2510 uac by sms

Motivation and Context

Need to update casev3 schema to add in sms_template and fulfilment_survey_sms_template tables.
What has changed

Added in sms_template and fulfilment_survey_sms_template tables.
Added patch script

How to test?

Run patch script and see if it creates tables.

Links

Trello
Screenshots (if appropriate):

 Prototype: Send a UAC by SMS by API (13)


Including the ninth digit of Brazil in DDD's 31, 32, 33, 34, 35, 37 and 38 (State of Minas Gerais). 71, 73, 74, 75 and 77 (State of Bahia). 79 (State of Sergipe)

This change is insufficient for the desired effect. It only changes formatting, but not validation (see the mobile pattern).
We are already working on this, and it should be out in the next release.

Thank you for your response, I await the next release :)

@dlyongemallo Could you please give us a reference of the method (file) that validates the mobile pattern? We use google-libphonenumber in our project and this modification is kinda urgent to us (I'm asking because we would like to try to work on this issue until the next release comes, due to the urgency of the project).

See this commit:
https://github.com/googlei18n/libphonenumber/commit/7c2de0119cd461c90bd37b59b9bb317c05a56bef

Many thanks, @dlyongemallo!

@dlyongemallo When the new release including Brazil changes will be released?

@dlyongemallo I'm a bit worried because the Brazil (ANATEL Government Agency) will insert this new digit in a lot of cellphone numbers on the next weekend.

The release of the next version should be taking place this week.

This was just released in 7.1.0.


It doesn't work for s10

It doesn't work for s10.

It doesn't work for s10.

It has been 9 months since the last update. Will try to take a look later if i have some free time.


chore: run bdd tests no longer run on separate agent

The current agent 'nixos-mayastor-pytest' is no longer available
as the node upon which it resides is being repurposed
as a "hypervisor" node

bors try

bors merge


Route extension typings

Issue description
CDNRoutes on API v10 has functions that return routes where most of them take a file format as a parameter (png, jpeg, etc.). The downside that this has caused is that the typings for them result in their return types being large template literal union types - one for each format possible. This not only makes it harder for those using these functions to quickly comprehend what will actually be returned from a given function, however it also from what I can see makes more work for those maintaining the typings for CDNRoutes - having to make sure the comment, allowed formats, and union return types are all in sync. I think this can be done better.
My proposal is to utilize generics for each of these CDNRoutes functions, which drastically reduces the amount of actual content needed to complete and maintain the typings for each function, and also makes for a smarter template literal return type which mutates based on the format specified - thus making for a better experience for those using these functions from my point of view.
I'm more than welcome to hearing others' thoughts on this and opening a PR assuming there's no issues with this that others are able to point out.
As a side note, the CDNRoutes storePageAsset function is implemented incorrectly. Its own comments as well as Discord's documentation specify that it supports the PNG, JPEG, and WebP extensions, yet it's written to only return a PNG extension with no option to specify which available one to use.
Code sample
// Current behavior
import { CDNRoutes, ImageFormat } from "discord-api-types/v10";

CDNRoutes.emoji("id", ImageFormat.PNG);
// Return value typed as `/emojis/${string}.jpeg` | `/emojis/${string}.png` | `/emojis/${string}.webp` | `/emojis/${string}.gif`

// Ideal behavior
import { CDNRoutes, ImageFormat } from "discord-api-types/v10";

CDNRoutes.emoji("id", ImageFormat.PNG);
// Return value typed as `/emojis/${string}.png`

Package version
0.37.61
Runtime
Node.js
Runtime version
v18.17.0 (TypeScript v5.2.2)
Priority this issue should have
Low (slightly annoying)

You're free to open a PR for this, as long as it still keeps the strict type for the formats and only allows actually allowed types 👀

Thank you! I noticed the strict format types that were set for each of them when digging into this and I'll be sure to keep those same boundaries.


GAMS is not registered correctly in show-versions

Code sample or context
Recently, @behnam-zakeri tried to install message-ix again on a new Linux machine. The process went fine by creating a new virtual environment via virtualenv and virtualenvwrapper and we made sure that the directory for gams is in $PATH. This can be confirmed by running gams on the system; it seems to work both from the command line and as part of the westeros_baseline tutorial from message-ix. However, running

message-ix show-versions

tells us that 'gams' is not in PATH. Since everything else is working fine, my expectation is that this is due to an issue with the way that ixmp tries to find gams, not about the installation per se.
We should note that the Linux machine was not a fresh install. Things like pip and virtualenv or even venv were missing, which seems odd.
Expected result
message-ix show-versions, which is internally using https://github.com/iiasa/ixmp/blob/d202e019204e6cf979df6f2a827322a00dbd1957/ixmp/model/gams.py#L18C1-L50C20 should find the correct version of gams.
Problem description
It doesn't seem to find it at all.
Versions
@behnam-zakeri If you can edit this description, please add the output of message-ix show-versions here. Otherwise, please just paste it down below.
Output of ixmp show-versions
<!--
Run one of the following and paste the results here:
- 'ixmp show-versions' in a terminal, or
- 'import ixmp; ixmp.show_versions()' in a Python interpreter.
-->

One way to debug this is to put for instance:
    print(os.environ)

    # Execute, capturing stdout
    output = check_output(
        ...
    )

    print(output)

…around the subject code.
Setting PATH can have some subtleties. For instance, if setting the value in .profile or a similar file, the value will appear in all new terminals opened after that addition. But if one has a terminal open prior, and does not do anything in it, then its prior value of PATH is not automatically updated.


Add a bunch more strings

Boolean keywords. Numeric constants in funny formats. More kinds of XSS. Malformed URIs. Very longs strings to overflow buffers. The empty string.

Please remove the 1000+ character strings and I'll merge.

Not having any long strings seems like a mistake; that is something that generally needs testing. What if the long strings were machine-generated from the txt_to_json.py, rather than inline in blns.txt?
(The file is going to be hard to view no matter what. In fact, the first text editor I tried crashed on some of the unicode.)

The intent of the list is to hit edge cases. Long text in itself is not an edge case.  (For smaller forms, like email and names, long text may be more of an issue; however, 100+ characters is more than enough to hit validation issues there. )

The first text editor I tried crashed on some of the unicode

Apparently the author is not testing against naughty strings :)


Iterator improvements

Renames word_iter to words to follow convention in the Rust ecosystem, and to add the word_indices method as word_indices_iter is too long.
Adds a new method to iterate over the word indices as it can be useful for some cases.

Hmm, I'd prefer not to make a breaking change here. Also I thought it would make sense to have words() -> Vec<&'static str> but I might agree that an iterator is more suitable.
I don't know why anyone would want the word indices, but I definitely accept that addition.
Can I ask to either make a new MR with only the non-breaking change, or maybe add a deprecation message on the original words_iter method so that this is not a breaking change.

@stevenroose I've added back word_iter along with a deprecation note.

I don't know why anyone would want the word indices, but I definitely accept that addition.

Mainly to encode SeedQR which uses the word indices to take advantage of QR numeric encoding.
Thanks for the review


vue-router current path invalid for a short time when loading async component

Version
3.0.3
Reproduction link
https://codesandbox.io/s/y32jkmjr7v
Steps to reproduce
Using vue and vue-router, create a route that requires a component (componentAsync) that is async loaded from the main component (componentApp).
Do something that uses router.push or router.go inside of mounted() of the componentApp without a path or name.
For example, router.push({query: { test: 'foo' }})
The redirected route will just use path: '/' instead of the actual path you used to initially hit the page.
For example, if you hit domain.com/about, you will wind up at domain.com/?test=foo, instead of domain.com/about?test=foo
What is expected?
vue-router would use the current window location
What is actually happening?
vue-router is using /

This is because the async component makes the confirmTransaction callback take longer than the mounted() call to router.push, so the route inside router is still the one with the wrong path.

This is working as expected, we need to wait to fetch the component for guards.
Use onReady to make sure code is executed when the router is ready:
this.$router.onReady(() => {
      this.firstName = this.$route.name;
    })

Thanks for the review. I disagree with the reasoning, as a developer, I would not want to have to think about additional criteria. I want to just be able to say $router.push(), not "Can I say $router.push yet, or do I need to wait for onReady"? This means potentially I need to wrap any $router.push inside of a onReady() if I want to be 100% safe, which just seems... lame

it's because you are doing it outside of a view component, in the main App which is mounted right away, so it's normal, we cannot delay mounting App

Sure, but https://github.com/vuejs/vue-router/pull/2704/files#diff-cae914e458ed0158d4acf96517a2e39bL52

the starting route that represents the initial state

may as well actually reflect the real starting state (window.location.pathname) instead of just /

Same very annoying problem. The current route is still invalid for a while, even after the execution of the beforeEach hook

Well apparently you can delay mounting the app without any issue
Vue.use(router);

const v = new Vue({
  router,
  render: //...
});

router.onReady(() => {
  v.$mount('#app');
});

Just don't wrap the new vue or the router will never be ready and none of the code will run


Bundle Javascript

A step towards solving #12.

[ ] Store generated bundle directly in the sdist directory, not in the source tree.
[ ] A cleaner way to run the bundle (perhaps when generating the bundle directory in the sdist directory, call it index.js).
[ ] Maybe another approach, as there is a warning - use alternative tool, or resort to caching dependencies instead.⚠ Warning: `deno bundle` is deprecated and will be removed in Deno 2.0.
Use an alternative bundler like "deno_emit", "esbuild" or "rollup" instead.

There is a deno vendor command to grab remote dependencies but I haven't test if works with workers.


error or other example?

File: engine/getstarted/step_four.md, CC @mstanleyjones
Hello!, in Step 2 and 4 seem to be the result of the same run but the 3 seems to be another run.
Step 2: Successfully built c2c3152907b5
Step 3: Successfully built success 7d9495d03763
Step 4 (docker images):
Docker-whale latest c2c3152907b5 4 minutes ago 275.1 MB
It is not clear whether step 3 is a sequence of 2 or it is a separate example

#dibs for the hackathon

This topic no longer exists. @jpooler still gets the points for #2832.


two heads inputs embedding layer and classification class supports

In this PR, I mainly implemented a two-head inputs embedding layer that support inputting two series of text and concatenate embedding vector of each to form a tensor ready to pass to the model.
Accordingly, I modified the classification.base_model to support dealing with multiple series of x_data during the preprocessing and data generation sections.
Not consider the situation of seq2seq labelling task yet.

Looks good, But I think we should add some unit test before merge this pull request.

Indeed. I used these pieces of code in my own project and they just worked well. But I've not finished their unit test yet. I guess I've changed some interfaces of these related methods, so that the unit tests failed.


GH-3781 add namespace validation

GitHub issue resolved: #3781
The NamespaceController is now validating the prefix and namespace before updating it.
For the namespace validation I used a regex which is based on the one from OWASP. Just added the char # and removed the (mailto:|news:) part.

PR Author Checklist (see the contributor guidelines for more details):

[X] my pull request is self-contained
[X] I've added tests for the changes I made
[X] I've applied code formatting (you can use mvn process-resources to format from the command line)
[X] I've squashed my commits where necessary
[X] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

By the way: thanks for picking this up @patrickwyler! Let's discuss how to improve this fix further.

I think it's ready for the final review @jeenbroekstra.

Nice work @patrickwyler - looks good to me! I'll hold off on merging because I think @hmottestad may want to do some cleanup with some other PRs first, but good to go otherwise.


Unable to delete user

It doesn't seem like there is a way to delete users that have been removed from the OIDC endpoint?
Am I missing something obvious?

No, you are right. There is no functionality to remove users. You need to disable user on the IDP. We have an IDP sync feature in the roadmap for future releases.

Thanks! Do you want me to close this issue (and link to a different issue?) or leave it open?

Lets leave it open @a7g4 when we add the function we will close it automatically

Done in
https://github.com/netbirdio/dashboard/pull/184.
Though it is not possible to delete a user - just block.


The forward contains irrelevant attributes.

https://github.com/Cadene/pretrained-models.pytorch/blob/8aae3d8f1135b6b13fed79c1d431e3449fdbf6e0/pretrainedmodels/models/fbresnet.py#L152
In fbresnet.py,the forward method contains irrelevant attributes.
self.conv1_input = x.clone() in forward is not used,  What is the function of this attribute?

您的邮件已收到!


[#157737884] Set broker basic auth credentials from the environment

What
See commit messages for details.
How to review

Code review
Run make unit
Check integration tests pass in the build CI.

Who can review
Anyone but me.

I've added a commit for pulling the cloud configuration from the environment.

I've added a commit to standardise the returned credentials to what the CF docs recommend: https://docs.cloudfoundry.org/services/binding-credentials.html

Merging this (@henrytk has given my additional commit a once-over)


[iOS] Build is failing with 'React/RCTDefines.h' file not found

We have a successful build of an app using ExpoKit. Trying to add this module had various issues we have solved, but we cannot get past this one.
Your Environment

Plugin version: master branch + PR #101
Platform: iOS
XCode: 8.3.3
React Native version: https://github.com/expo/react-native/archive/sdk-20.0.0.tar.gz
Link to your project: https://bitbucket.org/fredyc/tracker/src/9cff22e83aa7c4376a36eca2aace0a5300e1f34c?at=ios

Context
I am totally unsure what's going on here. From my basic understanding when RCTBrdigeModule.h is looking for <React/RCTDefines.h> and that file is in there, it should find it. Obviously, I don't know anything about this so I am fishing in a dark here :)
Actual Behavior
In file included from /Users/ci/agent/vstsagent/_work/1/s/node_modules/react-native-mauron85-background-geolocation/ios/RCTBackgroundGeolocation/RCTBackgroundGeolocation.m:9:
In file included from /Users/ci/agent/vstsagent/_work/1/s/node_modules/react-native-mauron85-background-geolocation/ios/RCTBackgroundGeolocation/RCTBackgroundGeolocation.h:10:
../../react-native/React/Base/RCTBridgeModule.h:12:9: fatal error: 'React/RCTDefines.h' file not found
#import <React/RCTDefines.h>

Steps to Reproduce
You can probably just clone the project, switch to ios branch, yarn install and then try to build it in XCode.
Debug logs
logs_15.zip

Notice: this issue has been closed because it has been inactive for 74 days. You may reopen this issue if it has been closed in error.

@mauron85 No, it's not really possible to reopen... It's inactive because you are kinda inactive ;)

That message was auto generated by script. So don't take it personally. Message was general. Feel free to reopen ;)

I'm not familiar with Expo. But I tell you what I know. Maybe it will be helpful.
So bit of history.
Starting React 0.40 facebook decided to namespace of all ios headers with "React/" prefix.
The reason to do so, was to make it work with their proprietary closed build system.
Qote from https://github.com/facebook/react-native/wiki/Breaking-Changes#040

This improves interoperability with FB's internal build system and makes it easier to use React Native in a mixed hybrid environment

If you ask me, I consider that as extremely selfish move from facebook side. But...
Plugin has been adjusted to be compatible with version prior 0.40 and also after.
Now the question is why it doesn't work in Expo. Can you tell me what version of react-native is Expo based on?

FIY: repo is not available anymore

@mauron85 I am sorry, I was kinda teasing you here since you were rather unresponsive in the past. Thank you for responding. I am no longer using Expo, but using your lib (with my fork) successfully in pure RN app, so thank you for making it. I am closing it again :)


Allow log out / add another channel for sync

Right now you need to clear cookies or start a new session to add another channel.

Not sure what the scenario is where this happens, but I've seen it with a few creators now...when they click claim channel, it just keeps their own session and gives them whatever error they had, i.e. "playlist items not found". Clearing cookies/site didn't didn't work,so I'm not sure if a logout button would help either, but worth a try? Had to use incognito mode with a new session.


Fix UI glitches from PFv5

📝 Description
Fixing issues from the upgrade to PFv5 according to this document:
https://docs.google.com/spreadsheets/d/1WpnJnw4FcfG1xvk1QKdK1l9de33Qtc-al2mQl5J2CQU/edit#gid=1386834576

/retest

Hi @avivtur could you, please, mention explicitly which of the glitches this PR fixes? It would help us to review and test this PR much faster. Thanks! :)

Hi @hstastna
You can take a look at the doc added in the description and see in main branch the glitches, and compare it to this branch as there are many changes

/lgtm

/jira refresh


Some drive functionality doesn't work when mixing http and https

When running on the local server and trying to share, I get this error:

Refused to display 'https://drive.google.com/share?id=0B0T... in a frame
because it set 'X-Frame-Options' to 'SAMEORIGIN'.

This version of colaboratory is no longer supported, please switch to https://colab.research.google.com.


Revert removed domains

git diff 38c0c74 HEAD | grep -e '-- '

Thank you so much Alexandr!

@Bishop I pushed v1.1.9 to rubygems with this fix so you know


view passenger map slow/sometimes not loading

The passenger map is slow and sometimes not loading

there is a second bug...
-open the route map.
-left screen
-open routes -> map is not loading until went back to rout map and click close.... Now map is loading correct from the routes page


clear containers: add to e2e test

Why? To make sure it doesn't break :)

Also if this one is already in the e2e then we don't need this: https://github.com/Azure/acs-engine/blob/master/examples/e2e-tests/kubernetes/kubernetes-config/clear-containers.json
Just making sure.


BackAndroid/BackHandler Event Listeners are not Triggered when set in a Modal's Child Component

[X] I have reviewed the documentation
[X] I have searched existing issues
[X] I am using the latest React Native version

I am unable to set event listeners using the react-native BackHandler in a component that is placed inside a modal. I suspect that this happens because the modal is listening to the method that is passed on the onRequestClose prop.
Well, I am not sure if this is a bug or a feature request but I would suggest that you allowed us to pass a certain value (e.g null) to the onRequestClose prop as a way of flagging that there might be BackHandler event listeners being set in the Modal's child components, and that these listeners have priority (i.e override the onRequestClose of the Modal).
Environment
Environment:

OS: macOS High Sierra 10.13.3
Node: 9.2.0
Yarn: 0.24.6
npm: 5.6.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4408382

Packages: (wanted => installed)

react: 16.2.0 => 16.2.0
react-native: 0.53.0 => 0.53.0

Steps to Reproduce
Below there is the instructions  inside the child component:
class ChildComponent extends Component {
  componentDidMount () {
    BackHandler.addEventListener('hardwareBackPress', this._onBackPress)
  }

  componentWillUnmount () {
    BackHandler.removeEventListener('hardwareBackPress', this._onBackPress)
  }

  _onBackPress = () => {
    console.log('Event was triggered')

    return true
  }

  render () {
    return (
      <Text>{'Some Text'}</Text>
    )
  }
}

export default ChildComponent

The component that has the Modal (parent) has the following instructions:
class ParentComponentWithModal extends Component {
  constructor (props) {
    super(props)
    this.state = {
      modalVisible: true
    }
  }

  render () {
    const { modalVisible } = this.state
    return (
      <View>
        <Modal
          visible={modalVisible}
          onRequestClose={() => console.log('onRequestClose')}
        >
          <ChildComponent />
        </Modal>
      </View>
    )
  }
}

export default ParentComponentWithModal

Expected Behavior
The _onBackPress method added to hardwareBackPressed listener should be executed when the back button is pressed.
Actual Behavior
When the back button is pressed, the function defined on the onRequestClose prop is triggered. Even if no function is defined on the onRequestClose prop, the methods attached to the event listeners defined in the modal's children are not executed.
As I am unsure if this issued should be posted here just on StackOverflow, I will also create a post there.

@dauane can you check if my PR #19077 helps here?

Apologies for the late response @jerolimov. I'll check it out and get back to you.

I have the same problem. If i register the EvenListener in a Modal Component I won't trigger.

Having the same problem, the event listener is not mounted within the modal component but the modal being displayed seems to completely block the event listener function from being called

1

I have similar issue as well

We've faced the same issue using react-native-router-flux. The solution was that we implemented back handling in our router instead the component where it was needed. Works like a charm, sadly can't provide solution for different navigations.

This is documented but I'm not sure why it's implemented that way:

onRequestClose
The onRequestClose callback is called when the user taps the hardware back button on Android or the menu button on Apple TV. Because of this required prop, be aware that BackHandler events will not be emitted as long as the modal is open.

@Abhishekgarg727 onRequestClose you need to put the same method to close


Create About Content

The app needs to display its version, along with other content.
Definition of Done
The following tasks need to be completed.

[x] displays version
[x] provides link to source code
[x] provides link to releases
[x] describes features
[x] support paths
[x] collaboration how-to

Tech Notes
Implement the AboutView and TermsOfServiceView as wrappers to display markdown content in a popup dialog.

Done. Pasted markdown into code. Needs to be integrated into the app.

Done. Pasted markdown into code. Needs to be integrated into the app.


Error: workspace folders from different providers are not allowed

Extension 'Remote FS' failed to update workspace folders: Error: Workspace folders from different providers are not allowed in the same workspace.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Start vscode-insider
Ctrl+Shift+p -> "Remote-WSL: New window"
Open Folder in Explorer (Ctrl+Shift+E), choose any...
Ctrl+Shift+P -> Remote FS: Add Folder to Workspace -> choose...
See error:
"Extension 'Remote FS' failed to update workspace folders: Error: Workspace folders from different providers are not allowed in the same workspace."

Desktop (please complete the following information):

OS: Windows 10 with WSL (Ubuntu 18.04)
VSCode Version 1.41.0-insider
Version: 1.41.0-insider (user setup)
Commit: bbf00d8ea6aa7e825ca3393364d746fe401d3299
Date: 2019-12-05T06:56:28.532Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.17763
Extension Version Remote FS 0.0.15 - 2019-04-27

I swear it worked for me before


Generate common query parameters from the REST spec

Closes #2541

This looks good to me but mind splitting up the code changes to the generator with the generator output?
Will make it easier not to include the breaking changes from master to 5.x

@Mpdreamz good call, I've updated the PR.  I'll port to 5.x once ES 5.3 drops (since the _common change didn't make it into 5.2).

Merged to master and 5.x.  I did not update the spec on 5.x just yet though.


Update Globals “site_data”

Automatically generated by Netlify CMS

👷 Deploy Preview for thunderous-brigadeiros-23902d processing.

Name
Link

🔨 Latest commit
d0c0d313c49cb87f3fda0372f852a16a5549d92c

🔍 Latest deploy log
https://app.netlify.com/sites/thunderous-brigadeiros-23902d/deploys/6331bb2962e91b00094ce62c


Run dotnet-format

PR Summary
Reformat code according to EditorConfig rules.
The following rules were temporarily disabled as they resulted in a high number of changes:
dotnet_sort_system_directives_first = true
csharp_preserve_single_line_statements = false
csharp_new_line_before_open_brace = all

PR Context
Follow-up: #11681
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[NA] Experimental feature(s) needed

[NA] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[NA] Documentation needed

[NA] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[NA] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@adityapatwardhan CodeFactor violations are fixed.

Build failures are due to PowerShell Gallery unavailability, see #13946.


Translation dutch

When the mower is "mowing"  the result state is in dutch "reinigen" . That means cleaning.
It should be "mowing'

Hello,
Thx for the feedback, are you talking in Home assistant ?

Sorry it should be "maaien" instead of "reinigen"
Yes its in Home Asistant.

I have the same in english, it says: "cleaning" instead of mowing

Its because the mower is actually seen as vacuum cleaner in HA, HA has no
mower class. Hence cleaning instead of mowing :)
On Tue, 15 Jun 2021 at 13:18, jeremycoppey @.***> wrote:

I have the same in english, it says: "cleaning" instead of mowing
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/py-smart-gardena/hass-gardena-smart-system/issues/63#issuecomment-861449912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZVQ2C2NAHEBRC3LHGSLKTTS5AJ3ANCNFSM43OTKLIA
.

Indeed, i am planning to create a mower component instead of vacuum and it should work in it !
Jeremie

@grm I think this is actually possible to handle just with translations, the characteristics of mower and cleaner are the same except for the wording, so maybe just a translation can handle this?


Refactor to enhance code quality

Description
Addressing multiple concerns, such as consistent naming conventions, splitting long functions, adding type hints, improving variable names, breaking down large functions, proper code formatting, and using f-strings can greatly enhance the code quality.
Example Improvements
In the extract() function, rename spattern and tpattern to source_pattern and target_pattern for better readability. We could refactor the convert() function to separate the handling of part matches into a dedicated function.
Could I be assigned to this issue to tackle these improvements comprehensively?

Did you fully understand the codebase?

Hi @B-R-P, thanks for the response. I probably don't understand the codebase as in-depth as yourself and the other contributors. What I was really getting at with this issue is suggesting that a modular approach to the functions and classes in separate files would make it easier to maintain and contribute too. Or did you want to keep a single LangTrans.py file?

I want it as a single file for now. I am assigning you (@thatvideoshopguy) to improve the code, as you mentioned above.

Use docs to better understand the code and feel free to ask me if you have any questions.


Getting terminal prompts disabled error when cloning a new repo

$ scalar clone https://office.visualstudio.com/DefaultCollection/<...>
Skipping GVFS protocol check...
Fetching objects from remote...
Failed

Cannot clone @ /Users/sameer/enlist/<...>
Error: Failed to complete regular clone: fatal: helper error (255): Interactivity is required but has been disabled.
fatal: could not read Username for 'https://office.visualstudio.com': terminal prompts disabled

Had to manually run a git clone to complete the auth, and then ran scalar clone again to make it work
OS: Mac Big Sur
$ git version
git version 2.28.0
$ scalar version
scalar <IP_ADDRESS>

Both git and scalar are installed using homebrew

Hi @sameeragrawal I'm sorry you're having this problem.
Have you tried installing microsoft/Git-Credential-Manager-Core using homebrew?
$ brew cask install git-credential-manager-core

I believe we have tested this case in particular, but it might not be set up correctly for the default helper.

I just checked, and #439 should have fixed this. If it did not, then we need to go back and try again.

Can you help with the build number where this was released? my scalar version is listed above.
Also, checked that git-credential-manager-core was installed as part of scalar installation itself
$ brew cask install scalar
==> Downloading https://github.com/microsoft/scalar/releases/download/v<IP_ADDRESS>/Installers_macOS_Release.zip
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/201114820/f58ca200-13a8-11eb-9782-816a88aa779f?X-Amz-Algorithm=
######################################################################## 100.0%
==> Installing dependencies: git-credential-manager-core
==> Downloading https://github.com/microsoft/Git-Credential-Manager-Core/releases/download/v2.0.280-beta/gcmcore-osx-2.0.280.19487.pkg
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/158405551/63cd4f00-1d2f-11eb-851c-e10ec4fda036?X-Amz-Algorithm=
######################################################################## 100.0%
==> Verifying SHA-256 checksum for Cask 'git-credential-manager-core'.
==> Installing Cask git-credential-manager-core
==> Running installer for git-credential-manager-core; your password may be necessary.
==> Package installers may write to any location; options such as --appdir are ignored.
Password:
installer: Package name is Git Credential Manager Core
installer: Installing at base path /
installer: The install was successful.
🍺  git-credential-manager-core was successfully installed!
==> Verifying SHA-256 checksum for Cask 'scalar'.
==> Installing Cask scalar
==> Running installer for scalar; your password may be necessary.
==> Package installers may write to any location; options such as --appdir are ignored.
installer: Package name is Scalar
installer: Installing at base path /
installer: The install was successful.
🍺  scalar was successfully installed!
$

@sameeragrawal could you clarify some things about your environment while we wait for @mjcheetham to wake up and take a look?
Specifically:

What command-line tool are you using? Terminal?
Is there anything custom about your environment? Are you using SSH or something?

I am using Mac's default Terminal app.
I am remotely connected to the Mac using Remotix NEAR

@sameeragrawal, can you try running the scalar clone with the following environment variable set?
GCM_TRACE=/Users/<user>/Desktop/gcm.log scalar clone https://office.visualstudio.com/DefaultCollection/<...>

..where <user> is your username, and reply with the output of the trace log?
:warning: Please redact any private information such as URLs from the output before posting! Secrets/passwords should already be masked but please double check on URLs and file/usernames.
Thanks!

$ scalar clone https://office.visualstudio.com/DefaultCollection/<...>
Skipping GVFS protocol check...
Fetching objects from remote...
Failed

I should have noticed this earlier, but the Skipping GVFS protocol check message is because...

$ git version
git version 2.28.0
$ scalar version
scalar <IP_ADDRESS>

Your Git version doesn't include .vfs., so it cannot communicate via the GVFS protocol. If you intended to use the GVFS protocol, then...

Both git and scalar are installed using homebrew

Did you specifically brew cask install scalar-azrepos? That downloads our custom version of Git which will enable the GVFS protocol.
The GVFS protocol check will authenticate for you before we get to the fetch, so if you fix your Git version you should be unblocked.
We still have a bug in Scalar that doesn't allow for interactive auth, and we will remedy it. You should just be able to get unblocked without needing a new release.

@derrickstolee No, I did the install scalar, and was using the git already installed on machine via homebrew.
I did not intend to use GVFS version.

@mjcheetham I tried that, but after scalar clone shows the failure, no gcm.log is generated.


Placeholder

Hi.
Is there a way to avoid the placeholder?
I tried the following:
appModule.config(function(datetimePlaceholder){     angular.extend(datetimePlaceholder, {         year: "",         month: "",         date: "",         hour: "",         minute: ""     }); });
And I got the following error:
Error: InputMask.digest crashed! Infinite loop on 08:55     at InputMask.digest (http://localhost/tellware/libs/angular-datetime/custom-input.js:470:27)     at InputMask.initialize (http://localhost/tellware/libs/angular-datetime/custom-input.js:371:26)     at new InputMask (http://localhost/tellware/libs/angular-datetime/custom-input.js:226:23)     at Object.linkFunc [as link] (http://localhost/tellware/libs/angular-datetime/datetime.js:114:14)     at http://localhost/tellware/Scripts/angular.min.js:16:230     at ia (http://localhost/tellware/Scripts/angular.min.js:81:35)     at n (http://localhost/tellware/Scripts/angular.min.js:66:176)     at g (http://localhost/tellware/Scripts/angular.min.js:58:429)     at g (http://localhost/tellware/Scripts/angular.min.js:58:446)     at g (http://localhost/tellware/Scripts/angular.min.js:58:446) <input class="form-control ng-pristine ng-untouched ng-valid" id="fechaMaximo" type="text" name="maximo" ng-class="edited" ng-model="vm.campo.calendario.maximo" ng-pattern="vm.mascarasFecha[vm.campo.calendario.tipo].pattern" placeholder="{{vm.mascarasFecha[vm.campo.calendario.tipo].placeHolder}}" ng-maxlength="vm.mascarasFecha[vm.campo.calendario.tipo].maxLength" datetime="{{vm.mascarasFecha[vm.campo.calendario.tipo].datetime}}">

Currently the parser tests the placeholder first, so an empty placeholder makes it never match.
https://github.com/eight04/custom-input/blob/master/lib/text-parser.js#L24-L29
I'll take a look on it these days.
TBH, I think this directive looks pretty confusing without a placeholder.

Fixed in 5.1.0 with custom-input 0.2.0.


Disallow passing non integer indices to jax.nn.one_hot

When evaluating the expression jax.nn.one_hot(jnp.array([0.2, 1.2, 2.]), 3),
the result is
Array([[0., 0., 0.],
       [0., 0., 0.],
       [0., 0., 1.]], dtype=float32)

because the first two indices are not integer, so will not match any coordinates.
Would it be worthwhile  to raise an error when the indices argument is not an integer type, to prevent silent errors in case someone forgot to cast their indices?

Thanks for pointing this out – I think you're right that it would make sense to require input indices to be integers, particularly given the confusing behavior when non-integers are supplied.

So I've dug-in a bit and this is not going to be a straightforward change: there are many downstream users of this utility who pass in floating-point values, some very deliberately (e.g. using NaN as a marker of rows for which there is no "hot" index).
Even if we were to fix these explicit cases, there is a chance that changing this behavior would change production models that implicitly rely on the current behavior.
Given that, I'm thinking that the more reasonable way forward would be to document and test the behavior of this function for non-integer inputs, without changing the function's behavior. What do you think?

That's true that this would definitely be a breaking change (and one that I imagine is quite hard to fix automatically, given that whether or not casting will change anything depends on the value contained in the tensor). I guess the NaN usage could be replaced by using negative values for the same behaviour, but other use-case may not be as straightforward.
Flagging the problem in the documentation sounds like a good compromise :)


Fix unwanted omitting events right after commented lines

I work with [tootsuite/mastodon] streaming API.
Sometimes IKEventSource ignores events.
The case is where an event is placed right after :thump\n (commented line). for example this event will be ignored in parsing events:
:thump
event: update
data: {"id": ... }

This PR removes these comment lines before parsing event structures.

Codecov Report

Merging #75 into master will increase coverage by 0.36%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   84.66%   85.03%   +0.36%
==========================================
  Files           8        8
  Lines         587      588       +1
==========================================
+ Hits          497      500       +3
+ Misses         90       88       -2

Impacted Files
Coverage Δ

EventSource/EventSource.swift
94.64% <100%> (+0.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abb76f...1fee6eb. Read the comment docs.


[standalone][ibm_vpc] avoid docker pull or load if runtime installed in the custom VM image

…ged with runtime
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@JosepSampe This PR about - if custom image already contains runtime image in the Docker, this prevents docker pull <runtime> and greatly improve times when many VM backends created and each need the runtime image.

@JosepSampe This PR about - if custom image already contains runtime image in the Docker, this prevents docker pull <runtime> and greatly improve times when many VM backends created and each need the runtime image.

@JosepSampe I just fixed the comment. Ok to merge?

@JosepSampe I just fixed the comment. Ok to merge?

@gilv ok, go ahead ;)

@gilv ok, go ahead ;)


Flatbuffers serialization issue of 0 integers

flatbuffers serialize integer zero as 1 byte value which then fails deserialization on server which expects int32 to be 4 bytes
Check Schema whether int type serialization can fix this

will be moving to catbuffers sooner than later so this is not needed


Issue template second try

This PR is a follow up for https://github.com/SalesforceCommerceCloud/pwa-kit/pull/209. We made a mistake that we placed the issue templates in the wrong folder, and github can't find the issue templates.
We put issue templates in .github/ISSUE_TEMPLATES where as the correct folder is .github/ISSUE_TEMPLATE

LGTM


Possible scope typo?

Current coverage is 89.88% (diff: 100%)

Merging #38 into master will not change coverage

@@             master        #38   diff @@
==========================================
  Files             2          2
  Lines           267        267
  Methods          57         57
  Messages          0          0
  Branches         40         40
==========================================
  Hits            240        240
  Misses           27         27
  Partials          0          0

Powered by Codecov. Last update b5d15c1...0b43a4f

Thanks a lot! Good finding.


Add coverage reporting, small updates in README

This PR was reverted and redone in a (very similar) PR #7


Remove readline from lua

The cernan use-case for lua is one that does not use readline. On
systems that attempt to statically linked cernan against MUSL libc the
readline dependency breaks the build on account of the difficulty of
building readline in that environment. I could not determine if there
were a cleaner way to disable readline other than but permanently.
That is, maybe this approach is a hack.
I think disabling readline is okay here as the focus of the library
appears to be the use of lua in a purely embedded environment.
Signed-off-by: Brian L. Troutwine<EMAIL_ADDRESS>

I think readline is only used for the lua command-line interpreter, right?

@sagebind That's my understanding, yeah. I went through the C source to confirm and believe that to be correct.


[wip] Attempt to fix build

Hmm, @samphippen (given you're way more active with rspec-rails than I) what do you want to do about the cucumber segfaults, we can't update cucumber, we're on the last version supporting 1.8.7 anyway

@JonRowe if this is still relevant I can take a look at it. Is this still a thing?

We still need to fix the 1.8.7 build so yes? I've added a commit which skips cucumber on 1.8.7 which should help.

A wild green Rails build appears! This is just skipping the acceptance on 1.8.7 though, @samphippen and @myronmarston how do you feel about this? I think given that 1.8.7 is so EOL and this only affects Rails 3 I'm ok with it, we're still running unit specs and confirming cross compatibility with the other gems and its unlikely any 1.8.7 specific errors will crop up here?

we're still running unit specs and confirming cross compatibility with the other gems and its unlikely any 1.8.7 specific errors will crop up here?

The problem is that the unit spec coverage in rspec-rails is pretty poor, from what I remember (although I haven't worked much in this code base), and the cukes do a much better job of coverage.
Also, 1.8.7 specific errors are very easy to do accidentally, e.g. wrong hash syntax or whatever.
Couldn't we just add a Gemfile.lock for 1.8.7 that contains all the gems that were working previously?

No the issue here is the segfaults, the gem versions haven't changed.

No the issue here is the segfaults, the gem versions haven't changed.

But what is different in the environment from when 1.8.7 builds passed?

Nothing as far as I know

OK. Ideally, it would be nice to just skip the part of the acceptance cukes that trigger this instead of all of them, but I'll defer to you and @samphippen on this.

I don't think its that predictable, I'm happy for this to be a temporary measure but I don't have the time to investigate any further and it'd be nice to get them as green as possible.

I don't think its that predictable, I'm happy for this to be a temporary measure but I don't have the time to investigate any further and it'd be nice to get them as green as possible.

:+1:


Add full support for subscriptions

Right now support for managing/consuming subscriptions is very experimental and not all-the-way implemented.  We should update the application so that it more concretely display how subscriptions are managed and consumed.

Hey there,
Wondering if there has been any progress made towards this issue? I've noticed the #create_subscription method in the documentation but am not sure if it is fully functional yet and if so how exactly to use it. Thanks!

Great question- I hadn't looked at these issues is a very long while. To my knowledge, create_subscription should work correctly now, so I'll close this issue. If, in using it, you find issues we can re-open a new one issue against a particular problem.


Drop obsolete params for Spring < 3.0.5 from Readme

I got curious with -Djdk.util.jar.enableMultiRelease=false and read through the linked thread - looks like the issue was fixed a good while ago.
Indeed, a test on my end showed that the property was no longer required.
I raised another PR in the pages-repo for the documentation changes there.

Thank you. 👍


Make rust crate name support "-" not replace with "_"

Make rust crate name support "-" not replace with "_"

by jjc.jclark.com:
The spec defines identifier like this:
identifier = letter { letter | unicode_digit }
where letter is _ or class Lu, Ll, Lt, Lm, or Lo.
This doesn't work for languages with combining characters (e.g. South and
South-East Asian languages).  For example, in Thai some vowels have
combining class Lo and some vowels have combining class Mn.
There's lots of details in
http://www.unicode.org/reports/tr31/
I would actually recommend using
http://www.unicode.org/reports/tr31/#Alternative_Identifier_Syntax
This keeps things simple and ensures that the definition of an identifier
is Unicode version independent.

What spec are you referring to? (I can't find any formal definition of legal crate names in the cargo book)
I believe the current hyphen and underscores behavior comes from https://github.com/rust-lang/rfcs/pull/940. It seems clear that we would've gone with a less weird system had we considered this issue from day one, but the argument that forcing several thousand hyphenated crate names to change is just not worth it seems pretty strong to me. Has anything significant changed since then?

@Ixrec I just want one more choice. There is no need to change other crate names.

@Ixrec I am done. You can close it. I know it won't be solved.


Rio terminal

Hey there!
Awesome theme, i would love to use on Rio terminal https://github.com/raphamorim/rio, is ok if I send a PR adding it?

Hi @raphamorim , thanks. Sure, you can send it 💜


Fix the HTJ2K and other builds

There were a number of issues with actually being able to build and deploy the open jph library.  These are nto entirely resolve, but seem to be getting closer.

@jmhmd - this build setup allows building from the codec directory, but it is producing somethign different from what you checked into the cornerstone wado image loader branch - could you take a look and see if you can figure out what is going on here?

I'll take a look when I get a chance. I had just copied the pre-built files from Chris's repository because I was also having build issues I think due to some docker/M1 compatibility problems.


Updated per the triager conversation

We got overwhelmed with requests from Summit, this is to give the bot the way to stale out PRs that haven't been touched in 2 weeks.

Do'h fixed.


[exporter/limits] emit total and alloc job limits

I already collected and tested job submit limits, I just didn't export them yet.
resolves #90

lgtm ... thanks!


Agreement link changed

as of 15.nov 2017 link to agreement policy has changed,
old:
"https://letsencrypt.org/documents/LE-SA-v1.1.1-August-1-2016.pdf"
new link is:
"https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf"
due tu this certificate renewals fail with error 400
can you please update module acordingly?

This has already been fixed in https://github.com/diafygi/acme-tiny/commit/c4940d229a296b7643e86d2e9ab31a6e0099ba71


Infinite analyzing of airflow

I'm using apache airflow and beta version of a server takes infinite time to analyze it. (at least one night)

AIRFLOW_GPL_UNIDECODE=1 sudo -E pip3 install apache-airflow

@Yanpas , can you please enable full logging ("python.analysis.logLevel": "Trace"), copy log from output and attach it as a file to this bug?

Hm. I've disabled and enabled python ls (python.jediEnabled), it was redownloaded and seems like this version doesn't stuck.

Analysis of PyQt5.QtWidgets(Compiled) completed in 79379,6379 ms

Here is a log: https://gist.github.com/Yanpas/adc8a7bd00df8e6ae850d6a5bdfc9524

Thanks.
Yes, PyQt5.QtWidgets is a huge 5MB module, so its analysis is slow.

I do not import Qt anywhere, don't know why is it analyzed

@Yanpas See my comment here: https://github.com/Microsoft/python-language-server/issues/832#issuecomment-477688703

But library you do import may import other libraries which may end up importing Qt.


luci-base: add back the help.gif

The help.gif has been moved to luci-compat after 102124115d4c2e204bf4cf1ffafe1d8b304fd0df. But it is still used by the luci-theme-bootstrap and luci-theme-openwrt as the following codes. So we should add it back or also remove it form the themes.
https://github.com/openwrt/luci/blob/558525783cf33a986efa33d23f5283b33a6c936e/themes/luci-theme-bootstrap/htdocs/luci-static/bootstrap/cascade.css#L1928
Signed-off-by: brvphoenix<EMAIL_ADDRESS>

Somehow the commit looks strange.
I also get the following message.
This commit does not belong to any branch on this repository.
@brvphoenix Can you take a look at this again?

It is because I deleted the fork by mistake a few days ago. Although my fork has been restored, it seems that there are still something wrong in this pull.

I have made a new pull https://github.com/openwrt/luci/pull/4227.
@feckert


Constructor Unit Testing (For All Classes)

Working example in unit testing file for language class.

Language, Country, CIty, Capital City


Visibility of "Remove File" Button Based on Attachment Presence

Currently, the "Remove file" button is consistently visible, regardless of whether any attachments are present. This can lead to confusion for users, as the button implies that there is a file attached when there may not be.
To enhance clarity and usability, it is advisable to dynamically control the visibility of the "Remove file" button based on the presence of attachments. When no attachments are associated with the item, the "Remove file" button should be hidden to avoid any confusion or misleading impressions.

Also, when editing project, and there are no attachments:

Moved to https://github.com/HurasAdam/React-Django-Task-Tracker/issues


newScrollview - custom scroll bar fail

The custom scroll bar does not work as expected. The width of the custom bar is too small.
scrollBarOptions. The following in widget_scrollview.lua at 759 is incomplete. It should include values for frameWidth and frameHeight.
	-- ScrollBar options
	if nil ~= customOptions.scrollBarOptions then
	    opt.scrollBarOptions =
	    {
		    sheet = customOptions.scrollBarOptions.sheet,
		    topFrame = customOptions.scrollBarOptions.topFrame,
		    middleFrame = customOptions.scrollBarOptions.middleFrame,
		    bottomFrame = customOptions.scrollBarOptions.bottomFrame,
	    }
	else
	    opt.scrollBarOptions = {}
	end

Thanks for the report, we'll fix it soon.


Improve templates

Feature Request
Name: Improve templates like ISSSUE_TEMPLATEs and PULL_REQUEST_TEMPLATEs
About:
Here's some of the feedback I have so far. We can use this as a kind of tracking issue too.

Feature Request template asks for title and name. It feels slightly redundant. Maybe we remove the name requirement.
The markdown adds large "Feature Request" text to the issue. I think we maybe make that smaller. It feels like it takes over the content. I do think having "Feature Request" documented on the issue is smart.
There's probably room for issues that are useful but maybe not necessarily considered a "Feature". Maybe we need something else too? 🤔 I'll think this one over.

Maybe add the "Good first project" label?

Great idea.

Some more feedback
It looks like by indenting the Summary of changes section of PR templates it creates a kind of snippet.

I also usually use "Closes #[issue num]". This is more of a nit than anything else. It's pretty simple to just swap in "Closes" if that's your preference.


Gt/update erosion deposition

Removes the now-obsolete (under Landlab 2.0) passing of phi and erode_flooded_nodes arguments from those models that use the ErosionDeposition Landlab component, and the latter parameter from the one that uses Space. Modifies test files accordingly.

Awesome! Thank you @gregtucker 🎉 🦖
Looks like there is 1 failure on appveyor and that the travis builds have the same problem @mcflugen fixed here (landlab/landlab/pull/1183). I will take a more careful look tomorrow. If this is all that needs to happen for final 2.0 comparability that would be amazing!

It looked to me as if there might be some issues with changes to netCDF, but I didn't dig into those.

Yes. I just ran the tests and everything that remains is related to netcdf. I'll deal with (on this issue, since it won't run otherwise).

Pull Request Test Coverage Report for Build 1196

9 of 19 (47.37%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 99.377%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

terrainbento/derived_models/model_basicDdHy.py
1
3
33.33%

terrainbento/derived_models/model_basicHy.py
1
3
33.33%

terrainbento/derived_models/model_basicHyRt.py
1
3
33.33%

terrainbento/derived_models/model_basicHySt.py
1
3
33.33%

terrainbento/derived_models/model_basicHyVs.py
1
3
33.33%

Totals

Change from base Build 1174:
-0.6%

Covered Lines:
1596

Relevant Lines:
1606

💛  - Coveralls

if you type :+ it should autocomplete.
I'm going to add a test for the new warning and verify that this jives with umami. then on to making full 2.0 releases for both of them.

There it is: 👍

@gregtucker I believe I've addressed the netcdf issue.
In diagnosing it you found a bug in how internal iteration counter was incremented. However, that meant that the "truth" netcdfs were no longer correct (see inline comment, probably located above).
I fixed those reference netcdfs and my tests pass locally.

💯 👍


Add Layer::overlaps method and use it in count_deltas to avoid unnecessary image layer generation

refer #2948

For pgbench -i 1000 with subsequent 1000 seconds of updates  the difference in storage size is not so large:

main: 67GB
PR: 56GB

It is not so easy to reproduce behavior reported in #2948 (so that number of image layers is greater than delta layers).
I was able to get about 2 times difference with main using the following test:
pgbench -i -s 1000
pgbench -s 1000 -c 10 -M prepared -T 300 -P 10 -f update.sql

update.sql is the following:
update pgbench_accounts set abalance = abalance + 1 where aid=1;
update pgbench_accounts set abalance = abalance + 1 where aid=:scale * 100000;

main: 22GB
this PR: 14GB

Now we can pile up an unlimited number of deltas. The last lsn cache will help avoid false positives and locate the first relevant layer, but won't help finding the second relevant layer. It's a solveable layer map problem with some effort, but IMO the bigger problem is if we need to download any of these layers on demand. Doesn't feel good to not have any bound on how many layers need to be downloaded to serve a get_page if the layers are not on the pageserver. This was the whole point of compaction from the start: to make on demand download feasible. If we don't care about this we shouldn't be creating L1 layers at all, just use L0.

Now we can pile up an unlimited number of deltas. The last lsn cache will help avoid false positives and locate the first relevant layer, but won't help finding the second relevant layer. It's a solveable layer map problem with some effort, but IMO the bigger problem is if we need to download any of these layers on demand. Doesn't feel good to not have any bound on how many layers need to be downloaded to serve a get_page if the layers are not on the pageserver. This was the whole point of compaction from the start: to make on demand download feasible. If we don't care about this we shouldn't be creating L1 layers at all, just use L0.

Yes, I also thought about it.
But do not know some good solution at this moment.

But do not know some good solution at this moment.

I tried my method of changing the definition of L1 to mean "sufficiently dense layer", such that those 2 out of 10 sparse layers would get re-compacted. I somewhat prefer this approach to adding L2 layers (which was probably the original plan) because at least the L1 layers that come out dense from the start don't need to be compacted.
It was a 2 line change in LayerMap::get_level0_deltas but it caused some panics that I haven't investigated yet.

I do not think that this approach will really work.
First of all because it may lead to infinite compaction loop: layers produced by compactor will never meet "dense" criteria and will e once and once again added to L0 layers list until compacting them will take unacceptable amount of time.
Also, as I found myself with PR trying to limit layer's key range, it is hard if ever possible to find some reasonable key rage threshold. There can be just one big relation (i.e. 1Tb). But it key range will e just 256Mb (so not satisfying your criteria of sparse layer). But it can contain just one page of this relation. Fro the other side, there can be thousands of relatively small relation and splitting them in separate layers will lead to large number of very small layers. Also not good.
We have yesterday discussed this problems with @hlinnaka  and @shanyp
Followup is here:
https://docs.google.com/document/d/1GcmSW9_DXHou3tuezhjKyL2-ZNuxdRTAaKoi1BC08ns/edit
We decided that first step can be to add to layer map information about ranges, so it will be possible to perform fast lookup wihtout reading layer content from the disk. For our purposes storing ranges seems to be omre efficient than bloom filter.
But still unclear how much ranges can we keep in memory to avoid too much memory footprint of layer map.
So, summarizing all above: right now we can propose four different approaches for solving problems with image layers:

Reduce period when image layers are created. For example create them not after 3 but 30 delta layers. Improved layer map can be used to efficiently skip not relevant delta layer. To reduce reconstruction cost with can either store partia images, either rely on reconstructed page cache.
Force compaction of sparse layers. I think your approach can be improved by more pricese and sophisticated criteria of layer density (may rely on number of range stored in layer map for this layer)
When calculated number of delta layers as criteria of image layer generation, ignore layers not intersecting with target image layer key range (this PR). Once again, instead of accessing B-Tree for checking overlaps we can use ranges stored n memory.
Avoid creation of sparse deltas at all. Looks like key range is not good criteria.Detecting large "holes" seems to be better criteria. But I think we should  take in account not only content of delta layer, but also image coverage. I.e. if we have delta layers with few pages belonging to two relations, we should consider how large are this relations. If them are small, then there is no sense to try to split this delta layer.

Here's the effect on pgbench 10gb:

It's not the best workload to test this on, because I don't think this change has much effect on the random updates phase (top of the diagram). But at least we can see that layers are being created later than usual, and all at the same time. So the two long L1s at the bottom probably have large holes and are not affecting the image heuristic.
I don't know if there's a better way to test this than to deploy and see what happens. The cost is not that big (only log_2(10) increased pressure on the new layer map, not sure about current layer map).
Off topic: I don't know how to interpret all the layers on the right end of the key space. Something changed on main branch since fe8cef3427dcd5a2f2d8e96655e898d332859035. See for example: https://github.com/neondatabase/neon/pull/2995#issuecomment-1382293170 which is a PR branched from an older version on main and doesn't have those layers. I also see some 24KB L1 deltas now. There might be some regression on main

What would be the worst case workload to demonstrate the problem?

What would be the worst case workload to demonstrate the problem?

Worst case is probably synthetic uniform random updates. The top 10 holes wouldn't take up a big percentage of the range. But this seems adversarial, and in real workloads I'd expect that the top 10 holes would take up a significant percentage of the range.

What would be the worst case workload to demonstrate the problem?

Worst case is probably synthetic uniform random updates. The top 10 holes wouldn't take up a big percentage of the range. But this seems adversarial, and in real workloads I'd expect that the top 10 holes would take up a significant percentage of the range.

I meant, worst case to demonstrate the original problem that this fixes.

I meant, worst case to demonstrate the original problem that this fixes.

The bigger the database the worse it is. If we have 1TB database we will spontaneously create 1TB images once in a while even if compute is doing nothing but vacuum. We routinely see databases with 5-10x their size in useless images.
It's hard to reproduce this because of nondeterminism. But generally because we do a full reimage of the database once we get 3 batches of L1s that cover the entire key space, and most L1 batches cover the entire keyspace, 30-50GB of wal is (my guess) enough to trigger reimaging. But it can also trigger just from passage of time. We can periodically flush tiny L0s, then compact them into tiny L1s and reimage. We've also seen this in prod.

We could write a binary that we execute against a timelie on prod to download layer metadata: layer range + 100 largest holes.
This gives us enough information to run the count_deltas function (locally!!) for each image, and compute how many of those would not have existed with this PR. We can then fine tune the number of splits to create (IMO 10 is the right number, and 100 is also affordable after we pay the tech debt on layer map rebuilds)
Yes, all this testing is extra effort compared to just merging this, waiting a week and then looking at prod metrics, but IMO that local reimaging simulation would make a nice unit test anyway. We should be testing compaction/reimaging/gc/branching/upload/download in unit tests, just using metadata. There's an old issue for this assigned to me that I somehow got distracted from :) https://github.com/neondatabase/neon/issues/2031

Ugh...
Propagating everywhere RequestContext everywhere is really terrible.
Will be pleased if @problame  or @hlinnaka  can review if I did everything as expected.
Also this PR fixes two remote tests added by @hlinnaka - can you look at them please.

Just so the comment doesn't get lost in history:

I'm curious about results from at least one of these databases: https://neondb.slack.com/archives/C03UVBDM40J/p1674749418292749

these projects have potential for more than 50% images disappearing, and I'm wondering if that will happen

Just so the comment doesn't get lost in history:

I'm curious about results from at least one of these databases: https://neondb.slack.com/archives/C03UVBDM40J/p1674749418292749

these projects have potential for more than 50% images disappearing, and I'm wondering if that will happen

layer_map_analyzer is now merged and once it is installed at staging/prod it is possible to apply it to all projects=tenants

Sorry, which linear search do you mean?
Holes are stored in ascending order and binary search is used.
Or you mean that layer map will have to skip non-overlapping layers by  checking them one-by-one?
But number of delta layers between image layers should not be large. Ideally 3 but even in the worst case - should not be larger than 100. I do not think that it an somehow slowdown search.

Or you mean that layer map will have to skip non-overlapping layers by checking them one-by-one?

Yes

But number of delta layers between image layers should not be large. Ideally 3 but even in the worst case - should not be larger than 100.

Is this true? What if we have N layers, where the i-th layer only occupies ranges i..i+1 and i+N..i+N+1?  But the layer map will have to search N layers, where N could be as large as you want

I see... Then we should follow your suggestion and handle holes not during search, but in insert: allow tree to contain multiple references to the same layer. And for iteration through historical layer we should either maintain separate collection or exclude duplicates. First seems to e easier.

if we really need to add ctx to all these places, please extract that to a separate commit, for easier review

Sorry, how you can imagine it?
Some of new methods, i.e. get_occupied_ranges() require context.
So I need to propagate it through all chain of calls.
I can not add get_occupied_ranges()  without passing context.
And I can not just pass context - where? without having this method. Do separate commit and pass _ctx to all potential callers of  get_occupied_ranges() ? How I can find all this places if compiler  will not do this work for me? And even if I managed to do it, then still after adding get_occupied_ranges() I will have to change '_ctx' to 'ctx'. So it slightly reduce amount of induced changed in the commit, but not so much.
IMHO we should either force propagation of context in all pageserver methods. Either use TLS.
Adding them on demand is most awful solution (small change can cause avalanche  of other changes).

Some of new methods, i.e. get_occupied_ranges() require context.

Why? We need ctx to pass it to get_occupied_ranges, which needs it to call self.load, because the holes are stored in the delta's inner. But the holes are already precomputed. We don't need to specify download behavior. Why not make holes accessible without load?

It's not that I don't like the eyesore of seeing ctx in the layer map. It's that having ctx in the layer map is a red flag, that implies we might potentially do expensive operations like layer download, and that should never be the case, especially not inside the insert_historic method, under a write lock.
The layer map should use already available metadata.
But I'm not sure if the right fix is to change your code, or change RequestContext. Why does RequestContext require TastKind in the case when download_behavior is Error? Why would we ever use Error, instead of statically preventing the error.. Not sure I haven't read that code yet.

Related to the ctx requirement, we already have 1-2 threads on it, perhaps keep that discussion there? https://github.com/neondatabase/neon/pull/3348#discussion_r1098257312
Is it obvious for else how will this work in practice? I think the ideal situation would be that we could just pull some existing tenant, and have this new code regenerate all of the files for that, then compare and bench. We probably cannot do that right now? Should we have such testing facilities? I think having such would make testing in future easier, for example compression etc, other layer layout ideas coming in future.

It's not that I don't like the eyesore of seeing ctx in the layer map. It's that having ctx in the layer map is a red flag, that implies we might potentially do expensive operations like layer download, and that should never be the case, especially not inside the insert_historic method, under a write lock.
The layer map should use already available metadata.
But I'm not sure if the right fix is to change your code, or change RequestContext. I haven't read that code yet.

Information about holes is stored in index_part.json and is used when we download file from S3.
But it is not stored locally at pageserver: it is reconstructed when layer is loaded. And it is now done on demand.
I do not understand why "ctx" in LayerMap is red flag. RequestContext is actually just a way to propagate task specific context.
From my point of view it should be everywhere (in each our method) or never (use LS when it is actually needed).

A quick comment while trying to understand the on-demand calculation of holes while not actually holding any locks.

Layers are read-only. So why do we need any locks here?

Are there intentional changes for vendor/postgres-v1{4,5} as well? I cannot see how these changes could require postgres chjanges.

Sorry, them are completely unrelated.
I will remove them. Just ignore them for now.


Can't rewrite my ffmpeg commands to nodejs

I'm trying to do some stuff using fluent-ffmpeg which I have working in command line just fine.
basically, I'm merging videos -> extracting audio -> mixing audio with some music -> merge it back
part when I'm stuck is after mixing audio I can't marge it back.
this is command for merge audio
ffmpeg -i merge.m4a -i overlay.aac -strict experimental -c:a aac -filter_complex amix=inputs=2:duration=first mergeOutput.m4a

and this I have in nodejs:
  ffmpeg('./merge.m4a')
  .input('./overlay.aac')
  .audioCodec('aac')
  .complexFilter('amix=inputs=2:duration=first')
  .saveToFile('./mergeOutput.m4a')

this is both working fine.
ffmpeg -i merge.mp4 -i mergeOutput.m4a -c:v copy -c:a copy -map 0:0 -map 1:0 -shortest final.mp4 -y

this merge in command line is also working.
so this shouldbe same as above: (but it's not working)
  ffmpeg('./merge.mp4')
  .input('./mergeOutput.m4a')
  .audioCodec('copy')
  .videoCodec('copy')
  .outputOption('-map 0:0')
  .outputOption('-map 1:0')
  .on 'error', (err, stdout, stderr)->
    console.log(err)
    console.log("ffmpeg stdout:\n" + stdout)
    console.log("ffmpeg stderr:\n" + stderr)
  .mergeToFile('./final.mp4')

I misunderstand how to use fluent-ffmpeg or is something else wrong.
I get this err:
 ffmpeg exited with code 1: Cannot find a matching stream for unlabeled input pad 2 on filter Parsed_concat_0

full output: http://pastebin.com/hqeeek6f

I think you should not specify -map options when using mergeToFile. Can you please try without them ?

When I remove map I get exact same error.

Sorry for the delay ; could you please show me the full command line generated by fluent-ffmpeg ? Just add a handler for the 'start' event, it will receive the command line as argument.

Sorry, I give up on that. I can't figure out how to make it work and it wasn't only command. So I just use shell.js without fluent.


Theme pattern for Filter Pane not present in Theme documentation

It is not clear how to integrate the example for a theme JSON file to apply to the filter pane into the overall theme file. Can this example and the filter pane options be integrated into the Desktop Report Themes documentation with all properties defined?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 169f0fd8-5f91-c727-863e-775092492219
Version Independent ID: f2870679-e514-3e52-3513-eb62c81983c7
Content: The new filter experience in Power BI reports - Power BI
Content Source: powerbi-docs/power-bi-report-filter.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @awbarbeau -- good idea. Let's see what we can do. Thanks!
@Sujata994, here's the json part of the report themes article https://docs.microsoft.com/power-bi/desktop-report-themes#report-theme-json-file-format

@maggiesMSFT, can you assign this to @amandacofsky since she owns the theming part of the docs.

Hi, @amandacofsky -- can you update the json part of the report themes article, https://docs.microsoft.com/power-bi/desktop-report-themes#report-theme-json-file-format, with the theme info for filters?
thanks!

Hi<EMAIL_ADDRESS>We got this feedback again from customers saying the themes doc is out of date and doesn’t include info about filter pane. Can you prioritize updating it?
the site linked from Power BI Desktop ( https://docs.microsoft.com/en-us/power-bi/desktop-report-themes ) is out of date and has no reference to Themes or the "outspacePane" seciton as described in the May blog post.
Thanks,
Sujata
From: Maggie Sparkman<EMAIL_ADDRESS>Sent: Monday, August 5, 2019 2:36 PM
To: MicrosoftDocs/powerbi-docs<EMAIL_ADDRESS>Cc: Sujata Narayana<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/powerbi-docs] Theme pattern for Filter Pane not present in Theme documentation (#1255)
Hi, @amandacofskyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famandacofsky&data=02|01|sunaraya%40microsoft.com|2f6262e69b20455e1c9708d719ecd844|72f988bf86f141af91ab2d7cd011db47|1|0|637006377338260421&sdata=WBmKegKCs2Vdxmzeg45b5nATdQb4Tdg%2FMzj%2F7weVBBo%3D&reserved=0 -- can you update the json part of the report themes article, https://docs.microsoft.com/power-bi/desktop-report-themes#report-theme-json-file-formathttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fpower-bi%2Fdesktop-report-themes%23report-theme-json-file-format&data=02|01|sunaraya%40microsoft.com|2f6262e69b20455e1c9708d719ecd844|72f988bf86f141af91ab2d7cd011db47|1|0|637006377338265405&sdata=IhO0GBLfeUblj91apR%2FcwcqRFnN%2B468onOCdBzap2XA%3D&reserved=0, with the theme info for filters?
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerbi-docs%2Fissues%2F1255%3Femail_source%3Dnotifications%26email_token%3DALNOGSVCQYDDT3RTGWCJG2LQDCMKJA5CNFSM4IFMDSI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3TE32I%23issuecomment-518409705&data=02|01|sunaraya%40microsoft.com|2f6262e69b20455e1c9708d719ecd844|72f988bf86f141af91ab2d7cd011db47|1|0|637006377338270403&sdata=L7BNUO95Er%2BFHTH4%2F0Mj3jySg4f4UcXhTYozzqZV7EM%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALNOGSXLUESHDNM65YANBLLQDCMKJANCNFSM4IFMDSIQ&data=02|01|sunaraya%40microsoft.com|2f6262e69b20455e1c9708d719ecd844|72f988bf86f141af91ab2d7cd011db47|1|0|637006377338275391&sdata=A%2FFhj63uaBN5oLq5Oj9yqiI0TE6jdKrlwfLq1mvwsn4%3D&reserved=0.


improve ledger ux

Ledger UX improvements from issue #845
The two step process for selecting a Ledger derivation path first and then selecting an address is merged into one modal. If the user has their Ledger connected and the Ethereum app open then 5 addresses from each path get preloaded, the first path to have a non-zero ETH balance in one of their addresses gets displayed, and all 5 addresses have their ETH and aggregate stablecoin USDT, DAI and USDC balances displayed underneath. Paths can still be switched afterwards.
If there is some problem with discovering Ledger at first, then the modal requires a button click to choose the path once the Ledger gets discovered.
On each path, an additional 5 addresses can be displayed, so 3 x 10 choices overall.
Hopefully it doesn't take to long to render initially, might be possible to do some optimisation trade-offs etc otherwise.

Oh another nitpick when arrow is facing upwards it is not centered:

Appreciate your comments @sparrowDom ! I committed all the changes for those.
About the address shortening, I originally left them long to fit the wider box, but I agree that's probably too much text. I shortened the addresses, but kept the buttons wide to fill the empty space and leave room for large balances, let me know if that works.

@micahalcorn UI looks good to you? If yes, let's merge this in!

Thanks for addressing all the issues looks great @rolandpo . Great work with this PR 🙏


Add google serper tool

🚀 Feature Request
I think we can build more tools. We can refer to the code implementation in the duck duck go search section, and also refer to the Google Serper implementation section in Langchain. It is highly recommended to read the relevant implementation code.

https://github.com/Undertone0809/promptulate/tree/main/promptulate/tools/duckduckgo
https://python.langchain.com/docs/integrations/tools/google_serper

We may use the following method to call tool:
import promptulate as pne
from promptulate.tools.serperimport Serper

serper= Serper()
agent = pne.ToolAgent(tools=[serper])
agent.run("What's the weather in Shanghai tomorrow?")

Isn't pne already perfectly compatible with the Langchain tool, and why do you need to be compatible with this tool independently?

Isn't pne already perfectly compatible with the Langchain tool, and why do you need to be compatible with this tool independently?

It doesn't mean we don't need it.

@Hizeros here is a good for first issue.


Remove use of mongolabs in sample config file

It gets used as part of our test suite that runs on Travis and it is too flaky. Hardcode to localhost instead.

Current coverage is 79.44%

Merging #1088 into master will decrease coverage by -0.08% as of 42bcb15

@@            master   #1088   diff @@
======================================
  Files          167     173     +6
  Stmts         9684    9681     -3
  Branches       316     314     -2
  Methods          0       0
======================================
- Hit           7701    7691    -10
  Partial          0       0
- Missed        1983    1990     +7

Review entire Coverage Diff as of 42bcb15

Powered by Codecov. Updated on successful CI builds.

👍🏽

Eventually we should also change SBT to pull down the correct MongoDB to use and start it locally so the tests can succeed on fresh checkout.

@jdegoes They already should succeed on a fresh checkout – I’m ok with this change because this config gets tested only on Travis before releasing the jar. Running the tests locally still doesn’t require a particular Mongo instance, it just requires you to have some Mongo instance (≥ 2.6) somewhere.

:+1:

@sellout I think what @jdegoes meant is that the sbt build should take care of everything. i.e. the tests should not fail even if the developer has not previously gone through the steps of installing an instance of MongoDB and configuring things so that quasar knows where to find it.
Anyway, I have thoughts on how to make that happen, but one step at a time.

@sellout I think what @jdegoes meant is that the sbt build should take care of everything. i.e. the tests should not fail even if the developer has not previously gone through the steps of installing an instance of MongoDB and configuring things so that quasar knows where to find it.

:+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1: :+1:


SQLite rewrite

Rewrite jails, homes and warps to use SQLite.
I don't know SQLite, so I won't do it soon, maybe some day if I learn.
Any volunteer?

Just curious, what exactly is the advantage of SQLite?

Faster access to data.
Right now essentials is using ini files, which, specially in the case of jails, can be slow.

How is the jail done then? Does it check the INI file when the player moves or when the player joins? If it checks it when the player moves, then I suggest creating a cPlayerState object just like WorldEdit. In there you can save if the player is in jail or not.

I'm not quite sure, it's been a long time since I coded and tested it for the last time.
I will have a look.
Anyway, SQL would be better.

Yes, SQL would be better, but it's still better to save if someone is jailed in memory.


Constraints file does not get created for monorepos

Description
It seems that a wheel for monorepo does not include a top-level METADATA to extract the constraints from. This means that reqs remains empty:
https://github.com/jupyterlab/maintainer-tools/blob/cc40b874b2c46a91b80ace91e8e0baace20c2d31/.github/actions/base-setup/create_constraints_file.py#L11-L18
Reproduce
https://github.com/jupyterlab/jupyter-ai/actions/runs/11295357412/job/31417885693?pr=1029
Expected behavior
Follows the dependencies in monorepos like https://github.com/jupyterlab/jupyter-collaboration or https://github.com/jupyterlab/jupyter-ai which produce METADATA like:
Metadata-Version: 2.3
Name: jupyter-collaboration-monorepo
Version: 3.0.0b6
License-File: LICENSE
Requires-Python: >=3.8
Requires-Dist: jupyter-collaboration-ui@ file:///some/path/jupyter_collaboration/projects/jupyter-collaboration-ui
Requires-Dist: jupyter-collaboration@ file:///some/path/jupyter_collaboration/projects/jupyter-collaboration
Requires-Dist: jupyter-docprovider@ file:///some/path/jupyter_collaboration/projects/jupyter-docprovider
Requires-Dist: jupyter-server-ydoc@ file:///some/path/jupyter_collaboration/projects/jupyter-server-ydoc
Provides-Extra: dev
Requires-Dist: click; extra == 'dev'
Requires-Dist: jupyter-releaser; extra == 'dev'
Requires-Dist: pre-commit; extra == 'dev'
Requires-Dist: tomlkit; extra == 'dev'
Provides-Extra: docs
Requires-Dist: jupyterlab>=4.0.0; extra == 'docs'
Requires-Dist: myst-parser; extra == 'docs'
Requires-Dist: pydata-sphinx-theme; extra == 'docs'
Requires-Dist: sphinx; extra == 'docs'
Provides-Extra: test
Requires-Dist: jupyter-server-ydoc[test]@ file:///some/path/jupyter_collaboration/projects/jupyter-server-ydoc ; extra == 'test'

in jupyter_collaboration_monorepo-3.0.0b6.dist-info
Context
https://github.com/jupyterlab/jupyter-ai/pull/1029

So it looks like we would want to run build on each project and concatenate the result. To simplify things we could build the wheels using Python API of build module for all the projects: monorepo and the dependencies referenced via file: protocol. I am not sure if we want this to be recursive, but probably yes.


Configure account name's hostname component

Some conflicts after merging this PR, sorry about that. Let me know if you have any questions!

@mmontes11 Yeah sure you can merge this PR if it looks good to you 👍🏼


add some information to the index

Please add some information to the index, it looks empty

it's done, we need to change the content, of another more funny and creative


Add Windows support

I guess the readme should also be updated to include the Error: Unsupported os: {{os}}. Or should we just gracefully do nothing if the os is not supported?

We can just fail gracefully. You also need to mention Windows support in the readme.

Well, I changed my mind. I think we should throw.
If the exec fails, it's gonna throw anyways. And if we do try { ... } catch (error) { /* log error in some way */ } we just swallow useful info and make it harder to test.
I guess we could also just do a Promise API and exec async. Users could then decide what to do with the error in their .catch().
What do you think?

I'm ok with throwing too, but it should stay synchronous.

Okay, I kept it sync.
I also switched from return to break so it doesn't return a Buffer.

👍

https://github.com/sindresorhus/lock-cli/commit/4aa7c339c9a0d7d8d52efc325a97c2693690155f


Support an asterisk in bothify and optimize

Base::bothify() now replaces an asterisk ('*') with either a random number or a random letter.
I also replaced preg_replace_callback in numerify and lexify as it is slower than iterating over a range of chars found by using strpos and strrpos.
Benchmarks are available here: https://gist.github.com/nineinchnick/84895a560910e3ead9cc
The biggest question is should we worry about UTF-8? I guess in a worst case it could replace the wrong byte. There are a few SO questions how to iterate over UTF-8 strings efficiently.
Should the new helper method Base::replaceWildcard be public?

Hi, thanks for the patch!
Being utf8-safe also explains why the current version may be slower. Although faster, your method drops an important ability (UTF-8), which is a stopper. I think preg_replcae_callback() with a /u is a must.

I've been thinking about it. We can still use strpos to extract a shorter string to pass to preg_replace_callback(). It also allows to skip the call completely in bothify if there are no '#' or '?'.
I'll benchmark that version and the one with custom utf-8 string iteration.

Btw there should be an unit test to see it fail for special utf-8 strings. Maybe I'll try it with minimaxir/big-list-of-naughty-strings.

There's an answer on SO that says it should be fine to search for an ascii char in an utf-8 string.

Then you'll need a test to prove it :)

Done and it seems to work. Done with https://gist.github.com/nineinchnick/917e644df42ccd62db5c
on every possible utf-8 char and those files:

minimaxir/big-list-of-naughty-strings
bits/UTF-8-Unicode-Test-Documents

I mean a unit test un Faker.

Done.

I meant testing Faker, not PHP. You have to make sure numerify, lexify, and bothify work correctly with UTF-8 strings.

I'm not sure how such a test would look like. Should I run it on that big utf-8 string, replace the single char back to the placeholder and compare?

No, just use a sample UTF-8 string with a couple special chars AND placeholders, and check that the result matches the expected with a regular expression (using /u)

Done.

Great, thanks!


Missing positional values for dynamically added columns

CrateDB version
master
CrateDB setup information
No response
Steps to Reproduce
cr> create table t (obj object(dynamic));
CREATE OK, 1 row affected  (0.203 sec)
cr> INSERT INTO t (obj) VALUES ('{"new": 1}');
INSERT OK, 1 row affected  (0.092 sec)

Expected Result
generate the same index mapping as below:
cr> create table t (obj object(dynamic));
CREATE OK, 1 row affected  (0.195 sec)
cr> alter table t add column obj['new'] integer;
ALTER OK, -1 rows affected  (0.071 sec)

{"default":{"dynamic":"strict","_meta":{},"properties":{"obj":{"position":1,"dynamic":"true","properties":{"new"{"type":"integer","position":2}}}}}}
// notice that position: 2 is there

Actual Result
{"default":{"dynamic":"strict","_meta":{},"properties":{"obj":{"position":1,"dynamic":"true","properties":{"new":{"type":"long"}}}}}}

Table level dynamic column addition is not affected:
cr> create table t (x int) with (column_policy = 'dynamic');
CREATE OK, 1 row affected  (0.198 sec)
cr> insert into t (x,y) values (1,2);
INSERT OK, 1 row affected  (0.087 sec)

{"default":{"dynamic":"true","_meta":{},"properties":{"x":{"type":"integer","position":1},"y":{"type":"long","position":2}}}}


Add Osu! 2021.312.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

Greetings. When I run the app Osu!laser, I do not see anything happen. It starts to launch, then nothing. Is it missing a dependency?

@KevinLaMS maybe check https://github.com/microsoft/winget-pkgs/pull/1067#issuecomment-636387463 , I don't have any problems.

/azp run


Fix scilla testcases

Most of the testcases in https://github.com/Zilliqa/Zilliqa/tree/ba6dc3d1cd08de09ea9f543340c983d83ecdfde7/tests/EvmAcceptanceTests/test/scilla doesn't work. We would need to fix them.

@saeed-zil will raise more detailed issues for the individual Scilla features we are missing

CHAINID
_codehash
accept
TIMESTAMP
user-defined libraries


feat: Migrate to AndroidX and generate AARs to maintain backward compatibility

Overview
This PR migrates the library to use AndroidX. This allows it to be used with other libraries which have been migrated to AndroidX and React Native >= 0.60.
It also adds code from a pre-release version of bob which build an AAR file for the Android library. This allows the same library code to be used with or without AndroidX.
Test Plan
Users who want to test this can update to this version of the library by running:
yarn add @react-native-community/netinfo@next
or:
nom install --save @react-native-community/netinfo@next
The library should then work as expected, but they can also change the reference to the project in their android/settings.gradle file to one of these to use either the AndroidX or support library AARs:
AndroidX:
include ':react-native-community-netinfo'
- project(':react-native-community-netinfo').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/netinfo/android')
+ project(':react-native-community-netinfo').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/netinfo/lib/aar')

Android Support:
include ':react-native-community-netinfo'
- project(':react-native-community-netinfo').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/netinfo/android')
+ project(':react-native-community-netinfo').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/netinfo/lib/aar/support')

See also:

https://github.com/react-native-community/bob/pull/4
https://github.com/react-native-community/discussions-and-proposals/issues/129

Fixes #107

Just curious, why have you chosen to provide two aars rather than a single one?
If you build an AAR with com.android.support dependencies, the Jetifier will convert it to androidx when the app is built.
Are there any new features in the androidx library that you are using or plan on using?

@AndrewJack I did two AARs mainly because I there is less potential for bugs if the AAR is converted from AndroidX to support and then back again. If an app is using AndroidX then they would just use it directly and avoid the Jetify process completely. From what I've read Jetifier is not 100% accurate and I think it's always better to be as direct as possible.

Nice
Waiting for the fix to https://github.com/react-native-community/react-native-netinfo/issues/107

Any chance this PR can be deployed to 2.X.X version for those still running RN 0.57 or should I just get with the times 🙏

I'm going to close this PR in favour of just migrating cleanly to AndroidX. For users who need to support it early, or users who want to migrate their libraries back to the support library, they can use the Jetifier project.
I will do the migration when React Native 0.60 is fully released to avoid too much user confusion too early.

hey guys, Does recat-native-netinfo support AndroidX?

@florinlazau https://github.com/react-native-community/react-native-netinfo/blob/8af8437b9f47f3c0366b47f3abcc4d479a3567b7/android/build.gradle#L59-L68


[Fix]: Postman and Twitter icon alignment

This fixes issue #45
Center-aligned postman and Twitter icons
Before

After

HI @vinitshahdeo , sorry to bother you. As the hacktobefest ends today, can you please check and merge this as soon as possible?


Handle illegal StateMachine transition as Non-Deterministic error

Handle illegal state machine panic as non-deterministic error so it will be handled according to NonDeterministicWorkflowPolicy.
This change is needed to hook up the Reset API once it is ready on server side.

Coverage decreased (-0.06%) to 69.06% when pulling 388c7b8214aa112bde61a6a72fedcfdb4d2414aa on yiminc:non-deterministic-panic into 167c85a7e8ed5430f57716531030c51cae748bc1 on uber-go:master.


Does thorium have the hangout_services extension

Add all the stuffz here
https://x.com/lcasdev/status/1810696257137959018
It has and gives access to all *.google.com sites to see personally identifying information, and is default in chromium. I am curious if it's in Thorium.

We did not shut down or delete this service.

Thorium should remove hangout spyware from its code.

This extension is not enabled by default in non-chrome (controlled by a compile-time parameter) and has been used by Google for a long time, but Thorium has chosen to force the extension to be enabled for usability.
We will review whether it is still necessary to force-enable this extension later.
BTW, this extension is not spyware and the data it collects is not very sensitive. Please be rational and dialectical when looking at online comments.
@Tarek-Hasan @viasux

This extension is not enabled by default in non-chrome (controlled by a compile-time parameter) and has been used by Google for a long time, but Thorium has chosen to force the extension to be enabled for usability.
We will review whether it is still necessary to force-enable this extension later.
BTW, this extension is not spyware and the data it collects is not very sensitive. Please be rational and dialectical when looking at online comments.
@Tarek-Hasan @viasux

Could you not do what brave does, where there's an option to have it enabled or disabled in the settings?

@Tarek-Hasan @gz83 @viasux Probably going to either make it disable-able, or remove it and instead offer it as a .crx that can be installed manually, since most people don't need it, and it does have some privacy concerns, due to it sharing more system info data than other extensions are normally allowed.

Brave's statement on this matter - https://x.com/brave/status/1811129059687997444

@gz83 @Tarek-Hasan @viasux I decided to disable it for all platforms except Android (where it is still used heavily since alot of people use Hangouts and Chrome/Chromium/Thorium can use this to hook into it).
All desktop platforms in the next release will have it disabled by default, HOWEVER, I extracted the source code, made a few tweaks, and it is now present here > https://github.com/Alex313031/thorium/tree/main/infra/hangout_services
I will eventually build a .crx and place it in the repo with a link to download in the release notes. This will allow people who depend on the extension to still manually install it. Files other than the manifest.json should not be tampered with however, because then the UUID of the extension will change, and Chromium gives special permissions to this extension only by having it match the UUID that is hard coded in the source.


Create local m3u8 file with exec

Why won't this work
exec ffmpeg  -i rtmp://localhost/live/stream -c:v libx264 -c:a aac -ac 1 -strict -2 -crf 16 -profile:v baseline -maxrate 10000k -bufsize 1835k -pix_fmt yuv420p -flags -global_header -hls_time 10 -hls_list_size 6 -hls_wrap 10 -start_number 1 /tmp/live/stream.m3u8
It works fine on the command line but not using exec

user absolute path of ffmpeg, such as /usr/local/bin/ffmpeg


Fix Fix INT96 timestamp min-max statistics is incorrect when was written by some old parquet writers by disable it.

Proposed changes
[Fix] (parquet-reader) Fix INT96 timestamp min-max statistics is incorrect when was written by some old parquet writers by disabling it.
Parquet INT96 timestamp values were compared incorrectly for the purposes of producing statistics by older parquet writers, so PARQUET-1065 deprecated them. The result is that any writer that produced stats was producing unusable incorrect values, except the special case where min == max and an incorrect ordering would not be material to the result. PARQUET-1026 made binary stats available and valid in that special case.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Repeat block treats its argument differently than in Scratch 2.0

Expected Behavior
The repeat block should follow the Scratch 2.0 repeat block behavior of rounding its argument.
Actual Behavior
The repeat block appears to do a floor (int?) function on its argument.
Steps to Reproduce

Operating System and Browser
Windows 7 (64 bit), Chrome Version 66.0.3359.117 (Official Build) (64-bit)
The Scratch 3.0 repeat block will break projects like https://scratch.mit.edu/projects/42202752/, which, however wrongly, depend on the rounding of the repeat argument.

Moved to LLK/scratch-vm#1083


Fix release docs action

Description
Cherry-pick this fix from the master branch.

I successfully created a test release with expected actions. @cmclaug2 have you had success too?

@jvgeiger @emkemp,
I was also able to successfully create a test release.

Okay, then I will accept.