Discovery against #SNMP demo agent didn't work

The error message is simply "SNMP message timing parameters not in windows of trust".
Investigation shows that PySNMP dislikes the discovery response message generated by #SNMP demo agent, which is of security level 0, so it does not cache engine boots and engine time for the following requests. In that way, #SNMP demo agent denies them with not in time window responses, which leads to the error message on PySNMP side.

RFC 3414 does not seem to have clear descriptions on what behaviors are expected. So, maybe just patch PySNMP to accept such discovery responses and cache the time data.


Hey can update the Readme File according to the new changes

@jsvigneshkanna

Hi @kuldeepmangla
I am assigning you this issue, go ahead
Also please look at other feature requests too

Thanks @kuldeepmangla for your contribution,
Check out this figma whether you can recreate any components in tailwind and please raise an issue for that component
https://www.figma.com/file/0eqV7t3UKKM14UeqCSfOZb/Essential-UI---Figma-Ui-Kit-(Community)?node-id=688%3A1988


Is option to connect to DB through SSH ?

Is there any feature through which i can connect to the server through SSH then initiate a connection to the running DB on that server.?

Hi @Amrkamel1 yes, this module just makes a TCP connection to the server like most programs. If you want to connect to something over a SSH connection, just set up SSH port forwarding as usual and then point this module at the local port and localhost. I hope that helps!

Definetly it helps, could provide any reference that could work with mysql.
I have tried many node packages but failed to do so always getting timeout

Hi @Amrkamel1 no problem! Here is an example for how to set up a tunnel with the SSH program (the most common way): https://www.ssh.com/ssh/tunneling/example

@dougwilson
I have managed to connect through ssh thanks so much.
but i have another question how i can disable all meta data like the highlighted part below


Add -wrap class to annotation_table data cell

Motivation and Context

There is a small visual artifact in Markus (#7001) where long annotations do not wrap, which results in them being cut off after a certain length.
Your Changes

Description:
I added the -wrap class to the table data cells in the AnnotationTable component
Type of change (select all that apply):

[x] Bug fix (non-breaking change which fixes an issue)

Testing

I added the -wrap class to the web interface via Chrome Devtools and saw that it resolved the issue. Then I went and tested that docker-compose.yml builds and runs properly
Checklist

[x] I have performed a self-review of my own code.
[x] I have verified that the pre-commit.ci checks have passed.
[ ] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.
[x] I have updated the Changelog.md file.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.653%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
40299

Relevant Lines:
43303

💛  - Coveralls

thank you for the swift reply! i've added my name to markus-contributors.txt


Increases log_limit to 256k

Hello!
I'm needing bigger logs, so I added a layer increasing the log_limit in my app.
But, since Cloudwatch now allows logs up to 256kb (https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/cloudwatch_limits_cwl.html), is there a chance this can be applied to the base layer?
Thanks from a fan!

Hi, have you been able to test these changes in Lambda?

Hi, the change works, in the sense that larger logs are exported intact from Lambda.
If the intended usage of these logs is the creation of metrics, it's kinda easier to do with JSON data, and in that case getting truncated logs makes data "disappear" from the metric.
The only thing is if some app is expecting log_limit to reduce their Cloudwatch (and $) usage.


Change prices to strings in G5&6 schemas

Change the minPrice and maxPrice fields to be strings (as they are in
G7) in the G5 and G6 schemas.
This is going to mean that G5 and G6 services read from the data API
will not be valid if sent straight back. However, this shouldn't be a
problem because the only way they can be edited is through the admin
app which sends them back as strings.
In terms of the effect this will have on other apps. The supplier and
frontend apps will be using the same price rendering code which will
allow for strings or numbers for the prices. The buyer frontend
currently uses the priceString field which isn't set on G7 services so
we need to address this anyway.

:+1:

I'm a bit confused by the "the only way they can be edited is through the admin app which sends them back as strings" part. If you edit an unrelated service field in the admin app then changed fields are sent to the API, combined with the original service and the resulting service data is validated – and I'd expect it to be rejected since the price fields no longer pass the validation. Am I missing something?

Good point @allait - you're right I think (not tested though).

Ah, rubbish, I was thinking of the draft behaviour where only the changed section is uploaded. Closing until I have a solution.

:+1:


Next Unread Button Functionality

When you're viewing posts in flat mode (<3), the next unread button moves between the next unread messages in the thread, not the next unread message by time. It seems like in flat mode it should move through time, rather than thread. Maybe this could be an option.

Whoops, my bad. Fixing this now.


try-puppeteer: (async() => { ... })() fails silently

From @ithinkihaveacat on November 2, 2017 12:33

The following code (abbreviated version of a file from the examples folder) fails silently when entered in the editing component at https://try-puppeteer.appspot.com/:
(async() => {
const browser = await puppeteer.launch();
console.log('Hello, World');
})();

Actual:
No output, no error message.
Expected:
The output Hello, World!.
Copied from original issue: GoogleChrome/puppeteer#1254

Ironically, this by itself works:
(async() => {
console.log('Hello, World');
})();

I think we can get around it by adding an await in front of the user code (https://github.com/ebidel/try-puppeteer/blob/master/backend/server.js#L85) just in case someone uses an async IIFE wrapper.

Unfortunately, that won't work if the user just has:
const browser = await puppeteer.launch();
...


Fixed Sound Issue

This PR is to fix issue #31 .
This issue was caused by pygame being unable to read the .ogg files that contained the sounds. To combat this, I converted the files into the WAV format.
I've tested on Mac, Linux, and Windows, all seem to work perfectly!

I've tested it out and it works! But now there's the issue of the sound files getting too big. WAV format tends to be very big, I've checked the sound file and it alone uses up to 77 MB now. Can you convert it to another format, such as mp3 (I think I tried mp3 before and it didn't work, but maybe I was doing it wrong) or other formats that are smaller in size?

I did try mp3 before attempting WAV and it didn't work properly. I will try to find another file format that is smaller.

Pygame currently only supports mp3, ogg, and WAV. WAV is the only one that works out of the three.

Is it possible to compress the WAV files further?

Apologies for the delay in my responses, I have managed to compress the WAV files to be much smaller than they were originally. To my knowledge, this hasn't sacrificed sound quality at all.


cant create directory /usr/local/bin/mount_unionfs

echo "$mount_script" > /usr/local/bin/mount_unionfs says: nonexistent directory
Tryed with latest fresh moebius-OS

closed since repo is dead.


Introduce the draw display list

Build it
Add DrawCompositedLayer
Use it in Browser.draw
Delete almost all the complexity in CompositedLayer.draw

I'll clean up now-dead code in another PR.


WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'

Description
I'm using react-native-image-picker 0.26.10 it is showing WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
on running android build OR running project.
the same warning is showing for the app so i changed 'compile' to 'implementation' in build.gradle file, it works for the app but it is still showing for image picker
Solution
remove warning
Additional Information
full warning
Configure project :react-native-image-picker  WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html WARNING: Configuration 'testCompile' is obsolete and has been replaced with 'testImplementation' and 'testApi'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html WARNING: Configuration 'testApi' is obsolete and has been replaced with 'testImplementation'. It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html WARNING: The specified Android SDK Build Tools version (25.0.2) is ignored, as it is below the minimum supported version (27.0.3) for Android Gradle Plugin 3.1.4. Android SDK Build Tools 27.0.3 will be used. To suppress this warning, remove "buildToolsVersion '25.0.2'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

since the library here is using the depricated keywords, ImagePicker is showing warnings.

I resolved this by changing 'compile' with 'implementation' in the react-native-image-picker gradle file,
i found at the bottom if android studio navigating bar inside gradle
what I was doing wrong is changing 'compile' with 'implementation' in app gradle file and hoping for react native image picker to remove the warning,
well you have to do in for both.

This isn't a proper solution, as when you delete your NPM modules and reinstall them, the issue will return.
Is there a way to override the module settings in the apps main build.gradle file?

@twhoff I know that but at that time i just wanted to get rid of that warnings

@twhoff you are right I'm reopening this issue

What version of the image picker are you using?
This was changed about 5 months ago: https://github.com/react-native-community/react-native-image-picker/blob/master/android/build.gradle#L56


Simplify Docker setup

This was just a test to see what was wrong with the build. I'm not planning to submit it.


What if we had a big model that could do everything for fine-tuned inference

Creates one large model which can run fp8 & bf16 flux dev & schnell lora inference.

going to go ahead and merge to avoid split brain but if folks have thoughts, can always make changes.


added reportEvent method

added the reportEvent method.
I made something simple as i didn't know how to use the async queue.
Please have a look and tell me how we can make it better, i will be happy to improve the code.

@rstiller did you have time to give a look ?

Hi, no I'll need to do it later in about 6-7 hours (I'm at work).

@rstiller I made the changes you requested.

I see - will review / merge / publish next ... had to publish inspector-metric, inspector-carbon, inspector-prometheus and inspector-elasticsearch because of this huge security alert on event-stream package ...


Typescript issues

Description
Fix the Sentry and ConnectedRouter errors that are due to type errors

@thanasis457, I don't think these errors are fixed yet. That's why i recently opened https://github.com/GTBitsOfGood/MapScout/pull/281. You might want to take a look at this PR.

@nickspaargaren Thank you so much for your PR! I seriously appreciate your help. We are a student org helping out non-profits and any help is much appreciated.
I did run the project and indeed new errors have started popping up. This is a pretty old project and a lot of the issues will only be resolved by a massive upgrade of the packages. For now, I have identified the few packages that were causing the issues and will change the package.json file to limit upgrades to patches (no minor updates).
There are a lot more features to be implemented so upgrading packages is not really a priority now.

You are welcome @thanasis457! Sounds like a helpful project!
I've already did some major dependency upgrades last week for you to resolve the newly introduced errors. Check it out and let me know if i need to explain anything else. Happy to help!


[Volunteer] Add unit test for PluginController

Volunteer help
Hi community
Volunteer help to add unit test for org.apache.shenyu.web.controller.PluginController

I want do it

i want do it

@dbaxyx  hezhaoming accept, thanks ,Look at the other~

@dbaxyx  What is the current progress and do you need help?

3Q, I doing ^_^

@hezhaoming   dbaxyx What is the current progress and do you need help?

Is there any progress? Let me try it plz @songyuequan @yu199195

Hi~ I have assigned it to you in #2420 . and you can just try. @yangtianrui95

done


Tag not found after build

Scenario: Create brand new webapi project,  Publish container image (detailed commands see below)
Expected outcome: Container image can be accessed with auto-generated tag or tag specified using ContainerImageName
Actual outcome: Container image can only be accessed using image ID, have to create a new tag to access it via tag
Environment:

Windows 11 21H2 (22000.1042)
Docker Desktop 4.12.0 (85629) using WSL 2 based engine

Commands:
C:\Code\GitHub\Samples\DotNet7>dotnet new webapi -n my-awesome-api
The template "ASP.NET Core Web API" was created successfully.

Processing post-creation actions...
Restoring C:\Code\GitHub\Samples\DotNet7\my-awesome-api\my-awesome-api.csproj:
  Determining projects to restore...
  Restored C:\Code\GitHub\Samples\DotNet7\my-awesome-api\my-awesome-api.csproj (in 10 ms).
Restore succeeded.

C:\Code\GitHub\Samples\DotNet7>cd my-awesome-api

C:\Code\GitHub\Samples\DotNet7\my-awesome-api>dotnet add package Microsoft.NET.Build.Containers
  Determining projects to restore...
  ...
log  : Restored C:\Code\GitHub\Samples\DotNet7\my-awesome-api\my-awesome-api.csproj (in 92 ms).

C:\Code\GitHub\Samples\DotNet7\my-awesome-api>dotnet publish --os linux --arch x64 -p:PublishProfile=DefaultContainer
MSBuild version 17.4.0-preview-22428-01+14c24b2d3 for .NET
  Determining projects to restore...
  ...
  Pushed container 'my-awesome-api:1.0.0' to registry 'docker://'

C:\Code\GitHub\Samples\DotNet7\my-awesome-api>docker inspect my-awesome-api
[]
Error: No such object: my-awesome-api

C:\Code\GitHub\Samples\DotNet7\my-awesome-api>docker images | find "my-awesome-api"
my-awesome-api                                      1.0.0                                                   c2db0d6412e6   31 seconds ago   216MB

C:\Code\GitHub\Samples\DotNet7\my-awesome-api>docker tag c2db0d6412e6 my-awesome-api2

C:\Code\GitHub\Samples\DotNet7\my-awesome-api>docker inspect my-awesome-api2
[
    {
        ...
    }
]

What's happening here is that docker is silently inserting a :latest tag onto any image names that are specified without one. They do this in a few places, which causes this sort of error. If you fully qualify your inspect command (docker inspect my-awesome-api:1.0.0) the command should work.

@baronfel Thank you, works as you described it. It would be nice if Microsoft.NET.Build.Containers would also add latest. As an alternative, you could not the behavior in docs.


[Code structure] Remove thprac_ prefix from filenames

Having the prefix serves no practical purpose, and introduces needless visual complexity.
Known potential conflicts:

main.cpp and thprac_main.cpp
utils/utils.h and thprac_utils.h

It may also be worth considering organizing the files into subdirectories, as the groupings in Visual Studio are not reflected in the file structure. (Would this be worth opening a separate issue for?)

thprac_utils can just become common while main.cpp and thprac_main.cpp can just be merged


Updated README.md

Description of new feature, or changes
Added Unlicense.org to the readme. So, No one should look for Issue/PR, if this project contains it or not, again.
Checklist

[X] Your branch is up-to-date with the base branch
[X] You've included at least one test if this is a new feature
[X] All tests are passing

Related Issues and Discussions

Fixes #6
People to notify

Thanks for this. I just noticed that the Unlicense file - https://github.com/plibither8/licensed/blob/master/assets/Unlicense - is not present in the assets/licenses directory, but in assets/.
It would be great if you could move the file to the assets/licenses directory to prevent the app from breaking/crashing.

Thanks!

I moved the Unlicense file.

Merged :)


[Question] Android app support

Not really an issue but will Artsy always be exclusive to iOS?

It's unlikely in the long term, hard to say in the short.
We covered this a bit in our React Native conference: https://youtu.be/Q2tfkpkmRLE?t=3m5s


Notebook test automation

We have a few issues relating to automated testing:
See #353 #426
A precursor step is to automatically deploy an Egeria environment after a build
An initial attempt was made in .azure-pipelines/test . This used an existing k8s cluster but was not successful as the cluster in question wasn't funded.
We need to get this automation in place so that we can run tests more quickly and reliably.
Will look at one of

establishing a permanent capability to run a k8s cluster
running a mini cluster (single node) with a pipeline, ie using microk8s/k3s or similar

#426 added FVT tests to the build - which run with a single server (though could be more).
#353 refers to adding CTS to build.
Both are specific actions with well defined test results.
A simple 'deployment' is too vague.
A sensible target here would be to automatically test our notebooks to avoid having to do this manually (even though it is fairly quick).

The intent of this test should be to validate our notebooks, not to run FVTs or similar.
At a minimum, ensuring the images are good, and that the key notebooks can at least be launched would be useful


Update README for MetadataTransfer utility

Additions:

Add information about the required packages for successfully running the script. Currently, the script requires psycopg2 and boto3 and is only compatible with python2.
Add info that the utility requires default region to be configured, else it will lead to an Exception from boto3core.

Modifications:
The usage section of the README mentions the following usage format
python metadatatransfer.py --tgtcluster <target cluster endpoint> --srccluster <source cluster endpoint> --tgtuser <target superuser> --srcuser <source superuser> --tgtdbname <target cluster dbname> --srcdbname <source cluster dbname>
While the actual usage format is as following
python metadatacopy.py \
--tgtcluster <target cluster endpoint> \
--srccluster <source cluster endpoint> \
--tgtuser <target superuser> \
--srcuser <source superuser> \
--tgtdbname <target cluster dbname> \
--srcdbname <source cluster dbname> \
[--dbport <database port>]

The filename metadatatransfer.py is incorrect and the --dbport option is not mentioned.

Can anyone of the maintainers please verify the issue and assign it to me?


Kareem branch

I added an audio btn to prefer if you want to listen to the audio or not. I also added a count div to monitor the number of questions being answered. I'm more than eager to listen to corrections or go back on any functionality that doesn't meet requirements.
Thanks.

Yeah that's right , I have removed it.
Thanks.


Integrate Istio standard logging package with Mixer.

This moves istio/mixer/pkg/log to istio/pkg/log.

This renames a few methods in the logging package to be more idiomatic.

This plumbs the logging library into mixer/pkg/server so creating a server now
requires configuring the logging options.

Next PR will wholesale switch over Mixer to use the new logging package and
drop glog. I'm separating those PRs for clarity.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@geeknoid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I think code reuse across components is not something we should take
lightly. I'd suggest externalizing any such shared components of the repo.
On Wed, Dec 13, 2017 at 3:26 PM Martin Taillefer<EMAIL_ADDRESS>wrote:

This moves istio/mixer/pkg/log to istio/pkg/log.
This renames a few methods in the logging package to be more idiomatic.
This plumbs the logging library into mixer/pkg/server so creating a
server now
requires configuring the logging options.
Next PR will wholesale switch over Mixer to use the new logging package and
drop glog. I'm separating those PRs for clarity.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #(, fixes
#<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #
Special notes for your reviewer:
Release note:

You can view, comment on, or merge this pull request online at:
https://github.com/istio/istio/pull/2143
Commit Summary

Integrate Istio standard logging package to Mixer.

File Changes

M mixer/cmd/mixs/cmd/BUILD
https://github.com/istio/istio/pull/2143/files#diff-0 (1)
M mixer/cmd/mixs/cmd/server.go
https://github.com/istio/istio/pull/2143/files#diff-1 (7)
M mixer/pkg/perf/BUILD
https://github.com/istio/istio/pull/2143/files#diff-2 (2)
M mixer/pkg/perf/clientserver.go
https://github.com/istio/istio/pull/2143/files#diff-3 (2)
M mixer/pkg/perf/controller.go
https://github.com/istio/istio/pull/2143/files#diff-4 (2)
M mixer/pkg/perf/load.go
https://github.com/istio/istio/pull/2143/files#diff-5 (2)
M mixer/pkg/perf/server.go
https://github.com/istio/istio/pull/2143/files#diff-6 (2)
M mixer/pkg/server/BUILD
https://github.com/istio/istio/pull/2143/files#diff-7 (1)
M mixer/pkg/server/args.go
https://github.com/istio/istio/pull/2143/files#diff-8 (5)
M mixer/pkg/server/server.go
https://github.com/istio/istio/pull/2143/files#diff-9 (5)
R pkg/log/BUILD
https://github.com/istio/istio/pull/2143/files#diff-10 (0)
R pkg/log/log.go
https://github.com/istio/istio/pull/2143/files#diff-11 (50)
R pkg/log/log_test.go
https://github.com/istio/istio/pull/2143/files#diff-12 (26)
R pkg/log/options.go
https://github.com/istio/istio/pull/2143/files#diff-13 (0)
R pkg/log/options_test.go
https://github.com/istio/istio/pull/2143/files#diff-14 (0)

Patch Links:

https://github.com/istio/istio/pull/2143.patch
https://github.com/istio/istio/pull/2143.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJGIxtBsHm_MnAxYF171YaFBzen0tnK6ks5tAF08gaJpZM4RBVAy
.

Why is that? One of the primary motivations for a mono repo is to
specifically enable sharing of code between our components.
On Wed, Dec 13, 2017 at 3:29 PM, Kuat<EMAIL_ADDRESS>wrote:

I think code reuse across components is not something we should take
lightly. I'd suggest externalizing any such shared components of the repo.
On Wed, Dec 13, 2017 at 3:26 PM Martin Taillefer<EMAIL_ADDRESS>
wrote:

This moves istio/mixer/pkg/log to istio/pkg/log.
This renames a few methods in the logging package to be more idiomatic.
This plumbs the logging library into mixer/pkg/server so creating a
server now
requires configuring the logging options.
Next PR will wholesale switch over Mixer to use the new logging package
and
drop glog. I'm separating those PRs for clarity.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #(, fixes
#<issue_number>, ...) format, will close that issue when PR gets
merged):
fixes #
Special notes for your reviewer:
Release note:

You can view, comment on, or merge this pull request online at:
https://github.com/istio/istio/pull/2143
Commit Summary

Integrate Istio standard logging package to Mixer.

File Changes

M mixer/cmd/mixs/cmd/BUILD
https://github.com/istio/istio/pull/2143/files#diff-0 (1)
M mixer/cmd/mixs/cmd/server.go
https://github.com/istio/istio/pull/2143/files#diff-1 (7)
M mixer/pkg/perf/BUILD
https://github.com/istio/istio/pull/2143/files#diff-2 (2)
M mixer/pkg/perf/clientserver.go
https://github.com/istio/istio/pull/2143/files#diff-3 (2)
M mixer/pkg/perf/controller.go
https://github.com/istio/istio/pull/2143/files#diff-4 (2)
M mixer/pkg/perf/load.go
https://github.com/istio/istio/pull/2143/files#diff-5 (2)
M mixer/pkg/perf/server.go
https://github.com/istio/istio/pull/2143/files#diff-6 (2)
M mixer/pkg/server/BUILD
https://github.com/istio/istio/pull/2143/files#diff-7 (1)
M mixer/pkg/server/args.go
https://github.com/istio/istio/pull/2143/files#diff-8 (5)
M mixer/pkg/server/server.go
https://github.com/istio/istio/pull/2143/files#diff-9 (5)
R pkg/log/BUILD
https://github.com/istio/istio/pull/2143/files#diff-10 (0)
R pkg/log/log.go
https://github.com/istio/istio/pull/2143/files#diff-11 (50)
R pkg/log/log_test.go
https://github.com/istio/istio/pull/2143/files#diff-12 (26)
R pkg/log/options.go
https://github.com/istio/istio/pull/2143/files#diff-13 (0)
R pkg/log/options_test.go
https://github.com/istio/istio/pull/2143/files#diff-14 (0)

Patch Links:

https://github.com/istio/istio/pull/2143.patch
https://github.com/istio/istio/pull/2143.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJGIxtBsHm_
MnAxYF171YaFBzen0tnK6ks5tAF08gaJpZM4RBVAy>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143#issuecomment-351558781, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHRqd6WLRSq9KRCd_G3Ue9u7fN6aUks5tAF3fgaJpZM4RBVAy
.

That leads to coupling creeping into the codebase, which eventually turns
istio into a monolith.
I think for logging it's fine, but I don't see how to keep this in check.
On Wed, Dec 13, 2017 at 3:32 PM Martin Taillefer<EMAIL_ADDRESS>wrote:

Why is that? One of the primary motivations for a mono repo is to
specifically enable sharing of code between our components.
On Wed, Dec 13, 2017 at 3:29 PM, Kuat<EMAIL_ADDRESS>wrote:

I think code reuse across components is not something we should take
lightly. I'd suggest externalizing any such shared components of the
repo.
On Wed, Dec 13, 2017 at 3:26 PM Martin Taillefer <
<EMAIL_ADDRESS>
wrote:

This moves istio/mixer/pkg/log to istio/pkg/log.
This renames a few methods in the logging package to be more idiomatic.
This plumbs the logging library into mixer/pkg/server so creating a
server now
requires configuring the logging options.
Next PR will wholesale switch over Mixer to use the new logging package
and
drop glog. I'm separating those PRs for clarity.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #(,
fixes
#<issue_number>, ...) format, will close that issue when PR gets
merged):
fixes #
Special notes for your reviewer:
Release note:

You can view, comment on, or merge this pull request online at:
https://github.com/istio/istio/pull/2143
Commit Summary

Integrate Istio standard logging package to Mixer.

File Changes

M mixer/cmd/mixs/cmd/BUILD
https://github.com/istio/istio/pull/2143/files#diff-0 (1)
M mixer/cmd/mixs/cmd/server.go
https://github.com/istio/istio/pull/2143/files#diff-1 (7)
M mixer/pkg/perf/BUILD
https://github.com/istio/istio/pull/2143/files#diff-2 (2)
M mixer/pkg/perf/clientserver.go
https://github.com/istio/istio/pull/2143/files#diff-3 (2)
M mixer/pkg/perf/controller.go
https://github.com/istio/istio/pull/2143/files#diff-4 (2)
M mixer/pkg/perf/load.go
https://github.com/istio/istio/pull/2143/files#diff-5 (2)
M mixer/pkg/perf/server.go
https://github.com/istio/istio/pull/2143/files#diff-6 (2)
M mixer/pkg/server/BUILD
https://github.com/istio/istio/pull/2143/files#diff-7 (1)
M mixer/pkg/server/args.go
https://github.com/istio/istio/pull/2143/files#diff-8 (5)
M mixer/pkg/server/server.go
https://github.com/istio/istio/pull/2143/files#diff-9 (5)
R pkg/log/BUILD
https://github.com/istio/istio/pull/2143/files#diff-10 (0)
R pkg/log/log.go
https://github.com/istio/istio/pull/2143/files#diff-11 (50)
R pkg/log/log_test.go
https://github.com/istio/istio/pull/2143/files#diff-12 (26)
R pkg/log/options.go
https://github.com/istio/istio/pull/2143/files#diff-13 (0)
R pkg/log/options_test.go
https://github.com/istio/istio/pull/2143/files#diff-14 (0)

Patch Links:

https://github.com/istio/istio/pull/2143.patch
https://github.com/istio/istio/pull/2143.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJGIxtBsHm_
MnAxYF171YaFBzen0tnK6ks5tAF08gaJpZM4RBVAy>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143#issuecomment-351558781, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AVucHRqd6WLRSq9KRCd_G3Ue9u7fN6aUks5tAF3fgaJpZM4RBVAy
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143#issuecomment-351559374, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxu065bajhpI4aNyBDXFSGDdC28AAks5tAF6kgaJpZM4RBVAy
.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
39158c10b44c59653bb6bad456d7328495b3234b
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OK, I reverted to the original method names where the simple names are the most efficient ones.
PTAL.

Can I get a /approve?
Thanks.
On Thu, Dec 14, 2017 at 10:01 AM, Sunny Gupta<EMAIL_ADDRESS>wrote:

@guptasu approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2143#pullrequestreview-83592774, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHd4hLzPtQp3wcUzNkCdRV22zKYqkks5tAWKOgaJpZM4RBVAy
.

/lgtm
/approve

/approve


add early filtering of final method names for final method checking

This PR attempts to make the inner loop of final method checking less costly by filtering out names that we've never seen declared as final.  Ideally, this should make _on_method_added checking much faster by never having to enter the doubly-nested loop in _check_final_ancestors, and the module-level checking we need to do much faster by reducing the number of method names we need to check for every ancestor.
Motivation

Speed.
Test plan

See included automated tests.

This change appears to be very effective in large codebases, so I think it's time to remove the wip tag.

This PR seems to have made the runtime library only compatible with Ruby 2.6 and above, due to the use of source_method_names.filter!. Here is a test failure from Tapioca on 2.4: https://github.com/Shopify/tapioca/pull/253/checks?check_run_id=2080578832#step:7:1912
However, I see that filter! is actually an alias for select! and the latter exists all the way back to Ruby 2.4. Would be like me to change the method call in a PR to keep the backwards compatibility?

This PR seems to have made the runtime library only compatible with Ruby 2.6 and above, due to the use of source_method_names.filter!. Here is a test failure from Tapioca on 2.4: https://github.com/Shopify/tapioca/pull/253/checks?check_run_id=2080578832#step:7:1912
However, I see that filter! is actually an alias for select! and the latter exists all the way back to Ruby 2.4. Would be like me to change the method call in a PR to keep the backwards compatibility?

I would be OK with that.

Already done: https://github.com/sorbet/sorbet/pull/4074


Just want to say thanks :)

This morning, when I decided to see what's new in nvim-compe these days, I did a double-take when I found that it supported a new snippets plugin. "LuaSnip?", I thought, "Huh. Gotta check that one out."
And lo and behold, it was glorious. With select mode and extmarks, the presentation is really simple and non-surprising—exactly as I like it. The snippets syntax is a bit bewildering at first, but pretty ingenious overall.
When I realized that I wasn't shackled to my previous snippets plugins anymore, a single tear rolled down my face.
Thank you, @L3MON4D3. I feel at home.
:eggplant:

Dude, thank you, it makes me very happy to hear this :D

No, thank you. Feel free to close :)


fix(migrations): do not migrate redblack pipelines without stages

Pipelines created outside of the UI Pipeline Builder may not have stages defined in the JSON. When such a pipeline exists and the RedBlackToBlueGreenK8sPipelinesMigration is run the result is an NPE.  This fixes that NPE.

@mergifyio backport release-1.30.x release-1.29.x


[Doc] Documentation Related  有对nameserver进行权限访问吗。

Search before creation

[X] I had searched in the issues and found no similar issues.

Documentation Related
有对nameserver进行权限访问吗。 比如用户密码，我现在看到的全是broker，而且在issue和doc中都找到
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

目前没有，不过可以考虑把Broker的ACL移植过去，而且确实也有必要对namesrv进行权限控制

+1
这是一个安全问题，我们的安全部门多次向我们报告了nameserver未授权修改配置漏洞，我们研发侧是难以解决的
虽然你们的CVE-2023-37582修复代码禁止了关键属性，但是其他属性被黑客恶意修改，可能导致服务不可用，使用mqadmin修改的数据包抓一下就能获得报文，比如修改线程数为1，容量为1，或者关闭某些flag导致服务不可用
这个问题是需要尽快解决的
This is a security issue, and our security department has repeatedly reported to us the 'nameserver' unauthorized configuration modification vulnerability, which is difficult for our research and development team to solve
Although your 'CVS 2023 37582' fix code prohibits key attributes, other attributes have been maliciously modified by hackers, which may cause the service to be unusable. Use the 'mqadmin' modified packet to grab the message and obtain it, such as modifying the number of threads to 1 and the capacity to 1, or closing certain flags to cause the service to be unusable
This problem needs to be resolved as soon as possible

后面ACL这块会有一个比较完善的设计，敬请期待

hi, seems that you can refer to this RIP, the new version is comming soon https://github.com/apache/rocketmq/issues/7560

Search before creation
* [x]  I had searched in the [issues](https://github.com/apache/rocketmq/issues) and found no similar issues.

Documentation Related
有对nameserver进行权限访问吗。 比如用户密码，我现在看到的全是broker，而且在issue和doc中都找到
Are you willing to submit PR?
* [ ]  Yes I am willing to submit a PR!

考虑到ACL配置存储在broker, namesrv要支持ACL就要反向依赖Broker，不太合适，暂不考虑支持

Can be discussed under this issue，https://github.com/apache/rocketmq/issues/7560


Page will not load completely

Challenge http://freecodecamp.com/challenges/waypoint-declare-javascript-variables has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
Both the code editor on the right side as the small challenges on the left are strangers.I have changed my browser to try and they do not carry through.

Thanks for posting an issue!
Can you explain what you mean?  It is asking you to declare a variable myName and set it equal to a string containing your name on line 2.

Hello!
In the exercises about jQuery, each lesson proposed some steps to complete it. The screen was as the picture 1, showing all fully loaded and each completed step showed a "check"::

In Javascript exercises, the screen both the right and left are not fully loaded. In place of "checks" there javascript code.

Yes that is correct, it shows you the exact code that it runs to test your JS exercises.
This is on purpose to help you see better what test is failing and why.

Got it. Thank you for the answer!


Shopify Storefront with Coinbase Commerce checkout

What changed? Why?
Added new tutorial
Notes to reviewers
Tutorial require a Shopify + Commerce managed account
How has it been tested?

🟡
Heimdall Review Status

Item
Status
More Info

Minimum Required Reviews

🟡
0/1

Show calculation

Show calculations

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculations

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

📝 Heimdall docs
·
🕵 Advanced details
·
♻ Refresh Heimdall
·
#⃣ #ask-heimdall


feat(CategoryTheory): the triangle identity for the tensor product of graded objects

In this PR, we construct the left and right unitors for the tensor product of graded objects and we obtain the triangle identity.

After one more PR about the pentagon relation, we shall get the monoidal structure...

[x] depends on: #14339

Thanks :tada:
bors merge


Extrapolation into the past

Hi,
I recorded a rosbag file including color and depth images as well as tf and tf_static with a robot.
I use the depth_image_proc/point_cloud_xyzrgb nodelet to create point clouds as input for voxblox. The result looks ok, but it is not deterministic.
I inserted some console outputs in the voxblox code to see what is going on. Apparently, the tf lookup between world and camera fails a lot.
Lookup would require extrapolation into the past.  Requested time<PHONE_NUMBER>.722519152 but the earliest data is at time<PHONE_NUMBER>.744975090, when looking up transform from frame [head_rgbd_sensor_rgb_frame] to frame [map]
I'm surprised because the difference between the two timestamps is not very big and tf should store 10 seconds by default. It usually fails for 40-50 consecutive frames.
As soon as the rosbag player finishes (output in the terminal [player-5] process has finished cleanly), voxblox can handle all the remaining frames without a problem. Although there are still 300 frames to integrate and the queue only saves 10?
Do you have any ideas why that happens? Thank you for your help!

After dealing with that problem for several days, the solution was very simple. Play the rosbag file with -r 0.1 solved it!


It doesn't obey instructions

00:48 anildigital: faunabot: the rules
00:48 anildigital: faunabot: hubot the rules
00:48 anildigital: faunabot: die
00:48 anildigital: faunabot die
00:48 anildigital: faunabot the rules

Closed, same as https://github.com/nandub/hubot-irc/issues/4

I can confirm I'm having the same problem.

Just to add more information, I'm running the latests node.js, hubot and hubot-irc. I'm on xubuntu 11.10. Debug mode doesn't show anything, hubot just refuses to communicate with me.
I think this ticket should be reopened as there is obviously another, different issue from #2 and #4.

I've installed with npm, bot is connected, no I/O over IRC, the shell shows every action as intended, but doesn't respond to:
hubot help
Korvin1 help
korvin1 help
Hubot help

Nothing =\

From Korvin to #testing: Help
#testing <Korvin> Help
From Korvin to #testing: Korvin1 help
#testing <Korvin> Korvin1 help
From Korvin to #testing: korvin1 help
#testing <Korvin> korvin1 help


this.clone() is undefined

There's a call to this.clone() in Model.js; I think it's supposed to be this._clone()?


ci: Use travisci-tools script to trigger-fullstack-compat suite.

Summary

This uses the script from travisci-tools repo to trigger compat suite.

Test plan
Issues

OASIS-4389

Pull Request Test Coverage Report for Build 924

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.038%

Totals

Change from base Build 914:
0.0%

Covered Lines:
2648

Relevant Lines:
2974

💛  - Coveralls


Add cookiecutter-awesome to section Other

add cookiecutter-awesome to section "Other"

also add link to awesome in description

Codecov Report

Merging #1051 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1051   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          18      18
  Lines         781     781
======================================
  Hits          781     781

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7154cf2...b71120e. Read the comment docs.

Hey @Pawamoy! 👋
Thank you for this PR 🙇


chore: release main

:robot: I have created a release beep boop
accesskit: 0.8.1
0.8.1 (2023-03-16)
⚠ BREAKING CHANGES

Move thread synchronization into platform adapters; drop parking_lot (#212)
Make Node opaque and optimize it for size (#205)

Features

Test CI (b4af465)

Bug Fixes

Set appropriate representations on all public types that will be exposed via FFI (54e82f6)

Documentation

Fix outdated documentation for TreeUpdate (#182) (dd658c7)

Code Refactoring

Make Node opaque and optimize it for size (#205) (4811152)
Move thread synchronization into platform adapters; drop parking_lot (#212) (5df52e5)

accesskit_c: 0.1.0
0.1.0 (2023-03-16)
Features

Test CI (b4af465)

Dependencies

The following workspace dependencies were updated

dependencies

accesskit bumped from 0.10.1 to 0.8.1
accesskit_windows bumped from 0.13.2 to 0.14.0
accesskit_macos bumped from 0.6.1 to 0.7.0
accesskit_unix bumped from 0.3.2 to 0.4.0

accesskit_consumer: 0.15.0
0.15.0 (2023-03-16)
⚠ BREAKING CHANGES

Move thread synchronization into platform adapters; drop parking_lot (#212)
Make Node opaque and optimize it for size (#205)

Features

Automatically get button and link labels from descendants (#184) (ec5c38e)
Basic Unix platform adapter (#198) (1cea32e)
Text support on macOS (#191) (3a35dbe)

Bug Fixes

Make Node::filtered_parent recursive as it was meant to be (#203) (d2faef5)
More reliable handling of the edge case for wrapped lines (#192) (c626d2c)

Code Refactoring

Make Node opaque and optimize it for size (#205) (4811152)
Move thread synchronization into platform adapters; drop parking_lot (#212) (5df52e5)

Dependencies

The following workspace dependencies were updated

dependencies

accesskit bumped from 0.10.1 to 0.8.1

accesskit_macos: 0.7.0
0.7.0 (2023-03-16)
⚠ BREAKING CHANGES

Move thread synchronization into platform adapters; drop parking_lot (#212)
Make Node opaque and optimize it for size (#205)
Move lazy initialization from the core platform adapter to the caller (#179)

Features

Live regions on macOS (#196) (47d8d9f)
Text support on macOS (#191) (3a35dbe)

Bug Fixes

Correctly apply the DPI scale factor to coordinates (#185) (d263938)
Don't expose the window title in our root element on macOS (#187) (9739b74)
Expose static text as the value rather than the title on macOS (#186) (e3720c8)
Expose which accessibility selectors are actually allowed for a particular node (#181) (c4cbb23)
Fix macOS leaks (e8537fc)
Handle views with flipped coordinates (#174) (d14484c)
Make VoiceOver move through nodes in logical order (#176) (f060be4)
More reliable handling of the edge case for wrapped lines (#192) (c626d2c)
Pin objc2 dependency to 0.3.0-beta.3 (#201) (0adfed1)
Re-export types from objc2 (#172) (1ac67ad)

Code Refactoring

Make Node opaque and optimize it for size (#205) (4811152)
Move lazy initialization from the core platform adapter to the caller (#179) (f35c941)
Move thread synchronization into platform adapters; drop parking_lot (#212) (5df52e5)

Dependencies

The following workspace dependencies were updated

dependencies

accesskit bumped from 0.10.1 to 0.8.1
accesskit_consumer bumped from 0.14.1 to 0.15.0

accesskit_unix: 0.4.0
0.4.0 (2023-03-16)
⚠ BREAKING CHANGES

Move thread synchronization into platform adapters; drop parking_lot (#212)
Make Node opaque and optimize it for size (#205)

Features

Basic Unix platform adapter (#198) (1cea32e)

Bug Fixes

Update atspi dependency (#217) (93f2dc9)

Code Refactoring

Make Node opaque and optimize it for size (#205) (4811152)
Move thread synchronization into platform adapters; drop parking_lot (#212) (5df52e5)

Dependencies

The following workspace dependencies were updated

dependencies

accesskit bumped from 0.10.1 to 0.8.1
accesskit_consumer bumped from 0.14.1 to 0.15.0

accesskit_windows: 0.14.0
0.14.0 (2023-03-16)
⚠ BREAKING CHANGES

Move thread synchronization into platform adapters; drop parking_lot (#212)
Make Node opaque and optimize it for size (#205)
Update winit to 0.28 (#207)
Move lazy initialization from the core platform adapter to the caller (#179)

Bug Fixes

Correct broken UIA method implementation that was incompatible with Windows 11 ATs (#193) (3c527c7)
Fix Windows 32-bit build errors (#223) (41f28b6)
More reliable handling of the edge case for wrapped lines (#192) (c626d2c)
Provide fallback property implementations for the window root (#194) (f3d30b9)
Update windows-rs to 0.44 (#220) (a6b0a12)

Miscellaneous Chores

Update winit to 0.28 (#207) (3ff0cf5)

Code Refactoring

Make Node opaque and optimize it for size (#205) (4811152)
Move lazy initialization from the core platform adapter to the caller (#179) (f35c941)
Move thread synchronization into platform adapters; drop parking_lot (#212) (5df52e5)

Dependencies

The following workspace dependencies were updated

dependencies

accesskit bumped from 0.10.1 to 0.8.1
accesskit_consumer bumped from 0.14.1 to 0.15.0

accesskit_winit: 0.13.0
0.13.0 (2023-03-16)
⚠ BREAKING CHANGES

Move thread synchronization into platform adapters; drop parking_lot (#212)
Make Node opaque and optimize it for size (#205)
Update winit to 0.28 (#207)
Move lazy initialization from the core platform adapter to the caller (#179)

Features

Basic Unix platform adapter (#198) (1cea32e)
Feature-gate the Unix adapter in accesskit_winit (#214) (be95807)

Bug Fixes

Don't force winit's X11 and Wayland features to be enabled (#209) (a3ed357)
Reduce the winit version requirement to match egui (#170) (1d27482)

Miscellaneous Chores

Update winit to 0.28 (#207) (3ff0cf5)

Code Refactoring

Make Node opaque and optimize it for size (#205) (4811152)
Move lazy initialization from the core platform adapter to the caller (#179) (f35c941)
Move thread synchronization into platform adapters; drop parking_lot (#212) (5df52e5)

Dependencies

The following workspace dependencies were updated

dependencies

accesskit bumped from 0.10.1 to 0.8.1
accesskit_windows bumped from 0.13.2 to 0.14.0
accesskit_macos bumped from 0.6.2 to 0.7.0
accesskit_unix bumped from 0.3.2 to 0.4.0

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit-v0.8.1 :sunflower:

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit_consumer-v0.15.0 :sunflower:

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit_macos-v0.7.0 :sunflower:

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit_unix-v0.4.0 :sunflower:

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit_windows-v0.14.0 :sunflower:

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit_winit-v0.13.0 :sunflower:

:robot: Release is at https://github.com/DataTriny/accesskit/releases/tag/accesskit_c-v0.1.0 :sunflower:


Vulkan Swapchain Refactor

Refactoring vulkan swapchain. By abstracting this inside the Window class.
The current design was quite messy in the sense of simply creating a window using Vulkan and made it very difficult to follow.
Hence the refactor to make the codebase at least readable and follow to how we reference the data from windows to the swapchain easier to manage.

Vulkan Swapchain refactor is almost finished. Currently what is being done is implementing how images are going be iterated and rendered to the display. Making sure that when we flush command buffers it makes it easier on how we submit command buffers to the swapchain.
Currently will be testing acquiring the next images before submitting my PR.

Vulkan Swapchain has been implemented.
There are still some things we should take care of. Which will be framebuffers and a few abstraction API's before doing the buffers. To handle showing the display logic to the vulkan abstraction layer, instead.

Closing this issue. Swapchain has been fully refactored and is already in-use.


Wasm relocations?

Hi,
I want to construct wasm object files using object (does the object libary support wasm?).
If it does support wasm, how can i access the:
R_WASM_FUNCTION_INDEX_LEB- relocation kind?
Bye

Ok thanks


awsebcli: fix up, requests and future dependencies

Description of changes
after
https://github.com/NixOS/nixpkgs/pull/210072 and
https://github.com/NixOS/nixpkgs/pull/210778
awsebcli no longer builds
as for future, its being remove upstream https://github.com/aws/aws-elastic-beanstalk-cli/pull/277/
and requests is a tiny bump so shouldnt be any issues there
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cc @mweinelt @SuperSandro2000

Backported as PR #215468

Did we think about just dropping all constraints instead of micro managing them?

IMHO that's a question more for the upstream(s).


Add KUBECTL_EXTERNAL_DIFF_OPTIONS env var to set custom diff command options

What would you like to be added:
I'd like an environment variable KUBECTL_EXTERNAL_DIFF_OPTIONS to be added in order to be able to customize the options when using a diff command other than diff when using kubectl
The related part of the code https://github.com/kubernetes/kubectl/blob/f00cf713934555e6edd635bd7477f028056eda50/pkg/cmd/diff/diff.go#L168
Why is this needed:
When using the default diff command, the options -u and -N are set by default. I'd like to have these same options when using colordiff, and also be able to add any other options that might be necessary

I think make sense. Let me try to prepare a patch.

/assign

With the provided patch the following commands work:
 $ export KUBECTL_EXTERNAL_DIFF="colordiff -N -u"
 $ kubectl diff -f filename.yaml

/assign @seans3

@julienvey Please note an environment variable already exists for choosing the diff program. According to kubectl diff -h:
KUBECTL_EXTERNAL_DIFF environment variable can be used to select your own diff command. By default, the "diff" command
available in your path will be run with "-u" (unified diff) and "-N" (treat absent files as empty) options.

An example is:
export KUBECTL_EXTERNAL_DIFF=meld; kubectl diff -k ./dir/

Closing

/triage accepted

patch is merged, thanks for the report.
/close

patch is merged, thanks for the report.
/close

There is still a small gap: When using GNU diffutils, some commands (e.g. --color[=WHEN]) require an equal sign, which is excluded by the specified regex (^[a-zA-Z0-9-]+$)

There is still a small gap: When using GNU diffutils, some commands (e.g. --color[=WHEN]) require an equal sign, which is excluded by the specified regex (^[a-zA-Z0-9-]+$)


Unresolved dependencies when sbt compile

Hi,
With the latest commit(980778b1874b93b7e2778eb0c8f666f9691176f1), i got unresolved dependencies when running sbt compile and download failed in the end.
log shows below:
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.apache.httpcomponents#httpclient;4.3.6: typesafe-ivy-releases: unable to get resource for org.apache.httpcomponents#httpclient;4.3.6: res=https://repo.typesafe.com/typesafe/ivy-releases/org.apache.httpcomponents/httpclient/4.3.6/jars/httpclient.jar: java.net.SocketTimeoutException: timeout
[warn] 	:: ws.unfiltered#unfiltered_2.12;0.9.1: not found
[warn] 	:: com.typesafe#config;1.2.1: typesafe-ivy-releases: unable to get resource for com.typesafe#config;1.2.1: res=https://repo.typesafe.com/typesafe/ivy-releases/com.typesafe/config/1.2.1/bundles/config.jar: java.net.SocketTimeoutException: timeout
[warn] 	:: org.jruby#jruby-complete;1.7.21: sbt-plugin-releases: unable to get resource for org.jruby#jruby-parent;1.7.21: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.jruby/jruby-parent/1.7.21/ivys/ivy.xml: java.net.SocketTimeoutException: timeout
[warn] 	:: org.ow2.asm#asm;5.0.3: sbt-plugin-releases: unable to get resource for org.ow2.asm#asm;5.0.3: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.ow2.asm/asm/5.0.3/jars/asm.jar: java.net.SocketTimeoutException: timeout
[warn] 	:: org.ow2.asm#asm-tree;5.0.3: public: unable to get resource for org/ow2/asm#asm-tree;5.0.3: res=https://repo1.maven.org/maven2/org/ow2/asm/asm-tree/5.0.3/asm-tree-5.0.3.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[warn] 	:: com.typesafe#config;1.3.1: not found
[warn] 	:: org.scala-lang.modules#scala-java8-compat_2.12;0.8.0: public: unable to get resource for org/scala-lang/modules#scala-java8-compat_2.12;0.8.0: res=https://repo1.maven.org/maven2/org/scala-lang/modules/scala-java8-compat_2.12/0.8.0/scala-java8-compat_2.12-0.8.0.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[warn] 	:: org.webjars#webjars-locator-core;0.32: public: unable to get resource for org/webjars#webjars-locator-core;0.32: res=https://repo1.maven.org/maven2/org/webjars/webjars-locator-core/0.32/webjars-locator-core-0.32.jar: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[warn] 	:: org.scalactic#scalactic_2.12;3.0.1: Resolution failed several times for dependency: org.scalactic#scalactic_2.12;3.0.1 {compile=[default(compile)]}::
[warn] 	typesafe-ivy-releases: unable to get resource for org.scalactic#scalactic_2.12;3.0.1: res=https://repo.typesafe.com/typesafe/ivy-releases/org.scalactic/scalactic_2.12/3.0.1/bundles/scalactic_2.12.jar: java.net.SocketTimeoutException: Read timed out
[warn] 	sbt-plugin-releases: unable to get resource for org.scalactic#scalactic_2.12;3.0.1: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scalactic/scalactic_2.12/3.0.1/ivys/ivy.xml: java.net.ConnectException: Failed to connect to dl.bintray.com/<IP_ADDRESS>:443
[warn] 	:: org.ow2.asm#asm-tree;6.0: sbt-plugin-releases: unable to get resource for org.ow2.asm#asm-tree;6.0: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.ow2.asm/asm-tree/6.0/jars/asm-tree.jar: java.net.SocketTimeoutException: timeout
[warn] 	:: javax.enterprise#cdi-api;1.0: typesafe-ivy-releases: unable to get resource for org.jboss.weld#weld-api-bom;1.0: res=https://repo.typesafe.com/typesafe/ivy-releases/org.jboss.weld/weld-api-bom/1.0/jars/weld-api-bom.jar: java.net.SocketTimeoutException: timeout
[warn] 	:: com.eed3si9n#sjson-new-scalajson_2.12;0.8.2: public: unable to get resource for com/eed3si9n#sjson-new-scalajson_2.12;0.8.2: res=https://repo1.maven.org/maven2/com/eed3si9n/sjson-new-scalajson_2.12/0.8.2/sjson-new-scalajson_2.12-0.8.2.pom: java.net.SocketTimeoutException: timeout
[warn] 	:: org.scala-sbt#util-position_2.12;1.1.2: public: unable to get resource for org/scala-sbt#util-position_2.12;1.1.2: res=https://repo1.maven.org/maven2/org/scala-sbt/util-position_2.12/1.1.2/util-position_2.12-1.1.2.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[warn] 	:: org.apache.logging.log4j#log4j-api;2.8.1: public: unable to get resource for org/apache/logging/log4j#log4j;2.8.1: res=https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j/2.8.1/log4j-2.8.1.jar: java.net.SocketTimeoutException: Read timed out
[warn] 	:: org.scala-lang#scala-reflect;2.12.4: not found
[warn] 	:: org.scala-sbt#zinc-apiinfo_2.12;1.1.1: Resolution failed several times for dependency: org.scala-sbt#zinc-apiinfo_2.12;1.1.1 {compile=[compile(), master(compile)], runtime=[runtime()]}::
[warn] 	sbt-plugin-releases: unable to get resource for org.scala-sbt#zinc-apiinfo_2.12;1.1.1: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-sbt/zinc-apiinfo_2.12/1.1.1/ivys/ivy.xml: java.net.ConnectException: Failed to connect to dl.bintray.com/<IP_ADDRESS>:443
[warn] 	typesafe-ivy-releases: unable to get resource for org.scala-sbt#zinc-apiinfo_2.12;1.1.1: res=https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/zinc-apiinfo_2.12/1.1.1/jars/zinc-apiinfo_2.12.jar: java.net.SocketTimeoutException: Read timed out
[warn] 	:: org.slf4j#slf4j-api;1.7.25: sbt-plugin-releases: unable to get resource for org.slf4j#slf4j-parent;1.7.25: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.slf4j/slf4j-parent/1.7.25/jars/slf4j-parent.jar: java.net.SocketTimeoutException: timeout
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::              FAILED DOWNLOADS            ::
[warn] 	:: ^ see resolution messages for details  ^ ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: com.typesafe.sbt#sbt-web;1.4.2!sbt-web.jar
[warn] 	:: org.scala-sbt#util-control_2.12;1.1.2!util-control_2.12.jar
[warn] 	:: org.apache.logging.log4j#log4j-core;2.8.1!log4j-core.jar
[warn] 	:: org.scala-sbt#zinc_2.12;1.1.1!zinc_2.12.jar
[warn] 	:: com.trueaccord.lenses#lenses_2.12;0.4.12!lenses_2.12.jar
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.scala-lang.modules:scala-java8-compat_2.12:0.8.0
[warn] 		  +- com.typesafe.akka:akka-actor_2.12:2.5.4
[warn] 		  +- com.typesafe.sbt:sbt-web:1.4.2 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.lightbend.paradox:sbt-paradox:0.3.0 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.typesafe.sbt:sbt-site:1.3.1 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L9-10)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		ws.unfiltered:unfiltered_2.12:0.9.1
[warn] 		  +- ws.unfiltered:unfiltered-filter_2.12:0.9.1
[warn] 		  +- com.typesafe.sbt:sbt-site:1.3.1 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L9-10)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.scala-sbt:zinc-apiinfo_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-core_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-persist_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc_2.12:1.1.1
[warn] 		  +- org.scala-sbt:actions_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main_2.12:1.1.1
[warn] 		  +- org.scala-sbt:sbt:1.1.1
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.jruby:jruby-complete:1.7.21
[warn] 		  +- org.asciidoctor:asciidoctorj:1.5.4
[warn] 		  +- com.typesafe.sbt:sbt-site:1.3.1 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L9-10)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.scalactic:scalactic_2.12:3.0.1
[warn] 		  +- com.eed3si9n:sbt-assembly:0.14.6 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L19-20)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.slf4j:slf4j-api:1.7.25
[warn] 		  +- com.eed3si9n:gigahorse-core_2.12:0.3.0
[warn] 		  +- com.eed3si9n:gigahorse-okhttp_2.12:0.3.0
[warn] 		  +- org.scala-sbt:librarymanagement-core_2.12:1.1.3
[warn] 		  +- org.scala-sbt:command_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main-settings_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main_2.12:1.1.1
[warn] 		  +- org.scala-sbt:sbt:1.1.1
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.webjars:webjars-locator-core:0.32
[warn] 		  +- com.typesafe.sbt:sbt-web:1.4.2 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.lightbend.paradox:sbt-paradox:0.3.0 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.typesafe.sbt:sbt-site:1.3.1 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L9-10)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.ow2.asm:asm-tree:6.0
[warn] 		  +- org.ow2.asm:asm-commons:6.0
[warn] 		  +- org.pantsbuild:jarjar:1.6.5
[warn] 		  +- com.eed3si9n:sbt-assembly:0.14.6 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L19-20)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		com.typesafe:config:1.3.1
[warn] 		  +- com.typesafe.akka:akka-actor_2.12:2.5.4
[warn] 		  +- com.typesafe.sbt:sbt-web:1.4.2 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.lightbend.paradox:sbt-paradox:0.3.0 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.typesafe.sbt:sbt-site:1.3.1 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L9-10)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.apache.httpcomponents:httpclient:4.3.6
[warn] 		  +- org.eclipse.jgit:org.eclipse.jgit:<IP_ADDRESS>609210915-r
[warn] 		  +- com.typesafe.sbt:sbt-git:0.9.3 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		  +- com.typesafe.sbt:sbt-ghpages:0.6.2 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L7-8)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		com.eed3si9n:sjson-new-scalajson_2.12:0.8.2
[warn] 		  +- org.scala-sbt:util-logging_2.12:1.1.2
[warn] 		  +- org.scala-sbt:zinc-classfile_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-compile-core_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-ivy-integration_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc_2.12:1.1.1
[warn] 		  +- org.scala-sbt:actions_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main_2.12:1.1.1
[warn] 		  +- org.scala-sbt:sbt:1.1.1
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.apache.logging.log4j:log4j-api:2.8.1
[warn] 		  +- org.scala-sbt:util-logging_2.12:1.1.2
[warn] 		  +- org.scala-sbt:zinc-classfile_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-compile-core_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-ivy-integration_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc_2.12:1.1.1
[warn] 		  +- org.scala-sbt:actions_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main_2.12:1.1.1
[warn] 		  +- org.scala-sbt:sbt:1.1.1
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.scala-lang:scala-reflect:2.12.4
[warn] 		  +- org.scala-sbt:util-logging_2.12:1.1.2
[warn] 		  +- org.scala-sbt:zinc-classfile_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-compile-core_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc-ivy-integration_2.12:1.1.1
[warn] 		  +- org.scala-sbt:zinc_2.12:1.1.1
[warn] 		  +- org.scala-sbt:actions_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main_2.12:1.1.1
[warn] 		  +- org.scala-sbt:sbt:1.1.1
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		javax.enterprise:cdi-api:1.0
[warn] 		  +- org.eclipse.sisu:org.eclipse.sisu.plexus:0.3.2
[warn] 		  +- org.apache.maven:maven-plugin-api:3.3.9
[warn] 		  +- org.pantsbuild:jarjar:1.6.5
[warn] 		  +- com.eed3si9n:sbt-assembly:0.14.6 (scalaVersion=2.12, sbtVersion=1.0) (/home/Dream-yang/work-riscv/rocket-chip/firrtl/project/plugins.sbt#L19-20)
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[warn] 		org.scala-sbt:util-position_2.12:1.1.2
[warn] 		  +- org.scala-sbt:collections_2.12:1.1.1
[warn] 		  +- org.scala-sbt:tasks_2.12:1.1.1
[warn] 		  +- org.scala-sbt:task-system_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main-settings_2.12:1.1.1
[warn] 		  +- org.scala-sbt:main_2.12:1.1.1
[warn] 		  +- org.scala-sbt:sbt:1.1.1
[warn] 		  +- default:firrtl-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[error] sbt.librarymanagement.ResolveException: unresolved dependency: org.apache.httpcomponents#httpclient;4.3.6: typesafe-ivy-releases: unable to get resource for org.apache.httpcomponents#httpclient;4.3.6: res=https://repo.typesafe.com/typesafe/ivy-releases/org.apache.httpcomponents/httpclient/4.3.6/jars/httpclient.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: ws.unfiltered#unfiltered_2.12;0.9.1: not found
[error] unresolved dependency: com.typesafe#config;1.2.1: typesafe-ivy-releases: unable to get resource for com.typesafe#config;1.2.1: res=https://repo.typesafe.com/typesafe/ivy-releases/com.typesafe/config/1.2.1/bundles/config.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.jruby#jruby-complete;1.7.21: sbt-plugin-releases: unable to get resource for org.jruby#jruby-parent;1.7.21: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.jruby/jruby-parent/1.7.21/ivys/ivy.xml: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.ow2.asm#asm;5.0.3: sbt-plugin-releases: unable to get resource for org.ow2.asm#asm;5.0.3: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.ow2.asm/asm/5.0.3/jars/asm.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.ow2.asm#asm-tree;5.0.3: public: unable to get resource for org/ow2/asm#asm-tree;5.0.3: res=https://repo1.maven.org/maven2/org/ow2/asm/asm-tree/5.0.3/asm-tree-5.0.3.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: com.typesafe#config;1.3.1: not found
[error] unresolved dependency: org.scala-lang.modules#scala-java8-compat_2.12;0.8.0: public: unable to get resource for org/scala-lang/modules#scala-java8-compat_2.12;0.8.0: res=https://repo1.maven.org/maven2/org/scala-lang/modules/scala-java8-compat_2.12/0.8.0/scala-java8-compat_2.12-0.8.0.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: org.webjars#webjars-locator-core;0.32: public: unable to get resource for org/webjars#webjars-locator-core;0.32: res=https://repo1.maven.org/maven2/org/webjars/webjars-locator-core/0.32/webjars-locator-core-0.32.jar: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: org.scalactic#scalactic_2.12;3.0.1: Resolution failed several times for dependency: org.scalactic#scalactic_2.12;3.0.1 {compile=[default(compile)]}::
[error] 	typesafe-ivy-releases: unable to get resource for org.scalactic#scalactic_2.12;3.0.1: res=https://repo.typesafe.com/typesafe/ivy-releases/org.scalactic/scalactic_2.12/3.0.1/bundles/scalactic_2.12.jar: java.net.SocketTimeoutException: Read timed out
[error] 	sbt-plugin-releases: unable to get resource for org.scalactic#scalactic_2.12;3.0.1: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scalactic/scalactic_2.12/3.0.1/ivys/ivy.xml: java.net.ConnectException: Failed to connect to dl.bintray.com/<IP_ADDRESS>:443
[error]
[error] unresolved dependency: org.ow2.asm#asm-tree;6.0: sbt-plugin-releases: unable to get resource for org.ow2.asm#asm-tree;6.0: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.ow2.asm/asm-tree/6.0/jars/asm-tree.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: javax.enterprise#cdi-api;1.0: typesafe-ivy-releases: unable to get resource for org.jboss.weld#weld-api-bom;1.0: res=https://repo.typesafe.com/typesafe/ivy-releases/org.jboss.weld/weld-api-bom/1.0/jars/weld-api-bom.jar: java.net.SocketTimeoutException: timeout
[error] download failed: com.typesafe.sbt#sbt-web;1.4.2!sbt-web.jar
[error] unresolved dependency: com.eed3si9n#sjson-new-scalajson_2.12;0.8.2: public: unable to get resource for com/eed3si9n#sjson-new-scalajson_2.12;0.8.2: res=https://repo1.maven.org/maven2/com/eed3si9n/sjson-new-scalajson_2.12/0.8.2/sjson-new-scalajson_2.12-0.8.2.pom: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.scala-sbt#util-position_2.12;1.1.2: public: unable to get resource for org/scala-sbt#util-position_2.12;1.1.2: res=https://repo1.maven.org/maven2/org/scala-sbt/util-position_2.12/1.1.2/util-position_2.12-1.1.2.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: org.apache.logging.log4j#log4j-api;2.8.1: public: unable to get resource for org/apache/logging/log4j#log4j;2.8.1: res=https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j/2.8.1/log4j-2.8.1.jar: java.net.SocketTimeoutException: Read timed out
[error] unresolved dependency: org.scala-lang#scala-reflect;2.12.4: not found
[error] unresolved dependency: org.scala-sbt#zinc-apiinfo_2.12;1.1.1: Resolution failed several times for dependency: org.scala-sbt#zinc-apiinfo_2.12;1.1.1 {compile=[compile(), master(compile)], runtime=[runtime()]}::
[error] 	sbt-plugin-releases: unable to get resource for org.scala-sbt#zinc-apiinfo_2.12;1.1.1: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-sbt/zinc-apiinfo_2.12/1.1.1/ivys/ivy.xml: java.net.ConnectException: Failed to connect to dl.bintray.com/<IP_ADDRESS>:443
[error] 	typesafe-ivy-releases: unable to get resource for org.scala-sbt#zinc-apiinfo_2.12;1.1.1: res=https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/zinc-apiinfo_2.12/1.1.1/jars/zinc-apiinfo_2.12.jar: java.net.SocketTimeoutException: Read timed out
[error]
[error] unresolved dependency: org.slf4j#slf4j-api;1.7.25: sbt-plugin-releases: unable to get resource for org.slf4j#slf4j-parent;1.7.25: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.slf4j/slf4j-parent/1.7.25/jars/slf4j-parent.jar: java.net.SocketTimeoutException: timeout
[error] download failed: org.scala-sbt#util-control_2.12;1.1.2!util-control_2.12.jar
[error] download failed: org.apache.logging.log4j#log4j-core;2.8.1!log4j-core.jar
[error] download failed: org.scala-sbt#zinc_2.12;1.1.1!zinc_2.12.jar
[error] download failed: com.trueaccord.lenses#lenses_2.12;0.4.12!lenses_2.12.jar
[error] 	at sbt.internal.librarymanagement.IvyActions$.resolveAndRetrieve(IvyActions.scala:331)
[error] 	at sbt.internal.librarymanagement.IvyActions$.$anonfun$updateEither$1(IvyActions.scala:205)
[error] 	at sbt.internal.librarymanagement.IvySbt$Module.$anonfun$withModule$1(Ivy.scala:243)
[error] 	at sbt.internal.librarymanagement.IvySbt.$anonfun$withIvy$1(Ivy.scala:204)
[error] 	at sbt.internal.librarymanagement.IvySbt.sbt$internal$librarymanagement$IvySbt$$action$1(Ivy.scala:70)
[error] 	at sbt.internal.librarymanagement.IvySbt$$anon$3.call(Ivy.scala:77)
[error] 	at xsbt.boot.Locks$GlobalLock.withChannel$1(Locks.scala:95)
[error] 	at xsbt.boot.Locks$GlobalLock.xsbt$boot$Locks$GlobalLock$$withChannelRetries$1(Locks.scala:80)
[error] 	at xsbt.boot.Locks$GlobalLock$$anonfun$withFileLock$1.apply(Locks.scala:99)
[error] 	at xsbt.boot.Using$.withResource(Using.scala:10)
[error] 	at xsbt.boot.Using$.apply(Using.scala:9)
[error] 	at xsbt.boot.Locks$GlobalLock.ignoringDeadlockAvoided(Locks.scala:60)
[error] 	at xsbt.boot.Locks$GlobalLock.withLock(Locks.scala:50)
[error] 	at xsbt.boot.Locks$.apply0(Locks.scala:31)
[error] 	at xsbt.boot.Locks$.apply(Locks.scala:28)
[error] 	at sbt.internal.librarymanagement.IvySbt.withDefaultLogger(Ivy.scala:77)
[error] 	at sbt.internal.librarymanagement.IvySbt.withIvy(Ivy.scala:199)
[error] 	at sbt.internal.librarymanagement.IvySbt.withIvy(Ivy.scala:196)
[error] 	at sbt.internal.librarymanagement.IvySbt$Module.withModule(Ivy.scala:242)
[error] 	at sbt.internal.librarymanagement.IvyActions$.updateEither(IvyActions.scala:190)
[error] 	at sbt.librarymanagement.ivy.IvyDependencyResolution.update(IvyDependencyResolution.scala:20)
[error] 	at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:56)
[error] 	at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:46)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:99)
[error] 	at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:68)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$19(LibraryManagement.scala:112)
[error] 	at scala.util.control.Exception$Catch.apply(Exception.scala:224)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:112)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:95)
[error] 	at sbt.util.Tracked$.$anonfun$inputChanged$1(Tracked.scala:149)
[error] 	at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:126)
[error] 	at sbt.Classpaths$.$anonfun$updateTask$5(Defaults.scala:2383)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:39)
[error] 	at sbt.std.Transform$$anon$4.work(System.scala:66)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:262)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)
[error] 	at sbt.Execute.work(Execute.scala:271)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:262)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:174)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:36)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:748)
[error] (update) sbt.librarymanagement.ResolveException: unresolved dependency: org.apache.httpcomponents#httpclient;4.3.6: typesafe-ivy-releases: unable to get resource for org.apache.httpcomponents#httpclient;4.3.6: res=https://repo.typesafe.com/typesafe/ivy-releases/org.apache.httpcomponents/httpclient/4.3.6/jars/httpclient.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: ws.unfiltered#unfiltered_2.12;0.9.1: not found
[error] unresolved dependency: com.typesafe#config;1.2.1: typesafe-ivy-releases: unable to get resource for com.typesafe#config;1.2.1: res=https://repo.typesafe.com/typesafe/ivy-releases/com.typesafe/config/1.2.1/bundles/config.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.jruby#jruby-complete;1.7.21: sbt-plugin-releases: unable to get resource for org.jruby#jruby-parent;1.7.21: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.jruby/jruby-parent/1.7.21/ivys/ivy.xml: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.ow2.asm#asm;5.0.3: sbt-plugin-releases: unable to get resource for org.ow2.asm#asm;5.0.3: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.ow2.asm/asm/5.0.3/jars/asm.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.ow2.asm#asm-tree;5.0.3: public: unable to get resource for org/ow2/asm#asm-tree;5.0.3: res=https://repo1.maven.org/maven2/org/ow2/asm/asm-tree/5.0.3/asm-tree-5.0.3.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: com.typesafe#config;1.3.1: not found
[error] unresolved dependency: org.scala-lang.modules#scala-java8-compat_2.12;0.8.0: public: unable to get resource for org/scala-lang/modules#scala-java8-compat_2.12;0.8.0: res=https://repo1.maven.org/maven2/org/scala-lang/modules/scala-java8-compat_2.12/0.8.0/scala-java8-compat_2.12-0.8.0.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: org.webjars#webjars-locator-core;0.32: public: unable to get resource for org/webjars#webjars-locator-core;0.32: res=https://repo1.maven.org/maven2/org/webjars/webjars-locator-core/0.32/webjars-locator-core-0.32.jar: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: org.scalactic#scalactic_2.12;3.0.1: Resolution failed several times for dependency: org.scalactic#scalactic_2.12;3.0.1 {compile=[default(compile)]}::
[error] 	typesafe-ivy-releases: unable to get resource for org.scalactic#scalactic_2.12;3.0.1: res=https://repo.typesafe.com/typesafe/ivy-releases/org.scalactic/scalactic_2.12/3.0.1/bundles/scalactic_2.12.jar: java.net.SocketTimeoutException: Read timed out
[error] 	sbt-plugin-releases: unable to get resource for org.scalactic#scalactic_2.12;3.0.1: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scalactic/scalactic_2.12/3.0.1/ivys/ivy.xml: java.net.ConnectException: Failed to connect to dl.bintray.com/<IP_ADDRESS>:443
[error]
[error] unresolved dependency: org.ow2.asm#asm-tree;6.0: sbt-plugin-releases: unable to get resource for org.ow2.asm#asm-tree;6.0: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.ow2.asm/asm-tree/6.0/jars/asm-tree.jar: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: javax.enterprise#cdi-api;1.0: typesafe-ivy-releases: unable to get resource for org.jboss.weld#weld-api-bom;1.0: res=https://repo.typesafe.com/typesafe/ivy-releases/org.jboss.weld/weld-api-bom/1.0/jars/weld-api-bom.jar: java.net.SocketTimeoutException: timeout
[error] download failed: com.typesafe.sbt#sbt-web;1.4.2!sbt-web.jar
[error] unresolved dependency: com.eed3si9n#sjson-new-scalajson_2.12;0.8.2: public: unable to get resource for com/eed3si9n#sjson-new-scalajson_2.12;0.8.2: res=https://repo1.maven.org/maven2/com/eed3si9n/sjson-new-scalajson_2.12/0.8.2/sjson-new-scalajson_2.12-0.8.2.pom: java.net.SocketTimeoutException: timeout
[error] unresolved dependency: org.scala-sbt#util-position_2.12;1.1.2: public: unable to get resource for org/scala-sbt#util-position_2.12;1.1.2: res=https://repo1.maven.org/maven2/org/scala-sbt/util-position_2.12/1.1.2/util-position_2.12-1.1.2.pom: java.net.ConnectException: Failed to connect to repo1.maven.org/<IP_ADDRESS>:443
[error] unresolved dependency: org.apache.logging.log4j#log4j-api;2.8.1: public: unable to get resource for org/apache/logging/log4j#log4j;2.8.1: res=https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j/2.8.1/log4j-2.8.1.jar: java.net.SocketTimeoutException: Read timed out
[error] unresolved dependency: org.scala-lang#scala-reflect;2.12.4: not found
[error] unresolved dependency: org.scala-sbt#zinc-apiinfo_2.12;1.1.1: Resolution failed several times for dependency: org.scala-sbt#zinc-apiinfo_2.12;1.1.1 {compile=[compile(), master(compile)], runtime=[runtime()]}::
[error] 	sbt-plugin-releases: unable to get resource for org.scala-sbt#zinc-apiinfo_2.12;1.1.1: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.scala-sbt/zinc-apiinfo_2.12/1.1.1/ivys/ivy.xml: java.net.ConnectException: Failed to connect to dl.bintray.com/<IP_ADDRESS>:443
[error] 	typesafe-ivy-releases: unable to get resource for org.scala-sbt#zinc-apiinfo_2.12;1.1.1: res=https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/zinc-apiinfo_2.12/1.1.1/jars/zinc-apiinfo_2.12.jar: java.net.SocketTimeoutException: Read timed out
[error]
[error] unresolved dependency: org.slf4j#slf4j-api;1.7.25: sbt-plugin-releases: unable to get resource for org.slf4j#slf4j-parent;1.7.25: res=https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.slf4j/slf4j-parent/1.7.25/jars/slf4j-parent.jar: java.net.SocketTimeoutException: timeout
[error] download failed: org.scala-sbt#util-control_2.12;1.1.2!util-control_2.12.jar
[error] download failed: org.apache.logging.log4j#log4j-core;2.8.1!log4j-core.jar
[error] download failed: org.scala-sbt#zinc_2.12;1.1.1!zinc_2.12.jar
[error] download failed: com.trueaccord.lenses#lenses_2.12;0.4.12!lenses_2.12.jar
Any help will be appreciated.
Thanks

See solution in freechipsproject/rocket-chip#1041


Added plugin to support Juju

Hi, and thanks for contributing.
What you want to add is based on code written by Benji York and distributed under GPLv3 so it cannot be simply integrated into a project that distributes under the MIT license.
My advice is that you create yourself a custom plugin.

Ok. I will close this and then open a new one.


wallet: sweep_all fix

Wasn't being properly detected and errored with "missing value"

Value error gone, but its not sweeping whole balance.
investigating

Fixed


Document what to do if a merged PR has a bug that was missed during PR reviews

Summary
We want to present a process for handling a scenario where a PR was merged and the community found out that there was a mistake with it.
Following the discussion in the issue, I created a new page called, Merged PR Scenario under the good decisions section inside of the contribute section.
This page describes what should be done depending the type of the feature merged in the PR (either low or high impact).
Ticket Link
Fixes #449

Hello @TomerPacific,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


coercing to Unicode: need string or buffer, ContentType found

Any idea about this?
ERROR:django.request:Internal Server Error: /admin/djangoseo/youlunmetadatamodel/add/
Traceback (most recent call last):
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
response = wrapped_callback(request, _callback_args, *_callback_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/contrib/admin/options.py", line 583, in wrapper
return self.admin_site.admin_view(view)(_args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/utils/decorators.py", line 105, in _wrapped_view
response = view_func(request, _args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/views/decorators/cache.py", line 52, in _wrapped_view_func
response = view_func(request, _args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 206, in inner
return view(request, _args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/contrib/admin/options.py", line 1453, in add_view
return self.changeform_view(request, None, form_url, extra_context)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/utils/decorators.py", line 29, in _wrapper
return bound_func(_args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/utils/decorators.py", line 105, in _wrapped_view
response = view_func(request, _args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/utils/decorators.py", line 25, in bound_func
return func.get(self, type(self))(_args2, *_kwargs2)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/db/transaction.py", line 394, in inner
return func(_args, *_kwargs)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/contrib/admin/options.py", line 1407, in changeform_view
self.log_addition(request, new_object)
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/contrib/admin/options.py", line 776, in log_addition
object_repr=force_text(object),
File "/home/vagrant/virtualenv/local/lib/python2.7/site-packages/django/utils/encoding.py", line 85, in force_text
s = six.text_type(s)
TypeError: coercing to Unicode: need string or buffer, ContentType found

https://github.com/romansalin/django-seo2/blob/952741849974415edc44bba0200d1c3b48c01fc2/djangoseo/backends.py#L451
I think this one should return a string, instead of content_type.

Thank you for the issue, I'm going to fix this within 24 hours.

We have hit this error too, the grappelli admin wont load because of it.
It also stops you from printing it in the console.
In [10]: ObjectMetaDataModel.objects.all()
Out[10]: ---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
... snip ...
TypeError: coercing to Unicode: need string or buffer, ContentType found

In [11]:

Same problem, is anybody knows how to fix if ?

fixed in: https://github.com/romansalin/django-seo2/commit/68d1184064fa3b94dafce93610191cc7fa5a5a04

Yeah, looks like this was in PR #13.
@romansalin any chance on getting a release uploaded to pypi?
Its been more than 24 hours :cry:

Hey @romansalin ,
Can you please release the new updated patch to pypi as the version downloaded via pip still throws this error.

@romansalin please release to pypi!

@romansalin bump!

@romansalin, please release the fix...


New version: ParticleHolography v0.1.2

Registering package: ParticleHolography
Repository: https://github.com/dainakai/ParticleHolography.jl
Created by: @dainakai
Version: v0.1.2
Commit: ba91cce3a42fa5e91b55a1d48c051499b452af20
Reviewed by: @dainakai
Reference: https://github.com/dainakai/ParticleHolography.jl/commit/ba91cce3a42fa5e91b55a1d48c051499b452af20#commitcomment-145206355
Description: ParticleHolography.jl: Holographic particle measurement in Julia.

stop registration


Dig only once

Doing some bash sanitization and reducing the number of calls to dig.
In particular, making sure we use the same list of endpoints when configuring and initializing the replica set.
Since we call wait_for_mongo_up for all endpoints in initiate_replica.sh, we ensure we have waited for all known endpoints before a call to rs.initiate, so this should fix what #98 was trying to solve.

@bparees @mfojtik @omron93 @grdryn please take a look

I've included one commit where I'm also reducing the number of steps/queries to connect to the primary to add / remove members. Mongo has a special syntax to connect to a replica set that automatically connect to the primary.

While testing this I ran into #125. If we're already broken, I'm not sure if my changes carry any harm.

I don't know if this is a new problem introduced by your change or not, but:  Is there any guarantee that before the post-deploy hook runs, all the replicas are added as endpoints to the service?
if not, we're not going to get the right membership list.
And I don't think it is guaranteed, I think the deployment is considered success once 90% of the replicas are ready, not 100%.
Otherwise the changes look sane and beneficial to me.

I don't know if this is a new problem introduced by your change or not,

The bug I reported was running the image from Docker Hub.
I deleted all locally built images, docker pulled, and setup the cluster example.

but: Is there any guarantee that before the post-deploy hook runs, all the replicas are added as endpoints to the service?

This is the right question. If it is not, then the subsequent calls getting more members is just "accidental", and not correct by design. If our implementation would rely on multiple DNS queries to "make sure we found all members", that's room for bugs and flakes.
I'll investigate the answer.

https://docs.openshift.org/latest/dev_guide/deployments.html#rolling-strategy

The Rolling strategy will:

Execute any pre lifecycle hook.
Scale up the new deployment based on the surge configuration.
Scale down the old deployment based on the max unavailable configuration.
Repeat this scaling until the new deployment has reached the desired replica count and the old deployment has been scaled to zero.
Execute any post lifecycle hook.

hoping the docs are up-to-date :pray:
Looking at the code for the Rolling deployer, which replicates the logic for Recreate as well, corroborates to my prayer:
pkg/deploy/strategy/rolling/rolling.go#L97-L226
This will be even better if we have readiness probes -- we just need to verify https://github.com/openshift/mongodb/pull/120.

@rhcarvalho
The maxUnavailable parameter is the maximum number of pods that can be unavailable during the update. The maxSurge parameter is the maximum number of pods that can be scheduled above the original number of pods. Both parameters can be set to either a percentage (e.g., 10%) or an absolute value (e.g., 2). The default value for both is 25%.

https://docs.openshift.org/latest/dev_guide/deployments.html#strategies

hm.  That may not mean what I thought, but i'm still pretty sure @smarterclayton just told me that a deployment can reach "success" even if not all replicas are available.
So the question is, what is going to happen if we run the post-deployment hook, and then a couple more replicas show up?

So the question is, what is going to happen if we run the post-deployment hook, and then a couple more replicas show up?

Replicas that are not in the replica set should broadcast themselves to be added to the replica set.
I think that's the same situation when we do oc scale dc/mongo --replicas=4 -- there is no post-deployment hook after scaling, and the replica set should be able to reconfigure itself.

Replicas that are not in the replica set should broadcast themselves to be added to the replica set.
I think that's the same situation when we do oc scale dc/mongo --replicas=4 -- there is no post-deployment hook after scaling, and the replica set should be able to reconfigure itself.

yeah that was my assumption (except as you noted, scaling is currently broken :) ), but i figured it was worth calling out explicitly.  Because if other replicas will broadcast to join, why don't we just add a single member to the replica set, and let the others join automatically, regardless of how many are "available" when the post-deploy hook runs?
that way we'd have a single codepath for adding members to the replicaset.

why don't we just add a single member to the replica set,

The problem is which one?
Using the post-deployment hook we know for sure which one, and we also make sure it is not part of the replica set itself (at least not as a primary).
If we would put this code in the pod template command, every replica would try to create a replica set by itself.

why don't we just add a single member to the replica set,

The problem is which one?
Using the post-deployment hook we know for sure which one, and we also make sure it is not part of the replica set itself (at least not as a primary).

If you change the template to use a DeploymentConfig per Pod, then you can have the post-hook run for just one. Having separate DeploymentConfigs for each replica would mean that scaling would be odd, but it would also give a workaround for #114 (we're going to go with separate DCs in production, and just not use the scaling mechanism, until the better solution is ready).

The problem is which one?

any one?  which one are we adding today?  does it matter if we just add one and ignore the rest?

Using the post-deployment hook we know for sure which one, and we also make sure it is not part of the replica set itself (at least not as a primary).

how do we know this?

If we would put this code in the pod template command, every replica would try to create a replica set by itself.

i'm definitely not suggesting that.
i'm not as familiar w/ the clustering flow as you are, so perhaps that's where my confusion is coming from, let's talk through the flow on scrum tomorrow.

i'm not as familiar w/ the clustering flow as you are, so perhaps that's where my confusion is coming from, let's talk through the flow on scrum tomorrow.

Let's do that.

https://ci.openshift.redhat.com/jenkins/job/mongodb/212/console
Got a yum error saying "This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register." -- this is weird...
[test] again

I think that's a normal message.
Ben Parees | OpenShift
On Mar 3, 2016 11:32 AM, "Rodolfo Carvalho"<EMAIL_ADDRESS>wrote:

https://ci.openshift.redhat.com/jenkins/job/mongodb/212/console
Got a yum error saying "This system is not registered to Red Hat
Subscription Management. You can use subscription-manager to register." --
this is weird...
[test] again
—
Reply to this email directly or view it on GitHub
https://github.com/openshift/mongodb/pull/124#issuecomment-191840634.

@php-coder PTAL :eyes:

LGTM

LGTM

[test] again