Accelerate model loading

What would you like to be added:
Generally,

if user use object stores, they can use fluid as distributed caching system
if user use oci images, they can use dragonfly for p2p accelerating

However, there are 2 gaps here:

what about user download model weights from model hub, we should only download once and then using the cache, but we can't achieve this today. One way is download the model weights to the file system or cache system
However this bring another problem, what if people don't have these two additional components, we should still have ways to accelerate the model loading by default.

Why is this needed:
Minimum the configurations but still enjoy the accelerating.
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

/kind feature

/priority important-soon

/close
duplicated as https://github.com/InftyAI/llmaz/issues/119


How do I attach a tendon to a floors.Floor() object?

I try
class Task(composer.Task):
    def __init__(self, creature):
        ...
        self._arena = floors.Floor()
        self._arena.mjcf_model.add('tendon', ... )

And it gives me ValueError: A <tendon> child already exists, please access it directly..
I need to hang my robot to a tendon attached to a site belonging to the worldbody so that it learns to stand faster.

I just found out you can't add anything to self._arena.mjcf_model (tried an actuator). Should I just not use floors.Floor()?

Solved:
        spatial1 = self._arena.mjcf_model.tendon.add('spatial')
        spatial1.add('site', site=end1)
        spatial1.add('site', site=end2)


bugfixes

Calling ParamContainer init with yr_i argument instead of price level.
C_fin has a multiindex. Setting index_col of C_fin led to an error in calculation of construction time.

Bugfix, replacing construction start with price level year.


Apply multicolumn to visited and lived-in countries

Subject: Apply multicolumn to visited and lived-in countries
Description:
Added new countries to the list I've visited
Results:
Been visiting more than 80 countries, so when displayed the list is quite long; using a single column is probably not the best way.
If using flex, multiple columns could be allowed; or, list could be horizontally displayed, separating countries even with something simple (comma, column, hyphen, etc.)
Backend version: develop-b8a97954
Frontend version: develop-b8a97954
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36
Page: https://app.couchers.org/profile/about
User: daniele (4567)

I would like to start my contribution with this issue.

Feel free to comment or email me of you have any difficulties!

Thank you

Gonna take this low-hanging fruit as my first issue 😂
Can we go for a simple comma-separated list here? Could also be a flexbox of pills, if we want to keep using the color scheme.

Either one sounds good to me!


Dropdown menus in Add Gall reopen instantaneously when clicking below them

On the Add/Edit Gallformers page, if I click either the Hosts or Locations field, select my first option, then click anywhere below the field, eg to add a detachable entry or to submit the gall, anywhere in the space where the dropdown menu was, it acts as if the menu were still there and lets me select another entry.
It's not hugely annoying but another thing that could lead to erroneous data being entered if users aren't paying attention to it.

I can not replicate this one. If it still fails for you it could be an OS/Browser difference. What OS & Browser are you using?

I'm running Windows 10 home 64 bit and using Firefox at the moment. I'll check chrome and edge and see if it makes a difference.

I have tried it on Chrome and Firefox on Mac OS and do not see it. Maybe I am not understanding the issue. Can you create a screen recording and post it here?

Well of course it's not happening now in Edge or Firefox. Maybe it got fixed in some other alterations you made. If it happens again I'll record and reopen the issue.

It is quite possible, though that is really odd behavior.

Finally got a video of this. It happens when I'm using the map-host-gall page as well, and what seems to trigger it reliably is when I enter a couple of options, click to another window, then come back in to hit submit without interacting with the window any other way first.
https://user-images.githubusercontent.com/69063635/115948866-b5fd5a80-a49e-11eb-8594-41d68978fc18.mp4

Ahh I see it now. On my machine when I leave the page with the cursor in the selection box then come back the selection list is expanded. For you it is hidden until you click (which rather poor behavior on its part!). I will see what I can do. This is a 3rd party open source component that I am using so it might be a tough one to fix.

It's not a big deal, especially now that I'm aware of how to avoid it. But could cause issues for new users.


FAD-60 selection tool user toggle

Description

User Toggle Switch
Figma File: https://www.figma.com/file/g7Edk2JCOMLpRAw9v8NJ4c/FA-Product-Wireframe---working-file?node-id=94%3A12407

Checklist
FAD-60

[x] CHANGELOG has been update

d (if appropriate)
[x] Environment variables updated (if appropriate)

I have no idea why the package-lock.json was deleted from packages/client3. I have attached a video to show that it is there...


How to get more cities?

Hi,
I want to download all cities in Germany. Running the script gives me only ~1500 cities. Why?

You may need to change the source file. Look in site-packages/cities_light/settings.py
CITY_SOURCES = getattr(settings, 'CITIES_LIGHT_CITY_SOURCES', ['http://download.geonames.org/export/dump/cities15000.zip'])
cities15000.zip has cities with a population of over 15000.
cities5000.zip should solve the problem.
More details here: http://download.geonames.org/export/dump/readme.txt

@bomba1990
Thank you for the fast response :) This should be added to the docs.
Is there a hidden option to download suburbs?


Pin dask <2024.9

🚀 Pull Request
Description
Addresses #6251.
Note: it may be worth also adding a test for the bug encountered in #6251. This bug can be replicated without Iris, so this probably doesn't fall under our jurisdiction to test for.
TODO: update the lockfiles.

The doctest failure: I had a PR merged-and-released on Dask, which allowed me to remove this workaround:
f5476629870aeee80f8b4b468dca99b83a458971
If we're using an older version of Dask then the above workaround needs to go back in.


Block domain kingtroll.stellarmint.io

Domain: domain
Requested by @djolehaubica

COMPLETE FRAUD, KNOWN CRIMINALS, PUSHING THIS AND OTHER FAKE TOKENS ON MULTIPLE WEBSITES, WHILE DRAINING LIQUIDITY

ref
#19
#21
#22


Traditional and simplified Chinese translation of 2020 Jupiter-Saturn…

… conjunction, also correct wording for eclipse
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[ ] If you have multiple commits please combine them into one commit by squashing them.

Thanks a lot for this! Really appreciate the quick fix (especially as this new text won't even appear in English for non-English locales, alas).


test(RHTAPWATCH-643): Adding python tests to CI

LGTM have you checked those are running (in personal branch's PR?)

Yes. https://github.com/yftacherzog/tools/pull/1/checks


Camera stuck on yellow light, no wifi, no reset possible -- Yi 1080p Home IFUS 	9.0.19* 	y21ga

Yi 1080p Home IFUS 	9.0.19* 	y21ga
Hi, after the allwinnerV2 hack the cam worked fine (offline, without yi-app). I've done some changes on the webinterface, which was fine so far.
The next day turning it on again, the yellow light immediately goes on, but nothing else happens. It doesn't connect to wifi, nor can I reset it - with and without SD card. Formatting SD to apply the hack again doesn't work, nothing happens. SD card is fine. Also tried with yi-app and internet connection, no success. Tried a manual firmware update like described on yi-support-page. But no, the cam stays in an unaccessable state with yellow light permanently on. Any ideas anybody?

Try the unhack procedure.

I've tried to unhack, did not work unfortunately. Same behaviour as described above.
(https://github.com/roleoroleo/yi-hack-Allwinner-v2/wiki/Remove-the-hack)
Do you have any other ideas except for hard unbrick?

Unbrick in the wiki.

If you try backup procedure, does it works?

I've tried, it did not work. Cam hangs, no matter what I do or what I put into SD.
I'm going to talk to the seller, maybe this is a hardware failure and I'll get a new one.
Thanks so far.

I've tried, it did not work. Cam hangs, no matter what I do or what I put into SD.
I'm going to talk to the seller, maybe this is a hardware failure and I'll get a new one.
Thanks so far.

I have one camera exactly doing the same (y21ga)
It did work fine for a few days and then is stoped working and only give a yellow light.
Up to now I did not try to fix it, but i might give it a shot in the next few days.
I'll let you know if i manage to make it work again.

Are you able to connect a serial cable?

Are you able to connect a serial cable?

Yeah i'll try that, but I can't do it today. Hope to be able to do it next weekend

Have you tried to change the cable and use its own power supply ?
This camera is very sensible to power, at least mine and happen to me to have a fixed yellow light and then swapped to proprietary cable and power plug and all went back working. Worth a try.

Have you tried to change the cable and use its own power supply ?
This camera is very sensible to power, at least mine and happen to me to have a fixed yellow light and then swapped to proprietary cable and power plug and all went back working. Worth a try.

I noticed the same thing.
I tried like 6 usb cables - none of them worked, only its proprietary one.
I think I was stucked, since I needed to place it far away from a power source, but I tried an usb extender and it worked flawlessly (I used an usb supercharger ~2.4A then the extender and in the end the proprietary cable).


Custom image cropping tool?

Closing because we used the Image Optimizer for this: https://thirsty-nightingale-ae4089.netlify.app/directory-image-optimizer


AHBottomNavigation, MaterialDesignDimens and PhotoView libraries added.

@matmedev they look very good thanks. if libraries are added into the AboutLibraries. the _int after define is required here: https://github.com/mikepenz/AboutLibraries/pull/316/files#diff-280db18cd776ac1a27308243479c117dR4 otherwise those libs would show up for everyone automatically. (sample here: https://github.com/mikepenz/AboutLibraries/blob/develop/library/src/main/res/values/library_actionbarsherlock_strings.xml#L4)
And the classpath should define a specific class (java sadly does not allow to check for a package if it exists)
https://github.com/mikepenz/AboutLibraries/blob/develop/library/src/main/res/values/library_actionbarsherlock_strings.xml#L17
thank you

OK. I will take a look at it and get back as soon as I am ready.

I made some changed (see commit message). I couldn't add the classpath for MaterialDesignDimens lib since there are no classes in the lib, only constants.


Login with facebook

Hello, I have an application made with nancy and I can not login to facebook, because they changed the connection policies (https://docs.wp-native-articles.com/article/73-enabling-facebook-oauth-strict-mode) a month ago (May-2018) and following the nancy tutorial to do the authentication manually (https://github.com/SimpleAuthentication/SimpleAuthentication/wiki/NancyFX-Manual-Setup), I can not find where the IAuthenticationService interface is. I need, would you have any solution like this?
Hola, tengo una aplicalcion hecha con nancy y no puedo logearme por facebook, porque ellos cambiaron las politicas de coneccion hace un mes (may-2018) y siguiente el tutorial de nancy para hacer la autenticacion manualmente, no encuentro donde esta la interface IAuthenticationService que necesito, tendrian alguna solucion asi esto?
sorry for my englesh

Hi @allnnde :wave: A few quick questions, first. What version of NancyFx are you using. Also, what version of .NET are you using? .NET or .NET-Core?

Ok - I might have to look into this, then.

@allnnde Ok, I've had a quick look at the current code that is up in the master and dev branches.
Then I used the sample NancyFX website to test out the library. Tried logging into Facebook and I got a crap error:
So, did a quick google and figured out that I needed to update my facebook settings for the facebook-app my sample app is using. Here is what it now looks like:

Notice this bit...

This url has to be exactly what your return redirect URI (from facebook BACK to your website) is. Take note of the domain name etc.
So try updating your facebook-app settings.
Also, to see how I did this with NancyFX, you can review the sample project here to see how it was done. Basically, I:

created a basic NancyFX website
installed the nuget
set the config settings for your facebook public/secret app settings.

and i think that was it.
NOTE: the documentation is waay old, so refer to code instead of documentation please. Yes, it should be updated and no, i'm not going to both because this repo is now going into maintenance mode only.
Give that a try and report back, please.


Allow to disable DVC datasets statuses in project Explorer

I found confusing that DVC reuse the same status icons as Git does in Project Explorer. I have to check who is showing the status for the file by hovering over the icon. In my case, I use git hooks and there no need to duplicate the status in VSCode File Explorer.
Please add an option to disable this feature in the settings.

I found confusing that DVC reuse the same status icons as Git does in Project Explorer.

Removing the statuses from File Explorer will mean that a status is not displayed at all for these files throughout the app. This is due to the limited API provided by VS Code.

Removing statuses would mean that in the second screenshot, the items would be shown under the DVC SCM tree without a status attached.
Can you please further explain your use case and why you do not need to know the status of resources tracked by DVC?


ci: Freeze pipenv version for avoiding issue on documentation generation

Summary
This PR intends to add a quick fix for an issue with the latest release of pipenv.
From my investigation seems related to this issue: https://github.com/pypa/pipenv/issues/4828
Impact
No impact, fix for CI job.
Testing
CI build pass.

So what's the root cause?  I had some desperate attempts locally.

So what's the root cause? I had some desperate attempts locally.

It seems that pipenv run is failing to actually execute the command inside the virtual environment.
The alternative method works: running make run html inside pipenv shell.

It looks like there is a fix for this already but still not part of any release, we'll have to merge this then.

It looks like there is a fix for this already but still not part of any release, we'll have to merge this then.

Just for future reference, the fix is already merged upstream:
https://github.com/pypa/pipenv/issues/4838
Once the hotfix is published to pypi, we can unfreeze pipenv version by reverting this commit.


Allow to specify --subscription flag for GetTokenFromCLI

We have multiple subscriptions that we manage, and trying to use https://github.com/Azure/go-autorest/blob/master/autorest/azure/cli/token.go#L126 to get the token from the logged in az cli.
However, the subscription id is not configurable, so we have to switch it again and again when working on multiple projects.
Proposal:
Add another function alongside https://github.com/Azure/go-autorest/blob/master/autorest/azure/cli/token.go#L126 to accept subscription id flag.
Happy to make a PR for that, shouldn't be hard.

Fixed in autorest/azure/cli/v0.4.3


synapse's password policy is ignored/circumvented

Describe the bug

To Reproduce

setup synapse password policy e.g. minimum length 10 letters
register new user with token, using a policy violating password, e.g. 8 characters long

Expected behavior

respect pw policy
Screenshots

System:

OS: docker
python version: docker
matrix registration version: v0.7.2 (docker)

Additional context

not sure what good practices are in regards of informing users of the pw policy

Since the admin of the Synapse server also runs matrix-registration, we'd have two ways of implementing this:
Requesting the server policy via synapse api
+ following the configuration setup in synapse
- doesn't seem to have a default value (on my server it just returns empty json body - synapse 1.37.1 / edit: even matrix.org doesn't seem to implement /_matrix/client/r0/password_policy)
- doesn't seem to be suggested anywhere to change theese (correct me if I missed it)
- the synapse config files are quite cryptic and always scary for less experienced admins to touch
Implementing it ourselfes
+ centralised registration policies (e.g. usernames, passwords)
+ cleaner way of configuration (easier to find in my opinion)
(+ prettier on our side to implement without repeating api calls)
Conclusion / Proposal
The probability of one using the integrated registration feature of synapse alongside matrix-reistration is quite low.
So I propose that we include theese settings into our password reqirement field somewhat like this:
# password requirements
password:
  min_length: 8
  needs_lowercase: true
  needs_upercase: false
  needs_numbers: false
  needs_symbols: false

Of cause open to suggestions (esp. regarding the default values)

looks like this msc isn't yet merged?
https://github.com/matrix-org/matrix-doc/pull/2000


Highest/Warmest Equivalent Classes

The Highest_Zone_Air_Temperature_Sensor has an OWL equivalent class relationship with  Warmest_Zone_Air_Temperature_Sensor yet the former has tag:Highest and latter has tag:Warmest.  As long as a thing has both tags then I would expect it to be an instance of both types, but if it's a "highest" that does not have a "warmest" tag does the inference engine assume that (thanks to open world) that somewhere in the universe that there must be a "warmest"?
What is the intent of have two classes, is it simply the idea that someone can use "highest" or "warmest" and they are they mean the same thing?

This is one of those classes on our list of "these sound the same but they came from different buildings and we're not exactly sure whether or not they refer to the same concept" :)
We're unfortunately now at the stage where the Brick documentation appears higher on Google search results than some source material, but my guess is that Highest_Zone_Air_Temperature_Sensor  and Warmest_Zone_Air_Temperature_Sensor are computed values stored in the BMS in conjunction with Lowest_/Coolest_/Average_ variants. Is that your experience?
If that's the case then we might want to drop the alternatively-phrased "flavors" that ultimately mean the same thing (e.g. drop Warmest_ for Highest_ or vice versa). Currently the inference engine will add the warmest tag if you are an instance of Highest_Zone_Air_Temperature_Sensor (class -> tag inference), but because we are not using OWL inference for tag -> class, you only need the tags for one of the equivalent classes in order to produce the correct inference.

@JoelBender what do you think of replacing Highest with Warmest and Lowest with Coolest where the points pertain to temperature? I'm thinking we might remove the Highest/Lowest variants altogether, or at least mark them as deprecated to indicate that users should use the other point.

Yes, I believe these both refer to the same thing and were simply described differently by the controls contractor on the respective sites: The zone temperature that is highest/warmest and thus driving the temperature of the cold air from the air handling unit down to it's current point.
I agree that it's clearer (to me anyway!) to change to 'standardize' to Warmest/Coolest.

Thanks @praftery !
Changes captured in PR https://github.com/BrickSchema/Brick/pull/133. I'll do a quick look for similar redundancies/confusions that can be rectified in the same PR

Fixed in https://github.com/BrickSchema/Brick/pull/133


Press the keyboard to return to the previous page

When the keyboard is up, click back to the previous page，wrong：  "****Logic" not found. You need to call "Get.put(CreatWalletPasswordLogic())" or "Get.lazyPut(()=>****Logic())"

Please paste your back press action code snippet


Fixes for multi-device support

Check whether there is > 1 device
Fix setup of sycl per-device queues

LGTM.

LGTM

@davidbeckingsale just so you know, regarding this PR, for now the compute-sanitizer only handles allocations for devices where cudaDeviceEnablePeerAccess has been called before. I didn't mention this limitation at first considering it wouldn't impact you, but it might be useful to mention it now. I will get rid of this limitation ASAP.


Inconsistent Behaviour Listing File

Describe the bug

Calling list with a path to an existing file behaves inconsistently

LocalFileSystem, GCP, AWS, Azure return an empty list
MemoryStore and HttpStore return the file at the given path

To Reproduce

Add the below to the put_get_delete_list_opts test
let content_list = flatten_list_stream(storage, Some(&location)).await.unwrap();
assert_eq!(content_list, &[]);

Expected behavior

The docs state

Prefixes are evaluated on a path segment basis

As such all stores should return an empty list
Additional context

It seems azure Gen2 accounts also have the bug.
I'd be happy to take this up. Just a quick question as to how. I would have gone the naive way and just filter results for the affected stores, since I assume we cannot do much about the returns we are getting from the backend.
Do you see another way?

It seems azure Gen2 accounts also have the bug.

Sigh... I don't understand why Azure thought directories in object storage were a good idea...

I'd be happy to take this up

I'm actually most of the way through a fix for HTTP and MemoryStore, I'll finish this up and then perhaps you could pick up the azure shenanigans?


Anonymous comments

Given a post from yesterday at /c/alpha.
Free speech is being able to express your opinions and ideas without fear of retaliation.
Online in Openbook and other platforms, your persona linked to your account is always on the lines when expressing an opinion.
Adding the possibility of commenting anonymously would decrease the fear of retribution greatly.
Behind the scenes of course the comment would be linked to the real account in case it's abused for demeaning, humiliating or brutalising another person or group, in which case measures like banning play a role.
Thoughts, ideas, opinions on this very welcomed!

From Cyrill

I'm absolutely not a fan of this idea. Everyone can use Openbook anonymous according to nickname/profile picture. When someone still fears to comment what he want, then we have a community/communication problem generally or this person shouldn't write down the comment anyway. Adding this feature would just conceal a problem not solve it and maybe brings more problems into the platform by abusing this feature. That's my opinion about that.

Personally not in favour of this, anonymous comments tend to be mostly misused for trolls/taunts/minor insults rather than properly used for the purpose mentioned. This type of sarcastic micro aggression doesnt cross the line to warrant strong action but still destroys healthy debate.
I think the fear of retaliation exists because people fear being attacked online rather than expect having a healthy discussion. We should strive to make Openbook a platform where everyone stays respectful (and maybe is incentivised to be remain way? ) That way people will know that a difference of opinion is fine and that expressing it will not result in being attacked. They will also know that being disrespectful for no reason will have consequences.
And then the need to be Anonymous (for fear of retaliation at least) wont be there anymore.
There still might be a wish to be anonymous for example if someone wants to share something very personal to get opinions from others, but wishes not to identify themselves. But that needs a separate discussion, in this context at least I agree with Cyrill that it only hides the problem, does not solve it.

Anonymisation has some potential uses, like e.g. to (temporarily) anonymise entries into content-based contests and similar to avoid voter bias (we do this as writingforums.org, e.g.).
In general, I would say that one of the biggest advantages and biggest problems with the internet is that it is (mostly) anonymous. Anonymity means that people dare to things they wouldn't otherwise do, and those things are more often malevolent than not (IMO).
As a consequence, if full anonymity is added it should be in a controlled manner (e.g. limit anonymous postings, only allow anonymous stuff in communities that have it enabled, mods/admins can see the original poster).

@lifenautjoe - I'm not a fan of anonymous comments for the reasons that Cyrill @ @Komposten already mentioned, but I can see value in allowing people to post anonymously when, for example, they're being critical of oppressive regimes.
Could the ability to post anonymously be coupled with sentiment analysis and a ruleset governing it?
Example:

Don't allow @ mentions in anonymous posts / comments.
Check the content (via sentiment analysis) for negativity / hate speech
Allow for members of the community to confirm or deny the automatically detected sentiment


Reduce memory usage, especially with many small files

For the small-files scenario:

Reduce max slice count in pools
Set GC Percent based on allocation patterns in this app. (I.e. lots of permanently-allocated big buffers up front, then nothing changes much... but we still want those relatively small later changes to be GC, even if they are small relative to the RAM occupied by the big buffers).

And, related, for big files:

Gradually prune out contents of idle pools

This change, coupled with #216, should address #209.


Extend xSPWebApplication resource to include "Site Use Confirmation and Deletion" settings

Extend the xSPWebAppliation resource top include the follow settings (seen in central admin under the "Application Management > Site Collections > Confirm site use and deletion" menu, http://<central_admin_url>/_admin/DeleteSiteConfig.aspx)

Configure SharePoint to send out site usage confirmation e-mails to owners
Configure SharePoint to delete sites when not confirmed after x notices

@ykuijs You wanna work on this one, or just adding to the list of enhancements? Happy for either, just wanted to know if I need to leave it as help wanted or not

@BrianFarnhill - I am on it!

All yours @ykuijs

@BrianFarnhill - I think this issue can be close, since the resource was created already


createCatalogImage is unable to use native File type?

Describe the bug
The createCatalogImage call does not accept a File type. Getting an error; source.on is not a function.
Expected behavior
The api should be able to handle the native File type from node as it is a subset of Blob.
To Reproduce
Steps to reproduce the bug:
Create a form on your client:

	const handleSubmit = async (event: React.FormEvent<HTMLFormElement>) => {
		event.preventDefault();
		const formData = new FormData(event.currentTarget);
		const response = await fetch('/api/upload', {
			method: 'POST',
			body: formData,
		});
		const json = await response.json();
		console.log(json);
	}

	return (
		<form onSubmit={handleSubmit} className="flex flex-col gap-2" encType="multipart/form-data">
			<input type="hidden" name="id" value={props.id} />

				Image
				<input type="file" name="image" required />

			<button className="rounded border border-gray-200 px-4 py-1" type="submit">Upload</button>
		</form>
	)

Server side create the image
import client from "@/lib/square";
import { FileWrapper } from "square";

export const POST = async (request: Request) => {
	// form submission to upload photo
	const body = await request.formData();

	console.log(request.headers.get("Content-Type"));

	const { image, id } = Object.fromEntries(body.entries()) as {
		image: File;
		id: string;
	};

	const fileWrapper = new FileWrapper(image, {
		contentType: image.type,
		filename: image.name,

	});

	try {
		const { result, request, body } = await client.catalogApi.createCatalogImage({
			objectId: id.toString(),
			isPrimary: true,
			idempotencyKey: id.toString(),
			image: {
				id: `#${id}`,
				type: "IMAGE",
				imageData: {
					caption: "test",
					name: image.name,
				},
			}
		}, fileWrapper);
		console.log(result);
	} catch (err) {
		console.error(err);
		const error = err as Error;
	}

	return new Response("ok");
}

Screenshots

Square SDK version
^33.1.0
Additional context
It seems like the work around could be to save the file to disk and then create a readstream from there, but with the advent of serverless frameworks (and moving to more native js apis) I would expect this flow to work.

And I figured it out.... was just missing a step of converting the file to a Readable stream.
new backend code;
import client from "@/lib/square";
import { FileWrapper } from "square";
import { Readable } from "stream";

export const POST = async (request: Request) => {
	// form submission to upload photo
	const body = await request.formData();
	const { image, id } = Object.fromEntries(body.entries()) as {
		image: File;
		id: string;
	};

	// convert image to Readable stream
	const bytes = await image.arrayBuffer();
	const buffer = Buffer.from(bytes);
	const readable = new Readable();
	readable.push(buffer);
	readable.push(null);

	const fileWrapper = new FileWrapper(readable, {
		contentType: image.type,
		filename: image.name,
	});

	try {
		const { result } = await client.catalogApi.createCatalogImage({
			objectId: id.toString(),
			isPrimary: true,
			idempotencyKey: id.toString(),
			image: {
				id: `#${id}`,
				type: "IMAGE",
				imageData: {
					caption: "test",
					name: image.name,
				},
			}
		}, fileWrapper);
		console.log(result);
	} catch (err) {
		console.error(err);
		const error = err as Error;
	}

	return new Response("ok");
}

Hopefully this helps someone else. There could be a case where the package itself could just accept the File type and save us a step, so I will leave it open. However if the above is the recommended method maybe we could consider adding it t othe docs?

Hey @ozzyonfire - sorry for the pain point here, but yes converting image file to a readable stream is the correct course of action here. I am looking at our docs though, and am seeing what you are saying that we don't seem to have that defined anywhere in the reference or guides. The sample code usually shows converting it to a readable stream, but we should be more clear on that. Thank you for your contributions here, and I'll take this feedback to the relevant team to get this addressed. Thanks!


(PDB-4938) Deliver promise after initial gc

Add a promise to shared-globals that is delivered after the initial
garbage collection finishes. On the PE side, we will wait on that
promise to start the initial sync.

CLA signed by all contributors.


Fixed serialization issue when connecting to MongoDB 3.0

Coverage decreased (-0.16%) to 96.52% when pulling 3bb1343d284438afc9ce58e880ae6bb78e658bbe on lennynyktyk:mongo30-distinct into 6f7363396a029f0e63f398f41cde06eefbf8a835 on jenssegers:master.


[BUG] Code provided by custom script changes window size

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
When I put this in eww.yuck:
(deflisten wifi-icon "~/.config/eww/scripts/wifi-icon-alt.sh")

(defwidget wifi []
   (literal :content wifi-icon))

(defwindow wifi
  :class "wifi-win"
  :windowtype "dock"
  :stacking "fg"
  :geometry (geometry
    :x "-130px"
    :y "65px"
    :height "75px"
    :width "100px"
    :anchor "top right")
  (wifi))

And this is the code inside of wifi-icon-alt.sh:
#!/bin/bash
strength=`iwconfig wlan0 | grep "Link Quality=" | awk -F'=' '{ print $2 }' | awk -F'/' '{ print $1 }'`

strength-icon() {
  if [[ $strength -le 14 ]]; then
    echo "(box :class \"wifi-btn\" (label :text \"󰤯\"))"
  elif [[ $strength -le 28 ]]; then
    echo "(box :class \"wifi-btn\" (label :text \"󰤟\"))"
  elif [[ $strength -le 42 ]]; then
    echo "(box :class \"wifi-btn\" (label :text \"󰤢\"))"
  elif [[ $strength -le 56 ]]; then
    echo "(box :class \"wifi-btn\" (label :text \"󰤥\"))"
  elif [[ $strength -le 70 ]]; then
    echo "(box :class \"wifi-btn\" (label :text \"󰤨\"))"
  fi
}

strength-icon

This is how the window appears:

And if I change contents of eww.yuck:
(defwidget wifi []
    (box
        :class "wifi-btn"
        (literal :content wifi-icon)))

And changing contents of wifi-icon-alt.sh:
#!/bin/bash
strength=`iwconfig wlan0 | grep "Link Quality=" | awk -F'=' '{ print $2 }' | awk -F'/' '{ print $1 }'`

strength-icon() {
  if [[ $strength -le 14 ]]; then
    echo "(label :text \"󰤯\")"
  elif [[ $strength -le 28 ]]; then
    echo "(label :text \"󰤟\")"
  elif [[ $strength -le 42 ]]; then
    echo "(label :text \"󰤢\")"
  elif [[ $strength -le 56 ]]; then
    echo "(label :text \"󰤥\")"
  elif [[ $strength -le 70 ]]; then
    echo "(label :text \"󰤨\"))"
  fi
}

strength-icon

Thie window ends up looking like this:

Reproducing the issue
No response
Expected behaviour
When I put this in eww.yuck:
(defwidget wifi []
   (box
      :class "wifi-btn"
      (label :text "󰤢")))

(defwindow wifi
  :class "wifi-win"
  :windowtype "dock"
  :stacking "fg"
  :geometry (geometry
    :x "-130px"
    :y "65px"
    :height "75px"
    :width "100px"
    :anchor "top right")
  (wifi))

This is how the window should appear:

Additional context
Here is whats inside eww.scss if you need:
* {
  padding: 3px;
}

window {
  border: 10px solid #151515;
  border-radius: 8px;
}

.wifi-btn,
.bt-btn {
  background-color: #FFFFFF;
  border: 1px solid #151515;
  border-radius: 8px;
  font-size: 14px;
  color: #151515;
}

I'm pretty sure this is because literal adds a box around its content, whether this is a bug or not is debatable (You should see with elkowar), but in your case it would be better to just use a defpoll for the text content (label :text "${variable}"), (label :text {variable}) (label :text variable). Though your actual case might be a more complicated (I don't know if what you showed is just an example or not). You rarely really need literal, the only uses I could think of would be some kind of recursive structure or a weird optimization trick to avoid the number of elements growing too big.

Thank you, that works fine. I'm new to eww so I've just been learning it from other people's configs as well as looking at docs to understand what's going on.
In this case I just wanted to show a wifi icon at certain strengths. Currently, I don't really understand the syntax for flow control with eww (if, else if, and else), so I just wrote a script for this and other stuff.


Fixes #8

Hi,
this commit fixes issue #8.
Changelog -

Modified models.py per requirement.

Hey, can you change content from a charfield to a textField? Other than that, everything looks great.

Sure, will do

Great Work! Will merge it. Happy contributing!

Thank you!

!bounty 100

!bounty 30

!bounty 30


Local cluster visible in Cluster Explorer when hide-local-cluster set to true

Spotted in 2.5.8.
Issue description:
When the hide-local-cluster setting is set to true, the local cluster will not appear in the Cluster Manager UI, however it is appearing in the Cluster Explorer.
Business impact:
Tenants, who are restricted admins, should not be able to modify the local cluster and it's better if they don't see it at all.
Repro steps:

run kubectl patch settings.management.cattle.io hide-local-cluster --type merge -p '{"value":"true"}'

Go to the Cluster Explorer and click the drop down in the top right corner to select the local cluster.

Actual behavior:
User can see local cluster in Cluster Explorer. User cannot see local cluster in Cluster Manager.
Expected behavior:
User should not be able to see local cluster in Cluster Explorer or Cluster Manager.

@gaktive Has anyone validated this in 2.6.x ? Or is this an ask for a 2.5.x fix?
In 2.6.0 the cluster choose in the top-right is no longer present.

Pinged @SheilaghM on the 2.5.x aspect.
@sowmyav27 was this tested during 2.6.0?

Verified this has been fixed in v2.6-head https://github.com/rancher/rancher/commit/6c12bee2d0bee16a2854df5471aaa0cdee5b9bf1.
Verification Steps

Downloaded kubeconfig file and applied to local client machine (performed testing using local cluster's kubectl shell as well).
Ran command kubectl patch settings.management.cattle.io hide-local-cluster --type merge -p '{"value":"true"}'.
Refreshed the page and verified the local cluster is no longer appearing in the home page, cluster management and cluster explorer:

Home Page

Cluster Explorer

Cluster Management

Ran command kubectl patch settings.management.cattle.io hide-local-cluster --type merge -p '{"value":"false"}'.
Refreshed the page and verified the local cluster once more appears in the home page, cluster management and cluster explorer:

Home Page

Cluster Explorer

Cluster Management

Created user accounts for roles: restricted administrator, standard user, user base. With the value set to false, logged into each account and verified none of these accounts can see the local cluster. This is expected behavior.


Extract lua library support into a lua51-sys package

rust-lua should depend on some lua51-sys package that provides the actual library bindings.

I'm a few years late, but I ended up doing this for an unrelated project of mine: https://crates.io/crates/lua51-sys
If you're still interested (4 years!), I'm sure I messed up a couple things here and there doing this.


Update with preferred email address

Update MAINTAINERS file with my preferred email address as others use
this to send mail, add to mailing lists, etc. My
contributor/Signed-off-by is a valid address, but not the one I use for
community interactions.
Signed-off-by: Phil Estes<EMAIL_ADDRESS>

LGTM

Codecov Report

Merging #870 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   59.55%   59.55%
=======================================
  Files           5        5
  Lines         759      759
=======================================
  Hits          452      452
  Misses        199      199
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae11b6...d2c0f30. Read the comment docs.

LGTM


How to handle access token for each "GET "request to prevent hacker use direct link to fetch data.

How to handle access token for each "GET" request to prevent hacker use direct link to fetch data.
it mean that you can not enter directly into the browser API to get information, you must get access token through first, then transfer that value to execute query commands.

Hi @SanhNX, I'm sorry you may have asked in the wrong repository. This is a MySQL driver, and doesn't have any mechanism to interact with HTTP. You may want to post a question against whatever HTTP server you are using if you're not sure how to do that.


[Bug] [dolphinscheduler-api] Failed to execute PROCEDURE node

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
1.An error is reported when the data storage IN mode references a user-defined parameter

2.An error is reported when the data storage OUTmode references a user-defined parameter

What you expected to happen
.
How to reproduce
.
Anything else
No response
Version
2.0.1
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

the task of procedure may missing part to replace parameters with placeholders


Slurm multi-node work fine but multi-gpu doesn't

Bug description
I am training a sample model which works on multiple GPUs as long as these are across nodes. But as soon as I allocate more than one GPU on a node it returns  [rank7]: torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1970, unhandled cuda error, NCCL version 2.17.1 [rank7]: ncclUnhandledCudaError: Call to CUDA function failed. [rank7]: Last error: [rank7]: Cuda failure 'invalid device pointer'
What version are you seeing the problem on?
v2.4
How to reproduce the bug
python training script:

from pytorch_lightning.demos.boring_classes import BoringModel, BoringDataModule
from pytorch_lightning import Trainer
import os

def main():
    print(
        f"LOCAL_RANK={os.environ.get('LOCAL_RANK', 0)}, SLURM_NTASKS={os.environ.get('SLURM_NTASKS')}, SLURM_NTASKS_PER_NODE={os.environ.get('SLURM_NTASKS_PER_NODE')}"
    )
    model = BoringModel()
    datamodule = BoringDataModule()
    trainer = Trainer(max_epochs=100,devices=2,num_nodes=4)
    print(f"trainer.num_devices: {trainer.num_devices}")
    trainer.fit(model, datamodule)

if __name__ == "__main__":
    main()

Slurm sbatch.sh file:

#!/bin/bash
#SBATCH --job-name=rocm_DDP_lightining
#SBATCH --nodes=4
#SBATCH --gres=gpu:2
#SBATCH --ntasks-per-node=2
#SBATCH --mem=96g
#SBATCH --output=/mnt/jobOutput/sample.out
#SBATCH --error=/mnt/jobErrors/sample.err
#SBATCH --time=0-02:00:00
#SBATCH --cpus-per-task 10
#SBATCH --partition rocm
export NCCL_DEBUG=INFO
export PYTHONFAULTHANDLER=1
srun python /mnt/sample_lightning.py

Error messages and logs
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Using the `SDPA` attention implementation on multi-gpu setup with ROCM may lead to performance issues due to the FA backend. Disabling it to use alternative backends.
Initializing distributed: GLOBAL_RANK: 5, MEMBER: 6/8
Initializing distributed: GLOBAL_RANK: 4, MEMBER: 5/8
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
HPU available: False, using: 0 HPUs
/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/connectors/logger_connector/logger_connector.py:75: Starting from v1.9.0, `tensorboardX` has been removed as a dependency of the `lightning.pytorch` package, due to potential conflicts with other packages in the ML ecosystem. For this reason, `logger=True` will use `CSVLogger` as the default logger, unless the `tensorboard` or `tensorboardX` packages are found. Please `pip install lightning[extra]` or one of them to enable TensorBoard support by default
Initializing distributed: GLOBAL_RANK: 6, MEMBER: 7/8
You are using a CUDA device ('AMD Instinct MI50/MI60') that has Tensor Cores. To properly utilize them, you should set `torch.set_float32_matmul_precision('medium' | 'high')` which will trade-off precision for performance. For more details, read https://pytorch.org/docs/stable/generated/torch.set_float32_matmul_precision.html#torch.set_float32_matmul_precision
Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/8
Initializing distributed: GLOBAL_RANK: 3, MEMBER: 4/8
Initializing distributed: GLOBAL_RANK: 1, MEMBER: 2/8
Initializing distributed: GLOBAL_RANK: 7, MEMBER: 8/8
Initializing distributed: GLOBAL_RANK: 2, MEMBER: 3/8
----------------------------------------------------------------------------------------------------
distributed_backend=nccl
All distributed processes registered. Starting with 8 processes
----------------------------------------------------------------------------------------------------

[rank0]: Traceback (most recent call last):
[rank0]:   File "/mnt/scratchc/ralab/atif/SRResNet_SRGAN/rocm_DDP.py", line 109, in <module>
[rank0]:     main()
[rank0]:   File "/mnt/scratchc/ralab/atif/SRResNet_SRGAN/rocm_DDP.py", line 18, in main
[rank0]:     trainer.fit(model, dm)
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/trainer.py", line 538, in fit
[rank0]:     call._call_and_handle_interrupt(
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/call.py", line 46, in _call_and_handle_interrupt
[rank0]:     return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/strategies/launchers/subprocess_script.py", line 105, in launch
[rank0]:     return function(*args, **kwargs)
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/trainer.py", line 574, in _fit_impl
[rank0]:     self._run(model, ckpt_path=ckpt_path)
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/trainer.py", line 938, in _run
[rank0]:     self.__setup_profiler()
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/trainer.py", line 1071, in __setup_profiler
[rank0]:     self.profiler.setup(stage=self.state.fn, local_rank=local_rank, log_dir=self.log_dir)
[rank0]:                                                                             ^^^^^^^^^^^^
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/trainer/trainer.py", line 1233, in log_dir
[rank0]:     dirpath = self.strategy.broadcast(dirpath)
[rank0]:               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/lightning/pytorch/strategies/ddp.py", line 307, in broadcast
[rank0]:     torch.distributed.broadcast_object_list(obj, src, group=_group.WORLD)
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/torch/distributed/c10d_logger.py", line 75, in wrapper
[rank0]:     return func(*args, **kwargs)
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/torch/distributed/distributed_c10d.py", line 2649, in broadcast_object_list
[rank0]:     broadcast(object_sizes_tensor, src=src, group=group)
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/torch/distributed/c10d_logger.py", line 75, in wrapper
[rank0]:     return func(*args, **kwargs)
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/Users/khan01/miniconda3/envs/rocm_test/lib/python3.11/site-packages/torch/distributed/distributed_c10d.py", line 2136, in broadcast
[rank0]:     work = default_pg.broadcast([tensor], opts)
[rank0]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]: torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1970, unhandled cuda error, NCCL version 2.17.1
[rank0]: ncclUnhandledCudaError: Call to CUDA function failed.
[rank0]: Last error:
[rank0]: Cuda failure 'invalid device pointer'

.
.
.
# [rank7]: torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1970, unhandled cuda error, NCCL version 2.17.1
[rank7]: ncclUnhandledCudaError: Call to CUDA function failed.
[rank7]: Last error:
[rank7]: Cuda failure 'invalid device pointer'
srun: error: clust1-rocm-6: task 5: Exited with exit code 1
srun: error: clust1-rocm-3: task 1: Exited with exit code 1
srun: error: clust1-rocm-4: task 3: Exited with exit code 1
srun: error: clust1-rocm-8: task 7: Exited with exit code 1
srun: error: clust1-rocm-6: task 4: Exited with exit code 1
srun: error: clust1-rocm-4: task 2: Exited with exit code 1
srun: error: clust1-rocm-8: task 6: Exited with exit code 1
srun: error: clust1-rocm-3: task 0: Exited with exit code 1

Environment

Current environment
#- PyTorch Lightning Version (e.g., 2.4.0):2.4.0
#- PyTorch Version (e.g., 2.4): 2.3.1+rocm5.7
#- Python version (e.g., 3.12):3.11.0
#- OS (e.g., Linux): Linux 4.18.0-372.32.1.el8_6.x86_64 (RHEL)
#- CUDA/cuDNN version: rocm5.7
#- GPU models and configuration: AMD Instinct MI50/MI60
#- How you installed Lightning(`conda`, `pip`, source): pip

More info
No response

update your trainer to include accelerator and strategy arguments -
trainer = Trainer(max_epochs=100,                               devices=2,                               num_nodes=4,                               accelerator="gpu",                               strategy=DDPStrategy(find_unused_parameters=True))
Also try setting devices='auto'. This will use all available GPUs on the selected node.


Built-in content.text plugin

Background
In addition to the installable plugins (https://github.com/blackstork-io/fabric/issues/3), fabric must have built-in plugins to allow generation of simple content without the need to download extra components.
Related: https://github.com/blackstork-io/fabric/issues/13, https://github.com/blackstork-io/fabric/issues/18
Design
content.text plugin is be a part of the fabric binary.
Specification

the plugin has no configuration options
API interface:

local context object
required text string attribute
optional format_as enum string attribute with allowed values title, code and blockquote (nil by default)
optional absolute_title_size int attribute (nil by default)
optional code_language string attribute

Behavior
The plugin renders and returns a text value as a template string using local context as input data and formats it in Markdown according to format_as parameter (if provided).
If format_as set to code, the text is formatted with triple backticks. If code_language is provided, the language should be set after the first triple backtick.
If format_as is title and absolute_title_size is set, the Markdown title size is absolute_title_size * #
If format_as is title and absolute_title_size is not set, the relative title size is calculated from the local context object that contains a document body (issue TBD) -- the multiplier for # for a Markdown title prefix is the number of title text seen previously in the document
Deliverables

new built-in content.text plugin
unit test for the plugin

moved to v0.4 milestone because it depends on https://github.com/blackstork-io/fabric/issues/98, as agreed in a conversation on slack


Please support python API for whisper-ctranslate2

I want to integrate whisper-ctranslate2 to my system, can you support API for whisper-ctranslate2, I use Python coding, thanks very much.

You can use the Faster-whisper API. You can see how whisper-ctranslate2 actually uses it since its a client to this API.

I test faster-whisper, every time return different result, and the accuracy not better.
If I set temperqture=0, the result is very bad
I  do not know why.

Whisper-ctranslate2 uses faster-whisper. You should get the same results. If you are using the API directly, feel free to open an issue in https://github.com/guillaumekln/faster-whisper/issues


Slack notification count always set to 1 even without mentions

Exact same bug as in franz: https://github.com/meetfranz/franz/issues/1715

I was used to see in Franz badges for slack workspaces a single dot when there are unread messages in any channel, and a number when there are unread mentions, reporting the total of unread mentions.
Now I always see numbers: when I have any amount of unread messages in channels without direct mentions, Franz shows "1" instead of the red dot, confusing me because I think I've mentioned while I'm not.
Expected Behavior
In the service's badge, I should see:
Unread messages without direct mentions to me (nor @here nor @channel): red dot.
Unread messages directed to me (including @here or @channel): unread direct messages count
Current Behavior
In the service's badge, I see:
Unread messages without direct mentions to me (nor @here nor @channel): the number "1" (wrong)
Unread messages directed to me (including @here or @channel): unread direct messages count (right)
Screenshots (if appropriate):
As you can see in the screenshot, the selected service badge reports "1" but I have no mentions in any channel.

Steps to Reproduce (for bugs)

Open Franz, add a slack service.
Mark everything as read
Wait for any new message in any channel without direct mention
See that the service badge shows "1"

Context
I think the context should be pretty clear by now.
Your Environment

Franz Version used: Version 5.3.3 (<IP_ADDRESS>2)
Operating System and version: macOS Mojave 10.14.6 (18G103)

Related to https://github.com/meetfranz/recipe-slack/pull/13 and seems to have been fixed in Ferdi by @vantezzen via https://github.com/getferdi/recipes/commit/83f946f546247572a787d451ca9ec6649c600849. The fix should be available in the next release.

@kytbw Fix is originally from getferdi/recipes#39

Ah my bad, went a bit fast: fixed by @Serubin 🙏
Closing for now.

Hello I'm in version 5.5.0 Flatpak and this issue is still happening.
Slack only. I have restart ferdi too.

Can you provide a screenshot of this issue? It's been fixed - and has stayed fixed as far as I can tell

here, there are no unread messages but it shows 1 as unread.

I'm unable to reproduce. Perhaps it'll resolve when you finish setting up slack.

I can confirm that. Finishing "Getting started" removes the 1 count.


Use @property for tooltip offset

Perhaps check if we can use @property with a fallback for FF/older browsers? https://caniuse.com/mdn-css_at-rules_property

Originally posted by @jpzwarte in https://github.com/sl-design-system/components/pull/642#discussion_r1332650442

@jpzwarte is this really important? Please have a look.

@DanielleRameau yes, this issue is still relevant.

With the refactor of tooltip in #984, this is no longer relevant.


Async buffer creation causes fence signaling lag and program hanging

Version of vulkano: 34.1
OS: Linux
GPU (the selected PhysicalDevice): RTX 3060 Laptop 6GB
GPU Driver: Nvida DKMS 555
Issue
Creating a buffer in a separate dedicated thread, with the from_iter() function causes massive (35s) lag on the next then_signal_fence_and_flush(). After 3 frames the program hangs completely. I don't know why this affects the gpu at all, because the buffers are created with the PREFER_HOST flag. I'd appreciate any help as I'm out of ideas.
Buffer creation code:
let memory_allocator = state.memory_allocators.standard_memory_allocator.clone();
let vertices = self.vertices.clone();
let indices = self.indices.clone();
let handle = thread::spawn(move || {
    let timer = Instant::now();
    let res = (
        Buffer::from_iter(
            memory_allocator.clone(),
            BufferCreateInfo {
                usage: BufferUsage::STORAGE_BUFFER | BufferUsage::SHADER_DEVICE_ADDRESS,
                ..Default::default()
            },
            AllocationCreateInfo {
                memory_type_filter: MemoryTypeFilter::PREFER_HOST |
                MemoryTypeFilter::HOST_SEQUENTIAL_WRITE,
                ..Default::default()
            },
            vertices
        ).unwrap(),
        Buffer::from_iter(
            memory_allocator.clone(),
            BufferCreateInfo {
                usage: BufferUsage::STORAGE_BUFFER | BufferUsage::SHADER_DEVICE_ADDRESS,
                ..Default::default()
            },
            AllocationCreateInfo {
                memory_type_filter: MemoryTypeFilter::PREFER_HOST |
                MemoryTypeFilter::HOST_SEQUENTIAL_WRITE,
                ..Default::default()
            },
            indices
        ).unwrap()
    );
    debug!("Load: {}", timer.elapsed().as_millis());
    res
});

Mesh update code:
for (_, mesh) in assets.meshes.iter_mut() {
    if mesh.transfer_thread.is_some() {
        debug!("{} transfering", mesh.name);
        if mesh.transfer_thread.as_ref().unwrap().is_finished() {
            debug!("{} finished", mesh.name);
            let (vertex, index) = mesh.transfer_thread.take().unwrap().join().unwrap();
            mesh.vertex_buffer = Some(Arc::new(vertex));
            mesh.index_buffer = Some(Arc::new(index));
        }
    } else if mesh.backed_transfer {
        debug!("{} backed", mesh.name);
        mesh.load(state);
        mesh.backed_transfer = false;
    }
}

It was a problem with my implementation of indirect rendering.


[core] Need to run solver, job-creator with --disable-pow

Following the merge of https://github.com/Lilypad-Tech/lilypad/pull/203 , we need to update the deployments to run non-RP services with --disable-pow so they're not doing PoW jobs.

the pow code only in rp,  the 'solver job-create' has nothing to do with 'pow' at all." i think this issue can close directly

The 2 places I can think of:

[ ] GitHub workflow for the CPU RP
[ ] stack


Can build/run/serve scripts respect env variables?

I would like to have 'ionic [serve|emulate|run|build|etc]' all respect environment variables so that I can change how my app behaves accordingly.
I've seen a lot of posts that access the current runtime env by 'process.env.VAR_NAME' but it's unclear if that's supported inside ionic's webpack process.
Thanks!

This is a bit of a gap in our process right now that we will resolve in the coming months. For now, please use webpack or rollup's plugin for environment variables. You may also need to add node typings to your Ionic project.
Thanks,
Dan

Hi @danbucholtz thanks for your reply - would you mind linking me to those things?  I'm not super familiar with the ecosystem yet.

Lets track this here. Please weigh in with your thoughts.
https://github.com/driftyco/ionic-app-scripts/issues/762
Thanks,
Dan


Custom database tables?

Hey @lucadegasperi.
I'm implermenting your oauth package into an already build system, using the client credentials grant, for each of my physical machines.
The question is, since i've already got a table of machines. Is there a way to merge the oauth_clients into my own table?
Cheers!

I've had to edit the src files for this (Such as FluentClient.php). Any better way to solve this?

Thanks for using this package!
For this kind of support questions, we'd like you to use the following resources:

Documentation
Laracasts
Laravel Slack
Stack Overflow

This will allow us to keep the issues for bug reporting only and make our work easier.


Individual case study view has hardcodes that need to be refactored

Reason/Context
Case study example: https://www.asyncapi.com/casestudies/adeogroup
Code responsible for rendering: https://github.com/asyncapi/website/blob/master/pages/casestudies/[id].js
Structure it operates on: https://github.com/asyncapi/website/blob/master/config/casestudies/adeo.yml
Some structures are arrays like: https://github.com/asyncapi/website/blob/master/config/casestudies/adeo.yml#L10
In this example you see that in case study we can have an array of contact points.
But in code it is hardcoded to read only the first contact:
<Link href={casestudy.company.contact[0].link}>
    <a className="text-secondary-500 underline hover:text-gray-800 font-medium transition ease-in-out duration-300" target="_blank">
        {casestudy.company.contact[0].name}
    </a>
</Link>

Description
Yeah just refactor the code to support rendering or all elements of the array wherever it is available.

company.contact
technical.languages
technical.frameworks
technical.protocols
asyncapi.versions

If there is some repetition, feel free to extract some code to reusable components

Hey @derberg Can I work on this.

@reachaadrika please 🙏

Hey @derberg I see no progress on this issue for 3 weeks
Mind if I take it up?

@Ciggzy1312 please go ahead

@derberg Instead of yaml can't we use markdown in case studies similar to blogs.

Hey, I picked YAML instead of MD to get data in a structured way that is very easy to read in the front end so we can build different UIs out of one data set.
now we just list all items from the YAML file in a given case study. Idea is that long term when we have many case studies, we can have a UI where we for example render only highlight on how different companies do schema versioning, or for example what are their use cases for AsyncAPI. So extracting info is much easier and user friendly, rather than you know, clicking through every case study one by one


ERROR in undefined is not a function

I am trying to copy an assets folder to my build directory. When I am running any type of webpack build commands I get an ERROR in undefined is not a function. It is working the way I am expecting it, but it does give me that message. I am one of those people that don't like error messages, so I was wondering if there was something I am not seeing here. I have all of the basic requirements to do the copy. Here is a rough look at my config file:
var info = require('./package.json');
var webpack = require('webpack');
var HtmlWebpackPlugin = require('html-webpack-plugin');
var path = require('path');
var CopyWebpackPlugin = require('copy-webpack-plugin');

module.exports = {

    entry: {
        'polyfills': 'angular2/bundles/angular2-polyfills',
        'vendor': './src/vendor.ts',
        'app': './src/bootstrap.ts'
    },
    output: {
        path: path.join(__dirname, 'build/'),
        filename: 'bundle-' + info.name + '-[name]-' + info.version + '.js'

    },
    devServer: {
        outputPath: path.join(__dirname, 'build')

    },
    context: path.join(__dirname),
    devtool: 'inline-source-map',
    resolve: {
        extensions: ['', '.webpack.js', '.web.js', '.ts', '.tsx', '.js',
        '.tpl.html'],
        root: path.resolve('.src'),
        moduleDirectories: ['node_modules', 'src', 'typings']

    },
    module: {
        loaders: [
            {
                test: /\.ts(x?)$/,
                loader:'ts-loader',
                exclude: /node_modules/
            }
        ]

    },
    plugins: [
        new HtmlWebpackPlugin({
            template: 'src/index.html'
        }),
        new CopyWebpackPlugin([
            {
                from: 'src/assets',
                to: 'assets'

            }
        ])
    ]
};

I hope its just a stupid configuration issue, but I am lost at the moment.

I don't see anything wrong with the config (at least for the copy-webpack-plugin side). Do you have a stacktrace for that error?

How does one even get a stack trace from webpack? I've got a similar useless message when I try to build my project at the moment...

After doing some more local debugging looks like this error is due to
var union = function union(set1, set2) {
return new Set([].concat(_toConsumableArray(set1), _toConsumableArray(set2)));
};
function _toConsumableArray(arr) { if (Array.isArray(arr)) { for (var i = 0, arr2 = Array(arr.length); i < arr.length; i++) { arr2[i] = arr[i]; } return arr2; } else { return Array.from(arr); } }
(or, to be more specific, the Array.from(...))
being invoked with new Set() and causing [TypeError: undefined is not a function]
Looks like something babel-related... similar to http://stackoverflow.com/questions/32000374/es6-babel-spread-error-with-set

Upgrading my Node version to 4.4.4 and rebuilding my node_modules seems to have made the issue go away, hopefully that helps someone out there!

I have this error here too :( but it appears to have worked..though doesn't give me full confidence.

I ran the node updater here and now version is 6.0.0 and no error. Thanks berg for the tip and Auha for the initial issue raise. BUT more than this thanks for a sane way (gulp spoilt brat here) to simply copy files and folders ....file-loader - pah !

@Auha does the latest version resolve your issue?

in my case yes.


failed to inject:mono_object_get_class() returned NULL

When I try to launch it the game crashes and an error message says "failed to inject:mono_object_get_class() returned NULL"

Hi, I will need some more information to understand why does this happens,

On which version of the game are you?
Is it the game from Steam or from the xbox game pass?
Which version of ValheimTooler do you use?
Do you use mods?

Kind regards,
Astropilot

I have the same problem. The latest game version (0.217.38). ValheimTooler 1.9.2. I have a graphics mod and another mod for unrestricted portals. Steam version. BepInEx mod not working too.

I have the same problem. The latest game version (0.217.38). ValheimTooler 1.9.2. I have a graphics mod and another mod for unrestricted portals. Steam version. BepInEx mod not working too.

Hi @WilczaQ ,
The standalone version (with the launcher) cannot work when you are using mods, the mod version should be used instead.
Which mod manager do you use?

@Astropilot r2modman.

@Astropilot now it's working, BepInEx not loading correctly before. I simply reinstalled the game

Hi, I'm closing this issue as I haven't had a reply from the original author. Feel free to open it again if needed.


"Invalid string length" building a library

Command
build
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Running ng build <project>, we obtain
❌  Generating "fesm2015"

Invalid string length

Indeed, fesm2020 build succeeded.
The dist sourcemap for fesm2020 reached 32MB, while the fesm2015 sourcemap reached 33MB (.mjs.map file).
The entire source code is about 200 components distributed in 1 single library.

No response

This should no longer be a problem with version 16+. Please update to a more recent version and if the problem persists please file a new issue with a minimal reproduction.
Having unrelated features in the same entry-point is discouraged as could cause JavaScript of components which are not needed in a specific page to be loaded and parsed.
It is recommended that features which are not used together are split into separate entry-points similar to how @angular/components package their components were each component is in a different entry-point.


Performance issues and queries not running

Type: Bug
I'm having issues with larger queries (large in() lists of several thousand values). The query doesn't run, and when I try and interact with the results (copying/selecting), it gets stuck on 'Copying' and 'Loading selected rows for calculation'

If I restart the app, it will play ball for a time, before breaking again.
Very frustrating so any help is appreciated!
Thank you
Azure Data Studio version: azuredatastudio-insiders 1.48.0-insider (7bdf5c994bcc25aaeb60584dcaa24f83e6fde7fd, 2024-01-29T07:04:50.019Z)
OS version: Darwin x64 23.3.0
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz (8 x 1400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
5, 4, 4

Memory (System)
8.00GB (0.04GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

I'm having this issue even for small results (10 or so rows). Trying to copy a single value will sometimes hang with exactly the same messages as the OP.
Version: 1.47.1 (system setup)
Commit: b6f7beb01f92adaa4b79b6b6f3ac704e95cafe6e
Date: 2024-01-10T02:15:02.628Z
VS Code: 1.82.0
Electron: 25.8.4
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

This is happening for me too. Often I will ctrl-tab to a different editor, when I come back I see all the results are empty and then they are "Loading selected rows for calculation" if there is a high latency between you and the Azure SQL DB. Seems ADS does not keep the results in the window but refreshes them every time you change to that tab. Terrible design if you ask me, why not just keep the results in the window in memory? Why are you refreshing them every time you change focus to that tab? Doesn't make sense. This never happened in SSMS.
Don't ask for logs, just query an Azure SQL DB that you have high latency to, like in a region on the other side of the world.

I have the same issue very frustrating only I run this on Apple MBP M2 Sonoma 14.6.1


Add monaco code editor

Much better now with the code editor vs a test area!
Thanks @nikolaystrikhar!


search: mark more strings for translation

@safwanrahman can you take a look at this file? I know that you were working on the search. These changes don't look too complicated but maybe this file won't exist anymore or similar. You know that :)

thanks @humitos for mentioning me.
This file will exist in the search upgrade, but I am hesitate to merge this before we deploy our new upgraded search. The template is changed in the new search, so I think we can hold this PR untill our search_upgrade branch merged into master.

Please either merge this now, cherry-pick in your branch, close the pr but don't expect me to respin  sometime in the future when some branch will merge, thanks.

@xrmx I have added this PR to the search Improvement milestone, so it will not get lost. If you want to merge it now, then you can open the PR against search_upgrade branch.

Gonna merge this, as it's useful, and the search upgrade is blocked currently :(

Thanks @xrmx


Is there a marker onclick hook?

I only see an event listener on the map itself in the API, but since there's an explicit bindPopup event on click, maybe there's a more general version exposed but not documented?

Never mind, can do
  const marker = WE.marker([latitude, longitude], markerImagePath)
  marker.addTo(earth)
  marker.element.onclick = clickHandler


Button missing in Asana

OS version:
Browser version:
Extension version:

Relevant integration (if any):
Asana
🐛 Describe the bug
Button missing on tasks, some users reporting button is there but does nothing.
Expected behaviour

Steps to reproduce

Steps to reproduce the behaviour:

Go to ...
...

Other details or context

Case reference 1
Case reference 2
Case reference 3
Case reference 4


fixes #81 - add support for changing contact list width

Fixes #81: Add hotkeys (Ctrl+, and Ctrl+. by default) for decreasing/increasing width of the contact list. The width will be stored in ui.conf.

Hi @luntik2012 - thanks for contributing to nchat!
Generally I think the patch looks good. The proposed default key bindings are not working on my macOS/Terminal and Linux/Gnome Terminal though, so I'm thinking we could change them (probably use alt-, and alt-.). I also have some other minor suggestions, but I think it's easiest if I merge the PR as-is, to a branch, make the minor follow-up changes, and then merge to to master.


Small step to prepare for native node glob support, and test waters of dep hygiene

Small step to prepare for native node glob support, and test waters of dep hygiene

@SocketSecurity ignore-all


Transparency regression on Windows

Describe the bug
Transparency no longer works out of the box on Windows 11 (at least). Instead, a black background is present.
Likely something to do with this commit
Steps To Reproduce

Be on Windows 11. Possibly 10 as well.
Create a webview using the WebViewBuilder, making sure to set with_transparent to true.
Observe a nontransparent window

Expected behavior
The background of our application window should be transparent.
Screenshots

Platform and Versions (please complete the following information):
OS: Windows 11 build 22000
Rustc: 1.63.0 (latest)
Would you assign yourself to resolve this bug?

[ ] Yes
[x] No

Additional context
Not totally vital, but we can't upgrade until resolved. Ping me if you can't reproduce this and I'll try to get some more info.

Thanks for the report, I will release a fix for this shortly


Pointing frame code

Change Summary
Overview
Provides algorithm that mocks Nick Duttons pointing frame (DPS frame) kernel generation. Note that I have TODOs that will be included in the next tickets.
New Files

pointing_frame_handler.py

writes a new C-kernel file containing the averaged pointing data

Testing

test_pointing_frame_handler.py

tests pointing_frame_handler.py

imap_science_0001.tf

pointing frame kernel used for test data

imap_sclk_0000.tsc

spacecraft clock kernel used for test data

imap_wkcp.tf

spacecraft frame kernel used for test data

Just as a note that we should discuss in a future tag-up. Because @subagonsouth had comments I think his approval should have been waited for. I approved suggesting my comments were sufficient, but thought maybe Tim should take another look before merging.


Expose a connection state from HubConnection

We should expose a ConnectionState enum from the HubConnection so that it's possible to avoid throwing from SendAsync if the HubConnection wasn't connected. Today it requires you storing your own bool and setting it in the Closed event.

Also need state on JS client.

Only that it can still throw if the connection gets disconnected after the check and before actually sending data...

Yep.

when will this be released? Microsoft.AspNetCore.SignalR.Client Version 1.0.2 doesn't include this.
I assume the 2.2.0 means Asp.Net Core 2.2? Why not sync SignalR versions to match Asp.Net Core to easily see which version has the fix?

when will this be released? Microsoft.AspNetCore.SignalR.Client Version 1.0.2 doesn't include this.

1.1, which will ship with ASP.NET Core 2.2

I assume the 2.2.0 means Asp.Net Core 2.2? Why not sync SignalR versions to match Asp.Net Core to easily see which version has the fix?

We'll sync it in 3.0

That's correct. There are packages on the myget feed if you want to try them out right now but the final build will be with ASP.NET Core 2.2

so I have to use this version?

the version works and I see the State property. How reliable are the 1.1 previews? Will we see radical API changes or only for 3 builds?
btw, it would be better to have 2 feeds (1 feed for 3.0 and 1 for 2.2/1.1).

I've tested the nightly versions a bit more, but it doesn't work the same like in the old SignalR. In my case 3 time the state is disconnected and I start 3 connections not only 1 like in old SignalR.
Application started. Press Ctrl+C to shut down.
dbug: Microsoft.AspNetCore.Server.Kestrel[1]
      Connection id "0HLG2H0UTOJ3O" started.
dbug: Microsoft.AspNetCore.Server.Kestrel[1]
      Connection id "0HLG2H0UTOJ3P" started.
dbug: Microsoft.AspNetCore.Server.Kestrel[2]
      Connection id "0HLG2H0UTOJ3O" stopped.
dbug: Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets[6]
      Connection id "0HLG2H0UTOJ3P" received FIN.
dbug: Microsoft.AspNetCore.Server.Kestrel[1]
      Connection id "0HLG2H0UTOJ3Q" started.
dbug: Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets[7]
      Connection id "0HLG2H0UTOJ3P" sending FIN.

Connection = new HubConnectionBuilder()
            .WithUrl("https://foo:5001/barService")
            .Build();

if (Connection.State == HubConnectionState.Disconnected)
            {
                try
                {
                    await Connection.StartAsync();
                }
                catch (Exception e)
                {
                    Debug.WriteLine(e);
                }
            }

I've tested the nightly versions a bit more, but it doesn't work the same like in the old SignalR

That's right, they work very differently.

In my case 3 time the state is disconnected and I start 3 connections not only 1 like in old SignalR.

Can you clarify what you mean? There's no intermediate states, there's disconnected and connected. There's no automatic reconnect either so when disconnected, you need to manually reconnect.

In each method I call a Connect method which checks the State to check if the connection is already connected and if not I start the connection. this works fine for old SignalR and I only have 1 connection. Now for the first 3 calls the state is always disconnected and I have 3 connections from 1 client.

Do you mean you have 3 different hubs?

Can you provide a sample project with repro steps?


[Feature Request] Multi Attachment Uploads

Describe the feature you'd like
I'd like to request multi attachment uploads under the "chapters" section
Describe the benefits this feature would bring to BookStack users
I recently converted over from Confluence PAID to BookStack and found it lacking an option to drag and drop multiple files into a chapter. This prolonged my transition over to BookStack and will take more of my time to upload other attached items later on when I make more documents.

Thanks for the request @athornfam2.
I'm a little confused on the fundamental request for issue. What of the following do you desire?:

The ability to upload attachments to chapters.
The ability to upload multiple attachments in a single operation on pages.

In regards to the listed benefits, these are usually intended to be focused on what the feature would bring to general existing BookStack users rather than personal benefits. I prefer to prioritise features that benefit existing users over attracting new users, and knowing the benefits to existing users can help assess if a feature is worthwhile to implement and maintain since it's likely not if it only benefits a single instance.

I'm requesting, as a feature, to add multi-attachment support on a per chapter level. I don't know "who" wouldn't want this function  especially if you need to upload a manual, reference pictures rather than injecting them into the document, raw files, etc...

Okay, So you're after any ability to upload an attachment to a chapter, whereas BookStack only currently offers attaching files to a page.
I'd rather keep chapters as an organisational element, rather than an element that contains content (including attachments) itself, since that's focused on pages currently. I like the currently focused simple nature of the chapter, and adding more content options to chapters may just lead to more confusion as to where content should lie.
To consider supporting such a change in the future, I'd need to hear good reasoning why attachments at the chapter level would be a benefit over the current page-only implementation.

Since there's been no further discussion or reasoning in the past year I'll close this off.


Add Clique Consensus Engine

What was wrong?
Py-EVM should be able to sync chains that use Clique consensus (e.g. used by Görli and Rinkeby)
How was it fixed?
This adds a new class CliqueConsensus with a validate_seal method that validates headers according to the clique consensus rules.
Notice, that some details of this feel a little hacky and I expect this to take some rounds of review to got to an architecture that feels sound.
I'll add some comments in line.

[x] Add entry to the release notes

Cute Animal Picture

@pipermerriam I did a bunch of cleanups, added more tests and documentation. I also created some comments on code paths that I believe deserve special attention. I consider it ready for review now :)

@pipermerriam This is ready for another round of review.


Support RISCV-64

This pull request adds support for RISCV-64. WIP now.

Now the fork is ok to build on Debian in RISC-V QEMU. Tests are passed.
Additional tests for float/double typed arguments are also added.

Can you update the README to add the new architecture support?
It'd be nice if this could be tested automatically; speaking of, it looks like the CI is broken, let me fix it first so that we can test this properly.

README.md has been updated :)

Any update about the CI?

@ziyao233 please, could you open a PR on https://github.com/ros2/Mimick ? Looks like ROS 2 uses that fork

Hey! any news on this? I'm now trying to compile ROS2 for RISC-V and having this package available for RISC-V would make my life way easier :D

The maintainer of this repo does not give me more updates.
if a PR on the fork of ROS2 is helpful, I will do that.


updated fail to return response

Previously, the response from the server is hidden for any non 200 responses, which hides validation messages. This commit allows error handling as detailed in the original superagent. http://visionmedia.github.io/superagent/#error-handling

Seems reasonable. You should update the tests and readme to match the new reality.

closed by #20


hide note message for pull request template

As title

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9d855bd). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #17529   +/-   ##
=======================================
  Coverage        ?   45.49%
=======================================
  Files           ?      793
  Lines           ?    88793
  Branches        ?        0
=======================================
  Hits            ?    40392
  Misses          ?    41889
  Partials        ?     6512

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d855bd...ca9a657. Read the comment docs.


Implement a POC based on BalancedShardsAllocator for searchable snapshots

Is your feature request related to a problem? Please describe.

Searchable snapshots will introduce a new remote searcher role - https://github.com/opensearch-project/OpenSearch/issues/3895
As a part of this, we would like to design a new shard allocation logic which will assign the searchable snapshot shards to the nodes with this new role

Describe the solution you'd like
This task will focus on the following -

Implement a POC using the existing BalancedShardsAllocator logic

Describe alternatives you've considered

N/A

Additional context

#4152
#4306

POC at https://github.com/kotwanikunal/OpenSearch/pull/4


Google Assistant says "something went wrong... try again in a few seconds" all the time

ON_CONVERSATION_TURN_STARTED
[979:7790:ERROR:speech_processing_task.cc(646)] Detected communication error: Downstream closed prematurely.
[979:7790:ERROR:assistant_output_handler.cc(589)] Failed with a general speech recognition error
ON_ASSISTANT_ERROR:
{'is_fatal': False}
ON_RESPONDING_STARTED:
{'is_error_response': True}
ON_RESPONDING_FINISHED
ON_CONVERSATION_TURN_FINISHED:
{'with_follow_on_turn': False}

It looks like other people without the SDK have the same problem. So it's not really an issue with the SDK.


[IOTDB-6164] Fix create illegal path through rest api bug

After this pr, we  will get error msg while using illegal path

And we must use `` to include the path to be successful.

Codecov Report

Merging #11178 (d4e3e93) into master (1aa098c) will decrease coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #11178      +/-   ##
============================================
- Coverage     47.57%   47.55%   -0.03%
+ Complexity    23628    23625       -3
============================================
  Files          2788     2788
  Lines        170312   170388      +76
  Branches      20294    20302       +8
============================================
  Hits          81032    81032
- Misses        89280    89356      +76

Files Changed
Coverage Δ

...node/manager/pipe/runtime/PipeHeartbeatParser.java
0.00% <0.00%> (ø)

...onfignode/manager/pipe/runtime/PipeMetaSyncer.java
0.00% <0.00%> (ø)

...fignode/manager/pipe/task/PipeTaskCoordinator.java
0.00% <0.00%> (ø)

...ode/manager/pipe/task/PipeTaskCoordinatorLock.java
0.00% <0.00%> (ø)

...dure/impl/pipe/AbstractOperatePipeProcedureV2.java
5.91% <0.00%> (-2.22%)
:arrow_down:

.../rest/v1/handler/StatementConstructionHandler.java
0.00% <0.00%> (ø)

.../rest/v2/handler/StatementConstructionHandler.java
0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[2.x] Backports changes related to demo configuration tool

Description
Backports following commits related to demo configuration tool from main to 2.x:

[x] 17748b9 from #3669
[x] 4496440 from #3734
[x] 06d8c29 from #3777
[x] e698315 from #3807
[x] 9d11524 from #3843
[x] 62aed21 from https://github.com/opensearch-project/security/pull/3850
[x] ceabe13 from #3844

Issues Resolved

Resolves https://github.com/opensearch-project/security/issues/3827

Testing

automated tests

Check List

[x] New functionality includes testing
[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'll refactor current PR to match the plugin install workflow on 2.x

There was mismatch in Documentation in developer guide between main and 2x. I've refactored that file to be in line with main.


update Placement and PlacementDecision API to v1beta1

Ref: https://github.com/stolostron/backlog/issues/19189
Signed-off-by: haoqing0110<EMAIL_ADDRESS>

/assign @qiujian16 @elgnay


feat(frontend): extend exchange.derived with BTC testnet and regtest

Motivation
Extend exchange.derived with BTC testnet and regtest in order to calculate usdBalance for those tokens.

I can see that there is indeed a market for testnet, but I somehow can't find it in coingecko API. In any case, let's use this PR for regtest only, will do the same for testnet separately.


Unknown type name 'CARingBuffer'  in  CH08-AUGraphInput

CARingBuffer_Wrapper.cpp:15:5: Unknown type name 'CARingBuffer'

@little-dandan, would you please to check if CARingBuffer class exists at the following path?
/Library/Developer/CoreAudio/PublicUtility/CARingBuffer.cpp
If you have the book, "Learning Core Audio", in the Footnotes section, it will introduce you how to install CARingBuffer.
In case you don't have the book, you can use "More Developer Tools..." menu item on Xcode and find "Audio Tools for Xcode" package to install CARingBuffer.


Think about survey solutions

The data we need to gather is very complex. I don't think there are any COTS survey solutions that will meet our needs. The best path forward is probably to model the data we need to collect and build a CRUD app.


Feature request: control light

Can you add control entity for lights ?

This is in my plan, but I don't know when I can implement it.
I don't have a compatible light, so it is tricky to test this for me.

Oh, ok thank you.
Maybe I can help you if you want

created a PR ;)


RFC for Vec::append_from_within()

Rendered
This addition is quite trivial. However, in the pre-RFC I've learned that there are many approaches to solving this, so I'm opening an RFC to provide a clear rationale and get some input on the final design.
Prototype implementation in playground

This feels very ad-hoc. I wonder if exposing some intermediate building block would help? Something like:
impl<T> Vec<T> {
    /// Returns the result of `self.as_mut_slice()` together with the rest of the capacity.
    ///
    /// The two slices have length `self.len()` and `self.capacity() - self.len()` respectively.
    pub fn with_uninit_capacity(&mut self) -> (&mut [T], &mut [MaybeUninit<T>]) {…}
}

impl<T> MaybeUninit<T> {
    /// Panic if the two slices have different lengths.
    pub fn copy_from_slice(this: &mut [Self], other: &[T]) where T: Copy {…}
    pub fn clone_from_slice(this: &mut [Self], other: &[T]) where T: Clone {…}
}

Then, append_from_within could be implemented outside of the standard library with the only unsafe code being a call to Vec::set_len.

I do not believe the MaybeUninit solution is optimal. For one, MaybeUninit::copy_from_slice actually guarantees that the buffer is initialized after its completion, but this is not reflected in the type system. Which is why this still requires an unsafe set_len() operation on the vector. Also, performance characteristics of this solution when used in a loop are exactly the same as for append_from_within. Finally, two similar but entirely safe solutions are already discussed in detail in "Alternatives" section.
Note that the desired end result in all three motivating examples is actually repeat_tail(&mut self, elements: usize, times: usize), while append_from_within() intended as a minimum viable safe building block for implementing the former.
While a hypothetical more general solutions could serve more use cases (see the pre-RFC for a motivating example from Claxon for a more general abstraction), it would take a long time to design and implement, and it would not entirely supersede append_from_within(). This function is more discoverable and easier to apply than a generic abstraction by virtue of being much simpler and also by being the counterpart of an existing method on slice. And in this case having a low cognitive load is important: as illustrated by the motivating examples, people are repeatedly tempted to hand-roll this and keep getting it wrong.

Could we add a self-contained description of why this method is so difficult to implement correctly? Two of the three example links didn't seem to ever describe the bug, and the third explained only at the end of a very long post about a bunch of other security stuff that the broken code forgot to check if an argument was 0 (which imo is a perfectly good answer, if that is correct, it just needs to be easier to find).

The code in rust stdlib was not checking for overflow in capacity calculation. Here's the fix.
DEFLATE decoders forgot to check that one of the arguments is not 0. Here is a simplified version of the code they used that illustrates the problem:
/// Repeats `repeating_fragment_len` bytes at the end of the buffer
/// until an additional `num_bytes_to_fill` in the buffer is filled
pub fn decode_rle_vulnerable(buffer: &mut Vec<u8>, repeating_fragment_len: usize, num_bytes_to_fill: usize) {
    buffer.reserve(num_bytes_to_fill); // allocate required memory immediately, it's faster this way
    unsafe { // set length of the buffer up front so we can set elements in a slice instead of pushing, which is slow
        buffer.set_len(buffer.len() + num_bytes_to_fill);
    }
    for i in (buffer.len() - num_bytes_to_fill)..buffer.len() {
        self.buffer[i] = self.buffer[i - repeating_fragment_len];
    }
}

If you pass repeating_fragment_len set to 0 it will expose contents of uninitialized memory in the output. Both inflate and libflate crates have this bug even though they were implemented independently.

Thanks, that makes perfect sense now.

You'll need separate append_copies_from_within and append_clones_from_within, because the copy version require only Vec::set_len, while the Clone versions requires first Vec::as_mut_ptr and then later Vec::set_len.
In the simple versions, If Vec<(F,Arc<T>)> panics mid-way, due to F::Clone panicing, then the Arc<T> gets left with an incorrect ref count, which sounds okay but annoying.  If otoh Mutex<Vec<F>> panics then PoisonError permits access while the Vec<F> contains uninitialized data.  You could do only one Vec::set_len at the end in the Clone version, but doing them after each Clone works too.

I was using slice::copy_within() as reference, and that is restricted to Copy types.
I am open to adding append_clones_from_within() if there are use cases for it.

I was using slice::copy_within() as reference

I like this plan -- when I saw it get stabilized in 1.37 I also thought of this scenario, as it implicitly set a precedent for API design for things that treat part of themselves as input.
(Now that it's simplified so much and not blazing its own trail -- something like .as_fixed_capacity() was a much bigger addition -- I'd personally consider it small enough to just be a PR instead of an RFC, though of course I'm not on libs so my opinion isn't all that important here.)

@WanzenBug and me have ported libflate to a 100% safe RLE implementation using this abstraction. That let us remove an unsound bespoke unsafe block.
It also improved end-to-end performance by 5% over the unsafe, unsound implementation, and by much more over the best safe implementation possible without append_from_within().

From reading the RFC I found that Vec::repeat_part was a more clear description and API for the desired operation than append_from_within despite being more generic. That coupled with the potential to allow for eliding the checks makes it more compelling to me than append_from_within.
bikeshed I think switching the position of the parameters would better match the name. e.g. (&mut self, times: usize, src: Range) as you first specify how may times you're going to repeat and then what part you want to repeat.

I don't think the name repeat_part is clear at all; it sounds like it might return a repeated value without modifying the Vec, or perhaps replace the part with repeated copies of itself (as opposed to appending those copies at the end).

So I went through Vec's current methods to see if there was existing terminology that would make more sense, and I think the extend terminology might suit this better. E.g. append_from_within -> extend_from_within, repeat_part -> extend_from_part.

Thanks for the RFC here @Shnatsel and sorry for the delay!
FWIW the libs team tends to not require RFCs for API additions like this nowadays. This looks like a pretty reasonable feature addition to send in a PR, and we can have more discussion there if necessary (but it seems like a lot has happened here already!) and we can have another round of discussion before stabilization.
Does that sound alright with you? If so feel free to adapt the discussion here to a PR sent to libstd, and we can close this and open a tracking issue and copy over any remaining unresolved questions and such.

Sounds good to me! I'll close this as soon as I create a PR.

BTW: could we get the README in this repo updated? It states that additions to std require an RFC.

Sure! Seems reasonable to update the README

@Shnatsel did you ever get a chance to make a PR?

No, I didn't get around to it yet. I got sidetracked by other projects.

For future reference, this would also eliminate the only unsafe block in ruzstd, the zstd decoder in Rust:
https://github.com/KillingSpark/zstd-rs/blob/e521dfdb4005b9d6d9556a8e3df9db445a5d038d/src/decoding/decodebuffer.rs#L135

@Shnatsel am I right, that feature is still unimplemented? If so, I could ake a PR.

am I right, that feature is still unimplemented?

Yes, that is correct.
After a bunch of experimentation with this in a crate I am convinced that the API described here is the right level of abstraction to expose.
The implementation is already written and tested, see https://github.com/WanzenBug/rle-decode-helper/blob/690742a0de158d391b7bde1a0c71cccfdad33ab3/src/lib.rs#L74
All you need to do is make a PR for the standard library adding this function. I'd very much appreciate this since I keep getting sidetracked by other projects.

Since https://github.com/rust-lang/rust/pull/79015 was merged, I guess this PR can be closed?


Circles don't appear well on Android

On Android phones, drawing a circle seems to just draw a few arcs instead of the whole picture.  I suspect a scaling issue.

This is using Chrome on a Nexus 5X.  I have not verified on other phones or browsers.

Seems fine using Firefox, Chrome and Default Browser on Galaxy S7.

Seems to have gone away.


python310Packages.google-cloud-pubsub: 2.15.0 -> 2.16.0

Changelog: https://github.com/googleapis/python-pubsub/blob/v2.16.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228689 run on x86_64-linux 1

10 packages built:

home-assistant-component-tests.google_pubsub
home-assistant-component-tests.nest
python310Packages.google-cloud-pubsub
python310Packages.google-cloud-pubsub.dist
python310Packages.google-nest-sdm
python310Packages.google-nest-sdm.dist
python311Packages.google-cloud-pubsub
python311Packages.google-cloud-pubsub.dist
python311Packages.google-nest-sdm
python311Packages.google-nest-sdm.dist