Provide some guidance on how to deal with security issues originating from compose-jb for web

I have a public project on GitHub built with compose-jb for web. This means that I get Dependabot security alerts for free by default. Recently I got an alert about this critical security issue: https://github.com/advisories/GHSA-76p3-8jx3-jpfq

(dumping a copy of that page so that this issue shows up in people's search results)
Prototype pollution in webpack loader-utils
Critical severity GitHub Reviewed Published on Oct 13 • Updated 7 days ago
[Vulnerability details](https://github.com/advisories/GHSA-76p3-8jx3-jpfq)
Dependabot alerts
4
Package
 loader-utils (
[npm](https://github.com/advisories?query=ecosystem%3Anpm)
)
Affected versions
>= 2.0.0, < 2.0.3
< 1.4.1
Patched versions
2.0.3
1.4.1
Description
Prototype pollution vulnerability in function parseQuery in parseQuery.js in webpack loader-utils prior to version 2.0.3 via the name variable in parseQuery.js.

References
[nvd.nist.gov/vuln/detail/CVE-2022-37601](https://nvd.nist.gov/vuln/detail/CVE-2022-37601)
https://github.com/webpack/loader-utils/issues/212
[webpack/loader-utils@d9f4e23/lib/parseQuery.js#L11](https://github.com/webpack/loader-utils/blob/d9f4e23cf411d8556f8bac2d3bf05a6e0103b568/lib/parseQuery.js#L11)
[webpack/loader-utils@d9f4e23/lib/parseQuery.js#L47](https://github.com/webpack/loader-utils/blob/d9f4e23cf411d8556f8bac2d3bf05a6e0103b568/lib/parseQuery.js#L47)
<EMAIL_ADDRESS>(release)](https://github.com/webpack/loader-utils/releases/tag/v2.0.3)
https://github.com/webpack/loader-utils/pull/217
https://github.com/webpack/loader-utils/pull/220
<EMAIL_ADDRESS>(release)](https://github.com/webpack/loader-utils/releases/tag/v1.4.1)
Severity
Critical
9.8
/ 10
CVSS base metrics
Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
High
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Weaknesses
https://github.com/advisories?query=cwe%3A1321
CVE ID
CVE-2022-37601
GHSA ID
GHSA-76p3-8jx3-jpfq

This issue is not about fixing that security issue, though that should also be fixed. This is issue is about how to handle these security issues in general. As a user/consumer of compose-jb for web, how do I deal with such security reports? Do I apply the fixes suggested by the advisory, and hope that my project still builds, or do I sit back, relax and wait for compose-jb for web to be updated, including the required fixes? Some guidance on this subject would be nice to have in the compose-jb documentation.
Do note that, in general, there are relatively many security issues in my project: 11 opened in the past 28 days, 2 of which are labelled critical and 5 are labelled high (I won't copy them all here, unless that would be helpful: let me know). I don't do anything with these web dependencies directly; they all originate from NPM deps in kotlin-js-store/yarn.lock. The noise that these advisories make is what worries me and what I'd like some guidance on.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Build issue related to barrierColor

I'm trying out the library and attempting to add a modal. I've copied over the modal example and run into compile issues when building the project, related to barrierColor not being found. I've tried including it in the S2ModalConfig, but no luck. I'm using the latest version 4.3.2.
Error log:
Compiler message:
../../Flutter/fluttersdk/.pub-cache/hosted/pub.dartlang.org/smart_select-4.3.2/lib/src/widget.dart:1023:11: Error: No named parameter with the name 'barrierColor'.
          barrierColor: modalConfig.barrierColor,
          ^^^^^^^^^^^^
../../Flutter/fluttersdk/packages/flutter/lib/src/material/dialog.dart:898:11: Context: Found this candidate, but the arguments don't match.
Future<T> showDialog<T>({
          ^^^^^^^^^^

Sample code with error
import 'package:flutter/material.dart';
import 'package:mindfulness_reminders/ui_res/TextStyles.dart';
import 'package:smart_select/smart_select.dart';

class AddReminderScreen extends StatefulWidget {
  @override
  _AddReminderScreenState createState() => _AddReminderScreenState();
}

class _AddReminderScreenState extends State<AddReminderScreen> {

  List<S2Choice<String>> days = [
    S2Choice<String>(value: 'mon', title: 'Monday'),
    S2Choice<String>(value: 'tue', title: 'Tuesday'),
    S2Choice<String>(value: 'wed', title: 'Wednesday'),
    S2Choice<String>(value: 'thu', title: 'Thursday'),
    S2Choice<String>(value: 'fri', title: 'Friday'),
    S2Choice<String>(value: 'sat', title: 'Saturday'),
    S2Choice<String>(value: 'sun', title: 'Sunday'),
  ];

  String _day = 'fri';

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: const Text('Add Reminder'),
        ),
        body: Column(children: <Widget>[
          SmartSelect<String>.single(
            title: 'Days',
            value: _day,
            choiceItems: days,
            onChange: (state) => setState(() => _day = state.value),
            modalConfig: S2ModalConfig(
              type: S2ModalType.fullPage,
              barrierColor: Colors.black54
            ),
          ),
        ]));
  }
}

Also, the same error happens when using the sample code from the home page
import 'package:flutter/material.dart';
import 'package:mindfulness_reminders/ui_res/TextStyles.dart';
import 'package:smart_select/smart_select.dart';

class AddReminderScreen extends StatefulWidget {
  @override
  _AddReminderScreenState createState() => _AddReminderScreenState();
}

class _AddReminderScreenState extends State<AddReminderScreen> {

  String value = 'flutter';
  List<S2Choice<String>> options = [
    S2Choice<String>(value: 'ion', title: 'Ionic'),
    S2Choice<String>(value: 'flu', title: 'Flutter'),
    S2Choice<String>(value: 'rea', title: 'React Native'),
  ];

  @override
  Widget build(BuildContext context) {
    return SmartSelect<String>.single(
                title: 'Frameworks',
                value: value,
                choiceItems: options,
                onChange: (state) => setState(() => value = state.value)
            );
  }
}

Issue was resolved by updating Flutter

I released https://pub.dev/packages/flutter_awesome_select with fixed null safety.
Could you check that everything works for you?


global Variable undefined

Discussed in https://github.com/AnWeber/vscode-httpyac/discussions/47

Originally posted by gerukin July  6, 2021
Hi, I'm new to httpyac. I currently use rest-client and Postman. The extension and runner look promising, congrats!, but somehow I cannot make anything work.
I'm using the latest general availability vscode (Mac) and have installed both the cli and the extension. I opened a new folder with just this one file:
@url = http://www.google.com

### Test
{{url}}

Clicking send gets me this:
ERROR: js: exports.$result = (url);
ERROR: ReferenceError - url is not defined
ReferenceError: url is not defined
	at Object.userJS (/Users/gerukin/dev/http-test/test.http:4:86)
	at Object.<anonymous> (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:37501)
	at Generator.next (<anonymous>)
	at /Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:36506
	at new Promise (<anonymous>)
	at s (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:36251)
	at Object.g (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:36785)
	at t.JavascriptVariableReplacer.<anonymous> (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:143455)
	at Generator.next (<anonymous>)
	at /Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:142841
	at new Promise (<anonymous>)
	at r (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:142586)
	at t.JavascriptVariableReplacer.replace (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:143089)
	at Object.<anonymous> (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:46841)
	at Generator.next (<anonymous>)
	at s (/Users/gerukin/.vscode/extensions/anweber.vscode-httpyac-2.18.0/dist/extension.js:587:46333)
	at processTicksAndRejections (internal/process/task_queues.js:93:5)

This works though:
### Test
@url = http://www.google.com
{{url}}

But my understanding is that those variables are in a global scope and should be available to all requests. What am I doing wrong?

The cause was an incorrect setting of an If condition for the check whether the progress bar should be displayed. This change was included in the previous version for httpbook and unfortunately caused an error in vscode-httpyac.


[General] Integration of the over the air to application

Dear,
Currently, I have the application working on ESP IDF and connect to MQTT based AFR and I need to integrate the OTA demo to this application to support update over the air so what is need to be called from Application context to support over the air update from the OTA Mqtt demo.
Describe the desired outcome
Integrating version 202107 of the OTA demo in my application.
System information
Hardware board: [ESP32 ]
IDE used: [ ESP_IDF ]
Operating System: [ Windows ]
Code version: 202107
Project/Demo: [ ota_demo_core_mqtt\ota_demo_core_mqtt.c]

OK, so the MQTT demo is based on the coreMQTT not coreMQTT_Agent so when using the OTA I must use  coreMQTT_Agent for MQTT demo is this correct? as the issue the linking between the MQTT and OTA on same network context as according to a new update for OTA_Init the pvConnectionContext removed as The connection the OTA Library Version 3 does not require the connection context to be passed to it and the MQTT operations are handled by their respective interfaces in the OTA demo or application. so how I can link the OTA with the same MQTT demo example.


LDAP connection issue with ARM devices like Raspberry Pi

Bug description
I've tried to connect my portainer (running on a Raspberry Pi 3B+) to an LDAP server, but without success, all I got from logs is:
2019/10/08 21:29:09 ldap: recovered panic in processMessages: runtime error: invalid memory address or nil pointer dereference
2019/10/08 21:29:09 http error: Unable to connect to LDAP server (err=LDAP Result Code 200 "Network Error": ldap: response channel closed) (code=500)

After some search I've found this issue with some ARM processors on the LDAP library: https://github.com/go-ldap/ldap/pull/199
From the above link it seems that the temporary fix is into version v3 of the LDAP library, now portainer is using the v2 "gopkg.in/ldap.v2". Is it possible to update to "gopkg.in/ldap.v3"?
Thanks,
Simone
Technical details:

Portainer version: 1.22.0
Docker version (managed by Portainer): 19.03.2, build 6a30dfc
Platform (windows/linux): linux ARM - Raspberry Pi 3B+

Hi there,
Have you verified that Portainer has connectivity to the LDAP server via the Connectivity check option in the LDAP configuration section?
It may help you to follow our user guides on how to configure LDAP in Portainer:
https://www.portainer.io/2018/09/ldap-users-groups-portainer/
https://www.portainer.io/2017/08/enable-ldap-ad-authentication-portainer-io/

Yes, obviously, I've checked with it hundred of times, I've also tried with other LDAP servers but without any result. The same configurations works perfectly on other tools on the same machine like Jenkins and Gerrit, only portainer give me the error that I've pasted above.
The XHR call to checkLDAP and consequently the user interface return to me the message above LDAP Result Code 200 "Network Error": ldap: response channel closed...
After some hours of search on the possible cause I came across that issue on the LDAP library: https://github.com/go-ldap/ldap/issues/195
That seem to be solved into the v3 of the LDAP library: https://github.com/go-ldap/ldap/pull/199
Thanks,
Simone

I can also add that I've just tested the same LDAP configuration used into the ARM device (that doesn't work) also on a x86_64 machine configured in the same way of the ARM one and on the x86_64 it works without any problem, so now it must be clearly an issue related to ARM as mentioned above...
Thanks,
Simone

Same issue here

Closed via #3386


Add property for a screen reader accessible label for the container

Pull Request Test Coverage Report for Build 90

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.99%

Totals

Change from base Build 89:
0.0%

Covered Lines:
53

Relevant Lines:
53

💛  - Coveralls

Pull Request Test Coverage Report for Build 90

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.99%

Totals

Change from base Build 89:
0.0%

Covered Lines:
53

Relevant Lines:
53

💛  - Coveralls

Pull Request Test Coverage Report for Build 90

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.99%

Totals

Change from base Build 89:
0.0%

Covered Lines:
53

Relevant Lines:
53

💛  - Coveralls

Pull Request Test Coverage Report for Build 90

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.99%

Totals

Change from base Build 89:
0.0%

Covered Lines:
53

Relevant Lines:
53

💛  - Coveralls

This fixes #51. If no containerLabel is passed in, a default of "Table of contents" will be used as the aria-label for the container nav element. This makes it distinguishable from other possible nav elements on the same page, which may be used for the main or secondary navigations, or for grouping links in the footer. Blind users who cannot see the whole structure of a page at a glance, will then immediately know that this is a table of contents.

This fixes #51. If no containerLabel is passed in, a default of "Table of contents" will be used as the aria-label for the container nav element. This makes it distinguishable from other possible nav elements on the same page, which may be used for the main or secondary navigations, or for grouping links in the footer. Blind users who cannot see the whole structure of a page at a glance, will then immediately know that this is a table of contents.


Great tutorial !!!

These are among the best short tutorials I've watched. Very clear, at the tight pace. Congrats on that! I want to suggest that you do the same for Power Query, it would be awesome to have this kind of clarity with that one too! Thanks a lot.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bcb9bc55-ac56-d1ab-c465-4e41bfa8f152
Version Independent ID: 44bd9bb3-5aad-31ac-27b6-53e3c0554960
Content: Introduction to DAX - Power BI
Content Source: powerbi-docs/guided-learning/introductiontodax.yml
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @mau-lopez. We really appreciate the positive feedback. I've assigned this issue to the doc author for review.

@mau-lopez  - thank you! Happy to hear you liked these, and we'll see about doing the same for Power Query.


Panwang/taskruns

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

hi @pan-wang could you pls address comments ?

Thank so much for remaindering.
We are working on twitting the change for better ARM deployment experience. Will address all feedbacks soon once we land on final change.
Thanks
Pan

From: Yunge Zhu<EMAIL_ADDRESS>Sent: Monday, October 7, 2019 11:32 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: pan-wang<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Panwang/taskruns (#7123)
hi @pan-wanghttps://github.com/pan-wang could you pls address comments ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-rest-api-specs/pull/7123?email_source=notifications&email_token=AEKUVW7X75CINWR4D35NII3QNP5NJA5CNFSM4ITX26M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASQXII#issuecomment-539298721, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKUVW3F7SCAWTDESRLVROTQNP5NJANCNFSM4ITX26MQ.

@krishbabu Could we move forward for this PR? We would like to file a separate work item to solve the debt per discussion above. And there're two Ignore Test-Only CI fail. We can just ignore, right?

@krishbabu Could we move forward for this PR? We would like to file a separate work item to solve the debt per discussion above. And there're two Ignore Test-Only CI fail. We can just ignore, right?

I think you meant @KrisBash. For the CI failures, @anuchandy will need to weigh as the SDK team owns these checks.

Signing off from ARM side.

@majastrz ARM signed off this change. Could you continue merge the manifest?

@anuchandy Could you merge the PR? The manifest update was blocked now.


[analyzer] Handle type in TypeArgumentList is Null

Adding the following two lines in sdk/lib/ffi/ffi.dart:
@Brinstar<Void Function(Handle)>()
final z = 0;

I get:
[53/54] ACTION //utils/dartanalyzer:generate_summary_strong(//build/toolchain/linux:clang_x64)
...
type 'Null' is not a subtype of type 'ParameterElementImpl' in type cast
#0      AstBinaryWriter._storeFormalParameter (package:analyzer/src/summary2/ast_binary_writer.dart:780:40)
#1      AstBinaryWriter._storeNormalFormalParameter (package:analyzer/src/summary2/ast_binary_writer.dart:818:5)
#2      AstBinaryWriter.visitSimpleFormalParameter (package:analyzer/src/summary2/ast_binary_writer.dart:613:5)
...
#5      AstBinaryWriter.visitFormalParameterList (package:analyzer/src/summary2/ast_binary_writer.dart:276:5)
...
#8      AstBinaryWriter.visitGenericFunctionType (package:analyzer/src/summary2/ast_binary_writer.dart:333:5)
...
#11     AstBinaryWriter.visitTypeArgumentList (package:analyzer/src/summary2/ast_binary_writer.dart:698:5)
...
#15     AstBinaryWriter.visitAnnotation (package:analyzer/src/summary2/ast_binary_writer.dart:39:5)
...
#26     _Builder.build (package:analyzer/dart/sdk/build_sdk_summary.dart:109:22)
#27     buildSdkSummary (package:analyzer/dart/sdk/build_sdk_summary.dart:74:5)
...

The node it's dying on is Handle.
Edit: It looks like the error happens regardless of any type of any part. The only requirement is that the annotation type is a Function type.

@scheglov, @bwilkerson Do you know if this is a bug, or if I'm just doing something crazy here that is expected to fail?

I've bisect'd my way back to e021d0c1714ccd22308e251a3978ef9880a128a1 which introduced this issue.

https://dart-review.googlesource.com/c/sdk/+/201940


Fix using merged models var instead of user provided models in props

While researching how to use custom models found a tiny bug.
When you specify a model prop in your adapter initialization, this prop gets preference used in the spread in L32 instead of the previously built/merged models variable.
Putting the spread at the beginning and models later will make sure that we overwrite whatever the user custom models are with the merged object from default/user provided.
Happy to fix any wording or whatever else is needed, working on a Tutorial for the usage of custom models also.

Seems like it's an issue in v3 too, happy to make another pr against that or move this oen to v3 of the release is soon

Doh! Thanks for spotting this! This looks great!
Some tutorials for this would be amazing, we get asked about this a lot! It's an intended feature but not one we have any information that explains how to actually use it.
Heads up: I might be refactoring this file to change how transforms work for custom models so it's easier to use them (e.g. work around timestamp type conversion, as TypeORM doesn't handle that automatically and if you are using a Postgres it means timestamps are wrong as don't get saved as UTC).
https://github.com/iaincollins/next-auth/blob/ace756d0cdcd4552e2520b6a74725f69dfddab90/src/adapters/typeorm/lib/transform.js


Remote indicator for folders and workspaces from contributed file systems

Show the host name in the remote indicator when a folder or a workspace on a contributed file system is open.
Example is the RemoteHub extension that allows to browse github repos.
The folder URI is: "remotehub://github.com/aeschli/test-theme"

The host name comes from the label provider (that RemoteHub already has)
		"resourceLabelFormatters": [
			{
				"scheme": "remotehub",
				"authority": "*",
				"formatting": {
					"label": "${authority}${path}",
					"separator": "/",
					"workspaceSuffix": "GitHub"
				}
			}
		]

FYI @eamodio


Finite state machines

Hello,
I was looking for a Finite State Machine implementation for my game, but found only limited implementations working as plugins.
As FSM are a commonly used tool to define objects behavious in video games, I was wondering why not implement it as a built-in feature for godot.
Thus, I open this issue to discuss multiple thing:

Should it be implemented as a built-in function ?
If the answer is yes, how ?

Here is my idea of a possible implementation:

A FSM parent node is responsible for the state machine handling, while its children are the states.

The initial state is the first child node (or predefined maybe).
A transition between two nodes can be added using a function of the FSM node:
add_transition(NodePath from, NodePath to, FuncRef[] conditions, FuncRef[] inverted_conditions, int priority=0)
When the current state is the "from" node (or one of its children), the transition can be trigerred if all functions called in conditions return true and all functions called in inverted_conditions return false. The current state node is then set to to. Transitions with higher priorities are treated first.
An "update" function in the FSM node triggers transitions util none can be triggered (up to a fixed limit of transitions, so that it does not goes in circles until infinity).
State nodes can implement three functions that are automatically called when the FSM update is triggered:

on_state_enter is trigerred when the node becomes the current state
on_state_exit is trigerred when the node is no more the current state
on_state_update is triggered once per update FSM call, once we have found the new state.

This implementation could be completed with a specific editor view, with something like that:

What do you think ?

Unity supports state machine (although only for animations).
I think generic state machine would be very useful tool in Godot:

Basic AI
Animations States
Characters States
Heavy UI games

and probably more.

I don't like node-based implementations, also godot offer many ways to do it (code, node, signal), and 3 could let make complex designs to tweak with visual scripts for mechanics designers.
For generic FSM could be better to have a framework, like Escoria.

Strange that nobody yet mentioned the FSM plugin by @kubecz3k ... https://godotengine.org/asset-library/asset/5 (though it is slightly WIP it seems...)

Well, I do not see why the three solution should be considered separately. I mean, scripts are basically an extend to a base node class. Creating a script attached to a node is like creating a class inheriting from its parent class node. When some features are used by a lot of people (FSM are), I think the considered features could be implemented as a real node.
Signals are, IMO, an unadequate design pattern (they correspond to the Observer design pattern) for implementing FSMs. That is why I suggest an other implementation for them.
I do not get why you do not like Node-based implementations. I mean, even the GUI system is based on nodes, so why not provide the developper with node-based AI features ?
@bojidar-bg I saw the plugin and tested it, but it lacks some flexibility (no functions are called when states changes, but the global idea is what i propose). It is also still a plugin, the question was also "should it be implemented as a builtin-features ?" (I believe so) :)

As far as I know, something like this is already planned for 3.1 under the name transition graph.

@groud what do you mean that no function is called when the state changes? You can connect a signal "stateChanged" to be notified about state changes. I'm using this plugin a lot in my projects, version on the asset store is very slightly outdated (cosmetic stuff).I think I will get some windows machine and try to test it on it since 'tool editor' part is not working on windows as far as I know. If I succeed I think I will record some tutorial on how to use it since it seems there might be need for that.

@tagcup it seems that you are right. I hope this will be usable as a generic state machine too.
@kubecz3k well if you need to connect all children to the fsm node to detect if they are the current state, this is a little bit heavy no ? But I may miss something in how to use your plugin... ^^"

@groud Yeah you totally missed the point how to use the plugin (I guess it's my fault in the end). Will create some video tutorial and put it on the net. You can use signal to be notified about state change, but you can also just use fsm.getStateID() method. Check fsm.gd script to see how api looks like: https://github.com/kubecz3k/FiniteStateMachine/blob/master/addons/net.kivano.fsm/content/fsm.gd
Also I have managed today to test the plugin on Windows 10 and it seems it's working fine in the end...

@kubecz3k ok, I had a look to the code, I understand it a little bit better I believe. The enter(), update() and exit() functions, called for the children node do what I was looking for.
Anyway, does it features hierachical FSM ? I cannot see how they could be implemented in your code.
Aside from that, as your plugin does not provide a structure to store the transitions, I believe creating a visualization tool will be difficult.

@groud no it does not provide stucture do store transforms. I didn't had an y good idea for this part at the time, there is just an option to hardcode transforms inside states (so you can implement computeNextState() from https://github.com/kubecz3k/FiniteStateMachine/blob/master/addons/net.kivano.fsm/content/StateTemplate.gd ) alternatively  you can not use this option and just steer manually with fsm.setStateID(). I also think visual tool for FSM would be the best. Do you have any structure for storing transforms in mind? Some kind of function references 2 states map? That part sounds like something I could benefit from, if you have any ideas for this it would be great if you could open an issue on plugin github page (don't want to spam to much this discussion with discussion related to my plugin)
Also yes there is no support for hierarhical fsm since I'm not using those in my current games - I think the most close what you can have in this plugin is to have multiple FSMs and manually steer them from up to down  (more important fsms know about atomic ones but not other way), but haven't tried this.
Also as I said the plugin is little outdated right now, I think I will update it tomorrow, changes are cosmetic in terms of LOC but handy sometimes (like passing custom arguments to update/init or having dictionary with states names so you dont need to use strings at all (more error prone)).

Ok I see :)
Well, for now it was thinking in using a FuncRef to store transitions, instead of using hardcoded ones. I will try to code something in the next few days and see what i can came up with.

@groud I have booked couple hours tomorrow to create video and clean/upload changes. I think I might give a shot for this transition structure as well since it's something that this plugin (and my projects :P) could benefit for sure.

I know it has been couple of days and there still is no tutorials/new functions... but I think you will forgive me :)

(still wip but almost done)

@kubecz3k what do you think about a structure to be used with Visual Script? I think that with custom nodes may be possible to do something.
This is one of the few things where I think VS may be useful :smile:

@kubecz3k
Holly crap!

@eon-s well I have prototyped fsm on visual script when I was giving initial feedback on visual script :) In short I don't have any strong opinion on it, I kind of like it even without any additional nodes/structures. But for now I think VS is not as readable for FSM purpose as that kind of simple graph that was designed for FSM, to tell truth when I started implementing this on Monday I was using initially GraphNodes from VS but it was a little unreadable and I was not happy with this solution. But for sure I will experiment with VS a lot more in 3.0
ps. if you would have build with VS you could double click on state/transition and implement it in VS (at least I think it should work this way!)

Nice, good job !
I have been thinking a few days about how to implement those FSMs, and came up with a more or less similar design. The only difference I can find is that I though it was more easy to understand if you to put a transition as a child of the source node (instead of a direct child of the FSM node).
I am currently working on a built-in (C++) implementation of such module, let me know if you update your code on github, I am very interested by how you implemented the visualization part ! :)

@groud in this implementation transition can have multiple source states (but only one target one). I'm finishing it right now, will test today if there will be no problems maybe I will be able to record vid today.

also curious why you want c++ implementation? I mean, runtime is really minimal, maybe couple dozens of gdscript loc running every frame, linearly without any loops or any other heavy stuff, and people will implement more heavy stuff (like actual game logic) in gdscript anyway so...

Well it is not a matter of complexity or whatever... It is just because I believe this should be included into the godot engine itself (because it is a feature used by a lot of people), and not as a plugin. Thus it would need to be coded in C++. :)

@groud
True. Also, next step would be Behavior Trees :) and then we will be on par with Unity and Unreal if AI/Logic systems are concerned :)

@n-pigeon actually I believe all good fsm implementations for unity are a plugins :P

I believe if we will have buildin ready to use fsm functionality it should be extension for our visual scripting system (basically couple new VS nodes). There is no need to introduce two competing systems into core.

I also believe reduz was already thinking about that kind extension, but we need to get people use VS first and have real life feedback on that.

@kubecz3k
I agree with you. FSM and BT logically belong to VS. Probably new Controls will be needed for them but it would be the best if they would act as one system.

In any case as I promised I made a quick vid on how to use the plugin: https://youtu.be/n4lJXjLAHoI

I had a look to how visual scripting works and is implemented, but I hardly understand how we could combine them with either Behaviour Trees or State Machines. In terms either or visualization or implementation I find that it would be a little bit hacky to combine them. Also, this may overload the visual script editor.
The solutions I can imagine are the following:

We use a scene node-based system, as with @kubecz3k 's plugin, with a special vizualization tool when a FSM node is selected. That would be a little bit similar to the animation system.
We create two new types of scripts (like VS or GDScript), one for FSMs and one for behaviour tree, then implements a set of corresponding nodes. Both could have a different editor so that the VS editor stays simple and dedicated to its own "model". This would make sense IMO.

WDYT ?

Hey guys!
I have to make any advanced C++ project for my lecturer and I thought that I could make godot module. Any propositions for functionality? I considered FSM.

Closing in favor of #25021, as we now have built-in state machines for animation.


Not working Pjax if i use html tag

Not working Pjax if i use html tag
<object style="height: 45px;" class="data-pjax cell-fluid-school" type="image/svg+xml" data="/basic/web/assets/build/images/ic_school_white_24px.min.svg" >
Why?

Sorry, there is not enough information given here for us to be able to provide any advice. It sounds like this might be a problem with usage of this project, and not a bug in our code. If you do think this is a bug, please reopen this and provide more information, such as steps to reproduce. Thank you!


Building in Linux support

Hey I am using GitHub cli to do this so how can this run on Linux since workflows run on Linux I found a docker for Linux can implement to run this thing in Linux also if you can you can switch to a project called flutter installer
That can package on every desktop and is fully made with flutter

Hello there,

how can this run on Linux...

Inno Setup is Windows only, so is this package (might change later).

I found a docker for Linux...

If you are referring to Inno Setup docker image, I didn't try it yet, but would love to when I have some free time.

you can switch to a project called flutter installer...

This project? It is not built upon inno setup so I cannot see how it might be useful to switch to it (and appears to be unmaintained).
I have an idea, I didn't try it but worth a shot (if you can), use Windows Github action and employ a script to download Inno Setup and install it , then you can run this package to build an installer for you.

Hey, if you are still interested on how to run it as a GitHub action, checkout this demo I have created to add GitHub automation support for inno_bundle.

I already impl it thanks for your response that was pretty nonsensical issue to make. I am terribly sorry.

`  build_windows:
runs-on: windows-latest
needs: check_version
steps:
  - name: Checkout Repository
    uses: actions/checkout@v2

  - name: Set up Flutter
    uses: subosito/flutter-action@v2
    with:
      flutter-version: '3.16.8'
      cache: true

  - name: Install Dependencies
    run: flutter pub get

  - name: Set up Inno
    run: |
      Invoke-WebRequest -Uri 'https://jrsoftware.org/download.php/is.exe' -OutFile 'inno.exe'
      Start-Process -FilePath 'inno.exe' -ArgumentList '/VERYSILENT'

  - name: Set up Dart
    uses: dart-lang/setup-dart@v1

  - name: Build Windows Installer
    run: dart run inno_bundle:build --release

  - name: Upload Windows Installer Artifact
    uses: actions/upload-artifact@v2
    with:
      name: app-release-windows
      path: build/windows/x64/installer/Release/Sanji-x86_64-${{ needs.check_version.outputs.version }}-Installer.exe
      retention-days: 1`

This is way i did it could you plz mention this in the readme so people will not get lost or you can create a cmd that installs the innobundle silently if it is not installed also thanks for the package 💗

No problem mate, in fact I planned to make such automation script, just didn't have motive to prioritize it.
Thank you for sharing your script here as well. Again, here is a more complete example that works without needs: check_version, I shared it on this demo.
name: Main workflow
on:
  push:
    branches:
      - dev # <--- Put your branch of course
permissions:
  contents: write
jobs:
  windows-installer:
    runs-on: windows-latest
    steps:
      - name: Checkout Repo
        uses: actions/checkout@v3

      - name: Get Flutter
        uses: subosito/flutter-action@v2

      - name: Build Windows App
        run: |
          flutter config --enable-windows-desktop
          flutter build windows

      - name: Build iss script
        run: dart run inno_bundle:build --no-app --release --no-installer

      - name: Output config into github output
        id: envs
        # thanks to https://github.com/actions/runner/issues/2224#issuecomment-1289925992
        run: echo $(dart run inno_bundle:build --envs --no-hf) | Out-File -FilePath $Env:GITHUB_OUTPUT -Encoding utf8 -Append

      - name: Build installer
        uses<EMAIL_ADDRESS>        with:
          path: ./build/windows/x64/installer/Release/inno-script.iss

      - name: Release installer
        uses: softprops/action-gh-release@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          files: |
            ./build/windows/x64/installer/Release/${{ steps.envs.outputs.APP_NAME_CAMEL_CASE }}-x86_64-${{ steps.envs.outputs.APP_VERSION }}-Installer.exe
          name: "${{ steps.envs.outputs.APP_VERSION }}_${{ github.run_id }}"
          target_commitish: dev
          tag_name: "v${{ steps.envs.outputs.APP_VERSION }}_${{ github.run_id }}"


Display of Agencies in form not using select2

not sure why select2 does not seem to be loading. image below:

The input box should only show the agencies that have been selected. The list should appear only when the user starts typing to add an agency.

Inspecting element reveals some errors:

This looks like a CORS issue. We can mitigate by using rack-cors to specify hosts which are valid to use.

uh never mind...

What happen?


A button to clear all selections in calendar

Currently, if we need to clear the selections we've made in the calendar, we should clear them one by one
A button like Clear All Selections the would come in handy in the Create Poll page

can you please assign this issue to me?

I would like to work on this issue.Please assign me. Thanks !


Update code fetch task name

Note that we are no longer fetching the full history, but rather a subset of the history.
refs GH-148

Ignore assertion check (will fix in a follow-up PR).


Add segment replication blog

Description
Adds segment replication blog for 2.7
Issues Resolved
Fixes #1405
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@natebower Addressed all comments. This blog is not ready to be published yet because we're waiting for the latest benchmarking test results. Thanks!

@pajuric @krisfreedain I've implemented all comments and this blog should be ready to publish


Two tabs are opened in case of explaining execution plan without any resultset open

System information:

Operating system (distribution) and version win10
DBeaver version 21.0.5

Connection specification:

Database name and version PostgreSQL, Oracle, Cockroach

Steps to reproduce, if exist:

Open SQL editor and write some query (e.g. Select 1;)
Perform Explain execution plan.

Actual result
Two tabs open. First tab - Result 1 is empty, the second tab contains the execution plan.

Fixed.

verified

See #13636


Support for the Logitech G Pro Mouse (Overwatch)

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[x ] Aurora supported device, (Logitech G Pro)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[x ] Other, (I would like for this mouse to be added to Aurora)

Expected behavior:
Explain here what should happen.
I would love for you to add the Logitech G Pro to Aurora, specifically with an overwatch profile
Actual behavior:
Explain here what happened instead.
How often does this problem occur?

This problem occurs... (Fill in here)
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

What is the version of Aurora you are experiencing this issue with?

My version is... (Fill in here)
Does the previous version of Aurora have this issue?
The previous version, (Fill in the version here), did/did not have this issue.
Please include any logs, screenshots, or files that are related to this issue:

For logs, you can use: http://pastebin.com/
For screenshots, you can use: http://imgur.com/
For files, you can use: http://www.tinyupload.com/ , https://www.dropbox.com/ , or attach them to the issue.

I don't see that device listed in the Logitech LED SDK documentation so I think it might not be supported by it. In which case, there isn't much I can do to support it. If it is actually supported by the sdk you should be able to select a similar device in the options and the lighting should apply to your mouse if you set it.


When switch routers, the scroll event of the parent of router-viewer is triggered

Here is the html:
<div id="parent_view">
  <router-view></router-view>
</div>

When switch the router, the scroll event of the parent_view div is triggered. But I didn't do any scroll operation at all. Is that a bug?

I don't think so, it's probably because the height of the content has changed?

yes, the height of the content is changed. Because when switch to different router maps, they have different height. But would that trigger scroll event of parent_view?

Hello snowffer,
you are right that the scroll event should not fire from a change of height from what documention like MDN say, and as far as I can judge from experience.
could you provide a reproduction example on jsfiddle.net ?

Closing for inactivity


capture important github repos in TF

I added a handful in #33 but there are more remaining.

As @IanEdington pointed out not all these repos are important. Let's include removing the dead ones from TF in this work item as well.


Class 'ThirtybeesStripe\Source' not found

I get the error
Class 'ThirtybeesStripe\Source' not found
at line 111 in file modules/stripe/controllers/front/validation.php
I updated from 1.4.3 to 1.4.4 but that made no difference

Gotcha! I have immediately updated the module. Thanks!


Added animations and some transition effects on cards

Thank You so much for contributing!

Thank You so much for contributing!

You're welcome.😃✌


Can idock dock flexible residues as vina does?

I would like to request this vina's feature at idock. I hope this can be applie in next release. Thanks

Yes, this would be a very useful feature.


Fix movie rendering problems with Google Maps Photorealistic 3D Tiles by updating cesium-native

Depends on CesiumGS/cesium-native#686.

Thanks for the pull request @kring!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

I'm going to merge this because it only updates cesium-native to the latest main.

We forgot to add this to CHANGES.md!

Just pushed a commit to main to add the missing changelog entry, feel free to reword as needed.


Chat - Chat history disappears after creating a task

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any chat
Tap "+" button and select "Assign a task"
Enter the Title and assign it to yourself
Navigate to the chat

Expected Result:
Chat history is displayed
Actual Result:
Chat history disappears, only the task is shown after scrolling up
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.56-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/53545482-42bc-435b-8d17-fb9e821a57f5
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
Please re-state the problem that we are trying to solve in this issue.
edited message is overlapping with the next message in the chat if a quote is used
What is the root cause of that problem?
Due to this PR in BaseHTMLEngineProvider defaultViewProps now have styles.w100, styles.h100 which are causing the issue of the blockquote element specifically height 100%
What changes do you think we should make in order to solve the problem?
I think there might be more issues since this is used by the RenderHTMLSource but this is the first visible so there are two ways of solving it:

remove from defaultViewProps h100 and w100 and include it in the specific element required using webViewStyles.tagStyles
In the webViewStyles.tagStyles.blockquote element we can override height to avoid the issue.
I'm inclined to using solution #1 but it would require help from the author of the display receipts in chat to avoid any side effect in the implementation.

What alternative solutions did you explore? (Optional)

Prioritizing another distance request deploy blocker over this. This is free to take by anyone

Not able to reproduce this on web

Trying Android next

Not able to reproduce this on Android v 1.3.56-16:

Going to close this one as fixed


Added designs on the buttons

Signed-off-by: Bishal Das<EMAIL_ADDRESS>
Fixes Issue #62
This PR fixes the following issues:
closes #62
Here comes all the changes proposed through this PR
Check List (Check all the boxes which are applicable)

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Add all the screenshots which support your changes

@AnuragThePathak Now all good to go!

Cool, rest of the changes would be reviewed by someone from the dev team.

Hey, @bishal7679 can you please quickly resolve the conflicts and commit ASAP 😄?

@SuperAayush This conflicts happened due to this PR https://github.com/commclassroom/commclassroom/pull/68

@SuperAayush This conflicts happened due to this PR #68

Yes I am aware of that, #68 PR had the final changes for the homepage.
Can you please fetch the data, fix the conflicts and push the changes?

@SuperAayush This conflicts happened due to this PR #68

Yes I am aware of that, #68 PR had the final changes for the homepage. Can you please fetch the data, fix the conflicts and push the changes?

This final changes looks good! Actually I was facing some line-height issue for the Explore courses button. Now it is good to go!

@SuperAayush This conflicts happened due to this PR #68

Yes I am aware of that, #68 PR had the final changes for the homepage. Can you please fetch the data, fix the conflicts and push the changes?

This final changes looks good! Actually I was facing some line-height issue for the Explore courses button. Now it is good to go!

Conflicts are yet to be solved!!

@SuperAayush This conflicts happened due to this PR #68

Yes I am aware of that, #68 PR had the final changes for the homepage. Can you please fetch the data, fix the conflicts and push the changes?

This final changes looks good! Actually I was facing some line-height issue for the Explore courses button. Now it is good to go!

Conflicts are yet to be solved!!

@SuperAayush sure! I will push it soon!

@bishal7679 let us know if you need help in conflict resolution.

@AnuragThePathak @SuperAayush The page is not loading on localhost:3000

Maybe your site is crashing due to some errors.

Can you give the error message ? @bishal7679

@bhavyastar The page is loading with completely blank

@bhavyastar Now it is loading after run this command
npm audit fix --force

@bhavyastar @SuperAayush The previous design of the site was looking quite good but in the current one
both side the space is looking so weird and so much blank!
WDYT?
Just giving my point of view :)


submodules error

needs to modify .gitmodules file
origin url is 	url = git@github.com:shysaur/Fragaria.git
new url is url=https://github.com/shysaur/Fragaria.git

It should work fine with the git URL as well, have you added an SSH key to Github?


added a link

added a link to rooms device marketplace at Office.com using aka.ms/roomdevices

@sohailta - looks like just a small typo of 'also'  .. please fix and then will merge. Really cool link by the way. Those systems look awesome.


Celo Rewards can verify PN-type claims

Claim should be verified for the following:

PN type is mobile (or unknown?)
Identifier in claim is associated w/ the address
Issuer was elected and using this key at the time of claim creation (see parent epic for more details)


Check if app is running before installing/uninstalling

Description
The current installers don't check if the app is running when installing or uninstalling, so the main app executable gets left behind
Additional information
No response

Bumping this, tons of leftover files with the current uninstaller if it's executed while system-bridge is still running.


11th Gen Intel GPU not supported. Why?

Summary
The example program crashes/aborts with following error:
./matrix_mul_mkl
Device: Intel(R) Iris(R) Xe Graphics [0x9a49]
Problem size:  A (600x1200) * B (1200x2400)  -->  C (600x2400)
Launching oneMKL GEMM calculation...
An exception occurred: oneapi::mkl::oneapi::mkl::blas::dgemm: unsupported device: Intel(R) Iris(R) Xe Graphics [0x9a49]
make: *** [GNUmakefile:8: run] Error 1
Version
Report oneAPI Toolkit version 2023.0.0. and oneAPI Sample version downloaded 3/8/2023
Environment
OS: Ubuntu 22.04.5 LTS 64bit
Platform: Latitude 7320, 16Gb RAM, Intel i71185G7, (11th Gen) GPU Mesa Intel Xe TGL Gt2
Steps to reproduce
Move to the root directory of the example and run make.
Observed behavior
Crash
Expected behavior
Program exit gracefully and report why the GPU is not suitable not supported.
It did not crash with oneAPI 2022.x.x late last year.

The GPU offload for Ice Lake platform (GEN11 graphics) is supported. You'll need to install the legacy GPU drivers:
https://dgpu-docs.intel.com/releases_legacy/legacy-m815_20220830.html
The GPU offload for EHL platform (also GEN11 graphics) is not supported, and never was supported. It would be nice though to add a platform support matrix to these samples

(OneSmpl_Team1)
@irudkin
I have confirmed it runs well in my i5-1135G7, which use the same GPU with yours, I am on ubuntu 22.04 and oneAPI 2023.1.
Libraries/oneMKL/matrix_mul_mkl$ ./matrix_mul_mkl
Device: Intel(R) Iris(R) Xe Graphics [0x9a49]
Problem size:  A (600x1200) * B (1200x2400)  -->  C (600x2400)
Launching oneMKL GEMM calculation...
Performing reference calculation...
Results are accurate.


Fix ih_schema.sql to comply with eclipse-edc/IdentityHub#451

What this PR changes/adds
This change adds the missing key_context in keypair_resource that we introduced in https://github.com/eclipse-edc/IdentityHub/pull/451.
Why it does that
Without having this column the services start with an error and does not work as expected:
Exception in thread "main" org.eclipse.edc.spi.EdcException: org.eclipse.edc.spi.persistence.EdcPersistenceException: ERROR: column "key_context" of relation "keypair_resource" does not exist
  Position: 181
	at org.eclipse.edc.boot.system.runtime.BaseRuntime.onError(BaseRuntime.java:143)
	at org.eclipse.edc.boot.system.runtime.BaseRuntime.boot(BaseRuntime.java:106)
	at org.eclipse.edc.boot.system.runtime.BaseRuntime.main(BaseRuntime.java:77)
Caused by: org.eclipse.edc.spi.persistence.EdcPersistenceException: ERROR: column "key_context" of relation "keypair_resource" does not exist
  Position: 181
	at org.eclipse.edc.sql.SqlQueryExecutor.execute(SqlQueryExecutor.java:59)
	at org.eclipse.edc.identityhub.store.sql.keypair.SqlKeyPairResourceStore.lambda$create$0(SqlKeyPairResourceStore.java:57)

(full stack trace omitted)

Further notes
I'm not sure how such breaking changes should be propagated to downstream consumers like this sample repo. Maybe the versions of the IdentityHub (and other dependencies) should be pinned.

this is a temporary fix at best. IH and other components now come with a SqlSchemaBootstrapper that automatically creates the DB schema. Please sign the ECA so we can run, review and ultimately merge your PR

this is a temporary fix at best. IH and other components now come with a SqlSchemaBootstrapper that automatically creates the DB schema. Please sign the ECA so we can run, review and ultimately merge your PR

Thanks for your clarifications. I just signed the ECA.


ci: use previous commit for linting on main

Updates lint workflow to use commit prior to push when merging to main. Previously the step would fail because $GITHUB_BASE_REF is empty.
See https://docs.github.com/en/webhooks/webhook-events-and-payloads#push:~:text=or null Required-,before,-string Required for more information.
Fixes golioth/firmware-issue-tracker#248

Awesome, thanks Dan! We had a ticket for this, I assigned it to you for bookkeeping 👍


Auto Add List Items

VSCode Version: Version 1.6.1 (1.6.1)
OS Version: 10.12

Feature Request
When working in markdown files, it'd be great if after I start a list, each time I hit enter it would add another list item. That'd make working with Markdown much more efficient.
Hitting enter twice would then break out of the list.

Probably could be done by an extension

does any one known any extension? I came accross the same problem.

The extension "Markdown all in one" implements this https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one

Closing as extension candidate


Need a way to reference file paths relative to the config file

Summary of the new feature / enhancement
A winget configure scenario is that a git repo has a config.dsc.yaml which uses a resource that uses a file within the repo.  Ask is to have a built-in variable similar to $PSScriptRoot like $DSCConfigRoot that contains the path to the config file.
Proposed technical implementation details (optional)
No response

WG discussed this and proposes a new env var created by dsc.exe called DSCConfigRoot which contains the directory of the currently executing config file.  The PowerShell group resource (and any other language group resource) would need to know to expand this before passing to resources:
$schema: https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/2023/08/config/document.json
resources:
- name: Use class PowerShell resources
  type: DSC/PowerShellGroup
  properties:
    resources:
    - name: foo
      type: PsDesiredStateConfiguration/MSFT_File
      properties:
        Path: $env:DSCConfigRoot/bar/baz


Tencent video playlist extraction problem

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
Tencent video playlist can only extract up to 60 videos
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
C:\Users\Administrator>yt-dlp -F -vU https://v.qq.com/x/cover/w1ppt1vtbxcilgv.html
[debug] Command-line config: ['-F', '-vU', 'https://v.qq.com/x/cover/w1ppt1vtbxcilgv.html']
[debug] Portable config "E:\Tencent\Mplayer\yt-dlp.conf": ['--output', 'E:\\Tencent\\N_m3u8DL-CLI\\Downloads\\%(title)s-%(section_number)s-%(section_title)s.%(ext)s', '--console-title', '--progress-template', 'download-title:%(info.id)s-%(progress.eta)s', '--merge-output-format', 'mp4', '--no-write-subs', '--external-downloader', 'aria2c', '--cookies-from-browser', 'edge', '--embed-thumbnail', '--embed-metadata']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (win_exe)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.19044-SP0 (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg 2023-05-15-git-2953ebe7b6-full_build-www.gyan.dev (setts), ffprobe 2023-05-15-git-2953ebe7b6-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-11.0.2
[Cookies] Extracting cookies from edge
[debug] Extracting cookies from: "C:\Users\Administrator\AppData\Local\Microsoft\Edge\User Data\Default\Network\Cookies"
[debug] Found local state file at "C:\Users\Administrator\AppData\Local\Microsoft\Edge\User Data\Local State"
[Cookies] Extracted 728 cookies from edge
[debug] cookie version breakdown: {'v10': 728, 'other': 0, 'unencrypted': 0}
[debug] Proxy map: {}
[debug] Loaded 1813 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 437306c40d6ce00244ddf1588202929c701e333dfe6f7f0262124d2c8d28a176
yt-dlp is up to date<EMAIL_ADDRESS>[vqq:series] Extracting URL: https://v.qq.com/x/cover/w1ppt1vtbxcilgv.html
[vqq:series] w1ppt1vtbxcilgv: Downloading webpage
WARNING: [vqq:series] w1ppt1vtbxcilgv: Failed to parse JSON: Expecting ',' delimiter in 'lice.call"({"0":[{"c': line 1 column 10466 (char 10465)
[download] Downloading playlist: 蜡笔小新 第6季
[vqq:series] Playlist 蜡笔小新 第6季: Downloading 60 items of 60
[download] Downloading item 1 of 60
[vqq:video] Extracting URL: https://v.qq.com/x/cover/w1ppt1vtbxcilgv/o0024gd0w91.html
[vqq:video] o0024gd0w91: Downloading webpage
WARNING: [vqq:video] o0024gd0w91: Failed to parse JSON: Expecting ',' delimiter in 'lice.call"({"0":[{"c': line 1 column 11233 (char 11232)

I also encountered the same problem


contact form delete button not working

maybe double modal now working.

please reopen the ticket an follow the issue template


Add Redis instrumentation to example app

Which problem is this PR solving?

closes #106

Short description of the changes

[x] uses local dependency
[x] adds redis auto-instrumentation
[x] creates at least one manual span
[x] has a curl-able endpoint

How do I know it works?
Steps to run the app:

Add API key to appsettings.json in the examples/aspnetcore directory.
Install and start Redis
uncomment the line in WeatherForecastController.cs to enable the db ping
dotnet run
navigate to localhost:5001/weatherforecast

Looks good. I've left feedback around the optional redis config options.
How about we say this example expects to use a local redis instance and leave all the redis config as enabled?

I agree. I'm actually going to separate this into a new example app, so there is still a ready-made example that doesn't require redis.


Documentation or More Example to Use XLRSCRIPT

can I get more complete documentation, or examples for using the function from XLRSCRIPT?
Thank you.

Hi Aris,
All the documentation currently available is in the spreadsheet below:
xlRcode/xlRcode - Main.xlsx
You will note that there is a tab for each function, including one for XLRSCRIPT.
This function runs the commands written in a R script file and allows the user to transfer values from and to Excel. The first parameter is a string with the path to the R script file. The next parameters are optional and they represent the variables you may want to pass to the script code before running it. They are stated in pairs, where the first parameter is a string that stands for the name of the variable to be created, and the second parameter is its value. After running the code, the function XLRSCRIPT returns the result of the last line of the script. Say you want to return the value of a variable called XXX, then you should write XXX in the last line of your script.
So far, the examples available are the ones in the folder "Examples" of this repository.
I hope this clarifies.
Best,
Eduardo

thanks for the response given...
I have read the documentation/examples provided. but I'm still having a hard time understanding
Can I get more varied case examples? focus on educational statistics?

What's exactly your doubt?
If you write =XLRCODE("1+1") in a cell and it returns 2, then XLRCODE should be running ok in your machine.
The example below
=XLRCODE("a+b", "a", 1, "b", 2)     should return 3
Note that I passed two variables (a and b) and gave them the values 1 and 2, respectively.
XLRSCRIPT follows the same logic.


User/group problem

Reported by an end-user : whenever he tries to select a group/period to add the user into, the selection never appears. The same issue occurs in the group view, when he tries to select the user/period.

Update from the user as of 07/10 : he managed to workarround this by entering the first few letters, hence allowing the selection.

Fixed by #236


Switch between browser tabs

Is it possible to switch between browser tabs? I tried using SwitchWindow and does not seem to work. I also used WindowCount to validate that the new tab is being recognized as a window but does not seem like it since it is returning 1 instead of 2 which is the number of tabs at the time.

Are you sure that you've successfully opened the new tab? WindowCount should pick up new tabs. What webdriver / browser are you using?

Yes, the tab was successfully opened but the WindowCount returns only one window.


V caxian patch 1

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

CSIDevDocsPublic/auto-check.md
:white_check_mark:Succeeded

CSIDevDocsPublic/auto-merge.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

PRMerger Results

Issue
Description

Added or Deleted File(s)
This PR contains added or deleted file(s).

File Change Percent
This PR contains file(s) with more than 20% file change.


generator doesn't work in Photoshop 2018 on mac

I just want to duplicate adobe topic to be sure it's investigate from both sides - Photoshop and generator core. In some environments savepixmap couses following error: Error with convert's STDIN: Error: write EPIPE. So it's impossible to save any bitmaps.
Here's discussion thread on Adobe support forum: https://forums.adobe.com/message/9941050.

Thanks @GDreyV , I'm aware of that support forum thread.  So far no one here can repro the issue.  I know you're an expert, so any help is appreciated.


Tc sig env merging

Hello,
This resolves the problem that was detected in #10.
I first removed the workaround where a signature file depends on all the signature files that came before it. Surprisingly, I didn't break any unit tests by doing that. This is something to pay closer attention to in the future.
Next, I've added my failing test case. Then I updated the merge code and my test case worked.
From now on I hope to inspire you to do every next change test driven. This would be a good preparation for the eventual draft PR.
Two more pointers I do want to mention:

Can we start always formatting the code? Because you didn't do this, I'm not able to do it either because it would make a PR diff larger than necessary. (See ancient greek tragedy)
Please consider abandoning the separate ParallelTypeCheckingTests.fsproj project. Your eventual PR will not be merged in using that. It is best to move the bits to the right projects instead.

Can we start always formatting the code? Because you didn't do this, I'm not able to do it either because it would make a PR diff larger than necessary. (See ancient greek tragedy)

Thanks, I've run Fantomas on src/ and the test project now.
This caused some conflicts on this PR, I'll look into resolving them.

I merged a copy of this PR as I didn't have write access to your fork.
Thanks for help 👍

As noted in https://github.com/safesparrow/fsharp/issues/15 , the changes in this PR do break FCS type-checking, so we need to keep looking.


Pr365

PR description
Fixed Issue(s)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 14 committers have signed the CLA.:white_check_mark: edwardmack:x: shemnon:x: RatanRSur:x: MadelineMurray:x: abdelhamidbakhta:x: EdJoJob:x: pinges:x: usmansaleem:x: macfarla:x: atoulme:x: rolfyone:x: matkt:x: faraggi:x: joshuafernandesYou have signed the CLA already but the status is still pending? Let us recheck it.

Merged in Hyplerledger/Besu

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: edwardmack:x: shemnonYou have signed the CLA already but the status is still pending? Let us recheck it.


Create docker-stack.yml

Create a Stack config for running with portainer - may be it helps others, also add 2 viewer for debugging.

Hi @hipposen
Thanks for your pull request.
Could you add the section to README.md on how to deploy into the portainer with docker swarm?
That will help others.

Updated the readme

Thanks @hipposen
I will merge in.


SgfcMessageParser should be more flexible

Example:
Line:35
Line: 35
Line :35
Line : 35

should all work. The first step would probably be a better tokenizer.

SgfcMessageParser has been removed, the new SGFC version (see #31) makes message data available without parsing.


fix: add react client directive

Adds React use client directive to make React package compatible with React server components.
Fixes #21

Thanks can you add a changeset?


error: exportArchive: The operation couldn’t be completed. (IDEDistributionErrorDomain error 3.)

Bitrise Build Issue Report template
Description of the issue
Configured everything for an app-store release build (I first struggled with the certificate an provisioning profile, I was forgetting the wildcard one). Once I finally was able to build, I got an error when exporting the ipa from the archive.
Environment:
It happens on the Xcode 8.0.x, on OS X 10.11 (El Capitan) stack during the xcode-archive step.
The step is at the current last version: 2.0.1
Reproducibility
I was never able to build a release/app-store build, this was the first time I tried and configured it. So for me the issue started once I succeed building and archiving the project.
Right now, I just need to start a new build, or hit the "Rebuild" button, to have the error.
Build log
Relevant parts:
+------------------------------------------------------------------------------+
| (6<EMAIL_ADDRESS>                                                    |
+------------------------------------------------------------------------------+
| id: xcode-archive                                                            |
| version: 2.0.1                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2016-11-18T09:19:02-08:00                                              |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[09:19:02]  * [OK] Step dependency (xcode) installed, available.
INFO[09:19:02]  * [OK] Step dependency (go) installed, available.

ipa export configs:
- ExportMethod: app-store
- UploadBitcode: yes
- CompileBitcode: yes
- TeamID:
- UseDeprecatedExport: no
- ForceTeamID:
- ForceProvisioningProfileSpecifier:
- ForceProvisioningProfile:
- ForceCodeSignIdentity:
- CustomExportOptionsPlistContent:

...

step determined configs:
- xcodebuildVersion: 8.0.0 (8A218a)
- xcprettyVersion: 0.2.2
- projectAction: -workspace

...

▸ Archive Succeeded

Exporting ipa from the archive...

Using export options
Generating export options
using export-method input: app-store
generated export options content:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
	<dict>
		<key>method</key>
		<string>app-store</string>
	</dict>
</plist> <nil>

[09:27:39] set -o pipefail && xcodebuild "-exportArchive" "-archivePath" "/var/folders/90/5stft2v13fb_m_gv3c8x9nwc0000gn/T/__archive__339792222/REDACTED.xcarchive" "-exportPath" "/var/folders/90/5stft2v13fb_m_gv3c8x9nwc0000gn/T/__export__303920421" "-exportOptionsPlist" "/Users/vagrant/deploy/export_options.plist" | xcpretty

❌  error: exportArchive: The operation couldn’t be completed. (IDEDistributionErrorDomain error 3.)

If you can't find the reason of the error in the log, please check the raw-xcodebuild-output.log
The log file is stored in \$BITRISE_DEPLOY_DIR, and its full path
is available in the \$BITRISE_XCODE_RAW_RESULT_TEXT_PATH environment variable
Export failed, error: %!s(<nil>)

...

+------------------------------------------------------------------------------+
|                               bitrise summary                                |
+---+---------------------------------------------------------------+----------+
|   | title                                                         | time (s) |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                      | 2.12 sec |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                             | 8.61 sec |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                     | 5.80 sec |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                     | 106 sec  |
+---+---------------------------------------------------------------+----------+
| ✓ | Build number                                                  | 2.72 sec |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                | 2.71 sec |
+---+---------------------------------------------------------------+----------+
| x |<EMAIL_ADDRESS>(exit code: 1)                            | 523 sec  |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-new-xcode-archive/issues  |
| Source: https://github.com/bitrise-io/steps-new-xcode-archive                |
+---+---------------------------------------------------------------+----------+
| ✓ |<EMAIL_ADDRESS>                                                 | 4.67 sec |
+---+---------------------------------------------------------------+----------+
| - |<EMAIL_ADDRESS>                       | 1.32 sec |
+---+---------------------------------------------------------------+----------+
| Total runtime: 11.0 min                                                      |
+------------------------------------------------------------------------------+

Can you please add the Deploy to Bitrise.io step to your workflow, e.g. right before the deploy-to-itunesconnect-deliver step?
That will attach additional debug log files to the build, like the raw-xcodebuild-output.log one which is mentioned in the build log.
Once you add the step, run a new build and attach / send us these debug log files (will be in the Apps & Artifacts section of the build page)

Here are the Xcodebuild output log
raw-xcodebuild-output.log.zip

The relevant parts of the log:
"Error Domain=IDECodesignResolverErrorDomain Code=2 \"No matching provisioning profiles found\" UserInfo={NSLocalizedRecoverySuggestion=No provisioning profiles matching an applicable signing identity were found., NSLocalizedDescription=No matching provisioning profiles found, IDECodesignResolverError_ResolutionInputsKey=<IDECodesignResolutionInputs: 0x7f9ceaa67930; portalTeamID='REDACTED', usingTeamBasedSigning='NO', bundleIdentifier='REDACTED', targetName='(null)', provisioningProfilePurpose='1', requiresProvisioningProfile='YES', provisioningProfilePlatform='iOS', certificateKind='1.2.840.1136<IP_ADDRESS>.4', requiredEntitlements='{\n    \"aps-environment\" = development;\n    \"beta-reports-active\" = 1;\n    \"keychain-access-groups\" =     (\n        \"REDACTED.REDACTED\"\n    );\n}', requiredCodesignableDevices='(null)', requiredFeatures='(null)'>\n}"

The most frequent cause of this issue are:

you did not upload the provisioning profile (from the logs it seems you did)
the provisioning profile is outdated - please download the latest version from Apple Developer Portal, and upload that to bitrise.io
you missed to enable a required entitlement in the distribution provisioning profile - you can enable entitlements on the Apple Developer Portal, and once updated, download the prov profile and upload it to bitrise.io

Also, did you use codesigndoc to export the files? If you did, please make sure that you can export a fully signed IPA from Xcode.app first, and run codesigndoc after that, as Xcode.app might update the local prov profiles during the export process, if required.

Ok, so:

I have uploaded the provisioning profile
This is the last one, It was generated by Xcode (I don't have any to download from the Apple Developer Portal)
I've checked again, all my entitlements are enabled on my distribution provisioning profile

Also I've checked, the file uploaded on bitrise are the same the codesigndoc tool provided me. Except for the wildcard one, I had to export the certificate myself.
I can confirme I can export a fully signed IPA from Xcode since I finally uploaded my binary to Apple via Xcode, since I wasn't able to export from Bitrise

Can you please try to:

delete all signing files from bitrise.io
then run codesigndoc again
upload the files it generates (all the files) to bitrise.io
and run a new build

Ok, but what do I do for the wildcard ? because codesigndoc doesn't export it.

Can you upload that manually - but can you please create an issue on codesigndoc's github (https://github.com/bitrise-tools/codesigndoc) with the log it generates? It should definitely pick up the file, unless your Xcode project settings specify another code signing file.
Actually, it could be even better if you could first do a clean git clone, into a new directory on your mac, and run codesigndoc there - that way you can be certain that the Xcode project config is the same as what bitrise will get, and there are no uncommitted changes / gitignored files

Ok, it worked...
I've checked the file again, it seems the only difference was the missing provisioning profile generated by Xcode for distribution, the one labeled: "XC iOS: app.bundle.id".
Seems to work fine now.
Thank you!

Indeed, a single .p12 can include multiple Identities, so for simplicity codesigndoc exports all in a single .p12.
Just to be sure: so, you didn't have to do anything else, just run codesigndoc and upload all the files it exported, right?

Yes.
The first time I didn't uploaded the "XC iOS" provisioning profile, thinking it was just here because it was matching the bundle id and also was on my computer. But this time I uploaded everything (include this one) and everything worked.

Got it, thank you for the info @StrAbZ , and Happy Building! :)


[ENHANCEMENT] TypeParameters(Matrix{Float64})[eltype] === Float64

An idea for simplifying the implementation could be to have a wrapper type TypeParameters(T::Type) = TypeParameters{T}() that you can index into to get the type parameters, i.e.:
TypeParameters(Matrix{Float64})[:] === (Float64, 2)
TypeParameters(Matrix{Float64})[1] === Float64
TypeParameters(Matrix{Float64})[eltype] === Float64
TypeParameters(Matrix{Float64})[(ndims, eltype)] === (2, Float64)

It may not be all that helpful since it could just make it harder for type inference and I'm not sure how much it will help the implementation, but I think it is interesting as a thought experiment.
I think a lot of concepts can map to the TypeParameters wrapper, i.e. defaults can be based around get:
get(TypeParameters(Matrix{Float32}), eltype) === Float32
# Use default value
get(TypeParameters(Matrix), eltype) === Float64
get(TypeParameters(Matrix), eltype, Float32) === Float32
# Determine if a type is specified or not
get(TypeParameters(Matrix), eltype, nothing) === nothing

I'm not really sure setting/specifying parameters really fits this interface though, since setindex(TypeParameters(Matrix{Float32}), Float64, eltype) doesn't make much sense. Part of the motivation could be to try to decrease the number of functions in the interface of the package, which is a lot at this point.

In analogy to the set/@set interface of Accessors.jl, we can think of TypeParameters as defining a lens, i.e. it could maybe even be implemented as something like:
lens = @optic TypeParameters(_) # Obviously this is just a sketch to present the idea
lens(Matrix{Float32}) === (Float32, 2)
set(Matrix{Float32}, lens[eltype], Float64) === Matrix{Float64}`

Again, I'm not sure if it is worth it, but I think it is an interesting perspective and I like the idea of thinking through how the functionality of this package could be implemented through more general concepts and with fewer functions.


soc: npcx: add soc drivers for npcx9 series.

This PR introduces the soc driver of npcx9 series. It includes:

Move common source files for all npcx series such as power policy, checking register structures, and so on to "nuvoton_npcx/common" folder.
Add npcx9 soc drivers and introduce two chips, npcx9m6f and npcx9m3f.
Modify adc, clock control, and miwu drivers to support npcx9 series.

Signed-off-by: Mulin Chao<EMAIL_ADDRESS>

After rebasing, the build error has been resolved. Any further comment is appreciated.


Parallelize tests

Some of the methods are embarrassingly parallel, e.g. statsmodels, wilcoxon test.
I suggest to use the following snippet from scirpy:

using joblib it is more robust than multiprocessing
joblib natively supports the dask backend, so you get out-of-machine support for free.

https://github.com/scverse/scirpy/blob/443e59e6245b917e87972f87df350ae4f429d011/src/scirpy/util/__init__.py#L567-L579
def _parallelize_with_joblib(delayed_objects, *, total=None, **kwargs):
    """Wrapper around joblib.Parallel that shows a progressbar if the backend supports it.

    Progressbar solution from https://stackoverflow.com/a/76726101/2340703
    """
    try:
        return tqdm(Parallel(return_as="generator", **kwargs)(delayed_objects), total=total)
    except ValueError:
        logging.info(
            "Backend doesn't support return_as='generator'. No progress bar will be shown. "
            "Consider setting verbosity in joblib.parallel_config"
        )
        return Parallel(return_as="list", **kwargs)(delayed_objects)

https://github.com/scverse/scirpy/blob/443e59e6245b917e87972f87df350ae4f429d011/src/scirpy/ir_dist/metrics.py#L231-L233
block_results = _parallelize_with_joblib(
         (joblib.delayed(self._compute_block)(*block) for block in blocks), total=len(blocks), n_jobs=self.n_jobs
)

Migrated to https://github.com/theislab/pertpy/issues/613


Aria-Control-Add ->  Added the aria control attr to the date input

resolved with https://github.com/Availity/react-dates/pull/15


Odd "createwallet" behaviour

The createwallet option of the peerplays CLI has a unintuitive behaviour captured below: Executing the peerplays createwallet` command to create a wallet:
$ peerplays createwallet
Wallet Passphrase:
Repeat for confirmation:
$

Suppose I used a passphrase of "something123".
Now rerunning the same command and giving the password as "something123" does not throw any error. This could cause confusion as to whether a wallet was created in the first place as attempting to create another wallet should've thrown the WalletExists exception.
However rerunning the same command and providing the passphrase as "somethingelse" this time throws me a WrongMasterPasswordException which proves that something was actually done when I first ran the createwallet option.
Next, say I run a peerplays addkey command. This time, the output is as follows:
No wallet installed yet. Creating ...
Wallet Encryption Passphrase:

Note how it says wallet not installed. However, providing any other passphrase other than "something123" throws a WrongMasterPasswordException.
Suppose I give the passphrase as "something123", it proceeds normally on to ask me to enter a Private WIF key as follows,
Private Key (wif) [Enter to quit]:

Now if I simply press Enter and quit and rerun the addkey command once again, the same thing as above happens i.e. it still tells me "No wallet installed yet". This time however, if I do actually add a WIF key and then quit by hitting Enter, then running the addkey command later gives me the following prompt:
Current Wallet Passphrase:

Also, now, running the createwallet command and providing the passphrase as "something123" no longer exits well but throws me a WalletExists exception.

The createwallet has been noticed to create a file at ~/.local/share/peerplays/peerplays.sqlite. Once we give the password "something123", it's encrypted version has also been noted to be stored in the sqlite file. However, after the first run, the file was not noticed to be read again despite running other peerplays commands. This was found out by running ls -l --time=atime ~/.local/share/peerplays/peerplays.sqlite for getting the last read time of the file.


error

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\plugins\ipythonconsole.py", line 890, in set_current_client_working_directory
shellwidget.set_cwd(directory)
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\widgets\ipythonconsole\shell.py", line 111, in set_cwd
self.silent_execute(code)
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\widgets\ipythonconsole\shell.py", line 273, in silent_execute
self.kernel_client.execute(to_text_string(code), silent=True)
AttributeError: 'NoneType' object has no attribute 'execute'
Traceback (most recent call last):
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\plugins\projects.py", line 233, in _create_project
self.open_project(path=path)
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\plugins\projects.py", line 269, in open_project
self.restart_consoles()
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\plugins\projects.py", line 386, in restart_consoles
self.main.ipyconsole.restart()
File "D:\coding\WinPython-64bit-<IP_ADDRESS>Qt5\python-3.5.4.amd64\lib\site-packages\spyder\plugins\ipythonconsole.py"

Please describe step by step how you got this error so we can reproduce it in our side. If you fail to do that, we'll close this issue in a week from now.
Also, please read our
https://github.com/spyder-ide/spyder/wiki/Troubleshooting-Guide-and-FAQ
to see if you are able to fix this problem by following it.

Closed due to lack of response. If you can provide more information, please re-open and do so. Thanks.


Add GH workflow to build and release on PyPI (WIP)

Fixes #1550
This PR adds a workflow with two jobs to build and release on PyPI. The release job waits for the build job and uses a custom release environment, which can be configured to require review.
To share the build artifacts between the jobs and to make them available for intermediate review, we use actions/upload-artifact (in build) and actions/download-artifact (in release) (also see GitHub docs).
To upload the build artifacts to PyPI, we use pypa/gh-action-pypi-publish as recommend by PyPA.
A demo is available in my fork.
Caveat
The URL to grab the build artifacts created in a workflow run requires knowledge of the corresponding action ID and artifact ID, plus a login token (w/o special permissions). This makes it a bit cumbersome to fetch the artifacts with a script in order to compare them to a local build. It might be easier to instruct reviewer to download the artifacts manually using the GitHub UI, and tailor the local verification script  accordingly.
TODO

Change repository_url to release on PyPI instead of Test PyPI and update the token
Require successful CI run for a pushed tag to trigger the workflow, instead of just a push (see workflow_run docs)
Integrate workflow with local verification (see caveat above)
Add "Release on GitHub" job to workflow
Note, this could be akin to and in parallel with the "release-on-pypi" job, waiting for the same review approval, and uploading the same build artifacts as release assets. Alternatively, we could create the release as part of the build job and upload the build artifacts as release assets right away, bypassing the download/upload caveat from above. It would be nice if we could set the release as draft at first, but that has the same caveat, i.e. it requires a token and special knowledge to download the assets.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.312%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1179

Relevant Lines:
1195

💛  - Coveralls

Re "Release on GitHub":
Unfortunately, the GitHub-native action/create-release is unmaintained. But there is a third-party softprops/action-gh-release, which seems popular. If we use that we'd have to make an exception in our "only allow actions created by GitHub"-policy.

The URL to grab the build artifacts created in a workflow run requires knowledge of the corresponding action ID and artifact ID, plus a login token

:open_mouth: wow. They really are making artifacts hidden from unauthenticated users, how disappointing of GitHub. This limits the number of people able to download the artifacts to a mere 70 million accounts: a security improvement indeed :roll_eyes:
This was so close to Just Working but then... not quite.
So, assuming we do want to integrate the GitHub release process and also want to have the local verification as automatic as possible, a potential solution for both is:

add code to do the GH release (either using a 3rd party action or just adding the code, it doesn't look horribly bad for our simple case, 1 call to create release, 1 call for each asset)
do the GH release during the "build" job (as in before the maintainer deploy permission), but name the release like "1.1.0-rc" or something
now verify_release would be able to check that release matches a local build
after maintainer approval, the "deploy" job would take the release artifacts and push them to pypi. GH release can be renamed to "1.1.0"

It's definitely more work than I expected but maybe doable?

I think using the pypa/gh-action-pypi-publish action seems fine... but also after looking at it, it literally just calls twine check and twine upload and that's it.

release environment, which can be configured to require review.

To clarify, this means configured in GitHub project/environment settings, not in the workflow?
Are we defining that all maintainers can deploy? I think this might be fine: Current pypi.org project maintainers is a subset of all maintainers but that makes sense as you can upload anything with pypi.org access. With deploy permission you can only release from git sources...

😮 wow. They really are making artifacts hidden from unauthenticated users, how disappointing of GitHub. This limits the number of people able to download the artifacts to a mere 70 million accounts: a security improvement indeed 🙄

Yep, others too have expressed their doubt about the security benefit of this restriction.

This was so close to Just Working but then... not quite.

Yep, I was really excited when I discovered the download/upload feature... and then quickly somewhat disappointed.

So, assuming we do want to integrate the GitHub release into the process and also want to have the local verification as automatic as possible, a potential solution for both is:
[...]

Thanks for thinking this through with me! That's one of the approaches I had in mind. I'll explore in that direction then.

I think using the pypa/gh-action-pypi-publish action seems fine... but also it literally just calls twine check and twine upload and that's it. We could do the same manually (and this would allow running twine check in the build phase instead of failing in deploy)

Right, I forgot to mention that this is a 3rd-party action too. I was less worried since it seems endorsed by the pypa. But yeah, if it just calls twine, we might as call it ourselves.
I'll prepare a POC using pypa/gh-action-pypi-publish and softprops/action-gh-release, and in a next iteration will try to replace them with custom code.

release environment, which can be configured to require review.

To clarify, this means configured in GitHub project/environment settings, not in the workflow?

Yes!  Environments and protection rules like "requires review" are configured in the GitHub repo settings (see GH docs).

Are we defining that all maintainers can deploy? I think this might be fine: Current pypi.org project maintainers is a subset of all maintainers but that makes sense as you can upload anything with pypi.org access. With deploy permission you can only release from git sources...

I haven't thought this far. I probably would have started with requiring a review from one of the maintainers who currently also has pypi.org access. I am not sure if the git sources constraint is a good argument for broadening the subset, because git sources can be anything.

One more thing (that is probably future work as well): is signing the release still relevant?
I'm not sure if anyone uses our signatures for anything... but we could:

have a signing key in an environment secret and sign with gpg or
do what the cool kids are doing:  https://blog.chainguard.dev/zero-friction-keyless-signing-with-github-actions/

One more thing (that is probably future work as well): is signing the release still relevant?
I'm not sure if anyone uses our signatures for anything... but we could:

have a signing key in an environment secret and sign with gpg or
do what the cool kids are doing:  https://blog.chainguard.dev/zero-friction-keyless-signing-with-github-actions/

I'm in favor of the latter, GPG isn't relevant for PyPI anymore, and IIUC this is also the right direction towards generating in-toto attestations for our supply chain (I really need to catch up on the latest in-toto/sigstore developments).

Even more future improvements (there's a lot of details in this one PR/discussion, no need to fix everything in one go):
For standard auditability reasons, the build log should include the hashes (and/or signatures ) of the artifacts.


Use this library in React project

Hi, how can I use this library in my React Project?

You can customize a component and instantiate SmilesDrawer.SvgDrawer() in useEffect()

Issues while running in Reactjs:
TypeError: Cannot read properties of null (reading 'determineDimensions')
at SvgDrawer.draw (SvgDrawer.js:67:1)
at Drawer.draw (Drawer.js:47:1)
at SmileDrawer.js:14:1
at SmilesDrawer.parse (app.js:80:1)
at SmileDrawerContainer (SmileDrawer.js:12:1)
at renderWithHooks (react-dom.development.js:16305:1)
at updateFunctionComponent (react-dom.development.js:19588:1)
at beginWork (react-dom.development.js:21601:1)
at beginWork$1 (react-dom.development.js:27426:1)
at performUnitOfWork (react-dom.development.js:26557:1)

Issue in referencing the canvas

anyone get this to work in svelte?

Here's a component I created that works with similes-drawer.
import React, { useRef, useEffect } from "react";
import SmilesDrawer from "smiles-drawer";

const SETTINGS = {
  width: 800,
  height: 400,
};

const SmileDrawerContainer = ({ smilesStr }: { smilesStr: string }) => {
  if (USE_SVG) {
    // SVG version (versions: <=2.0.3 and 2.1.7)
    const svgRef = useRef<SVGElement>(null);

    let drawer = new SmilesDrawer.SvgDrawer(SETTINGS);

    useEffect(() => {
      SmilesDrawer.parse(smilesStr, function (tree: any) {
        drawer.draw(tree, "structure-svg", "light");
      });
    }, []);

    return (

        <svg id="structure-svg"></svg>

    );
  } else {
    // Canvas version (versions: <=2.0.3 only)
    const canvasRef = useRef<HTMLCanvasElement>(null);

    let drawer = new SmilesDrawer.Drawer(SETTINGS);

    useEffect(() => {
      SmilesDrawer.parse(smilesStr, function (tree: any) {
        drawer.draw(tree, "structure-canvas", "light");
      });
    }, []);

    return (

        <canvas
          className="relative"
          id="structure-canvas"
          ref={canvasRef}
          width={"800px"}
          height={"400px"}
        />

    );
  }
};

export default SmileDrawerContainer;


Make self-signed certificates work for development

If the connected Magento (1.9 in our case) shop uses a self-signed certificate, e.g. in development environment, the API will drop the error message Error occured: Error: self signed certificate and won’t be able to connect to your Magento instance using e.g. DivanteLtd/magento1-vsbridge and DivanteLtd/magento1-vsbridge-client.
To prevent this behavior and make a dev environment work, you can disable TLS rejection using an env variable called NODE_TLS_REJECT_UNAUTHORIZED.
In our case we added it to our docker-compose file like:
…
services:
  vsf-api-app:
    image: divante/vue-storefront-api
    …
    environment:
      NODE_TLS_REJECT_UNAUTHORIZED: 0
    …

!!! Of course, this shouldn't be used in a production environment.

Although adding that env variable will make it work, it's unsafe to use it. A preferable way to solve it would be creating a shared directory for storing self-signed certs and using syswide-cas to load them into the application runtime.

Yes, indeed. It's definitly a work around for the develop environment or e.g. test runs during continuos integration only and clearly not meant to be used in production. The idea with a shared folder surely would work but is quiet a lot of configuration for developing or testing. I'm not sure whats the better way or at least how to mark it as dev-only setting.
I just stumbled about this issue during testing and found this quiet painless solution that I thought would be good to know for everybody elses first steps with this system.

I would argue that it's lots of configuration. Maybe it's a little bit more development to set it up but later the only configuration you need to do is to dump your self signed certificates to the 'certs' directory or whatever it will be called.
Regarding your solution: it's a workaround for a local dev environment which of course might be helpful for other devs facing this problem but as I mentioned above, we cannot merge it because of security reasons.

@cewald I've prepared a PR featuring syswide-cas approach. Feel free to test it and share your opinion :slightly_smiling_face: