Naming convention for Maintenance branches and branch protection rule for them

Problem description

Do we have already a naming convention for maintenance branches to enable patch release after the M4 release of a working group and/or API repository? The Guideline is currently only saying "the patched public API version x.y.z+1 shall be created through a maintenance release on a separate branch referred to as a maintenance branch"
In addition we need an additional branch protection rule in all repositories which will protect the maintenance branches like the main branch.
Possible evolution

A naming convention for maintenance branches is defined and added to https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API_Release_Guidelines.md.
A branch protection rule which covers these branch names  is rolled out across all repositories.
Proposal:
maintenance-rx, created based on the release tag rx.n+1 (the M4 release) within the main branch. The first patch release on the maintenance-rx branch is then rx.n+2.
Exceptions for Commonalities and ICM within Fall24 Meta-Release: maintenance-r0.4 respective maintenance-r0.2 (but only for Fall24, proposal is that they follow in next release cycles also the rx.n format. Issue for that to be created).
Proposal for the branch protection rule is to extend the pattern for the current rule from main to main* which has the advantage that no new rule has to be created and for new repositories still only one rule need to created.  That would protect all branches which start with "main" - which shouldn't be a problem as branches for PR development should be in forks of the upstream repository not in the repository itself.
Alternative solution

Additional context

https://github.com/camaraproject/IdentityAndConsentManagement/pull/196 is waiting for a decision on this issue.

In the Confluence https://wiki.camaraproject.org/display/CAM/API+Release+Process > Maintain a public release > PATCH update we have "the branch name shall be  maintenance-rx.y where rx.y is the release number of the public release rx.y being patched"
The branch naming is not explicitly stated in the GitHub version of the API release process, so this would need an updata

"the branch name shall be maintenance-rx.y where rx.y is the release number of the public release rx.y being patched"

A patch release is also a public (or in GitHub language a "latest"), right?
That would imply that for each patch release there will be a new maintenance branch, not necessarily a problem, as we don't expect many patch releases between the release cycles (not sure about this ...).
But another point is for me that there will be potential confusion as such branch "maintenance-rx.y" could be understood that it is there to develop the release rx.y.
For the two reason I'm still in favour of my proposal with "maintenance-rx", one branch per metarelease which will be used to maintain the meta-release.
BTW: how we want to deal with the situation of patch releases of rx if there is already the next public release rx+1.n as "latest". It wouldn't make sense to declare a rx.p as a "pre-release" to avoid to overwrite the rx+1.n. But that seems to be mainly a GitHub UI problem.

It's not 100% clear to me what a working group should do with the maintenance branch, I think at some point the changes applied to that branch should be merged into the main branch as well, to be included in the next meta-release as well. Right?
Normally, maintenance branches would contain fixes that we would most likely want to merge into the next releases as well...

It's not 100% clear to me what a working group should do with the maintenance branch, I think at some point the changes applied to that branch should be merged into the main branch as well, to be included in the next meta-release as well. Right?
Normally, maintenance branches would contain fixes that we would most likely want to merge into the next releases as well...

The maintenance branch allows to create patch releases of previous released versions, while the main branch contains already changes (wip) towards the next version. For example you released for Fall24 v1.0.0 with r1.2, in the main branch there are already changes which are planned to released as v1.1.0. If you know want to create a patch version v1.0.1 (e.g. with a documentation fix), you need to create a maintenance branch starting in r1.2, commit the fix on this branch and create a release tag on the maintenance branch. If you want to merge it also into main depends of the kind of fix ... it could be a workaround (e.g. some description) which is only valid for v1.0.x, but can finally only fixed in v1.1.0.


Ixia support for version field

@marcushines please pull the ixia node related changes for version support

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.751%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
590

Relevant Lines:
1262

💛  - Coveralls

@marcushines please pull the changes required for version support for Ixia nodes.

no worries that was my fault for not getting this merged sooner


Add erlang friendly clients

While I don't want to do tons of this, there's interest in adding erlang friendly clients so that erlang users can use this instead of erlcloud. Right now erlang users have to do 'Elixir.ExAws.S3':list_objects which is awkward.
The following gives an example s3 client.
defmodule :ex_aws_s3 do
  use ExAws.S3.Client
end

On further reflection I'm thinking that it may be best to simply document that this is a possibility for erlang users using mix instead of including it in this library itself.


[Suggestion] Add a "output window" link in the notification when creating a Function App

OS: All
Build Version: 20210521.1
Repro Steps:

Create a new function app.
Check the popped up notification.

Actual:
There is no "output window" link in the notification.

Suggestion:
Add a "output window" link in the notification when creating a Function App, like below:

We don't think the link is necessary since in this case we show the logs directly in the notification as they happen


The INSUFFICIENT_UTXO error is not clear enough

Issue
The reasons triggering the INSUFFICIENT_UTXO error are clear:

Not enough satoshi collected to cover the needs of the outputs and fee
Not enough satoshi collected to generate a change output (change output value < minUtxoSatoshi)

However, it's hard to prompt a specific reason that causes the error because there could be indirect causes:

Small value UTXOs (value < minUtxoSatoshi) of an address will be excluded as they're considered dust
If ckbVirtualResult.needPaymasterCell == true, there's an extra payment to the paymaster
The change output's defined value must be >= minUtxoSatoshi

Possible Resolutions

I think this is somewhat a lack-of-documentation issue, and if we can provide a better version of the documentation, things could be easier. For starters, we could write a "Common Errors" section in the documentation, explaining what the errors actually mean in reality and guiding users to find the actual cause or reason for the error.
For the indirect cause 3 mentioned above, we could add an option to allow treating the change value as fee if the value is smaller than the minUtxoSatoshi, instead of always generating a change output for that. Related issue: https://github.com/ckb-cell/rgbpp-sdk/issues/183.

For the indirect cause 3 mentioned above, we could add an option to allow treating the change value as fee if the value is smaller than the minUtxoSatoshi, instead of always generating a change output for that. Related issue: Don't create change output if not worthy #183.

Ideas about making the BTC tx cost as low as possible

546 <= changeValue < minUtxoSatoshi
create the change output directly with changeValue.

changeValue < 546
The change could be treated as a fee, as it may not be economically viable to create a change output for such a small amount.
=> https://github.com/ckb-cell/rgbpp-sdk/issues/183


Error running Gradle:

Steps to Reproduce

Launching lib\main.dart on Letv X500 in debug mode...
Initializing gradle...
Resolving dependencies...
* Error running Gradle:
Exit code 1 from: D:\Program Files\Android\temp workspace\flutter_appp\android\gradlew.bat app:properties:
Parallel execution with configuration on demand is an incubating feature.

Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error.

FAILURE: Build failed with an exception.

* Where:
Build file 'D:\Program Files\Android\temp workspace\flutter_appp\android\app\build.gradle' line: 25

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not resolve all files for configuration 'classpath'.
   > Could not find bundletool.jar (com.android.tools.build:bundletool:0.1.0-alpha01).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/build/bundletool/0.1.0-alpha01/bundletool-0.1.0-alpha01.jar
   > Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar
   > Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.1.0).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/build/aapt2-proto/0.1.0/aapt2-proto-0.1.0.jar

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s

Finished with error: Please review your Gradle project setup in the android/ folder.
Logs

D:\Program Files\Android\temp workspace\flutter_appp\foo>flutter run
Launching lib/main.dart on Letv X500 in debug mode...
Initializing gradle...                                       1.2s
Resolving dependencies...
* Error running Gradle:
Exit code 1 from: D:\Program Files\Android\temp workspace\flutter_appp\foo\android\gradlew.bat app:properties:
Parallel execution with configuration on demand is an incubating feature.

Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error.

FAILURE: Build failed with an exception.

* Where:
Build file 'D:\Program Files\Android\temp workspace\flutter_appp\foo\android\app\build.gradle' line: 25

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not resolve all files for configuration 'classpath'.
   > Could not find bundletool.jar (com.android.tools.build:bundletool:0.1.0-alpha01).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/build/bundletool/0.1.0-alpha01/bundletool-0.1.0-alpha01.jar
   > Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar
   > Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.1.0).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/build/aapt2-proto/0.1.0/aapt2-proto-0.1.0.jar

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s

Please review your Gradle project setup in the android/ folder.

D:\Program Files\Android\temp workspace\flutter_appp>flutter doctor -v
[√] Flutter (Channel beta, v0.8.2, on Microsoft Windows [Version 10.0.17134.345], locale zh-CN)
    • Flutter version 0.8.2 at D:\Develop\Flutter\flutter
    • Framework revision 5ab9e70727 (5 weeks ago), 2018-09-07 12:33:05 -0700
    • Engine revision 58a1894a1c
    • Dart version 2.1.0-dev.3.1.flutter-760a9690c2

[√] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at D:\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.2
    • ANDROID_HOME = D:\sdk
    • Java binary at: D:\Develop\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at D:\Develop\Android\Android Studio
    • Flutter plugin version 28.0.2
    • Dart plugin version 181.5616
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[!] IntelliJ IDEA Ultimate Edition (version 2017.2)
    • IntelliJ at D:\Develop\JetBrains\IntelliJ IDEA 2017.2.5
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[√] Connected devices (1 available)
    • Letv X500 • E6C6TKSKCUDM7P4T • android-arm64 • Android 6.0 (API 23)

! Doctor found issues in 1 category.

Just had this start to appear on my builds (on build server) today. Even though I didn't change anything in the dependencies.

I have just finished setting up flutter on windows 10 with Android Studio...
FLutter doctor output:
`C:\Users\Bob>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.9.4, on Microsoft Windows [Version 10.0.17134.345], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[√] Android Studio (version 3.2)
[√] VS Code (version 1.28.2)
[√] Connected devices (1 available)
• No issues found!`
However when I perform the test drive I get the following in studio's console:
`Launching lib\main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...
Resolving dependencies...

Error running Gradle:
Exit code 1 from: G:\flutter\flutter_test_01\android\gradlew.bat app:properties:
Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error.

FAILURE: Build failed with an exception.

Where:
Build file 'G:\flutter\flutter_test_01\android\app\build.gradle' line: 25

What went wrong:
A problem occurred evaluating project ':app'.

Could not resolve all files for configuration 'classpath'.
Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
Finished with error: Please review your Gradle project setup in the android/ folder.`
I am unable to move beyond this. I have tried Visual Studio Code and it also failed..!

Absolutely same thing here. I submitted a pull request that fixes it: https://github.com/flutter/flutter/pull/23397

Same here... well I started to use flutter in the wrong time haha

Same here... well I started to use flutter in the wrong time haha

Take a look at the PR I submitted earlier. It resolves the issue.

thank you, it's working

Strangely is that I do not get the problem locally. I wonder why not. Same version and everything I think. Just locally is Mac OS, build server is inside docker (linux).
So kind of hard to reproduce and fix on the build server.
@mrmitew how would you fix it on a build server?

Win10 OS run error
FAILURE: Build failed with an exception.
Where:
Build file 'D:\Program Files\Android\temp workspace\flutter_appp\android\app\build.gradle' line: 25

What went wrong:
A problem occurred evaluating project ':app'.

Could not resolve all files for configuration 'classpath'.
Could not find bundletool.jar (com.android.tools.build:bundletool:0.1.0-alpha01).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/build/bundletool/0.1.0-alpha01/bundletool-0.1.0-alpha01.jar
Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar
Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.1.0).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/build/aapt2-proto/0.1.0/aapt2-proto-0.1.0.jar

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

@waleedbasit
Temporary solution：
dependencies {
classpath 'com.android.tools.build:gradle:3.0.1'
}
distributionUrl=https://services.gradle.org/distributions/gradle-4.1-all.zip

@Sky24n it gives an error on distributionUrl

@waleedbasit
distributionUrl is in gradle-wrapper.properties

Merging with #23404

@Sky24n  I updated distributionUrl and the classpath but it still gives the same error

@waleedbasit publish your error message

@ShowMeThe   build.gradle 用3.0.1
buildscript {
repositories {
google()
jcenter()
}
dependencies {
    classpath 'com.android.tools.build:gradle:3.0.1'
}

}

Win10 OS run error
FAILURE: Build failed with an exception.
Where:
Build file 'D:\Program Files\Android\temp workspace\flutter_appp\android\app\build.gradle' line: 25

What went wrong:
A problem occurred evaluating project ':app'.

Could not resolve all files for configuration 'classpath'.
Could not find bundletool.jar (com.android.tools.build:bundletool:0.1.0-alpha01).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/build/bundletool/0.1.0-alpha01/bundletool-0.1.0-alpha01.jar
Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar
Could not find aapt2-proto.jar (com.android.tools.build:aapt2-proto:0.1.0).
Searched in the following locations:
https://jcenter.bintray.com/com/android/tools/build/aapt2-proto/0.1.0/aapt2-proto-0.1.0.jar

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

It is evident from your error log that gradle isn't looking at the google's repo, but only at jcenter.
The google() repo has to be added NOT in your gradle file, but in flutter's. A pull request was already merged that fixes the problem (not sure if it was also merged in the beta or only in master).

I found the solution there : https://github.com/flutter/flutter/pull/23397/commits/e93d19c0e7805e375b650ddf69009fa4549ad678#diff-d9b052388990c36138e397b5bb529025 thanks to @mrmitew .
Just find the flutter.gradle file in your folder : flutter/package/flutter_tool/gradle and add 'google()' to the buildscript. It fixed the issue for me.

Aqui tem a solução, nos textos anteriores explicam tbm... testei aqui e deu certo \0/...
https://github.com/mrmitew/flutter/commit/e93d19c0e7805e375b650ddf69009fa4549ad678

I found the solution there : e93d19c#diff-d9b052388990c36138e397b5bb529025 thanks to @mrmitew .
Just find the flutter.gradle file in your folder : flutter/package/flutter_tool/gradle and add 'google()' to the buildscript. It fixed the issue for me.

But where exactly. I'm so sorry but i can't it

@mrmitew solution worked for me. Thank you!

We will be releasing a new beta soon that contains the fix for this.

Making the answer Clear: All you have to do is go to your have your flutter installed and make sure maven is above jcenter in the flutter.gradle file

I've tried it. It doesn't work.

@AmandaMML Did you try adding google() ? I only followed this and it works!

I found the solution there : e93d19c#diff-d9b052388990c36138e397b5bb529025 thanks to @mrmitew .
Just find the flutter.gradle file in your folder : flutter/package/flutter_tool/gradle and add 'google()' to the buildscript. It fixed the issue for me.

@AmandaMML Did you try adding google() ? I only followed this and it works!

I found the solution there : e93d19c#diff-d9b052388990c36138e397b5bb529025 thanks to @mrmitew .
Just find the flutter.gradle file in your folder : flutter/package/flutter_tool/gradle and add 'google()' to the buildscript. It fixed the issue for me.

Now it works!! Thank you @aizuddineismail !!

@aizuddineismail I've I've tried it. It Work!
Thanks

@AmandaMML Did you try adding google() ? I only followed this and it works!

I found the solution there : e93d19c#diff-d9b052388990c36138e397b5bb529025 thanks to @mrmitew .
Just find the flutter.gradle file in your folder : flutter/package/flutter_tool/gradle and add 'google()' to the buildscript. It fixed the issue for me.

@aizuddineismail  I've I've tried it. It Work!
Thanks

C:\Users###Jean_Baptiste\AndroidStudioProjects\flutter_app>flutter run
Launching lib\main.dart on TECNO LA7 in debug mode...
Running Gradle task 'assembleDebug'...
FAILURE: Build failed with an exception.

Where:
Build file 'C:\Users###Jean_Baptiste\AndroidStudioProjects\flutter_app\android\app\build.gradle' line: 25

What went wrong:
A problem occurred evaluating project ':app'.

org/jetbrains/kotlin/cli/common/PropertiesKt

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 3m 18s
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                       202,0s (!)
Exception: Gradle task assembleDebug failed with exit code 1
Svp j'ai besoin de votre aide


Issue-981: Improve narrative for chatId.

See https://github.com/apache/camel-kamelets/issues/981
The consensus was that the documentation wasn't entirely clear as to whether chatId was mandatory or not.
It is mandatory but not necessarily as a Configuration Option if provided in the header.

Needs to be backported on 3.x and 3.20.x too.

@oscerd I've been thinking on this...
This PR made chat Id mandatory which is a breaking change (and is the cause of my re-consideration).
I'm thinking it may have been better to simply improve the description to read along the lines of chat Id being required as either a configuration option or supplied in the message header without making it explicitly required.
WDYT? Happy to submit more PRs.

This is on main branch, so a breaking change is fine. I'm happy to merge more stuff if you feel it would be better to just add a description


Expanded entry request for CHEBI:20689 (6-O-methylguanine)

It would be great if the preliminary entry for CHEBI:20689 6-O-methylguanine could be expanded into a full entry. This could largely be modeled after the version of this compound with the carbohydrate moiety (CHEBI:27549 O6-methyl-2′-deoxyguanosine). O6-methylguanine should be added as a synonym.
The below citation could also be added:
Clark, T. A., Spittle, K. E., Turner, S. W., & Korlach, J. (2011). Direct detection and sequencing of damaged DNA bases. Genome Integrity, 2(1), 10.

Hi Coby
As requested I've now curated a full entry for 6-O-methylguanine (see
http://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:20689).
Thanks again for your interest in ChEBI.
Regards,
Marcus

Marcus Ennis, CChem, MRSC
ChEBI Curation Consultant
European Bioinformatics Institute (EMBL-EBI)
Wellcome Trust Genome Campus
Hinxton, Cambridge
CB10 1SD
United Kingdom
La Jolla Institute for Allergy and Immunology
9420 Athena Circle
La Jolla
CA 92037
USA
t: +44 (0)1638 50 81 95 (office)
+44 (0)7866 29 29 26 (mobile)
e<EMAIL_ADDRESS><EMAIL_ADDRESS>
Visit ChEBI at www.ebi.ac.uk/chebi
On 21/06/2016 16:05, Coby Viner wrote:

It would be great if the preliminary entry for CHEBI:20689
6-O-methylguanine
http://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:20689 could be
expanded into a full entry. This could largely be modeled after the
version of this compound with the carbohydrate moiety (CHEBI:27549 O^6
-methyl-2′-deoxyguanosine
http://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:27549). O^6
-methylguanine should be added as a synonym.
The below citation could also be added:
Clark, T. A., Spittle, K. E., Turner, S. W., & Korlach, J. (2011).
Direct detection and sequencing of damaged DNA bases. Genome
Integrity, 2(1), 10. http://doi.org/10.1186/2041-9414-2-10
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ebi-chebi/ChEBI/issues/3166, or mute the thread
https://github.com/notifications/unsubscribe/APkQQDMz3xDk99Xj2nrSqayR7jtMGQA0ks5qN_3AgaJpZM4I61w_.

Thank you!


Unable to save workflow in UI

Hi ,
I am new to workflows. I started with docker compose provided in source code (https://github.com/serverlessworkflow/synapse/blob/main/deployment/docker-compose/docker-compose.yml) and tried saving hello world workflow sample provided. When trying to save the work flow its not saving .

Could you check the dev console of your browser for errors (and the server logs as well) ? In the current state of the issue, we do not have enough information to provide support.

Closed as stale


fix(system_monitor): change communication to unix domain socket

Signed-off-by: ito-san<EMAIL_ADDRESS>Description
There is a bug that the ROS node hdd_monitor communicates with the daemon process hdd_reader running on another ECU instead of that running on local computer when system_monitor runs on multiple ECUs at the same time.
The hdd_monitor and hdd_reader uses INADDR_ANY for socket programming, and the socket was bound to all network interfaces instead of localhost only.

The ROS node and daemon process is designed to communicate within localhost only, so I made a change to use an UNIX domain socket for local socket communication.

Changes

Use an UNIX domain socket(/tmp/hdd_reader) instead of INADDR_ANY.
Code refactoring to clean up complex codes.

Related links
TIER IV INTERNAL LINK TO SLACK
Tests performed
Verify all diagnostic topics regarding hdd_monitor are reported correctly.

Run Autoware.

Run rqt_runtime_monitor.
ros2 run rqt_runtime_monitor rqt_runtime_monitor

HDD Connection

HDD Usage

HDD Temperature

HDD PowerOnHours

HDD TotalDataWritten

HDD Recovered Error

HDD ReadDataRate

HDD ReadIOPS

HDD WriteDataRate

HDD WriteIOPS

Verify no warning and error messages in a normal run.

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@asana17 Sorry but many changes were made. Verified hdd_monitor works correctly.

The hdd_monitor functions are LGTM. From the parameter file hdd_monitor.param.yaml, can't multiple local HDDs or disks other than "disk0" currently be monitored?

This can be solved in future PR. so I remain it.


improvement(rust): separate runtimes for different overload

What changes were proposed in this pull request?
In current codebase, we use the same tokio runtime for grpc/http/reading/flushing service, this is not
stable fot the different load.
This PR is to introduce runtime manager to separate.
Why are the changes needed?
For #1234 , separate runtimes for different overload
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UTs

Codecov Report

Merging #1233 (1a110c5) into master (77092e4) will increase coverage by 1.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1233      +/-   ##
============================================
+ Coverage     53.57%   54.61%   +1.04%
  Complexity     2613     2613
============================================
  Files           395      375      -20
  Lines         22648    20288    -2360
  Branches       1933     1933
============================================
- Hits          12133    11080    -1053
+ Misses         9774     8539    -1235
+ Partials        741      669      -72

see 24 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cc @jerqi Please help merge this


Dispense location of fixed trash causes multi-channel collision on slope

Using the transfer function with the destination trash[0] as in the 10X Serial Dilution Protocol published on the OpenTrons website causes the pipette to collide with the waste container (and with the waste frame when the container is removed) along the z axis.
steps to reproduce
m300.transfer(
transfer_volume,
plate.columns('1'),
trash[0])

Hi, thanks for the report! Can you please provide us with the following information so we can investigate this issue?

Robot type
App version
Robot software version (if OT2)
Operating system and version
Full protocol to reproduce issue

@5000commas were you able to gather the information requested above?

@btmorr reproduction protocol:
# multi-channel trash collision repro protocol
from opentrons import containers, instruments

tiprack = containers.load('tiprack-200ul', '9')
plate = containers.load('96-flat', '1')

p300m = instruments.P300_Multi(tip_racks=[tiprack], mount="left")

p300m.pick_up_tip()
p300m.aspirate(25, plate.cols('11'))

# THIS CRASHES THE ROBOT
p300m.dispense(p300m.trash_container)

The cause for this is that the dispense method defaults to the bottom of the well, if a vector is not provided (as opposed to move_to commands, for instance, which default to the top of the well). To explicitly dispense into the trash, please use:
p300m.dispense(p300m.trash_container.top())

Talked to @5000commas on Intercom today. Tried @btmorr's fix but didnt solve issue. Code to reproduce:
m300.transfer(
transfer_volume,
plate.columns('7'),
trash[0],
new_tip='never')

Video of the crash is attached as zip file: VID_20180828_111526.3gp.zip
Conversation link on Intercom: https://app.intercom.io/a/apps/ukpodv2l/inbox/inbox/all/conversations/18203485047

@willcanine I believe that, according to @btmorr's fix, that transfer should be written as:
m300.transfer(
    transfer_volume,
    plate.columns('7'),
    # this might need to be trash[0].top()
    m300.trash_container.top(),
    new_tip='never')

From your reply (can't see the Intercom conversation) it looks like the fix might not have been attempted? @5000commas are you able to confirm?

Closing because (according to the Intercom conversation) customer issue seems resolved and the transfer code posted above should work. Will re-open if this is not the case

Getting the same issue.
waste = pipette.trash_container.top()
pipette.transfer(volume, plate[well], waste, new_tip='never')

Yields TypeError <opentrons.protocol_api.disposal_locations.TrashBin object at 0x0000022D5A00EFB0>


Conduct Needs Assessment

[ ] - Identify and assess the needs of the communities we serve
[ ] - Gather data through surveys, interviews, and focus groups
[ ] - Analyze findings to inform program development
[ ]

Assign Otobong & Irene to this-

The @clentafrica/wg-programs can collaborate with the @clentafrica/wg-research-and-data team to work on this. Is anyone available to work on this please?


Insert labels in batches to avoid pq param limit

pq has a limit of 65535 parameters, see https://github.com/lib/pq/blob/master/conn.go#L1282
now we insert labels in batches to avoid this limit

Coverage decreased (-0.07%) to 86.832% when pulling 205d9c35c5782a191d618da8fb09bb3040fd35c9 on pg-param-limit into bcd5de748902327e1bf3c25bd9c78d73134b9155 on master.


Jck java_io can exceed max open files if concurrency too high

Jck java_io test suite can exceed max open files if concurrency too high on certain machines.
JavaTestRunner will scale its concurrency to the machines cpu's, which can exceed max open files, which via testing exceeds 10,000 open files.
This PR limits the concurrency to 1 for java_io, to prevent JavaTestRunner from exceeding the limit.
Resolves Temurin compliance issue 286

@Mesbah-Alam The testcase completes in only 5mins with concurrency=1 on an average mac machine, so it's a fairly short testcase anyway.

Thanks @andrew-m-leonard !


Fix docker container

Ubuntu/Xenial based Docker base image doesn't work with the binaries produced by the build container (based on Debian/Stretch).
Fixes https://github.com/paritytech/substrate/issues/2569

wrong base branch.


img2img with image guidance scale of 1.0 yields different results than txt2img

Question is: shouldn't they be identical?

No. Fixed.


fix: correctly load twitch badges in highlights page

this was broken in https://github.com/Chatterino/chatterino2/pull/3736
Broken state:

Fixed state after this PR:

in what way https://github.com/Chatterino/chatterino2/pull/3736 broke it?
imageCount() == 0 check was present before my PR, so unless it reports -1 now (which is error value we probably shouldn't ignore), it was broken before

in what way #3736 broke it? imageCount() == 0 check was present before my PR, so unless it reports -1 now (which is error value we probably shouldn't ignore), it was broken before

My bad, I checked the diff too lazily then


212 testcase for every endpoint 1

closes #212

Endpoints (implemented & tested):
Entities

[x] GET /entities
[x] POST /entities
[x] GET /entities/{entityId}
[x] DELETE /entities/{entityId}
[x] POST /entities/{entityId}/attrs
[ ] PATCH /entities/{entityId}/attrs
[x] PATCH /entities/{entityId}/attrs/{attrId}
[x] DELETE /entities/{entityId}/attrs/{attrId}

Batch operations

[x] POST /entityOperations/create
[x] POST /entityOperations/update
[x] POST /entityOperations/upsert
[x] POST /entityOperations/delete

Subscriptions

[x] GET /subscriptions
[ ] POST /subscriptions
[ ] GET /subscriptions/{subscriptionId}
[ ] PATCH /subscriptions/{subscriptionId}
[ ] DELETE /subscriptions/{subscriptionId}

Complete unit tests for client endpoints
Entities

[ ] GET /entities (all parameters are missing, among all idPattern, type, attrs, options should be tested.)
As for options
sysAttrs, a representation of NGSI-LD Elements shall be provided so that the system-generated attributes createdAt, modifiedAt are included in the response payload body.
keyValues, a simplified representation of entities shall be provided
[x] POST /entities
[ ] GET /entities/{entityId} (parameters type and optinos are missing)
As for options,
sysAttrs, a representation of NGSI-LD Elements shall be provided so that the system-generated attributes createdAt, modifiedAt are included in the response payload body.
keyValues, a simplified representation of entities shall be provided
[x] DELETE /entities/{entityId}
[x] POST /entities/{entityId}/attrs
[ ] PATCH /entities/{entityId}/attrs
[x] PATCH /entities/{entityId}/attrs/{attrId}
[x] DELETE /entities/{entityId}/attrs/{attrId}


Add Bhuvana

Good job @bhuvanakundumani, can you please fix the conflicts, so I can merge?

Thanks @bhuvanakundumani!


compress messages?

when using snappy/gzip compression in async-producer, it compresses one message, or one messageset per time?

Compression is per message set.


DBZ-5542 Edits property description; populates empty table cells.

DBZ-5542
Updates description of mongodb.connection.string property to remove typo, improve clarity, and apply style guidelines.
Also populates empty cells in property table entries with No default string.
Tested in local Antora build.

@jcechace Could you please take a look? The wording LGTM.


nsenter: cannot open /proc//ns/ipc: Permission denied

I've seen message that I can handle docker without root permissions by adding myself to docker group: http://askubuntu.com/a/477554/115769.
It works, I really can get container ID and PID, but I can't use nsenter, error in subject:
nsenter: cannot open /proc/<PID>/ns/ipc: Permission denied

I subscribe.
OpenSuse 13.1, nsenter 2.25.1, my groups:
$ groups
users docker vboxusers

Making
$ nsenter --target $PID --mount --uts --ipc --net --pid

And get

nsenter: cannot open /proc/7331/ns/ipc: Permission denied

That seem logical -
(root) $ ls -la /proc/7331/ns/ipc
lrwxrwxrwx 1 root root 0 Apr  3 14:23 /proc/7331/ns/ipc -> ipc:[4026532897]

Which version of Docker are you using? (docker version)
If it's recent enough, you can use docker exec.
 But I also thought nsenter should still be alive -)

Are you using AppArmor or SELinux? Does anything particular show up in dmesg after trying to run nsenter?

Is this issue resolved by any chance. Without prepending "sudo", I am unable to nsenter (docker exec works fine though). I am using ubuntu 14.04 LTS and rest of the details are below
pmacharl@continuousautomation:~$ docker ps
CONTAINER ID        IMAGE                  COMMAND             CREATED             STATUS              PORTS               NAMES
3f742bab06d5        evarga/jenkins-slave   "/bin/bash"         5 minutes ago       Up 5 minutes        22/tcp              furious_saha
pmacharl@continuousautomation:~$ uname -r
4.1.5-x86_64-linode61
pmacharl@continuousautomation:~$ docker version
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:12:04 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:12:04 UTC 2015
 OS/Arch:      linux/amd64
pmacharl@continuousautomation:~$ nsenter -m -u -n -p -i -t 6896 /bin/bash
nsenter: cannot open /proc/6896/ns/ipc: Permission denied
pmacharl@continuousautomation:~$ sudo nsenter -m -u -n -p -i -t 6896 /bin/bash
root@3f742bab06d5:/#

Oh, sorry, I hadn't read this correctly. You need permissions to use nsenter; in that case, it is likely that your UID doesn't match the UID of process 6896.


Crash in [ARTRealtime transitionSideEffects:] (508)

Ably v1.0.6
*** Collection <ARTRealtimeChannels: 0x17403f1c0> was mutated while being enumerated.
-[ARTRealtime transitionSideEffects:]
The problem is that I cannot reproduce it.

Fatal Exception: NSGenericException
0  CoreFoundation                 0x1909a2fe0 __exceptionPreprocess
1  libobjc.A.dylib                0x18f404538 objc_exception_throw
2  CoreFoundation                 0x1909a2a30 -[NSException name]
3  Ably                           0x1001f0d80 -[ARTRealtime transitionSideEffects:] (ARTRealtime.m:508)
4  Ably                           0x1001ef950 __40-[ARTRealtime transition:withErrorInfo:]_block_invoke (ARTRealtime.m:328)
5  Ably                           0x1001de66c __artDispatchSync_block_invoke.21 (ARTGCD.m:88)
6  libdispatch.dylib              0x18f85a9a0 _dispatch_client_callout
7  libdispatch.dylib              0x18f867ee0 _dispatch_barrier_sync_f_invoke
8  Ably                           0x1001de3b8 artDispatchSync (ARTGCD.m:99)
9  Ably                           0x1001ef6b8 -[ARTRealtime transition:withErrorInfo:] (ARTRealtime.m:334)
10 Ably                           0x1001f2cf8 -[ARTRealtime onError:] (ARTRealtime.m:672)
11 Ably                           0x1001f80b0 -[ARTRealtime realtimeTransport:didReceiveMessage:] (ARTRealtime.m:1175)
12 Ably                           0x100220680 -[ARTWebSocketTransport receive:] (ARTWebSocketTransport.m:94)
13 Ably                           0x10022072c -[ARTWebSocketTransport receiveWithData:] (ARTWebSocketTransport.m:101)
14 Ably                           0x1002227cc __46-[ARTWebSocketTransport webSocketMessageData:]_block_invoke (ARTWebSocketTransport.m:370)
15 libdispatch.dylib              0x18f85a9e0 _dispatch_call_block_and_release
16 libdispatch.dylib              0x18f85a9a0 _dispatch_client_callout
17 libdispatch.dylib              0x18f868ad4 _dispatch_queue_serial_drain
18 libdispatch.dylib              0x18f85e2cc _dispatch_queue_invoke
19 libdispatch.dylib              0x18f86aa50 _dispatch_root_queue_drain
20 libdispatch.dylib              0x18f86a7d0 _dispatch_worker_thread3
21 libsystem_pthread.dylib        0x18fa63100 _pthread_wqthread
22 libsystem_pthread.dylib        0x18fa62cac start_wqthread

Thanks for the report @andreiChis70. This looks to me like a thread-safety issue, as the ARTRealtimeChannels collection is being mutated (ie. a channel is created or released) in a thread while being iterated in another thread. Luckily, we're in the process of making the whole library thread-safe. The next release will fix this and other related issues.

I'm lucky :)
Looking forward to the next release.

@andreiChis70 Can you confirm this is fixed? The thread-safe release was made a while ago. Sorry, should've updated this issue then.

@tcard Yes it is fixed. Thank you!


update to 20190819.  add comments to recipe and build script.

Checklist

[X] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thank you @notestaff !!!


Pypi enable poetry publish - 88

[Auto generated]
Number: [#88]

github-gitlab-webhook-server: Closing issue for PR: Pypi enable poetry publish.
PR was closed.


Non-performant use of fibers on Windows

https://github.com/google/marl/blob/8c98371e534c1f4fc0faaa91575027d13ab74f54/src/osfiber_windows.h#L67
The Win32 CreateFiber function has unexpected virtual memory size by default. When using CreateFiberEx, default behavior is to round stack size to next multiple of 1MiB. With CreateFiber, for some reason it rounds to 2MiB, which is even worse.
Now even if you use CreateFiberEx, there's still some weirdness. If dwStackCommitSize and dwStackReserveSize are equal, the stack size will still round to 1MiB. The only way is to use it like this:
CreateFiberEx(size - 1, size, FIBER_FLAG_FLOAT_SWITCH, cb, NULL);
Note that even then, the stack can't be less than dwAllocationGranularity, which is typically 64KiB. If this minimum stack size is OK for performance, then that's how fiber creation should be done on Windows.
If we need smaller values (16KiB is common in schedulers), then asm fibers should be used instead IMO.

Thank you for your feedback @jesta88.

The Win32 CreateFiber function has unexpected virtual memory size by default. When using CreateFiberEx, default behavior is to round stack size to next multiple of 1MB. With CreateFiber, for some reason it rounds to 2MB, which is even worse.

My understanding was that this is an initial reservation size, not a committed size. For Win64, this seems like a non-issue? For 32-bit, I can see why this would be problematic.
Am I missing something?
One of my colleagues (@AWoloszyn) has some previous experience writing a fiber context switch in Windows, and advised against it due to complexities with implementation (he can give more information). If the fiber stack size is a deal breaker for windows, I'd be open to making changes here (or accepting PRs).
Currently marl has a fixed stack size of 1 meg per fiber (non-windows), which is larger than I'd like, but does make things fairly consistent across the different platforms. I do intend to make this configurable and to lower the default value down significantly.
Many thanks,
Ben

It's not just a reservation size unfortunately. See this simple test: https://gist.github.com/SergeyMakeev/65b8b3ee72c65b2a70534cd873e540f6
Results:

estimated : 78.125000 Mb
reality : 5007.000000 Mb
estimated : 16384 bytes
reality : 1050044 bytes

It's a known quirk of Win32 fibers, and the workaround I mentioned has been battle-tested in production for quite a while. See the Ruby implementation: https://github.com/ruby/ruby/commit/c462c50d6336a0c7823ff8cfce51f8bff22eeff6#diff-d6ef5d5c0939813bfb4ff4bdab9f3930R574
For now since your stack size is hard-coded to 1MiB it won't make a huge difference, but eventually if you support configurable stack sizes, you could see non-trivial gains.

I believe the original request has been fixed with https://github.com/google/marl/pull/173.
It still might be beneficial to have a non-Win32-Fiber (assembly) implementation at some point, but that goes beyond the scope of this issue.
Closing.


shadowsocks go mu can't starting, Get User Error%!(EXTRA *json.Unmarshal was reported

When I starting the shadowsocks go mu, the following messages are output:
time="2017-06-23T17:44:52+08:00" level=info msg=PONG
E0623 17:44:53.025237    9731 boot.go:36] Get User Error%!(EXTRA *json.UnmarshalTypeError=json: cannot unmarshal number 1.073741824021e+18 into Go struct field User.transfer_enable of type int64)
Should I to do?
Thanks!

please check new version


CrispView not fitting the entire scaffhold

Hi,
I'm having trouble with the size of the crispView on iOs devices. In Android, it works well. (see picture below)
Context:
Scaffhold:
-> LayoutWidget
     -> Stack
          -> Offstage( DashboardPage )
          -> Offstage( ChatPage )
               -> CrispView // problem here
          -> Offstage( AccountPage )
     -> BottomNavigationBar

When I remove the Offstage, the CrispView fits the entire screen.
I don't want to get rid of the offstage.
Does anyone have a workaround or not how to fix this issue?

Since it will fit the entire screen I think you don't need to wrap the crisp in the chat page, so you would be able to make two different pages if you need a chat page.
Scaffhold:
-> LayoutWidget
     -> Stack
          -> Offstage( DashboardPage )
          -> Offstage( ChatPage )
          -> CrispView // other different page
          -> Offstage( AccountPage )
     -> BottomNavigationBar

What do you think?

No, to render CrispView in the space I just sent. Instead of above Offstage it would be above Stack

From what I can understand:
Scaffhold:
-> LayoutWidget
     -> CrispView (//above Stack)
     -> Stack
          -> Offstage( DashboardPage )
          -> Offstage( AccountPage )
     -> BottomNavigationBar

Is it so?

I think that can work, but I think it could be CrispView inside Stack too I think, as I sent.

If I let the CrispView inside my stack, I'll need the OffStage to hide it though.

Hey, since there isn't any update here and it's a more code layout issue and not direct related to this library, I'm gonna close this issue. If you still have problems Stackoverflow would be a better place to ask for help in this case. :smiley:


Add stat that allows attackers to take more damage from defenders when attacking

LA would like a stat that allows defenders to do damage when attacked in melee. Think 'spiked armor' or equivalent.

Alternatively:
we gotta put him in one of these
ohhh @FrostRaptor i have a idea for charge balance
have defender/target tons affect attacker self damage taken
that could tie into my ideas with the spikes too and scale that
Interactive Rubber Dolphin11/16/2020
that's how charge is calculated
????
Damage to attacker is calculated by target tons
@Alekto
Alekto11/16/2020
oh?
Interactive Rubber Dolphin11/16/2020
"Charge": {
"AttackerDamagePerTargetTon": 0.5,
Alekto11/16/2020
so basically for my spikes idea
i only need a way to scale that on the defender


TopicDispatcherDefault 'dispatch method' with MDC use discussion

Notice that TopicDispatcherDefault dispatch function brings in MDC operation for trace,  but there's  only put operation  in current implementation,  could it be result in memory leak with no remove or clear operation.

感谢！

v0.52 修好了。谢谢


Need default StorageClass

Need to write a default StorageClass that gets created with the cluster. Many ways to handle this - or we just set it to a StorageClass with no provisioner and let the user figure out how they want it to work; which works unless you create a PVC without specifying a local path.

There has to be something off the shelf we can use that maps to the various LXD storage pools

dir
block device w/ filesystem (btrfs)
zfs? usually special
Ceph - already has has clustered storage and virtual block storage provisioning built in

We should look into the microk8s project and see what they use.


asyncio IPC PUSH/PULL Socket.close + Context.term + Context.destroy do not reliably flush messages with LINGER == -1 on debian

re-opening https://github.com/zeromq/pyzmq/issues/832
based on conversations here: https://github.com/zeromq/libzmq/issues/1922#issuecomment-300988036
looks like they did some updates in libzmq recently which may have resolved the underlying flush, however I'm still seeing messages getting dropped in pyzmq.  You can see in https://github.com/zeromq/libzmq/issues/1922 that I translated the pyzmq testcase into native code and the issue doesn't happen in the native code.  @minrk would you mind taking a look?  It would be awesome if we could finally put this to bed :)

closing, forgot to remove a sleep in native testcase :)


test: Add tests for Users with mock responses

Plus some TODOs that come out of this (I'll come back to them tomorrow, or you can feel free to push to this branch). This should exercise some of the previously untested code, and should open up a path for adding some enhancements on top.

I'm going to merge this: it pushes test coverage to 96% of lines, and it covers the key functionality of the Users resources. I want to try a refactor and need this coverage in place first.


help help ！

How to add a topic in your project！

If you want a make a publisher, you can look at RobotController:432 for reference.

I mean to add one user-defined topic .The  parameter is  java.lang.String.
)

Do you want to allow a user to add a topic in the app? This feature was not
part of the app as far as I know.
Or do you mean you want to add a new topic to the app and have the user
pick the name? This would be similar to how we handled the topics
(joystick, navsat, etc.) that are already in the app.
Can you clarify? I'm not sure what you mean. Your English isn't bad. I just
need more information and context.
On Jul 22, 2017 2:29 AM, "lichunlei4"<EMAIL_ADDRESS>wrote:

I mean to add one user-defined topic .The parameter is java.lang.String.
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SCCapstone/RobotCA/issues/63#issuecomment-317170569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIHUSS4giJGXGzzAJPjA2v5eJlyyFBTcks5sQcESgaJpZM4OgCI2
.

I mean is to add a new topic to the app and have the user
pick the name. I tried but it didn't  work !Can you give me an example?

I mean is to add a new topic to the app and have the user
pick the name. I tried but it didn't work !Can you give me an example?
(the topic has a parameter type is std_msgs::String::ConstPtr)!

Oh ok. There's a few things you need to do for that.

Add the topic to RobotInfo. This is the main class for a robot's configuration. Other classes use the constants and data in there to subscribe, publish, and save preferences for each robot.
Add the topic to the AddEditRobotDialog. This allows the user to add/edit topics for a robot before they connect.
Add the topic to the Preferences file. This file is used to make the settings view that allows the user to edit the topics after they have connected to a robot.
Update RobotStorage with the new topic so that it can load/save the topic from/to SharedPreferences.

It would probably be easiest to copy the existing pattern for topics that are already in the app like navsat, pose, or joystick.

this project have a bug ! some time cannot move to forward~！Do you know way~！

how to change the ros‘s speed？？

I'm not sure why moving forward wouldn't work. This code is not the best quality since it was done over a few months with minimal testing. It's not being maintained anymore so there won't be any bug fixes.
What do you mean by the ros's speed? You mean the robot's speed? That's a setting you have to change. I don't know anything about your configuration.

OH~!Thanks mtbii~!Mtbii is your real name?? Do you have a better Code??

Not my real name. If click on my name here you can see all my info in my GitHub profile including my real name (which is Michael).
I don't have better code unfortunately. This was a project I worked on with a few other people during my last year in college in a senior-level capstone design course. It was for a robotics research group at my university and no one has touched the code in a year or so because we all graduated and got jobs that keep us busy. That's why I put "No longer maintained, please fork or PR" in the README. It has only been tested on a few robots in the lab. I made the code public so others could (hopefully) learn and do better and more interesting things with the code.

Well, your programming skills are very powerful!

你现在做什么工作呢？方便说吗？

I'm a software engineer at Google now working on Android Things. Very fun, but very time consuming and difficult.

I used to work on Chrome. I created the chrome://bluetooth-internals page (which most people have never seen. Haha.).

I'm also a Android developer, but I'm just a newbie!  I must learn from you!

I haven't been doing Android that long, but I know enough to get some basic stuff done.

That enough~!What subject did you study at university？ What kind of development are you good at?

I studied computer engineer. It's a mix of computer science and electrical engineering (mostly computer science though). Most of my experience is in web development: HTML, JS, CSS, React, and Angular. I just started doing Android platform stuff: interacting with hardware drivers, adding new APIs to Android itself, and writing apps to test the new APIs.

Why the project can't load the map?

I just noticed this is the out of date repo so you might want to move to the cloned one:
https://github.com/mtbii/RobotCA
Or better yet, ros-autom has an updated version that was forked from my cloned repo.
https://github.com/ros-autom/RobotCA


reduce postprocessors to Function

This PR removes AgnosticMetric and changes the representation of postprocessors from Transformation<DI, DO, AgnosticMetric, AgnosticMetric> to Function<TI, TO>.

Current dependencies on/for this PR:

main

PR #648   👈

PR #618

PR #456

PR #641
PR #653

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #648   👈

PR #618

PR #456

PR #641
PR #653

This comment was auto-generated by Graphite.


[composer] Edit mode - all add symbols "+" are appears when collapse the main window(localObserver)

Description:
As $subject see in image1, I can view all in expand the resource windows under edit mode. In image2 I tried to collapse the main window(localObserver) and observed a UX issue.
image1

image2

Affected Versions:
beta17
OS, DB, other environment details and versions:
Firefox-59.0.2
Ubuntu 15.10

verified with 0.970.2


KeyError 'rows' when using task scheduler

I have been working on an easy way to pull all the impression data from Google Search Console.
I have created a python script based off of the supplied example from Google.
Everything was working perfectly! so I created a bat file to run all my clients data at once, each day and used windows task scheduler to run the bat file.
The issue is, whenever task scheduler runs the .bat file, I get this error.
Traceback (most recent call last):   File "impressions-data.py", line 150, in <module>     main(sys.argv)   File "impressions-data.py", line 86, in main     print_web_table(web_response, file_path)   File "impressions-data.py", line 113, in print_web_table     rows = web_response['rows'] KeyError: 'rows'
However, if I run the .bat file manually, everything works perfectly and no issues.
Any thoughts on why task scheduler would cause this issue? and running it manually wouldn't?
Thanks.

Usually if KeyError happens, it's usually caused by your API request is too much on same IP in a short time or the server on Google side have trouble
but assuming that your bat file runs all the client on the same time at once, I guess it's the first case as it also happens on my side as well
Try supplying userIP or quotaUser parameter
https://developers.google.com/analytics/devguides/config/mgmt/v2/parameters

Hi @daocsm,
It looks like that KeyError is a result of  web_response not containing the field you were expecting. This sample checks to make sure there is a field rows in the response before trying to access the value.
https://github.com/googleapis/google-api-python-client/blob/fef743a41e8f0e533469d621567f322a5f8465be/samples/searchconsole/search_analytics_api_sample.py#L159-L172
You can check to see if the request was successful by looking for rows and do some error handling or logging when it isn't in the response. This should help track down what's going wrong when you run your .bat file.
Please let us know if you have more concerns.


After duplicating and deleting the same row in statement list, there is missing entity notification from BE.

Something with audit.
/api/v1/audits/get/ab1a3076-efe6-457a-9886-ef64c9467d47 400 (Bad Request)


Define model sync priority

Is your feature request related to a problem? Please describe.
Some of our models are essential for display on the initial screen a user sees. Other data is more of a nice to have as it requires deeper navigation. Equally some of this deeper data is significantly larger.
Syncing seems to happen all together, or maybe indeterminate is a better way to describe it
Describe the solution you'd like
We'd want to define a high, medium and low priority of model entities as they'd be synced.
Say it was a music app where we sync song names and for whatever reason, their lyrics are a separate model. Something like
ModelRegistry.register(modelType: Song.self, priority: .high)
ModelRegistry.register(modelType: SongLyrics.self, priority: .low)

To also be clear, we still want to sync all the data, just that some of it would be preferable to be available ASAP vs others at the background rate would be fine
Describe alternatives you've considered
N/A

Note for future: This feature request would have to be balanced against the need to sync the models by their relationship dependencies. In the above example, if "Song" has a 1:many relationship with "SongLyrics", then we'd have to sync SongLyrics first, regardless of their relative priorities, in order to maintain referential integrity.

Seems to have a similar desired outcome as #1106

Seems to have a similar desired outcome as #1106

I don't follow that, except insofar as the desired outcome is "all my data syncs"? It seems that #1106 is related to a max subscription error, as opposed to this request being about prioritizing subscriptions so they can be fulfilled in a customizable order.

I'd also like this... I thought I could create something similar with sync expressions (basically return a predicate like model.keys.owner == ready?userId:"bogus"), but that doesn't seem to work due to https://github.com/aws-amplify/amplify-ios/issues/1177
This would be super useful and I don't see a way to work around it.

This would be ideal.  In our scenario, one of our most necessary items is the User table.  This table doesn't have any dependencies but gets relegated to the end of the sync due to the alphabetical sort in the sortByDependencyOrder method.  It would be great if this initial sorting was adapted to utilize a user-preference priority as suggested here.

Anything that can be done to help progress this?
This is definitely a recurring issue for our users as they switch phones, receive app updates with new schemas, etc.  The more data they accrue the longer they have to wait until the app can be used since we must wait until user and profile are synced.  Add in data sync only running in the foreground and you end up with a decent number of people that call in frustrated.

I wonder if there could be some sort of config option that we could to to eg. mark certain models to be synced in batches.
Say eg. models that do not have relationships could be batched, and the onees with relationship woul still rely on one-by-one syncing...


docs: add query parameters to list tags endpoint

Solves #25,
Updated the query parameters for README#list-tags, which although in the issue #25 has been mentioned as README#getTags, which doesn't exist. So I continued with the one that was prevailing in the real documentation.

The link in the issue was just outdated. This looks perfect, I'll go ahead and merge it. Thanks!

The link in the issue was just outdated. This looks perfect, I'll go ahead and merge it. Thanks!

Awesome :v

Awesome :v


perf(internal/blocksync): do not ValidateBlock twice

The first time we validate the block is by calling ValidateBlock. Then we were calling ApplyBlock, which also calls ValidateBlock. The solution is to introduce a new method - ApplyVerifiedBlock, which skips validation.
Refs #1830

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[x] Updated relevant documentation (docs/ or spec/) and code comments

cc @ValarDragon

@mergify backport v0.37.x


Karma sometimes fails to start

When running tests through our CI server, karma fails to start in around 10% of our builds. Its not consistent, and doesn't happen locally which leads me to believe this is a race condition.
The testing is started with meteor --test, and we're running sanjo-karma 3.1.0, and we're running with the following settings:
JASMINE_SERVER_UNIT=0
JASMINE_SERVER_INTEGRATION=1
JASMINE_CLIENT_UNIT=1
JASMINE_CLIENT_INTEGRATION=0
CUCUMBER=0
JASMINE_BROWSER=PhantomJS
VELOCITY_CI=1
VELOCITY_DEBUG=1

I'm seeing the following log when it fails, and it causes the build to hang forever (because the JASMINE_CLIENT_UNIT never finishes).
[12:30:02][Step 1/2] W20160126-08:28:23.308(0)? (STDERR) [sanjo:karma]: start request failed { [Error: connect ECONNREFUSED]
[12:30:02][Step 1/2] W20160126-08:28:23.309(0)? (STDERR)   code: 'ECONNREFUSED',
[12:30:02][Step 1/2] W20160126-08:28:23.309(0)? (STDERR)   errno: 'ECONNREFUSED',
[12:30:02][Step 1/2] W20160126-08:28:23.309(0)? (STDERR)   syscall: 'connect' }

Our build agents aren't the fastest in the world, which leads me to believe its a race condition. In the apiRequest, you have 5 retrys with 1000ms retryDelay.
Is it possible to fix this issue or make the retry count and delay configurable? That way people with slow hardware can increase the retrycount or delay and not run into this.
When googling [sanjo:karma]: start request failed { [Error: connect ECONNREFUSED], I can see other people have also experienced this.

Hi. I have just released 3.1.1. There is a chance that the version fixes your problem without any adjustments on the retry times. But I have also added environment variables for it: https://github.com/Sanjo/meteor-karma/commit/ec7673fd9c525a8678fe909fa26ff859c5a5b82a

Thanks a bunch! I'm currently testing, and I'll close this issue within a few days unless I find something (specific).
Again, Thank you!

I have the same problem with 3.1.1 if I create only client unit tests
I20160331-17:00:36.601(3)? [velocity] Search framework for path tests/jasmine/client/unit/sample/src/Player.js
I20160331-17:00:36.602(3)? [velocity] Target framework for tests/jasmine/client/unit/sample/src/Player.js is jasmine-client-unit
I20160331-17:00:36.603(3)? [velocity] Search framework for path tests/jasmine/client/unit/sample/src/Song.js
I20160331-17:00:36.603(3)? [velocity] Target framework for tests/jasmine/client/unit/sample/src/Song.js is jasmine-client-unit
I20160331-17:00:36.604(3)? [velocity] Search framework for path tests/jasmine/client/unit/sample/spec/PlayerSpec.js
I20160331-17:00:36.605(3)? [velocity] Target framework for tests/jasmine/client/unit/sample/spec/PlayerSpec.js is jasmine-client-unit
I20160331-17:00:36.606(3)? [velocity] Search framework for path tests/jasmine/client/unit/sample/spec/SpecMatchers.js
I20160331-17:00:36.606(3)? [velocity] Target framework for tests/jasmine/client/unit/sample/spec/SpecMatchers.js is jasmine-client-unit
I20160331-17:00:36.606(3)? [velocity] File scan complete, now watching /tests
I20160331-17:00:36.606(3)? [velocity] Triggering queued startup functions
I20160331-17:00:36.655(3)? [sanjo:jasmine]: No tests for jasmine-server-integration found. Reporting completed.
I20160331-17:00:36.662(3)? [sanjo:jasmine]: No tests for jasmine-client-integration found. Reporting completed.
W20160331-17:00:40.729(3)? (STDERR) [sanjo:karma]: start request failed { [Error: connect ECONNREFUSED]
W20160331-17:00:40.729(3)? (STDERR)   code: 'ECONNREFUSED',
W20160331-17:00:40.730(3)? (STDERR)   errno: 'ECONNREFUSED',
W20160331-17:00:40.730(3)? (STDERR)   syscall: 'connect' }

Well, I am also @3.1.1 but this was all working fine until the Meteor 1.3 update.
W20160331-21:30:22.551(1)? (STDERR) [sanjo:karma]: start request failed { [Error: connect ECONNREFUSED]
W20160331-21:30:22.552(1)? (STDERR)   code: 'ECONNREFUSED',
W20160331-21:30:22.552(1)? (STDERR)   errno: 'ECONNREFUSED',
W20160331-21:30:22.552(1)? (STDERR)   syscall: 'connect' }

In the server integration log I can see that there is dependency conflicts.
Errors prevented startup:

   While selecting package versions:
   error: Conflict: Constraint<EMAIL_ADDRESS>is not satisfied by meteor 1.1.10.
   Constraints on package "meteor":
   *<EMAIL_ADDRESS><- top level
   *<EMAIL_ADDRESS><- meteor-base 1.0.1
   *<EMAIL_ADDRESS><- underscore 1.0.4 <- accounts-base 1.2.2 <-
   accounts-facebook 1.0.6

@Sanjo is this because the Velocity mirror is actually running Meteor 1.2.1_2 not 1.3 and the Meteor 1.3 dependency versions conflict?
I guess this then may not be related to any of the above, or even the Karma start up because this error causes the start to fail anyway.
I guess as Velocity is effectively abandoned this may not get resolved as it has testing baked in now. However I don't really want to move from Jasmine to Mocha/Chai for all my tests. I guess I'll wait for that jasmine driver?

Hi,
My bad for not closing this issue earlier. I believe the previous issue was resolved, and I would propose you create a new issue regarding the things you're seeing.
This is just to keep track of the different issues in the future. I will let this issue be open until you have created a new one.
Thanks in advance.

Hey, no problem.
I think you can close anyway as I think the issue is that the mirror is out of sync and that causes bad dependency conflicts preventing karma ever starting.
I have raised this on the velocity meteor reop https://github.com/meteor-velocity/meteor/issues/9
I don't know what is involved in the upgrade, happy to help there if I can.

Thanks, closing this issue.


Validator argument should be callable.

If user supply validator argument to the Argument or Variable placeholders we should check if passed thing supports callable interface.

Superseded by #722


Moving project to another maintained repository

Hi everyone,
As you saw in PR section, this package is no longer maintained so we forked the repository there:
https://github.com/UnlyEd/serverless-env-copy-plugin
We have made changes, such as renaming the plugin (was confusing) and fixed some of the open PR reported here.
We are open for changes and pull requests, don't hesitate to share your thoughts there.
Let's bring this plugin to life and improve it !

@Demmonius Would be nice if Issues were enabled

@Lusitaniae Issues and discussions were enabled just now!


SP5 Scatter Plot: Performance decreases in version 5.0.11

Bug Report
Issue: In the 5.0.10 version I can easily plot 1000 Scatter plots with 1000 points each with around 4FPS
All higher version take literally forever. Performance drastically detoriates after more than 100 Scatter plots
Reproducing: (What do others have to do to reproduce the bug?)
// a code sample may improve communication
var rnd = new Random();
int numberOfPlots = 1000;
int max = 1024;

WpfPlot1.Plot.Clear();

for (int n = 0; n < numberOfPlots; n++)
    // XYPlot data
    double[] dataX = new double[max];
    double[] dataY = new double[max];
    for (int i = 0; i < max; i++)
    {
        dataX[i] = i;
        dataY[i] = 1000.0 * rnd.NextDouble();
    }

    // ScottPlot
    var scatter = WpfPlot1.Plot.Add.Scatter(dataX, dataY);
    scatter.MarkerStyle.IsVisible = false;
    scatter.LineStyle.Width = 1.0F;
    scatter.LineStyle.Pattern = LinePattern.Solid;
    scatter.LineStyle.AntiAlias = true;
}

WpfPlot1.Refresh();

System Details

ScottPlot Version: 5.0.11 Beta and higher
Operating System: Windows 10)
Application Type:  WPF
.NET Version: (NET Framework 4.8)

FYI, here's a full reproducible code sample for WinForms, and yeah the performance is awful... 15x slowdown!

ScottPlot 5.0.10
ScottPlot 5.0.13

0.242 sec
3.688 sec

using ScottPlot;

namespace Sandbox.WinForms;

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();

        int pointsPerPlot = 1024;
        int numberOfPlots = 1_000;

        for (int n = 0; n < numberOfPlots; n++)
        {
            double[] dataX = Generate.Consecutive(pointsPerPlot);
            double[] dataY = Generate.RandomWalk(pointsPerPlot);

            var scatter = formsPlot1.Plot.Add.Scatter(dataX, dataY);
            scatter.MarkerStyle.IsVisible = false;
            scatter.LineStyle.Width = 1.0F;
            scatter.LineStyle.Pattern = LinePattern.Solid;
            scatter.LineStyle.AntiAlias = true;
        }

        formsPlot1.Plot.RenderManager.RenderFinished += (s, e) =>
        {
            Text = formsPlot1.Plot.LastRender.Elapsed.ToString();
        };
    }
}

I found that what is happening is that when coordinate range was split into separate objects in 30f83a5470c230d09271482ad07626eb95a1e1f9 that the render system is getting confused about whether or not axis limits have been set and it's running "AutoScale()" before every frame, resulting in the bottleneck.


add support for filter specified file

Describe the PR
add support for filter specified file

@tengzhuofei is this PR related to any issue?


Bluetooth causes NativeScript app to crash on ios 14.1

After running:
>> ns run ios

When calling bluetooth is enable in the app:
this.bluetooth.isBluetoothEnabled().then(
          function(enabled) {
            console.log("Enabled: " + enabled);
          }
);

NativeScript app crashes with error:
"Running performTccCheck CBManager tccAvail 1, tccRequired 1
TCC required
This app has crashed because it attempted to access privacy-sensitive data without a usage description.  The app's Info.plist must contain an NSBluetoothAlwaysUsageDescription key with a string value explaining to the user how the app uses this data."
I've already added (with description) in info.plist:
Bluetooth Always Usage Description
Still did not fix the issue....
Any suggestions?

@jthompson-ceres look at the doc there are new descriptions you need to add (don't have my computer around)

@farfromrefug (this is jthompson-ceres)
Which docs are you referring too? Apple?

@farfromrefug ahhh found the issue!
I was adding the key to the wrong info.plist
Adding it to App_Resources/iOS/Info.plist does the trick.
According to the NativeScript docs here:
https://docs.nativescript.org/tooling/publishing/publishing-ios-apps#example-1-how-to-customise-infoplist__

There's another issue here I found in another user's app:
https://github.com/NativeScript/NativeScript/issues/8999#issuecomment-722111181

@NathanWalker thanks good.find but weird one :)

published 3.0.7 with build.xcconfig


Include links to prefix.dev for each conda package

conda-forge packages can be found in links like these: https://prefix.dev/channels/conda-forge/packages/certbot
Something like the following

Explicit dependencies

Dependency[^1]
Before
After
Change
Environments

certbot
2.10.0
2.11.0
Minor Upgrade
default on all platforms

gh
2.52.0
2.55.0
Minor Upgrade
bump on all platforms

hclfmt
2.21.0
2.22.0
Minor Upgrade
lint on all platforms

[^1]: Bold means explicit dependency.

The question is how to figure out if a package is from conda-forge (then the link will work) or not.
We could try to read pixi.lock for this.

with the new pixi json output format that includes the full URL, we could filter out conda-forge packages
https://github.com/pavelzw/pixi-diff-to-markdown/blob/d291124ada1252b7c61ca1a669e36970944af2b5/tests/resources/diff-example-v6-lockfile.json#L16


Add mandatory person attributes

Fixes #457, fixes #283.

Coverage remained the same at 60.521% when pulling d0077267548022c76aa87f91a65ec1c338101cbb on ynurmahomed:fix-provenience into d5364fa29f636c5be6f6a3342fc15f2b989727f2 on esaude:master.


Clean-up and bug fix

New features added, please review.
I took out time to clean up some unused imports in various components files.
However, I only comment them out, expecting each developer to finally delete the import not necessary.
Meanwhile, for separation of concerns, we should try to separate custom components, in a different Javascript file and then import the same to the target component script.
I did a few examples to illustrate this.

Ok, i understand you. its actually very important you brought this to our notice


Updating Holographic samples to use a font supported by the HoloLens.

"Consolas" is used in these Holographic samples, but the font does not appear to be supported on the HoloLens (at least through DirectWrite). These samples end up displaying as the fallback/recommended font, which is "Segoe UI".

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: magnusmaynard sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Productize Approval Tool

This is planned in scope of https://github.com/servic ecatalog/oscm-approval/issues/31


Drying up swagger_api_root

Is there a way we can dry up swagger_api_root?
Defining:
key :swaggerVersion, '1.2'
key :apiVersion, '1.0.0'
key :basePath, ...

everytime, feels a bit messy.
It would be more convenient if you could define it one place and extend it/override it. Any thoughts on how to do this?

How I currently do this in a Rails app is with an initializer and a constant, like:
# initializers/swagger_setup.rb:
SWAGGER_CONFIG = {
  swagger_version: '1.2',
  api_version: 'v1',
  # TODO: make this dynamic based on the current host.
  base_path: 'http://localhost:3000/api/v1',
}.freeze

# controllers
swagger_api_root :users do
  key :swaggerVersion, SWAGGER_CONFIG[:swagger_version]
  key :apiVersion, SWAGGER_CONFIG[:api_version]
  key :basePath, SWAGGER_CONFIG[:base_path]
  key :resourcePath, '/users'
end

It looks like they've addressed this in Swagger 2.0 :+1: because the spec is now a single file and the root object has a single swagger key. So as soon as #8 lands, you'll be able to DRY this up with an upgrade to the new spec, so I'm going to close this in preference for Swagger 2.0.

Perfect, thanks! :+1:


gulp-utils is deprecated, update to use specific packages.

Replace gulp-utils things with packages as detailed at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

@trusktr
Thanks for your help but this PR is a duplicate of #137. Could you close it?


Add constexpr keyword to lots of small functions where possible

Codecov Report

Merging #451 into master will increase coverage by 0.17%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   84.94%   85.11%   +0.17%
==========================================
  Files          40       39       -1
  Lines        6342     5455     -887
==========================================
- Hits         5387     4643     -744
+ Misses        955      812     -143

It's very unclear to me why the code coverage would have changed due to this PR.

I re-run the bottom 4 tasks on travis-ci. They send codecov reports.
Sometimes some of them seems to fail to send report and it is NOT logged.
Perhaps codecov has time limit from the first report receiving to the last report receiving.
To be honest, I don't read much the codecov document. I just modify some example.
Here is codecov report code:
https://github.com/redboltz/mqtt_cpp/blob/master/.travis.yml#L102-L107
I guess that we can improve it.

Recovered by re-run bottom four builds. - Coverage   84.94%   84.93%   -0.01%

Still weird that the coverage decreased even though I removed an unused function. Oh well.

Either way, I think this code is ready to merge.
Let me know if there's anything you want me to change.

Looks good to me. Thanks.


Please invite me to the GitHub Community Organization

Name
Yousuf Ejaz Ahmad
Discord Username (if applicable)
Sukuna#7190
Additional Context
I like the premise of the idea upon which the organization is based. I would like to support such a community and would love to be a part of it.

@Yousuf-Ejaz

Check your email or organisation page
Thank you for contribution 🙂
Please contribute in Unique-Github-Profiles

@Yousuf-Ejaz
Contribute in Unique-Github-Profiles


feat: Implement of increments and decrements

This PR is related with #517 and it contains Incr, Dncr, IncrBy and DncrBy.
The different methods rely on the same methods. The main logic as following:

Get value from bucket with checking if it has been expired
Try to convert value from string to int64. Use big int addition if it has over range of int64
Judge if the value will over range after addition. Use big int addition if yes.
Do addition as int64
Delete the old value and put the new value

And the follow is another proposal:
I think we can abstract a Value to replace []byte of code. We can do more with Value, such as type assertion, more powerful additions when it's a numeric value and so on.

You can open an issue to talk about your plans for Value in detail😁

@bigboss2063 I have do some modifications for review. I will open an issue after refining my ideas about Value

Welcome to do more tasks!😁


rquickshare: init at 0.7.1

Description of changes

added rquickshare, making the airdrop alternative for android and windows available on linux/nixos
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Aleksanaa is there a nice way i can check if the desktop file is working (e.g. having it picked up by gnome and clicking it), i currentlly have it added as ((import /home/hannes/Repos/nixpkgs {}).rquickshare) and then impurely update my whole system, which seems like a bad way to add the share output of my derivation to the xdg_path

solved by #311433


Documentation for lumped_port

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug

The syntax of the documentation for the parameters named signal and reference is not correct.
Steps To Reproduce
N/A
Which Operating System are you using?
Windows
Which Python version are you using?
3.7
Installed packages
N/A

@MaxJPRey  what is incorrect in this syntax?

@maxcapodi78 No major issue. I just fixed it.


Catalyst CLI fails to fails at graphql schema generation

We really appreciate the help making Catalyst better. Every issue helps!

No problem! 🙌
Describe the bug
When running catalyst-cli to setup and connect to a store, an error is received and the setup does not complete.
The error is as follows:
➜  Learning npm create catalyst-storefront@latest

◢ @bigcommerce/create-catalyst v0.1.0

? What is the name of your project? catalyst-training
? Would you like to connect to a BigCommerce store? Yes

Please visit https://login.bigcommerce.com/device/connect and enter the code: mf3ftjeh

The code will expire in 30 minutes

✔ Device code authorized

You have reached the maximum number of active storefronts allowed for your plan. Please select an existing channel below, de-activate an active channel, or purchase additional storefront seats in your BigCommerce Control Panel.

? Which channel would you like to use? catalyst

Creating 'catalyst-training' at '/Users/andrew/Developer/Learning/catalyst-training'

✔ Catalyst template cloned successfully
✔ Catalyst components cloned successfully

Using npm

✔ Dependencies installed successfully
✖ Failed to generate GraphQL types: Command failed: npm run codegen
[FAILED]
[FAILED]         Failed to load schema from ./schema.graphql:
[FAILED]
[FAILED]
[FAILED]       Unable to find any GraphQL type definitions for the following pointers:
[FAILED]
[FAILED]           - ./schema.graphql
[FAILED]
[FAILED]         Error:
[FAILED]       Unable to find any GraphQL type definitions for the following pointers:
[FAILED]
[FAILED]           - ./schema.graphql
[FAILED]
[FAILED]     at prepareResult (/Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-tools/load/cjs/load-typedefs.js:82:15)
[FAILED]     at loadTypedefs (/Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-tools/load/cjs/load-typedefs.js:40:20)
[FAILED]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[FAILED]     at async loadSchema (/Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-tools/load/cjs/schema.js:15:21)
[FAILED]     at async loadSchema (/Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-codegen/cli/cjs/load.js:36:24)
[FAILED]     at async /Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-codegen/cli/cjs/codegen.js:190:69
[FAILED]     at async /Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-codegen/cli/cjs/codegen.js:189:56
[FAILED]     at async /Users/andrew/Developer/Learning/catalyst-training/node_modules/@graphql-codegen/cli/cjs/codegen.js:66:17
[FAILED]     at async Task.run (/Users/andrew/Developer/Learning/catalyst-training/node_modules/listr2/dist/index.cjs:979:11)
[FAILED]     at async /Users/andrew/Developer/Learning/catalyst-training/node_modules/p-map/index.js:57:22
[FAILED]
[FAILED]         GraphQL Code Generator supports:
[FAILED]           - ES Modules and CommonJS exports (export as default or named export "schema")
[FAILED]           - Introspection JSON File
[FAILED]           - URL of GraphQL endpoint
[FAILED]           - Multiple files with type definitions (glob expression)
[FAILED]           - String in config file
[FAILED]
[FAILED]         Try to use one of above options and run codegen again.
[FAILED]
[FAILED]

npm ERR! code 1
npm ERR! path /Users/andrew/Developer/Learning
npm ERR! command failed
npm ERR! command sh -c create-catalyst-storefront

To Reproduce
Steps to reproduce the behavior:

nvm use 18.18.1 (also same on 21.6.2)
npm create catalyst-storefront@latest
Follow prompts - attaching to a store

Expected behavior
Local theme should generate correctly
Screenshots

Additional context
Store hash is jk0h5oo6h0

Thank you for the report @AndrewBarber, and apologies that you ran into that issue. This has now been fixed in the latest release of the Catalyst CLI we pushed out just now. Note however that the command to run the CLI is now npm create @bigcommerce/catalyst@latest.


Feature Request: Double Click Selection

Summary of the new feature/enhancement
Double-clicking the text buffer creates a selection encompassing the "word".
The delimiters for what makes a "word" are defined in the settings (described below).
Dragging after a double click maintains the "beginning of the word" anchor but changes the other one.
Settings

Property Name
Type
Description
Default Value

"selectionDelimiters"
array
list of characters used as delimiters
[' ', '/', '\']

Use case: easily select a path or word from the selection.

Proposed technical implementation details (optional)
If possible, have XAML identify double-click. Everything else should be pretty straightforward. The TermControl will work with the Terminal to create the selection. When the event is triggered, we need to check the delimiters from the settings to decide what to select.

Would this support double clicking to select an entire word?  Or just double click to switch to mouse selection mode?

Would this support double clicking to select an entire word? Or just double click to switch to mouse selection mode?

Assuming the window is focused and you're already in mouse selection mode, it should select the entire word (inclusive).

Double click and drag is also important— like current PowerShell, it should be possible to select a line or word and then drag out to encompass more text.

Wow, great job everyone! Could you let me know how I can find out when this change will actually be rolled out?

Since it’s merged to master, you can try it out by building the repo on GitHub today.
For the store update, it’ll be in the next release that’s being tracked with the 0.3 milestone.

Double click does not work when clicking on the first character of a line
(tested in Version 0.3)


enable emojis for rich logging handler

Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[X] Tests
[X] Other

Checklist

[X] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
I didn't do this since it's a small change.
[X] I've added tests for new code.
[X] I accept that @willmcgugan may be pedantic in the code review.

:)
Description
Run logged strings through _emoji_replace so we can use the emoji shorthand in conjunction with rich's logging handler :). Add basic test.

Thanks for the PR, but I'm afraid I'm not keen on enabling emoji code in logging. The emoji isn't going to be replaced in all handlers, and the function to do the replace is fast but not free in terms of cpu.
If you want emoji in your logs my suggestion would be to either copy RichHandler to your own project and customize it, or define a logging Formatter that does the emoji replace. The later is probably better because you could get emoji an all handlers.

Ah that makes sense; I should have looked for a way to do this that didn't involve modifying code first. Thanks for the response and for your work on this great library!


Support for using TeamsInfo without a TurnContext

Is your feature request related to a problem? Please describe.
I'm in the process of porting Polly over from v3 to v4 botbuilder for Teams, and this is a bit of a stumbling block.  We do mostly  out of band communication and api calls for our application into Teams where we do not have a TurnContext to supply to the  TeamsInfo static methods for api calls.
Describe the solution you'd like
Overload method for all the api calls that just takes the params required to make the call.  Looking into TeamsInfo it mostly uses the TurnContext for the service url, conversation id, and the adapter for credentials which can be easily supplied directly to the method calls.
Describe alternatives you've considered
I'm currently going to just extract all the internals of TeamsInfo out into our own helper class to do these calls as described above for our application as needed.
[enhancement]

Hi @brycepolly
Thank you for raising this enhancement request.  However, the TeamsInfo helper is intended to be used from within the bot while processing a message, not for out of band processing.
Apart from duplicating the code, another option is to construct a ConversationReference with the necessary fields, and call adapter.ContinueConversation ...then within the callback you will have access to the context and can use the TeamsInfo as is.

Thanks, unfortunate to hear but I have already abstracted the TeamsActivityHandler and combined in the functionality of TeamsInfo into it so that its usable for us, so not blocked at least.
The structure of adapter.continueConversation seems to not really be async-await and uses a callback instead (even though it returns a promise?), which makes it difficult to work with for error handling forcing me to wrap the entire usage of it in a new Promise in a helper methods to not deal with that throughout our code.
Example
    const result = await new Promise<void>((resolve, reject) => {
      this.adapter.continueConversation(conversation, async t1 => {
         try {
            const updateResult = await t1.updateActivity(updateActivity);
            resolve(updateResult);
         } catch(e) {
            reject(e);
         }
      });
    });

Ideally I would just await the continueConversation and get back the turn context;
const conversationTurnContext = await adapter.continueConversation(conversationInfo);
const updateResult = await conversationTurnContext.updateActivity(foo);

This is a reasonable request and useful in some scenarios.  However, we do not have plans to update the sdk with these helper methods. As such we recommend you use this in your own code.
Closing the issue


[DDW-941]: Table component

This PR implemented table component and updated other components to use it.
YouTrack Ticket
Todos

[x] Implement table component

Testing Checklist

[x] Check table component and other components to see if they are updated properly in reusable way

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

~Please add the component to Storybook~
I will merge this in since the existing components already need more work and I need to press on with the MVP.

Yeah, story for table component was not needed. It's ok to merge without story. Thanks.


[RER433] conda packaging

Original Gitlab Enabler: REF433

This PR introduces the following changes:

add new conda build recipe meta.yaml
add new ci items that

build conda packages
verify conda pacakages
upload conda packages to Anaconda for a tagged release

cannot build a standard conda package with setup.py, need to upgrade setup.py to setup.cfg first before using the conda package recipe.
closing the PR.


Add Gated Embedding Module and Expert Projection Modulation

Work done:

Implemented Gated Embedding Module
Implemented Expert Projection Module

Hey Serhat - made the requested changes. I didn't add a test for GatedEmbeddingModule because it is a trainable layer and I don't think we're planning on having unit tests for those. Happy to figure out a way to add test coverage for that layer though!


Support for Azure B2C?

I have Azure B2C tenants that I would like to provision in other connected directories.
Can I use B2C as a source?

Hi unfortunately provisioning isn't supported for B2C

Any chance you could provide tips or hints on what I may need to supplement or code in a fork that might add this functionality? (e.g. for AAD functionality that isn't yet present in B2C, or just different)

@RedBlue1776  to clarify the Azure AD SCIM client doesn't support B2C tenants. It's work Azure AD needs to do. You wouldn't need to develop a SCIM server differently for B2C. I would recommend posting here to add support for it  https://feedback.azure.com/forums/169401-azure-active-directory?category_id=160596

Hi unfortunately provisioning isn't supported for B2C

Could you expand on this? What exactly does this mean? I am able to provision using an enterprise app in Azure B2C. Is provisioning now supported?

@craigeaw can you elaborate on which "enterprise app" you used? Does this app uses SCIM then??

@craigeaw can you elaborate on which "enterprise app" you used? Does this app use SCIM then??

I used a ServiceNow enterprise app in B2C. We were able to provision users to ServiceNow with no issues. We followed this documentation: https://docs.microsoft.com/en-us/azure/active-directory/saas-apps/servicenow-provisioning-tutorial

@dalbani We just found out that on-demand provisioing is possible. However, the provisioning service is not supported. As soon as you turn on and enable provisioning you get this error:
Provisioning has been quarantined. See quarantine details for more information.
Quarantine details:
User provisioning is not supported for your tenant, which is most likely an Azure Active Directory "B2C" tenant.
Thanks Microsoft. Could you please disable provisioning entirely if it's not supported so we don't waste time setting it up?

@craigeaw Did you manage to figure out how you could provision users? I'm currently researching this and have been looking at B2B and B2C. I'm looking into how SAML SSO and SCIM provisioning can be integrated into a public-facing web portal that we develop and host. We currently hold the users on our database but the clients would like to be able to manage and have these users on their active directory. So it seems like this use case is more fitted to a B2C tenant but what I'm trying to achieve doesn't seem to be supported with B2C

@craigeaw Did you manage to figure out how you could provision users? I'm currently researching this and have been looking at B2B and B2C. I'm looking into how SAML SSO and SCIM provisioning can be integrated into a public-facing web portal that we develop and host. We currently hold the users on our database but the clients would like to be able to manage and have these users on their active directory. So it seems like this use case is more fitted to a B2C tenant but what I'm trying to achieve doesn't seem to be supported with B2C

The provisioning service is not supported for B2C. I could only provision manually using SCIM in B2C (one at a time). This was not a viable option so we set up JIT provisioning with the app.


Clarify that persistent notifications is in Professional/Enterprise plans

Add a note that Persistent notifications is in Professional/Enterprise plans.

Thanks @amyblais!


Calling graphics folks: anyone want to brainstorm logos / designs?

We're eventually going to need some sort of a logo/theme.
Given the name of the site and the theme -- "Casting a Wider .NET", I think we have a good direction to start playing around with initially.
If anyone wants to draft something or start kicking around ideas for logos, etc. that combine .NET with that theme of casting a wider net, I'd love to see some discussion here.
No rush -- we still have a while to go -- but it's never too late to start kicking ideas around.

/cc @RyKilleen.

the theme of nodes and lines has become really common place theses days, but I think in this case could be used to both visually represent an open net, while also graphing out what an open source community looks like. Crude suggestions coming shortly.


Azure leaking resources when instances failed to be created

User Story
When users create a machine in azure cloud provider, NICs and Discks are created before the vm is created. If the VM failed to be created the machine controller won't start cleaning up the left behind resources.
Acceptance Criteria

NICs, Disks and any other VM resources should be deleted after machine being deleted
Machine Controller should clean up the machine even if the VM is not found(this is the source of the bug).

If there was a vm stuck in deletion, Azure won't allow us to delete any resources that are attached to the stuck vm. Thus, this is a limitation from Azure cloud provider and we have to comply.
Adding a documentation for this workflow and close the issue

https://github.com/kubermatic/docs/pull/586


Is this project still active?

It's been months since the latest release..
I don't know if blender developers are working on an integrated hydra add-on, would be cool tho

Yes, you can track the development we are assisting blender with here:  https://developer.blender.org/T100892

Great to know, thanks!
Would be great to have that information in the README