Recording violations with non-binary audit criteria

On Fuchsia, we'd like to record crate audits for UB risk on a scale from 0 (no unsafe code) to 4 (hard to avoid UB). We have that set up like this:
[criteria.ub-risk-0]
description = "..."
implies = "ub-risk-1"

[criteria.ub-risk-1]
description = "..."
implies = "ub-risk-2"

[criteria.ub-risk-2]
description = "..."
implies = "ub-risk-3"

# ...

Which works well, we can record our audits by picking the strictest criteria that a crate satisfies. However, this makes it tricky to record violations:
# `foo` is ub-risk-2, which implies ub-risk-3 or more and NOT ub-risk-1 or less
[[audits.foo]]
criteria = "ub-risk-2"

[[audits.foo]]
violation = "ub-risk-1"

[[audits.foo]]
violation = "ub-risk-0"

Right now, it looks like we'll have to record violations at every lower ub-risk- level than the one we signed off on. Ideally, we'd be able to opt into contrapositivity with implies: "ub-risk-0 implies ub-risk-1" also means that "not ub-risk-1 implies not ub-risk-0". That would bring us down to needing a single extra violation, which would be easier to handle.
If we could do that, then it would also be helpful for us to record the violation along with the criteria like:
[[audits.foo]]
criteria = "ub-risk-2"
violation = "ub-risk-1"

Ah interesting. So the idea here is that cargo-vet should apply modus tollens on implies relationships, and generate implicit violations for implying criteria? That seems sensible: a safe-to-run violation should imply a safe-to-deploy violation as well. I honestly would have thought we did that already, though honestly we've never used violation much.
I imagine it should also be pretty straightforward to allow criteria and violation to exist in the same audit entry.
@mystor WDYT?

I did some testing and it seems that safe-to-deploy and safe-to-run already have a modus tollens relationship:
first/supply-chain/audits.toml
[[audits.byteorder]]
who = "David Koloski<EMAIL_ADDRESS>criteria = "safe-to-run"
violation = "^1.4.3"

second/Cargo.toml
[package]
name = "second"
version = "0.1.0"
edition = "2021"

[dependencies]
byteorder = "=1.4.3"

second/supply-chain/config.toml
[imports.first]
url = "http://localhost:8000/supply-chain/audits.toml"

[policy.byteorder]
criteria = "safe-to-deploy"

[[exemptions.byteorder]]
version = "1.4.3"
criteria = "safe-to-deploy"

This yields the error we'd expect:
$ cargo vet check
Violations Found!
  byteorder:1.4.3
    the exemption 1.4.3
      criteria: ["safe-to-deploy"]
    conflicts with foreign (first) violation against ^1.4.3
      criteria: ["safe-to-run"]
      who: David Koloski<EMAIL_ADDRESS>
However, swapping these for custom criteria:
first/supply-chain/audits.toml:
[criteria.safe-to-deploy-2]
description = "safe-to-deploy"
implies = "safe-to-run-2"

[criteria.safe-to-run-2]
description = "safe-to-run-2"

[[audits.byteorder]]
who = "David Koloski<EMAIL_ADDRESS>criteria = "safe-to-run-2"
violation = "^1.4.3"

second/supply-chain/audits.toml:
[criteria.safe-to-deploy-2]
description = "safe-to-deploy"
implies = "safe-to-run-2"

[criteria.safe-to-run-2]
description = "safe-to-run-2"

second/supply-chain/config.toml:
[imports.first]
url = "http://localhost:8000/supply-chain/audits.toml"

[policy.byteorder]
criteria = "safe-to-deploy-2"

[[exemptions.byteorder]]
version = "1.4.3"
criteria = "safe-to-deploy-2"

Passes the check:
$ cargo vet check
Vetting Succeeded (1 exempted)

But also unexpectedly passes if the criteria is set to safe-to-run-2 as well. Perhaps a bug? I'll try and minimize.

This error with safe-to-deploy-2 and safe-to-run-2 is happening because unlike the built-in criteria, custom criteria are not identity-mapped into the local namespace by default. You need to add a [imports.first.criteria-map] table mapping the criteria to local criteria in order to catch the relevant errors. Something like this could work:
[imports.first]
url = "http://localhost:8000/supply-chain/audits.toml"

[imports.first.criteria-map]
safe-to-deploy-2 = "safe-to-deploy-2"
safe-to-run-2 = "safe-to-run-2"

You can also use this to change how criteria are mapped for the default criteria, though there is an identity mapping by-default.
In terms of your original request around combining violations and audits into a single criteria, this would be potentially possible, but not the easiest to implement, as we currently always require only one key, and don't allow combo entries like this. If we did add something like that, it'd also be odd as the violation field for most violation entries is a VersionReq to specify a range of versions, rather than a criteria to add a violation for. Overloading the meaning like that feels a bit confusing.
It would be interesting to learn more about how you want to use violations for these ub criteria. Right now our story around violations is one of the weakest stories (as others haven't had a use for them yet, so they haven't been exercised much), and it'd be good to learn more about how people who want to use them expect them to act.

If I had to guess, I might interpret the goal here to be to affirmatively record the discovered UB issues and ensure someone else doesn't come along and patch the audit hole with a less-careful review. If that's the case though, you probably also want to do the work to specify a full version range rather than limiting the violation to the precise version you audited. Otherwise, it won't apply to the next trivial point release, even though the issue is almost certainly still there.

That bisection facility seems reasonable to add, feel free to file an issue for it.
I'm also curious as to whether eagerly determining the violation range is the optimal process for you, or whether that's just an artifact of the cargo-vet workflow which we could consider improving. It seems to me that it might be enough to say "at least some versions of crate foo are ub-risk-3, including version X we considered importing" — and then defer the question of whether the problem exists in version Y to the moment where somebody actually tries to import version Y. Would this be preferable?

Hm, I think that would actually be very helpful. If we could just say "a violation was introduced at some point between  and ", then that would be sufficient for us. Maybe that could be used to prioritize which crates to audit using cargo vet suggest? I think doing the version bisecting upfront doesn't do us too much good unless we plan to use some intermediate crates.


Integration broken for Redis

I've set this up as described in the docs, except for putting broker.startup and broker.shutdown in the FastAPI lifespan function rather than in the startup and shutdown decorated functions.
It works fine with InMemoryBroker: I start FastAPI, then kiq a task either from a separate script or somewhere in my app (like a FastAPI router) and receive a result. When I use ListQueueBroker, I get nothing. However, if I run the ListQueueBroker without the FastAPI integration, as it's own script, it works fine.
Additionally, I get a warning if I use the result_backend arg for the ListQueueBroker, so instead I use .with_result_backend, as the warning indicates (see below).
# broker.py
from taskiq import InMemoryBroker
import asyncio
from taskiq_redis import RedisAsyncResultBackend, ListQueueBroker
import taskiq_fastapi

url = "redis://<IP_ADDRESS>:6379"

redis_async_result = RedisAsyncResultBackend(redis_url=url)
broker = ListQueueBroker(
    url=url
    # result_backend=redis_async_result,
).with_result_backend(redis_async_result)

taskiq_fastapi.init(broker, "app.main:app")

@broker.task
async def add_one(value: int) -> int:
    return value + 1

async def main():
    await broker.startup()
    task = await add_one.kiq(1)
    result = await task.wait_result(timeout=2)
    print(f"Task execution took: {result.execution_time} seconds.")
    if not result.is_err:
        print(f"Returned value: {result.return_value}")
    else:
        print("Error found while executing task.")
    await broker.shutdown()

if __name__ == "__main__":
    asyncio.run(main())

# app.py
@asynccontextmanager
async def lifespan(app: FastAPI):
    if not broker.is_worker_process:
        print("Starting broker")
        await broker.startup()

    yield

    if not broker.is_worker_process:
        print("Stopping broker")
        await broker.shutdown()

app = FastAPI(
    debug=settings.DEBUG,
    lifespan=lifespan,
)

and then uvicorn app.main:app or however you like starting FastAPI

so this works:
> taskiq broker:broker
> python broker.py

and this doesn't:
> uvicorn 'app.main:app'
> python broker.py

Hi and thanks for your interest in this project. Your code listing works as expected. I guess you just a bit mislead by the documentation. The main function in your broker.py file just starts up the broker and sends a task. Nothing more.
The FastAPI integration executes all startup and shutdown events of your application during startup and shutdown of your workers. This is helpful, because it allows you to use the same dependencies as in your handlers in taskiq tasks and also, it automatically resolves all tasks used in your application, so you don't have to import them manually.
To verify that everything is working, let's create the endpoint where we call the task you've defined.
@app.get("/")
async def index():
    task = await add_one.kiq(1)
    result = await task.wait_result(timeout=2)
    return {"res": result.return_value, "time": result.execution_time, "is_err": result.is_err}

Then you need to start both application and workers.
uvicorn 'app.main:app'
taskiq broker:broker

After that, if you send GET / request to your application, the task is going to be sent to workers.
I hope that it helped you to gain more understanding of how to use the project. If you have any ideas how we can improve the documentation, please tell us. We want our library to be as easy to use and accessible as possible.

So, all tasks are executed on workers to offload the CPU of your application. That's why, when you call  uvicorn app it won't be able to handle tasks. It's intentional.
But, if you really want to spin up actual task listeners along with your application, we got you covered. You can read more about such setups here: https://taskiq-python.github.io/guide/dynamic-brokers.html
But I would try to avoid this, because it introduces more load on CPU and network for each application's instance, and it loses cool feature of self-healing that workers can do if something will go wrong with network or redis connectivity.

🤦  thanks!


On google colab

Hi man, thanks for the cool package, I have been looking at executing your work on google colab. This is probably the closest I have come to getting it to work, could you perhaps let me know how you think this can be run, I have linked to an editable notebook. https://colab.research.google.com/drive/1KkRB3W1yV26AsMNJxA8-WWbs7FPeoyCh?usp=sharing

Hi @firmai, I dug into this and realized that the ESG Ratings Corporate Search Tool that this package scrapes unfortunately does not have any data on Apple, seen here: https://www.msci.com/our-solutions/esg-investing/esg-ratings/esg-ratings-corporate-search-tool/issuer/apple-inc/IID000000002135451
To address this, I've updated the documentation to use TSLA as the example stock, and I'm updating the exception handling to provide a more informative message when a KeyError or NoSuchElementException is reached, saying that this given stock may not have data on the Corporate Search Tool.
Thank you for creating this issue! It's cool to see someone using the project!

Updated example, first attempt is using "AAPL" as the symbol argument, second is using "TSLA" as the symbol argument:
(venv) Austins-iMac:TESTING huntaj$ python test.py
MSCI ESG Ratings Corporate Search Tool may not have data for the stock AAPL.  To verify this, open https://www.msci.com/our-solutions/esg-investing/esg-ratings/esg-ratings-corporate-search-tool and search for your stock to see if the resulting page contains data.
average
{}
(venv) Austins-iMac:TESTING huntaj$ python test.py
average
{'rating-paragraph': 'Tesla is average among 40 companies in the automobiles industry.', 'rating-history-paragraph': "Tesla's rating remains unchanged since April, 2019.", 'current': {'esg_rating': 'a', 'esg_category': 'average'}, 'history': {'jul-17': 'aaa', 'apr-18': 'aa', 'aug-18': 'aa', 'apr-19': 'a', 'apr-20': 'a'}}

@austinjhunt thanks for the quick update, I am looking forward to playing around with the data, cheers.


Documentation: Restart cilium-operator and cilium after enabling Service Mesh

The EnvoyConfig CRDs are not created until the operator restarts, and cilium does not begin processing the new CRDs until it's been restarted.
Documentation: Restart cilium-operator and cilium after enabling Service Mesh

This is needed for the v1.12 release

Can you make the commit message a little bit shorter for CI :heavy_check_mark: ?
https://github.com/cilium/cilium/runs/7224507895?check_suite_focus=true
  NOTE: Ignored message types: C99_COMMENT_TOLERANCE COMMIT_LOG_LONG_LINE COMMIT_MESSAGE COMPLEX_MACRO CONSTANT_CONVERSION CONST_STRUCT EMAIL_SUBJECT FILE_PATH_CHANGES FROM_SIGN_OFF_MISMATCH GIT_COMMIT_ID JIFFIES_COMPARISON LEADING_SPACE LONG_LINE_COMMENT MACRO_WITH_FLOW_CONTROL MULTISTATEMENT_MACRO_USE_DO_WHILE NOT_UNIFIED_DIFF PRINTK_WITHOUT_KERN_LEVEL TRAILING_SEMICOLON TRAILING_STATEMENTS VOLATILE
  Error: ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 77)


download-binaries in 2.0.0-rc.6

Hello,
the download-binaries is not working for me. I have this in my Cargo.toml:
[dependencies.ort]
version = "2.0.0-rc.6"
default-features = false
features = ["download-binaries", "copy-dylibs", "load-dynamic"]

but I am getting runtime error:
thread ... panicked at /home/beda/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ort-2.0.0-rc.6/src/lib.rs:130:33:
An error occurred while attempting to load the ONNX Runtime binary at `libonnxruntime.so`: libonnxruntime.so: cannot open shared object file: No such file or directory

I have done some debugging of the build script and found that libonnxruntime.a is downloaded but I don't see libonnxruntime.so anywhere:
beda@notebook:lib$ pwd
/home/beda/.cache/ort.pyke.io/dfbin/x86_64-unknown-linux-gnu/C718EFE9677E093BCD986A27EBE83BDDD0DAFD6967FAFB0DE311A239D27F4A71/onnxruntime/lib
beda@notebook:lib$ ls
libonnxruntime.a

I am upgrading from version 1.16.3. That version worked without any problems. Am I doing something wrong? Was there some change in the downloading?

Remove the load-dynamic feature unless you're also using CUDA or TensorRT or a custom build that uses dylibs. The default (CPU) build is statically linked, and load-dynamic configures ort to not link at all.

Thanks for the fast answer, it works.


[http] 42mate/PHRequests

I'm using this library for a while and it's been useful to do simple HTTP requests. It uses cURL to make the requests and is easy to consume REST resources.
https://github.com/42mate/PHRequests

There are other libraries that handle web requests which are already listed, so without a good reason, I'll abstain from merging for now. Regardless, thanks for your contribution.


remove pre/post callbacks

See #68 for discussion.
This will also implement #90 and #91

Note that this after all doesn't implement #90 and #91 only partially


[EPIC] Add Spark engine support for Gravitino

Describe the proposal
This epic task tracks the work of adding Spark engine support for Gravitino.
Task list

[x] #1287
[x] #1530
[ ] #1528
[ ] #1529
[ ] #1550
[ ] #1552
[ ] #1549
[ ] #1560
[ ] #1561
[ ] #1562
[ ] #1564
[ ] #1565
[ ] #1573
[ ] #1566
[ ] #1567
[ ] #1568
[ ] #1578
[ ] #1569
[ ] #1570
[ ] #1571
[ ] #1572
[ ] #1574

@FANNG1 please list all your tasks here.

FYI @caican00


Add support for Proscenic air purifier (tested against Proscenic A8) addresses #363 and #195

This addresses #363 to add full support for the Proscenic A8 air purifier:

switch on and off
manual and automatic mode
speed slider sets to one of the three modes and disables automatic mode

The following functionality is not supported:

countdown timer
enable/disable the air quality light (retains manufacturer functionality: sleep mode = light off; all other power on modes = light on)

The following functionality is untested:

child lock
air purifiers other than the Proscenic A8 (but from an examination of the code I do not believe there will be any regression issues)

There is one, pre-existing, known issue:

there is a "Mode" toggle that mirrors the power-on state.  This is present for all air purifiers.

This code contains a tweak to the handling of DP_SWITCH - I observed #195 with the Proscenic A8, and I believe the new logic should address it for all.  It also contains a fix for retrieving the PM2.5 value - this looked like a bug that was always there.
When building and running against my local Homebridge I found that there were some issues in AirConditionerAccessory.js and index.js.  This PR does not contain those fixes so that this change can be applied on any branch.

this is excellent, I inserted to lib folder and for siguro air purifier and solve most of my problems, but I still get [12/10/2022, 2:27:46 PM] [homebridge-tuya] This plugin generated a warning from the characteristic 'Rotation Speed': characteristic value expected valid finite number and received "NaN" (number). See https://homebridge.io/w/JtMGR for more info.
this warnings, no matter what I have looked at it is still warning, device info has this:
"code": "fan_speed_enum",
"mode": "rw",
"type": "Enum",
"property": {
"range": [
"auto",
"sleep"
so there are 5 speeds 1-2-3-auto-sleep, where should I change the code to avoid this error? I am not really interested in the using the fan speed but if I can avoid the error that would be great, of course if I can use fan speed also better but you know what I mean. Thanks a lot @ak6i

@fate8383 Awesome! Please feel free to submit a PR with your changes.

Hi @fate8383 , If you can create a PR with your changes i can get this into 3.1.1 Release :)

I have taken the files from @fate8383 and pushed them as part of 3.1.1-beta.10. @ak6i, are you able to test with this version and config everything looks good from your side?

@05TEVE I've updated this PR to merge the Proscenic support I implemented with the Siguro support from @fate8383 ( and also remove the doorbell support I was working on).  Probably all you need from this is the AirPurifierAccessory.js file.
Offtopic: once this PR is merged, I could take another look at the doorbell support.  It's not great (even Home Assistant doesn't support Tuya video devices) but at least I managed to make it send a snapshot of who rang the doorbell!

Hi @ak6i,
I have merged the PR into 3.1.1 and pushed it live with version 3.1.1-beta.12.
Please have a test and let me know if there are any issues.

Hi @ak6i,
If you have changes to add even basic doorbell support that would be a really nice addition! :)

Hi @ak6i, If you have changes to add even basic doorbell support that would be a really nice addition! :)

Here's the commit with basic support.  When someone rings the doorbell, you'll get a notification "Someone rang the doorbell." with the picture that was taken.  The video stream doesn't work (the means to authenticate with Tuya is too much of a PITA to implement) so you'll always see the last picture that was taken when you go to that camera in the Home app, and there's no audio so you can neither hear nor talk to them.  But at least you get a picture so it's easy to ignore callers you don't want to answer  ;)
Also, I have only tested it on the Virone VDP-65.  As with all Tuya stuff, other manufacturers may implement things differently.  But feel free to try it out.  And sorry for the delay in replying!

Hi @ak6i, these changes look good for the Doorbell. Would it be possible for you to raise another PR with the changes for the Doorbell into the 3.1.2 Branch?


New command: Get theme of site

Usage
I don't see any command to get the theme of a site. The usage should be something like this:
o365 spo theme get --webUrl https://xxxx.sharepoint.com/sites/xxxx
This command should respond with the theme of the site.

Hi @sergiosanchezd thank you for your suggestion, I've taken a quick look at how this could be implemented.
There is a ThemeInfo resource on the Web endpoint (_api/web/ThemeInfo) however unfortunately this doesn't appear to give much information about the applied theme apart from a description, the title and name properties returned are empty.
There is a ThemedCssFolderUrl resource on the Web endpoint (_api/web/ThemedCssFolderUrl) however unfortunately this only returns a URL which also doesn't give any indication of the theme applied, the URL returned will be something like /_catalogs/theme/Themed/DFC52C80.
I'm not aware of any other resources that could provide the information that would make this command usable.
Any ideas @pnp/office-365-cli-maintainers ?

This command should respond with the theme of the site.

Would you expect this command to return the currently applied palette (basically what you upload when setting a theme)?

Hi, yes, this is my suggestion.

As far as I can tell, there is no ready to use API for this. We'd need to dissect the SharePoint UI and see how it does that. @garrytrinder already said that there is a property that contains the path to the current theme folder but the question is what's after that. Would you be interested in investigating this @sergiosanchezd?

Hi, I investigated a little bit, and I am not sure if it will be possible to get the theme name of a site. In the first instance, the UI doesn't give you that information. For example, if you have 3 company themes, in the themes you have the title, but in the theme that you have selected you don't have the title, it puts "Current selection".
In another way, I see that SharePoint calls to an endpoint to get your "Company themes" and here you have the title, but it is not selected any of that. The endpoint is "https://xxxxx.sharepoint.com/sites/xxxxx/_api/ThemeManager/GetTenantThemingOptions"

Maybe we can get the theme palette but not the title of the theme: https://docs.microsoft.com/en-us/javascript/api/sp-component-base/themeprovider?view=sp-typescript-latest

You're looking at SPFx which is not something that we use in the Office 365 CLI. Perhaps a better path would be to look at the REST/CSOM APIs exposed in Office 365 which we could tap into to extract some meaningful information.

Closing due to lack of response


If enemy hurt, send aggro signal

This sends a signal if an enemy gets shot at that they should move
into attack mode. Closes #40.
Please check if the PR fulfills these requirements:

[x] The commit message follows our guidelines.
For bug fixes and features:

[x] You tested the changes.
[ ] You updated the docs or changelog.

Thanks!


Adding mergeTwoObjects snippet

Hello @Chalarangelo
The snippet that I've submitted is another approach to tackle the merge of two objects, they are not the same. Maybe I can update the actual merge post if is okay for you and if you can tell me what was the guidelines that I broke due seems to me look okay.
Thanks.


Should Line/Polygon/Path points be absolute or relative to position ?

Points of a Line object have absolute position. That way, in order to draw a polygon between 3 shapes, it's easy to write:
const line = new Polugon([
	shape1.position,
	shape2.position,
	shape3.position,
]);

This means that moving one position don't change the others.
In the other hand, relative position could allow to move the polygon position and keep the polygon shape.

Relatives points allow shapes to be easily draggable by only modifying shape's position.

Fixed by f750ca8


Exclude babelrc in the npm package

Excluding the babelrc file in the npm package would allow upndown to be used in project using a different babel version

upndown is meant to be used as an npm package, and not as the basis for another project.
Just  create a package.json, install upndown and require it in node. You'll be able ti use whatever .babelrc file you want then.


Compute Distribution Day count for major indexes

Distribution days mark when market is .2% lower or more than day before with heavier volume than day before. Utilizes daily chart. Looks at last [30] days. Compute for major indexes (DIA, SPY,QQQ)

get_Market_Health is pulling wrong dates for data. SHould be pulling most recent

Logic was wrong and for loop started and stoppd at wrong indexes


Nix cache enhancement in CI and ping clang-tools version to 17.0.6

Re-ping clang-tools version to 17.0.6 as #228 is reverted in #230

Solve nix cache issue on CI

magic-nix-cache somehow doesn't work on ec2 instances
magic-nix-cache runs into GH rate limit easily
replacing magic-nix-cache to cache-nix-action which is a wrapper over gH official actions/cache.
for adopting cache-nix-action, GH shared runner needed to install nix in single user mode
now nix cache is split by os/arch/nix shell/nix install mode/hash of nix files, for avoiding cache pollution
cache is sharable among branches, since we suffix cache by hash of nix files, it should be safe to share among branches

ci nix shells are adjusted accordingly

ci: native shells
ci-cross: native shells + cross compiled gcc and glibc
ci-cbmc: ci shell + cbmc
ci-cbmc-cross: ci-cross shell + cbmc
default, ci-linter: stays as it was, not changed

Since ci and ci-linter shells don't require long build time, everything is cached in public cache server, jobs that uses these shells should disable cache function, to avoid reaching GH cache storage limit (10 GB)

Currently built caches are:

Linux-ARM64-ci-cross-...: built and used by GH shared arm64 runners
Linux-X64-ci-cross-...: built and used by GH shared x86_64 runners
Linux-X64-ci-cross-multi-...: built and used by x86_64 ec2's
Linux-ARM64-ci-cbmc-cross-multi-: built and used by arm64 ec2's which runs cbmc proofs

Yes indeed, I will investigate this further, so please don't merge this PR yet!

Ok, I found https://github.com/NixOS/nix/issues/4653 which explained that authenticated requests have higher rate limit, and that putting the token in nix.conf is the recommended way to proceed.


fix: enable TLS on secure connections

Testing the otel-cli against a service exposed with https, we detected that the connection is closed. The current PR adds the dial option to negotiate an https connection in case you connect to a remote endpoint and you do not set --insecure=true flag.

@ahayworth I don't want to let this linger and could use some advice. Should I merge this as-is and follow up PR the aesthetic updates, or commit to this PR and merge when it's ready? I'm a bit rusty on maintainer protocol 😅

@tobert I think it's perfectly fine to merge as-is!


no-flags-array should ignore buildFlagsArray

I just noticed that buildFlagsArray gets flagged by no-flags-array (https://github.com/NixOS/nixpkgs/pull/112814#issuecomment-777767848). Even thou it is valid I think we want to ignore that or change buildGoModule to use nix instead of bash.

Well, Go packages are precisely what lead me to introduce the check in the first place (see https://github.com/NixOS/nixpkgs/issues/112054). As soon as someone adds a second flag, the whole thing will break.

Alternative would be only showing the error once there is actually more than one flag since it technically works with a single one.

Alternative would be only showing the error once there is actually more than one flag

Doing this would be good for now until we come up with a proper fix for buildGo{Module,Package}.


rocketpool: 1.12.1 -> 1.13.7

Seems to run as expected. I have not run the complete docker setup with this build.

@ekimber sign the commit :)


How can I use mocha-teamcity-reporter with grunt-webdriver?

I'm trying to figure out how I can use mocha-teamcity-reporter as a reporter, but I'm stuck. Any hints on that? :)

It should work the same way how other reporter work. Try to use the reporter option and pass in teamcity I guess.

I've tried that :) but with no luck. is it possible to pass the --reporter option when I call grunt webdriver? as on https://github.com/travisjeffery/mocha-teamcity-reporter

mocha --reporter mocha-teamcity-reporter test

no unfortunately not .. what exactly happens? Any output? errors?

 the same with mocha-teamcity-reporter

We will be updating grunt-webdriver to use the wdio test runner. If you still need teamcity test reports, please open an issue here. Thanks.


Support using the base image ENTRYPOINT and starting the application through CMD

Some base images (like those provided by Red Hat) have a container ENTRYPOINT that performs some initialization before running the CMD.
The current logic supports figuring out the ENTRYPOINT so it starts the .NET application.
Can the logic be extended so it is possible to choose to start the application using CMD?
cc @baronfel @richlander @omajid @aslicerh

Definitely down for reworking this - the intent here was to simplify for most use cases, but we can definitely make this able to be more explicitly defined. I'm mostly concerned about end-user confusion about the purpose/difference between ENTRYPOINT and CMD. I'd want to make sure that we are super-clear on the happy-path. What kinds of scenarios would you like to be able to support?

I'm mostly concerned about end-user confusion about the purpose/difference between ENTRYPOINT and CMD. I'd want to make sure that we are super-clear on the happy-path. What kinds of scenarios would you like to be able to support?

When a container is running what gets executed is: ENTRYPOINT COMMAND. COMMAND is what the user specifies as podman run <COMMAND>, and defaults to the Dockerfile CMD.
Some images (like Red Hat .NET images), have an ENTRYPOINT script that does some initialization actions before executing COMMAND.
The SDK tooling currently always emits an ENTRYPOINT, which means it skips the entrypoint script from our base image.
This is a request to make it possible to emit a CMD instruction so the entrypoint script does not get skipped.
The default behavior of the SDK can still be to emit an ENTRYPOINT, and have an opt-in to emit a CMD instead. Or, if the tooling wants to be "smart": it can use a CMD when the base image has an ENTRYPOINT.

@baronfel I hope the difference between ENTRYPOINT and CMD are clear, and why sometimes CMD is preferred to  ENTRYPOINT?
Using ENTRYPOINT by default is appropriate. The request here is: a toggle that opts-in to use CMD instead.

Yep - all clear now. Thanks for following up! We'll have to think about what that signal would look like - would the presence of user-added ContainerCommand items be enough of a signal?

We should allow the tooling to figure out the command to start the app also when it is emitted as a CMD.
If I ignore backwards compat, I'd suggest something like:
<ContainerCommand> = command to launch the app
<ContainerCommandInstruction> = Entrypoint
<ContainerEntrypoint> = ContainerCommand when ContainerCommandInstruction == EntryPoint
<ContainerCmd> = ContainerCommand when ContainerCommandInstruction == Cmd

(The assignment show the default values.)

While making some contributions to the container tooling, I've learned the tooling is aware the base image has an entrypoint. It would make sense for the default behavior to be to emit a CMD instruction when there is an entrypoint, and an ENTRYPOINT when there isn't.
Proposal:
<ContainerAppCommand>
<ContainerAppCommandInstruction>

ContainerAppCommand defaults to the exec args required to start the .NET app.
ContainerAppCommandInstruction defaults to use an ENTRYPOINT when the base image has no entrypoint, and CMD when the base image has an entrypoint. It can be set explicitly to Entrypoint/Cmd to force a specific instruction.
@baronfel what do you think?

This proposal seems good to me - we need to consider back-compat though. Existing ContainerEntrypointArgs items should be used as the default for the new ContainerAppCommand item group, and a message/warning should be emitted here describing the new item. Then as you say we should determine Entrypoint-vs-Command during base image inference.


add xgMetNove1 (Metafruticicola noverca)

Assembly review request

ToLID: xgMetNove1
Species: Metafruticicola noverca
Project:  ERGA-BGE
Affiliation: Genoscope

ok

Yes
From: "erga-ear-bot[bot]" @.>
Reply to: ERGA-consortium/EARs @.>
Date: Tuesday 8 October 2024 at 14:08
To: ERGA-consortium/EARs @.>
Cc: Dominic Absolon @.>, Mention @.***>
Subject: Re: [ERGA-consortium/EARs] add xgMetNove1 (Metafruticicola noverca) (PR #88) [EXT]
Hi @DomAbsolon [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DomAbsolon&d=DwMCaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=HMo-nEncpJD-Huct-h6WEs_n6mFGlpSnfDTSEb1TwXE&m=PtA3NN7X-d6u9ditod3bUwcdMoJAteBaTqDjecTZUoNupyRGyqz781V2F0jlUKYB&s=-l1qwFMW2bi9_yED7iYXayKvL3IhBovdS8CYlG2V3F4&e=, do you agree to review this assembly?
Please reply to this message only with Yes or No by 15-Oct-2024 at 15:07 CET
—
Reply to this email directly, view it on GitHub [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ERGA-2Dconsortium_EARs_pull_88-23issuecomment-2D2399800544&d=DwMCaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=HMo-nEncpJD-Huct-h6WEs_n6mFGlpSnfDTSEb1TwXE&m=PtA3NN7X-d6u9ditod3bUwcdMoJAteBaTqDjecTZUoNupyRGyqz781V2F0jlUKYB&s=SON5F14ND_H9uxi_hA0bmN4qwCI9zDRmG9-c7PbWx-Y&e=, or unsubscribe [github.com]https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_BCJBKIG7HQ2QWIR6GCKGG2LZ2PKMNAVCNFSM6AAAAABPSFIKC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZHAYDANJUGQ&d=DwMCaQ&c=D7ByGjS34AllFgecYw0iC6Zq7qlm8uclZFI0SqQnqBo&r=HMo-nEncpJD-Huct-h6WEs_n6mFGlpSnfDTSEb1TwXE&m=PtA3NN7X-d6u9ditod3bUwcdMoJAteBaTqDjecTZUoNupyRGyqz781V2F0jlUKYB&s=8eJqTFZMOk0pCNO_0acH6Joz121fdcF-kUhc00u1EQE&e=.
You are receiving this because you were mentioned.Message ID: @.***>

The Wellcome Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in England with number 2742969, whose registered office is Wellcome Sanger Institute, Wellcome Genome Campus, Hinxton, CB10 1SA.

Hi @DomAbsolon have you had a chance to look through the assembly? I have a few areas where I'm not sure and think you will be best placed to make an informed decisions
I'm not sure about the placement of some of the unlocs, especially at SUPER_2 - could this fit just as well in SUPER_3?
Potential hapdups at the start of SUPER_11 and middle of SUPER_14
Centromeres of SUPER_20 and SUPER_25 appear to be at the end and there is a strong telomere signal in the middle. However based on the Hi-C map I'm not sure where/if to invert or move sequences
Please let me know what you think

and @duprats there are some bacterial scaffolds in the TAPAS map, have these already been removed from the assembly?

Hi,

I had moved  SUPER_21[0.00 bp -- 2.15 Mbp]   to    SUPER_21[13.59 Mbp]

I agree with you on these :

there are still  12  bacterial scaffolds in the TAPAS map, that I must remove   from the assembly
I can suppress 'unloc' tags  on SUPER_2_unloc_1,SUPER_2_unloc_2 ; they look like to be  centromeric regions with contacts  on all chromosomes, but with some more contacts with SUPER_2 (but never mind)
I  wondered too how to invert or move sequences on SUPER_20, SUPER_25 ( but also   Super_23 end Super_26 have telomere signal in the middle  )

(for information , I made around  700 edits on the original map and new haplotigs appears on this map )

I have to say, the HiC data is relatively low quality so this is not an easy curation and makes it hard to say with absolute certainty what if ay changes should be made but I think these are what should be done:
I think the SUPER_2 unlocs are fine, they have raised background signal compared to all the other centromeres.
SUPER_10 flip from ~13,185-15,876
SUPER_11 I think the following needs changing: cut into five blocks
A - Start-4,330
B - 4,330-14,719
C - 14,719-19,697
D - 19,697-27,636
E- 27,636-End
The order then goes B(+) -> A(-) -> D(+) -> C(-) -> E(+)
SUPER_14 flip ~24,084-27,743 then remove one copy of the haplotypic duplication.
SUPER_20 - I think there may be a flip required ~2,421-4,493 although this is not very clear. Regarding the centromere, I think it breaks from ~48,700-End and then this places ~26,667 in reverse orientation.
I think the repeat array on SUPER_21 (first ~2,000 Kbp) should break off and insert ~13,589
SUPER_25 is a similar situation to SUPER_20. Break around 33,771-End and insert that chunk around 18,000 kbp.
SUPER_26 flip from start-31,753
All the coordinates stated are as they appear on the tool tip in PretextView (i.e. Kbp).

Hi @DomAbsolon thank you for looking through the assembly and the thorough review.
Do you have a savestate that you could share? That would certainly speed us along if you have it to hand

Git hub doesn't seem to like save state files so here is a wetransfer link https://we.tl/t-suS1BzJCnN

@duprats hopefully a quick fix for you. If possible, it would be great to see the EAR again by the end of this week

of course ;   but  coverage (for tracks)  is still running

Hi @DomAbsolon
Have you had a chance to look through the updated assembly? I had a look through and am generally happy at the higher-level organisation.
My only query was whether the unloc on SUPER_6 could be placed in reverse orientation at ~8.5Mb:

Let me know what you think. Hopefully we can get this wrapped up and submitted soon.

Hi @tbrown91,
Simone is on vacation this week, so I'll be stepping in to continue her work and aim to finalize the genome by the deadline. I may run into some challenges as I’m not fully familiar with all the specifics of her progress, but I'll do my best to ensure everything is wrapped up on time.
@DomAbsolon , what are your thoughts on the latest EAR?
Thanks!
Lola

Hi, yeah a couple more small changes I think need to be done. As Tom says the super_6 unloc could be placed. I also spotted some small miss placed chunks:

SUPER_4 55,724-56181 moves to ~64,465
SUPER_17 44,967-44,590 should unloc to SUPER_19
Sorry to pick these up only on the second round. The HiC data makes it difficult to spot everything. But after this I think it should begged to go.

Hi @DomAbsolon, @tbrown91,
I’ve made all the requested changes to the best of my understanding, including adjusting the unlocking of super_6 and repositioning SUPER_4 and SUPER_17. I’ve re-run the EAR report generation, and the updated map should be ready tomorrow for a final review.
Thanks again for the thorough review!
Best,
Lola

Hi everyone,
Despite my attempts to take over this genome, it has proven to be too complex, and I believe it’s best to wait for Simone’s return to continue. Given tomorrow's deadline, it won’t be possible to submit this genome on time. I am awaiting Simone's feedback for a final review, and we will submit it once that’s completed.
Thank you for your understanding.
Best,
Lola

Thanks @duprats
I'm pretty happy with this now. Any last thoughts, @DomAbsolon ?

Maybe I am missing something but the version of the EAR I can see, look like it is from 3 weeks ago?

Hello sorry  , I forgot to click on 'commit' !

Hi, I made these edits :/SUPER_6[16.44 - 16.60 Mbp ] => haplotig
/SUPER_10[43.49 Mbp] to SUPER_10[42.27 Mbp]   inverted and moved to       SUPER_10[39.52 Mbp]
SUPER_10[42.27 Mbp] to SUPER_10[39.55 Mbp]   inverted and moved to       SUPER_10[42.33 Mbp]
/SUPER_14 : insert   scaffold_233[0.00 bp-237.94 kbp]        at       SUPER_14[65.94 Mbp]
/SUPER_15[2.56 - 2.46 Mbp]       => haplotig
/tag  scaffold_245    => haplotig with      SUPER_15 [ 396.57 kbp -713.83 ]
/SUPER_18[47.61 Mbp] to SUPER_18[32.33 Mbp] inverted and moved to SUPER_18[32.31 Mbp]  (telomere)
cf   scaffold_182 => SUPER_18_unloc

Looks good

Thank you @DomAbsolon
And thank you for all the hard work @duprats

Thanks  very much for your help


Update a french message to make it more natural

The proposed current sentence is a direct translation of the English sentence. Understandable if you know English, but not natural French.

Thanks for the fix!

(just pushed an update with these changes)


CRM Table Extension with OptionOrdinalValues not possible

Describe the bug
OptionOrdinalValues property is not possible to set on a CRM or CDS Table.
You get the error:
The property 'OptionOrdinalValues' can only be set if the property 'TableType' is set with any of the values of :'CRM,CDS' AL(AL0167)
To Reproduce
Create a Table Extension on a CRM or CDS Table i.e. CRM Contact and add an option field with OptionOrdinalValues.
tableextension 50150 "CRM Contact NVX" extends "CRM Contact"
{
    fields
    {
        field(50150; "AnredeNVX"; Option)
        {
            ExternalName = 'nvx_anrede';
            ExternalType = 'Picklist';
            Description = '';
            Caption = 'Anrede';
            InitValue = " ";
            OptionMembers = " ",Herr,Frau;
            OptionOrdinalValues = -1, 100000000, 100000001;
        }
    }
}

Expected behavior
OptionOrdinalValues are accepted on a table extension on CRM or CDS Table.
Screenshots
5. Versions:

AL Language: 5.0.277602

Business Central: AT Business Central 16.1 (Plattform 16.0.12630.13302 + Anwendung 16.1.12629.12805)

The issue has been fixed and it will be available in CU3 of the Wave 1 2020 release and the next major release.


Fix the grammatical errors in README.md

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm


Allow brew dump and cleanup to run offline

brew doctor output
❯ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  kubernetes-service-catalog-client

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 3.6.20-143-g10845a1
ORIGIN: https://github.com/Homebrew/brew
HEAD: 10845a1122b916dc91d04f00a4d8b7b888d52654
Last commit: 22 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 70d133fdc25baa4aa4d6779bb74e4b4da5804171
Core tap last commit: 23 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: code --wait
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_INSTALL_FROM_API: set
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_AUTO_UPDATE: set
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.39.1 => /opt/homebrew/bin/git
Curl: 7.86.0 => /usr/bin/curl
macOS: 13.2-arm64
CLT: <IP_ADDRESS>.1.1668646533
Xcode: N/A
Rosetta 2: false

What were you trying to do (and why)?
I am trying to run brew dump and brew cleanup
What happened (include all command output)?
❯ brew bundle dump --force --all --formula --taps --whalebrew --casks --mas --describe --file="$HOME/.Brewfile"
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
^C

❯ brew cleanup
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
curl: (6) Could not resolve host: formulae.brew.sh
^C

What did you expect to happen?
Both commands successfully execute
Step-by-step reproduction instructions (by running brew commands)
1. Run `brew cleanup` or `brew bundle dump --force --all --formula --taps --whalebrew --casks --mas --describe --file="$HOME/.Brewfile"`

This seems to be related to https://github.com/Homebrew/brew/issues/14451 and https://github.com/Homebrew/brew/issues/14445

Agreed, the experience here needs to be improved. Thanks for reporting!
In the meantime, setting the HOMEBREW_NO_INSTALL_FROM_API environment variable should allow you to continue using those commands.

Seems like https://github.com/Homebrew/brew/issues/14462 is probably related.

Marking as a duplicate of https://github.com/Homebrew/brew/issues/14451


[Event Request] Table 39 - Purchase Line - OnBeforeValidateJobLineAmount

Dear ALAppExtensions team,
through this issue we would like to request adding event publisher OnBeforeValidateJobLineAmount in Table 39 Purchase Line with the following signature:
[IntegrationEvent(false, false)]
local procedure OnBeforeValidateJobLineAmount(var PurchaseLine: Record "Purchase Line"; var TempJobJournalLine: Record "Job Journal Line" temporary; var IsHandled: Boolean)
begin
end;

which would be called as follows in the OnValidate trigger of field 1005 - Job Line Amount:
trigger OnValidate()
// >>>> New >>>>>>>>>>>>>>>>
var
    IsHandled: Boolean;
// <<<< New <<<<<<<<<<<<<<<<
begin
    // >>>> New >>>>>>>>>>>>>>>>
    OnBeforeValidateJobLineAmount(Rec, TempJobJnlLine, IsHandled);
    if IsHandled then
        exit;
    // <<<< New <<<<<<<<<<<<<<<<

    TestField("Receipt No.", '');
    if "Document Type" = "Document Type"::Order then
        TestField("Quantity Received", 0);
    if JobTaskIsSet then begin
        CreateTempJobJnlLine(false);
        TempJobJnlLine.Validate("Line Amount", "Job Line Amount");
        UpdateJobPrices();
    end;
end;

Thanks in advance!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47054.


instaces processed - not getting updated

Hello,
landscape Label: trail1
Sprint Label: SCPTest-2008A
Scenario Label: SCPTest-eboard
Scenario URL:https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-5-run.html#427fcc75-2f8b-47f7-b7b5-eddd676e83c0
Step 5.1: In the SAP Fiori launchpad, open Monitor Visibility Scenarios application, click Process Data and Refresh to see the new batch of processed events.
Instance processed is not getting updated even after completing the 'task' by clicking confirm in previous step.
Screenshots:

thanks,
Shubham

This issue might occur due to EU10 outage. As it passed in US10 which means there is no problem with the product or the scenario but at times EM fails to send the events to process visibility. This is a known and there is nothing that I can do here.
@thecodester - please close the issue


[Report] - INCORRECT information : The theory is seriously wrong

Context: https://go.dev/tour/concurrency/4
I found the following content that you provided is not correct: The loop for i := range c receives values from the channel repeatedly until it is closed
It’s possible to close a non-empty channel but still have the remaining values be received. This means: the For loop will NOT stop even if the Channel is closed. Here is an example code:
package main

import "fmt"

func main() {

	queue := make(chan string, 3)
	queue <- "one"
	queue <- "two"
	queue <- "three"
	close(queue)

	for elem := range queue {
		fmt.Println(elem)
	}
}

Output:
one
two
three

Yes, I agree with you, but I am raising the problem of For loop with Channel.
Different ways of using Channels solve different problems:

Using the msg, ok := <- ch syntax will help you check if a channel is closed or not.
Using For instead of Select-Case syntax will help you get all the msg in the Channel even if it is closed. When a channel is closed and there are no more msg in it, the For loop will terminate on its own.

I am no longer sure what you are reporting.  Could you rephrase the issue?

The problem is that you are not correctly expressing the end time of the For loop.
I think I detailed it in the first comment, please read it again carefully :333

I think you should separate them so others can see 2 things:

They can use the For syntax to get the messages out of the Channel
Using the For syntax will allow them to continue to retrieve messages that are still present in the Channel even after the Channel is closed.

It would be great if you have a detailed description of the differences of the 3 syntaxes:

msg := <- ch
msg, ok := <- ch
for msg := range ch

For is not unique in allowing channel receive after a close.  Close does not remove items from a channel, nor does it stop anyone from receiving them.
To quote the slide:

A sender can close a channel to indicate that no more values will be sent.

Those three options seem to me to be covered already.


remove WalkerBootstrap.php

remove WalkerBootstrap.php, add vendor bs4navwalker with theme option on/off bootstrap walker

Merged to develop


Update BuildTools to 2.1.0-preview2-02621-01

Update dotnet/standard commit to bring in fixes for the new version (https://github.com/dotnet/standard/pull/690), and fix init-tools.sh (same fix as standard).
Unblocks https://github.com/dotnet/source-build/pull/371

Figured out the weirdness with tarball, I'm pretty sure. Repro steps from fresh dotnet/standard@2022919b29bc37746f760bc6391171459f613ea5 standalone clone:

./build.sh
rm -rf bin/ packages/
./build.sh

Tarball build does keep some packages, but I guess not the ones that are needed. I believe BuildTools handles the package not being there by building with the old Roslyn, which causes the failures like these:
/home/dagood/git/standard/Tools/Microsoft.CSharp.Core.targets(106,11): error MSB4064: The "OverrideToolHost" parameter is not supported by the "Csc" task. Verify the parameter exists on the task, and it is a settable public instance property. [/home/dagood/git/standard/netstandard/ref/netstandard.csproj]
/home/dagood/git/standard/Tools/Microsoft.CSharp.Core.targets(67,5): error MSB4063: The "Csc" task could not be initialized with its input parameters.  [/home/dagood/git/standard/netstandard/ref/netstandard.csproj]

It seems like init-tools itself brings down some packages that aren't being saved? @crummel does this sound reasonable?

I added a step to the tarball creation script that runs Tools/init-tools.sh to populate the packages/ dir with the package BuildTools now expects to be there.
Removed CoreCLR from known-good temporarily to see if this makes it past CI. This works on my machine with I limit the build to standard. (My docker install doesn't seem to be working, so I can't test the offline tarball build, but the online one seems to work.)

Green CI, but with CoreCLR taken out. Locally, I'm trying a merge of release/2.1 into @weshaggard's fix branch to see if that works. The merge is clean, BuildTools version is 2.1.0-preview2-02612-03 and CLI 2.1.2, which means it should be past at least the known break.

CI's green! Once https://github.com/dotnet/coreclr/pull/17136 is in CoreCLR release/2.1 we can move off my fork.

@dseefeld @crummel PTAL

@dagood did you move coreclr to the tip of the release/2.1 branch + my fix? If so and that works then I can update the release/2.1 branch in coreclr to have the fix. It should be noted that my fix isn't enough and needs adjustments see (https://github.com/dotnet/coreclr/pull/17226) to ensure other scenarios still work.

Yep, my commit is just your fix branch with release/2.1 tip merged into it. I'll push it to dev/dagood/source-build-fixes-preview2 in dotnet/coreclr to unblock for now, then we can switch back when you have the adjustments in.


curl handling fixes

(merged from upstream master) curl_reset (resets curl options) before each request
curl_close/curl_init only every $X requests (1000 by default)
add possibility to log curl_getinfo output

never mind, back to me for now

looks gut to me :+1: :rocket:


date Support DateV1 keyword

Proposed changes

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Graduate eligible experimental configs

See also:
cox@ip-192-168-0-52:~/presto$ git grep experimental
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spill-enabled``
presto-docs/src/main/sphinx/admin/properties.rst:    Be aware that this is an experimental feature and should be used with care.
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spill-order-by``
presto-docs/src/main/sphinx/admin/properties.rst:    This property must be used in conjunction with the ``experimental.spill-enabled`` property.
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spill-window-operator``
presto-docs/src/main/sphinx/admin/properties.rst:    This property must be used in conjunction with the ``experimental.spill-enabled`` property.
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spiller-spill-path``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spiller-max-used-space-threshold``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spiller-threads``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.max-spill-per-node``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.query-max-spill-per-node``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.aggregation-operator-unspill-memory-limit``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spill-compression-enabled``
presto-docs/src/main/sphinx/admin/properties.rst:``experimental.spill-encryption-enabled``
presto-docs/src/main/sphinx/admin/spill.rst:pool via ``experimental.reserved-pool-enabled`` config property.
presto-docs/src/main/sphinx/admin/spill.rst:Consider reducing the value of ``experimental.memory-revoking-threshold`` when spill

Should we also graduate experimental.memory-revoking-threshold and experimental.reserved-pool-enabled?

related: https://github.com/airlift/airlift/pull/767

Should we also graduate experimental.memory-revoking-threshold

yes

and experimental.reserved-pool-enabled?

no.
This is independent from this PR.

AC

@electrum


SDK server not respecting limit param

Describe the bug
Title
To Reproduce
Steps to reproduce the behavior:
1.
curl --request POST \
  --url https://sdk-server.testnet.connext.ninja/getTransfers \
  --header 'content-type: application/json' \
  --header 'user-agent: vscode-restclient' \
  --data '{"params": {"status": "CompletedFast","range": {"limit": 1,"offset": 0}}}'

See that you get more than 1 record.

Additional context
Add any other context about the problem here.

This is due to misconfiguration on the index.http example file. The param is actually working fine.


Update to latest version (riak_core 2.0.2), improve README add LICENSE file

the title says it all :)

Would love to merge but the merge introduces a number of changes  in src/chash.erl that are nothing but adding tailing whitecaps or change indentation from spaces to tabs, can you fix that before I merge?

I will without problem, just note that this is a straight copy from riak_core sources :) (unless vim added them for some weird reason)

Wooh! thanks for bearing with the picky-ness ;)!

thank you for saving me some work creating this repo before I do :D


[sparkfun-tensorflow-codelab] - Update Code

The codelab still links to the experimental folder for the makefile, which is incorrect.
Visual:

Update the codelab at this link https://codelabs.developers.google.com/codelabs/sparkfun-tensorflow/#3
Code should read:
make -f tensorflow/lite/micro/tools/make/Makefile \
TARGET=sparkfun_edge micro_speech_bin

URL(s) with the issue:
https://codelabs.developers.google.com/codelabs/sparkfun-tensorflow/#3

@petewarden is this the right place for bugs for codelabs like that?

If there's any way I can do a PR to fix this, let me know.

@GantMan  This is not the correct place for codelabs. At the bottom left side of the page there is a link to Report a mistake,  you can close this issue and do it there itself.

The codelab is now updated with the changes mentioned upstream. Thanks!
https://codelabs.developers.google.com/codelabs/sparkfun-tensorflow/#3


[FEA] Warnings treated as errors needs highlight

Warnings treated as errors are not highlighted
Example:
/home/user/file.cu (297): error #177-D: variable "i" was declared but never referenced

Please describe the compiler that produces this error message so that I have better context on how to construct the syntax match.

Closing due to inactivity

Closing due to inactivity

nvcc 11.8


Question: Where/How is uReplicator deployed so that it can talk to clusters across multiple AWS regions?

I saw this diagram from one of the presentations given this year.
Where/How is uReplicator deployed so that it can talk to clusters across multiple AWS regions?

I am trying to do a POC similar to https://github.com/uber/uReplicator/issues/158 but using the first approach that @xhl1988 mentioned:

(Based on your description, seems this is not your case, but I still want to call out as this is what we are doing now)
If your message can be filtered based on src cluster info inside message body/header, you can aggregate the message into the same topic name in the other cluster.
pros: save disk space since only two copies for each message.
cons: consumer need to do filter if they only want local data

For example, aggregate Topic A in Cluster 1 (us-east-1) and same Topic A in Cluster 2 (us-west-2).
Thanks,
Sangjin Shin

Hi @sangjin-shin-sp , we deploy the uReplicator in the same region as the destination cluster if that's what you are asking. In your case, we would recommend to deploy one uReplicator cluster in us-east-1 to replicate topic A from cluster 2 to cluster 1 and another uReplicator cluster in us-west-2 to replicate topic A from cluster 1 to cluster 2.

Thanks!


Update ky.json

Added a closing tag

last time forgot to close my translation code

Thanks! I don't know how I missed it :S


tailwind-rn

I couldn't get the listed regex(es) to work. This slightly modified version works for me:
"tailwind\\('([^)]*)\\'\\)"

Sorry for the late reply.
Are you using double quotes instead of single quotes? If yes then I updated the example to enable this. Would love to hear if it worked on your end. Thank you so much!


Wrong reported location of error - missing responses for swagger

Hi, for following swagger
swagger: "2.0"
info:
  description:
   some description
paths:
  /tickets:
    get:
      responses:
        200:
          title: abc

Is reported location: attribute paths.'/tickets'(get).200.title is unexpected but I mean, it should be attribute paths.'/tickets'(get).responses.200.title is unexpected
It seems, there is missing modification of location in SwaggerDeserializer::response()
eg. here https://github.com/swagger-api/swagger-parser/blob/v1.0.51/modules/swagger-parser/src/main/java/io/swagger/parser/util/SwaggerDeserializer.java#L1209

Hi, thanks for pointing that out, please send us a PR with a proposal fix.

@r-sreesaran thanks for the PR https://github.com/swagger-api/swagger-parser/pull/1438, it's now merged. I'm closing the issue, @klokane please let us know if this keeps happening.

Thank you, it works as expected!


pytest and black workflows should not run for web-server changes

Description:

The code base is divided into two portions, the web-server (typescript/next js) and apiserver (python/flask). pytests and black workflows should only run when changes are made to python directory or apiserver as they are focused towards that.
At the moment these workflows run for all PRs and may be an overhead for devs contributing strictly to web-server.
Steps to reproduce:

Make Changes to web-server
Check Workflow runs

Example: #223
Expected behavior:

Python and flask centric workflows should run only when changes are made to apisever.

Actual behavior:

pytest and black run on all PRs

Server Setup Information:

Operating System:
Deployment Method:

Additional context

I would like to work in this issue, can I get assigned ?

I would like to work in this issue, can I get assigned ?

Hey @JuanJoseLL, sure, I will assign you the issue. Feel free to give this a try. You can discuss your approach or any queries you might have in this issue thread itself. Thanks 🚀


Make a "read-only" invite

Could we make a config list of approved servers, that only have access to ?search and ?tag?
Because lots of people are asking to invite and it could be nice if they can view, but note edit.

sure thing

sure thing


switch to axon 3.0 final release

I noticed some compile errors when switching to latest, seems like some dependencies and test tools changed from RC to RELEASE.
Would be nice to have the example reflect the final version.
Reproduce: switch version to 3.0 in pom.xml, fix errors

Update: compiles after I

renamed to FixtureExecutionResult expectDispatchedCommands in saga tests and
added  spring-messaging dependency to "query"

But when running the embedded example, I now get this exception when I trigger a transfer:
javax.persistence.TransactionRequiredException: No EntityManager with actual transaction available for current thread - cannot reliably process 'persist' call
        at org.springframework.orm.jpa.SharedEntityManagerCreator$SharedEntityManagerInvocationHandler.invoke(SharedEntityManagerCreator.java:282) ~[spring-orm-4.3.5.RELEASE.jar:4.3.5.RELEASE]
        at com.sun.proxy.$Proxy122.persist(Unknown Source) ~[na:na]
        at org.axonframework.eventhandling.saga.repository.jpa.JpaSagaStore.insertSaga(JpaSagaStore.java:260) ~[axon-core-3.0.jar:3.0]
        at org.axonframework.eventhandling.saga.repository.AnnotatedSagaRepository.storeSaga(AnnotatedSagaRepository.java:217) ~[axon-core-3.0.jar:3.0]
        at org.axonframework.eventhandling.saga.repository.AnnotatedSagaRepository.lambda$doCreateInstance$3(AnnotatedSagaRepository.java:138) ~[axon-core-3.0.jar:3.0]
        at org.axonframework.messaging.unitofwork.MessageProcessingContext.notifyHandlers(MessageProcessingContext.java:68) ~[axon-core-3.0.jar:3.0]
        at org.axonframework.messaging.unitofwork.BatchingUnitOfWork.lambda$notifyHandlers$2(BatchingUnitOfWork.java:131) ~[axon-core-3.0.jar:3.0]

Hi. I updated the project to use version 3.0 of Axon Framework.

hi，I use version 3.0.4 of Axon Framework.and occur same exception.are you fixed?how?thank you.


VSTest - Code Coverage - No results for .NET Core XUnit project

Environment

Server - Azure Pipelines

rcss-willistowerswatson - PPM - Build design

Agent - Hosted or Private:

Private - WS16 - 2.140.2

VSTest version: 15.9.0

Issue Description
I am attempting to get C# code coverage from XUnit .NET Core test projects by using VSTest task v2.*.
I am testing assemblies resulting from "dotnet publish" command.
.csproj file:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>
    <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
    <IsPackable>false</IsPackable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" />
    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="2.1.1" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.8.0" />
    <PackageReference Include="Moq" Version="4.10.0" />
    <PackageReference Include="xunit" Version="2.4.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\WTW.AML.Host.Common\WTW.AML.Host.Common.csproj" />
  </ItemGroup>

</Project>

Build steps:

The publish folder contains CodeCoverage folder under it, which came as part of the Test SDK 15.8.0.

However, when I run directly against this folder (or with wildcard paths), it doesn't find this data collector.
Task logs
vsts-issue-coverage.txt
Error logs
2018-10-11T06:11:31.5196256Z vstest.console.exe
2018-10-11T06:11:31.5196422Z "D:\netcoreapp2.1\publish\WTW.AML.Host.Common.UnitTests.dll"
2018-10-11T06:11:31.5196517Z /Settings:"D:\_Builds\<vm_name>.01\_temp\7f49c700-cd1c-11e8-9ae8-55b5d8e8f4b0.runsettings"
2018-10-11T06:11:31.5196586Z /logger:"trx"
2018-10-11T06:11:31.5196652Z /TestAdapterPath:"D:\netcoreapp2.1\publish"
2018-10-11T06:11:31.5196732Z /diag:"D:\_Builds\<vm_name>.01\_temp\7f429b10-cd1c-11e8-9ae8-55b5d8e8f4b0.txt"
2018-10-11T06:11:31.8244301Z Starting test execution, please wait...
2018-10-11T06:11:31.8253389Z Logging Vstest Diagnostics in file: D:\_Builds\<vm_name>.01\_temp\7f429b10-cd1c-11e8-9ae8-55b5d8e8f4b0.txt
2018-10-11T06:11:32.4487069Z Data collection : Logging DataCollector Diagnostics in file: D:\_Builds\<vm_name>.01\_temp\7f429b10-cd1c-11e8-9ae8-55b5d8e8f4b0.datacollector.18-10-11_07-11-31_99995_4.txt
2018-10-11T06:11:32.4489680Z Data collection : Could not find data collector 'Code Coverage'

Workaround:
It's not just published assembly folders that come with CodeCoverage utility, but also the installed TestPlatform. I can reference it as a test adapter, but then have to be careful to download a specific version with my installer task.

Closing this. Please reopen with logs if this repros again.


setCommits.ignoreMissing doesn't work anymore.

Environment
self-hosted (I don't know the version)
Which SDK and version?
Latest Javascript
Steps to Reproduce
Run webpack twice using setCommits.ignoreMissing to true
Expected Result
The setCommits.ignoreMissing parameter works as expected.
Actual Result
/cli/sentry-cli releases set-commits development --auto --ignore-missing
error: No commits found. Change commits range, initial depth or use --ignore-empty to allow empty patch sets.
Probably due to a CLI param rename?

@bmulholland I saw you downvoted the stalebot comment. Is this still an issue for you in the newest release of the webpack plugin?

@lforst well, it's fixed for me, and this was a year ago so I forget exactly what was going on, but the breaking change is still undocumented. There's no mention of "ignore empty" in the docs), and this Issue is actually one of the few relevant results on Google for "sentry ignore-empty". The only place so see anything about the option is in the source code itself, as I noted below, and a short note in the changelog that says it's a breaking change but not who it affects and what they should do about it.
Looking for this now, I also see a suggestion that using this option in the first place is a workaround for another problem, so I might try to fix that. The CLI message about the issue, or the docs would be a good place for Sentry to call that out, suggesting better ways to fix the issue (assuming it's indeed an anti-pattern of sorts).
Finally, as I noted above, my complaint was also about how a breaking change was rolled out without suitable communication. That wasn't addressed, which -- along with the continuing lack of docs -- is why I downvoted the bot.

There's no mention of "ignore empty" in the docs

That's due to making this option a default behavior as you already noticed. There's no reason for documenting it, as it's a no-op flag now.

it's a breaking change but not who it affects and what they should do about it.

Finally, as I noted above, my complaint was also about how a breaking change was rolled out without suitable communication. That wasn't addressed, which -- along with the continuing lack of docs -- is why I downvoted the bot.

It's a behavior change, but not really a breaking API change (though still marked as breaking to make it easier to notice in the changelog). The flag is still there, hidden, but won't have any effect, to not force people to update their CIs scripts unnecessarily. This flag was used to allow creating initial commits patchset for "suspected commits" integration, or for branches that diverged in a way, that prevented the HEAD of CI job to find it's ancestor.
This should not break the CI, but rather create a log warning, and this is exactly the current behavior.
We had lots of feedback from people saying that they'd expect it to work this way, so we initially rolled it out as an opt-in flag, but after a while, when moving to a new major version of the CLI, we made it a default.


feat: upgrade to webpack5

when passing a function, it has now a different signature ({ context, request }, callback)

Since webpack5 has changed the signature of externals, so I suppose we should release a major beta version for upgrading webpack.
Ping @liady

Thank you for this PR.
Added support for Webpack 5 (while maintaining backwards support) in version 2.5.0


Incorrect tooltip for File - Save in main menu

System information:

Operating system (distribution) and version win 10 x64
DBeaver version 6.0.1

Describe the problem you're observing:
incorrect tooltip appears for File - Save. And there is no tooltips for other meni elements

verified


incorrect result printout for time_hash_map

The number of copies is incorrect, as it is not reset when the real test begins. Code should be in time_hash_map.cc:342
inline void Rusage::Reset() {
g_num_copies = 0;
g_num_hashes = 0;

Patch welcome :-)

Will do.

Fixed in d6684b241c915a2764caa20270e48d9c5f25eb1d


New version doesnt work [[Version 3.3.3 working]]

Hey I think last version fucked up something

command used on both screenshots
[ori@npc_onlyfans_girl ~]$ ofscraper -u kitalovexoxovip --after 2000 --dump

===================================

^CERROR: Operation cancelled by user
^[[A[ori@user ~]$ pip install ofscraper==3.3.3
Collecting ofscraper==3.3.3
fixed the issue

SCREENSHOT WITH ISSUE (THE LATEST VERSION)

UPDATE
in version 3.3.3
TWO DIFFERENT FOLDER NAMES

DUPE ISSUE WITH CDM / DRM VIDEOS

try 3.4


Fix lumi.remote.b1acn01 device triggers

Fixes: #640

Codecov Report

Merging #660 (4198198) into dev (47287d1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #660   +/-   ##
=======================================
  Coverage   81.15%   81.15%
=======================================
  Files         166      166
  Lines        3763     3763
=======================================
  Hits         3054     3054
  Misses        709      709

Impacted Files
Coverage Δ

zhaquirks/xiaomi/aqara/sensor_switch_aq3.py
76.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47287d1...4198198. Read the comment docs.

Pull Request Test Coverage Report for Build 436480314

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.159%

Totals

Change from base Build 436460653:
0.0%

Covered Lines:
3054

Relevant Lines:
3763

💛  - Coveralls


conversion issue with balance passed into remove liquidity

Issue is USDC value gets passed into get Remove liquidity estimate that causes to fail, since user has less lp tokens than USDC amount.

When estimation does succeed the MM doesn't pop up so user can't sign transaction. Saw on USDC amm.

typing in a lower amount will allow the user to remove liquidity
The amount typed in to remove was 100 and 500 lp tokens. The values below are wrong compared to what the user typed in. Need to check values on graph transactions to see if there is a conversion error when displaying.

Issue here was min amount was calculated incorrectly because of rounding up error. fixed

Issue here was min amount was calculated incorrectly because of rounding up error. fixed

closing


Update to PureScript v0.15.0

Description of the change
Backlinking to purescript/purescript#4244
Migrates FFI to ES modules

Checklist:

[x] Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
[x] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation
[ ] Added a test for the contribution (if applicable)

🏓 @thomashoneyman @JordanMartinez

CI is failing due to unused imports.


Needs to use openat() with gvfs so that stale but remounted connections work.

Description
If you try to save to a file over gvfs where the connection has been closed, and the remounted it reports a fuse error. This is because it is holding a state file handle, instead of using openat() and letting the kernel traverse the directories each time. Sometimes you would want the functionality where it holds on to the fds, but in this case I do not want that.
Steps to Reproduce

Open a file on GNOME from over gvfs to a ssh host (sftp)
disconnect the sftp connection
reconnect the sftp connection
try to save a file

Expected behavior:
works
Actual behavior:
can't save over socket
Reproduces how often:
100%
Versions
apm  2.1.7
npm  6.2.0
node 8.9.3 x64
atom 1.37.0
python 2.7.16
git 2.20.1
Ubuntu disco x86_64

Sorry for the delay and thanks for the report -

can't save over socket

Are you getting a specific error or does Atom crash?

disconnect the sftp connection
reconnect the sftp connection

If Atom is crashing and based on these steps, this sounds like https://github.com/atom/atom/issues/10271?

I switched to vscode over this (which works unlike most editors, but there is also a multiple round trips problem with FUSE, which they are trying to get people to use proprietary limited code to address)


fix: replace git:// URIs with https://

stacked on #150
Because the git:// protocol is oftentimes blocked by traditional firewalls, we instead redirect the git URL to https:// for better compatibility.

tests failing, will fix


Add Support for Package Binding

We have many deployment use cases which uses package binding, for example, the most common package binding is cloudant. Whisk deploy does not have support for such package binding. I am creating this issue to keep track of adding this support.
Openwhisk CLI  has support for such binding at https://github.com/openwhisk/openwhisk-client-go/blob/master/whisk/package.go#L54
Details on package binding is available at https://console.ng.bluemix.net/docs/openwhisk/openwhisk_packages.html#openwhisk_packages
@paulcastro @mrutkows @daisy-ycguo any comments or feedback are welcome!

@pritidesai We have discussed adding grammar for "built-in" feeds/actions and adding credentials for alreaedy running (external services), but have not gotten around to formalizing the discussion.  Cloudant, for example, is just one Cloud storage (API) service and we need a general way to integrate with them.  Please note the wskdeploy tool's scope is limited to OpenWhisk APIs and any other service we cannot add deployment support for (and not try to become an "omni" deployer; that is not our role).  However, we can better integrate running/existing services. Thoughts?

I'm quite confused. @pritidesai are you referring to #158?

It has a reference to #41, I am not sure if #41 is about creating package binding listed under "dependencies", please clarify.
I am referring to adding support in wskdeploy so that we can automate these wsk CLI:
wsk package bind /whisk.system/cloudant TrackPRsInCloudant --param-file cloudant.json
This cloudant package can than be used in multiple custom actions.
wsk package bind /whisk.system/slack PostPRToSlack --param-file slack.json
Reference:
https://github.com/openwhisk/openwhisk-GitHubSlackBot#step-2-create-cloudant-package-binding---trackprsincloudant

Priti indicates this is resolved.


[Bug]: toStrictEquals incorrectly compares class instances with getters that access private fields

Version
29.0.3
Steps to reproduce
Execute the following test that fails:
class ClassWithPrivateJsField {
  #_a: string;

  constructor(a: string) {
    this.#_a = a;
  }

  get a() {
    return this.#_a;
  }
}

describe('toStrictEqual', () => {
  describe('on class instances with private javascript fields', () => {
    it('should not consider objects with different js-private field values via getter to be equal', () => {
      expect(new ClassWithPrivateJsField('v1')).not.toStrictEqual(
        new ClassWithPrivateJsField('v2')
      );
    });
  });
});

Also see https://stackblitz.com/edit/node-5wy1ts?file=index.spec.ts
Expected behavior
The test above should be successful
Actual behavior
The test above fails
Debug log
See stackblitz
Additional context
This issue might be somehow related to the follwing jest issues, but I am not 100% sure as there are errors thrown in those issues. In my case with ts-jest toStrictEqual just considers both instances as equal although they are not.

https://github.com/facebook/jest/issues/10167
https://github.com/facebook/jest/issues/9022

Environment
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    jest: ^29.2.2 => 29.2.2

I am closing this issue as the same issue is reproducible via plain jest: https://github.com/facebook/jest/issues/13535


Attempts to "clean up" s3 in case of Iceberg tables, which is redundant

More new behaviour since 1.3.5
For CTAS dbt-athena attempts to delete objects at location in the case of iceberg table. It did not do that before, so this is another breaking change thus requiring new S3 permissions (listing and deleting) if you're using iceberg (which I am, and I don't have the necessary permissions).
This activity seems to be redundant given AWS docs

Because Iceberg tables are considered managed tables in Athena, dropping an Iceberg table also removes all the data in the table.

Problematic line appears to be here. I'll PR a fix to remove this call in case of iceberg.

(I do appreciate some of the challenges with OSS maintenance, I've done a bit of that myself. I'll take a few minutes to try and explain my context and why I'm having problems, but I think it's really more a question for how dbt-athena decides what and how to implement, and how breaking changes are defined and handled. I'll try and find a bit more time to drop my broader thoughts there for you)

Can't you get the right permissions in place?

I think this might be the crux of the problem - dbt-athena makes the assumption that any user will have access not just to Athena, but also fairly comprehensive access to Glue and S3. I'm sure that's the case for many of even most teams, but it is possible to use Athena in a much more restricted mode, using the CalledVia key to permit access to S3 only when called via Athena, as documented by AWS here.
The presence of that documentation specifically in the context of Athena, and the general AWS "best practices" guidance for IAM issued here, specifically:

When you set permissions with IAM policies, grant only the permissions required to perform a task.

I am a consultant working with highly sensitive data for a client, and aside from is being a best practice, I was explicitly asked to minimise the permissions required for teams - with a specific callout for no direct access to S3. Up to dbt-athena 1.3.5, this was not a problem. Almost every release since, the set of required permissions has been extended (I'm sure you're aware of the battery of issues I've raised this week - this is as a result of me trying to get update our dependency on dbt-athena to latest and every time I fix one thing, I just surface the next broken thing.
To reiterate - everything works fine on 1.3.5. These are all breaking changes, if your consumer is operating in a least privilege environment.
Why don't I just update the permissions?

I have to go and argue a case with infosec and compliance folk to make this kind of change. What's my argument? It's clearly possible to operate without these permissions - as 1.3.5 shows. "The maintainers of dbt-athena will change the required permissions at any time, for any reason, without notice, and will refuse to consider it a breaking change when they break you"... not the best look
That dialogue takes time.  This kind of a change might even result in a need to do a bunch of security threat modelling, which is not a quick process.
I'm likely to hit a wall anyway. The S3 access is likely a dealbreaker (some teams are allowed this, others are not)
Finally - what permissions are safe to assume stable? dbt-athena does not document the permissions it needs, and if I figure out what's needed in line with AWS best practice and go with that it seems inevitable that by release 1.4.8 you will break me again.

The issue is that drop sometimes do not clean the path correctly when you have many objects. We had already

Have you raised this issue with AWS? If the advertised functionality doesn't work as expected, I'm sure AWS would appreciate getting that info and whatever evidence you have of the problem (as would everyone who uses Athena Iceberg and expects it to work properly like me!)

Thanks for your detailed answer.
When we build and maintain new features for the adapter we don't have all the usage clear in mind, therefore giving such context in each issue helps us to understand what lead to it. Often we give our first answer based on common patterns/issues raised in the past - see this case: I assumed that you could simply add a missing IAM action.
Your setup is a rather special one, thanks for making us aware. I apply the "at least privilege rule" in all of my projects, but as often I have admin rights, I can add more policies, this is not the case for you - and for sure other users.
We are aware of changes in the IAM policies, and often we prefer to let the final user add new policies in order to fix a specific issue, generally, this approach had lead us to make most of the users happy, and I'm aware that we won't be able to to make everybody happy.

Have you raised this issue with AWS? If the advertised functionality doesn't work as expected, I'm sure AWS would appreciate getting that info and whatever evidence you have of the problem (as would everyone who uses Athena Iceberg and expects it to work properly like me!)

This implementation is a fruit of a suggestion made by AWS support. I guess that you are aware of the long fixing time of some bugs, hence the proposed fix.
Also, I would like to remind you that this project is a community-based effort, we do maintain in free time and compromise with work/private life. Said so, when we do a change we put "maintainability first", which means we avoid "backward compatibility changes", and convoluted code, as simply we don't have enough resources (time/people) to do so - happy to add you as code maintainer if you are interested.
In this specific case, I believe that we could consider an extra global/model specific flag native_iceberg_drop, if set to True the native athena drop statement will be executed and cleanup of s3 will happen again using athena iceberg capability - by default such flag will be set to False.
WDYT?
cc @Jrmyy

Thanks @nicor88 for taking the time, that sounds like a perfectly good solution - I'll be happy to submit a PR to make that change as per your spec. I am also mid-writing a bit of a timeline and suggestions in the Governance ticket as there's a bit of a multi-issue story - will finish that up and then do that PR :bow:

@nicor88 I have started work on a PR, but I'm wondering whether a better way of approaching the whole problem I've been trying to explain would be to have a single flag like "sql_only" that switches behaviour to avoid other API calls instead of a potentially several flags that toggle bits to be done in SQL rather than API calls.
I think that could be understood as a feature to support the restricted access case which should help avoid confusion. That flag should also be easier to understand and use as well as easier to implement than multiple small independent fixes - I get the feeling the piecemeal approach will end up being more difficult to maintain?

Hello
I overall agree with the discussion and I feel indeed that we can both support an "enhanced" version of the adapter, leveraging S3, Glue and Athena in order to have the maximum capacities of the adapter.
I also think that having a sql_only or athena_only could be a better way to handle things.
This config could be in the profiles file.
I also warn that this might be a noticeable amount of work because we would have to check everything to be sure they are compliant with both approaches. My 2 cents is really to have a shared discussion of what we want to achieve and what complexity it will bring to support several ways to do things. I don't want to be opinionated or impose anything but on the other hand I don't want to over-complexify the adapter if we don't have an audience for that.
What do you think about having an open discussion about it on #db-athena in DBT Slack ? Maybe it will help having more insights.

@Jrmyy I didn't know there was a Slack channel! Could pop that in the README. Would love to have more of a dialogue about this, it's not a trivial thing I'll see you over on Slack :+1:


Maybe a bleachbit script to automatically clean

Bleachbit can delete files from a computer easily, its made to remove junk.

Bleachbit can delete files from a computer easily, its made to remove junk.

Doesn’t this have the same purpose as aptcleaner?

No.
Please look into things.
https://duckduckgo.com/?q=bleachbit
There

Alright, where are the install/uninstall files?

sudo apt install bleachbit
sudo apt purge bleachbit
I didn't sign up to make them, just giving you some suggestions

Sorry that was rude of me.

bleachbit --list may be of some use

sudo apt install bleachbit
sudo apt purge bleachbit
I didn't sign up to make them, just giving you some suggestions

If it’s already installable with sudo apt-get install, why do you want it on Pi-Ware?

Because it might be better to have a script that automates it

Because it might be better to have a script that automates it

Ok, if you make one I will add it to Pi-Ware.

Yes, this is unfortunately true... I bricked an OS installation once by selecting all the clean options in BleachBit

Yes, this is unfortunately true... I bricked an OS installation once by selecting all the cleaning options in BleachBit

Give me a few days and i'll look into it

Ok, I’ll check back on the 31st.

Actually, I am not going to keep you waiting. I am very busy so I cannot promise anything, feel free to close if you want or make it on your own

Actually, I am not going to keep you waiting. I am very busy so I cannot promise anything, feel free to close if you want or make it on your own

Ok, when or if you have any files ready, just comment here and I’ll re-open the issue.


phpdoc_types_order bug with intersection types and generic annotations

Bug report
3.0.1 (or 3.0.2) seems to have introduced a bug with phpdoc_types_order.
I found a related issue https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5798 which was closed as solved.
I think this is a slightly different issue but still related.
Code snippet that reproduces the problem
Initial code:
/**
 * @var Collection<int, AbstractInvoice> & Selectable<int, AbstractInvoice>
 */
private Collection $invoices;

Changed code:
/**
 * @var Collection<int, <|AbstractInvoice> & Selectable|int, AbstractInvoice>
 */
private Collection $invoices;

Current workaround I'm using:
/**
 * @var (Collection<int, AbstractInvoice>) & (Selectable<int, AbstractInvoice>)
 */
private Collection $invoices;

I believe this has been fixed in #6063

Thanks for the headsup, this seems fixed indeed in v3.6.0, let me know if not and I'll reopen :+1:


Fixing jshint issues with grunt, gulp, and reset-password script.

Fixing jshint issues with grunt, gulp, and reset-password script.

LGTM


Release 1.6.3

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Let's hold on this before we have sync on this PR: https://github.com/aws/amazon-vpc-resource-controller-k8s/pull/503/commits/53939cd8212a4b1fb78e8685b3c8e86eef9fb8b3

Let's hold on this before we have sync on this PR: 53939cd
My concern is on managed -> unmanaged Update workflow.

Synced on this offline, VPC-CNI does not remove the feature from CNINode on disabling the feature, hence node is not updated as being unmanaged-
[13/12/24 4:13:20] ➜  ~ kubectl set env daemonset aws-node -n kube-system ENABLE_POD_ENI=false
daemonset.apps/aws-node env updated
[13/12/24 4:16:17] ➜  ~ kubectl get cninodes
NAME                                            FEATURES
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal     [{"name":"SecurityGroupsForPods"}]

I restarted one instance on EC2 console, and the feature is removed only for that particular node
[13/12/24 4:21:10] ➜  ~ kubectl get cninodes
NAME                                            FEATURES
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal

Also tested with aws-node restarts and verified the feature is not removed(the last node is the same restarted node form above):
[13/12/24 4:21:31] ➜  ~ kubectl rollout restart ds -n kube-system aws-node
daemonset.apps/aws-node restarted
[13/12/24 4:28:07] ➜  ~ kubectl get cninodes
NAME                                            FEATURES
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal


Implement deepstack compatible endpoints

As https://github.com/robmarkcole/tensorflow-lite-rest-server

Can this endpoint be async? Most likely a blocking endpoint


#137 Adjusted poll many API response code - removed unnecessary guid.

Server side code has been simplified due to lack of requirement to support additional case of many guid. Device identifiers are now part of command entity only.

Looks fine

Looks good.


Nitro has a installation script and configurations

Success Criteria

User should be able to configure Nitro and change defaults
User should be able to run a single script to install Nitro/OS dependencies
User should be able to deploy Nitro service
User should be able to integrate Nitro with Jan seamlessly

Rough spec
An installation path could look like the following

Install dependencies: ./install.sh

logs:
sh     # If gpu_mode:     echo "Running Nitro on GPUs, checking dependencies"     # install nvidia-smi     ...

Configure .env
NITRO_PORT: 8000
GPU_MODE: true

# What other configs are possible for a good UX?

Install the model(s) into directory
wget ... /models

Run Nitro: run.sh

No longer relevant


How is this a permanent web if DMCA can take content down?

What's the purpose of this repo please?

To provide a list of known-bad hashes that people can use who want to run a public gateway.

I understand. It's gateway specific.


CDN support

how to use this plugin on CDN ?

I don't think 3rd party plugins are currently supported by the Play CDN.
That would be a nice option to have for rapid development and experiments. However, as the Tailwind CDN is not intended for production, I think this is acceptable.

Check this out, https://jsfiddle.net/fcv5epma/
we can set theme and configs using tailwindcss config
https://tailwindcss.com/docs/installation/play-cdn
it can be useful for iframes and web builders.
Thanks

Fair, predefined animations (keyframes) would work that way. But custom utilities not, right? Try to add a animate-duration-75 class for example. This kind of extension only works with plugins, as far as I know.


FusedLamb error

I am running large Bert model from HuggingFace on AzureML. When I defined "FusedLamb" as an optimizer in ds_config.json, I had this error: AssertionError: FusedLamb is not a supported DeepSpeed Optimizer. Then I used "Lamb" (according to https://huggingface.co/docs/transformers/main_classes/deepspeed) but had this error: (AssertionError: You are using an untested ZeRO Optimizer. Please add <"zero_allow_untested_optimizer": true> in the configuration file to use it.).
I added zero_allow_untested_optimizer to the config and didn't have the error again.
Which optimizer (Lamb vs FusedLamb) should I use, and why do I get those errors while Lamb and FusedLamb are listed as optimizers?

The optimizer you should use depends on your hardware and performance requirements. The FusedLamb optimizer is a faster and more memory-efficient version of the Lamb optimizer, which implements the fusion of some operations to reduce the communication overhead and memory footprint. However, the FusedLamb optimizer requires a custom CUDA kernel to run, which means you need to have a compatible GPU and CUDA version to use it. The Lamb optimizer is a more general and compatible version, which can run on any device that supports PyTorch, but it may be slower and consume more memory than the FusedLamb optimizer.
The errors you encountered are related to the compatibility and configuration of the optimizers. The first error (AssertionError: FusedLamb is not a supported DeepSpeed Optimizer) indicates that you did not install the FusedLamb op when you installed DeepSpeed. To use the FusedLamb optimizer, you need to install DeepSpeed with the DS_BUILD_FUSED_LAMB environment variable set to 11. Alternatively, you can use the ds_report tool to check which ops are installed and compatible with your machine1.
The second error (AssertionError: You are using an untested ZeRO Optimizer) indicates that you are using an optimizer that is not officially tested and supported by the ZeRO-Offload feature of DeepSpeed. ZeRO-Offload is a technique that offloads some of the optimizer states and gradients to the CPU memory, which reduces the GPU memory consumption and enables training larger models. However, not all optimizers are compatible with this technique, and some may cause errors or performance degradation. Therefore, DeepSpeed only allows using tested and supported optimizers with ZeRO-Offload by default, such as Adam and AdamW. To use other optimizers, such as Lamb, you need to add “zero_allow_untested_optimizer”: true in the configuration file, as you did2. However, this does not guarantee that the optimizer will work correctly and efficiently with ZeRO-Offload, so you need to be careful and monitor your training progress

Thanks for the explanation and guidance. I added "RUN DS_BUILD_FUSED_LAMB=1 pip install deepspeed" when I was building the environment (AzureML) and after that had "RUN python -m deepspeed.env_report" which shows that fused_lamb is compatible, but it is not installed. Uninstalling and installing deepspeed didn't help and I still get the same error as before (AssertionError: FusedLamb is not a supported DeepSpeed Optimizer) when I use "FusedLamb" as an optimizer in ds_config.json, I should mention that there is no error in the log file after building the environment. I use single A100 VM as a compute cluster. How should I install deepspeed so that FusedLamb is also installed?

It is odd that opt is not building, but your first comment about using 'Lamb' in the config is correct is correct.
As you can see from the code

The name 'Lamb' in the config instantiates the 'FusedLamb' optimizer. Sorry for the confusion.


DBZ-379

Supersedes https://github.com/debezium/debezium/pull/364.
@jpechane Could you take a look at my additions and merge if you think it's good? Thanks!

@jpechane any more comments on that one?

@gunnarmorling Looks much better thanks, I've just added one comment reagrding using implementation class vs interface in type definitions. It is in attribute declaration and in method signatures.

@jpechane, just rebased to current master and force-pushed. The "unknown types" support was a bit in the way of it :)

Suqashed and merged, thanks for the patience.


Introduce a next channel withing which we can get the next bits (from custom catalog source)

Description
Currently, there is a two way to get the latest DWO installed:

with make install
with OperatorHub

We also have the ability to register catalog source https://github.com/devfile/devworkspace-operator/blob/main/build/make/olm.mk#L73
but I think it does not support automatically upgrade since that index drop everything but just keeps the latest CSV.
This issue is about something that Che Operator has, where you're able to get the next bits updates from the channel.

next deployments of DWO are supported through the quay.io/devfile/devworkspace-operator-index:next operator index.


Problem with nDim with 2D potentials

Using a 2D potential currently creates in error in the ##set dim part of basic_systems. This is due to the sympy representation of potential.nDim.  Fix when sympy variables or corresponding valuesare used.

I fixed the issue by generating a constants dict for all potential, which is a good solution, as this is needed for the sympy implementation style. And I would like in future to use this more.
see commit: #2

Please Test Langevine with the 2d Sim :)


Fix -> Vue3: SAML SLO support - feature is broken

Summary
Fixes #11766

Original work was done on this PR https://github.com/rancher/dashboard/pull/11182
Occurred changes and/or fixed issues

add missing bits to make SAML SLO feature work (Header component missing a part of template)
fix  $set notations on saml.vue
fix problem of data propagation on the SAML auth providers for certificates where when you added a certificate the textarea wouldn't show the certificate data

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

There some problems with the styling on the popover that comes from clicking on the avatar icon on the header, especially for different themes (light vs dark) but that's tracked already in https://github.com/rancher/dashboard/issues/11684

Screenshot/Video

Checklist

[ ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[ ] The PR has a Milestone
[ ] The PR template has been filled out
[ ] The PR has been self reviewed
[ ] The PR has a reviewer assigned
[ ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@codyrancher I've added you here because of the fix I did for the TextAreaAutoGrow. Not 100% sure if this has unwanted implications that I haven't foreseen.