Getting compile errors against latest OpenPose

I'm getting the following errors when trying to build PyOpenPose:
[ 75%] Building CXX object PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/opencv_expose.cpp.o
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:51:23: error: cannot declare field ‘OpenPoseWrapper::PrivateData::faceExtractor’ to be of abstract type ‘op::FaceExtractor’
     op::FaceExtractor faceExtractor;
                       ^
In file included from /home/liffon/openpose/include/openpose/face/headers.hpp:7:0,
                 from /home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:13:
/home/liffon/openpose/include/openpose/face/faceExtractor.hpp:14:18: note:   because the following virtual functions are pure within ‘op::FaceExtractor’:
     class OP_API FaceExtractor
                  ^
/home/liffon/openpose/include/openpose/face/faceExtractor.hpp:48:22: note: 	virtual void op::FaceExtractor::forwardPass(const std::vector<op::Rectangle<float> >&, const cv::Mat&, double)
         virtual void forwardPass(const std::vector<Rectangle<float>>& faceRectangles, cons
                      ^
/home/liffon/openpose/include/openpose/face/faceExtractor.hpp:71:22: note: 	virtual void op::FaceExtractor::netInitializationOnThread()
         virtual void netInitializationOnThread() = 0;
                      ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:55:23: error: cannot declare field ‘OpenPoseWrapper::PrivateData::handExtractor’ to be of abstract type ‘op::HandExtractor’
     op::HandExtractor handExtractor;
                       ^
In file included from /home/liffon/openpose/include/openpose/hand/headers.hpp:7:0,
                 from /home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:14:
/home/liffon/openpose/include/openpose/hand/handExtractor.hpp:14:18: note:   because the following virtual functions are pure within ‘op::HandExtractor’:
     class OP_API HandExtractor
                  ^
/home/liffon/openpose/include/openpose/hand/handExtractor.hpp:53:22: note: 	virtual void op::HandExtractor::forwardPass(std::vector<std::array<op::Rectangle<float>, 2ul> >, const cv::Mat&, double)
         virtual void forwardPass(const std::vector<std::array<Rectangle<float>, 2>> handRe
                      ^
/home/liffon/openpose/include/openpose/hand/handExtractor.hpp:78:22: note: 	virtual void op::HandExtractor::netInitializationOnThread()
         virtual void netInitializationOnThread() = 0;
                      ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In constructor ‘OpenPoseWrapper::PrivateData::PrivateData(const op::Point<int>&, const op::Point<int>&, const op::Point<int>&, const op::Point<int>&, const op::Point<int>&, const op::PoseModel&, const string&, int, float, float, const std::vector<op::HeatMapType>&, const op::ScaleMode&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:41:114: error: too many initializers for ‘op::CvMatToOpInput’
 r{netInputSizeFace, netOutputSizeFace, modelFolder, 0, 1, 0.4, heatMapTypes, heatMapScale}
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:41:114: error: too many initializers for ‘op::CvMatToOpOutput’
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:41:114: error: no matching function for call to ‘op::PoseGpuRenderer::PoseGpuRenderer(<brace-enclosed initializer list>)’
In file included from /home/liffon/openpose/include/openpose/pose/headers.hpp:11:0,
                 from /home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:12:
/home/liffon/openpose/include/openpose/pose/poseGpuRenderer.hpp:16:9: note: candidate: op::PoseGpuRenderer::PoseGpuRenderer(op::PoseModel, const std::shared_ptr<op::PoseExtractor>&, float, bool, float, float, unsigned int)
         PoseGpuRenderer(const PoseModel poseModel, const std::shared_ptr<PoseExtractor>& p
         ^
/home/liffon/openpose/include/openpose/pose/poseGpuRenderer.hpp:16:9: note:   no known conversion for argument 1 from ‘const op::Point<int>’ to ‘op::PoseModel’
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:41:114: error: no matching function for call to ‘op::FaceExtractor::FaceExtractor(<brace-enclosed initializer list>)’
 r{netInputSizeFace, netOutputSizeFace, modelFolder, 0, 1, 0.4, heatMapTypes, heatMapScale}
                                                                                ^
In file included from /home/liffon/openpose/include/openpose/face/headers.hpp:7:0,
                 from /home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:13:
/home/liffon/openpose/include/openpose/face/faceExtractor.hpp:22:18: note: candidate: op::FaceExtractor::FaceExtractor(const op::Point<int>&, const op::Point<int>&, const std::vector<op::HeatMapType>&, op::ScaleMode)
         explicit FaceExtractor(const Point<int>& netInputSize, const Point<int>& netOutput
                  ^
/home/liffon/openpose/include/openpose/face/faceExtractor.hpp:22:18: note:   candidate expects 4 arguments, 6 provided
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:41:114: error: no matching function for call to ‘op::HandExtractor::HandExtractor(<brace-enclosed initializer list>)’
 r{netInputSizeFace, netOutputSizeFace, modelFolder, 0, 1, 0.4, heatMapTypes, heatMapScale}
                                                                                ^
In file included from /home/liffon/openpose/include/openpose/hand/headers.hpp:7:0,
                 from /home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:14:
/home/liffon/openpose/include/openpose/hand/handExtractor.hpp:25:18: note: candidate: op::HandExtractor::HandExtractor(const op::Point<int>&, const op::Point<int>&, short unsigned int, float, const std::vector<op::HeatMapType>&, op::ScaleMode)
         explicit HandExtractor(const Point<int>& netInputSize, const Point<int>& netOutput
                  ^
/home/liffon/openpose/include/openpose/hand/handExtractor.hpp:25:18: note:   candidate expects 6 arguments, 8 provided
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function ‘void OpenPoseWrapper::detectPose(const cv::Mat&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:131:71: error: ‘class op::CvMatToOpInput’ has no member named ‘format’
     std::tie(netInputArray, scaleRatios) = membersPtr->cvMatToOpInput.format(rgb);
                                                                       ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:133:96: error: no matching function for call to ‘op::PoseExtractorCaffe::forwardPass(op::Array<float>&, <brace-enclosed initializer list>, std::vector<float>&)’
 bersPtr->poseExtractorCaffe.forwardPass(netInputArray, {rgb.cols, rgb.rows}, scaleRatios);
                                                                                ^
In file included from /home/liffon/openpose/include/openpose/pose/headers.hpp:10:0,
                 from /home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:12:
/home/liffon/openpose/include/openpose/pose/poseExtractorCaffe.hpp:24:14: note: candidate: virtual void op::PoseExtractorCaffe::forwardPass(const op::Array<float>&, const op::Point<int>&, const std::vector<double>&)
         void forwardPass(const Array<float>& inputNetData, const Point<int>& inputDataSize
              ^
/home/liffon/openpose/include/openpose/pose/poseExtractorCaffe.hpp:24:14: note:   no known conversion for argument 3 from ‘std::vector<float>’ to ‘const std::vector<double>&’
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function ‘void OpenPoseWrapper::detectFace(const cv::Mat&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:139:86: error: ‘BOOST_THROW_EXCEPTION’ was not declared in this scope
         BOOST_THROW_EXCEPTION(std::runtime_error("Face network was not initialized."));
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function ‘void OpenPoseWrapper::detectFace(const cv::Mat&, const cv::Mat&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:155:86: error: ‘BOOST_THROW_EXCEPTION’ was not declared in this scope
         BOOST_THROW_EXCEPTION(std::runtime_error("Face network was not initialized."));
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:159:120: error: ‘BOOST_THROW_EXCEPTION’ was not declared in this scope
 td::runtime_error("Invalid face rectangles format. Expected Nx4 mat with type CV_32SC1"));
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function ‘void OpenPoseWrapper::detectHands(const cv::Mat&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:174:86: error: ‘BOOST_THROW_EXCEPTION’ was not declared in this scope
         BOOST_THROW_EXCEPTION(std::runtime_error("Hand network was not initialized."));
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function ‘void OpenPoseWrapper::detectHands(const cv::Mat&, const cv::Mat&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:193:86: error: ‘BOOST_THROW_EXCEPTION’ was not declared in this scope
         BOOST_THROW_EXCEPTION(std::runtime_error("Hand network was not initialized."));
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:197:120: error: ‘BOOST_THROW_EXCEPTION’ was not declared in this scope
 td::runtime_error("Invalid hand rectangles format. Expected Nx8 mat with type CV_32SC1"));
                                                                                ^
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function ‘cv::Mat OpenPoseWrapper::render(const cv::Mat&)’:
/home/liffon/PyOpenPose/PyOpenPoseLib/OpenPoseWrapper.cpp:214:77: error: ‘class op::CvMatToOpOutput’ has no member named ‘format’
     std::tie(scaleInputToOutput, outputArray) = membersPtr->cvMatToOpOutput.format(rgb);
                                                                             ^
PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/build.make:62: recipe for target 'PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/OpenPoseWrapper.cpp.o' failed

If I'm correct, the error messages about op::FaceExtractor and op::HandExtractor messages are caused by a commit in OpenPose that changed them to be abstract classes.
The Boost errors I'm guessing are caused by this commit in OpenPose that caused Boost to no longer be included in the OpenPose headers (so we probably have to include them explicitly from PyOpenPose).
The ones with op::CvMatToOpInput and op::CvMatToOpOutput seem to come from the same commit as the op::FaceExtractor and op::HandExtractor errors, as does the op::PoseGpuRenderer one.
It might be worth mentioning that I've compiled OpenPose using CMake and installed it system-wide with sudo make install as suggested by the OpenPose documentation.

Confirmed, also getting the same error.

Yes, the api changes were made on openpose commit: 5160a127fe871d39f38a0cf05d60200bbe84d2c8
I will commit a patch on Monday.

I pushed an update for the API changes in openpose.


Panorama on mobile is aligned left even with startPosition: 0.5

Hello panorama image is aligned to left edge of screen on mobile devices (chrome android, safari ios) even when I use: startPosition: 0.5 ? On desktop computers is working fine.

The issue you are facing is two-fold: (1) the deviceOrientation event listening is bonked in a recent demo, but has been fixed as of 5147516, and (2) as per documentation, when deviceOrientation is being listened on, the startPosition option will be ignored: "This option will be nullified when gyroscopic data is in use."


plugin: implementing plugin API

@vincenzopalazzo What is needed here

implementing the go API to implement a plugin in core lightning, how a develop a plugin is implemented here https://lightning.readthedocs.io/PLUGINS.html#a-day-in-the-life-of-a-plugin


Add method to close the processing session

This method disconnects ion-avp from ion-sfu for this specific session.
The next step would be to expose this in the gRPC interface.

I believe the session should be closed when you close the gprc stream

I believe the session should be closed when you close the gprc stream

That makes sense. I'm using ion-avp as a library rather than as a separate server. I should probably keep this change in my fork for now, until I can change to use ion-avp as a server. Thanks!

That makes sense. I'm using ion-avp as a library rather than as a separate server. I should probably keep this change in my fork for now, until I can change to use ion-avp as a server. Thanks!


Complain about .modal.hide Bootstrap v2-ism

Fixes #221.

Coverage remained the same at 100.0% when pulling 6324fa3b4f4599cffc9d4f1c1f42e04ec9fec619 on fix-221 into a69f995ad5b7d3890a8dd32eda01e93c241cb315 on master.


Create unknown codec error

I get an error as soon as the controller.create method runs on Android. The error is as follows: PlatformException (PlatformException(failed_to_create_live_stream, java.security.InvalidParameterException: Failed to create unknown codec for: {mime=video/avc, width=720, height=1280}, null, null))
This also occurs when I clone and run the example project or run my own project.

Device: Samsung Galaxy j7 Prime 2
OS: Android 9
Flutter version:3.0.4

Hello,
I am pretty sure your device has a codec that supports AVC/H.264 1280x720...
Have you call controller.create multiple times? Or setVideoParameters multiple times ?
Have you try to restart your device before testing ?
Best regards,
Thibault

bitrate: 60 is really really low.
How old is your device?
Could you test this class from StreamPack:
object Video {
        /**
         * Get supported video encoders list
         */
        val supportedEncoders = getSupportedMediaCodecEncoders()

        /**
         * Get device video encoder list.
         *
         * @return list of supported video encoder
         */
        private fun getSupportedMediaCodecEncoders(): List<String> {
            val encoders = mutableListOf<String>()
            MediaCodecList(MediaCodecList.REGULAR_CODECS).codecInfos
                .filter { it.isEncoder }
                .flatMap { it.supportedTypes.toList() }
                .filter { it.isVideo() }
                .distinct()
                .forEach { encoders.add(it) }

            return encoders
        }

        /**
         * Get video encoder video capabilities.
         *
         * @param mimeType video encoder mime type
         * @return encoder video capabilities
         */
        private fun getCapabilities(mimeType: String): MediaCodecInfo.VideoCapabilities {
            require(mimeType.isVideo()) { "MimeType must be video" }

            val format = MediaFormat().apply { setString(MediaFormat.KEY_MIME, mimeType) }
            val mediaCodecList = MediaCodecList(MediaCodecList.REGULAR_CODECS)
            val encoderName = mediaCodecList.findEncoderForFormat(format)

            val mediaCodec = MediaCodec.createByCodecName(encoderName)
            val videoCapabilities = mediaCodec.codecInfo.getCapabilitiesForType(
                mimeType
            ).videoCapabilities
            mediaCodec.release()
            return videoCapabilities
        }

        /**
         * Get video encoder supported heights.
         *
         * @param mimeType video encoder mime type
         * @return range of supported heights
         */
        fun getSupportedHeights(mimeType: String): Range<Int> =
            getCapabilities(mimeType).supportedHeights

        /**
         * Get video encoder supported widths.
         *
         * @param mimeType video encoder mime type
         * @return range of supported widths
         */
        fun getSupportedWidths(mimeType: String): Range<Int> =
            getCapabilities(mimeType).supportedHeights

        /**
         * Get video encoder supported frame rate range.
         *
         * @param mimeType video encoder mime type
         * @return range of frame in b/s
         */
        fun getFramerateRange(mimeType: String): Range<Int> =
            getCapabilities(mimeType).supportedFrameRates

        /**
         * Get video encoder supported bitrate.
         *
         * @param mimeType video encoder mime type
         * @return range of bitrate in b/s
         */
        fun getBitrateRange(mimeType: String): Range<Int> =
            getCapabilities(mimeType).bitrateRange
    }

with mimeType = MediaFormat.MIMETYPE_VIDEO_AVC
Could you get supported height, width, framerate range, bitrate range and capabilities?

The problem here is not with the bitrate. It also works fine when I enter a higher value for Bitrate. It's only a problem when the resolution is higher than 480. Is there a bitrate you recommend? I can enter any value I want here.

Then, use the default bitrate from VideoConfig.withDefaultBitrate

initialVideoConfig: VideoConfig.withDefaultBitrate(resolution: Resolution.RESOLUTION_480),
It worked great this way. Thanks


Random test failures

Sometimes the tests in GitHub are failing and I don't know why. The latest run failed but then succeeded when I re-ran it.
It does seem to be running the tests on iOS 18.1 which I think is still in beta. Perhaps we should force it to use 18.0 or the latest version of iOS 17 for now?

I ran into this too. I agree enforcing a stable iOS version is a good thing to try. I had also noticed that some of the versions of the reusable GitHub Action stages we leverage were reported as deprecated, but it looks like you already fixed that.
Separate issue, but I also noticed that the pipeline isn't accurately noticing when the build stage fails. This makes the output confusing, because the pipeline carries on to the subsequent test stages which complain about the app bundle not existing. Example: https://github.com/soundscape-community/soundscape/actions/runs/10754605735/job/29825643227

set to iOS 18.0 in #107
The problem was that piping the build output into xcpretty swallowed the exit code. that should also be fixed in #107  according to xcpretty documentation.

It looks like this is still a problem (the most recent commit still needed to be run twice before it passed). I dug into the output log and have a theory, though not a fix.
A common property of the inconsistently failing tests is triggering speech. Based on some discussions online (e.g. https://stackoverflow.com/a/73886077, https://forums.developer.apple.com/forums/thread/708114), as of iOS 16, the simulator no longer comes with voices installed by default -- you need to manually open the Settings app within the simulator and install voices individually. This is consistent with what I observed after an upgrade some time within the last year, when all the voices disappeared from inside the simulator on my Mac. I'm not sure how/if this can be done in an automated way inside a pipeline. Nor can I explain why the failures are only inconsistent.
Below is an excerpt of the output from a failing test:
Test Case '-[UnitTests.AudioEngineTest testDiscreteAudio2DSimple]' started.
2024-09-20 17:26:14:571 [AUS] Category set (playback, default, options: none)
2024-09-20 17:26:14:571 [AUD] Initializing audio engine
2024-09-20 17:26:14:572 [AUD] Connecting audio graph in 3D mode (from <OperationQueue: NSOperationQueue Main Queue>)
2024-09-20 17:26:14:578 [AUS] Audio session activated
2024-09-20 17:26:14:578 [AUD] Starting audio engine (from services.soundscape.audioengine)
2024-09-20 17:26:14:591 [AUD] Resuming 0 players
2024-09-20 17:26:14:591 [AUD] Audio engine does not need to be started (it is already running)
2024-09-20 17:26:14:591 [AUD] Resuming 0 players
2024-09-20 17:26:14.604324+0000 Soundscape[13330:54459] [general] NSBundle file:///Library/Developer/CoreSimulator/Volumes/iOS_22A3351/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS%2018.0.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/TextToSpeech.framework/ principal class is nil because all fallbacks have failed
2024-09-20 17:26:14.639504+0000 Soundscape[13330:54459] [general] NSBundle file:///Library/Developer/CoreSimulator/Volumes/iOS_22A3351/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS%2018.0.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/TextToSpeech.framework/ principal class is nil because all fallbacks have failed
2024-09-20 17:26:14.651305+0000 Soundscape[13330:54459] [general] NSBundle file:///Library/Developer/CoreSimulator/Volumes/iOS_22A3351/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS%2018.0.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/AccessibilityUtilities.framework/ principal class is nil because all fallbacks have failed
2024-09-20 17:26:15:436 [AUD] Tried to play next sound when the current sound was still playing (Optional(C4ED4483-A943-44F2-BC9F-200D513CAF31))...
2024-09-20 17:26:15:437 [AUD] Tried to play next sound when the current sound was still playing (Optional(C4ED4483-A943-44F2-BC9F-200D513CAF31))...
2024-09-20 17:26:16.354521+0000 Soundscape[13330:54581] [asset] Failed to get sandbox extensions
2024-09-20 17:26:16.438687+0000 Soundscape[13330:54581] [catalog] Query for com.apple.MobileAsset.VoiceServicesVocalizerVoice failed: 2
2024-09-20 17:26:16.441707+0000 Soundscape[13330:54581] [asset] #FactoryInstall Unable to query results, error: 5
2024-09-20 17:26:16.445212+0000 Soundscape[13330:54581] [catalog] Unable to list voice folder
2024-09-20 17:26:16.475853+0000 Soundscape[13330:54581] [catalog] Query for com.apple.MobileAsset.VoiceServices.GryphonVoice failed: 2
2024-09-20 17:26:16.476080+0000 Soundscape[13330:54581] [catalog] Unable to list voice folder
2024-09-20 17:26:16.478170+0000 Soundscape[13330:54581] [catalog] Query for com.apple.MobileAsset.VoiceServices.CustomVoice failed: 2
2024-09-20 17:26:16.478843+0000 Soundscape[13330:54581] [catalog] Unable to list voice folder
2024-09-20 17:26:16.473348+0000 Soundscape[13330:53937] [catalog] Query for com.apple.MobileAsset.VoiceServicesVocalizerVoice failed: 2
2024-09-20 17:26:16.489509+0000 Soundscape[13330:53937] [catalog] Unable to list voice folder
2024-09-20 17:26:16.587649+0000 Soundscape[13330:53937] [catalog] Query for com.apple.MobileAsset.VoiceServices.GryphonVoice failed: 2
2024-09-20 17:26:16.589387+0000 Soundscape[13330:53937] [catalog] Unable to list voice folder
2024-09-20 17:26:16.596751+0000 Soundscape[13330:53937] [catalog] Query for com.apple.MobileAsset.VoiceServices.CustomVoice failed: 2
2024-09-20 17:26:16.597445+0000 Soundscape[13330:53937] [catalog] Unable to list voice folder
2024-09-20 17:26:16.780426+0000 Soundscape[13330:53937] [catalog] Query for com.apple.MobileAsset.VoiceServicesVocalizerVoice failed: 2
2024-09-20 17:26:16.782910+0000 Soundscape[13330:53937] [catalog] Unable to list voice folder
2024-09-20 17:26:16.797422+0000 Soundscape[13330:53937] [catalog] Query for com.apple.MobileAsset.VoiceServices.GryphonVoice failed: 2
2024-09-20 17:26:16.802185+0000 Soundscape[13330:53937] [catalog] Unable to list voice folder
2024-09-20 17:26:16.825969+0000 Soundscape[13330:53937] [catalog] Query for com.apple.MobileAsset.VoiceServices.CustomVoice failed: 2
2024-09-20 17:26:16.827267+0000 Soundscape[13330:53937] [catalog] Unable to list voice folder
2024-09-20 17:26:24.398982+0000 Soundscape[13330:54468] [AMCP]  50955          HALC_ProxyIOContext.cpp:1619  HALC_ProxyIOContext::IOWorkLoop: skipping cycle due to overload
/Users/runner/work/soundscape/soundscape/apps/ios/UnitTests/Audio/AudioEngineTest.swift:64: error: -[UnitTests.AudioEngineTest testDiscreteAudio2DSimple] : XCTAssertEqual failed: ("XCTWaiterResult(rawValue: 2)") is not equal to ("XCTWaiterResult(rawValue: 1)")
/Users/runner/work/soundscape/soundscape/apps/ios/UnitTests/Audio/AudioEngineTest.swift:65: error: -[UnitTests.AudioEngineTest testDiscreteAudio2DSimple] : XCTAssertEqual failed: ("0") is not equal to ("1")
Test Case '-[UnitTests.AudioEngineTest testDiscreteAudio2DSimple]' failed (24.770 seconds)

Apparently using the tts api triggers a voice to be installed. I suspect it succeeds the second time because GitHub is caching the macos instance and the voice has already been downloaded
We could possibly add a test that runs first to trigger a voice download and waits for it to be availible.

Unrelated to the voice issue, but it is failing again with the latest macos image on github actions. It worked with version 20241022.361, but failed with version 20241108.442.
It doesn't seem to be accepting the target specification:
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, variant:Designed for [iPad,iPhone], id:0000FE00-C561D0E269705BEC, name:My Mac }
(...}

According to the readme for the image the iOS 18 simulator is only available with Xcode 16, and 18.1 with Xcode 16.1.
I'm not sure there's much we can do other than to manually update the workflow each time a version becomes unsupported.

Seems to be okay after updating the workflow to iOS 18.1 / Xcode 16.1

Should we revert to the action using the latest, possibly beta iOS version? Hard-coding the iOS version didn't fix the problem here, and I'd rather have potential future failures reported earlier than be stuck on a single version until someone manually changes it.

There's the Xcode version to deal with as well. I have it working with the latest stable Xcode, iOS version determined automatically by Xcode in my fork.
The run is here: https://github.com/RDMurray/soundscape/actions/runs/11818261318/job/32925422972#step:3:1


Flush file before unlocking it

With the current implementation, there is a race condition when the lock file is unlocked but the changes have not been flushed yet, resulting in a second process reading the old version of the file.

This change is

@bubenkoff would you mind checking this and possibly make a new release?


3.7.3 regression: useDefineForClassFields + private = broken emit

TypeScript Version:  3.8.0-dev.20191207

Search Terms: usedefineforclassfields private
Code
// enable --useDefineForClassFields

class C {
    private foo: number;
    constructor() { this.foo = 0; }
}

new C();

Expected behavior:
Code works properly at runtime.
Actual behavior:
Code throws at runtime because the emit for an uninitialized private field is:
        Object.defineProperty(this, "foo", {
            enumerable: true,
            configurable: true,
            writable: true,
            value: foo
        });

foo is being initialized to foo, which of course doesn't exist!
This is a regression in TypeScript 3.7.3, discovered after updating.  I spent about 10 minutes stepping through the debugger looking for the source of the runtime exception before I finally thought to check the emitted JS and discovered it was invalid.
Playground Link:
https://www.typescriptlang.org/play/?useDefineForClassFields=true&ts=3.8.0-dev.20191207&ssl=1&ssc=1&pln=5&pc=1#code/PTAEFMDsEMCMBtygKoGdwBFwDMCWlwAxAewCcBheaVVQ3ceAE1QFgAoAYyptHNAG92oYaAAOpXADdoAFyTZixAFyhIAVwC2scKQDcQkR2KRUM0mo4yyACgCUA0DIAWuVADoFxUAF5QABl1QAF92ELZ2AgB3Xjt9NiA
Related Issues:
Couldn't find anything that seemed relevant.

Relevant source... I have no idea why the branch for a modifier is there. Introduced by 369900bb078049a839c09d1b1d53742ab0ddba27:
https://github.com/microsoft/TypeScript/blob/369900bb078049a839c09d1b1d53742ab0ddba27/src/compiler/transformers/classFields.ts#L421-L423

I want to add that this also happens for uninitialized public properties as well, if the public modifier is used when declaring the property.
version: 3.7.3
Code:
class SomeClass {
  someProp: number;
}

class SomeClassWithPublicProp {
  public someProp: number;
}

Output:
class SomeClass {
    constructor() {
        Object.defineProperty(this, "someProp", {
            enumerable: true,
            configurable: true,
            writable: true,
            value: void 0
        });
    }
}

class SomeClassWithPublicProp {
    constructor() {
        Object.defineProperty(this, "someProp", {
            enumerable: true,
            configurable: true,
            writable: true,
            value: someProp
        });
    }
}

It will happen with any uninitialized property if that property has a modifier (readonly, public, private, protected)

The branch with the initializer is there to handle parameter properties. Seems like the condition needs to be more strict.
@sandersn

@ajafff that doesn't make sense to me given that the function accepts a PropertyDeclaration and parameter properties don't have a PropertyDeclaration node. See ast-viewer
Though then again, the function is named transformInitializedProperty and handles uninitialized properties... so maybe my intuition here is wrong

hasModifier(getOriginalNode(property), ModifierFlags.ParameterPropertyModifier)

If my reading of this is correct, it’s checking for only the “parameter property” modifier, but for some reason is picking up all modifiers.  The only lead I have is an observation that parameter properties always have a modifier, and deduce that, perhaps, the implementation of that was hacked together in such a way that it can’t actually distinguish between the two...
...but that doesn’t really make sense for other reasons so I’m probably totally off-base.  We’ll see what an actual compiler dev has to say before jumping to conclusions. :wink:

The offending code is inside a transform. When it gets executed, parameter properties have already been transformed to property declarations.
ParameterPropertyModifier is just a shorthand for public, protected, private and readonly. These are valid for parameter properties and regular properties, so it needs to check whether the property originated from a parameter.

Ah hah, so I was (mostly) right!

I've submitted PR which will fix this issue, so could you check for it please?
https://github.com/microsoft/TypeScript/pull/35898


deis tags per process type

It could be useful if you could configure process types to run in particular places based on fleet metadata with deis tags.
For example, if you have asynchronous workers that don't necessarily have to be on a fast machine but you want your web processes on better hardware.  Or you have asynchronous workers which require a lot of CPU/Memory and you want to schedule them only on hardware that could support it.
Right now, you have to have separate apps for them which can lead to a lot of redundancy, multiple pushes/envirionment config, etc.
I understand not everyone is running a heterogeneous cloud environment but there is some aspect of cluster cost maintenance untapped here where you could have redundant large hosts paired with redundant smaller hosts and reserve the large hosts for process types that need them.  Case in point here from a deis core perspective, the deis-builder.

I can see the use case for this. This is actually how deis limits works too, so it makes sense :+1:

Yeah, deis limits can help with this problem in the sense that a process type won't eat up more CPU/Memory then you lend it.  If your machines are all equally powerful, then this works well.  I had forgotten you could set limits by process type, though.

I think this makes a lot of sense and is worth exploring :+1:

Have anyone started to work on this?
I tried to start something, but I got really lost on the Django migrations.

It would be great to have deis tags extended to support this. We have a lot of applications with frontend and backend components which we'd like to segregate.

This issue was moved to deis/controller#1212


How to get the MANO hand faces/ triangles for the image data?

Dear authors,
I am trying to obtain hand faces/ triangles for the OakInk-Image part. I see that you already have code to do this for the OakInk-Shape here . How can I obtain this for the image part data? Should I just add a simple class method here that takes MANO hand shape and hand pose as input to the ManoLayer and access ManoLayer.th_faces?
Thanks

Yes, you can access the MANO hand faces through a static ManoLayer object.
Current the oikit only provide the bare usage: load image, load annotations, and visualize.
Feel free to customize.
Thanks.

Thanks!


Include screencap of studio flow

Addressed in https://github.com/ayyrickay/sms-reminder-demo/pull/3


Sub-buttons don't work when double tap action set to no action

Describe the bug
Sub button don’t work anymore snif in some case:
buttons are no more detected as “button” mousse icon don’t change when it goes on the sub-buttons.
To Reproduce
I found what parameter is causing the issue: it is when I put “no action” in the “Doubble Tap action” on “Top action on icon”
Expected behavior
Action linked to sub_button
YAML
type: custom:bubble-card
card_type: button
entity: light.cellier_lumiere
tap_action:
  action: none
double_tap_action:
  action: none
name: 'Cellier '
show_last_changed: true
show_state: true
sub_button:
  - entity: light.cellier_lumiere
    icon: ''
    tap_action:
      action: toggle
    double_tap_action:
      action: more-info
  - entity: binary_sensor.cellier_fenetre
styles: >
  .bubble-button-card-container {
    border-radius: 10px !important;
    background: rgba(70, 240, 70, 0.4);
  }
  .bubble-icon {
    opacity: 1;
    color: white !important;
  }
  .bubble-sub-button-2 {
    background-color: ${hass.states['sensor.mosquitto_broker_openstate_11'].state === 'OPEN_FRENCH' ? 'red' : hass.states['sensor.mosquitto_broker_openstate_11'].state === 'OPEN_HOPPER' ? 'rgba(87, 160, 238, 1)' : 'green'} !important;
  }

  ${subButtonIcon[1].setAttribute("icon",
  hass.states['sensor.mosquitto_broker_openstate_11'].state === 'OPEN_FRENCH' ?
  'kuf:fts_window_2w_open' :
  hass.states['sensor.mosquitto_broker_openstate_11'].state === 'OPEN_HOPPER' ?
  'kuf:fts_window_2w_tilt' :'kuf:fts_window_2w')}
icon: hue:room-closet
button_type: state
hold_action:
  action: none
button_action:
  tap_action:
    action: none
  double_tap_action:
    action: none
  hold_action:
    action: none

Informations (please complete the following information):

OS: all
Browser/App: brave
Bubble Card version: since all 2.1.x
Home Assistant version: 2024.7.4

Hi and thank you for the feedback! This issue is now fixed!
https://github.com/Clooos/Bubble-Card/releases/tag/v2.2.0

Merci !
Tested and all good.
Thanks


Income Account gets updated with package update

Describe the bug

When seed package has no income account and importer has already Income acc in service then system does nothing.
When Seeded package has different income acc than Importer side then system updates the Income acc.

According to me system should update Income Account only if that field is blank.

rishi ka sochna sahi hai. agar change karna mahenat ho to abhi jaisa hai woh bhi chalega.

As discussed with Vinod sir, leaving it as it is..


/how-can-i-help: carousel not displaying articles

I thought the issue was that the subsections referred to in the Caroussel were children of a full section that was "Marked for deletion", so I unlinked them (making the Subsections not children of anything), but it did not solve the issue.


Support for Angular 14

Can you provide new version with support for Angular 14

I can look at this the middlte of August. If you need it earlier, make a PR and ask @chymz to get new npm package

@chymz : please create a new npm package.

done!


Add Vault example to the traffic shaping section.

Add a small section to the Traffic Shaping documentation detailing how to use Fabio to route traffic for Vault to the active node.
Ref: https://twitter.com/jrasell/status/1100724689767485440

Thank you!


Problem with lazyLoading + freeMode + mousewheelControl

Hi Vladimir,
First of all, wonderful script - thank you! :)
I am trying to implement an image gallery with lazy loading in conjunction with the free mode and mousewheel control. However, I can't get the lazy loading to work correctly.
The first few images load but after that nothing happens and the preload spinners just sit there for the remaining images. There are no errors, and after testing it, I've figured out that the images don't lazy load when they are scrolled into view via the mousewheel (however the swiper-slide-visible class is applied correctly).
It will work when I click and drag to scroll but this defeats the goal of having the mousewheel control, which is much nicer than having to constantly click and drag.
I've prepared a demo here illustrating the problem: http://codepen.io/anon/pen/GompzX
Is this a bug or a known limitation? I would really love to get it working and it seems like it is very close!
Also, bonus question: would it be possible to lazy load several images ahead of the scroll position instead of just one more than is visible? Maybe an extra 3-5 images would be nice so that there isn't much lag when scrolling through.
Many thanks for any help!
Stephen

Brilliant! Thanks so much @nolimits4web :)
The lazy loading with the mousewheel is working very nicely now!
However, for the loading N next/prev slides, I am not sure it is working for me.
I updated the code to v3.3.0 and I set lazyLoadingInPrevNextAmount: 3 but it only seems to load the next slide when it scrolls into view. Checking the Network monitor confirms this - only visible items load.
Here are the settings I'm using:
direction: 'horizontal',
slidesPerView: 'auto',
spaceBetween: 7,
mousewheelControl: true,
freeMode: true,
preloadImages: false,
lazyLoading: true,
watchSlidesVisibility: true,
lazyLoadingInPrevNext: true,
lazyLoadingInPrevNextAmount: 3

Is there something else I should do to make the N next/prev slides load? I guess I should open a new ticket for this...


"run_not_found" test is failing

___ test_run_not_found ___

    def test_run_not_found():
        status, result, again = run(['notfound'])
        assert status == 'not found'
>       assert result == "[Errno 2] No such file or directory: 'notfound'"
E       assert "[Errno 2] No...': 'notfound'" == "[Errno 2] No ...y: 'notfound'"
E         Skipping 36 identical leading characters in diff, use -v to show
E         -  'notfound': 'notfound'
E         +  'notfound'

- is actual output, + is expected.
So, it's getting [Errno 2] No such file or directory: 'notfound': 'notfound' instead of [Errno 2] No such file or directory: 'notfound'.
I've disabled the test in 234ef668b74cc20f5f302c6b950e36d26d68bdd5.

234ef668b74cc20f5f302c6b950e36d26d68bdd5


[FEAT]: contributor card

Is your feature request related to a problem? Please describe.
Based on what I saw the discussion here We can add projects card.
Describe the solution you'd like
My solution is we will added the contributor card to list of /contributors page. on the card of list contributor will added one button let's say my card (this name will not necessarily be the same). this button will show the card like this :
Example :

IMPORTANT
If it's your first Contribution to this project, please add your details to the Contributors file
File Path: src/json/Contributors.json and you have to MUST read the contributing guideline before you start.  Read this Guideline Before you start

If you do not add your details or assigned to issue, your PR will be Close

Completed #345


feat: added example coverage for HIP-865

Description:

upgrade the solidity version to 0.8.24 and specify the evmVersion to Cancun in hardhat.config.js
adds example coverage for HIP-865 about the new Cancun Opcodes for Transient Storage and Memory Copy.

Related issue(s):
Fixes #688
Related #725
Notes for reviewer:
The artifact files of the erc-721 and erc-20 are modified as the solidity version is upgraded.
Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

System Contract DApp failing CIs are reported in this issue https://github.com/hashgraph/hedera-smart-contracts/issues/817


Added explicit downcasting

XCode gave 7 compiler errors due to non-explicit downcasting (e.g. we have to use as! instead of as). Please test before merging as I'm not sure if this will work exactly as intended.

Duplicate of #7. I'll add Swift 1.2 support today, since this is now supported by Travis CI.


Convert binary mask to polygon

❓ Questions and Help
Is there a function that allows me to convert binary masks to polygons? this would help in training the model on new datasets that come with polygons like COCO.
Thanks!

Thanks for the reply.
Aren't polygons and RLE less expensive to operate on than binary masks (unless it's sparse binary mask)? I think the pycocotools evaluation expects polygons/rle to compute the AP scores, right?

@IssamLaradji In my case, instance masks may have holes, so you can not use polygons and binary mask is the only way. And binary mask do use more GPU memory.


Use environment variables and substitutions to dynamically build from branches

Following discussion with @o-smirnov, here is my WIP on using environment variables and substitutions to make per branch images. There are still issues at present:

The builder assumes that the latest tag must be assigned, and that the version in points to must exist. I think that it may be better to assume that there is no latest tag, and only act when it is explicitly given. The current logic for assigning the latest tag can definitely result in unintended images being tagged as latest.
The substitutions don't currently get propagated into image_info.versions. This makes things a little tricky as the version key changes as the builder progresses. My current approach just used the unsubstituted key but that seems a little dodgy.

Ok, I went with the simplest solution. There is now simply an option which completely disables the latest tag logic by setting tag_latest[image]= None for all images. This seemed less error prone than sometimes honouring the tag when we happen to on the correct branch. Instead, I have opted to expand the CI on breifast to behave slightly differently. Specifically, only successful merges to master will trigger the latest tag updates. Does that seem sensible?


Add getPayloadV3 with builder override flag

Specs out the proposal made in https://github.com/ethereum/execution-apis/pull/388 in a separate builder-override.md document allowing it to be implemented out of the scope of the next fork

it would be nice to see an end-to-end prototype of this feature working, e.g. for censorship resistance, before deciding we need to add an entirely new feature to the engine-api
on its own this change is small but we will also keep accumulating them over time

closing if favour of https://github.com/ethereum/execution-apis/pull/425


bugfix/issue #3763 partially extracted nugets

fixing partial nuget extraction #3763 by extending fixes for borked and leaky zips to catch more cases

This is released in v6 alpha channel. Can you please test it out and then I'll push it to v5 as well. Thanks for your help!

Verified 6.0.0-alpha009 with previously failing dependencies -- the expected yellow warning "Trying to extract files individually" shows up, and the packages are fully extracted and work correctly in dotnet restore/build/run. Thank you!

It seems version 5.241.3 has some new merge/build issue -- paket install ends with:
Paket failed with
-> Resource stream 'Paket.Restore.targets' could not be found in the Paket.Core assembly

It happens on all install attempts, regardless of .paket\Paket.Restore.targets presence, and the file indeed does not re/appear with this version when not present.
It does not happen when 6.0.0-alpha009 is used for install, regardless if fresh or using 5.241.3 bootstrapper with version in paket.dependencies to use the alpha.

Damn. Unlisted that one.
Can you please try .4? If that also broken then I need to unlisted and
check that tomorrow.
Viktor Svub<EMAIL_ADDRESS>schrieb am So., 22. Dez. 2019, 13:02:

It seems version 5.241.3 has some new merge/build issue -- paket install
ends with:
Paket failed with
-> Resource stream 'Paket.Restore.targets' could not be found in the Paket.Core assembly
It happens on all install attempts, regardless of
.paket\Paket.Restore.targets presence, and the file indeed does not
re/appear with this version when not present.
It does not happen when 6.0.0-alpha009 is used for install, regardless
if fresh or using 5.241.3 bootstrapper with version in paket.dependencies
to use the alpha.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3764?email_source=notifications&email_token=AAAOANFJBXIGIS5TBHEPQDTQZ5JLZA5CNFSM4J6INUR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPOLNA#issuecomment-568255924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOAND6IRV2VHGHMNMDWLDQZ5JLZANCNFSM4J6INURQ
.

Ok never mind. It's still broken. Seems I need to dig deeper tomorrow.

ok released 5.241.5 and that one seems to work. I had to install VS 2019 because it used a wrong compiler version. ffs

thank you! 5.241.5 works perfectly :)


Filestream should be binary

This does not run in visual studio 2019 as is, and gives a cryptic memory exception .  It should specify ios::binary.

Thank you! It's been fixed in commit 03a4e1cb2cf4fbc78fbd2185c67e2acdf3418c65


Cannot read property 'some' of undefined

⚠ IMPORTANT ⚠ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

[x] Read the docs.
[x] Make sure the code is up to date. (Some bugs have been fixed in the latest code)
[x] This is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Describe the bug
3月23号下午15:00更新的最新代码，开发环境和生成环境都报 Cannot read property 'some' of undefined

System Info

Operating System: Windows
Node version: v12.16.3

固定 Back 不会有问题，应该是还没从 getProjectConfig 函数获取到 permissionMode 就执行下面的代码所致的问题


Add starter template tutorial for Bitbucket

Bitbucket's permissions don't allow deploy keys with write permission, which means that people can't create Bitbucket repos with a "Deploy to Netlify" button. Since this leaves Bitbucket users out from the Start with a Template page, it would be nice to be able to link to a tutorial on the Netlify CMS blog.
It could follow these steps:

Clone a starter repo to Bitbucket. The post could include both the Hugo and Gatsby starters from the templates page, since setup will be the same for either. The repos should be linked directly, rather than in Deploy to Netlify buttons.
Link the repository to Netlify (like in the video here).
Follow Step 1 of the Git Gateway backend setup. (Step 2 will already be done in the repo, and step 3 is optional.)
Continue with the steps to access Netlify CMS on your new site from the "Start with a Template" page.

I actually tried this yesterday without knowing this step by step suggestion existed as an open issue. Turns out Netlify doesn't allow a user to turn on Git Gateway in the Netlify admin panel when the repo is hosted on bitbucket. I might have missed something but my experience is that step 3 doesn't work.

D'oh, you're right. There's an internal PR for this in the Netlify UI, but it hit a snag. I'll update here when things change.

DId this ever get resolved or do we have to use github over bitbucket?


Be vintageous friendly

continued from  #372

Somehow this didn't work when I first tried it. It does, however, work now and is definitely a better approach.
{ "key": "setting.command_mode", "operator": "equal", "operand": false } is enough

Awesome, I like this much better.  Once you add the comments I requested, I'll merge this in!  I may revisit at some point to see if this can be further abstracted, so that Vintageous-specific settings become unnecessary.  But this seems a reasonable step for now.  Thanks for your work on this!

I've created a GsHandleVintageousCommand which has it's own docstring and keeps the code DRY. Hopefully placed it right.

That's perfect.  Thanks again!

This PR actually causes a bit of pain for me. Since the default mode when opening a view is command mode, to use GitSavvy shortcuts I must change to insert. Even changing between dashboards using TAB requires changing to insert mode every time. Honestly, even though the previous mode was lacking some vim-friendliness , at least it required much less keystrokes.

@asfaltboy set the vintageous_enter_insert_mode option to true

Brilliant! Why won't we set these to True by default?

Indifferent to me. Might be a good idea, as it mimics the default non-vintageous behaviour. What do you think, @divmain?

We should definitely document this feature if possible

Well, it is explained in the default settings file.

Yes, this is why I just opened issue #430 .


[UE5.3.2] Plugin does not work

System Information
Please provide the following information about your system:

Steam Audio version: 4.5.0
Unreal Engine version: 5.3.2 (Launcher)
Operating System and version: Windows 11 Home 22623.1037

Issue Description
I went through the necessary steps of deleting the version of Steam Audio that ships with the engine, and downloaded the 4.5.0 release from Github. Then I extracted the "SteamAudio" folder into my blank project's plugin folder, enabled it in the project, and set it up in the [Project Settings/Platforms/Windows] settings.
I then created a simple scene consisting of an extruded cube making up a wall, and an extruded cube making up the floor. I then tagged these cubes with the geometry component and exported the geometry, which I verified to be exported properly. However, when I created an actor with an audio component in the scene and set up the sound attenuation to use binaural spatialization with the steam audio config, it did not work, it sounded exactly the same as panning. Occlusion did not work either, at all.
Steps To Reproduce
Steps to reproduce the behavior:

Delete the built-in SteamAudio from UE5.3.2
Install SteamAudio 4.5.0 to a blank project.
Enable it, and set it up in platform settings.
Blockout a simple scene.
Tag all meshes using the plugin and export geometry.
Drag a soundcue into the scene and override it's attenuation settings.
Set the spatialization method to Binaural, and create a new steam audio asset for the spatialization plugin settings, where you enable binaural and set the interpolation to bilinear.
Enable occlusion and create a new steam audio asset for the plugin settings. Enable "apply occlusion" on this asset.

I tried to repro this issue, and I observed the following:

The spatialization plugin (i.e. setting Spatialization Method to Binaural) works fine.
The occlusion plugin does not work when playing in editor, but it does work when running a packaged build.

I think this has to do with the way the plugin is re-initialized when entering play-in-editor mode. Can you try commenting out line 138 of the function FSteamAudioModule::OnPIEStarted in Plugins/SteamAudio/Source/SteamAudio/Private/SteamAudioModule.cpp? This line currently reads:
Manager->ShutDownSteamAudio();

After commenting this line out, you will need to rebuild your project. If you are able to try this, let me know if it helps fix the issue. Thanks!

Commenting out line 138 and recompiling the plugin worked, thank you! 😄

Commenting out line 138 and recompiling the plugin worked, thank you! 😄

This issue should now be fixed in v4.5.1.


Automatic JSX runtime

Hello, thanks for coming up with this clever solution. Testing w/ Slate is critical yet very much unsolved, or at least it was until this came out! Where I work, we've been using Cypress w/ several hacks in place to test Slate. This is much faster, neater abstraction.
I was wondering if you had any idea how to enable the jsx extensions with an already set importSource using the automatic JSX runtime.
We're using Emotion, which requires us to set the pragma importSource to @emotion/react.
It would be so awesome if we could use the JSX using what's described in this packages README in addition to Emotion.
I'm not blocked, I can just not use JSX syntax and instead use the function exported from slate-hyperscript:
    jsx('editor', {}, [
      jsx('element', { type: 'paragraph' }, [
        jsx('text', ['potato']),
        jsx('text', { bold: true }, [' cucumbers', jsx('cursor')]),
      ]),
    ]),

Feel free to close this issue if it's off topic or you're not sure what the solution would look like.
Thanks again for creating and open sourcing this package!

Hey @hanford, I've ran into this a couple times on a previous project. Unfortunately I don't have a good solution beyond using separate files. For example, you can write the JSX hyperscript in one file and then import it into another file which is using a different pragma. If you create a small repo I can clone down I'm happy to give it a look if that's not helpful.


Adding php-builder docker image

This docker image is solely for creating debian packages that the php-nginx image will later download and use. That way, we'll be able to shorten the build time of the php-nginx itself significantly.
Fixes #34

@dazuma I'd appreciate your review too

@dazuma Thanks for the review. I changed the directory name to deb-package-builder. PTAL

I intentionally stopped the test to avoid hitting some quota behind the cloudbuild. I will re-run the test after a while.


chore: support local model for running e2e tests

Add support for using a local model for e2e testing.

Which issue(s) does this pull-request address?
Currently e2e testing requires a remote service which may cost people $ to run. Add the option
to use a model running locally if OLLAMA_HOST is set. If an API key is specified the associated
service will be used in preference to OLLAMA_HOST so this change should have no effect on
people not trying to use a local model.
Description

If OLLAMA_HOST is set and no other API keys are providced use that host to run the e2e tests.
Checklist

[X] I have read the contributor guide
[X] Linting passes: yarn lint or yarn lint:fix
[X] Formatting is applied: yarn format or yarn format:fix
[X] Unit tests pass: yarn test:unit
[X] E2E tests pass: yarn test:e2e
[X] Tests are included
[X] Documentation is changed or added
[X] Commit messages and PR title follow conventional commits

It takes about 10 minutes for the e2e tests to pass with my local ollama instance with a 4070ti super, but unless I have to debug issues that's better for me than having to use a service where I pay for the requests.

@Tomas2D we could read the model from a .env file, however, not all versions work/pass the e2e tests. That was the smallest/lowest quantization that I found worked so there is some value in sharing which model will succeed when running the e2e tests.

@Tomas2D I'll give it a try again, with the smaller models. I had tried a few and seen failures but maybe something else was going on.

Not sure what I had wrong when I ran the tests earlier, but super happy that they pass with the smaller model.
Updated to inline as requested, to use llama3.1:8b by default and to use process.env.OLLAMA_MODEL to override it exists./

@Tomas2D updated as requested. I had to work around the problem that the undici RequestInit does not extend the standard fetch one  ( I guess since it does not implement all of the options) but I was using an option not defined in the standard fetch one.

Rebasing to pull in the latest seem to results in failures running the e2e tests, but I also tried using OpenAI instead of ollama and got a bunch of failures as well, so I don't think that is related to this PR.
Is there a known issue with the e2e tests or something I need to do beyond rebasing after the addition of the examples to the e2e tests?

The E2E Tests and E2E Examples should be fixed now.

@Tomas2D thanks for confirming, rebased.


APT source whitelist updates for Chef repos

Chef Software Inc’s existing PackageCloud APT repo has been deprecated. The new packages.chef.io APT repo has equivalent versions for all products and should be a drop in replacement.
See the following Chef mailing list post for full details:
https://discourse.chef.io/t/we-ve-moved-our-software-distribution-to-packages-chef-io/8001

I'm not sure what the Travis failure wants me to fix:
0.01s$ diff -u ubuntu.json <(jq 'sort_by(.alias)' < ubuntu.json)
--- ubuntu.json	2016-03-22 18:31:17.195901022 +0000
+++ /dev/fd/63	2016-03-22 18:32:11.959901022 +0000
@@ -60,13 +60,13 @@
     "key_url": "https://downloads.chef.io/packages-chef-io-public.key"
   },
   {
-    "alias": "chef-stable-precise",
-    "sourceline": "deb https://packages.chef.io/stable-apt precise main",
+    "alias": "chef-current-trusty",
+    "sourceline": "deb https://packages.chef.io/current-apt trusty main",
     "key_url": "https://downloads.chef.io/packages-chef-io-public.key"
   },
   {
-    "alias": "chef-current-trusty",
-    "sourceline": "deb https://packages.chef.io/current-apt trusty main",
+    "alias": "chef-stable-precise",
+    "sourceline": "deb https://packages.chef.io/stable-apt precise main",
     "key_url": "https://downloads.chef.io/packages-chef-io-public.key"
   },
   {
The command "diff -u ubuntu.json <(jq 'sort_by(.alias)' < ubuntu.json)" exited with 1.

This has been merged. It looks good from my testing.
If you've got a build which tests installing the package, please run it and let us know how it looks for you.


feat: add documentation for go sdk

@danijelTxFusion can you also add a "Requirements" section with any requirements like the minimal version of Go required, and a link to an installation guide?

@danijelTxFusion can you also add a "Requirements" section with any requirements like the minimal version of Go required, and a link to an installation guide?

It's already added here.

@danijelTxFusion as discussed, can you add the example for ZksGetConfirmedTokens in the getting started page?

Before you merge this PR, you need to create the menu links.

Before you merge this PR, you need to create the menu links.

I guess they are already added here.


feat(middleware): Add concept of middleware for calling html-sketchapp APIs

Since I landed brainly/html-sketchapp#90 with resizingCintraints api I've been trying to think of a good way to expose calling APIs from here.
So I've come up a kind of middleware concept with this as something that works but happy to iterate on this.
Using it
html-sketchapp-cli --symbol-middleware 'src/middleware.js'

cli.js then requires this based on the presence of this flag and passes it through to snapshotSymbols which then calls it while looping over each layer.
Where it passes through a bunch of stuff the most important one being the layer so I can call layer.setResizingConstraint() on it and a few of the constructors to check instanceof types and change resizingContraints based on that.
Example middleware
module.exports = (args) => {
  const { layer, SVG, RESIZING_CONSTRAINTS } = args;
  const { TOP, LEFT, WIDTH, HEIGHT } = RESIZING_CONSTRAINTS;

  if(layer instanceof SVG) {
    layer.setResizingConstraint(TOP, LEFT, WIDTH, HEIGHT);
  } else {
    layer.setResizingConstraint(LEFT, TOP);
  }
};

Just a couple questions, which I apply to every potential feature:

Since we're trying to be a bit more opinionated in this tool, is this something we could be opinionated about? Does it even need to be configurable at all? Why/why not?
If it needs to be configurable, could it be locally configurable, via data attributes, etc?

Since we're trying to be a bit more opinionated in this tool, is this something we could be opinionated about? Does it even need to be configurable at all? Why/why not?

It definitely could be but was trying not to enforce my use case on other people who might use this tool.

If it needs to be configurable, could it be locally configurable, via data attributes, etc?

It can in some parts and I have some code (not pushed) that uses data-sketch-resizing-constraint attributes where possible. But for somethings like extracting out svg backgrounds and creating actual elements for pseudo-elements would require a hook like I've done here to modify the sketch layer.
So this could be both, use the data attribute if possible otherwise you can fallback to the middleware concept or whatever it ends up being.

So this is what I had when using data attributes:
<Alert type="success">
  <Title data-sketch-resizing-constraint="top left">Success Alert</Title>
  Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut laboreet dolore magna aliqua.
</Alert>

Some elements I can apply this others I can't like the text below <Title>. This component also has a background svg applied that i inject at run time, see brainly/html-sketchapp#81.
So I think we'd need both cases.

Had a closer look at this, and I think this makes sense to me if I view it as an escape hatch. Long term, I feel like resizing constraints should be handled for you, but I can see the need for this as an interim solution.
For this to be approved, I think we need a new snapshot test that sets some resizing constraints, and some documentation in the readme.
Also, do you think we could add support for functions as config values too, not just file paths, so you can inline the middleware directly in html-sketchapp.config.js?

Also, do you think we could add support for functions as config values too, not just file paths, so you can inline the middleware directly in html-sketchapp.config.js?

Heh, I originally had it as an inline function but thought people wouldn't like that. Will add support for both a string on inline function.

@markdalgleish any more feedback?

Just a heads up that I've upgraded html-sketchapp in master so I could also fix the install command in v3, so this PR will need to be updated.

Donions

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@ryanseddon Thanks so much for the PR, and thanks for your patience on this one. Really appreciate your contribution here 👏


DataHook makes pylint error after >=1.5.0

🐛 Bug

To Reproduce
pytorch_lightning>=1.5.0 makes below pylint error.
W: 87, 0: Method 'predict_dataloader' is abstract in class 'DataHooks' but is not overridden (abstract-method)
W: 87, 0: Method 'test_dataloader' is abstract in class 'DataHooks' but is not overridden (abstract-method)
W: 87, 0: Method 'train_dataloader' is abstract in class 'DataHooks' but is not overridden (abstract-method)
W: 87, 0: Method 'val_dataloader' is abstract in class 'DataHooks' but is not overridden (abstract-method)

This is due to change of on_train_dataloader to train_dataloader, removing prefix on_.
Pylint handles raise NotImplementedError as abstractmethod.
And train_dataloader raises  NotImplementedError when not defined.
def train_dataloader(self) -> EVAL_DATALOADERS:
    ...
    raise NotImplementedError("`predict_dataloader` must be implemented to be used with the Lightning Trainer")

Expected behavior
I think on_train_dataloader and train_dataloader is not doing different job.
To make consistency, this raise code should be removed from the function.
And i found same issue https://github.com/PyTorchLightning/pytorch-lightning/issues/2815, that raise is not the desired way.

Environment

PyTorch Lightning Version (e.g., 1.3.0): >=1.5.0
PyTorch Version (e.g., 1.8) 1.10
Python version: 3.8.10
OS (e.g., Linux): Ubuntu
CUDA/cuDNN version: x
GPU models and configuration:
How you installed PyTorch (conda, pip, source): pip
If compiling from source, the output of torch.__config__.show():
Any other relevant information:

Additional context

cc @justusschock @awaelchli @ninginthecloud

@Aiden-Jeon actually on_train_dataloader and train_dataloader have different responsibilities. The first one is a (now deprecated) hook that was called whenever the second one was called (which usually builds and returns the loader).
I am afraid, that we cannot remove the NotImplementedError there since this method will be triggered (and has to error out if not implemented) when no other data source is given to the trainer.
As a workaround, you could disable this particular warning (W0223).
#2815 is quite old and the way the data part is currently handled by the trainer, the NotImplementedError is exactly what we want here. An alternative could be to return None here and then raise a RuntimeError inside the trainer when data is None

Closing as this is currently expected behaviour after #8752.


Reduce metrics reporter

Coverage increased (+0.2%) to 98.574% when pulling 42468bdeea4d7ceb82fb2e4cdeb17fbd488ad4c6 on thinker0:reduce-reporter into 84e0451d435b3cb18f5302287c77b986bca8102c on sps:master.


Document how to use done for testing async code

It wasn't remotely clear to me how to do this, and the only doc is buried in #41
I didn't document Then (done) -> ... because my imagination failed to come up with anything useful that could do.

Thanks!
For assertions, you might think of an API like selenium.
Then (done) -> browser.find('.alert', (el) -> expect(el).toBeDefined(); done())
And (done) -> browser.find('.other-thing', (el) -> expect(el).toBeDefined(); done())

IIRC, the most complex thing about this feature is rolling up all the Thens & Ands into a single logical jasmine expectation


Try free-threaded support

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.55%. Comparing base (b8f01ee) to head (54b4e0a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   81.55%   81.55%
=======================================
  Files           5        5
  Lines        1399     1399
  Branches      143      143
=======================================
  Hits         1141     1141
  Misses        258      258

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Move tokio-openssl to new tokio-io crate

When developing tokio-cassandra we moved to the new tokio-io crate. Since we are also using tokio-openssl for SSL connections we needed to move the implementation there also to tokio-io.
Our tests against SSL are working (Travis Run).
Since I don't have expert knowledge in SSL / tokio-futures I think especially the shutdown implementation of AsyncWrite should be reviewed.
This Pull-Request will help us to continue on tokio-cassandra
Thanks Niko

Awesome, thanks!

Let me know if you need any help on tokio-cassandra, we're always willing to help out!


chore: update metadata

:tada: This PR is included in version 1.8.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[2] Performance

Non-functional requirement 2: Performance

The processes generally take a lot of time, some of them take up to a minute. This is not very performant, but of course it depends on the amount of data processed, the hardware properties etc.


Update ReadMe.md

Created CV in markdown

@akparkins - there are some changes you should review and accept if you agree or reject if you do not.


⚠ Turnos 24x7 has degraded performance

In d3a0909, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3038 ms

Resolved: Turnos 24x7 performance has improved in f65ef56.


Without consensus message

Please, Take a look @yongjiema

@shargon, that's makes sense
Sound like the jump of cat...aehauheauea
In the recent logs this has been noticed. A lot of Consensus on this function going to OnNewTasks and then nothing happening.
But how will normal consensus payloads be processed?

I think that is not good, break the CN :D


[FEATURE REQUEST] Support for Qwen1.5-0.5 fine tuning

Feature Request
Add support to fine tune Qwen1.5 models.
https://huggingface.co/collections/Qwen/qwen15-65c0a2f577b1ecb76d786524
Motivation
Qwen has also a collection of good performing small models
Additional Context
No response

do you get an error when training: https://huggingface.co/Qwen/Qwen1.5-7B-Chat ?

I want to fine tune 0.5B model. I am interested in Qwen1.5 small models

are you getting an error?

Under Base Model, I only see Qwen-14B

you can pass environment variable AUTOTRAIN_CUSTOM_MODELS=Qwen/some_other_model to use it.

I was using the UI, am new to using AutoTrain. How do I set that?

click on settings on autotrain space, then new variable:

thanks. solved


[fastlane_core] fix: paths with spaces fail

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

If the path has a space in it (for example C:/Users/User Name/AppData/Local/Temp/....), the command would ignore anything after the space, thus exiting with
Can't open C:/Users/User for reading, No such file or directory
Description

The only change is wrapping the path in quotes.
Testing Steps

I personally didn't test - because it requires creating a new user on Windows that has a home directory with a space in it, however this came up on the NativeScript discord by someone having trouble with it (screenshot submitted by a community member)

@googlebot I signed it!

No worries - I wasn't sure if just the quotes would be enough, but being safe with shellescape is definitely better!

If I remember correctly it depends on the OS - some like ", some one ' etc - which is why we have a modified version of shellescape that does the right thing on Windows.


[Feature Request] Horizontal reading mode

Hello again. Sorry for this second request, but if both are implemented, this app would be perfect for me.
It would be great to have an option to toggle between the current vertical reading mode and an horizontal/page by page reading mode. Scrolling for a long time when reading multiple chapters can be tiring, so I find it more comfortable to just tap at the sides to go back or forward a page.

Horizontal reading mode is planned for future. There isn't a way to add it right now.

I understand. Thank you for your effort.


[SPARK-13389] [SparkR] SparkR support first/last with ignore NAs

What changes were proposed in this pull request?
SparkR support first/last with ignore NAs
cc @sun-rui @felixcheung @shivaram
How was the this patch tested?
unit tests

Test build #51546 has started for PR 11267 at commit a30bd4a.

Test build #51546 has finished for PR 11267 at commit a30bd4a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51546/
Test PASSed.

Merged build finished. Test PASSed.

Is this option used by base R / other R libraries like dplyr ?

@shivaram Several R packages have similar function such as first, aggregate, etc. Users need this feature in R and did some workaround.

Test build #51656 has started for PR 11267 at commit 6e78f7c.

Test build #51656 has finished for PR 11267 at commit 6e78f7c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51656/
Test PASSed.

Merged build finished. Test PASSed.

Thanks @yanboliang -- Sorry for the delay in looking at this. I think this looks good. Merging to master


Pagination support required for Prometheus API or Query to List down the metrics.

GET /api/v1/query API gives a list of all metrics for query={__name__!=""}
If I want to get only first 100, then next 100-200, then 200-300 so on.... how can I do that???
How to achieve pagination either in query or the API?

Hi..
What about pagination on the /series api? It returns a sorted list so it would be easier to implement a pagination there?
WDYT @roidelapluie


Replace comment characters to support other languages

Can you provide a mechanism to replace the Comment with PowerShell Block style, also note the : needs a space for powershell
<#
@Author : mikey.zhaopeng
@Date :   2016-07-29 15:57:29
@Last Modified by: mikey.zhaopeng
@Last Modified time: 2016-08-09 13:29:41
#>

In the "User" settings and "Workspace" settings under the 'vscode-fileheader' extension settings you need to update:

Fileheader: Author --> [desired name]
Fileheader: Last Modified By -> [desired name]

** this is how you can update the Comment block to suit another programming language:

First, find an example of the Comment block for the desired programming language. Next, DO NOT DELETE the '@Author: {author} , @Created: {createTime}' , etc. fields in the "Fileheader: Tpl" settings. INSTEAD -- before each "@" symbol, add in the character used for 'newline' for your language of choice ... ex) Python: input "\n" right before the "@" symbols
You can of course delete the extra asterisks (*) inside the "Fileheader: Tpl" field if they are of no use to you in your Comment block
(FINAL STEP): Be sure that you have added the needed "Comment block symbols" at the beginning and end of the field for "Fileheader: Tpl" ... **ex) Python: input """ at both the beginning (before any other characters) and end of the field (after all characters) ... **ex) Powershell: input <# at the beginning of the field before all other characters, and #> at the end of the field after all other characters.
Add in 'newline' ( \n ) as needed to reformat the file header to your liking. REMEMBER: you must make the changes in both "User" and "Workspace" tabs for the extension (make changes in one tab, copy and paste to the other) ... must then close and re-open VS Code before extension changes will take affect

** (example) Adjustment of file header settings to suit Python

** Result after closing and re-opening VS Code, and adding fileheader with ctrl+alt+i

The following is what I use for my Python codes.
""" \n@Title: \n@Author: {author}  \n@Date: {createTime}  \n@Last Modified by:   {lastModifiedBy}  \n@Last Modified time: {updateTime} \n@Comments:  \n@TODO: \n"""\n\n
It gives the following.
"""  @Title:  @Author: vineeshvs   @Date: 2020-05-03 12:57:49   @Last Modified by:   vineeshvs   @Last Modified time: 2020-05-03 12:57:49  @Comments:   @TODO:  """


displayName not automatically set

Hey there — Thanks for creating this compiler. I'm blown away with how it just works seamlessly and gives me the best from both CoffeeScript and React.js. One feature is missing though:
The official JSX syntax sets the displayName property automatically. This behavior isn't carried over to coffee-react which makes debugging with the react debug tools harder because you manually have to set this property on every single component.
See this ticket on the official react.js repo for more info: https://github.com/facebook/react/issues/2447

just ran into this myself :) @jsdf I agree it would be nice to bundle the transform into the package.
My current workaround is adding the non-coffee reactify transform to my pipeline. It looks something like this:
patchDisplayNameUsingReactify = (filename, options) ->
  optionsForcingCompilationOfCJSX = _.extend({extension: ["cjsx"]}, options)
  reactify(filename, optionsForcingCompilationOfCJSX)

bundle = browserify()
bundle.transform("coffee-reactify")
bundle.transform(patchDisplayNameUsingReactify)

You may be able to just incorporate ReactTools.transform directly.

+1
Because I'm using sprockets I can just give my files the extension .jsx.coffee.cjsx, but it would be nice to see it integrated for parity.

+1
Using the workaround @noinkling suggested as well. Would be great to have this included in coffee-react.

Fixed by 4.0.0


ARROW-633/634: [Java] Add FixedSizeBinary support in Java and integration tests (Updated)

The original PR is at https://github.com/apache/arrow/pull/1012. Due to the major refactoring last year, changes are big. So I created this separate PR for easier to review and will cancel the other one later.
Changes include:

Arrow-633: [Java] Add support for FixedWidthBinary type
Arrow-634: Add integration tests for FixedSizeBinary

@siddharthteotia Do you think we can merge this? LGTM but want to double check with you.

It seems like we are missing support in the ComplexWriter and FieldReader interfaces. I think that should be included in introduction of these things. The patch here looks fine but I think we should include that before releasing this feature (either in this patch or a follow-up).

Per my comment, I'm +1 on the spirit on these changes but think the patch (or feature) is somewhat incomplete

@jacques-n, to make sure that I understand the question properly, do you mean there should be proper interfaces defined for FixedSizeBinary type inside AbstractFieldWriter and AbstractFieldReader?
Currently, AbstractFieldWriter has:
public void writeFixedSizeBinary(ArrowBuf buffer)
AbstractFieldReaderWriter has:
public byte[] readByteArray()
What would be the desired interfaces to add?
I would prefer to add the necessary fix in a separate PR as this one has grown too big if it is OK.

You're right. I forgot that the code is autogenerated and was looking for it here. I'm +1 on this PR.

thanks all, please open any follow-up JIRAs


Tooltip arrows don't move when you adjust the margin of the tooltip

This should work
Tooltip(..., Modifier.margin(left=30.px))
but right now, the tooltip body moves and leaves its arrow behind...

This got fixed at some point


feat(native): ✨  add RunPaths

allows users to easily specify multiple files, like how the KCL CLI allows specifying multiple files.
ref: https://www.kcl-lang.io/docs/next/reference/lang/tour#multi-file-compilation

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[X] Y

fix https://github.com/kcl-lang/kcl/issues/1466

2. What is the scope of this PR (e.g. component or file name):
/pkg/native/api

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[x] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

Allows users to pass in multiple paths, like how the CLI behaves. Ref: https://www.kcl-lang.io/docs/next/reference/lang/tour#multi-file-compilation

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[X] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

see /pkg/native/api_test.go

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

7 of 8 (87.5%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 32.922%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/native/api.go
7
8
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
5653

Relevant Lines:
17171

💛  - Coveralls


[Feature Request] Migrate to using Sonner instead of useToast

Is your feature request related to a problem? Please describe.
Sonner is now supported directly by shadcn and has great UI. This would migrate to leverage sonner as a direct dependency instead of the toast component.
Describe the solution you'd like
modify the templates to import toast from sonner instead of useToast from toaster and update associated method calls.

oops, this is a dup of #50


TRY ATUALIZED THE PAINT

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

NEW STOOLS TO PAINT

THIS  ,MOVIE

LOOP ,

BUTTONS

TO THATS HAVE GIMME MOVIMENT IN THE CARTOONS


python3Packages.async-dns: 1.1.9 -> 1.1.10

Motivation for this change
Update to latest upstream release 1.1.153
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128739 run on x86_64-linux 1

2 packages built:

python38Packages.async-dns
python39Packages.async-dns

nixpkgs-review happy, macos 10.15


Update CI for PostgreSQL 11.1, PostGIS 2.5.1

Related:
#753
appveyor/ci#2805

Opened appveyor/ci#2872 to address the service autostart.

Sorry for not reviewing the Azure DevOps PR, I promise I'll get around to it eventually...


Added vue-test-utils, and remove trailing white spaces.

Sorry, I did not pay attention to that, fixed!


Use a tuple for marginals.

@liutianlin0121 As we discussed, I made the following changes.

@liutianlin0121 As we discussed, I made the following changes.

Thanks!


fix: #674

Description
Concise description of proposed changes
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address:

The named exports are intentional so it's explicit what is being exported. Please add a minimal reproducible example to #674 before opening a PR.


Properly dispose of the timer in play screen

See https://github.com/raxysstudios/andax/pull/89#issuecomment-1126202707

Not dispose, rather play \ pause.


Update titles-03.csv with date information

Columns in that file are missing start and end dates for second batch of Chronicling America newspapers.

Addressed in c882ee6.


Allow future imports in CI

Currently I believe that CI disallows future imports, which means that we have to add a noqa like this:
from __future__ import annotations # noqa FI58

In general, we should avoid requiring systematic noqas, instead allowing this by global rules. We can adjust the linting config to allow this.

Sure. Let me try to find a way to do this. 🤔


Localized service consents with fallback

https://github.com/City-of-Helsinki/omahelsinki/issues/136

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   64.84%   64.84%
=======================================
  Files          21       21
  Lines         256      256
=======================================
  Hits          166      166
  Misses         90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b970d58...4c77558. Read the comment docs.


add typescript example for agent simulation evaluation

This PR implement TS version for the example chatbot simulation evaluation

Hi, sorry for the delay! Will review this week.

So sorry for the delay - I've gone through and fixed a few things but looks great overall. Thanks so much!


Alignment does not work for video block

Using centre, or right alignment does not work for the video block.
The class ql-align-* is not applied to the iframe element of the video block. See screenshot below:
In the editor:

Rendered from quill-delta-python

P.S. Would you mind if I attempt to create a PR with the fix?

Would not mind, please do! @sebammon

Make sure you make a test, as well.

@DeadWisdom I could use some advice... Unlike the block formats where the elements are changed by the attrs of the endline, the video's alignment is set in the insert e.g.:
{"insert": {"video": "https://www.youtube.com/embed/NAb9V08zcBE"}, "attributes": { "align": "center" }}

Should I apply the fix in the function
@format
def video(root, op):
...

or am I missing something else?

Fix would look like this:
@format
def video(root, op):
    attributes = op.get('attributes', {})
    iframe = root.makeelement('iframe')
    iframe.attrib.update({
        'class': VIDEO_IFRAME_CLASS,
        'frameborder': '0',
        'allowfullscreen': 'true',
        'src': op['insert']['video']
    })
    if isinstance(attributes, dict) and attributes.get('align', None):
        align_block(iframe, attributes)
    root.addprevious(iframe)
    return iframe

Yeah, that's right. We can access the attributes for that reason.

@DeadWisdom I have created a PR. Please can you review it :)


Better threadmarker position

Position threadmarker within post element.

Fixes #20 and #21.
Makes #23 redundant.

LGTM
Tested and it appears to have fixed it!


[WIP] Provide consistent interface for entry and account policies

Since we did not need some of the account policies, we did not provide them up to this point. To provide a more consistent policy interface, this commit adds three methods that were undefined so far.
Also, the standard entry and account policies now always include admin. This was also inconsistent.

Coverage decreased (-0.02%) to 99.036% when pulling 423d6e87e4e5a62008c5c9910faa9e73f3c64ae0 on aviav:make-policy-interface-more-consistent into 60713f627685b6c8f7564d29527f23064b53b11e on codevise:master.

Will try roles as an interface that is possibly cleaner


Default .verbrc template pulls in Jon and Brian authors by default :D

The default .verbrc template contains a reference to contrib("authors").
## Author
{%= contrib("authors") %}

This appears to resolve to https://github.com/verbose/verb-contrib-templates/templates/authors.md which in turn loads jon.md and brian.md...
{%= contrib("jon") %} {%= contrib("brian") %}

As a result, every default README.md file generated contains:
## Author

**Jon Schlinkert**

+ [github/jonschlinkert](https://github.com/jonschlinkert)
+ [twitter/jonschlinkert](http://twitter.com/jonschlinkert)

**Brian Woodward**

+ [github/doowb](https://github.com/doowb)
+ [twitter/doowb](http://twitter.com/doowb)

For general use, it would make more sense to load authors and contributors from the module's package.json.

At this time, I can say, that code
## Author
{%= author %}

works fine, assuming, that in my package.json exists property author (singular, not authors).
Nevertheless, if I use include code (suggested by someone time ago):
{%= include("author") %}

I have error in console, and readme not re-generated.

Running "verb:readme" (verb) task
TypeError: Cannot read property 'replace' of null
Cannot find "username" on the context. TypeError: Cannot read property 'split' of undefined
Warning: username is not defined Use --force to continue.

Here is my config:
verb: {
    readme: {
        files: [
            {src: ['assets/docs/.verb.md'], dest: 'dist/docs/README_by_verb.md'}
        ]
    }
},

So, regarding initial issue description by @jwtd - it's fixed/implemented, and issue can be closed.
But regarding include I'am not sure. I guess, it's expected function, and you @jonschlinkert  have not implemented such. Right?


Less heap allocations

Removed heap allocations in errorPixel, getPixelInfo, and analyseImages.
I don't have any test suite, but in general it seems to have roughly halved the processing time.
And huh, it seems like Visual Studio destroyed your whitespaces so now everything is in the diff...

By the way, just as a comment - your loop function passes x and y in that order, but your callbacks consider them as verticalPos and horizontalPos in that order - I assume that's not on purpose, and should bug with non-square textures.

I am really sorry, I didn't realize that pressing that button will actually finalize the merge. Can I merge things in a repo not owned by me on purpose?


preliminary support for generics and rpc

does not compile yet. do not merge as such.

Thanks for this! I went ahead and fixed it up and merged it.


[Bug] Error: API error: failed integrity check

I haven't been able to use it for a while, but I recently checked for updates and updated it to the latest version, but I get an error.
Is this bot working now?
[2023-04-16 16:26:19] [info] Processing campaign: Tom Clancy's Rainbow Six Siege BlastxUbi Rainbow6 Season 1 2023 Week 7
[2023-04-16 16:26:19] [error] Error processing campaign! Error: API error: failed integrity check
[2023-04-16 16:26:19] [info] Processing campaign: Overwatch 2 Path to Pro Spring Season 2023 Drops
[2023-04-16 16:26:19] [error] Error processing campaign! Error: API error: failed integrity check
[2023-04-16 16:26:19] [info] No campaigns active/streams online. Checking again in 5.0 min.```

Same problem.

Mine has not been getting drops for the past 2 months or so, it was watching the streams but nothing dropping.  Error: API error: failed integrity check
[2023-05-23 15:42:44] [info] Processing campaign: Overwatch 2 Path to Pro Spring Season 2023 Drops
[2023-05-23 15:42:44] [error] Error processing campaign! Error: API error: failed integrity check
[2023-05-23 15:42:44] [info] No campaigns active/streams online. Checking again in 5.0 min.
do we have a patch


Feature: support station (browser web) extension in web app

I find it unexpected, that this station web app does not support
Maybe it is already considered in newer extension under development https://github.com/terra-money/station/issues/147#issuecomment-883462011
Example: browser with station (browser web) extentson installed

Release date? Thx you

@hrfischberg No release date yet, but in this year we promise.


Group by family/conversation

customers are requesting more detail on the "Group by family/conversation" feature provided - which appears to enable expanding/collapsing the view

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 685ef016-8eaf-a40d-73af-0fc28e072e41
Version Independent ID: 8fbf5517-d2bc-12eb-79d0-8209130e29ec
Content: Investigate and remediate communication compliance alerts - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/communication-compliance-investigate-remediate.md
Service: o365-seccomp
GitHub Login: @robmazz
Microsoft Alias: robmazz

@nanoonan538 - thanks for the feedback. I'll include this feedback with our documentation updates included with upcoming feature enhancements this month. Thanks!


Trying to get started

I've followed the boilerplate instructions and get a 401 error when running.  Also, I'd like to build in .net 8, do you foresee any issues if I download the code and just upgrad to .net 8?  Any help would be greatly appreciated.
HttpRequestException: Response status code does not indicate success: 401 (Unauthorized).
System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
Adliance.Storyblok.Clients.StoryblokStoryClient.LoadStoryFromStoryblok(CultureInfo culture, string slug, ResolveLinksType resolveLinks, bool resolveAssets, string resolveRelations)
Adliance.Storyblok.Clients.StoryblokStoryClient.LoadStory(CultureInfo culture, string slug, ResolveLinksType resolveLinks, bool resolveAssets, string resolveRelations)
Adliance.Storyblok.StoryblokStoryQuery.Load()
Adliance.Storyblok.Middleware.StoryblokMiddleware.Invoke(HttpContext context, StoryblokStoryClient storyblokClient, IOptions options, ILogger logger)
Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

I figured out the issue is that the current codebase is written for V1 and not V2, so my next question is are there plans to upgrade this to V2 and .NET Core 8 in the near future?


empty e-mails incoming

Today I've had an OpenTSDB outage and Bosun as expected emailed me a dozen of "Unknown" alerts.
What's wrong with that is soon I've started to messages with no subject and empty body while all of templates I defined in config file do have both template and body:
Date: Sun, 8 Nov 2015 07:40:27 +0000
Mime-Version: 1.0
X-Bosun-Server: tsdb
Content-Type: multipart/mixed;
 boundary=435514121d807855059eaa73cdea71ccbaa92a293f0eaafb0b48d9c5ec2f
To<EMAIL_ADDRESS>From<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>X-SES-Outgoing: 2015.11.08-<IP_ADDRESS>
Feedback-ID: 1.us-west-2.LQSZzAmtlzVGV4VEOTpAGIGbe5mPLH9mf6V5OR2giLE=:AmazonSES
X-Original-Sender<EMAIL_ADDRESS>X-Original-Authentication-Results: mx.google.com;       spf=pass (google.com:
 domain of<EMAIL_ADDRESS> designates <IP_ADDRESS> as permitted sender<EMAIL_ADDRESS>       dkim=pass<EMAIL_ADDRESS>Precedence: list
Mailing-list: list<EMAIL_ADDRESS>contact<EMAIL_ADDRESS>List-ID: <ops.mydomain.com>
X-Spam-Checked-In-Group<EMAIL_ADDRESS>X-Google-Group-Id:<PHONE_NUMBER>05
List-Help: <http://support.google.com/a/mydomain.com/bin/topic.py&topic=25838><EMAIL_ADDRESS>
--435514121d807855059eaa73cdea71ccbaa92a293f0eaafb0b48d9c5ec2f

--435514121d807855059eaa73cdea71ccbaa92a293f0eaafb0b48d9c5ec2f--

I'm running Bosun 0.4.0 on Ubuntu 12.04, gathering incoming data via /api/index (sending to OpenTSDB in parallel) and sending out e-mails via AWS SES.

Copying here yesterday's slack chat for reference:
timurb [10:01 PM]
I have the following lines when I see empty messages:
2015-11-10_18:45:17.05809 2015/11/10 18:45:17 info: notify.go:122: Batching and sending unknown notifications
2015-11-10_18:45:17.05810 2015/11/10 18:45:17 info: notify.go:152: Done sending unknown notifications

timurb [10:01 PM]
nothing besides these ones

timurb [10:01 PM]
but the same lines appear for valid messages too

captncraig [10:03 PM]
nothing on 222,227, or 193 though?

timurb [10:05 PM]
no, I see the messages from notify.go only for these 2 lines

captncraig [10:07 PM]
We are still getting these empty emails about twice a day

captncraig [10:08 PM]
so I need to figure out where they are coming from

captncraig [10:08 PM]
I almost want to put a unique id in an smtp header anytime we send email and log a stack trace when we generate it

timurb [10:09 PM]
in my case I think it was related to errors while accessing OpenTSDB

timurb [10:09 PM]
in both cases (weekend and today) I saw empty messages when my HBase cluster got down (edited)

captncraig [10:09 PM]
interesting

captncraig [10:09 PM]
I think the errors should go into a different place now

captncraig [10:10 PM]
the little numbers on the top of the dashboard show errors.

captncraig [10:10 PM]
but things would also go unknown

captncraig [10:10 PM]
which is our best guess at this point

timurb [10:12 PM]
yep, I can’t say anything about weekend but today I’ve seen one error in top right and received an empty message. Not sure what was the timing. I’ve shut down Bosun quickly to avoid receiving tons of them so I can’t say more than that for now.

timurb [10:13 PM]
I was checking OpenTSDB from cmdline using `check_tsd` and it simply produced timeouts

I believe I know what is going on here. My attempt to change some of the dashboard inadvertently caused this. Fix should be in #1473.

One more update to the original issue: it seems the empty e-mail is send when error count in top right is increased. Not completely sure this is so but I'm sure I've seen both cases happening together when there is some issue with connectivity to OpenTSDB or with accessing data.
This is probably already fixed by pull-request but I feel I need to update the issue until the new version of Bosun holding the fix is out.


[BUG] QTextBrowser Link Color too Dark on Windows

Description
The link color in a QTextBrowser is too dark, and renders the actual content almost unreadable.

This also affects the link color in QLabels, as shown by the markdown-rendered QLabel test.


Disable XR Debug Capture by default

Disable XR Debug Capture by default because it causes crashes while using Monado OpenXR Runtime

Tested with Monado, it fixed the crash.


Contacts Search function: contact does not appear after correcting a typo

Hi,
Issue Impact: Minor
Device Manufacturer: Samsung
Device Model: S10
Device OS: Android
Device OS Version: 11
Application Version: apk: v0.98.29
Wallet: 1.1.4
What happened: From both the Send page and the Contacts page. When searching for a contact, if you make a typo and then correct it, the contact does not appear. You have to clear the box completely and start again.
Expected result: The search is regenerated after typo.
https://user-images.githubusercontent.com/60537663/124395351-93d45400-dcfb-11eb-94e3-ab06e79b1d8d.mp4
Thanks
Jazmin

Now fixed in v1.1.5

confirmed as fixed by @MiniJaz


Added test cases for lrucache, checkers, intern, hash, map and sort

@pattyshack I have addressed the review comments. Thanks :)


add gc roots and gc finalist roots to fix unrooted nodes

PR Description
What does this PR do?
This PR is to fix the issue: https://github.com/JuliaLang/julia/issues/52432

Fixed unrooted nodes from gc_mark_roots and added a GC root to them
Fixed unrooted nodes from gc_mark_finlist and added a finlist root to them
Added logic to check nodes without any incoming edges and print them out when serialize heap snapshot

The resulting output is as follows for snapshotting julia process
julia> using Profile

julia> Profile.take_heap_snapshot("jf-julia.heapsnapshot")
node count: 1384919
edge count: 4407344
orphan node count: 0
orphan nodes: []
"jf-julia.heapsnapshot"

The containment view on chrome DevTools:

Checklist
Requirements for merging:

[x] I have opened an issue or PR upstream on JuliaLang/julia: not applicable
[x] I have removed the port-to-* labels that don't apply.
[x] I have opened a PR on raicode to test these changes:

@JianFangAtRai, could you please tidy up the Checklist with requirements for merging?

@JianFangAtRai, could you please tidy up the Checklist with requirements for merging?
Here is the check list:

[ ]  I have opened an issue or PR upstream on JuliaLang/julia:  https://github.com/JuliaLang/julia/pull/52618
[ ]  I have removed the port-to-* labels that don't apply: only keep the port-to-v1.9 label
[ ]  I have opened a PR on raicode to test these changes: https://github.com/RelationalAI/raicode/pull/17030


Made corrections in the CONTRIBUTING.md file #79

Pull Request Template
What have you Changed
I corrected the git pull upstream master to dev, added git add too
Issue no.(must) - #79
Self Check(Tick After Making pull Request)

[x] One Change in one Pull Request
[x] I am following clean code and Documentation and my code is well linted with flake8.

Join Us on Discord:- https://discord.gg/JfbK3bS

Thanks for making it better.