"Failed building wheel for onnx" Error while install_prerequisites.bat

I trying to install OpenVINO Toolkit version 2019R1 which the latest version of today (2019-04-11). But during installation I got this error:

Failed building wheel for onnx

I installed everything as the documentation before I was using version 2018R5 and it was installed successfully and working well, but now I want to install the new version, but it gives me the above error.
It is the complete stack trace:

Building wheels for collected packages: onnx
Building wheel for onnx (setup.py) ... error
Complete output from command c:\users\bahra\appdata\local\programs\python\python37\python.exe -u -c "import setuptools, tokenize;file='C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" bdist_wheel -d C:\Users\bahra\AppData\Local\Temp\pip-wheel-zqjeth4c --python-tag cp37:
fatal: not a git repository (or any of the parent directories): .git
running bdist_wheel
running build
running build_py
running create_version
running cmake_build
-- Building for: Visual Studio 15 2017
-- Build type not set - defaulting to Release
-- Selecting Windows SDK version 10.0.17763.0 to target Windows 10.0.17134.
-- The C compiler identification is MSVC 19.16.27030.1
-- The CXX compiler identification is MSVC 19.16.27030.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:217 (message):
Protobuf compiler not found
Call Stack (most recent call first):
CMakeLists.txt:248 (relative_protobuf_generate_cpp)
-- Configuring incomplete, errors occurred!
See also "C:/Users/bahra/AppData/Local/Temp/pip-install-7w3v8o85/onnx/.setuptools-cmake-build/CMakeFiles/CMakeOutput.log".
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py", line 328, in
'backend-test-tools = onnx.backend.test.cmd_tools:main',
File "c:\users\bahra\appdata\local\programs\python\python37\lib\site-packages\setuptools_init_.py", line 145, in setup
return distutils.core.setup(**attrs)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\core.py", line 148, in setup
dist.run_commands()
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 966, in run_commands
self.run_command(cmd)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
cmd_obj.run()
File "C:\Users\bahra\AppData\Roaming\Python\Python37\site-packages\wheel\bdist_wheel.py", line 192, in run
self.run_command('build')
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
cmd_obj.run()
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\command\build.py", line 135, in run
self.run_command(cmd_name)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
cmd_obj.run()
File "C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py", line 203, in run
self.run_command('cmake_build')
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
cmd_obj.run()
File "C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py", line 190, in run
subprocess.check_call(cmake_args)
File "c:\users\bahra\appdata\local\programs\python\python37\lib\subprocess.py", line 347, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\Program Files\CMake\bin\cmake.exe', '-DPYTHON_INCLUDE_DIR=c:\users\bahra\appdata\local\programs\python\python37\include', '-DPYTHON_EXECUTABLE=c:\users\bahra\appdata\local\programs\python\python37\python.exe', '-DBUILD_ONNX_PYTHON=ON', '-DCMAKE_EXPORT_COMPILE_COMMANDS=ON', '-DONNX_NAMESPACE=onnx', '-DPY_EXT_SUFFIX=.cp37-win_amd64.pyd', '-DPY_VERSION=3.7', '-DONNX_USE_MSVC_STATIC_RUNTIME=ON', '-DCMAKE_GENERATOR_PLATFORM=x64', 'C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx']' returned non-zero exit status 1.

Failed building wheel for onnx
Running setup.py clean for onnx
Failed to build onnx
Installing collected packages: onnx, test-generator, defusedxml
Running setup.py install for onnx ... error
Complete output from command c:\users\bahra\appdata\local\programs\python\python37\python.exe -u -c "import setuptools, tokenize;file='C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record C:\Users\bahra\AppData\Local\Temp\pip-record-aj9pyef5\install-record.txt --single-version-externally-managed --compile --user --prefix=:
fatal: not a git repository (or any of the parent directories): .git
running install
running build
running build_py
running create_version
running cmake_build
-- Selecting Windows SDK version 10.0.17763.0 to target Windows 10.0.17134.
CMake Error at CMakeLists.txt:217 (message):
Protobuf compiler not found
Call Stack (most recent call first):
CMakeLists.txt:248 (relative_protobuf_generate_cpp)
-- Configuring incomplete, errors occurred!
See also "C:/Users/bahra/AppData/Local/Temp/pip-install-7w3v8o85/onnx/.setuptools-cmake-build/CMakeFiles/CMakeOutput.log".
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py", line 328, in <module>
    'backend-test-tools = onnx.backend.test.cmd_tools:main',
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\site-packages\setuptools\__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\core.py", line 148, in setup
    dist.run_commands()
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\site-packages\setuptools\command\install.py", line 61, in run
    return orig.install.run(self)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\command\install.py", line 545, in run
    self.run_command('build')
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\command\build.py", line 135, in run
    self.run_command(cmd_name)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py", line 203, in run
    self.run_command('cmake_build')
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
  File "C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py", line 190, in run
    subprocess.check_call(cmake_args)
  File "c:\users\bahra\appdata\local\programs\python\python37\lib\subprocess.py", line 347, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\Program Files\\CMake\\bin\\cmake.exe', '-DPYTHON_INCLUDE_DIR=c:\\users\\bahra\\appdata\\local\\programs\\python\\python37\\include', '-DPYTHON_EXECUTABLE=c:\\users\\bahra\\appdata\\local\\programs\\python\\python37\\python.exe', '-DBUILD_ONNX_PYTHON=ON', '-DCMAKE_EXPORT_COMPILE_COMMANDS=ON', '-DONNX_NAMESPACE=onnx', '-DPY_EXT_SUFFIX=.cp37-win_amd64.pyd', '-DPY_VERSION=3.7', '-DONNX_USE_MSVC_STATIC_RUNTIME=ON', '-DCMAKE_GENERATOR_PLATFORM=x64', 'C:\\Users\\bahra\\AppData\\Local\\Temp\\pip-install-7w3v8o85\\onnx']' returned non-zero exit status 1.

----------------------------------------

Command "c:\users\bahra\appdata\local\programs\python\python37\python.exe -u -c "import setuptools, tokenize;file='C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record C:\Users\bahra\AppData\Local\Temp\pip-record-aj9pyef5\install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in C:\Users\bahra\AppData\Local\Temp\pip-install-7w3v8o85\onnx\

Warning: please expect that Model Optimizer conversion might be slow.
You can boost conversion speed by installing protobuf-*.egg located in the
"model-optimizer\install_prerequisites" folder or building protobuf library from sources.
For more information please refer to Model Optimizer FAQ, question #80.

The root cause seems to be the missing Protobuf (see the line Protobuf compiler not found). Not sure where it should be fixed.
@vmatveic Slava, do you think it's an issue of the installer or the environment?

@snosov1 Thanks for the reply! But when I want to install the Protobuf, gives me this:

pip3 install Protobuf
Requirement already satisfied: Protobuf in c:\users\bahra\appdata\roaming\python\python37\site-packages (3.6.1)
Requirement already satisfied: six>=1.9 in c:\users\bahra\appdata\roaming\python\python37\site-packages (from Protobuf) (1.12.0)
Requirement already satisfied: setuptools in c:\users\bahra\appdata\local\programs\python\python37\lib\site-packages (from Protobuf) (40.8.0)

pip3 install Protobuf

pip3 install onnx is your target command.
protobuf python is not the same as protobuf C++ which is in mentioned error log.

Building wheels

Building of Python packages from sources usually doesn't work well on Windows platform.
Try to downgrade Python or downgrade onnx version - to ensure that it is loaded by pip via wheels (prebuilt wheels may not be available for "latest" configurations).

This issue can't be fixed by patching code in this repository.

@alalek Yes, the problem was with Python version. I have one another question, but I don't know to ask it here or open a new issue, OK I will prefer to ask it here.
That is: In the latest version the pre-trained models (intel_models) are not bundled into the download package, so now the intel_models there is only the description of the model.
So I found a script  which is used to download the models.
But here I found some problem which some of the models cannot be downloaded, the connection timed out or the connection cannot be established, the host  not responding and so on problems, so it makes hard to download the models, the problem may be due to some restriction to some addresses it not possible to have access to some of the links.
It is the result of my download, after many tries

###############|| Post processing ||###############
========= Changing input dimensions in vgg19.prototxt =========
========= Changing input dimensions in vgg16.prototxt =========
========= Changing input dimensions in googlenet-v1.prototxt =========
========= Changing input dimensions in googlenet-v2.prototxt =========
========= Moving to new Caffe layer presentation googlenet-v2.prototxt =========
========= Changing input dimensions in alexnet.prototxt =========
FAILED:
Sphereface
googlenet-v4
inception-resnet-v2
mobilenet-ssd
mobilenet-v2-1.4-224
mtcnn-o
mtcnn-p
mtcnn-r
resnet-101
resnet-152
resnet-50
se-inception
se-resnet-101
se-resnet-152
se-resnet-50
se-resnext-101
se-resnext-50
squeezenet1.0
squeezenet1.1
ssd300
ssd512

One error example:

Error Connecting: HTTPSConnectionPool(host='docs.google.com', port=443): Max retries exceeded with url: /uc?export=download&id=0B_geeR2lTMegb2F6dmlmOXhWaVk (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x00000202B81BA160>: Failed to establish a new connection:[WinError 10060]

So is it not possible to bundle all the models into a single package and download at once?
I think the better way it to provide three download ways:

Bundle all them into a singal package

Bundle each model in a separet package and let user download it manually

And dowload by script

So now everyone will be able to download what ever models they want.

One small question:
What does the value exactly mean in after of the each model's names, e.g:
instance-segmentation-security**-0033**
instance-segmentation-security**-0049**
AND
face-detection-adas-0001
face-detection-retail-0004
Thanks in advance!!

numbers

It is like a version (of used model's scheme, training processes, including used datasets).
May be faster and/or more accurate.
There is no "gold" solution, so models are always evolving. Some interesting variants goes public.

face-detection-adas-0001
face-detection-retail-0004

Perhaps they are trained on different datasets. And/or based on different scheme of models. Or have different purposes. Refer to attached description/readme files of these models.
Evaluate all applicable variants on your data and pick the best based on these metrics:

accuracy
performance

On the value interpretation - @alalek is correct. It's simply an ID, so we can distinguish between different models.
On the download issue - @atsyplen can you comment? In the meantime, @Bahramudin can you try model_downloader from this repo?

@Bahramudin regarding HTTPS errors, first of all please check that the correct date and time settings are set. Secondly make sre that you use a correct https proxy settings, if you need it for your network.
regarding requested features - you can find them in the latest  version of model downloader from this repo.

@snosov1 I am just using the one you mentioned to download the models. I think it is the reason which some of the links is not accessible may be restricted, anyway, I have tried many ways such as using VPN, but also was not working well, but VPN is not very stable after a while it is interrupted.
And also this script has a problem which when run it for the second time, then it will start downloading the already downloaded models, it will be good to check if the file already exists.
So I think it will be good to provide three ways of download which I mentioned in the above comment.
About the version, I checked the lower the heavier bin file, so the heavier may be more accurate and slower.

@Bahramudin please, reopen if it's still relevant


Unable to annotate images using Tesseract OCR backend

Hi,
I am working on a document AI project wherein I want to tag various items of interest in invoices, such as buyer/seller address, line items, dates, etc., by drawing bounding boxes.
I followed the steps outlined here - except for cloud storage, I imported a handful of images from local hard disk.
I then started a Tesseract-based OCR backend and added it to project settings.
However, when I click it, I do not see an image in the annotation panel.
Please note I installed label studio using pip inside a virtual environment and started it as label-studio. I started the ML backed with the command label-studio-ml start my-ml-backend -d -p=9090 --debug.
What am I missing?

@abhinavkulkarni

However, when I click it, I do not see an image in the annotation panel.

What do you mean? Could you share a screenshot?

Yes, I see the same :(

This view not gonna work :(

Please use this labeling config:
<View>
   <Image name="image" value="$ocr" zoom="true" zoomControl="false" rotateControl="true" width="100%" height="100%" maxHeight="auto" maxWidth="auto"/>

   <RectangleLabels name="bbox" toName="image" strokeWidth="1" smart="true">
      <Label value="Label1" background="green"/>
      <Label value="Label2" background="blue"/>
      <Label value="Label3" background="red"/>
   </RectangleLabels>
   <TextArea name="transcription" toName="image"
     editable="true" perRegion="true" required="false"
     maxSubmissions="1" rows="5" placeholder="Recognized Text"
     displayMode="region-list"/>
</View>

I've fixed the readme file with this config. Seems it's a bug in UI.


The tcp reserved field cannot be specified when constructing a TCP packet

https://github.com/google/gopacket/issues/909#issue-999883380
Check this issue in the google/gopacket repo

according to RFC793, reserved field must be zero at all times. what's the specific use case you have for a non-zero reserved field?

@mosajjal
I wonder if it would be a good method for data exfiltration, like during a pen test or security audit. Do network appliances often validate this reserved field, or are applications just expected to be compliant with the RFC?


some tiktok accounts dosnt work but some works i think its a bug btw

i tried so many times but looks like some tiktok account wont get data:
it stop working for got7official for example:

@candyily Unfortunately the underlying library that I use is being blocked again by TikTok via Captcha. I believe some work is being done on trying to fix it. But until then, we are all in the same situation. It is over a week since any of the accounts I follow have worked.

Out of curiosity, do you have an issue number or link to a ticket for the library? I'd like to see if there's a chance this will start working again, or if I should disable the repeating task...
Thanks!
Ricky

There is actually a PR with a fix which just needs to be merged by the author.
Issue: https://github.com/davidteather/TikTok-Api/issues/750
PR: https://github.com/davidteather/TikTok-Api/pull/753

Thanks! I'll follow that to see if this will get fixed...

Try this https://ttrss.mybluemix.net
It use mobile api

@k3ns1n Is there any source code of this project?


default export issue

The issue is with

how ES6 modules are emulated in CommonJS
how you import the module

ES6 to CommonJS
At the time of writing this, no environment supports ES6 modules natively. When using them in Node.js you need to use something like Babel to convert the modules to CommonJS. But how exactly does that happen?
Many people consider module.exports = ... to be equivalent to export default ... and exports.foo ... to be equivalent to export const foo = .... That's not quite true though, or at least not how Babel does it.
ES6 default exports are actually also named exports, except that default is a "reserved" name and there is special syntax support for it

#21
fix


[FLINK-32052][table-runtime] Introduce left and right state retention time to StreamingJoinOperator

What is the purpose of the change
This is the second subtask for FLIP-292.
Brief change log
This PR introduces leftStateRetentionTime and rightStateRetentionTime to StreamingJoinOperator and StreamingSemiAntiJoinOperator.
Verifying this change
This change added tests and can be verified as follows:
Add StreamingJoinOperatorTest and StreamingSemiAntiJoinOperatorTest to verify the different state TTL for join operators work as expected.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduces a new feature? yes
If yes, how is the feature documented? FLINK-31957

The first failure is not relevant to this change. Well, I've rebased the master n force push to reinvoke CI...

Hi @ lincoln-lil, would you mind sparing some time to review it?


Fork from turtle activity and port to Gtk+ 3

Fork of turtleart-activity from the present state, added required changes to make it Turtle Confusion activity.
Some changes I am not sure of:

NEWS file
Version metadata
There might be some other license related issue that I am not sure of.

@quozl @walterbender , I know there are way too many changes to be reviewed but I still request to have a look here and merge this pull request, thanks!

It seems close. There seem to be a few things still broken (some of these were fixed in Quozl's patch from today):
/home/walter/Activities/activity-turtle-confusion/TurtleArt/tawindow.py:600: Warning: Source ID 1266 was not found when attempting to remove it
self.activity._unfullscreen_button_timeout_id)
(See https://github.com/sugarlabs/turtleart-activity/commit/daa498e2d0c153c81b1dcf222ef9a28ac1c9ecdc)
Traceback (most recent call last):
File "/home/walter/Activities/activity-turtle-confusion/TurtleArtActivity.py", line 491, in do_palette_buttons_cb
self._help_button.set_current_palette(palette_names[i])
AttributeError: 'ToolButton' object has no attribute 'set_current_palette'
This one may be broken in Turtle Art as well.
Traceback (most recent call last):
File "/home/walter/Activities/activity-turtle-confusion/TurtleArtActivity.py", line 599, in do_stop_cb
self.stop_turtle_button.set_icon('hideshowoff')
AttributeError: 'ToolButton' object has no attribute 'set_icon'
should be set_icon_name (there may be other places where this is broken)
See https://github.com/sugarlabs/turtleart-activity/commit/547aa4756466abce45a2919634a2e0eb595d7b2e
https://github.com/sugarlabs/turtleart-activity/commit/b0f21da0db60e0b0f5e220f0291c70102f519904
and
https://github.com/sugarlabs/turtleart-activity/commit/4cb96a0ad3a7ad95b10249f54b6c2e81d7d5208c

Fixes https://github.com/sugarlabs/activity-turtle-confusion/issues/2

@walterbender @quozl added all commits from TurtleArt activity.
However, this error was logged doing simple operations on Turtle Confusion
Guessing python class from activity.info!
Traceback (most recent call last):
  File "/home/yash/testgsox/activity-turtle-confusion/TurtleArt/tawindow.py", line 3036, in __run_stack
    code = self.lc.generate_code(top, self.just_blocks())
  File "/home/yash/testgsox/activity-turtle-confusion/TurtleArt/talogo.py", line 278, in generate_code
    self.clear_value_blocks()
  File "/home/yash/testgsox/activity-turtle-confusion/TurtleArt/talogo.py", line 1045, in clear_value_blocks
    self.update_label_value(name)
  File "/home/yash/testgsox/activity-turtle-confusion/TurtleArt/talogo.py", line 1077, in update_label_value
    for block in self.value_blocks_to_update[name]:
KeyError: 'sound'

which is fixed in c1ec720f2861d75099fe63b6fe60420044c1e2aa .
please review

c1ec720 is not a correct fix, because we don't know why it happened, and interactive_mode is True anyway, so the change should have been ineffective but wasn't.
Unrelated issue in testing;
Traceback (most recent call last):
  File "/tmp/TurtleArtActivity.py", line 599, in do_stop_cb
    self.stop_turtle_button.set_icon('hideshowoff')
AttributeError: 'ToolButton' object has no attribute 'set_icon'

Should be set_icon_name; the code in this function is different between Turtle Art and Turtle Confusion.

Changed set_icon to set_icon_name in e91c34c2eb30ac54b719e82bc5b97cad8573f4af

@yashagrawal3, does this mean https://github.com/sugarlabs/turtleart-activity/commit/e822494254d233f0c9f9b080fa772c51786791d2#diff-deff5a37361d95d05f55434cd910e4b8L3028 is wrong and the not should be removed?
@walterbender said on IRC;

and you do not want to find value blocks in non-interactive mode

and the code would seem to do the opposite.
If so, then your c1ec720 is not a correct fix, it should instead read;
    if self.interactive_mode:
        self.lc.find_value_blocks()  # Are there blocks to update?

@quozl My apologies, made changes in ebd529bcb4632fe0a6a8191f9587e1dab892d3e6.

Agreed.  _fill_challenges_list is not in ebd529b, and _help_button is not an instance of HelpButton.

Fixed both errors, please review again.

Reviewed ecd148b and 4196519.  Seems to be a mistake in two places;

your addition of the call to HelpButton and assignment to _help_button is immediately discarded by the following line which calls _add_button,
your removal of the call to self._help_button.set_current_palette in do_palette_buttons_cb would not then be needed,

Thanks for all the work on this; the repositories for Turtle Blocks and Turtle Confusion are now much closer than before, and so I've carefully examined the differences.  For two reasons; (a) detect any unexplained changes during your merge, and (b) work toward merging the separate activities.

plugins/$NAME/$NAME.py has functional change; makes blocks hidden; it would be better to add a keyword argument to each __init__ so that the files can be identical between repositories.

plugins/camera_sensor/glive.py, instance.py, utils.py; all three files seem unused, are GTK+ 2 and GStreamer 0.10 binding uses, please confirm and remove the files,

there's a copy of extrasoff.svg and extrason.svg in each plugins/* directory; it would be better to have only one copy in a common place.  As the same problem affects Turtle Blocks for the sensoroff.svg and sensoron.svg files, it could be fixed later.

.gitignore is different, easily resolved.

README.md has unexpected differences; some of Turtle Blocks README.md might be added to Turtle Confusion, and vice versa.

setup.py has an import missing from the Turtle Blocks side; if this code has lasted this long with a missing import, perhaps it is not needed, @walterbender?

TurtleArtActivity.py could be changed to contain two activity classes, with a TurtleConfusionActivity class inheriting from TurtleArtActivity, and a corresponding change to exec in activity/activity.info.

It looks possible to merge the functionality of Turtle Confusion into Turtle Blocks.  If we do this, maintenance will be easier.
@yashagrawal3, are you interested in adding this to your project, or would you and your mentors prefer it be done outside your project?

Would be great to combine them, Please keep in mind that there are several other versions of turtle confusion specific to different locals: Amazonas, Mexico, ...

Thanks.  Guess these are;

Amazonas Tortuga at walterbender or at sugarlabs (same code but disconnected repositories), and;
Tortuga de Mexico (not on GitHub),

I also see

Turtle Flags,
Turtle Bots, and;
Turtle Nutrition (not on GitHub).

Hmm. I will upload the repos for everything I can find (except Turtle Bots, which is maintained by a group in Uruguay -- I'll ask them to upload it to github).

@quozl  I will once talk to @chimosky about it and then tell you we will add this to our project.

@quozl I have made changes that you suggested.

Thanks.  I've reviewed by;

doing a rebase of Turtle Confusion (revert the two commits that diverged from Turtle Art, merge the Turtle Art changes since, then reapply the reverted commits and resolve conflicts),
pushed to https://github.com/quozl/activity-turtle-confusion/commits/2018-06-01-rebase
comparing your branch against mine, using git diff,

Some things you need to fix;

ObjectChooser and mime modules are imported and not used,
self._local and self._custom_filepath variables are defined and not used,
restore_state and _draw_cartoon methods are missing,
some of the _logger.debug calls got lost,
cancel_plugin_install is incorrectly referenced,
a Gtk.ScrolledWindow policy changed,
... and so on.

You can see the differences by using git remote add for my fork, fetch, then use git diff quozl/2018-06-01-rebase.  There are some bugs in my work too, and it is untested, but the differences will give you things to consider for investigation.
My guess is you've got several hours work ahead of you.  Have fun!

@quozl reviewed all difference between the two branch and made necessary changes, please see!

Why is self._level defined and not used?

it got left with self._custom_filepath ,  I have removed it now.

Thanks.  What is self._custom_filepath for?

https://github.com/yashagrawal3/activity-turtle-confusion/blob/6ff8b5183951096b3569670d65b6d427407763f5/TurtleArtActivity.py#L112

https://github.com/yashagrawal3/activity-turtle-confusion/blob/6ff8b5183951096b3569670d65b6d427407763f5/TurtleArtActivity.py#L542

https://github.com/yashagrawal3/activity-turtle-confusion/blob/6ff8b5183951096b3569670d65b6d427407763f5/TurtleArtActivity.py#L1755

Since it is announced None and never changed later, I think it can be avoided but it is used in file later as mentioned, so avoided removing it.

Thanks.  In my branch, a call to restore_cursor is preceded by a comment "restore the cursor", and then a _logger.debug() with "restoring cursor", but in yours it says "setting watch cursor";
Compare mine vs yours;

mine,
yours,

Compare with confusion vs original:

this repository master,
turtle art master.

Changed to "restoring cursor", next line gives evident that it is right.

Thanks.  You have a reference to self._sample_window, an undefined variable;
https://github.com/yashagrawal3/activity-turtle-confusion/blob/e48674ac65235ab30a16537c7a26d0b29a6d16e8/TurtleArtActivity.py#L1845
In my branch this is self._challenge_window.

Used camera_sensor.py becuase it was closer to camera_sensor.py in Turtle Activity.

Thanks.  Reviewed to 022c708.
Reminder; plugins/camera_sensor/glive.py, instance.py, utils.py; all three files seem unused, are GTK+ 2 and GStreamer 0.10 binding uses, please confirm and remove the files.
For your interest, another method I'm using for review is to compare two views of the change from Turtle Art to Turtle Confusion; the most recent rebase by @walterbender and the output of "git diff turtleart/master yashagrawal3/gtk3".  In my local repository, I've a remote added for the Turtle Art repository; because the two repositories share a common history.

git grep gtk shows that following files that are not ported to GTK3 and and after testing found that they were not being used by the activity:

TurtleArt/sprites.py
plugins/camera_sensor/glive.py
plugins/camera_sensor/instance.py
plugins/camera_sensor/utils.py
pyexported/window_setup.py

I have removed all this files. Please verify these changes.

As sprites.py and window_setup.py are imported, and are used by Turtle Art, I'd like them to remain.

@quozl added both files.


⚠ Bofrost.es has degraded performance

In 815101f, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1736 ms

Resolved: Bofrost.es performance has improved in f3c539d after 7 minutes.


Embark.Storage.IPFS#getUrl function is hardcoded to localhost?

Noticing that this line is hardcoded to localhost:8080.
https://github.com/iurimatias/embark-framework/blob/5b60c3effa19ad5004f23e37e3be1d6544fe3416/js/embark.js#L304
Shouldn't this be something like Ember.Storage.ipfsConnection.get ?
However, I'm opening an issue because perhaps I have a fundamental misunderstanding of how best to setup my Embark app.
My app uploads a file to IPFS and tracks the returned hash to show other users.
I have setup an IPFS Node on Digital Ocean.  I was planning to expose this Node for receiving the Uploads from my Embark App, and for sending absolute URLs back from IPFS for the uploaded file.
Is this a correct way to view this architecture of a simple app like I described?  If not - how would I connect to localhost to get files when the Embark app is deployed?

Also - I am planning to use NGINX to proxy requests from the Embark App to my IPFS node (from 443 & 80 to 8080) on the IPFS daemon.

I would recommend just hosting IPFS locally and using Embark to get/set data to IPFS. That way you minimize what ports your app server has exposed.

@hhff this will be configurable in 2.6.0

cool!  will close


[$500] Web - Search - The user is displayed twice

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4294696&group_by=cases:section_id&group_id=229066&group_order=asc
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Account A: Log in as a new Gmail account
Account B: Log in as a new Gmail account
Account B: Send a text message to account a
Account A: Click on the search box (Don't open the chat before the search)

Expected Result:
There shouldn't be a duplicated entry.
Actual Result:
The user is displayed twice. The duplicate disappears after opening the chat.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a6d7fdcf164874c6
Upwork Job ID:<PHONE_NUMBER>430300672
Last Price Increase: 2024-03-05

Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user receives a text message from a new Gmail account and clicks on the search box without opening the chat, the user is displayed twice in the search results. The duplicate entry disappears after opening the chat. This issue affects the user experience by displaying incorrect information and causing confusion.
What is the root cause of that problem?
The root cause of this problem is likely related to the way the app handles the display of new chat entries in the search results. There might be a bug in the logic that populates the search results, causing it to temporarily display duplicate entries for new chats that have not been opened yet.
What changes do you think we should make in order to solve the problem?

Investigate the logic that populates the search results when a new chat message is received. Identify where the duplication is occurring.
Implement a check to ensure that each chat entry is unique in the search results, preventing duplicate entries from being displayed.
Test the solution on all affected platforms (iOS, Android, MacOS) to ensure that the issue is resolved and there are no regressions.

What alternative solutions did you explore? (Optional)
An alternative solution could be to refresh the search results after a new chat message is received, ensuring that the list is updated correctly. However, this approach might introduce unnecessary overhead and affect performance.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - The user is displayed twice
What is the root cause of that problem?
const accountIDs = report.visibleChatMemberAccountIDs ?? []; // in OptionsListUtils.ts file
What changes do you think we should make in order to solve the problem?
Instead of using  report.visibleChatMemberAccountIDs we can use report.participantAccountIDs which will show the unique chat members id

. As follow:
const accountIDs = report.participantAccountIDs ?? [];
What alternative solutions did you explore? (Optional)
N/A

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0186fb67844c31f2d2

@rayane-djouah IMO, we should show reportOption, not the personalDetailOption, as we do same for any other user with a report, right?

participantAccountIDs includes people who opened a room/thread but didn't actively joined it yet, making them have a notificationPreference=hidden .
So basically visibleChatMemberAccountIDs is everyone who doesn't have a notificationPreference=hidden

@rayane-djouah In that case, I am bit confused why does visibleChatMemberAccountIDs doesn't have the accountId of the other user in the first place and why will it only appear after the user opens the chat?
Note: https://github.com/Expensify/App/commit/4952bc3a830b799196d1e2354e4668524c1ac2cb commit replaced participantAccountIDs with visibleChatMemberAccountIDs in https://github.com/Expensify/App/pull/30863 PR.

@puneetlath I will confirm today. I think it's possible, but the App PR I'm working on should fix if it turns out to be the case.

I don't think this is related to my PR @puneetlath

Ok, got it. Thanks @youssef-lr.
@sobitneupane mind summarizing the current state of this issue?

@sobitneupane bump!

@rayane-djouah The change from participantAccountIDs to visibleChatMemberAccountIDs  was made by https://github.com/Expensify/App/pull/30863 PR. So, can you please make sure it doesn't cause any regression.
getOptions function is used not only for SidebarOptions. It has many uses in the app.

@rayane-djouah Is your proposal to make the change in getSearchText https://github.com/Expensify/App/pull/30863#discussion_r1515299840 or in getOptions function https://github.com/Expensify/App/issues/36377#issuecomment-1951378470?

Issue not reproducible during KI retests. (First week)

@sobitneupane any of the proposals catching your fancy so far?

Wait, is this issue still happening? It sounds like no, so I'm going to close. But please comment if I'm mistaken.


Updated README.md and added Examples/SimpleFcmClient

Added comment on FCM.(get/set)BadgeNumber not being available on Android.

great job 👍

Ouch! I'm still getting used to all this Pull Request thing.
My intention was to just update the README, now.
I'm still working on the Example.

great, LMK when you finish the example.
It will be very helpful

@evollu it is working as it is. Feel free to add it if you want, so other people might improve, also.

@evollu I think we can merge this in
an example will be very helpful

Holy cow! It took so long to finally find what I was looking for. So, if I want to send a remote notification from one device to another, I need to use this google API??? Seems like overkill, but I am just getting my feet wet with Notifications

there are some merge conflicts, can you fix it?

Sure. I'll do it later today
Em quarta-feira, 9 de novembro de 2016, Libin Lu<EMAIL_ADDRESS>escreveu:

there are some merge conflicts, can you fix it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/evollu/react-native-fcm/pull/152#issuecomment-259449773,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANTgKeJR5SyNvc9pZYrs5yRUv7GbwE0eks5q8e3XgaJpZM4KU7hc
.

--
Enviado do meu telemóvel, o pá!

Thank you for your new sample project.
I have a question: could you please elaborate on how to send a push notification to a group of devices? (from a client or from a server - either is possible)
In your sample project I only get local notifications for send data and send data with notification. (first button has no effect). Nowhere on the internet there was anything related to fcm doing so. Only configuring a fcm server system does that, right?
I wonder why no one has the need to send push notifications from one device to other devices. Imagine a chat - i want to notify all people in the group. How to do that?
Please drop us a simple statement , thank you very much!

@tioback can you fix the conflicts?

Sorry, guys, I've been busy with my final thesis.
I should have some time throughout this week.

@evollu, conflicts have been merged :-)

sample project


Obtain full URL from config file

No longer append the endpoint, have the user
specify the full URL.

Need to fix code style, please wait to review

Code style is fixed

do the endpoints change? it seems like its easier just to require the base url / ip address.

Yes, they can change. The connector itself will be updated following these changes, and one update will be to include the capability for each device to have its own endpoint and app key.

I will add a commit renaming ThingworxBaseUrl


Explore Operators on Python Indicators

Expected Behavior
All operators work in comparing indicators. +, -, *, /.
Actual Behavior
Only < and > work. The other operators require referencing Current.Value
Potential Solution
Explore and understand why < > work and apply lessons to other operators.
Reproducing the Problem
This shouldn't work but it does.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

These two issues might be related:

https://github.com/pythonnet/pythonnet/issues/253
https://github.com/pythonnet/pythonnet/issues/906

Has this issue been addressed? At least from the first Python tutorial https://www.quantconnect.com/tutorials/api-tutorials/consolidating-data-to-build-bars there is a line thirtyMinuteConsolidator.DataConsolidated += self.ThirtyMinuteBarHandler that indicates support for addition operator on events/handlers?
Not sure if this is related as well https://github.com/QuantConnect/Lean/blob/d1624ab8998deea2afd54a7db6b3694886665f14/Common/Python/PandasData.cs#L265

Sorry I just realized that the event += handler pattern is not exactly an operator, I'm not familiar with C#. It's surprising that the same syntax works in Python, is this out of the box or did it require some Python.NET modifications?

Something with https://stackoverflow.com/questions/11544056/how-to-cast-implicitly-on-a-reflected-method-call/11563904#11563904 on the indicator object then converting indicator result to a decimal.
No need for an elegant universal solution should aim at getting indicators to work.


Short Question

Would it be possible to automatical Chat in Champ Select?
For example if I start a normal where everybody is calling their lane and I want to call my prefered role as fast as possible.

Nope, not supported.


Register 'androidtv.download' and 'androidtv.upload' services

Description:
Register the androidtv.adb_filesync that allows users to transfer files between their Android TV / Fire TV device and their HA instance.
Pull request with documentation for home-assistant.io (if applicable): https://github.com/home-assistant/home-assistant.io/pull/11501
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

The failing tests don't seem related to my changes. In case they're flaky but not flat-out broken, I'll close this pull request and re-open it and see if they pass.

@balloob is this ready to be merged?

Thanks for the review!


Feature/python exotic engine

Added implied vol solvers.
Edit: this PR fixes #21 .

Codecov Report
Patch and project coverage have no change.

Comparison is base (b038d95) 97.70% compared to head (863fdc4) 97.70%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   97.70%   97.70%
=======================================
  Files          12       12
  Lines         393      393
=======================================
  Hits          384      384
  Misses          9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM

LGTM

Thanks for the constructive feedbacks!


sqlite automirate failed by "near "unsigned": syntax error"

GORM Playground Link
version: 1.25.4
column_type: uint64

remove tags it working

remove tags it working


Community / Collection statistics should include aggregate statistics for their Items

Is your feature request related to a problem? Please describe.
This was brought up in a DCAT discussion today, and was supported by several DCAT members.
Currently, in DSpace 7, the (Solr) Statistics pages for Communities and Collections just displays statistics for views of the Community/Collection homepage.  While this is useful, DCAT members agreed it'd be useful to also show aggregated statistics for all Items in that Community/Collection.  Some examples of aggregated statistics include:

total bitstream downloads
most downloaded (top 10?) bitstreams
total Item accesses
most accessed (top 10?) Items.

Sidenote: It's also odd that the historical view statistics for Communities/Collections only show the last 7 months.  7 months is an odd timeframe, and likely should be updated to be either 6 or 12 months, or maybe a way to select the number of months to show?

I've never poked around in the built-in statistics, but I'd guess that 7 months is to cover the difference between "6 calendar months" and "6 months ending now".
Not disagreeing with the meat of this issue, but I would say that, if one is more than casually interested in statistical analysis of DSpace usage, one should export the cases into R or SAS or SPSS or Stata or any of a dozen others, and get the abstractions that one wants.  We should have simple statistics built in, but strongly resist the temptation to add more and more and more.  (I've said this before, and I'll continue to say it at intervals, because it's so easy to succumb to this particular temptation.  Everybody wants "statistics," but everybody means something different....)

I've never poked around in the built-in statistics, but I'd guess that 7 months is to cover the difference between "6 calendar months" and "6 months ending now".
Not disagreeing with the meat of this issue, but I would say that, if one is more than casually interested in statistical analysis of DSpace usage, one should export the cases into R or SAS or SPSS or Stata or any of a dozen others, and get the abstractions that one wants.  We should have simple statistics built in, but strongly resist the temptation to add more and more and more.  (I've said this before, and I'll continue to say it at intervals, because it's so easy to succumb to this particular temptation.  Everybody wants "statistics," but everybody means something different....)
And now I see #8573.  I'll continue my ranting there.

@mwoodiupui : Agreed overall... one of the points made in the DCAT meeting though was that external tools often don't "understand" DSpace's Community <-> Collection <-> Item <-> Bitstream structure.  So, showing statistics based on this structure is something that can be done relatively easily with DSpace, but may not be as easy in external analysis tools (unless you can feed those tools somehow with pre-aggregated data).
This is where the idea of having basic "aggregated stats" comes in... it's not (easily) possible for Google Analytics (or other external tools) to easily tell you how many downloads occurred in Collection A vs Collection B.  But, DSpace's Solr Statistics could do that relatively easily (though its numbers may not always be as accurate as a system which has streamlined filtering out bots)

It would also be nice if there is an option to select the date start and date end for each aggregated statistic. Our use case requires us to report the number of downloads, and access each year or for a specific time frame.


iterator_size memory leak fixed

returning directly sum(1 for x in iterable) somehow instantiate iterable in memory.

Nice one!

Also please see this one: http://cardinality.readthedocs.io/en/latest/


Renyi & Tsallis entropies

Closes #3, #4.
i also went through and corrected the docstrings for several multivariate measures (they raise a ditException in a situation that wasn't documented), added a test for the conditional generalized cumulative residual entropy, and removed the reference to exitstack.py from landscape.yaml.

actually, we still need to ignore exitstack,py.


split refers to split on lists instead of the tactic

See below:
From MetaCoq Require Import MetaCoq.

Goal True /\ True.
MProof.
Locate split.
(*
Constant MetaCoq.Plist.split
Constant Coq.Lists.List.split
  (shorter name to refer to it in current context is List.split)
Constant MetaCoq.Tactics.split
  (shorter name to refer to it in current context is Tactics.split)
Ltac Coq.Init.Notations.split
split.
(* Error: Not a Mtactic *)
*)

Maybe it would be better to rename split to avoid confusion with the split on lists?

Turns out that this problem appears only in the polylist branch.

We should probably rename split. split_tac?

Yet one more, or overlaps with Coq's disjunction.

I think this has been solved in the tac_value branch, where split is in the module T.

As for or, I propose to rename it into || (like in Ltac).

Robbert, feel free to change this small things yourself :-)

The problem for or has been fixed by f57f4aac66b2b23f16ea8edf512c8040d3df961e, the problem for split has been fixed in tac_value. Closing this issue.


Add branch name to git config

When this resource is used to checkout a pull request's branch, it uses a special name as the branch (in the form pullrequest/{id}/merge.
This change add the original name of the branch as a git config setting so that it can be retrieved and used by other tasks in the pipeline.

Thanks for the PR. I will take a look at it soon.


fix: uuid deep requires now deprecated

#570

:tada: This PR is included in version 2.10.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Fetch Rewards to the list of Who's Using Svelte

This adds Fetch Rewards to the Who's Using Svelte section of the svelte.dev site.
I work at Fetch, and we're using Svelte and SvelteKit extensively in both our public-facing website as well as various internal dashboards. We're huge fans of the Svelte ecosystem and would love to show our support!

Thanks, but we're not adding new logos and this really screws up the layout


[Questions] variables in function body, svg's

I'm coming over from Stencil and really like how simple this library is in comparison.  That said, I've a few questions on how to do certain things and could use some guidance.  If there's a better place for these questions, please let me know and I'll move them there.
Please pardon the contrived examples.  They're merely intended to illustrate scenarios.

Variables in render

Coming from React, I often find myself creating variables in functional components to simplify the code.  Here's an example:
interface Props {
  some: {
    deeply: {
      nested: {
        prop: {
          values?: string[]
        }
      }
    }
  }
}

export default function Component(props: Props) {
  // this prop is now much easier to work with
  const valueArr = props.some.deeply.nested.prop.values ?? []
  return (

        {valueArr.map((value) => {
          return

        })}

  )
}

What's the best way to do this with mitosis?  I combed the docs and couldn't find anything.

SVGs

While my knowledge of SVGs is limited, I noticed that some attributes that work properly in React/Stencil are giving me type errors in mitosis.  Consider the following:
export default function Component() {
  return (
    <svg>
      <g fill={"#000000"} id={"Shape"}>
        <use fill={"#000000"} filter={`url(#filter-1)`} xlinkHref={`#path-1`} />
      </g>
    </svg>
  )
}

errors:
// Property 'fill' does not exist on type 'GSVGAttributes<SVGGElement>'
// Property 'fill' does not exist on type 'UseSVGAttributes<SVGUseElement>'

Are there any gotchas, re: using SVGs in mitosis?

There are absolutely zero gotchas with using SVGs in mitosis! This is just a bug with our JSX types: I found the issue with GSVGAttributes, but not sure what the best way is to fix this for UseSVGAttributes yet

Awesome, thanks @samijaber
I just realized that there's a discord.  I'll put all future questions there.

I'm going to keep this open, since it does point to a bug in the types :)

hello @samijaber
I'm interested in helping. Could you please guide me on how to fix the typing of UseSVGAttributes?


Issue noticed with https://fmriprep.org/en/stable/contributors.html#adding-dependencies while attempting to add new version of tedana (0.0.9) to docker image

There’s a broken link in the documentation: https://github.com/nipreps/fmriprep/blob/master/requirements.txt (looks like the repo no longer has a requirements.txt)
Rebuilding the docker image gives an error on step 8/42:
E: Version ‘5.0.9-4~nd16.04+1’ for ‘fsl-core’ was not found

Thanks for opening this, @QuintinFrerichsWUSTL !
For (1), I think we'll need to update the link to point to the setup.cfg file (likely defaulting to the install_requires section ).
For (2) it looks like neurodebian is now packaging 5.0.9-5~nd16.04+1. So we'll likely need to update that in the Dockerfile.
For now, you might be able to patch (2) locally when you're building it s.t. you can have a built image to test with !

Just to add on point 2) we have been pinning the FSL release to 5.0.9-5~nd16.04+1 for a least as far back as the 20.0.0 series
https://github.com/nipreps/fmriprep/blob/f9b2f5309f322a1464ffdd97044da26e4d5f97bf/Dockerfile#L74
so it's likely your Dockerfile is outdated.

Thanks guys - I think I see what's going on. According to the documentation, I should modify the about.py file ("Python dependencies should generally be included in the REQUIRES list in fmriprep/about.py"). This files exists on the 510f28db branch, but not master, and the 510f28db branch's Dockerfile has the old version of fsl-core specified. I can workaround this by building with fsl-core=5.0.9-5~nd16.04+1 locally, but seems like another issue to me.

Yes, so I was able to successfully build fmriprep with tedana 0.0.9 (the original issue from https://neurostars.org/t/zerodivisionerror-with-combine-py-for-multi-echo-fmri/17928/14), by copying the version of about.py from 510f28d into the repo on master and modifying it there.

Ok sorry for the multiple replies, but after working through a couple more issues I ran into with the build, I've realized that IMO the best solution for the documentation is to link to setup.cfg (at install_requires) as you described, and remove the sentence on updating REQUIRES in about.py. This avoids having to transfer code between the branches and works for me.

hi @QuintinFrerichsWUSTL -I'm a little confused, is your objective to build a docker image with an updated version of tedana?
If so, the easiest way may just be to download @tsalo's branch and build the Docker image from there.
wget https://github.com/tsalo/fmriprep/archive/refs/heads/update-tedana-req.zip  # or visit the page in browser
unzip update-tedana-req.zip
cd fmriprep-update-tedana-req
make docker-build tag="fmriprep:dev-aab2361"

@QuintinFrerichsWUSTL next 21.x series coming up soon will build on tedana 0.0.10
Please reopen this issue if you the problems persist.


[Performance] The GEMM performance with the column major B matrix is not as good as row major B matrix.

The performance gap is found in https://github.com/intel/intel-xpu-backend-for-triton/pull/2347
Need to investigate root cause of the performance drops of the column major B matrix case.
Roughly 1.5x worse than the row major B matrix case.

(I): Detected 7680 spills, recompiling the kernel using large GRF mode
(I): Kernel has now 0 spills
✅ Triton and Torch match
Time for torch: 0.31633758544921875 ms
Time for triton: 0.44517597556114197 ms
Compute A x B.T
OpenCL API not available for this operation
OpenCL API not available for this operation
OpenCL API not available for this operation
OpenCL API not available for this operation
(I): Detected 7680 spills, recompiling the kernel using large GRF mode
(I): Kernel has now 0 spills
✅ Triton and Torch match
Time for torch: 0.3375360071659088 ms
Time for triton: 0.6348815560340881 ms

Adding to this, if the A matrix is column-major we have similar problems.

Current Triton tiling strategy for DPAS for AxBT:

oneDNN tiling strategy mapped to Triton (thanks to @Jianhui-Li and @chengjunlu ) :

I plan to try to implement the oneDNN strategy in Triton.


using response with Firebase

hey Ari - I've got to point where both Google/Facebook auth is returning me good response payloads (per your documentation).
what im struggling with now is how can i use that payload, to then make a login request to Firebase ?
ie the payload i mention above looks like this:
{
  status: "ok",
  response: {
    authorized: true, (boolean)
    uuid: "UUID", (user UUID)
    credentials: {
      access_token: "access token",
      refresh_token: "refresh token",
      type: 1
    }
  }
}

Did you get this working?

I used redux observable. I have an epic which takes the response and turns it into a 'credential' object and dispatches that as an action with the credential payload. I then have another epic which listens for that succesful action and then authenticates with firebase. It's working perfectly on ios but on android I get an error at the oauth stage (cannot read property 'configureProvider' of undefined) @auser  I'll raise this as an issue for more context. Anyway here's my working (on ios) epic maybe you can use that for help @ajonno ?
https://gist.github.com/SamMatthewsIsACommonName/c69485f6be660362a09060c410182a57


tensorflow mobilenet-v2 support

Hi.
Since tensorflow has released mobilnet-v2 weights,
I'm wondering that
is this toolkit goinig to support mobilenet-v2 from tf to caffe?

@cjerry1243
The padding in Caffe is always symmetric, defined in official tutorial and mentioned in stackoverflow.
According to Caffe #6294, there is no non-symmetric padding layer implemented.
Currently, mobilenet v2 conversion from tensorflow to caffe does not work because of this padding problem. Take the first conv layer as examples. It takes the input of 224x224x3 and outputs 112x112x32, with kernel size of 3 and stride 2. In tensorflow, the padding is same, which actually means padding_left=0, padding_right=1, padding_top=0, padding_bottom=1. However, in caffe, the padding is symmetric. Even though  p_h = 1, p_w = 1 ( or padding_left=1, padding_right=1, padding_top=1, padding_bottom=1) can also make the output 112x112x32 shape, the value of the output can be different because of mismatch in convolution arithmetic computation. To illustrate this more clearly, I draw the following charts.

Despite intrinsic problem in caffe, we have already add mobilenet-v2 inside MMDNN. You can convert tensorflow mobilenet-v2 into any other frameworks. You can follow the ways described below for the conversion.

First, try the newest version by
pip install -U git+https://github.com/Microsoft/MMdnn.git@master

Next, You can refer Slim Model Extractor to extract mobilenet-v2 model,
mmdownload -f tensorflow -n mobilenet_v2_1.0_224

Meta File Graph Visualization
I recommend you to use this tool to visualize the graph
mmvismeta imagenet_mobilenet_v2_1.0_224.ckpt.meta ./logs/

Tensorflow -> IR
You can use following bash command to convert the checkpoint files to IR architecture
mmtoir -f tensorflow -d mobilenet-v2 -n imagenet_mobilenet_v2_1.0_224.ckpt.meta -w imagenet_mobilenet_v2_1.0_224.ckpt --dstNodeName MMdnn_Output

You will get IR architecture file and IR weights file
IR network structure is saved as [mobilenet-v2.json].
IR network structure is saved as [mobilenet-v2.pb].
IR weights are saved as [mobilenet-v2.npy].

IR  -> Tensorflow
Convert models from IR to Tensorflow code snippet
mmtocode -f tensorflow --IRModelPath mobilenet-v2.pb --IRWeightPath mobilenet-v2.npy --dstModelPath tf_mobile-v2.py

You will get the tensorflow code
Target network code snippet is saved as [tf_mobile-v2.py].

IR  -> Keras
Convert models from IR to Keras code snippet and you will get the keras code
mmtocode -f keras --IRModelPath mobilenet-v2.pb --IRWeightPath mobilenet-v2.npy --dstModelPath tf_mobile-v2.py

Also, it can be converted to coreml and mxnet.

@JiahaoYao Thank you.
I have solved padding problem by using pad=2 followed by 2 slice layers in caffe.

@ujsyehao
when pad=1, caffe will pad left and right simultaneously, but TF will pad right first, and then pad left if necessary. As the above example, input size is 224, and kernel=3, stride=2 in conv layer. Although output size is the same which is 112, kernels slide differently because they starts from different pixels in the image.

So, the solution is that use pad=2 followed by 2 slice layers in caffe.
kernels would slide:

The second kernel starts from the pixel where tf pad=1 kernel starts. Except for the first kernel, the other kernels slide as tf kernels do. The output size become 113, so we need to slice the left column and the top row.

I have finished mobilenet v2 conversion from tf to caffe.
It's now on my github.

@cjerry1243 I see your project, Relu6 layer in caffe is easy to implement, you can finish it!

Hi I wonder how to do the cropping in caffe.NetSpec to get the sliced layers.


SEC$GLOBAL_AUTH_MAPPING wrong field sizes

Open anyd Firebird 3 database. Go to System tables and open properties of SEC$GLOBAL_AUTH_MAPPING.

Field #01: SEC$GLOBAL_AUTH_MAPPING.DB_KEY Alias:DB_KEY Type:STRING(8)
Field #02: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_NAME Alias:SEC$MAP_NAME Type:STRING(31)
Field #03: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_USING Alias:SEC$MAP_USING Type:STRING(1)
Field #04: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_PLUGIN Alias:SEC$MAP_PLUGIN Type:STRING(31)
Field #05: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_DB Alias:SEC$MAP_DB Type:STRING(31)
Field #06: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_FROM_TYPE Alias:SEC$MAP_FROM_TYPE Type:STRING(31)
Field #07: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_FROM Alias:SEC$MAP_FROM Type:STRING(255)
Field #08: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_TO_TYPE Alias:SEC$MAP_TO_TYPE Type:SMALLINT
Field #09: SEC$GLOBAL_AUTH_MAPPING.SEC$MAP_TO Alias:SEC$MAP_TO Type:STRING(31)

Hello, which Fr version are you using?
I tried in the latest snapshot, and got this: (I'm using Firebird 5 RC1)

Firebird 3

Please, confirm which charset you are using to connect, and what are the default from your DB

Firebird 3

remember that i post above that i connect to Firebird 3

I'm trying to understand where this UNICODE_FSS charset came from. Any idea?
I'm not an expert about charset, so no idea if it could be related.
Anyway, can you send me a sample database to look here?

Hi, can you provide an reproducible database for me to take a look?

CORE-5849.zip
I added an attachment with the sample database. Register it with utf8 like here https://github.com/mariuz/flamerobin/issues/304#issuecomment-1753566933

So, looks like Fb3 and 4+ handles SEC$GLOBAL_AUTH_MAPPING field_lenght differently in Fb3
Fb3 size = 31 bytes
Fb4 size = 252 bytes
Fb5 size = 252 bytes

Note that there is another field  rdb$character_length, but Flamerobin uses rdb$field_length/rdb$bytes_per_character to retrieve field size
I don't know if its a bug from Firebird or on purpose or not, but if you run this query you'll see that it has different results from Fb3 to Fb4 and 5
select
             f.rdb$field_name,            --  1
             f.rdb$field_type,            --  2
             f.rdb$field_sub_type,        --  3
             f.rdb$field_length,          --  4
             f.rdb$field_precision,       --  5
             f.rdb$field_scale,           --  6
             c.rdb$character_set_name,    --  7
             f.rdb$character_length,      --  8
             f.rdb$null_flag,             --  9
             f.rdb$default_source,        -- 10
             l.rdb$collation_name,        -- 11
             f.rdb$validation_source,     -- 12
             f.rdb$computed_blr,          -- 13
             c.rdb$bytes_per_character    -- 14
         from rdb$fields f
         left outer join rdb$character_sets c
             on c.rdb$character_set_id = f.rdb$character_set_id
         left outer join rdb$collations l
             on l.rdb$collation_id = f.rdb$collation_id
             and l.rdb$character_set_id = f.rdb$character_set_id
         left outer join rdb$types t on f.rdb$field_type=t.rdb$type
         where t.rdb$field_name = 'RDB$FIELD_TYPE' and f.RDB$FIELD_NAME='RDB$MAP_NAME'

Looks like it's something related to Fb3 itself, running this SQL in Fb3 brings tons of records, for Fb2.5,4 and 5 none:
select
             f.rdb$field_name,            --  1
             f.rdb$field_type,            --  2
             f.rdb$field_sub_type,        --  3
             f.rdb$field_length,          --  4
             f.rdb$field_precision,       --  5
             f.rdb$field_scale,           --  6
             c.rdb$character_set_name,    --  7
             f.rdb$character_length,      --  8
             f.rdb$null_flag,             --  9
             f.rdb$default_source,        -- 10
             l.rdb$collation_name,        -- 11
             f.rdb$validation_source,     -- 12
             f.rdb$computed_blr,          -- 13
             c.rdb$bytes_per_character    -- 14
         from rdb$fields f
         left outer join rdb$character_sets c
             on c.rdb$character_set_id = f.rdb$character_set_id
         left outer join rdb$collations l
             on l.rdb$collation_id = f.rdb$collation_id
             and l.rdb$character_set_id = f.rdb$character_set_id
         left outer join rdb$types t on f.rdb$field_type=t.rdb$type
         --where t.rdb$field_name = 'RDB$FIELD_TYPE' and f.RDB$FIELD_NAME='RDB$MAP_NAME'
         where 1=1 and nullif(f.RDB$CHARACTER_LENGTH,0) is not null
         and f.RDB$CHARACTER_LENGTH<>f.RDB$FIELD_LENGTH/c.RDB$BYTES_PER_CHARACTER

Until Firebird 4.0, the system columns for identifiers with character set UNICODE_FSS are special, in that they are CHAR(31), but also only max 31 bytes long. Only for system columns, dividing by RDB$CHARACTER_SET.RDB$BYTES_PER_CHARACTER is the wrong way to derive their length (because you end up with 10 instead of 31).
The reason that the query by @arvanus is different between Firebird 2.5 and Firebird 3.0 is that in Firebird 2.5, the RDB$CHARACTER_LENGTH column is NULL for those columns. The reason it is different in Firebird 4.0 and higher is because those columns are now CHAR(63) CHARACTER SET UTF8 with RDB$FIELD_LENGTH = 252.

Hello Mark, first of all thank you for your detailed answer!
So, to fix Flamerobin execution what do you suggest?
For Fb3<, keep as is, and for Fb3> use the new filled field RDB$CHARACTER_LENGTH?
Thanks!

Also, why does if I create an table in the employee DB (FB3), with a char(30) charset UNICODE_FSS, it will display correctly as 90 bytes and 30 char length?
This is a strange thing at my POV. Looks like there is something very specific to SEC$GLOBAL_AUTH_MAPPING.
CREATE TABLE NEW_TABLE (
    NEW_FIELD CHAR(30) CHARACTER SET UNICODE_FS
)

Also, why does if I create an table in the employee DB (FB3), with a char(30) charset UNICODE_FSS, it will display correctly as 90 bytes and 30 char length? This is a strange thing at my POV. Looks like there is something very specific to SEC$GLOBAL_AUTH_MAPPING.

As I said, system columns for identifiers are special: they are 31 characters and 31 bytes long, while a "normal" CHAR(31) CHARACTER SET UNICODE_FSS column is 31 characters and 93 bytes. As I understand it, this was done when Unicode support for identifiers was added, to ensure the maximum byte length of a field name in the XSQLDA didn't change.
This isn't specific to SEC$GLOBAL_AUTH_MAPPING, it applies to all system columns that are CHAR(31) (and FlameRobin does it wrong for all of them)!

For Fb3<, keep as is, and for Fb3> use the new filled field RDB$CHARACTER_LENGTH?

Yes, that sounds OK to me.


Fix TODO comments in types about or_i() stack depth calculation

The TODO comments are added in PR #255

This was actually a bug in cast_unlikely. This was code removed and follow back to or_i(A, false) was used instead. This bug is now addressed.


Improve Remove Component API (#2368)

Signed-off-by: Keith Chong<EMAIL_ADDRESS>What does this PR do?:

Make cloning the repo optional when removing a component. In some use cases, the repo has already been cloned.  We just want to call the API to only remove the component
Rename the API so it's more meaningful

Which issue(s)/story(ies) does this PR fixes:
2368
PR acceptance criteria:

Test added which is based on the current test for RemoveAndPush

[ ] Unit/Functional tests

Test added

[ ] Documentation

N/A - current API in code has been updated

[ ] Client Impact

All clients MUST be updated to adopt this change. (I'll do this after)
How to test changes / Special notes to the reviewer:
Run make test

Codecov Report
Base: 80.70% // Head: 81.06% // Increases project coverage by +0.35% :tada:

Coverage data is based on head (0b10b7d) compared to base (d393649).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   80.70%   81.06%   +0.35%
==========================================
  Files           6        6
  Lines         596      602       +6
==========================================
+ Hits          481      488       +7
+ Misses        106      105       -1
  Partials        9        9

Impacted Files
Coverage Δ

pkg/gitops.go
59.70% <100.00%> (+1.70%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Merged. Thanks @maysunfaisal


If a spot instance is tagged with a schedule, an entire batch of instances will not stop.

If a spot instance is tagged with a schedule, an entire batch of instances, even non-spot, will not stop per their schedule.
This is the error logged in CloudTrail:
The instance '[InstanceID]' is a spot instance and may not be stopped."
userAgent: InstanceScheduler-aws-scheduler-main-<IP_ADDRESS>
The requestParameters in the logged event seem to contain all the other instances that are impacted in the batch.
Per module, ec2_service.py, default STOP_BATCH_SIZE is 50.   From the behavior I'm seeing, if a spot instance is present in a batch, all the instances in a batch will not be stopped by the Scheduler.
A possible workaround may be to set STOP_BATCH_SIZE to 1 if an environment has spot instances.

Spot instances are not officially supported by the Scheduler in the current release.

Sure, Scheduler doesn't need to support spot instances.    But, if a spot instance is tagged with a schedule, Scheduler is then broken.    With an autotagging policy, this can easily happen.     So something to think about with future release possibly?
I may test the workaround of a STOP_BATCH_SIZE of one to limit impact to non-spot batches.    The performance impact may be minimal with a small number of instances.    I'll post the results if I proceed.
Thank you

Setting the batch size is an option if you expect to incidentally tag unsupported spot instances. However this will increase the number of API calls with the risk of being throttled. As we have customers that schedule large number EC2 Instances setting the batch size to 1 will seriously increase the risk of throttling.
On 7 Mar 2019, at 23:16, wallabyies <notifications<EMAIL_ADDRESS>wrote:
Sure, Scheduler doesn't need to support spot instances. But, if a spot instance is tagged with a schedule, Scheduler is then broken. With an autotagging policy, this can easily happen. So something to think about with future release possibly?
I may test the workaround of a STOP_BATCH_SIZE of one to limit impact to non-spot batches. The performance impact may be minimal with a small number of instances. I'll post the results if I proceed.
Thank you
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/awslabs/aws-instance-scheduler/issues/76#issuecomment-470718570, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACBiexlgnPvvQjujcTAOx9RYCn4uJnlVks5vUY_MgaJpZM4bkJFR.

We do not have plans to support this feature in the solution.


Index procedure profiling for a stand-alone use case

Currently we use a workaround where a Collection node is attached to the Publication via a [:USES_DATA] relationship, which in turn points to those Datasets.
Publication 3c7273660cdf9ab91a7901533b2cd9a5 shown below as an example:

Also similar handling for 77ab35880329b5932380104aa58795a4 and 72cbeb8ff605fd5017cb2666cd19dfb7.
First create a situation in a local Neo4j instance where a Publication node is generated from a large number of Datasets (over 200 for instance) as direct ancestors without using a Collection node as workaround.
Then do some entity-api and Neo4j profiling to identify the bottleneck of indexing the Publication into Elasticsearch (we can create some testing indices on DEV) with such large number of direct ancestors and ancestors and measure the total time as well as where is causing the performance issue.

Is running entity-api triggers taking too much time?
Are some of the neo4j queries slowing down the index?
What improvements can be done? Either in search-api or entity-api.

@shirey @DerekFurstPitt I looked at the results (very useful) and was able to confirm the places that can be optimized to improve the efficiency, which are in line with the established tasks from each milestone:

https://github.com/hubmapconsortium/search-api/milestone/5
https://github.com/hubmapconsortium/entity-api/milestone/8

In addition, I also identified a few other interesting places that definitely can be optimized outside the index scope in entity-api.
We will focus on the above tasks and leave the uuid-api profiling for the future sprint.


fix: low round but valid proposal to commit

related issue: https://github.com/cita-cloud/consensus_bft/issues/49


[dashboard] allow user re-order top-level tabs

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Codecov Report

Merging #7390 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7390      +/-   ##
==========================================
+ Coverage   64.89%   64.91%   +0.01%
==========================================
  Files         428      428
  Lines       20979    20988       +9
  Branches     2337     2344       +7
==========================================
+ Hits        13615    13625      +10
+ Misses       7240     7239       -1
  Partials      124      124

Impacted Files
Coverage Δ

...ts/src/dashboard/components/gridComponents/Tab.jsx
68.18% <ø> (ø)
:arrow_up:

...sets/src/dashboard/components/DashboardBuilder.jsx
81.81% <100%> (+0.33%)
:arrow_up:

...et/assets/src/dashboard/actions/dashboardLayout.js
97.72% <100%> (+0.22%)
:arrow_up:

superset/assets/src/messageToasts/actions/index.js
79.16% <0%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe152d...037510b. Read the comment docs.


Update gevent in app.py with new import package

The package gevent.wsgi has been updated to gevent.pywsgi as it has been renamed.
Based on the post here to solve the import issue.

I noticed this change to gevent a few days ago. Now, we have to import gevent.pywsgi instead.
Thank you.


(suggestion/discussion) More unique names for report value types?

Some of the report value types in OSVR.ClientKit have somewhat generic names which are likely to conflict with other libraries. For example, OSVR.ClientKit.Quaternion vs Microsoft.Xna.Framework.Quaternion. In order to make it easier to add a using statement for OSVR.ClientKit without causing ambiguous references, I'd like to propose we rename them in some way that makes then more unique to OSVR or at least less likely to conflict. Some possibilities:
Using OSVR as a prefix, e.g. OSVRQuaternion, OSVRVec3.
Using Value or similar as a suffix, e.g. QuaternionValue.
Using VR as a prefix or suffix? e.g. VRQuaternion, etc...
I'm also ok with using short forms despite the .Net naming conventions discouraging them, for example VRQuat vs VRQuaternion. I think math related types get a pass.

I would think that in this case, wouldn't you just use a fully-qualified (or partially-qualified, like ClientKit.Quaternion) name for one of the types, instead of hardcoding what is essentially a namespace into the name?

You can fully qualify the names, but this makes the code verbose and is inconvenient. For example, if I want to use static methods of the Xna Quaternion class, I have to do the full xna framework namespace:
return Microsoft.Xna.Framework.Quaternion.Invert(value);

Which can get pretty tedious in math-heavy code. The problem is made worse if the user needs extension methods from both namespaces, as you need a using statement to expose extension methods, thus making it so both types need to be fully qualified.
It can also lead to confusing code, when some programmers choose to have a using statement for OSVR.ClientKit and others Microsoft.Xna.Framework (or the unity equivalent, or the .Net SIMD equivalent). When reading old code for example, you'll see Quaternion and you'll have to investigate to figure out which type of quaternion it is.
I agree it is somewhat encoding a namespace into the type name, but for such commonly implemented type names I feel it may be justified to make the library easier to consume. Perhaps "Value" or "Report" as a suffix would make it less like a namespace and more descriptive?


Automatically stale and close issues

Introduction
This is a pull request as well as an enhancement proposal for the repository.
There are issues created in 2021 that are still opened, some of them might be relevant but not enough to receive any updates. To avoid accumulating issues, I think it would be interesting to automatically stale and close issues that does not receive any update.
Changes
This pull requests adds a new automated workflow to automatically mark issues as stale and close them using the Stale Github Action.
It works as the following:

After 90 days without activity, the issue is marked as stale with the following message

"This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed."

After 7 days of being marked as staled, the issue is closed with the following message

"This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem."

It is possible to label issues with Issue accepted to ensure that they will never be closed automatically.

@drwpow what do you think?

I’m in favor of this. I think we’re at a point now where the number of issues opened do need to get cleaned up. While sometimes we may close an issue that may still be present, I think it will help the quality of issues as the stale ones usually contain no reproductions and contain too much missing info for it to be a quick, actionable fix.

It is possible to label issues with Issue accepted to ensure that they will never be closed automatically.

I really like this. There will definitely be some issues where they may go stale, not from lack of interest or missing info, but just because they are particularly challenging problems.


Crashes due to ledger mutations

At present, the ledger can be mutated without notifying or updating other parts of the program that depend on the ledger state.
For example the ledger may be mutated during Transaction_pool.apply, causing the ledger to become inconsistent. This has manifested in

#6946 where the ledger is detached while a diff is being applied

addressed by PR #6971

#7613, #4255, #4274,  #4282 where the ledger has changed while a diff is being applied

addressed by #7639 (in review)

the ledger has changed but the pool hasn't yet been updated, violating invariants

partially addressed by #7705

It's not clear what is mutating the ledger to cause this. We should investigate, and consider using immutable ledgers by default. If we use mutable ledgers only at creation and destruction time, and only allow ledger mutation when no immutable references are held via some kind of locking, then we should be able to mitigate this.
There are related concerns around all of our uses of ephemeral data. For example, the transaction pool is valid at a particular slot, and modifying it before we update it to the current slot also breaks invariants. We need to think much more carefully about how we handle mutable and ephemeral data, especially in the context of the concurrent async primitives we use.

We haven't seen this crash again since #7759 was merged. Tentatively closing.


Latest version

guess this doesn't work on acrobat 2020.09.20067, tested but "hello world" doesn't popup. what a nice project you put up anyway

Hi thanks for the appreciation.
I have just tested this in Windows 10 with version 20.009.20067 (and I ran check for updates and got none). The alert message did popup for me.
Can you try again please?

Closing this because it absolutely worked and there hasn't been an update.


SecurityHub just receives alerts in Audit account

Hi!
Was just checking something here:
resource "aws_securityhub_account" "default" {
  provider = aws.audit
}

won't this just create SecurityHub in the Audit account, but not assign it any members, make it the delegated admin, or receive findings from the other AWS accounts in the organisation?
Compare this to:
resource "aws_securityhub_account" "default" {
  provider = aws.audit
}

resource "aws_securityhub_organization_admin_account" "example" {
   admin_account_id = var.control_tower_account_ids.audit
}

resource "aws_securityhub_organization_configuration" "example" {
   provider = aws.audit
   auto_enable = true
}

Hey @HarleyB123 , thank you for your comment. You are right this was a manual action up until now and I created this issue in the provider https://github.com/hashicorp/terraform-provider-aws/issues/17287 as a reminder to add this. I see the community already picked it up which is great! https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/securityhub_organization_admin_account . I'll put this on our next sprint to pick up, but feel free to open a PR if you like.

Cool, thanks for the quick reply @marwinbaumannsbp ! Yeah happy to put a PR in. Should note though that when I applied it with the change locally, the SNS messages get very heavy and frequent - might need a design change there

Hey @HarleyB123 this is a known issue indeed and we are working on that :-)


Model PR (or other jurisdictions)

Find birth data, or estimate births based on population
Find any validation data?

Out of scope. If anything, we'd want to do state-level estimates first. In a sense, this is the opposite requirement of #18


Update documentation for Express version 4

The readme instructs developers to pass express to connect-tedious:
var express = require('express');
var TediousStore = require('connect-tedious')(express);

In version 4.x, Express removed all built-in middleware from its core except express.static.  So the documentation should read:
var express = require('express');
var session = require('express-session');
var TediousStore = require('connect-tedious')(session);

Not sure if you still want to support Express 3 -- at the very least include a note in the readme about Express 4 and express-session?

Thanks for the feedback. We support both frameworks (at least for now) but I will update the documentation as you suggest.
I will close the issue when the next version is released (nothing planned yet).

Landed in version 1.0.0