Unclear how (if even possible?) to filter Obj-C categories

I added what I expected to be a small additional API surface to my exclude-all-by-default: true Obj-C ffigen set, and then re-ran and was seeing a ton of unexpected new Cocoa UI classes. I picked one and tried to trace why it was included via verbose logging, and it looks like the problem is that I am now using NSView, and every type used in every category on NSView is now being considered a transitive inclusion.
Arguably this is just a special case of needing method filtering, but I think it's worth filing separately because this is pretty unexpected behavior; if I use an extremely core class, I do not expect to get every highly use-case-specific extension to that class that's reachable anywhere in the SDK when I'm using default-exclude. I can see the argument for this behavior, but I think the NSView case is a potential argument against default-including categories for any included type. And even if we do want to default-include them, it should be possible to exclude them by category rather than by method.

Dupe of https://github.com/dart-lang/native/issues/271


Editing capabilities

Make the contenteditable actually editable through keyboard input, selections, etc. Currently behavior is buggy and not working because of the underlying tables.

Idea: not to use contentEditable, but a floating textarea like they do it in Ace (https://github.com/ajaxorg/ace/). Ace could provide a lot of hints on how to fix various problems and scenarios.


Implement recurrent layers

Add support of recurrent layers to the converter:

[ ] GRU

[ ] LSTM

ONNX still have a very bad support of recurrent layers.


⚖ Register range Validator

Register new validator gentx on the drunemeton-1 network.

Was not selected for this network.


ReferenceError: TextEncoder is not defined

The setup
I went to the wiki and followed the step in "0. Installation" successfully:
>> node -v
v8.16.0
>> npm -v
6.4.1
>> fmc
Formality-Core
...
Note: fmc will automatically import any local file ending in .fmc.
>> lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic
The hello world file main.fmc:
def main:
  "Hello, world!"

The error
>> fmc main
/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:819
var bytes = [].slice.call(new TextEncoder("utf-8").encode(text), 0);
^
ReferenceError: TextEncoder is not defined
at text_to_term (/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:819:33)
at parse_term (/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:171:14)
at Object.parse (/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:287:18)
at Object. (/home/dan/opt/npm/lib/node_modules/formality-core/main.js:57:28)
at Module._compile (module.js:653:30)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Function.Module.runMain (module.js:694:10)
The error seems to appear also when called on a file that does not exist
>> fmc doesnotexist
/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:819
var bytes = [].slice.call(new TextEncoder("utf-8").encode(text), 0);
^
ReferenceError: TextEncoder is not defined
at text_to_term (/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:819:33)
at parse_term (/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:171:14)
at Object.parse (/home/dan/opt/npm/lib/node_modules/formality-core/fm-core.js:287:18)
at Object. (/home/dan/opt/npm/lib/node_modules/formality-core/main.js:57:28)
at Module._compile (module.js:653:30)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Function.Module.runMain (module.js:694:10)

Seems like your locale is not set to UTF. What does
$ echo $LANG
$ echo $LC_ALL

return for you? Try
$ export LC_ALL=en_US.UTF-8

Also you could try updating to a more recent version of node. If that fixes it, we should probably update the wiki's installation instructions with minimum versions

Thank you, upgrading fixed it. I am on node version v12.4.0 now.
In hindsight, I did not follow the guide exactly. Out of comfort I used the Ubuntu package manager to install node, which was why I had the version that was too old. So adding some sentence like "make sure that you are at least on version vX.X.X" would have prevented me from using the Ubuntu package manager.
I would guess that v10.16.0 (which is the lts version one gets from following the guide) is enough, but I have not verified this.


Bug: Default Model Setting Inconsistencies in Open WebUI

Bug Report: Default Model Setting Inconsistencies in Open WebUI
Environment

Open WebUI Version: v0.3.30 (latest)
Installation Method: Docker Desktop

Ollama Version: v0.3.12 (latest)
Installation Method: Ollama Windows (preview)

Operating System: Windows 11 Pro 24H2, OS build 26120.770, Windows Feature Experience Pack 1000.26100.6.0
Browser (if applicable): Firefox v131.0 (64-bit)

Confirmation

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[x] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Description
Bug Summary:
Multiple inconsistencies have been discovered in the default model settings across the Open WebUI platform. These issues affect the Set as default functionality, Admin account settings, and Whitelisted model constraints.

Expected Behavior
Issue 1: Inconsistent Default Model Setting
When a user sets a model as the default from the chat page's model drop-down selector, the change is not reflected in their Interface settings for the Default Model option. However, if the default model is set from the Interface settings, the update is correctly reflected in both the chat page and the Interface settings.
Expected Behavior:

Setting a model as default from the chat page drop-down selector should update the default model in both the chat page and the Interface settings.

Issue 2: Admin Account Settings Not Overriding User Default Model
Setting the Default Model under the Users tab in an Admin account does not override the user's default model for new chats. Instead, it only updates the user's Interface settings for the Default Model option, requiring the user to manually save the changes.
Expected Behavior:

Setting the Default Model under the Users tab in an Admin account should override the user's default model for new chats, without requiring manual user intervention.

Issue 3: Admin Account Model Setting Validation
An Admin account can set the Default Model under the Users tab to a model not present in the list of Whitelisted models. This results in the default model being cleared in the user's Interface settings for the Default Model option.
Expected Behavior:

The Admin account should only allow setting the Default Model to a model present in the list of Whitelisted models.
A validation mechanism should be implemented to ensure the selected model is Whitelisted before applying the default model setting.

Reproduction Details
Steps to Reproduce:

Set a model as default from the chat page's model drop-down selector.

The change should be updated in both the chat page and the Interface settings, but it is not.

Set the default model from the Interface settings.

The change is correctly reflected in both the chat page and Interface settings.

As an Admin, set the default model under the Users tab for a user.

The setting should override the user's default model for new chats, but it does not.

As an Admin, set the default model under the Users tab to a model not present in the list of Whitelisted models.

The Admin account should not allow this, but it does, resulting in the default model being cleared in the user's Interface settings.

Recommendations
To address these issues, the recommend fixes are introduced:

Update the Set as default functionality to correctly reflect the default model in both the chat page and Interface settings.
Enhance the Admin account settings to override the user's default model for new chats without manual user intervention.
Implement validation mechanisms to restrict the selection of models not present in the list of Whitelisted models.

Note
This bug report aims to provide all necessary information for reproduction and addressing of the issue. If any additional details are required, please let me know.

I notice those too and it's an issue for my family setup.

What should be also the behaviour for the 'whitelist models' in the interface settings?
When set, should the models for all users and the admins matched the given list in the model selector in chat? (Preferred behaviour)
Or admin user should have all models accessible in the model selector in chat? ( Actual version)

What should be also the behaviour for the 'whitelist models' in the interface settings?
When set, should the models for all users and the admins matched the given list in the model selector in chat? (Preferred behaviour)
Or admin user should have all models accessible in the model selector in chat? ( Actual version)

I believe the current functionality of the Admin's ability to whitelist models on a User account level is desired and the preferred behavior.

This issue has been closed due to the depreciation of the Set as default option found within the Interface settings menu and the depreciation of the Users tab in the Admin settings menu.

Hi there,
I've looked through the documentation but couldn't find any information about this: is there still a way for Admin to set Default Models for other users through alternative means or interfaces? This functionality is quite important for our team's workflow.


feat(non-literal-require): support template literals

I did not have write access to the fork for #32, so i forked the fork and implemented the following changes:

This PR has resolved the merge conflicts currently on #32.
The old PR failed 16 tests due to ESLint >6 requiring absolute parser paths for rule testers. This is resolved. More info:
https://github.com/eslint/eslint/blob/main/docs/user-guide/migrating-to-6.0.0.md#rule-tester-parser

This closes #29  and #27
@nzakas Can you close #32 in favor of this pr, and possibly merge?

@nzakas removed the babel-eslint dependency and cleaned it up.


Improve breadcrumbs semantic and add HTML5 Microdata

Fixes https://github.com/argyleink/gui-challenges/issues/44
It passes the Google Rich Results Test keeping the old functionalities. This Patch improves automatically its accessibility as well using the proper markup for the breadcrumb items.

nice, ty for this! would you mind adding an additional breadcrumb example instead of changing each of the existing?

@argyleink thank you for reviewing it. Sorry but I don't understand what you are proposing: should I create a new folder using this markup and calling it semantic-breadcrumbs or should I just add 1 HTML Example with semantic code?
Honestly I think that providing different markup solutions might be misleading for beginners and it feels not right to me.
Please let me know if I can do anything to help you on this PR.

Sorry, I'll try to be more clear! I think it'd be misleading also to come from an article or video that has different HTML than was found in the repo. If we're additive about this microdata example, and clearly label what it is and what it offers, then it feels like the best of both worlds. the original breadcrumbs are available, as well as a community contributed one! I think a new html and css file with the modified contents should do the trick well?

@argyleink I have updated my patch according to your suggestion. Please let me know if that works for you.

thanks for helping others by sharing your style!


Removed AniAPI

Removed AniAPI. (#52)
The API domain aniapi.com is for sale and all the GitHub repositories are marked as public archives. It's save to assume that support for this API has stopped.

@marcelscruz could you link #52 to this or close it once this gets merged?

Thank you!


hi, is eval progress online also sampled from the data set with not fix support set as written  in code

code in data_loader.py   next_batch.

Yes. During validation and test, we sample support and query sets from the corresponding datasets. Since the number of sample times is very large, evaluation results eventually converge.

Yes. During validation and test, we sample support and query sets from the corresponding datasets. Since the number of sample times is very large, evaluation results eventually converge.
thanks for your reply!
i've found 5 way 5 shot on pure proto network only 86% in the val dataset , is there 3% gap between val and test?

Yes~


Feature/jdk9

More tests

Coverage increased (+13.09%) to 39.113% when pulling feb8e2f5e4f41bf66a7b31cef720c7521ce992c8 on feature/jdk9 into 04d4ddea9870cc552d8a233308046b90a8c2eb77 on master.


Fixed #25083 -- Added SessionAuthenticationMiddleware to auth installation docs

Correction to my previous PR (https://github.com/django/django/pull/4963)
The (new in 1.7) django.contrib.auth.middleware.SessionAuthenticationMiddleware is an incredibly important security improvement that insures a user's other sessions are logged out after a password change.  We should add it to the >1.7 docs on auth installation as a default.

Thanks, fixed the line-wrap, should've read the contribution guidelines more thoroughly :panda_face:

merged in f0857c09fb51b21afb3e55da53bce962466af6d3, thanks.


[Bug] Connectivity coloring appears when closing selected region when 2 region is selected

steps to reproduce:
0/ go to /, select human multilevel, select mni152 template space
1/ select region "Area 6ma (preSMA, mesial SFG) - left hemisphere" and "Area 6ma (preSMA, mesial SFG) - right hemisphere" together from the viewer
2/ expand and collapse Connectivity
3/ deselect region
expected behavior:
Map coloring should restore
actual behavior:
Map applies connectivity coloring

cannot reproduce. I got the expected beahviour

Sorry step 1 was wrong 2 region should be selected, so "Ch 123 (Basal Forebrain) - left hemisphere" and "Ch 123 (Basal Forebrain) - right hemisphere" toegether

still cannot reproduce.
Connectivity data never showed for me.

Could you please look at the gif?

that is not CH 123

Yeah, Ch 123 has not connectivity for this version of the connectivity dataset and it was not possible to explore bug at this region (my mistake sorry)

bandaid fix maybe fixing #686 , but should debug thoroughly

bandaided by #691
@fsdavid do you want to keep this issue open so you can fix it later?

I think for now, it is better to close. We can reopen if the problem appears in the future.


Client ID

I cant create a client ID

Hello.
Please contact NRG Tech Support (if you haven't already).
Thanks!


Update web-sites-restore.md

fixed a typo

Hi @nromyn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@nromyn : Thanks for your contribution to the Azure documentation! The author, @cephalin, has been notified to review your proposed change.

@nromyn Thanks for the catch and for fixing it for us! #sign-off


adding toolbar button to display trails of cells deaths

This PR

adds toolbar button to display trails of cells deaths
adds the state of button to datastore
modified tutorial.js and locale.ini for new toolbar button
adds attribution for new icon used

Very cool.
Two UI remarks:

I think the death color could be brighter, may be a lighter gray or why not do a very light version of the stroke color
I'm not a big fan of your icon: it's too big (icons should have margin between the border and the content) and it's not really explicit. May be you could find something around the concept of "footsteps"?

changed icon (also added the attribution)

i have not use lighter version of stroke color as if stoke color is like yellow or any other bright color, then we can have a problem where both are alive and dead cells are of same color.

Good job. Thanks.


Support Container Tabs for Zen Browser (Firefox fork)

Is your feature request related to a problem? Please describe.
I've started to switch over from Firefox to Zen Browser (https://zen-browser.app/), which is an alternative Firefox fork that's similar to Arc. I've used Container Tabs in Firefox to keep browsing data separate for personal, schoolwork, and work-related uses, which Browsers does support with the use of the "Open external links in a container" add-on.
While Browsers does have basic support for Zen Browser, it does not have support for Container Tabs. Links opened in Zen Browser open in the default "No Container" tab type.
Describe the solution you'd like
Add support for Container Tabs (like Firefox has) for Zen Browser.

Hi @grizzogor
In Zen Browser go to about:profiles in the web url entry and look for "Root Directory".
Then copy the <config_dir_relative> part from /Users/xyz/Library/Application Support/<config_dir_relative>/Profiles/...
If macOS, you could go to Applications in Finder, right click on Browsers and choose Show Package Contents.
Then go to Contents->Resources->repository
In that directory edit application-repository.toml and add this section:
[[apps]]
id = "org.mozilla.com.zen.browser"
config_dir_relative = "Firefox"
kind = "FIREFOX"
os = "MAC"

Yep, that works great. The config_dir_relative in my case is zen.
Thanks!


Display the logged in user full name, image url (avatar) [Story #312 Visualizing the Login Status ]

https://github.com/almighty/almighty-core/issues/312
On the current application header, we can display the logged in user's:

full name
avatar

On a Git hub login, there are two parameters, we can get.

Here is a reference to the UX for Login https://redhat.invisionapp.com/d/main#/console/8621915/185564523/preview

PR #189 merged with master, hence closing the issue.


[DOCFIX] Add doc on how to deploy proxy in docker/k8s

Solves https://github.com/Alluxio/alluxio/issues/13137

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.9 please


<details> blocks linkable

Made the <details> block linkable and will auto expand when the link is opened through the hashed links.
Some considerations and possible issues:

I have used the details title for the id attribute which seems to be a good solution until there are some pages that have the same titles in multiple places particularly  Expand to see what happens under the hood.

Fix for #3314

Fixes #3314 closes #3299

This update generates the hash links for titles serially unique on page level(the previous version had uniqueness on whole docs level so there could be hash link starting from numbers even it's occurred 1st time on the page).
This one is simple and for simple titles only it's adopted this way eg: Mermaid sequence diagram.
Also, I will also be submitting another pr which will have the custom slugger where we can also provide some random code/words through props to make the hash link unique.

But, the possible problem with this method is updating the page and adding another <details> can alter the numbering causing old links to refer to another place.

Personally, I don't see this as a huge issue 🤔 Our headings work the same way. Should we avoid making a custom slugger and just use github-slugger?

Quick Q. What about

Separately we have the expandable  sections which contain details we want to have but hide by default. I guess the same component for general notes could just have a prop to determine if it's auto-hidden.

From https://github.com/iterative/dvc.org/issues/3153#issuecomment-1064853806
?
I.e. will we keep the custom <details> component after that is implemented?

I.e. will we keep the custom <details> component after admonitions are implemented?

I believe so! Collapsible admonitions will probably be created by expanding the <details> component.

Personally, I don't see this as a huge issue 🤔 Our headings work the same way. Should we avoid making a custom slugger and just use github-slugger?

I feel like hash link creation should be completely automated. Plus, wouldn't that make URLs more lengthy and less readable?

I also prefer this way as:

the level of an impact overall doesn't seem to be huge
also the fact that docs maintainer doesn't need to take care of providing the custom code
plus we can encourage the docs maintainer to provide a unique title but isn't compulsory

I.e. will we keep the custom <details> component after admonitions are implemented?

I think the <details> component will still be there, it will still be useful for very long descriptions which are better hidden.
Also, it looks like the plugin mentioned by Roger also supports nested markdown.

@yathomasi, what's blocking this from being merged? Is it waiting on the decision between using a custom slugger and github-slugger?

@yathomasi, what's blocking this from being merged? Is it waiting on the decision between using a custom slugger and github-slugger?

Yes, @iterative/docs can also help to decide on which could be better. We already kind of have our preference.

@iterative/docs, we're discussing adding some props to <details> that help create the anchor link (#3329):

code - text that is added to the anchor link
position - whether text is added to the beginning or end of the link

Aka
<details code="staring and storing" position="start">

### Expand to see what happens under the hood.

text, text, etc.

</details>

would create a details block with the link being #storing-and-sharing-Expand-to-see-what-happens-under-the-hood.  Would these props be useful to you or should we just use the title to create the link?

@julieg18 Thank you for putting this clearly here.

what's blocking this from being merged?

This PR is still a draft too. Is it ready for review?

not sure what the utility is for code/position (complicates and lengthens the anchor). Am I missing something?

The initial motivation for code is so that a single docs page can have multiple details blocks with the same summary content, as the resulting ids need to be unique.

Oh I see, good point. We probably shouldn't use headers for <details> titles then, since headers in general are supposed to be unique. Maybe add a title prop instead? And append it with a number in the anchor if needed.

This PR is still a draft too. Is it ready for review?

Yeah, it's ready for review. To clear the point, we basically have two options to make the id unique:

Using github-slugger(current pr), which will basically add numbers to the slug if it's already there.

examples:

doc/start/data-and-model-versioning#Expand-to-see-what-happens-under-the-hood
doc/start/data-and-model-versioning#Expand-to-see-what-happens-under-the-hood-1

Using custom code based slugger(pr #3352 ), for which it will throw error during development time and we need to provide unique code prop in order to make it unique.

The pros and cons of both methods are already discussed(if any queries can be discussed). So, now we need to decide which one should we go with?

I vote for reusing title prop instead of (current behavior) taking the first chile element's tex as title;
and make the anchor unique automatically. p.s. minor: anchors like the rest of the URL are all lower case right?

I vote for reusing title prop instead of (current behavior) taking the first chile element's text;
and make the anchor unique automatically (append number when needed).

So if I'm understanding correctly, we should add a title prop that will become the anchor link URL, and if no title is given, take text from the first child element?
Also, @yathomasi, I don't see any need to use #3329. We can take any props for creating the URL string in the Details component, and have github-slugger handle the rest of the logic. Unless I'm missing something?

I vote for reusing title prop instead of (current behavior) taking the first chile element's text;

So, I assume you mean, provide title through props instead of 1st child. That would just be a different way of providing the title and I also think will be better but it's just the preference for the title.

and make the anchor unique automatically (append number when needed).

For uniqueness, I understand @jorgeorpinel voted for no.1 (current pr) which appends the number if there are two same titles.

p.s. minor: anchors like the rest of the URL are all lower case right?

Yes, it will all be lowercase(just was trying with @casperdcl 's preference).

Also, @yathomasi, I don't see any need to use https://github.com/iterative/dvc.org/pull/3329. We can take any props for creating the URL string in the Details component, and have github-slugger handle the rest of the logic. Unless I'm missing something?

I assume you mean #3352 . Yes, if we go with numbering then we don't need that. But, if we want to throw an error if there are two same titles(for manually setting the unique title) or also if we don't want to have numbering then we would need to go with the custom slugger.

and make the anchor unique automatically (append number when needed).

@jorgeorpinel This pr exactly does that. So before merging this,  we want to be clear. So, here are some points.

We are making this <details> block sharable with link and we don't want those link to change with time.
With this approach if we happen to edit the docs and add another <details> block, the numbering can change.
if such changes are rare or those changes are acceptable then this method would be best.
Otherwise, if the changes are frequent then it would be better to look into another approach(#3352)

PS: regarding title on props instead of first child can be another pr/discussion.

The commit check is failing on prettier for content/docs/command-reference/repro.md, but that's unrelated to this PR (I think it may have been an earlier issue that's already been solved by @julieg18?)

@julieg18 @rogermparent thanks for the review.

The commit check is failing on prettier for content/docs/command-reference/repro.md, but that's unrelated to this PR (I think it may have been an earlier issue that's already been solved by @julieg18?)

Yes, seems to be the same one. We can create a new issue if it's not. So, merging this one for now.

The commit check is failing on prettier for content/docs/command-reference/repro.md, but that's unrelated to this PR (I think it may have been an earlier issue that's already been solved by @julieg18?)

Yes! I think this branch might not have been on the latest version of master :)

I'm understanding correctly, we should add a title prop
I assume you mean, provide title through props ... can be another pr/discussion

All HTML tags have the title attribute I think, which is what I was referring to by "reuse". Agree to do that separately because we'll need to also change lots of content simultaneously (remove current header first-childs).

make the anchor unique automatically (append number when needed).

we want to be clear....
With this approach if we happen to edit the docs and add another  block, the numbering can change

Ah wait that's a good point. That may be problematic. Content gets rearranged all the time. A details block that was no 2 in the doc may well become no 4 in the future. Well, it's not that common actually but it can definitely happen.
So maybe we should require an id or some other prop that's supposed to be unique somehow after all 😅

https://github.com/iterative/dvc.org/issues/3383


I was wondering If exist a similar method than sendRequest(postman) in Bruno?

I need to re-send a request to evaluate other scenarios like 401 or 404, and I don't want to create a particular request for each scenario.

Hey @ivonnepurpose,
Thanks for creating this issue.
Could you share more context on it if possible any screenshot or video will be helpful.

Hi @ganesh-bruno
Certainly! For example, I have a POST request, and I would like to test error code 400 with different scenarios. My request receives a JSON with several fields, and I want to test, for instance, by omitting one of the mandatory fields or using invalid data types. In this case, I would like to resend the request multiple times with different JSON payloads without needing to create a separate request for each JSON.
Thanks in advance


Error: Failed to call done in a stream handler before 30000ms timeout

Given this task:
gulp.task('jshint', function() {
   var jsHintOptions = {
      globalstrict: true,
      browser: true,
      globals: {
         angular: true,
         console: true,
         jQuery: true,
         $: true,
      },
      shadow: "inner",
      sub: true,
      strict: false,
      laxcomma: true
   };

   gulp.src(globalSearchFiles, {base: './'})
      .pipe(jshint(jsHintOptions))
      .pipe(jshint.reporter('jshint-summary', {
         verbose: true,
         statistics: true
      }))
      .pipe(jshint.reporter('fail'));
});

I get the following error after all gulp tasks have finished:
[INFO] [12:47:53] Starting 'jshint'...
[INFO] [12:47:53] Finished 'jshint' after 43 ms
...
[INFO] events.js:72
[INFO]         throw er; // Unhandled 'error' event
[INFO]               ^
[INFO] Error: Failed to call done in a stream handler before 30000ms timeout.
[INFO]     at null._onTimeout (.../node_modules/gulp-jshint/src/stream.js:32:27)
[INFO]     at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

You need to return the stream, its in the docs everywhere.


tune data model for unified flow

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
Update date model to support unified flow
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #33 (3750935) into single-flow-development (a648e86) will decrease coverage by 0.26%.
The diff coverage is 51.85%.

:exclamation: Current head 3750935 differs from pull request most recent head 26056b5. Consider uploading reports for the commit 26056b5 to get more accurate results

@@                      Coverage Diff                      @@
##             single-flow-development      #33      +/-   ##
=============================================================
- Coverage                      79.21%   78.95%   -0.27%
- Complexity                      2681     2684       +3
=============================================================
  Files                            242      242
  Lines                          11025    11131     +106
  Branches                        1010     1029      +19
=============================================================
+ Hits                            8734     8788      +54
- Misses                          1878     1913      +35
- Partials                         413      430      +17

Flag
Coverage Δ
Complexity Δ

plugin
78.95% <51.85%> (-0.27%)
2684.00 <5.00> (+3.00)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

...on/opendistroforelasticsearch/ad/model/ADTask.java
86.76% <50.66%> (-9.80%)
68.00 <4.00> (+2.00)
:arrow_down:

...stroforelasticsearch/ad/model/AnomalyDetector.java
90.38% <54.54%> (-5.22%)
92.00 <1.00> (+1.00)
:arrow_down:

...ndistroforelasticsearch/ad/task/ADTaskManager.java
72.99% <0.00%> (-0.23%)
81.00% <0.00%> (-1.00%)

...troforelasticsearch/ad/task/ADBatchTaskRunner.java
87.82% <0.00%> (ø)
63.00% <0.00%> (ø%)

...sticsearch/ad/indices/AnomalyDetectionIndices.java
51.72% <0.00%> (ø)
45.00% <0.00%> (ø%)

...stroforelasticsearch/ad/AnomalyDetectorRunner.java
46.25% <0.00%> (+6.25%)
7.00% <0.00%> (+1.00%)


Update wrong URLs on the docs

Some of the links and the markdown structure at the Views' page are wrong (https://reactnavigation.org/docs/views/). This PR update and fix the missing links to the doc.

Hi! This was completed in #2374.


Unable to download bigdatauniversity/spark image for docker

"Network timed out while trying to connect to https://index.docker.io/v1/repositories/bigdatauniversity/spark/images. You may want to check your internet connection or if you are behind a proxy."
"no such image
404
No such image: bigdatauniversity/spark:latest"

I'm getting these 2 errors when I'm trying to download spark image form docker.

The latest tag does exist for that image, it's surprising that you got a 404 - More than likely your network connection isn't solid and the source of the download issue.
https://hub.docker.com/r/bigdatauniversity/spark/tags/
The image is 2GB, please make sure that you have a good connection prior to downloading it.

Thanks for the timely reply. I was on a pretty good network. Now that
you've confirmed the image's there, I'll try a couple of more times.
Thanks,
Bhavya
On Thu, Mar 10, 2016 at 2:26 AM, French Ben<EMAIL_ADDRESS>wrote:

The latest tag does exist for that image, it's surprising that you got a
404 - More than likely your network connection isn't solid and the source
of the download issue.
https://hub.docker.com/r/bigdatauniversity/spark/tags/
The image is 2GB, please make sure that you have a good connection prior
to downloading it.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/kitematic/issues/1530#issuecomment-194503841.


Bump relaton version

relaton-py has been updated to reflect changes in Relaton schema. This allowed to remove part of the normalisation the bibxml-service does
update test fixtures to reflect the schema changes mentioned above

@stefanomunarini Tests fails with following:
xml2rfc_compat/serializers/authors.py: note: In function "create_author":
xml2rfc_compat/serializers/authors.py:153: error: Generator has incompatible item type "Optional[str]"; expected "str"  [misc]

Logs: https://github.com/ietf-tools/bibxml-service/actions/runs/4554262178/jobs/8031886606

@kesara sorry for letting this PR sit for so long. I bumped into it the other day and fixed all the mypy complaints and a few other minor issues.


feature: Adds gzip compression to HTTP responses, dramatically improving load times.

Overview
Introduces gzip compression to responses.
Example change
index.js response size reduced from 2.9mb to 628kb.

Requesting a code review / pointers to documentation for requesting a code review – @whitdog47 @kevgliss.


Ambiguous occurrence of InstalledPackageInfo_

I'm running into some compile errors while trying prepare the haskell-docs package for Debian.
Preprocessing library haskell-docs-4.2.2...
[1 of 7] Compiling Haskell.Docs.Types ( src/Haskell/Docs/Types.hs, dist-ghc/build/Haskell/Docs/Types.o )
[2 of 7] Compiling Haskell.Docs.Ghc ( src/Haskell/Docs/Ghc.hs, dist-ghc/build/Haskell/Docs/Ghc.o )
[3 of 7] Compiling Haskell.Docs.Cabal ( src/Haskell/Docs/Cabal.hs, dist-ghc/build/Haskell/Docs/Cabal.o )

src/Haskell/Docs/Cabal.hs:59:21:
    Ambiguous occurrence `InstalledPackageInfo_'
    It could refer to either `Distribution.InstalledPackageInfo.InstalledPackageInfo_',
                             imported from `Distribution.InstalledPackageInfo' at src/Haskell/Docs/Cabal.hs:12:1-40
                          or `PackageConfig.InstalledPackageInfo_',
                             imported from `PackageConfig' at src/Haskell/Docs/Cabal.hs:20:1-20
                             (and originally defined in `Cabal-1.16.0:Distribution.InstalledPackageInfo')

src/Haskell/Docs/Cabal.hs:59:48:
    Ambiguous occurrence `InstalledPackageInfo_'
    It could refer to either `Distribution.InstalledPackageInfo.InstalledPackageInfo_',
                             imported from `Distribution.InstalledPackageInfo' at src/Haskell/Docs/Cabal.hs:12:1-40
                          or `PackageConfig.InstalledPackageInfo_',
                             imported from `PackageConfig' at src/Haskell/Docs/Cabal.hs:20:1-20
                             (and originally defined in `Cabal-1.16.0:Distribution.InstalledPackageInfo')

src/Haskell/Docs/Cabal.hs:60:11:
    Ambiguous occurrence `InstalledPackageInfo'
    It could refer to either `Distribution.InstalledPackageInfo.InstalledPackageInfo',
                             imported from `Distribution.InstalledPackageInfo' at src/Haskell/Docs/Cabal.hs:12:1-40
                          or `PackageConfig.InstalledPackageInfo',
                             imported from `PackageConfig' at src/Haskell/Docs/Cabal.hs:20:1-20
                             (and originally defined in `Cabal-1.16.0:Distribution.InstalledPackageInfo')

src/Haskell/Docs/Cabal.hs:61:7:
    Ambiguous occurrence `exposedModules'
    It could refer to either `Distribution.InstalledPackageInfo.exposedModules',
                             imported from `Distribution.InstalledPackageInfo' at src/Haskell/Docs/Cabal.hs:12:1-40
                          or `PackageConfig.exposedModules',
                             imported from `PackageConfig' at src/Haskell/Docs/Cabal.hs:20:1-20
                             (and originally defined in `Cabal-1.16.0:Distribution.InstalledPackageInfo')

src/Haskell/Docs/Cabal.hs:62:7:
    Ambiguous occurrence `hiddenModules'
    It could refer to either `Distribution.InstalledPackageInfo.hiddenModules',
                             imported from `Distribution.InstalledPackageInfo' at src/Haskell/Docs/Cabal.hs:12:1-40
                          or `PackageConfig.hiddenModules',
                             imported from `PackageConfig' at src/Haskell/Docs/Cabal.hs:20:1-20
                             (and originally defined in `Cabal-1.16.0:Distribution.InstalledPackageInfo')
/usr/share/cdbs/1/class/hlibrary.mk:120: recipe for target 'build-ghc-stamp' failed
make: *** [build-ghc-stamp] Error 1

I tried a few quick hacks with no luck. It could be our version of cabal. I'd be happy to patch this but a hint would really help.

Hmm, haskell-docs should build with the versions specified in the GHC file. Please state your versions of ghc and cabal.

ghc - 7.6.3
cabal-install - <IP_ADDRESS>
Cabal - <IP_ADDRESS>

Is this still an issue?


Add a table for tools used by organizations

I'm thinking of a table with columns (this could be OrgWatch-only):

Organization (e.g., GiveWell, Animal Charity Evaluators)
Tool (e.g., Slack, Google Docs, Drupal, Toggl)
Tool type (e.g., "Content management system" "Real-time communication platform") that is an enum. The tool type should be a function of tool (alternatively the tool -> tool type mapping can be a separate table)
Start and end time of use of tool (to the extent known)
Notes on how the organization uses the tool; for instance, for organization = GiveWell, tool = Slack, stuff like what's at https://denver-frederick.com/2019/05/04/elie-hassenfeld-co-founder-and-executive-director-of-givewell-joins-denver-frederick/ "We use Slack as our internal chat program, and we have a channel for mistakes."

@riceissa and @sebastiansanchez123, what do you guys think?

This seems fine, but I am wondering what most people would get out of learning this information about an org. I can see some productivity-obsessed people caring about such details, but I think most people care more about less granular details, like the ratio of text to face-to-face communication, or ratio of asynchronous to synchronous communication. These things give a feel for how the org operates without spending time on "irrelevant" details (but they are also harder to find).

I think this also depends on the possibility to find enough information about the tools being used by orgs. But also, if tools are replaced by others at some pace we can't track, I don't know how useful this endeavor would be.


Need to add GIMP (mailbox intelligence)

aka Graph-based impersonation

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@MSFTTracyP - PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith


Zoomed in cameras cause the ui to become misplaced and incorrectly scaled

When changing the zoom of a camera with the projection.scale property the ui is not affected and ends up improperly scaled and positioned

Fixed in version 0.1.1 for Bevy 0.14.0. I will release the crate once 0.14.0 lands. For now you can use the "dev" branch (0.14.0) on GitHub.


Fix parsing of markdown code element

This solves issue #8 whereby 2 anomalies occurred constantly when parsing grave accent to represent markdown element code. For example, let c1 = this is code, c2 = this is code too

When either c1  or c2  occurs at the the beginning of a file, it will cause a runtime error.

When either c1 or c2 occurs somewhere within the file, it doesn't cause a runtime error but as explained in #8, it outputs a random string of numbers.

After further investigation, the culprit is in the regex string: "(?<!\\\\)(?:\\\\\\\\)*+(+)(.?[^`].?)(\1)(?!`)"`. I am not good at regex yet but that's where the issue is. So, in my implementation, I modified the regex string and no anomaly occurs and thus no runtime error.

This seems to have a lot of conflicts which need to be solved, will try working it out sometime soon.

Is this being worked on? I've found that simply trying to parse the following crashes and I think it's related:
```test

@DavidLari Closing the triple ticks will prevent the crash as in test. Although ideally, not closing keyword w/ triple ticks, the word simply will not get parsed as markdown format. I have tested this unclosing pattern on other markdown elements and they work ok.

The problem is I am creating a markdown editor using this library to show the preview. So, crashing on open ticks is a showstopper.


Which license

I've put the BSD-3 license since it is quite permissive but requires our consent for derived products.

@MichielStock  do you agree with this license?


fix for cocoapods with use_framework!

When I use Cocoapods with use_framework! flag to work with my Swift project, I met this problem that includes wrong path.
But I'm not sure is it correct for other situations with this modification.

I use use_framework! too, but not problem. Can you try it again and show me the result?


Add End Sequence to ReadRange API

This allows callers to specify both count and end sequence in mutations ReadRange API. The returned range stops when either count or end sequence is reached, whichever comes first.
Partial #59.

Codecov Report

Merging #581 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   59.66%   59.66%
=======================================
  Files          32       32
  Lines        2209     2209
=======================================
  Hits         1318     1318
  Misses        616      616
  Partials      275      275

Impacted Files
Coverage Δ

impl/sql/mutations/mutations.go
55.81% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e1ec0...d900721. Read the comment docs.


ANC Subs Visit - Next Steps - Gonorrhea [2h]

Issue
When a patient identifies that they have the following symptoms, we provide health education and medication:
(1)Symptom Review: Abnormal Vaginal Discharge + partner has urethral discharge (follow-up question)
This diagnosis is unique as we are also recommending medication for the patient's partner. We are not following up on the dispensing of this medicine but do want to have the instructions on the screen for the health care worker to see.

Pop-Up
Health Education
Medication

Supporting Documents:
You can see the logic for next steps here.
Notes:
Similar to the first ANC encounter, if a patient is receiving health education for multiple things they will stack in one health education sub-activity. If they are being referred to the hospital for multiple things, there is only one referral screen.
To Do:

Style next steps screens per design
Adjust logic per document

updated health education screen to include question:

@jeanette-pelizzon

At medication distribution form, we have separate section for each medication. For example:

Please adjust the design.

I believe Health education header should not be saying 'burning on urination', but something else

@jeanette-pelizzon
But this issue symptom is abnormal vaginal discharge, not burning on urination.

Updated.

https://nutrition-ihangane.pantheonsite.io/
QA Review
Found issues and questions:

Not related to this issue, but I found a typo when clicking around:

So far I have found no way to indicate some diseases, like gonorrhea or candidiasis at first encounter. I need to finish first encounter, come back, and only then will be the symptom review icon available, where I can specify the symptoms. Is there a way to get these diagnoses at first encounter? What are the preconditions to display symptom review? Panel says patient has noted symptoms that require follow up question. I only noted pregnancy.

@jeanette-pelizzon

Grammar is not correct in the Note. Recommend should be recommended. Maybe drop comma at line end.

Shall we drop the comma?

Not related to this issue, but I found a typo when clicking around:

Fixed at another PR

So far I have found no way to indicate some diseases, like gonorrhea or candidiasis at first encounter. I need to finish first encounter, come back, and only then will be the symptom review icon available, where I can specify the symptoms. Is there a way to get these diagnoses at first encounter? What are the preconditions to display symptom review? Panel says patient has noted symptoms that require follow up question. I only noted pregnancy.

Addressed this at another PR. Will need clarifications from @jeanette-pelizzon .

Currently I cannot reproduce it, but when at subsequent encounter I started with filling out the symptom review I ended up with Next steps not displaying. Just as I was about to finish the encounter, I went back and changed the symptoms, and from that time I am getting the next steps icon.

Mandatory activity to complete is Danger signs. Without completing it, no next steps.

The Warning popup about gonorrhea is not as descriptive, as in the issue description.

Changed.

The Warning popup about gonorrhea is not as descriptive, as in the issue description.

Fixed

Ciproflaxcin should be Ciprofloxacin. Fixed it in the google sheet.
Doxycyline should be Doxycycline. Fixed it in the google sheet.

Both fixed

Grammar is not correct in the Note. Recommend should be recommended
Fixed

On the medication panel in the questions the medicine is not blue, and dosage is missing.

This is the standard we display for any medication. The recommendation is blue with dosage.
At question it's gray, and dosage is not mandatory. @jeanette-pelizzon please approve it's ok.

Yes fix comma issue
You are correct on the blue / grey medication rules @anvmn

// @anvmn @balagan73

J I m up g hmm nkkb


WebContainer is in Beta

Describe the bug
Not working!!!
Link to the blitz that caused the error
https://stackblitz.com/edit/angular-ququej?file=src/app/app.component.ts
Steps to reproduce

Expected behavior
Not working
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots

Platform
Browser name  = Chrome
Full version  = 98.0.4758.102
Major version = 98
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.102 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 71123146,
  "usedJSHeapSize": 67416974,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = e1937cc6e2ee7e7a1da198d43493f4063378a564

Additional context
No response

Hey, I just tested your linked project and it works for me with Chrome Version 98.0.4758.102
I encourage you to check the devtools if there is any error displayed.

Hey there! Please provide more information and a clear list of steps to reproduce.

Closing due to inactivity.


chore: add port to connection details

Description of your changes
Fixes https://github.com/crossplane-contrib/provider-upjet-aws/issues/1458
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

/test-examples="examples/opensearch/v1beta1/domain.yaml"

/test-examples="examples/opensearch/v1beta2/domain.yaml"

/test-examples="examples/elasticache/v1beta1/cluster.yaml"

/test-examples="examples/elasticache/v1beta2/cluster.yaml"

/test-examples="examples/elasticache/v1beta1/cluster.yaml"

Thank you for your effort, @aiell0; it would be great if you could update the description to show that you are testing manually and seeing the port value in the secret.

@turkenf I had to change the code to reflect the correct type of port (number vs string) and it worked! Result is below:
lawrenceaiello@Lawrences-MacBook-Pro ~/Development/aiell0/provider-upjet-aws (add-port-to-elasticache-connection-details) $ k get secrets                                                                                <aws:dev>
NAME             TYPE                                DATA   AGE
sample-cluster   connection.crossplane.io/v1alpha1   2      7m14s
lawrenceaiello@Lawrences-MacBook-Pro ~/Development/aiell0/provider-upjet-aws (add-port-to-elasticache-connection-details) $ k describe secrets                                                                                <aws:dev>
Name:         sample-cluster
Namespace:    default
Labels:       <none>
Annotations:  <none>

Type:  connection.crossplane.io/v1alpha1

Data
====
cluster_address:  50 bytes
port:             5 bytes
lawrenceaiello@Lawrences-MacBook-Pro ~/Development/aiell0/provider-upjet-aws (add-port-to-elasticache-connection-details) $ kubectl get secret sample-cluster -o jsonpath="{.data.port}" | base64 --decode
11211

/test-examples="examples/elasticache/v1beta1/cluster.yaml"


Prepare 0.1.0 release

[x] Bump version to 0.1.0
[x] Check deprecation warnings under Qiskit Terra 0.24; see if there are any we can fix.
[x] Fix formatting/links in Nature 0.5 release note
[x] Make a release note mentioning new versions, no longer need qiskit-ibmq-provider, now we support Python 3.11.
[x] Move existing release notes to 0.1 subdirectory once all other PRs are merged

Here's what my local build looks like.  I expect the release to be listed at 0.1.0 once we actually tag it.


Creating New B2C Application Powershell Command

I tried creating new B2C application using the following powershell command:
New-AzureADApplication -DisplayName "$cusprefix-API-B2C-$teamsuffix" -ReplyUrls $replyUrl_API
It did create an application, the only issue being, how do I change the supported account types option to All Users, like I see while creating using GUI:
Accounts in any organizational directory or any identity provider
What is the command to set this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bee63035-00ee-f7fd-97a1-69dae5f808ef
Version Independent ID: a3447928-73cc-0290-6d46-b89234757e3b
Content: Get started with custom policies - Azure AD B2C
Content Source: articles/active-directory-b2c/custom-policy-get-started.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@JasSuri could to check this issue?

@deep-mm We are trying to check this internally and will update the same soon.
Thank you.

@deep-mm We are now proceeding with closure of this thread. Feel free to tag me in your reply if you have any further question.


Turbo Stream refresh does not work when responding to a form submission

I'm using Turbo 8 so I can trigger refreshes.
In one instance I submit a form (POST request) and I want to show a toast and refresh the page.
The page already has a toast container like this

When I submit the form, I see the server returns:
<turbo-stream action="update" target="toast-container"><template>

        Marking 15 payouts ($198.45) as paid.

      <button type="button" class="btn-xs btn-close me-1 m-auto alert-link btn-sm" data-bs-dismiss="toast" aria-label="Close"></button>

</template></turbo-stream>

<turbo-stream request-id="374d19b3-8358-462a-ae9d-0da43c02820b" action="refresh"></turbo-stream>

The toast is correctly shown, but the page is not refreshed.

@jordinl thank you for opening this issue.
Are you rendering the Morphing <meta> element into your page's header?
If the intention is to refresh the page, have you tried reverting the Turbo Stream template rendering in favor of a (assuming that you're using Rails) setting a flash.notice value, then redirecting? Something like:
if @widget.save
  flash.notice = "Marking 15 payouts ($198.45) as paid."
  redirect_to widget_url(@widget)
end

Hey, found this issue when looking for answers to exactly the same problem (also Turbo 8, POST request).
When submitting the form and then responding with the following in turbo_stream template:
turbo_stream.update('venues', partial: 'venues')
turbo_stream.append('turbo-flash', flash_messages)

everything works fine, the element is updated correctly.
However, when using these as a response to the same action:
turbo_stream_refresh_tag # tried also turbo_stream.action(:refresh, '_top')
turbo_stream.append('turbo-flash', flash_messages)

Flash is shown, but page is not refreshed even though the response contains:
<turbo-stream action="refresh"></turbo-stream>
<turbo-stream action="append" target="turbo-flash"><template>...</template></turbo-stream>

I tried adding the meta tag, but it doesn't help (I would prefer the default replace anyway).
I tried using redirect_to as @seanpdoyle suggested, but even though I am getting a correct response, the page is not refreshed - maybe that's a lead? redirect_to would not be a preferable solution in my case, but I would go with that if it had worked.

I know it might be somehow due to a faulty setup on my side, but would like to establish a solution.

@wawer77 could you change the following bug report template to reproduce your issue?

Save this file to `bug_report_template.rb`, then execute with `ruby bug_report_template.rb`
require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  git_source(:github) { |repo| "https://github.com/#{repo}.git" }

  gem "rails"
  gem "propshaft"
  gem "sqlite3"
  gem "turbo-rails"

  gem "capybara"
  gem "cuprite", "~> 0.9", require: "capybara/cuprite"
end

require "active_record/railtie"
# require "active_storage/engine"
require "action_controller/railtie"
require "action_view/railtie"
# require "action_mailer/railtie"
# require "active_job/railtie"
# require "action_cable/engine"
# require "action_mailbox/engine"
# require "action_text/engine"
require "rails/test_unit/railtie"

class App < Rails::Application
  config.load_defaults Rails::VERSION::STRING.to_f

  config.root = __dir__
  config.hosts << "example.org"
  config.eager_load = false
  config.session_store :cookie_store, key: "cookie_store_key"
  config.secret_key_base = "secret_key_base"
  config.consider_all_requests_local = true
  config.turbo.draw_routes = false

  Rails.logger = config.logger = Logger.new($stdout)

  routes.append do
    root to: "application#index"
  end
end

class ApplicationController < ActionController::Base
  include Rails.application.routes.url_helpers

  class_attribute :template, default: DATA.read

  def index
    render inline: template, formats: :html
  end
end

class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
  driven_by :cuprite, using: :chrome, screen_size: [1400, 1400], options: { js_errors: true }
end

Capybara.configure do |config|
  config.server = :webrick
  config.default_normalize_ws = true
end

ENV["DATABASE_URL"] = "sqlite3::memory:"
ENV["RAILS_ENV"] ||= "test"

Rails.application.initialize!

require "rails/test_help"

class TurboSystemTest < ApplicationSystemTestCase
  test "reproduces bug" do
    visit root_path

    assert_text "Loaded with Turbo"
  end
end

__END__

<!DOCTYPE html>

    <%= csrf_meta_tags %>

  Loaded without Turbo

I'm seeing the same behaviour als @wawer77 and @jordinl
It looks like this is the intended behaviour. The refresh action is generated from the same request which caused the change in the first place. Turbo ignores that action on purpose.
See https://github.com/hotwired/turbo/pull/1019#issuecomment-1869655371

@jordinl thank you for opening this issue.
Are you rendering the Morphing <meta> element into your page's header?

@seanpdoyle yes. I have:
    <meta name="turbo-refresh-method" content="morph">
    <meta name="turbo-refresh-scroll" content="preserve">

If the intention is to refresh the page with Morphed content (including the Flash), have you tried replacing the Turbo Stream template rendering with (assuming that you're using Rails) setting a flash.notice value and redirecting? Something like:
if @widget.save
  flash.notice = "Marking 15 payouts ($198.45) as paid."
  redirect_to widget_url(@widget)
end

This is a relatively old app. Up until recently the flash messages were shown as banner right below the navbar. Then I started adding more interactivity with Turbo Streams and it made sense to use a toast (positioned fixed). So we have some endpoints using a banner and others a toast. Which means I can't set the flash and redirect in this situation.

I'm seeing the same behaviour als @wawer77 and @jordinl
It looks like this is the intended behaviour. The refresh action is generated from the same request which caused the change in the first place. Turbo ignores that action on purpose.
See #1019 (comment)

I'll have to read carefully the entire PR, I'm not entirely sure this is the same issue.
So far the way I got it working was to stream the toast update with action cable and then do the redirect:
    Turbo::StreamsChannel.broadcast_render_to([current_user, :payouts],
                                              target: 'toast-container',
                                              partial: 'shared/update_toast',
                                              locals: { flash: flash_details })

    redirect_to merchant_payouts_path(state: @state)

This seems worse than allowing to stream and update and a refresh in the same request.

I was able to get a form submit request to refresh the current page by changing the "request-id" attribute of the turbo-stream tag:
In rails I did this:
render turbo_stream: turbo_stream.refresh(request_id: SecureRandom.uuid.to_s)

This caused the request id to be different from the submitting request ID and tricked turbo into rendering the refresh anyway.
In my case, I had a modal dialog that updated a record and I wanted the index page behind the modal to be refreshed with new content once submitted. The modal dialog uses a turbo frame to show the edit page.

@caleb Indeed that seems to be the case:

But this makes using frames to have an SPA like UI like this, creating in the same page the list is rendered to not refresh and be forced to use stream actions to attach the new action
Show image

Someone reading this knows if the idea going forward is to keep using streams for things like this and the auto refresh it's only meant to reflect updates from other people/browsers, or is there a way I'm missing? 🤔

@caleb I was curious to see what happened when you send no request id and I was able to reproduce as you say -- what's interesting though is that my turbo frames without morph also seemed to re-load via their src.


Consider padding  elements for MOTD

From discussion in slack, the OOD MOTD columns have zero padding, and they look like this:

We want them to look more like this:

We can accomplish padding in CSS by adding some variant of the following block.
td, th {
  padding-left: 8px;
  padding-right: 8px;
  padding-top: 0px;
  padding-bottom: 0px;
}

Issue resolved elsewhere, MOTD partition table looks great now.


Add translation chapter 1 and 5 in spanish

Hi, I add the translation for those two chapters, i hope everything is alright with my PR
Thanks

Hey @dev-nekko  :wave:
Thanks for your contribution  :pray:
Unfortunately, these chapters are already assigned to other contributors. You need to comment on the issue so that the chapters can be assigned to you. Otherwise, your pull request will NOT be accepted.


Remove statefulSetUID parameter from GetWorkloadName.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove statefulSetUID parameter from GetWorkloadName.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
We are not using statefulSetUID parameter in GetWorkloadName() method.
Does this PR introduce a user-facing change?

NONE

/cc @mimowo

Looking at https://github.com/search?q=repo%3Akubernetes-sigs%2Fkueue GetWorkloadNameForOwnerWithGVK&type=code we pass the object UID to the function for other APIs. I think if the StatefulSet is recreated (different UID) we also want to recreate the same group and re-admit.

Yes, but it's empty every time :) Removed to avoid confusing other contributors.

ok, but it is surprising that ss.UID is empty. I would expect every object, also StatefulSet to have an UID. Am I missing something?

ok, but it is surprising that ss.UID is empty. I would expect every object, also StatefulSet to have an UID. Am I missing something?

We can't get the UID in the Default function because it's executed before creation, so we don't have the UUID at that time.

/lgtm


Refactor low node utilization

@seanmalloy @damemi @lixiang233 PTAL

changing the utilization computation from fractions (in percentages) to resources that are left instead
refactoring the code to make it more generic (so it's more reusable when implementing HighNodeUtilization strategy)

I don't see anything wrong with these changes. @lixiang233 please review again when you have some time. Thanks!

/lgtm
@lixiang233 please review one more time when you get a chance. Thanks!

@seanmalloy  this change looks pretty good to me.

/assign @damemi

/kind cleanup

@seanmalloy done PTAL

/lgtm
/assign @damemi

@ingvagabund could you add some more description to the commits/PR on what the goal is with this refactor, for future reference?

Description updated. Lemme know whether it's sufficient.

@damemi please take a look when you have some time. I believe @ingvagabund has addressed all of your review feedback.
/lgtm


Idea exchange on the process for this.

Hi @stoe, I'm building some of the same steps for a customer over here following this process specifically for GitHub Actions.
Maybe we can collab on some ideas around this?
For example: I also want to have Dependabot enabled at the org level of the place we fork the repo to, and then read the security alerts back after the run has competed. Still searching for the API to check if the Dependabot run has completed for example.

Hi @stoe,
Be aware that deleting the current workflows in the fork will fail if there are no workflows! See https://github.com/ActionsDesk/github-action-oss-scanner/blob/083f47c3a5edef4c9f8a71835415161d8cdfb172/src/scanner.js#L123
I've changed the throw to just a log line, since I don't care in that case and just want to inject a new CodeQL workflow anyway :-).

Additionally I've learned that GitHub uses Lignuist to determine the languages inside the repos.
I've used it in my workflow to determine the languages needed to run CodeQL with:
https://github.com/rajbos/github-actions-requests/blob/3576f90d2c7271326eed8afe5972bf42180f1d36/.github/workflows/issue-labeled-as-security-scan.yml#L96-L122


New Tutorial: Control Thruster Articulation with Gamepad

Our thruster articulation tutorial says we can control thruster angle with a gamepad using usv_joydrive.launch but we do not explain what the controls are. If the user needs to do something to configure these we should say this and, if possible, say how to do it.

Should be addressed with PR#308


Update VinNodes.toml for testnet-15

Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[x] Only one toml is added in this PR
[x] The file being added is indeed a .toml file
[x] The toml being added is to the cqorrect folder, and only to the correct folder
[x] The eth_hot_key and eth_cold_key are present
[x] The email, discord, elements telegram, and twitter fields are present and valid

This validator was not recognised as a previous validator and has update in the title. Please read the description.


[Suggestion] The ability to add a custom image as a background

I believe it would be a good addition to the theme to make the background customizable. I tried replacing the background image link with one of my own, but nothing happened. I really like how the theme looks and I think that this could be a good next step.

You did something wrong then. Use this: https://bdeditor.dev/theme/softx/ if you're not sure on how to edit themes.

Thanks!


Fixes #246: Disable auto showing up the soft keyboard in login activity

Fixes: #246
@kunall17 Now keyboard shows up in the first screen for server URL and don't shows UP for login Activity.

Automated message from Dropbox CLA bot
@saketkumar95, it looks like you've already signed the Dropbox CLA. Thanks!

This doesn't do the things we intend to, we want something in which the keyboard shows at the first screen when it asks for the server URL and after when the backends are fetched and the login controls are shown then the keyboard should be hidden!
Also remove windowSoftInputMode from many other activities!

@kunall17 I will check it again and update the branch.. :)

@kunall17 Done! :)

@kunall17 Done! :)

Add android:windowSoftInputMode="stateVisible" to the LoginActivity
Squash the commits

@kunall17 Closing this PR. As i'm having some problems in squashing the commits in master branch.
Created the new PR #278 here


weight is a float

<?xml-model href="https://wofsauge.github.io/isaac-xml-validator/xsd/sounds.xsd" ?>
<sounds root="sfx/">
  <sound name="ShankerBritish">
    <sample weight="1" path="shanker2.wav" />
    <sample weight="0.3" path="shanker1.wav" />
  </sound>
</sounds>

-->
Content of type 'integer' is expected.

The following content is not a valid type:
 '0.3'

Code:
cvc-attribute.3: The value '0.3' of attribute 'weight' on element 'sample' is not valid with respect to its type, 'unsignedInt'.

i cant reproduce that issue. Does it still occur for you?

looks like its fixed now thanks


Github Issues Page - "Want to contribute?" section.

Most open source repos have a "Want to Contribute" section in their Github issues page.
Example:
https://github.com/rails/rails/issues

https://github.com/atom/atom/issues
https://github.com/twbs/bootstrap/issues
I think it's helpful to have but I can't figure out how to add this to our page.
@johnbent @novium258 @amolkongre  @mukul-seagate11  what do you think about adding this?
Also any idea on how we can add/configure this?
@xahmad Some other Seagate repos like -> https://github.com/Seagate/openSeaChest have it too. Do you know how they configured it?

I think it's based on the presence of a CONTRIBUTING.md for the first line and, traditionally, having a label literally named good first issue for the second. So I do see a partial contributing banner on the issues page:

About a year ago GitHub began using machine learning to augment the list of good first issues, but it's not a replacement for manual labeling.
See https://github.com/Seagate/cortx/contribue for what GitHub has identified as beginner friendly.

https://support.github.com/ticket/personal/0/856384 <- asked Enterprise support about this


auro-lockup: boolean properties need default values

Describe the bug
The standard and oneworld properties do not have a default value.
Expected behavior
The above properties default to false.

:tada: This issue has been resolved in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Implement progressbars for data upload

Coverage decreased (-1.1%) to 75.342% when pulling ef859d572990adb79adf4c41b82ff82cf196688e on Fak3:t31_upload_data into 423e20cca6f47874aceb84603515fb8b762020f7 on frictionlessdata:master.

Coverage decreased (-1.1%) to 75.342% when pulling ef859d572990adb79adf4c41b82ff82cf196688e on Fak3:t31_upload_data into 423e20cca6f47874aceb84603515fb8b762020f7 on frictionlessdata:master.

Coverage decreased (-1.1%) to 75.342% when pulling ef859d572990adb79adf4c41b82ff82cf196688e on Fak3:t31_upload_data into 423e20cca6f47874aceb84603515fb8b762020f7 on frictionlessdata:master.

Coverage decreased (-3.7%) to 72.768% when pulling 2cbb9754b9a06a95942c81215f254d491980b3aa on Fak3:t31_upload_data into 423e20cca6f47874aceb84603515fb8b762020f7 on frictionlessdata:master.


Cannot read property 'style' of undefined

When I import MapView, without even rendering a MapView component, I see the following error in the iOS app:

Cannot read property 'style' of undefined.
<unknown>
MapView.js:63:23

In the Android app I get:

undefined is not an object (evaluating '_reactNative.ViewPropTypes.style')

I am using react-native-maps 0.15.3, react-native 0.43.0 and react 16.0.0-alpha.6.
This error occurs when I simply add this line to my app:
import MapView from 'react-native-maps';
Is this a version problem between React, React Native and react-native-maps with regard to the definition of ViewPropTypes?
EDIT: Looks like it could be breaking change, and here.

+1

+1

+1

+1 but with react-native 0.43.1

+1

+1

+1

I recently made a fresh example build.
https://github.com/alvelig/react-native-maps-example.
Try to check it out or build through the README.MD. If it does not help, let me know.


[Bugfix] Fix NPE when disable materialized view

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #10163
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 4 / 5 (80.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
2
3
66.67%
[3437]

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
2
2
100.00%
[]

run starrocks_admit_test

@Mergifyio backport branch-2.4


Unable to reproduce

I set random_state=666:
LGBMClassifier(boosting_type='gbdt', class_weight=None, colsample_bytree=0.617,
importance_type='split', learning_rate=0.005, max_depth=-1,
metric='auc', min_child_samples=31, min_child_weight=0.01,
min_split_gain=0.884, n_estimators=30000, n_jobs=-1,
num_leaves=16, objective='binary', random_state=666,
reg_alpha=0.631, reg_lambda=0.81, scale_pos_weight=1,
silent=True, subsample=0.788, subsample_for_bin=200000,
subsample_freq=8, verbosity=-1)

sklearn api

could you describe your problem with more details?

@Jie-Yuan Please follow my comment in #2448 and post your feedback there to not split the discussion of the same issue into multiple topics.


undefined method can for custom action

I tried to add new custom action like this:
class UsersController < ApplicationController
def registrant_info
end
end
next, i change config file authority.rb like this:
Authority.configure do |config|
config.controller_action_map.merge!(
:registrant_info => 'registrant'
)
config.abilities.merge!(
:registrant => 'registrantable'
)
end
then, in file user_authorizer i added code like this:
class UserAuthorizer < ApplicationAuthorizer
def self.registrantable_by?(user)
user.has_role?(Role::ROLES[:admin])
end
def registrantable_by?(user)
user.has_role?(Role::ROLES[:admin])
end
end
finally i go to browser: localhost:3000/users/10/registrant_info, I got the error
"undefined method `can_registrant_info?' for nil:NilClass"
Logs console:
NoMethodError (undefined method can_registrant_info?' for nil:NilClass):   /home/vinh-phuc/.rvm/gems/ruby-2.1.1@4.1/bundler/gems/load_and_authorize_resource-a77cce9a1170/lib/load_and_authorize_resource.rb:307:in authorize_resource'
activesupport (4.1.1) lib/active_support/callbacks.rb:424:in block in make_lambda'   activesupport (4.1.1) lib/active_support/callbacks.rb:143:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:143:in block in halting_and_conditional'   activesupport (4.1.1) lib/active_support/callbacks.rb:149:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:149:in block in halting_and_conditional'   activesupport (4.1.1) lib/active_support/callbacks.rb:149:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:149:in block in halting_and_conditional'   activesupport (4.1.1) lib/active_support/callbacks.rb:149:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:149:in block in halting_and_conditional'   activesupport (4.1.1) lib/active_support/callbacks.rb:149:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:149:in block in halting_and_conditional'   activesupport (4.1.1) lib/active_support/callbacks.rb:166:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:166:in block in halting'   activesupport (4.1.1) lib/active_support/callbacks.rb:229:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:229:in block in halting'   activesupport (4.1.1) lib/active_support/callbacks.rb:166:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:166:in block in halting'   activesupport (4.1.1) lib/active_support/callbacks.rb:166:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:166:in block in halting'   activesupport (4.1.1) lib/active_support/callbacks.rb:86:in call'
activesupport (4.1.1) lib/active_support/callbacks.rb:86:in run_callbacks'   actionpack (4.1.1) lib/abstract_controller/callbacks.rb:19:in process_action'
actionpack (4.1.1) lib/action_controller/metal/rescue.rb:29:in process_action'   actionpack (4.1.1) lib/action_controller/metal/instrumentation.rb:31:in block in process_action'
activesupport (4.1.1) lib/active_support/notifications.rb:159:in block in instrument'   activesupport (4.1.1) lib/active_support/notifications/instrumenter.rb:20:in instrument'
activesupport (4.1.1) lib/active_support/notifications.rb:159:in instrument'   actionpack (4.1.1) lib/action_controller/metal/instrumentation.rb:30:in process_action'
actionpack (4.1.1) lib/action_controller/metal/params_wrapper.rb:250:in process_action'   activerecord (4.1.1) lib/active_record/railties/controller_runtime.rb:18:in process_action'
actionpack (4.1.1) lib/abstract_controller/base.rb:136:in process'   actionview (4.1.1) lib/action_view/rendering.rb:30:in process'
actionpack (4.1.1) lib/action_controller/metal.rb:195:in dispatch'   actionpack (4.1.1) lib/action_controller/metal/rack_delegation.rb:13:in dispatch'
actionpack (4.1.1) lib/action_controller/metal.rb:231:in block in action'   actionpack (4.1.1) lib/action_dispatch/routing/route_set.rb:80:in call'
actionpack (4.1.1) lib/action_dispatch/routing/route_set.rb:80:in dispatch'   actionpack (4.1.1) lib/action_dispatch/routing/route_set.rb:48:in call'
actionpack (4.1.1) lib/action_dispatch/journey/router.rb:71:in block in call'   actionpack (4.1.1) lib/action_dispatch/journey/router.rb:59:in each'
actionpack (4.1.1) lib/action_dispatch/journey/router.rb:59:in call'   actionpack (4.1.1) lib/action_dispatch/routing/route_set.rb:676:in call'
warden (1.2.3) lib/warden/manager.rb:35:in block in call'   warden (1.2.3) lib/warden/manager.rb:34:in catch'
warden (1.2.3) lib/warden/manager.rb:34:in call'   rack (1.5.2) lib/rack/etag.rb:23:in call'
rack (1.5.2) lib/rack/conditionalget.rb:25:in call'   rack (1.5.2) lib/rack/head.rb:11:in call'
actionpack (4.1.1) lib/action_dispatch/middleware/params_parser.rb:27:in call'   actionpack (4.1.1) lib/action_dispatch/middleware/flash.rb:254:in call'
rack (1.5.2) lib/rack/session/abstract/id.rb:225:in context'   rack (1.5.2) lib/rack/session/abstract/id.rb:220:in call'
actionpack (4.1.1) lib/action_dispatch/middleware/cookies.rb:560:in call'   activerecord (4.1.1) lib/active_record/query_cache.rb:36:in call'
activerecord (4.1.1) lib/active_record/connection_adapters/abstract/connection_pool.rb:621:in call'   activerecord (4.1.1) lib/active_record/migration.rb:380:in call'
actionpack (4.1.1) lib/action_dispatch/middleware/callbacks.rb:29:in block in call'   activesupport (4.1.1) lib/active_support/callbacks.rb:82:in run_callbacks'
actionpack (4.1.1) lib/action_dispatch/middleware/callbacks.rb:27:in call'   actionpack (4.1.1) lib/action_dispatch/middleware/reloader.rb:73:in call'
actionpack (4.1.1) lib/action_dispatch/middleware/remote_ip.rb:76:in call'   actionpack (4.1.1) lib/action_dispatch/middleware/debug_exceptions.rb:17:in call'
actionpack (4.1.1) lib/action_dispatch/middleware/show_exceptions.rb:30:in call'   railties (4.1.1) lib/rails/rack/logger.rb:38:in call_app'
railties (4.1.1) lib/rails/rack/logger.rb:20:in block in call'   activesupport (4.1.1) lib/active_support/tagged_logging.rb:68:in block in tagged'
activesupport (4.1.1) lib/active_support/tagged_logging.rb:26:in tagged'   activesupport (4.1.1) lib/active_support/tagged_logging.rb:68:in tagged'
railties (4.1.1) lib/rails/rack/logger.rb:20:in call'   actionpack (4.1.1) lib/action_dispatch/middleware/request_id.rb:21:in call'
request_store (1.0.6) lib/request_store/middleware.rb:8:in call'   rack (1.5.2) lib/rack/methodoverride.rb:21:in call'
rack (1.5.2) lib/rack/runtime.rb:17:in call'   activesupport (4.1.1) lib/active_support/cache/strategy/local_cache_middleware.rb:26:in call'
rack (1.5.2) lib/rack/lock.rb:17:in call'   actionpack (4.1.1) lib/action_dispatch/middleware/static.rb:64:in call'
rack (1.5.2) lib/rack/sendfile.rb:112:in call'   railties (4.1.1) lib/rails/engine.rb:514:in call'
railties (4.1.1) lib/rails/application.rb:144:in call'   rack (1.5.2) lib/rack/lock.rb:17:in call'
rack (1.5.2) lib/rack/content_length.rb:14:in call'   rack (1.5.2) lib/rack/handler/webrick.rb:60:in service'

The error undefined method 'can_registrant_info?' for nil:NilClass suggests Authority can't find an actual user object to use in your controller. By default, it calls the current_user method in your controller, and then calls can_? methods on that.
Whatever your current_user implementation is, it's returning nil, which in turn is causing some grief during the authorization step.
If you have some other than method than current_user to get a user object, you can change what method Authority uses:
Authority.configure do |config|
  config.user_method = :my_controller_current_user_method
end

If current_user is returning nil because there isn't one–nobody's logged in–you have a few options. I recommend using the null object pattern in your current_user method rather than returning a raw nil. Depending on your application, something like this may work:
class NilUser
  def method_missing?(method_name, *args)
    nil
  end
end

Any method you send to an instance of this class will return falsey, including Authority methods. If current_user returns one of these instead for unauthenticated sessions, all authorization will fail for non-logged-in-users.
Another option is to avoid authorization entirely for all unauthenticated sessions by setting up a controller filter to redirect to a login page in all controllers that only logged in users ought to be able to see.

@christhekeele just dropping by - :clap: :smile:


Added importing, tests and setups(copy)

Added:
Import Events/Products BQ Table + test
Import Events/Product Gcs Bucket + tests
Import Events/Products inline source + test
setup files for Creating and Removing BQ tables and Gcs Buckets
resources: table schema and table data

This is an exact copy of #1702 so I don't think we need it. Any reason why this PR has been opened?

Can be closed because it will be split in 2 other PRs.


Support watchOS, tvOS, macOS, ipadOS

The SDK might support some of these OSes out of the box already. Not sure because it's never been tested.

[ ] Update Package.swift to update platforms we support
[ ] Test on these platforms
[ ] Way to run tests against the different test devices on CI?
[ ] Update README with what we support.

I was personally curious about this and checked - the push notifications are shown on watch as well. Watch does allow having specific watch apps but testing that would require having one for RemoteHabits as well:


Opensearch Ingestion Service Implementation

OSIS implementation and testing
Fixed type hint for create_vpc_endpoint()

This is my first time implementing a full service so any and all feedback is welcome especially where it relates to the extent of the functionality to mimic.  Currently I'm validating that SGs and Subnets exist but nothing else (e.g. opensearch pipeline sink existence, valid pipeline source for using buffer_options, etc.).  I'm also creating VPC endpoints when the VpcOptions.VpcEndpointManagement field is set to Service to mirror what AWS does.  Let me know if I should forgo that in favor of just sending back a fake vpce id.  I am not creating Cloudwatch logs groups if they don't exist although AWS will.

@bblommers For the life of me I can't figure out how to get the arn out of the Tagging APIs based on the botocore service model.  If you could take a look that would be very much appreciated

Hi @mattheidelbaugh, thank you for the PR!
I've pushed a fix for the failing tagging tests. There were two issues:

The ARN was part of the querystring, so the full URL was /tags/..?arn=arn:aws:.... I've updated responses.py to just use self._get_param, as that (also) pulls parameters from the querystring
The tags were set as part of the model and in the TaggingService, but when calling the tag_resource-method, only the TaggingService was updated. That means that the tags that are part of the Pipeline-model are very quickly outdated.
I've refactored this so that the TaggingService is the source of truth, and the Pipeline-model refers to the TaggingService if it wants to return the list of it's tags.

I've also refactored the ec2 imports a bit. It's big service that does a lot of things in the background, so importing it takes a lot of time. Having localized imports ensures that we only suffer that cost when necesssary.
And finally the State Transitions. First of all: Really cool to see this part of the implementation! The tests are an excellent way of showing why this is so useful, giving users the chance to test the proper behaviour in all stages of the Pipeline lifecycle.
These tests did fail in ServerMode, because the statemanager.set_transition command only works when using the decorator. I've refactored this to call the /moto-api/state-manager/set-transition-endpoint instead in ServerMode.

especially where it relates to the extent of the functionality to mimic.

In an ideal world we mimic the full functionality of course, but realistically there are limits to what we can do.
Validating that the subnets/security groups are present and correct is a great start IMO, and also nice to automatically create a VPC endpoint.
If/when someone needs the Cloudwatch LogGroup to exist, or wants even more validation, we can always implement that later.


WIP: Completed JIRA OWLS-72972 and OWLS-73203

OWLS-72972 - move stop and restart Operator using replicas to Domain.java
OWLS-73203 -  remove dulplicate test cases from server-discovery-tests branch

kicked off a Jenkins run Friday, yesterday. Still don't see the results yet. Just kicked off another one, #1395

local run passed:
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 753.867 s - in oracle.kubernetes.operator.ITServerDiscovery
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
....
[INFO] Reactor Summary:
[INFO]
[INFO] Build Tools 1.0 .................................... SUCCESS [  2.867 s]
[INFO] weblogic-kubernetes-operator 2.2 ................... SUCCESS [  6.864 s]
[INFO] json-schema 2.2 .................................... SUCCESS [ 12.630 s]
[INFO] jsonschema-maven-plugin Maven Mojo 2.2 ............. SUCCESS [ 10.604 s]
[INFO] operator-model 2.2 ................................. SUCCESS [ 20.592 s]
[INFO] operator-swagger 2.2 ............................... SUCCESS [  5.366 s]
[INFO] operator-runtime 2.2 ............................... SUCCESS [ 56.563 s]
[INFO] operator-integration-tests 2.2 ..................... SUCCESS [13:54 min]
[INFO] installation-tests 2.2 ............................. SUCCESS [  5.885 s]
[INFO] Project Reports 2.2 ................................ SUCCESS [  0.743 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15:57 min
[INFO] Finished at: 2019-04-10T11:49:40-07:00
[INFO] ------------------------------------------------------------------------

Jenkins run kicked off

local run passed:
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 729.91 s - in oracle.kubernetes.operator.ITServerDiscovery
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
....
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Build Tools 1.0 .................................... SUCCESS [  2.943 s]
[INFO] weblogic-kubernetes-operator 2.2 ................... SUCCESS [  6.654 s]
[INFO] json-schema 2.2 .................................... SUCCESS [ 12.029 s]
[INFO] jsonschema-maven-plugin Maven Mojo 2.2 ............. SUCCESS [ 11.166 s]
[INFO] operator-model 2.2 ................................. SUCCESS [ 20.077 s]
[INFO] operator-swagger 2.2 ............................... SUCCESS [  5.500 s]
[INFO] operator-runtime 2.2 ............................... SUCCESS [ 59.774 s]
[INFO] operator-integration-tests 2.2 ..................... SUCCESS [12:56 min]
[INFO] installation-tests 2.2 ............................. SUCCESS [  3.656 s]
[INFO] Project Reports 2.2 ................................ SUCCESS [  0.558 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  14:59 min
[INFO] Finished at: 2019-04-10T12:54:09-07:00
[INFO] ------------------------------------------------------------------------

We only need two tests, existing tests seem repetitive use cases. Please modify the tests to have only the two tests I mentioned above.

Which two you'd like to keep? I don't really feel those are duplicates, they might look similar but they actually test diff things. However, it's up to you, if you have the opposite opinion, just let me know which two you'd like to keep

What Vanaja is referring here is to merge the use cases into 2 usecases

Stop Operator.  Modify (Up/Down) the repilca counts
Start the Operator and make sure New  Server Pod Count matches with updated repilca count

Stop the Operator.  Stop all servers ( including admin and managed server )
No need to create separate tests  for Admin  Server and Managed Server
Start the operator and make sure all the servers in the domain comes up.

oh. got it. Will do

We may wanted to keep one more test case - stop and restart operator but leave all wls servers(admin/ms) intact and running, Verify that Operator will reconnect to these running servers. What do you guys think?

We may wanted to keep one more test case - stop and restart operator but leave all wls servers(admin/ms) intact and running, Verify that Operator will reconnect to these running servers. What do you guys think?

This is already covered, quick test covers this use case.

oh. ok. Will remove that test then

Vanaja and Pani, Can you guys take a another look, comments or approve accordingly? That way, I can complete the task and no need to mention them in Today's planning meeting. Thanks
I kicked off Jenkins run yesterday. Not sure where is the result. Will search

Jenkins run passed:
http://wls-jenkins.us.oracle.com/job/weblogic-kubernetes-operator-javatest/1500/consoleFull
04-11-2019 17:42:54 INFO   oracle.kubernetes.operator.ITServerDiscovery staticUnPrepare SUCCESS
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 594.539 s - in oracle.kubernetes.operator.ITServerDiscovery
...
[INFO] Reactor Summary:
[INFO]
[INFO] Build Tools 1.0 .................................... SUCCESS [  2.463 s]
[INFO] weblogic-kubernetes-operator 2.2 ................... SUCCESS [  3.142 s]
[INFO] json-schema 2.2 .................................... SUCCESS [ 16.151 s]
[INFO] jsonschema-maven-plugin Maven Mojo 2.2 ............. SUCCESS [ 10.198 s]
[INFO] operator-model 2.2 ................................. SUCCESS [ 24.112 s]
[INFO] operator-swagger 2.2 ............................... SUCCESS [  5.499 s]
[INFO] operator-runtime 2.2 ............................... SUCCESS [01:03 min]
[INFO] operator-integration-tests 2.2 ..................... SUCCESS [  02:20 h]
[INFO] installation-tests 2.2 ............................. SUCCESS [  4.338 s]
[INFO] Project Reports 2.2 ................................ SUCCESS [  2.144 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

@hzhao-github copy README.md from develop branch and push it to your branch.

Every time before I make changes to server-discovery-tests branch , I always do "git pull origin develop" first. And did again, it says:
bash-4.2$ git pull origin develop
From https://github.com/oracle/weblogic-kubernetes-operator

branch            develop    -> FETCH_HEAD
Already up-to-date.

I am confused why I should ouul README.txt from develop branch? my changes in server-discovery-tests is on the top of latest develop branch. It makes sense to me that in develop branch, you don't see my changes in server-discovery-tests  branch because we haven't merge these changes to develop branch yet

There should not be README.md file in your PR, those changes are not required and not correct. You have already pushed modified README.md into your branch, that's why its appearing in your PR. Can you remove those changes. Ping me on slack if you need help.

Post latest Jenkins results here.

Jenkins job kicked off #1517

http://wls-jenkins.us.oracle.com/job/weblogic-kubernetes-operator-javatest/1517/consoleFull
04-15-2019 13:01:42 INFO   oracle.kubernetes.operator.ITServerDiscovery staticUnPrepare SUCCESS
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 592.346 s - in oracle.kubernetes.operator.ITServerDiscovery
...
[INFO] Reactor Summary:
[INFO]
[INFO] Build Tools 1.0 .................................... SUCCESS [  2.495 s]
[INFO] weblogic-kubernetes-operator 2.2 ................... SUCCESS [  7.815 s]
[INFO] json-schema 2.2 .................................... SUCCESS [ 17.327 s]
[INFO] jsonschema-maven-plugin Maven Mojo 2.2 ............. SUCCESS [ 11.393 s]
[INFO] operator-model 2.2 ................................. SUCCESS [ 25.365 s]
[INFO] operator-swagger 2.2 ............................... SUCCESS [  5.552 s]
[INFO] operator-runtime 2.2 ............................... SUCCESS [01:01 min]
[INFO] operator-integration-tests 2.2 ..................... SUCCESS [  02:20 h]
[INFO] installation-tests 2.2 ............................. SUCCESS [  6.329 s]
[INFO] Project Reports 2.2 ................................ SUCCESS [  3.963 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:22 h
[INFO] Finished at: 2019-04-15T14:01:06-07:00


some of the checks should be skipped for Arista_7280 which is Not a m…

…odular system
Some of the checks in this test is mainly for the modular & chassis styled systems, so they should be skipped in the DUT model like Arista DCS-7280CR3K-32D4
These checks include:
"Fabric"
"Linecard"
"Supervisor"
For Arista DCS-7280CR3K-32D4, They are not in the returned telemetry states.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.88%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1236

Relevant Lines:
2173

💛  - Coveralls

I don't think we should use deviation for this purpose. Instead I would gate it by dut.Model() == "model".
Deviations are signals that sooner or later there would be fix needed. here is nothing to fix. Component just do not exist and nevwer will be existing.

actually that is exactly what the commit #1 - the initial commit about which conditioned on the dut.Model();
then I thought the popular deviation way maybe preferable by the reviewers in the community as it used does....
so I pushed in the commit #2 which is the current deviation one.
yes, I can just rollback to the original commit #1 if it satisfy the most!
thank for review & comment!

all reviewers, would you please update & continue the review - give your weight on which option you may still prefer after we have chatting talked the alternatives like the args....thanks!


Notation conversion, get_num_pieces function, and misc.

Note - since this PR is quite big, please merge the other PRs into master first. I'll then resolve any conflicts for this PR.
Closes #110
This PR allows the user to convert "human-style" notation into the notation format that Stockfish uses.
Thanks to @FalcoGer for providing the code for this feature in issue 110. I've refined it a bit and added some tests, but most of the credit should go to them.
Besides this, the PR also:

Doesn't send the "ucinewgame" command to the Stockfish engine, when setting a new position. I noticed that doing this frequently can end up being a large bottleneck (as Stockfish has to reset its transposition table each time). Instead, I've made a separate function which the user can call to send this command, if they want to.
Updates the readme to explain the get_top_moves and make_moves_from_current_position functions, as well as the Stockfish.Piece enum a bit.
Adds a function that lets the user find the number of pieces. If desired, the user can specify to only count the number of pieces in a certain range of file(s) and/or row(s). They also have the option of only counting certain pieces.
Modifies the _is_fen_syntax_valid function. Some changes include fixing a bug with splitting up the fields (use fen.split() instead of regexMatch.groups()), and adding checks for more types of invalid FENs (such as the halfmove clock field being >= 2x greater than the fullmove counter).

There are a few things I noticed.
In models.py line 897 there is the condition check
if (
                    isCapture
                    and turnsInto != ""
                    and self.get_what_is_on_square(dst) is None
                ) or (
                    isCapture
                    and turnsInto == ""
                    and self.will_move_be_a_capture(move)
                    == Stockfish.Capture.NO_CAPTURE
                ):

This was put like that because there was the bug () in self.will_move_be_a_capture(move) when move was 5 characters long (due to being a pawn turning into something else). Since that is fixed this part may be simplified now.
Also line 738 is a return "Empty Move", did you mean to raise a value error instead?
Also "+" and "#" at the end of the move string indicates a check/checkmate. I glossed over that in my implementation and just ignored it because I was just messing around, you may want to test if that's actually true.

I hope I didn't make too much of a mess. I'm not used to github's review system.

Maybe you should merge this in or work on a different branch if you want to work on unrelated features. Not quite sure how PRs work, but I get notifications now for unrelated features to this, and the PR is still open.

@FalcoGer Agreed, but unfortunately I don't have write access for merging PRs. Only zhelyabuzhsky can merge, and I think he's been away for a few months. But yeah if I decide to work on a new feature before the merge I'll use a separate branch.

@johndoknjas Ilya willn't return to this project. Unfortunately Ilya died in july.

@2union I'm very sorry to hear that, this is sad news. Thank you for letting us know though, we will try to continue the project. He started something that's become quite popular and useful for many people.

@2union I'm very sorry to hear that, this is sad news. Thank you for letting us know though, we will try to continue the project. He started something that's become quite popular and useful for many people.

Maybe it's time for a fork?

Maybe it's time for a fork?

Yes, it definitely is. @johndoknjas and I already set up a new repo and intend to continue the development there. We haven't announced that yet since we're still in the middle of planning and getting more permissions for the PyPi package, but we plan to make the fork the main development point and move all PRs (and issues) that are still open here over there (Preferably not all at once so there is no chaos).