fixing collision when invoking wrap on multiple cache instances with …

…same key simultaneously (#742)
Please check if the PR fulfills these requirements

[x] Followed the Contributing guidelines.
[x] Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix for issue #742; when invoking cache.wrap() simultaneously with the same key on two different instances, the result from the first method is returned for both invocations

@kentandersen - I haven't had time to look into this but wanted to make sure that we are not affecting the key itself being stored such as in redis. Is this only for the coalescAsync key id?

The only keys affected by this change is the ones supplied to coalescAsync. I even named the prefix variable coalescePrefix to make it clear that it should never be used with any other key


Numerous minor fixes

Numerous small edits to make the code more playable before starting work on larger changes.

Thanks!


add my name in preface/index.md

I try to create a new brach and to create a new PR with one file.

Job d2l-zh/PR-721/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-721/

Fabulous! Thanks!

:-)


Set up a moderator-friendly system for accepting new account requests

ASL SB expects registrations from many users (100-1000); handling all of these requests manually in Django will be inefficient. We need a way to monitor new registrations, and simple buttons for accepting/rejecting them and assigning a group (default group: Guest).
(Didn't FinSL SB already have an administrator menu with features like these?)

Actually we don't have yet. I think that we will rely on django admin, but
either send email to admins or/and have a page that lists newly registered
users.
We are interested in hearing your ideas concerning this.
14.7.2017 0.06 "ocrasborn"<EMAIL_ADDRESS>kirjoitti:

ASL SB expects registrations from many users (100-1000); handling all of
these requests manually in Django will be inefficient. We need a way to
monitor new registrations, and simple buttons for accepting/rejecting them
and assigning a group (default group: Guest).
(Didn't FinSL SB already have an administrator menu with features like
these?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Signbank/NGT-signbank/issues/355, or mute the thread
https://github.com/notifications/unsubscribe-auth/ANkkYv0eYm3K0UVuodWeOakgWmJw8y2Aks5sNobogaJpZM4OXi4h
.

Workflow:

Prospective user clicks on 'registration' somewhere
User goes to page where personal details can be filled in
User checks "Accept terms of use" and clicks submit
New account is created, but waits for consent from the system manager
System manager goes to a page where a list of new request appears, with buttons 'accept' and 'reject'; reject removes the user, accept makes the user 'active'
User receives an email saying account is active, with a link to the Conditions of Use page

To discuss: how/where to specify who the user manager is for the system, who can have access to the 'new registrations' page and who receives an email notification at interval X about pending account requests.

step (3).
Where can I find the Terms / Conditions of Use that need to be approved by new users?
Is this stored in the database? It would be easiest if this could be retrieved for display.

@ocrasborn , at the moment Signbank does not seem to send any (automated) emails. Is this correct?

In the original (unused code), there are some registration routines that are intended to send the new user an activation code by email.
Under the new registration, this will be done by the admin on a new page (#460).
To avoid the need to send emails, I've made the registration request display the data the user has entered to confirm the request has been received.
Here are some screenshots.

From the screenshots, the Conditions for Use need to appear for the user to accept.

For the requested datasets, these need to somehow be communicated to the Dataset Manager.
The new user is created as an "inactive" user, in the same table as all the users. (as for original Signbank)
The new user is put in Group Guest. (as for original Signbank)
Where would you like the store the Requested datasets?
There is a database table registration_registrationprofile where activation keys are stored.
That would seem the most logical place to store requested datasets.
They could perhaps be fed to the Dataset Manager page? So the manager can grant and revoke permissions, as well as process requests?

Hi @susanodd , some responses:

The only place the system now sends emails is upon resetting a password, I think. We might want to double-check that that is working properly.
'Guest' sounds good to me as default, but perhaps we can make new users 'active' without any action on our part. When a Nijmegen SB-manager disapproves, users can be deactivated; and activation is meaningless anyway until the dataset manager for each of the datasets requested has granted access.
We still need to write up the Terms & Conditions; we can adopt in part what has been created for FinSL Signbank.
I'm not sure where to store the requested datasets; better discuss this with @vanlummelhuizen and @Woseseltops .

@vanlummelhuizen helped me get the send_mail working for registration. (The mail server had not been set.)

Regarding the From address in the new user email, can this be you, @ocrasborn ? Or does Signbank have its own email address?

In the emails, it uses the SITE_ID from the settings and looks up the domain and site name in the django_site table. In settings, it had been set to 1, which is example.com. Now it's that of Signbank. But the name of the site is still NGT Signbank.
@ocrasborn , @Woseseltops , or @vanlummelhuizen can somebody update this on the live database?

I pushed the most recent registration code to github.

Registration is not available on the "login" page.

The user can enter the requested datasets as shown in the screenshots above.
Once the user has submitted, the system sends emails to the owners of each dataset (provided they are also in group Dataset_Manager).

There is an activation step for the user. The user receives an email to their submitted email address to activate their account. This doubles to make sure that the email address is valid.

For resetting passwords, if an email has multiple usernames, the user will receive a resetting link for each username. The username is shown in the respective emails.

@susanodd and @Woseseltops , I just tested it for Global/NGT, and it works OK (some ideas for minor improvements to follow). For ASL, however, there is no menu dataset manager as datasets are not active there, right? If we'd follow the same procedure there, it may be a bit confusing to users: they've been granted access after confirming their account request with the link in the email, but they cannot do anything yet. Requesting access to a specific dataset in the registration process is also a bit odd there, it should always be the one and only existing dataset. We could fill that in by default (or do so and hide the field from the form), but that still leads to the strange user experience of 'I can log in, but I have not been granted access'. What shall we do about this?
One idea: we can keep accounts inactive until they have been granted view permission for at least one dataset, and send them an email confirmation as soon as that has been done ("Your account is active and you have access to dataset X.")
And shouldn't users be notified of every dataset manager approval, in case they've asked permission for two or more?

I made the is_public field visible for edit on the Dataset Detail View.
I was going to use that field to limit the set of datasets a new user can request.
But at the moment, none of the datasets have is_public set to true.
Do you want the Default Dataset used if there are no public datasets?
(The Default dataset, NGT, is not public.)

Hi @susanodd , please set it to true for NGT and for NGT non-signs.
For the other datasets, the dataset managers can "overrule" this, right? In the sense that they can still add permissions for users, even though the users cannot (yet) request access to that particular dataset.

Yes, that's true. The managers can grant and revoke.
Does there need to be a Request access button anywhere for the datasets, maybe in the list view?

Yes that would be a good idea at some point. Let's wait a while before we do that, though, until more datasets are actually public.

I think this is good for now. I will add a new issue for @susanodd 's last suggestion. -->


chore: bdd-spring-1588299927 to 0.0.1

chore: Promote bdd-spring-1588299927 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Is there any way to stop WinToast from printing to the console?

Every notification prints an XML object to the console, is there anyway to stop it from doing that?

According to this code found in wintoastlib.cpp, just define NDEBUG to stop WinToast from writing to console.
#ifdef NDEBUG
    #define DEBUG_MSG(str) do { } while ( false )
#else
    #define DEBUG_MSG(str) do { std::wcout << str << std::endl; } while( false )
#endif


Add IST to timezone feature (branch #83)

Config file src/config.ts
Add abbreviation that people will type and the momentjs full timezone

I'll work on this

Cool 👍 . Any questions let me know


Vulkan: Disable debug draw modes that do not make sense depending on the current scene configuration or project settings

Godot version
4.0 alpha 1
System information
Linux Manjaro, Vulkan, Intel Kaby Lake
Issue description
There's a laundry list of special display modes on Vulkan, which is awesome <3
But I haven't been able to figure out how some of these work (e.g. directional shadows, occlusion buffer don't seem to display anything for me), and I'm fairly sure some of these don't make sense without a related property/node being in the scene you're looking at:

all of the SDFGI modes
all VoxelGI modes
lightmapGI mode
directional shadow splits if no directional light in scene
fairly sure some more...

Please hide/make them unclickable when not relevant.
Also it would be nice to have a mode to show you which meshes are configured for GI at all, to avoid running into freezes/1fps if you happen to have GI with NO meshes set...
Steps to reproduce
Load up the editor, play around with the new options.
Minimal reproduction project
N/A

directional shadows

This mode is currently broken: https://github.com/godotengine/godot/issues/46129

occlusion buffer don't seem to display anything for me

This mode only works if occlusion culling is enabled in the project settings and you have an Occluder node present in your scene.

Fixing the bug would be nice, but it would also help people NOT click bake only to realize they forgot to set up the meshes they wanted to use with GI :P


stringx.Replace was broken

stringx.Replace was broken since commit f1102fb2.
the example code from https://github.com/zeromicro/zero-doc/blob/main/go-zero.dev/cn/keywords.md
replacer := stringx.NewReplacer(map[string]string{
  "日本":    "法国",
  "日本的首都": "东京",
  "东京":    "日本的首都",
})
fmt.Println(replacer.Replace("日本的首都是东京"))

expected: 东京是日本的首都
actual: 法国的首都是日本的首都

I think the result is correct. We need to update the doc.
The logic is that, after replacement, if there are still words afterwards, we need to go back to the start of the replaced segment.

The docs was updated.
https://github.com/zeromicro/zero-doc/commit/92dc94b982978d71505df2a9c2a2d0b9e6b8e662


fix: force update of tough-cookie

tough-cookie has a security vulnerability which aint is exposed to through transitive use via jest. This PR forces the update of the package to address the security issue

Looks like this has also fixed itself due to other dependency work


Docs: OverflowMenu 'data' prop type is instead 'items'

In the documentation for the usage and API of the OverflowComponent, the data prop seems to be incorrect/legacy at the moment, instead its currently named items.  A working usage sample is:

render () {
    let { menuVisible, selectedMenuIndex } = this.state
    let items = [{
        title: 'Item 1'
    }]
    return (
        <View style={{flex: 1, justifyContent: 'center', alignItems: 'center'}}>
            <OverflowMenu
            onSelect={this.onSelect}
            visible={menuVisible}
            selectedIndex={selectedMenuIndex}
            onSelect={this.onSelect}
            items={items}
            />
        </View>
    )
}

Sorry it's not typescript

Hi @Kejoku! Thanks, will be fixed.

By the way, the right property is "data". So everything is correct in the documentation

I guess @Kejoku is using version 4.1, that exports items
Try updating to the beta version :)
npm i react-native-ui-kitten@beta @eva-design/eva@beta

@artyorsh thanks for that, you're completely right. I didn't realize I'd locked the version to 4.1.0 😄


support nflog

When will nflog be supported?

You can use nflog already as source for gopacket.
package main

import (
	"context"
	"fmt"
	"time"

	"github.com/florianl/go-nflog"
	"github.com/google/gopacket"
	"github.com/google/gopacket/layers"
)

func main() {
	// Send outgoing pings to nflog group 100
	// # sudo iptables -I OUTPUT -p icmp -j NFLOG --nflog-group 100

	//Set configuration parameters
	config := nflog.Config{
		Group:       100,
		Copymode:    nflog.CopyPacket,
		ReadTimeout: 10 * time.Millisecond,
	}

	nf, err := nflog.Open(&config)
	if err != nil {
		fmt.Println("could not open nflog socket:", err)
		return
	}
	defer nf.Close()

	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
	defer cancel()

	fn := func(attrs nflog.Attribute) int {
		// Decode the packet from NFLOG with gopacket
		packet := gopacket.NewPacket(*attrs.Payload, layers.LayerTypeIPv4, gopacket.Default)
		if icmpLayer := packet.Layer(layers.LayerTypeICMPv4); icmpLayer != nil {
			ipLayer := packet.Layer(layers.LayerTypeIPv4)
			ip, _ := ipLayer.(*layers.IPv4)
			icmp, _ := icmpLayer.(*layers.ICMPv4)
			fmt.Printf("%d\t%s > %s\n", icmp.Seq, ip.SrcIP, ip.DstIP)
		}
		return 0
	}

	// Register your function to listen on nflog group 100
	err = nf.Register(ctx, fn)
	if err != nil {
		fmt.Println(err)
		return
	}

	// Block till the context expires
	<-ctx.Done()
}

But it won't help decode pcaps with DLT_NFLOG, obtained e.g. with tcpdump -i nflog:1


adds docs for modals and bottomsheets

Thanks so much @mayerlench! These docs should answer a few questions that have kept coming up in RNS! 💙


el rap de fernanfloo

Song Name
el rap de fernanfloo
Artist Name
bambielR4
Source
Youtube
Youtube Link
uHjW3zxbyf4
Direct File Link
No response
Song ID
621134
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 12057578
Downloaded: Yes

accept


Si

VSCode Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No
Yes

/duplicate

/duplicate


Polyglot VSCode thinks F# notebooks generated by FSharp.Formatting are C# notebooks

Describe the bug

This is probably the same issue as #2289, and it breaks all documentation notebooks previously created by F# Formatting.
For new F# notebooks, I can do a PR to update the F# Formatting library to generate F# notebooks with the metadata that the Polyglot notebooks extension wants. What metadata should we add?

Details follow:
The F# Formatting Library generates .NET interactive notebooks. The VSCode extension previously recognized the code cells as F#, but now the polyglot extension converts them to C#. As far as I can tell it's necessary to manually go through every cell and change it to F# (not practical). This breaks all documentation notebooks previously created by F# Formatting.
For example, the extension now thinks the F# code in this notebook from the F# Data Library is C# code:

Regarding metadata ... A simple notebook generated by the F# formatting tool looks like this below in json and is what used to work with the old VSCode extension.
        {
            "cells": [
          {
           "cell_type": "code",
           "metadata": {},
            "execution_count": 1, "outputs": [],
           "source": ["let x = 100\n"]
          }
,
          {
           "cell_type": "code",
           "metadata": {},
            "execution_count": 2, "outputs": [],
           "source": ["let y = 100\n"]
          }],
            "metadata": {
            "kernelspec": {"display_name": ".NET (F#)", "language": "F#", "name": ".net-fsharp"},
            "langauge_info": {
        "file_extension": ".fs",
        "mimetype": "text/x-fsharp",
        "name": "C#",
        "pygments_lexer": "fsharp",
        "version": "4.5"
        }
        },
            "nbformat": 4,
            "nbformat_minor": 1
        }

From experimentation, it looks like if we change "metadata": {} in code cells to what I have here then the cells are recognized as being F# code. Is this correct, is there anything else that you suggest?
 "metadata": {
    "dotnet_interactive": {
     "language": "fsharp"
    },
    "polyglot_notebook": {
     "kernelName": "fsharp"
    }
   }

Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):
.NET Interactive
Version: 1.0.360602+9bf026dabac44a6256a65168fa93dcb7e2edcca4
Library version: 1.0.0-beta.22606.2+9bf026dabac44a6256a65168fa93dcb7e2edcca4
Build date: 2023-01-31T11:33:36.0115292Z
Screenshots
If applicable, add screenshots to help explain your problem.

@nhirschey adding the polyglot_notebook metadata is the "correct" way to enable this, and the dotnet_interactive key is a fallback for back-compat.
This situation, however, is interesting and something that should probably work.  The fix on our end will likely be to use the notebook's kernelspec language if the cell metadata isn't present.

@brettfo, thank you for making this fix so quickly! That's a real help to the F# community. Additionally, I will update the FSharp.Formatting tool so that it adds polyglot_notebook metadata to code cells in notebooks going forward.
@jonsequitur thank you, I was not aware. I'll keep that in mind. One of the F# formatting library's todo's is to allow generating documentation from a notebook, and your notebook parser could help with that.
Thanks!

@nhirschey we published a new extension to our insiders channel, can you give it a shot to see if it fixes this issue?  You'll need to install VS Code - Insiders and then install the extension like normal, it should automatically pick up the correct version, which should be 1.0.4108061.

@brettfo yes I checked docs from a few repos and it's fixed in the insiders version of VS Code. Thank you!


Change the bomb emoji to a water baloon

It needs to happen. The gun is now a water gun, what about the bomb!?

And maybe fire (because you can "burn" someone) with... idk, maybe water? ;)
Meh, I never thought I'll ever be involved into politics basically when I open my keyboard.

🍴🏹🔧🔨⚒🛠⛏🔪💣🔫🗡⚔🚬💉✂📍📌 - all this stuff need to be revised!

While we're at it lets change the fork to a spork


Fix in 'buildPipeline' function

Description
This pull request fixes a bug in the buildPipeline function. The change made was:

selector: {type: data.target?.selector.type},

selector: {type: data.target?.selector?.type},

Type of change

[x] Bug fix
[ ] New feature
[ ] Breaking change

Explanation:
The previous version of the buildPipeline function did not work correctly if the selector field was null or undefined. This happened because the code tried to access the type field of a null object, which resulted in an error.
The change fixes this issue by checking if the selector field exists before accessing the type field. If the selector field is null or undefined, the function will return an empty object.
Benefits:
This fix improves the reliability and robustness of the buildPipeline function. It prevents errors from being thrown if the selector field is null or undefined.
Testing:
I tested this change locally and it works as expected. I created a test case where the selector field was null and the function returned the empty object as expected.
I look forward to your review and approval.

I have read the CLA Document and I hereby sign the CLA

@claudio-mas Thank you for your contribution! We do required signed commits though. Could you please sign your commit? I'll approve then 🙏

@claudio-mas Thank you for your contribution! We do required signed commits though. Could you please sign your commit? I'll approve then 🙏

@ypc-faros I'm not sure if I did it correctly, is there something else missing on my part? Thank you 👍

@claudio-mas Thanks for fixing this! Could you rebase/squash your commits and force-push your branch so that all the commit(s) are signed? The first commit in your branch is still unsigned and therefore blocking us from merging.

@claudio-mas Thanks for fixing this! Could you rebase/squash your commits and force-push your branch so that all the commit(s) are signed? The first commit in your branch is still unsigned and therefore blocking us from merging.

@cjwoo, I don't think I'll be able to sign the first commit, could this be resolved by redoing the pull request?

@claudio-mas Apologies for late response, creating a new branch, commit, and PR should resolve it.

Duplicated change with https://github.com/faros-ai/airbyte-connectors/pull/1451


Curly Brace might cause a syntax problem

Hello,
I just used "message>description" to bind to a property( for example, description) of MessageItem.
And when the received data was "blblbl {http://blblbl}", it caused a syntax error with "unexpected '/'".
After debugging the stack, I found "rFragments" variable in BindingParser.js which has "/(\[\{}])|({)/g". It seems searching all open curly brace from data without any limitations.
https://github.com/SAP/openui5/blob/073fffeb16d7ae5f7c265456c3624ae0efda641d/src/sap.ui.core/src/sap/ui/base/BindingParser.js#L44
https://github.com/SAP/openui5/blob/073fffeb16d7ae5f7c265456c3624ae0efda641d/src/sap.ui.core/src/sap/ui/base/BindingParser.js#L461
I think it needs some additional expressions here.
I don't have any idea about the rules here,
hopefully someone could find it.
Regards.

In what context did you use the MessageItem? Most likely, some control embedding the item doesn't do escaping when it propagates the received property value to another control.
See https://github.com/SAP/openui5/issues/1595#issuecomment-316020849 for a general explanation of the matter.

I've read that comment, but I can't find any problem in my code.
https://github.com/SAP/openui5/issues/2233#issue-366649852
As I said above, I think the rFragments is too simple to find open curly brace, a complicated rule for searching sString might exist.
And as following code, I've added messages by the method:
window.sap.ui.getCore().getMessageManager().addMessages()
and bind to properties of window.sap.m.MessageItem.

    const onMessagesButtonPress = function(oEvent) {
    	var oMessagesButton = oEvent.getSource();

    	if (!this._messagePopover) {
    		this._messagePopover = createSimpleComponent({
          targetClass: window.sap.m.MessagePopover,
          name: "messagePopover",
          settings: {
      		items: {
      			path: "message>/",
      			template: createSimpleComponent({
                targetClass: window.sap.m.MessageItem,
                name: "messagePopoverItem",
                allowReset: false,
                settings: {
        		description: "{message>description}",
        		type: "{message>type}",
        		title: "{message>message}",
                  markupDescription: true
                }
              })()
      			}
          }
        })()
    		oMessagesButton.addDependent(this._messagePopover);
      }
    	this._messagePopover.toggle(oMessagesButton);
    }

The createSimpleComponent function will return the created object by name, avoid to re-create new object.

const getMessageProcessor = ()=>{
	if(!MESSAGE_PROCESSOR){
		MESSAGE_PROCESSOR = new window.sap.ui.core.message.ControlMessageProcessor();
	}
	return MESSAGE_PROCESSOR
}

const showMessage = (msg, indicator_clear, type)=>{
	if (typeof(indicator_clear) === UNDEFINED || indicator_clear === true){
		clearMessages()
	}

	if (typeof(type) === UNDEFINED || type === "error"){
		type = window.sap.ui.core.MessageType ? window.sap.ui.core.MessageType.Error : "Error"
	}

	let m = {}
	if(_.isString(msg)){
		m.message = msg
	}else{
		m = msg
	}
	if( _.isEmpty(m.description) ){
		m.description = "No additional description"
	}

	window.sap.ui.getCore().getMessageManager().addMessages(
		new window.sap.ui.core.message.Message({
			message: m.message,
			type: type,
			description: m.description,
			processor: getMessageProcessor()
		})
	);
}

I didn't want to suggest that there's a problem with your code, rather with some composite control that propagates a string value to a constructor of one of its components without proper escaping. That#s why I asked for the context in which you use the sap.m.MessageItem.
What version of UI5 are you using? c1abcd86fee6002731484e02bb4c019eb59a0e41 fixed such an escaping issue in the sap.m.MessagePopover, but that fix is already in since 1.54.0.
It's by intention that rFragments checks for any curly braces. That's how it is supposed to work. If there are curly braces in a string, the string needs escaping - when given to a constructor. When given to a setter, it must not be escaped.
Onco we know the UI5 version that you use, we can try to reproduce the issue.

I'm using latest version (1.56.11).

Please check these examples and let us know how you pass the string e.g. how to reproduce the issue:
https://jsbin.com/mapivepoxi/edit?html,output (JSONModel simulation)
https://jsbin.com/teworiluhi/edit?html,output (MessageManager simulation)
Thanks

Here is the code that could reproduce this issue:
https://jsbin.com/guganexuca/edit?html,output

Click "Add Message", then a button would appear below.
Click that button to show message
If you want to see the message, you could try to remove "{" from message.

Regards.

Thanks, this helped a lot, I unfortunately hadn't found time to play with it.
The problem is with the MessageView.js, it does exactly what is described as a problem in #1595, see
https://github.com/SAP/openui5/blob/master/src/sap.m/src/sap/m/MessageView.js#L928
For the non-markup path, the necessary escaping is already done, for the markup path it is missing.

The case is logged internally via #1880616644
Thanks


Module compiled with Swift 4.0.3 cannot be imported in Swift 4.1

After updating XCode 9.3 I started getting this error.

Try with the latest version and reopen with a few more details if you are still getting the same error.


fix: lean4-ify names of inductive constructors

These inductive types carry data, so these should be functionCase not theorem_case.
It seems that mathport didn't do this.

Thanks! :tada:
bors merge


Slowmode CC

I think it would be a nice addition
yes, i read the CONTRIBUTING.md file and followed the steps

Imma do the rest of the changes when my computer gets fixed, the issue with having all channels in a single db is that all channels with slowmode have seperate slowmode times and having them all in one might even exceed the amount of db calls in one cc

@Spongerooski Then id -> slowmode dictionary should work fine, unless I'm missing something obvious. and np, take your time :)

Do you mean like having one db entry which contains the channel ids with their slowmode and it gets updated if a slowmode is changed or removed?

yes

is this ready for merge, ignoring the comments about dict about?

is this ready for merge, ignoring the comments about dict about?

seems like it, yeah, if you want more changes lmk

seems like it, yeah, if you want more changes lmk

Thank you!

Thank you!


flux-local: Allow policy checking

Broken out from #35
Update the flux-local cli to allow testing policies. The implementation will run  kyverno cli against local policy files to verify that cluster resources confirm to spec ( example )

Now that flux-local test has been improved in #71, this should be straight forward to connect with the existing policy and the validate library in https://github.com/allenporter/flux-local/blob/fb201306a94e40cc6c480dce153367de3b69446d/flux_local/kustomize.py#L107


cmd/go: go mod init does not correctly resolve pseudo-versions

What version of Go are you using (go version)?

$ go version
go version devel +ab724d43ef Mon May 20 20:58:14 2019 +0000 linux/amd64

What did you do?
Extract the following files:
-- glide.lock --
imports:
- name: github.com/Shopify/sarama
  version: 4602b5a8c6e826f9e0737865818dd43b2339a092
  subpackages:
  - mocks
- name: github.com/eapache/queue
  version: 093482f3f8ce946c05bcba64badd2c82369e084d
-- glide.yaml --
package: example

-- main.go --
package main

import (
	_ "github.com/Shopify/sarama"
	_ "github.com/eapache/queue"
)

func main() {}

Run go mod init example.
What did you expect to see?
I would expect to see the go.mod file reflect the requirements listed in the glide.lock file. Specifically, I'd expect to see this go.mod file:
module example

require (
	github.com/Shopify/sarama v1.21.0
	github.com/eapache/queue v1.1.1-0.20180227141424-093482f3f8ce
)

go 1.13

which is what you get if you start with this go.mod file, which exactly reflects the glide.lock file:
module example

go 1.12

require (
	github.com/eapache/queue 093482f3f8ce946c05bcba64badd2c82369e084d
	github.com/Shopify/sarama 4602b5a8c6e826f9e0737865818dd43b2339a092
)

What did you see instead?
I see this go.mod file:
module example

go 1.13

require (
	github.com/Shopify/sarama v1.21.0
	github.com/eapache/queue v0.0.0-20180227141424-093482f3f8ce
)

The github.com/eapache/queue dependency has the wrong pseudo-version, which means that when dependencies are later resolved, the dependency in sarama (which depends on epache/queue v1.1.0) supercedes the dependency in the go.mod file, which leads to a version regression.

cc @bcmills @jayconrod

Seems duplicated of https://github.com/golang/go/issues/29262

@cuonglm I don't think it's a duplicate of that bug. With that bug, I can do go get rsc.io/quote@5d9f230bcfba and version stays at v0.0.0-20180710144737-5d9f230bcfba, whereas with this bug, if I do go get github.com/eapache/queue@093482f3f8ce, the version changes to the correct v1.1.1-0.20180227141424-093482f3f8ce.

Neat example. I can confirm the observed behavior: go mod init produces the wrong pseudo-version, but go get finds the correct one.

https://golang.org/cl/178497 I think is trying to get go mod init to create the proper pseudoversion.
If that turns out to be tricky to get right or a bigger change than would work for 1.13, I wonder if an alternative approach might be to simplify what go mod init tries to do in this case.
Instead of go mod init creating the proper pseudoversion, perhaps instead go mod init could just leave the commit hash in the resulting go.mod file?
That should then be automatically converted to the right pseudoversion by the first go list -m all, go build or similar because the commit hash would be treated as a "module query".
However, perhaps that is no simpler than the current https://golang.org/cl/178497 approach.

@thepudds I don't know why that change is not sure or hard to understand. When the convert try to make pseudoversion, it does use statVers to query the most recent tag:
                        // Otherwise make a pseudo-version.
                        if info2.Version == "" {
                                tag, _ := r.code.RecentTag(statVers, p)
                                v = tagToVersion(tag)
                                // TODO: Check that v is OK for r.pseudoMajor or else is OK for incompatible.
                                info2.Version = PseudoVersion(r.pseudoMajor, v, info.Time, info.Short)
                        }

we passed statVers as empty string, so most recent tag from HEAD was returned instead of most recent tag from commit.

It is not correct for convert to use statVers in the RecentTag lookup, but passing in the correct rev moves things in the right direction regardless.


feat: add show organization accounts data source

Test Plan

[x] acceptance tests

[ ] …

References

@peter-chai-iw i know it has been a while since you last opened this PR. this is a good feature request that only requires a few small changes to get it ready for release. Would you like to make the changes to get this up-to-date or would you like me to do it for you?

Closing due to inactivity.


How to stop module from rendering completely…

Problem Description
In the Divi Button Module, if neither the Button Text and Button URL are defined, the module is not rendered to the screen. This seems to be achieved with just this code:
if ( '' === $button_text && '' === $button_url ) {     return ''; }
However, if I try and do the same with my own modules, the module’s et_pb_module div and et_pb_module_inner div are still rendered. The closest I have got to removing the module altogether, is to modify the elements wrapper_settings, like this:
$this->wrapper_settings = array(     'attrs' => array(),     'inner_attrs'  => array(), );
And then...
return '';
However, I'm still left with empty (classless) divs for the outer and inner module elements.
How do we conditionally stop a module from rendering to the screen completely?
Thanks!
David.

@dtcblyth can you please implement this method in your class like so?
        protected function _render_module_wrapper( $output = '', $render_slug = '' ) {
		return $output;
	}

This should remove the wrappers.


Allow multiple contexts per MLS+SFrame sender

Real-time media systems often have strong decoupling between media sources after initial setup, including things like providing separate SRTP contexts for different media sources.  In SRTP, this is safe because the RTP SSRC is included in the nonce computation.  In MLS+SFrame, however, the key and nonce only depend on the secret and the sender ID in the KID, so having multiple contexts with the same secret and KID leads to nonce reuse.
Since the MLS+SFrame provisions derive per-sender-ID keys and senders will never use all 64-E bits of KID, we can put a context distinguisher in the high-order bits of the sender ID that will cause independent contexts to have different keys and independent nonce sequences.  The resulting KID value will thus have the following form:
              sender_bits epoch_bits
              <---------> <-------->
+------------+-----------+----------+
| Context ID | Sender ID | Epoch ID |
+------------+-----------+----------+

The width of the "sender ID" part will depend on the size of the MLS group, and can vary by epoch, but it needs to be large enough to hold the MLS sender indices.  For example, a group with 256 participants needs sender_bits >= 8.
This has not been added to the specification yet.

One additional note: This requires that the encoded sender_id used in key derivation be encoded in more bytes (8 instead of 4).  The combined sender index and context ID might overflow a 4-byte field, in which case there would be a a risk of collision and key/nonce reuse.  This doesn't cost any more bits on the wire, but does make this change non-backward-compatible.


Add possibility to use StrokeDashArray for line-based series.

Hello, mainly in need of StokeDashArray property for FastLineRenderableSeries, but read from here https://www.scichart.com/documentation/js/current/webframe.html#Series Styling - Dash Line Patterns.html that "All the line-based series in SciChart.js support StrokeDashArray for dashed or dotted lines." So thought it will be useful for all, not only FastLineRenderableSeries.

I don't have a lot of time to maintain this. However, if you want to take a stab at this, you likely can create a new Interface ILineSeries or something like that. Please feel free to do a PR (with a demo of it working) and I'll be happy to add it

Looks like you did! Please add something to the demos showing it working and I'll be happy to merge


LXD containers fail to execute network driver operation: post.

Description
As I attempt to instantiate LXD container it fails to boot with an error stating
Failed to execute network driver operation: post.
To Reproduce
Steps to reproduce the behavior.
Instantiate Centos7 or Fedora 29/30 LXD
Expected behavior
LXD container boots and runs.
Details

Affected Component: Sunstone, post,
Hypervisor:  LXD
Version: 5.8.4

Additional context
Here is the full LXD log:
Fri Aug 16 11:45:11 2019 [Z0][VM][I]: New state is ACTIVE
Fri Aug 16 11:45:11 2019 [Z0][VM][I]: New LCM state is PROLOG
Fri Aug 16 11:45:13 2019 [Z0][VM][I]: New LCM state is BOOT
Fri Aug 16 11:45:13 2019 [Z0][VMM][I]: Generating deployment file: /var/lib/one/vms/76/deployment.0
Fri Aug 16 11:45:13 2019 [Z0][VMM][I]: Successfully execute transfer manager driver operation: tm_context.
Fri Aug 16 11:45:14 2019 [Z0][VMM][I]: ExitCode: 0
Fri Aug 16 11:45:14 2019 [Z0][VMM][I]: Successfully execute network driver operation: pre.
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Processing disk 0
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Using rbd disk mapper for
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Mapping disk at /var/snap/lxd/common/lxd/storage-pools/default/containers/one-76/rootfs using device /dev/nbd1
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Resizing filesystem ext4 on /dev/nbd1
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Mounting /dev/nbd1 at /var/snap/lxd/common/lxd/storage-pools/default/containers/one-76/rootfs
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Mapping disk at /var/lib/one/datastores/101/76/mapper/disk.1 using device /dev/loop0
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: Mounting /dev/loop0 at /var/lib/one/datastores/101/76/mapper/disk.1
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: deploy: --- Starting container ---
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: ExitCode: 0
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: Successfully execute virtualization driver operation: deploy.
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: Command execution fail: /var/tmp/one/vnm/fw/post [encoded data, 4448 characters] 'one-76'
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: iptables v1.6.1: interface name --physdev-is-bridged' must be shorter than IFNAMSIZ (15) Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: Try iptables -h' or 'iptables --help' for more information.
Fri Aug 16 11:45:16 2019 [Z0][VMM][E]: post: Command Error: sudo iptables -I opennebula -m physdev --physdev-out  --physdev-is-bridged -j one-76-0-i
Fri Aug 16 11:45:16 2019 [Z0][VMM][E]: post: ["/var/tmp/one/vnm/command.rb:62:in block in run!'", "/var/tmp/one/vnm/command.rb:59:in each'", "/var/tmp/one/vnm/command.rb:59:in run!'", "/var/tmp/one/vnm/security_groups_iptables.rb:485:in nic_pre'", "/var/tmp/one/vnm/sg_driver.rb:92:in block in activate'", "/var/tmp/one/vnm/vnm_driver.rb:79:in block in process'", "/var/tmp/one/vnm/vm.rb:64:in block in each_nic'", "/var/tmp/one/vnm/vm.rb:63:in each'", "/var/tmp/one/vnm/vm.rb:63:in each_nic'", "/var/tmp/one/vnm/vnm_driver.rb:82:in process'", "/var/tmp/one/vnm/sg_driver.rb:84:in activate'", "/var/tmp/one/vnm/fw/post:32:in '"]
Fri Aug 16 11:45:16 2019 [Z0][VMM][I]: ExitCode: 1
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: --- Stopping container ---
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Processing disk 0
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Using rbd disk mapper for
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Unmapping disk at /var/snap/lxd/common/lxd/storage-pools/default/containers/one-76/rootfs
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Umounting disk mapped at /dev/nbd1
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Unmapping disk at /var/lib/one/datastores/101/76/mapper/disk.1
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Umounting disk mapped at /dev/loop0
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: ExitCode: 0
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: Successfully execute virtualization driver operation: cancel.
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: Failed to execute network driver operation: post.
Fri Aug 16 11:45:17 2019 [Z0][VMM][E]: Error deploying virtual machine: fw: -
Fri Aug 16 11:45:17 2019 [Z0][VM][I]: New LCM state is BOOT_FAILURE

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

@dann1 I see you assigned yourself.  If any additional information is needed please let me know.

Hi @alitvak69, could you clarify what version is this opennebula setup ?
Issue says it's 5.8.0, but this line

Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Processing disk 0

Was added 2 months ago

It is 5.8.4, the issue started to manifest in 5.8.3, update to 5.8.4 didn't
help.
On Mon, Aug 19, 2019 at 12:21 PM Daniel Clavijo Coca <
<EMAIL_ADDRESS>wrote:

Hi @alitvak69 https://github.com/alitvak69, could you clarify what
version is this opennebula setup ?
Issue says it's 5.8.0, but this line
Fri Aug 16 11:45:17 2019 [Z0][VMM][I]: shutdown: Processing disk 0
Was added 2 months ago
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenNebula/one/issues/3596?email_source=notifications&email_token=ABWJN3EI57VFTBBWBKK4SG3QFLJATA5CNFSM4IML5YN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4TVZYY#issuecomment-522673379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWJN3HWV7Y42YQREVAPF7DQFLJATANCNFSM4IML5YNQ
.

Yes sorry, I read 5.8.0, I don't know what I was looking at.

@dann1 Any luck in reproducing it?  None of my LXDs are starting for this reason and I am not sure what could cause it.

Hi @alitvak69, I cannot reproduce the issue, here is the centos7 based LXD VM template with an fw net
oneadmin@ubuntu1804-lxd-qcow2-f34f2-0:~/readiness$ onevm show -x 20
<VM>
  <ID>20</ID>
  <UID>0</UID>
  <GID>0</GID>
  <UNAME>oneadmin</UNAME>
  <GNAME>oneadmin</GNAME>
  <NAME>alitvak69-20</NAME>
  <PERMISSIONS>
    <OWNER_U>1</OWNER_U>
    <OWNER_M>1</OWNER_M>
    <OWNER_A>0</OWNER_A>
    <GROUP_U>0</GROUP_U>
    <GROUP_M>0</GROUP_M>
    <GROUP_A>0</GROUP_A>
    <OTHER_U>0</OTHER_U>
    <OTHER_M>0</OTHER_M>
    <OTHER_A>0</OTHER_A>
  </PERMISSIONS>
  <LAST_POLL>1566365074</LAST_POLL>
  <STATE>3</STATE>
  <LCM_STATE>3</LCM_STATE>
  <PREV_STATE>3</PREV_STATE>
  <PREV_LCM_STATE>3</PREV_LCM_STATE>
  <RESCHED>0</RESCHED>
  <STIME>1566364996</STIME>
  <ETIME>0</ETIME>
  <DEPLOY_ID>one-20</DEPLOY_ID>
  <MONITORING>
    <CPU><![CDATA[0.0]]></CPU>
    <MEMORY><![CDATA[0]]></MEMORY>
    <NETRX><![CDATA[726]]></NETRX>
    <NETTX><![CDATA[726]]></NETTX>
    <STATE><![CDATA[a]]></STATE>
  </MONITORING>
  <TEMPLATE>
    <AUTOMATIC_DS_REQUIREMENTS><![CDATA[("CLUSTERS/ID" @> 0)]]></AUTOMATIC_DS_REQUIREMENTS>
    <AUTOMATIC_NIC_REQUIREMENTS><![CDATA[("CLUSTERS/ID" @> 0)]]></AUTOMATIC_NIC_REQUIREMENTS>
    <AUTOMATIC_REQUIREMENTS><![CDATA[(CLUSTER_ID = 0) & !(PUBLIC_CLOUD = YES)]]></AUTOMATIC_REQUIREMENTS>
    <CONTEXT>
      <DISK_ID><![CDATA[1]]></DISK_ID>
      <ETH0_CONTEXT_FORCE_IPV4><![CDATA[]]></ETH0_CONTEXT_FORCE_IPV4>
      <ETH0_DNS><![CDATA[]]></ETH0_DNS>
      <ETH0_EXTERNAL><![CDATA[]]></ETH0_EXTERNAL>
      <ETH0_GATEWAY><![CDATA[]]></ETH0_GATEWAY>
      <ETH0_GATEWAY6><![CDATA[]]></ETH0_GATEWAY6>
      <ETH0_IP><![CDATA[<IP_ADDRESS>]]></ETH0_IP>
      <ETH0_IP6><![CDATA[]]></ETH0_IP6>
      <ETH0_IP6_PREFIX_LENGTH><![CDATA[]]></ETH0_IP6_PREFIX_LENGTH>
      <ETH0_IP6_ULA><![CDATA[]]></ETH0_IP6_ULA>
      <ETH0_MAC><![CDATA[02:00:c0:a8:a0:64]]></ETH0_MAC>
      <ETH0_MASK><![CDATA[]]></ETH0_MASK>
      <ETH0_MTU><![CDATA[]]></ETH0_MTU>
      <ETH0_NETWORK><![CDATA[]]></ETH0_NETWORK>
      <ETH0_SEARCH_DOMAIN><![CDATA[]]></ETH0_SEARCH_DOMAIN>
      <ETH0_VLAN_ID><![CDATA[]]></ETH0_VLAN_ID>
      <ETH0_VROUTER_IP><![CDATA[]]></ETH0_VROUTER_IP>
      <ETH0_VROUTER_IP6><![CDATA[]]></ETH0_VROUTER_IP6>
      <ETH0_VROUTER_MANAGEMENT><![CDATA[]]></ETH0_VROUTER_MANAGEMENT>
      <NETWORK><![CDATA[YES]]></NETWORK>
      <SET_HOSTNAME><![CDATA[alitvak69-20]]></SET_HOSTNAME>
      <SSH_PUBLIC_KEY><![CDATA[ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCYz+lkZoNyspRhrtXDKFN3cIEwN3w08mz0YGKpVDIiV0+/vgG8dAUQ70Irs3m83W9BHN+vNjKPgKcF+X+sSfxniOtavahxGCRjAhhs1IVm196C5ODbSgXVUWULdtmMHelXbLBJ8X340h/UO+eQ6eRLaRfslXUsgRqremVcvCCPz4LIuRiliGWiELAmqYcY+1zJLeg3QV2Pgn5vschM9e/A4AseKO+HnbGB/I5tnoeZT/Gc3FGfUZLNFVB2XsVGAEEzkqO8VI2msB7MCAZBHffIK6WfLIYgGP6Ha2JT1NWJU7Ncj9Xuql0ElF01VwWMDWzqc0DOiVSsTL89ugJKU6+h one]]></SSH_PUBLIC_KEY>
      <TARGET><![CDATA[hdb]]></TARGET>
    </CONTEXT>
    <CPU><![CDATA[1]]></CPU>
    <DISK>
      <ALLOW_ORPHANS><![CDATA[NO]]></ALLOW_ORPHANS>
      <CLONE><![CDATA[YES]]></CLONE>
      <CLONE_TARGET><![CDATA[SYSTEM]]></CLONE_TARGET>
      <CLUSTER_ID><![CDATA[0]]></CLUSTER_ID>
      <DATASTORE><![CDATA[default]]></DATASTORE>
      <DATASTORE_ID><![CDATA[1]]></DATASTORE_ID>
      <DEV_PREFIX><![CDATA[hd]]></DEV_PREFIX>
      <DISK_ID><![CDATA[0]]></DISK_ID>
      <DISK_SNAPSHOT_TOTAL_SIZE><![CDATA[0]]></DISK_SNAPSHOT_TOTAL_SIZE>
      <DISK_TYPE><![CDATA[FILE]]></DISK_TYPE>
      <DRIVER><![CDATA[qcow2]]></DRIVER>
      <IMAGE><![CDATA[centos_7 - LXD]]></IMAGE>
      <IMAGE_ID><![CDATA[4]]></IMAGE_ID>
      <IMAGE_STATE><![CDATA[9]]></IMAGE_STATE>
      <LN_TARGET><![CDATA[NONE]]></LN_TARGET>
      <ORIGINAL_SIZE><![CDATA[1024]]></ORIGINAL_SIZE>
      <READONLY><![CDATA[NO]]></READONLY>
      <SAVE><![CDATA[NO]]></SAVE>
      <SIZE><![CDATA[1024]]></SIZE>
      <SOURCE><![CDATA[/var/lib/one//datastores/1/8813f27f47e4396104b474b395c9776c]]></SOURCE>
      <TARGET><![CDATA[hda]]></TARGET>
      <TM_MAD><![CDATA[qcow2]]></TM_MAD>
      <TYPE><![CDATA[FILE]]></TYPE>
    </DISK>
    <GRAPHICS>
      <LISTEN><![CDATA[<IP_ADDRESS>]]></LISTEN>
      <PORT><![CDATA[5920]]></PORT>
      <TYPE><![CDATA[VNC]]></TYPE>
    </GRAPHICS>
    <MEMORY><![CDATA[768]]></MEMORY>
    <NIC>
      <AR_ID><![CDATA[0]]></AR_ID>
      <BRIDGE><![CDATA[br0]]></BRIDGE>
      <BRIDGE_TYPE><![CDATA[linux]]></BRIDGE_TYPE>
      <CLUSTER_ID><![CDATA[0]]></CLUSTER_ID>
      <FILTER_IP_SPOOFING><![CDATA[YES]]></FILTER_IP_SPOOFING>
      <FILTER_MAC_SPOOFING><![CDATA[YES]]></FILTER_MAC_SPOOFING>
      <IP><![CDATA[<IP_ADDRESS>]]></IP>
      <MAC><![CDATA[02:00:c0:a8:a0:64]]></MAC>
      <NAME><![CDATA[NIC0]]></NAME>
      <NETWORK><![CDATA[sg-1]]></NETWORK>
      <NETWORK_ID><![CDATA[1]]></NETWORK_ID>
      <NIC_ID><![CDATA[0]]></NIC_ID>
      <SECURITY_GROUPS><![CDATA[0]]></SECURITY_GROUPS>
      <TARGET><![CDATA[one-20-0]]></TARGET>
      <VN_MAD><![CDATA[fw]]></VN_MAD>
    </NIC>
    <OS>
      <BOOT><![CDATA[]]></BOOT>
    </OS>
    <SECURITY_GROUP_RULE>
      <PROTOCOL><![CDATA[ALL]]></PROTOCOL>
      <RULE_TYPE><![CDATA[OUTBOUND]]></RULE_TYPE>
      <SECURITY_GROUP_ID><![CDATA[0]]></SECURITY_GROUP_ID>
      <SECURITY_GROUP_NAME><![CDATA[default]]></SECURITY_GROUP_NAME>
    </SECURITY_GROUP_RULE>
    <SECURITY_GROUP_RULE>
      <PROTOCOL><![CDATA[ALL]]></PROTOCOL>
      <RULE_TYPE><![CDATA[INBOUND]]></RULE_TYPE>
      <SECURITY_GROUP_ID><![CDATA[0]]></SECURITY_GROUP_ID>
      <SECURITY_GROUP_NAME><![CDATA[default]]></SECURITY_GROUP_NAME>
    </SECURITY_GROUP_RULE>
    <TEMPLATE_ID><![CDATA[6]]></TEMPLATE_ID>
    <TM_MAD_SYSTEM><![CDATA[qcow2]]></TM_MAD_SYSTEM>
    <VMID><![CDATA[20]]></VMID>
  </TEMPLATE>
  <USER_TEMPLATE>
    <HYPERVISOR><![CDATA[lxd]]></HYPERVISOR>
    <INPUTS_ORDER><![CDATA[]]></INPUTS_ORDER>
    <LXD_PROFILE><![CDATA[]]></LXD_PROFILE>
    <LXD_SECURITY_NESTING><![CDATA[no]]></LXD_SECURITY_NESTING>
    <LXD_SECURITY_PRIVILEGED><![CDATA[]]></LXD_SECURITY_PRIVILEGED>
    <MEMORY_UNIT_COST><![CDATA[MB]]></MEMORY_UNIT_COST>
  </USER_TEMPLATE>
  <HISTORY_RECORDS>
    <HISTORY>
      <OID>20</OID>
      <SEQ>0</SEQ>
      <HOSTNAME>ubuntu1804-lxd-qcow2-f34f2-2.test</HOSTNAME>
      <HID>1</HID>
      <CID>0</CID>
      <STIME>1566365022</STIME>
      <ETIME>0</ETIME>
      <VM_MAD><![CDATA[lxd]]></VM_MAD>
      <TM_MAD><![CDATA[qcow2]]></TM_MAD>
      <DS_ID>0</DS_ID>
      <PSTIME>1566365022</PSTIME>
      <PETIME>1566365025</PETIME>
      <RSTIME>1566365025</RSTIME>
      <RETIME>0</RETIME>
      <ESTIME>0</ESTIME>
      <EETIME>0</EETIME>
      <ACTION>0</ACTION>
      <UID>-1</UID>
      <GID>-1</GID>
      <REQUEST_ID>-1</REQUEST_ID>
    </HISTORY>
  </HISTORY_RECORDS>
</VM>

The VM runs
oneadmin@ubuntu1804-lxd-qcow2-f34f2-0:~/readiness$ onevm list
    ID USER     GROUP    NAME            STAT UCPU    UMEM HOST             TIME
    20 oneadmin oneadmin alitvak69-20    runn  0.0      0K ubuntu1804   0d 00h02

The part of the driver that must be failing on your setup is the one related to getting the container nic of the veth pair located on the host.
https://github.com/OpenNebula/one/blob/0c1550a90ef979155d9877b6b674eea5dbe85607/src/vnm_mad/remotes/lib/nic.rb#L107-L147
Maybe you can debug something over there. Are you using snapd or apt based setup ?

I am using snapd based setup,  but the problem started after apt-get upgrade was run.  I updated ceph-common to 14.2.2 during to cluster update, which caused rbd-nbd  to die with segfault.  Thinking something else was not updated,  I ran apt-get update && apt-get upgrade.  The rbd-nbd started running fine but this problem appeared.  Do you think that update overwrought something and perhaps I need to reinstall lxd with snap or apt-get?  The thing is,  I already removed and installed all relevant opennebula debs during 5.8.3 to 5.8.4 update.

In any case,  how do you enable debug so it prints more than the log already have?

I don't think ceph has any role over this issue. The issue here is reading the value of the NIC veth pair on the host from the container configuration. Long ago we had an issue with this particular situation where the value couldn't be read due to snapd-based setup requiring sudo to run the command.
Update, in the LXD host, the file /var/tmp/one/vnm/nic.rb with the changes seen here.

I guess my story got too long.  While ceph is not the issue general systemwide package update could break something.  In any case I will add those lines for debugging and report.

That is possible, also keep in mind that we recommend avoiding snapd-based setups if possible.

Should I do it via apt-get?  Is there a document for that?

I've updated the changes, the 2nd e was wrong

http://docs.opennebula.org/5.8/deployment/node_installation/lxd_node_installation.html#installing-on-ubuntu

Confirmed with a snap based setup, very important when reporting LXD related bugs to state whether it's snap based or apt based environment.

The snapd got updated and the output it gave changed, code relied on it. I've updated it. Check https://github.com/OpenNebula/one/pull/3605/files if you want to apply the patch.

Your patch has worked.  I have LXD running again.  However, and I apologize for off-topic, snap changed probably affected noVNC console as well.   If you want me to open a separate issue I will, logs below, however.

Could your patch affect KVM interface naming?  I had VMs operating with default eth0 and eth1 virtual nics.  After installing the patch and redeploying my instances coming up with ens3 and ens4 interfaces.
It seems that virtio nic is no longer default and virtio_net is not loaded on boot.

Never mind my last message.  The upgrade overwrote my custom vmm_exec_kvm file making network cards RTC-Link instead of virtio by default.

Remember to update the source file in the frontend so when you add new hosts the will get the patch as well. The file is located in /var/lib/one/remotes/vnm/nic.rb in the frontend.


Auto-convert the tty file descriptor/stream on fopen/open

This resolves the issue when the /dev/tty* device is opened via fopen or open and then written to or read from. Without this change, we typically see garbled messages printed on the screen.
This issue affects sudo and less (we already have a workaround for less here, but we can undo it with this change). I've tested these projects with this change.
I believe it also affects gpg - FYI @HarithaIBM, and potentially others

nice... is the ccsid always 1047 if it's EBCDIC?

Yeah the change only applies to the stream if the tty is untagged, so I suppose a user could manually tag their tty to another EBCDIC ccsid and auto-conversion should take still into effect. But typically /dev/tty* is untagged on z/OS.
We did the same here on file descriptors 0,1 and 2: https://github.com/ibmruntimes/zoslib/blob/91bad64f0da971adde1e0b5733e2c6e180077678/src/zos.cc#L2738


JWT signature is not valid when it is

Hi, this library was recommended to me by Microsoft as I'm trying to verify an access_token from my API that was sent to it from my ReactJS frontend.
Basically, the flow is this:

User goes to web app at https://www.example.com
They are redirected to Azure AD to signin
Successful sign-in provides id_token and access_token
access_token is sent to Python backend to verify it is authentic token and not just some random string or object
If it is a verified, then the frontend and API are permitted to communicate with one another

So I'm getting the access_token in the FE using the following:
// Authentication.js

...
  const testApiAuthentication = async () => {
    let token = await authProvider.getAccessToken();
    setAccessToken(token.accessToken);
    if (token.accessToken) {
      console.log(token.accessToken);
      setAuthenticatingToken(true);
      axios({
        method: 'post',
        url: '/api/user/',
        data: { access_token: token.accessToken },
        // headers: {
        //   'Accept': 'application/json',
        //   'Authorization': 'Bearer ' + token.accessToken
        // }
      })
        .then((response) => {
          console.log(response);
        })
        .catch((error) => {
          console.log(error);
        });
    }
  };
...

Then I'm doing the following in the API to verify the token. I can print(request.data['access_token'] and it does print out the access_token I sent to it. So it is receiving it.
# views.py

from rest_framework.views import APIView
from rest_framework.response import Response
from rest_framework import serializers
# from rest_framework.permissions import AllowAny
# from rest_framework.authentication import TokenAuthentication

from py_jwt_validator import PyJwtValidator, PyJwtException

class TokenSerializer(serializers.Serializer):
    access_token = serializers.CharField(allow_blank=False,trim_whitespace=True)

# Create your views here.
class TestView(APIView):

    def post(self, request, *args, **kwargs):
        print(request.data['access_token'])
        jwt = request.data['access_token']
        validator = PyJwtValidator(jwt, auto_verify=False)
        try:
            payload = validator.verify(True)
            print(payload)
        except PyJwtException as e:
            print(f"Exception caught. Error: {e}")

        serializer = TokenSerializer(data=request.data)
        return Response('Hello World')

The server just says:
Exception caught. Error: JWT Signature is not valid.

But it is. Well, it should be given that milliseconds before it retrieved an access_token from Azure AD on the frontend.
I also tried with the id_token and that appeared to work. It returns a payload with my information. I'm just pretty sure I shouldn't be using that for authentication purposes... at least I seem to recall reading that somewhere in the Azure AD documentation.
I'm not entirely sure what is going on. Thoughts?

Hello @cheslijones ! I do apologize for the late response. As you can see, there has been some time since the latest update for this library due to my loaded work schedule. I would like to look further into this problem, and hopefully find a fix for it.
Since it's been some time since I developed it, I am not 100% sure if it fully supports Microsoft (both access_token and id_token), or it's only able to verify the id_token.
What would be really useful is if you can provide me with an access_token that can't be verified, so I can properly troubleshoot it.
Furthermore, in regards to your concern of what you should use for authentication, let me shed some light:

Access Tokens are intended to be used for Authorization purposes in different contexts, most often service to service communication (Oauth)
ID Tokens are inteded to be used for Authentication purposes as they provide a user context, hence the ID (identifier) in the name (OIDC - OpenID Connect).

Therefore, if your main purpose is authentication, then you can definitely use the id_token, as you would only follow the standard.

Hi @cheslijones.
Small update. I've been able to retrieve an acess_token from AAD using the client_credentials flow. Indeed, I was unable to verify the signature with the RS256 algorithm.
From my readings (https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/609) it seems that the signature generation process is a bit different than the IETF process, therefore it appears only MS can verify these access tokens.
I will, however, invest some more time into researching this matter, as I would like to fully determine whether is possible for me to implement this logic or not.
Have a great day!

Hi @cheslijones
Final update.
I've played along a bit more with AAD, and id_tokens and access_tokens that they issue.
I can defnitely say that this library will not include support for verification of access_tokens issued by AAD, but it does support the verification of the id_token signature.
I will ensure to update the documentation, so this will be reflected.

Got it, thank you for looking into and verifying that!


[SPARK-36184][SQL] Use ValidateRequirements instead of EnsureRequirements to skip AQE rules that adds extra shuffles

What changes were proposed in this pull request?

Currently, two AQE rules OptimizeLocalShuffleReader and OptimizeSkewedJoin run EnsureRequirements at the end to check if there are extra shuffles in the optimized plan and revert the optimization if extra shuffles are introduced.
This PR proposes to run ValidateRequirements instead, which is much simpler than EnsureRequirements. This PR also moves this check to AdaptiveSparkPlanExec, so that it's centralized instead of in each rule. After centralization, the batch name of optimizing the final stage is the same as normal stages, which makes more sense.
Why are the changes needed?

EnsureRequirements is a big rule and even contains optimizations (remove unnecessary shuffles). ValidateRequirements is much faster to run and can avoid potential bugs as it has no optimization and is a pure check.
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing tests.

cc @yaooqinn @ulysses-you @viirya @JkSelf @maryannxue

Test build #141166 has started for PR 33396 at commit 8caab18.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45677/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45677/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45677/

Test build #141166 has finished for PR 33396 at commit 8caab18.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141166/

thanks for the review, merging to master/3.2 (since it fixes potential bugs for AQE)!

+1, LGTM. Thank you, @cloud-fan and all.


Add devtools extension

Description
Add a collection of dev tools (commands) for everyday tasks. For now the only command I add is "Format JSON" that formats JSON from clipboard.
Type of change

New extension

Screencast
https://user-images.githubusercontent.com/2499356/145694923-a769acb3-d6c8-4293-938d-101ef7b5ec4e.mov
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing

Hi @frouo 🔥
Thanks for your contribution 💪
Are you aware of that there is multiple extension that formats JSON and a toolbox?

https://www.raycast.com/destiner/json-format
https://www.raycast.com/Kang/toolbox

It could be an idea to contact the author and help contribute to the already existing extension instead of making another one, let me know if you have any concerns regarding this

Hello @pernielsentikaer, thank you for reviewing.
Oh I did not see toolbox, sorry. And json-format did not yet exist when I first used Raycast (3 days ago) 😅.
I installed these extensions:

toolbox is 1 command that lists features, it is not a collection of commands. So if I need to access a feature, I must first open the application. I personally prefer having commands right away just by pressing Command + Space (as in Window Management extension for example). So I think that toolbox / devtools concept is different. Besides, maybe I should rename this extension devcommands?
json-format. Yes I can contact the author and contribute to make json-format meets my needs (as it is, this extension copies the result to the clipboard when I just would like to see the result).

What is best then:
Should I close the PR? Start contacting authors (including those listed in the README.md) to know what they think about the idea of merging their extension in a bigger one? Or ask the community (slack)?

Hey there. Just stumbled upon this PR. I'm the author of json-format extension. Let me know if you want to collaborate!

toolbox is 1 command that lists features, it is not a collection of commands. So if I need to access a feature, I must first open the application. I personally prefer having commands right away just by pressing Command + Space (as in Window Management extension for example). So I think that toolbox / devtools concept is different. Besides, maybe I should rename this extension devcommands?

You could bind the extension to a hotkey, then it's also starting in the “root” with all available commands like you want to

Should I close the PR? Start contacting authors (including those listed in the README.md) to know what they think about the idea of merging their extension in a bigger one? Or ask the community (slack)?

It should be fine to tag them in this thread, they are both on GitHub (as you saw with @Destiner) — It would be preferable to close the PR and add it to the existing extensions due to similarities in them
We're planned on adding support for “contributors” in package.json, so co-authors also get credit, but I can't give you a date for that yet 😄

cc @DanielSinclair @AntonNiklasson @jmaeso @fe9lix

@Destiner @pernielsentikaer fyi: we do have support for the contributors now

Hey, not sure why I got tagged to the thread. My assumption is that I did (probably?) the smallest extension ever 😂 so it could be a great easy addition to a bigger toolbox.
I did the uuid extension to be able to have a new uuid in my clipboard by tapping cmd + Space -> uuid -> Enter, so please, whatever work is done with the toolbox, I would prefer not make this use-case longer in steps.
Feel free to include any uuid functionality wherever you desire, I don't deserve much merit on the code I submitted. I think it was literally a 3 lines feature.


Error access denied with local file

When I open it the first time it displays pdf but when I go back and again try to open it  shows this error.
Error  {
  "canGoBack": false,
  "canGoForward": false,
  "code": -1,
  "description": "net::ERR_ACCESS_DENIED",
  "loading": false,
  "target": 765,
  "title": "Web page not available",
  "url": "file:///data/user/0/host.exp.exponent/cache/ExperienceData/%2540rohitsaini0444%252FRD/index.html",
}

Code:
<PDFReader
  source={{ uri:  "file:///data/user/0/host.exp.exponent/files/ExperienceData/%2hs%252FRD/a.pdf"}}  />

+1

please try last version

It is reproduced in version 0.5.3 with Expo SDK 36.

This fork https://github.com/Codeko/rn-pdf-reader-js works fine.

You should really use the last version, I've made better support for iOS and Android!
Please let me know what I need to change here to fix it. Even if that from 'your' old clone of this repo.

You should really use the last version, I've made better support for iOS and Android!
Please let me know what I need to change here to fix it. Even if that from 'your' old clone of this repo.

@xcarpentier, sorry if my comment referring to a fork has been inappropriate here. The fork is not mine. If I find the difference between both repositories that corrects the problem, I comment, don't hesitate.

No worries, I admit that I let this repo too long without fixing it. But today I'm facing issues with this so I work for it and share.
I think the issue is related to the removing of the HTML from local files. (maybe we can keep it but I don't think it's performant at all).
I remove the HTML file at every mount
https://github.com/xcarpentier/rn-pdf-reader-js/blob/master/src/index.tsx#L221-L223
And I recreate it every at every mounting.
https://github.com/xcarpentier/rn-pdf-reader-js/blob/master/src/index.tsx#L225-L235

Also, I'm using a temp directory FileSystem.cacheDirectory.
As I said if I remove file at every unmount I wonder if I will not use FileSystem.documentDirectory.

I'm able to replicate it with Expo 35 with v0.5.3 on Android
https://snack.expo.io/@trinet/rn-pdf-reader-js

Can you please try with v0.6.0?

I think v0.6.0 fixed the issue.
Please let me know if this is not the case.

I can confirm that it is working in Android and iOS, many thanks!


Make Highlighter docs readable

Doesn't fix the docs, but at least puts it in a code block where needed

Thanks for the PR.
This is something that @Shazwazza has been working on, but the way the API docs are currently deployed, these changes will be overwritten during the next documentation release.
There is some discussion about this topic in

https://github.com/apache/lucenenet/pull/231
https://github.com/apache/lucenenet/pull/229#issuecomment-520831453 (scroll down to the "code samples" heading)

In general, we need to get the JavaToMarkdownConverter tool automated to the point we can "freeze" the documentation at Lucene 4.8.1 without the risk of important info being reverted if it is re-run and to flag any things that need to be dealt with manually, and then we will be able to go through and convert all of the code samples and platform-specific information to target C#/.NET.

Ah. I see.. I'll close this then, and let you guys work on a general fix :).


Create a rule for Oracle RPM for JRE installing JCE which failed linking

I run into the problem when installing JCE with the following specifics:
Flavor: oracle_rpm
Type: jre
Version: 8
Basically I think this wasn't never tested using RPM and JRE so the code expected to have the directory
/usr/java/latest/jdk/jre/lib/security (but that is only for JDK installs)
but when installing JRE the path  is only
/usr/java/latest/lib/security.
so my quick fix was to just create an if statement to handle JCE installs under JRE.
%w(local_policy.jar US_export_policy.jar).each do |jar|
jar_path = if node['java']['oracle_rpm']['type'] == 'jre'
::File.join(node['java']['java_home'], 'lib', 'security', jar)
else
::File.join(node['java']['java_home'], 'jre', 'lib', 'security', jar)
end
# remove the jars already in the directory
file jar_path do
action :delete
#not_if { ::File.symlink? jar_path }
end
link jar_path do
to ::File.join(node['java']['oracle']['jce']['home'], jdk_version, jar)
end
end
end

Any ideas on how to fix the specific problem I currently have since the tests failed on your side?
This was the configuration I am trying to get to work.
default['java']['jdk_version'] = '8'
default['java']['install_flavor'] = 'oracle_rpm'
default['java']['oracle_rpm']['type'] = 'jre'
default['java']['oracle_rpm']['package_name'] = 'jre1.8.0_112'
default['java']['jdk']['8']['x86_64']['checksum'] = '3197aa60a852b0410ceb8d2790405a7eef74622b2d2369121dd8d5d8e5388205'
default['java']['oracle']['accept_oracle_download_terms'] = true
default['java']['oracle']['jce']['enabled'] = true
default['java']['oracle']['jce']['8']['url'] = 'https://s3-us-west-2.amazonaws.com/optron-artifacts/jce/8/centos/jce_policy-8.zip'
default['java']['oracle']['jce']['home'] = '/usr/java/jre1.8.0_112/lib/security'
default['java']['oracle']['jce']['8']['checksum'] = 'f3020a3922efd6626c2fff45695d527f34a8020e938a49292561f18ad1320b59'

Do the tests run locally for you? The failed test look to be related with this change in the way jce behaves.

Closing due to age.


Will not run

Will not run for me, I get an error message. See attached screenshot

Figured out the problem, I forgot that I have software restriction policy software installed (to keep any drive-by software from installing itself) Once I unlocked it, the script worked fine.
https://i.imgur.com/Re5lXz7.png


Floating Pragmas

Is your feature request related to a problem? Please describe.
Not a problem, but a lousy solidity's code practice, Every contract has a floating pragma which is not recommended. It should be fixed.
Describe the solution you'd like
Fix the Pragmas
Describe alternatives you've considered
N/A
Additional context
Check this: https://t.co/PsMruMmE6t

Fixed PR #116  :)
Thanks


Compilation error

I am getting the following error when running catkin_make:
kuka-lwr/lwr_controllers/src/joint_impedance_controller.cpp:94:101: error:
no ‘void lwr_controllers::JointImpedanceController::commandConfiguration(const ConstPtr&)’
member function declared in class ‘lwr_controllers::JointImpedanceController’
void JointImpedanceController::commandConfiguration(const std_msgs::Float64MultiArray::ConstPtr &msg){

@marcoesposito1988 you renamed JointImpedanceController::command to JointImpedanceController::commandConfiguration in https://github.com/CentroEPiaggio/kuka-lwr/commit/7319f24d487e67862acc40a905540018092f01c6 without changing the header file
Edit: Actually JointImpedanceController::command is mentioned in other places also. @marcoesposito1988 why did you change it to commandConfiguration in lwr_controllers/src/joint_impedance_controller.cpp?

@nrontsis: you're right, sorry about that. It must have slipped when I separated the changes into different commits. Can you make a pull request with the fix or should I do it?
We renamed all commandConfiguration to command for uniformity with ros_controllers. It was discussed in #28 and implemented in #30

Thank you for the quick reply :+1:
Sure, I will make the pull request.

Thank you for the contribution! I'm glad to see the community growing ;)
Please tell us if we can help you getting started or if you have ideas for improvements (especially for a new user, e.g. documentation).

Thanks for reporting @nrontsis, actually I meant changing only the topic name, but Marco changed also the function name, I didn't see that.

But I see I also proposed to change the function name, sorry.
Again, travis will be of great help here... I'll try to figure out if there is some sort of a hack to use it with 14.04/Indigo.


Bw64Reader tell() returns incorrect position

The tell() function at line 253 of reader.hpp is supposed to return the current read position in the data chunk in terms of frames. It calculates this by subtracting the position of the data chunk from the read position in the file, dividing the result by the block alignment.
The data samples actually start at the data chunk position +8 bytes (4 for the chunk ID and 4 for the chunk size), so the value returned by tell() is slightly farther along the file than the actual position.
The effect of this is that the last couple of samples are skipped when reading a file as the sanity checking code on line 238 gets an incorrect position from tell().
The following test  exposes the issue
#include <array>
BOOST_AUTO_TEST_CASE(can_read_all_frames) {
  Bw64Reader bw64File("testfiles/noise_24bit_uneven_data_chunk_size.wav");
  BOOST_TEST(bw64File.numberOfFrames() == 13);
  std::array<float, 13> readBuffer;
  int readSampleCount = bw64File.read(readBuffer.data(), 13);
  BOOST_TEST(readSampleCount == 13);
}

Thanks a lot Richard. I just made a pull request which should fix this. The PR also addresses the other issue you reported.


add docs on the developer setup for vscode

add docs on the developer setup for vscode and relevant extensions and how to see the virtualenvs :)

https://js-next.github.io/js-ng/wiki/#/./devsetup


fix: add missing cleanup to background quoter

:tada: This PR is included in version 2.4.4 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Add GCP plugin

Adds a GCP plugin with Google Compute Engine support.
Resolves #390.

This is still a work in progress. I have some basic metadata and console output working, but not really complete. And Exec - based on https://cloud.google.com/compute/docs/instances/adding-removing-ssh-keys - is going to take some time. The goal is to have it as smooth as gcloud compute ssh.

I have a few outstanding items, but I think the code that's present is pretty complete

[ ] add tests
[ ] provide an expiration date for SSH public keys that are uploaded to a project/instance
[ ] check that this works for instances that explicitly prohibit project-wide SSH keys

I'm also open to suggestions on things that should be configurable, with supporting use-cases.

Could you paste the stree output here? Curious to see what this looks like.

stree output (after I fixed it)
gcp
└── [project]
    ├── compute
    │   └── [instance]
    │       └── console.out
    └── compute
        └── [bucket]
            ├── [prefix]
            │   ├── [prefix]
            │   └── [object]
            └── [object]

Updated, but I still have some TODOs to get to.

Pushed an update to revamp how we check and update SSH keys so it works with more configurations.

The key expiration doesn't do what I hoped it would (remove the key from the VM when it expires), so I left it out.


Improve Participation Form UX

[ ] widgets for individual times could be better suiting for changing the times around the original time. Maybe remove the date altogether and  actually automatically determine the date.
[ ] hide disabled time widgets in signup view or explain that they are disabled.

related to #1346


use kubectl-clusternet plugin to visit child clusters

Signed-off-by: Di Xu<EMAIL_ADDRESS>
What type of PR is this?
kind/documentation
What this PR does / why we need it:
kubectl-clusternet plugin v0.5.0  introduced new flags cluster-id and child-kubeconfig. This made easier to visit child clusters through parent cluster using CLI, instead of constructing a complicated and dedicated kubeconfig.
Which issue(s) this PR fixes:

partial mitigate #184
Special notes for your reviewer:

Codecov Report

Merging #214 (ebabefc) into main (b0fd5e9) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #214   +/-   ##
=====================================
  Coverage   8.37%   8.37%
=====================================
  Files         36      36
  Lines       4142    4142
=====================================
  Hits         347     347
  Misses      3767    3767
  Partials      28      28

Impacted Files
Coverage Δ

...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go
89.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0fd5e9...ebabefc. Read the comment docs.


meaning for spa_info_b in ref_model.py

I read the code, and got confused by the meaning of spa_info_b in ref_model.py.  I have read the ref-nerf paper, and understood the diffuse reflection and specular reflection, but still don't understand spa_info_b. I think it is kind of density, which is showed in figure 4 in the paper.
thank u very much!

thx


Handling missing values

In the issue #122 it was explained that handling missing values e.g. for XGBoost is possible, but not yet implemented. In the R port of LIME the same problem arose and, if I understand correctly, it was handled (see (this issue)[https://github.com/thomasp85/lime/issues/8] and (https://github.com/thomasp85/lime/commit/2d806431537dd9d95a4106ecd1ab00232853ad6a)[this fix]). Can the same be done for Python version?
A very important use case for this feature motivating its importance is as follows: in medical applications not always all measurements from dataset are available, due to privacy concerns, lack of time and/or money during the visit etc., and new vectors for classification often have missing values. Using LIME can satisfy legal requirements of model explainability, making less inpterpretable but highly accurate tree ensembles like XGBoost a very viable option.

I guess my comment back from 2017 still applies:

Anyway, this is not something I can see myself working on soon. If you are interested, we'll take a pull request : )
The fact that 3 years have elapsed since then and we got no other requests for this feature indicates to me that there is no pressing need for it.


proxy configs don't seem to be working for setting port

RancherOS Version: (ros os version)
v.1.5.0
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
bare metal
Running ros config export:
...(edited for brevity/privacy)...
rancher:
  docker:
    environment:
    - http_proxy=http://proxy.some.domain:80
    - https_proxy=http://proxy.some.domain:80
  environment:
    HTTPS_PROXY: http://proxy.some.domain:80
    HTTP_PROXY: http://proxy.some.domain:80
    http_proxy: http://proxy.some.domain:80
    https_proxy: http://proxy.some.domain:80
  network:
    http_proxy: http://proxy.some.domain:80
    https_proxy: http://proxy.some.domain:80

...
Also no_proxy and NO_PROXY seem to be getting ignored.
[root@somehost rancher]# docker logs 35c2b0881992
INFO: Arguments: --server rancher.some.domain --token REDACTED --ca-checksum d1fc7f25cd5e9e19a7d4067c853358fd5abe6b3acf9c465412c83366e7c02c17 --etcd --controlplane
INFO: Environment: CATTLE_ADDRESS=<IP_ADDRESS> CATTLE_INTERNAL_ADDRESS= CATTLE_NODE_NAME=bctlprancherw01 CATTLE_ROLE=,etcd,controlplane CATTLE_SERVER=rancher.some.domain CATTLE_TOKEN=REDACTED
INFO: Using resolv.conf: search noam.lnrm.net nameserver <IP_ADDRESS> nameserver <IP_ADDRESS>
INFO: rancher.some.domain/ping is accessible
INFO: Value from rancher.some.domain/v3/settings/cacerts is an x509 certificate
time="2019-03-21T19:40:08Z" level=info msg="Rancher agent version v2.1.7 is starting"
time="2019-03-21T19:40:08Z" level=info msg="Option etcd=true"
time="2019-03-21T19:40:08Z" level=info msg="Option controlPlane=true"
time="2019-03-21T19:40:08Z" level=info msg="Option worker=false"
time="2019-03-21T19:40:08Z" level=info msg="Option requestedHostname=bctlprancherw01"
time="2019-03-21T19:40:08Z" level=info msg="Listening on /tmp/log.sock"
time="2019-03-21T19:40:08Z" level=info msg="Option customConfig=map[roles:[etcd controlplane] label:map[] address:<IP_ADDRESS> internalAddress:]"
time="2019-03-21T19:40:08Z" level=info msg="Connecting to wss:///v3/connect/register with token REDACTED"
time="2019-03-21T19:40:08Z" level=info msg="Connecting to proxy" url="wss:///v3/connect/register"
time="2019-03-21T19:40:08Z" level=error msg="Failed to connect to proxy" error="dial tcp :443: connect: connection refused"
time="2019-03-21T19:40:08Z" level=error msg="Failed to connect to proxy" error="dial tcp :443: connect: connection refused"

Notice that rancheros seems to pick up it needs a proxy and does The Right Thing but then tries to use 443 even though our proxies don't forward HTTPS. The real problem is no_proxy seems to be getting ignored.

OK my coworker did what I thought would be the wrong thing and changed the clustername to garbage and then changed it back. Now all is working as advertised. Soooo I dunno. We installed from helm.


Fix issue in builtIn type node

Purpose
$subject
Fixes #23757
Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #23758 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23758   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57baba5...3ad6d7d. Read the comment docs.


x/build/cmd/release: update to FreeBSD-[amd64|386]-11_4 builder for 1.17 Beta

The cmd/release command is currently configured to use the freebsd-{amd64,386}-11_2 builders for the freebsd release targets.
FreeBSD 11.2 will not be supported by the time Go 1.17 is released. We should use FreeBSD 11.4 builders during the release.
/cc @golang/release

Using the latest "patch" release of the oldest "major" release of FreeBSD that we support for issuing Go 1.17 releases seems consistent with what we've done before, and SGTM.


Rename Core.cs to Base.cs or class Base to Core

Name of file is Core.cs but name of class inside the file is Base, it's naming mistake.
It's necessary to bring to one name.

Should be done when there are no open branches, as it will break the versioning


How does it compare to Rack::Attack?

From the readme, it seems like this gem is doing something very similar to Rack::Attack. Since Rack::Attack is an already well-known gem, and it can be used in any Rack application (not just for Grape), I think it wold be good to add to the readme what are some of the advantages of using Grape::Attack over Rack::Attack in Grape applications.

Yes good idea. Basically I considered using rack-attack for my own usage but I wanted something with a custom DSL for each of my grape endpoints. I also did not really care about white/black listing (yet). Finally I wanted to set custom HTTP headers with api limit values and usage.


Update Travis CI gates to support current Go version

The Kubernetes Go Client's CI Gates are currently using Go1.11. We should consider creating a new branch which updates the CI Gates for kubernetes-entrypoint so as to stay up-to-date and consistent with the latest Go client

Any thoughts on this?


PMID:27005325

ophthalmic acid CHEBI:84058 absent from cell
increased cellular gamma-glutamyl-2-aminobutyrate CHEBI:133093
abolished anaerobic cell population growth
normal growh on myxothiazol (MXT) CHEBI:25461
sensitive to MXT

ophthalmic acid absent from cell FYPO:0005881
increased cellular gamma-glutamyl-2-aminobutyrate lev FYPO:0005el FYPO:0005882
abolished anaerobic cell population growth FYPO:0005883
normal growth on myxothiazol FYPO:0005884
sensitive to myxothiazol FYPO:0005885

edit file: de7745210933ee0c76aa64dd9366ba2750ca5515
release: 33aa05df02539d433cfa8db6fa62fe5861d13072


Quick Start Example with "NegativeBinomialOutput" throw exception

System: Ubuntu 16.04
Python: 3.6.4
mxnet: 1.4.1
Code to reproduce:
import pandas as pd
url = "https://raw.githubusercontent.com/numenta/NAB/master/data/realTweets/Twitter_volume_AMZN.csv"
df = pd.read_csv(url, header=0, index_col=0)
from gluonts.dataset.common import ListDataset
training_data = ListDataset(
    [{"start": df.index[0], "target": df.value[:"2015-04-05 00:00:00"]}],
    freq = "5min"
)
from gluonts.model.deepar import DeepAREstimator
from gluonts.trainer import Trainer
from gluonts.distribution import NegativeBinomialOutput, StudentTOutput
estimator = DeepAREstimator(freq="5min", prediction_length=12, distr_output=NegativeBinomialOutput(),
                            trainer=Trainer(epochs=10))
predictor = estimator.train(training_data=training_data)

Exception:
DeferredInitializationError               Traceback (most recent call last)
/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in _call_cached_op(self, *args)
    802             cargs = [args[i] if is_arg else i.data()
--> 803                      for is_arg, i in self._cached_op_args]
    804         except DeferredInitializationError:

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in <listcomp>(.0)
    802             cargs = [args[i] if is_arg else i.data()
--> 803                      for is_arg, i in self._cached_op_args]
    804         except DeferredInitializationError:

/usr/local/lib/python3.6/site-packages/mxnet/gluon/parameter.py in data(self, ctx)
    493                                "instead." % (self.name, str(ctx), self._stype))
--> 494         return self._check_and_get(self._data, ctx)
    495

/usr/local/lib/python3.6/site-packages/mxnet/gluon/parameter.py in _check_and_get(self, arr_list, ctx)
    207                 "You can also avoid deferred initialization by specifying in_units, " \
--> 208                 "num_features, etc., for network layers."%(self.name))
    209         raise RuntimeError(

DeferredInitializationError: Parameter 'deepartrainingnetwork0_lstm0_i2h_weight' has not been initialized yet because initialization was deferred. Actual initialization happens during the first forward pass. Please pass one batch of data through the network before accessing Parameters. You can also avoid deferred initialization by specifying in_units, num_features, etc., for network layers.

During handling of the above exception, another exception occurred:

MXNetError                                Traceback (most recent call last)
/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in _deferred_infer_shape(self, *args)
    788         try:
--> 789             self.infer_shape(*args)
    790         except Exception as e:

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in infer_shape(self, *args)
    861         """Infers shape of Parameters from inputs."""
--> 862         self._infer_attrs('infer_shape', 'shape', *args)
    863

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in _infer_attrs(self, infer_fn, attr, *args)
    850             arg_attrs, _, aux_attrs = getattr(out, infer_fn)(
--> 851                 **{i.name: getattr(j, attr) for i, j in zip(inputs, args)})
    852             if arg_attrs is None:

/usr/local/lib/python3.6/site-packages/mxnet/symbol/symbol.py in infer_shape(self, *args, **kwargs)
    995         try:
--> 996             res = self._infer_shape_impl(False, *args, **kwargs)
    997             if res[1] is None:

/usr/local/lib/python3.6/site-packages/mxnet/symbol/symbol.py in _infer_shape_impl(self, partial, *args, **kwargs)
   1125             ctypes.byref(aux_shape_data),
-> 1126             ctypes.byref(complete)))
   1127         if complete.value != 0:

/usr/local/lib/python3.6/site-packages/mxnet/base.py in check_call(ret)
    251     if ret != 0:
--> 252         raise MXNetError(py_str(_LIB.MXGetLastError()))
    253

MXNetError: Error in operator deepartrainingnetwork0__mul1: [10:04:54] /home/travis/build/dmlc/mxnet-distro/mxnet-build/3rdparty/mshadow/../../src/operator/tensor/../elemwise_op_common.h:135: Check failed: assign(&dattr, vec.at(i)) Incompatible attr in node deepartrainingnetwork0__mul1 at 1-th input: expected [32,24], got [32,32,24]

Stack trace returned 10 entries:
[bt] (0) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x23d55a) [0x7f44332ff55a]
[bt] (1) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x23dbc1) [0x7f44332ffbc1]
[bt] (2) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x4ee78d) [0x7f44335b078d]
[bt] (3) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x5587d6) [0x7f443361a7d6]
[bt] (4) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x762338) [0x7f4433824338]
[bt] (5) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x2be2cea) [0x7f4435ca4cea]
[bt] (6) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x2be5658) [0x7f4435ca7658]
[bt] (7) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(MXSymbolInferShape+0x15ba) [0x7f4435c140ca]
[bt] (8) /usr/local/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(ffi_call_unix64+0x4c) [0x7f44791201da]
[bt] (9) /usr/local/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(ffi_call+0x26b) [0x7f447911c5cb]

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
<ipython-input-6-7512b68a283e> in <module>()
      1 estimator = DeepAREstimator(freq="5min", prediction_length=12, distr_output=NegativeBinomialOutput(),
      2                             trainer=Trainer(epochs=10))
----> 3 predictor = estimator.train(training_data=training_data)

/usr/local/lib/python3.6/site-packages/gluonts-0.1.1-py3.6.egg/gluonts/model/estimator.py in train(self, training_data)
    187     def train(self, training_data: Dataset) -> Predictor:
    188
--> 189         training_transformation, trained_net = self.train_model(training_data)
    190
    191         # ensure that the prediction network is created within the same MXNet

/usr/local/lib/python3.6/site-packages/gluonts-0.1.1-py3.6.egg/gluonts/model/estimator.py in train_model(self, training_data)
    180             net=trained_net,
    181             input_names=get_hybrid_forward_input_names(trained_net),
--> 182             train_iter=training_data_loader,
    183         )
    184

/usr/local/lib/python3.6/site-packages/gluonts-0.1.1-py3.6.egg/gluonts/trainer/_base.py in __call__(self, net, input_names, train_iter)
    256
    257                             with mx.autograd.record():
--> 258                                 output = net(*inputs)
    259
    260                                 # network can returns several outputs, the first being always the loss

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in __call__(self, *args)
    538             hook(self, args)
    539
--> 540         out = self.forward(*args)
    541
    542         for hook in self._forward_hooks.values():

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in forward(self, x, *args)
    905             with x.context as ctx:
    906                 if self._active:
--> 907                     return self._call_cached_op(x, *args)
    908
    909                 try:

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in _call_cached_op(self, *args)
    803                      for is_arg, i in self._cached_op_args]
    804         except DeferredInitializationError:
--> 805             self._deferred_infer_shape(*args)
    806             cargs = []
    807             for is_arg, i in self._cached_op_args:

/usr/local/lib/python3.6/site-packages/mxnet/gluon/block.py in _deferred_infer_shape(self, *args)
    791             error_msg = "Deferred initialization failed because shape"\
    792                         " cannot be inferred. {}".format(e)
--> 793             raise ValueError(error_msg)
    794
    795     def _call_cached_op(self, *args):

ValueError: Deferred initialization failed because shape cannot be inferred. Error in operator deepartrainingnetwork0__mul1: [10:04:54] /home/travis/build/dmlc/mxnet-distro/mxnet-build/3rdparty/mshadow/../../src/operator/tensor/../elemwise_op_common.h:135: Check failed: assign(&dattr, vec.at(i)) Incompatible attr in node deepartrainingnetwork0__mul1 at 1-th input: expected [32,24], got [32,32,24]

Stack trace returned 10 entries:
[bt] (0) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x23d55a) [0x7f44332ff55a]
[bt] (1) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x23dbc1) [0x7f44332ffbc1]
[bt] (2) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x4ee78d) [0x7f44335b078d]
[bt] (3) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x5587d6) [0x7f443361a7d6]
[bt] (4) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x762338) [0x7f4433824338]
[bt] (5) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x2be2cea) [0x7f4435ca4cea]
[bt] (6) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x2be5658) [0x7f4435ca7658]
[bt] (7) /usr/local/lib/python3.6/site-packages/mxnet/libmxnet.so(MXSymbolInferShape+0x15ba) [0x7f4435c140ca]
[bt] (8) /usr/local/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(ffi_call_unix64+0x4c) [0x7f44791201da]
[bt] (9) /usr/local/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(ffi_call+0x26b) [0x7f447911c5cb]

The bug is in the expand_dims here, which should just be omitted.
I'll open a PR as soon as I have tests in place for this.

Thanks for reporting this! The fix will be included in the next release


Incremented sleep variable in the work_handler

The static int sleep is set as 0 and then it's used in wait_event_interruptible function as a condition sleep != 0. This check will never be true as the sleep is always 0. Therefore, it needs to be !=0, so needs to be incremented in work_handler.

Fixes https://github.com/PacktPublishing/Linux-Device-Drivers-Development/issues/6


misspelled function name

https://github.com/InstituteforDiseaseModeling/PACE-HRH/blob/66fbb93cde930b31abf4c7d42564dab3b280e76d/pacehrh/vignettes/technical-notes.Rmd#L72
Function 'setGlobalConfig()' does not exist. Should it have been 'loadGlobalConfig()'?

Actually, setGlobalConfig() does exist:
# Note: this function does not check that the file path is valid.
# This function is intended to support unit tests to force the system to
# initialize based on a different configuration than is in globalconfig.json.
setGlobalConfig <- function(inputExcelFilePath = "./config/model_inputs.xlsx"){
  if (!is.blank(inputExcelFilePath)){
    GPE$inputExcelFile <- inputExcelFilePath
    GPE$globalConfigLoaded <- TRUE
  }
}

It's defined in pace_config.R. It is not, however, an exported function, so it has to be access as pacehrh:::setGlobalConfig() (triple colon operator).

Hi @celiot-IDM, thanks for the clarification. Should we update the technical notes to include this clarification as well? I suspect that future users are likely to name their input files differently from "model_inputs" especially if they have different versions of input files for different purposes. They may find this command particularly useful.

I'll have to think a bit about this, @rhanIDM. The implementation will cause strange side-effects outside the limited context of unit tests, so will need a bit of work to get right as a publicly available function.

Both setGlobalConfig() and loadGlobalConfig() are private functions currently intended for supporting unit tests only. Will open a new issue exploring best practice for a user to load alternative input file to global environment.


Magnetizer isn`t working on curios

When I try to use the magnetizer in the Curios slot, its slot does not appear.
What do I have to do?

just tested with the new update (which should not impact in the curios implementation), and worked correctly
are you sure both have installed curios and tested properly? @kokloler @DarkBRrvv

If you'd like, I can call you on discord to show you what I'm doing. My discord account is @kokloler

@kokloler I sent you a friend request

fixed in latest update of 1.19.2


code problem with the dialogue

how do i fix this?
i might be dumb

remove the "{" at line 120, its not being used

you're placing the "{" behind where it should actually be
the "{" has to go in front of the else if statement for it to work
also your code isn't properly indented to fit inside the else if statement

so like this?

so like this?

it should be like this:
else if (PlayState.SONG.song.toLowerCase()=='stretch-roll') {     portraitLeft = new FlxSprite(-20, -40);     rest of the code, you get the idea, add the missing 4 spaces/tabs     portraitLeft.visible = false; }
also you have duplicated the stuff

ok wait
ill try it

it works yay
ill tell if there are more issues

ok. now the crashes everytime a dialogue is like loading

ill just open a new issue


Finish weather update function

Right now we're using a facade and coordinates do not yet exist. Time to implement them!

[ ] Do thing 1
[ ] Do thing 2


How to disabled submit button on page init

Vue Version:Vue 2.0
Vue-Validator Version:v3.0.0-alpha.2
when page init $validation is empty object,if i bind :disabled="reasonInvalid" to submit button,this can not work on page first init.
How can I solve this problem?

This demo can helps a little: vue-validator/examples/timing/index.html
But: demo have some issue. If one of the fields is a valid - submit button will become active.
Maybe you should add array to the data with all your validity fields, and mark them as valid/invalid durings validation (inside handleInput method), and unlock your submit button after all fields will become isValid: true

@gavrashenko  I think vue-validator need provider an API that can be invoked before submit it to obtain the validation results,this is be best practice.


NMZ overlay active in KBD private instance

KBD lair is the same region as NMZ, so the points overlay is showing up

The fix for this was backed out in ff7f06dffdda3f20bf12214a715c9adc29251a4c as it is breaking the notifications.


Adding CTA Wave Project

Here's the CTA Wave Homepage: https://cta.tech/Resources/Standards/WAVE-Project Industry Standards group that's doing great stuff.

@krzemienski I'm adding this one to get started and confirmed I'm doing it the right way for your project. I also opened an issue with some category suggestions. Once this is resolved and merged and you've had a chance to chime in on the categories issue I can start adding in some more links.
Have a good weekend!

@krzemienski Saw the comment, thanks! Also, appreciate you merging this. More to come.


Use target class version for proxy

Uses the classfile version of the proxy to avoid confusion on different JDK in CLI and build image.

@aclement See https://github.com/spring-projects-experimental/spring-native/pull/866#issuecomment-876368234.