Clarification on host folder specification

All these questions are for container-mode :)
What is the purpose of mapping a volume when starting the plugin...?
docker run -d \
    -v /run/docker/plugins/:/run/docker/plugins/ \
    -v /path/to/store/json/for/restart/:/var/lib/docker/plugin-data/ \
    -v /path/to/where/you/want/data/volume/on/host/:/path/to/where/you/want/data/volume/ \
        cwspear/docker-local-persist-volume-plugin

and have to do it again when using it...
docker volume create -d local-persist -o mountpoint=/data/images --name=images

The tests I made, I skipped the first -v /path/to/where/you/want/data/volume/on/host/:/path/to/where/you/want/data/volume/ and all seemed to work well.
I re-re-read the docs and I could not understand that.
Thx

The purpose, as mentioned in #32, is to persist the data.
It will work, but the data will disappear after you destroy the local-persist container without this.

Ok. I have to try it...
But what is the relationship between "/path/to/where/you/want/data/volume/on/host" and "/data/images"?

Does the 2nd have to be a subfolder of the 1st one?
Is the 1st one the "root" of the folders?

Thx

They don't have to be related or a subfolder or anything.
You can store files anywhere on the host and map it to anywhere in the local-persist container.
I generally will map them to the same directory, i.e. -v /data/images/:/data/images/, but you could do /home/joaocc/Pictures/my-awesome-project/:/data/images/.
In both cases, when creating a volume, the part on the right is what's important for the mountpoint:
docker volume create --driver=local-persist --opt mountpoint=/data/images/ --name=my-images

But where the actual physical files will persist on the host, that's the left side.

Hi,
I'm sorry to insist, but I am not sure I am explaining myself correctly.
Let me give a concrete example.
docker run -d \
    -v /run/docker/plugins/:/run/docker/plugins/ \
    -v /path/to/store/json/for/restart/:/var/lib/docker/plugin-data/ \
    -v /backups-on-host/general/:/all-backups/ \
        cwspear/docker-local-persist-volume-plugin

docker volume create -d local-persist -o mountpoint=/backups-on-host/specific --name=bak-specific

...docker run ... -v bak-specific:/my-backups... some-container

From what I understood and what I tried on one of the older versions, ```-v /backups-on-host/general/:/all-backups/´´´ didn't do anything.
Inside the some-container, I would only see a "/my-backups".
In this case, why would I need to add ```-v /backups-on-host/general/:/all-backups/´´´?
Thanks and once again I apologise for not having been clearer before.

The mountpoint needs to be a subdirectory of the right side of the -v in your local-persist container, or the data won't persist.
docker volume create -d local-persist -o mountpoint=/all-backups/specific/ --name=bak-specific

(Or it could be the directory itself. /all-backups/ works for a mountpoint, too)

I generally will map them to the same directory, i.e. -v /data/images/:/data/images/, but you could do /home/joaocc/Pictures/my-awesome-project/:/data/images/.
This doesn't work for me; because, when docker asks for the host path, the driver container returns "/data/images"; the file then ends up being stored on the host under the same path, not in /home.

@miracle2k then just use -v /path/to/files:/path/to/files (the same path on both sides).

@CWSpear That's what I am doing. I think the making an alias path work though would be a nice improvement; maybe by defining the "real" host path via environment variable.


Mapper Lifting (Graph to Hypergraph)

In this PR, we implement a lifting from graphs to hypergraphs via the "Mapper on Graphs" construction as depicted in Figure 30 [1], which can be enriched with the structure of a combinatorial complex. It operates in the following way:

Begin with graph $X$ and choice of filter function $g: X^{(0)}\to [a,b]$.
The algorithm creates $\mathcal{U}$, a cover of $[a,b]$ based on parameters resolution (number of intervals) and gain (proportion overlap between neighboring intervals).
For $U\in \mathcal{U}$, the set of vertices $g^{-1}(U)$ induce a subgraph $X_U$ of $X$; together, these pullback sets cover $X^{(0)}$.
For each $U$, "cluster" $X_U$ into its connected components. Each connected component is a hyperedge in the lifted topology.
Additionally, each edge in $X^{1}$ is a hyperedge in the lifted topology. This could allow for the enrichment of the hypergraph with the structure of a combinatorial complex, if desired.

The 1-skeleton of the nerve of the resulting cover would give the results of the classic Mapper algorithm for graph simplification with filter function $g$.
By default, the function $g$ is the first projection of the graph Laplacian embedding of the unweighted edge adjacency matrix of $X$, as this may be defined on all graphs and is known to capture topological information. However, we also have alternative filters that can be selected by the user. Some require that the graph $X$ be enriched with additional features. Users may define other filter functions $g$ dependent on what features their data contains in the form of a lambda function.
[1] Hajij, M., Zamzmi, G., Papamarkou, T., Miolane, N., Guzmán-Sáenz, A., Ramamurthy, K. N., et al. (2022). Topological deep learning: Going beyond graph data. arXiv preprint arXiv:2206.00606.
This is joint work between Halley Fritze and Marissa Masden.

Hello @hfr1tz3! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at<EMAIL_ADDRESS>so I can share access to the voting form. In your email, please include:

your first and last name (as well as any other team members)
the title of the method you implemented
the input domain of the method you implemented
the output domain of the method you implemented
your pull request number (#48)

Before July 12, make sure that your submission respects all Submission Requirements laid out on the challenge page. Any submission that fails to meet this criteria will be automatically disqualified.


Column view gets stuck on "Processing..." when clicking on the root of a large codebase in the tree view

This is happening on a sqlite DB that is 500+ MB.

I get this warning when clicking on items in the tree view:
/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/rel…:870 Unhandled rejection RangeError: Maximum call stack size exceeded
    at Function.map (file:///home/jono/nexb/tools/develop/aboutcode-manager/assets/js/jquery-2.1.3.min.js:2:3574)
    at Function.mapToAttributeValues (file:///home/jono/nexb/tools/develop/aboutcode-manager/assets/js/aboutCodeBarChart.js:67:18)
    at Model.aboutCodeDB.FlattenedFile.findAll.then (file:///home/jono/nexb/tools/develop/aboutcode-manager/assets/js/aboutCodeBarChart.js:56:49)
    at Model.tryCatcher (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/promise.js:691:18)
    at Async._drainQueue (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/release/async.js:17:14)

printWarning @ /home/jono/nexb/tools/develop/aboutcode-manager/node_modules/sequelize/node_modules/bluebird/js/rel…:870

The issue is that the sqlite file was created with a previous version of Aboutcode Manager. In between those two versions the data schema changed. Since the sqlite file was first created with an AboutCode Manager that still used dejacode_url and the new table uses reference_url, the query will error. The DataTables message "Processing..." is misleading since the query has been terminated with an error. The short fix is to use the same version of AboutCode Manager that you used to create the sqlite file. I believe that is ec7cf5e.

This can be closed. A crude fix has been done in #228 but will be addressed further in #230


Discussion:  Should we be using random numbers in our tests?

(not urgent.. this can wait until 2022 :slightly_smiling_face: )
I fear that using random numbers in our tests could lead to intermittent (and hence hard-to-debug) unittest failures.
Let's not worry about this now, though!  We can discuss later...

Yea agree with can deal with it later.
Pro:
Part of me likes having random numbers as it is more likely to cover cases that we havent thought of
Con:
as you say above - can be a problem with hard-to-debug failures

I think this unit test failure just now in the github CI (that I haven't seen before, and has nothing to do with the PR) might be to do with random numbers!

Perhaps 'seeding' them is a good comprise?

Perhaps 'seeding' them is a good comprise?

yeah, sounds good to me!
I'd guess we'd need to use the new(ish) np.Generator, one Generator per test (maybe?) to guarantee that the test data remains the same, no matter what order the tests are run in


Lite Only Opens In Its Directory

A bit difficult to describe it well in the title, but essentially I'm not able to open Lite from the command prompt outside of where the data directory exists. When I installed the source, even though it contained a different data folder, I was indeed able to open Lite, even though it didn't use the data folder which came with the source. Anywhere else, however, the program would simply not launch. No errors would be displayed, no warnings, no logfile from as far as I can tell. From as far as I can tell, this is due to core.init, but I've not been able to fix the problem as of now. Any suggestions?
Operating System: Windows

Update: After some more testing, it's clear that it's from the initial lua string in the main.c file. Here's the standard output:
Error: cannot open data/core/start.lua: No such file or directory
stack traceback:
        [C]: in function 'dofile'
        [string "local core..."]:5: in function <[string "local core..."]:2>
        [C]: in function 'xpcall'
        [string "local core..."]:2: in main chunk

I tried modifying the string, however, the program seems to silently crash whenever I change it. Any reason why?

Hi, thank you for your investigations. Thank to your message I understood the problem. The following change is needed in src/main.c:
     "  HOME = os.getenv('HOME')\n"
 #endif
     "  local prefix = EXEFILE:match(\"^(.+)[/\\\\]bin[/\\\\][^/\\\\]+$\")\n"
-    "  dofile((prefix and prefix .. '/share/lite-xl' or 'data') .. '/core/start.lua')\n"
+    "  local exedir = EXEFILE:match(\"^(.+)[/\\\\][^/\\\\]+$\")\n"
+    "  dofile((prefix and prefix .. '/share/lite-xl' or exedir .. '/data') .. '/core/start.lua')\n"
     "  core = require('core')\n"
     "  core.init()\n"
     "  core.run()\n"

but, since a .c file is modified a re-compilation is needed.
I going to include the fix and publish a new hotfix release today I home.

Huh, that's interesting. I updated the main.c and compiled it myself, however, the program doesn't seem to be launching anymore.
D:\Projects\lite-xl\build\src>.\lite

D:\Projects\lite-xl\build\src>.\lite > output.txt

D:\Projects\lite-xl\build\src>type output.txt

D:\Projects\lite-xl\build\src>

I was able to compile and run before the change. I was also able to do that when adding print statements in the C string, yet whenever I modified the regex or added the local exedir, the program seems to simply not open anymore, even though it compiles. I'm interested in whether you'll encounter similar problems or not. It could be because I'm on Windows and I updated the build system so that it uses the sdl wrap rather than the linux package. I'm a bit busy now so I can't dig into it now sadly, but I'll be looking forward to the next release. Thanks!

Please check again the master branch. I have fixed some stuff and tested extensively on Windows. I am preparing a release.

Should work now with the new release. Waiting to have some feedback before closing the issue.

I am pretty much positive that this bug was already solver with 1.16.2 and 1.16.3 is already out.

Oh, I apologize. I should've totally tested it, but I was busy at the time and I forgot to go back to the email. I just downloaded the latest version, and when running it now, I get this error message written in error.txt, regardless of the current directory:
Error: error loading module 'core.command' from file 'C:\Program Files\lite/data/core\command.lua':
	C:\Program Files\lite/data/core\command.lua:28: too many C levels (limit is 200) in function at line 27 near '1'
stack traceback:
	[C]: in ?
	[C]: in function 'require'
	C:\Program Files\lite/data/core\command.lua:2: in main chunk
	[C]: in function 'require'
	C:\Program Files\lite/data/core\command.lua:2: in main chunk
	[C]: in function 'require'
	C:\Program Files\lite/data/core\command.lua:2: in main chunk
	...
	[C]: in function 'require'
	C:\Program Files\lite/data/core\command.lua:2: in main chunk
	[C]: in function 'require'
	C:\Program Files\lite/data/core\command.lua:2: in main chunk
	[C]: in function 'require'
	C:\Program Files\lite/data/core\command.lua:2: in main chunk
	[C]: in function 'require'
	C:\Program Files\lite/data/core/init.lua:348: in function 'init'
	[string "local core..."]:8: in function <[string "local core..."]:2>
	[C]: in function 'xpcall'
	[string "local core..."]:2: in main chunk

I'd look into it further but that's all the time I have for now. Thank you for helping out. I really appreciate it!

Thank you for testing and for reporting this problem.
Actually the error you see is unrelated to the problem you reported in this issue. Looking at the stack traceback it doesn't make a lot of sense to me unless you modified some of the lua files bundled with lite-xl.
I would suggest making a new test by deleting any previous install of lite-xl and remove any plugin you may have in:
%USERPROFILE%/.config/lite-xl/plugins

Oh, you're absolutely on the mark on that one. I updated Lite by replacing the files, but I suppose that left some of the old files untouched and that could've messed with the application. Thank you for your help! I can't make promises but I'll certainly try to fit the time to make contributions back, you totally deserve any support you can get.


getting same hidden states value from Wav2Vec2 for my dataset

Hey @EvelynFan ,
I tried to train the model on my custom datasets, but Wav2Vec2 is producing same hidden states value
for all audio frames,
Here is the reference,
torch.Size([1, 88800])
hidden_states: tensor([[[-0.0847,  0.0599, -0.0042,  ...,  0.1818,  0.0301, -0.0014],
         [-0.0847,  0.0599, -0.0042,  ...,  0.1818,  0.0301, -0.0014],
         [-0.0847,  0.0599, -0.0042,  ...,  0.1818,  0.0301, -0.0014],
         ...,
         [-0.0847,  0.0599, -0.0042,  ...,  0.1818,  0.0301, -0.0014],
         [-0.0847,  0.0599, -0.0042,  ...,  0.1818,  0.0301, -0.0014],
         [-0.0847,  0.0599, -0.0042,  ...,  0.1818,  0.0301, -0.0014]]],
       device='cuda:0')

Can you suggest some way out?
Thanks.

i have same question

The same.


[tokenomics] holders of locked-up SUI tokens can stake them, even before they vest

Depends on issue #2458


Add update instructions for RPM/DEB and bin distribution

This requires the paths.html page available with #210

I added the links for the DEB package on the download pages. This is subject to our ability of building the DEB and RPM package for snapshot though /cc @richardcloudsoft

@aledsage Comments addressed


Add (de)serialization guide, fix #26

the CI code depends on either https://github.com/lempiji/md/pull/1 and/or https://github.com/lempiji/md/pull/2
I noticed it was not possible to use the ionSerializer properly with custom deserializers like it is done internally in all the xxx2ion functions, because the ionPrefix variable was not public. So for now I simply made it public.
This is in docs-src in case we want to add a proper auto-generated docs folder in the future, possibly using mkdocs or other tools, with links to API docs too.

off-topic: can I get a new release? (since #31 is in now)

OMG! Thank you so much! I am very happy to see this documentation!


Lab3 letter frequency

Fixes #63
Changes proposed in this PR:
.Implemented letter frequency
.Write a function that returns a sorted slice of strings with elements "{key}:{val}"
.Add unit test

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #69   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           7      8    +1
  Lines         112    128   +16
=====================================
+ Hits          112    128   +16

Impacted Files
Coverage Δ

03_letters/vinilapeddireddy/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f17728...82f67d6. Read the comment docs.

Once you have approval you should be able to just click the Update branch button and without further reapproval merge.


Cherry pick previous commits in collab authn branch

Cherry pick previous commits in collab authn branch:
ca6d85ec2  Add CRD validation functions for authn v2 policy (#13413)
2b5015bab Update API (#13405)
fb4b0a170 Add new authN policy CRD

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


k8s probe: Fix a panic (nil pointer deref) when a cronjob has never been scheduled

in which case cj.Status.LastScheduled is nil.
New behaviour is to omit it from the map (and therefore the display) if it has never been scheduled.
Fixes https://github.com/weaveworks/scope/issues/2783

Tested with and without a value for LastScheduled.


props and states

Hey looked I'm confused here,
I want to pass states as props here, but I couldn't figure out how can I transform function to class here. Any little help?

Hey,
I've exported that file as a variable because the starter app doesn't need anything more complex.
For your case, you'll want to convert this to a export a stateful component and update the main function.
Export Stateful Component
import { h, Component } from 'preact';
//...
export class App extends Component {
  // ...
  render(props, state) {
    return (
      <Layout>
        // ... <Router>....</Router>
      </Layout>
    );
  }
}

Update Main Import
Change this line to:
elem = render(h(App), document.getElementById('root'), elem);
// or
elem = render(<App/>, document.getElementById('root'), elem);

I have a real-world example using this starter kit. You can look at colors-app to see how I've done what you're after.
Hope that helps!

Yup that will help Thanks Luke!


mmlink: integrate argsfilter

Changes --socket-id short option from -S to -s so as not to
collide with argsfilter (which uses -S for PCIe segment).
Signed-off-by: Tim Whisonant<EMAIL_ADDRESS>

Coverage increased (+0.03%) to 68.206% when pulling 6592e86a261edc589a866b0c1f8fccea581d7d1c on tswhison/mmlink_args into f4a5e52375523a54f0553394cc24ded7bd131768 on master.


Made String and Buffer types templates with DNA base

This allows such types to be used in Vector (without DNA_COUNT() specialization)

:+1:  lgtm!


I18n attribute added for Spanish language

An attribute called status_message was added in the languages
I18n branch updated with master

Will update with remaining locales later.


LOGIN PAGE ISSUE RESOLVED

Hey @anuragverma108
Status: Resolved
The issue with the login button not redirecting to login.html has been resolved. The JavaScript code was updated to include an event listener that handles the redirection correctly.
please bro review and accept it
thank you

hey @anuragverma108 please add hacktoberfest, hacktoberfest-accepted label to my pull request and accept and merge it

@Parth04exe Please resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

@rahulkhandait-sde can you tell me how to do this i am new in github


Configure hound to ignore /// comment style

What does this PR do?
Sassdoc uses a triple dash comment style to mark its content.
Hound keeps barking at it every time a pr is posted that involves any documentation.

I got this merged in and it seems to work. I pushed up https://github.com/thoughtbot/neat/pull/536 with no comments from the hound on the missing space

Thanks, @whmii!


feat: Sortable chats in admin panel

Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[ ] Testing: Have you written and run sufficient tests for validating the changes?
[ ] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description

Enhances the Admin Panel dashboard by giving the ability to sort chats within the User Chats Modal. This makes management and monitoring of users easier.

Changed

Changed Chat 'Name' column header text to 'Title' to match property name.
Updates Admin Panel User Chats Modal to allow sorting each column in ascending or descending order
Added "Updated at" column to the Admin Panel User Chats Modal.

Screenshots or Videos
https://github.com/open-webui/open-webui/assets/48695279/f1036e38-fc1d-4b64-b584-14a39888bb74

We'll have to refactor this when we eventually add pagination enh but LGTM for now!


Try to construct an Arab name parser using GPT and Efraim's explanation

Find the relevant repository and open an issue.
Give a blank GPT system instructions using Efraim's explanation and an Arabic name.

Waiting for @sinairusinek to complete #185

#185 is ready

[ ] Prepare local LLM for inferencing
[ ] Prepare prompts using https://docs.google.com/spreadsheets/d/10rvo4x96gNkL_19xrtjfxKIMSYUW8-nXkmQ3PukswGY/edit?gid=896669129#gid=896669129
[ ] Prepare testset using Lev @sinairusinek


Removed id parameter from Create and Update actions

As per the discussion in PR #3645 the id parameter has been removed from the create and update actions.

@mwvdev,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.
It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@mwvdev, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot


Opening a chart from the dashboard should not make the chart unavailable in the chart menu

When a chart is opened from the dashboard and consequently closed again, the chart is unavailable for selection in the chart menu.
For example when I click on the dashboard item "Renewables" the chart "Renewability of final demand" opens. When I then close the chart and go to "See more charts" or to the "Change chart" button in the chart that is already on display in the front-end, "Renewability of final demand" is unavailable for selection.

I suppose that once you close a chart from the dashboard, is still 'open' somewhere in the background. Can this be fixed?

@antw I think it is important to pick this issue up before tomorrow's deploy. Is that possible

I'll see what can be done.


Replace pydantic_encoder with to_jsonable_python

pydantic_encoder is deprecated in Pydantic v2 and triggers a DeprecationWarning.
I'm not sure what's happening with the test failures, they happen for me on the main branch too (presumably some newer dependency versions have changed behaviour slightly).

Thanks


PropertySheets: Intermittent Explorer Crashes

This issue has been raised from #177.
Reproduction Steps

Register a property sheet shell extension for a file type or class of file.
Open a number of sheets, ideally 8-10.
After about one minute, explorer will crash.

Root Cause
My hypothesis is the following:
MSDN notes that for shell property sheet extensions, we must use a parent reference count:

Assign the variable that holds the handler's reference count to the pcRefParent member. This practice prevents the handler object from being unloaded while the property sheet is still being displayed. (Reference

The implication is that if we do not use a parent reference count, explorer could actually unload the shell extension while the sheet is still visible to the user. This sounds like a very likely root cause for the issue. One reason I believe this is that attaching a debugger and observing the crash, I see this:

Fairly explicit suggestion that the shell is trying to call a callback which has been disposed (i.e. the shell extension has been unloaded).
If this is the case, the fix is to maintain the reference count of the shell extension, and ensure the property sheet has access to this. This is actually quite complicated - we do not manually manage the reference count (i.e. by implementing IQueryable), .NET does this for us. So investigation is required.
Notes

This is not fixed by #213 (confirmed in the notes for issue #177).

So investigation is required.

I would like to try to help to reduce your investigation time, see if maybe this is kind of helpful for you:

callbackOnCollectedDelegate MDA
Diagnose Errors with Managed Debugging Assistants
gcManagedToUnmanaged MDA
gcUnmanagedToManaged MDA

Good luck with this!


Closes: #1 Updated Script

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

rerun

@gauntface


Document running InfluxDB as a Windows service

Need a set of instructions for InfluxDB on Windows for setting it up and running it as a service....
Telegraf  example: https://docs.influxdata.com/telegraf/v1.18/administration/windows_service/

Checking with the team, but it looks like this is not currently supported for InfluxDB 2.x.

Closing as possible duplicate of #1060.


Jitter issue when using the region editing area and animation tree together in sprite2D

Tested versions
godot 4.3dev2
godot 4.2.1
System information
win11 12th Gen Intel(R) Core(TM) i7-12650H   2.30 GHz
Issue description
The region of sprite2D was used in AnimationPlayer_ Rect, where the idle animation has 6 frames and the running animation has 8 frames, this issue occurs when using the animation tree and region editing area together. If the region is not used, using the frame of the image directly will not cause any problems. So I guess that if the editing area size of idle is also equal to 8 frames, there may not be any issues. I don't know if there is any solution.
Steps to reproduce

Use the region of sprite2D to select the editing area and create an animation

Use the animation tree to use AnimationNodeStateMachine and create a Move animation (add blendspace1D). Select the idle animation in the middle, select the running animation on the left and right sides, and then connect start and move

Minimal reproduction project (MRP)
Knight.zip

In each animation, make sure to set the Update Mode of region_rect track to Discrete (the one using 3 dots as its icon).

Sorry, after following your prompts to adjust, I encountered an exception and there was a flicker on the animation editing interface
https://github.com/godotengine/godot/assets/44998695/58133116-3506-4504-8089-a462b468d930

In this case, change the Blend Mode of Move state in your AnimationTree:

😂Thank you very much for your help


CRI: Properly restore IP information for userns sandboxes

Fixes: #10363
Due to when we setup networking for userns containers (AFTER the OCI runtime has ran), this was causing the underlying object for the sandbox to not have the IP information saved in the metadata extension. Because we're trying to move away from modifying the underlying container object for sandboxes (or even just keeping around a reference to it), I don't want to update the underlying container afterwards to include this. So, to remedy this we can update the sandboxes metadata after network setup runs for userns containers, and then our recovery logic just needs to be altered a bit.
Our recovery logic already checks containers with the sandbox label first, and then checks our shiny new sandbox store. Our IP information is stored in the sandbox store objects, so all we need to do is check if it exists, and if so and we already found a container for it (although without the IP information) then just update the sandbox in our in-memory store.

/retest

@fuweid Sorry for delay, un-drafted this and added an integration test. Only some of the CI machines support userns in full so I added a log so we can grep for if the testcase is actually being hit. "restart_linux_test.go:36: adding userns pods for containerd restart test"

/retest

Removing from v2.0 milestone as staled


feat: add option merge to command create

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Other information:

Usage: vue create --merge .
This option works like the --force option.

I don't feel like adding this feature. Because the end result is still unpredictable and the directory could still get messed up.
A warning on the overriding might suffice.

What I want to do with this option is auto generating projects by some tools based on vue-cli.
The tool I used needs to write some files before calling vue-cli.
I just want to skip the prompt, and merge files immediately.

I agree with @sodatea here. If you want to, you can create a new folder and merge those 2 folders with some other tools locally.

By default, without any cli options, if the target dir is existing, @vue/cli will prompts the user to either delete the target folder or merge with it.
And there is an option --force to skip the prompt and delete the target folder. So I just want to add an option --merge to skip the prompt and merge with the target folder.
Actually I'm writing a tool which combined @vue/cli with a custom package manager. I need to write some info into the package.json in the target folder first. And during the creation of the target project, these info will be used by the custom package manager to installing deps.
So I just want this --merge option to skip the prompt and automate the whole creation procedure.

That actually sounds better. If you are okay, we can merge this @sodatea

This is still failing. You think there's an issue with your code?
FAIL<EMAIL_ADDRESS>

Never mind, it has been happening on dev too


The checkbox is not aligned on Account > Notifications

The checkbox is not aligned on Account > Notifications. The text should be next to the checkbox.

Done


rebuild resnet block based approach

see also #156

Kokoro tests failed, but due to unrelated Transformer changes (fixed in #171). I've built the ResNet target from this branch locally, and it builds correctly with a very recent tool chain. As a result, I'm going to squash & merge this. Thank you @brettkoonce !


Check contract for valid addresses before deployment

Issue To Be Solved
Sometime contracts get deployed with addresses that were either invalid or for the wrong network. For example, this could happen from a developer building on testnet and forgetting to update the addresses in their contract to mainnet.
Suggested Solution
During deployment of contracts in the CLI, it would be nice to check the addresses in the contract to see if they are invalid or for the wrong network and display an error to the developer.

Closing this since contract deploy seems to fail already with invalid addresses.


Add milmove-app-browsers Dockerfile

Add Dockerfile for creating a milmove-app-browsers image with chrome installed. This is to be used with the Loki tests for Storybook stories.
I used the example from the CircleCI Dockerfile for setting this up.
https://github.com/CircleCI-Public/circleci-dockerfiles/blob/master/node/images/10.19.0-buster/browsers/Dockerfile

@chrisgilmerproj I modified the test file, I also updated the list of "special" branches and the build script so that it would be built along with the rest. Let me know if I missed anything else for adding this new image.


Live data feed query results in pipeline runner

What is the proposed architecture for a long running live session of market data?
Currently the PipelineRunner will expect a Source to return a Iterator[Candle]. The AsyncQueryResult is being returned by the AsyncMarketProvider.request_symbol_history and our QuerySubscription attached to the results will wait for the done_event before returning. Once the market provider returns the symbol history and our subscriptions complete, the pipeline ends.
Ideally, the architecture should be able listen for incoming candles from a source and continuously process new incoming data through the pipeline.
Any thoughts on the implementation of this would be greatly appreciated.
This might be related to #2  section 2.

AsyncQueryResult, QuerySubscription, and AsyncMarketProvider, were written entirely to enable history loading from IB (IBMarketProvider). As you can see, the single function there is request_symbol_history.
Ideally, in order to implement streaming market data (running throughout the trading session), you'd want to implement an adaptor against the chosen broken API that will expose the generic Source iterator.
The pipeline itself cares only for the Source class. Meaning that it will probably be up to the adaptor implementation to keep the 3rd party connection open and receiving data, transform it, and pass it to a Source implementation.
We could wrap it in some kind of "adaptor runner" that will bridge the broker to the Source object. But that means creating an interface that will bind the different adaptor's implementations. Because there is no implementation for a streaming provider at the moment, I didn't see a reason to create it yet. After the first implementation, we'll get a sense of how the interface should look and maybe go in that direction.

I think because of the current state of my additional providers, the best way to get this feature to the main project would be to create a dummy streaming provider which returns some fixed bars over time and completes the interface for technical reference.

I'm not familiar with many brokers streaming APIs to know how the interface should be designed. There are APIs that are symbol based and you have to request symbols one by one. There are fire hoses that send you everything. There are pulling ones...
I'd really like to have several providers before committing to a unified binding interface.
It is possible to go and create this dummy adaptor that will provide a long-running Source just to close the circle and have a running example end-to-end while keeping in mind the possibility to have a type of adaptor manager that will bridge the two via a unified interface in a later stage when we have a better sense of how the interface should look like (with real brokers).

The current provider that I am working on implementing is TradingView Pro unofficial websockets feed.


Several problems with Duplicate action

Amazing new feature introduced in https://github.com/area17/twill/pull/556 , thanks for it!
Some problems:

The "Duplicate" appears in the actions list even when indexOption 'duplicate' is set to false.
Default implementation of duplication does not work if the model does not have revisions.
Action "Duplicate" appears for the items in the "Trash" list but it does not work there at all (even when enabled in indexoptions and the implementation fixed)

Thanks in advance!

Hi @marinaglancy thanks! 1 and 3 should be fixed now, however I'm afraid 2 is a requirement right now. We could look into supporting duplication on models that do not have revisions if you feel like this is important for your use case.


trivy: 0.21.1 -> 0.21.2

Motivation for this change
https://github.com/aquasecurity/trivy/releases/tag/v0.21.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 150519 run on x86_64-linux 1

1 package built:

trivy


Various changes from my fork

Here are various changes from the branch I am using to develop the Galaxy tool.
Not saying we can simply merge this PR, but maybe some things are a starting point for discussion.
Addresses some of #1.

I don't see why wouldn't we merge these commits, all seem in line with what we talked.

I don't see why wouldn't we merge these commits, all seem in line with what we talked.

ok, cool, let me fix a couple of things, then let's merge

@AlvaroSmorras feel free to merge, if you are happy


Sm/symlinks

What does this PR do?
supports symlinks in nodefs tree
lstat will stat the actual target, but stat will follow symlinks
What issues does this PR fix or reference?
@W-10494044@
https://github.com/forcedotcom/cli/issues/1375

QA notes:
With dreamhouse:
# symlink to `force-app` folder
➜  dreamhouse-lwc git:(main) ✗ ln -s force-app force-app-symlink

➜  dreamhouse-lwc git:(main) ✗ l -l force-app-symlink
lrwxr-xr-x  1 cdominguez  staff  9 Feb  7 20:00 force-app-symlink -> force-app

✅  Can deploy when passing a symlink as sourcepath
Before:
s force:source:deploy --sourcepath force-app-symlink/
ERROR running force:source:deploy:  /Users/cdominguez/code/gh/dreamhouse-lwc/force-app-symlink: Could not infer a metadata type

After:
➜  dreamhouse-lwc git:(main) ✗ s force:source:deploy --sourcepath force-app-symlink/
*** Deploying with SOAP API v53.0 ***
....


Quote Page Acreage rate

Choose which acreage rate to use from the rate table

I'll add this to questions to ask because I am not sure when/how the acreage rate location is set, which informs not only price but what account to fund.  Perhaps it will on the quote but I don't know.

closed in #106 by adding a acreage rate selection box


Task / Configurable runner environment

Motivation:
The motivation for this PR is to make Runner more flexible by optionally allowing the provision of a custom environment for the underlying UserToolchain.
Context:
In our company, we use ScipioKit in a quite advanced way. Specifically, we use it to precompile packages with multiple toolchains within a single run. For this, we set certain environment variables such as PATH and DEVELOPER_DIR before each Runner's run to delicately control the compiling process.
It all works well, except for the case when the environment is not provided to UserToolchain; it defaults to Environment.current. This is not a problem by itself; the problem is that such an environment is statically cached when called for the very first time, and there's no way to redefine it in the subsequent runs (as all the Environment state modifiers are internal).
Solution:
This problem can be easily fixed by extending the Runner interface so it takes an optional Environment parameter in its build options, which is then handed over to the underlying UserToolchain.
Important:
The PR ensures that the newly introduced environment property (in BuildOptions) does not affect the existing SwiftPMCacheKey, meaning the cache will remain environment-agnostic.
@giginet I'd love to hear your opinion on this.

It seems the Environment API is not available in last year's SwiftPM. I'm going to make the respective changes.

@giginet What you say sounds reasonable, it would lead to a better architecture indeed. Additionally, environment configuration should be done once per run, hence it fits more when done on the runner level.

As pros, reasoning about build options is easier, requires no exceptions, and less code overall.
As a con, I had to extend both FrameworkProducer and PIFCompiler initializers as we don't pass the runner options directly there. I believe it's a very minor change though, and it still remains an implementation detail.

I just applied the changes as suggested here.

I didn't add any tests since there are no existing test cases for PIFCompiler or ToolchainGenerator. I believe integration tests are more appropriate for covering this change, as it primarily concerns configuration passed down to SwiftPM.

@dmhts Thank you for the contribution! I'll release the new version soon.
By the way, I'm very excited that your company uses this product heavily. I'm happy to hear the case study someday.

@giginet That's not it, there's one more PR coming soon :)
We're currently working on a tool that uses SwiftPM and Scipio at its core. Once everything is polished, our goal is to open-source it. It's already running successfully in our CI pipelines. You'll be one of the first people I let know when it's ready!


luci-app-dawn: Implement in JavaScript

This pull request re-implements the app luci-app-dawn in JavaScript, removing the lua implementation.
Besides a re-implementation the following things are changed:

In both the network overview and the hearing map MAC addresses are replaced by host name if known.
In the hearing map, the table is sortable. If the same client is connected to multiple access points/frequencies the MAC/host name is listed twice, where in the lua implementation the second MAC address was empty to show it was referring to the same client.
The view in the network overview is a bit different. This table is not sortable, because LuCi doesn't seem to like a table inside a table for sorting.
Aligning the column names between the network overview and the hearing table.
Add tooltips for abbreviations.

Still to test:

~building package~ (works); ~install package on a fresh install~ (works); ~upgrade package from lua to javascript~ (can lead to a problem, see https://github.com/openwrt/luci/pull/6656#issuecomment-1784198904)

I also tried to compile it and install it. On a  install where the lua version of luci-app-dawn is installed, there is (or could be) an error after the installation. I believe this is not really related to the changed in this merge request, but just how the previous package was configured in combination with opkg.
If luci-app-dawn (lua version) is the only installed package that requires luci-compat this package will be uninstalled when installing the JavaScript version of luci-app-dawn over it. As a consequence, there is an error after login because it cannot find the lua compatibility layer, even though it is not really needed any more.
To fix this, either:

Reinstalled the compatibility layer with opkg install luci-compat. This is the safest option, and won't break any other packages.
Remove lua completely by running opkg remove luci-compat luci-lua-runtime ucode-mod-lua luci-lib-base lua. This might break other packages if lua is needed!

Is there a recommended way to deal with this? Or is it OK because an upgrade of a package, without a reinstall/update of openwrt, isn't recommended anyway?

Wow thanks a lot! Please squash commits together and prefix them with luci-app-dawn: ....

@PolynomialDivision Done. I've rebased on the latest commit from master and squashed everything into one commit.

@PolynomialDivision I've added the full list of changes back to the commit message. It's basically the same as in this pull request, but you're right that it is helpful to have it in the commit message as well.

I think your signed-off is missing a valid email that we require here in this repository. Could you maybe add a valid mail? Sorry, for doing nitpicking.

No problem. I understand the need for a good review process, and good to see it is applied. Had to change some settings because GitHub didn't like when my address is exposed in the commit, but it should be good now. The git author now also matched the one in Signed-off-by, as does the GPG signature. And as a bonus I reformatted the commit description to be less than 75 characters per line.

Thanks a lot. Great work. :) I will merge.

I will also cherry-pick that to 23.05.

@danielvijge This is great, thank you. I have a few comments and would be happy if you would create a follow-up PR.

the hearing map is not showing more than one AP per client anymore.
this is the data:

this is the result:

replacing the MAC with the names is a bit sub-optimal. It would be better to show the names in addition to the MAC

The nmame of the APs could be shjown in the hearing map. To do so, you can fetch the network and extract it from there. Here's how I did this in my now obsolete PR: https://github.com/openwrt/luci/pull/6625/files#diff-a17ac5c6613bbbfcb01f6a442e12dd594644d7778f580e2be7d5e29e11cf0667

you could flatten the network overview to one row per AP and client and add SSID as a column. This way you have only one "denormalized" table. If that table allows sorting and filtering, it would be way better than the old table. E.g. one could filter by SSID or sort by client.

Kind regards,
Michael.

@micw Thanks for testing it and submitting the feedback. For the first one, I remember explicitly testing for this, but it appears in the final, cleaned-up version, the flat() statement is applied to the wrong array.
Fixes for 1,2, and 3 are available in https://github.com/danielvijge/luci/commits/luci-app-dawn-js-fixes-and-improvements/ each in their own commit.
For 4 I have to look at it later. It can be done, but as I understand it now, it would remove the H3 headings for the SSID, and it would just be one table? Then it might make sense to apply the same logic to the hearing map as well. Or maybe I'm misunderstanding it. I was thinking of a better structure for this, but couldn't really come up with one. It might help if you could comment the table structure you envision.
Could you already test these changes and see if they all work?
(disclaimer: I tested them directly on my router, then applied the changes directly as an edit in GitHub. There is a chance I copied something wrong. I didn't test copying things back yet, or even making a package out of it. I'll later squash everything in one commit, do a proper change log, sign-off, pull request, etc.)

Hey @danielvijge ,
yes, for 4 I imagined just one large table. At the moment there is an arbitrary structure (SSID -> AP -> Clients). This might be meaningful for some uses but not in general. A large table with everything in cloumns would be sortable/filterable by each aspect and be much more usefull. E.g. one could filter by SSID, by AP or by a particular client. Same applies to the hearing map.
How can I test the new changes? I just updated today and was able to test the last PR since it was already cherry-picked to 23.x

You could directly edit the files on OpenWrt with the new versions. The files are in /www/luci-static/resources/dawn and /www/luci-static/resources/view/dawn. The installed files are minimised, but you can jus paste the full source version in there. Then just reload the page.

Thinking a bit more about the table. I think this is what you proposed:

SSID
Access Point
Interface
MAC
Utilization
Frequency
HT
VHT
Client
HT
VHT
Signal

MyWiFi
ap1
phy0-ap0
00:01:02:03:04:05
25.49%
5.200 GHz (Channel: 40)
Available
Available
Laptop
Available
Available
-74

MyWiFi
ap1
phy0-ap0
00:01:02:03:04:05
25.49%
5.200 GHz (Channel: 40)
Available
Available
Phone
Available
Not available
-53

MyWiFi
ap2
phy0-ap0
FF:09:08:07:06:AA
2.83%
5.200 GHz (Channel: 40)
Available
Available
No clients connected

There might be several problems with such a table:

The first 8 columns are repeated many time, especially when there are many client connected to an AP. This might make things harder to read.
Some columns refer to AP properties, while other refer to client properties. This might be difficult to communicate.
Aggregate properties, like number of clients connected don't really make that much sense.

In a way, the table would be almost the same as the hearing map, with just an additional column to indicate if a client is actually connected/authenticated to the network, or only seen by an AP.

It's not the same as the hearing map since it would contain only connected clients, not all visible clients (so it's much smaller). But now than you write this, Seing which clients is connected would be a great extension to the hearing map ;-)
My idea was that if everything in one table, it could be made much more interactive. Want to see how many clients are connected to one AP - filter by that AP. Want to see which client are on a particular SSID - filter by that SSID etc.

The first 3 bugs are fixed in #6674. For an optional view of the table I opened #6675 to have a discussion.


hide cluster network config from side nav

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


feat: honk acir composer

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

note_history_trial_decrypting_time_in_ms (5): 215 (+90%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 04f8e0df and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
220,992
866,396
3,448,076

l1_rollup_execution_gas
934,136
3,968,870
24,791,612

l2_block_processing_time_in_ms
1,420 (+1%)
5,540 (+5%)
22,050 (+1%)

note_successful_decrypting_time_in_ms
315 (+2%)
949 (+3%)
3,416 (+3%)

note_trial_decrypting_time_in_ms
27.6 (+50%)
78.1 (+70%)
141 (-3%)

l2_block_building_time_in_ms
16,156
64,064
256,899

l2_block_rollup_simulation_time_in_ms
11,744
46,658
187,456

l2_block_public_tx_process_time_in_ms
4,375 (+1%)
17,316
69,161

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,869 (-2%)
30,460 (+1%)

note_history_successful_decrypting_time_in_ms
2,164 (+1%)
4,224

note_history_trial_decrypting_time_in_ms
:warning: 215 (+90%)
175 (-8%)

node_database_size_in_bytes
3,580,372
3,653,998

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
214
44,681
25,561

private-kernel-ordering
165
43,753
14,809

base-rollup
1,193
128,338
881

root-rollup
79.3
4,088
677

private-kernel-inner
291
71,208
25,561

public-kernel-private-input
206
31,863
25,561

public-kernel-non-first-iteration
203
31,905
25,561

merge-rollup
7.64
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
12.6 (+1%)
19.6 (+3%)
13.6
19.4 (-1%)
25.9 (-3%)
70.6 (+3%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.627
0.668 (+6%)
0.547
0.541
0.487 (-1%)
0.445
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
84.1
52.2 (+1%)
254 (+2%)
476
918
3,588

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.473 (-2%)
0.500
0.440
0.435
0.431
0.428

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
121 (+3%)
62.8
377 (-1%)
767
1,446
5,997 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.509 (+1%)
0.503 (-1%)
0.478 (-1%)
0.484
0.475
0.486

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
68.2
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
94.1
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
0.597
N/A
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455
32,219

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
376
1,088

Metric
1 public data writes

tx_sequencer_processing_time_ms
537


[VIC] Can't download root cert

I am trying to install vSphere Integrated Containers 1.2 from the OVA but once connected to my VIC appliance I can't download root cert from Administration > Configuration
Any idea?

@cuwab in VIC the UI is bundled with another component,  there's a similar issue opened recently.
https://github.com/vmware/admiral/issues/215
I noticed the text looks incorrect in your screenshot, are you using a released .ova or a dev build?

Hi ! I use the latest released ova dowloaded from official vic website

so is it 1.2.1?

I could reproduce this issue with Chrome [Version 61.0.3163.100 (Official Build) (64-bit)], but not Firefox [53.0 (64-bit)]. I don't see anything special either in the console or in the requests.
P.S. While writing this I noticed that in my incognito window in Chrome the page has loaded okay.. Not sure what happened, but now it seems to be fine in all windows..

Also seen in https://github.com/vmware/vic-product/issues/821

Everything seems OK after reinstall VIC 1.1 and upgrade it to 1.2 so I can't check if there's failed http request, sorry :/

@eivanova @andrewtchin,
To locate the root cause of this issue, we need to confirm:
Firstly, the current user has admin role;
Secondly, the ca is in the right place.
The above things have corresponding properties returned by the systeminfo api. When reproduced the issue, have you tried to check if the properties in the json data returned by the systeminfo are right? I'm wondering if there are some cache problems to interrupt the api to return the latest data.

I believe the user is admin and CA is generated and moved correctly by the VIC Appliance startup. @stuclem is the original reporter in vic-product #821

Checked, it's already fixed in new .ova build. Close it.


vmaGetBudget() is ambiguous and can lead to easy bugs

Hello,
I just submitted a PR to the C++ wrapper of this library, that I think illustrates how easy it is to misinterpret vmaGetBudget
https://github.com/malte-v/VulkanMemoryAllocator-Hpp/pull/8
Even before switching to the C++ wrapper, I had this in my code:
VmaBudget budget;
vmaGetBudget(allocator, &budget);

This generated a "stack corrupted around variable budget" error on Visual Studio 2019, and I could not for the life of me track down why.
After digging through the eventual call to allocator->GetBudget() and finding the line ++outBudget, I finally realized it was supposed to be an array!
Now the easy response is "read the documentation", which is correct and points out that it should be an array. Which, yes, I should have done.
However, I find the naming of the function to be very misleading. It promises to give me a budget, I give it a budget, and it gets filled with information.
I have a few suggestions:

Rename it to vmaGetHeapBudgets() or something similar, to indicate that it's giving you an array of budgets, one per heap
Rename the variable from pBudget to pBudgets or something to indicate that I'm not expceting a single Budget struct back
Accept a maximum size for the output array as a parameter, vmaGetBudgets(pBudgets, 10);

Thank you for your time!

Thank you for reporting this issue. I agree with you. I try to preserve backward compatibility in general, but as the library is now developed towards new major version 3.0.0, I renamed the function to vmaGetHeapBudgets as you proposed and I renamed the parameter to pBudgets.


add 'methods' in code comments for $options in Stub::create($options)

in favor of https://github.com/crysalead/kahlan/issues/90#issuecomment-149542506

:+1:


Text on image

Hi
Is there way to put text on image like using "insert" on two images ?
For exampletext "1234" on center of the image 500x500 would be positioned x:245, y:245
Regards Artur

Have you looked at the http://image.intervention.io/api/text method?

Yes but I can't obtain effect with text on middle/center of image without setting x and y


Q: how do we know when a new cryptocurrency is added to the SDN?

My guess from reading https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/main/generate-address-list.py#L12 is that someone periodically fetches the XML file, does a grep and then compares that to the list at https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/main/generate-address-list.py#L13-L15
I am wondering if a better implementation strategy might be to have the script do two passes: first, to look for <FeatureType/> starting with "Digital Currency Address - ", to build up the list on lines 13-15, and, second, to proceed as usual. of course, i'd still keep what's on lines 13-15, just as a safety.
Your thoughts?

I'm not actively monitoring for new coins being added to the SDN list - for me personally, only XBT is relevant. However, I accept PRs (https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/pull/7, https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/pull/6) to add new coins and will review and merge them.
As the CI is already running each night to check if there are new entries for the existing coins, there could also be a job that runs after uploading potential new entries - failing or otherwise alerting that there are new coins. Happy to create an issue for each new coin when the CI fails. Someone (not necessarily me, but I might do it if I have the time) can then create a PR to add the new coin.

Thank you!

We might want to keep this open and not "closed as completed". The new CI task I was talking about doesn't exist yet. Someone might want to add that.
Reopening with the help wanted label.

hey i was wondering if this is a related issue, let alone coins, but new addresses, but on branch lists, does the github actions event still work where it updates addresses? does it update on an interval ? when can we expect to see new addresses?

The list branch is only updated when the underlying OFAC list changes - this happens infrequently. The OFAC list is downloaded an processed daily see
https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions
and
https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/319d5a6510c84fe01396387801dcc539a19a9f7f/.github/workflows/generate-lists.yml#L5-L7


feat(output): Add matching_authors

Description
This pull request introduces several improvements and updates to the Comment Finder GitHub Action. The main changes include:

Simplified Logic: The logic for matching authors and keywords has been simplified and improved, making the code more readable and maintainable.

Improved Variable Names: Variable names have been updated to follow proper naming conventions and be more descriptive.

Output: You can then use the matching_authors output to get a comma-separated list of authors whose comments contain the specified keywords:

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

approve


Allow S3 Snapshot service to trust internally signed certs when talking to the S3 endpoint

What kind of request is this (question/bug/enhancement/feature request):
enhancement/feature request
Allow S3 Snapshot service to utilize internally signed certs when talking to the S3 endpoint.
We utilize internal S3 compatible services and would like to make use of the S3 Snapshot feature provided in 2.2.0.  We receive a trust type warning from the snapshot endpoint since our internal S3 endpoint utilizes an internally signed cert(private CA).
Steps to reproduce (least amount of steps as possible):

Edit Cluster -> Configure Internal S3 compatible endpoint that uses an internally signed cert (private CA).
Select cluster in UI -> Snapshot Now

Result:
Error in API view.
message": "Failed to take one-time snapshot, exit code [1]: time="2019-03-27T13:38:51Z" level=fatal msg="faield to set s3 server: failed to check s3 bucket:mybucket, err:Head https://s3server:9021/mybucket/: x509: certificate signed by unknown authority" \n",
Other details that may be helpful:
Environment information

Rancher version: 2.2.0
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom
Kubernetes version (use kubectl version): 1.13.4

+1
We encountered the same problem, it could be nice to have the possibility to setup our internal CA when configuring the S3 endpoint for snapshots.

API/Backend support is in master. Separate ticket is filed for UI.

Verified in rancher:master-head -- API testing

Launch a minio server with Self-signed Keys and Certificates.
Created a cluster, by configuring the minio server as S3 snapshot details without passing the  certs incustomCa. Error was seen on the rancher logs:

2019/06/27 22:17:24 [WARNING] Failed to take one-time snapshot, exit code [1]: time="2019-06-27T22:17:23Z" level=fatal msg="faield to set s3 server: failed to check s3 bucket:sowmya-test, err:Get https://x.x.x.x:9000/sowmya-test/?location=: x509: certificate signed by unknown authority"

Now create a cluster passing the valid certs incustomCafield.
Snapshot is taken successfully. Restore from snapshot works.


feat: use visibility

Description
Problem
Part of #4515
Summary
We recently added a warning for unused imports... but only for bin and contract packages. We didn't enable it for lib packages because a use could also be used as pub use, something we don't have yet. I thought it would be really nice if we had pub use, and warned on unused imports in libs too. I checked the code and we already track visibility for any item, in general, it's just that for things that don't allow a visibility modifier we just consider it's public. So I tried to see how difficult it would be to implement it, and it turned out it wasn't that hard or time-consuming.
That said, visibility for use involves some more logic, particularly for autocompletion, because now pub use should be suggested, but the "parent" module of that item isn't the actual parent (it's the module where the pub use is defined) but that was relatively striaght-forward to implement too.
Additional Context
No need to review or merge this, I just played with this while waiting for other things and I didn't want to lose the work.
If we decide to go forward with this, any existing use that was used as pub use will likely start producing a warning for libs, but now that can be silenced by changing it to pub use.
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Haven't checked to see if a test already exists but we should make sure that we can't turn a private item pub with a pub use.

Ah, I forgot to add tests. I'll try, but right now running cargo test on the frontend project gives a linking error (just on Mac, I think?) so it's kind of hard to test things.

What's a code to do that?

// library/lib.nr

use foo::private_func;

mod foo {
    fn private_func() -> Field {
        42
    }
}

// binary/main.nr

fn main() -> Field {
    library::private_func()
}

This should work.

Ah, I see.
Right now that code gives a warning on library:
warning: private_func is private and not visible from the current module
  ┌─ deps/foo/src/lib.nr:1:14
  │
1 │ pub use foo::private_func;
  │              ------------ private_func is private

but no error on the user of the library.
What should we do in this case? If a pub use tries to export a private item we should consider it as just use? Or is it fine if it just warns on the library side?

We could go further and make private_func be pub(crate) which should mean that no warnings/errors are thrown either on the library or user's side.
// library/lib.nr

pub use foo::private_func;

mod foo {
    pub(crate) fn private_func() -> Field {
        42
    }
}

// binary/main.nr

fn main() -> Field {
    library::private_func()
}

Realistically we should be returning a hard error for these visibility issues rather than just warnings. We should also be erroring/warning in the case in which a use statement is expanding the visibility of the item it's importing.

Done! Now you get a warning if you try to re-export an item with less visibility than the use statement, plus the use statement's visibility changes to the lowest of visibilities (so you get a warning too on the user of the pub use).
As you said, eventually all of these should be errors, but at least now we get a warning on both sides.

I pushed a commit to solve the remaining issue, but I had to change a "def maps" parameter to be mutable and I'm not sure that's correct. I'm thinking maybe tracking unused stuff should be outside of ModuleData, as a separate structure, and that's something you would pass to resolve_path. I'll try to do that after working on other things.

Now usage/unused tracking is held in NodeInterner with a new type UsageTracker. I made it very explicit that this is about tracking imports, but that type could later be used to track any unused items (we'll have to rename some methods, of course). It could be done right now, but it's probably better to do it in a separate PR.
I also added docs (I copied some of that from the Rust docs).


⚠ Fortnite has degraded performance

In ab75dd2, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1570 ms

Resolved: Fortnite performance has improved in 5544132.


Clean dist

This PR:

Deletes orphan files (that are no longer in src) from renamed/removed components (date, grid, link-back, pagination, phase-tag, select-box, site-width-container)
Removes index.html files from dist; we are not generating these index.html files anymore, so I figured we don't need them because we provide the same content through our express app
Add the clean task to build:dist to prevent having orphan files in dist

This PR helps passing the should copy the right files to dist tests

👏 💯 🗑 ➖ 🔻 🚫


[Bug] npx hydrate failling to hydrate route dependencies

Describe the bug
When running npx hydrate, the node_modules folder of my routes are not being populated with their required packages needed.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/joemccann/begin-functions-app
Clone the repo
npm i
npx hydrate
cd src/html/get-articles/node_modules
ls -la

Expected behavior
Upon listing the directory you should see request-promise as well as a few other packages that are required in the index.js file of the get-articles route.  They are not present.
Screenshots
Gif of a screen cap here: https://www.dropbox.com/s/bnvkng28tqiqs5z/begin-bug.gif?dl=0
Desktop (please complete the following information):

OS: MacOS
npx hydrate output:

ARC_APP_NAME jump-z3c
AWS_REGION us-west-2
AWS_PROFILE xxx

Node 8.11.1
npm 6.1.0
arc 3.2.18

Ah shitballs! I think its "working" but this is a gotcha. You don't have request-promise in your package.json here https://github.com/joemccann/begin-functions-app/blob/master/src/html/get-articles/package.json so npx hydrate isn't installing it.
Aside: you should use a smaller http client (like tiny-json-http). It supports promises and, more important, isn't 10mb so it won't impact your Lambda coldstarts!

np np! hmu if you run into anything weird. Another heads up: we've noticed some funkiness w package-lock.json and sadly the easiest way to resolve is to delete it and then rerun npm i to regenerate. =/

I npm installed in each lambda and it works fine now.  Closing this.

Same issue, same fix: deleting package-lock.json and re-running npm -i. 👍


Feat: Scraping gold rates from money control

Describe the feature
Hi @nikhil25803
We can scrape gold rates city-wise from moneycontrol
I am a GSSoC '23 contributor, please assign this issue to me.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

Go ahead @DyuthiVivek |


[SPARK-48768][PYTHON][CONNECT] Should not cache explain

What changes were proposed in this pull request?
Should not cache explain
Why are the changes needed?
the plans can be affected by dataframe.cache
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No

thanks all, merged to master


hope support activemq in instrumentation

hello，hope trace it ,thanks

this should be covered by https://github.com/openzipkin/brave/tree/master/instrumentation/jms, @promission if this does not cover your needs please raise more specific issues. Issue can be closed.


No whitelist shown in settings

Describe the Bug/Feature
When entering the addon settings page from about:addons, the following error appears in the browser console:

Then, the whitelist has no content, even though it does keep cookies of sites which I whitelisted from the icon's context menu. New entries will also not appear in the list, when trying to enter them via the settings page.

OS/version: OSX 10.11.6
Browser/version: Firefox 55.0.3
Cookie AutoDelete version: 1.4.3

I'm facing the same issue on FF 55.0.3 on a Debian 8. I've just replaced SDC by this extension and without the possibility to manually manage the white list, it's of little use (e.g., cannot add *.domain.com).

manually manage the white list, it's of little use (e.g., cannot add *.domain.com).

In an upcoming version, you'll be able to do so.

The updated features for the next version is a good news, but the current version still has the issue reported here: There's an error in the JS code and the Cookie Whitelist section doesn't work at all (can't see or edit the whitelist).

Maybe turn on e10s? See #117

AFAICT, it is enabled on my FF (about:support show Multiprocess Windows: 1/1 (enabled by the user)).

Try a Restore Default Settings. I think the whitelist data might be corrupted from entering a '*'.

restoring to default settings did not fix this for me

It fixed it for me as well, I may indeed have tried to enter a URL with a star.

Seems to be fixed so closing.


Fix static analyzer warnings

Coverage increased (+0.06%) when pulling a89e77cfd549084b4c2a520b736f3896d804ef23 on warnings into a24d068e5cce1e0a321cf726d7d53e2b7422acdd on master.


Axis protected in unaligned joint models

In JointModelPrismaticUnaligned and JointModelRevoluteUnaligned, axis is protected and there is no accessor on it. I need to have access (in read only) to this attribute.
Is there any rationnal to but axis protected? I suggest to simply pass it as a public attribute.

I'm fixing current bugs in integrate. I will do it in the same PR.

Thx. Could you also fix obstacle placement BTW? See humanoid-path-planner/hpp-pinocchio#27

Ok.

Solved by direct push.
The second point is PR #264.


Read value

Added read[type][width][endianness] functions. I found that I did need to use the host's endianness to determine if the BE or LE version of the function should be called. Basically, on an LE system, the byte order of the BitBuffer will be revered from a regular buffer. So if you are on an LE system and you want a BE number, you need to actually request an LE number. The function read has this built in so the user can just request a BE or LE number as they need.
This requires resize() and subbuffer() so pull requests #5 and #4 are included

The byteorder of the host system is not relevant here. The buffer stores a continuous array of memory. That memory could have been read from a file or transferred from the network. So it is up to the consumer of the API to determine if the data has to be interpreted as LE or BE.
I'm also confused by the width parameter.

The width parameter are the number of bits (e.g. an 8-bit int has width = 8)
Endianness of the host system DOES matter when you start talking about bit addresses in a byte buffer. Say I have 2 bytes of big-endian data (0xeb90 /<PHONE_NUMBER>010000) and I stored it, bit-by-bit with this.set(), in a 16-bit BitBuffer. On a big-endian host the backing Buffer would indeed look like [eb][90]. However, on a little-endian host the Buffer would look like [90][eb].  Because of this you must correct for little-endian systems because they will reverse the bytes as you fill the array.


Variable names containing dash throws error

This template
<p> {{ person.first-name }} </p>

with following data
{
	"person": {
		"first-name": "John"
	}
}

does not render and logs this issue parseInput: end of input expected @ 1:9. But when using first_name (underscore instead dash) in data and template it works. Is there any restriction here? https://pub.dev/packages/liquid_engine had no issues with dash separators in variable names or in template. 🙏

I have forked the package and added dash support! 😊

@cka29 can you create a pr with the changes?


6.8.4 not working (Carthage)

I'm using latest version of Carthage 0.33 and running PromiseKit 6.8.4 and this was working before not sure what happened. BUT the message I am getting is
A shell task (/usr/bin/env git checkout --quiet e0b3a9274560393328a7b08cec77676726b863b4 (launched in .../Carthage/Checkouts/PromiseKit/Extensions/AddressBook)) failed with exit code 128:
fatal: reference is not a tree: e0b3a9274560393328a7b08cec77676726b863b4

It is definitely the same as this issue https://github.com/mxcl/PromiseKit/issues/959

I also see this failure.

I am only seeing this error with 6.8.3. carthage update i was able to successfully install 6.8.4.

Delete the Carthage cache

Doing rm -rf ~/Library/Caches/org.carthage.CarthageKit to clear the cache worked
then running it again worked.

I just encountered this error. A month ago, PromiseKit 6.8.4 resolved to https://github.com/mxcl/PromiseKit/commit/d6b3b93bbdb9e6668fdcc3e0b0029e635e7915c9, but I see now (after manually resolving the resulting Carthage and git errors) that the tag is at https://github.com/mxcl/PromiseKit/commit/fe1e9c5b62465227cceb7b0e6e79489ba7b824af. Moving semver tags after they are published is very bad practice and can cause a lot of headaches for users of the library.

I know it's a pita, but it was unavoidable.

Like honestly this kind of snarky feedback is really unpleasant. I have dedicated huge amounts of time and effort to this library and all my other open source, being nice is really the least you could do.


Creative-CA0132

I have x99 gaming g1
Creative-CA0132
can you add this code to AppleALC.
AppleHDA-272.51.3-Creative-CA0132_files.zip

Hello,
Please follow the wiki article, and pass me the right files for your codec in a pull request form. Thanks :)
I have to warn you that the AppleHDAController patch, X99 needs, is not yet supported by AppleALC. For some short meanwhile you will have to use your bootloader to apply it, which will work just fine for testing reasons.

Hi
Just x99 patch with applehda and appleALC work together.

On Mar 11, 2016, at 3:30 PM, vit9696<EMAIL_ADDRESS>wrote:
Hello,
Please follow the wiki https://github.com/vit9696/AppleALC/wiki article, and pass me the right files for your codec in a pull request form. Thanks :)
I have to warn you that the AppleHDAController patch, X99 needs, is not yet supported by AppleALC. For some short meanwhile you will have to use your bootloader to apply it, which will work just fine for testing reasons.
—
Reply to this email directly or view it on GitHub https://github.com/vit9696/AppleALC/issues/10#issuecomment-195538213.

I need this too
ALC 260
http://www.insanelymac.com/forum/files/file/531-realtek-alc260-sound-with-applehdakext/

I don't know how to build kext.


[Question] Auth options

FHIR server uses Azure AD to authenticate clients, but I'm also interested in creating a patient self-help portal, where they can manage, update and change their medical info. Does this mean I'll have to create new AD account for all of the users? Or must I add another API on top of the FHIR server that proxies/forwards all to it to manage user auth?
I was hoping this would help with the creation of a new example, or some help regarding what direction to take to implement patient login functionality?

Azure B2C is designed for this type of workflow, although you would need to create an api to be called in an auth flow that would allow for correlation between the patient I’d and the new ad user
Get Outlook for iOShttps://aka.ms/o0ukef

From: medlab001<EMAIL_ADDRESS>Sent: Monday, September 28, 2020 5:06:21 AM
To: microsoft/fhir-server-samples<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [microsoft/fhir-server-samples] [Question] Auth options (#95)
FHIR server uses Azure AD to authenticate clients, but I'm also interested in creating a patient self-help portal, where they can manage, update and change their medical info. Does this mean I'll have to create new AD account for all of the users? Or must I add another API on top of the FHIR server that proxies/forwards all to it to manage user auth?
I was hoping this would help with the creation of a new example, or some help regarding what direction to take to implement patient login functionality?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/fhir-server-samples/issues/95, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXRQMISX5U2TJNRLQJH4J3SIBNZ3ANCNFSM4R4J2VXQ.

Ahh, I see, I missed this. Thanks for that!
If I'd rather use my way of authentication/authorization, how do I handle that?

If you can share some details, I can point you in the right direction, but ultimately with any auth mechanism, you’ll need a way to tie an external claim to the patient record. Using oAuth with an external IDP, like gmail/etc still requires that the system accepting the claim match it to a user configured with the system. AzureB2C handles this by automatically creating that user upon enrollment
Get Outlook for iOShttps://aka.ms/o0ukef

From: medlab001<EMAIL_ADDRESS>Sent: Monday, September 28, 2020 8:44:19 AM
To: microsoft/fhir-server-samples<EMAIL_ADDRESS>Cc: brochlabs<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/fhir-server-samples] [Question] Auth options (#95)
Ahh, I see, I missed this. Thanks for that!
If I'd rather use my way of authentication/authorization, how do I handle that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/fhir-server-samples/issues/95#issuecomment-700016024, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXRQMM7LWNT2WIXAMH3CETSICHLHANCNFSM4R4J2VXQ.

Details, well I'm still starting out with this, so I'm actually looking for info on how to accomplish this. From your suggestion, I could use B2C for this, and seems to meet all the requirements, such as user types for access control. In case I go ahead with B2C, how do I tie a user's info to the B2C account? I'll need an API b/w B2C and FHIR server, correct? This API will be the one that checks that the user is authorized to view that information.
I'll clarify a custom solution once I'm up to speed with B2C usage. Thanks for your help!

@brochlabs
I was able to configure Azure B2C, thanks for the info! With that directly connected to FHIR server, I can see all the info.
This page suggests that external auth is required for fine-grained access, such a patient being able to access only their data. My idea was to use Ocelot to inspect the tokens, (and extended permissions stored, say in CosmosDB) and then forward the request to the FHIR server. Have I got this right?

Essentially yes. I would recommend that you CISO sign off on your final
authentication and authorization pattern, but yes, the first piece there
would be to determine what your system of record is for determining whom
has authorization to a patient record. For example, the EMR or the FHIR
server should be the most up-to-date system of record for determining a
patient or their authorized contact ( oftentimes you have a legal guardian,
parent, or someone whom has power of attorney that would be authorized to
view the patient record). On initial authentication, you need a mechanism
to query not only the authenticating person's EMR ID, but also their
related contacts. You could then store those tokens in Redis Cache so they
are available for the session context, etc.
On Fri, Oct 9, 2020 at 4:58 AM medlab001<EMAIL_ADDRESS>wrote:

@brochlabs https://github.com/brochlabs
I was able to configure Azure B2C, thanks for the info! With that directly
connected to FHIR server, I can see all the info.
This page
https://docs.microsoft.com/en-us/azure/healthcare-apis/use-custom-headers
suggests that external auth is required for fine-grained access, such a
patient being able to access only their data. My idea was to use Ocelot to
inspect the tokens, (and extended permissions stored, say in CosmosDB) and
then forward the request to the FHIR server. Have I got this right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/fhir-server-samples/issues/95#issuecomment-706088701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIXRQMJ4CEMKYYB3IBRH76TSJ3NCVANCNFSM4R4J2VXQ
.

Yeah this is starting to make sense.
But I ran into an issue. I'm using the Azure API for FHIR, so can't customize the auth pattern there much. For each incoming request, token validation isn't enough. I'll need to check if an physician can view a corresponding patient's data, but there's no such info on the server. If I understood you right, I store this mapping elsewhere, such as a <insert DB + private API, perhaps> and then query it for the given request, and conditionally forward it to FHIR, correct? The trick here, that I must be careful about, is that on new 'relation' (such as a patient being assigned a physician), I must first update my setup, and then update FHIR, so that I'll know what patients to retrieve given a physician. Not sure if I can use Redis here, since it might lose data when there's a crash.
Do let me know if I've got this right.
Thank your very much for your kind help, it's been really invaluable in clarifying how things work, and how I'm supposed to integrate all these.

Correct, determining whom has access to a patient's record requires
constraints implemented beyond the FHIR API. The Redis cache was more for
retrieving that information and storing it for the context of the session,
but you are correct, there needs to be a source system for
controlling/requesting/assigning access to a patient record. There is the
potential that you could store this information within the FHIR API, using
the RelatedPerson endpoint, but I haven't vetted that out yet, and it will
be a few days before I can circle back to my API environment.
[image: image.png]
On Tue, Oct 13, 2020 at 5:26 AM medlab001<EMAIL_ADDRESS>wrote:

Yeah this is starting to make sense.
But I ran into an issue. I'm using the Azure API for FHIR, so can't
customize the auth pattern there much. For each incoming request, token
validation isn't enough. I'll need to check if an physician can view a
corresponding patient's data, but there's no such info on the server. If I
understood you right, I store this mapping elsewhere, such as a <insert
DB + private API, perhaps> and then query it for the given request, and
conditionally forward it to FHIR, correct? The trick here, that I must be
careful about, is that on new 'relation' (such as a patient being assigned
a physician), I must first update my setup, and then update FHIR, so that
I'll know what patients to retrieve given a physician. Not sure if I can
use Redis here, since it might lose data when there's a crash.
Do let me know if I've got this right.
Thank your very much for your kind help, it's been really invaluable in
clarifying how things work, and how I'm supposed to integrate all these.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/fhir-server-samples/issues/95#issuecomment-707646226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIXRQMIP4XJFB5XVUIOFU4TSKQTLZANCNFSM4R4J2VXQ
.

Thank you for clearing that up!
In B2C, I'm trying to bind the FHIR ID in the user's claims after they register, so that after they login, I can get their FHIR token directly.

I do get the ID in the token "extension_FHIRID": "", after they signin, but I am trying to update it through the graphAPI. The GraphAPI docs only talk about how to create 'open extensions' which are different from extension attributes. I can fetch these through the GraphAPI (_graphService.Users[claimsIdentity].Request().Select($"extension_{b2c-app-id}_{id_name}").GetAsync();), but I can't find any resources on hot to modify them. Could you kindly point me to the right resource?
Have a great day!


worker: error when applying new batch error report logic

After #78 is deployed, errors appear in worker lambda as follows:
handler returns a single value, but it does not implement error: errorStringnull | handler returns a single value, but it does not implement error: errorString null

Maybe related to aws/aws-lambda-go/issues/430 ?
Reverted #78 for now.

Fixed via #81


Update apis_mapping_table.md

Proposed changes
This PR updates documentation about the specification to map FIWARE Open APIs with NGSI Go commands.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage remained the same at 100.0% when pulling 5e0188054a9204dc296a0ecf88490e4ff90c84b0 on fisuda:update/documentation into 431f1669265fc55b1e992532f4d6721969ee05d7 on lets-fiware:main.


🕵 Define the services we support as Analytical Platform

User Story
As an Analytical Platform product engineer
I want a list of services we as a team support
So that we aren't on the hook for anything and everything
Value / Purpose
The ecosystem of products that use Analytical Platform branding is bigger than what the core team supports day-to-day
Useful Contacts
Data Engineering
User Types
Product Engineering
Hypothesis
If we survey the Analytical Platform landscape of services, create a list of who owns AND supports them
Then this should help us identify what WE support
Proposal
DM/PM/BA create list of services and owners
Additional Information
No response
Definition of Done

[ ] service list created
[ ] support documentation updated

It is worth noting this page should be in agreement / updated with whatever conclusions are made in this ticket.

The Spreadsheet listing the services and products the AP supports have been shared with the Data Engineer Leads (Callum and Soumaya) for their comments.
Action Points:

AP Team will review the spreadsheet listing the products and services we support.
Share spreadsheet with Data Engineer team to agree the services and products the AP team supports.

The list of of services we would be supporting are now on the attached Spreadsheet which would be forwarded to Greg and Callum. A new ticket would be raised to review the 'Shared Responsibility Model' document.
List of services AP Team supports - https://docs.google.com/spreadsheets/d/1VCP6VHsnWsHdJvhUMruocdMk212ayx3BQA49AZS7nOs/edit#gid=1722260833