Launcher crashes on tray shortcut creation

2017-06-14 18:14:17 [Information]: Logging system initialized
2017-06-14 18:14:17 [Information]: Initializing Python v3.7
2017-06-14 18:14:18 [Debug]: Configuring SSL Client context
2017-06-14 18:14:18 [Debug]: Starting Downloader instance
2017-06-14 18:14:18 [Debug]: Setting Download output directory to C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:18 [Information]: Starting notification center
2017-06-14 18:14:18 [Trace]: Starting new Environment instance
2017-06-14 18:14:18 [Debug]: PATH: C:\Program Files (x86)\Intel\iCLS Client\;C:\Program Files\Intel\iCLS Client\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;C:\Program Files\RedHat\java-1.8.0-openjdk-<IP_ADDRESS>-1\bin;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\GNU\GnuPG\pub;C:\Go\bin;C:\Users\Dilshat\AppData\Local\Microsoft\WindowsApps;C:\Users\Dilshat\apache-maven-3.3.9\bin
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files (x86)\Intel\iCLS Client\
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Intel\iCLS Client\
2017-06-14 18:14:18 [Trace]: Probing C:\WINDOWS\system32
2017-06-14 18:14:18 [Trace]: Probing C:\WINDOWS
2017-06-14 18:14:18 [Trace]: Probing C:\WINDOWS\System32\Wbem
2017-06-14 18:14:18 [Trace]: Probing C:\WINDOWS\System32\WindowsPowerShell\v1.0\
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Intel\Intel(R) Management Engine Components\DAL
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Intel\Intel(R) Management Engine Components\IPT
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Intel\WiFi\bin\
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Common Files\Intel\WirelessCommon\
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\RedHat\java-1.8.0-openjdk-<IP_ADDRESS>-1\bin
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Git\cmd
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Git\mingw64\bin
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files\Git\usr\bin
2017-06-14 18:14:18 [Trace]: Probing C:\Program Files (x86)\GNU\GnuPG\pub
2017-06-14 18:14:18 [Trace]: Probing C:\Go\bin
2017-06-14 18:14:18 [Trace]: Probing C:\Users\Dilshat\AppData\Local\Microsoft\WindowsApps
2017-06-14 18:14:18 [Trace]: Probing C:\Users\Dilshat\apache-maven-3.3.9\bin
2017-06-14 18:14:18 [Information]: Updating PATH environment variable to C:\Users\Dilshat\subutai\bin
2017-06-14 18:14:18 [Trace]: Environment::~Environment
2017-06-14 18:14:18 [Debug]: Initializing UI: SubutaiLauncher dev
2017-06-14 18:14:18 [Trace]: Creating main window
2017-06-14 18:14:18 [Debug]: Starting Library UI Component
2017-06-14 18:14:18 [Trace]: CommunityComponent::CommunityComponent()
2017-06-14 18:14:18 [Debug]: UI Initialization completed
2017-06-14 18:14:21 [Trace]: Install button clicked
2017-06-14 18:14:21 [Trace]: Creating Installation Wizard Window
2017-06-14 18:14:21 [Trace]: Creating Wizard Intro UI Component
2017-06-14 18:14:21 [Trace]: Starting System Check UI Component
2017-06-14 18:14:21 [Trace]: Starting new Environment instance
2017-06-14 18:14:21 [Trace]: Environment: Getting operating system information
2017-06-14 18:14:21 [Trace]: Environment: Getting OS Architecture
2017-06-14 18:14:21 [Trace]: Environment: Retrieving RAM size
2017-06-14 18:14:21 [Trace]: Starting VirtualBox instance
2017-06-14 18:14:21 [Trace]: Searching for VirtualBox installation in PATH
2017-06-14 18:14:21 [Trace]: Searching for VBoxManage.exe in C:\Program Files (x86)\Oracle\VirtualBox
2017-06-14 18:14:21 [Trace]: Searching for VBoxManage.exe in C:\Program Files (x86)\Oracle\VirtualBox
2017-06-14 18:14:21 [Trace]: Searching for VBoxManage.exe in C:\Program Files\Oracle\VirtualBox
2017-06-14 18:14:21 [Trace]: VirtualBox installation found at C:\Program Files\Oracle\VirtualBox/VBoxManage.exe
2017-06-14 18:14:21 [Trace]: System Check UI Component created
2017-06-14 18:14:21 [Trace]: VirtualBox::~VirtualBox
2017-06-14 18:14:21 [Trace]: Environment::~Environment
2017-06-14 18:14:21 [Trace]: SystemCheck::resized
2017-06-14 18:14:21 [Trace]: ComponentChooser::Pre
2017-06-14 18:14:21 [Trace]: Creating Component Chooser UI Component
2017-06-14 18:14:21 [Trace]: Component Chooser UI Component created
2017-06-14 18:14:21 [Trace]: Creating Wizard Install UI Component
2017-06-14 18:14:21 [Trace]: Creating Wizard Install UI Component
2017-06-14 18:14:21 [Trace]: Creating Wizard Install UI Component
2017-06-14 18:14:21 [Trace]: Creating Wizard Install UI Component
2017-06-14 18:14:21 [Trace]: Creating Wizard Finish UI Component
2017-06-14 18:14:22 [Trace]: SystemCheck::paint
2017-06-14 18:14:29 [Debug]: Collecting choosen components
2017-06-14 18:14:29 [Trace]: Cleaning install pages
2017-06-14 18:14:29 [Debug]: P2P Component has been choosen
2017-06-14 18:14:29 [Information]: Starting P2P installation
2017-06-14 18:14:29 [Trace]: Recreating progress bar
2017-06-14 18:14:29 [Debug]: Installation initializator has been finished
2017-06-14 18:14:29 [Information]: P2P installation started
2017-06-14 18:14:29 [Trace]: Downloader::setFilename launcher-p2p-install-windows.py
2017-06-14 18:14:29 [Debug]: Requesting file info for /kurjun/rest/raw/info
2017-06-14 18:14:30 [Debug]: Received file info for /kurjun/rest/raw/info: [{"id":"5a4fd682029e21cd4cf7a0f88b3bc88e","size":1153,"name":"launcher-p2p-install-windows.py","owner":["launcher"],"filename":"launcher-p2p-install-windows.py"}]
2017-06-14 18:14:30 [Debug]: Owner: launcher
2017-06-14 18:14:30 [Debug]: Name: launcher-p2p-install-windows.py
2017-06-14 18:14:30 [Debug]: ID: 5a4fd682029e21cd4cf7a0f88b3bc88e
2017-06-14 18:14:30 [Debug]: Size: 1153
2017-06-14 18:14:30 [Information]: Downloaded launcher-p2p-install-windows.py installation script
2017-06-14 18:14:30 [Debug]: Starting Download thread
2017-06-14 18:14:30 [Debug]: Unregistering HTTP(S) Stream factory
2017-06-14 18:14:30 [Error]: Failed to unregister HTTP(S) Stream factory
2017-06-14 18:14:30 [Debug]: Registering HTTP Stream Factory
2017-06-14 18:14:30 [Debug]: Requesting https://devcdn.subut.ai:8338/kurjun/rest/raw/get?name=launcher-p2p-install-windows.py
2017-06-14 18:14:30 [Information]: File launcher-p2p-install-windows.py already exists
2017-06-14 18:14:30 [Information]: Verifying C:\Users\Dilshat\subutai\\tmp\\launcher-p2p-install-windows.py MD5 checksum
2017-06-14 18:14:30 [Information]: File launcher-p2p-install-windows.py is up to date
2017-06-14 18:14:30 [Debug]: Starting scripting language interface
2017-06-14 18:14:30 [Trace]: SL::Opening tmp path: C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:30 [Trace]: SL::Open path C:\Users\Dilshat\subutai\\tmp\\launcher-p2p-install-windows.py
2017-06-14 18:14:30 [Trace]: SL::open dir: C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:30 [Trace]: SL::open file: launcher-p2p-install-windows.py
2017-06-14 18:14:30 [Debug]: Starting execution in thread
2017-06-14 18:14:30 [Debug]: Preparing script for execution
2017-06-14 18:14:30 [Debug]: Notification Center locked
2017-06-14 18:14:30 [Information]: Starting script execution: [ERRFMT]
2017-06-14 18:14:30 [Trace]: SL::execute syspath: [ERRFMT], dir: C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:30 [Debug]: subutaistart() entry point was not found
2017-06-14 18:14:30 [Trace]: SL_AddStatus ~ Downloading p2p binary
2017-06-14 18:14:30 [Trace]: SL_UnregisterService ~ Subutai P2P
2017-06-14 18:14:30 [Trace]: Starting new Environment instance
2017-06-14 18:14:30 [Information]: Unregistering Subutai P2P Windows Service
2017-06-14 18:14:30 [Debug]: Checking NSSM tool
2017-06-14 18:14:30 [Trace]: NSSM tool exists
2017-06-14 18:14:30 [Debug]: NSSM tool found
2017-06-14 18:14:30 [Debug]: Running command: nssm.exe remove "Subutai P2P" confirm
2017-06-14 18:14:30 [Trace]: NSSM has been executed
2017-06-14 18:14:30 [Error]: Service installation failed. Exit code: 3
2017-06-14 18:14:30 [Trace]: Environment::~Environment
2017-06-14 18:14:30 [Trace]: SL_Download ~ p2p.exe
2017-06-14 18:14:30 [Trace]: Downloader::setFilename p2p.exe
2017-06-14 18:14:30 [Debug]: Requesting file info for /kurjun/rest/raw/info
2017-06-14 18:14:31 [Debug]: Received file info for /kurjun/rest/raw/info: [{"id":"fc94daae2434852ffe9fbbf4c4e297a9","size":6181376,"name":"p2p.exe","owner":["jenkins"],"version":"4.0.15-10-gd455d0c.","filename":"p2p.exe"}]
2017-06-14 18:14:31 [Debug]: Owner: jenkins
2017-06-14 18:14:31 [Debug]: Name: p2p.exe
2017-06-14 18:14:31 [Debug]: ID: fc94daae2434852ffe9fbbf4c4e297a9
2017-06-14 18:14:31 [Debug]: Size: 6181376
2017-06-14 18:14:31 [Debug]: Action received: 1
2017-06-14 18:14:31 [Debug]: Starting Download thread
2017-06-14 18:14:31 [Debug]: Unregistering HTTP(S) Stream factory
2017-06-14 18:14:31 [Debug]: Registering HTTP Stream Factory
2017-06-14 18:14:31 [Debug]: Requesting https://devcdn.subut.ai:8338/kurjun/rest/raw/get?name=p2p.exe
2017-06-14 18:14:31 [Information]: File p2p.exe already exists
2017-06-14 18:14:31 [Information]: Verifying C:\Users\Dilshat\subutai\\tmp\\p2p.exe MD5 checksum
2017-06-14 18:14:31 [Information]: File p2p.exe is up to date
2017-06-14 18:14:31 [Debug]: Action received: 2
2017-06-14 18:14:31 [Trace]: SL_AddStatus ~ Downloading extra tools
2017-06-14 18:14:31 [Trace]: SL_Download ~ nssm.exe
2017-06-14 18:14:31 [Trace]: Downloader::setFilename nssm.exe
2017-06-14 18:14:31 [Debug]: Requesting file info for /kurjun/rest/raw/info
2017-06-14 18:14:34 [Debug]: Received file info for /kurjun/rest/raw/info: [{"id":"d8b92a87c135e366eebfab7e7c6423ff","size":368640,"name":"nssm.exe","owner":["mike"],"filename":"nssm.exe"}]
2017-06-14 18:14:34 [Debug]: Owner: mike
2017-06-14 18:14:34 [Debug]: Name: nssm.exe
2017-06-14 18:14:34 [Debug]: ID: d8b92a87c135e366eebfab7e7c6423ff
2017-06-14 18:14:34 [Debug]: Size: 368640
2017-06-14 18:14:34 [Debug]: Action received: 1
2017-06-14 18:14:34 [Debug]: Starting Download thread
2017-06-14 18:14:34 [Debug]: Unregistering HTTP(S) Stream factory
2017-06-14 18:14:34 [Debug]: Registering HTTP Stream Factory
2017-06-14 18:14:34 [Debug]: Requesting https://devcdn.subut.ai:8338/kurjun/rest/raw/get?name=nssm.exe
2017-06-14 18:14:34 [Information]: Starting file downloads [nssm.exe]
2017-06-14 18:14:35 [Debug]: Action received: 2
2017-06-14 18:14:35 [Trace]: SL_GetTmpDir
2017-06-14 18:14:35 [Trace]: SL_GetInstallDir
2017-06-14 18:14:35 [Trace]: SL_AddStatus ~ Download finished. Installing P2P
2017-06-14 18:14:35 [Trace]: SL_AddStatus ~ Installing Service Manageer
2017-06-14 18:14:35 [Trace]: Starting new Environment instance
2017-06-14 18:14:35 [Trace]: Environment::~Environment
2017-06-14 18:14:35 [Trace]: SL_AddStatus ~ Making P2P binary executable
2017-06-14 18:14:35 [Trace]: SL_AddStatus ~ Registering P2P as a Windows service
2017-06-14 18:14:35 [Trace]: SL_RegisterService ~ Subutai P2P C:\Users\Dilshat\subutai\bin/p2p.exe|daemon
2017-06-14 18:14:35 [Trace]: Starting new Environment instance
2017-06-14 18:14:35 [Information]: Registering C:\Users\Dilshat\subutai\bin/p2p.exe as a Windows Service
2017-06-14 18:14:35 [Debug]: Checking NSSM tool
2017-06-14 18:14:35 [Trace]: NSSM tool exists
2017-06-14 18:14:35 [Debug]: NSSM tool found
2017-06-14 18:14:35 [Trace]: Executing NSSM: Name: Subutai P2P Path: C:\Users\Dilshat\subutai\bin/p2p.exe
2017-06-14 18:14:35 [Debug]: Running command: nssm.exe install "Subutai P2P" "C:\Users\Dilshat\subutai\bin\p2p.exe" "daemon"
2017-06-14 18:14:35 [Trace]: NSSM has been executed
2017-06-14 18:14:35 [Information]: Service was installed
2017-06-14 18:14:35 [Trace]: Environment::~Environment
2017-06-14 18:14:45 [Trace]: SL_Shutdown
2017-06-14 18:14:45 [Debug]: Action received: 5
2017-06-14 18:14:45 [Information]: Script execution completed without any errors
2017-06-14 18:14:46 [Debug]: Notification Center unlocked
2017-06-14 18:14:46 [Information]: launcher-p2p-install-windows.py script execution completed
2017-06-14 18:14:46 [Debug]: Stopping installation process and notifying parent
2017-06-14 18:14:46 [Debug]: Looking for next component
2017-06-14 18:14:46 [Debug]: Next component found
2017-06-14 18:14:46 [Debug]: Collecting choosen components
2017-06-14 18:14:46 [Trace]: Cleaning install pages
2017-06-14 18:14:46 [Trace]: Deactivating P2P Installation page
2017-06-14 18:14:46 [Debug]: Tray Component has been choosen
2017-06-14 18:14:46 [Information]: Starting Tray installation
2017-06-14 18:14:46 [Trace]: Recreating progress bar
2017-06-14 18:14:46 [Debug]: Installation initializator has been finished
2017-06-14 18:14:46 [Trace]: Parent notified
2017-06-14 18:14:46 [Information]: Tray installation started
2017-06-14 18:14:46 [Trace]: Downloader::setFilename launcher-tray-install-windows.py
2017-06-14 18:14:46 [Debug]: Requesting file info for /kurjun/rest/raw/info
2017-06-14 18:14:48 [Debug]: Received file info for /kurjun/rest/raw/info: [{"id":"ad3e0e3cf75c5a233fc72f749c4a7d09","size":856,"name":"launcher-tray-install-windows.py","owner":["launcher"],"filename":"launcher-tray-install-windows.py"}]
2017-06-14 18:14:48 [Debug]: Owner: launcher
2017-06-14 18:14:48 [Debug]: Name: launcher-tray-install-windows.py
2017-06-14 18:14:48 [Debug]: ID: ad3e0e3cf75c5a233fc72f749c4a7d09
2017-06-14 18:14:48 [Debug]: Size: 856
2017-06-14 18:14:48 [Information]: Downloaded launcher-tray-install-windows.py installation script
2017-06-14 18:14:48 [Debug]: Starting Download thread
2017-06-14 18:14:48 [Debug]: Unregistering HTTP(S) Stream factory
2017-06-14 18:14:48 [Debug]: Registering HTTP Stream Factory
2017-06-14 18:14:48 [Debug]: Requesting https://devcdn.subut.ai:8338/kurjun/rest/raw/get?name=launcher-tray-install-windows.py
2017-06-14 18:14:48 [Information]: Starting file downloads [launcher-tray-install-windows.py]
2017-06-14 18:14:48 [Debug]: Starting scripting language interface
2017-06-14 18:14:48 [Trace]: SL::Opening tmp path: C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:48 [Trace]: SL::Open path C:\Users\Dilshat\subutai\\tmp\\launcher-tray-install-windows.py
2017-06-14 18:14:48 [Trace]: SL::open dir: C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:48 [Trace]: SL::open file: launcher-tray-install-windows.py
2017-06-14 18:14:48 [Debug]: Starting execution in thread
2017-06-14 18:14:48 [Debug]: Preparing script for execution
2017-06-14 18:14:48 [Debug]: Notification Center locked
2017-06-14 18:14:48 [Information]: Starting script execution: [ERRFMT]
2017-06-14 18:14:48 [Trace]: SL::execute syspath: [ERRFMT], dir: C:\Users\Dilshat\subutai\\tmp\
2017-06-14 18:14:48 [Debug]: subutaistart() entry point was not found
2017-06-14 18:14:48 [Trace]: SL_AddStatus ~ Download Tray application
2017-06-14 18:14:48 [Trace]: SL_Download ~ SubutaiTray_libs.zip
2017-06-14 18:14:48 [Trace]: Downloader::setFilename SubutaiTray_libs.zip
2017-06-14 18:14:48 [Debug]: Requesting file info for /kurjun/rest/raw/info
2017-06-14 18:14:49 [Debug]: Received file info for /kurjun/rest/raw/info: [{"id":"a893130e9a2619a5a0289b2397d0e3b0","size":19263437,"name":"SubutaiTray_libs.zip","owner":["lezh1k"],"filename":"SubutaiTray_libs.zip"}]
2017-06-14 18:14:49 [Debug]: Owner: lezh1k
2017-06-14 18:14:49 [Debug]: Name: SubutaiTray_libs.zip
2017-06-14 18:14:49 [Debug]: ID: a893130e9a2619a5a0289b2397d0e3b0
2017-06-14 18:14:49 [Debug]: Size: 19263437
2017-06-14 18:14:49 [Debug]: Action received: 1
2017-06-14 18:14:49 [Debug]: Starting Download thread
2017-06-14 18:14:49 [Debug]: Unregistering HTTP(S) Stream factory
2017-06-14 18:14:49 [Debug]: Registering HTTP Stream Factory
2017-06-14 18:14:49 [Debug]: Requesting https://devcdn.subut.ai:8338/kurjun/rest/raw/get?name=SubutaiTray_libs.zip
2017-06-14 18:14:49 [Information]: Starting file downloads [SubutaiTray_libs.zip]
2017-06-14 18:15:41 [Debug]: Action received: 2
2017-06-14 18:15:41 [Trace]: SL_Download ~ ssh.zip
2017-06-14 18:15:41 [Trace]: Downloader::setFilename ssh.zip
2017-06-14 18:15:41 [Debug]: Requesting file info for /kurjun/rest/raw/info
2017-06-14 18:15:41 [Debug]: Received file info for /kurjun/rest/raw/info: [{"id":"fd18e94d5c67fe3d300575a7ab79058e","size":4188116,"name":"ssh.zip","owner":["b5c5ab4c1d3e4643df3ea877b709548775eb74f7"],"filename":"ssh.zip"}]
2017-06-14 18:15:41 [Debug]: Owner: b5c5ab4c1d3e4643df3ea877b709548775eb74f7
2017-06-14 18:15:41 [Debug]: Name: ssh.zip
2017-06-14 18:15:41 [Debug]: ID: fd18e94d5c67fe3d300575a7ab79058e
2017-06-14 18:15:41 [Debug]: Size: 4188116
2017-06-14 18:15:41 [Debug]: Action received: 1
2017-06-14 18:15:41 [Debug]: Starting Download thread
2017-06-14 18:15:41 [Debug]: Unregistering HTTP(S) Stream factory
2017-06-14 18:15:41 [Debug]: Registering HTTP Stream Factory
2017-06-14 18:15:41 [Debug]: Requesting https://devcdn.subut.ai:8338/kurjun/rest/raw/get?name=ssh.zip
2017-06-14 18:15:42 [Information]: File ssh.zip already exists
2017-06-14 18:15:42 [Information]: Verifying C:\Users\Dilshat\subutai\\tmp\\ssh.zip MD5 checksum
2017-06-14 18:15:42 [Information]: File ssh.zip is up to date
2017-06-14 18:15:42 [Debug]: Action received: 2
2017-06-14 18:15:42 [Trace]: SL_GetTmpDir
2017-06-14 18:15:42 [Trace]: SL_GetInstallDir
2017-06-14 18:15:42 [Trace]: SL_AddStatus ~ Installing Tray
2017-06-14 18:15:44 [Trace]: Starting new Environment instance
2017-06-14 18:15:44 [Trace]: Environment::CreateShortcut
2017-06-14 18:15:44 [Debug]: Shortcut for SubutaiTray.exe located in C:\Users\Dilshat\subutai\tray\ with name Subutai Tray.lnk

Fixed


Bug:

Describe the bug
In custom CLI commands, parameters containing dashes ('-') break the parsing of the command line.
CodeIgniter 4 version
CI 4.0.3
Affected module(s)
I suppose the problem is in CodeIgniter\CLI\BaseCommand.
Expected behavior, and steps to reproduce if appropriate
When running a custom command with some parameters, I expect to find the value of all parameters in $params array, but if one parameter value contains dashes, that parameter and the all following ones are missing in the array.
To reproduce, simply create a custom command:
<?php namespace App\Commands;

use CodeIgniter\CLI\BaseCommand;
use CodeIgniter\CLI\CLI;

class TestCmd extends BaseCommand
{
    protected $group        = "Test";
    protected $name         = "test:param";
    protected $usage        = "test:param param1 param2 param3 param4 ";

    public function run(array $params)
    {
        CLI::write(print_r($params, true));
    }

}

and run it with some parameters containing dashes:
spark test:param p1 p2-a p3 p4
Expected result:
Array
(
    [0] => p1
    [1] => p2-a
    [2] => p3
    [3] => p4
)

Actual result:
Array
(
    [0] => p1
)

Context

OS: Centos 8 Linux
Web server: Apache 2.4.37
PHP version:  7.2.24

should already fixed by https://github.com/codeigniter4/CodeIgniter4/pull/3208 please try develop branch

Ok, thank you.
Sorry for bothering with an already resolved issue.


Pointpillars - kitti modification possibilities

if  i wanted to use another backbone or bbox_head from other models in mmdetection3d,
without major changes in code, could i do it ?
and what are those that would be compatible ?
thanks in advance

Yes you can. For backbones supported in MMDet3D, you only need to change the config. The configs using RegNet are examples. For other backbones like ResNet, you might need to change the stem layers as they are a little bit different, you can also take the regnet as an example here.

for bbox_head, i can too?
can you give examples also? @ZwwWayne


Failed to update package using this package

 Failed to clone https://github.com/ramsey/uuid.git via https, ssh protocols, aborting.

   - https://github.com/ramsey/uuid.git
     fatal: unable to access 'https://github.com/ramsey/uuid.git/': SSL certificate problem: unable to get local issue
   r certificate

   - git@github.com:ramsey/uuid.git
     Could not create directory '/c/Users/\342\200\235\302\214\342\204\242/.ssh'.
     Host key verification failed.
     fatal: Could not read from remote repository.

     Please make sure you have the correct access rights
     and the repository exists.

Closing, since this is a network error. If you're still having this problem, you might need to check with GitHub support.


Threshold is missing on VectorizedQuery

Type of issue
Typo
Description
Feedback on Azure.Search.Documents.Models.VectorQuery Package: Azure.Search.Documents v11.6.0
Issue Identified:
It seems there is confusion or a possible discrepancy regarding the Threshold property in the VectorQuery class.
Details:
According to the Microsoft documentation, there is a Threshold property associated with VectorQuery. However, it appears that the VectorizedQuery class should inherit the Threshold property from VectorQuery, but currently, VectorQuery does not contain a Threshold property.
Potential Issues:

Documentation Error: There might be an error in the documentation where the Threshold property is mentioned, but the actual implementation does not include it.
Code Implementation Bug: Alternatively, the VectorQuery class might be intended to include the Threshold property, and its absence could be a bug in the codebase.

Request for Clarification:
Could you please confirm whether this issue is a documentation error or a bug in the code implementation? This clarification is essential for developers relying on the accuracy of both the documentation and the API's functionality.
Page URL
https://learn.microsoft.com/en-us/dotnet/api/azure.search.documents.models.vectorquery?view=azure-dotnet
Content source URL
https://github.com/Azure/azure-docs-sdk-dotnet/blob/master/xml/Azure.Search.Documents.Models/VectorQuery.xml
Document Version Independent Id
6c4d2760-ba6c-0339-348e-b6705b970ae9
Article author
@azure-sdk
Metadata

ID: fd72d24a-9347-4442-3820-a89d9ec38739
Service: azure

Hi @kim4848. Thank you for reaching out and we regret that you're experiencing difficulties.   The documentation that you're looking for is for prerelease versions of the library.   The VectorQuery property exists in 11.16.0-beta.4 version of the library, as it is tied to a beta feature of the service.   The stable package, 11.16.0, does not include this property because it is not supported by the stable version of the Azure Search service.   The stable version of the VectorQuery docs do not include this property.


TextBox DeleteHighlightedText crash

It is easy to reproduce this issue,please check it.

I can't figure out the steps to make this crash occur, can you please add them?

On OSX, when input words, it will input the terminal, but not in this textbox;
On windows10, when using mouse to select words, and as the same time to input words, it will crash.

windows is ok.
While on OSX the textbox input is still out to terminal, and get crash.
11112233444222019-12-04 10:44:10.896 dotnet[3681:2549534] WARNING: NSWindow drag regions should only be invalidated on the Main Thread! This will throw an exception in the future. Called from (
0   AppKit                              0x00007fff2a158607 -[NSWindow(NSWindow_Theme) _postWindowNeedsToResetDragMarginsUnlessPostingDisabled] + 378
1   AppKit                              0x00007fff2a1559f7 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 1479
2   AppKit                              0x00007fff2a15542a -[NSWindow initWithContentRect:styleMask:backing:defer:] + 45
3   AppKit                              0x00007fff2a9b6753 -[NSWindow init] + 75
4   libAvaloniaNative.dylib             0x000000010e8f73cf -[AvnWindow initWithParent:] + 63
5   libAvaloniaNative.dylib             0x000000010e8f8efd _ZN14WindowBaseImplC2EP20IAvnWindowBaseEvents + 445
6   libAvaloniaNative.dylib             0x000000010e8f8b06 _ZN10WindowImplC1EP16IAvnWindowEvents + 134
7   libAvaloniaNative.dylib             0x000000010e8f8a0b _Z15CreateAvnWindowP16IAvnWindowEvents + 59
8   libAvaloniaNative.dylib             0x000000010e8ef22f _ZN14AvaloniaNative12CreateWindowEP16IAvnWindowEventsPP10IAvnWindow + 63
9   ???                                 0x0000000113c2d4c2 0x0 +<PHONE_NUMBER>
10  ???                                 0x0000000113c2d012 0x0 +<PHONE_NUMBER>
11  ???                                 0x0000000113c2cf19 0x0 +<PHONE_NUMBER>
12  ???                                 0x0000000113c1225f 0x0 +<PHONE_NUMBER>
13  ???                                 0x00000001145c1a79 0x0 +<PHONE_NUMBER>
14  ???                                 0x00000001145c19e3 0x0 +<PHONE_NUMBER>
15  ???                                 0x00000001145c197f 0x0 +<PHONE_NUMBER>
16  ???                                 0x00000001145c16ff 0x0 +<PHONE_NUMBER>
17  ???                                 0x00000001137447f1 0x0 +<PHONE_NUMBER>
18  ???                                 0x000000011374a1e2 0x0 +<PHONE_NUMBER>
19  ???                                 0x000000011372ed82 0x0 +<PHONE_NUMBER>
20  ???                                 0x0000000113744661 0x0 +<PHONE_NUMBER>
21  ???                                 0x0000000113744478 0x0 +<PHONE_NUMBER>
22  ???                                 0x000000011374440b 0x0 +<PHONE_NUMBER>
23  ???                                 0x0000000113726beb 0x0 +<PHONE_NUMBER>
24  libcoreclr.dylib                    0x000000010cfe4029 _ZN18MethodDescCallSite16CallTargetWorkerEPKmPmi + 1657
25  libcoreclr.dylib                    0x000000010cffeef8 _Z32QueueUserWorkItemManagedCallbackPv + 184
26  libcoreclr.dylib                    0x000000010cfa4fa3 _ZL31ManagedThreadBase_DispatchOuterP22ManagedThreadCallState + 323
27  libcoreclr.dylib                    0x000000010cfa55c0 ZN17ManagedThreadBase10ThreadPoolEPFvPvES0 + 32
28  libcoreclr.dylib                    0x000000010cf9bcb4 ZN26ManagedPerAppDomainTPCount16DispatchWorkItemEPbS0 + 276
29  libcoreclr.dylib                    0x000000010cfc95cf _ZN13ThreadpoolMgr17WorkerThreadStartEPv + 1311
30  libcoreclr.dylib                    0x000000010ce1d384 _ZN7CorUnix10CPalThread11ThreadEntryEPv + 436
31  libsystem_pthread.dylib             0x00007fff58c4c2eb _pthread_body + 126
32  libsystem_pthread.dylib             0x00007fff58c4f249 _pthread_start + 66
33  libsystem_pthread.dylib             0x00007fff58c4b40d thread_start + 13

I haven't been able to figure out the issue with keystrokes not getting captured on OSX, and I can't get Avalonia to run without crashing right now on OSX so I can't compare.  I'll have to retry some time later.

Looks like it's related to not using OSX window decorations.  Commenting out this line seems to fix it:
https://github.com/modern-forms/Modern.Forms/blob/master/src/Modern.Forms/Form.cs#L28

It is about the action when input . When input words, on osx it will input to the terminal but not in the textbox.

Did you try commenting out that line? That fixes it for me, but obviously it makes the window look weird.

I already try it.But still like that, and the window look weird.

Looks like I mixed up what actually fixed it for me.  It was actually this commit updating the Avalonia Mac backend: https://github.com/modern-forms/Modern.Forms/commit/0006e5aeacb27136e2b9021984b48e5f7124e609.
So updating to the latest should fix it.

Closing because I think this is fixed. If it still occurs, please feel free to reopen.


Service Controller Watch possible infinite loop during LB creation

I am using the openstack cloudprovider to bring up a cluster and create an external LB. I then ran into a weird problem and tried to debug a little and think found what the problem is, but there are a few things that I could not explain and have a theory that I want someone to refute.
This is the log I have in kube-controller-manager
Jun 05 05:54:55 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:55.844360   11533 servicecontroller.go:188] Got new Added delta for service: &{TypeMeta:{Kind: APIVersion:} ObjectMeta:{Name:esfrontend GenerateName: Namespace:default SelfLink:/api/v1beta3/namespaces/default/services/esfrontend UID:8c3c215f-0b42-11e5-975c-74dbd1a077b0 ResourceVersion:2466 CreationTimestamp:2015-06-05 05:20:15 +0000 UTC DeletionTimestamp:<nil> Labels:map[name:elasticsearch] Annotations:map[]} Spec:{Ports:[{Name: Protocol:TCP Port:80 TargetPort:{Kind:0 IntVal:9200 StrVal:}}] Selector:map[name:elasticsearch role:load-balancer] PortalIP:<IP_ADDRESS> CreateExternalLoadBalancer:true PublicIPs:[] SessionAffinity:None} Status:{}}
Jun 05 05:54:55 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:55.858084   11533 servicecontroller.go:268] Creating LB for service default/esfrontend
Jun 05 05:54:55 kubernetes-master-7957 kube-controller-manager[11533]: E0605 05:54:55.865276   11533 servicecontroller.go:153] Failed to process service delta. Retrying: failed to create external load balancer for service default/esfrontend: Unable able to find service matching lbname: a8c3c215f0b4211e5975c74dbd1a077b
Jun 05 05:54:56 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:56.054567   11533 servicecontroller.go:188] Got new Added delta for service: &{TypeMeta:{Kind: APIVersion:} ObjectMeta:{Name:esfrontend GenerateName: Namespace:default SelfLink:/api/v1beta3/namespaces/default/services/esfrontend UID:77dba985-0b43-11e5-975c-74dbd1a077b0 ResourceVersion:2733 CreationTimestamp:2015-06-05 05:26:50 +0000 UTC DeletionTimestamp:<nil> Labels:map[name:esfrontend] Annotations:map[]} Spec:{Ports:[{Name: Protocol:TCP Port:80 TargetPort:{Kind:0 IntVal:9200 StrVal:}}] Selector:map[name:elasticsearch role:load-balancer] PortalIP:<IP_ADDRESS> CreateExternalLoadBalancer:true PublicIPs:[] SessionAffinity:None} Status:{}}
Jun 05 05:54:56 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:56.073351   11533 servicecontroller.go:268] Creating LB for service default/esfrontend
Jun 05 05:54:56 kubernetes-master-7957 kube-controller-manager[11533]: E0605 05:54:56.088323   11533 servicecontroller.go:153] Failed to process service delta. Retrying: failed to create external load balancer for service default/esfrontend: Unable able to find service matching lbname: a77dba9850b4311e5975c74dbd1a077b
Jun 05 05:54:57 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:57.303412   11533 openstack.go:209] Claiming to support Instances
Jun 05 05:54:57 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:57.890623   11533 servicecontroller.go:188] Got new Added delta for service: &{TypeMeta:{Kind: APIVersion:} ObjectMeta:{Name:elasticsearch GenerateName: Namespace:default SelfLink:/api/v1beta3/namespaces/default/services/elasticsearch UID:d53988ed-0b43-11e5-975c-74dbd1a077b0 ResourceVersion:2820 CreationTimestamp:2015-06-05 05:29:27 +0000 UTC DeletionTimestamp:<nil> Labels:map[name:elasticsearch] Annotations:map[]} Spec:{Ports:[{Name: Protocol:TCP Port:80 TargetPort:{Kind:0 IntVal:9200 StrVal:}}] Selector:map[name:elasticsearch role:load-balancer] PortalIP:<IP_ADDRESS> CreateExternalLoadBalancer:true PublicIPs:[] SessionAffinity:None} Status:{}}
Jun 05 05:54:57 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:57.890930   11533 servicecontroller.go:235] Deleting existing load balancer for service default/elasticsearch that needs an updated load balancer.
Jun 05 05:54:57 kubernetes-master-7957 kube-controller-manager[11533]: I0605 05:54:57.962485   11533 servicecontroller.go:268] Creating LB for service default/elasticsearch
Jun 05 05:54:57 kubernetes-master-7957 kube-controller-manager[11533]: E0605 05:54:57.994480   11533 servicecontroller.go:153] Failed to process service delta. Retrying: failed to create external load balancer for service default/elasticsearch: Unable able to find service matching lbname: ad53988ed0b4311e5975c74dbd1a077b

As you can see it is basically an infinite loop where the servicecontroller is trying to create an LB after it has an Add delta on a external routable service and not able to find the service to get a list of endpoints (I am building my lb pool with the endpoints).  The sequence of events which led to this issue are as follows:

Created an RC with 3 replicas
Created a service with external LB => Placed on FIFO Queue as Added Delta
Called Delete Service, which deleted the API server's service object of my service -> Placed on FIFO Queue as Deleted Delta
processDelta Called for add event and CreateTCPLB failed due to a connection reset. Since this is retriable, the delta has been placed back on the queue.
Now Deleted Delta is processed (There was nothing to be deleted, hence moved on, but the apiserver's service object has been deleted by now).
Now the AddedDelta comes back up to get processed (for a service that no longer exists)

Is this an expected behavior ? I might not be the best at explaining this, but let me know if I can be more clear on this.
And the Queue is
NewServiceCreate <- SomeOp <- NewServiceDelete <- SomeOp

The CreateTCPLB for the NewServiceCreated failed so added back to the queue. It is now:
SomeOp <- NewServiceDelete <- SomeOpAgain <- NewServiceCreate

After a while:
NewServiceDelete <- SomeOpAgain <- NewServiceCreated

After this, the service is completely deleted and now it is only
NewServiceCreated

Should we be processing this delta ? I ask this because, this delta has been undone by an other delta event before the Create Delta has been processed.

You can reproduce this by:

Induce an error returned at CreateTCPLoadbalancer function in the cloudprovider
Build a cluster with this
Create a service (with externalLB set to true) on top of some pods.
Delete service

The 3rd step should fail and be set for retry.

Eventually, I got a panic on the kube-controller-manager
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: I0606 05:47:54.261241    4647 servicecontroller.go:169] Got delta of service %!s(*api.Service=<nil>)
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: I0606 05:47:54.261255    4647 servicecontroller.go:173] Not OK
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: panic: runtime error: invalid memory address or nil pointer dereference
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: [signal 0xb code=0x1 addr=0x0 pc=0x57d68a]
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: goroutine 102 [running]:
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider/servicecontroller.(*ServiceController).processDelta(0xc2085b0af0, 0xc20860ec40, 0x0, 0x0, 0x0)
Jun 06 05:47:54 kubernetes-master-7427 kube-controller-manager[4647]: /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/cloudprovider/servicecontroller/servicecontroller.go:185 +0xc4a


[Feature Request]: Create and make 404 error page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Create and make 404 error page
Use Case
Create and make 404 error page
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Is there an existing issue for this?

[x]  I have searched the existing issues

Feature Description
Create and make 404 error page
Use Case
Create and make 404 error page
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[x]  I have read the Contributing Guidelines
[x]  I'm a GSSOC'24 contributor
[x]  I have starred the repository

Hello @arunimaChintu , Go for it
All the Best

@Trisha-tech can i work on this?

@Trisha-tech can i work on this?

Hello @Sourabh782, Go for it
All the Best


feat: resource grant methods

Add a permissions API on resources, that exposes grant methods on subjects.

💚 All backports created successfully

Status
Branch
Result

✅
k8s-22/main

✅
k8s-23/main

Questions ?
Please refer to the Backport tool documentation


[TS] issue matching on parent compound state when using TypeStates

Description
Given a machine with a compound state where states have been modelled using TypeStates e.g
{
  parentState: {
    states: {
      childState1: {},
      childState2: {}
  },
  otherState: {}
}

When using state.matches you get a Typescript error when using state.matches('parentState'). This forces running a match on each combination of parentState and childState. This isn't an issue when not using TypeStates.
Expected Result
You should be able to match on just parentState to include all childState combinations
Actual Result
You get a TS Error
Reproduction
codesandbox reproduction
(see line 66 for TS error)

Moving forward, we do not recommend using typestates because they are unsafe – it is possible to create an impossible typesafe. With the upcoming typegen, we will eventually be able to safely infer typestates.

Interesting, is there somewhere I can hear more about the typegen plans?
I'm currently working on a library where I generate a machine via a factory function. This is partly so that my consumers could pass some types via a generic to include in the machine's Context type. Would this be supported by the typegen approach or would it only work where you have a fully formed machine with a fixed Context type?

Beta support for the typegen has been just released in<EMAIL_ADDRESS>It requires our VS Code extension.
The config argument passed to the createMachine has to be statically analyzable for this to work. If you only want to configure parts of the context type using factories - then it should work quite OK (but we have not tested such a scenario). Configuring the shape of actual states etc is not supported though. If you need that - I would love to learn more about your use case but I wouldn't expect to add support for this any time soon (we have higher priority items to work on at the moment).

That's very exciting! I'll try it out as soon as I can.
I think the shape of the states is stable in my use case so hopefully this will work. I had considered whether I could use factories to optionally add features to a machine but it's not something I'm currently working on.
An example use-case might be if I was creating a drag and drop library, I might want to optionally include a feature in the machine which waits till a certain threshold 'distance has been moved' or 'time has been elapsed' before the drag is activated. This might be desired by some users but not by others and so you might want to tweak the machine based on a config.
I'm sure this could be achieved in other ways though e.g. include all the functionality in the machine but set the threshold to zero if the user isn't using the feature.

I think the shape of the states is stable in my use case so hopefully this will work. I had considered whether I could use factories to optionally add features to a machine but it's not something I'm currently working on.

That would technically be possible at runtime but this makes stuff like visualization much harder. So my general advice is that - just don't try to do this. I don't think there is good RoI for us supporting this kind of a thing at the tooling level.

An example use-case might be if I was creating a drag and drop library, I might want to optionally include a feature in the machine which waits till a certain threshold 'distance has been moved' or 'time has been elapsed' before the drag is activated. This might be desired by some users but not by others and so you might want to tweak the machine based on a config.

This can still be achieved with factory parameters and guards+always transitions in the machine.

I'm sure this could be achieved in other ways though e.g. include all the functionality in the machine but set the threshold to zero if the user isn't using the feature.

Yeah, there are ways around that 👍


Broken links from bill tracker

https://pmg.org.za/node/47644
https://pmg.org.za/committees/Finance Standing Committee

The first of these now works, and billtracker has been pulled into the main site. The second one won't work until we have nicely named URLs, which is in Pivotal.


Add the manual link for the DAO page

Description
https://dashboard.bknd1.ninja.tf/#/tf-chain/dao, 2.3.0-alpha6
Add the manual link for the DAO to the DAO page.
I don't know which one is it, but I found some links: https://manual.grid.tf/dashboard/dashboard.html?highlight=dao#tfchain-dao, https://manual.grid.tf/dashboard/dao_voting/dao_voting.html?highlight=dao#an-introduction-to-the-dao-concept.
Steps to reproduce

Navigate to the Dashboard.
Connect your wallet.
Navigate to the DAO page.

Logs/Alerts

verified on devnet
version : 5b50681

Verified:

Devnet
6a9a049


ComboBox selection is hidden if SelectedIndex does not return "-1" between

This example has a model that has a ComboBox of string objects. If I update the items of the ComboBox, then the selection is hidden no matter what order I fire events and no matter if the old index is available in range of the new items. I have to manually click the empty ComboBox and select my item in the UI because it's not working in code-behind at all.
<ComboBox Items="{Binding SelectableItems}" SelectedIndex="{Binding Index}" />

private int _index = 0; // Default to first item works
public int Index
{
  get => _index;
  private set
  {
    if (value == -1)
    {
      _index = 0; // Issue is here because -1 was not successfully set
      OnPropertyChanged(nameof(Index));
    }
    else if (value != _index)
    {
      _index = value;
      OnPropertyChanged(nameof(Index));
    }
  }
}
private IEnumerable<string> _selectableItems = new[] { "Default" };
public IEnumerable<string> SelectableItems
{
  get => _selectableItems;
  private set
  {
    _selectableItems = value;
    OnPropertyChanged(nameof(SelectableItems));
  }
}

private void UpdateItems(object[] items)
{
  // Setting selectable items sets the selected index to -1 for no reason
  if (items.Length == 0)
  {
    SelectableItems = new[] { "Default" };
  }
  else
  {
    SelectableItems = items.Select(o => o.ToString());
  }
  Index = 0; // No selection even though I'm telling it to select 0 here and in the setter
  /* Same nonsense if you fire in reverse order
  Index = 0;
  SelectableItems = items;
  */
}

The issue goes away if you let -1 be successfully set (and then change the selected index again right after). This is not going to work when you are using unsigned types for your selected index, so you would need to work around it like this:
private byte _trueValue; // Cannot be -1 (and I do not want -1 selection on a ComboBox anyway)
private bool _avaloniaIssue = true;
public int Index
{
    get => _avaloniaIssue ? -1 : (int)_trueValue;
    set
    {
        if (value == -1)
        {
            _avaloniaIssue = true;
            OnPropertyChanged(nameof(Index));
        }
        else
        {
            _avaloniaIssue = false;
            _trueValue = (byte)value;
            OnPropertyChanged(nameof(Index));
        }
    }
}

The workaround returns -1 when this issue would occur, and then I immediately set the index back to 0.

Hmm, this in fact seems to be the same issue as #4048 - the problem is that the selected item isn't preserved when Items is changed. Closing this in favor of #4048 - should have a fix soon.


Bug - unexpected panic

panic.zip
Homotopy in S19 causes panic.

This is not a panic. I believe that the code isn't even buggy here, it's just horrendously slow - or rather, the algorithm we are using isn't fast enough.
During expansion, factorization is called, which initialises a MonotoneSequences iterator of length 20, with max value 18:
MonotoneSequences::new(20, 18).
The monotone sequence is a guess for the underlying monotone of the factorization rewrite being constructed, and the number of sequences which exist for these parameters is 38 C 18 =<PHONE_NUMBER>0 ( (length 20 array, each value can range 0-18 --- monotonicity means that counting this is equivalent to describing where the initial segment of zeroes ends, the second segment of 1s ends, etc... equivalent to the number of ways 18 bars can be placed between 20 digits, i.e. (20 + 18) choose 18).
I think we need to be smarter about iterating through all of these, because this number seems too large. The current implementation is to iterate through all possible monotone sequences lexicographically. Any ideas @jamievicary?

We could try to make the search smart enough to only iterate over monotones
that compose properly, i.e. that aren't rejected by the first check in the
factorisation thing. This means that we only consider those assignments of
h(i) which are in the preimage g^{-1}(f(i)) when we try to find h s.t.
h(g(i)) = f(i); since g is monotone, that preimage is an interval, so we
could try iterating over the cartesian product of these intervals.
On Mon, 26 Jul 2021, 17:02 Nick Hu, @.***> wrote:

This is not a panic. I believe that the code isn't even buggy here, it's
just horrendously slow - or rather, the algorithm we are using isn't fast
enough.
During expansion, factorization is called, which initialises a
MonotoneSequences iterator of length 20, with max value 18:
MonotoneSequences::new(20, 18).
The monotone sequence is a guess for the underlying monotone of the
factorization rewrite being constructed, and the number of sequences which
exist for these parameters is 38 C 18 =<PHONE_NUMBER>0 ( (length 20 array,
each value can range 0-18 --- monotonicity means that counting this is
equivalent to describing where the initial segment of zeroes ends, the
second segment of 1s ends, etc... equivalent to the number of ways 18 bars
can be placed between 20 digits, i.e. (20 + 18) choose 18).
I think we need to be smarter about iterating through all of these,
because this number seems too large. The current implementation is to
iterate through all possible monotone sequences lexicographically. Any
ideas @jamievicary https://github.com/jamievicary?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886828795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXKJP5BXSPZPFITPQISMTTZWBH7ANCNFSM5AX2M4TQ
.

*h such that g(h(i)) = f(i).
On Mon, 26 Jul 2021, 17:13 Lukas Heidemann, @.***> wrote:

We could try to make the search smart enough to only iterate over
monotones that compose properly, i.e. that aren't rejected by the first
check in the factorisation thing. This means that we only consider those
assignments of h(i) which are in the preimage g^{-1}(f(i)) when we try to
find h s.t. h(g(i)) = f(i); since g is monotone, that preimage is an
interval, so we could try iterating over the cartesian product of these
intervals.
On Mon, 26 Jul 2021, 17:02 Nick Hu, @.***> wrote:

This is not a panic. I believe that the code isn't even buggy here, it's
just horrendously slow - or rather, the algorithm we are using isn't fast
enough.
During expansion, factorization is called, which initialises a
MonotoneSequences iterator of length 20, with max value 18:
MonotoneSequences::new(20, 18).
The monotone sequence is a guess for the underlying monotone of the
factorization rewrite being constructed, and the number of sequences which
exist for these parameters is 38 C 18 =<PHONE_NUMBER>0 ( (length 20 array,
each value can range 0-18 --- monotonicity means that counting this is
equivalent to describing where the initial segment of zeroes ends, the
second segment of 1s ends, etc... equivalent to the number of ways 18 bars
can be placed between 20 digits, i.e. (20 + 18) choose 18).
I think we need to be smarter about iterating through all of these,
because this number seems too large. The current implementation is to
iterate through all possible monotone sequences lexicographically. Any
ideas @jamievicary https://github.com/jamievicary?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886828795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXKJP5BXSPZPFITPQISMTTZWBH7ANCNFSM5AX2M4TQ
.

Cartesian product of what exactly? Each interval of the preimage of g?

Yeah, so we need a value of h(i) for every i in the domain. Through the
requirement that g(h(i)) = f(i) we know that h(i) must be in the interval
g^{-1}(f(i)). Naively we could search for assignments of h(i) restricted to
those intervals each, and filter for monotonous sequences. A bit less
naively we could integrate this with the monotone iteration thing.
On Mon, 26 Jul 2021, 17:23 Nick Hu, @.***> wrote:

Cartesian product of what exactly? Each interval of the preimage of g?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886846442,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXKJN53LVQBQEWV7XSJRLTZWDWXANCNFSM5AX2M4TQ
.

Agrees. The space of possibly-valid monotones is much smaller and quite
easy to describe I think.
On Mon, 26 Jul 2021, 17:27 Lukas Heidemann, @.***>
wrote:

Yeah, so we need a value of h(i) for every i in the domain. Through the
requirement that g(h(i)) = f(i) we know that h(i) must be in the interval
g^{-1}(f(i)). Naively we could search for assignments of h(i) restricted to
those intervals each, and filter for monotonous sequences. A bit less
naively we could integrate this with the monotone iteration thing.
On Mon, 26 Jul 2021, 17:23 Nick Hu, @.***> wrote:

Cartesian product of what exactly? Each interval of the preimage of g?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886846442
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AACXKJN53LVQBQEWV7XSJRLTZWDWXANCNFSM5AX2M4TQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886849640,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ4OHQVZOLZF26KRKCAYZDTZWEIFANCNFSM5AX2M4TQ
.

Another optimisation could arise from this: when the recursive
factorisation fails in the case that h(i) = j for some h, then it also
fails for all other h' with h'(i) = j. Accounting for this might avoid a
lot of churn.
On Mon, 26 Jul 2021, 18:31 jamievicary, @.***> wrote:

Agrees. The space of possibly-valid monotones is much smaller and quite
easy to describe I think.
On Mon, 26 Jul 2021, 17:27 Lukas Heidemann, @.***>
wrote:

Yeah, so we need a value of h(i) for every i in the domain. Through the
requirement that g(h(i)) = f(i) we know that h(i) must be in the interval
g^{-1}(f(i)). Naively we could search for assignments of h(i) restricted
to
those intervals each, and filter for monotonous sequences. A bit less
naively we could integrate this with the monotone iteration thing.
On Mon, 26 Jul 2021, 17:23 Nick Hu, @.***> wrote:

Cartesian product of what exactly? Each interval of the preimage of g?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<

https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886846442

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AACXKJN53LVQBQEWV7XSJRLTZWDWXANCNFSM5AX2M4TQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886849640
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ACQ4OHQVZOLZF26KRKCAYZDTZWEIFANCNFSM5AX2M4TQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-886892566,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXKJIUEBHVW2XAFOH65K3TZWLWTANCNFSM5AX2M4TQ
.

I believe I have fixed this in 9112364. It's essentially Lukas's suggestion to search for the underlying monotone by looking in the preimage of $g$. There's no caching, as it seems fast enough now: the expansion move at the head of this issue is now near instant, but strangely I need to do it twice before it visually shows up. I have confirmed that the first drag does a successful expansion, and so does the second, but for some reason the first one doesn't visually cause the diagram to change. I think it's a consequence of only looking at this 2D projection.

That's excellent Nick thank you. Hao do you agree the issue is resolved?
Your last point about the display not updating is weird. I don't see why
that would be to do with the 2d projection. Does the first interaction
actually change the global diagram?
On Tue, 27 Jul 2021, 21:16 Nick Hu, @.***> wrote:

I believe I have fixed this in 9112364
https://github.com/homotopy-io/homotopy-rs/commit/911236469a82c6ea70c96667f3c702050516a875.
It's essentially Lukas's suggestion to search for the underlying monotone
by looking in the preimage of $g$. There's no caching, as it seems fast
enough now: the expansion move at the head of this issue is now near
instant, but strangely I need to do it twice before it visually shows up. I
have confirmed that the first drag does a successful expansion, and so does
the second, but for some reason the first one doesn't visually cause the
diagram to change. I think it's a consequence of only looking at this 2D
projection.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/123#issuecomment-887804996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ4OHTEOX5PJBS6RMIF5IDTZ4HYBANCNFSM5AX2M4TQ
.

This looks fine to me. The global diagram does indeed update with your fix after doing the homotopy once. The reason that the view does not update properly is a manifestation of issue #30. So I think this can be closed.


Add auto-generate sample for Maps and NetworkFunction

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.


Create InsightAppsec API integration for Shuffle

https://docs.rapid7.com/insightappsec/api-get-started

More:


typescript react testing.

TypeScript Version:  2.5.2
Code
https://github.com/nfq-eta/react-typescript/blob/6099865d118f885c99afd5e11afacadf73457ab8/src/components/tests/App.test.tsx#L27-L37

Expected behavior:
Should be no error
Actual behavior:
[ts] Property 'handleClick' does not exist on type 'Component<any, any>'.

If there is a problem here, we have no idea what it is.  Why do you feel that this is a TypeScript bug, and do you have a more minimal repro if so?

A type assertion will get you what you want: (wrapper.instance() as App).handleClick(
As to why it's necessary, unfortunately the shallow wrapper can't know about your instance methods. JSX is a bit of a black hole for type information. The type of the expression <App /> is completely disconnected from the type of App. So by the time we get to .instance() on the wrapper, the best the type definitions can do is tell you that there's probably stuff from the React.Component base class on there, but it doesn't know about anything else.

@jwbay - thanks for the grreeat explanaition. And for the suggested fix. Respect :speak_no_evil:

I apologize, but the influx of issues being filed we have means that we don't have the time to dive into every project's codebase. Our bandwidth is relatively limited so asking us to diagnose a whole project or learn Enzyme's API is a bit much.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Allow Optional Resource Group target

Expose option to deploy new microservice resources into an existing resource group

Thanks for the PR! I like the change and glad you added this, just have one minor suggested change.
I was just being asked about adding this today by someone else :)

Thanks for the PR! I like the change and glad you added this, just have one minor suggested change.
I was just being asked about adding this today by someone else :)


Enhance error output when package file not found - RELENG_2_2

I had a system that had upgraded but the Notes package had not managed to (re)install. In that situation the Notes item is on the Status menu but there is no notes.xml or other notes code on the the system.
When I go to Status->Notes I get:
Warning: substr_compare(): The start position cannot exceed initial string length in /usr/local/www/pkg.php on line 56 File not found notes.xml
The warning is because realpath() returns false in this case and cannot be used is a parameter to substr_compare().
Handle this case, and make the error message more informative.
Note: In RELENG_2_2 print_info_box_np() puts a "Close" button and has no way to stop that. It looks dumb, but that can be cleaned up in 2.3 master. I am just doing this in RELENG_2_2 to avoid the PHP warning.

I will make a similar PR for this in 2.3 master after checking what currently happens in 2.3-BETA


1dvars cmtb v2

@collins-frf need to fix a few things before merging.  The call to writeAllFiles needs to be reverted back to the previous form.  Also the gitmodules code should not be updated on the repo with your local changes.

@thesser1  updated logic for slack and pflag commands to move files


Error: svelte-scrolling doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module

Hey @valmisson thanks for this awesome plugin! However, after updating this plugin from 1.1.1 to 1.2.0 I'm getting this error.
Error:  svelte-scrolling doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.
Version:

svelte-scrolling: 1.2.0
svelte-kit: 1.0.0-next.348

Thanks for reporting, this issue has been fixed in v1.2.1


Create License

I enjoyed this project.  I wanted to use your code for commercial purposes but you have no license attached to it.  I'm wondering if you would be able to attach a license with something reasonable?

Hi, as stated in the comments the code is based on the rosetta code page
http://rosettacode.org/wiki/K-d_tree
so I'm not sure how it works in terms of licensing

Come to think of it I didn't use any of the code iself, just the algorithm, which is in the public domain, so that is a non-issue. Licensed.


Bridge getExtraInfos

Hello, my firstname is Aurelien
I'm very impressed by this project and I want to congratulate the community.
The purpose of this pull request is to allow custom Bridges to pass additionals ExtraInfos to customs Formats without rewriting default behaviour.

I have made the change you requested. Thank you for your review.


KeyError: "Column(s) ['GPUMemoryUtilization', 'GPUUtilization'] do not exist" for non-GPU instances

I tried to benchmark two inf2 instances against teach other.
I got the error KeyError: "Column(s) ['GPUMemoryUtilization', 'GPUUtilization'] do not exist"
error excerpt and config file attached.
However, it does work for configs/llama2/7b/config-llama2-7b-inf2-g5.yml
I think this is because the g5 instance does have those values, so the GPU columns exist in the dataframe.
error log excerpt.txt
Inf2-TGIvLMI.txt

I confirmed it.  If I add the configuration for a g5 onto the end of my config file, everything works.

ACK. Will fix this.

Any ETA on this?

this is fixed as of v1.0.47.

I am getting the error:
KeyError: "Column(s) ['GPUMemoryUtilization', 'GPUUtilization'] do not exist"

I am using ml.inf2.48xlarge machines to run benchmark.


patches: next: Remove return type error patch

A better patch from Arnd was merged, which causes my patch to break the
build:
<EMAIL_ADDRESS>

I have pushed another fix because our latest -next run failed to start due to a patch we were carrying being merged.


[BUG]Training speed of deepspeed>0.12.5 becomed slower than before!

about 5% slowdown when training with pipeline parallelism and megatron-deepspeed

Hi @janelu9 - could you let us know what baseline DeepSpeed version you are comparing with?

Hi @janelu9 - could you let us know what baseline DeepSpeed version you are comparing with?  And that this is the same "issue" as #4881 ?

this version is faster https://github.com/microsoft/DeepSpeed/files/13825076/deepspeed-0.12.4.zip

Thanks, so something between 0.12.4 and 0.12.5, I'll git bisect between those and see if I can tell, can you share your torch version as well so I'm running the same tests?  As well as if you have a small repro case or one from DeepSpeed Examples?

Thanks, so something between 0.12.4 and 0.12.5, I'll git bisect between those and see if I can tell, can you share your torch version as well so I'm running the same tests? As well as if you have a small repro case or one from DeepSpeed Examples?

My torch version==2.1.2+cu118, I don't have a repro published, I test them with Llama-7B of 8 stages in pipeline engine on one node of 8 A100-40G.

@janelu9 - I'll have to test a repro with V100s probably and a smaller model, and it is possible that it won't repro there in the same way.
If it is easy for you to run your test, could you try with pip install deepspeed git+https://github.com/microsoft/DeepSpeed.git@a7900bcc3d2f7789cc734aa28a11d2f3b3d8b04f to help bisect the search space?

@janelu9 - I'll have to test a repro with V100s probably and a smaller model, and it is possible that it won't repro there in the same way.
If it is easy for you to run your test, could you try with pip install git+https://github.com/microsoft/DeepSpeed.git@a7900bcc3d2f7789cc734aa28a11d2f3b3d8b04f to help bisect the search space?

Well, this version is the faster one which was 10.3 samples/sec while the latest one was 9.9 samples/sec. Otherwise, I quoted flash-attn in my model codes.

The one installed from the git link was also faster?  If so, could you also try this one?
pip install git+https://github.com/microsoft/DeepSpeed.git@b83b1c2e1c4dc4c91c4ad78773dc2232ca9f7070
I suspect the issue may come from transformers since we updated our transformers requirement in the timeframe of 0.12.4 to 0.12.5, but if you're able to test with the above version and let us know if it appears to show the performance degradation or not, that would help, thanks!

The one installed from the git link was also faster? If so, could you also try this one?
pip install git+https://github.com/microsoft/DeepSpeed.git@b83b1c2e1c4dc4c91c4ad78773dc2232ca9f7070
I suspect the issue may come from transformers since we updated our transformers requirement in the timeframe of 0.12.4 to 0.12.5, but if you're able to test with the above version and let us know if it appears to show the performance degradation or not, that would help, thanks!

this version is fastest up to now , its speed is about 10.4 samples/sec

Thanks @janelu9 -
If you're able, lets try this one then?
pip install git+https://github.com/microsoft/DeepSpeed.git@449e454f83bb6a14b0de359660d4b206d5c3feed
This only contains a few additional fixes but I want to make sure they don't cause an impact, the remaining PRs do change some user args behavior so if this still does not reproduce the performance degradation we can look into that.
Thanks!

this version seems a little slower, about 10.1 samples/sec

Thanks @janelu9 -
If you're able, lets try this one then?
pip install git+https://github.com/microsoft/DeepSpeed.git@449e454f83bb6a14b0de359660d4b206d5c3feed
This only contains a few additional fixes but I want to make sure they don't cause an impact, the remaining PRs do change some user args behavior so if this still does not reproduce the performance degradation we can look into that.
Thanks!

this version seems a little slower, about 10.1 samples/sec

Thanks, can you test this as well?
pip install git+https://github.com/microsoft/DeepSpeed.git@65b7727758a4c0ee08597a88ab4f051abcfc2a8a
That should only contain two additional PRs that refactor user arg parsing, so should not impact anything, but would be good to run the test as well.  Thanks!

Thanks, can you test this as well?
pip install git+https://github.com/microsoft/DeepSpeed.git@65b7727758a4c0ee08597a88ab4f051abcfc2a8a
That should only contain two additional PRs that refactor user arg parsing, so should not impact anything, but would be good to run the test as well. Thanks!

this version hadn't slowdown yet

Thanks, that should have all the changes from v0.12.5, can you test with this one as well to confirm, since this should be after we update the tag:
pip install git+https://github.com/microsoft/DeepSpeed.git@4d866bd55a6b2b924987603b599c1f8f35911c4b

Thanks, that should have all the changes from v0.12.5, can you test with this one as well to confirm, since this should be after we update the tag:
pip install git+https://github.com/microsoft/DeepSpeed.git@4d866bd55a6b2b924987603b599c1f8f35911c4b

What's puzzling is that all the speeds of 0.12.4<deepspeed<=0.12.5 is now the same, maybe it also be related to torch, but the versions>=0.12.6 are still slower .

Thanks, that should have all the changes from v0.12.5, can you test with this one as well to confirm, since this should be after we update the tag:
pip install git+https://github.com/microsoft/DeepSpeed.git@4d866bd55a6b2b924987603b599c1f8f35911c4b

This version is faster.
@loadams  Are you tracing the problem using the idea of binary search?

@janelu9 that's correct, but we've now completed the entire search space between 0.12.4 and 0.12.5 without seeing a significant slowdown, correct?

@janelu9 that's correct, but we've now completed the entire search space between 0.12.4 and 0.12.5 without seeing a significant slowdown, correct?

Yes，no one has a significant slowdown

@janelu9 that's correct, but we've now completed the entire search space between 0.12.4 and 0.12.5 without seeing a significant slowdown, correct?

@loadams please give me all the tags between 0.12.5 and 0.12.6 order by commit time. I'd like to test them to find where the problem is.

@janelu9 - here is that list of commits, https://github.com/microsoft/DeepSpeed/compare/v0.12.5...v0.12.6
It looks to only be 13 commits, so should be fairly easy to binary search that space.  Please let me know if you need anything else.

git+https://github.com/microsoft/DeepSpeed.git@

Well, now I have found the key commit leads to the slowdown:
https://github.com/microsoft/DeepSpeed/tree/d5a7c1e0b494fbd0958bf8274bde0bacb2c16854
@loadams check it please.

@janelu9 - here is that list of commits, v0.12.5...v0.12.6
It looks to only be 13 commits, so should be fairly easy to binary search that space. Please let me know if you need anything else.

Well, I have found the key commit leads to the slowdown:
https://github.com/microsoft/DeepSpeed/tree/d5a7c1e0b494fbd0958bf8274bde0bacb2c16854
@loadams, please check it out!

Thanks, @inkcherry any idea why this might be slower?  Nothing in !4318 that appears to cause a slowdown, and to confirm, @janelu9 you don't have graph harvesting enabled?

hi, @loadams @janelu9
I use 8 * A100 80G, with this script https://github.com/microsoft/Megatron-DeepSpeed/blob/main/examples_deepspeed/pretrain_llama2_distributed.sh
I only changed the setting from pp=2 tp=2 to pp=8 tp=1.（of course, this is not the best configuration for this hardware. It's just for comparing the performance before and after the modification）  it seems that there is no performance issue.
Could you share more parameters and configuration information about your workload?
- log with ds before this commit:
steps: 50 loss: 8.4555 iter time (s): 1.464 samples/sec: 21.860
steps: 60 loss: 8.4218 iter time (s): 1.456 samples/sec: 21.975
steps: 70 loss: 8.1501 iter time (s): 1.460 samples/sec: 21.916
- log with ds on this commit:
steps: 50 loss: 8.4555 iter time (s): 1.427 samples/sec: 22.431
steps: 60 loss: 8.4218 iter time (s): 1.433 samples/sec: 22.335
steps: 70 loss: 8.1501 iter time (s): 1.400 samples/sec: 22.862

Thanks, @inkcherry any idea why this might be slower? Nothing in !4318 that appears to cause a slowdown, and to confirm, @janelu9 you don't have graph harvesting enabled?

I'm not sure if I opened graph harvesting, how to confirm it? I just build the model using PipelineModule

@janelu9  It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

@janelu9 It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

sorry， it's incompatible for me, my torch version is 2.1.2+cu118

@janelu9 It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

sorry， it's incompatible for me, my torch version is 2.1.2+cu118
@janelu9
Thank you for your attempt. This is consistent with what you mentioned in the key commit version. You can see the commits list, with only one change where I added a patch in one commit.
you can try install ds by
 git clone https://github.com/inkcherry/DeepSpeed.git
pip uninstall deepspeed ; cd DeepSpeed ; git checkout for_5175;  python setup.py install

@janelu9 It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

sorry， it's incompatible for me, my torch version is 2.1.2+cu118

@janelu9 Thank you for your attempt. This is consistent with what you mentioned in the key commit version. You can see the commits list, with only one change where I added a patch in one commit.
could you try install ds by
 git clone https://github.com/inkcherry/DeepSpeed.git
pip uninstall deepspeed ; cd DeepSpeed ; git checkout for_5175;  python setup.py install

con't import torch._six

@janelu9 It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

sorry， it's incompatible for me, my torch version is 2.1.2+cu118

@janelu9 Thank you for your attempt. This is consistent with what you mentioned in the key commit version. You can see the commits list, with only one change where I added a patch in one commit. could you try install ds by  git clone https://github.com/inkcherry/DeepSpeed.git pip uninstall deepspeed ; cd DeepSpeed ; git checkout for_5175; python setup.py install

Do you have any ideas else? need I offer you my train codes? but it's not allowed by my company

@janelu9 It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

sorry， it's incompatible for me, my torch version is 2.1.2+cu118

@janelu9 Thank you for your attempt. This is consistent with what you mentioned in the key commit version. You can see the commits list, with only one change where I added a patch in one commit. could you try install ds by  git clone https://github.com/inkcherry/DeepSpeed.git pip uninstall deepspeed ; cd DeepSpeed ; git checkout for_5175; python setup.py install

Do you have any ideas else? need I offer you my train codes? but it's not allowed by my company

https://github.com/inkcherry/DeepSpeed/tree/for_5175
https://github.com/microsoft/DeepSpeed/tree/d5a7c1e0b494fbd0958bf8274bde0bacb2c16854
Hi, @janelu9
I'm not sure why one of these two versions runs smoothly while the other encounters the "con't import torch._six" issue. I think this shouldn't happen if you've correctly installed both versions (or maybe I missed some installation steps causing this problem? @loadams ).

I think this commit didn't make significant changes to the default computation path. If it affects performance, the only possible change might be switching from grad to None to grad.zero(). Both of these operations shouldn't significantly impact time, but the only difference could potentially affect memory usage and consequently performance.
Could you please try making some modifications to your installation location? In the file
deepspeed/runtime/bf16_optimizer.py, under this function:
    for group in self.bf16_groups:
        for param in group:
            if param.grad is not None:
                # Using zero_() fixed memory address for graph replay
                param.grad.zero_()```

change it to

def clear_lp_grads():
for group in self.bf16_groups:
for param in group:
param.grad = None

@janelu9 It's not easy for me to reproduce your model. Could you try this branch? Will it solve your issue? https://github.com/inkcherry/DeepSpeed/tree/for_5175

sorry， it's incompatible for me, my torch version is 2.1.2+cu118

@janelu9 Thank you for your attempt. This is consistent with what you mentioned in the key commit version. You can see the commits list, with only one change where I added a patch in one commit. could you try install ds by  git clone https://github.com/inkcherry/DeepSpeed.git pip uninstall deepspeed ; cd DeepSpeed ; git checkout for_5175; python setup.py install

Do you have any ideas else? need I offer you my train codes? but it's not allowed by my company

https://github.com/inkcherry/DeepSpeed/tree/for_5175
https://github.com/microsoft/DeepSpeed/tree/d5a7c1e0b494fbd0958bf8274bde0bacb2c16854
Hi, @janelu9
I'm not sure why one of these two versions runs smoothly while the other encounters the "con't import torch._six" issue. I think this shouldn't happen if you've correctly installed both versions (or maybe I missed some installation steps causing this problem? @loadams ).

I think this commit didn't make significant changes to the default computation path. If it affects performance, the only possible change might be switching from grad to None to grad.zero(). Both of these operations shouldn't significantly impact time, but the only difference could potentially affect memory usage and consequently performance.
Could you please try making some modifications to your installation location? In the file deepspeed/runtime/bf16_optimizer.py, under this function:
def clear_lp_grads(self):
    for group in self.bf16_groups:
        for param in group:
            if param.grad is not None:
                # Using zero_() fixed memory address for graph replay
                param.grad.zero_()

change it to
def clear_lp_grads():
    for group in self.bf16_groups:
        for param in group:
            param.grad = None

Yes, that is where the key is. It speeds up obviously from 9.97 to 10.24 after I changed it

Thanks @inkcherry for the debug work on this, please tag me here when you have a PR with a fix, and we can work on getting that tested and merged!

Thanks for your help, @inkcherry

Thanks @inkcherry for the debug work on this, please tag me here when you have a PR with a fix, and we can work on getting that tested and merged!

I just send a fix as we disscussed, hope it's helpful for you @janelu9 , and thanks for the help of @loadams !

@inkcherry, this is greatly appreciated. Thanks!


CSS leaking with external stylesheets

I'm using my child element within my parent element. If the parent element uses an external stylesheet the CSS rules in the sheet will affect the child element. If the parent element use an internal style the rules are kept to the parent only.
Is this intended or a bug? Thanks!

Forget this. I accidently put the CSS rule in the external sheet inside a


Initial support for java and cpp lambdas

We already have a LambdaExpression node but neither java nor cpp have handlers to assemble it. This PR adds initial support to handle lambdas.
Tasks:

[x] Implement Java handler
[x] Implement CPP handler
[ ] Connect the EOG

[ ] Called inside function
[ ] Passed as argument to known function
[ ] Passed as argument to unknown function

[x] Test variable resolving
[x] Support anonymous classes too (optional, if easy)

Closes #10 , closes #1005

Apparently I broke some tests, already on it.

@peckto will test this PR with more real-world samples


Obsoletion request: GO:0045204 MAPK export from nucleus & related

Please provide as much information as you can:

GO term ID and Label
GO:0045204 MAPK export from nucleus
GO:0045208 MAPK phosphatase export from nucleus
GO:0045209 MAPK phosphatase export from nucleus, leptomycin B sensitive
GO:0071701 regulation of MAPK export from nucleus

Reason for deprecation Put an x in the appropriate box:
Represents a specific substrate, out of scope for GO.

"Replace by" term (ID and label)
To be reviewed carefully, it seems many annotations represent a phenotype/readout of the cascade.

"Consider" term(s) (ID and label)
Suggestions for reannotation

Are there annotations to this term?

How many EXP:

Are there mappings and cross references to this term? (InterPro, Keywords; check QuickGO cross-references section)

Is this term in a subset? (check the AmiGO page for that term)

Any other information

Checklist for ontology editor
Check term usage and metadata in Protégé

[ ] check term usage in the ontology
[ ] check internal mappings: RHEA, EC, MetaCyc
[ ] check subset usage
[ ] check taxon constraints

Check annotations

[ ] create Annotation Review spreadsheet

Annotation Review template: https://docs.google.com/spreadsheets/d/1izV3q1jnq_Ybg5MJ53O_b5BCTkGtjl_Fi-cOg3-7eBE/edit#gid=0

Instructions: https://wiki.geneontology.org/Annotation_Review_Request

[ ] create annotation review ticket: https://github.com/geneontology/go-annotation/issues/new?assignees=&labels=annotation+review&template=annotation-review-for-obsoletion.md&title=Review+annotations+to+[INSERT+GO+TERM]
[ ] find external mappings (via IEAS), include in obsoletion notice
[ ] tag curators in Annotation Review ticket. Responsible annotator for each group: https://github.com/geneontology/go-site/blob/master/metadata/group-contacts.csv

Notification

[ ] create obsoletion announcement
[ ] announce to GO friends<EMAIL_ADDRESS>[ ] paste the text in the ontology ticket

@raymond91125 FYI I have not yet ran the annotation review.


Re-export UnprefixedHexError in the bitcoin crate root

Re-export UnprefixedHexError in the bitcoin crate root
Fixes #2874

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.12%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19549

Relevant Lines:
23519

💛  - Coveralls

Please commit the API changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
89 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 83.12%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/taproot/mod.rs
22
78.13%

bitcoin/src/bip32.rs
67
87.57%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19539

Relevant Lines:
23507

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
89 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 83.12%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/taproot/mod.rs
22
78.13%

bitcoin/src/bip32.rs
67
87.57%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19539

Relevant Lines:
23507

💛  - Coveralls

should i squash them all into one commit?

There are a few problems with this PR:

The api changes are incorrect because you have to use cargo public-api v0.35.0 (since #2893) but we never documented that - my bad.
This doesn't close the issue because it leaves all the other error types in the units::parse module still unreachable.

#2874 is not a trivial issue to solve, it requires quite some thought (that is why I raised the issue instead of fixing the problem). For more context, for niche error types we typically expose the module so users can do foo::BarError.
So basically, the re-export of units and stuff in units is broken - the UnprefixedHexError is just one example of the broken-ness.
To move forward, and to close the issue, there needs to be some thought put into the units re-exports. FTR the re-exports everywhere are not perfect, we have not 100% nailed down the best way to re-export things.

Ah bother, the check-api stuff is a mess. I'll try fix it on master so you don't have to worry about it.

Your check-api problems stem from, I believe, the method used to install cargo-public-api. Try removing it and re-installing using cargo install --locked<EMAIL_ADDRESS>See #2900 for context.

Your check-api problems stem from, I believe, the method used to install cargo-public-api. Try removing it and re-installing using cargo install --locked<EMAIL_ADDRESS>See #2900 for context.

I did some digging and realized this was the issue and ran just check-api, which resulted in the 3 lines being added for the API changes (how it currently looks). Previously, i had just done a cargo install cargo-public-api which resulted in the 1700+ line diff

For more context, for niche error types we typically expose the module so users can do foo::BarError.

I've only started taking a look at the repo recently - do we know how niche the units::parse errors are? For more common error types, is there a desired way to export them?

Ah I misspoke, I should have said "for niche use cases we typically expose the module". So we need a module so users can do parse::UnprefixedHexError. The question is should it be exposed at bitcoin's crate root eg, should users be able to do
pub use bitcoin::parse;

...
// The use `parse::UnprefixedHexError`

or should they have to go to units?
pub use bitcoin::units::parse;

(Remembering that we are missing a pub extern crates units also.)

hmm i think that since that those error types aren't used only for the types in units (a couple examples of uses outside units here and here), it would make sense to expose it at the bitcoin crate root with pub use bitcoin::parse; This would also give us some flexibility if for whatever reason we move those errors out of units, we could just update the reexport block from
pub mod parse {
    /// Re-export everything from the [`units::parse`] module.
    pub use units::parse::ParseIntError;
    pub use units::parse::UnprefixedHexError;
}

to
pub mod parse {
    /// Re-export everything from the [`units::parse`] module.
    pub use some::new::path::ParseIntError;
    pub use some::new::path::UnprefixedHexError;
}

without affecting the end user. Would like to hear your thoughts to make sure I didn't miss anything

Yeah, that looks good to me.

Nice, we can move forward on this @shinghim. We are in the process of eliminating wildcard imports so just in case you get tempted please don't use pub use units::parse::* :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.156%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19569

Relevant Lines:
23533

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.156%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19569

Relevant Lines:
23533

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.156%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19569

Relevant Lines:
23533

💛  - Coveralls

I think it makes sense. std/alloc/core do the same thing.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.094%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19508

Relevant Lines:
23477

💛  - Coveralls


With sequelize example

With-sequelize example.
Highlights:

Creates docker mysql container
Creates database
Seeds database
Displays database contents on homepage

I can move this example to master if you prefer.

@mschipperheyn for db setup, I usually put it into the package.json scripts as a setup and just add it as a requirement before running jest:
"scripts": {
  "unit": "./jest-setup/migrate-db.js && ./jest-setup/seed-db.js && test"
}

where migrate-db.js
const { spawn } = require('child-process-promise')

const run = async () => {
  const url = process.env.TEST_DB_URL = 'mysql://root@localhost:3306/database-test'
  try {
    await spawn('./node_modules/.bin/sequelize', ['db:migrate', `--url=${url}`], { stdio: 'inherit' })
    console.log('Migration success')
  } catch (e) {
    console.error('migration failed')
    process.exit(1)
  }
  process.exit(0)
}
run()

If you like, you can modify this PR (I know its quite old now, sorry for the delay) or I can just merge it in as is and you can make another PR when you have time to add this in?

@elliottjro hello, why you don't merge this 😎?

Could you do this against the finch branch?

Um, finch branch is now canary, can you do this against canary?


Mouse pointer jumps.

Mouse pointer jumps very offen while dragging.

I noticed that it sometimes jumps when releasing the fingers and replacing them on the touchpad, continuing the drag.
Are you talking about this ? Or does it jumps even when you don't release fingers ?

By the way, it is normal if the pointer jumps when dragging the ThreeFingersDragOnWindows app window title bar, I don't know why, but because it is the app itself, it can't work properly when you drag the window.
But it should work properly on any other window or on the desktop !

Ok,
I had the same issue on my laptop, but only something like once in twenty try.
I can't currently work on fixing this bug, but I'll try later.
Thanks for the report, I didn't think that it could appear more often on others touchpads.

Ok, I had the same issue on my laptop, but only something like once in twenty try. I can't currently work on fixing this bug, but I'll try later.
Thanks for the report, I didn't think that it could appear more often on others touchpads.

I fixed the issue like this, it works good for me.

Thank you very much !
I'll check this out and make a new release when I'm back home.

perhaps it reproduce when resize window (maybe 100%)

Ok, I had the same issue on my laptop, but only something like once in twenty try. I can't currently work on fixing this bug, but I'll try later.
Thanks for the report, I didn't think that it could appear more often on others touchpads.

perhaps it reproduce when resize window (maybe 100%)

I'm afraid I will not be able to update this app anymore.
I developed it in three days when I had a Windows laptop, but I don't have it anymore, and I figured out I had no wireless trackpad at home.
I hope someone will be able to fork this app to fix this bug.
Thank you !

Hey @ClementGre , great work on this app! I took inspiration from your project and wrote my own version which also fixes the bugs present in this project (ie. mouse pointer jump, not being able to drag certain apps/views). Please feel free to incorporate my fixes into your app if you choose.
I'm adding a link to my project here, hope its okay with you!
https://github.com/gurinderhans/threefingerdrag

Hey @ClementGre , great work on this app! I took inspiration from your project and wrote my own version which also fixes the bugs present in this project (ie. mouse pointer jump, not being able to drag certain apps/views). Please feel free to incorporate my fixes into your app if you choose.
I'm adding a link to my project here, hope its okay with you! https://github.com/gurinderhans/threefingerdrag

Hey @ClementGre , great work on this app! I took inspiration from your project and wrote my own version which also fixes the bugs present in this project (ie. mouse pointer jump, not being able to drag certain apps/views). Please feel free to incorporate my fixes into your app if you choose.
I'm adding a link to my project here, hope its okay with you! https://github.com/gurinderhans/threefingerdrag

Thanks for ur contribution! i have an idea about a new gesture which is compatible with windows original gesture, but since its developed over the buggy version, i tried to  read ur code but end up with giving up T_T. could u try it out in my repository and maybe consider add it to ur project?

Hi,
this issue happens because, when replacing fingers on the touchpad, you generally send a one or two finger input while removing/placing fingers.
Therefore, this allows me to detect a fingers replacement, and to reset the coordinates. But sometimes, you don't generate these events (removing exactly all fingers at the same time), and in these cases, I can't detect a fingers replacement, and the cursor is then bound to jump in function of the fingers replacement shift.
I added a threshold that prevent this issue, just like @91he did, and it now works perfectly, without any bug.
I'll make a release in a few days !


embedding logo

[Enter feedback here]
Hi...with the video shown, it pulls the logo from a public website.  When I send an email with this method to a user who opens the email in Outlook, the logo is not displayed.
How do I make the change so the logo is inclusive within the HTML code?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a984a46-1f7b-6ef1-71f3-c5df6c142c01
Version Independent ID: 4fab7da3-c9ae-0136-c693-ae99c1090f40
Content: Create organization-wide signatures and disclaimers - Microsoft 365 admin
Content Source: microsoft-365/admin/setup/create-signatures-and-disclaimers.md
Service: o365-administration
GitHub Login: @twernermsft
Microsoft Alias: twerner

@copenhaus Thank you for your feedback. If you would like to use a logo on the signature, you need to use a publicly available image. I was able to test it and the image is available on Outlook, outlook web app, or Mobile app. However,  if you continue to have this problem I'd recommend you to contact support who can help sort this out.
Hope this helps!
Thanks
Sri

Sri, thank you for your suggestion...sorry, don't to be mean, but why do you think Microsoft has this "feature" where the images via links are not downloaded automatically (Default settings) and why is the setting to undo it is buried under "Trust Center setting"?
In order for your suggestion to work, that means you have turned off "Don't download pictures automatically" in Trust Center and it potentially can download malicious images, which should not be acceptable under ANY circumstances.
Besides, the built-in image didn't work for us when sent from an iPhone (via Policy) either.

@msbemba  Thank you very much for the contribution and sharing this explanation. @copenhaus Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


one example that read from TiDB using TiSpark

General Question
can you show me one example that read from TiDB using TiSpark? I want to use Tispark connect to TIDB with scala，but I failed ,I hope someone can help me.  thanks a lot.

List your steps and show the error information

Thanks for your prompt reply !
ERROR Message: Table not exist TiTableReference(dm,
(select USER_NM,PASS_WORD from user_info) as t.
Tidb Version : 3.1.0.
Tispark Version 2.4.3
my code:
val df = sqlContext.read
.format("tidb")
.options(tidbOptions1)
.option("database", "dm")
.option("table", "(select USER_NM,PASS_WORD from user_info) as t")
.load()
Do Tispark have this api like spark JDBC which can use sql instead of table name?
Looking forward for your reply! Thanks a lot.

@superJazzy Please see the user guide in https://github.com/pingcap/tispark/blob/master/docs/userguide.md#Demonstration.
use spark.sql instead of Datasource Reader.

Thanks for your reply .
I have tried spark sql but faied.
ERROR Message :
org.apache.spark.sql.AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException: java.lang.RuntimeException: Unable to instantiate org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient;
It seems that when I use "spark.sql("use dm")" the program judges I want to read tables from hive. Do I miss any confige
in config file?

@superJazzy have you added this configuration

I haved added it in CDH like this

I used spark submit on using adding --jar tispark-assembly-2.4.3-scala_2.11.jar

I haved added it in CDH like this  I used spark submit on using adding --jar tispark-assembly-2.4.3-scala_2.11.jar

What is CDH
Maybe CDH spark conf is different from Apache spark. You can follow this

thank you for your reply.I have run it successfully.Thanks a lot


Leonardo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: leonardoliragama sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Be able to override the destination dbaas operator namespace from the command line

The namespace may not always be dbaas-operator. In our case, it was just lagoon.

This is great, thanks!
Everything looks good to me, I really like the wait instead of sleep. Very nice.


no learn.md

Issue Description
i am a begginer and unable to run the program in my pc i want a learn.md for this
Screenshots or Examples (if applicable)
No response
Proposed Solution (optional)
No response
Checklist

[X] I have checked the existing issues.
[X] I have read the Contributing Guidelines
[X] I have read the Code Of Conduct
[X] I joined onboarding group for knowledge flow and direct conversation and support from admins  Curious Developers Community - Curious Connect
[X] The changes don't break the code
[X] Please attach the screenshots and video of the development work once it is done
[X] If you need any help please join the default  (Google Meet Link)

@DesignDread Sorry for late reply but instead of learn.md, you can also follow our ReadMe File it contains link to all other related Documents. For Running our program you can read Project Setup
If you still have any questions Please onboard yourself to our WhatsApp Group Curious Developers Community - GSSoC  and connect with our admins


Collection log OSB

🐛 Bug Report
Write a description of the bug here, give all the information you can about what it is, how it happened.

Items that I fletched appear in the collection log

This is intentional.


Pinch and zoom on video wall is too sensitive

Describe the bug
The pinch and zoom seems to be very sensitive when using with the video wall. I've done the same on a laptop, phone, desktop and works perfectly fine. However, it all goes weird when using on the video wall. I'm really confused as to why the sudden change in behaviour.
I would be really grateful if you could help out.
Sandbox or Video
I've used your code for the pan and zoom.
https://codesandbox.io/s/elated-lichterman-oj203
Below is a video to better explain what I'm facing.
https://drive.google.com/file/d/1j-zJjAMNuCAy-rgzakcBItUS9_c-C7mG/view?usp=sharing
Information:

React Use Gesture version: 9.1.3
Device: 2X2 video wall
OS: mac os mojave
Browser : Chrome

Checklist:

[X] I've read the documentation.
[X] If this is an issue with drag, I've tried setting touch-action: none to the draggable element.

Hi, please provide a sandbox, I'm not sure what a video wall is.

Hi @dbismut. It's updated. Didn't realise I had already created an issue without the sandbox and the video. Apologies.

Hey, no problem. The video requires access you should let anyone view the link ;)

Apologies. Should be possible now.

I'll get back to you later today.

Hey @SevenSinS02 have a look at this comment https://github.com/pmndrs/react-use-gesture/issues/260#issuecomment-781272882.
Try installing 9.1.0-alpha.1 and see if this works out as described in there.
Let me know if you need further guidance.

@dbismut i will give that a try! Thanks a lot :)

Hi @dbismut . The sensitivity is still high. Any idea how I can adjust the pinch speed/ sensitivity.

Did you try multiplying the scale multiplier by a factor lower than 1?


Move build timout to build container

The build timeout is currently being enforced by the Drone server. It would be nice if, instead, this is enforced by the build container launched on the worker node.

this should perform the timeout in the build runner (container) instead of the server:
https://github.com/drone/drone/commit/b264e837fe31aa794d83f822c29c139421a90937
need to put it through some more testing, and then permanently remove the timeout code from the server, where it is currently disabled.