Travis build "not passing" randomly

Since Pull Request on dynamic dense joints, travis has troubles to build AND check successfully.
In fact there are two major problems that occur alternatively:
1/ When compiling the unittest urdf, there is an error in the flags ( there is a "urdf_CFLAGS-NOTFOUND " instead of "-I/usr/include/eigen3 -I/opt/openrobots/include" in the travis log).
I do not understand where this comes from* given that:

there are no changes in the travis build configuration
there are (almost) no changes in the CmakeLists : just one file added at a certain commit
urdfdom is found when generating the Makefile

2/ When error #1 does not occur, travis seem to "freeze" at the end of the build and then abort the procedure. The typical error message at the end of log is:
"  No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated "
If you go on https://travis-ci.org/stack-of-tasks/pinocchio/jobs/83854014 , you will see that it occured after all the test passed.
Note that it can happens only on gcc build, or clang build, or both.

I don't know why the flags are -NOTFOUND but i suppose it happens in the unittest/CMakeLists.txt at line 35
GET_TARGET_PROPERTY(${target}_CFLAGS ${target} COMPILE_FLAGS)
SET_PROPERTY(TARGET ${target} PROPERTY COMPILE_FLAGS "${${target}_CFLAGS} ${flag}")

Edit : When pushing to my own repository and running travis I have some "strange" behaviour. If you take a look at https://travis-ci.org/fvalenza/pinocchio/builds  the build #7 and #9.
The number 7 passed and number 9 did not whereas the only difference between them is the synchronization of travis and cmake submodule as suggested by @olivier-stasse

Pull Request #51 should - partially* - solve error 2/
Commit #c8ff00 solve error 1/

The random failures rate seems to decrease

It seems that this bug has been fixed via recent PR.


[SPARK-22499][FOLLOWUP][SQL] Reduce input string expressions for Least and Greatest to reduce time in its test

What changes were proposed in this pull request?
It's minor and trivial but looks 2000 input is good enough to reproduce and test in SPARK-22499.
How was this patch tested?
Manually brought the change and tested.
Locally tested:
Before: 3m 21s 288ms
After: 1m 29s 134ms
Given the latest successful build took:
ArithmeticExpressionSuite:
- SPARK-22499: Least and greatest should not generate codes beyond 64KB (7 minutes, 49 seconds)

I expect it's going to save 4ish mins.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1260/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93483 has started for PR 21855 at commit 0efe041.

Test build #93483 has finished for PR 21855 at commit 0efe041.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93483/
Test FAILed.

retest this please

LGTM.
With Spark 2.2, I have just confirmed the followings:
N=1500: passed
N=1800: exception
N=2000: exception

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1265/
Test PASSed.

Test build #93489 has started for PR 21855 at commit 0efe041.

Thanks, @kiszk!

Test build #93489 has finished for PR 21855 at commit 0efe041.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93489/
Test PASSed.

Merged to master, branch-2.3 and branch-2.1.


Added Blender 2.90.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run


Slightly tilted face

Assuming the people in the photos have a slightly tilted head (less than 30 degrees), would this software capture and un-rotate the face?

@DonaldTsang No this tool doesn't have that functionality. It's a pretty interesting idea though, I'll add the functionality when I find some free time. If you want to do it, PR's are welcomed.


Add computed category "extensions" to show methods in other packages

In a style similar to what Pharo does, compute a category named extensions in the browser in the category list.
It should be visually distinct from other categories and show all methods extended in other packages.

Now that we have the Package tab again, we can see which methods are in which package. I don't think a computed extensions category is still needed. Thoughts, @dalehenrich ?
The Pharo extension category is displayed for comparison.

We are trying to get away from using categories for packaging info, however, for the Monticello and RowanHybrid package conventions, the tonel file will record a fabricated *<package-name> category and there is no room to store an additional category name, so we can't put these  Monticello/RowanHybrid into anynormal category and almost "have to use" a computed category for those methods (similar to what Pharo does ... and for similar reasons)
The Rowan package convention does indeed ignore the category for packaging purposes, so we could continue to get away with defining a category for Rowan convention extension methods and I assume that these methods WOULD NOT show up in the computed category.
Rowan package convention is incompatible with Pharo and Monticello/RowanHybrid will have to be used for cross-platform projects.
My thoughts are that we should discuss this in more detail :smile:

Here's a first cut at a description of how we will be manipulating methods and I think that we might still want to have the computed extensions category ... but we have more information to work with ....
Tonel constraints
The method category field on disk must be defined.
RowanHybrid
*PACKAGE-NAME
Monticello
*PACKAGE-NAME
ROWAN
, default ‘other’
Jadeite Method Constraints

A method must be created in a category and by default it will be created in the package of it’s class. A class may be unpackaged (nil package field).

After creation a method may be moved to another package and will become an “extension method”
RowanHybrid/Monticello
The category of the method will become *PACKAGE-NAME and it will be displayed in the computed Extensions category
Rowan
The category of the method will remain unchanged, but the method will be displayed in its named category and the computed Extensions category

A method may be moved from an extension packaged to the package of its class
RowanHybrid/Monticello
The category will become the default category (‘other’) and it will no longer be displayed in the computed Extensions category
Rowan
If the original package was Rowan convention, it’s category will remain unchanged and it will no longer be displayed in the computed Extensions category.
if the original package was RowanHybrid or Monticello, it’s category will become ‘other’ and it will no longer be displayed in the computed extensions category.

A class may be moved to a different package and the method categories will have to be adjusted.
Rowan to RowanHybrid/Monticello
All of the extension methods that were in the target package will no longer be extension methods and will retain their original category.
All of the extension methods that remain extension methods will retain their category/extension method status.
All of the non-extension methods that were in the original package will be moved to the target package and will retain their original category.
RowanHybrid/Monticello to Rowan
All of the extension methods that were in the target package will no longer be extension methods and will be moved to the default category (‘other’).
All of the extension methods that remain extension methods will retain their category/extension method status.

All of the non-extension methods that were in the original package will be moved to the target package and will retain their original category.

Will need to describe what happens when an unpackaged class with extension methods is moved to Rowan and RowanHybrid/Monticello packages

It seems that the point of the computed extension category is not about displaying package information, but about how to deal with extension methods when the category tab is enabled, since some of the methods will not have a category defined and for those methods (in RowanHybrid and Monticello packages) we do not want to display the tonel category because we do not want users to think they can create or move a method to those categories ... remember we got here because we're trying to get out of the business of using the category for packaging information .. so I think it is "cleaner" to hide the tonel categories in the category tab than to disallow method creation or moves into the SPECIAL tonel categories... but cleaner or not is open to discussion ...
With Rowan packages the tonel category is not part of the convention so we could get away with not displaying Rowan package extensions in the computed category, but if we have an 'extensions' category that does not show all extension methods I think that is odd... but this is a debatable point as well

After discussions, having a simple computed extensions category is a helpful tool. I'll add that and we can make it more feature rich in the future if desired.

Computed extensions category seems to be mostly working.
category is purple
category can't be deleted
category only shows method extensions (purple) in the selected class
'extensions' category can still be created.
https://github.com/GemTalk/JadeiteForPharo/commit/796084af876378022046e99c0be23e0bea582c73


feat: Add 'isTransactional' attribute.

Did you test this - as in how this shows up in the trace information? Please also update the Trace catalog.

Did you test this - as in how this shows up in the trace information?

Yes. I also manually tested and observed the attribute in Cloud Trace.

Please also update the Trace catalog

Done


Add remote.pr_number to remote context of commits in changelog

Motivations
Needed for ratatui!
Solution

Fill pr_number of RemoteContributor struct.
Do it here: https://github.com/MarcoIeni/release-plz/blob/51416d4e9e69cfcdd3a12df069bace6d6f839b8f/crates/release_plz_core/src/changelog_filler.rs#L46

@MarcoIeni i can work on this issue if you can assign me this. Also is the ratatui issue you have mentioned a reference to this issue?

i can work on this issue if you can assign me this.

Done, thanks!

Also is the ratatui issue you have mentioned a reference to this issue?

Yes 👍

I'm not gonna lie the gitea part was a bit tricky since i have'nt used gitea till now


[FEATURE] Check that vulnerability assement is configured for Azure SQL

Your suggestion
According to WAF security recommendation it would be nice to have a PSRule to check the configured vulnerability assessment.
Alternatives
N/A
Additional context
No response

Thanks @peterbud. Is the request to check the results from a vulnerability assessment or that vulnerability assessment is enabled/ configured?

Hi @BernieWhite , the purpose would be to check that the vulnerability assessment is enabled / configured.


BUILD: actually fix review checklist

Debugged and validated solution on my own fork: https://github.com/mehalter/Catlab.jl/pull/1

It was a bit painful 😅 I just tested it (#813) and it worked great!


Flex: Update stop schema and add missing_stop_id rule

Describe the problem
In order to support Flex as a part of https://github.com/MobilityData/gtfs-validator/issues/1721, we need to

modify the stop schema so stop_id is no longer a required field
add a new rule for missing_stop_id and checks for ids across stop_id, location_group_id, and locations.id

Proposed solution

Test to check that missing_required_field is no longer triggered when stop_id is not provided
Add new missing_stop_id rule. Test with no-stop-id-for-trip-t_5735996_b_81516_tn_0.zip  I removed the stop_id associated with the trip_id t_5735996_b_81516_tn_0 in stop_times.txt from https://data.trilliumtransit.com/gtfs/islandtransit-wa-us/islandtransit-wa-us--flex-v2-TEST.zip to test this.
In depth review of acceptance test results, given the widespread implications of this change

File name

Spec language

Notice to update or add

Validator logic

Notice table columns

stops.txt, location_groups.txt, locations.geojson

In stops.txt:

stop_id

ID must be unique across all `stops.stop_id`, locations.geojson `id`, and `location_groups.location_group_id` values.

In stop_times.txt:

stop_id **Required** if `stop_times.location_group_id` AND `stop_times.location_id` are NOT defined.-

New notice to address use case that was previously covered in missing_required_field:

missing_stop_id

ERROR:
Generate if there is no stop_id, location_group_id, OR location_id

Description should specify that the producer should add stop_id to stops.txt

lineNumber and tripId

Alternatives you've considered
No response
Additional context
This seems to be the most substantial change to the previous files and requirements of the spec from the new Flex changes. We're curious to hear from consumers about this modification and the work required for them to incorporate this change.

Tasks:

[ ] Investigate if it's possible to keep the same missing required field notice in case of non-flex feeds

After further clarification, this change is not required. stop_id is still required in all cases where stops.txt is still provided. The decision to define stops.txt as conditionally required is an ongoing discussion in the spec: https://github.com/google/transit/issues/452


fyi, in case you're interested...

enjoy

Done. Thanks !
I've done some changes lately that I'ven't time to commit. I'll do that soon :)


[bug] Input & TextArea border issue

When I try to set a custom border width for Input and TextArea, on field focus, the field moves 1px to the left.
I cannot override border width on focus style.

Thank you

Probably connected to https://github.com/tamagui/tamagui/issues/725 as well

This should be fixed, but also the negative margin trick is specific to our default styles. You can reset it with unstyled prop, or just override it manually.

Should be fixed, lmk if still an issue.


Use deps

Use github.com/golang/deps to manage dependencies. It's cleaner.

It's difficult to know what is used and what is not in that repo, since it's doing nothing for the moment. But I removed the code (unused?) that depends on resources from k8s.io/kubernetes for now. I don't think it'd be a good idea to vendor kubernetes in kubectl.

Tests are failing on this PR since the "verify travis" script doesn't work well with the vendor directory. We need to merge #130 first.

@mengqiy I would really appreciate if you could review and maybe approve this change.
@hoegaarden Can you please review this quickly, even if its merged when you have time to do it?
Thank you!

/lgtm

/approve

I have to say using dep to manage apimachinery repo will make kinflate work harder.

See: https://github.com/kubernetes/kubectl/pull/144/commits/68011dc6ca9393c263ce924aee714c55b7f646bc#diff-a6c2ab3f6dea554a6f402bf4a9f269cfR73


#44 Update README.md due to update of clang-tools:all

Do you think we need to change the default version from 10 to some higher version, like 12 which is the default of clang-tools:all? or just keeping to 10 is good.
Personally, I usually prefer to use the newer version.

LTS releases are right around the corner. I think you can leave it as is for a while still. I read a while back that some are still using v8 (like adafruit org). I think Arduino will start using v12 soon.

I agree with your suggestion 👍


[BUG] Created album links lack domain information

Describe the bug
The album links do not include domain information and are therefore invalid.
To Reproduce
Steps to reproduce the behavior:

Navigate to the "Albums" page
Click on the expand icon for an album
Click on the green "Create new link" button
Examine the contents of the displayed link and notice that it lacks domain information

Expected behavior
A valid URL with domain information should be created
Screenshots

I'm closing this since the new version was just pushed to master.


ConsoleBox is not working under OS X

Currently the ConsoleBox does not work for OS X.
Fast fix: The code in ProcessTraceOSX could be copied to ConsoleBox.
Good fix: A refactoring of ProcessTrace and ConsoleBox is preferred solving also issue #3 .

#5 solves this


Update scalafmt-core to 3.4.1

Updates org.scalameta:scalafmt-core from 3.4.0 to 3.4.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #34 (a130c28) into main (e990afe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          316       316
  Branches         8         8
=========================================
  Hits           316       316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e990afe...a130c28. Read the comment docs.

Superseded by #35.


pg_activity -h connection to AWS RDS PostgreSQL is failing

FATAL: Must be run with database superuser privileges.
Any option to bypass this error? A subset of data displayed is acceptable.
Thanks & Regards
.... Sushanta

Has a --rds parameter
.
run pg_activity -U <your_user> -h <your_RDS_DNS_HOST> --rds

Has a --rds parameter
.
run pg_activity -U <your_user> -h <your_RDS_DNS_HOST> --rds

That worked! Thanks a lot!
.... Sushanta

That worked! Thanks a lot!
.... Sushanta


admins should be able to delete routes

The url has user.participant.username in it instead of participant.username.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/21592398-admins-should-be-able-to-delete-routes?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

The url has user.participant.username in it instead of participant.username.

Elaborate? I don't see where that is.

I think it's in JavaScript, Gratipay.username I think? When I try deleting a route through the UI as an admin I POST to /~whit537/routes/delete.json instead of /~the-user/routes/delete.json. I think it's in js/gratipay/routes.js.

Oh, okay I get it. I thought you were facing this problem with the workaround, hence the confusion.

Ah. :-)

@rohitpaulk I suppose I'll begin here.
To make sure I'm understanding correctly - Deleting routes is referring to deleting payment routes within the ~user that is currently logged in.  (Not another user)
Such as here:

The change that needs to be done refers to this line and it should reflect the suggested change @whit537 made....or am I over simplifying this?
Also what is the preferred method of testing Ajax calls?  I've used Chrome Dev Tools in the past - but I'm just curious.

To make sure I'm understanding correctly - Deleting routes is referring to deleting payment routes within the ~user that is currently logged in. (Not another user)

No, not exactly. Deleting routes works just fine for the ~user that is currently logged in. The bug is that deleting routes doesn't work as intended when an admin uses it. As an admin, you should able to visit ~bob's page and delete his route. If you try that on ~bob now (when signed in as ~kzisme) though, it'll end up deleting your route, and not ~bob's.

The change that needs to be done refers to this line and it should reflect the suggested change @whit537 made....or am I over simplifying this?

I don't think it's that simple :)
Did you have a look at https://github.com/gratipay/gratipay.com/issues/3548#issuecomment-111306137?

Also what is the preferred method of testing Ajax calls? I've used Chrome Dev Tools in the past - but I'm just curious.

Chrome dev tools works just fine for me...


Implement initial plugin auth on server and app

This is just an initial implementation, and there's still a few TODOs for cleanup and improvements.
But this basically covers all of the essential parts for server and UI parts of the planned plugin auth flow (see diagram below for a rough overview).

Let me know if you got any questions/concerns - this is obviously a bit complex, and I might create a proper diagram at some point if we need it.
Conventions

sessionId or the session secret is the session's identifier that's stored in our database. This is what we need to get to the client/game so it can prove its identity to us in the future (primarily to upload replays).
clientCode ("tempCode" in the diagram) is the temporary code generated by our server that identifies a client/game. It's used to retrieve the session after the user has logged in and proven his identity. After the plugin has retrieved the session, this code loses its meaning and can be removed from memory.
code or "auth code" is part of the standardized OAuth flow. The code is generated by the trackmania.com API, and we only send it around - we don't store it or modify it because it doesn't have any meaning to us. It is what proves to the trackmania.com API that the user has indeed logged in from our site, so it sends us the actual access token (which we then use to retrieve the real user data from trackmania.com) proving to us the user is who they say they are.

Server

Modified /auth route to generate clientCode and store it in the user document for later. Also changed response to now include that clientCode and the URL to log in on trackmania.com (including a dedicated redirect_uri and the clientCode inside the state query parameter).
/auth expects a sessionId, if it is present, it will check if there is a matching sessionId for said user, if not, it sends the authUrl and clientCode back to the plugin
Added TMDOJO_UI_URL env variable to be able to generate the correct redirect_uri - we'll have to always set that, but we could probably also define intelligent fallbacks in the future.
Modified /authorize route to also accept the clientCode. If it exists, check that the user's clientCode in the database and the one in the request are the same. If so, create an extra session and include the clientCode in there (so it can later be retrieved by the plugin). Also remove the clientCode from the user document so it can't be used again.
Note that a "normal" session is created either way - so the existing login flow still works. At the same time, the plugin auth flow will also return a "normal" UI session to the redirect_uri, so the user won't have to log in again if they visit the normal UI later.
Added /auth/pluginSecret route to retrieve a session by its associated clientCode. If one is found, it responds with the sessionId so the plugin can store it. Also, the clientCode is removed from the session document in the database so it can't be used again (at this point, the server forgets about the clientCode).
Because this flow uses a different redirect_uri, I had to adapt the array of accepted redirect targets in our trackmania.com app - check out the prod app to see what I changed. If you want to test this locally with your own app, you'll have to add the same extra redirect targets.

UI

Added /auth_redirect_plugin route to serve as redirect_uri for the plugin auth flow. I just copied over the structure from the existing redirect target, and we should probably consolidate the two down the line (keeping both routes if possible).
It sends both auth code and the state (i.e. the clientCode) to the server's /authorize route but doesn't do anything with the response yet. As mentioned before, the server also creates a normal UI session so that could be received and processed here.
Added some logic to include clientCode handling where necessary in the UI's auth logic.

Plugin

'sessionId' has been added to the /auth call at startup, is plugin isn't authenticated, the server responds an auth url & clientCode which is stored for later use
If plugin isn't authenticated, clicking the "Authenticate Plugin" menu button  will open a browser with url mentioned above, start a coroutine that will check periodically until the user has authenticated his ubisoft account on web ui (for 60 seconds max)

@Bux42 Can you update the PR description with what you did?
I guess this is close to being done, so I'd like to merge this soon so we can get it tested by a few people. Once that's done, we can enforce auth for replay submissions.

Had a look at the plugin locally - the happy path seems to work fine, but I ran into a couple issues that we should address:

The plugin is sending 60 requests when trying to log in - this is spamming the server, and we don't need this many requests. I suggest we change it so the plugin sends 10 requests in the first ten seconds, and then only sends a request every five or ten seconds after that. Also, I think we should show the user a permanent error message (because it's easy to miss the notification in the top right, especially when you're tabbed out for a second).
There's no good way to "log out" - if the plugin is authenticated, we should maybe add a button in the settings to remove the session (both locally and in our db). Otherwise the only way to do it is to manually remove the sessionId in the settings.
If you're authenticated, and you remove the sessionId in the settings, the plugin still thinks it's authenticated. I'm not sure what we can do there, and if we can maybe hook into the settings saving - but this behavior isn't great atm.
When I try to authenticate, but I'm already logged in on api.trackmania.com in my browser, then I have no chance to change my account during the auth flow. Instead, it redirects me just fine (which we can't really prevent) and the UI just shows that it's all good (which we might be able to change - the API already detects that the user is not the same, so it should relay that to the UI). Also, the plugin just searches for a minute, although it should be able to find out what's happening and make the plugin display an error saying "You tried to log in with a different account." - this whole flow isn't the most pressing but I think we should improve it down the line.

4 isn't insanely important right now, but the other three should be fixed before we merge this imo.


firmware_info is not located in flash

the SCT file only defines FIRMWAREVERSION but nothing for firmware_info, I don't even think it exists in the flash at all due to optimization, this problem is making it impossible to check if EEPROM needs to be updated when upgrading from FW version 2 to FW version 3, as it makes it impossible to detect if FW version 3 is the one running.

oh no, this is a problem with the V2 firmware too, anything built by Keil is missing the metadata


Sectioning

@mcdonamp
A separate pull request for Sectioning.
This version is dependent on the NSSortDescriptors and NSPredicate version.
FirebaseArray now has a sectionKeyPath property. This is a key path for use with an FDataSnapshot.
eg:
dataSource.array.sectionKeyPath = @"value.simpleDate";
dataSource.array.sectionsOrderedAscending = YES;
//Sections will be produced based on the simpleDate value

You can access the values the sections are based on by the sectionValues property of the array.
This version uses NSIndexPaths instead of NSUIntegers in the dataSource methods.

Hi, is there likely going to be support for UITableView sections anytime soon? Thanks.

I'd certainly like to see support for sections too.


Load new DMAP columns for G and GBETA.

Describe the Enhancement
The issue dtcenter/met#1673 and corresponding pull request dtcenter/met#1857 add new columns to the distance map (DMAP) line type created by the Grid-Stat tool.
This adds 3 new columns to the end of the existing DMAP line type: G, GBETA, and BETA_VALUE. All 3 columns are floating point numbers. Note that G will always have a value in the output, but GBETA and BETA_VALUE will only have a value when VX_MASK = FULL. When VX_MASK != FULL, GBETA = BETA_VALUE = NA.
Please see corresponding METviewer issue for plotting these stats:
dtcenter/METviewer#323
Please see existing documentation for more details about the configuration options, science, and equations.
Sample data can be found in kiowa:/d1/projects/MET/MET_regression/develop/NB20210818/MET-develop/test_output/met_test_scripts/grid_stat/grid_stat_120000L_20050807_120000V_dmap.txt.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
No sub-issues needed.
Relevant Deadlines
Prior to the coordinated METplus 4.1.0 release.
Funding Source
2702691
Define the Metadata
Assignee

[x] Select engineer(s) or no engineer required: Venita
[x] Select scientist(s) or no scientist required: no scientist required

Labels

[x] Select component(s)
[x] Select priority
[x] Select requestor(s)

Projects and Milestone

[x] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[x] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[x] METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

Here is the sample data (remove.txt)
grid_stat_120000L_20050807_120000V.stat.txt

Updated schema file:
https://github.com/dtcenter/METviewer/blob/issue/324-dmap_stats/sql/mv_mysql.sql

Added new fields g, g_beta, and beta_value to line_data_dmap in constants.py. Requires version of mv_mysql.sql with new columns in line_data_dmap (in METviewer repo). Ran with test data file provided by Tatiana.


[stable/rabbitmq-ha] RollingUpdate -> federation issue & old queue reappears

Describe the bug
Hi,
I'm doing a RollingUpdate of a 3-node rabbitmq cluster using rabbitmq-ha. The pods in the cluster do a rolling update but when they come back up there are a couple of issues:

An old queue which I'd previously deleted via the management ui, which had 0 messages, keeps reappearing. I've checked in the secrets (k get secrets rabbit-mq-rabbitmq-ha -o yaml | grep definitions.json | awk '{print $2}' | base64 -d) but that old queue isn't listed there, so I don't know where it's getting the definition from to recreate it.

I have a federation defined in my values.yaml but it's not starting up correctly. I can see it displayed in the management ui under Federation Upstreams, but it's not listed on the Federation Status. The log for one of the nodes shows an error saying "gen_event handler rabbit_federation_event crashed" with a badmatch badarg error but I'm not sure what the exact problem is (error in section of log below). The federation is defined in definitions-parameters of the values.yaml as:
{
"value": {
"ack-mode": "on-confirm",
"exchange": "the_upstream_exchange",
"max-hops": 1,
"reconnect-delay": 1,
"trust-user-id": false,
"uri": "amqp://the_user:the_password@the_upstream_federation"
},
"vhost": "/",
"component": "federation-upstream",
"name": "documents-federation"
},

Any idea where the queue definition in 1) is coming from, or what the error in 2) is from?
Thanks in advance,
John.
Version of Helm and Kubernetes:
Helm: v2.14.0
Kubernetes: v1.14.9-eks-c0eccc
Which chart:
stable/rabbitmq-ha
Error in rabbit pod log:
2020-02-12 16:33:25.705 [error] <0.455.0> ** gen_event handler rabbit_federation_event crashed.
** Was installed in rabbit_event
** Last event was: {event,parameter_set,[{component,global},{name,cluster_name},{value,<<"the_rabbitmq_cluster">>},{user_who_performed_action,<<"rmq-internal">>}],none,1581525205685}
** When handler state == []
** Reason == {{badmatch,{error,{{badarg,[{binary,part,[<<87,153,18,71,57,194,112,95,223,166,228,250,96,98,252,59,230,15,103,220,77,74,224,167,209,7,8,93,131,31,130,138,78,13,184,36,138,38,29,217,25,145,191,244,36,24,205,136,115,250,124,93,145,243,246,133,142,50,228,42,242,16,211,11,88,68,142,245,33,171,203,195,61,3,108,154,40,83,108,13,11,185,92,199,18,225,169,60,30,64,89,4,84,239,255,129>>,0,-33],[]},{credentials_obfuscation_pbe,unpad,1,[{file,"src/credentials_obfuscation_pbe.erl"},{line,143}]},
{rabbit_federation_util,'-deobfuscate_upstream/1-lc$^0/1-0-',1,[{file,"src/rabbit_federation_util.erl"},{line,94}]},
{rabbit_federation_util,deobfuscate_upstream,1,[{file,"src/rabbit_federation_util.erl"},{line,94}]},
{rabbit_federation_exchange_link,init,1,[{file,"src/rabbit_federation_exchange_link.erl"},{line,78}]},
{gen_server2,init_it,6,[{file,"src/gen_server2.erl"},{line,565}]},
{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]},
{child,undefined,{upstream,[<<"I1o66nTNB9SG25vGbPHeLGjVEmokyXuLPn+UIFVbbyGeUezy90TdXoCO6aMeGv5Rhb8wM2jARM2sdoYnbZamo7btUelh8Yc8/mr0atrvEHy2mQ2t5M6ZzVIqWGHn6Bqd7jBrLGllJcFplhxMpv8ufS49bt0lgm3uyZUBvIaTpZg=">>],
<<"the_upstream_exchange">>,<<"the_local_exchange">>,<<"federation-link-documents-federation">>,1000,1,1,none,none,false,'on-confirm',none,<<"documents-federation">>,false},{rabbit_federation_exchange_link,start_link,[{{upstream,[<<"I1o66nTNB9SG25vGbPHeLGjVEmokyXuLPn+UIFVbbyGeUezy90TdXoCO6aMeGv5Rhb8wM2jARM2sdoYnbZamo7btUelh8Yc8/mr0atrvEHy2mQ2t5M6ZzVIqWGHn6Bqd7jBrLGllJcFplhxMpv8ufS49bt0lgm3uyZUBvIaTpZg=">>],
<<"the_upstream_exchange">>,<<"the_local_exchange">>,<<"federation-link-documents-federation">>,1000,1,1,none,none,false,'on-confirm',none,<<"documents-federation">>,false},{resource,<<"/">>,exchange,<<"the_local_exchange">>}}]},{permanent,1},30000,worker,[rabbit_federation_exchange_link]}}}},[{rabbit_federation_link_sup,'-adjust/3-lc$^1/1-4-',2,[{file,"src/rabbit_federation_link_sup.erl"},{line,36}]},{rabbit_federation_exchange_link_sup_sup,'-adjust/1-lc$^0/1-0-',2,[{file,"src/rabbit_federation_exchange_link_sup_sup.erl"},{line,56}]},{rabbit_federation_exchange_link_sup_sup,adjust,1,[{file,"src/rabbit_federation_exchange_link_sup_sup.erl"},{line,57}]},{rabbit_federation_parameters,adjust,1,[{file,"src/rabbit_federation_parameters.erl"},{line,81}]},{rabbit_federation_event,handle_event,2,[{file,"src/rabbit_federation_event.erl"},{line,48}]},{gen_event,server_update,4,[{file,"gen_event.erl"},{line,577}]},{gen_event,server_notify,4,[{file,"gen_event.erl"},{line,559}]},{gen_event,server_notify,4,[{file,"gen_event.erl"},{line,561}]}]}

This is a large issue for us as well!

Still haven't gotten to the bottom of this.


Allow Asm.js type coercions on simd builtin ret values

Allow simd builtin function return values to be coereced
to asm.js types as allowed by the spec.
http://asmjs.org/spec/latest/#unary-operators
Adding positive and negative tests.
Fixes #933

@abchatra @MikeHolman Please review.

@MikeHolman Can you please review this?

lgtm


Unicode LaTeX tab completion

The Julia vim plugin has tab completion from LaTeX to Unicode, why doesn't the Lean vim plugin have this as well? I recommend taking a look at theirs to see how you can do it let https://github.com/JuliaEditorSupport/julia-vim

Can you elaborate on what you mean? This plugin does have support for entering unicode abbreviations already. What functionality are you missing?

The README has not made it clear to me how to activate these abbreviations. In the Julia vim plugin, I can simply type \times and then press the TAB key to have it replaced with unicode. This is the most natural way in my opinion, I don't know how to do it with this plugin based on the half sentence of information in the readme.

It works exactly the same way. Feel free to come ask on the Lean Zulip if you're having setup issues.

It does not, though Lean (the language) certainly assumes you are using it through an LSP.

Why not just explain how to use it here?

Please be less presumptuous? Have you tried using this plugin already or simply assuming? I have other things to do than walk you through it, though if you were a bit less rude it certainly wouldn't hurt.

It does not, though Lean (the language) certainly assumes you are using it through an LSP.

It seems that it's possible to use lean by using lean --run in terminal, so an LSP in the editor is not required to be assumed.

Have you tried using this plugin already or simply assuming?

Yes, I have tried using this plugin and I don't understand how I can insert unicode from this instruction:

Abbreviation (unicode character) insertion (in insert mode & the command window accessible via q/)

So when I am in insert mode and have the phrase \times, how can that be transformed to Unicode?

Please be less presumptuous?

My only presumption is that I am not able to accomplish the unicode insertion

I have other things to do than walk you through it, though if you were a bit less rude it certainly wouldn't hurt.

I'm not sure what you think is rude here, I'm trying out lean.nvim and am not successful at the unicode insertion.

It seems that it's possible to use lean by using lean --run in terminal, so an LSP in the editor is not required to be assumed.

Every user of the language uses it through an editor with an LSP, the vast majority of whom (95% plus) doing so via VSCode. No one uses Lean through lean --run.

So when I am in insert mode and have the phrase \times, how can that be transformed to Unicode?

Hit tab or space, after having enabled the plugin.

Then I don't quite understand how to enable this plugin. I am using vim pathogen, and have cloned the repository into ~/.vim/bundle/lean.vim.
Syntax highlighting for lean seems to be enabled, so I am not sure what I'm missing to enable here.

Are you using vim? This is a neovim plugin.

Yes, I am using vim, I was hoping this would be backwards compatible. The Julia Vim plugin is an example where they have unicode tab completion, so I was hoping it would inspire someone to do something similar for lean with vim.


Window tries to maximize and then minimize on each incoming notification

When a new message is received - the window maximizes and then immediately minimizes with each incoming notification.
this was not the case in the 1.5.3 Release - the notification was received without any window maximize - minimize circus.

This is solved on the next release, you can try it by using the v1.5.5 rolling-beta

Keeping issue open until release

I was just coming here to report the same issue. Glad it's being addressed. Thank you!


Disable spider legs?

How can I disable the spider leg polylines?  Should I just set the opacity or thickness to zero using spiderLegPolylineOptions? or is there a better way?

I don't think there is a way other than your suggestion. Take a look in the code maybe.


[bug]: Delete hotkey doesn't delete gallery images while editing workflows

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
RTX 3080Ti
GPU VRAM
12GB
Version number
4.2.2post1
Browser
Google Chrome 124.0.6367.208
Python dependencies
No response
What happened
When editing workflows, the Delete hotkey will not delete gallery images. If a noodle or node is selected, that will be deleted instead. If nothing is selected, nothing happens.
You must switch to a different mode, e.g. Generation or Canvas, for the delete key to delete a gallery image, or switch the Workflow view to Use In Linear View to delete gallery images.
What you expected to happen
If I'm editing a workflow and I move my cursor over the gallery, I expect the Delete hotkey to delete the currently selected gallery image.
How to reproduce the problem

In Workflows tab, edit a workflow. Select a gallery image and press Delete. The image won't be deleted.
In Workflows tab, edit a workflow. Select a noodle or node, move your cursor over the Gallery, and press Delete. The node or noodle will be deleted, but the image will be unaffected.

Additional context
No response
Discord username
_cirius_

I have an idea of what's happened, classic fix one bug and cause another 😅 I fixed an issue with the node editors delete hotkey but I think I made it too powerful.


Object literal not recognized as namespace

TypeScript Version:  3.1.0xxxxx

Search Terms:
namespace empty object literal
Code
var ns = {};     // recognized as a declaration for a namespace `ns`
ns.constant = 1; // recognized as a declaration for var `constant`
// ^^^^^^^^ <- Property 'constant' does not exist on type '{}'.

Expected behavior:

TypeScript 2.8 adds support for understanding more namespace patterns in .js files. Empty object literals declarations on top level, just like functions and classes, are now recognized as as namespace declarations in JavaScript.

Release notes (source)
Actual behavior:
Compile error.
Playground Link:
Playground
Related Issues:
I'm migrating a codebase and tried a few minor variations unsuccessfully.

patterns in .js files

Ugh just realized I converted my file to .ts. Is this specific to working with the pragma?

Yes, this is specific to JavaScript. In TypeScript you should declare the intended type of your variables beforehand. One exception will come for function types:
https://github.com/Microsoft/TypeScript/pull/26368


Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

I have ruby 2.3.1 in Ubantu 14.04 LTS system, when I excute sudo -u git -H bundle install --deployment --without development test mysql, I got those errors.
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unf_ext-<IP_ADDRESS>/ext/unf_ext
/usr/local/bin/ruby -r ./siteconf20160901-32338-giivbf.rb extconf.rb
checking for main() in -lstdc++... yes
creating Makefile

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /home/git/gitlab/vendor/bundle/ruby/2.3.0/extensions/x86_64-linux/2.3.0-static/unf_ext-<IP_ADDRESS>/mkmf.log

current directory: /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unf_ext-<IP_ADDRESS>/ext/unf_ext
make "DESTDIR=" clean

current directory: /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unf_ext-<IP_ADDRESS>/ext/unf_ext
make "DESTDIR="
compiling unf.cc
cc1plus: warning: command line option ‘-Wdeclaration-after-statement’ is valid for C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option ‘-Wimplicit-function-declaration’ is valid for C/ObjC but not for C++ [enabled by default]
virtual memory exhausted: Cannot allocate memory
make: *** [unf.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unf_ext-<IP_ADDRESS> for inspection.
Results logged to /home/git/gitlab/vendor/bundle/ruby/2.3.0/extensions/x86_64-linux/2.3.0-static/unf_ext-<IP_ADDRESS>/gem_make.out

I've never seen a error like this.  Can you check and compare the memory usage before and while running it?  If the system only has very limited RAM available, adding a swap might help.

I don't this compiling this extension would require such a large amount of memory, so I guess some other process is hogging RAM, the compiler has a bug, or something.

Please reopen this when you get more information to share.


Add Nebra hotspots

I believe I've done this right as per the Manufacturer's docs.
This PR should add the icons and screens for the Nebra Hotspots.
Resolves #153
Screenshots:

Hey Ryan, thanks for submitting this PR. It is looking great, I left you some comments for improvements. Let me know if you want to jump on a discord call to discuss.

Hi Tyler, No problem.
I expected it to not be quite right as I'm not a Typescript / React developer and was just going roughly based on the docs.
All the comments make sense, but can discuss further via Discord if you like. I'm @ryanteck#0042.


Fix FlutterEngineOnVsync being called after engine shutdown

Potentially fixes https://github.com/flutter-tizen/flutter-tizen/issues/232.
This change is just a partial revert of https://github.com/flutter-tizen/engine/pull/317. In the PR, I changed tdm_client_ from a plain pointer to a shared_ptr which is shared between the platform thread and the vblank thread, but it turned out that it results in a synchronization issue in https://github.com/flutter-tizen/flutter-tizen/issues/232 for some unknown reason. The main reason I changed it into a shared_ptr was that it seemed not safe to call OnEngineStop on a plain pointer because the object pointed by the pointer was being destroyed on thread exit. However, in reality, OnEngineStop is guaranteed to be called before a kMessageQuit message is sent and thus no segmentation fault should occur.
I also considered removing the vblank thread itself but thought it would not be very efficient since tdm_client_handle_events is a blocking call and blocks the UI thread.

I changed tdm_client_ back to a share_ptr and just replaced reset() with OnEngineStop() according to @bbrto21's suggestion. The problem was that the instance was not destroyed when reset() was called and thus engine_ = nullptr; was not called as I expected. Thank you!


How to Inject to additive Loaded Content or Scene switch ?

Question
How do I Inject Bindings into a scene that is loaded additive ?
Current scenario
I have the my main StateMachine for the Game ( that handles all state and Scene switches )
Its created by my installer in the application Warmup like this :
Container.Bind<GameStateMachine>().ToSingleFromPrefab<GameStateMachine>(_gameStateMachinePrefab);

To keep loading times short my warm-up scene is nearly empty ( Installer + Loading Grafics )
From this point I load the needed scene async and additive ( while I can show loading animations etc. )
How do I Inject my main stateMachine ( or any other binding ) to this additive loaded scenes ?
I tried:
[PostInject]
public void Init(GameStateMachine gameStateMachine){
    this.gameStateMachine = gameStateMachine;
}

but it doesn't get called at all.
So what is the recommended approach for this ? Thanks for your help.
Friedrich Wessel

Are you using ZenUtil.LoadSceneAdditive or Application.LoadLevelAdditive directly?
If you use ZenUtil.LoadSceneAdditive you can also pass additional bindings if you have configuration you want to pass to the next scene as well

There is also LoadSceneAdditiveWithContainer for cases where the new scene does not have its own CompositionRoot.
This might also be a case where nested containers might be useful, not sure.

I guess the question is, does the new scene have its own CompositionRoot?  If so, nested containers might be the way to go.

Hello,
wow - thats a quick answer :)

I use Application.LoadLevelAdditive -> I guess the answer to my question is use: ZenUtli.LoadLevelAdditive.

No the new scene dont have its own Composition Root ( and its not planned to do this if there is another way )

Im not at my workstation now - I will close the ticket after I testet your suggestions.
Thanks for the quick answer!

Ok.  I think you want to use Zen.LoadSceneAdditiveWithContainer then, and pass in the container for your root scene

For folks from the future finding this conversation: LoadSceneAdditive/WithContainer have become ZenjectSceneLoader.LoadScene() and that function with containerMode set to LoadSceneRelationship.Child.
There's also a LoadSceneAsync available, to match Unity's change from Application.LoadScene to SceneManager.LoadScene(). In fact, these functions are wrappers around SceneManager calls, so SceneManager.SceneLoaded() will still be called and all other functionality is compatible. You don't need to replace SceneManager entirely, just Load calls.


Example code is a dead link

Located at:
https://firebaseopensource.com/projects/flutter/plugins/packages/firebase_auth/readme/

@sandwichstealer
firebase is a 3rd party plugin, please open an issue in the dedicated github

Hi @sandwichstealer
From what I can see, the issue is related to a FlutterFire plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments,
providing your flutter doctor -v, your flutter run -v,  your pubspec.yaml
a minimal reproducible code sample that does not use 3rd party plugins,
and I will reopen it.
Thank you


Implement game speed

Extend IEntity update method with new paramerter -> Game Speed Koeficient (default value - '1')
Provide new HUD GUI element -> Game Speed controller with 4 speeds (pause, slow, normal, fast)

No need to extend IENtitty


Handle deriving from case classes where

Happy to reopen this with more info!

My apologies, the issue seems to have been truncated somehow. I no longer remember what the original issue was, unfortunately.


Add new updated SQL Server sample region tags.

After I've imported the code into docs using cloud_sql_sqlserver_pdo_connection, I'll create another PR to remove the old cloud_sql_server_pdo_connection


Remove reliance on external image services

The project currently relies on posts to imgur to host the images in the PR comments posted to github.  This restricts the usefulness of this project for private repositories and introduces a dependency that I believe is unnecessary.
As a replacement I would propose:

Write the images to a companion github repo for the original project (e.g. ember-frost-core would have a companion ember-frost-core-visual-acceptance repo)
Images are written to a visual-acceptance branch
A report is published to the gh-pages branch of the companion repo that tracks the changes to the visuals, reading from the visual-acceptance branch (this allows usage of full webpage capabilities in creating a report and removes the current PR markdown comments restriction)
A link to the report and a summary of the changes (added, changed) is posted to the target PR
Accepting the PR moves additions and changes into the baseline for the project

This gives us an image storage location that could potentially be private and a report that isn't restricted to PR markdown.
Open questions/thoughts:

Authorization to create/write the companion repo: can we default to using the ember-cli-visual-acceptance user?
Publishing and updating the gh-pages report site: how would the original site be published, how would the report site be upgraded if a newer version is available?
Can the PR report be grouped with the rest of the report checks in the PR?
For private repos, the companion repo should also be private - so the write privileges for the companion repo would need to be configurable - can the PR post still come from ember-cli-visual-acceptance in this case?
How do we provide the write permissions for ember-cli-visual-acceptance to travis?

I don't know enough about the specifics of github tokens with travis to answer most of the open questions yet.

Write the images to a companion github repo for the original project (e.g. ember-frost-core would have a companion ember-frost-core-visual-acceptance repo)

Yes but obviously the repo would be under ember-cli-visual-acceptance and any one could use the token to do modify its repo's

The rest of the proposals would require us hosting a separate server to handle these requests. And users giving write permissions to ember-cli-visual-acceptance.

The rest of the proposals would require us hosting a separate server to handle these requests.
Why?

Yes but obviously the repo would be under ember-cli-visual-acceptance and any one could use the token to do modify its repo's
Can you clarify this?  Are you saying the companion repos would be owned by ember-cli-visual-acceptance?  The intention would be to support writing to private repos with an appropriately configured token, even if that means it's not a token from the ember-cli-visual-acceptance user.

Why?

All the images would have to be written during a PR build to create our comment. Seeing as secure env variables can't be used, we would would have to have an additional server we called to utilize secure Oauth tokens that had permissions to read/write to a user's repo (they would grant a user access)

Clarify

Yes the repos would be owned by  ember-cli-visual-acceptance. I doubt anyone would wish to supply a token (Must be an unsecure env varable on travis) that grants access to read/write on both their public and private repos

I doubt even more that people want to grant access to private repos to ember-cli-visual-acceptance, so it looks like we need to figure out another solution to writing the images.

Ugh, why can't github just expose an API for uploading files to PR comments?...

Ok, so let's say the target for this is open source - at least for the first pass, so we go back to the idea that the companion repo is owned by ember-cli-visual-acceptance, this still would mean that we need to expose a write token for ember-cli-visual-acceptance in the unsecured travis env variables.
Other alternatives are:

External hosting of the images (imgur - current solution - no path forward for private repos)
Adding images as PR files (ideal for github - local generation runs into the issue of image reproducibility - can be solved a la webdriver-io server, but this is not a general market open source solution)
Starting a service for hosting the reports (costly - not something we want responsibility for)

An image hosting service with an option for private accounts (dropbox?)

If you have a private github repo using private travis back to a private companion repo, would you care if a r/w token for a user that only had access to the companion repo was posted in private travis unsecured env vars?

I'm becoming more comfortable with the idea that ember-cli-visual-acceptance (or a similarly provided account) is a sacrificial lamb that only has access to reporting (companion) repos and is therefore acceptable to expose the credentials on.
We could still ensure that the baseline images were written back to the source repo, so that someone malicious wiping out the report repos wouldn't have an impact on anything other than active reports (just re-run the travis build?)

So the purpose of the reporting repo would be to host a site for the active PR(s) and the current baseline, but the source copy of the baseline would always be kept in the source repo.

delete PR image assets from the report repo after merge, only keep the baseline (a new baseline and comparison images would be produced for all outstanding/future PRs by the Travis process)

I need thoughts about pro/cons over the current strategy.  So far I have:
Pros:

Better reports
One less service in the process
Potential to work for private repos/travis

Cons:

Expose a write token for ember-cli-visual-acceptance

Closing - not enough value at this stage


WIP

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #8601 (a50eac2) into main (558b921) will decrease coverage by 0%.
The diff coverage is 86%.

@@          Coverage Diff          @@
##            main   #8601   +/-   ##
=====================================
- Coverage     71%     71%   -1%
=====================================
  Files        381     381
  Lines      24471   24478    +7
  Branches    3758    3758
=====================================
- Hits       17495   17475   -20
- Misses      5463    5486   +23
- Partials    1513    1517    +4

Impacted Files
Coverage Δ

...atascience/interactive-window/interactiveWindow.ts
65% <75%> (-1%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
58% <88%> (-1%)
:arrow_down:

...ce/interactive-window/interactiveWindowProvider.ts
75% <100%> (+<1%)
:arrow_up:

...ience/variablesView/variableViewMessageListener.ts
77% <0%> (-23%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
67% <0%> (-11%)
:arrow_down:

.../client/datascience/debugLocationTrackerFactory.ts
92% <0%> (-4%)
:arrow_down:

...lient/datascience/jupyter/kernels/cellExecution.ts
73% <0%> (-4%)
:arrow_down:

src/client/datascience/webviews/webviewHost.ts
80% <0%> (-2%)
:arrow_down:

...t/datascience/notebook/vscodeNotebookController.ts
78% <0%> (-1%)
:arrow_down:

... and 1 more


jest --json throws error when there is a failing test

The json is not being generated when there is a failing test. The json is being output just fine when all tests are passing.
jest --json
Using Jest CLI v0.9.2, jasmine2

Unexpected Error: Path must be a string. Received undefined

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:8:11)
    at Object.win32.relative (path.js:256:3)
    at C:\Mappings\Prominence\node_modules\jest-cli\src\lib\utils.js:365:20
    at Array.map (native)
    at C:\Mappings\Prominence\node_modules\jest-cli\src\lib\utils.js:348:12
    at Array.map (native)
    at C:\Mappings\Prominence\node_modules\jest-cli\src\lib\utils.js:346:54
    at Array.map (native)
    at Object.formatFailureMessage (C:\Mappings\Prominence\node_modules\jest-cli\src\lib\utils.js:345:6)
    at formatResult (C:\Mappings\Prominence\node_modules\jest-cli\src\lib\formatTestResults.js:34:30)

\node_modules\jest-cli\src\lib\formatTestResults.js:35:9
rootPath should be changed to rootDir
    ...
    if (!allTestsPassed) {
      output.message = utils.formatFailureMessage(testResult, {
        rootDir: '',
        useColor: false,
      });
    }
  }

utils.js is expecting config.rootDir (commit)
formatTestResults.js is passing in config.rootPath (commit)

Thanks! Fixed this in https://github.com/facebook/jest/commit/7e575672689dca354a34ce34b0bfa702308301a7


rest framework actions do not provide sane schema

Extra object actions should use either
@action(detail=True, schema=None) to declare they are ID based rather than list based, which changes the schema accordingly, but will only partially fix the schema.
or
@action(detail=True, schema=...) allows accurately describing the parameters, which seems highly desirable/expected behaviour for this library.

It looks like as_interface is using @action.  I'm not sure why I am seeing a list type schema for the actions (I'll dig into that), but adding the schema= arg will make the OpenAPI much more accurate.

also the url is
object/<pk>/action-name/
when it would be better to be
object/<int:pk>/action-name/


hydrogen-may project sehl-utopia branch: font is missing in utopia

Original:

Utopia:

Fixed by https://github.com/concrete-utopia/utopia/pull/5760 it would appear.


fix: github action for conformance

This PR adds the OCI_CROSSMOUNT_NAMESPACE environment variable in the
github action config file. This enables us passing all the test cases.
Signed-off-by: jay-dee7<EMAIL_ADDRESS>

@guacamole lets merge this one after #31

Looks awesome, everything passes!!! 🥇


Error

Hi, I get an error in logs:
This error originated from a custom integration.

Logger: homeassistant.helpers.entity
Source: custom_components/smartthings_soundbar/api.py:35
Integration: smartthings_soundbar (documentation, issues)
First occurred: 19:21:56 (43 occurrences)
Last logged: 19:28:56

Update for media_player.stue_soundbar fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 515, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 710, in async_device_update
    raise exc
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/smartthings_soundbar/media_player.py", line 76, in update
    SoundbarApi.device_update(self)
  File "/config/custom_components/smartthings_soundbar/api.py", line 35, in device_update
    device_volume = data['main']['volume']['value']
KeyError: 'main'

Config:
- platform: smartthings_soundbar
  name: Stue Soundbar
  api_key: "ladida etc"
  device_id: "xx:xx: etc"

I had similar issue. my problem was the Device ID was not correct. Check the DEvice ID (only use the xxx part, without the part before/) and check the Token


Issue in the hamburger icon

Description
The hamburger icon doesn't work
Steps to Reproduce
https://github.com/user-attachments/assets/f70ad2b2-9e29-44eb-9415-574c38593da2
Expected Behavior
The hamburger must work as it is made for mobile screens
Actual Behavior
No response
Screenshots
No response
Additional Information
No response
What browser are you seeing the problem on?

[X] Firefox
[X] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

this issue was assigned before, you can check in issues he is resolving,
So i am closing this issue.
Please understand.


Handle banned users

Handle 403 in case of inventory request:
Error during GET request or invalid JSON content: 403 Client Error: Forbidden for url: https://steamcommunity.com/inventory/76561199072654974/440/2?l=english&count=3000
Traceback (most recent call last):
File "/home/.local/lib/python3.10/site-packages/steampy-1.1.2-py3.10.egg/steampy/utils.py", line 190, in func_wrapper
return func(self, *args, **kwargs)
File "/home/.local/lib/python3.10/site-packages/steampy-1.1.2-py3.10.egg/steampy/client.py", line 175, in get_partner_inventory
raise ApiException('Success value should be 1.')
steampy.exceptions.ApiException: Success value should be 1.

fixed in proxy branch


evertyhign probe,m

everythig broken ??WTf

proof

https://cdn.discordapp.com/attachments/902309433747587112/904450308325920788/unknown.png


pakcs: 3.6.0 -> 3.7.2, build on ghc9

version bump and switch to ghc9
cc #346214
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I’d prefer not vendoring the patch but fetching it with fetchpatch from a PR against upstream, but its your decision.

I seriously recommend that we activate the pakcs job in pkgs/top-level/release-haskell.nix (uncomment line 335) so that we notice when one of the haskell-updates breaks pakcs again.


case Backup & restore with view

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Added junit tests

I suggest add travis-ci and run these tests after every commit. This will prevent problems like #101 in future.
I created inner classes because tests other way would not be correctly fail if something going wrong. I use CountDownLatch because creating while/sleep loop is bad practic. I personally prefer use static imports to remove excess code. But for new users may be harder to understand what going on.
We can remove "example" package and redirect users to tests. But this require some modifications to show all available features.

Looks good to me. Not sure if this would really be able to replace the example, as they have different intents behind them.


Driver is unable to handle response from RedShift

Driver version
2.0.903
Redshift version
PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.49676
Client Operating System
AWS Lambda (Amazon Linux)
Python version
3.10
Table schema
Doesn't matter
Problem description
Getting UnicodeDecodeError: 'utf-8' codec can't decode byte 0x9d in position 122: invalid start byte when simply connecting to RedShift. THIS IS VERY RARE OCCURENCE, in our case - 7 times out of 5000 invocations. I'm guessing, that RedShift is too busy and driver is unable to handle such event
Python Driver trace logs
  self.connection = self.engine.connect()
  File "/var/task/sqlalchemy/engine/base.py", line 3204, in connect
    return self._connection_cls(self, close_with_result=close_with_result)
  File "/var/task/sqlalchemy/engine/base.py", line 96, in __init__
    else engine.raw_connection()
  File "/var/task/sqlalchemy/engine/base.py", line 3283, in raw_connection
    return self._wrap_pool_connect(self.pool.connect, _connection)
  File "/var/task/sqlalchemy/engine/base.py", line 3250, in _wrap_pool_connect
    return fn()
  File "/var/task/sqlalchemy/pool/base.py", line 310, in connect
    return _ConnectionFairy._checkout(self)
  File "/var/task/sqlalchemy/pool/base.py", line 868, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "/var/task/sqlalchemy/pool/base.py", line 476, in checkout
    rec = pool._do_get()
  File "/var/task/sqlalchemy/pool/impl.py", line 256, in _do_get
    return self._create_connection()
  File "/var/task/sqlalchemy/pool/base.py", line 256, in _create_connection
    return _ConnectionRecord(self)
  File "/var/task/sqlalchemy/pool/base.py", line 371, in __init__
    self.__connect()
  File "/var/task/sqlalchemy/pool/base.py", line 677, in __connect
    pool.dispatch.connect.for_modify(
  File "/var/task/sqlalchemy/event/attr.py", line 329, in _exec_w_sync_on_first_run
    self(*args, **kw)
  File "/var/task/sqlalchemy/event/attr.py", line 343, in __call__
    fn(*args, **kw)
  File "/var/task/sqlalchemy/util/langhelpers.py", line 1691, in go
    return once_fn(*arg, **kw)
  File "/var/task/sqlalchemy/engine/create.py", line 686, in first_connect
    dialect.initialize(c)
  File "/var/task/sqlalchemy/dialects/postgresql/base.py", line 3241, in initialize
    super(PGDialect, self).initialize(connection)
  File "/var/task/sqlalchemy/engine/default.py", line 407, in initialize
    self.server_version_info = self._get_server_version_info(
  File "/var/task/sqlalchemy/dialects/postgresql/base.py", line 3487, in _get_server_version_info
    v = connection.exec_driver_sql("select pg_catalog.version()").scalar()
  File "/var/task/sqlalchemy/engine/base.py", line 1669, in exec_driver_sql
    return self._exec_driver_sql(
  File "/var/task/sqlalchemy/engine/base.py", line 1578, in _exec_driver_sql
    ret = self._execute_context(
  File "/var/task/sqlalchemy/engine/base.py", line 1845, in _execute_context
    self._handle_dbapi_exception(
  File "/var/task/sqlalchemy/engine/base.py", line 2030, in _handle_dbapi_exception
    util.raise_(exc_info[1], with_traceback=exc_info[2])
  File "/var/task/sqlalchemy/util/compat.py", line 207, in raise_
    raise exception
  File "/var/task/sqlalchemy/engine/base.py", line 1802, in _execute_context
    self.dialect.do_execute(
  File "/var/task/sqlalchemy/engine/default.py", line 732, in do_execute
    cursor.execute(statement, parameters)
  File "/var/task/redshift_connector/cursor.py", line 211, in execute
    self._c.execute(self, operation, args)
  File "/var/task/redshift_connector/core.py", line 1279, in execute
    self.handle_messages(cursor)
  File "/var/task/redshift_connector/core.py", line 1359, in handle_messages
    self.message_types[code](self._read(data_len - 4), cursor)
  File "/var/task/redshift_connector/core.py", line 1350, in handle_DATA_ROW
    row.append(desc[0](data, data_idx, vlen))
  File "/var/task/redshift_connector/utils/type_utils.py", line 131, in text_recv
    return str(data[offset : offset + length], _client_encoding)

Hey @zaibacu, just to confirm this is occurring when using Redshift provisioned i.e. not Redshift serverless?

I'm guessing, that RedShift is too busy and driver is unable to handle such event
this is my guess here as well. without access to server side (Redshift) logs we have limited insight here.

I'd recommend some combination of the following

reaching out to AWS support so internal analysis of server logs can be performed to determine the root cause of the failure to connect. Please provide them with this GitHub issue as a reference.
use of sqlalchemy's connection pooling/some sort of re-try logic to recreate establishing the connection in these rare cases

Hello, yes this is provisioned RedShift instance

Hi @zaibacu,
We face the same issue on a provisioned RedShift instance but with much higher frequency of occurrence.
Did you have any success yet on mitigating the issue?

Thanks for getting back this quickly. We'll investigate if something along the lines of https://stackoverflow.com/a/53300049 would help to reduce the pain until the issue is resolved from AWS side.
30.05.2023 14:03:25 Šarūnas Navickas @.***>:

Hi @zaibacu[https://github.com/zaibacu],
We face the same issue on a provisioned RedShift instance but with much higher frequency of occurrence.
Did you have any success yet on mitigating the issue?
Hello, we're still battling this issue and frequency is getting higher. As much as we could track, all issues began on automatic version bump by Amazon. This driver clearly doesn't work with latest Redshift version
—
Reply to this email directly, view it on GitHub[https://github.com/aws/amazon-redshift-python-driver/issues/157#issuecomment-1568313763], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABCSWEY5FJOUFTSEQ4VOMWTXIXOYZANCNFSM6AAAAAAXV26NRE].
You are receiving this because you are subscribed to this thread.[Verfolgungsbild][https://github.com/notifications/beacon/ABCSWE3F3U5RXRFUFDTOIHTXIXOYZA5CNFSM6AAAAAAXV26NRGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS5PKI2G.gif]

Yes, we have retry mechanism as well. Usually query works in 1-2 retry attempts

We have also began to experience this non-utf-8 response from redshift during connection initialization somewhat frequently.  Has anyone gotten a response from Amazon regarding the cause?  Can this be handled better by the driver?

We have also began to experience this non-utf-8 response from redshift during connection initialization somewhat frequently. Has anyone gotten a response from Amazon regarding the cause? Can this be handled better by the driver?

It seems to be this concrete driver issue and started after RedShift version bump (not every one gets update at the same time, that's why others encounter bug later).
We are connecting to the same database in other project via JDBC driver. No problems are occuring there

We have also began to experience this non-utf-8 response from redshift during connection initialization somewhat frequently. Has anyone gotten a response from Amazon regarding the cause? Can this be handled better by the driver?

It seems to be this concrete driver issue and started after RedShift version bump (not every one gets update at the same time, that's why others encounter bug later).

We are connecting to the same database in other project via JDBC driver. No problems are occuring there

We are experiencing this issue as well. We have multiple data pipeline jobs that had not failed for months that all of a sudden started failing intermittently directly after a weekly maintenance patch was applied.
Is there any update on this ticket? If not, is there any known workaround we can explore?

No update, easiest workaround - create retry logic. It usually works from 2nd-3rd try. Poor man's solution, but have nothing better at the moment

Hi folks, apologies for the delay in updates. This issue is being investigated internally and updates will be provided as available. Until resolution is found, retry logic is our best suggestion, as folks mentioned above.

We also noticed this issue in the github.com/astronomer/astro-sdk project, we'll be trying to retry as well and wait for a more definite solution (https://github.com/astronomer/astro-sdk/issues/1976)

Any news on this? The frequency of occurrence gets higher and higher and the implementation of retries is partly unfeasible in our codebase.
Did anybody succeed in using a connection pool for fixing this (which was the advice by AWS support folks).

Hi folks, no major updates aside from a general recommendation to ensure your Redshift instance is running the latest cluster version. Please check this page to see the latest cluster versions.

Hi folks, I have more of an update to provide. tl;dr: Redshift server team is investigating this issue. Sqlalchemy appears to trigger some potential server issue.
I was able to reproduce this issue using the following cluster:
Redshift 1.0.52931
DC2 Large Single Node
sqlalchemy does not need to be involved to reproduce the issue, though there is a clear pattern of sqlalchemy users encountering this behavior as sqlalchemy's postgres dialect (which sqlalchemy-redshift is built upon) issues a select version() query upon initialization, which results in this issue being surfaced.
this issue can be reproduced with redshift-connector alone as I believe there is some additional data being sent to redshift_connector which causes this issue.
Below is a script that reproduces the issue.
import redshift_connector

with redshift_connector.connect(
    user='awsuser',
    host='xxx',
    password='xxx',
    database='dev',
    client_protocol_version=1,
    ssl=False,
    port =5439,
) as conn:
    with conn.cursor() as cursor:
        query="select version();"
        for _ in range(10):
            cursor.execute(query)
            print(query, cursor.fetchone())

After a non-deterministic number of query executions, (typically between 1 and 3), the code fails with exception. The exception is raised by redshift_connector due to an error in processing the DATA ROW returned by the query select version().
When inspecting data over wire using wireshark I performed an analysis using postgres wire protocol docs for reference https://www.postgresql.org/docs/8.0/protocol-message-formats.html.
-- Python Driver "select version() Data Row"--
0000   02 00 00 00 45 00 00 c6 0d 4a 40 00 ec 06 4a a5<EMAIL_ADDRESS>0010   03 89 2d 7e 0a 8e fa ad 15 3f c7 47 c1 72 05 d7   ..-~.....?.G.r..
0020   f6 a8 f8 0c 80 18 00 6e 8b ed 00 00 01 01 08 0a   .......n........
0030   0b 9d f8 b7 fa b7 cc d1 44 00 00 00 85 00 01 00   ........D.......
0040   00 00 7b 50 6f 73 74 67 72 65 53 51 4c 20 38 2e   ..{PostgreSQL 8.
0050   30 2e 32 20 6f 6e 20 69 36 38 36 2d 70 63 2d 6c   0.2 on i686-pc-l
0060   69 6e 75 78 2d 67 6e 75 2c 20 63 6f 6d 70 69 6c   inux-gnu, compil
0070   65 64 20 62 79 20 47 43 43 20 67 63 63 20 28 47   ed by GCC gcc (G
0080   43 43 29 20 33 2e 34 2e 32 20 32 30 30 34 31 30   CC) 3.4.2 200410
0090   31 37 20 28 52 65 64 20 48 61 74 20 33 2e 34 2e   17 (Red Hat 3.4.
00a0   32 2d 36 2e 66 63 33 29 2c 20 52 65 64 73 68 69   2-6.fc3), Redshi
00b0   66 74 20 31 2e 30 2e 35 32 39 33 31 00 74 43 00   ft 1.0.52931.tC.
00c0   00 00 0b 53 45 4c 45 43 54 00                     ...SELECT.

44 => D (Data Row 'D' character)
00 00 00 85 => 133 (length of data row including length itself)
00 01 => 1 (there is one column)
00 00 00 7b => 123 (length of the column value in bytes SHOULD BE 121 as last 2 bytes are garbage)
50 6f 73 74 67 72 65 53 51 4c 20 38 2e
30 2e 32 20 6f 6e 20 69 36 38 36 2d 70 63 2d 6c
69 6e 75 78 2d 67 6e 75 2c 20 63 6f 6d 70 69 6c
65 64 20 62 79 20 47 43 43 20 67 63 63 20 28 47
43 43 29 20 33 2e 34 2e 32 20 32 30 30 34 31 30
31 37 20 28 52 65 64 20 48 61 74 20 33 2e 34 2e
32 2d 36 2e 66 63 33 29 2c 20 52 65 64 73 68 69
66 74 20 31 2e 30 2e 35 32 39 33 31 00 74 => PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.52931�t (INCORRECT the last 2 bytes should be excluded)

this issue does not lead to deterministic exceptions in redshift_connector as sometimes these 2 spare bytes are utf-8 compatible e.g. 00 00, resulting in incorrect data but no failure.
I will continue tracking this issue and providing updates here available. Unfortunately, at this time I cannot provide any "nice" workaround to this issue aside from retry logic as has already been discussed.

Hi folks, a fix for this issue is anticipated in Redshift server P178

Hi, We managed to resolve this issue by upgrading our version of Amazon Redshit to 1.0.54899.

Great to hear, thanks for the update, Jorge. Folks, if you're hitting this please upgrade your cluster to see resolution.

Redshift server P178 has been released. Please upgrade to the latest version of Redshift server to see resolution for this issue.


Climate error After Upgrading HASSIO

Home Assistant version
0.115.1
SmartIR version
1.13.1
SmartIR configuration

climate:
  - platform: smartir
    name: Panasonic Heatpump
    unique_id: lounge_heatpump
    device_code: 1021
    controller_data: <IP_ADDRESS>
    temperature_sensor: sensor.temperature_158d000245f4c8
    humidity_sensor: sensor.humidity_158d000245f4c8

Describe the bug
Below Error On Climate control via Broadlink RM Mini after upgrading HASSIO to 115.1
Debug log
Unable to find service remote/send_command
Traceback (most recent call last):
File "/config/custom_components/smartir/climate.py", line 337, in send_command
await self._controller.send(
File "/config/custom_components/smartir/controller.py", line 101, in send
await self.hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1265, in async_call
raise ServiceNotFound(domain, service) from None
homeassistant.exceptions.ServiceNotFound: Unable to find service remote/send_command

#480


Split off admission-webhook operator

Code now lives here: https://github.com/canonical/admission-webhook-operator

Shouldn't this also remove charms/admission-webhook/*?


Fixed broken link to style guidelines

Old link was a 404, I think this new one is the most up to date,

Thank you!


Added two awesome CSS effect

Description
I successfully added two amazing CSS effect.
Complete the issue #295.

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Explain the Testing instructions

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

SCREEN-SHOTS

@Sandhya312 tick mark the boxes in the PR description.

@Sandhya312 tick mark the boxes in the PR description.

Done.


Add GitHub Actions, move roles to refactored Bicep Files

Purpose
This PR adds GitHub Actions to the demo repository and fixes a small role assignment issue.
When running the azd deploy multiple times (or GitHub Actions), the user roles addition would crash because the role assignments were named with "subscription+resource group+principal+role" name (see infra\role.bicep line 14). Changed to use "subscription+principal+role" name so this could be deployed multiple times if needed.
As part of this fix, the role definition GUIDs were moved to a JSON file for better readability.
Does this introduce a breaking change?
[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]

Test the code

Set up repository secrets and variables (see .github/workflows/readme.md for details)

What to Check
Verify that the following are valid

Run the deploy.infra.and.website workflow to test

Other Information
These examples are set up with 'dev'/'qa'/'prod' GitHub environments as an example, but that could be easily changed.
The workflows are set to be manually triggered for now, not triggered on check-in, but that could be easily changed.

Replaced by subsequent PR that includes Azure DevOps Pipelines as well as GitHub Actions


Add pyiron_potentialfit to mpie cluster

@pmrv Can you also add it to requirements.txt ?

Seems the error is not related to this change as it is.
----> 1 grid = pr.continuum.damask.Grid.via_voronoi_tessellation(box_size=1.0e-5, spatial_discretization=grids, num_grains=grains)

TypeError: GridFactory.via_voronoi_tessellation() got an unexpected keyword argument 'spatial_discretization'

I try to fix this issue in https://github.com/pyiron/docker-stacks/pull/271


use babel-plugin-transform-runtime for generator function support

Current Behavior
Right now, when using generator functions, a global import of regenerator-runtime is required, which means that either the library consuming project has to import it itself, or that the library has to import it (which can cause problems due to different versions of the regenerator-runtime being possibly imported.
Desired Behavior
The library should use its own version of the regenerator-runtime without polluting the global namespace.
Suggested Solution
https://babeljs.io/docs/en/babel-plugin-transform-runtime
Using that plugin with regenerator set to true + including regenerator-runtime as dependency should ensure that the regenerator runtime is not using a global namespace and can be imported by the own library without problems.
Who does this impact? Who is this for?
Libraries that make use of generator functions.

Automatic polyfilling of generators with babel-plugin-polyfill-regenerator for targets that need a polyfill has been added #795 and will be released in v0.14.0 soon.


Update python test from 3.6 to 3.11

Python 3.6 is not available on the ubuntu-latest runner anymore. This PR changes the test to use Python 3.11

@bennybp please merge asap


Add Randle Skandle Aid Station

Is your feature request related to a problem? Please describe.
Due to a wild-fire driven partial course closure of the 200M event, a new 50M course has been developed within the original USFS Permit and there will now be an Aid Station at Start/Finish.
Describe the solution you'd like
Add "Randle Skandle" with suggested abbreviation "RS" to the Aid Station selection list.
Describe alternatives you've considered
None.
Additional context
None.

This was completed prior to deploying for the Aug 2024 event.


Only the first dashed attribute is managed when defining my own property type

Hello everyone,
I'm currently using skatejs 5.0.0-alpha.9.
I'm trying to define a new type of attribute, which is almost the same as the props.object but with a slight difference (i.e. it can parse JSON written with simple quotes instead of forcing the usage of double quotes).
My component is as follow:
import { h, Component } from 'skatejs';

type MyProps = {
  foobar: any;
  bazbaz: any;
}

class MyComponent extends Component<MyProps> {
  static get props() {
    return {
      foobar: Object.freeze({
        source: true,
        attribute: true,
        default: Object.freeze({}),
        serialize: JSON.stringify,
        deserialize: (obj: any) => {
          console.log('deserialize 1', obj);
          return JSON.parse(obj);
        }
      }),
      bazbaz: Object.freeze({
        source: true,
        attribute: true,
        default: Object.freeze({}),
        serialize: JSON.stringify,
        deserialize: (obj: any) => {
          console.log('deserialize 2', obj);
          return JSON.parse(obj);
        }
      })
    };
  }

  constructor() {
    super();
  }

  renderCallback({foobar, bazbaz}: MyProps) {
    console.log('foobar', foobar);
    console.log('bazbaz', bazbaz);
    return (

    );
  }
}

customElements.define('my-component', MyComponent);

And its usage is:
<my-component foobar='{"foo": "bar"}' bazbaz='{"baz": "baz"}'>
</my-component>

It works as expected, the JS console is displaying the following information:
deserialize 1 {"foo": "bar"}
deserialize 2 {"baz": "baz"}
foobar Object {foo: "bar"}
bazbaz Object {baz: "baz"}

Now, I want to use dash-separated names for these properties. The component is exactly the same, except for the name of the attributes which are now camelCased.
type MyProps = {
  fooBar: any;
  bazBaz: any;
}

class MyComponent extends Component<MyProps> {
  static get props() {
    return {
      fooBar: Object.freeze({
        source: true,
        attribute: true,
        default: Object.freeze({}),
        serialize: JSON.stringify,
        deserialize: (obj: any) => {
          console.log('deserialize 1', obj);
          return JSON.parse(obj);
        }
      }),
      bazBaz: Object.freeze({
        source: true,
        attribute: true,
        default: Object.freeze({}),
        serialize: JSON.stringify,
        deserialize: (obj: any) => {
          console.log('deserialize 2', obj);
          return JSON.parse(obj);
        }
      })
    };
  }

  constructor() {
    super();
  }

  renderCallback({fooBar, bazBaz}: MyProps) {
    console.log('foo-bar', fooBar);
    console.log('baz-baz', bazBaz);
    return (

    );
  }
}

customElements.define('my-component', MyComponent);

And its usage is:
<my-component foo-bar='{"foo": "bar"}' baz-baz='{"baz": "baz"}'>
</my-component>

Only the first attribute is managed (in that case foo-bar, but it can be baz-baz if the latter is defined before the other attribute in HTML).
The console log now shows:
deserialize 1 {"foo": "bar"}
foo-bar Object {foo: "bar"}
baz-baz Object {}

I think the issue is mainly on how I define my property, since if I set the properties as direct props.object, it works:
class MyComponent extends Component<MyProps> {
  static get props() {
    return {
      fooBar: props.object,
      bazBaz: props.object
    };
  }
  // ....
}

and in console:
foo-bar Object {foo: "bar"}
baz-baz Object {baz: "baz"}

Is it a bug, or is something wrong in the definition of my property type (sorry, the official documentation still rely on v4, and this part seems to have been changed).
Thanks in advance.

Hey thx 4 report!
first of, you are using wrong api,
there is no source allowd on property object
Here is your example working and fixed
https://codesandbox.io/s/Kr8pp1Y3J
problem is when you use attribute:true which is not recommended ( perf reasons -> 2 way property attribute reflection ), so maybe we have bug in that use case @treshugart  ?

If we can confirm that attribute: true is a problem, then yeah, it'd be a bug.

yup my example confirms that

Thanks you all for the details

Tried to repo the issue, but I'm not sure if I've mis-understood the bug.
https://github.com/sugendran/skatejs/commit/c4f2fa40095cffe457c5cc643ce3b5b7abf4ccd4

This shouldn't be an issue in @skatejs/element anymore.


React in web-component tutorial missing unmount

We are using a react component through a web-component inspired by the snippet in docs.
We stumbled over an issue after which we noticed that the component is never unmounted.
We added a disconnectedCallback like this
disconnectedCallback() {
    ReactDOM.unmountComponentAtNode(this)
  }

I could make a quick PR adding that if you folks think that makes sense!

It's HTML error


Sample code is having syntax error in TensorFlow nodejs code

System information

TensorFlow version:
Doc Link:

Syntax error in TensorFlow nodejs example
See sample code for Node.js usage
Extra semicolon is causing the syntax error.
onEpochEnd: (epoch, log) => console.log(Epoch ${epoch}: loss = ${log.loss});
In the above line, semi-colon in the end should be removed.

The link you have referenced does not refer to the sample code you are referring too. Can you please take a look and provide pointers? Thanks!

Sure Yasir
Thanks and Regards,
Ashwini Gadag
On Fri, Apr 5, 2019 at 12:07 AM ymodak<EMAIL_ADDRESS>wrote:

The link you have referenced does not refer to the sample code you are
referring too. Can you please take a look and provide pointers? Thanks!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/27361#issuecomment-480013010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AuOvzUxVkv7BHZ6NBaAjiYQuboZ9Ekmwks5vdkZbgaJpZM4cVDzg
.

Thanks for reporting. Closing since its  a duplicate #27237

Thanks for reporting @varun-jalandery. @ymodak I think you can close the original issue the #27237


stuck at "Initializing distributed.." when using ddp with multiple gpus

First check

[x] I'm sure this is a bug.
[X] I've added a descriptive title to this bug.
[X] I've provided clear instructions on how to reproduce the bug.
[X] I've added a code sample.
[X] I've provided any other important info that is required.

Bug description
Dear community,
I'm desperately trying to achieve multi gpu training on our scientific SLURM cluster. It has one gpu (Tesla T4) per node, so specifically I want to achieve multi node multi gpu training. For testing I just use a minimal example from PL documentation (https://pytorch-lightning.readthedocs.io/en/latest/starter/introduction.html) to ensure that the error is not build in my model.
Even when allocating only 1 gpu the code hangs. When using "dp" instead of "ddp" it runs (though not really faster).
How to reproduce the bug
MODELL:

import os
from torch import optim, nn, utils, Tensor
from torchvision.datasets import MNIST
from torchvision.transforms import ToTensor
import pytorch_lightning as pl

os.environ['CUDA_LAUNCH_BLOCKING'] = '1'

# define any number of nn.Modules (or use your current ones)
encoder = nn.Sequential(nn.Linear(28 * 28, 64), nn.ReLU(), nn.Linear(64, 3))
decoder = nn.Sequential(nn.Linear(3, 64), nn.ReLU(), nn.Linear(64, 28 * 28))

# define the LightningModule
class LitAutoEncoder(pl.LightningModule):
    def __init__(self, encoder, decoder):
        super().__init__()
        self.encoder = encoder
        self.decoder = decoder

    def training_step(self, batch, batch_idx):
        # training_step defines the train loop.
        # it is independent of forward
        x, y = batch
        x = x.view(x.size(0), -1)
        z = self.encoder(x)
        x_hat = self.decoder(z)
        loss = nn.functional.mse_loss(x_hat, x)
        # Logging to TensorBoard by default
        self.log("train_loss", loss)
        return loss

    def configure_optimizers(self):
        optimizer = optim.Adam(self.parameters(), lr=1e-3)
        return optimizer

# init the autoencoder
autoencoder = LitAutoEncoder(encoder, decoder)

# setup data
dataset = MNIST(os.getcwd(), download=True, transform=ToTensor())
train_loader = utils.data.DataLoader(dataset, num_workers=8)

# train the model (hint: here are some helpful Trainer arguments for rapid idea iteration)
trainer = pl.Trainer(limit_train_batches=1000, max_epochs=4, accelerator="gpu", devices=1, strategy="ddp", num_nodes=4)

trainer.fit(model=autoencoder, train_dataloaders=train_loader)

# load checkpoint
checkpoint = "./lightning_logs/version_0/checkpoints/epoch=0-step=100.ckpt"
autoencoder = LitAutoEncoder.load_from_checkpoint(checkpoint, encoder=encoder, decoder=decoder)

# choose your trained nn.Module
encoder = autoencoder.encoder
encoder.eval()

# embed 4 fake images!
fake_image_batch = Tensor(4, 28 * 28)
embeddings = encoder(fake_image_batch)
print("⚡" * 20, "\nPredictions (4 image embeddings):\n", embeddings, "\n", "⚡" * 20)

SLURM SUBMISSION SCRIPT:
#!/bin/bash
#SBATCH -J test
#SBATCH -e test.err
#SBATCH -o test.log
#SBATCH --ntasks-per-node 4
#SBATCH --cpus-per-task 4
#SBATCH --gres gpu:1
#SBATCH --nodes 4

SECONDS=0
python train.py
echo "$SECONDS seconds passed"

Error messages and logs
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/4

Important info
cuda 11.2
torch 1.12.1
pytorch-lightning 1.7.6

More info
I tried out various things from many threads but still can't even get this minimal example to work :(
This is my first bug report ever, please don't hate and thanks a lot in advance!

Can you try launching this script instead? It's simpler and the one we use for bug reports
https://github.com/Lightning-AI/lightning/blob/master/examples/pl_bug_report/bug_report_model.py
Also, os.environ['CUDA_LAUNCH_BLOCKING'] = '1' is for debugging and will make your run considerably slower

Dear carmocca, thank you for your reply! I tried your bug_report_model, but still run into the same issue. I only added lines  accelerator="gpu", devices=1, strategy="ddp", num_nodes=4. Thank you in advance!

Hey @FlorianWieser1
Our SLURM docs here have a template for the slurm submission script. One thing which is very important is that the number of nodes and processes configured there need to match with what is in the Trainer! This mismatch is the most likely cause why it gets stuck. Try to change it:
#!/bin/bash
#SBATCH -J test
#SBATCH -e test.err
#SBATCH -o test.log
#SBATCH --nodes=4   <--- MUST MATCH num_nodes IN TRAINER
#SBATCH --gres=gpu:1
#SBATCH --ntasks-per-node=1   <--- MUST MATCH devices IN TRAINER
Trainer(accelerator="gpu", devices=1, strategy="ddp", num_nodes=4)

Also, please pay close attention on how to invoke the script, it should be done with srun. You have
python train.py

But it should be
srun python train.py

I will try to make it more clear in the docs.
I also have this related proposal open #10150

Dear awaelchli, the missing "srun" command fixed it for me! :) Thanks a lot!

Great to see you were able to solve it.
If only we could provide a warning if the user forgot that.
I thought about this but it seems impossible, because we can only auto-detect SLURM in a reliable way if the corresponding environment variables are set. But they only get set when you run with srun 😄
So this is a pickle. Writing it in bold in the doc will help some people, but would it have helped you @FlorianWieser1?

Haha I see thats a Problem :joy:
I don't know to be honest, I've been on this documentation side you linked mulitple time, but still I overlooked or forgot about the "srun". I'm not new to SLUM so I knew about "srun". I guess the documentation is fine and this was really my fault :)
Before I came here I randomly searched the internet for things like "slurm pytorch lightning ddp multi node" etc.
Best,
Florian


Wiki

Set up an available wiki where the project documentation is accessible.

Wiki accessible at https://github.com/whiteyhat/Lightning-Network-Simulation/wiki


HTML labels and edges with ports from element to element

a node Label can contain complex HTML with many sub-elements (e.g. a table); and Edges can connect those internal sub-elements (e.g. connecting cells of the tables)

Thanks for the contribution, I have a suggestion; I think we should use the same label property for both html and non-html content. It would prevent some confusion about the HtmlLabel property getting/setting the same value as Label underneath.
For this I would update the constructor of DotLabelAttribute by adding isHtml = false, so the final result for creating a html label would look like this:
node.Label = new DotLabelAttribute("

a

", true);

Thanks for the library!
when adding HtmlLabel attribute, instead of additional parameters, i thought it might express the intention more obviously -- some people dislike boolean flags-parameters.
but on the other hand, referring to the same label through two names can also be confusing, so, it's the matter of style

Understandable. Then I would just edit the Node's Label setter to set IsHtml to false.
I'll merge right after :)


Make sure all controllers have Not Found if it's incorrect URL

I know for sure IssueController is missing this

I believe I fixed this now