S3DIS usage

Hello,
I see that your code looks simular to SoftGroup (they probably copied from you, but let's put that aside).
I want to test HAIS on the S3DIS dataset but I see no readme file that shows me how to do so. I could try to modify it myself but I see that you also have benchmark results on S3DIS so it would be nice to get the files to make it work (and how).
Finally I am curious about the visualisation for S3DIS, do you have something for this as well?
I look forward to hearing from you!
Kind Regards,
Goose.

hi.Have you solved it now?

hi.Have you solved it now?

@CodeFly-123 No I have not fixed HAIS. I am using SoftGroup now, works fine besides a small memory leak but I am not sure it is on my side of in the code.

@GooseFather990  I also am using SoftGroup now, But test large scene on s3dis dataset，
The result was a little bad. for example Area_2_auditorium_2_inst_nostuff.pth file. Can you test it and see how it works well？Thank you very much if you can.

@CodeFly-123 I saw some decent results for instance segmentation. I got an average of 66%AP on Area_5 with loss still going down (view with tensorboard). Now I am using a custom dataset so you cannot compare these numbers anymore with a custom situation. If u use it in semantic only however, the results are great. With some external magic you can make the grouping more efficient compared to the instance segmentation but ohw well...

@GooseFather990  Thank you！ I also got an average of 66%AP on Area_5. but when test alone "Area_2_auditorium_2_inst_nostuff.pth" scene in Area_2, the result was a little bad. If it's convenient for you, you can test it and visualize it. We can compare and verify the results. Because Area_2 is used as train set，I think Its result won't be too bad. I doubt that the ability to big scenes is still limited. I've been trying to solve this problem recently.
I hope we can communicate and solve problems together.

我在实例细分方面看到了一些不错的结果。我在Area_66上的平均AP为5%，损失仍在下降（使用张量板查看）。现在我使用的是自定义数据集，因此您无法再将这些数字与自定义情况进行比较。但是，如果您仅在语义中使用它，则结果很棒。与实例分段相比，使用一些外部魔法，您可以使分组更有效，但是哦，好吧......

Hello! I am currently replicating the experiment on SoftGroup, but my computer only has one GPU. When I change the command line from "./tools/dist_train. sh configs/softgroup_stpls3d_backup. yaml 4" to "./tools/dist_train. sh configs/softgroup_stpls3d_backup. yaml 1", I can read the parameters in the. yaml file normally, but I still report an error: "RuntimeError: CUDA error: invalid device function". Do you know why this is


⚠ WSINGRESOS - RECIBOPAGO has degraded performance

In 92eea84, WSINGRESOS - RECIBOPAGO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsRecibosPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 2183 ms

Resolved: WSINGRESOS - RECIBOPAGO performance has improved in 84d7ac3.


Unable to receive failed tests report from remote machine when using Kotlin Coroutines runTest

Hi, I'm experiencing a weird behavior when executing unit tests from Android Studio. I'm unable to receive the failed tests report from the remote machine and the IDE execution never ends. The execution seems to have finished but the IDE is not aware of it as it can be seen on this screenshot:

After debugging, I noticed that this is only happening when using runTest method from kotlin-coroutines-test package on the test that is failing and from the IDE (it works ok from command line). For example:
@Test
fun `this test should fail`() = runTest {
    assertTrue(false)
}

Here you have an example repository where this bug can be reproduced after enabling remote compilation with Mirakle plugin: test-remote-compilation
Other information:

Android Studio version: Dolphin 2021.3.1
Mirakle version: 1.6.0

Hey, it is a weird thing, I can't find a way to fix this.


init logger with version/experiment_name based on hparams

I'm using LightningCLI, however, I could not find a convinced way to init logger with version/experiment_name based on hparams, which make my log folder more readable:

cc @carmocca @mauvilsa Is there an option for this?

I think I can customize CLI's fun
before_instance_class to init my logger, sorry for bothering.


[IOTDB-6111] Fix Region creation bugs

Updations:

Both the Running and Unknown DataNodes can be used when making CreateRegionGroupsPlan. Since we have IoTDB-Region-Maintainer thread in PartitionManager to ensure the creation at Unknown DataNodes will finally successed.
Distinguish re-creation and re-deletion in IoTDB-Region-Maintainer. So that these corner cases wouldn't stuck into infinite loop.

coverage: 48.071% (-0.03%) from 48.103% when pulling eb6c61c976f6b19ff759a492cd232edf29e4a7b4 on Fix-Region-creation-bugs into 031495a6301937cbc0ac6066fb147322ea18a1c2 on master.


Feature request: Make it easier to assert against sent SES emails

As a feature request, it would be nice if the Mock SES backend kept the actual email content in the sent_messages list, and made it easy to make assertions against them.
I think two things would be needed:

The Message class would have to capture actual content of the emails.

The backend would have to expose those messages somehow so test code could assert against them.

I'm imagining something like
with fake_ses() as mock_ses:
    ... # tests that trigger sending email
    assert<EMAIL_ADDRESS>in mock_ses.sent_messages[0].recipients

Hi @bjmc,
You can do this by asserting against the SES backend e.g:
from moto.ses import ses_backend
assert<EMAIL_ADDRESS>in ses_backend.sent_messages[0].recipients

This was not clear to me either :)

Going to close this. @r1b 's suggestion is our current best practice.

@bjmc The SES backend state is available on the SES module, e.g:
from boto.ses import ses_backend
assert ses_backend.sent_messages[0]

For future readers, ses_backend is available on moto not boto:
from moto.ses import ses_backend
#    ^^^^
assert ses_backend.sent_messages[0]


Support for OWL2 vocabulary

OWL2 uses the same namespace as OWL, but adds some properties like owl:deprecated
See also https://www.w3.org/TR/owl2-overview/

Hi what is needed for adding OWL2? "only" the vocabulary, or there is also some test to be implemented?

As far as I'm concerned, it's only about adding the vocabulary (I just wanted to use the owl:deprecated property in a project, without OWL2 reasoning)
So if you think it would be a good idea, it can be added very quickly.

Hi do you have a link to the full vocabulary?
2017-08-01 19:35 GMT+02:00 Bart Hanssens<EMAIL_ADDRESS>
As far as I'm concerned, it's only about adding the vocabulary (I just
wanted to use the owl:deprecated property in a project, without OWL2
reasoning)
So if you think it would be a good idea, it can be added very quickly.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eclipse/rdf4j/issues/766#issuecomment-319441672, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFYfHr2nawMSR48KqgGBXIIn_y0bmKrks5sT2HQgaJpZM4MIX-c
.

https://www.w3.org/2002/07/owl# (OWL2 reuses the OWL 1 namespace, and IIRC they are very similar)


AttributeError: 'EntryPoints' object has no attribute 'get'

What is going wrong here?  Sorry for the delay.


add opensearch 1.12.1

Towards: https://github.com/giantswarm/giantswarm/issues/21942

Not proceeding further with this.


Update xosp_devices_deps.xml

Look on XOSP-Devices there are already there. Just update the xosp.dependencies file


python310Packages.bitstring: 3.1.9 -> 4.0.1

Description of changes
https://github.com/scott-griffiths/bitstring/releases/tag/bitstring-4.0.1
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 203309 run on x86_64-linux 1

10 packages failed to build:

electrum-grs
esphome
esptool
pynitrokey
python310Packages.angrop
python310Packages.cypherpunkpay
python310Packages.spsdk
python39Packages.angrop
python39Packages.cypherpunkpay
python39Packages.spsdk

29 packages built:

cantoolz
chia
electrum
electrum-ltc
home-assistant-component-tests.lifx
opsdroid
python310Packages.ailment
python310Packages.aiolifx
python310Packages.aiolifx-connection
python310Packages.aiolifx-effects
python310Packages.aiolifx-themes
python310Packages.angr
python310Packages.angrcli
python310Packages.bitstring
python310Packages.cle
python310Packages.pysml
python310Packages.pyvex
python39Packages.ailment
python39Packages.aiolifx
python39Packages.aiolifx-connection
python39Packages.aiolifx-effects
python39Packages.aiolifx-themes
python39Packages.angr
python39Packages.angrcli
python39Packages.bitstring
python39Packages.cle
python39Packages.pysml
python39Packages.pyvex
resp-app

Some packages fail to build because they specify bitstring<=3.1. Upstream (bitstring) says 3.1.x is still supported, should we keep it as well?

Thanks for running nixpkgs-review. I'll take a look at those failures and check if the <=3.1 constraints are necessary.

The status of the broken packages:

electrum-grs: broken because of incompatible protobuf version and unrelated to bitstring and I couldn't fix it
esphome: broken only because esptool is broken
esptool: https://github.com/NixOS/nixpkgs/pull/203403
pynitrokey: broken only because pythonPackages.spsdk is broken
pythonPackages.angrop: broken because of incompatible angr version and unrelated to bitstring, but will be fixed in https://github.com/NixOS/nixpkgs/pull/203338
pythonPackages.cypherpunkpay: https://github.com/NixOS/nixpkgs/pull/203341
pythonPackages.spsdk: https://github.com/NixOS/nixpkgs/pull/203343

/cc @dotlambda I moved the esptool changes into this PR and kept the old patches and testing strategy unchanged. The esptool_3 patch is still being reviewed by upstream and could undergo additional changes.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1502

Result of nixpkgs-review pr 203309 run on x86_64-linux 1

1 package failed to build:

electrum-grs

39 packages built:

cantoolz
chia
electrum
electrum-ltc
esphome
esptool
esptool_3
home-assistant-component-tests.lifx
opsdroid
pynitrokey
python310Packages.ailment
python310Packages.aiolifx
python310Packages.aiolifx-connection
python310Packages.aiolifx-effects
python310Packages.aiolifx-themes
python310Packages.angr
python310Packages.angrcli
python310Packages.angrop
python310Packages.bitstring
python310Packages.cle
python310Packages.cypherpunkpay
python310Packages.pysml
python310Packages.pyvex
python310Packages.spsdk
python39Packages.ailment
python39Packages.aiolifx
python39Packages.aiolifx-connection
python39Packages.aiolifx-effects
python39Packages.aiolifx-themes
python39Packages.angr
python39Packages.angrcli
python39Packages.angrop
python39Packages.bitstring
python39Packages.cle
python39Packages.cypherpunkpay
python39Packages.pysml
python39Packages.pyvex
python39Packages.spsdk
resp-app

electrum-grs failure is unrelated:
ERROR: Could not find a version that satisfies the requirement protobuf<4,>=3.12 (from electrum-grs) (from versions: none)
ERROR: No matching distribution found for protobuf<4,>=3.12

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/724


Multiline editing keyboard shortcuts not working

Issue Type: Bug
The multiline editing keyboard shortcuts CTRL+ALT+UP/DOWN is not working for me all of a sudden. I've tried uninstalling and reinstalling VS Code, but that hasn't helped.
VS Code version: Code 1.49.0 (e790b931385d72cf5669fcefc51cdf65990efa5d, 2020-09-10T13:22:08.892Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (16 x 2904)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.74GB (9.77GB free)

Process Argv
--crash-reporter-id 3c013fe6-b98b-44c2-99bd-6e8c87ac3cdb

Screen Reader
no

VM
0%

Extensions: none

/needsMoreInfo
Do you have Intel Graphics Command Center software? Most likely problem similar to #106256
Do you see these shortcuts if you follow steps in https://github.com/microsoft/vscode/issues/106256#issuecomment-688519096 or what new tool https://code.visualstudio.com/updates/v1_49#_improved-keybinding-diagnostics?

Hi Andrii,
I’ve traced the problem to the Nvidia Geforce Experience software that had it’s own key bindings. Once I disabled that the VS Code key bindings worked normally. Thanks for you help.
Kelly
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Andrii<EMAIL_ADDRESS>Sent: Saturday, September 12, 2020 9:50 AM
To<EMAIL_ADDRESS>Cc: Kelly<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] Multiline editing keyboard shortcuts not working (#106529)
/needsMoreInfo
Do you have Intel Graphics Command Center software? Most likely problem similar to #106256https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fissues%2F106256&data=02|01||d49416190c4540c86b5208d85722da93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637355154485027140&sdata=7vUZj3HZShDOlqRvu%2FVZ0OC3v2HjLT9ENoprQtWvdlo%3D&reserved=0
Do you see these shortcuts if you follow steps in #106256 (comment)https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fissues%2F106256%23issuecomment-688519096&data=02|01||d49416190c4540c86b5208d85722da93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637355154485027140&sdata=cRScS6IaQinBDr8Y%2FVfWKnT9IzRMh4dyeETImLGJguM%3D&reserved=0 or what new tool https://code.visualstudio.com/updates/v1_49#_improved-keybinding-diagnosticshttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode.visualstudio.com%2Fupdates%2Fv1_49%23_improved-keybinding-diagnostics&data=02|01||d49416190c4540c86b5208d85722da93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637355154485037136&sdata=dN35wsUm06Gkz%2B3pL6e67NlsXlWPsHh6oC3d7NBkc%2Bk%3D&reserved=0?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fissues%2F106529%23issuecomment-691491648&data=02|01||d49416190c4540c86b5208d85722da93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637355154485037136&sdata=fG5%2B8KJ8acOTnEWN%2BRZnM%2BdfY1icXT6VUIuMTR%2FYtQA%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALDDBUUZAC57RVW7EDBEB2TSFN4DNANCNFSM4RIZ3XGQ&data=02|01||d49416190c4540c86b5208d85722da93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637355154485047131&sdata=sB7TaCfM7EKTGx0z6BQJoI%2Fb3Mfb%2BcA4eHfkfIAA4KA%3D&reserved=0.

Thanks for reporting back. Closing the issue.


Run PythonBridge tests as part of CI/CD

Run PythonBridge tests as part of CI/CD (at least on one platform).
Add some additional testable high level functional examples.
Check out existing unit tests (PythonBridge-Tests package).

unit tests in PythonBridge and PythonBridge-Pharo should now all be green
unit tests in Python3Generator require https://github.com/juliendelplanque/Python3Generator/pull/6 so skip them for now
some elementary s where added to PythonBridge-Pharo https://github.com/feenkcom/PythonBridge/commit/918686832dc309c792339e20f511db3c9e3fd2b0
ready for integration

Enabled with
https://github.com/feenkcom/gtoolkit/commit/8760c602dd00ff537709f2cb7baad42663ac3487
Running
https://github.com/feenkcom/PythonBridge/blob/main/scripts/run_python_examples.sh
on [ubuntu-scooby-doo] Linux (AMD64) only
Requires
https://pypi.org/project/gtoolkit_bridge/0.1.7/
Result


Allow legacy timezone

My localzone() shows Europe/Kiev that is a legacy name for Europe/Kyiv.
julia> localzone()
Europe/Kiev (UTC+2/UTC+3)

julia> istimezone(string(localzone()))
false

julia> istimezone("Europe/Kyiv")
true

julia> istimezone("Europe/Kiev")
false

julia> istimezone(string(localzone()), TimeZones.Class(:DEFAULT) | TimeZones.Class(:LEGACY))
true

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.50 :warning:

Comparison is base (c1ea853) 84.31% compared to head (2695600) 83.81%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   84.31%   83.81%   -0.50%
==========================================
  Files           4        4
  Lines         357      346      -11
==========================================
- Hits          301      290      -11
  Misses         56       56

Impacted Files
Coverage Δ

src/preferences.jl
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


limit amount of lines in "dokku logs -t"

Long running applications are producing enormous amount of logs and currently "dokku logs -t" throws all history from proccess start to console.
This patch limits amounts of log lines to 100, as in "dokku logs" without -t

Seems reasonable to me.


Build error on easy-format and jbuilder

Error message when I tried to build was:
info building @opam/cmdliner@opam:1.0.2@8ab0598a
error: build failed with exit code: 1
build log:
# esy-build-package: building: @opam/easy-format@opam:1.3.1
# esy-build-package: pwd: C:\Users\DarrylSpencer.esy\3_\b\opam__s__easy_format-opam__c__1.3.1-386c7282
# esy-build-package: running: "jbuilder" "build" "-p" "easy-format" "-j" "4"
The jbuilder binary is deprecated and will cease to be maintained in July 2019.
Please switch to dune instead.
File "test/jbuild", line 1, characters 0-0:
Warning: jbuild files are deprecated, please convert this file to a dune file instead.
Note: You can use "dune upgrade" to convert your project to dune.
Error: I don't know about package easy-format (passed through --only-packages/--release)
error: command failed: "jbuilder" "build" "-p" "easy-format" "-j" "4" (exited with 1)
esy-build-package: exiting with errors above...
building @opam/easy-format@opam:1.3.1
esy: exiting due to errors above

Seems like this has been fixed long ago since we're not using jbuilder anymore. Therefore closing this, but let me know if there's still an issue!


Login Component

Description
Created the Login endpoint:
Included:

email input
password input
hide/show password functionality
forgot password link
submit button
facebook/google login auth
signup link

Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

 Front-End: Multi-functional Login Route

 Front-End: Multi-functional Login Route


[happy] Initial commit for adding Happy test

Summary of Changes

Adds happy to submodule
Adds test_inet_multicast_01.py and necessary supporting libs.

To test:
make -f Makefile-standalone  # Will change to gn build
abs_builddir=`pwd`/build/x86_64-unknown-linux-gnu/src/inet/tests python3 src/test_driver/happy/tests/standalone/inet/test_inet_multicast_five_nodes_on_wifi.py.py

fixes #1207

It is just the first test. It would have test_Inet_multicast_02.py or more.
All tests would be run in parallel, and there is no dependency among these
tests
On Thu, Aug 27, 2020 at 2:40 PM Michael Spang<EMAIL_ADDRESS>wrote:

@mspang commented on this pull request.
In src/test_driver/happy/tests/standalone/inet/test_inet_multicast_01.py
https://github.com/project-chip/connectedhomeip/pull/2319#discussion_r478710161
:

@@ -0,0 +1,223 @@
+#!/usr/bin/env python3

What does the number 01 mean
"test_inet_multicast_01"
Will the tests have to run in order?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/project-chip/connectedhomeip/pull/2319#pullrequestreview-477102222,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGJNQF2RP7TNKTJ33PWC7BTSC3HDTANCNFSM4QKMSNJQ
.

It is just the first test. It would have test_Inet_multicast_02.py or more. All tests would be run in parallel, and there is no dependency among these tests
…
On Thu, Aug 27, 2020 at 2:40 PM Michael Spang @.> wrote: @.* commented on this pull request. ------------------------------ In src/test_driver/happy/tests/standalone/inet/test_inet_multicast_01.py <#2319 (comment)> : > @@ -0,0 +1,223 @@ +#!/usr/bin/env python3 What does the number 01 mean "test_inet_multicast_01" Will the tests have to run in order? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2319 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJNQF2RP7TNKTJ33PWC7BTSC3HDTANCNFSM4QKMSNJQ .

I think we shouldn't number the tests, then.

All tests would be run in parallel, and there is no dependency among these tests

I think we shouldn't number the tests, then.

Yep, agree, hi, song, please modify the name with some meaningful postfix

@mspang any further comments?

@mspang any further comments?


Container view scroll issue

I have a weird behavior with 2 basic view controllers. XLPagerTabStrip appears to reserve space for 2 view controllers but twice (under each tab)

Any idea what it might be?
Environment:
XLPagerTabStrip: 5.0.0
Xcode 7.3.1
iOS 9.3

@mtnbarreto ^

I got it working by moving functionality over to a clean slate controller and using container to embed the tab controller view.


setup.sh does not download necessary libraries for 3.0

@mcdonamp
When I run setup.sh for the new 3.0 version, I get the following error (this is after it successfully downloads the firebase SDK):
-----------------------------------------------
STARTING FACEBOOK
-----------------------------------------------
Downloading Facebook SDK...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 55838    0 55838    0     0  41537      0 --:--:--  0:00:01 --:--:--  117k
Extracting Facebook SDK...
Archive:  ******/FirebaseUI-iOS/sdk/facebook-sdk.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of ******/FirebaseUI-iOS/sdk/facebook-sdk.zip or
        ******/FirebaseUI-iOS/sdk/facebook-sdk.zip.zip, and cannot find ******/FirebaseUI-iOS/sdk/facebook-sdk.zip.ZIP, period.

I put the ****** in the paths for privacy.
I have some new major updates that I would like to include, but I can't until I can get this to run properly.

Interesting--looks like that version of the Facebook SDK no longer exists, so I switched the download link to https://origincache.facebook.com/developers/resources/?id=facebook-ios-sdk-current.zip which looks like it's pinned at the current version. We should likely do the same with Google as well.

This is fixed in #24

Nice
On Monday, November 30, 2015, Michael McDonald<EMAIL_ADDRESS>wrote:

This is fixed in #24 https://github.com/firebase/FirebaseUI-iOS/pull/24
—
Reply to this email directly or view it on GitHub
https://github.com/firebase/FirebaseUI-iOS/issues/22#issuecomment-160811362
.


/p:CoverletOutputDirectory= not working

the param /p:CoverletOutputDirectory= is still outputting the data into the root of the project.
It's regarding version 2.10 and I was wondering if this could be fixed

Try this one:
/p:CoverletOutput=path/reportfile.xml
See the last sentence in this paragraph: https://github.com/tonerdo/coverlet/blob/master/README.md#coverage-output

Thnx! Abny idea when it will be possible to merge all coverage files from different projects into 1 file?

That's currently being worked on in #123


Trouble getting started

Hello, I'm really excited to use this extension, but I cannot get it to work. Do I need to have the original plugin installed in order to use the docker version?
These are my settings:
{
    "phpsab.docker.dockerEnabled": true,
    "phpsab.docker.dockerContainer": "wordpress",
    "phpsab.docker.dockerWorkspaceRoot": "/var/www/html/wp-content/plugins/my-plugin",
    "phpsab.docker.dockerExecutablePathCBF": "/var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcbf",
    "phpsab.docker.dockerExecutablePathCS": "/var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcs",
    "phpsab.docker.snifferMode": "onType",
    "phpsab.docker.debug": true,
}

I've verified that I can run docker exec -i wordpress /var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcs -i and it displays the list of installed standards correctly.
Even with the debug enabled I'm not getting any error messages or feedback from the developer tools console, nor any errors in VS Code.
I'm developing on WSL2 ubuntu 20.04 distro with Docker Desktop using a docker-compose.yml file to setup my containers.
Any help greatly appreciated 🙏

Hey @tg-jbenson,
If the remove the dockerExecutablePathCBF and dockerExecutablePathCS path properties does anything change?
Everything looks good to me though, I can't replicate this with the same configuration on Linux.
If that doesn't work, could you send over any logs from the Output terminal in VS  Code? See screenshot of where to find this.

Cheers

Hey, thank you for taking a look! That did change something, with these settings:
{
    "phpsab.docker.dockerEnabled": true,
    "phpsab.docker.dockerContainer": "wordpress",
    "phpsab.docker.dockerWorkspaceRoot": "/var/www/html/wp-content/plugins/my-plugin",
    "phpsab.docker.snifferMode": "onType",
    "phpsab.docker.debug": true,
}

Now if I run the PHPCBF: Fix this file with F1 it pops up a VScode message:
Fixer is disable for this workspace or PHPCBF was not found for this workspace.
but I'm not getting anything from Output, or in the devtools console with debug enabled
I'm not sure if it matters, but I only have phpcs/phpcbf and composer/php installed in the container, not locally at all

Ah sorry, I missed the output dropdown, thanks for the screenshot here is my log
["INFO" - 1:00:01 PM] DOCKER: Resolved docker path:
["INFO" - 1:00:01 PM] DOCKER: Resolved docker path:
["INFO" - 1:00:01 PM] The phpcs executable was not found for my-plugin
["INFO" - 1:00:01 PM] The phpcbf executable was not found for my-plugin
["INFO" - 1:00:01 PM] CONFIGURATION
{
  "resources": [
    {
      "useFilepath": false,
      "containerExec": "docker",
      "fixerEnable": false,
      "fixerArguments": [],
      "workspaceRoot": "/home/bensonism/projects/my-plugin",
      "executablePathCBF": "",
      "executablePathCS": "",
      "composerJsonPath": "composer.json",
      "standard": null,
      "autoRulesetSearch": true,
      "allowedAutoRulesets": [
        ".phpcs.xml",
        ".phpcs.xml.dist",
        "phpcs.xml",
        "phpcs.xml.dist",
        "phpcs.ruleset.xml",
        "ruleset.xml"
      ],
      "snifferEnable": false,
      "snifferArguments": [],
      "dockerEnabled": true,
      "dockerContainer": "wordpress",
      "dockerWorkspaceRoot": "/var/www/html/wp-content/plugins/my-plugin",
      "dockerExecutablePathCBF": "",
      "dockerExecutablePathCS": ""
    }
  ],
  "snifferMode": "onType",
  "snifferShowSources": false,
  "snifferTypeDelay": 250,
  "debug": true
}

OKAY, I made some progress, maybe my project is setup weird, but my composer.json isnt in the project root, its one folder down in project-root/my-plugin/composer.json -- because that's the folder that gets mounted in the container and where I want it to run composer install etc.
SO by adding the ``"phpsab.docker.composerJsonPath": "my-plugin/composer.json",``` setting
Now it's resolved the paths and it's able to fix my files when I run the command with F1 + PHPCBF: Fix this file, but it's not giving me any of the sniff highlighting that the original extension was doing, and I'm not getting any errors related to that in the output logs either

In case its helpful here's the logs
when I add the setting:
["INFO" - 1:18:38 PM] DOCKER: Resolved docker path: /var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcbf
["INFO" - 1:18:38 PM] DOCKER: Resolved docker path: /var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcs
["INFO" - 1:18:38 PM] CONFIGURATION
{
  "resources": [
    {
      "useFilepath": false,
      "containerExec": "docker",
      "fixerEnable": true,
      "fixerArguments": [],
      "workspaceRoot": "/home/bensonism/projects/my-plugin",
      "executablePathCBF": "/home/bensonism/projects/my-plugin/my-plugin/vendor/bin/phpcbf",
      "executablePathCS": "/home/bensonism/projects/my-plugin/my-plugin/vendor/bin/phpcs",
      "composerJsonPath": "my-plugin/composer.json",
      "standard": null,
      "autoRulesetSearch": true,
      "allowedAutoRulesets": [
        ".phpcs.xml",
        ".phpcs.xml.dist",
        "phpcs.xml",
        "phpcs.xml.dist",
        "phpcs.ruleset.xml",
        "ruleset.xml"
      ],
      "snifferEnable": true,
      "snifferArguments": [],
      "dockerEnabled": true,
      "dockerContainer": "wordpress",
      "dockerWorkspaceRoot": "/var/www/html/wp-content/plugins",
      "dockerExecutablePathCBF": "/var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcbf",
      "dockerExecutablePathCS": "/var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcs"
    }
  ],
  "snifferMode": "onType",
  "snifferShowSources": false,
  "snifferTypeDelay": 250,
  "debug": true
}

and when I run the fixer:
["INFO" - 1:21:05 PM] Fixer running
["INFO" - 1:21:05 PM] Standards Search paths:
[
  "/home/bensonism/projects/my-plugin/my-plugin/",
  "/home/bensonism/projects/my-plugin/"
]
["INFO" - 1:21:05 PM] Standards Search files:
[
  "/home/bensonism/projects/my-plugin/my-plugin/.phpcs.xml",
  "/home/bensonism/projects/my-plugin/my-plugin/.phpcs.xml.dist",
  "/home/bensonism/projects/my-plugin/my-plugin/phpcs.xml",
  "/home/bensonism/projects/my-plugin/my-plugin/phpcs.xml.dist",
  "/home/bensonism/projects/my-plugin/my-plugin/phpcs.ruleset.xml",
  "/home/bensonism/projects/my-plugin/my-plugin/ruleset.xml",
  "/home/bensonism/projects/my-plugin/.phpcs.xml",
  "/home/bensonism/projects/my-plugin/.phpcs.xml.dist",
  "/home/bensonism/projects/my-plugin/phpcs.xml",
  "/home/bensonism/projects/my-plugin/phpcs.xml.dist",
  "/home/bensonism/projects/my-plugin/phpcs.ruleset.xml",
  "/home/bensonism/projects/my-plugin/ruleset.xml"
]
["INFO" - 1:21:05 PM] Standards Search found:
"/home/bensonism/projects/my-plugin/my-plugin/phpcs.xml"
["INFO" - 1:21:05 PM] DOCKER: Resolved docker path: /var/www/html/wp-content/plugins/my-plugin/phpcs.xml
["INFO" - 1:21:05 PM] DOCKER: Resolved docker path: /var/www/html/wp-content/plugins/my-plugin/my-plugin.php
["INFO" - 1:21:05 PM] FIXER COMMAND: docker exec -i wordpress /var/www/html/wp-content/plugins/my-plugin/vendor/bin/phpcbf -q --standard=/var/www/html/wp-content/plugins/my-plugin/phpcs.xml --stdin-path=/var/www/html/wp-content/plugins/my-plugin/my-plugin.php -
["INFO" - 1:21:06 PM] Fixer ran for 0.256 seconds

Hey @tg-jbenson,
Thanks for the info!
I've done some tests locally and put together a new release which will hopefully patch this.
The release version is 0.0.9. Can you test it out and see if it works for you?
This is the config I was working with (which hopefully is close to yours!):
{
	"phpsab.docker.dockerEnabled": true,
	"phpsab.docker.dockerContainer": "<container_id>",
	"phpsab.docker.dockerWorkspaceRoot": "/var/www/html",
	"phpsab.docker.composerJsonPath": "my-plugin/composer.json",
	"phpsab.docker.dockerExecutablePathCBF": "/var/www/html/my-plugin/vendor/bin/phpcbf",
	"phpsab.docker.dockerExecutablePathCS": "/var/www/html/my-plugin/vendor/bin/phpcs",
	"phpsab.docker.debug": true,
	"phpsab.docker.snifferMode": "onType",
}

This results in a configuration object in Output like this:
{
  "resources": [
    {
      "useFilepath": false,
      "containerExec": "docker",
      "fixerEnable": true,
      "fixerArguments": [],
      "workspaceRoot": "/home/matthew/Workspace/phpcs-test",
      "executablePathCBF": "",
      "executablePathCS": "",
      "composerJsonPath": "my-plugin/composer.json",
      "standard": null,
      "autoRulesetSearch": true,
      "allowedAutoRulesets": [
        ".phpcs.xml",
        ".phpcs.xml.dist",
        "phpcs.xml",
        "phpcs.xml.dist",
        "phpcs.ruleset.xml",
        "ruleset.xml"
      ],
      "snifferEnable": true,
      "snifferArguments": [],
      "dockerEnabled": true,
      "dockerContainer": "d27cc988ee07",
      "dockerWorkspaceRoot": "/var/www/html",
      "dockerExecutablePathCBF": "/var/www/html/my-plugin/vendor/bin/phpcbf",
      "dockerExecutablePathCS": "/var/www/html/my-plugin/vendor/bin/phpcs"
    }

Cheers

Its working!
Everything is working great now! Thank you so much for the quick fix, this is the best!
Before I was using a hacky technique to pass the executable through a shell script to the container, but this is much better.


Highlight color with leap.nvim in VS Code

It is not strictly an issue, just ask for help. If I use the excellent leap.nvim plugin the highlights are in bright green what makes them difficult to read, especially if font is light blue:

In nvim the highlights are red and there is no problem with readability. Do you know if there is a way to adjust the highlight color for this plugin in VSCode?
I'm sorry if this question has been answered already but I wasn't able to find the answer myself.

This should have been fixed by https://github.com/vscode-neovim/vscode-neovim/pull/982.
Are you on the latest version of VSCode?
If so, maybe you just need to specify the LeapMatch fg. Look at the leap documentation for specifying the match highlight group.
On my machine, I have the text fg to be black (as leap default), and it works properly in vscode.


Build fails, analyzer issues

Trying to build from source on OS 10.11.6, make is failing with the following output:
git clean -f -x -d
./make-package.sh
make build
......................................................................
.................................** BUILD FAILED **

The following commands produced analyzer issues:
	AnalyzeShallow libkrbn_configuration_monitor.cpp
	AnalyzeShallow libkrbn_device_monitor.cpp
	AnalyzeShallow libkrbn_system_preferences_monitor.cpp
(3 commands with analyzer issues)

The following build commands failed:
	AnalyzeShallow libkrbn_system_preferences_monitor.cpp
(1 failure)
make[4]: *** [all] Error 65
make[3]: *** [all] Error 2
make[2]: *** [all] Error 2
make[1]: *** [build] Error 2

make: *** [all] Error 99

I'm still seeing the error after rolling back to other versions.

Confirm the requirements. I guess you did not install boost.
https://github.com/tekezo/Karabiner-Elements#how-to-build

Thanks. I should have seen that. Still getting some errors and warnings in the make cmd (a few code object is not signed at all and a few The following commands produced analyzer issues: AnalyzeShallow main.cpp, but it does produce a functioning DMG and the installed program has been working as expected so far.


Remove indirection through ShiftedRead

[ch2089]
Removes the LP.Read => Transpose(Read) => LeftShift(Reduce(ShiftedRead)) => QS.ShiftedRead indirection in favor of LP.Read => QS.Read.
QS.Read now has "shifted read" semantics.

Awwww, I thought the "misdirection" false cognate was intentional! It was a pretty dope pun and rightly cast shade on a dubious design.

Yeah I second guessed myself... could have kept it that way I guess :)


Providing translational velocity data to cartographer

Hello,
I have a general question about integrating estimates of an agent's motion into cartographer.
Setup
We are interested in running cartographer on a simple simulated 2D-LiDAR data set stemming from this paper, in order to consider its performance as a baseline. The agent's movement in the paper is entirely in 2D, with no tilting of the laser plane. Since the simulated LiDARs are sparse (20 laser rays radially spread around the agent), some odometry estimates need to be fused in. The data is provided to cartographer by custom ROS publishers with a simulated clock (so far using the sensor_msgs/LaserScan topic).
The issue
The problem is that, besides the laser scans, the simulated data set only comes with direct estimates of the agent's angular velocity and xy-offsets (i.e. movement velocity) in every time step, and no acceleration data. Following the documentation of cartographer_ros:

the sensor_msgs/Imu topic can provide angular velocity and translational acceleration
from the nav_msgs/Odometry topic only the absolute pose data is utilized (based on https://github.com/googlecartographer/cartographer_ros/issues/960).

What would be the best way to incorporate the available xy-velocity into cartographer, given that I have no access to acceleration readings? Integrating the xy-velocity out of band to obtain absolute pose estimate is obviously a bad idea. And also, is it O.K. to only use the angular velocity component of sensor_msgs/Imu and skip the acceleration part of the Imu messages?

Closing for inactivity, we can't invest time to help you with your setup anymore unfortunately.


Surface error message for incorrect passwords

Sometimes we will throw WARNING: No queries to run rather than a connection error for incorrect or missing password. SQL-runner should return clearer error messages for each error case.

The cause was because of the missing error handling from fillTemplates and could be reproduced by any value in playbook that may trigger that error, e.g. :password: {{notSupportedSecretFunc "X"}}. It was being mostly surfaced for passwords, as this is where template functions are usually used.
Was fixed in v0.10.0 as part of https://github.com/snowplow/sql-runner/commit/6cf2e12ef7a5cc06b5af747c96cb29f0e682fba3
Closing.


Update to 1.20 and go-github

Issue #, if available:
Description of changes:

Updated Go to 1.20
Updated go-github to newer version where the bumped dependency version of the usual CVE suspects (aka x/net, x/oauth2, and x/sys)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


First base version of snapcraft.yaml. Work in progress. [DO NOT MERGE]

I'm following the instructions from https://www.tensorflow.org/install/install_sources
I'm using this as a tutorial. https://snapcraft.io/docs/build-snaps/python

https://github.com/av8ramit/tensorflow-snap


Extensions and ideas

ANIMEPAHE , ANIMERUSH ,ANIMELIST.IR  extensions ,pause and continue button for downloading animes😭please and resolution options if possible, feature to migrate sources at once for Anime, ability to import ANILIST anime and manga library to the Aniyomi app,thanks a lot you guys are really making like easier and better for us,will more ideas if they come up

and also, please do add filters when browsing for anime :-D


Have a better way to handle global CSS

Describe the problem
People usually (if not always) import global CSS inside __layout.svelte, but that doesn't make sense because global CSS is usually page/app related things, like CSS resets, custom properties / variables, etc. I think of it like this:
<html>
  <body>
    <Layout>
      <main>

Why are we setting CSS for <html> and <body> inside <Layout>?
Also, if you have __error.svelte, you need to import the global CSS file there too! And now with the new Named Layouts feature is also worse because if you have 10 different layouts that share the same CSS resets... you have to import it 10 times. Even if the output CSS is not duplicated and file is only imported once... it doesn't make sense as Layouts shouldn't be responsible for this!
A layout is a visual representation of a page, it shouldn't be responsible for setting variables or resetting css among other things.
Describe the proposed solution
I think we need an entrypoint for global CSS that is outside of layouts, for example an option inside svelte.config.js like:
const config = {
  kit: {
    'globalCss or cssEntrypoint': 'src/lib/styles/index.css',
  }
}

Alternatives considered
I tried using prependData inside postcss with svelte-preprocess but that's worse because the variables get added over and over again.
Having <style> or <link> inside app.html doesn't let you process those files with postcss or any other preprocessor, so not really a solution.
Importance
would make my life easier
Additional Information
No response

Thanks, but the discussion on global styles (and scripts, for that matter) is happening on #3127.
For what it's worth, with named layouts you can have a root layout that all other layouts inherit from, so you'd only need to add it once (well, twice, pending #4582 for __error@layout).


Is there any movement left in this project?

Hi @vishrutshuklaMSFT
It has been a long time and it seems like people have problems getting this project to run in their environments - is there anything still going on? I really want to set this up on our tenant.
Any help or official response would be greatly appreciated!

Short answer: not with the open source version, contact Antares directly.
..I'll just close this here..


es.mtlnovel

es.mtlnovel
Does the host have more than 15 novels?
Yes.
Did you try manual grabbing?
No.
https://es.mtlnovel.com
I cannot download novels in Spanish or any other language except for English from MTL. Please help. I only get "Host not supported: es.mtlnovel.com"
PS: I use the Telegram bot.

Added all language variants of MTLNovel


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 87.75%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage     94.52%   94.52%
  Complexity      267      267
=========================================
  Files            25       25
  Lines           749      749
=========================================
  Hits            708      708
  Misses           41       41

Impacted Files
Coverage Δ
Complexity Δ

.../src/classes/Brave/Core/Api/App/InfoController.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

.../classes/Brave/Core/Entity/CharacterRepository.php
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...d/src/classes/Brave/Core/Entity/RoleRepository.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

backend/src/classes/Brave/Core/Entity/Group.php
100% <ø> (ø)
14 <0> (ø)
:arrow_down:

.../src/classes/Brave/Core/Entity/GroupRepository.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

.../classes/Brave/Slim/Role/SecureRouteMiddleware.php
100% <ø> (ø)
8 <0> (ø)
:arrow_down:

...end/src/classes/Brave/Slim/Session/SessionData.php
100% <ø> (ø)
16 <0> (ø)
:arrow_down:

...src/classes/Brave/Core/Entity/PlayerRepository.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...nd/src/classes/Brave/Core/Entity/AppRepository.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...src/classes/Brave/Core/Api/User/InfoController.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754b7a5...9809257. Read the comment docs.


[R-package] Added unit tests

On a flight this weekend, I spent some time learning the internals of covr and trying to figure out why covr::package_coverage() doesn't work on the LightGBM R package.
While I still haven't figured that out, I did figure out how to measure the unit test coverage of the R package with a modified version of covr::package_coverage(). See https://github.com/jameslamb/lightgbm-r-coverage.
Currently on master, the R package's test coverage is 56.37%. The tests in this PR takes it to 65.48%.
In this PR, I also propose formally skipping the broken test referenced in #2468 with testthat::skip(). I'm making some progress on that issue but in the interim we might as well have our CI work and not have to "just remember" that that one test has been broken for some time. This skip is necessary to compute test coverage.

ping @Laurae2 for a review

I just rebased this to latest master to catch up with changes over the last two weeks. It is ready for review.


Why to fragment projects? Why not to merge pdfminer.six into original pdfminer?

I mean that I see no reason to have pdfminer.six separate from pdfminer. I wonder why such a decision has been made?
https://github.com/euske/pdfminer/issues/210

Hi @KOLANICH. I am not really sure, but I think that the original pdfminer is largely unmaintained. Since the maintainer has not been active, there was no way for people to keep contributing to it. Thus, this fork is still a separate project.

Maintainer is active, he is alive and making commits ... into other repos. So he is alive, he is subscribed to all the activity so he sees our PR's and issues. So I guess it should not be a very big deal for him to merge this fork and to transfer ownership of the main repo to the org.

@KOLANICH I am well aware of the fact that the maintainer is "alive". Sure. We can raise an issue in the original pdfminer for the same.

We can raise an issue in the original pdfminer for the same.

I have already done that.

Hi there. originally I forked pdfminer because I needed it in a Python 3, and @euske didn't want to support Python 3 ( https://github.com/euske/pdfminer/issues/63 )
I nevertheless sent .six as a push request  https://github.com/euske/pdfminer/pull/71 which was declined.
So unless @euske changes his mind and becomes more active, I believe the way to continue is to merge his branch into this one.
If you want to help, you're welcome : we can add you to the group, give you credentials for PyPi. Just ask.
Once again I apologize for not being more active on this project : I did it just because I needed it for something specific, which is now done.

If you want to help, you're welcome : we can add you to the group, give you credentials for PyPi.

Thank you for suggestion, but no, I'm not going to maintain and develop it in long scale, so there is no need to give me, a stranger, credentials. But in near future there probably will be PRs from me.


New method for initialization

https://github.com/toyobayashi/emnapi/issues/15#issuecomment-1376673478

v0.25.0 released


Let's add prettier?

I was very interested in this project. Do you mind if I add .editorconfig and prettier here?

🙂
Hi again, Dmitry! Yeah, let's add it!
Got a question regarding this:
What is the best way to ensure prettier has been run before pushing to remote?
Maybe we should add some git hook to do that?

For automation I usually use husky and lint-staged, I can do something like this here.

I can't configure bots and GitHub Actions.

For automation I usually use husky and lint-staged, I can do something like this here.

I think we can start with husky/lint-staged to add prettifying on before commit, and later we'll investigate some CI (like GithubActions) checks.
Sounds ok?

Also, can we exclude .md files, so docs will be manually formatted?
I want to still have ability to fine-tune docs code examples

Also, can we exclude .md files, so docs will be manually formatted?

Sure.

I want to still have ability to fine-tune docs code examples

Do you want to exclude the examples folder?

I thought of maybe dropping/moving examples folder.
Please, exclude it for now too -- we'll figure out what to do with it later.
Thx!


Doc "feature" in-page navigation links take back to main page.

On this page https://polyfill.io/v2/docs/features/ the o-techdocs modules adds navigation links of the form href="#feature-list" for in-page navigation. Clicking on the link browses to the doc's main page.
The problem seems to be that a <base href="/"/> inserted in the page that makes these links point to https://polyfill.io/#feature-list instead of https://polyfill.io/v2/docs/features/#feature-list. I wasn't able to pin-point where this <base> element was coming from though.

This is now fixed, thanks for reporting the issue 👍


Use Clortho to securely save credentials for patch uploads

When a patch is uploaded, the user is prompted for the username and password each time before uploading to a ticket. This will save the credentials in the system store and only prompt for the username for each upload.
Alternatively, we could store the username in a config file and not prompt for it each time, but asking for it each time probably isn't that horrible.
See #37.

😍 Thanks @morganestes
What OS have you tested on this so far?

Just on macOS for now. I need to install a Windows VM to test it there, and
I can test Linux inside VVV.

https://www.npmjs.com/package/keytar seems like it might be a better choice since it's actively developed while Clortho seems to be somewhat forgoten.


[CONTROLLER/PROMETHEUS] supports multi orgs in cache

This PR is for:

Server

supports multi orgs in cache
Checklist

[ ] Added unit test.

Backport to branches

main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhengya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Import a large glb file (778MB) which contains 800 models will crash the editor.

Tested versions
4.2 stable
System information
macOS 14.5 - forward+ - godot 4.2 stable
Issue description
Import a large glb file (778MB) which contains 800 models will crash the editor.
Steps to reproduce

Create a new project.
Drag and drop the large glb file into editor.

Minimal reproduction project (MRP)
Here is the glb file
https://drive.google.com/file/d/1f74-29422AmZQJohng74ySdELGJptgSA/view?usp=sharing

Tried on latest from github (4 or 5 days ago). I hang on import. Restarting the editor restarts and re-hangs the import, automatically.
For some reason my Attach to Process is being disconnected and reattaching it doesnt show me the Call Stack. (Mind currently blown.)
Just pulled latest and recompiling.

I tried this on 4.3.beta2.official and although it was very slow, it did eventually load after about 6 minutes (during the whole time it appeared stuck at 0%).

Opening the scene took a couple more minutes:

This was on Ubuntu 24.04.

I tried this on 4.3.beta2.official and although it was very slow, it did eventually load after about 6 minutes (during the whole time it appeared stuck at 0%).
Opening the scene took a couple more minutes:  This was on Ubuntu 24.04. Edit: Godot uses about 9 GB of RAM with this scene open.

I created this file just for testing purpose, want to see how godot will handle it :P

After transferring the model to Godot 4.3 beta2, it still didn’t load for me, I waited 28 minutes, then closed it.
I also tested this on Blender 3.6.2, waited 3 minutes and Blender closed itself, which didn't happen with Godot.
Godot v4.3.beta2 - Windows 10.0.19045 - Vulkan (Mobile) - dedicated Radeon RX 560 Series (Advanced Micro Devices, Inc.; 31.0.14001.45012) - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 Threads)

Next steps is to get profiles for the load.
My recommendations is use either https://github.com/mstange/samply or https://superluminal.eu/

I will try to review any pull requests that can improve load times on the 777mb glb with nothing broken.

Oh... Nothing broken? Ah, nevermind then.
Really, yes my first challenge is proving that it is faster.
Thanks!

Ok, I didnt know github would add these comments from my own fork because I referenced the Issue in the description. I will be avoiding that in the future.

Since I ended up looking into this a little bit, I'll share my findings in hopes that it will help.
Measured by clicking "Reimport" on the scene in an otherwise empty project, --verbose says import took 276 seconds (that's a little under 5 minutes).
Note that the scene has ~800 meshes that add up to ~39.3M triangles (~50k each, looks reasonably uniformly distributed). Overall I would have expected one mesh per scene here, but I'm not familiar with how Godot workflows work, and it's a good stress test regardless.
perf profile on Linux / editor build with default settings with fno-omit-frame-pointers -- please note that timings add up to 45% (perf doesn't normalize them):

Renormalizing the percentages by dividing by 0.45, and focusing on significant underlying components, we get:

5% scene save
14% tangent space generation
25% normal reprojection after LOD generation (raycasts)
29% simplification (meshopt_simplify)
24% the rest of generate_lods (it's inlined here so hard to see from the profile exactly)

In aggregate, LOD generation takes ~78% here, so definitely good to focus on that. When looking at something like a 5-minute import though, my expectations are usually that small gains are not terribly exciting, so something more significant needs to happen.
A note on the scale here: each mesh gets approximately 6 LOD levels generated. The work for meshopt_simplify scales with that; the work for normal reprojection scales with the total number of rays, which scales with the total number of triangles in all LODs, times the area factor - looks like we cast 16..64 rays which is a lot of rays :)
If I were tackling this problem, I would entertain the following projects:

For scenes with many large meshes like this, my first goal would be to process meshes in parallel. I'm not familiar with the details of ImporterMesh code but superficially nothing should prevent fully generating each mesh in parallel. Maybe that requires refactoring some of this code to actually be thread-safe. It would also require making sure that the dependent code is thread-safe internally - meshopt definitely is, I assume so is Embree, but some care would be required. That alone would probably get this to be under a minute on an 8-core system if we discount tangent space generation.

I'm skeptical that tangent space generation is efficient here. For a sense of scale, meshopt_simplify does a fair bit more work per call, and it's called ~6 times per mesh here and still only takes twice as much time. I would assume tangent space generation has internal algorithmic inefficiencies and could be improved, but I haven't looked at that code myself.

I would not advise trying to optimize the internals of meshopt_simplify (trust me...). Some small future performance improvements are planned here in meshoptimizer but largely speaking unless this runs into some edge case, which it doesn't look like it does to me, it should be very well tuned already. Same for Embree - I would assume it's impractical to optimize that to the degree that is relevant here. However:

I would certainly think of, at the minimum, reducing the amount of requested work from both meshopt_simplify and Embree here. Notably, meshopt_simplify is called approximately 6 times per mesh here and is asked to generate larger and larger meshes. Because of this, it does more or less the same amount of work: simplifying the mesh 2x is almost the same effort as simplifying the mesh 10x (... well, not quite, but it gets there quickly). However, in LOD chain generations you can usually generate the LODs in the opposite direction: start by requesting a ~1.5x smaller mesh, if that target is reached, ask for ~1.5x smaller mesh again, etc. I don't recall why the order here is reversed but I would consider flipping it and simplifying from the last LOD. I don't think that's going to reduce the work here 6x, but I would expect something like 3-4x improvement in cost to call simplify.

In a similar vein, casting 16-64 rays per triangle is a lot, especially for higher levels of detail. I would probably reduce this in general or at least scale this as the LOD levels get closer to original mesh: in the limit, we're casting at least 16 rays per triangle here for something that only has 1.5x fewer triangles than original mesh, and that just feels wasteful. This has a risk of reducing the quality of the resulting normals because there's a higher chance of missing the mesh or hitting a wrong triangle. Maybe ray casts here aren't the right fit and averaging triangle normals from triangles that are in a bounding sphere of the generated triangle is better, but this brings me to my final point:

We've already discussed this at some point in another issue, but overall I'm not 100% sure the current normal processing in the importer for LODs is generally beneficial. With the normal aware simplifier with the recent fixes, generally speaking I'd expect decent normals to come out of the simplifier itself. Sometimes that's not the case, but I'm not sure the ray cast logic is perfect either, and it's just a lot of complexity to always keep in mind. I do think the reindexing that happens in this code is beneficial for some faceted meshes though. So a good use of time would be to perhaps introduce an option for normal reprojection that would disable the ray cast based normal recreation (I'd expect that alone cuts half of the overhead of LOD generation here), test the option in a release, then maybe default it to skip the normal recreation and see if this comes up.

Hopefully this is helpful :) I would be happy to discuss (3)/(5) further and/or maybe contribute a patch or two as I'm generally interested in making sure simplification integration is working well for Godot; I'll leave 1/2/4 to others if they are motivated to work on this.

On "I'm not 100% sure the current normal processing in the importer for LODs is generally beneficial", I decided to do a quick comparison on the scene from this file. It looks like it's easy to disable normal override, basically just need to disable the ray caster creation (as mentioned earlier, I believe current splitting logic to be generally beneficial for faceted meshes). I then look at a few low LODs (where the risk of picking a bad normal due to ray casts is maximized), by tuning the LOD bias to be a very small value.
On the left (yes, left, I double checked!) is the import without using the raycaster. On the right is current master (raycaster enabled). Both levels are at ~2200 triangles. I see somewhat similar issues on a few other models - this is not universal, this happened to be the first model I checked, and some models from this scene look about the same with or without the raycaster enabled. But this to me is strong evidence that raycaster should be optional, and probably opt-in.

I've switched to using a smaller version of the scene from the original post (that one has 800 meshes but each mesh is duplicated 8 times, I've switched to a deduplicated version where there's only 100 meshes, easier to work with and faster to reimport). Reimport takes 37 seconds on master and 22 seconds without raycaster enabled.

Wow, well that is surprising. Are there any examples where the raycaster was better in visual fidelity. (I understand that's somewhat subjective but your above screenshot feels fairly objective as to which is "better.")
I've been diving further into this section of code throughout the day today, attempting to rally myself before trying multithreading. I really appreciate your write-up. This is absolutely great to see!

As someone who works on this, I am supporting changes that improves quality and performance

After  trying to import this glb file on a s23 + mobile it ends up crashing after some time, so this does not look to be  the cow fault , using  https://github.com/godotengine/godot/pull/93064
as it the fastest when loading big project along with the other pr  which still causes it to crash on reimport.

@Saul2022 does it also crash on your pc?

@Saul2022 does it also crash on your pc?

Can't test on pc, sorry , it dead, only black screen despite the light thing is working, so prob screen issue.

I've tried this and this is the resulted Godot's memory crash dump:
godot.exe.14296.zip
My specs:

I suspect that developers loading that 3d asset require more than 16GB of ram.
We can check how big the difference is. If the requirements is closer to 32 gb then it's a lot harder than like 18gb.

What is the expected behaviour if we exceed the ram (like 19gb usage on a 16 gb - 14gb free) on the system?

We can attempt to use less memory, but there will always be a dataset that exceeds a limit.

Ye i guess, i tried with multithread import off, vsync dissable and continous update ,but still crash. Though the image files did import though, except the glb scene. Maybe to avoid crash instead of crashing the engine, make it so  before a crash happens, quit the import process and print an error message about not enough ram to import the scene.


MERC-1175 the fix for the dropdown bug using blueprint method

I found the solution in blueprint javascript
Is a jquery plugin that handles the hiding by creating a shadow hidden select element.
@bc-ranji @bc-ong @bc-julianleong

💚

@bc-ong

:+1: LGTM


Error mirroring git-init image in private registry. Unsupported MIME type for compression

Expected Behavior
git-init image can be mirrored from gcr.io to private registry.
Actual Behavior
Mirroring fails with error: unsupported MIME type for compression: application/vnd.docker.image.rootfs.diff.tar.gzip
Steps to Reproduce the Problem
skopeo copy docker://gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.37.2 docker://example.example.com/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.37.2

FATA[0001] Uploading manifest failed, attempted the following formats: application/vnd.oci.image.manifest.v1+json(writing manifest "{\"schemaVersion\":2,\"mediaType\":\"application/vnd.oci.image.manifest.v1+json\",\"config\":{\"mediaType\":\"application/vnd.oci.image.config.v1+json\",\"size\":1132,\"digest\":\"sha256:92846c512aba07f16a37baac3ac2650c4af38d6cc986010941568d174a4fb7a1\"},\"layers\":[{\"mediaType\":\"application/vnd.oci.image.layer.v1.tar+gzip\",\"size\":16196893,\"digest\":\"sha256:fa4f96b22123a850bc0727f32c52099e618ac215d9a06832562a41af6110c644\"},{\"mediaType\":\"application/vnd.docker.image.rootfs.diff.tar.gzip\",\"size\":8914910,\"digest\":\"sha256:1cd258f7c0bb909f632b3dd5faedf3e3f73191608364cc6c24c1a41519e2fa09\"},{\"mediaType\":\"application/vnd.docker.image.rootfs.diff.tar.gzip\",\"size\":15465791,\"digest\":\"sha256:199f56e7ac1acca896b89ead8ba89d60039b2cabf68b45c5c74c85571d999aaa\"}]}": uploading manifest v0.37.2 to quay.example.com/okd/catalog/tekton-releases/github.com/tektoncd/pipeline/cmd/susi/git-init: manifest invalid: manifest invalid), application/vnd.docker.distribution.manifest.v2+json(creating an updated image manifest: Unknown media type during manifest conversion: "application/vnd.docker.image.rootfs.diff.tar.gzip"), application/vnd.docker.distribution.manifest.v1+prettyjws(creating an updated image manifest: Unknown media type during manifest conversion: "application/vnd.docker.image.rootfs.diff.tar.gzip"), application/vnd.oci.image.index.v1+json(creating an updated image manifest: Unsupported conversion type: application/vnd.oci.image.index.v1+json), application/vnd.docker.distribution.manifest.list.v2+json(creating an updated image manifest: Unsupported conversion type: application/vnd.docker.distribution.manifest.list.v2+json), application/vnd.docker.distribution.manifest.v1+json(creating an updated image manifest: Unknown media type during manifest conversion: "application/vnd.docker.image.rootfs.diff.tar.gzip")

podman pull gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.37.2
podman tag  gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.37.2 registry.example.com/cm/git-init-tekton:v0.37.2
podman push registry.example.com/cm/git-init-tekton:v0.37.2

Error: creating an updated image manifest: preparing updated manifest, layer "sha256:aefddf89d81647c74d761e2b4f77827afb785280cde0886509a333442711ef4d": unsupported MIME type for compression: application/vnd.docker.image.rootfs.diff.tar.gzip

Additional Info

Mirroring worked fine with this image until Release v0.36.0. The error occurs since v0.37.0.
All other tekton release images are working.

Kubernetes version:
**Output of kubectl version:
not applicable

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'
not applicable

What registry implementation are you trying to mirror into? (Quay, Harbor, etc)
This might help narrow down the issue.
Recently we switched the git-init image to be based on distroless.dev/git, which is built with apko. This may be related. We've also switched our base image for everything else to distroless.dev/static so other images may also start exhibiting the same behavior when that's released.

Could you try mirroring our nightly release images to see if this will be a problem when those changes are in a full release?
Apko also switched to producing OCI-typed images by default since that git-init image was released, it's possible that this confluence of events fixes the issue in your registry, but it would be good to be sure.

I tried with quay and also gitlab registry.
Quay v3.7.3
Gitlab 15.1.2-ee
I also ran into an error, when i tried to extend this image in a buildah build.

Same error with gcr.io/tekton-nightly/github.com/tektoncd/pipeline/cmd/git-init:latest

Same problem here.... I think this is NOT a problem specific to an registry... it looks like apko is not producing oci conform images?
However... if you're not able to mirror tekton images in private registries this will be a show stopper for all operating tekton in an disconnected environment e.g. air gapped OpenShift.

For me it's a little bit like this Kaniko problem with mixed layers..... see Kaniko#1836.
When you inspect the actual tekton image you only see oci layers in teh json output... but in reality it might be a docker layer....

The fix for this is in https://github.com/google/ko/pull/776 -- I expect a ko release soon, that Tekton should start using shortly after, to produce consistently-typed image layers so this isn't an issue.
Sorry for the disruption, and thanks for reporting this!

This issue has persisted in Tekton v0.41.1 (gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/controller@sha256:02aef94088e2f5487b224c6a9d380cac7fa72e8fec883c9e2833569f302cb53c is the corresponding image sha), and presents itself when attempting to run skopeo copy --remove-signatures docker://gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/controller@sha256:02aef94088e2f5487b224c6a9d380cac7fa72e8fec883c9e2833569f302cb53c docker-archive:gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/controller:v0.40.1
This will result in the same error as posted above:
FATA[0013] creating an updated image manifest: Unknown media type during manifest conversion: "application/vnd.docker.image.rootfs.diff.tar.gzip"

Ah 😅 this didn't apply to 0.41.1 because I did not cherry-pick #5539 to the release branch (and thus.. it used ko 0.11 I guess).
I'll cherry-pick today and prepare a 0.41.2 tomorrow 😉


add: get unknown network name from env

Sometimes you may want to have dev/staging/prod contracts on same network
if you set NETWORK in env this allows for multiple deployment to same network ie:
export NETWORK='ropsten-staging'

Hi @sirpy! I think the intention here is interesting but I don't like the idea of using an environment variable for it...
I want to think about a better way to achieve the same goal. Do you use Buidler/Hardhat or Truffle?

truffle.
other options i can think off are:

passing down as variable
allowing to change networkNames object which is currently frozen. so a user could do setNetworkName(3,'ropsten-staging') so for current run chainid 3 would resolve to new network name.

Can you explain to me the precise reasons why you want to have separate network files for dev/staging/prod?
I don't see an issue in reusing implementation contracts, since they don't hold any state. There may be an issue with reusing the admin contract, but that can be solved in a different way by allowing you to have multiple admin contracts, as in https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/136.

Can you explain to me the precise reasons why you want to have separate network files for dev/staging/prod?
I don't see an issue in reusing implementation contracts, since they don't hold any state. There may be an issue with reusing the admin contract, but that can be solved in a different way by allowing you to have multiple admin contracts, as in #136.

i'm not familiar with the internals but i want a different admin + state for each env, if you can suggest a way to do that which  could be integrated with the truffle plugin i would be happy to learn.
currently the deployProxy/upgradeProxy command reads the info it needs from the network file and based on it decided what to do

@frangio any updates on this?

@sirpy Sorry, I don't think using an environment variable for this purpose is a good idea, and I don't think the alternatives are good either. This is more of a fundamental issue of how we're thinking of network state, and although I will definitely keep the use case you describe in mind going forward, I don't want to rush to providing a solution for it.
I'd encourage you to check out #136 and see if having multiple admins in the same network data file would be useful to you. However, given that you said you wanted different state for each evironment, it might not be sufficient.
I can also suggest a couple of workarounds for you to use:

use different directories for each environment (.openzepelin is stored and read in the process working directory),
use different git branches.

@frangio why is allowing the user to set the network name is not a good solution? (setNetworkName(3,'ropsten-staging'))
this also allows custom support for all those sidechains like XDAI, POA, FUSE which are currently simply "unknown"
ie setNetworkName(122,'fuse')

It's a different use case. We should add those networks as known in
https://github.com/OpenZeppelin/openzeppelin-upgrades/blob/0761c2224464e36795e8e96da232f5e85904d6a6/packages/core/src/provider.ts#L52-L59

@frangio it makes no sense to make it hard coded.

We could also use a shared list like chainid.network. I've created an issue for this at https://github.com/OpenZeppelin/openzeppelin-upgrades/issues/229.

@frangio it still makes no sense
who exactly updates this chainid.network? it is no different then making PR. i already see it doesnt have a network i know.
networks are popping like mushrooms after the rain.
allowing the developer to set the network names makes it compatible with whatever, plus solves the issue for having multiple envs for same network
what is your objection for letting the developer set the network name? it is a trivial config and you can still have your sane defaults

@sirpy I appreciate the feedback but I will ask you to avoid comments such as "it makes no sense".
I rejected this PR as a way to use the same network in different environments. You're now discussing the separate issue of configuring names for "uknown" networks. They shouldn't necessarily be tackled in the same way, but I can see how solving the second issue may provide a solution for the first.
Using an environment variable will be a last resort. The project considers this is not the right tool for the job. The solution has to be either explicit in the use of the plugin API or integrated with the tooling (Truffle and Hardhat).
We could potentially use the network name as defined in the Truffle/Hardhat config. Hardhat already allows this, the network name is present in the environment network object. In Truffle I couldn't find it, but we can ask them to add it. What do you think of this idea?

that was always the purpose how to handle unknown networks. see title.
in any case to set network from truffle you would probably have some helper function, I simply suggest to expose it to developers as first step and meanwhile ask truffle to Also add access to it

@frangio can you reply to my last comment?

I'm sorry, this is not a priority for us at the moment. I encourage you to use the workarounds I described above:

I can also suggest a couple of workarounds for you to use:

use different directories for each environment (.openzepelin is stored and read in the process working directory),
use different git branches.

I'm sorry, this is not a priority for us at the moment. I encourage you to use the workarounds I described above:

I can also suggest a couple of workarounds for you to use:

use different directories for each environment (.openzepelin is stored and read in the process working directory),
use different git branches.


Support hostnames for streams

Currently, there seems to be a restriction that you can't input any hostname when creating or editing a stream. It would be very useful, at least for me, if I could input any domain or hostname there.

This should be possible per: http://nginx.org/en/docs/stream/ngx_stream_ssl_preread_module.html


No example provided for fractionOf aggregator

Hi, I am trying to use the fractionOf aggregator for cols (or rows) in a pivot table. I need to do this without pivotUI and just use the pivot version. From the documentation, I have found how I can programmatically build a simple sum aggregator like I have done in the fiddle/code snippet below. Can you please advise me how I can modify this to work with the fractionOf with the required arguments? I tried looking at the source and got lost because it looks pretty complex ;)
var sum = $.pivotUtilities.aggregatorTemplates.sum;
var numberFormat = $.pivotUtilities.numberFormat;
var floatFormat = numberFormat({digitsAfterDecimal: 2});
var sumAggregator = sum(floatFormat)(['tip'])

$("#output").pivot(
  $.pivotUtilities.tipsData, {
    rows: ["sex", "smoker"],
    cols: ["day", "time"],
    vals: ["tip", "total_bill"],
    aggregator: sumAggregator
  });

Relevant fiddle

Here are some examples of where this is used: https://github.com/nicolaskruchten/pivottable/blob/master/pivot.coffee#L145

I tried adding in a template in that matter and it didn't quite work. I'm getting a TypeError: this.allTotal.push is not a function
var sum = $.pivotUtilities.aggregatorTemplates.sum;
var numberFormat = $.pivotUtilities.numberFormat;
var usFmtPct = numberFormat({ digitsAfterDecimal:1, scaler: 100, suffix: "%" })
var fractionOf = $.pivotUtilities.aggregatorTemplates.fractionOf(sum(), 'row', usFmtPct)

$("#output").pivot(
  $.pivotUtilities.tipsData, {
    rows: ["sex", "smoker"],
    cols: ["day", "time"],
    vals: ["tip", "total_bill"],
    aggregator: fractionOf
  });

Fiddle

OK so the issue is that you're mixing up the call semantics of pivot() and pivotUI()... The vals parameter is used by pivotUI() but not pivot().
The following will work (note that I removed vals and called the aggregator with a field to compute over):
var sum = $.pivotUtilities.aggregatorTemplates.sum;
var numberFormat = $.pivotUtilities.numberFormat;
var usFmtPct = numberFormat({ digitsAfterDecimal:1, scaler: 100, suffix: "%" })
var fractionOfRowSum = $.pivotUtilities.aggregatorTemplates.fractionOf(sum(), 'row', usFmtPct)

$("#output").pivot(
  $.pivotUtilities.tipsData, {
    rows: ["sex", "smoker"],
    cols: ["day", "time"],
    aggregator: fractionOfRowSum(["tip"])
  });

Fantastic! Thank you.
Also, thank you very much for this excellent library. I have been using it on a few different projects now.

You're welcome, and I'm glad you like it!

On Jun 22, 2016, at 09:16, Zach Cowell<EMAIL_ADDRESS>wrote:
Fantastic! Thank you.
Also, thank you very much for this excellent library. I have been using it on a few different projects now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Control Flow

A section on the Cairo control flow: if statements, loops(still alpha, might be for another issue)
This section doesn't include match statements, which are specific to Cairo (and Rust)
Estimated time: 1 hour

Doing this


Better TypeScript support

Do you want to consider using TypeScript to refactor code to get better TypeScript syntax support? And updated to koa3.

This project has no type definitions. The author hates types and you always should checkout the source code of the method your using.

import type { FastifyInstance } from 'fastify';
import type { TypeBoxTypeProvider } from '@fastify/type-provider-typebox';
import { Type } from '@sinclair/typebox';

export default async (app: FastifyInstance) => {
  const router = app.withTypeProvider<TypeBoxTypeProvider>();

  router.get(
    '/hello-world',
    {
      schema: {
        response: {
          200: Type.Object({
            message: Type.String(),
          }),
        },
      },
    },
    async (req, reply) => {
      return reply.send({
        message: 'Hello, World!',
      });
    },
  );
};

how to resolve it

I was against typescript before, but nowadays everything is typescript, so 👍 for a typescript rewrite. unfortunately, I haven't coded in typescript since I haven't been coding much for years, so will need help!


(chore) Up Ergo 0.0.61

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>

Coverage remained the same at 94.65% when pulling 3e5800fbb6d36718b09e5e8698e5049410d8c173 on jeromesimeon:js-chore-ergo-0.0.61 into 37f5d331d1c03a70558d2f8b34dfcf82d60dd33d on accordproject:master.


Defining ConfigurationBuilder to index classes in test root

Using reflections library, I wrote a simple utility class that indexes all test methods together with their annotations. Reflections library helps me like that:
Set testMethods = reflections.getMethodsAnnotatedWith(Test.class);
If my utility class is located in test root (src/test/java), it finds all test methods as expected.
However, if it is located in sources root (src/test/java), then it find no test methods.
How should I define ConfigurationBuilder for Reflections so that it works for the latter case?

I found a solution. When creating ConfigurationBuilder it is important to define:
register additional classloader that will be aware of test classes location
register test class location

Here's an example implementation:
URL testClassesURL = Paths.get("target/test-classes").toUri().toURL();
URLClassLoader classLoader = URLClassLoader.newInstance(new URL[]{testClassesURL},
ClasspathHelper.staticClassLoader());
Reflections reflections = new Reflections(new ConfigurationBuilder()
.addUrls(ClasspathHelper.forPackage(packageToIndex, classLoader))
.addClassLoader(classLoader)
.filterInputsBy(new FilterBuilder().includePackage(packageToIndex))
.setScanners(
new SubTypesScanner(false),
new TypeAnnotationsScanner(),
new MethodAnnotationsScanner()));


profile and logging improvements

Some improvements for efficiency and useability:

removal of the profile json
add log_timer decorator
Add log messages

Explored persistence options for ydata-profiling.ProfileReport.  Trouble recreating the ProfileReport from json.  Also cannot (simply) persist the pickle dump to omf.
For the record, relative sizes of a test report.
HTML size:<PHONE_NUMBER>875 KB
JSON size: 205.34375 KB
Pickle size:<PHONE_NUMBER>875 KB
So, will store (only) the html at this stage.


[Bug]: vite plugin seems to be missing files in 0.2.0 release

Is there an existing issue for this?
I have searched the existing issues
Current Behavior
Try to use the plugin and it says the lib folder is missing. Checking the contents of the downloaded package and I can confirm that folder is not present. It looks like the files array in package.json doesn't list it either.

Expected Behavior
The files are present.
Steps To Reproduce
yarn add -D @yaml-js/vite and inspect the contents
Environment
No response
Anything else?
No response

I experienced the same bug. Switched to unplugin-yaml which works just fine.


Collect Provenance Data

Collect info that can be used to support reproducibility & data provenance.
Including:

Pipeline Run Start Timestamp
SGE Job IDs
Pipeline Version (With Link to GitHub Release or Tag)
Paths & Hashes for Reference Databases
Versions for tools (mash, shovill, abricate, etc.)

SGE Job IDs will be captured using the drmaa library described in #29.

Refer to cwlprov project for ideas on how to store this info:
https://github.com/common-workflow-language/cwlprov


PyTorch Geometric Temporal Integration

We integrated the model in PyTorch Geometric Temporal.
https://github.com/benedekrozemberczki/pytorch_geometric_temporal

Thanks, your work is fantastic~~


add httpbin virtualservice http rules

Signed-off-by: zackzhang<EMAIL_ADDRESS>[X] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Hi @zackzhangkai. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Error "2:Invalid Indexed type" Try Again?

🐞 bug report
Push "ctrl+d", autosearch 0,5 sec and  get this error
🌍  Your Environment

OS: Win10 x64
Version: 0.8.3-0.8.3 setup
PoE: Steam 3.15.0d Ru

It works if you change the "searching time period" from 'Any Time' to any other.

It works if you change the "searching time period" from 'Any Time' to any other.

Ok. thanks. it's really work)


New version: Grisu v1.0.2

Registering package: Grisu
Repository: https://github.com/JuliaAttic/Grisu.jl
Created by: @KristofferC
Version: v1.0.2
Commit: 5e7d3312af1893cd8a2837b26878d68226b9a2d2
Reviewed by: @KristofferC
Reference: https://github.com/JuliaAttic/Grisu.jl/commit/5e7d3312af1893cd8a2837b26878d68226b9a2d2#commitcomment-50164543

Merging quickly because it fixes a bug in important plotting packages.


Issue with 4.0.0 version

I am seeing that inputmask for numeric field and date has an issue of focus and tabout in IE 11. IE is not responding after entering the field value.But same Seems to be working fine in chrome and Mozilla.
We upgraded to 4.0.1.beta 39 but everything seems to be working fine there.
Please let me know when we will having the release version of this instead of beta.Please clarify

@sundaralingam48 ,
There is now the 4.0.2 release.


Desktop Orientation on AYANEO Geek

On the low-end SKU (512GB - 800p Display) of the AYANEO Geek, the desktop mode cannot be rotated. Have tried all orientations/available resolutions.

For a kernel quirk, this is somewhat more challenging as both the 800p and 1200p have the same DMI data.

I see, the weird thing is not even resolutions change

Closed by accident

For a kernel quirk, this is somewhat more challenging as both the 800p and 1200p have the same DMI data.
The resolution is all I need to pull to apply rotation quirks.

It's 1200x800p

I can confirm the issue

For a kernel quirk, this is somewhat more challenging as both the 800p and 1200p have the same DMI data.

The resolution is all I need to pull to apply rotation quirks.

Apply, sure, but we still need to identify pretty device. The geek has two models, one with an 800p screen and one with the same 1200p screen as the 2.


fix: Adapt Postman collection for 0.3.x

WHAT
Adapt Postman collection for version 0.3.x
WHY
The Postman collection was not compatible with the current version 0.3.x
FURTHER NOTES
Also the Control Plane Adapter request call is added to the collection.
Closes #228

If I understood correctly, this collection contains EDC's Management API plus the control plane adapter's API. However, it's missing our custom Observability API.
Unifying these things is easy and can be automated, assuming you have EDC checked out in EDC_DIRECTORY:
# 1. Re-Generate the collective EDC Management API into the TractusX repo
cd <EDC_DIRECTORY>
./gradlew mergeApiSpec --input=resources/openapi/yaml/management-api --output=<TRACTUSX_DIRECTORY>/resources/openapi/yaml/management-api.yaml

# 2. Merge Management API, ControlPlane Adapter API and Observability API
cd <TRACTUSX_DIRECTORY>
./gradlew resolve
./gradlew mergeApiSpec --input=resources/openapi/yaml/ --output=resources/openapi/yaml/txedc-api.yaml

Then, in Postman, it is quite easy to import txedc-api.yaml into a collection:  After some manual polishing, that collection can be exported using postman.

As I described in issue, the aim of this is to provide the users a simple collection where they can easily use it to exchange data between two connectors (provider and consumer) with all necessary calls they need. It also provides some variables which are used between several calls and some are initialized automatically after a call.
It is not about just providing the calls that you would also have by importing the API specification into Postman. I have been contacted multiple times about using/providing such a collection but if we don't want to provide such a collection, of course it can be removed completely since everybody should be able to import the whole api spec into Postman and use the calls that they need.

that's fine, but I'm assuming users would want the following:

the Management API
the Observability API

which is exactly what the above code snip will produce by merging them into one collection. now, the collection generated by Postman may not be perfect, e.g. it might not yet have tests to store the variables, but IMO that trade-off is worth the benefit of having always-up-to-date collections, that are not error-prone.
In the future we could even automate this in our CI workflows, e.g. using this app.

if @stephanbcbauer agrees we can merge it as-is


feat: add config based annotation converter

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Also be sure to change the file name from convert_document_from_azure_sample.py to convert_external_annotations_sample.py (Same for the tests)


Documentation edits

Minor language edits based on documentation review.

@JennaPaikowsky I am going to merge this without rerunning the examples. The reason being that the changes to the examples are quite small and it turns out that I need to make a new release in the next couple of days so I am going to have to re-run the examples then in any case. It will mean that the examples will be out of sync with your changes for a couple of days.


[ENH] Process text

PR Description
Please describe the changes proposed in the pull request:

Modifies only existing column
Deprecate new_column_names and merge_frame
keeping it simple (and easier to maintain)

This PR improves process_text.

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.rst.

[x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks
There will be automatic checks run on the PR. These include:

Building a preview of the docs on Netlify
Automatically linting the code
Making sure the code is documented
Making sure that all tests are passed
Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

I think I know what's going on with the code coverage - when dev has more lines of code than PR branch, it'll detect a decrease in the code coverage. Probably continually merging dev into the PR branch will fix that problem.

@nvamsikrishna05 @loganthomas @ericmjl can I bother you a tiny bit to have a look at this PR. thanks

@nvamsikrishna05, my apologies; can i bother u with this PR? A second look and possible merge if all is good


add validation on update status as created to return also as updating…

…, given process started
Description
add status validation to updating
FIXES:
Type of change
What is it?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

lgtm\

Codecov Report
Base: 53.91% // Head: 53.88% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (498cb89) compared to base (0219f75).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
- Coverage   53.91%   53.88%   -0.04%
==========================================
  Files          70       70
  Lines        9932     9932
==========================================
- Hits         5355     5352       -3
- Misses       4104     4106       +2
- Partials      473      474       +1

Impacted Files
Coverage Δ

pkg/services/devices.go
50.79% <100.00%> (-0.32%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


LINKTA-44 Implement PromptInputPage

Description

delete PromptInputField component
rename PromptInputBox to PromptInputForm
update PromptInputForm code to match new name
move PromptInputForm to common components directory
import PromptInputForm to PromptInputPage
update PromptInputPage placeholder element

Type of change

[ ]  🐛 Bug fix (non-breaking change which fixes an issue)
[x] ✨  New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📝 Documentation update
[ ] Other 🗒 ______________

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist:

[x] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[x] I have reviewed the Security Best Practices Document.
[x] I have followed the Naming Conventions Guide for my changes.
[x] I have ensured that my pull request title is descriptive.

Additional Information:

Looks good, I'm assuming we are not creating a separate component for the input instruction for now?

Looks good, I'm assuming we are not creating a separate component for the input instruction for now?

We still have the PromptInputInstructions component - I should have included its placeholder in PromptInputForm. It will be included in the next PR for 'LINKTA-128 Implement PromptInputForm'


TS-4309: Fix missing event setting that was causing a spin if a end o…

…f SSL stream occurred due to ERR_SYSCALL.  Also fixes clang
warning described in TS-4492.

Ship it.

Yeah, been running on the docs site for a while, no issues. I also ran it on the Github Jenkins and passes all tests.
https://ci.trafficserver.apache.org/job/Github-Linux/46/


ja: Translate /docs/concepts/configuration/organize-cluster-access-kubeconfig/ into Japanese

This is a Feature Request
What would you like to be added
Translate /docs/concepts/configuration/organize-cluster-access-kubeconfig/ into Japanese.
Why is this needed
This page has not been translated.
Comments
/language ja
/assign

/triage accepted


ES5 or ES6 Module Import

Can Slider Pro be imported as an ES5 or ES6 module? Could not find any working code examples. So starting to think I need some template like https://gist.github.com/publicJorn/668d381287632b1fbaed2d5288340b25 to allow importing in Vue components with ease.

Hmm
import $ from 'jquery';
import '../../../../../node_modules/slider-pro/dist/js/jquery.sliderPro.min.js';

may work
or
import<EMAIL_ADDRESS>

with
"@nodemodules/*": [
"node_modules/*"
]

at jsconfig.json


ci: Add secrets baseline file

PR summary

This PR adds a .secret.baseline file for detect-secrets git pre-hook.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the
Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

No secrets detect is used.
What is the new behavior?

Add secrets.baseline file that excludes:

stubs/+.json files
package-lock.json

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thank you for reviewing! I am about to merge this.


Scale the damage

It would be awesome if you deal more damage when you're big vs. normal - small - tiny, or damage less when you're tiny vs. small - normal - big .  🤔

Yeah, but for being big thats too OP, and for small its like disabling damage at all.
And also minimum point of health is half-heart (maybe in the game its counted in floating point numbers, need to check) so what you deal when you're 1/16? zero?
Possibly I'll do a config similar to fall damage.

Yes i see, that's op.  I thought of this: When you're calibrating yourself from 1/2 - 1/32,  you deal half a heart less by each stage? 🤔

Isn't this place for reporting issues...?

I was told that you can use it for future updates or discussions too

Isn't this place for reporting issues...?

Feature requests are issues too and I am totally ok with that.
They are even great for being a todo list, I've seen people open issues on their own repos.

Closed by e68acb5