Introduce and use INT_TRIM/trim_to_int.

The macro typically used to constrain a long to fit into an int.
Initially used to trim int options sizes, and defensively in shift_line().
@chrisbra If sw remains constrained to an int, then the use of INT_TRIM at the entry in shift_line() is not required. LMK if you want that change.

I was looking at gcc docs. I guess INT_TRIM could be made a function, and with sufficient optimization, then function inlining automagically happens. So instead of the macro, could put int trimToInt(long long) somewhere. (In ops.c?). Then the entry to shift_line() could avoid the temp variable and simply have
    int		sw_val = trimToInt(get_sw_value_indent(curbuf));

Thinking about it, if get_sw_* functions are contrained to int, then why are they declared to return long; probably best to be defensive and assume long until/unless their declaration changes. So still want trim.

Thinking about it, if get_sw_* functions are contrained to int, then why are they declared to return long; probably best to be defensive and assume long until/unless their declaration changes. So still want trim.

Yes agree.
Coverity also detected another issue in parse_cino:
*** CID 1554344:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
/src/cindent.c: 1905 in parse_cino()
1899                if (p == digits)
1900                    n = sw; // just "s" is one 'shiftwidth'
1901                else
1902                {
1903                    n *= sw;
1904                    if (divider)
>>>     CID 1554344:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "sw * fraction" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "long long" (64 bits, signed).
1905                        n += (sw * fraction + divider / 2) / divider;
1906                }
1907                ++p;
1908            }
1909            if (l[1] == '-')
1910                n = -n;

So a bit more to fix :(

So a bit more to fix :(

Handled (I think).
This PR needs some "final" cleanup. (waiting for comment on macro vs function vs inline) Preference?

I don't really have a preference. In general I am with Bram on the inlining but I don't really mind

Ready for "final" review.

thanks looks good. Appreciate it 🙏


Added 46 uniqe / set items to pickit

Added some unique and set items to the pickit.
All items have been tested with the Graphic Debugger.

Everything looks fine to me other than adding 46 useless items to cram up more of the pickit.

Thanks @mischavandenburg . Will you set all the added items to =0 in the pickit config for the default? Otherwise looks good.

Thanks, @mgleed ! I committed and pushed again, all items should be set to 0 now.

Great, this was my first pull request ever, and my first ever contribution to open source! Thank you for reviewing and merging, @mgleed


convert Todo items in README.md to github issues

There's a bunch of Todo items in the README.md, let's convert them to github issues so they can be managed.

Done!


add tests for small subject pages

e.g. politk or in other languages
check for secondary menu

check for taxnomies as secondary entries (shortcuircut path)


Add an extensive Unit/Integration Test for InlineInsert that targets a table name.

Added to the master.


[SR-11421] Checked Cast Diagnostics Should Be More Specific When Literals Are Involved

Previous ID
SR-11421

Radar
None

Original Reporter
@CodaFi

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug, DiagnosticsQoI, StarterBug

Assignee
mohit.athwani (JIRA)

Priority
Medium

md5: 54d2d8b997d41666f9024642eb576483

cloned to:

SR-12093 Checked Casts With Literals Are Deeply Unintuitive

Issue Description:
Checked casts on literals can have surprising effects at face value
let character = "A" as Character
let bad = "A" as? Character

The former is a character literal and is statically coerced. The latter is a String literal that is being dynamically cast to a Character. This cast will always fail, and we note as much - this also works with as! force casts.
warning: cast from 'String' to unrelated type 'Character' always fails

We could definitely do a better job phrasing this warning to let the user know what went wrong and can even offer a fixit that changes the dynamic cast to a static cast if it's going to succeed.

@CodaFi Let me try this!

Hey @CodaFi I have run the exact same code, I have got this output:
warning: conditional downcast from literal to 'Character' always fails; consider using 'as' coercion
let bad = "A" as? Character
              ^

What exact type of phrasing are you looking for, because the above seems very clear and is also giving a suggestion to use the as statically coerced cast, instead of as?.

@Rajveer100 This is definitely an improvement, but I think we can take another step forward and mention the inferred type of the literal as well. I can imagine people wondering why their supposed Character literal does not want to downcast to a Character. It is not immediately clear that the destination type of a dynamic cast does not participate in the inference of the left-hand side.

Yeah I understand that, could you exactly specify to what it could be potentially changed to, what would be your suggestion?

Do you have any ideas in mind? Of course, I could just throw in a suggestion without asking you first, but to me that defeats the purpose of a good first issue.

So overall, the fix is to change the diagnosed message to a more better phrasing and provide a fix it to it if the casting is possible. While I am solving another issue, I will get back to this.

@AnthonyLatsis Back into this issue!
I guess we were discussing about the suggestions?

Hey Rajveer, got any ideas on how to improve the message yet? Suppose you compile "A" as? Character, and the compiler reacts with conditional downcast from literal to 'Character' always fails. But why does the cast fail?

as?,  as!, and is are variants of the same runtime operation.  In fact, you can define as! and is in terms of as?:

x as! T is defined to be (x as? T)!
x is T is defined to be (x as? T) != nil

as? supports a variety of casting and conversion operations, including bridging conversions (which are not really "casting" in the traditional OO sense) as well as both up and down casting.

as is special because it is not necessarily a run-time operation. It can act as both a known-to-succeed bridging conversion and a type inference hint or coercion, as in 0 as Double.

Okay, so the reason the cast fails is that String and Character are unrelated types. The problem is, the error message says nothing about String (the inferred type the literal), it only says that the literal cannot be cast to X.

Okay, so the reason the cast fails is that String and Character are unrelated types. The problem is, the error message says nothing about String (the inferred type of the literal), it only says that the literal cannot be cast to Character.

In which perspective are they 'unrelated', since a string essentially is a stream / buffer of characters, i.e., String.Element.

They are "unrelated" in the type system, not logically. "Unrelated" in this sense means that neither is a descendent (subtype) of the other. With the exception of bridging conversions and presumably some other edge cases, Swift’s type safety implies that a type cast/coercion fails if the types are "unrelated".

That makes sense.

So we can probably update the diagnostic warning to, warning: {literal_in_context} literal and %0 are 'unrelated' to each other, consider using 'as' coercion, which in our case would be, warning: 'String' literal and 'Character' are 'unrelated' to each other, consider using 'as' coercion.

I suggest we align the second half with the wording we already have in downcast_to_unrelated: ... to unrelated type <to_type> always fails rather than the current ... to <to_type> always fails. from <from_type> literal sounds good, but I think we can still do better by mentioning that the literal was inferred to that type (and only then cast), to add some contrast between casting and coercing (the fix-it), e.g. from literal of inferred type <from_type>.

Right...


[chore] Update Env Schema

Description

Removes the organization selector from schema
Updates .gitignore with .DS_Store

This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Closing this as its not required anymore based on recent discussion.


New environment support contact link is incorrect

Incorrect links to support.aptible.com/contact

Good find


Installation problem on main branch

If you clone the main branch and try to install, you will likely hit this error.
14.30  × Preparing metadata (pyproject.toml) did not run successfully.
14.30  │ exit code: 1
14.30  ╰─> [33 lines of output]
14.30    Traceback (most recent call last):
14.30     File "/opt/conda/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
14.30      main()
14.30     File "/opt/conda/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
14.30      json_out['return_val'] = hook(**hook_input['kwargs'])
14.30     File "/opt/conda/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
14.30      whl_basename = backend.build_wheel(metadata_directory, config_settings)
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/build.py", line 58, in build_wheel
14.30      return os.path.basename(next(builder.build(directory=wheel_directory, versions=['standard'])))
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/plugin/interface.py", line 155, in build
14.30      artifact = version_api[version](directory, **build_data)
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/wheel.py", line 412, in build_standard
14.30      for included_file in self.recurse_included_files():
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/plugin/interface.py", line 176, in recurse_included_files
14.30      yield from self.recurse_selected_project_files()
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/plugin/interface.py", line 180, in recurse_selected_project_files
14.30      if self.config.only_include:
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/config.py", line 781, in only_include
14.30      only_include = only_include_config.get('only-include', self.default_only_include()) or self.packages
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/wheel.py", line 231, in default_only_include
14.30      return self.default_file_selection_options.only_include
14.30     File "/opt/conda/lib/python3.10/functools.py", line 981, in __get__
14.30      val = self.func(instance)
14.30     File "/tmp/pip-build-env-yo0q6xyo/overlay/lib/python3.10/site-packages/hatchling/builders/wheel.py", line 219, in default_file_selection_options
14.30      raise ValueError(message)
14.30    ValueError: Unable to determine which files to ship inside the wheel using the following heuristics: https://hatch.pypa.io/latest/plugins/builder/wheel/#default-file-selection

It should be fixed once https://github.com/arcee-ai/DALM/pull/86 is merged.

Fixed in https://github.com/arcee-ai/DALM/pull/86


Add support for testcheck.

Adds support for property testing via Lee Byron's testcheck-js library. This cannot merge until this merges: https://github.com/leebyron/jasmine-check/pull/5
Please see the documentation for testcheck: https://github.com/leebyron/testcheck-js

OK, this is now ready to go.

@facebook-github-bot import

@facebook-github-bot import

Thanks for importing. If you are an FB employee go to Phabricator to review.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Create insertion_sort.c

Added insertion_sort.c
What type of PR is this? (check all applicable)

[ ] 🚀 Added Name
[ ] ✨ Feature
[ ] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

Great work


Screenshot or animated gif?

I just came across your library while trying to find a framework for implementing modals. However, I don't see a screenshot, animated gif, or video of what your library does. Can you please add a screenshot so that I can see if it will be something that I want to integrate?

Just google TDSemiModal, and there should be several screenshots. This blogpost is an example: http://www.alexcurylo.com/blog/2011/03/31/tdsemimodal/


Add support for dynamic segments in visitable urls

This allows you to do the following:
let userPage = PO.build({
  visit: PO.visitable('/users/:id')
});

userPage.visit({id: 5});

This is great! thanks for contribute.
I plan to update the addon to ember-cli 0.2.6 today and make a new release with this feature.


Fix detecting response content-type and parsing json

Close #24

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           9      9
  Lines         105    108    +3
  Branches       10     11    +1
=====================================
+ Hits          105    108    +3

Impacted Files
Coverage Δ

src/client/client.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27623ae...13889b9. Read the comment docs.


Support Media Session title in demo

With the brand new Media Session API, we can now customize media notifications by providing metadata for the media the web app is playing. It also allows us to handle media related events such as seeking or track changing which may come from notifications or media keys.
So here's a first stab to support the Media Session in the shaka demo.
WDYT?

@ismena I've addressed your feedback.

@beaufortfrancois Cool, let me run it through our test bot.

This is a new API and our compiler doesn't know about the types involved.  You will need to add an additional file to the externs folder.  Simply copy one of them and modify it to describe the new APIs (you don't need to include everything, just what you use).
You can also run build/all.py to check that it works locally.

I've added missing externs.js files in https://github.com/google/shaka-player/pull/689/commits/aa693a9792cca266b68053de81e6297d6144fa39 but it looks like tests are still failing for the play promise:
Checking the tests for type errors...

./externs/mediaelements.js:29: ERROR - variable HTMLMediaElement.prototype.play redefined, original definition at externs.zip//html5.js:1700
HTMLMediaElement.prototype.play = function() {};
^

1 error(s), 0 warning(s)
Build failed

I'd appreciate some help there.

@TheModMaker Done! Thanks ;)

Thanks for the PR and thanks for introducing this to us.  This will be helpful if we decide to add more UI elements to our demo app.

Yeah! Please let me know when it's live @TheModMaker!

It is already live on the nightly site: https://nightly-dot-shaka-player-demo.appspot.com/demo/.  It will appear in the normal demo once we release v2.1.


4.0.0-beta.16 breaks ion-tabs in Electron

Bug Report
ion-tabs fails when upgrading to 4.0.0-beta.16.
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
Ionic:
ionic (Ionic CLI)             : 4.3.1 (/Users/pianokai/.nvm/versions/node/v10.10.0/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.0.0-beta.15
@angular-devkit/build-angular : 0.10.7
@angular-devkit/schematics    : 0.7.5
@angular/cli                  : 7.0.7
@ionic/angular-toolkit        : 1.2.0
Cordova:
cordova (Cordova CLI) : 7.1.0
Cordova Platforms     : none
Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3
System:
ios-deploy : 1.9.2
ios-sim    : 5.0.13
NodeJS     : v10.10.0 (/Users/pianokai/.nvm/versions/node/v10.10.0/bin/node)
npm        : 6.4.1
OS         : macOS High Sierra
Xcode      : Xcode 10.1 Build version 10B61
Describe the Bug
A clear and concise description of what the bug is.
navigating between tabs would work on the first click but afterwards it does not work.
Steps to Reproduce
Steps to reproduce the behavior:

Download ionic conference app
npm install, npm install<EMAIL_ADDRESS>then npm run build
npx cap add electron, then npx cap copy
in ./electron/index.html, change  to
in ./electron/index.html, remove this line  as it will show the Stencil warning
in ./electron, type 'npm run electron:start'
Clicking between tabs would crash

Related Code
If you are able to illustrate the bug with an example, please provide a sample application via an online code collaborator such as StackBlitz, or GitHub.
Expected Behavior
Clicking between tabs should work as normal.
Additional Context
List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, screenshots, OS if applicable, etc.
Looks like the router or the router-outlet is broken in v.16 when clicking on . Instead of the router routing to /(link), it routes to ./.

Can you provide a repo case? i have a hard time understanding what the underlining issue is

Can you provide a repo case? i have a hard time understanding what the underlining issue is

i also don't fully understand your underlining issue, but keep in mind beta.16 changed from Angular 7 to Angular 7, perhaps update ionic to 4.5.0 and check out the package.json of ionic start myApp tabs --type=angular or check if anything changed from Angular 6 to Angular 7 depending the syntax of ion-tabs.
I did an update to Angular 7 today, and i did not need any changes on my ion-tabs

@manucorporat Here is the repo: https://github.com/calvinckho/conference-app
Notice if you downgrade to beta.15, the ion-tabs on Electron works as expected.
@RELAXccc, thanks and yes it is already using Angular 7.

Thank you @manucorporat. beta.17 came out and it fixed this issue related to routerLink.


Feature/2727 ng13

Fixes #275 I'm putting this in because if we're not longer building storybook, then there can't be any errors, right?

Changes proposed in this Pull Request:

Migrate over to angular 13
Preserve storybook in a working state at angular 12 w/<EMAIL_ADDRESS>

To Test:

Make sure you're on the showcase feature/ng13 branch, then run:
yarn start:showcase

noticing odd behavior with drawer with footer story. Clicking down the the hierarchy of stories and reaching the "with a footer" story the drawer doesn't display and throws error....

then clicking full config story then back up to the with footer story, the drawer displays

noticing odd behavior with drawer with footer story. Clicking down the the hierarchy of stories and reaching the "with a footer" story the drawer doesn't display and throws error....

then clicking full config story then back up to the with footer story, the drawer displays... also seems to be same issue with the drawer--within-a-drawer-layout story as well

just verified this is in master branch too

@jeffvg Is this something that is happening when observed here?
https://brightlayer-ui-components.github.io/angular/?path=/story/components-drawer--with-a-footer
Or is this just happening when you checkout the master branch locally and run it?

@jeffvg Is this something that is happening when observed here? https://brightlayer-ui-components.github.io/angular/?path=/story/components-drawer--with-a-footer
Or is this just happening when you checkout the master branch locally and run it?

I see this in both master and feature branches

I see this in both master and feature branches

Ok I'm doing a fresh clone and taking a look at the master branch now.

Ok I'm doing a fresh clone and taking a look at the master branch now.

Looks like a small changedetection error introduced by the navigation depth management logic; I'll put add a small patch in a separate PR.  We'll have to verify the component isn't destroyed before attempting a cd.detectChanges.

@jeffvg I've added a bug fix in #398 which should get merged in & published before this PR.


Show how to use the Q calculation engine of E4CV

Demonstrate how to use a different calculation engine other than the default hkl.
FIX #138

@jwkim-anl, @gfabbris, @strempfer, @rodolakis: You might be interested in this.  See: https://github.com/bluesky/hklpy/blob/138-other-engines/examples/var_engines.ipynb

@mrakitin: Can we finalize this for merge by next week (6/14)?

@mrakitin Thanks for the review!


lorri Crash Report

Lorri crashed.
Running on NixOS 20.09pre234194.8d05772134f (Nightingale).
The incriminating shell.nix uses sources from niv if that matters it fails even by stripping out this part.
Running nix-shell works fine.
Here's the crash report file:
name = 'lorri'
operating_system = 'unix:Unknown'
crate_version = '1.1.0'
explanation = '''
Panic occurred in file 'src/build_loop.rs' at line 184
'''
cause = '''
Unrecoverable error:
Io {
    msg: "Error { kind: Io(Os { code: 2, kind: NotFound, message: \"No such file or directory\" }), paths: [] }",
}'''
method = 'Panic'
backtrace = '''

   0: 0x5585b44733e7 - std::sys_common::backtrace::__rust_begin_short_backtrace::hf5c2b909feb00994
   1: 0x5585b451aa96 - std::panicking::try::do_call::he5c83fe2e1b3a210
   2: 0x5585b46c62c7 - __rust_maybe_catch_panic
   3: 0x5585b44f1306 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h5c597f91521da909
   4: 0x5585b46b05df - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hbbb901353ef4b64c
   5: 0x5585b46a616d - std::sys_common::thread::start_thread::h8dee943d5991507e
   6: 0x5585b46b7516 - std::sys::unix::thread::Thread::new::thread_start::hc9563c2ff113f634
   7: 0x7f6bf5b0aedd - start_thread
   8: 0x7f6bf5a21acf - __clone
   9:        0x0 - <unknown>'''

and another one:
name = 'lorri'
operating_system = 'unix:Unknown'
crate_version = '1.1.0'
explanation = '''
Panic occurred in file 'src/build_loop.rs' at line 184
'''
cause = '''
Unrecoverable error:
Io {
    msg: "Error { kind: Io(Os { code: 2, kind: NotFound, message: \"No such file or directory\" }), paths: [] }",
}'''
method = 'Panic'
backtrace = '''

   0: 0x55b476cd83e7 - std::sys_common::backtrace::__rust_begin_short_backtrace::hf5c2b909feb00994
   1: 0x55b476d7fa96 - std::panicking::try::do_call::he5c83fe2e1b3a210
   2: 0x55b476f2b2c7 - __rust_maybe_catch_panic
   3: 0x55b476d56306 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h5c597f91521da909
   4: 0x55b476f155df - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hbbb901353ef4b64c
   5: 0x55b476f0b16d - std::sys_common::thread::start_thread::h8dee943d5991507e
   6: 0x55b476f1c516 - std::sys::unix::thread::Thread::new::thread_start::hc9563c2ff113f634
   7: 0x7ff8c0425edd - start_thread
   8: 0x7ff8c033cacf - __clone
   9:        0x0 - <unknown>'''

More from today, after clearing my ~/.cache/lorri and doing a nix-collect-garbage -d:
name = 'lorri'
operating_system = 'unix:Unknown'
crate_version = '1.1.0'
explanation = '''
Panic occurred in file 'src/build_loop.rs' at line 184
'''
cause = '''
Unrecoverable error:
Io {
    msg: "Error { kind: Io(Os { code: 2, kind: NotFound, message: \"No such file or directory\" }), paths: [] }",
}'''
method = 'Panic'
backtrace = '''

   0: 0x564c193283e7 - std::sys_common::backtrace::__rust_begin_short_backtrace::hf5c2b909feb00994
   1: 0x564c193cfa96 - std::panicking::try::do_call::he5c83fe2e1b3a210
   2: 0x564c1957b2c7 - __rust_maybe_catch_panic
   3: 0x564c193a6306 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h5c597f91521da909
   4: 0x564c195655df - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hbbb901353ef4b64c
   5: 0x564c1955b16d - std::sys_common::thread::start_thread::h8dee943d5991507e
   6: 0x564c1956c516 - std::sys::unix::thread::Thread::new::thread_start::hc9563c2ff113f634
   7: 0x7f07fb5a0edd - start_thread
   8: 0x7f07fb4b7acf - __clone
   9:        0x0 - <unknown>'''

No idea what's that path that is missing…

At the same time I have:
Jul 15 13:37:30 sam lorri[12873]: Jul 15 13:37:30.688 INFO build status, message: BuildEvent(Failure { nix_file: Shell("/home/eeva/relex/isengard/deploy/shell.nix"), failure: Exit { cmd: "\"nix-instantiate\" \"-vv\" \"--add-root\" \"/tmp/.tmpQye81k/result\" \"--indirect\" \"--argstr\" \"runTimeClosure\" \"/nix/store/32rvq8qyyyg8k5i0ain5x3z3110j9vm1-runtime-closure.nix\" \"--argstr\" \"src\" \"/home/eeva/relex/isengard/deploy/shell.nix\" \"--\" \"/home/eeva/.cache/lorri/cas/3a83fbad2f114b4f4f431db2014c985c\"", status: Some(1), logs: [LogLine("unpacking \'http://releases.nixos.org/nixos/20.03/nixos-20.03.1445.95b9c99f6d0/nixexprs.tar.xz\'..."), LogLine("tar (child): xz: Cannot exec: No such file or directory"), LogLine("tar
(child): Error is not recoverable: exiting now"), LogLine("tar: Child returned status 2"), LogLine("tar: Error is not recoverable: exiting now"), LogLine("error: program \'tar\' failed with exit code 2")] } })

Lorri is installed through services.lorri.enable = true

One mone bit of information from journalctl:
Aug 05 13:14:42 sam systemd[1296]: lorri.service: Main process exited, code=exited, status=101/n/a

Basically the same error here.
name = 'lorri'
operating_system = 'unix:Unknown'
crate_version = '1.1.0'
explanation = '''
Panic occurred in file 'src/build_loop.rs' at line 184
'''
cause = '''
Unrecoverable error:
Io {
    msg: "Error { kind: Io(Os { code: 2, kind: NotFound, message: \"No such file or directory\" }), paths: [] }",
}'''
method = 'Panic'
backtrace = '''

   0: 0x5642dc71ede9 - std::sys_common::backtrace::__rust_begin_short_backtrace::h9f0d9a224168c6fa
   1: 0x5642dc7bf2c6 - std::panicking::try::do_call::h471201e4c23bfb52
   2: 0x5642dc982aba - __rust_maybe_catch_panic
   3: 0x5642dc7aed46 - core::ops::function::FnOnce::call_once{{vtable.shim}}::he7d67f266d25d93e
   4: 0x5642dc97689f - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::he9dcb7073be13c65
   5: 0x5642dc9643d0 - std::sys_common::thread::start_thread::h9ce8f903e84fe8e9
   6: 0x5642dc975f16 - std::sys::unix::thread::Thread::new::thread_start::h5e894f0575174d9e
   7: 0x7ff0985dbedd - start_thread
   8: 0x7ff0984f2aaf - __clone
   9:        0x0 - <unknown>'''

Think this was during or after a nix-collect-garbage.

I do collect garbage automatically once a week here. Maybe some path was trashed when it should not have been?

I’m gonna annotate file not found errors with their path soon-ish, then
there is more information about what went wrong. We have to do better error
handling for functions accessing files.
On Thu, Aug 6, 2020 at 10:42 AM Martin<EMAIL_ADDRESS>wrote:

I do collect garbage automatically once a week here. Maybe some path was
trashed when it should not have been?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/target/lorri/issues/447#issuecomment-669796649, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYB5ZVK4UMR7SDY7NHY7GTR7JUHLANCNFSM4OZNYSYQ
.


feat: add bytes_sent and bytes_received as metrics

Port of CloudSQL's https://github.com/GoogleCloudPlatform/cloud-sql-go-connector/pull/856
Fixes https://github.com/GoogleCloudPlatform/alloydb-go-connector/issues/607

Details

Yes, I'm planning to to do this. I discussed with Eno that I'll use the Go connector in a client VM, send read/write requests to an AlloyDB cluster, and verify whether the metrics show up in Cloud Monitoring.

Did you check that the metrics were populated in monitoring? I'm not sure if you talked about this with Eno if that'd be too much of a hassle when OpenCensus is going away

Yes, I'm planning to to do this. I discussed with Eno that I'll use the Go connector in a client VM, send read/write requests to an AlloyDB cluster, and verify whether the metrics show up in Cloud Monitoring.

Thanks! Do leave a comment on the PR when you verify this (and maybe some pictures would be nice :))


doubt reg UI

I've another internal executive dashboard ( JSP based) ,  Iam using Hygieia as well.
is it possible to use only of the widget from available in Hygieia to embed in my other application? ( say, just embed the sonar widget in other app, using any of HTML statement?  )
please clarify

@smsuresh You could use something like an iframe to embed one webapp inside another webapp. If you want just one widget, you would need to create an additional template with just that widget and then embed it inside another app.


Handle orphaned jobstore writes on job failure (resolves #1239)

resolves #1239

@hannes-ucsc I've implemented the test i believe shows that the orphaned file exists If you approve this, I'll start on the actual code to fix it.

@arkal what happened to the tests?

Continued in #1351


fix(sqlsmith): fix failing frontend tests

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix it and re-enable fuzzing (just for frontend) per PR and in main-cron.
Frontend tests fail relatively less often. Can easily split into its own pipeline too.
Following PRs will try to fix up e2e fuzzing too, seems like that's failing as well.
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Failing main-cron workflow 806f713
Is due to e2e-test release, which is unrelated to changes in this PR.


fix: loading raw pub key to Tink keyset.Handle fails verification

Since default signing key templates have Tink specific prefix,
need to use RAW type to avoid adding a prefix. This will fix
verification with a keyset.Handle created from raw public key []byte
To unblock dev, the temporary fix is to manually change the key templates
in aries-framework-go code. A followup issue is created to use Tink
created key templates without a prefix when the templates are
available in Tink (#1489).
closes #1483
Signed-off-by: Baha Shaaban<EMAIL_ADDRESS>

@Baha-sk  can we add a test case I mentioned at https://github.com/hyperledger/aries-framework-go/issues/1483#issue-583803837 to double-check your temporary fix?

@Baha-sk can we add a test case I mentioned at #1483 (comment) to double-check your temporary fix?

@kdimak the test already exists: https://github.com/hyperledger/aries-framework-go/blob/master/pkg/kms/localkms/pubkey_export_import_test.go#L76

@Baha-sk can we add a test case I mentioned at #1483 (comment) to double-check your temporary fix?

@kdimak the test already exists: https://github.com/hyperledger/aries-framework-go/blob/master/pkg/kms/localkms/pubkey_export_import_test.go#L76

OK!


add CITATION.cff

I was asked in a DM in Gitter how to cite PyO3 today, and I thought it might be helpful to add a CITATION.cff file which GitHub appears to have native support for.

Since there are a lot of scientific users it might make sense to write a journal publication with a DOI for pyo3 and the tools around it, e.g. through the Journal of Open Source Software. This requirements for JOSS are fairly small, but it would be really cool to use this to make a review of scientific software using pyo3 (e.g. huggingface tokenizers, fastobo, NBLAST, https://github.com/PyO3/maturin/discussions/1030, this cites pyo3, rustworkx (also in JOSS), this bachelors thesis, PhyloDM, ..., there are a lot of science projects if you click through the github reverse dependencies list). This would be mostly relevant for those still in academia (which would be @althonos, @kngwyu and I, I think)

I completely agree with @konstin, and also second the recommandation for going towards JOSS, which totally makes sense for a community software project with scientific applications like PyO3. They only require a short manuscript with a very minimal "Statement of need" (which I think is covered already by existing articles like Nature's Why scientists are turning to Rust), and otherwise inspect the code quality, documentation, CI/CD etc. which I think are already passing the requirements with flying colors thanks to all of the hard work done here over the years!

Thank you for this PR!

I was asked in a DM in Gitter how to cite PyO3 today

Since a considerable amount of scientific projects are using PyO3, publishing in JOSS sounds great. I'm happy to help publish if needed. Having itation.ccf seems nice for now.

👍 it is outside of my capacity to work on a JOSS publication for now, please have my blessing to proceed with authoring one if you have time to @konstin @kngwyu @althonos

I'd also be interested if my contributions are deemed important enough.

@birkenfeld of course!


Task is left in weird state after containerd is restarted during task deletion.

I hit one case in cri-containerd restart test that:

The test stops a container;
cri-containerd handles TaskExit event and task.Delete the task;
task.Delete closes the task io, which deletes the fifo directory here
containerd/cri-containerd gets restarted before task is actually deleted here.
After cri-containerd/containerd is up, we'll never be able to load the task and attaching FIFOs. Because the fifo directory has been removed, even we do OpenFifo in ioAttach we'll get the error that the directory is not found.

There are 2 options:

Option 1: Do not try to attach io to a stopped task. The problems is that we usually attach io when loading task, but with the current client we can only know the task status after loading the task. It means that to reliably load a task and attach io, we have to 1) load task without IO first -> 2) check status -> 3) load task with IO. This is pretty troublesome.
Option 2: Ensure fifo directory exists in loadTask when ioAttach is specified.

I feel like option 2 seems simpler.
/cc @dnephin

@Random-Liu I can't find where the io.Close() would remove the directory, could you point to the implementation? The behavior of that close call depend on the Creator used when calling NewTask so I would argue that the onus is on the client to not delete the directory until it has receive success from the deletion call.

@mlaventure See here.

ah, I was looking at the windows version this whole time :sweat_smile:


Use custom-select-% variable instead of input

is there a reason why this package uses the input field variable instead of the custom-select-% variables?
https://github.com/twbs/bootstrap/blob/7a6da5e3e7ad7c749dde806546a35d4d4259d965/scss/_variables.scss#L575
I had a custom drop-down indicator on my normal select fields but when I installed this package, I lost that customization. Looking through your source code, it doesnt look like any of these variables are used.
Is there a particular reason for this?

Hi @claytoncollie, I've noticed the same and I've refactored this theme to use custom-select in #67
This is only compatible with the upcoming Select2 4.1 release

Looks good. Thank you for the patch.


Update scalafmt-core, scalafmt-dynamic to 3.8.2

About this PR
📦 Updates

org.scalameta:scalafmt-core
org.scalameta:scalafmt-dynamic

from 3.8.1 to 3.8.2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #161.


Disable the creation of persistence.xml

Hello ,
When we choose to Generate Source Code the persistence.xml is created or if the file already exists , it appends the "DEFAULT_PU".
It would be great if we could disable the creation or the appendance of persistence.xml
Thanks.

Update the Persistence Unit name with already existing PU name of persistence.xml. So it will not create the new PU.
Click on the diagram > Properties > Basic Properties > Persistence Unit name

Hello @jGauravGupta ,
I did as you have said but , it still adds class tags. If it's possible to disable the update of the current Persistence Unit .
Thank you.

Will add this feature to next release :)


Missing types on the latest (1.4.11) of @nhost/nhost-js package

Hi guys,
I'm getting these errors on the latest version of the javascript client
TS2724: '"@nhost/core"' has no exported member named 'ChangeEmailResponse'. Did you mean 'ChangeEmailOptions'? TS2724: '"@nhost/core"' has no exported member named 'DeanonymizeResponse'. Did you mean 'DeanonymizeOptions'? TS2305: Module '"@nhost/core"' has no exported member 'NhostSessionResponse'.
I looked at the type definition in the node_modules and this version is missing all the response types defined in @nhost/core. Downgrading to v1.4.7 fixes the issue
Am I missing something?
I picked this up on an angular project using version 14

I upgraded to the latest version and the response issue seems to be solved. This error however remained
Error: node_modules/@nhost/hasura-storage-js/dist/utils/types.d.ts:1:8

import FormData from 'form-data';

node_modules/form-data/index"' can only be default-imported using the 'allowSyntheticDefaultImports' flag

This is pretty self-explanatory, so I added the flag on my tsconfig.json compiler options
"allowSyntheticDefaultImports": true,
I can compile and test the app again

Hello @kornect,
Yes, this is the way to solve this allowSyntheticDefaultImports error.
I however tried to reproduce your issue on this sandbox with no success. Regardless of the reproduction, there is not much we can do to avoid this error without setting allowSyntheticDefaultImports to true.
Don't hesitate to share a reproduction link through.
Thanks!


crypto$Decipher#update type annotation incorrect

According to
https://nodejs.org/api/crypto.html#crypto_decipher_update_data_input_encoding_output_encoding
the input_encoding should be 'latin1' | 'base64' | 'hex'
for some reason, flow's definitions are 'utf8'| 'ascii' | 'binary', though it's not clear where that came from.
https://github.com/facebook/flow/blob/8e9755ed36d631679314110ea296683c71f269f0/lib/node.js#L340

@nicks node v4 used different types for this API:
https://nodejs.org/dist/latest-v4.x/docs/api/crypto.html#crypto_class_decipher
I'll probably send a PR tackling this 👍


Remove unnecessary removeFinal and LCM

It caused issues in java 12+ and isn't even needed to use field.set on final fields.

This project seems to be abandoned. I'm gonna close this PR. I'll leave the branch up for anyone that needs this fix.


Support resx

When using the build image to build an asp.net 3.5 website project that contains RESX files - you get the following exception:
[15:12:54]foo\bar\baz.csproj: Build default targets (1s)
[15:12:54]PrepareForBuild
[15:12:54]_GetProjectReferenceTargetFrameworkProperties
[15:12:54]ResolveProjectReferences
[15:12:54]_HandlePackageFileConflicts
[15:12:54]CoreResGen (1s)
[15:12:54]GenerateResource (1s)
[15:12:56]C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Microsoft.Common.CurrentVersion.targets(3009, 5): error MSB4216: Could not run the "GenerateResource" task because MSBuild could not create or connect to a task host with runtime "CLR2" and architecture "x86". Please ensure that (1) the requested runtime and/or architecture are available on the machine, and (2) that the required executable "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\MSBuildTaskHost.exe" exists and can be run.
[15:12:56]C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Microsoft.Common.CurrentVersion.targets(3027, 7): error MSB4028: The "GenerateResource" task's outputs could not be retrieved from the "FilesWritten" parameter. Object does not match target type.

If you remove the resource file from the project then it successfully builds.
Opened as requested via https://github.com/Microsoft/dotnet-framework-docker/pull/89

I tried this with the latest builds and could reproduce.  @dazinator, is this still an issue?  If so can you supply a simple repo?

I tried this with the latest builds and could reproduce

I assume you meant you could not reproduce?
If you cant repro any longer perhaps it's been fixed- happy to close and can reopen if I encounter again. I put the attempt in hold and no immediate need to revisit it at this time.


[WIP] Don't build EFCore.Benchmarks.EF6 on non-Windows

This might fix #7781

It adds a new solution configuration with that project excluded and tells KoreBuild to use that solution configuration on non-Windows.
lol, don't look at what this commit adds. Look at what it doesn't add. 😉

But it needs a little something more. Travis failed.

Recalling. This issue has been mitigated by Nate's changes.


Fail to create image/ssh key

link to PR https://github.com/rancher/harvester/pull/109

validated


Add hideErrors option

We are using the cache only in CI and we don't care for it during local development. hideErrors was added to hide warnings and errors when we know it will fail. Still thinking about it since setting it to true means we will lose any unexpected error in the CI. I'll be back to this later and re-open it with a proper solution.

👀

Sure, any contribution is welcome!


Pending or Skipped tests not uploaded with the execution

Hello :)
Description
I have tested adding tags such as @skip or @only to run only the scenarios I want. However, after the execution is complete, tests with the status pending or skipped are not included in the execution in Jira.
I would like to have the option to include those tests in the execution even if I skipped them manually.
I have tried to use optional settings for the status, but I am using the default settings
In my previous project I had an older version of this plugin and I was not using Cucumber and it was possible to upload the Skipped tests I had disabled using xit(...)
Cypress version
13.10.0
Plugin version
7.0.1
Jira/Xray type
Cloud
Configuration
import { addCucumberPreprocessorPlugin } from '@badeball/cypress-cucumber-preprocessor';
import { configureXrayPlugin, syncFeatureFile } from 'cypress-xray-plugin';
import { defineConfig } from 'cypress';
import coverageWebpack from './cypress/coverage.webpack';
import { DASHBOARD, RESULT } from './cypress/properties/credentials';
import { EnvUrl } from './cypress/properties/env-url.enum';

// eslint-disable-next-line @typescript-eslint/no-var-requires
const { Client } = require('pg');

import createBundler from '@bahmutov/cypress-esbuild-preprocessor';
import createEsbuildPlugin from '@badeball/cypress-cucumber-preprocessor/esbuild';
// eslint-disable-next-line @typescript-eslint/no-var-requires
const fix = require('cypress-on-fix');

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const connections: Record<string, any> = {
  atDashboard: {
    host: DASHBOARD.host,
    user: DASHBOARD.user,
    password: DASHBOARD.password,
    database: DASHBOARD.database,
    port: DASHBOARD.port,
  },
  atResult: {
    host: RESULT.host,
    user: RESULT.user,
    password: RESULT.password,
    database: RESULT.database,
    port: RESULT.port,
  },
  // You can add more data bases repeating the same structure
};

export default defineConfig({
  component: {
    devServer: {
      framework: 'angular',
      bundler: 'webpack',
      webpackConfig: coverageWebpack,
    },
    specPattern: '**/*.cy.ts',
    setupNodeEvents(on, config) {
      // eslint-disable-next-line @typescript-eslint/no-var-requires
      require('@cypress/code-coverage/task')(on, config);
      // eslint-disable-next-line @typescript-eslint/no-var-requires
      const getCompareSnapshotsPlugin = require('cypress-image-diff-js/plugin');
      getCompareSnapshotsPlugin(on, config);
      return config;
    },
    viewportWidth: 1280,
    viewportHeight: 720,
  },

  e2e: {
    experimentalWebKitSupport: true,
    baseUrl: EnvUrl.URL,
    async setupNodeEvents(on, config) {
      const fixedOn = fix(on);

      fixedOn('task', {
        async queryDb({ dbName, query }) {
          const { host, user, password, database, port } = connections[dbName];
          const client = new Client({
            user: user,
            password: password,
            host: host,
            database: database,
            port: port,
          });
          await client.connect();
          const res = await client.query(query);
          await client.end();
          return res.rows;
        },
      });

      fixedOn('file:preprocessor', async (file: Cypress.FileObject) => {
        await syncFeatureFile(file);
        const cucumberPlugin = createBundler({
          plugins: [createEsbuildPlugin(config)],
        });

        return cucumberPlugin(file);
      });

      // eslint-disable-next-line @typescript-eslint/no-var-requires
      const getCompareSnapshotsPlugin = require('cypress-image-diff-js/plugin');
      getCompareSnapshotsPlugin(fixedOn, config);

      await addCucumberPreprocessorPlugin(fixedOn, config);
      await configureXrayPlugin(fixedOn, config, {
        jira: {
          projectKey: 'XXX',
          url: 'url',
          testExecutionIssueKey: 'XXX-3053',
        },
        xray: {
          uploadResults: true,
        },
        cucumber: {
          featureFileExtension: '.feature',
          uploadFeatures: true,
          prefixes: {
            precondition: 'PRECOND_',
            test: 'TEST_',
          },
        },
        plugin: {
          enabled: true,
        },
      });

      return config;
    },
    viewportWidth: 1920,
    viewportHeight: 1080,
    specPattern: ['**/**/*.feature'],
    requestTimeout: 40000,
    responseTimeout: 30000,
  },
});

Acknowledgements

[X] I have made sure not to include any sensitive data in screenshots or obfuscated all occurrences.
[X] I have made sure not to include any sensitive data in descriptions or replaced all values with placeholders.
[X] I have made sure not to include any sensitive data in code snippets or replaced all values with placeholders.

Hi @mar1ogz,
thanks for the very detailed issue description! I will look into it, theoretically it should be possible to scan all included scenarios for @skip or @only tags.

Sorry for the somewhat late reply. I looked into it and the Cucumber plugin seemingly does not at all include skipped tests in the generated JSON report, which my plugin relies on and uploads to Xray. I have started a discussion in the other repository, which you can follow for now for further updates: https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1203

Hello!
Nice :) Thanks for getting involved in this topic @csvtuda!

Hey @mar1ogz,
I have just released version 7.1.0 (changelog). This version includes a dependency bump of the cypress-cucumber-preprocessor, which fixes the problem with skipped scenarios.
However, since the preprocessor skips scenarios by marking all the steps they contain as "skipped", I had to add new options:
xray: {
  status: {
    step: {
      failed: // ...
      passed: // ...
      pending: // ...
      skipped: // ...
    }
  }
}

By default, Xray treats Cucumber step results named "skipped" as "TODO" (as far as I've seen). So you'll need to explicitly set skipped steps to the status you want to see, e.g.:
xray: {
  status: {
    step: {
      skipped: "MY SKIPPED STATUS"
    }
  }
}

You can check the documentation for another example.

I also looked at @omit. It looks to me like the preprocessor ignores this tag completely and executes all scenarios regardless. Unfortunately, I will not be able to investigate this further in the coming weeks. If my observations are correct, you will need to open an issue with @badeball/cypress-cucumber-preprocessor, as my plugin is not responsible for executing tests/scenarios - only for uploading results.

Hey @csvtuda!
Now it is working fine with the @skip tag! It is set as TO DO because I don't have the SKIPPED status in Xray set up for my project, but I will definitely ask my admin for it :)
Thank you for your hard work and for solving this issue so quickly!


Refactoring, improved error logging, and started a CONTRIBUTING.md

I really like this extension, and want to help make it better. When I first used this extension on a work project, it wouldn't work, and the errors were not helpful in finding what the issue was.
So I first wanted to help improve the error logging. I traced the unkown error back to mochashim.js, so that is where I started. It had a lot of duplicated code that I thought could be combined. If I was wrong and they should be separate, please let me know.
After some refactoring to make future changes easier, I improved some of the error logging around finding and running tests.
I also started a CONTRIBUTING.md based off of my experiences from making these first changes, in hopes that it will help future contributors get started.
Let me know what you think!
EDIT: Helps with #21

Also fixes an issue I just had, where the findtests.js process would never exit, even though it had finished finding the tests with mocha. Maybe it was caused by async mocha tests?

Tks for your contribution it seems like a great addition.
I will merge it as soon as  can


Removed a circular dependency between remote.ts and tunnelView.ts...

... in directory "vs/workbench/contrib/remote/browser/", which was producing a compile-time error.
Moved a single variable declaration from remote.ts to a new file called
forwardedPortsViewEnabled.ts

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Levitator1 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for the PR, but this was already fixed with https://github.com/microsoft/vscode/commit/c1b74a9cff9a1f3225fe040d8cda319aefcef13a

Sorry, I searched for "circular" and nothing came up.


Training Process Error:  accelerator.backward(loss)

When I run train_stage_1.py, "accelerator.backward(loss)" shows error like following. Could you help me to solve this error?

Exception has occurred: RuntimeError
Trying to backward through the graph a second time (or directly access saved tensors after they have already been freed). Saved intermediate values of the graph are freed when you call .backward() or autograd.grad(). Specify retain_graph=True if you need to backward through the graph a second time or if you need to access saved tensors after calling backward.

I also tried adding "retain_graph=True" but it also doesn't work.

Do you set gradient_checkpointing=True in traning?

I set gradient_checkpointing: True in stage1.yaml.
After changing to gradient_checkpointing: False, it can pass.
Thank you!

Hi the same error appears when I set gradient_accumulation_steps >1. I can set retain_graph=True but I do not know if this affects training.

When I set the following, it works.

train_bs: 2
num_processes: 2

@goshiaoki hi, I meet the same error, where should "num_processes" be added, please

可是gradient_checkpointing=True就不是梯度累计了呀，如何不加这个项跑通呢


Refactor build_headers

Codecov Report

Merging #900 (f296d2b) into devel (265ae87) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##            devel     #900   +/-   ##
=======================================
  Coverage   89.92%   89.92%
=======================================
  Files          28       28
  Lines        4677     4677
=======================================
  Hits         4206     4206
  Misses        471      471

Impacted Files
Coverage Δ

hahomematic/helpers.py
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


bug: comments cause error messages

Right now the idea implies that here is a comment - however it is only syntax highlighting..
Therfore next-yak is causing an error:

fixed in 0.2.6:
https://stackblitz.com/edit/next-yak-starter-8k5h1n?file=app%2Fpage.tsx


Store hashmap values in a single Vec instead of Rc's

This stores all the value pairs in a Vec and keeps 2 HashMaps that hold indexes into the Vec to allow lookups.
This trades the overhead from Rc with the overhead of using the index, note that in both cases the HashMaps hold "pointers" to the values.
On my local machine the added benchmarks give the following result
before:
test bench_hash_map_get_left            ... bench:       8,294 ns/iter (+/- 724)
test bench_hash_map_get_right           ... bench:       2,094 ns/iter (+/- 286)
test bench_hash_map_insert              ... bench:      34,270 ns/iter (+/- 1,634)
test bench_hash_map_insert_no_overwrite ... bench:      33,936 ns/iter (+/- 4,649)
test bench_hash_map_iter                ... bench:         320 ns/iter (+/- 47)
test bench_hash_map_replace_both        ... bench:      27,046 ns/iter (+/- 2,294)
test bench_hash_map_replace_left        ... bench:      35,141 ns/iter (+/- 2,200)
test bench_hash_map_replace_right       ... bench:      31,532 ns/iter (+/- 2,925)
test bench_hash_map_replace_same        ... bench:      23,992 ns/iter (+/- 1,224)

after:
test bench_hash_map_get_left            ... bench:       7,807 ns/iter (+/- 1,015)
test bench_hash_map_get_right           ... bench:       2,195 ns/iter (+/- 321)
test bench_hash_map_insert              ... bench:      16,577 ns/iter (+/- 1,068)
test bench_hash_map_insert_no_overwrite ... bench:      15,947 ns/iter (+/- 1,006)
test bench_hash_map_iter                ... bench:          66 ns/iter (+/- 7)
test bench_hash_map_replace_both        ... bench:      16,406 ns/iter (+/- 1,372)
test bench_hash_map_replace_left        ... bench:      21,219 ns/iter (+/- 2,122)
test bench_hash_map_replace_right       ... bench:      18,556 ns/iter (+/- 1,374)
test bench_hash_map_replace_same        ... bench:      11,585 ns/iter (+/- 1,510)

Getting values is pretty much the same since both have one layer of indirection on top of the HashMap.
Inserting is ~30% faster, presumably due to not having to create the Rc's.
Iterating is a lot faster presumably due the cache locality of the values in the new setup.
Memory overhead should be less -- the Rc adds 2 usize's overhead per stored item for refcounting, both implementations store 2 "pointers" per value in the HashMaps) -- but I don't have proper numbers on that.
Since the keys stored in the new HashMaps are themselves already hashes of the inserted values, a dummy hasher is used to prevent double hashing.

Codecov Report

Merging #9 into master will decrease coverage by 0.87%.
The diff coverage is 94%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   99.31%   98.43%   -0.88%
==========================================
  Files           4        4
  Lines         585      641      +56
==========================================
+ Hits          581      631      +50
- Misses          4       10       +6

Impacted Files
Coverage Δ

src/lib.rs
100% <ø> (ø)
:arrow_up:

src/btree.rs
99.26% <ø> (ø)
:arrow_up:

src/hash.rs
97.4% <94%> (-1.81%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5abca2...b9ab2ee. Read the comment docs.

ping @billyrieger

Sorry for the slow reply, my computer was out of commission for a while. This seems like it would be a good improvement for the library. Before going too deep into the code, I have a question regarding the NullHasher. Instead of having a HashMap<u64, usize, NullHasherBuilder> and hashing the keys manually with Self::get_hash(), wouldn't it make more sense just to have a HashMap<T, usize> to store the data indices? How it's written now seems to have an unnecessary layer of indirection (hence why NullHasher is needed).

Also, if we're doing this change for BiHashMap it makes sense to also do it for BiBTreeMap.

using a HashMap<T, usize> would require storing the values in the hashmap, by using the hash we can put them in the Vec instead.
Updating BiBTreeMap is generally something I want to do once this is merged, and I also want to see if I can generalize the bimap to work with any underlying map

I just realized that doing the pre-hashing removes the hashmap's ability to handle hash collisions and will thus not be reliable.
I'll see if I can adjust the way the data is stored

I'm closing this for now, but if you ever get something to work you can open a new pull request.


[Bug] Helm is needed when it shouldn't be

In your latest commit you seem to have broken the helm dependency.
I have no intentions of using Helm and am using the default of install_helm=false but the binary itself is now needed since the ~/.helm dir needs to exist in order for your TF code to execute.

Sorry about that. I actually misunderstood how the helm provider works. Also, I found an open bug on the helm provider yesterday. I'll look at your fix

Fixed in https://github.com/oracle-terraform-modules/terraform-oci-oke/pull/29


Build targets of workspace crates do not appear to be honoured

rust-analyzer version: rust-analyzer version: 54782428a 2022-01-12 dev
rustc version: rustc 1.59.0-nightly (c5ecc1570 2021-12-15)
Further to the "Respect .cargo/config.toml" PR, the config.toml file of a crate within a workspace does not appear to be honoured. For example, if I have a project named client and it has two crates, app and embedded-app, and embedded-app has a .cargo/config.toml, then the latter does not appear to be considered when determining build targets.
To reproduce this issue:

Download the branch at https://github.com/titanclass/embassy-start/pull/4
rustup target add thumbv7em-none-eabihf if you don't have that target
Open the project's workspace file (embassy-start.code-workspace) in VSC
Navigate to client/embedded-app/src/boards/nrf52840_dk.rs
Wait for RA to complete its indexing
Note that interrupt::take! on L18 is able to be resolved
Remove the "rust-analyzer.cargo.target": "thumbv7em-none-eabihf" from the workspace file
Reload RA
Wait for RA to complete its indexing
Note that interrupt::take! can no longer be resolved

My expectation is that the build target of client/.embedded-app/.cargo/config.toml should be honoured, and that I should not have to declare a rust-analyzer.cargo.target.
Related? https://github.com/rust-analyzer/rust-analyzer/issues/8521

I made some progress by running my own RA build and printing out the cargo.toml's that were being used to determine the various targets. In my example, this is what I get:
config ManifestPath { file: AbsPathBuf("/Users/huntc/Projects/titanclass/embassy-start/client/Cargo.toml") } "cargo" "-Z" "unstable-options" "config" "get" "build.target"
result None
config ManifestPath { file: AbsPathBuf("/Users/huntc/Projects/titanclass/embassy-start/network-protocol/Cargo.toml") } "cargo" "-Z" "unstable-options" "config" "get" "build.target"
result None
config ManifestPath { file: AbsPathBuf("/Users/huntc/Projects/titanclass/embassy-start/server/Cargo.toml") } "cargo" "-Z" "unstable-options" "config" "get" "build.target"
result None
...meaning that no target is being resolved out of the cargo.toml's that are used.
client/embedded-app/Cargo.toml and server/embedded-app/Cargo.toml would be needed to determine the needed build targets here.

I've come to the conclusion that RA is working as intended. When it performs a cargo check, it does so at the workspace level if there is one, or if there's not, then just the crate. Cargo workspaces aren't effective when there are multiple targets being used as expressed by config.toml. In fact, config.tomls are only applied when cargo is working within that particular directory.
I have since removed workspaces from situations where there are no common targets between crates.


RSC_007 doesn't say which file exactly is missing

Message RSC_007 doesn't say which resource exactly can't be found in the EPUB:
ERROR(RSC-007): /Users/tobiasfischer/Entwicklung/EPUB-Kram/_testdaten/official/UnmanifestedGuideItems.epub/OEBPS/content.opf(29,67):
  Referenced resource is not found in the ePub.

A better message would be:
ERROR(RSC-007): /Users/tobiasfischer/Entwicklung/EPUB-Kram/_testdaten/official/UnmanifestedGuideItems.epub/OEBPS/content.opf(29,67):
  Referenced resource "toc.html" is not found in the ePub.

references #588, #634

Added a fix for that in PR #722


Submodules for pony-semver, ponylang/appdirs; using appdirs for repo cache

Migrated use of pony-semver to a submodule referencing btab/pony-semver @ v0.1

Fixes #77

Added submodule for ponylang/appdirs.

Fixes #78

Using appdirs now to compute default repo cache directory.

Fixes #28

Added a --repo_cache_dir option to allow custom repo cache locations.

This needs manual CHANGELOG entries.

And one of:

The Makefile needs to be updated to check out git submodules if they don't already exist.
The checkout needs to be done in a recursive fashion to get the submodules

I'm leaning towards the Makefile should use dependency tracking to determine if the submodules are checked out and if not, should check them out. However, to move along the PR and verify that tests pass etc, Then the various github workflows that use the checkout action should be updated like this:
uses: actions/checkout@v1
  with:
    submodules: recursive

I'm not particularly comfortable with the change to using an external dependency that we don't control.
And important issue. It's referencing a tagged commit. I think this is a bad idea. Security-wise, that tag can be moved. It should use a SHA because, its a repo that is out of our control. A tag can be moved and introduce an attack vector. A SHA will still point to the same commit. That said, I'm not really comfortable using a library that is external. I'd prefer to develop a ponylang alternative or if @btab is willing, to make pony-semver a Ponylang project.

I have updated the Makefile to pull the submodules as a dep. This works locally, but I am not sure if it addresses all the paths that the github workflows need. I've updated the pony-semver reference to use the SHA. I will check with @btab to see if he is interested in moving pony-semver into ponylang.

I updated the github workflows that were building Docker images to ensure that the submodules are pulled at checkout time. And I updated the Dockerfile to get the submodule trees copied into the build container. But I now see an error from make:  make: *** No rule to make target 'install'.  Stop. locally and on github that is mysterious.

So, you don't need both the submodule recursive in github workflows and also in the Makefile. You should pick one. 2 is redundant.
You didn't update all the .github workflow files that need updating so if you want to go that route, that needs to be completed.
The submodules support is incorrect how it is done. I could start to fix it, but it also won't work particularly well for anything other than pulling in the dependencies. Really it should also be scanning for .pony files in the directories and using as part of a build target. Other than the existing syntax problem, the current setup would allow for a change to a dependency in the subdirectory and wouldn't trigger a rebuild.  But if you changed the README for either, it would trigger a rebuild.

I see that both the git workflows and Makefile approach are redundant in the CI use cases. But they are not necessarily in developer use cases. I guess we could add a note to the readme to remind people to git clone  --recursive and/or git submodule update --init. I took the approach of relying on the Makefile for make-based targets but added the --recursive to the workflows that ran Docker build directly which then requires the submodules to be pulled prior to the Docker build.
The Makefile implementation for pulling the submodules is strictly for pulling them the first time to make it more developer-friendly. Maybe that limited solution is more confusing than helpful and we should just rely on instructions in the readme.

I think we should be doing the Makefile approach, but neither was complete when I left that comment. The recursive ci pull wasn't done for all cases that needed it and Makefile left a lot of edge-cases around and wasn't working.
I think you should finish off the recursive CI stuff (it needs to be done everywhere in a .github workflow that uses checkout@v1) and remove the Makefile stuff for now and we can add an issue to add full and correct handling in the Makefile.

I'm going to take over finishing off this PR unless someone else wants to.
I definitely want to see Carl's last work completed and merged.

I did implement most of these changes.


Please add Jammy to Ubuntu PPA

Currently only Focal and Impish are available on the repo.

Added - https://launchpad.net/~daniel-milde/+archive/ubuntu/gdu/+build/24348008
I will upload newer version soon.


replace anvil OP types with op-alloy

Motivation

close #8575
Solution

we should be able to replace the anvil deposit type entirely with the op-alloy I think?

All struct fields name is the same as op-alloy?

Just a heads up - due to duplicate tickets we may have double assigned this task, if we end up having a PR for https://github.com/foundry-rs/foundry/issues/6860 by @leovct I'll make sure to tag @programskillforverification as co-author

Just a heads up - due to duplicate tickets we may have double assigned this task, if we end up having a PR for #6860 by @leovct I'll make sure to tag @programskillforverification as co-author

No problem at all. I started to work on it but it's not done, I can give it to @programskillforverification :)

Just a heads up - due to duplicate tickets we may have double assigned this task, if we end up having a PR for #6860 by @leovct I'll make sure to tag @programskillforverification as co-author

This PR  has been opened for a long time, I think all is done but maybe not. I don't get what @mattsse mean. Could you give me more detail, like what't left to do. I hope finish this assign asap.

Superseded by #9047


extracting directb2s files

These are just xml with images and some other data?

https://sourceforge.net/p/b2s-backglass/code/HEAD/tree/trunk/b2sbackglassdesigner/b2sbackglassdesigner/classes/Save.vb


chore(tests): fail on console.error for propType warnings

We have a hard time tracking down failed propType warnings in tests simply because there are so many tests.  We should consider overloading console.error in tests to throw if there are propType warnings.
Note, we have the consoleUtil to silence tests that intentionally need to test failed propType cases.  This allows us to tell console functionality to enable, disable, and disableOnce for any given tests.

I've added this code to tests.bundle.js as a TODO in #1428.  Once merged, it just needs uncommented and the broken tests fixed.


TypeError: str.indexOf is not a function

Cheers,
I use node-steam-tradeoffers, which use a long library
Today, I tried to use one function and had a trouble instead:
var Long = require('long');
function toSteamId(accountId) {
  return new Long(parseInt(accountId, 10), 0x1100001).toString();
}
toSteamId(someAccountId)

TypeError: str.indexOf is not a function
at Function.fromString (.../node_modules/long/dist/long.js:260:22)
at toAccountId (.../node_modules/steam-tradeoffers/index.js:374:15)

Can somebody help me with this?

Closing this issue for now as it hasn't received any replies recently. Feel free to reopen it if necessary!


Sidebar-v2 + Bootstrap (with header and container-fluid)

Hi,
Sidebar-v2 project is really awesome but I'm struggling when I try to combine the sidebar with Bootstrap using a fixed header and a container-fluid.
Here is an example : http://codepen.io/anon/pen/ALdBGR
I suppose the problem comes from using position: absolute; ! Is there an easy way to place the sidebar inside the container and limit the sidebar to the container ?
Thanks.

@jbelien it is definitely possible, but on first glance I'm not sure what you're doing wrong. Have a look at e.g. https://skylines.aero/flights/60985/ where we're doing something similar.

@Turbo87 : Thanks a lot ! I'll look at it 👍


STG95 Premium Files – Paid Burst IOPS/Bandwidth

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-storage-file-share


[Feature] Add support for Timestamp type for Substream Powered Subgraphs

Description
Enhancement Request: Timeseries Aggregations Support for Substreams
Doing timeseries within a substream can be quite cumbersome, so taking advantage of aggregations would greatly improve both development and performance.
If we are sending over entity changes from a substream, this functionality is currently not possible.
To use Timeseries aggregations, there are a few requirements:

The id field must be of type Int8
Must have a timestamp field of type Timestamp

The id field seems to be automatically set when the entity type is defined with timeseries: true, so that doesn't seem to be an issue. However, a field type of Timestamp is currently not supported, even after making adjustments to the substreams entity changes library.
I experimented with adding Timestamp to this library, and you can see those changes here: Substreams Sink Entity Changes - Add Timestamp.
With this change, you can now output a type of timeseries from the substream to graph-node:
{
  "name": "timestamp",
  "newValue": {
    "timestamp": "1680880739"
  }
}

However, this still doesn't seem to be enough. Here is the error produced when sending this from my substream:
Error: failed to process trigger: Failed to process substreams block: Entity MessageSent[0]: missing value for non-nullable field `timestamp`

It looks like graph-node doesn’t know how to decode this field type in the protobuf message, so it comes in as a blank field.
I believe graph-node needs to be updated in a similar way to the changes I made in the substreams entity changes library. This might be required somewhere around here:
graph-node substreams codec.proto.
I’d love to hear any feedback on this!
Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.
No response
Some information to help us out

[ ] Tick this box if you plan on implementing this feature yourself.
[X] I have searched the issue tracker to make sure this issue is not a duplicate.

More context on Timestamp with Substreams Powered Subgraphs
https://github.com/pinax-network/subgraph-antelope-transactions/issues/2
❌ Errors
Attempted different variances of BigInt/String and none of them are functional.

the value<PHONE_NUMBER> for field timestamp must have type Timestamp! but has type String
the value 2018-06-09T11:56:30Z for field timestamp must have type Timestamp! but has type String
the value<PHONE_NUMBER>000000 for field timestamp must have type Timestamp! but has type BigInt
the value<PHONE_NUMBER>000000 for field timestamp must have type Timestamp! but has type String

Hey @DenisCarriere the changes in my fork of substream entity changes https://github.com/Dirt-Nasty/substreams-sink-entity-changes/tree/add_timestamp remove these errors which I thought would have worked.  It modifies the types on the entity changes to include Timestamp but on the graph-node (receiving side) it doesn't know how to decode that type.  So technically modification is needed on both the substream library and graph-node and I was able to complete the substream side but I'm unable to experiment with graph-node as it would probably take me a good while to get graph-node up and running locally with a modified version.


Add High/Low Fee Warnings

High Fee Warning caused by a mistake

Zeplin: https://zpl.io/adZWLy5

High Fee because the network is congested

Zeplin: https://zpl.io/29rJ6dy

Fee too Low

Zeplin: https://zpl.io/V1Pm63k

Note that updated a few components:

I increased the font size to 15pt for the secondary row.

This component has changed to two rows.

https://zpl.io/b6qO6Wy
https://zpl.io/agwyXEA
https://zpl.io/VDeR6Yg

Created #2367 for tweaking font and layout


"Shading" randomly failed, where maybe the problem

I shade some jars like that:

assemblyShadeRules in assembly ++= Seq(
ShadeRule.rename("org.apache.curator.**" -> "mycurator.@1").inAll
)

When I launch the myassembly.jar on the cluster, it randomly failed (maybe on some particular nodes). It still load from org.apache.curator, not mycurator.**)
I couldn't figure out where the problem is?
Is this due to different version of scala, sbt or something else?

Have you checked the classpath of your process ? Is it possible there are some old unshaded jars on those nodes ?

Probably fix this one. Please see my PR: https://github.com/sbt/sbt-assembly/pull/376

Fixed in #376


[DO-368] Refactor current sidebar

Replace the current sidebar implementation as the leftmost sub-panel of the Resizable, and make it also resizable (no collapse handling yet) and persisting with Zustand.
Effectively, after this sub-issue is done, we have a three-column resizable layout.
From SyncLinear.com | DO-368

Canceling this issue as a different approach regarding the sidebar has been chosen (will be turned into a top menu bar).


The AI type is not saved

The game has two different AI types. When you create or load a game, each country is assigned an AI at random. The AI players should keep the same AI type after saving and loading.

I just checked and actually yes it is saved and it's loaded too!


Issues about ReservedItemSlotCore and ReservedWeaponSlot

Sorry, my statement when I posted was not very clear :(
The main issue is：
If the host has ReservedWeaponSlot installed, other players who have ReservedItemSlotCore but do not want to use ReservedWeaponSlot will also see a weapon slot on the right side of the screen.

Sorry, just to be clear, are we talking about the lack of a hotkey that specifically toggles to the reserved weapon slot because they don't have the mod? Or just the fact that they can't toggle their reserved slots in general?
If you know these people, could you just have them install the reserved weapons slot mod? Or could you have them go into their config and enable toggling the reserved hotbar slots rather than swap to them while holding?

If you know these people, could you just have them install the reserved weapons slot mod? Or could you have them go into their config and enable toggling the reserved hotbar slots rather than swap to them while holding?

If I knew other players, of course this problem could be solved.
But if I were not the host, it would still bring a terrible gaming experience, and I couldn't completely avoid playing in a stranger's room. If a strange host installs ReservedWeaponSlot, this problem will plague players like me who do not want to use ReservedWeaponSlot.

Furthermore, it is well known that not everyone has the ability to independently change the config, so I sincerely hope that this issue can be resolved ：)

What are your thoughts on the Core mod adding hotkeys, such as alt+1, alt+2, etc, to swap/toggle to each reserved weapon slot, and maybe doing it this way would toggle that slot so you couldn't have to hold down alt to stay on that slot until you swap off that slot?
I'm all open for suggestions. I do understand how that could be frustrating.

I think even if this issue doesn't happen, your proposal still attracts me a lot :)

So is there a way to solve the situation indicated by the arrow?

Okay, I might have misunderstood. So if you do not have the weapon slot mod installed, but the host does have it, it will normally give you that slot.
Were you not wanting to have that slot if you don't have the mod?
If this is the case, then it's not something I want to support, mainly because the reserved item slots are a part of the player's inventory, and the inventory should stay the same size across all clients as to not cause any errors or desynced items.
When I have time, I would like to think of a decent solution for this, though.


Tensorflow building error

I am trying to build tensorflow with this statement "bazel build -c opt //tensorflow/examples/android:tensorflow_demo"
the WORKSPACE is
`android_sdk_repository(
name = "androidsdk",
api_level = 23,
#build_tools_version = "25.0.2",
build_tools_version = "26.0.1",
path = "C:/Users/ST/AppData/Local/Android/Sdk",
)
android_ndk_repository(
name="androidndk",
path="C:/Users/ST/Downloads/Tensorflow_Compile/android-ndk-r12b",
api_level=14)
`
but I got an error message:
"ERROR: C:/msys64/tmp/_bazel_st/_ztysx-6/external/protobuf_archive/BUILD:93:1: C++ compilation of rule '@protobuf_archive//:protobuf_lite' failed (Exit 3).
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Cannot create temporary file in C:\WINDOWS: Permission denied
Target //tensorflow/examples/android:tensorflow_demo failed to build
Use --verbose_failures to see the command lines of failed build steps.
____Elapsed time: 5.465s, Critical Path: 0.63s"
I am using Windows 10, bazel 0.5.4, python 2.7. Is there anyway to fix this problem?

@petewarden will the android demo build work on Windows?

According to the doc for Android examples, Windows build is not supported via Bazel:

NOTE: Bazel does not currently support building for Android on Windows. Full support for gradle/cmake builds is coming soon, but in the meantime we suggest that Windows users download the prebuilt binaries instead.

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.


helm repo add now fails in v3.3.2 and v3.3.3

Description
The command helm repo add <name> <url> fails as it is no longer idempotent.  This worked fine in version v3.3.1 and earlier.  It now fails in v3.3.2 and v3.3.3.  This is a breaking change that has broken automation relying on helm and tools helmfile.
Steps  to Reproduce
helm repo add jaegertracing https://jaegertracing.github.io/helm-charts
helm repo add jaegertracing https://jaegertracing.github.io/helm-charts

Expected Results
"jaegertracing" has been added to your repositories

I expected that the command would be idempotent and would not fail.  As the repository was already added, it would not need to be added again, and thus should to exist with an error.
Actual Results
Despite the repository already in the desired state, helm exits with an error, even though there is no error.  helm will exit with 1 indicated an error.  This destroys any automation scripts and tools like helmfile to function correctly.
Error: repository name (jaegertracing) already exists, please specify a different name

Output of helm version:
version.BuildInfo{Version:"v3.3.3", GitCommit:"55e3ca022e40fe200fbc855938995f40b2a68ce0", GitTreeState:"dirty", GoVersion:"go1.15.2"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T23:30:39Z", GoVersion:"go1.14.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.9-eks-4c6976", GitCommit:"4c6976793196d70bc5cd29d56ce5440c9473648e", GitTreeState:"clean", BuildDate:"2020-07-17T18:46:04Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):

EKS (K8S v1.17.9-eks-4c6976)

@darkn3rd
You can add --force-update option when run helm repo add.

Hi, @darkn3rd - as explained in https://github.com/helm/helm/releases/tag/v3.3.2:

One breaking change was made: The default behavior of helm repo add was changed: It no longer overwrites repositories by default. The flag --force-update was added to helm repo add to allow a repo to be overwritten. The flag --no-update still exists, but does nothing. This change accords with the Helm policy for allowing minor breaking changes in the name of security.

@bridgetkromhout I saw that comment shortly after I wrote this.  This can be both secure and idempotent at the same time.  Both of these are not mutually exclusive.  Simply, if the repo exist, don't do anything, don't error when there is no error, as this breaks things.
Upstream automation and tools, such as helmfile, now fail.

@yxxhero Thanks for the tip.  I can do that to return to the behavior, but then in v3.3.1 and earlier, doing that will cause this:
$ helm repo add --force-update jaegertracing https://jaegertracing.github.io/helm-charts
Error: unknown flag: --force-update

This will break upstream automation and tools like helmfile, as now they'll have to test the version of helm and mutate the behavior.
Helm should just not do anything if the repo already exists, not create an error where no error.  If it was idempotent, it would also be secure in that manner, and the behavior as far as being in the desired state, would be similar.  The behavior would not break things.  The --force-update for other use cases, but for my use case, I just need the not updating a repo to not exit with an error, because there's no error.

Just wanted to add this behavior violates the principal of least surprise, as it diverges from the behavior inherent with countless other package managers that are idempotent in this aspect: chocolatey, homebew, apt-get, yum, emerge, ports, aur, pacman, etc.

Absolutely agree with @darkn3rd - it was even released as a bug-fix. We can do better!

Hmm... We could just return exit code zero if the same repo is attempted to be added twice. Since it isn’t changing the information that’s already there, that should resolve the issue without working around the security controls we had to put in place
What do you think about that?

That would work.

Noted. Thanks for the feedback.

First, let me apologize for the lack of breaking change being bubbled up. It was noted on the pull request to fix the security issue (the only time we will intentionally make a breaking change is security issues) but we missed bubbling it up.
Second, I put up a PR to fix this issue at #8777. Can you please take a look and see if this will work.

I am tentatively marking this as a bug.

Thank you all for supporting this. ❤


data:Drabzit

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

You can check out mine as an example.

Great collaboration everyone 👍


Implement NPL agent unification.

Unify agent behavior across Linux and Windows. Linux agent should support
allocating different nodeports for different protocols when the podports are the same.
Update port allocation related unit tests.
Enable windows e2e test.
Delete unused functions.

Signed-off-by: Shuyang Xin<EMAIL_ADDRESS>

/test-all

Codecov Report

Merging #3936 (ebe6bd9) into main (b2c245c) will decrease coverage by 28.67%.
The diff coverage is 68.08%.

@@             Coverage Diff             @@
##             main    #3936       +/-   ##
===========================================
- Coverage   64.16%   35.49%   -28.68%
===========================================
  Files         293      380       +87
  Lines       43223    56102    +12879
===========================================
- Hits        27735    19912     -7823
- Misses      13256    34234    +20978
+ Partials     2232     1956      -276

Flag
Coverage Δ

integration-tests
35.15% <ø> (?)

kind-e2e-tests
35.63% <68.08%> (-14.92%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../agent/nodeportlocal/portcache/port_table_linux.go
54.27% <65.11%> (-3.43%)
:arrow_down:

pkg/agent/nodeportlocal/portcache/port_table.go
60.71% <100.00%> (-6.79%)
:arrow_down:

pkg/util/sets/int32.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ipfix/ipfix_process.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ipfix/ipfix_registry.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/controller/networkpolicy/crd_utils.go
0.00% <0.00%> (-92.60%)
:arrow_down:

.../agent/flowexporter/priorityqueue/priorityqueue.go
0.00% <0.00%> (-92.41%)
:arrow_down:

pkg/ipfix/ipfix_intermediate.go
0.00% <0.00%> (-90.91%)
:arrow_down:

...lowaggregator/clickhouseclient/clickhouseclient.go
0.00% <0.00%> (-90.77%)
:arrow_down:

pkg/agent/controller/networkpolicy/priority.go
0.00% <0.00%> (-90.72%)
:arrow_down:

... and 319 more

/test-all

/test-all
/test-windows-all

/test-all

/test-all
/test-windows-all

/test-all
/test-windows-all

/test-all
/test-windows-all

/test-e2e

/test-windows-e2e

/test-windows-e2e

/test-windows-all

/test-windows-proxyall-e2e

/test-all
/test-windows-all

/test-all
/test-windows-all

Hi @antoninbas , do you have more comments for this PR?

/test-all
/test-windows-all

/test-all
/test-windows-all

/test-windows-e2e
/test-windows-proxyall-e2e

/test-windows-proxyall-e2e

/skip-integration tested manually


Don't clone old value on dict_entry_get

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
Attention: Patch coverage is 97.64706% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (ac0e5ca) to head (fcabf6e).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

src/libfuncs/felt252_dict_entry.rs
97.64%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   82.44%   80.67%   -1.78%
==========================================
  Files         117      107      -10
  Lines       34071    29235    -4836
==========================================
- Hits        28091    23585    -4506
+ Misses       5980     5650     -330

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Test in LXC

Nice package !
Have you considered running tests in a LXC guests ? LXC may be a better tool because it does distribution isolation, rather than process isolation: it runs a real init as PID 1.
You could run something like this to create the LXC guests the test needs from the test inventory file:
- hosts: localhost
  vars:
    LXC_PATH: /var/lib/lxc  # change to /tmp to run in ram with -e

  tasks:
  - name: Configure container
    lxc_container:
      name: '{{ item }}'
      template: debian
      state: started
      template_options: --release wheezy
      lxc_path: '{{ LXC_PATH }}'
    with_items: '{{ groups["all"] }}'

  - name: Ensure .ssh directory exists in container
    file:
      path: '{{ LXC_PATH }}/{{ item }}/.ssh'
      state: directory
      mode: 0700
    with_items: '{{ groups["all"] }}'

  - name: Add your SSH key in the container
    copy:
      src: '{{ lookup("env", "HOME") }}/.ssh/id_rsa.pub'
      dest: '{{ LXC_PATH }}/{{ item }}/.ssh/authorized_keys'
      mode: 0600
    with_items: '{{ groups["all"] }}'

Then you could execute your playbooks from the host.
Testing on multiple hosts may be useful for more complicated tests such as orchestration tests.
Thoughts ?

@jpic Molecule can do this: https://molecule.readthedocs.io/en/latest/configuration.html?highlight=LXC#lxc


Miscellaneous plot fixes

Smaller bug fixes along with tests to avoid regressions.

[x] Fixes https://github.com/ioam/holoviews/issues/1757, https://github.com/ioam/holoviews/issues/1921 and https://github.com/ioam/holoviews/issues/2347

Looks good. Happy to merge when the tests are green.

The pr build is now passing. Merging.


Bump elixir sense

Fixes #30 and brings in a host of other improvements/enhancements (although we need some updates to make full use of the elixir_sense improvements such as #39)
Testing this locally right now and it is working well so far.

This has been working well locally and I really want to get the travis-ci and test fixes in so I'm going to go ahead and merge :+1:


Mega Evolution Pokemons Data is not there

Mega Evolution Pokemons data like Mega Rayquaza,Gigantmax Haunter etc. data is not present.

You can find them in pokemon forms/varieties
Example for Rayquaza
https://pokeapi.co/api/v2/pokemon-species/384
https://pokeapi.co/api/v2/pokemon/10079/


initial try at HALE gas powered model

This is a model for a high altitude vehicle that uses gas as it's energy source.  Breguet range is the underlying model for time on station.

Hey @whoburg I added a sketchy power vs. weight that we made here (based on small honda engine models): https://docs.google.com/spreadsheets/d/15_bX0Ub71fxrkyj72nUteMgjKj_mJw72Qi2RW3fag0I/edit?usp=sharing.
eta_t is my throttle variable because I figured that P_shaft would only be some percentage of the max power, which is what we graphed.
What do you think of this approach? Should we expand our engine database to include higher hp engines? Would appreciate any help.

@whoburg just added a wind model and update the power weight curve.  This could be useful to look at in class today.  I'm send the files that have the wind curves and power vs weight curves to Oren, Reo and Kelly

(great to see these!)

This is great! Added a commit moving the model to a .py file for better tracking of diffs in git; there's also a .ipynb alongside to run the model.

Also @mjburton11 I would recommend looking at the data sheet Prof. Drela sent for gas engine sizing.


Desktop notifications wont work even with new install

My Setup

Operating System: Win 10
App Version: 2.15.1 and tried all version past 6months
Installation type:  exe

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description

I'm a member of one hobby group where timely desktop alerts are very important. Desktop notifications stopped working 6months ago, settings doesn't help, updates doesn't help, different chat channels doesn't make any difference. I don't get @here or @all notifications. Task bar turns to orange but no sound or popup. I have checked windows settings and allowed all notifications. My SSD died and I MADE FRESH WIN 10 INSTALL with latest app versions and updates but still no luck. What can I do?
Current Behavior

No sound or pop-up alert, task bar turns to orange. From user settings, test notification button works and gives me pop-up. Earlier with old versions, this didn't work (if it gives any clue for solution).
Expected Behavior

Pop-up alert with sound when @here is mentioned in my channel.
Attached is image of settings bar:

same issue:
App Version : 2.15.1
Windows 10 / 1809 Build 17763.404
i can confirm that when i click on "Test Desktop Notification" a notification will show but no other notification, notifications doesn't work anymore.

Can confirm - we have a number of users who aren't getting audio notifications (consistently, anyway).  Total re-installation after removing Electron seem to work on a very temporary basis.
macOS desktop/laptop/mobile platforms seem to be most affected.

Can confirm. A lot of users are complaining about this.

Similar issues #1058 and #1138

I can say we are having this issue too. It started with the last couple of updates. I didn't update between the first 2.13.x and the latest, then updated and have the issue. I have my whole team also reporting similar issues, across Windows, Linux, and Mac systems. Almost nobody is getting notifications at all and it is actually killing productivity. Not sure what info could help. Not really a desktop application developer. I have at least a dozen reports of this issue from my staff.

on version 2.15.0 , 2.15.1 , 2.15.2 we do not have notification, it seems that this problem appears from time to time.

@rabbithats Mobile platforms depend exclusively on Push notifications, configured on server.

@rabbithats Mobile platforms depend exclusively on Push notifications, configured on server.

Right, our admins are working with our rocketchat server to tackle those particular issues.  I should've specified that our users with notification issues are exclusively Desktop/Laptop, v2.15.1.
We're updating users to v2.15.2, but it's too early to tell if there are positive returns, plus silence can sometimes be a sign of normal function, so we'll see.

No notifications on some Windows 10 Pro clients.
RocketChat-electron: 2.15.0; 2.15.1; 2.15.2;
Server: 0.74.0
Few users reported that they are not getting notifications after update from 2.14.7 to 2.15.1. I updated to 2.15.2 on one of the computers but it didn't help - still no notifications.
I had to downgrade client to 2.14.7 (with removing user data).
I discovered that on fresh Windows 10 install and RocketChat v2.15.2 notifications are working like a charm.

@c1hd did you tried manually removing the user files when upgrading to 2.15.2 on the problematic computers ?
Thanks

@franckadil unfortunately not, but I think it could work (everything works on fresh install, so problem might be there). We just ran script through GPO to install 2.14.7 silently - I think it doesn't remove user files, but since we downgraded no problems were reported.

@c1hd Thank you, a ticket have been reopened I hope this gets fixed son, I'll do some testing.
https://github.com/RocketChat/Rocket.Chat.Electron/issues/1195#event-2305672308


Debates section land on News

Everything is in the title, the default landing page when hitting the landdebate section should be http://landportal.info/debate/news

done