Hi @awitherow, in an earlier version of https://farbenmeer.de we also used Next.js with Next-CSS. React-Slick requires fonts and icons in it's default-theme that webpack does not resolve by default. That's likely where your error comes from.

Hi @awitherow, in an earlier version of https://farbenmeer.de we also used Next.js with Next-CSS. React-Slick requires fonts and icons in it's default-theme that webpack does not resolve by default. That's likely where your error comes from.
You can "fix" this by adding URL-Loader for these files to webpack in next.config.js like this:
const withCSS = require('@zeit/next-css')

module.exports = withCSS({
  webpack: function (config) {
    config.module.rules.push({
      test: /\.(eot|woff|woff2|ttf|svg|png|jpg|gif)$/,
      use: {
        loader: 'url-loader',
        options: {
          limit: 100000,
          name: '[name].[ext]'
        }
      }
    })
    return config
  }
})

and of course install url-loader: $ yarn add --dev url-loader.
Originally posted by @pex in https://github.com/akiran/react-slick/issues/842#issuecomment-385378629
When i add  cssModuled:true, it stops working

Danke dass ihr habt das mitgeteilt @Mhmdabed11 👍


Sysrc append treats multiword-values as multiple single values

Sysrc treats word combinations like addm em0 and addm epair0a etc. as multiple single words.
E.g. the actions:
- name: Add jail to vnet
  sysrc: name="{{ item.name }}" value="{{ item.value }}" state="{{ item.state }}"
  loop:
    - { name: ifconfig_bridge0, value: "addm em0", state: append }
    - { name: ifconfig_bridge0, value: "addm epair0a", state: append }

What I want to achieve is ifconfig_bridge0="addm em0 addm epair0a"; however both sysrc-CLI and the sysrc module create ifconfig_bridge0="addm em0 epair0a", which obviously does not have the intended effect (epair0a is not attached).
Is there any way/workaround to append multi-word values to an existing key?

A workaround, though not so pleasant at the moment, would be to combine them independently of sysrc.
- set_fact:
    addm_ifs:
      - em0
      - epair0a
- sysrc:
    name: ifconfig_bridge0
    value: "{% for if in addms_ifs %}addm {{ if }} {% endfor %}"

I'll take a look at how this could be supported in the module, I'm surprised this hasn't been fixed in sysrc-CLI itself.
Do you happen to know if the arguments to ifconfig_bridge are required to be in a certain order? If they are I'm wondering if it'd be worth it to create a module that deals specifically with creating the bridge interfaces.

A workaround, though not so pleasant at the moment, would be to combine them independently of sysrc.
- set_fact:
    addm_ifs:
      - em0
      - epair0a
- sysrc:
    name: ifconfig_bridge0
    value: "{% for if in addms_ifs %}addm {{ if }} {% endfor %}"

I'll take a look at how this could be supported in the module, I'm surprised this hasn't been fixed in sysrc-CLI itself.
Do you happen to know if the arguments to ifconfig_bridge are required to be in a certain order? If they are I'm wondering if it'd be worth it to create a module that deals specifically with creating the bridge interfaces.

Afaik they don't need to be in a specific order as long as certain combinations are satisfied likeaddm INTERFACE or inet IP. However, a network-specific module might indeed be a better/cleaner solution…
My current workaround is to configure the interfaces using the exec.prestart and exec.poststop; however that of course is jail specific 😅

Afaik they don't need to be in a specific order as long as certain combinations are satisfied likeaddm INTERFACE or inet IP. However, a network-specific module might indeed be a better/cleaner solution…
My current workaround is to configure the interfaces using the exec.prestart and exec.poststop; however that of course is jail specific 😅

Outside of the work around I presented for building the value I'm not sure this belongs in the sysrc module to "template" an array that way.
FWIW, The sysrc module has been moved to community.general.sysrc.


🐣 Add RHEL 8.3 test cases

Created with:
./tools/test-case-generators/generate-test-cases \
  --distro rhel-8.3 --arch x86_64 --store .osbuild/ \
  --output test/cases/

Signed-off-by: Major Hayden<EMAIL_ADDRESS>

So, I wonder about this. We are now pointing to the latest nightly in the test case, so it will get out-of-sync as soon as a new nightly is released.

@dvdhrm this sounds like a job for fedmir.

There's an 8.3.0 option, too. It seems there is some compose shuffling happening today.

Nevermind. The redhat-release file for 8.3 is not signed yet.


plrust-trusted-pgrx v1.1.2 missing from crates.io

Hi,
the latest release (v1.1.2) seems not to have got to crates.io
this breaks the installation instructions, at the 'Try it out' step I got this error:
postgres=# CREATE OR REPLACE FUNCTION plrust.one()
    RETURNS INT LANGUAGE plrust
AS
$$
    Ok(Some(1))
$$;
ERROR:
   0: `cargo build` failed

Location:
   /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/convert/mod.rs:726

`cargo build` stderr:
       Updating crates.io index
   error: failed to select a version for the requirement `plrust-trusted-pgrx = "=1.1.2"`
   candidate versions found which didn't match: 1.1.1, 1.1.0, 1.0.0
   location searched: crates.io index
   required by package `plrust_fn_oid_5_24607_3204045602816 v0.0.0 (/tmp/plrust_fn_oid_5_24607_3204045602816)`

Source Code:
   #![deny(unsafe_op_in_unsafe_fn)]
   pub mod opened {
       #[allow(unused_imports)]
       use pgrx::prelude::*;
       #[allow(unused_lifetimes)]
       #[pg_extern]
       fn plrust_fn_oid_5_24607<'a>() -> ::std::result::Result<
           Option<i32>,
           Box<dyn std::error::Error + Send + Sync + 'static>,
       > {
           Ok(Some(1))
       }
   }
   #[deny(unknown_lints)]
   mod forbidden {
       #![forbid(deprecated)]
       #![forbid(implied_bounds_entailment)]
       #![forbid(plrust_async)]
       #![forbid(plrust_autotrait_impls)]
       #![forbid(plrust_env_macros)]
       #![forbid(plrust_extern_blocks)]
       #![forbid(plrust_external_mod)]
       #![forbid(plrust_filesystem_macros)]
       #![forbid(plrust_fn_pointers)]
       #![forbid(plrust_leaky)]
       #![forbid(plrust_lifetime_parameterized_traits)]
       #![forbid(plrust_print_macros)]
       #![forbid(plrust_static_impls)]
       #![forbid(plrust_stdio)]
       #![forbid(plrust_suspicious_trait_object)]
       #![forbid(soft_unstable)]
       #![forbid(suspicious_auto_trait_impls)]
       #![forbid(unaligned_references)]
       #![forbid(unsafe_code)]
       #![forbid(where_clauses_object_safety)]
       #[allow(unused_imports)]
       use pgrx::prelude::*;
       #[allow(unused_lifetimes)]
       fn plrust_fn_oid_5_24607<'a>() -> ::std::result::Result<
           Option<i32>,
           Box<dyn std::error::Error + Send + Sync + 'static>,
       > {
           Ok(Some(1))
       }
   }

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

I can work around it with the steps Choosing a different plrust-trusted-pgrx dependency at compile time, but this step caveats:

Generally, changing the plrust-trusted-pgrx dependency is only useful for PL/Rust development and CI, not for production deployments,

Oh geez. This is my mistake.  I will get it published here in a few minutes.  Thanks for understanding.

Done.
We need to a) write out our release procedure and b) have some kind of CI job that tests this particular scenario. We do have CI jobs that build .deb packages from the latest tagged release but they don't also run the test suite.
Thanks again!


Need more thorough tests

Some basic components have decent unit tests, but the most complicated parts (the connection state and I/O loop) have none. Options:

Integration tests that require a rabbit server
Unit tests that use mock streams

May make sense to pursue both of these for different kinds of tests.

Been running in production for six months - testing still isn't ideal but I don't think there are any glaring issues.


Sync with Triton API

Hi,
Some changes I noticed in the latest Triton version.
Cheers,
Liblor

@aguinet i'm ok with this PR :)


build: Align on tools from .versions also for the build / test workflow

Blocked by https://github.com/oss-review-toolkit/ort/pull/7883.


Argo jupyter scheduler

Reference Issues or PRs
Fixes #436

What does this implement/fix?
Updates the tutorial for jupyter-scheduler.
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[x] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist
Text styling

[x] The content is written with plain language (where relevant).
[x] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[x] All links describe where they link to (for example, check the Nebari website).
[x] This content adheres to the Nebari style guides.

Non-text content

[x] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[x] If there are emojis, there are not more than three in a row.
[x] Don't use flashing GIFs or videos.
[x] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

I have suggested minor changes. Looks good otherwise.

Thanks @pt247 .  I accepted your suggestions and made only minor edits on top of them.  If you like them, it's ready to merge.


Added repository-progress-view on startup and fixes description issues

Description

Changed commit #44 which only includes progress (and changed style slightly)
On startup (nearly everytime on F5) showed previously just "0" which changes to "X %" on load. Now it shows "0 %" at the start
Fixed some format (theres a lot more to fix) to make them easier to find / edit
Also checked mobile-view and it does fit well
This change does not decrease performance  (or its not noticeable)

Other changes

Added fix for description "null" if no description is given on a repository (closes #96)

Meh, I should do my change in
function repoDescription(repo) {
desc = repo.description;
return desc;
}
I will add another change for that. But for now it works.

@Nitair hmm, i was notified that the page isn't building:
The page build failed for the `master` branch with the following error:
unable to build page. Please try again later.
For information on troubleshooting Jekyll see:
  https://help.github.com/articles/troubleshooting-jekyll-builds

When I pull down master, run $ jekyll serve, and load it in a browser, it just fine, any ideas?

@stevemart It seems its a general issue from GitHub right now. I created a new repo with just index.html with content Hello World and got

Your site is having problems building: unable to build page. Please try again later.

@Nitair 👍 awesome

@stevemart


Roadmap/versioning

There is a change that I'm interested in, namely #526. Will it make into some new version of v7.x.x or will it be part of v8.x.x?
I ask because I'd like to have some version number that I'll be able to target in our own software. mqtt_cpp is the library that we will use, as it seems quite mature, performant and easy to use, the only thing I miss is some API/versioning stability. Currently this part seems somewhat neglected, page releases has v.7.0.0 as last version, wiki mentions 6.0.2 as last release and I see here that v7.x is basically ready and v8.x in the making.
None of the latter pages mentions #526 or #528 (merge of #526) as part of it.

I will update wiki and related pages later.
The project page is not well maintained, so far.
Let me explain the current status.
Here is the release policy:
The latest release is v7.0.0.
Until breaking change is merged, then master is for v7.x.
If a breaking change is merged, then master is for v8.0.0. The current master is for v8.0.0. (Version text should be updated but not done yet.)
If a serious bug is reported and fixed then the fix will be backported to v7.x.
#526 and #528 are for v8.0.0.

Updated https://github.com/redboltz/mqtt_cpp/wiki/News.
Added https://github.com/redboltz/mqtt_cpp/wiki/Versioning-Policy.
Send #533. It is for updating README.md. It doesn't mean v8.0.0 will release immediately.

Thanks, this answers my questions. Have you considered merging small fixes into older releases? I'm not sure how viable it is, I think that this would cause problems only if client/server was exposed directly from .so/.dll, but I might be wrong.

mqtt_cpp offers no ABI stability. As a header only library, the only stability it offers on non-major releases is end-user API stability.

Sure, I don't see why not.
@redboltz has been very responsive on accepting PRs from me. He and I have seriously evolved the codebase over the last 6 months since I discovered it and started using it for my current work project.

Which means that if I wanted to backport to e.g. v7.x.x something that only enhances API and does not break it and I'd provide patch/merge request then it will be likely accepted?

I just pushed v7.x branch for backporting. You can create PR for the branch.

Thanks, I will look through differences between these branches and try to prepare a PR.


Should I write all of the folder structure and files' content using Filer?

@humphd
I want to navigate through my local filesystem folder.
so what should I do? The only way I got from this repo, is to create folders/files and write files' content using Filer.
or is there any other way?
please let me know if I am missing something wrong.
thank you.

See https://github.com/humphd/browser-shell, which is everything I know about this.
I'm not actively working on this project anymore, so that demo and code is probably where I'd start.

@humphd
okay, I got it. thank you.


Add ConfigMapping annotation for configuration

Fixes #218

cc: @WilliamKSilva

Sorry @mcruzdev , could you please rebase this PR since I mrege https://github.com/quarkiverse/quarkus-dapr/pull/219


osm install --set arguments should override default flag values

Bug description:
If the --set flag is used for osm install but the value being passed in already has a default since it has its own flag for install, the argument passed to --set should override the default.
More details: https://github.com/openservicemesh/osm/pull/2784/files#r591035725
Affected area (please mark with X where applicable):

Install                    [X]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]

Expected behavior:
osm install --set="OpenServiceMesh.enablePrivilegedInitContainer=true" --set="OpenServiceMesh.envoyLogLevel=info"
The above command should override the envoyLogLevel
Steps to reproduce the bug (as precisely as possible):
osm install --set="OpenServiceMesh.enablePrivilegedInitContainer=true" --set="OpenServiceMesh.envoyLogLevel=info"
How was OSM installed?:
osm CLI
Anything else we need to know?:
Environment:

OSM version (use osm version): 0.8.0
Kubernetes version (use kubectl version): 1.18
Size of cluster (number of worker nodes in the cluster): 2
Others:

This behavior is intended, though I understand it's not ideal.
The help text for the flag does address this behavior somewhat:
--set stringArray                         Set arbitrary chart values not settable by another flag...

--set doesn't override the other flags because currently the validation for those values is tied to the CLI flag. The current behavior ensures that validation can't be bypassed using --set.

Yeah, that should work. My only concern is the error messages will probably say something like OpenServiceMesh.envoyLogLevel not valid... if a user does osm install --envoy-log-level=invalid. Usually the mapping between osm install flags and values is easy enough to figure out, but I could see that being unclear.

Can we make the usage of chart param specific flags consistent with either using the CLI flags or using --set and ensuring we can validate every param passed to --set? There needs to be a clear guidance on when to use a CLI flag vs --set. Otherwise this is going to introduce more inconsistency in the code and make it hard to reason. I don't believe we should be providing multiple ways to set the same chart param, its just harder to maintain and reason.

Commit bff18e72c702478ee588433547d80b17240d8e83 removed custom CLI flags for the install commands in favor of using --set, so this issue should be resolved.


Can't access payload of pull_request.opened

Bug Report
Current Behavior
When listening to events of pull_request.opened it is not possible to access the payload object due to a typing problem
app.on("pull_request.opened", async (context) => {
    context.payload.pull_request.number; // accessing the payload throws the error below
});

Property 'number' does not exist on type 'never'.
  The intersection 'PullRequest & { state: "open"; closed_at: null; merged_at: null; merge_commit_sha: null; active_lock_reason: null; merged_by: null; }' was reduced to 'never' because property 'closed_at' has conflicting types in some constituents.ts(2339)

Expected behavior/code
Expected to work as other pull request events like edited.
Environment

Probot version(s): 12.3.1
Node/npm version:  Node 18.16.0/npm 9.5.1
OS: Ubuntu 22.04
Typescript: 4.9.5

Do you have the strictNullChecks option enabled in your tsconfig.json?
That option is required to use the Webhook payload types

Do you have the strictNullChecks option enabled in your tsconfig.json?
That option is required to use the Webhook payload types

That seems to solve the problem. Is documented anywhere? I did not know that this ts config was required.

It doesn't seem to be documented for Probot itself.
It is documented in the Octokit repos

Duplicate of https://github.com/probot/probot/issues/1581


Embedded multi-value fields in a resource component

The configuration components and resource components in a module configuration should be either of the "General Configuration" schema, or a custom schema with a flat list of text fields.
When I tried to have a multivalue embedded field in a custom resource component I noticed that the settings page has published the field in a weird way, the value of the field is an object id. This is what I found in the [modulename].json
    "interestAreas": "Tridion.ContentManager.ContentManagement.Fields.EmbeddedSchemaField"

I guess that this means that the TBB rendering this file is not checking the field type at all. It should handle the situation and not render the object id.
I think it is best when the Settings page would raise an publishing error whenever there are unsupported fields in the configuration or resource components.

Internal Issue ID (for tracking purposes): CRQ-12804


Improve build and add size badge

FYI: Badge isn't working on this branch because it's getting the file from master, and the master branch doesn't have the minified version yet

@cauealves @willianjusten ref lyef/react-base-component#7
If this is ok, I'll replicate this PR to the base rep as well

Nice <3


super.disconnectedCallback() is no longer present

Description
super.disconnectedCallback() having been removed from LitElement puts pressure on the element developer to make a clear decision as to how to address the possible presence of this method at various extension and mixin levels. Further, it makes for the possibility that there would need to be a future breaking change in LitElement where core functionality needed in this callback.
Live Demo
https://glitch.com/edit/#!/five-latex?path=index.html:39:50
Steps to Reproduce

Create an element
Add a disconnectedCallback method.
Call super.disconnectedCallback() in it.
Disconnect the element and see the error.

Expected Results
No error. Or clear documentation of the approach to this.
Actual Results
Uncaught TypeError: (intermediate value).disconnectedCallback is not a function
at HTMLElement.disconnectedCallback ((index):25)
at (index):36
Browsers Affected

[x] Chrome
[x] Firefox
[x] Edge
[x] Safari 11
[x] Safari 10
[x] IE 11

Versions

lit-element: ^0.6.0
webcomponents: latest

Thanks @Westbrook.  I've never used disconnectedCallback(), will you explain how it's used and when to use it?  And If it's needed, why in the heck was it removed do you thihnk?

@aadamsx disconnectedCallback() is the lifecycle method supplied by the browser to do work when a custom element is removed from the DOM. Generally, I use it for things like removing event listeners I may have added to elements outside of the scope of the template for my component, disconnecting IntersectionObservers, or other long running interactions with the DOM or thread that I'd applied imperatively.
For the most part, you don't need a disconnectedCallback so in the move from https://github.com/Polymer/polymer/blob/master/lib/mixins/properties-mixin.js (which applied it in a protected manner so as not to overwrite any application is was mixed into) to an all internal lit-element lead to it likely got forgotten. It's possible that this is the correct case, and this should simply be documented as such, however that would mean that were lit-element to want to use this callback to do something later, there would be a breaking update required.
To prevent the need for a breaking update, I've submitted a PR to apply a blank disconnectedCallback to lit-element, a change that was brought up by Justin in the Slack channel when discussing this context. There may be some extra comments of TS magic that I missed, but if it's agreed to be the right path forward, hopefully it's quick to be merged.

Yeah, this was an oversight in version 0.6. I think it makes sense to add back for the reasons stated. (PR welcome)

Happy to help @sorvell #213 is looking forward to your review. I have a note there as to a possible alternate approach based on technique in properties-mixin.js and look forward to seeing this back in the repo!

I've been unsubscribing my observables in disconnectedCallback :/ does this mean that they're never actually being unsubscribed? :/

@cstsortan Currently, if you are using this directly, you should not have any issues. disconnectedCallback is provided by the specification as a lifecycle method and both native and polyfilled implementations of custom elements give access to it.
The change outlined here would support users moving from older version of lit-element where there was an instance of disconnectedCallback that could be accessed via super.disconnectedCallback() for whom the move to 0.6.0 will have caused an error due to the removal of that instance. Further, it would prepare for adding functionality at this part of the life cycle in the future without additional breaking changing.


Indexed included modules on namespaces

Motivation
Resolves second point of #1333
This changes index included modules of all Namespaces, including Class and Module nodes.
Implementation
Each time a class or module is visited by the collector, we instantiate a new visitor that only visits its inmediate nodes (depth 1 of the tree), looking for CallNode that match the include method. The collector has an index of all the included modules to keep track of all the modules included for a singe entry. Then pass this values to the Namespaces nodes. Because its passed by reference and because it's a Set data structure, the modules are propagated and not repeated.
Automated Tests
Tests where added in lib/ruby_indexer/test/classes_and_modules_test.rb to cover different cases.
Manual Tests
Test indexing the same repo and does not crash.

Also a include method could be called from different redefinitions of the class, for example if i write
module Foo
end

class Bar
   include Foo
end

class Bar
   include Foo
end

The ancestor array will contain the Foo entry only once and not twice. That's why i thought a Map data structure is more suitable than an array because the way ruby add included Modules to the ancestors chain

You're right in your assessment. However, we need to limit what we support since Ruby allows you to do crazy stuff that's not easy to detect statically.
For the case of overriding include, we'll simply not support that. Overriding such fundamental parts of the language, like include, extend, public, private can lead to a lot of headache and it's frankly not good practice.
For the case of dynamic inclusion, like your example of including something from a method, that's simply not possible to support. Imagine you have this scenario
module Bar
  def baz; end
end

class Foo
  def dymamic_include
    include Bar
  end
end

foo = Foo.new
foo.baz # This invocation of `baz` is invalid and leads to a `NoMethodError`
foo.dynamic_include
foo.baz # This invocation of `baz` is valid and points to `Bar#baz`

This is very difficult to support without a type system. Even with a type system, it would still be really hard to do this in a performant way. Imagine that you could have a much more complicated structure than that one, including multiple ancestors, conditionals where the module is only included in one branch, etc. It becomes too complex to support for little benefit.
We'll move forward with only supporting the non dynamic includes and considering that they are not overridden.

Ok, with the simplification you provide i can simplify the implementation to support just simple includes to the ancestors chain. I will be working on that if you like.

@vinistock There is the implementation we talked about, also added a inner test class to check that the @current_owner works correctly in the inner classes when using the collector. I will be looking for any comments.

Thanks for the feedback!, Just pushed the corrections and added support for ConstantPathNode excluding dynamic Constant Path Node references as you sugested.


Android applications silently fail without explicit internet permissions.

Because of the nature of the OSVR server client applications on Android require internet permissions.
If users don't explicitly enable internet permissions their applications will silently fail. This can be remedied by creating a minimal manifest.xml with the correct uses-permission tag in Assets->Plugins->Android. Unity will automatically merge the manifest files when building.

Can also be remedied by what's sometimes called a combined server which is
a server linked with the client.
On Fri, Apr 1, 2016, 4:31 PM Chase Cobb<EMAIL_ADDRESS>wrote:

Because of the nature of the OSVR server client applications on Android
require internet permissions.
If users don't explicitly enable internet permissions their applications
will silently fail. This can be remedied by creating a minimal manifest.xml
with the correct uses-permission tag in Assets->Plugins->Android. Unity
will automatically merge the manifest files when building.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/OSVR/OSVR-Unity/issues/148

That is definitely a solution, with it's own set of pros/cons. The manifest is a simple change that will 100% fix the issue with the normal server model. This also has no negative impact on a combined server approach.
One of the larger concerns with forcing the server to be bundled would be developer overhead. When new features roll into the server developers would be forced to recompile. This approach is more consistent with our existing architectural direction.

Many application sandbox environments, particularly on mobile, force us to make some concessions, however the OSVR architecture still allows for a good deal of flexibility. Our approach for mobile devices (or any sandboxed app model) will be a hybrid one. On one hand, the server auto-start API will launch a server thread in the same process with a set of default plugins. Typically, these plugins will be based on operating system level abstractions (for example, the Android sensor APIs), and thus will be suitably universal across devices, and will be relatively stable.
On the other hand, OSVR uses a distributed architecture, and allows you to connect to devices on external servers via the external devices configuration section. Or, even to connect to a server running on the device. Where permitted by the mobile OS, the server configuration should be shared among all apps on that OS. This allows a great deal of flexibility - for example, it would allow mobile apps to take advantage of hand tracking devices connected to a PC on a local network, even when that device has no native support for the mobile OS.

Is there a JNI interface for the server, or does the client always communicate with the server via localhost?
We can follow-up offline with architectural discussion if needed.


Initial seeder / fixtures

Hi,
I'm opening this issue to discuss about possibly adding some seeder or fixtures so that people who'd like to contribute can get a local environment closer to the actual website.

@divagueame yes, this would be an awesome initial experience for someone setting up the project first time

This can be a starting point:
https://github.com/ShortRuby/rubyandrails.info/pull/55


Long startup flags are being cut

I have a server and I tried to use aikar's flags for it, but for some reason it always cuts it to about half of the initial flags

Since you provided very little information ( Please refer to: https://github.com/PufferPanel/PufferPanel/blob/master/.github/CONTRIBUTING.md ), I assume you're referring to:
https://aikar.co/2018/07/02/tuning-the-jvm-g1gc-garbage-collector-flags-for-minecraft/
If so, I am unable to reproduce this issue.
I have the Run Configuration > Command on the template set to:
java -Xms${memory}M -Xmx${memory}M -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=200 -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:SurvivorRatio=32 -XX:+PerfDisableSharedMem -XX:MaxTenuringThreshold=1 -Dusing.aikars.flags=https://mcflags.emc.gs -Daikars.new.flags=true -jar purpurclip.jar nogui

None of which gets cut off because it wouldn't run otherwise ( the jar is listed last )

The issue occured when I have pasted the flags in and reloaded the page
idk if that will help
and no, I don't mean in the templates, I have pasted them into the 'Edit Server Definition'

Closing due to the fact that it got fixed somehow, I don't know what has actually happened there


Feat/docker e2e

The Problem

The Solution

Checklist

[ ] Test manually on test-ui using remote chains.
[ ] Run load tests.
[ ] Update documentation if needed.
[ ] Update CHANGELOG.md.

update: really close here. Currently just facing some issues with getting GRAPH_1337_ENDPOINT and GRAPH_1338_ENDPOINT specified in the env for CI. Once that's working, should be passing (hopefully?) and good to merge.


fix: typo

Closes #x
Objectif(s)

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Backing image enhancement

longhorn/longhorn#2530

Replacing the Backing Image URL with a checksum seems fine.

Then we may need to bump up the min API version, which is unexpected.

@shuo-wu I might have missed it but it looked like this was the only change that was done here? i.e. replace backing image url with backing image checksum?

--backing-image-name indicates the volume that creates the backup is using a backing image. Later if users want to restore a volume from this backup volume, this backing image will be set for the restore volume by default.
--backing-image-checksum can be used to verify if the backing image matching before backup creation or restoring.
--backing-image-url is for recording only. It won't be used to create a backing image during restoring even if the backing image doesn't exist.

GetBackupFromBackupURL

Thank you for the notification. Updated the PR.

app/cmd/backup.go:31:4: undefined: cmd.BackupInspectCmd
Seems like it highly depends on #623 :(

Integration test still checks VolumeBackingImageURL

Fixed the integration test failures.

There're some conflicting files.

Conflicts resolved


AttributeError: module 'speech_recognition' has no attribute 'Recognizer'

I already installed speech_recognition
but running this code return me AttributeError
import speech_recognition as sr
`# obtain audio from the microphone
r = sr.Recognizer()
with sr.Microphone() as source:
print("Say something!")
audio = r.listen(source)
try:
print("Google: you said \n" + r.recognize_google(audio))
except:
passhere is the errorTraceback (most recent call last):
File "C:/Users/CJ/Desktop/Python/speech_recognition.py", line 2, in
import speech_recognition as sr
File "C:\Users\CJ\Desktop\Python\speech_recognition.py", line 5, in
r = sr.Recognizer()
AttributeError: module 'speech_recognition' has no attribute 'Recognizer'`
System information
My system is <window 10>.
My Python version is <Python 3.6>

Check the name of your python file name. That fixed my error.

What do u mean by python file name?

@senihtosun maybe you named your working file as the function your looking for inside the r object.
So in that case you'll need to change that as different one

Your name of the file is speech_recognition.py and python is looking not to the speech_recognition module but search the Recognizer in your module (file).
You need simple to rename your module (file).
For example from speech_recognition.py to sp_recog.py

Thank you. It worked for me as well after renaming the file.

cat s2t.py
#Python 2.x program to transcribe an Audio file
import speech_recognition as sr
AUDIO_FILE = ("/home/rakeshpatil993/OSR_us_000_0010_8k.wav")
use the audio file as the audio source
r = sr.Recognizer()
with sr.AudioFile(AUDIO_FILE) as source:
#reads the audio file. Here we use record instead of
#listen
audio = r.record(source)
try:
print("The audio file contains: " + r.recognize_google(audio))
except sr.UnknownValueError:
print("Google Speech Recognition could not understand audio")
except sr.RequestError as e:
print("Could not request results from Google Speech Recognition service; {0}".format(e))
python s2t.py
Traceback (most recent call last):
File "s2t.py", line 10, in
with sr.AudioFile(AUDIO_FILE) as source:
AttributeError: 'module' object has no attribute 'AudioFile'
getting above error while converting speech to text using speech_recognition . i have installed beloa packages, then also facing the issues.
pip install SpeechRecognition
pip install pyaudio

PS G:\program files> python -u "g:\program files\speech1.py"
Traceback (most recent call last):
File "g:\program files\speech1.py", line 3, in
with sr.microphone() as source:
AttributeError: module 'speech_recognition' has no attribute 'microphone'
PS G:\program files>
same problem facing how to fix this

@rakeshpatil993 same issue

I am also facing the same problem.
AttributeError: 'Recognizer' object has no attribute 'AudioFile'
I am running the code in googlecolab, with ipynb name as sp_recog.ipynb


extract error

I used the Celeb dataset, but changed the format of the Celeb dataset to f ++ to be consistent with your code. The folder architecture for storing videos and the folder architecture for storing face pictures are shown in the figure.The photo with the train folder is the folder that holds the face image.

I confirmed that the number of files in the box is equal to the number of my videos by the command you gave, but I encountered the error as shown in the picture. Why did I get this wrong? When I deleted the video he reported the error and ran it again, he suggested another video encountered the same error. I don't think I can delete it one by one according to his hints, so I would like to request your help

I just added the absolute path to the folder where the video is stored and the folder where the images are extracted to the extract.py file you gave me,and I didn't make any other changes.

Hi. Could you please share the exact command you used and the error shown?

This is the error

The red line is the absolute path THAT I added,Corresponding to the folder structure on the left

This is the command to check the number of files in the box

the number of my video is also the same 1200.


Multiple areas in API

Modifications to the API to generalise it to any area.
Will comment on individual lines of code in the PR
There are a couple of remaining problems which I can't fix on my end
(1) sklearn version inconsistency
The process of switching the files in and out seems to be working perfectly (as far as I can tell), however, the models for tyne_and_wear and tyne_and_wear_hex seem to be serialised with a different version of sklearn (1.2.0 and 1.3.2 respectively) and are not compatible with one another.
So, if I pin scikit-learn==1.2.0 in the pyproject.toml then the prediction fails for tyne_and_wear_hex:
  File "/Users/jyong/demoland/engine/api/main.py", line 68, in root_POST
    pred = demoland_engine.get_indicators(df, random_seed=42)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/demoland_engine/predictors.py", line 75, in get_indicators
    aq = air_quality_predictor.predict(vars)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/demoland_engine/indicators.py", line 22, in predict
    return self.model.predict(data[self.model.feature_names_in_])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py", line 1487, in predict
    return self._loss.link.inverse(self._raw_predict(X).ravel())
                                   ^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py", line 1043, in _raw_predict
    self._predict_iterations(
  File "/opt/homebrew/lib/python3.11/site-packages/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py", line 1071, in _predict_iterations
    raw_predictions[:, k] += predict(X)
                             ^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/sklearn/ensemble/_hist_gradient_boosting/predictor.py", line 69, in predict
    _predict_from_raw_data(
  File "sklearn/ensemble/_hist_gradient_boosting/_predictor.pyx", line 17, in sklearn.ensemble._hist_gradient_boosting._predictor._predict_from_raw_data
ValueError: Buffer dtype mismatch, expected 'unsigned int' but got 'long long' in 'node_struct.feature_idx'

We can't change the version of sklearn on the fly so we should choose one version and stick to it (for good).
The choice will probably depend on the version of sklearn that is available in pyodide. In particular, we are using pyodide==0.24.1 right now which is compatible only with scikit-learn==1.3.1.
(2) Docker image can't be built
This is less urgent since the Azure deployment no longer uses Docker, but since there is a Dockerfile (and a docker_usage notebook) we should probably make it work. The issue stems from libpysal==4.9.2 now having geopandas as a dependency.
I could probably figure out how to fix this myself, but I'm guessing you probably already know the fix 😅
$ docker build -f Dockerfile.api -t demoland_api .
[...]
#6 8.230 Collecting fiona>=1.8.21 (from geopandas>=0.10.0->libpysal==4.9.2)
#6 8.242   Downloading fiona-1.9.5.tar.gz (409 kB)
#6 8.278      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 409.3/409.3 kB 11.6 MB/s eta 0:00:00
#6 8.307   Installing build dependencies: started
#6 12.81   Installing build dependencies: finished with status 'done'
#6 12.81   Getting requirements to build wheel: started
#6 12.92   Getting requirements to build wheel: finished with status 'error'
#6 12.92   error: subprocess-exited-with-error
#6 12.92
#6 12.92   × Getting requirements to build wheel did not run successfully.
#6 12.92   │ exit code: 1
#6 12.92   ╰─> [3 lines of output]
#6 12.92       <string>:86: DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead
#6 12.92       WARNING:root:Failed to get options via gdal-config: [Errno 2] No such file or directory: 'gdal-config'
#6 12.92       CRITICAL:root:A GDAL API version must be specified. Provide a path to gdal-config using a GDAL_CONFIG environment variable or use a GDAL_VERSION environment variable.
#6 12.92       [end of output]

seem to be serialised with a different version of sklearn (1.2.0 and 1.3.2 respectively) and are not compatible with one another.

yes but with 1.3.2 you should be able to use the file from 1.2.0. It warns but works, at least I think that I've tested that.

I'll fix all this in January. thanks @yongrenjie :).

Of course haha, have a good Christmas and New Year! 😄

Docker image can't be built

Installing geospatial stack (geopandas) using solely pip on top of vanilla Python image can be tricky. I'll try switch to a micromamba container we use in the other image.

All should be fixed now and use sklearn 1.3.1.


Installation fails due to conflicting numpy version

Hi, users are unable to run sockeye due to dependency conflict with numpy package. As shown in the following full dependency graph of sockeye, sockeye requires numpy >=1.14，while mxnet-mkl requires numpy <1.17.0,>=1.8.2.
According to pip’s “first found wins” installation strategy, numpy 1.17.4 is the actually installed version. However, numpy 1.17.4 does not satisfy <1.17.0,>=1.8.2.
Dependency tree-----------
sockeye - 1.18.106
| +- mxnet-mkl(install version:1.4.1 version range:==1.4.1)
| | +- numpy(install version:1.4.1 version range:<1.17.0,>=1.8.2)
| +- numpy(install version:1.16.5 version range:>=1.14)
| +- portalocker(install version:1.5.2 version range:*)
| +- pyyaml(install version:5.2 version range:>=5.1)
| +- sacrebleu(install version:1.3.6 version range:==1.3.6)
| | +- typing(install version:<IP_ADDRESS> version range:*)
| +- typing(install version:<IP_ADDRESS> version range:*)

Thanks for your help.
Best,
Neolith

Suggested Solution

Fix your direct dependency to be mxnet-mkl>=1.4.1. I have checked this revision will not affect your downstream projects now.
Remove your direct dependency numpy, and use numpy transitively introduced by mxnet-mkl.

@fhieber Which solution do you prefer, 1 or 2?
Please let me know your choice. I can submit a PR to solve this issue.

Hi @NeolithEra ,
Thanks for investigating! First choice is not an option as we would like to depend on MXNet 1.5.1. I am also not a big fan of transitive dependencies if we use nunpy explicitly in Sockeye. Would it work to simply use the same version requirement as mxnet-mkl?

In case that's relevant here: newer versions of numpy cause problems for training continuation:
https://github.com/awslabs/sockeye/issues/693

This is fixed in Sockeye 2, closing.


NTR: Torres Strait Islander

For new term requests, please provide the following information:
Preferred term label
Torres Strait Islander
Synonyms
TSI
Textual definition
An Australian Indigenous person from the Torres Strait Islands, situated between the north of Australia and Papua New Guinea.
PMID: 32391301 This is an Australian Indigenous population who have historically not been engaged or partnered with for health-based research. So there are no genetic references currently available. I refer to a paper discussing the need for this
Suggested parent term
Once available, please place under NTR: Indigenous Australian per #23

While we are happy in principle with the creation of this term, some questions remain as to the best classification of this term and its suggested parent term(s). This request is therefore placed on hold pending the resolution of the classification question.


Azure builds not showing on PR branches

It seems that no Azure builds are currently showing up on branches from my fork to the upstream repo. The circleci builds are working fine.

Thanks for the feedback. These changes are now merged in master.


New Instagram icon (May 2016)

Instagram launched a new look, a very clean EPS can be found on their brand website, and I've even converted it to SVG (I later changed the color back to black, after comparing with the PNG). Feel free to incorporate that SVG code into your collection! :)

Done 2a2939b29ae8272d0157ce998a4d80ef7ddaab66


Showing in-progress GitHub Actions as "in progress"

Hi,
I noticed that, while a build is in progress, the Shields.io badge that I have in my project readme, on GitHub, shows the status of the last completed build. That is, it never reports "in progress" or anything like that. Is there any way to fix this?
The readme I'm hinting at can be seen at:
https://github.com/gennaroprota/breeze.
Thanks.

The workflow status badge in your readme is explicitly pointed to your master branch, so it's always, and only, going to reflect the  status for workflow runs against that branch.
If you want it to reflect the current status of the workflow run independent of any single branch, then you should remove the /master route parameter from your badge url.
Please also note that even though we have the shortest cache duration for build status badges like this one (30 seconds) there are still a few layers of caching, and if your entire workflow run completes in significantly less than that 30 second then it might be fairly unlikely that you'd get a request and a cache miss at the same time a workflow was in progress.

Yes, pointing to the master branch only was intentional, but thanks for the heads up! :-)
My tests normally take a few minutes (on average, a little more than 10 minutes when they succeed). But one thing that is occurring to me now is: should I load the readme page in the browser 30 seconds after the push, so that the badge cache expires? (I'm not sure how much I've been waiting after the push, so far: you know, it may be just a matter of hitting CTRL-TAB, F5 :-).)

I'm going to close this as there doesn't really seem to be anything actionable. If you feel this is something you are still encountering, please feel free to reopen (or add a comment) with details and preferably screenshots showing both our workflow status badge and the native github workflow status badge side by side; if there's genuinely something different between the two then we'll take a look, but otherwise we just use the data the upstream services give us.


Upgrade Rust toolchain to 1.54.0

https://blog.rust-lang.org/2021/07/29/Rust-1.54.0.html
This PR addresses many new and updated clippy lints.
This PR uses the new function-like macro in attribute position changes to simplify the testing of README.md code blocks in doc tests.

It's likely the doctest changes will result in the artichoke/nightly CI run to fail tonight, which will require bumping the RUST_VERSION arg embedded in the Dockerfiles.
Let's wait for that run to fail before pushing a fix and link it here.

Let's wait for that run to fail before pushing a fix and link it here.

https://github.com/artichoke/docker-artichoke-nightly/pull/42


Let Array#<< modify default configuration values

Previously, config reader methods would return a new array for the default
value of paths, so if a user did:
PuppetSyntax.exclude_paths << "spec/fixtures/**/*.pp"

e.g. in puppetlabs_spec_helper, then the new path would get appended to the
new array and not change the actual configuration.  Now the array is set as
the default first, so in-place modifications of arrays are preserved.

The puppetlabs_spec_helper code assumes this works (as it does in puppet-lint and other gems): https://github.com/puppetlabs/puppetlabs_spec_helper/blob/0.8.2/lib/puppetlabs_spec_helper/rake_tasks.rb#L208.  Similarly if you try and append more paths in your own Rakefile, they're silently ignored.

Thanks for the pull request.
One of us will hopefully get round to looking at this soon.

Thanks, Dominic. I'll get this released shortly.

Thanks!

https://rubygems.org/gems/puppet-syntax/versions/1.4.1 :whale:


[API. Add club] The system responds to a request from an unauthorized user by processing the content of the request

Environment: Windows 10 Pro
Postman for Windows Version 10.11.2
Reproducible: always
Preconditions
Run Postman
Don't authorize with token
TD1: {
"categoriesName":[
"Танці, хореографія"
],
"name": "name",
"ageFrom":2,
"ageTo":14,
"description":"{"blocks":[{"key":"brl63","text":"descriptiondescriptiondescriptiondescridescriptiondescriptiondescriptiondescri","type":"unstyled","depth":0,"inlineStyleRanges":[],"entityRanges":[],"data":{}}],"entityMap":{}}",
"userId":"1",
"contacts":"{"1"::"234567891"}",
"centerId":640
}
Steps to reproduce

Create new POST request
Choose Body>raw>JSON
Enter TD1 to "Body"
Click "Send" button

Actual result
Server responding with status code 400 Bad request and error message "name Довжина назви має бути від 5 до 100 символів"
Expected result
Server responding with status code 401 Unauthorized and error message "You are not authenticated"
User story and test case links
Labels to be added
"Bug", Priority ("pri: "), Severity ("severity:"), Type ("UI, "Functional"), "API" (for back-end bugs).
https://user-images.githubusercontent.com/122798739/224562253-b40543ce-6733-43a5-ac7b-e5b7a9c3dd09.mp4

@TetianaFilatova This is not a bug! I asked questions at the meeting and Yaroslav told me how it works.


[DOCS] need improvement in avatar part of docs

Description
In the avatar part of the docs , It should be clearly mentioned that one just have to add his/her Github username with .png extension and the website will automatically fetch your Github avatar.
Screenshots
No response
Additional information
No response

Please assign me this, so I can work on it

Sure! @Rahulbaran feel free to work on it :D


Selecting an element from Layers Panel and clicking Delete not working

Bug Description
When selecting an element via Layers Panel and then clicking the Delete button, nothing happens.

Expected Behaviour
The element should be deleted after being selected via the Layers Panel.

Steps to Reproduce

Add an element
Unselect it
Select it via the Layers Panel, see the element getting the selection frame active.
Hit "Delete"
Nothing happens

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Related to #738. But I'd not say it's a dupe since the implementation can reasonably well decide to just use the same shortcuts here directly.


OOTB Support Major Distros

GOAL: goglizer OOTB support for current Mint/Ubuntu/Debian/Manjaro/Fedora "Broken Sword 2.5"
Tests:

install/run/uninstall boxed "LifeForce_ASD"
download dolmades-cli, cook/serve/del "LifeForce_ASD"

Results

[X] Mint 19 / Mate - best support as I use it for development :)

TODO --- from here repeat and update:

[ ] Official Ubuntu Desktop 18.04.1 LTS - GNOME 3 (ugh!)

requires sudo apt -y install git python curl

No SysTray feature using yad. What to do?

Did not have ~/.Xauthority. It works without. FIXME: adapt cook and dolmades

[ ] Debian Live 9.5 - KDE

no systray

requires sudo apt -y install git curl

Desktop symbol receives no run permissions. These can be given manually by user...

[ ] Manjaro - XFCE

I'm not even able to install git without breaking the system...hmm, download zip and install like that

Did not have ~/.Xauthority. It works without. FIXME: adapt cook and dolmades

Desktop symbol receives no run permissions. These can be given manually by user...

[ ] Fedora 29 Workstation - Gnome localized German

sudo yum install python2

gnome is so advanced it even removed desktop symbols 🤦

General Issues

[ ] udocker needs curl or pycurl
[ ] python2 shebang might differ from distro to distro we cover most with python2
[ ] desktop file doesnt receive exec permissions on some distros (WHY?)
[ ] git is often needed - change docs to use curl instead!
[ ] Some WMs might not have systrays
[ ] Some WMs do not display desktop icons by default
[ ] Full Screen did not work. Might be due to VirtualBox though...

Create

a very simple test suite
make it work out-of-the-box on the most common distros

support for ubuntu 19.04 has been added!


Google Drive Link empty

Hi,
Great project, I really want to try it out, but the google drive link seems to be empty.
Could you please share those videos for the prerecord demo, really appreciated.

Thanks for the reminder.
I've reuploaded all the videos needed for the demo.
The google drive link should work right now.


Please add the font-size of 125% and 150%

Summary
Font-size in type of 200% is too large, but default (100%) is too small. The font size of 125% is well decorated.
Please confirm the following

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Available on Release 1.6.6

Yes, it works fine now on v. 1.6.6.
Thanks for your efforts.

Everything works perfectly thank you very much


Describe cloudevents target endpoint

We should be able to see the endpoint for a given cloudevent target.
Right now we do not
Target                       Kind                  Status
foobar-cloudeventstarget     cloudeventstarget     online(http://localhost:63535)

Atlernative idea that would be more feasible:
tmctl [describe|dump|get] target mycloudeventstarget
=> this could output a subset of the dump


[Enhancement] add iceberg plan files costs profile

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 14 / 15 (93.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/iceberg/IcebergMetadata.java
7
8
87.50%
[421]

:large_blue_circle:
com/starrocks/connector/iceberg/IcebergFilter.java
7
7
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 14 / 15 (93.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/iceberg/IcebergMetadata.java
7
8
87.50%
[421]

:large_blue_circle:
com/starrocks/connector/iceberg/IcebergFilter.java
7
7
100.00%
[]


Rendering in template

Want to show in template amount of votes for object, added to installed apps 'vote', though {% load vote %} doesn't work for me, raises an error that there is no such library.

What's your Django version and django-vote version?

Django v. 1.9.5.
django-vote v. 1.1.2

Bug fixed in latest release (2.1.2)


changed pip call to avoid logger config code in pip

this may not be resilient to change in pip, but works for 9.0.1 and the master branch of pip
The new code is basically copied from  pip.basecommand.Command.main(). This is the method that gets called by pip.main(), and it basically sets up the logger config (which we don't want), then executes these commands. There are a couple other environment variable checks also, but they seem unnecessary and even more subject to change.
This is a proof-of-concept for fixing pip's screwing with logging #23. I haven't looked at different versions of pip much, just 9.0.1 (current) and 10.0.0 (dev version, HEAD of repo). If we want to go this way, we should check other versions better. Also, I've only worked in python 3.5 here.

Thanks a lot. I had already changed the code to use subprocess instead, but I'll see if your alternative is better.
https://lab.cluster.gsi.dit.upm.es/senpy/senpy/commit/7e5b55ff9cab00d8d3f4421465fdc40ac5edded1
A drawback of my solution is that stdout and stderr are out of order. On the other hand, it is logged in the appropriate level, which we weren't doing before.


Add Commands.register_system

register_system, register_boxed_system and remove_system were added for Commands. This is very useful for adding systems inside entities to make the code flexible. It's needed specially for the UI.
Objective
For the proposal posted here
https://github.com/bevyengine/bevy/issues/13986
I just started rust 3 weeks ago so i'm not sure if this is good.
Solution
Register Entity owned systems (we would add the system id's entity as a child and then we will have resource management + caching. We also won't need to make our systems exclusive.
Testing
https://github.com/darthLeviN/commands_register_system_example
Works.
Further suggestions
I'm not sure whether we want this in ChildBuilder as well or not.
The example usage is basic. but this will be used to create flexible automated node tree builder systems that are still cached efficiently and can be called with Commands instead of a exclusive &mut World query in the entire system. So there will be an opportunity for parallelization if we're loading something heavy (even though the parallelization might not be happening in the current implementation).
At the moment run_system command is ran with
impl<I: 'static + Send> Command for RunSystemWithInput<I> {
    #[inline]
    fn apply(self, world: &mut World) {
        let _ = world.run_system_with_input(self.system_id, self.input);
    }
}

My idea is that if two RunSystemWithInput need to run at the end of two queues, it might be possible to run them at the same time.

@BD103 I just realized in the main branch, there is a similar function called
register_one_shot_system that does something very similar.
Boxed systems can be registered with pushing the RegisterSystem command.
However that would come with an overhead of a pushed exclusive command.
Should i remove that one or close this PR bc that solution is preferred?

I think the existing solution should be preferred, in the absence of a compelling argument to the contrary.


Empty table columns at end of table do not render

If you create a table, and the last column is empty, it does not correctly render. For reference, this works on GitHub.
Using the demo as an example:
| Feature   | Support | Empy |
| --------- | ------- | ---- |
| tables    | ✔ |
| alignment | ✔ |
| wewt      | ✔ |

You get this:

and the cells do not appear in the markup:

Whereas, the same table renders fine on GH, eg on this issue:

Feature
Support
Empy

tables
✔

alignment
✔

wewt
✔

This appears to be an issue upstream with remark, will open a ticket there.


customValidator is not provided via NG_VALIDATORS or NG_ASYNC_VALIDATORS

I have a problem with custom validators but only when building application for production. The problem is in dynamic-form.service.ts file when code enters in getCustomValidatorFn() function.
I'm using Angular CLI with webpack: v1.0.0-beta.31
Angular v2.4.3
The problem appears when code gets uglified and variable names are renamed. Function getCustomValidatorFn() compares two strings which are not equal because of code uglification and because of that it doesn't find anything in NG_VALIDATORS array.
I hope the code below explains the problem. I put console.log() to output breaking lines of code to understand where the issue is. If it's not clear I will explain more clear.
Right now I'm not able to use the library in production.
getCustomValidatorFn(validatorName: string): ValidatorFn | AsyncValidatorFn | undefined  {

        console.debug(validatorName) // myCustomValidator

        let validatorFn;

        console.log(this.NG_VALIDATORS)
        // Array[1]:
        //     i(t)
        //       arguments(...)
        //       arguments(caller)
        //       length: 1
        //       name: "i"

        if (this.NG_VALIDATORS) {
            validatorFn = this.NG_VALIDATORS.find(validator => {
                console.log(validatorName); // myCustomValidator
                console.log(validator.name); // i
                console.log( validatorName == validator.name) // false

                // THIS IS CRITICAL LINE OF CODE WHERE FUNCTION NAME IN "this.NG_VALIDATORS"
                // IS EQUAL TO "i" AND FUNCTION PARAMETER "validatorName" IS EQUAL TO "myCustomValidator"
                return validatorName == validator.name
            });

            console.debug(validatorFn) // undefined
        }

        if (!isDefined(validatorFn) && this.NG_ASYNC_VALIDATORS) {
            validatorFn = this.NG_ASYNC_VALIDATORS.find(asyncValidator => validatorName === asyncValidator.name);
        }

        return validatorFn;
    }

    getValidatorFn(validatorName: string, validatorArgs?: any): ValidatorFn | AsyncValidatorFn | never {

        console.debug( validatorName) // myCustomValidator

        let validatorFn = Validators[validatorName] || this.getCustomValidatorFn(validatorName);

        console.debug(validatorFn) // undefined

        if (!isFunction(validatorFn)) {
            throw new Error(`validator "${validatorName}" is not provided via NG_VALIDATORS or NG_ASYNC_VALIDATORS`);
        }

        return isDefined(validatorArgs) ? validatorFn(validatorArgs) : validatorFn;
    }

Is there any solution to workaround this?
Thanks

@anteburazer There it is, Ante! You've found the single most weak point of current custom validators implementation. I've already tried to get my head around this. Is there any chance that you exclude certain strings from mangling / uglifying?

@anteburazer I guess, I've got a solution for you! You just need to exclude the function name from mangling:
    plugins: [

        new webpack.optimize.UglifyJsPlugin({
            mangle: {
                except: ['myValidator']
            }
        })

    ]

@udos86 thanks for your help.
I'm using Angular CLI and I don't have access to webpack config file. They provide some config file to override webpack configuration but as far as I know there's no option to manipulate with mangling options.
My other problem is that I had to customize the library, because of some extra features I needed, so I included it as a regular module inside the project and not via node modules.
I had to make this decision because I needed it ASAP so unfortunately I'm not in sync with your updates anymore :(
I'm not sure how I can integrate your solution but it's up to me cause I branched from this repository because of custom modifications I had to make.
I really appreciate your help. If you have any idea please let me know, if not I'll have to make some workaround for this.

For all adventurers who wants to include this library as project's local module and not via node_modules this is how to workaround this issue:

Don't  implement custom validators via NG_VALIDATORS but use Angular injectable service instead and define all custom validator functions there.

@Injectable()
export class ValidationService {
  public numericRequired(formControl: FormControl): {[error: string]:any} {
    return (formControl.value && formControl.value > 0) ? null : { numericRequired: { valid: false } };
  }
}

Change getCustomValidatorFn() function inside the dynamic-forms.service.ts file to use validation service from above, instead of NG_VALIDATORS

getCustomValidatorFn(validatorName: string): ValidatorFn | undefined {
    let validatorFn;

    if (validatorName in this.validationService) validatorFn = this.validationService[validatorName];

   return validatorFn;
}

I didn't cover async validators in this case. Maybe I will one day when I see red errors in production :)
Enjoy :)

@anteburazer Great! Thanks for your figuring out that workaround!

I too have ran into this problem. However, I didn't fork the repo, i'm using the latest version. Is the only workaround found so far is forking the repo and modifying dynamic-forms.service? :/

@kirjai I'll try to figure out a solution for everyone out there using Angular CLI

@kirjai @anteburazer  Good news, everybody! I finally found a fix for this! Have a look at aaff8ec.
However there's one constraint: It only works for NG_VALIDATORS not for ASYNC_VALIDATORS
And please always name your validator function the same as the property of it's return object:
export function customValidator(formControl: FormControl) {
    return {
        customValidator: {valid: formControl.value ? (formControl.value as string).startsWith("abc") : false}
    };
}

@udos86 thanks for help.
I didn't try your solution yet but I saw that Angular CLI supports webpack.config.js now: http://www.dzurico.com/angular-cli-with-the-super-powers/
@kirjai you can also try with Udo's first solution by excluding validator's name from mangling

@anteburazer Alright, thanks for the information!

i being pulling my hair over this issue but to no avail
13:12:53.883 ERROR in<EMAIL_ADDRESS>(108,13): Argument of type 'ValidatorFn' is not assignable to parameter of type 'AsyncValidatorFn'.
13:12:53.883   Type 'ValidationErrors' is not assignable to type 'Promise<ValidationErrors> | Observable<ValidationErrors>'.
13:12:53.883     Type 'ValidationErrors' is not assignable to type 'Observable<ValidationErrors>'.
13:12:53.883       Property '_isScalar' is missing in type 'ValidationErrors'.
13:12:53.883<EMAIL_ADDRESS>(145,45): Argument of type 'ValidatorFn[] | AsyncValidatorFn[]' is not assignable to parameter of type 'AsyncValidatorFn[]'.
13:12:53.883   Type 'ValidatorFn[]' is not assignable to type 'AsyncValidatorFn[]'.
13:12:53.883     Type 'ValidatorFn' is not assignable to type 'AsyncValidatorFn'.

i followed all the suggested methods but still not solved

@Ellipizle Hi! Did you update to 1.4.0?

For anyone on webpack 4
    optimization: {
      minimizer: [
        new UglifyJsPlugin({
          uglifyOptions: {
            compress: false,
            mangle: {
              reserved: ['myValidator'],
            },
          },
        }),
      ],
    },

is the new way to achieve this


feat(aws): add jwt authentication

part of #137
This is a PoC that is used to create a PR-image to do manual testing.
A lot of changes were needed:

configure kind to enable SA Token Volume Projection
update Kubernetes in kind/e2e/ci to 1.20.7
use latest localstack (old didn't have assumeRoleWithWebIdentity enabled)
controller-runtime does not support subresources (controller-runtime#172), we have to use client-go for this which is a PITA for testing
refactor pkg/aws/session and pkg/aws/provider.go so that all stuff relevant for authentication is in pkg/aws/auth

It is hard to do proper e2e tests  for AssumeRoleWithWebIdentity due to the dependency on AWS/EKS. I'll tackle this one in a follow-up PR.

I will need some time to go over this one, will try asap :)

Finally had the time to go over this one. LGTM! Your changes to the e2e tests suites will of course affect this, and we have some conflicts but besides that I could not spot anything that I would change.

/approve

/merge


In-Browser?

Can you use this module in browsers?
If so, is there a way to toggle features / select groups, etc.. from the URL?

No, there's currently no browser support for this module.

Thanks. =)


Relax base upper and bring CI to latest and greatest

Sorry it's kind of a grab-bag, but nothing's too wild here.

Circle's not too happy about this change :laughing: :rofl:


[fix] update URL paths to new github endpoint

Task: Update URL with new github endpoint
Issue Reference: https://github.com/imba/imba.io/issues/59

This has been resolved in #61
If you are looking for more issues to work on checkout these links
https://github.com/imba/imba/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest
https://github.com/imba/imba.io/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest
Thanks.


Add ISSUES_TEMPLATE.md

Direct users to tfjs union repo to file issues.

This change is

 We disabled issues on this repo, and migrated the issues, but it's not a problem if this file is checked in

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Sprite3D is jittering on move with enabled shadows

Godot version
3.3.2 stable
System information
Windows 10, GLES3
Issue description
If sprite moves with enabled shadows, it is jittering with visual artefacts. Without shadows it's OK. I tried changing all the light and sprite settings

Compare with original

Steps to reproduce
See and run project.
"Новая игра" - New game
"Выход" - Quit
A and D - left and right move
Also try walking towards the wall, sprite is jittering too.
Minimal reproduction project
prototype123.zip

@Calinou we inserted the scene in the wrong way, reworked it and everything works


Fix Visual Studio 2019 build issues in samples

In short, the essence of this fix:

Try to autodetect the latest Windows 10 SDK.
Try to autodetect the Visual Studio version:

if Visual Studio 2019 is detected, then use v142 tooling for the samples.
if Visual Studio 2017 is detected, then use v141 tooling for the samples.

This ensures that if we "Build All..." in Visual Studio 2019 IDE, even without v141 (vs2017) tools installed, all projects including samples are built successfully.

@sid-dahiya - I know you've seen it on your machine too. While I'm working on SetType PR, I've experienced OCD related to not having v141 tools installed.. I need all of my projects to build successfully. Thus, fixing it.

@bliptec @kindbe @lalitb @larvacea @mkoscumb @reyang - can you folks quickly take a look? The change is no-code-change, build change that fixes some issues with vs2019 ide. I'd like to merge that to minimize my other PR.


Dependency Injection for Extension#manipulate_resource_list

Hi,
I started using middleman a couple of weeks ago and absolutely love it.
But one thing bothers me : MyExtension#manipulate_resource_list is concerned with the totality of the resources and breaks SRP quit badly.
For example in the Paginator of middleman-blog, the method needs to check:

if resources belongs to the right blog,
if locales are set or not,
if a filter needs to be applied (in the TODO) etc.

This clearly should not be the paginator's concern !!! I mean... this is really bad !
So I understand, at least I assume, middleman extensions are build on the same idea rack middlewares are and each extension/middleware passes the whole set of resources/headers to the next...
So I don't have any out of the box solution, and I don't know if DI could be it in this case, but I would be interested to know if this problem has been spotted/addressed already, if there are plans or ways to solve it, and if not I would be happy to try to contribute.
Charly

It's definitely reached the edges of what the current approach can handle. I've been thinking about a multi-phase approach, but still having the current pipeline concept. We'll see.

I found a fork of aupajo's pagination extension that kinda got it right by setting the paginated collection in a proc and removing the burden of determining it inside the method.
# config.rb
activate :pagination do
  pageable_set :articles_en, "en/articles/index.html", 55, "p/:num" do |p|
    resources.select{|r| r.data.lang == "en"}
  end
end
```

Regarding a multi-phased approach I'd be curious to know what's in your mind. I'm tempted to say a routeur/controller division would be welcome (instead of stuffing everything in `config.rb`). It would stay a flow but it would clear the callback mess by stating what needs to come before and after in the lifecycle (I personally got rid of all callbacks in my rails apps).

On the other hand that might be overkill....

Always happy to review a proposal. Most of our users don't need to get too in the weeds on stuff, but we always want to make APIs available to the power users to do complex things.
In v4 we tried to abstract collections out so things like pagination could be slightly easier to build, but it's still pretty complex and a little too magical.


Added suggestion of mvdnbrk/postmark-inbound to composer.json.

Hi Paul,
I have created a simple package to process Postmark Inbound Webhooks.
Would you mind adding this as a suggestion?
Thanks,
Mark
:smile:

Thanks Paul!
2017-11-07 16:27 GMT+01:00 Craig Paul<EMAIL_ADDRESS>
Merged #7 https://github.com/coconutcraig/laravel-postmark/pull/7.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/coconutcraig/laravel-postmark/pull/7#event-1329925817,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAw_eZ9F6M85VRW2q247j7XrYC-kE2EMks5s0HbrgaJpZM4QUdo6
.


continues delete prompt bug

Came across your app on reddit and I love it! Thank you sooo much!

delete single chapter button -> cancel -> continues delete prompt, until manual restart app
delete single chapter -> accept -> app crash, chapter not deleted

In Depth:
I clicked on the green saved icon (downloads page ->  right saved icon) and on the pop up I clicked cancel. But now everytime I go in it gives me the prompt to delete, it promps again everytime when I try to scroll or click on anything except the exit button. (The trash can button, top right, does not have this issue) The issue stops when I relaunch the app. And selecting delete crashes the app before I deletes the chapter. So there is no option to delete individual chapters.
Device: iPhone 15 Pro
iOS: 17.4.1
App: v 0.28

thank you for clear way of error reproduction
i fixed the crash


fix bad url

fix bad url

This change is

We should use relative URLs so the originals here are fine.


Feature: Add option to aggregate dataframe before plotting

User description
When excluding columns from plotting that are present, this can lead to wonky plots.
For example, if ion mobility is present in the underlying dataframe and is ignored in chromatogram plotting, we can end up with a plot like this

This is because there is more than one point plotted at each RT and intensity (since they differ in IM).
In this PR I add a warning message that this is occurring because of duplicates.

I also added the aggregate_duplicates option which will sum up the intensities of duplicate entries.
If  aggregate_duplicates=True then we get a plot that is more in line with what is expected

PR Type
enhancement, bug fix

Description

Introduced an aggregate_duplicates option to sum up intensities of duplicate entries, improving plot accuracy.
Added a method _check_and_aggregate_duplicates to handle duplicate data by either aggregating or warning the user.
Enhanced the handling of known columns across different plot types, ensuring proper aggregation and plotting.
Fixed bugs related to peakmap plotting and aggregation, improving the robustness of the plotting functionality.

Changes walkthrough 📝
Relevant filesEnhancement

_core.pyAdd data aggregation and duplicate handling in plotting

pyopenms_viz/_core.py
Added aggregate_duplicates option to aggregate duplicate data points.  Implemented a method to check and aggregate duplicate data.  Added warnings for duplicate data without aggregation.  Enhanced known columns handling for different plot types.

+130/-59

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@axelwalter can you please review this when you have a chance?

Since some of the docs render strange without this PR merged, I am going to merge it.


Directory resolve fix

At the moment, grunt task doesn't work when you use it via npm. It works only if you clone the repo and run task there. I fixed this and checked with npm@2 and npm@3.
Also, I added casperjs as peer dependency. Because you can't use this plugin without casperjs.

I absolutely HATE IT when a component provides said support for grunt, gulp - or in this case npm - but it just plain doesn't work.
Now we have your fix dangling into the unknown. I think I'll just pull from your fork directly.
Thank you @boccob,


Fix the Go example for Random provider intro.

Method and args name was wrong per https://www.pulumi.com/docs/reference/pkg/random/randompet/#create.

This needs to be fixed in all other languages as well - right?

This needs to be fixed in all other languages as well - right?

Yea, you're right. I'll fix them too...

Fixed the rest of them.


resolves #451 which suggest to use a stylable background for btn:

Currently just a test commit to trigger feedback how to set the background color a text element

Actually, there's an open pull request for adding a background color to a span of text. The problem isn't that we can't specify the markup, but that the drawing element isn't implemented. See #350. We'll still need this PR, but it is blocked by #350.

I think this PR is now superseded by #664. That PR still needs some refinement, but it has all the elements necessary to make this possible.


New rule added to ruleset is not accessible in canvas

Hi,
I added a new rule in http://<IP_ADDRESS>/HELM2MonomerService/hwe/examples/RuleSetApp.htm (replace P by sP). It is saved correctly, but I cannot see this new ruleset from the canvas (app page) and rule tab.

This sounds like a similar problem to the monomer refresh issue. Can we put in a fix similar to the monomer fix where the webservices update the set of rules on creation of a new rule.

Fixed now,  in javascript side

Retested and looks fixed to me. Yohann - could you check and close if you are happy?

It looks good: the rule is now visible from the canvas as expected.
However, it introduced a new bug when create a rule with quote. Where the single quote symbol is added and create an error when trying to apply the rule. I am creating a new ticket for it so this one can be closed.


sort array inside hash automatically

I find this library to be extremely useful, however its missing a usecase that i badly need.
As you mentioned in the documentation, if we have array inside hash, it will need to be sorted before we can compare, else it will show them as diff.
Can we please add a option to sort arrays before comparing them? is there any specific reason why its not provided?
Thanks
Rajat JIndal

@rajatjindal83 it seems difficult to arrive at a reasonable way to sort arrays with arbitrary objects.


Update ServerInfo Command, HTTP.CheckHttp and RunCommandAsPlayer

Used Players:GetPlayers() for Non-Admins/Admins instead of NetworkServer:GetChildren()
Replaced ON/OFF with bool strings to make it more fast
Removed ThirdPartySales (ROBLOX doesn't respect this afaik and was replaced with one inside Game Settings https://i.imgur.com/Fyo6Hzs.png)
Fixed RunCommandAsPlayer trying to get a unknown variable, which was supposed to be plr
Logs lines with only spaces were removed
Fixed Logs indenting on the ServerDetails function
HTTP.CheckHttp is more simplified

replacing [ON] [OFF] with [true] [false] doesn't make it more fast in terms of nanoseconds

replacing [ON] [OFF] with [true] [false] doesn't make it more fast in terms of nanoseconds

Actually LOADK is faster than LOADBOOL

[ON] [OFF] looks better than [true/false] and the speed isn't really noticeable

[ON] [OFF] looks better than [true/false] and the speed isn't really noticeable

Yeah I'm going to revert from the bool values to [ON] and [OFF] again.


Add Apache Kafka KRaft support

Issue description
Apache Kafka now seems to also support an alternative coordination backend besides Zookeeper, dubbed "KRaft", and NixOS doesn't appear to support that yet, at least I was unable to any reference in nixpkgs, besides an indirect mention in an issue comment https://github.com/NixOS/nixpkgs/issues/127226#issuecomment-1085914763

PTAL ^ :smile_cat:

I think so, yes :)


Update peer dependencies for angular v2.1.1, uninstallable

Pulled in your changes and also published 0.4.1 to npm

Thanks so much man !


Failed to unpack account state

LITE_SERVER_UNKNOWN: cannot apply external message to current state : Failed to unpack account state
Receiving this error while using tonWeb for simple transaction thew WalletV4

Did you solve?

Hello, i have same issue:

Hi guys. I think I solve for me. Look to seqno. This is number of transactions IN WALLET WHO SEND TRANSACTION to another wallet. This mean:
logic: wallet1 -> tx -> wallet2
wallet1 -> tx (seqn_wallet1:int, amount:int, wallet2:str) -> walelt2


Enabling external rabbitmq for analytics

/cc @sdelano @gregdurham @jamesc
tested with build: http://wilson.ci.chef.co/job/chef-server-12-trigger-ad_hoc/585/downstreambuildview/
and all looks good.

@PrajaktaPurohit and I chatted earlier about my comments.  I think this can go through without them being addressed immediately. :+1: here.

thanks @stevendanna!

+1

:+1:

[ ] needs a rebase before merging
[ ] could use a note in the changelog about preliminary support for external actions queue

:shipit:


SourceId: Test and fix ambiguous serialization of Git references

For some branch names (or tags or refs), generate_lockfile will serialize poorly.  Parsing the Cargo.lock will refer to a branch that wasn't the intended one in Cargo.toml.
Because a branch name can contain the '#' character, the precise reference could be corrupted through a branch/tag/ref as well.
First commit adds a test showing the problem, second commit fixes it by having the serializer match the deserializer by encoding a x-www-form-urlencoded query string.
Fixes #11085.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.
Please see the contribution instructions for more information.

Re compatibility, this changes the way some git urls are written to Cargo.lock if they contain non-alphanumeric characters (anything outside of [a-zA-Z0-9*._-]).
Running cargo update before/after switching cargo versions will write different git urls when they contain characters that are now escaped.  The Cargo.lock stays compatible, because parsing is unchanged: URLs that used to round trip still do, URLs that were generated incorrectly but without breaking precise references (git sha1s) seem to behave the same (cargo seems to use the precise reference, at least for building), minus spurious messages on cargo update (from compare_dependency_graphs).  I haven't checked how URLs that broke precise references behaved, but they will be unbroken.

I appreciate the review feedback, and I would be happy to see where the cargo team discussed this, if there's a transcript or a good discussion channel.
I want to stress once more that this is not a parsing problem and that the parsing path should not be changed.
Serializing two different inputs to the same serial form is always a problem on the serialisation side.  The information is lost after serialisation, and deserialisation will never be able to divine the intended branch name no matter how ad-hoc the parser.  Let's keep the perfectly good deserialisation path, it follows the WHATWG URL standard, it should stay there.
So, here is what I'm suggesting:
when writing a version 2 lockfile, this PR can be amended to change the serialised form for fewer special characters, escaping only those that produce known breakage (either breaking round-tripping or spilling into other fields).
Doing simpler, fully conformant serialisation can be conditional on a Cargo.lock version bump.
Deserialisation will stay the same pre and post version bump, no ambiguities there.
This way will minimise churn to VCS-tracked lockfiles.

True that we should keep deserialization correct. I'll label this as https://github.com/rust-lang/cargo/labels/S-blocked at this moment. We'll revisit once we decide to have a lockfile version bump. Thank you for your efforts and suggestions so far!

:umbrella: The latest upstream changes (presumably #11501) made this pull request unmergeable. Please resolve the merge conflicts.

https://github.com/rust-lang/cargo/issues/12120 is an issue tracking for all bugfixes needing a lockfile version bump. Given this PR isn't likely to merge in its current status, I'll go ahead closing it. We can track its progress in https://github.com/rust-lang/cargo/issues/11085 and https://github.com/rust-lang/cargo/issues/12120. If I got time I'll have this fixed within a lockfile version bump (or someone gets it faster than me). Thank you for calling out the ambiguity and the fix!


NDEBUG Definition always enabled using Ninja Multi-Config

Brief Issue Summary
Bug NDEBUG Definition is not grayed in release mode

step to reproduce:
set  cmake generator = Ninja Multi-Config

#ifndef NDEBUG
#define PRINTHELLO() std::cout << "Hello, debug!\n";
#else
#define PRINTHELLO() std::cout << "Hello, release!\n";
#endif

man() {
PRINTHELLO();
}

expected :
following line grayed in  release mode

#define PRINTHELLO() std::cout << "Hello, debug!\n";
CMake Tools Diagnostics
{
  "os": "win32",
  "vscodeVersion": "1.81.1",
  "cmtVersion": "1.15.31",
  "configurations": [
    {
      "folder": "c:\\Users\\ascre_p1ijxgd\\test\\prova",
      "cmakeVersion": "3.27.1",
      "configured": true,
      "generator": "Ninja Multi-Config",
      "usesPresets": false,
      "compilers": {
        "C": "C:/msys64/clang64/bin/clang.exe",
        "CXX": "C:/msys64/clang64/bin/clang++.exe"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": false,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": true
    }
  ]
}

Debug Log
No response
Additional Information

Configuration is Release

@AlessandroScrem Thanks for posting the issue! Is there any way that you could provide a repro project for us to reproduce this issue and investigate?
Is this using kits?

This is the repo I used to reproduce the issue:
It's very basic file.
https://github.com/AlessandroScrem/prova
I using following kit:
CMAKE_C_COMPILER:FILEPATH=C:\msys64\clang64\bin\clang.exe -CMAKE_CXX_COMPILER:FILEPATH=C:\msys64\clang64\bin\clang++.exe
Cmake Generator =  "Ninja Multi-Config"
Im also using clangd extension:
https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.vscode-clangd
I hope this info could be userful.
Thank so much.
Alessandro

It's possible that #3363 fixes this issue. Once merged, could you please confirm? We also will try to check if this is fixed. Thanks.

Yup, this issue could be related since the CMakeLists.txt does not provide a CMAKE_BUILD_TYPE.