Hanging at 'Files successfully emitted, waiting for typecheck results...'

3.4.1
This just started happening and can't get rid of it. Without any package changes. It had been working alright, then suddenly hangs forever. Tried npm reinstall --no-cache, updated packages to 3.4.1. Have no idea what's causing it.
Downgrading typescript (used to be 3.7.5) to 3.3 or upgrading it to 3.8.3 didn't help either. Building in node 13.7 & node 13.10, with same results.
tsconfig is the same as in the ejected CRA with additional
"experimentalDecorators": true,
    "noImplicitAny": false,
    "strictNullChecks": false

Resolved. I don't know what the initial problem was, since, again, I didn't change any packages, but I created a new CRA project with typescript and copied the libs from package.json. Works fine for now.

No, sorry. It's back again. Worked for two times, and now hanging again.

Same here.
.. and I get ReferenceError: _createSuper is not defined right at the start-up when accessing localhost:3000.

Also tried to delete the babel cache.
... after reverting to 3.4.0 everything works again.

Removed package-lock.json, and did an npm install --package-lock. Tried 3 times, it's working (still). Meanwhile I did run an npm audit fix, so I believe (and hope) that breaks the compilation for CRA 3.4.1

Hmmm, after deleting node_modules + package-lock.json, I get the following error now:
Module parse failed: Cannot use keyword 'await' outside an async function (85:31)
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.

(Cannot use keyword 'await' outside an async function is not correct, it's indeed an async method.)

My issue was with lerna run --scope ... --parallel --include-dependencies start stuck at Starting the development server.... No other output. yarn start from without the package worked as expected.
Downgrading to react-scripts 3.4.0 and babel-eslint 10.0.3 fixed the issue with lerna.

I'm currently experiencing the same issue with the dev server getting stuck on Files successfully emitted, waiting for typecheck results....
I tried the steps @sandorvasas noted above and it is still not fixing the issue for me.
@sandorvasas are you using any web workers with workerize perhaps?

I'm seeing this same issue just pop up with the dev server. Deleted node_modules and re-installed, same result. If I let the process hand for long enough it fails with JavaScript heap out of memory

I just ran another test:  npm un react-scripts && npm i<EMAIL_ADDRESS>(re-install).
Now the start is not hanging, but I still have the ReferenceError: _createSuper is not defined error.
... so this error definitely has to do with updated indirect dependencies (probably Babel which has been updated from 7.8.x to 7.9.0).

=> https://github.com/babel/babel/issues/11336

@samheutmaker Try increasing max_old_space_size.
node --max_old_space_size=8192 scripts/start.js

Can confirm this is happening as well on a fresh ejected project. It hangs on that message, but after you change a file to trigger a recompile, it stops hanging until you restart the dev server.

I've now tried with a fresh and empty CRA and i can confirm that for me it does not happen, exact package versions are listed below if you're interested.
However i was using workerize-loader to use a web worker to convert images to base-64 strings in the
background.
The import statement needed to use the worker was using a custom format:
import createWorker, {
  Workerized
} from "workerize-loader!./my-worker-file.worker";

And this worked because i had a custom typings file:
declare module "workerize-loader!*" {
  type AnyFunction = (...args: any[]) => any;
  type Async<F extends AnyFunction> = (
    ...args: Parameters<F>
  ) => Promise<ReturnType<F>>;

  export type Workerized<T> = Worker &
    { [K in keyof T]: T[K] extends AnyFunction ? Async<T[K]> : never };

  function createInstance<T>(): Workerized<T>;
  export = createInstance;
}

The import statement above also needed a // eslint-disable-next-line, when i removed it i saw that the error was stating that you shouldn't use custom imports to modify the webpack build.
This was build by my friend so i did not know what the effects were.
As soon as i added these files and used them in the new fresh CRA project i got locked at the message mentioned in the issue title.
It's not likely that you're facing this exact issue, but maybe you have custom typing somewhere that is causing this. I thought I'd put it here for future readers.
This will probably lead to us ejecting from CRA instead, since we have a couple of things that needs it.
Here's our exact package versions, since i did not get the error without the workerize-loader package, maybe you'd like to try the version of react-scripts we're using:
{
  "name": "my-app",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@babel/plugin-proposal-optional-chaining": "7.7.5",
    "@mdi/js": "4.8.95",
    "@mdi/react": "1.2.1",
    "@types/jest": "24.0.17",
    "@types/node": "12.7.1",
    "@types/react": "16.9.1",
    "@types/react-dom": "16.8.5",
    "file-saver": "2.0.2",
    "moment": "2.24.0",
    "react": "16.12.0",
    "react-dom": "16.12.0",
    "react-scripts": "3.4.0",
    "typescript": "3.7.3",
    "workerize-loader": "1.1.0"
  },
  "devDependencies": {
    "@types/file-saver": "2.0.1",
    "eslint": "6.8.0"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "babel": {
    "plugins": [
      "@babel/plugin-proposal-optional-chaining"
    ]
  }
}

Does anybody get this error like me? I have tried to up and downgrade the version of babel. But it still occurs? Could you help me explain exactly what is it? Thanks!

@KyNguyenDai => https://github.com/babel/babel/issues/11336

#8707

Same here.
But if I run yarn tsc --noEmit it's done in a second

Even better:
I did a yarn eject and changed in webpack.config.js this line to useTypescriptIncrementalApi: false, and it works again.
Will roll back and edit inside the node_modules folder for now.

I've now tried with a fresh and empty CRA and i can confirm that for me it does not happen, exact package versions are listed below if you're interested.
However i was using workerize-loader to use a web worker to convert images to base-64 strings in the
background.
The import statement needed to use the worker was using a custom format:
import createWorker, {
  Workerized
} from "workerize-loader!./my-worker-file.worker";

And this worked because i had a custom typings file:
declare module "workerize-loader!*" {
  type AnyFunction = (...args: any[]) => any;
  type Async<F extends AnyFunction> = (
    ...args: Parameters<F>
  ) => Promise<ReturnType<F>>;

  export type Workerized<T> = Worker &
    { [K in keyof T]: T[K] extends AnyFunction ? Async<T[K]> : never };

  function createInstance<T>(): Workerized<T>;
  export = createInstance;
}

The import statement above also needed a // eslint-disable-next-line, when i removed it i saw that the error was stating that you shouldn't use custom imports to modify the webpack build.
This was build by my friend so i did not know what the effects were.
As soon as i added these files and used them in the new fresh CRA project i got locked at the message mentioned in the issue title.
It's not likely that you're facing this exact issue, but maybe you have custom typing somewhere that is causing this. I thought I'd put it here for future readers.
This will probably lead to us ejecting from CRA instead, since we have a couple of things that needs it.
Here's our exact package versions, since i did not get the error without the workerize-loader package, maybe you'd like to try the version of react-scripts we're using. Beware that we are using slightly older versions of the packages since we're hunting problems of our own with this project:
{
  "name": "my-app",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@babel/plugin-proposal-optional-chaining": "7.7.5",
    "@mdi/js": "4.8.95",
    "@mdi/react": "1.2.1",
    "@types/jest": "24.0.17",
    "@types/node": "12.7.1",
    "@types/react": "16.9.1",
    "@types/react-dom": "16.8.5",
    "file-saver": "2.0.2",
    "moment": "2.24.0",
    "react": "16.12.0",
    "react-dom": "16.12.0",
    "react-scripts": "3.4.0",
    "typescript": "3.7.3",
    "workerize-loader": "1.1.0"
  },
  "devDependencies": {
    "@types/file-saver": "2.0.1",
    "eslint": "6.8.0"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "babel": {
    "plugins": [
      "@babel/plugin-proposal-optional-chaining"
    ]
  }
}

I have a very similar issue I'm experiencing for the last couple of weeks - I was sure it's related to me importing babel/rollup in some areas of the code.
My setup is very similar with workerize loader and typescript - only that I have partial typescript throughout the app and the part loading the loader is plain jsx - so I never noticed it's related.
On top of that I'm loading the worker file twice, once as a worker and once as a regular module.
Removing the workerize loader import resolved my issue! Now simply to rewrite the API between worker and main thread.

Revert to 3.4.0 solve this issue for me

im trying to run a fresh install of ionic react. when running ionic serve its hanging at "Files successfully emitted, waiting for typecheck results...". everything fresh install from nodejs to ionic..

I had same issue. Problem in my repository was that we used to use jsDocs for type annotation, and I had wrong type declaration in code, like this:
/** @type {import('./../filePath').} */
let variable;

Notice that there is nothing after .. When I removed this line, everything was working as expected.

I'm getting the same issue, tried everything in here, nothing fixes it apart from reverting which isn't ideal.

Typescript Language Server is a memory eater (2GB) and (3GB) in vscode/vim extension. Some Times this error comes up when Out of Memory Happens. Create Swap or increase memory to mitigate it. I run it in WSL so creating swap(to save RAM) worked for me.

Typescript Language Server is a memory eater (2GB) and (3GB) in vscode/vim extension. Some Times this error comes up when Out of Memory Happens. Create Swap or increase memory to mitigate it. I run it in WSL so creating swap(to save RAM) worked for me.

FYI I have analyzed this issue a little bit and opened #10871 to include a reproduction attempt. I'm pretty sure that it involves a race condition, so it is unlikely to reproduce the problem with 100%.

I face this too. In my case there is a lerna project with 12 packages in it. I updated one of the branches after a while (~800 file changes) and started one of the packages, it is taking forever in Files successfully emitted, waiting for typecheck results...
I expected there to be a process regarding node/typescript that is eating CPU or RAM, but there is nothing special. The simple  node, npm & yarn related processes are not using CPU.

Self quote from here:

As far as I understood it, it's due to Typescripts incremental API, which is invoked by fork-ts-checker-webpack-plugin. They have an update, but it isn't part of CRA yet.
https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/463
My personal solution is to opt out of the incremental API by patching CRA Webpack config.
https://github.com/pixelkritzel/savages/blob/master/patchWebpackConfig.js

This issue began for me in one of my projects after installing typescript-plugin-css-modules. I removed this and this issue has ceased since. I do not know if this information is helpful, but I thought I would add it.

Hey guys, I solved this issue with yarn.lock (or package-lock)

just use previous (working) version of lock file
clean project with this script:

rm -rf node_modules
rm -f package-lock.json
rm -f yarn.lock
npm cache clean --force

yarn install
done !

Just running npm cache clean --force fixed it for me


Tox Security Fix

Addresses temporary issue within the tool, as described here.

@emma-nechamkin and @lucasmbrown-usds feel free to merge in to your branches to fix the build issue.


Update Step1-Initial-Exploration.ipynb

simple test change

Commented on notebook Step1-Initial-Exploration.ipynb Cell 2 Line 1
REDDIT_API_URL = 'https://api.pushshift.io/reddit!'

hi! this is a test!
Respond and view the context here.

Commented on notebook Step1-Initial-Exploration.ipynb Cell 2 Line 1
REDDIT_API_URL = 'https://api.pushshift.io/reddit!'

this is a test comment!
Respond and view the context here.


Spotify api call

added a test page for the Spotify api integration.

after more testing, its still being buggy but i believe the issue is due to endpoints and how the login key is being handled. It may work perfectly on yours. if you have issues  try checking if your local server is the same as my local ip is likely different


possible error

I'm just learning so a bit unsure, but I believe scrutineer (with the "r") may have been the word the author was going for, but in this context "alternative" probably makes more sense? ...

This PR does not affect the produced WebAssembly code.

There are no such things as dead scrutinees in a call-by-value language. You are correct that alternative is the right word. It is also defined a few lines up.

Thanks, never worked in a strongly typed language.
On Sat, Jun 19, 2021 at 5:25 PM Gabor Greif @.***>
wrote:

There are no such things as dead scrutinees in a call-by-value
language. You are correct that alternative is the right word. It is
also defined a few lines up.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dfinity/motoko/pull/2613#issuecomment-864465671, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZBJWADNNBBSP6HWELRAQ3TTUDN3ANCNFSM467MDSFA
.

Incorporated into #2619


feat: JMeter Scripts to run the performance test against EDC

Description

Added JMeter Scripts to run the performance test against EDC.
Created a shell script to run the performance test which can be used later as a entry point for a container.

Closes #285
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

Hi @ndr-brt, can you please take a look here?

@ciprian-nicuta TBH I don't have an up-to-date expert knowledge about JMeter (or, better, it has been a while... :D ), so it would require me to getting some confidence before, and it could take some time maybe @paullatzelsperger or @wolf4ood are in a better shape

@ciprian-nicuta @ndr-brt unfortunately my JMeter days are long in the past as well :/

I also don't have strong skills on Jmeter but as @ndr-brt  was saying probably we can go on and merge this?
Probably i would only add some description  which outline the tests plan or what the scripts  actually do?

I also don't have strong skills on Jmeter but as @ndr-brt was saying probably we can go on and merge this?
Probably i would only add some description which outline the tests plan or what the scripts actually do?

@wolf4ood
The script documentation was already elaborated but provided in a separate PR. Please check User Guide section of added readme file for more detailed information about the scripts. Now, just to have an integrated view of the documentation and the code, the branch containing documentation was merged in here.
Beside the mentioned documentation, also a shell script mxd/performance-tests/experiment_controller.sh  wrapping the JMeter calls was now also merged into this PR. It provides users with ability to run JMeter tests in a very simplified manner and does not require JMeter app installation, taking care of the following:

Environment Setup

Creates infrastructure resources defined in Terraform
Deploys Prometheus
Creates performance-tests-pod using run_experiment.sh as entry point.

Cleans up the environment after the tests are executed
Provides the tests results in easy to use archives.


Create and refactoring CRUD operations Shkaff API

CRUD - Users
CRUD - Databases
CRUD - Tasks
Read - Segment - Statistic
Enter by Token key

In the end create documentation about Shkaff API.

Done


Computed values are incorrect

Hello, remember me? I'm no n00b anymore =)
I've tested a couple scripts to do unmatrix/decompose and yours is the only one that actually gets translation right. I need something like this to make a matrix animation for my KUTE.js, so far nothing reliable.
My problem
Have the following example

3D

The result of the decompose function for the above
transform = {
 perspective: (4) [0, -0.0017677700379863381, -0.0017677700379863381, 1]
 quaternion: (4) [0.3826834323650898, 0, 0, 0.9238795325112867]
 scale: (3) [1, 1.0000003200605172, 1.0000003200605172]
 skew: (3) [0, 0, 0]
 translation: (3) [0, 170, 0]
}

Now, the translation is right, but the rotation is less than half the input value (~ 22deg = 0.38268*180/Math.PI) and the perspective is off by about 165 (~565 = -1/-0.01767).
Questions:

what if we recalculate the quaternion matrix with a q[3] of 1, would this solve the incorrect rotation quaterion?
is this something to do with the new implementation of DOMMatrix() API to replace the old CSSMatrix?
does this have to do with Euler vs quaternion calculation of rotation?
what if we decompose the matrix by dividing functions one-by-one, the reverse process of multiplication, do you think this would work?
do you plan on updating the code?

Hello Matt @mattdesl
As promised, I wanna share with you a script I found that nearly works, it has some flaws however, but out of all it's the only one that actually gets the rotation right; it doesn't do perspective right, the skewZ is something apparently, translation is off by ~0.5% and it adds some scale, given the same example I posted above.
https://gist.github.com/joelambert/1117818
I played with it for couple minutes and I found it an interesting idea, perhaps we can have a closer look when we have more time.


Education Ramp-up

Hey @blkdm0n I have a goal to have a conversational understanding of the following topics by Monday the 17th.  Please let me know if you have any tips or see any features I’ve overlooked. :stuck_out_tongue_winking_eye:

[x] Markdown Syntax
[ ] GitHub Workflow
o	Create Repository
o	Add Commits
o	Open Pull Request
o	Discuss and Review
o	Code
o	Deploy
o	Merge
[ ] Issues
[ ] Actions
[ ] Packages
[ ] Codespaces
[ ] DevOps
[ ] DevSecOps

Hey @cheri-dean this looks like a comprehensive overview of GitHub and it's features.  I'm happy to help where I can if you should have questions.  Just give a shout!  👍

I'm closing the issue, as I now have a comfortable level of understanding of all topics.


Missing stack traces

Since 0.4 I've had the stack traces frequently missing in IJulia on OSX. I'm sorry that I don't have code to reproduce it, since the issue is fairly random. But I found a work-around today that I thought I'd share: just adding a print("") statement in the code that's run brings back the trace (adding the statement to an IJulia cell does not work).

Think this is likely JuliaLang/julia#13947 ?

Ah, very likely. I can reproduce his result. I don't rethrow anything, but I have a lot of try finally blocks.


Add TagSpecifications to ec2:CreateNetworkInterface only when len > 0

If no tags are being passed we currently still set the TagSpecification
which results in a 4xx from the ec2 API:
Unable to create interface on instance: unable to create ENI operation error EC2: CreateNetworkInterface, https response error StatusCode: 400, RequestID: 328945ae-c171-4987-b829-be5e8cd3e792, api error InvalidParameter: Tag specification must have at least one tag

Fixes 02bf3ba40040d735814c599e578a02356f4c861c.
Signed-off-by: Vlad Ungureanu<EMAIL_ADDRESS>

test-me-please

test-me-please

retest-4.9

retest-4.9

retest-4.9

retest-4.9


templates: use form and assurance macros from frontend toolkit instead of repo local copies

Story https://trello.com/c/W3d7VMrO/72-supplier-app-use-frontend-toolkit-macros-3
There still exists in this repository an app/templates/macros/forms.html (which contains... "extensions" to the toolkit-provided macros?)
Do we think these should be folded into the frontend-toolkit too?

OK so this is probably the point where this ticket becomes a "3"...
Looking at the diff between app/templates/macros/toolkit_forms.html that's deleted here and the toolkit/forms/macros/forms.html that's being dropped in as a replacement, there seem to be some non-trivial differences that mean I'm not 100% convinced that we can just swap-in the toolkit versions.
The main thing seems to be that the supplier app has |question_references(kwargs.get_question) on a lot of the values, which I think (but am not sure without further investigation) is the thing that makes the between-question references work for the supplier declaration.
So I think this needs thorough testing locally before we go any further - running through a complete G-Cloud 9 application, both declaration and services , should expose any regressions that this change would bring in.
If regressions exist (as I suspect they will), then up to you if you want to fix it all, or just shelve this ticket.

Siiii-i-igh so I can't just rely on the tests covering it.

The requirements for this are growing rapidly.
One of the main differences between the two files is that the supplier-internal versions filter their input through question_references. So with the idea that any app may want to use the question cross-reference feature, it was decided that feature should be included in the toolkit. However, that means the toolkit's macros will implicitly depend on a particular jinja filter which currently only the supplier frontend has. So we have to move the question_reference jinja filter to -utils and include it in the default selection of filters for this to continue to work across apps.
But question_reference has no unit tests, so moving it to -utils would require some unit tests written for me to feel ok about it. Thing is, that would require building a mock framework to be any use. And this would cause the -utils repo to have a dev-dependency on the content loader, which we've managed to avoid up to now.


Added Pelican, Virtual Environment and Flask

Hi, thank you for your contribution. This package provides snippets based on https://github.com/github/gitignore. So, you should suggest those changes there.


Read results from str file with results

This will fix #20 as well (Method for the user to read an .str file "directly" in C#)

Should this be a separate component or should it replace the Model.ReadStr component?

I'm tilted towards a new component since that allows us to try it out and change it without breaking the old ReadStr component.
The downside is that introducing a new component (to our API with already a lot of components) increases the complexity. The two components are similar. If the suggested component in the comment above gets no input on resultTypes we could make it behave as ReadStr does when it is provided with no bscPaths.

I think it should be the same component. I don't think two separate "ReadStr" components makes sense from a user perspective even if I understand the practical advantages. I think it sounds good that it reads only model if no bsc files are provided

I don't have a strong opinion about this. 😌

Ok! 😎
I will mark the current Model.ReadStr as obsolete ("Old" tag in grasshopper) for backwards compatability and create a this new component.

Dynamo
Should the resultTypes list be a list of ResultType enums or of string?
Enum

String

Strings are difficult as the user needs to know which strings to use. Enum is also a bit cumbersome. Maybe Model.ReadStr input resultTypes is List<SomeEnum> but there is a ParseResultType node that can be used for users who would rather use string.
Alternative if technically possible resultTypes is List<Object> with assertion that Object must be either SomeEnum or string then parser is used in node if input is string.

Also a general though on the Model.ReadStr component/node. As bscFilePath input option is removed the user will be restricted to our predefined result types. We must either have this input as optional or have two Model.ReadStr componentes/nodes otherwise we will restrict the user.

Dynamo (just like C#) allow for overload methods. Multiple methods of the same name if the input arguments are of different types. If we use argument List<ResultType> resultTypes or List<object> resultTypes, we could keep the method using List<string> bscPath as well as the new one for compatibility.


feat: #511 - nutrition page minor improvements

Impacted file:

nutrition_page_loaded.dart

explicit labels for units
removed "energy" line and computed "energy-kj" and "energy-kcal" accordingly
unit conversion (e.g. x 1000 for mg from g)
new small default nutrient unit repository

nb: kj and kcal should not be computed from one another: one field for each
also, unsure why we need mg / g conversions ? we probably shouldn't try to autoupdate fields on unit change. at the end of the day, the user is responsible for his/her input

nb: kj and kcal should not be computed from one another: one field for each

There's no connection between kj and kcal. It's just that sometimes energy-kj was empty but energy was not and energy-unit was kj => instead of displaying an empty energy-kj, I populate it with energy.

also, unsure why we need mg / g conversions ?

If we don't do that, the values are wrong for mg and µg. Just test on a product with vitamin b12.

we probably shouldn't try to autoupdate fields on unit change.

The conversion is just at init time.
There will be another conversion the other way around when saving the nutrients: it looks like we always store the values in grams, and the unit is just there for a better display.


Add an AV1 parser

Leaving this here in case anyone has any critique to offer. The basic ideas are in place, including the switch to Cow so as to clean some signatures as per #49
Still doesn't work though. I have to iron out the bugs.
With a couple weeks more this should be good to go.

Hi Daniel,
I wanted to check what the switch to Cow would look like eventually, but could not find any reference to it in the CL pushed to far - am I missing something?

@Gnurou Hi Alex, I consider this to be ready. We'll only be able to debug it further when we hook up the other bits and run it through fluster.

Merged! Thank you.


Cactbot not running

I'm really sorry about this, I'm quite new to this cactbot thing. I've been reading around but I seem to not be able to use cactbot since it keeps giving me this error message

I tried everything:

Running it as administrator
Updating all the files based on : https://www.reddit.com/r/ACTOverlayPlugin/comments/3b7ogz/instructionslatest_download/?st=j4pvvxeo&sh=c37c574a
Copying it from C to another drive and use the same file
Re-installing ACT

All kinds of effort still failing me to run cactbot. Please help

It looks like you're trying to load cactbot twice here.  The second screenshot is correct.  The first screenshot has the error.  You shouldn't try to load CactbotOverlay.dll directly from ACT.  Remove the CactbotOverlay.dll from that first screenshot.
https://github.com/quisquous/cactbot#potential-errors-and-workarounds has some notes about the "This assembly does not have a class that implements ACT's plugin interface" error.

alright, so i've removed the one from the plugin page (as in the first screenshot) and after i followed this guide:https://github.com/quisquous/cactbot#adding-overlay-modules, tested it on raid and dummy. Everything is working. Thanks!!


debug: try to wait for a debugger before running extensions

Fixes #106698
Fixes #99222
See discussion here: https://github.com/microsoft/vscode/issues/106698#issuecomment-702846751. This is the same problem we were facing on the web previously, so I implemented it in a way which will solve both.
Most of the changes here are piping data around and adding it to environments. I added a separate debugExpected from just the isExtensionDevelopmentDebug, since isExtensionDevelopmentDebug is true whenever a debugging is enabled at all, which includes running ./scripts/code-cli -- using that as the "wait" signal would cause code-cli to take an extra 5 seconds to run extensions.
Tagging Joh for review seems like you've been touching much of this code most recently according to gitlens.

Thanks for the reviews!
It looks like in node-debug2 uses --inspect-brk-extensions, but in js-debug at one point (probably while initially getting extension host dev working) that was changed for --inspect-extensions -- fixing that should fix the debugging in web scenario, and then I can remove the unnecessary generalization here.

One thing to keep in mind is that we should check if the properties need to be unset or changed when the window reloads

thanks for the callout -- it looks like debugRenderer is still in the configuration in that case, and we will not need to unset it as users cannot detach from the renderer without ending the debug session.

this is only for extension debugging

It's also used for debugging webviews. But, VS Code does not know whether the debugger will attach to webviews, extensions or both, it's only asked to expose the renderer.

@connor4312 I see. I feel renderer is a term that Electron/Chrome introduces. Maybe we find a better more generic name or is this really only specific to Electron renderers?

It's specific to electron renderers. In web we can never debug the 'renderer', as a tab cannot start another tab in debug mode.
In theory if running serverful web locally we could actually launch a debugged browser instance on the desktop, but this is probably not worth doing...


Why is KafkaSchemaRegistry inside "gobblin-metrics" package ?

Looks like the class is in the wrong package :)

This does seem like the wrong place this to live.

Yes, this is not the best spot for the Kafka dependencies and should be moved.
It will be moved to a better location.

This has moved now :)


gdpcleaner Code Function

Function is coded and performs well with all the URLs identified in the data_sources.csv


As an industry reporter, I want to see my activities in the same order every time, so that I don't get confused

Description:
IRC has requested that activities are ordered like this:
General Stationary Combustion activities
Mobile Combustion
Alphabetically after the above activities
Acceptance Criteria:
As an industry reporter
Given I am viewing the list of activities on the facility review page
Or I am walking through the activities I selected in that page
When I see the list of activities
Then they follow the ordering pattern described above
Development Checklist:

[ ] GSC activities have lower weight than all other activities
[ ] Mobile Combustion has a higher weight than GSC activities & lower weight than all other activities
[ ] All other activities have the same weight
[ ] The endpoint that fetches the set of activites sorts by weight & then alphabetically by name
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

@patriciarussellCAS  @pbastia  may not need this ticket? Was this covered by adding weights to the database?

To test: Order of activities can be seen on either the operation review or facility review pages.
Screenshot:

This worked for me. Thanks!


Cannot authenticate second instance in the string

Hi all,
I’m having an issue with connecting to 2 instances at the same time
I want to use service account key but its different for both of the instances as they are on different projects
Im calling :
cloud_sql_proxy.exe -instances=DB1=tcp:3306,DB2=tcp:3307 -credential_file=c:\KEy\db1.json & c:\KEy\db2.json
First instance connects fine but the second one is not authorised.
Can you help me with syntax to make it work please?
Cheers
Paulina

There is currently no support for using a different credential file for different databases. Other than adding changes to the client to support it, you could start two proxy processes.

Additionally, you can also add a single service account to both projects with the correct IAM roles. See here for some instructions how.


Feature/audiobook admin board

Pull Request Template
Go from a screen that selects the game play of single player or multiplayer.
When the single player mode is selected it goes into the screen which gives the option to read, write, and/or draw.
1. You will be able to check or uncheck draw or write but cannot choose both write and draw together
2. After chooseing you will be able to upload the drawing or writing to the platform.
When it is submited a function will pit the player against a randomly chosen boss.
Description
Add a summary that address the following:

motivation/purpose for the feature
To make a gamemode menu for single player where they can choose read write or draw and then upload their writing or drawing
What were those changes
A gamemode menu for uploading a drawing by choosing the button.
What issues were fixed
A gamemode styled menu
Provide the link to the user story it is referencing in Trello board or other supporting document
https://trello.com/c/Q4Wusyn7/53-create-button-to-select-single-player-mode

Commits Checklist

[ ] commits have clear title names
[ ] commit has descriptive message of what has changed
[ ] more small commits than less big commits

Code Checklist

[ ] code is formatted appropriately
[ ] code meets DRY standards
[ ] no dead code (check for logs and print statements)
[ ] no TODOS instead necessary comments
[ ] code follows Story Squad standards for:

Language
Framework
Libraries

PRs needs to be reviewed by at least 2 team members

TPL is the 3rd reviewer
Lots of comments and suggestions, please!

Pull Request Rubric

Everything looks good here Jesse; with the routes for admin, do we have protected routes set up, or is that all handled through okta?

admin has no auth set up yet so that's for another cohort


Adds xADComputer Resource

Ignores DSCResource.Tests
Updates readme and adds example
Adds unit test coverage
Fixes #69
Fixes #67

This change is

One for you @PlagueHO!

@iainbrighton  - You're a legend! I'll review tonight (unless someone else gets there first)! :+1:

Reviewed 1 of 2 files at r1, 11 of 11 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

README.md, line 233 [r2] (raw file):

### Unreleased

You should add a mention of fixing the verbose log messages and the changes (minor) to xADGroup and xADUser.

DSCResources/MSFT_xADCommon/MSFT_xADCommon.ps1, line 303 [r2] (raw file):

            if ($member -notin $ExistingMembers)
            {
                Write-Verbose -Message ($localizedString.MemberNotInDesiredState -f $member);;

Nitpick: Even though you didn't add it, can we remove the 2nd semicolon at the end of the line?

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):

$Global:DSCResourceName    = 'MSFT_xADComputer' # Example MSFT_xFirewall

#region HEADER

Can you convert the template into the new version (v1.1.0) Unit Test Template?

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 28 [r2] (raw file):

    # The InModuleScope command allows you to perform white-box unit testing on the internal
    # (non-exported) code of a Script Module.
    InModuleScope $Global:DSCResourceName {

You should probably get rid of the InModuleScope block as it isn't required. The templates got changed a few weeks ago to remove this so that it was only included when private functions needed to be tested.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 56 [r2] (raw file):

        $testDomainController = 'TESTDC';
        $testCredential = New-Object System.Management.Automation.PSCredential 'DummyUser', (ConvertTo-SecureString 'DummyPassword' -AsPlainText -Force);

PSSA is probably going to throw a hissy fit about this line so we'd need to add a [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "")]

Comments from Reviewable

Review status: all files reviewed at latest revision, 5 unresolved discussions.

README.md, line 233 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> You should add a mention of fixing the verbose log messages and the changes (minor) to xADGroup and xADUser.

Done

DSCResources/MSFT_xADCommon/MSFT_xADCommon.ps1, line 303 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Nitpick: Even though you didn't add it, can we remove the 2nd semicolon at the end of the line?

Done (it probably was me at some point!)

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> Can you convert the template into the new version (v1.1.0) [Unit Test Template](https://github.com/PowerShell/DscResources/blob/master/Tests.Template/unit_template.ps1)?

I attempted to update the template and _everything_ blew up. Now, this might be due to not being able to install the AD RSAT tools on the latest Win 10 slow ring build. I will try in a VM over the weekend/early next week.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 28 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> You should probably get rid of the InModuleScope block as it isn't required. The templates got changed a few weeks ago to remove this so that it was only included when private functions needed to be tested.

Acknowledged.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 56 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> PSSA is probably going to throw a hissy fit about this line so we'd need to add a [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "")]

Can the attribute be placed at the beginning of a .PS1 file (outside of a function)? Not checked, but will try and see what the PSSA says..

Comments from Reviewable

Review status: 10 of 12 files reviewed at latest revision, 5 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):
Previously, iainbrighton (Iain Brighton) wrote…
> I attempted to update the template and _everything_ blew up. Now, this might be due to not being able to install the AD RSAT tools on the latest Win 10 slow ring build. I will try in a VM over the weekend/early next week.

@PlagueHO Removing the `InModuleScope` scriptblock causes me a real problem and results in __every__ test failing. All I receive are `The term 'xxx-TargetResource' is not recognized as the name of a cmdlet`. Here's an example:
```
Describing MSFT_xADComputer\Get-TargetResource
 [-] Returns a 'System.Collections.Hashtable' object type 9.01s
   The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
   at line: 65 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
 [-] Returns 'Ensure' is 'Present' when user account exists 161ms
   The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
   at line: 73 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
 [-] Returns 'Ensure' is 'Absent' when user account does not exist 165ms
   The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
   at line: 81 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
 [-] Calls 'Get-ADComputer' with 'Server' parameter when 'DomainController' specified 163ms
   The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
   at line: 89 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
 [-] Calls 'Get-ADComputer' with 'Credential' parameter when 'DomainAdministratorCredential' specified 164ms
   The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
   at line: 97 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
```
I've not had a real chance to dig into what the test helper(s) are doing, but it looks like the module's not imported correctly. It might be something to do with my setup though. Ideas?

Comments from Reviewable

Superb work on this BTW! :+1:
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> @iainbrighton  - You're a legend! I'll review tonight (unless someone else gets there first)! :+1:

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):
Previously, iainbrighton (Iain Brighton) wrote…
> @PlagueHO Removing the `InModuleScope` scriptblock causes me a real problem and results in __every__ test failing. All I receive are `The term 'xxx-TargetResource' is not recognized as the name of a cmdlet`. Here's an example:
> ```
> Describing MSFT_xADComputer\Get-TargetResource
>  [-] Returns a 'System.Collections.Hashtable' object type 9.01s
>    The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
> Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
>    at line: 65 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
>  [-] Returns 'Ensure' is 'Present' when user account exists 161ms
>    The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
> Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
>    at line: 73 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
>  [-] Returns 'Ensure' is 'Absent' when user account does not exist 165ms
>    The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
> Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
>    at line: 81 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
>  [-] Calls 'Get-ADComputer' with 'Server' parameter when 'DomainController' specified 163ms
>    The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
> Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
>    at line: 89 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
>  [-] Calls 'Get-ADComputer' with 'Credential' parameter when 'DomainAdministratorCredential' specified 164ms
>    The term 'Get-TargetResource' is not recognized as the name of a cmdlet, function, script file, or operable program.
> Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
>    at line: 97 in C:\Users\iainb\Dropbox\PowerShell\DSC\Resources\xActiveDirectory\Tests\Unit\MSFT_xADComputer.Tests.ps1
> ```
> I've not had a real chance to dig into what the test helper(s) are doing, but it looks like the module's not imported correctly. It might be something to do with my setup though. Ideas?

I'm scratching my head on this. It "should" work just fine. Let me have a dig about in some of my modules and see if I can replicate the problem. I might clone your repo and see if it happens with mine. Not good - don't want to be telling people to remove the InModuleScope if it in fact requires it!

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 56 [r2] (raw file):
Previously, iainbrighton (Iain Brighton) wrote…
> Can the attribute be placed at the beginning of a .PS1 file (outside of a function)? Not checked, but will try and see what the PSSA says..

I think it can be - at least the documentation says it can be: https://github.com/PowerShell/PSScriptAnalyzer#suppressing-rules
Although I think outside a function you need to add:
[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "", Scope="Function")]

Comments from Reviewable

Thinking about this (on the train), isn't the module imported inside the TestHelper scope? This is a different scope to where the Pester tests are executed and might be why they can't be found..?

@iainbrighton - oh my - you could very well be correct. That would make a lot of sense. I say we use InModuleScope until we figure out a solution.
If there is no solution then we need to revert the Test.Templates and the TestGuidelines.
@KarolKaczmarek, @narrieta - can you think of a way around this problem: If the DSC Resource being tested is being imported by the Test.Helper.psm1 module, not by the actual unit test script, then it is not in the scope of the unit test script - so the tests needs to be in an InModuleScope block.

@PlagueHO - in my opinion the module to test should be imported within the scope of the test script, rather than in the scope of Test.Helper.psm1. Importing at the global scope (Import-Module -Global) may also work, though I think the first option would be preferable.
One question regarding the import: Initialize-TestEnvironment explicitly removes the module before importing it. Is Import-Module -Force not enough?
One observation about Initialize-TestEnvironment: when I tried to execute the unit tests for ADComputer my PowerShell session seemed to hang so I had to kill the process. From then on, all the new PowerShell instances I started were extremely slow. The issue turned out to be duplicated entries in PSModulePath. Initialize-TestEnvironment changes the module path at the machine level; consider changing it at the process level and checking for duplicates. The execution policy should probably also be changed at the process level.

@narrieta - thank you for looking at this and the info.
Regarding the Import-Module -Force - I think you're right, using the -Force parameter should be enough.
As for the Initialize-TestEnvironment problems, there is actually an issue in place that relates to this. I'm looking at doing some work on this but was just waiting to get a bit more feed back before proceeding. But it looks like the issues are really mounting up with this stuff so I might just go ahead and PR a solution and let people comment on that. I do agree though, the PSModulePath should only be changed at the process level - but only for the unit tests. For the integration tests to work this still requires the machine level changes because the LCM runs under a different process.
Thanks again for commenting on this - sorry @iainbrighton for hijacking this PR.

@PlagueHO @narrieta No problem! If the import in the TestHelper.psm1 is changed to Import-Module -Name $DSCModuleFile.FullName -Force -Scope Global, then I can see the publicly exported *-TargetResource functions.
However, I can't seem to then mock the internal calls to Get-TargetResource from the Test- and Set-TargetResource functions without the InModuleScope [sigh].

@iainbrighton @PlagueHO OK, too bad -Global doesn't work. I would recommend then importing the module to test from the test script instead of from TestHelper.psm1. It may be a small inconvenience but then only the code that actually needs access to the privates of the module needs to use InModuleScope (instead of the entire code of the test). Especially if we are doing this in the template that new test should follow.

@narrieta, @iainbrighton  - I've moved this issue out into a new issue in DSCResource.tests. Thanks heaps for looking into all of this.

Reviewed 1 of 2 files at r1, 7 of 11 files at r2, 3 of 4 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> I'm scratching my head on this. It "should" work just fine. Let me have a dig about in some of my modules and see if I can replicate the problem. I might clone your repo and see if it happens with mine. Not good - don't want to be telling people to remove the InModuleScope if it in fact requires it!

Why did we remove InModuleScope?  Resources with private functions won't be able to be tested without this.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):
Previously, TravisEz13 (Travis Plunk) wrote…
> Why did we remove InModuleScope?  Resources with private functions won't be able to be tested without this.

I got my answer offline.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 4 [r2] (raw file):
Previously, TravisEz13 (Travis Plunk) wrote…
> I got my answer offline.

Here are the original discussions for a bit more context:
https://github.com/PowerShell/DscResources/issues/115
https://github.com/PowerShell/DscResources/issues/123

Comments from Reviewable

I reviewed, two discussions waiting on @iainbrighton  and @plagueho  to  say they are satisfied with the resolution.
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> @narrieta, @iainbrighton  - I've moved this issue out into a new issue in DSCResource.tests. Thanks heaps for looking into all of this.

Reviewed 1 of 4 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 56 [r2] (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
> I think it can be - at least the documentation says it can be: https://github.com/PowerShell/PSScriptAnalyzer#suppressing-rules
>
> Although I think outside a function you need to add:
> ```[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "", Scope="Function")]```

I think using an empty [PSCredential] is the "cleaner" way of solving this (rather than suppressing the rule)?

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/MSFT_xADComputer.Tests.ps1, line 56 [r2] (raw file):
Previously, iainbrighton (Iain Brighton) wrote…
> I think using an empty [PSCredential] is the "cleaner" way of solving this (rather than suppressing the rule)?

I'm all for the cleaner way!

Comments from Reviewable


Make architecture more coherent for data storage

At the moment we have caches of records in postgres (fine) and big tables of lookups in redis (fine), but we also have Sqlite for label and URI based reconciliation. And then we have some URI reconciliation tables in redis. Sqlite is just an sql implementation ... so it could equally migrate into postgres?
Figure out where the different types of data lookups should live, and then fix the implementation to do that.

For data currently managed in SQLite, we should see significant performance gains from using LMDB (via lmdbm):
https://pypi.org/project/lmdbm/
For 1M random reads, LMDB took 10 seconds, whereas Sqlite took 447.

Storage proposal:

Key/Value that needs multiple writers goes to redis.

Thus idmap, reference tracking, network result tracking

Key/Value that can be written once and then needs fast read goes to lmdb.

Thus reconciliation, differentFrom, or other static tables

Documents go to postgres.

Thus existing caches, but not key/value

Rationale:
Multiple processes writing to LMDB can cause the file size (and thus memory footprint) to grow constantly as the different writers don't have access to others' pages. So we can't use it for a redis replacement easily. It's designed for values up to 2k bytes, so also not good for documents, as it'll cause paging across single values.
Redis is very fast and supports multiple writers and readers. Could be distributed over the network if needed rather than local.
Postgres is good at dealing with tons of data (1.5Tb currently) and has native JSON tables. Easy to add metadata fields and indexes. Could swap for CouchDb, CouchBase, CrateDB, MongoDB or others ... but no reason to believe there'd be significant performance gains from doing so. Can be distributed or local as needed.
Changes to make:

[ ] Implement LMDB based reconciliation store
[ ] migrate redis distinct and equivs to LMDB (along with all the existing ones)
[ ] determine if we need networkmap and redirects tables in redis
[ ] further consider record refs tracking vs ML queries

No Change:

idmap, networkmap, all_refs, done_refs stay in redis


Add progress option to ve_run

Description
This PR adds a simple optional progress report to ve_run, so that something happens when the command runs and logging is being sent to file (which is likely all reasonable use cases).
When ve_run is executed with --progress, a user sees:
Starting Virtual Ecosystem simulation.
* Logging to: /tmp/ve_example/out/logfile.log
* Loading configuration
* Saved compiled configuration: /tmp/ve_example/out/vr_full_model_configuration.toml
* Built core model components
* Initial data loaded
* Models initialised: plants, animals, litter, hydrology, abiotic_simple, soil
* Starting simulation
100%|███████████████████████████████████████████| 24/24 [00:06<00:00,  3.52it/s]
* Simulation completed
* Merged time series data
* Saved final model state
VR run complete.

Fixes #402
There are probably more elegant ways of handling the tqdm progress bar, but tqdm is usually used with a for loop rather than while. We could explicitly loop over the known number of updates at the moment, but retaining the current while timing loop is a useful implicit reminder that updates might not always be synchronised.
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Just spotted the VR  in VR run complete.

I think we are using while because the original conception of the model had a kind of event stack - not everything happened on a synchronised tick with a fixed set of update times. I think that is something we may want to bring back in at some point. But ultimately, although a for loop would work better with tqdm here, I wanted to keep the changes simple.


The website cannot render in the edge browser

When I committed, the website looks different in the Edge browser and in the Chrome browser, I only change the _config.yml, can anyone help me with it?

Hi, same issue here. Have you fixed it now? If so, it will be of great help if you could tell me the solution. Thanks!

The latest updates might have fixed this as I'm unable to reproduce the error on Edge.


New blog theme

https://github.com/Tazeg/hugo-blog-jeffprod
Regards

Hello @Tazeg,
thank you for sharing this theme with the Hugo community :+1:
I've checked your theme and noticed that the thumbnail and screenshots in the images folder don't have the right dimensions. Please correct them in order to display them correctly on the Hugo theme site. You can find the dimensions in the README.
Furthermore, the background image in the hero of your theme isn't shown because it's linked relative to the root url (/). But websites can also be hosted in a subdirectory like www.example.com/blog. This is also the case for the theme demos. Hence the path to the image has to take this into account. This can be fixed by using the absURL or relURL template function that handles this corner cases for you:
{{ "path/to/image.png" | absURL }}

Note that I omitted the leading slash in the path.
Otherwise your theme seems looks fine :)

Fixed. Thanks.

There's nothing to apologize for.
One thing that I should have noticed earlier is that the tag cloud on the right contains tags (implying that there is some sort of content) but no blog posts are shown on the homepage.
The reason for this is that you list all pages of type article. Hugo uses this repository to populate a demo with content. As you can see in it's content folder only pages of type post (!= article) are present. Hence the loop the template for the homepage doesn't loop over them.
Instead I would make use of .Site.RegularPages and the .Site.Params.mainSections parameter. .Site.RegularPages lists pages that relate to an actual content file (i.e. a blog post). Those are the files that we're interested in.
However, it's still possible that some regular pages shall not be shown on the homepage because they aren't blog posts. A user could create a file at content/about-me/_index.md to create an about-me-page, which we would not list as blog post on the homepage.
That's where .Site.Params.mainSections comes into play. By default Hugo adds all those sections to .Site.Params.mainSections that contain the majority of content files. It's likely that the posts or article section will be included by default (usually there are a lot of them), but not our about-me-page (because the about-me section only contains a single content file).
Combining both we can list all content files (the regular pages) that are of interest (i.e. those in a main section):
{{ $pages := where .Site.RegularPages "Type" "in" .Site.Params.mainSections }}
{{ $paginator := .Paginate $pages }}
...

{{ range $paginator.Pages }}
...

If Hugo's guesses for the main sections wasn't correct users can overwrite .Site.Params.mainSections in the config file:
[params]
mainSections = ["blog", "docs"]

Back to our initial issue: right now blog posts have to be in content/articles/ in order to be displayed which isn't a very flexible approach. Above we saw that this can be fixed without much work. At the end it doesn't matter if a user prefers to store the blog posts in content/articles/ or content/posts/. .Site.Params.mainSections will likely contain those sections by default.

Thanks for those helpfull explanations. I keep them in mind.
I could make it work as you said but not for "archives" which has to be a groupby and count on posts years.
Moreover, it can't work both for your "hugo templates site" and for the explanation I made at https://fr.jeffprod.com/blog/2018/creez-un-blog-en-deux-minutes-avec-hugo.html
So i may fork the projects soon to separate.
You can close this issue. I may open another one later with a working theme for Hugo.
Regards.

Your theme itself is working fine. The only "issue" with your theme's demo is that no blog posts are shown, which could look like a bug.
However, we can circumvent that by providing our own demo content. That's where the exampleSite folder comes into play. It basically mirrors the the root directory of every Hugo website, which contains the config file, the theme and content folder etc.
The exampleSite folder you can be populated with demo content at exampleSite/content/articles. This way we have content of type article that is actually displayed by your theme on the homepage.
For the setup you can find further information in the README. As always don't hesitate to ask if you got stuck.

Hello, i made fixes. Could you try again please ? I added a "exampleSite" directory which is a copy of "HugoBasicExample/content" but i added the param "archives" in posts file so that they appear in the widget.

Hello @Tazeg,
when referring to your theme in the config.toml please make sure you use the full name of your repository. Hence replate "jeffprod" with "hugo-blog-jeffprod". Otherwise Hugo isn't able to find the correct theme because a theme folder named jeffprod is expected.

Done. Thanks.

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.


ci: cache deno files

sorry for the previous commits, please squash

@not-ivy why does this pr modify request_context.ts though? 😂

& we should use v3 of the cache action


Add all language localization for SPARK ability rows

Currently there's English localization.

Issue implemented, closing.


Fix for flexible CAN baud rate

Fixes https://github.com/arduino/ArduinoCore-renesas/issues/295

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[core] officially support SFT (Supervised Finetuning)

What does this PR do?
This PR introduces SFTTrainer class. A handy and easy to use class to train your supervised fine-tuned model on instruction-based datasets.
The API is easy to use, and also modular enough if you want to customize your training for advanced users.
You just need to pass a model id, optionally pass a PeftConfig to train adapters only. Pass also from_pretrained kwargs directly to SFTTrainer for advanced users, for example to load your model in 8bit mode.
The PR also introduces ConstantLengthDataset, a handy class to create instruction-based datasets. Just pass a tokenizer, a dataset, and a function to specify the formatting you want to have, and you should be good to go
Quickstart:
from transformers import AutoModelForCausalLM
from datasets import load_dataset
from trl import SFTTrainer

dataset = load_dataset("imdb", split="train")

model = AutoModelForCausalLM.from_pretrained("facebook/opt-350m")

trainer = SFTTrainer(
    model,
    train_dataset=dataset,
    dataset_text_field="text",
)

trainer.train()

cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

No, the SFTTrainer only trains on the text with the causal language modeling objective.

Is this function suitable to train a instruction-following LLM? I reviewed the code and can't find the code about labels that avoiding to calculate the loss of instruction, prompts and labels.

See the docs here: https://huggingface.co/docs/trl/sft_trainer#train-on-completions-only


Refactor: Integrate vscode-exthost with scanner / manifest

Paired with: https://github.com/onivim/reason-vscode-exthost/pull/22 - this refactors to use vscode-exthost to manage extension scanning and extension manifest, along with all the types that are used by the manifest.
Functionally, there should be no change, and this does not yet use vscode-exthost to actually run the extension host - but it hooks up some of the extension pieces, so that we have less plumbing to do when we actually go to make the switch to replace the ExtHostTransport/ExtensionClient with the new extension host.

I'll close this out, and migrate reason-vscode-exthost over instead


GROUP RUBY CAPSTONE PROJECT

This PR Contains:
This is the link to our Project: Project Link
We are two members in this group 2⃣

Md. Porag Sarkar is team member 1 and was assigned a task list for team member 1
Ansar Ibrahim is team member 2 and was assigned a task list for team member 2

Changes Required ♻
Hi @AnsarIbrahim and @porag-m06,
Nice job, you are almost there.

(Changes Required) Aspects to improve: ♻

[ ] As per this requirement, Please add a descriptive title for all group tasks that you created, for example, the group task 1 suppose to be named Create Item class.

[Optional] suggestions:

Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

I have implemented the revisions suggested by the reviewer.

Hi Team,
STATUS: APPROVED! 🥇 💯
Great work on making the changes 👏
You've done well implementing the requested changes

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Highlights

Great job, implementing the requested changes :+1:

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


MAINT: Clean up raw.plot capture

Closes #12930
Turns out we already had a context manager for this stuff and scrollbars were already in the _toggle_zenmode. So just need to call that instead (and have https://github.com/mne-tools/mne-qt-browser/pull/295)!

Nice, this looks much better! Thanks @larsoner!


modified pos_tag and pos_tag_sents for russian pos-tagging

I have modified pos_tag and pos_tag_sents methods from tag module so that they work not only for English texts but also for Russian. An additional parameter 'language' was added. The parameter's default value is 'english', thus the methods behave the same way as before when 'language' is not specified. For Russian pos-tagging, the parameter needs to be set to 'russian'.
I trained an averaged perceptron model for part-of-speech tagging of Russian texts. For training I used Russian National Corpus (consists of 94240 tagged sentences with over 1 million tagged tokens): http://ruscorpora.ru/en/index.html
Methods of PerceptronTagger class from tag module were used for training and storing the model file.
The average accuracy of the model is 99% (measured by 10-fold cross-validation).

Looking forward to this one. Good work!

@tsolakghukasyan – thanks for the contribution. Can I ask you to change the optional argument and value to lang = "rus" for consistency with the rest of NLTK, since we use the lang attribute and ISO 639-3 codes for identifying languages. Thanks.

@stevenbird thanks for the reply. I have made the necessary changes.

Thanks @tsolakghukasyan


Allow methods to be used in @ToString and @EqualsAndHashCode

There are many requests for customizing @ToString and other annotations, so I'm proposing a simple way (based on ideas from this discussion) how many such requests can be easily fullfilled: Allow to exclude fields (already possible) and include methods in the computation. So the solution for #1392 would be simply
@ToString
class Article {
    private String author;
    private String title;
    @ToString.Exclude
    private String content;

    @ToString.Include
    private String shortenedContent() {
        return content.substring(0, Math.min(content.length, 100));
    }
}

This is surely more verbose than some @ToString(maxLength=100), but imagine you need to append the field length. Or there's another field which should never be shortened. Or another field signature which is uninteresting, but you want to see its length. This all can be achieved easily with methods inclusion.

An alternative stringly typed syntax: @ToString(exclude="content", include="shortenedContent()").

Includes #1385?

@omega09 I don't think, it "includes" it, especially it wouldn't allow you to call the Apache builders. But it'd allow you to do about everything their builders can do, except for styling, which is an orthogonal feature.
My proposal is good in case you want to change what happens for some fields while leaving lombok do its usual job for the others. Leaving out an offending field has always been possible, but sometimes, that's too harsh. When you want to summarize it instead, my proposal helps. It tries to combine the flexibility of a hand-written method with Lombok's power of handling boilderplate for free.

It will be good if these methods can be customized. I would like to use json presentation for toString().

Working on it: Working on it: https://github.com/rzwitserloot/lombok/wiki/FEATURE-IDEA:-Annotation-based-Include-Exclude-for-ToString,-EqualsAHC,-etc


Single carriage return (\r) not treated as line break

Describe the bug
Single carriage return line endings (\r) are treated as non-breaking characters. This is contrary to the YAML spec, which explicitly calls out CR, LF and CRLF as the (only) possible line breaks.
A similar problem afflicts other parsers, for example https://github.com/jbeder/yaml-cpp/issues/986
To Reproduce
const lfTokens = Array.from((new Lexer()).lex("text: \"a\n\n\n\n b\""));
console.log(lfTokens.length);

const crTokens = Array.from((new Lexer()).lex("text: \"a\n\r\r\r b\""));
console.log(crTokens.length);

Note the output:
6
9

Expected behaviour
6
6

The extra tokens in the second case are a result of \r being treated like any other (non-breaking) character, meaning the tokens are split only at the first \n and not reassembled:
(..., a, \n, \x1F, \r\r\r b)
Versions (please complete the following information):

Environment: [e.g. Node.js 14.7.0 or Chrome 87.0]
Node.js 20.17.0

yaml: [e.g. 1.10.0 or 2.0.0-2]
2.6.1

Additional context
There are several places this seems to manifest, for example:
https://github.com/eemeli/yaml/blob/main/src/parse/lexer.ts#L223
https://github.com/eemeli/yaml/blob/main/src/parse/lexer.ts#L191

While recognising that this is a divergence from the spec, does it affect any real-world use for you? As in, do you have some content that is actually using a lone \r as a line break?

No real-world impact at the moment, beyond the time spent debugging it.
For full context: I'm working on a component that extracts YAML fields from a larger document for passing to a third-party tool, and needs to be able to correlate line and column number from that extracted content with the original document.
I'd hoped I could reuse much of the existing logic, but given the need to know about the effects on column position of expanding, for instance, escape codes, for now I'm effectively replacing the whole "compose" layer. In the rewritten version, I keep track of positions, so I can emit a list of coordinates with the composed text that lets me align it to the original source doc.
My set of unit tests/edge cases for this include a mixture of line endings, and those are failing, which is why I had to track the problem back through the layers (right to the lexer).
If there's no intent to fix this, for now I just need to ensure all my test cases use only \n or \r\n, and that I document that as a restriction. I think mixing those two in a file would also be supported, as most/all of the problems I've encountered so far seem to revolve around \r.


Issue kerberos ticket retrieval

I´m experiencing an issue when running Debug-AzStorageAccountAuth in powershell, shows an issue regarding kerberos retrieval, when I check with the following cdmlet:
klist get cifs/stfileserverpruebas.file.core.windows.net
It shows the next error text:
Current LogonId is 0:0x18cf60
Error calling API LsaCallAuthenticationPackage (GetTicket substatus): 0x35
klist failed with 0x80090303/-2146893053: The specified target is unknown or unreachable
Any feedback would be great help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fba964be-3f77-d80c-f1a5-35bb1430bb8f
Version Independent ID: fe70b11e-10fe-5a8c-1fad-b22a83693503
Content: Enable Active Directory authentication over SMB for Azure Files
Content Source: articles/storage/files/storage-files-identity-auth-active-directory-enable.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@erikdfuqueneb Thanks for the question! We are investigating and will update you shortly.

@erikdfuqueneb We need work closer on this issue, I would recommend you to contact support, so If you have a support plan, I request you file a support ticket, else please do let us know, we will try and help you get a one-time free technical support. In this case, could you send an email to AzCommunity[at]Microsoft[dot]com referencing this thread as well as your subscription ID. Please mention "ATTN subm" in the subject field. Thank you for your cooperation on this matter and look forward to your reply.


How to show a preview when typing or moving cursor

Is it possible to print a preview (maybe multiline) when user is typing or moving the cursor, like a menu that the user can not interact with.
Example
When editing, print the evaluation preview of the expression under the cursor:
~/Code/reedline〉(1+1█) *3
2

Once enter is hit, clear the preview, and the main program prints the result:
~/Code/reedline〉(1+1) *3
6
~/Code/reedline〉█

In nushell, user can edit the filter expression and preview the result:
~/Code> ls | where type == 'dir█' | table
╭───┬────────┬──────┬─────────┬────────────────╮
│ # │  name  │ type │  size   │    modified    │
├───┼────────┼──────┼─────────┼────────────────┤
│ 0 │ cmd    │ dir  │ 4.0 KiB │ 2 months ago   │
│ 1 │ crates │ dir  │ 4.0 KiB │ 2 weeks ago    │
│ 2 │ dev    │ dir  │ 4.0 KiB │ 15 hours ago   │
│ 3 │ docs   │ dir  │ 4.0 KiB │ 2 hours ago    │
│ 4 │ logs   │ dir  │ 4.0 KiB │ 19 minutes ago │
│ 5 │ target │ dir  │ 4.0 KiB │ 21 hours ago   │
│ 6 │ tests  │ dir  │ 4.0 KiB │ a week ago     │
│ 7 │ xtask  │ dir  │ 4.0 KiB │ 2 months ago   │
╰───┴────────┴──────┴─────────┴────────────────╯

sounds a bit dangerous. However, in explore there is :try

Yeah... But my use case is a simply math evaluator and in that case it is fine.

With the current design of reedline there are no provisions for that (parallel evaluation, with managed output).
From our side this has a low priority (we as Nushell would probably only use such facilities for other status output, without clear existing requirements for that yet).
So no guarantees that an addition in that direction will receive maintenance support.
Currently reedline's add-on components are all evaluated in line and in a blocking fashion. So if anything takes too long the UI slows down/freezes. We could accept something in the same vain without much redesign, but if you want that particular feature non-blocking we clearly have to prioritize the design of asynchronous updates for the more important components of reedline.


Menu is light on the dark mode

Hi,
Menu is light on the dark mode.

Thanks for reporting the issue! this is caused by the theme changes in the last update, I will work on fixing it .

The issue has been fixed in version 2.13, available now on Github releases and soon on Google Play and F-Droid.


Responsiveness

first pass responsiveness on all pages with some outstanding issues here and there with  components, svgs, and a handful of others documented in Trello

updated a few svg images w minor alterations by Vic

Discussed a few things w Colby on the phone and we decided it would be good to merge this as a baseline for responsiveness to build from.


Support for tools:plugins

Please see the resulting changes. All the changes for plugins module are already in tools project

We should not apply this yet.

Now as we have plugins we can merge this to support them


Upgrade to React 16

- Summary
Upgrade to React 16 (and upgrade other React-related libs).
Closes #664.
- Test plan
TODO: All tests pass, and manual testing reveals no regressions.
- Description for the changelog
Upgrade React (and related deps) to v16.
- A picture of a cute animal (not mandatory but encouraged)

There is a small regression here: If someone creates a new entry, then (without making any changes), clicks the "Home" button, they are presented with two confirm dialogs, instead of just one.

@tech4him1 what are the effects of the breaking change you listed for enzyme in #664?

@Benaiah Enzyme was updated in d2a0477.

Out of the peer-dep warnings, these are the only React 16 ones that are actually for one of our deps, not sub-deps:
<EMAIL_ADDRESS>-- This can be done after merge, since it is just a dev dependency.
<EMAIL_ADDRESS>-- This still works fine, they just haven't released the new version yet.
<EMAIL_ADDRESS><EMAIL_ADDRESS>-- A new version was released, but this one still works fine, so we can just wait on it.


Allow UUID as a group name

UUIDs should be allowed to be used as a group name since it's a very common scenario.
The current limitation is the following:

should start with alphabetic characters and only contain alpha-numeric characters or underscore

source: https://github.com/MicrosoftDocs/azure-docs/issues/20988

We will change the limitation to less than 256, allow any character, like space, emoji.

Following cases are invalid:

Empty
LongLong...LongString (>256)

Following cases are valid

1234
GUID
1 2 3
123-456
~!@#$%^&*()_+=[]{}\|;:'",./<>?
:smile: emoji

If your group name contains spiecal characters, for rest API, you should encode the group name (like encodeURIComponent).
It will be release by service.

@vwxyzh great news! I'm looking forward to it. Do you have ETA? What do you mean by "It will be release by service."?

About 11 March, release to all regions may be one week.
This limit is in SignalR service side, we will update service, so no SDK changes.

Is there an official documentation page where we can track this?


George/number service

Coverage increased (+0.005%) to 99.751% when pulling 4e95968090eecccf1484f23aab26580240340f24 on george/number-service into 955420a8d61117a4175b7463dc61ab4133e47232 on development.


Should module completion value be fulfillment value of the promise?

When the initialization of a module completes normally it has a completion value that is generally the value of the last expression evaluated within the module body (see <IP_ADDRESS>). For static imports this completion value is discarded because there is no way for ES code to capture and process it.
However, dynamic-import is a different situation in that it returns a Promise to the ES code.  The fulfillment value of that promise could be used to transmit the module completion value back to the ES code that dynamically imported the module.
For this to work with multiple imports (either static or dynamic) of the same module, the completion value would have to be captured in the module record by the import that actually evaluates the body.
A Use Case
One reason that might be desirable is to enable a dynamically imported module to return a require-like export object:
//foo.js
//static exports accessible via static import
export function bar() {}
export function baz() {}
//make foo and bar available to dynamic importers
({bar, baz});   //this is the module completion value

//client.js
import("./foo.js").then(foo => {
   foo.bar();
   foo.baz();
});

A Concern
(attention @erights)
It seems like such a dynamic module completion value could be used to create a communications channel that could pierce an intra-realm membrane.  Consider a collaborator, outside of the membrane,  does a dynamic import of module "X" and obtains  an object as the module's completion value.  The collaborator adds a property to the object and uses it to store private data that only exists outside the membrane.  Code within the membrane also does a dynamic import of module "X" and obtains  the same completion value object.  That code now has access to the private data stored in the object by the collaborator.

My understanding is that the promise already currently resolves to an object containing all the exports - ie, in your example, even without the last line of foo.js, your client.js example should work.

@ljharb You're right, I missed that.
Membrane penetration still seems a concern.  Returning the module namespace object means that any module that has an export whose value is a mutable object (eg, any exported function) could be used to pierce a membrane.

Right, I don't plan to change the fulfillment value of the promise, or start giving meaning to the completion value of a module. (This isn't an eval API; it's an import API.)
I don't understand how there could be an issue with membranes here that is not also present with static imports, or with the host-specific mechanisms that are present in specs currently. I'd like to close this issue for now, but if we believe the membrane issue is worth investigation then we should open a separate issue for that.

if we believe the membrane issue is worth investigation then we should open a separate issue for that.

We do.
https://github.com/tc39/proposal-dynamic-import/issues/26


feat: offset radius for section added.

Adds offset radius to each section

Fixes #1146

Hi. Thanks for contributing.
Is there any related issue to this change? If you found any, please mention them.
BTW you need to update CHANGELOG.md and pie_chart.md files.
We explained the contribution details here.

@imaNNeoFighT changes made

Great!
I suggest you change offsetRadius to offset or centerOffset.
What do you think?

@imaNNeoFighT changes made. Thanks

Any update?

@imaNNeo changes pushed.

It is ready to merge. But you need to make some minor changes:

Please remove the changes in the examples.
Please update the CHANGELOG.md file to write about your feature.
Also, don't forget to update the docs in bar_chart.md

Thank you!

Don't forget to read the contributing guideline.


fieldSelector should support not only metadata.name and metadata.namespace

DynamicInformer supports only these fields. Usual Informers support more fields.

Research done in related PR #60 . Filter by arbitrary fields can be implemented on the client side as a workaround.

The limitation of a fieldSelector is now in README, thanks to PR #60.


Add Vietnamese Language

I just created Vietnamese Language file. Please accept.
Thanks.

Thank's!
And please, add in readme file this language with flag.


Restrict total label count to satisfy new limit

Occasionally, pull requests to WPT modify many files across many
directories. That causes this project to assign a large number of
labels, although in practice, modifications of this type are
infrastructural in nature and do not typically concern specification
compliance.
As of 2018-07-26, GitHub.com restricts the total number of pull request
labels to 100. Ensure that no more than 100 labels are ever assigned to
a pull request by replacing over-long lists with the labels infra and
very-large.
This is intended to resolve gh-35. It depends on gh-36

Following the merging of gh-36, I've rebased this onto master. I've force-pushed the result since doing so doesn't interrupt any ongoing review.

I didn't check the tests; it seems like a large addition that should probbly be in a seperate patch?

I agree that the regression tests shouldn't be coupled with the implementation change they are intended to support. I assumed separating them via git commits would be sufficient to facilitate review and to demonstrate consistency in behavior before and after the modification to the application code. Since I wouldn't advise landing the second commit without the first, an additional GitHub Pull Request initially seemed to require extra coordination without much benefit. Would making a new pull request help reviewing? If so, I'm happy to oblige!

@jugglinmike can this be merged?

@jugglinmike I've rebased the branch and resolved conflicts but can't push the results. I pushed to a branch in this repo and created https://github.com/web-platform-tests/wpt-pr-bot/pull/88. It still doesn't pass npm run test, so if you want to take a look I'll close my clone PR.

The tests were failing due to changes that were introduced in the time since this patch was written:

gh-51 caused the application code to issue another request to the GitHub API, and the fixtures recorded for this patch did not cover the new request. I resolved this by recording the response for the new request and checking in the corresponding fixture file
gh-76 introduced fixture files for some of the same resources that these tests depend on. Since the files are named with a timestamp, both fixtures were present in the rebased version of this patch, and one set interfered with the other. I resolved this by removing the duplicated fixture files

The prior version of this branch is available here.

Sure. Merging now.


Export to KML exports to KMZ

The dialog box says export to KML but the resulting file is actually a KMZ (a zipped KML file). Either the tool should be export to KMZ or the file created should be a KML

Currently we export to a KMZ, the dialog needs to be changed from KML to KMZ

switched the estimate on this issue to a one based on the fact that it is us changing a dialog prompt.

Based on speaking with @ScottCecilio and @jfrygeo they stated that KMZ or KML does not matter. We can keeps this KMZ and just update the UI