Fix expansion of GCE acronym from Container Engine to Compute Engine

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/656eb14a71ca61c2bed9fd8408566388681ef9db/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a64f6523eb28ab66ce85238211627bf904aa3050/


result of convert.py

How to view the result of the conversion after convert.py is done with elapsed time:22 ?

@YashBangera7 Can You please tell me how do I Run Convert.py because all I get is the 1 sec of  output


Enhance: Update article viewer page

We've updated the reading page, but it's a little strange to view at the moment.
Maybe we take a cue from Medium's style and bring user information and likes to the center of the page.

/assign @Kasey0727


Rotatable Mouse Pointer Crosshairs

Description of the new feature / enhancement
Possible to rotate the crosshairs with mod+scrollwheel. The feature might be helpful at some case scenarios.
Scenario when this would be used?
Aiming inputs, aside from directly x and y axes
Supporting information
No response

@gczark what use cases?  The crosshair feature was designed wayfinding the pointer but would love to understand what you're thinkign
/needinfo


Feed content different for Sonatype Blog depending on whether feed is On My Mac or in Feedbin

I've got a feed (http://blog.sonatype.com/rss.xml) that shows three unread articles from 2017 when the feed is stored in Feedbin, but nine unread articles from 2019 when stored On My Mac. The On My Mac version seems correct, but I'm wondering 1) what might be the cause of Feedbin showing the wrong count, and 2) if this is a Feedbin error, if there's a way of showing the problem in the NNW GUI. I'm using Version 5.0.3 (2618) on macOS 10.14.6 (18G2022). Perhaps Feedbin is blocked from accessing Sonatype to get an updated feed? If so, and there's an error available from Feedbin, that error would be good to display in NNW so I know to keep that feed On My Mac.

This could be on the Feedbin side, but we should investigate. It sounds like it’s really about items not showing up (and not having to do with read/unread status). I think.

I think this is a Feedbin issue or at least a matter of opinion on how dead feeds should work.
The http version of the feed is dead, but the https version is still working.  We automatically go after the https version, but it looks like Feedbin still has old stuff in it's database from 2017 and uses that.
I'm not sure what if anything we should/could do about this.

The issue is that it’s really two different feeds. Even though this isn’t ideal behavior, it’s expected.

Interesting. I'm happy to follow up with Feedbin; I'll look for a feedback link unless someone has a better channel for contacting them about this kind of problem.


causal conv eager issue

eager mode doesnt work with causal conv:
Invalid padding method 'CAUSAL'
gets thrown by this code :
import tensorflow as tf
#import keras # code works without eager
#but with it it wants tf.contrib.eager.Variable somewhere

from tensorflow import keras # <- errors on padding='causal'

import numpy as np
#tf.enable_eager_execution()

data = np.random.random([1,1,256])

leaky_relu = tf.nn.leaky_relu
model = keras.Sequential([
    keras.layers.Conv1D(16, 2, padding='causal', dilation_rate=2, activation=leaky_relu) ])

opt = tf.train.AdamOptimizer()
model.compile(opt, loss = 'mean_squared_error', metrics=['accuracy'])

model.fit(data, y=np.random.random([1,1,16]), batch_size=1)

tensorflow==1.12.0rc0
keras==2.2.4
-> collision between keras and tensorflow eagerness

Keras doesn't support tensorflow eager yet. Likely in TF 2.0. You should use tf.keras. If you have a problem with tf.keras, you need to open an issue in the tensorflow repository.


fixjson: init at 1.1.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@SuperSandro2000 Can this be merged?

Result of nixpkgs-review pr 106004 run on x86_64-darwin 1

2 packages failed to build:

lumo
tests.writers

2 packages built:

iosevka
vscode-extensions.matklad.rust-analyzer

Result of nixpkgs-review pr 106004 run on x86_64-linux 1

2 packages failed to build:

iosevka
lumo

23 packages built:

bitwarden-cli
castnow
emojione
epgstation
flood
gtop
image_optim
joplin
mirakurun
netlify-cli
pm2
ripcord
tests.writers
thelounge
twemoji-color-font
vimPlugins.coc-metals
vimPlugins.coc-prettier
vimPlugins.coc-rust-analyzer
vimPlugins.coc-stylelint
vimPlugins.coc-vetur
vscode-extensions.matklad.rust-analyzer
vscode-extensions.ms-python.vscode-pylance
vscode-extensions.vadimcn.vscode-lldb


Broken link - Tutorial Notebook

Hi,
The link for the Tutorial Notebook in the README.md file is broken (the same link exists in manual/Readme.md and here).
Maybe it should be changed to this one?
Cheers!
Nikitas

Changed! Thanks for mentioning it!


Linux 4.19.15-rt12 -> Linux 4.19.23-rt14 and latest rtirq

Update Linux kernel to latest RT patchset.
Musnix refers to no-longer existing version of rtirq, updated to the latest available.

Don't merge it. This Kernel version and patches doesn't look very stable...

This Kernel version and patches doesn't look very stable...

Could you explain?
What about rtirq?

Well, system instability.
Messages like systemd-journald block for more then 120seconds...
dmesg command does not print anything, but is hung indifinitely.
shutdown blocked indifinitely.
Will push rtirq in another push request separately.

Ok, thanks.


feat: Added storage manifest endpoint for schematic

Changelog
Goal: explore adding an endpoint in mono repo

Added storage/asset-views/{assetView}/projects/{projectId}/manifests endpoint
Added authentication token header for authentication
Added schematicpy23.1.1 in api project

To test this PR

Make sure your Python environment meets the need of schematic: nx run schematic-api:prepare-python
Visit page: http://localhost:7080/api/v1/ui/
nx serve schematic-api
Copy and pasted synapse access token to authenticate
Use the following asset view:

asset view: syn23643253
project id: syn30988314
See response 200

Errors trying this PR
Checking out the branch of this PR triggers an error when the post-checkout tries to update the Python dependencies:
✨ Preparing Node.js dependencies ✨ Preparing Java environments ✨ Preparing Python dependencies node:events:491 throw er; // Unhandled 'error' event ^ Error: spawn nx ENOENT at ChildProcess._handle.onexit (node:internal/child_process:283:19) at onErrorNT (node:internal/child_process:476:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) Emitted 'error' event on ChildProcess instance at: at ChildProcess._handle.onexit (node:internal/child_process:289:12) at onErrorNT (node:internal/child_process:476:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { errno: -2, code: 'ENOENT', syscall: 'spawn nx', path: 'nx', spawnargs: [ 'run-many', '--target=prepare-python', '--projects=schematic-api' ] } Node.js v18.16.0 husky - post-checkout hook exited with code 1 (error) . Please check git output for more details

Despite the error, I'm on the branch of the PR. The following error is then shown when trying to start the REST API with nx serve schematic-api:
vscode@eee29c9f9d7c:/workspaces/sage-monorepo$ nx serve schematic-api

> nx run schematic-api:serve

Current Python version (3.11.0) is not allowed by the project (>=3.9.0,<3.11).
Please change python executable via the "env use" command.
 >  NX   ERROR: Something went wrong in run-commands - Command failed: poetry run python -m schematic_api
   Pass --verbose to see the stacktrace.

@linglp I will explore this issue and post a solution here.

@tschaffter I think this happened because your local python version does not match what schematic required. I modified prepare-python in project.json (see here)I think maybe one solution could be to add the step of prepare-python before running nx serve schematic-api

Update
The following works:

Refreshed the PR locally
Run nx prepare-python schematic-api
Run nx serve schematic-api

I also tried to go back to main, remove the PR branch and checked it out again. The post-checkout script that should prepare the Python env and dependencies still throws an error. Ideally this script should run fine and the developer should then be able to start the REST API without preparing the environment manually.

As suggested in the above screenshot, here is the error shown in the "Output" tab for Git:
...
2023-06-01 22:27:50.968 [info] > git show --textconv :dev-env.sh [3ms]
2023-06-01 22:27:50.979 [info] > git checkout -q pr/linglp/1599 [1625ms]
2023-06-01 22:27:50.979 [info] ✨ Preparing Node.js dependencies
✨ Preparing Java environments
✨ Preparing Python dependencies
node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: spawn nx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn nx',
  path: 'nx',
  spawnargs: [ 'run-many', '--target=prepare-python', '--projects=schematic-api' ]
}

Node.js v18.16.0
husky - post-checkout hook exited with code 1 (error)
2023-06-01 22:27:51.017 [info] > git config --get commit.template [19ms]
...

What works
Running the command run by the post-checkout script manually works:
vscode@eee29c9f9d7c:/workspaces/sage-monorepo$ nx run-many --target=prepare-python --projects=schematic-api

    ✔  nx run schematic-api:prepare-python (55s)

Actually, once the PR has been checked out, all the commands work as expected. I can switch back and forth between the branch main and the PR branch and the post-checkout script successfully prepare the Python environment.
The issue originates from the VS Code extension for GitHub
The post-checkout script works successfully when checking out the PR manually - without using the VS Code extension for GitHub.
vscode@eee29c9f9d7c:/workspaces/sage-monorepo$ git fetch upsrtream pull/1599/head:lingling_pr
From https://github.com/Sage-Bionetworks/sage-monorepo
 * [new ref]           refs/pull/1599/head -> lingling_pr

vscode@eee29c9f9d7c:/workspaces/sage-monorepo$ git checkout lingling_pr
Switched to branch 'lingling_pr'
✨ Preparing Node.js dependencies
✨ Preparing Java environments
✨ Preparing Python dependencies

    ✔  nx run schematic-api:prepare-python (54s)

@linglp The issue I reported originate from the VS Code extension for GitHub. The issue does not happen when checking out the PR manually (see above). I'm not sure what the issue could be. The error mentions "processTicksAndRejections' which seems related to running async functions, which I make use of in the post-checkout script.
Proposed solution
There are three solutions:

Checkout PR manually
Checkout PR with the VS Code extension for GitHub and run the post-checkout script manually if it fails (e.g. node tools/check-python-dependencies.js).
Automatically prepare the environment before performing some tasks like serve and test. This would go against the idea to prepare the environments during post-checkout once instead of each time that serve and test are run.

@linglp I propose to go with Option 1. and 2. for now. At some point I will explore the issue with the VS Code extension for GitHub. The error seems related to changing the version of Python for the project, which hopefully we won't do too often.
How does that sound?

Can I try something like:

@linglp Hopefully we won't need this if you agree with the solution I proposed above.
If we needed this, there is actually a better way to do so, which is to tell Nx that the task serve depends on the task prepare-python. This would be done with the Nx property dependsOn.

Testing the new endpoint
@linglp Do I have access to the Synapse resources that you specified in the instructions to test the PR? If not, then I get an error that may be because I don't have access. The logs of the REST API show:
INFO: [2023-06-01 22:52:21] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:52:21] "GET /api/v1/ui/ HTTP/1.1" 200 -
INFO: [2023-06-01 22:52:22] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:52:22] "GET /api/v1/ui/swagger-ui-standalone-preset.js HTTP/1.1" 200 -
INFO: [2023-06-01 22:52:22] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:52:22] "GET /api/v1/ui/swagger-ui-bundle.js HTTP/1.1" 200 -
INFO: [2023-06-01 22:52:22] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:52:22] "GET /api/v1/ui/swagger-ui.css HTTP/1.1" 200 -
INFO: [2023-06-01 22:52:23] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:52:23] "GET /api/v1/ui/favicon-32x32.png HTTP/1.1" 200 -
INFO: [2023-06-01 22:52:23] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:52:23] "GET /api/v1/openapi.json HTTP/1.1" 200 -
ERROR: [2023-06-01 22:54:08] __main__ - Exception on /api/v1/storages/asset-views/syn30988314/projects/syn23643253/manifests [GET]
Traceback (most recent call last):
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/schematic/store/synapse.py", line 109, in _query_fileview
    self.storageFileviewTable = self.syn.tableQuery(
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/client.py", line 3488, in tableQuery
    return CsvFileTable.from_table_query(self, query, **kwargs)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/table.py", line 1966, in from_table_query
    download_from_table_result, path = synapse._queryTableCsv(
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/client.py", line 3638, in _queryTableCsv
    download_from_table_result = self._waitForAsync(uri=uri, request=download_from_table_request)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/client.py", line 3240, in _waitForAsync
    async_job_id = self.restPOST(uri+'/start', body=json.dumps(request), endpoint=endpoint)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/client.py", line 4047, in restPOST
    response = self._rest_call('post', uri, body, endpoint, headers, retryPolicy, requests_session, **kwargs)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/client.py", line 4014, in _rest_call
    self._handle_synapse_http_error(response)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/client.py", line 3984, in _handle_synapse_http_error
    exceptions._raise_for_status(response, verbose=self.debug)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/synapseclient/core/exceptions.py", line 160, in _raise_for_status
    raise SynapseHTTPError(message, response=response)
synapseclient.core.exceptions.SynapseHTTPError: 400 Client Error:
syn30988314 is not a table or view
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask_cors/extension.py", line 165, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/connexion/decorators/decorator.py", line 68, in wrapper
    response = function(request)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/connexion/security/security_handler_factory.py", line 388, in wrapper
    return function(request)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/connexion/decorators/uri_parsing.py", line 149, in wrapper
    response = function(request)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/connexion/decorators/validation.py", line 399, in wrapper
    return function(request)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/connexion/decorators/parameter.py", line 120, in wrapper
    return function(**kwargs)
  File "/workspaces/sage-monorepo/apps/schematic/api/schematic_api/controllers/storage_controller.py", line 39, in list_storage_project_manifests
    return storage_controller_impl.list_storage_project_manifests(
  File "/workspaces/sage-monorepo/apps/schematic/api/schematic_api/controllers/storage_controller_impl.py", line 70, in list_storage_project_manifests
    store = SynapseStorage(access_token=bearer_token)
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/schematic/store/synapse.py", line 97, in __init__
    self._query_fileview()
  File "/workspaces/sage-monorepo/apps/schematic/api/.venv/lib/python3.10/site-packages/schematic/store/synapse.py", line 115, in _query_fileview
    raise AccessCredentialsError(self.storageFileview)
schematic.exceptions.AccessCredentialsError: Your access to 'syn30988314'' could not be resolved. Please check your credentials and try again.
INFO: [2023-06-01 22:54:08] werkzeug - <IP_ADDRESS> - - [01/Jun/2023 22:54:08] "GET /api/v1/storages/asset-views/syn30988314/projects/syn23643253/manifests HTTP/1.1" 500 -

The error code returned should be 401 Unauthorized if the error is because I don't have access to the resources. The 500 error code is usually used in last resort for errors that are not expected by the developers. See libs/openchallenges/api-description/src/components/responses/Unauthorized.yaml.

401 (Unauthorized) vs 403 (Forbidden)

401 Unauthorized is the status code to return when the client provides no credentials or invalid credentials. 403 Forbidden is the status code to return when a client has valid credentials but not enough privileges to perform an action on a resource.

@linglp If Synapse returns 401, then Schematic REST API should return 401. If Synapse returns 403, then the REST API should return 403.

@tschaffter Thanks for detailed explanation. I like the proposal of option1 and option2. Thank you for documenting all the details in the PR.


[BUG] I CANNOT ADD LINK VALIDATE IN VERSION 3.0.4

Describe the bug
I CANNOT VALIDATE HYDRA CLOUD IN VERSION 3.0.4
Steps to Reproduce
1 - GO TO SETTINGS
2 - CLICK IN FONTS DOWNLOAD
3 - INSERT LINK IN BUTTONS FONT
4 - VALIDATE ERROR
Expected behavior
No response
Additional information and data

Operating System
WIN 10 PRO 22H2
Hydra Version
3.0.4
Before opening this Issue

[X] I have searched the issues of this repository and believe that this is not a duplicate.
[X] I am aware that Hydra team does not offer any support or help regarding the downloaded games.
[X] I have read the Frequently Asked Questions (FAQ).

Be sure you are passing a valid url to a valid json file

Passo 3 mais expecífico um pouco.
Não tem um link?

where can i get valid json source

https://hydralinks.cloud/

i cave the same problem i have even tried this url u send but it doesn't work

i cave the same problem i have even tried this url u send but it doesn't work

can u try downgrade for older version?
worked here!

Be sure you are passing a valid url to a valid json file

I downgraded the version above and it worked normally, I believe it could be a bug in the new version, I used the valid link, I will perform the update and perform the test by recording the screen.

how do i down grade the version?

how do i down grade the version?

uninstall a newest version and install a version oldest !

could u help me get an older version idk how to do that

i tried and it didn't work

i tried and it didn't work

Yez i Can


Support same-page anchor scrolling

This is a copy of https://github.com/hotwired/turbo-android/pull/175 already merged in turbo-android.
Addresses https://github.com/hotwired/turbo-ios/issues/37

Thanks! 👍🏻


Adding "our nearby restaurants" in Our serives page

a column can be made in the our services page to facilitate the user about the nearby restaurants
so that he can search for restaurants
Pls assign this issue to me under gssoc'23

Can be created Our Nearby Services and onclicking it opening in a card form .
Proper styling and allignment would be required here .
Secondly we have to map it with Google Maps.
I will be there to create this.


Need an option to resize the lens

I need an option to resize the lens so that I can use a square lens or can change the dimensions of the lens.

@yaser-ali-vp - I'm not sure if v2.5.0 helps your use case, but it might. Please have a look. Thanks.

Hi @carlgunderson - Thanks for your comment.  Unfortunately, it is not currently possible to configure an Amazon like lens design. Full control over the lens, along with an Amazon like design option, will be the focus of the next release.

@yaser-ali-vp, @carlgunderson - A new lens option has been released in v2.7.0. Please have a look and let me know your thoughts. There is a demo example that includes an optional restyling idea. Thanks for your input!

@ethanselzer works like a charm, thanks for implementing this feature!

@yaser-ali-vp - There is also an option to provide a custom lens component if you want something completely different.

Closing as fixed in v2.7.0.


openvas-scapdata-sync can't seem to finish

docker@boot2docker:~$ docker top 711f459094c3
UID                 PID                 PPID                C                   STIME               TTY                 TIME                CMD
root                9047                773                 0                   01:10               ?                   00:00:00            /usr/bin/python3 -u /sbin/my_init
root                9051                9047                0                   01:10               ?                   00:00:00            /bin/bash /etc/my_init.d/000_setup.sh
root                9082                9047                0                   01:10               ?                   00:00:00            openvassd: Waiting for incoming connections
root                9158                773                 0                   01:12               pts/2               00:00:00            bash
root                9499                9051                0                   01:26               ?                   00:00:00            /bin/sh /usr/local/sbin/openvas-scapdata-sync
root                9506                9499                0                   01:26               ?                   00:00:00            /usr/bin/rsync -ltvrP --delete --exclude /scap.db --exclude private/ rsync://feed.openvas.org:/scap-data /usr/local/var/lib/openvas/scap-data
root                9508                9506                0                   01:26               ?                   00:00:04            /usr/bin/rsync -ltvrP --delete --exclude /scap.db --exclude private/ rsync://feed.openvas.org:/scap-data /usr/local/var/lib/openvas/scap-data

openvas-scapdata-sync can't seem to finish . I wait all day long.
I run  "openvas-check-setup --v7" manually,
openvas-check-setup 2.3.0
  Test completeness and readiness of OpenVAS-7

  Please report us any non-detected problems and
  help us to improve this check routine:
  http://lists.wald.intevation.org/mailman/listinfo/openvas-discuss

  Send us the log-file (/tmp/openvas-check-setup.log) to help analyze the problem.

  Use the parameter --server to skip checks for client tools
  like GSD and OpenVAS-CLI.

Step 1: Checking OpenVAS Scanner ...
        OK: OpenVAS Scanner is present in version 4.0.7.
        OK: OpenVAS Scanner CA Certificate is present as /usr/local/var/lib/openvas/CA/cacert.pem.
        OK: NVT collection in /usr/local/var/lib/openvas/plugins contains 39478 NVTs.
        WARNING: Signature checking of NVTs is not enabled in OpenVAS Scanner.
        SUGGEST: Enable signature checking (see http://www.openvas.org/trusted-nvts.html).
        WARNING: The initial NVT cache has not yet been generated.
        SUGGEST: Start OpenVAS Scanner for the first time to generate the cache.
Step 2: Checking OpenVAS Manager ...
        OK: OpenVAS Manager is present in version 5.0.11.
        ERROR: No client certificate file of OpenVAS Manager found.
        FIX: Run 'openvas-mkcert-client -n -i'

 ERROR: Your OpenVAS-7 installation is not yet complete!

Please follow the instructions marked with FIX above and run this
script again.

If you think this result is wrong, please report your observation
and help us to improve this check routine:
http://lists.wald.intevation.org/mailman/listinfo/openvas-discuss
Please attach the log-file (/tmp/openvas-check-setup.log) to help us analyze the problem.

What's in the tail of your docker log for that container?
There is certainly an issue that I've seen with the new version that may be causing this. I'm hoping to update to v8 shortly and change the way a bit of this runs.

....
zone_alarm_local_dos.nasl
zone_alarm_local_dos.nasl.asc
[i] Download complete
[i] Checking dir: ok
[i] Checking MD5 checksum: ok
[i] This script synchronizes a SCAP data directory with the OpenVAS one.
[i] SCAP dir: /usr/local/var/lib/openvas/scap-data
[i] Will use rsync
[i] Using rsync: /usr/bin/rsync
[i] Configured SCAP data rsync feed: rsync://feed.openvas.org:/scap-data
OpenVAS feed server - http://www.openvas.org/
This service is hosted by Intevation GmbH - http://intevation.de/
All transactions are logged.

Please report synchronization problems to<EMAIL_ADDRESS>If you have any other questions, please use the OpenVAS mailing lists
or the OpenVAS IRC chat. See http://www.openvas.org/ for details.

receiving incremental file list
./
 Is it my network problem?

Yes I would expect that's a network issue.  It's halfway through the download process.  This can take hours on a slow connection.

Once I merge #38 you should also try that.

Closing since I haven't heard back from you. Feel free to comment if you have any other issues.


Style text in backticks with monospaced font

Wanted to get your feedback before I start working on this. IMO any tweet text wrapped in ` should get styled as a monospaced font

👍 Also 3-backtick code blocks.


Enhancement: Can Hugging Face be used for deployment?

Contact Details
No response
What features would you like to see added?
If possible, please make a tutorial, or give some useful tips!
More details
By the way, Hugging Face supports docker.
Which components are impacted by your request?
No response
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

+1

Yes: https://huggingface.co/spaces/LibreChat/LibreChat
But you will have to ask @fuegovic and @Berry-13 how they did it


fix(goreleaser): brew binary name

Fixes: https://github.com/charmbracelet/soft-serve/issues/146

its missing the empty var declaration in the top of the files, other than that lgmt


Set the name of Virtual Network Adapter name to "Unite-Gaming"

Blocked due to the name of the VNA adapter being limited to VPN and it requires changing a driver's name, and so that signing driver


Use capitalised clever references

[x] Substitute Theorem \ref with \Cref
[x] Substitute Lemma \ref with \Cref
[x] Substitute Prop \ref with \Cref
[x] Substitute Proposition \ref with \Cref
[x] Substitute Corollary \ref with \Cref

\refs included in \chapter, \section, etc. are excluded in order to avoid hyperref warning such as:

Package hyperref Warning: Token not allowed in a PDF string (Unicode):
(hyperref)                removing `\new@ifnextchar' on input line 1019.

This is useful, but is not good while the "real" source code is on Overleaf. Please do this again once this becomes the official source code in 1-2 weeks.

Oh, right. Sorry for this...


Add support for containerised azure packer builds

Tested by building ubuntu and centos images

add minor comments, overall LGTM BTW, have you tried RHEL?
I'm yet to try. I tried only CentOS and Ubuntu. Although I suspect RHEL will be very similar to CentOS. I'll try and update here.

@snir911 Added support for rhel and tried a build successfully for rhel as well.

/hold
Investigating usage of docker build --secret ...

I have now switched to using docker build --secret ..
example usagE:
export MYSECRET=mypass
docker build --secret id=MYSECRET -t my_image -f Dockerfile .

However podman doesn't seem to work with using env variables as secret.


Feature request: Support UAC-less / commandline authentication

Users should be able to enter their password at the command line, without a UAC prompt, to elevate their privileges.
Requested by: PowerShell / OpenSSH team, and everyone who's ever used sudo on Linux
Potential issues
Literally any malicious.exe out there can AttachConsole to a sudo process, PeekConsoleInput, and steal the password.

Users should be able to enter their password at the command line, without a UAC prompt, to elevate their privileges.
Requested by: PowerShell / OpenSSH team, and everyone who's ever used sudo on Linux
Potential issues
Literally any malicious.exe out there can AttachConsole to a sudo process, PeekConsoleInput, and steal the password.

Bad idea, please don't implement it.
That UAC prompt, annoying as it may, is the last chance that a person sitting behind the screen has to evaluate whether he or she really wants to run a command or process with elevated privileges and is a lot more effective at  doing so than a password prompt because UAC stops all onscreen activity and grants exclusive focus to the prompt.

without this feature alone, sudo is currently completely useless when compared to wsudo.

Users should be able to enter their password at the command line, without a UAC prompt, to elevate their privileges.
Requested by: PowerShell / OpenSSH team, and everyone who's ever used sudo on Linux
Potential issues
Literally any malicious.exe out there can AttachConsole to a sudo process, PeekConsoleInput, and steal the password.

Bad idea, please don't implement it.
That UAC prompt, annoying as it may, is the last chance that a person sitting behind the screen has to evaluate whether he or she really wants to run a command or process with elevated privileges and is a lot more effective at doing so than a password prompt because UAC stops all onscreen activity and grants exclusive focus to the prompt.
I've never liked sudo on Linux and will very much prefer Windows to use its own proper authentication mechanisms (UAC) for elevation than just simply typing a password into a terminal shell.

A potential fix for this would be to do something similar to what the WSL Windows Hello project does: when it catches a call to sudo, it would show a prompt for the user to authenticate (password, PIN, etc.).
Link to that project: https://github.com/nullpo-head/WSL-Hello-sudo

Users should be able to enter their password at the command line, without a UAC prompt, to elevate their privileges.
Requested by: PowerShell / OpenSSH team, and everyone who's ever used sudo on Linux
Potential issues
Literally any malicious.exe out there can AttachConsole to a sudo process, PeekConsoleInput, and steal the password.

Bad idea, please don't implement it.
That UAC prompt, annoying as it may, is the last chance that a person sitting behind the screen has to evaluate whether he or she really wants to run a command or process with elevated privileges and is a lot more effective at doing so than a password prompt because UAC stops all onscreen activity and grants exclusive focus to the prompt.
I've never liked sudo on Linux and will very much prefer Windows to use its own proper authentication mechanisms (UAC) for elevation than just simply typing a password into a terminal shell.

A potential fix for this would be to do something similar to what the WSL Windows Hello project does: when it catches a call to sudo, it would show a prompt for the user to authenticate (password, PIN, etc.). Maybe the UAC could be updated to request authentication if the sudo command is triggered.
Link to that project: https://github.com/nullpo-head/WSL-Hello-sudo

that still requires some sort of GUI support. the ask here is to do it in a completely command-lineish way. SO NO.

@parkovski That's exactly the scenario that the OpenSSH folks have been talking to us about. Having the ssh server running as admin always is mental. There's definitely room for us to work better together here.

@etna simply barring anyone not connected to a GUI desktop from using any elevated commands on the basis that it is «not secure» is at best disingenious. Particularly if you have any knowledge about the many quirks win32 has, or why they introduced the UAC hack in the first place.
Somehow the rest of the world has managed to find solutions for this, and while arguably not perfect by any means, they’re definetly on par with the UAC gui popup (if not better - the presence of UAC demonstrates some fundamental architectural flaws in the Win32 platform). The reason for there not being a solution for this on Windows already is closely related with the long delay before they (somewhat) eventually started adding support for a PTY (just about 40 years late), it simply hasn’t been in their interest to add support for any non-windows features.
But as MS seem to be on a roll, pushing them to finaly have an official solution for the UAC roadblock (not just another fancy runas like it is currently) should be a high priority.
Apologies for creating a dublicate issue, scanned through the existing issues but managed to miss this rather obvious one ;P

@etna simply barring anyone not connected to a GUI desktop from using any elevated commands on the basis that it is «not secure» is at best disingenious. Particularly if you have any knowledge about the many quirks win32 has, or why they introduced the UAC hack in the first place.
Somehow the rest of the world has managed to find solutions for this, and while arguably not perfect by any means, they’re definetly on par with the UAC gui popup (if not better - the presence of UAC demonstrates some fundamental architectural flaws in the Win32 platform). The reason for there not being a solution for this on Windows already is closely related with the long delay before they (somewhat) eventually started adding support for a PTY (just about 40 years late), it simply hasn’t been in their interest to add support for any non-windows features.
But as MS seem to be on a roll, pushing them to finaly have an official solution for the UAC roadblock (not just another fancy runas like it is currently) should be a high priority.
Apologies for creating a dublicate issue, scanned through the existing issues but managed to miss this rather obvious one ;P

Windows IS a GUI-driven operating system, and the vast majority of Windows and Windows Server users and administrators manage their operating systems through the graphical desktop.
Why are we trying to linuxify Windows and making it behave like Linux when it clearly should be doing its own thing, and especially when Linux distributions and users keep demanding that Windows users adapt to their archaic ways?

@etna simply barring anyone not connected to a GUI desktop from using any elevated commands on the basis that it is «not secure» is at best disingenious. Particularly if you have any knowledge about the many quirks win32 has, or why they introduced the UAC hack in the first place.
Somehow the rest of the world has managed to find solutions for this, and while arguably not perfect by any means, they’re definetly on par with the UAC gui popup (if not better - the presence of UAC demonstrates some fundamental architectural flaws in the Win32 platform). The reason for there not being a solution for this on Windows already is closely related with the long delay before they (somewhat) eventually started adding support for a PTY (just about 40 years late), it simply hasn’t been in their interest to add support for any non-windows features.
But as MS seem to be on a roll, pushing them to finaly have an official solution for the UAC roadblock (not just another fancy runas like it is currently) should be a high priority.
Apologies for creating a dublicate issue, scanned through the existing issues but managed to miss this rather obvious one ;P

Windows IS a GUI-driven operating system, and the vast majority of Windows and Windows Server users and administrators manage their operating systems through the graphical desktop.
Why are we trying to linuxify Windows and making it behave like Linux when it clearly should be doing its own thing, and especially when Linux distributions and users keep demanding that Windows users adapt to their archaic ways?
Windows is not Linux and has no reason to change its architecture or design to fit Linux users. Even if any tools or utilities from Linux are ported over to Windows, they should be modified to work within the existing Windows architecture and design. UAC works well for what it is, is an integral part of Windows, and should remain the method of authorizing permissions or privileges escalations in Windows.

By that logic, there was no need to even bring sudo windows at all. Because, Windows' per-file permission system was working well.
KEY POINT IS: Windows does NOT HAVE TO be restricted to GUI only.

I would also love to have support for Windows Hello instead of the UAC prompt or actually for UAC prompts in general.
I already use this in my WSL Ubuntu (https://github.com/nullpo-head/WSL-Hello-sudo) and macOS (https://github.com/artginzburg/sudo-touchid) and having that on Windows as well would streamline my experience a lot.

I would also love to have support for Windows Hello instead of the UAC prompt or actually for UAC prompts in general.

You have a point, how will UAC evolve? Will Microsoft sudo drive changes on UAC or even replace it?
For example: UAC can already be configured to use Windows Hello, given your webcam supports it. The problem is that UAC lacks configuration and friendliness:
The annoying part is that typing user/password is UAC's default, and takes 2 clicks to enable face recognition ¡on every single elevation!

Windows IS a GUI-driven operating system, and the vast majority of Windows and Windows Server users and administrators manage their operating systems through the graphical desktop.
Why are we trying to linuxify Windows and making it behave like Linux when it clearly should be doing its own thing, and especially when Linux distributions and users keep demanding that Windows users adapt to their archaic ways?
Windows is not Linux and has no reason to change its architecture or design to fit Linux users. Even if any tools or utilities from Linux are ported over to Windows, they should be modified to work within the existing Windows architecture and design. UAC works well for what it is, is an integral part of Windows, and should remain the method of authorizing permissions or privileges escalations in Windows.

Terminal =! Linux, and this is not about "linuxifying" anything (whatever that means). The wast majority of Windows server admins use RDP, quite simply because Windows doesn't support anything else, not because it is terribly convenient, easy to set up or well suited to remote administration, and this is why Microsoft over the last few years a) has lost a lot of market share in the server segment and b) is working hard on reinventing the console with it's own interpretation (you might have heard about PowerShell?).
There's no reason to do any fundamental changes to the architecture (other than possibly improve safety in general if they intend to deploy it in more remote locations), and the hardline attitude that a image sent over the wire, with a corresponding mouse click event sent in return should be the only way to respond to an auth challenge is, I'm sorry to be blunt, stupid.
Luckily the engineers at MS aren't silly, they've already implemented plenty of auth methods not involving images being sent back & forth, but my hope was that this would be considered a key feature, as right now, a console tool for privilege escalation that requires you to also have a RDP session running just to click on the fancy UAC GUI windows is a bit counterproductive.

Yes, @Brynyard has it exactly right. Nobody is saying that we shouldn't authenticate. But it's pretty annoying to need a graphical pop-up to do it.
Why not let us enter our password at the command-line? If I'm SSHed into a machine, why do I also need remote-desktop? How is clicking a GUI box more secure than entering my password?

I think it's OK for Windows-style Sudo if uses the password generated by Time-based one-time password (TOTP) and HMAC-based one-time password (HOTP) like using the Two-factor authentication.
It will reduce the potential risk of emulating user input to bypass the password authentication window.
Kenji Mouri

The level of secureness should be configurable at least.  I am sure that some people would rather their machines be more secure, and others would rather have convenience.  If Microsoft is investing into a real window's alternative for sudo, then I'd hope that it would cover each of the points people have expressed here in a final product.
I feel that the Runas utility  is extremely annoying to use on any effective scale, and have always needed custom code to have any reasonable expectation of recovering from possible error scenarios.  Sudo is a chance to solve all of those obstacles.  Sudo's NOPASSWD option is something I definitely use on some machines, and would never consider on others.
Either way, It'll be exciting to see where it leads..

Uhm, don't take this the wrong way folks, but I struggle to to comprehend why y'all so conclusively can assert that any text based solution for authentication is "less secure" or "isn't taking security seriously"? And this in comparison to a "protocol" for security in Windows based on a user getting a GUI popup (commonly served over RDP)?!
What is so inherently much more unsafe with using a protocol using asymmetric key exchange over a text protocol than first using SSL/TLS to connect to RDP and then get the "challenge" served in the form of an image that needs a click?

I'm a big proponent of making everything configurable. In my opinion, having a commandline-based auth method probably won't be the default. Especially not the *nix-style prompt, since literally any console application running at medium-IL could very easily sniff your password with a AttachConsole & PeekConsoleInput.
That being said, I'm also big on "users should be able to just get things done". So, I'd probably implement this with options to let users opt-in for convenience at the cost of security posture.

@zadjii-msft could an SSH-style keypair get the job done? That could provide some security without requiring a sniffable password.

@zadjii-msft the boat for securing anything running in Win32 userland has long since sailed, so if the goal is to also ensure safety on that level you'd have to require an integration with external auth using a keypair, TOTP or similar.
Though, one of the main the reasons I (+more) request this is not because we need this locally. Besides, requiring an external signing device isn't that outlandish (it's been the default at my office for a while now, and I don't foresee this going away).

Especially not the *nix-style prompt, since literally any console application running at medium-IL could very easily sniff your password with a AttachConsole & PeekConsoleInput.

Since this is the scenario that is causing the concern, would a better solution be address it as a root cause? Perhaps require much higher privileges for running such a process? Or disable being able to do so by default? Food for thought.

@SteveSyfuhs any ideas？

I would like this to be an optional setting which can be enabled in the command line and/or the Settings app.

If you have a console window running as standard user and that's piping the input stream to the low privileged process, I suspect hooking the normal process will still give you the ability to look at the stream.
... Ultimately, typing your password into a process gives that process your credential.

"For specific commands, Windows restricting a process for sometime and blocking any other processes from communicating/piping except the microsoft signed ones. (i.e: Windows Inputs processes)."
that's all Windows needs to implement this feature and this should not be too hard for adventurous Windows engineers. SMH

user types sudo xyz in the console window, Windows restricts that console window and blocks other processes from communicating/piping until the user finishes typing their passwords. once finished, windows releases that process.  the authentication is done behind the scenes by windows.

I own a good chunk of the authentication stack in Windows and I can say with certainty that this is not a thing that can be done easily. There is no process hold technology that allows one to block another from doing anything on demand. That's just not part of the Windows security model.
Further, the concern is still that a low privilege process is streaming commands to a high privilege process after the credentials have been entered.
I'm happy to be proven wrong here. Outline the steps this could take, maybe provide a POC?

From: Momin Shaikh @.>
Sent: Saturday, June 22, 2024 3:38:25 AM
To: microsoft/sudo @.>
Cc: Comment @.***>
Subject: Re: [microsoft/sudo] Feature request: Support UAC-less / commandline authentication (Issue #7)
If you have a console window running as standard user and that's piping the input stream to the low privileged process, I suspect hooking the normal process will still give you the ability to look at the stream.
... Ultimately, typing your password into a process gives that process your credential.
"For specific commands, Windows restricting a process for sometime and blocking any other processes from communicating/piping except the microsoft signed ones. (i.e: Windows Inputs processes)."
that's all Windows needs to implement this feature and this should not be too hard for adventurous Windows engineers. SMH
user types sudo xyz in the console window, Windows restricts that console window and blocks other processes from communicating/piping until the user finishes typing their passwords. once finished, windows releases that process. the authentication is done behind the scenes by windows.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/sudo/issues/7#issuecomment-2183975283 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJHTYKBOXYO6ZYPM25JTVLZIVH2FBFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI3DKMBVGE4DCOJVGKSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJXGUYTIOBWG42TNAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMJSGE3DQNZTGQ3IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI3DKMBVGE4DCOJVGKTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

There is no process hold technology that allows one to block another from doing anything on demand.

that's all Windows needs to implement this feature and this should not be too hard for adventurous Windows engineers.

I know.  I was talking about inventing one.
sudo or a proper terminal was also unimaginable on windows a few years back. now it is.

So... Passkeys? ducks


Template does not build with dotnet --version = 3.0.100

Hello, i followed the Using the template - guide and i got the following error when trying to build via fake build.
System.IO.FileLoadException: Could not load file or assembly 'System.Threading, Version=<IP_ADDRESS>,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition
does not match the assembly reference. (Exception from HRESULT: 0x80131040) at
System.Console.get_Out() at Program.main(String[] argv)

I checked my installed sdk versions (dotnet --info) and found that i have SDK 2.1.802 installed. This is the version that has LTS as listed here. At least as far as i understood.
Then i saw that 2.1.508 was referenced in the global.json file so i downloaded that version and tried to build, but it still failed.
In the end i changed the following files:

global.json -> "version": "3.0.100"
paket.dependencies -> framework: netcoreapp3.0
src/SaturnTemplate/SaturnTemplate.fsproj -> <TargetFramework>netcoreapp3.0</TargetFramework>

With these changes the fake build and fake build -t run command succed.
Now, i am missing a lot of knowledge so i don't know if this is a bug, an missing update or expected behavior and i just did everything wrong. :sweat_smile:

Same problem here, is there an update for dotnet 3?

Any update on this?


Add pending invite tracking to Invite Only Project feature

Add the ability to track invites pending acceptance to prevent admin users from inviting the same user multiple times before an invite has been accepted. May also be useful to track invited users whose invites expired before being accepted to be able to alert/warn the project administrator users (perhaps through Project Issues).

:+1:


Remove pytest as a requirement to run app

What does this PR do?

This PR just moves the import of pytest to avoid importing if the app cannot be loaded locally, as it imports EmptyFlow.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @tchaton @rohitgr7

@tchaton @lantiga for review!

@tchaton @lantiga Can I get a review from you as a codeowner on this ? as merging is blocked


Add context flag example with music and food

Currently, the car dashboard app relies solely on intents and entities to trigger events. However, this may cause inconsistent behavior when there is a change in the underlying algorithms. A more reliable way is to set flags in the context variable.
Important: This is just an example of how one might implement context flags. I've implemented flags for music and food only. Should this design be accepted, this PR should be modified to use context flags for all events.

@stevenoh93 Based on the description if I accept this PR I need to do other changes. Is that correct? Can you deploy this app to Bluemix and show me an example of when your version performs better than this?

@germanattanasio Right. There needs to be more change to both the workspace and the app. This was a response to a bug that was present before, but seems like it is fixed now.
When we did "turn on the radio" then "jazz", conversation would pick up #traffic_updates and would respond to that intent. Seems like the intent is no longer triggered. This PR was to prevent further bugs like that by triggering actions through context flags rather than intent/entities.

The app now uses the "action" flag in a resdponse to trigger events. Context and intent weren't stable indicators to trigger events.


Coverity fixes<PHONE_NUMBER>

On May 13, 2017, at 10:38 AM, Phil Sorber<EMAIL_ADDRESS>wrote:
@PSUdaemon commented on this pull request.
In iocore/dns/I_DNSProcessor.h:

SRVHosts srv_hosts;
virtual void free();
HostEnt()
{

size_t base = sizeof(force_VFPT_to_top); // preserve VFPT
memset(((char *)this) + base, 0, sizeof(*this) - base);

ink_zero(ent);
ink_zero(srv_hosts);
ent and srv_hosts are also members. Are you saying I should just make sure they initialize properly in their constructors?

Sorry this is fine. I misread it as being equivalent to "ink_zero(this)"

@jpeach I created a new PR anyway. I think I like it better without ink_zero(). Less brute force. See #1902.


Make Authenticated Calls to GitHub

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Resolves #168000
Resolves #167997

Microsoft Reviewers: Open in CodeFlow

The rate limit for authorized users is usually much higher than 60

It's usually closer to 5000:
PS C:\ManVal> Get-GitHubRateLimit

Wednesday, August 21, 2024 12:50:56

source    : Unlogged
limit     : 60
used      : 2
remaining : 58
reset     : 8/21/2024 12:32:29

source    : Logged
limit     : 5000
used      : 42
remaining : 4958
reset     : 8/21/2024 12:31:39

@stephengillie - Just adding it there wouldn’t work, it would have to also be added as a parameter of the entire script, which then needs to be validated and passed through to this sub-function.

Sorry @PckgrBot, why this pull request reverted?

Sorry @PckgrBot, why this pull request reverted?

It broke the publish pipeline


Node 20.x: import.meta.resolve is not a promise anymore

https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-04-18-version-2000-current-rafaelgss
https://github.com/nodejs/node/pull/44710
As a result, https://github.com/iambumblehead/esmock/blob/4425101785857d1ba09012694dd96e64bb593322/src/esmockModule.js#L120 fails with 'TypeError: (intermediate value).resolve(...).catch is not a function'.

I might have time to make a branch and resolve later tonight or tomorrow. Thanks for bumping the node --loader issue thread I hope they will resolve that


Cloudinit requires local_hostname field

but the docs are mentioning it as optional.
* libvirt_cloudinit.test_ci: "local_hostname": required field is not set

This is a bit of a frustration: I'm using a common cloud-init resource to set the ssh key across domains. As a workaround for now, I've commented out the hostname declarations for cloud-init and rebuilt.
I've not explored this plugin too much so I can't assess the impact of removing the require for now, but I might get my hands dirty and do this "soon"

I don't think that it got any downsides to make the hostname optional as stated in the docs. But maybe @flavio knows more about it since he has written the cloud-init integration?

I don't actually remember why I didn't make the hostname optional. I cannot see any downside in allowing that.
BTW, it would also be nice to revisit how the cloudinit resource is defined. It would be probably easier/more flexible to implement something like https://www.terraform.io/docs/providers/template/d/cloudinit_config.html


Timer::just_finished() returns true forever when paused during finish tick

Bevy version
0.6.1
Operating system & version
Ubuntu 20.04
The problem
The description of Timer::just_finished() claims it "returns true only on the tick the timer reached its duration", but pausing during that tick causes it to return true indefinitely. This causes inconsistent behaviour as it means pausing a timer will occasionally make Timer::just_finished() return true every frame, usually resulting in a massive speedup for anything the method is being used for: periodic entity spawning, advancing an animation, or printing info to the console.
It's possible this isn't actually a bug, but at the very least it leads to unintuitive behaviour which should be correctly indicated in the method's description.
Minimal example:
use bevy::prelude::*;
use std::time::Duration;

fn main() {
    // consistent for both repeating and non-repeating timers
    let mut timer = Timer::from_seconds(1.0, false);

    // finish timer
    timer.tick(Duration::from_secs_f32(1.0));
    assert!(timer.just_finished());

    // pause timer while just_finished()
    timer.pause();

    // timer is now just_finished() forever
    for _ in 0..100 {
        timer.tick(Duration::from_secs_f32(0.5));
        assert!(timer.just_finished());
    }
}

How was this found?
What you did
Used a timer to advance an animation when timer.just_finished() == true. Paused the timer.
What you expected to happen
The animation would stop.
What actually happened
The animation would stop unless it was paused on the tick timer.just_finished() == true. If this happened, the animation would speed up to the screen's refresh rate. Unpausing the animation would slow it back down.
Solutions you have considered

Make tick() reset times_finished to 0 when paused

In general, ticking a paused timer is supposed to do nothing.
Need to consider what exactly times_finished means while paused / if anything relies on it not changing.

@alice-i-cecile this has since been fixed. Good to close?


Swift 4 AlamofireObjectMapper Dependency

Hello,
Just writing to say that the Podfile spec should probably be updated for AlamofireObjectMapper 5 so that users can use swift 4
[!] Unable to satisfy the following requirements:

- `AlamofireObjectMapper (from `https://github.com/tristanhimmelman/AlamofireObjectMapper.git`, branch `swift-4`)` required by `Podfile`
- `AlamofireObjectMapper (= 5.0.0)` required by `Podfile.lock`
- `AlamofireObjectMapper (~> 4.0.1)` required by `Spartan (1.0)`

Hi @RudyB! 😄 AlamofireObjectMapper doesn't yet have a swift 4 release that can be used by pods who use AlamofireObjectMapper as a dependency. You can follow this issue as I have let the author know that a swift 4 release would be greatly appreciated. In the meantime, you can still use Spartan within a Swift 4 project as Swift 3.x and Swift 4 are completely compatible with each other. Just include this at the bottom of your podfile:
post_install do |installer|
    installer.pods_project.targets.each do |target|
        swift3_projects = ['Spartan']
        if swift3_projects.include? target.name
            target.build_configurations.each do |config|
                config.build_settings['SWIFT_VERSION'] = '3.2'
            end
        end
    end
end

@Daltron I saw that you were pretty active on their issue board. I am also patiently awaiting a swift 4 release from them.
I added that code to the bottom of my pod file and I am still getting the Object Mapper Build Issues regarding the toIntMax
Did I do something dumb?
A copy of my pod file:
target 'Tempo' do

  use_frameworks!
  platform :ios, '10.3'
  # Pods for Tempo
  pod 'SpotifyLogin'
  pod 'Spartan'

  target 'TempoTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'TempoUITests' do
    inherit! :search_paths
    # Pods for testing
  end

end

post_install do |installer|
    installer.pods_project.targets.each do |target|
        swift3_projects = ['Spartan']
        if swift3_projects.include? target.name
            target.build_configurations.each do |config|
                config.build_settings['SWIFT_VERSION'] = '3.2'
            end
        end
    end
end

@RudyB Did you rerun the pod install command? I forgot to mention that that is needed in order for the changes to take affect! 😄

I absolutely did. I also cleaned my project and build folder.

@RudyB Can you take a screenshot of the errors Xcode is reporting please?

Pod Install Output
Xcode Output

@RudyB Ahhh I'm sorry, you need to also specify 'AlamofireObjectMapper' and 'Alamofire' in the swift3_projects variable. I've updated my original comment to include these two pods.

I had to explicitly add ObjectMapper to the swift3_projects variable as well in order to get it to work. Thank you so much for all the help. You may want to add that to your code snippet

Glad to hear! 🎉

AlamofireObjectMapper 4.1.0 was released today FYI

@RudyB Swift 4 support is now available in v1.1.0 release! 🎉

@Daltron Thank you for your hard work.


cam.properties TypeError: Expected str, got unicode

tested with GigE Basler acA640-120gm
In [15]: for image in cam.grap_images(1):
Traceback (most recent call last):
  File "test_pypylon.py", line 20, in <module>
    gen = cam.grap_image(1)
  File "PyPylon/cython/factory.pyx", line 233, in pypylon.cython.factory.Camera.grap_image (cython/factory.cpp:4756)
  File "PyPylon/cython/factory.pyx", line 215, in grap_images (cython/factory.cpp:4385)
TypeError: Expected str, got unicode

leading to
terminate called after throwing an instance of 'GenICam_3_0_Basler_pylon_v5_0::TimeoutException'
Aborted

after changing factory.pyx
215             cdef str image_format = str(self.properties['PixelFormat'])
216             cdef str bits_per_pixel_prop = str(self.properties['PixelSize'])

it worked
for im in cam.grap_images(1): print im
[[187 175 181 ..., 255 255 255]
 [189 185 177 ..., 255 255 255]
 [189 179 186 ..., 255 255 255]
 ...,
 [255 255 255 ..., 255 255 255]
 [255 255 255 ..., 255 255 255]
 [255 255 255 ..., 255 255 255]]

ah this is one of these Python 2 vs. 3 issues. I'll fix it.


[opentelemetry-collector] fix HPA kind for StatefulSet mode

Fixes: #1024
Change was tested locally using commands:
helm template ./charts/opentelemetry-collector \
--values ./charts/opentelemetry-collector/ci/hpa-statefulset-values.yaml

helm template ./charts/opentelemetry-collector \
--values ./charts/opentelemetry-collector/ci/hpa-deployment-values.yaml

Hi approvers 👋🏻
Let me know if I missed something in the contribution rules.


Fixed editor log collapsing of duplicate messages not working

Closes #48930
The internals of Rich Text Label is pretty confusing to me so I apologise for the faffing about with this editor log stuff. I hope this is the last of it.

Side note: This UndoRedo event spam when editing properties with a slider is really getting tedious. It's good that it's grouped now, but at the same time it's distracting to see such high numbers for something so trivial (and the info box on the right side will quickly grow to 5-digit numbers or more in a short dev session).
That's not related to this fix specifically but we should really improve this in the future (likely by doing like all other editing tools with dragging do: register a drag from A to B as a single action, not 200 intermediate steps).

@akien-mga Yeah, even with that spam when you press undo, it does not step through every intermediate step - just the start and end, so i guess it is half way there...? Haven't looked into it.

Thanks!


JTDDataType signature for compile and verify

What version of Ajv you are you using?
master (7 or 8)
What problem do you want to solve?
Add signatures to AjvJTD's compile and verify methods that would support something like:
const schema = { ... } as const
const verify = ajv.compile(schema)
if (verify(data)) {
    const typed: JTDDataType<typeof schema> = data // no type errrors
}

What do you think is the correct solution to problem?
Note entirely sure, opening this up for discussion, versus continuing to talk on PR #1458.
I've been looking at how to do this, and I'm starting by implementing SomeJTDSchemaType and modifying the signature of compile. Previously I remember talking about having the AjvJTD subclass have different type arguments from the core Ajv class. I vaguely remember you not wanting to. Is there a reason you don't want to do this? Is there a significant cost to the super call?
Will you be able to implement it?
Yes

7 or 8

It's ok to add to 7 I think

implementing SomeJTDSchemaType and modifying the signature of compile

That seems ok, as you suggested in the PR there would be extra signatures in the core class:
compile<T extends SomeJTDSchemaType >(schema: T): ValidateFunction<JTDDataType<T>>;

having the AjvJTD subclass have different type arguments from the core Ajv class

some risk of divergence, additional complexity, some cost of extra call. Is there a reason why adding extra signature could be bad? Also, If JTD type signature were to be in the subclass why would JSON Schema signature be in core?
I do not plan many schema languages, so keeping it in core seems ok.
Also, I just never liked it when I had to add any executable code to satisfy type system/improve type safety :) It would have been nice if typescript had some zero-cost abstractions to add method overloads in subclasses...

yeah, those are good points. I'll see why I can do. There's some complexity that seems to come from the mingling of JTDDataType and ValidateFunction that I'm trying to understand. Will update. My guess is this won't make it in until 8.

The more I've played with this, the more it seems that JTDDataType is teetering right at the limits of typescripts complexity. It works when used by itself, but adding one more indirection of inferring it as a function argument makes typescript fail.
The solution probably lies in making it a little simpler if possible, or maybe having compile only work for definitions without refs, as that seems to be the cause of a lot of the complexity.
I'm still playing around with ideas, because I think it would be really cool for
const schema = ... as const
const validator = ajv.compile(schema)

to just work without additional typing.


[FEATURE] Easier file restore from Longhorn backup

Is your feature request related to a problem? Please describe (👍 if you like this request)
We're using Longhorn S3 backups. Unfortunately, we need to use large PVs for file storage, these PV sizes exceed a few hundred GBs.
If we need to view or restore just one file from the backup, we need to restore a huge amount of data to another PV and then we can do our investigation.
Describe the solution you'd like
Longhorn provides another backup method that preserves the file system layout in the S3 bucket.
Describe alternatives you've considered
Any other workaround is fine with me if there is a tool that can extract files from Longhorn backup.

An interesting feature request.
s3backer serves a similar purpose and is implemented by FUSE. Unfortunately, the block layouts and formats of Longhorn and s3backer are different, but we can leverage it if we or others want to implement. it.


Add cffi and bcrypt to dev requirements.

@johngian r?

Let's move those requirements to prod.
r+wc


Problem with ensureFocusedSuggestionIsVisible

Hi @moroshko,
I'm using the react-autosuggest component and applying the following two styles to the suggestionsContainer in my theme in order to get a scrollable dropdown when there are enough suggestions to exceed 300px:
.autosuggest-menu-outer {
max-height: 300px;
overflow: auto;
}
A recent change to react-autowhatever seemed to introduce a bug where if I scroll down in the list and then move my mouse pointer to the top element I can get the list to scroll by itself all of the way to the top of the list without ever touching the mouse wheel. I've been able to repro this on a variety of platforms and browsers (currently on Mac Chrome), but it seemed to be more serious in Windows. Looking at the code in ensureFocusedSuggestionIsVisible, it seems that it will autoscroll to align the top of a focused item to the container. The bug is likely around this logic as even after the initial alignment I seem to be able to get it to then align to the previous item indefinitely. When I built react-autosuggest with a react-autowhatever dependency of '~3.1.0' instead of '^3.1.0' the problem went away.
## Steps to reproduce:

Check out the JSFiddle I setup https://jsfiddle.net/thomasbottonari/b6m0frgs/
Type 'a' in the autosuggest element
scroll to the bottom
move the mouse pointer to the first visible item in the dropdown (it should align to the top of that item)
Continuously move the mouse just above the react-autosuggest__suggestions-container and then back on to the first visible item and watch the list continue to scroll until it hits the top.

@pdc Any chance you could help with this one?

Is any workaround available for this issue? I'm having the same autoscroll issue in react-autosuggest 10.1.0


Deployment failed - miss msbuild target: pipelinePreDeployCopyAllFilesToOneFolder

My GitHub url is - https://github.com/Microsoft/ViprService
The deployment is:
Command: "D:\home\site\deployments\tools\deploy.cmd"
Handling .NET Web Application deployment.
All packages listed in packages.config are already installed.
All packages listed in packages.config are already installed.
  Restoring NuGet packages...
  To prevent NuGet from downloading packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages'.
  All packages listed in packages.config are already installed.
  ViprService -> D:\home\site\repository\src\ViprService\bin\ViprService.dll
D:\home\site\repository\src\ViprService\ViprService.csproj : error MSB4057: The target "pipelinePreDeployCopyAllFilesToOneFolder" does not exist in the project.
Failed exitCode=1, command="D:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe" "D:\home\site\repository\src\ViprService\ViprService.csproj" /nologo /verbosity:m /t:Build /t:pipelinePreDeployCopyAllFilesToOneFolder /p:_PackageTempDir="D:\local\Temp\cec7964f-a0d6-4985-87c2-d5b12d052d13";AutoParameterizationWebConfigConnectionStrings=false;Configuration=Release /p:SolutionDir="D:\home\site\repository\.\\"
An error has occurred during web site deployment.
Handling .NET Web Application deployment.
All packages listed in packages.config are already installed.
All packages listed in packages.config are already installed.
  Restoring NuGet packages...
  To prevent NuGet from downloading packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages'.
  All packages listed in packages.config are already installed.
  ViprService -> D:\home\site\repository\src\ViprService\bin\ViprService.dll
D:\home\site\repository\src\ViprService\ViprService.csproj : error MSB4057: The target "pipelinePreDeployCopyAllFilesToOneFolder" does not exist in the project.
Failed exitCode=1, command="D:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe" "D:\home\site\repository\src\ViprService\ViprService.csproj" /nologo /verbosity:m /t:Build /t:pipelinePreDeployCopyAllFilesToOneFolder /p:_PackageTempDir="D:\local\Temp\cec7964f-a0d6-4985-87c2-d5b12d052d13";AutoParameterizationWebConfigConnectionStrings=false;Configuration=Release /p:SolutionDir="D:\home\site\repository\.\\"
An error has occurred during web site deployment.
D:\Program Files (x86)\SiteExtensions\Kudu\44.40324.1452\bin\scripts\starter.cmd "D:\home\site\deployments\tools\deploy.cmd"

Can you check whether your project can deploy locally, by following these steps?

Thx. I'll try.
When creating the project, there is a n option on ASP.NET template that you can check to deploy to Azure, and there will be some scripts in the PublishScripts folder, and Web Publish Activity tab. I didn't check that box. Is it required? What's the relationship between these two publish configs?

Nothing special is needed, as Azure Web Apps work with completely regular projects. Let's do that investigation step first, and we can go from there. If it fails to deploy locally as well, then at least we can close here knowing that it is not Azure/Kudu related.

@davidebbo thanks. Issue resolved (missing js file from project).

Hello, what kind of a file? I have the same problem. What was the solution to this please?

@x00105893 so yours also fails to deploy locally using the steps above? In @YingP99's case, it was apparently a .js file.

it runs locally normally, but when i'm trying to deploy to azure using github it gives the same error. I couldnt figure out where do i get this .js file from, i'm new to this
Thank you

Please try the steps suggested in my first reply in this thread.

Mine is _reference.js under Scripts folder

i went through the steps, ran it as website. All working. What is my next step please?

Next step would be the share a repo that demonstrates the issue. See this page for details.

my github https://github.com/x00105893/Project2015

And to make sure there is no misunderstanding, can you confirm that you are getting the same error as in this issue: error MSB4057: The target "pipelinePreDeployCopyAllFilesToOneFolder" does not exist in the project?

negative, i get a fault in azure, while it trying to deploy using github. full error looks like this:
Command: "D:\home\site\deployments\tools\deploy.cmd"
Handling .NET Web Application deployment.
All packages listed in packages.config are already installed.
All packages listed in packages.config are already installed.
ContactManager -> D:\home\site\repository\ContactManager\bin\ContactManager.dll
Transformed Web.config using D:\home\site\repository\ContactManager\Web.Release.config into obj\Release\TransformWebConfig\transformed\Web.config.
Copying all files to temporary location below for package/publish:
D:\local\Temp\e6da67ac-32c0-42a8-b960-7675389e88a2.
D:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\Web\Microsoft.Web.Publishing.targets(2988,5): error : Copying file App_Data\aspnet-ContactManager-20150306010642.mdf to D:\local\Temp\e6da67ac-32c0-42a8-b960-7675389e88a2\App_Data\aspnet-ContactManager-20150306010642.mdf failed. Could not find file 'App_Data\aspnet-ContactManager-20150306010642.mdf'. [D:\home\site\repository\ContactManager\ContactManager.csproj]
Failed exitCode=1, command="D:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe" "D:\home\site\repository\ContactManager\ContactManager.csproj" /nologo /verbosity:m /t:Build /t:pipelinePreDeployCopyAllFilesToOneFolder /p:_PackageTempDir="D:\local\Temp\e6da67ac-32c0-42a8-b960-7675389e88a2";AutoParameterizationWebConfigConnectionStrings=false;Configuration=Release /p:SolutionDir="D:\home\site\repository.\"
An error has occurred during web site deployment.
Handling .NET Web Application deployment.
All packages listed in packages.config are already installed.
All packages listed in packages.config are already installed.
ContactManager -> D:\home\site\repository\ContactManager\bin\ContactManager.dll
Transformed Web.config using D:\home\site\repository\ContactManager\Web.Release.config into obj\Release\TransformWebConfig\transformed\Web.config.
Copying all files to temporary location below for package/publish:
D:\local\Temp\e6da67ac-32c0-42a8-b960-7675389e88a2.
D:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\Web\Microsoft.Web.Publishing.targets(2988,5): error : Copying file App_Data\aspnet-ContactManager-20150306010642.mdf to D:\local\Temp\e6da67ac-32c0-42a8-b960-7675389e88a2\App_Data\aspnet-ContactManager-20150306010642.mdf failed. Could not find file 'App_Data\aspnet-ContactManager-20150306010642.mdf'. [D:\home\site\repository\ContactManager\ContactManager.csproj]
Failed exitCode=1, command="D:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe" "D:\home\site\repository\ContactManager\ContactManager.csproj" /nologo /verbosity:m /t:Build /t:pipelinePreDeployCopyAllFilesToOneFolder /p:_PackageTempDir="D:\local\Temp\e6da67ac-32c0-42a8-b960-7675389e88a2";AutoParameterizationWebConfigConnectionStrings=false;Configuration=Release /p:SolutionDir="D:\home\site\repository.\"
An error has occurred during web site deployment.
D:\Program Files (x86)\SiteExtensions\Kudu\44.40324.1452\bin\scripts\starter.cmd "D:\home\site\deployments\tools\deploy.cmd"

But you started out saying you had the same problem. I think that's the root of the confusion. If you have an unrelated deployment issue, we'll definitely want a new issue. A given issue is never used to track more than one problem.

ahh, i see. it felt like i had the same issue. My bad.
Apologise.

No problem. We're happy to help with your problem too. :)

https://github.com/timgabrhel/aspnetcore-kudurepro
I've created a repository with a repro project. See the readme for steps taken to see this error.

Unload the project, right click it go to tools, edit, then add these lines below the only import node in the file:
<Import Project="$(VSToolsPath)\WebApplications\Microsoft.WebApplication.targets"
    Condition="'$(VSToolsPath)' != ''" />
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v11.0\WebApplications\Microsoft.WebApplication.targets"
    Condition="true" />

@timgabrhel I was able to make your repo work with Kudu by simply adding a global.json at the root:
{
  "projects": [ "src", "test" ],
  "sdk": {
    "version": "1.0.0-preview2-1-003177"
  }
}

I am also getting this issue. I am working in visual studio for mac (I think that might be the issue). I added the global.json file to my WebAPI project and I am still getting "error MSB4057: The target "pipelinePreDeployCopyAllFilesToOneFolder" does not exist in the project."  When I set it as my start up project and run it I get this for a stack trace:
"at System.Web.StaticFileHandler.ProcessRequest (System.Web.HttpContext context) [0x00094] in /private/tmp/source-mono-2017-02/bockbuild-2017-02/profiles/mono-mac-xamarin/build-root/mono-x86/mcs/class/System.Web/System.Web/StaticFileHandler.cs:77
at System.Web.DefaultHttpHandler.BeginProcessRequest (System.Web.HttpContext context, System.AsyncCallback callback, System.Object state) [0x0007f] in /private/tmp/source-mono-2017-02/bockbuild-2017-02/profiles/mono-mac-xamarin/build-root/mono-x86/mcs/class/System.Web/System.Web/DefaultHttpHandler.cs:101
at System.Web.HttpApplication+d__225.MoveNext () [0x008d4] in /private/tmp/source-mono-2017-02/bockbuild-2017-02/profiles/mono-mac-xamarin/build-root/mono-x86/mcs/class/System.Web/System.Web/HttpApplication.cs:1335
at System.Web.HttpApplication.Tick () [0x00000] in /private/tmp/source-mono-2017-02/bockbuild-2017-02/profiles/mono-mac-xamarin/build-root/mono-x86/mcs/class/System.Web/System.Web/HttpApplication.cs:927

I'm getting this error for deploying any website currently to a new server.
The site builds fine on the server manually.
Windows 2012 R2 with IIS 8.5

@rnelson30 @michael-nee-mw tracked by #2530


Fix type conversion for deposits causing peak shifts

Type conversion for number of charges creation during deposition truncated the result, causing bias to lower energies. This resulted in a peak shift towards lower energies. To fix this, the number of charges created is instead rounded to the nearest integer. Further details are explained here: https://allpix-squared-forum.web.cern.ch/t/charge-creation-type-conversion-introduces-peak-shift-to-lower-energies/405

Hi @SBlokhuizen
thanks a lot for the investigation and the fix!
I only have one request - would you mind adding your name to the alphabetic list of contributors in AUTHORS.md?
Thanks a lot,
Simon

Hi @simonspa
I have added my name to the authors page.
Regards,
Sebbe

Excellent, thanks!
I'll push the branch to CERN Gitlab to get our full CI.

@SBlokhuizen sorry for the wait, we wanted to validate a few simulations with this change - it's now in:
https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/982
This will be part of the next feature release 3.1.0.


ERD

https://drive.google.com/file/d/1PZqkMdRnNbckXMzSaErNo-Cf1rRc6YoB/view?usp=sharing

Hi @Ne0kropolis
I don't think we need the agentCode and status in the Agent entity. We can just create a UserType entity that specifies the type of user the person is and link it with the userType field that  you have in the User entity. We can then move status to the User entity to identify if they are active or inactive.
Then in the Property entity we can use the userID instead of agentCode.
That's just my thoughts let me know if I maybe misinterpreted the ERD, other than that everything looks good.


Please provide pdf version

Running arbitrary js code sounds pretty dangerous from a security perspective. Please provide a pdf version of the slides.
https://revealjs.com/pdf-export/

Fair point. Unfortunately something about how I formatted the images in this slide deck causes them to slide off the screen when exported to PDF. Will need to figure out what is going on there and make that change first.


BigbrainIntensityProfile - determine the thickness files for left and right hemispheres

Determine the thickness files for left and right hemispheres of bigbrain in livequeries.bigrain.py. Potentially, calculate from the mesh data (but this might not be the same as how the authors did it, i.e., they might have used equivolumetric distance calculation)

Since the data is taken from  https://github.com/kwagstyl/cortical_layers_tutorial, the right hemisphere will not be supported for this specific feature. (Deve meeting 14.11.23)


Replace text color with danger or warning icon in TooltipFieldValue

Description
Problems

Color text causes accessibility problems like assumption of perfect color vision.

Color theme classes from template literal like text-${type}-600 prevents Tailwind optimization to purge unused classes.

Analysis
Find in Files <TooltipFieldValue 17 results in 5 files.
Optional type and dataTestId props in only one result:
src/Components/TimelineGraph/EventsGraph/EventTooltipFields/ProcessActivityTooltipFields.js
            <TooltipFieldValue
                field="UID"
                value={uid}
                type={uidType}
                dataTestId="tooltip-uid-field-value"
            />

Solution

Update integration tests not to select by field key UID instead of data-testid attribute.

Edit src/Components/TimelineGraph/EventsGraph/EventTooltipFields/ProcessActivityTooltipFields.js

Replace classic 'caution' and 'alert' with PatternFly 'warning' and 'danger' strings.

Rename dataTestId as testid prop for more effective Find in Files.

Rewrite src/Components/TooltipFieldValue/TooltipFieldValue.tsx

Residue

Import reusable DangerIcon and WarningIcon function components.

Checklist

[ ] Investigated and inspected CI test results
[x] Edited integration tests

Testing Performed
Integration testing

yarn cypress-open in ui/apps/platform

networkGraph/tooltip.test.js is skipped
risk/deploymentTimeline.test.js
risk/podTimeline.test.js

Manual testing

Visit /main/network

Point at an edge

Point at an external entity

Visit /main/risk, click a deployment, click Process Discovery tab, click View Graph, and point to the icon for an event

Plain color text for UID field

Classic 'caution' color text for UID field

PatternFly 'warning' color icon for UID field

Classic 'alert' color text for UID field

PatternFly 'danger' color icon for UID field (although red on black is bad for color vision, PatternFly dark theme is the future solution)

I will rebase after correction has been merged for incorrect assertion in failed Network Graph integration test.


Performance enhancements to parsing

PR #4350 by @fabioz contains nice looking performance enhancements for parsing. This issue exists mainly to get the enhancements listed in release notes. Need to test how much that affects normal execution times but parsing enhancements nevertheless help with editors and other tools that use Robot's parsing modules.

PR #4350 has been merged and I did some changes to the related code afterwards. There may be still further enhancements but this issue can nevertheless be closed now.

Commit 41a8f608e3ce6758de152b9ed4decbc8ea8183df contains some more performance enhancements, this time related to parsing variables from strings. It doesn't affect normal parsing times because Robot mostly searches variables at the execution time, but external tools using Token.tokenize_variables() see a small performance boost.


swagger ui not showing the default parameter value zero

Please take the time to search the repository, if your question has already been asked or answered.

[x] What version of the library are you using? Is it the latest version? The latest released version is

What kind of issue is this?

[ ] Question. Is this a question about how to do a certain thing?

[x] Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests or
steps to reproduce get fixed faster. Here’s an example: https://gist.github.com/swankjesse/6608b4713ad80988cdc9

[x] spring xml/java config that is relevant
[ ] springfox specific configuration if it makes sense
[ ] include any output you've received; logs, json snippets etc.; and what the expected output should be
[ ] if you have a repo that demonstrates the issue for bonus points! See this example

[ ] Feature Request. Start by telling us what problem you’re trying to solve. Often a solution
already exists! Don’t send pull requests to implement new features without first getting our
support. Sometimes we leave features out on purpose to keep the project small.

Please do consider starring this repository if you do like this project and find it useful.
I have a simple spring-boot web application, in my control, I have several method like this
	@ApiOperation(value = "查询活动告警", notes = "根据siteId以及可选的limit/offset查询活动告警")
	@RequestMapping(path="/{siteId}/alarm/activeAlarm", method = RequestMethod.GET, produces = "application/json")
	public FCSDKResponse<PageList<Alarm>> queryActiveAlarms(
			@ApiParam(name = "siteId", value = "The id of the site", defaultValue = "3F7B07E2") @PathVariable String siteId,
			@RequestParam(value="limit", defaultValue="10", required=false) int limit,
			@ApiParam(name = "offset", value = "The value of offset", defaultValue = "0") @RequestParam(value="offset", defaultValue="0", required=false) int offset)

If I set default value zero whether using @ApiParam or not, on the /swagger-ui.html, the default value of this parameter is empty.

This bug is still present. Version 2.9.2. The default field value stays empty or filled with a placeholder if '0' is set to 'defaultValue' or/and 'example' args of 'ApiParam'

This bug is still present. Version 3.0.0


Provide Darwin ARM64 on downloads page

Proposal
https://prometheus.io/download/ has darwin amd64, but not darwin arm64 (M1 Mac). I think nowadays, the latter is just as popular as the former and we should also include arm64 images.

Do you mean "by default" ?
because you can select it:

I download the node_exporter-1.6.1.darwin-arm64 in my MacBook with M2 chip, but node_exporter throws exception when run node_exporter. same error with 1.7.0 version. which one should i download? Thx

Hello from the bug scrub!
Given that currently sold Macs are usually darwin-arm64, we should probably have a "popular" selection for "architecture" as well, selected by default, which would be amd64 and arm64.
This has to be changed in the docs repo. We'll transfer this issue and would welcome a PR.

您好！我已收到您的邮件，我会尽快查看！        祝您生活愉快！


Allow a registration authority's information to be amended

[x] Translate
[ ] Install dev-develop of Middleware client bundle

@DRvanR

:+1:


Add variants of editing/navagiting methods that take relative index argument (paragraph index, column index)

I chose StyledDocument as the place to implement the base code for getAbsoluteCharPosition and not TwoDimensional because then that method would "pollute" its implementors with a confusing method name and parameters since it doesn't use int paragraphIndex and int columnIndex as its parameters but int major and int minor.

Looks, good, just not sure if I want to use "Char" in the method names. I try to be consistent in using the term position when pointing to a place between characters, and character index when pointing to a character.
 ┌ character 0
 | ┌ character 1
 | |   ┌ character 3
 | |   |
 v v   v

|_|_|_|_|

^ ^     ^
| |     |
| |     └ position 4
| └ position 1
└ position 0

I agree with keeping it consistent.
At the same time, I don't know if this distinction between position and character index is even stated in the javadoc or is as clear as the above picture.
Should it be in the javadoc? Or somewhere else in the project pages (ReadMe, Wiki, etc.)?

Well, since so many methods point to getAbsolutePosition(), whose javadoc now includes your picture, I think that takes care of the previous issue I raised.

👍


Ensure package managers link respects path prefix

Fixes an issue I discovered on my generated page (https://msfjarvis.github.io/twt/) where the 'View all downloads' URL did not have a path prefix and thus causes a 404.

Force pushed to get rid of the cargo fmt violations.


TS leftovers

@keybase/react-hackers bump this is the leftovers. after this we should be all ts for the app code


Update how-to-manage-classroom-labs.md

Removed "Internet Explorer 11 is not supported yet.", since I don't believe it's likely that it will be supported in the future.

@jms-du-se : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


hyprpicker causes segfault

I have hyprland and hyprpicker v0.4.1 installed. Command hyprpicker causes segmentation fault, but hyprpicker -z works just fine.

try git


Fix test that expected pre-GLR behavior.  RT##124572.

Alters 6.c-errata, so second opinion needed for merge.
See last PR for corresponding master branch commit.

👍 on the change, as the test is wrong. Empty is the correct return value, not an empty List
Probably can be done by just cherry picking the improved commit that went into master:
git checkout 6.c-errata
git cherry-pick 346f058338718f0e6777c5c90e50597b29441b52
git push

I did the cherry pick and committed the change. Thanks.


[SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause

What changes were proposed in this pull request?
Add doc about TRANSFORM and related function.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not need

Test build #137688 has started for PR 32257 at commit 731968f.

Test build #137688 has finished for PR 32257 at commit 731968f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137688/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42215/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42215/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42215/

ping @cloud-fan @maropu
When I back port #31010  to branch 3.0/3.1 I noticed that here's syntax is wrong. and I have modify this in  https://github.com/apache/spark/pull/32375 and https://github.com/apache/spark/pull/32376

Test build #138030 has started for PR 32257 at commit 1cbd472.

Test build #138030 has finished for PR 32257 at commit 1cbd472.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42548/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42548/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138030/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42548/

Merged to master.


Setting UnderWayData and ADCP to false in config is not considered?

Even though there is a flag for setting adcs and underwaydata to false in the user config, this seems to have no effect?
https://github.com/OceanParcels/Virtual_ship_classroom/blob/06dc1902c85e24693537a4e6bdeb457576adbdc0/student_input.json#L15-L16
Should these lines
https://github.com/OceanParcels/Virtual_ship_classroom/blob/06dc1902c85e24693537a4e6bdeb457576adbdc0/virtualship.py#L318-L321
be something like below?
if config.ADCP_data:
    pset_ADCP.execute([SampleVel], dt=adcp_dt, runtime=1, verbose_progress=False)
    adcp_output_file.write(pset_ADCP, time=pset_ADCP[0].time)
if config.underway_data:
    pset_UnderwayData.execute([SampleS, SampleT], dt=adcp_dt, runtime=1, verbose_progress=False)
    UnderwayData_output_file.write(pset_UnderwayData, time=pset_ADCP[0].time)

And also for other calls of adcp_output_file and UnderwayData_output_file etc

Yes it should...


enable text-to-speech setup on macOS

Discovered that pyobjc specified in the Pipfile doesn't respect the platform restriction and tries to install on Linux and Windows, which obviously doesn't work. Converting to draft until an acceptable solution is found.

This should be ready now, if not a 100% complete solution.
pyobjc is a bundle package and doesn't respect a restricted installation when specified in the Pipfile. I tried several workarounds but nothing I tried made it work. If it's not installed the TTS config UI still shows up on macOS but doesn't allow setting or testing of voices. However this really only affects devs using the source version as an installed package should require the modules as part of the installation (upcoming PR to cover that in detail).


configure: Get version string from git or from VERSION file

Use git to create the version string if possible.
Otherwise get the version from the VERSION file.
Signed-off-by: Stefan Weil<EMAIL_ADDRESS>

@stweil Please also update ccutil/version.h to use VERSION.

That file will be removed in one of the next steps.


Warn about truncation when listing collections

Related to slack thread (internal).
GET /api/collections do not return complete objects. Collections are truncated to keep only 4 items for performance reasons. This PR adds a warning in the api.md documentation.
(related PR for hub docs: https://github.com/huggingface/hub-docs/pull/1146)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for the quick review :)


idem minor version number cleanup

those version numbers look like salt version numbers and not idem ones. The last bit about the output of 'idem exec test.version' is invented. It blows up on my site so I do not know what this would actually report? I assume it might be the output in invented, but maybe that is well off.

Sounds good! Let's go with option 2. Thanks!


Refactor WeightRampingUpStrategy to be timestamp based

Motivation:
The motivation for this PR stems from #5688.
The current WeightRampingUpStrategy internally maintains the ramping up status of endpoints. However, it is possible that although an EndpointGroup has just been created certain endpoints must be considered already ramped up. For instance, in xDS we newly create an EndpointGroup every time a ClusterSnapshot is updated. However, even if a ClusterSnapshot has changed, we need to retain an endpoint's ramping up status.
To resolve this, I propose a timestamp based solution. Specifically, I believe an Endpoint can maintain a state createdAtNanos and WeightRampingUpStrategy can refer to this value to determine the ramp-up status. We can also allow users to specify their own timestamp via an attribute if they are maintaining their own Endpoint pool like done in xDS.
While implementing a timestamp based solution, I found that the previous logic is probably simpler to manage if it were refactored. Specifically, I propose that a rampingUpInterval is divided into rampingUpTaskWindows. Each rampingUpTaskWindow will be assigned a scheduler. If a scheduler doesn't have any more endpoints to ramp up, the scheduler is stopped. I've also removed the endpoint deduplication related logic to make the implementation simpler.
Modifications:

Defined an attribute createdAtNanos which signifies when an Endpoint has been created.
Refactored WeightRampingUpStrategy to refer to createdAtNanos when computing the initial ramping up step
Refactored WeightRampingUpStrategy overall to always use the created timestamp when 1) determining the initial ramping up step 2) determining which ramping up scheduler to use

Removed deduplication logic for simplifying logic
Removed weight update logic for simplifying logic.

Result:

We can prepare to support WeightRampingUpStrategy for xDS.

@jrhee17 👍 👍 👍


Generic Class Component wrapped in withStyles - TS error

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When trying to create a React Class component with generic props, if it's wrapped with withStyles HOC it produces error.
https://codesandbox.io/s/quiet-smoke-tnk9u?file=/src/App.tsx

@Tomassito We discourage the usage of withStyles and class components. You will find more luck on StackOverflow.


HAPI FHIR test server is down

After click
http://hapi.fhir.org/
It shows 502 Bad Gateway.

It is working now, Thanks!


docs: fix wrong import path

What type of PR is this?
docs

What this PR does / why we need it (English/Chinese):

Fix wrong import path in redis example.
Which issue(s) this PR fixes:

None.

LGTM