Thanks for the shout out <3 Also I was wondering if you could help me out with something

That was a pleasant surprise! :D
I used GPT4 to help me out about upscaling latents through lanczos this afternoon.
You can find it here.
Now of course the results that I am getting are as blurry as you can imagine and so just as viable as any other method.

You can find a workflow here
I was visiting your repository, wondering if there would be a way to somehow rearrange the latent into an image so to be able to do a proper lanczos upscale and then "put it back" into a latent. Since you know a lot more than me about the subject, I figured I would just ask :)
There wouldn't even be a need to modify the datas to make them RGB, just to be able to use lanczos on them with the provided functions within my node and reshape it to the correct latent format.
This combined with a fractal noise generator would allow to upscale mid-generation and new levels of creativity. As for now my only option is to decode->upscale image with lanczos (I made two small nodes using PIL that you can find in my linked repository if you want)->reencode with the VAE and finish the work with the refiner. While this is not a completely bad method it is also definitely not fast. Given that my knowledge about how the VAE works is pretty low, I also suspect that doing this mid-generation might also reduce the quality or complexity. It is also pretty limited overall.
Here is a Perlin Merlin Rabbit who used the wrong spell:

Figured you'd appreciate being linked to, didn't really feel right naming my repo "advanced noise" when it isn't really, well, advanced.

I was visiting your repository, wondering if there would be a way to somehow rearrange the latent into an image so to be able to do a proper lanczos upscale and then "put it back" into a latent.
Since you know a lot more than me about the subject, I figured I would just ask :)

Fair, though I don't actually have a background in any of this AI stuff so I'd still double-check anything I say with GPT4 if I were you lol.
Anyway, to address your question, I think the main problem with upscaling latents is that not all features map 1:1 properly. Especially around edges/borders/fine details, it seems to be non-linear, at least to some degree. This part makes sense right, how else would it fit a 3x512x512 image into 4x64x64.
Another way to think of it is like this: If you grab a brush in photoshop and set it to 4px wide, then it will be the same width at any resolution, both 512x512 and 1024x1024. Now, if you upscale your 512x512 drawing to 1024x1024 and start drawing with your 4px brush, your lines will no longer line up to the old ones. The "VAE" expects all "lines" to look the same, regardless of resolution.
Here's an example. This image is perfectly split in the middle and the res is divisible by 8, meaning even when it gets upscaled, it should retain that "split" in the middle. It works for black and white (mostly), but add any colors and suddenly the weird behavior appears again. I think this might be because the blue channel is negative in some of the latent channels, meaning to make the image "more" blue you have to make the actual numbers in the latent space smaller, but then again, no clue, I haven't messed with this enough to know and the SDXL latent space is completely different to begin with.

There wouldn't even be a need to modify the datas to make them RGB, just to be able to use lanczos on them with the provided functions within my node and reshape it to the correct latent format.

I know even less about image manipulation algorithms, but can't you directly run lanczos on your 4D vector if you're not turning it into an image? I doubt lanczos would mess up the details inside the latent space any less than bicubic does but who knows, might still be worth a try. Unless you mean fixing the issue with the details getting muddled, in which case I have zero idea. I guess you could get some content-aware algo going but that seems... painful.

This combined with a fractal noise generator would allow to upscale mid-generation and new levels of creativity.
I also suspect that doing this mid-generation might also reduce the quality or complexity.

Now, the problem here is that any time you force it back into the image, the "leftover noise" gets lost (I think). If I understand it correctly, your repo solves that by generating the same noise but at a different resolution, which is pretty genius. Your problem is the actual image part, which you'd have to somehow beat into the right shape to go into the second sampler.
My idea/solution for something like this would be to train a neural network for it. Probably something like a modified ESRGAN that works on latents instead of images, trained from scratch. This would (probably) preserve enough of the noise + the details to not ruin your image, and would also avoid the VAE encode/decode stuff.
Not sure how viable this is and it's not like I have an A100 to train on (all I have is 2xP40s and a crappy 10GB 3080 lol) but I can give it a shot if you want.
Anyway, I hope my rambling helps you at least somewhat. If it doesn't just ask me again, I'm horrible with explanations but happy to help lmao

Actually, wait, it doesn't even need ESRGAN. I can literally get a working upscaler with a 2MB model lol.
		module_list = [
			nn.Conv2d(4, 64, kernel_size=5, padding=2),
			nn.ReLU(),
			nn.Upsample(scale_factor=2.0),
			nn.ReLU(),
			nn.Conv2d(64, 64, kernel_size=7, padding=3),
			nn.ReLU(),
			nn.Conv2d(64, 64, kernel_size=7, padding=3),
			nn.ReLU(),
			nn.Conv2d(64, 32, kernel_size=7, padding=3),
			nn.ReLU(),
			nn.Conv2d(32, 4, kernel_size=5, padding=2),
		]

I think this might be because the blue channel is negative in some of the latent channels, meaning to make the image "more" blue you have to make the actual numbers in the latent space smaller, but then again, no clue, I haven't messed with this enough to know and the SDXL latent space is completely different to begin with.

That might explain why I had blue dots on my images during my attempts at creating usable noise. I was only able to solve that issue by "compressing towards zero" the values within the latent.
Example:

I don't actually have a background in any of this AI stuff

Me neither as you might have guessed lol!

Anyway, I hope my rambling helps you at least somewhat. If it doesn't just ask me again, I'm horrible with explanations but happy to help lmao

You helped me understand the problem better indeed and I thank you for you detailed answer! :)

Actually, wait, it doesn't even need ESRGAN. I can literally get a working upscaler with a 2MB model lol.
		module_list = [
			nn.Conv2d(4, 64, kernel_size=5, padding=2),
			nn.ReLU(),
			nn.Upsample(scale_factor=2.0),
			nn.ReLU(),
			nn.Conv2d(64, 64, kernel_size=7, padding=3),
			nn.ReLU(),
			nn.Conv2d(64, 64, kernel_size=7, padding=3),
			nn.ReLU(),
			nn.Conv2d(64, 32, kernel_size=7, padding=3),
			nn.ReLU(),
			nn.Conv2d(32, 4, kernel_size=5, padding=2),
		]

WAIT WHAT?! How do you do that? I have yet to know how to do such things.

WAIT WHAT?! How do you do that? I have yet to know how to do such things.

I just changed the training code from my latent interposer to take v1 latents on both sides then "designed" and trained a small neural net (the code part) that scales it up by a fixed amount. I'll clean up the code a bit and cook up some models overnight.
Should have your HQ latent upscaler by tomorrow ;D
(Only real problem is that it can only do fixed ratios, would x1.25, x1.5 and x2.0 scaling be enough or should I do more?)

That would be so awesome! Thank  you!

(Only real problem is that it can only do fixed ratios, would x1.25, x1.5 and x2.0 scaling be enough or should I do more?)

Big max x4 if you can without bothering but these ratios seems to be pretty good already! And it is always possible to try to loop back to get bigger sizes.

And it is always possible to try to loop back to get bigger sizes.

4x is pushing it, my training code/dataset is probably just awful. Though you do make a good point, chaining two of the 2x ones should work as a stopgap for the madman who wants to directly 4x his latents lol.

Yeah no then don't bother, I would rather loop through anyway!

Greetings. I finished the models/repo. It's available here: https://github.com/city96/SD-Latent-Upscaler
I have models for x1.25, x1.5 and x2.0, for both XL and v1.5. I teseted chaining two of the 2x ones for x4 and it works just fine. LMK if it works for your usecase.

I was frenetically refreshing the page since yesterday lol thank you so much!

Well it is still a better way to upscale the latents that anything that has been made so far so congrats!

I am currently trying to get results by combining it with the perlin-based noise generator but I wonder if I am not pushing it too far by multiplying the layers 6 times. While the overall pattern is still matching, I am getting results that so far are blurry. My generator is surely hard to set up correctly. I was able earlier to get, without upscale, correct results with 3 layers (I mean the "noise_iteration" value) after adding an option to make the mean value for each produced perlin layer to be at 0 instead of substracting it at the end but trying to understand what "kind of mess" should be passed to the refiner after an upscale is finicky.

It is more about keeping the in-between mess I guess. In order to provide something for the refiner to be able to work with.

I think your main problem is that your first advanced K-sampler doesn't return the leftover noise. I don't think you can avoid doing that, even if you inject your own perlin noise? (The step count might also be messed up, I just converted those back to widgets for testing.)
Not sure if it's possible to properly scale the actual leftover noise from the sampler. My crappy model certainly struggles to do it.
You can re-inject your perlin noise, as long as you don't scale it:

Yeah so far my best attempt was this one :

On this one I accidentally "rewinded" after the upscale without reinjecting noise but since I was using euler a I'd say that it doesn't count :-/
Using your latent interposer to do xl->1.5 -> upscale -> 1.5->xl made it better but so far my results are either blurry or having some sort of scanlines.

Using your latent interposer to do xl->1.5 -> upscale -> 1.5->xl made it better but so far my results are either blurry or having some sort of scanlines.

 I would've expected it to destroy the image completely.

I have a quick question. Is your perlin noise generator specific to SDXL? I was testing on v1 and noticed it was outputting garbage most of the time.
Also, I got this semi-coherent example by upscaling the noise separately and slightly overlapping the two samplers, like mentioned in the "BlenderNeko/ComfyUI_Noise" readme/example, though this is on v1 with the BNK noisy latent image node.
Anyway, I'm out of time for today.

Good call! Rewinding 10 steps works.
Not only it works but doing a x2 by generating a new and bigger layer of perlin noise (just as intended :D) actually enhances it to a freaky level!

You could almost read the plate number of the car on the left lol

To try the opposit I tested to upscale regular noise and re-used the same settings as for the house above and:

To not fool myself I decided to inject higher scale usual noise after the upscale for an honnest comparison.
So here are the results of a usual noise use as if we never tried anything differently:

It's just as smooth as usual SD1.5 even tho the model is good, the details seems to be smudged.
Now a batch of fractals :D

I think that we can say that it works.

This discussion mentions this one btw :)

Just a quick heads-up, I re-did all the models on the upscaler. Completely new model arch and training code so image quality is a lot better now. A simple git pull should get you up to speed.

@city96 The update also handles leftover noise quite well. Very clean, just the hue got changed a bit (but that's not a big deal for post processing).
Left is original perlin noise after XL sampling & before upscale, top right is the default bislerp upscale, bottom right is yours. Yours is much much better, great job!

@ntdviet Sorry, I saw you started the proper discussion but didn't have the time to post it there as well.
I'm glad it works, it seems a lot more flexible now but I didn't really test it with the leftover noise stuff. It's kinda amazing that it works, especially on XL (the v1 model still seems to outperform the xl model I think.).

WAIT WHAT?! How do you do that? I have yet to know how to do such things.

I just changed the training code from my latent interposer to take v1 latents on both sides then "designed" and trained a small neural net (the code part) that scales it up by a fixed amount. I'll clean up the code a bit and cook up some models overnight.
Should have your HQ latent upscaler by tomorrow ;D
(Only real problem is that it can only do fixed ratios, would x1.25, x1.5 and x2.0 scaling be enough or should I do more?)

When using LatentUpscaler, a ratio of 1.25-2 is sufficient.
What affects its wider use is that "the res is divisible by 8" causes the width and height pixels not to be aligned when the common image specification is upscale.

When you train the latent Upscaler model, choose the scale that can perfectly align the pixels with the common image specifications, which will greatly improve the practicability.
Translated with www.DeepL.com

Nx1080 is an odd resolution. We start with 512, 768 or 1024 for SDXL so if
you want it to be performant, keep it in scale with these figures and crop
your pic down to 1080 later.
Viet Nguyen
Tel. DE: +
49 176 5999 5952
Tel. VN: +84 93 804 5555
On Mon, Oct 9, 2023 at 6:36 AM suede299 @.***> wrote:

WAIT WHAT?! How do you do that? I have yet to know how to do such things.
I just changed the training code from my latent interposer to take v1
latents on both sides then "designed" and trained a small neural net (the
code part) that scales it up by a fixed amount. I'll clean up the code a
bit and cook up some models overnight.
Should have your HQ latent upscaler by tomorrow ;D
(Only real problem is that it can only do fixed ratios, would x1.25, x1.5
and x2.0 scaling be enough or should I do more?)
When using LatentUpscaler, a ratio of 1.25-2 is sufficient.
What affects its wider use is that "the res is divisible by 8" causes the
width and height pixels not to be aligned when the common image
specification is upscale.

When you train the latent Upscaler model, choose the scale that can
perfectly align the pixels with the common image specifications, which will
greatly improve the practicability.
Translated with www.DeepL.com
—
Reply to this email directly, view it on GitHub
https://github.com/city96/SD-Advanced-Noise/issues/1#issuecomment-1752334569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM7X3GUW326APUIDKAQGUZ3X6N5K7AVCNFSM6AAAAAA3QHAQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGMZTINJWHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

WAIT WHAT?! How do you do that? I have yet to know how to do such things.

I just changed the training code from my latent interposer to take v1 latents on both sides then "designed" and trained a small neural net (the code part) that scales it up by a fixed amount. I'll clean up the code a bit and cook up some models overnight.
Should have your HQ latent upscaler by tomorrow ;D
(Only real problem is that it can only do fixed ratios, would x1.25, x1.5 and x2.0 scaling be enough or should I do more?)

When using LatentUpscaler, a ratio of 1.25-2 is sufficient. What affects its wider use is that "the res is divisible by 8" causes the width and height pixels not to be aligned when the common image specification is upscale.  When you train the latent Upscaler model, choose the scale that can perfectly align the pixels with the common image specifications, which will greatly improve the practicability.
Translated with www.DeepL.com

Nx1080 is an odd resolution. We start with 512, 768 or 1024 for SDXL so if
you want it to be performant, keep it in scale with these figures and crop
your pic down to 1080 later.

WAIT WHAT?! How do you do that? I have yet to know how to do such things.

I just changed the training code from my latent interposer to take v1 latents on both sides then "designed" and trained a small neural net (the code part) that scales it up by a fixed amount. I'll clean up the code a bit and cook up some models overnight.
Should have your HQ latent upscaler by tomorrow ;D
(Only real problem is that it can only do fixed ratios, would x1.25, x1.5 and x2.0 scaling be enough or should I do more?)

When using LatentUpscaler, a ratio of 1.25-2 is sufficient. What affects its wider use is that "the res is divisible by 8" causes the width and height pixels not to be aligned when the common image specification is upscale.  When you train the latent Upscaler model, choose the scale that can perfectly align the pixels with the common image specifications, which will greatly improve the practicability.
Translated with www.DeepL.com

Nx1080 is an odd resolution. We start with 512, 768 or 1024 for SDXL so if you want it to be performant, keep it in scale with these figures and crop your pic down to 1080 later.

If the scaling is something like 1.2 / 1.4, then a 1080 image is perfectly fine.

@suede299
If I understand correctly, your main problem is that after the upscale the image doesn't align properly to 1920x1080 (e.g. downscaling would make it blurry)? The only thing I could really do is train a latent downscaler you can put after the x2 one but that's not really much of a solution...
The problem with resolutions like 1.2 and 1.4 is that they don't align with my training dataset properly. My max resolution is 1024x1024 for the x2 one, and my input is 512x512. From that, x1.25 is 640x640 and x1.5 is 768x768. x1.2 would be 614.4x614.4 and x1.4 would come out at 716.8x716.8.
You could try out NNLatentUpscale which can scale by arbitrary amounts. It's probably better than my solution anyway, since it used visual loss during training instead of just estimating loss across the latents.


Question : can we record audio while using daily transport for both input and output

I want to capture the audio we are receiving from daily input and the audio we are sending to the output transport. any straightforward way to do that?

If you use the DailyTransport then it should be super easy. The transport has a start_recording() method with the same arguments as https://reference-python.daily.co/api_reference.html#daily.CallClient.start_recording.
This will use Daily's recording functionality. Of course, your room must be configured with recordings enabled.
https://docs.daily.co/guides/products/live-streaming-recording

Closing. Feel free to reopen if you find any issues.

Hey @aconchillo , Thanks i will check this out, however my question was more general. for ex. In case of Webhook transport/server. what would be the recommended way to record the audio.
i was able to come up with adding a recorder service in the pipeline after the input and before the output which saves audio frames to a file and then redirects them back to the queue. however this had some challenges, tts output is not continuous and it is hard to get the timing of the segment right on the complete audio of the call.


Add support for the no new privs flag

Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

@liangchenye PTAL

LGTM


Drop the arrow functions

Mocha recommends avoiding arrow functions Due to the lexical binding of
this. More here.
This PR replaces every arrow function with plain functions. Also updates
the documentation.

https://github.com/spoonscen/es6-mocha-snippets-vs-code/issues/3
https://github.com/spoonscen/es6-mocha-snippets-vs-code/issues/7
Hey @malev! Thanks for making the PR. While it can be helpful to have mocha's context I find that I do not use it 99% of the time. In those rare occasions when I need to set the timeout for a particular test I update that one test. That being said, I have not found enough use cases to rid these snippets of arrow functions. I am definitely open to extending the snippets to include another set that use function instead of => I would accept this PR if it added to the current set of snippets instead of changing the functionality.

IMHO, using arrow functions is more of a syntax convenience and so far works for us in 99.99% of cases. In rare occasions when we need to access the mocha context, we'd replace that particular arrow function with function () {}.

@spoonscen, fair!
How about we using some other prefix for plain functions?
Something like fbefore, f-before or beforef? Would you be open to that? Keep in mind that before will stay they way it's already in master.
@demisx, I understand what you say. I just rather have 'em all the same making sure that the 0.01% also works :smile:, I guess it's a matter of style.

@malev Yes! I would love to have additional prefixes. Can you play with the names and see which one has the least collisions?

@spoonscen updated!

@malev Published a release! Should be live shortly.


Files on /mnt/c disappear on Pwsh/Ubuntu WSL when modules from /mnt/c are loaded

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
This has been happening for over a year through multiple versions of ubuntu and pwsh.

In Windows, clone a GH repo with a PowerShell module to C:\github
Install Ubuntu 20.04 on WSL
Install pwsh (this has been happening for over a year)
run pwsh
cd /mnt/c/github
Import-Module ./themodulepath -Force
Run a command from that module or maybe wait like a minute, not sure what triggers it
Files from loaded PowerShell modules imported in /mnt/c are deleted forever

Expected behavior
Files remain

Actual behavior
Files are deleted forever

Error details
None

Environment data
Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Linux <IP_ADDRESS>-microsoft-standa…
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
The reason I filed this here and not WSL is because it seems linked to PowerShell + WSL in some way? Note how the discordrpc module is not messed with. But the two modules I loaded are deleted. I have not observed any files on the native file system being deleted.
https://user-images.githubusercontent.com/8278033/196147494-722e67cf-ac24-4d3b-8c4c-74a35730f92e.mp4

I wondered if this happens after 60 seconds and it seems like it. It's almost exactly 60 seconds after the module has finished loading (?!)
$count = (Get-ChildItem ./dbatools).Count
Get-Date; Import-Module ./dbatools -Force; Get-Date; while ((Get-ChildItem ./dbatools).Count -eq $count) {};Get-Date

Monday, 17 October 2022 12:23:59
Monday, 17 October 2022 12:24:15
Monday, 17 October 2022 12:25:16

dbatools uses runspaces, maybe that's the timing thing? Let me try a module without runspaces
$count = (Get-ChildItem ./discordrpc).Count
Get-Date; Import-Module ./discordrpc -Force; Get-Date; while ((Get-ChildItem ./discordrpc).Count -eq $count) {};Get-Date

No files deleted? OHHHHHHHHHHHHHHHH this has got to be a path problem with our module! Thanks for reading!


doc: Created Catalog Framework Doc

Added review comments.

Incorporated all the feedback. Thanks!

We aren't covering dependencies with this one?

That is definitely in the pipeline and we will be replacing the existing Overview pages. This will be a separate PR.


Fix reg add command

Fix reg add command

@juanandmsft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@juanandmsft  : Thanks for correcting it. #sign-off


how to make a list from *.row.cs file ?

I used this code to make a list
`
AnswerSheetService.List({  }
, response => {
var myentities = response.Entities;
                        for (var i = 0; i < myentities.length; i++) {
                            myentities[i].Id = i.toString();
                            myentities[i].CurrentStatusScore = 0;
                            myentities[i].OptimalStatuScore = 0;
                            myentities[i].QuestionnaireId = "38308bf0-9fab-4dff-a8c7-55608502d470";
                            myentities[i].ItGQuestionText = ItGQuestionRow.getLookup().items[i].Text;

                        }
                     this.setItems(myentities);
                    })

`
as you can see I get my list by response  methdo but I like to make a list with nth item as i like
I need somthing like this
list < AnswerSheetRow > mylist=new AnswerSheetRow;
but it dosen't work in typescript.
how can I make a list from *.row.cs file ?

Did you try IncludeColumns?
AnswerSheetService.List({ IncludeColumns:["ItGQuestionText"] }?


strip trailing dots

Sorry, I was kinda out of commission for the last couple of days.
Tbh, I don't like the
getWordAndRange (editor, options = {
  bufferPosition: undefined,
  wordRegex: wordRegex,
  beginWordRegex: undefined,
  endWordRegex: undefined
})

API. Do you anticipate any need for user defined regexps there?
Imho it would be cleaner to just split the current "word" on .s and indicate in which the cursor is. Or maybe return a
[
  {
    text: 'Foo',
    range: [0, 2]
  },
  {
    text: 'bar',
    range: '[4, 6]
  }
]

for Foo.bar.

Sorry, I was kinda out of commission for the last couple of days.

No worries :)

Tbh, I don't like the
getWordAndRange (editor, options = {
  bufferPosition: undefined,
  wordRegex: wordRegex,
  beginWordRegex: undefined,
  endWordRegex: undefined
})

API. Do you anticipate any need for user defined regexps there?

yeah, fair enough. I made such a complex API since I thought it would be more extensible, but I'm not coming up with the use cases of the user-defined regexes other than this case for now, to be honest.

Imho it would be cleaner to just split the current "word" on .s and indicate in which the cursor is. Or maybe return a
[
  {
    text: 'Foo',
    range: [0, 2]
  },
  {
    text: 'bar',
    range: '[4, 6]
  }
]

for Foo.bar.

And so this would be better solution -- stripping trailing dots would be fairly easy with this approach, too. I will try to change the function APIs then :)

okay, e9e9845 hopefully simplifies the logic.


[GOBBLIN-1446] Parse Whitespace in Curli Request from GaaS

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin-1446 issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1446

Description

[X] Here are some details about my PR, including screenshots (if applicable):
When using the two filters cron-schedule and property-filter during search for flow-configs we do not handle the case when the parameters have white spaces in them. To encode the spaces in the curli url we use %20 and need to update GaaS endpoints to be able to parse them, so I have added code to replace %20 with a white space.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
My PR did not include unit testing as the filter functionality for flows could not be tested locally with FSSpecStore, however I verified that the encoding and decoding functionality with the debugger and deployment of open source GaaS via Docker.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3285 (e8c6287) into master (2e5eaca) will decrease coverage by 37.53%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5eaca...e8c6287. Read the comment docs.


Added Doc-Blocks for API documentation generation by ApiDoc

See: https://github.com/Strider-CD/strider/issues/667#issuecomment-120571324

Hopefully I did not make many mistakes, though I am sure that there are some.  I'll happily make corrections on request.
To view the output documentation, first checkout strider, then:
> cd strider
> npm install -g apiDoc
> npm run-script gendoc

.. output will go to apidocs.
On a side note, I added a .editorconfig file to the project as well.  My IDE settings promote tabs and not spaces, so I added the .editorconfig so that my IDE would not constantly overwrite your conventions with my own.

Regarding the Travis CI failure.  I apologize that I am not very familiar with Travis or the particulars of the Strider builds and tests, so I could be mistaken, but it seems like the tests are failing on code unrelated to my changes.  How should I proceed?

Luke, I think you are right that the tests are broken for unrelated
reasons. See #664
On Sunday, July 12, 2015, Luke Chavers<EMAIL_ADDRESS>wrote:

Regarding the Travis CI failure. I apologize that I am not very familiar
with Travis or the particulars of the Strider builds and tests, so I could
be mistaken, but it seems like the tests are failing on code unrelated to
my changes. How should I proceed?
—
Reply to this email directly or view it on GitHub
https://github.com/Strider-CD/strider/pull/835#issuecomment-120763407.

--
Niall O'Higgins
W: http://niallohiggins.com
E<EMAIL_ADDRESS>T: @niallohiggins

Wow @vmadman! Have you used apiDoc before? This is great, glad to have you contributing.

Also, you don't need to install it globally since it's installed as a devDependency, just run npm run gendoc after npm installing in the strider directory.

Wow @vmadman! Have you used apiDoc before? This is great, glad to have you contributing.

I've looked closely at it for one of our projects, and maybe tampered with it a bit, but have never officially used it.  I ended up going with Swagger, instead, because Swagger allowed for testing the API directly in the docs and allows you to be a bit more specific (with validators, etc).
Still, ApiDoc seems like a really nice product and its concepts were easy enough to follow.

Swagger cam up in my research, but it was so vague that I didn't even pursue it. Do you think ApiDoc is the right move, having used both so far?

I made several changes based on your previous feedback and pushed my changes.  Please let me know if I missed any or if you find anything else.

Swagger came up in my research, but their site is so vague that I didn't even pursue it. Do you think ApiDoc is the right move, having used both so far?

I think ApiDoc is more suitable for Strider.  Swagger has a lot of extra features but for smaller projects I think its a little too clunky.  We use the json-schema style swagger definitions in our "developer center" -- as we have commercial subscribers to our API.  More than once I've shaken my fist in the air, though, and I think its probably more than Strider would need.

Oh, I also forgot to mention:  Although my curl tests should be correctly formatted, I was not sure about how the auth process works.  I assume I would call POST /api/session and then retain a token of some sort for my subsequent calls, but I was not able to figure that out... so, my curl examples do not reflect that.
If you can provide me with a little insight into that I can update the docs and will add additional request and response examples.

I'm actually not that familiar with the auth process, but having a look at the code it looks like it's basic auth, so Basic <base64(username + ':' + password)> in the authorization header, so it can be done directly once you have an account, no two way process.
FWIW, I think this is a bad design security wise and In the future we should look at using JWT tokens or similar.


Make ASTNode return its subtree.

Currently to get subtree one need to use get_subtree method of AST, not of ASTNode. Moving this method to ASTNode would make it more convinient. To achive it we need to apply factory/DI trick to break circular import.

It is better to do ast framework refactoring separately in its own repo.


preLaunchTask to build using cmaketools in settings.json

I've tried using a build task but I couldnt get it to work. Is there any way to do this currently?
{
	// Use IntelliSense to learn about possible attributes.
	// Hover to view descriptions of existing attributes.
	// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
	"version": "0.2.0",
	"configurations": [
		{
			"name": "RelWithDebug",
			"type": "cppvsdbg",
			"request": "launch",
			"program": "${workspaceFolder}/Program/Etterna-release-symbols.exe",
			"args": [],
			"stopAtEntry": false,
			"cwd": "${workspaceFolder}",
			"environment": [],
			"externalConsole": true
		},
		{
			"name": "Release",
			"type": "cppvsdbg",
			"request": "launch",
			"program": "${workspaceFolder}/Program/Etterna.exe",
			"args": [],
			"stopAtEntry": false,
			"cwd": "${workspaceFolder}",
			"environment": [],
			"externalConsole": true
		}
	]
}

This is what i currently have for settings.

That's a shame. This extension is absolutely amazing! Thanks for the great work. It just worked. Having an easy way to setup the launch settings with automatic building would be a godsend.

+1 For this option!

+1 This would be great!

+1 I need it too

+1
I came here to see if there is already a suggestion to integrate cmake with the tasks system. And I found it. Unfortunately it looks like we're not getting this feature, at least anytime soon.
Is there any progress or is it still not possible due to technical reasons?
imho setting up tasks in vs code is not really intuitive and my tasks usually ignore everything I set in the cmake extension and just run cmake with default args. While this somehow works in my usual configuration, it fails to chose the right tools when I want to use a different kit.
I would greatly appreciate a "cmake" task type that just works, like the rest of the extension (great work btw).

Is there a workaround for launching a debug session and a build with a single command?

If you are using the CMake Tools debug feature (via the status bar or the command), a build will be triggered by an out of date state.
If you use a launch.json then no.

Found a good solution for this. Please give some thumbs up over here and hope it will be implemented finally.

@RolfNoot I also posted over there and will copy here for convenience.
Without preLaunchTask
There is an example launch.json in our documentation that shows how to do this without a preLaunchTask.  https://github.com/microsoft/vscode-cmake-tools/blob/develop/docs/debug-launch.md#debug-using-a-launchjson-file
The cmake.launchTargetPath and cmake.getLaunchTargetPath variable substitutions and their side effects (or lack thereof) are documented here: https://github.com/microsoft/vscode-cmake-tools/blob/develop/docs/cmake-settings.md#command-substitution.
With preLaunchTask
cmake.tasksBuildCommand should give you the cmake command required to build your binary, so if you want a preLaunchTask you could create a shell task that runs ${command:cmake.tasksBuildCommand} as the command (I see this is missing from the substitution documentation).

@bobbrow what should the type of task with ${command:cmake.tasksBuildCommand} be?
I've tried both "process" and "shell" and neither work because they treat the command as a single string instead of separate arguments:
The terminal process failed to launch: Path to shell executable "D:\Kicad\source\D:\devtools\CMake\bin\cmake.EXE --build d:\Kicad\source\build\vscode-msvc --config RelWithDebInfo --target install -j 26 --" does not exist.
The term 'D:\devtools\CMake\bin\cmake.EXE --build d:/Kicad/source/build/vscode-msvc --config RelWithDebInfo --target install -j 26 --' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name,  or if a path was included, verify that the path is correct and try again.

@qu1ck, try type "cmake" and command "build" (it will automatically use the same build command that tasksBuildCommand constructs). The "cmake" type of task was implemented more recently in our extension than when this report was discussed.

@andreeis I tried that before, failed, reported it here https://github.com/microsoft/vscode-cmake-tools/issues/1234#issuecomment-861932288, provided the logs you asked for but there was no follow up.
Please let me know if I can provide any more information.
Just repeated the test with type "cmake" and command "build". On linux machine it works fine, on windows machine I still get errors as described in my earlier report.

@qu1ck are you using PowerShell as your terminal?  I don't think the command works with PowerShell in VS Code anymore.  I use this setting to ensure that the regular Windows Command prompt is used.
    "terminal.integrated.defaultProfile.windows": "Command Prompt",

(may require reloading VS Code for the setting to take proper effect)
If you are just trying to ensure that stuff is built before you start debugging, you can use the example launch.json entry mentioned in the following documentation plus the cmake.buildBeforeRun setting instead of adding a separate build task for it: https://github.com/microsoft/vscode-cmake-tools/blob/main/docs/debug-launch.md#debug-using-a-launchjson-file

@bobbrow I had it set to null which I think is equivalent to default or "Command Prompt". Anyway, when setting to "Command Prompt" explicitly, same errors still occur. Bunch of "Cannot open include file" errors that are not there if I press F7 or run "command": "${command:cmake.build}","type": "shell".

Can you paste the output of your latest attempt?  If it says something about a cmdlet, then it's still trying to use PowerShell and you need to restart VS Code with that terminal setting set to "Command Prompt".
I don't know what you mean about the second part.  Where are the "Cannot open include file" errors?  In the terminal (which I didn't think was working), or as red underlines in the editor?

It's not using powershell.

Full output
> Executing task: CMake-build <

Starting build...
D:\devtools\CMake\bin\cmake.EXE --build d:/Kicad/source/build/vscode-msvc --config RelWithDebInfo --target install -j 26 --
[1/40] Creating image archive D:/Kicad/source/build/vscode-msvc/resources/images.tar.gz
[2/40] Generating version string header
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.23.0.windows.1")
-- Using Git to determine build version string.
-- Writing D:/Kicad/source/build/vscode-msvc/kicad_build_version.h file with version: (5.99.0-13222-g16a34e6adb-dirty)
[3/40] Building RC object gerbview\CMakeFiles\gerbview.dir\__\resources\msw\gerbview.rc.res
FAILED: gerbview/CMakeFiles/gerbview.dir/__/resources/msw/gerbview.rc.res
"D:/devtools/CMake/bin/cmcldeps.exe" RC D:\Kicad\source\resources\msw\gerbview.rc gerbview\CMakeFiles\gerbview.dir\__\resources\msw\gerbview.rc.res.d gerbview\CMakeFiles\gerbview.dir\__\resources\msw\gerbview.rc.res "Note: including file: " "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGERBVIEW -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I D:\Kicad\source\include -I D:\Kicad\source\gerbview -I D:\Kicad\source\resources\msw -I D:\Kicad\source\gerbview\dialogs -I D:\Kicad\source\common -I D:\Kicad\source\common\dialogs -I D:\Kicad\source\3d-viewer -I D:\Kicad\source\build\vscode-msvc -I D:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I D:\Kicad\source\scripting -I D:\Kicad\source\thirdparty\nlohmann_json -I D:\Kicad\source\thirdparty\compoundfilereader -I D:\Kicad\source\build\vscode-msvc\common -I D:\Kicad\source\libs\kimath\include -I D:\Kicad\source\thirdparty\clipper -I D:\Kicad\source\thirdparty\other_math -I D:\Kicad\source\thirdparty\rtree -I D:\Kicad\source\libs\kiplatform\include -I D:\Kicad\source\thirdparty\pybind11\include -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\include\opencascade -I D:\devtools\vcpkg\installed\x64-windows\lib\mswu -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\tools\python3\include -DWIN32 /fo gerbview\CMakeFiles\gerbview.dir\__\resources\msw\gerbview.rc.res D:\Kicad\source\resources\msw\gerbview.rc
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
D:\devtools\vcpkg\installed\x64-windows\include\wx/msw/wx.rc(12): fatal error C1083: Cannot open include file: 'windows.h': No such file or directory
[4/40] Building RC object bitmap2component\CMakeFiles\bitmap2component.dir\__\resources\msw\bitmap2component.rc.res
FAILED: bitmap2component/CMakeFiles/bitmap2component.dir/__/resources/msw/bitmap2component.rc.res
"D:/devtools/CMake/bin/cmcldeps.exe" RC D:\Kicad\source\resources\msw\bitmap2component.rc bitmap2component\CMakeFiles\bitmap2component.dir\__\resources\msw\bitmap2component.rc.res.d bitmap2component\CMakeFiles\bitmap2component.dir\__\resources\msw\bitmap2component.rc.res "Note: including file: " "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe -DBITMAP_2_CMP -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I D:\Kicad\source\include -I D:\Kicad\source\bitmap2component -I D:\Kicad\source\resources\msw -I D:\Kicad\source\build\vscode-msvc -I D:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I D:\Kicad\source\scripting -I D:\Kicad\source\thirdparty\nlohmann_json -I D:\Kicad\source\thirdparty\compoundfilereader -I D:\Kicad\source\build\vscode-msvc\common -I D:\Kicad\source\libs\kimath\include -I D:\Kicad\source\thirdparty\clipper -I D:\Kicad\source\thirdparty\other_math -I D:\Kicad\source\thirdparty\rtree -I D:\Kicad\source\libs\kiplatform\include -I D:\Kicad\source\thirdparty\potrace\include -I D:\Kicad\source\thirdparty\pybind11\include -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\include\opencascade -I D:\devtools\vcpkg\installed\x64-windows\lib\mswu -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\tools\python3\include -DWIN32 /fo bitmap2component\CMakeFiles\bitmap2component.dir\__\resources\msw\bitmap2component.rc.res D:\Kicad\source\resources\msw\bitmap2component.rc
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
D:\devtools\vcpkg\installed\x64-windows\include\wx/msw/wx.rc(12): fatal error C1083: Cannot open include file: 'windows.h': No such file or directory
[5/40] Building RC object kicad\CMakeFiles\kicad.dir\__\resources\msw\kicad.rc.res
FAILED: kicad/CMakeFiles/kicad.dir/__/resources/msw/kicad.rc.res
"D:/devtools/CMake/bin/cmcldeps.exe" RC D:\Kicad\source\resources\msw\kicad.rc kicad\CMakeFiles\kicad.dir\__\resources\msw\kicad.rc.res.d kicad\CMakeFiles\kicad.dir\__\resources\msw\kicad.rc.res "Note: including file: " "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DPCM -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I D:\Kicad\source\include -I D:\Kicad\source\kicad -I D:\Kicad\source\resources\msw -I D:\Kicad\source\pcbnew -I D:\Kicad\source\eeschema -I D:\Kicad\source\build\vscode-msvc -I D:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I D:\Kicad\source\scripting -I D:\Kicad\source\kicad\pcm -I D:\Kicad\source\thirdparty\nlohmann_json -I D:\Kicad\source\thirdparty\compoundfilereader -I D:\Kicad\source\build\vscode-msvc\common -I D:\Kicad\source\libs\kimath\include -I D:\Kicad\source\thirdparty\clipper -I D:\Kicad\source\thirdparty\other_math -I D:\Kicad\source\thirdparty\rtree -I D:\Kicad\source\libs\kiplatform\include -I D:\Kicad\source\kicad\pcm\dialogs -I D:\Kicad\source\thirdparty\picosha2 -I D:\Kicad\source\thirdparty\json_schema_validator -I D:\Kicad\source\thirdparty\pybind11\include -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\include\opencascade -I D:\devtools\vcpkg\installed\x64-windows\lib\mswu -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\tools\python3\include -DWIN32 /fo kicad\CMakeFiles\kicad.dir\__\resources\msw\kicad.rc.res D:\Kicad\source\resources\msw\kicad.rc
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
D:\devtools\vcpkg\installed\x64-windows\include\wx/msw/wx.rc(12): fatal error C1083: Cannot open include file: 'windows.h': No such file or directory
[6/40] Building RC object pagelayout_editor\CMakeFiles\pl_editor.dir\__\resources\msw\pl_editor.rc.res
FAILED: pagelayout_editor/CMakeFiles/pl_editor.dir/__/resources/msw/pl_editor.rc.res
"D:/devtools/CMake/bin/cmcldeps.exe" RC D:\Kicad\source\resources\msw\pl_editor.rc pagelayout_editor\CMakeFiles\pl_editor.dir\__\resources\msw\pl_editor.rc.res.d pagelayout_editor\CMakeFiles\pl_editor.dir\__\resources\msw\pl_editor.rc.res "Note: including file: " "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DPL_EDITOR -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I D:\Kicad\source\include -I D:\Kicad\source\pagelayout_editor -I D:\Kicad\source\resources\msw -I D:\Kicad\source\pagelayout_editor\dialogs -I D:\Kicad\source\common\dialogs -I D:\Kicad\source\build\vscode-msvc -I D:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I D:\Kicad\source\scripting -I D:\Kicad\source\thirdparty\nlohmann_json -I D:\Kicad\source\thirdparty\compoundfilereader -I D:\Kicad\source\build\vscode-msvc\common -I D:\Kicad\source\libs\kimath\include -I D:\Kicad\source\thirdparty\clipper -I D:\Kicad\source\thirdparty\other_math -I D:\Kicad\source\thirdparty\rtree -I D:\Kicad\source\libs\kiplatform\include -I D:\Kicad\source\thirdparty\pybind11\include -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\include\opencascade -I D:\devtools\vcpkg\installed\x64-windows\lib\mswu -I D:\devtools\vcpkg\installed\x64-windows\include -I D:\devtools\vcpkg\installed\x64-windows\tools\python3\include -DWIN32 /fo pagelayout_editor\CMakeFiles\pl_editor.dir\__\resources\msw\pl_editor.rc.res D:\Kicad\source\resources\msw\pl_editor.rc
cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
D:\devtools\vcpkg\installed\x64-windows\include\wx/msw/wx.rc(12): fatal error C1083: Cannot open include file: 'windows.h': No such file or directory
[7/40] Building CXX object kicad\pcm\CMakeFiles\pcm.dir\pcm.cpp.obj
FAILED: kicad/pcm/CMakeFiles/pcm.dir/pcm.cpp.obj
C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DPCM -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I..\..\include -I..\..\kicad\pcm\. -I..\..\kicad\. -I..\..\resources\msw -I..\..\pcbnew -I..\..\eeschema -I. -ID:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I..\..\scripting -I..\..\common -I..\..\kicad -I..\..\kicad\pcm\dialogs -I..\..\thirdparty\nlohmann_json -I..\..\thirdparty\compoundfilereader -Icommon -I..\..\libs\kimath\include -I..\..\thirdparty\clipper -I..\..\thirdparty\other_math -I..\..\thirdparty\rtree -I..\..\libs\kiplatform\include -I..\..\thirdparty\picosha2 -I..\..\thirdparty\json_schema_validator -I..\..\thirdparty\pybind11\include -ID:\devtools\vcpkg\installed\x64-windows\include -ID:\devtools\vcpkg\installed\x64-windows\include\opencascade -ID:\devtools\vcpkg\installed\x64-windows\share\wxwidgets\..\..\lib\mswu -ID:\devtools\vcpkg\installed\x64-windows\share\wxwidgets\..\..\include -ID:\devtools\vcpkg\installed\x64-windows\tools\python3\include /DWIN32 /D_WINDOWS /W3 /GR  /utf-8 /wd4290 /wd4800 /Zi /bigobj /EHs /MD /Zi /O2 /Ob1 /DNDEBUG /GF /Gy -std:c++14 /showIncludes /Fokicad\pcm\CMakeFiles\pcm.dir\pcm.cpp.obj /Fdkicad\pcm\CMakeFiles\pcm.dir\pcm.pdb /FS -c ..\..\kicad\pcm\pcm.cpp
D:\devtools\vcpkg\installed\x64-windows\include\curl/curl.h(49): fatal error C1083: Cannot open include file: 'stdio.h': No such file or directory
[8/40] Building CXX object kicad\pcm\CMakeFiles\pcm.dir\dialogs\dialog_pcm_progress.cpp.obj
FAILED: kicad/pcm/CMakeFiles/pcm.dir/dialogs/dialog_pcm_progress.cpp.obj
C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DPCM -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I..\..\include -I..\..\kicad\pcm\. -I..\..\kicad\. -I..\..\resources\msw -I..\..\pcbnew -I..\..\eeschema -I. -ID:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I..\..\scripting -I..\..\common -I..\..\kicad -I..\..\kicad\pcm\dialogs -I..\..\thirdparty\nlohmann_json -I..\..\thirdparty\compoundfilereader -Icommon -I..\..\libs\kimath\include -I..\..\thirdparty\clipper -I..\..\thirdparty\other_math -I..\..\thirdparty\rtree -I..\..\libs\kiplatform\include -I..\..\thirdparty\picosha2 -I..\..\thirdparty\json_schema_validator -I..\..\thirdparty\pybind11\include -ID:\devtools\vcpkg\installed\x64-windows\include -ID:\devtools\vcpkg\installed\x64-windows\include\opencascade -ID:\devtools\vcpkg\installed\x64-windows\share\wxwidgets\..\..\lib\mswu -ID:\devtools\vcpkg\installed\x64-windows\share\wxwidgets\..\..\include -ID:\devtools\vcpkg\installed\x64-windows\tools\python3\include /DWIN32 /D_WINDOWS /W3 /GR  /utf-8 /wd4290 /wd4800 /Zi /bigobj /EHs /MD /Zi /O2 /Ob1 /DNDEBUG /GF /Gy -std:c++14 /showIncludes /Fokicad\pcm\CMakeFiles\pcm.dir\dialogs\dialog_pcm_progress.cpp.obj /Fdkicad\pcm\CMakeFiles\pcm.dir\pcm.pdb /FS -c ..\..\kicad\pcm\dialogs\dialog_pcm_progress.cpp
D:\devtools\vcpkg\installed\x64-windows\include\wx/defs.h(725): fatal error C1083: Cannot open include file: 'stddef.h': No such file or directory
[9/40] Building CXX object common\CMakeFiles\common.dir\build_version.cpp.obj
FAILED: common/CMakeFiles/common.dir/build_version.cpp.obj
C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1429~1.300\bin\Hostx64\x64\cl.exe  /nologo /TP -DBOOST_ALL_NO_LIB -DBOOST_UUID_FORCE_AUTO_LINK -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD_BUILD_ARCH=x64 -DKICAD_BUILD_ARCH_X64 -DKICAD_CONFIG_DIR=kicad -DKICAD_SCRIPTING_WXPYTHON -DKICAD_SPICE -DKICAD_USE_OCC -DNOMINMAX -DUNICODE -DWXUSINGDLL -DWX_COMPATIBILITY -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D_USE_MATH_DEFINES -I..\..\include -I..\..\common\. -I..\..\resources\msw -I..\..\common\.\dialogs -I..\..\common\.\widgets -I..\..\common\.\dialog_about -I..\..\bitmaps_png -I..\..\3d-viewer -I..\..\pcbnew -I. -ID:\devtools\vcpkg\installed\x64-windows\include\python3.9 -I..\..\scripting -I..\..\thirdparty\libcontext -I..\..\thirdparty\nlohmann_json -I..\..\thirdparty\compoundfilereader -Icommon -I..\..\libs\kimath\include -I..\..\thirdparty\clipper -I..\..\thirdparty\other_math -I..\..\thirdparty\rtree -I..\..\libs\kiplatform\include -I..\..\thirdparty\pybind11\include -ID:\devtools\vcpkg\installed\x64-windows\include -ID:\devtools\vcpkg\installed\x64-windows\include\opencascade -ID:\devtools\vcpkg\installed\x64-windows\share\wxwidgets\..\..\lib\mswu -ID:\devtools\vcpkg\installed\x64-windows\share\wxwidgets\..\..\include -ID:\devtools\vcpkg\installed\x64-windows\tools\python3\include /DWIN32 /D_WINDOWS /W3 /GR  /utf-8 /wd4290 /wd4800 /Zi /bigobj /EHs /MD /Zi /O2 /Ob1 /DNDEBUG /GF /Gy -std:c++14 /showIncludes /Focommon\CMakeFiles\common.dir\build_version.cpp.obj /Fdcommon\CMakeFiles\common.dir\common.pdb /FS -c ..\..\common\build_version.cpp
D:\devtools\vcpkg\installed\x64-windows\include\wx/defs.h(725): fatal error C1083: Cannot open include file: 'stddef.h': No such file or directory
ninja: build stopped: subcommand failed.
Build finished with error(s).

Terminal will be reused by tasks, press any key to close it.

You can see it can't find system headers there. At the same time build works perfectly fine if I just press F7.

Task in tasks.json
        {
            "label": "CMake-build",
            "command": "build",
            "type": "cmake",
            "group": {
                "kind": "build",
                "isDefault": true
            },
            "problemMatcher": []
        }

Build also works perfectly fine if I change
            "command": "build",
            "type": "cmake",

to
            "command": "${command:cmake.build}",
            "type": "shell",

Except the inconsequential warning at the end of the build about not being able to substitute command variable "cmake.build"

If you are using MSVC to build, are you launching VS Code from a "Developer Command Prompt"?  The extension sets up the MSVC build environment for you if you use our "type": "cmake" task or the cmake.build command.  The ${command:cmake.tasksBuildCommand} doesn't do that and you'd need to have the environment already set up.

No I launch vscode from a standard shortcut it creates from installation. I have msvc environment setup manually because the project uses vcpkg and needs other tools both at cmake configure and build time.

The extension sets up the MSVC build environment for you if you use our "type": "cmake" task or the cmake.build command.

Except it doesn't setup include paths or overrides them from what cmake provides as evident from build failure.

The ${command:cmake.tasksBuildCommand} doesn't do that and you'd need to have the environment already set up.

That doesn't work at all, literally can't launch it. https://github.com/microsoft/vscode-cmake-tools/issues/540#issuecomment-961762703

The extension sets up the MSVC build environment for you if you use our "type": "cmake" task or the cmake.build command.

Except it doesn't setup include paths or overrides them from what cmake provides as evident from build failure.

It sounds like my memory was incorrect then.  I thought the cmake task type did that for you.  We should create an issue for that.

The ${command:cmake.tasksBuildCommand} doesn't do that and you'd need to have the environment already set up.

That doesn't work at all, literally can't launch it. #540 (comment)

It works for me (I did test this one), just not when PowerShell is chosen as the terminal.

Fair enough, I opened #2258 for cmake type launch issue.
With the latest update the
 "command": "${command:cmake.tasksBuildCommand}",
 "type": "shell",

configuration now "works" in the sense that it at least launches properly but gives same result as using task type cmake so build still fails.

Just for the record.
Using macOS 13.1, VSCode 1.73.1, CMake Tools 1.12.27, zsh or bash, none of the above is working.
I was happy when found this thread and I was sure that the
command": "${command:cmake.tasksBuildCommand}",
type": "shell",

version will work, but it did not.
These are my issues and tries, at the end the best working current version.
Hope it would help someone to spare a bunch of time whilst strugling with this
"tasks": [
// This should be the first in the task list as it seems, only the first one  is enumerated
// e.g. during default build task selection
{
"label": "CMake: Build (task)",
"detail": "CMake build task",
// Seems CMake Tools extension is bogus here, cannot return the failing task exit code properly
// Failing task will not stop the build that way
//
// "type": "cmake",
// "command": "build",
// "targets": [
// 	"install"
// ],
//
// This replacement is working, but has the disadvantage that not all possible original
// invocation parameters can be passed towards this way
//
//"type": "shell",
//"command": "/Applications/Development/CMake.app/Contents/bin/cmake --build ${command:cmake.buildDirectory} --config ${command:cmake.buildType} --target ${command:cmake.buildTargetName} -j 12 --",

// These are all failing with
// "The terminal process failed to launch: Path to shell executable (...) does not exist."
//
//"type": "process",
//"command": "${input:cmakeTaskBuildCommandNoQuotes}",
//"command": "/Applications/Development/CMake.app/Contents/bin/cmake --build ${command:cmake.buildDirectory} --config ${command:cmake.buildType} --target ${command:cmake.buildTargetName} -j 12 --",
//"command": "/bin/bash -c ${command:cmake.tasksBuildCommand}",
//"command": "/bin/bash -c ''${command:cmake.tasksBuildCommand}''",
//"command": "/bin/bash -c \"${command:cmake.tasksBuildCommand}\"",

// And the winner is...
//
"type": "process",
"command": "/bin/bash",
"args": [
  "-c",
  {
    "value": "${command:cmake.tasksBuildCommand}",
  }
],

For whoever still wonders what the current state of this matter is, this works pretty well for me.
It seems that the CMake Tools plugin now is an official task type, which makes this problem trivial.
tasks.json:
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Build",
            "type": "cmake",
            "command": "build",
            "targets": [
                "ALL_BUILD"
            ],
            "group": "build",
            "problemMatcher": [],
            "detail": "Builds the firmware"
        },
        {
            "label": "Build & run on device",
            "type": "cmake",
            "command": "build",
            "targets": [
                "flash"
            ],
            "group": "build",
            "problemMatcher": [],
            "detail": "Flashes the firmware to target",
        },
    ]
}

@Finomnis I believe this is true, we have default tasks that can be used. I am closing this as resolved, due to the fact that @Finomnis is correct, and since there are many changes/improvements in the extension and I believe this issue is solved now.
If it is not, please create a new issue with new/additional context so that we can investigate and assess. Thanks!
@nico-abram @qu1ck FYI.


dicomWeb application/dicom Accept Header

According to this source https://cloud.google.com/healthcare/docs/how-tos/dicomweb:

When you store a DICOM instance directly, only the application/dicom Accept Header is required.

However the viewer always request multipart/related; type="application/octet-stream", is there an option to configure this?

Does the additional header have a negative impact?

Sorry, I quoted the wrong part. I meant retrieving a study, not storing. The request header send to the server has accept: multipart/related; type="application/octet-stream". Is is possible to accept: application/dicom?

Are you talking about the individual image requests? In that case, it's using octet-stream because we are using WADO-RS RetrieveFrames to pull only the pixel data. The study metadata was previously retrieved via WADO-RS Retrieve Metadata at the Study level.
If you want to retrieve the entire DICOM instance instead, you can switch to using WADO-URI. Just change these two lines to 'wadouri':
https://github.com/OHIF/Viewers/blob/6f4f098671be6c511fc303f52ccd870d6ee340fa/public/config/public_dicomweb.js#L11-L12

Thank you! That was the change I was looking for.


@anangl task_wdt: Fix the way the kernel timer is used

Do not use periodic executions of the timer handler, as in certain
circumstances (the fallback hardware watchdog used, one or more
task_wdt channel activated but none of them being ever fed) this
would lead to no callback/reset being executed for any channel.
Instead, schedule the next timeout from the timer handler function
when the function is executed for the dummy background channel or
for a channel that was deleted.
This fixes #36357.
Use the actual minimum timeout used by the sample for task watchdog
channels (100 ms) as the configuration value for the fallback hardware
watchdog, to avoid unnecessary executions of the timer handler.
Add missing indentation in the documentation of the sample so that
the console output is rendered correctly.

IIRC I set the CONFIG_TASK_WDT_MIN_TIMEOUT to a "bad" value on purpose so that this feature is tested via the sample. But I should have left a comment to explain it.

This feature is anyway tested in this sample, as the control thread is started after one second. Before that time, there is only one channel enabled with timeout set to 1100 ms and the background channel timeout is 100 ms.
I think it is better to not provide such "bad" value in the sample. Users might just copy such configuration into their own applications without being aware that it is suboptimal.


[5.9] [move-only] Temporarily ban deinits on non-copyable enums.

The reason why we are doing this is that:

For non-copyable types, switches are always at +1 for now.
non-copyable enums with deinits cannot be switched upon since that would invalidate the deinit.

So deinits on non-copyable enums are just not useful at this point since you cannot open the enum.
Once we make it so that you can bind a non-copyable enum at +0, we will remove this check.
I added an experimental feature MoveOnlyEnumDeinits so tests that validate the codegen/etc will still work.
rdar://101651138

@swift-ci Please test

@swift-ci Please test Windows


Unfortunately not working with python>=3.10

  ERROR: Could not find a version that satisfies the requirement setuptools>=40.8.0 (from versions: none)
  ERROR: No matching distribution found for setuptools>=40.8.0

I am working on python 3.11. I assume that it is not working with this python version - a pitty. Would have been exactley what I was looking for.
Best,
Barbara

Seems like one of your enviroment's package has a wrong dep declare, try to install Pynecone again with a virtual enviroment.
I use Python 3.10 and it seems to be normal.

PyWebIO works with py3.11
Try run python3 -m pip install --upgrade pip setuptools wheel brfore install pywebio?
Or install pywebio in a new python venv

Thanks for your answer. I installed it on Windows (python 3.9), and it worked. But then again, I tried to install with new environment in Linux (python 3.9) and I get an error. Similar to the one with python 3.11 before:
'''
Creating environment...
Upgrading pip...
Collecting pip
Using cached pip-23.0-py3-none-any.whl (2.1 MB)
Collecting setuptools
Using cached setuptools-67.2.0-py3-none-any.whl (1.1 MB)
Collecting wheel
Using cached wheel-0.38.4-py3-none-any.whl (36 kB)
Installing collected packages: pip, setuptools, wheel
Attempting uninstall: pip
Found existing installation: pip 20.2.4
Uninstalling pip-20.2.4:
Successfully uninstalled pip-20.2.4
Attempting uninstall: setuptools
Found existing installation: setuptools 50.3.2
Uninstalling setuptools-50.3.2:
Successfully uninstalled setuptools-50.3.2
Successfully installed pip-23.0 setuptools-67.2.0 wheel-0.38.4
Installing requirements...
Collecting pywebio
Using cached pywebio-1.7.1.tar.gz (471 kB)
Installing build dependencies ... error
error: subprocess-exited-with-error
× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> [7 lines of output]
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f1e3da009a0>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /simple/setuptools/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f1e3da00190>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /simple/setuptools/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f1e3da00f10>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /simple/setuptools/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f1e3da262b0>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /simple/setuptools/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f1e3da26460>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /simple/setuptools/
ERROR: Could not find a version that satisfies the requirement setuptools>=40.8.0 (from versions: none)
ERROR: No matching distribution found for setuptools>=40.8.0
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
'''
Do you know what could be wrong?
Thanks again.
By the way, I tested it on Windows - it's very cool. Hopefully, I can get it working on Linux as well...

Solved my problem by installing separately as first package and not with the requirements.txt.


do.sh: Add ability to run ovn-heater on Ubuntu

Please review commit-by-commit.
This is a follow-up change after ovn-fake-multinode added support for ubuntu-baed builds (https://github.com/ovn-org/ovn-fake-multinode/pull/85)

This change should clear out the failing CI: https://github.com/ovn-org/ovn-fake-multinode/pull/87

This change should clear out the failing CI: ovn-org/ovn-fake-multinode#87

Ack, I triggered a retry of the CI after merging the ovn-fake-multinode PR.


App breaking when using Enum as field for Generic

When using an Enum as a field on a Generic, the app breaks, throwing a NotImplementedError.

Describe the Bug
The below code is an example of the error.
from enum import Enum
from typing import Generic, Optional, TypeVar

import strawberry

T = TypeVar("T")

@strawberry.enum
class EstimatedValueEnum(Enum):
    test = "test"
    testtest = "testtest"

@strawberry.type
class EstimatedValue(Generic[T]):
    value: T
    type: EstimatedValueEnum

@strawberry.type
class Query:
    id_translations: Optional[EstimatedValue[int]]

schema = strawberry.Schema(query=Query)

Are we doing something wrong and this is intended or is this a bug?

System Information

Operating system: Docker
Strawberry version (if applicable): Since 0.149.2

Hi @iamkhav this is a bug! I'll try to make a fix for it soon :)

Thanks a lot @patrick91 🙏


Bug: Run seata example failed in 2022.x!

Which Component
spring-cloud-alibaba-example/seata-example
Describe the bug
When I started the account and other four applications, the system registered successfully, but when I called the business-service interface, I found that the call failed.
Interface return
Administrator@yuluo-laptop MINGW64 /d/open_sources/sca2022/2022 (1202/yuluo-feat—t-update-seata)
$ curl http://<IP_ADDRESS>:18081/seata/feign
{"timestamp":"2023-12-02T07:30:30.981+00:00","status":500,"error":"Internal Server Error","path":"/seata/feign"}
Administrator@yuluo-laptop MINGW64 /d/open_sources/sca2022/2022 (1202/yuluo-feat—t-update-seata)
$ curl http://<IP_ADDRESS>:18081/seata/rest
{"timestamp":"2023-12-02T07:31:12.819+00:00","status":500,"error":"Internal Server Error","path":"/seata/rest"}

logs
2023-12-02T15:56:57.735+08:00  INFO 5844 --- [5)-<IP_ADDRESS>] o.s.web.servlet.DispatcherServlet        : Completed initialization in 1 ms
2023-12-02T15:57:55.494+08:00 ERROR 5844 --- [eoutChecker_1_1] i.s.c.r.netty.NettyClientChannelManager  : no available service endpoint found in cluster 'default', please make sure registry config correct and keep your seata-server is running
2023-12-02T15:57:55.760+08:00 ERROR 5844 --- [eoutChecker_2_1] i.s.c.r.netty.NettyClientChannelManager  : no available service endpoint found in cluster 'default', please make sure registry config correct and keep your seata-server is running
2023-12-02T15:58:05.495+08:00 ERROR 5844 --- [eoutChecker_1_1] i.s.c.r.netty.NettyClientChannelManager  : no available service endpoint found in cluster 'default', please make sure registry config correct and keep your seata-server is running
2023-12-02T15:58:05.764+08:00 ERROR 5844 --- [eoutChecker_2_1] i.s.c.r.netty.NettyClientChannelManager  : no available service endpoint found in cluster 'default', please make sure registry config correct and keep your seata-server is running

Simplest demo
The URL of the simplest demo to reproduce the problem.
Expected behavior
Refer to readme documentation
Screenshots
nacos

seata

Additional context

windows
jdk17
SCA 2022

When I start the Seata-Server that comes with the sample project, the interface can be accessed normally and the service runs normally.
However, the current Seata version has been updated to 1.8.0. This should be adjusted. Please assign it to me. I am targeting Conduct research and research on this content.

For #3502

@ruansheng8.  cc @chickenlj


[Autocomplete] Render endAdornment only when necessary

Signed-off-by: Yue Yang<EMAIL_ADDRESS>

[x] I have followed (at least) the PR section of the contributing guide.

As the title. If there has no hasClearIcon or hasPopupIcon specified, its no need to render the endAdornment.

Changes makes sense to me. Please add a test case for this new behavior.

Got it. I will add it soon.

@mnajdova Already added. Most of the cases where endAdornment isn't rendered are when freeSolo is defined, so I only added the test under prop: freeSolo.
PTAL when you're free. 😃

@g1eny0ung  It's a great first pull request on MUI 👌🏻. Thank you for working on it!

@ZeeshanTamboli It's my pleasure. Thanks for your careful correction! 😃


Idp SignOut

Hi,
oidc-js calls the endsession endpoint on logout, so the user get's not only logged out at the client, but also the identityprovider. The logout in oidc-react only logs out at the client (removes auth data from session storage).
I could not find a way of doing the full signout at the identityprovider - is there one? Or could you add it? The UserManager. signoutRedirect() in oidc-js will execute the idp signout redirect, I believe.
ref Angular sample

Hello,
Thanks for the issue! This is a feature we really need – you are right! Maybe you want to propose a pull request?

This has been solved with the great help of @lclc98 in #48. I'm going to publish this very soon!

Nice! Thanks for the heads up :) And thanks to @lclc98 for the implementation 👏


Fix terraform warnings/errors during E2E runs

Don't initialize firebase if running E2E tests
Check for left over gke-sa service account

Was able to find the command to check if firestore exists:
gcloud alpha firestore databases list

/e2e-test


update issues routing and home page

Resolve #144

Fixed issues with routing where navigating to the login page and other pages required a refresh and displayed
"Page Not Found."

They corrected the layout issue, which caused images and content on the landing/home page to be hidden behind the top bar.

sorry about that some issues in this branch so I created a new branch, today's network issue in my location so the code is corrupted the node is not starting while pushing my code sorry about that


Correct case of assertSame

Found this since I've got this hhi file so that I can have everything in xhp-foundation as strict.

Cool - any plans to split that HHI to another repository?

Have now: https://packagist.org/packages/91carriage/phpunit-hhi
Will get around to mirroring to GitHub at some point to make contributing easier.


Create journal dict for refextract

Move the kb file creation in a cronjob to hep https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/refextract/tasks.py#L35
TECH
On hep create a functioncreate_journal_dict which will:

Create a query which will gather all journal titles and short titles from db. The query should use SQLAlchemy ORM and the content should be the same as in this queries.
Use gathered data to populate dict as in here.
Return the dict.

Legacy approach of passing input via file is inefficient and unnecessary in this case. So we should just modify refextract API to accept the input simply as a function param. In this way, we don't need to deal with writing file over the network and scheduling a cron job etc.

That should work well. The task to write the journal KB to disk is fast (<1s for the whole task) so we should be able to do the request on the fly and pass the data to refextract. If we use the SQLAlchemy ORM instead of the handwritten requests in https://github.com/inspirehep/inspire-next/blob/11dcad6d3ecf6f5b5457b1af014121c73c1dcc3e/inspirehep/modules/refextract/tasks.py#L51-L69, we should get caching at the SQLAlchemy session level (so a new query in the same session won't hit the DB).

We need pass not a dict but a list of dict that is similar to below right? @michamos
[{ short_title, journal_title, title_variant }]

Also what I don't get from this task is that we just port the function from next and that's it? Not even use it anywhere yet?

no, you need to pass a dict, that maps all possible values in all journals as follows:

short_title -> short_title
journal_title -> short_title
title_variant -> short_title
This is what's happening in https://github.com/inspirehep/inspire-next/blob/5120677b03611764c4f9d2ea0087f60cd41b93a2/inspirehep/modules/refextract/tasks.py#L73-L86 (but using a python dict rather than the special writer).
The problem with a list is that ordering is relevant for equality, so you would need to sort it first, which is not really efficient.

The function needs to be called every time you call the refextract API. So currently only in the editor views (extract_references_from_string, extract_references_from_url).

There is no mention of caching here? Is it a plan for after?

caching is implemented inside refextract, the caller doesn't have to know about it, I'm just giving a bit more context here.


unit test: fix newInstanceManager

Which issue(s) this PR fixes:

Issue https://github.com/longhorn/longhorn/issues/8658
What this PR does / why we need it:
The TestCleanupRedundantInstanceManagers test fails due to a hard-coded and incorrect instance manager image. This issue surfaces after the introduction of the feature in commit 7b3521b6b9086d0a0b14b8da2621cc7b626f02d6.
Special notes for your reviewer:
Additional documentation or context

LGTM Just one question: we still have two instance managers when doing the s.controller.diskMonitor.RunOnce(), right? And I assume in the real case we won't have two instance managers with the same instance manager image.

The two IMs have different images.

@Mergify backport v1.6.x


Release builds

Not everyone has access to an android development environment.

Didn't he say he wasn't ready to put out a release yet?
I think he said he didn't want to deal with too many feature requests and bugs until a basic functioning app was completed

My bad, ignore this in that case.

Yes, please be patient. I don't think it will take too long for the first release.

Thanks for the update!


HOT_WATER -> OFF

is there an option to set HOT_WATER to 0 while toggled off? i played with the temp lowering down to 30 degrees which works but usually the WATER system can be set to OFF during a timeframe at night. Would be interessting to see the "OFF" valve in the chart as well.

[2022-01-09T15:08:20Z INFO  tado_exporter::tado::metrics] -> HOT_WATER -> setting temperature (celsius): 30
[2022-01-09T15:08:20Z INFO  tado_exporter::tado::metrics] -> HOT_WATER -> setting temperature (fahrenheit): 86

Would also like this for room temperatures. At present, it looks like the tado API just returns a "null" value along with an additional power: "OFF", attribute.


Change Data Capture (CDC) support

Does YDB support CDC or any other mechanism to stream data changes to Kafka, etc.?

The feature is now available as part of the 22-4 stable release. Please visit https://ydb.tech/en/docs/concepts/cdc for details.
Events are written to a topic:
https://ydb.tech/en/docs/concepts/topic (concepts)
https://ydb.tech/en/docs/reference/ydb-cli/topic-overview (CLI)
https://ydb.tech/en/docs/reference/ydb-sdk/topic (Go SDK)


Hide whitespace in comparisons

Similar to GitHub's (AFAIK) new option in comparisons (e.g. pull requests), Gogs should be able to hide the whitespace when doing comparisons (and of course to show it).
There should be a switch in the comparison view.

Sorry, what option are you referring to? I do not think GitHub has this.

It is quite hidden, I admit. :smile:

I have never seen this option and still dont see it on any github page I go to.  I know that there is a parameter that can be passed to do this (?w=1) Github Secrets  but this must be new if it is actually showing up in the ui

You can see it in PRs (file difference). Now it shows up as a button. (the screenshot I used here is a bit outdated)


[Flink-14953][formats] use table type to build parquet FilterPredicate

What is the purpose of the change
Fix the FilterPredicate built from using type inferred from literal to using table column type
Brief change log

Use table column type to build predicate pair
Do a special conversion for an expression whose column type is long but its literal type is an integer.

Verifying this change
It is tested in ParquetTableSourceITCase
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@KurtYoung @fhueske I think you have the context of the PR. Would you please take a look the fix?

@JingsongLi Thanks for the feedback. I changed accordingly. Please take one more round of look.

ping @KurtYoung


Adding codeowners to every chart

I don't think it's necessary to bump all these versions for this change. @davekonopka if you agree, we can administrator merge


STDERR: start: Job failed to start with docker 1.10.0

I am receiving errors on all my converges with this cookbook (at least on Ubuntu):
 Mixlib::ShellOut::ShellCommandFailed
    ------------------------------------
    Expected process to exit with [0], but received '1'
    ---- Begin output of /sbin/start docker ----
    STDOUT:
    STDERR: start: Job failed to start
    ---- End output of /sbin/start docker ----
    Ran /sbin/start docker returned 1

...
   [2016-02-09T20:33:32+00:00] ERROR:
docker_service[default] (docker_hubot::default line 14) had an error: Mixlib::ShellOut::ShellCommandFailed:
docker_service_manager_upstart[default] (/tmp/kitchen/cookbooks/docker/libraries/docker_service.rb line 64) had an error: Mixlib::ShellOut::ShellCommandFailed:
service[docker] (/tmp/kitchen/cookbooks/docker/libraries/docker_service_manager_upstart.rb line 29) had an error: Mixlib::ShellOut::ShellCommandFailed:
Expected process to exit with [0], but received '1'

I believe I tracked this down by comparing a the /etc/init/docker.conf from a vanilla ubuntu install and the file produced from this cookbook.
https://gist.github.com/aaronblythe/d6fea532bb9d90329659
This cookbook:
exec /usr/bin/docker -d --pidfile=/var/run/docker.pid >> /var/log/docker.log

Vanilla Ubuntu/Docker installed VM:
exec "$DOCKER" daemon $DOCKER_OPTS

If I understand correctly, the docker -d option has been deprecated since 1.8 and possibly was removed at 1.10.0.  https://github.com/docker/docker/wiki/Engine-v1.10.0-content-addressability-migration

Docker ships a sample upstart config at https://github.com/docker/docker/blob/v1.10.0/contrib/init/upstart/docker.conf

This actually may have been from a Berksfile.lock in my cookbook that was constraining the version a couple back on this cookbook as a dependency.  Feel free to close this, I believe I am around this issue.

I reproduced this when updating the inspecs for upstart. Marking as a bug.


Design Read-behind cache for FX and Routing table entries

These two operations can be expensive, so we want to use cached values for serving actual ILP packet flows, and re-load the cache in the background so as not to block the packet-flow.

Closing this for now - before we work on a caching solution here, let's make sure we need the perf gain.


[4.x] Make TenantDump work when called outside the tenant context

Calling the TenantDump command outside the tenant context (e.g., artisan tenants:dump --tenant=acme in the terminal) dumps the central database. This happens because the command doesn't run the parent as the tenant passed in the --tenant option.
This PR fixes the problem by moving the command's parent::handle() call inside $tenants->run().

Why did it work in tinker? Even without the $tenant->run()

Codecov Report

Merging #1015 (5499d1d) into master (9520cbc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1015   +/-   ##
=========================================
  Coverage     87.79%   87.79%
  Complexity      531      531
=========================================
  Files           130      130
  Lines          1475     1475
=========================================
  Hits           1295     1295
  Misses          180      180

Impacted Files
Coverage Δ

src/Commands/TenantDump.php
80.95% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Why did it work in tinker? Even without the $tenant->run()

Did it work for you @stancl? For me, it only works in tinker with tenancy()->initialize() or $tenant->run()

I haven't tested it, but from the title when called using the terminal I assumed it does work? I mostly meant to say artisan though, not tinker.
And if we have tests for this, and they're properly written (i.e. context shouldn't be tenant when we're running commands like these), then I'd assume it works well in CLI?
Or does the artisan command work now, but it doesn't work in tinker or when called from an app?

I haven't tested it, but from the title when called using the terminal I assumed it does work

I see. I renamed the PR

Or does the artisan command work now, but it doesn't work in tinker or when called from an app?

The command works correctly when called in the tenant context, but outside the tenant context, it dumps the central DB schema which shouldn't be happening.

if we have tests for this, and they're properly written (i.e. context shouldn't be tenant when we're running commands like these)

I just checked this, and in the tests, the command is called in the tenant context. I'll update the tests in his PR as well then


Enterprise components section

Think about a section for universal enterprise components.
Example: PayPal, stripe, etc

Example https://itch.io/docs/api/javascript

GitHub sponsor button https://buttons.github.io/


Fix grpc port by configure via url

I've noticed that when configuring Qdrant endpoint via URL it does not set grpc_port so I've made a simple change.

Hi @ainyava
Thank you for the contribution!
However, I don't think we'll be able to merge it:
Using both grpc and rest simultaneously is a valid case (and we can't assign the same port for two interfaces)
grpc interface does not implement some of the snapshots/shards/storage methods, and the rest one is used in that case

Oh I didn't know about that, how ever I think its kind of misleading that we cant use URL and host/port params at the same time while its not clear that how to configure both protocols separately
The real problem we're facing is:
We have Qdrant on Kubernetes and have access to it using Ingress (through port 443) so we need to configure separate endpoints (because our Ingress controller adds some annotation for gRPC) so we need to configure port and hostnames gor HTTP/gRPC separately.
I would appreciate some suggestions on how to resolve this in a clear manner, also If its needed to change the source code,
It would be a great pleasure for me to do so.
Thanks, Ainyava


Error assigning variable

This writing doesn't work

Error: TypeError: t is not a function

Fixed


Add templates

Only change I made was that GitHub was suggesting to make issues templates in the ISSUE_TEMPLATE folder.

left a few things out of HOWTOCONTRIBUTE.rst and will add back in once those PR's go in.

closing in favor of #97

also the use of setuptools for dirty tags in between official releases


MINIFICPP-1203 - Remove obsolate distinction between headers and sources when running linter checks

This PR will be flagged for Work in progress, until all the relevant linter errors are accounted for.
This serves as the base for all the linter-related errors PR, so preliminary reviews are very welcome.

Closing this as https://github.com/apache/nifi-minifi-cpp/pull/1069 will be merged instead.


Configure 'Similar Manga' Update Period

There is currently no option to change when the app redownloads the 20 MB file. I infrequently add new manga so it doesn't make sense to redownload it every 24 hours in my case.
Weekly/Monthly would probably be enough for most users.

not configurable but is now 3 days later.  Will reevaluate at a future date if it should be longer

3 days is still pretty excessive for a 20 MB payload.

This has been updated with more options


Show action & state rather than action or state

Partial of #16

This issue has been resolved in v1.8.8-thermostat.0


Fix bug during transform of CredDef and SchemaAPI

Not sure why this was working before some updates in the pom 🤷♂ . Also noticed that I had to add annotation to my enumerated types in models... that was also working previously.
Signed-off-by: Jason Sherman<EMAIL_ADDRESS>

I'm not up on this work, but it did resolve the issue i observed.


Update Get-PowerBIDataflow.md

Fixed typo

Docs Build status updates of commit a313590:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-ps/MicrosoftPowerBIMgmt.Data/Get-PowerBIDataflow.md
:white_check_mark:Succeeded
View (powerbi-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


How to Configure the gap in OR-tools Routing library

is there a way that i can set the gap of the pywrapcp.RoutingModel() in python, so that the solving process will terminate when a certain gap is reached (for example, something like model.setParam(GRB.Param.MIPGap, 0.50) in Gurobi).

THis makes no sense.
The routing library does not use GUrobi, and is not based on a MIP solver.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le sam. 14 déc. 2019 à 12:31, Adnanay<EMAIL_ADDRESS>a écrit :

is there a way that i can set the gap of the pywrapcp.RoutingModel() in
python, so that the solving proccess will terminate when a certen gap is
reached (for example, somethhing like model.setParam(GRB.Param.MIPGap,
0.50) in Gurobi).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1783?email_source=notifications&email_token=ACUPL3OSFZUUINIJT6ZWZZLQYS7XNA5CNFSM4J22DT6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IAPXR6A,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3PPTMQMF3OPMHH57C3QYS7XNANCNFSM4J22DT6A
.


importing the images

When we try to activate images using this tool. Its always importing as suse/. Is there any option to import custom images with the different names like abc/xyz.

Not really, but it should be easy to add.

Can you elaborate more on the use case for this request? Right not sle2docker can activate only the images that SUSE builds and ships as RPMs.
Do you plan to ship your docker images as RPMs too, that would be a bit strange to me 😄

Actually we have not finalized the approach. some of our customer will have access to internet in the production server, so we are planing to ship images as rpm's.  Let me know if there any option to import images build using "containment-rpm-docker".


upper bound and larger bound inconsistent with step sign

upper bound and larger bound inconsistent with step sign

Could you give more details please? Closing for now ...


Feature: Add PDF signature information

The SignatureUtil class defines constants (map keys for the result map) and generic functions that don't refer to a specific PDF framework
PDFBoxSignatureUtil inherits from this base class and adds functionality for the specific PDFBox use case. To use the documentplatform, a analog class that inherits from SignatureUtil will be created.

Können wir dann mergen?


Added golden files and test for schema2kotlin and schema2cpp

Adds a test for the C++ and Kotlin generated schema code. This test checks that the output matches the expected golden file.
This has a couple of key benefits:

It should help catch accidental changes to the generated code.
It will make it easier to review changes to the code generator (you'll have a nice diff of the changes you can easily review)
The golden files serve as a useful reference for what the generated code looks like.

Copybara error fixed in cl/288828612

With this change, should we get rid of the sample .h and .kt schema2kt files?

Done in https://github.com/PolymerLabs/arcs/pull/4401


Incompatible with Uglifyjs

Issue
Cannot be built for production with Uglify enabled.
Expected
Works with Uglify
Reproduce
$ vue init webpack-simple vue-webpack-simple
$ cd vue-webpack-simple
$ npm install
$ npm install --save-dev vue-transmit

Add vue-transmit to src/main.js
import VueTransmit from 'vue-transmit'
Vue.use(VueTransmit)

Build
$ npm run build
ERROR in build.js from UglifyJs
Unexpected token: name (t) [./~/vue-transmit/dist/vue-transmit.esm.min.js:1,1289][build.js:96,1293]

It seems like Uglify works with es5 syntax only, I tried to just use presets: ["es2015"] (same as Vue) and it works

A couple things here:

Basically yes, uglify is still stuck at es5 compatibility.
If you're using es6 in your project, you'll pull the es module version of the lib. My bundling preset may leave a lot of the es6 syntax in the output (like object shorthands), but I've compiled most of the language features to es5 (minus certain built-ins on the Array prototype).

I recommend using babel-minify-webpack-plugin for es6 minification. The downside to using uglify and an es5 preset is that your target demographic may not require that much transpilation.

Thanks for the reply.
Since vue init webpack and Laravel  use uglify for production by default, are you sure it's ok to drop support for those community?

This library is intended to be a modern JS library that takes full advantage of ES2015/ES6. The support for modern JS across browsers is excellent, and only getting better. I use the babel present env, and due to the current level of browser support, much of the ES2015 syntax makes it into the final build.
I see UglifyJS' lack of support for ES2015 as a problem, and a burden I don't intend to take on. They have a pretty impressive amount of optimizations, so I certainly sympathize with the sheer effort to get up to speed with ES2015, but if they don't catch up soon, other projects will start switching their minifier.
I think the best answer for this project is to include a fully ES5 build. That isn't my personal recommendation because it doesn't yield the best results (for size and optimizations), but I think it's a good workaround.

Try upgrading to v5.3.0 and use the commonjs bundle. Let me know if this passes through UglifyJS 👌
import VueTransmit from "vue-transmit/dist/vue-transmit.common.min.js"
Vue.use(VueTransmit)

The same. Uglify can't recognize such as const, let and { foo() {} } etc.

Working on getting babel to obey the config. Isn't transpiling let|const no matter what I throw at it.

Alright, I believe I've corrected everything. It turns out I need to indicate babelrc:false in the webpack config. I believe you've helped correct the builds for each target, so thank you for bringing this to my attention!
Go ahead and upgrade to v5.3.1 and tell me how she does.

Many thanks. 5.3.2 works for me.
PS: babel-minify-webpack-plugin works too 👍

Sorry for that! Check out 7.1.2 and see if that works for you. It looks like I missed the entry point file when I worked on 6.0 on.

Wow that was quick!
Looks good!  Thank you!  :+1:

Awesome! I use this in production, so this might have been affecting some of my users on older browsers!


Revert "Preserve event timestamps in X11 input driver"

Reverts etternagame/etterna#643
Pending conclusion of: #655
If merged, reopen #642

Can you do a hotfix release with this included? It breaks input on multiple machines I've tried running different Linux distros

Yeah if more than 1 person could confirm that it causes this issue.

This can be closed


remove superfluous references to enclosing classes

Thanks for the contribution. This should be reviewed carefully, because even if some static classes can be replaced with static inner ones, in case of non private ones at least it is a binary breaking change.

Though minor changes to protected and package private classes (none to public) were introduced behavioral compatibility was preserved.

Actually those changes preserve binary compatibility.
None of the changed inner classes used any outer classes' instance methods or properties, so no linking errors are possible.


Goto on scroll

Hello,
This is rather a question than a bug report. Is it possible to go to prev or next slide when the user scrolls above the slider? I have no idea where to start, any idea welcome!
Thanks a lot,
François

Listen for scroll event (want to debounce), test for condition, use the slickNext/slickPrev methods to trigger a slide scroll. Hope that helps.
Closing: Support Request


Implement request-response for in-memory transport provider

Currently the in-memory transport provider does not support request-response communication.
We need to implement that.

Req/Resp are now supported on the memory transport since version:
https://www.nuget.org/packages/SlimMessageBus.Host.Memory/1.4.2


Github sign in button not working

Describe the bug
I went to sign up and wanted to sign in with Github. The button to sign in with Github does not seem to be working. I dug into the code and it looks like const { currentUser, signin, signInWithGithub } = useAuth() the signInWithGithub does not seem to exist.
To Reproduce
Steps to reproduce the behavior:

Go to http://localhost:3000/sign-up?accountType=candidate
Click on Sign in with Github
Nothing happens

Expected behavior
I expect to be sign in with my Github account.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version

Additional context
Add any other context about the problem here.

I have some time this week I could build this out. @drewclem

I'd be open to working on this or enhancing it later on. Since Firebase is being used for the project, I suggest taking a look at the FirebaseUI they offer.
https://firebase.google.com/docs/auth/web/firebaseui
I have implemented the FirebaseUI for past projects. If you are open to this I can build it along with other platforms for a user to sign in with (Twitter, Google).

When creating an account via GitHub, we'll need to ensure the same documents for a regular sign up are created.
Also note that GitHub sign in will only be available for candidates, not companies, as companies typically do not have a GitHub account, usually just GitHub organizations.
Let me know if I missed anything @drewclem.

For the actual GitHub signin, would you be open to authenticating with Firebase like this?
var provider = new firebase.auth.GithubAuthProvider();
https://firebase.google.com/docs/auth/web/github-auth

This makes sense to me, or are there any reservations to using Firebase's GitHub auth provider @drewclem, @sethburtonhall, @clandau?

This makes sense to me, or are there any reservations to using Firebase's GitHub auth provider @drewclem, @sethburtonhall, @clandau?

None here, I think it's a good idea to use Firebase auth.