Fix Leak in ReplicateBlob

This PR would fix a memory in ReplicateBlob request.
In ReplicateBlobRequest, ambry-server would issue GetRequest to remote host and get a GetResponse back. After that, ambry-server would go through a transformer to transform PutBlob. In BlobIdTransformer, we would increase the ref counter for the GetResponse's InputStream when it detects that the InputStream is a NettyByteBufDataInputStream. We didn't decrease the counter any where so there is a memory leak.
This PR fixes that, by creating a new InputStream and pass this new InputStream to transformer. Since this new InputStream is not a NettyByteBufDataInputStream, the ref counter is not going to be increased. Thus, we don't have memory leak issue.

Codecov Report
Base: 73.08% // Head: 14.89% // Decreases project coverage by -58.19% :warning:

Coverage data is based on head (a573559) compared to base (9fb8017).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2306       +/-   ##
=============================================
- Coverage     73.08%   14.89%   -58.20%
+ Complexity    10463     2363     -8100
=============================================
  Files           753      753
  Lines         57859    57860        +1
  Branches       7107     7107
=============================================
- Hits          42289     8619    -33670
- Misses        13232    48722    +35490
+ Partials       2338      519     -1819

Impacted Files
Coverage Δ

...ambry/messageformat/MessageSievingInputStream.java
0.00% <0.00%> (-84.80%)
:arrow_down:

.../src/main/java/com/github/ambry/router/Router.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/com/github/ambry/store/Message.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/named/PutResult.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaName.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/rest/RestMethod.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/KMSConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/SSLConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/router/ByteRange.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 590 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


stream: RX thread - separate thread safe receiver

rtp: make rtcp_mux atomic
Title has to be equal to the baresip PR: https://github.com/baresip/baresip/pull/2454

Does an atomic bool solve the clang sanitizer warning? I try first to verify this.

regarding the whitespace, the current patch is a bit difficult to read, because it contains relevant parts
and unrelated parts. It is not so important, but please try to make the patch readable.
Regarding thread-safety I think that a struct class should either be not thread-safe or fully thread-safe.
A good example is the class "aubuf" which is fully thread-safe.
It is difficult for a user of the RTP class to know if it is thread-safe or not.
This should be stated in the doxygen comments.

It is difficult for a user of the RTP class to know if it is thread-safe or not. This should be stated in the doxygen comments.

Right! I'll check the alternatives:

making rtp_sock thread safe vs
solve the rtcp_mux problem in baresip

I came to the conclusion that it makes less sense to make rtp_sock thread safe. Because:

It's used for receiving and sending. e.g. enc only for encoding/sending
The lock should not be hold while the handlers are called.
The only field that may change while data is received is rtcp_mux.


[bug] [Furnace Speed] Stardew Furnaces SHOULD only be left click. also it  spits items out opposite side to player

THis config option under player area. when you punch a furnace it should spit out the resulting slot towards teh player.  also it should only do it on right click, but it goes opposite.
Also maybe add sounds too?

Fixed in release 1.3.3
http://minecraft.curseforge.com/projects/cyclic/files/2314001


Can't view Brainfuck scores

The current URL scheme can't handle a lang and a hole being the same: https://code-golf.io/scores/brainfuck
Possible solution would be to rename the hole to "Brainfuck Interpreter/Compiler/etc", bit wordy though, or come up with a new URL scheme.

Checked, valid issue.

I'm leaning towards
/scores/:hole/:lang
with "all-foo" being valid, e.g.
/scores/all-holes/brainfuck
/scores/brainfuck/all-langs
/scores/brainfuck/brainfuck
This'll probably make the routing simpler since there will always two params.

I think the pragmatic thing to do is rename the challenge "Brainfuck Interpreter." That's probably what it should have been named anyway, and had it been, this wouldn't have been an issue. I also think it's highly unlikely that there will ever be another conflict between language and challenge name.

My only concern with that @primo-ppcg is what if someone wants to solve the hole by writing an AoT compiler instead ;-)
But in all seriousness I quite like keeping the hole names pithy, I'm pretty much onboard with making the above changes to the URLs, just finding tuits.

But I shall fix this bug pronto, if for no other reason that it'll let me post to https://www.reddit.com/r/brainfuck/ ;-)


Folders: Archive V1 (Hide from view/show hidden)

Rationale
We now support marking a child folder as "archived" in the apps. Archived folders in app will be excluded from certain actions in app and also will have special visual indicators.
Related Pull Requests

https://github.com/LabKey/labkey-api-js/pull/185
https://github.com/LabKey/labkey-ui-components/pull/1618
https://github.com/LabKey/labkey-ui-premium/pull/573
https://github.com/LabKey/platform/pull/5982
https://github.com/LabKey/limsModules/pull/858

Changes

Add new Container.LockState.Archived
util to setting a container to archived / no archived
add metrics for archived containers

Tagging @labkey-adam for review in case there is a concern with re-purposing container.lockstate for marking a container as archived.

Tagging @labkey-adam for review in case there is a concern with re-purposing container.lockstate for marking a container as archived.

The existing "lock states" apply only to projects. Does "archived" apply only to folders? If so, then I don't see a conflict or concern.

Tagging @labkey-adam for review in case there is a concern with re-purposing container.lockstate for marking a container as archived.

The existing "lock states" apply only to projects. Does "archived" apply only to folders? If so, then I don't see a conflict or concern.

Yes, currently we only support archiving a child folder. Thanks for the feedback.


Test latest PHP versions

Update .travis.yml

Closing in favour of https://github.com/crysalead/dir/commit/0390ac74a8f1634b1ec1adffdd118125f1271976


GlobalSection(TeamFoundationVersionControl) doesn't always has solution SccLocalPath in index 0

The HandleVersionControlLines function in the SolutionFileReader uses the Regex ms_regexParseVersionControlName, which implicitly assumes that the SccLocalPath0 always holds the SccLocalPath for the solution itself. However, our VS2010 has put the solution's SccLocalPath at the bottom, resulting in the exeption "Missing property 'SccProjectUniqueName' for the element #{0} in the global section '{1}'.\nFound: Nothing.\nExpected: A property with the name 'SccProjectUniqueName{0}'." for that SccLocalPath. along with it, it won't read the first project (index 0), because the Regex doesn't match that at all. Attached solution was created by VS2010 after re-binding the solution to source control.
Attachments
IHCProducts.sln
This work item was migrated from CodePlex
CodePlex work item ID: '6355'
Vote count: '1'

[UnknownUser@3/22/2012]
Resolved with changeset 68569.

[UnknownUser@2/14/2013]

[UnknownUser@5/16/2013]


Windows 11 - Smart App Control

Windows 11 introduced Smart App Control. One of the security checks for apps is ensuring that the app and its binaries are signed. Because DryIoc does not sign its binaries, software using it will be blocked from running when Smart App Control is enabled.
Please sign DLLs produced for DryIoc.
https://support.microsoft.com/en-us/topic/what-is-smart-app-control-285ea03d-fa88-4d56-882e-6698afdb7003
DryIoc (unsigned):

Microsoft dll (signed):

zomby returns, ok...

@hathawcs Ok, I did not check it first, but you have an old version of DryIoc (v4.1.4)
The newer versions are signed with by the https://github.com/dadhi/DryIoc/blob/master/DryIoc.snk
You may manually sign the old assemblies using this file via https://learn.microsoft.com/en-us/dotnet/framework/tools/signtool-exe or https://learn.microsoft.com/en-us/dotnet/framework/tools/sn-exe-strong-name-tool or any other OSS tool.


Problems of code and testcases while evaling

Hello, thank you for you great job!

Which Testcases dataset do you use?
I found that there are some code can't pass all testcases when I test by myself, and most of this because of code problems.(eg. 440th src_code  in test.jsonl have an uninitialized error.). What's more, I had more problems when I used [Merged test cases] datasets than when I used [Public test cases] datasets.
Thank you for your excellent work again!

The test.jsonl file here  has a column named tests which has the indices of the tests to be used.
Here's an example of using these tests for eval in the code

I found that there are some code can't pass all testcases when I test by myself, and most of this because of code problems.(eg. 440th src_code in test.jsonl have an uninitialized error.). What's more, I had more problems when I used [Merged test cases] datasets than when I used [Public test cases] datasets.

Yes, perhaps if you're not using the right test cases, you may encounter errors.


A script to collect fybrik information using kubectl

Added an initial bash script, which saves in a local directory the logs from fybrik namespaces, and sorts them by timestamps and possibly by a given fybrikapplication UID. It saves only logs from the last hour and from pods on namespaces that contain the word "fybrik". Also saves the applied configmaps.
An example for the output of running from root:
./hack/save-logs-files.sh 49c8f461-c204-4e10-9ff7-7c071c23f8af
The created directory:
fybrik_logs_2023-03-06_11-06_last_1h.zip
Without passing the UID to the script, the created directory is identical but without the file combined_logs_sorted_onlyuid.txt.
Open questions / ideas that could be added:

Automatically detect all running fybrikapplications and create a separate log file for each one, instead of passing an argument.
Automatically detect and list which modules are deployed.
Automatically detect and list which policy files are applied.
Where to add documentation on the script and its usage? Is it for developers or users?
Accept an argument / flag of additional namespaces to collect the logs from.
Accept a flag for the time limit, instead of the currently hardcoded 1h (one hour).

Closes #568

Hi @Vicky-Goldin if your PR is ready to review, please mark it.

Closing this PR due to misuse of git commands, continuing on a new branch with a new PR: #2039


GUI: display fee-rate in Transactions and PSBTs screens

Currently only the absolute fee is shown, also displaying (while hovering or next to the fee) the fee-rate in sats/vbytes would be useful.
I got annoyed by a tx that wasn't getting mined, and I would like to know how far off i'm in terms of fee-rate.

In order to determine the fee rate for PSBTs, would the idea be to estimate the total transaction size once all inputs have been signed, e.g. using the descriptor's max satisfaction size? A similar thing is done when creating a new spend and estimating the amount left to be selected.

Good question. Yes the feerate should use the max satisfaction size. I think the simplest sufficient approach for now is to use it in all cases. (Eventually we could use the actual witness size for inputs that are already signed.) However i think we should convey to the user it's an estimate. Maybe with a ~, or "estimated feerate: ".


Proofreading code splitting guide

Removed repetitive explanation, reorganised content, improved grammar and general tone.

Thanks!


Aggiungere card ML

https://lists.python.it/mailman/listinfo/milano

Someone has added a pop up for mailing list subscribing. Maybe a card is redundant isn't it? Can we close this issue?

Someone has added a pop up for mailing list subscribing. Maybe a card is redundant isn't it? Can we close this issue?

Someone was me :D
Let's close thins issue!

Ehm... my mistake! It's different topic.
ML and popup it's two separated things:

ML it's the classic mailing list
popup is used to register users to mailchimp


Fix typo in Boutique Inventory instructions

Thanks @asyraffff !

Hey @kotp , thank you for reviewing and merging this PR!! Can you tag this PR with the hacktoberfest tag ?? I really appreciate if you can do it 👍 .


Cache not storing objects, but storing refs

See original issue on GitLab
In GitLab by [Gitlab user @coldtom] on Aug 23, 2018, 15:39
Summary
My local CAS cache has been not storing objects to go with the ref, as far as I know only with this specific object, but it could be more. When trying to checkout an object using this tool, I was getting an error for the object not existing, despite buildstream telling me it was cached. Investigating further I found that the object indeed did not exist, but the entry in cas/refs/heads did.
That is:
thomascoldrick ~ $: ls ~/.cache/buildstream/artifacts/cas/refs/heads/freedesktop-sdk/bootstrap-import
6a1b1d3443d29c04b79bc240a68a0197e538475388fbf7388709a76e590b2343
97f1957a0e3843372fb336494e1d4b192fb880a0054588ae2981f9c68a9ca08a
thomascoldrick ~ $: ls ~/.cache/buildstream/artifacts/cas/objects/6a | grep 1b1d3443d29c04b79bc240a68a0197e538475388fbf7388709a76e590b2343
thomascoldrick ~ $

Running bst checkout managed to check the artifact out correctly, presumably by weak key?
Attempting to delete the ref and rebuild or re-pull the element resulted in the same issue - no object.
It may also be relevant that bootstrap-import.bst is a stack element used to get a dependency from a junction, I don't know if any other objects have this issue at present.
Steps to reproduce

Clone freedesktop-sdk
bst pull --deps all all.bst
Run the commands described above.

What is the current bug behavior?
No object for a ref in the cache.
What is the expected correct behavior?
The object, existing.
Other relevant information

BuildStream version affected: 1.1.6

In GitLab by [Gitlab user @toscalix] on Aug 29, 2018, 09:22
assigned to [Gitlab user @juergbi]

In GitLab by [Gitlab user @juergbi] on Aug 29, 2018, 11:38

thomascoldrick ~ $: ls ~/.cache/buildstream/artifacts/cas/refs/heads/freedesktop-sdk/bootstrap-import
6a1b1d3443d29c04b79bc240a68a0197e538475388fbf7388709a76e590b2343
97f1957a0e3843372fb336494e1d4b192fb880a0054588ae2981f9c68a9ca08a

These are BuildStream cache keys, not CAS digests. These files contain CAS digests, i.e., you first have to extract the CAS hash from these files before you can check whether they exist in the objects directory. As you say that bst checkout works, I don't see anything wrong at this point.

In GitLab by [Gitlab user @coldtom] on Aug 29, 2018, 12:22
With this context I think this is probably a bug in the castool. I have now modified the script in such a way that it just tries checking out every element and all are throwing an error. I'm satisfied this is a downstream issue, if this wants to be closed.

In GitLab by [Gitlab user @coldtom] on Aug 29, 2018, 12:33
Further investigation has found that this is a bug in the user, not in either tool. Due to my confusion on the difference between cache keys and cas hashes the error is due to me, and buildstream and castool both should work fine if used correctly.

In GitLab by [Gitlab user @tristanvb] on Aug 29, 2018, 14:57

Further investigation has found that this is a bug in the user, not in either tool. Due to my confusion on the difference between cache keys and cas hashes the error is due to me, and buildstream and castool both should work fine if used correctly.

Thanks for clarifying this !

In GitLab by [Gitlab user @tristanvb] on Aug 29, 2018, 14:57
closed


Display connected WiFi network

Device WiFi tab should tell user the WiFi AP the device is connected to.

See also https://github.com/edgehog-device-manager/edgehog-esp32-device/issues/70


Missing params

Hey Mr. Packman(@OttoCoddo),
WDYM, unknown param?!?!?!?
$ ./pack -v
Error: Unknown parameter: v
Press Enter key to exit
$ ./pack -h
Error: Unknown parameter: h
Press Enter key to exit

And "Press Enter key to exit"?!?!?!
Needs some revision :smiley_cat:
:thinking: .oO( I swear, and double swear, these Windows users.... :smile: )
Cheers,
Gus

Hey Mr. Packman(@OttoCoddo),
Sorry to strongly disagree with:

Options are for advanced people like you.

99.9% of the Linux crowd will interact with your tool on their first try with:
$ pack -h

This should provide a sensible usage printout with a list of all possible params and a small description of their function.
It's something that all Linux users get a muscle memory of, whatever their skill level.
Cheers,
Gus


Example of Configuration.yaml in Corpora Schema guide is outdated

@brianraymor commented on Wed Jan 20 2021
This was reported by @jahilton.
The schema version is 1.1.0, but the sample configuration.yaml in the Corpora Schema Guide has not been updated to reflect the changes, including some deprecations of fields.

@mckinsel commented on Tue Feb 16 2021
We're moving this to the single-cell-curation repo (which will be public shortly), and the guide has been updated.

@brianraymor commented on Tue Feb 16 2021
You can use Transfer issue to accomplish that task.

This was amended during the transfer to single-cell-curation

Missed it by that much, the example is introduced as "required fo the 1.0.0 schema":

The configuration yaml file describes how to apply the schema. This is an example of a "skeleton" yaml that has all the fields required for the 1.0.0 schema but is not yet filled in with any logic:

Thanks! Fixed here


Add overload for GetModule that takes no TabId

Description of problem
DotNetNuke.Entities.Modules.ModuleController.GetModule currently requires ModuleId, TabId and IgnoreCache. But TabId can be replaced by Null to return the first found instance instead of a specific one.
When replacing deprecated API calls in old modules, it is not obvious for developers to know that TabId can be a null.
Description of solution
I suggest adding an overload method without TabId with a comment on the side effects of using that overload (it returns the first found instance instead of a specific one) so TabId, TabModuleId and ModuleOrder will be of the first found one.
Description of alternatives considered
None, still works fine providing Null.NullInteger to the exiting method, just makes it more obvious for developers.
Affected version

[?] 9.2.2
[x] 9.2.1
[x] 9.2
[x] 9.1.1
[x] 9.1
[x] 9.0
[x] 8.x.x

Affected browser
Not browser related

this doesn't require any change in a stored procedure, right?

@sleupold Correct, this is a simple API structure change that would not require changes at the DB Layer

@mitchelsellers thanks, I just wanted to make sure.

Yeah, it already supports passing null for the TabId as is. It just would make it more obvious on developers that need to use the method without having access to TabId, that it can be used that way. Basically it could be just an overload that simply calls the original method with null for the TabId. Very simple.

This is still on my long long todo list. But if anyone is looking for an easy PR, this would just be one additional overload.

Yeah, not a high priority thing but would be nice when someone or me has time for it.

still on the list for DNN10

Looks like this was done somehow after this issue was created.


SAK-46676 Gradebook student filter should be accent insensitive

Thanks for your suggestions @adrianfish !, I've just applied the changes.

Good job @josecebe !


Implementation of Folder Jumping

Simple implementation of  Folder Jumping
Comes with this PR

LGTM

Some nitpicking but could you squash your 2 commits into 1?

LGTM I'll squash


[php] Incorrect highlighting of semi-reserved keywords

Take the following example:
class A {
  static function while() {}
  public function function() {}
}

$a->function();
A::while();

// Just to show that 'while' is dark red normally.
while (0) {}

Note how GitHub (like other IDEs) correctly makes the declarations purple-ish and the calls black.

...but everything is blue in VSCode.

This got fixed in the meantime. Verified in 1.10-insiders.


Abandon unwanted pull requests

Abandon pull requests which are no longer needed. The criteria are:

The pull request must have been created by the current user (owner of the token). Handled in #442
The pull request title does not contain {space}{dependency-name} from {dependency-version} to{space} for any of the dependencies. Handled by this PR

As a consequence, some PRs may be abandoned mistakenly if the lock files (which contain the used version) are not checked in to source for certain ecosystems (e.g. npm, yarn, bundler) under certain circumstances.
Fixes: #432

This PR will be merged at a later date, awaiting live environment tests.

This PR will be merged at a later date, awaiting live environment tests.

Basic tests complete.
Note: this PR does not handle closing PRs for dependencies that are ignored after pull requests have been created.


Problem: "Task Templates" pages shows "Not Launched" for every tasks except the last one that ran

Issue
The "Task Templates" pages shows "Not Launched" for every tasks except the last one that ran
Impact
Web-Frontend (what users interact with)
Installation method
Docker
Database
BoltDB
Browser
Firefox
Semaphore Version
v2.10.12-beta, v2.10.13-beta, v2.10.15-beta
Ansible Version
No response
Logs & errors
No response
Manual installation - system information
No response
Configuration
No response
Additional information
No response

I think that this is due to the changes in e247c05cfb6bea01e69904ea8e8dfb1088ba64b7 but I am not sure what the fix would be here.

Hi @vaz-ar it is issue related to boltdb. Result of query optimization :) Will be fixed soon.

Ok thanks!

@fiftin I just installed 2.10.21, looks like this is fixed, thanks!

@vaz-ar please upgrade to v2.10.22 - some bugs fixed.


error: https://github.com/jd21195/catalogue-003

Error reported on rendering https://github.com/jd21195/catalogue-003
Please paste the error in the issue

Hi @Pgxe9zu1 can you paste in your error here in the issue please then I can take a look.
I'm assuming your error was on the Quarto render, and not the Notebook running.
I have cloned your repository to my machine and I can render it with no errors, As far as I can tell this might mean one of two things.
Your local install set up needs completion.
or
Your local files have been updated and I'm working with an older version from Github.
I would suggest, make sure you push a copy of your local repo online.
Second run: quarto check in your terminal and paste in teh output below, this will help see if you have anything missing in the install for quarto.

Hi @mrchristian, I'm sorry that I didn't respond sooner. I was unable to access my email account.
The Error message is:

compilation failed- error
Package graphics Error: Division by 0.

See the graphics package documentation for explanation.

Every time I try to render. The Error message can also be found in my index.log, Line 1338ff.
I am going to try your solution and let you know the results.

Thanks @Pgxe9zu1 I'll take a look ASAP

Hi, this appears to be an issue with the distribution of LaTeX that Quarto uses. I'd suggest running quarto install tinytex to ensure that it's properly installed. There are some further TinyTeX commands to check it here: https://quarto.org/docs/output-formats/pdf-engine.html

@Pgxe9zu1 see the note above about a possible fix for your error

Thanks, @SimonXIX, for trying to help me. I installed TinyTex and updated Deno, but the rendering issue persists (see below). Should I consider reinstalling something?
(Also, I've been unsuccessful in uninstalling MikTex for years, and I ended up deleting its folders. Because of the similar names, I thought there might be a connection.)

PS C:\Users\lisas\OneDrive\Documents\GitHub\catalogue-003> quarto render
[1/5] index.qmd
[2/5] colophon.ipynb
[3/5] collection003.qmd
[4/5] paintingsSommer.ipynb
[5/5] video.ipynb
pandoc
to: latex
output-file: index.tex
standalone: true
toc: true
number-sections: true
top-level-division: chapter
pdf-engine: xelatex
variables:
graphics: true
tables: true
default-image-extension: pdf
metadata
crossref:
chapters: true
documentclass: book
papersize: letter
block-headings: true
comments:
hypothesis: true
title: 'Baroque AI: Publication Prototype'
author: Lisa Sommer
date: '2023-04-13'
running xelatex - 1
This is XeTeX, Version 3.141592653-2.6-0.999995 (TeX Live 2023) (preloaded format=xelatex)
restricted \write18 enabled.
entering extended mode
updating tlmgr
updating existing packages
compilation failed- error
Package graphics Error: Division by 0.
See the graphics package documentation for explanation.
Type  H   for immediate help.
...
l.173 ...ring \includegraphics{6780765/Cupido.jpg}
see C:\Users\lisas\OneDrive\Documents\GitHub\catalogue-003\index.log for more information.
PS C:\Users\lisas\OneDrive\Documents\GitHub\catalogue-003> quarto list tools
[>] Inspecting tools
Tool         Status            Installed     Latest
chromium     Not installed     ---           869685
tinytex      Up to date        v2023.04      v2023.04

Hello @mrchristian, I got a new laptop and I reinstalled everything (I realized that I missed the entire chapter on Docker containers the first time). The issue sadly prevails. Is there a possibility to maybe remove the fork and start from the beginning? I thought that I might have done something to it, and that's why I can't render even on my new laptop.

Hi Lisa,
Aplogies for my slow reply, I need to make some sort of notification process to get notices from Github to my mail.
Great your persevering and thanks for the troubleshooting request - I'll try and run your repo locally my self and see what happens. Presently there are three possibilities that could be causing your problem: The specific LaTeX package as @SimonXIX mentioned; could be image size being over the default quota; or Quarto not fully installed.
I'll report back end of day

Hi @Pgxe9zu1 I found the solution to your problem.
In the file index.qmd line 7: delete
Once you save, then the Quarto project will render. I think the image file is too big, but I'll raise an issue and add to troubleshooting guide.
I was able to render your forked repo locally after this change https://github.com/Pgxe9zu1/catalogue-003
Note: In _quarto.yml update the repo address, line 18 to be your repo address https://github.com/Pgxe9zu1/catalogue-003
Thanks
Simon

Thank you so much, @mrchristian ! I'm so glad that it finally worked and that I'll be able to turn the exercise in normally.


Update and add waitForIndexer

Description

This PR updates the "wait for Indexer" concept to only wait when user is fetching the resource that need to be waited.
Changes in details:

Update name to waitForIndexer - This function will wait for indexer to catch up based on processor type. If not specified, wait on all processor
fundAccount - This automatically includes and wait for indexer, because I would expect to want to use the resource right away, and there are so many tests which relies on this.
Added new query to fetch ProcessorStatus - getProcessorStatus
Updated ProcessorStatus graphql query to include where_condition.
Added Api base class, which would include the actual logic of waitForIndexer, so all api classes can uses this func.
Added ProcessType enum for all processor types
Updated all api classes' query method to include optional minimumLedgerVersion. If included, The query will wait for indexer version to catch before the actual query happens.

Test Plan

pnpm test
Related Links

Updated to address all comments

Note: Rebased and handled merge conflicts

Rebased again

Squashed into 1 commit, with more description


StyleGAN Latent Space Examples

@ellennickles here are some new examples I'm working on, pretty similar to yours! (need to clean up and add comments still).

Generate an image

Interpolate an image

Wander latent space

Also, I was able to get the image synthesis to work @ellennickles! But I had to do some gymnastics dealing with the retina display pixels and using rectangles instead of circles to avoid anti-aliasing. This is definitely going to requires some thinking. . it might actually make sense to create a p5-runway library with a bunch of helper functions for base64 encoding and image manipulation?

cc @cvalenzuela

Hooray! 🎉 Now students have most of the p5 universe to create semantic maps!
Btw, I'm still working on a socket.io example that would be useful to have on hand, especially for the image synthesis models. It was working the day before yesterday :) but I'm currently troubleshooting CORS errors.


clean ups

replace https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1511 on 1.11

nice ;)

why is hhvm failing?

cc @GrahamCampbell http://fabbot.io/report/FriendsOfPHP/PHP-CS-Fixer/1535/10861d56f208c18a2415e38cb94c063f1518db48 do you agree withj fabbot here?

why is hhvm failing?

not a clue so far, I messed up my HHVM setup with the last RC of PHP7 so I'm a bit in the dark here.

Thank you @SpacePossum.

:+1:  thank you @keradus


'List' is ambiguous for type lookup in this context

There seems to be a collision for the List type, whenever I use it I get the following error.
Maybe I am missing some simple solution to this?
I know that if there is a name collision with other types you could say Twift.List, but here, all List types seem to be from Twift, but registered as different?
Do advise :) Thank you!

@daneden So this is weird.
If I omit SwiftUI from the import and add UIKit, it builds fine. It seems it is clashing with native List method in SwiftUI.
Not sure what is a solution to this?

@roblack ah yep, this is a tough one API-design-wise. I ran into this early in development and figured the ambiguity was easy enough to work around either by:

Disambiguating in-line (e.g. let list: Twift.List)
Disambiguating via typealias (e.g. typealias TwitterList = Twift.List

I don’t love the idea of prefixing List since that would make it inconsistent compared to the rest of the API, but open to other ideas!

I tried to use Twift.List but it did not work...however, i did that with SwiftUI being imported so that might have something to do with it 🤷♂
I will try with a typealias, that should do the trick 🤞
But you are right, prefixing would cause inconsistency 👌
Will report back first thing, but after that i think i can just close/cancel the PR

Actually, this turned out to be 👌
I do not need SwiftUI in the ObservedObject and View does not need to know the type of object so it all works out :)
It is weird that typealias or Twift.List did not work as soon as SwiftUI is imported but, main thing is that there are ways around it 🙌


Add recipe for bump version number and create a new Git tag

I had to rebase the interpret commit, can you rebase your commits off the new master? thanks

I have sync my repository. Is that all you need?

@carpasse http://stackoverflow.com/questions/17182624/contributing-to-project-on-github-how-to-rebase-my-pull-request-on-top-of-mast

rebase done.

Can you rebase?

done


Go language support

Hey, I recently found the goscript package which is a Go interpreter written in Rust which can be compiled to wasm and used to interpret and run Go code in the browser. I whipped up a quick demo you can try out here.
There are some considerations though:

Only the fmt package from the Go std lib is supported at this time, this is kind of a big deal but the project maintainer now seems to be focused on completing the rest of the packages
Differences in implementation details means that there may be edge cases where there are behavioural discrepancies between running Go code interpted by goscript vs compiled by the actual Go compiler. This probably won't be too big a concern and of course as the project matures these problems will be resolved
goscript uses the filesystem which means it must be compiled to the wasm32-wasi target, which requires a wasm runtime that supports WASI (most browser's dont support it right now). However it's a trivial process to setup wasmer.js which supports WASI (I used this for the demo I linked above)

What is everyone's thoughts on this? If there is interest I would be happy to make a PR to implement this 👍

Your demo is slick! I don't use Go yet, but would love to see this supported!

How does using this compare to something like https://github.com/tinygo-org/tinygo?

The main thing that compelled me to bring up goscript is that it is an interpreter so the Go code doesn't have to be compiled. If you try the tiny-go playground and open the network tab its compiling the code on a server and sending back the wasm for the client to run. This can be very appealing since it means getting Go to work with the library is painless.
That being said, goscript is missing a lot from Go's standard lib. Like I think at this point it would only be maybe viable for an introductory Go course on Slip for example. Obviously, tiny-go is a much more mature project supporting more features so it comes down to how much we value supporting a larger feature set at this time and if we don't mind the users of the library to have to setup a server to compile the Go code.
Or we could go halfway and have users of the library by default use goscript and can opt in to tiny-go + server side compilation if their needs demand it. What do you guys think?

The tiny-go docs say it's compiling and running in the browser

Hmm that's weird, think it's just vague wording on the docs, I poked around the TinyGo playground's source code and I see that they setup an /api/compile route here which runs the tinygo cli on the server.
Here's the network tab of Chrome devtools where I see the wasm being spit out:

Spoiler warning

Think to get TinyGo working solely in the browser we would have to compile the TinyGo compiler to wasm so we can compile Go to wasm inside wasm 🤯
If we choose the TinyGo server-side compilation route I guess it wouldn't be too difficult to pull some of the code from the playground to get it working

Why not have the actual go compiler compile to wasm? Go does have wasm support!

TinyGo is preferred because it strips some of the runtime bloat since go wasm binaries are known to be c h o n k y, but none of these can be used if we want to only run Go in the browser without any server-side compilation. For that we would need a Go interpreter (goscript), or some Go compiler that can be compiled to wasm so we can compile the Go code on the client side in the browser.

I think we just ship goscript and then long term experiment on figuring out a way to either add more libs or find support for tinygo!
Ship and iterate is the move 🥷

Sounds like a good plan 🚢 ♻
I can port over some of my existing code from my demonstration, any specific way you want me to do it? Perhaps we should setup a monorepo multiple-package type structure, I think it would be good to have each of these languages in its own package because wasm binaries can be a bit big

Yeah that's a good question.
I think having a common api across languages is good but that shipping the whole binary for every language is a little unnecessary for folks who want to only execute Python for example.
Maybe we should make the user load the binaries via cdn on the front end and they can choose which they want to import?
Or we could look at patterns that other similar libraries do this (similar in that they have heavy dependencies and let a user choose which to use).
Could you explain your option a bit more? Would it still be one npm library? Or multiple? I'd prefer one, with an option to reduce the total size based on a users preference somehow

So what I was thinking is we have @slip/run-wasm which is the "core" package and has the main RunWasm component, then each language can expose a class or an object that can interface with that component, imported like @slip/run-wasm-go or @slip/run-wasm-ts.
Then when using the library you do something like this:
import RunWasm from `@slip/run-wasm`
import ts from `@slip/run-run-wasm-ts`

const Code = () => {
  const [code, setCode] = useState('const fn = () => console.log("hello wasm!")')

 return (
    <RunWasm language={ts} code={code} />
  )
}

What do you guys think about this?

Yeah I'm down with this approach!

OOh, found this on the Gopher slack: https://github.com/open2b/scriggo
Do you think that could come in handy?

Amazing find @quackduck !! Scriggo has far more complete support for Go's stdlib. Scriggo's playground is already using wasm so I'll definitely try taking a look at that and getting it working 👍

Is anyone working on this?

I dont think so @ntindle, feel free to tackle it!

Is there any docs on integration of new langs or should I play it by ear?

RE: the above
Go ships with a wasm runner that we should use independent of the compiler (unless the compiler ships their own).  It can be found at $(go env GOROOT)/misc/wasm/wasm_exec.js for Linux systems.
This means that we only need to set up a Go -> WASM compiler. Based on the above discussions and my own research, I found a few things.
There are two options above and one I found:
TinyGo:

Cons:

Does not implement a WASM-based Go compiler. It can compile go to wasm.
Is a subset of Go

Pros:

Very Small

Scriggo:

Cons:

Does not implement a WASM-based Go compiler. It can compile go to wasm.
Is a subset of Go
The playground would require us to compile Scriggo to wasm ourselves.

Pros:

It has an example of how to implement a playground that compiles and runs go

wasm-go-playground:

Cons:

It is out of date for the latest release of go (hasn't been updated since Apr 2020)
It doesn't support the full go lib set, yet
No published license

Pros;

We wouldn't need to support our own compiled Go wasm binaries (hopefully)
it is using the real go compiler

I would prefer to use wasm-go-playground due to it using the go compiler itself, not a reimplementation. I opened an issue to address some of the concerns I had.
If we can't get wasm-go-playground, I would recommend having a Github action that periodically runs the Scriggo compile from the Playground and updates it in the repo. We would then be able to use Scriggo in a very similar way as wasm-go-playground without using the official go compiler.
If we wanted to support running pre-compiled Go wasm blobs, it would be trivial to get up. The compilation is the difficult part.
Nicholas


Update vocabulary.md

First of two additions of vocabulary and definitions from the 2020.12.18 OVN Vocabulary Reconciliation session.

Given there is an approval, @jcstine you can merge this PR now.

Given there is an approval, @jcstine you can merge this PR now.

Hi @jcstine - do you want to merge the changes if this is approved?

Hi @jcstine - do you want to merge the changes if this is approved?

Merging #105 with Vocabulary.md

Merging #105 with Vocabulary.md


MTL-1658 Updated echos and removal of nstat

Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
This change fixes some echo statements and removes calls to nstat, which doesn't print anything.
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Yes.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves MTL-1658

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
None.
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

This includes the RPM and the PIT ISO with the RPM baked in.


Update Node versions tested

Updates the Node versions used in testing:

Removes Node19 from tests as this has reached EOL and is not an LTS release.
Adds Node 21 to the list of tested Node versions
Updates Node 20 to its latest release as of 10/27 (v20.9.0)

In addition, this also adds the http1.1 flag to the curl calls to download the Node tarballs.

@timo should we update this Node 20? https://github.com/connectrpc/connect-es/pull/891/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R204

Yes, good idea to extend testwebnode to run on all versions - except for the CI runtime penalty, but that just means we should improve the setup sooner.


Resource Deps for k8s_yaml?

Is there a way to accomplish something like:
k8s_yaml('file.yaml', resource_deps=["service-operator"])

where service-operator is a helm_resource

not today, only on k8s_resource, marking this as a duplicate of https://github.com/tilt-dev/tilt/issues/3265


chore: fix go ctx arg naming in ics29 grpc queries

Description

closes: #872

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #1211 (36a6089) into ics29-fee-middleware (3ab2251) will not change coverage.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           ics29-fee-middleware    #1211   +/-   ##
=====================================================
  Coverage                 80.07%   80.07%
=====================================================
  Files                       166      166
  Lines                     11870    11870
=====================================================
  Hits                       9505     9505
  Misses                     1908     1908
  Partials                    457      457

Impacted Files
Coverage Δ

modules/apps/29-fee/keeper/grpc_query.go
77.68% <100.00%> (ø)


chore: add test that all words are unknown

Codecov Report
Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (f4e3300) to head (73d0c49).

Files with missing lines
Patch %
Lines

rust/lance-index/src/scalar/inverted/builder.rs
88.88%
4 Missing :warning:

rust/lance-index/src/scalar/inverted/index.rs
85.71%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2852      +/-   ##
==========================================
+ Coverage   78.04%   78.07%   +0.02%
==========================================
  Files         229      229
  Lines       70357    70397      +40
  Branches    70357    70397      +40
==========================================
+ Hits        54911    54963      +52
+ Misses      12361    12346      -15
- Partials     3085     3088       +3

Flag
Coverage Δ

unittests
78.07% <88.37%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hook before route no view method

Hi,
I'm trying to create an installable hook how make some ACL verifications and when I use res.forbidden, res.notFound or res.view I have an error :
error: Sending 500 ("Server Error") response:
 TypeError: Object #<ServerResponse> has no method 'view'
    at Object.forbidden (/Users/jaumard/Documents/workspaceIDE/KikiLib/api/responses/forbidden.js:56:19)
    at ServerResponse.bound [as forbidden] (/usr/local/lib/node_modules/sails/node_modules/lodash/dist/lodash.js:729:21)
    at isRouteAllowed (/Users/jaumard/Documents/workspaceIDE/KikiLib/api/hooks/acl.js:66:18)
    at routeTargetFnWrapper (/usr/local/lib/node_modules/sails/lib/router/bind.js:179:5)
    at callbacks (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:164:37)
    at param (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:138:11)
    at pass (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:145:5)
    at nextRoute (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:100:7)
    at callbacks (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:167:11)
    at /usr/local/lib/node_modules/sails/lib/router/bind.js:187:7
    at /usr/local/lib/node_modules/sails/lib/hooks/i18n/index.js:35:7
    at Object.i18nInit [as init] (/usr/local/lib/node_modules/sails/node_modules/i18n/i18n.js:89:5)
    at addLocalizationMethod (/usr/local/lib/node_modules/sails/lib/hooks/i18n/index.js:33:11)
    at routeTargetFnWrapper (/usr/local/lib/node_modules/sails/lib/router/bind.js:179:5)
    at callbacks (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:164:37)
    at param (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:138:11) [TypeError: Object #<ServerResponse> has no method 'view']
error: Server Error:
error: TypeError: Object #<ServerResponse> has no method 'view'
    at Object.forbidden (/Users/jaumard/Documents/workspaceIDE/KikiLib/api/responses/forbidden.js:56:19)
    at ServerResponse.bound [as forbidden] (/usr/local/lib/node_modules/sails/node_modules/lodash/dist/lodash.js:729:21)
    at isRouteAllowed (/Users/jaumard/Documents/workspaceIDE/KikiLib/api/hooks/acl.js:66:18)
    at routeTargetFnWrapper (/usr/local/lib/node_modules/sails/lib/router/bind.js:179:5)
    at callbacks (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:164:37)
    at param (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:138:11)
    at pass (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:145:5)
    at nextRoute (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:100:7)
    at callbacks (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:167:11)
    at /usr/local/lib/node_modules/sails/lib/router/bind.js:187:7
    at /usr/local/lib/node_modules/sails/lib/hooks/i18n/index.js:35:7
    at Object.i18nInit [as init] (/usr/local/lib/node_modules/sails/node_modules/i18n/i18n.js:89:5)
    at addLocalizationMethod (/usr/local/lib/node_modules/sails/lib/hooks/i18n/index.js:33:11)
    at routeTargetFnWrapper (/usr/local/lib/node_modules/sails/lib/router/bind.js:179:5)
    at callbacks (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:164:37)
    at param (/usr/local/lib/node_modules/sails/node_modules/express/lib/router/index.js:138:11) [TypeError: Object #<ServerResponse> has no method 'view']

Under index.js I have :
routes     : {
      before : {
        "/office" : function (req, res, view)
        {
          .....
          res.forbidden();
        }
      }
    },

I don't use policies cause policies only apply to routes and want to add more possibilities.
Is there a workaround for this ? Or maybe I make an error somewhere ?
http://stackoverflow.com/questions/29317329/sails-hook-route-forbidden?noredirect=1#comment46875764_29317329

Just found a workaround :
var _addResViewMethod = require("../sails/lib/hooks/views/res.view.js");
routes     : {
      before : {
        "/office" : function (req, res, view)
        {
          .....
          _addResViewMethod(req, res, function(){
               res.forbidden();
          });
        }
      }
    },

Hi @jaumard, this issue arises because the views hook waits until after the i18n hook loads before binding routes, and the only way to do this is to use the sails.router.bind method to bind routes directly instead of utilizing the hook API's built-in routes option.  The good news is, you can do the exact same thing in your hook.  Instead of using routes: {}, put the following in the initialize function:

// Wait for the router to be initialized
sails.on('router:before', function () {

    // Wait for the views hook to load, so that its routes get bound first
    // (including the one that mixes in res.view)
    sails.after('hook:views:loaded', function () {
      // Bind your routes here
      sails.router.bind('/office', officeHandler, 'get', {});
    });

    function officeHandler(req, res) {...res.forbidden()...}

    return cb();
});

This is preferable to adding the res.view method yourself.

Thanks ! It's more cleaner than my workaround, I will test this.

I have a E_HOOK_TIMEOUT error with your code.
To make it work I have to use this (call the callback out of router:before) :
initialize : function (next)
{
    // Wait for the router to be initialized
    sails.on('router:before', function ()
    {
      // Wait for the views hook to load, so that its routes get bound first
      // (including the one that mixes in res.view)
      sails.after('hook:views:loaded', function ()
      {
        // Bind your routes here

        for (var route in  sails.config.routes)
        {
          sails.router.bind(route, officeHandler, 'get', {});
        }

      });

      function officeHandler(req, res)
      {
        res.forbidden();
      }

    });
    return next();

},

You're right--I mistyped in my post.  The callback needs to go outside the event handler, just as you have it.

Thanks for your confirmation ! :D it works like a charm !


feat: CBR service profile submodule to support multiple target services

Description
Adding service profile submodule
Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[x] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Adding service profile submodule to support multiple target services

Checklist for reviewers

[ ] The PR references a GitHub issue.
[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

@daniel-butler-irl would you mind reviewing?
@jojustin You need to fix the conflict. Try to avoid committing updates to common-dev-assets in PRs, or you will quickly end up with conflicts like this

I think we need to brainstorm a bit further on what we're trying to achieve here, and how we shape this submodule accordingly.
The main goal is to facilitate the ability to create coarse-grained account level CBRs. In particular, in the context of fscloud architecture / slz, the CBR rules for the target that would be pre-configured at the account level behind CBR rule - a few examples of targets:

COS (all instances + bucket)
Key Protect / Hyper protect
Each of the ICD instance
Transit gateway (?)
potentially more over time

We should discuss on the input variable - I believe we could simplify slightly based on this - ideally just passing a list of service names, and default a lot of inputs (eg: accountId). Also it would be great to validate the name of the service at the module level.
The sources would typically be:

VPC compute resource in the account for COS, ICD
S2S when necessary (cos / icd -> key protect / hyper protect flows).

Another aspect to think about is around being able to easily update the source over time per CBR rule - eg: when a new VPC is created in the account.


docs: updated vision detect params/examples

Relates to https://github.com/GoogleCloudPlatform/gcloud-node/pull/1488#issuecomment-240179248

Coverage remained the same at 100.0% when pulling 843c9dc2b104f38a033456427f3fed76a15ed17e on callmehiphop:vision-buffer-docs into 3cfc68c20e29df85a16eae1de96da8dde232207c on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 843c9dc2b104f38a033456427f3fed76a15ed17e on callmehiphop:vision-buffer-docs into 3cfc68c20e29df85a16eae1de96da8dde232207c on GoogleCloudPlatform:master.

@stephenplusplus WDYT?

I think we just need a different example (https://github.com/GoogleCloudPlatform/gcloud-node/pull/1500#discussion_r75020420). Sorry that I'm struggling to come up with something specific to suggest... the only thing is that it shouldn't confuse people into thinking they have to use fs.readFile() to have an image on disk run through feature detection.

I think that there are many sorts of buffers sources, like DBs, remote services, incoming http requests, etc., IMHO doc shouldn't describe all these sources and maybe example should be transformed to a common form of getting buffer like:
getBufferFromSomewhere(function(err, buffer) {
  vision.detect(buffer, types, function(err, detection, apiResponse) {});
});

var db = require('level')('./users-database');

db.get('user-image', { encoding: 'binary' }, function(err, img) {
  if (err) {
    // Error handling omitted.
  }

  vision.detect(img, function(err, detection, apiResponse) {});
});

@stephenplusplus WDYT about using @calibr's example? IIRC a lot of our customers use AWS services as well, so I think it has the added benefit of being a common use case.

Let's see if @jgeewax or @omaray has a preference of which example best demonstrates passing a Buffer with our library off to Vision's feature detection.

@stephenplusplus @calibr updated the example, PTAL


Improvements to CLI interface

This pull request is to rename main class for consistency reason and simplify handling exit code.

approved


Unable to get user info for offline players.

LuckPerms dev 358
Yaml database.
You are unable to get user information for offline players.
/lp user <user> info outputs that the user could not be found. However the user does exist in the user files post migration.

If they haven't logged it yet, try using their UUID  in the command

LP doesn't automatically look up users by the name reference in their user file? Having to find what someone's UUID is to get their groups or permissions if they haven't logged in yet seems a bit tedious with large databases.

If they haven't logged on post migration, yes. The export command uses the uuid to ensure nothing dodgy goes on. After they've logged in, you can use their username.

The username already exists in the file though. Why not do a look-up of the name to pull the UUID file?

Set this option to true.
https://github.com/lucko/LuckPerms/wiki/Configuration#use-server-uuids

That option is already set to true but I'm not able to look-up players by their name who haven't logged in since migration.
# This option only really exists for networks who for whatever reason cannot setup proper ip
# forwarding.
use-server-uuids: true

Oh, sorry my bad, I meant this option:
https://github.com/lucko/LuckPerms/blob/master/bukkit/src/main/resources/config.yml#L71

Changing that setting seems to work. Thanks.


Where is source code? Compiler? Linker? Parser?

What i can only see , it is just some document.
But as programming language. said open source, Where is the source code.
Or why you called it Open Source.
Am i wrong to understand what is the opensource.
Hey , I am happy to open source Power-FX (But only the document open source)
How did you feel like it ?

it's a "low code" programming language, the  source is in the readme

"A start on the language documentation is available in the docs folder. As with the implementation, it is being extracted from the Power Apps documentation and generalized and that too is going to take some time." - from the Readme

as bryan canthrill said multiple times, one of the worst corporate anti pattern is to announce an open source product without the source code. when you're ready to release it, throw the code at the same time.

It would be very nice to have a roadmap with rough target dates for when the parts of the implementation will be available. Power Fx is very interesting, but writing a custom implementation of the language for use in a product is pointless if Microsoft's implementation will be open sourced a few quarters later. Likewise, if it's going to be years before the Microsoft implementation is available then a custom implementation makes more sense.

https://twitter.com/wuyuting771006/status/1367879011775311872?s=21

Currently this is the only source file as far as I can see. The rest is just docs :)


Unminify configs in repo, minify in use

It was suggested that the scripts could be adapted to minify the configs in use, but beautify in repo. That would help with transparency and clarity.
Probably in the CurseForge to MultiMC-Git tool.
Similar batch-minify thing wanted for languages too.

Most configs are small enough to be still legible; this would negatively affect MultiMC (auto-update).


Please patch CVEs

Hello! Continuing from #290, there are still two remaining CVEs in the latest celery-exporter docker image:

Package Name
Vulnerable Version
Patched Version
CVE

pyinstaller-5.10.0
5.10.0
5.13.1
CVE-2023-49797

certifi-2022.12.7
2022.12.7
2023.7.22
CVE-2023-37920

Thank you


[Runner] Container Configuration

There should be the possibility to configure the payload when creating the container.
A JSON config should be provided that is then deep-merged with the configuration Candor creates.
It should be provided as a base64 encoded RUNNER_CONTAINER_CONFIG_B environment variable.
This will allow resource limits, isolated networking, etc. and add great security benefit.

Implemented in 5df3baedba619f108710fb5e625d774b311e8a2d


Add awesome-npm-scripts

https://github.com/RyanZim/awesome-npm-scripts
I couldn't find an awesome list relating to npm scripts and using npm as a build tool, so I wrote one. This is a resubmission of https://github.com/sindresorhus/awesome/pull/775; the list has been expanded since then.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the list project/theme. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell.
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
The repo should have the following GitHub topics set: awesome-list, awesome, list. I encourage you to add more relevant topics.
Not a duplicate.
Includes a succinct description of the project/theme at the top of the readme. (Example)
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Has the Awesome badge on the right side of the list heading,
Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

Each link description starts with an uppercase character and ends with a period.Example: - [AVA](…) - JavaScript test runner.
Drop all the A / An prefixes in the descriptions.
Consistent naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Not followed:

Drop all the A / An prefixes in the descriptions.
Each link description starts with an uppercase character and ends with a period.

Advanced front-end automation with npm scripts - by Kate Hudson

This one needs an actual description.

@legodude17 Thanks for the review. Fixed (I think)!

Suggestions:

Actually describe what watch and onchange do.
Find a way to reword the Cross-Platform Utilities section so less of them start with the words cross-platform
Describe what shx is

Hey, thanks for the suggestions.
watch and onchange both do the same thing; they watch files. The only difference is the command syntax. Would it be OK to describe what they do directly under the heading and leave the individual descriptions pretty close to what they are?

Yeah, that would make sense, as long as you make it clear that the description applies to both of them.

@legodude17 Can you take a look at https://github.com/RyanZim/awesome-npm-scripts/pull/18?

@RyanZim Very nice!
I would suggest you improve the description of shx, like give examples.

@legodude17 Updated RyanZim/awesome-npm-scripts#18

@RyanZim Very nice! I don't think I have anything else to add.
Any thoughts @sindresorhus?

Any action on this?

@sindresorhus ping?

Includes a succinct description of the project/theme at the top of the readme. (Example)

⬆

@sindresorhus Change LGTM

@sindresorhus Updated

Added :)

Thanks a lot!


feat: compartmentalize ActionType

Description
Compartmentalize ActionType into smaller enums grouped by the action prefix ([dev], [settings]) etc..
Motivation
This will keep the action list clean and structured once more actions are added in the future.
Resources
Perhaps this will offer a nice solution: https://docs.rs/strum/latest/strum/
To-do List

[ ] compartmentalize ActionType

issue #97


Possible to send and recive dm to another user

I just need to send and recive messages to only one user  ? is it possible , if it's would you guide me a abit to able to try . to do it with using my user credentials.

You can just type User.SendMessageAsync()

shouldnt I login ?

login to what?

For questions relating to library help it's best to ask in the Discord https://discord.gg/jkrBmQR

login to what?

I'm not trying to make a bot  , just send and recive messages from a C3 application to specisif user or users

For questions relating to library help it's best to ask in the Discord https://discord.gg/jkrBmQR
Thank you I will go there.


Autodrive navigation is so slow

It is so slow navigating. seems like it doesnt know how to make up its mind...  and the network, as you can see is not major.

I have tried mapping every way till sunday and still, decision making is trash, it goes around the map, when there are clearer paths.

This is nothing new. Crossroads should be done with curves and not straight lines, otherwise it is normal for the vehicle to slow down a lot. This has always worked this way. Here is an example:

AD calculates the driving speed based on the angles of the waypoints to each other.
Less waypoints in a curve = higher angles = lower speed.


[iOS][Crash] [App will crash when render an image]

Platform
What platform is your issue or question related to? (Delete other platforms).

[ ] iOS

Author or host
Use Adaptive Card in my project.
Version of SDK
2.3.1 from CocoaPods
Details
If the Card include an image, the app will crash when render. But the 1.2.13 version is normal.
Last Exception BackTrace: NSInternalInconsistencyException: Mutating a priority from required to not on an installed constraint (or vice-versa) is not supported. You passed priority 750 and the existing priority was 1000.
0-4	CoreFoundation - Foundation	0x00000001ef96bef8 - 0x00000001f03079b8	__exceptionPreprocess - -[NSLayoutConstraint setPriority:]
5	AdaptiveCards	0x0000000144651c54	-[ACRImageRenderer configUpdateForUIImageView:config:image:imageView:]
6	AdaptiveCards	0x000000014467f2ac	-[ACRView observeValueForKeyPath:ofObject:change:context:]

@yanweida99
Thanks for reporting the issue.
Could you please share more about your project such as use cases for AdaptiveCards in your app, and perhaps the apps' name if you could?
Also please share your payload, so I can repro from my side.
Thanks

@yanweida99
Thanks for reporting the issue.
Could you please share more about your project such as use cases for AdaptiveCards in your app, and perhaps the apps' name if you could?
Also please share your payload, so I can repro from my side.
Thanks

I just embed AdaptiveCard in my project to make a simple demo.
Payload: { "type": "AdaptiveCard", "version": "1.0", "body": [ { "type": "Image", "url": "http://adaptivecards.io/content/adaptive-card-50.png", "horizontalAlignment":"center" }, { "type": "TextBlock", "horizontalAlignment":"center", "text": "Hello Adaptive Cards!" } ], "actions": [ { "type": "Action.OpenUrl", "title": "Learn more", "url": "http://adaptivecards.io" }, { "type": "Action.OpenUrl", "title": "GitHub", "url": "http://github.com/Microsoft/AdaptiveCards" } ] }
All Stack Trace:
Last Exception BackTrace: NSInternalInconsistencyException: Mutating a priority from required to not on an installed constraint (or vice-versa) is not supported. You passed priority 750 and the existing priority was 1000.
0	CoreFoundation	0x00000001ef96bef8	__exceptionPreprocess
1	libobjc.A.dylib	0x00000001eeb39a3c	objc_exception_throw
2	CoreFoundation	0x00000001ef880068	+[NSException raise:format:arguments:]
3	Foundation	0x00000001f036c3dc	-[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
4	Foundation	0x00000001f03079b8	-[NSLayoutConstraint setPriority:]
5	AdaptiveCards	0x0000000147f09c54	-[ACRImageRenderer configUpdateForUIImageView:config:image:imageView:]
6	AdaptiveCards	0x0000000147f372ac	-[ACRView observeValueForKeyPath:ofObject:change:context:]
7	Foundation	0x00000001f03ddd48	NSKeyValueNotifyObserver
8	Foundation	0x00000001f03e01dc	NSKeyValueDidChange
9	Foundation	0x00000001f03dfb0c	-[NSObject(NSKeyValueObservingPrivate) _changeValueForKeys:count:maybeOldValuesDict:maybeNewValuesDict:usingBlock:]
10	Foundation	0x00000001f032ea38	-[NSObject(NSKeyValueObservingPrivate) _changeValueForKey:key:key:usingBlock:]
11	Foundation	0x00000001f03da44c	_NSSetObjectValueAndNotify
12	Test	0x00000001073803b4	__109-[UIView(WebCache) sd_setImage:imageData:basedOnClassOrViaCustomSetImageBlock:transition:cacheType:imageURL:]_block_invoke
13	Test	0x00000001073802ac	-[UIView(WebCache) sd_setImage:imageData:basedOnClassOrViaCustomSetImageBlock:transition:cacheType:imageURL:]
14	Test	0x000000010737f420	__134-[UIView(WebCache) sd_internalSetImageWithURL:placeholderImage:options:operationKey:internalSetImageBlock:progress:completed:context:]_block_invoke.50
15	Test	0x000000010737ef7c	__134-[UIView(WebCache) sd_internalSetImageWithURL:placeholderImage:options:operationKey:internalSetImageBlock:progress:completed:context:]_block_invoke.38
16	Test	0x0000000107377524	__104-[SDWebImageManager callCompletionBlockForOperation:completion:image:data:error:cacheType:finished:url:]_block_invoke
17	Test	0x0000000107377294	-[SDWebImageManager callCompletionBlockForOperation:completion:image:data:error:cacheType:finished:url:]
18	Test	0x00000001073757f0	__65-[SDWebImageManager loadImageWithURL:options:progress:completed:]_block_invoke
19	Test	0x0000000107363428	__55-[SDImageCache queryCacheOperationForKey:options:done:]_block_invoke_2
20	libdispatch.dylib	0x00000001ef3a36c4	_dispatch_call_block_and_release
21	libdispatch.dylib	0x00000001ef3a4480	_dispatch_client_callout
22	libdispatch.dylib	0x00000001ef3509e8	_dispatch_main_queue_callback_4CF$VARIANT$mp
23	CoreFoundation	0x00000001ef8fa1b8	CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE
24	CoreFoundation	0x00000001ef8f5080	__CFRunLoopRun
25	CoreFoundation	0x00000001ef8f45b4	CFRunLoopRunSpecific
26	GraphicsServices	0x00000001f1b68580	GSEventRunModal
27	UIKitCore	0x000000021c8b8bc4	UIApplicationMain
28	Test	0x0000000106431a34	main
29	libdyld.dylib	0x00000001ef3b4b90	start

@yanweida99
I can't repro your issue on my end. I noticed two things; SDWebImageManager, and "NSInternalInconsistencyException: Mutating a priority from required to not on an installed constraint (or vice-versa) is not supported".
It seems that a constraint with the required priority was set on your ImageView, possibly from SDWebImageManager. AdaptiveCards renderer is installing its own constraints. Please check those constraints with the maximum priorities.

@yanweida99
Closing this issue as it requires the fix externally. Please let us know if changes in AdatpiveCards is required to resolve your issue.
Thanks,
c.c @shalinijoshi19 @paulcam206

@yanweida99
Closing this issue as it requires the fix externally. Please let us know if changes in AdatpiveCards is required to resolve your issue.
Thanks,
c.c @shalinijoshi19 @paulcam206

2020-12-21 15:52:06.674813+0800 ADCIOSVisualizer[4565:1656621] completed loading elements
2020-12-21 15:52:06.688209+0800 ADCIOSVisualizer[4565:1656621] completed loading elements
2020-12-21 15:52:09.293441+0800 ADCIOSVisualizer[4565:1656621] *** Assertion failure in -[NSLayoutConstraint setPriority:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/Foundation/Foundation-1556/Foundation/Layout.subproj/NSLayoutConstraint.m:234
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Mutating a priority from required to not on an installed constraint (or vice-versa) is not supported.  You passed priority 750 and the existing priority was 1000.'
terminating with uncaught exception of type NSException
2020-12-21 15:52:09.294451+0800 ADCIOSVisualizer[4565:1656621] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Mutating a priority from required to not on an installed constraint (or vice-versa) is not supported.  You passed priority 750 and the existing priority was 1000.'
*** First throw call stack:
(0x1ef96bef8 0x1eeb39a40 0x1ef88006c 0x1f036c3e0 0x1f03079bc 0x100be9f20 0x100cbd1b4 0x1f03ddd4c 0x1f03e01e0 0x1f03dfb10 0x1f032ea3c 0x1f03da450 0x10060a668 0x1031e7840 0x1031e8de4 0x1031f6a94 0x1ef8fa1bc 0x1ef8f5084 0x1ef8f45b8 0x1f1b68584 0x21c8b8bc8 0x10062b22c 0x1ef3b4b94)
libc++abi.dylib: terminating with uncaught exception of type NSException
I still need your help. Because I run your demo, ADCIOSVisualizer. Then touch V1.2 -> Scenarios -> FlightDetails.json. It will crash. The crash is the same as my project.
Project: ADCIOSVisualizer
Platform: iOS
Version of SDK：2.3.1 from CocoaPods


Changed calicoctl version command per issue #5260

Print calicoctl version with exit success when no config is present
Description

Hi all,
I have changed the implementation of the calico version command as requested in issue #5260.
The error happens because the underlying implementation tries to fallback to loading the config from environment and ends up defaulting to kubernetes datastore when detecting it. Because of this, k8s backend tries to build a client and returns errors.ErrorDatastoreError. Therefore, the approach was to check the error type and print a message when this error occurs. Since no one can guarantee that other states will not give the same error, a log.Debugf call with the error message was added for easier debugging in the future if needed.
This change should not affect any other component other than calicoctl version and I tried to cover only the case which was described in the linked issue. The change was tested manually and seems to work well. No corresponding unit tests for this change were added.
This is how calicoctl version looks without config:
$ ./calicoctl-linux-amd64 version
Client Version:    v3.22.0-0.dev-24946-gca67e1513bf2
Git commit:        ca67e1513
Unable to detect installed Calico version

$ ./calicoctl-linux-amd64 -l debug version
INFO[0000] Log level set to debug
Client Version:    v3.22.0-0.dev-24946-gca67e1513bf2
Git commit:        ca67e1513
INFO[0000] Config file: /etc/calico/calicoctl.cfg cannot be read - reading config from environment
DEBU[0000] Datastore type isn't set, trying to detect it
DEBU[0000] No EtcdEndpoints specified, defaulting to kubernetes.
DEBU[0000] No kubeconfig file at default path, leaving blank.
INFO[0000] Loaded client config: apiconfig.CalicoAPIConfigSpec{DatastoreType:"kubernetes", EtcdConfig:apiconfig.EtcdConfig{EtcdEndpoints:"", EtcdDiscoverySrv:"", EtcdUsername:"", EtcdPassword:"", EtcdKeyFile:"", EtcdCertFile:"", EtcdCACertFile:"", EtcdKey:"", EtcdCert:"", EtcdCACert:""}, KubeConfig:apiconfig.KubeConfig{Kubeconfig:"", K8sAPIEndpoint:"", K8sKeyFile:"", K8sCertFile:"", K8sCAFile:"", K8sAPIToken:"", K8sInsecureSkipTLSVerify:false, K8sDisableNodePoll:false, K8sUsePodCIDR:false, KubeconfigInline:"", K8sClientQPS:0, K8sCurrentContext:""}}
DEBU[0000] Using datastore type 'kubernetes'
DEBU[0000] Client config error: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
Unable to detect installed Calico version

Let me know what you think.
Related issues/PRs

Issue #5260
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/sem-approve


feat(oracle): introduce new events

Add events that can be used to track the following metrics for each validator:

number of wins
number of misses
number of abstains
number of slashes
reward

Need to be able to compare validator performance. A staker in the front-end could elect to delegate to a smaller validator with more consistent oracle performance/income
THe current QueryServer.MissCounter only reveals misses but not wins or abstains
Rewards likely separate event


File path is incorrect!

I have a file that is quite obviously there, locally, and it keeps saying it's not there, regardless of whether the path is in quotes or not...manually typed or not, etc.

if you have the tool in the download folder, also put the epub file there and press enter


Chrome fails to start on Docker for macOS

I'm using the gotenberg:8 docker image  (but also tested with 7 images) and I consistently get a 500 error when running something like this:
curl --request POST 'http://localhost:10000/forms/chromium/convert/url' \
--form 'url="https://sparksuite.github.io/simple-html-invoice-template/"'
Internal Server Error

The logs produced are quite cryptic:
gotenberg-1  | {"level":"error","ts":1707220350.6079977,"logger":"api","msg":"convert URL to PDF: convert to PDF: process first start: start process: run exec allocator: context canceled","trace":"761c3461-22f1-4518-b1e9-2f35d9320bc1","remote_ip":"<IP_ADDRESS>","host":"localhost:10000","uri":"/forms/chromium/convert/url","method":"POST","path":"/forms/chromium/convert/url","referer":"","user_agent":"curl/8.4.0","status":500,"latency":1353376793,"latency_human":"1.353376793s","bytes_in":208,"bytes_out":21}

I figured the problem has to do with the "Use Virtualization framework" in Docker Desktop for macOS. Disabling that feature makes gotenberg work again. I'm on a x86 mac.
I don't think this is a bug in the gotenberg project, but maybe it could provide a better error message and the documentation could mention this workaround.
This issue is likely the cause of the problem: https://github.com/docker/for-mac/issues/6824

Thanks for the details @jgimenez!

Documentation has been updated 👍


add kernel connection sys info string

For #9132

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #10236 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master   #10236      +/-   ##
==========================================
- Coverage   61.23%   61.22%   -0.01%
==========================================
  Files         567      567
  Lines       30862    30868       +6
  Branches     4432     4433       +1
==========================================
+ Hits        18898    18899       +1
- Misses      10981    10986       +5
  Partials      983      983

Impacted Files
Coverage Δ

.../datascience/interactive-common/interactiveBase.ts
16.64% <0%> (-0.11%)
:arrow_down:

...ience/interactive-common/interactiveWindowTypes.ts
100% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
95.28% <100%> (+0.01%)
:arrow_up:

src/client/common/utils/platform.ts
70.58% <0%> (-5.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9615a...5deeb3b. Read the comment docs.


Random app closure as i watch videos/scrub videos

Steps to reproduce
I am not exactly sure what is causing it, and I am not sure how to recreate it, but I noticed that it happens when I watch a video till the end and then press the next button to move onto the next episode as well as sometimes skipping/scrubbing the video, it randomly closes after watching a number of episodes. I feel it is a player issue.
Also, the external player option causes the app to crash.
Expected behavior
The player should be able to scrub and change episodes without crashing/forcfully closing.
Actual behavior
The app forcefully closes without showing the screen that normally shows when the app crashes (like when trying to play a video through the external player option). When tried the universal (large sized apk) of the Aniyomi Preview, it would show a dialog popup after it cforcefully closes that says there is a bug in the app and that I should wait for an update to fix it. But since I moved to the apk for my phone (i think arm 8a or something) the dialog doesn't show up anymore.
Crash logs
aniyomi_crash_logs.txt
Searching the logs by date and time, the recent crash can seen at 09-26 @ time: 23:27
Aniyomi version
0.14.3-6151 (Aniyomi Preview R6151)
Android version
12 (SDK 31)
Device
Samsung Galaxy Note 10+ 5g (SM-N976B)
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Should be fixed


Sane doc reports

Status
Ready
Related Issues
https://github.com/demisto/dockerfiles/pull/1836
Description
Trying to fix master and have a specific version.

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/sane-doc-reports:<IP_ADDRESS>81
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/sane-doc-reports/tags
Get started by pulling the image:
docker pull devdemisto/sane-doc-reports:<IP_ADDRESS>81

Docker Metadata

Image Size: 360.74 MB

Image ID: sha256:8bce710202743cfe2062edd49b60cb454609c0f712da1f1689c46a110c270f04

Created: 2020-06-16T16:40:16.998858599Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.8.3
PYTHON_PIP_VERSION=20.1.1
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/eff16c878c7fd6b688b9b4c4267695cf1a0bf01b/get-pip.py
PYTHON_GET_PIP_SHA256=b3153ec0cf7b7bbf9556932aa37e4981c35dc2a2c501d70d91d2795aa532be79
DOCKER_IMAGE=devdemisto/sane-doc-reports:<IP_ADDRESS>81

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:149146b58032e305b5db5546fd99433430ad07b8
org.opencontainers.image.version:<IP_ADDRESS>81

Docker Image Ready - Production
Docker automatic build at CircleCI has deployed your docker image: demisto/sane-doc-reports:<IP_ADDRESS>08
It is available now on docker hub at: https://hub.docker.com/r/demisto/sane-doc-reports/tags
Get started by pulling the image:
docker pull demisto/sane-doc-reports:<IP_ADDRESS>08

Docker Metadata

Image Size: 360.74 MB

Image ID: sha256:6b24d78b300bb26d676434e5cf17ee28242c9e75578903e80f54b2e0b462ca29

Created: 2020-06-17T16:04:17.840422015Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.8.3
PYTHON_PIP_VERSION=20.1.1
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/eff16c878c7fd6b688b9b4c4267695cf1a0bf01b/get-pip.py
PYTHON_GET_PIP_SHA256=b3153ec0cf7b7bbf9556932aa37e4981c35dc2a2c501d70d91d2795aa532be79
DOCKER_IMAGE=demisto/sane-doc-reports:<IP_ADDRESS>08

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:9b43f24b07a7564e23a364f7ff00b22b5d9ce9e7
org.opencontainers.image.version:<IP_ADDRESS>08


Question: Using IdentityServer4 UI/login and ClaimsPrincipal

Hello,
Actually I have 2 questions:

I am using IdentityServer4 Core (.NET Framework 4.6.2) and I have implemented User, Client and Scope persistence in MongoDB. I can successfully issue tokens for my API (Core.NET Framework 4.6.2) and everything works as expected. I put a breakpoint in my API HotelController and I can see in Locals under this, HttpContext, User, Claims my Claims and also the client, scope etc (see image below)

When I look ClaimsPrincipal.Current (same level as this above) in locals I don't see my claims...

Is this how it is supposed to be?

When I use the same credentials at the the UI/login page to login to the IdentityServer:

I put a breakpoint at my login controller and I can see in locals that user and claims have my claims:

but when I put a trace in LoginController's Index and look at Autos I see that CurrentPrincipal's claims are empty

Is this it is supposed to be this way?
Here is my LoginController Index action:
    [HttpPost(Constants.RoutePaths.Login)]
    [ValidateAntiForgeryToken]
    public async Task<IActionResult> Index(LoginInputModel model)
    {
        if (ModelState.IsValid)
        {
            if (_loginService.ValidateCredentials(model.Username, model.Password))
            {
                var user = _loginService.FindByUsername(model.Username);

                var claims = new Claim[] {
                    new Claim(JwtClaimTypes.Subject, user.Id.ToString()),
                    new Claim(JwtClaimTypes.Name, user.Username.Value),
                    new Claim(JwtClaimTypes.IdentityProvider, "AuthServer"),
                    new Claim(JwtClaimTypes.AuthenticationTime, DateTime.UtcNow.ToEpochTime().ToString()),
                    new Claim(JwtClaimTypes.Role, Enum.GetName(typeof(Role), user.Role))
                };
                var ci = new ClaimsIdentity(claims, "password", JwtClaimTypes.Name, JwtClaimTypes.Role);
                var cp = new ClaimsPrincipal(ci);

                await HttpContext.Authentication.SignInAsync(Constants.PrimaryAuthenticationType, cp);

                if (model.SignInId != null)
                {
                    return new SignInResult(model.SignInId);
                }
                System.Diagnostics.Trace.Write(ClaimsPrincipal.Current);
                return Redirect("~/");
            }

            ModelState.AddModelError("", "Invalid username or password.");
        }

        var vm = new LoginViewModel(model);
        return View(vm);
    }

I want to use the IdentityServer UI to add CRUD functionality for Users, Clients and scopes.
I am using a DDD onion structure in my Solution and I have Domain, Application, Infrastructure and API layers (IdentityServer is in this layer).

User in my solution is a Domain object while Clients and Scopes are the ones from IdentityServer.
All of them persisted to MongoDB.
Here is how I assign my User domain object properties to the corresponding claims in ProfileService (UserService is in my Application layer):

and here is my AuthServer's (IdentityServer4) Startup.cs:
using System.IO;
using System.Security.Cryptography.X509Certificates;
using AuthServer.Initializations;
using AuthServer.Repositories.Implementations;
using AuthServer.Repositories.Interfaces;
using AuthServer.Services;
using AuthServer.Services.Implementations;
using IdentityServer4.Models;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using IdentityServer4.Services;
using IdentityServer4.Validation;
using MongoDB.Bson.Serialization;
using Services.Implementations.Users;
using Services.Interfaces.Users;
using CustomGrantValidator = AuthServer.Extensions.CustomGrantValidator;
namespace AuthServer
{
public class Startup
{
private readonly IHostingEnvironment _environment;
    public Startup(IHostingEnvironment env)
    {
        BsonClassMapper.BsonClassMaps();
        //Initializations.Initializations.CreateClients();
        //Initializations.Initializations.CreateScopes();
        _environment = env;
    }

    // This method gets called by the runtime. Use this method to add services to the container.
    // For more information on how to configure your application, visit http://go.microsoft.com/fwlink/?LinkID=398940
    public void ConfigureServices(IServiceCollection services)
    {
        var cert = new X509Certificate2(Path.Combine(_environment.ContentRootPath, "Files\\identityserver.pfx"), "******************");

        var builder = services.AddIdentityServer()
            .SetSigningCredentials(cert);

        builder.Services.AddTransient<IUserService, UserService>();
        builder.Services.AddTransient<IClientRepository, ClientRepository>();
        builder.Services.AddTransient<IScopeRepository, ScopeRepository>();
        builder.Services.AddTransient<IClientStore, ClientStore>();
        builder.Services.AddTransient<IScopeStore, ScopeStore>();
        builder.Services.AddTransient<IProfileService, ProfileService>();
        builder.Services.AddTransient<IResourceOwnerPasswordValidator, ResourceOwnerPasswordValidator>();
        builder.AddCustomGrantValidator<CustomGrantValidator>();

        // for the UI
        services
            .AddMvc()
            .AddRazorOptions(razor =>
            {
                razor.ViewLocationExpanders.Add(new UI.CustomViewLocationExpander());
            });
        services.AddTransient<UI.Login.LoginService>();
    }

    // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
    public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory)
    {
        loggerFactory.AddConsole(LogLevel.Trace);
        loggerFactory.AddDebug(LogLevel.Trace);

        app.UseDeveloperExceptionPage();

        app.UseCookieAuthentication(new CookieAuthenticationOptions
        {
            AuthenticationScheme = "Temp",
            AutomaticAuthenticate = false,
            AutomaticChallenge = false
        });

        //app.UseGoogleAuthentication(new GoogleOptions
        //{
        //    AuthenticationScheme = "Google",
        //    SignInScheme = "Temp",
        //    ClientId = "434483408261-55tc8n0cs4ff1fe21ea8df2o443v2iuc.apps.googleusercontent.com",
        //    ClientSecret = "3gcoTrEDPPJ0ukn_aYYT6PWo"
        //});

        app.UseIdentityServer();

        app.UseStaticFiles();
        app.UseMvcWithDefaultRoute();
    }
}

}
I watched Dominick's courses in Pluralsight (Introduction to Identity and Access Control in .NET 4.5  and Identity and Access Control in ASP.NET 4.5) although my projects are in 4.6.2.
Can someone please help me clear things out regarding ClaimsPrincipal in both questions above?
Should I explicitly set the ClaimsPrincipal.Current Claims equal to my User's claims?
Thank you.

I wouldn't use claimsprincipal.current anymore.
Sent from my iPad

On 30 Jun 2016, at 22:38, Kouloukos<EMAIL_ADDRESS>wrote:
Hello,
Actually I have 2 questions:

I am using IdentityServer4 Core (.NET Framework 4.6.2) and I have implemented User, Client and Scope persistence in MongoDB. I can successfully issue tokens for my API (Core.NET Framework 4.6.2) and everything works as expected. I put a breakpoint in my API HotelController and I can see in Locals under this, HttpContext, User, Claims my Claims and also the client, scope etc (see image below)
When I look ClaimsPrincipal.Current (same level as this above) in locals I don't see my claims...
Is this how it is supposed to be?

When I use the same credentials at the the UI/login page to login to the IdentityServer:
I put a breakpoint at my login controller and I can see in Autos that user and claims have my claims
but here again CurrentPrincipal claims are empty
Is this it is supposed to be this way?
Here is my LoginController Index action:
[HttpPost(Constants.RoutePaths.Login)]
[ValidateAntiForgeryToken]
public async Task Index(LoginInputModel model)
{
if (ModelState.IsValid)
{
if (_loginService.ValidateCredentials(model.Username, model.Password))
{
var user = _loginService.FindByUsername(model.Username);
            var claims = new Claim[] {
                new Claim(JwtClaimTypes.Subject, user.Id.ToString()),
                new Claim(JwtClaimTypes.Name, user.Username.Value),
                new Claim(JwtClaimTypes.IdentityProvider, "AuthServer"),
                new Claim(JwtClaimTypes.AuthenticationTime, DateTime.UtcNow.ToEpochTime().ToString()),
                new Claim(JwtClaimTypes.Role, Enum.GetName(typeof(Role), user.Role))
            };
            var ci = new ClaimsIdentity(claims, "password", JwtClaimTypes.Name, JwtClaimTypes.Role);
            var cp = new ClaimsPrincipal(ci);

            await HttpContext.Authentication.SignInAsync(Constants.PrimaryAuthenticationType, cp);

            if (model.SignInId != null)
            {
                return new SignInResult(model.SignInId);
            }
            System.Diagnostics.Trace.Write(ClaimsPrincipal.Current);
            return Redirect("~/");
        }

        ModelState.AddModelError("", "Invalid username or password.");
    }

    var vm = new LoginViewModel(model);
    return View(vm);
}

I want to use the IdentityServer UI to add CRUD functionality for Users, Clients and scopes.
I watched Dominick's courses in Pluralsight (Introduction to Identity and Access Control in .NET 4.5 and Identity and Access Control in ASP.NET 4.5) although my projects are in 4.6.2.
Can someone help me clear these things out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you Dominick for the quick reply...
What do you think about my setup? Is everything correct regarding my IdentityServer's settings?
(Hahaha I am also watching Euro 2016 POLAND-PORTUGAL,  penalties)

these are all not issues with idsrv - please use SO for general questions. thanks!

@leastprivilege hi can you share with me how you have provided clients, users and scopes through the database because I am struggling with that, Your help in this regard would be much appreciated.
thank you


WIP persist tab state

This is just some tinkering to resolve https://github.com/slackhq/circuit/issues/116 and after talking with @bryanstern. Wanna iterate on this more and see if we can make this simpler, and also possibly explore implementing an analogous RetainedStateHolder.
Another thing this highlights is the fact that we always initially show a progress indicator even when restoring from a loaded state, wonder what we can do to improve that.
https://github.com/slackhq/circuit/assets/1361086/f1e0af59-aa58-4844-8443-f03b5a3ed97d

Sadly this did not Just Work when I converted to retained, gonna keep digging

It doesn't work in this PR's case because content is all swapped inside the tab pager. As far as the backstack's concerned, they're all just one screen (HomeScreen)
It actually does work, I just forgot the UI state that we see here is mostly all rememberSaveable from compose UI.


SHACL - race condition with jdk11 when using multiple threads to access a shacl sail

With reference to the email from Bart there is a failing test that tests for race conditions.
org.eclipse.rdf4j.sail.shacl.MultithreadedTest#testDataAndShapes
We should try to figure out

if this is only an issue when using parallel shacl validation?
if this is an issue with the shacl sail, with one of the added/removed repos or with the base sail

And also try to make it more reproducable!

This seems to be happening against the base sail. So it makes sense that it only happens when using parallel validation (since this shares a single connection from the base sail between multiple threads).

It doesn't seem to happen with IsolationLevels.NONE.

Next step is to try to figure out where the read locks are being taken.

Also, even after 8 hours the test still hangs!

Well, I guess it will hang forever: a back-off mechanism is being used, each time doubling the interval between  attempts ...

this seems like it might be caused by my read/write lock stuff directly in the shacl sail

It's definitively in the shacl code. Looks like there is some code that isn't releasing a read lock.....but I can't figure out where. I might instead end up switching to the lock manger instead.

This seems very odd. All the work threads from the common pool have single stacks except for this thread here that has two stacks.

The top stack [2] is waiting for a lock that the bottom stack has acquired. I have never seen anything like this before!

Related to #1148

Maybe we should go ahead and deactivate parallel validation while I get this sorted.
I have tried switching from stamped locks to the RDF4J common locks. It still hangs.
Next is to use a custom thread pool. Maybe for the test rather than for the actuall validation.


Fixes padding issue

Came across this earlier when browsing the webtorrent desktop page:

I believe what was intended was:

Edit: The problem seems to be browser specific as I use iceweasel. On most other devices it may render normally. Either way, the proposed PR shouldn't affect what currently works.

Nevermind

Why was this closed?


feat(timepicker): add templateUrl and controllerAs support

Add support for overriding the templateUrl on an instance by instance basis
Expose controller via controllerAs

addresses #4275

That is good to go sir.


Integrate with Nextcloud and Owncloud and Webdav

For those of us wanting to self-host our filesharing along with this sweet music server. :)
Nextcloud - Fully open source file sharing
Owncloud

If you have your files on your own server, you can run Koel already :)

There are still times when this would be useful:

You don't own the Nextcloud instance or your want to run Nextcloud on a different server than Koel.
You have server-side encryption enabled for Nextcloud.