FPU Operation

Hello There,
I have one fundamental question. In the Github repo:  https://github.com/bespoke-silicon-group/bsg_replicant/blob/master/regression/cuda/test_float_all_ops.c
Line no 50-64, the function  host_float_all_ops(...) is called as expected result at line no 391 but the actual results are coming from res_add_host, res_sub_host, res_mul_host, res_div_host, etc. May I ask where do we set-up host fpu operation for add, sub, mul, div, etc. since  host_float_all_ops(...) is the expected result? I am unable to figure-out in the source code perhaps I am missing something.
Many Thanks,
-Vijay

I believe @bornaehsani wrote this test. He should be able to answer your question

@bornaehsani I guess to set-up FPU operation for host FPU  one can set in the directory bsg_manycore/software/spmd/bsg_cuda_lite_runtime/ with respective applications For example  test_float_all_ops.c in the directory  bsg_replicant/regression/cuda/
gets host FPU result from bsg_manycore/software/spmd/bsg_cuda_lite_runtime/float_all_ops/ ? Please correct if I am wrong, Makefile in bsg_manycore/software/spmd/bsg_cuda_lite_runtime/float_all_ops/ is written for VCS co-simulation not for F1 execution?  If it is written for F1 execution, please let me know how to run Make.
Many Thanks,
-Vijay

This test is making sure that the FPU on the manycore is producing correct results. We define "correct" results as those matching some other FPU that we trust is correct. In this case, we trust the FPU on the host processor.
So this test:
Allocates input and output arrays on the device (i.e. the manycore), copies input values, runs the kernel defined in bsg_manycore/software/spmd/bsg_cuda_lite_runtime/float_all_ops/kernel_float_all_ops.c on the manycore, then copies the results back to the host. The host then performs the same operations on its own (in host_float_all_ops) and then compares the results. The host FPU does not require any setup.
We do expect some small error between the two, but as long as the error is within a threshold we define, the test will pass.
In regards to running on F1, after mounting the AGFI for the manycore, you should be able to go into bsg_replicant/regression/cuda and run sudo make test_float_all_ops.log, and it will run the test.

Hi @vijayholimath . So as @save-buffer has explained, the host_float_all_ops() is purely to make sure the results we get back from the device are correct. As the purpose of the regression tests are to in fact verify the correctness of the Manycore operations, we perform the same computation on both host (in this case host_float_all_ops() ) and the device (the actual kernel that is run), and then compare the results. As to your question regarding setting up the FPU operations in the host, I don't completely understand what you mean. There is no setup necessary for running FPU operations on the host, the entire host code located inside bsg_bladerunner/bsg_replicant/regression/cuda runs on the X86 host, including the host_float_all_ops(). The only setup necessary is for the device code. Does that answer your question?

Thanks for the clarification save-buffer and bornaehsani. Actually, I want to run only certain operations of my choice, let's say, three operations, add, mul and float to int. How do I run make on F1? I did comment out certain operations which are not of interest in both directory source codes:
bsg_replicant/regression/cuda/test_float_all_ops.c line no. 56- 61
bsg_manycore/software/spmd/bsg_cuda_lite_runtime/float_all_ops/kernel_float_all_ops.c line 27-39
In bsg_replicant/regression/cuda/tests.mk I commented out all tests except  test_float_all_ops (line no 68)
then I ran "make regression" in bsg_replicant/regression/cuda/ directory after loading AGFI, I am still seeing results from host FPU operations which are not interest to me.  I am using BSG repo version 3.5.2.
By the way, we have our own RISC-V compiler and we want to compile the codes using our compiler. I think the file to point one's own compiler is at:  bsg_manycore/software/mk/Makefile.builddefs line no. 58-63?
I think default tile is set to 2X2 where do I set tile numbers? I think maximum one can tile is up to 256X256 since the HammerBlade supports up to 512 cores?
Many Thanks,
-Vijay

The results of the operations are printed in this loop. You can skip operations that do not interest you. Alternatively, you could restructure the code by removing the operations from the operations array that you don't need, remove them from both host_float_all_ops and kernel_float_all_ops, and remove the allocations and copying of the input/output arrays.
bsg_manycore/software/mk/Makefile.builddefs lines 58-63 are correct for modifying the compiler you're using.
What do you mean by "setting tile numbers"? If you mean changing the dimensions of the manycore array, I believe you would have to recompile the manycore and create a new AGFI. I'm not sure how to do that, that's @drichmond's area of expertise. If you're interested in remapping the tile indices in a tilegroup to different physical tiles than the default, this is not supported. Also, 256x256 would be a 65536-tile manycore array. I'm not sure an F1 FPGA could hold that many.

Thanks save-buffer..:) Sorry I meant changing the dimensions of many core array. Dustin, can you please tell me where to change tile dimension of many core array? I plan to change different configurations such as 10X10, 20X20, etc. I think it is some where in *.v code as a parameter and re-compile the code and generate AGFI to new dimensions. Apart from that, I think one has to change some where in software to initialise the devices?

Hi @drichmond,  I think many array dimensions can be changed at: bsg_manycore/syn/Makefile.dc from line  no. 52-53? And one may need to change other parameters as well from line no. 47-54? How about in software, do we need to change some where for memory initialisation and others?
Thanks,
-Vijay

Hi Vijay, Dustin is on vacation, I think @vb000 has experience with building the AGFI with desired parameters. Bandhav do you know how to build custom AGFI? Thanks!

Hi @vijayholimath, I had built agfi quite a while back per Dustin's instructions, now concisely captured in bsg_bladerunner's RELEASE.md.
That looks up-to-date, could you try it out and let us know specific questions, if any?

Hello @vb000, I can sucessfully build AFI and AMI, I don't have issue with that. My question is rather, where to change manycore dimension array and rebuild AFI? I think now the array is set to 2X2, I would like to change to different configurations such as 10X10, 15X15, etc

All machine configuration is sourced from a file called Makefile.machine.include and that's here:
https://github.com/bespoke-silicon-group/bsg_replicant/blob/master/Makefile.machine.include
Could you try changing here?

Hello @save-buffer or @bornaehsani or any FP experts, I sucessfully replaced my arithmetic units with FP add, FP mul, int to float and float to int in fpu_float.v and fpu_int.v. Now, all cuda floating point test works fine such as test_float_vec_*.c where * here is add, mul, div, sqrt, etc. except log and exp is not working. If I try to run for test_float_vec_exp and test_float_vec_log, regression get stuck. Since div, sqrt, log, exp, etc. are FP subroutines (written in assembly). I am not getting how to debug exp and log functions, any suggestions?

Does your toolchain build spike? If so, you could write an assembly test that runs on a single tile and compare the intermediate results of emulated FP functions in the trace, with those in spike's trace.

@vb000, thanks for the file.  But in https://github.com/bespoke-silicon-group/bsg_replicant/blob/master/Makefile.machine.include I don't see any parameter which is set to 2, I mean something like num_x_tiles:= 2,  num_y_tiles:= 2, which matches with 2X2 tile description. Perhaps I am missing something? Or you mean by default this is set to 4X5, line no. 28 and 29?

Yes, BSG_MACHINE_GLOBAL_X and BSG_MACHINE_GLOBAL_Y are what might be interested in... default is 4x4 machine (BSG_MACHINE_GLOBAL_Y also includes IO on the top row of the grid).

Yes @vb000  the toolchain does support 'spike'. Unfortunately, I don't know much about spike and how to write test for spike and compare results. Any guidance much appreciated...:)

Spike is RISC-V ISA simulator which you could you to simulate RISC-V executables. If you have RISC-V executable like prog.riscv, it can be executed on spike by spike prog.riscv. You could find a usage tutorial here: https://github.com/riscv/riscv-isa-sim.
A crazy thought for FPU debugging:
Is it possible to add some non-synthesizable logic to your FPU that checks the result result of your FPU with that of x86. May be something like:
logic [31:0] my_result;
my_fpu_mul(.a_i(a), .b_i(b), .y_o(my_result));

// synopsys translate_off
assert (my_result == a * b);
// synopsys translate_on

My experience has been that our FPU's result should match x86 result exactly (bitwise), unless we make a conscious decision to deviate from the FP standard slightly. In which case, you could modify the assert accordingly.

Thanks @vb000. I did add some logic to our arithmetic circuits and debugged using ila probes and checked on the board in cloud with that of x86 FPU. In our case, results deviate from x86 FPU and this is expected because we have different number system other than IEEE-754 floating point number system.
I was checking BSG repo, spike is defined in https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/mk/Makefile.builddefs in line no. 63 and each cuda test cases such as for exp in https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/spmd/bsg_cuda_lite_runtime/float_vec_exp/Makefile  in line no. 30 generates it's own main.riscv  But I haven't  found it's usage in BSG repo. Perhaps I might have overlooked? If you could tell me usage or executing for example or add in BSG repo float_vec_exp test case that will be great?  Actually, I am looking for instruction by instruction of exp function in FP subroutine so that it is easier to point-out where test is getting stuck..:)
Many thanks.

I think BSG HammerBlade don't  have opcodes for FP sqrt, div, exp and log because these functions are not coded in BSG_FPU rather they are soft FP subroutine. In other words, these functions are taken care by RISC-V C/C++ compiler as a fplib.so I think. So I think using 'Spike' I don't think it is useful for instruction level debugging?

I think BSG HammerBlade don't have opcodes for FP sqrt, div, exp and log because these functions are not coded in BSG_FPU rather they are soft FP subroutine. In other words, these functions are taken care by RISC-V C/C++ compiler as a fplib.so I think. So I think using 'Spike' I don't think it is useful for instruction level debugging?

Compile the spike binary with the same options you use for compiling the binary for manycore, I think it's -mno-fdiv and more... this makes sure compiler use emulated instructions.

Sorry I am not clear. Yes in BSG repo mno-fdiv swith is off as the makefile line no. 32 in: https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/riscv-tools/Makefile
Since fdiv, fexp, etc. are off these instructions are emulated. But my question was how to debug for emulated instructions? I am not clear in spike, as you know spike requires opcodes, but in RISC-V instruction I haven't found instruction and opcode for fexp and flog under 'RV32F Standard Extension' as per the manual page 106 in: https://content.riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf

Hi, in order to add a custom instruction (flog, fexp) to spike, take a look at https://github.com/riscv/riscv-isa-sim/blob/master/README.md#simulating-a-new-instruction.
To compile a program with the new instructions (without modifying the compiler toolchain), you can use inline assembly in the program to emit raw bytes which correspond to your custom encoding. To add fdiv/fsqrt instructions simply remove the corresponding flags from the compilation command in the Makefile.

you can use inline assembly in the program to emit raw bytes which correspond to your custom >encoding. To add fdiv/fsqrt instructions simply remove the corresponding flags from the >compilation command in the Makefile.

It would be great if you could send me example code and Makefile for fexp?

Use the same binary with both spike and manycore. Then, if an instruction is emulated for manycore, it'll be emulated for spike as well.
Comparing traces can be quite a bit of work as manycore and spike binaries won't match exactly (the part of emulated instructions would match exactly though). Consider writing assertions in verilog that does fp bitwise matching for you.

All machine configuration is sourced from a file called Makefile.machine.include and that's here:
https://github.com/bespoke-silicon-group/bsg_replicant/blob/master/Makefile.machine.include
Could you try changing here?

This is the correct method for changing the AGFI/AFI dimensions.

I was working on spike, I think it would make sense if you add new instruction but I think fexp is not an instruction rather it is a fp subroutine algorithm. In other words, whenever fexp is found in assembly code/source code, the compiler would  then call fexp algorithm not an fexp instruction?

BTW, in https://github.com/bespoke-silicon-group/bsg_replicant/blob/master/Makefile.machine.include line 29 (BSG_MACHINE_GLOBAL_Y                  = 5) why it is 5? I was under impression that AGFI/AFI dimensions always in terms of square, for example 4X4, 5X5, 6X6, etc. Perhaps I misunderstood something?

Because that's the size of entire machine, including IO and memory routers.
If you want the dimensions of the manycore array:
CL_MANYCORE_DIM_Y                    := $(shell expr $(BSG_MACHINE_GLOBAL_Y) - 1)

OK, got it. But whenever I run cuda regression test (make regression) in bsg_replicant/regression/cuda/ I get BSG_INFO test is running on 2X2 tile group but I think  currently it is set to 4X5 as per: https://github.com/bespoke-silicon-group/bsg_replicant/blob/master/Makefile.machine.include
Could you please help me to understand?

There is a distinction between the size of the manycore and a tilegroup: The size of the manycore is the number of physical cores. A tilegroup is an abstraction on top of that that gives your kernel the illusion that it's running on its own manycore array. Several tilegroups can execute in parallel. For example, if you have a 4x4 manycore, you could run four kernels that run in a 2x2 tilegroup at the same time.
If you are familiar with CUDA terminology, one tile in a tilegroup is analogous to a thread and a tilegroup is analogous to a block.

Thank you very much @save-buffer ..:)

@vb000 or any FP experts.  I was working on spike, I think it would make sense if you add new instruction but I think fexp is not an instruction rather it is a fp subroutine algorithm. In other words, whenever fexp is found in assembly code/source code, the compiler would then call fexp algorithm not an fexp instruction?

Since exponential and logarithmic functions are  fp subroutines in bsg RISC-V compiler tool chain, I have to accept it is not possible to debug fp subroutines. Unless, if we add custom instruction and modify compiler to support custom instruction.  Please correct me if I am wrong?

Use the same binary with both spike and manycore. Then, if an instruction is emulated for manycore, it'll be emulated for spike as well.
Comparing traces can be quite a bit of work as manycore and spike binaries won't match exactly (the part of emulated instructions would match exactly though). Consider writing assertions in verilog that does fp bitwise matching for you.

^^^ You could debug emulated instructions (fp subroutines in toolchain) this way.

Thanks @vb000..:) I will try. Off the the FPU Operation thread, I have a question regarding AMI. After creating AMI and launching AMI instance, I am not clear about usage of the launched AMI instance. I think any c/cpp applications can  be written using BSG API  without including concerned header files because they are hidden in AMI kernel? It will be great if you could educate me on usage of AMI instance.

Just wondering, at what frequency bladerunner running on F1 instance?

125 MHz - the default.

We haven't spent any time optimizing it so that is not a maximum frequency.

Got it. Would bladerunner architecture suitable for mobile devices?

Hello All,
I just recompiled design in AWS with no modification, it taking more than 9 hours  synthesise and implement the design. After 9 hours it is still in synthesis step!  About couple of months ago, the same design took only 5 hours to synthesise and implement the design.  I am unable to figure-out what's happening, why recompiling taking longer time. Any suggestions?
Many Thanks.

Hi @vijayholimath
I don't have any specific suggestions. We haven't made any major changes to the hardware in the last couple of months, and last time I compiled it took a few hours (not overnight/9 hours).

I solved the problem...:) The issue is, if I use latest version of FPGA developer AMI: 1.8.0, it takes very long time to synthesize but with FPGA developer AMI: 1.7.0 it takes only about 5 hours. This is strange, I think in the latest version the design might be optimising for frequency. By the way, by any chance, do you have ASIC implementation report for latest technology node say, 7nm or 10nm or any other nodes?

Hello All,
I did very minute changes in /bsg_bladerunner/bsg_manycore/software/spmd/bsg_cuda_lite_runtime/scalar_print/  and
/bsg_bladerunner/bsg_manycore/software/spmd/fib I am trying to regenerate main.riscv, bsg_set_tile_x_y.o and bsg_printf.o in respective directories  by running 'make regression' in  bsg_f1/regression/spmd and running 'sudo make install'  and 'make build' in bsg_f1/libraries. Unfortunately, I am unable to regenerate these files, I mean these files are not updating. Can you please let me know how to update these files? I am using FPGA Image Version: 3.5.2
Many Thanks,
-Vijay

Does BSG manycore/F1 support OpenCL?

No, it currently only supports only our CUDA Lite programming model.

Hmmm, I think supporting OpenCL is not so complicated. I would very much like to support it, unfortunately it is very much architecture dependent and I don't have much knowledge on BSG many core architecture. I think your team can finish OpenCL project in a week since you people are experts....:)

It's not a priority for us. It sounds like it might be for you. Aren't you interested in learning more about our architecture?

I am learning BSG bladerunner architecture and it is quite interesting architecture. Unfortunately, I do not have much human resource and it will take lot of time in my case...:)

Thanks for your suggestion Vijay! Maybe one day somebody will contribute a
port!
On Thu, Jun 11, 2020 at 6:42 PM vijayholimath<EMAIL_ADDRESS>wrote:

I am learning BSG bladerunner architecture and it is quite interesting
architecture. Unfortunately, I do not have much human resource and it will
take lot of time in my case...:)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bespoke-silicon-group/bsg_replicant/issues/519#issuecomment-643017910,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5AG2VOHVBIE2YND6MMLRWGBW7ANCNFSM4LCVFGCQ
.

Sure, Michael...:) Many Thanks!

Hello All,
Can you please tell me how you generated riscv32-unknown-elf-dramfs-c++ , riscv32-unknown-elf-dramfs-ar, riscv32-unknown-elf-dramfs-gcc , etc. which are in bsg_manycore/software/riscv-tools/riscv-install/bin?  I think you used github repo which is mentioned in bsg_manycore/software/riscv-tools/Makefile as a NEWLIB_URL and in some other makefiles as well  as a cloned github repo. But other than this there is no directory named "bsg_newlib_dramfs" in the project.  The reason why I am asking these details because we have our own compiler we want to generate our own riscv32-unknown-elf-dramfs-c++ , riscv32-unknown-elf-dramfs-ar, riscv32-unknown-elf-dramfs-gcc , etc.
Many Thanks,
-Vijay

Hi Vijay —
bsg_newlib_dramfs is substituted for vanilla newlib here in the makefiles.
https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/riscv-tools/Makefile#L41
https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/riscv-tools/newlib.patch
It comes from our fork of newlib found here:
https://github.com/bespoke-silicon-group/bsg_newlib_dramfs
The cross-compile targets are set up to use this tuple, so you’ll have to replace it with your own:
https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/mk/Makefile.builddefs#L59

On Jun 15, 2020, at 5:33 AM, vijayholimath<EMAIL_ADDRESS>wrote:

Hello All,
Can you please tell me how you generated riscv32-unknown-elf-dramfs-c++ , riscv32-unknown-elf-dramfs-ar, riscv32-unknown-elf-dramfs-gcc , etc. which are in bsg_manycore/software/riscv-tools/riscv-install/bin? I think you used github repo which is mentioned in bsg_manycore/software/riscv-tools/Makefile as a NEWLIB_URL and in some other makefiles as well as a cloned github repo. But other than this there is no directory named "bsg_newlib_dramfs" in the project. The reason why I am asking these details because we have our own compiler we want to generate our own riscv32-unknown-elf-dramfs-c++ , riscv32-unknown-elf-dramfs-ar, riscv32-unknown-elf-dramfs-gcc , etc.
Many Thanks,
-Vijay
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thank you very much Dustin..:) I know above line numbers in Makefiles very well. But what I am unable to figure is, how bsg_newlib_dramfs is associated with building compiler. I use cross tool ng (https://crosstool-ng.github.io/) to build our compiler. Can you please tell me how I do associate https://github.com/bespoke-silicon-group/bsg_newlib_dramfs with crosstool-ng?

I think in crosstool-ng we need to apply this patch: https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/riscv-tools/newlib.patch while building compiler. Unfortunately, I don't know how to apply this patch. Any assistance highly appreciated. If you wish I can share config file for building in crosstool-ng? Many Thanks!

I am not sure, using this Makefile: https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/software/riscv-tools/Makefile one can download/obtain source codes for compilers and rebuild compiler after applying patches in source codes?

Hello @dpetrisko , @drichmond  and the team just to inform you, I solved the patching newlib.path to our compiler...:)  We need to build gfortran compliler as well, in $(RISCV_BIN_DIR), I did not find gfortran compiler may be this is because BSG project do not require this.
I think in order to build fortran compiler one need to enable switch  --enable--languages =c,c++,fortran. May I ask in which part of the Makefile your only enabling languages 'only c,c++' so that I can add extra fortran switch? I found this switch is used in lot of places in /riscv-gnu-tool-chain/Makefile, I could manually try enabling each places, since building compiler in our case takes more than 6 hours trying out all possible takes may be take more than 3 days. Since you people are experts, I thought I can ask you exact place to enable the fortran switch..:)  Many Thanks!

The makefile that builds the toolchain clones the official riscv-gnu-toolchain repo and configures and builds that. In this Makefile rule, you can see that the enabled languages are C and C++. stamps/build-gcc-newlib-stage2 is the rule that generates the final RISC-V compiler.

Thank you very much @save-buffer ...:)

@vb000 or the team, I want to use only one RISC-V core for testing purpose, I guess I need to change BSG_MACHINE_GLOBAL_X =1 and BSG_MACHINE_GLOBAL_Y =1 in bsg_f1/Makefile.machine.include? I guess there are no settings for software? I am using v3.5.2 bsg repo
Thanks,
-Vijay

Known issue: https://github.com/bespoke-silicon-group/bsg_manycore/issues/315

I changed BSG_MACHINE_GLOBAL_X =3 and BSG_MACHINE_GLOBAL_Y =2 but still synthesis is failing. Perhaps I am missing something?

I want to compile all programs in bsg_f1/regression/cuda and bsg_manycore/software/spmd/bsg_cuda_lite_runtime/float_vec_* to C++. I think I need to convert all files to *.cpp and then compile with CXX flag. I want to change flag CC to CXX somewhere in Makefiles. Can you please tell me where are those files to change the flag? I tried with grep command, I am getting lot of hits and I am running out of screen...:)


Simple file-based config store

Should be able to merge multiple configuration-files, thus, the config server will return a single JSON configuration object.

Closed by #231


<EMAIL_ADDRESS>breaks Nuxt frontend

Describe the bug
Using Nuxt in combination with visual-editing dependency from @nuxtjs/sanity breaks Nuxt frontend when visual editing is enabled via config:
    visualEditing: {
       token: process.env.NUXT_SANITY_VISUAL_EDITING_TOKEN,
       studioUrl: 'http://localhost:3333',
    },

Nuxt launches without errors, but the browser displays an error with react-compiler-runtime and interrupts JS execution, which also prevents visual editing from working properly.
Uncaught SyntaxError: The requested module '/_nuxt/node_modules/.pnpm/react-compiler-runtime@19.0.0-beta-df7b47d-20241124_react@18.3.1/node_modules/react-compiler-runtime/dist/index.js?v=4212c007' does not provide an export named 'c' (at mutations.js?v=4212c007:1:8)

react-compiler-runtime/dist/index.js actually exports c
//line 320
exports.c = c;

To Reproduce

Install fresh Nuxt Project
Add @nuxtjs/sanity
Add missing react dependency:  pnpm add react-is@latest
Add needed @sanity/visual-editing (otherwise nuxt complains on startup) : pnpm add @sanity/visual-editing@latest
Configure nuxt to use visualEditing (see description)

Or checkout:
https://github.com/metaforx/sanity-io-visual-editing-react-compiler-bug
Expected behavior
Nuxt should run without error in frontend and visual editing should work via studio.
Which versions of Sanity are you using?
Not needed in Nuxt frontend.
Which versions of Node.js / npm are you running?
10.9.0
v22.12.0

Not yet a perfect fix but a working solution and a resason for the problem.
The culprit it seems to be vite:

The root project is trying to use<EMAIL_ADDRESS>@sanity/visual-editing requires<EMAIL_ADDRESS>
Reproduce:

Delete all node_modules and clear cache
Instead of pnpm use npm install
Greeted with error pointing towards differing vite versions
Install using npm install --legacy-peer-deps
Runt npm run dev
Add missing deps for @sanity/visual-editing manually.  npm install react react-dom
npm run dev and  🎉
🎉 Nuxt is up and running without error.

 WARN  Failed to resolve dependency: @nuxtjs/sanity > @sanity/visual-editing > react, present in 'optimizeDeps.include'
 WARN  Failed to resolve dependency: @nuxtjs/sanity > @sanity/visual-editing > react/jsx-runtime, present in 'optimizeDeps.include'
 WARN  Failed to resolve dependency: @nuxtjs/sanity > @sanity/visual-editing > react-dom, present in 'optimizeDeps.include'
 WARN  Failed to resolve dependency: @nuxtjs/sanity > @sanity/visual-editing > react-dom/client, present in 'optimizeDeps.include'

There was also a hotfix released earlier today 😊
https://github.com/nuxt-modules/sanity/releases/tag/v1.13.1

I can confirm. Update @nuxtjs/sanity to 1.13.1 solves the issue.


Issue installing napari-stitcher

Hi, I am trying to setup napari-stitcher. I already have a conda-env setup with multiview-stitcher and I get the below error when I pass pip install https://github.com/multiview-stitcher/napari-stitcher
Error message:
Collecting https://github.com/multiview-stitcher/napari-stitcher
  Downloading https://github.com/multiview-stitcher/napari-stitcher
     / 292.9 kB 887.2 kB/s 0:00:00
  ERROR: Cannot unpack file /tmp/pip-unpack-zrkutp1x/napari-stitcher (downloaded from /tmp/pip-req-build-lhg31zjo, content-type: text/html; charset=utf-8); cannot detect archive format
ERROR: Cannot determine archive format of /tmp/pip-req-build-lhg31zjo

Hi @Eddymorphling, thanks for posting this issue!
I could reproduce your error and it made me realise that the syntax in the README for installing napari-stitcher from github is wrong. The correct syntax is:
pip install "git+https://github.com/multiview-stitcher/napari-stitcher.git"

@m-albert Thank you. How could I miss that? That fixed it :)

Glad to hear :)


Update universal router to handle redirections

#285
Haven't tested! Don't merge until I, or someone, actually runs this code.

One of these days... I'll try for tonight!

Ok, caught an error. Now it's all working well.

Don't merge yet, testing a better version..

Ok, awesome! Looks like history.replaceState is now working as you would expect it to, even when it's called during the listenBefore phase. So, this PR just got slimmed down.
Not sure which update caused this, but I think it's due to this: https://github.com/rackt/history/commit/feb8412288778a3744bf1391892d9cfd15a0b753
Also, the listen-required bug is fixed by the awesome @stevoland: https://github.com/rackt/history/issues/71
This PR is ready now =P

I've force pushed and changed the description of this PR. This fixes #319


Plugin Error, Constant Loading, Not excepting code

Challenge Waypoint: Comment your JavaScript Code has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
Page takes a long time to complete the load, when its loading it gives the plugin error. Once i type in the code and click run test the plugin error goes away but the waypoint wont except the code as being good code.
My code:
// This is a comment.
/* This is also a comment */

I'm getting that same issue right now.

From comments in the help chat early this morning, lots of people are having this issue. I've seen a dozen or so people in about 20 minutes ask about this error.

@GhostParticle thanks for posting. We're aware of this issue. Let's keep the discussion in #4853. Closing.


Add indicator for newly added books

Add this little pop-up indicator in the top right corner whenever a new book is added.

Notices added in version 0.3.2.


When I set the system language to zh-cn, there are still some parts of the interface that remain in English. Can you tell me why this is happening?

When I set the system language to zh-cn, there are still some parts of the interface that remain in English. Can you tell me why this is happening?
like this-------------

HTML To PDF
未选择任何文件

Accepts HTML files and ZIPs containing html/css/images etc required
Uses WeasyPrint

Translations are added manually via people.
So unless someone translates the new content after it's added it won't be translated and will shoe the English version
The file in question in
https://github.com/Frooodle/Stirling-PDF/blob/main/src/main/resources/messages_zh_CN.properties

You are welcome to add translations and raise a PR to add then it would be translated in next version

But in the message_zh_CN.properties file, the relevant sentences have been translated, but the UI interface is still displayed in English.
home.HTMLToPDF.title=HTML转PDF
home.HTMLToPDF.desc=将任何HTML文件或zip文件转换为PDF
HTMLToPDF.tags=标记、网页内容、转换、转换

This is probably because the latest release is yet to pick up these changes,  I  will make a new release soon for you

Thank you very much for your reply, hope to solve this "issue".

Try now, latest update should include this


Add a panel in the configuration listing and managing dependencies

Being able to see the dependencies (helm, kustomize, kubectl, git, etc.) and what versions are installed
Being able to install or tell the user how to install them.
Identify what versions are supported with the exiting schema versions and K8s versions


Update Dataproc docs

alluxio-bot, merge this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9469/
Test PASSed.


Feature: Add bolt-shadow-toggle component

Jira
n/a
Summary
Adds a new <bolt-shadow-toggle> helper component (based off of the upcoming <bolt-radio-switch>) that allows devs to globally enable / disable Shadow DOM rendering while developing in Bolt.
Details
Replaces #1538 which got out of sync with master.
Adds a new feature flag to @bolt/core to carefully allow the default Shadow DOM feature detection check results to be overwritten while debugging / testing.
Uses Modal to tuck away the config options while not in use.
How to test
Try the new helper component out!

PR was released with v2.14.0


i18n for the datepicker

Is i18n developed for your datepicker? I cannot see it that option at the docs

Did you find any solution to translate datepicker ?

Well, I went with this instead:
https://air-datepicker.com/

i18n is really needed for the date picker

Hey everyone,
There's actually support for this, but I'll have to properly document it. Will be added for v1.6.0.

I have tried multiple approachs and it was impossible for me too

I gave up, I'm migrating to this: https://mymth.github.io/vanillajs-datepicker/#/?id=quick-start

@zoltanszogyenyi Any progress?

Working on it for the next version since I'm adding it to the Instance Manager.

Until we provide docs on this, please do:

Install the flowbite-datepicker plugin
Configure the languages via this guide: https://mymth.github.io/vanillajs-datepicker/#/i18n

Cheers,
Zoltan


Service not accessible via EdgeStack (possible SSL/TLSContext/Routing)

Description
Hey all - I have three services deployed in my GKE cluster. Each exists in its own namespace:
service1.domain1.com - ns: service1
service2.domain1.com - ns: service2
service3.domain2.com - ns: service3
I installed EdgeStack and created a simple http+https listener as per the docs. I then created host and mapping resources for these services in the order listed. The first two worked fine exactly as expected but the third one (note: different domain) simply will not deploy.
The first two share a wildcard cert for *.domain1.com although the actual k8s secret containing it is deployed separately to each namespace and referenced in the host for each and I followed the same pattern for the third one but with its own cert
Stuff I Have Noted So Far

There is no config related to the third service found in the envoy.json file in the EdgeStack pods (plenty for the other two)
No routes related to the third service are visible in the EdgeStack pod's diag page (/ambassador/v0/diag)
The diag page states that one TLSContext is active but other tools (eg. kubectl get tlscontext --all-namespaces) report that none exist in the cluster
As far as I know, there is only a single ambassador_id in the cluster (just the default one)

To Reproduce
I don't have another cluster to test on but am assuming deploying services like this in the same order will reproduce
Expected behaviour
I expected the third service to become available once the host+mapping resources were deployed like the first two
Versions (please complete the following information):

Ambassador: [e.g. 3.1.0]
Kubernetes environment: GKE
Version: 1.23.7-gke.1400

So it seems this is related to bad envoy config being generated specifically when I tried to enable gzip compression as per the docs here: https://www.getambassador.io/docs/edge-stack/latest/topics/running/gzip/
When I removed that Module things seem to go back to normal

Turns out this seems to be related to/caused by #4461 so can close this one


fix: from_vscode

#243

Nice, ty for the quick fix :+1:

https://github.com/L3MON4D3/LuaSnip/issues/243 be fixed. :)


Update UG

Codecov Report

Merging #152 (bd3319c) into master (b85008f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #152   +/-   ##
=========================================
  Coverage     67.78%   67.78%
  Complexity      659      659
=========================================
  Files           114      114
  Lines          2176     2176
  Branches        261      261
=========================================
  Hits           1475     1475
  Misses          597      597
  Partials        104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85008f...bd3319c. Read the comment docs.


Mouse button 4/5 for back forward don't work in insiders build

Type: Bug
workbench.editor.mouseBackForwardToNavigate is set to true for both released and insiders builds, but the buttons only work in the released build. I'm on a Mac M1 Ventura with a Logitech M705 mouse
To reproduce

Open a file, click to move the cursor to a few locations
Use the back/forward buttons on the mouse and they do nothing.

I ran code --disable-extensions
VS Code version: Code - Insiders 1.79.0-insider (Universal) (c3867859cf3e1a73f3ddce5ad36b3791b7883d88, 2023-06-01T05:26:38.346Z)
OS version: Darwin arm64 22.4.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
5, 7, 6

Memory (System)
16.00GB (1.32GB free)

Process Argv
--disable-extensions . --crash-reporter-id ab336b3b-928a-4cbb-928e-f29f273c3b25

Screen Reader
no

VM
0%

Extensions disabled
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
py29gd2263:30754469
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
pylantcb52:30590116
pyind779:30611226
pythonsymbol12:30651887
a9j8j154:30646983
showlangstatbar:30737417
pythonms35:30671666
03d35959:30757351
ecj1e332:30687743
pythonfmttext:30716741
pythoncmvfstr:30726892
fixshowwlkth:30724385
hidesbindicator:30724476
pythongtdpath:30726887
dh2dc718:30763024
pythonnosmt12:30757129
pythonidxpt:30763123
pythondjangots:30763122

+1. I have this issue and it's incredibly frustrating.

FYI, this bug exists in 1.81.1, but you can work around with these instructions:
https://superuser.com/questions/1216047/universal-back-forward-mouse-buttons-in-osx-instead-of-m4-m5

Can people clarify in what version it works and in what version it does not?  Stable is currently on 1.81.x and insiders is on 1.82.x.

I rebooted today and the buttons are working
Version: 1.82.0-insider (Universal)
Commit: f1302be1e67e3af5fbeb8bbb2ea784de7bc96150
Date: 2023-09-01T11:10:56.707Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0


Hope to support custom output capture

For example, it may be used in xterm in the browser environment,For example, maybe it is used in xterm in the browser environment, so that the input can be captured and sent to the front end.

To clarify, are you hoping to be able to capture stderr in some way? That's what linya outputs its bars to.

Yes, hopefully in a non-standard cli environment, but they have the same standard execution display method

Can you describe that environment a little more?

The front-end uses the react framework and is an executable program packaged with tauri. One of the xterm front-end libraries has already done some conventional command line work for us.

Maybe I just need to capture the progress of the back-end work and then output the progress bar to the front-end, and the progress bar will be displayed naturally.

Then I have to separate two programs and use piped to capture stderr and stdout. Maybe I can try this difficult integration solution.

Don't you already have two programs, the frontend and the backend?
Also keep in mind that linya depends on being able to see ANSI terminal codes to move the cursor around the screen. I'm not sure what that would do in a browser-based application.

Although there is a front end and a back end, they are one program. Maybe I can make a separate program and use piped to capture stdout and stderr. I will try it myself first.

Let me know how it goes :+1:


miui core - security - screen r. how i uninstall

how un install module magisk  without bootlooping . etc

Maybe there is a bug at uninstall.sh
Will be fixed soon

Fixed in v1.8


Bug/env threadx queue

Removed incorrect struct keyword and unnecessary casting. This matches use of TX_QUEUE in other parts of the file so is probably just a mistake that was left over from a previous change or update to the ThreadX API.
It is using struct TX_QUEUE but TX_QUEUE is actually a typedef from tx_api.h:
typedef struct TX_QUEUE_STRUCT {
  ...
} TX_QUEUE;

Found it when compiling for NXP RT1170 chip based on rpmsg-lite examples ported to ThreadX.
Before change:
arm-none-eabi-gcc [ ... lots of arguments ... ] "../rpmsg_lite/rpmsg_lite/porting/environment/rpmsg_env_threadx.c"
../rpmsg_lite/rpmsg_lite/porting/environment/rpmsg_env_threadx.c: In function 'env_create_queue':
../rpmsg_lite/rpmsg_lite/porting/environment/rpmsg_env_threadx.c:621:67: error: invalid application of 'sizeof' to incomplete type 'struct TX_QUEUE'
  621 |     queue_ptr       = (struct k_msgq *)env_allocate_memory(sizeof(struct TX_QUEUE));
      |                                                                   ^~~~~~

After change there are no warnings or errors.
I've compiled it with MCU Xpresso and run with my board and it all seems to work.
Please let me know what you think and if this MR is useful or needs any more work to be merged in.
Thanks,
Tim
TTP

Hello @TimTTP , thank you for reporting that issue. In fact, I have already found that recently and got the fix ready together with other threadx related fixes for the next rpmsg_lite release. May I ask you to have a try attached updated source in your project if all is ok, please?
Thank you
Michal
rpmsg_env_threadx.zip

Hi Michal, thanks for getting back to me!
Sounds great - the update seems to work well, I just had to update the header file declaration for env_get_queue and env_put_queue because the timeout parameter changed to uintptr_t, but I presume that is all included in your update.
Feel free to close this MR if it's no longer useful.
When are you planning on releasing the next update?
Thanks,
Tim

Hello Tim,
thanks for trying on your side and confirming it is ok now. I plan to provide the update soon, the next official release is planned at the end of July. If you are not against I will close this PR, ok?
Regards
Michal

Thanks Michal, yea that's fine 👍


Spinner and splitted table view

Describe the bug
On opening a saved connection it shows an infinite loading spinner and a splitted table view
To Reproduce
Steps to reproduce the behavior:

Open application
Connect to a saved connection
Bug appears. Last session tabs are not loading
After closing all tabs and open a new one, the spinner don't hide

It happened two times since I installed the last version, but not always
Expected behavior
Previous tabs are opened with table records
Screenshots

Application (please complete the following information):

App client: MySQL
App version: 0.7.17-beta.o
Installation source: Ubuntu Software

Environment (please complete the following information):

OS name: Ubuntu
OS version: 22.04.3 LTS
DB name: MySQL
DB version: 8.0.23

Additional context

Thank you so much for testing the beta!
Can you tell me if this problem also occurs with connections created from 0.7.17-beta.0?
Before the update can you tell me if you had 0.7.16 installed or if you updated from earlier versions?

Now I've duplicated the connection, give me some time to check if it occurs again as now I cannot reproduce it.
I've updated from 0.7.16.

I can't reproduce it again, I'm going to close the issue.
Thank you for the support!


Inference in tensorflowjs

Have you tried performing the inference by converting the model into tensorflowjs?
I made some trials here.
Could you share any code for the inference?
Thanks a lot!

I planed to work on that but unfortunately I did not have the time...
If you ever manage to perform the conversion I would be very interested to know it !

I uploaded the savedModels and tfjs conversion here for the 2stems spleeter model. Feel free to use them.
Apparently it is now possible to run a tf SavedModel in nodejs without conversion, see related blog post here. That's cool considering the conversion to tfjs is sometimes tricky.
Any idea on how you would do the preprocessing of the audio in js?

@shoegazerstella Sorry for my late answer. Thank you for sharing it is very useful, regarding the waveform I took a look in the python code and it just looks like a simple vector. I think that now we have to look for a way to translate an audio file to a waveform in JS.

I uploaded the savedModels and tfjs conversion here for the 2stems spleeter model. Feel free to use them.
Apparently it is now possible to run a tf SavedModel in nodejs without conversion, see related blog post here. That's cool considering the conversion to tfjs is sometimes tricky.
Any idea on how you would do the preprocessing of the audio in js?

@shoegazerstella Could you explain me how did you get the savedModel (saved_model.pb and variables) from the provided pretrained models??

@luiherch check this issue
However, they made some change to the original code now and I am not sure this will still work, you should maybe checkout to an older version


[BUG] OpenID certificate improperly validated causing 401 Unauthorized due to openjdk bug

Describe the bug
If you have an OpenID provider that is using a certificate which contains at least one nameConstraint with a leading . (likely in the issuer chain rather than the leaf certificate), then java will fail to validate the certificate and OpenID authorization in OpenSearch will fail, returning 401 Unauthorized.
I have been troubleshooting this issue for more than a week and read through dozens of conversations where people report OpenID authorization issues with OpenSearch, many of which were never fully resolved. In some cases, the same configuration appears to work for some users but not others. With sufficient logging enabled (see replication below) there are two stack traces that appeared for me. Most conversations report similar certificate path validation exceptions, but that is the second stack trace in this case. The earlier exception that gives this case away is: CertPathValidatorException: name constraints check failed.
In my case I have an internal certificate authority for the internal domain, and have cert-manager configured as an intermediate authority for the app.internal domain with a nameConstraint of DNS:.app.internal.  Setting the openid_connect_url value to https://sso.app.internal/realms/internal/.well-known/openid-configuration and configuring opensearch-dashboards to use the same provider results in the dashboards correctly redirecting, but receiving a 401 Unauthorized after being redirected back from the OpenID login.
I verified that the internal users, roles, and role mappings were all configured correctly, that the certificate authority certificates were provided correctly in the configuration, and dozens of other suggestions. The single change that enabled OpenID to work correctly was to reissue the intermediate authority certificate without the nameConstraint and then reissue the KeyCloak certificate. SSO started working without needing any changes to OpenSearch once the certificate was deployed to KeyCloak.
Related component
Build
To Reproduce

Configure an OIDC provider with a HTTPS certificate that contains at least one nameConstraints with a leading . such as DNS:.example.com in the issuer chain (detailed instructions in the upstream fix)
Configure OpenSearch to use the provider with openid_connect_url
Attempt to log in using OpenID
Receive 401 Unauthorized

Additionally, you can configure log4j2.properties to see more details from the cluster:
status = error
appender.console.type = Console
appender.console.name = console
appender.console.layout.type = PatternLayout
appender.console.layout.pattern = [%d{ISO8601}][%-5p][%-25c{1.}] [%node_name]%marker %m%n
rootLogger.level = info
rootLogger.appenderRef.console.ref = console
logger.securityjwt.name = com.amazon.dlic.auth.http.jwt
logger.securityjwt.level = trace

And you should see at least one stack trace (I usually see 2 for each failed log in), the first includes the error CertPathValidatorException: name constraints check failed. I unfortunately don't have a full copy of this any more.
Expected behavior
Users from OpenID providers hosted with certificates containing nameConstraints in any part of the issuer chain should be able to authenticate with OpenSearch.
Additional Details
Additional context
This is an issue with upstream openjdk that has been fixed and backported to to 22+. The container images for OpenSearch 2.17.1 indicate the openjdk 21.0.4 is bundled, which does not contain the fix.
What needs to happen now?
This will continue to be an issue until a patched openjdk is bundled with OpenSearch. In the meantime, hopefully this bug appears in search results for others hitting the same issue so they don't have to spend days troubleshooting it.

[Catch All Triage - 1, 2, 3, 4, 5]


Many "redeclared" warnings

Cython master is giving lots and lots of '...' redeclared warnings. Even when compiling Cython itself, I am getting
    warning: Cython/Compiler/Code.py:380:4: 'format_code' redeclared
    warning: Cython/Compiler/Code.py:442:4: 'none_or_sub' redeclared
    warning: Cython/Compiler/Code.py:693:4: 'new_label' redeclared
    warning: Cython/Compiler/Code.py:712:4: 'get_loop_labels' redeclared
    warning: Cython/Compiler/Code.py:717:4: 'set_loop_labels' redeclared
    warning: Cython/Compiler/Code.py:728:4: 'get_all_labels' redeclared
    warning: Cython/Compiler/Code.py:735:4: 'set_all_labels' redeclared
    warning: Cython/Compiler/Code.py:826:4: 'temps_in_use' redeclared
    warning: Cython/Compiler/Code.py:863:4: 'start_collecting_temps' redeclared
    warning: Cython/Compiler/Code.py:869:4: 'stop_collecting_temps' redeclared
    warning: Cython/Compiler/Code.py:930:4: 'get_py_string_const' redeclared
    warning: Cython/Compiler/FlowControl.py:74:4: 'empty' redeclared
    warning: Cython/Compiler/FlowControl.py:77:4: 'detach' redeclared
    warning: Cython/Compiler/FlowControl.py:86:4: 'add_child' redeclared
    warning: Cython/Compiler/FlowControl.py:94:4: 'empty' redeclared
    warning: Cython/Compiler/FlowControl.py:126:4: 'newblock' redeclared
    warning: Cython/Compiler/FlowControl.py:137:4: 'nextblock' redeclared
    warning: Cython/Compiler/FlowControl.py:151:4: 'is_tracked' redeclared
    warning: Cython/Compiler/FlowControl.py:158:4: 'is_statically_assigned' redeclared
    warning: Cython/Compiler/FlowControl.py:168:4: 'mark_position' redeclared
    warning: Cython/Compiler/FlowControl.py:173:4: 'mark_assignment' redeclared
    warning: Cython/Compiler/FlowControl.py:180:4: 'mark_argument' redeclared
    warning: Cython/Compiler/FlowControl.py:187:4: 'mark_deletion' redeclared
    warning: Cython/Compiler/FlowControl.py:194:4: 'mark_reference' redeclared
    warning: Cython/Compiler/FlowControl.py:204:4: 'normalize' redeclared
    warning: Cython/Compiler/FlowControl.py:227:4: 'initialize' redeclared
    warning: Cython/Compiler/FlowControl.py:263:4: 'map_one' redeclared
    warning: Cython/Compiler/FlowControl.py:763:4: 'mark_assignment' redeclared
    warning: Cython/Compiler/FlowControl.py:796:4: 'mark_position' redeclared
    warning: Cython/Compiler/Parsing.py:646:0: 'make_slice_node' redeclared
    warning: Cython/Compiler/Parsing.py:2422:0: 'p_c_base_type' redeclared
    warning: Cython/Compiler/Parsing.py:2751:0: 'p_c_declarator' redeclared
    warning: Cython/Compiler/Parsing.py:2943:0: 'p_c_arg_list' redeclared
    warning: Cython/Compiler/Parsing.py:3586:0: 'p_code' redeclared
    warning: Cython/Compiler/Parsing.py:3610:0: 'p_module' redeclared
    warning: Cython/Compiler/Parsing.py:3733:0: 'print_parse_tree' redeclared
    warning: Cython/Compiler/Pythran.py:21:0: 'is_pythran_supported_dtype' redeclared
    warning: Cython/Compiler/Pythran.py:121:0: 'to_pythran' redeclared
    warning: Cython/Compiler/Pythran.py:150:0: 'is_pythran_supported_type' redeclared
    warning: Cython/Compiler/Pythran.py:163:0: 'is_pythran_expr' redeclared
    warning: Cython/Compiler/Scanning.py:93:4: 'lookup' redeclared
    warning: Cython/Compiler/Scanning.py:400:4: 'indentation_action' redeclared
    warning: Cython/Compiler/Visitor.py:169:4: 'visit' redeclared
    warning: Cython/Compiler/Visitor.py:197:4: 'visitchildren' redeclared
    warning: Cython/Compiler/Visitor.py:247:4: 'visitchildren' redeclared
    warning: Cython/Compiler/Visitor.py:264:4: 'recurse_to_children' redeclared
    warning: Cython/Plex/Actions.py:13:4: 'same_as' redeclared
    warning: Cython/Plex/Actions.py:29:4: 'same_as' redeclared
    warning: Cython/Plex/Actions.py:50:4: 'same_as' redeclared
    warning: Cython/Plex/Actions.py:70:4: 'same_as' redeclared
    warning: Cython/Plex/Scanners.py:112:4: 'read' redeclared
    warning: Cython/StringIOTree.py:55:4: 'getvalue' redeclared
    warning: Cython/StringIOTree.py:60:4: 'copyto' redeclared
    warning: Cython/StringIOTree.py:69:4: 'commit' redeclared
    warning: Cython/StringIOTree.py:104:4: 'allmarkers' redeclared

This is a recent regression related to #1874

I am seeing these also when working with C++ and std::move
    cdef extern from "<utility>" namespace "std" nogil:
        cdef shared_ptr[vector[int32_t]] move(unique_ptr[vector[int32_t]])
        cdef unique_ptr[vector[int32_t]] move_unique "std::move"(unique_ptr[vector[int32_t]])
        cdef shared_ptr[vector[int16_t]] move(unique_ptr[vector[int16_t]])
        cdef unique_ptr[vector[int16_t]] move_unique "std::move"(unique_ptr[vector[int16_t]])

Seems we shouldn't be warning on standard overload definitions in an extern

If it helps this warning is produced from line 452 of Symtab.py in the declare method

These are two separate issues. The original problem is that cpdef methods (and functions?) lead to incorrect warnings.

I see this compiling gevent with cython 0.28b1. It doesn't seem to cause any problems.
A simple reproducer:
# foo.py
class Semaphore(object):
    def locked(self):
        return True

# foo.pxd
cdef class Semaphore:
    cpdef bint locked(self)

$ cython foo.py
warning: foo.py:3:1: 'locked' redeclared

Another (possibly simpler) way to reproduce is to use typed memoryview:
# memoryview.pyx
def my_func(double[:] x):
    pass

$ cython memoryview.pyx
warning: TestClass:20:10: 'cpdef_method' redeclared
warning: TestClass:31:10: 'cpdef_cname_method' redeclared

CC-ing @robertwb

I think I found a way to tighten the detection here, but in order to prevent it from breaking again in the future, I'd be happy to see a test case that does not require C++11.

The simplest example is
# cython: language=c++

cdef extern from *:
    int foo()
    int foo(int)


Make caskade specific error types

Makes it easier to convey the message of an error, and declutters the main code.

Closed by #5


Release 0.3, boto3 install dependency question

Hello. Just a generic question regarding 0.3 version.
As I understand boto3 is removed from the install dependencies for any *nix operating system:
https://github.com/ansible-community/molecule-ec2/blob/14cea258dfbb7f465e4149ea33f4f5462adffefd/setup.cfg#L66
I don't see information about boto3 install dependency removal in the release changelog.
pip show molecule-ec2
Name: molecule-ec2
Version: 0.3
Summary: EC2 Molecule Plugin :: run molecule tests using AWS EC2
Home-page: https://github.com/ansible-community/molecule-ec2
Author: Sorin Sbarnea
Author-email<EMAIL_ADDRESS>License: MIT
Location: /home/andrew/.local/share/virtualenvs/test-hTviaBQ-/lib/python3.7/site-packages
Requires: molecule, pyyaml
Required-by:

pip show molecule-ec2
Name: molecule-ec2
Version: 0.2
Summary: EC2 Molecule Plugin :: run molecule tests using AWS EC2
Home-page: https://github.com/ansible-community/molecule-ec2
Author: Sorin Sbarnea
Author-email<EMAIL_ADDRESS>License: MIT
Location: /home/andrew/.local/share/virtualenvs/test-hTviaBQ-/lib/python3.7/site-packages
Requires: boto, boto3, ansible, molecule, pyyaml
Required-by:

Is it expected or is it some sort of a bug?

I agree boto3 should be preserved within install_requires.


Android Export : 'Use Custom Build' option DOES NOT USE 'Custom Template' setttings, for android_debug.apk and android_release.apk

Godot version:

3.2.3.stable
OS/device including version:

Linux, Android, GLES2.
Issue description:

I enabled the Android export option: 'Use Custom Build'. I also specified custom templates, for both the debug and release versions, as I wanted to use script encryption.
When I built and deployed the resulting app, on my Android device, it was UNABLE to read the encrypted scripts.
As a check, I unset the 'Use Custom Build' option only, and then was able to run my app fine, which indicates that the custom templates I had built, to use scrip encryption, were working fine.
Looking into this matter, it looks like the custom build option, instead of using the custom build templates (<custom_location>/android_debug.apk and <custom_location>/android_release.apk), were actually using .aar files from
the project's local
android/build/libs/debug/godot-lib.debug.aar
and android/build/libs/release/godot-lib.release.aar
As a further test and workaround, I copied my custom built godot engine's .aar files (which incorporated the script encryption) to the aforementioned locations, and was able to get my app to run successfully..
Ideally, the 'Use Custom Build' option should be able to pick up the custom templates and use them, if they are specified.
As it is now, the combo of 'Use Combo Build' and custom templates, for Android export, doesn't really work as one would expect..

When you use a custom build, you won't be using pre-built APK files as they will be built during the export process (using Gradle). Therefore, the Custom Template section simply can't be made to work in this case.

I'm not all that familiar with AAR files, but couldn't you dynamically generate suitable AAR files from the custom apk templates?
Then, it would effectively work as users would expect it to work..

I'm not all that familiar with AAR files, but couldn't you dynamically generate suitable AAR files from the custom apk templates?

@ginobean At build time, the aar files are unpacked within the apk, so once you have the final apk, it's not possible to retrieve the aar from it.

Documentation should be more clear about this. There is no mention that you can't mix android build templates with custom apks

@kristijandraca Feel free to open a pull request to update the documentation :slightly_smiling_face:

Hi, I have a Godot Android project (Godot 3.3.2.stable) with NativeLib and some plugins.
I wanted to use script encryption but I can't get it to work (with custom export templates and the encryption key).
I was about to open a new issue.
If I understand correctly, does this issue mean that you can't use script encryption and plugins together?
Thanks in advance

@serogbp try to build a custom export template for debug and release, and instead of using them, just replace android/build/libs aar files with ones that you generated with custom export.

Thank you so much @kristijandraca, it worked!

Thank you so much @kristijandraca. I have been struggling with this for weeks and it was the only thing keeping me from releasing my app. Thank you, thank you, thank you.

I believe the mentioned issue exists in 3.4 stable as well, since I've been trying to get it to work as well.
Also thank you @kristijandraca . Your solution worked for me as well!

@randazzle Feel free to open a pull request to update the documentation :slightly_smiling_face:

@serogbp try to build a custom export template for debug and release, and instead of using them, just replace android/build/libs aar files with ones that you generated with custom export.

THANK YOU!!!

Custom Build has been renamed to Gradle Build in Godot 4.x, which should resolve the confusion about assuming it's related to Custom templates.


Issue defining tf.function input_signature on class methods

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution: Linux Ubuntu 18.04
TensorFlow installed from (source or binary): Binary
TensorFlow version: tf-nightly-2.0-preview==2.0.0.dev20190426
Python version: 3.7.0

I have defined the following Encoder class with a tf.function signature hoping to be able to save it using the SavedModel format.
class Encoder(tf.keras.Model):
    # init and other functions...

    @tf.function(input_signature=[
        tf.TensorSpec([None, 50], tf.float32, name='x'),
        tf.TensorSpec([None, 1024], tf.float32, name='hidden')
    ])
    def call(self, x, hidden):
        x = self.embedding(x)
        output, state = self.gru(x, initial_state = hidden)
        return output, state

# Some more code...

tf.saved_model.save(
    encoder,  # instance of Encoder
    './some/directory/',
    signatures=Encoder.call
)

I am not sure if this is the desired behavior, but I am getting this error when trying to save:
Traceback (most recent call last):
  File "train.py", line 244, in <module>
    signatures=Encoder.call
  File "/home/marcio/Workspace/projects/traduki/traduki-pipel
ine/venv/lib/python3.7/site-packages/tensorflow/python/saved_
model/save.py", line 801, in save
    signatures = signature_serialization.canonicalize_signatu
res(signatures)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipel
ine/venv/lib/python3.7/site-packages/tensorflow/python/saved_
model/signature_serialization.py", line 95, in canonicalize_s
ignatures
    signature_function = _get_signature(function)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipel
ine/venv/lib/python3.7/site-packages/tensorflow/python/saved_
model/signature_serialization.py", line 41, in _get_signature
    function = function.get_concrete_function()
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 702, in get_concrete_function
    self._initialize(args, kwargs, add_initializers_to=initializer_map)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 379, in _initialize
    *args, **kwds))
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1331, in _get_concrete_function_internal_garbage_collected
    graph_function, _, _ = self._maybe_define_function(args, kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1594, in _maybe_define_function
    graph_function = self._create_graph_function(args, kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1527, in _create_graph_function
    capture_by_value=self._capture_by_value),
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/framework/func_graph.py", line 713, in func_graph_from_py_func
    func_outputs = python_func(*func_args, **func_kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 329, in wrapped_fn
    return weak_wrapped_fn().__wrapped__(*args, **kwds)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 436, in __call__
    self._initialize(args, kwds, add_initializers_to=initializer_map)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 379, in _initialize
    *args, **kwds))
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1331, in _get_concrete_function_internal_garbage_collected
    graph_function, _, _ = self._maybe_define_function(args, kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1594, in _maybe_define_function
    graph_function = self._create_graph_function(args, kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/function.py", line 1527, in _create_graph_function
    capture_by_value=self._capture_by_value),
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/framework/func_graph.py", line 713, in func_graph_from_py_func
    func_outputs = python_func(*func_args, **func_kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py", line 329, in wrapped_fn
    return weak_wrapped_fn().__wrapped__(*args, **kwds)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/framework/func_graph.py", line 705, in wrapper
    ), args, kwargs)
  File "/home/marcio/Workspace/projects/traduki/traduki-pipeline/venv/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 360, in converted_call
    result = converted_f(*effective_args, **kwargs)
TypeError: tf__call() missing 1 required positional argument: 'hidden'

When I remove the two TensorSpecs from the signature, I instead get a TypeError: tf__call() missing 3 required positional arguments: 'self', 'x', and 'hidden', which means it's expecting me to provide a TensorSpec for self.
Based on this guide I wouldn't expect to have to provide signature information for self in the call function, which leads me to believe the current behavior should be changed.

This works if you pass encoder.call instead of Encoder.call. Is there something you could do passing the unbound method that you can't by passing the bound method?

@allenlavoie Good catch! I guess I don't need the unbound method after all. Thanks!


'error: an inner attribute is not permitted in this context' and others

I've just started the Testing post, and have barely gotten through the first couple sentences, when I am given 3 errors (2 unique errors):
error: an inner attribute is not permitted in this context
  --> src\main.rs:22:1
   |
22 |   #![feature(custom_test_frameworks)]
   |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
26 | / fn test_runner(tests: &[&dyn Fn()]) {
27 | |     println!("Running {} tests", tests.len());
28 | |     for test in tests {
29 | |         test();
30 | |     }
31 | | }
   | |_- the inner attribute doesn't annotate this function
   |
   = note: inner attributes, like `#![no_std]`, annotate the item enclosing them, and are usually found at the beginning of source files
help: to annotate the function, change the attribute from inner to outer style
   |
22 - #![feature(custom_test_frameworks)]
22 + #[feature(custom_test_frameworks)]
   |

error: an inner attribute is not permitted in this context
  --> src\main.rs:23:1
   |
23 |   #![test_runner(crate::test_runner)]
   |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
26 | / fn test_runner(tests: &[&dyn Fn()]) {
27 | |     println!("Running {} tests", tests.len());
28 | |     for test in tests {
29 | |         test();
30 | |     }
31 | | }
   | |_- the inner attribute doesn't annotate this function
   |
   = note: inner attributes, like `#![no_std]`, annotate the item enclosing them, and are usually found at the beginning of source files
23 - #![test_runner(crate::test_runner)]23 + #[test_runner(crate::test_runner)]
   |

error[E0463]: can't find crate for `test`

The two bad pieces of code, in question,
#![feature(custom_test_frameworks)]
#![test_runner(crate::test_runner)]

How do I solve this? I've followed every step. Is this a problem with the latest rust nightly release?
Everything else works great (if I remove this code, and run cargo run), and I can't find anyone else with errors like mine.

#![foo] attributes need to be at the top of the file.

Well, as per usual, I find that I didn't even try the simplest solution.
Your help is much appreciated!


"An error occurred" on new status website

Describe the bug
I just generated a new status website following the Getting Started docs, yet after I updated the comfiguration file, the site now redirects to a 404. The Github readme itself shows the statuses just fine, which leads me to believe it's an issue with the custom domain, however, it does show the proper nav links and icon.
To Reproduce
Steps to reproduce the behavior:

Go to https://status.goldencheck.org
See error

Expected behavior
A proper status page, such as https://status.shulert.com/
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Firefox

Smartphone (please complete the following information):

Device: Pixel 2
OS: Android 11
Browser: Firefox

Can I work on this  issue?

Please do!

#283 This fixes the issue! It needs to be the organization name if hosted on an organization! @AnandChowdhary, please merge!


A valid gruntfile could not be found

On a windows 10 machine using visual studio code with powershell. I'm getting the following error when running "npm start".

Prior to this, I have updated powershells execution policy to enable remotely signed scripts.
Is the gruntfile missing from the repo?

@SamDrummond It looks like Gruntfile.js was listed in .gitignore. The file has been installed.
Feel free to re-open if you still run into issues.


Compare our snap test coverage against geth

Review our snap test coverage against geth test suites.

any types of tests that we need to add to our testing
edge cases

https://github.com/ethereum/go-ethereum/blob/0a2f33946b95989e8ce36e72a88138adceab6a23/cmd/devp2p/internal/ethtest/snap.go#L596


fix: 修复stylelintignore文件规则有空格失效的问题

修复stylelintignore文件规则有空格失效的问题

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.shiwenzhe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

<EMAIL_ADDRESS>已发布


[hotfix] [table-api-java] Add missing @PublicEvolving annotations to classes in flink-table-api-java.

What is the purpose of the change
Add missing @PublicEvolving annotations to classes in flink-table-api-java, the classes include: ExecutionConfigOptions, OptimizerConfigOptions, TableConfigOptions, ExplainDetail, ResultKind
Brief change log

Add missing @PublicEvolving annotations to classes in flink-table-api-java

Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Build is passed. Merging...


Question: How do I get interface vptr from a struct?

Hi,
I'm trying to return 'self' as interface pointer.
I'm trying to do something equivalent to this C++ code.
IEatable* Animal::GetEatable() {
    return this;
}

where Animal implements multiple interfaces. In this case, C++ took care of returning correct vptr.
I haven't found a good, clean way to do it in Rust other than refering to a member created by proc macro.
// this is not working code
impl Animal for IEatable {
    fn GetEatable(&self) -> *mut c_void {
        *self.__ieatablevptr as *mut cvoid
    }
}

Is there any macro or function that finds out proper vptr from struct instance?
Any help would be appreciated. Thank you.

You could call Interface::as_raw:
impl Animal for IEatable {
    fn GetEatable(&self) ->  core::ptr::NonNull<core::ptr::NonNull<IEatable::VTable>> {
        self.as_raw()
    }
}

Sadly I'm using old, forked version which doesn't have as_raw(), but now I know which part I should look into. Thank you!


[SET.2] cannot access setup page

The setup page does not open automatically the first time the application is run, I get the Hello World page. If I click on 'Member Area', then I get a 404, when the browser tries to open this link. (Installing under Windows with Vagrant)
This issue is a blocker for me as I can't test most of the remaining functionality without access to the backend.

oops, I din't upload the correct config file. can you try again please?

That's fixed it, great, thanks!
Perhaps handy to add to the README how you can stop vagrant and restart it
after a change in the repo
Op di 5 okt. 2021 om 13:18 schreef marilenadaquino @.***

:

oops, I din't upload the correct config file. can you try again please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/polifonia-project/registry_app/issues/40#issuecomment-934314385,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJF4QNN3B6BMTNHG5J7OGXDUFLNJFANCNFSM5FLKCFOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Build of cloud.google.com/go/storage on Go master/1.10 fails

% go build cloud.google.com/go/storage
# cloud.google.com/go/storage
./not_go110.go:26:29: shouldRetry redeclared in this block
	previous declaration at ./go110.go:21:29

Fix: https://github.com/GoogleCloudPlatform/google-cloud-go/pull/742


[help] Is it safe to assert relation query to typeof db.relation

Here is my use case:
I want to DRY for my select fileds.
user.repo.ts
const userDefaultSelect = (q: typeof db.user) => {
  return q.select('id', 'name', 'profile');
};

article.repo.ts
const repo = createRepo(db.article, {
  queryMethods: {
    defaultSelect: (q) => {
      return q.select('xxx', {
         user: (q) => userDefaultSelect(q.user as unknown as typeof db.user)
      })
    }
  }
})

userDefaultSelect(q.user) had type error so I have to assert it to typeof db.user. Are there any better ways to do this? Or if I have to do type assertion, is it safe?

By the way, the result for this simple demo is acting as expected, my concern is whether it can lead to hidden bugs in the future

There is a better way: userDefaultSelect should return a function that takes (q: typeof db.user) => ...
const userDefaultSelect = () => {
  return (q: typeof db.user) => {
    return q.select('id', 'name', 'profile');
  }
};

article.repo:
const repo = createRepo(db.article, {
  queryMethods: {
    defaultSelect: (q) => {
      return q.select('xxx', {
         user: userDefaultSelect()
      })
    }
  }
})

Let me know if it helps, it may not, I copied this idea from the long tutorial and there this works.

Seems not work, and it has type error and runtime errors.

In the tutorial, selectFavorited received a db.article type handles q.favorites  inside the function, but in my case, userDefaultSelect received a db.user type which is not compatible with q(as typeof db.article).user

I don't know and going AFK now, will try to figure out later.
There is a chance that db.article.user may be ok:
const userDefaultSelect = (q: typeof db.article.user) => {
  return q.select('id', 'name', 'profile');
};

Because that q is not exactly db.user, but extended version of it that belongs to db.article and the type is different.

This works but it's wired.

Cool, so at least it works. I'll figure out how to add some kind of helper to un-wire it.

Published a function makeQuery for this: docs.
A type-only helper wouldn't be enough for this case, I tried.


Version 2.5 is no longer available and version 3 is shown as 2.5

Describe the bug
It's no longer possible to access https://www.asyncapi.com/docs/reference/specification/v2.5.0 and v3.0.0-next-major-spec.4 is shown as 2.5.0.

This is the PR that broke it https://github.com/asyncapi/website/pull/514
I guess some dependency? What about a revert? cc @derberg @fmvilas

This is the commit that broke it https://github.com/asyncapi/website/commit/f2bf2fc6c68dc6fb0469948fa450dd53160f117c
I don't get how this is breaking it but it is. I checked every commit until getting a local version without the issue; this is the first version that breaks.
Any idea? cc @derberg @fmvilas @magicmatatjahu

I noticed the posts.json file generated contains incoherent things like:

"title": "2.4.0" but "slug": "/docs/reference/specification/v2.4.0",

I confirm the bug is gone whenever the file v3.0.0-next-major-spec.4 is not present (and is not generated).

All the "bug" comes from https://github.com/asyncapi/website/blob/master/scripts/build-post-list.js#L64.
Will try to give more detail in a next comment.

Will try to give more detail in a next comment.

Since both v2.5.0.md and v3.0.0-next-major-spec.4  are identical in terms of content, https://github.com/asyncapi/website/blob/master/scripts/build-post-list.js#L64 is returning the same exact file when processing the second, meaning it returns the same object as for v2.5.0.md. See cache logic in https://github.com/jonschlinkert/gray-matter/blob/8a22958e0afd4b2e09c705becec1c35e76c4f0ee/index.js#L37-L42.
Then, the issue is that any modification is being made to the same file in memory, ending up in v2.5.0.md being a mix of both files.


Register metrics defined at Resource level

If a Resource class is annotated with either:

@Timed,
@Metered
@ExceptionMetered

all method defined in such class will 'inherit' the corresponding annotation.

@ryantenney I was wondering if you could have a look at this PR and let me know if you have any comments (positive or negative) ?

I certainly will, but I'm very busy right now, I'll get to it soon.

@ryantenney Just reminding you about this PR, would really love to get some feedback from you,
so we don't need to keep a separate fork with the change.

@patrox Thank you, and I'm so sorry for the delay getting this merged.

Hi @ryantenney, I am using metrics-core 3.1.0 for jmx reporting but unable to see @Timed working at resource level. Can you tell me which version supports @Timed at resource level?

Hi @ryantenney @arteam,
I'm wondering if the changes from this PR were released as part of some latest releases ?
Cause I checked, and I couldn't find them :( Can you please check ?

@patrox this went into master and I don't think was cherry-picked into the 3.1 or 3.2 release branches, so we'd have to wait until 4.0 for this one.

I will take a look. I moved a bunch of merge requests manually from the 4.0 branch to 3.2, maybe I missed this.

thanks @jplock & @arteam, I appreciate your prompt response


Add grid_packing example from the upstream C repository.

This pull request is apart of #36, and is an adaptation of the grid_packing example from the upstream C repository.

That should fix it

Thanks!


Allow passing options to serializer for decoding based on the opcode (:text or :binary)

Currently, since the opcode is not being passed to the serializer, it is not possible to know if it is text or binary, and this may be helpful to know whether to decode/encode a JSON-text or a binary – for example, be able to do something like https://github.com/phoenixframework/phoenix/blob/master/lib/phoenix/socket/serializers/v2_json_serializer.ex#L102-L108

Dear @cabol, thank you for your contribution.
The pull-request changes the API in a breaking way. This would require a new major release with the corresponding accompanying effort. We are no longer maintaining this library. You can find more information here: https://github.com/Aircloak/phoenix_gen_socket_client/issues/57
If you are interested in taking over the stewardship of this library, please let me know.
As it is, we are no longer accepting further contributions.

Dear @cabol, thank you for your contribution.
The pull-request changes the API in a breaking way. This would require a new major release with the corresponding accompanying effort. We are no longer maintaining this library. You can find more information here: https://github.com/Aircloak/phoenix_gen_socket_client/issues/57
If you are interested in taking over the stewardship of this library, please let me know.
As it is, we are no longer accepting further contributions.

Hi @cabol,
Thank you for your contribution! I have just taken over the project and am pondering next steps. l'll  get back to you shortly on this PR(hopefully by the end of next week). In the meantime, feel free to join the Gitter Chat or post any suggestions you have for the project here.
Thanks!

Hi @cabol,
Thank you for your contribution! I have just taken over the project and am pondering next steps. l'll  get back to you shortly on this PR(hopefully by the end of next week). In the meantime, feel free to join the Gitter Chat or post any suggestions you have for the project here.
Thanks!

Hey @cabol,
Just wanted to just update you and let you know that I haven't forgotten about this thread. I've looked through the PR and it seems fine to me. However, as this involves a breaking change and consequently a release, I'd like to take sometime to see if there are any other changes we should rollout.
As such, I will only be merging this PR tomorrow once I have aggregated any other potential changes. Once again, thank you for your contribution and continued patience.

Hi @J0, thanks for the answer, it sounds good to me, totally understand, I stay tuned, thanks!!


Team up with Saltarelle

Nikhil, you have been pioneering on c# to javascript compiling, and I think a lot of us appreciate this very much. However, being on your own, progress, although steadily, has been quite slow... esp. for some c# 4.0 features, ScriptSharp still has no support.
Erik Källén has forked your work, and already included a lot of c# 4.0 feature we all love. I have tested the Saltarelle compiler, and was very satisfied with the result, all the new features like anonymous objects, objects initializers, anonymous delegates, lambda delegates, var keyword ect... are already available in Saltarelle.
Now both of you are building almost exactly the same product, so in my opinion a lot of effort is wasted. I would like to ask you, please contact Erik, team up, join forces, I think we will all benefit  a lot if you would do that...

hi: how to use anonymouse object in Saltarelle
[HttpGet]
public HttpResponseMessage TestJS()
{
try
{
var charts = chartService.GetAllChart().Select(c => new { c.ChartId, c.Title });
return Request.CreateResponse(HttpStatusCode.OK, new { list = charts, msg = MSGResource.SuccessEvent, type = MsgType.Success });
}
catch (System.Exception e)
{
return Request.CreateErrorResponse(HttpStatusCode.BadRequest, MSGResource.ErrorEvent, e);
}
    }

how to get 'list' name object in -
jQuery.Ajax(new jQueryAjaxOptions()
{
Url = "/Api/ChartApi/TestJS",
DataType = "json",
Type = "GET",
Success = (d, t, r) =>
{
// how to use d.list ?????
var content = jQuery.Select("#FeedItems");
content.Html("");
foreach (var item in (List)d)
{
                }
            }
        });


maps/metricsmap: fix cilium bpf metrics list output

As the metrics bpf map is the type of per CPU hash when performing a
lookup we need to provide the number of CPUs running to get all the
metrics stored in the BPF map.
Signed-off-by: André Martins<EMAIL_ADDRESS>Fixes: https://github.com/cilium/cilium/issues/8072

This change is

test-me-please

Coverage increased (+0.02%) to 41.953% when pulling f58e0de0be344d9d01459df046fe9a179a230e95 on pr/fixing-dumping-of-bpf-metrics into d84a7965650bec0291f552b6346588a5c4ff3b4d on master.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

What were the last 3 CI run failures related to?

Digged in, failures were also instances of #7902


TextSpan renders text incorrectly in Flutter 3.7x

Steps to Reproduce

We have found a regression bug in moving from Flutter 3.3.10 directly to Flutter 3.7x. The issue is regarding the use of RichText and TextSpan. We do not get the issue in 3.3.10 and below.
Simply put, we have a requirement to scan text and create TextSpan's on a character by character basis. The TextSpan for each character will have one or more TextStyles applied.
The TextStyles that are applied will take the form :
Theme.of(context).textTheme.xxxx.copyWith(.... here we set 1 or more style properties).
So as an example, we may have :
 final highlightStyle = Theme.of(context).textTheme.bodyLarge.copyWith(           color: Colors.red,         );
Which will be applied to certain characters of a String.
The example shown attempts to use RichText and TextSpan to format the String 'Profile Support' where a TextSpan is applied to each character of 'Profile' and a TextSpan is applied to the String 'Support'.
Expected results:
I want to see :
Profile Support
where 'Support'' is RED

Actual results:
This is what I see:
Profifile Suppor
Note
You can see that 'Profile' now gets rendered as 'Profifile'. Also, some of the characters of 'Support' are not fully displayed.

Code sample

/// We want to display the text 'Profile Support' with 'Support' rendered as RED

final highlightStyle = Theme.of(context).textTheme.bodyLarge.copyWith(
          color: Colors.red,
        );
///bodySmall,labelLarge etc will fail here and display profifile
///if we use labelSmall, we get the correct text being display 'profile'

    final normalStyle = Theme.of(context).textTheme.bodySmall;

    List<TextSpan> span2 = <TextSpan>[];

    /// This fails to display the correct text
    span2.add(TextSpan(text: 'P', style: normalStyle));
    span2.add(TextSpan(text: 'r', style: normalStyle));
    span2.add(TextSpan(text: 'o', style: normalStyle));
    span2.add(TextSpan(text: 'f', style: normalStyle));
    span2.add(TextSpan(text: 'i', style: normalStyle));
    span2.add(TextSpan(text: 'l', style: normalStyle));
    span2.add(TextSpan(text: 'e', style: normalStyle));
    span2.add(TextSpan(text: ' ', style: normalStyle));
    span2.add(TextSpan(text: 'Support', style: highlightStyle));

return Padding(
      padding: const EdgeInsets.all(8.0),
      child: RichText(
        text: TextSpan(
          children: span2,
        ),
      ),
    );

Logs

[✓] Flutter (Channel stable, 3.7.3, on macOS 12.6 21G115 darwin-x64, locale ps-AF)
    • Flutter version 3.7.3 on channel stable at /sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (13 days ago), 2023-02-08 15:46:04 -0800
    • Engine revision 248290d6d5
    • Dart version 2.19.2
    • DevTools version 2.20.1

Thanks for the report @alexda12
Can you try to run the scenario on latest master to see if the behavior persists on it as well or not ?
flutter channel master
flutter upgrade

This is similar to https://github.com/flutter/flutter/issues/104884
@Rusino

Thanks for the update. Seeing same behavior as reported and only on latest versions.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.7.3, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.7.3 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (4 days ago), 2023-02-08 15:46:04 -0800
    • Engine revision 248290d6d5
    • Dart version 2.19.2
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.8.0-15.0.pre.21, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.8.0-15.0.pre.21 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 02d5f2f648 (13 minutes ago), 2023-02-23 03:01:11 -0500
    • Engine revision b0248b1998
    • Dart version 3.0.0 (build 3.0.0-266.0.dev)
    • DevTools version 2.22.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Once https://github.com/flutter/flutter/issues/104884 is resolved, this one should get fixed too with it.

I also ran into the same issue some time ago when implementing something for devtools. The "profile" word was also the one causing issues: https://github.com/flutter/devtools/pull/4062/files#r865403626

We have two TextSpan, the first displays the text prof (which is the actual typed text). The other TextSpan will display ile, which is the suggestion. The only reasonable cause I can come up with is that something goes wrong because the ligature is split between two different TextSpan.

The workaround for this is as already mentioned, disabling ligatures for the affected text. In code, this would be:
const TextSpan(
  children: [/* ... */],
  style: TextStyle(
    fontFeatures: [FontFeature.disable('liga')],
  ),
);

I was able to reproduce this using the provided code sample on 3.7.3 but not on the current Flutter master branch (https://github.com/flutter/flutter/commit/5d36cb77fbe6e8c09ed6232cc045f8b498f759c1)
If anyone is still seeing this on master, then can you provide a full reproduction and describe the device/platform where this is happening?

Closing as fixed on ToT.


Problem: ApeX project page

The warning:
Smart Contracts on L1 do not enforce at the moment availability of data in DAC.
Is no longer valid.
The system has been upgraded and there is now L1 enforcement of data in DAC.
Please remove the comment.

Issue fixed.


Add Interface For DefinedTargetClass and UndefinedTargetClass.

What do you guys think about adding an interface for these two classes? They're pretty similar. This approach would increase code security, since we can expect and predict a common interface dictated in a contract pattern. The only difference between the two interfaces is the implementation of __toString() and getInterfaces() in the DefinedTargetClass.

Sure!


LSP Code Completion of the DSL Structure

As a user of the AaC VSCode extension, I want code completion of AaC structures, so that it's easier and quicker for me to create definitions.

This story blocks #253

AC:

[ ] The LSP recommends any available definition in the root spec.
[ ] The LSP recommends extended structures from the ActiveContext
[ ] The LSP recommends unused, defined field names in a definition. That is, if the definition is a Field, and name has already been defined but type hasn't, the completion list will contain type and not name.
[ ] If a root item is already defined in the YAML document, that item will not be in the completion list. That is, if the YAML document already has an import key, further completion lists for that document will not contain import.

Marked this issue as 'wont do'. We need to break out the LSP features into smaller, targeted code completion stories.


DSD-997: Optimize npm release bundle

Fixes JIRA ticket DSD-997
This PR does the following:

Slightly decreases the bundle size for the npm package. More could be done?
The size of the bundled file is actually the same. If we want to optimize that, it'd be code changes.
What this does is remove the src folder from the npm package. This is not needed by consuming applications since they already have the dist folder. They also don't need test or storybook files. Doing this reduces the npm package size. Notice how in the screenshots below, the number of files in the npm package went from 389 to 122.

Before:

After removing "src" from the "files" object in package.json:

It's better and less than 1MB but it's still quite large. Chakra, for example, has 105KB "unpacked" size but I think it's because they export/publish every component on an individual basis. Comparisons are bad, anyway, but we should keep trying to reduce the size of the bundle. Maybe it's time to move away from TSDX and use a faster/better bundler.
How has this been tested?
By making a test npm release version 1.0.3-beta. I cannot deprecate this version but the -beta should be enough to let others know not to use it.
Accessibility concerns or updates

N/A

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

I think there are other options for us to bundle the code. TSDX was a good option for us to get started and get to where we are but now we should figure out how to really optimize the distributed, minified code bundle.