Release/ADAPT-000 Gallery/Campaign page logo fix

READY FOR REVIEW

(Edit the above to reflect status)

Summary

Prepare release with fixes that Patrick requested to go live before 11/20

Review By (Date)

When does this need to be reviewed by?

Criticality

How critical is this PR on a 1-10 scale? Also see Severity Assessment.
E.g., it affects one site, or every site and product?

Review Tasks
Setup tasks and/or behavior to test

Check out this branch
Navigate to...
Verify...

Front End Validation

[ ] Is the markup using the appropriate semantic tags and passes HTML validation?
[ ] Cross-browser testing has been performed?
[ ] Automated accessibility scans performed?
[ ] Manual accessibility tests performed?
[ ] Design is approved by @ user?

Backend / Functional Validation
Code

[ ] Are the naming conventions following our standards?
[ ] Does the code have sufficient inline comments?
[ ] Is there anything in this code that would be hidden or hard to discover through the UI?
[ ] Are there any code smells?
[ ] Are tests provided? eg (unit, behat, or codeception)

Code security

[ ] Are all forms properly sanitized?
[ ] Any obvious security flaws or new areas for attack?

General

[ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
[ ] Is the approach to the problem appropriate?

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

Resources

AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack and link to Browserstack Credentials

@sherakama Thanks for adding the workflow files! Is there a chance we could roll this out today? I'm thinking that since this is going live this Saturday and I'm out next week, it might be good roll this out a day earlier so we have tomorrow to fix anything if needed 🤔

@sherakama Thanks for adding the workflow files! Is there a chance we could roll this out today? I'm thinking that since this is going live this Saturday and I'm out next week, it might be good to roll this out a day earlier so we have tomorrow to fix anything if needed 🤔

Let's dual release today during our 1pm session.

@sherakama Thanks for adding the workflow files! Is there a chance we could roll this out today? I'm thinking that since this is going live this Saturday and I'm out next week, it might be good to roll this out a day earlier so we have tomorrow to fix anything if needed 🤔

Let's dual release today during our 1pm session.

Awesome - thanks, @sherakama ! 😄


PUPIL-720 feat(subjects): fix padding on subject list

Description
Music year: 2010
fix padding on subject list
Issue(s)
Fixes #
How to test

Go to https://deploy-preview-2462--oak-web-application.netlify.thenational.academy
You should see correct padding

Screenshots

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

Link here for review @RBrownsett: https://deploy-preview-2462--oak-web-application.netlify.thenational.academy/pupils/years/year-4/subjects

@benprotheroe, Thanks, I just noticed that the heading size for mobile needs updating to use heading-6 if possible. E.g:

:tada: This PR is included in version 1.449.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to get error http code

I want to get the http code when error occurs and onFailure method doesn't give http code. please give  any solution

onFailure() won't be triggered for a successfully delivered response, regardless of the status code. You should check the status code in onResponse(). Have another look at the documentation.

I want to segregate the errors under onFailure()
likeerror code 400, 404 and so on then how to handle these type of issue.

HTTP response codes are also delivered in the onResponse(Response resp). To check if the response is "successful"(i.e the response code belongs to [200, 300), you check using:
resp.isSuccessful()

Otherwise, it's an error and you can get the error code using:
resp.code()

No action for us to take here. If you have API questions, we're happy to help you on Stack Overflow!


Prevent cancelling init task modifying the current directory

Fixes #18080
Context

If a user cancels the gradle init task before completion, the current directory will no longer be modified. If no build.gradle or settings.gradle files exist in the current directory, the init task can be run. If the user runs this task by mistake and cancelled their input using CTRL+C, gradle files were created. There was potential for this to overwrite files. This PR fixes this issue. Gradle files will only be created when a user gives input all the questions in the init task.
Contributor Checklist

[X] Review Contribution Guidelines
[X] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[X] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[X] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[X] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[X] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[X] Ensure that tests pass sanity check: ./gradlew sanityCheck
[X] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation

Superseded by https://github.com/gradle/gradle/pull/27408


Incorrect Syntax : git clone --depth=1 https://github.com/angular/angular-seed.git

I have used the below command as per documentation and it is still carry on the history
git clone --depth=1 https://github.com/angular/angular-seed.git <your-project-name>
I am running git 2.6.3 for windows and git bash shell. its look like --depth=1 syntax is wrong and it should be like --depth 1. Could you please correct the syntax in the documentation?

git clone --depth 1
this might do the trick?

yes. please correct the documentation in github.
On Wed, Apr 27, 2016, 5:28 PM Raymond Hughes<EMAIL_ADDRESS>wrote:

git clone --depth 1
this might do the trick?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-seed/issues/335#issuecomment-215250473

I am pretty sure it works both ways.


Fork of this project receiving workflow notifications for failed jobs

@halx99 I synced my fork of this project today, and now I'm suddenly getting notifications like this:

Has something recently changed in the settings of this repository? I shouldn't be receiving these notifications since they're being run on this repository, not the fork I've created.  I'll see if there's a setting in the fork that I need to turn off, but this has never happened before.

Refer to #793

No worries. I'll close this issue since the other one covers it.


Pr/michi/majestic ketchup

Replace the connectivity package with the one from cilium/cilium repo. The main rationale for moving the connectivity package to cilium/cilium repo is to enable Cilium developers to implement new features and add tests for the new features without having to deal with multiple repos. According to @brb, this will drastically boost Cilium developers' productivity, bringing the feature development velocity to the next level. See CFP-25694 ^1 for additional details.
Renovate is configured to upgrade to cilium/cilium pre-releases ^2, so cilium-cli gets synced to the latest cilium/cilium connectivity package from the main branch roughly once every month.

to avoid breaking tests against older cilium versions:

run the latest cli tests against all maintained stable branches (e.g. v1.15, v1.14, v1.13) in addition to main.

to avoid breaking cilium-cli:

try vendoring the cilium/cilium pull request branch to cilium-cli repo. run tests.
update cilium-cli go.mod more frequently https://github.com/cilium/cilium-cli/blob/main/go.mod#L17

to further reduce developer pain points:

later on we might end up moving more stuff like k8s or sysdump packages. tbd.

i boldly assert that this pull request is ready to be merged based on the following three factors:

there are 4 approvals without any blocking reviews.
it is also approved by ipcache, contributing, and cli team since tobias is a member of these teams. github didn't remove these teams from the review list because the approval came while the pull request was still in draft.
this pull request only refactors the connectivity package without changing the actual test logic, and we've had a discussion regarding this refactoring in great details in CFP-25694. therefore i claim that getting approvals from all the owners of individual test files is a bit of an overkill.

happy merging everybody 🚀🙏


add openvz support for new ctop version

New request instead of https://github.com/yadutaf/ctop/pull/10 .
How I see I cannot work correct with collect_ensure_common() with openvz.
I move memory statistic to down and skip it on openvz, if if have not tasks.
In this version it work on node with https://github.com/yadutaf/ctop/issues/9, how I see.
Added key 'c' like checkpoint(it same that suspend in openvz, but not see like "stop") for openvz containers.
Other minor fixes for previos ugly moments like get_user_beacounts('root').

One last fix and we're good to go.
git commit -sa --amend
git push -f

Thanks.

Merged. Thanks!


Suggested description page styling tweaks

Found while testing https://github.com/microsoft/vscode-pull-request-github/issues/1152

While the page is loading, the text "Loading..." is displayed at the very top of the page with no padding. It would be nice to have a top margin for this, or possibly make it more central
The comment editor seems to have lost its padding between the text area and buttons:

Can I try this?

@Adam13531 Yes! The second bullet point has already been fixed. The code that adds the "Loading..." text is here: https://github.com/microsoft/vscode-pull-request-github/blob/d8088a6473db83738e477ec116b3bf9041dcb13c/preview-src/app.tsx#L22 and the stylesheet is preview-src/index.css

@Adam13531 Yes!

I think you may have tagged the wrong person. @Ashniu123, see the last response.

Should I just put an margin-top like

Loading...

? Or Add use the "title" class ?

It would be helpful to post some screenshots so we can visually compare the two

Would something like this work, or is this too far?
Before - no spacing:

After - centered:

@queerviolet
if this is still open and available? I would like to take it. I have centered the "Loading..." text and increased the font size so that it is more visible.

@rishab-pdx if your PR is ready then by all means... Go ahead! :D

@Ashniu123 that makes sense. Here is the final view.

Let me know what you think?


Separates to be displayed first

BEFORE
AFTER

Enhance mobile experience by showing the view icon first
Make active item less confusing

overall :+1:

:+1:


When the table starts in the first column of the first line the plugin adds some duplication to the table

|Left align|Right align|Center align|
|:---------|----------:|:----------:|
|This|This|This|
|column|column|column|
|will|will|will|
|be|be|be|
|left|right|center|
|aligned|aligned|aligned|

is formatted as
| Left align | Right align | Center align |
|:-----------|------------:|:------------:|
| This       |        This |     This     |
| column     |      column |    column    |
| will       |        will |     will     |
| be         |          be |      be      |
| left       |       right |    center    |
| aligned    |     aligned |   aligned    |
|        will |     will     |
| be         |          be |      be      |
| left       |       right |    center    |
| aligned    |     aligned |   aligned    |

It appears that when then table is the first thing in the document that the myIterator runs twice.

Changing line 75 from editor.backwardScanInBufferRange(@regex, range, myIterator)
to editor.scanInBufferRange(@regex, range, myIterator) seens to fix. But needs more tests.

I will take a look. Bear in mind that I'm insanely busy right now, so it may take a day or two for me to get to this.

Don't worry. Take your time... I'm not in a rush and I find it rather
difficult to someone use a table as the first thing in the document.
On Tue, Dec 15, 2015 at 10:36 AM Nikolay Yakimov<EMAIL_ADDRESS>wrote:

I will take a look. Bear in mind that I'm insanely busy right now, so it
may take a day or two for me to get to this.
—
Reply to this email directly or view it on GitHub
https://github.com/fcrespo82/atom-markdown-table-formatter/issues/23#issuecomment-164751291
.

--
Fernando Xavier de Freitas Crespo

Looks like this goes deeper than our little package. I've opened an issue on Atom's repo. Let's see what Atom devs say first.

I thought that too. Because the ranges were being reported correctly. Let's see what they will say.
--
Fernando X. F. Crespo

Em 15 de dez de 2015, às 16:49, Nikolay Yakimov<EMAIL_ADDRESS>escreveu:
Looks like this goes deeper than our little package. I've opened an issue on Atom's repo. Let's see what Atom devs say first.
—
Reply to this email directly or view it on GitHub.

So, it's a bug in Atom core after all. Fix is available, and will likely get into next minor release. https://github.com/atom/text-buffer/pull/120
That said, we don't have to scan backwards, I don't think. I've changed testing code to provide more coverage (also to save some scrolling) and added more editor-specific tests. You can find it in editor-tests branch. ColumnAsFirstItem is merged into that one already.

@lierdakil you're great, thank you very much for your help. There's some sense of achievement finding a bug in such a great product as Atom.
I thought we should use backwards scan not to mess with marker positions after inserting the formatting spaces, but appears as Atom already takes care of this.

Closed by #25


react-components: title bar

What's new

fixes #273 #274

My previous commits in the other PR were not verified and signed off, hence I cherry-picked the commits and pushed them to this new branch instead.
This addresses previous comments about the alignment of the content in the bar.
I will proceed to remove the previous branch.
Self-checks

[x] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

@koonpeng thanks for the comments / feedback!!

Getting this error in the CI, is this something that is being fixed? because I have pulled in changes from main!
><EMAIL_ADDRESS>lint /__w/rmf-web/rmf-web/packages/reporting-server
> python3 -m pipenv run pylint rest_server

************* Module rest_server.repositories.test_log_creation_handler
rest_server/repositories/test_log_creation_handler.py:6:0: C0411: third party import "from tortoise import Tortoise" should be placed before "from models import DispenserState, DoorState, RawLog" (wrong-import-order)

Also the force push is because I had duplicate commits when trying to resolve the DCO failure..
Updated the files to reflect the changes that you mentioned above! Let me know if there are other changes I should make.
Thanks @koonpeng. Sorry about the slow progress as well.

@matiasbavera Can you check if the changes to reporting-server is correct?

Hey @vallq can you rebase this into main? Because if not this will replace all the changes I made on the report server

Ok! Thanks @matiasbavera


is there a way to do this in windows

i found out that windows doesn't support nvidia-docker which means i can't install the tensorflow-gpu in windows , is there a workaround ?

Hi, sorry, I am not a Windows user and as such, it would be hard to maintain a Windows support. As far as I am aware, NVIDIA Docker does not support Windows either: https://github.com/NVIDIA/nvidia-docker/wiki/Frequently-Asked-Questions#is-microsoft-windows-supported

thanks, i installed linux for this purpose the image works great , thanks again.
Le samedi 21 mai 2022, 16:44:15 UTC+2, Filip Matzner @.***> a écrit :
Hi, sorry, I am not a Windows user and as such, it would be hard to maintain a Windows support. As far as I am aware, NVIDIA Docker does not support Windows either: https://github.com/NVIDIA/nvidia-docker/wiki/Frequently-Asked-Questions#is-microsoft-windows-supported
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Playground could take schema from registry not from introspection

Component(s)
studio
Is your feature request related to a problem? Please describe.
Due to security reasons we don't want to expose introspection in our production clusters, but that is a problem with Cosmo's playground as it relies on introspection, without that we are not able to use it.
Describe the solution you'd like
It could automatically take latests compose schema from registry instead.
Describe alternatives you've considered
No response
Additional context
No response

It's a good idea. This would also increase the startup time of the playground for large schemas. Creating a ticket for the team. Updating progress here. Currently no priority.

It's in progress.

That was quick, thank you!


SFTP support (intgrated into File Explorer)

[Feature Request]
Could you make SFTP integration into the File Explorer? Like there is already FTP:// support, could you make SFTP:// support? I would love to be able to reach my SFTP shares without too much hassle in third party software.

This issue would be better integrated into Windows itself. Here is the link to an open issue, where you can vote on : https://aka.ms/AA60zm4


Add callysto cluster and hub

Ref https://github.com/2i2c-org/infrastructure/issues/1439
Creates a regional cluster in northamerica-northeast1-b (Montreal, gpu machines are available in this zone also, just in case we need them).
Other assumptions made would be that the storage buckets will be disabled since they won't probably be needed, as this hub is an educational one. Also, although right now it would be a single tenant cluster, maybe this would change in the future, so I left enable_network_policy set to true since I don't think we are so strict on the costs.
Config inspiration was from the cloudbank cluster, since that holds edu hubs

Terraform plan output:
Terraform will perform the following actions:

  # google_container_cluster.cluster will be created
  + resource "google_container_cluster" "cluster" {
      + cluster_ipv4_cidr           = (known after apply)
      + datapath_provider           = (known after apply)
      + default_max_pods_per_node   = (known after apply)
      + enable_binary_authorization = false
      + enable_intranode_visibility = (known after apply)
      + enable_kubernetes_alpha     = false
      + enable_l4_ilb_subsetting    = false
      + enable_legacy_abac          = false
      + enable_shielded_nodes       = true
      + enable_tpu                  = false
      + endpoint                    = (known after apply)
      + id                          = (known after apply)
      + initial_node_count          = 1
      + label_fingerprint           = (known after apply)
      + location                    = "northamerica-northeast1"
      + logging_service             = (known after apply)
      + master_version              = (known after apply)
      + monitoring_service          = (known after apply)
      + name                        = "callysto-cluster"
      + network                     = "default"
      + networking_mode             = (known after apply)
      + node_locations              = [
          + "northamerica-northeast1-b",
        ]
      + node_version                = (known after apply)
      + operation                   = (known after apply)
      + private_ipv6_google_access  = (known after apply)
      + project                     = "callysto-202316"
      + remove_default_node_pool    = true
      + self_link                   = (known after apply)
      + services_ipv4_cidr          = (known after apply)
      + subnetwork                  = (known after apply)
      + tpu_ipv4_cidr_block         = (known after apply)

      + addons_config {
          + cloudrun_config {
              + disabled           = (known after apply)
              + load_balancer_type = (known after apply)
            }

          + config_connector_config {
              + enabled = (known after apply)
            }

          + dns_cache_config {
              + enabled = (known after apply)
            }

          + gce_persistent_disk_csi_driver_config {
              + enabled = (known after apply)
            }

          + gcp_filestore_csi_driver_config {
              + enabled = (known after apply)
            }

          + horizontal_pod_autoscaling {
              + disabled = true
            }

          + http_load_balancing {
              + disabled = true
            }

          + istio_config {
              + auth     = (known after apply)
              + disabled = (known after apply)
            }

          + kalm_config {
              + enabled = (known after apply)
            }

          + network_policy_config {
              + disabled = (known after apply)
            }
        }

      + authenticator_groups_config {
          + security_group = (known after apply)
        }

      + cluster_autoscaling {
          + autoscaling_profile = "OPTIMIZE_UTILIZATION"
          + enabled             = false

          + auto_provisioning_defaults {
              + image_type       = (known after apply)
              + min_cpu_platform = (known after apply)
              + oauth_scopes     = (known after apply)
              + service_account  = (known after apply)
            }
        }

      + cluster_telemetry {
          + type = (known after apply)
        }

      + confidential_nodes {
          + enabled = (known after apply)
        }

      + database_encryption {
          + key_name = (known after apply)
          + state    = (known after apply)
        }

      + default_snat_status {
          + disabled = (known after apply)
        }

      + identity_service_config {
          + enabled = (known after apply)
        }

      + ip_allocation_policy {
          + cluster_ipv4_cidr_block       = (known after apply)
          + cluster_secondary_range_name  = (known after apply)
          + services_ipv4_cidr_block      = (known after apply)
          + services_secondary_range_name = (known after apply)
        }

      + logging_config {
          + enable_components = (known after apply)
        }

      + master_auth {
          + client_certificate     = (known after apply)
          + client_key             = (sensitive value)
          + cluster_ca_certificate = (known after apply)

          + client_certificate_config {
              + issue_client_certificate = (known after apply)
            }
        }

      + monitoring_config {
          + enable_components = (known after apply)
        }

      + network_policy {
          + enabled = true
        }

      + node_config {
          + disk_size_gb      = (known after apply)
          + disk_type         = (known after apply)
          + guest_accelerator = (known after apply)
          + image_type        = (known after apply)
          + labels            = (known after apply)
          + local_ssd_count   = (known after apply)
          + machine_type      = (known after apply)
          + metadata          = (known after apply)
          + oauth_scopes      = (known after apply)
          + preemptible       = false
          + service_account   = (known after apply)
          + spot              = false
          + taint             = (known after apply)

          + shielded_instance_config {
              + enable_integrity_monitoring = (known after apply)
              + enable_secure_boot          = (known after apply)
            }

          + workload_metadata_config {
              + mode = (known after apply)
            }
        }

      + node_pool {
          + initial_node_count          = (known after apply)
          + instance_group_urls         = (known after apply)
          + managed_instance_group_urls = (known after apply)
          + max_pods_per_node           = (known after apply)
          + name                        = (known after apply)
          + name_prefix                 = (known after apply)
          + node_count                  = (known after apply)
          + node_locations              = (known after apply)
          + version                     = (known after apply)

          + autoscaling {
              + max_node_count = (known after apply)
              + min_node_count = (known after apply)
            }

          + management {
              + auto_repair  = (known after apply)
              + auto_upgrade = (known after apply)
            }

          + network_config {
              + create_pod_range    = (known after apply)
              + pod_ipv4_cidr_block = (known after apply)
              + pod_range           = (known after apply)
            }

          + node_config {
              + boot_disk_kms_key = (known after apply)
              + disk_size_gb      = (known after apply)
              + disk_type         = (known after apply)
              + guest_accelerator = (known after apply)
              + image_type        = (known after apply)
              + labels            = (known after apply)
              + local_ssd_count   = (known after apply)
              + machine_type      = (known after apply)
              + metadata          = (known after apply)
              + min_cpu_platform  = (known after apply)
              + node_group        = (known after apply)
              + oauth_scopes      = (known after apply)
              + preemptible       = (known after apply)
              + service_account   = (known after apply)
              + spot              = (known after apply)
              + tags              = (known after apply)
              + taint             = (known after apply)

              + ephemeral_storage_config {
                  + local_ssd_count = (known after apply)
                }

              + gcfs_config {
                  + enabled = (known after apply)
                }

              + kubelet_config {
                  + cpu_cfs_quota        = (known after apply)
                  + cpu_cfs_quota_period = (known after apply)
                  + cpu_manager_policy   = (known after apply)
                }

              + linux_node_config {
                  + sysctls = (known after apply)
                }

              + sandbox_config {
                  + sandbox_type = (known after apply)
                }

              + shielded_instance_config {
                  + enable_integrity_monitoring = (known after apply)
                  + enable_secure_boot          = (known after apply)
                }

              + workload_metadata_config {
                  + mode = (known after apply)
                }
            }

          + upgrade_settings {
              + max_surge       = (known after apply)
              + max_unavailable = (known after apply)
            }
        }

      + notification_config {
          + pubsub {
              + enabled = (known after apply)
              + topic   = (known after apply)
            }
        }

      + release_channel {
          + channel = "UNSPECIFIED"
        }

      + workload_identity_config {
          + workload_pool = "callysto-202316.svc.id.goog"
        }
    }

  # google_container_node_pool.core will be created
  + resource "google_container_node_pool" "core" {
      + cluster                     = "callysto-cluster"
      + id                          = (known after apply)
      + initial_node_count          = 1
      + instance_group_urls         = (known after apply)
      + location                    = "northamerica-northeast1"
      + managed_instance_group_urls = (known after apply)
      + max_pods_per_node           = (known after apply)
      + name                        = "core-pool"
      + name_prefix                 = (known after apply)
      + node_count                  = (known after apply)
      + node_locations              = (known after apply)
      + operation                   = (known after apply)
      + project                     = "callysto-202316"
      + version                     = (known after apply)

      + autoscaling {
          + max_node_count = 5
          + min_node_count = 1
        }

      + management {
          + auto_repair  = true
          + auto_upgrade = false
        }

      + node_config {
          + disk_size_gb      = 30
          + disk_type         = (known after apply)
          + guest_accelerator = (known after apply)
          + image_type        = (known after apply)
          + labels            = {
              + "hub.jupyter.org/node-purpose" = "core"
              + "k8s.dask.org/node-purpose"    = "core"
            }
          + local_ssd_count   = (known after apply)
          + machine_type      = "n1-highmem-4"
          + metadata          = (known after apply)
          + oauth_scopes      = [
              + "https://www.googleapis.com/auth/cloud-platform",
            ]
          + preemptible       = false
          + service_account   = (known after apply)
          + tags              = []
          + taint             = (known after apply)

          + shielded_instance_config {
              + enable_integrity_monitoring = (known after apply)
              + enable_secure_boot          = (known after apply)
            }

          + workload_metadata_config {
              + mode = (known after apply)
            }
        }

      + upgrade_settings {
          + max_surge       = (known after apply)
          + max_unavailable = (known after apply)
        }
    }

  # google_container_node_pool.notebook["user"] will be created
  + resource "google_container_node_pool" "notebook" {
      + cluster                     = "callysto-cluster"
      + id                          = (known after apply)
      + initial_node_count          = 0
      + instance_group_urls         = (known after apply)
      + location                    = "northamerica-northeast1"
      + managed_instance_group_urls = (known after apply)
      + max_pods_per_node           = (known after apply)
      + name                        = "nb-user"
      + name_prefix                 = (known after apply)
      + node_count                  = (known after apply)
      + node_locations              = (known after apply)
      + operation                   = (known after apply)
      + project                     = "callysto-202316"
      + version                     = (known after apply)

      + autoscaling {
          + max_node_count = 20
          + min_node_count = 0
        }

      + management {
          + auto_repair  = true
          + auto_upgrade = false
        }

      + node_config {
          + disk_size_gb      = (known after apply)
          + disk_type         = "pd-balanced"
          + guest_accelerator = (known after apply)
          + image_type        = (known after apply)
          + labels            = {
              + "hub.jupyter.org/node-purpose" = "user"
              + "k8s.dask.org/node-purpose"    = "scheduler"
            }
          + local_ssd_count   = (known after apply)
          + machine_type      = "n1-highmem-4"
          + metadata          = (known after apply)
          + oauth_scopes      = [
              + "https://www.googleapis.com/auth/cloud-platform",
            ]
          + preemptible       = false
          + service_account   = (known after apply)
          + tags              = []
          + taint             = [
              + {
                  + effect = "NO_SCHEDULE"
                  + key    = "hub.jupyter.org_dedicated"
                  + value  = "user"
                },
            ]

          + shielded_instance_config {
              + enable_integrity_monitoring = (known after apply)
              + enable_secure_boot          = (known after apply)
            }

          + workload_metadata_config {
              + mode = "GKE_METADATA"
            }
        }

      + upgrade_settings {
          + max_surge       = (known after apply)
          + max_unavailable = (known after apply)
        }
    }

  # google_project_iam_custom_role.requestor_pays will be created
  + resource "google_project_iam_custom_role" "requestor_pays" {
      + deleted     = (known after apply)
      + description = "Minimal role for hub users on callysto to identify as current project"
      + id          = (known after apply)
      + name        = (known after apply)
      + permissions = [
          + "serviceusage.services.use",
        ]
      + project     = "callysto-202316"
      + role_id     = "callysto_requestor_pays"
      + stage       = "GA"
      + title       = "Identify as project role for users in callysto"
    }

  # google_project_iam_member.cd_sa_roles["roles/artifactregistry.writer"] will be created
  + resource "google_project_iam_member" "cd_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/artifactregistry.writer"
    }

  # google_project_iam_member.cd_sa_roles["roles/container.admin"] will be created
  + resource "google_project_iam_member" "cd_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/container.admin"
    }

  # google_project_iam_member.cluster_sa_roles["roles/artifactregistry.reader"] will be created
  + resource "google_project_iam_member" "cluster_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/artifactregistry.reader"
    }

  # google_project_iam_member.cluster_sa_roles["roles/logging.logWriter"] will be created
  + resource "google_project_iam_member" "cluster_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/logging.logWriter"
    }

  # google_project_iam_member.cluster_sa_roles["roles/monitoring.metricWriter"] will be created
  + resource "google_project_iam_member" "cluster_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/monitoring.metricWriter"
    }

  # google_project_iam_member.cluster_sa_roles["roles/monitoring.viewer"] will be created
  + resource "google_project_iam_member" "cluster_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/monitoring.viewer"
    }

  # google_project_iam_member.cluster_sa_roles["roles/stackdriver.resourceMetadata.writer"] will be created
  + resource "google_project_iam_member" "cluster_sa_roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "callysto-202316"
      + role    = "roles/stackdriver.resourceMetadata.writer"
    }

  # google_service_account.cd_sa will be created
  + resource "google_service_account" "cd_sa" {
      + account_id   = "callysto-cd-sa"
      + disabled     = false
      + display_name = "Continuous Deployment SA for callysto"
      + email        = (known after apply)
      + id           = (known after apply)
      + name         = (known after apply)
      + project      = "callysto-202316"
      + unique_id    = (known after apply)
    }

  # google_service_account.cluster_sa will be created
  + resource "google_service_account" "cluster_sa" {
      + account_id   = "callysto-cluster-sa"
      + disabled     = false
      + display_name = "Service account used by nodes of cluster callysto"
      + email        = (known after apply)
      + id           = (known after apply)
      + name         = (known after apply)
      + project      = "callysto-202316"
      + unique_id    = (known after apply)
    }

  # google_service_account_key.cd_sa will be created
  + resource "google_service_account_key" "cd_sa" {
      + id                 = (known after apply)
      + key_algorithm      = "KEY_ALG_RSA_2048"
      + name               = (known after apply)
      + private_key        = (sensitive value)
      + private_key_type   = "TYPE_GOOGLE_CREDENTIALS_FILE"
      + public_key         = (known after apply)
      + public_key_type    = "TYPE_X509_PEM_FILE"
      + service_account_id = (known after apply)
      + valid_after        = (known after apply)
      + valid_before       = (known after apply)
    }

Plan: 14 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + buckets                   = {}
  + ci_deployer_key           = (sensitive value)
  + kubernetes_sa_annotations = {}
  + registry_sa_keys          = (sensitive value)

──────────────────────────────────────────

According to our docs, I believe I first need an approval for the config, before running terraform apply and add the cluster to the various workflows

For setting up new infra, I think there's no need to wait on first review to start iterating. I think it's covered in https://infrastructure.2i2c.org/en/latest/contributing/code-review.html?highlight=terraform#changes-to-set-up-new-infrastructure.
I'm not sure we need to redeploy either!

Sorry about it! Thank you @yuvipanda!

I actually have a suggestion here - let's use Google Filestore and not manually manage an NFS server.

Thanks for the suggestion @yuvipanda! I've deleted the manually deployed vm and switched the cluster to use GFS. But just to make sure I understand, the reason behind this is to avoid performing those manual steps to create the vm, right? Are there any other technicalities that make GFS the better choice? thanks!
Update on the state of the cluster and hub

there is a new regional callysto cluster that's running and uses GFS to store the user data
all support components are up and running
there is a staging cluster that's running at https://staging.callysto.2i2c.cloud/ which uses cilogon authentication and allows Google + Microsoft authentication.

HOWEVER

The usernames are opaque ids, corresponding to the oidc claim returned by CILogon, which is actually the sub claim as returned by Google and Microsoft (more about this https://www.cilogon.org/oidc) - which should be unique.

IMPASSE
I am in an impasse however on how to deal with the allowed_users and admin_users in this  case, because we cannot know these unique ids before and even if we would, that would mean maintaining this lists by hand?
There is also the issue of tracing back support requests to the users, which in theory would be possible with the current hub version if auth_state would show up in the admin panel like:

Context
The utoronto hub is another hub that uses unique identifiers for the users, but since allowing users is done through only allowing login in through the utoronto portal. This is not the case here, since we want to allow logging in with Google and Microsoft.
Where I need help
The only solution I can think of right now is to override the authenticate method of the CILogonOAuthenticator so that it performs the allowed_domain check on the email claim, but returns the authenticated user as the one identified by the oidc claim.
But maybe there's something better that can be done? I would really appreciate a set of fresh eyes looking at thins, since I feel I am in a bit of a loop maybe (cc @yuvipanda)

Sorry for the extra ping @yuvipanda and @2i2c-org/tech-team, but can please help unblock me with on the above matter ⬆ ? thank you!

But just to make sure I understand, the reason behind this is to avoid performing those manual steps to create the vm, right? Are there any other technicalities that make GFS the better choice? thanks!

Yes - GFS is fully automated, while manual NFS isn't. Plus, it is much easier to resize a GFS than a manually deployed NFS VM.

@GeorgianaElena re: authentication, were we planning on allowing anyone with a Microsoft or Google account (based on https://github.com/2i2c-org/infrastructure/issues/1439#issuecomment-1218591404)? If that's the case, I think for admins we should ask the admins to log in, and ask for their opaque ID. It can be found if they go to the JupyterHub Control Panel. For example, if I go to https://jupyter.utoronto.ca/hub/home I can see my user id on the top right:

We can add those to the admin list once admins log in and report their opaque UID to us. This is also how support can be provided - users can self-report their Opaque UID when asking for support.
Hope this helps!

@GeorgianaElena re: authentication, were we planning on allowing anyone with a Microsoft or Google account (based on https://github.com/2i2c-org/infrastructure/issues/1439#issuecomment-1218591404)?

Hmm, not sure if they want to allow anyone but I will ask. I assumed they would like to keep a list of allowed users at least. Esp since we don't have extraordinary experiences with the hubs where we enabled this kind of loose access.

We can add those to the admin list once admins log in and report their opaque UID to us. This is also how support can be provided - users can self-report their Opaque UID when asking for support.

I believe not knowing each users opaque UID disables the ability to have an allowed list because the people will need to login to find their id.
But CILogon provides a service which I believe checks which attributes returns an identity provider, and it's running at https://cilogon.org/testidp/. You can then login with the IDP and account you'd like to access the hub, go to the User Attributes section there, and get the OpenID returned there, which is what we're using to identify the users in this hub (I double checked with my account and this is it)
We could use this to find out the admin's Opaque IDs and the admins could ask the users get their oids to providem access to the hub.
WDYT @yuvipanda ?
IT looks like this:

@2i2c-org/tech-team, can you please login into https://2i2c.callysto.ca then retrieve the hub username from there so I can add it as a hub admin?

I am<PHONE_NUMBER>68212778437 (We should maybe add comments in the config to map who is who... you've probably already thought of that!)

We should maybe add comments in the config to map who is who... you've probably already thought of that!

Kind of 😅 I believe the community rep wants to keep theirs private, so I'll probably have staff ones mapped and add the others through the hub Admin Panel.

Hmmm, I'm going to have to pause that workflow that posts the plans and figure out why it's posting multiple times instead of updating an existing comment...

Edit: I opened https://github.com/2i2c-org/infrastructure/issues/1675 to track

Thanks a lot @sgibson91 ✨
Feedback
I believe this is ready for review again. I will check with the callysto folks if they are able to login, but my plan is to get this merged, then iterate on further request from them in other PRs

Thanks @yuvipanda! I opened https://github.com/2i2c-org/infrastructure/issues/1678 and will merge this now as it is, but I plan to open a follow-up PR to use an allowed list of users until we find other abuse protection mechanisms for it, or until the hub will need to be used.


'' is an incorrect path for a scene file. BuildPlayer expects paths relative to the project folder.

When I try build instant app with button "Build for play console" I have error: " '' is an incorrect path for a scene file. BuildPlayer expects paths relative to the project folder. " Override Scenes (Optional) is empty. Could you investigate this issue? Thanks

Hi, thanks for filing this issue.
If you've been using release v0.7 of the plugin, my suspicion is that this may be an issue fixed by pull #20. I just released v0.8 of the plugin that includes the fixes from #20.
Do you mind trying release v0.8 to see if that fixes your issue?
Another possibility is that there is an issue with the selected scenes from Unity's Build Settings window. Do you mind sharing your Unity version as well as a screen shot of this window so I can see if anything looks unusual?
Thanks again.

Hi,
I tried v0.8 but the issue was not fixed.
I use Unity 2018.2.2f1 on Mac OS. Here you are screenshot: https://pasteboard.co/Hzi4lX4.png
Thanks.

Thanks for sharing your Unity version.
I apologize, but I was not clear when I requested a screenshot. What I had intended to request was the Build Settings windows. Is it possible for you to share a screenshot of those?
For example:

Here you are:

I just wanted to say I ran into this issue today with a fresh attempt to install. I am on OSX

Check your "BuildPipeline.BuildPlayer" function, I caused by incorrect because levels of parameters

Hey!
I had this same problem. I realized that in my case with Jenkins, the EditorBuildSettings do not save like in your screenshot in wherever else you have the project opened. They get deleted.
So what I did is, I first let Jenkins clone the project. Then I open it in a Unity Editor (whatever version you project lives in) and then I add the scenes I want to build to the Build Settings. Then I run Jenkins again and it finally finds the scenes to build.
Hope that helps!


Added ability to pass Edge instance to reachable method

@Thenerdstation, it's almost done! feel free to comment or ask any changes.

I think it's almost done.
A very very simple test added; cause i'm still beginner at it 😅


Allow url-map tests to run concurrently

This PR utilizes the multi-run feature introduced in https://github.com/grpc/grpc/pull/26542. The TD resources and backends will be shared, and each run will have a unique client namespace.
Internal changes: cl/386366746

https://fusion2.corp.google.com/invocations/31591d4c-8f1d-403f-814e-b1d76bc4a676/targets

:shipit:

Learnt yet another interesting trivia https://www.quora.com/On-GitHub-what-is-the-significance-of-the-Ship-It-squirrel.

Known failures: https://github.com/grpc/grpc/issues/26595


[0011] Get the vk::SpirvType or vk::SpirvOpaqueType of an expression

Which proposal does this relate to?
0011-inline-spirv.md
Describe the issue or outstanding question.
Banging my head against the wall trying to make Combined Sampler Images, or PhysicalStoragePointers (BDA) using types that are not "wholly build from ground up with vk::SpirvType"
For example I have
struct MyAggregate
{
   int32_t a,b;
};

For a regular vk::RawBufferLoad or a StructuredBuffer, DXC seems to make some meta-types that don't match vk::SpirvType<..,T> I'd make myself.
This gets in the way of doing OpAccessChain or similar things, because the types don't have the same %result_id from an OpType.. even though the types may be identically defined.
Additional context
I've outlined list of vastly different currently open DXC issues that may touch upon this here:
https://github.com/microsoft/DirectXShaderCompiler/issues/6578#issuecomment-2103318352
I'd also settle for getting the vk::spirvType of a type instead of an expression, this would be enough to e.g. have the exact same type that a Texture2D is using, or getting the basic MyAggregate typedef to make pointers out of.
This seems to be the final stumbling block (first being that the offsetof member decorations seem to just simply not work) for me to implement the equivalent of Proposal 0010 in user-space while also addressing #57

I don't think we need anything new in HLSL to handle this. The issue is the compiler implementation. The errors can vary depending on the situation. Some times there are issues with the compiler duplicating types in the spir-v. We have a solution for that with pointers. This will be harder with structs.
Another problem is how to specify the layout. There is no good solution for that in DXC.
We will leave this open to remind us of this when implementing inline spir-v in clang.


[FLINK-7334] [futures] Replace Flink's futures with Java 8's CompletableFuture in RpcEndpoint, RpcGateways and RpcService

What is the purpose of the change
Replace Flink's futures with Java 8's CompletableFuture in RpcEndpoint, RpcGateways and RpcService. Moreover, it removes the remaining usage of Flink futures in tests.
Brief change log

Change RpcCompletenessTest to only accept CompletableFutures as return type
Change signature of RpcGateways
Adapt all RpcEndpoint implementations
Remove Flink Future usage from remaining tests

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)

Documentation

Does this pull request introduce a new feature? (no)

Thanks for your review @zentol. I've addressed your comments.

Thanks for reviewing @zentol. I'll address your comments and then merge this PR.


Feature/async

Trying to fix build warnings and SwiftLint warnings

@wmcginty Can you please review and merge in the PR to the feature/async branch?


chore: bump version to 1.1.7

Pull Request Test Coverage Report for Build 204451247

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.136%

Totals

Change from base Build 175647445:
0.0%

Covered Lines:
45

Relevant Lines:
52

💛  - Coveralls

Pull Request Test Coverage Report for Build 204451247

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.136%

Totals

Change from base Build 175647445:
0.0%

Covered Lines:
45

Relevant Lines:
52

💛  - Coveralls

Pull Request Test Coverage Report for Build 204451247

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.136%

Totals

Change from base Build 175647445:
0.0%

Covered Lines:
45

Relevant Lines:
52

💛  - Coveralls


deps: Upgrade all; fix build_runner

Commit messages:

lint: Update database.g.dart to suppress unnecessary_cast too
This happens automatically if you rerun build_runner.  Seems like
its omission was basically a mismerge between 901a99eb8, when it
was merged early from #84:
https://github.com/zulip/zulip-flutter/pull/84#issuecomment-153384586
and 780b09283 / #22, which added this file.
Chalk it up as another occasion where #60 would have helped keep
things clean.

deps: Upgrade drift, drift_dev, sqlparser
The upgrade to drift_dev 2.8.x seems to be required in order to
work with the upgrade to analyzer 5.12.0 that we took in 861a92911.
The others are in turn required for that.
This makes another occasion where having CI, #60, would have helped
keep things clean for us.

deps: Upgrade watcher
With a recent Dart SDK from Flutter main, this is required in
order for build_runner to work.  Otherwise it gives an error
like (reformatted):
Failed to build build_runner:build_runner:
../../.pub-cache/hosted/pub.dev/watcher-1.0.2/lib/src/constructable_file_system_event.dart:7:57:
  Error: The class 'FileSystemEvent' can't be extended, implemented,
  or mixed in outside of its library because it's a sealed class.
abstract class _ConstructableFileSystemEvent implements FileSystemEvent {

deps: Upgrade Flutter to latest main, 3.11.0-16.0.pre.11

deps: Upgrade packages within constraints (flutter pub upgrade)
There are currently no upgrades that --major-versions would add
beyond these.

Hmm. After checking out this branch (then rebasing atop current main, which has f757587), I ran flutter pub get:
$ flutter pub get
Resolving dependencies...
The current Dart SDK version is 3.1.0-136.0.dev.

Because zulip requires SDK version >=3.1.0-155.0.dev <4.0.0, version solving failed.

Then flutter upgrade:
$ flutter upgrade
Upgrading Flutter to 3.11.0-16.0.pre.33 from 3.11.0-12.0.pre.15 in
/Users/chrisbobbe/.local/lib/flutter...

[…etc., success]

Then flutter pub get:
$ flutter pub get
Resolving dependencies... (1.8s)
  file 6.1.4 (7.0.0 available)
  file_picker 5.3.1 (5.3.2 available)
  http 0.13.6 (1.0.0 available)
  image_picker_android 0.8.6+16 (0.8.6+17 available)
> matcher 0.12.16 (was 0.12.15)
> test 1.24.3 (was 1.24.2)
> test_api 0.6.0 (was 0.5.2)
> test_core 0.5.3 (was 0.5.2)
  win32 4.1.4 (5.0.3 available)
  win32_registry 1.1.0 (1.1.1 available)
Changed 4 dependencies!

Then (probably relevant to that last command) there were some changes to pubspec.lock:
diff --git pubspec.lock pubspec.lock
index a4568c8fa..7aa872539 100644
--- pubspec.lock
+++ pubspec.lock
@@ -500,10 +500,10 @@ packages:
     dependency: transitive
     description:
       name: matcher
-      sha256: "6501fbd55da300384b768785b83e5ce66991266cec21af89ab9ae7f5ce1c4cbb"
+      sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
       url: "https://pub.dev"
     source: hosted
-    version: "0.12.15"
+    version: "0.12.16"
   material_color_utilities:
     dependency: transitive
     description:
@@ -817,26 +817,26 @@ packages:
     dependency: "direct dev"
     description:
       name: test
-      sha256: "4f92f103ef63b1bbac6f4bd1930624fca81b2574464482512c4f0896319be575"
+      sha256: "13b41f318e2a5751c3169137103b60c584297353d4b1761b66029bae6411fe46"
       url: "https://pub.dev"
     source: hosted
-    version: "1.24.2"
+    version: "1.24.3"
   test_api:
     dependency: transitive
     description:
       name: test_api
-      sha256: daadc9baabec998b062c9091525aa95786508b1c48e9c30f1f891b8bf6ff2e64
+      sha256: "75760ffd7786fffdfb9597c35c5b27eaeec82be8edfb6d71d32651128ed7aab8"
       url: "https://pub.dev"
     source: hosted
-    version: "0.5.2"
+    version: "0.6.0"
   test_core:
     dependency: transitive
     description:
       name: test_core
-      sha256: "3642b184882f79e76ca57a9230fb971e494c3c1fd09c21ae3083ce891bcc0aa1"
+      sha256: "99806e9e6d95c7b059b7a0fc08f07fc53fabe54a829497f0d9676299f1e8637e"
       url: "https://pub.dev"
     source: hosted
-    version: "0.5.2"
+    version: "0.5.3"
   timing:
     dependency: transitive
     description:

I checked, and at least one of those package versions was already out (link) when you wrote this branch, so it seems like that new version could have been taken then. I wonder why it wasn't; any ideas?

I checked, and at least one of those package versions was already out (link) when you wrote this branch, so it seems like that new version could have been taken then. I wonder why it wasn't; any ideas?

If you try the same Flutter version that's named in this branch, I'd expect you get no updates beyond what's in the branch.
It can take a bit for updates to other packages to roll into Flutter's dependencies, so I'd guess that that just hadn't happened yet as of the version I upgraded to (which was the latest Flutter main at that time.)

If you try the same Flutter version that's named in this branch, I'd expect you get no updates beyond what's in the branch.

Yeah. In my Flutter clone, if I set main to flutter/flutter@1dc26f80f, then in the project repo flutter --version gives
$ flutter --version
Flutter 3.11.0-16.0.pre.11 • channel main •
https://github.com/flutter/flutter.git
Framework • revision 1dc26f80f0 (27 hours ago) • 2023-05-30 15:37:12 -0400
Engine • revision a6d3124ced
Tools • Dart 3.1.0 (build 3.1.0-155.0.dev) • DevTools 2.23.1

and flutter pub get doesn't make any changes.

It can take a bit for updates to other packages to roll into Flutter's dependencies, so I'd guess that that just hadn't happened yet as of the version I upgraded to (which was the latest Flutter main at that time.)

I think this happens a few commits after flutter/flutter@1dc26f80f; in particular, I'm pretty sure it happens in flutter/flutter@0763d61f5.

LGTM, thanks! Please merge at will.
(Then updating past flutter/flutter@0763d61f5 or whatever—probably just to current main—can be a followup.)


[WIP] refactor: refine cycle reference error messages and add unit test cases.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re #101

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/global.rs
kclvm/sema/src/resolver/import.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

The test case test_resolve_program_cycle_reference_fail in kclvm/sema/src/resolver/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

73 of 74 (98.65%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 52.454%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/sema/src/resolver/global.rs
27
28
96.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
18904

Relevant Lines:
36039

💛  - Coveralls


Update the number of nuget packages downloads on the Platform website #5747

this close  #5747

@jacksonalexg99 Thanks for submitting this PR, but resolving multiple issues in the same PR is not allowed in this repo.
please review your changes and submit a new PR.
I'm sorry but this PR is rejected and I have to close it.


Fix the composer serve command for PHP 7.1.14+ and PHP 7.2.2+

This PR fixes the composer serve command as discussed in #196.
Closes #196

Thanks, @xtreamwayz!


Activator.CreateInstance doesn't work when you have a static constructor

https://deck.net/7bd4fb9a40a0c667b112afd67d2c7423

Dotnet fiddle sample: https://dotnetfiddle.net/hEk4rd
Corresponding deck: https://deck.net/853b312bbb6ccc9825698d5dec4865a3 (just changes the sample to run an assertion)

Fixed! This will be included in the next Bridge release.


Pancred update

Few Updates to the pancrebble stuff in oref0.
put the urchin loop completely inside the peb-urchin-status.sh
add the ability to turn off the urchin loop completely so you can run only notifications.
add of the urchin status for the current temp basal.

@Bender1061 hope you're recovering well.
Have you tested this thoroughly enough to confirm that this is better than what's in dev now?  If so, I can merge to dev before the release to master, and then we can do a patch release later if we find anything else that needs fixing...

my surgeon got the flu, so we have set up the surgery for next week now.
but yes I've been running this and am very happy with the changes.
unless someone has any issues, I say lets put it in.


installation of zlib1g-dev required on Ubuntu 16.04

The library zlib1g-dev is not installed by default on the "Ubuntu 16.04 LTS" (virtual Machine from Azure), but it is required by MMT.
I suggest to enhanced the INSTALL.md, with a note like the one for java in the section related to "Option 3 - Installing from source)"
Something like:
Install g++ if not present
sudo apt-get install zlib1g-dev
or alternatively make it mandatory as the others

Merged into issue #231.


Allow for custom stubs

[x] Checked the codebase to ensure that your feature doesn't already exist.
[x] Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
[ ] Adjusted the Documentation.
[ ] Added tests to ensure against regression.

Description of the Change
this will allow to override the import/export stubs.
Why Should This Be Added?
For custom implementations of the make commands
Benefits
if devs decided to override the stubs they can make one with exactly the same name in stubs folder in their project
Possible Drawbacks
No drawbacks,
Verification Process
Actually I tried it manually, Basically it is the same code as laravel model make command
Applicable Issues
N/A

Hey @Mina-R-Meshriky ! Thanks for your contribution. I like the idea! Will test it out soon!

Thanks @Mina-R-Meshriky !


Feature: package a secondary entrypoint (e.g. "@my/lib/testing")

Type of Issue

[ ] Bug Report
[x] Feature Request

Description
Angular Package Format "describes secondary entry points": https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview
We should add a possibility to compile and package such secondary entry points.
How To Reproduce
n/a
Expected Behaviour
TBD
Usage w/ ng-packagr must be further specified!
End result should be, say our already existing lib is @my/lib:
import { TestingStuff } from '@my/lib/testing';

Version Information
ng-packagr: v1.0.0-pre.14

Would this be limited to a single secondary entry? Would it be possible to provide an array of entries?

@deebloo Why not?!
First straight-forward idea would be a simple key-value object:
{
  "lib": {
    "secondaryEntries": {
       "testing": "src/testing_api.ts",
       "foobar": "foobar.ts"
    }
  }
}

Don't know if this is too simple?!?
Or an array of secondaries??
{
  "secondaries": [
     { "name": "testing", "entryFile": "src/testing_api.ts"" }
    /* .. */
   ]
}

@dherges I would argue for the second option, the key names make it more explicit what you are doing and also makes it more flexible if new properties need to be added in the future

Needs to investigste further: secondaries produce a separate package.json
Technically its just another independent npm package which is (physically) embedded in the location of the main package
So - w/o changes to current version - it should be possible to write a second ng-package.json producing the output contained in the main ng-package's dist folder.
Cheers, David

On 16. Aug 2017, at 16:55, Danny Blue<EMAIL_ADDRESS>wrote:
@dherges I would argue for the second option, the key names make it more explicit what you are doing and also makes it more flexible if new properties need to be added in the future
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@dherges
This sounds interesting.
So in essence it would be a "cascade" of something like this?

Run ng-packagr -p ng-package.json that creates the package output in ./dist
Run ng-packagr -p ng-package-testing.json that creates package output in ./dist/testing

Is this how it should be done?

Generated dist output:

@martinmcwhorter you could try whether this works, but I haven't done sofar ...

Generated dist folder structure


Model Deployment Still Running After one hour

[Enter feedback here]
The following step runs for one hour and never completes (I tried twice):
service_name = 'my-diabetes-model'

service = Model.deploy(ws, service_name, [model], inference_config, overwrite=True)
service.wait_for_deployment(show_output=True)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c3dfa0c7-942e-7120-1f84-aeec42f9b10a
Version Independent ID: 18a7dc7e-11f3-f612-d239-1682f283aff5
Content: Tutorial: Create the predictive model with a notebook (part 1 of 2) - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-power-bi-custom-model.md
Service: machine-learning
Sub-service: core
GitHub Login: @samuel100
Microsoft Alias: samkemp

Thanks for the feedback! We are currently investigating and will update you shortly.


IndexError in syllabization and alignment

I just found this poking around on staging...I don't know how many chants this might be true for: /chant/396856.

I navigated to this page by following a link on the chant search page, specifically: /chant-search/?op=contains&order=has_melody&sort=asc

Strange. That chant seems to break regardless of how you access it (e.g. directly from the inventory of the source); it works fine in OldCantus, for what it's worth.
Same breakage happens to the  next item in your search results, http://<IP_ADDRESS>/chant/521098. Not sure what they have in common...

for both of these chants, chant.volpiano is \n (i.e. just a line break character) lol
This should not be too hard to fix. Nice catch!


Nuke: extract review slate does not respect ExtractReview pixel aspect scaling

Running version
3.14.7
Describe the bug
extract_review_slate.py follows pixel aspect ratio in instance data. If scale_pixel_aspect is turned off in global/publish/ExtractReview/profile, slate frame will have different pixel aspect ratio to the rest of the frames.
To Reproduce
Steps to reproduce the behavior:

Go to a shot with pixel aspect ratio of 2.
Make sure scale_pixel_aspect is on in ExtractReview profile.
Render and publish.
Slate and shot appears consistent.
Turn off "Scale pixel aspect" in ExtractReview and publish again.
Slate frame now appears different compared to the rest of shot frame range.

Expected behavior
Turning off scale_pixel_aspect in ExtractReview profile should apply for extract_review_slate as well.
Desktop (please complete the following information):

OS: Windows 10
Host: Nuke

[cuID:OP-5225]

already merged by https://github.com/ynput/OpenPype/pull/5304


Pydantic v2, pydantic-settings

Improve the project template to support Pydantic v2, where BaseSettings was moved to a separate package.
Maybe add support for choosing between Pydantic v1 and v2 (?).
In v2:

add pydantic-settings to requirements.txt
update imports to be like from pydantic_settings import BaseSettings

Fixed at https://github.com/Neoteroi/BlackSheep-API/commit/c2c74e825b7baa3c01c62f3588265eaf43242b2a


panic: missing environment variable 'GOLANG-NW'

OSX
go 1.6.3
I made a simple example app the same as yours
i installed it
i try then to run it and it blows up with:
panic: missing environment variable 'GOLANG-NW'
Is there a need for a special env variable to be present ?

worked it out. was doing the wrong things :)


missing prop mockup.payment.label.billTo.region=billTo_state in scripts for test servers

fixed in 2005 release (see https://jira.hybris.com/browse/RAY-374)
but we have to adjust in 1905 manually

This has already been addressed by #3715 and it's in our spartacus recipe.


Flaky Ruby test:

Seen at unrelated PR https://github.com/grpc/grpc/pull/2302.
https://grpc-testing.appspot.com/job/gRPC_pull_requests/587/config=dbg,language=ruby,platform=linux/console
D0706 18:18:15.299616865    6139 server.c:429] Waiting for all channels to close before destroying server
I0706 18:18:15.299874090    6139 completion_queue.c:229] RETURN_EVENT[0x4267890]: QUEUE_SHUTDOWN
...
I0706 18:18:15.304546673    6139 completion_queue.c:229] RETURN_EVENT[0x392a230]: QUEUE_SHUTDOWN
E0706 18:18:15.305227653    6139 metadata.c:371] assertion failed: ctx->mdtab_free == 0
/usr/local/rvm/rubies/ruby-2.1.5/bin/ruby -I/usr/local/rvm/gems/ruby-2.1.5/gems/rspec-core-3.3.1/lib:/usr/local/rvm/gems/ruby-2.1.5/gems/rspec-support-3.3.0/lib /usr/local/rvm/gems/ruby-2.1.5/gems/rspec-core-3.3.1/exe/rspec spec/generic/active_call_spec.rb spec/generic/client_stub_spec.rb spec/generic/rpc_desc_spec.rb spec/generic/rpc_server_pool_spec.rb spec/generic/rpc_server_spec.rb spec/generic/service_spec.rb spec/spec_helper.rb --tag server failed
rake aborted!
TypeError: no implicit conversion from nil to integer
/usr/local/rvm/gems/ruby-2.1.5/gems/rspec-core-3.3.1/lib/rspec/core/rake_task.rb:75:in `exit'
/usr/local/rvm/gems/ruby-2.1.5/gems/rspec-core-3.3.1/lib/rspec/core/rake_task.rb:75:in `run_task'
/usr/local/rvm/gems/ruby-2.1.5/gems/rspec-core-3.3.1/lib/rspec/core/rake_task.rb:87:in `block (2 levels) in define'
/usr/local/rvm/gems/ruby-2.1.5/gems/rspec-core-3.3.1/lib/rspec/core/rake_task.rb:85:in `block in define'
/usr/local/rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => all => suite:server
(See full trace by running task with --trace)
FAILED: tools/run_tests/run_ruby.sh [ret=1, pid=5949]
FAILED: Some tests failed
+ DOCKER_FAILED=true
++ cat docker.cid
+ DOCKER_CID=22ee3381afd58bd114dad33fd8719b2bf4b50a03a5bbcfeccba56b0081861ddc
+ docker kill 22ee3381afd58bd114dad33fd8719b2bf4b50a03a5bbcfeccba56b0081861ddc
22ee3381afd58bd114dad33fd8719b2bf4b50a03a5bbcfeccba56b0081861ddc
+ docker cp 22ee3381afd58bd114dad33fd8719b2bf4b50a03a5bbcfeccba56b0081861ddc:/var/local/git/grpc/report.xml /home/jenkins/workspace/gRPC_pull_requests/config/dbg/language/ruby/platform/linux
+ docker rm 22ee3381afd58bd114dad33fd8719b2bf4b50a03a5bbcfeccba56b0081861ddc
22ee3381afd58bd114dad33fd8719b2bf4b50a03a5bbcfeccba56b0081861ddc
[copy-to-slave] Copying 'report.xml', excluding nothing, from 'file:/home/jenkins/workspace/gRPC_pull_requests/config/dbg/language/ruby/platform/linux/' on 'hudson.slaves.DumbSlave[grpc-jenkins-worker3]' to 'file:/home/jenkins/jenkins_home/jobs/gRPC_pull_requests/workspace/config/dbg/language/ruby/platform/linux/' on the master.
Recording test results
Build step 'Publish JUnit test result report' changed build result to UNSTABLE
Finished: UNSTABLE

Travis got the exact same failure for that run, so maybe it's not a flake and Ruby is currently broken? https://travis-ci.org/grpc/grpc/jobs/69772550

PTAL: @jayantkolhe, @hsaliak cannot reproduce locally after 20 iterations, removing Beta label
Note, I'm also aware that there were other issues related to the failure 'assertion failed: ctx->mdtab_free == 0' that actually got resolved, so I'd prefer to close this completely.


fixes visual 2022 studio build error (copydata fails)

a small fix in D3D9 client cmakelist.txt (visual studio 2022 building problem)
fixes issue #184

this was fixed by cb00f0cfcfe2bc4798134f799e08a6de8533689b


Parallel jobs GitHub actions

@ryanjbaxter ready for your eyes :) shrinks the build to around 30min, just like circleci. thank you

I'm on vacation for the next week, I will take a look once I get back


Don't display distracting errors when WSS comm fails.

When there's an error communicating with the wss server, AppRTC js spams the js log with
Uncaught TypeError: Cannot read property 'toPrecision' of undefined
Uncaught TypeError: Cannot read property 'toPrecision' of undefined
Uncaught TypeError: Cannot read property 'toPrecision' of undefined
The reason is that the formatting logic does not deal when the stats values are null, like when the call fails to get up. The below is a suggestion to fix that, but I'm sure there's a better way (maybe not request stats until we know wss is ok)?

LGTM
This seems fine for now. In the future we might want to not display any stats if endTime is null (i.e. the call isn't connected), but I think this change is a good idea in any case.


Create Cesium3DTileset tree for entire tileset

Right now the Python package just converts a single file and creates a single tileset.json to contain that one tile. We need to change the Cesium3DTileset class so that you can add several (thousands to millions) of Tiles to a Tileset and it creates a json tree of those Tiles. That tree may be broken up into several external tileset.json files so that the browser doesn't have to load in a huge json text file for the entire Arctic.

Here's a basic rundown of what this Tileset tree will look like:
We only want to show 3D Tiles when the user is zoomed into zoom 13. The 3D Tiles are already in a tileset grid thanks to viz-staging. Right now, each Tile (b3dm) has it's own tileset.json, which means when Cesium is loaded, we would have to fetch a tileset.json for each individual tile, which would probably crash the browser.
Instead we need to build a Tileset tree so that only one tileset.json is fetched at first, and as the user pans around the globe more tileset.jsons are fetched dynamically.
This would look like:
Root Tileset
    TilesetA.json
    TilesetB.json
    TilesetC.json
    TilesetD.json

TilesetA
    TilesetAA.json
    TilesetBB.json
    TilesetCC.json
    TilesetDD.json

And keep repeating that process until the final tileset.json references the b3dm files themselves:
TilesetAAAAA
    tile.b3dm
    tile.b3dm
    tile.b3dm
    tile.b3dm

This example is breaking down the tile grid into 4x4s, but we might find 8x8s or 16x16 or whatever works better.

The geometricError for each tileset and tile will always be the same because all 3DTiles are the same size. We want to tell Cesium to start showing tiles when it reaches a certain geometricError (i.e. zoom level), which will always be the same since we have chosen to display 3DTiles at one zoom level.
The boundingVolume for each tileset and tile will be calculated based on the total boundingVolume for that level in the tree. So using the 4x4 example, the top-level boundingVolume will be one quadrant of the globe. Then the next level would be a quadrant of that quadrant. The boundingVolume tells Cesium to start displaying tiles inside that boundingVolume when the user has panned to a location inside the boundingVolume and is under the geometricError.

The Cesium 3DTile specification has more info: https://github.com/CesiumGS/3d-tiles/tree/main/specification#external-tilesets
Page 2 of this pdf about Cesium 3DTiles has example json to show how to point to an external json. You essentially just point to a json file rather than a b3dm file: https://portal.ogc.org/files/92685


Fix lost file data in filesystem store

Description
This patch fixes lost data in the case when a file was closed due to a timeout.
The bug manifests itself as follows:
In the first loop pass in get_part_ref, everything works smoothly. After the writer times out however, the buffer is split again. At this point, the buffer is empty, original data is lost, and an empty buffer is passed to writer.send(), causing an assert error.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
By building envoy extensions tests using
bazel test //test/extensions/...

I've been building this using 128 core machine, so the build is very IO intensive.
basic_cas.json config is enough to reproduce the issue. After this patch, the errors are gone.
As for the unit testing, I tried to create a test.
    #[tokio::test]
    async fn get_part_timeout_test() -> Result<(), Error> {
        let digest1 = DigestInfo::try_new(HASH1, VALUE1.len())?;
        let content_path = make_temp_path("content_path");
        let temp_path = make_temp_path("temp_path");

        fs::set_idle_file_descriptor_timeout(Duration::from_millis(100))
            .err_tip(|| "Error setting idle file descriptor timeout")?;

        assert_eq!(fs::idle_file_descriptor_timeout(), Duration::from_millis(100));

        let store = Arc::new(
            FilesystemStore::<FileEntryImpl>::new(&native_link_config::stores::FilesystemStore {
                content_path: content_path.clone(),
                temp_path: temp_path.clone(),
                eviction_policy: Some(native_link_config::stores::EvictionPolicy {
                    max_count: 3,
                    ..Default::default()
                }),
                ..Default::default()
            })
            .await?,
        );

        let store_pin = Pin::new(store.as_ref());
        // Insert data into store.
        store_pin.as_ref().update_oneshot(digest1, VALUE1.into()).await?;

        let (writer, mut reader) = make_buf_channel_pair();
        let store_clone = store.clone();
        let digest1_clone = digest1;

        tokio::spawn(async move { Pin::new(store_clone.as_ref()).get(digest1_clone, writer).await });

        // Check to ensure our first byte has been received. The future should be stalled here.
        let first_byte = DropCloserReadHalf::take(&mut reader, 1)
            .await
            .err_tip(|| "Error reading first byte")?;
        assert_eq!(first_byte[0], VALUE1.as_bytes()[0], "Expected first byte to match");

        sleep(Duration::from_millis(200)).await;

        let remaining_file_data = DropCloserReadHalf::take(&mut reader, 1024)
            .await
            .err_tip(|| "Error reading remaining bytes")?;

        assert_eq!(
            &remaining_file_data,
            VALUE1[1..].as_bytes(),
            "Expected file content to match"
        );

        Ok(())
    }

However, the test passes even before the patch, because the future in get_part_ref() doesn't time out for some reason. I don't consider myself a rust programmer, do you think you could help me with this?
Checklist

[X] Updated documentation if needed
[ ] Tests added/amended
[X] bazel test //...  passes locally
[X] PR is contained in a single commit, using git amend see some docs

This change is

Superseded by #439.


test: Correcting test for Table.plot_boxplots to not save the file the test uses to verify the result

Summary of Changes
test: Correcting test for Table.plot_boxplots to not save the file the test uses to verify the result

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ PYTHON
black
1
0
0
0.51s

✅ PYTHON
mypy
1

0
2.08s

✅ PYTHON
ruff
1
0
0
0.05s

✅ REPOSITORY
git_diff
yes

no
0.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

v0.12.0
GitHub release

Your semantic-release bot :package::rocket:


98.fix-faerie-gold.1

Fix the Faerie Gold attack and hSig uniqueness.

Note that this is on top of the 558.crypto_box.1 branch (#7). The changes starting from [f36e7a3e064daccc37f47e6d47a576a1f2a02228] are the relevant ones.

Superceded by #9.


[Release] Update cookbook versions for 18.0.0

I've tested doing this locally and this is blocked on uploading to conda-forge.

Conda-forge seems to be merged already: https://github.com/conda-forge/arrow-cpp-feedstock/pull/1584

The stable branch is now up to date with 18.0.0.


What ESP32 are u using?

Hi, i want to try your code for my dashboard in the caravan :-) but i cant upload it to an ESP32-WROOM-32U. (DEVKIT V4)
Arduino Error:
text section exceeds available space in board
The sketch uses 1640446 bytes (125%) of program storage. Maximum is 1310720 bytes.
Global variables use 53340 bytes (16%) of dynamic memory. Remaining 274340 bytes for local variables. Maximum is 327680 bytes.
Compiling error for board DOIT ESP32 DEVKIT V1

found it! (modify the partition 2mb app/ 2mb spiffs)


No error when trying to assign a non null to variable type hinted null.

Godot version:
3.2.1.stable.offical
OS/device including version:
win 10 home 10.0.18362 build 18362
HP laptop 15-da0xxx
Issue description:
Type hinting a variable to null doesn't give an error when you try to set it to a non null value it just stays null.
Steps to reproduce:
Type hint a variable to null with ":=null"
Minimal reproduction project:
Map Editor.zip

:=null might not type it as "null" but as Variant or Object.

Is null is a Variant or an Object then why doesn't it allow you to change the value of the variable?  Godot just ignores assignments to the variable.


RichTextLabel: Ensure the select_all function selects all items

Fixes #79670
Two problems found in the select_all function:

select_all uses char_count in the cache without ensuring the cache is valid.
to_item is not set when the first item is found. This will be a problem when there is only one item to select.

Would you mind rebasing your PR against the current master?

Thanks!


Why I'm getting this error?

Hi there guys,
I'm getting the following and I don't get why. Anyone knows could it be?
[Vue warn]: existing instance property "errors" will be overwritten by a computed property with the same name.
(found in component )
[Vue warn]: Error when rendering component :
Uncaught TypeError: this.errors.filter is not a function
Best,
Juan Manuel.

Are you using Vee-Validate ?

yes

This error appears due to the fact that Vee-Validate injects by default an error property everywhere basically (in each component) and globally. Internally vue-form-generator has some computed property named errors which is overwritten by Vee-Validate and blows up everything.
In order to get rid of this issue totally you have to rename the default errors from vee-validate
http://vee-validate.logaretm.com/index.html#configuration
const config = {
  errorBagName: 'validationErrors', // change if property conflicts.
}

Vue.use(VeeValidate, config);

Also make sure to RENAME errors everywhere you try to access them. (e.g validationErrors.has, validationErrors.first etc)

Thank you so much @cristijora !!


[Feature] Dev Toolbar

Describe the solution you'd like
A Dev Toolbar App that allows the user to interact with their Cloudinary images.
Maybe updating the blur? Or the opacity?

love the idea of a dev toolbar
a few ideas ive had in my wish list for dev-only debugging/warnings:

Warning about LCP images once the page loads similar to the Next.js Image component (Related: https://github.com/cloudinary-community/astro-cloudinary/issues/9, https://github.com/vercel/next.js/blob/7418b26d8a27feb6925e488ac4e0c30ad15a3346/packages/next/src/shared/lib/get-img-props.ts#L570-L605)
Log the value of the x-cld-error header when an image has an error (related: https://github.com/cloudinary-community/next-cloudinary/issues/512)
There's a Cloudinary Chrome Extension that could be used for inspiration: https://chromewebstore.google.com/detail/cloudinary-media-inspecto/ehnkhkglbafecknplfmjklnnjimokpkg
Show the file size, format, and rendered dimensions

the editing capabilities seem interesting, but im thinking about what that woudl look like from a workflow perspective. if i wanted to make a change to an image, i would want to be able to save those changes, so would i copy a code snippet? what if i already have a value for that transformation? would i have some kind of field editor? just something to think about. could get complicated, but an interesting thread to pull
are there any existing toolbars that you've seen that i could check out as examples of what this sort of thing looks like?
I would imagine it would be handy to be able to enable/disable debug features, could store those in localstorage for in-UI toggling for people or even have flags in the configuration itself (or both)
can't help but wonder if there is any potential to develop any of the toolbar in a framework agnostic way so that we ecould take advantage of it in other frameworks, but that might be out of scope for getting a v1 😁

Another interesting thing i thought of, i was trying to create a visual editor in my Next.js documentation, wonder if thats a thread ot pull on

looks like we could likely add a button to the existing astro bar: https://x.com/astrodotbuild/status/1843632271708000723?s=46


Fixed issues

Work transmited on LiveCoding.tv: https://www.livecoding.tv/video/personal-jekyll-theme-9/
:stuck_out_tongue_winking_eye:

Apart from the image regression, I the lists in the post don't render correctly.
Actually that was a bug from the Timeline repo that I initially forked and it was tracked by issue #14 :yum:
Here is the screenshot from my blog when running locally with the new changes

I understand. He had seen that definition.
The correct is to to use <img class="img-responsive" ...> in the images. But we must maintain backward compatibility.
Do you think putting an extra class to the container of the post and assign the style to their internal images?
.container-post img {
  display: block;
  max-width: 100%;
  height: auto;
}

Added commit in the Pull Request. And deleted unecesary duplication ID in post.html and lastest-post.html.


DataGridPaginator - translator change

Move $this->template->setTranslator($this->translator); from render() method to createTemplate method. (quicker solution, not the best one, keep reading..)
This would allow setting translator of the paginator component later than during the instance creation.
The issue is that when I assign a new translator using the decorator extension to my grid instance, this new translator is not set to the paginator component as I would expected. I tried to do a workaround, calling $this['paginator']->getTemplate()->setTranslator($translator) when decorator is fired, but it has no effect as the translator of the paginator component is set in the constructor and then assigned to the template in render method of the paginator component. The best case scenario would be to adjust setTranslator of the grid object to call setTranslator on paginator component (the latter method would have to be created).

I don't see, why is that necessary.
How it works now:
1, You create a datagrid object
2, You set all columns, filters, translator
3, When template is rendered, paginator component factory is called
4, If you set previously some translator to datagrid, it is passed also to paginator in __constructor
Your example should work. Can you please show me the config (the decorator setting)? I don't see any reason why that should not work

Problem solved. I was accessing $this['paginator']->getTemplate() sooner than I should (in method 'attached' of the grid instance) because of other settings. This caused the paginator template to be created before my translator was set to the grid instance. I moved this settings to onRender event of the datagrid and now it works just fine. Thank you for clearing things up. It just seemed to me that the decorator is invoked too late.


Feature/15 golang vscode syntax support

Adding syntax support for golang  #15

Fixed https://github.com/dinbtechit/vscode-theme/issues/15


Use of parse_latex?

I am not familiar with it, but it looks like it will be more general than the current tex2py function.
See this for some examples: https://docs.sympy.org/latest/modules/parsing.html#experimental-mathrm-latex-parsing

Good remark, I had never heard of it before. So far I have only touched IO, not the core routines.
I'll have a look.


Unexpected error creating device. DB system error due to db system

After Login, always this error: Unexpected error creating device.
Have deleted from HA and try to reinstall got this error now.
Previous HA versions it works.
Unexpected error creating device
Traceback (most recent call last):
  File "/config/custom_components/panasonic_cc/config_flow.py", line 60, in _create_device
    devices = await self.hass.async_add_executor_job(api.get_devices)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 207, in get_devices
    self.login()
  File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 106, in login
    self._create_token()
  File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 164, in _create_token
    raise ResponseError(response.status_code, response.text)
custom_components.panasonic_cc.pcomfortcloud.session.ResponseError: Invalid response, status code: 500 - Data: {"code":5001,"message":"DB system error due to db system"}

Similar issue:
https://github.com/sockless-coding/panasonic_cc/issues/147

Home Assistant:
Core 2023.12.1
Supervisor 2023.11.6
Operating System 11.2
Interfície d'usuari 20231208.2

the same

same for me. I don't think it is a regional issue. I am in France.
My account was banned yesterday, now only the mobile app is ok

same for me.

Same error for me (The Netherlands).
I can still control them using the OEM android app
Logger: homeassistant.config_entries
Source: config_entries.py:402
First occurred: 19:01:07 (5 occurrences)
Last logged: 22:26:54
Error setting up entry for panasonic_cc
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 402, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/panasonic_cc/init.py", line 79, in async_setup_entry
devices = await hass.async_add_executor_job(api.get_devices)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 207, in get_devices
self.login()
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 106, in login
self._create_token()
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 164, in _create_token
raise ResponseError(response.status_code, response.text)
custom_components.panasonic_cc.pcomfortcloud.session.ResponseError: Invalid response, status code: 500 - Data: {"code":5001,"message":"DB system error due to db system"}

Same issue, I did find after updating HA to 2023.12.1 it broke after this.

I have the same problem with latest version of ha

Now I cannoy even add the integration back. Eariel it asked me for my credentials and failed after that. Now it does not even ask for credentials. It simply throws me back to the integration repository.

I have the same problem. is after the HA update to 2023.12.1

I have the same problem. fresh installation of HA 2023.12.1.

same here :
2023-12-13 00:50:47.585 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry  for panasonic_cc Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/config_entries.py", line 402, in async_setup     result = await component.async_setup_entry(hass, self)              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/config/custom_components/panasonic_cc/__init__.py", line 79, in async_setup_entry     devices = await hass.async_add_executor_job(api.get_devices)               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run     result = self.fn(*self.args, **self.kwargs)              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 207, in get_devices     self.login()   File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 106, in login     self._create_token()   File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 164, in _create_token     raise ResponseError(response.status_code, response.text) custom_components.panasonic_cc.pcomfortcloud.session.ResponseError: Invalid response, status code: 500 - Data: {"code":5001,"message":"DB system error due to db system"}

Same issue for me.

Same issue with 2023.12.2

same issue for me.
This error originated from a custom integration.
Logger: custom_components.panasonic_cc.config_flow
Source: custom_components/panasonic_cc/config_flow.py:60
Integration: Panasonic Comfort Cloud (documentation, issues)
First occurred: 1:18:27 PM (1 occurrences)
Last logged: 1:18:27 PM
Unexpected error creating device
Traceback (most recent call last):
File "/config/custom_components/panasonic_cc/config_flow.py", line 60, in _create_device
devices = await self.hass.async_add_executor_job(api.get_devices)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 207, in get_devices
self.login()
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 106, in login
self._create_token()
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 164, in _create_token
raise ResponseError(response.status_code, response.text)
custom_components.panasonic_cc.pcomfortcloud.session.ResponseError: Invalid response, status code: 500 - Data: {"code":5001,"message":"DB system error due to db system"}

Is downgrading some HA components a workaround for this?

Is downgrading some HA components a workaround for this?

Tried this already. No change, same error.

The update fixed the issue here as well :)

What was the fix for this in the end?

For people on Home Assistant where this update hasn't yet come through on HACS:
Find session.py by:
pip show pcomfortcloud
will get something like: /usr/local/lib/python3.11/site-packages/
nano /usr/local/lib/python3.11/site-packages/pcomfortcloud/session.py
find "language": "0" on line 125.
Replace with "language": 0
save, reboot, you should be back online.

Yes @MetalOctopus it's works thank you

With a new version (from HACS) and a reboot. My issues are solved again.

Please close the issue.

Hi all, i get this now, what should i do ?

Updated HA this morning and now get the "Unexpected error creating device." error... anyone else?

Same

Work in progress on pcomfort library,see here
https://github.com/sockless-coding/panasonic_cc/issues/191#issuecomment-2179220649


Two Custom KFP component links 404

On https://www.kubeflow.org/docs/pipelines/sdk/output-viewer/
The link to the TFMA component 404s
The link to the dataflow predict component also 404s
Note both are in .../components/dataflow/...

It seems the files are deleted in issue #2203 / PR #2161
/cc @gaoning777

Hi @gaoning777 , @sarahmaddox ,
Should we restore these 2 files? If not, maybe,  delete these 2 links in the website?

Hi @gaoning777 , @sarahmaddox
Any update on this? I can restore these 2 files or just delete these 2 links in the website.  Please let me know which way is better.

/assign @joeliedtke
@joeliedtke Would you be able to answer @janeman98's question?

These two components are deprecated. I'll dig into this to see if the pipeline was revised using different components, or if the example needs to be revised.
TFMA - https://github.com/kubeflow/pipelines/tree/dc5aab6687c7dee37834b3f4be1ca6851a59337a/components/deprecated/dataflow/tfma/src
Dataflow predict -
https://github.com/kubeflow/pipelines/tree/dc5aab6687c7dee37834b3f4be1ca6851a59337a/components/deprecated/dataflow/predict/src

/priority p2


Update the README to avoid runtime panic

This is a small fix in the README to update the instruction to run this CGI locally,
If it is executed by wasmer run-unstable ., It crashes when it receives a request.
thread 'main' panicked at 'no entry found for key', /home/syuparn/.cargo/registry/src/github.com-1ecc6299db9ec823/cgi-0.6.0/src/lib.rs:263:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-05-03T08:50:47.042755Z ERROR ThreadId(05) wasmer_wasix::runners::wcgi::handler: Unable to drive the request to completion error=Runtime error error.sources=[RuntimeError: unreachable
...

This is due to cgi crate and we should specify required environment variables explicitly.
wasmer run-unstable --env SCRIPT_NAME=hello .

Closed by #2


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: clarreasilva sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Oops


cli add member by phone

will this run resolver and add crypto member when phone is already verified?

@zapu I thought that's what happened for email in this path

i feel like it might not work, it's easiest to try it


Set "published": true (or remove "published" variable)

Set "published": true (or remove "published" variable)
If the post has been unpublished (published: false) in frontmatter and we want to publish it, then we need to set "published": true (or remove "published" variable)

Are asking to be able to publish a post in the _posts folder by changing the yaml front-matter? The current publish system is designed for use of the new _drafts/ directory feature.
If I'm right, (hey @parkr?) I think published: false is the legacy way of doing drafts. Perhaps I can create a command to convert a post in _posts/ to a draft in _drafts/ because converting a post to a draft is a pain, compared to adding published: false, but using drafts is a better workflow otherwise.
What do you think?

I have pull request #75 ready for review. This will allow you to type something like: `octopress unpublish 'some post' and it will move it into the drafts folder for you. You can read more about how this works in the PR. But I think it's preferable to setting messing with the published var.

It is the old way. There's an unpublished key you can use to show them. But it's deprecated.
https://github.com/jekyll/jekyll/blob/master/lib/jekyll/publisher.rb#L14


Automatic Model Training Colab notebook missing resources

During execution of the automatic_model_training_simple.ipynb notebook, I found that I was unable to train a full model.  After a bit of digging, I found that the notebook was not correctly importing the "embedding_model.onnx" and "melspectrogram.onnx" files into the ".../openwakeword/openwakeword/resources/models/" directory.  After manually adding those two .onnx files, I was successfully able to generate my own custom model.
I believe this is an issue with the notebook which simply needs to call the download_models function within "utils.py".  With a cursory glance, I do not see any call to this function within the notebook

Thank you for raising this @Thyself17, that is quite a serious issue!
I have updated both Colab notebooks to download the required model files, it should be working correctly now.