Installation broken - pyabcranger issue

Hi,
I seem to have an issue on a MacOS 14.1 with Apple M3 Max.
If I run the installation of this package:
python -m pip install sbibm

This error originates from a subprocess and is similar to this issue: https://github.com/diyabc/abcranger/issues/96, opened last week.
My current Python version is 3.11.5.
However, downgrading to Python 3.9.18 and 3.10.13 does not resolve the issue.
Collecting pyabcranger>=0.0.48 (from sbibm)
  Using cached pyabcranger-0.0.70.tar.gz (58 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [106 lines of output]
      PYTHON VERSION : 3.11
      running egg_info
      egg_info (cmake)
      writing dist/pyabcranger.egg-info/PKG-INFO
      writing dependency_links to dist/pyabcranger.egg-info/dependency_links.txt
      writing top-level names to dist/pyabcranger.egg-info/top_level.txt
      Cloning into 'ranger'...
      Cloning into 'wingetopt'...
      -- The CXX compiler identification is AppleClang <IP_ADDRESS>00100
      -- Detecting CXX compiler ABI info
      -- Detecting CXX compiler ABI info - done
      -- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
      -- Detecting CXX compile features
      -- Detecting CXX compile features - done
      Compiler ID : AppleClang
      -- The C compiler identification is AppleClang <IP_ADDRESS>00100
      -- Detecting C compiler ABI info
      -- Detecting C compiler ABI info - done
      -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
      -- Detecting C compile features
      -- Detecting C compile features - done
      -- Found Python: /Users/nastyakrouglova/anaconda3/bin/python (found version "3.11.5") found components: Interpreter Development.Module
      -- [pmm] Using vcpkg executable: /Users/nastyakrouglova/.local/share/pmm/2.1.0/vcpkg-6f7ffeb18f99796233b958aaaf14ec7bd4fb64b2/vcpkg
      CMake Error at build/_pmm/2.1.0/vcpkg.cmake:168 (message):
        Failed find portfile in
        /private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-install-q7br6124/pyabcranger_63824d441ed449369860b427234ea34f/pybind11-nodep!
      Call Stack (most recent call first):
        build/_pmm/2.1.0/vcpkg.cmake:224 (_pmm_vcpkg_copy_custom_ports)
        build/_pmm/2.1.0/main.cmake:46 (_pmm_vcpkg)
        build/_pmm/2.1.0/main.cmake:66 (_pmm_project_fn)
        CMakeLists.txt:83 (pmm)

      -- Configuring incomplete, errors occurred!
      [git] .gitmodules found. Cloning the submodules if necessary
      [git] cloning https://github.com/fradav/ranger.git to ranger...
      [git] cloning complete.
      [git] cloning https://github.com/alex85k/wingetopt.git to wingetopt...
      [git] cloning complete.

      [cmake] configuring CMake project...

      Traceback (most recent call last):
        File "/Users/nastyakrouglova/anaconda3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/Users/nastyakrouglova/anaconda3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/Users/nastyakrouglova/anaconda3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 480, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 23, in <module>
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/cmaketools/__init__.py", line 98, in setup
          _setup(**setup_args)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/__init__.py", line 103, in setup
          return distutils.core.setup(**attrs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 185, in setup
          return run_commands(dist)
                 ^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
          dist.run_commands()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
          self.run_command(cmd)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/dist.py", line 963, in run_command
          super().run_command(command)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
          cmd_obj.run()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/command/egg_info.py", line 321, in run
          self.find_sources()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/cmaketools/cmakecommands.py", line 72, in find_sources
          mm.run()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/command/egg_info.py", line 551, in run
          self.add_defaults()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/command/egg_info.py", line 589, in add_defaults
          sdist.add_defaults(self)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/command/sdist.py", line 112, in add_defaults
          super().add_defaults()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/command/sdist.py", line 251, in add_defaults
          self._add_defaults_ext()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/command/sdist.py", line 335, in _add_defaults_ext
          build_ext = self.get_finalized_command('build_ext')
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 305, in get_finalized_command
          cmd_obj.ensure_finalized()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 111, in ensure_finalized
          self.finalize_options()
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/cmaketools/cmakecommands.py", line 452, in finalize_options
          self.cmake.configure(self.build_base, **cmake_settings)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/cmaketools/cmakebuilder.py", line 321, in configure
          cmakeutil.configure(".", build_dir, *args, **kwargs)
        File "/private/var/folders/ld/flvgc_x56cqgh3w4r74wm0140000gn/T/pip-build-env-90ml_iw6/overlay/lib/python3.11/site-packages/cmaketools/cmakeutil.py", line 120, in configure
          sp.run(args, env=env, check=True).check_returncode()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/Users/nastyakrouglova/anaconda3/lib/python3.11/subprocess.py", line 571, in run
          raise CalledProcessError(retcode, process.args,
      subprocess.CalledProcessError: Command '['cmake', '.', '-B', 'build', '-DPython_EXECUTABLE=/Users/nastyakrouglova/anaconda3/bin/python', '-DPYABCRANGER=TRUE', '-DUSE_MKL:BOOL=FALSE', '-DCMAKE_BUILD_TYPE:STRING=Release', '-G', 'Ninja', '-DCMAKE_BUILD_TYPE:STRING=Release']' returned non-zero exit status 1.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

I assume that updating pyabcranger inside sbibm to the latest release of 0.0.57  will fix this issue. (see https://github.com/diyabc/abcranger/issues/92)

Unfortunately it didn't resolve the issue. I get the same issue with pyabcranger , which also originates from a subprocess.

I fixed the CI on pyabcranger, this should improve the situation there. Sorry for the delay!

Great, thanks for fixing this. Installing sbibm with python3.11.5 works just fine now!


Update go-zookeeper

Should prevent recurring disconnects: https://github.com/samuel/go-zookeeper/pull/167

🙏
LGTM


mem-ruby: Fix replacement policy in GPU_VIPER

The current GPU_VIPER protocol's TCC cache update the MRU information
twice with calling a_allocateBlock and ut_updateTag which affects the
LIP and RRIP replacement polies. Remove ut_updateTag fixes the LIP and
RRIP replacement polies.
Change-Id: I79ad9392593e00425a7fe8828048465b2c2c2e1f

Thanks again, @yuxiaojia !


Feat(trigger): trigger menu when deleting character that stands right after trigger character in insert mode

Feature Description
Currently, trigger characters don't work if we happen to be at one after removing a character from the right.
Current behavior: x.f| => <BS> => x.| - completion menu not triggered
Desired behavior: x.f| => <BS> => x.| - completion menu triggered

Currently, trigger characters don't work if we happen to be at one after removing a character from the right

I might be wrong in that, but I couldn't configure it the way I've outlined.

Is there a way to trigger completion on  regardless of trigger character?


enum type with numeric keys

Hey!
Enum types require that their keys are strings (https://github.com/gcanti/tcomb/blob/master/index.js#L395)
Enums.is = function (x) {
  return Str.is(x) && map.hasOwnProperty(x);
};

However, even though all js array keys are essentially strings, the constructor automatically converts keys to strings. The same holds for hasOwnProperty(). Thus the following is completely valid js:
var t = { 3: 'a', 3.2: 'b'};
t.hasOwnProperty(3); // true
t.hasOwnProperty(3.2); //true

To reference, the Standard (http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf) (Section 15.4, p. 122) states that any key must be converted to a string:

A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 2^32-1

Now, for floating point numbers, even though the standard requires a ToUint32 conversion, floating numbers work in any browser and node implementation as outlined above. (http://stackoverflow.com/questions/6649283/how-are-floating-point-array-indices-interpreted).
I'm sure one could just as well specify a list of type number to achieve a number-enum type, but i'd say it may be easier this way.
Any thoughts on relaxing the Str.is(x) requirement on enum.is()? :)

Any thoughts on relaxing the Str.is(x) requirement on enum.is()? :)

Hi! Thanks for your super detailed issue.
It's ok for me.

Yeah sure, will do!

published in v2.0.0-beta


Stall when connector hits limit from several connections to same bad hostname

Long story short
When a session's connector has a connection limit, multiple requests for a URL with a bad hostname never complete.
Expected behaviour
Script should run to completion
Actual behaviour
The second connection neither completes nor throws an error, and the script hangs.
Steps to reproduce
import aiohttp
import asyncio
import sys
import traceback

@asyncio.coroutine
def stall(session):
    for c in asyncio.as_completed([session.get('http://badhost.example/') for i in range(2)]):
        print(c)
        try:
            resp = yield from c
        except:
            for line in traceback.format_exception_only(*sys.exc_info()[0:2]):
                print(line, end='', file=sys.stderr)
        else:
            yield from resp.release()

loop = asyncio.get_event_loop()
with aiohttp.ClientSession(connector=aiohttp.TCPConnector(limit=1)) as session:
    loop.run_until_complete(stall(session))
loop.close()

Your environment
python 3.4.2 on Debian jessie
aiohttp 0.21.4

I don't think it is only bad hostname which leads to this situation. With the following code:
import asyncio
import logging
import aiohttp

LOG_FORMAT = ('%(asctime)s %(message)s')
logging.basicConfig(format=LOG_FORMAT)
log = logging.getLogger('root')  # pylint: disable=I0011,C0103
log.setLevel('DEBUG')

async def fetch(session, url):
    "single fetch"
    log.info('trying %s', url)
    try:
        with aiohttp.Timeout(5):
            async with session.get(url, compress=True) as response:
                if response.status == 200:
                    rs =  await response.text()
                    log.info('status 200  %s response size %s', url, len(rs))
                else:
                    log.error('received %s for %s', response.status, url)
    except aiohttp.errors.ClientError as exc:
        log.error(exc)
    except asyncio.TimeoutError as exc:
        log.error('fetching data timeout for %s', url)

async def fetch_all(session, urls, loop):
    """This a delegating routine."""
    futures = [loop.create_task(fetch(session, url)) for url in urls]
    for future in asyncio.as_completed(futures):
        result = await future
        if result is not None:
            pass

def main():
    """main code"""
    ssl_conn = aiohttp.TCPConnector(conn_timeout=2, limit=1, verify_ssl=False)
    sites = ['google.com', 'yahoo.com', 'facebook.com', 'cnn.com']
    urls = ['https://{}:443/'.format(site) for site in sites]

    loop = asyncio.get_event_loop()
    with aiohttp.ClientSession(loop=loop, connector=ssl_conn) as session:
        loop.run_until_complete(fetch_all(session, urls, loop))

# This is the standard boilerplate that calls the main() function.
if __name__ == '__main__':
    main()

I see that request to yahoo receives  timeout exception (catched by  try block) but in the tcpdump trace I see actual response from yahoo (it responses with 301).
2016-03-27 12:08:58,578 trying https://google.com:443/
2016-03-27 12:08:58,582 trying https://yahoo.com:443/
2016-03-27 12:08:58,583 trying https://facebook.com:443/
2016-03-27 12:08:58,584 trying https://cnn.com:443/
2016-03-27 12:08:58,771 received 400 for https://google.com:443/
2016-03-27 12:08:58,859 [Errno None] Cannot connect to host cnn.com:443 ssl:True [Can not connect to cnn.com:443 [None]]
2016-03-27 12:08:59,856 status 200  https://facebook.com:443/ response size 69800
2016-03-27 12:09:03,587 fetching data timeout for https://yahoo.com:443/

When I remove cnn from the url list and remove also 443 then I see:
2016-03-27 12:21:41,845 trying https://google.com/
2016-03-27 12:21:41,853 trying https://yahoo.com/
2016-03-27 12:21:41,856 trying https://facebook.com/
2016-03-27 12:21:42,032 received 400 for https://google.com/
2016-03-27 12:21:43,038 status 200  https://facebook.com/ response size 69651
2016-03-27 12:21:46,857 fetching data timeout for https://yahoo.com/

running curl -vv   https://yahoo.com:443/ or curl -vv   https://yahoo.com returns 301 to www.yahoo.com.

I don't think #861 solved the problem. If I run the code I mentioned above I see the same behavior.
@yrro , can you confirm if #861 fixes your problem ?

@unixsurfer Try removing compress=True from the request since you are not sending a body.

@danielnelson,  compress=False did the trick:
python ./aiosyncissue835.py
2016-05-23 22:08:20,190 trying https://google.com:443/
2016-05-23 22:08:20,193 trying https://yahoo.com:443/
2016-05-23 22:08:20,194 trying https://facebook.com:443/
2016-05-23 22:08:20,194 trying https://cnn.com:443/
2016-05-23 22:08:20,403 status 200  https://google.com:443/ response size 11424
2016-05-23 22:08:20,441 [Errno None] Cannot connect to host cnn.com:443 ssl:True [Can not connect to cnn.com:443 [None]]
2016-05-23 22:08:21,162 status 200  https://facebook.com:443/ response size 57148
2016-05-23 22:08:21,466 status 200  https://yahoo.com:443/ response size 434217
setting compress=True
python ./aiosyncissue835.py
2016-05-23 22:08:57,912 trying https://google.com:443/
2016-05-23 22:08:57,916 trying https://yahoo.com:443/
2016-05-23 22:08:57,917 trying https://facebook.com:443/
2016-05-23 22:08:57,917 trying https://cnn.com:443/
2016-05-23 22:08:58,062 received 400 for https://google.com:443/
2016-05-23 22:08:58,145 [Errno None] Cannot connect to host cnn.com:443 ssl:True [Can not connect to cnn.com:443 [None]]
2016-05-23 22:08:59,081 status 200  https://facebook.com:443/ response size 57182
2016-05-23 22:09:02,920 fetching data timeout for https://yahoo.com:443/
Do you have any explanation about this behavior ?

Setting compress=True adds the Content-Encoding and Transfer-Encoding headers, and yahoo is taking a long time to respond when these are set, when it does respond it seems to close the connection.  The equivalent curl command would be curl -vv -L -H Content-Encoding:deflate -H Transfer-Encoding:chunked https://yahoo.com:443/.

Without -H Transfer-Encoding:chunked  curl returns instantly

yahoo doesn't like chunked Transfer-Encoding
curl -vv -L  -H Transfer-Encoding:chunked https://yahoo.com:443/ 2>&1|grep 'HTTP/1.1'

GET / HTTP/1.1
< HTTP/1.1 301 Redirect
GET / HTTP/1.1
< HTTP/1.1 502 Server Hangup

Do we know why aiohttp uses chunked Transfer-Encoding when compression is enabled? A far as I know when both these headers are set then web server has to compress all payload before it sends out the compressed response in chunks.

reason for chunking exactly this, we can start compressing and send compressed chunks immediately, we do not need to compress whole blob.

I think this issue should be closed since the original report is addressed.  If we want to turn off chunked transfer with compression that should be a separate issue.

Confirming that my test case works with the current release (1.1.5).


highlight the nav item when on the page

Now the blog nav item is active whenever we are in blog page and similarly is the team.
Hope this was the issue u tried to communicate, and it is now solved :smiley:

Yes, this solves #48 now. Thank you @VipinVIP :-)


Redesign Footer

Pending Header styling

@RebWu Gucci?

Footer styling broken after Sass implementation.

Is this in PR #70 @jwu910 ?

Fixed


More pruning improvements

Ready for review. This should make it easier for people to run a pruned node. If someone starts with -prune core will automatically try to set txindex and disablegovernance to the proper values, and will abort if not possible. It still shows the "governance validation is disabled" message but I made it a bit less scary. In the future I plan on changing it so that that warning will only pop up if it's a users first time in pruned mode, or if they aren't in pruned mode but have governance validation disabled.

Pls see https://github.com/UdjinM6/dash/commits/pr3579:

34f5c1508ce17e9c946972165800ccb7a039cb11 is needed to ensure consistency of newly added checks/assignment of -disablegovernance
1d0d61df8a4eb87ec498fc636bf95f0f2e755859 is a cleanup, this logic really belongs to AppInitParameterInteraction
b2bb2649ee2e557adada59b975d620fcfef535bf is needed to fix blockchain.py and it's actually ok to skip this warning on pruned nodes completely, see inline comments
57dbd7748670cb0626aaa15f6d07b07cfb806e53 trivial text tweaks

I generally disagree with b2bb2649ee2e557adada59b975d620fcfef535bf because it is still important for pruned node operators to realize that they aren't doing FULL validation, only mostly full validation. I want in the future that warning to only pop up in case of first launch prune or launching w/o prune

Well, then you need smth like 97e0fafcaa for example cause blockchain.py fails because of this warning atm.

done

Hmm... looks like more changes to tests are needed, pls see 4e9dfe90bb

commited suggestion

cherry-picked

backported in https://github.com/dashpay/dash/pull/3670


Pod spec lint and pod repo push Error on Xcode 10, Swift 4.2

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[✓] I have read the wiki page and cheat sheet, but there is no information I need.
[✓] I have searched in existing issues, but did not find a same one.
[✓] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
Migrating to Swift 4.2 and Xcode 10 cannot pod repo push or passed validation with pod spec lint.
What
As I am migrating to Swift 4.2 and Xcode 10, I need to renew my other libraries as well as Kingfisher to 4.10 (from 4.9). But migrating to 4.10 has made the pod repo push and pod spec lint error. I tried to use CocoaPods 1.6.0.beta.1 and 1.5.3 and it's still not working
Reproduce

Change project build phase swift version to 4.2
Pod install Kingfisher, '4.10.0' with config.build_settings['SWIFT_VERSION'] = '4.2'
Put dependency on pod spec the same version as the one I installed s.dependency 'Kingfisher', '4.10.0'
Pod spec lint --verbose

Result is below :

ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code.

ERROR | [iOS] xcodebuild:  Kingfisher/Sources/AnimatedImageView.swift:111:30: error: type 'RunLoop' has no member 'Mode'
NOTE  | [iOS] xcodebuild:  ObjectiveC.NSObject:160:15: note: did you mean 'zone'?
NOTE  | [iOS] xcodebuild:  ObjectiveC.NSObject:162:21: note: did you mean 'zone'?
NOTE  | [iOS] xcodebuild:  Foundation.RunLoop:8:15: note: did you mean 'runMode'?
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/AnimatedImageView.swift:336:23: error: type 'UIView' has no member 'ContentMode'
NOTE  | [iOS] xcodebuild:  UIKit.UIView:19:14: note: did you mean 'contentMode'?
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/AnimatedImageView.swift:353:35: error: 'ContentMode' is not a member type of 'UIView'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/AnimatedImageView.swift:228:24: error: cannot invoke initializer for type 'Animator' with an argument list of type '(imageSource: CGImageSource, contentMode: UIViewContentMode, size: CGSize, framePreloadCount: Int, repeatCount: AnimatedImageView.RepeatCount)'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/Image.swift:460:58: error: 'ContentMode' is not a member type of 'UIView'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/Image.swift:184:20: error: value of type 'Base' has no member 'pngData'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/Image.swift:197:20: error: value of type 'Base' has no member 'jpegData'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageCache.swift:159:64: error: type 'UIApplication' has no member 'didReceiveMemoryWarningNotification'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageCache.swift:161:69: error: type 'UIApplication' has no member 'willTerminateNotification'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageCache.swift:163:79: error: type 'UIApplication' has no member 'didEnterBackgroundNotification'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageCache.swift:543:20: error: type 'UIBackgroundTaskIdentifier' (aka 'Int') has no member 'invalid'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageModifier.swift:119:39: error: 'RenderingMode' is not a member type of 'UIImage'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageModifier.swift:125:40: error: 'RenderingMode' is not a member type of 'UIImage'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageTransition.swift:82:34: error: 'AnimationOptions' is not a member type of 'UIView'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageTransition.swift:100:34: error: 'AnimationOptions' is not a member type of 'UIView'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageTransition.swift:96:15: error: pattern cannot match values of type 'ImageTransition'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageTransition.swift:110:15: error: pattern cannot match values of type 'ImageTransition'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageTransition.swift:116:15: error: pattern cannot match values of type 'ImageTransition'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/ImageTransition.swift:123:15: error: pattern cannot match values of type 'ImageTransition'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/UIButton+Kingfisher.swift:207:66: error: 'State' is not a member type of 'UIControl'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/UIButton+Kingfisher.swift:203:45: error: 'State' is not a member type of 'UIControl'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/Indicator.swift:136:38: error: type 'UIActivityIndicatorView' has no member 'Style'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/UIButton+Kingfisher.swift:55:47: error: 'State' is not a member type of 'UIControl'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/UIButton+Kingfisher.swift:133:57: error: 'State' is not a member type of 'UIControl'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/UIButton+Kingfisher.swift:246:55: error: 'State' is not a member type of 'UIControl'
ERROR | [iOS] xcodebuild:  Kingfisher/Sources/UIButton+Kingfisher.swift:250:76: error: 'State' is not a member type of 'UIControl'

I think it's either the CocoaPods problem or if someone know how to fix it please help me. Thanks

What's your CocoaPods version? Maybe it worths to try 1.6.0.beta.1.

What's your CocoaPods version? Maybe it worths to try 1.6.0.beta.1.

I already tried both 1.5.3 and 1.6.0.beta.1 still not working.

me did it too ,it didn't work, help!

The error log indicates that you are still trying to build it with Swift 4.0/4.1.
How did you set your own podspec Swift version? I guess you may need something like s.swift_version = "4.2" in your podspec too.

The error log indicates that you are still trying to build it with Swift 4.0/4.1.
How did you set your own podspec Swift version? I guess you may need something like s.swift_version = "4.2" in your podspec too.

Tried s.swift_version = 4.2 and pod spec lint --swift-version=4.2
Problem still persist.

i use cocoapods 1.5.3 and set s.swift_version = "4.2" , occurs this error too

Do you guys still have a .swift-version under your repos? It is deprecated and maybe you need to remove it before you do a lint.
@LemonadeEX @yishuiliunian May I know your repo/branch so I could check what happened.

The same error with Xcode 9.4.1, Swift 4.1, Cocoapods 1.5.3.

@ARGAMX Kingfisher 4.10 supports from Xcode 10 and Swift 4.2. To use in Xcode 9, please try Kingfisher 4.9.

Problem still persist even with Xcode 10.1 update.

OK. I will add Swift 4.0 support back.

Right now I have Xcode 10.1 and after installing Knigfisher in a new project I'm facing Swift 4.2 syntax issues. @onevcat Kingfisher (3.2.4) installed and Cocoapod version is 1.5.3.  Need help thanks from now.

Right now I have Xcode 10.1 and after I installed Kingfisher in a new project I'm facing some issues
like:
Placeholder
ImageModifier
@onevcat  Kingfisher (4.10.1) installed and Cocoapod version is 1.5.3. Need your help thanks from now.

4.10.1 was released with Swift 4.0 compatibility. Now you should be able to build it with Swift 4.0 or 4.1.
I am closing this.


Add ‘Not completed’ tags to the task list

We want to see if this makes it clearer to people what they need to do next when they land on the page.
Uses the tag component that’s recently been added to the Design System. I chose the grey one because it’s the default example given1, and it doesn’t have the same semantic associations as red, green or yellow.

Looks cooool 👍


Changed volume and brightness slider's style

I made them following the style of A12/13's system volume bar, now they both look good in white/dark mode.

Will check them and let you know if everything is good
Thank you for your contribution ❤

I am sorry i dont want to be picky, the idea of a moving icon is new
but but it feels weird , like none of the native players, does it , they all include a bar that fills, so this idea is a bit creative, for me i would rather stick with a filling bar , (of course theme related that is a nice addition )


🐛[BUG]: Corrdiff incompatible withSongUNetPosEmbd - constructor missing checkpoint_level argument

Version
0.7.0a
On which installation method(s) does this occur?
Docker, Source
Describe the issue
Analysis: The error comes from modulus.models.diffusion.song_unet.SongUNetPosEmbd not accepting the keyword_argument checkpoint_level.
Proposed fix: Add checkpoint_level to the constructor of SongUNetPosEmbd and pass it to its parent SongUNet.
Minimum reproducible example
python3 train.py --config-name=config_train_diffusion.yaml
config:
     arch: ddpmpp-cwb
     precond: edmv1
     task: diffusion

Relevant log output
Traceback (most recent call last):
  File "/code/modulus/examples/generative/corrdiff/train.py", line 344, in main
    training_loop.training_loop(
  File "/code/modulus/examples/generative/corrdiff/training/training_loop.py", line 166, in training_loop   <--------------
    net = construct_class_by_name(**merged_args)  # subclass of torch.nn.Module
  File "/code/modulus/modulus/utils/generative/utils.py", line 306, in construct_class_by_name
    return call_func_by_name(*args, func_name=class_name, **kwargs)
  File "/code/modulus/modulus/utils/generative/utils.py", line 296, in call_func_by_name
    return func_obj(*args, **kwargs)
  File "/code/modulus/modulus/models/diffusion/preconditioning.py", line 969, in __init__ <--------------
    model = model_class(
  File "/code/modulus/modulus/models/module.py", line 65, in __new__
    bound_args = sig.bind_partial(
  File "/usr/lib/python3.10/inspect.py", line 3193, in bind_partial
    return self._bind(args, kwargs, partial=True)
  File "/usr/lib/python3.10/inspect.py", line 3175, in _bind
    raise TypeError(
TypeError: got an unexpected keyword argument 'checkpoint_level'

Environment details
python version: 3.10
modulus commit: `c07fa25321c48a1d71efca12b67d056adbca8bd4`

hi @stathius could you comment what checkpoint you used here?

hi @stathius could you comment what checkpoint you used here?

Hi @yairchn you mean for the regression U-Net? It was 053327 but I am not sure it matters in this case.

This is fixed with https://github.com/NVIDIA/modulus/pull/550, closing the issue.

#550 was not merged.
Best,
Stathi
On Thu, 27 Jun 2024 at 15:08, David Pruitt @.***> wrote:

This is fixed with #550 https://github.com/NVIDIA/modulus/pull/550,
closing the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/modulus/issues/534#issuecomment-2195747918,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPQ4BMCFLCJQCPW46TVGFDZJSEOBAVCNFSM6AAAAABIR2A43CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVG42DOOJRHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Added logic to emit individual test case results - fail and error - i…

…n aftereach

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.cahrens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

great - question - are the test case 'names' the key property in the nightwatch test files? i mean the string that accompanies the test function?

yes


NetworkReachabilityManager: Add support for host names or ip addresses with ports

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

Problem
I am running multiple local web servers with different ports for testing and debugging purpose and Alamofire don´t have support for ports, see #3520
Feature Request
Add a new overload or similar for NetworkReachabilityManager with a parameter for a port. The underlying SCNetworkReachability has the ability to use ports.
Value to Alamofire
I think for testing and debugging purpose this function would be very useful.

SCNetworkReachability does not support port numbers, only general connectivity to a particular address.


Card count on collapsed list not visible while zoomed

Starting from 150% zoom, the collapsed list do not show amount of cards, the number go to another line.

Fixed 87db590 - Verify


root.crt change root-crt

Error: failed to start container "notary-server": Error response from daemon: oci runtime error: container_linux.go:247: starting container process caused "process_linux.go:364: container init caused "rootfs_linux.go:54: mounting \"/var/lib/kubelet/pods/7981c0e7-5351-11e8-8197-00505688f21e/volume-subpaths/root-certificate/notary-server/1\" to rootfs \"/var/lib/docker/overlay2/7f7af74be5dbd6e31fd3561da7ea3e9e7609426b0b412580a9a3dd7d5ccaf1c1/merged\" at \"/var/lib/docker/overlay2/7f7af74be5dbd6e31fd3561da7ea3e9e7609426b0b412580a9a3dd7d5ccaf1c1/merged/config/root.crt\" caused \"not a directory\""" : Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type
Back-off restarting failed container

@shayulei what's your kubernetes server version ? e.g. the output of kubectl version

Fixed in master branch


Remove mod operands.

(Stacked on top of #108; only the second commit is the real change here.)
This PR removes "mod" or "modify" operands. regalloc2 currently supports non-SSA input -- that is, code with multiple defs for the same register -- and as part of this support, a kind of operand that both uses the old value of a vreg and redefines it with a new value.
This operand kind was included for compatibility with regalloc.rs, because quite a few instructions in Cranelift used it to naturally describe the machine-level semantics. (For example, on x86, most ALU instructions modify one operand to replace it with the result.)
However, we've been pushing to refactor toward pure-SSA input, and thanks to @elliottt's work in Cranelift, non-SSA support is no longer needed in regalloc2. Instead, instructions now use "reused-input" operand constraints: a new vreg is defined with the result, and constrained to be in the same allocation as the input vreg. The "mod operand" thus was split into two halves.
Since we now want to make use of the pure-SSA properties for other work (e.g., better splitting and simpler liverange-construction frontend by allowing overlapping LRs for one vreg), we should remove features that imply non-SSA input, including "mod" operands.
The main part of this PR should be a fairly straightforward mechanical change: it removes the OperandKind then deletes the cases that handle it.
In addition, since the OperandKind now needs only 1 bit instead of 2 in the 32-bit bitpacked Operand encoding, there was an opportunity to allocate this bit to some other purpose. I've opted to put it in the RegClass field, because there has been a latent need to define more than two register classes for some architectures.

I presume there is also another follow up PR to remove program moves, which are no longer needed with SSA?

I presume there is also another follow up PR to remove program moves, which are no longer needed with SSA?

I actually hadn't gotten that far yet, and wanted to verify that they weren't used anywhere performance-critical first. In principle a program move could still be used in SSA-pure code (a trivial unary op that defs a new vreg), but indeed many of the major reasons to use them (x86 mod operands etc) have gone away.


Update create-an-aspnet-mvc-5-web-app-with-email-confirmation-and-pas…

…sword-reset.md
Added the location for the send grid configuration
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

@JSweetland95 We appreciate you taking time to address this. Congrats on your 1st contribution to this repo!


Update doesn't seem to work, at least with plain javascript (not typescript)

I'm using the example from the samples/simple, just with javascript instead of typescript. The docker image I'm using is postgres:15.3
When I run the application the 3 users do get inserted and the Cruella user gets deleted. The Anita user's age doesn't get updated though. I query the database and the age is still 25.
Here's my code:
import { endAllPools, pongoClient } from "@event-driven-io/pongo";
import { v4 as uuid } from "uuid";

const connectionString =<EMAIL_ADDRESS>const pongo = pongoClient(connectionString);
const pongoDb = pongo.db();

const users = pongoDb.collection("users");

const roger = { name: "Roger", age: 30 };
const anita = { name: "Anita", age: 25 };
const cruella = { _id: uuid(), name: "Cruella", age: 40 };

await users.insertOne(roger);
await users.insertOne(cruella);

const { insertedId } = await users.insertOne(anita);
const anitaId = insertedId;

await users.updateOne({ _id: anitaId }, { $set: { age: 31 } });

await users.deleteOne({ _id: cruella._id });

const anitaFromDb = await users.findOne({ _id: anitaId });

console.log(anitaFromDb);

const usersUnder40 = await users.find({ age: { $lt: 40 } });

console.log(usersUnder40);

await endAllPools();

Thank you for giving the heads up. Which Pongo version are you using?

I'm using version 0.2.3
Here's my package.json.
{
  "name": "pongo-test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@event-driven-io/pongo": "^0.2.3"
  }
}

It's very likely that I'm not doing something correctly.
Great project by the way. I'm excited to be able to use this.

Okay, thank you. I was able to reproduce it. Also, in typescript, it sounds like my bad. :| I'll look into that.
Thank you for the kind words and the reproduce steps 👍

@vanillaike it appeared that it was my dumb mistake. See details in #23. I provided the fix and released 0.2.4 samples are also updated.
Again, thank you for understanding and sending information with reproduce steps 👍

@oskardudycz Thanks! I'll check it out.

@vanillaike, did it work? 😀

@oskardudycz Yes it did work! Thanks again.


How to display video frames with deck.gl ?

I'm new to deck.gl and wondering how to display video frames with it.
I would like to build an app like the ascii demo but instead draw the actual frames.
Is the BitmapLayer suitable for this task or do I need to write a custom layers ?
Any hints will be helpful.
Regards

The BitmapLayer does not support video right now. I think this is a reasonable use case and we should consider supporting it. @xintongxia
I put together an example here: https://codepen.io/Pessimistress/pen/pmmbRj

@Pessimistress Thanks for the example. Is there something missing it the code ? The image in the canvas is not updated when the video is playing.

Are you using Safari? WebGL1 does not have good support for non-power-of-two texture sizes (and the demo video demensions are not power of two). You will need to resize your source video.

To get an non-power-of-two texture to work in WebGL 1, just change the wrap mode to CLAMP_TO_EDGE (and turn off mipmaps, which was already done here), i.e. in the codepen example, change the texture construction to:
this.setState({
  bitmapTexture: new luma.Texture2D(gl, {
    width: 1,
    height: 1,
    parameters: {
      [gl.TEXTURE_MIN_FILTER]: gl.NEAREST,
      [gl.TEXTURE_MAG_FILTER]: gl.NEAREST,

      // THIS IS THE NEW PART
      [gl.TEXTURE_WRAP_S]: gl.CLAMP_TO_EDGE,
      [gl.TEXTURE_WRAP_T]: gl.CLAMP_TO_EDGE
    },
    mipmaps: false
  })
});

Thanks @tsherif ! Codepen is updated.

Thank you. It's working great!

@Pessimistress Just to understand what's going on.  Does the fact the we set _animate = true forces deckGL to call layer.draw every timestep ?

That is correct. If you want more control over this, you can manually trigger redraw:
let animation = null;

const bitmaplayer

function animate() {
  videoBitmapLayer.setNeedsRedraw(true);
  animation = requestAnimationFrame(animate);
};

video.onplay = () => animate();
video.onpause = () => cancelAnimationFrame(animation);


Unity 2018.1.5f1 compile errors, dotnet 4.7,

After copying the GLTFSerialization directory to my project, Unity logs several error messages to its console such as the following

Assets/GLTFSerialization/GLTFSerialization/GLTFHelpers.cs(38,61): error CS1644: Feature `out variable declaration' cannot be used because it is not part of the C# 6.0 language specification

I have similar problem Assets/UnityGLTF/GLTFSerialization/GLTFSerialization/GLTFHelpers.cs(38,61): error CS1644: Feature declaration expression' cannot be used because it is not part of the C# 6.0 language specification
`

I've finally figured out we should add "com.unity.incrementalcompiler": "0.0.42-preview.1" into manifest.json then you need reimport all. I hope this information could be helpful for you.

@kyasbal-1994 thanks for the advice. What I did, as an alternative to copying the GLTFSerialization directory... I opened UnityGLTF inside Visual Studio and rebuilt it and I ran the build script included with UnityGLTF to generate the .unity file, which I'm able to add to my existing projects.

I've finally figured out we should add "com.unity.incrementalcompiler": "0.0.42-preview.1" into manifest.json then you need reimport all. I hope this information could be helpful for you.

Where i can find this manifest.json? :octocat:


Voyager Tables already existing

Hey Guys,
I decided to do not use the issue template, cause my question is more general.
I wanted to integrate voyager in an existing project, the problem ist that I already defined a categories-Table as well as a permissions-Table cause I use the spatie/laravel-permission package.
My firs try was to rename the categories table, but I think I could run into trouble, if I also rename the role tables.
So in short: I do not use all of these generated BREADs like Pages, Categories, etc. ... just wanted to start with a blank admin UI.

We're working on moving the pages/posts/categories functionality into a Hook.  You should expect that in v1.1 I think.
As for permissions, those are fairly tightly coupled into Voyager.  Is there a reason you need the spatie package instead of just using Voyager's?

Thanks @fletch3555 ! I'm looking forward to v2!!
Is there anything possible for now? For example just deleting the pages/posts/categories migrations? Especially to avoid the categories conflict? I would think of migrating to the Voyager's role system..

Fixed in https://github.com/the-control-group/voyager/pull/2829


restore unit teesting coverage using jacoco

as CI/CD verifications restored we have to return jacoco unit testing coverage back to the carina static code analysis

fixed: https://ci.zebrunner.com/sonarqube/dashboard?id=com.qaprosoft%3Acarina


Added ECC Nist256 support in crypto HSM layer

Problem
Support for ECC Nist256 in Hardware Secure Module (HSM) crypto layer
Summary of Changes
Added nist256 HSM implementation
Modified crypto test (CHIPCryptoPALTest) to use ecc keys from HSM

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Jagadish-NXP:x: sujaygkulkarni-nxpYou have signed the CLA already but the status is still pending? Let us recheck it.


should cd() and env() be params instead?

We're probably not going to want both forms, because that gets inconsistent and confusing. I worry that something like this is also confusing:
# cd only applies to the left side of the pipe!
cd('foo').then('pwd').pipe('tee', 'bar').run()

As compared to:
# cwd applies to everything
cmd('pwd').pipe('tee', 'bar').run(cwd='foo')

The latter is almost always going to be what the user wants. Likewise, setenv gets verbose if you need to set multiple variables at once, and so we might want a separate syntax that takes a dict.
The advantage of the command-style syntax for both is that it's possible to apply the change to only part of a expression. But:

Who will ever need to do that?
That's pretty easy anyway by letting individual commands take the env and cwd params just like the run() method does. Nice and consistent.

We have the same problem that subprocess does with env, which is that we need to decide whether it's the user's responsibility to copy the entire environment from the caller. It might be worth letting env do a copy by default, and define fullenv or something for when the user wants to own the whole thing.


Spec v0.9.0 updates - eth2 part

What is wrong?
https://github.com/ethereum/eth2.0-specs/releases/tag/v0.9.0

features

alter beacon proposer selection logic (ethereum/eth2.0-specs#1413)
add seed domains (ethereum/eth2.0-specs#1415)
fix delay-based attestation inclusion reward (ethereum/eth2.0-specs#1434)
use eth1_block_hash for initial randao_mix (ethereum/eth2.0-specs#1447)

simplifications

remove active active_index_roots and compact_committees_roots from phase 0 (ethereum/eth2.0-specs#1329)
remove shards/crosslinks from phase 0 (ethereum/eth2.0-specs#1428)
remove transfers from phase 0 (ethereum/eth2.0-specs#1443)

Fork choice

verify state root in fork choice tests and other minor fixes (ethereum/eth2.0-specs#1454)

How can it be fixed
Question: should the v0.9 progress on the new branch, so that interop tests can still work?
@ralexstokes

@hwwhww awesome! sounds like you want to do some further refactoring in #1251 so reviewing this will be top of my list after you get that done :)
in the meantime, i'd suggest we just move ahead w/ merging this to master we can always rewind to a particular point if we need to but i'd rather have an incentive for another team to update so we can do v0.9.0 interop experiments


Fix newline-after-import rule for require

This PR fixes #318.
Actually I’m not convinced that this rule really makes sense for commonjs, there are just too many edge-cases and no way to say which to exclude from this rule, e.g. the following:
require('a');
foo(require('b'), require('c'), require('d'));
var assign = Object.assign || require('object-assign');
const nightwatchConfig = { seleniumPath: require('selenium-standalone').path };

I’ve tried my best to handle those cases.

You should probably update changelog's Fixed section :)

@lo1tuma that's fair.
My default position is generally to support the simplest thing that is useful (like standard assignment and naked function calls), and put the weird stuff in the Don't Use This Rule If section of the docs. Don't have to solve every case. :smile:

I think we should only support requires that are present at the top level.
// Support
require('a');
var b = require('b');

// Do not support
foo(require('b'), require('c'), require('d'));
var assign = Object.assign || require('object-assign');
const nightwatchConfig = { seleniumPath: require('selenium-standalone').path };

I think we should only support requires that are present at the top level.

What about modules wrapped in an IIFE?

The problem is that not supporting certain use-cases is quite hard, when no support means the rule will just ignore them and never report any problems. For that you must actively detect such patterns and ignore them in the rule otherwise you would end up with problems being reported that don’t make any sense.

What about modules wrapped in an IIFE?

Ugh, didn't think of those. For what it's worth, most rules in this plugin don't support require, and those that do didn't take those cases into account afaik (the order rule for instance doesn't).

most rules in this plugin don't support require

Might be a bit too general. I think the ones that can (i.e. not supporting import-specific syntax things), do. (i.e. no-unresolved)
I still think that IIFE and other cases would be best supported by a visitor that interacts with BlockStatement's body array, which is compatible with the Program node.
So you only handle AssigmentExpression and CallExpression if they are a direct descendant of Program or BlockStatement.
So you'd also enforce newlines in any function body, i.e.
function foo() {
  var y = require('whatever') // AssignmentExpression
  require('something-else') // CallExpression

  // ^ this newline is enforced
  /* ... code ... */
}

Would work inside if and anything else that uses a block.

So you only handle AssigmentExpression and CallExpression if they are a direct descendant of Program or BlockStatement.

I thought about the same, but unfortunately an AssignmentExpression is never a direct descendant of a Program or BlockStatement node, it is wrapped either in an ExpressionStatement or in VariableDeclarator within of an VariableDeclaration. Which leads to another edge-case, if you define multiple variable bindings in one var statement, for example:
var a = require('a'),
    b = require('b'),
    c = require('c');
var d = require('d');

Ahh, yeah, that makes sense.
So, now that we've all gone on this discussion adventure: anyone opposed to merging this as-is? Seems to be strictly an improvement and fixes #318? I think we're all in agreement, just double-checking.

Seeing no feedback, will merge as is. Thanks, @lo1tuma!

Thanks @lo1tuma :D


Display password on browser

User Story
AS AN employee with access to sensitive data
I WANT to randomly generate a password that meets certain criteria
SO THAT I can create a strong password that provides greater security
Acceptance Criteria
GIVEN I need a new, secure password
WHEN the password is generated
THEN the password is either displayed in an alert or written to the page

completed


Use match DB

WIP

This seems to be working @szhan, so I think we'll merge it and try it out to see how it goes. Needs a bunch of work, but hopefully on the right path.


"Enlarge" spells roundoff errors cause characters to gradually shrink

Present in vanilla, but exacerbated by the different float->int library we use in TemplePlus.

Are you really sure this is the cause btw?
float->int is pretty stable across MSVC libraries i think.
The order of floating point operations however will influence the accuracy of your result.
At no point should floating point numbers be compared using ==, that will lead to errors such as this. Either always use an episolon for comparison or straight less than/greater than.

Well the fact is I have observed different behavior in TP vs. Vanilla, for functions we haven't touched.
Either way I have converted the floating point operations to integer multiplication / division -> instead of 1.8 I multiply by 9 and divide by 5 and vice versa.
This still results in some roundoff (ultimately to the next lowest multiple of 5) but that's acceptable I think without complicating things.


Aggregate column is not marked correctly for all countries

Original issue https://github.com/covidatlas/coronadatascraper/issues/378, transferred here on Thursday Mar 26, 2020 at 09:18 GMT

e.g. AUS has one row for entire country marked as "state" which should be "country" and it has 6 rows for the states Australian Capital Territory, New South Wales, Northern Territory, Queensland, South Australia and Victoria which are blank but should be marked "state".

(Transferred comment)
In addition, countries like the USA have a country level count in addition to state and county, but then countries like China only have data at a province level... so I'm starting to go a little crazy with what countries to aggregate/melt!

(Transferred comment)
@sagarkulkarny hmm, you may be right about AUS, @camjc can you look into it? We should be properly setting aggregate: 'state' on both the states and the rolled up data for AUS itself.

(Transferred comment)
@mdibenigno I don't see the problem at all here. CHN clearly says aggregate: state, and so does every single CHN province -- if you want totals for all of CHN, then just take CHN.
Look at the code on the map: https://github.com/lazd/coronadatascraper/blob/master/site/map.js#L133-L160
You can see we find out what is a county, what is a state, and what is a country and choose which one to display by looking at aggregate.

(Transferred comment)
@tautme says

The aggregate labels for country total cases are not consistent. #378


Allow auth using an arbitrary HTTP header

This allows the Hydra client to authorize with the admin backend using an arbitrary pre-shared token set at an arbitrary HTTP header key (defaulting to Authorization).
I've named this "http_header" authorization.

LGTM overall, left some comments.


[SL5] - Lid switch not working, but it was working with a "normal" kernel...

Hi everyone,
First off: very deep appreciation for everything already done here :).
I have a Surface Laptop 5 running on nixos with the nixos microsoft-surface-common module. Everything working (this includes suspending and waking up with the power button) except when I close the lid, nothing happens.
The screen stays on (I can see the light bleed through the small gap) and while evtest does mention that there is a lid switch input, when running it and closing, it doesn't detect anything.
Funny thing though is that when running the standard 6.6 kernel from nixos 24.05 release, the lid closing actually does make the computer suspend (but then it doesn't wake up because well... not running the linux-surface kernel I guess).
I saw that this is handled by the surface_gpe kernel module, but I see with lsmod that it's not loaded and when I try to load it, I get the following error message in dmesg:
modprobe: ERROR: could not insert 'surface_gpe': No such device
and in dmesg:
surface_gpe: no compatible Microsoft Surface device found, exiting
I think it's because surface_gpe still has a separate sl5 branch which might include the fixes needed but isn't part of master: https://github.com/linux-surface/surface-gpe/tree/devices/sl5

Anything more I need to provide in terms of logs?
Anybody that can help me build this surface_gpe kernel module from the sl5 branch on nixos and test it? I know a bit of nix configuration but building out of tree kernel modules is a bit above my current knowledge...

I also opened an issue on the surface_gpe repo (https://github.com/linux-surface/surface-gpe/issues/4) but just in case they don't reply, if anybody could help me build and test this kernel module, would be great :)!


Wrong directory referenced for yarn config

A recent commit (#489) changed the location of the yarn config files from /conf to /conf/yarn, but the gobblin-yarn.sh script references them at /yarn/conf.  Which one is correct?

conf/yarn should be the correct location.

I created a PR to fix this: #496

Yes, this was incorrectly set in https://github.com/linkedin/gobblin/pull/489/files but was fixed in https://github.com/linkedin/gobblin/pull/492 and https://github.com/linkedin/gobblin/pull/496
I just merged https://github.com/linkedin/gobblin/pull/496


try to fix linux ci

idk @puyoxyz do smth

bruh, the build have succesfully be do

but this build for macos
but the file who have been modified is the linux build file, not the macos file...


sqlx_store::SqlxStore is a private module

Trying to return sqlx_store::SqlxStore in a init function to bootstrap application.

Precisely sqlx_store::SqlxStore

We can make this public but note that it'll require generics or the concrete specification of those. The latter case is accounted for by pool type via the public types, e.g. MssqlStore, etc.

Of course


Thompson simulation implementation for NFA

Some notes:

Current implementation uses maps instead of arrays, might switch depending on performance
Will discuss with Michael about adding initial/final field flags to individual NFA nodes instead of maintaining them within an array (has O(n^2) worst-case search when checking for final node existence)

Hi Michael, meant to make a pull request to our forked repository. As per your suggestions and Professor Davis's, I made some changes other than this (particularly implementing sets instead of maps and removing redundant functions) and embedded it within nfa.test through an optional argument. I will create a pull request once I've confirmed everything works great.
Regarding the last comment on the match import, I accidentally left that in before creating the pull request. It's fixed now in the fork and will be present along with the test cases in the pull request.

Cool. Looking forward to it.
Also, you can also make feature branches directly in this repo if you wanted to. Syncing forks can be hassle. (It also makes it easier for me to checkout and review code.)


Build tools/filters failed on Mac OS X 10.10.3 & XCode 6.3

When build mongrel2 with XCode 6.3.2 command-line tools, tools/filters failed because of symbols not found. Some symbols comes from zmq and could be fixed by add -lzmq to %.so target in tools/filters/Makefile. But the leak of _taskmain symbols, I don't know how to fix it correctly. I have add src/mongrel2.o to the target, and it works, but I don't known whether it is correct or not.
I am using brew to install zmq and sqlite3. The other problem is that library path is not corrent. This could be fixed by either set the global C_INCLUDE_PATH and LIBRARY_PATH or use the OPTFLAGS. The /usr/local/include and /usr/local/lib should be in the finding path.
I think an empty taskmain function that is implemented in the filter could also solve the problem. but I have no idea about what it should be in the filters.

I use macports, and there is a build rule for that.  It ought to work with brew with just a few tweaks.

@jasom I already figured out how to solved the compiling problem. But the last thing I am not sure is that do I do the right thing to solve the taskmain problem. Or I need to create an empty taskmain function in sendfile.c

I had to check my makefile, it' in there for the macports build rule; the option you need is -undefined dynamic_lookup


feat(mempool): add metric size of pool in bytes

This PR exposes a new metric SizeBytes for the total size of the mempool in bytes. We already keep track of this value internally, in the variable txsBytes. Currently there is the metric Size for the size of the mempool in number of transactions.

Overall this makes sense to me.

@hoank101 what motivated this PR? Is there a Github issue we can link in the PR description?
Should we submit a similar PR upstream in CometBFT?
I modified the PR title to conform to conventional commits.

thank you, PR is already in CometBFT, I think it is missing in your chan, will help monitor metrics

PR is already in CometBFT

Thanks! I found https://github.com/cometbft/cometbft/pull/1512

can you merge it @evan-forbes @cmwaters ?


Connection queue size

It would be good to add connection queue size getter just for monitoring purposes. Looks pretty simple to implement.

:+1:


Loop. How to?

how to do a never end loop?

also interested about this, any info?

while (true) {
object.animation = "name_here"
object.animate()
}

ok that was really easy, I should have seen that coming. Thanks!

no problem, glad I


Error after posixification changes

I received the following error when deploying to S3 with the latest change to path posixification changes:
Traceback (most recent call last):
  File "/usr/local/bin/lektor", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args[1:], **kwargs)
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/lektor/lib/python2.7/site-packages/lektor/cli.py", line 290, in deploy_cmd
    for line in event_iter:
  File "/Users/alice/Projects/lektor-s3/lektor_s3.py", line 254, in publish
    diff = self.compute_diff(local, remote)
  File "/Users/alice/Projects/lektor-s3/lektor_s3.py", line 146, in compute_diff
    key = posixify(self.key_prefix + f)
  File "/Users/alice/Projects/lektor-s3/lektor_s3.py", line 279, in posixify
    return posixpath.join(*split_path(path))
TypeError: join() takes at least 1 argument (0 given)

It was never entering the while loop in split_path because os.path.split(path) was always returning an array where the first element was an empty string. I fixed this for myself by changing the initialization of last_split from an empty string to None. The tests pass but I'm not 100% sure if it's the way to go since I don't really know why the problem occurred in the first place. I have opened a PR anyway.

Jut wanted to say I ran into the same error yesterday. I'm on windows with a fresh install of lektor and lektor s3. @heldinz fix worked for me too.


Data race

Thread sanitizer is often complains about data race in "_synchronize" function:
private let lockQueueSpecificKey = DispatchSpecificKey<Void>()
private lazy var lockQueue: DispatchQueue = {
	let queue = DispatchQueue(label: "com.freshOS.then.lockQueue", qos: .userInitiated)
	queue.setSpecific(key: self.lockQueueSpecificKey, value: ())
	return queue
}()

private func _synchronize<U>(_ action: () -> U) -> U {
	if DispatchQueue.getSpecific(key: lockQueueSpecificKey) != nil {
		return action()
	} else {
		return lockQueue.sync(execute: action) // <- Data race detected here
	}
}

That's probably due to using lockQueue from many threads simultaneously. And lockQueue is a lazily computed variable, which is not thread safe.

That's true. Thank you for your feedback.

Please check PR #46 if it works correctly. Thanks!

@green-caterpillar this is now in https://github.com/freshOS/then/releases/tag/4.1.1 :)

Closing this for now, feel free to reopen if needed :)


anonymous function not written before payload while reciving the messege

messaging.onMessage((payload)
while receiving the message in the index page by onMessage event the anonymous need to be written before calling payload in the round brackets.

@adilKhan72 can you please provide a bit more context? I'm not sure what you mean.
I'm able to run the messaging quickstart and receive both foreground and background messages without issue.


Request for help with centrality measures

Hi all,
I've got betweenness_centrality pretty much done - that is, I translated the NetworkX code to Julia.
I need some help, though, both in validation and in optimization. The code itself runs pretty much on-par with NX, which means that there are probably some significant optimization opportunities for it. (Betweenness with weights, using modified Dijkstra, actually runs a bit slower in Julia.) Any advice on how to speed things up would be greatly appreciated.
For validation, I've done some simple tests to confirm everything's accurate, but more comprehensive tests would be appreciated. I'll be coding up more centrality measures shortly (see the TODO list) and would really appreciate some help here.
Repo here: https://github.com/sbromberger/GraphCentrality.jl
(Just FYI: I've made it separate from Graphs until it's in a good enough shape; then I'll propose adding it. See #129 for more info.)
Thanks,
Seth.

Closing this out since LightGraphs is now live and has optimized centrality measures, as does GraphCentrality. Contributions still very much welcome!


Stopped working on Chrome

I use the filler for local VueJS development work.
Since a recent update to Chrome, the filler still fills the fields, but if I then go to the next step of the form, it doesn't carry the data over.
If I go back and make a single change to the field, it commits it to the field.
I don't know if it's some sort of focus/blur check Chrome has decided to include to prevent automated field completion but it makes simple form completion for testing a lot of work.
Hopefully, there's a workaround for this. I've tried other form fillers with the same outcome, which is what makes me think it's Chrome related rather than the extension. This is also the case on our staging server so it's not just isolated to a local test environment.

Issue turns out not to be related to extension, closing.


Migrate to dep for dependency management (OSIO#2873)

Generating the Gopkg.* by running dep init, then
adapting the Makefile by replacing all calls to glide
with calls to dep.
Also:

download specified version of dep and use it
update doc, remove assetfs, add .dockerignore
set version on goa and satoro/go.uuid
updatr to latest version of auth (to date)
include fabric8-auth/account pkg in dependencies
generate fabric8-auth/account/tenant in vendor
update stretchr/testify to 1.2.1
Add test-keeper.yml to validate build (the 'Ike'
bot will no longer complain if there is no test
in the PR while it only brings changes to the
Makefile.)
remove the glide.* files as they are
no longer needed.

Fixes openshiftio/openshift.io#2873
Signed-off-by: Xavier Coulon<EMAIL_ADDRESS>

Codecov Report

Merging #2011 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #2011   +/-   ##
=======================================
  Coverage   65.56%   65.56%
=======================================
  Files         150      150
  Lines       13685    13685
=======================================
  Hits         8973     8973
  Misses       3892     3892
  Partials      820      820

Impacted Files
Coverage Δ

token/token.go
46.84% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53bc50...bcfb1ad. Read the comment docs.

@xcoulon snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-2011-2

/ok-without-tests

thanks for your patience with this PR review, @kwk! :)

[test]

@xcoulon snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-2011-7

/ok-without-tests


[stable/redis-ha] Add extraContainers option for running custom sidecar workloads

What this PR does / why we need it:
This PR introduces extraContainers option to enable chart users to run their own sidecar workloads in the redis-ha pods.
Special notes for your reviewer:
I have only implemented extraContainers. If you think it would make sense to also implement extraVolumes, extraSecrets etc. I'll be happy to do that.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @dandydeveloper

@lauripiispanen Can you just explain the use-case here and examples of the types of sidecars you'd want to add here?

Certainly! Our use case is that we run GKE and many of our workloads use prometheus-to-sd to push our metrics to StackDriver. This would let us add prometheus-to-sd as a sidecar to scrape the exported metrics.
Theoretically, the exporter itself could have also been implemented with the extraContainers sidecar extension mechanism, but that one is such a common use case that it makes sense to offer it built-in. https://github.com/helm/charts/issues/4283 would hint that a this mechanism is useful enough to adopt as standard practice for all or most offered charts, as it enables other people to satisfy their differing use cases with minimal impact.


[5.2] Adding seeJsonStructure helper method

Using this method you can check if a response has a certain structure.
This is also a recursive method, example usage:
$this->seeJsonStructure([
    'token',
    'user' => [
        'id',
        'name' => [
            'first_name',
            'last_name',
            'full_name'
        ],
        'email',
        'created_at',
        'updated_at'
    ]
]);

What does the second argument ($responseData) do?

@taylorotwell that's how the method can be recursive.
At first it would be null, so the "real" response would be set to that variable.
But then you want to do this method recursively, so you can check the nested data as well.

Ah ok, so the end-user would never manually pass in the second parameter?


Integration test with image comparison

[Pipeline] sh ([hide](http://localhost:8080/job/HodographMaps_Run/9/console#))
+ ./run_script.sh 12

Hodograph Maps Run Script
Version: 0.1

Configurations:
Model run: 00z
Leadtime: 12z
Today Date:  31.07.2024

Start downloading leadtime 012h
Plot Hodograph Maps
done with leadtime 012h on Mi 31. Jul 12:57:46 CEST 2024
mv: cannot stat './src/images/*12.png': No such file or directory
ls: cannot access './results_img/*12.png': No such file or directory


Custom connectors: Create buildConnectors function

⚠ Part of: https://github.com/Shopify/blockchain-components/issues/35
ℹ What is the context for these changes?
This PR creates a new function called buildConnectors that allows developers to pass in a custom list of connects, control whether the default list is shown, and if the previous is true, pass in a list of default connectors to exclude. This PR does not refactor the package to use the new buildConnectors function, that will be captured in follow-up PRs.
The buildConnectors function replaces the current getDefaultConnectors function and the useDefaultConnectors hook. The intention is that custom connectors returned from the function will be passed into the ConnectWalletProvider to be accessible throughout the package.
To note

If both custom connectors and default connectors as providers, the default connectors will be appended to the end of the custom connectors list
In the case where a custom connector has the same id as a default connector, the custom connector will take precedence and the default one will be automatically excluded

🕹 Demonstration

...

🎩 How can this be tophatted?

...
✅ Checklist

[ ] Tested on mobile
[ ] Tested on multiple browsers
[ ] Tested for accessibility
[ ] Includes unit tests
[ ] Updated relevant documentation for the changes (if necessary)

Note: Not including changelog as it will be included on the feature branch

Note: Not including changelog as it will be included on the feature branch

Changelog checks only occur when merging into main and when the label Skip Changelog is not included in the list of labels for the PR 🙂


add xcprivacy to all subspecs

Backport #1643 to lts_2024_01_16 branch

Tests is done in #1643, all subspecs now have xcprivacy.
They are upgrading to latest version, so 2024_01_16 should be enough

@derekmauro
Hi Derek, could you take a look at this one?
Hopefully, we can backport #1647 and #1639 together into 2024_01_16, and publish to cocoapods as 1.20240116.2 soon.
Thanks
@paulb777 @sampajano

I haven't had time for this, sorry.

I've cherry-picked this and a few other patches into https://github.com/abseil/abseil-cpp/releases/tag/20240116.2.

Thanks. What is the process to publish the CocoaPod? I still don't see it at https://cocoapods.org/pods/abseil

Thanks. What is the process to publish the CocoaPod? I still don't see it at https://cocoapods.org/pods/abseil

We have nothing to do that. @veblush is the maintainer of the CocoaPod.

1.20240116.2 got released.


Roll engine e65beb89da8b..6ed00a868860 (6 commits)

https://github.com/flutter/engine/compare/e65beb89da8b...6ed00a868860
git log e65beb89da8b..6ed00a868860 --no-merges --oneline
6ed00a868 Roll src/third_party/skia 5518e65d90d7..82bf31003c66 (1 commits) (flutter/engine#6220)
8d9e20c02 Roll src/third_party/skia 3c4d533d8ebd..5518e65d90d7 (1 commits) (flutter/engine#6219)
8f39cac12 Roll src/third_party/skia 7891994e89a3..3c4d533d8ebd (1 commits) (flutter/engine#6218)
e3133e0e3 Reapply "Some cleanups enabled by removing support for Dart 1." (flutter/engine#6216)
1fb01f335 Roll src/third_party/skia a2bc1ca21bbc..7891994e89a3 (9 commits) (flutter/engine#6217)
f19ee56e6 Roll freetype2 to 6581fd3e9c8645f01c0d51e4f53893f5391f2bf3 (flutter/engine#6214)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6312378543112192

Commit queue failed; closing this roll.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/302 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 3d1943c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-01-14-10-16-26 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-01-14-10-16-26

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Got 'undefined' when using this library.

Hi, I tried your library, and used your example code, but got undefined result instead of a JWK.
I want a JWK only contains my Public key, so I runned your code as

var fs = require('fs');
var rsaPemToJWK = require('rsa-pem-to-jwk');

var pem = fs.readFileSync('pubk.pem');
var JWK = rsaPemToJWK(pem, {use: 'sig'}, 'public');
console.log(JWK)  // undefined

Here is my PUBLIC key(the content of pubk.pem).
-----BEGIN PUBLIC KEY-----
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAwp6e3ABsGZGTjqmUWIGP
99cXucPOoM0sbc2wxdxrXCahlqKRvxcjl+QyCQOZC3Ff3BKI0B7PF+XiU1gcbqXE
r942MlVs6GIbohPF98BIxaUX/nJFDziABfDAQ/EDTpsSJIaE/UhhoWdTjU/XG5nz
4dQZWTKaw7SdD2EvjH+4uG1KbyOavLeeqjrItItIEedHeaXYSIy7P+6N+yZ6qYkW
ALnpm+Lqi0sxrPZDuiQ5Bq4bdYvaKOMBxbHzah5FOZF3bxPLVBjzOH0PtxvUdgLk
9sQ1Hl3k5LbEPrbG709ssEjO5pKJZwx21M6yrxAIZJjLLz6t81s/e0Lx55kTu4h9
QwIDAQAB
-----END PUBLIC KEY-----

Any ideas about this ?

I am facing exactly the same issue. I tried using 'private' in place of 'public' for generating var JWK. Same issue.

Hey @modu,  I found another Python package to generate JWK and it works.
http://jwcrypto.readthedocs.io/en/latest/jwk.html#examples

This library only supports the RSAPublicKey format. More info can be found here https://github.com/OADA/rsa-pem-to-jwk/blob/master/README.md#pem-format
You should think about using a better implementation as this project uses a quick hack. Since we wrote this pem-jwk was released. It uses asn1.js to read pem files with more success. We now use pem-jwk in our projects.

Yea this project is broken.

Make sure there is a newline at the end of your PEM block. It took a few tries but that seemed to be the trick. This works for me:
const rsaPemToJwk = require("rsa-pem-to-jwk");
const pem = `-----BEGIN RSA PRIVATE KEY-----
...
...
...
-----END RSA PRIVATE KEY-----
`;
rsaPemToJwk(pem, {use: "sig"}, "public");
// => { kty: 'RSA', use: 'sig', ... }

Instead of -----BEGIN PUBLIC KEY----- and -----END PUBLIC KEY----- you have to have -----BEGIN RSA PUBLIC KEY----- and -----END RSA PUBLIC KEY-----

Fixed in #6.

A possible solution could be to add a new line at the end of the PEM file:
  const privateKey = fs.readFileSync(`${__dirname}/../../certs/private.pem`);

  const certString = privateKey.toString("binary"); //Convert from buffer to string

  const cert = certString + "\n"; //Add a new line at the end of the file

  const jwk = rsaPemToJwk(cert, { use: "sig" }, "public");

console.log(jwk);

Seems like this library is using a very old outdated package (https://www.npmjs.com/package/rsa-unpack)
And the expected private key must start with ----BEGIN RSA (PRIVATE|PUBLIC) KEY-----
I made this library works with private key generated with
ssh-keygen -t rsa -b 2048 -m PEM -f private.pem

But not with openssl, since the key started with -----BEGIN PRIVATE KEY----- or -----BEGIN ENCRYPTED PRIVATE KEY-----

This library only supports the RSAPublicKey format. More info can be found here https://github.com/OADA/rsa-pem-to-jwk/blob/master/README.md#pem-format
You should think about using a better implementation as this project uses a quick hack. Since we wrote this pem-jwk was released. It uses asn1.js to read pem files with more success. We now use pem-jwk in our projects.

You should maybe make this clear in the README.md that it is better to use pem-jwk then this lib. This will save many people a lot of time.


[BUG] Name of tool when arrow hovers on it.

Name of the tool should be displayed when arrow hovers on the tool icon.

The icon is looking the same, even after hovering over the icon
So, dear PA; please assign me this issue under gssoc label as I have a clear knowledge of html and css

Dear PA, please assign me this issue under GSSOC label
I have my expertise in HTML and CSS
I will add the icon name after hovering over it.

@tarushi29 Do you want to work on the issue, If yes then under which program GSSOC or SSOC?

@tarushi29 Do you want to work on the issue, If yes then under which program GSSOC or SSOC?

yes assign me it under gssoc label

@tarushi29 Assigned, Best of Luck :)

I would like to work on this issue under gssoc. Please assign this issue to me.

@tarushi29 Any update?

@HJ2207 Someone is already assigned the issue.


Filepath support

As mention here

@SevereOverfl0w this implementation does not manage the plugin since you are bound to do that yourself considering you are using a local version of a plugin or a something you are developing yourself. All it does is adds it to the rtp and source the plugin files. Let me know if there is something that can be done to improve this.

I think this is perfect. All I want is to not have to touch anything separate to get my own plugins into vim!

Perfect, thanks for bringing this up.


[Example] Could we get an example with CRA

I think it would be super useful to have a Create React App example of this available. I started creating one but I am running into problems with React-Dom
import React, { Component } from 'react';
import './App.css';
import Animated from 'animated';

class App extends Component {
  constructor(props) {
    super(props);

    this.state = {
      animation: new Animated.Value(0),
    }
  }

  render() {
    console.log(Animated);
    return (
      <Animated.div className="App">
      </Animated.div>
    );
  }
}

export default App;

And I am getting this error, what am I doing wrong?

Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in. Check the render method of `App`.

Hey @rileybracken, you need to import the ReactDOM version like so:
import Animated from 'animated/lib/targets/react-dom';

oh, I started a workaround by doing this:
import Animated from 'animated';

const AnimatedDiv = = Animated.createAnimatedComponent('div');

@rileybracken this is possible. However just like react-native the main helper methods are provided. You can see that here https://github.com/animatedjs/animated/blob/master/src/targets/react-dom.js#L47

I think the main reason there is no example (and haven't pushed for one) is that this library isn't prime time or production ready. If anything would probably spin up a separate repo to show off examples vs including in this repo.
Could probably pull https://github.com/animatedjs/interactive-docs and switch it over to CRA

my main issue with this
import Animated from 'animated/lib/targets/react-dom';
is that I have to remember it, if I am creating a ton of components that have Animated this could get tedious. You could make the same argument for the way I am doing it, but it is declarative on what is happening.
I would rather type more and be more explicit as to what and why I am doing it, instead of just typing more.
That might not make much sense, but it does to me 😄 .

Oh I'm totally with you, typing that out or even creating a snippet is a bit nuts. Back to the definite not prime time point haha
You could use the browser key in your package.json and point animated at 'animated/lib/targets/react-dom' I think. Or use a webpack resolve /babel config resolve module.
Also I think we can potentially set that up in the Animated and point to the proper file w/ main right?

It seems like setting that up in the Animated package.json is the easiest solution. It is almost so easy that it makes me skeptical. Is there a reason why it isn't currently done that way?
If I did this and made a PR would it break something, I guess I could test it in RN and React.

@rileybracken This isn't use for RN internals. This is a copy. RN looks at the react-native key in your package.json so we could set that up and point to the correct target that way.

@rileybracken and @browniefed Just a heads up on this, if you use .createAnimatedComponent() for this, it does not recognize or add the transforms to the element style, but will add other styles. I tried the import Animated from 'animated/lib/targets/react-dom';, and the transform worked as expected.

@paigecwilley This is good to point out. You can check out the implementation of why here https://github.com/animatedjs/animated/blob/master/src/targets/react-dom.js#L25

Yeah I think good next steps for this would be to:

Translate the example to CRA
Create a new issue to do what we are talking about here https://github.com/animatedjs/animated/issues/62#issuecomment-292320924

@rileybracken Yes. However the structure of a transform in RN looks like
{
  transform: [
{ scale: 2},
{rotateX: "90deg"},
{translateY: 50}

]
}


[SPARK-11114] [PYSPARK] add getOrCreate for SparkContext/SQLContext in Python

Also added SQLContext.newSession()

Merged build triggered.

Merged build started.

Test build #43741 has started for   PR 9122 at commit e5a2437.

Test build #43741 has finished for   PR 9122 at commit e5a2437.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43741/
Test FAILed.

Test build #1902 has started for   PR 9122 at commit e5a2437.

Test build #1902 has finished for   PR 9122 at commit e5a2437.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build triggered.

Merged build started.

Test build #43755 has started for   PR 9122 at commit f92cd43.

Test build #43755 has finished for   PR 9122 at commit f92cd43.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43755/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #43847 has started for   PR 9122 at commit f272ddc.

Test build #43847 has finished for   PR 9122 at commit f272ddc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43847/
Test PASSed.

LGTM merging into master. Thanks @davies!


345 UI broken in home page

#345

some changes in the font-size and grid-matrix
now it look stable in every font size

Checked this PR :

[x] For duplication.
[x] For performance.
[x] Usage of recursive methods, loops and algorithms.
[x] For readability and understanding.
[x] For functions with multiple responsibilities.
[x] For scope of refactoring.
[x] For coupling
[x] For alternative approaches to the implementation.
[x] For how the change impacts other parts of the system.
[x] For validations. client side and server side validations are present.

For more insights on code reviews checkout our guidelines.


Add favicon to docs, update html static path

Closes #385

Codecov Report

Merging #390 (e523b30) into master (814beba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   97.84%   97.84%
=======================================
  Files          22       22
  Lines        2088     2088
=======================================
  Hits         2043     2043
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814beba...e523b30. Read the comment docs.


Add Types for the plugin

Would you prefer if I did a PR? Typescript support is pretty important

1.8.0 has added types, sorry for the long wait🥶


Wallet recovery with passphrase is not working

initwallet REST API is working without passphrase but it fails with passphrase, with 'invalid passphrase' error message.
I opened first issue about this API #3128 (https://github.com/lightningnetwork/lnd/issues/3128) almost 10 days back also and i am testing these scenarios from almost last 15 days. I found that initwallet REST API is behaving strangly.
If I generate the genseed with passphrase through lncli and use this cipher_seed_mnemonic array to recover the wallet through initwallet REST API, then it works perfectly. But, if i will generate the genseed with passphrase through REST and use that cipher_seed_mnemonic array to recover with initwallet REST then i am getting 'invalid passphrase' error.
Your environment
version of lnd: 0.6.0-beta
which operating system: Windows
version bitcoind: v0.17.1
Steps to reproduce

Call GET /v1/genseed with aezeed_passphrase value.
Call POST /v1/initwallet with wallet_password. it will initialize the wallet successfully.
Delete the wallet manually.
Call POST /v1/initwallet with wallet_password, aezeed_passphrase and cipher_seed_mnemonic array generated from step 1.

Initialize wallet with below details:
Method: POST,
url: https://<IP_ADDRESS>:8080/v1/initwallet,
payload: {
"wallet_password":"c3VoZWIxMjM=",
"cipher_seed_mnemonic":["absent","stuff","layer","holiday","slam","pelican","drift","heart","prepare","casual","treat","liar","small","venue","fragile","wise","frown","safe","brief","cherry","pigeon","pole","sound","rocket"],
"aezeed_passphrase":"dGhpc2lzbXlwYXNzcGhyYXNl"
}
Expected behaviour
It should successfully recover the wallet.
Actual behaviour
Failed response with { "error": "invalid passphrase", "code": 2 }
I have tested initwallet with multiple scenarios and all the scenarios are working with GRPC but not with REST.

Do you understand the difference between the aezeed_passphrase and the wallet_password? Only the wallet_password is actually required.
Perhaps it's an issue of encoding (base64) between the wallet calls? Will try to reproduce on our end.

We are not using passphrase when initializing the wallet, using it only to recover the wallet. And if it is not even required for recovery then can you please explain the use case where passphrase should be passed to initwallet API?

I don't think there's an issue here given that things are working fine with gRPC. Like @Roasbeef mentioned, it is most likely an encoding issue of the distinct passphrases.

We are not using passphrase when initializing the wallet, using it only to recover the wallet. And if it is not even required for recovery then can you please explain the use case where passphrase should be passed to initwallet API?

wallet_password is the password to unlock the wallet. This does not serve a purpose other than encrypting your secrets on-disk. It is always required when using initwallet.
aezeed_passphrase is an additional optional passphrase that only applies to your seed and not your wallet.

The scenario that we are testing is:

Intialize a wallet with aezeed_passphrase and generate a cipher seed (from genseed api)
Try to recover the same wallet by passing the aezeed_passphrase and the previously generated cipher_seed_mnemonic

The scenario works when the seed and the passphrase are generated with grpc.
The recovery step fails when the seed and passphrase generated via REST APIs are used.

I hope you haven't got funds in there,let me know if you still need assistance with this.

@ashwilly, we didn’t have any funds to recover as we were on testnet. We are developing an application called ‘Ride the Lightning’ (RTL) and we wanted to include create new wallet feature for our users but unfortunately we are also worried about the recovery. We will appreciate any help on the issue :). Thanks.

Was this eventually resolved w/ proper API usage?

No, it is still an open issue and our user will still be unable to recover the wallet with passphrase.

Can you please try if base64 encoding the wallet_password and aezeed_passphrase helps? Or passing in a Buffer into the request of walletUnlocker.initWallet instead of a string?

@guggero We worked on this issue almost 5 months back and as long as i can recall we were passing both in base64. But, let me recheck it once again. I will update you by today eod.

@guggero Appologies for the delayed reply. But, this time we are not even able to initialize the wallet with passphrase. Without passphrase (only password), wallet initialization and recovery both work perfectly.
But this time, when we are trying to initialize the wallet with passphrase, we are getting error as: {"error":"invalid passphrase","code":2}. Below are the steps to reproduce:

Called genseed with passphrase as "Test":
https://192.168.x.x:8080/v1/genseed?"aezeed_passphrase"=Test

Received response as:
{"cipher_seed_mnemonic":["abstract","shiver","pulp","carbon","shoot","unfold","disease","gain","snow","cement","blouse","this","crucial","absorb","fish","area","drama","pill","ill","elegant","orphan","oblige","dose","noble"],"enciphered_seed":"APjGtZE8adpPwvbNhKRg8GNGAZXoWkI0mcOjyc0wUGSt"}

Called initwallet API with "TestPassword" as password, "Test" as passphrase and above mnemonic value as cipher_seed_mnemonic.
URL: https://192.168.x.x:8080/v1/initwallet
options.form: {"wallet_password":"VGVzdFBhc3N3b3Jk","cipher_seed_mnemonic":["able","flower","income","fantasy","kidney","arrest","oxygen","elite","dice","mule","height","broken","marriage","island","rural","unfair","ticket","valid","awesome","poet","acquire","either","embody","chief"],"aezeed_passphrase":"VGVzdA=="}

This call is returing an error response stating that, it is an invalid passpharse.
Please note that password and passphrase both are base64 values of "TestPassword" and "Test" respectively.
With LND's past version, we were able to initialize the wallet with passphrase but unable to recover it.

@ShahanaFarooqui thank you very much for the detailed steps. I was able to reproduce the issue.
The problem why recovery doesn't work is because the password set in genseed is ignored.
It looks like if you pass the parameters in that way, they are just ignored. You need to set them as normal query parameters.
For example:
curl -k https://localhost:8099/v1/genseed?aezeed_passphrase=dGVzdA==
(base64 for "test").
But this will lead to the following error message:
{"error":"unsupported field type uint8","code":3}
This is a problem with the grpc-gateway library we use for the automatic translation between gRPC and REST.
I created a PR to update the library to a version that doesn't have this bug: #3650.

@guggero Thanks a lot for fixing it quickly :), hope it will be merged and released soon.
We also tried to use the query params the usual way (without quotes) but due to the above error, we had to pass them in quotes.
Also, the REST documentation, https://api.lightning.community/rest/index.html#v1-genseed, is advising to send the passphrase in string format NOT in base64. So, please confirm once again if we should use it in string/base64 format?

I think if there are no unexpected side effects of the fix then I think it can be merged quite quickly.
Correct, placing double quotes around the parameter name makes the error disappear. Because it is then just ignored by the REST gateway.
Please note that the REST documentation is auto-generated (I think from the rpc.swagger.json) and the data types noted there referring to JSON data types (of which there is only really string, number and boolean). So it is not very precise.
Maybe it helps to look at the rpc.swagger.json file directly:
    "/v1/genseed": {
      "get": {
        ...
        "operationId": "GenSeed",
       ...
        },
        "parameters": [
          {
            "name": "aezeed_passphrase",
            "description": "*\naezeed_passphrase is an optional user provided passphrase that will be used\nto encrypt the generated aezeed cipher seed.",
            "in": "query",
            "required": false,
            "type": "string",
            "format": "byte"
          },
          ...
        ],

You can see that the type is string but the format is really byte.
And the default encoding for a byte array is base64 in the library we use.
So short answer: Yes, it needs to be a base64 string whenever the Swagger format is byte.

@guggero, One last question :). Should the passphrase be used till seed generation only or we should pass it to init wallet API also? The documentation shows it as optional. But, if the passphrase is already being used to generate the seed then will it again be required at initwallet? Our flow diagram as per the documentation can be found here.

If the user sets a password and you send it with genseed then it is also required in initwallet. Otherwise lnd won't be able to decrypt the 24 words you send in initwallet.
If the user chooses to not set a password then it must be empty for both calls.

@guggero & @Roasbeef, We pulled the master branch and tested the passphrase fix thoroughly and it is working perfectly now. Thanks.

Hello eventough this issue is closed since you guys figured once how to use the api to obtain a seedphrase and then call initwallet i am reaching out as this servcie seems to be broken? Can you maybe provide me with an examplecode or smth how you guys did this? This is my issue: https://github.com/lightninglabs/lightning-terminal/issues/805


FEAT: include intermediate metrics of TRA into results

Hey @TimoK93,
Have you ever considered returning some intermediate metrics?
For example, AOGM, NS, FN, FP, ED, EA, EC when TRA metric is requested.
They are often reported in tracking papers.
Thanks for this packages, it's really useful!

I noticed some of them might already be there as TP, FP, FN, and IDSW, right?

Hey @JoOkuma,
cool that you had the chance to check the repo! Thanks a lot. Also a very good idea with the AOGM intermediate results. I added the measures to the result and released a new version. The new version that should satisfy your needs is implemented in branch #12  and released in Release v1.1.0.
Hope that this is all you had in mind!
Timo

That's perfect, thank you for the quick reply.


Use cl-remove-duplicates instead of remove-duplicates because the latter no longer exists in Emacs 27

Fix https://github.com/dash-docs-el/counsel-dash/issues/9

Hey @gilbertw1 @nathankot , could you take a look at this PR, please? Thank you

Merged. Thanks for the submission!


Add feature to handle high load/ split mode.

Split feature will help user to load high volume data. Catch job in case of failure of job. To process this kind of scenario need to add feature of file split.

@hutashan for all new features we will add a format design doc in docs/ page...The review on the doc can happen on google docs or somewhere...I will create a google group and let you know the format...once we agree on the interfaces and classes, impl can be pushed as a PR...


Remove mcquin as a maintainer

@mcquin recently asked that we remove her from the maintainer list.
I also removed the person field for Seth since he's not on the list anymore
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

:boom:


Find should accepts strings as selector

See http://docs.meteor.com/#/full/find

Available in 1.0.0-beta3.