Gridview inside pageview giving jank on scrolling pageview

Details

I'm working on a specific calendar package for my app needs and for that I'm using grid view inside pageview for the scrolling navigation behavior but the pageview scrolling behavior is causing a lot of janks as it has to rebuild the 42 elements of gridview every time pageview is scrolled.

So am I doing anything wrong here? Is grid view shouldn't be used for such types of applications? Also, how do other calendar packages or date pickers attain such a smooth behavior even during the debug mode.

The short example gist -> https://gist.github.com/chaudharydeepanshu/c1e3fe0386cb464514f62b73305962ee (Note this is just an example)

Device recording:-

https://user-images.githubusercontent.com/85361211/182958616-4aa98956-bad0-441f-ba37-e83fcf1c210b.mp4

Dart Timeline - https://drive.google.com/file/d/1r1kbbBUoey3BocZ82jirN21WTBgYX9ip/view?usp=sharing

Dart DevTools- https://drive.google.com/file/d/1cMQgrCayrLkkjGAMK1zIWuvOa6iwc1Eu/view?usp=sharing

https://user-images.githubusercontent.com/85361211/182958597-111f448d-bf79-4787-b257-cd819e48568c.mp4
Target Platform: Android
Target OS version/browser: 12
Devices: Redmi Note 10  Pro
Logs

Logs
Analyzing flutter_jank...
No issues found! (ran in 2.8s)

[√] Flutter (Channel master, 3.1.0-0.0.pre.2092, on Microsoft Windows [Version 10.0.22622.450], locale en-US)
    • Flutter version 3.1.0-0.0.pre.2092 on channel master at C:\dev\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0377468d59 (2 hours ago), 2022-08-04 15:30:10 -0400
    • Engine revision 9ec11a0550
    • Dart version 2.19.0 (build 2.19.0-64.0.dev)
    • DevTools version 2.16.0

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\deepa\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.1.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.1.32228.430
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.69.2)
    • VS Code at C:\Users\deepa\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (4 available)
    • Redmi Note 10 Pro (mobile) • d0646b2f • android-arm64  • Android 12 (API 32)
    • Windows (desktop)          • windows  • windows-x64    • Microsoft Windows [Version 10.0.22622.450]
    • Chrome (web)               • chrome   • web-javascript • Google Chrome 103.0.5060.134
    • Edge (web)                 • edge     • web-javascript • Microsoft Edge 103.0.1264.77

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thank you.

Hi!
I've just made a revision on your gist, i see two main performance problems.

check the diff on https://gist.github.com/BrianCraig/23b68df986ef6d1b84bdf46aeed9bbae/revisions
When you use any Builder (in this case PageView) the instantiated Widgets are built on the fly as required, so for example, if you have 100 pages, and it is on the first page, the second one isn't created, so when you slide to the right, flutter creates the second page. It is easier if you let the controller mantain its current page, and render based on the index.
Also i gave the controller a long number of pages, and made it start in the middle.

getDatesForACalendarMonthAsUTC is computed for each day on each month and seems quite intensive, try computing it once per month. (Check itemBuilder of the GridView).

hope it helps you, Brian

@BrianCraig Thanks for looking into this but I know that it easy with with your approach but actually the problem is that I don't want to provide fixed length of months to the page view builder and I only want to add items when user swipes left of right. I want the same experience of date pickers.
Also, thanks for noticing getDatesForACalendarMontgAsUTC. I forgot to put it above builder when creating example but even with that change the jank is still there.

In your code, the PageView builds the entire widget when scrolling. The GridView is built completely on the slightest scroll. This is working as expected. I suggest that you try Stackoverflow or other communities you can find on https://flutter.dev/community. Since this is not a bug or a feature request, I am closing this issue. If you disagree, please comment and we can reopen it. Thank you

@chaudharydeepanshu If you want to provide a fixed number of months just define it in the size, in the example i provided i set it to 10000, just a random number, you can use 12 if you want, and you will have 12 months. If you want an infinite calendar just use a size near to infinite, just as i did (i dont think anybody will scroll 5000 months)

@chaudharydeepanshu If you want to provide a fixed number of months just define it in the size, in the example i provided i set it to 10000, just a random number, you can use 12 if you want, and you will have 12 months. If you want an infinite calendar just use a size near to infinite, just as i did (i dont think anybody will scroll 5000 months)

After tinkering a while I actually think you are right. Also I don't think I have any other options as I have tried all methods and only custom scroll view will work but it has its own disadvantages like setting offset on orientation change. So the best bet here is pageview with big item count.

Also if anyone arrives on this thread in future looking for performance then I suggest that they is use pageview.custom with AutomatickeepAliveClientMixin as that will prevent pageview from building again and again on scroll.


Fix935 reopen

+1

Current coverage is 61.49%

Merging #1006 into master will change coverage by -0.05% by 1bc20d1

Coverage Diff
@@            master   #1006   diff @@
======================================
  Files          225     225
  Stmts         5687    5687
  Branches       453     453
  Methods          0       0
======================================
- Hit           3500    3497     -3
  Partial          0       0
- Missed        2187    2190     +3

Uncovered Suggestions

+0.34% via ...master/AmActor.scala#316...334
+0.30% via ...master/AmActor.scala#77...93
+0.28% via ...master/AmActor.scala#253...268
See 7 more...

Powered by Codecov


Update test exceptions

Updates to go with https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager/pull/16.
The tests here will fail, until the above PR is merged and released

@dhalbert are you able to restart tests?


Compile using VS2015

Hi,
This look really interesting, I am interested in using this in a small concept project.
I know the latest commit does not build, however would you be able to help me setup a visual studio project with the dependencies, when the project is stable again?

Hey,
the build should be stable - travis is currently failing because the build is taking too long (because I have to recompile cmake with every build since the travis version is too old).
If you have any questions or problems I will be happy to help! :smiley:

Awesome!
I ran cmake on Windows, with MSVC++ 14 as the compiler and it failed with;
CMake Error at CMakeModules/CodeCoverage.cmake:85 (MESSAGE):
Compiler is not GNU gcc! Aborting...
Call Stack (most recent call first):
CMakeLists.txt:14 (INCLUDE)

Ah, I see.
The problem is very likely the code coverage module, which requires gcc to work. I adjusted the CMakeLists.txt and included a Windows version. Just open the file and delete all the "Version 1" (Linux) lines and uncomment the "Version 2" (Windows) lines and try to generate your project files again.

Nice.
That did the trick,
I also have to add the /bigobj compiler option into the questweaver configuration within visual studio.
The compiler was also throwing errors about the MAX function being undefined, unless I added #include  to those files.
Also had to add #include  to SpaceWorldModel.cpp as it was throwing an error about back_inserter().
Also the project configuration is being created with the GCC -03 compiler option, which MSVC doesn't recognise.
I will have a look at this over the next few days, do you have any notes/examples to do with creating the quest templates and how to integrate it into an existing game engine/world?

Great, thanks - could you open a Pull Request, so I can merge your fix into the project? :)
As for any notes/examples:
There is a description on the project page: http://cultrarius.github.io/QuestWeaver/
Basically you have to create a custom WorldModel (see SpaceWorldModel for an example) that "knows" your game world and provides entities for the quest system. But the quest system will also want to create new entities, so your world model really is both ways and also affects the game.
For the templates, you need 3 things: a factory that creates teamplate objects (see SpaceQuestTemplateFactory.cpp for an example), the template objects (e.g. ExploreRegionTemplate.cpp) that know which elements to pick from your world model to create a particular quest and lastly the template file itself (e.g. ExploreRegionTemplate.qt) which defines variants for the quest description and title, says how rare it is, etc.
The most interesting thing however is the story generator! :)
Similar to the quests, you have a factory (see CommonSpaceStoryFactory.cpp) and a template class (PlanetIntroStoryTemplate.cpp) and two story files: the story "nuggets", which are the juicy parts of the story (Resources/Space/Nuggets.st) and a file which says how the nuggets are combined for different stories (CommonSpaceStories.st).
Another good starting point are the unit tests, you can for example have a look at the TemplateTest.cpp or the StoryWriterTest.cpp.
I can also create a small example project to get you started if you tell me a little more about what you want to do.


"base_url" conflict between symfony driver and zombie driver

I'm creating scenarios which some use the default symfony driver and some others that need javascript use the zombie driver.
I have had to create the app_test.php file and write the full path to it in the "base_url" option of the extension to make the zombie test work.
But then the scenarios that use the symfony driver use the "base_url" too to build the routes and of course, these don't exist. I'm I missconfigurating something?

Sorry to bump an old issue but I think this is better than creating a new one since I think my issue is exactly the same. When I run my tests with goutte or selenium2 driver it works great but when testing with symfony2 driver it will internally use the baseurl and go to "http://localhost/my_project/htdocs/" while this should simply be "/". Maybe someone can point out what is wrong with my config or maybe this bug got back somehow.
behat.yml
default:
    extensions:
        Behat\Symfony2Extension: ~
        Behat\MinkExtension:
            base_url: http://localhost/my_project/htdocs/
            browser_name: firefox
            default_session: symfony2
            sessions:
                goutte:
                    goutte: ~
                selenium2:
                    selenium2: ~
                symfony2:
                    symfony2: ~
    suites:
        front_end:
            type: symfony_bundle
            bundle: AppFrontEndBundle
            contexts:
                - App\FrontEndBundle\Features\Context\FeatureContext:

Versions:
Symfony: 2.8.4
Behat: 3.1.0
Mink: 1.7.1
Mink Extension: 2.2
Mink BrowserKit Driver: 1.3.2
Mink Symfony2 Extension: 2.1.1
Let me know if more info is needed.

@arnaugm @slootjes Have you guys managed to solve the issue? I still have the same issue even though I'm ready everywhere that PR have been merged and it's should be solved...
behat/symfony2-extension: 2.1.1
behat/mink-browserkit-driver: 1.3.2
behat/mink-extension: 2.2
behat/behat: 3.3.0

Thanks!


how to add pool at runtime?

I don't understand, you need to explain your question. Also, please try to keep questions to the mailing list.

@icook  , i want add new mining pool at runtime in simplecoin..

@frndxyz, If I understand correctly, you're asking if it is possible to update SCM while it is running to include information about a PowerPool instance. it is not currently possible to do that, although it is something that may be added eventually. For now, you'll have to change the SCM configuration and restart it.


WebRTC Multiple RTCPeerConnections

https://github.com/samdutton/simpl/blob/master/rtcpeerconnection/multi/index.html
This seems doesn't work well on chromium 34.

Apologies — this somehow never got sorted. That demo has gone now, so I'm closing this issue.


Update Jenkins versions

Upgrade Jenkins integration version from 2.306 to 2.312
Upgrade Jenkins production version from 2.306 to 2.312
See the latest changelog to check what will be updated

This includes version 2.307, which includes the breaking change that renames the main Jenkins node: https://www.jenkins.io/changelog/#v2.307
We've got a card about handling this, since it will probably need some changes to the build scripts: https://national-archives.atlassian.net/browse/TDR-1354


bind diopiProd to torch.prod

TESTED=python tests/test_ops/archived/test_prod.py

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

move to #285


Send hotkey instead of UID to all API endpoints

https://github.com/safe-scan-ai/cancer-ai/pull/21


PartitionAndJoin should throw an exception if it sees an unmapped read

PartitionAndJoin crashes with a null pointer exception when I call it to join a set of 4 mouse-chrM coordinates with a small mouse file.
You can find my mouse.bam, mouse.adam, the coordinate test.txt file and my source code here:
https://github.com/kozanitis/misc
This is the exception stack:
2014-07-09 09:39:57 WARN  TaskSetManager:70 - Loss was due to java.lang.NullPointerException
java.lang.NullPointerException
at org.bdgenomics.adam.rdd.NonoverlappingRegions.hasRegionsFor(RegionJoin.scala:311)
at org.bdgenomics.adam.rdd.MultiContigNonoverlappingRegions.filter(RegionJoin.scala:365)
at org.bdgenomics.adam.rdd.RegionJoin$$anonfun$5.apply(RegionJoin.scala:125)
at org.bdgenomics.adam.rdd.RegionJoin$$anonfun$5.apply(RegionJoin.scala:125)
at scala.collection.Iterator$$anon$14.hasNext(Iterator.scala:390)
at scala.collection.Iterator$$anon$13.hasNext(Iterator.scala:371)
at scala.collection.Iterator$class.foreach(Iterator.scala:727)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:158)
at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99)
at org.apache.spark.scheduler.Task.run(Task.scala:51)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:187)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

Closed as won't fix.


Allow insecure HTTPS connection to gitlab

Feature Description
Thank's for the work done on the plugin. Unfortunately, i can't use it on my enterprise environment due to the bad certificate of the self hosted gitlab server.
Once trying to connect, it throws:
gitlab.nvim: 2024/03/28 15:06:21 Failed to initialize project settings: Error getting project at https://srv-git/esv2/eai.git%!(EXTRA *url.Error=Get "https://srv-git/api/v4/projects/esv2%2Feai": x509: certificate signed by unknown authority)

This request is about to add a configuration to allow an insecure connection to the gitlab server (ie, like --insecure option for curl command)
Thanks !

Hey, could you please try this branch, rebuild the server, and see if it works for you?
https://github.com/harrisoncramer/gitlab.nvim/pull/229

Hi !
It works as expected ! Nice !
This plugin looks awesome,
Thanks dude,

I'll merge this into develop now. It'll be there for a few days while I make sure it doesn't cause other connectivity issues and then will merge into main.


Refactored html and css code.

Fixed indentation in the index.html file and moved in-line css to the external css/styles.css file to improve the structure a bit.

" I added inline css because according to google insights if you have small amount of css you should inline it as it loads faster.Anyways great job." oh really? I didn't think it made a difference. I need to google that!


Users UI added inside Dashboard

Users UI added inside the dashboard

Change "Edit Event to Edit User's Detail" on top of the modal.

oops soory ,but its  already done , that screen shot is captured earlier😅

@codebloded please add new ss

@ravisaxena23  DONE 👍


x/tools/go/ssa: multiple assign ssa.FieldAddr instr order error

What version of Go are you using (go version)?

$ go version
go version go1.18.4 darwin/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
 go env Output
$ go env

go version -m $(which ssadump) Output
$ go version -m $(which ssadump)
/Users/vfc/go/bin/ssadump: go1.18.4
	path	golang.org/x/tools/cmd/ssadump
	mod	golang.org/x/tools	(devel)
	dep	golang.org/x/mod	v0.6.0-dev.0.20220419223038-86c51ed26bb4	h1:6zppjxzCulZykYSLyVDYbneBfbaBIQPYMevg0bEwv2s=
	dep	golang.org/x/sys	v0.0.0-20220722155257-8c9f86f7a55f	h1:v4INt8xihDGvnrfjMDVXGxw9wrfxYyCjk0KbXjhR55s=
	build	-compiler=gc
	build	CGO_ENABLED=1
	build	CGO_CFLAGS="-g -O2"
	build	CGO_CPPFLAGS=
	build	CGO_CXXFLAGS="-g -O2"
	build	CGO_LDFLAGS="-g -O2"
	build	GOARCH=amd64
	build	GOOS=darwin
	build	GOAMD64=v1
	build	vcs=git
	build	vcs.revision=9d7fa4a49fed984f3980240b804508eff5988360
	build	vcs.time=2022-09-05T11:27:21Z
	build	vcs.modified=false

What did you do?

main.go
package main

type P struct{ i int }

func main() {
	var m int
	var p *P
	defer func() {
		recover()
		println(m)
	}()
	m, p.i = 3, 2
}

$ ssadump -build=F main.go
func init(): ....
func main$1(): ...

# Name: command-line-arguments.main
# Package: command-line-arguments
# Location: /Users/vfc/code/vtest/main.go:5:6
# Recover: 1
func main():
0:                                                                entry P:0 S:0
	t0 = new int (m)                                                   *int
	t1 = make closure main$1 [t0]                                    func()
	defer t1()
	t2 = &nil:*P.i [#0]                                                *int
	*t0 = 3:int
	*t2 = 2:int
	rundefers
	return
1:                                                              recover P:0 S:0
	return

What did you expect to see?
the  func main() instr order *t0 = 3:int   before of   t2 = &nil:*P.i [#0]
run line m, p.i = 3, 2 p.i is panic, but befor m is set, result is 3.
	*t0 = 3:int
	t2 = &nil:*P.i [#0]                                                *int
	*t2 = 2:int

What did you see instead?
the the  func main()  instr order error, the *ssa.FieldAddr &nil:*P.i [#0]  before of *t0 = 3:int.
run line m, p.i = 3, 2 p.i is panic, m not set, result is 0.
	t2 = &nil:*P.i [#0]                                                *int
	*t0 = 3:int
	*t2 = 2:int

@timothy-king It has to print 3. The other relevant clause here is in "Assignment statements":

The assignment proceeds in two phases. First, the operands of index expressions and pointer indirections (including implicit pointer indirections in selectors) on the left and the expressions on the right are all evaluated in the usual order. Second, the assignments are carried out in left-to-right order.

So the expressions p, 3, and 2 are evaluated in phase 1 in an unspecified order. Then in phase 2, the assignments m = (3) and then (nil).i = (2) happen sequentially.

Thanks. This is a bug then.


Bug with mask possession and items

I don't know if this is the issue fixed in 1.0.7 with the animation breaking, but the bug I wanted to submit is that the mask possessing me with the ship in orbit made it so every other item was zoomed in into my face, like if I was putting on the mask, which made it impossible to see anything whenever I was holding most items.

Animation breaks should be solved in newer versions, I recommend the newest version


ImageNet21K data preparation for pre-training

Hi,
I want to try imagenet21k pretraining. Could you please tell me how to process the raw data of imagenet21k?

Hi @mxjecho,
Thanks for your message.
You mean which data augmentation used?
Best,
Hugo

No, I want to know if I need to do pre-processing on the dataset. I use the winter21 imagenet 21k dataset.

We didn't do any particular preprocessing, we re-use the version we have internally of the dataset which should corresponds to the official version of the ImageNet dataset

Get it. BTW, what is the 'num_class' of Imagenet 21k?

21844 if I'm not wrong


[VL]Doc: How to prioritize loading Gluten jars in Spark

What changes were proposed in this pull request?

Remove df.describe() limitation
Refine parquet write limitation.
How to prioritize loading Gluten jars in Spark

How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@winningsix

@JkSelf there's a small conflict, can you please do a rebase?

@zhouyuan @zhztheplayer @jinchengchenghh Please help to review. Thanks.

I wonder if any way could prioritize loading Gluten jars in current UT framework?

It depends on the maven artifacts order in module pom.xml @Yohahaha

I wonder if any way could prioritize loading Gluten jars in current UT framework?
@zhouyuan Do you have any input?

It depends on the maven artifacts order in module pom.xml @Yohahaha

Could you explain more about it? and maybe an example would make sense, thanks! @jinchengchenghh
I try to adjust pom.xml but do not work as expected.


fetch_historical_prices_by_epic issue

hi all, I am trying to use fetch_historical_prices_by_epic:
tickerPrice = ig_service.fetch_historical_prices_by_epic(epic1, start_date="2020-12-7", end_date="2020-12-8")
i have this error:
unauthorised.access.to.equity.exception
not sure why?

You're referencing an epic that your account type does not have access to. Is it a crypto by any chance?

hi RRMXkun, it is Z1P, australia stock, epic is "AB.D.ZMLAU.CASH.IP"
my IG account is in AUD, I should be able to?

@jackyclever remember to switch_account if you have more than one account type. Sometimes IG will pick the wrong account type by default.

@RRMXkun I am a little confused that I cannot request data of an American stock with my standard CFD account (e.g. UC.D.NFLX.CASH.IP). Is this a normal behavior? Do you know if I can sign up any membership with IG to get this data as well?

@RRMXkun I am a little confused that I cannot request data of an American stock with my standard CFD account (e.g. UC.D.NFLX.CASH.IP). Is this a normal behavior? Do you know if I can sign up any membership with IG to get this data as well?

I have tried with my account: if I use my CFD account I get the same error. If I use my Spread Bet account I get the prices just fine. One for IG I'm afraid.


Apparent issue with focusing the editor when using functional component

Do you want to request a feature or report a bug?
bug
What is the current behavior?
when using
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
demo
using draft in a functional component, use and outside button to change inline style.
this works but does not refocus the editor.
using a ref, I came up with two solutions:

call ref.current.focus() onclick after the style change:
refocuses but does not change the style.
call it in useLayoutEffect /useEffect on editorState change:
seems to generally work, with minor bug: if you set the style before writing anything the button won't remove it.
however once you start writing this should be ok.
also there seem to be other issues sometimes when adding, removing and combining inline styles, block styles seem to be fine, presumably because they are mutually exclusive.
this also makes it impossible to focus out, if #2804  is correct than it's because onChange is triggered on focus change

What is the expected behavior?
hopefully style change functions should refocus the editor (as I think they do in class components but I may be mistaken) or at least fix what causes the bug in option 2.
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
I'm working on Windows, Chrome, latest draft-js.

https://dev.to/rose/draft-js-introduction-custom-styles-highlighted-text-and-have-formatting-buttons-show-whether-they-are-on-or-off-4f9p
refer to this blog series it might be helpful.

https://dev.to/rose/draft-js-introduction-custom-styles-highlighted-text-and-have-formatting-buttons-show-whether-they-are-on-or-off-4f9p
refer to this blog series it might be helpful.

thanks for the offer, it seems useful and I'll be sure to dive into it, but on a quick scan the term "focus" is not mentioned.

thanks for the offer, it seems useful and I'll be sure to dive into it, but on a quick scan the term "focus" is not mentioned.

https://dev.to/rose/rich-text-editing-on-the-web-getting-started-with-draft-js-2f68
However, the first page did contain the word 'blur', and it solved my problem.
thanks!

https://dev.to/rose/rich-text-editing-on-the-web-getting-started-with-draft-js-2f68
However, the first page did contain the word 'blur', and it solved my problem.
thanks!


Added example for Docker With Windows

I added an example to show how to use Millipng with a docker ran using the Windows CMD, which is as simple as changing $PWD to %cd%
Along with this, I also decided to clean up the formatting a bit!

Thanks for contributing, it is merged now.


Thanksgiving turkey is inexplicably no longer on the menu

🔎 Search Terms
turkey, thanksgiving, leftovers, gobble, reggie, jake, sans, papyrus
🕗 Version & Regression Information

This is a crash
This changed between versions turkey.0 and pizza.0
This changed in commit or PR free-birds
This is the behavior in every version I tried, and I reviewed the FAQ for entries about going back in time to the first Thanksgiving to get turkeys off the menu
I was unable to test this on prior versions because the Great Turkey tried to kick my butt

⏯ Playground Link
The turkey ate it.
💻 Code
// the turkey ate the code that was here

🙁 Actual behavior
Turkeys are not on the menu.
🙂 Expected behavior
Turkeys should be on the menu.
Additional information about the issue
I think two weird turkeys named Jake and Reggie went back in time to the first Thanksgiving to get turkey off the menu.  That’s right—they went back in time to the first Thanksgiving to get turkey off the menu.
…and that’s terrible.

Not a real TypeScript bug, obviously.  I just wanted to have some fun. 😅

Is this a reference to a classic holiday film I haven’t seen?

I don’t know if I’d go so far as “classic”, but yes: Free Birds.


export 'ViewPropTypes' (imported as 'ViewPropTypes') was not found in 'react-native-web/dist/index' (possible exports: AccessibilityInfo, ActivityIndicator, Alert, Animated, AppRegistr

Kindly provide code snippet that is causing the error.


Specify id to be null for arrow functions.

Q
A

Bug fix?
no

Breaking change?
no

New feature?
no

Deprecations?
no

Spec compliancy?
yes

Tests added/pass?
no

Fixed tickets
#747

License
MIT

The ArrowFunctionExpression section of the AST specification should probably clarify that supplying an Identifier for id does nothing, by explicitly saying id: null. Of course, we don't need to change babel-generator or babel-types to accommodate this change, because that would only hurt backwards compatibility.
Thanks,
Eli

We moved babylon back into the monorepo at https://github.com/babel/babel/tree/master/packages/babylon.
Unfortunately pull requests cannot be migrated between repositories automatically. If this PR is still valid please reopen it there.
Thanks for your effort.


doc: improve README to provide context on tutorial/walkthrough

feedback from @glasnt
Looking at the readme, I see I can either read the quickstart or launch the interactive walkthrough.
Quickstart: github.com/GoogleCloudPlatform/emblem/blob/main/docs/tutorials/setup-quickstart.md
Has a button to launch Cloud Shell
Walkthrough: github.com/GoogleCloudPlatform/emblem/blob/main/docs/tutorials/setup-walkthrough.md
IS the walkthrough.
Has the <walkthrough-..>tags.
These files looks like they're duplicates of each other; Is this intentional?

Resolved by #679 - root README will be the centralized location of 'Getting Started'


[WIP] Webpack to rollup

Hi, @DanielCoulbourne
The PR is the follow up of https://github.com/tightenco/ziggy/issues/184

Remove webpack and add rollup
Upgrade babel to 7
Source code is untouched
The dist files should work in browser and module environment as before

Still have IE 11 support as before

The dev dependencies size has been reduced to 23 MB (63 MB previously)
Loose ability to use ES6 syntax in tests

@bradlc
Please check the outfile file size now.
I am new to rollup, (just learned today), happy to hear recommendation.

Thanks for taking a look at this @ankurk91
From my perspective the main goal of moving to Microbundle or a custom Rollup build would be to reduce the final bundle size. Unless I’m reading it wrong (I might be) it looks like the bundle produced by this setup is pretty much the same size as the current one.
In contrast, Microbundle produces a bundle that is 38% smaller than the current one. I recommended Microbundle because it has already done the hard work of setting up an optimized Rollup config, and means you only have to maintain a single dependency. I personally don’t think it matters that the total dependency size is larger.
If you are against using Microbundle then that’s cool, but there might be some Rollup nuggets in that repo that might help get your bundle size down.

microbundle is using less popular buble instead of Babel.
microbundle is using terser instead of  UglifyJS
I notice that bundle size goes to from 12 KB to 7.77 KB  when switching from Babel to buble.
But also; it does not include the polyfills for older browsers and thats what was consuming the remaining size.
I am not confident to go with both of these. Specially buble.
You can purpose your solution (microbundle) in a PR and lets see what @DanielCoulbourne says.


python311Packages.python-homewizard-energy: 2.1.0 -> 2.1.0

Diff: https://github.com/DCSBL/python-homewizard-energy/compare/refs/tags/v2.1.0...v2.1.0
Changelog: https://github.com/DCSBL/python-homewizard-energy/releases/tag/v2.1.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 254395 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.homewizard
python310Packages.python-homewizard-energy
python310Packages.python-homewizard-energy.dist
python311Packages.python-homewizard-energy
python311Packages.python-homewizard-energy.dist


Improve UX on page loading: log in state takes seconds to load, no indication after click link that page is loading until it suddenly appears

I'm seeing that it can take a few seconds for the site to realize you're logged in, and in that time, you can click the sign in button. It's also bad UX that you can click a link and it seems like nothing is loading, then seconds later you're suddenly on a different page.

same as with #17


Issue / question— No suggestions / word overlap

Hi neilsustc, I've discovered / though of (yet another) something else to bug you with. Hope you don't mind.
Issue (unrelated to background)
However I've noticed that only previously typed words come up as suggested, and in a blank document only snippets come up, the extension doesn't appear to be working and I'm not sure why. Let me know what information would be helpful.
Background (related to question)
After that rather nice demo you had in your reply to my last question, and learning of stenography I've discovered to my delight that I can use text suggestions to halve the number of characters I need to type for long words, for example:

Question (related to background)
Due to my great discovery, I'm considering dumping a large wordlist into my user dictionary

Will this have a big performance impact if the size is ~50k?
Will this cause duplicate entries with if words are also in the default dictionary?

For the issue: Did you set the leastNumOfChars but forget it? 😂
For the question: I guess there won't be big performance impact.
As for duplicated words, the answer was yes. But it is no if you download the development build now. (click the "build passing" from the readme) 😅

Then could you please check whether there is any error in the dev console (menu>help>toggle dev tools)?
Another one is to check the editor.quickSuggestions setting.
You can execute "trigger suggestions" in the command palette to see whether words completion can be triggered.

Weird. Is there other error before this "command not found"? And you are using the dev build, right?

Ah, those errors are from the current workshop published version. Would you like me to install the dev build and try again?

I've installed the .visx you mentioned. Still having this issue.

 This extension is not activated.
I opened a LaTeX document and find this log from the extension host
[2018-10-18 11:58:42.305] [exthost] [info] ExtensionService#_doActivateExtension yzhang.dictionary-completion {"startup":false,"activationEvent":"onLanguage:latex"}

However, I cannot find this kind of log in your log (by searching yzhang)
It seems that we are close to the reason. Could you test it with a html/markdown/latex file. This extension doesn't activate on plaintext file.

Can command palette "trigger suggestions" bring up the completions in this file?

Same result

Doing now, just wanted to add — I really appreciate the amount of effort you are going to with this 🙂

Success! And embarrassment (sorry)

Few things I'd like to note.

No notifications came up

I was embarrassed to remember that I have min-letters set to 2

But I also had it not work when I types test and propted for suggestions, so…?

Also, is there a setting to make it so suggestions come up without ctrl+space?

No notifications came up

Weird if you have installed the debug build. There should be messages unless it fails to activate...

I was embarrassed to remember that I have min-letters set to 2

Very common 😄

But I also had it not work when I types test and propted for suggestions, so…?

😵

Also, is there a setting to make it so suggestions come up without ctrl+space?

To my knowledge, the only related setting is editor.quickSuggestions as noted in the readme

And don't forget language specific settings and workspace settings.

For installing the debug build this is what I did.

Uninstall extension, reload vs code
Download file, extract .visx
Run code --install-extension <path to file>

Okay, let's forget about the debug build since the word completions are back 😅

Sounds good to me :)


Bump-up Go version to 1.16 on CI

Bump-up Go version to 1.16 on CI

Done in https://github.com/RedHatInsights/insights-operator-web-ui/pull/138


Expand pytest test suite

An expanded pytest test suite covers the new functionalities added in Phase 2 and replaces the tests that use JSON files with tests that use NetCDF data.
Tests use data from the Data repository (https://github.com/earth-system-radiation/rrtmgp-data) as much as possible.

Related to #69 and https://github.com/earth-system-radiation/pyRTE-RRTMGP/pull/52.


refactor agent create function

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

simple refactor
consolidate repeated logic
simplifying conditional

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
Additional context
Add any other context or screenshots about the PR here.

retest please

@cpacker this is such a simple change, why does the tests complain about keys and other configs? What can I do to move this forward?


Need way to pass chrome arguments

In particular our development mode of testing requires --user-data-dir= for sharing an authenticated user's cookie and --disable-web-security= to allow cross-site usage of such cookie.
This line seems to not allow any user-specified arguments:
https://github.com/quickstrom/quickstrom/blob/0145b7be7036d5330f9aa941be58145f11cc4511/runner/src/Quickstrom/WebDriver/WebDriverW3C.hs#L161

Related: #21

Right, would a command-line parameter for passing additional args work? Would you be interested in submitting a PR? I'm thinking something like adding them to a Set first, and then creating the JSON.Array from that.

Yea that would work. I'll give a go at creating the PR. Thanks.

This is complete as of #60 being merged.

This is complete as of #60 being merged.


[Internal] [Bug] FTP 550 Error for Submission

What is the Bug Related To? Please Provide a Description.
Receiving a FTP 500 error when updating submission for any database. The issue is that during initial submission, the results directory server side is named "Production" or "Test", but update submission is looking for "prod" or "test".
Place an :x: in a Box that Best Matches the Bug's Importance:

[X] 1 - Most severe (a full-break in core function)
[] 2-4 - Moderate (break for a particular aspect/feature) (how integral is the broken feature?)
[] 5 - Least severe (non-functional issue, such as inconsitency / error in documentation or administrative in nature)

Please Complete the Following Information:

OS: [e.g. iOS]:
Browser [e.g. chrome, safari]:
Version [e.g. 22]:
Run environment (container, cloud service, HPC, platform, etc.):

Please Outline Necessary Steps to Replicate Bug (Go to.. Click on... Install the following... etc.):
N/A
Any Additional Context or Information? Has There Been Any Progress Made So Far Towards this Request? Any Concrete Instructions to Resolve the Bug or Helpful Resources to Reference? Screenshots or Logs?
N/A

Merged into staging. Closing for cleanliness.


no such file to load -- bundler/setup When cap deploy:cold

More details,see https://gist.github.com/1509402
Details about my deploy destination server:
cat /etc/redhat-release
CentOS release 5.7 (Final)
rvm list
rvm rubies
=> ruby-1.9.2-p290 [ x86_64 ]
which bundle
/usr/local/rvm/gems/ruby-1.9.2-p290/bin/bundle
find / -name bundler
/usr/local/rvm/gems/ruby-1.9.2-p290/doc/bundler-1.0.21/rdoc/lib/bundler
/usr/local/rvm/gems/ruby-1.9.2-p290/gems/bundler-1.0.21/spec/bundler
/usr/local/rvm/gems/ruby-1.9.2-p290/gems/bundler-1.0.21/lib/bundler
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>/usr/local/rvm/src/rvm/scripts/functions/bundler
/usr/local/rvm/scripts/functions/bundler
irb
1.9.2-p290 :002 > require 'bundler'
=> true
1.9.2-p290 :003 > exit

How did you resolve this?


FilterChainMatch: Add metadata match criteria

Add connection metadata match criteria for filter chain matching.
I have a use-case involving tagging various tenant connections' dynamic metadata with some ID in a listener filter. I'd like to use that metadata as filter chain matching criteria. As far as I can tell, there's currently no way to influence filter chain matching via the dynamic metadata for a connection.
I see that https://github.com/envoyproxy/envoy/issues/18685 is opened for custom matcher extensions, but in my opinion that is overkill for what I'm trying to do and others would benefit from this change.
If this sounds like a reasonable ask, I (or someone in my group) can submit a patch.

@mattklein123 let me talk with some folks and see if I can get some resources allocated to do this the right way.


Installation Issue

Hi guys,
I'm getting the following error when I try and run your issues.py

and the msr14 db is set up:

I simply ran your installation as you have posted on GH.

from the error it looks like you didn't run.
sudo apt-get install python2.7-mysqldb
also in the code the connection string needs to be changed so it is using the correct user and database name.
db = MySQLdb.connect("localhost","yourusername","yourpassword", "DatabaseName/msr14")
and there is a bug with the sql string.
sqlQuery needs to be changed to sql

Ok working. I recommend that you update your Install to get this squared away.


Add initial session-store interface and implementation

Description
This adds a SessionStore interface that can/will be used by the proxy to provide both client-side and server-side session storage implementations.
This PR is mainly copying and pasting code without much tidy up (especially in the cookie store implementation) but does add some tests to the SessionStore using ginkgo and gomega.
I haven't implemented using the SessionStore in the proxy itself yet so this PR should make no functional changes (bar the config changes that have been made).
I will follow with a separate PR to implement the SessionStore in the main proxy.
CC @brianv0
Motivation and Context
We want to add server side sessions, see issue #138
How Has This Been Tested?
Test suite added for SessionStore to ensure cookies have correct values set and Save/Load cycle produces the same session.
I manually tested that the configuration loading changes still work, have performed full authentication flow using image built from this branch
Checklist:

[x] My change requires a change to the documentation or CHANGELOG.
[ ] I have updated the documentation/CHANGELOG accordingly.
[x] I have created a feature (non-master) branch for my PR.

This is really nice, idiomatic code :+1:
Couple of questions:

Do we need to consider protecting against race conditions on the cookie store? Or will it never be called concurrently?
you mentioned that the cookie store is mainly copy/paste - where did it originate?
Do we want to test this in some sort of staging env?

Do we need to consider protecting against race conditions on the cookie store? Or will it never be called concurrently?

It definitely can be called concurrently, but at the moment we don't protect against that at all (in master that is). I'm not sure how you could lock across multiple instances to prevent it being called concurrently for a particular user so I was planning to just leave this pretty much as is. This PR plus #148 should be functionally equivalent to the existing behaviour.
I would like to add a lockable session store implementation at some point but that will likely have to be a server side session store implementation.
The only reason this would cause a problem being called concurrently is if you are using session refreshing with the upstream provider who rotates keys (looking at OIDC here) on every refresh, then you can end up with users being logged out periodically unless you do some caching fun in front of the proxy. This has been on my mind for a while... 😅

If you check #148, the actual implementation should just be all the code (pretty much) deleted from oauth2_proxy.go and moved into pkg/sessions/cookie/session_store.go

Im planning to build an image from #148 and will deploy it somewhere for testing, maybe internally at Pusher 🤔 I'll make sure we test it for a few days and see that everything is working as expected before we merge any of this code. I would like to (long term) set up so proper acceptance/black box tests for this project though I'm not entirely sure how to test projects with UIs, will need some research doing.

I've rebased, upped the linter timeout to stop the tests timing out, added a changelog entry and started a documentation page for the session storage stuff so will need another quick review on that last two commits before merge


HTM-728 Handle the default case in SetConnectionData

Description:

Handle the default case in SetConnectionData

Testing:

Build image

Need to change to merging into OpenRedButtonProject/orb-private/unstable/204 from HTM-72


Override PreserveOnDelete if cd is not installed

--> Skips the creation of uninstall job only if Spec.PreserveOnDelete and Status.Installed are true. If the cluster deployment is not installed, overrides the PreserveOnDelete to create an uninstall job.

/ok-to-test

/lgtm

Still needing a rebase.

/lgtm


Saving context when creating multiple private keys.

Hello, I'm not sure if this is the right place to ask this but I've been using your package for a small university project where i'm generating individual private keys for new users who are joining our system. For some unknown reason i'm generating the same private key but the public key does vary. Is there something that i'm missing? Would really appreciate your help. Thanks

@iHaroon29 to better answer your question, could you provide me a little context in what you're trying to do?
Generating a public key from a previously generated private key (loaded from a serialized base64 key into a KeyGenerator) will always be unique; however, they function in the same way as any other public key.

@s0l0ist Hey, thanks for replying. So here's what i was trying to achieve, We are currently building a multi user system where each user will have a pair of private and public key. By trail and error I was able to figure out that KeyGenerator and Context were needed and more specifically it was the context that needs to be the different if I were to have different key. Is there any way i can save "context" and load it upon request? Thanks in advance.

@iHaroon29 There's no way to save a context as the library requires a new context to be initialized and used throughout many of the constructors (both Encoders, Encryptor, Decryptor, Evaluator, KeyGenerator, etc.)
If your goal is to create multiple public keys from the same private key (public, relin,and galois are all public keys), you can pass in a privateKey instance to the constructor for the KeyGenerator.


gym -  module compiled with Swift 3.1 cannot be imported in Swift 3.0

New Issue Checklist

[X ] Updated fastlane to the latest version
[X ] I have read the Contribution Guidelines

Issue Description
After moving to Xcode8.3, impossible to compile the project. I have this issue:
module compiled with Swift 3.1 cannot be imported in Swift 3.0

Using manual archive on Xcode is working.
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.4

Ruby
2.2.3

Bundler?
true

Git
git version 2.11.0 (Apple Git-81)

Installation Source
~/.rbenv/versions/2.2.3/bin/fastlane

Host
Mac OS X 10.12.4 (16E195)

Ruby Lib Dir
~/.rbenv/versions/2.2.3/lib

OpenSSL Version
OpenSSL 1.0.2j  26 Sep 2016

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.3

System Locale

Variable
Value

LANG
fr_CH.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
fastlane_version "2.18.3"
xcversion(version: "8.3")

default_platform :ios

platform :ios do
#before_all do
#   carthage(platform: "iOS", use_binaries: false)
# end

  desc "Runs all the tests"
  lane :test do
    scan
  end

  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do

    # match(type: "appstore") # more information: https://codesigning.guide
    cert
    sigh
    gym(scheme: "iOSApp",
        include_symbols: true,
        include_bitcode: true)
    pilot
  end

  desc "Deploy a new version to the App Store"
  lane :release do
    # match(type: "appstore")
    # snapshot

    gym(scheme: "iOSApp") # Build your app - more options available
    deliver(force: true)
    # frameit
  end

  # You can define as many lanes as you want

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

fastlane gems

Gem
Version
Update-Status

fastlane
2.24.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

bundler
1.13.6

CFPropertyList
2.3.5

i18n
0.8.1

minitest
5.10.1

thread_safe
0.3.6

tzinfo
1.2.3

activesupport
4.2.8

public_suffix
2.0.5

addressable
2.5.1

babosa
1.0.2

claide
1.0.1

colored
1.2

colored2
3.1.2

highline
1.7.8

commander-fastlane
4.4.4

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170223

dotenv
2.2.0

excon
0.55.0

multipart-post
2.0.0

faraday
0.11.0

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
<IP_ADDRESS>

fastimage
2.1.0

gh_inspector
1.0.3

jwt
1.5.6

little-plugger
1.1.4

multi_json
1.12.1

logging
2.2.0

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

hurley
0.2

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.0.15

representable
2.3.0

retriable
2.1.0

google-api-client
0.9.28

json
2.0.3

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.2.0

rubyzip
1.2.1

security
0.1.3

slack-notifier
1.5.1

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

tty-screen
0.5.0

word_wrap
1.0.0

nanaimo
0.2.3

xcodeproj
1.4.3

rouge
1.11.1

xcpretty
0.2.6

xcpretty-travis-formatter
0.0.4

xcode-install
2.1.1

generated on: 2017-04-01

@yageek can you try cleaning out your derrived data? or setting an explicit value to gym - so it does not reuse any older files?
like:
gym(derived_data_path: "some_temp_folder")

let me know if this helps.

After cleaning the DerivedData I have the same error. The same by specifying a temporary directory.

@yageek do you have any 3rd party binary framework in your project which may be compiled 3.0?
also make sure that all of your targets, have the same swift version set

I checked every dependencies and they all have the same SWIT_VERSION.
I tried also by using a .xcconfig to specify the swift version for the whole project and force the version to 3.0.1 and I have the same issue.

@yageek
Do you have multiple versions of Xcode installed by any chance?
What's the output of xcodebuild -version and swift --version when you run these commands in terminal?
We had similar issue with 2.3 to 3.0 migration.
But in our case, the issue was happening during Xcode archiving phase, not while compiling and linking the app. We would first build the app with 2.3 and then would try to package it with Swift 3.0 standard libraries.
Another possible reason is that you have a 3rd party framework/cocoapod which is pre-built and is distributed as a binary. Anything like that? Then Xcode would have to link binaries built with 3.0 and 3.1 together, which wouldn't work and may explain your error message. 3.0 and 3.1 are source compatible, but not ABI compatible.
In any case, I find that it helps to provide an exact toolchain name to gym command. This way you are 100% sure that both building and archiving the app are using same toolchain. Specifying nil is same as specifying default keychain.
gym(
 ...
  toochain: nil
)

I may have missed, but are you using gym to build the project?

I updated both fastlane and Xcode (fastlane 2.37.0 and Xcode 8.3.3 and everything is working now.


Is maven plugin threadsafe?

Hi,
is the maven plugin threadsafe and does the plugin just miss the @Threadsafe annotation?
When building with maven parallel builder (e.g. "mvn -T 1C install") I get this warning:
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in jersey-core-common:
[WARNING] com.sun.istack:istack-commons-maven-plugin:3.0.8
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************

fixed by #62


Add support for FP8 in benchmark

Allows to run benchmark_throughput.py with FP8 precision

@mgawarkiewicz @kzawora-intel please review


Unable to build.

error C:\xampp\htdocs\enso\client\node_modules\postinstall-postinstall: Command failed.
Exit code: 1
Command: node ./run.js
Arguments:
Directory: C:\xampp\htdocs\enso\client\node_modules\postinstall-postinstall
Output:
ERROR Failed to apply patch for package bulma-rtl
This happened because the patch file patches\bulma-rtl+0.7.1.patch could not be parsed.
If you just upgraded patch-package, you can try running:
cd patches\bulma-rtl+0.7.1.patc
patch -p1 -i h
npx patch-package bulma-rtl
cd ../..

Otherwise, try manually creating the patch file again.
If the problem persists, please submit a bug report:
https://github.com/ds300/patch-package/issues/new?title=Patch+file+parse+error&body=%3CPlease+attach+the

+patch+file+in+question%3E
error Command failed with exit code 1.
child_process.js:669
throw err;
^
Error: Command failed: yarn run postinstall
ERROR Failed to apply patch for package bulma-rtl
This happened because the patch file patches\bulma-rtl+0.7.1.patch could not be parsed.
If you just upgraded patch-package, you can try running:
cd patches\bulma-rtl+0.7.1.patc
patch -p1 -i h
npx patch-package bulma-rtl
cd ../..

Otherwise, try manually creating the patch file again.
If the problem persists, please submit a bug report:
https://github.com/ds300/patch-package/issues/new?title=Patch+file+parse+error&body=%3CPlease+attach+the

+patch+file+in+question%3E
error Command failed with exit code 1.
at checkExecSyncError (child_process.js:630:11)
at execSync (child_process.js:666:15)
at Object.<anonymous> (C:\xampp\htdocs\enso\client\node_modules\postinstall-postinstall\run.js:15:5)
at Module._compile (internal/modules/cjs/loader.js:1138:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
at Module.load (internal/modules/cjs/loader.js:986:32)
at Function.Module._load (internal/modules/cjs/loader.js:879:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
at internal/main/run_main_module.js:17:47 {

status: 1,
signal: null,
output: [
null,
<Buffer 79 61 72 6e 20 72 75 6e 20 76 31 2e 32 32 2e 34 0a 24 20 6f 70 65 6e 63 6f 6c 6c 65 63 74 69 76
65 2d 70 6f 73 74 69 6e 73 74 61 6c 6c 20 26 26 20 70 ... 356 more bytes>,
<Buffer 0a 2a 2a 45 52 52 4f 52 2a 2a 20 46 61 69 6c 65 64 20 74 6f 20 61 70 70 6c 79 20 70 61 74 63 68
20 66 6f 72 20 70 61 63 6b 61 67 65 20 62 75 6c 6d 61 ... 565 more bytes>
],
pid: 16332,
stdout: <Buffer 79 61 72 6e 20 72 75 6e 20 76 31 2e 32 32 2e 34 0a 24 20 6f 70 65 6e 63 6f 6c 6c 65 63 74
69 76 65 2d 70 6f 73 74 69 6e 73 74 61 6c 6c 20 26 26 20 70 ... 356 more bytes>,
I tried the commands shown in the error but was unable to fix. Could someone guide me how do I fix this.
Thank You

See my issue for building on Windows. The patch file can be fixed by opening it then deleting the empty line and saving.

@curtisdelicata I did edit patches\bulma-rtl+0.7.1.patch file and removed the last empty line

Enven tried to clear the cache using yarn cache clean but the issue remains the same.

@shah-aadil when I had this issue when I was making my Enso based project. I just had to save again in PHP Storm and it seemed to convert it. I don't know why this patch has issues, as when I created my own patch for branding with patch-package it works on Windows and Linux fine.


Kiam is not working. AWS provider.

Kiam is not working. AWS provider.
ESO is not able to assume role provided in SecretStore.spec.provider.aws.role.
v0.3.10
Examples of the outcome
"controllers.ExternalSecret","msg":"could not reconcile ExternalSecret","ExternalSecret":"******","SecretStore":"*****","error":"could not get secret data from provider: key \"external-secret-operator\" from ExternalSecret \"poc-key\": NoCredentialProviders: no valid providers in chain. Deprecated.

apiVersion: external-secrets.io/v1alpha1
kind: SecretStore
metadata:
  name: secretstore-papp-dev
spec:
  controller: dev
  provider:
    aws:
      service: SecretsManager
      role: arn:aws:iam::*******:role/*****
      region: eu-west-1

Observations (Constraints, Context, etc):
When I added Kiam annotation directly to the pod I received this error:
could not reconcile ExternalSecret","ExternalSecret":"poc-key","SecretStore":"*****","error":"could not get secret data from provider: key \"external-secret-operator\" from ExternalSecret \"poc-key\": AccessDenied: User: arn:aws:sts::****:assumed-role/****/kiam-kiam is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::*******:role/*******\n\tstatus code: 403,

spec:
  template:
    metadata:
      annotations:
        iam.amazonaws.com/role: arn:aws:iam::*****:role/*****

It will be good to have Kiam configuration part documented somewhere.

on hold for now

Have you tried adding the annotation and leaving the provider.aws.role blank?
From the error message above i see that the ESO pod already acquired credentials via kiam:
User: arn:aws:sts::****:assumed-role/****/kiam-kiam is not authorized to perform: sts:AssumeRole

If the role has the proper SSM/SM policy set everything should work i suppose.

After further investigation -  ESO works fine with Kiam, but it needs some additional configuration.
This is my resolution:

Create a role  with AssumeRole allowed policy.
policy example

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "sts:AssumeRole"
            ],
            "Resource": [
                "*"
            ]
        }
    ]
}

Attach this role to ESO deployment. It can be done by putting these lines directly to manifest or with podAnnotations helm values block.

spec:
  template:
    metadata:
      annotations:
        iam.amazonaws.com/role: arn:aws:iam::*****:role/<role-with-assume-permissions>

After it ESO will be able to assume role which was described in SecretStore.spec.provider.aws.role

Thanks for documenting this!


Add data test

Please review carefully, i put some id's in places im not sure are ok

Fix the requested changes
Resolve the conflicts
Remove package-lock.json from the repository

Fix the requested changes
Resolve the conflicts
Remove package-lock.json from the repository


Don't reload preview when new lines arrive

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[x] fish

Currently, when using fzf to view the output lines of a long-running command, the preview command is re-ran when new lines arrive from that command (and the scroll is lost).
Try, for instance:
seq 1000000 | pv -qL 20 | fzf --preview="seq 1 10000"

And try scrolling.

Thanks for the report, fixed it.


Remove executable bit from test & example data files.

The lintian QA tool reported that several data files used for tests have the executable bit set.
This PR fixes the permissions for test & example data.

We have to move this upstream to libpysal.

Thanks for this. Will include in the 6-month release.


[ISSUE #4103] Simplify string-list-join in Message

Make sure set the target branch to develop
What is the purpose of the change
#4103
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4104 (d652cd4) into develop (fd554ab) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4104      +/-   ##
=============================================
- Coverage      47.91%   47.75%   -0.17%
+ Complexity      5001     4980      -21
=============================================
  Files            634      634
  Lines          42529    42525       -4
  Branches        5573     5572       -1
=============================================
- Hits           20377    20307      -70
- Misses         19651    19720      +69
+ Partials        2501     2498       -3

Impacted Files
Coverage Δ

...va/org/apache/rocketmq/common/message/Message.java
56.96% <0.00%> (+2.74%)
:arrow_up:

...in/java/org/apache/rocketmq/test/util/MQAdmin.java
38.88% <0.00%> (-5.56%)
:arrow_down:

...e/rocketmq/client/impl/consumer/RebalanceImpl.java
40.23% <0.00%> (-4.30%)
:arrow_down:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
46.83% <0.00%> (-3.53%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
41.05% <0.00%> (-2.99%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

...va/org/apache/rocketmq/logging/inner/Appender.java
34.83% <0.00%> (-2.25%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
77.72% <0.00%> (-1.99%)
:arrow_down:

...rocketmq/client/impl/factory/MQClientInstance.java
49.31% <0.00%> (-1.98%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd554ab...d652cd4. Read the comment docs.

Coverage decreased (-0.2%) to 51.8% when pulling d652cd47f2609ed4b28bb545b1183fe750c8cc57 on dugenkui03:patch-8 into fd554ab12072225325c957ff6bdf492fc67821af on apache:develop.

Coverage decreased (-0.2%) to 51.8% when pulling d652cd47f2609ed4b28bb545b1183fe750c8cc57 on dugenkui03:patch-8 into fd554ab12072225325c957ff6bdf492fc67821af on apache:develop.


layers: Use the new VUL safe struct code

CI Vulkan-ExtensionLayer build queued with queue ID 153248.

CI Vulkan-ExtensionLayer build queued with queue ID 153257.

CI Vulkan-ExtensionLayer build # 879 running.

CI Vulkan-ExtensionLayer build # 879 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 155258.

CI Vulkan-ExtensionLayer build # 881 running.

CI Vulkan-ExtensionLayer build # 881 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 156824.

CI Vulkan-ExtensionLayer build # 884 running.

CI Vulkan-ExtensionLayer build queued with queue ID 157013.

CI Vulkan-ExtensionLayer build # 885 running.

CI Vulkan-ExtensionLayer build # 885 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 157046.

CI Vulkan-ExtensionLayer build # 886 running.

CI Vulkan-ExtensionLayer build # 886 passed.

CI Vulkan-ExtensionLayer build queued with queue ID 157058.

CI Vulkan-ExtensionLayer build # 887 running.

CI Vulkan-ExtensionLayer build # 887 passed.

CI Vulkan-ExtensionLayer build # 884 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 158899.

CI Vulkan-ExtensionLayer build # 891 running.

CI Vulkan-ExtensionLayer build queued with queue ID 158924.

CI Vulkan-ExtensionLayer build # 892 running.

CI Vulkan-ExtensionLayer build # 892 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 158947.

CI Vulkan-ExtensionLayer build # 893 running.

CI Vulkan-ExtensionLayer build # 893 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 159026.

CI Vulkan-ExtensionLayer build # 894 running.

CI Vulkan-ExtensionLayer build # 894 passed.

CI Vulkan-ExtensionLayer build # 895 running.

CI Vulkan-ExtensionLayer build # 895 failed.

CI Vulkan-ExtensionLayer build queued with queue ID 159071.

CI Vulkan-ExtensionLayer build # 896 running.


Allow different (lon, lat, depth, time) grids for each Field in Grid.from_data construction

While Parcels support different longitude and latitude grids for U and V fields, currently they have to have the same depth and time when calling the Grid.from_data() method. Furthermore, extra_fields take lonU and latV as their longitude and latitude.
While of course all of these dimensions can be changed by going into the Fields themselves, it would be much more intuitive to specify the grid of each Field directly in the Grid construction
(as a side-note, this Issue also relates to #172, about possibly renaming the Grid class to FieldSet or something similar. Since the Fields in a Grid object don't need to live on the same grid, the naming of that class is quite confusing)

Fixed in #184


Bump eth-abi to 4.1.0 and eth-account to 0.10.0

Goal is to resolve a few open issues and also support development in python 3.11+
Issues

https://github.com/hyperliquid-dex/hyperliquid-python-sdk/issues/50
https://github.com/hyperliquid-dex/hyperliquid-python-sdk/issues/18
https://github.com/hyperliquid-dex/hyperliquid-python-sdk/issues/53

Upgrade release notes for dependencies:

https://eth-account.readthedocs.io/en/stable/release_notes.html: in 0.9.0 support 3.11+
https://eth-abi.readthedocs.io/en/latest/release_notes.html

I tested this out both in my development environment and in a 3.8 venv and seems to work fine. Thanks for doing this update. Do you mind rebasing to fix the poetry.lock merge conflict and then I'll approve and merge


Json bundle cannot validate in HAPI test server

Describe the bug
Error messages on HAPI test server when trying to validate json-bundle gererated by ODMtoFHIR
To Reproduce
Steps to reproduce the behavior:

Go to '...'

in Postman
add json file as body

Send

Expected behavior
Status 201 created
Screenshots
Status 412
Error Messages:
        {             "severity": "error",             "code": "processing",             "diagnostics": "bdl-7: FullUrl must be unique in a bundle, or else entries with the same fullUrl must have different meta.versionId (except in history bundles) [(type = 'history') or entry.where(fullUrl.exists()).select(fullUrl & resource.meta.versionId).isDistinct()]",             "location": [                 "Bundle",                 "Line 1, Col 2"             ]         }
Desktop (please complete the following information):

OS: Win 10
Browser Firefox

@pdi-uk: Can you perhaps provide us with the input ODM that provokes this error? From the provided error message it looks like you might tried to send the output of a single ODM2FHIR run several times to your FHIR server (as we currently generate a new, unique UUID for each resource during each run of ODM2FHIR).

@pdi-uk: Can you perhaps provide us with the input ODM that provokes this error? From the provided error message it looks like you might tried to send the output of a single ODM2FHIR run several times to your FHIR server (as we currently generate a new, unique UUID for each resource during each run of ODM2FHIR).

The ODM2FHIR app already has a built-in HAPI FHIR validator, which ensures that invalid FHIR resources are not added to the bundle.
When testing the method you described above with our dummy data output, the online validator only delivers errors/warnings of the following types:

Processing warning:
multiple warning regarding resource-properties that SHALL be filled (according to the default FHIR-Profile of this type, but not according to the NUM-Profile)
Processing Error:
unresolvable NUM-Profiles (therefore unchecked) and supposedly nonexistent codes (e.g. LOINC#19817-6 which does exist)

I cannot reproduce the error you described. So it would be good to get a copy of your input-ODM, as @holger-stenzhorn already said.

The ODM2FHIR app already has a built-in HAPI FHIR validator, which ensures that invalid FHIR resources are not added to the bundle.
When testing the method you described above with our dummy data output, the online validator only delivers errors/warnings of the following types:

Processing warning:
multiple warning regarding resource-properties that SHALL be filled (according to the default FHIR-Profile of this type, but not according to the NUM-Profile)
Processing Error:
unresolvable NUM-Profiles (therefore unchecked) and supposedly nonexistent codes (e.g. LOINC#19817-6 which does exist)

I cannot reproduce the error you described. So it would be good to get a copy of your input-ODM, as @holger-stenzhorn already said.

this is our input ODM:
TestGECCO_CDISC_ODM_2020-12-10_1140t.txt

this is our input ODM:
TestGECCO_CDISC_ODM_2020-12-10_1140t.txt

Thanks! I will check the problem and come back to you tomorrow.

Thanks! I will check the problem and come back to you tomorrow.

@pdi-uk Admittedly, this does not really concern your reported issue but still... :-) Which version of the data dictionary did you actually import into REDCap to create the instruments in there? It looks like you used the quite outdated one from 23.10.2020 which sadly does not work correctly with the recent ODM2FHIR. ...or did you just accidentally provide here an ancient export from 10.12.2020 and you have a more recent one based on the data dictionary from 13.11.2020 or (even better) 11.12.2020?

@pdi-uk Admittedly, this does not really concern your reported issue but still... :-) Which version of the data dictionary did you actually import into REDCap to create the instruments in there? It looks like you used the quite outdated one from 23.10.2020 which sadly does not work correctly with the recent ODM2FHIR. ...or did you just accidentally provide here an ancient export from 10.12.2020 and you have a more recent one based on the data dictionary from 13.11.2020 or (even better) 11.12.2020?

The version information of the data dictionary is lost in RedCap after uploading, but I think we used the data dictionary from 13.11.2020. However, we will try again with the newest version of the data dictionary.

The version information of the data dictionary is lost in RedCap after uploading, but I think we used the data dictionary from 13.11.2020. However, we will try again with the newest version of the data dictionary.

You have to remember that if you update the data dictionary, the already filled in forms WILL NOT BE UPDATED!
Changes can therefore only be determined in the forms edited afterwards.

You have to remember that if you update the data dictionary, the already filled in forms WILL NOT BE UPDATED!
Changes can therefore only be determined in the forms edited afterwards.

We updated the data dictionary and created a new sample patient. The error mentionted above does not appear any more when trying to validate the bundle.

We updated the data dictionary and created a new sample patient. The error mentionted above does not appear any more when trying to validate the bundle.

Okay, thats good!
I will close the issue as it's solved.

Okay, thats good!
I will close the issue as it's solved.


Features/methodtests

Unit testing for methods

https://gist.github.com/luismts/495d982e8c5b1a0ced4a57cf3d93cf60

And all of your commits can be squashed. The first 5 should be squashed into one commit appropriately named Add unit tests for HTTP methods.
Last commit could potentially be named Rebase onto main


Lego model transparent covers are too opaque

Perhaps because they're double sided? Maybe opaque objects should be rendered as single sided?

Likely due to brightness of the environment.


Graph of measured values

As a user, I want to see a simple graph of training progress when in detail view

Data can be collected using the Metrics API:
https://github.com/chovanecm/sacred/blob/feature/data-logger/docs/collected_information.rst#metrics-api

Work in progress: https://github.com/chovanecm/sacredboard/tree/feature/plot-metrics

Scenario:

The user indicates he wants to see the progress of a specific metric or metrics.
The system responds with a list of available metrics
The user selects the metrics he wants to plot
The system plots the selected metrics with x-axis as the step and y-axis as value.

Alternate scenarios:

In step 3., the user chooses to set the x-axis as time instead of step number.
1.1 The system draws the selected metrics with date-based x axis.


[FEATURE] Auto-update github if username changes.

Description
A api or something to have a look every 10 minutes if the github username exists, if it doesn't create a issue thread and a PR fixing the issue thread, updating the github avatar url and github url, according to new username, using commit history.
Screenshots
No response
Additional information
It may be confusing coz I didn't explain well lol.

I think this could be an option, but Idk feels weird that we'd be tracking and updating people's data without asking them first.
Maybe when we switch to data stored in the API, this type of tracking can be added to the API...

I think this could be an option, but Idk feels weird that we'd be tracking and updating people's data without asking them first. Maybe when we switch to data stored in the API, this type of tracking can be added to the API...

Yeah, but the issue is, many people forget to update their pfp when the change their github username, and until 1-2 months later, its as it is, and their pfp isn't working.. If the pfp doesn't work even the profile sometimes gets messed up (see #1139 )

You can still update to your latest profile info anytime in the json file

ask them beforehand , same as facebook , just put up " we use some data "

I think usernames don't change that often, plus when we finish GitHub OAuth, it can auto update when they login, so I am going to close this issue


Feature/mixins

Ok, so I finally got around to this. I rewrote large parts of the library in the feature/mixin branch. The syntax I settled on is the following:
<Grid id="demo-content">
  <Cell id="demo-charts" width="12" mixin={grid}>
    ... SVG charts (each SVG tag is a cell)
  </Cell>
  <Card id="demo-updates" mixin={cell} cell--width="4">
    ... Card contents
  </Card>
</Grid>

The trick is, most components are now defined as mixins in the first place (exported as lowercase versions of the components). They are simple functions which transform input attributes into output attributes:
let uvalue = mixin('uvalue', function({value}) {
    this.value = value.toUpperCase();
});

Then components are created from them:
let UValue = fromMixin(uvalue, 'input');

You can call them manually as well:
let trgAttribs = {};
callMixin(uvalue, {value: 'abc'}, trgAttribs);

return <input {...trgAttribs}></input>;

Obviously this restricts the mixins to working on the attributes only. I do however think this is way more reliable then having a mixin mess with the child elements.
To allow specifying specific attributes to specific mixins you can prefix them with the mixin's name (e.g. uvalue--).
I will leave this open for a day or two and try to figure out if this is a good idea. All current prs will have to be largely rewritten to make them work with this change. I am however going to do that myself if neccessary.
Feedback welcome.

Great work!
Looks great all in all. Slightly different form my implementation, but probably more thoroughly thought. The capital letter distinction and the prefix syntax makes JSX seem seamless. I like it!

First of, thank you for the feedback :)
Secondly after messing with this branch's history like a crazy person, I think I am now happy with what is in here. Next time I will do this differently for sure (merging changes from master back in here instead of rebasing, etc. but I guess I have to learn the hard way).
I also think I killed your linecomment with regards to object based mixins. I fixed that now.
All the stuff that just went into master is also componentized and I ran some (very) rough tests with a toy project of mine to see if anything major broke.
I think I will sleep on this one more night and if nothing comes up, I will merge this tomorrow.
Then on to documentation, then tests and then I think it will be time for a proper release.


How to abstract table filtering using function?

What's up?
In my prql code base, there's something repetitive as following,
module default_db  {
type table1Type = [{x1 = text, data_date = date}]
let table1<table1Type>

type table2Type = [{x2 = text, data_date = date}]
let table2<table2Type>

 ...
}

let now = @2024-08-01

let table1_now = (
from table1
filter data_date == now
)

let table2_now = (
from table2
filter data_date == now
)

...

How could I define a well-typed function likes tableNow, which takes tableN and returns tableN_now.
I've tried but compiler complains about type and col name.

V good question. Is this what you're thinking of?
let f = tbl -> (tbl | filter data_date == @2024-08-01)

from invoices | f

SELECT
  *
FROM
  invoices
WHERE
  data_date = DATE '2024-08-01'

-- Generated by PRQL compiler version:0.13.0 (https://prql-lang.org)

Thanks. It works.


build: install required binaries in a temporary subdirectory of the project

If controller-gen or kustomize are not found, my understanding is that those binaries are downloaded and installed in $(GOBIN) which may lead to issues as it may override the version one has already downloaded:
# find or download controller-gen if necessary
controller-gen:
ifeq (, $(shell which controller-gen))
	@{ \
	set -e ;\
	CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\
	cd $$CONTROLLER_GEN_TMP_DIR ;\
	go mod init tmp ;\
	go get<EMAIL_ADDRESS>;\
	rm -rf $$CONTROLLER_GEN_TMP_DIR ;\
	}
CONTROLLER_GEN=$(GOBIN)/controller-gen
else
CONTROLLER_GEN=$(shell which controller-gen)
endif

kustomize:
ifeq (, $(shell which kustomize))
	@{ \
	set -e ;\
	KUSTOMIZE_GEN_TMP_DIR=$$(mktemp -d) ;\
	cd $$KUSTOMIZE_GEN_TMP_DIR ;\
	go mod init tmp ;\
	go get<EMAIL_ADDRESS>;\
	rm -rf $$KUSTOMIZE_GEN_TMP_DIR ;\
	}
KUSTOMIZE=$(GOBIN)/kustomize
else
KUSTOMIZE=$(shell which kustomize)
endif

I think any project specific binary should be downloaded and installed on a temporary location relative to the project root

@astefanutti what do you think ?

@lburgazzoli my understanding is that overwriting only happens when GOBIN isn't in the PATH, which I would assume to be unusual. Otherwise, the existing version is used and not overwritten. That being said, I agree it'd be better to be completely environment independent, and install the binaries in temp dir local to the project.

Ah yes, that should be how it works however I spotted the issue because my environment was non properly set up and GOBIN was non on the path for some unknown reasons so the first invocation leaded to my own controller-gen being replaced and being re-download at each make invocation.


Relay Example in Angular

Anyone get the relay example to work in angular? I'm getting tons events. I'm just having a mental block on getting them out of the onevent function to manipulate.

Like this?
let events = []

relay.subscribe(_, _, {
  onevent(event) {
    events.push(event)
  }
})

V similar to what I had to do. I could not access a component property in the code block, but I can access a var local to the calling function. set the property to the local var,  done. angular can make the simplest thing difficult.


invalid syntax error

I've placed my credentials in prod.cfg
when I run python script/spider.py --config config/prod.cfg --claimOnly I get this error:
Traceback (most recent call last):
File "script/spider.py", line 7, in
from utils import ip_address, config_file
File "/home/csllc4/packtpub-crawler/script/utils.py", line 16
print '[-] GET {0} | {1}'.format(response.status_code, response.url)
^
SyntaxError: invalid syntax

uhmm that error was from my natted virtual machine.
Tried from a VPS with public address and it's working

Hi, sorry for the late response, if is working, can I close the issue or do you have any other problem?
Thanks

you can close, I cannot reproduce the error on any other machine than this (an archlinux VM) so probably is some problem here


added missing lifecycle method 'componentDidUnload'

Fix for issue #5

Awesome!
I also noticed that componentDidUpdate is missing too, in case you also want to fix that.

@ncardeli It looks like it is already in there? https://github.com/ionic-team/stencil-eslint/blob/cc8b58c989f23b2c4384130894fd5fc1efa56ad7/src/utils.ts#L81

Sorry, you're right.
Thanks for the fix 👍

Are the maintainers of this repo active anymore? I'd like to get this merged.

Are the maintainers of this repo active anymore? I'd like to get this merged.

Me too

@manucorporat would you able to take a look at the work that @sledsworth did? This would be a great addition to the eslint plugin, if accepted

I ran into this, just commenting to be notified when it get's merged

@valadas in the future, you can click the Subscribe button on the right to get notifications for a Pull Request or Issue without having to leave a comment

@manucorporat mentioned on the stencil slack that he'd look into merging this comically small outstanding PR this weekend. 😆

After chatting with @manucorporat, it is suggested that disconnectedCallback is used instead of componentDidUnload, which will be deprecated in the future.
https://stenciljs.com/docs/component-lifecycle#disconnectedcallback


Shared - jolokiaService should resolve or reject requests in case of ajax error

Currently the operations provided by jolokiaService such as readAttribute, writeAttribute, execute, search, etc. rely on the default ajaxError callback in case of ajax error happening while performing Jolokia requests.
https://github.com/hawtio/hawtio-next/blob/50a83c44b5ce1b14dfa492388770a2d18f772178/packages/hawtio/src/plugins/shared/jolokia-service.ts#L293-L332
Since this callback is not aware of resolve or reject callback provided by each Promise that wraps a Jolokia operation, the processing of the request should hang in case of ajax error. This can happen when for some reason the remote Jolokia endpoint starts to stop serving requests, for instance due to authentication being expired or any other internal server error.
This should be actually mostly fine, because then the user would need to refresh the page or authenticate again to restore the working status anyway. So, practically we've observed no issues with it yet. However, it should be still considered well-behaved to make sure the operation terminates in such an exceptional case. That's why it's marked as enhancement.

Hmm, I was thinking about it, but maybe it should be more long term goal - including Jolokia switch to Fetch API? (jolokia/jolokia#580)...

@grgrzybek If I remember it correctly, the issue was filed right after this fix:
https://github.com/hawtio/hawtio-next/commit/4963ed332cafbb55277880ff2aea5de11a0efa4c
it already fixed the issue for the list operation. What we need to do would be to apply the similar fix to the rest of Jolokia operations. So I think it can be fixed in a short term.


Encountered a different space group variable of a VESTA cif file

crystal.jl: Added a different space group variable and a suitable test cif file that contains the sayed space group variable name.

Oh sorry, I didn't see that the CIF file was not added. And now I had to forcefully stage it.

  Believe it or not, this isn't the first time a file has gone "missing" this way 😉

Codecov Report

Merging #193 (2b3cbe4) into master (9899e9a) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   91.98%   91.98%
=======================================
  Files           8        8
  Lines         986      986
=======================================
  Hits          907      907
  Misses         79       79

Files Changed
Coverage Δ

src/crystal.jl
93.77% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@galjos Changes are live in the new registered version.  Thanks again!


Update meta.yaml

Added sirocco as a run dependency

Checklist

[X] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

As suggested, I added sirocco as a run dependency, hope it works

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Did you bump the build number?

Could you add a test that checks that sirocco actually was included? Maybe run the doctests of the sirocco.pyx file?

Once that works, we could consider adding an ignore_run_exports to not bundle sirocco and instead have a run_constrained that sets sirocco with a pin_compatible. Not sure if that's the right approach though @isuruf.

 Did you bump the build number?
Actually, not

Could you add a test that checks that sirocco actually was included? Maybe run the doctests of the sirocco.pyx file?

Actually, I do not know how to add this test

Once that works, we could consider adding an ignore_run_exports to not bundle sirocco and instead have a run_constrained that sets sirocco with a pin_compatible. Not sure if that's the right approach though @isuruf.

I closed by mistake and change from run to host, I do not know how to proceed with the other points.

I changed sirocco from run to host and now the tests do not pass. Any ideas?

The error message is

nothing provides requested sirocco

Are the dependencies of sirocco incompatible with some of the other dependencies listed here?

Could you add a test that checks that sirocco actually was included? Maybe run the doctests of the sirocco.pyx file?

Actually, I do not know how to add this test

There's this section in the reicpe:
  source_files:
    - src/sage/version.py
  imports:
    - sage
  commands:
    - sage -v
    - sage -c 1+1
    # too many doctests fail still but we test that the doctesting framework works by testing a trivial file
    - sage -tp src/sage/version.py

You should be able to add another sage -tp there. Make sure to provide the sirocco.pyx file in source_files as well.

There is the requirement section for sirocco:
build:
      - {{ compiler('c') }}
      - {{ compiler('cxx') }}
  - autoconf
  - automake
  - libtool
  - m4
  - make
host:
  - gmp
  - mpfr
run:

Possibly some build options are not essential, I could try. But the complain is about sirocco not found. New try

It complains again about sirocco not found, but it is in conda-forge, maybe some database is not updated?

I am trying to test first in my computer; I have conda installed and added forge channel, in particular sirocco is found. I clone my fork of sagelib; is there a short howto in order to test locally this fork?

This seems to be the test error: ModuleNotFoundError: No module named 'pkgconfig'

In about 2-3 hours, you'll be able to do mamba install sage sagemath-sirocco to get the sage extension that uses sirocco.

I tested in binder (I replaced in the environment.yml  the lines - sage = 9.6 and - sirocco by - sagemath-sirocco. I will update properly my repos. Thanks to Fernando @isuruf and Julian @saraedum. There were only some harmless warnings concerning some gap packages. I guess that building a sagemath-optional would be to give but it would be nice to have a way to contruct images with more than one optional packages. My python skills are not very good but if you have an idea i can collaborate.


Signal handling fix

Fix related to this issue.

Oh this is great - I hit this the other day while working on Azure and my fix was not nearly as elegant!
Nicely done :smile:


random delay on suggestions being added

When suggestions are voted for sufficiently, it takes a while for them to be added, with seemingly random pauses in-between.

upon further inspection, items on the list can also just stay up indefinitely with sufficient votes

should be fixed


Abort job with multiple files when backend fails

Hi,
there is the first shot, which gets multiple files job aborted when backend suddenly lost connection during data transfer as I wrote in email. I am lost in making such job retry - I think a recovery for retry is rather complicated - checking which file didn't print correctly and probably creating new job for the unfinished business.
This pull request is connected to issue #5359 , is it a right way to go?

I ran basic tests from project and results are good. There are expected failures (according test) and one unexpected, but without connection to the issue (4.4-subscription-ops.test failed with server-error-internal-error (Invalid group tag.))

I pushed a slightly different fix, and all tests appear to pass.
[master 72a213482] Fix stuck multi-file jobs (Issue #5359, Issue #5413)
[branch-2.2 e7e33bf64] Fix stuck multi-file jobs (Issue #5359, Issue #5413)

Thank you, Mike! I'll test it tomorrow!


Next

:tada: This PR is included in version 1.2.0-beta.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.1-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[#156168463] Remove the 'home' module

What
This has been a starting point for the application to get moving around.
As the application grew, we no longer need it to exist nor do we want it
to be presented to our users.
We took the approach of redirecting the root URL to /organisations
endpoint, as this would be ideally a starting point for the user.
The redirection is and should be a temporary solution, for we need to
implement the router system that would fix the routes in general.
How to review

Code review
Run tests (should be done by travis)
Run the application using rafal's environmentOAUTH_AUTHORIZATION_URL="https://login.rafalp.dev.cloudpipeline.digital/oauth/authorize" OAUTH_TOKEN_URL="https://uaa.rafalp.dev.cloudpipeline.digital/oauth/token" OAUTH_CLIENT_ID="rafal-login" OAUTH_CLIENT_SECRET="secret" API_URL="https://api.rafalp.dev.cloudpipeline.digital" UAA_URL="https://uaa.rafalp.dev.cloudpipeline.digital" NOTIFY_API_KEY="not-important-for-that-story" npm start

See if by visiting the http://localhost:3000/ you're redirected correctly to organisations page

:bee: Depending on #24 one or the other may need to be rebased. Both are changing app.js.

:airhorn: conflicts :airhorn:

Rebased.


Remove "type" argument from call to opensearch.import

When running the opensearch:import:all task, I got this error:
rake aborted!
ArgumentError: unknown keyword: :type (ArgumentError)
/Users/aarestad/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/batches.rb:148:in `find_in_batches'
/Users/aarestad/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/querying.rb:23:in `find_in_batches'
/Users/aarestad/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/bundler/gems/opensearch-rails-8b0af5b21128/opensearch-model/lib/opensearch/model/proxy.rb:124:in `method_missing'
/Users/aarestad/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/bundler/gems/opensearch-rails-8b0af5b21128/opensearch-model/lib/opensearch/model/adapters/active_record.rb:105:in `__find_in_batches'
/Users/aarestad/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/bundler/gems/opensearch-rails-8b0af5b21128/opensearch-model/lib/opensearch/model/importing.rb:160:in `import'
/Users/aarestad/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/bundler/gems/opensearch-rails-8b0af5b21128/opensearch-rails/lib/opensearch/rails/tasks/import.rb:80:in `block (3 levels) in <top (required)>'
<snip>

It seems that the "type" argument being used here is being rejected by Active Record in Rails 7.1. Is it safe to simply remove the argument?

Ping - any thoughts on this? We're currently using a fork of your code with this change.


Moves 'distro_version_id' from a property on Package to an argument to Client#put_package

This is the start of a change to make the Package domain model agnostic to distributions.
The primary use case for this is to be able to upload the same Package object to multiple distributions like so:
pkg = Package.new(open('/tmp/mypkg.deb'))

client.put_package(pkg, 'ubuntu/utopic')
client.put_package(pkg, 'debian/wheezy')

As a bonus, it's now possible to lookup distributions by name, much like our command line tool.
We still handle the older case where distro_version_id is set on Package, which we'll presumably turn off in a future major version release.

Fixed here: https://github.com/computology/packagecloud-ruby/commit/992aaa5546554cecfcde17f10db8558cc3f261a2


Ability to fail fast on params validation

Correct me if I'm wrong, but currently all validators will be executed even if some of them fails during the validation process. I believe this is the corresponding code chunk, showing the nature of this behavior:
def run_validators(validators, request)
  validation_errors = []

  validators.each do |validator|
    begin
      validator.validate(request)
    rescue Grape::Exceptions::Validation => e
      validation_errors << e
    end
  end

  validation_errors.any? && raise(Grape::Exceptions::ValidationErrors, errors: validation_errors, headers: header)
end

I believe that it should be possible to instruct Grape to fail fast during the validation process.
One possible case: We need to validate that some string matches some pattern (for example it is an email) and than we need to validate if this email is in the white list. For now even if this email is malformed, it will be checked against the white list (which has no sense cause it is malformed anyway).
The DSL may look like this:
params do
  requires :email, allow_blank: false, regexp: /@/, fail_fast: true
end

I like this idea as long as we ensure the validation order.

Is this resolved now?

Yes, should probably be closed.

Closing via #1499.


Connectivity between containers on sub-nets

Rancher Version: v1.1.0-dev5/v1.1.0
Docker Version: 1.11.2
OS and where are the hosts located? (cloud, bare metal, etc): Ubuntu 16.04 on Azure
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB) Single node master, three hosts. Each host is on a separate sub-net, with all access (and UDP 500/4500 specifically) granted between sub-nets.
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Kubernetes
Steps to Reproduce: Trying to ping between network containers (or Kubernetes containers) on each host.
Results: Other containers are unreachable.
Expected: Containers should be able to reach each other over the Rancher network.

Hey @brandon-adams , can you access the console for the network agents. From there attempt to ping the network agents present on the other host(s). Are they able to ping?

No @aemneina, they can't ping at all. They can reach other containers on the same host, just not other hosts.

OK, turns out I should have been using local IPs instead of public facing IPs. The labeling confused me. Once I switched to local addresses, communication worked across sub-nets.