Update protocol to 1.8*

What protocol supported 1.8? and there are new update?

What you're using isn't even anywhere near English.

sorry men, i am spanish, my english is bad sorry ;(

Is the project is abandoned or being updated?

Long hiatus/better things to do/abandoned.

I don't like saying this but I'm the brother of the maintainer of this Git. He died as of a week ago when he contracted pneumonia, if any of you want to take over, drop me a message and I will pass along his private details, including the files he was working on before the illness hit.

@LefsFlare: I'm interested in taking over this project. I have extensive experience with software development, a high reputation Stack Overflow profile, and here's my CV.. You can get in touch with my public email listed under my GitHub profile.

@Unihedro It is fine, if you wish to take over the project but as far as my brother's wishes are to be of concerned, he would have wanted someone to update this project to the latest version, of which he didn't manage to do himself.
The biggest question, is if you would be able to do it.

I'm willing to give a hand in updating this project to 1.8. I'm the maintainer of node-minecraft-protocol and have a good understanding of how minecraft's protocol works.
I have already forked the project and am currently writing the v47x protocol backend for 1.8.
For a bit of an overview of the changes required :

Update the packet definitions so they match 1.8. This is relatively easy grunt work.
Implement the new packet header (varint CompressedLength, varint UncompressedLength) that is used after packet "SET_COMPRESSION" is received.
At this point, it will be possible to test the bot on server with compression disabled (compression-threshold=0).
Implement the new compression support. Compression is implemented using zlib's Inflate/Deflate algorithms. This will probably require some changes in SocketConnectionHandler.

Once this is all done, the bot will be updated to protocol 1.8, but that's just the start. We will still need to make sure the bot is still working, etc...

Ahem. Behave yourself, LefsFlare.  Not only did you ruin it, you effectively nulled any chance of Dark coming to this issue to rectify the issue that he is not dead.
If anyone asks why Dark is not coming back despite the issues, I will happily point them to you.

DarkStorm has no obligation to maintain this project for you. Your attempts to manipulate people are completely inappropriate and childish.

@roblabla let me know if you need help

@squires I don't think I am attempting to manipulate Dark to maintain this project. The only thing I and to that extend, every one of us want, is simply an answer from him. Whether be it a line claiming he does not want to work on the project anymore or that he was away on an extended leave or whatever the case.
You do realize that even though he has no obligation to maintain this project for anyone, he is the only one that understands most of his own code. For anyone to continue someone else's codes is not easy. From what I see on your GitHub repository, it's clear and obvious to anyone that you obviously have not worked on a project like DarkBot or even Java.
You may find it inappropriate and childish but before you nosed your way in, what I have done clearly worked the first time around, bringing Dark back into the scene and providing comfort and relief for the close followers of this Git project.
Lastly, I am not manipulating anyone. What I did was tell a lie, to which Dark can choose to rectify or continue to leave every single one of us in the dark. Calling my attempt inappropriate and childish is very obviously, on no grounds.

@LefsFlare I have taken the torch of node-minecraft-protocol when its maintainer stopped supporting it, without problem. Yes, undertaking maintenance of a foreign project is hard, but it's not impossible. Besides, the code quality of DarkBot is very high from what I've seen, so instead of losing your time in justifying yourself, go learn some java and submit a PR to DarkBot if you want to see it updated.
Oh, and yes, your attitude is childish and manipulative. Dark might not want to work on the project anymore, and yet you're forcing his hand into updating it. Like it or not, but what you're doing fits very neetly in the definition of Psychological Manipulation, which is "a type of social influence that aims to change the perception or behavior of others through underhanded, deceptive, or even abusive tactics".
Anyway, no use in arguing this further, I'm out. Let's stay on-topic now and see how the community can update this project without Dark around. I'll have some time over the week-end, I'll push my progres in my fork then.

@squires @LefsFlare @roblabla: I don't mean to offend or to be against any of you since I understand that everyone here is only commenting because you respect this repository and the program that Dark has built and helped everyone else for, but for the best interests of DarkBot - help by contributing if you have time, stay out of the pranking or the bickering if you can't otherwise.
Of course, I'm not one to speak since I have my own development projects to work on, but I don't get what the point of this entire discussion is extending into. If you're still wondering if this project is being maintained, just consider otherwise. It's not my loss - or yours - but others, and that you shouldn't be worrying about it and badgerng DarkStorm.
I'm unwatching this repository now. It's been a pleasure.

"he is the only one that understands most of his own code" - I am better than Darkstorm, ask him yourself.
"Besides, the code quality of DarkBot is very high from what I've seen" I think dankstorm would agree with me if I said there could be some large code changes in this project.

@TheBiblMan every project has its "bad chunk, big rewrite needed" part somewhere. The problem comes when 100% of the code is in that stage ^^.

Me here, hello! Forgot to check notifications on this account. Every time I go to work on 1.8 support I realize I've completely forgotten where I left off and only make a little progress before finding it too tedious and wandering off. I've managed to have bots join 1.8 servers (which is not as much of a milestone as it used to be, considering packets now have lengths), but a decent amount is still missing (the worst part being that I no longer know what is). If anyone is interested in becoming a maintainer, send me a PM and we can talk.
@TheBiblMan pls no troll. I've managed to split apart portions that were too coupled, with the only major changes left to be done being MinecraftBot and protocol structure re-engineering. Aside from that I've realized that the project is actually pretty well structured. I should definitely start documenting things, though.

send me a PM and we can talk.

... what?

Oh, GitHub doesn't have a messaging feature, my bad. My email<EMAIL_ADDRESS>

Is there information of their libraries?
Note: I am spanish, my english is bad ;/

Yes. MCP has decompiled builds, or you can reverse-engineer the protocol used by Minecraft clients simply by decompiling the Minecraft jar source.

Alright, I'm almost done with the structural aspect of parsing this intermediate language for protocols:
protocol47x.xml
XML and JSON will be supported. It will work as a utility for representing the protocol structure in a less inane way than a hundred Java files. I'm hoping to include a way to write handler method bodies (Java code) straight in the XML file and have it compiled, but if I get lazy, a companion Protocol class will still have to be written for each protocol. This IL API will be able to compile the XML into Java bytecode for packet processing efficiency. I will commit current changes shortly.
I'm starting to feel like I'm over-engineering it.

I love you @DarkStorm652  <3<3

@DarkStorm652 hey men, how is it going?

there is already a date for this over?

FYI here is a list of files representing the protocol in various project https://gist.github.com/rom1504/7b4c0cc29fb03122b6a5
I think there is room for standardisation, might be useful to think collectively what a format representing the mc protocol need.

Was this abandoned again :/

Check the development branch. There is a 47 protocol xml which is the protocol number for 1.8.x.
I have managed to get a DarkBot.jar to compile from the development branch, although i cant figure out how to use the 47 protocol.

how did you get it to compile

sigh...

Oh hi there, two years later. Now 1.8 is of no concern, but how about 1.12?

At this point, just use PrismarineJS/mineflayer and make something cool with it. There's currently rom1504/rbot which uses it.


shellify use the local nixpkgs path instead of the remote one

i am using flake for my nixos, and set the nixpkgs to "github:nixos/nixpkgs/nixos-unstable" so
it should use it instead of the local one.

Hi @RoadRoller01, the value for that input is actually taken from the output of nix flakes registry list. If you run nix shell nixpkgs#someProgram you'll get someProgram from whatever nixpkgs is set to in the registry. nix-shell -p someProgam will instead take someProgram from the wherever nixpkgs points but AFAIK flakes can't point at this environment variable. I have to admit I didn't know all this until I wrote this tool.
I could add functionality to try to in some circumstances decode the value of nixpkgs and attempt to convert it to a flake input. But I wonder if it's overkill, especially since using nix-shell is the old way now. I tried to get a feeling of what the community want on discourse but didn't get a lot of discussion. Please consider contributing there if you have ideas as it's not clear to me what the consensus is on this from the community so I'm keen to see discussion on the matter:
https://discourse.nixos.org/t/shellify-tool-for-shell-nix-generation/33935
Also, it would be interesting to know why your nixpkgs registry entry is a local path. My nixos is built from flakes too and it doesn't look like that. Do you happen to know why yours is like that? Can you please share your nix registry list output?
Thanks for the feedback.

sure,
its
system flake:nixpkgs path:/nix/store/801l7gvdz7yaibhjsxqx82sc7zkakjbq-source
global flake:agda github:agda/agda
global flake:arion github:hercules-ci/arion
global flake:blender-bin github:edolstra/nix-warez?dir=blender
global flake:bundlers github:NixOS/bundlers
global flake:cachix github:cachix/cachix
global flake:composable github:ComposableFi/composable
global flake:disko github:nix-community/disko
global flake:dreampkgs github:nix-community/dreampkgs
global flake:dwarffs github:edolstra/dwarffs
global flake:emacs-overlay github:nix-community/emacs-overlay
global flake:fenix github:nix-community/fenix
global flake:flake-parts github:hercules-ci/flake-parts
global flake:flake-utils github:numtide/flake-utils
global flake:gemini github:nix-community/flake-gemini
global flake:helix github:helix-editor/helix
global flake:hercules-ci-agent github:hercules-ci/hercules-ci-agent
global flake:hercules-ci-effects github:hercules-ci/hercules-ci-effects
global flake:home-manager github:nix-community/home-manager
global flake:hydra github:NixOS/hydra
global flake:mach-nix github:DavHau/mach-nix
global flake:nickel github:tweag/nickel
global flake:nimble github:nix-community/flake-nimble
global flake:nix github:NixOS/nix
global flake:nix-darwin github:LnL7/nix-darwin
global flake:nix-serve github:edolstra/nix-serve
global flake:nixops github:NixOS/nixops
global flake:nixos-hardware github:NixOS/nixos-hardware
global flake:nixos-homepage github:NixOS/nixos-homepage
global flake:nixos-search github:NixOS/nixos-search
global flake:nixpkgs github:NixOS/nixpkgs/nixpkgs-unstable
global flake:nur github:nix-community/NUR
global flake:patchelf github:NixOS/patchelf
global flake:poetry2nix github:nix-community/poetry2nix
global flake:pridefetch github:SpyHoodle/pridefetch
global flake:sops-nix github:Mic92/sops-nix
global flake:systems github:nix-systems/default
global flake:templates github:NixOS/templates

for some reason i have two nixpkgs one tagged global and one tagged system, so i think you should use the global one?

Thanks for sharing the output.
If I were to use the system one this would break for somebody choosing to override the global one with their own local version. It would be good to understand how the local one got there. You might want to try updating your Nixos flake and see if the system nixpkgs changes. If it doesn't then you should delete it because it is surely growing stale. If it changes I suspect you are using something that chooses to pin nixpkgs to a local version and my gut feeling is that shellify should respect that rather then do something confusing or convoluted.
I'm interested to know if your flake did this and whether others are likely to get have situation.

i quit nixos(:

:( nooooo.....
i was about to ask if you could add a flag to use global values...

@Vaisakhkm2625, I'm now seeing the system value set to a Nix store path too. I think this behavior may have changed. I now suspect we should ignore the system value for at least nixpkgs by default and not with a flag. It would be good to understand this better though. Any experiments or analysis in this area are most welcome.

@Vaisakhkm2625, I'm now seeing the system value set to a Nix store path too. I think this behavior may have changed. I now suspect we should ignore the system value for at least nixpkgs by default and not with a flag. It would be good to understand this better though. Any experiments or analysis in this area are most welcome.

so can we reopen the issue to make it global?

@Vaisakhkm2625, I'm now seeing the system value set to a Nix store path too. I think this behavior may have changed. I now suspect we should ignore the system value for at least nixpkgs by default and not with a flag. It would be good to understand this better though. Any experiments or analysis in this area are most welcome.

so can we reopen the issue to make it global?

Yes, of course we can. The main thing I think we need to understand to address this is whether the pinning of the system value is happening for nixpkgs only or whether we need to change the rules for all inputs. I don't want to make the situation amny more complicated than it already is.

I'm part way through reading the comments in https://github.com/NixOS/nix/issues/7422?utm_source=pocket_saves which may help us understand the situation better.

So I read the above and found a link to https://github.com/NixOS/nixpkgs/pull/254405/files which appears to be pinning the system flake specifically for the case of nixpkgs. I don't think it makes sense to copy this pinning over into flake.nix (although pinning flake.lock would be beneficial). I'm thinking we should do the following for now:

By default take from the user registry, then system if not available and finally from global.

In the case of nixpkgs only, if the system entry is set to point to a path then fall straight through to the global entry.

Keep the above by default but add a switch --always-take-from-system-registry to revert to the old behavior.

@Vaisakhkm2625 what do you think? This is more complicated than I would like but I think it's necessary due to the complicated implementation of nix registries in the nix tool.

So I read the above and found a link to https://github.com/NixOS/nixpkgs/pull/254405/files which appears to be pinning the system flake specifically for the case of nixpkgs. I don't think it makes sense to copy this pinning over into flake.nix (although pinning flake.lock would be beneficial). I'm thinking we should do the following for now:
1. By default take from the user registry, then system if not available and finally from global.

2. In the case of nixpkgs only, if the system entry is set to point to a path then fall straight through to the global entry.

3. Keep the above by default but add a switch `--always-take-from-system-registry` to revert to the old behavior.

@Vaisakhkm2625 what do you think? This is more complicated than I would like but I think it's necessary due to the complicated implementation of nix registries in the nix tool.

Yes, exactly what i would like to see... if user is using pkgs different from the global, it doesn't make sense to directly pull from the global, so using user registry by default would be perfect.. but without the pinning

Great. Thanks for the feedback. It might come after Christmas I'm afraid but it is high on my todo list.


Fix scary search behavior on terms containing dash character

Currently, dash character is defined ad non-word character and it results into following search oddities:
$ knife node create mysql -d -z
Created node[mysql]
$ knife node create mysql-slave -d -z
Created node[mysql-slave]
$ knife search node 'name:mysql' -a name -z
2 items found

mysql:
  name: mysql

mysql-slave:
  name: mysql-slave

$ knife search node 'name:mysql?slave' -a name -z
0 items found

$ knife search node 'name:mysql-?lave' -a name -z
1 items found

mysql-slave:
  name: mysql-slave

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@amazon

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@amazon it would be nice to see backing spec for new behaviour, but overall :+1:

I've tested this.  It will solve  #158 .
before patch.
$ knife node list
aaa.host
bbb-aaa.host

$ knife search node "name:aaa.host"
2 items found

after patch.
$ knife search node "name:aaa.host"
1 items found

👍

👍


Update qa jenkins jobs

add bootstrapcrowbar into commands  jobs' params
use want_node_os=suse-12.2=4,suse-12.1=3 for 2c scenario
use devel:/languages:/python/SLE_12_SP2 repo

+1

+1


Collect listener outputs and return them on emit calls.

Hi,
I made this change to allow me to return Promises on event listeners and wait for them to finish by using Promise.all.
I am fairly sure pushing to an array isn't a realistic impact on performance. Maybe if the maintainers disagree we could think of a way to toggle this functionality.
Why this pull request?

I prefer not having to maintain this, even though it's one of the lowest maintenance packages I have come across.
If it would be better to opt-in for this feature, I would like some feedback on the most intuitive way on doing so.

This breaks the API compatibility with node as emit should return a boolean indicating if the event was emitted

I'm -1 for this chance. If I understand the use case correctly can't you do something like this?
const promises = [];

ee.on('event', function () {
  promises.push(getPromise());
});

ee.emit('event');

Promise.all(promises).then(function (values) {
  console.log(values);
});

Hi there,
Missed the fact that the switch case uses arguments.length, good catch.
I'm dropping this strategy, thanks for the feedback.


Best Unicode support in MySQL is utf8mb4

Please run this command in MySQL to enable the best Unicode support at present:
alter database wordpress character set utf8mb4 collate utf8mb4_unicode_ci;
Note: utf8mb4 allows emotional icons in Unicode.

Please refer to:
MySQL tables should use utf8mb4 character set
https://core.trac.wordpress.org/ticket/21212


fix(compile): directive require doesn't throw without link

Closes #3941

it looks like this is no longer an issue. Closing


Fix docker integration

Currently, docker integration doesn't work, and complains about a non-existent commit in a subdirectory.
We need to fix this so that builds are correctly pushed and can be deployed.

This one has been solved, right?

Indeed


slowness on Mac - M2 issue or mine?

Hi All
Just started playing with this docker-compose setup and firstly its great :)
However, its VERY slow to do most operations.  Loading a blank store home page, configuration and APIs are taking way too long.
Its running on  32gb RAM i7 Mac, so its not local resource issues, but just wondering from experience on here, is that a general mag 2 slowness issues or have I messed up the install / config.
Didn't change much in the, had issue initially with php7.0 so switched to 7.1 and it starts fine (after setting UPDATE_UID_GID=false).  Containers start fine and very nippy, its just the usability of the system.
Is there anything I can tweak anyway to speed this up?
Thanks, Stuart

Even delegated was bad for me.  I switched to docker-sync and unison and it works well now


Create benchmarks using BenchmarkDotNet

I think we can start writing performance tests.
These are the first results. And I think performance can be improved.

BenchmarkDotNet=v0.12.1, OS=Windows 10.0.17134.1304 (1803/April2018Update/Redstone4)
Intel Core i7-7700 CPU 3.60GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.1.302
  [Host]   : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT
  ShortRun : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT

Method
Mean
StdDev
Error
Gen 0
Gen 1
Gen 2
Allocated

'Dapper 2.0.35: First'
122.7 μs
7.70 μs
14.73 μs
1.1250
0.3750
-
4.64 KB

'RepoDb: First'
152.4 μs
7.54 μs
14.41 μs
2.0000
0.5000
-
8.71 KB

'Dapper 2.0.35: FirstAsync'
152.9 μs
12.43 μs
18.79 μs
1.7500
0.5000
-
7.55 KB

'RepoDb: FirstAsync'
197.2 μs
9.09 μs
15.27 μs
2.7500
0.7500
-
11.6 KB

'EFCore 3.1.6: First'
624.2 μs
48.45 μs
73.25 μs
9.0000
1.0000
-
38.97 KB

'EFCore 3.1.6: FirstAsync'
708.4 μs
80.28 μs
121.37 μs
10.0000
1.0000
-
42.93 KB

'NHibernate 5.3.1: First'
879.2 μs
37.40 μs
62.85 μs
12.0000
2.0000
-
49.24 KB

'NHibernate 5.3.1: FirstAsync'
966.3 μs
80.31 μs
134.95 μs
12.0000
2.0000
-
52.53 KB

Dapper is know to be fast in single fetch, but not in set fetches which is the usual case. Yes, you are correct, the performance can be improved in RepoDB. It degrades when I introduced the Property Handler. :)

Thanks for this PR. I will do my best to expand this benchmark in the near future. Please do not hesitate to PR anytime.


Update golang.org/x/tools to v0.7.0

Fixes https://github.com/kunwardeep/paralleltest/issues/25

I am unsure why the tests have not been kicked off for this branch.. I'll need to investigate


feat: port RingTheory.WittVector.Verschiebung

This is missing the ghostCalc  tactic, I suppose. Should we wait for that to be ported or workaround?
Any thoughts, @jcommelin?

I'm excited that this is now working. Basically ready to go, I think.
ghost_calc _ _; -- FIXME without the semicolon, ghost_calc eats the next tactic

It would be good if we can fix this.

@jcommelin, fixed the semicolon issue. There are two places I added FIXMEs where the comments need rewriting. Could you generally read through all the comments and make sure they reflect the new tactic design?

bors merge


write out the last git-rev

Weird that it wasn't already done previously. Just fyi, I'm not sure media/ is the proper place anymore? I remember some changes a long time ago to use static/ and user-media/ instead.

The fabric file is no longer being used for deployments on -dev and stage, and soon prod.

Let's make sure we delete once its not needed on prod.


Finish fix for #416

See here for details: https://github.com/LIT-Protocol/js-sdk/issues/416#issuecomment-2050838008. In a nutshell, you only need globalThis.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Indeed, I'm upgrading to lit v6 and am now running into the cross-fetch issue, but that seems to a problem with their library and not lit's.
Either way, there's no reason to use global over globalThis, and I see a4dd28ffc4386d64e2fbc6de19ab08e0ca7bc82d implemented this fix. Thanks!

cross-fetch

Thanks, we are considering ripping out cross-fetch completely, as it's too hard to satisfy all environments, we will just let users to polyfill themselves if required.


Richer ci-result

Description
The changes will add a richer json summary when running a CI build. Instead of "ci-result.json" that only has the score per page, this change will create a json that looks like this:
{
    summary: {
        score: 0.91,
        categories: {
              seo: 0.89,
              performance: 0.99
       }
    },
    route: [
        {
            path: "/"
            score: 0.91,
            categories: {
                  seo: 0.89,
                  performance: 0.99
           }
        }
    ]
}

This will make it easier to create custom reports or store the result for reference.
Notes:

The categories will list all available categories.
The summary score for the categories will assume that all routes have a score for each category, if that isn't the case the summary score might show an incorrect average.

Linked Issues
Fixes: https://github.com/harlan-zw/unlighthouse/issues/98
Additional context

Hey @mastoj, thanks for the PR!
The only issue with supporting this currently is that you are introducing a breaking change for anyone using the current output JSON.
So either we need to do this without the breaking change or it can be introduced behind a CLI flag which can become default in v1.

While we're on this, I think we should also have an option to show these metrics in the JSON output as these are the metrics we often refer to for CWV.

If you think this is a good idea in general I can add the flag (v1-report?) and also look at the other metrics. I guess they are available on each route?

I haven't looked into the code much but we can get the data from the result.result?.audits.
https://github.com/harlan-zw/unlighthouse/blob/dc9cee6038395d0e7ab6db31ba5233e7635cdb02/packages/cli/src/ci.ts#LL93C15-L93C42
Core Web Vitals seem to be sent from columnFields seems like we can send in our own if we want.
https://github.com/harlan-zw/unlighthouse/blob/main/packages/core/src/puppeteer/tasks/lighthouse.ts#L48

I will give it a go and see where I end up. I hope to get to it today or during the weekend.

I did eventually figure out how to deal with the options and config, so this is what I had time to do. Unfortunately I couldn't find the CWV metrics in the report, not sure why. The good part though is that adding them should not be a breaking change.
I've also updated the way I calculate the average so it is based on present values and not the number of routes. This means if some category is missing a result for some pages those pages will be ignored in the calculation.

Not sure it follows the style and organization you like. I did try to improve some structure by breaking out the reporting pieces to separate functions, but it can probably be improved further. I was somewhat limited though since it seems like my dev environment isn't correctly set up for the project, so I have some errors in the IDE even when it builds perfectly fine.

Found that the CWV should be set, https://github.com/harlan-zw/unlighthouse/blob/34a61a7de1d4a635547ae8d0b611b80b2b0b28b8/packages/core/src/puppeteer/tasks/lighthouse.ts#L46, weird that I couldn’t see it when running. Will look more tomorrow or in the weekend.

Not sure it follows the style and organization you like. I did try to improve some structure by breaking out the reporting pieces to separate functions, but it can probably be improved further. I was somewhat limited though since it seems like my dev environment isn't correctly set up for the project, so I have some errors in the IDE even when it builds perfectly fine.

Not sure if you use Discord but feel free to DM me if you need some help getting it set up.
The reporting features were mostly an after thought, for the v1 they will need to be refactored so happy for bigger changes.

I think the format of the report is ok, since it is now easier to add more. The main things are "metrics" and "categories", and there are no limitation to how many they can contain. With that said, I am only picking metrics from a predefined set since the "audit" type contains many properties that does not align with the first set of metrics.
I have also added some unit test for the ci report generation and extracted a sample lighthouse report to use in the tests so we don't have to run against a web app to test it.

Continued in https://github.com/harlan-zw/unlighthouse/pull/111


Fix missing resources in CRD cluster roles

Fix missing resources in CRD cluster roles

/ok-to-test


mediaCapabilities queries include keySystemInformation for unencrypted content

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.2.1
Can you reproduce the issue with our latest release version?
I assume so. There don't look to be changes in this area
Can you reproduce the issue with the latest code from main?
I assume so. There don't look to be changes in this area
Are you using the demo app or your own custom app?
custom
If custom app, can you reproduce the issue using our demo app?
Not possible to define DRM licence server URL
What browser and OS are you using?
Windows, Chrome
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://dash.akamaized.net/dash264/TestCasesUHD/2b/11/MultiRate.mpd
What configuration are you using?  What is the output of player.getConfiguration()?
DRM servers are defined for widevine and playready. The exact values aren't significant, as this is an unencrypted stream, but it's significant that they are defined
What did you do?
Try to play the content
What did you expect to happen?
The content plays
What actually happened?
The content doesn't play. I see "4032-Shaka Error MANIFEST.CONTENT_UNSUPPORTED_BY_BROWSER()"
We have always kept the same DRM configuration whether playing encrypted or unencrypted content, and for most content this has been fine, but when we tried the HEVC stream listed above it failed. Tracing the code it seems that it's because the keySystemInformation is included in the query to navigator.mediaCapabailities.decodingInfo() even though the content is unencrypted.
Is it possible to exclude keySystemInformation from this query for unencrypted content, while maintaining the drm.servers configuration?

This is not feasible, because we can't be certain that content is actually unencrypted just from the manifest.
For server-side ad insertion in live streams using multiple DASH Periods, you typically end up with unencrypted ad Periods and encrypted main content Periods.  At the time we join the stream, it is possible that only unencrypted ad Periods are listed in the manifest.  So we rely on the configuration of the player to know that encrypted content is expected.
If your content is unencrypted, and you know this, you should remove the DRM servers from your player config.  Decoding capabilities can vary between encrypted and unencrypted content on the same system, since the CDM may only be able to securely communicate with certain decoders and not others.

Thanks @joeyparrish. I appreciate the feedback.


updated url regular expression.

In href Current REGEX not working for tel:// and custom routes which we created for our project. Here My solution is just matching with all texts whatever inside the href double quotes.

This also enables proper mailto: parsing.


middleware TypeError for not found routes

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] other (Please do not submit support requests here (below))

When using an action and calling context.next() with child routes, a TypeError is thrown if the route does not exist. I expected a route not found error to be thrown.
https://jsbin.com/zicukiyoxu/1/edit?html,output
    const router = new UniversalRouter({
      path: '/',
      async action({ next }) {
        console.log('middleware: start');
        const child = await next();
        console.log('middleware: end');
        return child;
      },
      children: [
        {
          path: '/hello',
          action() {
            console.log('route: return a result');
            return 'Hello, world!';
          }
        }
      ]
    });

    router.resolve('/hello/404');

universal-router.js:439 Uncaught (in promise) TypeError: Cannot read property 'route' of undefined
    at next (VM173 universal-router.js:439)
    at VM173 universal-router.js:462

If you comment out the action middleware, you get the expected error message
Uncaught (in promise) Error: Route not found
    at next (VM173 universal-router.js:451)
    at VM173 universal-router.js:462

I still get the TypeError if I add a fallback route using '*'. Without the action middleware and with a fallback, the fallback route is correctly returned and no error is thrown.

Thank you for the bug report! The fix is released: v8.2.1 🎉


SAK-32223 Drop down now works as expected.

@adrianfish, what is the original ticket for the addition of the picture changer? Thanks.

@fostersdesign
https://jira.sakaiproject.org/browse/SAK-32211

@fostersdesign Nice avatar :)

So does this fix (for SAK-32223) remove the changer from the profile photo, so it only appears on the profile photo in the account menu?

@fostersdesign Yep, spot on. That was how NYU had it in the first place - I just ported it wrong :(

@fostersdesign Good to go? Pirate Golf?

@fostersdesign Can I merge it? You are now the reviewer, so you have to say.

Sorry @adrianfish. I was out at lunch. I see you merged it.
Your changes make sense. I'll take a look at the nightlies tomorrow morning when it updates to confirm the functionality, as my local instance isn't set up to use Profile at the moment.

@fostersdesign No worries. Lunch is important. Meatzza?


Flutter [Web] ReorderableListView missing end icon 'handle' on Android Web

Greetings,
I notice that the ReorderableListView on Android Web View is missing the touch icon at the end, it appears to be present on desktop and iPad Web.
Sample code from here:
https://api.flutter.dev/flutter/material/ReorderableListView-class.html
Expected:

Android Web:

minimal code sample
/// Flutter code sample for ReorderableListView
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
/// This is the main application widget.
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
static const String _title = 'Flutter Code Sample';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
home: Scaffold(
appBar: AppBar(title: const Text(_title)),
body: const MyStatefulWidget(),
),
);
}
}
/// This is the stateful widget that the main application instantiates.
class MyStatefulWidget extends StatefulWidget {
const MyStatefulWidget({Key? key}) : super(key: key);
@override
State createState() => _MyStatefulWidgetState();
}
/// This is the private State class that goes with MyStatefulWidget.
class _MyStatefulWidgetState extends State {
final List _items = List.generate(50, (int index) => index);
@override
Widget build(BuildContext context) {
final ColorScheme colorScheme = Theme.of(context).colorScheme;
final Color oddItemColor = colorScheme.primary.withOpacity(0.05);
final Color evenItemColor = colorScheme.primary.withOpacity(0.15);
return ReorderableListView(
  padding: const EdgeInsets.symmetric(horizontal: 40),
  children: <Widget>[
    for (int index = 0; index < _items.length; index++)
      ListTile(
        key: Key('$index'),
        tileColor: _items[index].isOdd ? oddItemColor : evenItemColor,
        title: Text('Item ${_items[index]}'),
      ),
  ],
  onReorder: (int oldIndex, int newIndex) {
    setState(() {
      if (oldIndex < newIndex) {
        newIndex -= 1;
      }
      final int item = _items.removeAt(oldIndex);
      _items.insert(newIndex, item);
    });
  },
);

}
}

flutter doctor
[√] Flutter (Channel master, 2.6.0-6.0.pre.71, on Microsoft Windows [Version 10.0.17763.2114], locale en-IE)
• Flutter version 2.6.0-6.0.pre.71 at C:\Code\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision cd112e551c (12 hours ago), 2021-09-13 12:13:42 -0700
• Engine revision abb1980f65
• Dart version 2.15.0 (build 2.15.0-96.0.dev)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at C:\Users\Omega\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
• All Android licenses accepted.
[√] Chrome - develop for the web
• CHROME_EXECUTABLE = C:\Code\FlutterTesting\ChromeCORS.bat
[√] Android Studio (version 2020.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
[√] VS Code (version 1.60.0)
• VS Code at C:\Users\Omega\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.26.0
[√] Connected device (2 available)
• Chrome (web) • chrome • web-javascript • Google Chrome 93.0.4577.63
• Edge (web)   • edge   • web-javascript • Microsoft Edge 92.0.902.73
• No issues found!

ReorderableListView has an attribute buildDefaultDragHandles which default to true, and builds drag handles on desktop platforms and hold and drag behaviour on mobile device for reordering. If you want to have drag handles on mobile devices as well, you can do something like this:
return ReorderableListView(
      buildDefaultDragHandles:false,  //Remove default drag handles
      padding: const EdgeInsets.symmetric(horizontal: 40),
      children: <Widget>[
        for (int index = 0; index < _items.length; index++)
          ListTile(
            trailing: ReorderableDragStartListener(index:index,child: const Icon(Icons.drag_indicator_outlined)),   //Wrap it inside drag start event listener
            key: Key('$index'),
            tileColor: _items[index].isOdd ? oddItemColor : evenItemColor,
            title: Text('Item ${_items[index]}'),
          ),
      ],
      onReorder: (int oldIndex, int newIndex) {
        setState(() {
          if (oldIndex < newIndex) {
            newIndex -= 1;
          }
          final int item = _items.removeAt(oldIndex);
          _items.insert(newIndex, item);
        });

This will work on Desktop as well as mobile platforms, but it will disable hold and drag  on mobile platforms.
Complete Example:
/// Flutter code sample for ReorderableListView

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

/// This is the main application widget.
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: _title,
      home: Scaffold(
        appBar: AppBar(title: const Text(_title)),
        body: const MyStatefulWidget(),
      ),
    );
  }
}

/// This is the stateful widget that the main application instantiates.
class MyStatefulWidget extends StatefulWidget {
  const MyStatefulWidget({Key? key}) : super(key: key);

  @override
  State<MyStatefulWidget> createState() => _MyStatefulWidgetState();
}

/// This is the private State class that goes with MyStatefulWidget.
class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  final List<int> _items = List<int>.generate(50, (int index) => index);

  @override
  Widget build(BuildContext context) {
    final ColorScheme colorScheme = Theme.of(context).colorScheme;
    final Color oddItemColor = colorScheme.primary.withOpacity(0.05);
    final Color evenItemColor = colorScheme.primary.withOpacity(0.15);

    return ReorderableListView(
      buildDefaultDragHandles:false,  //Remove default drag handles
      padding: const EdgeInsets.symmetric(horizontal: 40),
      children: <Widget>[
        for (int index = 0; index < _items.length; index++)
          ListTile(
            trailing: ReorderableDragStartListener(index:index,child: const Icon(Icons.drag_indicator_outlined)),   //Wrap it inside drag start event listener
            key: Key('$index'),
            tileColor: _items[index].isOdd ? oddItemColor : evenItemColor,
            title: Text('Item ${_items[index]}'),
          ),
      ],
      onReorder: (int oldIndex, int newIndex) {
        setState(() {
          if (oldIndex < newIndex) {
            newIndex -= 1;
          }
          final int item = _items.removeAt(oldIndex);
          _items.insert(newIndex, item);
        });
      },
    );
  }
}

Hi @zambetpentru, This is the intended behavior for mobile platforms. Please see this api docs for more on buildDefaultDragHandles
Thanks, @Mayank-9018  for volunteering.
You may also refer this similar issue raised in the past https://github.com/flutter/flutter/issues/80553
Closing this issue as it is working as intended. If you disagree feel free to write in the comments and I will reopen it.
Thank you.

Cheers thank you both!

@Mayank-9018 thanks for your detailed response. Do you know what is the official flutter way to determine the difference between mobile and desktop web? As in this case interestingly the iPad shows the drag handles but my Android phone wasn't.

@zambetpentru You can use Theme.of(context).platform or
import 'dart:io' show Platform;    //Won't work on Web
print(Platform.operatingSystem);

Hi, @Mayank-9018 I think maybe my question wasn't as specific as it should have been. :-)
So the drag handles show on Desktop and they also show on my iPad but not on my Android phone. At the same time the iPad appears to be detected as a mobile device as it chooses the HTML renderer rather than the CanvasKit so I was trying to see how the choice was being made for the ReorderableListView handle.


Use an HTTPS Agent and HTTPS scheme if RED.settings.https is set

fixes #1473
Description
Supersedes https://github.com/FlowFuse/node-red-dashboard/pull/1480

Checks RED.settings.https is "something" and if yes:

switches the URL scheme to "https://"
Adds an HTTPS Agent & spreads whatever is in RED.settings.https into the Agent (permitting any extras to be included or to override the default rejectUnauthorized: false if so desired)

NOTE:
I have tested a variation of this code on a users VM (thanks for the support @Paul-Reed)
By variation, I mean an older branch but the relevant parts of this PR were used and verified.
Related Issue(s)
#1473
Checklist

[x] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[ ] Documentation has been updated

[ ] Upgrade instructions
[ ] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
[ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

Oddly keep getting 2 x slider tests failing, but I see no reason as to why that would be caused by this.

Oddly keep getting 2 x slider tests failing, but I see no reason as to why that would be caused by this.

This is (deliberately) based of the newer WYSIWYG work since it fixed something in this area and I didnt want to do the work twice.
In theory, the problem lies in the base branch (not this)
Investigating base branch widget-wysiwyg


stages/org.osbuild.dnf.config: Edit /etc/dnf/dnf.conf

Fixes #906

@gicmo So in the obscure case dnf.conf doesn't exist, should we create it?

Thanks a lot for implementing this. I would like to suggest that we use the same schema for dnf.config as it is used in https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.yum.config

Thanks a lot for implementing this. I would like to suggest that we use the same property names in the schema for dnf.config as it is used in https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.yum.config

Right but yum only supports the [main] section though, then again we'll probably never have any other sections?

Thanks a lot for implementing this. I would like to suggest that we use the same property names in the schema for dnf.config as it is used in https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.yum.config

Right but yum only supports the [main] section though, then again we'll probably never have any other sections?

So besides the [main] section, there can be only repository definitions in the main dnf.conf config. I think that we will never want to define repositories in dnf.conf and will do it by adding files to /etc/yum.repos.d.

Thanks a lot for implementing this. I would like to suggest that we use the same property names in the schema for dnf.config as it is used in https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.yum.config

Right but yum only supports the [main] section though, then again we'll probably never have any other sections?

So besides the [main] section, there can be only repository definitions in the main dnf.conf config. I think that we will never want to define repositories in dnf.conf and will do it by adding files to /etc/yum.repos.d.

true, I'll switch it over then!

@gicmo So in the obscure case dnf.conf doesn't exist, should we create it?

Yeah, this is what org.osbuild.yum.config does too.

I think that org.osbuild.yum.config creates the file only because YUM no longer exists on Fedora, on which we run all of our testing. So we can not easily ensure that the file exists by installing a package on Fedora.
Nevertheless the behavior across stages is not consistent in this regard (some create the config file, some will fail if it does not exist), so it is probably OK to create it.

So besides the [main] section, there can be only repository definitions in the main dnf.conf config. I think that we will never want to define repositories in dnf.conf and will do it by adding files to /etc/yum.repos.d.

I am torn. On to one hand it is nice to have the same schema for the yum and dnf stage and it is true that for yum we won't ever get something else than [main] but that might not be true for dnf since that is still in development. so maybe it is better to have it nested and have a main subsection (and re-use the schema here, so it is re-usable in composer as well).

I am torn. On to one hand it is nice to have the same schema for the yum and dnf stage and it is true that for yum we won't ever get something else than [main] but that might not be true for dnf since that is still in development. so maybe it is better to have it nested and have a main subsection (and re-use the schema here, so it is re-usable in composer as well).

We can definitely be on the safe side and add the main subsection. We did that in other stages with sections and there is IMO no real impact on user experience of the stage. If anything, it makes the schema easier to understand by anyone already familiar with the tool that it being configured.
However personally I think that DNF can't afford to add any other configuration section ever in the future. The reason is that any other section is currently interpreted as a repo configuration (and the section name as repo ID), thus if they decided to use some, it could easily conflict with a repo ID defined by some user. They would have to use some symbols not allowed in the ID string to be sure to prevent conflict.
But yeah, we can gamble or be safe 😄

So I decided to leave the schema as is then. I don't feel strongly either way and am happy to change it to be like the yum stage. The only downside is that if it ever where to change, we'd have a less ideal schema with 2 config sections on the top level.

So I decided to leave the schema as is then. I don't feel strongly either way and am happy to change it to be like the yum stage. The only downside is that if it ever where to change, we'd have a less ideal schema with 2 config sections on the top level I guess.

Sorry for being too nitpicky... Personally I prefer if the main would be a subsection under config property. This way we could just iterate over the dictionary items and interpret them as sections and options in that section. So we could end up using the same code even if we extend the schema with additional sections in the future. I find the potential addition of a new section as config_<section_name> a bit weird. I also think that nesting sections will look more natural in the data structure representation later in the composer implementation for the stage.
But it is not like I can not live with the current state 😄

So I decided to leave the schema as is then. I don't feel strongly either way and am happy to change it to be like the yum stage. The only downside is that if it ever where to change, we'd have a less ideal schema with 2 config sections on the top level I guess.

Sorry for being too nitpicky... Personally I prefer if the main would be a subsection under config property. This way we could just iterate over the dictionary items and interpret them as sections and options in that section. So we could end up using the same code even if we extend the schema with additional sections in the future. I find the potential addition of a new section as config_<section_name> a bit weird. I also think that nesting sections will look more natural in the data structure representation later in the composer implementation for the stage.
But it is not like I can not live with the current state smile

Oh sorry I think i misunderstood and missed the renaming part, totally agree.

@Gundersanne do you plan to implement also the necessary changes for the stage in osbuild-composer?

@Gundersanne do you plan to implement also the necessary changes for the stage in osbuild-composer?

On it!


Add python_requires

This will prevent installation on unsupported versions of Python.

Thanks I will merge this once I get back from vacation next week


change all imports to model.inventory.Ingredient for clearer structure

yeah sure, you can just refactor it. Will take note, thanks.


Change standalone agency doc

Changed documentation for standalone agency, set port of first agent to 8531, offset +10 for other agents for ArangoDB standard consistency

@Simran-B
-L does not redirect to Leader in my test. Just get the config from followers

I opened an issue in the new docs repo regarding the redirect question: https://github.com/arangodb/docs/issues/14


Xcode 8 support

Fixes #139

Coverage increased (+0.3%) to 62.403% when pulling e9454f375f6b1391682c63b5b3aff6775b485f7f on xcode-8-support into 5e42625f5153a835d8fdb9c4bc056ae67047b0db on master.

:shipit:


Implement Forward Action Resource to allow multiple target groups by Weight

Fixes: https://github.com/perfectsense/gyro-aws-provider/issues/448
This PR makes ALB Forwarding actions comparable to console configuration. This allows an Application Load Balancer Listener rule to forward to multiple target groups and to adjust the weight of them.

This functioned correctly for me when testing the ALB workflow.


fix paths in gradle scripts

I thought so as well that all usages of “/“ should be changed to File.separator, but as it turns out, paths that are passes to project.file() or project.files() should be OK regardless of the underlying platform.

@aalmiray thanks for info, and build is failing on linux at the end though I thought it's working (it's too long to wait). Btw I added a pr to disable fail-fast on ga https://github.com/kordamp/kordamp-gradle-plugins/pull/300


Update sbt-scoverage to 1.6.1

Updates org.scoverage:sbt-scoverage from 1.6.0 to 1.6.1.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: semver-patch

Pull Request Test Coverage Report for Build 20

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 95.0%

Totals

Change from base Build 19:
0.4%

Covered Lines:
57

Relevant Lines:
60

💛  - Coveralls


Horcrux v2 - Raft edition 🛶

We are going to implement a raft cluster for leader election. Only the leader will be able to submit signatures to sentries and all nodes will still maintain a high watermark HRS file outside consensus for protection against node take over (i.e. in the case where an attacker gains access to a single node in the cluster the attacker would only be able to cause a service disruption not a double sign event).
We plan to use https://github.com/strangelove-ventures/raft-sample as a basis for the implementation i.e. using hashicorp/raft and a database backend (badgerdb?). Data to be stored in consensus:

High watermark (i.e. what is the latest HRS that the cluster has sent to sentries)
Sentry nodes
Cluster members?

Unanswered questions for Jack:

[ ] Service discovery - how do we want the signer nodes to discover each other? Current method (hardcoding the peers in the config file) has some potential downsides but should be fine. Many of the Raft example repos I've seen don't do this.
[ ] Do we want to store last sign state in consensus and if so where and when do we rely on it?
[ ] Is there some required user intervention for picking the leader?

Great to see Raft on the roadmap! I have written a Raft leader election implementation myself, which I think we could use as a baseline. I've also written a short Medium article about it. It already implements pre-votes (see chapter 5) and leader stickiness (see chapter 6), which would be absolutely necessary to guarantee a single leader at all times (=during full and partial network partitions).


Follow up fluentd v1.16.5-1.0 images

Since v1.16.5, new version is reset to amd64-1.0 or arm64-1.0,
so it should follow them.

Oops, sorry.


Add a license to the repository

I recently came across your project Quantum-computing and I noticed that the repository github.com/graph90/Quantum-computing currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Hi @cbjuan,
Thank you for the suggestion! I've added an Apache 2.0 license to the repository as recommended. I appreciate you taking the time to point this out.
I noticed you work at IBM Quantum. I recently graduated from Ontario Tech University with a degree in Computer Science, where I took a quantum computing class that heavily focused on Qiskit. I’m eager to learn more about the field and what it’s like to work in quantum computing.
If you're open to it, I'd be happy to continue the conversation over email to learn more about your insights. You can reach me at<EMAIL_ADDRESS>Thanks again!
Best,
Nathaniel Armogan

Thank you!


New org: Condor Camp

https://condor.camp/team/

Only needs lontermism as cause_area to be ready

Ready for review


Updated to 0.7.2 from 0.5.0, rspec-expectations stop "working"

So, I have this request spec:
https://gist.github.com/7902d1a82d278cafc820#file_spec.rb
And it was totally passing a minute ago
But then other tests were failing to trigger jQuery.change() on radio buttons and I realized oh... I'm on capybara-webkit 0.5.0, maybe I should update that:
$ bundle update capybara-webkit
Gemfile.lock diff: https://gist.github.com/f135f987a3a677d408d8
And now, the spec I linked above fails, because the stubbed Product class method is no longer stubbed. It actually does the real deal and hits the third party API...
I have NO clue where to go from here, someone please help me out.

Concerning this specific codebase, I already moved off into a controller spec... I'll try to do as you asked though

I'm going to close this for now. @joemsak let me know if you still have these problems on 0.10.1.

Fair, sorry I just never had time to do this in a separate codebase, plus I turned all that stuff into a gem ; )


Query Expansion Select error on clicking query expansion button

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

Current behavior 😯
It's giving error - TypeError: Cannot read properties of undefined (reading 'map')
link - https://preview.nferx.com/core-ui-docs/components/query-expansion/query-expansion-select
Expected behavior 🤔
No response
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Going into the link doesn't seem to throw any error.
It doesn't look like this bug report has enough info for one of us to reproduce it.
Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

I will close this issue for now. Please create a new issue with the guideline suggested above.


Update filesys/nullfilter readme with deploy instructions

It would be very helpful if this provided basic instructions on getting the null filter built and deployed.
also, it's not currently compiling with VS2019:
1>------ Build started: Project: nullFilter, Configuration: Debug x64 ------
1>Building 'nullFilter' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
1>Stamping x64\Debug\nullFilter.inf
1>Stamping [Version] section with DriverVer=10/30/2019,<IP_ADDRESS>
1>C:\Repos\Windows-driver-samples\filesys\miniFilter\nullFilter\nullFilter.inf : error 1420: [DefaultInstall]-based INF cannot be processed as Primitive.
1>C:\Repos\Windows-driver-samples\filesys\miniFilter\nullFilter\nullFilter.inf(25-25): error 1421: Section [DefaultInstall] should have an architecture decoration.
1>C:\Repos\Windows-driver-samples\filesys\miniFilter\nullFilter\nullFilter.inf(36-36): error 1421: Section [DefaultUninstall] should have an architecture decoration.
1>C:\Repos\Windows-driver-samples\filesys\miniFilter\nullFilter\nullFilter.inf(71-71): warning 1205: Section [NullFilter.DriverFiles] referenced from DelFiles and CopyFiles directive.
1>Done building project "nullFilter.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

This is really two issues, "build and deploy docs", and "doesn't compile with VS2019". The second issue is a major bug and should be its own issue.

Have you (anyone) by any chance figured out how to get the minifilter examples working? I've read through all INF docs relating to the new required format and I think I'm close but these filters just won't load.

I think I figured it out here: https://gist.github.com/corytodd/09d112f1d6eb2ba264a1a4ee736ed52c
If any of that looks incorrect/unsafe/etc please let me know. At least now the minifilters are loading and appear to be working.


🐛 [firebase_messaging] Firebase messaging adds AD_ID permission

Bug report
Describe the bug
Browsing through the merged manifest it can be seen that firebase_messaging is reported to add AD_ID permission.
Steps to reproduce
Steps to reproduce the behavior:

Go to build folder
find manifest-merged-blame-debug-report.txt
Search for AD_ID usage
Find firebase_messaging adding unnecessary permission

33-->[com.google.firebase:firebase-messaging:23.0.8] /Users/.../.gradle/caches/transforms-3/c9ffe383d585c72fdd485b230afb7e10/transformed/jetified-firebase-messaging-23.0.8/AndroidManifest.xml:29:22-79
34    <uses-permission android:name="com.google.android.gms.permission.AD_ID" />

Expected behavior
firebase_messaging is not related to ads, so it shouldn't add AD_ID permission.
Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
- firebase_analytics 9.3.6 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 1.23.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.8.11 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 13.0.3 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_performance 0.8.3+1 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- firebase_remote_config 2.0.18 [firebase_core firebase_core_platform_interface firebase_remote_config_platform_interface firebase_remote_config_web flutter]

@AAverin
I think this will need to be reported in native firebase sdk repo. I see a similar issue open in it for analytics: https://github.com/firebase/firebase-android-sdk/issues/2582
Closing from here. If you disagree, write in comments and I'll reopen it.


Change configuration for uploading large size images with docker

Hello,
Is there any way to change the max size configuration for files when using docker? I've seen this ` but I don't know how to implement it , while serving a docker image directly.
You've done a great work. Thank you!

Thanks for your mail. I am out of the office and offline all day Thursday 25 October 2018. For any urgent matters please do not hesitate to contact the office, otherwise I will respond to your mail on Friday.


Gestione http exception.

Codecov Report
Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:

Coverage data is based on head (9b51c03) compared to base (7284a71).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              main     #20   +/-   ##
=======================================
  Coverage     0.00%   0.00%
- Complexity      68      73    +5
=======================================
  Files            9      10    +1
  Lines          165     174    +9
=======================================
- Misses         165     174    +9

Flag
Coverage Δ

unit-test
0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/EnolaClient.php
0.00% <0.00%> (ø)

src/HttpClient/Plugin/OpenApiExceptionThrower.php
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Trace is listed as "Trace " instead of "Trace"

LogLevel.Trace is listed as "Trace " instead of "Trace"  here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7184a308-a254-9350-a5cd-5bced1f369ae
Version Independent ID: 726e3bf1-f367-d733-8933-bccc04da0e16
Content: Logging in .NET Core and ASP.NET Core
Content Source: aspnetcore/fundamentals/logging/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Extra whitespace? Where?

A few sections below here

Microsoft.Hosting": "Trace " // Debug:Microsoft.Hosting category.       },

Yes that

Fixed  in #18881
Thanks for bringing this to our attention.


RFE: Code Generation Feature

Description
As the Rancher UI is effectively an API client, it could be possible to record and display the API's called in a more user-friendly way compared to using developer tools inside the clients browser client.
Workflow

User clicks a record button in the Rancher UI
User performs a number of activities - For example, creating cloud credentials, cluster, install an app from a repo, etc.
User clicks a stop button in the Rancher UI.
Rancher UI displays the API calls that were made during this time period.

Value
Being able to easily extrapolate API calls for complex workflows could help in third party integration with automation solutions
SURE-4581

I'm not sure this is a good idea. The UI roughly uses three APIs.
Norman (v3 / the old rancher API)
This one should be documented somewhere in the official docs
Steve (v1 / the new rancher API)
Using this outside of the UI / other tools isn't supposed to be supported. Someone from the backend team can fill in the details but as it manages native resources the kube api should supersede it.
Native Kube API
This should be well documented
At any point in the UI we could have used a number of them to either get the information required to create the requests or to make them.

We often get requests for API documentation, but since the API is not supported, the official response is that Fleet and the Rancher2 Terraform provider are the only supported forms of automation.
With that said, we do already have a user preferences setting that already lets you enable the "View in API" feature for development purposes. Maybe we should extend that feature so that when the "Enable Developer Tools & Features" option is clicked, then you will also be able to record the API calls.

@catherineluse We should NOT generate API docs for un-supported APIs or APIs that have external documentation. We should not either encourage people to use those un-supported APIs. The only actions for Rancher should be improving v3 docs and guides to our custom CRDs (which can be managed by the kube API).
The View in API site is generally there for internal/developer purposes as a workaround for features that aren't implemented or working as expected.
Browser 'Developer tools' already exists that clearly show the API calls the dashboard makes, it also has lots of cool features (filtering, display modes, recording, throttling, stats, etc) that we would have to re-implement.

Given the supported situation of the API's and that there's an existing, built-in tool in all browsers that already covers this I'm closing this issue


NIST PubID scheme: identifiers that need clarification

A number of Tech Pubs have current pub IDs that contain both Edition/Revision and also Year. Some of them have Month information.
What should the patterns be for those? I’m listing them below where the left shows the original pub ID, the right shows a proposed PubID.
What do we do with the month when given? (still an issue in PubID 1.0)

"NBS CIRC 13e2revjune1908”
"NBS FIPS 89-May1981”
"NIST IR 8170 (March 2020)"

Should we omit the year information if there is an edition number already provided?  (still an issue in PubID 1.0)

“NBS CIRC 11e2-1915” => “NBS CIRC 11e2"
“NBS HB 44e2-1955” => “NBS HB 44e2”?

Should we omit the edition number if it is 1? (still an issue in PubID 1.0)

“NBS SP 960-12e1” => “NBS SP 960"
"NIST SP<PHONE_NUMBER>ed.” => "NIST SP 260-162” (this is Edition 1 of SP 260-162) (now at #155)
“NIST SP 250-29e2004” => “NIST SP 250-29" (now at #155)

Should we omit the revision number if it was mis-marked? (still an issue in PubID 1.0)

"NIST SP 260-174r2012” => "NIST SP 260-174” (this is not a revision, this is actually Edition 1)
"NIST SP 305-23r1992” => "NIST SP 305-23” (this is actually Edition 1)

Should we automatically assign the edition number if the edition is given as a year? (No, an edition can be yyyy or 1-9, described in #155)

“NIST SP 250-39e2009” => “NIST SP 250-39e2” (this is Edition 2 of SP 250-39)

Sometimes revision numbers are inconsistently assigned: (still an issue in PubID 1.0, source data needs to be fixed)

"NIST SP 800-57p1” is the base document.
"NIST SP 800-57p1r2006” => should have been r1
"NIST SP 800-57p1r2007” => should have been r2
"NIST SP 800-57p1r3” => is correct.

Should the Part number, if in alphabet, be capitalised? (now decided in #154)

“NIST SP 800-131a” => “NIST SP 800-131A”? (The base document “NIST SP 800-131a” has a R1 as “NIST SP 800-131Ar1”.)
"NIST SP 800-38a” => "NIST SP 800-38A”? ("NIST SP 800-38a” but "NIST SP 800-38F”)

Should PubID fix minor issues like these? (still an issue in PubID 1.0, source data needs to be fixed)

"NIST SP 800-40ver2” => "NIST SP 800-40v2”

“Part” representation sometimes goes with “p” or “pt”: (decided in #87)

"NIST SP 800-57pt1r4” vs "NIST SP 800-57p3"

There are also some funny ones that need consideration:  (still an issue in PubID 1.0, potentially data source issues)

“NIST SP 800-27 Revision A”
“NIST SP 800-22 Revision 1a”
"NIST SP 800-87ver1” vs "NIST SP 800-87ver1e2006” vs "NIST SP 800-87ver1e2007”

Updated list according to Final PubID scheme. Remaining questions/identifiers have been sent for clarification.


Added .count method and :skip option

Added

.count() method that counts all records in a leaderboard
{ skip: number } option to the .list() method

Hi @alexfedosov, sorry for the delay to reply here. This looks really good. Would you mind removing the compiled lib files so I can merge your pull request?
Cheers


Gives Mediborg the Medical Hud

About the PR

Title
Why / Balance

I assumed that mediborgs already had the hud when making #27875, as the hud is used to help people in need.
Technical details

yml changes
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Medical Borgs now have medical huds

Meh... Don't know what's causing the GitHub error but I did the requested change. I think I set all the items that needed the parent but I'm not sure, tell me if you notice anything I missed.

Ok, all of the objects are parented that you requested, plus BorgChassisMedical because that's the main point of the pr. I believe the only thing I missed last time was MobMedibot.


How to list recurred/scheduled task?

Hello,
I have to implemented recurring tasks plugin for redmine and scheduled some of tasks and will recure it but i don’t know; how can i list or check or cancel or monitor for scheduled tasks ?
Many thanks for your help
Mutlu

Please read install instructions in readme. You have to setup cron (run whenever) to initialize cron.


Readme: correct some broken grammar / etc.

got here from https://twitter.com/stoiandan22/status/1404362636419121152
.
also see
https://www.shlomifish.org/humour/Muppets-Show-TNI/Summer-Glau-and-Chuck-Norris.html

Thank you @shlomif ! Will try to do better, lol! Appreciate your interest!

Thanks @stoiandan ! and - yw! ♥


user id is not consecutive

What is the expected result?
Increment of new users is jumping - its not consecutive
Additional info

Q
A

Yii2 version
latest

Yii2-user version
latest

PHP version
5.6

Its normal that the ID in table {user} - is not consecutive ? and may be someone can answer me why its happen ?

What database are you using?

InnoDB - utf8_general_ci

If i'm right when the registration have an error, its reserve an ID, and next time when you try to submit(validate) your form - its increse agains +1, and untill you get validation TRUE, and data is inserted all ok.

that's pretty odd, as the user table is created with primaryKey(). Handling of the increment is delegated to mysql afaik. can you post the result of the command "show create table user;"

CREATE TABLE user(  idint(11) NOT NULL AUTO_INCREMENT,  usernamevarchar(255) COLLATE utf8_unicode_ci NOT NULL,  emailvarchar(255) COLLATE utf8_unicode_ci NOT NULL,  password_hashvarchar(60) COLLATE utf8_unicode_ci NOT NULL,  auth_keyvarchar(32) COLLATE utf8_unicode_ci NOT NULL,  confirmed_atint(11) DEFAULT NULL,  unconfirmed_emailvarchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,  blocked_atint(11) DEFAULT NULL,  registration_ipvarchar(45) COLLATE utf8_unicode_ci DEFAULT NULL,  created_atint(11) NOT NULL,  updated_atint(11) NOT NULL,  flagsint(11) NOT NULL DEFAULT '0',  last_login_at int(11) DEFAULT NULL,   PRIMARY KEY (id),   UNIQUE KEY user_unique_email (email),   UNIQUE KEY user_unique_username (username) ) ENGINE=InnoDB AUTO_INCREMENT=5231 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
https://www.dropbox.com/s/2lwzt1xt9rmh89u/Screenshot 2017-02-25 00.51.32.png?dl=0
also an screenshot, here you can find the ID's - and before - 5203 you will see that there is 5190
and all users between 5203 and 5190 - not exists.

well, as you can see it's the database (mysql in this case) which increments the number. So if you have holes I'd look into mysql or mariadb. There is no code which generates this id afaik.

what do you mean "I'd look into mysql" ?

I mean that there's no code in yii2-user which increments the ID. So it must be somewhere else where you get the id "holes".
The id field it's supposed to be handled by mysql (mariadb) (AUTO_INCREMENT).
Did you override the User model?


RPC Manager: C++ Sync server redesign

C++ Sync server redesign.
There are a couple of outstanding issues to resolve

Change counters in grpc_rpc_manager.cc to atomics (This needs a bit more careful thinking that I thought. So I will be doing it as an addon to this PR)

In some cases, I am noticing that grpc_completion_queue_next() returns ok = false for the tag corresponding to  grpc_request_registered_call operation). I have not found out exactly why this happens. In anycase, I will have to handle this in Sync server. We currently do not handle this case (i.e both in the existing code and new code in this PR)

@ctiller
Renamed GrpcRpcManager to ThreadManager. PTAL

@vjpai and @ctiller - I have addressed your review comments. PTAL ?

LGTM

LGTM

All test failures are unrelated. I am merging this.


Replace an unnecessary link to the object model

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/worksheetfunction-object-excel.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/worksheetfunction-object-excel.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/worksheetfunction-object-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/worksheetfunction-trim-method-excel.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Excel-VBA/articles/worksheetfunction-object-excel.md
:white_check_mark:Succeeded

VBA/Excel-VBA/articles/worksheetfunction-trim-method-excel.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

All content in this repository has been migrated to a new repository (https://github.com/MicrosoftDocs/VBA-Docs). The changes in this PR have been applied in the new repository, so this PR is being closed. The changes will be published to the live docs soon. Thank you for your contribution!


Added event tracking for chosen currency

📲 What
The koala event tracking for Chosen Currency.
🤔 Why
Chosen Currency is part of Settings v2, but this event had been added on a PR containing events for Settings v3
✅ Acceptance criteria

[ ] I go to Settings > Account and change my currency by confirming the change on the Message dialog. The event Selected Chosen Currency should appear on Looker.
[ ] The Selected Chosen Currency  should contain a property called currency with the name of the chosen currency. E.g: € Euro (EUR)

 Add event for Chosen Currency


python310Packages.dash: 2.4.1 -> 2.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.dash is: "Python framework for building analytical web applications"
meta.homepage for python310Packages.dash is: "https://dash.plot.ly/"
meta.changelog for python310Packages.dash is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.5.0 with grep in /nix/store/hsj45a1jz2gdhjnlraw5i5hddrxvs02b-python3.10-dash-2.5.0
found 2.5.0 in filename of file in /nix/store/hsj45a1jz2gdhjnlraw5i5hddrxvs02b-python3.10-dash-2.5.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.dash
python39Packages.dash

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hsj45a1jz2gdhjnlraw5i5hddrxvs02b-python3.10-dash-2.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.dash https://github.com/r-ryantm/nixpkgs/archive/321e60b24bc477e80b5b7266953cfefe256e1396.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hsj45a1jz2gdhjnlraw5i5hddrxvs02b-python3.10-dash-2.5.0
ls -la /nix/store/hsj45a1jz2gdhjnlraw5i5hddrxvs02b-python3.10-dash-2.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.dash
python39Packages.dash

Maintainer pings
cc @antoinerg for testing.

Result of nixpkgs-review pr 176856 run on x86_64-linux 1

2 packages built:

python310Packages.dash
python39Packages.dash


Veracode static scan vulnerability - CWE 331 Insufficient Entropy

We are using jsoup 1.15.3 in our application. Our code is getting scanned through veracode security scan. It catches medium issues in jsoup 1.15.3 jar. Below are the details. Please let us know the the plan to fix this.
CWE 331 Insufficient Entropy
Flaw Category: Cryptographic Issues
Description: Standard random number generators do not provide a sufficient
amount of entropy when used for security purposes. Attackers can brute
force the output of pseudorandom number generators such as rand().

do not provide a sufficient amount of entropy when used for security purposes

But it's not used for security purposes.
Duplicate of https://github.com/jhy/jsoup/issues/994


ServiceResultApiModel data type does not match Swagger

In ServiceResultApiModel line 52, status code is an unsigned int. In the swagger document line 1043 it defines status code as int32. When using a tool to generate an SDK from the swagger documentation it does not use a data type that allows large enough status codes.
I am using the AutoRest Code Generator to generate Java. It is creating the class with an Integer. If I manually change this to Long, then it works again.

We need to look at the swagger generation using swashbuckle to see how to surface a uint.

New swagger json in master, with integer format int64 for all uint type properties.


Starting scheduler with docker-compose on main throws error: Error: An unknown argument '--config-backend' was specified.

Describe the bug
Starting the deployment in the main branch with the docker-compose option ttriggers this error:
arrow-ballista-ballista-scheduler-1  | Starting nginx to serve Ballista Scheduler web UI on port 80
arrow-ballista-ballista-scheduler-1  | Error: An unknown argument '--config-backend' was specified.

To Reproduce
Execute docker-compose up --build from main branch.
Expected behavior
Expected services to execute successfully.
Additional context
When looking at the source code, specifically ballista/scheduler/src/bin/main.rs I could not find the relevant etcd options.
Changing the docker-compose.yml line 29 from
    command: "--config-backend etcd --etcd-urls etcd:2379 --bind-host <IP_ADDRESS>"

To
    command: " --bind-host <IP_ADDRESS>"

Fixes the error and deploys successfully the containers. It does not seem like a proper solution here, as we're not effectively using the etcd service. Is there an unfinished feature in main branch?

I seem to have found the proper cause of the error. In the file ballista/scheduler/scheduler_config_spec.toml I found this block:
[[param]]
abbr = "b"
name = "cluster_backend"
type = "ballista_scheduler::cluster::ClusterStorage"
doc = "The configuration backend for the scheduler cluster state, possible values: etcd, memory, sled. Default: sled"
default = "ballista_scheduler::cluster::ClusterStorage::Sled"

Thus changing the config in docker-compose to:
    command: "--cluster-backend etcd --etcd-urls etcd:2379 --bind-host <IP_ADDRESS>"

Seems to work. I might create a follow-up PR here.


AJ-1558: Make InstanceInitializerBean azure-only

For AJ-1558: prove out how we might use annotation-based logic branches for deploying GCP or Azure-specific components.
In this case, we want InstanceInitializerBean to only be configured in Azure.
The first attempt at the annotations are introduced in CloudPlatform

In the description, could you link to the PR where you implemented annotations for reference?

In the description, could you link to the PR where you implemented annotations for reference?

Added a comment in the PR description, but the annotations are introduced in this PR  within the new CloudPlatform.java file.


please update bundle

Please update /dist.
If I include the component from pm, then older, built, version is used. To get features like enter keypress I need to copy paste source code and use it directly. Seems like older bundle contains older version

yes, noticed the same here.


Readme should not include the version number

We should not repeat the version number throughout the source.  Eventually, the download page will be http://openlayers.org/download/.

Looks good to me.


close stop chan in rollingupdate.go Stop func

fix #559
Signed-off-by: YujiOshima<EMAIL_ADDRESS>

CI passed! 😆
I hope that it will stabilize.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fixgroupci" git@github.com:YujiOshima/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353890808
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Embolden keyboard decorator associated with current unit value

Makes it a little easier to simply dismiss the keyboard without changing units, and it reenforces the unit that is at play if the user switches fields.

Git bisect points at 8f6159d08852216b4a924b52c34cdd0acf06a6b8

Fixed with #84


go.mod, vendor: update cilium to v1.14.0-rc.0

Renovate does not seem to recognize that 1.14.0-rc.0 is newer than 1.14.0-snapshot.4. Update it manually.

Seems to be already done in https://github.com/cilium/cilium-cli/actions/runs/5420254427?pr=1763


Not working/available

This command does not appear to be available under 2.26.1805.1

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ec9d15e-0cea-3966-d30c-eb7f939cb694
Version Independent ID: fcda0fff-544d-8d04-d942-e66e671f5744
Content: Add-PnPStoredCredential (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPStoredCredential.md
Service: unspecified
Product: unspecified
GitHub Login: @techwriter40
Microsoft Alias: kirks

@VesaJuvonen for your review.

Actually, it is. It's not there if you use the preview .NET standard version, but if you install PnP PowerShell from PowerShell gallery, it is included properly in the machine.


Date picker opens up after switching tabs

A simple testcase:

Select a value from the datepicker and don't click anywhere else
Switch to another browser tab
Switch back to the tab with datepicker

The date picker opens up again, even though the date is already selected.

See https://github.com/amsul/pickadate.js/issues/160


Feature/adaptive approximate algo

This feature adds the bounded approximation error state preparation (formerly called the adaptive approximate algorithm) to the qclib. The basis of the code is given in:
Entanglement as a complexity measure for quantum state preparation
Still there are issues:

documentation
tests
improve the algorithm performance-wise

Still I hope this is a valuable contribution!

-A module has been created with just the BAA routines (baa.py). So we can use it with other state preparations, isometries, and decomposition of unitaries.
-Removed the qutip dependency. It's not needed because we don't use the entanglement_measure.py module anymore.
-Several minor changes were made to conform the code style to Pylint.
-Now it includes some automated tests, but I think @carstenblank can think of some additional ones.


Driver Monitoring while driving on right hand side

Issue: In my country we drive on the right hand side of the car and I'd like to know how to make the EON knows to monitor the driver instead of the passenger.

Hi ! It's possible to do it ! I contacted you on Discord


How to send a msg from backend ??

Hi guys, I'm trying to send a notification msg to my personal number every time when the ticket meets some characteristics .
I used this function in older versions but now it's no longer available.
 const xsentMessage = await wbot.sendMessage('1234567890@c.us',"My message");
Now I tried to send it through the API using the ticket number like this:
headers: { Authorization: 'Bearer XXXXXXXXX'};  const xsentMessage = await axios.post('http://<IP_ADDRESS>:8080/messages/7',"my message body",config);
and it works but as soon as the token expires, it stops working.
How can I send my message in a easiest way??

I partially figured out , hard coded but...
in the module services/wbotservices/SendWhatsAppMessage.ts, I added this function:
...
...
/**
 * This function send a message to an specific WPnumber from the backend
 * @param num  whatsapp number
 * @param body message
 * @param tick  current ticket, it could be whatever
 */
async function sentMessagexxx (num:string,body:string, tick:Ticket){
  const wbot = await GetTicketWbot(tick); //just to let me use the function
  await wbot.sendMessage(num,body)
}

export { SendWhatsAppMessage, sentMessagexxx};

This is  to get the notification in my personal WhatsApp when someone text me to another number with Whaticket
// In the module wbotMessageListener.ts add
await sentMessagexxx("1234567890","New Ticket, check Whaticket !",ticket);

can post the file complete? i added the code in some position, and it no compile

Hi!
Same problem here..
@xmariodiaz , can you please share the files?


Fix worker metadata format

We'd like to be more strict about format for the analytics team.
We currently see this in the metrics table:
"RuntimeName": node,
"RuntimeVersion": v16.16.0,
"WorkerVersion": 3.5.0,
"WorkerBitness": ia32

Is it possible to remove the version prefix ("v") from runtimeVersion?
We also noticed the bitness looks wrong: "ia32" which should be "x86"

We also noticed the bitness looks wrong: "ia32" which should be "x32"

It's debatable what is "wrong" or right. Here's one stackoverflow post discussing some differences. Assuming you're used to windows terminology, I think it's saying ia32 is the same as x86, but not x32. In any case, here is the list of possible arch values given to us by Node.js and I'd rather not manipulate those if we don't have to

Is it possible to remove the version prefix ("v") from runtimeVersion?

Similar to above, we're just passing along the version given to us by Node.js so I'd prefer not to modify it. Sure we could remove the 'v', but couldn't the analytics team do that as well? It just feels risky if the analytics team is going to rely on these properties being in a strict format across all workers

Thanks for the info, that's totally fair and makes sense to me. I think the goal was to make this easier for the analytics team for the adoption dashboard this data is going to be used for.
cc: @fabiocav @cloudmelon @jcookems FYI

@ejizba, I think you summed it up well: should each layer pass along what the previous one gives us, or should some layer "fix" the value to make them consistent? (The Analytics will follow your example and "just pass along the version given to us" and have the next layer handle it, the dashboard in this case)
@liliankasem, I think the only reason we'd want enforce consistency would be if the Functions team wants to look at things like workerBitness across runtimes in the resulting dashboards. We might need to get Melony's input on this.
It doesn't make sense to compare versions across runtimes. In general, I'd expect that each runtime's records would only be compared with other records for the same runtime, so cross-runtime diffs probably wouldn't by problematic.
If consistency is needed, it should happen at the lowest level, where the details like Node.js's "list of possible arch values" are known, instead of relying on a third-party (Analytics) to grok those details for all Functions runtimes.

@lilyjma will sync with the PM team on this as it seems like a problem for all languages

@lilyjma let's follow up on this issue. We're trying to have items associated with this feature closed out.

started an email thread on this as it's a cross language question, not just a Node.js question

Yes. I spoke with Lily and she agreed to align with us and will follow up with Eric,
Kind regards
Melony

From: Lilian Kasem @.>
Sent: Wednesday, March 15, 2023 1:55:59 PM
To: Azure/azure-functions-nodejs-worker @.>
Cc: Melony Qin @.>; Mention @.>
Subject: Re: [Azure/azure-functions-nodejs-worker] Fix worker metadata format (Issue #633)
@cloudmelonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcloudmelon&data=05|01|Melony.Qin%40microsoft.com|02a0d9efcb83443f977008db2597ae31|72f988bf86f141af91ab2d7cd011db47|1|0|638145105632545064|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qsnvSkiqB8vear4YPNxujZCynmzoVoxU%2FRCUG9dUWpM%3D&reserved=0 any updates on how this issue is going? Has there been an agreement on format across language workers?
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-functions-nodejs-worker%2Fissues%2F633%23issuecomment-1470828805&data=05|01|Melony.Qin%40microsoft.com|02a0d9efcb83443f977008db2597ae31|72f988bf86f141af91ab2d7cd011db47|1|0|638145105632545064|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=uiIEHneggfs7LbhIlS9jRV7I2J5DYIbLv3GgVDsLEh0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABDIJ6HL6VRWOR4PQ4O5P33W4IUF7ANCNFSM6AAAAAAQ47GXZQ&data=05|01|Melony.Qin%40microsoft.com|02a0d9efcb83443f977008db2597ae31|72f988bf86f141af91ab2d7cd011db47|1|0|638145105632701745|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=vwpLw3GABSWA9YAnSMuJiywA53PtOldxVWJPgfa8pgU%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I updated the version to remove the 'v' here: https://github.com/Azure/azure-functions-nodejs-worker/pull/658. That one was easy enough so I just did it
The bitness is more complicated with nuances between .NET and Node.js, so we haven't had a compelling enough reason to work on that. After following up with me, @lilyjma started an offline thread with @fabiocav and @cloudmelon a few months ago but it did not receive a response.
Perhaps if you explained how this data is meant to be used outside of the worker teams that would be more compelling? My general view is that this information is most helpful for the language worker crew (tracking their own telemetry, investigating incidents, etc.), in which case it would be best (and easiest) to keep it in the language’s “native” format.

I updated the version to remove the 'v' here: #658. That one was easy enough so I just did it
The bitness is more complicated with nuances between .NET and Node.js, so we haven't had a compelling enough reason to work on that. After following up with me, @lilyjma started an offline thread with @fabiocav and @cloudmelon a few months ago but it did not receive a response.
Perhaps if you explained how this data is meant to be used outside of the worker teams that would be more compelling? My general view is that this information is most helpful for the language worker crew (tracking their own telemetry, investigating incidents, etc.), in which case it would be best (and easiest) to keep it in the language’s “native” format.

hi @ejizba i had a very long convo with @lilyjma about this, and I thought she talked with you already. Hi @lilyjma were you able to follow up on this ( after our convo a while back ) ? thanks!

I updated the version to remove the 'v' here: #658. That one was easy enough so I just did it
The bitness is more complicated with nuances between .NET and Node.js, so we haven't had a compelling enough reason to work on that. After following up with me, @lilyjma started an offline thread with @fabiocav and @cloudmelon a few months ago but it did not receive a response.
Perhaps if you explained how this data is meant to be used outside of the worker teams that would be more compelling? My general view is that this information is most helpful for the language worker crew (tracking their own telemetry, investigating incidents, etc.), in which case it would be best (and easiest) to keep it in the language’s “native” format.

hi @ejizba i had a very long convo with @lilyjma about this, and I thought she talked with you already. Hi @lilyjma were you able to follow up on this ( after our convo a while back ) ? thanks!

I'll let Lily follow up with more details here but the tl;dr is that the analytics team is using this data to create an adoption dashboard; last I heard is that the data is not reliable enough to start ingesting. We're working to make sure all the workers follow the same data format/contract to unblock this.


feat(GridFormTextArea): add rows to text-area field

Overview

Add the rows prop to GridFormTextArea

PR Checklist

[x] Related to designs:
[x] Related to JIRA ticket: [web-2447]
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change
[x] This PR includes testing instructions tests for the code change
[x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

View the larger TextArea in the "With tooltip" section of the GridForm story

PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

📬Published Alpha Packages:@codecademy/gamut@55.5.0-alpha.189d61.0@codecademy/gamut-kit@0.6.345-alpha.189d61.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://650494ebba445e08553cce65--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.5.0-alpha.672a74.0@codecademy/gamut-kit@0.6.345-alpha.672a74.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6504a00d851b27122d2193f6--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6509d3c3636e3d24bd1f8798--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://650cacdd7e223731bebfd9fe--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.5.0-alpha.30133e.0@codecademy/gamut-kit@0.6.345-alpha.30133e.0@codecademy/styleguide@66.3.0-alpha.30133e.0