Disable/Remove image upload

Summary
Is there a way to configure the editor / toolbar to show only the image url, but not the image file upload?
Screenshots

Version
2.4

I'm also looking for a solution to this. Is it possible to somehow pass custom template in here?
https://github.com/nhn/tui.editor/blob/a79dd97d453e62d3a3d858ec84fda6551572febf/apps/editor/src/js/ui/popupAddImage.js#L30

@iacobson
There is currently no option to use that feature. The template mentioned above is also not exposed to the outside. So, an option should be added to the editor and I'll consider this.

Thank you for the response and for considering the option!

wish

It is not a solution but it is fine to hide it if a special function is not assigned for the image upload tab.
Just add some CSS.
/* TUI Editor show only image linking tab in popup */
.tui-editor-popup{
    box-shadow: 0px 0px 15px 5px rgba(0,0,0,0.26);
}

.te-popup-add-image .te-tab button, .te-popup-add-image .te-file-type{
	display: none !important;
}

.te-popup-add-image .te-url-type{
	display: block !important;
}

Result:

Actually there are to many issue, missing part and feature. I am using for comment form and this way acceptable for now.

It is not a solution but it is fine to hide it if a special function is not assigned for the image upload tab.
Just add some CSS.
/* TUI Editor show only image linking tab in popup */
.tui-editor-popup{
    box-shadow: 0px 0px 15px 5px rgba(0,0,0,0.26);
}

.te-popup-add-image .te-tab button, .te-popup-add-image .te-file-type{
	display: none !important;
}

.te-popup-add-image .te-url-type{
	display: block !important;
}

Result:

Actually there are to many issue, missing part and feature. I am using for comment form and this way acceptable for now.

@iacobson There is currently no option to use that feature. The template mentioned above is also not exposed to the outside. So, an option should be added to the editor and I'll consider this.

@seonim-ryu Did you consider? Will you add this to config?

CSS solution does not work anymore.
Will you add this config option to disable image "uploads"?

I too am looking for this functionality.  I'm close to being able to create a simple popup replacement, but not sure how to implement the onClick functionality to insert the values into the editor.  Here is my code so far:
window.editor = new toastui.Editor({                                 el: document.querySelector('#markdowneditor'),                                 height: '98vh',                                 initialValue: text,                                 initialEditType,                                 previewStyle,                                 previewHighlight,                                 autofocus                             });                             window.editor.removeToolbarItem('table')                             window.editor.removeToolbarItem('image')                             let insertBodyHtml = document.createElement('div')                             insertBodyHtml.innerHTML = \
Insert URL

Alternate Text

Cancel

Insert

`
window.editor.insertToolbarItem({ groupIndex: 3, itemIndex: 0 }, {
name: 'imageUrl',
tooltip: 'Insert image',
popup: {
body: insertBodyHtml
},
text: '',
className: 'image toastui-editor-toolbar-icons',
style: {  }
});`

update, I'm closer with following:
<button type="button" class="toastui-editor-close-button" onClick="javascript:document.querySelector('.toastui-editor-popup').style.display = 'none'">
                                        Cancel
                                      </button>
                                      <button type="button" class="toastui-editor-ok-button" onClick="javascript:window.editor.exec('addImage', { imageUrl: document.getElementById('imageUrl').value, altText: document.getElementById('imageAltText').value }); document.querySelector('.toastui-editor-popup').style.display = 'none';">
                                        Insert
                                      </button>

This works once, but not the next time because im not changing the popup state, just modifying the css to be hidden.  If there is a way to hide the popup then this approach should work

ok, this version is working as expected. Here is final working code:
               window.editor = new toastui.Editor({
                                el: document.querySelector('#markdowneditor'),
                            });
                            window.editor.removeToolbarItem('image')
                            let insertBodyHtml = document.createElement('div')
                            insertBodyHtml.innerHTML = `
                                    Image URL
                                    <input
                                      id="imageUrl"
                                      type="text"
                                    />
                                    Alternate Text
                                    <input
                                      id="imageAltText"
                                      type="text"
                                    />

                                      <button type="button" class="toastui-editor-close-button" onClick="javascript:window.editor.eventEmitter.emit('closePopup'); window.editor.focus();">
                                        Cancel
                                      </button>
                                      <button type="button" class="toastui-editor-ok-button" onClick="javascript:window.editor.exec('addImage', { imageUrl: document.getElementById('imageUrl').value, altText: document.getElementById('imageAltText').value }); window.editor.eventEmitter.emit('closePopup'); window.editor.focus();">
                                        Insert
                                      </button>

`
                            window.editor.insertToolbarItem({ groupIndex: 3, itemIndex: 0 }, {
                                name: 'imageUrl',
                                tooltip: 'Insert image',
                                popup: {
                                    body: insertBodyHtml
                                },
                                text: '',
                                className: 'image toastui-editor-toolbar-icons',
                                style: {  }
                            });

need this too =.=

I do not have the 2.4 (only 3.0) but the general idea should work with any version, any framework, just check the classnames we're referring to in the code. When the editor is loaded, set up a MutationObserver (has a pretty good browser support) for the target class ".toastui-editor-popup " (there is a space character at the end of it!).
This will run a function when a popup opens in the editor (which is just a display style change on the element - that's what we're watching for with the observer). We need to filter more to avoid errors, and make sure it only runs when the popup div's classname is ".toastui-editor-popup.toastui-editor-popup-add-image", meaning you've clicked on the add image button and not any other tool that displays a popup (like headings, insert table).
Since the upload from file is selected by default, within this function we can programmatically switch to the URL tab, then hide the File tab's button.
window.onload = () => {
    const observer = new MutationObserver(() => {
        if (document.querySelector('.toastui-editor-popup.toastui-editor-popup-add-image')) {
          document.querySelector('[aria-label="URL"]').click();
          document.querySelector('[aria-label="File"]').style.display = "none";
        }
    });

    const target = document.querySelector(".toastui-editor-popup ");
    observer.observe(target, { attributes: true, attributeFilter: ["style"] });
  }

window.addEventListener('click', (e) => {
    if(document.querySelector('[aria-label="File"]')) {
        document.querySelector('[aria-label="File"]').style.display = "none"
    }
})

Works fine, just without using mutation observers for performance
just change the aria label to URL instead of File for url image uploads

This works for me: it simulates a click to the URL tab and hides the File button.
window.addEventListener('click', (e) => {
	var element = document.querySelector('.toastui-editor-tabs .tab-item[aria-label="URL"]');
	if (element) {
		element.click();
	}
	if(document.querySelector('[aria-label="File"]')) {
		document.querySelector('[aria-label="File"]').style.display = "none"
	}
})

Any progress on this issue? Would be great to have the fix done by @JuliaCasamitjana


Update NL embeddings eval playground

Remove golden stat vars and eval scores since these are not practical and reliable.
Updated this into a playground that can upload sv descriptions and queries on the fly and check stat var matches. The matches can highlight stat vars that have override descriptions.

Wonder if we should have the query textbox before the  NL description textbox?  Because I can imagine this playground is helpful to try queries to see the variable matches for different models, as well, optionally, override/add NL descriptions?
Wonder if it might be good have a few lines to articulate what to do with the tool?

This playground can be used explore the variable matches given a few queries for different models. Additionally, you can also override or add NL descriptions for variables.

Swapped the order. I put the suggestions as text area instruction explicitly now.


Add Flashbots to Kallisto FE transactions

As Kallisto team, I want all transactions for the Uniswap and Curve APY chaser vaults to be protected from sandwich attacks by going through Flashbots
Acceptance Criteria

[ ] All vault transactions are going through the Flashbots relay https://docs.flashbots.net/flashbots-auction/searchers/quick-start

users will need to use RPC endpoint


Implement Tasks

Okay maybe we didn't think it through enough. So what?
The idea is simple, rather than doing whatever it is we are doing now (I'm not trying to pretend that I understand any part of the system whatsoever), "tasks" should tell us what to do with a file (are you asking how is it going to work with the existing plugin callbacks? I don't know either).
So a build has different tasks it has to do before successfully ending:
include --> minify --> package --> upload

This is always a linked list, not a dependency tree or a cursed bidirectional graph. Nope. Keeping things simple should be our new motto.
Each task feeds into the next, which makes it look like the whole thing should be called a pipeline rather than a "build". That's not the case, at least not at the moment. A build has tasks it runs on pipelines, one pipeline is spawned for every processed file.
The Terrible Tasks to Tackle
I think we can get inspired by Howl. What should we call the part which processes a stream and all its directives though? Howl calls that task "build". Yeah. Damn it.

Ultimately, for each input file, we need to take the content, do stuff with it, poop out a Lua AST, then merge all the different ASTs together with some extra magic.
I think we've got the file lookup functionality sorted already. Protocols, plugins, that's all neat.
After that, you make a pipeline with the URI and mode generated by the file lookup. I think there are now the following stages to the pipeline:

Preprocess - do stuff with the entire file's content, if necessary. Then directives and a few callbacks like ignore handled by the lexer.
Parse - a single function called to parse using the lexer generated, generating an AST. One per file mode?
AST modification - plugins get to mess with the AST however they like. Want to replace a node? No problemo. Want to remove a node? Sure thing. Want to add a load of code in? Why not.

After this I'm not so sure. Previously, the plan was to compile to Lua and poop out the result, but that wasn't considering that there would be many files. The pipeline is pretty exclusive to just one file. What about a plugin that checked for global references? How would it know if it was referring to a definition in another file or something. It gets complicated here, but I'd suggest some way of turning (list of pipelines) into (one pipeline) and having callbacks in the process and after the process. Then compiling the AST to Lua.

Yeah okay, merging files should happen after AST modification. (Speaking of which, plugins should have a means of using the parser that pooped out the AST to add nodes of their own (best if such a method would be also available overloaded on the AST itself, like node:add_child "foo( 'this gets compiled during AST modification' )").)
How to call the pipeline merging process and therefore also the callbacks is just a matter of convention. pipeline.merge_pipeline_before/after_callbacks? I don't really know, just making this up as I go along.
Regarding the global reference plugin, while it is a neat idea I'd argue that its success rate very much depends on where it is imported to, and since that can be multiple locations, I wouldn't worry about it now (the plugin itself can define a directive to specify which variables it should ignore, etc).

Oh yeah definitely, although I'd argue that some of the same AST callbacks are invoked before and after the merge. Some (notably optimisations) would benefit from being done after the merge, as well as before.
I think it'd be more like node:add_child( pipeline.parser:parse_expression( "blahdyblah" ) ), but yeah that's a good idea. I also think there should be a simple way or remapping specific variables so you could do something like parse( "f( x )" ):replace( "x", myexpr ).
It's more the functionality of the callbacks that I'm concerned about. Also, how will inter-file dependencies work? If I want to include a library, will it use the standard, local lib = {}; ...; return lib? If so, should the include syntax look as follows: --@include X as Y? I really don't know about this one. In v1.0, there was a way to localise certain variables at the top, and then it could just define them, with the code being stuck in the middle of other files. Idk. Suggest things.
The global reference plugin is one of those ~essential ones imo. It's an example showing the ability to use what I think is a powerful and important ability of the build system.

The more metamethods, overloads, and shortucts there are, the better. Does it hurt if the AST has a reference to its parser? (In the case we're talking about, it doesn't actually need to access the relevant pipeline if it can get the parser reference from elsewhere.)
I guess it could be smart about libraries that do return foo at the end, but error if @include foo as bar doesn't succeed. The as * part should definitely be optional.
I was actually thinking about it as a real time linter. Nevermind.
I'd implement this by simply running the plugin only after all pipelines have been merged. That way it'll report on the actual global references.

I tend to go for a minimal AST so that it can be serialised easily. It also makes it easier to do things like return { type = "Blah", value = blah, .... } but I guess that's bad practise anyway. I think it's just the bloat that I don't like.
However, the AST really is just a storage of the syntax of the file. It's not really related to the parser. Ultimately, everything will end up being Lua, so would the AST have its parser pointing to the Lua parser, or the parser that generated that Lua AST? (e.g. MoonScript or something)
Plugins would be the things doing the AST modification, and those would have access to the pipeline or some object that referenced the parser, I'm sure. Or it could just directly refer to the parser. See below, regarding inter-plugin communication.
How would that not succeed? Also, "be smart" sounds scary, unplanned, and hacky. This needs to have really clear and defined behaviour.
I'd suggest that all files are wrapped in a local __unique_identifier_1 = (function() ... end), with another unique identifier used to store the result. In the place of the @include in whatever file, it ensures the dependency has been loaded already, then copies the latter unique identifier to the local import name. So...
--@include myfile.lua as myfile

__ID_3 = (function()
    if not __ID_2 then
        __ID_2 = __ID_1() or true
    end
    local myfile = __ID_2
end)
__ID_3() -- called as it's an entry point

My example of a global reference lookup thingy was bad. Basically, I dislike how plugins operating on the file pipeline won't be able to know anything about other files/pipelines. It might not be an issue, I guess we'll run into it later on if it is.
Inter-plugin communication
Plugins should be able to talk to eachother and share features. I think, given that multiple file modes will be supported (say, for different languages), plugins themselves should register the parser for that mode. This will make it much much easier to have precompiled packages later on (see #6). As parsers are implemented by a plugin, other plugins should be able to refer to that plugin and 'ask' it to parse things. There are undoubtedly many other occurrences where exposing public methods will be important. So, a plugin will have a private state, and public set of methods, for any stage in the pipeline.

Note, we really need to work on the terminology, I'm getting really confused already.

Good point with the AST scoping issues, I didn't think of that. Let's leave the parser link in the pipeline then.
"Be smart" is certainly none of those. Basically, if the file ends in a return statement with a single child that is also not a constant, it uses that child as the library:
-- foolib.lua
local foolib = {}

function foolib.bar()
    print "asdfmovie rulez"
end

return foolib

-- unicorn_land.lua
-- @include foolib.lua as greatness

greatness.bar()

-- unicorn_poop.lua
-- IR identical to the compiled output of unicorn_land.lua
local greatness = {}

function greatness.bar()
    print "asdfmovie rulez"
end

greatness.bar()

In case unicorn_land.lua's as greatness fails (foolib.lua puts functions into the global scope, for example), an error is raised. If the @include clause were only -- @include foolib.lua, the library would be wrapped in a function and included nonetheless.
Is that scary, unplanned, or hacky? I think it's pretty intuitive.
Inter-plugin communication would be nice, but do we actually need it? I don't know how to structure the plugin API for that either... I think we should implement this on-demand, anyway, that should help us understand the issue from a plugin-developer's perspective.

I made a flowchart illustrating how this should all work. https://drive.google.com/file/d/0B37gxkuD6apmS3lvLXFFUHRQbnM/view?usp=sharing

Anyway, the issue with your example is the fact that many different files may try to include, say util, and potentially as different things, --@include util.lua as _util, --@include util.lua as utils, etc. This means you can't just rename foolib in your case. However, it could be an optimisation applied by a plugin to see that greatness always referred to foolib and thus replace references of greatness with foolib. This also prevents some file doing utils = {} and messing up every other file that included the util file.
I think @include X (no as Y) should default to having X determine the name to import it as. For example, @include X.lua would implicitly function as @include X.lua as X. There's potential for things like @include -g X.lua for including it as a global-defining file or something.
One issue I see with this is that a file's type is dependent on the file, not how it's included.  Maybe just a universal @include X.lua and then something like @filemode "library" inside X.lua to determine how it's loaded/inserted into various environments.
Inter-plugin communication should be pretty easy. pipeline.plugins.PluginName.func()? I guess if we have plugin names something like namespace.plugin (e.g. lua.linter, moonscript.linter), that would need more processing, but using _ for namespaces or just doing wizardry to allow pipeline.plugins.namespace.PluginName.func() are both possible.
Let's seriously review the terminology soon. I'll make an issue in a sec.

the issue with your example

I suspect you mean this would cause issues when multiple files renaming a resource were a part of a single compiled output? I wanted to make the example readable, so I didn't apply optimisations and unique identifiers (and instead included the comment saying that while the code differs from the compiled output, its meaning is identical), which would of course be present in the final result.
What I wanted to stress out was the absence of a function wrapper in these cases.

Ohkay. So similar to what I said but without the wrapper? I'd agree but some files might be awkward, like
if boop then
    return blah
end
return bleh

Although trivial for a person (or even a decent code analyser) to handle, the (hopefully quite simple/basic) file merger wouldn't be able to handle that, and a function wrapper would be necessary. Having a separate way of handling files ending in a single return statement can come later. Having a wrapper handles any situation.
What did you think of @filemode and the inter-plugin communication suggestions?

I'm thinking of having something similar to the following:
local t = Task:new( "Parse" ):on( "Stream" ):returns( "AST" ):precedes( "MacroExpand" ):follows( "Preprocess" ):does( lua.parse )
plugin:register( t )

A pipeline would be a composition of tasks. However, there needs to be a looping mechanic where e.g. the AST could be modified and perform previous tasks (e.g. optimisations) on the new AST. I guess the pipeline could be copied from the first point that accepts an AST and run with the new data until the last point it returns an AST? So it's just the changed node that is re-run?

The suggested inter-plugin comms seem fine (which may be just because I don't know how I'd put them to a good use, tbh, but I don't see any issues with your proposal).
@filemode feels kinda hacky... Other Lua build systems and preprocessors simply inline the included files (frequently they literally do just that). Also I wouldn't expect the user not to read a tutorial on how to include libraries, so is it really necessary?
You're right, a function wrapper is guaranteed to work in either case.

Okay, I guess we'll roll with that. What namespace naming convention should we go with?
@filemode could default to something sensible, but it does give more control (and in the right place, imo).


Fix Frontend Action

This PR fixes the frontend action by adding a ci test configuration to the angular configuration.

@benedictweis FYI: Chrome Headless is now working on the runner, so the action should now work.


Added gzip functionality to index map

Hey,
I added some functionality that I need to index maps. It is gzip compressing.
If provided "gzip" option to createSitemapIndex sitemap index will generate gzip compressed xml files.
Instead of "sitemap-0.xml" -> "sitemap-0.xml.gz".
I only wonder if we should generate also regular XML files in this case?

Great patch! Thanks!

I only wonder if we should generate also regular XML files in this case?
Have no idea.

Can you please, create release with this PR?

Done:

https://github.com/ekalinin/sitemap.js/releases/tag/1.4.0


Setup deployment pipeline with Github Actions

Github actions should be used to:

[x]  build and test pull requests
[x]  deploy Storybook projects to Netlify
[x]  Deploy packages to npm

Closed with #131


Find tsconfig.json by traversing up

This should fix #238

This doesn't work yet

Awesome work! It'll be really nice to get this in.


Evaluate terraform for visual tests

Please check if it makes sense using terraform together with GCP and spawn GCE Instance in order to run visual tests (cypress and percy) during branch builds as well.

https://github.com/deliveredtechnologies/terraform-maven

Awaiting https://github.com/deliveredtechnologies/terraform-maven/issues/240 and https://stackoverflow.com/questions/64834935/assign-terraform-output-to-environment-variable
Start alternative pulumi evaluation in #113, which seems to support TS

Option is not viable for automated tests because of complexity and high costs for static ip. Also provisioning time is relatively big, so branch builds will take a lot of time. Stick to heroku at the moment and use terraform for show-case on demand


fix review note storage

This fixes an issue where the review notes were not actually being stored in the database once the in-memory objects were updated.

Codecov Report

Merging #189 (1166947) into main (bd36556) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 1166947 differs from pull request most recent head 582a652. Consider uploading reports for the commit 582a652 to get more accurate results

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   36.50%   36.50%
=======================================
  Files          37       37
  Lines        3682     3682
=======================================
  Hits         1344     1344
  Misses       2098     2098
  Partials      240      240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd36556...582a652. Read the comment docs.


Replace method reference to lambda in DefaultConfigParser.

Summary

Replace method reference with lambda in DefaultConfigParser

A recent change broke the selective class instantiating capability.
Test plan
Run the java-quickstart example.
Issues

OASIS-5052

Pull Request Test Coverage Report for Build 1142

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.624%

Totals

Change from base Build 1140:
0.0%

Covered Lines:
3576

Relevant Lines:
3990

💛  - Coveralls


Reduce default requests for cpu to 10m and change to QoS

https://github.com/stakater/application/blob/master/application/values.yaml#L213-L220

reduce to 10m
reduce to 50MB

and set same limits

@d3adb5 @aslafy-z any thoughts/comments about this one?

Usually Helm charts don't set resource constraints by default, so that chart users may size the applications up to fit specific deployments. The preferred QoS class is also highly dependent on each deployment.
Since this project is meant as a generic Helm chart for stateless applications following a specific set of criteria, I'd avoid setting constraints by default to make it as easy as can be for anybody to use the chart.


Update AccessRule.php

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
no

according to https://github.com/frontbear/yii2/blob/master/framework/filters/AccessRule.php#L28, code ? true : false  is not necessary

Don't do this. AccessRule::$allow can be null, and the null return has a proper meaning in the allows method.

I think that change could be dangerous.
The current implementation ensure the boolean return;
For example, if AccessRule::$allow is null, it will cause a improper behavior, because null return has a different meaning in the allows method.

@berosoboy i see, thanks.


Unable to add MP3 Media Assets

Hi folks,
I'd like to report a bug which I determined yesterday (see Forum thread).
In the latest version of the game studio (<IP_ADDRESS>), it is not possible to add MP3 media assets as described in the documentation (Import audio). As soon as the required MP3 file is selected in the file browser, the following error message appeares:
Error: An exception occurred while generating the template.. System.OverflowException: Arithmetic operation resulted in an overflow.
The error message appeares when choosing "Music", "Spatialized" as well as "Sound effect" assets.
WAV format seems to work (I converted my MP3 files to it), I didn't try the other supported formats yet.
Best, GS

I did a quick investigation and it seems like for some reason ffmpeg believes there might be a video stream and then when trying to decode it computes a NaN which causes the exception.
I will push a quick hotfix, but we need further investigation to properly fix it. The thing is that ffmpeg library is quick obscure and hard to use and its documentation is not always helpful (if not confusing).
Note: we use ffmpeg to extract audio/video frames from the resource files.


Adjusting the html of intercom widget

For some reason, the Intercom button on my page has the class .intercom-acquire (and associated styling) when I manually include the script provided on my Intercom integration dashboard. However, using the gem to integrate Intercom, that class and styling are missing.
Is there a way to, using config options, specify that the HTML should include that class? Otherwise, how can I have jQuery listen for the Intercom widget to finish loading so that I can add the appropriate classes using JS?

Hi, you need to tell intercom-rails to include the acquire widget using this config setting:
config.include_for_logged_out_users = true

Hope this helps.


There is no question mark option in the drop down menu for remaping keys

Microsoft PowerToys version
v0.69.1
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
Keyboard Manager
Steps to reproduce
There is no question mark option in the drop down menus for remaping keys or shortucts.
✔ Expected Behavior
That the question mark option would be available
❌ Actual Behavior
The question mark option is not in the list. Neither is the VK code.
Other Software
No response

What keys do you normally press to get that character?

Shift + /

Exactly: two keys. That's called a shortcut. 💡

Ye ik, but you cannot create a shortcut to do a question mark, when the question mark isn't available

The type it :)

I literally cannot, thats the problem

And I cannot copy and paste the character onto it either.

Ye it does not work. The key is coming up as Unidentified. I can choose the 'Shift' and '/' from the dropdown menu. But I cannot choose the question mark, which is what I need. Hence why I am reporting it.

Note that there are two forward slashes listed in powertoys keyboard manager when setting up a shortcut.
The second one is used to type a question-mark ( ? ) as you would when normally pressing shift+/  on qwerty keyboards.
Not the most intuitive when trying to replicate the character output of a broken key (a key you cannot press to create a shortcut to itself).

Windows doesn't support many true-keys (non-keyboard-layout-keys). For example, there is no question mark in the vk codes. These are meant to be virtual key codes independent from the keyboard hardware. But the way Windows expects you to describe the question mark is with shift + slash. So I believe that the vk codes fall short of what they try to deliver.
There are two ways to describe a key press and outcome

The hardware key combination that describes the event.
The key symbol that is intended.

Windows has never fixed this situation and it likely never will. Much of Windows is now frozen in a dilapidated state. This problem even carries over to other projects, such as Powertoys.


Can I use jsdom to test my choo app?

Curious.. can testing be done with jsdom  on a choo app especially with testing dom changes

jsdom is a pretty limited subset of what a normal dom looks like; so
probably not for everything - though you could definitely try it out.
Personally I wouldn't really go there, as the DOM is usually only needed
for side effects / rendering - and with .toString() and model testing, most
test cases should be covered for anyway :D
On Sat, Nov 5, 2016 at 3:08 AM rollymaduk<EMAIL_ADDRESS>wrote:

Curious.. can testing be done with jsdom on a choo app especially with
testing dom changes
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yoshuawuyts/choo/issues/311, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlevLhq0EnAalrLuta01gaomzPeohFks5q63SigaJpZM4Kp1aq
.

thanks... I decided to go with jsdom because I keep getting errors for choo components with the onload event attached to them.. something to do with restrictions with code having strict mode

I've used jsdom to test choo apps - here's an example.


fix test case due to swagger update

swagger pr: https://github.com/Azure/azure-rest-api-specs/pull/8056

this test case cannot pass CI because new SDK was not check in yet,
new sdk cannot be compiled because of the test case failed,
maybe I should mark this as skipped?

Closing as we can do this at the same time as new SDK is checked in


CZ nuclear power

Nuclear power appears in the CZ generation mix in the no-nuclear scenario.

[ ] Check if there is a new PP or one that is under construction.

There appears to be two new reactors planned at the Dukovany NPP (reactor 5 and 6). Sources such as EC, IAEA, Reuters and CEZ have highlighted these plans.
In general, they propose the tender to be chosen by 2024, a construction start by 2029, and first power to the grid by 2036. The total installed capacity of these two new reactors is planned at 1200 MW each.

[ ] Add 2000 MW of Nuclear in HU by 2030.

[ ] Add 1200 MW of nuclear in CZ by 2036. Do not include in the lim-nuclear scenario since it has not started construction and is not planned to start in the next 7 years.


Flush buffer and set active state properly

This should fix #75.
I believe the main issue was that ping/1 was always setting the active state of the socket to :once, but it should be set to what it was before changing it to false.
I was also told that you need to flush the buffer, so I decided to do that as well.
I would write a test for this, but I really don't know how to.

Thank you!


Needs to be updated with relativePath property (instead of the "uri" property) in templateLink object

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02fc2654-e6e1-12f9-6efc-696dcc407e7f
Version Independent ID: b541405a-d07b-606f-d943-a5f1bec174cf
Content: Tutorial - Deploy a linked template - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/deployment-tutorial-linked-template.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@StephenWeatherford Thanks for your comment! We will review and provide an update as appropriate.

@StephenWeatherford Thanks for submitting this issue. Please provide more details about your request to update the templateLink object in Tutorial: Deploy a linked template. For example, did you notice an error message when using the sample or the sample didn't work as expected?
When I reviewed the issue I found some information that might be helpful:

For Microsoft.Resources deployments, the templateLink object accepts uri or relativePath. In the section Create a linked template the highlighted code sample that uses the uri property appears to be correct. The preceding paragraph mentions the template is stored in a storage account and uses the URI in the linkedTemplateUri parameter.
The Tutorial: Create a template spec with linked templates has an example that uses templateLink with relativePath.
Azure Resource Manager template specs includes a section Create a template spec with linked templates that mentions relativePath.

@StephenWeatherford - Thank you for the suggestion.  I will update the tutorial.

@StephenWeatherford - the article has been updated.
#sign-off

#please-close


fix(helper): fix fs.stat in v1.41.0

:tada: This PR is included in version 3.0.4 :tada:
The release is available on:

GitHub release
Atom package

Your semantic-release bot :package::rocket:


chore: bump primitive types

as title - blocked on https://github.com/rust-blockchain/ethereum/issues/39

When will this PR be merged, the blocking issue has already been done.


Dates gets squished when switching back to month from Week

Code Used
//MARK: FSCalendar Bounding Refresh
func calendar(_ calendar: FSCalendar, boundingRectWillChange bounds: CGRect, animated: Bool) {
    calendarBaseViewHeightConstraint.constant = bounds.height
    calendar.reloadInputViews()
    self.view.layoutIfNeeded()
}

DispatchQueue.main.async {
        self.MyFSCalendar.setScope(.month, animated: true)
 }

use aspect ratio 4:5 - in other cases it wont draw correctly


x/playground: allow selecting supported versions of Go

Motivation
Go Playground was introduced in 2010 [1] and provides a great service that not only allows Go users exploring code snippet of Go but also supports all online document examples.
However, the playground only supports the latest version of Go, which may cause an issue: A code snippet was written and shared in Go 1.x. Over time, its shared link may have corrupt running result if Go 1.y (where y > x) introduces forward or backward compatibility issues.
The other example appears in tip.golang.org. The tip.golang.org illustrates the latest beta version of Go, but only uses the latest stable release of Go. If the latest beta contains API changes, the document example will be corrupted. E.g. the example [2] regarding API errors.As corrupts in Go 1.13 betas.
 This enables Go users being able to share code snippet with a specific version of Go, as well as powering beta document release in tip.golang.org.
Other consideration

Go is under the transition to Go 2, and considerably, future Go versions will introduce more API changes, especially if Generics feature is released (e.g. package sort, container and etc.)
Such a feature allows Go users to share and compare results in different versions.

It is worth mentioning that Compiler Explorer [3] is a famous tool that shows the assembly output of C++ compilers which allow C++ users to explore language changes and performance tunning process. There is already an online version exists [4] which dedicated for Go with few limited supported versions. But this may be an advanced feature that does not need to all Go users.

Services that rely on the Go Playground need to adapt to the changes of Go Playground.

[1] https://blog.golang.org/playground
[2] https://tip.golang.org/pkg/errors/#As
[3] https://godbolt.org/
[4] https://go.godbolt.org/

Thanks for the proposal.

A code snippet was written and shared in Go 1.x. Over time, its shared link may have corrupt running result if Go 1.y (where y > x) introduces forward or backward compatibility issues.

Go does not break backward compatibility (see https://golang.org/doc/go1compat), so in practice this should not be an issue. A correct piece of code that compiled on go1.5 will still work on a playground that is on go1.13
Forward compatibility is also not really an issue. Yes, you may have some runnable example on tip.golang not work for a few weeks, but tip.golang is not the website you should visit anyway. It's just a staging place for the upcoming website. Once the a new version is released and the website at golang.org is updated, the playground will be updated too and the runnable examples will work.
The only practical use of a multi-version playground I can imagine is to compare the generated machine code on different Go versions (e.g. to demonstrate better optimizations or show a regression), since that is not stable among Go versions, and can change; but the playground does not support disassembling anyway (and I think it would be out of scope), moreover you can use godbolt for that (it's literally its point), which already support all the old Go versions.

@ALTree Thanks for clarifying backward compatibility promise. I awarded it and that is why I added "Other consideration" with Go 2 paragraph. However, as long as future Go 2 breaks the backward compatibility, the code snippet shared in Go 1 will break.
Moreover, another use case for supporting all versions of Go can help Go user exploring bugs of Go. For instance, a code snippet that illustrates a compiler or runtime bug in Go 1.x, but the bug was fixed in Go 1.y (where y > x). Therefore, the code snippet can lose its interpretability of the bug.

For instance, a code snippet that illustrates a compiler or runtime bug in Go 1.x, but the bug was fixed in Go 1.y (where y > x). Therefore, the code snippet can lose its interpretability of the bug.

This is true but to be honest it doesn't seem a use-case that compelling.
The observation about Go2 is more interesting, and I agree that if a future Go2 breaks backward compatibility then we'll want to have a playground that supports at least 1) the latest/current version and 2) the latest Go1 version.
But this is quite different from what you were asking here in the original post (support of every Go1 version). If this is just about a dual Go1/Go2 playground, it seems premature to worry now.
cc @andybons

But this is quite different from what you were asking here in the original post (support of every Go1 version). If this is just about a dual Go1/Go2 playground, it seems premature to worry now.

@ALTree I think there may have some misunderstanding between Go 1.x and Go 2.
The reason I keep uses Go 1.x rather than Go 2 in the Proposal section because all announced articles [1, 2, 3],  delivers the message that the Go 2 may never be annotated as the official name but arrives in several different releases of Go 1.x, e.g.  This is actually the reason I mentioned in "Other consideration", starting from Go 1.11, "Go is under the transition to Go 2".
Towards to have two separate Go1/Go2 playgrounds: if the APIs to Playground is designed well and clean for two incompatible versions of Go, then it is not that difficult to support all versions of Go, isn't it? Unless we arguing support all different versions of Go are wasting of server resources. However, this isn't true because VM nowadays scales in seconds upon requests.
[1] https://blog.golang.org/toward-go2
[2] https://blog.golang.org/go2-next-steps
[3] https://blog.golang.org/experiment

Now that we can specify the language version in go.mod file and the compiler's -lang flag, it kind of already does: https://play.golang.org/p/B4ARI9cL3A4

What you are describing is a lot of work for the Go team, because we run play.golang.org, for diminishing benefit. Actually keeping old versions of software running is non-trivial effort.
And as multiple people noted, backwards compatibility means that there's not much difference
between the latest and the older ones.
If someone wanted to run a different site that had all the versions, that'd be great. But the cost-benefit here for the Go team does not seem like it works out.
This seems like a likely decline.

Just revisited the proposal: the proposal didn't provide enough impact to the community and didn't consider the future costs of maintaining the feature, which solves a trivial problem but creates tons of potential problems.
Agree on "clear rejection".

@bradfitz points out that the current playground backends do already support selecting between different compiler trees. Especially given #34536, maybe we should support the last two releases? What's missing is UI to select a specific version.
To be clear, this would only be supported versions, not all versions. With that restriction, the burden may be less.
We could possibly also add tip, but that would require more work in the backends to refresh tip regularly.
It is still unclear who would do the work, but at least limiting the proposal to supported versions would address the ongoing burden. We could accept this and move it to Backlog until someone is interested.

Sorry, this was meant to go back to Active earlier, not Accepted.

Going in the opposite direction from supporting older versions, how difficult would it be for the Go playground to provide the ability to run Go code using CLs uploaded to Gerrit? E.g., could the trybots automatically build a compiler-tree artifact and store it in GCS somewhere that the Go playground can use (maybe for N days or until the CL is merged or something, to limit storage costs)?
I've seen projects that will generate a preview website for each active PR so reviewers can easily see the results. Occasionally, when reviewing compiler CLs, I want to double check that it still handles some cases correctly; currently I'll typically download the CL and build/verify myself, but this is inconvenient sometimes. Also, I like uploading proof-of-concept CLs for language change proposals; it might make it more accessible to non-project-members (folks who aren't used to downloading Gerrit CLs and building locally) if they could experiment with these via the Go playground.
If this is at all reasonable, I can file a separate proposal to discuss this further. But if scaling the playground from supporting <10 versions to 100s of versions is going to be technically prohibitive, then I'll leave it be.

Matthew, the builders already do store the result of make.bash to GCS. Forever. For years now. Unless something changed recently. So probably wouldn't be hard to grab an alternate tarball from the network.

@bradfitz Sorry I'd like to get this ticket done, but I do not quite understand how the old CLs 195983 and CL 227351 supports multiple versions, especially here
https://github.com/golang/playground/blob/352556d2eef94293aa492d75a4a7414ed647cc3d/sandbox.go#L470

What's the backend endpoint to support frontend fetch supported go versions?
How does /usr/local/go-faketime/bin/go be able to build multiple versions? should there be, for example, go1.14.7-faketime/bin/go, /usr/local/go1.15-faketime/bin/go, gotip-faketime/bin/go for different version builds?

I think it would be enough to support the two latest a
versions, as well as the tip for experimenting with new language features, in essence 1.18 generics.

I realize that I'm a bit late to the discussion, but I had a thought. The Playground has the ability to use remote dependencies, though it seems that it's started printing out go vet warnings because of the go.mod not being tidied. Much like the version of Go itself, it would be nice to be able to pick versions for dependencies. Would it be feasible to deal with both birds by making it possible to just directly edit the go.mod file that the playground is using for the compilation?

@DeedleFake that's already possible, an example is selecting the multiple files example

So it is. I had no clue that that feature had been added. Neat. Thanks.

I believe this proposal is implemented now and live at https://go.dev/play since https://github.com/golang/website/commit/13fd0169c532e13fbcc57b3abf0f03ee49c2fa8b. Therefore I am closing this issue. If not, feel free to reopen this again.


Use previously unused FileStorage service

The FileStorage service wasn't added to the service collection. This PR adds it.

I stole this fix as part of https://github.com/loic-sharma/BaGet/pull/159, so this PR is no longer necessary 🙉


Yaml to Rails (action_dispatch, action_view, options

I'd like to write yaml settings like this :
development:
  action_mailer:
    perform_deliveries: true
    raise_delivery_errors: false

That would translate in Rails's config block to :
config.action_mailer.perform_deliveries = true
config.action_mailer.raise_delivery_errors = true

Could that be possible ?

Unfortunately not. Your yaml settings example would translate roughly to this:
config.action_mailer = { perform_deliveries: true, raise_delivery_errors: false }

Which is similar but not equivalent, because it overrides any other settings previously made to config.action_mailer (e.g. default values, or settings in other files).
I could change choices so they don't overwrite existing hashes.

Not overwriting existing hashes sounds like a good option. Also it would be consistent with the way local settings get overriden.


[FEAT] Add Zones Option to Detectors

Is your feature request related to a problem? Please describe.
I would like to use zones within a detector. Similar to how notify has the option.
    # only notify from specific zones
    # zones:
    #   - camera: garage
    #     zone: driveway

Describe the solution you'd like
I've been playing with Rekognition and it's been the best option for me for high quality matches.  But the costs can get high, Ideally I would love to use zones to limit Rekognition to my frigate porch zone, but still use a cheaper option like AIServer for my other zones; front yard, driveway, etc..
Notes:

This is a Nice-To-Have and by no means critical to the usage.
I had created this on the original double-take repo, but since I am now using this fork I figured I'd create it here as well.

https://github.com/skrashevich/double-take#frigate-1
frigate:
# only process images from specific zones
  zones:
    # - camera: garage
    #   zone: driveway

This feature has already been implemented

Wow, I can't believe I missed that. Thank you!

So after exploring this more, I'd like to reopen the issue. You are correct I can totally scope the incoming frigate requests to double-take to certain zones. But what I'm after is allowing all zones to be sent, but them limiting the detectors to zones instead of by cameras.
Example: So zone_1 would go to aiserver while zone_2 would go to Rekognition.
I tried with the following config on v.1.13.11 and wasn't able to get per zone as an option to work. Did I screw up the usage, or is this not supported?
detectors:
  rekognition:
    aws_access_key_id: !secret aws_access_key_id
    aws_secret_access_key: !secret aws_secret_access_key
    aws_region: "us-west-2"
    collection_id: double-take
    zones:
      - zone_1
      - zone_2

  aiserver:
    url: http://<IP_ADDRESS>:32168
    timeout: 15
#    cameras:
#      - camera_1
#      - camera_2
      zones:
        - zone_3
        - zone_4

u're right, now you can't filter/split detectors by zones. And this feature will not be implemented in the near future, because it contradicts the main mission of the application: to get a best recognition data from different external services


Adds test coverage for alpine linux.

I've gone ahead and added some alpine test coverage using travis-ci and docker to build an alpine image and test the run in there. It may need some tweaks/changes (chromium appears to be in /usr/lib/chrome, but it may not be functionality correctly), but this should be a good start to determine if this is working correctly.
See the following docker test:

See a sample build output of it failing here.

You issued this PR against the wrong fork, so I've created a new PR for you here: https://github.com/GoogleChrome/chrome-launcher/pull/68


Initial load in iframe scrolls page

On first pageload where I have an embedded iframe the page automatically scrolls to where the iframe is. I couldn't find anything in the source but maybe this is caused by some onpageload event handler on the window that is then propagating up to the parent when it's embedded in an iframe?

This was caused by autofocus attribute on the search field.
I updated code, so that when rendered inside an iframe the autofocus is not set by default. Please check now - it shouldn't scroll page.

Yes that fixed it thx! 🍻


Include by default an ssh-agent to prevent type ssh key password every time

Is your feature request related to a problem? Please describe.
Since I need terminal, more or less 100 times a day, It's a bit annoying unlock my ssh key 100 times.
Describe the solution you'd like
The way Ubuntu handle this issue is preatty easy, the command ssh-add store my key password for the whole session. A similar stuff already included could be interesting and comfortable.
Describe alternatives you've considered
There are not immediate ways to do this, like this one https://nazmul-ahsan.medium.com/how-to-prevent-ssh-key-passphrase-prompt-every-time-you-launch-wsl-6856eae31add
Prefer to avoid if possible

Are you running with systemd enabled? You can install ssh-agent etc... in ubuntu.

WSL doesn't control what runs in the distro. Adding an ssh-agent would be something that distro maintainers need to implement (or potentially users by starting the daemon with boot.cmd in /etc/wsl.conf)


warmup and backup enhancements, now rest endpoint

This PR does two things:
(a) enhances the warm up process by

delaying the start of Dynomite. We do not need to start Dynomite before the warm up finishes. The reason is that replicated data are received by peer nodes even though the node is out of Discovery. That may increase the memory footprint of Dynomite.
asking the local rack for the nodes with the same token

(b) adds a REST endpoint in Florida in which you can find information about the status of the node in JSON format. The reason, we added this feature is:
to have a single point of ground truth about the node without having to parse logs (especially useful for S3 backups). It will allow us to check before we move on.
For now, the following are supported:

warmup (status: not started, completed, pending, unsuccessful)
backup (status: not started, completed, pending, unsuccessful)
restore (status: not started, completed, pending, unsuccessful)
dynomiteAlive
storageAlive
healthy

(c) restructured backups and restores so that we can extend them to other platforms as well. The main benefit from that would be OSS folks who use Dynomite-manager with Google Cloud etc.


Infinity norm for matrices different than convention

According to the documentation, the function norm(X, 'inf') when X is a matrix computes \sum_{i,j}|X_{i,j}|, which is different than the convention, \max_i \sum_j |a_{i,j}|. This could lead to some confusion.
source: http://mathworld.wolfram.com/MatrixNorm.html

Hmm. Yes there is a discrepancy here.
In cvxpy 0.4, I think it makes sense to keep the current implementation. A large number of users may have run into this same discrepancy and simply changed their code accordingly.
The situation is a little different with cvxpy 1.0. Version 1.0 is designed to be as numpy compatible as possible, and numpy uses the same convention that you've pointed out. The result is that in version 1.0, the cvxpy Expression objects
expr1 = cvxpy.norm(X, 'inf')
and
expr2 = np.linalg.norm(X, np.inf)
have different dimensions, even though the user's intent is indistinguishable.
@SteveDiamond , since version 1.0 is yet to be fully released, do you think it would be reasonable to have cvxpy's norm function behave in the same way as numpy's norm function? In addition to the matrix infinity-norm, there's also the matrix 1-norm.

Yes, this behavior should be changed for cvxpy 1.0. Thanks for pointing this out!

I've made the changes necessary to resolve this issue. It will be included in my next pull request.

This can be marked as resolved.


Issues: Added Issue templates

Summary
-Template
Bug report
Report a bug to improve NuttX stability
Feature request
Request an enhancement for NuttX
General Help
Get general support regarding NuttX
Of course, others can be added. !!! :)
-Action
An action for automatically labelling issues
Keywords
Keywords are present in the dropdowns (the user can select more than one option) of the form Bug report and are:
- BSD, Linux, Mac, Windows, Other
- all, arm, arm64, avr, ceva, hc, mips, misoc, openrisc, renesas, risc-v, simulator, sparc, tricore, x86, x86_64, xtensa, z16, z80
- Applications, Api, Board support, Build System, Configuring, Debugging, Drivers, File System, Installing, Kconfig, Kernel, Memory Management, Native port, Networking, OS Components, Posix, Sensors, Specific Peripheral

Of course these keywords are examples so you can add, edit or delete them.
To work, the labels must have the same name as the keywords !!!
So before merging it is necessary that label keywords must first be entered manually!!!
My NuttX repository access permission levels do not allow me to add labels.
How to create a label manually
see #12748
Impact
none
Testing
CI

Could you please add BSD to the OS list @simbit18 ? :-) :-)

Hi @cederom  sure !!!

@cederom done !!!

Labels are created with some remarks:

OS have OS_ prefix (i.e. OS_BSD, OS_Linux, etc).
arch has arch_ prefix (i.e. arch_all, arch_arm, etc).
areas are lowercase and slightly updated.
label groups have the same color so they can be easily distinguished.

This is non-invasive change and can be easily updated by repo managers.
Please review labels and let me know if there is anything to update? Do we need labels descriptions too so they show up on the list somehow?

@cederom  @acassis has already added the labels in the nuttx repository.
see the test issue  12842

ah okay will adjust right now :-)

updated :-) please verify :-


Test for Born, probably gonna break memory but smaller makes no sense

New test for adjoint between Born and gradient. Needs about 4Gb of mem so it may fail.

Ok, test seems to not overload memory.
@ggorman here is the trust test :)

Question: given that the grid dimensions look small, why should this test need up to 4GBs of DRAM? what's consuming this much memory?

It is now reduced to ~700Mb. This is a gradient calculation that needs to store the full forward wavefield.


[2.0.0-dev] monofile errors out when a 100mb+ file is uploaded behind cloudflare tunnels

services behind cloudflare tunnels have a 100mb upload limit, anything higher than that returns a 413 from cloudflare

a potential solution to this could be a configurable option to enable/disable chunked uploads

chunking uploads between multiple requests, you mean?

if so, i'm not sure how i'd set it up and how to handle certain cases, i'll talk it out with jack ig. will be leaving unlabeled until i talk with him about this

i fixed the issue for myself by using a caddy reverse proxy, but i would still like to see the potential fix getting added

we've decided this is a job for the http proxy, not us; sorry


Update com.google.android.play

com.google.android.play:core has added this note for core:1.10.2:
Update your Play Core Maven dependency to an Android 14 compatible version! Your current Play Core library is incompatible with targetSdkVersion 34 (Android 14), which introduces a backwards-incompatible change to broadcast receivers to improve user security. As a reminder, from August 31, Google Play requires all new app releases to target Android 14. Update to the latest Play Core library version dependency to avoid app crashes: https://developer.android.com/guide/playcore#playcore-migration
You may not be able to release future versions of your app with this SDK version to production or open testing.

@andreevdenis looks like this is approved in Google Play no more nagging. Can this card be closed?


Fails to get gas tarriffs

There's a typo on line 90 of client.py where it sets the URL to fetch the gas tariff.  It is coded as "E-1R" but should read "G-1R".

Thanks. Feel free to submit a PR or I can fix over the coming days.

Released in Minor Release 0.0.12


Completion and docs update for --detach-keys

This adds bash completion for #15666.
The completion adds ctrl- when invoked at the beginning of the argument or after a comma.
This should be helpful if you want to enter arguments like ctrl-a,ctrl-a.
I also updated the cli documentation that the user can define a sequence of keystrokes.
ping @jfrazelle @tianon for review
/cc @sdurrheimer for zsh completion

LGTM 🐸

Nice, LGTM :+1:


Bump every package to version 0.2

The reason for the "bump" is to have a consistent version numbering across packages, not because it's needed for a release.

This appears good to me! The version "regression" in rclrs_examples is just a correction, right?

Ok, sure @esteve. I wasn't clear about the meaning of the author field. I'm making this PR just about the version numbers then.

@nnmm thanks!

@esteve Done.

@esteve Could you approve if no further changes are required?


documentation: undocumented query parameter 'attachments' for _bulk_get

Description
I've been using /{db}/_bulk_get and I wanted to get the document attachments in the response instead of just the stubs.  I checked the documentation to see if it was a supported query parameter but there is no mention:
https://docs.couchdb.org/en/stable/api/database/bulk-api.html#db-bulk-get
Just as a test I tried "?attachments=true" and was pleased that I got them in the response.
$ curl -k --cert cert --key key -X GET https://couchdb.example.com/
{"couchdb":"Welcome","version":"3.3.3","git_sha":"40afbcfc7","uuid":"c87ee6744ddc3efea74edfe25da5d7b3","features":["access-ready","partitioned","pluggable-storage-engines","reshard","scheduler"],"vendor":{"name":"The Apache Software Foundation"}}

$ curl -H "Content-type: application/json" --cert cert --key key -k -X POST https://couchdb.example.com/database/_bulk_get --data-binary @- << EOF
{"docs" : [ { "id":"docid" } ] }
EOF
{ ...response with attachment stubs ...}

$ curl -H "Content-type: application/json" --cert cert --key key -k -X POST https://couchdb.example.com/database/_bulk_get?attachments=true --data-binary @- << EOF
{"docs" : [ { "id":"docid" } ] }
EOF
{ ...response with inline attachments...}

Perhaps other parameters supported when fetching individual documents are also available for _bulk_get but not noted.
Steps to Reproduce
n/a
Expected Behaviour
n/a
Your Environment

CouchDB version used: noted above
Browser name and version: not relevant
Operating system and version:  not relevant

Additional Context

would you be interested in submitting a PR?


[ERROR] Can't create directory: File exists.

My hosting service complaints about this error i get when im using this free service
[ERROR] Can't create directory: File exists.
I don't know if it is something in my end, but would be nice if there would be a fix for this.

the error says there is already a file exist in the location you're trying to upload files to. Is this the case?


Fix display error

We need to save our img in diffrent way so they will be display properly on the site

We can:
Easy Option

Just make the folder inside a frontend /img and throw there our images. And then change links

Harder Option

Records in the form of BLOB in our database

Also we must change the clubs logo...
can we just change the path of the clubs logo  'url_logo' => "https://i.imgur.com/ASAxV9N.png",
So just the link will change

All fixed on branch "AxiosChanges"


Include additional log files in bpm logs

Is there a way, or could we add a way, for any additional log files created by running processes to be included in the bpm logs output?

@drnic we considered this initially but opted not to because of the complexity of avoiding rotated .gz files, as well as not knowing whether there are nested log directories which would need to be tail'ed.
I'm curious if it would be worth having an implementation that might miss some logs[1] as opposed to having a the limited implementation we have now which only gets stdout and/or `stderr
While it won't address this issue there is a logging story coming up which would force release authors to log into a subdirectory of /var/vcap/sys/log/<job>/ so that we can prevent the job-process from having write access to <process>.{out|err}.log. Link https://www.pivotaltracker.com/story/show/151341885
[1] Because we are avoiding archived logs, or because of unexpected subdirectories.

Ok. I'll wait until we have more bpm users and see if any one else get surprised when their job logs aren't in bpm logs. For now, I'll continue with my clipboard short cut tail -f /var/vcap/sys/log/{*.log,*/*.log}


Add option to control whether to normalize ident

Which issue does this PR close?

Closes #4551.
Rationale for this change

See issue above.
What changes are included in this PR?

Add new field enable_ident_normalization in ParserOptions
Add SqlParserOptions in ConfigOptions

Are these changes tested?
Add new UT: parse_ident_normalization

Are there any user-facing changes?
Yes, users can configure this new option when parse SQL

@alamb
parse_float_as_decimal already has its UT:
https://github.com/apache/arrow-datafusion/blob/7302120b00f0b8674fe0f5a544233516156c8af6/datafusion/sql/tests/integration_test.rs#L40
So I only add sqllogictests

Thanks again @jiacai2050


Add some benchmarks

Add jq in README.md
Add custom dict to benchmark
Add long-text benchmark

Push one more commit.

Separate Tokenizer::new as an another bench
Move new method outside bench_function


add note for strict ordering

Added a small note for ordering of paramters for spend permissions

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
1

Sum
2


customKey not working on read

Firebase library (firebase, firebase-admin, etc...) and version: firebase-admin
GeoFirestore version: 4.4.2

Hi there, I'm trying to use a custom key for my geoqueries instead of the default g but I'm running into some issues.
When I specify a customKey in the GeoFirestore.collection, then create a query from that and run it, the query is run on g.geohash instead of the specified customKey location.geohash.
Upon reading the source code, it appear to me that the customKey is only used when adding new documents.
    const geocollection = GeoFirestore.collection('posts', 'location');
    const geoQuery = geocollection
      .near({
        center: new admin.firestore.GeoPoint(query.centerLat, query.centerLng),
        radius: query.radius,
      })
      .where('community', '==', req.params.community)
      .limit(10);

    const resSnapshot = await geoQuery.get();

Am I missing something here ?
Cheers!

Instead of an await, try doing a traditional promise and apply the catch. I'd love to see what if any error appears.

@MichaelSolati With a traditional then/catch, I dont get any errors, but no results (where they should have been)
    const geocollection = GeoFirestore.collection('posts', 'location');
    const geoQuery = geocollection
      .near({
        center: new admin.firestore.GeoPoint(query.centerLat, query.centerLng),
        radius: query.radius,
      })
      .where('community', '==', req.params.community)
      .limit(10);

    return geoQuery
      .get()
      .then(v => res.status(200).json(v.docs))
      .catch(e => console.error(e));

I believe this issue was documented here too: https://github.com/MichaelSolati/geofirestore-js/issues/199

Also, by looking at the source of geofirestore-core, it doesn't appear to support custom keys as it uses the g key statically https://github.com/MichaelSolati/geofirestore-core/blob/main/src/api/query-get.ts#L83

What version are you using and can you show me what a document in Firestore looks like?

The custom key shouldn't matter on query as its used to encode into the .g field.

@MichaelSolati I'm using 4.4.2 and my documents looks like this
{
  location: {
    geopoint: GeoPoint,
    geohash: string
  },
  // other fields...
}

Ok, so the geopoint that you use in your doc can be any field, but you are right that geofirestore uses the g property.
Are you manually creating that location property?

@MichaelSolati The location property is created in the flutter frontend via https://pub.dev/packages/geoflutterfire, which allows a field name to be specified (which is porb. why I assume this worked the same way)

Got it, unfortunately no, this library doesn't support custom property names for queries, only to encode the document.
It's a good feature for down the road but not something I see myself getting to any time soon.

Fair. If I end up implementing it, I'll make sure to submit a PR ;)
In any case, thank you for your time!


Stuck on evaluation error

Description
Some times (it happens randomly or when there are a lot of files open and you switch on them) the PreviewPage stucks on Evaluation Error: Class, struct or interface method must have a return type. Trying switching to a cs file and back to a xaml one does not fix the issue.
Some times the output prints some gc info and seems that it got the change and trying to preview the file(with no success) and other ones it just does nothing. You have to re-run the application to make it work.
Haven't tried to make a toolbaritem for start and end(if it exists) the preview via an abstraction. Maybe a button on the preview page, like hard reload would resolve this issue.
Expected Behavior
The preview page should detect the focused page on the IDE and display it correctly.
Actual Behavior
The preview page after some time of switching files it gets stuck and does not preview the file.

Thanks again for you report :) I believe a hard reset option would be useful. Could you please attach some logs next time it happens so I can try to guess what happens to provide the correct fix?

A new release is available, you will have to update both the Add-in and the NuGet package :)


Suggestion: introduce dedicated message/command types

Instead of passing around raw string lines or a variable amount of tokens, dedicated message and command types could offer a convenient API to access & modify the relevant attributes of "lines" transferred between IRC servers, ZNC, and the clients. This could potentially help making the module hook API simpler and to avoid the need of ever parsing "things" twice (see for instance https://github.com/znc/znc/pull/501).
Message (received from an IRC server) attributes:

sender/prefix/nick/ident/host
type
command/number
parameters
timestamp
tags
raw data (?)
...

The buffer storage could store these message types so the same attributes could be accessed later eg. during the buffer playback or whatever modules might want to do.
Command (sent to an IRC server) attributes:

type
parameters
raw data (?)
...

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1435618-suggestion-introduce-dedicated-message-command-types?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

#1000


lapack/gonum: add Dpttrf, Dpttrs and Dptsv

Please take a look.

Codecov Report
Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (fa306f2) 74.01% compared to head (0c5992d) 73.98%.

:exclamation: Current head 0c5992d differs from pull request most recent head fa73453. Consider uploading reports for the commit fa73453 to get more accurate results

Files
Patch %
Lines

lapack/gonum/dpttrf.go
55.55%
10 Missing and 6 partials :warning:

lapack/gonum/dptsv.go
40.00%
12 Missing :warning:

lapack/gonum/dpttrs.go
50.00%
12 Missing :warning:

lapack/gonum/ilaenv.go
66.66%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
- Coverage   74.01%   73.98%   -0.03%
==========================================
  Files         528      532       +4
  Lines       63452    63546      +94
==========================================
+ Hits        46961    47013      +52
- Misses      13900    13936      +36
- Partials     2591     2597       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


default SELinux mode and override possibility

As far as I can see the default SELinux mode is set to "disabled".
In the environment I am managing we are using SELinux in "enforcing" mode by default. I can achieve that with this module by either including the config below in baseclass.pp
class { selinux:
mode => 'enforcing'
}
Or, I can edit the manifests/params.pp file. I have opted for the latter, but it is a bit hackish and intrusive to your module.
What I can't  seem to figure out is how to override this setting on a per host basis. There are hosts in the environement I am managing that we cannot have SELinux in enforcing mode, for various reasons.
What I am asking for is a way to set the default to enforcing in a proper manner, something that can be put in our baseclass.pp. And also a way to override the default setting on a per host basis.

You shouldn't be modifying the params.pp, that's the point of the class being parameterized. If you want to set different values per-host, either you need to have the logic in your Puppet code that determines the value and then pass that for the parameter, you need to include the selinux class separately per host (or per group of hosts with the same settings), or you need to inject the data via Hiera or an ENC.

Because of https://github.com/jfryman/puppet-selinux/issues/64 we had to do something to get around the unintended default behavior.
We have a baseclass.pp that we use on all our servers, this can be further divided into logical server groups. But however we divide things into logical groups that there will be exceptions to the rule of having SELinux enabled per default. How can one override the default setting?
What I am looking for is an override option. We would like to have a default (global or per group of servers) that ensures that SELinux is in enforcing mode. There are always exceptions to such rules whether we like it or not. How can we override the default to set SELinux in permissive mode on a per host basis?

You'd do something like this:
class baseclass ($selinux_mode = 'enforcing') {
  class { 'selinux':
    mode => $selinux_mode,
  }
}

Then you can set selinux_mode either by modifying where you include baseclass, using Hiera automatic data bindings, or using an ENC.
You could also do something like create a fact for whether you want SELinux or not or manually use the hiera() function to get a value, but those aren't really best-practice for this use case.

Oh, the other option is since #67 fixed the module to not manage the SELinux mode when you don't explicitly set it, you can manually set it on every node and not specify it with the module, but that's just decreasing what you manage, which really isn't a solution.


Fix Protactor name to correct one Protractor

There is typo in Protractor icon name (missing r)
Protactor should be Protractor
Let's check website https://www.protractortest.org

Fixed in d5a7437d826f5ef20d2815f7bed24d90ef113de2
Thanks


Fix wobbly points

Closes #698
The cause is related to floating point inaccuracies when mapping size from model/world to screen coords. The solution in this PR is to increase the sample distance. This does not completely remove the effect, but you'll have to zoom in a few orders of magnitude more before you see it.

Indeed this helps. I've had a few bugs in my shaders like this (one that took me 5 years to fix).
Do you have any tips to solving this? are there good "shader debuggers"?

one that took me 5 years to fix

That sounds like fun 😮

Do you have any tips to solving this? are there good "shader debuggers"?

I don't know. When possible I try to do something to visually check each step. This strategy worked well for e.g. the recent line shader work. But for this particular problem I don't think it helps.

Now it occurs when there is 1-2.

I can imagine there's a way to avoid round-off errors by changing how we do the matrix multiplications. I have not spent time to look into that. The current solution makes observing the problem much more rare, I think. But eventually someone could look into a more profound solution.

The current solution makes observing the problem much more rare, I think. But eventually someone could look into a more profound solution.

I agree! I limit my personal camera to "zoom in" to about 10 pixels anyway. Sometimes you do want to see how well you are "on center" so visually seeing the "squares" helps in that sense for me.


Rebuild VideoPlayer once VideoPlayerController finishes initialization.

This eliminates the races in VideoPlayer plugin initialization.

Seems I still have access!

I'll publish a new version as well

Thank you!

@nichtverstehen This breaks switching the VideoPlayerController for some reason. At least it does so in the example of the Chewie video player plugin. As soon as you switch the controller no video frames will ever be rendered again.
Do you have any ideas why? Before I dig any deeper..

Oops, it's obvious in retrospect. We should react to didUpdateWidget, not initState. Let me prepare a fix.

Sent https://github.com/flutter/plugins/pull/769.


Warn if fees are above 10% of total amount

Closes: #58

Codecov Report
Patch and project coverage have no change.

Comparison is base (a27fc18) 84.27% compared to head (8a90064) 84.27%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #196   +/-   ##
========================================
  Coverage    84.27%   84.27%
========================================
  Files           17       17
  Lines         2168     2168
========================================
  Hits          1827     1827
  Misses         341      341

Flag
Coverage Δ

unittests
84.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Screenshots of how it might look (as currently implemented in #196):
Nano S

Nano S+ / Nano X:

Stax complete signing flow:

Thanks for the idea @bigspider. We could improve the UX on Ledger Stax thanks to the bigger screen real estate. Instead of adding a warning modal, we could provide the information inline, thus improving context and reducing the number of taps. It might take the form of a smaller warning, below the Fees line.
What do you think?

Thanks for the idea @bigspider. We could improve the UX on Ledger Stax thanks to the bigger screen real estate. Instead of adding a warning modal, we could provide the information inline, thus improving context and reducing the number of taps. It might take the form of a smaller warning, below the Fees line. What do you think?

Thanks @blucet-ledger for the comment. I think it's actually better to explicitly inconvenience the user with an extra step that they don't usually have to perform − as the goal is for them to notice that something is probably wrong!
The warning should happen extremely rarely in practice.


[Feature Request] Show Windows-style Window Controls

Easy CodeSnap is excellent for anyone who doesn't want to touch settings.  Thank you for creating this!
Feature Request
Please add a setting to show Windows-style Window Controls.  Currently, the only option is to not show Window Controls.  When enabled, you only see the OS X style window buttons.  The Windows-style Window Controls should look like _ ☐ x on the top right instead of the red-yellow-green circles on the left.
Example:

@pnvnd What do you think about that?

Maybe should I align the title on left like Windows?

Looks nice @ArthurLobopro! Aligning the title to the left like Windows would be great!  Would you also be able to make the title bar a different color?  Here's was my attempt: Instead of using dot I made a square like this:
.square {
    width: 16px;
    height: 16px;
    margin-right: 8px;
}

Thank you for looking into this!

I can  add a option to change the title bar background if you want, with the transparent value as default

@pnvnd I think change the title bar background isn't a good idea because of this:

The title bar don't fill all top container, so if I change its background it will looks strange

No worries, it's fine.  Thank you for checking this out.  The Windows-style icons is more than enough for me 😄

@pnvnd it's done! In some minutes the version 1.8.0 will be available for download


fix: set ssh_keys to empty list in pvc pattern override json

Description

set ssh_keys to empty list in pvc pattern override json
update ibm_catalog.json to use patterns/vpc
added the variables to hide for VPC pattern in ibm_catalog.json
fix the values in patterns/vpc/catalogValidationValues.json.template
deleted examples/no-compute-example/catalogValidationValues.json.template

Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[x] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

:tada: This PR is included in version 3.4.1 :tada:
The release is available on:

GitHub release
v3.4.1

Your semantic-release bot :package::rocket:


Feature/port-in-use processors

Fix #99
Implement processor port-in-use-diagnoser.

The solution for this scenario -- restarting kubelet is a high-risk operation.


Non-JQuery solution

since you've figured out all the logic needed to make this happen, it would be really much more useful to have a javascript function that simply received a value and converted it:
FormatCurrency("2300"); // $2,300.00
...rather than having to have an object on the page to do it.  keeping your current implementation is, of course, very useful but in many other cases I may not have an element on the page I want to convert, I just have a value.
in other words, exposing the helper methods would give the module much greater functionality.
my two pence.

:+1:

I'm not sure whether I issued a pull request but for whoever cares, I forked and patched here: https://github.com/ekkis/jQuery-Currency


GUACAMOLE-996: Add support for specifying an LDAP group filter.

This change builds off the proposed changes submitted @echu2013 via #497, additionally addressing the feedback on that PR:

The default value for the new ldap-group-search-filter property should produce backward-compatible behavior when not specified (it should default to (objectClass=*)).
The group search filter should always be taken into account when retrieving user groups (it was erroneously ignored if connections were also being stored in LDAP).

I also went ahead and added a corresponding environment variable for the Docker image.

This closes #479


custom legend color error

C3 version:0.6.1
D3 version:4.13  and 5.4.0
Browser: chrome
OS: mac high sierra

Here is a codepen with the issue : https://codepen.io/prtome/pen/ERPzME
I am trying to build my  custom legend. A you can see the colours of the legend do not correspond to the colours of the graph

in the console I have the following error when using D3 4.13

There is no error in console with D3 5.40 (the current codepen) but legend colours are still wrong

I opened your codepen and did not had this JS error in the console.
The colors does not correspond because you are passing data1, data2, data3 instead of scan 1, scan 2, scan 3 to chart.color.


Move the Point and ChainUpdate types to Block module

It's not ok for them to live in the Chain module any more. The Chain module is the prototype / reference impl of the Chain and not the real thing, so it will not end up in the final library (just in the tests). So things we really need have to live elsewhere.

bors r+


The route /blog/rss.xml doesn't get built during the build

Describe the bug
The route /blog/rss.xml isn't built when running astro build. It is, however, present in dev
To Reproduce
Stackblitz repro: https://stackblitz.com/edit/github-t8s75sjf?file=astro.config.mjs,src%2Fcontent%2Fdocs%2Fblog%2Fpost.md&on=stackblitz
Expected behavior
As documented, it should be built when adding site
How often does this bug happen?
Every time
System Info
No response
Additional Context
No response

Thanks for the report.
I don't think the linked repro is complete so I tested directly on the Biome website.
First, the code to inject the route is fairly simple:
if (astroConfig.site) {
  injectRoute({
    entrypoint: 'starlight-blog/routes/rss',
    pattern: '/[...prefix]/rss.xml',
    prerender: true,
  })
}

The injectRoute() function is indeed called as expected in this case.
It looks like commenting the Netlify adapter in the astro.config.ts file makes it work as expected and the RSS feeds are generated correctly when running pnpm build:no-og:
λ starlight-blog/routes/rss.xml.ts
  ├─ /blog/rss.xml (+7ms)
  ├─ /fr/blog/rss.xml (+3ms)
  ├─ /ja/blog/rss.xml (+5ms)
  ├─ /zh-cn/blog/rss.xml (+2ms)
  └─ /pt-br/blog/rss.xml (+5ms)

Not quite sure what's going on here, will need to investigate further.

That's definitely weird, I'll see if I can remove the adapter for the time being


View components extraction

What?
Extracts the view components on the object page to separate files (inspired by Troika). Also the FINN fonts and colors are added, along with the spacing used in the Troika project.
Why?
This is another step towards the concept to prove.

I think this is looking pretty good. 👌


"in partnership" text should be only on the welcome page footer

@OzrenMuic everything that was in About now it's moved to the welcome page.


genpkey app writes keys with inconsistent formats

Compare:
$ openssl genpkey -algorithm rsa -outform pem 2>/dev/null | \
   grep -v ^- | openssl base64 -d | openssl asn1parse -inform der
    0:d=0  hl=4 l= 631 cons: SEQUENCE
    4:d=1  hl=2 l=   1 prim: INTEGER           :00
    7:d=1  hl=2 l=  13 cons: SEQUENCE
    9:d=2  hl=2 l=   9 prim: OBJECT            :rsaEncryption
   20:d=2  hl=2 l=   0 prim: NULL
   22:d=1  hl=4 l= 609 prim: OCTET STRING      [HEX DUMP]:3082025D02010002818100...

vs.
$ openssl genpkey -algorithm rsa -outform der 2>/dev/null | \
   openssl asn1parse -inform der

    0:d=0  hl=4 l= 604 cons: SEQUENCE
    4:d=1  hl=2 l=   1 prim: INTEGER           :00
    7:d=1  hl=3 l= 129 prim: INTEGER           :EC71E68C4AFD6E832A90...
  139:d=1  hl=2 l=   3 prim: INTEGER           :010001
  144:d=1  hl=3 l= 128 prim: INTEGER           :1543B11E50E835F629E...
  275:d=1  hl=2 l=  65 prim: INTEGER           :FCC8F44D6204849C4D...
  342:d=1  hl=2 l=  65 prim: INTEGER           :EF73BE970E0BCEE3EE...
  409:d=1  hl=2 l=  65 prim: INTEGER           :9BD5020DE63BE4C83A19...
  476:d=1  hl=2 l=  64 prim: INTEGER           :576ED1F6E22019A94CB9...
  542:d=1  hl=2 l=  64 prim: INTEGER           :53F3B624529B08A7155...

With -outform der I get traditional format for my RSA key, with -outform pem I get PKCS #8.
Why this inconsistency? Could we get PKCS #8 for -outform der too?

Yup, you're entirely correct.
I just did a debugging session with this, and the issue seems to be with these lines, i.e. if there is an old encoding functionality, it takes precedence.  Not so with the corresponding PEM routines...
@snhenson, I'd like your thoughts on this...

Well it's partly to do with the functionality available for DER. With PEM you can determine if the private key is encrypted or unenecrypted, its format (traditional or PKCS#8) and, if traditional, the algorithm used from the PEM headers. The standard function for reading in private keys is PEM_read_bio_PrivateKey() and it transparently just does the right thing.
With DER it's a bit of a mess. There isn't a universal handle almost everything equivalent of PEM_read_bio_PrivateKey(). If an application tries to read in DER and the format it wrong it will most likely just choke.
The nearest we have is d2i_PrivateKey_bio which does some autodetection (it's a bit messy though) but can't handle encrypted format (the function doesn't have any password arguments and we can't change that for compatibility reasons). The i2d_PrivateKey_bio() function which the genpkey function also behaves in the way it does for compatibility reasons.
So what could we do? Well I don't think we can change the genpkey inconsistency in a minor release as its a breaking change. We could add a command line argument to output in PKCS#8 or have an -outform format that does the same. At some point we need to enhance the autodetection for DER too.

Marking as inactive, to be closed at the end of 3.4 dev, barring further input


add element__click_test.test_click_waits_for_covering_preload_element_to_disappear

Codecov Report

Merging #310 (5165b6c) into master (55b3558) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   58.61%   58.61%
=======================================
  Files          35       35
  Lines        1829     1829
  Branches      117      117
=======================================
  Hits         1072     1072
  Misses        726      726
  Partials       31       31

Flag
Coverage Δ

unittests
58.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b3558...5165b6c. Read the comment docs.

Well done!
Just pay attention to some checks that failed:

And try to fix the code correspondingly;)
I will some additional comments regarding some naming conventions later...


Update to Latest Graph API

Any plan to update on latest facebook api?

+1

which API version it's using now?


⚠ Visual-Crew_Builder has degraded performance

In 3cc4a72, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 1202 ms

Resolved: Visual-Crew_Builder performance has improved in accb1a2 after 12 minutes.


pulseeffects: 4.3.7 -> 4.3.9

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pulseeffects/versions.
meta.description for pulseeffects is: '"Limiter, compressor, reverberation, equalizer and auto volume effects for Pulseaudio applications"'.
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/x6z71m9f6k50p5wca1zxgmmqhsyywi9b-pulseeffects-4.3.9/bin/pulseeffects had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/x6z71m9f6k50p5wca1zxgmmqhsyywi9b-pulseeffects-4.3.9/bin/.pulseeffects-wrapped had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 4.3.9 with grep in /nix/store/x6z71m9f6k50p5wca1zxgmmqhsyywi9b-pulseeffects-4.3.9
directory tree listing: https://gist.github.com/d623e057c8fdf1ff998ee6603664a578
du listing: https://gist.github.com/e6bf7ffce6070ed9eb63510d649c9d52

Outpath report (click to expand)

Outpath difference report
3 total rebuild paths
1 package rebuilds
1 x86_64-linux rebuilds
1 i686-linux rebuilds
0 x86_64-darwin rebuilds
1 aarch64-linux rebuilds
First ten rebuilds by attrpath
pulseeffects

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x6z71m9f6k50p5wca1zxgmmqhsyywi9b-pulseeffects-4.3.9 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A pulseeffects https://github.com/r-ryantm/nixpkgs/archive/9d79d12e6f694fde7912b60eb2d967e3b6a27007.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x6z71m9f6k50p5wca1zxgmmqhsyywi9b-pulseeffects-4.3.9
ls -la /nix/store/x6z71m9f6k50p5wca1zxgmmqhsyywi9b-pulseeffects-4.3.9/bin

cc @jtojnar for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pulseeffects
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


CORS: Allow inline CSS and style attributes

This change will allow fiddle users and people using the quickstart to add inline style elements and style attributes, making it easier to quickly style without significantly damaging CORS.
We could also consider script-src-attr to only allow style attributes but I think allowing inline style elements would be useful as well.

اريد الربح ع فايس بوك ولكن لا اعرف كيف


Select Value Does not update when typing a second char

When I focus on a text field, then tab over to a select field, then type the value of a valid option which starts with the same letter as another option that comes alphabetically first, I expect that angular will record the value of the option i typed, and which is also displayed in the UI.  Instead, the angular value is the non-typed option which comes first alphabetically.
Fiddle: http://jsfiddle.net/Missinghandle/vFX9n/
Select the text box
Tab
type "i", "l"
UI shows IL
select value is ID

this is the same as https://github.com/angular/angular.js/issues/9134


Get response body of 400

Hello,
I'd like to read to response body of a request. So in the code i do
begin
  Restclient.execute(...)
rescue RestClient::ExceptionWithResponse => e
  e.response.body # i only get a string message
end

How do i get access to the json body ?

Do you mean how do you parse a string as JSON? i.e. JSON.parse(body)?

No i mean i dont have the json i expect as a response, instead i get a string in the body. This only happens when i return 400 error from web API serveur (ASP.net)

I'm not sure I understand; HTTP as a protocol only transmits strings. You might interpret a string response as JSON and parse it with something like JSON.parse(body) which will deserialize the JSON into ruby objects, but the server is always actually transmitting a string.
Maybe an example showing what you expect to happen would help?

The thing is when i write :
e.response it woudln't show the response body of the response. But then i figured it was ASP Web Api issue, that it removed the body and only kept status message. So i did this in ASP Web Api :
Response.TrySkipIisCustomErrors = true;
So the problem was from the webserver i was contacting and not rest-client.
So this is really not an issue, thanks for trying to help @ab :)


⚠ Samsung has degraded performance

In 4011819, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3288 ms

Resolved: Samsung performance has improved in 21adbe9.