Can Eureka Client with Brixton.RC2 talk with Eureka Server with version Angel.SR6

I observed some compatibility issue between them.
Can someone confirm that :
Eureka Client with Brixton.RC2 does not suppose to talk with Eureka Server with version Angel.SR6 ?

What issue are you seeing?

I can confirm it works.

One issue I observed on client side:

The service (eureka client) is trying to re-register every 30 seconds
Posibbly due to below issue :

09:57:48.738 [DiscoveryClient-HeartbeatExecutor-0] WARN  com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient - Request execution failure
09:57:48.739 [DiscoveryClient-CacheRefreshExecutor-0] WARN  com.netflix.discovery.DiscoveryClient - The reconcile string is
09:57:48.739 [DiscoveryClient-CacheRefreshExecutor-0] WARN  com.netflix.discovery.DiscoveryClient - The Reconcile hashcodes after complete sync up, client : STARTING_1_UP_19_, server : STARTING_1_UP_21_.
09:57:48.741 [DiscoveryClient-HeartbeatExecutor-0] ERROR com.netflix.discovery.shared.transport.decorator.RedirectingEurekaHttpClient - Request execution error
javax.ws.rs.WebApplicationException
	at com.netflix.discovery.provider.DiscoveryJerseyProvider.readFrom(DiscoveryJerseyProvider.java:110) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:634) ~[jersey-client-1.19.1.jar:1.19.1]
	at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:586) ~[jersey-client-1.19.1.jar:1.19.1]
	at com.netflix.discovery.shared.transport.jersey.AbstractJerseyEurekaHttpClient.sendHeartBeat(AbstractJerseyEurekaHttpClient.java:105) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.MetricsCollectingEurekaHttpClient.execute(MetricsCollectingEurekaHttpClient.java:73) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.RedirectingEurekaHttpClient.executeOnNewServer(RedirectingEurekaHttpClient.java:118) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.RedirectingEurekaHttpClient.execute(RedirectingEurekaHttpClient.java:79) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient.execute(RetryableEurekaHttpClient.java:119) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.SessionedEurekaHttpClient.execute(SessionedEurekaHttpClient.java:77) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.DiscoveryClient.renew(DiscoveryClient.java:827) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.DiscoveryClient$HeartbeatThread.run(DiscoveryClient.java:1383) [eureka-client-1.4.6.jar:1.4.6]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_45]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_45]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_45]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_45]
	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]

Any more to that stacktrace? It's not very helpful. Maybe a project that recreates the problem?

Let me add more information that I dig before ;
I suspect the issue is related to the client detect different amount of UP instances. In my case client detect only 19 UP instances, but server detect 21.
There is one apps in my eureka server which is deployed on the same hostname, but different port:
My suspect is, there is different way on old version and new version to resolved the instanceId value :
The old one is by putting the instanceId under , the new version is on
<application>
<name>SIMPLE-ORIGIN-SERVICE</name>
<instance>
<hostName>devsand00113.example.com</hostName>
<app>SIMPLE-ORIGIN-SERVICE</app>
<ipAddr><IP_ADDRESS></ipAddr>
<status>UP</status>
<overriddenstatus>UNKNOWN</overriddenstatus>
<port enabled="true">8092</port>
<securePort enabled="false">443</securePort>
<countryId>1</countryId>
<dataCenterInfo class="com.netflix.appinfo.InstanceInfo$DefaultDataCenterInfo">
<name>MyOwn</name>
</dataCenterInfo>
<leaseInfo>
<renewalIntervalInSecs>5</renewalIntervalInSecs>
<durationInSecs>90</durationInSecs>
<registrationTimestamp>1462473050384</registrationTimestamp>
<lastRenewalTimestamp>1462846077421</lastRenewalTimestamp>
<evictionTimestamp>0</evictionTimestamp>
<serviceUpTimestamp>1462473048668</serviceUpTimestamp>
</leaseInfo>
<metadata>
<httpMethodsSupported>GET</httpMethodsSupported>
<instanceId>simple-origin-service-8092</instanceId>
<zone>dc3</zone>
</metadata>
<homePageUrl>http://devsand00113.example.com:8092/</homePageUrl>
<statusPageUrl>
http://devsand00113.example.com:8092/info
</statusPageUrl>
<healthCheckUrl>
http://devsand00113.example.com:8092/health
</healthCheckUrl>
<vipAddress>simple-origin-service</vipAddress>
<isCoordinatingDiscoveryServer>false</isCoordinatingDiscoveryServer>
<lastUpdatedTimestamp>1462473050384</lastUpdatedTimestamp>
<lastDirtyTimestamp>1462375159888</lastDirtyTimestamp>
<actionType>ADDED</actionType>
</instance>
<instance>
<hostName>devsand00113.example.com</hostName>
<app>SIMPLE-ORIGIN-SERVICE</app>
<ipAddr><IP_ADDRESS></ipAddr>
<status>UP</status>
<overriddenstatus>UNKNOWN</overriddenstatus>
<port enabled="true">8094</port>
<securePort enabled="false">443</securePort>
<countryId>1</countryId>
<dataCenterInfo class="com.netflix.appinfo.InstanceInfo$DefaultDataCenterInfo">
<name>MyOwn</name>
</dataCenterInfo>
<leaseInfo>
<renewalIntervalInSecs>5</renewalIntervalInSecs>
<durationInSecs>90</durationInSecs>
<registrationTimestamp>1462624611137</registrationTimestamp>
<lastRenewalTimestamp>1462846079435</lastRenewalTimestamp>
<evictionTimestamp>0</evictionTimestamp>
<serviceUpTimestamp>1462624611137</serviceUpTimestamp>
</leaseInfo>
<metadata>
<httpMethodsSupported>GET</httpMethodsSupported>
<instanceId>simple-origin-service-8094</instanceId>
<zone>dc3</zone>
</metadata>
<homePageUrl>http://devsand00113.example.com:8094/</homePageUrl>
<statusPageUrl>
http://devsand00113.example.com:8094/info
</statusPageUrl>
<healthCheckUrl>
http://devsand00113.example.com:8094/health
</healthCheckUrl>
<vipAddress>simple-origin-service</vipAddress>
<isCoordinatingDiscoveryServer>false</isCoordinatingDiscoveryServer>
<lastUpdatedTimestamp>1462624611137</lastUpdatedTimestamp>
<lastDirtyTimestamp>1462375190206</lastDirtyTimestamp>
<actionType>ADDED</actionType>
</instance>
</application>

It's not easy to provide you a sample project since the issue is happens on multi nodes registering on the server.

The angel eureka server only understands instanceId from metadata, so all clients must set eureka.instance.metadataMap.instanceId if they are on the same host. If everything was brixton, you could just set ``eureka.instance.instanceId`.

But the issue is not on server side. The client (Brixton.RC2) thought its only 19 UP, but server detect 21 UP, the gap 3 instance caused by the instance is share on the same hostname but put the instanceID on metadataMap

Are you referring to this line?
STARTING_1_UP_19_, server : STARTING_1_UP_21_

If so, there is no bug. At some point that client was at 19, next time it reconciled, it received 21. Both of those values come from the server. Besides the exception you saw is there anything actually wrong?

yes. but it reconciled each 30 seconds.

So your concern is you see the reconciliation log statement every 30 seconds?

yes and below exception is repeatly being print out every 30 second :
10:02:48.827 [DiscoveryClient-CacheRefreshExecutor-0] WARN  com.netflix.discovery.DiscoveryClient - The reconcile string is
10:02:48.827 [DiscoveryClient-CacheRefreshExecutor-0] WARN  com.netflix.discovery.DiscoveryClient - The Reconcile hashcodes after complete sync up, client : STARTING_1_UP_18_, server : STARTING_1_UP_20_.
10:03:18.795 [DiscoveryClient-HeartbeatExecutor-0] ERROR com.netflix.discovery.shared.transport.decorator.RedirectingEurekaHttpClient - Request execution error
javax.ws.rs.WebApplicationException
	at com.netflix.discovery.provider.DiscoveryJerseyProvider.readFrom(DiscoveryJerseyProvider.java:110) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:634) ~[jersey-client-1.19.1.jar:1.19.1]
	at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:586) ~[jersey-client-1.19.1.jar:1.19.1]
	at com.netflix.discovery.shared.transport.jersey.AbstractJerseyEurekaHttpClient.sendHeartBeat(AbstractJerseyEurekaHttpClient.java:105) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.MetricsCollectingEurekaHttpClient.execute(MetricsCollectingEurekaHttpClient.java:73) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.RedirectingEurekaHttpClient.executeOnNewServer(RedirectingEurekaHttpClient.java:118) ~[eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.RedirectingEurekaHttpClient.execute(RedirectingEurekaHttpClient.java:79) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient.execute(RetryableEurekaHttpClient.java:119) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.SessionedEurekaHttpClient.execute(SessionedEurekaHttpClient.java:77) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.DiscoveryClient.renew(DiscoveryClient.java:827) [eureka-client-1.4.6.jar:1.4.6]
	at com.netflix.discovery.DiscoveryClient$HeartbeatThread.run(DiscoveryClient.java:1383) [eureka-client-1.4.6.jar:1.4.6]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_45]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_45]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_45]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_45]
	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
10:03:18.795 [DiscoveryClient-HeartbeatExecutor-0] WARN  com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient - Request execution failure
10:03:18.795 [DiscoveryClient-HeartbeatExecutor-0] ERROR com.netflix.discovery.DiscoveryClient - DiscoveryClient_GEOLOCATION-SERVICE/ssetiadi-thinkpad-w540.taipei.digitalriver.com:geolocation-service:8080 - was unable to send heartbeat!
com

I'm unable to replicate that error.

I see these logs repeated
2016-05-09 21:06:38.746  WARN 82146 --- [freshExecutor-0] com.netflix.discovery.DiscoveryClient    : The Reconcile hashcodes do not match, client : UP_1_, server : UP_2_. Getting the full registry
2016-05-09 21:06:38.750  WARN 82146 --- [freshExecutor-0] com.netflix.discovery.DiscoveryClient    : The reconcile string is
2016-05-09 21:06:38.750  WARN 82146 --- [freshExecutor-0] com.netflix.discovery.DiscoveryClient    : The Reconcile hashcodes after complete sync up, client : UP_1_, server : UP_2_.

Hi
I'm facing same issues wuth Brixton.RELEASE,
I'm sure that my µServices are not registering/un-registering at this rate in eureka
My setup is a cluster of 2 eureka, but coming with Angel.SR4, I'll do a test by upgrading them to Brixton
each 30s I got

2016-05-18 10:18:56.360  WARN [onyx-walkway,,,] 35320 --- [freshExecutor-0] com.netflix.discovery.DiscoveryClient    : The reconcile string is
2016-05-18 10:18:56.361  WARN [onyx-walkway,,,] 35320 --- [freshExecutor-0] com.netflix.discovery.DiscoveryClient    : The Reconcile hashcodes after complete sync up, client : UP_27_, server : UP_28_.
2016-05-18 10:19:26.446  WARN [onyx-walkway,,,] 35320 --- [freshExecutor-0] com.netflix.discovery.DiscoveryClient    : The Reconcile hashcodes do not match, client : UP_27_, server : UP_28_. Getting the full registry

@ouaibsky Please keep us posted.
I guess a lot of people are in the same boat. We also installed Eureka a while ago and did not upgraded it regularly as it just worked.
Spring Cloud project is still relatively new, so we need to adjust along the way.

#978 has some analysis as well (slightly more detail). So this is a duplicate.

OK, I'm following #978  now
But before upgrading eureka server to Brixton I need to make sure my other clients (Angel) are still working with eureka server (brixton)
Christophe

I have the same issue, it did not help to upgrade both server and client to latest eureka.

Did you notice this issue is closed (as a duplicate)?


Request timeouts

Oct 05 21:58:23 slownews heroku/router:  at=error code=H12 desc="Request timeout" method=GET path="/data" host=slownews.ca request_id=d3b49ebe-bc3f-4469-b8af-074822153c83 fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=30000ms status=503 bytes=0

obviously Go is not enough. Go Elixir!

Obviated by #2


fedimint-cli derives secrets using federation id twice?

Once in get_default_client_secret and second in ClientBuilder::build.
The get_default_client_secret seems redundant now. Should we remove, or we're keeping it for backward compat? Or am I just confused? @elsirion @shaurya947

That was a deliberate trade-off. See last sentence in secret_derivation.md.
The first derivation using the federeation ID is defined in the standard derivation scheme that integrators are asked to follow but don't have to. It allows deriving additional keys for custom use cases.
The second derivation is just a safety feature for people that a) don't follow the standard derivation scheme and b) accidentally reuse the same secret for different federations. What the client does internally is opaque to integrators, this shouldn't be something most people concern themselves with.


⚠ Bofrost.be has degraded performance

In aa89c5c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 3304 ms

Resolved: Bofrost.be performance has improved in c543e1f.


Record.Instance link present in docs sidebar but section does not exist

In the sidebar, Record.Instance is present, but the link (https://facebook.github.io/immutable-js/docs/#/Record.Instance) does not lead anywhere -- there is no Record.Instance section on the Record page.

I think it's an exported type in the .ts file, which the docs are generated off of. It's just an instance of a Record with all the Map methods hanging off it.

Looks like it got fixed!


Assert on null t_state.transact_return_point

Seeing this crash now after putting in work around for issue #1401.
#0  0x00002b20159b7625 in raise () from /lib64/libc.so.6
#1  0x00002b20159b8d8d in abort () from /lib64/libc.so.6
#2  0x00002b20132c8a02 in ink_abort (message_format=0x2b20132de4f0 "%s:%d: failed assertion `%s`") at ink_error.cc:99
#3  0x00002b20132c6106 in _ink_assert (expression=0x7d8b20 "t_state.transact_return_point != nullptr", file=0x7d5e2c "HttpSM.cc",
    line=7197) at ink_assert.cc:37
#4  0x00000000005fbbeb in HttpSM::call_transact_and_set_next_state (this=0x2b20c8096c00, f=0) at HttpSM.cc:7197
#5  0x00000000005fbefe in HttpSM::set_next_state (this=0x2b20c8096c00) at HttpSM.cc:7253
#6  0x00000000005fbd43 in HttpSM::call_transact_and_set_next_state (this=0x2b20c8096c00, f=0) at HttpSM.cc:7206
#7  0x00000000005e7623 in HttpSM::handle_api_return (this=0x2b20c8096c00) at HttpSM.cc:1606
#8  0x00000000005e7454 in HttpSM::state_api_callout (this=0x2b20c8096c00, event=60000, data=0x0) at HttpSM.cc:1544
#9  0x00000000005e6a22 in HttpSM::state_api_callback (this=0x2b20c8096c00, event=60000, data=0x0) at HttpSM.cc:1340
#10 0x0000000000536236 in TSHttpTxnReenable (txnp=0x2b20c8096c00, event=60000) at InkAPI.cc:5883
#11 0x00002aaaae401263 in http_hook (contp=0x2204f40, event=60016, edata=0x2b20c8096c00) at INKPluginInit.cc:408
#12 0x000000000052a4d3 in INKContInternal::handle_event (this=0x2204f40, event=60016, edata=0x2b20c8096c00) at InkAPI.cc:1048
#13 0x000000000051592e in Continuation::handleEvent (this=0x2204f40, event=60016, data=0x2b20c8096c00)
    at /home/shinrich/yats_build/trafficserver/iocore/eventsystem/I_Continuation.h:153
#14 0x000000000052acd3 in APIHook::invoke (this=0x2206f80, event=60016, edata=0x2b20c8096c00) at InkAPI.cc:1267
#15 0x00000000005e7134 in HttpSM::state_api_callout (this=0x2b20c8096c00, event=0, data=0x0) at HttpSM.cc:1462
#16 0x00000000005f4d91 in HttpSM::do_api_callout_internal (this=0x2b20c8096c00) at HttpSM.cc:5168
#17 0x0000000000602fa3 in HttpSM::do_api_callout (this=0x2b20c8096c00) at HttpSM.cc:438
#18 0x00000000005fbdb0 in HttpSM::set_next_state (this=0x2b20c8096c00) at HttpSM.cc:7239
#19 0x00000000005fbd43 in HttpSM::call_transact_and_set_next_state (this=0x2b20c8096c00, f=0) at HttpSM.cc:7206
#20 0x00000000005e7623 in HttpSM::handle_api_return (this=0x2b20c8096c00) at HttpSM.cc:1606
#21 0x00000000005e7454 in HttpSM::state_api_callout (this=0x2b20c8096c00, event=60000, data=0x0) at HttpSM.cc:1544
#22 0x00000000005e6a22 in HttpSM::state_api_callback (this=0x2b20c8096c00, event=60000, data=0x0) at HttpSM.cc:1340
#23 0x0000000000536236 in TSHttpTxnReenable (txnp=0x2b20c8096c00, event=60000) at InkAPI.cc:5883
#24 0x00002aaaafd35999 in carpPluginHook (contp=0x2204dc0, event=60002, edata=0x2b20c8096c00) at carp.cc:542
#25 0x000000000052a4d3 in INKContInternal::handle_event (this=0x2204dc0, event=60002, edata=0x2b20c8096c00) at InkAPI.cc:1048
#26 0x000000000051592e in Continuation::handleEvent (this=0x2204dc0, event=60002, data=0x2b20c8096c00)
    at /home/shinrich/yats_build/trafficserver/iocore/eventsystem/I_Continuation.h:153
#27 0x000000000052acd3 in APIHook::invoke (this=0x2206f00, event=60002, edata=0x2b20c8096c00) at InkAPI.cc:1267
#28 0x00000000005e7134 in HttpSM::state_api_callout (this=0x2b20c8096c00, event=60000, data=0x0) at HttpSM.cc:1462
#29 0x00000000005e6a22 in HttpSM::state_api_callback (this=0x2b20c8096c00, event=60000, data=0x0) at HttpSM.cc:1340
#30 0x0000000000536236 in TSHttpTxnReenable (txnp=0x2b20c8096c00, event=60000) at InkAPI.cc:5883
#31 0x00002aaaae401263 in http_hook (contp=0x2204f40, event=60002, edata=0x2b20c8096c00) at INKPluginInit.cc:408
#32 0x000000000052a4d3 in INKContInternal::handle_event (this=0x2204f40, event=60002, edata=0x2b20c8096c00) at InkAPI.cc:1048
#33 0x000000000051592e in Continuation::handleEvent (this=0x2204f40, event=60002, data=0x2b20c8096c00)
    at /home/shinrich/yats_build/trafficserver/iocore/eventsystem/I_Continuation.h:153
#34 0x000000000052acd3 in APIHook::invoke (this=0x2206fa0, event=60002, edata=0x2b20c8096c00) at InkAPI.cc:1267
#35 0x00000000005e7134 in HttpSM::state_api_callout (this=0x2b20c8096c00, event=0, data=0x0) at HttpSM.cc:1462
#36 0x00000000005f4d91 in HttpSM::do_api_callout_internal (this=0x2b20c8096c00) at HttpSM.cc:5168
#37 0x0000000000602fa3 in HttpSM::do_api_callout (this=0x2b20c8096c00) at HttpSM.cc:438
#38 0x00000000005fbdb0 in HttpSM::set_next_state (this=0x2b20c8096c00) at HttpSM.cc:7239
#39 0x00000000005fbd43 in HttpSM::call_transact_and_set_next_state (this=0x2b20c8096c00, f=
    0x60e8f0 <HttpTransact::ModifyRequest(HttpTransact::State*)>) at HttpSM.cc:7206
#40 0x00000000005e51f1 in HttpSM::state_read_client_request_header (this=0x2b20c8096c00, event=100, data=0x2aad2028f158)
    at HttpSM.cc:821
#41 0x00000000005eb68b in HttpSM::main_handler (this=0x2b20c8096c00, event=100, data=0x2aad2028f158) at HttpSM.cc:2662
#42 0x000000000051592e in Continuation::handleEvent (this=0x2b20c8096c00, event=100, data=0x2aad2028f158)
    at /home/shinrich/yats_build/trafficserver/iocore/eventsystem/I_Continuation.h:153
#43 0x000000000078749d in read_signal_and_update (event=100, vc=0x2aad2028f030) at UnixNetVConnection.cc:145
#44 0x000000000078a630 in UnixNetVConnection::readSignalAndUpdate (this=0x2aad2028f030, event=100) at UnixNetVConnection.cc:1125
#45 0x000000000076cc40 in SSLNetVConnection::net_read_io (this=0x2aad2028f030, nh=0x2b201796ce60, lthread=0x2b2017969010)
    at SSLNetVConnection.cc:586
#46 0x000000000077fdff in NetHandler::mainNetEvent (this=0x2b201796ce60, event=5, e=0x1c46760) at UnixNet.cc:509
#47 0x000000000051592e in Continuation::handleEvent (this=0x2b201796ce60, event=5, data=0x1c46760)
    at /home/shinrich/yats_build/trafficserver/iocore/eventsystem/I_Continuation.h:153
#48 0x00000000007a985d in EThread::process_event (this=0x2b2017969010, e=0x1c46760, calling_code=5) at UnixEThread.cc:143
#49 0x00000000007a9d5e in EThread::execute (this=0x2b2017969010) at UnixEThread.cc:270
#50 0x00000000007a8f13 in spawn_thread_internal (a=0x1b33a50) at Thread.cc:84
#51 0x00002b2015d20aa1 in start_thread () from /lib64/libpthread.so.0
#52 0x00002b2015a6d93d in clone () from /lib64/libc.so.6

This could be an issue unique to our plugins.  This occurs after a successful remap (as shown in frame 5, t_state.url_remap_success is true).  As the assert says t_state.transact_return_point is NULL.  t_state.next_action is HttpTransact::SM_ACTION_SEND_ERROR_CACHE_NOOP.   However if we have set the next action to be an error, it is odd that the url_remap was reported to be a success.

Tracked it down some more.  In this case, new remap rule is not found, and build_error_response is called to set the status of 404 with the reason of "Not Found".  But somehow the t_state.transaction_return_point is not updated.

Looks like this should be closed since the PR for it was merged.  Please reopen if need be.


Add package for specific functions

Hi, in BANKSY workflow there're some functions from package scuttle. Yet in the BANKSY script, scuttle is not explicitly loaded, leading to a function-not-found error when running the script in the pipeline. I added scuttle:: for those functions so the script can work properly.
This is working now. Do I need to add library(scuttle) at the beginning of the script?

I added the scuttle version used in the environment to banksy.yml


chore: remove Go

We don't have any Go sources in rules_ts, so there's no reason we should install a Go toolchain or worry about upgrading it. 'aspect configure' provides the auto-generation for bzl_library targets so we don't need Gazelle either.

Confirmed that aspect workflows already has a configure task, so we shouldn't lose CI checking that bzl_library targets are up-to-date.

gazelle is currently load-bearing for testing Aspect Workflows on AWS+GHA so closing this for now. Can revisit when/if we stop recommending gazelle.


revive the Windows port

The DISPATCH_EXPORT macro added an extraneous extern on the
declaration.  This was pointed out by a newer clang.  Adjust the
declaration accordingly.
Add build rules to improve Windows builds.  These additions help
cross-compile to Windows with both clang-cl as well as the GNU clang
driver.
Use the newer Windows APIs to detect the windows CPU state.  This allows
us to collect all of the CPU configuration information to properly
affinitise work to the preferred CPU.
Use the FLS API to create thread local data storage for libdispatch's
queues.

CC: @das @MadCoder @jrose-apple @parkera

This is a partial patch, it still needs more work.  But, it sets up a lot of the work that is needed.  It also fixes cross-compilation on Linux to Windows.  The assumption here is that you are using clang-cl or clang to build libdispatch.  I figure that putting this up here earlier is better as it allows others to take a look as well as possibly solve some of the remaining issues.

I have to look at the patch more, and it's more than I can do in a timely fashion, but I've seen nothing shocking in there overall.

Updated to address the comments.  This is further along now, with a lot more of the port formalized.

There is a small amount of porting left: src/io.c (this previously was completely disabled).

if TARGET_OS_WIN32 comes from the build system you can't have it in private.h or any header, you should use _WIN32 there, and then it is a question whether we need TARGET_OS_WIN32 at all, it seems confusing. TARGET_OS* comes from <TargetConditionals.h> which is a thing that Apple has when we build things on Windows platforms that's why it's this way. I don't think it should stay this way.
have you ported all of event/event.c too? ;) because that part is the one that needs basically full reimplementation, unless windows supports kevent :P (not that it should block anything, but between having dispatch sources working and io.c I know what should be done first :P)

so please get rid of TARGET_OS_WIN32 consistently, we use __linux__ and __freebsd__ and such for other platforms, there's no reason for windows to be in between IMO. Once you've done that I'll merge.

Hah, kevent.c is huge (and as you pointed out, will require a full re-implementaiton), and I think that doing that as a separate change is best -- this is a pretty big change as is.  While I agree that kevent.c is crucial, having this part means that we can at least ensure that build regressions don't occur while that is ported over.  Replacing TARGET_OS_WIN32 with defined(_WIN32) sounds completely fine to me.

as far as kevent.c is, it's huge, but you should instead model it after event_epoll.c which is way smaller, I have abstracted platform specific code this way way more than it used to be.

So, the build should be complete at this point, the top patch is the only thing which I don't know how to formalize.  But, the entire build now completes successfully :-)

@swift-ci please test

@swift-ci please test


[DO NOT MERGE] Turn on rbac e2e test.

The rbac e2e got disabled in #5268 and I'm using this PR to trigger a test in CircleCI to check the logs.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7aee23870aff5ce9bef328165ef14763260ea6db
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7aee23870aff5ce9bef328165ef14763260ea6db
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
7aee23870aff5ce9bef328165ef14763260ea6db
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
7aee23870aff5ce9bef328165ef14763260ea6db
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a524fd1d7845059355a69d301006680551398952
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
7aee23870aff5ce9bef328165ef14763260ea6db
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a524fd1d7845059355a69d301006680551398952
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a524fd1d7845059355a69d301006680551398952
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a524fd1d7845059355a69d301006680551398952
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a524fd1d7845059355a69d301006680551398952
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a524fd1d7845059355a69d301006680551398952
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff39386a57d68b603844bf5a8d8b1df0f2aa0137
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a524fd1d7845059355a69d301006680551398952
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff39386a57d68b603844bf5a8d8b1df0f2aa0137
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ff39386a57d68b603844bf5a8d8b1df0f2aa0137
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff39386a57d68b603844bf5a8d8b1df0f2aa0137
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ff39386a57d68b603844bf5a8d8b1df0f2aa0137
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
ff39386a57d68b603844bf5a8d8b1df0f2aa0137
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


adds a link to the generated API reference to the toc

This is consistent with the other drivers tables of contents 😺

I am not planning to maintain the generated API docs once the new documentation is live. It was really just a quick solution until the public API was documented in Markdown, so we can do away with it.

Oh, cool, that works!


Add doc and test for Container's hitTest behavior

Description
A lot of people use Container as a hit test target. This PR adds docs and tests for container's hit test behavior.
Related Issues

Raised by https://github.com/flutter/flutter/issues/49919
We plan to make hittesting transparent Container an assertion (https://github.com/flutter/flutter/issues/51000)

Tests
I added the following tests:

Container is hittable if and only if it has color or any decorations

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

(PR triage): @dkwingsmt is this one ready to go?


Update stable version in repo to 1.0.6

Think about update stable version to 1.0.6
Version: stable=1.0.5 (154 days old) => latest=1.0.6 (72 days old)
Installs: stable=382 (57.88%), latest=158 (23.94%), total=660
Click to edit

I will add the version 1.1.0 to stable in a few days


doc: Chinese version of plugin tcp-logger

https://github.com/apache/incubator-apisix/blob/master/doc/plugins/tcp-logger.md

@membphis I would like to work on this task

I have assigned it to you


Completions snippets being automatically inserted into buffer

From user feedback:

Using MacVim 8.1, Kite is randomly typing in lots of text from the help docs directly into my input buffer, requiring me to stop using it.

Yep - here's a screenshot: Basically I typed "de" and the plugin automatically typed in the EOFError into my editor as well as opening up the additional split window up top.

The behaviour of the completions is controlled by the completeopt option.  The plugin sets completeopt to work well with Kite's autocompletion if and only if the user hasn't already configured it.
The readme explains this in detail.
The first step is to ask the user to do :verbose echo &completeopt.  This will print out the option value and also say what set it to that value.
Does the user want Kite to autocomplete?  If not, they should :let g:kite_auto_complete=0.  If they do, but don't want Vim to insert the first option automatically, they should :set completeopt+=noinsert.  It's all explained in the readme and Vim's help (:help completeopt).

FYI I got the command slightly wrong above: it should be :verbose set completeopt?.

Hi @airblade, the user reports that both these behaviors (auto-inserting text and docs split window showing) still occur even after removing preview and noinsert from completeopt. Is there anything else we can try to debug?

Thanks for linking to the readme! I did want the Kite autocomplete but not the automatic insert as well as auto-closing the preview, so that did the trick.  It would be great if the readme were linked from the Kite Copilot since I didn't know about this repo.

Thanks for clarifying @khchen428. Can we close this issue now since you've resolved your issue?
I'll create a separate issue to track your suggestion on how to surface these helpful docs better.

Perfect, thanks!


WIP Design: Interface for handling tablet state migration

Some objected oriented design ideas to clean up Master code in TabletGroupWatcher.  The
idea is to replace the TabletGoalState enum with concrete classes, to eliminate some of the complex if/else statements and switch cases.  It starts with a Goal interface, implemented by two Abstract types (AbstractGoal + AbstractHostedGoal).  The concrete types are classes which combine current state + goal state.  The classes are one of two goal categories of HOSTED or not (UNASSIGNED, DELETED, SUSPENDED), since the work is the same for the non hosted goals.  I haven't figured out how to integrate the MergeState that is also used to determine the Goal state here.

Is the following the code you are trying to simplify?
https://github.com/apache/accumulo/blob/353c611891a8b88b307dcba5e884467d4191b1f2/server/manager/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java#L252-L343
How much of your goals could accomplished by replacing code blocks w/ functions like below?   I think you are also trying to simplify master.getGoalState() and possibly consolidate concerns that currently straddle master.getGoalState() and TabletGroupWatcher?  If that is true, then it seems like the following would not accomplish all of your goals.
          if (goal == TabletGoalState.HOSTED) {
            if (state != TabletState.HOSTED && !tls.walogs.isEmpty()) {
              if (master.recoveryManager.recoverLogs(tls.extent, tls.walogs))
                continue;
            }
            switch (state) {
              case HOSTED:
                if (server.equals(master.migrations.get(tls.extent)))
                  master.migrations.remove(tls.extent);
                break;
              case ASSIGNED_TO_DEAD_SERVER:
                hostTabletAssignedToDeadServer(...);
                break;
              case SUSPENDED:
                hostSuspendedTablet(...);
                break;
              case UNASSIGNED:
                hostUnassignedTablet(....);
                break;
              case ASSIGNED:
                hostAssignedTablet(...);
                break;
            }
          } else {
            switch (state) {
              case SUSPENDED:
                unassignSuspendedTablet(...);
                break;
              case UNASSIGNED:
                cancelOfflineTableMigrations(tls);
                break;
              case ASSIGNED_TO_DEAD_SERVER:
                unassignAssignedToDeadServerTablet(...);
                break;
              case HOSTED:
                unassignHostedTablet(....);
                break;
              case ASSIGNED:
                break;
            }
          }
          counts[state.ordinal()]++;
        }

As for the merge code, that code straddles FATE and the Tablet goal state code in a way that is hard to follow.  It may need improvement, but I am uncertain what the improvement is.

Is the following the code you are trying to simplify?
TabletGroupWatcher link

Yes that is where I started.

How much of your goals could accomplished by replacing code blocks w/ functions like below?

This is certainly an improvement.  We could make this change, regardless of any other refactoring I do.  It makes this code block easier to read at least.

I think you are also trying to simplify master.getGoalState() and possibly consolidate concerns that currently straddle master.getGoalState() and TabletGroupWatcher? If that is true, then it seems like the following would not accomplish all of your goals.

Correct.

As for the merge code, that code straddles FATE and the Tablet goal state code in a way that is hard to follow. It may need improvement, but I am uncertain what the improvement is.

I agree.  I was aiming for a design that would allow adding more states to handle this code as well.

After much pain looking at this code, I created #1761 with the best I can come up with for now. @keith-turner I incorporated some of your ideas into this change.  I will close this Draft design PR for now since #1761 may be the best that comes of it.


Check if provider is supported

Description

Fix logging message template - avoid key error
Unit test checks that key error is not thrown
Program logic will probably need to be updated, but not in this simple bug fix

Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] Unit test

/approve
fix the PR title and commit message to reflect that this is actually changing and i'll lgtm

/approve
fix the PR title and commit message to reflect that this is actually changing and i'll lgtm

Fixed. TY in advance

/lgtm


Are These My Bearer/User Tokens?

Ok sniffed my IPhone with success got my user packets with the info and found 2 long strings under the deviceTokens. Are these the bearer token (top) and user id (bottom)? http://prntscr.com/iuekmr

Those don't seem to be it. The bearer token should be longer and the user ID should be pretty short. https://github.com/gjacobs314/HQTrivia has sample bearer tokens and user IDs.


Updating to May 3 snapshot

Thank you :)

The README.md doesn't work on MacOS with beta.docker.com.
To get into the Swift REPL, I need privileged:
 +docker run --privileged -i -t --name swiftfun swiftdocker/swift:latest /bin/bash


Reproduction of GCN and SAGE

Hi, when i reproduce SAGE on Plantoid dataset  Citeseer and Pubmed, i get HR@100 on citeseer 37 while on pubmed 57. so i want to know if you may confuse the results, it seems a bit weird...

not only SAGE, GCN have the exactly the same problem..

Hi, Planetoid datasets do not have a predefined train-val-test split. Are you using the same procedure to generate the splits/links as in Appendix B.2?
We don't have access to all of our logs, but from what I can see, the results in the table are correct. Let me double check them later.

The crucial point is that my results are exactly the opposite of yours, rather than just different, which makes me suspect that something might have gone wrong somewhere. 😂


Fix 500 Error with branch and tag sharing the same name #15592

Fixed 500 error while create Pull request when there are more
than one sources (branch, tag) with the same name
The idea is to take branch instead of tag by default if the branch and tag name are equal
Fix #15592
Signed-off-by: Viktor Yakovchuk<EMAIL_ADDRESS>

Codecov Report

Merging #16040 (4d64461) into main (cbf3083) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main   #16040      +/-   ##
==========================================
- Coverage   44.08%   44.07%   -0.01%
==========================================
  Files         682      682
  Lines       82427    82447      +20
==========================================
+ Hits        36336    36341       +5
- Misses      40175    40188      +13
- Partials     5916     5918       +2

Impacted Files
Coverage Δ

modules/git/error.go
50.00% <0.00%> (-4.24%)
:arrow_down:

modules/git/repo.go
39.66% <0.00%> (-1.38%)
:arrow_down:

services/pull/pull.go
42.95% <30.00%> (-0.89%)
:arrow_down:

modules/charset/charset.go
71.71% <0.00%> (-4.05%)
:arrow_down:

modules/queue/workerpool.go
55.34% <0.00%> (+2.29%)
:arrow_up:

modules/queue/queue_channel.go
96.66% <0.00%> (+5.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf3083...4d64461. Read the comment docs.

Hmm... Do we ever not want to push to refs/heads? I suspect we should be making this determination before push fails in the first place.
I'll have a look.

Hmm... Do we ever not want to push to refs/heads? I suspect we should be making this determination before push fails in the first place.
I'll have a look.

Yes we want to push without "refs/heads" when we create Pull request from tag instead branch. If we always push with refs/heads we will be not able to create pull request from tag.

I would guess that we should be setting the correct ref in the PR instead.

As I understand it, you will have to rewrite a lot, especially the routing system, to understand from tag or branch we do Pull request. And as I see GitHub use similar routes and take branch as default when the branch and tag names are equal.

I think the pr.HeadBranch and pr.BaseBranch should have had the refs/heads/... in them and I am fairly certain that at some point I forcibly added this. Somewhere along the line this appears to have been dropped - which is fairly disappointing as this is precisely why I would have added this.

Hello, it seems to me that we have 2 options for solving the #15592:

this patch, perhaps with additional changes recommended by you
adding refs/heads wherever such operations occur

Еhe second option makes it impossible to create a PR from the tag, but I can see from code and interface that this functionality is planned, although it does not work yet.
I am ready to implement both options in a few days, which one should I choose?

@zeripath @lunny guys which way we choose to solve this problem?

We delete tags tab from source selector when create pull request (in all over cases we keep all as it is) sea also #15695 Also add "refs/heads" to the code.
We take my pull request and fix pull request from tag (now it doesn't work)

I am ready to prepare new PR after we choose a way to solve the problem.

OK you have a working fix that fixes the problem for now so I suspect we should merge this.
However, my suggestion is that we should be putting the correct thing in the PR from the start.
So, if you are creating a PR from a branch - then it gets the full ref name: refs/heads/branch.
If you are creating a PR from a tree - it's the full sha
If it's a tag then it's refs/tags/xxx
And so on.
The PR has to be correct and correct forever.
if we use aliases then as you've shown it breaks everything because the name is not a full unambiguous ref.

@techknowlogick  please take a look once time permit.


Add doc meta.setdocmeta by default

Closes #232

Similar to this commit I'll update files regarding to CI

ready for review

Excellent work, thank you!


Add loop unroll transformation

This PR introduces a new transform, and associated pragma (!$loki loop-unroll [depth(n)]), for unrolling loops. It supports nesting & the ability to only unroll nested loops to a certain depth.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

If you don't mind I suggest we try to merge #335 first and rebase this PR subsequently - that will give us an immediate indication if the failing regression tests for PRs from forks are resolved once and for all.


Adding missing header "memory"

Build apache arrow on fedora-33 with clang-11 failed with below xsimd error:
xsimd_ep/src/xsimd_ep-install/include/xsimd/types/../memory/xsimd_aligned_allocator.hpp:345:15:
error: no member named 'allocator' in namespace 'std'; did you mean 'alloca'?
std::allocator
^~~~~

@JohanMabille

Thanks o/


Deep linking support

This implements direct linking to people and "worship administrative units".
It can be tested by using the following url: http://localhost:4200/redirect?resource=add-resource-uri-here
If the type of the resource is supported it should go to the correct page, else it will show the index page instead for now.
Requires this branch in the backend app: https://github.com/lblod/app-contact-hub/pull/57

I'm merging this myself for now. It seems to work as expected. I just wanted some extra eyes on the implementation but we can always refactor in the future.


About Editor Deprecation

Hi,
I just saw that a few months ago you announced that VisEditor will be no longer maintained. Is it ok if I make a fork of this repository or even new repository whatever is better for you?  I was thinking to maintain it as much as I can. I am still not 100% familiar with all code but I will get there in a month or so. My idea is to translate all code into kotlin and then just maintain the whole project in kotlin that is why I think new repository would be better so I don't modify anything related to VIS UI.
Just let me know what you think and if everything is ok with you. I would still give you credit for it even if most of the code would be moved to kotlin.
Btw what are your plans with gdx-lml, autumn and other projects will you still maintain those? I can help here and there with features and maintenance.
Cheers.

Sorry for the delay. I think making a fork is simplest way and keeps visible reference to parent repo. After that you can remove ui, usl modules and modify build.gradle to use vis-ui from Maven repo instead of using module source code. Translating to Kotlin would be a good start. Depends on how much compatibility you would like to keep with previous version but it might be good idea to do some architecture refactoring while you have the chance.

Btw what are your plans with gdx-lml, autumn and other projects will you still maintain those? I can help here and there with features and maintenance.

Those are not mine projects, they are created by @czyzby. I think he still maintains them but now focusing on ktx.

Btw what are your plans with gdx-lml, autumn and other projects will you still maintain those? I can help here and there with features and maintenance.

Those are not mine projects, they are created by @czyzby. I think he still maintains them but now focusing on ktx.

That is correct. I don't actively develop libraries from this repository: I usually fix bugs, implement feature requests (with sensible scopes) and upload the libraries after a new LibGDX version comes out. I don't mind if you want to help with maintenance, although I do have to warn you that today there are multiple things I would have done differently - writing units tests is an obvious one.
Anyway, if you're into Kotlin, I strongly suggest looking into KTX. It basically solves all the problems that Kiwi, LML and Autumn attempt to solve, without introducing annotation hell or a new non-Kotlin DSL you have to learn.

@kotcrab Yeah I plan to change some architecture and refactor few things. But am more thinking move all code to kotlin then refactor and improve it with some new features or starting from scratch and using vis editor code as sort of reference. My idea was to use artemis entity as id instead of using Entity class.
I would probably use gdx-lml for UI or Autumn but will see.
Few questions:

Do i still need to call it VisEditor or can i change name, package names etc..?
Can i use old icons or do i have to create new icons, because i was thinking to change some parts of UI one day?

@czyzby
Yeah i saw ktx it is nice library i even wrote some kotlin extensions for libgdx that am using in my projects. Ok that is nice to know, i like lml and autumn just yeah too much annotations.
No worries i will create forks for all your repos and see what i can do.
Thanks.

I would probably use gdx-lml for UI or Autumn but will see.

From personal experience, Autumn and LML injection annotations do not go well with Kotlin. I might be wrong, as I was just starting out with Kotlin when I tried to pair these. Still, there's just too much ceremony with lateinit or nullable fields. Plain LML could work - and the painless hot UI reload is nice - but I suggest against using Autumn.
It may be depressing to hear from the original author, but Autumn requires quite a bit of learning, especially if you have no experience with Spring or enterprise-style dependency injection. Learning LibGDX and Kotlin and LML and Autumn to make a pull request might be too much for most people. If you want others to contribute, I suggest keeping it simple and going with something that most developers interested in VisEditor already know: (almost) plain LibGDX. If you're keen on using Kotlin, KTX should be non-invasive enough for LibGDX devs to understand.

Ok tnx for letting me know about kotlin and Autumn. Am almost 10 years in Java/JavaEE so am pretty familiar with dependency injections etc. I agree it should be as simple as possible that is why am in doubt for moving code to kotlin. But since Google announced kotlin will be main language for android am sure more ppl will learn kotlin.
Am used to JavaFX and FXML your LML reminds me on it and it makes everything more clear but yeah again if anyone wants to contribute there is a lot to learn like you said, specially artemis-odb, libgdx, dependency injection etc.
I think i will for now just make project and remove ui, usl, and add some features that i have ready locally, then i can slowly go and move it to kotlin.
Any other suggestions, ideas? What do you think project is missing etc?

Do i still need to call it VisEditor or can i change name, package names etc..?

You can, changing name would be probably a good idea anyways.

Can i use old icons or do i have to create new icons, because i was thinking to change some parts of UI one day?

You can use old ones or create new, doesn't really matter.

But since Google announced kotlin will be main language for android am sure more ppl will learn kotlin.

IIRC it will be officially supported but they didn't say it's going to be main language. Still, I'd recommend converting code to Kotlin and using KTX.

Thanks a lot for your answers.

Sure. Going to close this one.


Add Cursor Pointer to "Proceed as a" Section on Signup Page

Description
I found a bug on the Signup page where the "Proceed as a" section does not have the appropriate cursor pointer when hovered. This makes the section feel less interactive and may confuse users about its functionality.
Problem:

The "Proceed as a" section lacks the cursor: pointer property, which is a standard for clickable elements.
This may lead to a poor user experience as users might not realize that the section is interactive.

Screenshots
https://github.com/user-attachments/assets/214bbe6f-8707-407f-a82e-b3b719b5a676
Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@ansiace, I understand this is a genuine bug, but we're currently focusing on the backend of the login/signup pages for both sellers and customers. To avoid conflicts with our ongoing work, I'd recommend closing this issue for now. We'll revisit it once the backend changes are complete. Thank you!

Ok fine


Feature/apvs 806/new contact details page

SQUASHED COMMIT MESSAGE (e.g. apvs-123 - this message accurately describes my changes replacing the squashed concatenation)
High-level description - a few sentences on the overall context and goals for the PR's commits.
Checklist

[ ] Unit tests
[ ] End-to-End tests
[ ] Code coverage checked
[ ] Coding standards
[ ] Error Handling
[ ] Security/performance considered?
[ ] Deployment changes considered?
[ ] README updated

Also update get-claim-summary to use get-repeat-eligibility for consistency


Use torchrun instead of torch.distributed.launch

torch.distributed.launch is deprecated, torchrun is recommended. This simple change updates to make speechbrain compatible with torchrun.

Linked issue #1937

Hey @lucadellalib, could you please have a look? Thanks :)

I suppose we could assume that if RANK and LOCAL_RANK env variables are set, that the program was intended to be run in distributed fashion.

Okay @lucadellalib this is ready for review again.


Unsupported supercompression scheme: Zstandard

Bevy version 0.8
[Optional] Relevant system information
AdapterInfo { name: "NVIDIA GeForce RTX 3060", vendor: 4318, device: 9351, device_type: DiscreteGpu, backend: Vulkan }

What you did
Running example https://github.com/bevyengine/bevy/blob/main/examples/3d/skybox.rs
cargo run --features bevy/ktx2 bevy/zstd

What went wrong
It says that cannot render ktx2 files

Try cargo run --features bevy/ktx2,bevy/zstd

Same error

Try cargo run --features bevy/ktx2,bevy/zstd

That isn’t the same error. GPUs support only specific compressed formats in the hardware itself. Usually desktop GPUs support BCn codecs, and mobile support ASTC and perhaps ETC2. The example cycles through them to show which work on your system.

Perhaps the error could be slightly improved here, saying that the hardware doesn't support the format, and not the software.


ipython_magic.py essential changes:

Changes made to existing cell magic that ignored config.media_embed changes after manim refactoring
Additional feature for %manim --quick-setup line magic added to ipython_magic.py

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Would you like to elaborate on your changes and why you did them?
It is helpful for us to understand why changes are made and not just what was changed.
Please note, that if a PR is not ready for review you can mark it as draft.
Thanks for participating in contributing to Manim ✨

Please see the updated markdown

Part of this PR seems to be based on a misunderstanding (caused by the media_embed config option not being documented particularly well).
The media_embed option isn't meant to control whether or not generated media is displayed in a notebook. It controls the way how exactly rendered videos are being displayed.
If config.media_embed is set to False, the HTML tag used to display the rendered video is, roughly, <video src="media/jupyter/..." ...>...</video>. Otherwise, if config.media_embed is True, the reference to an external file is avoided and the video is fully included in binary (base64-encoded) form in the video tag. For longer videos or ones with higher resolution, this substantially increases the file size of the HTML file (which is best avoided to keep the browser responsive, in general).
In the special case of config.media_embed is None (the default) we check whether the notebook has been spawned on Google Colab -- in which case media has to (or at least had to, at the time of implementation) be embedded directly to the notebook, so it acts as if the option was set to True. Otherwise, it behaves just like in the False case.
The documentation of this config option should be made more clear to reflect this.
The quick-setup utility proposed here then is again something completely different. We actually do have something like it already with our manim init CLI utility. It feels a bit weird to start a new project from an existing notebook though, and it might make more sense to put more effort into making manim init more useful.
Can you explain the usecase for the quickstart via the %%manim-magic a bit more, or share your thoughts on where manim init is lacking in comparison?


Filter relations

Hello,
For example I have posts resource that has many comments. My goal is to load only coments that has id of the following 1 and 2, how I can do that using this package?

There are two cases Querying Relationship Existence and  Constraining Eager Loads I'm interested in.
Querying Relationship Existence
// Retrieve posts with at least one comment containing words like foo%...
$posts = App\Post::whereHas('comments', function ($query) {
    $query->where('content', 'like', 'foo%');
})->get();

This one should be placed in filter method in Adapter I suspect?
Constraining Eager Loads
This one I"m stuck with. For example:
$users = App\Post::with(['comments' => function ($query) {
    $query->where('title', 'like', '%first%');
}])->get();

Where I should place this code using this package?
Thanks

The package already supports:
GET /api/comments?id[]=1&id[]=2
Or:
GET /api/posts/123/comments?id[]=1&id[]=2
Yes the querying relationship existence should be placed in the filter method.
For the constraining eager loads, you'll need to overload this method on your adapter:
https://github.com/cloudcreativity/laravel-json-api/blob/develop/src/Eloquent/Concerns/IncludesModels.php#L96-L101

Wow, it's a good tip!
What about if I want to specify query in parent resource ( because need to retrieve it as well ), request would look like:  GET /posts/1?filter[comments.id][]=1&filter[comments.id][]=2?
So in such case I need to provide filter ( as in example ) and overload mentioned method?
Thanks for your time!

So my general tip with these things is write the Eloquent query first and get that working outside of this package first... then it's just a matter of dropping that into the filter method.
For the thing you've asked about, it would be something like this (I haven't tried, so you'll need to check if I've got any typos!)
$query->whereHas('comments', function ($q) use ($filter) {
   $q->whereKey($filter['comments.id']);
});

With whereHas is pretty much clear where to place it.
Let's say I have the following query: GET /posts/1?filter[comments.id]=1,2
My goal is even if post doesn't have comments with ID 1,2 I want posts resource to be returned.
It's something that SPEC it self allows, correct me if I'm wrong.
The problem with whereHas is that in such scenario it will not work out and that's why I need to use with .
The question is where I can put code block with with logic and apply filters from filter.
For example where I should place such block:
if ($comments = $filters->get('comments.id')) {
   $query->with(['comments' => function($q) {
        $q->wherein($comments);
   }]);
}

I'm sorry, I think I have confused you and hope this comment will make things explained.

That code block can go in the filter method, because the filter method is invoked if there are any filters!
Whether it works for what you're trying to do, I have no idea. If it doesn't, give me the complete Eloquent query that you would run to replicate what you're trying to do outside of this package. Then we can work out where to put it in the adapter to replicate it. However if you're not able to write an Eloquent query for what you're trying to do outside of this package, it will never work within this package!

That code block can go in the filter method, because the filter method is invoked if there are any filters!
I think it is the answer to my question, thanks.


Implemented basic pipeline for Refitting

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project (You can use the linters)
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[ ] I have added tests to verify my fix or my feature
[ ] New and existing unit tests pass locally with my changes
[ ] I have added the relevant labels to my PR in so that relevant reviewers are notified

1 AI: take https://github.com/pytorch/TensorRT/blob/3422c41f165c3cf0833468b0cb548149ca78e057/py/torch_tensorrt/fx/converters/converter_utils.py#L101 and copy it into https://github.com/pytorch/TensorRT/blob/3422c41f165c3cf0833468b0cb548149ca78e057/py/torch_tensorrt/dynamo/conversion/converter_utils.py. Modify to use the naming scheme that you have designed to work with refit.
Replace all uses of set_layer_name inside torch_tensorrt/dynamo/conversion/impl and torch_tensorrt/fx/converters with your implementation.
cc: @peri044

1 AI: take
https://github.com/pytorch/TensorRT/blob/3422c41f165c3cf0833468b0cb548149ca78e057/py/torch_tensorrt/fx/converters/converter_utils.py#L101
and copy it into https://github.com/pytorch/TensorRT/blob/3422c41f165c3cf0833468b0cb548149ca78e057/py/torch_tensorrt/dynamo/conversion/converter_utils.py. Modify to use the naming scheme that you have designed to work with refit.
Replace all uses of set_layer_name inside torch_tensorrt/dynamo/conversion/impl and torch_tensorrt/fx/converters with your implementation.
cc: @peri044

@cehongwang  can you work with @keehyuna  as he also is modifying set_layer_name in this PR ? https://github.com/pytorch/TensorRT/pull/2853#pullrequestreview-2109004549

1 AI: take
https://github.com/pytorch/TensorRT/blob/3422c41f165c3cf0833468b0cb548149ca78e057/py/torch_tensorrt/fx/converters/converter_utils.py#L101
and copy it into https://github.com/pytorch/TensorRT/blob/3422c41f165c3cf0833468b0cb548149ca78e057/py/torch_tensorrt/dynamo/conversion/converter_utils.py. Modify to use the naming scheme that you have designed to work with refit.
Replace all uses of set_layer_name inside torch_tensorrt/dynamo/conversion/impl and torch_tensorrt/fx/converters with your implementation.
cc: @peri044

@cehongwang can you work with @keehyuna as he also is modifying set_layer_name in this PR ? #2853 (review)

Sure. I have reached out.

Add an attribute to TRTEngine that takes the serialized form of the compilation settings

Testing plan:

Test graph matching stand alone.

Given a graph, create an exported program and a compiled exported program and make sure that you can match the weights 1:1.

Given a single engine exported module and a new set of weights see if you can refit and the outputs match
Given a exported module that has graphs in pytorch and trt see if we can replace the weights for all TRT engines and correctly produce the same outputs.


change "Query builder" to "Advanced search"

Can we change the search tab/page title from "Query builder" to "Advanced search"?

it will make for less text editing throughout the FAQs and other documentation;

it's a more accurate description of the page, since it includes results, and will eventually also have result-customization stuff, as well as the query-building gubbins; and

small thing, but it'll be more consistent with the plain box being called the "simple search".

I've changed it, although I couldn't find many occurrences.  If I've missed any please let me know.

I really dislike like the name "advanced search" there isn't  really anything  "advanced" about it.
Query builder doesn't  accurately describe what it does, but neither does "search".
I don't have any ideas though so we are probably stuck with this.

I really dislike like the name "advanced search" there isn't really anything "advanced" about it.

I'm neutral on the name but I think the search is quite advanced, or at least it will be soon.  :-)

OK. I think its simple. but renaming things is a pain....


nvidia: Bump beta driver to 361.18

Including some more build fixes for that. These will presumably be useful for the default version, eventually.

It turns out that, despite setting boot.extraModulePackages = [ pkgs.linuxPackages.nvidia_x11_beta ];, the stable driver is the one that's loaded. It compiles the beta version, it just doesn't use it.
Any tips?

It seems we have no proper support for plugging in the beta driver. Currently we allow "nvidia" and "nvidiaLegacy*"  values of the drivers, so I suggest we just add "nvidiaBeta" to that list.

Will you test running it? Additional code for my suggestion is simple:
diff --git a/nixos/modules/hardware/video/nvidia.nix b/nixos/modules/hardware/video/nvidia.nix
index 7115769..e89f574 100644
--- a/nixos/modules/hardware/video/nvidia.nix
+++ b/nixos/modules/hardware/video/nvidia.nix
@@ -14,6 +14,8 @@ let
   nvidiaForKernel = kernelPackages:
     if elem "nvidia" drivers then
         kernelPackages.nvidia_x11
+    else if elem "nvidiaBeta" drivers then
+      kernelPackages.nvidia_x11_beta
     else if elem "nvidiaLegacy173" drivers then
       kernelPackages.nvidia_x11_legacy173
     else if elem "nvidiaLegacy304" drivers then

I've tested it. Unfortunately it doesn't work, and I don't think it has to do with the stable/beta difference. nvidia changed something in between versions; now none of my applications can use it, and there's no error messages that I can see.
Well, some:
➜  nvidia git:(nvidia) ✗ glxinfo                                                                                ~/dev/nvidia
name of display: :0
Error: couldn't find RGB GLX visual or fbconfig
Error: couldn't find RGB GLX visual or fbconfig

I think this one's a bit beyond me.

Hmm, I also see no relevant error message (except for glxinfo).

I bet it has to do with the GLVND infrastructure they're referring to in the release notes. I checked to make sure that all included libraries are installed, although since GLVND is open-source we might actually want to build that separately... anyway, nothing obvious there.
They do seem to be bundling libglx.so, for the first time, so that might be causing problems. I'm not sure what version of libglx it'd be, or what to do about it. I'd probably need to look at how it gets installed on a more traditional Linux system; Ubuntu or so.
Anyway, it'd be good to have this working before the driver leaves beta, but I don't think I'm likely to succeed. I'll take another poke or two at it, but you shouldn't expect anything.

Bundling libglx for the first time? It certainly was even in previous releases: /run/opengl-driver/lib/xorg/modules/extensions/libglx.so.358.16 on my system ATM.

We won't be able to switch to the branch before we fix it :-) ATM I've got personally other stuff with higher priority. Maybe someone else will fix it in the meantime.

Oh, sorry for the confusion. 361.18 has both libglx.so.361.18, which is presumably the X module, but also libGLX.so.0... which from the disassembly appears to be a thin wrapper for glvnd.
The Goobuntu system I'm sitting in front of right now, actually doesn't have libGLX at all. It's also on 340, though. I'll definitely need to see this package in action on a real system. I'll probably find time for that tomorrow.

@vcunat -- It's been somewhat more than a day, but I never could figure out what the problem was, save that it's caused by GLVND.
So for now, I've changed the build script to select the legacy driver. I'm running a system with it right now; OpenGL works. Meanwhile the non-beta driver also bumped, so I'm also including that.

So at this commit 361.28 runs for you good, right?

Right.

It runs fine for me as well. Thanks.

Has anyone noticed new segfaults after this merge? Since I switched to this, I'm getting some even segfaults with binaries that worked previously, so it has to be some impurity and we don't have so many...

Can't say I have.
What sort of segfaults? In OpenGL apps, or..?

So far only when I quit (g)vim or when I start vlc. It might be some other impurity. We'll see in time, I hope.

Can also confirm the above segfaults in vlc (on start) and gvim (on exit) using the "nvidia" driver on master, which are due to a segfault in "__eglTeardownVendor" from libEGL provided by the nvidia-x11 package according to valgrind.

Another segfaulting app is mplayer. While I think it's likely that the issue is with libEGL (which is a binary provided by nvidia in this driver) I have little understanding of the internals of OpenGL. This topic on the nvidia forums could be the same issue, although I had the same issue with running nixos vlc versions going back to 2.1.5 (I should really gc at some point :-) ).
I'll have a closer look and submit more information to nvidia at some point, unless someone beats me to it. Going to have to revert this locally for now.

The GLVND libraries do work, but you must create version symlinks to specific libraries.  The libraries being libGLX_nvidia.so.0, libEGL_nvidia.so.0, libGLESv1_CM_nvidia.so.1, libGLESv2_nvidia.so.2, & libGL.so.1.
https://devtalk.nvidia.com/default/topic/915640/unix-graphics-announcements-and-news/multiple-glx-client-libraries-in-the-nvidia-linux-driver-installer-package/
Fixing this will resolve the random segfaults you are encountering when libEGL looks for the library named with a specific version that doesn't exist at runtime.
https://github.com/triton/triton/blob/master/pkgs/all-pkgs/nvidia-drivers/builder-generic.sh

Ah. @codyopel: would you file a PR for this against https://github.com/NixOS/nixpkgs?


Elasticsearch output broken after ES outage

I've got cluster with following configuration:

2 ES master& data nodes
2 td-agent nodes with in_forward and out_elasticsearch with elasticsearch client node (data: false, master: false) on each node.

One day ES masters gone down because of memory issues. After recovery td-agents cannot send data to ES:
2018-03-03 15:08:12 +0000 [warn]: #0 Could not push logs to Elasticsearch, resetting connection and trying again. Connection reset by peer (Errno::ECONNRESET)
2018-03-03 15:08:14 +0000 [info]: #0 Connection opened to Elasticsearch cluster => {:host=>"localhost", :port=>9200, :scheme=>"http"}
2018-03-03 15:08:14 +0000 [warn]: #0 Could not push logs to Elasticsearch, resetting connection and trying again. Connection reset by peer (Errno::ECONNRESET)
2018-03-03 15:08:14 +0000 [debug]: #0 Created new chunk chunk_id="56683764ad5e859d4104ac357491e5ef" metadata=#<struct Fluent::Plugin::Buffer::Metadata timekey=nil, tag="syslog.daemon.info", variables=nil>
2018-03-03 15:08:18 +0000 [info]: #0 Connection opened to Elasticsearch cluster => {:host=>"localhost", :port=>9200, :scheme=>"http"}
2018-03-03 15:08:18 +0000 [debug]: #0 taking back chunk for errors. chunk="566745dbaa61f7ac3626ec83f956d0c2"
2018-03-03 15:08:18 +0000 [warn]: #0 failed to flush the buffer. retry_time=1 next_retry_seconds=2018-03-03 15:08:08 +0000 chunk="566745dbaa61f7ac3626ec83f956d0c2" error_class=Fluent::Plugin::ElasticsearchOutput::ConnectionFailure error="Could not push logs to Elasticsearch after 2 retries. Connection reset by peer (Errno::ECONNRESET)"
  2018-03-03 15:08:18 +0000 [warn]: #0 suppressed same stacktrace

ES node on localhost was actually alive:
# curl -XGET localhost:9200
{
  "name" : "harvester-gce-eu-1",
  "cluster_name" : "logs",
  "cluster_uuid" : "BY1pbzMbQJyL3KcgSY3qcA",
  "version" : {
    "number" : "6.2.2",
    "build_hash" : "10b1edd",
    "build_date" : "2018-02-16T19:01:30.685723Z",
    "build_snapshot" : false,
    "lucene_version" : "7.2.1",
    "minimum_wire_compatibility_version" : "5.6.0",
    "minimum_index_compatibility_version" : "5.0.0"
  },
  "tagline" : "You Know, for Search"
}

I've used tcpdump to check if there waere really resets and found this error message from ES:
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"text is empty (possibly HTTP/0.9)"}],"type":"illegal_argument_exception","reason":"text is empty (possibly HTTP/0.9)"},"status":400}
output config:
<match **>
  @type elasticsearch
  @log_level debug
  host localhost
  port 9200
  target_type_key @target_key
  type_name fluentd
  target_index_key target_index
  logstash_format true
  logstash_prefix fallback
  time_key @timestamp
  include_timestamp true
  reload_on_failure true
  <buffer>
    @type file
    flush_interval 10s
    retry_timeout 10d
    path /var/lib/td-agent/buffers/output_elasticsearch
  </buffer>
</match>

Ubuntu 14.04
td-agent 3.1.1-0
elasticsearch 6.2.2

This seems the plugin issue, not fluentd core. Closed.
If this problem is related with fluentd core, please reopen.


Error in utils.js

Hi all,
there is al littel error/type in the excercise 3.
Im the Utils.js the ajax post call has the wrong url:
$.ajax({
type: "POST",
url: "country/country.xsjs",
should be change to:
$.ajax({
type: "POST",
url: "/country.xsjs",
thx and br,
fabian

https://github.com/SAP/cloud-xsa-hybrid-deployment-tutorial/tree/master/exercise2#step-4---adding-business-logic-with-javascript suggests to place the country.xsjs under a country subfolder. Seems like you omitted that, but debugged the issue successfully yourself :)


MRG, ENH: Add inner surface option to coreg

Add option to control appearance of opaque inside surface of the head to mne coreg
Make the opaque surface always disappear in fiducials mode (it's not ever really helpful there)

Closes #8791

thx @larsoner

thx @larsoner


get_unit_cost and zerg buildings

The Bot::get_unit_cost method returns uncorrected values for zerg buildings, which include additional 50 minerals (the cost of a drone). For UnitTypeId::SpawningPool the returned value is 250. Since the aforementioned method is used to implement Bot::subtract_resources I'd suggest fixing this behaviour. It's counter-intuitive that Bot::subtract_resources(UnitTypeId::SpawningPool) subtracts 250 minerals, and the real mineral counter and the bot.minerals counter become out of sync for the rest of a step.

Should be fixed now in e1187ea.

Thank you. Can confirm: now it works as intended.


Add barebones roadmap to docs

Travis links are a little funky because of the name change.

The travis build had a stochastic failure on the old name. Build was restarted, but I dont know if the status can be accurately updated. I temporarily disabled the pass requirement for travis so we can merge this.

This has now been merged into the other docs pull request #57 .


Document example setup

For a non python developer like me it is not very easy to understand how to set up the examples.
I would be happy to document this but I would need some basic info. For example, I first installed ChatterBox given following command:
pip install chatterbox

Unfortunately, when I try to run basic_example it fails:
$ python basic_example.py
List Trainer: [#######             ] 33%Traceback (most recent call last):
  File "basic_example.py", line 12, in <module>
    "Your flight has been booked."
  File "/usr/local/lib/python3.7/site-packages/chatterbot/trainers.py", line 110, in train
    statement = self.get_or_create(text)
  File "/usr/local/lib/python3.7/site-packages/chatterbot/trainers.py", line 48, in get_or_create
    statement = self.storage.find(temp_statement.text)
AttributeError: 'ChatBot' object has no attribute 'find'

Martin, see: https://github.com/gunthercox/ChatterBot/issues/1426

I proposed a fix based on the comments: https://github.com/gunthercox/ChatterBot/pull/1529


Clan to Team esports page renaming

Context
We're using a legacy & internal name on the esports page leading to confusion for customers.
This change replaces the usage of the word clan to the word team on the /league page.
Translation effort is out of scope of this PR. This PR is more of an initial quick fix. I've added some small i18n improvements where it makes sense but the page remains mostly hard coded in English for now.
How

Change static text from clan to team across page and Clan/Team update modal.
Replace Clan with Team in autoclan descriptions that are automatically generated. Quick hack as we want to better handle this server side.

Risk
Minimal risk as text changes.
How to test
Navigate to localhost:3000/league and note the lack of clan verbiage on the page.
Clicking on an autoclan will no longer have Clan for description used.
Screenshots
Example of autoclan description changed:

Team heading on leaderboard:

Some text

Thanks for catching that @codeluggage !

Thanks for catching that @codeluggage !


it's possible to add a scheduled monitoring feature to activate file monitoring at a specific time.

[NEW Feature]
it's possible to add a scheduled monitoring feature to activate file monitoring at a specific time.

No. Prometheus and service discovery are the compenents that are timing the monitoring

@michael-doubez Thank you very much for your reply, but I found out whether another exporter that monitors sql statements supports timing to grab data.
This is url :
https://github.com/albertodonato/query-exporter
schedule: a schedule for executing queries at specific times. This is expressed as a Cron-like format string (e.g. */5 * * * * to run every five minutes). If a value is specified for schedule, an interval can't be specified. If no value is specified (or specified as null), the query is only executed upon HTTP requests.
I looked at it, and her implementation principle is to capture metrics at a specified time, and the metrics cannot be captured at a non-specified time.

Actually, it makes sense in case of a slow NFS by example.

I've added the tree feature in #42 .
I am planinng on adding a url parameter to metrics collection such that different tree (root) can be polled at different speed.
That way, one can poll /slow/ filesystems with an interval of ~4minutes (with a bigger timeout) while polling other more often.
This is not really what you asked for but keeping cache of metrics is a snake pit.
It you really need to take snapshots, I could add a feature for exporting metrics to a pushgateway.

@michael-doubez Very good, I have been paying attention to this feature

Sorry for the delay.
Prometheus client is not friendly with url parameters - it will take time

Too old

@michael-doubez it is ok. Take you time.


Add description for create personal credentials in Marvel API

Documentation: https://developer.marvel.com/documentation/getting_started

Hi! Can i take this one?

Hello @josemariogutierrez, sure, you can!


[error]A supported task execution handler was not found.

Does the extension work with tfs 2018 release?
[error]A supported task execution handler was not found. This error usually means the task does not carry an implementation that is compatible with your current operating system. Contact the task author for more details.

Hi, this extension was made for only for Azure pipelines. I have never been asked or tried to test this extension on TFS.
It's out of scope for this extension but you can test on your own.


improve numerical stability of the Rice distribution

this is a follow-up to gh-2841.
The idea is by @josef-ptk.

I just noticed that with this change, the "See Also" section of the docstring for vonmises_line refers to itself; see https://github.com/scipy/scipy/issues/6358.


ISPN-8524 ScatteredDelayedAvailabilityUpdateTest.testDelayedAvailabil…

…ityUpdate5 failing randomly
https://issues.jboss.org/browse/ISPN-8524

Integrated, thanks Radim!
Can't believe I left this in the PR queue for so long, but at least you didn't have to rebase all the time :)


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JohnTzoumas sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Make stackdiff-dtrace.py a little more tolerant

Motivation:
Some of the output from 'malloc-aggregation.d' trips up the
'stackdiff-dtrace.py' script -- especially when used with the output
from recent 5.4 builds. The regex for numbers includes hex which trips
us up when we try to convert that match to an int. Since we only use
this pattern for matching allocation counts, where we don't expect hex,
we can just modify the pattern.
Also the input parsing is a little tricky to follow without context so I
tidied it up little.
Modifications:

relax the number regex (we don't expect counts to be in hex)
drop the stack regex (it wasn't used)
aggregate the current stack in a list (instead of a string)
filter out non-stack lines (which were erroneously used to key the
first stack!)
a few comments

Result:
stackdiff-dtrace.py doesn't blow up on output from newer builds

@swift-nio-bot test this please

CI broken, I'm going to merge this still.


Add DeepOnion

Description
Add the DeepOnion Blockchain to the project
Testing instructions
Unit tests as per the integration guide have been added.
Types of changes
Added DeepOnion coin and blockchain info to the project as well as integration tests.

[X] Prefix PR title with [WIP] if necessary.
[X] Add tests to cover changes as needed.
[X] Update documentation as needed.

Yes

@nezero can you take a look at the requirements before moving any further: https://developer.trustwallet.com/wallet-core/newblockchain#requirements

@nezero can you take a look at the requirements before moving any further: https://developer.trustwallet.com/wallet-core/newblockchain#requirements

Adding Support for a New Blockchain

Yes, I read this before starting. The only point that we don't meet is "top 100 on CMC" and this is not something we can't really control unless we follow some of the other projects and generate a few trillion coins, though fake market caps is not what our project is about.

@hewigovens had an email that you commented, but I can't see it.
It is a bitcoin fork, however the blockchain is modified slightly with the addition of a timestamp on transactions.

Can someone trigger the iOS Tests again?
Looks like there was an infrastructure issue while the tests were running.
Job issues · 1 error The agent: Hosted macOS 2 lost communication with the server. Verify the machine is running and has a healthy network connection. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

@hewigovens can anyone help us out with a review on this?

Thanks for your efforts, but as https://github.com/trustwallet/wallet-core/pull/528#issuecomment-504722853 said, let's close it now