Fix for "leaf Variable that requires grad" Error in In-Place Operation

Issue:
The current implementation in the file peft/tuners/lora/layer.py encounters a runtime error due to an in-place operation on a leaf variable that requires gradient computation. Specifically, the error is triggered by the following line of code:
result += (after_A @ embedding_B) * scaling
This line uses the += operator, which modifies the result tensor in-place. When result is a leaf variable with requires_grad=True, such in-place operations are incompatible with PyTorch's autograd system, leading to a "RuntimeError: a leaf Variable that requires grad is being used in an in-place operation".
Solution:
To resolve this issue, I propose modifying the in-place operation to a regular operation that creates a new tensor. This change ensures that the original value of result is not altered, thereby maintaining compatibility with the autograd system. The updated line of code is as follows:
result = result + (after_A @ embedding_B) * scaling
This modification allows the computation to proceed without altering the original result tensor, thus avoiding the RuntimeError and ensuring proper gradient calculation during backpropagation.
Therefor, before modification I encountered
"RuntimeError: a leaf Variable that requires grad is being used in an in-place operation."
However, I revised like that it solved!
Best

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelka I tried CASUAL_LM and mixtral model..!

@younesbelkada also I changed lora/bnb.py for fix the error which written in below
RuntimeError: Output 0 of MatMul8bitLtBackward is a view and is being modified inplace. This view was created inside a custom Function (or because an input was returned as-is) and the autograd logic to handle view+inplace would override the custom backward associated with the custom Function, leading to incorrect gradients. This behavior is forbidden. You can fix this by cloning the output of the custom Function.

@pacman100  I will fix all of the layers and will mention again..!
Thanks for your recommendation..!

Thanks @DopeorNope-Lee ! Let us know if you need any help

Thanks @DopeorNope-Lee for providing this PR. Do you have a minimal code example that demonstrates the error with the in-place operation?

Thanks @BenjaminBossan I saw the PR in your mention. But it have some difference.
First, above the codes are related to full-finetuning(someone say it continuous pre-train). However, in place errors occurs in fine-tuning cases.
So I revised all of '+=' operator to 'a = a + b' like this.
@younesbelkada Hi, I revise all of operators in Lora layers. However I saw 'conflicts that must be resolved'.
I think the previous code used copy method, but the recent version uses clone method.
So I also updated it!
Is there anythings more to follow up?

First, above the codes are related to full-finetuning(someone say it continuous pre-train). However, in place errors occurs in fine-tuning cases.

Thanks for explaining. I wrote a small test to check full fine-tuning and didn't encounter any error when training. Could you please provide a minimal example? This is also important to have as a unit test so that we can prevent regressions in the future.

@BenjaminBossan Did you add embed?_tokens in target module?

Did you add embed_tokens in target module?

I added this test to test_custom_models.py:
    @parameterized.expand(TEST_CASES)
    def test_training_full_finetuning(self, test_name, model_id, config_cls, config_kwargs):
        # check if training the full model works, no error is raised; only check custom models since they are small
        # so full finetuning shouldn't take too long
        model = self.transformers_class.from_pretrained(model_id)
        config = config_cls(
            base_model_name_or_path=model_id,
            **config_kwargs,
        )
        model = get_peft_model(model, config)
        model = model.to(self.torch_device)
        model.train()
        model.requires_grad_(True)  # make all parameters trainable

        optim = torch.optim.SGD(model.parameters(), lr=0.1)
        inputs = self.prepare_inputs_for_testing()

        for _ in range(5):
            optim.zero_grad()
            output = model(**inputs)[0]
            loss = output.sum()
            loss.backward()
            optim.step()

These tests include examples with embedding layers in the target_modules.

@BenjaminBossan How about trying the mixtral model with LoRA layer? I think this error did not occurr from Full-finetuning, fine-tuning. LoRA fine-tuning

How about trying the mixtral model with LoRA layer?

I see, thanks. I don't have a machine available to test full mixtral, so I couldn't test it.

@BenjaminBossan Then may I help you with testing the LoRA fine-tuning mixtral?

Then may I help you with testing the LoRA fine-tuning mixtral?

Thanks, that's not necessary. My main concern is to have some kind of test to ensure that we don't have regressions in the future, but maybe that's not easily possible here? I tried a tiny mixtral model I found on HF but that didn't trigger any error. Running full mixtral won't work on our CI.

@BenjaminBossan Have you tried fine-tuning with LoRA?
I attempted fine-tuning using LoRA.
It's an instruct-tune utilizing LoRA, not full fine-tuning.
But your previous code looks full-fine-tuning, I think..

Well, we have a bunch of tests for fine-tuning with LoRA. I wrote the test for full fine-tuning because you had said earlier:

above the codes are related to full-finetuning

Maybe I misunderstood what you meant.

@BenjaminBossan
It seems we both misunderstood each other thinking the other discussion( #1425 ) was about full-finetuning.
However, the issue I'm referring to here is the instruct tuning (fine-tuning) using LoRA adapters through load_in_4bit.
After hearing your words, I've also started a training test with a new initial environment.
It would be great if we could run this together and share related information.
I'm very grateful for your contribution to this open-source.

It seems we both misunderstood each other

These things happen, glad we're now on the same boat.

After hearing your words, I've also started a training test with a new initial environment.
It would be great if we could run this together and share related information.

Thanks. If you have something to share, let me know. At the end of the day, if we have confirmation that this PR fixes a real world issue, even if we cannot add it to a unit test, it's fine with me. Maybe we can upload the script somewhere and add a link to it as a comment.

@BenjaminBossan Sure!
Moreover, I'm sharing recent test result using Mixtral LoRA finetuning.

@DopeorNope-Lee Could you please run make style on your changes? This might require to update ruff to work correctly. I think the issue is the excess empty line 493.

@BenjaminBossan I run make style and push it!

 @DopeorNope-Lee could you please fix the small merge conflict?
@younesbelkada @pacman100 do you have further comments?

@BenjaminBossan Sure, I fixed it.!

@pacman100 @younesbelkada  @BenjaminBossan  Hi?
I think we are ready to merge it.
I tried to merge it, but two pending reviews were left.
Therefore, I failed to merge it.
Could you approve my PR?

@DopeorNope-Lee I think the last merge with main resulted in incorrect code, with weights being merged twice, resulting in the failing CI. Could you please take a look?

@BenjaminBossan
Hmm...
It seems there was an error while resolving a conflict with the existing code.
So, I've brought over the current version of layer.py and made modifications in the same manner as my previous PR changes. Can you check this for me?

Thanks @DopeorNope-Lee for correcting the resolution to work as intended. This LGTM now.


ptrELM needs to be replaced by ptrElm

In EmatFile class, in eeqv method
f.seek(self.header['ptrELM'])
needs to be replaced by
f.seek(self.header['ptrElm'])
for Ansys19.2  because the actual header of emat file contains ptrElm

Thanks for noting that.  I've added a test for that and fixed it in https://github.com/akaszynski/pyansys/commit/45318782aa055453f9c47e9797ebd309b0ef15e9.


Why don't need android.permission.CAMERA

Well ,This maybe not a problem.
Since this library supprt capture function ,but I  can't found android.permission.CAMERA any where. It also without any reqeuest permission about Camera etc. mean while all the capture works well.
I'm just curious how this happened.

This function is in developping state, I know it from the wiki


Add linter for future reserved words

Thank you for your interest. Please refer to the Contributing link in the sidebar for guidance. Be sure to reference an existing issue number in your pull request description.
Fixes https://github.com/skeema/skeema/issues/120
I took the liberty of making it a warning. It seems useful to me.

Thanks for the PR! I'll aim to review later this week.
The most recent test failure is just from the Dockerized db being flaky / dropping conns or timing out. Seems to be happening at random on GitHub Actions the past few weeks, although I can't ever repro it locally 🤷 I just kicked off a re-run, usually it works fine the second time. If not, I'll try again at a later hour.

Coverage: 93.281% (+0.02%) from 93.263% when pulling bf7e4aead9646b05226d64577b896de83ae5d0c1 on morgo:lint-future-reserved-words into 94eaa998fbb9d9bc2b76da64a5f60b01753b76ca on skeema:main.

Thanks again for the PR!
One tricky wrinkle here is that whenever Skeema dumps a CREATE TABLE statement to the filesystem (skeema init, skeema pull, skeema format, etc), it uses the canonical format from SHOW CREATE TABLE, which means all table names and column names will be backtick-quoted. And some tables/columns may be using names that are already reserved words (for the current db version), and that's legal SQL due to the backtick-quoting.
So as a result of that, I believe this linter implementation would flag those too right? i.e. it's not strictly finding future reserved words. If so, I could see a couple paths forward:
(a) Keep the implementation as-is, but change the linter annotation wording, to not be about "later" releases / "forward-compatibility" etc
or
(b) Keep the focus on future reserved words by tracking the version which introduces each reserved word, and only flag ones which aren't already a reserved word in the user's current DB version
There's almost certainly other approaches I haven't considered, so also totally open to discussing alternatives.
Of these two, (a) is simpler but potentially noisier. In my experience, whenever a company had the misfortune of picking a reserved word for a table or column name long ago, the engineers tend to already be acutely aware of it -- from the constant need to use backticks around the name in ad-hoc SQL queries. So having Skeema complain about it further might just be frustrating. They could disable the linter rule to avoid that, but then they lose the benefit of future-proofing new tables and columns.
Similarly, regarding MySQL-specific vs MariaDB-specific reserved words: Some companies try to remain cross-compatible, but others likely don't ever plan to migrate between the two, so flagging the reserved words from the other DBMS may be viewed as noisy.
(b) feels more useful, but is trickier to implement. Because both MySQL version X and MariaDB version Y can hypothetically introduce the same reserved word, the data structure for tracking versions would likely need to be map[string][]tengo.Flavor -- that is, a mapping from (lowercased reserved word) to (slice of flavors that introduce this reserved word). For example, "except": []{tengo.FlavorMySQL80, tengo.FlavorMariaDB103}. One benefit though is that the list of reserved words to track is much smaller: anything appearing on both MySQL 5.5 and MariaDB 10.1's reserved word lists can be omitted entirely, since Skeema doesn't support versions older than that, so there's never a case where those ones are "future" reserved words.
If going with (b), the last arg to the checker function will be useful -- it's a linter.Options struct value, which contains a  Flavor field indicating what dbms + version the user is actually running. The tengo.Flavor.Min() method can be used for comparisons.
I'll likely have some additional review comments later, depending a bit on which approach is taken.

Just committed 4c2ddd0 on top, which reworked this a fair bit -- see that commit message for reasoning. To be clear, there was nothing wrong with your original implementation here, it was great and the PR is hugely appreciated 👍 It just made sense to make those changes on top, as they're in alignment with some other upcoming work.


Runelite crashing randomly when teleporting

Literally got on and within a minute I attempted to teleport via Xeric's talisman and the client crashes fully. I received help from unmoon on discord in the #support section but nothing came of it. Here is the pastebin showing the log from today as soon as I logged on and crashed. https://pastebin.com/HUNBULiA
//side note//
I tried to replicate it by logging in and out then teleporting as well as reloading the client and teleporting, neither were successful in replicating the crash. Which leads unmoon and I to assume it's something on jagex's end.

Happened to me and I couldn't replicate it either. I went into my POH, then tried using the Frem boots 4 to go to Rellekka and it crashed. Could be a big issue if pking and trying to go to deep wildy, or any other dangerous areas

Can we try and gather more data here?
#3218 - @liamthfc says he teleported from draynor to camelot.
Multiple others have said it was when leaving PoH.
Can any further reports include their teleport destination and where they were teleporting from?

Can confirm PoH to tears of guthix via jewelry box doesn't make you crash

This happened to me. I was doing Vorkath and teleported out just as I was about to take damage. I spam clicked the ornate rejuvenation pool. The client lagged for a good 1-2 seconds. After I healed I used the Fancy Jewelry Box to teleport to Castle Wars. The client then lagged again for 1-2 seconds and then forced closed.

Is this still happening?

The original issue looked like it happened on outdated client, closing


Add functionality for hdf5 files

could you please add a function for the files with the hdf5 extension?
These are used, for example, by the following project.
https://github.com/minimaxir/tweet-generator/blob/master/realDonaldTrump_dril_twitter_weights.hdf5
thank you very much

Added .hdf5 file extension. Note the file only contains weights and no model info. See #73.

For the reference https://github.com/minimaxir/tweet-generator/issues/3


Create sample project to apply r2dbc-proxy framework via java agent

A sample project to apply r2dbc-proxy framework via java agent.

Intercept ConnectionFactory#create method
Make it return a publisher that produces wrapped Connection
use ProxyFactory#wrapConnection() to wrap Connection

Relates to [r2dbc/r2dbc-spi#9]

Added a java-agent example here:
https://github.com/ttddyy/r2dbc-proxy-examples
@tylerbenson
This example contains a sample implementation with Java Agent which also uses Byte Buddy to create proxies; so no JDK proxy is used.
When you need to write an agent for R2DBC, you could reference this sample.


Explore: Edit and update

We need to have a better understanding of the current Edit and update pattern in order to determine if it is a component, pattern or guidance based on the new definitions.
Definitions
Component
An asset that has been designed and coded

Export is a component because there is a coded modal provided specifically to export

Pattern
Something that can be accomplished in multiple ways utilizing a combination of component(s) with additional design considerations (a recipe of components)

Patterns may provide coded examples, but will not be required to provide code or support every possible instance of a pattern
Dashboards are patterns because you can build a dashboard in many different ways

Various sized tiles
Various components, actions, information within those tiles

Guidance
Overarching direction or instruction that can be applied across an entity

As you move further away from the “core” of the spoke, we may see more detailed guidance and opinion on guidance at the “spoke” levels
Content is guidance because we apply the same principles across all IBM experiences and services

Capitalization rules
How to display dates

Tasks

[ ] Read the current Edit and update
[ ] Review the current Edit and update code
[ ] Answer: Do edit and update have coded assets? (This might make it a component)
[ ] Answer: Are there multiple ways to utilize edit and update? (This might make it a pattern)
[ ] Answer: Could edit and update be categorized into "common actions" or 'CRUD' (create, read, update, delete)
[ ] Form an opinion on what category edit and update slot into and the future of the asset. Share with Product PAL team

Answer: Do edit and update have coded assets? (This might make it a component)
Production

Edit in place

Canary/Experimental

Edit full page
Edit side panel
Edit tear sheet
Edit tear sheet narrow
Edit update cards

Answer: Are there multiple ways to utilize edit and update? (This might make it a pattern)

Yes
The guidance is very broad and not written consistently
It also covers components that are not included in the code (data table and text editors?)

Answer: Could edit and update be categorized into "common actions" or 'CRUD' (create, read, update, delete)

Not exactly a CRUD
Possibly common actions?

Form an opinion on what category edit and update slot into and the future of the asset. Share with Product PAL


JSend/Swagger/Error handling. Add ability to define error response codes in annotations and deliver via swagger

Add ability to define error response codes in annotations and deliver via swagger.
The ability should work with JSend support.
@ResponseError(code = 404)

@ResponseErrors ({
@ResponseError(code = 404),
@ResponseError(code = 505)
})

@ResponseFail(code = 404, data=Foo.class)

@ResponseFails ({
@ResponseFail(code = 404, data=Foo.class),
@ResponseFail(code = 505, data=Bar.class)
})

These become JSend validation fails.
Fail:
https://labs.omniti.com/labs/jsend
Exceptions always become JSend error and the message of the exception is the error.

Yes


chore: change bridge-tax to be per token

Related Github tickets

Closes https://github.com/VolumeFi/paloma/issues/1815

Background
We want bridge taxes to be per token, instead of global.

Change bridge tax setter and getter to include token
Change bridge tax proposal to include token
Change query RPC to return all bridge taxes, same as bridge transfer limits
Update genesis
Removed excluded_token setting as it doesn't make sense now

Testing completed

[x] test coverage exists or has been added/updated
[x] tested in a private testnet

Breaking changes

[x] I have checked my code for breaking changes
[x] If there are breaking changes, there is a supporting migration.

Excellent work.
Blocking this until we're clear on what happens to live data. We have tax data in the keeper already: https://explorer.kjnodes.com/paloma/gov/57
So that means we'll need an upgrade path to ensure the upgrade from 1.15.1 to 1.15.2 won't crash due to type differences.
My suggestion would be to simply clear the store of tax data.

Won't the store be cleared with the rename of gravity to skyway in the 1.15.2 upgrade?
I tested the upgrade in local testnet and it worked fine afterward. I'll re-do the test to make sure I have bridge tax data before the upgrade.

Of course the store will be cleared anyway. LGTM.

Thanks for checking.
I was just testing locally. The store works fine, but we have an issue with the proposal. Since the proposal changed, we can't decode the previous one anymore.
# palomad q gov proposals
Error: rpc error: code = Unknown desc = runtime error: invalid memory address or nil pointer dereference: panic

I'll look into it.


Add Round field to the PrepareProposal Request

Protocol Change Proposal
Summary
Add a Round field to the PrepareProposal Request
Problem Definition
The PrepareProposal request does not contain a Round field which may give
proposers additional desired information as to whether to add some additional
trasactions to the block.
For example, the proposer may want to have different logic for Round=0
than for other rounds.
Proposal
ABCI: Add a Round field to the PrepareProposal Request. This would use field number 9

Hi @BrendanChou, thanks for looking into this and working on the ADR.  Can you please elaborate more on the use cases you see for this extra field? Are you able to satisfy those use case with the existing APIs but find it more cumbersome?

Following up here @BrendanChou, @lasarojc has raised that one of our concerns in exposing the round number via PrepareProposal is that we're leaking even more consensus protocol-specific information into the application - something that, in principle, we're not keen on doing since it couples the app with the consensus algorithm as opposed to just coupling it with ABCI. It also introduces an additional footgun for application developers in that it could result in non-deterministic application operation if incorrectly implemented.
As per @jmalicevic's question, could you please clarify the use cases for having access to this field specifically in PrepareProposal?


Add auto-sum-to-100 button to multi choice questions

Add a button that sums exclusive multi-choice questions to 100. It should have the following behaviour:

If all options have prediction values, they should be scaled so their sum total is 100 while maintaining the current ratio between them
If all-but-one option has a prediction value, the value for the remaining option should be 100 - the sum of all other options
If more than one option doesn't have a prediction value, any remaining probability mass should be split evenly across all un-filled options

Start by looking at components/predict-form/question-types/MultiChoiceQuestion.tsx

Hey - no time pressure on my end, so you're welcome to go for it! Let me know if you need a hand with anything and I'll find some time.

Just wanted to get started a bit today (won't have much time until Sunday), let me know how this looks! (loom) in terms of design. I'll look to add a few tests before passing it over for review.
I'm rounding to 1 decimal for the moment, felt that was a good place to start.

Yo – got some time on this, code mostly clean but I have some issues I'm running into.
Behavior is still the same as in the last loom with regards to happy path but this requirement:

If more than one option doesn't have a prediction value, any remaining probability mass should be split evenly across all un-filled options

Logically leads to this issue:

60% for option 1, 60% for option 2, XX (undefined) for option 3
Press Sum to 100
Option 3 gets set to 0, total still over 100

Thoughts? I'd suggest this logic:

If all options have prediction values, ...
If not all options have prediction values and the sum is over 100%, scale while treating un-filled options as 0
If not all options have prediction values and the sum is under 100%, split the remainder between un-filled options

@adam-binks once again if I'm tagging to many folk just let me know – I notice you've been active recently and thought you might have an opinion on the best behavior here in case Jonny is off on hols

Hey @slowSort sorry for the late reply - I was indeed off on holiday :)
On the auto-sum logic, I think the other option is to display the existing "options must sum to < 100" message. I like this as

It makes the logic simpler
Users won't have their percentages scaled down when pressing the button - I think this makes for a better UX to keep the behaviour simpler too.

What do you think?
On the Jest setup issue, I think it's because Jest isn't currently configured to use ESModules, which we use throughout the project, so it's unable to compile the code to run the tests against. I'm happy for you to update this, or I can do it if that'd be easier. I'm back working again so should hopefully be more responsive!


updated axios 0.21.1 to 0.21.3

axios is vulnerable to Inefficient Regular Expression Complexity
References
https://nvd.nist.gov/vuln/detail/CVE-2021-3749
axios/axios@5b45711
https://huntr.dev/bounties/1e8f07fc-c384-4ff9-8498-0690de2e8c31

Thanks - I've updated axios along with some other deps and will be deploying shortly!


Pasting trouble

I'm having trouble getting the editor to paste a larger (roughly 1500 words) quantity of text. In both my app and the demo app, it gets through the first paragraph, which is exactly 50 words, and then nothing after that shows up.

Go into MarkupWKWebView.pasteText(_:handler:) or MarkupWKWebView.pasteHtml(_:handler:) to grab the text or html being passed to it, and then provide it here. Probably there is an issue with the "preprocessing" being done to remove things that mess up the MarkupEditor when arbitrary html is pasted-in. As I find cases that mess it up, I have been including them in the test suite. The cleanup is done on the JavaScript side in _patchPasteHTML if you are curious.

Okay, I've done some more fiddling. It seems to be okay with pasting large quantities of plain text (though I need to hammer it a little more to be sure). The problem is pasting HTML. If I grab some text from a random wikipedia page and try to paste it in, with a breakpoint in the MarkupWKWebView.pasteHTML handler, the breakpoint never triggers.

I would just back up further in the call chain, perhaps to MarkupWKWebView.paste(_:) or even to MarkupWKWebView.canPerformAction(_:withSender:) and track what's going on. Wikipedia content works fine for me in the SwiftUIDemo, sometimes uglier than other times, but the content arrives.

Okay, a breakpoint in the first line of MarkupWKWebView.pasteableType will stop execution. It correctly identifies the stuff as HTML and returns that, which gets it back to the canPerformAction handler, but when that's done is goes back to pasteableType and identifies the html again, then it just seems to be caught in an infinite loop there.

Yah, I don't know why that happens, but it's some kind of debugger breakpoint weirdness. If you remove the breakpoint, it won't be in an infinite loop. How about breaking at if let data = pasteboard.data(forPasteboardType: "public.html") { in MarkupWKWebView.paste(_:). Here's another issue where the guy dug into the paste operation that might be useful to look at, too: https://github.com/stevengharris/MarkupEditor/issues/128#issuecomment-1867655033. I haven't had a chance to chase that one down yet.

That helped. In the paste function, it's going into the HTML case and if I look at my data there, everything's fine – it's all intact. Going further in I find that it's surviving intact all the way through the escaping that you call in the evaluateJavaScript call in pasteHTML. I tried setting a breakpoint inside MU.pasteHTML so that I could look at the data there, but Xcode ignored it. Is that normal?

To set a breakpoint in MU.pasteHTML, you have to use the Safari Web Inspector from the Developer Tools menu in Safari (https://developer.apple.com/documentation/safari-developer-tools/web-inspector). It's primitive, but an alternative is to insert _consoleLog() calls in the JavaScript methods to print strings in the Xcode console.

@benlong100 I recently put in some fixes for pasting. If this is still broken on main, can you let me know, or otherwise, close the issue. Thanks.

Sorry for the delay, I've been mired in another part of the code. I had not forked your code before – I was just running it as a Local Dependency. This morning I set things up properly for syncing to your changes, and got my alterations moved into the code. When I invoke the MarkupEditor it's not loading my text – the editor and all my toolbars show properly, but there's no document or caret. Has something changed in the way that I need to pass it source text? If not then I must have missed something when I moved my changes over.

No, nothing should have changed. Since I'm often mucking around in markup.js, this is a behavior I see when there is a JavaScript error. If so, it is easily identified by opening the Safari Web Inspector (Develop->Choose device->Choose web page). A more top-down approach is to put a break in markupDidLoad in your MarkupDelegate to make sure it's called, or at a level deeper in MarkupCoordinator.userContentController(_:didReceive:).

My app is not showing up in the Device menu in Develop. This implies that I need to make the WKWebView inspectable. If that's true, where's the best place to put the .isInspectable = true?

Okay, so the WebInspector is working now. If there were errors, were might I see them? Right now it's showing the html, which looks like this:

        <meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0,user-scalable=no">
        <meta name="supported-color-schemes" content="light dark">
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
        <link rel="stylesheet" type="text/css" href="markup.css">

<input aria-hidden="true" id="hiddenInput" tabindex="-1" style="caret-color: blue; opacity: 0; position: fixed; top: -1000px; pointer-events: none; visibility: hidden;">

As expected, my content isn't in there. Hitting refresh in the Web Inspector doesn't change anything. In the section with the checkboxes for active, focus, focus-visible, and so on, nothing is checked.
In the MarkupDelegate file, I put a breakpoint in the MarkupDidLoad handler, but it's never triggering.
In the web inspector, when I mouse over the body tag, on the iPad it highlights a very thin strip across the top of the WKWebView.
Sorry if these are silly questions, I've never used this WebInspector before. Seems a bit of a hack, but it's cool.

You would not see any errors until you hit the reload button (3rd from the left in the top bar of the window). Reloading will cause the .js to load again, and if there was some change that doesn't compile properly, you would see an error show up in the console indicating the line number. The thin strip being highlighted is just showing the body.
Maybe at this point a better approach is to debug more top-down. Maybe this kind of sequence:

Is it easy just to open DemoContentView instead of whatever your top-level view is? If so, then it should show the demo.html contents and would give us some confidence that the basic MarkupEditor mechanics are working properly.
If that's not easy, then maybe break in MarkupWKWebView.initForEditing(). Make sure html has your content. Then step into MarkupWKWebView.initForEditing() to make sure the root files are found properly.
So if all that is working, then see if the callbacks to the MarkupCoordinator are working by breaking in MarkupCoordinator.userContentController(_:didReceive:). The first case that is triggered is the ready case which in turn triggers loadedUserFiles:

webView.setTopLevelAttributes() {
    webView.loadInitialHtml()
}

Assuming you get this far, you can set a break on the webView.loadInitialHtml() statement. When webView.loadInitialHtml() executes, your content is loaded in and markupDidLoad is called if the MarkupDelegate is set.
From what you're describing, something is broken in this sequence, so hopefully this gives you a path to narrowing it down.

Okay, that was good stuff. In MarkupWKWebView.initForEditing I found that html does contain my stuff. Where it comes apart is in MarkupCoordinator. loadedUserFiles isn't loading anything – both scriptFile and CSSFile are null. From what I see in your comments, that prevents loadInitialHTML?
I have a customCSS file that is stored in a specific user directory. I pass that as the resourcesURL when I call MarkupEditorView. Should I be putting that somewhere else?
And I have no idea what scriptFile might be referring to.

Aha! I just realized you've added a lot of new documentation to the Code page here – I haven't looked at it in a long time. I'll dig through that and see if it clears this up. Sorry I didn't see that before.

The scriptFile and cssFile are normally nil, but the callback to trigger the loadedUserFiles should still happen. This is the case for the standard demo, where they are both nil. Starting with the standard DemoViewController, you can put a break in MarkupWKWebView.loadUserFiles(_:), where both scriptFile and cssFile are nil. This invokes MU.loadUserFiles in markup.js, which ends up doing a callback to loadedUserFiles regardless of them being null on the JavaScript side.
This was definitely a change I made in the most recent round to allow custom scripts and css that I also added to the README. With this most recent change, you should be able to set your custom css file as discussed in the new README section. I am not sure how you are loading your custom CSS, but maybe the new work I did to formalize how to customize CSS is at cross purposes to what you did. In any case, if the loadedUserFiles case is never invoked in MarkupCoordinator.userContentController(_:didReceive:), but you can watch MarkupWKWebView.loadUserFiles(_:) be executed on the Swift side, then we know where the issue is. In markup.js we execute:
/**
 * Called to load user script and CSS before loading html.
 *
 * The scriptFile and cssFile are loaded in sequence, with the single 'loadedUserFiles'
 * callback only happening after their load events trigger. If neither scriptFile
 * nor cssFile are specified, then the 'loadedUserFiles' callback happens anyway,
 * since this ends up driving the loading process further.
 */
MU.loadUserFiles = function(scriptFile, cssFile) {
    if (scriptFile) {
        if (cssFile) {
            _loadUserScriptFile(scriptFile, function() { _loadUserCSSFile(cssFile) });
        } else {
            _loadUserScriptFile(scriptFile, function() { _loadedUserFiles() });
        }
    } else if (cssFile) {
        _loadUserCSSFile(cssFile);
    } else {
        _loadedUserFiles();
    }
};

const _loadedUserFiles = function() {
    _callback('loadedUserFiles');
}

In your case, with both scriptFile and cssFile null, it will fall thru and execute the _callback('loadedUserFiles');, which causes the MarkupCoordinator.userContentController(_:didReceive:) to fire on the Swift side and trigger the loadedUserFiles case. So there are only a few lines of JavaScript open to failing, or maybe the markup.js isn't the most recent version?

Okay, I've gone through your new readme. The new customization stuff is cool! And I've been wondering about changing the caret color but hadn't got around to it.
As for a custom style sheet, when I set markupConfiguration.userCssFile can that be a URL to a file? Or is it always going to look in the Bundle? Because of some custom font stuff, I have to modify my CSS file at runtime, so I can't keep an accurate one in the bundle.

It will always look for it in your app bundle. I'd be surprised if you can do much with files outside of the app bundle because of sandboxing rules.

I have some custom fonts in my app bundle and I want to be able to reference them from the CSS file. To do that the CSS file has to know the path to the font file. Unfortunately, at runtime, the path to the bundle is never the same. For example, it might be something like this:
/Library/Developer/CoreSimulator/Devices/C88793FA-075D-424F-92CE-2D6C29D6CBEF/data/Containers/Bundle/Application/A8EE7C9A-A80D-48C1-90F4-176971E4B117/theApp.app/Futura-Condensed.otf
but the UUIDs in the path change with each launch. So, every time I launch the app, I figure out what the current path to the bundle is and re-write the CSS file so that the font path is updated. Have I over-engineered this? Is there some other way that I could be referencing bundled fonts in a CSS file?

If you look at the SwiftUIDemo files like (now) custom.css, the file is part of the bundle, as is steve.png that I stuck in their for demo purposes so I could reference it from the demo.html. Can't you just put Future-Condensed.otf in the bundle like these other files, and then I would think your CSS can reference it without any path since it will be in the same place as the CSS.

The fonts are in the bundle, so that will work for the Markup editor. However I have some other web views that run off of documents stored in the app's Documents folder, so I need a style sheet in there, as well. That's where I get into the trouble of the bundle address changing every time.
Also, I have some preferences that allow the user to change the style sheet. Since the bundle is read-only, I can't work out of a bundle-based style sheet for that.

I'm doing all the editing from the cache directory, copying things from the bundle in initForEditing. Maybe you can do the something similar for your files?

So if I was keeping the CSS file in the cache directory then the Markupeditor would still be able to find it? If that’s the case I could just move everything to work out of there. Right now I’m in a Documents directory. The caches directory would definitely be “cleaner.”

On Jan 18, 2024, at 5:59 PM, Steve Harris @.***> wrote:
I'm doing all the editing from the cache directory, copying things from the bundle in initForEditing. Maybe you can do the something similar for your files?
—
Reply to this email directly, view it on GitHub https://github.com/stevengharris/MarkupEditor/issues/175#issuecomment-1899517892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2PK5ZS73GIYQDQQECUXIDYPHHQRAVCNFSM6AAAAABBA57ILCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGUYTOOBZGI.
You are receiving this because you were mentioned.

Is that the caches directory I get to with
FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask)

On Jan 18, 2024, at 5:59 PM, Steve Harris @.***> wrote:
I'm doing all the editing from the cache directory, copying things from the bundle in initForEditing. Maybe you can do the something similar for your files?
—
Reply to this email directly, view it on GitHub https://github.com/stevengharris/MarkupEditor/issues/175#issuecomment-1899517892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2PK5ZS73GIYQDQQECUXIDYPHHQRAVCNFSM6AAAAABBA57ILCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGUYTOOBZGI.
You are receiving this because you were mentioned.

Okay, I've got my app changed around so that it does all of its work out of the ApplicationSupport directory. I have some things that I have to ensure will persist, so I'm hesitant to put them in the Caches folder.
What I was doing with the old version of MarkupEditor was putting the CSS file and all of the images associated with the document I wanted to edit into a folder, and then passing a URL to that folder through the resourcesURL parameter in my MarkupEditorView call. I assume that, with the new scheme, that no longer works. I will still need to copy the images into the appropriate place, and from the Readme, it looks like that would be into the ID folder in the caches folder. I assume I could  copy my custom css into there as well? What I'm not clear on is where I should add this copying code. I don't want to copy over a CSS file and then have something downstream write over it with the one from the bundle.

I think specifying resourcesURL should still work for your purposes. It seems like to me you should specify the CSS file in MarkupWKWebViewConfiguration.customCss and just include the font and images in the resourcesUrl location. This way the customCss should just be able to reference the font without worrying about a path. Ideally this would "just work", and you don't have to deal with copying any files around yourself or relying on the specific setup (e.g., the use of the caches directory) under MarkupWKWebView.
As a last resort, I was thinking about exposing the MarkupWKWebView baseUrl (i.e., what is currently the private method cacheUrl()) publicly. At least then you could copy to the baseUrl, although there is still the issue of when to do the copying. Currently there is no notification via MarkupDelegate that comes before the initial HTML is loaded, and presumably you want to accomplish the copying before that happens (which is what goes on with the preferred approach of using customCSS and resourcesUrl). If I do this, then I'd probably have to include something like MarkupDelegate.markupWillLoad() that you could use to drive the copying yourself. There is still lots of room for screw ups via file name conflicts with things like markup.html, but frankly those are already possible via resourcesUrl.

Ah, copying the fonts into resourcesURL is very clever, that seems like the easiest solution. I wasn't clear on whether things were still being copied over from resourcesURL, so that's good news. I think that's a good mechanism and as long as it keeps working I can't think of a reason to expose the MarkupWKWebView baseUrl.
So now I'm back to the problem of the MarkupEditor not loading properly. I can watch LoadUserFiles and see that both the scriptFile and cssFile are set to null and I can see it call evaluateJavaScript, but I gather it's not possible to set breakpoints in Javascript code in Xcode? 'Cause it's not letting me do that.
In answer to your previous question of whether I have the most recent JS code, I just installed all this yesterday, so I should be in good shape.

You can put in breaks in markup.js from the WebInspector, but since we are dealing with it in a state where it really hasn't fully loaded everything, it's hard to do that. Can you put in a break in MarkupWKWebView.loadUserFiles to see if there is an error? I should be logging an error here if one occurred.

Okay, it's doing that weird Xcode thing where it runs through the code twice. The first time, there's no error, but then it comes back through and the console shows:
Error Internal: Break at MUError('Internal'... in Safari Web Inspector to debug.
If I fire up the Web Inspector in Safari and hit reload, then the Console there shows:
TypeError: MU.loadUserFiles is not a function. (In 'MU.loadUserFiles(null, null)', 'MU.loadUserFiles' is undefined)
So then if I go look in the markup.js file I find a lovely MU.loadUserFile function that looks perfectly intact.

You can see markup.js in the Web Inspector and that markup.js includes MU.loadUserFiles like I can see below when running the DemoViewController?

Aha! I see markup.js as a source in the Web Inspector but when I search it for loadUserFiles there's nothing there. Eyeballed around manually for a bit and couldn't find it. How can it be showing up in Xcode but not here?

The one in Xcode is not what was found in the bundle and copied to the cacheUrl() location in initRootFiles(). Maybe the first thing to do is Clean Build Folder, and make sure you build MarkupEditor build target again. If I had to guess, as you said, your app has a dependency on the local build of MarkupEditor, but you didn't rebuild it when you updated. So just rebuilding MarkupEditor might do the trick. If not, then you are down to debugging in initRootFiles and figuring out where it's finding markup.js and whether the contents are correct.
    private func initRootFiles() {
        guard
            let rootHtml = url(forResource: "markup", withExtension: "html"),
            let rootCss = url(forResource: "markup", withExtension: "css"),
            let rootJs = url(forResource: "markup", withExtension: "js") else {
            assertionFailure("Could not find markup.html, css, and js for this bundle.")
            return
        }
        var srcUrls = [rootHtml, rootCss, rootJs]
        // If specified, the userCSS comes from the app's main bundle, not something MarkupEditor provides
        if let userCssFile, let userCss = url(forResource: userCssFile, withExtension: nil) {
            srcUrls.append(userCss)
        }
        if let userScriptFile, let userScript = url(forResource: userScriptFile, withExtension: nil) {
            srcUrls.append(userScript)
        }
        let fileManager = FileManager.default
        // The cacheDir is a "id" subdirectory below the app's cache directory
        // If not supplied, then id will be a UUID().uuidString
        let cacheUrl = cacheUrl()
        let cacheUrlPath = cacheUrl.path
        do {
            try fileManager.createDirectory(atPath: cacheUrlPath, withIntermediateDirectories: true, attributes: nil)
            for srcUrl in srcUrls {
                let dstUrl = cacheUrl.appendingPathComponent(srcUrl.lastPathComponent)
                try? fileManager.removeItem(at: dstUrl)
                try fileManager.copyItem(at: srcUrl, to: dstUrl)
            }
        } catch let error {
            assertionFailure("Failed to set up cacheDir with root resource files: \(error.localizedDescription)")
        }
    }

Okay, you just lost me. I’d already done some Clean Builds, but that didn’t help, but I don’t understand building the MarkupEditor Target. How do I rebuild just that? (And was I supposed to have done some kind of special build of it before?)

On Jan 19, 2024, at 3:03 PM, Steve Harris @.***> wrote:
The one in Xcode is not what was found in the bundle and copied to the cacheUrl() location in initRootFiles(). Maybe the first thing to do is Clean Build Folder, and make sure you build MarkupEditor build target again. If I had to guess, as you said, your app has a dependency on the local build of MarkupEditor, but you didn't rebuild it when you updated. So just rebuilding MarkupEditor might do the trick. If not, then you are down to debugging in initRootFiles and figuring out where it's finding markup.js and whether the contents are correct.
private func initRootFiles() {
    guard
        let rootHtml = url(forResource: "markup", withExtension: "html"),
        let rootCss = url(forResource: "markup", withExtension: "css"),
        let rootJs = url(forResource: "markup", withExtension: "js") else {
        assertionFailure("Could not find markup.html, css, and js for this bundle.")
        return
    }
    var srcUrls = [rootHtml, rootCss, rootJs]
    // If specified, the userCSS comes from the app's main bundle, not something MarkupEditor provides
    if let userCssFile, let userCss = url(forResource: userCssFile, withExtension: nil) {
        srcUrls.append(userCss)
    }
    if let userScriptFile, let userScript = url(forResource: userScriptFile, withExtension: nil) {
        srcUrls.append(userScript)
    }
    let fileManager = FileManager.default
    // The cacheDir is a "id" subdirectory below the app's cache directory
    // If not supplied, then id will be a UUID().uuidString
    let cacheUrl = cacheUrl()
    let cacheUrlPath = cacheUrl.path
    do {
        try fileManager.createDirectory(atPath: cacheUrlPath, withIntermediateDirectories: true, attributes: nil)
        for srcUrl in srcUrls {
            let dstUrl = cacheUrl.appendingPathComponent(srcUrl.lastPathComponent)
            try? fileManager.removeItem(at: dstUrl)
            try fileManager.copyItem(at: srcUrl, to: dstUrl)
        }
    } catch let error {
        assertionFailure("Failed to set up cacheDir with root resource files: \(error.localizedDescription)")
    }
}

—
Reply to this email directly, view it on GitHub https://github.com/stevengharris/MarkupEditor/issues/175#issuecomment-1901268289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2PK523446RSGAD6BNKOPTYPL3V3AVCNFSM6AAAAABBA57ILCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGI3DQMRYHE.
You are receiving this because you were mentioned.

If you cloned the repo, then open Xcode on the MarkupEditor project and build it. That creates the framework you are referencing in your app as a dependency, so the import MarkupEditor finds what you built. I am usually using an Xcode workspace that includes my app and the MarkupEditor project, so the MarkupEditor target is easy to find and rebuild.
If you use the Swift Package dependency, it needs to be updated to the latest version (0.6.2 I think)

Okay, that worked halfway! I rebuilt the MarkupEditor target and cleaned out the Package Cache in my app. As you may recall, I'm running two different editors and now one of them is working! The other is still throwing the same error and finding the same lack of MU.loadUserFiles, but I'll poke around and see if I can figure out what might be different. Thank you thank you!

I have figured out what the problem was. As I mentioned before, before calling the editor I uses the resourcesURL to copy over a style sheet and any images my document needs. What I hadn't mentioned before is that I also copy over a markup.html file. I don't remember the details, but with the old version I seem to have discovered that, if I'm doing that, then I also have to copy markup.js through the resources directory, or MarkupEditor won't have one. To do that, I had made a copy of your markup.js file into my app bundle, and I was copying that into the resources directory when summoning a markup editor. What was happening earlier today was that, at runtime, it was still copying that OLD version of markup.js over.
I deleted that old version, and commented out the sections that copied it into the resources directory and then and had a very strange experience. The editors started working, and so I started testing. After four or five entries everything stopped working – the editor would no longer load at all. I hadn't made any changes to the code – this all happened during a single execution of the app. After that it wouldn't work at all and the only way that I've been able to get it working again is to put a copy of the new markup.js folder back into my bundle and return to letting my code copy that over via the resources directory. Now everything is working fine. If I don't do that, then when I execute the code and view it in the Web Inspector in Safari I find that there's no JS source at all in the Markup Editor.
So the behavior I seem to be seeing here is that, if you use resourcesURL to copy over a markup html and css file then you also have to copy over a js file. I'm fine with doing this and it's all working now, and perhaps I'm coming to the wrong conclusion, but that's what seems to be happening.
And now, finally, after all these weeks I can address the original point of this whole thread: whatever you've changed through these recent updates has fixed my pasting problem! Thank you!

Here's an odd one: occasionally, with large pastes, it's moving the first paragraph of the text I'm pasting to the very end. I'll see if I can find an example online that does this. Also, should Command-V be working as a shortcut?

The issue with pasting misplacing the paragraph is going to have something to do with the structure of what's being pasted, not really the length. If you find a case that reproduces it, what would help me debug is the html passed to MarkupWKWebView.pasteHtml(_:handler:).
On command+V, yes it should work. You should see it in your Edit menu, and the item should be enabled. If it's not in the Edit menu or it's disabled, then it won't work. You need to have built the menu, tho. See AppDelegate.buildMenu(with:) in the SharedDemo content to see where that should be done.


question about DDIM step

非常感谢您的工作！
我想请问一下这里DDIM step输入的model_output对应的是trajectory？diffusion_scheduler的prediction_type是不是应该为‘sample’？

Thank you for pointing this out! It seems that I made an error while migrating and cleaning up the code. You are correct, the prediction_type="sample" in the DDIM scheduler. I have corrected this in the latest code.


Add files via upload

@galushkoss Please provide us with:

the school official website URL
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Website URL: https://www.sh44.org
sh44.org is a Google Workspace domain of our school

чт, 11 лют. 2021 о 14:01 Philip Torchinsky<EMAIL_ADDRESS>пише:

@galushkoss https://github.com/galushkoss Please provide us with:

the school official website URL
a proof, which shows that the school recognizes the domain you are
submitting as an official email domain for the students.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/10720#issuecomment-777401418, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASZ63QCQDZBHQP47DFI5NQ3S6PBKVANCNFSM4XONGAIQ
.

@galushkoss Pull request merged. Thank you!


fix bug

line of 928,add vertical constraints to fix the bug of the customeview could not show.

This change unfortunately breaks implementations without custom views.


Second hand is detected

Camera detects the second hand when doing the handover (the hand controlling the needle). This causes the robot to move towards that hand

The issue is fixed by removing detections below a z-threshold. But this could lead to the arm locking onto the other hand


use twai ，how to change the receive buffer size. (IDFGH-9390)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
use the twai commucation, how to change the receive buffer size.

esp_idf-v4.4.   esp32    windows
i have a sensor , twai interface. MCU send a command to the sensor ,and the sensor will feedback 16 group data (128 byte) ,but the MCU only can receive the front 6 groups. and the last 10 group missing. so i think may be the receive buffer is not big enough. and i want to know how to change the buffer size..

You haven't read documentation well.
https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32/api-reference/peripherals/twai.html#_CPPv4N21twai_general_config_t12rx_queue_lenE

@giu-wxyao Please see the response on the related forum post

TKS,I found where to change the parameter.


Null values

I've come across an issue using the fusedlocationprovider task with this library - it can emit null values.
I think the only way around this would be to wrap null values with some kind of optional in the library?

Ah, Rx2 doesn't allow null emissions, emitting optionals would be an option, but I'd have to include a back port, perhaps instead catch null and emit it as an error instead

Or perhaps using a Maybe rather than Single would work?

Not a bad idea, but I'd wonder if that would result in unexpected behaviour in consumer applications due to an "expected" null  emission

I've opted to catch the NPE and emit an onError event, should be live with the next version


Custom scalar for kotlin.time.Duration coercing issue

For custom kotlin.time.Duration scalar, f.e.
scalar Duration

type Query {
    test: [Sample]
}

type Sample {
    duration: Duration
}

when I define custom GraphQLScalarType in spring configuration for kotlin.time.Duration (GraphQLScalarType.newScalar().name("Duration").coercing(DurationCoercing))
with Coercing<I,O> implementation class as described below, dataFetcherResult comes as Long type (the actual value passed to serialize method is "rawValue" property of kotlin.time.Duration, which is a private field)
object DurationCoercing : Coercing<kotlin.time.Duration, String> {
	override fun serialize(dataFetcherResult: Any): String {
		return ...
	}
	....

So the question is, why kotlin.time.Duration comes as Long to Coercing<I,O> serialize method - is that correct behaviour or a  bug? (if bug - is that a spring issue or issue of Kotlin kotlin.time.Duration?)
here is a link with sample application that demonstrates the problem (I have to do ((dataFetcherResult as Long) shr 1).toDuration(DurationUnit.NANOSECONDS).toString(), due to implementation details of kotlin.time.Duration to serialize properly)

Hi.
It seems buggy, but it's a correct behavior. kotlin.time.Duration is a value class and it is unboxed here.

Hi.
It seems buggy, but it's a correct behavior. kotlin.time.Duration is a value class and it is unboxed here.

right, seems that in kotlin.serialization you could choose which primitive type will be used for unboxing - is that supported somehow in spring?

I'm not sure where the unboxing happens, but Coercing is a GraphQL Java type, so this is more of a GraphQL Java question I think. There isn't any behavior specific to Spring in this, we just pass on the return value returned from the controller as is.
Closing for now, as I don't see anything we can do, but feel free to add more comments if you have further information or links to related issues.


check if tryte order for reattachments is correct

https://github.com/einfachiota/iota-payment/blob/5f17d4768fa5ee28026c389ab064fdad5160479e/lib/payoutHandler.js#L196
Sometimes it gets reattached in the wrong order, for example https://devnet.thetangle.org/transaction/TZHCVNDIYVOZRZHYJJYVAYOXTWPFXIGCOMQPBJRS9PZDUHLTDFTSATVZ9EXVKSTXFUUBXAIQSRKH99999 because not all nodes/fpgas handle a different order
bundletrytes.revers() would fix it maybe

The part was removed with #21


When a error is returned from a notebook execution this is not raised as a failure in the application. EG master notebook and metaextracts

When a error is returned from a notebook execution this is not raised as a failure in the application. EG master notebook and metaextracts

Note also made hash check warning until configurable options can be looked in issue #61

Completed and released


Adding 'missed appointments' tab

Fixes #351 .
I didn't realize the other appointment routes already filter to the latest, so 'missed' doesn't require any filters.
I added a test, and modified the createAppointment helper function to accept params.

cc @HospitalRun/core-maintainers

@pete-the-pete missed appointments doesn't mean all appointments in the past, it means appointments that were scheduled and the patient didn't show up.  The appointments missed should show all appointments that have a status of Missed, which will be a new status that will need to be added to hospitalrun/mixins/appointment-statuses.  You can then pass a filterBy value of Missed to the _modelQueryParams defined for the route, eg:
      options: {
        startkey: [startOfWeek, null, null],
        endkey: [endOfWeek, endOfWeek, maxId],
        filterBy: [
          name: 'status',
          value: 'Missed'
        ]
      },

Also, it looks like the tests are failing.

Ah...thanks for clarifying, and pointing me in the right direction.  I'll try to get something up soon.

@jkleinsc, finally back from vacation....
I don't understand how an appointment can be aware if a patient showed up or not.  My thought was to see if a given appointment had any visits, but there isn't a relationships between the two.  Should there be?
I could add it, so that there is a hasMany relationship between appointments and visits.  Appointments that have no visits, and the the current data is past the appointment date would then be set to "Missed" (the status would be updated when visiting the appointments route).  Thoughts?

@pete-the-pete the key here is instead of looking at this as something that the system automatically determines, the marking of an appointment as missed is something that requires human interaction.
I suppose at some point we could make this an automated process, but at this point using the status already used on an appointment is an appropriate way to handle this.
cc @HospitalRun/core-maintainers in case anyone else has a different opinion

cc @HospitalRun/core-maintainers in case anyone else has a different opinion

No, I agree @jkleinsc. Giving admins a way to manually set this for patients seems like the best path forward at this point. 👍

Setting that status is more straightforward.  I filtered the data in the route's model hook.  I couldn't get the filterBy property to actually accomplish things (I'd like to talk that through in slack and some point).
Hopefully this is attempt is closer.

@pete-the-pete to use the filterBy parameter on the couch view, you can pass it along by overriding the _modelQueryParams function in the route.  For example:
  _modelQueryParams() {
    let queryParams = this._super(...arguments);
    queryParams.filterBy = [{
      name: 'status',
      value: 'Missed'
    }];
  },

This will pass along the filter value to couch view.

@jkleinsc thanks for the help.  I ignored the cors errors, and saw it working.  Hopefully this is it.

@pete-the-pete looks good... just one more thing.  The controller and template for missed should just extend/use the controller and template from app/appointments/index because the code exactly them same.  If you take a look at app/appointments/today/controller.js and app/appointments/today/template.hbs you will see how that route uses the index controller and template.  If you don't have time to do this let me know and I'll do it.

I updated the controller and template.  Hopefully its good to go.


Calculating Lean Angle using GYRO

Hi David,
Hope all is well!
May I know if it is possible to calculate lean angle using GYRO data when GoPro camera is mounted on a bike? If yes, how does it work?
Many thanks!
Xiaoyue Huo

Full camera orientation can be determined from GYRO and ACCL streams, as this is all Fusion uses to do its awesome stabilization.  However stabilization is only concerned with changing camera orientation, not absolute angles relative to the ground.   I don't have any sample code I can share to compute the lean angle, but I believe it can be done.  One way to do it would be to compute the lateral acceleration from GPS position and compare with the acceleration direction measured from the ACCL data, the difference will help you compute lean angle.


crates.io: Package Groups

Motivation
We want to support "special" or "blessed" packages and would also like to limit the contention for important names in a flat namespace.
Overview
Cargo will support groups as package namespaces with special permissions. Any user can create a new group whose name is not taken and begin adding packages and owners to it. Packages in a group can be referenced in the [dependencies] section and on crates.io as <group>/<package>. Only owners of a group can add new packages to the group or update existing packages.
Details
New cargo commands:
cargo group create <name>

Creates a new blank group with the passed-in name, make yourself an owner, and push it.
cargo group edit <name>

Download and open the group's configuration as a toml file and edit it with $EDITOR. This includes description, members, etc. Only owners of a group may run this command.
Adding a package to a group is as easy as adding group = "<name>" to the [package] section of that package's Cargo.toml and running cargo publish. Permission to do this action is checked during cargo publish.
Expressing a dependency on a package within a group is the same as with a normal package, except the package is referred to as <group>/<package> in Cargo.toml. Notably, the name of the package does not change, and you still access the crate by doing extern crate <package>. This has the potential to cause some naming conflicts, but cargo could provide a solution to this by adding optional alias metadata to a dependency that tells cargo what name it should use when linking that dependency.
Each group gets its own page on crates.io that shows all the packages within it, and all packages in a group share owners.
Group configuration
cargo group edit <name> brings up the configuration file for a group, which contains the following structure in toml:
Necessary:
name
owners

Optional:
description
homepage

More fields could be added if/when they are needed.

@steveklabnik the link http://discuss.rust-lang.org/t/crates-io-package-policies/1041 is broken.

It's https://internals.rust-lang.org/t/crates-io-package-policies/1041 now :)


Notifications page blank when no notifications

I have no notifications.  I click the notifications icon in the top right, click "All Notifications" and am taken to https://www.lesserwrong.com/inbox?select=Notifications this page is totally blank.

Yep, that's a bug. Shouldn't be too hard to fix.

I'm working on a fix for this.
Having it say 'You have no notifications' is quite simple; making sure that it doens't say that when they just haven't loaded yet is a bit less straightforward, especially since I'm not familiar with Vulcan.
Would you prefer that I make a pull request now, so that you can look it over, or should I finish reinstating the loading message first? (Or something else entirely... This isn't marked 'good first issue', so I hope it's okay if I jump in here.)

Hmm – there's a chance this was inadvertently fixed awhile ago (when I test
it out locally it seems to work as intended). On your current version of
the site does it appear to still have the bug by default?
ᐧ
On Mon, May 14, 2018 at 4:58 PM, Forrest Wolf<EMAIL_ADDRESS>wrote:

I'm working on a fix for this.
Having it say 'You have no notifications' is quite simple; making sure
that it doens't say that when they just haven't loaded yet is a bit less
straightforward, especially since I'm not familiar with Vulcan.
Would you prefer that I make a pull request now, so that you can look it
over, or should I finish reinstating the loading message first? (Or
something else entirely... This isn't marked 'good first issue', so I hope
it's okay if I jump in here.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Discordius/Lesswrong2/issues/153#issuecomment-388999561,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADGKdoCJMp80ShHZBHKQa5om7Ehq1hA1ks5tyho3gaJpZM4Ph8ws
.

Wait, notifications are in the sidebar now, aren't they? So https://www.lesserwrong.com/inbox?select=Notifications isn't even used anymore? If that's the case, then yes, it's been inadvertently fixed already.

Oh, I see.
https://www.lesserwrong.com/inbox?select=Notifications is still used
(sometimes) to see all your notifications, but it's basically impossible
to get to that page until you have at least one notification (since the
link to it is in the sidebar)
So I don't think this technically needs to get done, but it might still be
worth doing as a simple "warm up" PR, unless you want to move on to
something else. (If you decide to continue this one, I'd lean even harder
in the "figure out how to properly wait for the loading to finish before
displaying the 'No notifications found' message", since most of the value
is in learning a bit about how vulcan works).
FYI, the relevant bits to learn are in the docs for the withList higher
order component (you can see at the bottom of the
NotificationsFullScreen.jsx component that it's getting wrapped in the
withList component during the registerComponent process. Wrapping something
in withList gives it some special prop, documented below:
http://docs.vulcanjs.org/resolvers.html#withList
And you can see some examples of how to apply that in the
posts/PostList.jsx item (which uses the withList props to determine whether
to show the PostList itself, or a loading screen, or a "no results"
message).
ᐧ
On Tue, May 15, 2018 at 7:39 AM, Forrest Wolf<EMAIL_ADDRESS>wrote:

Wait, notifications are in the sidebar now, aren't they? So
https://www.lesserwrong.com/inbox?select=Notifications isn't even used
anymore? If that's the case, then yes, it's been inadvertently fixed
already.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Discordius/Lesswrong2/issues/153#issuecomment-389191488,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADGKdmWakVDqqVlNA0-NfxZcpMNqlt4Vks5tyui4gaJpZM4Ph8ws
.


BUG: class static member scope

in python and brython the following works fine:
https://www.brython.info/tests/editor.html?lang=en

class DataUnit:
   static_one = 'one'
   static_two = 'two'
   static_total = static_one + static_two

in transcrypt, generated js uses direct mapping

...
{
   static_one : 'one',
   static_two : 'two',
   static_total : static_one + static_two // SCOPE NOT AVAILABLE
}

solution: generated js could use class prefix:

...
{
   static_one : 'one',
   static_two : 'two',
   static_total : DataUnit.static_one + DataUnit.static_two,
}

additional problem with static scope: it is not executed
class DataUnit:
   print('this is not printed')

Could be merged with #630. Also note that when the initializer object is used to create the class, DataUnit does not exist yet.


feat: first impl RawProvider and IndexerCellCollector

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
When MetaMask disconnects all accounts, the Web3Provider error occurs and the accountsChanged event does not fire

What is the new behavior (if this is a feature change)?

Other information:

https://talk.nervos.org/t/proposal-with-a-50-000-ckb-bonus-for-adapting-pw-core-to-back-end-usage/5301/5

There is a breaking change in this fix, so take note of that https://github.com/lay2dev/pw-core/pull/5/commits/d3575c1064a21e285b53c55fa2b4851465ea98c6
    const unspentCKBCells = await this.collector.collect(
      PWCore.provider.address,
-    neededAmount
+   { neededAmount }
    );

There is another implementation of this function https://github.com/lay2dev/pw-core/pull/6


(FACT-3087) restore Facter3's value of 'os.name' for VirtuozzoLinux

Contains the work from https://github.com/puppetlabs/facter/pull/2456, plus some other refactoring.

jenkins please test this on all

jenkins please test this on all


HttpError: Not Found

Hello,
I would like to set up this Github action for my repository, but I get an error:
Run<EMAIL_ADDRESS>Event is push
HttpError: Not Found
    at /runner/_work/_actions/mi-kas/kover-report/v1.5/webpack:/kover-report/node_modules/@octokit/request/dist-node/index.js:86:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Obviously it's not possible to getChangedFiles and I am wondering what can be the cause or how to debug it? I think token should have required permissions. The PR contains only version change for kover-report from v1 to v1.5.

Hi @matejuh! I think your issue is related to some missing permissions for the action in your repo. Could you try to apply this suggestion here: https://github.com/mi-kas/kover-report/issues/111#issuecomment-1431146784
Let me know if this solves you issue

The problem was that pipeline was trigger by push action but pull_request is needed to have PR context.


Pending amounts

Portion of funds stuck pending even though all txns are confirmed?

still having trouble with this - tried to open a channel and have sats stuck pending


Possible to add QSEoW QRS command for security rules?

There is a whole set of QRS endpoints for security rules at /systemrule/...
These are however not exposed in the qlik qrs command.
Possible to change this?
It would for example be quite useful to be able to export all security rules to a JSON file for backup purposes.
That can still be done using direct API calls of course - more convenient to have that feature right in qlik cli instead.

Hi @mountaindude, are there more endpoints that you would find useful in your use-case that is not exposed at the moment?
The qlik qrs commands exposed today are primarily intended to help in migration scenarios, but I do see the value of adding system-rule for backup or versioning purposes.

Indeed, it's a great little tool to have when setting up more comprehensive backups for client-managed QS.
Having access to security rules would be good.
Same thing for custom properties and tags.
Just for reference, with data connections I tend to use something like this (simplified..) to get a date-timestamped backup of all data connections. Easy and clean, can be scripted, parametrised etc.
qlik qrs dataconnection full | Out-File $backupfolder\data_connections_$((Get-Date).ToString('yyyy-MM-dd')).json

There are of course ways of extracting/backing up tags, custom properties, security rules etc using PowerShell scripts, authenticating using certificates.
Works well but having everything within qlik cli would be a bit cleaner and probably more accessible to users that aren't comfortable writing advanced PowerShell scripts.

Thanks @mountaindude, this is great input. I will bring it up internally and see if we can provide more support for this type of scenario in coming releases.

Closing as stale. Please reply here if this request is still of interest.


HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

…ableDescriptor
Logging cleanup.
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java
Undo fetching Table Descriptor. Not reliably available at recovery time.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s
branch-2 passed

+1 :green_heart:
checkstyle
1m 55s
branch-2 passed

+1 :green_heart:
spotbugs
3m 23s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

-0 :warning:
checkstyle
1m 16s
hbase-server: The patch generated 1 new + 63 unchanged - 0 fixed = 64 total (was 63)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m  6s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
4m 30s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

44m 18s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 4eb894d8e3d6 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4506f8d8ab

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Do we think this a good way forward?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
branch-2 passed

+1 :green_heart:
checkstyle
1m 49s
branch-2 passed

+1 :green_heart:
spotbugs
3m 11s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

-0 :warning:
checkstyle
1m 14s
hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

38m 53s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux f8b9d1082f8d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 38s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  4s
branch-2 passed

+1 :green_heart:
compile
1m 51s
branch-2 passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 34s
hbase-client in branch-2 failed.

-0 :warning:
javadoc
0m 43s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 42s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
shadedjars
6m 44s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 35s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 50s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
3m 19s
hbase-client in the patch passed.

-1 :x:
unit
215m 41s
hbase-server in the patch failed.

253m 10s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8baafa9bc8d3 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/testReport/

Max. process+thread count
2610 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  9s
branch-2 passed

+1 :green_heart:
compile
1m 30s
branch-2 passed

+1 :green_heart:
shadedjars
5m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
shadedjars
5m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 30s
hbase-client in the patch passed.

+1 :green_heart:
unit
229m 38s
hbase-server in the patch passed.

261m  7s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c76a0aae5a0d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/testReport/

Max. process+thread count
2745 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
branch-2 passed

+1 :green_heart:
checkstyle
1m 39s
branch-2 passed

+1 :green_heart:
spotbugs
3m  6s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 15s
the patch passed

-0 :warning:
checkstyle
1m  4s
hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 19s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

37m 20s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c2ceb7cdd540 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 59s
branch-2 passed

+1 :green_heart:
compile
1m 49s
branch-2 passed

+1 :green_heart:
shadedjars
7m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 14s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 24s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
shadedjars
6m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 29s
hbase-client in the patch passed.

+1 :green_heart:
unit
141m 49s
hbase-server in the patch passed.

177m 56s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b2a902d411fe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/testReport/

Max. process+thread count
4257 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 48s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 24s
branch-2 passed

+1 :green_heart:
compile
2m  9s
branch-2 passed

+1 :green_heart:
shadedjars
7m 59s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 37s
hbase-client in branch-2 failed.

-0 :warning:
javadoc
0m 51s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 16s
the patch passed

+1 :green_heart:
compile
2m  5s
the patch passed

+1 :green_heart:
javac
2m  5s
the patch passed

+1 :green_heart:
shadedjars
7m 34s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 37s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 52s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
3m  2s
hbase-client in the patch passed.

-1 :x:
unit
207m 56s
hbase-server in the patch failed.

249m  5s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 01855400bda9 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/testReport/

Max. process+thread count
2576 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Failed in here:
[INFO]
[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.util.TestHBaseFsckCleanReplicationBarriers.null
[ERROR]   Run 1: TestHBaseFsckCleanReplicationBarriers.testCleanReplicationBarrierWithNonExistTable:91->Object.wait:328->Object.wait:-2 Â» TestTimedOut
[ERROR]   Run 2: TestHBaseFsckCleanReplicationBarriers Â»  Appears to be stuck in thread Time-li...
[ERROR]   Run 3: TestHBaseFsckCleanReplicationBarriers.setUp:72 Â» IllegalState A mini-cluster i...
[INFO]
[ERROR]   TestHBaseFsckCleanReplicationBarriers.testCleanReplicationBarrierWithNonExistTable:91 Â» InterruptedIO
... which is flakey.
Let me rerun just in case.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  1s
branch-2 passed

+1 :green_heart:
checkstyle
2m  0s
branch-2 passed

+1 :green_heart:
spotbugs
3m 59s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 50s
the patch passed

-0 :warning:
checkstyle
1m 18s
hbase-server: The patch generated 1 new + 64 unchanged - 0 fixed = 65 total (was 64)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

42m  2s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6294f41ad7bf 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
branch-2 passed

+1 :green_heart:
compile
1m 33s
branch-2 passed

+1 :green_heart:
shadedjars
5m 46s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in branch-2 failed.

-0 :warning:
javadoc
0m 40s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
1m 32s
the patch passed

+1 :green_heart:
javac
1m 32s
the patch passed

+1 :green_heart:
shadedjars
5m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 14s
hbase-client in the patch passed.

-1 :x:
unit
126m 48s
hbase-server in the patch failed.

157m  0s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e7fd2218007c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/testReport/

Max. process+thread count
4181 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 14s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 58s
branch-2 passed

+1 :green_heart:
compile
1m 34s
branch-2 passed

+1 :green_heart:
shadedjars
6m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 32s
the patch passed

+1 :green_heart:
compile
1m 50s
the patch passed

+1 :green_heart:
javac
1m 50s
the patch passed

+1 :green_heart:
shadedjars
6m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 50s
hbase-client in the patch passed.

+1 :green_heart:
unit
206m 39s
hbase-server in the patch passed.

242m 38s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1955

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 000c138c3342 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 017c374519

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/testReport/

Max. process+thread count
2684 (vs. ulimit of 12500)

modules
C: hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1955/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Merged. The failures vary and are flakies.