[[Fix]] Make const have block scope

I've re-combined the copy and pasted code for var/const/let and in the process made const block scoped as per the spec.
It was a bit of a nightmare and the code was a bit of a nightmare.
I'd like to see if there are any bits to tidy and add some more tests, but I wanted to start getting feedback first - no point polishing if you are unhappy with the general approach.
More things to do:

I've removed the hacked-in way to allow unused variable tracking of consts and replaced it with a new system (again just for consts) - would it be nice if this was the same for all variables?
I added a todo about the warnunsed method not being used - it was already like this, but I'll see if it makes sense to fix or take out
more tests

Wow, nice work.

Coverage increased (+0.03%) to 96.36% when pulling 3c53cdd588c5896a6e681ad14dd7d772400609f2 on lukeapage:fix-2269 into dd768c243af2bd3a8beb5e47768eef3ec7ab2e5e on jshint:master.

Coverage increased (+0.03%) to 96.36% when pulling 3c53cdd588c5896a6e681ad14dd7d772400609f2 on lukeapage:fix-2269 into dd768c243af2bd3a8beb5e47768eef3ec7ab2e5e on jshint:master.

@rwaldron I've been looking at fixing #2292 and uncovered a few problems around const and let, so I am thinking of waiting on simplifying the way in which things can be marked as unused until after those changes.
So this PR is ready for review and (hopefully) merging.

bugs I think will be fixed by this:
#2271 #2268 #1884
maybe #2090 but its lacking info

Coverage increased (+0.03%) to 96.37% when pulling cec06eb6e04c61b3eefbdb152c5ad0ca83ddae7f on lukeapage:fix-2269 into dd768c243af2bd3a8beb5e47768eef3ec7ab2e5e on jshint:master.

Coverage increased (+0.03%) to 96.37% when pulling cec06eb6e04c61b3eefbdb152c5ad0ca83ddae7f on lukeapage:fix-2269 into dd768c243af2bd3a8beb5e47768eef3ec7ab2e5e on jshint:master.

As soon as @jugglinmike or @caitp review and give it the go ahead, it can land :)
Thanks for putting in the work to address these issues!

So, I'd really appreciate it if the variablestatement stuff was changed a bit --- keep the lexical declarations together, but I'd really appreciate it if var was kept separate for its distinct binding behaviour, and easier debugging.

Otherwise LGTM --- deferring to @jugglinmike for the rest

Thanks for the code review, it was good. I think I have addressed everything.

Coverage increased (+0.02%) to 96.38% when pulling fd87faf645002e39f4d7abe721202bceb6d5ab09 on lukeapage:fix-2269 into 2b673d92107be93df80e48471dced0432a127f25 on jshint:master.

Coverage increased (+0.02%) to 96.38% when pulling 011f70771c5423b12d4de3a8bd257dcc06c240d6 on lukeapage:fix-2269 into 2b673d92107be93df80e48471dced0432a127f25 on jshint:master.

0.10 travis build failed posting to coveralls - can you restart?

Coverage increased (+0.02%) to 96.38% when pulling a61f61d66e2b433a6e8bfc1967f31ca7d4654687 on lukeapage:fix-2269 into 2b673d92107be93df80e48471dced0432a127f25 on jshint:master.

Coverage increased (+0.1%) to 96.46% when pulling 5e946a712c195307e92db9d9cf2ab1d41015756a on lukeapage:fix-2269 into 2b673d92107be93df80e48471dced0432a127f25 on jshint:master.

Squashed and merged to master at commit 1bb80f9a5551a639db2be0dea655c9edef7a9b8a . This was a big one; thanks for your hard work, @lukeapage !


Mass matrices not compatible with diffeq_adjoint

I'm trying to use a DAE as a layer in a neural net. When the DAE is specified as an ODEProblem using an ODEFunction and mass_matrix, DiffEqFlux can solve the problem but it cannot be used in a neural net using diffeq_adjoint. On the Slack channel, @ChrisRackauckas mentioned that mass matrices are currently not compatible with diffeq_adjoint. I'm reporting this issue here so it can be tracked. Thanks.

Yup, thank you for the report. We are looking into how the adjoint can be extended to allow mass matrices. It doesn't seem to be that difficult, so I think we may have it sooner rather than later.

Great - thanks.

Hi there @ChrisRackauckas, any update on this? I have a problem where I'd like to either have a DAE solve as part of the loss function, or as the last layer of the network (either would work for my application) – is there any way to do that right now?
Thanks for this package, it was the thing that finally pushed me to bite the bullet and learn Julia. :)

There's an implementation here https://github.com/JuliaDiffEq/DiffEqSensitivity.jl/pull/86 and it works with non-singular mass matrices, but I can't find out why it doesn't work for singular mass matrices.

Non-singular mass matrices are now supported, but singular mass matrices are coming next.

It's good now.


⚠ Metadata API Service has degraded performance

In 1a9a6bc, Metadata API Service (https://api.ooica.net/metadata/status) experienced degraded performance:

HTTP code: 200
Response time: 10137 ms

Resolved: Metadata API Service performance has improved in c1d19eb after 6 minutes.


mayhem integration

it is part of stencila... it targets their markdown parser. they use pulldown-cmark to parse out "events" from a markdown source, then from there they extend the markdown syntax further with latex-like math notation


Quiz Checker is not being used

Summary:
It seems that quiz checker is not being used anywhere. Earlier if the revert rate was more than 15% then the quiz popup was shown. It doesn't seem to happen anymore.

Yes @maskaravivek it is not being used anywhere

I would like to work on this. Shall i pick it up?

I was actually already working on it. Can you please take up some other issue. :)

Sure :-)


Extra cursor-down when calling macro from vim file

Describe the bug
There is extra cursor-down when @b from vim file
let @b = ':echo "hello world!"^M'
To Reproduce

vim --clean
:w t.vim
input [ let @b = ':echo "hello world!"^M' ]
:w t.vim
so %
@b  <--  cursor-down
@b  <--  cursor-down
@b  <--  cursor-down

Expected behavior
No cursor-down when @b
Screenshots

Environment (please complete the following information):

vim 8.2.2968
Windows 10 21H1 19043.1052

Additional context
whend adding "^[" after "^M"  ( -->  let @b = ':echo "hello world!"^M^[' ) there is no extra cursor-down

I have changed '^M' to "\n"
Thanks a lot @brammool !


Uncaught Error: Invalid hook call. Hooks can only be called inside of the body of a function component.

import React from "react";
import Fetch from "./Fetch";
import { useState, useEffect } from "react";
const Header = () => {
const [data, setData] = useState([]);
useEffect(() => {
setData(Fetch("header"));
}, [data]);
return (

hellooooo

);
};
export default Header;
this is the code. i am importing Fetch and trying to call it in useEffect but i am geeting error. but if try to run useEffect in fetch file itself then it will run. My react and react-dom version is same, also they are matching with packge.json .

Based on the code you've provided, it seems that the Fetch component is returning a Promise, which means that you need to handle the data inside a then block. Here's an updated version of your Header component that should work:
import React, { useState, useEffect } from "react";
import Fetch from "./Fetch";

const Header = () => {
  const [data, setData] = useState([]);
  useEffect(() => {
    Fetch("header")
      .then(response => setData(response))
      .catch(error => console.log(error));
  }, []);

  return (

      {data && data.length > 0 ? (

          {data.map((item, index) => (

{item.title}

          ))}

      ) : (

Loading...

      )}

  );
};

export default Header;
Notice that we're now handling the data inside a then block, and we're also adding an empty dependency array as the second argument to useEffect. This tells React to only run the effect once, when the component mounts.
Also, I've added a conditional rendering to handle the case where the data is still loading. In this case, we display a "Loading..." message. Once the data is loaded, we display a list of items.
I hope this helps!

Support requests filed as GitHub issues often go unanswered. We want you to find the answer you're looking for, so we suggest the following alternatives:
Coding Questions
If you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.
https://stackoverflow.com/questions/tagged/react
Talk to other React developers
There are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.
https://reactjs.org/community/support.html


How read multipart/form-data (json + octet stream)

How is it possible to read form-data with a boundary containing octet-stream type (the file) and a boundary containing application/json (metadata) ??
FormHttpMessageConverter is encode-only ... how can I decode this response ??
Thx

You can do it like in this test, its server side is here.


Add implementations of composite specifications

Should composite specifications like AddSpecification and OrSpecification be added to the library?

Folks can build such things themselves, but I'm not generally a fan of them. The issue is that they start to move logic out of the domain and the specifications and into the application or UI layer where the specifications are created. Now instead of just newing up the appropriate spec and passing it to the repository, the client code needs to stitch together some collection of specs to be applied using boolean logic in a non-standard manner (i.e. not using && and II for boolean logic). All of that composition of filters could have and I would say should have been done in a new specification that simply does that work, has a name, and lives in the domain model.
That said if you need it, and you understand the potential consequences but are fine with them, build it and have at it.

Right, so if I want to create a new spec based on two other specs and keep things DRY, internally I would want the new spec to simply combine the other two instead of having to copy/paste the logic from the specs into a new one.

Composite specifications address a particular problem in the specification pattern, but are not applicable for Query Specifications.
Specification pattern in general provides a mechanism for combining and encapsulating a set of business rules. The idea is that the given specification will expose IsValid behavior which provides information if the defined business rules are met or not. Simply said, they're one form of validators. In this context, creating an infrastructure for composite specifications is quite straightforward.
This library has a more specific application. We're trying to leverage the original idea, but instead of representing business rules, in our case specifications describe and represent queries. That said, combining specifications is not feasible, nor logical. Imagine if in one specification you have applied Take and Skip, and in the second one, you have an additional Skip. What And/Or operations will represent in this case? Yes, composite specifications are feasible even for query specifications, but only for simple implementations where you have only filtering logic (i.e. Where expressions possibly).
Makes sense?

DRY is a nice and very useful pattern. But, as with everything else, we should not take it to an extreme.

No offense, but that's funny to me. I feel like limiting the specification pattern based on your personal preference as opposed to the guidelines that Martin Fowler set out and which all(/many?) other implementations follow is a bit extreme. Instead of letting users decide how they want to structure their specifications, you are deciding for them.
Combining specs by creating new ones is only trivial in simple scenarios. What if I don't know all the specs that I need upfront? What if a library defines a spec and I want to use it in combination with my own. Am I supposed to decompile their code and copy it?
This greatly increases the learning curve and the amount of work to get started. Not having composites is also contrary to what developers expect leading to confusion (which I've had a lot of).

Imagine if in one specification you have applied Take and Skip, and in the second one, you have an additional Skip. What And/Or operations will represent in this case?

OK, so what if there was an interface that didn't allow Take and Skip, something like IQueryableSpecification?
Finally, are composite specs feasible or not in this library, I feel like I got different answers from each of you.

They're feasible (as in possible), but neither Fati nor I recommend them, so we're not including them in this library for the reasons we've tried to outline. This isn't the only library available, and you can always fork it, or just take all the code and use it however you like (it's MIT licensed). But since we don't think they're something most users would benefit from, we've chosen not to include such composite specs (AndSpec, OrSpec, etc.) "in the box".

I'm not offended, enjoy 😄 It's all part of the discussion.
Yes, I'm very well aware of Martin Fowler's guidelines. But, as mentioned above we're not implementing exactly that. If analyzed carefully, Martin talks about creating a mechanism for better encapsulation of the business criteria in your application. There was an initiative to add validation behavior in this library, I was elaborating that in more detail here.
In our case, the specification should be independent constructs that are closely related to your application, and your application only. They're tightly related to your entities, and inheriting from external sources does not make much sense.
I provided the Take and Skipt just as a sample, but that applies to all the features we have here, starting from ordering, caching, ORM-specific features like AsNoTracking, etc. Also, if we have noticed we're keeping all criteria as Expressions, not delegates since we're trying to delay the execution and leave that part to ORM providers. So, not even the Where feature is not easily composable. We're compiling them for the in-memory evaluations only.
Simply said, in our case specifications are just constructs that describe a given query. They do not act upon the information they hold, they're just information providers to anyone who wants to utilize it (i.e. EF Core evaluators).
Steve's and my answers are aligned actually.

Closing as I think this is resolved.


Fix flaky ManagedLedgerImpl shutdown

Fixes #10356

@codelipenghui @eolivelli @congbobo184 @merlimat Please review. This fixes the flakiness issue in master branch.

/pulsarbot run-failure-checks

Looks good.
I wasn't sure about the 'possible race conditions' that may happen during shutdown.

Yes ledgers map changed asynchronously (that's the race condition) and this caused the shutdown to wait forever. The stacktrace in the issue helps understand it.

Also, the title is not only about ManagedLedgerFactory, can you please correct it?

Updated


fix: remove unneded discriminator ignore instance

Description
Remove discriminator ignore that have been fixed already.
Link to any related issue(s):
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[ ] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation (if appropriate)
[ ] I have run make fmt and formatted my code

Further comments

fixing


ZX Spectrum 128K implementetion progress tracking

Work on 128K implementation was started in develop branch

[x] Memory
[x] Screen validation on bank switch
[x] Check contentions
[x] Loading custom 128K ROM
[ ] Joysticks
[ ] Window size option

Development started by fe2b0d8faae91dcf06e22a945a70421b418bbf35 commit.

AY chip moved to separate issue #25

AY implemented via e4e3513

Kempston implemented via 3059a5a5023aaa85b85641d1ce57d5595a20d8fc

All things are implemented. Closing.


react-native compatibility

i saw someone using this for react-native any idea how??

No idea how; it’s a React (DOM) lib.


Ghosts

Time to get spooky in the most classical way possible. Ghosts mainly spawn in graveyards (although they can be found in other areas rarely) in small groups.
Visuals:
Ghosts are mostly white with varying colored eyes. They float and have no feet or legs.
Potential design inspiration:

Mechanics:
Ghosts will float towards and have a short aggro range (<10 blocks). They are immune to projectiles and take 1.25x damage from the Reapers Scythe.
Stats:
HP: 15
Damage: 4-5 (2x-2.5x hearts)
Drops:
Not entirely sure what they should drop yet-- I figure it could be a resource used for graveyard related recipes. Maybe a rare item that converts Zombie Villagers into normal Villagers?

They should drop Ectoplasm. Not sure what it would do though.
(by the way, you can already convert Zombie Villagers into normal VIllagers in vanilla with a Splash Potion of Weakness and a Golden Apple)


[iOS] Replace UnimplementedView with UnimplementedNativeView

Summary:
Seems we already have the  fallback descriptor mechanism, we can use UnimplementedNativeView to show un-support components and not need UnimplementedView anymore.
Changelog:
[IOS] [CHANGED] - Replace UnimplementedView with UnimplementedNativeView
Test Plan:
Show UnimplementedNativeView for un-supported components.

Just to set expectation, this will take a bit of time to land as several internal apps were using the component that got removed, so I have to spend some time to refactor them as well, before landing the diff.

@cipolleschi Thanks for the work. Are they only use component class directly? whether we can rename the new component class name to the removed component name?


Get ready for Journal of Open Source Software publication

See here: http://joss.theoj.org/about#author_guidelines

@mrocklin @ordirules @danielballan @sbillinge Please look this over and either push to this branch or PR into this branch any changes. (Or just email me)

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   96.99%   96.99%
=======================================
  Files           9        9
  Lines        1097     1097
=======================================
  Hits         1064     1064
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bdc6c...5120c05. Read the comment docs.

Thanks CJ
Please could you refer to the paper submission checklist for the group on group google groups and go through it before anything is submitted.  Thanks.

As Kevin and Simon are listed, would it be appropriate to add myself ?

Sure, can I please have your ORCID?

Thank you - 0000-0001-7079-0878

@mrocklin Can I get your ORCID? (Or can you push it to this branch?)

Things left to do (I think, feel free to add more):

[ ] Turn all the references (spark, flink, etc.) into real references like https://github.com/arfon/fidgit/blob/master/paper/paper.md
[ ] Double check that all funding and contracts are acknowledged
[ ] Discuss paper length and content. (we may want to link to the blog post at the very least?)

Broadly speaking I hesitate to push forward on this.  There has been a fair amount of churn recently and this will likely continue into the near future.  It's not clear to me that we should publish any artifact about this at this stage.

I wonder if, instead, it would make sense to publish things about your downstream code SHED?

That is in the works too, but we thought it would be best to get the base library in the open so that we can cite it for SHED.

That is in the works too, but we thought it would be best to get the base library in the open so that we can cite it for SHED.

While I can see the value of a citation I think it's best to wait.  I would like to close this for now.  Are you ok with this?

I am ok. I don't think we are quite ready.
On Wed, Nov 1, 2017 at 5:17 PM Matthew Rocklin<EMAIL_ADDRESS>wrote:

That is in the works too, but we thought it would be best to get the base
library in the open so that we can cite it for SHED.
While I can see the value of a citation I think it's best to wait. I would
like to close this for now. Are you ok with this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mrocklin/streamz/pull/63#issuecomment-341245518, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEDrUX0TxrS8Br0SnB84x9Dk8dX4AbmHks5syN_TgaJpZM4PcsSs
.

Ok


Upgrade 0.9.x to cats 1.0.1

Hey, my team is till on 0.9.x, but the old Cats dependency conflicts with other libs, so I cherry-picked couple of commits to bring the latest Cats to 0.9 folks.
Can you please create a branch from v0.9.5 tag so that I can target my PR against?

You can grab M7 which depends on Cats v1.1.0


color tables missing between 3.3.3 and 3.4.1

Describe the bug
User reports that their color tables were gone in 3.4.1, but when they run 3.3.3, they are back.
A tarball with their ~/.visit directory is located on LLNL CZ at:
/usr/workspace/visit/visit/bug_data/visit_bug_19456.tar

Helpful additional information

Did VisIt crash:
Did you get wrong results: yes

We no longer read color tables from session files.

Can we close this ticket then?

We should write up a guide to help folks address this, possibly write a python script that can process the session files and drop the color table


FIX #4875 : update modal onclick reference for same modal while pasting modal

Description

While copying and pasting a modal. The modal close button was not working properly as it was referring to the old modal. updated the same in function and added test cases for it.

Fixes #4875

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Locally.
Added new Test cases

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=430e852

Tests failing, Re-ran!

@vibhandikyash Issue: In deploy preview I am not able to open the 2nd Modal.
Steps:

Create a new modal
Copy this modal (cmd + c)
Click on the canvas to close first modal
Paste a new modal (cmd + v)
Not able to open second modal

https://www.loom.com/share/af3e99891cc94a878407eef391474e1b

@vivekverma2312 my bad, I didn't realize that you were still testing this out on the deploy preview. Can we check this on release and create a Bug for this if required. You can assign it back to me. Ill take care of it!


Support of Select clause for INSERT

Use case
Sometimes, we want to insert data only if other data exists.
Describe the solution you'd like
This is a SQL example :
create table if not exists guild
(
    id         serial                   not null,
    name       varchar(500)             not null,
    owner      uuid                     not null,
    created_at timestamp with time zone not null,
    constraint pk_guild primary key (id)
);

create table if not exists guild_member
(
    guild_id   integer                  not null,
    member_id  uuid                     not null,
    pending    boolean                  not null,
    created_at timestamp with time zone not null,
    constraint pk_guild_member primary key (guild_id, member_id)
);

ALTER TABLE guild_member
    ADD CONSTRAINT FK_guild_member_guild
        FOREIGN KEY (guild_id)
            REFERENCES guild (id)
            ON DELETE CASCADE
            ON UPDATE CASCADE;

INSERT INTO guild(name, owner, created_at)
VALUES ('test', '98aadca5-d4fd-446c-b59f-97d451aecc89', now());

-- Insert should not be added because guild id "0" doesn't exist
INSERT INTO guild_member(guild_id, member_id, pending, created_at)
SELECT g.id, 'e1d3bad7-e21b-4d37-b7df-e254bbb0b821', true, now()
FROM guild g
WHERE g.id = 0;

-- Insert should be added because guild id "1" exists
INSERT INTO guild_member(guild_id, member_id, pending, created_at)
SELECT g.id, 'e1d3bad7-e21b-4d37-b7df-e254bbb0b821', true, now()
FROM guild g
WHERE g.id = 1;

In this example, we have a constraint (Foreign Key) from guild_member to guild.
So, if we want to add a member only if  a guild exists (to avoid an exception in the code) it could be helpful to have a SELECT clause for insert method
Versions

Komapper: 1.8.0
Kotlin: 1.8.0
JVM: 17
JDBC Driver or R2DBC Driver: Both
Database: PSQL

Does this functionality meet your needs?
https://www.komapper.org/docs/reference/query/querydsl/insert/#select


Wrong hint?

https://github.com/kreshuklab/teaching-dl-course-2019/blob/master/Webinars/exercise1/image_manipulation.ipynb?short_path=a1d32b1#L136
For me, the "Clear output" is on the top right of the cell in the context menu. There is no "run cell" button.

Are you using Google Colab though?

yes


#747: Convert auth package to Kotlin

Description (required)
Kotlin conversion (#747). Hoping to get more of the app in Kotlin, eventually so it'll all be one language and easier to standardize and reason about.
This converts the auth package to Kotlin
Tests performed (required)
Tested BetaDebug on Oneplus 6T with API level 29

Codecov Report

Merging #4080 (e57393b) into master (b24ed1c) will increase coverage by 0.02%.
The diff coverage is 0.66%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24ed1c...e57393b. Read the comment docs.

hey @domdomegg , any luck with this PR regarding to my previous reviews?:)

Hi, sorry for the delay in getting back to you! I've been very busy this summer :)
I struggled to reproduce the bug you mentioned, despite having over 200 uploads. I'm going to keep digging (and I'll need to fix the merge conflicts anyways). Will convert this to a draft until that's fixed and if I get too stuck might ask if you could look into it again.

This is one of the PRs that I don't know what to do :) The errors are not reproducible all the times unfortunately :/ Should we convert it to draft @domdomegg , what would you suggest?

Hi @neslihanturan I've merged in master and so I think it is now up-to-date. I'm not able to reproduce the errors - are you sure they are specific to this branch? This should reimplement the functionality exactly, and my hope is to get everything in Kotlin so we can move faster going forwards with just one main supported language.

Hey @domdomegg thanks for merging to master. I think after the merge there are some build errors as:
LoginActivity.kt: (402, 25): Type mismatch: inferred type is String? but String was expected
LoginActivity.kt: (228, 22): No value passed for parameter 'p7'
LoginActivity.kt: (202, 63): Type mismatch: inferred type is <no name provided> but String was expected
SessionManager.kt: (120, 29): Expecting comma or ')';

Ah yep my bad, think I messed up the merge.
I think at this stage given the problems with the PR I'm just going to close it - possibly more effort to fix the merge than it would be to redo the PR :joy:.
One day (in my dreams) we'll get everything migrated to Kotlin, and I think that should be somewhat of a strategic priority to maximise future development velocity, both for us and new contributors with one consistent way of doing things :)


Error on post in this example

For the post method example, I get System.InvalidOperationException: No route matches the supplied values.
body:
{
"name":"walk dog",
"isComplete":true
}
Method:
[HttpPost]
public async Task<ActionResult<TodoItem>> PostTodoItem(TodoItem item)
{
_context.TodoItems.Add(item);
await _context.SaveChangesAsync();
        return CreatedAtAction(nameof(HttpGetAttribute), new { id = item.Id }, item);
    }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The tutorial works. I'm not sure what step you missed. You might try asking on StackOverflow,.

No, does not work, at least in version 2.1. I didn't miss any step. The CreatedAtAction does not work. If I change it for
return Created(nameof(GetTodoItem), new { id = item.Id, name = item.Name, isComplete = item.IsComplete });
it works


Unable to Fetch a text and store it into a string

@jan-molak ,
During my test I want to save the text of a web element and need to assert later during the test.
I'm sure "chai.expect" will help me in asserting, However I couldn't find any interaction to save the text of the Web element during the Test into a string. Do we have any such Interaction already Implemented??
Example:
WebElement txtBoxContent = driver.findElement(By.id(WebelementID)); String testValue=txtBoxContent.getText();
Above is the way to do it in Selenium, not sure how to do it here. I have tried Text.of However its returning me an object and when I try to assign it to Sting its throwing me error "argument type question string is not assignable to parameter type perform-able".
confirmationVoucher = Text.of(confirmationPage.VoucherCode)
I'm new to JavaScript/Typescript, Any help on how to handle the above scenario will be a great help. Kindly let me know if this issue is in-appropriate here I can close this issue.

Hello @srinivasbudh!
Yes, Text.of(confirmationPage.VoucherCode) would return a Question, which needs to be evaluated in the context of your actor before it can be asserted on.
// To create a Question:
Text.of(confirmationPage.VoucherCode);

// To evaluate a Question and return a Promise:
actor.toSee(confirmationPage.VoucherCode);

// To assert on the value of the returned Promise:
expect(actor.toSee(confirmationPage.VoucherCode)).eventually.equal('expected code')

Does that help?

Hi ,
Sorry if I have conveyed it wrongly. My question was to know if there is any interaction to take the text of a web element and store it into a string. Is this possible?? Like in selenium getText() which will help to store the value into a string as mentioned above in issue

Sure, although it would be easier for me to suggest something if I understood your test scenario a bit better. I'm guessing it perhaps goes somewhat along the lines of:

an actor starts working with the application
they're shown some sort of a voucher code
they perform some additional tasks (add items to a basket perhaps, go to checkout?)
they need to enter the voucher code they've been shown before, maybe before they pay for the items?

Is that what you're trying to accomplish?

Yes, Jan functionally I'm looking at the same thing  with a small change

an actor starts working with the application
they're shown some sort of a voucher code specific to this user as special offer
they perform some additional tasks (add items to a basket perhaps, go to checkout?)
Proceeds to payment page where  he see multiple voucher code with different offers but he need to check if the specific voucher offered to him during step 2 is there in the list of vouchers
And then select it

I see, thanks for the explanation.
This functionality was not available out of the box at the time when you asked the question.
However, since it seems to be a common scenario, it's now built-in 😄
Your scenario is now supported via the ability to TakeNotes, please check:

the unit tests for the API examples
the brand new documentation

Hope this helps,
Jan

@jan-molak : Thanks for providing the explanation above regarding getting the text out of an element.
However, when I'm trying to get text out of a select object (drop-down)I am facing issues.
Here is my code for your reference:
const stage = serenity.callToStageFor({
                            actor: name => Actor.named(name).whoCan(
                                                              BrowseTheWeb.using(protractor.browser),
                                                              TakeNotes.usingAnEmptyNotepad(),
                                                      ),
                       });

this.When(/Cucumber When Block/, function() {
Actor.named('User').attemptsTo(TakeNote.of(RaceMeetings.SelectMeeting));
return stage.theActorInTheSpotlight().attemptsTo(Click.on(RaceMeetings.Continue));
});
I am new to SerenityJS, would you be able to provide an example to get text out of an element.
The unit tests link above seems to be broken.
I've implemented the code based on new documentation example, however, it's not helping.

this.Then(/^check something$/,function(){
var elemtext: PromiseLike = james.toSee(Text.of(elem));
return elemtext.then(function(val)){
console.log(val);
})

I want to fetch the text from an xpath and store it in a string.
After entering all inputs and submitting , a new code will get generated and which looks like Customercode: IN02732114(number will dynamic).
Now i want to fetch this code and store it in a string and later want to use this string to search the data with this code.
i have used below snippet to get the text.
public static Question customer_code_value3() {
return actor ->  Text.of(CustomerCreatePage.CUSTOMER_CODE_TEXT).viewedBy(actor).asString().substring(15, 26);
}
now how can i store this in a string.
plz let me know
@jan-molak

I want to fetch the text from an xpath and store it in a string.
After entering all inputs and submitting , a new code will get generated and which looks like Customercode: IN02732114(number will dynamic).
Now i want to fetch this code and store it in a string and later want to use this string to search the data with this code.
i have used below snippet to get the text.
public static Question customer_code_value3() {
return actor ->  Text.of(CustomerCreatePage.CUSTOMER_CODE_TEXT).viewedBy(actor).asString().substring(15, 26);
}
now how can i store this in a string.
plz let me know
@jan-molak

Serenity/JS v. 2 introduced a way to .map Questions using a mapping function.
Text.of(CustomerCreatePage.CUSTOMER_CODE_TEXT).map(actor => value => value.substring(15, 26)

Serenity/JS v. 2 introduced a way to .map Questions using a mapping function.
Text.of(CustomerCreatePage.CUSTOMER_CODE_TEXT).map(actor => value => value.substring(15, 26)

i have wrote like this
public static Question customer_code_value3() {
return Text.of(CustomerCreatePage.CUSTOMER_CODE_TEXT).map(actor => value => value.substring(15, 26));
}
and now i am getting errors like this
cannot resolve method 'map' in 'UIStateReaderBuilder'
Cannot resolve symbol 'actor'
Cannot resolve symbol 'value'
can u plz help me ..
@jan-molak

i have wrote like this
public static Question customer_code_value3() {
return Text.of(CustomerCreatePage.CUSTOMER_CODE_TEXT).map(actor => value => value.substring(15, 26));
}
and now i am getting errors like this
cannot resolve method 'map' in 'UIStateReaderBuilder'
Cannot resolve symbol 'actor'
Cannot resolve symbol 'value'
can u plz help me ..
@jan-molak

@sudhir-kunchakuri UIStateReaderBuilder is part o Serenity BDD for Java, not Serenity/JS. If you're using the Java version you might want to raise this ticket here.

@sudhir-kunchakuri UIStateReaderBuilder is part o Serenity BDD for Java, not Serenity/JS. If you're using the Java version you might want to raise this ticket here.


Create CODEOWNERS

Add CODEOWNERS file with what I think is the appropriate team for this repo (let me know if not!)

@lesliecdubs just wanted to check-in to see if I had the right team for this repo in CODEOWNERS. Let me know if there is a more accurate team here 👀 (or if this repo doesn't need a CODEOWNERS file)

Closing in favor of: https://github.com/primer/eslint-plugin-primer-react/pull/88


[release/1.6] remotes: add handling for missing basic auth credentials

When a credential handler is provided but no basic auth credentials are provided, handle the error specifically rather than treating the credentials as not implemented. This allows a clearer error to be provided to users rather than a confusing not implemented error or generic unauthorized error.
Add unit tests for the basic auth case.
Backport #9234
(cherry picked from commit 51c9ffe468f8752d851ab6efda61a2f55026edfc)

I should pull in #6617 to fix the tests

Should be fine now? Maybe we can get it merged.


Make portability tests pull images from Dockerhub and add test filter

Known issues:
Performance - #9668
Interop - #9762
I am the author of the commits - CLA could not be found because I made these commits on a computer that was not configured properly.

A bit unrelated - is the test filter expected to work just fine on internal_ci?

I think it should? We just have to pass the target merge branch when calling run_tests_matrix.py so hopefully an env var will be available for this.


Retention - Stop/Disable

Hello,
It could be good if in document explained how to stop the retention policy, what is impact, and what is expected when the policy is stoped/the user is excluded or the policy is deleted.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ef663fdc-1776-3c73-7743-332796c284e6
Version Independent ID: ceb29788-39be-8c30-b92a-7a22243ebe83
Content: Automatically retain or delete content by using retention policies - Microsoft Purview (compliance)
Content Source: microsoft-365/compliance/create-retention-policies.md
Service: o365-seccomp
GitHub Login: @cabailey
Microsoft Alias: cabailey

Hi @lightupdifire, yes, there's quite a bit to this so it's covered where we explain the other concepts about Microsoft 365 retention: https://learn.microsoft.com/en-us/microsoft-365/compliance/retention?view=o365-worldwide#releasing-a-policy-for-retention


.next returns wrong dates

From the README.md I used this example:
// Create a recurrence
recurrence = moment("01/01/2014").recur().every(2).days();
// Generate the next three dates as moments
// Outputs: [moment("01/03/2014"), moment("01/05/2014"), moment("01/07/2014")]
nextDates = recurrence.next(3);
My outputs are:
// Outputs: [moment("01/02/2014"), moment("01/04/2014"), moment("01/06/2014")]

This is likely a timezone issue. I'm betting that moment.utc("01/01/2014").recur().... will do what you need. You can also do moment.recur("01/01/2014").... which sets the start date.

@bholbrook73 Both suggestions yield the same result as I reported in the original post.

Seems to work as expected here: https://jsfiddle.net/gg9gtm0c/
If you are still around and have any more information regarding the issue (actual source code would help), please let me know. Thanks.

As bholbrook73 suggested this is locale issue, but this is a bug in moment-recur
because moment-recur use moment.dateOnly() which is not documented (deprecated?) and not locale aware
I suggest lib should use moment.startOf('day')
moment("01/02/2017","MM/DD/YYYY").utcOffset(120,true).toString()
"Mon Jan 02 2017 00:00:00 GMT+0200"
moment("01/02/2017","MM/DD/YYYY").utcOffset(120,true).recur().every(1).daysOfWeek().next(1)[0].toString()
"Mon Jan 02 2017 22:00:00 GMT+0000"
moment("01/02/2017","MM/DD/YYYY").utcOffset(0,true).toString()
"Mon Jan 02 2017 00:00:00 GMT+0000"
moment("01/02/2017","MM/DD/YYYY").utcOffset(0,true).recur().every(1).daysOfWeek().next(1)[0].toString()
"Mon Jan 09 2017 00:00:00 GMT+0000"

It should be nice to add a note to document to tell users that moment-recur will return  moment objects in UTC mode.


Popover direction.

Why  there's no provision for left and right directions in popover .

good advice, i will add this feature sooner

I have the same issue


What UI do you use?

Dear all,
The default UI of  django-helpdesk is bootstrap UI,  I feel it's not beautiful. I found that the helpdesk writen in PHP looks pretty.
What UI do you use? Can anyone send me a beautiful one? Thanks.

example:
http://www.hesk.com/demo.php

Saying that something is not beautiful simply because it uses Bootstrap isn't a helpful suggestion, sorry.
We switched to Bootstrap a while ago for two reasons:

Most people don't use out-of-box templates, they will customise django-helpdesk to match the rest of their site. To that end, many people do use Bootstrap so this seems like a sane starting point for them to do their customisation... and if they want to throw away bootstrap and use custom templates, that's also alright.
If they don't want to customise the templates, Bootstrap is a "good enough" fit for  most people - it's relatively clean and simple and won't be too out of place on many websites. It also provides a familiar (to many) template structure to simplify out development process.

Further, my personal opinion is that the Hesk sample you've linked to looks like something out of the Windows XP era, and isn't a drop-in fit for most websites today in 2015. I would not want to update the default theming of django-helpdesk to match this.

Hi,
I think that using Bootstrap is a wise choice. It can be easilly
customised with limited knowledge of CSS and you have a responsive website.
I clicked the Hesk demo link and closed it right away.
On 13/04/15 01:21, Ross Poulton wrote:

Saying that something is not beautiful simply because it uses Bootstrap
isn't a helpful suggestion, sorry.
We switched to Bootstrap a while ago for two reasons:

Most people don't use out-of-box templates, they will customise
django-helpdesk to match the rest of their site. To that end, many
people /do/ use Bootstrap so this seems like a sane starting point
for them to do their customisation... and if they want to throw away
bootstrap and use custom templates, that's also alright.
If they don't want to customise the templates, Bootstrap is a "good
enough" fit for most people - it's relatively clean and simple and
won't be too out of place on many websites. It also provides a
familiar (to many) template structure to simplify out development
process.

Further, my personal opinion is that the Hesk sample you've linked to
looks like something out of the Windows XP era, and isn't a drop-in fit
for most websites today in 2015. I would not want to update the default
theming of django-helpdesk to match this.
—
Reply to this email directly or view it on GitHub
https://github.com/rossp/django-helpdesk/issues/318#issuecomment-92150660.


PlayerZero Cloud Docs

Proposed changes
Moved work from 4958 to current branch to make small edits/merge into the codebase.
Merge timing
Once approved by the original submitter!
Related issues (optional)
#4958

Lgtm!


Link to LICENSE is dead

Your link to LICENSE (https://github.com/Ramotion/swift-ui-animation-libraries/blob/master/LICENSE) in the README.md is dead.

Fixed


Document update

This was a comment I got from HCI team. However, when I try to deploy Arc VM management, without AKS, it keeps asking for controlplaneIP which "This is the IP address of the Kubernetes API server hosting the VM management application that is running inside the Resource Bridge VM. The IP address must be in the same subnet as the DHCP scope and must be excluded from the DHCP scope to avoid IP address conflicts. If DHCP is used to assign the control plane IP, then the IP address needs to be reserved."
I'm pretty confused how to get to the end of this installation an would appreciate this documentation being updated in line with no AKS deployment.

@anilcoolhub
Duplicate of #https://github.com/MicrosoftDocs/azure-stack-docs/issues/2567


How to use this library

Sorry for the noob question, but how can I use this library? What I have to do?

You install it like any other library, and you call its functions.
If you don't know how to do some particular step, you ask the community. If the library's documentation is seems inadequate, you report it.

@saxsoares
See unittests.
mersenne.nim#L72 e.g.

There's really no need for that, the main README has examples


Enabling the flight DMFEnableExecutionHistoryCleanupSystemJob in D365FO

It seems that Microsoft docs article "URL: https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/data-entities/data-import-export-job#job-history-clean-up-and-archival-available-for-preview-in-platform-update-39-or-version-10015" is not updated.
There is no need to activate this on 10.0.20 and newer update while those who use D365FO with older version than 10.0.20 need to register a support case to enable the flight DMFEnableExecutionHistoryCleanupSystemJob.
Regards,
Alireza Eshaghzadeh

@Eshaghzadeha - Thank you for the feedback.
@Peakerbl  - can you please take a look and update the topic?

Topic has been updated and changes published.


:sparkles: Middleware addition

Changes

adds:

on_channel_delete
on_channel_pins_update
on_channel_update
on_guild_delete
on_guild_update
on_message_reaction_add
on_message_reaction_remove
on_message_reaction_remove_all
on_message_reaction_remove_emoji
on_thread_create
on_thread_delete
on_thread_list_sync
on_thread_member_update
on_thread_members_update
on_thread_update

Check off the following

[x] I have tested my changes with the current requirements
[x] My Code follows the pep8 code style.

dont review yet. im just fixing that last commit

fixed

commit was wacky. I'm fixing it

https://app.codacy.com/gh/Pincer-org/Pincer/pullRequest?prid=8299424

https://app.codacy.com/gh/Pincer-org/Pincer/pullRequest?prid=8299424

@Arthurdw 👍

@Arthurdw can this be merged?


fix(cocoapods): update podspecs to use resource_bundles instead of re…

…sources

@mickael-menu Thank you! What does the release cadence typically look like?

It's pretty sporadic, two or three times a year. I'll probably do another release after finalizing TTS and adding the new settings API.


Incorrect expectations for ARGF.binmode behavior on Windows

These two expectations are incorrect: https://github.com/ruby/spec/blob/master/core/argf/binmode_spec.rb#L15-L29
Basically, there is a file with Unix-style line breaks, and it is expecting that setting binmode will convert these Unix-style line endings into Windows-style line endings. That does not make any sense, because it's just not what binmode does. Per http://ruby-doc.org/core-2.0.0/ARGF.html#method-i-binmode

Puts ARGF into binary mode. Once a stream is in binary mode, it cannot be reset to non-binary mode. This option has the following effects:

Newline conversion is disabled.
Encoding conversion is disabled.
Content is treated as ASCII-8BIT.

The proof is in the pudding:
C:\Users\Administrator\GitHub\spec>C:\Ruby\ruby-2.2.4-i386-mingw32\bin\ruby.exe -ve "ARGF.binmode; p ARGF.gets" C:\Users\Administrator\GitHub\spec\core\argf\fixtures\bin_file.txt
ruby 2.2.4p230 (2015-12-16 revision 53155) [i386-mingw32]
"test\n"

And here is the same result using ruby 1.8.7 (cause I wondered where these expectations came from, perhaps this is how it used to work on 1.8? But no.)
C:\Users\Administrator\GitHub\spec>C:\Ruby\ruby-1.8.7-p374-i386-mingw32\bin\ruby.exe -ve "ARGF.binmode; p ARGF.gets" C:\Users\Administrator\GitHub\spec\core\argf\fixtures\bin_file.txt
ruby 1.8.7 (2013-06-27 patchlevel 374) [i386-mingw32]
"test\n"

Ok, so to fix this and test ARGF.binmode properly, we need to add another fixture - a text file (named win_file.txt) containing Windows-style line breaks, then reading it in binmode should give us Windows-style line breaks, and reading it without binmode should give us Unix-style line endings:
C:\Users\Administrator\GitHub\spec>C:\Ruby\ruby-2.2.4-i386-mingw32\bin\ruby.exe -ve "ARGF.binmode; p ARGF.gets" C:\Users\Administrator\GitHub\spec\core\argf\fixtures\win_file.txt
ruby 2.2.4p230 (2015-12-16 revision 53155) [i386-mingw32]
"test\r\n"

C:\Users\Administrator\GitHub\spec>C:\Ruby\ruby-2.2.4-i386-mingw32\bin\ruby.exe -ve "p ARGF.gets" C:\Users\Administrator\GitHub\spec\core\argf\fixtures\win_file
.txt
ruby 2.2.4p230 (2015-12-16 revision 53155) [i386-mingw32]
"test\n"

@eregon unless there are any objections, I will be sending a PR for this, LMK...

Just realized that the reason for this working incorrectly may have something to do with git or something else along the line having converted the line endings in the fixture file bin_file.txt from \r\n to \n.

Yep, that was it - there's nothing wrong with the code, the problem was with the data (the fixture file). I replaced \ns with \r\ns in bin_file.txt and the spec makes sense again :smile:
C:\Users\Administrator\GitHub\spec>..\mspec\bin\mspec core/argf/binmode_spec.rb
ruby 2.0.0p247 (2013-06-27) [i386-mingw32]
[| | ==================100%================== | 00:00:00]      0F      0E

Finished in 0.171600 seconds

1 file, 4 examples, 6 expectations, 0 failures, 0 errors, 0 tagged

One down, hundreds more to go :beers:

Good find! 356fa4fb3e40f3a739c10f256d59a0885bfe39a7 seems the culprit.


Sending emails with PHP7

In PHP7 "String" cannot be used as class name anymore, which is currently used in "Type\BodyType". Renaming this class will solve the issue already.

This has been resolved with ce85d5b8831e62cd7781b20652ec27d0a9af399b.


fixed state scraper example to use new syntax

the state scraper example now has the new crontab syntax

Nice call, thanks!


Support server-side filtering for list_repo_tree

Is your feature request related to a problem? Please describe.
I need to retrieve some files from a dataset, for example all the *.json file. Currently, I am using the list_repo_tree function on all the files and check for my occurrences. However, it would be more efficient to provide a server-side filtering.
Describe the solution you'd like
Add filtering support on the API, similar to list_spaces's filter argument.
Describe alternatives you've considered
Continue with my current solution.

Hi @younik, listing info using list_spaces or entries in a repo using list_repo_tree has a completely different implementation server-side. Searching through Space is a very common use case so the data is already indexed in a search engine, making it easy to request only a subset of it based on a filter. On the contrary, listing files in a repo is a costly operation has files are not indexed. Since it's not done very often, the cost of indexing everything would be much much greater than indexing repos (we have 2M+ repos, each of them possibly containing thousands of files...) - and for a limited benefit.
This explains why it is not possible to filter them server-side when listing files from a repo. In theory we could do it before returning the response but in that case we would be hiding the complexity of the request to the end user (which is bad design-wise). So best solution is still to do the filtering client-side :)
Note that you can filter the listing by only listing files from a subdirectory. Hope this answers your question. I'll close this issue as "not planned" but please let me know if you have any further question


Add license to gemspec

I added license to gemspec based on the LICENSE.

Thank you.
I would like to add you to gems owner. Tell me your rubygems.org email, and release new version after add you.

Thank you, I'll do it.

I added you.
Please, create pull request for bump.


Docs CI fails on @azure/arm-sql

Example build: https://apidrop.visualstudio.com/Content CI/_build/results?buildId=248267&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=a04569be-1b08-5c9a-7e65-a83076350a0c&l=745
current package: @azure/arm-sql
current version is : 30.0.0-beta.1
##[debug]STDERR: [User Error]: ./types/arm-sql.d.ts doesn't exist, which is defined in package.json.
##[error][User Error]: ./types/arm-sql.d.ts doesn't exist, which is defined in package.json.
##[debug]Processed: ##vso[task.logissue type=error][User Error%5D: ./types/arm-sql.d.ts doesn't exist, which is defined in package.json.
##[debug]$LASTEXITCODE: 1

This error usually involves a configuration value in the package.json pointing to files which do not exist in the published package: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/sql/arm-sql/package.json#L29

I think this one should've been resolve with<EMAIL_ADDRESS>

@danieljurek Can we close this issue now ? As the problem should have been resolved.

I will close this issue. @danieljurek feel free to reopen it if you see any issues on it.


Model & Part Numbers

I know that this tool will use RPC (ssh/netconf/etc.) instead of SNMP when interacting with devices, but with other DCIM I have seen issues with model numbers polled do not even resemble the official model numbers.  As such, this has forced the need for model names, model numbers, an aliases for when odd SNMP model numbers are presented.
Regardless, I am just thinking about how we can enhance this object.  Furthermore, how should we handle the various variations of switch like the Catalyst 3750?  What are your thoughts on:

device type alias (to handle model numbers as well as potentially variations)
model/part number to handle the technical part number (normally hyphenated) - This would force you to create a device type for every variation of a model (not necessarily bad given the port count and speed variations)

For my cisco switches I do a show version and use say:
-WS-C3750E-24
-WS-C4948-10GE
-WS-C3750E-48
I don't have any POE models and am agnostic to IPbase vs IPservices so I don't bother to store the bits after that typically indicate the licensing included, POE, or other - but - if I did I would include them - there are though as you say so many variations that it's not (in my application) worth tracking it that granularly.
Each of these are their own device type with corresponding interfaces pre-set (sans VLANs)

How should we handle the various variations of switch like the Catalyst 3750?

Each variation is its own device type. Even a minimal difference between models (e.g. PoE versus non-PoE) is still a difference and needs to be accounted for. At most we might introduce the concept of a series to group similar devices, but that would just be for convenience.

Yea I'm with you on series for connivence, its really not absolutely needed.  But what are your thoughts on model / part number.  IE Part Name (Catalyst 3750X 48T-S) vs the official part number (WS-C3750X-48T-S).

I can see value in having a field for part/model.
We have some Cisco 3500 series switches that all say on the chassis they are WS-3500-something but show version could be a WS-3524 or WS-3548, etc
Not sure how other manufacturers stack up another use case to validate would be great otherwise we're essentially storing redundant information.

Intending to implement this as a new (optional) free-form part_number field on DeviceType.


can't preview unpublished magazine articles with slug

The preview for magazine articles does not work for unpublished articles that have a slug defined. It works fine for published articles as well as unpublished articles without a slug.

@fernandolucchesi can you have a look?


grafana support in release environment - [closed]

In GitLab by @tmon546596046 on Mar 1, 2018, 05:56
Merges grafana -> dev
add grafana container in release environment and expose the grafana ui from proxy container with /proxy/grafana prefix.

In GitLab by @wknet123 on Nov 13, 2019, 10:33
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:33
closed


triggering mediascanner

hey there, is it possible to trigger mediascanner from this module? because when i download an image it did not show in gallery. I have to restart my phone to trigger the mediascanner.

Yes, this should be possible. Will try to implement this, but will take some time.  Meantime if you have some time .. could you raise a PR for the same ?


Fix code formatting in setup.py

This is a simple MR, but I want to test that actions are running.

@Esterni can you check in the repository settings to see if actions are enabled? They aren't working for some reason. (Picture below)

I've got a test repository here: https://github.com/mikeholler/action-test
It has the same file and actions are running for master:

And for pull requests:

You can also see linting working on my fork, just not in the real repository. Also, fun fact, but we have like 700 lines of linting errors:
https://github.com/mikeholler/pyracing/runs/923473757?check_suite_focus=true


Update CI users list

Modulus Pull Request
Description
Added @Alexey-Kamenev to the CI users list
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


is the code reproducible？

It's not a good way to publish code,without usage and missing code file.

the bleu is only 15

it's corpus bleu ,sent bleu is 0.45

sep in char :bleu 15.61 ; sep in word, bleu 11.85

Rouge1 34.38 Rouge2 13.31 Rougel 25.58

@herbertchen1 hello，can you give some usage instruction? Thanks!

i didn't have time to write the usage, but you can get a better result with a pretrained BART, we will published the result in CIKM in this year
-----原始邮件-----
发件人:YuanWind @.>
发送时间:2022-08-09 19:32:58 (星期二)
收件人: egrcc/Review-Response-Generation @.>
抄送: herbertchen1 @.>, Mention @.>
主题: Re: [egrcc/Review-Response-Generation] is the code reproducible？ (#4)
@herbertchen1 hello，can you give some usage instruction? Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@herbertchen1 Ok, Thanks a lot.

@herbertchen1  Hello, could you please send me your mentioned paper now? Or the highest performance in your paper could be also ok, thank you very much.

@herbertchen1  Hello, are all the results reported in the CIKM paper sep in char?


DatasetBuilder 对 splits 和 data_files 加个  assert 限制不能同时出现是否会更好？

https://github.com/PaddlePaddle/PaddleNLP/blob/311bbfb7637c023fd627af2a47ff59db6f238140/paddlenlp/datasets/dataset.py#L474
e.g.
assert splits is None or data_files is None , "Only one of `data_files` and `splits` can be set."

Resolved by #530. Thanks for your contribution.

Why these two arguements should be exclusive? User may be needing PaddleNLP datasets and local file datasets at the same time. @jiaqianjing

Why these two arguements should be exclusive? User may be needing PaddleNLP datasets and local file datasets at the same time. @jiaqianjing

Yep, but it's kind of weird and not straight forward.  e.g.train_ds, dev_ds, local_train_ds =   load_dataset("lcqmc", splits=["train", "dev"], data_files="/to/path/xxx.tsv"). Generally, we use data_files for load our dataset. Another reason may be that there is no Internet.

More importantly, I feel that if I support these two parameters at the same time, users will be confused.  Like me.

More importantly, I feel that if I support these two parameters at the same time, users will be confused. Like me.

I'm not what you were confussing about. Did you think that the splits arguement is for data_files to specific splits?
I think that the situation that someone wants PaddleNLP dataset to train a model then predicts his local dataset is fairly common.

Did you think that the splits arguement is for data_files to specific splits?

yes, before I read source code.

I see... Maybe we should have done more work on documentation. Thanks for bring it. Also thank you for contribution.

You're welcome. Good luck.


[DoNotMerge]Add Redis track2 config

/azp run automation - sdk

Can one of the admins verify this patch?

@00Kai0 does this need review?

Thanks @TimLovellSmith , I will handle it. It's not ready now :)

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@00Kai0 is this PR ready to be reviewed ? It seems some modification of the example is not related with swagger file change in this PR?

Hi @njuCZ ,it's ready to be merged.


"electron-forge start " successfully. but error with "electron-forge make"

When I do the "electron-forge make", the error is following. But, "electron-forge start " successfully.
An unhandled rejection has occurred inside Forge:
RequestError: connect ETIMEDOUT <IP_ADDRESS>:443
at ClientRequest. (/usr/local/lib/node_modules/@electron-forge/cli/node_modules/got/dist/source/core/index.js:970:111)
at Object.onceWrapper (node:events:628:26)
at ClientRequest.emit (node:events:525:35)
at ClientRequest.emit (node:domain:489:12)
at origin.emit (/usr/local/lib/node_modules/@electron-forge/cli/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
at TLSSocket.socketErrorListener (node:_http_client:502:9)
at TLSSocket.emit (node:events:513:28)
at TLSSocket.emit (node:domain:489:12)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)

Hi, try this solution

It seems a network issue.  Thank you


Show episode tests

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   86.93%   86.93%
=======================================
  Files         152      152
  Lines        5794     5794
  Branches      184      184
=======================================
  Hits         5037     5037
  Misses        756      756
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6549be...e1fac4d. Read the comment docs.


HashUtils is not consistent and may be wrong

HashUtil.hash(File) produces hashes that I cannot reproduce with e.g. md5sum / openssl / Guava. Or even HashUtil.hash(byte[]).
I would expect the same result in all test cases (hashes are base64 just for comparing and reading)
// lets try with a file
Path file = Paths.get("hashtest.txt"); // content: "hello world" (without newline)
byte[] raw = Files.readAllBytes(file);
byte[] hash = HashUtil.hash(raw);
String hash64 = Base64.getEncoder().encodeToString(hash);
System.out.println(hash64); // prints XrY7u+Ae7tCTyyK7j1rNww==

// or a simple string
String content = "hello world";
raw = content.getBytes();
hash = HashUtil.hash(raw);
hash64 = Base64.getEncoder().encodeToString(hash);
System.out.println(hash64); // prints XrY7u+Ae7tCTyyK7j1rNww==

// lets try with a file and HashUtil
hash = HashUtil.hash(file.toFile());
hash64 = Base64.getEncoder().encodeToString(hash);
System.out.println(hash64); // ?? prints mPhP1IT4wic/KMxkWTX2UA== ??

# lets see what command line says
# -n prevents new line
$ echo -n "hello world" | openssl dgst -md5 -binary | openssl enc -base64
XrY7u+Ae7tCTyyK7j1rNww==

I was looking into this issue. The problem is that digest.update() is called twice for the same byte buffer because HashUtil and bouncycastle both call update(), which is of course wrong and results in a wrong hash.
I will push my fix later.

implemented fix and added test cases that check hash of given sample data.


multiarch CI build

Confused... the resulting image only has wasm in it... why do we need a multi arch?

you are right, no need for this.


trim sam format readname

https://github.com/bigdatagenomics/adam/issues/2321

Can one of the admins verify this patch?

Thank you for your contribution, @hxdhan.
I don't think we should change how ADAM parses read names across the board, rather for samples with odd names in them, one can simply transform the records before writing
import org.bdgenomics.adam.sql.Alignment

def trimReadName(a: Alignment): Alignment = {
  a.copy(readName = Some( /* ... do something with readName here ... */ ))
}

val transformed = alignments.transformDataset(ds => ds.map(trimReadName(_))


Compile failed in iOS

I have followed the instructions in the docs for infer, and installed infer. In oder to analyse the app i have used the following command:
infer --incremental -- xcodebuild -target xyz -configuration Debug -sdk iphonesimulator
Initially i was getting the @import error in #2 , but now the error is different as described in the screenshot attached. Bt when the app is built in Xcode, the app works fine on simulator and device.
I have the xcworkspace of "xyz" app as pods also is added to the project. Please let me know if there is any other command that can be used to analyse xcworkspace.

Hello @Debhora,
are you using the latest release of Infer available in https://github.com/facebook/infer/releases/latest
Can you please send me the output of infer --version
Thanks!

Hello @martinoluca,
I am using the latest version 1.1. Please find the screensho

t in the attchement

Hi @Debhora,

I have followed the instructions in the docs for infer, and installed infer. In oder to analyse the app i have used the following command:
infer --incremental -- xcodebuild -target xyz -configuration Debug -sdk iphonesimulator

I suspect the problem is related with the fact that in the presence of CocoaPods, you should use the xcworkspace and not the xcodeproj; please try running a command like this (customize according to your project):
xcodebuild -workspace HelloWorld.xcworkspace -scheme HelloWorld

As usual, please make sure the command itself works as expected, then run it with infer --
Let me know if this helps!

@martinoluca I ran into this issue and it was that I needed to use the workspace rather than the project file implicitly

Thank you @matto1990!

Hi @martinoluca,
Yes the above command works. Thank you.

Sadly i'm running into this issue with 0.1.1. xcodebuild works alone, but infer doesn't, and it complains about being unable to compile some pods.
My command is (censoring for NDA reasons)
infer -- xcodebuild -workspace XXXX.xcworkspace -scheme XXXX-Staging-Debug -sdk iphonesimulator
xcode 6.3
cocoapods 0.37.1
infer v0.1.1
What info would be useful to you?

Nowadays very often iOS developers use cocoapods (or similar).
I suggest writing this info in the docs section, because I spent a while searching what I was doing wrong.

I agree with @Ricardo1980. Cocoapods is so used that this should be in the "Hello World" example.

Are you talking about adding this information here: http://fbinfer.com/docs/hello-world.html? It would be easy to add a note in the "Hello world iOS" section.
By the way, there's an entry in the FAQ, but maybe it should be given more visibility: http://fbinfer.com/support.html#infer-cannot-analyze-my-cocoapods-project

Yes, in the Hello world Objective-C section, there could be a warning like:

Warning: If you're using Cocoapods, make sure you read the FAQ.


Responses to requests with reserved correlation IDs don't make it through the proxy

When an RPC request is sent with a reserved correlation ID, the head-unit rejects the request; however, due to the logic in SdlProxyBase.java, the rejected message doesn't make it through the proxy to developer code.  This makes it look as if the request was ignored with no explanation.

The proxy should check the correlation id and reject correlation ids that are set to the reserved values by the developer. Long term the app won't have to worry about correlation id

The new LifecycleManager that replaces SdlProxyBase calls the listener with a clear response message to let the developer know if the app is using a reserved correlation id:
https://github.com/smartdevicelink/sdl_java_suite/blob/715cb541c0034c7660fc152e418243c95ca96bce/base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseLifecycleManager.java#L682


Addrmini

Original pull request here:
Is our master branch out of date? I'm a bit new to all this so please bear with me.
===
Well I guess the first question is what's nLastTry? What benefits does his change has?

Awesome. I think you forgot to post the original description.

I think you forgot to paste the original PR description.
Yeah the master branch is probably out of date, sorry. Let me fix this.
As for discussion, if it's about code snippets you can do comments in the file changes page.

So how is this going to go? Do we go through and ask questions? Or do we
start from the top change?
On Mon, Apr 20, 2015 at 8:10 AM, BitcoinPRReadingGroup <
<EMAIL_ADDRESS>wrote:

I think you forgot to paste the original PR description.
Yeah the master branch is probably out of date, sorry. Let me fix this.
As for discussion, if it's about code snippets you can do comments in the
file changes page.
—
Reply to this email directly or view it on GitHub
https://github.com/BitcoinPRReadingGroup/bitcoin/pull/2#issuecomment-94435669
.

My thought was that people would primarily be "in charge" for their PR, but anyone can ask questions on parts that don't make sense to them. If the owner has a question, feel free to discuss it.
You don't have to discuss all changes.

In that case, I'd like to figure out how to do block exploring. The
different calls, and how they work, etc.
On 4/21/15, BitcoinPRReadingGroup<EMAIL_ADDRESS>wrote:

My thought was that people would primarily be "in charge" for their PR, but
anyone can ask questions on parts that don't make sense to them. If the
owner has a question, feel free to discuss it.
You don't have to discuss all changes.

Reply to this email directly or view it on GitHub:
https://github.com/BitcoinPRReadingGroup/bitcoin/pull/2#issuecomment-94834666

If you could find a PR that pertains to that stuff and push it to this repo, that would be the way to do that in the context of this process.

I'm on mobile so I can't really see a lot of the code, this is mostly guessing.

Well I guess the first question is what's nLastTry

addrman is either the address manager for connected peers or a super hero not unlike aquaman. Looks like nLastTry has to do with prioritising which peers to connect to. If a connection to a peer has already been tried recently, connecting to it again will be deprioritised.

Sounds about right @JornC


Please consider requiring yamlfmt . or similar before recursively rewriting *.yaml

Otherwise it's a little too easy to run it in the wrong directory and not even know what's changed.

Thanks for making an issue!
Yeah, it looks like most other similar formatting tools also do this. I'll join the pack. Sorta sucks that it's a breaking change but we're still in 0.x land anything can happen :laughing:


Artifact Streaming Support

Tell us about your request
Users are asking for support for artifact streaming.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
To enable artifact streaming inside of the Karpenter bootstrapping contract, we need to pass it in as a parameter to the CSE Scripts, and include some additional containerd configuration.
Based on this talk, a simple test validating that pulling sagemathinc/cocalc with a quick timeout should ensure that the image pull is faster and that the feature is working correctly.
The screenshot below should also indicate the types of performance improvements in image pull we can see with the feature enabled.

Enabling artifact streaming has a high cost of additional node bootstrapping latency, so until it is baked into the VHD, we will have it as an alpha field in the AKSNodeClass. Once its baked into the VHD and this cost is gone, we will enable artifact streaming by default.
Are you currently working around this issue?
No available workarounds
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

cc: @ganeshkumarashok


Run demo for custom dataset

I am running the demo with my custom dataset but it always get the pose entries equaling to 0. Also, for the keypoints.py in modules, just change the kpt list and the paf as the image below. my data is pigs with the keypoint defined as 0 for neck, 1 for ear left, 2 for ear right, 3 for neck, 4 for back, and 5 for tail. Can you help me on running the demo with custom dataset? Thank you.

sorry 0 for Nose

Hi! The indices look reasonable for me, did you trained the network on your dataset?

Hi, I did train already. However, when doing the demo, it could not work.

In this case I suggest to check ground truth images and heatmaps and predicted heatmaps for the training data. You can visualize them with OpenCV. Trained model should produce similar predictions to the ground truth data. Are they similar? BTW, there is similar question #42. It has a link to the guide how this code was adapted for custom dataset, it also may help.

Hope, it helped.


controller doesn't send application event logs to the logger

In v1, any call to log_event in models.py would write to the application's logs, which was a hack to get logspout to pick up the log and write it to the application's log file: https://github.com/deis/deis/blob/master/controller/api/models.py#L224-L229
In v2, event logs like bacongobbler created initial release are no longer available via deis logs because the controller doesn't have a way to make fluentd pick these up for the application.

oops, wrong repo


Provide platform dependent JARs with native Menoh libraries

Users should install the native Menoh Core library manually in addition to menoh-java itself. Providing supplemental JARs including the native libraries for each platform (Linux, Mac OS, Windows, ...) seems to be convenient.
Requirements
We need to consider that Menoh Core depends on other native libraries such like the following:

Protocol Buffers
MKL-DNN

MKL-DNN also has several options for linking with other libraries. We should choose one of them as a default and allow users to select an optimized binary for their platform.

standalone or MKLML (a subset of MKL, about 100~150 MB)
Intel or GNU OpenMP (about 2 MB)

Note
JNA will scan the locations to search for Menoh Core, but its transitive dependencies (such like MKL-DNN) should be extracted and placed in LD_LIBRARY_PATH (in Linux) / PATH (in Windows) or the system library paths (configured at /etc/ld.so.conf in Linux) outside the JAR file. We can also load and map them to the JVM process by using NativeLibrary.getInstance() explicitly even if they are placed in the JAR, but it requires to know all library names used by Menoh Core along with the order of loading JARs:
$ objdump -p /usr/local/lib/libmenoh.so
...

Dynamic Section:
  NEEDED               libmkldnn.so.0
  NEEDED               libprotobuf.so.9
  NEEDED               libstdc++.so.6
  NEEDED               libm.so.6
  NEEDED               libgcc_s.so.1
  NEEDED               libc.so.6
  NEEDED               ld-linux-x86-64.so.2
  SONAME               libmenoh.so
  ...

Note2
In Android, the shared libraries (lib<name>.so) should be placed under lib/<abi>/... in APK. See this document for the details.

My colleague noticed that libmenoh.so and libmkldnn.so depends on libstdc++, which may cause compatibility issues depend on the Linux distribution.
$ ldd /usr/local/lib/libmkldnn.so
	linux-vdso.so.1 =>  (0x00007ffdb7d18000)
	libmklml_intel.so => /usr/local/lib/libmklml_intel.so (0x00007f4dfc578000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f4dfc374000)
	libiomp5.so => /usr/local/lib/libiomp5.so (0x00007f4dfbfd0000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f4dfbc4e000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f4dfb945000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f4dfb72f000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f4dfb365000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f4e05def000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f4dfb148000)

Here is some workarounds:

Build them with -D_GLIBCXX_USE_CXX11_ABI=0
Build them with older CentOS environment https://github.com/bytedeco/javacpp-presets/wiki/Build-Environments#linux-x86-and-x86_64

scijava/native-lib-loader, which come from imagej/imagej, seems to be great for its JAR bulk-loading features.

We're discussing how to link protobuf with Menoh statically or dynamically.

Similar issues in ONNX repository:

https://github.com/onnx/onnx/issues/389#issuecomment-354352697
https://github.com/onnx/onnx/issues/1234#issuecomment-411288568

We plan to introduce static linking feature to Menoh core. https://github.com/pfnet-research/menoh/pull/70

Through a lot of trial and error, I found that the most difficult part of this task is ProtoBuf because of its C++ API and some other issue.
Anyway, using old ABI compatible binary and linking libprotobuf statically is a solution for many cases in Linux.
We also need to consider the glibc compatibility. One thing need to consider that CentOS 7 doesn't support gcc 4.9.
$ sudo docker run --rm --privileged -it centos:7 /bin/bash
[root@0845cf58c0a4 /]# yum install gcc-c++ cmake
Dependencies Resolved

================================================================================
 Package              Arch        Version                    Repository    Size
================================================================================
Installing:
 cmake                x86_64      <IP_ADDRESS>-2.el7             base         7.1 M
 gcc-c++              x86_64      4.8.5-28.el7_5.1           updates      7.2 M
Installing for dependencies:
 cpp                  x86_64      4.8.5-28.el7_5.1           updates      5.9 M
 gcc                  x86_64      4.8.5-28.el7_5.1           updates       16 M
 glibc-devel          x86_64      2.17-222.el7               base         1.1 M
 glibc-headers        x86_64      2.17-222.el7               base         678 k
...

snappy-java, a Java port of snappy, uses CentOS 5 and dockcross.

https://github.com/xerial/snappy-java/tree/master/docker

Building on Travis: https://djw8605.github.io/2016/05/03/building-centos-packages-on-travisci/

Summary: MKL-DNN is not able to run on CentOS 5 if it depends on iomp5 (Intel OpenMP runtime).
https://github.com/intel/mkl-dnn/issues/312

Other problem around building libmkldnn myself. Maybe it is not a real issue but strange:

https://github.com/intel/mkl-dnn/issues/313
https://stackoverflow.com/questions/25986091/telling-gcc-to-not-link-libgomp-so-it-links-libiomp5-instead/26149633
https://gitter.im/bytedeco/javacpp?at=5b91588011227d711d258577


[TEST] Improve the backend test framework

What's the test to develop? Please describe
Improve the backend test framework to make it easy for people to add new test cases. Like small and modularized fixtures, etc

Changes
Phase 1: Rework test cases in apis/ by #478
Let API test cases focus on core functionality and could be executed without dependency.
decoupling fixtures

Make a Harvester API library for API calls
Make API test cases require minimal dependency and few fixtures
Make pytest's markers more clear
Move test cases which depends on other functionality into Integration/

Phase 2: Rework test cases in scenarios/
Restructure scenarios into Integration and acceptance test cases, and let integrations could be executed with dependencies configured, without specific environment.
Restructure harvester_e2e_tests

Separate test cases into Integration/ and acceptance (TBD)
Rework test cases with dependencies
Rework fixtures
legacy code clean up

Phase 3: Acceptance test with Robot Framework

TBD

Closing this as the framework has been improved and on going tasks are tracked separately module wise.


M1 Mac, Manim not running properly

I have installed all of the dependencies as per the official documentation, but when I run 'manim' in the terminal I get the following error:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.10/bin/manim", line 5, in
from manim.main import main
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/manim/init.py", line 34, in
from .animation.animation import *
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/manim/animation/animation.py", line 5, in
from ..mobject import mobject, opengl_mobject
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/manim/mobject/mobject.py", line 36, in
from ..utils.color import (
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/manim/utils/color.py", line 28, in
from ..utils.bezier import interpolate
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/manim/utils/bezier.py", line 25, in
from scipy import linalg
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/scipy/init.py", line 153, in
from scipy._lib._ccallback import LowLevelCallable
File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/scipy/_lib/_ccallback.py", line 1, in /'
from . import _ccallback_c
ImportError: dlopen(/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/scipy/_lib/_ccallback_c.cpython-310-darwin.so, 0x0002): tried: '/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/scipy/_lib/_ccallback_c.cpython-310-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e')), '/usr/lib/_ccallback_c.cpython-310-darwin.so' (no such file)

Hello! This most likely seems to be an issue due to the fact you're on Python 3.10, and some of our dependencies aren't yet working with 3.10. Try downgrading to Python 3.9 instead.

Manim should work on Python 3.10 now.


something wrong with configuration while upload the release apk to appgallery store

Description
i follow all the docs from huawei dev. website and from the flutter repo readme , but still i got a rejection for update hms services
i only used this plugin : huawei_Iap, Huawei_account, Huawei_location
with the following pic that's the reject message :

Current behavior
that's all my configration files :
build.gradle
buildscript {
    repositories {
        ..
        maven { url 'https://developer.huawei.com/repo/' }
        ..
    }
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.6.2'
          ...
        classpath 'com.huawei.agconnect:agcp:<IP_ADDRESS>1'
    }
    allprojects {
    repositories {
        ..
        maven { url 'https://developer.huawei.com/repo/' }
        ..
    }
    }

android build.gradle
...
apply plugin: 'com.huawei.agconnect'
...
    defaultConfig {
            resConfigs "ar", "en"
}
...
dependencies {
    implementation 'com.huawei.agconnect:agconnect-core:<IP_ADDRESS>1'
    implementation 'com.huawei.hms:base:<IP_ADDRESS>0'
    implementation 'com.huawei.hms:hwid:<IP_ADDRESS>0'
    implementation 'com.huawei.hms:iap:<IP_ADDRESS>0'
    implementation 'com.huawei.hms:appservice:<IP_ADDRESS>2'
    implementation 'com.huawei.hms:hianalytics:<IP_ADDRESS>1'
    implementation 'com.huawei.hms:location:<IP_ADDRESS>0'
}

proguard-rules.pro
-ignorewarnings
-keepattributes *Annotation*
-keepattributes Exceptions
-keepattributes InnerClasses
-keepattributes Signature
-keepattributes SourceFile,LineNumberTable
-keep class com.huawei.updatesdk.**{*;}
-keep class com.huawei.android.sdk.drm.**{*;}
-keep class com.huawei.agconnect.**{*;}
-keep class com.hianalytics.**{*;}
-keep class com.hianalytics.android.**{*;}
-keep class com.huawei.hms.**{*;}
-keep interface com.huawei.hms.analytics.type.HAEventType{*;}
-keep interface com.huawei.hms.analytics.type.HAParamType{*;}
-keep class com.huawei.hms.analytics.HiAnalyticsInstance{*;}
-keep class com.huawei.hms.analytics.HiAnalytics{*;}
-keepattributes EnclosingMethod

#Flutter Wrapper
-keep class io.flutter.app.** { *; }
-keep class io.flutter.plugin.**  { *; }
-keep class io.flutter.util.**  { *; }
-keep class io.flutter.view.**  { *; }
-keep class io.flutter.**  { *; }
-keep class io.flutter.plugins.**  { *; }
-dontwarn io.flutter.embedding.**
-keep class com.huawei.hms.flutter.** { *; }
-repackageclasses

I added the agconnect-services.json and all build.gradle thats connect agconnect-services.json to the app

i follow all this references

https://developer.huawei.com/consumer/en/doc/development/AppGallery-connect-Guides/appgallerykit-preparation#h1-1574846682104
https://developer.huawei.com/consumer/en/doc/development/AppGallery-connect-Guides/agc-get-started-flutter
https://developer.huawei.com/consumer/en/doc/development/HMSCore-Guides/sdk-data-security-0000001050044906

and till now i got the same reject , So i would be appreciate that , if anyone can help to avoid this kind of rejection

new Update
i passed the automated review by removing my app from China in appGallery
also after the update it gives me this behavior , is that normal

also if we can involve our app with a flutter plugin that solve the CheckUpdate by huawei it will be very kindly

“i passed the automated review by removing my app from China in appGallery
also after the update it gives me this behavior , is that normal”
—This is normal. The application of Chinese mainland must integrate the API: checkUpdate. If the area does not contain Chinese mainland, the system does not require the integration of this API, so it will not report Major level error, so you passed the automated review. And the AppGallery Update is normal too.
“also if we can involve our app with a flutter plugin that solve the CheckUpdate by huawei it will be very kindly”
—Thank you for your feedback. We expect to provide this capability by the end of February

@mustafa-707
“i passed the automated review by removing my app from China in appGallery
also after the update it gives me this behavior , is that normal”
—This is normal. The application of Chinese mainland must integrate the API: checkUpdate. If the area does not contain Chinese mainland, the system does not require the integration of this API, so it will not report Major level error, so you passed the automated review. And the AppGallery Update is normal too.
“also if we can involve our app with a flutter plugin that solve the CheckUpdate by huawei it will be very kindly”
—Thank you for your feedback. We expect to provide this capability by the end of February

Thank you @Mayism , we will wait to provide our apps with this amazing services , i would ask again if you don't mind , is this capability it will be as flutter plugin and it will makes us to contain Chinese mainland ?
Regarded Thanks

@mustafa-707 Thank you for your understanding and patience. In the flutter plugin, we will provide the capability of checkupdate,too. However, if you want to release your app in Chinese Mainland, you must integrate the checkupdate interface.This is the same as that in the Android SDK.

@mustafa-707 Sorry, the flutter plugin that support checkupdate is still under development. If the development is complete, I will reopen this issue and inform you as soon as possible.


Remove hypervisor and ram nodes from Dom0 snippet

Snippets are applied at the end of device tree generation which makes impossible to edit some values by application. Thus, we need to remove hypervisor and ram nodes from them, to allow application set correct regions.
UPD: CI fails due to long commit topics, that contain subsystem tag and board names.

Acked-by: Mykola Kvach<EMAIL_ADDRESS>

pls, fix chepach errors:

 Commit a45c2d7da4:
1: UC5 Commit title exceeds max length (80>75): "snippets: xen_dom0: qemu_cortex_a53: remove RAM and hypervisor node modification"

Commit 872deae700:
1: UC5 Commit title exceeds max length (76>75): "snippets: xen_dom0: spider_ca55: remove RAM and hypervisor node modification"

Commit 2ae233b61a:
1: UC5 Commit title exceeds max length (79>75): "snippets: xen_dom0: salvator_xs_m3: remove RAM and hypervisor node modification"
Error: Process completed with exit code 1.

Minor, up to you - i see no reasons for 4 separate patches for boards.
Reviewed-by: Grygorii Strashko<EMAIL_ADDRESS>

Thanks for review

pls, fix chepach errors:

I tried to make it the most descriptive with all topic tags and explanation, IIRC it is allowed, but I didn't find any proves of this. Reworded.

Acked-by: Mykola Kvach<EMAIL_ADDRESS>
I used your corporate email for tag, correct me if I'm wrong

Stop. snippet.yml need to be update. remove EXTRA_DTC_OVERLAY_FILE

Also in xen_dom0.overlay -- below is platform specific, so need to be removed also. I think.
    #address-cells = <2>;
	#size-cells = <2>;


Try to reduce compile time of tests

Removes undesirable link_libraries() from CMake.

Analyzing the build time
I am using two measurements:

Time that each target takes to be built. I use the Ninja build system, so I have a report of the build times in the file .ninja_log.
Clang time tracer. I use clang++ with the compiler flag -ftime-trace, which collects more detailed information about build times in one .json per build target.

There is a lot of information in the .json files, so it is interesting to use another software to extract the information we want. You can open each file in the Google Chrome tracing tool. I didn't like the way the results are displayed, and having multiple .json files make it harder to analyze. So, I found a nice tool that does the job: https://github.com/aras-p/ClangBuildAnalyzer.
First attempt: replace TEMPLATE_TEST_CASE by TEMPLATE_LIST_TEST_CASE.

This change solely does not seem to affect the build time.
I did noticed a slightly modification in the test executable, but it is something really small. I don't think it is worth doing the change just because of that.

Second attempt: Declare templates classes explicitly
This change does reduce the build time of the targets. Basically, b5c6007 explicitly declares the matrix types we use for the tests, and then those matrices do not need to be instantiated for each build target. They are instantiated in the testutils library.

I don't fully understand how this works. But i am definitely in favor of its goals.

On a related note. Is it worth doing some caching in the ci? I see that a lot of time is spent reinstalling the necessary libraries each time.

Thanks! Yes, there is a page about that: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows
I looked into it a while ago, and I think this was indeed possible in our case. I will have another look.

I tried to do some caching, as suggested, using cache-apt-pkgs-action. It didn't work great. I found a problem:
 22:10:50.712   * Caching intel-oneapi-icc-eclipse-plugin-cpp-2023.2.1 to /home/runner/cache-apt-pkgs/intel-oneapi-icc-eclipse-plugin-cpp-2023.2.1=2023.2.1-16.tar...
tar: Cowardly refusing to create an empty archive

I will let the caching for another PR.


Add useWinUI3 and experimentalFeatures config

This PR adds documentation for the useWinUI3 RN config flag introduced in https://github.com/microsoft/react-native-windows/pull/7060 and the experimentalFeatures object added in https://github.com/microsoft/react-native-windows/pull/8402
Microsoft Reviewers: Open in CodeFlow

Looks good. We may want to wait until we cut 0.65 versioned docs to merge this.

Well, the useWinUI3 is already in 0.65 and I'm trying to get experimentalFeatures backported to 0.65 as well: https://github.com/microsoft/react-native-windows/pull/8428
But yes, I will make sure that however things land that the docs are correct.


Guess default DataSource if only one DataSource is available

Just like Cayenne and other DB-aware frameworks, LB should be using the "default" data source , if none is specified.

Fixed per PR #13


Share dockerize command between cadence-server and cadence-auto-setup Dockerfile targets

Both Dockerfile and docker/start.sh were executing the same dockerize command. This change makes it so both places call the same script.
This also makes it easier to wrap this startup script when overriding CMD with docker run. In my case, due to how my Kubernetes infrastructure is set up, I cannot pass database credentials in as environment variables, which is how the dockerize command expects them. Database credentials are only available via files that get mounted at runtime, so I need to wrap the startup script with something that grabs those credentials from a file and sets them as environment variables.
I'm not hip to all the coolest Docker idioms and tricks. Please check me on this.

Coverage decreased (-0.02%) to 66.786% when pulling ec5c1110f4a9bf4bae08e3d121fa911a8dab1df2 on barakalon:docker-start-command-dry into f8bf786f26054ce8c4e14f74706b73805a194836 on uber:master.


removing forge test

Motivation
removing forge test from ci-test and ci post-land

/canary

:boom: Tests timed-out

/canary

:broken_heart: Test Failed - ci-test


Dynamically-created iframe not loading properly in Firefox

What is your Scenario?
A test loads a page that dynamically inserts an iframe. element and loads that content. The iframe fails to load.
What is the Current behavior?
In Firefox, the iframe does not load at all (in any version of TestCafe that I have tried; 1.x, 2.x, 3.x).
Note that there's an error about querySelectorAll in the console.  In the provided sample, the main.ts file simply imports Highcharts (a popular charting library: https://www.highcharts.com/) and that's enough to cause the issue. I don't have the source so I can't whittle it down further.
What is the Expected behavior?
Simple test at https://github.com/drrnkin/testcafe-iframe should pass. The test should detect the content in the iframe that is dynamically created by a script in the iframe. The test does not pass in Firefox in any version of TestCafe.
Expected: test should pass in Firefox and all other supported browsers.
What is your public website URL? (or attach your complete example)
https://github.com/drrnkin/testcafe-iframe
What is your TestCafe test code?
See provided repo
Your complete configuration file
See provided repo
Your complete test report
No response
Screenshots
No response
Steps to Reproduce

Clone the repo https://github.com/drrnkin/testcafe-iframe
yarn
yarn build
yarn test-firefox

TestCafe version
3.3.0
Node.js version
v16.20.2
Command-line arguments
See Steps to Reproduce
Browser name(s) and version(s)
Firefox 116.0.3 (currently latest
Platform(s) and version(s)
Windows 10
Other
Split from #7983 .  This one is specific to Firefox.

Commenting to remove stale state

This is still an issue with same steps.

This is a rare, low-priority use case, and a possible fix would be quite complex. As a workaround, please use Chrome for this case.


[Suggestion] Select default terminal

For example to startup in Windows Terminal instead of default cmd conhost.

Is this possible?

I've analyzed WT again and now starting to realize this is not possible 🤔

I think too it is difficult...
Please let me know if there is any good way.

I'll work for this.

Added terminal selector in latest release.
https://github.com/yuk7/wsldl/releases/latest
Arch.exe config --default-terminal wt for set default terminal to "Windows Terminal".

Wow. You're the best dev I've ever met 👍


Add support custom type Nullfloat64

fix #1256

Codecov Report

Merging #1450 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
+ Coverage   56.95%   56.97%   +0.02%
==========================================
  Files          48       48
  Lines        8200     8205       +5
==========================================
+ Hits         4670     4675       +5
  Misses       2915     2915
  Partials      615      615

Impacted Files
Coverage Δ

session_convert.go
23.1% <100%> (+0.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4857995...c4693ab. Read the comment docs.


add when method

add a method in Telegraph for if true run & if false don't run
like when function in Elquent Laravel

@fabio-ivona
i test it & it is wrked in all method
& i trying to add to Keybord...

how it work in keyboards:

Thanks, this is a great improvement!
I'll review this as soon as I come back from vacation (on 22nd of August)
Meanwhile, would you mind to add tests for this feature?

I am not very familiar with the tests section

please add Conditional methods docs in
https://def-studio.github.io/telegraph/features/reply-keyboards
you just add in inline keyboard @fabio-ivona

done


OAK-8494 - Support AWS Key Managed Service (SSE-KMS)

OAK-8494 - Support AWS Key Managed Service (SSE-KMS)

Closing