feat: charge intrinsic gas

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Resolves: #642
What is the new behavior?

Created CheckedMath from CheckedAdd, CheckedSub traits - basically, using a trick I did the equivalent of CheckedMath: CheckedAdd + CheckedSub
Charged intrinsic tx gas cost

Does this introduce a breaking change?

[ ] Yes
[ ] No

This change is

@enitrat , LGTM, just need to rebase!


% tag match not working

In neovim pressing % with the cursor on an html tag takes you to the opposite tag. This works out of the box. This is not working in vscode.
neovim version: 0.5.0
vscode-neovim version: 0.0.63

@userbal It seems to work now!
In case it doesn't work for you still, try adding this to your init.vim:
runtime macros/matchit.vim
@asvetliakov This can probably be closed

Yep, things like this are not handled by the extension, it's usually a vimrc issue. Also, check out https://github.com/andymass/vim-matchup, it's pretty sweet!


Listing objects of S3 bucket

Even if S3 buckets have a flat structure, they still support the folder concept to make organization easier, but when listing the objects within an S3 bucket using the obstore package, the returned list does not clearly differentiate between files and directories.
For example, the following code:
s3store = S3Store.from_url(....) // include needed parameters
stream = obs.list(s3store, chunk_size=10)
for results in stream:
    print(results)

will return the following:
 [{'path': 'folder', 'last_modified': datetime.datetime(2024, 10, 22, 11, 15, 25, tzinfo=datetime.timezone.utc), 'size': 0, 'e_tag': '"123456789"', 'version': None}, {'path': 'file.txt', 'last_modified': datetime.datetime(2024, 11, 18, 18, 47, 45, tzinfo=datetime.timezone.utc), 'size': 0, 'e_tag': '"987654321"', 'version': None}]

As directories within S3 buckets are allowed to include a . in their names, it makes it impossible to differentiate between directories and files (a folder in S3 will always be an object of size 0 as it only mimics a directory, but so will an empty file).
Typically, directories have a trailing slash to differentiate them from other objects (note the red box marked important in their docs here), but this seems to have been removed in the obstore listing.
Is there any other way that directories are supposed to be differentiated? Or is this something that can be fixed?
Thank you!

You can use list_with_delimiter to list files within a prefix. Does that answer your question?

Thanks for your quick reply!
So, the only way to check if an object is a directory is to use the list_with_delimiter function and check if it exists within the common prefixes? I was using the list functionality as it has support for Arrow lists for larger results, but I see that is not possible with the list_with_delimiter function.
When using the list_with_delimiter function, the common prefixes returned only include directories that are not empty, so empty directories do not appear as common prefixes - I just tried it locally. Is this the expected behaviour?

obstore is a direct wrapper of the underlying object_store rust crate. I'm not entirely sure about some of these specifics of how the underlying crate works.

You might want to make an issue or ask in the discord of the arrow-rs project, which also manages object_store crate.

I asked on discord here: https://discord.com/channels/885562378132000778/885562378132000781/1310704559727054918


[WIP] Added check for existence of Location HTTP header before using it

PR Summary
Fix #6543
The HTTP RFC does not require a Location header to be present for redirects, thus it is required to check if the Location header is returned before using it. This pull request adds a check for the Location header.
A test for the fix seems to be a bit more difficult as WebListener always returns a Location header and needs to be extended.
PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Change is not breaking
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[X] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

I changed the status code to int and are using -Match now isntead of -Be for checking the Exception message. The reason is, that the Exception Message contains the Status Code with a space, e.g. Temporary Redirect and not TemporaryRedirect which is provided in $redirectTests.
The tests are still failing because $redirectTests contains an entry relative which is not a valid Status Code. I'm not sure how to handle this. In my opinion it would be better to not include relative in the list of $redirectTests or at least separate it into Status Codes to test for redirect and an additional relative redirect test.

@ffeldhaus for the relative issue, you could do
# Skip relative test as it is not a valid response type.
if ($redirectType -eq 'relative'){ return }

For the error message. I'm not certain we should even test it. Ideally, that message would be localized so it would fail in another language. I think the other tests are sufficient to show we are getting the error condition we desire and not the unrelated one.

@markekraus Thanks for all the help! I'm a bit annoyed at myself for doing quite a few mistakes in such an easy fix and that you basically had to tell me what to do. For the next time, I hope I'm now better equipped to make a change.
I think the pull request should be good to merge now.

LGTM

@ffeldhaus Thanks for your contribution! Welcome back with new ones!


report-issue: Add report issue UX using send-feedback electron element.

What's this PR do?
This uses @electron-elements/send-feedback package to easily implementUX for reporting issues.
Screenshots?

One problem here could be that send-feedback module uses promisify which has been introduced in node v8.0.0 but currently we have downgraded to node6 in this 028bc02, this could break the app.

@abhigyank that's not a problem electron uses its own internal embedded node version which should be greater than node 7 since electron v1.8.0 and we are currently on v1.8.2 in here I think.

I think we need to clear the contents once the feedback is sent.


Added changes to support and enable installation of SODA on Ubuntu20.04

What type of PR is this?
/kind new feature
What this PR does / why we need it:
This PR enables installation of SODA on Ubuntu 20.04.

Python2 is deprecated in Ubuntu20.04 and not available. All python-pip installations are upgraded to python3-pip
All scripts running python2 scripts are now executed with python3
Ansible version is updated to 2.9.6 (The default supported version for the ceph-ansible version supported)
Changed the ansible variable syntax to updated syntax for Ansible 2.9. Changed usage of single and double quotes.
install_as_systemd is set to false. Bring api, controller and dock as standalone processes.
Added an other variable called install_etcd_as_systemd and set it to false. etcd is also brought up as a standalone process.
Updated the CI to work on the ubuntu2004-experimental branch.
Removed the CI check for install from repository. Currently on install from release is tested with Ubuntu20.04

Which issue(s) this PR fixes:
Fixes #485
Test Report Added?:
/kind TESTED
Test Report:
Tested on Ubuntu 20.04 on Virtual Box.
Special notes for your reviewer:
There are some issues with the Anisble installation and etcd service running as a systemd process. Sometimes the process takes too much time to come up. This needs to be debugged and may be the etcd version needs to be updated.

This PR seems to handle two different features (Ubuntu 20.04 support and Python 2 removal). Can we handle it in separate PRs, so that user can explore all existing features in Ubuntu 20.04?
Ubutnu 20.04 may not have python 2, but there seems to be, successfull to install methods (Please check: https://linuxconfig.org/install-python-2-on-ubuntu-20-04-focal-fossa-linux)

This PR seems to handle two different features (Ubuntu 20.04 support and Python 2 removal). Can we handle it in separate PRs, so that user can explore all existing features in Ubuntu 20.04?

Python2 removal is due to the Ansible version upgrade to 2.9.6. They can be separated but there are many dependencies that need to be checked when we install Python2 on ubuntu20.04.
Let me check if I can separate the PRs.

Ubutnu 20.04 may not have python 2, but there seems to be steps available to install it (Please check: https://linuxconfig.org/install-python-2-on-ubuntu-20-04-focal-fossa-linux)

Yes. I will check this link and try out the installation.


Confused about hole sizes in base and cover

I'm confused about the hole sizes in the base and cover.  The base holes are significantly smaller than the 4 mount holes in the cover.  As the bolt/screw needs to go through the base into the cover, how is this supposed to work?
Thanks for any help.  In the mean time I will use a feature in my slicer to fill in the cover holes and replace with smaller diameter holes.

That is because the large holes are designed to host brass inserts. Please see the BOM. Thanks!

Thank you for resolving my confusion.   Apologies, I looked around for a BOM but didn't see one listing the brass inserts.   Is it inside the FreeCad files or KiCad files somewhere?

OK, I forgot to list that in the BOM. Sorry.

Fixed in this commit. Thanks!


Feature Request Notification When NFT sold

Is your feature request related to a problem?
No problems found, maybe this leads to progress.. because basically I or someone will always be curious when I want to see if the NFT is sold or still alive.
just when you want to check you have to go into your profile and have to wait a while for everything to be visible, maybe this is because the UI is heavy so it takes time to refresh the page.
Describe the solution you would like
I want KodaDot to add additional Notifications in the future
Describe alternatives you have considered
Showing notification NFT has been sold, maybe in some kind of notification/update tab like telegram bot, or you can add a bell icon in the UI on the bottom bar of Transform.
maybe it sounds really cool if this materializes

Screeenshots
Paste your vision

I guess you can better describe the steps for the first iteration and someone could pick it up.
Feel free to pick inspiration we've dropped in past.

https://github.com/kodadot/nft-gallery/issues/1285
https://github.com/kodadot/nft-gallery/issues/321
https://github.com/kodadot/nft-gallery/issues/571

#4890


Add config to set initial volume level

@Alphare There is a problem in your pull request with the audio volume it makes the player crazy fast skipping songs. I'm gonna fix it.


Refactor test to check the PostCSS version

PostCSS 8.2 has been released, so using String.prototype.startsWith() throws an error.
This PR resolves the problem.
Reference
https://github.com/postcss/postcss/releases/tag/8.2.0

Can you also update src/components/CssWebpackConfig.js while you're at it?

Thanks for this!


New rule jsx-ban-props prohibit specific prop names

Similar to the tslint react propose forbid-prop-types. Allows prohibiting of props in JSX with an optional explanatory message in the reported failure.
Example: block the use of styles, we do not want to allow the use of inline styles. There are a few edge cases where this might be suitable and we will disable the rule in those specific edge cases.
Configuration:
{
  "jsx-ban-props": [true, ["style", "use className and css"]],
}

Error
return (

)

Allowed
return (

)

Maybe this rule: forbid-dom-props. It does not allow you to customize the error message though.

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-component-props.md already exists.


Update MD file on new branch 2017-11-16_05-27-20

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Get first entity & camera working

I think I'm missing something obvious... but so far, I'm unable to get an entity (say, a Box) and camera working.
Here's what I'm trying:
const world = new World({
  plugins: [ThreePlugin],
  systems: [],
  components: [],
});

world.presentation.setViewport(document.body);

// Create an entity
const entity = world.entities
  .create()
  .add(Transform)
  .add(Shape, {
    kind: "BOX",
    boxSize: new Vector3(1, 1, 1),
    color: "purple",
  })
  .activate();

// Create the singleton camera
const camera = world.entities
  .create()
  .add(Transform, {
    position: new Vector3(0, 100, 0),
  })
  .add(LookAt, {
    entity: entity.id,
    limit: "Y_AXIS",
  })
  .add(Camera)
  .activate();

const gameLoop = () => {
  world.update();
  requestAnimationFrame(gameLoop);
};

gameLoop();

When I inspect world.presentation.scene.children, I only see two light sources. My entity doesn't appear to be part of the scene hierarchy.

Has the way this works changed? (From the docs:)

All entities with a Transform are given an Object3D component which will be displayed in the scene in the correct hierarchical position. This container is used internally for all Model and Shape meshes that are created.

What you have looks correct to me but I found a minor issue. You also need to include CorePlugin in your plugin dependencies like this:
import ThreePlugin from 'hecs-plugin-three'
import CorePlugin from 'hecs-plugin-core'

const world = new World({
  plugins: [CorePlugin, ThreePlugin],
  systems: [],
  components: [],
});

I've actually gone and updated hecs-plugin-three and hecs-plugin-physx to automatically pull in hecs-plugin-core so if you just update from 0.14.0 to 0.16.0 your code above should work without any changes.
I also put together a working example here so it's easy to jump in and play around:
https://codesandbox.io/s/hecs-example-1-r1k67?file=/src/App.js
Hope this helps!

There's also something odd happening when you use a LookAt with a Camera. I haven't needed to use this yet so only just noticed.
The LookAt works correctly for all entity combinations except ones with a Camera on it. The rotation is somehow inverted. I've added an example and comments here: https://codesandbox.io/s/hecs-look-at-issue-4gqgd?file=/src/App.js
I do wonder if this is maybe how Three.js cameras work, the direction normal might be inverted.

That was it! The camera wasn't facing the entity.

I do wonder if this is maybe how Three.js cameras work, the direction normal might be inverted.

Looks like your intuition was correct: https://github.com/mrdoob/three.js/issues/13753#issuecomment-378462743

I've added a PR for this at #10

Nice find!


Add support for replication metrics in mysql

Description
Add support for replication metrics in MySQL, and ensure they are supported in 5.7.
How has this been tested?
Checklist:

Unit tests

[ ] Unit tests do not apply.
[x] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[x] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[x] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

There appears to be a Cassandra integration test issue at the moment affecting debian third party apps tests, but the MySQL tests are all passing and validating replication support for both 5.7 and 8.0+


Scrolling with physical mouse is super slow on Android

When i'm using keyboard and mouse in flutter android app, i found below issue.

Keyboard Backspace is not working when Num Lock is ON
move scroll by mouse it's smooth
i'm using Logitec Keyboard and mouse fo this test.

Same scenario is working fine in windows desktop
Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.19043.928], locale en-US)
• Flutter version 2.2.0 at D:\SW\flutter_windows_2.2.0-stable\flutter
• Framework revision b22742018b (5 days ago), 2021-05-14 19:12:57 -0700
• Engine revision a9d88a4d18
• Dart version 2.13.0

Hi @selvam920
Thanks for filing the issue.
I can reproduce the  keyboard issue
Preview

stab;e & beta
dev & master

Reproduced the issue using the following minimal code sample

minimal code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: TextField(),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

This seems to be too fixed on the dev and master
Reproduced on the following channels

stable
beta
dev
master

✅
✅
❌
❌

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.2.0 at C:\Users\Taha\Code\flutter_stable
    • Framework revision b22742018b (6 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java.exe
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • def0ad20 • android-arm64  • Android 10 (API 29)
    • Windows (desktop)      • windows  • windows-x64    • Microsoft Windows [Version 10.0.19042.985]
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)             • edge     • web-javascript • Microsoft Edge 90.0.818.56

! Doctor found issues in 1 category.

[✓] Flutter (Channel beta, 2.2.0, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.2.0 at C:\Users\Taha\Code\flutter_beta
    • Framework revision b22742018b (6 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java.exe
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • def0ad20 • android-arm64  • Android 10 (API 29)
    • Windows (desktop)      • windows  • windows-x64    • Microsoft Windows [Version 10.0.19042.985]
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)             • edge     • web-javascript • Microsoft Edge 90.0.818.56

! Doctor found issues in 1 category.

[✓] Flutter (Channel dev, 2.3.0-12.1.pre, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.3.0-12.1.pre at C:\Users\Taha\Code\flutter_dev
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f9c825981c (2 days ago), 2021-05-18 14:07:52 -0700
    • Engine revision 26e217e6c3
    • Dart version 2.14.0 (build 2.14.0-edge.a527411e5100a0a4f48c4009087a1b988aa784af)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (5 available)
    • Redmi K20 Pro (mobile)  • def0ad20 • android-arm64   • Android 10 (API 29)
    • Windows (desktop)       • windows  • windows-x64     • Microsoft Windows [Version 10.0.19042.985]
    • Windows (UWP) (desktop) • winuwp   • windows-uwp-x64 •
    • Chrome (web)            • chrome   • web-javascript  • Google Chrome 90.0.4430.212
    • Edge (web)              • edge     • web-javascript  • Microsoft Edge 90.0.818.56

• No issues found!

[✓] Flutter (Channel master, 2.3.0-13.0.pre.59, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.3.0-13.0.pre.59 at C:\Users\Taha\Code\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1e35f4c0c6 (8 hours ago), 2021-05-20 03:14:01 -0400
    • Engine revision 67c537d41b
    • Dart version 2.14.0 (build 2.14.0-129.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (5 available)
    • Redmi K20 Pro (mobile)  • def0ad20 • android-arm64   • Android 10 (API 29)
    • Windows (desktop)       • windows  • windows-x64     • Microsoft Windows [Version 10.0.19042.985]
    • Windows (UWP) (desktop) • winuwp   • windows-uwp-x64 •
    • Chrome (web)            • chrome   • web-javascript  • Google Chrome 90.0.4430.212
    • Edge (web)              • edge     • web-javascript  • Microsoft Edge 90.0.818.56

• No issues found!

✅ : Reproducible ❌: Not Reproducible
but I am not sure what's the mouse issue you're describing, please explain the mouse issue

The mouse is like scroll mouse wheel or hold left mouse and move up and down then the page is not moving smooth, looks like stuck in between

Hi @selvam920
Thanks for the details
The keyboard issue looks like a duplicate of https://github.com/flutter/flutter/issues/78769
I can now also reproduce the mouse
No matter how fast I scroll, scrolling is slow  as snail on Android when using Bluetooth mouse
Reproduced on the following channels

channel
result

stable
reproduced

master
doesn't reproduced

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.2.0 at C:\Users\Taha\Code\flutter_stable
    • Framework revision b22742018b (6 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java.exe
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • def0ad20 • android-arm64  • Android 10 (API 29)
    • Windows (desktop)      • windows  • windows-x64    • Microsoft Windows [Version 10.0.19042.985]
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)             • edge     • web-javascript • Microsoft Edge 90.0.818.56

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.3.0-13.0.pre.87, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.3.0-13.0.pre.87 at C:\Users\Taha\Code\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d6a925326 (4 hours ago), 2021-05-21 01:09:02 -0400
    • Engine revision 20260fb95f
    • Dart version 2.14.0 (build 2.14.0-134.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (5 available)
    • Redmi K20 Pro (mobile)  • def0ad20 • android-arm64   • Android 10 (API 29)
    • Windows (desktop)       • windows  • windows-x64     • Microsoft Windows [Version 10.0.19042.985]
    • Windows (UWP) (desktop) • winuwp   • windows-uwp-x64 •
    • Chrome (web)            • chrome   • web-javascript  • Google Chrome 90.0.4430.212
    • Edge (web)              • edge     • web-javascript  • Microsoft Edge 90.0.818.56

This may be a case of scroll wheel deltas not wired up correctly. Perhaps not taking into account DPI scaling? cc @gspencergoog

This issue not only android phone found in android tv, chromebook also

Tag P4 added this issue, when will it be fixed?

Any update? This issue is still reproduced at 3.3.0-0.1pre.

Would be great if this issue and #107400 would get some attention, because now Flutter apps are barely usable on Chrome OS devices.

Any update in this issue?

any update on this?

Is there some sort of workaround we could use to fix this for all lists across the app?
We could probably manually listen to the mouse wheel and drive the scroll controller ourselves, but we would need to do that manually for every list in the app. Maybe there is a more straightforward way?

Code that could be relevent https://github.com/flutter/engine/blob/d7375ebfc6a88ac0e56f12e61d6320694b2ef128/shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java#L337

still waiting for this issue

anyone working for this issue?

I recently had a report about our app not supporting proper scrolling with Bluetooth mice.  Our app is multi-platform on Windows, Android, ioS, Mac, Linux.  I borrowed a BT mouse for testing.  I can confirm that Bluetooth mouse support works with our desktop app but with virtually the same code on android, it has the same issue reported here:  very slow scroll wheel scrolling problem.  I would imagine this was forgotten for Android because it was assumed that the user would use the touch features.  However, people connect BT keyboards and mice to tablets all of the time.  Our app also supports a desktop mode while rotated in landscape android.
We have over 2000 active devices for Android:
Android App  https://play.google.com/store/apps/details?id=com.paauk.tipitakapalireader
Windows App  https://apps.microsoft.com/store/detail/tipitaka-pali-reader/9MTH9TD82TGR?hl=en-us&gl=us
Furthermore, to be sure it was a flutter problem I downloaded syncfusion (flutter gallery app) and went to the pdf reader sample.  This android bt mouse scroll problem also existed.   It is therefore a flutter framework problem.
https://play.google.com/store/apps/details?id=com.syncfusion.flutter.examples

Seems no one is working with this bug, this bug was created two years ago

This bug did not close from when i created

I think you have the power to close.  and you have the power to create.  The focus of the bug seemed to be diverted to keyboard.  I'd close it .. then make a new bug report .  If you have the minimum app, then you can explain.. plus you can reference 3 other apps.  Your own, mine, and syncfusion.  Furthermore, syncfusion and TPR are available on the store.  Furthermore, I can confirm that scrolling does work on windows desktop.  Lastly, there are 2000 android devices using our TPR app and we have stated a better reason why it is need.
Close the issue.. and then make a new one.   share the link when you do.

I'd keep this open, it has 15 upvotes which is a core metric the Flutter team uses to determine priority. I know this issue is already on the Flutter teams radar as well.  If anything just update the OP to be more clear/specific

We do look at comments on existing bugs, and filing a new identical bug will not get a different prioritization. I'm sorry this hasn't risen to the top of our queue: there are a lot of other issues to attend to.
I'm reopening this because it has a lot of context that would be lost in a new issue (including recent comments).

Is there any use to reopen this bug? Bcoz this bug we waited almost 2 years

Yes, in includes investigative work that we won't have to do again when we get to fixing it. It has a reproduction steps and verification, as well as upvotes that will help it get to the top of the queue. There's plenty of reason to keep it open.

okay.. looks like we got some attention.  I hope my information helped.  Furthermore, Flutter was quite new then.  I would imagine this is one of the issues they would like to solve at this point and tablet as a computer is more common now too.  Desktops were in beta back then.  I hope we can test a fix for this soon.

Let's see still how many years needs to wait

any update?

you would need to test and let me know.. However, we did add keyboard scrolling.  You can see if that works on android.
pageup and pagedown and updown arrows work on desktop.

Are you talking about android or desktop?

You are talking about android.. therefore I'm also saying.. hey you can try testing.  I don't have the ability to test without asking for equipment from another monk.  If you report back your findings with your own equipment based on android.

Update I found a solution to this and am working on the unit tests now. It did however expose that flutter takes a few seconds longer than android to register mouse input. I may need to file a different issue to track that work.

@reidbaker Wow, it's great working on master channel


Update with bflw 2.12.0b0 for testing

2x speed improvement!

Coverage decreased (-0.02%) to 94.334% when pulling dde4f867f3a645faa31120c47d397a370c43caec on task/bflw-2.12.0b-refactor into 707a81990d1c51d64e964c781c5e700fe58646de on master.

Coverage decreased (-0.02%) to 94.334% when pulling dde4f867f3a645faa31120c47d397a370c43caec on task/bflw-2.12.0b-refactor into 707a81990d1c51d64e964c781c5e700fe58646de on master.


Ignore unnecessary files when bundling packages

Reason:
Unnecessary files (such as source, test, and config files) are being bundled and published. This inflates the package size and potentially allows for consumers to abuse the package's intended contract. In the case of the chainwebjs package the compressed size has been reduced from ~25 MB to 35 KB.
Note:

Duplication of .npmignore appears to be necessary because it is non-extendable and unable to be rigged with Heft.
A global .npmignore may be possible after investigation into why the prepack and postpack scripts are not triggered by rush publish, however this is contrary to Rush's principle of project isolation.
The few existing .npmignore configs had no impact and were identical to the template.

Closes #183
References:

https://github.com/microsoft/rushstack/issues/2618#issuecomment-823467076
Sharing Configuration Using Rig Packages
Rush Stack .npmignore template

Validate

Run rush build.
Run rush publish --pack --include-all --publish to package each project into a tarball (note: when --pack is specified the packages will not be published to the NPM registry).
Validate the contents of each tarball in common/temp/artifacts/packages.

Changes:

Add an entry to .gitignore to ignore IntelliJ Platform files.
Add an .npmignore file to each of the following packages:

libs/:

bootstrap-lib
chainweb-node-client
chainwebjs
client
cryptography-utils
kadena.js
pactjs
pactjs-generator
pactjs-test-project
react-components
types

tools/:

pactjs-cli

Checks:

[x] I have reviewed my changes and run the appropriate tests.
[x] I have have run rush change to add the appropriate change logs.
[x] I have added/edited docs.
[ ] I have added tutorials.
[x] I have double checked and DEFINITELY added docs.

Thanks for this @lukeribchester! Unfortunately the build fails, could you rebase on master to see if that fixes it?


jsonb_set for document update?

Hi,
I am wondering is there is plan to make use of Postgresql 9.5's jsonb_set to finally have document update that doesn't overwrite.
I cooked up something quick here, https://github.com/seymores/massive-js/blob/master/lib/document_table.js#L58
The obvious problems that I can see are:

Depends on Postgresql 9.5's jsonb_set
Column must be jsonb type

I'm all for the feature itself, and the problems don't sound that bad -- updateDoc is a new function so anyone running < 9.5 can just keep going with saveDoc, and jsonb is better for storage anyway. Can you add some tests and submit a pull request?
Also you're pulling args[pkName] out into plVal and not doing anything with it, so you might want to check that out.

Happy to write the tests and do the PR.
I tried running the tests on my local but am stuck at
    Document updates
       1) "before all" hook
       ...
      Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

I have created the test database to match "postgres://rob:password@localhost/massive" and tested to work fine using psql.
Any idea? :-(

Did you set the conn string in the test/helpers/index.js file?
https://github.com/robconery/massive-js/blob/master/test/helpers/index.js
And, did you add rob as a user, with the password password?

Thanks.
Turned out the 'rob' account doesn't have admin permission to create extension.
  'permission denied to create extension "pgcrypto"'

@dmfay
Completed a working and test backed updateDoc, see https://github.com/seymores/massive-js/blob/master/lib/document_table.js#L58
and the test spec here https://github.com/seymores/massive-js/blob/master/test/document_update_spec.js
However I come to think that the function name 'updateDoc' is not appropriate because it can only update one attribute at a time, limitation of jsonb_set .
I am thinking of renaming the function to updateDocAttribute but just want to run by you if you think the name is better than updateDoc.

oh cool! What about setAttribute for the name? It's more concise but still gets the point across.

Done.
Creating a PR shortly.
:-)


Print command name before execution

To help read the cause when lefthook hangs indefinitely.
Tested. With parallel: true results are very messy.

Hey! Let me help you investigate the problems with hangs. Could you provide your lefthook.yml that hangs? Maybe I can help you solve this problem.
As you noticed, with parallel: true results can be very messy. I believe we can solve this problem the other way.

@mrexox here is it https://gitlab.com/gitlab-org/gitlab/-/blob/master/lefthook.yml

Hey @abitrolly, I've tried to experiment on my private cloned repo with all the checks in lefthook.yml, but they didn't hang for me. Could you provide a PR (or MR if it is GitLab) for which lefthook hangs? You can use LEFTHOOK=0 git push to disable lefthook execution on git push.

@mrerox I am using Gitpod to run GitLab. Maybe it doesn't have the same performance, and the jobs just take a lot of time to complete. In any case waiting for more than 5 minutes in a terminal without any glue about what is going on is not a good user experience. I could skip certain tasks, or look into speeding them up if they are a bottleneck, but I can not identify them.

Hey! I prepared a possible solution: https://github.com/evilmartians/lefthook/pull/338. It will print the current running commands/scripts right after the waiting spinner. I think it will be more convenient.
I am going to release it with 1.1.3. I hope it would help you to find the problem. I also think there might be a bug with lefthook itself. There were hangs on pre-push hooks when the commands/scripts were waiting for the input from STDIN, and I was fixing them in 1.1.2 :thinking:. When I release the new fix, please, come if you find more details on this bug.

Hey @abitrolly! How is it going? Did you have a chance to check 1.1.3?

Not yet, but let my try this right now.

@mrexox works good to show the command name.
⠙ waiting: danger, rubocop

I synced my branch with upstream, so there are not many changed files, so didn't run it over all tasks over few hours. Let me still try that though.

Well, I can't see any obvious MRs with a lot of changes to different files. But the next time I encounter them I give it a test. It is still would be good to see timing information by the step in the end.

@mrexox the terminal width may be determined incorrectly.  Isn't it scrollable horizontally?

Might be Gitpod not reporting correct width of the terminal. Or reducing the width of the terminal after a command already started.

Yes, I think there's something wrong with terminal, because lefthook just prints text, so it is out of its responsibility :thinking:

@mrexox when printing lefthook tries to git fit terminal width. Does it reevaluate the width after it has been already started?

@abitrolly , actually lefthook doesn't have explicit code associated with terminal. Maybe there is something in spinner lib we use :thinking:

Fixed link https://github.com/briandowns/spinner


Support ONC requirements for Group Bulk Export

Describe the issue
ONC requirements mentioned here, require that HAPI-FHIR be able to include Practitioner, Organization, Device and Location resources as part of the responses for requests for multiple patient Group Bulk Export. The resources are referenced within the resources that is a part of the patient compartment.
Environment (please complete the following information):

HAPI FHIR Version 6.2.0
OS: MacOS
Browser: chrome

https://github.com/hapifhir/hapi-fhir-jpaserver-starter/issues/446
its not resolved yet in 6.2.0 pre18.


Another Issue, not sure if it is the APT protocol or something else

Migrated from https://gitlab.com/yaq/thorlabs-apt-protocol/-/issues/7
Opened by @ely-eastman

If I issue a stop command to a stage, the motor won't respond to any other commands, including moving home or starting another move. If I stop running the program entirely and restart it I can get the stage to respond, but it won't until I do so. Anyone else had this issue or is there a command I need to issue after running the stop command to get the waveplate to move again?

Kyle Sunden @ksunden · 10 months ago
Hmmm... I have not experienced this with any of the APT hardware I've dealt with... though admittedly don't send STOP Msg all that often.
Are there any unexplained messages coming back?


(SUGGESTION) GP from Extra utilities 2

An input/output for GP from extra utilities 2

https://minecraft.curseforge.com/projects/modular-magic


Add beautify output

Example: https://github.com/frontendfriends/gulp-combine-mq#usage

this would be very helpful... I actually switched to using 'gulp-combine-mq' for this reason. The problem is that 'gulp-combine-mq' doesn't have a "log" feature which was very helpful to see which @media queries were being affected in my build.


[Feat]: Explore Page

What would you like to share?
No contents in 'Explore' section

Additional information
Could u suggest me what contents shall I add in explore section? like cards or some what components would u prefer?
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@punyakrit could you assign me this issue under gssoc'24

This section is not required


"yarn develop" fails

yarn develop was working fine for me until today when I did a rebase over master. After the rebase, I ran yarn install which completed succesfully.
Now I'm getting this error when running yarn develop:
info bootstrap finished - 21.409 s

error Class constructor DefinePlugin cannot be invoked without 'new'

  TypeError: Class constructor DefinePlugin cannot be invoked without 'new'

  - plugin.js:8 new F
    [learn]/[webpack-configurator]/lib/resolve/plugin.js:8:33

  - plugin.js:13
    [learn]/[webpack-configurator]/lib/resolve/plugin.js:13:16

  - plugin.js:14 module.exports
    [learn]/[webpack-configurator]/lib/resolve/plugin.js:14:8

  - index.js:180 Config.resolve
    [learn]/[webpack-configurator]/index.js:180:22

  - webpack-modify-validate.js:45 _callee$
    [learn]/[gatsby]/src/utils/webpack-modify-validate.js:45:43

  - next_tick.js:131 _combinedTickCallback
    internal/process/next_tick.js:131:7

  - next_tick.js:180 process._tickCallback
    internal/process/next_tick.js:180:9

error Command failed with exit code 1.

node --version
v8.11.1
npm --version
5.6.0
$(npm bin)/yarn --version
1.6.0
Ubuntu 16.04.4

@Bouncey why did you close this? Is this a dup or something?

Must have been a slip of the finger, sorry

@tchaffee, are you still having a problem with this? I used nvm to switch to the same versions of node and npm you used and was able to complete the build. There were times in the past where I needed to run yarn install twice. Maybe that's causing the issue here?

@tchaffee I can't reproduce this either. Have you tried nvm install --lts (courtesy raisedadead). Just a thought. I have:
node: 8.11.2
yarn: 1.6.0

I got it working now. Not sure what did the trick, but running nvm install --lts did not fix it. I deleted the package.json.lock and yarn.lock local files, did a rebase over upstream master, and now it's working. Thanks for your help!


[WIP] Add logs subcommand

TODO

[ ] Add -f follow for all log sources
[ ] Add a default limit for node logs (currently gets full log)
[ ] Create better help output?
[ ] Shell tab completion support?

This will add a logs subcommand. It can be used to get control plane logs from cloudwatch logs or node logs as long as nodes have log query enabled.
Control plane components have short aliases to make querying easier (eg kube-apiserver -> api, cloud-controller-manager -> ccm)
Example control plane logs
k eks logs api
   I0719 17:09:03.035304      10 handler.go:232] Adding GroupVersion crd.k8s.amazonaws.com v1alpha1 to ResourceManager
   I0719 17:09:03.035824      10 handler.go:232] Adding GroupVersion vpcresources.k8s.aws v1beta1 to ResourceManager
   I0719 17:09:03.043369      10 handler.go:232] Adding GroupVersion karpenter.k8s.aws v1alpha1 to ResourceManager
   I0719 17:09:03.044100      10 handler.go:232] Adding GroupVersion karpenter.sh v1alpha5 to ResourceManager
   I0719 17:09:03.052008      10 handler.go:232] Adding GroupVersion karpenter.sh v1alpha5 to ResourceManager
   I0719 17:09:03.072483      10 handler.go:232] Adding GroupVersion nvidia.com v1 to ResourceManager

k eks logs scheduler
   I0719 17:18:55.277892      11 schedule_one.go:867] "Unable to schedule pod; no fit; waiting" pod="default/release-name-stable-diffusion-0" err="0/4 nodes are available: 2 Insufficient nvidia.com/gpu, 2 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}. preemption: 0/4 nodes are available: 2 No preemption victims found for incoming pod, 2 Preemption is not helpful for scheduling.."

Node logs are fetched from a kubelet proxy feature in 1.27. Configuration is checked before querying the API and will output an error message if the node is not configured for remote logging.

        Please enable remote logging on the kubelet from the documentation here
        Requires Kubernetes 1.27 https://kubernetes.io/blog/2023/04/21/node-log-query-alpha/

The way the kubelet logging works you can provide a systemctl service name (kubelet is default) or you can provide a file name from /var/log and kubelet will cat the file
// get /var/log/yum.log
k eks logs logs i-0893b00283cbf17aa.us-east-2.compute.internal yum
Jul 03 03:40:13 Installed: 7:device-mapper-event-1.02.170-6.amzn2.5.x86_64
Jul 03 03:40:13 Installed: 7:lvm2-libs-2.02.187-6.amzn2.5.x86_64
Jul 03 03:40:13 Installed: 7:lvm2-2.02.187-6.amzn2.5.x86_64
Jul 03 03:40:49 Installed: amazon-ssm-agent-3.1.1732.0-1.amzn2.x86_64
Jul 18 21:28:11 Installed: 2:xxd-9.0.1592-1.amzn2.0.1.x86_64
Jul 18 21:28:11 Installed: gpm-libs-1.20.7-15.amzn2.0.2.x86_64
Jul 18 21:28:11 Installed: 2:vim-filesystem-9.0.1592-1.amzn2.0.1.noarch
Jul 18 21:28:13 Installed: 2:vim-common-9.0.1592-1.amzn2.0.1.x86_64
Jul 18 21:28:13 Installed: 2:vim-enhanced-9.0.1592-1.amzn2.0.1.x86_64

One thing I wanted to discuss was shelling out to kubectl to fetch the raw URL for node logs and kubelet config. I'm not sure how you've handled that other places so I did it there because I knew it would work. Happy to update if you have a cleaner way without shelling out.

Example help output right now
go run main.go logs --help
Get logs from EKS control plane or nodes

Usage:
  kubectl-eks logs [flags] LOG_SOURCE

Examples:
  kubectl eks logs kube-apiserver
  kubectl eks logs NODE [query]

Flags:
  -h, --help            help for logs
      --region string   region

Global Flags:
      --as string
...

I wanted to add more details about what control plane fields are available but couldn't find a way to do that in cobra without going fully to a custom help template which I was trying to avoid.

@rothgar I think that's the only option (Long, Short, Example section in cobra CLI) regarding the accepted args, and flags values.
Inspiring from kubectl, I think we can add something like this:
    -o, --output='':
	Output format. One of: (json, yaml, name, go-template, go-template-file, template, templatefile, jsonpath,
	jsonpath-as-json, jsonpath-file).

What do you think ?

with regards to shelling out to kubectl for  --rawcommand. I have never done this before but I am guessing as it is doing simply REST call, we should be able to rely on RESTclient from client-go.
we already have clientset function under pkg/kube, so you can define,
clientSet, _ := kube.ClientSet(KubernetesConfigFlags)

then for rest call, for example,
kubectl get --raw "/api/v1/nodes/node-1.example/proxy/logs/?query=kubelet"

will be:
req := clientSet.RESTClient().Get().
			Name(i.Name).
			Resource("nodes").
			SubResource("proxy").
			Suffix("logs").
			Param("query", query)
readCloser, err := req.Stream(context.Background())

```

I knew something like this exists but never tried it hence asked chatgpt which gave me above snippet.

I couldn't try your logs one but I was able to try simple one:
kubectl get --raw /api/v1/namespaces/kube-system/pods

equivalent go:
clientSet, _ := kube.ClientSet(KubernetesConfigFlags)
req := clientSet.RESTClient().Get().
		Resource("pods").
		Namespace("kube-system").
                 Prefix("api/v1")

resp, err := req.DoRaw(context.Background())
if err != nil {
    fmt.Println("error")
}
fmt.Println(string(resp), req.URL().String())

This is working with the things I intended it to be able to do but using the clientSet didn't work for me. I'm going to look into it more and see why that might be. I was using the absurl option and tried other things but never got the data back from the API.
Here's the current help output
Get logs from EKS control plane or nodes

Usage:
  kubectl-eks logs [flags] LOG_SOURCE

Examples:
    kubectl eks logs kube-apiserver
    kubectl eks logs NODE [kubelet]

  Query multiple log sources:
    kubectl eks logs api audit scheduler
    kubectl eks logs NODE kubelet containerd

Flags:
  -f, --follow          Follow logs (not available for node file queries)
  -h, --help            help for logs
      --region string   region
      --since string    What time logs should start from (default "1 hour ago")

I'm going to run more checks and probably write some tests for this tomorrow but I think it's almost feature complete. You should be able to compile it and run against a cluster for control plane logs as long as you have control plane logging enabled.
kubectl-eks logs api audit ccm

ah cool, I will try it out today with my eks cluster.

@rothgar I think that's the only option (Long, Short, Example section in cobra CLI) regarding the accepted args, and flags values.
Inspiring from kubectl, I think we can add something like this:
    -o, --output='':
	Output format. One of: (json, yaml, name, go-template, go-template-file, template, templatefile, jsonpath,
	jsonpath-as-json, jsonpath-file).

What do you think ?

I didn't implement this because the log output varies greatly depending on what component you're querying. The control plane components are sometimes in json but sometimes not and logs from the node with kubelet or from /var/log are in any format so there's no way to parse them and turn them into structured data

@rothgar merging this in, will cut a new release for the same later today.


Clear Unsigned Items on Popup Closure

Builds on PR #188 to ensure that if the Signer window is closed during the signing process the deploy/message will be cleared from the queue.
Asset
Signer for PR 192

To prevent duplicated effort should be reviewed after #188 is merged as it contains the same code changes that will disappear after rebase

@George-cl we need to rebase and remove conflicts, could you take care of that, please?

Signer for PR 192


Unable to delete a VM because the filesystem is still in use [LVM storage backend]

Required information

Distribution: ArchLinux
Distribution version: latest (as of Apr 04 2020)
The output of "lxc info" or if that fails:

config: {}
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
- tls
environment:
  addresses: []
  architectures:
  - x86_64
  - i686
  driver: lxc
  driver_version: 4.0.0
  firewall: nftables
  kernel: Linux
  kernel_architecture: x86_64
  kernel_features:
    netnsid_getifaddrs: "true"
    seccomp_listener: "true"
    seccomp_listener_continue: "false"
    shiftfs: "false"
    uevent_injection: "true"
    unpriv_fscaps: "true"
  kernel_version: 5.4.30-1-lts
  lxc_features:
    cgroup2: "true"
    mount_injection_file: "true"
    network_gateway_device_route: "true"
    network_ipvlan: "true"
    network_l2proxy: "true"
    network_phys_macvlan_mtu: "true"
    network_veth_router: "true"
    seccomp_notify: "true"
  project: default
  server: lxd
  server_clustered: false
  server_pid: 1436
  server_version: 4.0.0
  storage: btrfs | lvm
  storage_version: 5.4.1 | 2.02.187(2) (2020-03-24) / 1.02.170 (2020-03-24) / 4.41.0

Issue description
Getting the following error when trying to delete a VM:
$ lxc delete demo
Error: Error deleting storage volume: Error removing LVM logical volume: Failed to run: lvremove -f /dev/lvmbased/containers_demo: Logical volume lvmbased/containers_demo contains a filesystem in use.

More info about the storage
$ lxc storage list
+----------+-------------+--------+--------------------------------+---------+
|   NAME   | DESCRIPTION | DRIVER |             SOURCE             | USED BY |
+----------+-------------+--------+--------------------------------+---------+
| default  |             | btrfs  | /var/lib/lxd/disks/default.img | 0       |
+----------+-------------+--------+--------------------------------+---------+
| lvmbased |             | lvm    | lvmbased                       | 9       |
+----------+-------------+--------+--------------------------------+---------+
[denis@T450s prometheus-demo-site]$ lxc storage show lvmbased
config:
  lvm.thinpool_name: LXDThinPool
  lvm.vg_name: lvmbased
  source: lvmbased
  volatile.initial_source: /dev/sda4
description: ""
name: lvmbased
driver: lvm
used_by:
- /1.0/containers/demo
- /1.0/containers/gitlab
- /1.0/images/29227944dc01396694237f08541d3135cab6b87a0b862ea0f2006c666d2c1ada
- /1.0/images/6ba50a93e883cf5ae71a4a727f55886c9857c4d74c8736104905e2513ae5cd2e
- /1.0/images/76f574054abcdec9c3a4f2c3177c370a3c5906217fe1648bde326b9937b8553b
- /1.0/images/7f47520c4613e56199c79ac660fc30c9a83352f8b78c465e57461356610991c0
- /1.0/images/9b3a342b12a16deabfce2e0444a0ac4c2245b108743345f3c3eed632c4f0e907
- /1.0/images/b2eb08cbfada3ea1301a9ee973fba91aef8a588fee56fb70d084b6306cb741a0
- /1.0/profiles/default
status: Created
locations:
- none

Information to attach

[ ] Any relevant kernel output (dmesg)
[X] Container log

$ lxc info demo
Name: demo
Location: none
Remote: unix://
Architecture: x86_64
Created: 2020/04/04 04:39 UTC
Status: Stopped
Type: container
Profiles: default
[denis@T450s prometheus-demo-site]$ lxc info demo --show-log
Name: demo
Location: none
Remote: unix://
Architecture: x86_64
Created: 2020/04/04 04:39 UTC
Status: Stopped
Type: container
Profiles: default

Log:

lxc demo<PHONE_NUMBER>5958.296 ERROR    cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1136 - File exists - Failed to create directory "/sys/fs/cgroup/cpuset//lxc.monitor.demo"
lxc demo<PHONE_NUMBER>5958.297 ERROR    cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1136 - File exists - Failed to create directory "/sys/fs/cgroup/cpuset//lxc.payload.demo"
lxc demo<PHONE_NUMBER>5958.328 WARN     cgfsng - cgroups/cgfsng.c:fchowmodat:1445 - No such file or directory - Failed to fchownat(17, memory.oom.group, 65536, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )

[X] Output of the daemon with --debug (alternatively output of lxc monitor while reproducing the issue)

location: none
metadata:
  context:
    ip: '@'
    method: GET
    url: /1.0
    user: ""
  level: dbug
  message: Handling
timestamp: "2020-04-04T19:28:11.143201432-04:00"
type: logging

location: none
metadata:
  context:
    ip: '@'
    method: GET
    url: /1.0/instances/demo
    user: ""
  level: dbug
  message: Handling
timestamp: "2020-04-04T19:28:11.145460945-04:00"
type: logging

location: none
metadata:
  context:
    ip: '@'
    method: GET
    url: /1.0/events
    user: ""
  level: dbug
  message: Handling
timestamp: "2020-04-04T19:28:11.148272399-04:00"
type: logging

location: none
metadata:
  context: {}
  level: dbug
  message: 'New event listener: 402a06f9-0a9e-43c5-a5e0-decc5378a4d5'
timestamp: "2020-04-04T19:28:11.148679906-04:00"
type: logging

location: none
metadata:
  context:
    ip: '@'
    method: DELETE
    url: /1.0/instances/demo
    user: ""
  level: dbug
  message: Handling
timestamp: "2020-04-04T19:28:11.149008623-04:00"
type: logging

location: none
metadata:
  context: {}
  level: dbug
  message: 'New task Operation: 9f78f717-8634-4925-86b1-a5d8bb8e33f2'
timestamp: "2020-04-04T19:28:11.154907889-04:00"
type: logging

location: none
metadata:
  context:
    created: 2020-04-04 00:39:22.503089804 -0400 EDT
    ephemeral: "false"
    name: demo
    project: default
    used: 2020-04-04 11:59:58.233418938 -0400 EDT
  level: info
  message: Deleting container
timestamp: "2020-04-04T19:28:11.155774677-04:00"
type: logging

location: none
metadata:
  context: {}
  level: dbug
  message: 'Started task operation: 9f78f717-8634-4925-86b1-a5d8bb8e33f2'
timestamp: "2020-04-04T19:28:11.155518629-04:00"
type: logging

location: none
metadata:
  class: task
  created_at: "2020-04-04T19:28:11.150715772-04:00"
  description: Deleting container
  err: ""
  id: 9f78f717-8634-4925-86b1-a5d8bb8e33f2
  location: none
  may_cancel: false
  metadata: null
  resources:
    containers:
    - /1.0/containers/demo
  status: Running
  status_code: 103
  updated_at: "2020-04-04T19:28:11.150715772-04:00"
timestamp: "2020-04-04T19:28:11.156414577-04:00"
type: operation

location: none
metadata:
  class: task
  created_at: "2020-04-04T19:28:11.150715772-04:00"
  description: Deleting container
  err: ""
  id: 9f78f717-8634-4925-86b1-a5d8bb8e33f2
  location: none
  may_cancel: false
  metadata: null
  resources:
    containers:
    - /1.0/containers/demo
  status: Pending
  status_code: 105
  updated_at: "2020-04-04T19:28:11.150715772-04:00"
timestamp: "2020-04-04T19:28:11.155478925-04:00"
type: operation

location: none
metadata:
  context:
    driver: lvm
    instance: demo
    pool: lvmbased
    project: default
  level: dbug
  message: DeleteInstance started
timestamp: "2020-04-04T19:28:11.158999489-04:00"
type: logging

location: none
metadata:
  context:
    ip: '@'
    method: GET
    url: /1.0/operations/9f78f717-8634-4925-86b1-a5d8bb8e33f2
    user: ""
  level: dbug
  message: Handling
timestamp: "2020-04-04T19:28:11.158722241-04:00"
type: logging

location: none
metadata:
  context:
    driver: lvm
    instance: demo
    pool: lvmbased
    project: default
    volName: demo
  level: dbug
  message: Deleting instance volume
timestamp: "2020-04-04T19:28:11.159679969-04:00"
type: logging

location: none
metadata:
  context:
    driver: lvm
    instance: demo
    pool: lvmbased
    project: default
  level: dbug
  message: DeleteInstance finished
timestamp: "2020-04-04T19:28:23.777966276-04:00"
type: logging

location: none
metadata:
  context: {}
  level: dbug
  message: 'Failure for task operation: 9f78f717-8634-4925-86b1-a5d8bb8e33f2: Error
    deleting storage volume: Error removing LVM logical volume: Failed to run: lvremove
    -f /dev/lvmbased/containers_demo: Logical volume lvmbased/containers_demo contains
    a filesystem in use.'
timestamp: "2020-04-04T19:28:23.778064057-04:00"
type: logging

location: none
metadata:
  class: task
  created_at: "2020-04-04T19:28:11.150715772-04:00"
  description: Deleting container
  err: 'Error deleting storage volume: Error removing LVM logical volume: Failed to
    run: lvremove -f /dev/lvmbased/containers_demo: Logical volume lvmbased/containers_demo
    contains a filesystem in use.'
  id: 9f78f717-8634-4925-86b1-a5d8bb8e33f2
  location: none
  may_cancel: false
  metadata: null
  resources:
    containers:
    - /1.0/containers/demo
  status: Failure
  status_code: 400
  updated_at: "2020-04-04T19:28:11.150715772-04:00"
timestamp: "2020-04-04T19:28:23.779760138-04:00"
type: operation

location: none
metadata:
  context: {}
  level: dbug
  message: 'Event listener finished: 402a06f9-0a9e-43c5-a5e0-decc5378a4d5'
timestamp: "2020-04-04T19:28:23.783860261-04:00"
type: logging

location: none
metadata:
  context: {}
  level: dbug
  message: 'Disconnected event listener: 402a06f9-0a9e-43c5-a5e0-decc5378a4d5'
timestamp: "2020-04-04T19:28:23.784314786-04:00"
type: logging

grep containers_demo /proc/*/mountinfo may help figure out what's keeping it busy

I'm getting an empty output from that command.
# grep containers_demo /proc/*/mountinfo
#

Hmm, then I wonder why LVM thinks it's currently in use...
Try grep demo /proc/*/mountinfo maybe?

I've managed to delete the container this morning (EST timezone) simply with the command `lxc delete demo' and I'm not sure why it worked.
I'll just close this issue.

Okay so may have been either a kernel reference but that cleared or some process had an open fd which only got closed later...
Good that it looks like the error was accurate and things worked again once its source went away.


test(mongodb): add mongodb integration tests

Nice! Does everything work as expected?

I needed to some adaptions in the code as some tests would naturally not work in mongodb but nothing unexpected happened.


Experiment with https://github.com/kvark/simplecs

https://github.com/kvark/simplecs

Screw that, check out https://github.com/slide-rs/specs instead

Хорошо :)


Some file operation strings not localized

files and folders not localized. They appear in undo labels and progress labels.
https://github.com/microsoft/vscode/blob/4168941deec97e4416493daf844e516740c716b3/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts#L1202-L1215

Assigned the folks based on the blame.
@isidorn added it,
@joaomoreno modified stuff closest to it,
@bpasero was also seen quite a bit in that file
https://github.com/microsoft/vscode/blame/4168941deec97e4416493daf844e516740c716b3/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts#L1202-L1215

It is localized, just check how that method is being used. It is always under a localized call.
Thus closing

My mistake, after discussing with @bpasero this is a valid issue. We need to call localize on each substring, because the transaltors can localize Foo {0} but not the thing in 0.

@isidorn I'm wondering what are some repro steps for this issue? I'm not sure where to find the strings.

@rzhao271 I guess code review is good enough for this one.
I believe these labels are not seen anywhere: they are undo labels which we might surface in the future if we introduce a richer Undo UI.


A practical Example as a form of Documentation

Hi @davidyaha I am working on this repository with express-graphql and was looking into documenting a practical example via MQTT.
I am not using typescript but standard ES6 stuff. Would you be able to just guide me with how do I get the data from the Broker out?
Progress
Defined a Schema as following:
schema.js
        type Result {
            payload: String
        }

        input TopicInput {
            topic: String!
        }

        type RootSubscription {
            subscribeSite(topicInput: TopicInput): Result
        }

       schema {
            query: RootQuery
            mutation: RootMutation
            subscription: RootSubscription
        }

resolvers.js
I did the following:
const { MQTTPubSub } = require('graphql-mqtt-subscriptions');
const { connect } = require('mqtt');

const client = connect('my.mqtt.broker.address', {
    reconnectPeriod: 1000
});

const pubsub = new MQTTPubSub({
    client
});

within the resolver function:
subscribeSite: (args) => {
    pubsub.asyncIterator(args.topicInput.topic)
}

I am not sure how do I get the value from the asynIterator at this point and return it to the GraphiQL UI.
I already have a setup where live data is sent via sensor nodes and maybe the repo could benefit from a nice working example writeup

I had to move from express-graphql to apollo-server-express since the former still doesn't have Subscriptions implementation.
I adapted the code but I get a websockets error. why?

will reopen it once a concrete setup is up and running

Based on #11  I will

Sounds great @shantanoo-desai! Please link it here when it's up!
btw, all subscription packages work similarly so you might want to head over to apollo's graphql-subscriptions repo to get information about asyncIterables  and the api to transform and filter them. This package is intended to be more like an addon to graphql-subscriptions because the actual pubsub manager can be easily replaced for something like redis / rabbitmq or whatever actually.
Regarding your issue here:
subscribeSite: (args) => {
    pubsub.asyncIterator(args.topicInput.topic)
}

Please note that you are not returning anything in this arrow function. The simplest form of subscription resolver should return an object with a subscribe property that has an iterable factory.
There are good examples here: https://github.com/apollographql/graphql-subscriptions#getting-started-with-your-first-subscription
Let me know if you need anymore help there and I would love to merge a working example to this repo's README file.

Hi @davidyaha I have written a blog post documenting a live IoT Data along side MQTT GraphQL Endpoint with Apollo Server here. Let me know if you find this useful or not.

@shantanoo-desai 🎉 🎉 Awesome use case!! Would love to see an app that utilizes this graphql api!

@davidyaha I do actually have something in mind but requires a bit more thought. I figured out that GraphQL Schemas can Adapt EPCIS aka. product RFID very well.
An really practical example might be Subscribing to live product tracking within companies or factories via MQTTPubSub.


Feature/logger

Added logging ecosystem to the auth service

@gmatoshp I fixed some merge conflicts that you had in the branch. I pushed them. Could you please pull those changes to your local environment and test that everything is working correctly? Thanks!


Typo in directory name, 'telemtry' should be 'telemetry'

one of those insidious single-character typos that slips by everyone. mixtral caught it tho.

Great catch

<3


CSA 4.7 - Missing Service Design

Hello,
After deployment, I have no service design available and I can not install any CSA Capsules.
Here is the message

Container Deployment is fine

Changing the  hostname and ipaddress in the yml file
Starting to download all the required images and the containers will be created in the backgroud. This may take sevaral minutes.

Thank you

You have to give it a couple of minutes to initialize. CSA starts out with a productive sleep 120. The actual work it performs afterwards can take serveral minutes, depending on the capacities of the host. I made the same mistake on my first installation.


Redo overview file

This address #5 by providing a basic object model with links.

Docs Build status updates of commit 39aee12:
:clock10: Pending: waiting for processors (11 builds ahead of you)
:warning: Docs Build is busy, currently there are 11 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 39aee12:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/office-scripts/overview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 265d864:
:clock10: Pending: waiting for processors (18 builds ahead of you)
:warning: Docs Build is busy, currently there are 18 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 265d864:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel-scripts/toc.yml
:warning:Warning

Details

docs/docs-ref-autogen/excel-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/office-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/overview.md
:white_check_mark:Succeeded

generate-docs/scripts/postprocessor.ts
:white_check_mark:Succeeded

docs/docs-ref-autogen/excel-scripts/toc.yml

Line 0: [Warning] Invalid file link:(~/docs-ref-autogen/excel-scripts/overview.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d371f56:
:clock10: Pending: waiting for processors (17 builds ahead of you)
:warning: Docs Build is busy, currently there are 17 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 3ce6fe0:
:clock10: Pending: waiting for processors (16 builds ahead of you)
:warning: Docs Build is busy, currently there are 16 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 9c77eec:
:clock10: Pending: waiting for processors (16 builds ahead of you)
:warning: Docs Build is busy, currently there are 16 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 3ce6fe0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/excel-scripts/toc.yml
:white_check_mark:Succeeded

docs/docs-ref-autogen/office-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/overview.md
:white_check_mark:Succeeded

generate-docs/scripts/postprocessor.ts
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 63caa41:
:clock10: Pending: waiting for processors (16 builds ahead of you)
:warning: Docs Build is busy, currently there are 16 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 9c77eec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/excel-scripts/toc.yml
:white_check_mark:Succeeded

docs/docs-ref-autogen/office-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/overview.md
:white_check_mark:Succeeded

generate-docs/scripts/postprocessor.ts
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 63caa41:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/excel-scripts/toc.yml
:white_check_mark:Succeeded

docs/docs-ref-autogen/office-scripts/overview.md
:white_check_mark:Succeeded

docs/docs-ref-autogen/overview.md
:white_check_mark:Succeeded

generate-docs/scripts/postprocessor.ts
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Checking in to prepare for going live. Please continue to leave any feedback here or as a new issue.


minor logging changes

Looks like the build a string to be logged test in VinylDNSServiceSpec.scala needs to change the text from status=200 to status_code=200.