I found a few possible errors, one which is breaking for me

So I ignored a few of the issues since, this project is still early, and they were only type issues that I could work around, but with version 0.3.0 another issue has cropped up that breaks things for me.
So the major issue that breaks things for me now, is the fact then after updating to 0.3.0 I am presented with
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './errors' is not defined by "exports" in<EMAIL_ADDRESS>
and the small but workaround issues that I have found since day one of using this, is also related in a way to the above, but not caused by it.
Cannot find module '@nahkies/typescript-koa-runtime/server' or its corresponding type declarations.ts(2307)
Cannot find module '@nahkies/typescript-koa-runtime/zod' or its corresponding type declarations.ts(2307)

it seems the runtime has no issues with these paths, but typescript does, and adding /src/ after @nahkies/typescript-koa-runtime path fixes the typescript issues, so it's just a simple path rewrite that needs to happen for the typescript types.
One last possible issue that I think you overlooked was you are linking joi definitions for zod.
https://github.com/mnahkies/openapi-code-generator/blob/6d6183abf264f085eec4cb416bd8e50db11432e6/packages/typescript-koa-runtime/package.json#L37
It's possible one or more of these issues are related to my setup, so do let me know, thanks.

Raised #119 to address the .d.ts issue, though it should be a red herring as by design the public API to the zod and joi portions of the runtime is expected to be identical.
For the:
Cannot find module '@nahkies/typescript-koa-runtime/server' or its corresponding type declarations.ts(2307)
Cannot find module '@nahkies/typescript-koa-runtime/zod' or its corresponding type declarations.ts(2307)

It would be helpful to see your tsconfig.json and the typescript version - my best guess is it will be caused by the moduleResolution parameter (docs). I'm fairly certain it needs to be:
"moduleResolution": "Node16",

and would recommend using https://github.com/tsconfig/bases/tree/main#node-20-tsconfigjson or equivalent as a base configuration which sets this by default

{
  "compilerOptions": {
    /* Base Options */
    "esModuleInterop": true,
    "skipLibCheck": true,
    "target": "esnext",
    // "verbatimModuleSyntax": false,
    "allowJs": true,
    "resolveJsonModule": true,
    "moduleDetection": "force",
    /* Strictness */
    "strict": true,
    "noUncheckedIndexedAccess": true,
    /* If transpiling with Typescript */
    "moduleResolution": "node",
    "module": "commonjs",
    "outDir": "dist",
    "sourceMap": true,
    "lib": [
      "es2022"
    ],
    /* Others */
    "checkJs": false,
    "noEmitOnError": true,
    "rootDir": ".",
    "allowSyntheticDefaultImports": true,
    "forceConsistentCasingInFileNames": true,
    "declaration": true,
    "strictNullChecks": true,
    "pretty": true,
    "noEmit": false,
    "declarationMap": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "preserveConstEnums": true,
    "importHelpers": true,
    "noErrorTruncation": true,
    "baseUrl": ".",
    "paths": {
      "@/*": [
        "./src/*"
      ],
      "@nahkies/typescript-koa-runtime/*": [
        "../../node_modules/@nahkies/typescript-koa-runtime/dist/*"
      ],
    },
    "typeRoots": [
      "../../node_modules/@types",
      "./src/types",
    ],
    "types": [],
  },
  "exclude": [
    "node_modules",
    "dist",
    "tests"
  ],
  "include": [
    "./src/**/*"
  ]
}

I've added a types workaround for your package, which fixed the issues in this, but as requested here is my tsconfig.json file. I can't remember what I based this tsconfig off, but it was a year ago.

Based on the above config, this was likely due to "moduleResolution" being set to Node instead of Node16 (probably bundler / nodenext would also work) - which is necessary for the exports field of package.json like https://github.com/mnahkies/openapi-code-generator/blob/acebcd931b8da07f0db9bca247c995c83576420b/packages/typescript-koa-runtime/package.json#L19-L40 to work correctly
ref: https://www.typescriptlang.org/tsconfig/#moduleResolution


Checking for inconsistent numbers of nodes/edges/nodepairs between labels and features

@DomInvivo I implemented a function checking for inconsistent numbers of nodes/edges/nodepairs between labels and features in the datamodule for #360. To keep label information separate from the featurization process, I created a new function found_size_mismatch in addition to the existing did_featurization_fail.
Otherwise, it could be included here
Also fixed docstrings according to #357.

@DomInvivo the test for the unit-tests for the test_multitask_datamodule is fixed in f39585370753073f7e700bc2b790ef146d151235
The _filter_none_molecules function is now applied to the union of none molecules across tasks. Otherwise (filtering per task), causes the random train/val/test split to assign molecules to more than one (with different tasks), blowing up the size of all three, i.e., #train + #val + #test > #all.
It's a result of different task_dataset_args[task]["sample_idx"] per task below:
https://github.com/datamol-io/graphium/blob/ba974b210ff62706d17e979d212abbead613235f/graphium/data/datamodule.py#L1116-L1124
Could this cause an issue when combining different datasets with shared molecules?

Let's not forget to remove the temporary fix described in #360 : https://github.com/datamol-io/graphium/issues/360#issue-1760806251

@DomInvivo this should be ready to merge


Upgrade futures to 0.3.0-alpha.18

There used to be some weird compilation errors on nightly with this alpha version, but that seems to be fixed now, so this can be merged now.


Fix calling functions with arguments

This PR adds functionality to only keep the second argument when calling a function. Previously, sushi would generate a temp file like so:
sushi   saving indexed functions (lib/main.hpp)
lib/temp.cpp:2:25: warning: character constant too long for its type
    2 |  int main() {helloWorld('main.hpp' 1);}
      |                         ^~~~~~~~~~
lib/temp.cpp: In function 'int main()':
lib/temp.cpp:2:35: error: expected ')' before numeric constant
    2 |  int main() {helloWorld('main.hpp' 1);}
      |                        ~          ^~
      |                                   )

In the above, we don't need to pass main.hpp to the temp file, only the arguments. This fixes issue #15
If users want to call functions with multiple arguments, we'll have to fix translate() in execute.py.
Passing tests:
(base) easto@Eastons-MacBook-Air tests % python3.9 -m pytest
========================================================================================================= test session starts ==========================================================================================================
platform darwin -- Python 3.9.16, pytest-7.1.3, pluggy-1.0.0
rootdir: /Users/easto/Library/Mobile Documents/com~apple~CloudDocs/Projects/sushi/tests
plugins: typeguard-2.13.3
collected 2 items

test_execute.py ..                                                                                [100%]

========================================================================================================== 2 passed in 0.85s ===========================================================================================================

Thanks! I will look into this soon.

@snacsnoc why not use positional arguments? This was the option earlier and by using that method sushi wouldn't put "file argument" inside temp file.
Example would be:
def helloWorld(number):	Execute(file='main.hpp', number)

@ksawery29 If we do that, it is not valid and it does not execute:
sushi   saving indexed functions (lib/main.hpp)
Traceback (most recent call last):
  File "/Users/easto/Library/Mobile Documents/com~apple~CloudDocs/Projects/sushi/examples/arg-cpp/app.py", line 10, in <module>
    from out.main import helloWorld
  File "/Users/easto/Library/Mobile Documents/com~apple~CloudDocs/Projects/sushi/examples/arg-cpp/out/main.py", line 2
    def helloWorld(number):     Execute(file='main.hpp', number)
                                                           ^
SyntaxError: positional argument follows keyword argument

When we mix keyword and positional arguments in Python, positional must come first.

Oh. When I run this I dont get any errors about it.

@ksawery29 when running the examples, cpp runs since there are no arguments but arg-cpp does not run.
Can you show your commands where it successfully executes?

It might be because no arguments were passed but I will check on my pc tomorrow. But what about just moving the file argument as the last argument? So from this: Example(file='hello.hpp', 123) it will be this: Example(123, file='hello.hpp')

Good idea! Out of the box, changing index.py to have file= at the end results in the args not being passed:
sushi   saving indexed functions (lib/main.hpp)
lib/temp.cpp: In function 'int main()':
lib/temp.cpp:2:24: error: too few arguments to function 'void helloWorld(int)'
    2 |  int main() {helloWorld();}
      |              ~~~~~~~~~~^~
In file included from lib/temp.cpp:1:

Ah my apologies, I should have submitted this PR from a feature branch instead of dev. I have added feature branches and merged to my dev, I did not intend to include those in this PR.
Having said that, commit d6ba095 is an improvement on the save() function.

@snacsnoc So what does this pull request add?

It might be something wrong with my setup, but after I executed your example it returned this error:
/usr/bin/ld: /tmp/cc8uD61J.o: in function `itt_add':
temp.c:(.text+0x43): undefined reference to `sin'
/usr/bin/ld: temp.c:(.text+0x57): undefined reference to `cos'
collect2: error: ld returned 1 exit status
sh: 1: ./lib/out: not found

I'm using currently wsl (<IP_ADDRESS>-microsoft-standard-WSL2) so maybe because of that I can't compile. I will need to look later on a real linux machine.

@ksawery29
ccbf242 save() in index.py was fixed, it was rewriting the file over and over again when looping through data. If the other language file had multiple functions, sushi would only write the first function.
The fix includes writing the import statement only once, and looping through all the functions and printing to out/main.py.

@ksawery29 For the C example, does it generate the lib/out file? Your out/main.py should look like this:
from sushipy.execute import Execute
def itt_add():	Execute('main.h', )
def matrix_multiply():	Execute('main.h', )
def array_sum():	Execute('main.h', )

We can tone down the C example and make it a bit simpler for the purpose of this repo. My thought was to have some C functions and the equivalent Python code and run a benchmark on execution time.

@snacsnoc I was testing using pip version, not the fork one. After changing to your fixed version it works now. I will take a deep look later at this pull request.
So this pull request adds more examples and fixes save(), right? If something is missing let me know.
Also, I think the title should be changed so the examples are included.

@ksawery29  Yes that is correct, this fixes save() for saving multiple functions and adds a C example. I will update the title, thank you

Not sure about your workflow, but as an FYI the examples are easy to run from the examples/ directory using the forked version of sushi with import sys. Just import the parent directory path for running against the local version of sushi:
# pylint: disable=missing-module-docstring
import sys
sys.path.append('../../src')
from sushipy.main import Sushi

if __name__ == "__main__":
    Sushi()

    # sushi generates code for us to call in Python
    from out.main import itt_add

    itt_add()

Please let me know if there's a better way of testing development sushi.

Please let me know if there's a better way of testing development sushi.

I just use a simple file inside root folder. By doing that I can just import things like that:
import src.sushipy without changing the directory inside python code.


Enable ZX Live to be run from inside of a notebook.

This is very cool!
It is a little bit confusing when you open up Proof mode and try to save though, because then it still thinks it is embedded and it just doesn't do anything. If you click File->New also nothing happens. I'm not sure what the correct behaviour should be. I think allowing the user to work as much as possible as in regular ZXLive is probably the way to go.

Right now the instance of the graph in ZXLive and that in pyzx are the same. So if you make a change in ZXLive, then this is also reflected in pyzx, which is what you want. However, you can also make a change in pyzx, and this also changes the graph in ZXLive, but this is not reflected in the visuals. It is probably too hard to make ZXLive just 'know' when a change happened, but maybe we can add a command like 'update_graph' that just updates all the graphics, which you can call when you are done doing stuff in pyzx?

This could maybe even the form of an environment, like:
with zxl.update:
    zx.spider_simp(g)

Right now the instance of the graph in ZXLive and that in pyzx are the same. So if you make a change in ZXLive, then this is also reflected in pyzx, which is what you want.

It's the "same" only in the sense that if you make a change in ZX Live and click File->Save, the changes are saved back to the graph in the notebook. But the changes are not "live". I think it's less confusing/dangerous if no data is actually changed in the notebook until/unless the user deliberately requests the changes be saved.
It is possible to make it so that changes made in ZX Live are immediately saved back to the notebook. In graphscene.py, there is a line that makes the assignments new_g = diff.apply_diff(self.g), self.g = new_g. If, instead of doing that, it did what's currently done in the PR in handle_save_embedded_graph_action instead, the update will be written into the original graph in the notebook.
The problem is that ZX Live (or any Qt application) is opened asynchronously, so that the notebook continues to run. So the user could have both the notebook and ZX Live open, and make changes in both, and ZX Live is not aware of the changes made to the graph in the notebook.

However, you can also make a change in pyzx, and this also changes the graph in ZXLive, but this is not reflected in the visuals.

The PR is just a proof-of-concept but there are two ways to go with this. Either we make a copy of the graph initially when it's imported into ZX Live, to break the link explicitly (so that changes made in the notebook no longer affect anything in ZX Live, and the only way to send the edits back to the notebook is via File->Save); or we somehow try to detect or allow the user to inform us if the graph is changed in the notebook, and update the internal state and visuals in ZX Live.
I think the former is clearer/cleaner, and that the latter leaves many possible opportunities for bugs due to things being out of sync.

It is probably too hard to make ZXLive just 'know' when a change happened, but maybe we can add a command like 'update_graph' that just updates all the graphics, which you can call when you are done doing stuff in pyzx?

What's a use case in which a user edits a graph in ZX Live, but continues to make changes using pyzx in the notebook, and needs to update the opened graph in ZX Live? Instead of updating the graph, which is complicated, wouldn't it make more sense to just open a new tab with the changed graph?

I'll experiment with keeping changes between the notebook and ZX Live in sync, but I suspect it's going to lead to weird edge cases, like what happens if the user makes changes to both and the update in both directions happen at the same time. There's just all kinds of possibilities for bugs because of race conditions.

That's true, I didn't think of what would happen if you would make changes in both settings.

I think only one tab should be connected to the original graph
I agree with that.
And then when you open a proof panel, that the graph there should not be linked to the one in pyzx. Maybe a nice solution would be to make all the opened graphs in zxlive available via some variables to pyzx, so that you can get them out and do stuff with them in pyzx.
It is possible to make it so that changes made in ZX Live are immediately saved back to the notebook
I think like you said, we shouldn't do this, but only when the user explicitly saves.

If we want to go the route of syncing the ZXLive and pyzx graph so that a change in one updates the other, I think we should let the pyzx changes take precedence. So if I make some change in ZXLive, which I don't save, and then I make a change in pyzx, this should overwrite my changes in ZXLive. I think this is the cleanest way because the zxlive application is called by pyzx

I'll experiment with keeping changes between the notebook and ZX Live in sync

... and it turns out to be a huge mess due to the ability to undo/redo. Any updates made in the notebook would have to also be saved on the undo stack. That's complex enough without introducing an external source of possible edits.

Maybe a nice solution would be to make all the opened graphs in zxlive available via some variables to pyzx, so that you can get them out and do stuff with them in pyzx.

I think the solution which would lead to the fewest potential bugs down the road is to copy the input graph, work entirely on that within ZX Live, and return some kind of object to the caller from which they can extract additional information. The caller should be informed that this returned object can change due to actions taken in the embedded ZX Live app, but the connection to the original graph has been severed and they can do whatever they want with it. I think this solution has the clearest semantics which can be understood by a user.
That also solves the problem of what happens if you open the same graph object twice: ZX Live simply has two copies of the graph in different tabs, which don't affect each other. This can even be considered a feature. Maybe the user wants to compare different sets of edits (or proof steps or whatever) to the same original graph.
However, the downside is that the graph is copied, which requires memory. Is that an issue for larger graphs? (But I don't imagine that a graphical tool would be very useful for a graph with millions of vertices, for instances.)
The API design question here is then what kind of information is needed to be communicated from ZX Live back to the notebook? For example, the returned object can bundle the working copy of the input graph, as well as other things produced from it like proofs.
p.s. Is it "ZX Live" or "ZXLive"? I've seen both but it should be kept consistent in the documentation and also in the app's own dialogs.

The tab_index isn't stable, in that if you open or close or rearrange the tabs, they get re-indexed. But we can certainly assign each input graph a unique ID within ZX Live, which can be passed to the user to manipulate that graph and its dependents inside ZX Live.

Okay, I've added a way for the user to get (a copy of) the graph by name. Also, if the user edits a graph whose name already exists in a tab, that tab is replaced (but the action can be undo from within ZXLive).
However, I'm not sure what to do if the name is not unique. Right now, it just acts on the first tab with that name.


Duty rota not working?

Hi everyone, we have 4 users with all service subscription alert enabled. Only two are on duty (correctly read from google calendar) but all the alerts are being delivered to all 4 users.
We have to remove the subscriptions? And leave only the on duty informations?
Thank you!

Duty rota only affects phone calls IIRC - does that match the behaviour you're seeing?

Ok, we have not configured twilio yet... this is the problem, thank you!


featrue_sops_node_support

标准运维节点

Codecov Report

Merging #15 (01aede9) into v2.6.x_develop (064a256) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v2.6.x_develop      #15   +/-   ##
===============================================
  Coverage           51.31%   51.31%
===============================================
  Files                 688      688
  Lines               36359    36359
===============================================
  Hits                18658    18658
  Misses              17701    17701

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064a256...01aede9. Read the comment docs.


Push frames through splits in quotation

This results in more readable output.
It would produce [i=0 -> x] instead of fst [i=0 -> [x,y]]. Please note that this is only changing the meaning of quotation: conversion still implements the exact same theory. We can't really have full "normal forms" in such a strict calculus, so it's up to us to choose the quasi-normal forms that are most readable in practice.

Hmm, this has some problem... I don't have the right type to quote at. Maybe I will put this on hold.

OK, so the issue is: I don't actually have a good way to be selective about what frames get pushed inward. So, we can abandon this is we very much want to keep ap on the outside.


PROD SUPPORT: ORDERS: ORDER NOT GENERATING FOR OTHER ORDER TYPE

Describe the bug
Judge is unable to issue with order type 'Others'. PDF is not generating after adding details. As perview is not working, we are also not able to put signature
Screenshots

Hi @muhammed-sawad please prove curl or API response for the above Error.

Hi @muhammed-sawad
This Issue is working fine in UAT
Refer Screenshot

Hi @bhuvanyuguru
We got two types of errors:

{"errorMessage":"Order not found","errorCode":404}

{
"ResponseInfo": null,
"Errors": [
{
"id": null,
"parentId": null,
"code": "ORDER_UPDATE_EXCEPTION",
"message": "Order don't exist",
"description": null,
"params": null
}
]
}

screenshot of issue

Please letme know if you need anything other than this. I can also share a video tomorrow morning if you need. This template worked for one time and it went we tried to do again.
screenshot for ref

Hi @Susmitabe , @muhammed-sawad , @Ramu-kandimalla
Checked via Logs and in meeting, working fine
@Susmitabe  please confirm the same.

Today we will check and confirm


Add support for arbitrary command line options for docker_container

Scenario:
[What you are trying to achieve and you can't?]
I'm trying to setup a docker_container configuration to run blackbox-exporter.
The recommended config looks like:
docker run -d -p 9115:9115 --name blackbox_exporter -v pwd:/config blackbox_exporter -config.file=/config/blackbox.yml
Looking through the documentation for docker_container I can't see any way to pass arbitrary command line options like -config.file=/config/blackbox.yml
Could this be added as a feature to the docker_container resource ?

im not familiar with the -config.file command. can you point me to the docs on this?

It looks to be that a running container can access command line options passed in, for example here are a set of options used by the prometheus container:
http://demo.robustperception.io:9090/flags
So it's less about the specific -config.file option and more the general capability for options to be passed on the command line to then be accessed by the container.

this should work for you
docker_container 'blackbox_exporter' do
  repo 'blackbox_exporter'
  port '9115:9115'
  volumes '/localpath/config:/config'
  command '-config.file=/config/blackbox.yml'
end

Ah - thank you, sorry I'd misread that as setting the entrypoint.


Num/Caps/Scroll lock indicator doesn't light up on CK550

When clicking Num/Caps/Scroll lock the light indicator above the numpad doesn't light up.
Aurora Version:
Aurora: v0.7.2

Same issue. :(

Same issue

same too

are you on the new fork?
https://github.com/Aurora-RGB/Aurora

Hi you were right I never realised I was on the old one, My KB gets
detected correctly but still no luck with the lock lights as they are not
shown in the layout.
Thanks!
On Sat, Aug 13, 2022 at 8:22 AM Aytaç Kayadelen @.***>
wrote:

are you on the new fork?
https://github.com/Aurora-RGB/Aurora
—
Reply to this email directly, view it on GitHub
https://github.com/antonpup/Aurora/issues/1957#issuecomment-1214148255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUUIHCQZGO4NGTNR7D4N4SDVY6HP5ANCNFSM4MIIRNBA
.
You are receiving this because you commented.Message ID:
@.***>


Is there someway to safe only a few generic tags from safebooru?

When you do the %all% the list of tags is too long. Is there some way to safe a few of the tags?

Yes, as stated the best option if you want a "whitelist" of tags for your filename is to use a custom token.
If you want a "blacklist" instead, you can add the tags you don't want to the ignore list (or right click > ignore).


Use ViewStylePropTypes instead of ViewPropTypes.style

Hi,
I've noticed that since the last update of the "react-native-table-component", I get following error "_undefined is not an object (evaluating 'reactNative.ViewPropTypes.style')"
After some research, I've found out, that if you use "ViewStylePropTypes" instead of "ViewPropTypes.style", the error disappears.
So, please correct this mistake by importing "ViewStylePropTypes" from react-native and by replacing in your code every "ViewPropTypes.style" with "ViewStylePropTypes".
Thanks for your collaboration.

Hello, I see your advice,I'm my english is poor.
Is that your “react-native” version below 0.44?
Please use the vesion "^1.1.1" of “react-native-table-component ”, when the “react-native” version below 0.44.


Can't select an option

See fix here: https://github.com/adamjsturge/easy-xsshunter-express/pull/2/commits/80e209798f7b7a791b5c76bd425c2b41811778bc


EPE-148 - Fix EOF problem in datastream

This is in reference to this: https://blockone.atlassian.net/browse/EPE-148

I have added defensive programming practices to cfile to ensure that a user cannot use it if it is closed.

I'm not sure what the point of this PR is.  It doesn't address the issue in EPE-148 at all.  Instead it's just changing the usage of unique_ptr which originally worked fine.

I'm not sure what the point of this PR is. It doesn't address the issue in EPE-148 at all. Instead it's just changing the usage of unique_ptr which originally worked fine.

The problem I am trying to fix is a hard to track down EOF issue with cfile.
With the previous implementation of cfile, when you called the open for the for  the first  time, fclose is called on an undefined  instance of FILE* (unique_ptr::reset())

The problem I am trying to fix is a hard to track down EOF issue with cfile.
With the previous implementation of cfile, when you called the open for the for the first time, fclose is called on an undefined instance of FILE* (unique_ptr::reset())

It isn't undefined, it's null and fclose is not called [unique.ptr.single.modifiers].

The issue with EOF is that remaining() may return true even if the file position indicator is at the end of the file, because it uses feof, but that isn't what feof means.

The problem I am trying to fix is a hard to track down EOF issue with cfile.
With the previous implementation of cfile, when you called the open for the for the first time, fclose is called on an undefined instance of FILE* (unique_ptr::reset())

It isn't undefined, it's null and fclose is not called: "if and only if the old value of the stored pointer, old_p, was not equal to nullptr, calls get_deleter()(old_p)" [unique.ptr.single.modifiers].

I see. i did  a quick reference check and that is true-

The issue with EOF is that remaining() may return true even if the file position indicator is at the end of the file, because it uses feof, but that isn't what feof means.

Thank you for that. Is that written somewhere? if so, I must have glazed over it.

It was a comment in the first PR linked in the issue.

It was a comment in the first PR linked in the issue.

I see. Is this the comment from June 8th 2020 from this link? https://github.com/EOSIO/eos/pull/9192

That is a different, but related issue.  in_avail is another function that is close, but not quite what we need.  The one I was referring to is https://github.com/EOSIO/eos/pull/9183#discussion_r435921222.

That is a different, but related issue. in_avail is another function that is close, but not quite what we need. The one I was referring to is EOSIO/eos#9183 (comment).

remaining is a very strange function. is it needed?

remaining is a very strange function. is it needed?

Delete it and see what doesn't compile?

Also, I don't really see it as strange.  The intended behavior is pretty simple: are there any characters left that can be read?

Also, I don't really see it as strange. The intended behavior is pretty simple: are there any characters left that can be read?

The reasoning as to why I find it strange is because you could essentially use eof for that use case, instead of a specialized eof wrapped function which has to be maintained.

Also, I don't really see it as strange. The intended behavior is pretty simple: are there any characters left that can be read?

it built

Also, I don't really see it as strange. The intended behavior is pretty simple: are there any characters left that can be read?

it built when i commented out the remaining function

You will need to make sure that all the repos that use it still build, not just EOSIO/eos

Also, I don't really see it as strange. The intended behavior is pretty simple: are there any characters left that can be read?

it built when i commented out the remaining function

You will need to make sure that all the repos that use it still build, not just EOSIO/eos

Ok, Thank you Brian. That is good to know. it sounds easier if i fix the remaining function.

Also, I don't really see it as strange. The intended behavior is pretty simple: are there any characters left that can be read?

it built when i commented out the remaining function

You will need to make sure that all the repos that use it still build, not just EOSIO/eos

Ok, Thank you Brian. That is good to know. it sounds easier if i fix the remaining function.

I believe I have fixed the remaining function.


TextField.value's type hint

Description
TextField.value can take both a str and a number. But its type hint in textfield.py is Optional[str] = None(either str or None)
The type hint should be updated, if you think this behavior is normal.
Code example to reproduce the issue:
import flet as ft

def main(page: ft.Page):

    tb1 = ft.TextField(value=2500)
    tb2 = ft.TextField(value="2500")

    page.add(tb1, tb2)

ft.app(target=main)

hey!
worked as expected?

No, I decided to leave it as is. Adding beartype check breaks a lot.
Let it show the error during code editing.

Alright.

Why is value an Optional? I just tried out the counter example from the docs and pyright complained that the TextField value that is manipulated in the callback functions can be None.
It of course isn't, because it gets set when the TextField is created, but is it not more intuitive to say that a TextField always has a value and that its default value is an empty string?
Sorry if this is obvious, I am not familiar with the code yet.


create crowdin account

Crowdin is the integration tool to translate the contents.
I've tested as an individual, but not as a community.
It's good to know about the Crowdin.

I wish someone will get used to using crowdin, but at this time let's keep working the project I created on the crowdin.


Update README.md

Changes
Context
Testing
Pre-merge checklist

[x] Build succeeds locally and in CI
[x] Proper documentation
[x] Tests
[x] Git history clean

Coverage remained the same at 27.338% when pulling c79920b88994bb01b1d094aa2448df9af9e82019 on fvosburgh-patch-1 into 00ae6ed78089a3b1a6c062b6007bf615968eb1e4 on master.


40: internal function argument out of range

For new development of telemetric particle counter we are looking into SPS30 and made some test software on PC to do the uart SHDLC protocol to communicate with the SPS30
For all commands sent to it, sps30 returns 40: internal function argument out of range status response. However, the command seems to be executed by the sensor.  The fan actually switches on after start command, and off after stop command.
Is this an issue with the protocol or is it something internal in de sensor ?

A true power-down power-up sequence of the sensor seems to have solved the issue.

Hi @jaapliefting
Thanks for reporting, we'll check internally if we have something on the record for this behavior. I'm just curious if you have also tried the soft reset (sps30_reset)? I see that the documentation for the i2c driver (https://github.com/Sensirion/embedded-sps/blob/d965ff6b6c79d61915dafb5e657f79726bd626c3/sps30-i2c/sps30.h#L230) is much better than the UART one..


Artist/Writer Messages Page Setup

Styling still pending.
Still need to setup CSV pull. Right now the messages are being generated by a for loop.
Also need to figure out how to deal w/ VoiceOver not reading the article messages.

@miffens I edited the PR title since I'm not sure what the CSV is going to look like yet. Maybe we merge this in w/ the initial setup, the fixes to the tabs, and the dark reader fix?
I also wasn't able to get VoiceOver to read the contents of the article elements. As a sanity check, I tried Chrome's screen reader extension and that seemed to work. Am I missing an aria tag here or should I use a different semantic tag that more compatible to define each message element?

Voiceover reads "article" and "end of article" for me. I also think it's fine in case screenreaders don't - I think a user can understand the page contents fine without those annotations
(nit) The message headings should ideally be h2-h3 - currently the heading hierarchy jumps from h1 ("the birthday project" title) to h4-h5 without reason. imo it's not a huge problem - it wouldn't confuse a user much because the messages being subcontents of the page is effectively conveyed with h4-h5, it's just slightly unexpected lol.
(nit) this is slightly fancy so not needed and mainly for your learning - if the messages are wrapped in ul/li elements, Voiceover will read the "position" you are on in the list ("2 of 50"). This can be helpful to let the user know how much more content there is remaining.

Voiceover reads "article" and "end of article" for me. I also think it's fine in case screenreaders don't - I think a user can understand the page contents fine without those annotations (nit) The message headings should ideally be h2-h3 - currently the heading hierarchy jumps from h1 ("the birthday project" title) to h4-h5 without reason. imo it's not a huge problem - it wouldn't confuse a user much because the messages being subcontents of the page is effectively conveyed with h4-h5, it's just slightly unexpected lol. (nit) this is slightly fancy so not needed and mainly for your learning - if the messages are wrapped in ul/li elements, Voiceover will read the "position" you are on in the list ("2 of 50"). This can be helpful to let the user know how much more content there is remaining.

@miffens I made attempts to wrap the messages in ul/li but Voiceover doesn't seem to want to say which position list item I'm on in the list. Not sure if I'm doing something wrong in the code or if I misconfigured my Voiceover. Added hover states for when a user highlights a button w/ a keyboard!
https://user-images.githubusercontent.com/7121716/211129266-ed27aa3a-bd14-4541-a324-1465b98534ee.mov


update for newer macOS versions

makes app compatible with new settings structure in e.g. Monterey

This modification works well with 10.13 Monterey. Thanks!

Just go the mgoeppl's fork repo, and do the same installation process

Superseded by #13. But thank you for the PR, @mgoeppl!


Support package selection options like --exclude in cargo publish

Fixes #14652.
Is there a way to make the help text depend on whether nightly/unstable features are enabled? I couldn't find one...

@bors try

:hourglass: Trying commit 3e1a9896114bd286b7a83e5f124ecd5971229905 with merge 12caaff7c2daaf03c248d485a33da8cd770231d2...

:broken_heart: Test failed - checks-actions

I presume that these flags are behind -Zpackage-workspace so we don't need to go through the RFC process until the stabilization. Once the man pages are added I'll merge this.

:pushpin: Commit d30fde980f524f0240aa5ccb1a10199aff5f5de1 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit d30fde980f524f0240aa5ccb1a10199aff5f5de1 with merge 5b220de42b466377311afc99c9d0480091905e50...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 5b220de42b466377311afc99c9d0480091905e50 to master...


Print (empty) for empty strings

Currently sqllogictest returns empty string rendered as is:
query T
select concat(NULL, NULL);
----

It should render it as:
query T
select concat(NULL, NULL);
----
(empty)

As per sqllogictest docs - https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki:

Empty strings are rendered as "(empty)"

I think this is controlled by the actual database implementation.
https://github.com/risinglightdb/sqllogictest-rs/blob/f41a7bfc3c79160a644a1a16eca91effe97d758a/examples/basic.rs#L19-L33
In sqllogictest's perspective, it simply compares and verifies a string.

Oh maybe you're referring to the sqllogictest binary. In this case,
https://github.com/risinglightdb/sqllogictest-rs/blob/f41a7bfc3c79160a644a1a16eca91effe97d758a/src/main.rs#L372-L375
It is true that we didn't write anything for an empty string 🤣

Oh maybe you're referring to the sqllogictest binary. In this case,
sqllogictest-rs/src/main.rs
Lines 372 to 375 in f41a7bf
match row.get(i) {
Some(v) => write!(output, "{}", v).unwrap(),
None => write!(output, "NULL").unwrap(),
}
It is true that we didn't write anything for an empty string :rofl:

Yes, that's what I was referring to, I think the sqllogictest binary needs to specially handle empty strings, similar to what it does for the NULL case above :rofl:


Added the Dockerfile and docker compose file

I added Dockerfile and docker compose for the API. All the endpoints are tested through postman.

good job


lib/bom.js: strange static members in XMLHttpRequest

This worked on 0.47.0 but doesn't work in any later version, flow.org/try:
const xhr = new XMLHttpRequest();
console.log(xhr.DONE);

But, that was not ideal; constants like DONE should be definitely static members right on XMLHttpRequest, just like flow.org/try:
console.log(XMLHttpRequest.DONE);

But this doesn't work in all Flowtype versions, even the last one 0.49.1 :disappointed:
I have tracked it down to lib/bom.js and here is something strange:
declare class XMLHttpRequest extends EventTarget {
  responseBody: any;
  status: number;
  ...
  statics: {
    create(): XMLHttpRequest;
    LOADING: number;
    DONE: number;
    ...
  }
}

Is the statics section an intent?
If so, should we have to fix our code to something ugly like this? flow.org/try:
console.log(new XMLHttpRequest().statics.DONE);

Thanks

Update<EMAIL_ADDRESS>works as in 0.48.0
It's duplicate of #4206


The type json is missing from the html documentation

What is the issue you have?

The examples in the README mention type json as the most basic type to use by default in order to use the library. The problem is that the linked documentation https://nlohmann.github.io/json/classnlohmann_1_1basic__json.html does not document this type.
This is certain to confuse anyone newbie. I'm willing to bet a beer that you are loosing 20% of newcomers because of this, particularly those who are new to C++.
Note: This is not about whether I can find the information for myself. I found out from the code that json is defined as "using json= basic_json<>;" and looked up the docs of basic_json. This is a quality of documentation issue that affects others.

Please describe the steps to reproduce the issue. Can you provide a small but working code example?

Look at the README and try to use the library. Then try to look up members of type json in https://nlohmann.github.io/json/classnlohmann_1_1basic__json.html.

What is the expected behavior?

I expect https://nlohmann.github.io/json/classnlohmann_1_1basic__json.html to  contain documentation of the json type (for example mentioning that json is a typedef for basic_json).

And what is the actual behavior instead?

https://nlohmann.github.io/json/classnlohmann_1_1basic__json.html does not document the name json.

Which compiler and operating system are you using? Is it a supported compiler?

all OSes and compilers

Did you use a released version of the library or the version from the develop branch?

The released version.

If you experience a compilation error: can you compile and run the unit tests?

no

This is the first time I heard of someone asking for documentation of the json type. Right now, it is this: https://nlohmann.github.io/json/namespacenlohmann_a2bfd99e845a2e5cd90aeaf1b1431f474.html#a2bfd99e845a2e5cd90aeaf1b1431f474
What do you expect instead?

One correction: When I copied the documentation link, I meant https://nlohmann.github.io/json/, not https://nlohmann.github.io/json/classnlohmann_1_1basic__json.html. I'm not sure where the latter came from. So I meant that your html documentation in general doesn't have the json typedef documented.
You link https://nlohmann.github.io/json/namespacenlohmann_a2bfd99e845a2e5cd90aeaf1b1431f474.html#a2bfd99e845a2e5cd90aeaf1b1431f474, and it is indeed there, I stand corrected in that respect. I didn't find it at the time though and I still think this is a usability issue.
Neither the main docs page (https://nlohmann.github.io/json/index.html) nor README links to it. You can find it by typing it into the search bar on the docs page, but I can't find it through google.

This is the first time I heard of someone asking for documentation of the json type.

I don't think that it is a particularly good measure of a need in a situation when everyone who doesn't find what he's looking for has a ton of alternative libraries. I understand how you could think that in the absence of other feedback though.

What do you expect instead?

I thing you should link to this type (json, not basic_json) from as many places as possible, because this is the central type to your library. From my experience in the industry, the people who don't really know C++ but need to use it outnumber those who really know it 5 to 1. They won't automatically know that json is basic_json.

🔖 Release item
This issue/PR will be part of the next release of the library. This template helps preparing the release notes.
Type

[ ] ✨ New Feature
[ ] 🐛 Bug Fix
[ ] ⚡ Improvement
[x] 🔨 Further Change
[ ] 🔥 Deprecated function

Description

Mention json type on the documentation start page.

I added a note to the API documentation. It will be part of the next release.


Add storage class support

Closed for supported in https://github.com/yunify/qscamel/commit/9cd0e6268025059e86f888c7e1d3d55436581b65 .


Run CRI integration tests in GitHub Actions

As suggested at https://github.com/containerd/containerd/issues/4878#issuecomment-814132549, and enhancing #5039.
I figured this was less work and less-costly than actually getting AKS and GCP accounts set up to let me run the CRI tests via the periodic job, and I don't have a regular Windows Server machine at-hand to run the tests directly anyway.

The two Linux-side test failures in the test run seem likely to be flakes. Both failed in the same two tests, TestContainerKillInitPidHost and TestContainerKillInitKillsChildWhenNotHostPid nothing I changed here should have affected that.
These failures didn't occur on the run for the same code in my fork.
The Windows Server 2022 failure is probably also a flake, as it was a bunch of failures in the cri-integration tests that I hadn't seen in either the above run on my fork, or the earlier run before I added critest.
That said, I was curious to see if I was going to see a failure I did see in my fork's last couple of runs, but it happens in cri-tools and so is later that the failure I hit here.
[Fail] [k8s.io] Streaming runtime should support streaming interfaces [It] runtime should support exec with tty=true and stdin=true [Conformance]
github.com/kubernetes-sigs/cri-tools/pkg/validate/streaming.go:203

I will push a minor change (I didn't allow for cri-test run-time when I bumped the job timeout) and see if run comes out differently.


Removing ThreeJS

I see you are using THREEJS for the CRT filter. If that is the case using a css filter will save you lots of space, or I can make a WebGL wrapper that only executes that shader without any THREEJS code. Let me know if you are interested.

CSS wouldn't do it because I want the screen to be warped like a TV screen, which (I believe) CSS can't do.
Also, I'm using Three.js's bloom effect in addition to my custom shader.
So I'd be happy to switch to a WebGL solution if it kept these 3 things (warped TV screen, bloom and my noise+scanlines shader). That would allow me to get rid of THREE.js, which is a huge dependency!

Ah! That's amazing! However, I'd rather wait until CSS support for custom filter hits the mainstream browsers (if I understand correctly, it needs Chrome Canary and etc).
I think I'm ok keeping Three.js for now, but maybe I'll revisit the idea of doing it in pure WebGL in the future.

ok then, btw: https://caniuse.com/css-filters

@btco just curious, did you read the date on the Chrome article provided? It was written in 2013 and last updated in 2020. I'd say CSS filters are very much supported in all major browsers.

Yes! But if I understand correctly (from the article and from more
research), CSS filters are widely supported but only built-in filters like
blur, etc, not custom shader-based filters (which is what we'd need).
For shader-based filters to work (custom filters), apparently browsers need
to be compiled with a special flag, so shader-based filters aren't
generally available to users.
Unless I'm missing something... I did try custom shader-based filters on
Chrome and Firefox on two of my machines and it didn't work on any of them.
Only the default filters work.
Thanks!!
Le ven. 27 oct. 2023 à 21:34, Oskar Löfgren @.***> a
écrit :

@btco https://github.com/btco just curious, did you read the date on
the Chrome article provided? It was written in 2013 and last updated in
2020. I'd say CSS filters are very much supported in all major browsers.
—
Reply to this email directly, view it on GitHub
https://github.com/btco/qx82/issues/1#issuecomment-1783410802, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBXHTDAWP2KSI4DNFN3LRLYBQEEHAVCNFSM6AAAAAA52DSSXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGQYTAOBQGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ah, you're right. My bad.


[FLINK-28035] Don't check num of buckets for rescale bucket condition

For an ordinary read-write job, the scan will check the numBuckets read from manifests against the current numBuckets, to avoid data corruption. See FLINK-27316.
For rescale-bucket rewrite, we should allow the rescale task to read the data as the old bucket number and rescale according to the new bucket number.

Why just check for rescale? Throws exception for normal reading?

I don't think we should treat rescale specially, our aim is to liberalize all reads and any partition with any number of buckets can be read.


Searching for flights at a specific Airport

Hello everyone
we did last week some updates - thank you for your work!
Now it looks like we have an issues and we don't know where these issue is coming from.
e.g.

we are looking for flights from a specific airport in this example LOWS
we want to step forward to the next page to see other flights
3 after pressing page 2, we can see "page 2" of "ALL FLIGHTS" we have in our VA

Any Idea what we can do?
Thanks for helping!
latest updated we did:
2022_07_20_174615_update_disposable_specs_table .................. 23ms DONE
2022_09_04_064836_create_disposable_whazzup_checks_table ......... 33ms DONE
2022_12_24_185438_update_disposable_whazzup_checks_table ......... 14ms DONE
2022_12_26_104800_add_new_autoreject_settings ..................... 3ms DONE
2023_01_14_093508_update_network_presence_settings ................ 4ms DONE
2023_01_15_100518_add_enr_margin_setting .......................... 2ms DONE

Confirmed with default theme too, phpvms simply disregards search results for pagination and it reverts back to flights display.
By the way; latest updates done to addons have no relationship with this issue as the data of this page is controlled/provided by phpvms itself. (addons only provide additional features after page generation, like map buttons and visual improvements etc)

Thanks for the feedback. So we have to hope for a FIX in the future as you told me on discord?

Exactly, I will look into it too... And if I can find the cause I will let @nabeelio know :)

This is caused by #1515 , needs to be checked why it is resetting the request for paginated results. I had no time during the weekend @nabeelio
Will try to check later.

thank you sir for the update!

Hello sir, I wanted to ask, if you had some time to check what caused the issue?
No stress, just wanted to know if we have to check for new updates.
Thank you!

No, due to the earthquake crisis I had zero time to check/investigate :(
Best wishes,
Dispo
Sent from mobile device / Mobil cihaz ile gönderildi
15 Şub 2023 Çar 15:28 tarihinde nobleaviation @.***>
şunu yazdı:

Hello sir, I wanted to ask, if you had some time to check what caused the
issue?
No stress, just wanted to know if we have to check for new updates.
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/nabeelio/phpvms/issues/1521#issuecomment-1431293294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARXKVMIP5SKT7CLTWQ4UHKLWXTDW5ANCNFSM6AAAAAAURBJXAI
.
You are receiving this because you commented.Message ID:
@.***>

All fine, stay health and all the best!!!

See the fix in this PR I made. It's a simple one-line fix. https://github.com/nabeelio/phpvms/pull/1525
{{ $flights->appends(\Illuminate\Support\Facades\Request::except('page'))->links('pagination.default') }}

Thank you sir!!!
Taylor Broad @.***> schrieb am So. 5. März 2023 um
01:37:

See the fix in this PR I made. It's a simple one-line fix. #1525
https://github.com/nabeelio/phpvms/pull/1525
{{ $flights->appends(\Illuminate\Support\Facades\Request::except('page'))->links('pagination.default') }}
—
Reply to this email directly, view it on GitHub
https://github.com/nabeelio/phpvms/issues/1521#issuecomment-1454938389,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYOXXZ3F6VXJXU23OZICKQLW2PN4PANCNFSM6AAAAAAURBJXAI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Flying regards
Christoph
Noble Aviation Team
www.noble-aviation.com
https://www.facebook.com/NobleAviationVA
https://www.instagram.com/nobleaviationvirtualairline/
https://discord.gg/9p2DBm7sEk


Unify @testset and @testloop ?

The new testing framework is really great, but I thought that @testset and @testloop can be unified into a single macro. For example, the latter can be interpreted like @testloop:
@testset begin
    @test ...
end

@testset for i in 1:10
    @test ...
end

Since macros can detect the type of given expression block, I think rewriting @testset for ... to a loop test is not so difficult.

Could you open this on Julia itself? It is a good point!

I opened an issue at https://github.com/JuliaLang/julia/issues/14011 :smiley:

This was done (and its great!)


Announcing TwitchJS, a community-centric, community-supported version of tmi.js

To help development, I have created a new clone of tmi.js called TwitchJS (Github, NPM). I have already merged in 8 of 10 open PRs and published the module on NPM.
Anyone who submits a PR that meets all the contribution guidelines (basically passes tests without much involvement from existing contributors) will receive merge rights. As such, I have already sent out collaborator invites to those authors whose PRs were merged.
Current maintainers include:

me
@mBeierl tmijs/tmi.js#237 > marcandrews/twitch-js#1
@AlcaDesign
@haganbmj tmijs/tmi.js#255
... with invites sent out to:
@mccxiv tmijs/tmi.js#255 > marcandrews/twitch-js#4
@Schmoopiie
@Borengar tmijs/tmi.js#263 > marcandrews/twitch-js#5
@HKK13 tmijs/tmi.js#246 > marcandrews/twitch-js#3

Please feel free to make issues and PRs for TwitchJS and hopefully we can keep this code alive.

Isnt that library geared towards extensions while tmijs is geared towards IRC communications.  What we could use is everyone to maintain a large Twitch API library that encompasses entire API

@spesvictus TwitchJS is tmi.js, with the latest PRs merged.

You completely missed the point. We don't need tmi.js clone or remade. We need Library designed from ground up to take full advantage of Twitch API not just irc.  People could be helping twitch-helix library include webhooks.

@spesvictus This is not the goal of TwitchJS at the moment. The problem we have right now is that there are many talented developers willing to contribute, but the maintainers of tmi.js do not have capacity to review and merge work.
Other libraries (twitch-helix, etc.) already suffer from the same issues as tmi.js; one maintainer, few contributors, no CI/CD, no Webpack support, no browser support. tmi.js is an amazing and arguably the most popular Twitch library. It is an ideal base for future development.
TwitchJS aims to solves this problem by having Twitch API library that is developed, maintained and supported by the community. To help with this, I am adding a lot of continuous-integration and delivery features:

automated linting
automated tests
automated coverage reports
automated deployments to NPM
maintainers and collaborators to help the process along

It's all about allowing developers to focus on writing code (instead of worrying about deploying delivering). Once we achieve CI/CD, I will make a Helix branch so we can start working towards the new API. We have a year so don't worry :stuck_out_tongue_winking_eye:
@artemisbot I agree totally, but if someone wants to add functionality, he/she can put up a PR and have it reviewed by the community.

I hope TwitchJS library will change their name to more suitable. There is confusing between TwitchJS and Twitch-JS
So this new library is just rebranding community focused tmijs? All I want is something that can handle entire Twitch API. Tired of using multiple libraries to do one job. And it doesn't introduce bloat.

You are welcome to submit a PR

@spesvictus Just came across your comment looking for a bugfix in TMI.js . I'm currently developing what you are asking for, a full twitch integration lib with chat irc (using tmi.js), new helix api support, pub/sub notification and soon, extensions. It's currently in a early stage but I will submit a new project sometime this week so people can contribute.


Assertions disabled in GDCM builds on Mac

There are some - likely invalid - assertions in GDCM that make the
DICOM plugin and several unit tests crash. The faulty code is invoked
by itk::GDCMImageIO::CanReadFile.
Signed-off-by: Miklos Espak<EMAIL_ADDRESS>

Already merged, thank you.


Enhancement: Consider supporting ULID

Summary
Determine if adding a ULID data type is feasible at this point.
Basic Example
No response
Drawbacks and Impact
No response
Unresolved questions
No response

Funding

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified

Maybe you want to also/instead consider the newly proposed UUIDv7.
There is a RFC draft (already rather close to acceptance) that standardizes these.
Should be very similar to ULID, except for the 6 bits that are reserved for UUID version and variant and therefore 74 random bits instead of 80.


Node process exiting on certain combination of error handlers and async middlewares

Our application was failing on Production with the node process exiting with error code 1. I was able to reproduce the error in a minimal example.
Even though the original issue was an application issue (sending an undefined http status in the response), it might also make sense to check why the process is exiting in this case.
Minimal example:
const express = require("express");
const app = express();

app.use(
  "/kill",
  (req, res, next) => {
    console.log("1. throw error");
    throw new Error("oops");
  },
  (err, req, res, next) => {
    console.log("2. try to handle error and send back undefined/invalid HTTP status");
    res.status(err.status).send("Error"); // err.status is undefined
  },
  (err, req, res, next) => {
    console.log(
      "3. have an error handler not catching the 'ERR_HTTP_INVALID_STATUS_CODE', so default error handler will not be used"
    );
    next();
  }
);

app.use(async (req, res, next) => {
  console.log("4. have an async middleware trying to send back a sth.");
  // do some async stuff here, read a file and transform it
  res.send("[the file]");
});

const server = app.listen(3000, () => {
  console.log(`Example app listening at http://localhost:3000`);
});

package.json
{
  "name": "xxxxx",
  "version": "1.0.0",
  "scripts": {
    "start": "node index.js",
  },
  "dependencies": {
    "express": "^4.17.1"
  }
}

Node Version
v15.14.0
How to bring it up
npm install
npm start

Open browser and navigate to http://localhost:3000/kill
See terminal how process exits with ERR_HTTP_INVALID_STATUS_CODE.
Output
node:internal/process/promises:245
          triggerUncaughtException(err, true /* fromPromise */);
          ^

RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: undefined
    at new NodeError (node:internal/errors:329:5)
    at ServerResponse.writeHead (node:_http_server:282:11)
    at ServerResponse._implicitHeader (node:_http_server:273:8)
    at write_ (node:_http_outgoing:769:9)
    at ServerResponse.end (node:_http_outgoing:858:5)
    at ServerResponse.send (/xxxxxxxxx/node_modules/express/lib/response.js:221:10)
    at /xxxxxxxxx/index.js:25:7
    at Layer.handle [as handle_request] (/xxxxxxxxxx/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/xxxxxxxx/code/mic/demos/09-express-failing-process/node_modules/express/lib/router/index.js:317:13)
    at xxxxxxxxxxxxxx/node_modules/express/lib/router/index.js:284:7 {
  code: 'ERR_HTTP_INVALID_STATUS_CODE'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     xxxxxxxxxxx-debug.log

Yes, throwing an error from an asynx peocess will lead to Node.js existing, regardless of if you are using Express or not, as this is a general Node.js behavior. You have to set up the Node.js things lile https://nodejs.org/dist/latest-v16.x/docs/api/process.html#process_event_uncaughtexception and https://nodejs.org/dist/latest-v16.x/docs/api/process.html#process_event_unhandledrejection
If you upgrade to Express 5, async middleware is supposrted there and your example will be caught by the framework, though you can still end up in sotuations where there are uncaught exceptions and still should set up the appropriate Node.js mechanisms I linked above.

@dougwilson Thank you for your feedback. We have added the process event handlers to our application.

No problem. I forgot to mention in my firsr response, but depending on how you run your application, you may want to ensure if it does crash, it restarts as well. You may already have this and even with this a crash is still going to break things (unlike the process handlers). This is because there are conditions (like segfaults) that don't trigger any handler in Javascript.
Also to add, please if you are able, try out our Express 5 release. It is functionality stable, but lacks much user feedback. We have a guide on any changes from 4 to 5 here: https://expressjs.com/en/guide/migrating-5.html


Request: Add support to Forerunner 45S

hi,
would it be possible to add support to the Garmin Forerunner 45S?

According to the documentation of the API the Forerunner 45 and 45S do not support watch apps.


Reproducible rust bindings

Makes bindings generated for rust use bindgen to be able to update them easily
PR description TBD

Hello. I really like the general direction of this PR; that is, generating the bindings directly using bindgen. I left some review comments on the PR.

That said, I feel like this PR is also doing some other stuff? It's adding another type KzgCommitment (along with KZGCommitment) and using that as its public type? Or something along those lines?
Should this be done as part of this PR? Or should we first merge the bindgen stuff, and then open a new PR for the new type? Or the new type is necessary for bindgen to work?
I guess some more documentation would be helpful to dispell these questions.

Finally, I guess a review from @pawanjay176 would also be useful here.

Thanks for the fast review. I opened this PR too late in my TZ and too tired to provide a more complete explanation.
So first thing to notice is that the current  bindings are a heavily edited version of the actually generated bindings. The first bindings version actually looked like this: commit within original pr. The difference between the current bindings and the ones in this PR are better viewed commit by commit in this pr (this is the way I intended this PR to be read, sorry for the lack of instructions there). The important differences are highlighted in this commit
As you can see, the differences are

types were private, now public. This change was made in the current bindings by hand in this commit
const vs mut pointer were changed by hand here
constants used in definitions vs integer literals. This change was made by hand here
KZGCommitment and KZGProof as structs, not type aliases: This change was made by hand in this PR
This one might be hard to spot so I'm pasting a screenshot

Now this last change is the only one that I could not make using bindgen. The rest of the by-hand cleanup are now simple bindgen instructions. I agree that the change is necessary to help with type safety. This is the reason why I introduced the types KzgProof  and KzgCommitment. These are the publicly exposed types and are the only notable difference between the current and proposed bindings. There is no way to mistake them outside the crate simply because they are not exposed, and there is no way to mistake them inside the crate because the compiler will complain loudly.
I'll address the rest of your comments individually, but I hope this help to better explain and understand the proposed changes

Thanks @pawanjay176 . I guess I didn't directly respond to @asn-d6 's question about whether this is necessary or can be addressed in another PR. This is necessary. Since the KZG* types are type aliases, a good part of the functions we implement over them are duplicated. To make that work within this PR without introducing the new types, we would need to remove functions like to_bytes, from_hex etc to prevent the duplicates. We would then re-add the functions in a new PR. I find the change of introducing the types here less disruptive since they align with the state of the current bindings

Are there better names that can be given to those two types? So that the difference is more clear and does not hide into the capitalization?

We can so something very explicitly like adding them as PublicApiKzgCommitment and re-export them with the nice KzgCommitment to make development easier. It's to note tho, that if this crate is published, an user that goes to the documentation of KzgCommitment, they will land in a page that has the explicit (but ugly) PublicApiKzgCommitment name.
Another option is to internally alias KZGCommitment to BindingKzgCommitment and use this name instead of the upper case , easy to mistake one here in the crate. This sounds like a better solution to me.

If no better names exist, can we please thoroughly document these types and their difference?

I can try to improve docs on this whatever way we go. Not sure how but probably something can be done
What do you guys think is best? What's your preference

I just updated this, blocklisting the type aliases and replacing them with custom implementations, which makes the bindings in this PR even closer to the current ones, and removed the existence of two similarly names types

I just updated this, blocklisting the type aliases and replacing them with custom implementations, which makes the bindings in this PR even closer to the current ones, and removed the existence of two similarly names types.
Let me know if this is something that works better

Honestly this is great. IMO this new approach is much more tidy. I guess the only downside is that we are being a bit naughty doing repr(C) stuff outside of the FFI boundary.
I'm gonna go ahead and ACK this. Let's merge this early next week unless there any new concerns get generated.
Thanks a lot @divagant-martian for being meticulous here :)


Added a tool to get to parent dir

Added a tool that makes reaching a parent directory of a given directory easier

@stevevanhooser

Thanks! This does exist in Matlab though.
See Matlab function
fileparts
Best
Steve


Switch to another test-rpc tool for running tests

Ganache-cli is deprecated and sunset.
We have the following candidates for replacement:

anvil

Requires changes to tests as deployments are not instant.
signing a transaction is not supported.

hardhat nodes.

Current issues with anvil:

eth_signTransaction is not behaving as expected (Fix pending in https://github.com/foundry-rs/foundry/pull/7804)
There is a delay after a transaction is received by anvil until it is part of the next block. Doing a quick lookup after eth_sendTransaction to get the transaction receipt will result in a transaction not found error.

* There is a delay after a transaction is received by anvil until it is part of the next block. Doing a quick lookup after `eth_sendTransaction` to get the transaction receipt will result in a transaction not found error.

btw the default action in anvil is to do "interval mining", to disable this use --no-mining
$ anvil
[...]
      --no-mining
          Disable auto and interval mining, and mine on demand instead

          [aliases: no-mine]
[...]

@BlazeWasHere Thanks for the info. I think I tested the --no-mining switch and what it does is that it requires you to explicitly call the mine function every time you want to mine a new block.
Actually I now realize my description of this issue is also wrong. This issue only seems to occur for transactions which are deploying a new contract. Other transactions are mined instantly.

@BlazeWasHere Thanks for the info. I think I tested the --no-mining switch and what it does is that it requires you to explicitly call the mine function every time you want to mine a new block.
Actually I now realize my description of this issue is also wrong. This issue only seems to occur for transactions which are deploying a new contract. Other transactions are mined instantly.

whoops i gave the wrong info there (sorry was late at night)... the default action is to auto mine (on new transaction sent) not interval mining, and yes --no-mining required calling evm_mine

Actually I now realize my description of this issue is also wrong. This issue only seems to occur for transactions which are deploying a new contract. Other transactions are mined instantly.

i think the issue is down to how quick the local network is, Ethers.deployed_address/2 does a one-shot query of eth_getTransactionReceipt however, due to anvil being ran locally, the query is ran before the block has been mined by the background miner thread. albeit slightly misleading, auto mining does not block eth_sendTransaction to mine a new block, instead the miner thread mines as soon as it receives the new transaction.
this can be confirmed on linux using netem (or just run anvil on a remote server)
# adds a 1ms delay to all outbound packets on loopback interface `lo`
$ tc qdisc add dev lo root netem delay 1ms
$ anvil &
$ mix test
# remove the delay made above
$ tc qdisc del dev lo root

i guess a solution is to poll and wait for eth_getTransactionReceipt to return the transaction receipt?

That seems like a good explanation. We did not have these issues with ganache probably because it is single threaded and we can be sure that a block was mined when we get a response back from send transaction.

i guess a solution is to poll and wait for eth_getTransactionReceipt to return the transaction receipt?
ethersjs has provider.waitForTransaction() and transaction.wait()

Yes, if not in the lib itself, we need something like this (probably using Process.sleep as we don't have websockets) to wait for transactions to be mined in tests. This can especially become a problem in CI where resources are very limited and we might start seeing random failures (flakey tests).


Remove installation instruction for Swift 2/watchOS 2

How do you access KeychainAccess from watchOS? I installed this library through cocoa pods but can't do let keychain = Keychain(service: bundleIdentifier)
without it saying that it can't recognize identifier. same line works on the iOS target

@acegreen What happens? Compile error? or Runtime error? Could you please show me more details.

KeychainAccess should work on watchOS 2. This PR just remove pre-release section.

This is the error:

Only appears on watch extension

Podfile configuration along with how it looks in my project

It has failed to setup. CocoaPods link only first target by default if a project has multiple targets. You should write pod ... to each target or use link_with to link multiple target.

I tried various other options:
Option 1:
use_frameworks!
def shared_pods
pod 'KeychainAccess'
end
target 'Chronic' do
platform :ios, '8.0'
pod 'CNPPopupController'
pod 'DZNEmptyDataSet'
shared_pods
end
target 'Chronic WatchKit Extension' do
platform :watchos, '2.0'
shared_pods
end
Option 2:
use_frameworks!
pod 'KeychainAccess'
pod 'CNPPopupController'
pod 'DZNEmptyDataSet'
Pod::Spec.new do |s|
…
s.watchos.deployment_target = '2.0'
end

Please try like following:
source 'https://github.com/CocoaPods/Specs.git'

inhibit_all_warnings!
platform :ios, '8.0'

target 'ExampleApp', :exclusive => true do
  pod 'KeychainAccess'
end

target 'ExampleApp WatchKit Extension', :exclusive => true do

end

target 'ExampleApp WatchKit 2 Extension', :exclusive => true do
  platform :watchos, '2.0'
  pod 'KeychainAccess'
end

what about use_frameworks!?

Or could you send your project tome to further investigation?

@acegreen Sorry, use_frameworks! is needed. I forgot it since above sample was copied from my ObjC project.

So I updated my Podfile as such
source 'https://github.com/CocoaPods/Specs.git'
inhibit_all_warnings!
platform :ios, '8.0'
use_frameworks!
target 'Chronic', :exclusive => true do
pod 'KeychainAccess'
pod 'CNPPopupController'
pod 'DZNEmptyDataSet'
end
target 'Chronic WatchKit Extension', :exclusive => true do
platform :watchos, '2.0'
pod 'KeychainAccess'
end
and I got the warning I got before with one of my options (see image)

Now Keychain identifier not recognized on both targets

First, you should fix setup to follow messages of CocoaPods.

Or you can use other ways for setup. You can use pre-built framework https://github.com/kishikawakatsumi/KeychainAccess/releases or use Carthage https://github.com/Carthage/Carthage instead CocoaPods.

Ok will copy the prebuilt frameworks. for sync between iOS and Apple Watch do I need to enable iCloud sharing in my capabilities? Also do we need to set accessibilities to the keys?

After copying the prebuilt frameworks. the watch kit framework is causing the following error. though it was working for a little

You should error message carefully first. You are wrong, you link iOS framework to watchOS app target. You should link the framework built for watchOS.

No I was sure to put the right framework to the right target.

Can you send to me your project?

I can't do that. its a production project. Can you Skype for a few minutes?

Skype id: alelafy1989


Support for Template Sections

I can't seem to figure out a way to create a template with sections, and I'm not sure if it is supported.  I am trying to test some code that loops through all the fields on an item and builds a dictionary from all the fields in a particular section using the Section property of the field.
It would be nice to be able to do something like this:
new DbTemplate("TemplateName")
{
    new DbSection("Section1")
    {
        new DbField("Field1"),
        new DbField("Field2")
    },
    new DbSection("Section2")
    {
        new DbField("Field3"),
        new DbField("Field4")
    }
}

@rmatherly thanks for the request. AFAICT, the customizable sections are not supported. Historically, the Data section created automatically satisfied the testing needs, but I agree that your scenario requires more advanced section configuration.
I cannot promise you fast implementation, but I'm always open for a PR ;)

@sergeyshushlyapin thanks for the quick response and for creating such a helpful testing tool.  After putting some thought into it, I'm going to change the code to pull the individual fields.  I feel that the Sections in Sitecore are really meant as a means of visual organization for the Content Editors and probably should not be used as groupings in the code.  I'm closing this for now.


testbed for configu integrations

In preparation for v1, Ran and I have agreed to tidy up all open PRs. Since the testbed still requires additional work, we've decided to archive it for now and revisit it when it becomes a priority. I'll close this PR accordingly.


Include full YAML config after dashboard import

This will make it easier for everyone to make adjustments to the YAML config because the entire config will be imported into your ESPHome dashboard after adoption.

Awesome work mate!


Support for list extensions

Add following command line switches to vstest.console.exe:

/listDiscoverers
/listExecutors
/listLoggers
/listSettingsProviders

These will list the corresponding test platform extensions. They are added for compatibility with earlier version of vstest.console.exe.

What is the behavior when running using dotnet vstest?

@codito : I am assuming it will discover extensions from --TeatAdapterPath as well.

vstest.console.exe /TestAdapterPath:"Path\to\core-adapters" /listDiscoverers, will show the discoverer?

@smadala @Faizan2304 no, this scenario is not supported. In tpv2, the runner process doesn't load the external test adapters; they are always known in the test host (which is specific to user provided runtime). This is different than tpv1 which only supported test adapters authored in .NET full framework.


SetMediaClockTimer behavior

I have a few questions about SetMediaClockTimer RPC behavior:

What happens when media clock is started in COUNT_UP mode from 00:00:00 to 05:00:00, then paused and then resumed with a new end time of 06:00:00?  Will the clock use the original end time, or the end time that was sent along with the resume request?

What happens when media clock is started in COUNT_DOWN mode and timer approaches 00:00:00?  Does it stop there or start going negative?  I assume it will stop at 00:00:00, but is that documented anywhere?  Likewise, what happens when COUNT_UP approaches 59:59:59 and is that documented anywhere?

What happens when media clock is started, cleared and then started again (not resumed) with no input start/end times?  Will the request be rejected, or use the previously defined start/end times?

Start/end times are defined as optional in the spec, but do they become required for COUNT_UP or COUNT_DOWN?  Are both values required for each one?  Is this documented anywhere?

Does COUNT_DOWN allow stopping at a certain point other than 00:00:00?  If I do COUNT_DOWN with start time of 05:00:00 and end time 03:00:00, will that work?

I can work on testing some of these out, but would like responses on desired behavior so I can compare to actual behavior.  Thanks!

Found the answer to #4 in the MOBILE_API.xml spec.  StartTime is required for COUNT_UP and COUNT_DOWN, but EndTime is always optional.
      	endTime can be provided for "COUNTUP" and "COUNTDOWN"; to be used to calculate any visual progress bar (if not provided, this feature is ignored)
      	If endTime is greater then startTime for COUNTDOWN or less than startTime for COUNTUP, then the request will return an INVALID_DATA.
      	endTime will be ignored for "PAUSE", "RESUME", and "CLEAR"


Integrating the plugins AV input, Device Diagnostics, Network, Screen Capture, Timer to Thunder UI.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Nivedha340:x: deepakponnathYou have signed the CLA already but the status is still pending? Let us recheck it.


Bug Live Picamera - Rpi update

Hello,
Following an update of raspberry with this command "sudo rpi-update"
The live of the camera works but the image is no longer in color and is pixelated using this script
https://picamera.readthedocs.io/en/release-1.13/recipes2.html#web-streaming
No problems to report when taking a picture.
A solution for this live problem?
thank you very much

Hello,
After test, the image is directly correct with this code: https://picamera.readthedocs.io/en/release-1.13/recipes2.html#web-streaming
But when I add the line: "from threading import Thread " I notice it is at that moment that I lose the colorization of the image. And this following an update of Pi: "sudo rpi-update"
The code used with "Thread" : https://github.com/waveform80/picamera/issues/389
Thank


add documentation for overwriting behaviour of in-place application of real-input fft plans

As noted in JuliaMath/FFTW.jl#158, application of inverse plans of real-input ffts via mul! or ldiv! potentially overwrites the input array.
This might be quite unexpected to many people (including me), especially since this is not the case for the complex-input versions.
This PR is an attempt at documenting this behaviour.

I thought that irfft destroying its input was an FFTW library thing and not an issue of FFTW.jl. Right?

Yes I think it's an FFTW library thing.
Still worth documenting here, I believe.

bump on review


Namespacing of modules

Hi
I have a setup where I use storybook to showcase components. In order for me to be able to push the components directly to a Salesforce org they need to be present in the "force-app/main/default/lwc" folder. That means when I run my local server, the components is not registered under the namespace "c" as they are when deployed to Salesforce.
Would it be possible to include an option to define a namspace for each module definition like showcased below?
"modules": [         {             "dir": "src/demoComponents"         },         {             "namespace": "c"             "dir": "force-app/main/default/lwc"         }     ]
Best
Rasmus

Thanks for opening the issue. This package delegates module resolution to the @lwc/module-resolver package, which actually lives over in the lwc repo.
Could you explain more about the problem you're running into exactly? I don't quite understand the problem space or the solution you're proposing. Thanks!

When having a Salesforce project, LWC components must be placed in a folder structure like "force-app/main/default/lwc/". When these components is deployed to a Salesforce org, you must refer to the component like "" So all components is given a prefix of "c".
In the same project structure, I am running LWC open source to do local development and showcasing of these components in Storybook. Since my components is placed in the given folder structure "force-app/main/default/lwc/", I am not able to refer to them, as on the Salesforce platform, using  "".
I would like to override the prefix of the components names, when the module resolver pick up the components.
Imagine that i could define a namespace like this is the lwc.config.json
 {  "namespace": "c",  "dir": "src/modules"  },
It can be done on single components ( https://github.com/salesforce/lwc/tree/master/packages/%40lwc/module-resolver#alias-module-record), but i would like to do it for all components no matter what folder structure they are placed within

Something that I did in the past was just to symlink force-app/main-default/lwc to my-lwc-oss-folder/c, and the use that one for Storybook.

Something that I did in the past was just to symlink force-app/main-default/lwc to my-lwc-oss-folder/c, and the use that one for Storybook.

I agree that it could fix the problem, I just think it would be nicer if the module resolver would support this as configuration instead

Agreed. I did a quick search on GitHub and found a mod that actually provides what you're looking for.
https://github.com/lukethacoder/lwc-module-resolver

Agreed. I did a quick search on GitHub and found a mod that actually provides what you're looking for.
https://github.com/lukethacoder/lwc-module-resolver

Thanks for finding the fork from lukethacoder! I still hope they will consider to add the support in the original package :)

This would greatly help our LWC development process as well!


Process ordering

Implement support for adding index to processes such that they can be started in specific order.

@iffyuva can you have a look?

@gnufied i looked at this PR today morning, and PR looks good. only concern is backward compatibility. let me try out this branch for couple of projects, and i will let you know. thanks.

I think it should be 100% backward compatible, the only change that users not using this feature will see is - 1s delay between starting their processes. I added that because, sometimes when processes are dependent - it is a good idea to introduce some delay between starting them. But we can probably drop it too.

Just curious. Can two processes have the same index?
[postgres]
directory = /Users/nisanth/code/SupportBee-Rails
command = /Users/nisanth/.pgvm/environments/current/bin/postgres -D /usr/local/var/postgres
index = 1

[redis]
directory = /Users/nisanth/builds/redis-2.4.2/src
command = ./redis-server /usr/local/etc/redis.conf
index = 1

[rails]
directory = /Users/nisanth/code/SupportBee-Rails
; Depends on redis and postgres
command = bundle exec rails s
index = 2

Yeah they can, in which case they would be ordered by order in which they were parsed.  In fact if a process has to no index, currently it is assigned 0 index.

It may be worth assigning higher index for processes without explicit index, rather than 0. @nisanth074  what you think?

@gnufied If I add a process which doesn't depend on anything else
[postgres]
directory = /Users/nisanth/code/SupportBee-Rails
command = /Users/nisanth/.pgvm/environments/current/bin/postgres -D /usr/local/var/postgres
index = 1

[redis]
directory = /Users/nisanth/builds/redis-2.4.2/src
command = ./redis-server /usr/local/etc/redis.conf
index = 1

[rails]
directory = /Users/nisanth/code/SupportBee-Rails
; Depends on redis and postgres
command = bundle exec rails s
index = 2

[faye]
directory = /Users/nisanth/code/SupportBee-Rails
; We used to use faye for push events
; I'd intuitively expect faye to be started immediately
command = bundle exec faye

I'd intuitively expect the process to be started immediately. Hence I feel defaulting to 0 index for processes without explicit index is fine.

couple of things to discuss:

index can be implicit, ie order in which processes appear in ini file is the order in which we can assign an index, and start processes
should invoker list show index of process?


Resolve OpenCorporates ID to LEI mapping issues in Open Ownership Register

Following work on https://github.com/openownership/register-sources-oc/issues/8, we have been made aware of mapping issues in the OpenCorporates to LEI mapping files. These have been examined and resolved by the OpenCorporates and GLEIF data quality teams now, so the issues should be resolved in the OpenCorporates bulk data files which Open Ownership receives each month.
This ticket is for us to take remedial action to replace all of the LEIs in our BODS datasets with the correct ones mapped to OpenCorporates IDs.

Migration Plan for LEI Flush

[ ] stop Ingester PSC streamer in Heroku
[ ] delete add_ids index in Elasticsearch
[ ] create add_ids index in Elasticsearch
[ ] deploy latest code container LEI changes
[ ] run Ingester OC to fetch latest LEIs for add_ids index
[ ] add new LEIs to PSC
[ ] add new LEIs to DK
[ ] add new LEIs to SK (probably none)
[ ] check LEIs in Elasticsearch for LEI scheme name (2) additions
[ ] remove old LEIs from PSC
[ ] remove old LEIs from DK
[ ] remove old LEIs from SK (probably none)
[ ] check LEIs in Elasticsearch for LEI scheme name original removals
[ ] run rest of monthly bulk data import
[ ] check Register entity page IDs
[ ] start Ingester PSC streamer in Heroku


PLATFORM-7349 linter

Related issue(s)

Checklist

[ ] I have read the contributing guidelines.
[ ] I have referenced an issue containing the design document if my change introduces a new feature.
[ ] I am following the contributing code guidelines.
[ ] I have read the security policy.
[ ] I confirm that this pull request does not address a security vulnerability.
If this pull request addresses a security. vulnerability,
I confirm that I got green light (please contact<EMAIL_ADDRESS>from the maintainers to push the changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added or changed the documentation.

Further Comments

Codecov Report

:exclamation: No coverage uploaded for pull request base (fandom_master@7c84b64). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             fandom_master      #72   +/-   ##
================================================
  Coverage                 ?   74.56%
================================================
  Files                    ?      323
  Lines                    ?    18591
  Branches                 ?        0
================================================
  Hits                     ?    13863
  Misses                   ?     3731
  Partials                 ?      997

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Closed in favour of #81


How much we: support new users to understand the interface?

Conversation on 2024-07-18 Sprint Review surfaced the conversation about user support, questions:

do we need a "help" page?
do we need a tooltip / just in time strings?
do we need a video?

This should be tested in user testing of v1!

I think this will be resolved through #286, @harryaolson has some explorations on this theme in addition to the findings from our usability work.

We are goding ahead with a help bar and additional pages on gov.bc.ca. This has been included in the mockups, closing #277 and creating #317


Collecting Stats

Good morning,
In your readme you state dpinger can provide information to "Cacti, Nagios, Zabbix, etc."
How would you go about getting the dpinger stats to a monitoring tool? I would like to run dpinger on a mips linux based router. Compiling dpinger with static binary is no problem and everything seems to work. However I am not sure what the best way to get data to one of the monitoring tools.
Thanks!
Josh

Hey Josh,
To collect info with Cacti on the local host, you set dpinger up to write to a status file (-o option) and use a cacti script to pull the data at each polling interval. See cacti_home/scripts for examples. Or if you prefer SNMP or need remote monitoring, you can use net-snmp's extend functionality. See snmpd.conf.example for examples.
Denny


Check recent APIs for tracks (iOS 16 and +)

As a Pillarbox developer I want to better understand the track-related APIs at my disposal.
Acceptance criteria

AVPlayer track-related APIs have been checked.
New interesting APIs have been reported.

Tasks

[ ] Have a look at new track-related APIs and report interesting ones.

loadMediaSelectionGroup(for:) to retrieve a group for some characteristic (legible, audible). Will have to be wrapped into a dedicated publisher.


[WIP] Added version check for Hawkular Metrics to switch Hawkular Inventory REST API into Metrics.

Removed unused _check_inv_version method.
Added new methods to check metrics version.
packaging.version is used to compare version strings.

Lint report for commit 73e8eaff8f31462d83a3fe46ab6c47e4cd42771b:
mgmtsystem/hawkular.py:

:bangbang: Line 926:101: E501 line too long (104 > 100 characters)

tests/test_hawkular.py:

:bangbang: Line 152:1: E305 expected 2 blank lines after class or function definition, found 1
:bangbang: Line 269:1: E305 expected 2 blank lines after class or function definition, found 1
:heavy_exclamation_mark: Line 351:4: W292 no newline at end of file

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot

Lint report for commit 31117f4037a7cd16fc3976d633619247942531c1:
mgmtsystem/hawkular.py:

:bangbang: Line 926:101: E501 line too long (104 > 100 characters)
:bangbang: Line 978:101: E501 line too long (102 > 100 characters)
:bangbang: Line 989:101: E501 line too long (104 > 100 characters)
:bangbang: Line 1008:101: E501 line too long (105 > 100 characters)
:bangbang: Line 1011:101: E501 line too long (103 > 100 characters)
:bangbang: Line 1014:101: E501 line too long (115 > 100 characters)

tests/test_hawkular.py:

:bangbang: Line 152:1: E305 expected 2 blank lines after class or function definition, found 1
:bangbang: Line 269:1: E305 expected 2 blank lines after class or function definition, found 1
:heavy_exclamation_mark: Line 351:4: W292 no newline at end of file

:frowning: You might like to check the lint of your code :point_up:
No commit flaws detected.
CFME QE Bot


Update the migration guide in README

https://github.com/pygae/galgebra#migration-guide

[x] mention that we now only support Python 3, and the last version that still supports Python 2.7
[ ] mention that API has changed a lot since the old version, many properties and methods are deprecated, see changelog
[x] update the example import, remove the deprecated stuff

Can probably add sympy 1.6 to that list too

I assume you want to do this before releasing?

Only one bullet point left here.

Fixed by #423


Error Standardization: Workflow API

Richer errors in Dapr for the Workflow API.
Note: Please clone this issue and assign the clone of this issue to yourself if you would like to contribute to the error standardization efforts.
Scope of work

[ ] Choose 5-10 errors in the Workflow API to enrich. Ideally, cover as many errors as possible from the API.
[ ] Follow the steps outlined in this README for each error being updated

Definition of done

[ ] Update 5-10 errors in the Workflow API
[ ] Update the unit tests, if necessary
[ ] Write integration tests to cover each updated errors

Keep in mind
Unless a major version is being released and there is a solid reason for introducing backwards incompatibility, we can't change the API, meaning the HTTP and gRPC status codes, and the error codes must stay the same. An exception to this is the gRPC StatusCode.UNKNOWN which should be converted to a specific status.
See the kit errors pkg README for another usage example. For each error being updated, you can use the following helper functions to add error details, see the kit errors pkg for more details:

WithHelpLink()
WithHelp()
WithErrorInfo() - Required
WithFieldViolation()
WithDetails()

Reference PRs
Existing error standardization for:

State API
PubSub API

Requirement

A dedicated error code to represent when a Workflow is trying to be scheduled when it is already running

Presently, the way to catch this error is with the following in .NET, which is not a great Dev Ex.
try
{
    result = await workflowClient.ScheduleNewWorkflowAsync(...);
}
catch(Grpc.Core.RpcException ex) when
(ex.StatusCode == Grpc.Core.StatusCode.Unknown && ex.Status.Detail.Contains("an active workflow with ID"))
{
  ...
}


Can't find avalon-blockchain-connector-dev docke image

I wanted to deploy avalon through k8s and used the scripts in avalon/docker/k8s/fabric/blockchain-connector.yaml.
This depends on avalon-blockchain-connector-dev image, but I haven't built it.
'''
spec:
containers:
- image: avalon-blockchain-connector-dev:latest
name: avalon-blockchain-connector
'''
How to build such an image? Thanks.

I wanted to deploy avalon through k8s and used the scripts in avalon/docker/k8s/fabric/blockchain-connector.yaml.
This depends on avalon-blockchain-connector-dev image, but I haven't built it.
'''
spec:
containers:

image: avalon-blockchain-connector-dev:latest
name: avalon-blockchain-connector
'''
How to build such an image? Thanks.

In order to build the images please follow the https://github.com/hyperledger/avalon/blob/master/docker/k8s/fabric/README.md
Also, I would like to point out that due to recent changes, image built name would be "avalon-fabric-connector-dev" so please rename the image name in the pod/container definition for  blockchain-connector.yaml. I will rectify this and will raise a PR.
Let us know if it doesn't work for you.

Closing the issue as it was resolved by @pankajgoyal2


ACCSEC-22770 - validate biometrics before repository

Ticket

ACCSEC-22770

Description

Validate biometrics available before creating AppProtectionRepository
Update security version name and code

Commit message

fix: validate biometrics before repository

Testing

[ ] Added unit tests
[X] Ran unit tests successfully
[ ] Added documentation for public APIs and/or Wiki

          1 Error

:no_entry_sign:
Fix code convention problems

          1 Warning

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger


docs: Update a link for the struct link with a full list of configura…

…tion options for ${HOME}/.finch/finch.yaml
At this time, the following "the struct here" link in README.md was not updated.
For a full list of configuration options, check the struct here.

Therefore, this commit fixes the "the struct here" link to link the updated struct code.
Issue #, if available: N/A
Description of changes: Detail are described in the commit message.
Testing done: N/A

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi, @vsiravar
Thanks for comments !!!
I have fixed, so could you please review when you have time ?