Silence "deletion in progress" errors when deleting VRGs

Since we added a VRG on the secondary cluster we have a random failure when deleting the DRPC after relocate. When this happens, we find the PVC in terminating state on the secondary cluster, and the VR and VRG are never deleted.
This change attempt to avoid this issue by deleting the secondary VRG first, and deleting the primary VRG only after the secondary VRG was deleted.
During DRPC delete we expect to see these logs one or more times:
2024-12-02T00:29:23.243Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "d944591e-fcf5-4882-8143-2e2a8f0351fa", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:23.358Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "364798af-15c0-4bba-829e-ae9928fe2383", "reason": "secondary VRG manifestwork deletion in progress"}
...
2024-12-02T00:30:05.230Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "3353357f-3cf8-4a6f-bb16-8aa95f24aec1", "reason": "primary VRG manifestwork deletion in progress"}

Fixes #1659
Based on #1709 for testing.

So far it works (4 successful builds in 4 tries), but we need to avoid the noisy errors when the reconcile fails:
We have 18 errors - 15 errors for the secondary vrg:
2024-12-01T19:37:37.543Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "3041f0da-e705-450c-bdd1-e159ffcecef7", "error": "secondary VRG manifestwork deletion in progress"}
And 3 errors for the primary vrg:
2024-12-01T19:38:32.151Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "0f352732-07e2-40d5-bd3f-a9a97181d94a", "error": "primary VRG manifestwork deletion in progress"}
Examples errors for single workload during e2e flow:
% grep -E 'ERROR.+subscr-deploy-rbd-busybox' hub.log | grep 'in progress'
2024-12-01T19:37:37.543Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "3041f0da-e705-450c-bdd1-e159ffcecef7", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:37.563Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "54d47c7a-8cf9-4728-aa47-2f00c1fb8397", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:37.577Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "48d03d0f-6659-4a02-81ca-0fc52b80d298", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:37.623Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "22188374-06f7-4b6c-96c9-f108acd86632", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:37.637Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "84a59ea7-62a2-40d5-98c5-e25e9d56279a", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:37.681Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "3cca19b4-0747-4544-a3bb-ea34c9b727e5", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:37.852Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "76b0b07b-69aa-40a9-a94c-f3acd574945f", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:38.184Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "5e8cb110-d849-4664-9a5e-b002ed75433f", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:38.837Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "c789aa29-75ad-48c5-9914-6ec6d5e93e5a", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:40.133Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "60124950-d22f-4078-a0e2-385b6697e8bb", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:42.712Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "ed43d9d3-25b0-4839-b6b9-773dbf0a3361", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:47.845Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "f77bcf91-6d06-44af-8677-84c65ffcab94", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:37:58.101Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "b6baa97d-a743-4eed-9a4b-4f9e44241011", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:38:02.134Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "951f3169-cc3d-4719-9194-902e8aaf10c4", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:38:18.591Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "d9fd5fdb-3bab-45c4-9b10-8df9421f9f6e", "error": "secondary VRG manifestwork deletion in progress"}
2024-12-01T19:38:32.151Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "0f352732-07e2-40d5-bd3f-a9a97181d94a", "error": "primary VRG manifestwork deletion in progress"}
2024-12-01T19:38:32.235Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "f331b6f2-7d28-45b0-b535-55f9c7de4c7d", "error": "primary VRG manifestwork deletion in progress"}
2024-12-01T19:38:32.531Z	ERROR	controller/controller.go:316	Reconciler error	{"controller": "drplacementcontrol", "controllerGroup": "ramendr.openshift.io", "controllerKind": "DRPlacementControl", "DRPlacementControl": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "namespace": "subscr-deploy-rbd-busybox", "name": "subscr-deploy-rbd-busybox", "reconcileID": "44c5037e-1924-4d32-b052-3f87fc333520", "error": "primary VRG manifestwork deletion in progress"}

Example delete progress logs:
subscr-deploy-rbd-busybox
% grep -E 'Deleting DRPC in progress.+subscr-deploy-rbd-busybox' hub.log
2024-12-01T23:36:51.505Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "c01ff1e4-8f0e-4965-bc85-a06c1e888e36", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:36:51.689Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "40730143-531d-4c01-a205-1fa265aeb85e", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:01.520Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "283e2548-893c-4e70-955a-79aa185aea7d", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:11.535Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "3300dbfa-3414-4869-b89a-1b208f316553", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:20.181Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "1e2a0e90-fc1b-4fc5-bb7a-2d7b0cb80924", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:37:20.210Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "22293783-bfaa-41fd-8607-f23fb766355f", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:37:21.690Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "52abd33d-1c38-4412-9dfa-bf3902012599", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:37:24.290Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "1500677b-0659-4e91-a145-e005402c6c3c", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:37:31.701Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "aeaf71ef-fb5d-4ad3-8855-69e388b26652", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:37:41.711Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "4a364a82-edf0-44f6-9ca1-83aa4a1f0deb", "reason": "primary VRG manifestwork deletion in progress"}

subscr-deploy-cephfs-busybox
% grep -E 'Deleting DRPC in progress.+subscr-deploy-cephfs-busybox' hub.log
2024-12-01T23:37:21.706Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "710deb73-f89d-4557-9f98-12efa449698b", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:21.795Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "52415983-6e0c-41ae-8d6c-99c0d393e64c", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:21.810Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "7f026333-afe1-4adf-bbb2-4d00e402bb67", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:31.715Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "db3b5e31-9658-431e-8d6b-129cac4baf1d", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:41.724Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "0fa28897-6b86-4a30-b50f-5b2b0ec51b75", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:37:51.157Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "29ea23b2-fdff-40e3-890c-a636b7bd9eb6", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:37:51.185Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-cephfs-busybox","namespace":"subscr-deploy-cephfs-busybox"}, "rid": "85fd4847-09d9-4b08-8811-58e475875494", "reason": "primary VRG manifestwork deletion in progress"}

appset-deploy-rbd-busybox
% grep -E 'Deleting DRPC in progress.+appset-deploy-rbd-busybox' hub.log
2024-12-01T23:41:21.892Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "74aeb9cd-c645-4e62-ae65-6b0ac87ad796", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:41:21.912Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "7f4eb775-e6c2-42d3-9914-6074ddfe40f3", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:41:21.994Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "f98039b8-e832-4757-82ab-142c919bec4f", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:41:31.906Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "226d77d1-154b-405c-ab17-a5cbef4e7a78", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:41:41.919Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "825e8ca7-b036-4f05-bddd-99d36af2063d", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:41:50.413Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "e1a78c9f-b407-4630-a7b0-3afd3c25a194", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:41:50.488Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "5504c9c7-f7e7-4242-a2d7-fe574e5f8034", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:41:51.928Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "e8117c30-181a-445c-a2a9-c5d5d01f1549", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:01.937Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "a2148e49-34dc-4e19-a517-e3c9e88cff0c", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:11.946Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-rbd-busybox","namespace":"argocd"}, "rid": "290e5d98-54bf-4675-8f4c-f1dbda9d5361", "reason": "primary VRG manifestwork deletion in progress"}

appset-deploy-cephfs-busybox
% grep -E 'Deleting DRPC in progress.+appset-deploy-cephfs-busybox' hub.log
2024-12-01T23:41:56.734Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "61e812e0-586d-4731-9213-c7686f98010e", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:41:56.796Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "6b6039fd-ae64-4aaf-a980-24301bc5704b", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:42:06.744Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "9aa97171-9187-437c-b592-ff5ae27c77b9", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:42:16.777Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "5051f09b-599d-4e7f-87fd-3c15ca1c04d2", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:42:25.253Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "ce27df83-3e59-4603-93e3-be9de6148d58", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:25.377Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "5b9ece1d-9f03-4151-b1b2-ff3aed4148b0", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:25.421Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "edbfdf63-4b66-4bb2-86b3-8e881912cb64", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:26.789Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "c60662ad-f607-42ec-9257-15ddd51b8262", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:36.799Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "a6ef8580-5ead-493d-9074-97a3a02d3fdc", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:42:46.891Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"appset-deploy-cephfs-busybox","namespace":"argocd"}, "rid": "ceb0ea28-7758-4131-83e1-de6d6f68864b", "reason": "primary VRG manifestwork deletion in progress"}

disapp-deploy-rbd-busybox
% grep -E 'Deleting DRPC in progress.+disapp-deploy-rbd-busybox' hub.log
2024-12-01T23:38:11.672Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "3f1b9d98-9c0b-4f29-9087-dc92816d80ce", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:38:11.704Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "f9537542-da9f-4ac2-ac44-12c65f7a45fc", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:38:11.720Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "71f12186-502f-46b4-af6f-9bd1d2578e4e", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-01T23:38:17.247Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "19c9d72e-98c9-4ebb-81f1-09c68941702c", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:38:17.277Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "cbf17316-225d-44b2-89f8-cb5f0e610cd5", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:38:21.684Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "294d56a2-30d6-47b3-a106-bf2cff64d784", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:38:31.694Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "8a6122af-9c8e-4ff8-8dfd-14bf90af5ea1", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-01T23:38:41.705Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:194	Deleting DRPC in progress	{"DRPC": {"name":"disapp-deploy-rbd-busybox","namespace":"ramen-ops"}, "rid": "0c5b40a6-16cd-498d-85a7-77f91e90078a", "reason": "primary VRG manifestwork deletion in progress"}

Example run
The Disable step took 30-60 seconds. Before this change it took 30 seconds (when it worked).
--- PASS: TestSuites (0.05s)
    --- PASS: TestSuites/Validate (0.05s)
        --- PASS: TestSuites/Validate/hub (0.02s)
        --- PASS: TestSuites/Validate/c1 (0.02s)
        --- PASS: TestSuites/Validate/c2 (0.02s)
    --- PASS: TestSuites/Exhaustive (6.08s)
        --- SKIP: TestSuites/Exhaustive/disapp-deploy-cephfs-busybox (0.00s)
        --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox (461.72s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Deploy (5.15s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Enable (90.11s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Failover (150.16s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Relocate (150.18s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Disable (60.06s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Undeploy (6.05s)
        --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox (461.82s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Deploy (5.16s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Enable (120.26s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Failover (125.13s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Relocate (175.15s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Disable (30.04s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Undeploy (6.07s)
        --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox (531.06s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Deploy (1.37s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Enable (90.11s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Failover (214.91s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Relocate (169.51s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Disable (40.05s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Undeploy (15.11s)
        --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox (726.20s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Deploy (0.15s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Enable (95.24s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Failover (270.49s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Relocate (300.25s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Disable (60.05s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Undeploy (0.03s)
        --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox (761.05s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Deploy (0.14s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Enable (160.31s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Failover (300.27s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Relocate (240.22s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Disable (60.09s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Undeploy (0.04s)
PASS
ok  	github.com/ramendr/ramen/e2e	767.792s

Example run
--- PASS: TestSuites (0.05s)
    --- PASS: TestSuites/Validate (0.05s)
        --- PASS: TestSuites/Validate/hub (0.02s)
        --- PASS: TestSuites/Validate/c1 (0.02s)
        --- PASS: TestSuites/Validate/c2 (0.02s)
    --- PASS: TestSuites/Exhaustive (6.09s)
        --- SKIP: TestSuites/Exhaustive/disapp-deploy-cephfs-busybox (0.00s)
        --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox (522.23s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Deploy (0.21s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Enable (100.31s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Failover (210.24s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Relocate (150.37s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Disable (61.05s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-rbd-busybox/Undeploy (0.06s)
        --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox (522.91s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Deploy (5.29s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Enable (150.29s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Failover (120.15s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Relocate (185.40s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Disable (55.71s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-cephfs-busybox/Undeploy (6.07s)
        --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox (523.05s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Deploy (5.26s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Enable (90.17s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Failover (210.32s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Relocate (155.37s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Disable (55.85s)
            --- PASS: TestSuites/Exhaustive/subscr-deploy-rbd-busybox/Undeploy (6.06s)
        --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox (528.00s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Deploy (2.27s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Enable (90.26s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Failover (211.04s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Relocate (159.64s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Disable (50.08s)
            --- PASS: TestSuites/Exhaustive/disapp-deploy-rbd-busybox/Undeploy (14.71s)
        --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox (586.29s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Deploy (0.20s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Enable (135.34s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Failover (120.16s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Relocate (270.49s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Disable (60.08s)
            --- PASS: TestSuites/Exhaustive/appset-deploy-cephfs-busybox/Undeploy (0.03s)
PASS
ok  	github.com/ramendr/ramen/e2e	593.046s

Example deleting drpc progress logs
% grep -E 'Deleting DRPC in progress.+subscr-deploy-rbd-' hub.log
2024-12-02T00:29:23.243Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "d944591e-fcf5-4882-8143-2e2a8f0351fa", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:23.358Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "364798af-15c0-4bba-829e-ae9928fe2383", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:23.542Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "54cce07c-3416-4935-b3e0-dc9b2015d1e1", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:23.641Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "c6854a8d-3668-4bf2-ae3f-0afdf04a444d", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:23.667Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "a822bf0a-d9fa-472e-b4df-54e0a69bf605", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:23.848Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "94d38462-f725-407b-8045-5943af05f423", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:24.026Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "52ab9cdc-a3e6-4cd6-b43b-1159e9280fcf", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:24.369Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "08283771-99bb-4a97-8aa4-136eab0edf1c", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:25.149Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "7d3bc103-246d-4d09-a98a-fc9bf77c35bf", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:26.560Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "f6bec8be-13c7-45f4-8d8b-59e626fc2631", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:29.341Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "a4345a4d-47c2-4321-a2c7-e722691109a1", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:34.480Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "3ab27ce7-fb93-47c3-a0c0-cb939447729f", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:44.736Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "bfb20d7c-2de2-4588-b425-7e0da9483d5f", "reason": "secondary VRG manifestwork deletion in progress"}
2024-12-02T00:29:47.470Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "2d33dca8-11e6-4979-adfe-8486247f7b36", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-02T00:29:47.764Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "667ff490-205c-4f0f-aff3-6bfa8f2c18a1", "reason": "primary VRG manifestwork deletion in progress"}
2024-12-02T00:30:05.230Z	INFO	controllers.DRPlacementControl	controller/drplacementcontrol_controller.go:191	Deleting DRPC in progress	{"DRPC": {"name":"subscr-deploy-rbd-busybox","namespace":"subscr-deploy-rbd-busybox"}, "rid": "3353357f-3cf8-4a6f-bb16-8aa95f24aec1", "reason": "primary VRG manifestwork deletion in progress"}

@BenamarMk @ShyamsundarR I splited the fix to #1709, so can fix the failing builds quickly, and have more time to think about the best way to handle operation in progress.


Error Creating User when production mode is on

Hi,
Love the work you are doing with this project so far, I have one error when production mode is enabled and trying to create a user. after submit on the the signup page I get the error below. You will not see the issue in development mode because the ReCaptcha check is skipped. Is there a library I am missing?
Fatal error: Class 'ReCaptcha\ReCaptcha' not found in application/libraries/Form_builder.php on line 412

Yes you will need enter the application folder, then execute command composer install to install required packages.
If Composer is not installed yet, please follow the Getting Started page from its official website: https://getcomposer.org/


Fixing tiny stuff

Codecov Report

Merging #192 (a6859c6) into main (4983f6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   69.66%   69.66%
=======================================
  Files          61       61
  Lines         590      590
  Branches      152      152
=======================================
  Hits          411      411
  Misses        167      167
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4983f6f...a6859c6. Read the comment docs.


CDVPlugin class IonicKeyboard (pluginName: Keyboard) does not exist

I just gonna leave this here for now. Should be an easy fix for anyone wanting to hop on. @thoughtpalette perhaps?
When running the beta14 branch on iOS platform:
CDVPlugin class IonicKeyboard (pluginName: Keyboard) does not exist.
2015-01-18 22:32:17.359 trendicity[24209:8844253] ERROR: Plugin 'Keyboard' not found, or is not a CDVPlugin. Check your plugin mapping in config.xml.

I'm not available tonight. I was unaware of tomorrows timeline until today :\

Related to #33.

Where are we on this one?


Fix some outdated documentation and scripts

These are some of the things I changed doing some tests locally. I think all these changes make sense and there's nothing specific to my local environment.

Unless @ylebre has other insights in the coming days, I'll merge these changes this week.


Tests: Make assertCapturedSuccess check stderr is empty again

assertCapturedSuccess used to check that stderr was empty, until:
https://github.com/heroku/heroku-buildpack-python/commit/797652a75d69a1fece96a26bf4514fe9e9e1c020#diff-65c067a6f0a3aef292fb54ec21a1fe8cR98
Adding back the assertion exposes some new bugs, which I'll fix in later PRs. In the meantime affected tests have been adjusted to use a new assertCapturedSuccessWithStdErr.
The test harness output for the failing case has also been improved, to ease debugging.
Closes W-7918492.
[skip changelog]

(This change means the tests now catch a few failure cases which would otherwise have been silently introduced once #968 is updated/merged)


filtering a collection with a relationship-field results always in empty list

Bug Report
Filtering a collection with a relationship-field seems to be not working at the moment, as it always returns an empty list and not the required elements. Filtering a collection with fields which are not a relationship do seem to work.
Expected Behavior

in the following example I expect the post with title 'Eastern European White Hands Having Brunch in a Van' to be shown when I

Current Behavior
nevertheless at the moment this results in

an empty list
Possible Solution
I could look into the source code later, but I thought I mentioned it immediately
Steps to Reproduce

create a collection X that will be used as relation
add element to collection X called X1
create another collection Y with a relationship-field to X
add element to collection Y with a relationship to X1
try to filter collection Y with X -> exists -> X1
witness there is no element shown instead of the one element you added

Detailed Description

If you hit the rest endpoint: /api/posts?where[category][equals]=ID_OF_CATEGORY_HERE
Do your results come back properly?
The issue you are describing seems to function correctly on the demo site here

Mm, no I still get an empty list

And I agree, it does seem to work properly on the demo site.
It also looks a bit different:

as you can see, with my version it is a dropdown where I can select only 1 category, but with the demo I can select multiple categories.

ok, I think I found the culprit.
I defined the schema for the category-field as follows:

I think there are some examples in your docs that follow this patter too.
Nevertheless if i remove the square brackets:

it does look a bit weird in the list-view

but I am able to filter the category

Also, tangentially related, when I removed the brackets, the category-fields from the already entered data became corrupted.

I suppose this is expected behavior in a way, but a bit frustrating right now the only way to fix it is to enter the database and correct the data directly in mongodb.

the weird list-view was solved once I manually adjusted the data in mongodb (from category as an object with a name- and an id-key to category as a single id-string)
![image](https://user-images.githubusercontent.com/10504064/180214099-35917534-d8d5-4d0c-a1df-4d71ba8b217a.png

So a more correct title would be:
filtering a collection with a relationship-field with an array as its value results always in empty list.

OK - here's the issue here.
You're trying to ask Payload for posts where category EQUALS id. But, a hasMany category will never equal and ID specifically, because it's an array.
So, you need to use category IN id, like this:

This works on demo and I'm sure it's the issue. If you want to use equals, you'd need to pass in an array of categories, which is currently not possible in the admin UI. But it is certainly possible with GraphQL / REST / Local Node API queries. So I'm going to close this one as there is no issue per se, more of a feature enhancement to allow equals queries on hasMany relationship fields from the admin UI.
Does that make sense?


openMP line continuation

Hi Pedro! Line continuations in openMP statements get incorrect highlighting. For example
    !$omp parallel do default(none) &
    !$omp private(a,bunch,of,variables) &
    !$omp shared(more,vari,ables)
    do
    enddo
    !$omp end parallel do

Hello there @sujona, I don't have experience with other editors and $omp directives... So how this should be highlighted?

The wrong thing is that the private keyword should be highlighted just like parallel do default?

When the line is not broken it looks like

Which I think is fine, so if the "&":s are white and the "!$omp":s are green like in the first line of your screenshot, and the colors of the "private(var1,...)" and "shared(var2,...)" are as in the single-line case in my screenshot, that would make sense I think.

@sujona Is something like this ok?

I don't have any large code with an example of !$omp to check if my modification will affect wrongly the highlight of some other OpenMP directive... do you?
If you do, i can tell you how to apply this change in your extension so you can check other directives in your code for inconsistencies.

Yeah, it works great! Maybe you should add instructions in the readme on how to install it manually. I uninstalled the official plugin, cloned this repo, checked out the hotfix/highlight branch and linked it into .vscode/extensions/ with ln -s`.

There is no need for that. This fix will join the new release soon.


Investigation: right-to-left language support

Right now, the default Superset translations are supposedly not great but none of them seem to be RTL. We should investigate how support for RTL languages works in Superset, and ensure nothing in the data pipeline or ClickHouse storage breaks RTL languages.
As a fluent speaker of an RTL language:

Make some local translations: https://superset.apache.org/docs/contributing/translations/
Create and publish a course with XBlock names using RTL
Log into Superset and choose your language
General UI testing is important, but we will also want to know about chart labels and other issues
Create an epic of issues that we can contribute fixes for back upstream

Latest on this topic is here: https://github.com/apache/superset/issues/25258


[FLINK-27595] Helm - made security context configurable

LGTM too. It maybe worth defining separate securityContext at container level (webhook/operator) too with an empty body {}.

LGTM too. It maybe worth defining separate securityContext at container level (webhook/operator) too with an empty body {}.

added

thanks, +1 for merging


Hammer.js repo with just the .js files for use with Bower

Bower always copies all the files from the repository, and just to keep my app's file structure cleaner, it would be great to have a repository that just contains the latest release version of Hammer.js, i.e. the contents of the dist folder.

You can also commit on a detached head this is what many projects do. Im going to close this for now if we want to do anything more in the future we can discuss / open a new issue


set changed row only if non null

since we are using k2 topics. When backfill, there will be lots of columns with null value. We need to ignore those values

Codecov Report

Merging #43 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   75.75%   75.76%   +<.01%
==========================================
  Files          85       85
  Lines       13180    13181       +1
==========================================
+ Hits         9985     9986       +1
  Misses       2391     2391
  Partials      804      804

Impacted Files
Coverage Δ

memstore/backfill.go
74.92% <100%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc3630...1ad90d2. Read the comment docs.


WCAG 1.4.3: (ExpenseItIntro/Table headers ExpenseType , Amount "Expense Report For" view) [High Contrast White] Contrast ratio failure for regular text

The following accessibility issue needs investigation.
App: ExpenseItIntro
Element path: Table headers ExpenseType , Amount in "Expense Report For" view
Issue Details: Contrast ratio failure for Regular text
How To Fix: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.


[Bug Report] The initial type of el-input makes different height

Element UI version
2.2.0
OS/Browsers version
macOS High Sierra 10.13.3 / Chrome 64.0.3282.186
Vue version
2.5.13
Reproduction Link
https://jsfiddle.net/mmx38qxw/460/
Steps to reproduce
el-form中多个el-input的v-model的初始值设置number和string两种类型，会发现排列出现错乱，两种类型的高度不一样
What is Expected?
高度一致，排列不错乱
What is actually happening?
高度不一致，排列出现错乱

https://jsfiddle.net/mmx38qxw/463/ . You have to wrap each row in one <el-row>.

This small different in height may cause some other bugs. Mine is just an example to show that.

Also, wrap several rows in one el-row is usable because el-col is float. And there's a "column wrapping" since bootstrap. This bug is caused by the different height of input not wrapping multiple row in one el-row. I think your answer was thoughtlessly.

It seems this only happens in Chrome. In https://github.com/ElemeFE/element/pull/10064 the line-height for input element is explicitly declared in px instead of the original 1, which works for me.


don't try to access device when probing failed

This avoids a segfault in pixelpulse2 when first starting the app and
then plugging in a device without full access permissions to it.

No reason, that's what I get for making commits while distractedly talking to other people and forgetting to remove lines. :)


dingtalk null and @all

Mobile

■ null
440@10-11-87-176 | jvm-name
2023-10-16T01:00:00.047377Z[Etc/UTC] | rpt-time

PC

■ null
440@所有人-11-87-176 | jvm-name
2023-10-16T01:00:00.047377Z[Etc/UTC] | rpt-time

applicationName is null, should WARN in log
jvm name should replace @ with at


Firefox 85: preview.jpg tiles not correctly placed on cube

When loading a cube-multi-res scene like the demo https://www.marzipano.net/demos/cube-multi-res/ in Firefox the six sides of the preview.jpg are not distributed over the six sides of the cube, but the whole image is squezed on each side of the cube. This happens only in Firefox.
You can see the problem with slower internet connections until the tiles are loaded.

same problem with i'm using Mozilla Firefox 85.0.1 (64-bit)

I have also experienced this issue with Firefox.
It seems like it was introduced with v0.10.0, since downgrading to  v0.9.1 solved it for me. I'll keep it at that until the issue has been fixed.

Hello, I am unfortunately having the same issue on Firefox 85.0.2.
It is a shame to see continuous flashes of wrong tiles while panning around, really ruins the immersive experience! If anyone has any solutions or thoughts, please let me know.

This should have been fixed in 684f9fd which was just released as part of v0.10.2.

Hello Tiago @tjgq, thank you so much for working on this and for fixing this issue. The preview tiles load perfectly in Firefox now and it looks great across all browsers. Thanks for all your awesome work!


[error]No code coverage results were found to publish

Running  as per https://github.com/microsoft/MLOpsPython/blob/master/docs/getting_started.md#set-up-the-model-ci-training-evaluation-and-registration-pipeline I get the following error. Can you help please?
2022-02-25T03:18:01.8689783Z ##[section]Starting: Publish coverage report
2022-02-25T03:18:01.8696346Z ==============================================================================
2022-02-25T03:18:01.8696875Z Task         : Publish code coverage results
2022-02-25T03:18:01.8697190Z Description  : Publish Cobertura or JaCoCo code coverage results from a build
2022-02-25T03:18:01.8697465Z Version      : 1.198.0
2022-02-25T03:18:01.8697655Z Author       : Microsoft Corporation
2022-02-25T03:18:01.8698004Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/test/publish-code-coverage-results
2022-02-25T03:18:01.8698394Z ==============================================================================
2022-02-25T03:18:02.3843085Z ##[error]No code coverage results were found to publish.
2022-02-25T03:18:02.3914084Z ##[section]Finishing: Publish coverage report

rename project in diabets_regression-ci.yml fixed the issue. Project and files renaming not cascading into ylm files.


NIFI-3543 Fixed a bug that nifi-jms-cf-service cannot have a variable as the brokerURL.

@ShellyLC If you wouldn't mind opening a NIFI JIRA ticket for this bug, we would really appreciate it!

@ShellyLC also, please amend your commit message preceding it with the JIRA number so it could be automatically linked in JIRA (i.e., "NIFI-3543 Fixed a bug that nifi. . ."). Also, please read my comments on the differences between BUG and IMPROVEMENT.

Thanks you @ShellyLC , will review and merge.


Add support for arbitrary record types

@benlangfeld Can you rebase this and let's look at trying to get this committed.

@bexelbie Is this project alive again? If I rebase this is it likely to get merged?

@benlangfeld alive and kicking :) We had our first maintainers meeting and have a basic Roadmap to get us rolling again

@bexelbie Rebased, but this modifies CNAME support and removes reverse DNS. I'm not convinced either were implemented adequately and were done so in a way that makes generic record type support hard. This needs a ground-up rethink of what landrush is supposed to be, along the lines of the notes above.
I've made my preference for the approach clear. If you're in agreement, then all that remains is to decide the API Landrush is to provide for manual record insertion and which records should be inserted automatically, both to generate a BIND zone file. That this functionality and the DNS server are coupled has over time encouraged strange behaviours and a very loose specification of intent.

@benlangfeld I will take some time to re-read the history of this PR before I comment.  I am updating to let you know that I saw your update.

@benlangfeld, even worse. I merged now also my changes to make Landrush work on Windows. They don't directly affect your code, but since I touched a lot of files, there are plenty of merge issues. Not sure if you to try to sort them out. If so, it would be nice if you also create a issue for this and add the issue key to the commit messages.
The new issue could also serve as a discussion ground. AFAIU you also think that we first need to define the overall goal. For me it is not quite clear yet which benefit supporting BIND zone files has? What do we really gain here, compared to the simple config we have now? Could additional DNS entry types also supported by sticking to a simple JSON notation?

@hferentschik I don't use Landrush currently; in fact, right now I have no need for anything landrush-like. Given my other project load, I probably won't get back to this issue. If I ever do have a need in the future and the point of this PR becomes important, I will probably build it out separately from Landrush to avoid integration effort.

I don't use Landrush currently; in fact, right now I have no need for anything landrush-like.

Fair enough.


Small suggestions

Would be nice to have an option to give the Cassie announcements a delay, when they should be played. I also have Serpents Hand on my server and as this counts as a Chaos spawn, both messages trigger at the same time.
FriendlyFire resets on round start, so the server is listed as FF on, as long, as you are in the lobby or if the server is empty. This could be fixed, if FF resets on round restart.

Thanks for suggestions.

FF is now permanently on. It doesn't get reset.

Fixed


Add RaspberryPI Zero pin diagram library

I add a library for RaspberryPI Zero pins based on the existing RaspberryPi3 by @revolunet :)

Preview image is very heavy

Preview image is very heavy

Could you rotate the image and have a maximum dimension of 400px for the preview?

Could you rotate the image and have a maximum dimension of 400px for the preview?

I would like to add also (in another PR) some other drawings related to Raspberry like ADS1115 board and other stuff.. maybe we can create a unique directory to store them? If you like we can combine our dirs for RaspberrPI @revolunet , what do you think?

I would like to add also (in another PR) some other drawings related to Raspberry like ADS1115 board and other stuff.. maybe we can create a unique directory to store them? If you like we can combine our dirs for RaspberrPI @revolunet , what do you think?

Yeah, i guess it would be more user-friendly to have a lib containing all related drawings

Yeah, i guess it would be more user-friendly to have a lib containing all related drawings

We are open for suggestions.. we just want to make sure to give credit where credit's due. So one idea is to create a raspberrypi directory and have all elements in one library, and there we can add a README.md with the contributor's names and link to that.. WDYT?

We are open for suggestions.. we just want to make sure to give credit where credit's due. So one idea is to create a raspberrypi directory and have all elements in one library, and there we can add a README.md with the contributor's names and link to that.. WDYT?

Think in the long term divide the libraries based on the Author can lead to a bit of a mess maybe... Of course, mentions the author is important too! Think they could be organized by topic and for each include a list of authors... in the README.md or maybe also reorganizing libraries.json (but is a bigger change 😅 ), don't know which is the best really...
I just suggested creating a common directory with the authors' names (I thought this was the 'convention') in order to just put all the Raspberry related items in one place and easily search on https://libraries.excalidraw.com/, I see there are some items with two authors...

Think in the long term divide the libraries based on the Author can lead to a bit of a mess maybe... Of course, mentions the author is important too! Think they could be organized by topic and for each include a list of authors... in the README.md or maybe also reorganizing libraries.json (but is a bigger change 😅 ), don't know which is the best really...
I just suggested creating a common directory with the authors' names (I thought this was the 'convention') in order to just put all the Raspberry related items in one place and easily search on https://libraries.excalidraw.com/, I see there are some items with two authors...

mention in readme is very fine for me

mention in readme is very fine for me

Was there mentioned simply listing both (or more) authors as creators of a given library?

Also note that long-term we plan to make library items be searchable and installable individually. This will improve the UX in case we add all the rpi items into a single library, but a user will want to install just one instead of importing all of them at once.

Was there mentioned simply listing both (or more) authors as creators of a given library?

Also note that long-term we plan to make library items be searchable and installable individually. This will improve the UX in case we add all the rpi items into a single library, but a user will want to install just one instead of importing all of them at once.

The current model doesn't scale for multiple authors..

The current model doesn't scale for multiple authors..

If we fill the "authors" field in the libraries.json will not enough? (I didn't look how is rendered really... I'm guessing...)
Like this...
Was just a little improvement to have everything in the same place, if it's not possible I think is fine anyway :)

If we fill the "authors" field in the libraries.json will not enough? (I didn't look how is rendered really... I'm guessing...)
Like this...
Was just a little improvement to have everything in the same place, if it's not possible I think is fine anyway :)

I suppose it's because we namespace each library under author's username folder. Ultimately it's blocked by how we load libraries (single URL): https://github.com/excalidraw/excalidraw-libraries/blob/2d0cf1709d927d02ffccfda2de62dc976d5ad80b/script.js#L83
We could either precompile the library files and commit as joined library file from two (or more) authors, or we could support loading libraries from multiple urls at once.
Or, as a temp workaround we can simple create a folder that's named: author1_autor2/.
Either way I think long-term we'll definitely want to support cases where multiple authors contributed to a single library.

I suppose it's because we namespace each library under author's username folder. Ultimately it's blocked by how we load libraries (single URL): https://github.com/excalidraw/excalidraw-libraries/blob/2d0cf1709d927d02ffccfda2de62dc976d5ad80b/script.js#L83
We could either precompile the library files and commit as joined library file from two (or more) authors, or we could support loading libraries from multiple urls at once.
Or, as a temp workaround we can simple create a folder that's named: author1_autor2/.
Either way I think long-term we'll definitely want to support cases where multiple authors contributed to a single library.

we can create a directory raspberypi and have a README.md there and all the related libs as separate files.. why not? To keep it simple..

we can create a directory raspberypi and have a README.md there and all the related libs as separate files.. why not? To keep it simple..

I wouldn't say creating a subfolder with its own readme and everything is keeping it simple :).

I wouldn't say creating a subfolder with its own readme and everything is keeping it simple :).

I wouldn't say creating a subfolder with its own readme and everything is keeping it simple :).

This will be just a link from the author could be: @Raspberry Pi Team with a link to the readme for the contributors..
Adding/Supporting multiple author won't scale with the current (directory based) model..
I'm just wondering is it OK to include all the Raspberry Pi boards in one library or we should have multiple.. if having multiple, we can continue as we are and just merge this PR as is.

I wouldn't say creating a subfolder with its own readme and everything is keeping it simple :).

This will be just a link from the author could be: @Raspberry Pi Team with a link to the readme for the contributors..
Adding/Supporting multiple author won't scale with the current (directory based) model..
I'm just wondering is it OK to include all the Raspberry Pi boards in one library or we should have multiple.. if having multiple, we can continue as we are and just merge this PR as is.

Closing in favor of #44 let's continue there.

Closing in favor of #44 let's continue there.


BUG - optional flpId is not optional

Related Feature
Feature request: #72
Description
The property is defined as optional at https://github.com/SAP/open-ux-tools/blob/main/packages/fiori-elements-writer/src/types.ts#L85, however, if the property is not provided, then the generated flpSandbox.html file is broken because it is missing the semantic object and intent for the app to be previewed.
Steps to Reproduce
Steps to reproduce the behavior:

Create a simple script with all mandatory input values for @sap-ux/fiori-elements-generator/generate()
Generate an app
Start the (mock) preview

Note: I have only tested this with the Fiori elements writer but I assume the same issue exists in the freestyle writer.
Expected results
The app is loaded
Actual results
The FLP starting page is loaded and there is no tile for my app.
Suggested Solution
I see three possible solutions

Add some code that sets a default value if the property is not provided
Remove the property from the API and always set a default value since there is no reason to actually provide a custom value. In addition, the name flpId is a bit odd since it actually is the serialized intent (semantic object and action).
Remove the property and add a new optional property call navigation of type (https://github.com/SAP/open-ux-tools/blob/main/packages/ui5-config/src/types/manifest.ts#L714). If the object navigation.outbound is provided then we use its content also for the sandbox html, and if not we use a default value

interface navigation {
   semanticObject: string;
   action: string;
   parameters?: { [key: string]: string }
}

My preference is option 3 because it does not just solve the current problem but also prepares the writers for features required when adding deployment configurations.
Version/Components/Environment
Add any other context about the problem here
OS:

[x] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

@tobiasqueck
I suppose minimum required is to add a default value for this parameter.
Splitting flpid into SematicObject and Action makes sense in 3.
But we also need to distinguish between writing the flpSandbox.html  ( eventually OPA files - I think some reference the intent - historically at least) and the manfiest.json crossNavigation section for deployment. Since the deployment part would be optional. Also, not sure if there is a valid reason for it but these  flpSandbox.html and manifest.json intents are often different.
So I would favour separating these two intents in the interface at the risk of duplication.

I think some reference the intent - historically at least)

The only reference to this intent is in the script that we generate into the package.json and that happens within the same writer (https://github.com/SAP/open-ux-tools/blob/main/packages/fiori-elements-writer/src/packageConfig.ts#L16), so there is nobody that I am aware of that references it.
So, if I understand you correctly, you prefer option 2 then (i.e. don't mix this with outbound navigation)


IOS More Ram allocation for iOS 15

com.apple.developer.kernel.increased-memory-limit
A Boolean value that indicates whether core features of your app may perform better with a higher memory limit on supported devices.
https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_developer_kernel_increased-memory-limit?changes=latest_beta

Well that's definitely useful!  Thanks for bubbling that up!

@stossy11 It's already implemented: https://github.com/utmapp/UTM/blob/master/Platform/iOS/iOS.entitlements#L5-L6
See also https://github.com/utmapp/UTM/pull/3318


Entra - Make Source field in payload required

This PR checks for source in the request payload and will return an error if not found.
The Bug# 2161566

@hakimms:  Please let me know when you'd like me to merge.

@hakimms:  When you get a moment, please join the "Microsoft" and "Azure" GitHub organizations and ensure that they're set to public on your profile.

@hakimms: When you get a moment, please join the "Microsoft" and "Azure" GitHub organizations and ensure that they're set to public on your profile.

I see the option to follow these organizations, but how do I join them?

Please go ahead and merge this. Thank you

@hakimms: Please let me know when you'd like me to merge.

Please go ahead and merge it, thank you!

@hakimms: When you get a moment, please join the "Microsoft" and "Azure" GitHub organizations and ensure that they're set to public on your profile.

I see the option to follow these organizations, but how do I join them?

https://docs.opensource.microsoft.com/github/opensource/accounts/linking/https://docs.opensource.microsoft.com/github/opensource/accounts/linking/

Missed a URL that may be a secret leak.   Please evaluate and roll keys if needed:
https://github.com/Azure/azure-sdk-for-net/security/secret-scanning/181


Introduce size constants

Changes

Adds a module exporting our sizes as constants for re-use in other components.

Hm yeah, if they use sizes like, they should get updated to use these constants.


Masthead and Footer making api calls and resulting in errors

Description
The masthead and footer components make api calls and which encounter errors. Just simply open the code sandbox links from the documentation to view it on the console.

Masthead: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Masthead
Footer: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Footer
Component(s) impacted
Masthead: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Masthead
Footer: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Footer

Browser
Chrome, Safari, Firefox
Carbon for IBM.com version
1.35.1
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
https://www-40.ibm.com/ibm/cas/canada/
Package
@carbon/ibmdotcom-react, @carbon/ibmdotcom-web-components, @carbon/ibmdotcom-styles
CodeSandbox example
Masthead: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Masthead  Footer: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Footer
Steps to reproduce the issue (if applicable)
Visit code sandbox links from official documentaion and open up console to view the errors.
Masthead: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Masthead
Footer: https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Footer
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

Not stale

Most of the errors coming through in that screenshot are CORS errors (namely the login API) which fails because the page requesting is not under the allowed host list set by the server. These are valid errors.
The other API error (translation one) I do not see in the current stackbiltz (try running in FireFox - Chrome will run out of memory).
Closing this ticket, feel free to reopen if there are any questions or additional information that needs to be addressed.


Update HTMLImageElement IDL to latest version from gecko

I haven't tested all the new extensions but I did confirm that decoding and decode() functions work as expected.
IDL source: https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/HTMLImageElement.webidl

Thanks! Mind removing the Mozilla specific bits? Other than that seems good to merge

@alexcrichton Absolutely. Done.

Thanks!


Trying new @UIRouterModule...

Hi!
I cloned ui-router into local folder, and built it with npm run build
Then I removed old ui-router-ng2 content in the node_modules folder and copied new content from build_packages\ng2.
Then I changed app.module.ts to:
var homeState = { name: 'home', url: '/home', component: HomeComponent };
var aboutState = { name: 'about', url: '/about', component: AboutComponent };

@UIRouterModule({
   imports: [BrowserModule],
   declarations: [AppComponent],
   states: [homeState, aboutState]
 })
export class AppModule {};

and got a error:

Whats wrong?

After I added traceur manually:

I suspect you're using systemjs? I saw this in quickstart-ng2 where SystemJS incorrectly detects ui-router-ng2.js as an ES6 module that needs transpiling.  I believe it's parsing something from one of the block comments in the unminified file.
Try one of these things:

Point systemjs to the ui-router-ng2.min.js minified file
Add a meta: block that says the bundle is cjs https://github.com/ui-router/quickstart-ng2/blob/rc5compat/systemjs.config.js#L54

Thanks! That worked!
But got another error:

@UIRouterModule
({
  imports: [
    BrowserModule,
  ],
  declarations: [
   AppComponent
  ],
  states: [],
  providers: [
    {provide: LocationStrategy, useClass: HashLocationStrategy},
    {provide: UIRouterConfig, useClass: MyUIRouterConfig},

  ],
  bootstrap: [ UIView ]
})

you need to declare it as an entryComponent

Ho can I do this?

@UIRouterModule
({
  imports: [
    BrowserModule,
  ],
  declarations: [
   AppComponent
  ],
  entryComponents: [
    AppComponent
  ],
  states: [],
  providers: [
    {provide: LocationStrategy, useClass: HashLocationStrategy},
    {provide: UIRouterConfig, useClass: MyUIRouterConfig},

  ],
  bootstrap: [ UIView ]
})

Also note: @UIRouterModule is a shortcut for creating a NgModule manually:
https://github.com/angular-ui/ui-router/blob/f6741516a43a605ed7f8f3d1d96517e7e46ef54d/src/ng2/uiRouterNgModule.ts#L50-L66

What is the official latest release of ui-router-ng2 for npm in order to start using @UIRouterModule? I am updating to RC5.

@christopherthielen Yes! Thats helped!
And one more error from second module:

@christopherthielen I fixed it by removing undefined states
uiSref="app.public.user.signup"
uiSref="app.public.user.login"

@kolkov What is the latest release of ui-router to work with angular 2 rc5? Also, where are you importing UIRouterModule from?

@kolkov @christopherthielen nvm I found the quickstart and that is all up to date. Thanks all!

@thegrid22593 No, quickstart is not for UIRouterModule, it's for beta1. UIRouterModule is for future beta2.
If you want you can try to build beta2 by yourself as described above.

@thegrid22593  ui-router 1.0.0-beta.2 will be out shortly and contains the UIRouterModule code being discussed, and full NgModule support.

@christopherthielen Great to hear! Thanks!

@christopherthielen What is preferable to use, UIRouterModule or NgModule?

@kolkov UIRouterModule is easier to use (less boilerplate) but it's your own personal choice.
If you use raw NgModule make sure your module provides the states as UIROUTER_STATES_TOKEN with multi: true and also imports the UIRouterRootModule

Thanks! Now we can describe routes for modules separately in the modules themselves?
And we no longer need to use this construction in MyUIRouterConfig?
INITIAL_STATES.forEach(state => uiRouter.stateRegistry.register(state));

Now we can describe routes for modules separately in the modules themselves?
And we no longer need to use this construction in MyUIRouterConfig?
INITIAL_STATES.forEach(state => uiRouter.stateRegistry.register(state));
^ correct.

And what now we do with this function? It is still necessary?
@Injectable()
export class MyUIRouterConfig {
  constructor(private injector: Injector) {}

  configure(uiRouter: UIRouter) {
    // Register each state definition (from app.states.ts) with the StateRegistry

    // Define a default behavior, for when the URL matched no routes
    uiRouter.urlRouterProvider.otherwise(() => uiRouter.stateService.go("app.public.home", null, null) && null);
  }
}

And do we need here injector still?

You still need to provide a MyUIRouterConfig with a .configure() function.  The private injector: Injector isn't actually used, and is not necessary to inject.

@christopherthielen any idea on what the time frame is for 1.0.0-beta.2?

@christopherthielen Do we still need bootstrap: [ UIView ] in AppModule?

Url: mydomain/angular2#/public/home
state is: public.home
And state is empty in Augury:

Is it correct?


'webgpu/webgpu_cpp.h' file not found

file not found when running in ios
@wcandillon

can you provide steps to reproduce the issue?

can you provide steps to reproduce the issue?

I have take a clone of the repo and run the apps/example
with steps:
1-> yarn install
2-> npx pod-install
3-> run from xcode in simulator.
I have also disable metal api.
@wcandillon

then you would need to follow these steps: https://github.com/wcandillon/react-native-webgpu?tab=readme-ov-file#library-development


[Docs] GraphicsCompositor - Add XML summary

Describe the update or improvement you would like to see
I would like to add a description summary to GraphicsCompositor, what is it doing and a link to our Stride docs.
Is this related to a specific part of the documentation?
https://doc.stride3d.net/latest/en/manual/graphics/graphics-compositor/index.html
Why is this update needed?
I am going through the basics and architecture of Stride and when we work with GraphicsCompositor, the IntelliSense should provide some basis description.
Additional context
Proposed text, also below in xml.

Proposed changes
I would like to review this addition:
    /// <summary>
    /// The <c>GraphicsCompositor</c> class organizes how scenes are rendered in the Stride engine, providing extensive customization of the rendering pipeline.
    /// </summary>
    /// <remarks>
    /// This class handles the initialization and destruction of the render system, manages the cameras used in the composition, and controls the render stages and features.
    /// It provides entry points for the game compositor, a single view compositor, and a compositor used by the scene editor.
    /// <para>
    /// Key features of the <c>GraphicsCompositor</c> include:
    /// </para>
    /// <list type="bullet">
    ///   <item><description>Using one or multiple cameras</description></item>
    ///   <item><description>Filtering entities</description></item>
    ///   <item><description>Rendering to one or more render textures with different viewports</description></item>
    ///   <item><description>Setting HDR or LDR rendering</description></item>
    ///   <item><description>Applying post effects to a render target</description></item>
    ///   <item><description>Clearing a render target or only the depth buffer</description></item>
    ///   <item><description>Modifying the compositor from scripts</description></item>
    /// </list>
    /// <para>
    /// For more information, see the
    /// <see href="https://doc.stride3d.net/latest/en/manual/graphics/graphics-compositor/index.html">Graphics Compositor</see> documentation.
    /// </para>
    /// </remarks>

Are you ok with this summary? If yes, I will make a PR.

Key features of the GraphicsCompositor include:
[...]
Modifying the compositor from scripts

Maybe "Editable in the gamestudio and at runtime from scripts" instead ?
Otherwise looks good !

Thanks. I will make the updates and then PR.


[Feature]: Delete to Trash on Windows

Describe the feature you'd like added
Could the current behavior be changed and the files to be deleted should be placed into the Trash on Windows?
Additional context
No response

I don't think Jellyfin supports that or ever will be.
пн, 18 дек. 2023 г., 21:27 advokatb @.***>:

Describe the feature you'd like added
Could the current behavior be changed and the files to be deleted should
be placed into the Trash on Windows?
Additional context
No response
—
Reply to this email directly, view it on GitHub
https://github.com/shemanaev/jellyfin-plugin-media-cleaner/issues/33,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICN2LKI747MTCKF4STVU3YKCDJJAVCNFSM6AAAAABAZ6OBLGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DOMRQHEYDGOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Cosign this. Or at least set up a trash folder to move the videos too after it's been watched


tagRemoveButtonPressed stop working suddenly

When I click on tag following action is being called
func tagPressed(_ title: String, tagView: TagView, sender: TagListView) {
        print("Tag pressed: \(title)")
}

but when I click on closeButton
func tagRemoveButtonPressed(_ title: String, tagView: TagView, sender: TagListView) {

}

was not being called it was working previously but suddenly stop working.
I am using Xcode 9.3

Have you tried to update your Xcode to the latest version? And don't forget to set delegate.

Check my pull request, I had same issue with custom TagView

I can confirm that the PR of @radvansky-tomas has helped me get through this.

don't forget to set delegate to other TagList also.


Increase coverage of api/placer.py

Closes #689
Name             Stmts   Miss  Cover   Missing
------------------------------------------------------------------
api/placer.py      325     37    89%   71, 242-259, 272, 285, 293-296, 318, 375, 387, 533, 617-618, 629, 636-638, 652-657

71: "too much effort"
242-259: compatibility code - to be removed soon
272, 285, 293-296: too much effort
318, 375: not sure how they're reachable (see listhandler.py:526)
533: not sure how it's reachable (session meta may not include timestamp, see raml/schemas/input/packfile.json)
617-EOF: effort + would be helpful to talk through analysis/analysisjob placing in detail in the future

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

LGTM


abnormal litter size MP:0001933 - remove axiom and amend placement of child terms

EQ for abnormal litter size MP:0001933 currently uses:
'has part' some (quality and ('characteristic of' some 'brood size') and ('has modifier' some abnormal))
Using ‘brood size’ PATO:0000276 is not appropriate. Remove EQ entirely.
decreased/increased litter size terms have no EQs (ok).
Also, place decreased litter size MP:0001935 under reduced fertility MP:0001921 and increased litter size MP:0001934  under enhanced fertility MP:0010143

EQ for abnormal litter size MP:0001933 has been removed.
decreased litter size MP:0001935 is now under reduced fertility MP:0001921 and increased litter size MP:0001934 is under enhanced fertility MP:0010143


External trigger scan crash

The scan_external_trigger scan crashes with the message attached below.
Traceback (most recent call last):
File "C:\Users\student\git\pyBAR\pybar\run_manager.py", line 111, in run
self.do_run()
File "C:\Users\student\git\pyBAR\pybar\fei4_run_base.py", line 295, in do_run
self.scan()
File "C:\Users\student\git\pyBAR\pybar\scans\scan_ext_trigger.py", line 74, in scan
with self.readout(**self.scan_parameters._asdict()):
File "C:\Users\student\Anaconda\lib\contextlib.py", line 17, in enter
return self.gen.next()
File "C:\Users\student\git\pyBAR\pybar\fei4_run_base.py", line 392, in readout
self.start_readout(*args, **kwargs)
File "C:\Users\student\git\pyBAR\pybar\scans\scan_ext_trigger.py", line 120, in start_readout
self.dut['TLU']['EN_INVERT_TRIGGER'] = 0 if self.trigger_pos_edge else 1
File "c:\users\student\git\basil\host\basil\HL\RegisterHardwareLayer.py", line 244, in setitem
return self._set(name, value)
File "c:\users\student\git\basil\host\basil\HL\RegisterHardwareLayer.py", line 222, in _set
descr = deepcopy(self._registers[reg]['descr'])
KeyError: 'EN_INVERT_TRIGGER'

please update pyBAR and basil to the latest development version

It was already updated.
And I notice the scan only crashes when I enable the tdc to True.

this is fixed now.
Please use dut_configuration_mio.yaml to set up trigger (mode). Comments on the settings are available inside the file.


Windows compatibility

Related issues:

https://github.com/yuki-ycino/fzf-preview.vim/issues/182
https://github.com/yuki-ycino/fzf-preview.vim/issues/177

This PR should fix most of the commands of fzf-preview.vim if installed with coc-nvim, except the ones using

git_actions_preview
preview_yankround_register

I ran yarn test (on windows only), and every test pass, by I have no easy access to a linux or mac os.
Could you review my code an keep in mind that I am new to vim and that I am not a native English speaker.
Thank you.

Thanks for the PR.
I'm a little busy, so I'll try to do a review in my free time.
The CI was not running against the PR, so I just set it up to run against a pull request.
Can you rebase the master and ask for a push again?

It doesn't seem to work when multiple arguments are passed to FromResources.
It may be environment dependent, but can you confirm that it works?
I think this patch should work if the problem is happening.
If you are able to confirm the problem, please incorporate this patch
diff --git a/src/args/files-from-resources-parser.ts b/src/args/files-from-resources-parser.ts
index 4bb4006..c7fe163 100644
--- a/src/args/files-from-resources-parser.ts
+++ b/src/args/files-from-resources-parser.ts
@@ -1,3 +1,5 @@
+import { flatMap } from "lodash"
+
 import { argsParser } from "@/args/parser"
 import { FILE_RESOURCES } from "@/const/fzf-option"
 import type { SourceFuncArgs } from "@/type"
@@ -6,7 +8,7 @@ export const parseResources = (args: string): SourceFuncArgs => {
   const parser = argsParser()
   const options = parser.parse(args)

-  const resources = options._
+  const resources = flatMap(options._, (resource) => resource.split(","))

   if (resources.length === 0) {
     throw new Error("Select one or more resources")

I haven't finished reviewing it yet, but is it mandatory to change the fzfOptionsToString to fzfOptionsToStringArray?
If it's not required, I'd like to incorporate it in another amendment.

On my computer, it seem that FromResources works with and without your patch on multiple resources.
From the Read me
nnoremap <silent> [fzf-p]p     :<C-u>CocCommand fzf-preview.FromResources project_mru git<CR>

I think that your patch should split on space and not comma:
const resources = flatMap(options._, (resource) => resource.split(","))

should be
const resources = flatMap(options._, (resource) => resource.split(" "))

The change from fzfOptionsToString to fzfOptionsToStringArray is not mandatory, but it means that the user must escape correctly some symbols for the cmd shell. This escaping is made in fzf.vim of the fzf plugin:
function! s:shellesc_cmd(arg)
  let escaped = substitute(a:arg, '[&|<>()@^]', '^&', 'g')
  let escaped = substitute(escaped, '%', '%%', 'g')
  let escaped = substitute(escaped, '"', '\\^&', 'g')
  let escaped = substitute(escaped, '\(\\\+\)\(\\^\)', '\1\1\2', 'g')
  return '^"'.substitute(escaped, '\(\\\+\)$', '\1\1', '').'^"'
endfunction

I will update this PR in the week to remove the fzfOptionsToStringArray related code.

I haven't finished reviewing it yet, but is it mandatory to change the fzfOptionsToString to fzfOptionsToStringArray?
If it's not required, I'd like to incorporate it in another amendment.

Do you want me to do another PR for that ? If so, when do you want me to do it ?

When I try it on my friend's environment, it looks like the FromResources call has a comma-separated list of space-separated arguments.
This is the behavior on Windows 10 + gVim with coc extensions.
To work around this, I had to use a flatmap to separate them by a comma.
The changes to fzfOptionsToStringArray can be merged before this PR if needed.

Execute :CocCommand fzf-preview.FromResources buffer mru
console.log(args)
Mac: ['buffer', 'mru']
Windows ['buffer,mru']

I'm not making much progress, so I'm going to use the PR as a guide to fix this on my end.


clone: seems to be pulling orphaned revisions unlike git clone

One of our users https://iterativeai.slack.com/archives/C03JS2V4MQU/p1689332412460989?thread_ts=1689272591.583879&cid=C03JS2V4MQU found that when using dvcfs, we were downloading large files that they've removed from history. And when running git clone those files were not downloaded.
Need to check if maybe one of our git backends is accidentally cloning more than intended.

It's probably that those files aren't orphaned, but that they are referenced by exp refs which are still pushed to the repo. git clone does not fetch exp refs but git clone --mirror (and DVC's clone implementation) do

@pmrowla Indeed, that explains it. Thank you!

(and DVC's clone implementation) do

Is it intentional though?

It's intentional so that you can dvc import or dvc get from named DVC experiments the same way you can import from a branch or tag name. We could try to make that lazier and only search and fetch exp refs if we fail to resolve a name on import, but that would be a DVC issue and not scmrepo.

@pmrowla Makes sense. So you mean that at least vanilla clone implemented in scmrepo, should not clone exp refs by default, right? We should have some kind of flag or something, so that default behaviour is closer to git clone. Or do I misunderstand something?

Vanilla Git.clone in scmrepo doesn't do anything with exp refs, the exp ref behavior is kept in the DVC erepo code:
https://github.com/iterative/dvc/blob/f1764bdc772916d40f824531705fffdfc462793e/dvc/repo/open_repo.py#L217C20-L217C20

@pmrowla Ah, indeed, I completely blinded that one. Thank you. Closing this issue for now then. Overall it is now clear that this is an intended behaviour so no action needed here.


Support for RPC API Specification v0.1.0

Usage related changes

(Closes #204) (Closes #178)
All of the methods from the latest RPC API Specification v0.1.0 are implemented and tested with the following exceptions:

starknet_pendingTransactions
starknet_syncing
starknet_getEvents
starknet_getNonce

version field in RPC transactions (invoke, deploy) is hardcoded to be hex(0x0) - in StarkNet 0.10.0 it will be an important part, distinguishing between different transaction types
Checklist:

[x] No linter errors
[x] Performed a self-review of the code
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Documented the changes
[x] Linked the issues which this PR resolves
[x] Updated the tests
[x] All tests are passing

Thanks for the PR; it's a rather long one! I can probably start the review only next week; is there a deadline when you would need it merged?
On the first glance, it seems like many of the changes come from the refactor of rpc.py. If that is so, you may consider linking this issue https://github.com/Shard-Labs/starknet-devnet/issues/178 as a closing candidate. How much of the changes actually comes from the refactor?

Regarding unimplemented methods:

Could pendingTransactions return an empty array?
Could syncing return false?
How could getEvents be implemented?
Could getNonce be implemented after adaptations to Starknet v0.10.0?

Should version field be changed to 1 with adaptations to Starknet v0.10.0?
In multiple places str is used for type hinting, whereas the custom types Felt or NumAsHex could be used.
Can pylint suppresion (# pylint: disable=unused-argument) be removed in some places if pytest.mark.usefixtures can be used (e.g. for deploy_info)?
Conflicts in server.py and rpc/conftest.py need to be resolved. I see app.test_client() is not used anymore; it was causing some headache in one of the latest PRs, so a fixture with restart was introduced. I guess it can be ditched now.
What's the impact of running devnet in background on test execution time? Why not use the existing decorator but a new fixture?

Regarding unimplemented methods:

pendingTransactions - returns events object with empty array
syncing - returns false
protocolVersion - removed, a note in docs added
getEvents - this is quite a big method, which will mutate a bit in the future, but definetly is a candidate for an issue to be implemented in
getNonce - probably yes, in another issue

For now, the version field should stay at 0. Once there will be 2 types in future specs (0 and 1), devnet should probably update to support that.
✔
✔
✔
Running devnet_in_background fixture on every test indeed increased the test execution time, but made it so every test runs in an isolated devnet, which was essential for some of the tests as they would behave differently when ran in a pack and individually.

@FabijanC Not sure if it is already planned, but would it be possible to deliver a new docker image with this PR merged ?
We hope it will make starknet-devnet compatible with Apibara
Thank you !

@AnthonyBuisset It can be released this week, how soon would you need it?

@FabijanC the sooner the better for us as we are going to deploy in the coming days our project and it would allow to validate in local before testing on goerli :-)

@FabijanC No rush to deploy the latest version anymore (at least from our side).
It seems it is still not compatible with apibara:
starknet_devnet.blueprints.rpc.structures.types.RpcError: Method not found

Maybe the missing starknet_getEvents callback
Do you know if it is just due to a lack of time or is there a technical issue preventing this method from being implemented ?

@AnthonyBuisset How did you test it? I'm currently working on #230, which should push a new pre-release image with each new commit to master.
Regarding starknet_getEvents, this is what the implementer said in https://github.com/Shard-Labs/starknet-devnet/pull/220#issuecomment-1220776804:

this is quite a big method, which will mutate a bit in the future, but definetly is a candidate for an issue to be implemented in

I've created an issue for this: https://github.com/Shard-Labs/starknet-devnet/issues/231

@FabijanC I built a docker image from the Github repository in my docker compose, I suppose it took master.


Would be useful to have a AddLabels() in the meta API

Hi, In using the meta info API I had needed to add my own labels. I had to do a get, add labels to what got retrieved and then use the SetLabels() api. Any reason why we do not have a "AddLabels()" api with the semantics of adding onto the labels map ? I am assuming this must have come up before but could not locate an applicable thread. Thanks.

A smaller API surface area of simple getters/setters is preferred, and allows building helper methods like AddLabels/RemoveLabels on top
/close

Thanks for responding. IMHO Add/Remove labels seems basic enough to be part of the base API but a minimal API surface does have its advantages..


Broken/Unusable Sliders

Steps to reproduce:

Open form with a slider present (e.g. Example Form)
Slider is practically unusable (selected value not displayed, touch area too small, lacks any graphics)

Expected behavior: Apparently this used to display properly, and was a usable form feature
Observed behavior: It doesn't.

Fixed or not an issue as of RC2 or earlier


Release version 0.6.0

Bump version.
Tag release.
Upload to PyPI.

I'd like to know what the necessary steps are in order to do this. Even if it's just for the joy of learning 😬

Sure. :blush:

Bump version: means to change the package version in osbrain.__init__.py and make a commit with that change. You can see there are similar commits for older releases in the Git history.
Tag release: we create an annotated tag for each release with the specific version number and a simple comment. See tag -l -n. As you can see, before 0.4.0 we did not have a strict policy to tag releases and tags are named after the commit they were attached to...
To upload to PyPI you simply execute python setup.py sdist upload. In order to do that you need to already have registered the project in PyPI and provide the required pakcage owner credentials. Once this is done the new version is available to be installed with pip.

Once we include a changelog (hopefully for 0.7.0+) this process will probably change a little.

@Peque it's nice to know. I feel a little bit wiser now 😁.