CVE-2023-42366 Vulnerability in Python 3.11.9-alpine3.19 Docker Image

e have identified a critical security vulnerability (CVE-2023-42366) present in our Docker image. This vulnerability poses a significant risk to our system's security and integrity. Immediate action is required to mitigate potential exploitation.
Issue Details:

CVE ID: CVE-2023-42366
Description: A heap-buffer-overflow was discovered in BusyBox v.1.36.1 in the next_token function at awk.c:1159.

Could you please provide an estimated timeline for fixing this issue? Additionally, any guidance on how to address this vulnerability effectively would be highly appreciated.? We would like to ensure that our system remains secure and up-to-date.
Thank you.

There isn't a fix available in Alpine 3.19, so there is nothing we can do: https://security.alpinelinux.org/vuln/CVE-2023-42366

This vulnerability poses a significant risk to our system's security and integrity.

Can you please elaborate how a heap buffer overflow in BusyBox awk's token parsing is a "significant risk" to your systems/deployments?  Is your Python code shelling out to awk with untrusted input, for example? :thinking:


Make sure every type from RAC that can be imported from Hopper.

A lot of types from RAC are used by our components. For instance, the type "Key", "Orientation", "SortDirection". We should make sure that inside the index.ts of hopper, we re-export those typings.
We could probably create a script that ensures that every types extracted from our component props are listed and exported from our index.ts file.
//index.ts
export { Key, Orientation, SortDirection } from "react-aria-components";

Expected Outcome
import { Select, Key } from "@hopper-ui/components"
...

const handleChange = (k: Key) => {
   console.log(k);
}
...

<Select onChange={handleChange} >

Done


fix(#minor); schemas; options/derivatives

Update options/derivatives contracts.

Add missing fields
Add more comments for users to understand fields
remove Contract from options and add fields to Position
Add Borrow entitiy on perps

@jaimehgb I made a few more changes if you want to review

Looks good :)


Angular Formly overrides model data on UI for same form fields with different  instances

I am making use of 2  tags to render my form on UI which have same fields but model value is different for both. The model value to these tags are coming from indexes of an array. The form renders properly on UI with all the form fields but somehow the values to these form fields are duplicating. The model values seem to somehow override the values in the array while rendering or something else.
Please find below the link to my stackblitz project depicting the same.
https://stackblitz.com/edit/formly-example-ekckzs?file=src/app/app.component.html
Any kind of help is highly appreciated. Also please comment for any clarification on the same.

Passing the same fields instance may provide an unexpected result, you can use one of the following solution:

Copy fields: https://stackblitz.com/edit/formly-example-nq3znp?file=src/app/app.component.ts
use immutable mode: https://github.com/ngx-formly/ngx-formly/issues/3294#issuecomment-1126875866
use custom type https://formly.dev/examples/advanced/multi-step-form
use repeatable type: https://formly.dev/examples/advanced/repeating-section


profiler a11y bug fixes

announce the new clause action and remove all action
add aria-label for the value input component

https://msdata.visualstudio.com/Data Studio/_workitems/edit/1613311
https://msdata.visualstudio.com/Data Studio/_workitems/edit/1655604

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 41.897%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
28648

Relevant Lines:
63494

💛  - Coveralls


correct parse_args usage

parser.parse_args only returns one value and doesn't require an input. Current implementation crashes at this point.

Thanks so much for the pull request! Totally overlooked the bug after the change from parse_known_args (which returns two values).
However, please do supply args explicitly: parser.parse_args is invoked inside process_args, which accepts args as input (=> they may not come from sys.argv in some very rare cases).

Ah, didn't notice both use cases. Added args back in.

Perfect ❤ Thanks a lot for the fix!


Plan title doesn't display on subscription page

Curtis Delicata is scamer. He doesn't pay any profits. Don't work with him.


[$250] Category rule - Approver field is not empty after the approver is removed from the workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition:

Rules are enabled.
"Add approvals" is enabled in Workflows.
Workspace has at least one member other than yourself.

Click on any category.
Click Approver.
Select a member as the approver.
Go to Members.
Remove the member from the workspace.
Go back to the category rule of the category in Step 3.

Expected Result:
Approver field will be empty because the approver is no longer a workspace member.
Actual Result:
Approver field still shows the removed member when the approver is no longer a workspace member.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/d169ef74-d918-435d-832f-8fe111f02d22

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021854279355604338561
Upwork Job ID:<PHONE_NUMBER>604338561
Last Price Increase: 2024-11-06

Issue OwnerCurrent Issue Owner: @mollfpr

We think that this bug might be related to #wave-control

@mallenexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Checking with Tom about quick

Posted and bumped in #wave-control room https://expensify.slack.com/archives/C06ML6X0W9L/p1727482508265999?thread_ts=1727123059.243429&cid=C06ML6X0W9L

Per Dylan, Put on hold pending the beta being built for it

https://github.com/Expensify/Expensify/issues/431466

On hold

Was able to reproduce

and

@mollfpr, can you review the proposal above? Thx

@zanyrenney I'm off the next week, can you please keep an eye on this issue til I'm back? Thx

Sure thing @mallenexpensify !

Seeing as @mallenexpensify successfully reproduced this, I am removing the label.

bumping @mollfpr to review the proposal above.

We don't reset the approval rule to be empty after deleting a member.

@abzokhattab I agree with RCA, but why is the solution not related to resetting the rules?

@mollfpr , 👀 above plz.  Thanks for watching over Zany, I'm back!

We don't reset the approval rule to be empty after deleting a member.

@abzokhattab, I'm still not onboard with the solution. The root cause is in our BE response not updating the policy rules.approvalRules after removing the member. So I think the proper solution is:

BE: Fixing the API DeleteMembersFromWorkspace response to have the rules.approvalRules updated with the employee list
FE: Follow up with the same approach for the OFFLINE

That's it, no need to update getCategoryApproverRule since we got the correct data for rules.approvalRules.

Ohyeah, you already have that in the alternative solution my bad 🙏
The alternative solution looks good to me and it's pretty much the same as the strategy I suggest. I think we can move forward from here and discuss the BE changes with the selected engineer.
🎀 👀 🎀 C+ reviewed!

Yeah let's go with the backend + front-end solution. The backend should definitely clean up the approvalRules array in this case.
I'm done with the bulk of the backend changes but still need to add some tests. Heads up that I'm going to be OOO for the rest of the week, but feel free to start working on the front-end changes for the optimistic and failure data in the meantime.

Will do. The backend change PR is in review now.

@abzokhattab the backend changes are now live.

Issue not reproducible during KI retests. (First week)

Looks like the PR is moving along

https://github.com/Expensify/App/pull/53383#pullrequestreview-2507550198

Issue not reproducible during KI retests. (Second week)

PR is on staging
https://github.com/Expensify/App/pull/53383#issuecomment-2551348519

Issue not reproducible during KI retests. (Third week)

Contributor:  @abzokhattab paid $250 via Upwork
Contributor+: @mollfpr due $250 via NewDot
@mollfpr it doesn't look like the BZ checklist was auto-added.  Can you fill it out please?
BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[ ] 2b. Reported on staging (eg. found during regression or PR testing)
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎


Tests for "ssr: true" on dynamic pages

What's this PR?
Based on the feedback on this PR @timneutkens asked me to create a test for ssr: true
What's it do?

adds a test for setting ssr: true - /basic
adds a test for setting ssr: true - /production

Awesome! Thanks! 🙏 🙌


[Bug] can not get context after an async operation in a middleware

This code will throw error:
http.use(async (req, next) => {
  const a = useReq();
  await delay(1000);
  const b = useReq();  // Error: Can't call useContainer out of scope, it should be placed on top of the function
  return Response.json(a === b);
});

The core problem is at
https://github.com/Lucifier129/farrow/blob/877d04f97ca260927483bb3db0ee7a4ef32d05a5/packages/pipeline/src/hook.ts#L29-L36
Once f is an async function, only the code before the first await will be run in the container scope.
I have came up with an idea to solve this problem.
https://github.com/Lucifier129/farrow/blob/877d04f97ca260927483bb3db0ee7a4ef32d05a5/packages/pipeline/src/pipeline.ts#L92-L102
Change all our middleware to generator function, and change the runHooks to a generator runner like co.
I'd like to draft a PR, but this will change a lot, so asking you.

It seems change async to generator is still not ok. What if the user run an async function in a async function in a generator function like:
async function some_async_fn() {
  const a = useReq();
  await delay(1000);
  const b = useReq();   // Error: Can't call useContainer out of scope, it should be placed on top of the function
  console.log(a === b);
}

http.use(function*(req, next) {
  const a = useReq();
  await some_async_fn();
  const b = useReq();
  return Response.json(a === b);
})

We need the user change all their async function to generator function. 😱 I don't know.

It seems change async to generator is still not ok. What if the user run an async function in a async function in a generator function like:
async function some_async_fn() {
  const a = useReq();
  await delay(1000);
  const b = useReq();   // Error: Can't call useContainer out of scope, it should be placed on top of the function
  console.log(a === b);
}

http.use(function*(req, next) {
  const a = useReq();
  await some_async_fn();
  const b = useReq();
  return Response.json(a === b);
})

We need the user change all their async function to generator function. 😱 I don't know.

It seems async_hooks can solve this problem. https://stackabuse.com/using-async-hooks-for-request-context-handling-in-node-js/

It seems async_hooks can solve this problem. https://stackabuse.com/using-async-hooks-for-request-context-handling-in-node-js/

This is a known limitation, see doc.
Farrow previously has implemented the hooks based on async generator, but it results full of yield*.
pipeline.add(async function* (request, next) {
  let start = Date.now()
  let logger = yield* useLogger('time')
  let response = yield* next()

  logger.add(`path: ${request.pathname}, take time ${(Date.now() - start).toFixed(2)}ms`)

  return response
})

pipeline.add(async function* (request) {
  await sleep(500)
  return Json(request)
})

The current version of farrow hooks is simpler and easy to use, although it has some limitations.
We can use some functional techniques to overcome the problem you met.
// a custom hooks that return async function, but itself is not async.
// It's higher-order function
function useSomeAsyncFn() {
  const a = useReq();

  return async (b) => {
       await delay(1000);
       console.log(a === b);
      return a === b
  }
}

http.use(function*(req, next) {
  // all of farrow-hooks place before the first await keyword
  const b = useReq();
  const someAsyncFn = useSomeAsyncFn()
  // call the async function returned by farrow-hooks
  const c = await someAsyncFn(b);
  return Response.json({  c });
})

I will look into async_hooks you suggested above to figure out whether it can improve farrow-hooks or not:)

This is a known limitation, see doc.
Farrow previously has implemented the hooks based on async generator, but it results full of yield*.
pipeline.add(async function* (request, next) {
  let start = Date.now()
  let logger = yield* useLogger('time')
  let response = yield* next()

  logger.add(`path: ${request.pathname}, take time ${(Date.now() - start).toFixed(2)}ms`)

  return response
})

pipeline.add(async function* (request) {
  await sleep(500)
  return Json(request)
})

The current version of farrow hooks is simpler and easy to use, although it has some limitations.
We can use some functional techniques to overcome the problem you met.
// a custom hooks that return async function, but itself is not async.
// It's higher-order function
function useSomeAsyncFn() {
  const a = useReq();

  return async (b) => {
       await delay(1000);
       console.log(a === b);
      return a === b
  }
}

http.use(function*(req, next) {
  // all of farrow-hooks place before the first await keyword
  const b = useReq();
  const someAsyncFn = useSomeAsyncFn()
  // call the async function returned by farrow-hooks
  const c = await someAsyncFn(b);
  return Response.json({  c });
})

I will look into async_hooks you suggested above to figure out whether it can improve farrow-hooks or not:)

async_hooks do solve this problem.
import Koa from "koa";
import { executionAsyncResource, createHook } from 'async_hooks';

const symbols: symbol[] = [];
function createContext<T>(value?: T) {
  const sym = Symbol('ctx');
  symbols.push(sym);
  (executionAsyncResource() as any)[sym] = value;
  return {
    get value(): T {
      return (executionAsyncResource() as any)[sym];
    },
    set value(nv: T) {
      (executionAsyncResource() as any)[sym] = nv;
    }
  }
}

createHook({
  init(asyncId, type, triggerAsyncId, resource: any) {
    const cr: any = executionAsyncResource();
    if (cr) {
      for (const sym of symbols) {
        resource[sym] = cr[sym];
      }
    }
  }
}).enable();

const app = new Koa();

const StringCtx = createContext<string>();

app.use(async (ctx, next) => {
  ctx.state.id = Math.floor(Math.random() * 1e7);
  console.log('id: ', ctx.state.id);
  await delay(1000);
  StringCtx.value = ctx.state.id;
  await next();
});

app.use(async (ctx, next) => {
  console.log('id + ctx: ', ctx.state.id, StringCtx.value);
  await delay(1000);
  console.log('id + ctx: ', ctx.state.id, StringCtx.value);
  ctx.body = ctx.state.id;
});

app.listen(4000, () => {
  console.log('4000');
});

Things works... 🎆

async_hooks do solve this problem.
import Koa from "koa";
import { executionAsyncResource, createHook } from 'async_hooks';

const symbols: symbol[] = [];
function createContext<T>(value?: T) {
  const sym = Symbol('ctx');
  symbols.push(sym);
  (executionAsyncResource() as any)[sym] = value;
  return {
    get value(): T {
      return (executionAsyncResource() as any)[sym];
    },
    set value(nv: T) {
      (executionAsyncResource() as any)[sym] = nv;
    }
  }
}

createHook({
  init(asyncId, type, triggerAsyncId, resource: any) {
    const cr: any = executionAsyncResource();
    if (cr) {
      for (const sym of symbols) {
        resource[sym] = cr[sym];
      }
    }
  }
}).enable();

const app = new Koa();

const StringCtx = createContext<string>();

app.use(async (ctx, next) => {
  ctx.state.id = Math.floor(Math.random() * 1e7);
  console.log('id: ', ctx.state.id);
  await delay(1000);
  StringCtx.value = ctx.state.id;
  await next();
});

app.use(async (ctx, next) => {
  console.log('id + ctx: ', ctx.state.id, StringCtx.value);
  await delay(1000);
  console.log('id + ctx: ', ctx.state.id, StringCtx.value);
  ctx.body = ctx.state.id;
});

app.listen(4000, () => {
  console.log('4000');
});

Things works... 🎆

Yes, I am working in process and it works in my local modification.
We can improve it in the next version of farrow

Yes, I am working in process and it works in my local modification.
We can improve it in the next version of farrow

farrow v1.5.0 was released.
In this version, we overcome the limitation of farrow hooks and refine the API of farrow context.
See the doc for more detail:)

farrow v1.5.0 was released.
In this version, we overcome the limitation of farrow hooks and refine the API of farrow context.
See the doc for more detail:)

So fast.

So fast.


Switching the active asset from OHM to gOHM causes a never-ending loading status

https://user-images.githubusercontent.com/91760036/234961425-24ac449b-f3ae-47c6-b412-2e9d7275d8c2.mp4
Introduced in #2779

Fixed using caching (useEffect hooks) and simplification of react-query hooks.


Change AttributeValue, EndSpanOptions and NetworkEvent to use autovalue.

Codecov Report

Merging #267 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
- Coverage     94.74%   94.65%   -0.09%
+ Complexity      438      414      -24
============================================
  Files            70       70
  Lines          1637     1573      -64
  Branches         96       89       -7
============================================
- Hits           1551     1489      -62
+ Misses           61       60       -1
+ Partials         25       24       -1

Impacted Files
Coverage Δ
Complexity Δ

...com/google/instrumentation/trace/NetworkEvent.java
100% <100%> (ø)
2 <2> (-5)
:arrow_down:

...m/google/instrumentation/trace/AttributeValue.java
100% <100%> (+5.55%)
4 <4> (-13)
:arrow_down:

...m/google/instrumentation/trace/EndSpanOptions.java
100% <100%> (ø)
3 <2> (-6)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3625be...bb040e5. Read the comment docs.


Extract skywalking-oap package in skywalking home dir

this doesn't solve the OOM issue, https://github.com/apache/skywalking/pull/11247 does, so closing this


Infer face_normals=True/False according to .use_smooth attribute of polygons

Hi folks! I believe, it would be really helpful to toggle the export of face/vertex normals naturally by using Shade smooth or Shade flat options in Blender. It can be inferred via .use_smooth property of faces on export stage.
If that makes sense, I can draft a PR.

Hello,
The add-on should already support exporting both flat & smooth shaded meshes by setting Mitsuba's face_normals flag as you can see below.
https://github.com/mitsuba-renderer/mitsuba-blender/blob/2b9365f3856c5ed8951962e385f1468426a16517/mitsuba-blender/io/exporter/geometry.py#L139-L141
If this does not do what you expect, can you please explain in more details what issue you are experiencing and how to reproduce it ? Also, can you indicate which version of Blender & the add-on you are testing this with ?
Thank you!

Which version of Blender are you using? This works with Blender 2.93 but something may have changed in later versions.

I am using Blender 2.93 and current master branch for the add-on

Oh, I actually double-checked with the sphere and it worked for me too... I did not understand yet why, but worked :)
Never mind, sorry for raising the issue and thank you for looking into that!


Solution Inspector improvements

Check for duplicate files. Increased scope of search to include CLInclude elements.
IT-334

Would be nice to update the top-level README file according to these changes, to give people an idea on how to use the new parameters.
I think I'll just merge and add these afterwards.


Writing CDB file with SOLID187 elements

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
I've encountered an issue when trying to write a CDB file containing SOLID187 elements using the ansys.mapdl.reader.archive.save_as_archive() function.
Apparently, when writing a pyvista mesh of these elements, the mid-nodes get discarded.
I'm creating a tetrahedral mesh consisting of SOLID187 elements using pymapdl:

The elements are 10-node elements with mid-nodes in between the corner elements:
APDL element data (one-indexed):
 mapdl.mesh.elem[0]=array([  1,   1,   1,   1,   0,   0,  14,   0,   1,   0, 169, 167, 101,
       171, 157, 172, 173, 174, 175, 176], dtype=int32)

The last 10 entries of this vector are the node numbers that make up a single SOLID187 element.
When saving this mesh as CDB file from APDL using the CDWRITE command the resulting element entries in the file also have 10 unique nodes:
...
EBLOCK,19,SOLID,       100,       100
(19i10)
         1         1         1         1         0         0         0         0        10         0         1       169       167       101       171       157       172       173       174
       175       176
...

Next, I'm converting converting the APDL mesh to a pyvista / VTK mesh (in my case I want to do some modifications / label certain parts of the mesh using python).
In pyvista, each element still is made up of 10 unique nodes (4 nodes at the corners, 6 mid-nodes) as confirmed by the inspection of the node data:
VTK element type:
 g.cell[0].type=<CellType.TETRA: 10>
VTK element data (zero-indexed):
 g.cells[1:11]=array([168, 166, 100, 170, 156, 171, 172, 173, 174, 175])

Here's a visualization:

However, if I now save the pyvista mesh as a CDB file using ansys.mapdl.reader.archive.save_as_archive() the resulting elements only contain 4 unique nodes while the rest are duplicates of other nodes (similiar to if they were SOLID185 elements in the tedrahedral configuration):
...
EBLOCK,19,SOLID,       100,       100
(19i8)
       1       1       1       1       0       0       0       0      10       0       1     169     167     101     101     171     171     171     171
...

Is there a way to output a CDB file for SOLID187 elements with the correct nodes (including the mid-nodes)?
📝 Steps to reproduce
Full code to reproduce the above results:
import pyvista as pv

from ansys.mapdl.core import launch_mapdl
from ansys.mapdl import reader as pymapdl_reader

mapdl = launch_mapdl()
print(mapdl.directory)
mapdl.prep7()

# create a tetrahedral mesh with SOLID187 elements
L = 1
mapdl.block(x1=0, x2=L, y1=0, y2=L, z1=0, z2=L)
mapdl.et(1, "SOLID187")
mapdl.vmesh('all')
print(mapdl.mesh)
mapdl.eplot(savefig='ansys_mesh.png', off_screen=True)

# -> elements with 10 unique nodes per element (including mid-nodes)
print(f"APDL element data (one-indexed):\n {mapdl.mesh.elem[0]=}")

# write CDB file
mapdl.cdwrite('DB', 'apdl_archive.cdb')

# export APDL mesh to VTK
grid = mapdl.mesh.grid

# plot mesh including mid-nodes
mb = pv.MultiBlock([grid, pv.PolyData(grid.points)])
mb.plot(off_screen=True, show_edges=True, screenshot='vtk_mesh.png')

# data of first element
# VTK element type = 10 -> tetrahedral elements with 10 nodes (including mid-nodes)
print(f"VTK element type:\n {grid.cell[0].type=}")
print(f"VTK element data (zero-indexed):\n {grid.cells[1:11]=}")

# output VTK data as CDB archive
pymapdl_reader.save_as_archive('vtk_archive.cdb', grid)

mapdl.exit()

💻 Which operating system are you using?
Linux
📀 Which ANSYS version are you using?
2023 R1
🐍 Which Python version are you using?
3.10
📦 Installed packages
ansys-api-mapdl==0.5.1
ansys-api-platform-instancemanagement==1.0.0b3
ansys-mapdl-core==0.63.4
ansys-mapdl-reader==0.52.13
ansys-platform-instancemanagement==1.1.1
appdirs==1.4.4
certifi==2023.5.7
charset-normalizer==3.1.0
contourpy==1.0.7
cycler==0.11.0
fonttools==4.39.4
geomdl==5.3.1
googleapis-common-protos==1.59.0
grpcio==1.54.2
idna==3.4
imageio==2.29.0
importlib-metadata==6.6.0
kiwisolver==1.4.4
matplotlib==3.7.1
numpy==1.24.3
packaging==23.1
pexpect==4.8.0
Pillow==9.5.0
platformdirs==3.5.1
pooch==1.7.0
protobuf==3.20.3
protoc-gen-swagger==0.1.0
ptyprocess==0.7.0
pyiges==0.2.1
pyparsing==3.0.9
python-dateutil==2.8.2
pyvista==0.38.6
requests==2.31.0
scipy==1.10.1
scooby==0.7.2
six==1.16.0
tqdm==4.65.0
urllib3==2.0.2
vtk==9.2.6
zipp==3.15.0

I think we are going to attack this issue later in the year, when we start to work on the MAPDL backend.


US 1637896 - Loc content review and fix.

User Story 1637896: Content Update - Localization fix: Windows Server Docs - M44486 Content review
Line 54: Filled in missing words and clarified the meaning of this section.

#sign-off

@illfated It looks like this has passed reviews. Can it be merged?  The Loc team is wondering about the status and would like to get these changes in. Thanks!

Thank you for mentioning me, I wish I were able to oblige in this matter. I am merely an external user and contributor to this repository and the Windows IT Pro docs.
@lizap : As the document author, will you be able to follow up on this PR for final review? Or should we wait for the doc manager @DonGill to handle this?

#sign-off

@Heidilohr : Do you know if there are anyone else available to follow up on this typo & grammar improvement solution, besides the already mentioned document author and the manager? Or would it be useful to assign this issue ticket to the relevant person for final review & merge?

@ItzLevvie @illfated @Heidilohr @DonGill It looks like this change has passed two reviews. If there are no suggested changes, the Localization team would like to get this merged. Thanks!

@v-thpra : Please note that both ItzLevvie and I are ordinary users (not employed by MS), so we need to be patient for reviews by the document author & the manager employed by Microsoft.
I acknowledge the fact that it seems confusing that ItzLevvie and I have added our non-affiliated approvals. We have acted in good faith, offering our free time and general knowledge to suggest that the PR content is good enough for final review by either the document author or the team manager for this section of the repository. I apologize for the confusion it has brought you in this case.

@illfated Thanks for explaining that, and thank you very much for your review and your efforts on this PR to help me find the correct person to sign-off on it.

#sign-off

@v-thpra Something seems to be up with GitHub at the moment, so I'm going to ask the admin to merge this for you. The pull request should send you a notification when it merges.

@Heidilohr Thank you!

I could be wrong, but seeing that the users with write access to the repository have shown green tick marks when approving in previous cases, it looks as if none of us users here have merge access for this PR.
(As previously stated, I could very well be mistaken about this detail.)

@illfated  @v-thpra  I believe the reason you can't see the merge button is because you are in the public repo. But I could be mistaken if this is typically where you make your changes. I'm going to go ahead and merge your changes now.

Fair enough, thank you for your reply. I was mostly concerned about MS Docs team members without merge access, because it is obvious that the PR author and I don't have access. A simple example would be mapalko, who is a document author of several articles, but he does not have merge access. When he approves an article, his approval tick mark is black, just like the 3 here in this PR. This is in contrast to those who do have merge access, where you will see a green approval tick mark when approving a PR where you do have merge access.
That is as condensed as I can make it, to point out why Heidi Lohr commented about not being able to merge this PR.

@illfated  We actually don't allow merge permissions to people outside of specific writing or administrative groups. While the writers/admins typically don't edit content for people that are seen as subject matter experts or in self-serve status, we do still take a look to make sure nothing breaks our builds before merging. If you need a review quicker than you're seeing it, I suggest the following: 1) Create your content in the private repo (if you're a Microsoft employee), 2) Add windowsservercontent as a reviewer (this notifies the writers), and 3) Add # sign-off (without the space after the #) in the comments. This will change the article status and tell us it's ready for final review and publish if everything looks okay. If you can't work in the private repo, you can @ mention the windowsservercontent group and it should still notify the writers that you're ready for a review.

Thank you for your detailed answer, appreciated. Useful details, I will keep those in mind.


[feat] Add support not to clear the input on error

resolves #30
What happened 👀

Add clearInputOnError option to not clear the input on error.

Proof Of Work 📹
There are quite many samples in this demo project, so I decided to update the third sample to set clearInputOnError = false.
https://github.com/user-attachments/assets/aa174dba-9c59-4c98-86b5-68e924dc5895

Looks great thank you for the contribution 🚀


Small problem.

So the demo working good but when I open firefox and chrome at the same time, I click at send notification and just one browser which I clicked receive the message.
2 browser running in the same localhost, so do they suppose to both receive the notif?
Just asking, if it not how that work, it's fine.
Thanks for the demo.

Thats normal because each browser have the own channel (Demo Setup)
In  my case:
channel-57287fce-4b96-XXXXXXXX for Firefox
channel-bcde201b-0e47-XXXXXXXX for Chrome
Best regards Joachim


fix(tests): mock requests during unit testing

Description
Mock functionality on tests. We allow the OMXS30 test to NOT BE MOCKED ON NASDAQ. This is a relatively small index so we can generate the traffic. However, all other tests should/are mocked (yfinance get requests).
Also, add show bool arg to dataset.visualize() func to avoid warnings during test
Is this change linked to an existing issue?

[x] #14

Any other relevant reference?

https://stackoverflow.com/questions/11836436/how-to-mock-a-readonly-property-with-mock
https://www.fugue.co/blog/2016-02-11-python-mocking-101
https://github.com/ranaroussi/yfinance/blob/308e58b914a065f33402bdcb3ed72e2b2d881f64/yfinance/base.py#L435

Bypassing branch rules, need to get this through for other changes.


Doesn't work inside pyenv virtualenv

Installed this with the hope of moving away from pipenv
Running within pyenv virtualenv for python 3.7 throws a ModuleNotFound error.
Traceback (most recent call last):
  File "/Users/developer-3/.pyenv/versions/leadflo/bin/pipm", line 5, in <module>
    from pipm.__main__ import main
  File "/Users/developer-3/.pyenv/versions/leadflo/lib/python3.7/site-packages/pipm/__main__.py", line 20, in <module>
    from pipm.commands import (
  File "/Users/developer-3/.pyenv/versions/leadflo/lib/python3.7/site-packages/pipm/commands.py", line 8, in <module>
    from . import file
  File "/Users/developer-3/.pyenv/versions/leadflo/lib/python3.7/site-packages/pipm/file.py", line 8, in <module>
    from pip._internal.download import PipSession, get_file_content
ModuleNotFoundError: No module named 'pip._internal.download'

$ pip --version
pip 20.1 from /Users/developer-3/.pyenv/versions/leadflo/lib/python3.7/site-packages/pip (python 3.7)

what is the version of pipm? you could view by pip show pipm

pipm-19.3.5
seems that's what's on pypi

seems like the latest release failed. I will run it again.

I have pushed a new version that support pip>=20.1


python3Packages.pyclimacell: init at 0.18.0

Motivation for this change
Python client for ClimaCell API
https://github.com/raman325/pyclimacell
This is a Home Assistant dependency. Currently the Home Assistant tests for the climacell integration are outdated. Fix will be releases with 2021.5.x.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119079 run on x86_64-linux 1

2 packages built:

python38Packages.pyclimacell
python39Packages.pyclimacell

@ofborg evaö


20947 - Fix limited restoration to full filing saves or resumes with company Name change

Issue #: /bcgov/entity#20947
Description of changes:

Added isLimitedRestorationToFull condition to shouldShowUndoButton logic
Enhanced nameChangeHandler to properly handle numbered company names
Added logic to set legal name for numbered companies to satisfy Legal API requirement
Updated shouldShowEditedLabel to include Limited Restoration to Full scenario

Notes:

This is a temporary easy solution until we can implement the refractory long-term fix in ticket #20827

Test Screenshots:
Test locally with these scenarios:

[x] CC (Community Contribution Company) BC0884776
[x] BC (Limited Company) BC0884805
[x] BEN (Benefit Companies) BC0884873
[x] ULC (Unlimited Liability Company) BC0884875

Before Fix (Using Limited Company as an example):

After using the incorporation number as the name and clicking "save and resume later"
Upon resuming, the button incorrectly shows as "Edit"

After Fix:

Scenario 1: Numbered Name

After save and resume, button correctly shows as "Undo"

Scenario 2: Non-Numbered Name

After save and resume, button correctly shows as "Undo"

Results:

Submitted this filing successfully

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app

/gcbrun

Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app

/gcbrun

Temporary Url for review: https://business-edit-dev--pr-606-zy7umcr4.web.app


Rroux plugin warnings

Turn on warnings by default
Remove the warning about the plugin reset function

 All committers have signed the CLA.


Plugin Datasource not working with Grafana 8.0.5

Upgrading to grafana 8.0.5 causes the plugin to stop working
Error on the Frontend:
Error: Failed to fetch Instantiating https://dashboards.diennea.lan/public/plugins/alexanderzobnin-zabbix-app/datasource-zabbix/module.js Loading plugins/alexanderzobnin-zabbix-app/datasource-zabbix/module
Grafana logs dosen't show any error

Grafana
Zabbix
Grafana-Zabbix Plugin

8.0.5
5.2/5.4
latest installed by cli

I second this, have the same issue also

It works now with grafna 8.0.6


Access Global Variables Using R

I can see documentation on python and SQL to access the global variable like execution_date. However,  I couldn't find a way to get the context for R, and further access to the global variables is not documented here https://docs.mage.ai/guides/r-blocks. Anything I missed here? Appreciate your help!

Hello @ChengzhiZhao,
Have you tried using something like this:
library("pacman")
p_load(dplyr)

transform <- function(df_1, ...) {
    # Specify your transformation logic here
    # Return value: transformed dataframe.
    df_1 <- filter(df_1, Pclass < 3)
    df_1
}

The values after the df_1 argument should contain the variables like execution_date.
Also, for instant response and faster help, you can join the Mage community Slack (https://www.mage.ai/chat) and get instant replies.
I’d also love to hear more feature requests from you as well.
Thank you so much for your amazing blog!

Hello @ChengzhiZhao, we just recently added support for using global variables and runtime variables in R blocks.
Please pull the latest docker image and use this in your code:
global_vars['execution_date']

@ChengzhiZhao did this work for you? If it works, please let us know. Then, we’ll close this issue.

Thanks @tommydangerous I can verify with the latest build, right on time this PR merged 20h ago https://github.com/mage-ai/mage-ai/pull/1845. I close the one now.

One small suggestion is to update the variable tab with more instruction for SQL and R (or point to the documentation link)

We'll update the UI and documentation to reflect those changes. Thank you so much for suggesting!

One small suggestion is to update the variable tab with more instruction for SQL and R (or point to the documentation link)

Hi @ChengzhiZhao, just FYI the Variables tab has been updated with more details for SQL and R blocks per your suggestion. https://github.com/mage-ai/mage-ai/pull/2153


Sema: Inherit SPI groups when synthesizing modify accessor

When synthesizing a _modify coroutine for a property, ensure the implicit declaration gets the same SPI groups as the property setter since they should have the same visibility.
Additionally, diagnose the exportability of references to accessors. Previously resilience type checking assumed that accessors always have the same exportability as their storage, but with @_spi accessors this is no longer the case.
Resolves rdar://108069565

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS


Improve tlog-accept address checking, if still needed

tlog-accept address checking, added at #539, might need some improvement as pointed by https://github.com/zero-os/0-Disk/pull/536#discussion_r147294312
Honestly i still don't understand why we need this feature, should be removed if we don't need it anymore

Honestly i still don't understand why we need this feature, should be removed if we don't need it anymore

This is still used. The problem is, during VM live migration there is two nbdserver started at the same time. When we change the tlog server of the nbd config we can't know which nbd will try to contact the tlogserver first, so we need this mechanism to be sure it's the correct nbd that connnect to the tlog.
I agree this is not the most clean way to do this, but I don't think ecd watcher gives us any other way to achieve this.

Why not define a new tlogServerCluster? And only use the new tlogServerCluster for the new nbdserver? This way only the new nbdserver will try to connect to it, no?

@glendc not sure I understand what you propose. There is only one unique Nbdconfig per vdisk, how do we make the old nbdserver not see they to connect to the same tlog server as the new one?

Oh right. Forgive me, I just woke up when I wrote that. My proposal is indeed not possible.


Kargo does not honor Argo CD sync windows

Description
Kargo replicates the Argo CD server sync logic, but I believe misses out on the sync window check:
https://github.com/argoproj/argo-cd/blob/ef37b3975406ac58bd527990d247071f38198963/server/application/application.go#L1812-L1814
Kargo should honor the sync window of an AppProject, since users often use this to prevent deploys at a certain time.
Steps to Reproduce
Promote a Stage backed by an Argo CD application and where the AppProject itself is in a window
Version
v0.6.0

I think https://github.com/akuity/kargo/issues/1328 may supersede this.

I agree. At this point we've isolated about 90% of Kargo's integration with Argo CD to the argocd-update step and the goal is to eventually get that to 100%. So a solution that doesn't rely on other parts of Kargo being tightly coupled to Argo CD is preferable. I'll close this in favor of #1328

Reopening based on user feedback where #1328 would not be sufficient. For this user, not everything will be managed by kargo pipelines they already heavily use argo cd sync windows. They do not want some things to be managed by kargo windows and others to be managed by an Argo CD window. So they prefer to rely solely on Argo CD windows and Kargo to just honor it.
This is how I think the feature should work: today, we blindly set the .operation on an application without considering the Argo CD window. Instead, we should consult the window before setting the operation. If the window is closed, the step will remain in a Running phase until the window is open. As a result, the Promotion will also remain Running indefinitely, which I would argue is the expected behavior.
This should satisfy the requirement that argo cd logic is still mainly isolated to the argocd-update step.

Ah. This makes sense. When we spoke offline, I was questioning how Kargo was supposed to honor Argo CD sync windows when Kargo isn't managing an App. I see now that the real desire is to manage sync windows entirely in one place, regardless of whether Kargo manages the App or not. Makes perfect sense. And easy to do.

We can do this in v1.2.

I'm reclassifying this as an enhancement. This wasn't a bug. It was just functionality we hadn't built.

Argo CD has fixed this as of v2.11 so that the AppController enforces sync windows instead of only relying on the API server to do so.
I'm going to keep this issue open, but re-categorize it as a doc issue.
I'll update docs to note that sync windows are respected only if using Argo CD v2.11+ and that if you anticipate encountering an active deny window, you should set the timeout on your argocd-update step accordingly.


   The "Loving" choice in personality section drops down a line instead of staying on the row.   And the button text on some buttons overflow or are too far to the right.
Browser Information

Browser Name, Version:
Firefox, 51.0.1 (64 bit)
Operating System:
MacOS
Mobile, Desktop, or Tablet:

Screenshot

Closing as duplicate of https://github.com/freeCodeCamp/freeCodeCamp/issues/7842. Feel free to continue the conversation over there in case your concerns haven't been addressed yet. Happy coding!


Would like to merge

Hi @FrancescaFr - no need to merge with the original repo. Let me know if you require any help.


Repeated document formatting adds unnecessary new lines

Describe the bug**
Steps to reproduce
Have the following setup:
.editorconfig
[*.fs]
indent_size=4
fsharp_max_array_or_list_width=20
fsharp_max_elmish_width=10
fsharp_single_argument_web_mode=true
fsharp_multi_line_lambda_closing_newline=true
fsharp_record_multiline_formatter=number_of_items
fsharp_max_record_number_of_items=1
fsharp_disable_elmish_syntax=false

Some random file, App.fs for example:
[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [
        ]
        Html.div [
            Html.text "hola muy buenas"
        ]
    ]

And just Ctrl + Shift + I multiple times
Link to sample reproduction
I don't think it is necessary
Expected behaviour
To be formated like this:
[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div []
        Html.div [
            Html.text "hola muy buenas"
        ]
    ]

However, it gets formated like this:
[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [

        ]
        Html.div [
            Html.text "hola muy buenas"
        ]
    ]

Which I really don't mind, but the issue is whenever I reformat again the document without changing anything, the format output adds new unnecessary lines:
[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [

        ]
        Html.div [
            Html.text "hola muy buenas"
        ]

    ]

// And on, and on...

[<ReactComponent>]
let Dashboard () =
    Html.div [
        Html.div [

        ]
        Html.div [
            Html.text "hola muy buenas"
        ]

    ]

After some testing I found out that just passing an array with a null inside instead of an empty array solves the issue, but I'd expect to work both ways as expected
Machine info

OS: Linux
.NET SDK version: 5.0.103
Ionide version: v5.3.2

Hello @not-rusty,
Ionide is using Fantomas for the formatting. I think you should open the issue there so @nojaf and others can take a look at it.

Yes please, could you report an issue using https://fsprojects.github.io/fantomas-tools/#/fantomas/preview please?

Closing as an upstream issue.


Add try_current_local_offset

Currently if time library failed to get local offset it returns UTC offset. In my case I get datetime from device with local offset and converting them to OffsetDateTime via PrimitiveDateTime::new(date, time).assume_offset(UtcOffset::current_local_offset()). But if current_local_offset fails to get local offset my program will return wrong time. I'd like to return error in this case.

I can definitely do this — the current method is actually a wrapper around a try_ method anyways.

OffsetDateTime::try_now_local() also will be useful.

Done on master!

@Y0ba FYI this has just been released in 0.2.8.


Please update to v25.0.0

Thanks a lot for this!

@dfroberg I didn't receive notification for this item, so couldn't respond back on time. I am on it right now, due to some time constraints I won't be able to test this though. Let me know if you could test and let me know if things work well.

@dfroberg images have been published :)


Allow configuring provision handler to combine user roles

Moved from: https://wso2.org/jira/browse/IDENTITY-5576
When federated authentication is configured and syncing user roles from an external identity provider, locally configured user roles are removed and replaced with roles provided from an external identity provider.
There can be use cases where instead of removing locally configured roles, retaining both locally configured roles for a user and roles configured in the external identity provider.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


[bug] Stack, Grid, Container aren't usable as base for additional components

Steps to reproduce
Live example.

Try to create a custom component (using styled) based on top of Pigment CSS' Stack, Grid or Container.

Current behavior
Cannot read properties of undefined (reading 'values') is thrown.
Expected behavior
A working custom styled component.
Context
No response
Your environment

npx @mui/envinfo
  System:
    OS: Linux 5.0 undefined
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  Browsers:
    Chrome: Not Found
  npmPackages:
    @emotion/react:  11.13.0
    @emotion/styled:  11.13.0
    @mui/private-theming:  6.0.0-dev.20240529-082515-213b5e33ab
    @mui/styled-engine:  6.0.0-dev.20240529-082515-213b5e33ab
    @mui/system:  6.0.0-dev.240424162023-9968b4889d
    @mui/types:  7.2.15
    @mui/utils:  6.0.0-dev.20240529-082515-213b5e33ab
    @types/react: latest => 18.3.3
    react: latest => 18.3.1
    react-dom: latest => 18.3.1
    typescript: latest => 5.5.4

Search keywords: stack, grid, container, styled

I finally got around to look at this and found that the issue here was that you were trying to use these components without setting up breakpoints in the theme. Adding this -
theme.breakpoints = {
  values: {},
};

after the theme definition in the vite.config.ts file fixed the issue.
@siriwatknp We should probably update the docs to mention this.

Why does it break with:

const StyledStack = styled(Stack)({
  margin: 8,
});

and works with?
const StyledStack = Stack;

I would expect a consistent behavior.

@pigment-css/react/Stack feels risky from a product perspective. Could we remove this? Maybe have @pigment-css/react-layout/Stack or anything not using the same npm package.
+1 to update the docs
If we take a path of making theme.breakpoints.values required to be defined, it looks like we should have a dedicated throw error message when it's not done correctly, so it's clear (and like to 3.)


Support for  tag within markdown

Hi, just found and love this package. Works great, thanks for making it.
For my application, https://github.com/enricoros/big-agi, it would be semantically really useful if <mark>sometext</mark> tags within the text itself could be supported by this lib, in the same way ==sometext== does. This is because == can appear within chats with greater frequency (AI generates code blocks and text blocks all intertwinded and can commonly be messy and produce false positives), while with <mark>, we can semantically make the app understand that the user meant to highlight.
Would it be possible to have an option to treat the <mark> tag like the highlight?
Thank you.

The <mark> tag should be a native html tag, so is it possible to just add the css to enable the marker?
mark { background-color: yellow }

@widcardw thanks for the prompt answer. You're probably right, actually: I'm sure you're right and know much more than me.
I've fully implemented the integration and the way I do it is: I have a <mark/> element (both AI or the user can use them) in the text, and before giving it to markdown I replace the <mark> with ==.
This way I keep the semantics of the text and then use this plugin for rendering.
You may consider it as an extra to support the <mark> element, so that people will have a single go-to plugin for their highlight needs.

After searching some remark and rehype plugins, the rehype-raw plugin may meet your need. It will parse the raw nodes again and recognize the embedded <mark> tag.
The remark-mark-highlight plugin is designed for editors like Typora and Obsidian so that the double equal sign syntax can be easily parsed as highlighted text, but the LLM may be pretrained as using embedded <mark> tag to highlight some text. As a result, using rehype-raw may be better.

Thank you for the follow up. Makes perfect sense. thanks again.


Issues with index exports and NG >4.4.4

Hi there,
Thanks for this great starter. It has been really helpful.
In my project I am using a core library, which shares services and Redux (NgRX) files between the Web and the Mobile App. For this purpose I have split the files into subdirectories (NgRX creates much boilerplate), which have index.ts files that export the .ts files contained. Example.
In the main index.ts I am doing the following:
import { NgModule, ModuleWithProviders } from '@angular/core';
import { CommonModule } from '@angular/common';
import { GeocodeService } from './services/geocode.service';
import { HttpService } from './services/http.service';
import { LoginService } from './services/login.service';

export * from './services/geocode.service';
export * from './services/http.service';
export * from './services/login.service';
export * from './modules/person';
export * from './modules/auth';
export * from './modules/interaction';
export * from './modules/settings';
export * from './modules/tags';
export * from './common';

@NgModule({
  imports: [
    CommonModule
  ],
  declarations: [
  ],
  exports: [
  ]
})
export class MhCoreModule {
  static forRoot(): ModuleWithProviders {
    return {
      ngModule: MhCoreModule,
      providers: [GeocodeService, HttpService, LoginService]
    };
  }
}

Up until Angular 4.4.5 this used to just work. With 4.4.5 (presuming that it is the compiler here, since ngc fails) the compilation process issues errors with the subfolders:
Error: Could not resolve './modules/person' from build/index.js
    at error (/Applications/MAMP/htdocs/memberhive2/core/node_modules/gulp-rollup/node_modules/rollup/dist/rollup.js:185:14)
    at then.resolvedId (/Applications/MAMP/htdocs/memberhive2/core/node_modules/gulp-rollup/node_modules/rollup/dist/rollup.js:9804:8)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
error Command failed with exit code 1.

Maybe you can have a look into this since Angular is busy changing the compiler quite a bit (with view of NG5 being in RC now).
I am lost for solutions, except for fixing NG at 4.4.4.

Try this :
export * from './modules/person/index';

@raphael-volt Thanks, that did the trick. But why??


Added new Deployment Types

Added new deployment types to deploy Azure Automation runbooks, DSC configurations and modules.
The deployment type for Azure Automation modules supports deployment from a public PS repository like PowerShell Gallery, from a private repository like Azure Artifacts private NuGet feed, and from a local source path. To support the deployment from a public or private PS repository, the 'SourceIsAbsolute = $true' option is used in deployment configurations. See, the deployment script help for the configuration snippets.
Any suggestions for improving the test cases are highly appreciated.

FWIW - I have very little time for work, let alone open source things nowadays - happy to poke around quick things, but stuff like pull requests will fall even further behind the very large list of things I haven't gotten to - sorry!

FWIW - I have very little time for work, let alone open source things nowadays - happy to poke around quick things, but stuff like pull requests will fall even further behind the very large list of things I haven't gotten to - sorry!

No worries, I understand that. Are you considering introducing maintainers for the PowerShell modules you authored?

Bump

No worries, I understand that. Are you considering introducing maintainers for the PowerShell modules you authored?

I would certainly consider it!  Or a group/org of some sort.  Some day!  Anyhow, this seems good enough, and I don't see anyone else responding with concerns, so merging now : )


[tests-only] Spaces registry PR comments

Fixes comments from this PR: https://github.com/cs3org/reva/pull/2234

@refs Thanks for reviewing the spaces registry PR! I hope this fixes all points you mentioned.
See also https://github.com/cs3org/reva/pull/2372 for caching related comments
@butonic I couldn't answer some questions, can you please check https://github.com/cs3org/reva/pull/2234 (especially the comments where I mentioned you?)

thx for the cleanup


Update dependencies

Both js-yaml and yaml-languageserver-parser have been replaced with yaml.
jsonc-parser has been externalized.
All defaults are now specified explicitly.
The new property yamlVersion has been added to match yaml-language-server. The default is 1.2.
DiagnosticsOptions properties are now sorted alphabetically and documentation has been enhanced.

Closes #117

@remcohaszing I found two issues while testing this branch:

The autocompletion is not working correctly when you hover at the end of an object block, it gives suggestions from the parent block.
The deprecationMessage is not working anymore it throws an error for node.range.

Should I report those to the yaml-language-server guys?

The autocompletion is not working correctly when you hover at the end of an object block, it gives suggestions from the parent block.

I also recall some odd behaviour with this in VSCode YAML. I just thought it was me, but since you noticed this as well, please report an issue upstream. :)

The deprecationMessage is not working anymore it throws an error for node.range.

I’m not entirely  sure about this one. This needs further investiation.
As a rule of thumb: If the same issue occurs in VSCode YAML, it’s probably a bug in yaml-language-server. Otherwise it’s probably a bug in monaco-yaml.

I would like to release this in 4.0.0-alpha.1.


Fix snapshot tests

When running the snapshot tests, 3 of them fail, namely panic_verbose, successful_run_can_enforce_backtrace and panic_is_reported_as_such.
For one, setting up the canary takes a different amount of time.
Also name demangling seems to fail (see also  https://github.com/knurling-rs/probe-run/issues/201 )

Apparently the last good commit is 73ba0ccc90400c6dfd89005aab020917210fd5f6, Merge #253 . In between then and now there seem to be a changing number of failures.

https://github.com/knurling-rs/probe-run/pull/280 should fix the demangling?

I've re-ran the tests on main– this issue seems to be fixed by now (by #280?), but one test still fails due to updated logging statements– will open a separate PR for that


Compatibility issue

Hi,
i m trying to install pinocchio python library on a raspberryPi4.
The system is blocking the installation and says that the architecture (aarch64) is not supported at following stage: sudo apt install robotpkg-py27-pinocchio
On a linux virtual machine (architecture x86_64) installed on Windows OS, everythimng works fine.
Can you provide me with a workaround to solve this problem on the RaspberryPi4.
We are using Ubuntu 18.4.3 TLS on the RaspPi4.
Thanks in advance.

Dear @dadouz,
In short, current binairies are only available for amd64 architecture (not ARM). To install it on another architecture, I would advise you to rely on the following instructions to install all the dependencies using either robotpkg (https://stack-of-tasks.github.io/pinocchio/download.html#Install_3) or directly from sources (https://stack-of-tasks.github.io/pinocchio/download.html#Install_4).
Best,
Justin

The binaries provided via the ROS buildfarm should support arm

@dadouz Any feedback?

I will close this issue hopping that the problem is now solved.

I also tried to install pinocchio on an arm-based development board.
The OS run on the borad is Linux 4.1.15.
How could I get binaries provided via the ROS buildfarm?


Jsrt: External data support for DynamicObject

Adds API below to ChakraCore Jsrt;

JsObjectHasExternalData
JsObjectGetExternalData
JsObjectSetExternalData
JsObjectSetExternalDataWithCallback

Removes API from ChakraCore common Jsrt;

JsHasExternalData
JsGetExternalData
JsSetExternalData

Does this change allowing setting a finalizer too?

Does this change allowing setting a finalizer too?

@fatcerberus Yes, JsObjectSetExternalDataWithCallback

Looks solid 👍 . A few feedback/questions,

Why put the old APIs in ChakraCommonWindows.h? Either leaving them as-is or deprecating them in ChakraCore (a.k.a. they show up in ChakraFull not here) makes more sense. I tend to leave them as-is, but that's ofc up for debate.

Can I put ext data on any JsValueRef, or just objects?

I assume every time JsObjectSetExternalDataWithCallback is called, it will replace any previous finalizer set on the object, including the one from JsCreateExternalObejct. A following JsObjectSetExternalData call should set the finalizer to nothing. Am I correct?

@liminzhu I will put an external post to explain what is what in detail.
About JSRT; IMHO old JsHasExternalData.. confusing and not needed.

Definitely strange errors from CI
/Users/dotnet-bot/j/workspace/Microsoft_ChakraCore/release_1.7/static_osx_osx_debug_prtest/out/Debug/../../lib/Jsrt/ChakraCore.h:300:5: note: candidate function not viable: requires 4 arguments, but 5 were provided

Well... It's defined under ChakraCore.h:309.. not 300!..

Looks like the CI issue is related to branch / base difference among the headers... Updated to latest again.

Reminder; I'm just experimenting here. No promises. If your application depends on external data usage and current ChakraCore Jsrt is not helping, please let us know from https://github.com/Microsoft/ChakraCore/issues/3592
Current version;

External data support for non primitive JS types.
If, needed in the future, same interface can host additional properties on a DynamicObject without increasing its initial size.
No runtime / memory usage etc. change on anything that doesn't use external data.
Perf cost is limited to couple of if/else call - bool function (vtable)
Brings additional TypeHandler types. i.e. We had PathTypeHandler.. now we also have PathTypeHandlerWithExternal. The new interface is all about HasExternalDataSupport() virtual function is returning true. No additional logic update to original type handler.
Centralize the usage of auxSlots and internally manages under DynamicObject
Supports type handler sharing among the new object instances with external data.
Added native tests to make sure things work -> https://github.com/Microsoft/ChakraCore/pull/3639/files#diff-f2ba368ddfd5ff52839d16738442a504

What else needs to be done;

More testing!
Reduce the amount of ConvertToExternalData calls. (latest update to PR cleared the hot paths already)

@dotnet-bot test Copyright Check please

Without this change, is there a way right now to have a native constructor create an object with external data?  If I return a new object from a constructor directly, then subclassing it doesn't work :(

Was a good experiment and learned a lot. Thanks for the thumbs ups!
#3717 may help to implement such feature without changing the type system significantly


Update costs calculation methods

For the new categories in the costs chart we have to revise our cost calculation methods. Additionally, there are some other issues that have to be picked up. I am writing them all here as they are related. Feel free to split them up when necessary.
Split up the total costs
At the moment fuel costs, CO2 costs and CCUS costs are included in the total costs calculation. With the new categories these should be split up.
For example for a industrial burner:

the fuel costs should be part of the "Energy sources & import"
the investment and O&M costs should be part of the "Buildings/installations" category
the CO2 ETS costs and CCUS investment should be part of the "CO2-infrastructure, CCUS, compenation"

For this we need the following methods:

investment costs excluding CCS
variable costs excluding fuel costs

Avoid double-counting of fuel costs for produced carriers
We should avoid the double-counting of fuel costs. For example hydrogen that is produced with an SMR and then used in an industrial burner. In this case we should only include the costs for the gas used in the SMR and not the hydrogen fuel costs for the industrial burner. This double-counting is mostly the case for hydrogen as hydrogen has its own price. For electricity the price is set to zero in the graph. For heat double-counting is probably not happening at the moment, but we should check.
Export costs must be settled with import costs
At the moment the costs for export fuels are included in the total costs calculation (see this issue). These costs for exported fuels should not be included in the "Energy sources & import" category.
Improve naming of the costs calculation methods
At the moment the distinction between total costs (over lifetime) methods and yearly total costs methods is not clear. The method total_costs_per calculates the yearly total costs and the total_investment_over_lifetime calculate the total investment costs of lifetime, if I am right. It would be great if the names would better match with the method :)
Notifying @MartLubben @ChaelKruip

Hi @antw,
Thanks for the clear explanation. I have some questions in bold. I think that we could already start with the variable costs excluding fuel costs.

total_initial_investment - ccs_investment
This could be implemented either directly in the gqueries

I agree that this can be implemented in the queries and I am in favour of that. It will make it very clear that CCS is (as an exception) not part of the investment costs. Are these investment costs per year? Or in total?

Personally, I'm not convinced it's worth renaming all of these methods, but not doing so would make the naming of total costs inconsistent with all the others. Can we not assume anything cost-related is per year by default and only include a time period in the name ("over lifetime") in cases where this isn't true?

I like your thinking. Also I hear that it is not that difficult to change the names. I will maybe come back on this, but it does not have the highest priority. Is it correct that is does not create a lot of fallout if we change the names?

The double counting and and the settlement of export and import is more relevant for the query making than to the method change I think.

Is it correct that it does not create a lot of fallout if we change the names?

It creates a great deal of fallout, but most of it can be automated. Anywhere the name is referenced also needs to be changed to reflect the new name; there are probably a great many queries that use these cost methods.
The change in ETSource can be automated with a global search and replace, but it still needs a human review to ensure that the change doesn't break anything.

total_initial_investment - ccs_investment

Are these investment costs per year? Or in total?

:wink:
I believe both are one-off costs, paid then the plant is built.

I think that we could already start with the variable costs excluding fuel costs.

What would exactly be part of this method? As I understand the variable_costs are now:
weighted_carrier_costs + co2_emissions_costs + variable_operation_and_maintenance_costs

If you don't want to include the fuel and co2 emissions, couldn't you just use the variable_operation_and_maintenance_costs? Or am I missing something?

Very good question. I am not sure:
We need to get from a node the variable costs (ex fuel ex ccs), the yearly fixed costs incl investment (ex fuel ex ccs) and the CCS costs.
I have three questions @michieldenhaan:

Is co2_emissions_costs equal to all CCS costs?
Is variable_operation_and_maintenance_costs equal to variable costs (ex fuel, ex ccs)?
Do we have a method for yearly investment/fixed costs costs (ex fuel, ex ccs)?

Is co2_emissions_costs equal to all CCS costs?

Don't think so, you can check the description of the method out here:
https://github.com/quintel/etengine/blob/dc293e2ee2ae6a967e575a306d0db718d86c04dd/app/models/qernel/node_api/cost.rb#L262-L276

Is variable_operation_and_maintenance_costs equal to variable costs (ex fuel, ex ccs)?

I see now there is ccs in the variable_operation_and_maintenance_costs:
variable_operation_and_maintenance_costs_per_full_load_hour + variable_operation_and_maintenance_costs_for_ccs_per_full_load_hour

That css part has to go then? So we end up with just variable_operation_and_maintenance_costs_per_full_load_hour and possibly parts of co2_emissions_costs.

Do we have a method for yearly investment/fixed costs costs (ex fuel, ex ccs)?

There is a method called fixed_costs that "Returns the total fixed costs for one plant per year." I don't see any mention of fuel or CCS in there.

What is needed is the yearly costs of:

CAPEX = CAPEX ex CCS + CAPEX of CCS
OPEX  =  OPEX (ex fuel, ex CCS), OPEX CCS, fuels costs.

CAPEX of CCS = annualised ccs_investment
CAPEX (ex CCS) = annualised total investment - annualised CCS investment
OPEX CCS = variable costs of CCS + CO2 credits
OPEX (ex fuel, ex CCS) = variable O&M - Variable CCS O&M + fixed O&M


Fix BottomSheet focus issues

Fixes #563
Tested with Talkback on Android. Screen reader should now:

[x] Focus on and read title of HomeScreen view when BottomSheet is closed
[x] Focus on StatusHeaderView when opening the BottomSheet
[x] Scroll through BottomSheet

Let's optimize useAccessibilityAutoFocus hook too. If we have AccessibilityProvider, we don't need to call AccessibilityInfo.isScreenReaderEnabled().

This has been done, thank you @henrytao-me!


[WIP] Add discrete/continuous support+more samplers

addr #187 #171
PR should include:

[x] Support for more samplers (the design should be discussed)
[x] Support for compound step sampling (maybe it is hard one to implement because of over-reliance on batching in tfp)
[x] Support for discrete var sampling
[ ] Support auto_assign_method based on a set of certain criterias (like in pymc3)
[ ] More reach trace for compound step
[ ] More tests (they suck for now)

Current user design of compound step for user looks like this:
# the easiest one with automatic method assignment
# for each free var
model = ... # we define the model
pm.sample(model(), sampler_type="compound")
# user defines the methods for selected vars in model
from pymc4.mcmc.samplers import NUTS, RandomWalkM
pm.sample(model(),
    sampler_type="compound",
    sampler_methods=[
        ("var", RandomWalkM),
        ("mean", NUTS)
    ],
    xla=True)

There is currently support for categorical distribution mcmc sampling with custom state function, implemented in pymc4/distributions/state_functions.py, but more distributions should be tested and supported.

[x] Categorical
[ ] **should be added as its tested and supported

There are some problem with sampling discrete distributions with xla enabled. I will look at the issue closer.

@junpenglao can you please provide some feedback on the issues #233, I've implemented the sampling of the models with categorical distribution (with support of new_state_fn) but the implementation still relies on CompounStep. There is a brief notebook that will test sampling.

Sorry for some notebooks edited, tests do not pass without it. There are also some issues with notebook testing, radom example doesn't work on my local machine.

So basically, I had two ways of designing sampler methods. This PR implementation is similar to pymc3, which for me is more clear from user perspective. Another idea was to have MCMCSampler class with all the ops like sample, run_chains etc. and sampler subclasses that defined the parameters like kernel, adaptive_kernel, trace_fn and etc. Then _assign_default_methods method should be defined in MCMCSampler class (it is defined now in CompoundStep) so that user doesn't pass sampler_type argument, but the samplers are assigned automatically to each free var according to certain criterias. Basically, all the sampler methods are now the type of compound step. What I don't like about this design choice is how the parametrization for each sampler method is handled. S

I assume Unititled1.ipynb is not supposed to be there.


Feature/wildcard speedup

(don't review yet, still a WIP)
Speeds up uc_wildcard processing by about 40x

btw, if you convert it to draft PR the CI will run on every push, as well.


MB-7942 Update SM patch api to only update orders if move is in draft

Also update test so that the Orders/Move look more like they would when submitted, before a TOO gets to them.
Description
This was stopping a user from editing contact info after submitting their move.
Reviewer Notes
Anything weird?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make server_test

Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-7942

  Generated by :no_entry_sign: dangerJS against ca9a29a8e80c8c62859a3ad7d4617b40f5824b93


Prepare release v1.4.0

Update package version and changelog

@susodapop or @yunbodeng-db I updated changelog - could you please take another look before I merge this? thank you!


Add support for count(distinct ...)

Resolves #112

Coverage remained the same at 100.0% when pulling 16dd1c2cd6159a20db0850b9aea197e8659f1f2c on jeffgbutler:master into 86e398056920a0f50bf1d01652814fab1a03bf6a on mybatis:master.


Deep fill env

nuxt.config.js
env: {
  foo: {
    bar: {
      baz: "hi"
    }
  }
}

Before:
// process.env.foo.bar.baz
{ bar: { baz: "hi" } }.bar.baz

After:
// process.env.foo.bar.baz
"hi"

Codecov Report

Merging #2171 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2171      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.01%
==========================================
  Files          15       15
  Lines         968      974       +6
==========================================
+ Hits          943      949       +6
  Misses         25       25

Impacted Files
Coverage Δ

lib/builder/webpack/client.config.js
100% <100%> (ø)
:arrow_up:

lib/builder/webpack/server.config.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785948e...59169c9. Read the comment docs.

Hi @0pt1m1z3r
Thanks for the PR, I believe we can improve this, first of, fillEnv could be inside webpack/utils.js since it's used in two files.
Also, what about arrays?

Ok. I will move it to utils.
Arrays keys now need to write like .1.. I will fix it to [1]. And for
string keys that can not be write with dots.
21 нояб. 2017 г. 4:41 ПП пользователь "Sébastien Chopin" <
<EMAIL_ADDRESS>написал:
Hi @0pt1m1z3r https://github.com/0pt1m1z3r
Thanks for the PR, I believe we can improve this, first of, fillEnv could
be inside webpack/utils.js since it's used in two files.
Also, what about arrays?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nuxt/nuxt.js/pull/2171#issuecomment-346029591, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEtUgSdKqMwKc7UquMVeAwbGjxFtR9P0ks5s4tMWgaJpZM4Qk7gj
.

@Atinux
env: {
    items: [
      { id: 1, name: 'Kobe' },
      { id: 2, name: 'Michael' }
    ],
    foo: {
      bar: {
        baz: 'hello',
        'wi-fi': true
      },
      'a"-"b': {
        'b\'c': {}
      }
    }
  }

    console.log(process.env.items[0].id)
    // 1
    console.log(process.env.items[0].name)
    // "Kobe"
    console.log(process.env.items[0])
    // {"id":1,"name":"Kobe"}
    console.log(process.env.items[1].id)
    // 2
    console.log(process.env.items[1].name)
    // "Michael"
    console.log(process.env.items[1])
    // {"id":2,"name":"Michael"}
    console.log(process.env.items)
    // [{"id":1,"name":"Kobe"},{"id":2,"name":"Michael"}]
    console.log(process.env.foo.bar.baz)
    // "hello"
    console.log(process.env.foo.bar['wi-fi'])
    // true
    console.log(process.env.foo.bar)
    // {"baz":"hello","wi-fi":true}
    console.log(process.env.foo['a"-"b']['b\'c'])
    // {}
    console.log(process.env.foo['a"-"b'])
    // {"b\'c":{}}
    console.log(process.env.foo)
    // {"bar":{"baz":"hello","wi-fi":true},"a\\"-\\"b":{"b\'c":{}}}

@Atinux ping

Hi, I've an issue with the env variables, and I'm currently making a PR which will be in conflict with this one.
The issue is:
env: {
  FOO: 'bar'
}

console.log(process.env['FOO']);` //bar
`const key = 'FOO'; console.log(process.env[key]);` // undefined

I know how to fix it, but it involves to totally change the way the object which is putted in definePlugin is constructed.
@Atinux how do you want to process? Have you planed to merge this one? Can I integrate this PR in mine?
Merci pour la réponse 😉 !

Hi @mathieutu
Actually, it's Webpack which replaces the values of process.env.X but I'm happy to see if there is a solution to use variables like you do.
I plan to merge this PR into 2.0 since it's a breaking change. It would be awesome if you could work on a branch from this PR directly :)

Ok, I'll do that so.
I've just tried to do it in a module, it works perfectly with the "old" way to handle env variables.
@Atinux Do you know when you will release the 2.0? Maybe should I make a PR before to fix the 1.* version?

Sure you can already send a fix for the 1.x version :)
The version 2 will come in a month I believe

Hi!
Actually we don't need this PR anymore. 😅
https://github.com/nuxt/nuxt.js/pull/2171 handle this behavior directly without any trick.
@0pt1m1z3r I let you test your needs on my branch an let us know if it's ok for you?

@Atinux you can notify me when you want to merge this PR, and I will bring it to the actual code

Forgot to mention here that I finally merged this one with https://github.com/nuxt/nuxt.js/pull/2974, so no need to pull it. (Or it should be overwritten by the over.)
🙂


[Feature] Support CSS Grid

Opening this as a tracking issue.
I understand there is an intent for stretch to support CSS Grid in future, so for anyone interested in knowing when/if that happens, they can watch this issue for updates and/or show interest/support via :+1: reaction(to this issue, no +1 type comments thanks!).
While slightly biased due to React-Native using yoga for layout, there is strong interest in seeing CSS Grid support with little indication from yoga devs that the feature is on the horizon.

So I spent a day yesterday looking into what it would take to implement CSS Grid in Stretch. And I thought I would write up my findings.
Useful Resources:

CSS Grid Level 1 Specification: https://www.w3.org/TR/css-grid-1
CSS Grid Garden: https://cssgridgarden.com

MVP Implementation Plan:

[ ] Extend the Style and Geometry sections of Stretch to include definitions for CSS Grid styles, while ensuring that the existing Flex implementation continues to work:

[ ] fr units
[ ] grid-template-columns/grid-template-rows/grid-template-areas
[ ] grid-auto-rows/grid-auto-columns/grid-auto-flow
[ ] grid-row-start/grid-row-end/grid-column-start/grid-column-end
[ ] row-gap/column-gap

[ ] Implement resolving the "explicit grid". This is the rows, columns and areas (cells) as defined by grid-template-columns/grid-template-rows/grid-template-areas (Sections 7.1-7.4 of the spec)

[ ] Implement grid placement. Matching Grid Items (child nodes of the grid) to Grid Areas. This may include generating extra rows and columns that form the "implicit grid" if any Grid Items are placed outside of the bounds of the "explicit grid". (note: the "implicit grid" is the whole grid, not just the extra bit) (Sections 7.5-8.5 of the spec)

[ ] Implement the Grid Sizing Algorithm to determine the size of each Grid Area. This mostly consists of the Track Sizing Algorithm, iterated a few times. A Grid Track is a row or column of the grid. (Section 11 of the spec).

[ ] Resolve Grid Item (node) sizes, by matching them to the Grid Areas.

Further tasks for full support:

[ ] Implement gutters, spacing and alignment (Section 10 of the spec)
[ ] Implement absolute positioning (Section 9 of the spec)
[ ] Support for aspect ratios
[ ] Support for CSS Grid Level 2 (subgrids)

Blocking questions / issues:

How should Grid interact with intrinsically sized leaf nodes. The spec seems to define child nodes as having both a min-size (e.g. text node that wraps at all opportunities) and max-size (e.g. a text node that doesn't wrap at all). Possibly these would need to be added to nodes as additional  "measure functions"? Or possibly they could both be assumed to be equal to the one measure functions at first? Possibly min can be obtained by passing the MeasureFunc width: 0, height: 0, and max can be obtained by passing the MeasureFunc width: undefined, height: undefined? https://www.w3.org/TR/css-sizing-3/#intrinsic-contribution

@emilsjolander Does this look about right to you? Do you have any comments, corrections, or suggestions?

@nicoburns this looks like a very solid plan. The only thing I can see is missing is testing :) One of the first steps should be extending the current test harnesses to support Grid and then also adding a significant number of test cases.
Really looking forward to seeing how this progresses! Please open up a PR early in the process just so we can help comment and see what is going on :)

Very curious / excited to see where this goes!

Awesome!

Would this type of Grid layout be useful for a test case? It uses fixed columns counts(repeat() + 1fr) until 1200px wide, then minmax() with repeat() to auto-fit as many columns of a min/max limit.
Rows are also a bit dynamic, and previously was a bit more complicated to keep the cells properly packed without unwanted spaces at certain viewport widths and rows. fit-content() resolved all that along with pre-processing the images to specific aspect ratios rather than relying on grid and CSS alone. The older CSS and images for that are available in git history if you'd want to use those for additional testing.
Then dense row packing is used since without that, empty spaces would not be filled. I think it's a good example of CSS grid.
Current CSS for grid is like this:
  background-color: #191723;

  display: grid;
  grid-gap: 5px;
  grid-auto-flow: row dense;
  grid-auto-rows: min-content;
  grid-template-columns: var(--column-count, 1fr);

  @media (min-width: 320px) {
    --column-count: 1fr 1fr;
  }
  @media (min-width: 640px) {
    --column-count: repeat(3, 1fr);
    /* Beneficial from this breakpoint forward */
    grid-auto-rows: fit-content(350px);
  }
  @media (min-width: 960px) {
    --column-count: repeat(4, 1fr);
  }
  /* Limit the width of cells from this size onwards */
  @media (min-width: 1200px) {
    --column-count: repeat(auto-fit, minmax(280px, 1fr));
  }

  /* These breakpoints have some unfilled areas, fill them */
  @media (min-width: 640px) and (max-width: 959.98px) {
    > div:nth-child(23) {
      grid-row: span 2;
    }
  }
  @media (min-width: 1705px) and (max-width: 2274.98px) {
    > div:nth-child(20) {
      grid-row: span 2;
      /* override internal inline style */
      img {
        object-position: left !important;
      }
    }
  }
  /* 2560px is next breakage */

  /* Related CSS on Grid item components: */
  @media (min-width: 320px) {
    ${props => props.type === "wide" && "grid-column: span 2;"}
    ${props => props.type === "tall" && "grid-row: span 2;"}
    ${props => props.type === "big" && "grid-column: span 2; grid-row: span 2;"}
  }

If not on a desktop device, here's some different viewport widths to show off the grid adapting:

Here we've reached fixed column breakpoints, and you can see how the vertical/tall cell in the middle has a more narrow aspect ratio to pack nicely into the grid, despite sharing the same CSS and image dimensions as the other tall images.

Just noticed that I need to push an update to the live version as it's presently using older CSS(some CSS variables to do calc() scaling at <720px on grid row/col values), which aren't necessary with the fit-content() rule I had switched to. At <640px, grid-auto-rows should be auto or min-content so that the single row/col grid items produce variable heights for some more interesting packing/layout variation like shown on the right here beside that tall two row cell:

At <320px, every grid item is just 1 col/row spans:


Require.js compatibility

Is escodegen compatible with Require.js?  When required in, the generate method is undefined.

Has anyone solved this? It's still an issue.

This is still an issue, is there any plans to fix it?

Anyone that cares about this issue is free to send a pull request.

Has anyone solved this issue?


Add lint script to spell check using cspell

This can be added to CI later, for now it is a useful script to have in the repo to test against CPP/H/MD files.
Currently it reports no spelling issues for '**/*.cpp', '**/*.h', '**/*.md' files. I haven't taken a look at the rest of the filetypes yet. Script is based on the markdown lint script.

Planning to keep this script locally instead of storing in the repo. Can revisit this decision if other users become interested in it.


[VL] Support cross join type with Merge join and Hash join

Description
A join gets converted to hash join or merge join only when there are equi join conditions.
Consider query select * from Tbl1 cross join Tbl2 on Tbl1.c1 = Tbl2.c1 This join will be converted to hash join or merge join depending on data type and size. This query is equivalent to select * from Tbl1 inner join Tbl2 on Tbl1.c1 = Tbl2.c1.
Cross join with non equi join conditions will never get converted to hash or merge join. Considering these facts cross join with equi join conditions can safely be added to hash/merge joins.
There will only be need to add it in supported join type and it can be mapped to JoinRel.JoinType.JOIN_TYPE_INNER in substrait.

There is TODO in code to support it with crossRel but this will not be required.
object SubstraitUtil {
  def toSubstrait(sparkJoin: JoinType): JoinRel.JoinType = sparkJoin match {
    case Inner =>
      JoinRel.JoinType.JOIN_TYPE_INNER
    case FullOuter =>
      JoinRel.JoinType.JOIN_TYPE_OUTER
    case LeftOuter | RightOuter =>
      // The right side is required to be used for building hash table in Substrait plan.
      // Therefore, for RightOuter Join, the left and right relations are exchanged and the
      // join type is reverted.
      JoinRel.JoinType.JOIN_TYPE_LEFT
    case LeftSemi =>
      JoinRel.JoinType.JOIN_TYPE_LEFT_SEMI
    case LeftAnti =>
      JoinRel.JoinType.JOIN_TYPE_ANTI
    case _ =>
      // TODO: Support cross join with Cross Rel
      // TODO: Support existence join
      JoinRel.JoinType.UNRECOGNIZED
  }
}

Cross join with non equi join conditions will get converted to either BroadcastNestedLoopJoinExec or CartesianProductExec. Both of these will be supported with crossRel.

@zhouyuan @rui-mo Can you please check this issue and let me know if you see any issue with it?

@Surbhi-Vijay I think you are correct, the code is introduced by CK backend - maybe something different in CK impl


[Bug] When inventory is full and taking a picture, the image will simply disappear and cost a paper

What's the issue?
As said in the tile, this bug is not making the game unplayable but still a minor issue that is worth reporting
Screenshots
No response
Mod and Minecraft version
1.2.1, Fabric 1.20.4

Are you sure it doesn't get dropped on the ground? I just tested it, and if your inventory is full, it should just drop the picture item in front of you.

Huh, that's weird. I've been trying some combinations of things, but I can't seem to recreate it. I think it might be a compatiblity issue with another mod.
I also see the error message in chat, which indicates an issue on the server. I'm not sure if you've got access to the server logs (or client logs in case of a single player world), but if you do, and know how to, are you able to look if there's any error in there (just Ctrl+F search for "camerapture"), and send it here if there is? Thank you!

There you go, this log is after launching the game, a sp world, making my inventory full and trying to take a picture with the error message:
https://pastebin.com/qnyBEf5J

Ah, thank you so much, I see the problem now. It's a compatibility issue with the Concurrent Chunk Management Engine mod that happens when trying to drop the picture item in the world. It shouldn't be too much work to fix that! I'll get it done soon, thank you!!


:sleep! doesn't hide the cursor in gVim

To Reproduce

Run gvim --clean
Execute :sleep! 3 (the command is described at :help :sleep!). gVim sleeps for 3 seconds, but doesn't hide the cursor.

Expected behavior
The cursor should be hidden while gVim sleeps.
Environment:

Vim version 8.2.2632
OS: Windows 10 Home 1803
Terminal: GUI.

cc @jeremy-quicklearner via https://github.com/vim/vim/pull/7688
Also, not sure whether it's working as intended, or if it's just corner case, but the cursor is no longer hidden when a timer callback is processed:
vim -Nu NONE +'au CmdlineLeave : call timer_start(0, {-> 0})'
:sleep! 3

I don't have much insight into how Vim draws the cursor, but I can confirm that I only tested sleep! using Vim on the command-line.
After looking at the code, it seems that cursor_off() only applies to the terminal - not the GUI. It may be possible to modify update_screen() in drawscreen.c so that it calls gui_undraw_cursor() and then skips gui_update_cursor() if sleep! is ongoing. For that, we'd need some sort of ":sleep! is ongoing" flag.
As for the timer callback issue @lacygoill commented on: Looks like sleep and sleep! don't block Vim's event loop. Makes sense. I expect fixing this would require :sleep! to set some flag that later gets checked as part of the callback's event.
So to fix both of these issues, we need a flag that's accessible to both drawscreen.c and term.c. I don't know where best to put it... Perhaps someplace higher up where it can be passed down as a parameter. Maybe someone more experienced can weigh in?

Jeremy Lerner wrote:

I don't have much insight into how Vim draws the cursor, but I can confirm that I only tested sleep! using Vim on the command-line.
After looking at the code, it seems that cursor_off() only applies to the terminal - not the GUI. It may be possible to modify update_screen() in drawscreen.c so that it calls gui_undraw_cursor() and then skips gui_update_cursor() if sleep! is ongoing. For that, we'd need some sort of ":sleep! is ongoing" flag.
As for the timer callback issue @lacygoill commented on: Looks like sleep and sleep! don't block Vim's event loop. Makes sense. I expect fixing this would require :sleep! to set some flag that later gets checked as part of the callback's event.
So to fix both of these issues, we need a flag that's accessible to both drawscreen.c and term.c. I don't know where best to put it... Perhaps someplace higher up where it can be passed down as a parameter. Maybe someone more experienced can weigh in?

We already have the cursor_is_off flag in term.c.  We could add a
"cursor_is_sleeping" flag there, with functions to set/reset it (making
sure reset is always used after set), and a function to get the current
value.  That seems the cleanest way.  Then when the cursor is displayed
anywhere, the flag can be checked by calling that function.  In
cursor_on_force() the flag can be used directly.
--
Anyone who is capable of getting themselves made President should on no
account be allowed to do the job.
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

We already have the cursor_is_off flag in term.c. We could add a "cursor_is_sleeping" flag there, with functions to set/reset it (making sure reset is always used after set), and a function to get the current value. That seems the cleanest way. Then when the cursor is displayed anywhere, the flag can be checked by calling that function. In cursor_on_force() the flag can be used directly.

Great! cursor_off() is already called by update_screen() in drawscreen.c, so I agree putting the flag in term.c with set/get functions is the clean choice. I'll give this a try within a few days.

We already have the cursor_is_off flag in term.c. We could add a "cursor_is_sleeping" flag there, with functions to set/reset it (making sure reset is always used after set), and a function to get the current value. That seems the cleanest way. Then when the cursor is displayed anywhere, the flag can be checked by calling that function. In cursor_on_force() the flag can be used directly.

Great! cursor_off() is already called by update_screen() in drawscreen.c, so I agree putting the flag in term.c with set/get functions is the clean choice. I'll give this a try within a few days.


Add option to disable port scans

Closes #75

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm not sure if the @CLAassistant page is configurable, but I've found hard to read the hex color #2c3e50 over white color with that thin typography, maybe I need to go to the ophthalmologist again.

This looks great, thank you! Would you mind updating the manpage (twa.1) as well?

I'm not sure if the @CLAassistant page is configurable, but I've found hard to read the hex color #2c3e50 over white color with that thin typography, maybe I need to go to the ophthalmologist again.

Yeah, I've had the same problem. I don't believe it is configurable, unfortunately :disappointed:

This looks great, thank you! Would you mind updating the manpage (twa.1) as well?

Sure, I added an additional commit with the man page updated. :+1:

Fantastic, thanks. I made one small additional manpage change, will merge when CI goes through.

Fantastic, thanks. I made one small additional manpage change, will merge when CI goes through.

Oh, yes I forgot a to update that at the man page. Cool :+1:
Let's see on which other issue I can help

Let's see on which other issue I can help

I appreciate it!


storage/swift: error format bug

Swift is emitting error messages that look like this:
swift: copying file for URL "swift://biostream/biostream/mc3/mc3.Variant.json": %!s(<nil>)

It is due to a typo here:  https://github.com/ohsu-comp-bio/funnel/blob/master/storage/swift.go#L284. The %s formatting directive doesn't work for the error type if the error is nil.

hrm, interesting, I guess %v is better? More importantly, wonder how we got this with a nil error.

ah I see it:
https://github.com/ohsu-comp-bio/funnel/blob/master/storage/swift.go#L228
We have closeErr where it should be copyErr.


Feature/traffic junction

What?
Added Traffic Junction to Mava.
Why?
To enable testing of MARL systems requiring communication. Env is unsolvable without communication.
How?

Added Traffic Junction (TJ) env from IC3Net code, defined in CommNet paper, and cleaned up the code.
Created a PZ wrapper for TJ
Made a function to create TJ envs
Added an MAPPO example on TJ

Extra
Closes #637
Closes #638

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We are closing this PR as we are focussing on the JAX release. We will re-open it when needed again in the future.


Add new driftfile, hwtimestamps, rtcsync, and dumpdir parameters

The params added with this PR are:
driftfile, hwtimestamps, rtcsync, and dumpdir. Each with it's separate commit.

Rebased to master/HEAD because the need to add defaultvalue for $dumpdir for Gentoo in params.pp

Would you be able to add any extra tests to cover the new options?  In particular, it'd be good to test that hwtimestamps works correctly with both Hash and Array values.

Would you be able to add any extra tests to cover the new options? In particular, it'd be good to test that hwtimestamps works correctly with both Hash and Array values.

Yes, I can do that.

I have rebased to master, fixed the typos, and added tests in the commits for each param


arrpc: 3.3.0 -> 3.4.0

Description of changes
This PR updates the rev, hash and npmDepsHash to update arrpc to 3.4.0 from 3.3.0

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@NixOS/nixpkgs-merge-bot merge

oh my bad

Result of nixpkgs-review pr 308269 run on aarch64-linux 1

1 package built:

arrpc


Don't manage Rakefile with pdk

This commit tells the PDK to not manage the Rakefile in this module. The previous commit overwrote our changelog related config, which is also added back in this commit.

Testing the auto release workflow using this branch here, don't merge until it works there.


Fix event call

Q
A

Is bugfix?
yes

http://yiiframework.ru/forum/viewtopic.php?f=27&t=44518

Merged. Thanks!


Bump digitalmarketplace frameworks to 5.1.6

Brings in changes to the link text for links to brief fields yet to be completed.
See https://github.com/alphagov/digitalmarketplace-frameworks/pull/344 for details.

👍


Add a script for running the sms service incrementally

(Merging so I can update the execution scripts)