Looks like worker dies and no more jobs being picked up

The only error we have is this one:
Job failed due unexpected exit. %Honeydew.Job{by: :nonode@nohost, completed_at: nil, delay_secs: 0, enqueued_at:<PHONE_NUMBER>191, failure_private: nil, from: nil, job_monitor: #PID<0.9131.53>, private: -576460752298270142, queue: :new_block, result: {:error, %Honeydew.Crash{reason: {:timeout, {Task, :await, [%Task{owner: #PID<0.9133.53>, pid: #PID<0.4273.53>, ref: #Reference<0.3764113133.549453826.23758>}, 50000]}}, stacktrace: [], type: :exit}}, started_at: nil, task: {:new, ["000000000000000000063f666d006acc3c83013f38be1662986639a7bfc19d79"]}}",
** (exit) exited in: Task.await(%Task{owner: #PID<0.9133.53>, pid: #PID<0.4273.53>, ref: #Reference<0.3764113133.549453826.23758>}, 50000)
    ** (EXIT) time out

After this error no more jobs is being processed.
We run honeydew with:
:ok = Honeydew.start_queue(:new, failure_mode: {Honeydew.FailureMode.Retry, times: 10})
:ok = Honeydew.start_workers(:new, App.BlockWorker, num: 1)

Hm, that's unfortunately not a lot to go on.
Do you have a minimal reproduction you can share, so I can help you debug the issue?

Unfortunately no, also it happens randomly - can work for days, but then we get this error and that's all. Even putting a new job into the queue doesn't trigger it. The job itself is very heavy and intense and can take from 30s to minutes to process.  However it worked for several months flawlessly and just recently started to freeze.
Do you have any idea why the worker supervisor doesn't start a new worker?

I'm not able to reproduce it, I've got a worker that spawns a long task and then times out, I'm seeing the worker start back up again every time.
There's even a test in the suite that's intended to simulate pandemonium, it's functioning correctly, so there must be something quite strange going on.
Your queue is named :new, but the Job struct you gave has it set to :new_block, was that intentional?
Next time you see it happen, can you send me your Honeydew.status/1?

Yeah, its :new_block, changed it when replaced App name. It failed again, here is the status:
%{
  queue: %{
    count: 63,
    in_progress: 1,
    mnesia: %{
      "honeydew_:new_block": [
        access_mode: :read_write,
        active_replicas: [:nonode@nohost],
        all_nodes: [:nonode@nohost],
        arity: 3,
        attributes: [:key, :job],
        checkpoints: [],
        commit_work: [],
        cookie: {{1580667096093232350, -576460752303423483, 1}, :nonode@nohost},
        cstruct: {:cstruct, :"honeydew_:new_block", :ordered_set,
         [:nonode@nohost], [], [], [], 0, :read_write, false, [], [], false,
         :wrapped_job, [:key, :job], [], [], [],
         {{1580667096093232350, -576460752303423483, 1}, :nonode@nohost},
         {{2, 0}, []}},
        disc_copies: [],
        disc_only_copies: [],
        external_copies: [],
        frag_properties: [],
        index: [],
        index_info: {:index, :ordered_set, []},
        load_by_force: false,
        load_node: :nonode@nohost,
        load_order: 0,
        load_reason: {:dumper, :create_table},
        local_content: false,
        majority: false,
        master_nodes: [],
        memory: 3421,
        ram_copies: [:nonode@nohost],
        record_name: :wrapped_job,
        record_validation: {:wrapped_job, 3, :ordered_set},
        size: 62,
        snmp: [],
        storage_properties: [],
        storage_type: :ram_copies,
        subscribers: [],
        type: :ordered_set,
        user_properties: [],
        version: {{2, 0}, []},
        where_to_commit: [nonode@nohost: :ram_copies],
        where_to_read: :nonode@nohost,
        where_to_wlock: {[:nonode@nohost], false},
        where_to_write: [:nonode@nohost],
        wild_pattern: {:wrapped_job, :_, :_}
      ],
      "honeydew_:new_block_in_progress": [
        access_mode: :read_write,
        active_replicas: [:nonode@nohost],
        all_nodes: [:nonode@nohost],
        arity: 3,
        attributes: [:key, :job],
        checkpoints: [],
        commit_work: [],
        cookie: {{1580667096097079709, -576460752303423387, 1}, :nonode@nohost},
        cstruct: {:cstruct, :"honeydew_:new_block_in_progress", :set,
         [:nonode@nohost], [], [], [], 0, :read_write, false, [], [], false,
         :wrapped_job, [:key, :job], [], [], [],
         {{1580667096097079709, -576460752303423387, 1}, :nonode@nohost},
         {{2, 0}, []}},
        disc_copies: [],
        disc_only_copies: [],
        external_copies: [],
        frag_properties: [],
        index: [],
        index_info: {:index, :set, []},
        load_by_force: false,
        load_node: :nonode@nohost,
        load_order: 0,
        load_reason: {:dumper, :create_table},
        local_content: false,
        majority: false,
        master_nodes: [],
        memory: 353,
        ram_copies: [:nonode@nohost],
        record_name: :wrapped_job,
        record_validation: {:wrapped_job, 3, :set},
        size: 1,
        snmp: [],
        storage_properties: [],
        storage_type: :ram_copies,
        subscribers: [],
        type: :set,
        user_properties: [],
        version: {{2, 0}, []},
        where_to_commit: [nonode@nohost: :ram_copies],
        where_to_read: :nonode@nohost,
        where_to_wlock: {[:nonode@nohost], false},
        where_to_write: [:nonode@nohost],
        wild_pattern: {:wrapped_job, :_, :_}
      ]
    },
    suspended: false
  },
  workers: %{
    #PID<0.26129.22> => {%Honeydew.Job{
       by: :nonode@nohost,
       completed_at: nil,
       delay_secs: 0,
       enqueued_at:<PHONE_NUMBER>589,
       failure_private: 1,
       from: nil,
       job_monitor: #PID<0.26130.22>,
       private: -576460752302077374,
       queue: :new_block,
       result: nil,
       started_at:<PHONE_NUMBER>872,
       task: {:new_block,
        ["00000000000000000010147f3f358a7b0c3a187d1f0270a741b49e3124892aa1"]}
     }, :running}
  }
}

Error (sorry for the mess, its  for elastic):
{"@timestamp":"2020-02-02T23:47:41.871+01:00","file":"lib/honeydew/logger.ex","function":"job_failed/2","level":"warn","line":64,"message":"Job failed due unexpected exit. %Honeydew.Job{by: :nonode@nohost, completed_at: nil, delay_secs: 0, enqueued_at:<PHONE_NUMBER>589, failure_private: nil, from: nil, job_monitor: #PID<0.20763.22>, private: -576460752302077438, queue: :new_block, result: {:error, %Honeydew.Crash{reason: {:timeout, {Task, :await, [%Task{owner: #PID<0.20764.22>, pid: #PID<0.22225.22>, ref: #Reference<0.439751935.234356738.105265>}, 50000]}}, stacktrace: [], type: :exit}}, started_at: nil, task: {:new_block, [\"00000000000000000010147f3f358a7b0c3a187d1f0270a741b49e3124892aa1\"]}}\",\n** (exit) exited in: Task.await(%Task{owner: #PID<0.20764.22>, pid: #PID<0.22225.22>, ref: #Reference<0.439751935.234356738.105265>}, 50000)\n    ** (EXIT) time out\n","module":"Elixir.Honeydew.Logger"}

Looks like worker is alive, but it couldn't handle the crash and became a zombie.

It looks to me that the worker did indeed crash and restart, as intended, and a new worker is now retrying the job. The task's owner pid and the currently running worker's pid are different, so it did restart.
Just judging from this output, it does look like your job is legitimately running.
From here, I'd suggest adding some more logging to your job, especially around where you do your Task.await/1. Is there any chance you're looping and awaiting multiple times, or waiting for :infinity?
Can you share your actual job code with me?

Happened again, you are right it restarts on the next block in queue after the one that failed and stops on it.
%{
  queue: %{
    count: 30,
    in_progress: 1,
    mnesia: %{
      "honeydew_:new_block": [
        access_mode: :read_write,
        active_replicas: [:nonode@nohost],
        all_nodes: [:nonode@nohost],
        arity: 3,
        attributes: [:key, :job],
        checkpoints: [],
        commit_work: [],
        cookie: {{1580726431401602349, -576460752303423390, 1}, :nonode@nohost},
        cstruct: {:cstruct, :"honeydew_:new_block", :ordered_set,
         [:nonode@nohost], [], [], [], 0, :read_write, false, [], [], false,
         :wrapped_job, [:key, :job], [], [], [],
         {{1580726431401602349, -576460752303423390, 1}, :nonode@nohost},
         {{2, 0}, []}},
        disc_copies: [],
        disc_only_copies: [],
        external_copies: [],
        frag_properties: [],
        index: [],
        index_info: {:index, :ordered_set, []},
        load_by_force: false,
        load_node: :nonode@nohost,
        load_order: 0,
        load_reason: {:dumper, :create_table},
        local_content: false,
        majority: false,
        master_nodes: [],
        memory: 1672,
        ram_copies: [:nonode@nohost],
        record_name: :wrapped_job,
        record_validation: {:wrapped_job, 3, :ordered_set},
        size: 29,
        snmp: [],
        storage_properties: [],
        storage_type: :ram_copies,
        subscribers: [],
        type: :ordered_set,
        user_properties: [],
        version: {{2, 0}, []},
        where_to_commit: [nonode@nohost: :ram_copies],
        where_to_read: :nonode@nohost,
        where_to_wlock: {[:nonode@nohost], false},
        where_to_write: [:nonode@nohost],
        wild_pattern: {:wrapped_job, :_, :_}
      ],
      "honeydew_:new_block_in_progress": [
        access_mode: :read_write,
        active_replicas: [:nonode@nohost],
        all_nodes: [:nonode@nohost],
        arity: 3,
        attributes: [:key, :job],
        checkpoints: [],
        commit_work: [],
        cookie: {{1580726431405308957, -576460752303423294, 1}, :nonode@nohost},
        cstruct: {:cstruct, :"honeydew_:new_block_in_progress", :set,
         [:nonode@nohost], [], [], [], 0, :read_write, false, [], [], false,
         :wrapped_job, [:key, :job], [], [], [],
         {{1580726431405308957, -576460752303423294, 1}, :nonode@nohost},
         {{2, 0}, []}},
        disc_copies: [],
        disc_only_copies: [],
        external_copies: [],
        frag_properties: [],
        index: [],
        index_info: {:index, :set, []},
        load_by_force: false,
        load_node: :nonode@nohost,
        load_order: 0,
        load_reason: {:dumper, :create_table},
        local_content: false,
        majority: false,
        master_nodes: [],
        memory: 353,
        ram_copies: [:nonode@nohost],
        record_name: :wrapped_job,
        record_validation: {:wrapped_job, 3, :set},
        size: 1,
        snmp: [],
        storage_properties: [],
        storage_type: :ram_copies,
        subscribers: [],
        type: :set,
        user_properties: [],
        version: {{2, 0}, []},
        where_to_commit: [nonode@nohost: :ram_copies],
        where_to_read: :nonode@nohost,
        where_to_wlock: {[:nonode@nohost], false},
        where_to_write: [:nonode@nohost],
        wild_pattern: {:wrapped_job, :_, :_}
      ]
    },
    suspended: false
  },
  workers: %{
    #PID<0.23441.22> => {%Honeydew.Job{
       by: :nonode@nohost,
       completed_at: nil,
       delay_secs: 0,
       enqueued_at:<PHONE_NUMBER>163,
       failure_private: nil,
       from: nil,
       job_monitor: #PID<0.23442.22>,
       private: -576460752297858591,
       queue: :new_block,
       result: nil,
       started_at:<PHONE_NUMBER>471,
       task: {:new_block,
        ["00000000000000000008d820bfbb7b50c02034bedd6756bf7079cabb08e5658c"]}
     }, :running}
  }
}

As you can see it has 30 elements in queue, being stuck on that one. Here is the :sys.get_state(pid) of  #PID<0.23441.22>
%Honeydew.Worker.State{
  has_init_fcn: false,
  init_args: [],
  init_retry_secs: 5,
  job: %Honeydew.Job{
    by: :nonode@nohost,
    completed_at: nil,
    delay_secs: 0,
    enqueued_at:<PHONE_NUMBER>163,
    failure_private: nil,
    from: nil,
    job_monitor: #PID<0.23442.22>,
    private: -576460752297858591,
    queue: :new_block,
    result: nil,
    started_at: nil,
    task: {:new_block,
     ["00000000000000000008d820bfbb7b50c02034bedd6756bf7079cabb08e5658c"]}
  },
  job_runner: #PID<0.23443.22>,
  module: App.BlockWorker,
  private: :no_state,
  queue: :new_block,
  queue_pid: #PID<0.280.0>,
  ready: true,
  start_opts: [
    #PID<0.307.0>,
    :new_block,
    %{
      init_retry_secs: 5,
      ma: {App.BlockWorker, []},
      nodes: [],
      num: 1,
      shutdown: 10000
    },
    #PID<0.280.0>
  ]
}

I've tried to get state of the job_runner: #PID<0.23443.22> but failed
** (exit) exited in: :sys.get_state(#PID<0.23443.22>)
    ** (EXIT) time out
    (stdlib) sys.erl:335: :sys.send_system_msg/2
    (stdlib) sys.erl:136: :sys.get_state/1

Process.info gives info that its actually a Redis process:
[
  current_function: {Redix.Connection, :pipeline, 3},
  initial_call: {:proc_lib, :init_p, 5},
  status: :waiting,
  message_queue_len: 4,
  links: [#PID<0.23441.22>],
  dictionary: [
    "$ancestors": [#PID<0.23441.22>, #PID<0.307.0>, #PID<0.306.0>,
     :"Elixir.Honeydew.WorkerGroupSupervisor.new_block", #PID<0.303.0>,
     Honeydew.Workers, Honeydew.Supervisor, #PID<0.238.0>],
    job_monitor: #PID<0.23442.22>,
    "$initial_call": {Honeydew.JobRunner, :init, 1}
  ],
  trap_exit: false,
  error_handler: :error_handler,
  priority: :normal,
  group_leader: #PID<0.237.0>,
  total_heap_size: 2585,
  heap_size: 987,
  stack_size: 42,
  reductions: 2445,
  garbage_collection: [
    max_heap_size: %{error_logger: true, kill: true, size: 0},
    min_bin_vheap_size: 46422,
    min_heap_size: 233,
    fullsweep_after: 65535,
    minor_gcs: 5
  ],
  suspending: []
]

Unfortunately I can't provide the code. The task is really huge, we even call rust code with NIF to process some data in the middle.
The only place where we use Tasks is to fetch transactions through json-rpc:
  def fetch_transactions(raw_transactions) do
    raw_transactions
    |> Enum.map(fn trx_id ->
      Task.async(fn ->
        {:ok, data} = Api.gettransaction(trx_id)
        {trx_id, data}
      end)
    end)
    |> Enum.map(&Task.await(&1, 50_000))
    |> List.flatten()
  end

Yeah, unfortunately, even though the job runner process is a GenServer, it's pretty unlikely that you'll get it to respond to :sys.get_state/1 since it's performing your job and the job doesn't yield control back to the GenServer loop.
So process #PID<0.23443.22>, as you mentioned, is the job runner that's stuck, it's not actually a process that belongs to redis' supervision tree, but it is running redix's code (as you mentioned, too). It sounds like redis' command!/2 function calls pipeline/3, which is probably blocking and eventually causing the Task.await/1 timeouts.
I think Redis is going to be the best place for you to investigate. Just off the cuff, I'd check out the following:

Check the redis logs for anything obvious (slow commands, warnings, etc)
Does the local :redix connection have a command pipeline cap, and is it blocking because it's waiting in line? (related: if you can store a handle to a unique redis connection in honeydew's job state instead of relying on a connection pool, there'll never be a mismatch between available connections and number of workers)
Does the remote redis server have a cap on the number of things it'll process simultaneously? It could be that your local client is blocking awaiting the scheduling of its request.
Do you have enough ram on your redis server, and is redis allowed to use that ram? It could be that redis is paging the data set out to disk because it's low on ram, and has to page it back in to satisfy your command (and hence blocks).
Next time this happens, maybe try opening a remote iex shell (as you've been doing) and running Redix.command!(:redix, ["PING"])? I don't know how much that'll tell you, but if that doesn't work at all, perhaps the redis connection has broken.

hey @nateless, i'd love to hear how your debugging is going if you're able. :)

Hey @koudelka, after we removed Redis it works flawlessly, unfortunately I didn't have time to investigate why it freezed with Redis.

all good dude, thanks for the update, i'm glad it's working.
drop me a line if you have any other issues. :)


Inconsistent state of Routes variable after present/push when VC is presented on top (from UIKit)

I have an SDK that pushes (through UIKit) a fullscreen cover on app start, and I have my own cover, also on app start (ask for notifications).
If SDK presents its cover and then I present my - only SDK's cover is presented.
And when SDK's cover is dismissed, I see my root view, but I get an assertion failure: it tries to push view on top of "invisible" sheet that is not embedded into navigation view.
If I embed it into navigation view, then assert's not firing, but push doesn't work either.
Can I somehow forcely update the hierarchy after SDK's modal dismissal?
Or, maybe, synchronize routes array with actual state (if view wasn't presented, then it should disappear from (or not even be added to) routes array)
Thank you for your help!

Thanks for raising this issue. Out of interest, which SDK is it? I don't see a good way to resolve the issue in this library, but I can see ways to work around the problem, such as:

Using a different modality for 'presenting' your own screen on app start (not a sheet/cover) - e.g. conditionally showing the notifications screen or the main view from the app root, and using a .transition() modifier to animate the transition between them. Or using push navigation rather than cover presentation.
Delaying initialising the SDK until after your own fullscreen cover is dismissed.
Delaying your own fullscreen cover until after the SDK's has been dismissed (though I guess you might not know when that happens).

Thank you for your answer and your suggestions!
The SDK is DivPro: https://github.com/divkit/divkitpro/
I think I have another one option, from the SDK side:
I can write and inject own “presenter” (the sdk allows it) and wrap their UIViewController in SwiftUI view, and present it normally through FlowStacks.
I’ll try it out.

Ah great, that would be ideal.


SSL Certificate error: ERR_CERT_AUTHORITY_INVALID on certain sites

Running this script in a Debian environment returns:
(node:7395) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: SSL Certificate error: ERR_CERT_AUTHORITY_INVALID
const puppeteer = require('puppeteer');

args = [];
args.push('--no-sandbox');
args.push('--disable-setuid-sandbox');

const takeSnapshot = async (page) => {
  await page.screenshot({ path: '/tmp/test.png' });
};

try {
  (async () => {
    browser = await puppeteer.launch({
      headless: true,
      args,
    });

    page = await browser.newPage();

    await page.goto('about:blank', { waitUntil: 'load' });

    await page.goto('https://www.ralphlauren.com/women-clothing-polo-shirts/skinny-fit-big-pony-polo-shirt/412481.html?cgid=women-clothing-polo-shirts&dwvar412481_colorname=Deep+Royal&webcat=women/tops/Polo+Shirts', { waitUntil: 'load' });

    await takeSnapshot(page);
  })();
} catch (err) {
  console.log(err);
}

There are other sites as well. Is it because of system certificates?
Thank you!

Can't reproduce this on current tip-of-tree: 0.13.0-alpha. Could you please check if it works for you on tip-of-tree?

I'm afraid it's still happening with tip-of-free.

I'm running into same issue on another domain. The test script above fails for me as well.

@sjungwirth can you share your script/domain?

It might be related to Comodo certificates.

@aslushnikov I verified using the same script in the original post https://github.com/GoogleChrome/puppeteer/issues/1137#issue-267783452 against www.frys.com

Also confirm the same problem for Let's Encrypt certificate at itms.pro

Seeing errors for this site.  http://www.wmcactionnews5.com/ .
Also used headless:false.
(node:71693) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: SSL Certificate error: ERR_CERT_COMMON_NAME_INVALID
(node:71693) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
^C(node:71693) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: Page crashed!

I stopped getting errors in the latest Chromium revision. Can anyone else on this issue please confirm? If all is well I'll close this issue.

I have the same problem.
09:24:07.722 DEBUG selenium-nodejs.HomePage: navigate
[1120/092408.090:VERBOSE1:network_delegate.cc(31)] NetworkDelegate::NotifyBeforeURLRequest: https://localhost/home
[1120/092408.403:VERBOSE1:navigator_impl.cc(242)] Failed Provisional Load: https://localhost/home, error_code: -501, error_description: , showing_repost_interstitial: 0, frame_id: 1
The error page like:

@wenJanus it looks like you're using self-signed certificates on the localhost. Using ignoreHTTPErrors puppeteer option should help to get rid of this message.

Can I ask why this issue was closed? I don't see any solution and can still reproduce the issue using the submitters attached code example. We are seeing the same issue with our websites.
The ignoreHTTPErrors flag does not seem to effect the outcome. Is the behaviour by chance related to this Headless Chrome bug? https://bugs.chromium.org/p/chromium/issues/detail?id=721739

@tk8817 @aslushnikov the option seems to be ignoreHTTPSErrors not ignoreHTTPErrors

@tk8817 We had success with setting Security.setIgnoreCertificateErrors (https://chromedevtools.github.io/devtools-protocol/tot/Security#method-setIgnoreCertificateErrors) on Chrome 65.0.3325.146. More context: https://gitlab.com/DMore/chrome-mink-driver/issues/57

I've got it working with:
browser = await puppeteer.launch({ headless: false, slowMo: 250, ignoreHTTPSErrors: true });

hi @Tech-Nomad I tried your code but this is what i get "HTTP Error 502.5 - ANCM Out-Of-Process Startup Failure" did you experience this also?

@Tech-Nomad Does anyone know why this has to be slowMo set to 250. In the docs it says this is for slowing down puppeteer actions but doesn't look like it should be in production code.
https://developers.google.com/web/tools/puppeteer/debugging

I used self-signed certificates on the localhost,
ignoreHTTPSErrors: true,   > not working in my env
args.push('--ignore-certificate-errors'); > seems good in my env


[VkAlternativeBridge] New bridge

Hello. This is an alternative bridge for the vk.com site. I know that a bridge for this site already exists in rss-bridge, but I was dissatisfied with it's code structure, therefore did not want to contribute to it and preferred to write the bridge from scratch. Unlike VkBridge, this bridge correctly embed all types of videos (vk's native videos and videos from Youtube), gifs (inserts the gif itself, not a static preview), images inserted as files (inserts preview images into the feed and adds a direct link to the full-size image ), maps (inserts the map itself and a link to the location, not just the name of the location), posters, files (inserts a direct link to the file, not to the web page with the file), the bridge also allows you to insert comments from the post into feed and subtly set up filtering of comments, plus it is possible to remove from the feed not just posts with reposts, but only posts in which there is nothing but a repost. In addition, the code is structured in a completely different way and separates the parsing of the post from its presentation, allowing to change how to format feed items, for example, this way developer can add css to feed items without touching the parsing at all (as well as the process of getting post data in general). Also, in my opinion, this bridge formats content much more beautifully. The bridge still has some roughness (for example cold start is slow, because of pages downloading), but it is already quite working and suitable for everyday use.

Hi, @d7sd6u !
Nice job about rewriting bridge for vk.com.

I was dissatisfied with it's code structure, therefore did not want to contribute to it and preferred to write the bridge from scratch.

I think you did the right decision about rewriting bridge from scratch. I consider to make it as a replacement, but in this case you would need to add backward compability for old urls to be valid.
Here are some moments:

Feed for https://vk.com/a.n.shilov does not work:

https://feed.eugenemolotov.ru/pr1888/?action=display&bridge=VkAlternative&sourceId=a.n.shilov&removeReposts=none&topCommentThreshold=0&branchCommentThreshold=0&descendingCommentThreshold=0&descendingCommentThresholdOffset=0&format=Html
The original vk bridge results: https://feed.eugenemolotov.ru/?action=display&bridge=Vk&u=a.n.shilov&format=Html

Also profile name depends on instance country. For example my instance is hosted in Netherlands, so profile is named Alexander Sjilov, while in English it must be Alexander Shilov. Original VkBridge sends some specific headers, to indicate that it requests page in English. Anyway, Russian is also fine, but I remember that it lead to problem, where timestamps were not parsed in original VkBridge.

Hello, @em92 , thanks for the review. I've been busy this week and will only be able to code again this weekend. On Saturday, Sunday I'll fix the pull request.

I consider to make it as a replacement, but in this case you would need to add backward compability for old urls to be valid.

I'll try to do backward compatibility, but I need to figure out how to do it for repost filtering (VkBridge uses checkbox, and this bridge uses list).

Feed for https://vk.com/a.n.shilov does not work:

Most likely this is due to nested reposts (I myself first met them), but you will need to see if this is so. If so, it shouldn't be difficult to fix it.

Original VkBridge sends some specific headers, to indicate that it requests page in English.

This bridge also sends special headers for this, which, as far as I remember, works in this bridge and VK sends the English version of the page.

Good evening, @em92 , I fixed everything, including backward compatibility for old urls.

@em92 , why aren't you merging pull request? In the meantime, I have corrected the feed name extraction (I finally understood what you were talking about in the first comment) and added support for post's origin extracting and formatting.

Optimized page downloading, now almost all necessary pages are downloaded in advance and in parallel, using curl_multi. Previously, without caching, feed was created for about a minute or more, but now from three to nine seconds, depending on the number and content of reposts and comments,10-20 times faster! Bridge is now fully usable even by the most "impatient" feed readers. In my opinion, such functionality (downloading many links in parallel) should be in rss-bridge libraries, but for this error handling and caching should be added to my function (I will add this later).

Optimized page downloading.

However, be careful, in this mode standard 128 megabytes of RAM are not enough for the bridge and therefore I recommend increasing the limit to at least 256 megabytes on your instance.

I am rewriting the bridge so that it uses my new libraries, in which I moved all the actions related to parsing and formatting posts, so I close this PR.

I am rewriting the bridge so that it uses my new libraries, in which I moved all the actions related to parsing and formatting posts, so I close this PR.


Git on WSL not syncing correctly with repos cloned with Git on Windows

Environment
Windows build number: Microsoft Windows [Version 10.0.19041.329]
Your Distribution version: Ubuntu 20.04
Whether the issue is on WSL 2 and/or WSL 1: Linux version 4.4.0-19041-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #1-Microsoft Fri Dec 06 14:06:00 PST 2019

Steps to reproduce

I have Git installed on my Windows 10 machine as well as in the Ubuntu 20.04 WSL installation. When setting up, I cloned all my repos using PowerShell Core to my PC using Git Windows. And, as expected, if I made any changes then Git on Windows tracks these and I can view the correct status in PS Core. But I faced something weird when accessing the same repositories using the Ubuntu 20.04 version of Git. When I navigated to the repository using Ubuntu Bash, I saw that everything in that repository was not staged for commit. I had just cloned them all and there were no edits at all. The Bash shell showed that all the files of that repo was not staged in red color. I am attaching a couple of screenshots to show my issue.
Now, let's create a new repo and demonstrate my problem.

I create two empty repositories on my Desktop called "test-app" and both Bash and PS Core show that the master branch is clean. Now I will add some files using PS Core and then staging and committing them using Git on Windows.

After committing, I see that the master branch is clean again and all changes were saved. Now look at what happens when I view the repository using Bash.

It shows that the "info.txt" file was modified and needs to be staged, but I did that already using PS Core so why am I still seeing that my master branch is not clean? To further explain, my first commit is surprisingly available in the git log command in the Bash shell.

So the Git installed in WSL does know that the commit was made, but still shows that changes are not staged. What could be the reason that this is occurring? Interestingly, if I made edits and commit them using Bash, git on Windows actually knows about this commit and PS Core shows that my branch is clean. So, this is a one-way issue. Please also know that my Git in WSL is configured with the same Git account details and GitHub credentials as the Windows variant.

Expected behavior

Git in WSL should know that the edited files were staged and commit and the master is clean although I made changes using Git on Windows. It should be synced with the correct state of the repository whether the changes were committed using WSL Git or Git from PS Core on Windows.
Actual behavior

It shows already committed changes as unstaged and in red color although the commit is readily visible in the git log.

Because you didn't match core.autocrlf on both sides.
https://docs.microsoft.com/en-us/windows/wsl/tutorials/wsl-git#git-line-endings

https://github.com/microsoft/WSL/issues?q=is%3Aissue+core.autocrlf

@0xbadfca11 Okay thank you so much for the suggestion. I will make sure to use same line endings on both sides. Thanks. 😄


Update install.yml

Fix node_exporter download url
Signed-off-by: Alexey Savinov<EMAIL_ADDRESS>

I think this was fixed in #17.

I think this was fixed in #17.


Multiple dependency clients using the same trigger.

It seems there is no way to init a trigger that would have been already created and used by another client. The current constructors only allows to create a new trigger?
That makes alot of mess in the database.

No. One SqlTableDependency instance one trigger.


Time question will throw error in Edge

Description
In Edge browser when we add an time question ( or some question use the timepicker). the survey will throw an error.
Screenshots

Test xlsx time.xlsx

This issue maybe because of the append function in timepicker-extended.
https://github.com/enketo/enketo-core/blob/446077bc2a81b7d392b1b0bc3626817f1dec4579/src/widget/time/timepicker-extended.js#L26
IE and Edge doesn't support the append function. It work well in IE was because we have an polyfill for it.

Ah, thanks!

@huoyixin I'm updating my Edge (which will take some time), but it looks like you are referring to Edge Mobile perhaps (though I tested Edge Mobile on Android and it doesn't have the issue either). Is anybody using Edge Mobile? It's not a browser we support (or had ever heard of actually ;)).

Sorry, that was my mistake with the MDN table.
But this append function can not work in my edge 41.16299.1004.0 browser, I will check again.
Thanks for you quick response.

No worries. Thanks. Since 41.x is quite old, and the error message mostly prevents users from using it, I think it's best to leave this as is.


How do u guys show cat-log in Atom IDE ?  #React-native

Hi! Thanks for trying out NativeBase!
Take a look at these before heading towards creating an issue

Check latest documentation: https://docs.nativebase.io/
Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/

Also DO fill out the below form to give us a better idea about your environment and help us debug it quicker. Issues without the required details will mostly be closed.
node, npm, react-native, react and native-base version
Expected behaviour
Actual behaviour
Steps to reproduce should include code snippet and screenshot
Is the bug present in both iOS and Android or in any one of them?
Any other additional info which would help us debug the issue quicker.

Please follow instructions mentioned in issue template
Failing which this issue will be closed


[Docs] Update two Wikipedia links

Can you update this on the master branch as well/instead?

Yeah, my mistake...

Sorry, now the branch is clean.

My bad. I had to get rid of some cherry-picked commits from 1.8 and rebase.
We're good to go now.

@rmlarsen We're good to go now.

Failure unrelated: tensorflow/contrib/data/python/kernel_tests/batch_dataset_op_test


Issue with /docs/tutorials/kubernetes-basics/cluster-interactive/

This is a...

[ ] Feature Request
[x ] Bug Report

Problem:
On this page http://kubernetes.io/docs/tutorials/kubernetes-basics/cluster-interactive/
Clicking on Start Scenario does not start MiniKube in the browser.  Instead it does to this Intel page with just articles http://www.intel.com/content/www/us/en/cloud-for-all/cloud-for-all.html?linkId=18217494
Proposed Solution:
Page to Update:
http://kubernetes.io/...

Sorry about that. Duplicate of #2050

Closing this because it is a duplicate. Please follow this issue in #2050


Adds support for using RNP in Eigen without Pod changes

#trivial
fixes #2497

Gonna call this as not gonna do it. Considering how often the prod version of RN might not compile right compared to the dev version, I don't want to move that kind of fail into deployment.


Added capture video functionality

I can't capture any video (Camera app crashes), but in theory it must works

@kaadzr
In case you are not sure about it. You can go on pushing new commits to the source branch which is kaadzr:master. And also don't forget to rebase against zhihu:master as I have merged some other PRs.

Any reason you closed this PR? Really awesome feature.

@kaadzr Sorry, I can't merge this PR right now due to the following two reasons:

CI failed because of code style
The commit history is somewhat in a mess

any updates on this issue plz as i need it in my project. thanks for your great efforts.

@gejiaheng is video capture feature is available?


⚠ ClamAV has degraded performance

In 863e19a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in cd95810.


Downloading the file problem

Hi,
I have problem downloading the file into my local jupyter notebooks by using pyspark. Can you please helpme.
Thanks,

What is the command to download the file from this link: "https://github.com/IBM/coursera/raw/master/hmp.parquet"

I have tried using the following code"
df = spark.read.load("https://github.com/IBM/coursera/raw/master/hmp.parquet")

spark doesn't support direct https downloads, please download the file manually or use the
!wget
or
!curl
command


Feature/health react fix

fix for https://github.com/jhipster/jhipster-quarkus/issues/100

Changes look good. I think that a test needs to be updated though?

Good catch, I wonder how I could let it like this...


Adding the model and system tournament blueprint

Solves #93. I just created the model and system blueprint to keep working on it. Any feedback is more then welcome. I still need to figure it out how to do the remaining functions. (register_player, start_tournament and complete_torunament)
And btw, how can I check that the code is working fine, when I run sozo build nothing happens. See this picture:

Summary by CodeRabbit

New Features

Introduced a new tournament management system with functionalities to create and retrieve tournaments.
Added tournament status tracking with states: Pending, Ongoing, and Completed.

Documentation

Added new modules related to tournament functionality, including a dedicated test module for tournament features.

Hi @Gerson2102, if you execute sozo build and you do not receive errors it's ok, but remember to import the new files/code in the lib.cairo file (I think you need to do it). Also if you want to validate in a quickly way that your functions are working just write some unit tests for yourself to verify that (do not upload that in the PR), because the idea is to create a complete set of unit tests in the other issue.

I'm getting this error while trying to test my code:
sozo test -f test_create_tournament
testing test(bytebeasts_unittest) bytebeasts v0.1.0 (/root/ByteBeastsBackend/Scarb.toml)
running 1 test
test bytebeasts::tests::test_tournament::tests::test_create_tournament ... fail (gas usage est.: 10994620)
failures:
   bytebeasts::tests::test_tournament::tests::test_create_tournament - Panicked with ("Model `Tournament`: deserialization failed. Ensure the length of the keys tuple is matching the number of #[key] fields in the model struct.", 0x454e545259504f494e545f4641494c4544 ('ENTRYPOINT_FAILED')).

error: test result: FAILED. 0 passed; 1 failed; 0 ignored

I dont know why is that happening, the Tournament model just has one #[key] argument. It should works.

@Gerson2102 can you show me your tests?

@danielcdz this is the test:
#[test]
    fn test_create_tournament() {
        let (_, tournament_system) = setup_world();
        let mut players = ArrayTrait::new();

        let player_ash = Player {
            player_id: 1,
            player_name: 'Ash',
            beast_1: 1, // Beast 1 assigned
            beast_2: 0, // No beast assigned
            beast_3: 0, // No beast assigned
            beast_4: 0, // No beast assigned
            potions: 1
        };
        players.append(player_ash);

        tournament_system
            .create_tournament(1, 'tournament', TournamentStatus::Pending, 1, 2, players, 1);
        let tournament = tournament_system.get_tournament(1);
        assert!(tournament.name == 'tournament', "The tournament name is wrong!");
    }

@Gerson2102 can you add the test file to this PR to have all the context and try to debug the test?

@Gerson2102 can you add the test file to this PR to have all the context and try to debug the test?

This is my dojo version currently: 1.0.0-alpha.5

@Gerson2102 I saw your tests and they seem to be good, I faced a similar issue a couple of weeks ago and I think is related to the Dojo version, for now, is ok to delete those system tests as we will be migrating all these repo to Dojo 1.0.0 soon, but please add some tests to the model, something like this: https://github.com/ByteBuildersLabs/ByteBeastsBackend/blob/d088b3b688e2821f075ac1d3dee56e545172c4b8/src/models/battle.cairo#L38

@Gerson2102 are sozo build and sozo test working?

@danielcdz yes

The CI is failing for a weird reason. Seems like is running out of memory, I remember to have faced that kind of issues locally with other projects. But I'm not sure if it is that.


fix: used admin_flask_client to fix the filing tests.

Solves all the failing test but I am not sure if it is the correct way or not
Questions:

Is it safe to use admin_flask_client in this case
Is there any better way to test the content of webpage

CC: @potiuk

This all looks cool. I did similar things.


fix: #145 Disable particular view

Summary
This PR adds the functionality for disabling a particular view like the feature request in https://github.com/dlvhdr/gh-dash/issues/145
This is my first PR in this project, please correct if there any issue or problems with it
How did you test this change?
Adding a option in config file remove a particular view
Images/Videos
If there is no change to the config file gh-dash work as expected without any change

on updating the config file with disableViews config

the view is updated to the following

@dlvhdr Thanks for the review I'll make the required changes

@rambhosale can you fix the conflicts and I'll merge?

@dlvhdr fixed merge issues

@dlvhdr can you merge this?

I'm getting an error that the branch cannot be rebased. Can you rebase it on top of main and push?
I can do it later as well

Can we ensure that the new configuration option is added to the configuration schema? I'm happy to write the extended documentation for it, but I think it's best if the option itself is added with the implementing PR for the sake of commit history.


Clarified nonce requirements

Clarified usage of nonce when use in a non-interactive protocol.

Addresses issue #15

Discussed on Jan 10th WG call, resolved to merge after 1 day if no further objection or feedback.

I'm not sure the text BBS signatures are nondeterministic is still true depending how the nonces are chosen. It also might be good to refer to e and s specifically in the context of nonce selection (at least I think those are the relevant nonces?). I'm not sure why a signed document would include a ZKP of a signature rather than the signature itself but maybe there's a use for that.

Hm, I also can't imagine how blinded signatures would be used in a non-interactive or deterministic context.

I'm not sure why a signed document would include a ZKP of a signature rather than the signature itself but maybe there's a use for that.

The use case I referred here if you want to sign a statement without identifying yourself, think role-based signature similar to role-based access. A BBS+ cred owner could sign a statement, disclosing some attributes attested by a trusted issuer.

I also can't imagine how blinded signatures would be used in a non-interactive or deterministic context.

One scenario that dates way back to Chaum's credential days was toll booths, where passing cars could present a payment by signing a booth ID + timestamp. Prover just broadcasts the proof to get access to a resource, using a (verifier ID + timestamp + small random value) as the nonce. Verifiers can prevent replays by keeping a local cache of used nonces (deleting as the timestamps get too old).

@andrewwhitehead any concrete proposal that could be suggested here to move this PR along?

Comments from the Jan 24th meeting: yes, the nonce terminology contradicts the deterministic use cases. Perhaps renaming it to something more neutral would help generalize the supported scenarios. In U-Prove, e.g., the nonce was called presentation message, which could be a nonce (for interactive scenarios), a verifierID+timestamp for user-initiated non-interactive scenarios, or static content for digital signature use cases.

Comments from the Jan 24th meeting: yes, the nonce terminology contradicts the deterministic use cases. Perhaps renaming it to something more neutral would help generalize the supported scenarios. In U-Prove, e.g., the nonce was called presentation message, which could be a nonce (for interactive scenarios), a verifierID+timestamp for user-initiated non-interactive scenarios, or static content for digital signature use cases.

I think that's a good description of an application of a nonce, when it's used in a deterministic scenario, but not general enough. Challenge may be used when interaction is needed in a non-deterministic manner. A nonce can then become a presentation message, a challenge, or even a pin to be more specific. This makes me think that nonce is indeed a good way to refer to this input.

@christianpaquin apologies but we have renamed the spec file name so we leverage existing tooling around managing ID drafts, can you please rebase your PR accordingly?

I've updated the PR, merging with latest changes on main, and removing some mentions of potential use cases causing confusion.
The main use case I have in mind for BBS+ signature is to build anonymous credentials, where the holder is not only given certified attributes, but also holds a private key (in one of the never-disclosed attributes, like in U-Prove and Idemix). Since BBS+ can, in its generalization, be used to encode key-less, bearer-only signatures on arbitrary messages, the previous "signing the nonce" text was confusing, so I removed it for now.
This being said, where should we specify such a use for BBS+ signature? Should that be a totally different spec (similar to CL sig vs. Idemix?) or a simpler profile?

This being said, where should we specify such a use for BBS+ signature? Should that be a totally different spec (similar to CL sig vs. Idemix?) or a simpler profile?

Just so I can clarify when you say a more opinionated signature scheme what do you mean exactly, one that features holder cryptographic binding or something else?

how many days with approval before merge for this work item?

Resolved to merge on WG call 7th of Feb, awaiting conflict resolution

Conflict merge resolution is very confused on my system, so closing this and opening new, cleaner PR #55.


Implicit pybind11 dependency

When you try the compilation from source and you haven't installed pybind11 then setup.py raises the error message ImportError: No module named pybind11, so the pybind11 dependency seems to be missing in the explicit setup dependencies.

Hi! Unfortunately, this is true. I have tried adding pybind11 to the setup dependencies, but then the error message just changes. I am closing this as a duplicate of #59, where you can also find links to a similar issue in pybind11's very own example project.


Cluster settings page sometimes requires multiple clicks to close

Cluster settings page sometimes requires multiple clicks to close. It hasn't been reproduced in master but occurs for https://github.com/lensapp/lens/pull/2065 and https://github.com/lensapp/lens/pull/2047. May be related to using a pop-up Menu element for accessing the cluster settings page. The page may be getting added multiple times to the navigation history according to @Nachasic
See the issue here:
https://github.com/lensapp/lens/pull/2065#pullrequestreview-592379673

This has to do with some odd behaviour around navigation. I don't know exactly what is causing it but from adding some inspection it is easy to observe that this behaviour only occurs when more than one cluster iframe is active.
Namely, adding the following code to src/renderer/navigation/history.ts can help observe what is going on.
navigation.listen((location, action) => {
  const clusterId = getHostedClusterId();
  const frame = clusterId ?? "root";

  logger.debug(`[NAVIGATION]: ${action}`, { location, frame });
});

fixed by #2330


[CodeCompletion][Sema] Refine logic that ignores missing arguments after the code completion position when solving

If the completion loc was in a trailing closure arg, it only makes sense to ignore later missing args if they have function type, as there's no way for the user to complete the call for the overload being matched otherwise.
Resolves rdar://problem/72412302

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test and merge

@swift-ci please test and merge


etc-ta-8h

Maybe we could spice up the wording a little bit?
Also, I didn't see the original tweet in come in via #ETCtweets yet, could you make sure you reply to your original tweet with the  hashtag? https://twitter.com/sunlal77/status/1583461955829760000.

I got 20 like on my account in less then 2 hours, that's why I've used that wording.
How about, "Is this a good day to get involved in $ETC?"
There is also the chart, so... maybe say "long" to replace "buy"?


npm run build fails with a syntax error

I'm running node v4.3.2, installed via nvm. I did a npm install, it complained that babel and cover prefers global, I then installed both those versions manually with -g, I ran npm run build and it gives me this:
$ npm run build

><EMAIL_ADDRESS>build /Users/leroux/src/draft-js
> gulp

/Users/leroux/src/draft-js/node_modules/gulp-util/node_modules/lodash.template/node_modules/lodash._isiterateecall/index.js:80
});
 ^

SyntaxError: Unexpected token )
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/leroux/src/draft-js/node_modules/gulp-util/node_modules/lodash.template/index.js:12:22)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)

npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/leroux/.nvm/versions/node/v4.3.2/bin/node" "/Users/leroux/.nvm/versions/node/v4.3.2/bin/npm" "run" "build"
npm ERR! node v4.3.2
npm ERR! npm  v2.14.12
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: `gulp`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'gulp'.
npm ERR! This is most likely a problem with the draft-js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp
npm ERR! You can get their info via:
npm ERR!     npm owner ls draft-js
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/leroux/src/draft-js/npm-debug.log

Any ideas? I really want to try this out..

Solved with the good old "rm -rf node_modules and start over" trick.

npm update probably would have done it too. Looks like a bad version of lodash got published and you hit npm at just the wrong time :/


HDFS-15765. WebHdfs: add support for basic auth and custom API path

Description of PR
WebHdfsFileSystem didn't provide any support for HTTP BASIC authentication (username/password). This patch adds that feature. When specifying filesystem URI, the credentials part (user:pass@) is now parsed properly and used for Authorization header.
Additionally, base path specified in filesystem URL used to be ignored. This patch adds configuration option dfs.client.webhdfs.use-base-path that, when enabled, indicates that this path should be used as API prefix. This allows specifying /gateway/gatewayname when using WebHdfs for Apache Knox. When base path contains /webhdfs/v1, it is ignored, since we always append that.
Option dfs.client.webhdfs.use-base-path defaults to false because it could introduce a backward compatibility break. Some WebHdfs users could have typos or something random as path, and before this patch it would simply be ignored. By setting the default to false, we make sure that it won't break any existing setup.
Note that issue HDFS-15765 is also about Kerberos auth. This patch only addresses the base path and basic authentication portion, I didn't investigate the Kerberos auth since we don't use in our setup.
How was this patch tested?
I tested it with WebHdfs secured by Apache Knox with basic authorization, but without Kerberos. I had a test script that would perform a file upload. I set dfs.client.webhdfs.use_basepath to true, and used swebhdfs://admin:admin-password@localhost:8443/gateway/docker/ as filesystem URI. Without my patch, both the admin:admin-password credentials and /gateway/docker API base path would be ignored. With it, file upload worked.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 44s

trunk passed

+1 :green_heart:
compile
6m 38s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
2m 26s

trunk passed

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
6m 13s

trunk passed

+1 :green_heart:
shadedclient
26m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s

the patch passed

+1 :green_heart:
compile
6m 39s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
6m 39s

the patch passed

+1 :green_heart:
compile
6m  7s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
6m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  9s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 1 new + 87 unchanged - 0 fixed = 88 total (was 87)

+1 :green_heart:
mvnsite
2m 13s

the patch passed

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  0s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
2m 44s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
25m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 23s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
226m 20s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

394m 52s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Found reliance on default encoding in org.apache.hadoop.hdfs.web.BasicAuthConfigurator.configure(HttpURLConnection):in org.apache.hadoop.hdfs.web.BasicAuthConfigurator.configure(HttpURLConnection): String.getBytes()  At BasicAuthConfigurator.java:[line 55]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5447

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux e0ff0413f8d1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6e04605afdddbba7baa35c13a1867a2b56811d4d

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/1/testReport/

Max. process+thread count
2125 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
19m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 41s

trunk passed

+1 :green_heart:
compile
6m  3s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 43s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
2m 31s

trunk passed

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 57s

trunk passed

+1 :green_heart:
shadedclient
22m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s

the patch passed

+1 :green_heart:
compile
5m 50s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 50s

the patch passed

+1 :green_heart:
compile
5m 36s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 1 new + 87 unchanged - 0 fixed = 88 total (was 87)

+1 :green_heart:
mvnsite
2m 11s

the patch passed

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  3s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 56s

the patch passed

+1 :green_heart:
shadedclient
22m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 29s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
206m  6s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

350m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5447

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 62e3e8274ff4 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ee843013b36a761d3050c69e008f6bd234ae6985

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/2/testReport/

Max. process+thread count
3312 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 41s

trunk passed

+1 :green_heart:
compile
6m  0s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 45s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
2m 32s

trunk passed

+1 :green_heart:
javadoc
1m 51s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 16s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
6m  3s

trunk passed

+1 :green_heart:
shadedclient
22m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s

the patch passed

+1 :green_heart:
compile
5m 49s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 49s

the patch passed

+1 :green_heart:
compile
5m 35s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
2m 14s

the patch passed

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 57s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 55s

the patch passed

+1 :green_heart:
shadedclient
22m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 31s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
211m 38s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

352m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5447

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 3bc362272e00 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5babfbce1916a11567382920024a43026c82eb04

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/3/testReport/

Max. process+thread count
3467 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the review @saxenapranav, I've applied the suggested changes.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 36s

trunk passed

+1 :green_heart:
compile
6m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 42s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
2m 29s

trunk passed

+1 :green_heart:
javadoc
1m 51s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 56s

trunk passed

+1 :green_heart:
shadedclient
22m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s

the patch passed

+1 :green_heart:
compile
5m 54s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 54s

the patch passed

+1 :green_heart:
compile
5m 40s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
2m 16s

the patch passed

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  2s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 48s

the patch passed

+1 :green_heart:
shadedclient
22m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 30s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
206m  2s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

346m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5447

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 91f6bdec7132 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 87e39011908cd63627beeab0b68ef89a2ac72454

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/4/testReport/

Max. process+thread count
3674 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the additional look @saxenapranav! I've applied the suggested changes.
Hey @Hexiaoqiao, Pranev mentioned that you could help with further review. Please let me know if you'd like me to make additional changes!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  1s

trunk passed

+1 :green_heart:
compile
5m 59s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
5m 45s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
2m 32s

trunk passed

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 19s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
6m  0s

trunk passed

+1 :green_heart:
shadedclient
22m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s

the patch passed

+1 :green_heart:
compile
5m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
5m 51s

the patch passed

+1 :green_heart:
compile
5m 39s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
5m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 16s

the patch passed

+1 :green_heart:
mvnsite
2m 15s

the patch passed

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
2m 35s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
22m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 28s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
205m 12s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

347m 11s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-client

Nullcheck of uri at line 318 of value previously dereferenced in org.apache.hadoop.hdfs.web.WebHdfsFileSystem.initialize(URI, Configuration)  At WebHdfsFileSystem.java:318 of value previously dereferenced in org.apache.hadoop.hdfs.web.WebHdfsFileSystem.initialize(URI, Configuration)  At WebHdfsFileSystem.java:[line 246]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5447

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 7e30e398beaf 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 57e1e566e51b25404c55c63ce74b4e7388075418

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/5/testReport/

Max. process+thread count
3397 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5447/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Dead link in the documentation

The "DOM type definitions" link at https://typescript-v2-784.vercel.app/docs/handbook/dom-manipulation.html leads to a 404 page

It works now (Checked in Feb 2024) 👍

I don't think it does. The link is to https://github.com/microsoft/TypeScript/blob/main/lib/lib.dom.d.ts (a file I removed!)

Yep, confirming clicking "DOM type definitions" in https://typescript-v2-784.vercel.app/docs/handbook/dom-manipulation.html still gives me 404


Using this package in PHP/Composer

I'm not sure how this is supposed to be used with Composer. I don't think there is a reliable way to get the location (directory) of the data.
The simplest way around this is with an auto-loaded class that can return the directory the data is located. Would you accept a PR with this addition?
Edit: See my fork.

@MidnightDesign Thanks for the issue.
Actually there is. Similar package umpirsky/currency-list is used in moneyphp/money.
See https://github.com/moneyphp/money/blob/master/src%2FISOCurrencies.php#L31-L46.

Do you really think this is the way to go? It seems pretty fragile to me.

This is safe as long as there are no batshit crazy custom installers in the game that relocate packages randomly. It's a similar pattern to what we do for binaries to find the autoloader really https://github.com/Seldaek/jsonlint/blob/master/bin/jsonlint#L20 and has the same constraint (no crazy custom installers).

Thanks for your opinion!
But isn't that a little different? In the case you mentioned, you're trying to initialize the autoloader itself. When autoloading is already wired up, I don't think that's the way to do it.

Well.. yeah you can for sure use a class to do the resolution, I am not saying your method is wrong, but IMO both are valid workable solutions. One uses a class as indirection which adds overhead while the other potentially does useless io/filesystem stats, but it's marginal either way I think.

Just wanted to add that it is not a primary use case to use this package with composer. Mainly because it is not limited to PHP at all.

Yeah, I got that. That's why I chose this title for the issue. :)

:)


Matplotlib inlinebackend = Retina doesnt work

https://ryanwingate.com/visualization/matplotlib/inline-backend-on-retina-displays/
It should render matplotlib plots at a high resolution but keep it the same size, but in VS Code it makes all the plots bigger.

I have been looking at this today as part of vsc notebook rendering. Different types of images and scissored metadata.
Hence I'll look into your

Yup, more metadata that we aren't supporting.

Only fixed in VS Code Notebooks


Special workspace not visible during workspace switching

Hyprland Version
Hyprland, built from branch makepkg at commit 8b57a1973ea8b242783069e9a3e3d31e3cd939a8 dirty (internal: Allow floating windows on special (3872)). Tag: v0.32.3-34-g8b57a197
Bug or Regression?
Bug
Description
Switching workspaces when a special workspace is visible, causes that special ws to hidden behind the windows on the non-special new workspace until the switching is finished.
Also, In my opinion switching a workspace with a visible special workspace should either keep the special focused (i would prefer that), or hide the special one.
The way it is now after switching the special is still visible but not focused, i think that is not usefull at all, and a state that can't be reached in other ways.
How to reproduce
See description
Crash reports, logs, images, videos
No response

confirmed 572fd554b8e86b3b3533f05631348c3374815ab5
It's especially entertaining when you have a window rule to fade in the windows 😸

@vaxerski after the last change, this issue is back too!

This seems to be fixed!
Thanks


Add CI to run unit tests

Issue #, if available:
Description of changes:
Add CI to run unit tests on PRs, the CI also verifies if the generated helm template matches with the expected one
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

https://github.com/aws/eks-pod-identity-agent/pull/37/files#diff-245392b692a50c38ecab4381b118862db514035c10983f3bd4f4b7f1f4be4692R14 don't think we have a .go-version?

Good catch, seems it automatically picked 1.23.4, but explicitly added .go-version file


Some properties are not preserved on de-serialization

Main Points
There are a number of properties which are not preserved by our de-serialization process.
wants-move   The easiest way to test this is to add a part, set "wants-move" to true, serialize and load. You will see the property properly set in the editor but no effect. Toggling it will bring the effect back, as expected.
Similarly for "allow-scrolling" as demonstrated by the two screenshots below. First is before serialization, 2nd is after:

@dkrasner I have had  a fix to the allow-scrolling case in my working branch. It should be good once I merge in the language stack. See this commit and its message: https://github.com/dkrasner/Simpletalk/commit/7d69edb4f7e2458ac12adf7256b58cab23deb4ab


A0-2405: Use every_imported_block notification

Description
We use the extended notification that will inform us about every imported block. We also can request justifications, hence Forest refresh becomes unnecessary.
Type of change

New feature (non-breaking change which adds functionality)

Checklist:

connected to testnet, synced 0.5M blocks in 30 minutes, no issues


[docs/themes.md] fix typo 'muTheme' -> 'muiTheme'

[ ] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@100ideas thank.

@oliviertassinari welc.


Problematic if a note is accidentally deleted

If a note is accidentally deleted

A submission can no longer be linked to the noteId (which means all stored submissions will no longer have a link to a note)
The goldstandard will also be missing a note.
The note can be replaced, but it would have a new noteId

P.S. yes, I accidentally deleted a note :/

The solution seems to allow the user to specify the ID of the note, which can then give its name like datasets/{datasetId}/fhirStores/{fhirStoreId}/Note/my-note. This would also make a dataset and its content portable.


Inventory Space's are not visible

When viewing the Bag, the empty inventory spaces are not visible.

Stop Gap in place till I can effectively achieve a placeholder for empty slots.
Stop Gap is a Label with that Slots Numeric Index Value.


'Twine' Object

It would be neat to have an object designed to quickly concat sets of strings, potentially without reallocation. The name is inspired from LLVM's Twine class, which they use to take lists of strings and throw them into a single buffer at once.
This could be more effective than table.concat for frequently called methods, or even seldom called methods that require lots of different concatenating characters or large buffers.
It could inherit (or pseudo-inherit) from List and be used for intermediate steps and string buffering, much like in other platforms.

This should have mechanics similar to Tuple.


[REQUEST]

Is your feature request related to a problem? Please describe.
I am told that my internet is 50 mbps, but in Hydra it is 110 kb

Describe the solution you'd like
i need my internet 5mbps
Describe alternatives you've considered
none
Additional context
No response

just read the README


Git line diff and tree view status don't show changes for capitalization-renamed directories

#19191 # Prerequisites

[X ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
The built in version control ignores capitals in folder names (example: Component).  This breaks  git-diff and version control coloring coding in tree-view.
Steps to Reproduce

In a version controlled project, rename a folder using capitals (ex: Component)
Make changes to any files within that folder
Changes won't be visible by git-diff or tree-view.

Edit by @rsese to add more detailed repro steps
In some new project directory:

mkdir dir
touch dir/test.txt
git init; git add .; git commit -m "Initial commit"
atom .
Rename the directory from dir to Dir
Open and save an edit to Dir/test.txt

Screenshot after reloading the window (test.txt should be orange in the tree view and "hello world" in the text file should have the green highlight in the gutter):

From the command line:
$ git diff
diff --git a/dir/test.txt b/dir/test.txt
index e69de29..3b18e51 100644
--- a/dir/test.txt
+++ b/dir/test.txt
@@ -0,0 +1 @@
+hello world

Expected behavior:
Changes to be visible by git-diff/tree-view
Actual behavior:
Changes show for a split second but disappear straight away as if no changes were made to the file
Reproduces how often:
Always
Versions
Atom    : 1.28.2
Electron: 2.0.5
Chrome  : 61.0.3163.100
Node    : 8.9.3
Windows 10
Additional Information

Atom : 1.28.2

@fonziemedia Atom is currently on version 1.39.1, please try that first to see if your issue still reproduces.

Hi @Aerijo,
Thanks for your reply and apologies I overlooked the version I was using.. I thought it was auto updating but my company had them disabled.
I've now updated to 1.39.1 but unfortunatelly the issue is still ocurring.
Thanks for looking into this.

Thanks for trying 1.39.1 @fonziemedia - I was able to reproduce with 1.41.0-nightly3 as well.  Thought this might be Windows specific but I reproduced on macOS 10.14.6.

Hi guys,
Just to add a bit more info that might be helpful:
If you set the 'ignorecase' option to 'false' in  .git/config the issue goes away. However, I think Atom should recognise case changes with the default config options.

For completeness, on Linux which is case sensitive, shown as a new file added (and the GitHub package shows it as a deletion + new file):

Any update on this? Just happened to me and it took me a while to figure out why it wasn't working.


Traffic Graph tab enhancement

Use IFrame to move the Kiali Graph into Rancher UI.

Version: master-head (7/26/19)
This change simply creates an iframe now for the "Traffic Graph" tab. We have an iframe of what we see in Kiali:

This let's us leverage Kiali UI features such as pictured below (traffic animation and weight)

I tested each option in the UI as carefully as I could -- essentially smoke testing all the different views and options. I made sure any pop-ups (window overlays like the Legend) work as expected. All in all it's essentially an iframe and it works as expected.
I tried to break things and wasn't able to identify any issues. Rancher is showing the iframe in a manner I expect and that makes sense to me. I was not able to break anything in the Kiali UI (which would be a Kiali issue anyway).

I did spot a minor issue and entered that here: https://github.com/rancher/rancher/issues/21811


Floating point exception when computing gradients

Hi tensorflow developer team!
I just wanted to first let you know that I really appreciate all the work you are putting into this amazing open source system. It has been a terrific system for me so far. However, I have come into a roadblock when using the tf.gather function in gradients.
I am using
Environment info
Operating System: CentOS
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
CUDA version 7.5
cuDNN version 7.0 (64 bit)
tensorflow/0.8.0-gpu version
Steps to reproduce
I obtain a floating point exception when I run the following code
A_ph = tf.placeholder(tf.float32, shape=(None, 2))
ind_ph = tf.placeholder(tf.int32, shape=(None, 2))
gather = tf.gather(A_ph, ind_ph)
redsum = tf.reduce_sum(gather, 1)
l2 = tf.reduce_sum(redsum)
A = np.array([[0,0],[0,0],[0,0]])
ind = np.zeros((0,2))
grad_op = tf.gradients(l2, A_ph)
out = sess.run(grad_op, feed_dict={A_ph:A, ind_ph:ind})
What have you tried?
If you replace ind with a non-empty array, such as [[0,1]] it works fine.
I suspect that the output of redsum = [], which makes l2 disconnected from A_ph for the given ind. Fed forward to computing l2, I get the correct value of 0.0 (since there is nothing to be summed). However, for backpropagation of gradients, I think the output of redsum=[] chokes the algorithm, and causes it to evaluate some illegal operation using an empty tensor, instead of just backpropagating 0.0.
Are there any solutions to this problem currently? In my use of this computation, I won't know ahead of time whether or not the intermediate computations produce [] (empty tensor), but I also want to be able to get the correct gradients when this happens. Thank you so much for your consideration!

Thanks for the bug report.
@girving ReshapeOp is generating SIGFPE in this program.

Thanks for reporting!  We're going to fix TensorFlow to produce nice exceptions for integer zero divisions.

Ah, there are two bugs here: one bug that we crash the process on integer division by zero, and another that we generate a division by zero.

Yes, I think there should never be any division by zero in the above operations, at least from what I can tell from the backpropagation formulas. I think I should definitely be able to get a None gradient to indicate that that l2 and A_ph are disconnected, rather than an exception. Is the bug a complex one to fix?

@altaetran: It's conceptually straightforward: one has to go through and sanitize all the occurrences of // in math_grad.py.  Unfortunately there are a bunch of them for a variety of different ops, and the fixes look different in the different cases.
However, there's no way to get a None gradient, since the variables are connected, just through an empty tensor bottleneck.  Since we don't necessarily know that the shapes are empty until runtime, we can't produce None.

@altaetran: To make my initial comment make sense: we want to produce nice error messages even for malformed ops, so we want to fix the underlying divisions by zero regardless of whether we fix the gradient code.

Oh I see, so those would be two separate tasks. Is there a reason for why an empty bottle neck tensor in the gradients produces division by zero though? Or is that something to be changed as well?

As I said: the fixes are straightforward but there are a number of them.  Here is an example of a bad line: https://github.com/tensorflow/tensorflow/blob/5e22e3a3187e6729488f4a6da59b4cfbedc40946/tensorflow/python/ops/math_grad.py#L36

Oh I see ok. So then this is likely something to occur in a future patch?

I'm looking at it now, so not too long except for the upcoming weekend. :)
I'll probably fix the gradients first since making integer division safe is slightly more awkward (to do in a reasonably performant manner).

CL submitted, so it should be on Github within 24 hours.

To clarify: I fixed the gradients not to divide by zero, which should solve your issue.  Integer divide by zero on its own will still crash the process.

Great! Been running into a similar problem myself. As a question, is there a local version of the patch I could use? I'm running Tensorflow 0.8.0 on a cluster, and the sysadmins won't rebuild the cluster version before TF 0.9.0 (or the next stable version)

@rbharath: Do you want source or binaries?  The source version should have the fix tomorrow.  Not sure when the nightly appears (tomorrow or the next day), but the links for those are here: https://github.com/tensorflow/tensorflow/blob/master/README.md

@girving Sorry, should have been clearer. Is the fix python only? If so, would I be able to just use the corrected python module instead of the standard module without rebuilding the rest of the source? (The issue is that our cluster runs with an old CentOs with an old glibc, so the sysadmins have to do a ton of work to get tensorflow to build, so it's infeasible for us to use binaries or rebuild except at stable releases).

@rbharath: Ah, yes: the fix I just made is Python only.  However, we don't have any setup for using different Python alongside C++, and in any case you'd have to carefully cherry-pick just my change ontop of 0.8.0 to have a hope of succeeded.


Possible race condition in stream registry

The ForEachStream method in the stream registry can trigger a race.
The intention of the following code is to copy the map, but instead it creates a reference.
See https://github.com/trivago/gollum/blob/master/core/streamregistry.go#L168
registry.streamGuard.Lock()
routers := registry.routers
registry.streamGuard.Unlock()

AFAIR this pattern also exist in other locations in the code.
Those should also be fixed.

Fixed


Issue #2675 [staging & production] Can't mass-update permissions on child nodes

Purpose
This allows admins to mass update permissions on child nodes for contributors they've readded to the parent node of.
Closes issue https://github.com/CenterForOpenScience/osf.io/issues/2675
Changes
Now when someone is added to a node they're already on there permission updates.
Side Effects
None that I know of.

@Johnetordoff Could you update the comment part according to the format requirement? Also close the pull request you replaced https://github.com/CenterForOpenScience/osf.io/pull/2914.

@Johnetordoff, please put the issue number this closes in the description and not in the title.

@Johnetordoff, could you take a look into the failing tests? Thanks!

This looks great! Just one small addition-- the add_contributor function will call self.save() if save=True is passed into the function: https://github.com/CenterForOpenScience/osf.io/blob/develop/website/project/model.py#L2237-#L2238. Can you add this in for when the permissions are overridden?

First pass complete! :+1:

Can you add a test case for this change to tests.test_models.TestProject? That's where the other tests are for adding a contributor. After that, I think this should be good to go! :whale:

@samanehsan ping!

Pass complete! :sunglasses: Please ping me when you're done making changes.

To my understanding, Issue  #2675 actually doesn't deal with that. It isn't for making the parent and child permissions consistent, it's specifically deals with re-adding people overwriting old child perms. I brought up the same "All-the-way-down" behavior in the comments here: #2675.
So I don't know how to formulate a test case for this. It's just created by a quirk of the UI. because what the issue really is, double dipping, using add_contributor for a node that a contrib is already on. In a perfect world this would not be allowed, but the UI is designed in a way that basically necessitates it.

Just a few more changes! :octopus:

Thanks! I think this is good to go @sloria! :octocat:


libgdata: add gnome-online-accounts to propagatedBuildInputs

Motivation for this change
libgdata's new Meson config lists gnome-online-accounts as a dependency. Downstream apps which use Meson (like shotwell) refuse to build without gnome-online-accounts in the build env.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I'm suspect that the error
meson.build:117:0: ERROR: Could not generate cargs for libgdata:

that line being
gdata = dependency('libgdata')

means that I should probably fix something in libgdata.

It seems the changes in the .pc files are pertinent
Here's a diff of the two files
--- libgdata-old.pc	2019-07-26 20:48:19.032408179 -0400
+++ libgdata-new.pc	2019-07-26 20:48:44.987912414 -0400
@@ -1,13 +1,14 @@
-prefix=/nix/store/hyakiglm5s4xw24jj001yq51pxglbb3q-libgdata-0.17.9
+prefix=/nix/store/mg16sjmcq5k2nbq63ni9q118a7x4hd5v-libgdata-0.17.10
+libdir=${prefix}/lib
+includedir=/nix/store/icz2m06whc3lwlx1pwgbqpqx9p6irky9-libgdata-0.17.10-dev/include
+
 exec_prefix=${prefix}
-libdir=${exec_prefix}/lib
-includedir=${prefix}/include
 goa_enabled=true

 Name: libgdata
 Description: GData client library
-Version: 0.17.9
-Requires: gobject-2.0 glib-2.0 >= 2.44.0 gio-2.0 >= 2.44.0 libxml-2.0 libsoup-2.4 >= 2.42.0 json-glib-1.0 >= 0.15
-Requires.private: gthread-2.0 oauth >= 0.9.4 gcr-base-3 libxml-2.0 goa-1.0 >= 3.8
+Version: 0.17.10
+Requires: gobject-2.0, glib-2.0 >=  2.44.0, gio-2.0 >=  2.44.0, gio-unix-2.0, json-glib-1.0 >=  0.15, libxml-2.0, libsoup-2.4 >=  2.42.0, goa-1.0 >=  3.8
+Requires.private: gthread-2.0, oauth >=  0.9.4, gcr-base-3
 Libs: -L${libdir} -lgdata
 Cflags: -I${includedir}/libgdata

It seems at some point goa was intentionally private

https://gitlab.gnome.org/GNOME/libgdata/commit/b4d828e002adf21a5ef671ec1b62bed2f48382af

I guess this should be done again upstream for the generated .pc file with meson.

Ahh that was an intentional change

https://gitlab.gnome.org/GNOME/libgdata/merge_requests/6/diffs?commit_id=0d463dcda944dedce3050f4d541fbfeccba9b569

We should add gnome-online-accounts to propagatedBuildInputs in libgdata.

We should add gnome-online-accounts to propagatedBuildInputs in libgdata.

Oh yeah, that's a better approach. I'll start testing that; note that it might take me a while to complete test builds of all the reverse dependencies.

Updated to export gnome-online-accounts from libgdata via propagatedBuildInputs. Should cover all reverse dependencies.

LGTM, could you fetchpatch the commits off master from these PR's ?

https://gitlab.gnome.org/GNOME/libgdata/merge_requests/9
https://gitlab.gnome.org/GNOME/libgdata/merge_requests/10
https://gitlab.gnome.org/GNOME/libgdata/merge_requests/11

This is something I forgot to do initially.

LGTM, could you fetchpatch the commits off master from these PR's ?
* https://gitlab.gnome.org/GNOME/libgdata/merge_requests/9

* https://gitlab.gnome.org/GNOME/libgdata/merge_requests/10

* https://gitlab.gnome.org/GNOME/libgdata/merge_requests/11

This is something I forgot to do initially.

I'll take a look.

Added the Meson patches. They seem to work ok and all reverse-dependencies build.

Added the Meson patches. They seem to work ok and all reverse-dependencies build.
EDIT: Oops, hang on, I used patches from the merge requests. Let me change it to use the master commits in case the MRs disappear.

Fixed, the Meson fixes now use the master commits.


PBTS: wrapping up spec, not draft anymore

Rendered
Addresses https://github.com/tendermint/tendermint/issues/8953, taking into consideration https://github.com/tendermint/tendermint/issues/8628
For some reason, Git is not tracking the renamed filed pbts-algorithm*.md properly. A better diff as follows:
git diff --word-diff main:spec/consensus/proposer-based-timestamp/pbts-algorithm_002_draft.md cason/pbts-review:spec/consensus/proposer-based-timestamp/pbts-algorithm.md

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Includes #1206