rest.WithCors("*") and token verify the execution order.

Describe the bug
Start JWT authentication, and use ajax to request without token, or when the token has expired. The framework will report CORS error.
If the Ajax request carries a valid token, there is no cros problem.
Use rest.WithCors("*") setting cros issues remains the same
To Reproduce

API starts JWT verification

Ajax requests the API with invalid token or without token

Cross domain error reported by the framework

Ajax carries a valid token

API returns to normal

The code is
	ctx := svc.NewServiceContext(c)
 server := rest.MustNewServer(c.RestConf,
 	//Cros is set here. Token is invalid and does not take effect
 	rest.WithCors("*"),
 	rest.WithUnauthorizedCallback(func(w http.ResponseWriter, r *http.Request, err error) {
 		//Cros settings take effect here
 		origin := "*"
 		header := w.Header()
 		header.Set(allowOrigin, origin)
 		header.Set(allowMethods, methods)
 		header.Set(allowHeaders, allowHeadersVal)
 		header.Set(exposeHeaders, exposeHeadersVal)
 		if origin != allOrigins {
 			header.Set(allowCredentials, allowTrue)
 		}
 		header.Set(maxAgeHeader, maxAgeHeaderVal)
 		httpx.OkJson(w, nil)
 	}))
 defer server.Stop()

The error is
Browser reports CORS error

Expected behavior
It is hoped that cross domain settings can still be set when token is invalid No error is reported
Screenshots
nothing
Environments (please complete the following information):

OS: [e.g. Linux]
go-zero version [e.g. 1.2.4]
goctl version [e.g. 1.2.1, optional]

More description
After testing, the cros settings in rest.WithUnauthorizedCallback() are restored to normal.
The guess is that token authentication and cros settings are executed in the wrong order.
Happy New Year!

Let's discuss this for details on wechat or slack?


Add metrics for ellipticity and magnitude on galsim simulated blends as function of SNR and blendedness

Closes #456

Done! Results look promising I think (first bin in SNR has 5 objects, so ignore for now)


Fix under accent depth

Fix #2251. By correcting the depth reported for an under-accent, we fix the problem when they are rendered inside \left( and \right).

@ylemkimon Thank you for the review!

thank's !!!

just 2 questions :

when do you plan to release 0.12.0 ?
will \html be part of the 0.12.0 release ?

thx for all your work here .... katex is just super great !


Add missing rule error

Current coverage is 97.07% (diff: 100%)

Merging #32 into master will not change coverage

@@             master        #32   diff @@
==========================================
  Files            16         16
  Lines           410        410
  Methods          83         83
  Messages          0          0
  Branches          0          0
==========================================
  Hits            398        398
  Misses           12         12
  Partials          0          0

Powered by Codecov. Last update c72e070...d21b613


CAMEL-16080: Migrate camel-kamelet component from camel-k-runtime to camel

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

And it would be nice with an example at camel-examples git repo

And it would be nice with an example at camel-examples git repo

I can only find some bits in the doc page. I tend to like that things are named myXXX when its something that the end user can freely choose.

fixed

I can only find some bits in the doc page. I tend to like that things are named myXXX when its something that the end user can freely choose.

fixed

And it would be nice with an example at camel-examples git repo

will create one once merged

And it would be nice with an example at camel-examples git repo

will create one once merged


[$500] Room- Room name changed is not updated in admin comment section

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.94-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap fab--start chat
Tap Room
Enter all details and tap Create Room
Tap on the header
Tap Members---Invite
Invite any user to the room
Tap settings
Tap room name and change it
Go to Workspace admin room in which "Room" was created
Note the comment of user invited to room
Note the room name in LHN

Expected Result:
Room name changed must be updated in admin comment section and LHN
Actual Result:
Room name changed is not updated in admin comment section and LHN
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a6183027-5614-46a1-9395-1187e4b92f9e
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e512ffd790127318
Upwork Job ID:<PHONE_NUMBER>951098368
Last Price Increase: 2023-11-01
Automatic offers:

hoangzinh | Reviewer | 27554495
dukenv0307 | Contributor | 27554496

Issue OwnerCurrent Issue Owner: @techievivek

@dukenv0307 we are getting updated room name report and invite report in different api calls and both are being stored in different keys in onyx. i have doubts if it will be possible to handle this only from frontend.

@hoangzinh any thoughts on the proposal above?

Ooh good catch @hoangzinh, yes we should!

@hoangzinh any updates? Looks like the PR hasn't had any action for a month.

Thanks @hoangzinh!

Noting that I'm on leave from tomorrow until Jan 8th and will check in on my return.

I don't think this is worth fixing to be honest. It makes sense that the change log for the room matches the name of the room when the person was invited.
We have other change logs that reflect the name of the room being updated.

Thanks for your input, @jasperhuangg. I agree with your thoughts. This should be fine as long as it links correctly to the room and the changes are recorded.

@kadiealexander, Can we please review the compensation here since a PR was already raised and reviewed?

Guidelines say they're paid in full!
Payouts due:
Contributor: $500 @dukenv0307
Contributor+: $500 @hoangzinh
Upwork job is here.


phpPackages.phpstan: 1.10.57 -> 1.10.58

Description of changes
release notes: https://github.com/phpstan/phpstan/releases/tag/1.10.58

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@patka-123 why ?

wow, I didn't even see it the first time! I guess it's the view on the mobile.


Including blog posts from Simon Headley

Hey Dapr team
I am raising a PR with links to my blog posts around Dapr. Q: should we also reference the CNCF case study, or is that covered implicitly due to its publicity?
TIA :)

@holopin-bot @KrylixZA writer-badge


[VC] Add featuregates cmdline support in syncer

We will enhance syncer to support various new features such as enabling a super cluster pool to serve multiple tenants.
This change adds feature-gate command line support to the syncer.

/lgtm
/approve

Potentially consider using the component base feature flag libraries. Otherwise looks good! ￼￼ https://github.com/kubernetes/component-base/tree/master/featuregate


feat: CreateCLPool & LinkCFMMtoCL pool into one gov-prop

Closes: #5888
What is the purpose of the change
Currently we have 2 gov prop message to migrate pool from GAMM.
Create CL Pool
Link GammPool with CL pool
This take 2 gov period which is too long. Lets create a gov-prop that will handle both of these commands in one
Testing and Verifying
localosmosis tested
/osmosis #
/osmosis # osmosisd q gov proposals 1
pagination:
  next_key: null
  total: "0"
proposals:
- content:
    '@type': /osmosis.gamm.v1beta1.CreateConcentratedLiquidityPoolsAndLinktoCFMMProposal
    description: add
    pool_records_with_cfmm_link:
    - balancer_pool_id: "2"
      denom0: uosmo
      denom1: uion
      exponent_at_price_one: "-6"
      spread_factor: "0.001000000000000000"
      tick_spacing: "100"
    title: add
  deposit_end_time: "2023-07-28T21:02:14.184663875Z"
  final_tally_result:
    abstain: "0"
    "no": "0"
    no_with_veto: "0"
    "yes": "0"
  is_expedited: false
  proposal_id: "1"
  status: PROPOSAL_STATUS_VOTING_PERIOD
  submit_time: "2023-07-26T21:02:14.184663875Z"
  total_deposit:
  - amount: "1000000000"
    denom: uosmo
  voting_end_time: "2023-07-26T21:03:34.234001152Z"
  voting_start_time: "2023-07-26T21:02:34.234001152Z"
-------
/osmosis # osmosisd q gamm cl-pool-link-from-cfmm 2
concentrated_pool_id: "4"

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

just checked
/osmosis # osmosisd q gov proposal 1
content:
  '@type': /osmosis.gamm.v1beta1.CreateConcentratedLiquidityPoolsAndLinktoCFMMProposal
  description: add
  pool_records_with_cfmm_link:
  - balancer_pool_id: "2"
    denom0: uion
    denom1: uosmo
    exponent_at_price_one: "-6"
    spread_factor: "0.001000000000000000"
    tick_spacing: "100"
  title: add
deposit_end_time: "2023-08-04T20:35:26.728976737Z"
final_tally_result:
  abstain: "0"
  "no": "0"
  no_with_veto: "0"
  "yes": "500000000"
is_expedited: false
proposal_id: "1"
status: PROPOSAL_STATUS_PASSED
submit_time: "2023-08-02T20:35:26.728976737Z"
total_deposit:
- amount: "1000000000"
  denom: uosmo
voting_end_time: "2023-08-02T20:36:36.753489095Z"
voting_start_time: "2023-08-02T20:35:36.753489095Z"

/osmosis # osmosisd q gamm cl-pool-link-from-cfmm 2
concentrated_pool_id: "4"

/osmosis # osmosisd q concentratedliquidity pools
pagination:
  next_key: null
  total: "0"
pools:
- '@type': /osmosis.concentratedliquidity.v1beta1.Pool
  address: osmo1ad4r3uh5pdn5pgg5hnl6u5utfeqmpwstlvgvg2h2jdztrcnwkqgs3hs85z
  current_sqrt_price: "0.000000000000000000000000000000000000"
  current_tick: "0"
  current_tick_liquidity: "0.000000000000000000"
  exponent_at_price_one: "-6"
  id: "4"
  incentives_address: osmo1ra25mx8lch089mxf97nr6cnzns7vesecvw0mxj32fcaj5ygrsd8sqwhjpk
  last_liquidity_update: "2023-08-02T20:36:36.898121604Z"
  spread_factor: "0.001000000000000000"
  spread_rewards_address: osmo1w60ad6wuhkxeyuqfhnflvtkzcsrpey2xv6s05r00xxegl4vcedsqqu89g6
  tick_spacing: "100"
  token0: uion
  token1: uosmo

First pass looks good, it appears you only tested that the prop gets posted though according to your log though. Can you pass the prop and confirm the results? After that I think we can merge.

merging this as the gov prop has been tested and logs are posted


duplicate elements generated by GEnum Word{8,16,32,64} instances

I'm afraid there's still something not quite right:
> length (genum :: [Word8])
512

I'd expect (genum :: [Word8]) == [minBound .. maxBound] for unsigned fixed-width types...
Or more generally (this holds for Int{8,16,32,64} at least it seems):
prop_bounded_ints :: (Bounded a, Enum a, Ord a, GEnum a) -> Bool
prop_bounded_ints = Data.List.sort (genum :: [a]) == [minBound .. maxBound]

This should be fixed as of d82c53f514ce3dccf04bb3ddc2780e6365adb72f.


"LookupError: gradient registry has no entry for: shap_TensorListStack" using DeepExplainer for Keras Model

Hello @slundberg,
I am getting the following error when using the DeepExplainer for the Keras sequential model for Multiclass text classification. Please find the details below:
##KERAS VERSION: 2.4.3.
##MODEL
model = Sequential()
model.add(InputLayer (input_shape= (max_len ,)))
model.add(Embedding (vocab_size +1 , embed_dim , input_length= max_len, weights[embed_matrix]))
model.add(LSTM (LSTM_unit , dropout= dropouts, recurrent_dropout=dropouts,return_sequences=False))
model.add(Dense (6 , activation="softmax"))

##DEEPEXPLAINER
explainer = shap.DeepExplainer(model, X_train[:100], learning_phase_flags = None)
shap_values = explainer.shap_values(X_test[:10])
##ERROR
LookupError: gradient registry has no entry for: shap_TensorListStack
Please help me with the solution to this issue. I have tried all the possible solutions provided in the issues mentioned in the repository but couldn't able to solve this error.
Best Regards,
Meghna Goyal

I am expressing the same error:
explainer = shap.DeepExplainer(model,x_train[:100])
shap_values = explainer.shap_values(x_test[:10])
''    LookupError: gradient registry has no entry for: shap_TensorListStack"

+1 Having the same issue.

Same issue here. @slundberg any chance you could take a look?

Same issue here

Same issue :/

Hello, I have the same problem as you, and I tried my best to solve it, but I failed. Could you tell me how to solve this problem? thank you!!

Same issue

+1 I have the same issue.

I no longer have this issue.
Solution is found here: https://github.com/slundberg/shap/issues/1551#issuecomment-851623882

Same issue here!

Same issue here :(

Same issue here . I am trying to use it on Google Collab and getting the following error:-
TypeError: Argument fetch = None has invalid type "NoneType". Cannot be None.
@loewenm I tried your solution too but it didn't work for me.
My SHAP version is: 0.41.0
Tensorflow version is: 2.9.2

I had the same error but managed to resolve it by sticking to a specific set of package versions:

TensorFlow 1.14
Python 3.7
Protobuf 3.20
h5py 2.10

import tensorflow as tf
import sys
import google.protobuf
import h5py

assert tf.__version__ == '1.14.0'
assert sys.version_info[0] == 3 and sys.version_info[1] == 7
assert google.protobuf.__version__ == '3.20.0'
assert h5py.__version__ == '2.10.0'

Same issue.

tensorflow 2.16.1
keras 3.0.4
shap 0.46.0

tensorflow 2.16.2
keras 3.4.1
shap 0.46.0
Same issue

same issue.
shap: 0.46.0
tf: 2.17.0

@JulianKlug  I resolve my error by your reply

我通过您的回复解决了我的错误
same issue.Is it solved?

Same issue with:
TensorFlow version: 2.17.0
SHAP version: 0.46.0

Same issue here:
SHAP: 0.46.0
Tensorflow: 2.16

I've ditched SHAP with TensorFlow 2.x - it was a pain! Now I just run a Docker container with Python 3.7 and TensorFlow 1.14.0, and feature importance explanations work like a charm. No more stress about this!


ReferenceError: CSSStyleSheet is not defined

Describe the bug
services/publishing/.vite-ssg-temp/wsz1ya4dub/main.mjs:62887
styleSheet: new CSSStyleSheet(),
^
ReferenceError: CSSStyleSheet is not defined
Reproduction
vite-ssg build
add  new CSSStyleSheet() anywhere and build fails
System Info
✓ built in 4.22s

[vite-ssg] An internal error occurred.
[vite-ssg] Please report an issue, if none already exists: https://github.com/antfu/vite-ssg/issues
file:///publishing/.vite-ssg-temp/f3lxys23re/main.mjs:62887
      styleSheet: new CSSStyleSheet(),
                      ^

ReferenceError: CSSStyleSheet is not defined

### Used Package Manager

pnpm

### Validations

- [X] Follow our [Code of Conduct](https://github.com/antfu/.github/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guide](https://github.com/antfu/contribute).
- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
- [X] The provided reproduction is a [minimal reproducible](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

🤦 ofc this is how SSG works, closing cause not enough coffee 🤣


Update houdahgeo to 5.1.8

Appcast no longer seems valid and haven't found another yet

After making all changes to the cask:

[x] `brew cask audit --download {{cask_file}}` is error-free.
[x] `brew cask style --fix {{cask_file}}` left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as b5eebb1b3cc5eecce9b0c7757f95744664e3bb3a. Your contribution is still credited to you.


Using crypto-wasm-ts in a browser

I'm trying to use the module in a browser, but it cannot be resolved correctly: Uncaught TypeError: Failed to resolve module specifier "@docknetwork/crypto-wasm-ts".
Any suggestions?

Running typescript in a browser isn't practical first convert it to js using yarn build and then use the js file in your browser. The project doesn't have a bundler to create a single js file yet as we expect the consumer app to have a bundler setup, eg. sdk uses this project and its bundler (rollup) takes care of it.


Yomiroll: Couldn't find any video links

Source information and language
Yomiroll 13.24 (all)
Steps to reproduce
Example in Naruto shippuden and demon slayer.
Begin playing an episode.
Expected behavior
Anime should start playing
Actual behavior
Instead of playing it exits the video and gives the prompt: "Couldn't find any video links".

Aniyomi version
<IP_ADDRESS>
Android version
Android 11
Other details
It only happens on certain anime I have no way to fix it.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Those anime or ep of anime you are able to play on yomiroll are free on crunchy roll but those anime that have premium ep will not play . No idea when will it fixed

Duplicate of #1720


feat: Adding architecture definition module and additional folders variable

Overview/Summary
Adding architecture definition module for FSI/SLZ, and additional_folders, enable_alz, and architecture_definition_path hidden variables
This PR fixes/adds/changes/removes

Adds support for including additional folders to repo
Adds architecture definition creation module
Adds hidden variables to include alz archetypes in architecture definition template file(enable_alz), architecture definition file path(architecture_definition_path), and include additional folders in repo(additional_folders)

Breaking Changes

None

Testing Evidence

As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.

@microsoft-github-policy-service agree company="Microsoft"


Add support for "elevation" property

Since Android 5.0+ there is a new property called "elevation": https://www.google.com/design/spec/what-is-material/elevation-shadows.html#elevation-shadows-elevation-android-
It allows to raise a widget on the z-axis.

This issue is a sub issue of https://github.com/eclipsesource/tabris-js/issues/602

Implemented for the 1.5 release.


[BEAM-362] Move a few more remnants of internal state to runners/core-java

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @staslev just spreading the burden of my boring move PRs. This is a no-op but I'm trying to get the SDK cleaned up whenever it overlaps with something I am really working on.
The tests fail because the Dataflow service needs a corresponding update, but I like to get the external PR mostly approved first before I do that, and then I can fix it up, get green, and merge.

Run Dataflow RunnableOnService

Run Dataflow RunableOnService

Changes Unknown when pulling 255c7e28d00a41341cf05764b170462cd41e35c1 on kennknowles:StateTag into ** on apache:master**.

LGTM.


Composite primary key errors

"Reopening" this as this does seem to be an issue, or it's a misunderstanding.
Using a standard reference implementation of composite keys, you'll get an error when calling Add on an Entity in the DBContext:
InvalidOperationException: Unable to track an entity of type 'Client' because its primary key property 'TenantId' is null.
I have created a PR/fork of the sample project that can reproduce this issue: https://github.com/Finbuckle/Finbuckle.MultiTenant/pull/834

Thanks for creating the fork. Just out of curiosity have you tried different database providers at all? I'm trying to figure out the scope of the issue and if it is specific to one provider or something similar. It may be more fundamental than that.
Also do you think this is something that could impact a non Finbuckle.MultiTenant db context? Is there a way to arbitrarily reproduce it by setting a primary key as a composite on regular db context?

So I initially encountered this using the Npgsql.EntityFrameworkCore.PostgreSQL provider.
I've never personally created a "virtual" composite key before.
I'm also trying to decide how to proceed on my side. i.e is it fine for the PK/FK relationship to just be on the ID field, and just use .AdjustUniqueIndexes().AdjustIndexes()

Thanks for creating the fork. Just out of curiosity have you tried different database providers at all? I'm trying to figure out the scope of the issue and if it is specific to one provider or something similar. It may be more fundamental than that.
Also do you think this is something that could impact a non Finbuckle.MultiTenant db context? Is there a way to arbitrarily reproduce it by setting a primary key as a composite on regular db context?

So I initially encountered this using the Npgsql.EntityFrameworkCore.PostgreSQL provider.
I've never personally created a "virtual" composite key before.
I'm also trying to decide how to proceed on my side. i.e is it fine for the PK/FK relationship to just be on the ID field, and just use .AdjustUniqueIndexes().AdjustIndexes()

I tried to add tenantId as a key in Postgres and SQLSERVER. The issue exists for both the DBs
System.InvalidOperationException: Unable to track an entity of type 'Product' because its primary key property 'TenantId' is null.

It’s an issue at the tracker level for any db provider.
There is a workaround example from pr #834
The idea is you attached in the detached state, set the tenant id shadow property, then change the state to added.
app.MapGet("/create-client", (ApplicationDbContext applicationDbContext, HttpContext httpContext) =>
{
    var client = new Client { Name = "Client 1" };
    var tenantId = httpContext.GetMultiTenantContext<AppTenantInfo>().TenantInfo?.Id ?? "null";
    applicationDbContext.Entry(client).Property("TenantId").CurrentValue = tenantId;
    applicationDbContext.Add(Client);

   // set here or somewhere else if desired...
   applicationDbContext.TenantMismatchMode = TenantMismatchMode.Overwrite;

   applicationDbContext.SaveChanges();

    return Results.Ok("Client created");
});

So, Do I need to add this work around in every controller and each API?

So, Do I need to add this work around in every controller and each API?

basically yes, but you can get EFCore to fix/automated this for you, doing something like this
In your application context
       public override async Task<int> SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default)
        {
            ReplaceTenantIdPlaceholders();
            return await base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken);
        }

        private void ReplaceTenantIdPlaceholders()
        {
            var addedMultiTenantEntities = ChangeTracker.Entries().
                Where(e => e.State == EntityState.Added).
                Where(e => e.Metadata.IsMultiTenant()).ToList();

            // ensure tenant context is valid
            if (addedMultiTenantEntities.Count > 0 && TenantInfo == null)
            {
                throw new MultiTenantException("MultiTenant Entity cannot be changed if TenantInfo is null.");
            }

            var mismatchedAdded = addedMultiTenantEntities.
                Where(e => (string?)e.Property("TenantId").CurrentValue == MultiTenantEntity.TenantIdPlaceholder &&
                           (string?)e.Property("TenantId").CurrentValue != TenantInfo!.Id).ToList();

            foreach (var e in mismatchedAdded)
            {
                e.Property("TenantId").CurrentValue = TenantInfo!.Id;
            }
        }

In your entity
    public const string TenantIdPlaceholder = "THIS_VALUE_GETS_REPLACED_BY_FINBUCKLE";

    // ReSharper disable once UnusedMember.Global
    public string TenantId { get; set; } = TenantIdPlaceholder;


Colors in SplitButton sample don't always work as expected

Describe the bug

Steps to reproduce the bug

Steps to reproduce the behavior:

Go to SplitButton page
Type some text (e.g. "This text is black.")
Select a subset of the text (e.g. the word "text") and choose red from the SplitButton flyout
Click at the end of the text and type a few more characters

Expected behavior

The new characters will be red
Actual behavior

The new characters are still black like the older text
Screenshots

Version Info

Gallery version (found on Settings page):
<IP_ADDRESS>
Windows 10 version:

[x] Insider Build (xxxxx)
[ ] May 2019 Update (18362)
[ ] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[x] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Additional context

This behavior also applies to the RichEditBox custom editor sample where the color is not applied when we click anywhere in the text and type.


include(${wxWidgets_USE_FILE}) lost the information in a subproject

Hi, I am very new to hunter but fascinated from it.
Actually I get an error:
the include(${wxWidgets_USE_FILE}) works in the main project
but gets "empty" value in a libraries, which are added with "add_subdirectory" and are small projects.
Any idea?

I'm not sure I understand what is the issue. Can you check that your example is similar to one in wiki page:

https://github.com/ruslo/hunter/wiki/pkg.wxwidgets

Not exact.
For Project 1 and Project 2 it works, but it seems somehow in Lib1 and Lib2 etc. the information for the wxwidgets get losts. The Structure is so:
Directory Structure - all Projects in one solution
Project1
Project2
Libs
Libs/Lib1
Libs/Lib2
#Main folder:
CMakeLists.txt
include("cmake/HunterGate.cmake")
HunterGate(
URL "https://github.com/ruslo/hunter/archive/v0.10.9.tar.gz"
SHA1 "53b198e364dc7bc8360fc545f798563229bd7e20"
)
PROJECT(Main_Solution)
hunter_add_package(wxWidgets)
find_package(wxWidgets REQUIRED core base xrc xml ribbon propgrid)
ADD_SUBDIRECTORY( Project1)
ADD_SUBDIRECTORY( Project2 )
ADD_SUBDIRECTORY( Libs)
#Subdirectory Project1
CMakeLists.txt
PROJECT( Project1 )
include(${wxWidgets_USE_FILE})
...
INCLUDE_DIRECTORIES(
${PROJECT_SOURCE_DIR}/src
${wxWidgets_INCLUDE_DIRS}
)
...
#Subdiretory Libs
CMakeLists.txt
ADD_SUBDIRECTORY(Lib1)
ADD_SUBDIRECTORY(Lib2)
Subdiretory Lib1
CMakeLists.txt
PROJECT(Lib1)
include(${wxWidgets_USE_FILE})
...
INCLUDE_DIRECTORIES(
${PROJECT_SOURCE_DIR}/src
${wxWidgets_INCLUDE_DIRS}
)

Don't see any issues related to Hunter.

:-) sure,
but without hunter the structure works, it means the projects in the libs have the correct include folders of the wxWidgets. With the hunter - only for the proects this works, in the libs somehow get lost.
My question is if hunter does not "resets" some variables or if I have to add some "hunter_" commands within the add_subdirectory issues.

I haven't used this package and have no idea about all aspects how it works, the only things I know that custom Find*.cmake module called by Hunter is here:

https://github.com/ruslo/hunter/blob/master/cmake/find/FindwxWidgets.cmake

My question is if hunter does not "resets" some variables

Hunter does reset some variables at the start of the work in some cases, but it happens only on start and there is no "magic" hooks at the enter of every subdirectory.

if I have to add some "hunter_" commands within the add_subdirectory issues

The only command user need to call is hunter_add_package

Solution found. The problem seems to be connected with the understanding of the linker process of several libraries - how the single libraries are compiled and linked.
After adding
${wxWidgets_LIBRARIES}
in the TARGET_LINK_LIBRARIES block of CMakeLists.txt
the include folder for wxWidgets appears in the projects for the libraries, too.
So it seems that CMAKE checks, which sources are included as library and include these in the "include folders" only if they are presented as well in the Link_Libraries
So for the wiki - do not forget to add linking to wxWidgets for the "small sublibraries"
TARGET_LINK_LIBRARIES(source
${wxWidgets_LIBRARIES}
)
Why this works in the same project structure with cmake but without hunter is not clear for me, but that is not so bad now.

So for the wiki - do not forget to add linking to wxWidgets for the "small sublibraries"

As far as I understand this is exactly what current version of wiki page saying:

https://github.com/ruslo/hunter/wiki/pkg.wxwidgets

So it seems that CMAKE checks, which sources are included as library and include these in the "include folders" only if they are presented as well in the Link_Libraries

Check the values of wxWidgets_USE_FILE and wxWidgets_LIBRARIES variables. Seems that Hunter version use imported targets for relocation reason and "normal" version use full paths (which is not relocatable). In both cases same name for variables used for compatibility reason.


[doc] Update the way to modify Android minSdkVersion in README

Flutter v2.8+ uses android/local.properties
See https://docs.flutter.dev/deployment/android#updating-the-apps-version-number (not really, but well...)
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Sorry, I am not used to this repo. Not sure of which branch to merge against

Thanks for the submission!
In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.
I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

In the future, please do not delete the checklist that is in the PR template; it is there for a reason.

Sorry about that. I'm used to unecessary lists.
I'll fill the list later.
Thanks!

@millerf Thanks for your contribution! Is this PR still on your radar?

@millerf Thanks for your contribution! Is this PR still on your radar?

Sorry I totally forgot about it.
I can have a look tonight...

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!


Enable Docker CS + Experimental mode

This change enables the installation of Docker CS as documented in https://docs.docker.com/cs-engine/1.13/, together with experimental flag to enable service logs and metrics

@kbhattmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Can one of the admins verify this patch?

@kbhattmsft We have made changes to the acs-engine repo, where we have removed test comparison with the expected files. Please pull the latest changes and resubmit.

Closing this pull request as there has been no activity or updates on this. And Swarm Mode is using the latest version of Docker Engine. Please create a new PR if these changes are still needed.


Use respective - update out of date version instructions(Windows, Linux, MacOS)

Current message states:
warning: your version of azd is out of date, you have 0.6.0-beta.1 and the latest version is 0.7.0-beta.1

To update to the latest version, run:
powershell -ex AllSigned -c "Invoke-RestMethod 'https://aka.ms/install-azd.ps1' | Invoke-Expression"

Installed azd using winget, should option for Windows be?
To update to the latest version, run:
winget upgrade Microsoft.Azd

@savannahostrowski -- After further consulting with Heath about this we're going to link out to https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/install-azd via an aka.ms link and let the user upgrade.
On Windows: it's possible for the user to install in a variety of ways and "package managers" (like winget, choco, etc.) don't do a great job of tracking state here. On Windows we should just download the MSI and run the upgrade ourselves replicating the params used to install the MSI.
On Mac: We can do some detection on whether the package was installed using brew but if the package was installed via a script with custom arguments we don't have an easy way of tracking that state so commands involving "run this script" could be misleading.
Linux: Similar problem with knowing the arguments used in the original install script... though upgrading .deb and .rpm packages may be more straightforward.
cc @rajeshkamal5050


Disable cache warmer if no RPC/STS uses it.

Problem
The tpu cache is only used by STS started by RPC service. If no RPC service is enabled, no need to start the cache warmer. Which is having unnecessary load on the leaders.
Summary of Changes
Start the cache warmer conditionally.
This is built upon https://github.com/anza-xyz/agave/pull/878.
Fixes #

Codecov Report
Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (f121f73) to head (25299f8).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #938     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%
=========================================
  Files         853      853
  Lines      231779   231819     +40
=========================================
+ Hits       189829   189861     +32
- Misses      41950    41958      +8


[HxTooltip, HxPopover] Allow passing Container parameter as ElementReference

https://getbootstrap.com/docs/5.3/components/tooltips/#options
Options allow element type for container parameter.
I think we should implement one new parameter - ContainerElement of type ElementReference. Either Container or ContainerElement parameter can be set, but not both at the same time.
This would allow us to implement a pattern where we render tooltip body inside its trigger element. This would hopefully make the tooltip visible when we hover inside it.

For these super-rare scenarios, I prefer to allow the #elementId pattern to be passed to the string Container parameter value (and resolve the element inside our JS for this pattern) instead of adding a new parameter.
I think we've already used this pattern somewhere.

Well, it seems Bootstrap itself does some basic container resolution:
https://github.com/twbs/bootstrap/blob/e20cc0d660f72c12befbfcbe90eef2aa39655c48/js/src/tooltip.js#L559
https://github.com/twbs/bootstrap/blob/e20cc0d660f72c12befbfcbe90eef2aa39655c48/js/src/util/index.js#L86-L97
...which means we don't need to. :-D


The pwsh terminal display incorrectlly when installed starship

Does this issue occur when all extensions are disabled?: Yes
When installing starship，commad in pwsh terminal always displays an extra first letter on start of the line，while the command executed is right.

After tested, when I enable the os option for starship config, the pwsh terminal display incorrectlly.
[os]
disabled = false

However I know't think it is a problem of starship. Because everything is ok in windows terminal pwsh and the historical vscode version.

VS Code Version:

Version: 1.87.2 (user setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631

OS Version:

windows11  10.0.22631.3155

starship Version:

starship 1.17.1
branch:master
commit_hash:
build_time:2024-01-02 18:35:11 +00:00
build_env:rustc 1.75.0 (82e1608df 2023-12-21),stable-x86_64-pc-windows-msvc

This is because of the windows symbol you added to the front, removing that should fix it. We're currently discussing a related issue in https://github.com/xtermjs/xterm.js/issues/4969
/duplicate


[Feature Request]: Volume Setting

Choose the extension for feature request.
Full Screen Mode
📝 Provide a description of the new feature
Add the option to set the volume in full screen mode.
➕ Additional Information
No response

Added in v2.0.0.


ability to vf create?

it would be nice if I didn't have to remember the virtualenv commands.
I'd like to be able to go vf create chatbot instead of having to run
mkvirtualenv chatbot; and vf connect.
Just a small thing that could be cool if you were interested.

Hi David. You don't have to know any virtualenv commands, much less mkvirtualenv commands.
If you don't mind my asking, have you read the documentation? I only ask because the answer to your query is in step 4 of the README's quick-start section, as well as the very first entry in the Usage section of the docs.

Hi!
So, putting aside the use or otherwise of VIRTUALENV_COMPAT_ALIASES, am I right in saying that what you're looking for is a way to do vf new and vf connect in one command?
To me this sounds like a good idea, although I'm strongly against calling it vf create because it wouldn't be clear what makes it different from vf new.
My preferred solution to this would be to add a --connect flag to vf new, but that would depend on #71.

I've just now noticed that I've already added a ticket for this! Closing as a dupe of #118.


PPI-203 : deprecate context manager and implement attach/detach APIs

Which problem is this PR solving?
Fixes #185
The current context API is unnecessarily complex and does not support the attach/detach optional APIs.
In async programming, the attach/detach APIs can be incredibly handy in passing context to async processes that cannot propagate context manually (most likely due to public or otherwise unbreakable APIs). Zones can help in this case, but do not always suffice since zones might not appropriately follow code execution. Specifically, if a process includes putting an event on a stream/sink where that event is consumed by a stream listener, the zone does not propagate from where the event was placed on the stream/sink to the stream listener's callback.
Short description of the change
The current context implementation requires a modifiable concrete implementation used to decide how to propagate context. This is an adaption to OpenTelemetry JavaScript's implementation.
However, unlike JavaScript, zones are a language native feature: its type and implementation provided by the standard library. Therefore it is okay to assume that zones are available and thus simplify the context propagation story as compared to OpenTelemetry JavaScript.
A potential solution to this end would be to replace the abstract Context with the concrete ZoneContext. This solution was avoided because ZoneContext presumes that zone values are what carries the context. This means that manual propagation would be passing around the zone itself (or rather the contrived wrapper of the zone).
Instead, the changes make Context its own immutable propagation context. This allows a zone, also an immutable propagation context, to hold both a stack of versions (due to multiple calls to attach) or a specific version (when binding a version to a zone for zone execution).
tl;dr; Context is a stack implemented as a linked list. Cross-cutting APIs allow stacking the stack (attach/detach) on a zone, or binding a specific version (linked list node) to a zone.
Zone zoneWithContext(Context context) -> binds a specific version to a fork of the current zone
ContextToken attach(Context context) -> stacks a specific version to the current zone
With the new APIs, retrieving the active context follows a hierarchy:

active attached context
active zone context
root context

Starting a span is the same: a manually specified context is used if given and the active context is used otherwise. The changed part is that the active context might be an attached context.
How Has This Been Tested?
The provided example and unit tests demonstrates functionality. Additional testing will be carried out by consuming the changes in various test applications.
Checklist:

[x] Unit tests have been added
[x] Documentation has been updated

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

closing in favor of https://github.com/Workiva/opentelemetry-dart/pull/196


[53] rupture generation integration test

implements #53 as discussed

@voj - looks like we'll need a minor tweak to run this with travis?


Expose LG's sleep mode function

Enable sleep mode for LG's AC devices
This PR exposes sleep timer as a switch. This mode reduces energy consumption and fan noise, it also introduces some automatic adjustments
Detailed explanations from LG's user manual:

In the Cooling and Dehumidification Mode, the
temperature increases by 1 °C after 30 minutes
and additional 1 °C after another 30 minutes for a
more comfortable sleep.

The temperature increases up to 2 °C from the
preset temperature.

Although the remark for fan speed on the display
screen may be changed, the fan speed is adjusted
automatically.

Use case
In a hot night we can setup an script/automation which will balance conform and energy consumption

Enable jet mode for X minutes or until temperature reaches Y degrees
Then, change to cool/dry mode for certain amount of time or until temperate reaches lower threshold
Finally, enable "sleep mode" for the rest of the night.

Why is better that automations or auto mode?
The first two steps are doable with current H-A capabilities but the third, in my experience, can't be reproducible with any combination of fan speeds or temperature. Also, LG's devices beeps each time a settings is changed. Changing settings in the middle of the night via some automations can result in a orchestra of beepings. LG's sleep mode doesn't have this problem.
Further work
This PR is presented as first approach to integrate sleep mode.
Currently it's exposed as a switch. When enabled, this mode is activated with a 7 hours timer. After 7 hours it goes back to off.
Further discussion and work should determine other behavior as:

it's the 'switch' control the right interface?
should the timer be autoreset before it goes to 0?
should be the default timer 7 hours?

Previous discussions:

https://github.com/ollo69/ha-smartthinq-sensors/issues/569
https://github.com/ollo69/ha-smartthinq-sensors/issues/573
https://github.com/ollo69/ha-smartthinq-sensors/issues/182
https://github.com/ollo69/ha-smartthinq-sensors/issues/524

it's the 'switch' control the right interface?

My opinion is that this should be implemented as a service with a parameter to set the duration.
A sensor can be used to identify if the function is enabled.

it's the 'switch' control the right interface?

My opinion is that this should be implemented as a service with a parameter to set the duration. A sensor can be used to identify if the function is enabled.

@ollo69, done
services are not my best skill but I based my code on your existing ones.

@ldotlopez,
I did some changes on the logic used to control if status is available, range used to call the service and service availability.
I also rebased branch with master.
Please check if everything look fine for you and ask if something is not clear,
If ok I think we can merge.
Thanks.👍

It's OK for me.
Thanks 👍

I've been looking forward to the sleep mode, but it looks like this does not work correctly on my device (LG I38TKF - 3 ton, split inverter) - I can't see the switch entity for the sleep mode. Moreover since 33.3 the jet mode switch is now shown as unavailable - might be related?
It does properly expose the entity _sensor.sleep_time . Is there any specific procedure to reload all entities to recognize/expose/identify the new switch? (besides removing and adding again?).

Is there any specific procedure to reload all entities to recognize/expose/identify the new switch? (besides removing and adding again?).

I tried re-enrolling a new account on another HA instance with latest SmartThinQ LGE Sensors integration (0.33.3) and the problem is the same - the device is controllable, but the sleep button is still not discovered (sleep_time is there and it is properly reporting when sleep mode is initiated from the app).
Can I share any logs with devs? Maybe this could help fixing this bug?

Hi @gitmarecki
You should file an issue for better tracking.
However, I can only talk about sleep mode which is the feature I developed: there is not sleep button, you should call the smartthinq_sensors.set_sleep_time service to start sleep mode.

how did I miss that? :D It works! THANK YOU! where's the buy-me-a-coffee button? :-D


x-go-custom-tag tag not taken into account in some cases since 0.26.0

Problem statement
x-go-custom-tag tag is no longer taken into account for a property.

In this particular use case, I understand that this is a problem, though ...

 properties:
      test:
        $ref:  '#/definitions/MyType'
        description: blah blah blah
        x-go-custom-tag: db:"test"

This is because we are now stricter on the jsonschema spec that is "every sibling to a $ref" is ignored.
In this particular use case, I understand that this is a problem, though ...

The only way we could solve this recurring use case is to add some "Annotations" field to spec.Ref, with extensions. At least this piece of information wouldn't be lost during unmarshaling/marshaling and the swagger codegen would have the opportunity to check for extensions in this block

The only way we could solve this recurring use case is to add some "Annotations" field to spec.Ref, with extensions. At least this piece of information wouldn't be lost during unmarshaling/marshaling and the swagger codegen would have the opportunity to check for extensions in this block

This is because we are now stricter on the jsonschema spec that is "every sibling to a $ref" is ignored.

But description is not ignored here, that is why it is a bit weird...

This is because we are now stricter on the jsonschema spec that is "every sibling to a $ref" is ignored.

But description is not ignored here, that is why it is a bit weird...

Setting:
  MyType:
    type: array
    items:
      type: string
    x-go-custom-tag: db:"test"

works, but admit it is not obvious... IMHO MyType should not carry the custom tag of a field using it.

Setting:
  MyType:
    type: array
    items:
      type: string
    x-go-custom-tag: db:"test"

works, but admit it is not obvious... IMHO MyType should not carry the custom tag of a field using it.

How would it work for the ones that are not type: array


AAD joined devices and 3rd party CA (key trust)

This page mentions Accessing on-premises resources from an Azure AD Joined device does require special configuration when using a third-party CA to issue domain controller certificates, and then refers to another page about smart card logon with 3rd party CAs.
Can someone please explain what the additional requirements are that are not covered by Configure domain controller certificates and Requirements for domain controller certificates from a third-party CA ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1f64c6e7-4002-fe69-b8a0-aa3539949ee6
Version Independent ID: 3e71c3a7-6654-d31a-37eb-7cc84d0b8a72
Content: Windows Hello for Business known deployment issues - Windows Security
Content Source: windows/security/identity-protection/hello-for-business/hello-deployment-issues.md
Product: windows-client
Technology: itpro-security
GitHub Login: @paolomatarazzo
Microsoft Alias: paoloma

Hello @LijuV-MSFT and thank you for the feedback. As we discussed offline, please follow up with Support to determine the accuracy of the statement and feel free to reopen the issue once we get more clarity about this scenario. Much appreciated!


Update operations-and-monitoring.md

Updated the section Device Groups, to add the link to the new feature and update responsibilities for both Microsoft and customer.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@jaimeo FYI.

@jaimeo Please merge this PR. Thanks

Thank you. FYI @jaimeo .

@JohanFreelancer9 that is not the correct link format for links between articles in the same repo. I've corrected it.


Channel argument for read_binary

There is currently no usage of the channel argument in read_correlators_binary and I'm not actually sure how I would introduce that, so I've removed it. It slightly undermines the consistency with read_correlators_fortran but I don't quite see how it is supposed to be used there either. Feel free to make an argument against this or close this issue if you agree.

Another stub of part of a feature, sorry. The intent is that if you have multiple files, each containing a single channel (e.g. A++, E++, T++), then you could specify this and then concatenate the CorrelatorEnsembles to give a single one with a channel column that could then be filtered on to get a given channel to process. (E.g. get_pyerrors would then take a channel argument.) This would allow equivalence with a file format that stores all channels in a single file.
Since nothing currently does that in the glueball space (guess which code does?), and it's probably easier to just create a separate CorrelatorEnsemble for each state that we read in, then this can likely be dropped for now.

Yes, I'm aware of this. I meant more concretely how would you possibly handle such an argument for stuff that is read from a binary? You would need some way to specify which parts of the binary contain which channel and that sounds like a highly non-trivial interface to me. Adding that info after the fact seems way easier. Anyhow, happy that we agree on removing it (for the moment at least).

Oh, I see, I would anticipate that either

each binary only contains a single channel, and you would do something like CorrelatorEnsemble.concat([read_binary(f"corr_{channel}.bin", channel=channel) for channel in channels]), or
the binary contains all channels indexed in some deterministic way, in which case the channel argument would be removed and instead there would be a list of channel names in the specific implementation (which would then have to go record-by-record through the file), or perhaps
the binary contains all channels, with a record immediately before each's record with a single string containing the channel name. (At which point, you surgically obliterate the section of code writing that format and look up how to write HDF5 in Fortran.)

... or in other words: "a highly non-trivial interface".


Container Instantiation Flow

How do you make a new container with prebuilt data objects in it?

@ChumpChief, perhaps this is more relevant?

@ChumpChief, perhaps this is more relevant?


UnusedPrivateProperty does not detect unused property named "logger"

Expected Behavior
detekt should find unused properties for which no exception is defined.
Observed Behavior
detekt does not find unused properties named "logger".
Steps to Reproduce

Context
The documentation statesthe default allowed values are: allowedNames (default: '_|ignored|expected|serialVersionUID') - "logger" is not listed here.
We also have no exceptions in our config for that rule defined:
---
build:
  weights:
    LongParameterList: 0
    TooManyFunctions: 0

complexity:
  excludes: ["**/test/**"]

formatting:
  MaximumLineLength:
    excludes: ["**/test/**"]
  NoWildcardImports:
    active: false
  TrailingCommaOnCallSite:
    active: true
  TrailingCommaOnDeclarationSite:
    active: true

naming:
  FunctionParameterNaming:
    excludes: ["**/test/**"]
  ClassNaming:
    excludes: ["**/test/**"]
  MemberNameEqualsClassName:
    active: false

style:
  MaxLineLength:
    excludes: ["**/test/**"]
  WildcardImport:
    active: false
  SerialVersionUIDInSerializableClass:
    active: false

config:
  validation: true

Your Environment

Version of detekt used: 1.23.5
Version of Gradle used (if applicable):

Gradle 8.6
Build time:   2024-02-02 16:47:16 UTC
Revision:     d55c486870a0dc6f6278f53d21381396d0741c6e
Kotlin:       1.9.20
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          17.0.10 (Private Build 17.0.10+7-Ubuntu-122.04.1)
OS:           Linux 6.5.0-28-generic amd64

Hi,
sorry for the late answer, one of my Outlook filters has eaten up the notification.
I've tried to run 'detektMain' wich gave me a lot of new findings but the unused logger property was still ignored.
Then I tried to assign the value '2' to logger, like in your test. That was found by both, the 'detekt' and the 'detektMain' task.
After that, I tried to assing 'private val logger = Logger.getLogger("foo")' and that was also found.
It must have something to do with the 'KotlinLogging.logger {}'.

Hi @Chris-Goetz I tried below TCs
@Test
fun `#7222 1`() {
    val code = """
        interface KLogger
        object KotlinLogging {
            fun logger(func: () -> Unit): KLogger = TODO()
        }

        private val logger = KotlinLogging.logger {}
    """.trimIndent()
    assertThat(subject.lintWithContext(env, code)).hasSize(1)
}

@Test
fun `#7222 2`() {
    val code = """
        interface KLogger
        object KotlinLogging {
            fun logger(func: () -> Unit): KLogger = TODO()
        }

        private val logger = KotlinLogging.logger {}
        private val something = KotlinLogging.logger {}
    """.trimIndent()
    assertThat(subject.lintWithContext(env, code)).hasSize(2)
}

and it is still running fine.
Also rule UnusedPrivateProperty required type resolution which means it will only work correctly when detektMain is used(NOT detekt).
Can you see from the TC is something is still missing here?

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.


Fixing increased visibility issue(497).

Fixing issue 497.
Notes about changes:

I've changed the mockery_getMethods method in the Mock class.
The method now doesn't treat prototypes, it just lists the reflection methods of the current class.
If there's a real reason for treating prototype methods, it's not being covered by the tests.
I've changed the description of  an exception thrown when trying to mock a protected method, it's an attempt to be more accurate. Change can be seen in the Mock.php file, at line 207.
I've removed unused commented code from Mock and MockInterface source.

Coverage increased (+0.3%) to 74.118% when pulling 9e3d13e1fddc94de3a7db1cc329f2f741e66d32b on TiagoMaiaL:master into 64d0c313c5fa6db3c113f577b47da45a0591ef4e on padraic:master.

Coverage increased (+0.3%) to 74.131% when pulling 9e3d13e1fddc94de3a7db1cc329f2f741e66d32b on TiagoMaiaL:master into 64d0c313c5fa6db3c113f577b47da45a0591ef4e on padraic:master.

I imagine the getPrototype is something to do with abstract classes, will do some digging when I get chance to make sure we aren't regressing something there.

Ok, if we're indeed regressing something, I can write a test that covers the code using this prototype in the expected way, so we could prevent this regression in the future. Also, if the regression is happening,  I could also solve the problem in another way. So, when it becomes possible for you, please, let me know about the results.

Coverage increased (+0.4%) to 74.211% when pulling b6116e8ad4d366bed29d65c221594a7c710190bd on TiagoMaiaL:master into 64d0c313c5fa6db3c113f577b47da45a0591ef4e on padraic:master.

Coverage increased (+0.4%) to 74.211% when pulling 66efb7b156260979b5f0f20fd3fc9bbaaddca2f5 on TiagoMaiaL:master into f9c911059ec3d9216758fbaa6b8983a71e07a64e on padraic:master.

Coverage increased (+0.4%) to 74.211% when pulling e9ca7ff676916a293056b0b5ec4875d2caecc9f9 on TiagoMaiaL:master into 590b1e1711d4d813d3ae164487050ac4626b3bba on padraic:master.

Thanks! I think the _mockery_handleMethodCall method already handles the abstract thing I mentioned.

Nice! Thanks.


Update about-change-data-capture-sql-server.md

adding details about the sp's and views that can be used to cleanup and monitor replication. can someone check the links I wasn't sure if they were pathed correctly

@jasonhorner : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@jasonhorner Thanks for this suggested change. I am going to run this by some people internally before publishing. Thanks for your patience.

@jasonhorner Thanks, again, for this change. I am going to try to make a minor edit to your suggestion and to resolve the merge conflict. + @assign:MaraSteiu FYI

The following users don't have valid GitHub IDs, or are not collaborators on this repo: marasteiu fyi

@rothja : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jasonhorner I was having trouble making all the necessary changes here to publish, so I am pushing your commits on our private repo and it should publish soon from there. I am closing this PR, but your changes will publish and you should be listed as a collaborate on the article when it does. Thanks!


Changes the loading of kafka cacert from clowder

Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[x] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

https://github.com/RedHatInsights/app-common-python now has LoadedConfig.kafka_ca()

Codecov Report
Base: 50.14% // Head: 74.55% // Increases project coverage by +24.41% :tada:

Coverage data is based on head (09f95bd) compared to base (209c0c9).
Patch coverage: 70.28% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #258       +/-   ##
===========================================
+ Coverage   50.14%   74.55%   +24.41%
===========================================
  Files          13       25       +12
  Lines         357      723      +366
===========================================
+ Hits          179      539      +360
- Misses        178      184        +6

Impacted Files
Coverage Δ

clean_expired_records.py
0.00% <0.00%> (ø)

historical_system_profiles/mgmt_views/v0.py
100.00% <ø> (ø)

kafka_listener.py
0.00% <0.00%> (ø)

standalone_flask_server.py
0.00% <ø> (ø)

wsgi.py
0.00% <ø> (ø)

..._system_profiles/notification_service_interface.py
35.00% <35.00%> (ø)

...ical_system_profiles/baseline_service_interface.py
39.13% <39.13%> (ø)

historical_system_profiles/archiver.py
55.05% <54.41%> (+55.05%)
:arrow_up:

...torical_system_profiles/drift_service_interface.py
66.66% <66.66%> (ø)

historical_system_profiles/probes.py
66.66% <66.66%> (ø)

... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

https://ci.ext.devshift.net/job/RedHatInsights-historical-system-profiles-backend-pr-check/291/console is CI run in default pool, https://ci.ext.devshift.net/job/RedHatInsights-historical-system-profiles-backend-pr-check/292/console is CI run in real-managed-kafka pool.... both passed.
Note that this PR changes pr_check.sh (or hsp_deploy_ephemeral_env.sh to be precise) to use real-managed-kafka for deployment.

https://issues.redhat.com/browse/DRFT-1183
https://issues.redhat.com/browse/RHCLOUD-20005


The "arc42-docu" button in the header is not working

Just fyi, the link does not work

Is this the button which should point to the arc42 docs generated with doctoolchain? Then let me have a look

frankly, I'm currently not sure what the intention of these buttons were.
Having a link to the (automatically generated) doctoolchain-based arc42-documentation would be nice, but then we should rename the button too...


[GSSoC'23] Automate github operations

Aim

What is the objective of the Script

Automate all the commands of the github using python script.

Details

What the features will your script have

Staged <-> Unstaged files in one go using python script.
Commits all the files.
Reverse last commit.
push all the files using python script, etc.

Do I want to work on this:

[x]  Yes

@avinashkranjan @vanshitaverma @omazoz please assign this task to me

Go Ahead @Avdhesh-Varshney


Using vedo with PySimpleGUI

I have looked through the vedo docs and have not found a way to do this, so I wanted to ask here in case I am missing something. It seems like integration with any kind of GUI for Plotters in vedo is only supported through the qt_widget argument option, as demonstrated in examples/other/qt_window2.py. However, for my project I am using PySimpleGUI, which generally relies on tkinter in the backend. I found a relevant issue on the PySimpleGUI Github, where they discuss how a Canvas element would be a good potential solution, and that vedo would need to be the one to provide some kind of accessible output product for embedding. Is there any way to extract an element from vedo or pass in arguments for which figure/axes to plot onto that could be integrated into other GUI options?
It also seems like other GUI options like streamlit (mentioned in #588 ) are of interest, including potentially website-focused GUI options.

Just want to add my support for this feature! We use both streamlit and vedo for neuroscience visualisation software, and would absolutely love to see an integration where we can embed a vedo plot inside a streamlit app!


Fail to load bullet-native

The required native library 'bulletjme' was not found in the classpath via 'native/linux/x86_64/libbulletjme.so'. Error message: no bulletjme in java.library.path: [/usr/java/packages/lib, /usr/lib/x86_64-linux-gnu/jni, /lib/x86_64-linux-gnu, /usr/lib/x86_64-linux-gnu, /usr/lib/jni, /lib, /usr/lib]

Not sure what is wrong there again, but I am short of reverting netbeans 11 and stick with java 8 and netbeans 8.2. The engine itself doesn't use anything other than 8 anyway

Fixed in https://github.com/jMonkeyEngine/jmonkeyengine/pull/1255

So: This was a build error and it has been fixed and merged into master, not cherry picked into 3.3, but I think 70626cd22cf976b66dfaec534768882c5d73b855 solved that.


pformat calling <

Perhaps unrelated, perhaps not, but another repr error:
from gpkit.shortcuts import *
from numpy import ones

N = 6
L = 5.
dx = L/(N-1)

EI = Var("EI",10)

P = 100
p = Vec(N, "p", descr="Distributed load")
p = p.sub(p, P*ones(N))

V  = Vec(N, "V", label="Internal shear")
M  = Vec(N, "M", label="Internal moment")
th = Vec(N, "th", label="Slope")
w  = Vec(N, "w", label="Displacement")

eps = 1E-6 #something small

substitutions = {var: eps for var in [V[-1], M[-1], th[0], w[0]]}

objective = w[-1]

constraints = [EI*V.left[1:N]     >= EI*V[1:N]    + 0.5*dx*p.left[1:N]     + 0.5*dx*p[1:N],
               EI*M.left[1:N]     >= EI*M[1:N]    + 0.5*dx*V.left[1:N]     + 0.5*dx*V[1:N],
               EI*th.right[0:N-1] >= EI*th[0:N-1] + 0.5*dx*M.right[0:N-1]  + 0.5*dx*M[0:N-1],
               EI*w.right[0:N-1]  >= EI*w[0:N-1]  + 0.5*dx*th.right[0:N-1] + 0.5*dx*th[0:N-1]]

m = Model(objective, constraints, substitutions)

This code doesn't generate an error on its own, but
In [2]: m
Out[2]: <repr(<gpkit.model.Model at 0x10441d090>) failed: TypeError: unsupported operand types for <: 'Variable' and 'Variable'>

hmph, pformat is definitely calling <. Did we agree on a path to resolving this in person?
Why was it working before?

< works for VarKeys, just not for variables; it's now sorting an uncoerced substitutions list

Ok, so perhaps the fix is to standardize coercion to VarKeys -- I have a note to work on that already.
Can get to that after we get unit tests on #360 working.

Another related case(?), this time with >:
In [1]: pwd
Out[1]: u'/Users/philippekirschen/Documents/MIT/Research/GPkit/gpkit/docs/source/examples'

In [2]: from beam import beam

In [3]: beam(10)
Out[3]: <repr(<gpkit.model.Model at 0x1059c0890>) failed: TypeError: unsupported operand types for >: 'Variable' and 'VarKey'>

Same issue; Variables don't support < or >

Should we just not call pformat on the list of subs? That would resolve this.
Another approach -- we already have NomialData._get_varkeys, but that would mean we need a way to get the NomialData corresponding to a given Model (perhaps we want that)?

Good point, we should just use a different sort key

more details? I didn't follow. (my last message above was two different options -- @bqpd do you support one of them?)

Oops, yep, the first.


Introducing support to Travis-CI

Description:
This PR introduces support to Home Assistant to monitor the result of a test build performed by Travis-CI.
Basically this platform will allow to monitor the following conditions:

state of a given branch
Last build state
started time from the last build
elapsed time from the last build
finished time from the last build
last build ID

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#3519

Example entry for configuration.yaml (if applicable):
- platform: travisci
  github_token: !secret travisci_github_token
  scan_interval: 30
  default_branch: master
  repository_names:
    - raincloudy
    - home-assistant

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[x] New dependencies are only imported inside functions that use them ([example][ex-import]).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Thanks for your help and code review @pvizeli

Once the release branch is create I try only to add fixes. Otherwise there will never be an end :wink:

@fabaff it's ok. next release then. Thanks for merging it.


New version: Bitwarden.CLI version 2024.6.1

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-02 14:15:09.398 [FAIL] Installer failed security check. Url: https://github.com/bitwarden/clients/releases/download/cli-v2024.6.1/bw-windows-2024.6.1.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

/azp run

/azp run

/azp run


bugfix: skip write index.json if no data is wrote.

What does this PR do?
Skip creating index.json for processes that do not write data.
Fixes #19438

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ yes ] Is this pull request ready for review? (if not, please submit in draft mode)
[ yes  ] Check that all items from Before submitting are resolved
[ yes ] Make sure the title is self-explanatory and the description concisely explains the PR
[ yes ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19439.org.readthedocs.build/en/19439/

Hey @cauyxy Thanks for your contribution!
The index.json file is used to detect whether a given worker has finished its work. This needs to be written down even if the file is empty for the other processes to understand how the workers are done.
This is particularly important when doing multi-node data processing.

Hey @cauyxy Thanks for your contribution!
Would you mind adding a test after verifying the test breaks using master? Especially one emulated multiple nodes. If you get blocked, I can help there.
BTW, what's your interest in Lightning Data? I am quite curious as you are the first community contributor ;)

Sorry, I'm not very familiar with adding tests, and it might take me some time to do it myself. If you could help with that, it would be great!
I've been experimenting with training some small language models and have used the Lightning framework. For the data part, I primarily utilized StreamingDataset, which I found very convenient and it solved many of my problems. Thank you for your great work.
The code looks very neat, which is extremely pleasing for someone like me who has a strong preference for clean code!🥰

Hey @cauyxy, this is kind. Thank you.
For LLM, we are a couple of Studios I built to display how to best use Lightning Data:

Benchmark cloud data-loading libraries
Prepare the TinyLlama 1T token dataset
Pretrain LLMs - TinyLlama 1.1B

Studios are fully reproducible cloud environments with data, code, dependencies, etc... Give it a spin ;)

Sorry, I'm not very familiar with adding tests
This is entirely fine. Do you think you could provide a reproducible dummy python script that triggers the error? This is usually the first step to build a test. Same for the other error ;)

@tchaton Sure, I can give it a try. I don't have access to Studio right now, but I can set it up locally.

Hey @cauyxy, this is kind. Thank you.
For LLM, we are a couple of Studios I built to display how to best use Lightning Data:

Benchmark cloud data-loading libraries
Prepare the TinyLlama 1T token dataset
Pretrain LLMs - TinyLlama 1.1B

Studios are fully reproducible cloud environments with data, code, dependencies, etc... Give it a spin ;)

Sorry, I'm not very familiar with adding tests

This is entirely fine. Do you think you could provide a reproducible dummy python script that triggers the error? This is usually the first step to build a test. Same for the other error ;)

this dummy script can trigger pdb.
Env: Linux python3.9
import os
import time
import json
import torch
from pathlib import Path

from lightning.pytorch.utilities.imports import RequirementCache
from lightning.data.streaming import DataChunkRecipe, DataProcessor

assert os.cpu_count() > 1, "cpu count should be greater than 1"
assert RequirementCache("lightning==2.2.0"), "Please use lightning==2.2.0"
assert RequirementCache("lightning_cloud==0.5.64")

base_dir = Path(os.path.dirname(__file__))

def prepare_data():
    data_dir = base_dir / "data"
    data_dir.mkdir(parents=True, exist_ok=True)

    with open(data_dir / "dummy.json", "w") as f:
        f.write(json.dumps({"text": "hello world"}))

prepare_data()

class CommonDataRecipe(DataChunkRecipe):
    def prepare_structure(self, input_dir):
        files = Path(input_dir).rglob("*.json")
        return [str(file) for file in files]

    def prepare_item(self, filepath):
        with open(filepath, "r", encoding="utf-8") as f:
            for _ in f:
                yield torch.tensor([0, 1, 2, 3, 4, 5, 6])

def prepare(
    input_dir: str = "data",
    output_dir: str = "processed",
    chunk_size: int = 4,
) -> None:
    data_recipe = CommonDataRecipe(chunk_size=chunk_size)
    data_processor = DataProcessor(
        input_dir=str(input_dir),
        output_dir=str(output_dir),
        num_workers=os.cpu_count(),
        num_downloaders=1,
    )

    start_time = time.time()
    data_processor.run(data_recipe)
    elapsed_time = time.time() - start_time
    print(f"Time taken: {elapsed_time:.2f} seconds")

if __name__ == "__main__":
    import fire

    fire.Fire(prepare)

Hey @cauyxy This is great. Now, you can convert this reproducible script into a test ;) You are almost there.

Done!
You are really a good teacher! haha...😂

@tchaton  Happy Chinese New Year! 🍊🐉🏮🧧


Bugfix/2752 bulk editing removes categories

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest2.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[x] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.
[x] Client: I followed the coding and design guidelines.
[x] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes

Motivation and Context

Fix for #2752 where categories of Programming Exercises are removed when 'bulk updated'.
In addition, the optional 'Notification Text' has been added to the 'Edit selected' modal, which was missing before.
Description

A new Endpoint PUT /programming-exercises/timeline has been implemented to only update the timeline of a Programming Exercise. This fixes the before mentioned issue and improves the performance of the bulk updates.
Steps for Testing

Log in to Artemis
Navigate to Course Administration
Select one or more Programming Exercises containing at least one 'Category'
Click on 'Edit Selected'
Choose a Release and Due date
Click 'Save'
The selected Exercises should now have the new release and due dates and their 'categories' should have remain untouched.

Test Coverage

ProgrammingExerciseResourc.javae 82%
ProgrammingExerciseService.java 92%
programming-exercise-edit-selected.component.ts 87.27%
programming-exercise.service.ts 65.15%
Screenshots

The Edit Selected modal with optional 'notification text field'

Tested on TS3, works as intended. Manual review and later steps are not set for the exercises when you define them but I assume that's intended.

If you can edit those in the client, I would assume that they are also changed in the database

I think I formulated that too complicated. In short: You can activate the Manual Review in a bulk edit (see screenshot), but this does not activate the Manual Review in the exercises.

Tested on TS3, works as intended. Manual review and later steps are not set for the exercises when you define them but I assume that's intended.

If you can edit those in the client, I would assume that they are also changed in the database

I think I formulated that too complicated. In short: You can activate the Manual Review in a bulk edit (see screenshot), but this does not activate the Manual Review in the exercises.

Tested on TS3, works as intended. Manual review and later steps are not set for the exercises when you define them but I assume that's intended.

If you can edit those in the client, I would assume that they are also changed in the database

I think I formulated that too complicated. In short: You can activate the Manual Review in a bulk edit (see screenshot), but this does not activate the Manual Review in the exercises.

You were right :+1:
I was missing the Assessment Type attribute, which indeed did not update correctly.
Thanks for pointing that out :rocket:

Tested on TS3, works as intended. Manual review and later steps are not set for the exercises when you define them but I assume that's intended.

If you can edit those in the client, I would assume that they are also changed in the database

I think I formulated that too complicated. In short: You can activate the Manual Review in a bulk edit (see screenshot), but this does not activate the Manual Review in the exercises.

You were right :+1:
I was missing the Assessment Type attribute, which indeed did not update correctly.
Thanks for pointing that out :rocket:


binance transactions errors

hi guys,
I+m having thsi error when live trading on binance:
Error: binance POST https://api.binance.com/api/v3/order 400 Bad Request {"code":-1100,"msg":"Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(\\.[0-9]{1,20})?$'."} (possible reasons: invalid API keys, bad or old nonce, exchange is down or offline, on maintenance, DDoS protection, rate-limiting)
    at binance.defaultErrorHandler (/home/vitorego/download/zenbot_master/node_modules/ccxt/js/base/Exchange.js:400:15)
    at response.text.then.text (/home/vitorego/download/zenbot_master/node_modules/ccxt/js/base/Exchange.js:413:25)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7) constructor: [Function: ExchangeNotAvailable] }

Binance API is down! unable to call buy, retrying in 20s
[ { size: '0.00280188',
    orig_size: '0.00280188',
    remaining_size: '0.00280188',
    orig_price: '426.96',
    cancel_after: 'day',
    product_id: 'ETH-USDT',
    type: 'limit',
    side: 'buy',
    post_only: true } ]

Do you know if this is a bug or what?

try asking binance for a new api, that worked for me on gdax.

I think the issue is because binance only supports 5 decimals digits and we are sending 8.

Same problem here. Couldn't fix it. Any help would be great!

i just discover that this errors happens because the products.json of binance is not correct according with the real minimum allowed by their site. Fixing the file manually the issue seems to be fixed.
thanks for the support

Could you show me what exactly did you chance? That would be great. Thx

For ETH-USD pair i just changed to:
{
"id": "ETHUSDT",
"asset": "ETH",
"currency": "USDT",
"min_size": "0.01000",
"max_size": "100000",
"increment": "0.001",
"label": "ETH/USDT"
}

Thx. I'm not able to get it work.
Did also the increment of 0.001 but no hope.
{
"id": "IOTABTC",
"asset": "IOTA",
"currency": "BTC",
"min_size": "1.000000",
"max_size": "100000",
"increment": "0.000001",
"label": "IOTA/BTC"
},
If someone have a idea it would be great!

Where do I find this file?


[Feature] Add/remove connection breakpoint by dragging

Reported by andrex42 on 2010-03-16 20:46 UTC
When the user clicks on a connection and starts dragging a breakpoint should be added. Conversely, a breakpoint should be deleted when it is dropped near another breakpoint or on an almost straight line segment.

Commented by andrex42 on 2010-03-17 08:26 UTC
Implemented in e3fec4ea.

Updated by andrex42 on 2010-03-17 08:26 UTC

status: open --> closed


Add support for Y-axis category values in Time-Series Scatter Plot

I would like to create a scatter plot where the Y-axis is a text value rather than a number. In this example the Operation column contains names of actions say OperationA or OperationB.
I want to use these 2 values on the Y-axis and plot dots whenever in time these actions occur.
Using the Time-Series Scatter Plot I can achieve this (almost).
I can declare 2 CUSTOM SQL metrics like this:

Label: OperationA

CUSTOM SQL: IF( count(Operation) filter(where Operation = 'OperationA') > 0, 100, -100)

Label: OperationB

CUSTOM SQL: IF( count(Operation) filter(where Operation= 'OperationB') > 0, 200, -200)

For each aggregation of OperationA it will result in either a value of +100 or -100.

First issue:
I'm not interested in seeing OperationA markers if that was not the action taken. I can CUSTOMIZE the chart to only show positive values, hiding the non-events however the hover tooltip can pickup negative values.
Second issue:
Its cumbersome, you have to explicitly create a metric for every possible category value (thus know all of them ahead of time).
Third issue:
The Y-axis has these artificial numbers which are meaningless.
If I was able to use text values as a metric, I would have used a metric like MAX(Operation) to pick the text value to plot on the Y-axis. Right now the code assume the metric is a number.
I would declare a metric like this
Label: Operations
CUSTOM SQL: max(Operation)
But this gets me half way there. Ideally I would like the skip the GROUP BY entirely so that every event in time is displayed as a marker in the scatter plot. With it's text value (could be numeric as well).
Is this something the Time-Series Scatter Plot would be able to do with minor changes?

optional GROUP BY
metrics of text type

The error sent by the server is "Could not convert OperationA to numeric"
I have noticed that if I remove this field from the request sent to the server. The call will succeed. It will also succeed if I replace the mean operator to be a max operator. I'm not sure where this mean operator comes from and why it is required..
            "post_processing": [
                null,
                null,
                null,
                {
                    "operation": "pivot",
                    "options": {
                        "index": [
                            "__timestamp"
                        ],
                        "columns": [],
                        "aggregates": {
                            "SomeLabel": {
                                "operator": "max"
                            }
                        },
                        "drop_missing_columns": false
                    }
                },
                null,
                null
            ]

I modified the scatter plot client and I'm able to get the desired results.
/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts
Removed the pivotOperator
export default function buildQuery(formData: QueryFormData) {
         timeCompareOperator(formData, baseQueryObject),
         sortOperator(formData, { ...baseQueryObject, is_timeseries: true }),
         rollingWindowOperator(formData, baseQueryObject),
         //pivotOperator(formData, { ...baseQueryObject, is_timeseries: true }),
         formData.contributionMode
           ? {
               operation: 'contribution',

Removed the number formatter
/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
export default function transformProps(
     fillNeighborValue: stack && !forecastEnabled ? 0 : undefined,
   });
   const series: SeriesOption[] = [];
   const formatter = undefined; //getNumberFormatter(contributionMode ? ',.0%' : yAxisFormat);

Changed the echart type to be 'category'
Removed the axisLabel property
    yAxis: {
       ...defaultYAxis,
-      type: logAxis ? 'log' : 'value',
+      type: 'category', //log' : 'value',
       min,
       max,
       minorTick: { show: true },
       minorSplitLine: { show: minorSplitLine },
       // axisLabel: { formatter },
       scale: truncateYAxis,
       name: yAxisTitle,

Tooltip checks if it should use the number formatter
/plugins/plugin-chart-echarts/src/utils/prophet.ts
   let isObservation = false;
   if (observation) {
     isObservation = true;
-    row += `${formatter(observation)}`;
+    if (formatter) {
+      row += `${formatter(observation)}`;
+    }
+    else {
+      row += observation;
+    }
   }

This yields the following result.

Excellent idea, thanks for bringing this up @cccs-jc ! We're currently working on making the x-axis generic, but I don't see any reason why we couldn't also make the y-axis generic where applicable (as your POC shows this is fairly trivial to implement in ECharts). I'll definitely keep this in mind when making changes to the code while working on the x-axis feature.

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: https://github.com/apache/superset/issues/13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.


add ndt data volume blog post, ndt test links

This PR adds a new blog post about NDT data volume and adds a link to speed.measurementlab.net on both the NDT landing page and the website front page.
Content may be previewed on sandbox: http://website.mlab-sandbox.measurementlab.net/

This change is

Can we make the table be "tests counts from every country in 2019"? That way smaller countries can still have big numbers.
￼

Ugh. Investigating how to do that with the ndt5 data led me to file https://github.com/m-lab/etl/issues/733
Let's either delete the table or make it about the first half of 2019.

@pboothe I've updated the table to include a total test count by country from Jan 1-Jun 30, 2019. PTAL?


NavigationDestination docs could use a diagram

The docs explaining the how NavigationDestination will look like doesn't translate well to API docs

Potential Solution
Use a diagram generator to illustrate this better

duplicate of https://github.com/flutter/flutter/issues/103032


Improvement in Dark Mode

The colors in the dark mode are not good and some element are not seen in dark mode. Hover Effects are not so good I will also fix this.
Please assign me to this project.

Please Assign me to this project so that i can improve the UI and take participate in JWoC

I am interested to solve this issue please assign me this task

This icon is showing in light mode but not in dark mode I want to fix this issue please assign me.

@psykat1116 you are good to go. All the best. Let me know if you don't want to do in case due to late response.
I'm sorry for being inactive, the reason for the same was due to some serious health issues.

@kaal-coder No Problem I want to do it.


Nest Thermo - Temperature in Celcius ?

I am located in Europe so my Nest thermos are set to display the temperature in degrees Celsius.
I assumed I could just use degrees Celsius when setting the temperature value in the HA Bridge.
However, I found out that the HA Bridge temperature setting MUST ALWAYS be in Fahrenheit - then and only then, the correct, Celsius-converted temp appears on the Nest itself.
For example:

If bridge temp value = 68 (F) then Nest displays 20 C (OK assuming the entry value is in F)
If bridge temp value = 20 (C) then I get an error: -6.66 (C) value out of range (10 C - 33 C)

Is there a way or modification to have the HA-bridge accept Celsius range (10-33) temp values and send them to Nest in Fahrenheit as expected?
Thanks in advance

Yeah, I was going to get to this. I'll need to add a setting to control if you want it in F or C. The math is done in the bridge so it is easy.


Image Styles in features with MultiPolygon geometry

Not sure if this is intended behaviour, but in the case mentioned in the title the styles are not rendered. Intuitively I think it should still apply the style to center of the geometry extent (or alternatively to the center of each of the polys)

By default, image styles get applied to points only. If you want image styles to get applied to multipolygons, you'll need to set a geometry in the style function:
var imageStyle = new ol.style.Style({
  geometry: function(feature) {
    return feature.getGeometry().getInteriorPoints();
  },
  image: new ol.style.Circle({
    radius: 5,
    fill: new ol.style.Fill({ color: 'black' })
  })
});


Current release doesn't build

The last release file luv-1.30.1-0.tar.gz doesn't build because it doesn't include the pkg-config file libluv.pc.in so CMake complains:
CMake Error: File /build/libluv/src/luv-1.30.1-0/libluv.pc.in does not exist.
CMake Error at CMakeLists.txt:206 (configure_file):
  configure_file Problem configuring file

-- Configuring incomplete, errors occurred!

A new release with that file included should be made.

Agreed, will release a 1.30.1-1 when I get a chance.

Should be fixed in 1.30.1-1.


Cleanup and small additions to reals

This is just a cleanup/minor refactoring of the reals. I've moved a bunch of the lemmas to the appropriate places in algebra.

I've added one more commit. Jeremy noticed that the following failed:
import data.real
open real

check 0 + 0
check 3 + 3

This is because the rat namespace was opened without coercions in real/basic where of_rat is defined. The last commit fixes this.

And, one more commit, unrelated to the others. This begins to address #760.


Doc: redifinition initialize

Removed redundant macro included
Added spec and doc about redefinition of initialize method

Redundant in sope of https://github.com/NeuraLegion/generic_actor/pull/4

Redundant in scope of https://github.com/NeuraLegion/generic_actor/pull/4


Qingwei/fix sell on market portfolio bug

This fix the buggy behavior sell on market button, but is not a proper fix because now the charts is using real time ticks, so it will not retain the contract if contract's tick went out of our 60 ticks frame

Coverage decreased (-0.2%) to 35.2% when pulling e60c1acfb9d7e0e2cc49b5113c084833661d6383 on qingweibinary:qingwei/fix_sell_on_market_portfolio_bug into 8d7c21e450d778154a85eb08d557e1c5c3d2074f on binary-com:master.


Make agents that can't reach their goals static

Roughly 2% of agents cannot reach their goals due to mislabeling. We should make these agents static so that we don't actually have to control them. The way to do this is replay the expert trajectories and see which ones have a collision in the expert trajectory. We can overapproximate and treat all of those as experts.

Solved by this pr.


update user agent

Description
Since our name change happened in June 2020, I wanted to update the user agent to reflect that.
Checklist

[ x] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot check


Use/Mention IHtmlLocalizer.GetString in Localization doc

Globalization and localization in ASP.NET Core provides the following information about IHtmlLocalizer and ViewLocalizer:

Use the IHtmlLocalizer<T> implementation for resources that contain HTML.

IHtmlLocalizer HTML encodes arguments that are formatted in the resource string, but doesn't HTML encode the resource string itself.

ViewLocalizer implements the localizer using IHtmlLocalizer, so Razor doesn't HTML encode the localized string. You can parameterize resource strings and IViewLocalizer will HTML encode the parameters, but not the resource string.

It also gives the note below twice:

Note: You generally want to only localize text and not HTML.

The effect of the above, in my view, is that although HTML may be put in resources and may be localized without being encoded using IHtmlLocalizer, generally speaking, only text should be included in resources. That would be fine if the HTML encoding behavior of IHtmlLocalizer is an opt-in. Unfortunately, since the injection of an IViewLocalizer is the easiest way for a MVC view or Razor page to get a localizer and IViewLocalizer extends IHtmlLocalizer, all localized strings from IViewLocalizer are not HTML encoded. This is confusing because other values on the same page, such that those from Model and IStringLocalizer<SharedResource>, are HTML encoded.
Adding to the confusion is that wrapping an IViewLocalizer value with Html.Encode makes the situation worse as the value is then double encoded.
I initially thought the it is a bug (See aspnet/Mvc#8225). After a more careful reading of the document and ASP.NET Core API Reference, I find that localized values that are retrieved through the IHtmlLocalizer.GetString extension method instead of the index property are HTML encoded. The IHtmlLocalizer.GetString extension method is probably the easiest way to opt out of the HTML encoding behavior of IHtmlLocalizer and I think it should be mentioned in the document with examples.
Finally, since there is a similar extension method for IStringLocalizer, to make the HTML encoding behavior more consistent and easier to understand, perhaps all localized values in the examples, except those showcasing the HTML encoding behavior of IHtmlLocalizer, should be retrieved through the GetString extension method.

@ryanbrandenburg  please review.

Edited the issue above to suggest replacing the index properties with either GetString or GetHtml

I think I need to mention some of what you wrote in https://github.com/aspnet/Home/issues/3289 to make the APIs consistent in IStringLocalizer, IViewLocalizer & IHtmlStringLocalizer

FYI the issue that I referenced earlier is unfortunately closed 😞, @Rick-Anderson what's the action needed here?


GH-39943: [CI][Python] Update manylinux images to avoid GPG problems downloading packages

Rationale for this change
Old manylinux images seem to have issues with a GPG key in order to download packages.
What changes are included in this PR?
Update the manylinux image used for the latest one.
Are these changes tested?
Via archery jobs
Are there any user-facing changes?
No

Closes: #39943

@github-actions crossbow submit -g wheel

The CI failures aren't related as far as I can tell.