Intellisense for TypeScript Monorepo stops working after a few mintues

The Office Online team has a TypeScript monorepo managed by Rush. The repository has over 50 packages in it, some of which are interconnected. References to other packages in the repo are not handled with TypeScript project references, but are instead linked by Rush using symbolic links.
Very recently, we started noticing that after just a few minutes the intellisense for Typescript in VSCode stops working and our developers are having to reboot constantly to get intellisense back in a good state.
We're using Typescript 3.2.2 and all our developers are on Windows machines.

Moving upstream as this appears the be a TS issue. I can't repo it though by making random edits and opening random files in the project
One thing I noticed is that the root tsconfig does not have an excludes/includes section. May be worth adding one just to ensure that any file that is not part of a project does not trigger TS to try loading a very large number of files into a single project
Also, the TS Server logs may be helpful to identify when and why the stall happens:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a folder with a tsserver.log file in it

If you can send the logs by email I can see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this


'Fusion Obby' example place should use framerate-independent particle physics

Currently the Fusion Obby example place has a confetti particle system which is designed to run on a fixed timestep, but which currently just runs every render step. This means the effect may not appear at the correct speed for people not running Roblox at 60fps.
@\boatbomber's Lua Learning already has framerate-independent particle physics, however I'd like to investigate performance-light enhancements to improve the smoothness of the motion when using a fixed time step.
This isn't something I have time to address now, but worth noting to fix later.

You have full access to my codebase, feel free to poke around and see how I did it. You have my written permission to create and share derivate work from my particle system.


Fix spurious errors when using --follow-imports=normal

Fixes #62
When generating diagnostics for a file while using --follow-imports=normal, mypy will emit errors that occur in both the requested file and any other files it may import. However, the extension doesn't check which file an error originates from, leading to errors from other files being incorrectly reported as being for the requested file. These changes fix that behavior by stripping out all errors originating from files other than the requested file.
Additionally, this changes the default mypy configuration to be --follow-imports=normal. This makes it more similar to the previous behavior before #52, where --follow-imports=silent (which is not supported by dmypy) was used to suppress error messages while still allowing mypy to pull in useful type information from imported files.

@Jammf Seems like there is an issue with python 3.7, probably need to special case it for 3.7.

It looks like there might be some issue with the .nox/tests venv  that dmypy is running in? I found the following line in the testing logs, which is result.stderr from the call to dmypy (and since result.stdout is empty, no diagnostics are published, which is why the tests are failing):
{'type': 4, 'message': 'The typed_ast package is not installed.\nYou can install it with `python3 -m pip install typed-ast`.\n'}

This seems to just be an issue with 3.7, and doesn't seem to be related to the changes I made (I ran local tests against main and that also had the same errors).
That said, I'm pretty stumped on how to actually fix the tests, or even why that error is occurring in the first place. It does look like typed_ast has reached EOL (along with Python 3.7 itself), but I can't see how that would cause the tests to suddenly fail.

I have a fix for this. Basically typed-ast reached end of life yesterday. They released a new version, that version has multiple linux *.so which breaks our bundling.

After this is merged it will be available in the next pre-release (usually the next workday)


Session life cycle

Hi!
I would like to see a bit more on the life cycle of a session in the message broker. The problem I have is that on the one hand, you write:

On session-aware queues or subscriptions, sessions come into existence when there is at least one message with the session's SessionId. Once a session exists, there is no defined time or API for when the session expires or disappears.

On the other hand, there is:

All existing sessions in a queue or subscription can be enumerated with the SessionBrowser method in the Java API and with GetMessageSessions on the QueueClient and SubscriptionClient in the .NET client.

So, if I use sessions for implementing a call/return pattern, in an application running for ten years, that SessionBrowser thing will return billions of (now empty) sessions beause every session ever opened will still be there somewhere?
Lots of Greetings!
Volker

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0803fba3-53aa-0d6b-e692-81777f3f7641
Version Independent ID: fdc839f6-4986-89f2-5334-879559df8511
Content: Azure Service Bus message sessions
Content Source: articles/service-bus-messaging/message-sessions.md
Service: service-bus-messaging
GitHub Login: @clemensv
Microsoft Alias: spelluru

Thanks for the feedback! We are currently investigating and will update you shortly.

There are scenarios where lots of sessions are created, like with call/return, where I send a message to a service via queue, containing the id of a session I listen to, then I listen on a sessioned queue for the response.
Given all the multithreading, scaling and reboot/migrate stuff in a modern web hosting, I really see no other way to implement a call/return using anything other than random guid session id's, one per call.
In a busy web application, there can be hundreds of such api calls per minute or even second, and millions over years, adding up to an equally large number of sessions.
So, can I use a new guid for each call or will I run out of sessions? What does the SessionBrowser object return after a few years of running?
Will a session use resources, i.e. any resources, whether storage, or even a list of session id's or anything at all if there are no messages in there?
Or is a session

without messages
with sessionstate==null
with no one listening for messages in this session

fully equal to a session that does not exist yet? Does it actually exist?

I have the same concern.
For each Document we would have multiple messages, that needs to be individually handled in sequence.
Therefore the SessionId would equal the DocumentId, of which there are millions every year.
Will we run into problems when we a few years in the future have millions of different SessionIds used, where most of them are old and empty and will NEVER have new messages pushed to them again?

@sergaz-msft  I wonder why no one at ms never responded to these questions

@vhe1 If there are no active messages for a session, then that session does not utilize any resources on the service side.
it will not show up when queried using the SessionBrowser also.
#please-close


Training and Mentorship / add information for undergraduates?

In addition to the Graduate study section and Postdoctoral training section, we could add a short section for undergraduates who may want to get involved in the lab detailing what opportunities are available, how they could apply/who they should contact, qualifications, what they can expect to be doing, etc.

In line with this, it would be also good if the information about the visiting student researcher is added.

working on this


Question about reproduction

Thanks for your great work!
And I have two questions about reproducing results.

I have a question about 'Adversarial Domain', that is, how to generate it from MSRVTT? I tried to select the samples which are among top 5k minimum retrieved values of each query, but cannot reproduce the results of the paper, on the setting of MSRVTT full and TT-CE.
I have a question about querybanks for clip2video. That is, i generate querybanks directly from CLIP2Video inference , and finally get the train_test shape as [180000, 1000]. But after qbnorm, the result is {'R1': 46.4, 'R5': 72.6, 'R10': 82.5, 'R50': 94.4, 'MedR': 2.0, 'MeanR': 14.1, 'geometric_mean_R1-R5-R10': 65.3}
I think i may have some misunderstandings? Really appreciate it if you can reply.

Hi,

So, we constructed the Adversarial querybank for MSRVTT by taking 5000 queries that retrieve the least videos. So, we computed the most retrieved video and put the queries from that video in the querybank, then we computed the second most retrieved video and put those queries in the querybank and so on until we reach 5000 queries.
What temperature (beta) did you use? We will try to upload the similarity matrices for CLIP2Video also.

Thanks,
Ioana

Thanks for your help! And I have reproduced results according to your first advice.
In clip2video, beta is set to 0.5. Looking forward to the matrices!

@JonnyS1226 Have you reproduced the result in clip2video which is reported as 47.2 on the R@1? Can you share your reproduction process？

Hi,
We published here the sims matrices for CLIP2Video (https://www.robots.ox.ac.uk/~vgg/research/teachtext/QB-Norm/msrvtt-1ka-clip2video-sims.tar.gz). For the final experiments we used beta = 1/1.99, as stated in the paper.
Cheers,
Ioana

Hi,
We published here the sims matrices for CLIP2Video (https://www.robots.ox.ac.uk/~vgg/research/teachtext/QB-Norm/msrvtt-1ka-clip2video-sims.tar.gz). For the final experiments we used beta = 1/1.99, as stated in the paper.
Cheers, Ioana

Thanks!

@JonnyS1226 Have you reproduced the result in clip2video which is reported as 47.2 on the R@1? Can you share your reproduction process？

I just use clip2video inference (text in training set and video in test set), get the final train_test_sim, and the results is sensitive to beta. The author has published the sims of clip2video~

Thanks for your reply. I have tested with the train_test sim matrix of clip2video. And as you pointed out, this result is so sensitive to the beta that I mistakenly thought I made a mistake somewhere.

Hi,
Thanks for the questions!

We used the original training MSR-VTT split when extracting the sims matrix for CLIP2Video (due to some time constraint at that point). Did you find that using the whole (180000, 1000) matrix produce lower numbers?
We updated the paper on 6 April and it reflects the 1/1.99 value. Since the QB-Norm algorithm runs fast, we afford to do some brute force. For your own dataset I suggest to do a general search first to find a good value and then to do a fine-grain search around that value. In our paper we strived for consistency and tried to use a global beta for all datasets. So, if you are interested, for most datasets you can find a better temperature that yields better results.

Thanks,
Ioana

yes, when use the (180000, 1000) train_test, my best reproduced results R@1 is 46.9, where beta is 0.55, but this is already a big improvement.

Hi,
Thanks for pointing that out! We have not tested with the full 9k training queries.
The reason why beta is around 0.5 for CLIP models(clip2video and clip4clip) is because the final similarity matrix is scaled by the methods which is differently than CE.
Ioana

@ioanacroi Thanks for your patient explanation.
I didn't test the (180000, 1000) sim matrix on clip2video, but for my own model, which did not achieve some improvement. It confused me for days after I tested different ways to construct query bank, such as sampling 5000 from training set and using the whole 180000 text queries in training set.
I also tried a brute force search for beta, but its best results also didn't beat the original model's results, which disappointed me a lot.

Hi,
@HanielF In our experiments QB-Norm always brought a gain, so I am not aware of why this would not work on your method.
I will close this issue, feel free to reopen if needed.


feat: remove partition schema when incremental model overwrites partitions

Description

Glue has two kinds of schema, table schema and partition schema.
When the table schema is updated, the partition schema does not follow it automatically.
This causes HIVE_PARTITION_SCHEMA_MISMATCH in some conditions.
To avoid this, clean_up_partitions is modified to delete partition schemas as well as delete s3 objects.
I also found getting Parameters of table shows KeyError on some tables.
To fix it, I use get statement on table
Models used to test - Optional

Checklist

[x] You followed contributing section
[x] You kept your Pull Request small and focused on a single feature or bug fix.
[x] You added unit testing when necessary
[x] You added functional testing when necessary

Thanks for the fix @hiro-o918 💯


⚠ Fortnite has degraded performance

In 8fbcd62, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1617 ms

Resolved: Fortnite performance has improved in 37c7255.


update manual on use of distribution functions in nimbleFunctions

Once keyword processing is dealt with, we should update the manual to reflect the additional flexibility we allow.
Also note at that location in the manual that user defined dist functions can be used. (Note need to deal with keyword processing for user-defined too via matchFunctions analog in nimbleUserNamespace)

keyword processing for user-defined distributions already works fine in terms of matching arg by name and rearranging the arg order.
I updated the manual to reflect that we allow default args and do arg matching by name.


Fix segfault in C_GetAttributeValue

sec_convert_cert3_to_attribute_list() previously defined serial in two
different scopes - first as a CK_BYTE*, and later on as a char*. This
led to serial_len being set to a valid length, but the CK_BYTE* remained
NULL when processed by C_GetAttributeValue().
On my system this was causing Chrome/Firefox to segfault at
pkcs11-impl.c:667 during the memcpy, due to pTmp->pValue being NULL.
This commit removes the second definition of serial and casts the
existing CK_BYTE* where necessary.
Signed-off-by: Matt Merhar<EMAIL_ADDRESS>

yes. this was a serious bug. i wonder why it did not trigger a segfault or even a compiler warning on my system.

i didn't see the segfault when doing relatively simple stuff like pkcs11-tool --module /usr/lib/x86_64-linux-gnu/scd-pkcs11.so ..., but firefox/nss seem to really give the module a workout.
regarding not seeing the error, i guess -Wall isn't enough (you'd think it would be...). i just tested with -Wshadow and it triggered an error:
cc -c pkcs11-impl.c  -Werror -Wall -Wshadow -std=c99 -fPIC -DHAVE_SSL
cc -c sec.c  -Werror -Wall -Wshadow -std=c99 -fPIC -DHAVE_SSL
sec.c: In function ‘sec_convert_cert3_to_attribute_list’:
sec.c:135:11: error: declaration of ‘serial’ shadows a previous local [-Werror=shadow]
     char *serial = BN_bn2dec(bn);
           ^~~~~~
sec.c:113:11: note: shadowed declaration is here
  CK_BYTE *serial = NULL; CK_ULONG serial_len = -1;
           ^~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:23: sec.o] Error 1

thanks for merging!


"Multicore/spreaded" processing autocrafting only using one machine

Issue description:  "Multicore/spreaded" autocrafting only using one machine
What happens: Only one machine is being used, despite haing multiple machines with same processing pattern installed in appropriate crafter
What you expected to happen: All machines spread the workload between the crafting of the requested item
Steps to reproduce:

Set up a few solderers with crafters ontop and importers at bottom
Insert the EXACT similar processing patterns into the crafters
Request the item from autocrafting and expect only one machine being used.
...

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: 2601
Refined Storage: 1.5.31

Does this issue occur on a server?
I don't know. Maybe irrelevant
P.S: I also made a bad quality video, showcasing the bug.
https://youtu.be/x0ayNR5WzP0 Maybe that would be helpful

I think this is not the bug, but it just don't work like that, sadly. It would be great if it would tho.

It should work like that. I'm going to look into it.

I can't reproduce this. It works fine for me.


[Tooltip] Not working with contenteditable on iOS

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Correct behavior is to create a contenteditable html mark or input with mdTooltip directive.
What is the current behavior?
We can create with only 1 of 2 elements, when html mark got both it's not working.
This behavior work in Chrome and Firefox...
What are the steps to reproduce?
Here my demo: http://plnkr.co/edit/3AbfAd0DJWUZjZ9xTLX9?p=preview
What is the use-case or motivation for changing an existing behavior?
I would like to have an html mark editable with a tooltip when there is an error (display with the tooltip).
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Browser: safari (iOS)
Is there anything else we should know?

We tried this out and found that the tooltip does show up on longpress as normal on a contenteditable div. You should, though, also be able to apply matTooltip to a container element if necessary.


Get smaller homogeneous patches of stars

get stars from multiple nside 4096 pixels rather than 256 (smaller area -> more computationally feasible)
randomize positions so that the stellar density is homogeneous (density varies by healpix in galactic coord but the catalog is store in healpix in icrs)

Addressed in #4fbddcc


Unable to reset password on Keybase

I seem to have misplaced my details to login to keybase (have the username and email though), it says I can still login from "Desktop" but I formatted that PC a few weeks ago by re-installing the OS.
I have emails back from 2017 where I confirmed ownership via twitter and reddit.
It doesn't allow me to reset the account because it says I still have one device active (which I don't).
How do I reset the account? Thanks!

login on the website and reset all keys

Thanks I was able to remember my login password and reset the account.


Bottom navigation bar is not working properly

When you click the Learn icon and then press the Back button, you will be taken to the Wallet screen, but the navigation bar still highlights Learn icon.

Hi there! I think you might not be building the app from the latest master branch (or maybe you're using the app downloaded from the Play Store). This is a nice little bug, and it was solved in #259!
If you try building the latest version you'll find it all fixed. Cheers!

Thanks, @thunderbiscuit


[grafana] Use sidecar for datasources and dashboards

what

Update to use sidecar pattern

why

Allow applications to ship their own monitoring configurations

todo

[ ] demonstrate loading datasources (they are loading, but grafana doesn't display them)
[ ] demonstrate loading dashboards by YAML/JSON and ID

Here is a working example with datasource ConfigMap
apiVersion: v1
kind: ConfigMap
metadata:
  name: grafana-datasources
  labels:
    grafana_datasource: "true"
data:
  datasource.yaml: |-
    apiVersion: 1
    datasources:
    - name: Prometheus
      type: prometheus
      url: http://kube-prometheus-prometheus:9090
      access: proxy
      isDefault: true

Here is a working example with dashboard ConfigMap
apiVersion: v1
kind: ConfigMap
metadata:
  name: grafana-dashboards
  labels:
    grafana_dashboard: "true"
data:
  kubernetes-cluster-monitoring.json: |
    {...}

New configuration will accessed by grafana on startup (pod should be restarted)
Also, here is a helper script to download dashboards by id and revision (taken form grafana chart).
#!/bin/bash

ID=$1
REVISION=$2
DATASOURCE=$3

curl -sk \
    --connect-timeout 60 \
    --max-time 60 \
    -H "Accept: application/json" \
    -H "Content-Type: application/json;charset=UTF-8" \
    https://grafana.com/api/dashboards/$ID/revisions/$REVISION/download | sed "s|\"datasource\":[^,]*|\"datasource\": \"${DATASOURCE}\"|g" \
    > $ID-$REVISION.json


feature: Allow for checkboxes to not propagate state to children

There is new option disableCheckboxSelectionPropagation that id set to true disables propagation of state of checkboxes to children and switches off validation of parents state. Thus the checkboxes are independent on each other and selection of checkbox on any level is relevant only to it's item.
Closes #195

Now I see I should have probably commit the built files too. But before adding it, please let me know if the changes are otherwise OK for you. Thanks!

Nice!
Not a big deal but you can skip the built files in future.
Would it make sense to have two separate options, one to stop parent validation and the other to stop child selections?
Would need some tests too ;).

ad the two options - not sure if you mean it as a discussion or polite request.. if discussion - first, I don't see a use case for it and second, it would complicate configuration for the two scenarios (file system like case and the case where parent nodes represents sums (or some other calculations))

ad testing - I can't even get the environment working - tasks jshint and jasmine fail and I only can proceed with grunt -force. (I'm not JS developer so it might be my limited knowledge though. Any help appreciated.)

Anyway, I didn't thank you for this component, which is helpful and nice written so even I was able to make changes there. Thanks for your effort and sharing!

OK, regarding to the environment, update of packages did solve the problem (it is pretty old stuff in the repo). I've added tests.

I did mean it as discussion and am inclined to agree with you :). The only reason I ask is in the past we've gotten requests for both "halves" of that feature independently.

Yeah... the env is a bit dated. Our tooling at iVantage has actually drifted quite a bit from what's used here so incremental updates no longer trickle down for free. I'm glad you got it sorted :).

Thanks for adding the tests - I'll review shortly.

Thanks for the contribution! This is available in v1.1.0.


Weird issue with UITableView

I am having a weird issue when scrolling. Cells start disappearing when you bounce the view.
From my testing is caused by SPStorkController.scrollViewDidScroll(scrollView) but not sure why yet, is this issue known?

Please, send me example project

Here is a [https://github.com/robertodias180/SPStorkController-Bug-Demo](demo App)

Yes, real bug. You can see example in project, I am create example table.
You need set
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let cell = tableView.dequeueReusableCell(withIdentifier: "Cell", for: indexPath) as! ValuePickerCell
        cell.transform = .identity // here
        cell.optionLabel.text = self.options[indexPath.row].text
        return cell
    }

I don't know hot it fix now

@IvanVorobei the cell.transform = .identity fix it thans 👍
But the cells still blink when you scroll. Is this fixable?

Yes, cells blink... I am added this issue to readme for help community.

I am update example and now all work correctly. Please, see.


Add SensitivityAtSpecificity metric

What does this PR do?
Fixes the remaining part of #971
It basically follows the same code structure with this pull request and make the necessary modifications.
Repos like tensorflow include both SensitivityAtSpecificity and SpecificityAtSensitivity, whereas Torchmetrics is missing SensitivityAtSpecificity.
The github discussion at #971 ends with "Feel free to implement the other variant SensitivityAtSpecificity if you guys are interested."

Before submitting

[X] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[X] Did you read the contributor guideline, Pull Request section? (OH: no such a section, is this a test?)
[ ] Did you make sure to update the docs?
[X] Did you write any new necessary tests?

PR review
 SpecificityAtSensitivity is already included in TorchMetrics. This PR introduces the SensitivityAtSpecificity Metric.

Did you have fun?
[X] Make sure you had fun coding 🙃

:books: Documentation preview :books:: https://torchmetrics--2217.org.readthedocs.build/en/2217/

@oguz-hanoglu @SkafteNicki seems like a real issue with GPU and old version of pyTorch

@oguz-hanoglu @SkafteNicki seems to be constantly failing on PT 1.10
see: https://dev.azure.com/Lightning-AI/Metrics/_build/results?buildId=189940&view=logs&jobId=95985737-7c02-5ecd-7847-688de4203f7e&j=95985737-7c02-5ecd-7847-688de4203f7e&t=30568a28-ed27-55ff-e099-f25174540c05

we can also allow this method only for newer PT


Relion GUI is not in relion/3.* containers

Can not launch the Relion GUI for the 3.* version of the containers:
$ module load relion/3.1.0
$ relion
INFO legacy OFED driver set: 4.7-<IP_ADDRESS>
FATAL Failed to find relion in PATH

And indeed, shelling into the container shows a bunch of relion_***** executables under /usr/local/relion/bin, but no relion itself.
Same for the relion/3.0.8 module.  But not for relion/2.1.b1 (this GUI launches fine).  The relion_refine_mpi seems to work fine for all, so I wonder if something had changed with the GUI behavior and/or installation procedure between versions 2 and 3?

This looks like a bug in the container environment module for the 3.0.8 container.  The relion mapping should be removed.

From the end-user prospective it feels like a bug/omission in the container though :)  What's the best way to reach out to the containers folks?

https://forums.developer.nvidia.com/c/accelerated-computing/nvidia-gpu-cloud-ngc-users/container-hpc/30

Thanks, posted there: https://forums.developer.nvidia.com/t/relion-3-containers-lack-the-relion-gui/173632


(backport) Add Cape Town (af-south-1) as a supported AWS region.

Backport of https://github.com/rancher/ui/pull/3962

https://github.com/rancher/rancher/issues/27083


Error while trying to start your software

loading preprocessed files
Traceback (most recent call last):
File "train.py", line 75, in
main()
File "train.py", line 39, in main
train(args)
File "train.py", line 50, in train
model = Model(args)
File "/home/tensorflow/tests/char-lstm-16/model.py", line 53, in init
self.final_state = states[-1]
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/array_ops.py", line 126, in _SliceHelper
raise NotImplementedError("Negative indices are currently unsupported")
NotImplementedError: Negative indices are currently unsupported

https://github.com/sherjilozair/char-rnn-tensorflow/pull/12 should have fixed this. Please re-open if this isn't the case.


Add mola_lidar_odometry to rosdistro for indexing

Please Add This Package to be indexed in the rosdistro.
ROS distributions: all ROS 2 active distributions.
The source is here:
https://github.com/MOLAorg/mola_lidar_odometry
Checks

[X] All packages have a declared license in the package.xml
[X] This repository has a LICENSE file
[X] This package is expected to build on the submitted rosdistro

Linked ros2-gbp PR: https://github.com/ros2-gbp/ros2-gbp-github-org/issues/562


cleanup consecutive if statements

[Current coverage][cc-pull] is 60.81%

Merging [#30][cc-pull] into [master][cc-base-branch] will increase coverage by 0.01%

@@             master        #30   diff @@
==========================================
  Files            21         21
  Lines          1755       1753     -2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1067       1066     -1
+ Misses          688        687     -1
  Partials          0          0

Powered by Codecov. Last updated by [0218407...d63d78a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/CyberReboot/vent/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/CyberReboot/vent/compare/0218407f61567c2030eb8ea46ec303ef12912892...d63d78a89ae38e6adc8b0502697c168b2d079a4f
[cc-pull]: https://codecov.io/gh/CyberReboot/vent/pull/30?src=pr


Upgrade SQLAlchemy to 1.4

If you wish to discuss the possibility of adding support for SQLAlchemy 1.4, please open a thread on the Discussions tab or ask on the Superset Slack workspace. Thanks!


BLFS tools: commands run as root instead of as user

name: Bug report
about: Create a report to help us improve
title: 'BLFS tools: commands run as root instead of as user'
labels: bug
assignees: ''

Describe the bug
Commands without role="root" should be run as user, but sometimes, they are generated inside a sudo -E sh << ROOT_EOF ... ROOT_EOF block.
To Reproduce
Steps to reproduce the behavior:

Install blfs tools, and change to the directory where they are installed
Launch make, and select:
Post LFS Configuration and Extra Software--->
Security --->
[*] stunnel 5.53
Tick:
[*] Build as user
[*] Use `porg style' package management
Type q and save configuration. Answer yes to "Are you happy with these settings"
Examine the content of scripts/001-z-stunnel

Expected behavior
The script should contain:
cd $JH_UNPACKDIR

sudo -E sh << ROOT_EOF
groupadd -g 51 stunnel
useradd -c "stunnel Daemon" -d /var/lib/stunnel \\
        -g stunnel -s /bin/false -u 51 stunnel
ROOT_EOF
sed -i '/LDFLAGS.*static_flag/ s/^/#/' configure

Observed behavior
The script contains:
cd $JH_UNPACKDIR

sudo -E sh << ROOT_EOF
groupadd -g 51 stunnel
useradd -c "stunnel Daemon" -d /var/lib/stunnel \\
        -g stunnel -s /bin/false -u 51 stunnel
sed -i '/LDFLAGS.*static_flag/ s/^/#/' configure
ROOT_EOF

Environment Details (please complete the following information):

Host OS: Linux turboli 4.19.0-4-amd64 #1 SMP Debian 4.19.28-2 (2019-03-15) x86_64 GNU/Linux
Target architecture: N/A
jhalfs version: Revision: 3e2392f Date: 2019-04-25 11:26:50 +0200
Book version: BLFS development Sysv/systemd

Additional context
Add any other context about the problem here.

This happens because the <screen><userinput> is inside a <note>, but we only use:
preceding-sibling::screen[not(@role='nodump') and ./userinput][1][not(@role)], so that  are excluded...


feature: support authorization when connecting to the OAP

Codecov Report

Merging #81 (606deec) into master (2b7fae8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   44.89%   44.89%
=======================================
  Files           9        9
  Lines         147      147
=======================================
  Hits           66       66
  Misses         73       73
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7fae8...606deec. Read the comment docs.

Is this being added because of demo env? :)

😉 yes, we want to continuously use the demo env for development


Add input padder to warmup function

Codecov Report

Merging #187 (244cd57) into main (1a586ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   88.16%   88.16%
=======================================
  Files          57       57
  Lines        2357     2357
=======================================
  Hits         2078     2078
  Misses        279      279


Configuring overlay ports and overlay triplets through the manifest

Docs PR: https://github.com/microsoft/vcpkg/pull/27172

@microsoft-github-policy-service agree [company="microsoft"]

@microsoft-github-policy-service agree company="microsoft"

The only issue I have with adding this stuff into the manifest is that the manifest becomes kind of a configuration file for vcpkg instead of a clean dependency definition. Maybe vcpkg should add a new differentiation and add a vcpkg-project.json instead of calling everything vcpkg.json

The only issue I have with adding this stuff into the manifest is that the manifest becomes kind of a configuration file for vcpkg instead of a clean dependency definition. Maybe vcpkg should add a new differentiation and add a vcpkg-project.json instead of calling everything vcpkg.json

That is, vcpkg-configuration.json, where the registries definitions already live. That makes sense to me...

That is, vcpkg-configuration.json, where the registries definitions already live. That makes sense to me...

Wait, that's what this PR already does. @Neumann-A I think the "vcpkg.json is the durable/transitive declaration of dependencies" is unaffected here.

Wait, that's what this PR already does. @Neumann-A I think the "vcpkg.json is the durable/transitive declaration of dependencies" is unaffected here.

Maybe the title of the PR should be changed? Or is vcpkg-configuration.json also considered to be the manifest?
Furthermore can i use the manifest overlays without defining a registry?

We consider vcpkg-configuration.json as part of what composes "the manifest" , although this is not clear in the docs for sure.

Furthermore can i use the manifest overlays without defining a registry?

Yes, and just like registries you could also configure overlays in vcpkg.json using the configuration { } tag

Yes, and just like registries you could also configure overlays in vcpkg.json using the configuration { } tag

Is this documented somewhere? I always thought you need to have two different files (vcpkg.json; vcpkg-configuration.json).
https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md doesn't mention that.
https://github.com/microsoft/vcpkg/blob/master/docs/users/registries.md also seems to not mention it.
https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json also doesn't have that if I read it correctly.

Yes, and just like registries you could also configure overlays in vcpkg.json using the configuration { } tag

Is this documented somewhere? I always thought you need to have two different files (vcpkg.json; vcpkg-configuration.json). https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md doesn't mention that. https://github.com/microsoft/vcpkg/blob/master/docs/users/registries.md also seems to not mention it. https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json also doesn't have that if I read it correctly.

That would be my fault, I don't think it is documented other than the comment I made on the PR https://github.com/microsoft/vcpkg-tool/pull/239.

That would be my fault, I don't think it is documented other than the comment I made on the PR #239.

I will add this to the docs PR I have open (currently on the description of this PR)

closes https://github.com/microsoft/vcpkg/issues/12289 ?

The relative paths are still relative to the CWD and not to the configuration file.

@autoantwort good catch, just sent a new commit to change this

Thanks!


slow startup time since latest update 1.55.2

note I have also disabled AV completely, it is not caused by that! What I notice is that the following are very slow:
window.loadUrl() => begin to require(workbench.desktop.main.js)
System Info

Code: 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d)
OS: win32(10.0.21354)
CPUs: AMD Ryzen 9 3900XT 12-Core Processor           (24 x 4300)
Memory(System): 31.92 GB(22.75GB free)
Memory(Process): 208.80 MB working set(157.36MB private, 0.19MB shared)
VM(likelihood): 0%
Initial Startup: true
Has 0 other windows
Screen Reader Active: false
Empty Workspace: true

Performance Marks

What
Duration
Process
Info

start => app.isReady
60
[main]
initial startup: true

nls:start => nls:end
0
[main]
initial startup: true

require(main.bundle.js)
94
[main]
initial startup: true

app.isReady => window.loadUrl()
172
[main]
initial startup: true

window.loadUrl() => begin to require(workbench.desktop.main.js)
4763
[main->renderer]
NewWindow

require(workbench.desktop.main.js)
573
[renderer]
cached data: NO, node_modules took 0ms

wait for shell environment
0
[renderer]
-

init storage (global & workspace)
101
[renderer]
-

init workspace service
35
[renderer]
-

register extensions & spawn extension host
258
[renderer]
-

restore viewlet
0
[renderer]
-

restore panel
0
[renderer]
-

restore editors
26
[renderer]
1: workbench.editors.welcomePageInput

overall workbench load
248
[renderer]
-

workbench ready
5924
[main->renderer]
-

renderer ready
933
[renderer]
-

shared process connection ready
0
[renderer->sharedprocess]
-

extensions registered
6229
[renderer]
-

Extension Activation Stats

Extension
Eager
Load Code
Call Activate
Finish Activate
Event
By

vscode.debug-auto-launch
true
3
0
103
*
vscode.debug-auto-launch

vscode.git
true
59
2
141
*
vscode.github

GitHub.vscode-pull-request-github
true
81
1
100
*
GitHub.vscode-pull-request-github

ms-vscode.cpptools
true
131
0
229
*
platformio.platformio-ide

PKief.material-icon-theme
true
17
0
133
*
PKief.material-icon-theme

platformio.platformio-ide
true
324
0
0
*
platformio.platformio-ide

standard.vscode-standard
true
150
0
176
*
standard.vscode-standard

WakaTime.vscode-wakatime
true
75
0
100
*
WakaTime.vscode-wakatime

WallabyJs.quokka-vscode
true
1
99
1
*
WallabyJs.quokka-vscode

Wattenberger.footsteps
true
2
0
1
*
Wattenberger.footsteps

wayou.vscode-todo-highlight
true
2
1
0
*
wayou.vscode-todo-highlight

yatki.vscode-surround
true
2
0
0
*
yatki.vscode-surround

vscode.configuration-editing
false
4
0
4
onLanguage:jsonc
vscode.configuration-editing

vscode.emmet
false
23
2
5
onStartupFinished
vscode.emmet

vscode.github
false
10
0
0
*
vscode.github

vscode.github-authentication
false
24
0
46
onAuthenticationRequest:github
vscode.github-authentication

vscode.json-language-features
false
37
3
7
onLanguage:jsonc
vscode.json-language-features

vscode.merge-conflict
false
4
0
5
onStartupFinished
vscode.merge-conflict

vscode.microsoft-authentication
false
26
1
229
onAuthenticationRequest:microsoft
vscode.microsoft-authentication

ms-vscode-remote.remote-wsl-recommender
false
19
1
4
onStartupFinished
ms-vscode-remote.remote-wsl-recommender

ms-vscode.js-debug
false
195
6
0
onCommand:extension.js-debug.clearAutoAttachVariables
ms-vscode.js-debug

vscode.testing-editor-contributions
false
1
0
4
onStartupFinished
vscode.testing-editor-contributions

vscode.typescript-language-features
false
32
1
6
onLanguage:jsonc
vscode.typescript-language-features

DominicVonk.parameter-hints
false
247
0
4
onStartupFinished
DominicVonk.parameter-hints

eamodio.gitlens
false
218
1
3015
onStartupFinished
eamodio.gitlens

formulahendry.code-runner
false
28
2
3
onStartupFinished
formulahendry.code-runner

usernamehw.errorlens
false
3
0
3
onStartupFinished
usernamehw.errorlens

voorjaar.windicss-intellisense
false
59
1
2995
onStartupFinished
voorjaar.windicss-intellisense

Raw Perf Marks: main
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>685	0	0
code/didStartMain<PHONE_NUMBER>269	584	584
code/mainAppReady<PHONE_NUMBER>329	60	644
code/willLoadMainBundle<PHONE_NUMBER>329	0	644
code/fork/willLoadCode<PHONE_NUMBER>342	13	657
code/registerFilesystem/file<PHONE_NUMBER>420	78	735
code/didLoadMainBundle<PHONE_NUMBER>423	3	738
code/willOpenNewWindow<PHONE_NUMBER>501	78	816

Raw Perf Marks: renderer
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>503	0	0
code/didStartRenderer<PHONE_NUMBER>260	4757	4757
code/willShowPartsSplash<PHONE_NUMBER>260	0	4757
code/didShowPartsSplash<PHONE_NUMBER>261	1	4758
code/willLoadWorkbenchMain<PHONE_NUMBER>264	3	4761
code/willWaitForShellEnv<PHONE_NUMBER>837	573	5334
code/didWaitForShellEnv<PHONE_NUMBER>837	0	5334
code/didLoadWorkbenchMain<PHONE_NUMBER>837	0	5334
code/registerFilesystem/file<PHONE_NUMBER>840	3	5337
code/registerFilesystem/vscode-userdata<PHONE_NUMBER>841	1	5338
code/willInitWorkspaceService<PHONE_NUMBER>844	3	5341
code/willInitStorage<PHONE_NUMBER>844	0	5341
code/didInitWorkspaceService<PHONE_NUMBER>879	35	5376
code/didInitStorage<PHONE_NUMBER>945	66	5442
code/willStartWorkbench<PHONE_NUMBER>945	0	5442
code/LifecyclePhase/Ready<PHONE_NUMBER>948	3	5445
code/registerFilesystem/trustedDomains<PHONE_NUMBER>031	83	5528
code/willRestoreEditors<PHONE_NUMBER>166	135	5663
code/didRestoreEditors<PHONE_NUMBER>192	26	5689
code/LifecyclePhase/Restored<PHONE_NUMBER>192	0	5689
code/didStartWorkbench<PHONE_NUMBER>193	1	5690
code/didRemovePartsSplash<PHONE_NUMBER>193	0	5690
code/willConnectSharedProcess<PHONE_NUMBER>211	18	5708
code/willLoadExtensions<PHONE_NUMBER>240	29	5737
code/willHandleExtensionPoints<PHONE_NUMBER>311	71	5808
code/didHandleExtensionPoints<PHONE_NUMBER>490	179	5987
code/didLoadExtensions<PHONE_NUMBER>498	8	5995

Raw Perf Marks: localExtHost
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>278	0	0
code/fork/start<PHONE_NUMBER>642	364	364
code/fork/willLoadCode<PHONE_NUMBER>664	22	386
code/extHost/willConnectToRenderer<PHONE_NUMBER>884	220	606
code/extHost/didConnectToRenderer<PHONE_NUMBER>884	0	606
code/extHost/didWaitForInitData<PHONE_NUMBER>934	50	656
code/extHost/didCreateServices<PHONE_NUMBER>940	6	662
code/extHost/willWaitForConfig<PHONE_NUMBER>945	5	667
code/extHost/didWaitForConfig<PHONE_NUMBER>972	27	694
code/extHost/didInitAPI<PHONE_NUMBER>977	5	699
code/extHost/didInitProxyResolver<PHONE_NUMBER>978	1	700
code/extHost/ready<PHONE_NUMBER>978	0	700
code/extHost/willLoadExtensionCode/vscode.microsoft-authentication<PHONE_NUMBER>984	6	706
code/extHost/didLoadExtensionCode/vscode.microsoft-authentication<PHONE_NUMBER>010	26	732
code/extHost/willLoadExtensionCode/vscode.debug-auto-launch<PHONE_NUMBER>010	0	732
code/extHost/didLoadExtensionCode/vscode.debug-auto-launch<PHONE_NUMBER>013	3	735
code/extHost/willLoadExtensionCode/vscode.git<PHONE_NUMBER>013	0	735
code/extHost/didLoadExtensionCode/vscode.git<PHONE_NUMBER>072	59	794
code/extHost/willLoadExtensionCode/GitHub.vscode-pull-request-github<PHONE_NUMBER>073	1	795
code/extHost/didLoadExtensionCode/GitHub.vscode-pull-request-github<PHONE_NUMBER>154	81	876
code/extHost/willLoadExtensionCode/PKief.material-icon-theme<PHONE_NUMBER>155	1	877
code/extHost/didLoadExtensionCode/PKief.material-icon-theme<PHONE_NUMBER>172	17	894
code/extHost/willLoadExtensionCode/ms-vscode.cpptools<PHONE_NUMBER>172	0	894
code/extHost/didLoadExtensionCode/ms-vscode.cpptools<PHONE_NUMBER>303	131	1025
code/extHost/willLoadExtensionCode/standard.vscode-standard<PHONE_NUMBER>303	0	1025
code/extHost/didLoadExtensionCode/standard.vscode-standard<PHONE_NUMBER>453	150	1175
code/extHost/willLoadExtensionCode/WakaTime.vscode-wakatime<PHONE_NUMBER>453	0	1175
code/extHost/didLoadExtensionCode/WakaTime.vscode-wakatime<PHONE_NUMBER>528	75	1250
code/extHost/willLoadExtensionCode/WallabyJs.quokka-vscode<PHONE_NUMBER>528	0	1250
code/extHost/didLoadExtensionCode/WallabyJs.quokka-vscode<PHONE_NUMBER>529	1	1251
code/extHost/willLoadExtensionCode/Wattenberger.footsteps<PHONE_NUMBER>530	1	1252
code/extHost/didLoadExtensionCode/Wattenberger.footsteps<PHONE_NUMBER>531	1	1253
code/extHost/willLoadExtensionCode/wayou.vscode-todo-highlight<PHONE_NUMBER>532	1	1254
code/extHost/didLoadExtensionCode/wayou.vscode-todo-highlight<PHONE_NUMBER>534	2	1256
code/extHost/willLoadExtensionCode/yatki.vscode-surround<PHONE_NUMBER>534	0	1256
code/extHost/didLoadExtensionCode/yatki.vscode-surround<PHONE_NUMBER>536	2	1258
code/extHost/willActivateExtension/vscode.microsoft-authentication<PHONE_NUMBER>540	4	1262
code/extHost/willActivateExtension/vscode.debug-auto-launch<PHONE_NUMBER>541	1	1263
code/extHost/willActivateExtension/vscode.git<PHONE_NUMBER>541	0	1263
code/extHost/willActivateExtension/GitHub.vscode-pull-request-github<PHONE_NUMBER>543	2	1265
code/extHost/willActivateExtension/PKief.material-icon-theme<PHONE_NUMBER>544	1	1266
code/extHost/willActivateExtension/ms-vscode.cpptools<PHONE_NUMBER>544	0	1266
code/extHost/willActivateExtension/standard.vscode-standard<PHONE_NUMBER>544	0	1266
code/extHost/willActivateExtension/WakaTime.vscode-wakatime<PHONE_NUMBER>544	0	1266
code/extHost/willActivateExtension/WallabyJs.quokka-vscode<PHONE_NUMBER>544	0	1266
code/extHost/willActivateExtension/Wattenberger.footsteps<PHONE_NUMBER>643	99	1365
code/extHost/willActivateExtension/wayou.vscode-todo-highlight<PHONE_NUMBER>643	0	1365
code/extHost/willActivateExtension/yatki.vscode-surround<PHONE_NUMBER>644	1	1366
code/extHost/didActivateExtension/vscode.debug-auto-launch<PHONE_NUMBER>664	20	1386
code/extHost/didActivateExtension/GitHub.vscode-pull-request-github<PHONE_NUMBER>664	0	1386
code/extHost/didActivateExtension/WakaTime.vscode-wakatime<PHONE_NUMBER>664	0	1386
code/extHost/didActivateExtension/WallabyJs.quokka-vscode<PHONE_NUMBER>665	1	1387
code/extHost/didActivateExtension/Wattenberger.footsteps<PHONE_NUMBER>665	0	1387
code/extHost/didActivateExtension/wayou.vscode-todo-highlight<PHONE_NUMBER>665	0	1387
code/extHost/didActivateExtension/yatki.vscode-surround<PHONE_NUMBER>665	0	1387
code/extHost/didActivateExtension/PKief.material-icon-theme<PHONE_NUMBER>677	12	1399
code/extHost/didActivateExtension/vscode.git<PHONE_NUMBER>684	7	1406
code/extHost/didActivateExtension/standard.vscode-standard<PHONE_NUMBER>720	36	1442
code/extHost/willLoadExtensionCode/vscode.github-authentication<PHONE_NUMBER>746	26	1468
code/extHost/didLoadExtensionCode/vscode.github-authentication<PHONE_NUMBER>770	24	1492
code/extHost/didActivateExtension/vscode.microsoft-authentication<PHONE_NUMBER>770	0	1492
code/extHost/didActivateExtension/ms-vscode.cpptools<PHONE_NUMBER>773	3	1495
code/extHost/willLoadExtensionCode/ms-vscode.js-debug<PHONE_NUMBER>783	10	1505
code/extHost/didLoadExtensionCode/ms-vscode.js-debug<PHONE_NUMBER>978	195	1700
code/extHost/willLoadExtensionCode/vscode.github<PHONE_NUMBER>979	1	1701
code/extHost/didLoadExtensionCode/vscode.github<PHONE_NUMBER>989	10	1711
code/extHost/willLoadExtensionCode/platformio.platformio-ide<PHONE_NUMBER>989	0	1711
code/extHost/didLoadExtensionCode/platformio.platformio-ide<PHONE_NUMBER>313	324	2035
code/extHost/willActivateExtension/vscode.github-authentication<PHONE_NUMBER>313	0	2035
code/extHost/willActivateExtension/ms-vscode.js-debug<PHONE_NUMBER>316	3	2038
code/extHost/willActivateExtension/vscode.github<PHONE_NUMBER>322	6	2044
code/extHost/willActivateExtension/platformio.platformio-ide<PHONE_NUMBER>322	0	2044
code/extHost/didActivateExtension/ms-vscode.js-debug<PHONE_NUMBER>322	0	2044
code/extHost/didActivateExtension/vscode.github<PHONE_NUMBER>322	0	2044
code/extHost/didActivateExtension/platformio.platformio-ide<PHONE_NUMBER>322	0	2044

Node Cached Data Stats
cached data used
cached data missed
cached data rejected
cached data created (lazy, might need refreshes)
prof-fcc4.extHost.cpuprofile.txt
prof-fcc4.main.cpuprofile.txt
prof-fcc4.renderer.cpuprofile.txt

Yeah, that's slowness in creating the renderer process

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/
(asking because I recently added some more perf timers)

I tested it and it is the same behavior. Do you need the profiling there too?

Yeah that would be great 👍

System Info

Code - Insiders: 1.56.0-insider (25785b97e533b15ae3b12e48aaf4187416437e62)
OS: win32(10.0.21354)
CPUs: AMD Ryzen 9 3900XT 12-Core Processor           (24 x 4300)
Memory(System): 31.92 GB(18.55GB free)
Memory(Process): 180.48 MB working set(155.43MB private, 1.89MB shared)
VM(likelihood): 0%
Initial Startup: true
Has 0 other windows
Screen Reader Active: false
Empty Workspace: true

Performance Marks

What
Duration
Process
Info

start => app.isReady
74
[main]
initial startup: true

nls:start => nls:end
1
[main]
initial startup: true

require(main.bundle.js)
117
[main]
initial startup: true

start crash reporter
21
[main]
initial startup: true

serve main IPC handle
3
[main]
initial startup: true

create window
58
[main]
initial startup: true, state: 0ms, widget: 20ms, show: 34ms

app.isReady => window.loadUrl()
258
[main]
initial startup: true

window.loadUrl() => begin to require(workbench.desktop.main.js)
2519
[main->renderer]
NewWindow

require(workbench.desktop.main.js)
795
[renderer]
cached data: NO, node_modules took 0ms

wait for window config
0
[renderer]
-

wait for shell environment
0
[renderer]
-

init storage (global & workspace)
28
[renderer]
-

init workspace service
58
[renderer]
-

register extensions & spawn extension host
493
[renderer]
-

restore viewlet
0
[renderer]
-

restore panel
0
[renderer]
-

restore & resolve visible editors
214
[renderer]
1: workbench.editors.untitledEditorInput

overall workbench load
504
[renderer]
-

workbench ready
4217
[main->renderer]
-

renderer ready
1376
[renderer]
-

shared process connection ready
0
[renderer->sharedprocess]
-

extensions registered
4569
[renderer]
-

Extension Activation Stats

Extension
Eager
Load Code
Call Activate
Finish Activate
Event
By

vscode.debug-auto-launch
true
5
0
11
*
vscode.debug-auto-launch

vscode.git
true
81
5
36
*
vscode.github

kamikillerto.vscode-colorize
true
55
5
1
*
kamikillerto.vscode-colorize

ms-vsliveshare.vsliveshare
true
570
0
781
*
ms-vsliveshare.vsliveshare

oderwat.indent-rainbow
true
2
0
1
*
oderwat.indent-rainbow

PKief.material-icon-theme
true
30
0
6
*
PKief.material-icon-theme

wayou.vscode-todo-highlight
true
4
1
0
*
wayou.vscode-todo-highlight

vscode.emmet
false
17
2
12
onStartupFinished
vscode.emmet

vscode.github
false
15
1
0
*
vscode.github

vscode.github-authentication
false
31
2
70
onAuthenticationRequest:github
vscode.github-authentication

vscode.merge-conflict
false
3
1
11
onStartupFinished
vscode.merge-conflict

vscode.microsoft-authentication
false
39
6
86
onAuthenticationRequest:microsoft
vscode.microsoft-authentication

ms-vscode-remote.remote-wsl-recommender
false
15
2
9
onStartupFinished
ms-vscode-remote.remote-wsl-recommender

ms-vscode.js-debug
false
281
14
1
onCommand:extension.js-debug.clearAutoAttachVariables
ms-vscode.js-debug

vscode.testing-editor-contributions
false
1
0
9
onStartupFinished
vscode.testing-editor-contributions

dbaeumer.vscode-eslint
false
25
0
9
onStartupFinished
dbaeumer.vscode-eslint

esbenp.prettier-vscode
false
90
8
1
onStartupFinished
esbenp.prettier-vscode

usernamehw.errorlens
false
3
1
0
onStartupFinished
usernamehw.errorlens

Raw Perf Marks: main
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>877	0	0
code/didStartMain<PHONE_NUMBER>475	598	598
code/willStartCrashReporter<PHONE_NUMBER>494	19	617
code/didStartCrashReporter<PHONE_NUMBER>515	21	638
code/mainAppReady<PHONE_NUMBER>549	34	672
code/willGenerateNls<PHONE_NUMBER>554	5	677
code/didGenerateNls<PHONE_NUMBER>555	1	678
code/willLoadMainBundle<PHONE_NUMBER>556	1	679
code/fork/willLoadCode<PHONE_NUMBER>573	17	696
code/registerFilesystem/file<PHONE_NUMBER>668	95	791
code/didLoadMainBundle<PHONE_NUMBER>673	5	796
code/willStartMainServer<PHONE_NUMBER>686	13	809
code/didStartMainServer<PHONE_NUMBER>689	3	812
code/willCreateCodeWindow<PHONE_NUMBER>746	57	869
code/willRestoreCodeWindowState<PHONE_NUMBER>747	1	870
code/didRestoreCodeWindowState<PHONE_NUMBER>747	0	870
code/willCreateCodeBrowserWindow<PHONE_NUMBER>748	1	871
code/didCreateCodeBrowserWindow<PHONE_NUMBER>768	20	891
code/willMaximizeCodeWindow<PHONE_NUMBER>768	0	891
code/didMaximizeCodeWindow<PHONE_NUMBER>802	34	925
code/didCreateCodeWindow<PHONE_NUMBER>804	2	927
code/willOpenNewWindow<PHONE_NUMBER>807	3	930

Raw Perf Marks: renderer
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>808	0	0
code/didStartRenderer<PHONE_NUMBER>316	2508	2508
code/willWaitForWindowConfig<PHONE_NUMBER>317	1	2509
code/didWaitForWindowConfig<PHONE_NUMBER>317	0	2509
code/willShowPartsSplash<PHONE_NUMBER>318	1	2510
code/didShowPartsSplash<PHONE_NUMBER>319	1	2511
code/willLoadWorkbenchMain<PHONE_NUMBER>326	7	2518
code/willWaitForShellEnv<PHONE_NUMBER>121	795	3313
code/didWaitForShellEnv<PHONE_NUMBER>121	0	3313
code/didLoadWorkbenchMain<PHONE_NUMBER>121	0	3313
code/registerFilesystem/file<PHONE_NUMBER>126	5	3318
code/registerFilesystem/vscode-userdata<PHONE_NUMBER>127	1	3319
code/willInitWorkspaceService<PHONE_NUMBER>130	3	3322
code/willInitStorage<PHONE_NUMBER>132	2	3324
code/didInitStorage<PHONE_NUMBER>160	28	3352
code/didInitWorkspaceService<PHONE_NUMBER>188	28	3380
code/willStartWorkbench<PHONE_NUMBER>188	0	3380
code/LifecyclePhase/Ready<PHONE_NUMBER>191	3	3383
code/registerFilesystem/trustedDomains<PHONE_NUMBER>300	109	3492
code/willRestoreEditors<PHONE_NUMBER>477	177	3669
code/willLoadExtensions<PHONE_NUMBER>551	74	3743
code/didRestoreEditors<PHONE_NUMBER>691	140	3883
code/LifecyclePhase/Restored<PHONE_NUMBER>691	0	3883
code/didStartWorkbench<PHONE_NUMBER>692	1	3884
code/didRemovePartsSplash<PHONE_NUMBER>692	0	3884
code/willConnectSharedProcess<PHONE_NUMBER>712	20	3904
code/willHandleExtensionPoints<PHONE_NUMBER>858	146	4050
code/didHandleExtensionPoints<PHONE_NUMBER>035	177	4227
code/didLoadExtensions<PHONE_NUMBER>044	9	4236

Raw Perf Marks: localExtHost
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>586	0	0
code/fork/start<PHONE_NUMBER>746	160	160
code/fork/willLoadCode<PHONE_NUMBER>775	29	189
code/extHost/willConnectToRenderer<PHONE_NUMBER>085	310	499
code/extHost/didConnectToRenderer<PHONE_NUMBER>085	0	499
code/extHost/didWaitForInitData<PHONE_NUMBER>140	55	554
code/extHost/didCreateServices<PHONE_NUMBER>149	9	563
code/extHost/willWaitForConfig<PHONE_NUMBER>152	3	566
code/extHost/didWaitForConfig<PHONE_NUMBER>190	38	604
code/extHost/didInitAPI<PHONE_NUMBER>199	9	613
code/extHost/didInitProxyResolver<PHONE_NUMBER>199	0	613
code/extHost/ready<PHONE_NUMBER>199	0	613
code/extHost/willLoadExtensionCode/vscode.microsoft-authentication<PHONE_NUMBER>208	9	622
code/extHost/didLoadExtensionCode/vscode.microsoft-authentication<PHONE_NUMBER>247	39	661
code/extHost/willLoadExtensionCode/vscode.debug-auto-launch<PHONE_NUMBER>247	0	661
code/extHost/didLoadExtensionCode/vscode.debug-auto-launch<PHONE_NUMBER>252	5	666
code/extHost/willLoadExtensionCode/vscode.git<PHONE_NUMBER>252	0	666
code/extHost/didLoadExtensionCode/vscode.git<PHONE_NUMBER>333	81	747
code/extHost/willLoadExtensionCode/kamikillerto.vscode-colorize<PHONE_NUMBER>333	0	747
code/extHost/didLoadExtensionCode/kamikillerto.vscode-colorize<PHONE_NUMBER>388	55	802
code/extHost/willLoadExtensionCode/ms-vsliveshare.vsliveshare<PHONE_NUMBER>389	1	803
code/extHost/didLoadExtensionCode/ms-vsliveshare.vsliveshare<PHONE_NUMBER>959	570	1373
code/extHost/willLoadExtensionCode/oderwat.indent-rainbow<PHONE_NUMBER>960	1	1374
code/extHost/didLoadExtensionCode/oderwat.indent-rainbow<PHONE_NUMBER>962	2	1376
code/extHost/willLoadExtensionCode/PKief.material-icon-theme<PHONE_NUMBER>962	0	1376
code/extHost/didLoadExtensionCode/PKief.material-icon-theme<PHONE_NUMBER>992	30	1406
code/extHost/willLoadExtensionCode/wayou.vscode-todo-highlight<PHONE_NUMBER>992	0	1406
code/extHost/didLoadExtensionCode/wayou.vscode-todo-highlight<PHONE_NUMBER>996	4	1410
code/extHost/willActivateExtension/vscode.microsoft-authentication<PHONE_NUMBER>006	10	1420
code/extHost/willActivateExtension/vscode.debug-auto-launch<PHONE_NUMBER>012	6	1426
code/extHost/willActivateExtension/vscode.git<PHONE_NUMBER>012	0	1426
code/extHost/willActivateExtension/kamikillerto.vscode-colorize<PHONE_NUMBER>017	5	1431
code/extHost/willActivateExtension/ms-vsliveshare.vsliveshare<PHONE_NUMBER>022	5	1436
code/extHost/willActivateExtension/oderwat.indent-rainbow<PHONE_NUMBER>022	0	1436
code/extHost/willActivateExtension/PKief.material-icon-theme<PHONE_NUMBER>022	0	1436
code/extHost/willActivateExtension/wayou.vscode-todo-highlight<PHONE_NUMBER>022	0	1436
code/extHost/didActivateExtension/vscode.debug-auto-launch<PHONE_NUMBER>023	1	1437
code/extHost/didActivateExtension/kamikillerto.vscode-colorize<PHONE_NUMBER>023	0	1437
code/extHost/didActivateExtension/oderwat.indent-rainbow<PHONE_NUMBER>023	0	1437
code/extHost/didActivateExtension/wayou.vscode-todo-highlight<PHONE_NUMBER>023	0	1437
code/extHost/didActivateExtension/PKief.material-icon-theme<PHONE_NUMBER>028	5	1442
code/extHost/didActivateExtension/vscode.git<PHONE_NUMBER>053	25	1467
code/extHost/didActivateExtension/vscode.microsoft-authentication<PHONE_NUMBER>098	45	1512
code/extHost/willLoadExtensionCode/ms-vscode.js-debug<PHONE_NUMBER>107	9	1521
code/extHost/didLoadExtensionCode/ms-vscode.js-debug<PHONE_NUMBER>388	281	1802
code/extHost/willLoadExtensionCode/vscode.github<PHONE_NUMBER>388	0	1802
code/extHost/didLoadExtensionCode/vscode.github<PHONE_NUMBER>403	15	1817
code/extHost/willActivateExtension/ms-vscode.js-debug<PHONE_NUMBER>412	9	1826
code/extHost/willActivateExtension/vscode.github<PHONE_NUMBER>426	14	1840
code/extHost/didActivateExtension/ms-vscode.js-debug<PHONE_NUMBER>427	1	1841
code/extHost/didActivateExtension/vscode.github<PHONE_NUMBER>427	0	1841
code/extHost/willLoadExtensionCode/vscode.github-authentication<PHONE_NUMBER>448	21	1862
code/extHost/didLoadExtensionCode/vscode.github-authentication<PHONE_NUMBER>479	31	1893
code/extHost/willActivateExtension/vscode.github-authentication<PHONE_NUMBER>483	4	1897
code/extHost/didActivateExtension/vscode.github-authentication<PHONE_NUMBER>555	72	1969
code/extHost/didActivateExtension/ms-vsliveshare.vsliveshare<PHONE_NUMBER>803	248	2217

Node Cached Data Stats
cached data used
cached data missed
cached data rejected
cached data created (lazy, might need refreshes)
prof-1303.extHost.cpuprofile.txt
prof-1303.main.cpuprofile.txt
prof-1303.renderer.cpuprofile.txt

Thanks, it looks like a lot of unexpected time is spend here:

Which seems to hint at something being slow in Electron as already pointed out.
Do you have a AV software configured that could be the culprit?

note I have also disabled AV completely, it is not caused by that!

i read all other issues, and in the first report, I said I have made sure it is not AV!

@bpasero I also did the check and reinstalled insiders, removed all config & all extensions. Still the same issue. Did not have this before 1.55 ... something changed ?

How does it perform from our exploration builds: https://az764295.vo.msecnd.net/exploration/37dee411c81abf7d8ecb28ffe218475c328578b8/VSCode-win32-x64-1.56.0-exploration.zip
?

@bpasero better, performance as I expect it!
window.loadUrl() => begin to require(workbench.desktop.main.js) | 219      | [main->renderer]          | NewWindow

OK looks like Electron 12 makes this considerably better for you. We plan to ship E12 to insiders in May.

I'll try to stay with the exploration build for now. Hope this works for daily use in corporate environment :/

@alexanderniebuhr can you provide the performance numbers with the archive version of insiders https://az764295.vo.msecnd.net/insider/ce791d27dc9889a392f4d29abefe9c53eb0b5129/VSCode-win32-x64-1.56.0-insider.zip

@deepak1556 seems to be normal performance as well
System Info

Code - Insiders: 1.56.0-insider (ce791d27dc9889a392f4d29abefe9c53eb0b5129)
OS: win32(10.0.21359)
CPUs: AMD Ryzen 9 3900XT 12-Core Processor           (24 x 4200)
Memory(System): 31.92 GB(25.01GB free)
Memory(Process): 193.68 MB working set(172.50MB private, 1.69MB shared)
VM(likelihood): 0%
Initial Startup: true
Has 0 other windows
Screen Reader Active: false
Empty Workspace: true

Performance Marks

What
Duration
Process
Info

start => app.isReady
59
[main]
initial startup: true

nls:start => nls:end
1
[main]
initial startup: true

require(main.bundle.js)
48
[main]
initial startup: true

start crash reporter
22
[main]
initial startup: true

serve main IPC handle
1
[main]
initial startup: true

create window
44
[main]
initial startup: true, state: 0ms, widget: 16ms, show: 27ms

app.isReady => window.loadUrl()
153
[main]
initial startup: true

window.loadUrl() => begin to require(workbench.desktop.main.js)
188
[main->renderer]
NewWindow

require(workbench.desktop.main.js)
219
[renderer]
cached data: YES, node_modules took 0ms

wait for window config
1
[renderer]
-

wait for shell environment
0
[renderer]
-

init storage (global & workspace)
16
[renderer]
-

init workspace service
25
[renderer]
-

register extensions & spawn extension host
133
[renderer]
-

restore viewlet
9
[renderer]
workbench.view.explorer

restore panel
0
[renderer]
-

restore & resolve visible editors
107
[renderer]
1: workbench.editors.untitledEditorInput

overall workbench load
230
[renderer]
-

workbench ready
878
[main->renderer]
-

renderer ready
486
[renderer]
-

shared process connection ready
0
[renderer->sharedprocess]
-

extensions registered
1038
[renderer]
-

Extension Activation Stats

Extension
Eager
Load Code
Call Activate
Finish Activate
Event
By

vscode.debug-auto-launch
true
3
0
4
*
vscode.debug-auto-launch

vscode.git
true
11
4
171
*
vscode.github

vscode.github
true
5
1
0
*
vscode.github

vscode.emmet
false
8
4
3
onStartupFinished
vscode.emmet

vscode.extension-editing
false
95
0
4
onLanguage:markdown
vscode.extension-editing

vscode.github-authentication
false
11
2
46
onAuthenticationRequest:github
vscode.github-authentication

vscode.markdown-language-features
false
87
4
0
onLanguage:markdown
vscode.markdown-language-features

vscode.merge-conflict
false
3
0
2
onStartupFinished
vscode.merge-conflict

vscode.microsoft-authentication
false
8
4
181
onAuthenticationRequest:microsoft
vscode.microsoft-authentication

ms-vscode-remote.remote-wsl-recommender
false
5
2
0
onStartupFinished
ms-vscode-remote.remote-wsl-recommender

ms-vscode.js-debug
false
117
10
0
onCommand:extension.js-debug.clearAutoAttachVariables
ms-vscode.js-debug

vscode.testing-editor-contributions
false
1
0
0
onStartupFinished
vscode.testing-editor-contributions

Raw Perf Marks: main
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>962	0	0
code/didStartMain<PHONE_NUMBER>022	60	60
code/willStartCrashReporter<PHONE_NUMBER>035	13	73
code/didStartCrashReporter<PHONE_NUMBER>057	22	95
code/mainAppReady<PHONE_NUMBER>081	24	119
code/willGenerateNls<PHONE_NUMBER>083	2	121
code/didGenerateNls<PHONE_NUMBER>084	1	122
code/willLoadMainBundle<PHONE_NUMBER>085	1	123
code/fork/willLoadCode<PHONE_NUMBER>095	10	133
code/registerFilesystem/file<PHONE_NUMBER>131	36	169
code/didLoadMainBundle<PHONE_NUMBER>133	2	171
code/willStartMainServer<PHONE_NUMBER>146	13	184
code/didStartMainServer<PHONE_NUMBER>147	1	185
code/willCreateCodeWindow<PHONE_NUMBER>189	42	227
code/willRestoreCodeWindowState<PHONE_NUMBER>190	1	228
code/didRestoreCodeWindowState<PHONE_NUMBER>190	0	228
code/willCreateCodeBrowserWindow<PHONE_NUMBER>190	0	228
code/didCreateCodeBrowserWindow<PHONE_NUMBER>206	16	244
code/willMaximizeCodeWindow<PHONE_NUMBER>206	0	244
code/didMaximizeCodeWindow<PHONE_NUMBER>233	27	271
code/didCreateCodeWindow<PHONE_NUMBER>233	0	271
code/willOpenNewWindow<PHONE_NUMBER>234	1	272

Raw Perf Marks: renderer
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>235	0	0
code/didStartRenderer<PHONE_NUMBER>414	179	179
code/willWaitForWindowConfig<PHONE_NUMBER>414	0	179
code/didWaitForWindowConfig<PHONE_NUMBER>415	1	180
code/willShowPartsSplash<PHONE_NUMBER>415	0	180
code/didShowPartsSplash<PHONE_NUMBER>418	3	183
code/willLoadWorkbenchMain<PHONE_NUMBER>422	4	187
code/willWaitForShellEnv<PHONE_NUMBER>641	219	406
code/didWaitForShellEnv<PHONE_NUMBER>641	0	406
code/didLoadWorkbenchMain<PHONE_NUMBER>641	0	406
code/registerFilesystem/file<PHONE_NUMBER>642	1	407
code/registerFilesystem/vscode-userdata<PHONE_NUMBER>642	0	407
code/willInitWorkspaceService<PHONE_NUMBER>644	2	409
code/willInitStorage<PHONE_NUMBER>644	0	409
code/didInitStorage<PHONE_NUMBER>660	16	425
code/didInitWorkspaceService<PHONE_NUMBER>669	9	434
code/willStartWorkbench<PHONE_NUMBER>670	1	435
code/LifecyclePhase/Ready<PHONE_NUMBER>671	1	436
code/registerFilesystem/trustedDomains<PHONE_NUMBER>702	31	467
code/willRestoreEditors<PHONE_NUMBER>793	91	558
code/willRestoreViewlet<PHONE_NUMBER>795	2	560
code/didRestoreViewlet<PHONE_NUMBER>804	9	569
code/didRestoreEditors<PHONE_NUMBER>900	96	665
code/LifecyclePhase/Restored<PHONE_NUMBER>900	0	665
code/didStartWorkbench<PHONE_NUMBER>900	0	665
code/didRemovePartsSplash<PHONE_NUMBER>900	0	665
code/willConnectSharedProcess<PHONE_NUMBER>912	12	677
code/willLoadExtensions<PHONE_NUMBER>927	15	692
code/willHandleExtensionPoints<PHONE_NUMBER>995	68	760
code/didHandleExtensionPoints<PHONE_NUMBER>054	59	819
code/didLoadExtensions<PHONE_NUMBER>060	6	825

Raw Perf Marks: localExtHost
Name	Timestamp	Delta	Total
code/timeOrigin<PHONE_NUMBER>952	0	0
code/fork/start<PHONE_NUMBER>008	56	56
code/fork/willLoadCode<PHONE_NUMBER>020	12	68
code/extHost/willConnectToRenderer<PHONE_NUMBER>174	154	222
code/extHost/didConnectToRenderer<PHONE_NUMBER>176	2	224
code/extHost/didWaitForInitData<PHONE_NUMBER>205	29	253
code/extHost/didCreateServices<PHONE_NUMBER>214	9	262
code/extHost/willWaitForConfig<PHONE_NUMBER>218	4	266
code/extHost/didWaitForConfig<PHONE_NUMBER>237	19	285
code/extHost/didInitAPI<PHONE_NUMBER>247	10	295
code/extHost/didInitProxyResolver<PHONE_NUMBER>247	0	295
code/extHost/ready<PHONE_NUMBER>247	0	295
code/extHost/willLoadExtensionCode/vscode.microsoft-authentication<PHONE_NUMBER>255	8	303
code/extHost/didLoadExtensionCode/vscode.microsoft-authentication<PHONE_NUMBER>263	8	311
code/extHost/willLoadExtensionCode/vscode.debug-auto-launch<PHONE_NUMBER>263	0	311
code/extHost/didLoadExtensionCode/vscode.debug-auto-launch<PHONE_NUMBER>266	3	314
code/extHost/willLoadExtensionCode/vscode.git<PHONE_NUMBER>266	0	314
code/extHost/didLoadExtensionCode/vscode.git<PHONE_NUMBER>277	11	325
code/extHost/willActivateExtension/vscode.microsoft-authentication<PHONE_NUMBER>279	2	327
code/extHost/willActivateExtension/vscode.debug-auto-launch<PHONE_NUMBER>283	4	331
code/extHost/willActivateExtension/vscode.git<PHONE_NUMBER>283	0	331
code/extHost/didActivateExtension/vscode.debug-auto-launch<PHONE_NUMBER>287	4	335
code/extHost/willLoadExtensionCode/ms-vscode.js-debug<PHONE_NUMBER>336	49	384
code/extHost/didLoadExtensionCode/ms-vscode.js-debug<PHONE_NUMBER>453	117	501
code/extHost/didActivateExtension/vscode.git<PHONE_NUMBER>458	5	506
code/extHost/willActivateExtension/ms-vscode.js-debug<PHONE_NUMBER>464	6	512
code/extHost/didActivateExtension/vscode.microsoft-authentication<PHONE_NUMBER>474	10	522
code/extHost/didActivateExtension/ms-vscode.js-debug<PHONE_NUMBER>474	0	522
code/extHost/willLoadExtensionCode/vscode.github<PHONE_NUMBER>486	12	534
code/extHost/didLoadExtensionCode/vscode.github<PHONE_NUMBER>491	5	539
code/extHost/willActivateExtension/vscode.github<PHONE_NUMBER>493	2	541
code/extHost/didActivateExtension/vscode.github<PHONE_NUMBER>494	1	542

Node Cached Data Stats
cached data used

C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\graceful-fs-b6fa6f371f63eef8c3cf7c3918ae5d25.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\main-d92b589578f9be7cb662d240f648f5b4.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\polyfills-09b0a18ac4b0308552e365b7d92a7c05.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\tas-client-umd-33ffba0283b90b04aa033ff3fcda6064.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\workbench.desktop.main-f95e468a03b3beb5f3b0ac3dedb4bf53.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\workbench.desktop.main.nls-9c750fca9e63b4808cc29172893e4a15.code

cached data missed

C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\clone-a5193b87d45dc5b6f5002f5b6719c714.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\legacy-streams-21839944b532390e1cacac298e9463d8.code
C:\Users\Alexander\AppData\Roaming\Code - Insiders\CachedData\ce791d27dc9889a392f4d29abefe9c53eb0b5129\main-cfe16405ad55f2cfb6fc8ff261265729.code

cached data rejected
cached data created (lazy, might need refreshes)

@deepak1556 wait this is weird. the insider installed with the system-installer is till loading very slow,
however extracted from the zip running without the installer in the same root folder as the installed one, it loads fast?

Yup thats what I wanted to confirm, pretty sure you are hitting the same issue as https://github.com/microsoft/vscode/issues/121319 based on the profiles you have attached in https://github.com/microsoft/vscode/issues/121377#issue-858705584.
Can you also attach the profiles for the insiders run from archive, to confirm if the difference is the jumplist call.

I am not sure if it is the same issue, but I found a way to reproduce slow startup times with archive version!
I attached both profiles (both archive, just different path on same hard drive C:), same OS. disabled AV completely!
SLOW:
prof-ad6a.extHost.cpuprofile.txt
prof-ad6a.main.cpuprofile.txt
prof-ad6a.renderer.cpuprofile.txt
FAST:
prof-5752.extHost.cpuprofile.txt
prof-5752.main.cpuprofile.txt
prof-5752.renderer.cpuprofile.txt

Thanks for the profiles, on the slow version the handleWindowsJumpList call takes about 4s while on the fast version it is around 80ms.
Can you provide the system paths from which you ran these versions, I would like to repro it on my machine.

The slow is just on
C:/VSCode
The fast is in
C:/Users/Alexander/Documents/VSCode
However it seems that the fast one can be on various different path, as long as it is in Users folder I guess..

@deepak1556 just tried Insiders User Wide Installer and it performs fast. So it actually confirms that it slows only on specific paths on hard drive

Thanks for confirming, I am unable to repro the issue on my system, I need to check whats taking the cpu cycle in the jumplist code path. Can you follow these steps to capture the system trace.

Download latest insiders and install it to the location that has slow startup
Make sure there are no running instances of the insiders application
Open Windows Performance Recorder from system start menu
Have the following settings

Start the recorder
Open the insiders application
Once the application has completely loaded, stop the recorder and save the profile
Send the profile to<EMAIL_ADDRESS>

@deepak1556 I would love to give some more insights on this but your instructions do not work, I am starting to think it is an issue with the Windows 10 Insiders Preview, I am running on :(
If I try to open the Windows Performance Recorder
i get Error code: 0x8007000e, but I do have more than 150GB free on C:

@deepak1556 I actually made it profile it. Check your inbox. Please keep me updated, I am very interested what you will find in the profile, and if you can identify the issue. If that is something related to VS Code or maybe a bug for the Windows 10 OS Team

Thanks, received.

@deepak1556 just to update you. latest Windows 10 Update, does not fix it. Still same issue
Edition	Windows 10 Pro for Workstations
Version	Dev
Installed on	4/22/2021
OS build	21364.1
Experience	Windows 10 Feature Experience Pack 321.9601.0.3

Windows 10 21359:

Windows 10 19041:

19041 trace was taken on my system, the amount of time spent on the jumplist path is not different on the above versions,  QQ: can you confirm if the profile was taken for slow startup ?

@deepak1556 yes I can confirm that it was taken for the slow version. You can see it here, that it took very long to start

check your inbox again. I also did a profile with the latest stable Version of VS Code. Non Insider.. Slow Start!

@alexanderniebuhr can you also attach the trace following steps at https://github.com/microsoft/vscode/issues/121344#issuecomment-823022230 , I think the problem lies elsewhere as the jumplist calls are clean in the ETW traces.

@deepak1556 let me know if I can provide anything else, i am happy to help as much as I can. I actually think it is something with VS Code, maybe in combination with Windows 10 Insiders (but it appeared randomly, nothing changed.. also the latest Update to Windows 210416, did not change)
I have two variants, uploaded
Code Stable System Wide Install: https://nbhrio-my.sharepoint.com/:u:/g/personal/alexander_nbhr_io/EQaDwrlW2p1Nhw_ikDTXihsBZxq7Dsumkvo5go2LSAP_pA?e=flIQ78
Insiders Archive on slow Path: https://nbhrio-my.sharepoint.com/:u:/g/personal/alexander_nbhr_io/EZgEimth7vBPvqrTtNd2Al8BOsPrn4JwCGPazvhkKDEFsQ?e=T8h8kJ

also to note for you, I am using Windows Defender. I disabled it completely, so it should not interfere and not cause the issue. VS Code was running fast before with it enabled.
But in case it is not disabled completely (i remember that you can't disable it unless you do some registry stuff),
i have the process and the path of the folders of the VS Code Instances in Exclude lists.

@deepak1556 do you have any updates? Do you need me to provide any other metrics and traces?

I have this issue too, It's so slow and not usable! I remove and install it again and it becomes OK for a while. but after using it for days it breaks again.

@navidnabavi The User Setup or Archive Version stay very usable for me, maybe use them as a workaround.
I am sure @deepak1556 will update later what causes this issue

@deepak1556 not 100% sure yet, but newest Windows 10 (21376.1) seems to be fixed it.. I have to do some more debugging
Edition	Windows 10 Pro for Workstations
Version	Dev
Installed on	07.05.2021
OS build	21376.1
Experience	Windows 10 Feature Experience Pack 321.11803.0.3

Ok it was just changed for some of the Instances.. still slow for most of them .. same behavior as before

Thanks for the update @alexanderniebuhr


Add support for other secure element chips

In order to provide more manufacturing flexibility, it would be good if we can support now secure element chips.
Specifically:

[ ] Runjet rjgt102wdp8
[ ] Maxim Integrated DS28C36Q+T / DS28C36BQ+T
[ ] TFLXTLS ATECC608B
[ ] TPM2.0 chips

Will also need updates to https://github.com/NebraLtd/hm-miner and https://github.com/NebraLtd/hm-diag and https://github.com/NebraLtd/hm-config and https://github.com/NebraLtd/hm-gwmfr

This is helped by https://github.com/helium/miner/pull/769

https://github.com/helium/gateway_mfr/issues/5

FYI @marvinmarnold

Other option...
Infineon-OPTIGA TRUST M SLS32AIA-DataSheet-v03_00-EN.pdf

IMHO, sticking to TPM would be better as it is less of a lock-in. We already got the Secure pHAT that we could re-purpose for this and fit onto a board.

@vpetersson that and TrustZone yes.
FYI here is a RockPi 4b based hotspot using TrustZone https://github.com/dewi-alliance/hotspot-manufacturers/pull/254
We should investigate further on our side


Convert to application does not seem to work correctly for me...

Hi there,
I'd love to get started with Bonobo, but fail at installing.
Following the install guide I try to convert the Bonobo.Git.Server folder to an application. The result should be like this image:

How ever, I end up with this:

The forms and interface parts never appear... What could I be doing wrong?
When trying to connect to the server after this, I get a 403 error:

403 - Forbidden: Access is denied.
You do not have permission to view this directory or page using the credentials that you supplied.

Help?

You don't appear to have any application pools, which may suggest you don't have something missing, like the .NET framework or ASP.NET components of IIS.
Have a look at #718
It often feels like no two installations of Windows + IIS are the same, so getting the list of prerequisites right is hard.

Hi Willdean,
Thank you for your quick response!
I actually do have application pools:

These are the roles I have installed:

I was expecting not to need classic asp or the .net 3.5 tools?

OK, sounds like you have the right stuff.  You do also need to make sure that the user that the app pool is running at has permission to the folder where you've put the Bonobo files.

Yup, done that too, this should be cutting it, right?

So, after converting, should I have just the bonobo.git.server application, or also the forms and interface ones?

I'm not sure what did the trick, but I installed all of these:

And now I get a logon screen!
Thanks!


refactor(network): change base uri, removing tables endpoint

Summary
The baseURIs include the tables/{chainId} endpoint, which shouldn't really be used. Instead, it should just be the true /api/v1 endpoint, attached to the correct gateway.
Details
See network.ts and baseURIs.
How it was tested
N/A
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Since this PR makes a tweak to network.ts, so I figured I'd call the following out in case there's a change we want to make with TablelandNetworkConfig types, described here. TL;DR—the TS compiler doesn't always like the string | number type when we use evm-tableland imports in the SDK, which was introduced when we added validatorPollingTimeouts. Thus, a @ts-expect-error is needed to resolve the issue...not a big deal but just noting the behavior.

Also, @brunocalza—do we really need the optimism-goerli-staging definition in these exports? That config info is only really relevant to and is already configured on the validator, right? Or, do we use @tableland/evm for internal testing purposes somewhere, too, and need it to exist in this package?

@joewagner I came across the changesets tool while making a PR in D1's ORM repo. It's a pretty nice experience because you just run npx changeset on your feature branch, which prompts you for major/minor/patch and a description of changes—this gets written to a .changeset/<file.md>. Then, when you merge the branch, it'll automatically handle publishing to npm, tags, and can update the package.json's version, too.
If you think it's worthwhile, I can try it out on this repo since the publishing action is broken, anyways. It's also supposed to be nice for monorepos, but I'm not sure if we need that with our lerna setup for the SDK/CLI/LT.

Also, @brunocalza—do we really need the optimism-goerli-staging definition in these exports? That config info is only really relevant to and is already configured on the validator, right? Or, do we use @tableland/evm for internal testing purposes somewhere, too, and need it to exist in this package?
edit: I suppose we do need it because we use that type def in the hardhat config, which we obv need in order to deploy to the staging network.

yeah, I guess you're right, we need it for deploying the contract

@joewagner I came across the changesets tool while making a PR in D1's ORM repo. It's a pretty nice experience because you just run npx changeset on your feature branch, which prompts you for major/minor/patch and a description of changes—this gets written to a .changeset/<file.md>. Then, when you merge the branch, it'll automatically handle publishing to npm, tags, and can update the package.json's version, too.
If you think it's worthwhile, I can try it out on this repo since the publishing action is broken, anyways. It's also supposed to be nice for monorepos, but I'm not sure if we need that with our lerna setup for the SDK/CLI/LT.

I'm not sure, but I think we tried changesets in the past and didn't end up going with it.  @carsonfarmer would remember better than me.
I'd prefer to just fix the publish action instead of introducing more tooling.  We publish this so infrequently that I've neglected to spend any time trying to fix the publish action.  If you want to work on that, feel free.  In the mean time let's publish this manually when its ready.


Fixing Bubbles Cut off

#18
I fixed bubbles in the chart getting cut off due to its SVG container boundary by passing overflow props to BubbleChart Component.

Thank you @PotLid for your contribution.


Spelling mistake in help output

For option -j it says

-j    File name of the final rendered front image
Default: back-render.png

I think you mean the name of the final rendered back image

Oh yes I do. Thank you for catching that for me.


processOverOutEvents throws error

v3.60.0-beta.4
the event was set for GAMEOBJECT_DRAG, and when you move your mouse out side of the canvas it will throw an error.
call stack:

caused by:

the canvas has a fixed size and set to center_both of the browser screen. so my mouse can be moved outside of the canvas easily.

Thank you for spending time reporting this issue. However, we've already fixed this in the master branch of Phaser and it will be part of the next official release.


Apply offset setting on UI layer

Description:
Apply offset setting on UI layer and not adjust datapoints in local database.

Closing https://github.com/ruuvi/com.ruuvi.station/issues/995 as this implementation will be fixed on this card

QA passed


Update schema + fixes (v4)

This PR address and updates some of the core.
Fixes https://github.com/zwave-js/ZWaveJS.NET/issues/46
Fixes https://github.com/zwave-js/ZWaveJS.NET/issues/45

Updates the schema to 1.33.0
Moves all event handlers to a task
Adds deviceConfig to the controller
Switch all JSON conversions to use ToObject<Type>()
Terminates zombie server process's before starting a new one
Renames the heal methods (Schema 1.33.0)
The method GetAvailableFirmwareUpdates has been updated to remove the API Key requirement
Employ the use of esbuild to address some ES imports during the binary build of the server

@spudwebb
This PR should address your findings.
The PR also signifiers an extremely potent leap towards a release of V4.
I am currently finishing of the Demo application, once that is done - we could be ready for a release (or at least a preview)

@georgeinva2004
This should also address your discussion points with firmware and ping

I'll continue fine tuning this PR, and will get it merged into V4


Custom Thumbnail size not working

I am changing the height and width inside style for the Thumbnail
const ProfileImage = ({size}) => {
  const userImage = require('./amy_walton.png');
     return (
	<Thumbnail
		source={ userImage }
		style={{ height: 150, width: 150 }}
	/>
     );
}

This is what's happening:

Why isn't it a circle anymore?

@rostyys If you see theme of Thumbnail
Max limit of height and width mentioned here is 80
So anything above this, you need to mention borderRadius along with height and width

We will add this in docs


Migrate FreeRTOS dependencies to bm_core in bmdk app main

There are more than 200 references to FreeRTOS.h in this repo that should migrate to use functions from bm_os.h. This is one example of how they can be migrated.

Ohhhhhhh looks pretty 🌹


feat: updates with probablity and severity info

Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[X] Follow the CONTRIBUTING Guide.
[X] You are listed as the author in your notebook or README file.

[X] Your account is listed in CODEOWNERS for the file(s).

[X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[ ] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[ ] Appropriate docs were updated (if necessary)

Fixes #790 🦕

FYI "SPII" is an abbreviation for "Sensitive Personally Identifiable Information" which is in our docs and copied in directly.


Add support for compute nodes with only a boot disk

@cdearborn @rpioso @digambar15

okay i will close this PR and raise new PR due to conflicts.


Incorrect / Misleading information

On Step 5 of this document, the wording needs to change. This is giving people the impression that no one is able to sign in at all. I’ve spoken to Microsoft reps in the past that have told me the same thing, however that’s clearly not the case. Step 5 is denoted with “direct sign-in is unnecessary”, however immediately before it states that they "won't be able to sign in".
So is signing in unnecessary, or is it not possible? That is not clear, and it should be for security reasons.
I found that sign in IS possible. The wording on this needs to change. Hopefully you can forward my concern to those able to modify this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58fb81a0-5744-18b2-1636-a41c771ef0db
Version Independent ID: fad4cd45-1a93-bfee-e82b-892752317056
Content: Convert a user mailbox to a shared mailbox
Content Source: Office365-Admin/email/convert-user-mailbox-to-shared-mailbox.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@officedocsbot assign @mypil

@celliott2012 - Thank you for submitting feedback.
I will get this issue over to the O365ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@celliott2012 -  I believe the content has been updated to add the changes that you requested for. Kindly check and let us know if your issue has been resolved. Thanks.

Hi @mypil , I looked over this really quick and it looks really good. I do like the linking to the Remove A Former Employee document as well, I think that is a great addition.
Thank you for being attentive to this.


Navbar search on enter key pressed

Hi, I've my code as suggested on http://materializecss.com/navbar.html for the search bar, and I've seen many solution on how to get the inputText value, but there is not actual documentation for this precise component, as the desired action is to get a text value from the input when user hits enter key.
By now, and as on the documentation for the navbar, if any text is written on the bar and the 'enter' key is pressed, the page will redirect to  "/?" (for example if I'm on the main localhost, it will redirect to localhost/?) and the search bar will be closed as normally.
Is there a way of controlling this through jQuery? (I'm using Angular with angular2-materilize, but their documentation only provides with example on simple inputs, and is not related with pressing the 'enter' key as they do not require this characteristic.

This may help you: https://stackoverflow.com/questions/13987300/how-to-trigger-enter-key-press-of-textbox
For how-to questions, please use StackOverflow.


Failed to start WebRTC stream: webrtc

When i start stream of my camera, it goes well, and after like 10s it gives me this error
Failed to start WebRTC stream: webrtc: streams: exec/rtsp [rtsp @ 0x7f79080000] method DESCRIBE failed: 404 Not Found [in#0 @ 0x7f79412b00] Error opening input: Server returned 404 Not Found Error opening input file rtsp://<IP_ADDRESS>:18554/camera.nvr2_main_orginal?audio. Error opening input files: Server returned 404 Not Found

I have the same issue. Trying to resolve it in a proper way.

Same issue here :(

Same issue on HomeAssistant

Same for me

I've found that if you disable the RTSP over TLS and this will get the streams going again. Not ideal but a work around for the interim until the RTSP over TLS is fixed.

 I strange because I can connect some cameras to view live but most show the picture and update when motion is detected but it wont show live I get the same error.

I'm having trouble reproducing this. Not sure if it's something with the latest update of HA or something else. Do you have any repro steps?

I think this did happen on the latest update. My error is a little different and complains about the URL markup:
Failed to start WebRTC stream: webrtc: streams: parse "rtsp://[[my username]]:[[my password here with special characters]]@<IP_ADDRESS>:554/cam/realmonitor?channel=1&subtype=0": invalid port ":[[my password here with special characters]]" after host, exec/rtsp [rtsp @ 0x7f632dbe0000] method DESCRIBE failed: 404 Not Found [in#0 @ 0x7f632de12c00] Error opening input: Server returned 404 Not Found Error opening input file rtsp://<IP_ADDRESS>:18554/camera.nvr_main?audio&source=ffmpeg:camera.nvr_main%23audio%3Dopus%23query%3Dlog_level%3Ddebug&log_level=debug. Error opening input files: Server returned 404 Not Found

My error is similar but on the overview page I can see the stream, when I click on it brings up a mini window showing the stream for 3 or 4 seconds and then I get.
Failed to start WebRTC stream: webrtc: streams: parse "rtsp://[Username]:[Password]@<IP_ADDRESS>:554/cam/realmonitor?channel=1&subtype=0": net/url: invalid userinfo, exec/rtsp [rtsp @ 0x7f9f5fbe0000] method DESCRIBE failed: 404 Not Found [in#0 @ 0x7f9f5fe12c00] Error opening input: Server returned 404 Not Found Error opening input file rtsp://<IP_ADDRESS>:18554/camera.9_back_garden_main?audio&source=ffmpeg:camera.9_back_garden_main%23audio%3Dopus%23query%3Dlog_level%3Ddebug&log_level=debug. Error opening input files: Server returned 404 Not Found

Hello all I believe i have found the issue. After staring at the error code
for long enough I noticed my password on there was wrong; the sepcial
characters were not showing up. I changed my camera password and removed
the (#) I had out. Deleted the camera re-added and now it works. I don't
want to change all my pws so I'm going to try to see if maybe putting it in
quotations will work or something
On Sun, Dec 8, 2024, 7:50 AM qvanlem @.***> wrote:

My error is similar but on the overview page I can see the stream, when I
click on it brings up a mini window showing the stream for 3 or 4 seconds
and then I get.
Failed to start WebRTC stream: webrtc: streams: parse
"rtsp://[Username]:[Password]@
<IP_ADDRESS>:554/cam/realmonitor?channel=1&subtype=0": net/url: invalid
userinfo, exec/rtsp [rtsp @ 0x7f9f5fbe0000] method DESCRIBE failed: 404 Not
Found [in#0 @ 0x7f9f5fe12c00] Error opening input: Server returned 404 Not
Found Error opening input file rtsp://
<IP_ADDRESS>:18554/camera.9_back_garden_main?audio&source=ffmpeg:camera.9_back_garden_main%23audio%3Dopus%23query%3Dlog_level%3Ddebug&log_level=debug.
Error opening input files: Server returned 404 Not Found
—
Reply to this email directly, view it on GitHub
https://github.com/rroller/dahua/issues/428#issuecomment-2525950110, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BKRORGWLYMLHF53ILQSIKVT2ERFA5AVCNFSM6AAAAABRYQKEOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVHE2TAMJRGA
.
You are receiving this because you commented.Message ID:
@.***>

I can confirm making a new user in my cameras with not special characters in the PW worked for me. I cant see why this works because I do have a camera that was working with the pw that had a # in it. I will just make new users for all my cameras as it will provide another small layer of security.

Strange! I already tried a new user with a pw without any special charachters and that didn´t help me :(

Strange! I already tried a new user with a pw without any special charachters and that didn´t help me :(
Still, whats even more strange is that i get the snapshot when looking at the entities and can download a current snapshot but when trying to load the stream it won´t let me.
UPDATE! Just tried this again after the latest HA update and can confirm that this works!

When you say it works.. does that mean you get the live video stream again? Or just that snapshot. What you have posted is what mine has looked like since it broke. I could see the snapshots but it does not load when clicked.

Strange! I already tried a new user with a pw without any special charachters and that didn´t help me :(

Still, whats even more strange is that i get the snapshot when looking at the entities and can download a current snapshot but when trying to load the stream it won´t let me.

UPDATE! Just tried this again after the latest HA update and can confirm that this works!

When you say it works.. does that mean you get the live video stream again? Or just that snapshot. What you have posted is what mine has looked like since it broke. I could see the snapshots but it does not load when clicked.

Yep, live video is working as well. Set up another user with a simple password without any special characters and it fired up again.

Strange! I already tried a new user with a pw without any special charachters and that didn´t help me :(

Still, whats even more strange is that i get the snapshot when looking at the entities and can download a current snapshot but when trying to load the stream it won´t let me.

UPDATE! Just tried this again after the latest HA update and can confirm that this works!

When you say it works.. does that mean you get the live video stream again? Or just that snapshot. What you have posted is what mine has looked like since it broke. I could see the snapshots but it does not load when clicked.

Yep, live video is working as well. Set up another user with a simple password without any special characters and it fired up again.

Glad to hear. I hope this gets fixed as I like having special characters even for the dummy accounts I made for HA. Unfortunately the doorbell can only have one user name a pw and to change it you have to factory rest it and set up again.


[Feature Request] Add a valid list of Royale CSS valid properties

Hi Josh,
In VSCode if I add to my settings.json a config like the following:
"css.lint.validProperties": ["IItemRenderer", "ISelectableItemRenderer"]
VScode consider IItemRenderer and ISelectableItemRenderer valid css properties removing warnings.
Could AS3&MXML extension add a list of Royale CSS valid properties on its own to avoid users configure this each time they install VSCode?
I think would be a nice addition
Thanks

Since it is a setting for CSS and not for AS3 or MXML, it could potentially cause issues with non-Royale projects that use CSS. With that in mind, I don't think that this belongs in the AS3 & MXML extension. Perhaps you could create a separate extension for Royale that adds this sort of things so that people can opt-in if they really want it.


Xcode Beta 6: Fails to compile. Cannot find type 'ASAuthorization' in scope

In AuthorizationAppleIDButton.swift, compilation fails with

Cannot find type 'ASAuthorization' in scope

This used to compile up until beta 5.

@prasannag are you building from Xcode or from the command line? What target are you building for?

I was able to reproduce this by running:
xcodebuild -scheme SwiftUIX build -configuration release -destination 'generic/platform=iOS Simulator’

@vmanot @Brett-Best  I am seeing this problem when building in Xcode, you are not able to reproduce it with Xcode?

@prasannag I need the following information from you:

Which Xcode version you're on.
Which compile target you're building for.
Whether you're building for Debug or Release.

@prasannag I could reproduce this compiling for the iOS Simulator using release configuration.

@vmanot

Xcode 12 Beta 6 (12A8189n)
Building for iOS (iPhone only)
Debug build configuration

@prasannag I am not able to reproduce it. Are you on the latest master, or are you on 0.1?

I can confirm that I am on latest master. Not sure how my configuration is different, will dig a bit more.

@prasannag we pushed some further updates to ease breakage on RELEASE builds for the simulator, but your case seems unique in that it's breaking on DEBUG as well. See if updating to master helps again.

Seeing this also. Same setup as @prasannag mentioned above. However, I'm only running into it when building for SwiftUI Previews, not for the simulator (or onto device).

@alexfringes @prasannag @pteasima I've created a temporary branch xcode12b6-patch  removing it altogether. This is an Xcode bug, and there doesn't seem to be a way around it.
So while we wait for the next beta, feel free to hop on to this branch to get your archives/previews working.

Closing as Xcode 12GM seems to have fixed this.

Thanks @vmanot! Amazing work.

@prasannag spoke too soon, it's still present. 😅


Fix csrilu02 memory leak

This leak is not as serious because in the typical iterative-solve workflow it'd be only run once. Unlike in #7039, no synchronization is needed here. cc: @anaruse

The simplest reproducer is to trigger the code path many times:
for i in range(10000):
    lu_t = linalg.spilu(A, fill_factor=1)

with a sparse matrix A.

/test mini

Hmmm it seems the mempool tests overflowed, I wonder why...

I can reproduce the error locally with this command
$ pytest tests/cupy_tests/test_cusparse.py tests/cupy_tests/cuda_tests/test_memory.py

Need some time to look into it.

/test all

/test all

/test full

Keeping my notes here since I need to attend to other things (cc @anaruse).

This overflow happens because when computing free_bytes, we query both total_bytes and used_bytes and compute their difference (total_bytes - used_bytes), and the former is 0 but the latter is not. I asked internally and this is not supposed to happen, so something is off.
I noticed #7039 is not the full fix. I monitor the MemoryAsyncPool usage (since cuSPARSE uses the async pool if available) and I noticed a leak of 8~32 bytes every time csrsm2 is called. Though I think this is likely a cuSPARSE bug (I used CUDA 11.4).
The first overflow happens at the shutdown time of TestMemoryAsyncPool.test_alloc. The memory we allocate (100 bytes, but internally we make it a 512B block) is correctly returned to the pool, but total_bytes goes off (set to 0) here. It doesn't matter if we synchronize at any point before querying the pool statistics or not.


NumberField should support labels

🙋 Feature Request

Like TextField/SearchField, NumberField should support Labels.
😯 Current Behavior

No labels :(
💁 Possible Solution

SearchField supports labels through Textfield, this may not be possible because there are stepper buttons, so label top align end may not be in the correct spot. Someone will need to try this.
If it's not possible, we'll need to figure out how to silence the console warning from textfield about labels.
<EMAIL_ADDRESS>💻 Examples

https://react-spectrum.adobe.com/react-spectrum/SearchField.html#example
🧢 Your Company/Team

🎁 Tracking Ticket (optional)

Dependent on https://github.com/adobe/react-spectrum/pull/731