docs: Package API Reports should show up on backstage.io/docs

All of our plugins and packages export APIs, and the API reports are generated for each package e.g. https://github.com/backstage/backstage/blob/master/packages/backend-common/api-report.md
It will be nice to see a version of these reports with documentation under https://backstage.io/docs/api/backend

So, it looks like the yarn build:api-docs command is supposed to generate these API references inside docs/references and docusaurus is able to display them locally!
For some reason, it seems to be disabled. Would love if someone can share the history behind it. cc @backstage/reviewers

The API reports are optimized for diffing and are therefore not great as docs, most importantly they don't contain any doc comments.
There's indeed the build:api-docs command, you can try it out and look around in docs/reference if you want. When @grantila and I were looking at this we stopped at shipping the API reports, since the docs required quite a bit more work. The main pain points of the generated docs are that they don't work very well with React components and that functions defined as const ... = (...) => ... show up as variables which produce considerably worse documentation. Overall variable docs aren't great, meaning it's not that good for API References either.
The docs generation in API extractor is prolly the best one around still, so I think we should move forward with it, but we need to refactor a bunch of code and possibly create our own markdown generator for it to generate decent docs. It's not a huge amount of work but it hasn't received priority so far

Thanks for the context @Rugvip !

Potentially closed by https://github.com/backstage/backstage/pull/7150 ?


add drawer-toggle to bower main block

This seems to be causing that the component is not published in npm package, making vaadin-app-layout-flow fail with flow 2.0

This change is

bower.json has nothing to do with publishing to npm.
Also there is no "theme/material/vaadin-drawer-toggle.html".
The drawer-toggle JS files are already published to npm correctly as you can see if you try to install:
npm i<EMAIL_ADDRESS>
These files were introducted in<EMAIL_ADDRESS>They are not in any stable version yet. Latest stable is 1.0.2.
Closing this PR as it doesn't fix anything and everything seems to be good in npm already.


Add device-width option

device-width is too complicated and hard to manage with profile option only.
It's better that users can set any value directly.
// iPhone 6 Plus
new Dyframe(element, {
  width: 980,
  deviceWidth: 414
});

Closed by a2d8b9e566064e2241bf0e9a4ec01d5bf5cf6918.
This will be released on v0.3.0.


Fix overflowing text in calendar view on schedule page

Actual Behaviour

Expected Behaviour
The text should not overflow outside the session.

I understand the issue and would like to take this up.It will be a good introduction to the project.

@geekyd could you assign this to me?

@zamhaq Please coordinate with @shubhshrma as he has already claimed the issue.

Yeah @zamhaq if you want we can work together but i won't like to leave this as I already started on it and it seems solvable as a newcomer.

@shubhshrma Its ok. You can work on it then.

@geekyd do we want the text in all boxes (in calendar view of schedule) to be  only a single line and hide all overflowing text after ... ? This would amount to majority of box space remain empty.

The first PR resulted in the disappearance of most of the text as "...". The implementation is not how it is supposed to be. If there is enough space there should be a line break - as it was before. I am reopening this issue therefore.


playing with the output repository lets me delete my whole project

If I accidentally set the output repo to my project directory, and then set it back to the right location, the IDE will helpfully offer to delete my whole project for me. If you don't very carefully read the message, you will just click OK.

Fixed, I also changed the dialog to not show when the previous output directory was a source folder.

Thanks!


fixed #1226

Issue:

Hello @mg143pavankumar thank you for contributing. First, you should know that you should comment on an issue to claim it and be assigned to it before working on it. Second, You have a lot of unnecessary changes due to changing of formatting of files. I'll be closing this PR. If you still want to work on it please comment on the issue first to be assigned and then make sure you only commit what is necessary for the fix of the issue.

Hello @mg143pavankumar thank you for contributing. First, you should know that you should comment on an issue to claim it and be assigned to it before working on it. Second, You have a lot of unnecessary changes due to changing of formatting of files. I'll be closing this PR. If you still want to work on it please comment on the issue first to be assigned and then make sure you only commit what is necessary for the fix of the issue.


finalizeSale should be callable by everyone but requires admin sender

    event FinalizeSale();
    // function is callable by everyone
    function finalizeSale() {
        require( saleEnded() );
        require( msg.sender == admin );

It would make sense to allow anyone to call finalizeSale once the sale has ended, in case the admin is not available for any reason, but this function still requires msg.sender==admin.

We consider it. But decided not to. We will first verify user didnt send tokens to the contract by mistake and only then burn the remaining tokens.
It is true that in theory tokens are not tranferable till end of token sale. But still, we decided to be extra careful.
The down side is that a trust is now needed. But in token sale a trust in the issuer is needed anyway.


Micro kernel elementwise math ops issues (abs, sin, cos, log, sqrt, tanh)

@tensorflow/micro
The math ops in elementwise.cc seem a little askew.
Firstly AbsEval, which calls std::abs
TfLiteStatus AbsEval(TfLiteContext* context, TfLiteNode* node) {
  return EvalNumeric(context, node, std::abs);
}

The math.h int abs(int j) is an integer function, what is probably intended is fabs, or better still float fabsf(float x) : return the absolute value of the floating-point number x.
The other float operations are actually referencing the double valued functions, e.g.
TfLiteStatus SinEval(TfLiteContext* context, TfLiteNode* node) {
  return EvalNumeric(context, node, std::sin);
}

would be better referencing std::sinf, which is the float-valued counterpart. Same for cosf, logf, and sqrtf.
Unfortunately changing e.g. std::cos to std::cosf will not compile on gcc, due to an issue in the <cmath> header. So to make it compile with gcc-based compilers the include should be changed to #include <math.h> and the functions referenced without std:: prefix.
I will make a PR that also includes the TANH op.

@pingdynasty This is a micro related issue,Please post this in micro repository  ..Thanks!


Cannot mount user-defined volumes into setup-replica-data-directory initContainer

In order to use mutually authenticated TLS and/or cert authentication for the replication role, it is necessary to mount the client certificates (or at least the root certificate, for the case of only authenticating the server) into the setup-replica-data-directory initContainer for the replica StatefulSets so that the copy_primary_data_to_replica.sh script (see below) can be overridden to make use of the client certificates in the DSN for the pg_basebackup command.
At present, there is no apparent way to mount user-defined volumes into the initContainer. I would like to request a feature to include the user-defined volumes from the volumes item of the Kubegres spec in the setup-replica-data-directory initContainer.
I would be willing to write the code to support this change and submit a PR if desired, however I would like feedback on the proposed change.
This change proposal would resolve #92 and I expect it will be necessary in the future to support @movitto's attempts to get TLS working for a multi-node cluster, as #85 concerns a single-replica kubegres deployment.
https://github.com/reactive-tech/kubegres/blob/b733b736b5845679250b121cdbf43986842445ef/controllers/spec/template/yaml/BaseConfigMapTemplate.yaml#L196-L219

I'm now realizing the same issue exists for the database backup cron job, so that would need to be added to the scope of changes in order to incorporate this feature.


I'm confused

You have closed several issues asking that are asking for updates, but your read me explicitly states not to modify the JSONs.

FYI: It says it in the README. Please update the (plain) source text e.g. cup.txt (and NOT the generated JSON files - they will get overwritten with every update).  Learn more about the football.db @ http://openfootball.github.io/.


Close socket before client get all data when handler FourLetterWordCmd

RaftKeeper version
2.0.3
Description
Get Connection reset when using FourLetterWordCmd
How to reproduce
echo stat|nc <IP_ADDRESS> 2181
RaftKeeper version: RaftKeeper v2.0.4
Clients:
<IP_ADDRESS>:38942(recved=4679652,sent=4685458)
<IP_ADDRESS>:24574(recved=5067762,sent=5075057)
<IP_ADDRESS>:36014(recved=5381825,sent=5388387)
<IP_ADDRESS>:64900(recved=5083387,sent=5090679)
<IP_ADDRESS>:48382(recved=5159396,sent=5166985)
<IP_ADDRESS>:53730(recved=5042596,sent=5049098)
<IP_ADDRESS>:15208(recved=5498836,sent=5505599)
<IP_ADDRESS>:52420(recved=5521839,sent=5529076)
<IP_ADDRESS>:10138(recved=5344873,sent=5350979)
<IP_ADDRESS>:50300(recved=5301892,sent=5308121)
<IP_ADDRESS>:23170(recved=5120888,sent=5127194)
<IP_ADDRESS>:23478(recved=0,sent=0)
<IP_ADDRESS>:34748(recved=5125987,sent=5133551)
<IP_ADDRESS>:25616(recved=14860,sent=14859)
Latency min/avg/max: 0/10/72518
Received:<PHONE_NUMBER>
Sent :<PHONE_NUMBER>
Connections: 13
Outstanding: 5
Zxid:<PHONE_NUMBER>77
Mode: leader
Node count: 13365943
Ncat: Connection reset by peer.

When nc sending data to server, it will half close the connection, and waiting the result.  But RaftKeeper did not recoginze the half connection and it may close the connection in advance.


cmd+f in the Monaco Editor,  find/search box not appearing

I'm unable to see the search bar in the code editor when executing Cmd + f.
Is there any options I need to pass?

@anikdutta16 Is it because the focus is not in the editor?


tomldecodeerror while using plugin generator

Hi while running plugin generator i am seeing bellow error.  any inputs on how to fix this issue ?.

Looks like Readme is old, It's not showing current options list.

Yes. Issue got fixed. Thank you.


DTLZ

I was wondering are you have a plan to implement the pareto front of DTLZ5, DTLZ6, DTLZ7?
when I tried to get the pareto font of those functions with 5 objectives, I got "Not implemented yet." error.

I will make it short currently this is not on the agenda. In theory, this needs to be a method to work for any number of objectives which is more challenging to implement by itself.
However, if you know of a solution I would be very happy to look at a pull request!


[RFC] mbedtls: Add CONFIG_MBEDTLS_SSL_MAX_CONTENT_LEN

This value allows to set max payload length of a TLS protocol
message, and passed thru to mbedTLS as MBEDTLS_SSL_MAX_CONTENT_LEN
setting. The only safe value is 16384, which translates to 32KB
of RAM required just for mbedTLS input/output buffers. Any other
value can be configured only per a particular application
(e.g. knowing that it won't pass more than spefific amount of
data at once and/or won't connect to a server with a long cert
chain). Previosuly, we had quite an adhoc and inflexible config
with random values for that setting, based on protocol.
Note that while the safe value is 16384, "backward compatible"
default of 1500 is used (good for DTLS on the other hand).
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Further clean up along the lines of https://github.com/zephyrproject-rtos/zephyr/pull/6219, https://github.com/zephyrproject-rtos/zephyr/pull/6221

Codecov Report

Merging #6225 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6225   +/-   ##
=======================================
  Coverage   52.91%   52.91%
=======================================
  Files         414      414
  Lines       40355    40355
  Branches     7807     7807
=======================================
  Hits        21355    21355
  Misses      15784    15784
  Partials     3216     3216

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1fc5c2...06e9d8f. Read the comment docs.

@pfalcon This looks very similar to the CoAP specific commit: https://github.com/zephyrproject-rtos/zephyr/commit/2fc554b8fcd37e589448010ff4dfab4affff2af4
I wonder if we should remove the extra config from the CoAP lib and re-use this config?

I wonder if we could remove the coap specific config in favor of this "mini" config which could be #ifdef'd for features requiring TCP(TLS) / UDP(DTLS).  So that if TCP isn't selected it would be the equivalent of the coap config for DTLS.

@pfalcon This looks very similar to the CoAP specific commit: 2fc554b
I wonder if we should remove the extra config from the CoAP lib and re-use this config?

Thanks for the pointer, that definitely would be in the scope of this PR, I'll look into adding it.

So that if TCP isn't selected it would be the equivalent of the coap config for DTLS.

I had an idea like, because I'd really like to have a default of 16384 ;-). Then, if TCP is not selected, we can have a default of 1500.
That's all a bit brave of course without changing mbedTLS itself (e.g. https://github.com/ARMmbed/mbedtls/pull/1368). I've marked this as 1.12, so we have some time to think it all.

@pfalcon correction on my part: I believe that config-coap.h is a trimmed down version of config-mini-dtls1_2.h (though the diff looks messy).

Adding this new config option llooks very reasonable so +1 from me for this one.

@mike-scott, @jukkar : I've refactored COAP-specific setting to use the generic one instead. In my list, this should be ready to merge. Please re-review.


OSX debugging

The problem does not occur on linux.
https://github.com/microsoft/mimalloc/blob/master/src/alloc.c#L212
(lldb) r
Process 93543 launched: './bin/arangodbtests' (x86_64)
mimalloc: option 'secure': 0
mimalloc: option 'pool_commit': 0
mimalloc: process init: 0x7fffc980c3c0
mimalloc: debug level : 1
mimalloc: option 'show_errors': 1
mimalloc: error: trying to mi_free a pointer that does not point to a valid heap space: 0x111040000
mimalloc: assertion failed: at "/Users/jenkins/arangodb/3rdParty/mimalloc/src/options.c":121, _mi_error_message
  assertion: "false"
Process 93543 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fffc0a21d42 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fffc0a21d42 <+10>: jae    0x7fffc0a21d4c            ; <+20>
    0x7fffc0a21d44 <+12>: movq   %rax, %rdi
    0x7fffc0a21d47 <+15>: jmp    0x7fffc0a1acaf            ; cerror_nocancel
    0x7fffc0a21d4c <+20>: retq
Target 0: (arangodbtests) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x00007fffc0a21d42 libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fffc0b0f457 libsystem_pthread.dylib`pthread_kill + 90
    frame #2: 0x00007fffc0987420 libsystem_c.dylib`abort + 129
    frame #3: 0x00000001055e339f arangodbtests`_mi_assert_fail(assertion="false", fname="/Users/jenkins/arangodb/3rdParty/mimalloc/src/options.c", line=121, func="_mi_error_message") at options.c:136
    frame #4: 0x00000001055e3e24 arangodbtests`_mi_error_message(fmt="trying to mi_free a pointer that does not point to a valid heap space: %p\n") at options.c:121
    frame #5: 0x00000001055dfa53 arangodbtests`mi_free(p=0x0000000111040000) at alloc.c:212
    frame #6: 0x00000001055dfbc5 arangodbtests`_ZdlPv(p=0x0000000111040000) at alloc-override.c:90
    frame #7: 0x0000000105573910 arangodbtests`testing::internal::MakeAndRegisterTestInfo(test_case_name="ActiveFailover", name="creating_a_job_should_create_a_job_in_todo", type_param=0x0000000000000000, value_param=0x0000000000000000, code_location=(file = "/Users/jenkins/arangodb/tests/Agency/ActiveFailoverTest.cpp", line = 113), fixture_class_id=0x0000000109537728, set_up_tc=(arangodbtests`testing::Test::SetUpTestCase() at gtest.h:20190), tear_down_tc=(arangodbtests`testing::Test::TearDownTestCase() at gtest.h:20198), factory=0x0000000111020000)(), void (*)(), testing::internal::TestFactoryBase*) at gtest-all.cc:4053
    frame #8: 0x00000001000ae474 arangodbtests`::__cxx_global_var_init.29() at ActiveFailoverTest.cpp:113
    frame #9: 0x00000001000aee64 arangodbtests`_GLOBAL__sub_I_ActiveFailoverTest.cpp at ActiveFailoverTest.cpp:0
    frame #10: 0x000000010f80ca1b dyld`ImageLoaderMachO::doModInitFunctions(ImageLoader::LinkContext const&) + 385
    frame #11: 0x000000010f80cc1e dyld`ImageLoaderMachO::doInitialization(ImageLoader::LinkContext const&) + 40
    frame #12: 0x000000010f8084aa dyld`ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, char const*, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 338
    frame #13: 0x000000010f807524 dyld`ImageLoader::processInitializers(ImageLoader::LinkContext const&, unsigned int, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 138
    frame #14: 0x000000010f8075b9 dyld`ImageLoader::runInitializers(ImageLoader::LinkContext const&, ImageLoader::InitializerTimingList&) + 75
    frame #15: 0x000000010f7f947a dyld`dyld::initializeMainExecutable() + 195
    frame #16: 0x000000010f7fd8c6 dyld`dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 3966
    frame #17: 0x000000010f7f8249 dyld`dyldbootstrap::start(macho_header const*, int, char const**, long, macho_header const*, unsigned long*) + 470
    frame #18: 0x000000010f7f8036 dyld`_dyld_start + 54
(lldb)

In order to reproduce you could build the tests in this branch:
https://github.com/arangodb/arangodb/tree/feature/mimalloc

I am actually wondering if this might be a bug in our code.

Can't you put it in a debugger and take a look what exactly is happening? But it seems like there is memory being freed during global init (maybe because of a resize?).
Interesting points would be to know what is the state of the heap at that point or right before it, what allocated that memory. I completely don't know how the override works on osx, but we had some problems like that because of the ordering of the heap initialization and overrides.

Ah, that is no good! I am on it -- tomorrow I have access to a Mac and will look into it. For now, the message implies that a pointer is freed that perhaps was allocated using some other malloc? The  _ZdlPv routine is plain delete on a C++ object. (One thing it could be is that the overriding is kicking in too late where an object is allocated using the system malloc, and then freed by mimalloc.)

Can you compile the debug version with cmake ../..  -DMI_CHECK_FULL=ON  to enable all assertions?

By default, the macOS version uses "interpose" but only overrides the four basic functions, malloc, free, realloc and calloc -- I wonder if we need to interpose more functions, like the array new or something.

By running cmake as cmake ../..  -DMI_CHECK_FULL=ON -DMI_INTERPOSE=OFF we use malloc zones instead of interpose --maybe that will work? This is still more experimental though.

Tomorrow I will also look into it, but just wanted to offer some pointers. There is also the MI_TLS_RECURSE_GUARD that is enabled when MI_INTERPOSE is enabled which prevents recursion as the dylib loader in macOS tries to allocate memory itself (with mimalloc) for thread local storage while the mimalloc module is still being loaded ... :(

MI_INTERPOSE=OFF
cupertino:arangodb-build jenkins$ MIMALLOC_VERBOSE=1 ./bin/arangodbtests --gtest_filter=SimpleHttpClientCommunicatorTest.requests_are_properly_aborted
mimalloc: process init: 0x7fffc980c3c0
mimalloc: debug level : 3
mimalloc: option 'secure': 0
mimalloc: option 'pool_commit': 0
mimalloc: option 'page_reset': 0
mimalloc: option 'cache_reset': 0
Note: Google Test filter = SimpleHttpClientCommunicatorTest.requests_are_properly_aborted
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SimpleHttpClientCommunicatorTest
[ RUN      ] SimpleHttpClientCommunicatorTest.requests_are_properly_aborted
mimalloc: option 'show_errors': 3
mimalloc: error: trying to mi_free a pointer that does not point to a valid heap space: 0x7fd1b551e6f0
mimalloc: assertion failed: at "/Users/jenkins/arangodb/3rdParty/mimalloc/src/options.c":121, _mi_error_message
  assertion: "false"
Abort trap: 6 (core dumped)

MI_INTERPOSE=ON
cupertino:arangodb-build jenkins$ MIMALLOC_VERBOSE=1 ./bin/arangodbtests --gtest_filter=SimpleHttpClientCommunicatorTest.requests_are_properly_aborted
mimalloc: option 'secure': 0
mimalloc: option 'pool_commit': 0
mimalloc: assertion failed: at "/Users/jenkins/arangodb/3rdParty/mimalloc/src/page.c":101, _mi_page_is_valid
  assertion: "segment->thread_id == page->heap->thread_id"
Abort trap: 6 (core dumped)

I have just pulled the following change into the branch
https://github.com/arangodb/arangodb/commit/635437222856d631b74158269bae6dbf4eb227b5
That seems to resolve the problem here (The test fixture is using a builder in the constructor). It was made because we had issues with thread_local variables on windows.
Unfortunately we end up with a different error in curl.

Any idea why the allocations could be partially replaced?

Great -- thanks for the debug output. I am currently working on a mac book through these problems too and addressing various issues. My feeling is indeed that the system strdup calls an internal allocation routine... not sure. Also, I read somewhere that one cannot interpose functions in system libraries? So perhaps more is needed. For now, I will concentrate on making at least the basic scenarios work and protect against recursion in the thread local storage allocation.

I think the latest dev branch should now work with MI_INTERPOSE=ON on static-overload test. The dynamic one is still being worked on.

cupertino:arangodb-build jenkins$ cmake -DCMAKE_BUILD_TYPE=Debug -DMI_CHECK_FULL=ON -DMI_INTERPOSE=ON ../arangodb on our mimalloc branch
[100%] Built target arangodbtests
cupertino:arangodb-build jenkins$ MIMALLOC_VERBOSE=1 lldb -- ./bin/arangodbtests --gtest_filter=SimpleHttpClientCommunicatorTest.requests_are_properly_aborted
(lldb) target create "./bin/arangodbtests"
Current executable set to './bin/arangodbtests' (x86_64).
(lldb) settings set -- target.run-args  "--gtest_filter=SimpleHttpClientCommunicatorTest.requests_are_properly_aborted"
(lldb) r
Process 31879 launched: './bin/arangodbtests' (x86_64)
mimalloc: option 'secure': 0
mimalloc: option 'pool_commit': 0
mimalloc: assertion failed: at "/Users/jenkins/arangodb/3rdParty/mimalloc/src/page.c":101, _mi_page_is_valid
  assertion: "segment->thread_id == page->heap->thread_id"
Process 31879 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fffc0a21d42 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fffc0a21d42 <+10>: jae    0x7fffc0a21d4c            ; <+20>
    0x7fffc0a21d44 <+12>: movq   %rax, %rdi
    0x7fffc0a21d47 <+15>: jmp    0x7fffc0a1acaf            ; cerror_nocancel
    0x7fffc0a21d4c <+20>: retq
Target 0: (arangodbtests) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x00007fffc0a21d42 libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fffc0b0f457 libsystem_pthread.dylib`pthread_kill + 90
    frame #2: 0x00007fffc0987420 libsystem_c.dylib`abort + 129
    frame #3: 0x000000010563927f arangodbtests`_mi_assert_fail(assertion="segment->thread_id == page->heap->thread_id", fname="/Users/jenkins/arangodb/3rdParty/mimalloc/src/page.c", line=101, func="_mi_page_is_valid") at options.c:136
    frame #4: 0x0000000105631126 arangodbtests`_mi_page_is_valid(page=0x0000000111000060) at page.c:101
    frame #5: 0x0000000105633710 arangodbtests`mi_page_fresh_alloc(heap=0x00000001095f2058, pq=0x00000001095f2560, block_size=96) at page.c:219
    frame #6: 0x0000000105634872 arangodbtests`mi_page_fresh(heap=0x00000001095f2058, pq=0x00000001095f2560) at page.c:238
    frame #7: 0x00000001056345f3 arangodbtests`mi_page_queue_find_free_ex(heap=0x00000001095f2058, pq=0x00000001095f2560) at page.c:606
    frame #8: 0x000000010563327d arangodbtests`mi_find_free_page(heap=0x00000001095f2058, size=96) at page.c:634
    frame #9: 0x0000000105632e9f arangodbtests`_mi_malloc_generic(heap=0x00000001095f2058, size=96) at page.c:701
    frame #10: 0x00000001056351dd arangodbtests`_mi_page_malloc(heap=0x00000001095f2058, page=0x000000010783a238, size=96) at alloc.c:27
    frame #11: 0x00000001056353e4 arangodbtests`mi_heap_malloc_small(heap=0x00000001095f2058, size=96) at alloc.c:49
    frame #12: 0x00000001056355f0 arangodbtests`mi_heap_malloc(heap=0x00000001095f2058, size=96) at alloc.c:69
    frame #13: 0x000000010563496d arangodbtests`mi_malloc(size=96) at alloc.c:84
    frame #14: 0x0000000105634cc5 arangodbtests`_Znwm(n=96) at alloc-override.c:97
    frame #15: 0x000000010003edb5 arangodbtests`std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::allocate(unsigned long) [inlined] std::__1::__allocate(__size=96) at new:226
    frame #16: 0x000000010003edac arangodbtests`std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::allocate(unsigned long) [inlined] std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::_
_1::allocator<char> > >::allocate(this=0x0000000109639358, __n=4, (null)=0x0000000000000000) at memory:1771
    frame #17: 0x000000010003ece6 arangodbtests`std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::allocate(unsigned long) [inlined] std::__1::allocator_traits<std::__1::allocator<std::__1::basic_string<char, std::__1
::char_traits<char>, std::__1::allocator<char> > > >::allocate(__a=0x0000000109639358, __n=4) at memory:1526
    frame #18: 0x000000010003ecca arangodbtests`std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::allocate(this=0x0000000109639348 size=1, __n=4) at vector:925
    frame #19: 0x00000001000ae889 arangodbtests`::__cxx_global_var_init.7() [inlined] std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::vector(this=0x0000000109639348 size=1, __il=([0] = "/Target/ToDo/", [1] = "/Targ
et/Pending/", [2] = "/Target/Finished/", [3] = "/Target/Failed/")) at vector:1278
    frame #20: 0x00000001000ae79d arangodbtests`::__cxx_global_var_init.7() [inlined] std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::vector(this=0x0000000109639348 size=1, __il=([0] = "/Target/ToDo/", [1] = "/Targ
et/Pending/", [2] = "/Target/Finished/", [3] = "/Target/Failed/")) at vector:1272
    frame #21: 0x00000001000ae773 arangodbtests`::__cxx_global_var_init.7() at Job.h:43
    frame #22: 0x00000001000afa7c arangodbtests`_GLOBAL__sub_I_ActiveFailoverTest.cpp at ActiveFailoverTest.cpp:0
    frame #23: 0x000000010f892a1b dyld`ImageLoaderMachO::doModInitFunctions(ImageLoader::LinkContext const&) + 385
    frame #24: 0x000000010f892c1e dyld`ImageLoaderMachO::doInitialization(ImageLoader::LinkContext const&) + 40
    frame #25: 0x000000010f88e4aa dyld`ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, char const*, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 338
    frame #26: 0x000000010f88d524 dyld`ImageLoader::processInitializers(ImageLoader::LinkContext const&, unsigned int, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 138
    frame #27: 0x000000010f88d5b9 dyld`ImageLoader::runInitializers(ImageLoader::LinkContext const&, ImageLoader::InitializerTimingList&) + 75
    frame #28: 0x000000010f87f47a dyld`dyld::initializeMainExecutable() + 195
    frame #29: 0x000000010f8838c6 dyld`dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 3966
    frame #30: 0x000000010f87e249 dyld`dyldbootstrap::start(macho_header const*, int, char const**, long, macho_header const*, unsigned long*) + 470
    frame #31: 0x000000010f87e036 dyld`_dyld_start + 54

Good to hear there is progress -- just to confirm , the static-override test passes now right?
Also, the new error is "better" as it is an assertion failure in mimalloc (so happy we have thorough invariant checking!), and it seems to have started the actual program instead of having trouble during the dyld loading.
Actually, this could be related to another issue in the dev branch -- can you check you have the latest dev commits (in particular 1587058) ?  Also, cmake the debug version with -DMI_CHECK_FULL=ON to ensure all invariants are checked continuously.
Apologies for your trouble, but your feedback is very helpful to get automatic overriding to work well on macOS.

Sources upgraded maybe 3 hours ago from mimalloc/master
cupertino:bin jenkins$ MIMALLOC_VERBOSE=1 lldb -- ./static-override
(lldb) target create "./static-override"
Current executable set to './static-override' (x86_64).
(lldb) r
Process 34562 launched: './static-override' (x86_64)
mimalloc: process init: 0x7fffc980c3c0
mimalloc: debug level : 3
mimalloc: option 'secure': 0
mimalloc: option 'pool_commit': 0
mimalloc: option 'show_errors': 3
mimalloc: error: trying to mi_free a pointer that does not point to a valid heap space: 0x100100100
mimalloc: assertion failed: at "/Users/jenkins/arangodb/3rdParty/mimalloc/src/options.c":121, _mi_error_message
  assertion: "false"
Process 34562 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fffc0a21d42 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fffc0a21d42 <+10>: jae    0x7fffc0a21d4c            ; <+20>
    0x7fffc0a21d44 <+12>: movq   %rax, %rdi
    0x7fffc0a21d47 <+15>: jmp    0x7fffc0a1acaf            ; cerror_nocancel
    0x7fffc0a21d4c <+20>: retq
Target 0: (static-override) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x00007fffc0a21d42 libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fffc0b0f457 libsystem_pthread.dylib`pthread_kill + 90
    frame #2: 0x00007fffc0987420 libsystem_c.dylib`abort + 129
    frame #3: 0x000000010000f04f static-override`_mi_assert_fail(assertion="false", fname="/Users/jenkins/arangodb/3rdParty/mimalloc/src/options.c", line=121, func="_mi_error_message") at options.c:136
    frame #4: 0x000000010000fad4 static-override`_mi_error_message(fmt="trying to mi_free a pointer that does not point to a valid heap space: %p\n") at options.c:121
    frame #5: 0x000000010000a973 static-override`mi_free(p=0x0000000100100100) at alloc.c:212
    frame #6: 0x000000010000a8b5 static-override`free(p=0x0000000100100100) at alloc-override.c:64
    frame #7: 0x00000001000016c5 static-override`main at main-override.c:21
    frame #8: 0x00007fffc08f3235 libdyld.dylib`start + 1
(lldb)

Thank you for your time!

Ah.. frustrating.. on Linux/BSD systems this is so easy with LD_PRELOAD ... :-)
Anyway, I will keep working on this -- I have the macOS machine available maybe tomorrow but otherwise next week. Apologies for your troubles getting the overriding to work for you.

I there anything I can do? Should I try a newer version?

Ah sorry for not following up -- I have been just a bit too busy to look into it further. However, I have been working on improving the situation of dynamic overriding on Windows which should also help on the macOS side. I will try to look into it later today or otherwise tomorrow as I do have a macbook available now for testing.

No problem it was the same for me, I actually forgot to check the thread for some days ;)

I recently started to play with this project and I have a similar problem in macOS.
(lldb) bt 20
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=2, address=0x7ffeef3ffc00)
  * frame #0: 0x00007fff5d7757f8 libdyld.dylib`tlv_get_addr + 255
    frame #1: 0x00000001000d5be1 libmimalloc-debug.dylib`mi_get_default_heap at mimalloc-internal.h:157:10
    frame #2: 0x00000001000d5271 libmimalloc-debug.dylib`mi_malloc(size=8) at alloc.c:84:25
    frame #3: 0x00007fff5d7759f2 libdyld.dylib`tlv_allocate_and_initialize_for_key + 340
    frame #4: 0x00007fff5d775821 libdyld.dylib`tlv_get_addr + 296
    frame #5: 0x00000001000d5be1 libmimalloc-debug.dylib`mi_get_default_heap at mimalloc-internal.h:157:10
    frame #6: 0x00000001000d5271 libmimalloc-debug.dylib`mi_malloc(size=8) at alloc.c:84:25
    frame #7: 0x00007fff5d7759f2 libdyld.dylib`tlv_allocate_and_initialize_for_key + 340
    frame #8: 0x00007fff5d775821 libdyld.dylib`tlv_get_addr + 296
    frame #9: 0x00000001000d5be1 libmimalloc-debug.dylib`mi_get_default_heap at mimalloc-internal.h:157:10
    frame #10: 0x00000001000d5271 libmimalloc-debug.dylib`mi_malloc(size=8) at alloc.c:84:25
    frame #11: 0x00007fff5d7759f2 libdyld.dylib`tlv_allocate_and_initialize_for_key + 340
    frame #12: 0x00007fff5d775821 libdyld.dylib`tlv_get_addr + 296
<snip>
me #21813: 0x00000001000d5be1 libmimalloc-debug.dylib`mi_get_default_heap at mimalloc-internal.h:157:10
    frame #21814: 0x00000001000d5271 libmimalloc-debug.dylib`mi_malloc(size=8) at alloc.c:84:25
    frame #21815: 0x00007fff5d7759f2 libdyld.dylib`tlv_allocate_and_initialize_for_key + 340
    frame #21816: 0x00007fff5d775821 libdyld.dylib`tlv_get_addr + 296
    frame #21817: 0x00000001000d9d11 libmimalloc-debug.dylib`_mi_heap_init at init.c:185:30
    frame #21818: 0x00000001000d9bc2 libmimalloc-debug.dylib`mi_thread_init at init.c:315:7
    frame #21819: 0x00000001000d7819 libmimalloc-debug.dylib`mi_heap_get_default at heap.c:161:3
    frame #21820: 0x00000001000cf72d libmimalloc-debug.dylib`mi_stats_get_default at stats.c:262:21
    frame #21821: 0x00000001000cf6bd libmimalloc-debug.dylib`mi_stats_reset at stats.c:267:23
    frame #21822: 0x00000001000d9cf0 libmimalloc-debug.dylib`mi_process_init at init.c:370:3
    frame #21823: 0x00000001000d9bbd libmimalloc-debug.dylib`mi_thread_init at init.c:312:3
    frame #21824: 0x00000001000d7819 libmimalloc-debug.dylib`mi_heap_get_default at heap.c:161:3
    frame #21825: 0x00000001000d53be libmimalloc-debug.dylib`mi_free(p=0x0000000100200090) at alloc.c:220:21
    frame #21826: 0x00007fff5bfaaf06 libobjc.A.dylib`_NXHashRehashToCapacity + 214
    frame #21827: 0x00007fff5bfaae1f libobjc.A.dylib`NXHashInsert + 396
    frame #21828: 0x00007fff5bfaaaff libobjc.A.dylib`NXCreateHashTableFromZone + 310
    frame #21829: 0x00007fff5bfaa9c0 libobjc.A.dylib`NXCreateHashTable + 47
    frame #21830: 0x00007fff5bfaa89d libobjc.A.dylib`NXCreateMapTableFromZone + 79
    frame #21831: 0x00007fff5bfaa847 libobjc.A.dylib`NXCreateMapTable + 39
    frame #21832: 0x00007fff5bfa9a92 libobjc.A.dylib`_read_images + 502
    frame #21833: 0x00007fff5bfa8a50 libobjc.A.dylib`map_images_nolock + 1182
    frame #21834: 0x00007fff5bfbb560 libobjc.A.dylib`map_images + 68
    frame #21835: 0x000000010000847b dyld`dyld::notifyBatchPartial(dyld_image_states, bool, char const* (*)(dyld_image_states, unsigned int, dyld_image_info const*), bool, bool) + 1311
    frame #21836: 0x000000010000862e dyld`dyld::registerObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*)) + 63
    frame #21837: 0x00007fff5d774a27 libdyld.dylib`_dyld_objc_notify_register + 113
    frame #21838: 0x00007fff5bfa8234 libobjc.A.dylib`_objc_init + 115
    frame #21839: 0x00007fff5d73be36 libdispatch.dylib`_os_object_init + 13
    frame #21840: 0x00007fff5d747ad2 libdispatch.dylib`libdispatch_init + 282
    frame #21841: 0x00007fff5a7719c5 libSystem.B.dylib`libSystem_initializer + 121
    frame #21842: 0x000000010001b592 dyld`ImageLoaderMachO::doModInitFunctions(ImageLoader::LinkContext const&) + 506
    frame #21843: 0x000000010001b798 dyld`ImageLoaderMachO::doInitialization(ImageLoader::LinkContext const&) + 40
    frame #21844: 0x0000000100016bea dyld`ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, char const*, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 362
    frame #21845: 0x0000000100016b80 dyld`ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, char const*, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 256
    frame #21846: 0x0000000100016b80 dyld`ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, char const*, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 256
    frame #21847: 0x0000000100015d73 dyld`ImageLoader::processInitializers(ImageLoader::LinkContext const&, unsigned int, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 133
    frame #21848: 0x0000000100015e05 dyld`ImageLoader::runInitializers(ImageLoader::LinkContext const&, ImageLoader::InitializerTimingList&) + 73
    frame #21849: 0x0000000100005765 dyld`dyld::initializeMainExecutable() + 199
    frame #21850: 0x000000010000a709 dyld`dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 6213
    frame #21851: 0x0000000100004503 dyld`dyldbootstrap::start(macho_header const*, int, char const**, long, macho_header const*, unsigned long*) + 1167
    frame #21852: 0x0000000100004036 dyld`_dyld_start + 54

It goes into an infinite recursion (as far as I understood) and runs out of stack memory and gets aborted.
Not sure if I screwed up when running it. I did the following

Build the debug version of everything with -DCMAKE_BUILD_TYPE=Debug
In the test directory:
env LD_PRELOAD=/usr/local/lib/libmimalloc-debug.dylib MIMALLOC_SHOW_STATS=1 lldb -- ./dynamic-override
I have yet to go through the implementation of this library to understand what is happening. Saw this discussion thread and thought may be this data might be useful in the meantime.

MacOS system libraries will call free on any pointer, it doesn't even have to be previously allocated. I have seen system library code (I believe it was ObjC, or swift runtime) where it stores either an allocated pointer, or a pointer to constant data and then calls free on it, letting the memory allocators figure out if it's owned or not.
The implementation is required to check if any of the zones own a pointer. If you look at the documentation for _malloc_zone_t.
size_t (* MALLOC_ZONE_FN_PTR(size))(struct _malloc_zone_t *zone, const void *ptr); /* returns the size of a block or 0 if not in this zone; must be fast, especially for negative answers */

Basically the default malloc implementation will go through all registered malloc zones and call size(zone, ptr) until it finds a zone that claims ownership of that pointer and then call free on that zone.
What I have done in my memory manager/interposer implementation to get around the most annoying performance implications of this is:

Interpose the whole machinery of malloc zones
If no other zones are registered, just call my free implementation
Opportunistically check if the zone was created by me. This is just aligning the pointer and checking a magic number in header. This involves _setjmp and catching segfaults if the checked location is not a valid pointer
Lastly fall back to zones that are registered, but not created by me. This uses the same method of going through all zones and calling size()

Finally I think the current version of mimalloc v1.6.1 is working on macOSX.
Thank you @erikolofsson for your insights! (I did take a slightly different approach though)
I did a bit of testing with dynamic and static linking and it worked for those cases. I did a bit of light benchmarking and mimalloc seems quite a bit faster than the default allocator:
              mimalloc           default        speedup
cfrac          6.124s              13.171s       2.15x
mstressN       2.090s               5.960s       2.85x
larsonN       14.588s              63.369s       4.34x
rptestN       292742ops/s          245539ops/s   1.19x

this is despite it being not yet as optimal as it could be as it needs to check pointers before freeing if they belong to our zone.

It's crashing for me when using XcodeProj

Also, one thing to be aware of is mimalloc may need to always check that the pointer it's being given to free is one that was allocated by it, as Apple can sometimes give improper pointers to be freed

Ah, explained much more thoroughly by Eric above 😛

@michaeleisel: do you mean there is crash when dynamically overriding malloc with mimalloc in XcodeProj ?  Not when you create programs using mimalloc directly right?
The comment by @erikolofsson  is quite discouraging -- that is just terrible for allocation performance on macOS. :-(   Currently, the regular free is checking for ownership on macOS (using cfree) but the zone_free calls just mi_free.
Can you try to change that into a call to mi_cfree to see if that works for XCodeProj?

dynamic override on macos gives me bus error here
mimalloc: option 'show_errors': 1
mimalloc: option 'show_stats': 0
mimalloc: option 'eager_commit': 1
mimalloc: option 'eager_region_commit': 1
mimalloc: option 'reset_decommits': 0
mimalloc: option 'large_os_pages': 0
mimalloc: option 'reserve_huge_os_pages': 0
mimalloc: option 'segment_cache': 0
mimalloc: option 'page_reset': 1
mimalloc: option 'abandoned_page_reset': 0
mimalloc: option 'segment_reset': 0
mimalloc: option 'eager_commit_delay': 1
mimalloc: option 'reset_delay': 100
mimalloc: option 'use_numa_nodes': 0
mimalloc: option 'os_tag': 100
mimalloc: option 'max_errors': 16
[1]    3010 bus error  ./cmake-build-debug/test
mimalloc: option 'show_errors': 1
mimalloc: option 'show_stats': 0
mimalloc: option 'eager_commit': 1
mimalloc: option 'eager_region_commit': 1
mimalloc: option 'reset_decommits': 0
mimalloc: option 'large_os_pages': 0
mimalloc: option 'reserve_huge_os_pages': 0
mimalloc: option 'segment_cache': 0
mimalloc: option 'page_reset': 1
mimalloc: option 'abandoned_page_reset': 0
mimalloc: option 'segment_reset': 0
mimalloc: option 'eager_commit_delay': 1
mimalloc: option 'reset_delay': 100
mimalloc: option 'use_numa_nodes': 0
mimalloc: option 'os_tag': 100
mimalloc: option 'max_errors': 16
heap stats:     peak      total      freed       unit      count
  reserved:   256.0 mb   256.0 mb       0 b        1 b              not all freed!
 committed:   967.7 kb   967.7 kb       0 b        1 b              not all freed!
     reset:       0 b        0 b        0 b        1 b              ok
   touched:       0 b        0 b      4.0 kb       1 b              ok
  segments:       1          1          0                           not all freed!
-abandoned:       0          0          0                           ok
   -cached:       0          0          0                           ok
     pages:      15         16          1                           not all freed!
-abandoned:       0          0          0                           ok
 -extended:       0
 -noretire:       0
     mmaps:       0
   commits:      16
   threads:       0          0          0                           ok
  searches:     0.0 avg
numa nodes:       1
   elapsed:       0.002 s
   process: user: 0.013 s, system: 0.003 s, faults: 0, reclaims: 562, rss: 1.2 mb
mimalloc: process done: 0x115827dc0
mimalloc: option 'show_errors': 1
mimalloc: option 'show_stats': 0
mimalloc: option 'eager_commit': 1
mimalloc: option 'eager_region_commit': 1
mimalloc: option 'reset_decommits': 0
mimalloc: option 'large_os_pages': 0
mimalloc: option 'reserve_huge_os_pages': 0
mimalloc: option 'segment_cache': 0
mimalloc: option 'page_reset': 1
mimalloc: option 'abandoned_page_reset': 0
mimalloc: option 'segment_reset': 0
mimalloc: option 'eager_commit_delay': 1
mimalloc: option 'reset_delay': 100
mimalloc: option 'use_numa_nodes': 0
mimalloc: option 'os_tag': 100
mimalloc: option 'max_errors': 16
heap stats:     peak      total      freed       unit      count
  reserved:   256.0 mb   256.0 mb       0 b        1 b              not all freed!
 committed:   839.2 kb   839.2 kb       0 b        1 b              not all freed!
     reset:       0 b        0 b        0 b        1 b              ok
   touched:       0 b        0 b        0 b        1 b              ok
  segments:       1          1          0                           not all freed!
-abandoned:       0          0          0                           ok
   -cached:       0          0          0                           ok
     pages:      13         13          0                           not all freed!
-abandoned:       0          0          0                           ok
 -extended:       0
 -noretire:       0
     mmaps:       0
   commits:      14
   threads:       0          0          0                           ok
  searches:     0.0 avg
numa nodes:       1
   elapsed:       0.011 s
   process: user: 0.016 s, system: 0.002 s, faults: 0, reclaims: 442, rss: 915.5 kb
mimalloc: process done: 0x117b39dc0

I am also getting the following errors. Is it safe to say that the static object implementation doesn't work for OSX @daanx ?
appTest(3748,0x1ef6e8100) malloc: *** error for object 0x20000020080: pointer being freed was not allocated
appTest(3748,0x1ef6e8100) malloc: *** set a breakpoint in malloc_error_break to debug
[1]    3748 abort      ./build/bin/appTest


GripTape Agent Config : Ollama

[ x ] I have read and agree to the contributing guidelines.

Is your feature request related to a problem? Please describe.
when the Ollama Agent Config pulls a list of models from Ollama, it grabs all models and shows only the model main family name (but not any variant)
this means the GripTape list can show multiple of the same model when they care in fact differnet variants (eg :small vs :medium, :2b vs :7b).
when executing, it seems that only a model with  ":latest" is actually usable.
Ollama throws a model not found error if the model in ollama doesnt match :"latest
Describe the solution you'd like
please enumerate the full model spec from ollama, and then use the full model when posting the prompt to ollama
eg :
Phi3:Medium
Phi3:14b
Dolphin-Mixtral:8x7B
Describe alternatives you've considered
n/a
Additional context

fix merged

thanks. works perfectly.
cheers for the quick fix.

My pleasure, glad it worked :)
On Tue, Jun 25, 2024 at 12:01 AM BreckanM @.***> wrote:

thanks. works perfectly.
cheers for the quick fix.
—
Reply to this email directly, view it on GitHub
https://github.com/griptape-ai/ComfyUI-Griptape/issues/33#issuecomment-2186411533,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJFWYIJIBRKVD7STJFD66DZJADCFAVCNFSM6AAAAABJYPNNPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWGQYTCNJTGM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


negative amount

In NZ Watercare's invoices, they use this to indicate a negative total amount (credit balance):
[$ 108.43 cr]
I added IF statement to recognize it as a negative float

Thanks for the contribution, but there are many extra files/commits in your pull request. Could you rebase this to only include the actual change. E.g. it shouldn't include my last version bump.
Rough steps:

Pull latest changes from master (this repo)
Create new branch based on master
Make changes
Push and open pull request.

And one PEP8 issue: (see CI test for details)
src/invoice2data/extract/invoice_template.py:110:83: E231 missing whitespace after ','

Will do. Thanks for review


(server) http2_only(true), http1_only(true) do not work (hyper::server::Builder)

Take this (incomplete but clear enough) sample code (v0.12.7):
let tcp = TcpListener::bind(&socketaddr).unwrap();
let tls = tcp
    .incoming()
    .and_then(|s| serverconfig.accept_async(s))
    .then(|r| match r {
        Ok(x) => Ok::<_, io::Error>(Some(x)),
        Err(error) => {
            warn!("Client connection error: {}", error);
            Ok(None)
        }
    }).filter_map(|x| x);
let fut = Server::builder(tls)
    //.http2_only(true)
    .http1_only(true)
    .serve(move || service_fn(producer.clone()));
let mut core = tokio_core::reactor::Core::new().unwrap();
if let Err(err) = core.run(fut) {
    error!("FATAL: {}", err);
    panic!()
}
Ok(())

Multiple curl invocations (e.g., --no-alpn, --http2, --http2-prior-knowledge) seem to show the same logic is applied no matter what. Both HTTP 1.1 and 2 are supported.

Hm, I'm trying to reproduce, but setting http1_only(true) and then sending an HTTP2 request seems to be erroring, as expected...

Ah, hyper doesn't know anything about ALPN, you'd need to configure that in the TLS acceptor. The options in hyper are telling it what protocols to allow internally. The default is that if the transport sends HTTP/1 or HTTP/2 (after any decrypting or whatever the transport may do), it just works. The http{1,2}_only() methods are there in case for some reason you would rather that hyper tear down the connection if the protocol is different.

Thanks, I fixed the ALPN issue.
With rustls ALPN configured to accept h2 and http1.1, http2_only(true), some kind of corrupt response data are sent:
  curl --http1.1 --location -k -v https://localhost.localdomain:8082/ | hexdump
* Uses proxy env variable no_proxy == '<IP_ADDRESS>,<IP_ADDRESS>/8,<IP_ADDRESS>/16,<IP_ADDRESS>/12,::1,fd00::/8, localhost,.localdomain'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost.localdomain (::1) port 8082 (#0)
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: none
} [5 bytes data]
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
} [216 bytes data]
* TLSv1.2 (IN), TLS handshake, Server hello (2):
{ [89 bytes data]
* TLSv1.2 (IN), TLS handshake, Certificate (11):
{ [5058 bytes data]
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
{ [300 bytes data]
* TLSv1.2 (IN), TLS handshake, Server finished (14):
{ [4 bytes data]
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
} [37 bytes data]
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
} [1 bytes data]
* TLSv1.2 (OUT), TLS handshake, Finished (20):
} [16 bytes data]
* TLSv1.2 (IN), TLS handshake, Finished (20):
{ [16 bytes data]
* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: CN=testserver.com
*  start date: Aug 13 16:07:04 2016 GMT
*  expire date: Feb  3 16:07:04 2022 GMT
*  issuer: CN=ponytown RSA level 2 intermediate
*  SSL certificate verify result: self signed certificate in certificate chain (19), continuing anyway.
} [5 bytes data]
> GET / HTTP/1.1
> Host: localhost.localdomain:8082
> User-Agent: curl/7.61.0
> Accept: */*
>
{ [5 bytes data]
100     9    0     9    0     0    529      0 --:--:-- --:--:-- --:--:--   529
* Connection #0 to host localhost.localdomain left intact
0000000 0000 0400 0000 0000 0000
0000009

Those bytes look a lot like the initial SETTINGS frame an HTTP2 server would respond with...

and then sending an HTTP2 request seems to be erroring, as expected...
So, it comes down to what erroring means here?

So, it comes down to what erroring means here?

Perhaps! Do you have a suggestion on what should be changed here?

If a request comes in with an incompatible HTTP version specified, hyper should close the connection?

I agree with that. So, it seems the issue in this case is that if the client sends a HTTP/1 request, and hyper is told to only use HTTP/2, hyper will actually write the HTTP2 SETTINGS frame before realizing that incoming bytes weren't HTTP2. Does that sound right?

To me it does. (But I haven’t spent the time to dig into this issue to give you any more confirmation/knowledge than you already have.)

@sanmai-NL could you post the full test script?

@AlexDvorak: I didn’t have one really, it’s just a curl invocation.

So the behavior seen here is happening in the h2 dependency. It's currently setup to first flush the server preface, and then read the client preface. This means the HTTP2 preface would be written to every connection here, without checking if it sent an HTTP2 preface itself.
If worth fixing, it'd just require swapping the order in h2. I'm going to close this here in hyper as there's nothing hyper itself can do, besides peeking for a preface before handing off to h2.


revert to sgd

@piiswrong In kvstore,
 File "../../python/mxnet/kvstore.py", line 251, in set_optimizer
    optim_str = pickle.dumps(optimizer, 0)

it requires optimizer to can be dumped, but current ccSGD doesn't support. So revert first.

cc @piiswrong

Ok. This seems to be a conflict. Symbol also cannot be dumped right? How is it sending those?

Pickle can be implemented as long as getstate and setstate are implemented, see https://github.com/dmlc/mxnet/blob/master/python/mxnet/symbol.py#L110


Terragrunt multiple accounts with assume role getting connection refused from aws

Terrafrom version: 1.2.8
Terragrunt version: 0.38.9
AWS provider version: 4.28.0
My config:
iam_role = local.iam_role

# Generate an AWS provider block
generate "provider" {
  path = "provider.tf"
  if_exists = "overwrite_terragrunt"
  contents = <<EOF
provider "aws" {
  region  = "${local.aws_region}"

  # Only these AWS Account IDs may be operated on by this template
  allowed_account_ids = ["${local.account_id}"]
}
EOF
}

# Configure Terragrunt to automatically store tfstate files in an S3 bucket
remote_state {
  backend = "s3"
  config = {
    encrypt        = true
    bucket         = "terraform-st-acc-${local.account_id}-${local.aws_region}"
    key            = "${path_relative_to_include()}/terraform.tfstate"
    region         = local.aws_region
    dynamodb_table = "terraform-locks"
  }
  generate = {
    path      = "backend.tf"
    if_exists = "overwrite_terragrunt"
  }
}

Having multiple accounts and switching between them with assume-role.
During terragrunt run-all apply --terragrunt-non-interactive --terragrunt-parallelism 5 getting connection refused errors from sts, dynamodb, s3, etc. Example:
ERRO[0040] Create S3 bucket with retry iris-terraform-st-acc-1234567890-us-east-1 returned an error: RequestError: send request failed
caused by: Put "https://terraform-st-acc-1234567890-us-east-1.s3.amazonaws.com/": dial tcp <IP_ADDRESS>:443: connect: connection refused. Sleeping for 10s and will try again.
ERRO[0044] Create S3 bucket with retry terraform-st-acc-1234567890-us-east-1 returned an error: RequestError: send request failed
caused by: Put "https://terraform-st-acc-1234567890-us-east-1.s3.amazonaws.com/?versioning=": dial tcp <IP_ADDRESS>:443: connect: connection refused. Sleeping for 10s and will try again.

Initializing the backend...
╷
│ Error: error configuring S3 Backend: error validating provider credentials: error calling sts:GetCallerIdentity: RequestError: send request failed
│ caused by: Post "https://sts.amazonaws.com/": dial tcp <IP_ADDRESS>:443: connect: connection refused
│
│

│ Error: Error releasing the state lock
│
│ Error message: RequestError: send request failed
│ caused by: Post "https://dynamodb.us-east-1.amazonaws.com/": dial tcp
│ <IP_ADDRESS>:443: connect: connection refused
│ Lock Info:

Looks like terragrunt is doing sts:assume for each operation such as: to read info from backend, to put a lock, to remove a lock. So AWS basically starts throttling my requests and i'm getting connection refused errors.
Am I missing something? Is there a way to avoid these errors and keep using assume-roles?

Recently I reworked my terragrunt code and instead of using separate folders for each role,policy, etc I combined them into one module, looks like this:
Before:
account/region/iam/policies/policy_name1/terragrunt.hcl
account/region/iam/policies/policy_name2/terragrunt.hcl
account/region/iam/policies/policy_name3/terragrunt.hcl
account/region/iam/roles/role_name1/terragrunt.hcl
account/region/iam/roles/role_name2/terragrunt.hcl
account/region/iam/users/user_name1/terragrunt.hcl
account/region/iam/users/user_name2/terragrunt.hcl

Now:
account/region/iam/policies/terragrunt.hcl
account/region/iam/roles/terragrunt.hcl
account/region/iam/users/terragrunt.hcl

Even with this changes since my infra is still big I anyway continue getting this error:
finished with an error: RequestError: send request failed
caused by: Post "https://sts.amazonaws.com/": dial tcp <IP_ADDRESS>:443: connect: connection refused

Please introduce some sort of STS session caching. Or please tell me how to properly use sts assume role to not hit AWS rate limits. This guide https://terragrunt.gruntwork.io/docs/features/work-with-multiple-aws-accounts/ works only if you have very simple setup.

As a popssible workaround, you might try adding that to the list of retryable errors?
retryable_errors = [
  # Terragrunt default retryable errors
  "(?s).*Failed to load state.*tcp.*timeout.*",
  "(?s).*Failed to load backend.*TLS handshake timeout.*",
  "(?s).*Creating metric alarm failed.*request to update this alarm is in progress.*",
  "(?s).*Error installing provider.*TLS handshake timeout.*",
  "(?s).*Error configuring the backend.*TLS handshake timeout.*",
  "(?s).*Error installing provider.*tcp.*timeout.*",
  "(?s).*Error installing provider.*tcp.*connection reset by peer.*",
  "NoSuchBucket: The specified bucket does not exist",
  "(?s).*Error creating SSM parameter: TooManyUpdates:.*",
  "(?s).*app.terraform.io.*: 429 Too Many Requests.*",
  "(?s).*ssh_exchange_identification.*Connection closed by remote host.*",
  "(?s).*Client\\.Timeout exceeded while awaiting headers.*",
  "(?s).*Could not download module.*The requested URL returned error: 429.*",
  "(?s).*Error: NoCredentialProviders: no valid providers in chain.*",
  # Custom retryable errors
  "(?s).*dial tcp.*connect: connection refused.*",
]

@lorengordon AWS applies block for 5-10 minutes. So it will not work, unfortunately. With a such workaround there is a chance to get even longer ban :)


Publish 'Founding an Analytics Engineering Team' Article

@natesooter has finished his article per this issue from our archived repo, we just need to publish it https://github.com/dbt-labs/dbt-technical-blog-writing/issues/76

@gwenwindflower I'm on it! I'll submit the PR to ganz today for his final approval

@gwenwindflower I ended up needing permission to the doc. Just noticed I had access to the draft doc today. Do you know if there is a author bio pic @natesooter prefers?

@johnblust just uploaded a headshot here, let me know if you need anything else!

@jasnonaz Do you have an estimate for when the blog will be published?

Hi @natesooter! We should be ready to publish in the next few days (hopefully tomorrow) - just wrapping up the PR and getting ready to publish https://github.com/dbt-labs/docs.getdbt.com/pull/1172

@jasnonaz That sounds great. Can't wait to see this full story shared and appreciate your partnership in getting the story ready for publishing!

And @johnblust thank you for your work migrating this from the Google doc format onto the blog itself. It looks great!

Closed by #1172


Script to migrate admin sets and collections - this is a Hyku thing

Script should cycle through each tenant to load and save each admin set and collection
Below is sample code for admin sets. Collections will vary slightly.
Note: this gets all defined admin set classes. We probably want to use only ActiveFedora classes.
models = Hyrax::ModelRegistry.admin_set_classes
    unique_models = []
    models.each do |model|
      unique_models << Wings::ModelRegistry.lookup(model)
    end

    unique_models.uniq.each do |model|
      admin_sets = Hyrax.query_service.find_all_of_model(model:)
      admin_sets.each do |as|
        fm = AdminSetResourceForm.new(resource: as)
        converted = Hyrax.persister.save(resource: fm)
        Hyrax.index_adapter.save(resource: converted)
      end
    end

TODO:

[ ] add collection reindex to script as the final step
[ ] update project submodule once merged

NOTES
ref:

https://github.com/samvera/hyku/blob/main/app/jobs/migrate_resources_job.rb

QA RESULTS: ⚠ PENDING
TESTED ON ADVENTIST
command: rake migrate_collections
produced:

QA RESULTS: ✅ PASS
To confirm that all collections and adminsets got converted,  find all collections in af and compare to collections in the resource table. do they all exist? every record in af should be in the resource table,
There was a weird behavior where two of the collections didn't get indexed for some reason. This manifested itself in such a way that I got an unauthorized message when trying to view it directly, but i could find the record in the rails console. reindexing the collection resource resolved this so it may be a good idea to run the collection reindex task afterwards, just in case.

TODO: run script in staging to confirm per @laritakr

Rob has made alterations to this job after testing it on Pals.
ref:

https://github.com/samvera/hyku/commit/43a2d1e07cc28eae48f2c93af639f77ed1e013a3


Log Rotation for rtm-bot

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Description

Please implement a way to configure daily / hourly log rotation for logging data.

Reproducible in:

[x] This is reproducible in the sample project.
RTMBot version: latest
Python version: 2.7
OS Version: MacOS High Sierra

Steps to reproduce:

Not Applicable

Expected result:

Should be able to automatically create log files and rename the old log file accordingly.
Example Old log file format: rtmbot.log.2018.04.17

Actual result:

Functionality not available as of now.

This issue is probably similar to https://github.com/slackapi/python-rtmbot/issues/66 but it doesn't have any specifics documented.

I'd prefer to delegate logging to a general logger and add debug statements where they're valuable and leave the retention up to the implementing app's settings. Marking this as a suplicate of #66  and updating the contents of that request.


Codecov coverage reports

Testing Codecov coverage reports on a PR as per https://github.com/quantumlib/Cirq/issues/6063#issue-1667122621

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8e70f77). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6193   +/-   ##
=========================================
  Coverage          ?   97.46%
=========================================
  Files             ?     1098
  Lines             ?    95482
  Branches          ?        0
=========================================
  Hits              ?    93062
  Misses            ?     2420
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Please rebase so this PR contains only codecov-related commits on top of the quantumlib/Cirq master.
As it is the PR has intermediate commits from your previous contribution.
One way of doing the rebase is
$ git checkout codecov-coverage-reports
$ git fetch https://github.com/quantumlib/Cirq.git master
$ git rebase -i FETCH_HEAD
  ... keep only the new commits
$ git push --force-with-lease your_remote_name codecov-coverage-reports

I will, thank you very much. I'm learning a lot!


Fix inconsistencies

I'm using pocketbase on an unsupported platform, so I wrote some code to automatically scrape the docs and generate an sdk from it. In that process, I found several inconsistencies that caused problems for scraping, some of which seem to potentially be actual mistakes in the documentation.
This PR has the changes needed to fix those inconsistencies and align the docs with the actual behavior. Please still check it and make sure I didn't mess up, I did my best to understand the behavior by reading the go code, but I'm far from infallible and it's possible I misinterpreted something.
(any edits that don't look like they do anything important are probably just to be consistent with other parts of the docs, it makes things easier for me if everything is written in the same way and things like field order are the same)

I've pushed in master fix for the incorrect/legacy settings and auth collection list response examples and updated the static search index.

I wrote some code to automatically scrape the docs and generate an sdk from it.

I don't recommend doing this. Not only the HTML and overall structure of the docs can change without any warnings, but also note that some of the supported request fields may not be returned in the API response intentionally (e.g. smtp password, s3 secrets, etc.) or their availability in the response to depend on some other option being enabled.


Align buttons design

Currently the buttons have borders when active and dont look exactly like the mockups
Network and user buttons align to sigma - https://www.figma.com/file/fwADI9wqDrRAdlMX8EddCw/Bancor-v3?node-id=2132%3A12590

Stale


Cosmos emulator "can run with as little as 0.5 cores" inaccurate/outdated

In Configuration Options in the docs, under --cpus it states...

"...the emulator can run with as little as 0.5 cores..."

This is not the case.  It typically hovers around 100%-400%
compose.yaml
volumes:
  # mounting to local path caused cosmos emulator to kernel panic
  cosmosdb-data:
    name: cosmosdb-data

cosmosdb:
  image: mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator:latest
  container_name: cosmosdb
  # cpus: 4.0  # has no positive effect on issue
  environment:
    # Reduce resource burden
    AZURE_COSMOS_EMULATOR_PARTITION_COUNT: 1
    AZURE_COSMOS_EMULATOR_ENABLE_DATA_PERSISTENCE: 'true'
  ports:
    - 8081:8081  # data explorer ui
  volumes:
    - cosmosdb-data:/tmp/cosmos/appdata:rw

.wslconfig
[wsl2]
memory=12GB
processors=6

RAM = 32GB
CPU = 8cores

All 8 host cores are essentially unused (barely reach a quarter use).  However, top command in resulting container shows (well) above 100% CPU.  System is unusable and results in timeouts from the node.js SDK (which points to CPU/resource exhaustion, via docs)
Tried ensuring WSL was configured as per other issues/reports, to no avail.  top in container shows cosmos emulator (alone) being the problematic process.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a59d2ab-cacd-5545-bddb-b9304f204605
Version Independent ID: bbcf9128-f9c3-fa84-b085-ba566f45d56f
Content: Run the Azure Cosmos DB Emulator on Docker for Linux
Content Source: articles/cosmos-db/linux-emulator.md
Service: cosmos-db
GitHub Login: @StefArroyo
Microsoft Alias: esarroyo

@bigteejay Thank you for the feedback. This is being assigned to the content author to evaluate and update as appropriate.

#assign:seesharprun
Hello @bigteejay!
I agree that the recommendation should now be to use 2 cores. I have updated the doc to not mention 0.5 cores anymore and outright recommend 2 cores. The code samples were already updated to reflect this.
For the high CPU usage, you should file an issue with product feedback. This repo is for docs and we won't be able to provide technical support on the product itself.
This issue will auto-close once the change is in our publishing pipeline. You should see it soon.


TwelveHourClock format

Hi!
First of all thanks for this great component. This is exactly was I was looking for and I like that it has Swift 3 support already.
I was looking at the pre defined tokens in SplitflapTokens. I think the TwelveHourClock token should have a 2 digits format just like the 24hour and minutes/seconds one.

It works as expected. Except that each flap display one digit, like in this photo:

Of course you can create clocks with 2 digits per flap but the 1 digit per flap covers more use cases.

I see, it was intended then. I will close the PR.

Hey
I also wanna use it to print a clock i have set SplitflapTokens.TwelveHourClock but i can´t set the numbers when i try it with splitflap.setText("11:59", animated: true) in a button it print me hours but he print not the double point and the minutes.
numberOfFlapsInSplitflap i have set to 5
Thanks for your answer :)

@Danielthenew This is because the : is not available in the TwelveHourClock token list.
You should add it in the tokensInSplitflap method:
func tokensInSplitflap(_ splitflap: Splitflap) -> [String] {
  return SplitflapTokens.TwelveHourClock + ":"
}


Client Allocation Request for: Speedium

Client Allocation Questions
Core Information

Name: Speedium
Website / Social Media: www.speedium.network
Region: Europe
DataCap Requested: 10TiB
Addresses to be Notarized: f3qpxctorx5cvsfz4emzl5tgraiqavzkdazul475hpe4tdjc6mydnunt4betsweons4fwyd7d54vcvbcskx4la
Notary Requested: neogeweb3

Hello @neogeweb3
As requested, this request relates to #284 and #31 and #297
To answer your questions you send me:
1:) How much cumulative DataCap was allocated to you from me?
1TB
2:) In which region(s) did you use the DataCap?
EU
3:) What was your use case for the previous allocation?
To bring Usenet cache to filecoin.
4:) Did you specify any advanced features for the previous allocation?
No
5:) How many miners did you allocate the DataCap to? Please specify transaction links to the storage deals.
See attachment
6:) In your previous allocation, did you violent any community principles like excessive/unfair self-dealing?
No
7:) Is there anything I could improve to serve you better in future allocations?
Our datacap need is +/- 1 TB per day. We are keen to have a recurring cap. It would be great if you can make efforts with that together with Philipp.

Hey @cryptowhizzard, the transactions look good to me. This is your 3rd request while @philippbanhardt run out of his DataCap. I know there are only 2 notaries in Europe, but please keep in mind that I shouldn't allocate too much DataCap to you for geographic distribution diversity. I will approve this request, while discussing within notaries to find a way that we could broadly share allocation needs.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacebgtonjruhyil547oaev4n45bunbkyfpskt5beoz4fpqngomvyur4

Address

f3qpxctorx5cvsfz4emzl5tgraiqavzkdazul475hpe4tdjc6mydnunt4betsweons4fwyd7d54vcvbcskx4la

Datacap Allocated

10TiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacebgtonjruhyil547oaev4n45bunbkyfpskt5beoz4fpqngomvyur4

This user’s identity has been verified through filplus.storage


making sure imgui works well after resizing

right now imgui windows are clipping to old size and mouse position is not tracked well after resizing

Looks good, thanks.


Is there a Java grammar for Lark

Would like to parse Java. Right now, Im translating a ANTLR Java grammar to the Lark format, but do you know if there is one available already? Thanks!

Hi, none currently exists, but the translation should be very straightforward.
Let me know if you need any help.

Thanks! I ended up sticking with antlr for which the grammar already exists.

Okay, good luck!


Update copyright to '2023'

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.195%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2369

Relevant Lines:
2515

💛  - Coveralls


[BUG] Flaky IT test

What is the bug?
Possibly related to Seg Rep changes
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

What is the expected behavior?
A clear and concise description of what you expected to happen.
What is your host/environment?

OS: [e.g. iOS]
Version [e.g. 22]
Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

i think the discussion is still ongoing https://github.com/opensearch-project/observability/issues/1562
we will probably align to osd behavior

there were multiple CI runs in https://github.com/opensearch-project/observability/pull/1778
but they were consistently failing or succeeding, no flaky runs. closing for now


Access violation in poodinis.container.getExistingRegistration

This happens in release mode.
Compiler: DMD32 D Compiler v2.072.2
OS: Win10 x64
Test: example\quickstart\app.d

Thank you for reporting this issue! After some investigation this seems to be caused by a bug in the DRuntime. I've filed it under https://issues.dlang.org/show_bug.cgi?id=17088
Unfortunately I couldn't find an easy workaround at this time. If the dlang issue is not solved within a considerable amount of time I will see if I can re-architect some things to fix it.

In DMD 2.075.0 this issue, at least for Poodinis, seems to be fixed


No export for multiple (matplotlib)-images in output cell

The following code creates 5 images in cell, however only the first one gets exported.
import numpy as np
import matplotlib.pyplot as plt
%matplotlib inline

for ii in np.arange(5):
    plt.figure()
    plt.plot(np.arange(100)**2)
    plt.show()

Hi Marco,
I had the same problem exporting with pandas versions higher than 2.6. Up to 2.6 the export works fine. Just give this a try. Maybe this helps you to find the reason.
The cause for not exporting all images lies somewhere in pandas. Even tried to convert a document directly using pandas without any other tool showed this behaviour.
Best regards Martin

I don't think it has to do with the pandas version. Could you explain which specific version you mean? They had version numbers to 0.25 and then switched to 1.0. Currently we have 1.0.5.
However this package basically does a conversion to *.html and then to *.docx. You can try it with
jupyter-nbconvert notebook.ipynb --to html
pandoc notebook.html --to docx -o notebook.docx

The *.html has all the images, however the *.docx not. The issue seems to be in the conversion process of pandoc.

Just after submitting my comment, I understood: you meant pandoc :-)

May its time to remove that *.html-intermediate conversion because pandoc supports direct *.ipynb-conversion since version 2.6


"Cannot read property 'length' of undefined" error appears when open easyCla page at PCC

Steps :

Login admin portal
Search Project which have cla enabled
Open easyCla page

Actual Results : "Cannot read property 'length' of undefined" error appears & page is inaccessible
ERROR TypeError: Cannot read property 'length' of undefined
    at ActivityLogComponent_Template (activity-log.component.html:2)
    at executeTemplate (core.js:9614)
    at refreshView (core.js:9480)
    at refreshComponent (core.js:10651)
    at refreshChildComponents (core.js:9277)
    at refreshView (core.js:9530)
    at refreshEmbeddedViews (core.js:10605)
    at refreshView (core.js:9504)
    at refreshEmbeddedViews (core.js:10605)
    at refreshView (core.js:9504)

https://images.zenhubusercontent.com/194341141/d542169a-41d2-40e1-b3e8-d9834843c814/easycla_error.mp4

@thakurveerendras the error is thrown on activity-log.component.html so looks like a PCC issue on the frontend

Thanks @nickmango ,
Added frontend ticket for above case (https://jira.linuxfoundation.org/browse/PCC-1591).

Closing as this appears to be a front-end issue in the PCC. Thanks!


Resize Window

Is it possible to change the properties of a window (resize / reposition)? I want to do this programatically in response to some events inside the window.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/25523169-resize-window?utm_campaign=plugin&utm_content=tracker%2F899498&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F899498&utm_medium=issues&utm_source=github).

Sorry it's not currently possible to do that. I will keep this as a feature request.


Why was this changed? It broke for me.

Line 11 in pyv4l2_reader.pl should be:
    from pyv4l2.frame import Frame

Instead of this, as v4l2 does not contain a 'frame' object:
    from v4l2.frame import Frame

Howdy version: latest

Fixed the typo in 2.5.1


Add in a proposed Zero BSD license

Dunno if this is a good choice or not. I put the ekonomisk föreningen as copyright holder.

Adding in some minor spelling changes.

Oh, good point. Usually I make a note of the different copyrights in the README. I'll add that.


Does the "torch.cuda.is_available()" option affect kernel crash?

While running demo_part3.ipynb, cell 3 crashes due to kernel issue.

I think this is due to torch.cuda.is_available() option. I found that torch.cuda.is_available() is False on cell 2.
Am I right? If yes, should I make torch.. available() true by setting torch and cuda environment? my cuda version is 12.1.
Thanks for reading it.

I had the same problem (in COLAB and Vscode) this is what i did

Install Pytorch Cuda using the command in this page : https://pytorch.org/get-started/locally/ , be sure pytorch use cuda correctly , with  torch.cuda.is_available() get in true giving to you true
Use a env Python 3.9.XX (I use 3.9.19)

@Dan-H-Muniz-Sanchez Thanks!!!!


Introduction

My Introduction
Name
Martijn Keesmaat
Class
VID2
About me
I have been trying to upload something each weekday on Dribbble. I have been doing this for about 5 weeks now. Recently I have been focusing on layout and typography, by experimenting with different grid systems like the golden ration and canon grid. I'm also trying to learn from a wider variety of sources like vintage newspapers, highlight reels, SWISS poster design, and graphic design history. Then I realize that I develop things and type out some code.
Goals
Get introduced to processing, generative art, and physics.
P.S. how to make better work faster by working smarter
Skill level
7/10
GitHub username
Me
GitHub repository
Repo

🎉 Thanks Martijn!


Proper way to let parent bind children's data?

Consider this example:
<tabs>
  <tab label="Followers" some-magic-prop-or-directive="{{ number }}">
    <followers></followers>
  </tab>
  <tab label="Messages"  some-magic-prop-or-directive="{{ number }}">
    <messages></messages>
  </tab>
</tabs>

that gets rendered as
<tabs>
  <tabs-pagination>
      Followers 123
      Messages 456
  <tabs-pagination>
  <tab label="Followers">
    <followers></followers>
  </tab>
  <tab label="Messages">
    <messages></messages>
  </tab>
</tabs>

Now, as the tabs need child component's data to display the numbers, and the numbers are fetched from api (so the data should be two-way binded),
what is the proper way to get it?
Using props + callbacks needs to define a prop inside each child component,
Using directives won't get the data binded...
The only way I can think of now, is setting up watches inside each child component, that $dispatchs the new value upwards..

According to contribution guide questions should be in vuejs/Discussion

Sorry about that.
moved there.


[BUG] Default prompt for similarity does not work with gpt-4o

Describe the bug
Using code like this:
from promptflow.evals.evaluators import SimilarityEvaluator

similarity = SimilarityEvaluator(model_config)

similarity_score = similarity(
    question=sample['question'],
    answer=sample['final_answer'],
    ground_truth=sample['gold_final_answer'],
)

We get a result of nan for the score, and when we print out the llm_output from inside the promptflow code, we simply see an output of the word "Based".
It would be great if the prompts could be improved to work with gpt-4o as evaluation models, since many developers would like to use them instead of gpt-4.
How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

We always experience it for this data, on every question.

Expected behavior
We expected the prompts to work well for gpt-4o as well.
Screenshots
If applicable, add screenshots to help explain your problem.
Running Information(please complete the following information):
Promptflow Package Version using pf -v: [e.g. 0.0.102309906]
{
"promptflow": null,
"promptflow-azure": "1.14.0",
"promptflow-core": "1.14.0",
"promptflow-devkit": "1.14.0",
"promptflow-evals": "0.3.1",
"promptflow-tracing": "1.14.0"
}
Operating System: GitHub Codespaces, python3:12 image
Python Version using python --version: Python 3.12.5

cc @cedricvidal

I just tried this with 0.3.2, and I am getting a numeric score instead of "Based" (nan). So something seems to have changed in last version to improve this, at least for this particular QA pair. @cedricvidal could try running on the full set to see theyre all working now.


added a new button

fixes issues #1302

Can u provide the working of that button like a screenshot or a video

https://github.com/akshitagupta15june/Moksh/assets/111264897/76a30ee5-9bb1-4336-b76f-dbd1a7c93a78

@akshitagupta15june mam please check it out

Hey there are 2prs why not one can u close that background music one

Sure mam

hey on clicking that button can song be paused and again played means the ui of button changes?

Yes


Remove unnecessary pages

This PR removes mention of SET APPLICATION_NAME in favor of adding it later with other such variables. It also removes a few old stub pages.
Partially addresses #918

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c490429cfc414cc24d68b4c1be3ac1ffc3ab6077/

LGTM - thanks!


Memory access improvement

Re-factory memory access to improve performance
improve readability
use uint_fastx_t to replace the original native data type. Balancing between portability and performance.
NOTE: The re-factory doesn't change the original logic. The code has been verified.

Closing this pull request - merged most of it, but some things are special:

Removed 16bit interface
Removed special DMA handling (it's really seldom used in games)
Didn't merged the interface for drawing pixels (but will come in future)
Had to make adaptations to pass all the test roms

Overall it improved the benchmark (running 1000 frames) by 2.7%. More to come...

Thanks!
Just one thing, could I add macros to make the 16bit read interface and dedicated dma interface an optimisation option? I do see the improvements on my poor cortex-m platform. due to the very limited computing power, I have to do the cycle level optimisation.

I am doing next around update and will send a pull request again:

Adding macros to enable/disable optimisation options
using the latest ppu_upate

Cheers,
Gabriel

Could you keep the pull request rather small - going optimisation by optimisation? It's easier for me to understand and merge it and we can discuss the pull requests separately.


Support multiple  Setup / Teardown

After feedback from @jnm2
Currently setup replaces current setup/teardown action could instead add ( += ) to existing / if not null.

Second ‘Support’ in this title and release notes should be ‘Setup.’

@jnm2 great catch, thank you for the heads up!