Minor structural fix to chain spec article

This PR change the Extension heading in the chain spec KB article from H2 to H3. This makes sense because the extension is part of the client spec. This also sidesteps the question that I had when reading the article

If there are two parts of the spec, like the text says, then why are there three subheadings.

lgtm, thanks @JoshOrndorff

I hate when this CI issue happens, it is stuck. Can you push another commit @JoshOrndorff or do you remember how we fixed it last time? :sweat_smile:


[BUG] lombok still insert a null-check even when using androidx.annotation.NonNull

Describe the bug
On Android, when using androidx @NonNull annotation (and not lombok @NonNull) with @RequiredArgsConstructor or @AllArgsConstructor, lombok still insert a null-check at the start of the constructor's body.
To Reproduce
import androidx.annotation.NonNull;
import lombok.RequiredArgsConstructor;

@RequiredArgsConstructor
public class MyClass {
    @NonNull  // Android annotation
    private final String myString;
}

Look at the generated code
Expected behavior
Lombok should add the null-check only with lombok.NonNull annotation.
Version info (please complete the following information):

Lombok version: 1.18.18
Platform: Android Studio 4.1.2

If I remember correctly that behaviour is intended. Lombok knows a bunch of NonNull annotations and generates null checks if it create methods that uses these fields. Is there any reason why you think that lombok should not do that?

You are right, It's the intended behavior.
Because I don't want lombok to do a null-check at all in my project but still use @RequiredArgsConstructor for example, I built a lombok.jar with the following changes:

Added None option to NullCheckExceptionType:

@ExampleValueString("[NullPointerException | IllegalArgumentException | Assertion | JDK | Guava | None]")
public enum NullCheckExceptionType {
	...
	NONE {
		@Override public String getExceptionType() {
			return null;
		}

		@Override public LombokImmutableList<String> getMethod() {
			return null;
		}
	};

Check the exceptionType inside generateNullCheck methods in both EclipseHandlerUtil and JavacHandlerUtil classes:

if (exceptionType == NullCheckExceptionType.NONE) return null;

I understand what you want to archive but I don't get why.
Documentation:

androidx.annotation.NonNull
Denotes that a parameter, field or method return value can never be null.
This is a marker annotation and it has no specific attributes.

It clearly says that this field should never be null and the added check ensures that this condition is met.


Inconsistent naming for Amazon/AWS services

I was scanning this list and noticed that the naming for all the individual services is pretty inconsistent. I've also noticed this elsewhere in the AWS IAM world (like the online policy editor, which has the same names):
Contrast the following:

Amazon Elasticsearch Service
Amazon ElastiCache
AWS Key Management Service
Identity And Access Management
Amazon API Gateway
Manage Amazon API Gateway

Basically, inconsistency between whether the service is called "AWS" or "Amazon" (or neither, in the case of IAM or SSO), and sometimes a seemingly redundant "service" is added to the end of the name. The "Manage Amazon API Gateway" one is weird too.
Luckily it seems like the list is alphabetized by the important bit, but the inconsistent prefix (lengths vary) makes it very hard to visually scan the list looking for something.
I assume these names reflect some sort of internal organizational details but it's confusing for users and I was wondering if something could be done to improve consistency in the IAM documentation at least.

Thank you for your comment, copumpkin. We understand your issue with the naming inconsistencies, which is why we made sure the list is alphabetized as is now. Making changes to the service names is outside of the scope of IAM documentation. We cannot present the list any other way but to use the actual service names. We appreciate your feedback!

Hi @carlasp -- could the documentation at least be consistent with the use of acronyms vs. full names? For example, the page lists "Amazon EC2" instead of "Amazon Elastic Compute Cloud" (or it could even be, "Amazon Elastic Compute Cloud (EC2)") and "Amazon S3" instead of "Amazon Simple Storage Service." However, it has "Identity and Access Management" versus "IAM" and "AWS Key Management Service" instead of "AWS KMS." It's frustrating not knowing whether to search for the full name or the acronym.


Add h7 power management

Requires https://github.com/zephyrproject-rtos/zephyr/pull/41869 to be completed beforehand.

Also requires https://github.com/zephyrproject-rtos/zephyr/pull/41867 to be completed beforehand.

In the project where we were using the H7 the requirement for power saving was dropped. On top of that, additional tasks for getting the power saving up and running popped up, like having to change clock frequency dependening on the VOS-level, ... and so on. Unfortunately getting power saving right is rather difficult.

Ok, thanks for the info. Does it need some improvements to be merged? At the first glance, it looks like ready to merge.

I haven't finally tested it in this state, with some parts being stripped out into other PRs. Therefore, I would heavily advise for testing it on the actual hardware first.


attempt 3.9 testing

This PR is the initial attempt to support Python 3.9 for CI testing.

See original PR in #71.

Dependencies not yet there for 3.9. Leaving this open for now and will check back periodically.
Looks like the specific failure here is:
numpy[version='>=1.3'] -> blas=[build=mkl] -> liblapacke==3.8.0[build='4_mkl|5_mkl|6_mkl|9_mkl|11_mkl|14_mkl|16_mkl|21_mkl|20_mkl|19_mkl|18_mkl|15_mkl|13_mkl|12_mkl|10_mkl|8_mkl|7_mkl']

how come we're pinning scikit to 0.22?

how come we're pinning scikit to 0.22?

how come we're pinning scikit to 0.22?

No idea. Let's try without a pinned version?

how come we're pinning scikit to 0.22?

No idea. Let's try without a pinned version?

this is supreceded by #95

this is supreceded by #95


Phrase relatedness

Phrase Relatedness

@googlebot I signed it!

Not a reviewer. @LuisOlCo, thank you for submitting the task!
As I understand, you're using data from 3 datasets:

Big BiRD by Asaadi et al. 2019
TR9856 by Levi et al. 2015
WORD by Ein Dor et al. 2018

I would kindly suggest to state their licenses (e.g. Apache) in the readme, to ensure compliance with the licensing requirement, as described here.

Hi,
I am one of the two assigned reviewers. This task looks interesting. It evaluates phrase relatedness, which requires a compositional understanding of words. I will likely vote for inclusion.
Correctness:
The task is correct. Although I think it would be more readable if the author writes it as a Python task with a separate data file. The current form makes it quite difficult to go through all test data.
Difficulty:
The task is difficult. An especially interesting point is the composition of words might have a meaning different from their "average" meanings. I think of this as the hard instances from the phrase relatedness problem. For example, a toy spacecraft is a toy instead of spacecraft. It might be valuable to compute a specific measure separately for these hard instances.
Not solvable by memorizing the Internet:
Yes.
Novelty:
The task is novel and builds upon several existing work.
Justification:
The author clearly justifies the motivation of this task.
Size:
The task is of reasonable size.

requires licensing review @chiafullo

@LuisOlCo We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!

@kaustubhdhole are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

@nick11roberts are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

@XudongOliverShen are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

The amount of tasks we received this round is tremendous.  With so many tasks to review we have decided to extend the review period to Tuesday, June 29.
Reviewers: if the submitter has made revisions please be sure to notify me with a formal ”accept” or ”does not meet criteria” by Tuesday, June 29  (if you haven't already done so).
this is an automated message

@chiafullo, Data Source section added to README.md

Accept @chiafullo

Your task has been accepted in the initial review stage.  The next stage of this process is for us to assign your task a meta-reviewer for final review and merge.  An assigned meta-reviewer will follow-up by commenting on the PR should it need further revisions.

Hi, I am the meta-reviewer for this task, and I have discovered some issues with this task that I was wondering if you could address?
Unfortunately, this was overlooked by the previous reviewer, and sadly due to the enormous amounts of taks that were submitted, there was never a second reviewer that got around to this one. Sorry about that!
I believe the taks is well motivated, and I think in the main idea is a good one in testing semantic understanding, like the fact that a toy spacecraft is a toy instead of spacecraft.
My two main concerns are:

Currently, the presentation of the problem just gives the word, like "Citizenship", and is asking which of the choices ("Compulsory voting", "Internet", "Airport", "Immigration to the United States") are more semantically similar.
I believe the task would greatly benefit from adding a task_prefix to the json task like: "Which of the following phrases is most related to ".
I believe this could be easily addressed.
After manual inspection and some analysis of the examples in the task, I am concerned that many of the examples are not always providing insight towards the natural language understanding of large language models (this is not an exhaustive list):

"Trivial" by reordering: In 130 examples (8.9% of the overall examples), the right answer is simply found by reordering of the words{"input": "business management",  "target_scores": {"public administration": 0, "management business": 1, "field": 0, "collective": 0}},
{"input": "food quality", "target_scores": {"safety": 0, "quality food": 1, "project": 0, "control": 0}}

Although, there are 10 examples (0.7% of the overall examples) where the reordering of the words is the wrong answer, like{'input': 'flight training', 'target_scores': {'training flight': 0, 'flying instruction': 1, 'examination': 0, 'aircraft': 0}},
{'input': 'work site', 'target_scores': {'working area': 1, 'labour force': 0, 'site work': 0, 'location': 0}}

I would have liked to either see the same number of each of these, or preferably more of the second kind that is testing a very interesting non-trivial understanding in the language models.
Single word match: In 13% of the examples that only have a single word in the input (69 of 529 examples), the right answer contains the input word, while this never occurs in the wrong answers. For example{'input': 'speech', 'target_scores': {'gas chambers': 0, 'freedom of speech': 1, 'leaking': 0, 'government': 0}}
{'input': 'documents', 'target_scores': {'military documents': 1, 'official secrets act': 0, 'penalty for treason': 0, 'leaking': 0}}
{'input': 'children', 'target_scores': {'gender': 0, 'sterilized': 0, 'children per woman': 1, 'cardiovascular': 0}}

Synonyms vs. opposites vs. related concepts: It is not clear to me exactly how one defines "semantically related" in the description of the task, and I believe the task would benefit from a clearer definition or a separation between different kinds of concepts.
For example, sometimes the synonym is labeled as correct{'input': 'Murder', 'target_scores': {'Manslaughter': 1, 'Age of consent': 0, 'Multiculturalism': 0, 'Surety': 0}}

Sometimes they're more opposites,{'input': 'Childbirth', 'target_scores': {'Gene': 0, 'Classical element': 0, 'Abortion': 1, 'Advanced Audio Coding': 0}}

And most of the time they are more about finding the target that has some topic overlap with the input{'input': 'Employment', 'target_scores': {'Gender pay gap': 1, 'Futures contract': 0, 'Adverse selection': 0, 'Federal Insurance Contributions Act tax': 0}}

While I do think it's great that there is good coverage in terms of different kinds of semantic "relatedness", I have some mixed feelings about the "opposites" and to what extent I think a language model should consider them as "related".
Ambiguous answers: While manually inspecting examples, I have found quite a few examples I would consider ambiguous in term of what the true answer should be. Some examples are{{"input": "pope benedict xvi", "target_scores": {"calendar based methods": 0, "catholic church": 1, "cardinal": 0, "diseases": 0}} # He used to be a cardinal
{{"input": "Income", "target_scores": {"Base and superstructure": 0, "Rolling stock": 0, "Saving": 1, "Purchasing power": 0}} # One could argue "Purchasing power" is just as related to income as "Saving".
{{"input": "Heart", "target_scores": {"Liver": 1, "Transplant rejection": 0, "Patient": 0,"Chemical formula": 0} } # Yes, the heart and liver are both organs, but "Heart transplant rejection" is also a real concept.

While this is subjective and harder to quantify, I'm concerned to what extent the score of this task is truly meaningful since other answers are also meaningful.

Lastly, I want to flag that several 'input'-'correct answer' pairs exists with different alternatives. For example,{"input": "Science", "target_scores": {"Culling": 0, "Organism": 1, "Wildlife Conservation Society": 0, "Circle": 0}}
{"input": "Science", "target_scores": {"Bering Strait": 0, "Numeral system": 0, "Organism": 1, "Teratoma": 0}}
{"input": "Science", "target_scores": {"Organism": 1, "Food and Drug Administration": 0, "Demarcation problem": 0, "Whaling": 0}}

If one were to create a train/test split, and fine-tune on the train data, one could see improvement just from memorization and not improved understanding of the phrase relatedness.

I apologize for the long message, but I wanted to be as concrete as possible in what sort of issues I have with the current form of the examples in the task.
I do think the task is well motivated and there are lots of good examples in the task that would give valuable insights into how large language models handle phrases that are related.
I have consulted with some of the organizers, and if you are able to address these issues in the next week, we will review it again and hopefully be able to include your task.
Unless there is a simple way to change the pipeline for generating these examples to address these issues, I would propose that you remove the lower quality examples and leave only the ones that focuses more on truly interesting behavoir of large language models' understanding of phrase relatedness.
Sorry again for the delay in the review and the extra work, and thank you for your submission!

Hi @andersjohanandreassen,
Thank you very much for the detailed feedback, I really appreciate you took the time to include examples and go over the the json file.
I will go over the file and remove those examples that fall into the categories that you mentioned. I will make sure I have ready next week.
Thanks again!

Hi @andersjohanandreassen,
I have manually reviewed the task file and deleted those examples that did not meet the criteria.
From 1,468 examples that we had,  we ended up with 661 samples,  I believe the remaining examples are valuable and interesting for testing Language Models.
Modifications:

Added the task_prefix field
"Trivial" by reordering: For this issue, I have decided to leave equal number of examples of each type.
Single word match: This examples have been all deleted. There are some examples where the word maybe be part of a complex word and it is present in both, correct and wrong answer, in those cases I think they could be relevant:

            "input": "war years",
            "target_scores": {
                "military": 0,
                "postwar period": 0,
                "wartime": 1,
                "air force": 0
            }

Synonyms vs. opposites vs. related concepts: All those examples where the correct answer represents the opposite meaning of the input have been deleted.
Ambiguous answers: I have removed all those examples that to the best of my knowledge entail some ambiguity.
Several 'input'-'correct answer' pairs: also fixed.

Please, feel free to reach out if there was anything else that may need to be modified.
Thanks for the feedback!

Hi @LuisOlCo. Thanks again for updating the task, and apologies for the long process.
After inspection of the updated task.json, I'm still concerned that the number of examples that are ambiguous is still quite high.
Just looking through the first examples, here are some examples I still find problematic:

food quality also related to safety and not just quality food
Hillary Clinton has been in the Federal government of the United States
fighting crime has target crime fighting, but could also be criminal or perhaps also enforcement
diversity could be interpreted as related to either multiculturalism, levels of immigration or endangered species
voter registration seems related to both  voters and polling station

Instead of arguing over which examples are ambiguous or not, would it be possible for you to pick out O(100) of the best and most interesting examples that illustrates the interesting behavior you want to show with this task?

Hi @andersjohanandreassen,
Perfect! I will prepare the task file with the best examples. I will have it ready soon.
Thank you very much.

Hi @andersjohanandreassen,
I have modified the task file, and I only have included those examples that I find interesting and do not entail any kind of ambiguity.
Although the task file is considerably smaller, I think that the content's quality is higher than previous versions.

Thank you again for making the changes.
The examples looks much better now, and I'm happy to approve the meta-review!


Including hashtag in link URL breaks the link when rendering

For example, if I pass in {text: "#awesome", weight: 15, link: "/tags/%23awesome"} it alters the HTML escape character and renders it as #awesome.

Seeing exactly the same thing here


Fix #1492:Attributes equals now is order sensitive

Since Attributes are implemented by map, so the comparison can be realized by calling equals() for map in the function equals() in Attributes.java

Thanks and sorry for the late reply.
This implementation doesn't work, because dataset() is a filtered list of attributes that start with "data-".
You're basically making equals() return true for every attribute set that does not include data- attributes.
Generally it's a good idea when writing test cases to include negative cases (in this case, things that should not be equal) to catch that kind of error.


Use Bamboo as source of truth for org chart?

I notice it takes a lot of work and duplicated data to recreate the membership list of each team and the org chart in the handbook. Our source of truth for this stuff is Bamboo. Should we just link to Bamboo for the membership list of specific teams, and for the org chart?
I'd say yes, since it does not seem worth the time for someone here to update this in 2 places (and in practice, it's only done some not all teams here at Sourcegraph). If I'm missing something and people find it really useful to have in the handbook, or if someone is keeping tabs on all the individual team pages and department org structure pages, then let me know.

(Actually, I think it is useful as Bamboo doesn't really encode when someone is manager of more than 1 team, or interim manager of a team, etc.)


Updates

reorder sections to be alphabetical
fill in placeholder text for contributing.md
add react on rails starter

Thank you @apolopena


When enabling #timesRepeat: to be optimised, fail: SindarinCommandsTest>>testStepToNextCallInClassNeverFinishes

I would like to enable #timesRepea: to compile as an optimized construct by default
(see https://github.com/pharo-project/pharo/pull/11439)
But SindarinCommandsTest>>testStepToNextCallInClassNeverFinishes  relies on the method to be not optimised.
A minimal change would be to have it for now as
acceptVisitorNeverFinishes: aVisitor
	<compilerOptions: #(- optionInlineTimesRepeat)>
	10000 timesRepeat: [ self doStuff ]

How to change that so that we get it in Pharo11?
Somehow the package is neither really external nor internal, that is, I have no idea how to commit a change.

I found where Sindarin is imported!
It's imported from
BaselineOfNewTools>>#sindarin:

So you can do the changes I suggested above and modify the URL in this method in NewTools

In the end this was in the NewTools package....
https://github.com/pharo-spec/NewTools/pull/394

I merged the PR


Change forcing variable LAI_IN to LAI

Version VIC.5.0.1
This is just a very minor change: changing the name of the forcing variable LAI_IN to LAI.  This is just for simplicity/aesthetics.  I think it used to conflict with another instance of the term LAI but no longer does.
This is technically not backwards-compatible as it requires users to update their global parameter files to list LAI instead of LAI_IN as a historical forcing variable.  However, I believe I might be the only user to have used this feature so far, and I am happy to make this change.

Yes, this belongs in 5.1. Can you put this together in association with #764?

Yep, this is already in my PR #723

Closed by PR #723


Rule idea: Warn of using variables without interpolation in css custom properties

I've been bitten a few times by writing SCSS variables in CSS custom properties without interpolation. It would be great if we could lint and warn about this potential issue automatically.
Basically the same problem as here: https://github.com/stylelint-scss/stylelint-scss/issues/388
I read what dollar-variable-no-missing-interpolation is supposed to do and I agree with @kristerkari that it's not supposed to fix this issue. So I'm suggesting a new rule to handle this problem.
To re-use the example from that previous issue:
When I accidentally write:
.class {
  $var: 2rem;
  --gap: $var;

  display: grid;
  gap: var(--gap);
}

That gets rendered like this and does not work as I intended:
.class {
  --gap: $var;

  display: grid;
  gap: var(--gap);
}

When I should have written:
.class {
  $var: 2rem;
  --gap: #{$var};

  display: grid;
  gap: var(--gap);
}

That gets rendered to:
.class {
  --gap: 2rem;

  display: grid;
  gap: var(--gap);
}

If you have any other ideas how to tackle this issue with already existing rules, please let me know.

It would also be useful to expand this beyond variables to other Sass-specific constructs. In particular, namespaced function calls, known Sass global functions that aren't shadowing CSS globals, and operations outside calc() should all get warnings.


[V1] Use FlashInfer Sampling Kernel for Top-P & Top-K Sampling

This PR brings FlashInfer's top-p & top-k sampling kernel to the V1 sampler.
The PyTorch-native implementation of top-p and top-k sampling requires sorting the entire logits tensor, which could be very large when the batch size is large. As a result, the sorting op can take ~20% performance overhead in high-throughput settings. By leveraging the FlashInfer's kernel, we can reduce this down to almost zero.
ShareGPT benchmark:

main w/o top-p & top-k: 47.40 reqs/s
main w/ top-p: 40.20 reqs/s
This RP w/ top-p: 47.15 reqs/s

@sroy745 @comaniac Could you please take a look?


Possible fix for update only changed settings

As explained here: https://github.com/akaunting/setting/issues/53

This doesn't save the settings at all.

For me works fine.


Suggestion: accept issues only after the submitter has contributed

Hi Allen
Great project but it looks like you are very busy, maybe getting overloaded.
Maybe you could put in your README that if someone wants to post an issue, they must first contribute to the project by fixing a bug or making a cash donation of > $30
Just an idea....  I want to see this project succeed and maybe it won't unless you get help.

@crowdwave, thanks your idea, I'll back this project soon(Hopefully). For me in the future(After v4.0.0), I'll focus on major bug issues and stop feature development if the feature was too big and not very necessary.  I'll announce this information after v4.0.0. As i know, there's some great react table component on github, I encourage you guys to try the other table components. I think react-bootstrap-table is not the best. Actually, this project was started by a goal of learning react.js by myself. I was surprised it become little popular, I think you will know what I means after you trace the code. I do too many wrong things on this project, because I treat this project as a practice for me at starting...   Anyway, for now, the only thing I can do is still enhance code and functionality when I have free time.
thanks :)

Hi, @AllenFang. Could you please give a link to "some great react table component on github" ? :)

I think you're doing excellent work Allen and I have seen no grids more suited to what I am trying to do. Thanks for your work.

@epsyan, for example,

https://github.com/adazzle/react-data-grid
https://griddlegriddle.github.io/Griddle/
https://github.com/tannerlinsley/react-table


Update create-first-function-vs-code-other.md

Some incorrect info here and want to mention about creating functions automatically using windows

@ggailey777
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


get hand joints software or hardware limits

Brief description
Similar to this wiki page http://wiki.icub.org/wiki/ICub_joints_limits where we can find the joint limits of iCub, I would like to know what are the software/hardware joint limits of the left and right hand.
Detailed context
Is it possible to get the limits of the joints of the hand from a yarp device sth like https://www.yarp.it/classyarp_1_1dev_1_1IControlLimits.html#a67727bdb91bddeb1c070d44904d501cc that is implemented for the axis limits.
To be more precise, I need the limits for transforming the raw values of the iAnalogSensor to the Degree. Therefore, the exact limits necessary for calibration process is: when the related axis goes to its boundaries, we should know what are the joints values  in order to calibrate tranform the raw values to degrees.
I saw there is the calibrateSensor , calibrateChannel methods in iAnalogSensor device,  what are their use?!
@pattacini @xEnVrE

Hi @kouroshD,
if you want to extract plausible angular values for the joints of the entire chain of the finger starting from the motor encoders and/or the analog sensors, I suggest you reading this brief tutorial.
Regarding your specific question about limits, let me briefly add some context. From my experience, the maximum and minimum values that the analog sensors assume might depend from robot to robot. For this reason, the best solution would be to find these values by means of experiments and write down in a matrix. Once you have this calibration matrix, there is a specific method of the iCub forward kinematics API, namely iKinFwd::iCubFinger::getChainJoints, that allows you get the angles of the entire finger chain starting from the motor encoders, the analog sensors and, optionally, the calibration matrix.
Let me know if my explanation answers your question.

Thank you @xEnVrE  for the response. I've checked already that issue, which is very useful.
However, in practice my question is how chain[i].getMax() and chain[i].getMin() are found in the issue you have mentioned.
Also, I am curios to know:
in (1.0-std::min(1.0,std::max(0.0,analogs[2+i]/255.0))) why it is written in this way, and why not simply (1.0- analogs[2+i]/255.0)? Because of possible spikes in the measures?!

From my experience, the maximum and minimum values that the analog sensors assume might change from robot to robot.

I agree with you, I think it should depend on  how the hall effect sensors are placed in the fingers joints. Then, another question will arise is that, every time we turn on the robot, these values should be the same? Am I right? If  some maintenance goes on with the fingers, these values should be checked again. Is that correct?!

However, in practice my question is how chain[i].getMax() and chain[i].getMin() are found in the issue you have mentioned.

These limits are set inside the iCubFinger::allocate() method. E.g. at line 1932, you find something like
pushLink(new iKinLink(0.0259, 0.0,       0.0, 0.0, 0.0, 90.0*CTRL_DEG2RAD));

where the last two arguments are exactly those returned by getMin() and getMax() respectively. However, nothing prevents you from aligning these limits with those coming from the robot using the method iCubFinger::alignJointBounds(). This method accepts a list of yarp::dev::IControlLimits interfaces.

Also, I am curios to know:
in (1.0-std::min(1.0,std::max(0.0,analogs[2+i]/255.0))) why it is written in this way, and why not simply (1.0- analogs[2+i]/255.0)? Because of possible spikes in the measures?!

I think so, basically to handle negative (slightly below 0) or > 255 readings.

I agree with you, I think it should depend on how the hall effect sensors are placed in the fingers joints. Then, another question will arise is that, every time we turn on the robot, these values should be the same? Am I right? If some maintenance goes on with the fingers, these values should be checked again. Is that correct?!

Not an easy question. Maybe the best solution is to repeat the calibration every so often or, at least, check if matches the one you have stored before doing an important experiment. Also, it depends on the kind of experiment you have in mind. If you can accept "some" errors, the ranged spanned by the sensors should be more or less the same.

(1.0-std::min(1.0,std::max(0.0,analogs[2+i]/255.0))) is just a safety guard to make 100% sure that nothing will escape those bounds, even if the source will be yielding data withing the allowed range.

Thank you for explanation @xEnVrE .
To complement you explanation,  we have 19 joints, each finger 4 joints except the middle 3 joints.
All the link numbers in  iCubFinger::allocate()  are consistent with that and with the order abduction/adduction, proximal, and the two distal;. However,  thumb has 5 links, where the second one has no dof and is a fixed link: https://github.com/robotology/icub-main/blob/9b2a78301f5fc64a3223eb9515cc0c0f87c4dbcf/src/libraries/iKin/src/iKinFwd.cpp#L1898


Update interpolation.json to match .yml

Also update the Rakefile to ensure the "__ATTN__" notice is the
at the start of the file.

This pull request is obsoleted by #90.


Fix electron docs page not found.

Why:
When visiting Electron docs the url from Github docs  takes you to https://electronjs.org/docs/ which is not a valid url. The valid url is https://electronjs.org/docs/latest

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@meel-hd Thanks for submitting a PR with this fix! ✨
It looks like this link was updated in a recent PR merged today. So I'm going to go ahead and close this one.
Thank you for your interest in improving GitHub Docs! :sparkling_heart:


TypeError: mel() takes 0 positional arguments but 5 were given

I'm following the instructions to get started, so to get the gist of it i'm using the provided lists and wavs while just adapting the paths to my system's.
After running the command python train_ms.py -c configs/config.json -m checkpoints, I encountered a TypeError when calling the mel() function in the spec_to_mel_torch() function in the mel_processing.py file, any help appreciated.
Traceback:
INFO:torch.distributed.distributed_c10d:Added key: store_based_barrier_key:1 to store for rank: 0
INFO:torch.distributed.distributed_c10d:Rank 0: Completed store-based barrier for key:store_based_barrier_key:1 with 1 nodes.
./vits-finetune/checkpoints/G_0.pth
INFO:checkpoints:Loaded checkpoint './vits-finetune/checkpoints/G_0.pth' (iteration 0)
./vits-finetune/checkpoints/D_0.pth
INFO:checkpoints:Loaded checkpoint './vits-finetune/checkpoints/D_0.pth' (iteration 0)
  0%|                                                                                | 0/8 [00:52<?, ?it/s]
Traceback (most recent call last):
  File "train_ms.py", line 306, in <module>
    main()
  File "train_ms.py", line 56, in main
    mp.spawn(run, nprocs=n_gpus, args=(n_gpus, hps,))
  File "/mnt/d/AI/vits-finetuning/venvwsl/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 240, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/mnt/d/AI/vits-finetuning/venvwsl/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 198, in start_processes
    while not context.join():
  File "/mnt/d/AI/vits-finetuning/venvwsl/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 160, in join
    raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:

-- Process 0 terminated with the following error:
Traceback (most recent call last):
  File "/mnt/d/AI/vits-finetuning/venvwsl/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 69, in _wrap
    fn(i, *args)
  File "/mnt/d/AI/vits-finetuning/train_ms.py", line 124, in run
    train_and_evaluate(rank, epoch, hps, [net_g, net_d], [optim_g, optim_d], [scheduler_g, scheduler_d], scaler, [train_loader, eval_loader], logger, [writer, writer_eval])
  File "/mnt/d/AI/vits-finetuning/train_ms.py", line 160, in train_and_evaluate
    hps.data.mel_fmax)
  File "/mnt/d/AI/vits-finetuning/mel_processing.py", line 78, in spec_to_mel_torch
    mel = librosa_mel_fn(sampling_rate, n_fft, num_mels, fmin, fmax)
TypeError: mel() takes 0 positional arguments but 5 were given

Additional Information:

Running on a brand new WSL Ubuntu install with Python 3.7 and venv.
To install torch i used the official site's instructions:

pip3 install torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/cu116

Same for cuda, used nvidia's website instructions.

My pip freeze:
For version comparison
absl-py==1.4.0
appdirs==1.4.4
audioread==3.0.0
cachetools==5.3.0
certifi==2022.12.7
cffi==1.15.1
charset-normalizer==3.0.1
cycler==0.11.0
Cython==0.29.33
decorator==5.1.1
fonttools==4.38.0
google-auth==2.16.1
google-auth-oauthlib==0.4.6
grpcio==1.51.3
idna==3.4
importlib-metadata==6.0.0
joblib==1.2.0
kiwisolver==1.4.4
lazy_loader==0.1
librosa==0.10.0
llvmlite==0.39.1
Markdown==3.4.1
MarkupSafe==2.1.2
matplotlib==3.5.3
msgpack==1.0.4
numba==0.56.4
numpy==1.21.6
oauthlib==3.2.2
packaging==23.0
Pillow==9.4.0
pooch==1.6.0
protobuf==3.9.2
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.21
pyopenjtalk==0.3.0
pyparsing==3.0.9
python-dateutil==2.8.2
requests==2.28.2
requests-oauthlib==1.3.1
rsa==4.9
scikit-learn==1.0.2
scipy==1.7.3
six==1.16.0
soundfile==0.12.1
soxr==0.3.3
tensorboard==2.11.2
tensorboard-data-server==0.6.1
tensorboard-plugin-wit==1.8.1
threadpoolctl==3.1.0
torch==1.13.1+cu116
torchaudio==0.13.1+cu116
torchvision==0.14.1+cu116
tqdm==4.64.1
typing_extensions==4.5.0
Unidecode==1.3.6
urllib3==1.26.14
Werkzeug==2.2.3
zipp==3.15.0

You should downgrade librosa.
I worked well at librosa==0.8.0
so you should do pip install librosa==0.8.0 and maybe work fine.

You should downgrade librosa. I worked well at librosa==0.8.0 so you should do pip install librosa==0.8.0 and maybe work fine.

I confirm it will work also for the newer version  librosa==0.9.1.
This will give a warning that version 0.10 will throw an error.

Chnage the code as below:
mel_basis = librosa_mel_fn(
           sr=sampling_rate, n_fft=filter_length, n_mels=n_mel_channels, fmin=mel_fmin, fmax=mel_fmax
        )


Update UAVCAN submodule

This submodule update adds internal combustion engine-related messages, in support of https://github.com/ArduPilot/ardupilot/pull/6438.

Merged, thanks! I opted to do it with Git, I'm not completely sure what GitHub does here, but I think it would create new commits, which we don't want given we are just updating to be on par with upstream.

Okay, thanks!


Error exporting subworkflow

When exporting the big all-in-one subworkflow that includes the 2 variants for single-end and paired-end workflows the export fails with
galaxy.web.framework.decorators ERROR 2020-06-01 18:04:18,839 Uncaught exception in exposed API method:
Traceback (most recent call last):
  File "/Users/mvandenb/src/galaxy/lib/galaxy/web/framework/decorators.py", line 295, in decorator
    rval = func(self, trans, *args, **kwargs)
  File "/Users/mvandenb/src/galaxy/lib/galaxy/webapps/galaxy/api/workflows.py", line 471, in workflow_dict
    ret_dict = self.workflow_contents_manager.workflow_to_dict(trans, stored_workflow, style=style, version=version)
  File "/Users/mvandenb/src/galaxy/lib/galaxy/managers/workflows.py", line 480, in workflow_to_dict
    wf_dict = to_format_2(wf_dict)
  File "/Users/mvandenb/src/galaxy/lib/galaxy/managers/workflows.py", line 461, in to_format_2
    return from_galaxy_native(wf_dict, None, **kwds)
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.8/site-packages/gxformat2/export.py", line 54, in from_galaxy_native
    output_id = labels.ensure_new_output_label(workflow_output.get("label"))
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.8/site-packages/gxformat2/_labels.py", line 17, in ensure_new_output_label
    assert label not in self.seen_labels
AssertionError

I think assert label not in self.seen_labels might need to be scoped to individual workflows ?

This is the .ga in question: https://gist.github.com/mvdbeek/7d6c1da73e54b12f0163c0440b786161
just tracking it here so I don't forget.

I'm not sure what to do here ... if we want to switch to export gxformat2 by default we should be able to export all existing workflows IMO, but if we auto-fix or drop the redundant labels we can't go back to the native format without losing the labels. As a sidenote, you can't produce a workflows like this anymore because of https://github.com/galaxyproject/galaxy/pull/10432 and the editor will try to "fix" this for you by dropping the redundant labels ... which I guess is an option ?

As a sidenote, you can't produce workflows like this anymore because of galaxyproject/galaxy#10432 and the editor will try to "fix" this for you by dropping the redundant labels ... which I guess is an option ?

I agree that dropping the redundant labels is a good option, since that's also what happens if you try to import into UseGalaxy.org the .ga file you linked above.

Try uploading the workflow, then downloading it. The redundant label is still there. If we silently dropped the label on import that would be really really bad, but that's not happening. The editor will warn you about the duplicate label and then drop it, you need to save for the label to disappear.
I think we've decided we'd fall back to the .ga download when we can't produce .gxformat2 because of this issue.


weird taskid when using ajax post

pyspider version: 0.3.10
Operating system: OSX

crawling pages with ajax-post like the following (ajax_url is unique all times)
for page in pages:
    params['page'] = page
    self.crawl(ajax_url, method='POST', data=params, callback=self.detail_page, save=response.save)

two things look so weird:

finished so early, even there are so many pages should be crawled.
only one record in result page

When looking into the source,

in sqlite.resultdb.py

    def _create_project(self, project):
        assert re.match(r'^\w+$', project) is not None
        tablename = self._tablename(project)
        self._execute('''CREATE TABLE IF NOT EXISTS `%s` (
                taskid PRIMARY KEY,
                url,
                result,
                updatetime
                )''' % tablename)

taskid is the primary key, unique one.

in lib.base_handler.py._crawl

        task['project'] = self.project_name
        task['url'] = url
        if 'taskid' in kwargs:
            task['taskid'] = kwargs.pop('taskid')
        else:
            task['taskid'] = self.get_taskid(task)

    def get_taskid(self, task):
        '''Generate taskid by information of task md5(url) by default, override me'''
        return md5string(task['url'])

md5string of the ajax_url could be unique all times.
That's the problem. ajax post owns one unique url.
What kinds of things could be done in minimal effort? Thanks so much.

@ericxsun i'm not family with python, can you explain how to overwrite get_taskid


svelte-kit caching with yarn PNP

Describe the bug
Overview
Previously there was some discussion over the use of yarn PNP / berry here

https://github.com/sveltejs/kit/issues/993

The main advantage of PNP is that it allows you to reference packages from a global cache on the disk (similar to pnpm except without the disk hard links). So it saves on disk space with the global cache setting enabled.
With yarn 3.2.1 PNP this sort of half works.
If you install and set everything up then it works fine on the first run, but then fails on the follow up run due to something related to the .svelte-kit caching
Reproduction
Example
First setup a new svelte kit app (skeleton)
yarn create svelte myapp
cd myapp

Switch to yarn berry with PNP
yarn set version berry

Add the following to the config under the kit section of svelte.config.js
kit: {
    vite: {server: {fs: {allow: ['.yarn']}}},
}

Try yarn dev
yarn dev

At this point things work on the first run
On follow up runs this error shows up
> p.replace is not a function
    at Object.toPortablePath (C:\SourceCode\project-docs\example\.pnp.cjs:2808:9)
    at PosixFS.mapToBase (C:\SourceCode\project-docs\example\.pnp.cjs:5313:18)
    at PosixFS.rmdirSync (C:\SourceCode\project-docs\example\.pnp.cjs:5230:39)
    at URLFS.rmdirSync (C:\SourceCode\project-docs\example\.pnp.cjs:5230:24)
    at _rmdirSync (node:internal/fs/rimraf:260:21)
    at rimrafSync (node:internal/fs/rimraf:193:7)
    at node:internal/fs/rimraf:253:9
    at Array.forEach (<anonymous>)
    at _rmdirSync (node:internal/fs/rimraf:250:7)
    at rimrafSync (node:internal/fs/rimraf:193:7)

If I delete the .svelte-kit directory then it works fine again for a first run.
Logs
No response
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 5.34 GB / 15.68 GB
  Binaries:
    Node: 18.1.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.2.1 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.11.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (103.0.1264.44)
    Internet Explorer: 11.0.19041.1566

Severity
annoyance
Additional Information
No response

Just to add the quick way to turn PNP off
.yarnrc.yml
nodeLinker: node-modules

This gets around the above but means more disk space used

Not sure if they are plans to support this per https://kit.svelte.dev/faq#integrations-how-do-i-use-with-yarn-how-do-i-use-with-yarn-3

I wrote that (the yarn 3 part)
I figured I'd raise this issue as I suspect the problem with pnp might be with the way the caching works inside the .svelte-kit directory which might be a svelte-kit issue.
One thing that could be done to make things better is to add the .yarn directory into the defaults passed to vite
kit: {
    vite: {server: {fs: {allow: ['.yarn']}}},
}

Oh sorry I didn't know that 😅 I'm not sure how yarn pnp affects .svelte-kit caching, but it seems like yarn is doing something off. Does specifying .yarn in server.fs.allow fixes it?

It doesn't fix the .svelte-kit caching issue (I'm not sure how to fix that outside of just deleting the cache directory each time before running)
but it does fix a warning vite shows up when you try to run things this way

Awhile back I was trying to get sveltekit to work with yarn berry but ran into the same issue. I believe this PR will fix it on yarn's side: https://github.com/yarnpkg/berry/pull/3889.
The third issue mentioned in that PR (3783) looks like a very similar error we are getting here, but I could be wrong.

is there anything kit can/should do here? Looks like yarn pnp still has issues to solve on their end.
The fs.allow setting can be provided by pnp users in config. Automatic detection would be something either for vite or a supporting vite-plugin-yarn-pnp.

Using yarn 3.2.2 which included the pr I had mentioned above the issue still persists.

I think this has been fixed in a more recent version of yarn. I have been able to successfully use sveltekit with the current version of yarn (4.1.1).
There is an issue with the use of prettier and plugins (which shows up in sveltekit), I was able to patch that in prettier though. See https://github.com/wooorm/import-meta-resolve/issues/26 and https://github.com/prettier/prettier/issues/15513.

Still reproduced in yarn 4.4.0


Update devcontainer.json

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Is this intended to be a public PR? If so, please update the description with rationale for the change.

No, that request could be ignored or deleted, thx
Von: Pamela @.>
Gesendet: Donnerstag, 19. Oktober 2023 23:25
An: @.>
Cc: Rene @.>; @.>
Betreff: Re: [Azure-Samples/azure-search-openai-demo] Update devcontainer.json (PR #827)
Is this intended to be a public PR? If so, please update the description with rationale for the change.
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure-Samples/azure-search-openai-demo/pull/827#issuecomment-1771728124, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADKVN2PZHMP57Y5DRAZJILLYAGLGFAVCNFSM6AAAAAA6FTKGTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRG4ZDQMJSGQ.
You are receiving this because you authored the thread.Message ID: @.***>


Tests are taking too long in development

It's fairly natural that our tests will start taking longer to run the more code we have, but I've noticed a dramatic increase in the time taken recently.
This ticket is to help us figure out what's slowing us down and whether there's anything we can do to speed our development process up. This ticket encompases both unit + behaviour testing.
As part of this ticket you should investigate:

[ ] Which tests (or groups of tests) are taking the longest to run

[ ] Whether there are any similarities between tests which are taking a long time

[ ] Is there anything we can do to speed up any of our tests?
[ ] Figure out whether there are a sensible set of groups of tests we could defer to execution on pull requests/merges to main that devs could avoid running on their local boxes (if they haven't touched the code).

If you have any other suggestions which you think might help reduce the need to run quite so many tests locally, bring them up as part of this ticket.
N.B. actually implementing any of these suggestions is outside of this ticket - you'll need to create the tickets once we've agreed on the approach we'll want to take (if any).

pytest-bdd

We need to reduce the size of CSV datasets in the test cases folder. Challenge is how we can do this whilst making sure the unit tests are still meaningful (i.e. covers the real-world scenario).

And yes I agree with Andrew on pytest-bdd. So we can keep unit and bdd tests within the same framework - will look good on IDEs too.

As of today's refinement meeting, here are our initial thoughts on how we can speed stuff up:
Short Term

Do we use Swirrl's AOT-compile version of csv2rdf in our docker image -- will this speed things up enough for now?
What are we really using csv2rdf for? Is this something that can be replaced by direct queries to the JSON-LD metadata files?

Longer Term Solutions

How frequently are we running the SPARQL tests -- is it worth investing effort in rewriting them so they work against the CSV-W?

pytest-bdd -- will speed things up at all? Parralelisation -- can we configure this so it runs 4 processes locally but only 1 on Jenkins to avoid resource problems?

Andrew G suggested - could we keep a long-running docker container open for csv2rdf so we don't deal with the startup times problem so much?

A quick summary of the length of time it takes to run the pytest suite (top 20 longest tests).
The 20 least performant tests are 62s of approximately 102s on my machine. Improving the performance of our pytest testing suite doesn't feel like a good use of time.  Again, considering we got behave tests twice as fast by using a native-AOT csv2rdf docker image there's diminishing returns here. A lot of tests which use csv2rdf are checks if a specific qube is still valid at lint and after RDF serialisation. Many of these can be consolidated, conceivably by creating fewer scenarios which contain the individual features in a single cube.
Summary of csv2rdf calls in feature files (23 total)

19 in qbwriter
2 in skoscodelists
2 in dcatcommandline

Note that none of these steps are expected to fail, so a "monster test case" might be possible unless testing data shape differences (i.e. single or multi measure). Additionally, you cannot consolidate testing for failures, since you want to see a specific failure, opposed to any failure.
qbwriter.feature
This following table summaries the state of qbwriter's features which use csv2rdf. Consolidation is possible into a minimum of two tests in a "monster" qube.

Scenario Name
Single, Multi, or Not Relevant
Consolidation possible

A QbCube should generate appropriate DCAT Metadata
Not relevant
Yes

A QbCube should validate successfully where foreign key constraints are met.
Not relevant
Yes

QbCube new attribute values and units should be serialised
Not relevant
Yes

QbCube extended units (and new base units) should be serialised correctly.
Not relevant
Yes

A QbCube with string literal new attributes should validate successfully
Not relevant
Yes

A QbCube with numeric literal new attributes should validate successfully
Not relevant
Yes

A QbCube with date literal new attributes should validate successfully
Not relevant
Yes

A QbCube with string literal existing attributes should validate successfully
Not relevant
Yes

A QbCube with numeric literal existing attributes should validate successfully
Not relevant
Yes

A QbCube with date literal existing attributes should validate successfully
Not relevant
Yes

A single-measure QbCube should pass skos+qb SPARQL test constraints
Single
Yes

A multi-measure QbCube should pass skos+qb SPARQL test constraints
Multi
Yes

A locally defined single-measure dataset (with code-lists) can be serialised to a standard CSV-qb
Single
Yes

A locally defined multi-measure dataset (with code-lists) can be serialised to a standard CSV-qb
Multi
Yes

A single-measure dataset (with code-list) having existing resources can be serialised to a standard CSV-qb
Single
Yes

A multi-measure dataset (with code-list) having existing resources can be serialised to a standard CSV-qb
Multi
Yes

A codelist defined in a CSV-W should be copied to the output directory
Not relevant
Yes

Each Observation should have Type http://purl.org/linked-data/cube#Observation and be part of the dataset
Not relevant
Yes

A QbCube which references a legacy composite code list should pass all tests
Not relevant
Yes

The csv2rdf steps in qbwriter.feature take 103 of 160 seconds for this specific feature file run on my laptop at this time. So, over two thirds of the time.
Conclusion
Consolidating long running tests into a single feature test or a few feature tests could result in a third reduction of a specific feature's runtime.
Recommendation
Monitor

Jenkins build analysis
Scope
Looking at only steps in the last 8 successful builds which take longer than a minute for potential improvements. Total Jenkins pipeline appears to be decreasing from an average of 17 minutes to recent builds of approximately 12ish.
Results
Docker build of environment
The docker container build step takes an average of 3:18, lowest being below a minute, highest 5:16.
conclusion building the docker image is the single most costly action in the Jenkins pipeline
recommendation use a docker image instead of building from the docker file each time. This image should have poetry installed, so that we only need to use poetry install to run tests, etc.
csvcubed behave tests
The behave tests on csvcubed take between 2:36 and 10:00, with an average of 6:19, which appears to be decreasing (with the new AOT compiler).
conclusion AOT compiled will speed things up
recommendation monitor
csvcubed qbwriter.feature
The csv2rdf function does take the majority of the behave test time, but with adopting AOT test time is already decreased. We can reduce the time it takes to check if cubes are valid (i.e. no feature backslipping) by combining tests into a monster cube might work, but likely won't be necessary.
csvcubed unit tests
The unit tests on csvcubed take between 1:28 and 1:48, with an average of 1:36, which appears stable.
conclusion unit tests are already fast
recommendation monitor
Conclusion
There is not much lower fruit here for optimisation.
Recommendations

[x] Adopt AOT csv2rdf
[ ] Raise monster cube ticket based on this comment
[ ] Move to a pre-build docker image to run our tests, build this image when the Dockerfile changes or when a new base-image is released, set Jenkins to pull this image instead of building it
[ ] Moving to multiple-repos will speed up changes to specific packages (by testing less)
[ ] Use GitHub Actions for stuff which can be pulled off the Jenkins runner which don't depend on CICD (i.e. build and publish docs only on tagged releases)
[ ] CICD and test monitoring suites which track performance will improve metrics and allow us to focus on individual problems (See #425)

i.e. build and publish docs only on tagged releases

I'm not 100% in support of this. There are things you can do to break the documentation build -- I'd rather that be highlighted in a PR build rather than saving all those broken things up until when we release.

Raise monster cube ticket based on https://github.com/GSS-Cogs/csvcubed/issues/421#issuecomment-1117266468

I'm very much against creating a monster test, however (as I think we've discussed), I think there may be scope to speed some of these tests up by removing the need to run csv2rdf at all and instead running all RDF assertions against the CSV-W metadata document -- obviously this will only work where the metadata we're checking isn't generated from the CSV by csv2rdf itself.

Move to a pre-build docker image to run our tests, build this image when the Dockerfile changes or when a new base-image is released, set Jenkins to pull this image instead of building it

We can do this to a point, but we should still have Jenkins build a new image (on top of some standardised python 3.10 base image) so that it can use the pyproject.toml/poetry.lock files to install all of the dependencies in a cached fashion.

Yup. The base Docker image can be stored and sent to Docker hub but the Python environment beyond a Python distribution + poetry needs to be built each time.
We agree.
A way of querying CSVW as if it were RDF serialised would be a good project to throw at Swirrl.


Fylr: allow providing conf using existing deployed configmap

Description
Adding the possibility to provide an existing configmap holding an additional config for fylr
How Has This Been Tested?
Tested by deploying a test instance in a test cluster

Please review and merge

Thanks, looks good to me


The content of the ContextMenu is not displayed when right-clicking on the tray icon.

Describe the bug
The content of the ContextMenu is not displayed when right-clicking on the tray icon.
To Reproduce
xmlns:tray="http://schemas.lepo.co/wpfui/2022/xaml/tray"
<tray:NotifyIcon
Grid.Row="0"
FocusOnLeftClick="True"
Icon="pack://application:,,,/Assets/wpfui-icon-256.png"
MenuOnRightClick="True"
TooltipText="WPF UI - MVVM Demo">
tray:NotifyIcon.Menu

</tray:NotifyIcon.Menu>
</tray:NotifyIcon>
-MainWindowViewModel
[ObservableProperty]
private ObservableCollection<Wpf.Ui.Controls.MenuItem> _trayMenuItems =
new()
{
new Wpf.Ui.Controls.MenuItem { Header = "Home", Tag = "tray_home" },
new Wpf.Ui.Controls.MenuItem { Header = "Close", Tag = "tray_close" },
};
Expected behavior
The same issue is observed in the Wpf.Ui.Gallery project as well.
Screenshots
No response
OS version
windows-10
.NET version
.Net 8.0
WPF-UI NuGet version
WPF-UI 3.0.0
Additional context
No response

I have faced this error:

NotifyIcon does not exist in the "http://schemas.lepo.co/wpfui/2022/xaml/tray" namespace

It seems there is a problem with NotifyIcon

I have installed the WPF-UI.Tray 3.0.0-preview.11 package.


refresh session when nil

temporary possible fix.
the assumption is that the session does not exist anymore and hence needs renewal.
if that's indeed the case, we will see this in the logs.
if the problem still persists, we might have an issue with the mutex itself.

Coverage remained the same at 5.398% when pulling 81bd42114a91f08bc730af81e72291b4336c8d27 on feature/session-refresh into 90096e1406fead43d29b13ffd329699de2bc388e on master.

Coverage remained the same at 5.398% when pulling 605933808e94d9d9fb647315fa5fab3fa9fe37e7 on feature/session-refresh into 90096e1406fead43d29b13ffd329699de2bc388e on master.


run unit_test.py error:  list index out of range

when I  run unit_test.py, I found an error in basic_server.py: 'list index out of range'.
in basic_server.py line 118.

This bug has been fixed.


fix(behavior_path_planner): fix planing when start and target in same lane

Description
The planning shall plan the right path when  start and target in same lane

Related links
https://github.com/autowarefoundation/autoware.universe/issues/2354

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@shulanbushangshu Thank you for creating the PR. It looks like you and @VRichardJP are already using Richard's pr to do further discussion so I will close this PR.
https://github.com/autowarefoundation/autoware.universe/pull/2424


WIP Add Segment

Shall we put this in 0.5.1?

Looking at this, I was just reminded that ApproxFun defines a canonicaldomain function, as well as tocanonical and fromcanonical. These functions are also defined in DomainSets 0.5 (and exported). I'm pretty sure I've started using them because I saw the name in ApproxFun first a while ago, and it is a really good idea which enables lots of flexibility and automated procedures. But I forgot about where it came from later and did not check the expected interface, so there might be a clash now. Hopefully we can easily sort that out here, it doesn't look too bad actually.
I'll describe what the functions do in DomainSets:

canonicaldomain(d): returns a canonical domain associated with  d. This seems to be the same in ApproxFun, except that intervals are mapped by default to [-1,1] in ApproxFun and to [0,1] in DomainSets. For intervals that would be fine, in several dimensions the box [0,1]^d is currently better supported than [-1,1]^d.
fromcanonical(d) returns a map from the canonical domain of d to d. ApproxFun defines fromcanonical(d, x) , which would agree with fromcanonical(d)(x).
tocanonical(d) returns a map from d to its canonical domain, ApproxFun has tocanonical(d, x) as above

In addition DomainSets defines a two-argument version of canonicaldomain where the second type indicates the kind of canonical domain we're after (there might be more than one). This allows a more generic way of checking whether two domains are equal, a way to find simpler domains and a generic description of parameterizations (typically these are maps from lower-dimensional domains).
Currently, there is:

canonicaldomain(d, ::Equal): returns a domain that is equal to d (it has the same elements and the same T) but possibly simpler. For example, a scalar ball like UnitBall{Float64}() is really just the interval [-1,1]. Several other domains might have a simpler representation.
canonicaldomain(d, ::Isomorphic): returns an isomorphic domain that equals d but does not have the same element type. For example, a domain with T=SVector{1,Float64} probably corresponds to a simpler domain with `T=Float64'. Such as a product domain with just one component.
canonicaldomain(d, ::Parameterization): returns a parameter domain. The canonical domain of a circle is the unit circle, but its parameterization is a map from [0,1] to the circle. The two types of "canonical" domains have different use cases and it is nice to have them both.

There are corresponding functions fromcanonical(d, Parameterization()) etcetera. These would clash with fromcanonical(d, x), so I'll rethink them. The two-argument version fromcanonical(d, x) makes sense to avoid having to construct a map and I'd actually like to use it. It would probably be sufficient to put the canonical type first and then we can disambiguate, i.e., canonicaldomain(Parameterization(), d). This would lead to fromcanonical(d::Domain, x) and fromcanonical(::Parameterization, d::Domain, x). No clash. Or, the more general variant could have a different name. It is not really user-friendly to have to type canonicaldomain(d, DomainSets.Parameterization()) anyway, I defined parameterdomain(d) for that purpose.
In DomainSets itself, the generic implementation allows a very flexible mapto(d1,d2) function, which tries to find a map from d1 to d2:
julia> using DomainSets, StaticArrays

julia> m = mapto(2..3, Sphere(4.0, SA[0.5; 0.6]))
(x -> 4.0 * x + [0.5, 0.6]) ∘ F ∘ (x -> 1.0 * x + -2.0)

F = DomainSets.UnitCircleMap{Float64}()

The interval is first mapped to [0,1], which maps to the unit circle, which maps to the circle with different center and radius. This is tricky to do without ambiguities, but I think I resolved it. Composite maps define jacobians and all the components do as well, so we can do:
julia> jacobian(m, 2.7)
2-element SVector{2, Float64} with indices SOneTo(2):
 23.90265731793245
 -7.766444154901849

julia> (m(2.7+1e-6)- m(2.7))/1e-6
2-element SVector{2, Float64} with indices SOneTo(2):
 23.902681719922825
 -7.766369063855194

julia> jacobian(m)
x -> F₂(x) * F₄(x) * F₃(x)

F₁ = DomainSets.UnitCircleMap{Float64}()
F₂ = (x -> [4.0 0.0; 0.0 4.0]) ∘ F₁ ∘ (x -> 1.0 * x + -2.0)
F₃ = x -> 1.0
F₄ = LazyJacobian(F₁) ∘ (x -> 1.0 * x + -2.0)

julia> jacobian(m)(2.7)
2-element SVector{2, Float64} with indices SOneTo(2):
 23.90265731793245
 -7.766444154901849

Anyway, that's just to say why I like the canonical domain functionality.
Packages can define their own canonical type to make different choices from the default. I've done that in DomainIntegrals, to make intervals map to [-1,1] in fact :-) I'm also using parameterizations there to automate the evaluation of some integrals (hence why I needed jacobians), but I know of no other uses so far. I think it may still be fine to just change the interface at this stage.
A short term solution would be to stop exporting the canonical methods in DomainSets until the interface has settled down and is useful for ApproxFun?

To be honest I never really liked tocanonical and fromcanonical...
Perhaps canonicalmap? I think a Map can be thought of as an invertible function, whose inverse is specified by invmap (or whatever its called). Then tocanonical(d,x) becomes canonicalmap(d)(x) and fromcanonical(d,x) becomes invmap(canonicalmap(d))(x)... though perhaps this is even uglier...

It could be mapto_canonical and mapfrom_canonical?
I found it works well if a single argument function returns a map and the two-argument version evaluates the map at a point. In some cases I've made the single-argument function return a lazy map by default (like LazyJacobian, LazyInverse), such that one only has to implement inverse(m,x) or jacobian(m,x). That's often cheaper to compute and it doesn't require having to define some new map type.
The inverse of a map right now is inverse(m), but a map might not be invertible. It could be invertible on its range (like a parameterization) or for a subset of its domain (like a projection), so I've also defined leftinverse and rightinverse. The map from a canonical domain to d is typically a parameterization, so there is the default:
tocanonical(d) = leftinverse(fromcanonical(d))
and
tocanonical(d,  x) = leftinverse(fromcanonical(d),  x).
A segment in 2D or 3D could be the map of a 1D interval, which would be a non-invertible rectangular map. That map does have a left inverse, which maps a point on the segment back to the interval. That would be my plan here.
I've added a lot of logic for vector-valued functions which probably ultimately belongs elsewhere, but most packages I've checked work with square maps only.

Closing because this is outdated


[Question][Discussion] Wiki

Why aren't we using the Wiki? It seems like it would make managing docs a lot easier.
Any thoughts?

I want the least vendor lockin from github as possible, also rather point people to a documentation website than a github wiki (to make it as frictionless as possible - also for non developers).
For that reason all docs are stored in gekko/docs and this repo compiles all the docs into the website: https://gekko.wizb.it/


Update javaparser

I've been using an updated javaparser jar locally and I have experienced faster performance from JavaComplete. This is definitely a repeat of PR #172. Please test this on your machine before merging to make sure it works the same for you :)

Hm, seems like some api changed, couldn't recompile. Ok, will look it...

I must've missed something. I'll be able to look into it later

There is still some deprecated api usage.


Feature Request: GPIO control of homeduino

Hello,
as a former longtime pimatic user, I am sad and happy at the same time to see this project here. Some time ago I moved my stuff to Home Assistant. Only the 433 devices are still running under Pimatic. It's a shame to think so, but I'd really like to see this replace my pimatic instance completely.
I could offer my helf by testing an so on. If you like just response.
Bye,
Daniel

Yes, please go ahead and test this integration and report your findings. On my system it's running quite stable. I've only implemented the protocols for the devices I own myself, so you might need to port the protocols for your devices from rfcontroljs to rfcontrolpy. Also in the field of documentation there is some work todo, feel free to make adjustments accordingly. You can create a pull request with your modifications and I'm happy to look at it and incorporate good code in a future release.

Okay, I will see what I am able to do.

@0rTiN, what is your GPIO setup?

I mean, what kind of devices do you have connected to the GPIO? What is attached to your homeduino

I have connected a relay board (like this: https://www.amazon.de/gp/product/B078Q326KT/ref=ox_sc_act_title_1?smid=A1X7QLRQH87QA3&psc=1) at the homeduino.

Ok, great. I've been working on a new release of the Homeduino integration which should support local IO and I think such a relay should work. It's not yet released as a new version, but you can give the latest Github code a try.
If you have experimental features enabled in HACS you can run the following service from Developer Tools > Services:
service: update.install
data:
  version: master
target:
  entity_id: update.homeduino_update

The Homeduino I'm using in production actually doesn't have any local IO connected, so I had to build a new Homeduino to develop this functionality. In my setup it seems to work, but I'm dependent on your feedback to se if it works in a real life scenario. Please let me know if it works for you.

Hi rrooggiieerr,
I installed it as mentioned. First I tried to find something like "Homeduino Device" here:
.
Just by accident I found it Homeduino Transiver device. I was somehow in the wrong path.

What I can say is it works after a short test. I will move mow the rules from pimatic to HA automations to test it productively for a while.
Many thx for your effort!!! 🙇♀

Thanks for the coffee 0rTiN! I changed the configuration menu slightly, maybe it's a bit less confusing now.
If you like to get further involved, the README.md doesn't have any instructions on using the IO yet. If you feel obliged you're invited to improve on that.

u r rrooggiieerr!
I will have a look on it after the coming weekend.


samples/net/sockets/echo_client/server: No docs for testing TLS mode

Subj. Nothing in the docs. I tried:
openssl s_client -host <IP_ADDRESS> -port 4242

Got:
**** Booting Zephyr OS zephyr-v1.13.0-53-g1e58bc1d03 *****
Zephyr Shell, Zephyr version: 1.13.99
Type 'help' for a list of available commands
shell> [echo-server] [INF] init_app: Run echo server
[echo-server] [INF] process_tcp: Waiting for TCP connection (IPv6)...
[echo-server] [INF] process_tcp: Waiting for TCP connection (IPv4)...
[echo-server] [INF] process_udp: Waiting for UDP packets (IPv6)...
[echo-server] [INF] process_udp: Waiting for UDP packets (IPv4)...
[echo-server] [ERR] process_tcp: Error in accept (IPv6): 53 - stopping server
[echo-server] [INF] main: Stopping...

Not good.

P.S. Actually, there's even no docs how to build TLS mode...

And well, the above issue happens when built against min libc.

Ah, not even that - it happened during that run. Rebuild/restart - openssl s_client works.

So, I'll include switching these to minlibc to https://github.com/zephyrproject-rtos/zephyr/pull/9923

who are you talking to?

To the assignee of the ticket, the author of this sample.

Sorry for missing docs, I have in in my schedule, just didn't come to it yet. It will happen though.

P.P.S. And having boards/qemu_x86.conf is counter-intuitive/productive/etc.

So where would you see this config then? This is approach suggested in review of #8342 and followed by #9033 as a way to solve the problem of multiple, almost identical config files. If you have other/better propsal to make this simple, please share with us instead of writing daunting comments.

So, I'll include switching these to minlibc to #9923

I appreciate that.
Anyway, thanks for leaving the ticket, so it won't be forgotten.

P.P.S. And having boards/qemu_x86.conf is counter-intuitive/productive/etc.

So where would you see this config then?

So, the idea which I hoped the mainline by now and in everyone's loop, is that generic networking functionality should not require board-specific configuration. I.e. if a board has some IP-compatible networking builtin, the the board config should enable/configure it by default. Yes, if people need to use non-default choice, or use external hardware, they'd need to have board-specific (re)configuration, by default should just work.
That's how my samples in samples/net/sockets/ are written.
And let's look inside your boards/qemu_x86.conf:
CONFIG_NET_UDP=y
CONFIG_NET_TCP=y
CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=y

How is that qemu_x86 specific? Please just merge those opts into the main prj.conf and remove that file.

How is that qemu_x86 specific? Please just merge those opts into the main prj.conf and remove that file

When I was suggested to introduce this boards/${BOARD}.conf pattern, I've took a look what differentiated boards in the original echo samples. What was different beside hardware specific stuff was that some boards did not enable IPv4, others didn't run TCP etc. (Perhaps memory constraints? Techonology limitations?). That's why I put those configs into separate file.
Of course, we could enable everyting by default, and then have other boards override these values, perhaps it is a better way to do that. But again, if we want to enforce this new pattern of adding configs, I think that it is good to have a reference of how board-specific configuration should be added. Otherwise we'll end up with people submitting configs in an old way (because it's simpler/faster to just copy a config and modify what's needed).

When I was suggested to introduce this boards/${BOARD}.conf pattern, I've took a look what differentiated boards in the original echo samples.

Let me start reading here, write the response to this, then continue reading ;-).
The "original echo samples" are messy config with too much magic which everybody is afraid to touch to not break some magic somebody else may be using (for testing, and testing is important). Rewrite, especially with sockets, gives an opportunity to leave that baggage behind. (And I overlooked that during the original review, yeah.)

memory constraints?

Would be handled on board level. Like, if it really can't use TCP or IPv6, should be force-disable on board level. But I doubt we have choices like that, and if some board is really on an edge - yes, that can be handled by board-specific config.

Techonology limitations?

Should be handled automagically too. E.g. 6lowpan devices can't work with IPv4. So, it can be either: 1) IPv4 enabled, so what; or 2) just be force-disabled. I believe we're at 2) already. Users would get warning of conflicting CONFIG_IPV4 assignment after recent @ulfalizer work, but that's price of magic.

it is good to have a reference of how board-specific configuration should be added

Sure. It's just socket and IP networking in general examples aren't the best place for that. We surely have other examples with board/*.conf ?

Otherwise we'll end up with people submitting configs in an old way (because it's simpler/faster to just copy a config and modify what's needed).

No, we'll -1 that ;-). There should be single prj.conf per sample which just works. Anything else is rare exception which should have good justification ;-).

Well, I don't want to argue here, as in general I agree with your point of view, it's just that this vision is idealistic and would invovle changes not only in project files but in module configurations as well (which sounds like lot of work), but yes, we should strive for that.

We surely have other examples with board/*.conf ?

Not many actually, at the moment the echo socket samples were submitted there was one or two samples that supported this pattern. But hopefully PR's like #9033 will not be a single case, and could serve as a reference for others (still not ideal, but a good step forward).
I'm not having problem with removing boards directory from echo_client/server if there's a will to do that, at least unitl it's necessary to have it. So let's just summarize this topic in a checklist, that I could take care of once I'm done with current stuff.

So to summarize:

[ ] Add TLS sockets subsystem documentation
[ ] Update socket echo_client/echo_server samples with information on how to run TLS
[ ] Unify socket echo_client/echo_server sample project configuration into a single file (with TLS as overlay config)

I hope that concludes updates requested in this topic?

I hope that concludes updates requested in this topic?

Yeah, sorry for brining different things under the same ticket ;-). I guess it could work as "beginning of new devel cycle brainstorming", but feel free to request moving different topics to different tickets.

Feel free to update if I've missed something.

Looks good. I just took freedom to reorder bullet points from easier/sooner to do down to requiring more time to do.

I'll reopen this, there's still one point to cover.

Closing, as #11534 satisified the final point from the checklist.


am335x dev board which machine to use

Hello, I have dev kit PCM953 and am335x module PCM-051 (on module is written 1358.3) I would like to build yocto but cannot somehow identify which machine should I use for this machine type. Can you please give me some hint which machine to use? Thanks

Hello Marek,
yes there are a lot of machines which makes it quite confusing.
Correct machine in your case should be "phycore-am335x-1"
Regards,
Teresa

@tremmet perfect. Many thanks.


Add collapsible "on this page" in smaller screens

What kind of changes does this PR include?

[ ] Minor content fixes (broken links, typos, etc.)
[ ] New or updated content
[ ] Translated content
[x] Changes to the docs site code
[ ] Something else!

Description
This PR adds a sticky "on this page" navbar for mobile/tablet users:

I'm marking this as a draft because there are some blocking issues I couldn't fix:
1 - As you can see, some elements are kinda breaking out from the parent element width, so this causes a very ugly effect:

I think to fix this we would need to have a way to make "on this page" cover more than its parent width but I'm not sure what would be the best approach here.
2 - When the header also becomes sticky the navbar isn't sticky anymore. Probably some very specific CSS behavior I couldn't find an answer for 😅.

@Yan-Thomas hope you don’t mind I ran with this. Let me know what you think!

Thank you so much for all these amazing improvements, @delucis! 🙌 💛
LGTM!!

I've been letting this PR just chug along, seeing what you all have been doing with it. After Chris' demo it's quite impressive! (And, I hear this is working to make our Lighthouse scores 100s, so that's great, too!) I like that it's sticky; I think that's great for navigation!

I did have a "Sarah's Phone" issue: in Chrome (and Kiwi, another Chromium-based browser):
The workflow that seems to bork is:

expand menu
select one of the nav links to go to a section
the navigation component disappears completely, and neither scrolling up nor down makes it visible again.

I'm not 100% convinced on the initial loaded state of collapsed, and e.g. ON THIS PAGE > Overview

It makes me think that what is on this page is.... an overview! the Right arrow could be interpreted as a symbol for "one level deeper" navigation instead of "a collapsed menu." Random possible thoughts for dealing with this:

NOT ever have "Overview" show up there, so that the > symbol looks more like something meant to be expanded?
use a different symbol or word or styling that makes it look more like, on mobile a thing that can expand?
start expanded (didn't we talk about this before, where I thought that the initial list expanded was actually helpful for the reader to know they're on the correct or a useful page? I still think this is a plus) BUT the fact that it's sticky when expanded means on initial scroll, you might be taken aback by the small amount of screen real estate actually scrolling (if any at all, when the list is long enough!) until you figure out you can collapse it.

Those are my initial thoughts!

Remind me of your phone + browser combo, Sarah? I can’t seem to get that to happen for me.
Re: 2. I’ve just hidden the “Overview” text from the summary. PTAL.
The next approach I’d suggest would be better styling. I went with minimal changes for this PR, but it could look a little more like a button for example to help prompt people if you think it’s still not clear.

Example of something like what I mean by “like a button”:

Or even:

Samsung Galaxy note 8, Chrome (and Kiwi); Android 9, OneUI 1.0

UPDATE It's closer to working on my phone!
The update is that now, when I click a TOC link and the navigation TOC disappears, I can scroll all the way to the top, and now it's there.
Visually, looking 🔥 !

LGTM!  NWTWWHB!
I know on Chrome mobile it doesn't have all the features (yet?) that it does in FF, but it doesn't break anything, and still gives the very slick collapsable menu (just non sticky) available at the top.
Plus, LIGHTHOUSE!!  🟢 💯

Just to leave a note as I merge:
There’s an outstanding bug that once a link has been clicked and the page is a ...url#heading, the sticky behaviour seems to break in several mobile browsers. Needs more investigation.


Issue: No issues

There are no issues documenting any improvements that should be made. This is an issue issue that can be resolved by there being issues. However by creating this issue the issue is then resolved until it is in which then the issue is unresolved because the issue issue issue in once more an issue.


Sinusoidal embedding order choice different from original definition

Hey Phil! One more from me! :)
I see that the way you stack sinusoidal embeddings here is different from the original transformer paper (section 3.5).
Instead of:
emb = torch.cat((emb.sin(), emb.cos()), dim = -1)
What the original one does is this:
emb = torch.stack((emb.sin(), emb.cos()), dim=-1).view(max_pos, -1)
i.e. your vector looks like:
[sin(x1),sin(x2),...,cos(x1),cos(x2),...]
whereas in the original paper it was like:
[sin(x1),cos(x1),sin(x2),cos(x2),...]
again, the network will certainly learn from both of these - I was just curious has there been any empirical finding that showed that the first definition is more performant?

hmm not that i know of, but if you run any benchmarks, let me know


New explosive barrel

The barrel needs to look more "explody"
The barrel health should also be lowered
Optional:
Add explosion sound

didn't you add the explosion sound in another PR?


z_cli.certify() error

When redeploying a site with recertify set, I see these errors in the cloudwatch logs:
This application isn't deployed yet - did you mean to call deploy?: ClickException
Traceback (most recent call last):
File "/var/task/handler.py", line 479, in lambda_handler
return LambdaHandler.lambda_handler(event, context)
File "/var/task/handler.py", line 192, in lambda_handler
return handler.handler(event, context)
File "/var/task/handler.py", line 301, in handler
return self.run_function(app_function, event, context)
File "/var/task/handler.py", line 237, in run_function
result = app_function(event, context)
File "/var/task/handler.py", line 493, in certify_callback
return lh.update_certificate()
File "/var/task/handler.py", line 253, in update_certificate
z_cli.certify()
File "/private/var/folders/26/dklxrj8130l1rxw1r5qnb7nw0000gn/T/pip-build-4CS1fJ/zappa/zappa/cli.py", line 1206, in certify
ClickException: This application isn't deployed yet - did you mean to call deploy?

we might be swallowing an exception here:
    def get_lambda_function_versions(self, function_name):
        """
        Simply returns the versions available for a Lambda function, given a function name.

        """
        try:
            response = self.lambda_client.list_versions_by_function(FunctionName=function_name)
            return response.get('Versions', [])
        except Exception:
            return []

When that returns [] you get the error above. I've also seen this.


Add my first file

I have created a new branch, created a file, and made a commit!

Created a file on a separate branch and committed it. After committing I merged it into main.


Flatten Remote Profile Data

Issue Description
The profile column in dynamoDB saves all the attributes connected to each user.
Expected Results
DynamoDB should store each (group of) attribute(s) in a separate column of its own.
Still want to keep the JSON which is stored in profile column to allow for a seamless transition from previous data structure

React Native version: 6.2
Platform(s) (iOS, Android, or both?): both

Success Criteria
Data in the current user profile json structure to be pulled up one level. Each data attribute will be on the root level.

Done on branch feature/flatten-profile


jquery-ui dependency: add version constraints.

Coverage remained the same at 84.032% when pulling 6a73f28d503ad9d9f026319bc00a827aecc979c2 on jquery-ui-dep into ac0c6c1ea02bc1134eb8711e52eb3f172810d232 on master.


feat: port Algebra.Modeq

[ ] depends on: #3920

This PR/issue depends on:

leanprover-community/mathlib4#3920
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#3920
By Dependent Issues (🤖). Happy coding!

Sorry @qawbecrdtey - I'd just made the exact same change


Self nominating Baodong (Robert) Li to OWNERS file of tests

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: baodongli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
Assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Codecov Report

Merging #6147 into master will increase coverage by 7%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #6147     +/-   ##
========================================
+ Coverage      67%     74%     +7%
========================================
  Files         342     322     -20
  Lines       29945   27518   -2427
========================================
+ Hits        20059   20103     +44
+ Misses       9095    6622   -2473
- Partials      791     793      +2

Impacted Files
Coverage Δ

mixer/pkg/adapter/quotas.go
0% <0%> (-100%)
:arrow_down:

mixer/pkg/adapter/check.go
60% <0%> (-40%)
:arrow_down:

...ilot/pkg/networking/plugin/authn/authentication.go
68% <0%> (-15%)
:arrow_down:

pilot/pkg/model/authentication.go
57% <0%> (-15%)
:arrow_down:

mixer/adapter/kubernetesenv/kubernetesenv.go
70% <0%> (-12%)
:arrow_down:

mixer/adapter/kubernetesenv/cache.go
83% <0%> (-10%)
:arrow_down:

pilot/pkg/proxy/envoy/v2/discovery.go
68% <0%> (-8%)
:arrow_down:

mixer/adapter/stackdriver/helper/common.go
76% <0%> (-7%)
:arrow_down:

pilot/pkg/serviceregistry/kube/controller.go
64% <0%> (-3%)
:arrow_down:

broker/pkg/platform/kube/crd/client.go
72% <0%> (-2%)
:arrow_down:

... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9eb210...3aa9cf4. Read the comment docs.

@baodongli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@baodongli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@baodongli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@baodongli: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @costinm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: baodongli, costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baodongli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3aa9cf42c939f0d0ba93be3b0a774a56db5d2bdd
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Support Bash Completion

This idea is to add bash completion for libcompose.
Below is a  bash completion example:

// press tab twice after input "docker k", "kill" is completed and containers are printed.
root@SZX1000041895:~/sleep# docker ps
CONTAINER ID        IMAGE                        COMMAND             CREATED             STATUS              PORTS               NAMES
d3b5210874af        mbrt/golang-vim-dev:latest   "/bin/bash"         2 days ago          Up 2 days                               myvim

root@SZX1000041895:~/sleep# docker kill
d3b5210874af9c4d9fe9041a47928e551c719c2281758e73558f24234d36b807  myvim

//press tab when input "docker r", then all command that begins with "r" will be displayed.
root@SZX1000041895:~/sleep# docker help r
rename   restart  rm       rmi      run

I think https://github.com/docker/compose/tree/master/contrib/completion should work, no?

@bohai I think it should yeah (except for the docker-compose command part :stuck_out_tongue: https://github.com/docker/compose/blob/master/contrib/completion/bash/docker-compose#L443).


Make test cases portable with resource path

Fix ut failures in IntelliJ
Description
Use resource path in unit tests to make the code portable (even in IntelliJ).
Leverage the helper functions in SparkFunSuit
  // helper function
  protected final def getTestResourceFile(file: String): File = {
    new File(getClass.getClassLoader.getResource(file).getFile)
  }

  protected final def getTestResourcePath(file: String): String = {
    getTestResourceFile(file).getCanonicalPath
  }

How was this patch tested?
Unit test

Does this PR introduce any user-facing changes?
No

Can you fix the github actions?

Can you fix the github actions?

Done, but the checks fail with confusing cancel operation.

@DonnyZone Sorry, I think the github actions were down and I forgot to check back in on this once they were fixed. Are you still interested in merging this? If so could you resolve the conflicts? Thanks!


Restores torque cartocss syntax check

Fixes #4164
Added some improvements/fixes to the logic, after implementing virtually the same code in Windshaft for internal style checking.
@javisantana @rochoa

Frontend tests were OK :+1: (details)


Added support for strikethrough color

@jgsamudio I think the attributes test should be in a separate PR. So far, there hasn't been any test for other attributes yet.


RefreshTokenStore does not save updated JsonCode

When refresh token is updated, JsonCode needs to be updated too, because it contains LifeTime property that can be extended.

Ok, I'll have a look when I can. Thx.

@brockallen or @samikoivupalo -- Can you expand on this bug report?
I'm currently using this project for a reference implementation and would like to avoid a known bug...

Yep, thanks for the nudge...

Is this (https://github.com/IdentityServer/IdentityServer3.EntityFramework/commit/f0eb1095ff9aad33c7333f752cc99c88bdf3efdb) the change you're expecting @samikoivupalo?

Yes. That worked for me. Thanks.

2.4.2 NuGet pushed with the fix


Right click to show app menu in Windows

Currently the code to show the app menu in start.js doesn't work on Windows, it should show the menu on a right click.
It will probably work similarly to v1:
ipcMain.on('contextmenu-click', function() {
  menu.popup();
});

closed via #453


Bazel tests should use the $TEST_TMPDIR directory provided by Bazel

My /tmp dir is getting a bit polluted. I suspect it's mostly from times when Fildesh is crashy during development, but https://bazel.build/reference/test-encyclopedia says that tests should create temporary files in $TEST_TMPDIR, so the current behavior of our fildesh_test Bazel macro can be considered a bug.

Hmm... still have compilation artifacts being created. Is that from builds or from example/convoluted.fildesh? We should probably set the $TMPDIR environment variable for that.