delete things we don't need

View classes and their methods are deleted if there is no snippet files using them.

Codecov Report

Merging #2215 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2215      +/-   ##
============================================
- Coverage     86.85%   86.83%   -0.02%
+ Complexity     5145     5126      -19
============================================
  Files           457      452       -5
  Lines         20459    20360      -99
  Branches       2189     2185       -4
============================================
- Hits          17769    17680      -89
+ Misses         1920     1910      -10
  Partials        770      770

Impacted Files
Coverage Δ
Complexity Δ

...ansformer/csharp/CSharpGapicClientTransformer.java
97.77% <ø> (-0.02%)
52 <0> (ø)

...le/api/codegen/transformer/ParamWithSimpleDoc.java
100% <ø> (ø)
8 <0> (ø)
:arrow_down:

...ogle/api/codegen/config/PackageMetadataConfig.java
92.55% <ø> (-0.08%)
22 <0> (ø)

...e/api/codegen/transformer/BatchingTransformer.java
97.29% <ø> (-0.38%)
14 <0> (-2)

...odegen/viewmodel/metadata/PackageMetadataView.java
71.42% <ø> (ø)
5 <0> (ø)
:arrow_down:

...ansformer/ruby/RubyPackageMetadataTransformer.java
100% <ø> (ø)
27 <0> (ø)
:arrow_down:

...r/java/JavaDiscoGapicRequestToViewTransformer.java
94.59% <ø> (-0.03%)
20 <0> (ø)

...nsformer/nodejs/NodeJSGapicSurfaceTransformer.java
100% <ø> (ø)
27 <0> (ø)
:arrow_down:

...i/codegen/viewmodel/metadata/VersionIndexView.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

...en/transformer/php/PhpGapicSurfaceTransformer.java
92.95% <ø> (-0.15%)
41 <0> (-2)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1ef90...fb85442. Read the comment docs.

@vchudnov-g What would make you comfortable? I regenerated Java client and found no regression


Added Awesome Functional Programming to the CS Category

Let me know it it is still too early to propose this list, or if the category is wrong or anything! :)

Please read the instructions for creating a new list, contributing guidelines and the awesome manifest.
Especially this part:

Wait at least a couple of weeks after creating a list before submitting to give it a chance to mature.

Ping me here in a few weeks and I'll reopen ;)

Could you tell me what exactly is missing? Content? Something that is not attending the awesome criteria?

I didn't say anything was missing. Just asking you to read those documents.

Yes, I understood that. But this is my second attempt at adding this specific list to the awesome project. In the first one you gave me the same message and also more specific feedback (which I very much appreciated). This time I really didn't get what I should focus on.
Thanks anyway. I will wait a couple of weeks and try again :)

But this is my second attempt at adding this specific list to the awesome project.

You should have mentioned that in the PR description. I can't possibly remember all previous contributions.

This time I really didn't get what I should focus on.

Maybe following instructions. Looking at your last PR a week ago I cleary said:

Ping me here in a few weeks and I'll reopen ;)

Neither was followed...

Ok. Now I know exactly what I've done wrong. Thank you very much.


[Typescript] Generated QueryVariables filed with default Value not optional

Describe the bug
If you provide a default value for a query variable, the generated field in the query variable type is mendatory instead of optional.
It worked before with version "0.12.6".
To Reproduce
Steps to reproduce the behavior: Provide a default value in a query.

My GraphQL schema:
I can provide it if its necessary.

My GraphQL operations:

# ../search.graphql

query SEARCH($query: String!, $limit: Int = 9, $offset: Int = 0) {
  search(query: $query) {
    pages(limit: $limit, offset: $offset) {
      total
    }
  }
}

My codegen.yml config file:

overwrite: true
schema: 'http://localhost:4000/api/graphql'
documents: ['**/*.graphql']
generates:
<EMAIL_ADDRESS>    plugins:
      - 'typescript'
      - 'typescript-operations'
    config:
      skipTypename: true
      namingConvention:
        typeNames: change-case#pascalCase
        enumValues: keep

Expected behavior

Variable is optional in type.
Environment:

OS: Windows 10
@graphql-codegen/cli: 1.0.3
@graphql-codegen/typescript: 1.0.3
@graphql-codegen/typescript-operations: 1.0.3
NodeJS: 10.15.0

Additional context

@roman-may It think @kamilkisiela fixed it recently, can you please try 1.0.6?

@dotansimha You're right. I did not realize there was an update. Thank you for the fast reply!

I still have this issue 1.0.7...
I've just tried to upgrade from v0.18 => 1.0.7, and I cannot resolve errors by tsc.
Is this error comes back in 1.0.7 ?
  ./src/__generated__/graphql-codegen.tsx:
    documents:
      - graphql/query/**/*.gql
    plugins:
      - add: *header
      - typescript
      - typescript-operations
      - typescript-react-apollo
      - ./codegen-plugins/hoc-name.ts
      # - typescript-compatibility # => more error by tsc
    config:
      avoidOptionals: true
      strict: true
      scalars:
        BigInt: string
        BigFloat: string
        Cursor: string
        Datetime: string
        JSON: any
        # JSON: { [key: string]: any } # => [object Object] ERROR!!
        UUID: string
      # __options for react-apollo__
      withHOC: true
      withComponent: false
      # noGraphQLTag: true # => error

  "devDependencies": {
    "@graphql-codegen/add": "1.0.7",
    "@graphql-codegen/cli": "1.0.7",
    "@graphql-codegen/fragment-matcher": "1.0.7",
    "@graphql-codegen/schema-ast": "1.0.7",
    "@graphql-codegen/time": "1.0.7",
    "@graphql-codegen/typescript": "1.0.7",
    "@graphql-codegen/typescript-operations": "1.0.7",
    "@graphql-codegen/typescript-react-apollo": "1.0.7",
    "@graphql-codegen/typescript-resolvers": "1.0.7",
    "graphql": "14.1.1",
    "jest": "24.5.0",
    "lodash": "4.17.11",
    "prettier": "1.16.4",
    "ts-node": "8.0.3",
    "tsconfig-paths": "3.8.0",
    "typescript": "^3.3.3"
  }

@ken0x0a can you please open a new issue for that? And if possible, with a reproduction in a repo :)

@dotansimha Thank you for your reply :)
I'll try when I can.
Since now I'm happy with v0.18 and already over due date... I'll try later (maybe with newer version if already released when the time I'll try).
And I'll open new issue if I can reproduce the issue :)
Thank you for you help!


[BUG] Improving the login page in light and dark mode.

Description
Some icons are overlapping and there is misalignment in the button and the input box.Also non-hovering of the sign up link.
Screenshots
https://github.com/user-attachments/assets/3c0be068-5398-4122-80c0-c941c7b0eab6
Any additional information?
Please assign this issue to me.
What browser are you seeing the problem on?
Safari
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@Arghya-Chakraborty0812, set your screen size to 100% and then check again. It looks good and nice. I am closing the issue for now. Please raise another issue, which I am happy to assign to you, but make sure the issue is valid and addresses something important on our website. Otherwise, invalid issues will be closed. Thank you!


How to handle plugin Schema migrations?

Hi guys. I was learning how to create plugins for kong using the python-pdk and it wasn't clear how to handle plugin schema migrations.
From what I understand about lua-pdk, to handle migrations, it's just need to create a migrations directory inside the plugin directory and write the migrations with raw SQL in files in the following format 000_<custom_name>.lua, and in the file init.lua, inside the migrations directory, which I believe is equivalent to python's __init__.py, is necessary to return a set with the filenames in the order they should be applied.
It seems to me that kong already handles the discovery of migration files, and to apply them just run kong's CLI (kong migrations up).
Does this whole process also apply to python-pdk?

Hi @durvalcarvalho , custom DAO (and migrations) are currently not supported for external plugins. Actually the recommended way to store those custom data outside of plugin config is to use your own datastore, like redis or other database.


Fails to determine IP address of Interface on FreeBSD

Not sure if it's configuration issue or not (seems like a bug) but trying to use an interface makes godns fail.
ERRO[0000] Cannot get IP:Get "": unsupported protocol scheme ""
ERRO[0000] get ip online failed. Fallback to get ip from interface if possible.
ERRO[0000] get ip from interface failed. There is no more ways to try.
ERRO[0000] Error during execution:can't get a vaild address from hn0: fail to get current IP

Relevant configuration (json):
...
  ],
  "ip_urls": [""],
  "ip_type": "IPv4",
  "ip_interface": "hn0",
  "interval": 300,
  "debug_info": true,
  "run_once": true
}

Using this code works however (standalone)
https://gist.github.com/schwarzeni/f25031a3123f895ff3785970921e962c

Still busy or is this something you can look into? @TimothyYe
It appears to be a simple parsing bug

Same problem on windows. "ip_interface": "wgpia0",
time="2023-09-07T16:09:24-04:00" level=info msg="Creating DNS handler with provider: DuckDNS"
time="2023-09-07T16:09:24-04:00" level=info msg="GoDNS started, starting the DNS manager..."
time="2023-09-07T16:09:24-04:00" level=error msg="Cannot get IP:Get "": unsupported protocol scheme """
time="2023-09-07T16:09:24-04:00" level=error msg="get ip online failed. Fallback to get ip from interface if possible."
time="2023-09-07T16:09:24-04:00" level=error msg="get ip from interface failed. There is no more ways to try."
time="2023-09-07T16:09:24-04:00" level=error msg="can't get a vaild address from wgpia0"
time="2023-09-07T16:09:24-04:00" level=debug msg="DNS update loop finished, will run again in 300 seconds"

@TimothyYe
Can you possibly have a look at this?

@diizzyy Thanks, I'll look into this issue.

ERRO[0000] Cannot get IP:Get "": unsupported protocol scheme ""
@diizzyy I've checked the code, this error means GoDNS still tries to get the IP address from the internet.
I think to fix this issue, update your config as:
{
  "ip_type": "IPv4",
  "ip_interface": "hn0",
  "interval": 300,
  "debug_info": true,
  "run_once": true
}

Just remove ip_urls from it.
By the way, I've released a new version to fix this problem and filter the empty URLs in the ip_urls option.

@TimothyYe
Hi, still doesn't work unfortunately
  "ip_type": "IPv4",
  "ip_interface": "hn0",
  "interval": 300,
  "debug_info": true,
  "run_once": true

INFO[0000] GoDNS started, starting the DNS manager...
ERRO[0000] get ip from interface failed. There is no more ways to try.
ERRO[0000] Error during execution:fail to get current IP

Could you please help to run the ifconfig command, and paste the output for your network interface hn0 here?
I guess the only difference between GoDNS and the code snippet you mentioned is that GoDNS checks if the IP is private:
https://github.com/TimothyYe/godns/blob/master/pkg/lib/ip_helper.go#L122

I use my Oracle cloud to test GoDNS on the FreeBSD system, and the same error shows when the network interface is assigned with a private IP address:

For the current implementation, GoDNS will ignore the private IP address while fetching it from the network interface.

Ahh, you're correct! I should've checked the code more carefully but it would be nice if godns where verbose about it especially in debug mode. There seems to be a loop however somewhere in the logic to detect IP?
INFO[0000] Creating DNS handler with provider: Infomaniak
INFO[0000] GoDNS started, starting the DNS manager...
DEBU[0000] get ip success from network intereface by: igb0, IP: NOT PRIVATE
DEBU[0000] get ip success from network intereface by: igb0, IP: NOT PRIVATE
INFO[0002] Update IP success: good NOT PRIVATE
DEBU[0002] Cached IP address: NOT PRIVATE

It's not a loop, it only happens when the GoDNS is launched for the first time, the current_ip in the IPHelper is empty, so it tries to fetch the current IP address immediately. In this case, it produces one extra output log:
https://github.com/TimothyYe/godns/blob/master/pkg/lib/ip_helper.go#L71
Another log is produced by the inner goroutine inside the IPHelper:
https://github.com/TimothyYe/godns/blob/master/pkg/lib/ip_helper.go#L60
So you may see two output logs here.

Thanks for clarifying, I guess we can close this now.


Sorting by clicking on header column does not work for read only column

Sorting by clicking on header column does not work for the read-only column is not working. It only works for the first column.

We are using the latest solution v<IP_ADDRESS> on Dynamics CRM 2015 on premise. I don't see script error in the browser console?  It just the info message "CRM Version <IP_ADDRESS> does not support WebAPI. Using SOAP library.".  The first time click on the read-only column seems to do the sort with the refresh but when we click on the second time to reverse the sort order it is not doing anything.  Also, we are using Chrome and IE 11 browser.


Fix spelling of developers in android quick start

[x] This is a small change
[ ] This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:
Just noticed this spelling error :)

Thanks!


use rapidfuzz instead of fuzzywuzzy

FuzzyWuzzy is GPLv2 licensed which would force you to licence the whole project under GPLv2.
For this reason this Pullrequest replaces FuzzyWuzzy with  rapidfuzz which is implementing the same algorithm but is based on a version of fuzzywuzzy that was MIT Licensed.
Rapidfuzz is:

Mit licensed so it can be used with the license used by this project
Is faster than FuzzyWuzzy

Thank you for the suggestion. Running the tool locally seems to work after the replacement!


Spigot support

Spigot support would be great

It works with Spigot already, I'm running a few Spigot servers on it. You can either rename the jar to craftbukkit.jar or make a symbolic link to it with ln -s.


Wrong URL links at the blog pages

Describe the bug
I'm testing the following version:
    ...
    "astro": "5.0.9",
    ...
    "@astrojs/starlight": "0.30.2",
    "@astrojs/starlight-tailwind": "3.0.0",
    "@astrojs/svelte": "7.0.1",
    "@astrojs/tailwind": "5.1.3",
    ...
    "starlight-blog": "0.16.0",

I notice that with this version, the URLs contain the file extension, in my case, .mdx files, which causes it to reach the 404 page instead of reaching the desired blog page
To Reproduce

git clone

git clone -b update/astro https://github.com/erkobridee/astro-starlight-hello.git

npm i
npm start
access the URL defined below, and you'll see that all the links rendered on the page contain the file extension (.mdx)

http://localhost:4321/en/blog

Expected behavior
render the links without the file extension (.mdx)
How often does this bug happen?
Every time
System Info

Operating System: Ubuntu 22.04.5 LTS
Browser: Chrome
Version: 130.0.6723.91 (Official Build) (64-bit)

Additional Context
No response

Thanks for your report.
The issue seems to be coming from a small migration mistake in https://github.com/erkobridee/astro-starlight-hello/blob/update/astro/src/content/config.ts#L9
In your src/content/config.ts file, the loader should be at the root of defineCollection() and not nested inside docsSchema().
export const collections = {
  docs: defineCollection({
+   loader: docsLoader(),
    schema: docsSchema({
-     loader: docsLoader(),
      extend: (context) => blogSchema(context)
    })
  }),
  i18n: defineCollection({
    loader: i18nLoader() /*type: 'data'*/,
    schema: i18nSchema()
  })
};

I just tested locally and it seems to be working fine after this change.

oops, my bad
thanks a lot @HiDeoo o/
I also checked here with that change, and it's working :sweat_smile:


Minor nix cleanups

Issue Number
#2046 #2054
Overview

Minor cleanups of nix code for migration tests and latency benchmark.

Comments
Tested with:
nix-build -A benchmarks.cardano-wallet.latency
nix-build nix/migration-tests.nix

bors r+


Project name is not updated in the project list

When the project name is changed, the old name is displayed in the list.
Steps to reproduce the behavior

Menu => Open Project => Click on the gear of any project
Change project name and click Save.
The project list displays the old project name.

Expected behavior
The new name is displayed in the project list.
Affected versions

v1.0.2

Fixed in v1.0.3.


Symlink icons (#1416)

Uses the octicon icons for directory and file symlinks.

Directory symlinks will only be rendered if the target is present in the repository.  Broken links, targets outside the repo and links to other links will just be rendered as file-symlink-file.

I have some tests to add before this is merged but I need some advice as to the cleanest way to add a repository to the test server (gitea-repositories-meta, fixtures etc).
Is there an easy way to spin up the test server, push a new repository and spit out the fixtures?

Codecov Report

Merging #3826 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3826      +/-   ##
=========================================
- Coverage   23.02%     23%   -0.02%
=========================================
  Files         126     126
  Lines       24894   24911      +17
=========================================
  Hits         5731    5731
- Misses      18287   18304      +17
  Partials      876     876

Impacted Files
Coverage Δ

modules/base/tool.go
68.36% <0%> (-3.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae2642...f0d783f. Read the comment docs.

I tried just adding a bare repo at integrations/gitea-repositories-meta/user2/repo4.git but the test instance wont pick it up unless it exists in the database as well...

Yes you have to add needed database records in fixtures yml files

Have not tested yet but does opening link also go to link target?

No, behaviour is identical github.

all entries with mode 120000 render as file-symlink-file
if the target resolves to a directory within the repo it renders as file-symlink-directory
symlinks open as a text file with the location of the link.
the edit button is present but editing disallowed on attempt to save.
link -> link -> directory displays as file-symlink-file i.e. no recursive dereferencing.

See https://github.com/tf198/symlink_test
It would be easy to add an goto target button on the file view page for symlinks if that was considered a useful enhancement...

Just a note: editing of symlinks is allowed on GitHub, and I think it should be kept this way (there may be a broken symlink because the dst directory changed - should be reasonable to keep the ability to change the symlink)
Please do add the Go to target button! (I'm wondering why GitHub considered it not necessary...) Thank you for your pull request!

Thanks for doing this! Suggestions:

Color the directory symlink icon blue like regular directories
Maybe (if it's not too hard) sort directory symlink among directories

LGTM

Here's a patch for the directory symlink color:
diff --git a/public/less/_repository.less b/public/less/_repository.less
index 3bbfe33ef..cb6245908 100644
--- a/public/less/_repository.less
+++ b/public/less/_repository.less
@@ -237,7 +237,8 @@
                     &.octicon-mail-reply {
                         margin-right: 10px;
                     }
-                    &.octicon-file-directory, &.octicon-file-submodule {
+                    &.octicon-file-directory, &.octicon-file-submodule,
+                    &.octicon-file-symlink-directory {
                         color: #1e70bf;
                     }
                 }

After applying, run npm i && make generate-stylesheets to generate the CSS.

Have applied the css patch from @silverwind - looks pretty smart now!
Regarding the second suggestion, any implementation would have to track the paths seen to avoid infinite loops [ link_a -> link_b -> link_c -> link_a ].  Not sure the benefit justifies the complexity...
@thehowl - I am corrected, github currently allows editing of symlinks but gitea doesn't (existing behaviour).  Suggest a new issue is opened for modifying this behaviour.

We could just avoid nested symlinks (if the target is a dir then it's a dir, otherwise if it's a file, symlink, or anything else, it's a file). Hacky, sure, but should suffice most use cases.


Wrap script in async function to fix "await is only valid in async functions" error

Fixes #30.
On Firefox (and maybe other browsers) the script currently gives an Uncaught SyntaxError: await is only valid in async functions, async generators and modules error when run. Wrapping the script in an async closure fixes this.

Awsome, this should be merged IMO!

In addition, Firefox does not support the experimental API navigator.userAgentData but you can just set ua to an empty string ("") and it works fine!


Model updated of radio fields with same name but different keys.

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request

Current behavior
I have a form which has different radio fields that share the same "name" property.  It was made in that way because I need to have other fields between them.  These radio fields only share "name" property but no "key" property due to the fact that sometimes I need to disable or to hide these fields, and if they would have the same "key" all of them would be affected by the disable or hide expression.
The problem is, as they have different keys, when I pick a radio field,  it adds its value to the model:
{
radio1: "valueRadio1"
}

But, when I pick another radio field, it adds its value, but the previous radio field don't update its value to null, although visually it doesn't appear marked.
{
radio1: "valueRadio1",
radio2: "valueRadio2"
}

Expected behavior
The expected behavior is updating the model of the previous radio field selected to null.
{
radio1: null,
radio2: "valueRadio2"
}

Minimal reproduction of the problem with instructions
DEMO
What is the motivation / use case for changing the behavior?
Having the radio button options separated in different fields and with different keys, but sharing de same name, so we could have other fields between them and be able to disable or have different options, or another field which depends on these options.

ngx-formly version:
I updated my project to 3.1.0, but I can't have the dependency of angular 6 of the version 4.x.x of ngx-formly.

Angular version: 5.2.11

sorry but there is no way since it's managed by angular itself.


Cannot resume plotting after pause

Hey there guys,
So here is what error I get after i try to resume plotting after pausing it (I upload it as picture).
The OS is Linux Mint Cinnamon 19.2 and the HDD i try to plot is External HDD Seagate 2TB, formated to extFAT format. Have you got any idea how to resume the plotting?
Thank you in advance.

Okay guys, a quick update on the problem. It is solved. It was because of the format. I used now EXT4 and it seems to work well. Can pause and resume it without problem. Thank to everyone that took part of resolving the problem and a quick note from me - don't use exFAT for plotting your HDD.
You can mark the thread as solved.


Want to know is MFA server Onpremise support Linux login ?

If yes, want kind of component is required?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75965afd-b39c-5bf0-bc9a-7520bddfd4af
Version Independent ID: be56aebb-04fb-0518-017f-5a7115c8038b
Content: Getting started Azure Multi-Factor Authentication Server - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-mfaserver-deploy.md
Service: active-directory
Sub-service: authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@ericcwk Thanks for your feedback! We will investigate and update as appropriate.

@ericcwk I do not think Linux is supported.  Please refer to Prepare your environment for MFA server requirements.

@ericcwk We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


UI adapt namespace has not commit situation

Coverage remained the same at 45.793% when pulling 00883fd16b53eaf35d8b0f8921d517366eaca094 on lepdou:0105 into 770d2dae46444c534011534e673bdd8f81044e72 on ctripcorp:master.


Update entrypoint.sh

update.sh: fatal: Refusing to fetch into current branch refs/heads/master of non-bare repository error fix

@talva-tr Thanks for making this fix have your tried using push event or switching back to the current PR branch before running this action ??

@talva-tr Thanks for the fix this should be available in the latest release.


Missing validation for server url

Describe the bug
When starting server basing on the definition tooling is not checking if the server url is provided. Documentation is not specifying what fields that are usually optional are required to run server (URL)
To Reproduce
Steps to reproduce the behavior:

Download https://gist.github.com/wtrocki/2ece5c69bc585d36d601b0ce701103f7
openapi-to-graphql example-task.yaml                                                                                3. Execute tasks query
See error

{
  "errors": [
    {
      "message": "Invalid URI \"/tasks\"",
      "locations": [
        {
          "line": 31,
          "column": 3
        }
      ],
      "path": [
        "tasks"
      ]
    }
  ],
  "data": {
    "tasks": null
  }
}

Expected behavior
The server should validate the existence of the url and fail to start.
Screenshots

Happy to contribute and fix this problem uppon agreement.

To be honest, I'm more familiar with OAS 3 than Swagger but I believe the problem is that the Swagger does not have a host or a basePath (servers object equivalent in OAS 3) to build the URL (i.e. we want to call something like "https://myapi.com/tasks" but we were only provided the path "/tasks").
Perhaps the problem is how we are reporting the problem. If you have any suggestions, feel free to speak them!

Having simple check for OAS2/OAS3 if there is server url is provided.
I was using Apicurio (https://www.apicur.io/) to build OAS3 definition so it looks they do not provide url by default.

I found url --url command that resolves the problem by giving a way to override sever url


New 7.2 themes seem to confuse unstyled/styled base themes

Based on https://liferay-community.slack.com/archives/C5H30KZ1A/p1570033569288400 and  https://liferay-community.slack.com/archives/C67VDLMMF/p1570033390001700

Is anyone aware that for 7.2 themes > node_modules for styled theme contains less stuff than unstyled theme? They seem to be swapped around with unstyled surely meaning styled? Also no matter how hard I try even if I select styled I'm getting an unstyled theme. If I choose unstyled, I'm still getting unstyled??
Unstyled size on disk 5.67 MB
Styled size on disk 444 KB
This version of the liferay-js-themes-toolkit (9.4.0)
npm i -g<EMAIL_ADDRESS>

Thanks. I did get a color change in _custom.scss applying so the theme is building correctly. Just choosing _unstyled as the base no matter what.
If I choose unstyled on purpose the size of my theme war increases dramatically and I get all the images etc.

/cc @duracell80

Would it be because of missing imports in styled?
This seems to go nowhere (line 7 /_imports.scss)
@import "clay/base-variables";
There is _variables.scss but not _base-variables.scss

This looks like the Styled theme to me. If you want it to resemble the Classic theme (which I think is the styled look you imagine), you have to extend the Atlas Base theme, I believe. See https://portal.liferay.dev/docs/7-2/frameworks/-/knowledge_base/f/customizing-atlas-and-clay-base-themes Note that this adds default styling that may conflict with your custom styles  @jbalsas can you confirm? I wasn't able to reproduce the file size swapping

I could not reproduce the issue described.  The file sizes for styled theme is greater than the unstyled theme and the applied themes look as expected to me.
Styled

Node modules = 65 MB
War file = 3.2MB

Unstyled

Node modules = 64.6 MB
War file = 2.4 MB

I think here in the documentation ...
By default, Clay base variables are imported into the theme. From what I could see clay wasn't being imported into styled.
The hello world portlet isn't styled in the reproduction? In 7.0 the theme generator would produce a theme that was fully baked with classic. That's what I'm looking for the theme generator to do.

I guess the user story here is that as a theme developer I want the theme generator to produce a mirror copy of classic theme so that I have a fully baked base theme to customize with variables.
So Atlas isn't included by default when generating a theme? I need the hello world portlet to be styled by default when using the _styled theme.

Hey @duracell80!
Yeah, I think there's a bit of confusion coming from the docs and in terms of nomenclature and expectations.
The https://portal.liferay.dev/docs/7-2/frameworks/-/knowledge_base/f/clay-css-and-themes tutorial might provide some additional rationale into what you're seeing:
Clay CSS is bundled with two sub-themes: Clay Base and Atlas. Clay Base is Liferay Portal’s Bootstrap API extension. It adds all the features and components you need and inherits Bootstrap’s styles. As a result, Clay Base is fully compatible with third party themes that leverage Bootstrap’s Sass variable API.

Atlas is Liferay Portal’s custom Bootstrap theme that is used in the Classic Theme. Its purpose is to overwrite and manipulate Bootstrap and Clay Base to create its classic look and feel. Atlas is equivalent to installing a Bootstrap third party theme.

Other than a glitch that caused a publication of the classic theme in 7.0 and in some of our tooling, we've never really supported extending from the classic theme. As it is, the classic theme is a final implementation of a theme that we need control over. Making it a dynamic extension point makes it very difficult for us to evolve.
Thus, we provide:

unstyled -> almost nothing
styled -> base, minimal theme, easy to overlay on top

Keep in mind that styled extends unstyled in a way. The tooling always overlays those too when you extend styled. That's why you only see the images in unstyled, but they should end in your styled-based themes too.
I think at this point, starting from classic has been a common enough request that we need to consider something different than the extension mechanism (which would bound us to keep compatibility). Maybe we can add something like a "kickstart" command with the generator that would dump a copy of classic into your theme... 🤔
/cc @david-truong, @marcoscv-work?

Sorry for taking a while to get back to this.
There is another person having the same issue
https://liferay.dev/forums/-/message_boards/message/114183284
It does make sense with the images being in unstyled, therefore it would be bigger, I had forgotten about that caveat. The issue though I think is that when we ran the generator 4 years ago we got a theme that was styled ... now we don't and it's not clear why that changed or when atlas stopped being included in a generated styled theme.
I still like _ultrastyled, sounds so cool!

We've just migrated this project to the liferay-frontend-projects monorepo in the name of consolidation. As this issue is quite old now, I'm not going to transfer it automatically. If you consider it to be still relevant, please create a fresh issue over in the new repo.


Reverse routing with next url endpoint

Summary
Sometimes, we want to set query_parameters when redirecting like:

http://flask.pocoo.org/docs/0.12/patterns/viewdecorators/

Caution
This option bumped with url variables.
@app.route('/foo/{next}')
def foo(next: str) -> Response:
    return Response('foo')

Maybe next_url is not conflict with url variables.


const support

Closes #44.
This PR will allow the typeshare annotation to be used for const variables. This will copy the variable declaration into the output for the respective language.
For example:
const ANSWER_TO_EVERYTHING: u32 = 42;
const BEST_FILM: &str = "The Tree of Life";

This would become:
const ANSWER_TO_EVERYTHING = 42;
const BEST_FILM = "The Tree of Life";

class Constants {
  static let ANSWER_TO_EVERYTHING = 42
  static let BEST_FILM = "The Tree of Life"
}

const val ANSWER_TO_EVERYTHING = 42
const val BEST_FILM = "The Tree of Life"

const ANSWER_TO_EVERYTHING = 42
const BEST_FILM = "The Tree of LIfe"

As of right now, this PR only supports integers, floats, and strings as constant types.

I would like to have this 👍

Is this still being worked on? It seems very useful

Sorry, this has been put on hold for a while. I'm no longer actively involved with this specific project but I'll try to get this merged when I can.


Ensure all native modules are NAPI or Context Aware

By Electron 11.x, all native modules will have to be NAPI or Context Aware (more info here). Every incompatible module has to be updated or replaced with a compatible alternative. Below is the list of modules we know about so far:

<EMAIL_ADDRESS>

Do you know what we have to do to make modules context aware? Is this something we have to do on our side or something the package creator has to do?

AFAIK it is something the package creator has to do.


sleep feature

Can the sleep feature be disabled using flags in the loader? This is a very annoying feature if not running off batteries.
Also, why can't we simply wakeup the device from sleep by pressing reset? We have to press reset and then also press menu.
Finally, can it wakeup from one the GPIOs. The the micro requires a specific pin then perhaps we can use it on one the buttons

I also find the sleep feature very annoying when testing on hardware. Ideally, it should not trigger at all when on USB

@mmoskal

I think we need to dedicate a pin in the hardware specification to sense the battery level (and report it). Battery level is very important.

Note that dead batteries are even more annoying.


Update centre-id.csv

Include all centre-id parts of the pilot

@golfvert suggest we close this PR and re-issue once the centre-ids are updated per #58

Ok for me.


logrotate: disable acl on non-Linux platforms

Description of changes
Currently running nix build nixpkgs#logrotate on Darwin fails, because it tries to build acl, which is a Linux-only package - since it's an optional dependency, let's disable it on non-Linux platforms.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build logrotate


Instrument and load test over number of databases

Instrument our postgres connections and understand when and how it will fail on different hardware. would pg bouncer help?

duplicate https://github.com/iasql/iasql-engine/issues/1621


[hi] Localize i18n strings in hi.toml

Please describe why this term needs to be updated
Why this term needs to be updated? (briefly)

There are some string in hi.toml(Hindi) which are not translated in Hindi language.
Why this term needs to be updated? (briefly)

As you see that some string are still not translate, User might be seen English string, so I propose to update all String in Hindi language.

I would like to work on it

@aryasoni98 can you give this opportunity to me to contribute


md-list-item in  tag + long description (md-2-line ?)

Bug, feature request, or proposal:
When having a  tag as a md-list-item (i.e ) and a button inside with an event, it first fires the event of the button then goes to the path of the  tag
What is the expected behavior?
Only firing the button event.
What is the current behavior?
It fires both event (the  path and the button).
What are the steps to reproduce?
http://plnkr.co/edit/YsZR4BwZFLZvV74en9F4?p=preview
What is the use-case or motivation for changing an existing behavior?
Gives possibility to add button to a list.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest
Is there anything else we should know?
I've seen a bug for the list fixed into the beta.5 but it didn't improve anything for me.

I've added a plunker here! I believe this is way more simple like that.

I wonder if this is something that should be supported out of the box. As a workaround, you could use preventDefault() to keep the click event from bubbling up to the anchor element
http://plnkr.co/edit/dDxySwiO7xJ4DHtODSFL?p=preview
Note that I also added stopPropagation() so that clicking the edit button doesn't trigger a ripple on the whole list item.

Hi and thank you for your answer ! it seems that in your plunkr the href isn't working anymore... Does it work for you?

It logs an error because the frame doesn't want to navigate away, but that's the nature of using plunker. This should work (tested Chrome/FF/Safari):
http://run.plnkr.co/plunks/dDxySwiO7xJ4DHtODSFL

That's great it works with the href. Do you know how to make it work with routerlink? Because it doesn't have the same behavior.

Oh oops, use both of these in your click callback
event.stopPropagation();
event.preventDefault();

hi, yes that's what I did, it works great ! 👍  But I guess it shoul be supported ootb no ?

It is invalid to place a button inside of an anchor. The nav-list is intended to be used in situations where the entire action of each list item is a navigation (with no sub actions allowed). For more custom scenarios, the normal <md-list> should be used with each item containing whatever anchors and buttons you want.


How is this positioned in relation to AutoRest?

What are the advantages and disadvantages?
Looking at https://github.com/Azure/azure-rest-api-specs, it seems that clients are still generated via AutoRest is that correct?
I'm just wondering which to choose..
Thank you very much,
softworkz

Hi @softworkz ,
Thanks for your interest in Kiota.
Correct, most of Azure SDKs are generated by AutoRest to the exception of things like Azure Identity and such.
This generator (kiota) is used at Microsoft to generate Microsoft Graph SDKs as well as other internal projects.
You can experience them via:

The dotnet preview SDK version 5 and above
The Java preview SDK version 6 and above (upcoming)
The PHP preview SDK version 2.0.0-RC5 and above (upcoming, the team is publishing the packages as I'm writing)
The JavaScript/TypeScript preview SDK
The Go preview SDK
The CLI preview

The Kiota documentation is also a great way to know more about Kiota itself, the design decisions and more.
As per the original question about what's Kiota position regarding AutoRest, you can think of it as an alternative.
AutoRest works well with APIs that are small, don't have a lot of interconnections/can easily be segmented without loss of functionality (i.e. a blob storage model, doesn't do anything with the sentiment model in cognitive services), and are not too deep (i.e. /path/subpath/subsubpath/subsubsubpath...). Additionally it will produce a "shape of API"/experience that you might or not like.
For all those reasons, we've started this generator, which better handles the limitations mentioned above, and provides a different client experience. One is not meant to replace the other, they just address different segments with different needs, and YOU get to choose which one works better for the scenario you're trying to address.
I hope this clarifies things a bit, don't hesitate if you have comments of follow up questions.

Thanks @baywet  and @darrelmiller,
this sounds interesting. In fact, I'm trying to get some orientation in choosing the most suitable toolchain all around the subject of "SDK Generation", which includes conceptual documentation, reference documentation for both .NET code and a (not that small) REST API and eventually generation of API clients to include in the SDK.
4 years ago I had started using Microsoft.OpenApi (version 1.0.1) to generate OpenAPI/Swagger spec files and that part is really fine.
 The goal is to have an automated single process for building this as an SDK package at any time which is always up-to-date.
I thought that this is not a really exotic concept and that must be plenty of way to get this all done in a consistent way, and as our whole ecosystem is built on .net (been 7yrs MS MVP), it started looking around in the MS space. These were my findings:

There are many options for client generation, might take a long time to find out which is the best one (maybe Kiota 😄)
Generating documentation while mixing
conceptual PLUS .net assembly PLUS Rest Api
appears to be hard to find any tooling for
docfx is the MS tool for generating docs, and it basically can create Rest Api docs - but really not in a nice way

it creates a single html page for a given json
plugins (for splitting) are dysfunctional
even after fixing them, the results are ridiculous
they don't support OpenAPI3

There doesn't seem to be any collaboration:

Searching for docfx in the OpenAPI.Net repo yields zero results
Searching for OpenAPI.Net in the docfx  repo yields zero results

Made me wonder how MS is doing it, when they are using docfx?´
I ended up here where I found some internal links to which I have no access

I know that this is only indirectly related to Kiota, but since your project is relatively fresh, chances are high that you might be up-to-date to the bigger picture and MS plans in that area.
PS: I'll also have a few questions on (actually) Kiota.
Thank you very much,
softworkz

Our documentation process is a bit different from Azure's and relies on internal tooling.
IMHO there's little value in having auto-generated doc for a .NET/TS/Go... client that's based of an OpenAPI description if you already have good documentation for the REST API itself. That's besides the snippets that answer the following question "what's the equivalent .NET call to this HTTP call?"
You can explore the documentation for Microsoft Graph here and you'll see that we have a mix of:

conceptual docs
CRUD/model auto-generated docs
language snippets auto-generated
SDK docs

I believe the key is in separating the different sections properly to ease up navigation and maintenance. I think our internal tooling might be using docfx at some places but this is handled by some other internal team.
Now, Kiota leverages descriptions and summaries from the OpenAPI description to generate doc comments and augment the intellisense/auto-completion experience of the developer using the client.
And I know that swagger UI does as well.
My personal advice would be to focus on high quality OpenAPI documentation on one hand and high quality conceptual/scenario oriented documentation on the other.
This way you'll be able to produce high-quality clients (Kiota, AutoRest, etc...), have an automatically generated documentation for CRUD and/or a sandbox (swagger ui), and have great introduction/conceptual/scenario/advanced documentations.

You can explore the documentation for Microsoft Graph here

Very nice! Well - that's what I want to have... :-)
I guess the tooling behind that is non-public?

IMHO there's little value in having auto-generated doc for a .NET/TS/Go...

It's not about generating a doc for the generated clients. We have a REST API and we also have a server-side PlugIn model. The latter is generated from .NET code. This causes a bit of duplication, especially for the type definitions, as there are those from the .NET code documentation and then those from the REST API definitions.
The public docfx doesn't even generate definitions, which makes it hardly usable for having a proper REST API documentation. I wonder how you are doing that internally.

My personal advice would be to focus on high quality OpenAPI documentation on one hand and high quality conceptual/scenario oriented documentation on the other.

I think we already do have some good OpenAPI definitions. At that time, I tried included everything that shows up on SwaggerUI, but I'll try some Kiota generation now and see how it will turn out!

Yeah most of the tooling is internal unfortunately, I think the only ones that are public are:

api doctor that mixes concerns between scaffolding new documentation topics from api description (CSDL based), generating HTTP request snippets, and linting documentation.
devx api that generates SDK snippets from HTTP snippets

I'm not sure any of that is usable beyond our own scenarios at this point.

I won't comment on the reliability and dependencies aspects of AutoRest here.
The OPTIONS and TRACE scenarios you're mentioning are really interesting, we didn't include those in our test scenarios. On paper Kiota should not fail to generate for those, but is the generation outcome going to be useful? that's a good question and we're looking forward to your feedback!

Regarding OPTIONS and TRACE I'll need to check back with a colleague. I don't know why it's there and how it is been used.

Unfortunately, it has turned out the Kiota is not exactly what I'm looking for.
This project is still impressive in a way that it shows what can be achieved within just a number of months, while other projects are getting nowhere.
Thanks a lot for your support!
softworkz


Update nucleo_f303re.dts to match board labels

Updated i2c1 to match labeling on board and standard Arduino header pinout Fixes #57394

Rebased from main, and updated commit message to match guidelines.

Is it possible to backport this fix to the 3.3 branch?


Failed to compile

Hi, I am new to Heroku, and do not know what I did wrong. I highly appreciate if anyone can help me here. Here is the error message that I got when I 'git push heroku master.'
Does anyone know how to fix this? Thank you.
ude/libffi -I/app/.heroku/python/include/python2.7 -c c/_cffi_backend.c -o build/temp.linux-x86_64-2.7/c/_cffi_backend.o
remote:            c/_cffi_backend.c:15:17: fatal error: ffi.h: No such file or directory
remote:             #include <ffi.h>
remote:                             ^
remote:            compilation terminated.
remote:            error: command 'gcc' failed with exit status 1
remote:
remote:            ----------------------------------------
remote:        Command "/app/.heroku/python/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-p5BnBS/cffi/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-4k1LWT-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-p5BnBS/cffi/
remote:
remote:  !     Push rejected, failed to compile Python app
remote:
remote: Verifying deploy...
remote:
remote: !	Push rejected to hhapp.
remote:

@hhsieh Could you please file a ticket at https://support.heroku.com ?  This is not a bug in the CLI and I do not have the requisite python skills to help you.  If you submit there, it will be routed to people who will be able to help you better.


TypeError: undefined is not an object (evaluating '$httpBackend.expectPOST') in test/leave.service.tests.js (line 65)

I got the following error
PhantomJS 2.1.1 (Linux 0.0.0) leave API service create(): should create a leave FAILED
        static/app.min.js:4804:54
        forEach@static/app.min.js:440:25
        loadModules@static/app.min.js:4764:13
        createInjector@static/app.min.js:4686:31
        WorkFn@node_modules/angular-mocks/angular-mocks.js:3120:60
        loaded@http://localhost:9876/context.js:151:17
        TypeError: undefined is not an object (evaluating '$httpBackend.expectPOST') in test/leave.service.tests.js (line 65)
        test/leave.service.tests.js:65:16
        loaded@http://localhost:9876/context.js:151:17

Test
var chai = require('chai');
var assert = chai.assert;
require('../src2/pages/leaves/leave.service.js');

describe('leave API service', function () {
	var service;
	var $httpBackend;

	beforeEach(angular.mock.module('app'));

	beforeEach(inject(function (_$httpBackend_, LeaveService) {
		$httpBackend = _$httpBackend_;
		service = LeaveService;
	}));

	it('create(): should create a leave', function (done) {
		var leave = {name: 'test'};
		$httpBackend.expectPOST('/api/leave/', leave).respond(201, leave);

		service.create(leave).then(function () {
			done();
		});
		$httpBackend.flush();
	});
});

webpack-related config in Karma.conf.js
		files: [
			'./static/app.min.js',
			'node_modules/angular-mocks/angular-mocks.js',
			{pattern: 'test/leave.service.tests.js', watched: false}
		],
		preprocessors: {
			'test/leave.service.tests.js': ['webpack']
		},

Do you know why I got trouble with the injection?

you shouldn't include your test files explicity via karma.conf.js. there is an automation to load tests in this file. just leave the configs as they are checked in the repository.
let me know if this will resolve your issue.

Here is how I did it
Karma-webpack: Unknown provider: LeaveServiceProvider <- LeaveService

@edouard-lopez so the issue was the angular.mock.inject. as i told you, you do not have to explicitly load the tests file because webpack.require.context can dinamically load files at runtime.

I will investigate the require.context(), thanks.

@edouard-lopez  i am facing the exact problem . How did you solve it ?
In my karma file , i dont explicitly mention the spec file instead mention like this :
`    files : [
'./node_modules/angular/angular.js',
'../src/main/webapp/test/unit/**/*.spec.js',
],
preprocessors: {
'../src/main/webapp/js/login.js':['webpack','sourcemap'],
'../src/main/webapp/js/mainApp.js':['webpack','sourcemap'],
'../src/main/webapp/test/unit/**/*.spec.js': ['webpack','sourcemap'],
},`
If i specifically run only single .spec file having $httpBackend . The test cases pass . But when i run everything like shown above in karma : "../src/main/webapp/test/unit/**/*.spec.js" . Then i get the same error as mentioned by you .
Can you please tell what did you do ?

@ashwanikumar415 see my stackoverflow answer.


Inquiry regarding "WARNING:root:unexpected tensor: projection.weight"

@JiJiJiang
Thank you so much for providing such a fantastic speaker recognition tool.
I tested "Command Line Usage", and the following warning message occurred.
"WARNING:root:unexpected tensor: projection.weight"
I installed all packages according to the installation guide.
Will there be any performance impact if the warning message occurs?
If there is a solution to the warning message, please guide me.
Thank you

Thank you for your question,
There isn't any performance impact caused by the warning.
We saved the whole model in the checkpoint. However, when inferring the model to obtain the speaker embeddings, we don't need the  projection module (mapping embeddings to training speakers).

@JiJiJiang
Thank you for your quick and detailed reply.

Thank you

Thank you


The subpackage GreatCircle is missing

The turf library provides a feature to calculate the great cirlce distance between two points. This feature is currently missing. This also includes a library to calculate an arc.

working on it.


Normalize time values in Certificate resources

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
https://github.com/argoproj/argo-cd/issues/6008

License
Apache 2.0

What's in this PR?

Better support of ArgoCD for deployment - use full time string for certificate duration
Why?

Always OutOfSync status of Certificate resources due to diff in duration string
Additional context

Checklist

[X] Code meets the Developer Guide
[X] User guide and development docs updated (if needed)
[ ] Related Helm chart(s) updated (if needed)

To Do

[ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.n.shashkov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please bump the chart version as well.

@bonifaido Fixed


flush all record external-dns created

When undeploying a cluster for google cloud-dns the zone should be emptied. Right now one would need to remove the services and wait 'a bit' until external-dns removed the dns-record, then undeploy external-dns.
It would be nice to have a way to either force updating the records or having a way to flush the added records manually.

I guess creating a script to iterate through all DNS records "owned" by External DNS (e.g. identified by TXT record) should be easy to do. I don't see this as part of the External DNS "core".

I've considered this. Unfortunately gcloud dns does not make this easy. Deleting a record requires you to specify all fields. One can filter like this:
gcloud dns record-sets list --zone=external-dns --format=json | jq '. | map(select(.type == "A" or .type == "TXT"))'
but generating the transaction from this list is still not trivial :/

Thanks for the idea.
IMO there might be a certain use for this feature, though I don't see it coming in the nearest future, as for now we are more concentrated on core components - dns providers, compatibility and refactoring, having a functionality to flush the records will probably not come before we will stabilise the "where's" and "how's" the records are managed on dns provider side and how they are generated from k8s resources.


Implement colorspace tex-srgb

Ref #557
This, I think, solves the remaining point in #557. In my view, there are valid cases for handling srgb both by conversion in the shader, as by using an -srgb texture format. This implements the latter.

Interesting to see that the glTF-compliant method produces less pretty results (see the bands in the new validation screenshot).

@panxinmiao

Interesting to see that the glTF-compliant method produces less pretty results (see the bands in the new validation screenshot).

In fact, in this use case, the "banding" effect in the image is actually correct. This is because the color data is in the sRGB space, while np.linspace(0, 255, 6) performs interpolation in linear space. The gradient between the generated colors is not linear because the sRGB space itself is non-linear. In sRGB space, the gradient between colors is uneven.
This use case precisely demonstrates the error of interpolating directly in the sRGB space. To generate smooth gradient colors in sRGB space, the data should first be converted to linear space, then interpolated, and finally converted back to sRGB space.

import numpy as np

# Generate interpolation in linear space
lin_rgb = np.linspace(0, 1, 6)  # Linear interpolation from 0 to 1
# Convert linear RGB back to sRGB space
srgb = np.clip(lin_rgb ** (1/2.2), 0, 1)

# Scale the interpolation result back to the range of 0-255
srgb_255 = np.clip(srgb * 255, 0, 255).astype(np.uint8)

If the image data is in the "smooth" sRGB space (i.e., the data is non-linear), and interpolation is performed before sampling as it is currently done, I expect that it would actually result in "banding."

@panxinmiao I don't entirely agree 😄   But I think we do agree that both approaches have valid use-cases, and this PR tries to make it so that we have can both. Do you have any comments on the implementation or is this good to go from your end?

In the mean time we can discuss this band effect.
I meant to create a gradient in sRGB space, so np.linspace()  interpolates in the sRGB space, simply because I state that the data is sRGB. I started with 100 samples, in which case the band looks smooth in all cases. Then I used less samples and see how the results differ. Although downsampled, it's still sRGB space. It's the same effect of using a lower resolution texture map.
The shader is sampling from source data that is in sRGB space, so it makes perfect sense that the result looks better if the interpolation happens in the sRGB space.
If the image would represent "physical" data, then the "source" is in linear space, so missing values are best reconstructed by interpolation in the linear space.

I understand your point. In this use case, you aim to create an image that appears visually smooth in the sRGB space, which requires performing linear interpolation directly in the sRGB space. However, the corresponding physical color values would then be nonlinear. Following the "tex-srgb" workflow (i.e., decoding first and then performing interpolation in the physical space), banding artifacts will occur, which is expected. However, this is a special use case (working directly in the sRGB space), whereas modern rendering engines and related shader and lighting algorithms are typically designed for linear workflows and operate in linear space.
To address your requirement, we only need to set both the input and output textures to non-sRGB formats (although we currently don’t support setting the output texture format). I understand that you may consider the data to "represent" sRGB space values, but this is not critical. For the program, data is just data, and its meaning is defined by the user. Texture formats simply dictate how data is processed and do not necessarily align with its actual significance. By configuring this way, we essentially instruct the program to "process the data directly without decoding into physical space." Since no space conversion is applied, you can think of the shader algorithms as effectively operating in the sRGB space.

Do you have any comments on the implementation or is this good to go from your end?

I think the current approach is acceptable, at least it can solve some of the current needs. However, it is evident that this will increase the complexity of shaders and code.

In #910 you mention that "this issue still needs further resolution". I was under the impression that the gltf loader can simply set colorspace="tex-srgb" for things to work as glTF intended. What part is still missing?

I was under the impression that the gltf loader can simply set colorspace="tex-srgb" for things to work as glTF intended. What part is still missing?

This is exactly what I mean.
Additionally, the logic related to texture colorspaces needs to be adjusted. My idea is to standardize the logic for all textures and ensure that each texture’s colorspace property is truly effective (rather than just the colormap’s colorspace being considered).
For example, for an env_map, typically in the sRGB space, when loading from glTF, we simply specify its colorspace as "tex-srgb" in the glTF loader. However, for environment map textures created by the user, they can choose "tex-srgb", "srgb", or even "physical" (any of these cases are possible). We need to handle these different settings. When the user specifies "srgb", the shader must be able to handle the space conversion (even though this may not be entirely correct or fully compliant with the glTF specification). When "tex-srgb" or "physical" is specified, no conversion should be performed.
The increase in shader code complexity that I mentioned earlier refers to this issue.

I'm not sure what the problem is. The colorspace attribute is honored in (AFAICT) all cases where the texture is interpreted as color.
And yes, this has made the code a bit more complex, but that's the price we pay (and one that I'm happy to pay) for supporting the different use-cases related to srgb.

I'm not sure what the problem is.

What I meant in #910 is just to note down the tasks that are still pending:

Setting the correct format for each texture in the glTF loader.
Handling the colorspace of each texture in the shaders.

I plan to complete these tasks in a single PR. Simply noting that the issue with that test case has not been fully resolved before that PR :)


Fix LTO support for WebAssembly targets

It seems .bc input file handling and -flto clang linker driver option were forgotten to be ported.

@swift-ci test


use sphinx for documentation

While pydoc is super nice for small and straightforward projects, I think the flexibility of sphinx is needed here. E.g., there is this nice extension for automatically inserting commands and their output.

Most of the work was done after the merge at 989b9726afd23f53de42c6369756210729b9106e.


3D possible?

Hi!
Is it possible to add a third dimension to the function?(z height)
Something like:
polygon = [(0,1,2), (-1, 0, 2.5), (0, -1, 2.5), (1, 0, 2)]
I tried it but get the error:
triangles = tripy.earclip(polygon)
 File "C:\Users\SEKRSV\AppData\Local\Programs\Python\Python36\lib\site-packages\tripy.py", line 30, in earclip
    polygon = [Point(*point) for point in polygon]
  File "C:\Users\SEKRSV\AppData\Local\Programs\Python\Python36\lib\site-packages\tripy.py", line 30, in <listcomp>
    polygon = [Point(*point) for point in polygon]
TypeError: __new__() takes 3 positional arguments but 4 were given

The problem in 3D space is quite a bit more complicated than on a single plane. While technically one can calculate the area of a triangle in 3D space with nearly as much ease as 2D, the surface itself depends on the points chosen. At a first glance I think this would be far more complicated than this library would provide.
However, for this class of problem in 3D you might want to look into Delaunay triangulation:
https://www.youtube.com/watch?v=63MM0EqXlT0
See also SciPy's implementation:
https://docs.scipy.org/doc/scipy-0.14.0/reference/generated/scipy.spatial.Delaunay.html


RHINENG-10904: Kebab actions for expanded details

https://issues.redhat.com/browse/RHINENG-10904
I added 2 kebab actions to copy the user experience from the Alerting page.

/lgtm


quota: migrate from SPECS-EXTENDED to SPECS

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

The quota package monitors and limits disk quota. Partners have requested this tool to be made available and supported in Mariner.
We supply this today in the extended repo, but this change moves it to our main SPECS folder so it will be published as part of our core package repo.
Signed-off-by: Chris Co<EMAIL_ADDRESS>Change Log

Migrate the quota package from SPECS-EXTENDED to SPECS

Does this affect the toolchain?

NO
Associated issues

https://microsoft.visualstudio.com/OS/_workitems/edit/39419014
https://microsoft.visualstudio.com/OS/_workitems/edit/38077011

Links to CVEs
Test Methodology

Local build

Looks like there is a newer version of quota available (4.06). Converting back to draft to update to 4.06


slate download command

 Issue by NathanPJF
Saturday Jan 14, 2017 at 22:34 GMT
Originally opened as https://github.com/Shopify/slate-tools/issues/40

Slate currently doesn’t have a equivalent of Theme Kit’s theme download command.  It may be helpful to have this pull down individual files, or the entire hosted site, into the dist folder so developers can use git to see what all has changed.
Scenario:  You have to make a hot fix on the live site, or the merchant you are working for made some of their own changes while you were away.  How do you find out what exactly changed and across which files?
Other scenario: I make a bunch of changes to my theme settings using the Online editor.  How should I have those reflected in my remote files?  Currently I would need to go to the settings_data.json files and copy its contents then paste those into my own src/config file (and dist if I want as well).
Location of download
Suggesting the files be pulled into the dist folder because they are essentially compiled files.  This command would be there to help developers, particularly those using git, to see what changed and then work on their build files to match.

 Comment by celsowhite
Wednesday May 03, 2017 at 17:04 GMT

This is the only thing preventing me from switching from quickshot! Would love to see this in place.
I typically develop sites for clients then only come in later for hot fixes or new feature requests. In between that time, many of my clients will upload new assets, make css changes or change content in template files. All of which I'd like to pull locally and potentially deploy to my development environment.

 Comment by tkdave
Wednesday Jul 05, 2017 at 21:16 GMT

Themekit tool still works. Just tell it what directory to use.
theme download -d src -e production

 Comment by infernalsirius
Thursday May 04, 2017 at 09:53 GMT

I was about to open an issue for this feature 😉  . Right now the watch feature does not look upstream for changes that may have been done in the web admin interface. If you try to download using the older themekit tool, it does not respect the folder hierarchy needed with the build system.
If you are using an app that generates code and add it to your files, it can be quite a task to track every changes and transfer them to your local dev environment. For this use case, even quickshot does not seems to be able to it since it is uploading the builded files.
Having the code downloaded to the dist folder would surely be a step forward, but if you track your project with a versioning system, you'll still have to find the code in the dist files, which is almost the same as copying and pasting it from the web editor.
Maybe that a kind of deploy hook in combination with a repo ( github, bitbucket, etc) could be the answer. The web editor would commit the changes to the repo and the sync would be done as usual, by pulling the latest changes from your remote repository... It sounds more complicated though than having a simple remote repository access to your Shopify store. Those are only ideas I throw in the wind here 😉 .

+1 for this - I have just had a 3rd-party app install some stuff in my store and now I am having to manually extract what they have done into my local copy... a real faff!

Closing this in preference of #255


[ServiceBus] Track2 should fail-fast on invalid gredentials on client opening, not on receiver/sender open.

Currently, if one initializes an sbclient and then get_queue_receiver on it (with invalid credentials)  the failure will only occur in the latter step.
Best practice would be to fail fast during the ServiceBusClient open() open.
Per adam: uamqp handshake may be heavy in leiu of full-featured connection sharing, so administration controller may be a clever workaround.
Edit 2: Administration Controller wont work with entity-specific credentials.  Requires namespace-level credentials.  Need to actually go through the UAMQP CBS handshake / have the inner client 'do connection' to force a failure to occur if there is one.

Designing this feature revealed pitfalls.

A user can provide credentials at the client level.
This can include credentials for a specific entity, not the top level namespace.
On top of that, one may have provided NOT the entity-specific connstr, but the raw sas key/policy.  The key to realize here is that they did NOT provide the entity path.
This has the consequence, to my understanding, of disallowing us to establish a connection until they've called get_*_<receiver/sender> to tell us what entity we're connecting to.

This has the result that one cannot from my perspective fail fast on ServiceBusClient opening, since one may get an entity-specific credential without the full path
We've synced with C# folks and they are similarly taking a lazy approach to opening and see the same constraint.
In light of user studies indicating that most users do not think about connection lifespans occuring at the client level (do not context manage the client) it seems reasonable to use this as our "Escape route": namely, that if users don't associate the connection and the top level lifespan, don't force it.  Refcount on receiver closure to allow sharing and not require explicit servicebusclient close, and do not force connection on open. An extension for this in the future could be if the credential is not entity-related, but that's somewhat of a pipe-dream at this point.


⚠ Mobitopup has degraded performance

In 9cee577, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 10855 ms

Resolved: Mobitopup performance has improved in 3a2a541.


Gradle 7: Plugin with id 'maven' not found.

Description
Just upgraded React Native to 0.67.4 which bumps up Gradle to 7.2. And now running into this error on build.
<EMAIL_ADDRESS>line: 25
A problem occurred evaluating project ':seatsio_seatsio-react-native'.

Plugin with id 'maven' not found.`

Maven plugin has been removed in Gradle 7. docs.gradle.org
Steps to Reproduce

Upgrade React Native project to React Native 0.67.4
Try to build Android Project

Expected Behaviour: Builds fine
Actual Behaviour: Plugin with id 'maven' not found.
Versions
"react-native": "0.67.4",
"@seatsio/seatsio-react-native": "^3.1.0",
Gradle 7.2

Hi, we'll have a look.

Should be fixed now, in v3.2.0


update kvproto dependencies

Signed-off-by: linning<EMAIL_ADDRESS>

you can replace the path github.com/zhangjinpeng1987/raft in the code and remove the replace in go.mod

you can replace the path github.com/zhangjinpeng1987/raft in the code and remove the replace in go.mod

I update the zhangjinpeng1987/raft dependency instead, PTAL @coocood

LGTM


Implement connection rebalancing for HTTP/2

Also upgrade Jetty to the version we use internally

Tragically, CI failed in exactly the way it shouldn’t!
Expected size:<2> but was:<1> in:
<[Connection{<IP_ADDRESS>:43083, proxy=DIRECT hostAddress=/<IP_ADDRESS>:43083 cipherSuite=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 protocol=h2}]>
	at misk.web.RebalancingEnabledTest.checkResponse(AbstractRebalancingTest.kt:116)

... I found a simple way to mitigate against the race. By making 3 calls it’s a guarantee the first close will be observed before the 3rd call is attempted.


[feature] avoid setup-golang tools when downloading a binary

Is your feature request related to a problem? Please describe.
I'm currently getting warnings from setup-golang action, due to having already setup golang with a different version and cache location.
That slsa generator needs it when its downloading a binary seems erroneous and is a causing this spurious message as well as wasting ci time.
https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/generate-builder/action.yml
instead the setup-golang step should be conditional on the input if the tool is to be built.

I'll not the warning here would also be addressed by https://github.com/slsa-framework/slsa-github-generator/pull/2864

That slsa generator needs it when its downloading a binary seems erroneous and is a causing this spurious message as well as wasting ci time.

If downloading the binary this is true but the Go compiler will be needed when building from source. We could add a conditional to only run setup-go when the compiler is needed (which is most often for our pre-submits etc. anyway).

@kapilt
Also, just curious, how are you running into this issue? Our workflows should be calling generate-builder as part of reusable workflows which are run in their own VM. are you calling generate-builder directly yourself?


Validate scrape configs/targets from incoming relations

The addition of a config validation action provides a good way to validate a complete Prometheus configuration, but it is only useful as a all-or-nothing check, where a potentially invalid configuration must either not be pushed to the workload, which may also miss other changes in relations, or to apply it and block Prometheus entirely, forcing the use of the action.
In addition, on an upgrade, pod restart, or other scenario whether the workload container is not running, it is not possible to pre-preemptively validate the configuration, since promtool will not be accessible.
Similar to cos-tool validating alerts, we could extract the portions of promtool used to evaluate rules/targets and validate them in an isolated fashion, sending events back as appropriate (again, similar to the alert rule validation).

I see no reason to extract code from promtool as it already ships with the prometheus rock. We can use the full tool directly.


Problem with static server

run gulp
include some styl file into the build process
create a mistake in the file
try to continue the work :)

Current result: static server falls down and stops watching the files, if you break gulp work and run it again it won't help you, because static server process is detached. You need to stop the node process manually
Expected:

static server continues working if an error happens.
static server stops at the same time the gulp does.

It's a problem with your gulpfile. See solution here.


How to set vertical align center in IOS?

I added a button to view and the title is "LOG In".

You can add padding or paddingTop to the button style @deju
<Button style={{padding:10, height: 45}}>

It doesn't run on Android.
Can add alignItems: 'center', to style options plz?

+1 Padding does not seem to work

Specify the padding in the containerStyle prop, instead of the style prop.
On Thu, May 12, 2016 at 12:08 PM, jwynveen<EMAIL_ADDRESS>wrote:

+1 Padding does not seem to work
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/ide/react-native-button/issues/24#issuecomment-218855695

@ide maybe just close this issue now

@andrewljohnson thanks for helping out -- closing this.


[FR] Switch UI to React

Is your feature request the result of a bug?
No - More of a vision
Problem
Currently we build a lot of html templates and js. As there is a disconnect between the server and the frontend we do not really have tests for the frontend. Also there is a lot more data transmitted than needed.
Suggested solution

Switch to React (or a framework that uses React as basis like remix or next.js)
Add UI testing with cypress
Run test via gh-actions

Describe alternatives you've considered
Current solution works fine but this FR would be cool.
Examples of other systems
A lot seems to run on this - an example in our field would be https://partsbox.com/
Do you want to develop this?
I would love to help but this would be a team effort.

@SchrodingersGat can we get a 1.0 milestone for that? @eeintech

@eeintech huge adoption, not very opinionated, good toolset ecosystem and a lot of examples that this sort of application can be done in react.
The tooling is a good fit for what we already do with js. A lot of code should be adaptable rather easy. And there are not as much heavy breaking changes as in vue. Got burned by that too often now.

Sounds good thanks!

@eeintech always open for feedback but I think react is a good compromise.
I will do a prototype for how I would tackle it so we can discuss the architecture, todos etc. in the coming months. It is a lot but not as much one would think - we can reuse all the API forms from what I can see.

I dislike React. I'm working on a project, and at the end of every day I want to go out to the garage and hang myself. Please stay clear of React.

@4jag we are open for other suggestions.
I have worked and am working on multiple projects with next.js and find it to be much better than bare js + html. Could you elaborate on the problems you see / which framework would be better suited for this project?

Tutorial for Vue: https://realpython.com/python-django-blog/#step-6-set-up-vue-router

Geniunely, why? Your front end seems clear, simple, and capable. You could acheive more UI testing with your current frontend. You could even use this sort of system: https://playwright.dev/

Have you worked with the front-end code? A lot of bugs are because of missing typing and lazy linking of important parts via jquery. It also needs full reloads for a lot of actions.


Cosmos DB: Corrected Azure Cosmos DB branding.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/cosmosdb.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

I'm so embarrassed this has sat like this for so long!  Thanks for the fix, @mimig1 !

@CamSoper  - No worries - just doing some global housekeeping here. :)


[FLINK-9927] [Documentation] Change .print() to .output() in Python Streaming example

The method .print() doesn't exist, it should be .output()
What is the purpose of the change
Correct the final line of the pipeline example in the python streaming example. There is no such method as .print(), it should say .output().
This is a documentation change only, no code is touched.
Brief change log

change one line of the streaming program example code.

Verifying this change
This change is a trivial documentation change.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

LGTM cc @zentol


Install libxml2 into container

Install libxml2 into container via "postCreateCommand".
Why:
mcr.microsoft.com/dotnet/sdk:7.0 lacks libxml2 package, causing dotnet build to fail:
/root/.wasi-sdk/wasi-sdk-16.0/bin/wasm-ld: error while loading shared libraries: libxml2.so.2: cannot open shared object file: No such file or directory

Or is there a more idiomatic solution other than postCreateCommand?
BTW, thank you @brendandburns for devcontainers you've created!

Thanks for the PR, sorry it took so long to merge!


Go Function always fails with permission denied

Description:
As written in the title, Go function always fails with a permission denied error.
I have just followed the instruction written in the below page to compile dlv and my go binary.
https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-using-debugging-golang.html
Of course, I have checked permissions of those binaries and those were executable for all users.
Steps to reproduce the issue:

execute "sam local start-api -d 5986 --debugger-path debug"
kick "curl http://<IP_ADDRESS>:3000/test"
Error occurs

Observed result:
Fetching lambci/lambda:go1.x Docker container image......
2018-10-28 00:35:10 Mounting /Users/nhiromoto/.gvm/pkgsets/go1.10.4/global/src/sam-debug-sandbox as /var/task:ro inside runtime container
START RequestId: 0fd90978-6cb3-1642-3e9f-6e812d4c67d1 Version: $LATEST
END RequestId: 0fd90978-6cb3-1642-3e9f-6e812d4c67d1
REPORT RequestId: 0fd90978-6cb3-1642-3e9f-6e812d4c67d1	Duration: 2.58 ms	Billed Duration: 100 ms	Memory Size: 128 MB	Max Memory Used: 7 MB
{
"errorMessage": "fork/exec /tmp/lambci_debug_files/dlv: permission denied",
"errorType": "PathError"
}
2018-10-28 00:35:11 Function returned an invalid response (must include one of: body, headers or statusCode in the response object). Response received:
2018-10-28 00:35:11 <IP_ADDRESS> - - [28/Oct/2018 00:35:11] "GET /test HTTP/1.1" 502 -
Expected result:
my go binary runs
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)
sam cli version -> 0.6.0 and upper
go -> 1.10
dlv -> 1.0.0 and upper

Is this because of docker image build done 6days ago?
https://hub.docker.com/r/lambci/lambda/
I have seen a blog post that says the instruction had been working until two months ago.

@NHirom What is in the debug directory you are passing in --debugger-path?

Closing as inactive.


ITV gets on screen signed language video instead of a normal unsigned video

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.04.30
[ ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl.exe" --geo-bypass-country "GB" --ignore-config -v --all-subs --sub-format "vtt" --sub-lang "en" --fixup "never" -f "best" "https://www.itv.com/hub/the-professionals/L0845a0044"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--geo-bypass-country', 'GB', '--ignore-config', '-v
', '--all-subs', '--sub-format', 'vtt', '--sub-lang', 'en', '--fixup', 'never',
'-f', 'best', 'https://www.itv.com/hub/the-professionals/L0845a0044']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.04.30
[debug] Python version 3.4.4 (CPython) - Windows-XP-5.1.2600-SP3
[debug] exe versions: ffmpeg N-91691-g962c931-Reino, ffprobe N-91691-g962c931-Re
ino, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Using fake IP ok (GB) as X-Forwarded-For.
[ITV] L0845a0044: Downloading webpage
[ITV] L0845a0044: Downloading XML
WARNING: Unable to download XML: HTTP Error 504: Gateway Time-out
[ITV] L0845a0044: Downloading JSON metadata
[ITV] L0845a0044: Downloading m3u8 information
[debug] Invoking downloader on 'https://itvpnpdotcom-a.akamaihd.net/IMM-00054-00
5-003/18/1/VAR012/IMM-00054-005-003_18_1_VAR012.ism/IMM-00054-005-003_18_1_VAR01
2-audio=128000-video=1503019.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 236
[download] Destination: Hijack-L0845a0044.mp4
[download] 100% of 562.01MiB in 04:22

Description

There are two picture placements for the same video on the web page. Both insert placements have the same ID number L0845a0044 only. When download this Youtube-dl downloads an on screen signed language video. Needing the normal non on screen signed video but unable to get or unknown how to as video has the same ID on the web page.

youtube-dl downloads the same video that can be viewed in the browser.
provide instruction or screenshot on how to access the normal version(without sign language).

As said the page has two pictures for the same episode mouse over each and they both show "L0845a0044" and that is all that can be chosen. Mention in case some extra parsing can be done background to see if exists two video under same ID. If so for us to have option to get signed or non signed. Unknown if you have come by this yet or is something new the broadcasters are doing.
Maybe there error I though but why two picture placements on not one but sometimes a few videos. But always both picture placements for the show will have the same ID.
Appreciated if without ID nothing can be done but is an opportunity to look at web page and parsing ID to see if it is something new the broadcasters are doing. Not so beneficial if all becomes like this.
NSFW please indicate what needs editing and which button is the edit button to edit it.

NSFW done a search for its meaning.
Not safe for work (often shortened to the acronym NSFW) is an Internet slang or shorthand used to mark URLs and hyperlinks which link to videos or websites pages containing nudity, intense sexuality, profanity, violence or other potentially disturbing subject matter, which the viewer may not wish to be seen looking at in a public or formal environment, including a workplace or school.

Provide Clear Instructions or Screenshots on how to access the normal version(without sign language).


Create Active Record Model From Condition

It will be great if we have some methods like findOneOrCreate in active record class to create new model if condition array is don't have any match.
$object = MyModel::findOneOrCreate(['name' => 'My name']);

By the way we can have some more methods like findOneOrNew to make an object if not found and findAllOrFail to raise exception if data not found.

I have added a pull request for this features.

Simple condition is 3 lines at max so doesn't worth implementing it as a shortcut. In reality, condition is usually more complicated. There could be permission checks, extra computations etc. etc. Each case is different so simple findOrNew() doesn't make much sense to me.

@yiisoft/core-developers need opinions.

findOneOrCreate in active record class to create new model if condition array is don't have any match.

I am against such change: it creates implicit program workflow, which reduces a readability. The common code for this is simple enough:
$condition = [
    'name' => 'some',
    'categoryId' => 17,
];
if (($model = Item::findOne($condition)) !== null) {
    $model = new Item($conditon);
}

I can see no reason to hide a simple if statement inside some method.
If you wish this so badly you can do it on your own:
class Item extends \yii\db\ActiveRecord
{
    public static function findOneOrCreate($condition)
    {
        if (($model = static::findOne($condition)) !== null) {
            $model = new Item($conditon);
        }
        return $model;
    }
}

You can extract this into a trait and reuse if necessary.

findAllOrFail to raise exception if data not found.

This is already rejected, see #3896


Unexclude com/sun/jdi tests on windows for JDK8

Problem with jdi tests on windows has been fixed by  JDK-8295164 [1]. These tests are part of jdk/tier1 and are being ran as part of testing in GitHub CI on jdk8u-dev since.  Also comment in referenced aqa-tests issue says, that tests can be removed from list, once that JDK issue is fixed.
Fixes https://github.com/adoptium/aqa-tests/issues/2415
[1] https://bugs.openjdk.org/browse/JDK-8295164
[2] https://github.com/adoptium/aqa-tests/issues/2415#issuecomment-1277685526

There are 2 tests, which were also excluded on linux-s390x. I kept them excluded on linux-s390x, as that is separate issue, just updated links to that other issue (windows issue -> s390x issue).

Verify in https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6538


Warning when launching Rancher agents.

I get an error very similar to Issue 33 when starting Rancher Agent containers I get the following error. Nothing seems to fail but I wanted to highlight the error. The message is slightly different from 33 so I created a new issue.
FATA[0082] Error response from daemon: Cannot destroy container 9667b5eaa5e4f0bfcaa649eaf8734c6a46faff9208f4e257cc13b1db215b7ba1: Driver devicemapper failed to remove root filesystem 9667b5eaa5e4f0bfcaa649eaf8734c6a46faff9208f4e257cc13b1db215b7ba1: Device is Busy

My Docker Version:
    docker --version
    Docker version 1.5.0, build a8a31ef

My Docker Info:
docker info
Containers: 3
Images: 45
Storage Driver: devicemapper
 Pool Name: docker-202:1-263382-pool
 Pool Blocksize: 65.54 kB
 Backing Filesystem: extfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 1.327 GB
 Data Space Total: 107.4 GB
 Metadata Space Used: 2.855 MB
 Metadata Space Total: 2.147 GB
 Udev Sync Supported: false
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.82-git (2013-10-04)
Execution Driver: native-0.2
Kernel Version: 3.14.27-25.47.amzn1.x86_64
Operating System: Amazon Linux AMI 2014.09
CPUs: 1
Total Memory: 996.3 MiB
Name: ip-172-30-0-129
ID: JNCJ:4X3R:4LZT:KVTZ:ID4E:ZQUN:BQ66:C2KF:LLWF:WTCV:EA7Z:6PRS

I have the same issue, but using the aufs storage driver. Note it happens both on docker 1.4.1 and 1.5.
$ IFACE=eth0
$ AGENT_IP=$(ifconfig $IFACE | grep "inet addr" | tr " " "\n"| grep addr| cut -d: -f2)
$ SERVER_IP=<IP_ADDRESS>
$ docker run --rm -it --privileged -v /var/run/docker.sock:/var/run/docker.sock -e CATTLE_AGENT_IP=$AGENT_IP rancher/agent http://$SERVER_IP:8080/v1/scripts/3635CE52990768911608:1424721600000:3j74JpoznIP98r7ishstjWaaCU

Rancher State
e8a5c2ec847e89038621bf27bc2d259f4b145f7698482cffa95d9123e56cf265
FATA[0001] Error response from daemon: Cannot destroy container a7caf8381d9e3b7c868355ea74fa032772dea4ef0721cbd19d6713e768728715: Driver aufs failed to remove root filesystem a7caf8381d9e3b7c868355ea74fa032772dea4ef0721cbd19d6713e768728715: rename /var/lib/docker/aufs/mnt/a7caf8381d9e3b7c868355ea74fa032772dea4ef0721cbd19d6713e768728715 /var/lib/docker/aufs/mnt/a7caf8381d9e3b7c868355ea74fa032772dea4ef0721cbd19d6713e768728715-removing: device or resource busy
FATA[0003] Error response from daemon: Cannot destroy container f59c0974786a157d47d9c5e8afd90fb107cc9296e7b72428528ecca53f87736a: Driver aufs failed to remove root filesystem f59c0974786a157d47d9c5e8afd90fb107cc9296e7b72428528ecca53f87736a: rename /var/lib/docker/aufs/mnt/f59c0974786a157d47d9c5e8afd90fb107cc9296e7b72428528ecca53f87736a /var/lib/docker/aufs/mnt/f59c0974786a157d47d9c5e8afd90fb107cc9296e7b72428528ecca53f87736a-removing: device or resource busy

Containers: 4
Images: 75
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Dirs: 103
Execution Driver: native-0.2
Kernel Version: 3.13.0-44-generic
Operating System: Ubuntu 14.04.1 LTS
CPUs: 8
Total Memory: 7.798 GiB
Name: vm-client-esri-001
ID: VQLO:S4ZG:6XUX:ZN4Q:ZHDV:GPTN:YDSB:YFJ4:Z4ZP:YUOZ:DFUS:LR7C

$ docker info
Containers: 2
Images: 35
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 49
Execution Driver: native-0.2
Kernel Version: 3.13.0-35-generic
Operating System: Ubuntu 14.04.1 LTS
CPUs: 8
Total Memory: 7.798 GiB
Name: vm-client-esri-003
ID: Y3AA:I4ME:XOJD:C3ZD:KPYW:IZAI:2R2Q:JZ5H:5DL3:MKAP:ECRH:WNQ7
WARNING: No swap limit support

It is somehow a docker issues that has been mentioned and supposedly solved many times before, but I think Rancher doing the dance with the different Agent containers triggers this in particular. Everything seems to work fine, though. It's just a bit confusing.

By using the command in the UI (per #267), these warnings are eliminated.


Detecting DataCube, CodeList and unsupported inputs

Detect whether a given input json is a DataCube or a CodeList or an unsupported input (i.e. neither a DataCube nor a CodeList).

Things that would be good for you to detect but not support are (i.e. tell people you're pointing it at the wrong file):

table structure jsons (part of the csv-w payload)
qube-config files


Support multi-line logs in the grok processor

Is your feature request related to a problem? Please describe.
The library used for the grok processor (https://github.com/thekrakken/java-grok) only supports single line logs, and as a user I would like to grok my multi-line logs
Describe the solution you'd like
Built-in support for multi-line grokking within the grok processor. This could include an additional configuration option, such as is_multi_line (defaults to false), to indicate that the logs are multi-line. If this option were set to true, then the grok processor would replace all newlines in patterns that are supplied in match or pattern_definitions with a special character (or potentially a unique hash?), such as |, and the grok processor would also replace all newlines in logs with this special character before matching against them.
The thought process behind explicitly stating is_multi_line as a configuration option would be to avoid the unnecessary performance impact that could occur from replacing all the newlines in each log. It is worth noting that single line logs would still work as intended while is_multi_line is set to true, since the replacement of newlines would be a no-op.
One additional complication that arises is that we don't want to modify the user's original logs, so we would need to replace the special characters with newlines again after grokking. This would be an issue if the user's logs also contained the special character, so the easy way to solve this would be to create a copy of the logs before the newlines are replaced, rather than having to track all the replacements that occurred to undo them. Another option to solve this problem would be to reserve the special character, but that is not ideal since there is always the chance that a user's logs would contain this special character, no matter how rare it would be.
The easiest solution would be to just remove newlines from the logs and patterns, but this would not keep things fully consistent since users do want to match based on newlines.
Describe alternatives you've considered (Optional)
Adding a substitute_string processor before the grok processor to replace newlines with a different character, and then including this character in the grok patterns supplied for grok.

Do we need this? See this thread - https://stackoverflow.com/questions/26474873/how-do-i-match-a-newline-in-grok-logstash/26475308#26475308


added inputRef example in text-field doc

I don't get it. What's the point of this pull-request? Shouldn't we aim to keep the examples as simple as possible? I doubt this use case is generatic enough to be added into the documentation, maybe into some StackOverflow issue.

Can you guide me just a little bit as to what it is that i should add in this pr? More explanation for the inputRef prop or something else.. @oliviertassinari

Maybe something like this
inputRef={el=> { this.ref = el }

I am a bit confused ..

Following https://github.com/mui-org/material-ui/issues/11427#issuecomment-389583916, I think that we should apply the following diff:
-Properties applied to the native input element.
+Attributes applied to the native input element.

The property vs attribute is an advanced topic. Most people shouldn't have to worry about, and the one that do, should already know the difference, so I think that no more effort is needed.

Okay understood 👍
This was small 4th PR, any feedback for me so far sir? Where can I be more helpful working on docs or code,  anything that i should improve on?  @oliviertassinari

In the specific context of HTML / Javascript the HTML representation of a DOM element has attributes but when represented as a JavaScript object those attributes appear as object properties.

Sorry for the late delay at my end, I was going to do it! I'll try to be more prompt next time.

@adeelibr Oh sorry, next time :)


Errant Space in your python code

File: templates/duo-proxy-fargate.template.yaml
In line 1672 it appears there is an extra space that casuses the code to fail when running..

Yup, getting this error now as well which seems to be related: [ERROR] Runtime.UserCodeSyntaxError: Syntax error in module 'index': unexpected indent (index.py, line 9) Traceback (most recent call last):   File "/var/task/index.py" Line 9      artifact_bucket = os.environ['DuoBucket']

@cpieper78 Thank you for submitting the fix in PR https://github.com/aws-ia/cfn-ps-duo-mfa/pull/12


Cannot Get Fog of War to Work

This may be the same issue as with https://github.com/npruehs/ue4-rts/issues/158, but I am not 100% sure.
Basically, I can get RTSProject to run fine, but when I try to setup a sample project according to the setup instructions in https://github.com/npruehs/ue4-rts/blob/develop/Documents/Manual/Setup.md and https://github.com/npruehs/ue4-rts/blob/develop/Documents/Manual/Maps.md, all I get is a black screen. I put the two projects side by side and tried scaling up the Floor, vision volume, and camera bounds volumes in my project to match the RTSProject, but that had no effect. I've even tried copying the volumes from the RTSProject into my sample project, but that also had no effect.
I am thinking either that this is because I haven't setup the HUD or because I need to do more to initialize characters, but am not sure.
While editing (not simulating):

During play (using the default "black" Fog of War from the framework):

During play (using the "white" Fog of War from the RTSProject):

Sample project:
https://1drv.ms/u/s!AigXEMxuXyh0gpcF57hjVqdau0xhcg?e=Ys5cHj

Nevermind! Figured it out. I was missing the character setup (specifically, I missed adding a Vision Component to the character) under:
https://github.com/npruehs/ue4-rts/blob/develop/Documents/Manual/Units.md#vision