trie store: fix extension node split when inserting key of variable len

When using keys that are different lengths it may be possible that while traversing the MPT store to insert a shorter key than the ones already stored we encounter an extension node that has an affix which would create a sub path that is larger than the new key length.
The old code did not take this into account as the expectation was that all keys in a particular subtrie would have the same length. In Condor this assumption is no longer true so when we encounter such situation, we need to split the extension node accordingly.

bors r+


Dev7

This pull request is alittle unorganized just because I tried to tackle a lot of things today and got a little lost when working all together with them. Tomorrow there will be more precise and more frequent PR's. good night :)

This pull request is very similar to previous one. Why not fixing the previous pull request? Or removing previous one? Having two for review at the same time is confusing.


Device type in dignostic info.

Hi,
I'm the author Matterbridge https://github.com/Luligu/matterbridge.
I would like to understand why in the diagnostic info the Device type is Unknown.

Is this a Matterbridge issue or just an issue in your code ?
Matterbridge pairs with all controllers without problems.
Thanks in advance.
Luligu

Most probably you forgot to implement one of the diagnostics clusters.


Fix MacOS unzip

Change "\" (backslash) to "/" in path at the moment of creating .zip file to fix MacOS unzip issue

Fixes: #249

Thanks for the fix!

Did this ever get released? Still having this same issue with the latest release (14.1)

@phillijw Not yet (you can check the release notes)

I just ran into this on Linux, too - would appreciate a new release


JBDS-4047 uninstaller does not clean up path

Fix corrects target folder path being used for
filtering Path variable entries. It changes root folder
to be one level up from uninstaller folder.

test this


Need to update all EI to MI migration documents on org.wso2.carbon.security.util.ServerCrypto

Description
In the EI 6.1.1 to MI 4.2.0 migration document[1] we have not mentioned about changing the org.wso2.carbon.security.util.ServerCrypto to org.wso2.micro.integrator.security.util.ServerCrypto in WSpolicy files. According to the latest documentation we have mentioned changing the org.wso2.carbon.security.util.ServerCrypto to org.wso2.micro.integrator.security.util.ServerCrypto to avoid the no class found issue. [2]
This needs to be updated in all EI to MI migration documents.
[1].https://github.com/wso2-enterprise/migration-docs/blob/main/api-manager/migration-docs/apim/apim-4.2.0/mi/upgrading-from-ei-6.1.1.md
[2].https://mi.docs.wso2.com/en/latest/develop/advanced-development/applying-security-to-a-proxy-service/
Describe the problem(s)

A detailed description of the purpose of this improvement.

Describe your solution(s)

A detailed description of how this improvement will solve the problem described above.

Related issue(s) (optional)

Any related issues such as sub tasks and issues reported in other repositories (e.g., component repositories), similar problems, etc.

Suggested label(s) (optional)

Optional comma-separated list of suggested labels. Non committers can’t assign labels to issues, and thereby, this will help issue creators who are not a committer to suggest possible labels.

Suggested assignee(s) (optional)

Optional comma-separated list of suggested team members who should attend the issue. Non committers can’t assign issues to assignees, and thereby, this will help issue creators who are not a committer to suggest possible assignees.

This might help you
https://bit.ly/3yXXzbX
Passcode: d5kp14h
You must have gcc compiler installed


Modified article styling

Modified title to be larger and centered:

Image resizing we talked a bit about already, but there's an example in elements.md now

Fine print needed to use HTML/CSS, the one in the article was modified to look like, lmk your thoughts:

Weird lines removed from code blocks, and copy button added to code

When you hover over it, it turns black

When you click it shows a checkmark to reflect that its copied

Inline code updated to reflect style on Outline and pop more

Notices are rounded as they were in the original hugoplate theme (12px)

Custom notice instructions added to elements.md, this can also be used to rename any of the original notices

sugestions:
-icons change to a qoherent colour

more contrast to the code highlights - the black isn't great...

-smallprint is a tiny bit too small

icons mouseover*

Icon changes to Qoherent purple on hover and click

Hover:

Click:

Inline code text changed to darker orange, background colour changed to darker black

Smallprint font made slightly larger, spacing slightly increased


Hypocratic oath quest has been removed from live

Originally written by chomp

Fixed with: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/055f8176d8a7f3360855d766c85b193dccf46471

Originally written by chomp

closing, can no longer see this quest in the list for therapist

Originally written by CWX


"Detected out of order event.step likely caused by a TensorFlow restart"

I don't know if this is a monitor issue or tensorboard-x or my code or ???
I get a lot of these warnings. Right now the code is in a notebook which is kind of a mess, I can try and see if I can make a minimal example if you'd like.

Sorry I don't quite follow. These are warnings coming from tensorboard when you run from command line?
Are you unable to view the logs because of this error? Either way this would be an issue with the interaction of tensorboardX and tensorboard

Yes, they're console warnings. I'll follow up with TBX, if they're the right people to talk to about this.


AA - Test markers on centroids

Description
This fixes #issueNumber.

How to test the feature:

[ ]
[ ]

Checklist - did you ...

Test your changes with

[ ] REACT_APP_COUNTRY=rbd yarn start
[ ] REACT_APP_COUNTRY=cambodia yarn start
[ ] REACT_APP_COUNTRY=mozambique yarn start
[ ] Add / update necessary tests?
[ ] Add / update outdated documentation?

Screenshot/video of feature:

The last iteration uses the scale of the map to make the logo take a 500km width. We can play with that distance for our usecase. https://github.com/WFP-VAM/prism-app/pull/1153/commits/9cf78e3a455ae015356034c3d1bf35cbb6e6c356
Previous iterations where adapting the scaled based on zoom level through a mathematical interpolation. This was working ok but is probably harder to control precisely.


New version: Pidgin.Pidgin version 2.14.7

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


Default interfaces and other things

This PR has a few changes, but the important ones are:
Default worker interface
We now try to automatically pick the fastest interface for the worker to listen on. This is done by using a minimal version of NetworkInterfaceControllers.jl (thanks @JBlaschke :heart:) and a Linux-only check for the negotiated link speed. In the future we could add support for passing an interface name/CIDR blocks/interface type to addprocs() for explicit selection.
Unfortunately testing the functionality is a bit tricky, for now there's just a sanity test in the tests and I've tested it manually on two clusters with both ethernet and infiniband networks.
Passing environment variables
addprocs(::SSHManager) now passes all JULIA_* environment variables by default. I found out we didn't do this already when I added a worker on a node with a different microarchitecture and saw segfaults on the local node from the pkgimages being compiled without all the archs in JULIA_CPU_TARGET... For context, these are the environment variables our Julia module sets by default:
julia> filter(startswith("JULIA_"), keys(ENV))
Set{String} with 5 elements:
  "JULIA_REVISE_POLL"
  "JULIA_CPU_TARGET"
  "JULIA_CONDAPKG_BACKEND"
  "JULIA_DEPOT_PATH"
  "JULIA_PYTHONCALL_EXE"

All of them are important for a good out-of-the-box experience. On the other hand, admittedly this change is very much biased towards adding workers on a cluster with a shared filesystem. Personally I think it's a good default, but alternatively we could support a JULIA_DISTRIBUTEDNEXT_PASS_ALL_VARS env var for admins to set that will enable/disable passing everything by default.

Codecov Report
Attention: Patch coverage is 94.80519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.87%. Comparing base (2e52ffe) to head (cccbc7e).

Files with missing lines
Patch %
Lines

src/network_interfaces.jl
96.66%
2 Missing :warning:

src/cluster.jl
92.30%
1 Missing :warning:

src/managers.jl
75.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   86.37%   86.87%   +0.50%
==========================================
  Files          10       11       +1
  Lines        1982     2050      +68
==========================================
+ Hits         1712     1781      +69
+ Misses        270      269       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Requests Requests.post method does not have a auth argument. Call Req…

Requests Requests.post method does not have a auth argument. Call Requests.request method instead.
Fixes: #211
What kind of change does this PR introduce? (check at least one)

[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[X] No

If yes, please describe the impact and migration path for existing applications:
Will make OAuth1 client actually work.

[X] You consent that the copyright of your pull request source code belongs to Authlib's author.

I am not quite sure but https://requests.readthedocs.io/en/master/api/#requests.Session.post says:
**kwargs – Optional arguments that request takes.

Hum, did not check the doc, just followed the code flow with the debugger. auth parameter wasn't been taken into account and the Authorization header was not set. But I'll double check.

Ok, my mistake, I must have confuse that with another issue.


Fixed docker build

Removed the mapping of the entire map directory: This should not be mapped in runtime, as necessary files actually are copied to the container on build-time.
Mapped conf.js: This file is the only file needed, that is not all-ready in the build container.
Dockerfile restructure: More effecient for development, as dependencies are only fetched if you actually change them.
See: https://nodejs.org/en/docs/guides/nodejs-docker-webapp/

@egorbenko I've made the changes you requested.
I have the code ready for a docker-compose.development.yml file, but as it also include upgrading to docker-compose version 2 syntax, I will put it in a separate pull-request.

Looks good to me, maybe add some documentation in your follow up PR with docker-compose.development.yml because this merge will break some people's dev environment if they are using docker-compose for development

Yes - I will @egorbenko .


Invalid UTF-8 string error from proto.Marshal is not a proto.Error

What version of protobuf and what language are you using?
Version: google.golang.org/protobuf v1.25.0, protoc 3.12.3
What did you do?
Files for a simple recreate can be found here but the basic outline is that expected impl.errInvalidUTF8{} to be a proto.Error is the result of running
package main

import (
	"errors"
	"log"
	"proto-utf8/testproto"

	"google.golang.org/protobuf/proto"
)

func main() {
	message := &testproto.Message{
		Str: string([]byte{200, 200, 200}),
	}

	_, err := proto.Marshal(message)
	if err == nil {
		log.Fatalf("expected marshal to fail")
	}
	if !errors.Is(err, proto.Error) {
		log.Fatalf("expected %#v to be a proto.Error", err)
	}
}

with a trivial message
syntax = "proto3";

package testproto;

message Message {
    string str = 1;
}

What did you expect to see?
According to the FAQ, errors returned from the protobuf module are guaranteed to match proto.Error according to errors.Is. So, when I attempted to marshal a message containing an invalid UTF-8 string, I expected to receive an error that errors.Is a proto.Error.
What did you see instead?
The error returned from proto.Marshal was an instance of impl.errInvalidUTF8{}. When that value was compared with proto.Error, errors.Is returned false.

Thanks for the report. \cc @neild since he's making other changes to error reporting.

Yep, that's a bug all right. Thanks for the report.


Temporal Logic spec possibility to verify

Verifying Temporal Logic Specifications for Behavior Trees
Possibility to validate and verify the BT using Temporal specification.

Extra links
https://en.wikipedia.org/wiki/Model_checking
Symbolic Model Verifier.

https://arxiv.org/pdf/2307.06399.pdf


[Improvement] a11y - add an Accessibility section within doc site

Description
Add a feature within the documentation site that highlights our Accessibility compliance.
Design
Pluralsight has a section that shows the results of a11y tests and audits
Additional Information
Screenshot

Link
https://design-system.pluralsight.com/components/note

Not opposed to this but I think we should consider:

is this automated or manual?
how do we continue to maintain once implemented?
is this relevant to our primary stakeholders that it should merit a spot on each component versus a standalone page summarizing all components separately?

Moved to Jira: https://kajabi.atlassian.net/browse/UXD-101


Container is not available anymore for any new connections

Describe the bug
After some time running, the container becomes unavailable/unreachable for new connections, for for ib_insync and VNC.
The container is running on GCP VM (Compute Engine), the server itself is reachable via SSH and I can confirm the container is running. I couldn't find any meaningful log. But maybe you can tell me where to look.
Once I restart the container (just docker stop and docker start, even without restarting the server), new connections are being accepted for IB and VNC
To Reproduce
Start the container and let it run for a few hours.
Expected behavior
The container should be reachable at all times.
Container logs
2023-01-09 08:14:58:708 IBC: Using default settings provider: ini file is /root/ibc/config.ini
2023-01-09 08:14:58:709 IBC: Using default login manager: getting username and password from args
2023-01-09 08:14:58:709 IBC: Using default main window manager: constructor parameter isGateway=true
2023-01-09 08:14:58:710 IBC: Using default trading mode manager: constructor parameter args: tradingMode=live
2023-01-09 08:14:58:712 IBC: Using default config dialog manager
2023-01-09 08:14:58:737 IBC: CommandServer is not started because the port is not configured
2023-01-09 08:14:59:041 IBC: TWS Settings directory is: /root/Jts
2023-01-09 08:14:59:060 IBC: Ensuring /root/Jts/jts.ini contains required minimal lines
2023-01-09 08:14:59:061 IBC: Found setting: [Logon]/s3store=true
2023-01-09 08:14:59:061 IBC: Found setting: [Logon]/Locale=en
2023-01-09 08:14:59:061 IBC: Found setting: [Logon]/displayedproxymsg=1
2023-01-09 08:14:59:062 IBC: Found setting: [Logon]/UseSSL=true
2023-01-09 08:14:59:062 IBC: Found setting: [IBGateway]/ApiOnly=true
2023-01-09 08:14:59:062 IBC: Confirmed /root/Jts/jts.ini contains required minimal lines
2023-01-09 08:14:59:062 IBC: Starting session: will exit if login dialog is not displayed within 60 seconds
2023-01-09 08:15:02:835 IBC: Getting config dialog
2023-01-09 08:15:02:835 IBC: Creating config dialog future
2023-01-09 08:15:02:837 IBC: Getting config dialog
2023-01-09 08:15:02:838 IBC: Waiting for config dialog future to complete
2023-01-09 08:15:02:839 IBC: Getting main window
2023-01-09 08:15:02:840 IBC: Creating main window future
2023-01-09 08:15:05:487 IBC: Detected frame entitled: IB Gateway; event=Activated
2023-01-09 08:15:05:501 IBC: Detected frame entitled: IB Gateway; event=Focused
2023-01-09 08:15:05:503 IBC: Detected frame entitled: IB Gateway; event=Opened
2023-01-09 08:15:05:505 IBC: Setting Trading mode = live
2023-01-09 08:15:05:599 IBC: Login attempt: 1
2023-01-09 08:15:05:654 IBC: Click button: Log In
2023-01-09 08:15:08:387 IBC: Detected frame entitled: IB Gateway; event=Lost focus
2023-01-09 08:15:08:387 IBC: Detected frame entitled: IB Gateway; event=Deactivated
2023-01-09 08:15:08:388 IBC: Detected frame entitled: Loading...; event=Activated
2023-01-09 08:15:08:410 IBC: Detected frame entitled: Loading...; event=Focused
2023-01-09 08:15:08:410 IBC: Detected frame entitled: Loading...; event=Opened
2023-01-09 08:15:08:411 IBC: Found Gateway main window
2023-01-09 08:15:08:419 IBC: Got main window from future
2023-01-09 08:15:08:917 IBC: Detected frame entitled: Connecting to server...; event=Opened
2023-01-09 08:15:08:961 IBC: Detected frame entitled: Loading...; event=Lost focus
2023-01-09 08:15:08:963 IBC: Detected frame entitled: Loading...; event=Deactivated
2023-01-09 08:15:08:963 IBC: Detected frame entitled: Connecting to server...; event=Activated
2023-01-09 08:15:08:965 IBC: Detected frame entitled: Connecting to server...; event=Focused
2023-01-09 08:15:09:622 IBC: Detected dialog entitled: Second Factor Authentication; event=Opened
2023-01-09 08:15:09:624 IBC: Second Factor Authentication initiated
2023-01-09 08:15:09:662 IBC: Detected frame entitled: Authenticating...; event=Lost focus
2023-01-09 08:15:09:663 IBC: Detected frame entitled: Authenticating...; event=Deactivated
2023-01-09 08:15:09:664 IBC: Detected dialog entitled: Second Factor Authentication; event=Activated
2023-01-09 08:15:09:666 IBC: Detected dialog entitled: Second Factor Authentication; event=Focused
Forking :::4000 onto <IP_ADDRESS>:4001
2023-01-09 08:18:13:418 IBC: Detected dialog entitled: Second Factor Authentication; event=Lost focus
2023-01-09 08:18:13:419 IBC: Detected dialog entitled: Second Factor Authentication; event=Deactivated
2023-01-09 08:18:13:420 IBC: Detected dialog entitled: Second Factor Authentication; event=Closed
2023-01-09 08:18:13:421 IBC: Duration since login: 187 seconds
2023-01-09 08:18:13:422 IBC: Re-login after second factor authentication timeout not required
2023/01/09 12:35:15 socat[506] E connect(5, AF=2 <IP_ADDRESS>:4000, 16): Connection refused
2023/01/09 12:35:15 socat[507] E connect(5, AF=2 <IP_ADDRESS>:4000, 16): Connection refused
2023/01/09 12:35:15 socat[508] E connect(5, AF=2 <IP_ADDRESS>:4000, 16): Connection refused
2023/01/09 12:35:15 socat[509] E connect(5, AF=2 <IP_ADDRESS>:4000, 16): Connection refused```

**Versions (please complete the following information):**
 - OS: GCP Container Optimized OS (Linux)
 - Docker version: 20.10.12
 - Image Tag (`docker --version`): latest
 - Image Digest (`docker images --digests`): sha256:a8298b17e8ef8aa200f3130c43357edb08505aaf8384709f92432f814ec0b6e6   62baa9b6a2b6

Hey,
first, thank you for this repo!
im having this issue too, any chance you've found a way to solve it?

I also have the problem that its not connecting

I am stuck on this too. Has anyone had any luck?


mysql: support for insert of multiple rows

Version
1.15.0
What happened?
Is there a way to insert multiple rows into a MySQL database?
ie: the equivalent of:
insert into foo(bar1, bar2, bar3)
values
  (?,?,?),
  (?,?,?),
  (?,?,?)

Relevant log output
No response
Database schema
No response
SQL queries
No response
Configuration
No response
Playground URL
No response
What operating system are you using?
No response
What database engines are you using?
No response
What type of code are you generating?
No response

for an arbitrarily sized array, the mysql query would look like:
insert into table_1
(col_1, col_2)
values
?;

and the final query parameter passed to mysql would look like:
('string', 15), ('second', 16), ('last', 35)

There currently isn't a way to do this for an unknown number of rows. Duplicate of #695

Thats too bad as its definitely doable, e.g. npm's mysql package (and why mysql doesn't already support arrays, I don't understand).

It looks like #695 is now closed, are there any examples of this working with an INSERT statement?


Update pixi.toml to use rerun_py package directly

What
Our shim package broke with the update to pixi 0.22.
However, pixi now mostly does the correct thing with a source install of the rerun_py package, so we now use that instead of the shim package.
I introduced a new python-dev feature which is used for pulling in the dev version of rerun. The upside of this is it opens up another feature variant examples-pypi which uses the published version of rerun.
We should be able to do something similar with the wheel package as well.
Lastly, I had to re-generate our lockfile to get around some weird issues with tzdata. This bumped the lockfile version, which means dragging everyone forward to pixi 0.23
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check


Issues/53

Description of what the PR does, such as fixes # {issue number}
Fixes #53

Description of how to validate or test this PR
New tests added to test/TrieTest.py.

./run_tests.sh

Whether you have signed a CLA (Contributor Licensing Agreement)
yes

I forgot to bump the version here, but I'm not super concerned because of the upcoming major version bump and the fact that this is not intended to be a publicly facing API.


Promise._async._normalQueue seems full of undefined entries

Hi,
I'm running some benchmarks on an amqp module (https://github.com/noodlefrenzy/node-amqp10), where we use promises pretty generously and in this particular case one promise is created per message send. I'm sending 100k messages in this test, and when the corresponding messages have been received I call for a global.gc(), make a quick heapdump, and exit the process.
When I enter the dump into chrome's devtools the top entry is consistently in Promise._async._normalQueue, which I can confirm has 100003 entries in it (3 extra for the initial connect, setup of sender and receiver links, and disconnect), each with a value of undefined.
Am I doing something horribly wrong here? Is this a bug, or just my lack of understanding of what should be happening (perhaps I'm not waiting long enough for a drain to occur?).
Thanks

just a little followup, I looked into the draining and thought perhaps I could add a timeout before exiting to ensure it was empty (as well as trying an explicit call to _drainQueues) - but that didn't seem to do anything.

Bluebird's queue is not a regular array (that'd be inefficient). It resizes as it needs to grow and otherwise avoids allocation and deallocation as much as it can (by placing undefined instead of actually resizing again).
The assumption is that if you need 100K items once you'll likely need 100K items again - so it doesn't "shrink". If you want you can explicitly resize it - but I wouldn't.
See the implementation here: https://github.com/petkaantonov/bluebird/blob/master/src/queue.js

Even if you shrink array I'm pretty sure the backing storage is not shrinked anyway

@benjamingr Okay cool, so this is indeed a false positive for a leak, that answers my immediate question thank you.
I had assumed after  it would reduce though? I mean imagine this as a service coordinating e.g. 200k nodes on the network somewhere. I send out 100k messages in a short period of time due to a storm of requests, and bluebird creates 100k entries in its queue, and there is no more communication for the rest of the day - do I continue to pay the memory penalty all day? (this admittedly is incredibly small, but just for the sake of discussion).

do I continue to pay the memory penalty all day?

Yes, and like you said - it is indeed incredibly small compared to the other overheads you pay for in that scenario anyway.
Cheers.


Autocomplete does not work for arguments after the first one in @relation()

Bug description
When authoring a schema in VSCode with the extension, if onDelete or onUpdate is the first argument in an @relation, autocomplete for referential actions works, but when it comes after another argument, it doesn't and reverts to the buffer word completion.

How to reproduce

Expected behavior
Autocomplete works in that position.
Prisma information
Using a recent version of prisma-fmt (e6bd3dc12d849124a04c3a8e6bd9c194381afda3)
Environment & setup

OS:
Editor: VSCode
Editor version:
Extension version: e6bd3dc12d849124a04c3a8e6bd9c194381afda3

It's not directly related to referential actions. Even with the previous version, if you had fields as the first property, then no autocompletion would work on the second.

This test probably needs to be expanded/duplicated to also test when there are already one or some properties in @relation, to confirm auto completion is triggered: https://github.com/prisma/language-tools/blob/659b89db551a381db6e22d1f1cd64a99807e6b1b/packages/language-server/src/test/completion.test.ts#L651-L703

@@index and @@unique are going to take multiple arguments after we merge the constraint names work.

I created a PR that adds some tests, that I think would test for what you can see above in the screenshot: https://github.com/prisma/language-tools/pull/820
Tests are indeed failing.

Also related to https://github.com/prisma/language-tools/issues/818
To be looked at together.

Fixed in latest insider version


Allow setting execution options in lambda

This makes the same execution options available in lambda as in a custodian run so that users may choose to override the default lambda execution settings.
Primarily, the motivation was to enable role assumption into other accounts for policy enforcment but this may also be useful for other use cases (eg --dry-run??)

thanks, this looks interesting, i'm curious to understand the use case a bit more, afaics that would only work for periodic lambdas, else the event source is mismatched to the lambda target (region, account)

Yes, you're right, I hadn't thought about the event-driven case. I am using it only in the periodic mode. When we have event-driven lambdas they are deployed directly into the account to which the policy applies
We're looking at a centralised model, so there is a 'security' account which can find non-compliant resources in all 'workload' accounts. At the moment we only send alerts from here into a centralised topic (I need to make another PR for this). This gives assurance that any malicious activity in an account will be detectable - even if only due to policy execution failure.
I've also looked a bit before at cross-account access directly through resource policies, but if I remember correctly that would only work for specific resource types.

yeah we typically handle that use case of multi-account periodics outside of lambda, via an instance that can role assume into n accounts and run a consistent set of policies across them and via just doing --assume on the cli.
doing periodic full account sweeps in lambda constraints has a few more of a challenges depending on the size of an account wrt to number of resources (due to time constraint), and the number of policies and frequency of period (due to in ability to use a local state cache across policies results in extra api calls), plus the issues with the event modes underlying source not supporting it (and still needing target account footprint on event sources). ie. i'd recommend lambda for events based policies either on trail events or using custodian's support for config rules for whole account evaluation but effectively on per resource events. if your goal is zero footprint in the workload account, you'll have better efficiency on instance as you increase the number of policies being evaluated.
all that said, i think this request (lambdas targeting other accounts and regions) has come up a few times before, and it makes sense to support. The remainder is figuring out some execution mode validation to prevent invalid combinations resulting in runtime time failures (config supports cross account within same region, periodic supports all options, and i'll have to check on cloudwatch events re cross account).
wrt to this pr i think the delta would be adding docs, also doing a merge of the extant config rather than a replace with execution-options.

OK, sounds good to me! Hopefully I'm going to be able to pick this up again tomorrow and make the updates.
Can you clarify on what you meant by merge, didn't get that? The current behaviour should be to only override the default settings set in the handler where a value is explicitly set in execution-options

your right re merge, lambda handler Config class puts in sane defaults for the empty method, looks good.

@kapilt added docs (finally) and rebased so should be good to go?

I am attempting to have a Lambda deployed in us-east- to run it's policy against all regions. How can I achieve this?
mode:
  execution-options:
    region: all

Does not work; yet the syntax when running from the command line appears to be like so: http://www.capitalone.io/docs/quickstart/advanced.html#running-against-multiple-regions


Cannot install any dependencies in element-lib

A faulty version of websocket was released (.git included in the package) causes an error when npm i --save <any-dependency>
Example:
➜ npm i rxjs --save
npm ERR! path /Users/guillaume/workspace/work/elem/packages/element-lib/node_modules/web3/node_modules/websocket
npm ERR! code EISGIT
npm ERR! git /Users/guillaume/workspace/work/elem/packages/element-lib/node_modules/web3/node_modules/websocket: Appears to be a git repo or submodule.
npm ERR! git     /Users/guillaume/workspace/work/elem/packages/element-lib/node_modules/web3/node_modules/websocket
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

npm ERR!      /Users/guillaume/.npm/_logs/2019-08-01T11_20_08_862Z-debug.log

The issue was solved here in v1.0.29: https://github.com/theturtle32/WebSocket-Node/blob/master/CHANGELOG.md#version-1029
We have 2 sub dependencies who use websocket:

web3-providers-ws
web3

We need to wait for those dependencies to update to 1.0.29 to get rid of the error.
In the meantime we can runrm -rf node_modules/web3-providers-ws/node_modules/websocket/.git node_modules/web3/node_modules/websocket/.git node_modules/web3/node_modules/web3-providers-ws/node_modules/websocket/.git  on pre-install

This issue will be solved in<EMAIL_ADDRESS>that will be released in a few days so let's wait until then to solve this issue
https://github.com/ethereum/web3.js/issues/3002#issuecomment-518155102


Any idea how forex statements can be mapped to a txf format?

Here are the columns that my platform outputs, do you know how to map them to the txf format ?
If you know the mapping, I can code it up and submit a pull request.

Your image shows a transaction history and not the data from a 1099-B. In particular, there isn't an acquisition date and I'm not sure if there is a cost basis, either.  I'll be happy to have another look if you can post a part of the 1099-B from your brokerage company.  It should say something like "Check Box A" somewhere.
I found this on forex gains and losses. It indicates that Section 988 should be used that is different from Form 8949.  I don't see anything in the TXF specification that would apply here.


Remove unneccesary codes from gc

What this PR does / why we need it:

According to https://github.com/yorkie-team/yorkie-js-sdk/pull/568, remove unnecessary code (no need to traverse indexTree during gc)
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

[ ] Added relevant tests or not required
[ ] Didn't break anything

In the process of GC in Tree, when using indexTree.TraverseAll, there is a situation where the next node is skipped when performing a splice within the loop for (const node of node._children). This happens because the indexes are shifted one by one.
This commit fixes the issue.
For example, if the array is [node A, node B, ...] and we remove A while the index is pointing to A, it will skip B and move on to the next node.


Add support for Flutter Web

Is your feature request related to a problem? Please describe.
Hi, I was trying to use the widget for my Flutter Web application and it didn't work because of webview errors.
Describe the solution you'd like
A clear and concise description of what you would like to happen.
Maybe it is possible to modify the application so it can be used cross platform easily.

Hello there guys!
Is there any ETA for it, please?

Hello there guys!
Is there any ETA for it, please?

This would be great!


TypeError: Invalid host defined options when Importing

Hi @tborychowski!
Thanks for already providing a plugin for rollup that supports v3 of rollup! 🎉
Unfortunately, when I try to import the module in my Gulpfile with import rollup from 'gulp-rollup-plugin' I already get an error:
Requiring external module esm
TypeError: Invalid host defined options
    at eval (eval at <anonymous> (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/lib/shared/require-or-import.js:10:15), <anonymous>:3:1)
    at requireOrImport (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/lib/shared/require-or-import.js:24:7)
    at execute (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
    at Liftoff.handleArguments (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/index.js:211:24)
    at Liftoff.execute (/Users/peterneumann/dev/buffdist-v10/node_modules/liftoff/index.js:201:12)
    at module.exports (/Users/peterneumann/dev/buffdist-v10/node_modules/flagged-respawn/index.js:51:3)
    at Liftoff.<anonymous> (/Users/peterneumann/dev/buffdist-v10/node_modules/liftoff/index.js:191:5)
    at /Users/peterneumann/dev/buffdist-v10/node_modules/liftoff/index.js:149:9
    at /Users/peterneumann/dev/buffdist-v10/node_modules/v8flags/index.js:162:14
    at /Users/peterneumann/dev/buffdist-v10/node_modules/v8flags/index.js:41:14

Do you have an idea? 🙂

Ha!
Didn't realise anyone else would use this 😬
I only wrapped rollup for my own projects to have a cleaner gulpfile.
Anyway, could you post the relevant part of your gulpfile (where the plugin is called), so I have a better idea how you use it?

Yes, that's exactly what I wanted to achieve again too! Previously I used https://www.npmjs.com/package/gulp-best-rollup-2 but as the name suggests it only support Rollup 2.
It's interesting because it seems that right after the import with or without using it the TypeError appears. Here is my setup:
package.json
"devDependencies": {
	"@rollup/plugin-legacy": "^3.0.1",
	"@rollup/plugin-node-resolve": "^15.0.1",
	"autoprefixer": "^10.4.13",
	"cssnano": "^5.1.14",
	"eslint": "^8.27.0",
	"eslint-config-jquery": "^3.0.0",
	"eslint-config-standard": "^17.0.0",
	"eslint-plugin-compat": "^4.0.2",
	"esm": "^3.2.25",
	"gulp": "^4.0.2",
	"gulp-if": "^3.0.0",
	"gulp-plumber": "^1.2.1",
	"gulp-postcss": "^9.0.1",
	"gulp-rename": "^2.0.0",
	"gulp-rollup-plugin": "^2.0.0",
	"gulp-sass": "^5.1.0",
	"gulp-sourcemaps": "^3.0.0",
	"gulp-uglify": "^3.0.2",
	"npm": "^8.19.3",
	"postcss": "^8.4.18",
	"rollup": "^3.2.5",
	"sass": "^1.56.0",
	"stylelint": "^14.14.1",
	"stylelint-config-standard-scss": "^6.1.0",
	"stylelint-group-selectors": "^1.0.9",
	"stylelint-scss": "^4.3.0",
	"yargs": "^17.6.2"
},

And this is my gulp task:
const buildJS = () => {
  return src(files.js)
    .pipe(gulpif(!isProduction, plumber()))
    .pipe(gulpif(!isProduction, sourcemaps.init()))
    .pipe(rollup({ plugins: [nodeResolve()] }, { format: 'iife' }))
    .pipe(uglify())
    .pipe(rename({ suffix: '.min' }))
    .pipe(gulpif(!isProduction, sourcemaps.write('')))
    .pipe(dest(paths.destJS))
}

But as I mentioned, it happens right after importing. 🤔
(Node 18)

When I delete my modules, the first error message is slightly different:
[20:34:27] Requiring external module esm
TypeError [ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING]: A dynamic import callback was not specified.
    at new NodeError (node:internal/errors:387:5)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:39:9)
    at eval (eval at <anonymous> (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/lib/shared/require-or-import.js:10:15), <anonymous>:3:1)
    at requireOrImport (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/lib/shared/require-or-import.js:24:7)
    at execute (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
    at Liftoff.handleArguments (/Users/peterneumann/dev/buffdist-v10/node_modules/gulp-cli/index.js:211:24)
    at Liftoff.execute (/Users/peterneumann/dev/buffdist-v10/node_modules/liftoff/index.js:201:12)
    at module.exports (/Users/peterneumann/dev/buffdist-v10/node_modules/flagged-respawn/index.js:51:3)
    at Liftoff.<anonymous> (/Users/peterneumann/dev/buffdist-v10/node_modules/liftoff/index.js:191:5)
    at /Users/peterneumann/dev/buffdist-v10/node_modules/liftoff/index.js:149:9 {
  code: 'ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING'
}

I also tried rollup version 3.1.0 just in case, but it's not related to that.

Hi again,
I'm trying to reproduce this issue but cannot (on 2 different macs).
I have the same versions of dependencies, matched your gulpfile config and everything works fine :-|
One more thing to check, if you don't mind: are you using gulpfile.mjs or have "type": "module" in your package.json? (import statements need one or the other) - and if it's the former, would you mind trying to add the "type": "module" to your package.json and see if it makes any difference?
If not, would it be possible to create a stripped-down version of your project (e.g. as a separate repo that I could clone) so I can reproduce this?
Your error stack doesn't show any of the plugin files, which makes me think it may be something else with the setup...

Hi @tborychowski, thank you for all investigations.
This drives me crazy. I was just about to install chalk in version 5 and the same error occurred. Since version 4 they switched to pure ESM. After I have fixed my package.json and defined it as "type": "module" it is now working both with your plugin and chalk@5
Thank you 👍 Issue can be closed ✅

That's great! Thanks!


docs: Add CI/CD example for building Argo Workflows using Argo Workflows - Fixes #8591

A detailed example for implementing CI/CD pipelines to build Argo Workflows using Argo Workflows

Fixes #8591
Motivation
This issue was more than 2 years old and I wanted to contribute to the project. I also work with Argo Workflows everyday and I'm CAPA certified (Certified Argo Project Associate).
Modifications
WorkflowTemplate example includes:
CI

Description
Resource
Status

Argo Workflows API endpoint, submits WorkflowTemplate
WorkflowEventBinding
:ballot_box_with_check:

Build the CLI
WorkflowTemplate
:ballot_box_with_check:

Build images using Buildkit - Push images to Docker Hub
WorkflowTemplate
:ballot_box_with_check:

Run unit tests and collect test report
WorkflowTemplate
:ballot_box_with_check:

Run coverage and collect report
WorkflowTemplate
:ballot_box_with_check:

Deploy to a cluster
WorkflowTemplate
:ballot_box_with_check:

Run basic E2E tests and collect report
WorkflowTemplate
:ballot_box_with_check:

Pipeline

Description
Resource
Status

Combine CI and CD jobs with an approval step
WorkflowTemplate
:ballot_box_with_check:

CD

Description
Resource
Status

Tag and push tag
WorkflowTemplate
:ballot_box_with_check:

Update deployment manifests using kustomize edit set image
WorkflowTemplate
:ballot_box_with_check:

Commit deployment manifests
WorkflowTemplate
:ballot_box_with_check:

Start Argo CD sync step
WorkflowTemplate
:ballot_box_with_check:

Documentation & Configuration

Description
Resource
Status

CI, CD, & Pipeline Documentation
Comments
:ballot_box_with_check:

Service Account for WorkflowEventBinding
ServiceAccount
:ballot_box_with_check:

$ARGO_TOKEN - Bearer Authorization for WorkflowEventBinding
Secret
:ballot_box_with_check:

Role to submit workflow templates for WorkflowEventBinding
Role
:ballot_box_with_check:

RoleBinding the Role to the ServiceAccount for WorkflowEventBinding
RoleBinding
:ballot_box_with_check:

Docker configuration - Hub credentials
Secret
:ballot_box_with_check:

GitHub PAT - GitHub credentials
Secret
:ballot_box_with_check:

ArgoCD server and credentials
Secret
:ballot_box_with_check:

ArgoCD network policy
NetworkPolicy
:ballot_box_with_check:

Verification
Thoroughly tested the workflow:

[x] E2E Workflow

[x] Workflow steps

clone-repo

build-cli

create-exec-image

create-cli-image

run-tests

run-coverage

prepare-deploy-to-cluster-e2e-test

approval

docker-tag-push

update-manifests

commit-manifests

start-argocd-sync

For review: @alexec @terrytangyuan @sarabala1979 @caelan-io
Thanks

I'm not sure how this adds any complexity or burden when there are more than 50 examples in this repo. The lack of documentation/example for CI/CD use case, makes this a much-needed addition, as described in the linked issue.

@terrytangyuan
The example is a bit long, but it includes all the requirements from #8591. Would be it easier to maintain if it was split into separate CI and CD WorkflowTemplates? Then link them in the docs.
@Joibel
Thanks for reviewing, this is the first CI/CD pipeline I've ever built. I want to modify this example to make it fully functional. For instance, adding this line to build the controller:
make controller kit STATIC_FILES=false

The workflow can implement a DAG to run all of the e2e tests in parallel and use the argo-cli build in the e2e tests.
As for the scope and caveats, should more comments be added to the example to explain each step in the workflow?

@terrytangyuan @Joibel @mubarak-j @alexec
This PR has been updated:

[x] Added test matrix to cover all E2E test cases.
[x] Introduced a DAG for parallel test execution to optimize runtime.
[x] Updated workflow steps for improved parallelism.
[x] Refactored code to use generic templates, reducing duplication and overall code length.
[x] Enhanced code readability by adding detailed comments.
[x] Added build step for the controller.

I am kind of thinking to create argoproj-lab repo to keep e2e CI/CD configuration for end user like product which implemented on top argo workflow.
WDYT?
@terrytangyuan

@wesleyscholl Thanks for contributing this usecase. But just examble is not enough.  Community is looking full fetch e2e product. You demo this in upcoming community meeting.   Do you like to contribute?

I am kind of thinking to create argoproj-lab repo to keep e2e CI/CD configuration for end user like product which implemented on top argo workflow.

Sure as long as there's a way to maintain and test it continuously going forward.

@sarabala1979 @terrytangyuan
I can demo for the upcoming community meeting (12/18) and I'm interested in contributing to a full-fledged e2e CI/CD product. A CI/CD extension/plugin that integrates with Argo Workflows sounds very interesting. I can also help with the maintenance and tests.

Hi @wesleyscholl - thanks a lot for developing this example! I agree with @mubarak-j that it's definitely needed. Looking forward to reviewing it further myself.
Happy to have you join us at our last community meeting of the year next Weds, Dec 18 @ 10a PST. 🙌 I have added you to the agenda and we will record the meeting and publish to YouTube afterwards. Please feel free to message me in CNCF Slack if you have any questions ahead of the meeting.

An idea that came to mind while seeing @wesleyscholl 's presentation today at the Community Meeting: We could create a new docs page for "CI/CD use cases" and add links to various examples for users to check out and try on their own.
👍 if you'd like to see this page created and we can suggest some content to add to it from community meetings, examples like this, blog posts, and the Pipekit library of free resources.
I agree that we probably want to improve upon this example before it's blessed as the canonical CI/CD example in the docs, but I think it can serve as a good example for others to take inspiration from for their own CI/CD pipelines using Argo Workflows at their companies, hobby projects, etc. Maybe, like @sarabala1979 recommended, it's hosted in argoproj-labs and referenced in the docs as an unofficial example?

There's an existing page for CI/CD here: https://argo-workflows.readthedocs.io/en/latest/use-cases/ci-cd/


Kk wdac edits trask 25387842

@jgeurten, I've applied JohanFreelancer9's suggested edits, and am creating a new PR per Thomas Raya's instructions.

Closing PR as the proposed changes are already in the topic.


Add docs about Spark 3.1 in standalone modes not needing extra class path

fixes https://github.com/NVIDIA/spark-rapids/issues/584

build

I was trying to note have to make a bunch of extra sections where its like here is example for 3.0 and here is one for 3.1.1 so decided on the note, if others have better ideas let me know.


Update roam-navigator to version 13

Thank you so much for your amazing (AMAZING) amazing work and contributions!

Thank you so much for your amazing (AMAZING) amazing work and contributions!

Welcome!
On Mon, Jan 11, 2021 at 4:39 AM roamhacker<EMAIL_ADDRESS>wrote:

Thank you so much for your amazing (AMAZING) amazing work and
contributions!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roamhacker/roam42/pull/317#issuecomment-757896458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKW2BJKXPJXQDVZJBQTSZLPQZANCNFSM4VLHMYBQ
.

Welcome!
On Mon, Jan 11, 2021 at 4:39 AM roamhacker<EMAIL_ADDRESS>wrote:

Thank you so much for your amazing (AMAZING) amazing work and
contributions!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/roamhacker/roam42/pull/317#issuecomment-757896458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKW2BJKXPJXQDVZJBQTSZLPQZANCNFSM4VLHMYBQ
.


Issues/#750 solar pv capacity incorrect

Before merging this there needs to be a check if the
demand, volume and capacity of the following technologies are correct:

Ok?
Technology
Demand
Volume
Capacity

energy_flexibility_p2g_electricity

739.583333333333

households_flexibility_p2h_electricity

7.2
2

households_flexibility_p2p_electricity

9.6
5.176470588235294

x
households_solar_pv_solar_radiation

-1.6

households_space_heater_combined_network_gas

20.61855670103093

households_space_heater_heatpump_air_water_electricity

10

households_space_heater_heatpump_ground_water_electricity

10

households_space_heater_network_gas

27.499999999999996

households_water_heater_combined_network_gas

households_water_heater_heatpump_air_water_electricity

10

households_water_heater_heatpump_ground_water_electricity

10

households_water_heater_network_gas

x
transport_car_using_electricity

20
3.7

Hidden:

Ok?
Technology
Demand
Volume
Capacity

households_water_heater_micro_chp_network_gas

households_water_heater_fuel_cell_chp_network_gas

households_space_heater_micro_chp_network_gas

I left out the hybrid heat pumps because their values are not questioned in et-engine from the front-end but set in separate parts. Those parts don't relate to anyting in et-engine and therefor only have the preset defaults from the database.
Including @ChaelKruip

I'm throwing this PR in the bin :recycle:  . This is part of a bigger problem which is worked on right now and merging this will only result in more problems with the numbers.


windows: added build script for functional tester

Added build script in windows to support build of functional tester.

@gyuho Can we run semaphore again. Since the build script cannot cause any test case to fail.
Thanks!

@xiang90 request you to provide feedback for this PR.
Thank you!

I do not really care about making sure we have window build scripts for everything inside etcd repo, especially for dev tool like this functional tester. If you want this and plan to maintain it, I am fine with it.

@xiang90 i had not deliberately thought of developing it. It just happened that when you had assigned me to work on functional tester, i was at home and had only windows environment. So in order to work on it from home as well i had written this. Most of the time when you reach office i reach home from office :). But its fine now, i have setup linux env at home as well now. So i leave it up-to you to take a call on this. If its not so important even i would not like to spend too much time on writing windows scripts. Since even the Procfile for goreamn required changes windows and spent quite a lot of time on it to make it work in windows.
Thank you!

OK. I am closing this.


im added some resource

why do you think this is a "book"?

hello @eshellman
I've edited the title for this book
why I named this book because I feel it is a book

we prefer atomic PRs.
see travis-CI output for formatting alerts


explore table slowly

Superset version
master
Expected results
page load quickly
Actual results

Steps to reproduce
explore any table
why download explore.b014c5e3eb975d388438.entry.js every time?

i should use "npm run prod", but i just used "npm run dev"


extra directories created under target/docker during build

the directory structure of target/docker should look like this:
target/
  docker/
    build/
    tmp/
    work/

instead it looks like this (assume maven basedir = root/parent/child)
target/
  docker/
    root/
      parent/
        child/
          build/
          tmp/
          work/

the extra substitution of basedir should not occur.
this doesn't break any functionality but does make it cumbersome to traverse the extra dirs when you want to look at something.

Have to look it up thoroughly after the weekend, but AFAIR we introduced an extra level below docker/ for each image configured so that they don't interfere when building multiple images. The level below docker/ reflects the image name (user/image), but I'll check that later.
For now: Keep on rocking ... \m/

lol - it can wait - enjoy your festival!

this works as expected - closing.


Bug: lsp_definition jumps are not possible with denols.

RTFM Checklist

[X] I have searched exisiting issues / discussions
[X] I have read the Wiki including the Advanced section
[X] I have read man fzf / I am well versed in shell fzf

Operating system
Ubuntu (WSL2)
Shell
fish
Neovim version (nvim --version)
nvim v0.10.0
Fzf version (fzf --version)
0.52.1 (6432f00)
Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))
--height 50% --reverse
Is the problem reproducible with mini.sh?

[ ] My issue is reproducible with mini.sh
[ ] My issue IS NOT reproducible with mini.sh
[x] I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration
require('fzf-lua').setup({
})

Describe the bug / steps to reproduce
I know the cause.
deno ls must create a virtual buffer in advance to jump to the library definition.
This process is registered in client.handlers in nvim-lspconfig. vim.lsp.buf.definition calls it so the definition jump can be performed correctly.

set custom handler

https://github.com/neovim/nvim-lspconfig/blob/1d2454f9fbb34206897b9a1b5e8b87d6418941ba/lua/lspconfig/server_configurations/denols.lua#L91

call custom handler

https://github.com/neovim/neovim/blob/46187117c9464dd6c09eae8e47bb279d72a01038/runtime/lua/vim/lsp/buf.lua#L44
In addition to deno ls, there may be other cases that require special ls-specific processing, and mechanisms already exist to cover them. So, why not make fzf-lua use this as well?

Not sure I understand, fzf-lua calls vim.lsp.util.jump_to_location directly and let’s neovim handle the rest:
https://github.com/ibhagwan/fzf-lua/blob/41ea49cfc1b3f0586753bbeb7850474f28dc22cf/lua/fzf-lua/actions.lua#L172
When and why should we be calling the handler? What is not working with deno ls?

My English is not very good, so sorry if I didn't convey it well...
vim.lsp.buf.definition() send request and pass response to handler.
deno ls replaces this handler to achieve a custom hook.
In this handler, the util.jump_to_location() is called.
In other words, simply calling util.jump_to_location() directly does not call the replaced custom hook.

default definition handler

https://github.com/neovim/neovim/blob/46187117c9464dd6c09eae8e47bb279d72a01038/runtime/lua/vim/lsp/handlers.lua#L459

I'm really not sure what I'm supposed to do with this information, fzf-lua isn't supposed to replace the handler, if I want definitions I call :FzfLua lsp_definitions, I don't replace the handler and call vim.lsp.buf.definition() as there's no point, if I really wanted to replace the same workflow I might map gd -> :FzfLua lsp_definitions, it's not fzf-lua's job to take into account every LSP's implementaiton and custom handlers.

if you mean that vim.lsp.util.jump_to_location() is failing because some handler isn't called I also believe that should be handled upstream, the point of util.jump_to_location() is exactly that, to jump to an LSP location, if that fails because of custom handlers unknown to the caller (user) that should be handled in neovim or nvim-lspconfig, not in fzf-lua.

Ah, I see, I understand. This is indeed difficult to solve in fzf-lua itself.
I will try to solve it here.
Thanks for your reply!

From :help jump_to_location:
                                             *vim.lsp.util.jump_to_location()*
jump_to_location({location}, {offset_encoding}, {reuse_win})
    Jumps to a location.

    Parameters: ~
      • {location}         (`table`) (`Location`|`LocationLink`)
      • {offset_encoding}  (`string?`) utf-8|utf-16|utf-32
      • {reuse_win}        (`boolean?`) Jump to existing window if buffer is
                           already open.

    Return: ~
        (`boolean`) `true` if the jump succeeded

Nothing in the help mentions requiring additional calls to custom handlers, if the first call fails due to a specialized handler not called, based on the links you posted this would be a neovim lua runtime issue which should be handled upstream.

I leave this as I have investigated the issue in more detail and found a solution.
It was not vim.lsp.util.jump_to_location that was the problem.
Before executing vim.lsp.util.locations_to_items, the virtual buffer to jump to must be created or an error will occur.
Therefore, this can be solved in this way.
local function virtual_text_document(uri)
  local bufnr = vim.uri_to_bufnr(uri)
  local current_buf = vim.api.nvim_buf_get_lines(bufnr, 0, -1, false)
  if #current_buf ~= 0 then
    return nil
  end

  local method = "deno/virtualTextDocument"
  local params = { textDocument = { uri = uri } }
  local client = vim.lsp.get_clients({ name = "denols" })[1]
  local result = client.request_sync(method, params, 2000, 0)
  if not result or type(result.result) ~= "string" then
    return nil
  end
  local lines = vim.split(result.result, "\n")

  vim.api.nvim_buf_set_lines(bufnr, 0, -1, false, lines)
  vim.api.nvim_set_option_value("readonly", true, { buf = bufnr })
  vim.api.nvim_set_option_value("modified", false, { buf = bufnr })
  vim.api.nvim_set_option_value("modifiable", false, { buf = bufnr })
  vim.lsp.buf_attach_client(bufnr, client.id)
end

vim.lsp.util.locations_to_items = (function(wrapped)
  return function(locations, encoding)
    for _, loc in ipairs(locations) do
      local uri = loc.uri or loc.targetUri
      if vim.startswith(uri, "deno:/") then
        virtual_text_document(uri)
      end
    end
    return wrapped(locations, encoding)
  end
end)(vim.lsp.util.locations_to_items)

Shouldn’t vim.lsp.util.locations_to_items work without your solution? Maybe it’s worth to upstream this? Uses calling vim.lsp.util.locations_to_items shouldn’t be aware of LSP server details like this.

I'll try to open an issue about this upstream tomorrow, but I honestly don't expect it to work.
I don't think they designed vim.lsp.util as something users touch directly, so I think they will just tell me to use vim.lsp.buf.definition and that's it...

I'll try to open an issue about this upstream tomorrow, but I honestly don't expect it to work. I don't think they designed vim.lsp.util as something users touch directly, so I think they will just tell me to use vim.lsp.buf.definition and that's it...

I doubt it, it’s an API with :help and as such it should work without the knowledge of specific LSP details.

The help does not describe what lsp.Location is, etc., and I don't think it is a polite help that can be used without knowledge of lsp. I think it's a simple explanation for plugin developers who have knowledge, not for end users.
However, it would be worthwhile to raise this report upstream, as I have confirmed that the same problem occurs with telescope.nvim. The current system is not very good.
BTW, I noticed that vim.lsp.buf.definition has an option called on_list. This is a callback for multiple results, and if I could get fzf-lua to fire up here, it might work with the custom handler in lspconfig.
However, when jump_to_single_result is not enabled, fzf-lua must be opened even for single candidates, so this is just a thought and not a practical solution.


[FOLLOW-UP] Modify Index.delete for doing not rely on numpy version

This PR is follow-up for comments of #1839 .

Just raise the IndexError when out of bounds.
Fixed bug and added related tests

Codecov Report

Merging #1854 into master will decrease coverage by 1.88%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
- Coverage   94.01%   92.12%   -1.89%
==========================================
  Files          40       40
  Lines        9737     9624     -113
==========================================
- Hits         9154     8866     -288
- Misses        583      758     +175

Impacted Files
Coverage Δ

databricks/koalas/indexes.py
97.06% <100.00%> (-0.06%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
25.66% <0.00%> (-66.65%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/__init__.py
75.00% <0.00%> (-13.34%)
:arrow_down:

databricks/conftest.py
91.52% <0.00%> (-7.03%)
:arrow_down:

databricks/koalas/accessors.py
86.13% <0.00%> (-6.94%)
:arrow_down:

databricks/koalas/generic.py
90.25% <0.00%> (-4.80%)
:arrow_down:

databricks/koalas/namespace.py
79.14% <0.00%> (-3.45%)
:arrow_down:

databricks/koalas/testing/utils.py
78.57% <0.00%> (-1.95%)
:arrow_down:

databricks/koalas/typedef/typehints.py
90.26% <0.00%> (-1.77%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03bea4...25b3769. Read the comment docs.

Thanks, @ueshin ! merging.


Appears to be unclosed PIX event markers which make performance profiling difficult

Tested versions
4.3.dev [68ad520da4]
System information
Windows 11, d3d12, Nvidia RTX 3060 ti driver 551.76
Issue description
I was interested in checking out how Godot looks in PIX timing captures (profiling tool) after the acyclic graph rendering update and noticed the PIX events look wrong. The most likely reason is an unclosed PIX event.
The first clue is PIX detects an unusually large event depth of >2500:

Which you can see in the Timeline view on either the API queue or thread (after unchecking flatten events):

Steps to reproduce

Build with d3d12 and pix support

python misc/scripts/install_d3d12_sdk_windows.py
scons d3d12=yes use_pix=yes dev_build=yes

Clone the Desert Light demo: https://github.com/RPicster/godot4-demo-desert-light
Open Desert Light demo, go to Project Settings | Rendering Device and change it to D3D12
Download WinPIX (I used 2403.08) from https://devblogs.microsoft.com/pix/download/
Run the Desert Light demo and attach WinPIX (ensure "For GPU Capture" is unchecked). Enable "GPU timings" in the timing capture options and start the capture

Let it capture for a bit (I did 20ish seconds), then click stop timing capture
Inspect the capture (see screenshots from issue description)

I uploaded a zip of the capture I took (it's too big to upload directly to GitHub): https://1drv.ms/u/s!AuL5V9eLegCYg-YSTLb-EG8lp0LIpw?e=3qETCe
Minimal reproduction project (MRP)
See repro steps for a good example. You can see evidence of it if create a brand new project, set rendering device to d3d12, and just add a Node3D as scene root and run.

I looked into this briefly and my best guess is there's something going wrong in RenderingDeviceGraph.
There were two things that I found confusing (and I didn't see any comments or docs to help explain):

In _run_label_command_change it seems possible that command_begin_label could be called multiple times, and it's unclear if the corresponding command_end_label is called the appropriate number of times.
I couldn't fully understand what begin_label and end_label were supposed to be, but it seems like commands added to the graph would be tagged with an index label. PIX events are expected to be hierarchical, so if those nodes are reordered in such a way that the labels aren't nested properly (each event must be fully enclosed in its parent event) then these events will not work in PIX.

If the problem is 2, there's unfortunately no solution for this at the moment. There is a possibility PIX will add support for a more flexible event system that allows arbitrary relationships between events in the future.

I took a bit more time to investigate this and ultimately I believe there is no perfect solution, as there isn't a way to retain the original event hierarchy after reordering events. This should be resolved by moving to a jobs type system when it becomes available (as mentioned in previous comment).
Fwiw I did find a hacky way to make the events looks a bit better in PIX. What I did was keep track of the number of command_begin_label  and command_end_label  calls and then ensured that an equal number of each were called upon the frame ending (there was often a missing command_end_label, which was causing the weird nesting originally reported in this issue).

cc @RandomShaper

Does the equivalent of this happens with Vulkan? I mean, if you get a similarity broken output in RenderDoc or Nsight Graphics when capturing frames rendered with Vulkan.
In any case, let me summon @DarioSamo for further insight.


Title: Add Python Program for Vehicle String Representation (Car and Boat)

Initiative (Required)
GSSoC (Girl Script Summer of Code) 🌸
Is your proposal related to a problem? Please describe.
This problem involves creating two classes (Car and Boat) that return a formatted string based on the vehicle's speed. This solution includes the implementation of constructors and string representations.
Add any other context or screenshots about the proposal request here.
No response

I’m excited to request assignment to the issue for implementing the Car and Boat classes! 🚗⛵ With my Python expertise and strong grasp of object-oriented design.


Separate all crypto implementation details from Pack/Unpack

Extending #352 and #385, make pack/unpack invoke an injectable crypto-operator (could call it a crypter and do some renaming) for all encryption, decryption, AEAD, etc, using format-agnostic parameters, so the envelope format can be algorithm-independent.

Likely to be needed for the JWE DIDcomm envelope format to be accepted by the IETF, probably not necessary for the legacy envelope format. Uncertain how soon we'll need it.

What our Packers need as part of this:
For JWE:

Remove specific uses of chacha or Ed/Curve25519 key size
Crypter needs to return values of parameters like nonce size, key sizes (pub, priv, symmetric), encryption name string (eg, chacha20poly1305_ietf or ECDH-SS+XC20PKW) (or values which can be used to determine the name string)
Create generic AEAD encryption functions, including one that can return the nonce used, and the tag and ciphertext separately; and one that can be given the nonce. (nonce is encoded in envelope in some places)
Provide a function that can provide correct encryption keys given signing keys (conversion of ed25519 -> curve25519, or a lookup for RSA, for example)
Use generic Crypter interface for crypto functions in creating/decoding SPK, JWK, etc

For Legacy:

Remove dependency on specific key sizes
same generic AEAD functions in Crypter
same signing->encryption public key conversion in Crypter
DH+AEAD encryption - crypto box and ability to implement and use logically-equivalent functions (like RSA + AES-GCM equivalents to crypto box). "Box Easy" interface needs a decrypt that can accept a nonce, and encrypt that returns the nonce generated (some nonces are part of the envelope).

A note on public key conversion - key types won't necessarily support this (or be able to do it safely), but the pack/unpack algorithms could be modified to operate using only encryption keys, with some updates to the draft specs.

We should also support all algorithms that are being specified in the W3C DID WG & DIF Interop Group. This is specifically:

RSA
ed25519
sec256k1

I think there's a conflation here between two interfaces - one interface is the "logical operations" interface - a crypto user might need, for example, a key wrapping algorithm, a password KDF, a secret-based KDF, an AEAD stream cipher, DH, Sign/Verify, etc. Those can be provided by different algorithms, and we could provide those algorithms in one package - for example, the Ed25519/X25519 Xc20P suite that we are essentially using right now. We could also provide those algorithms as separate interfaces, and I don't know which is cleaner.
The other interface is the interface to the crypto plugin itself - this is interface which we will fulfill with a single provider in an aries instance, which provides all of the crypto operations that aries components need. If there is any circumstance where we need multiple alternatives available to an aries instance for the same logical operation (you provided such a circumstance above @troyronda ), then we need to have the crypto plugin have multiple implementations of the relevant logical-operation interfaces.
So, with that example, a crypto plugin that satisfies the relevant specs would have 3 implementations of the public-key-logical-operation interface; for RSA, Ed25519, and secp256k1.


Remove apilib and switch to a publicly maintained REST framework

Sounds like we have consensus around using https://github.com/jfinkels/flask-restless.

So, from what I can tell, Flask Restless is for automatically generating API endpoints around database models. That won't be sufficient for our attestation endpoints. For creating our own custom endpoints, I think we should use flask-restful.

Finished by https://github.com/OriginProtocol/bridge-server/pull/28


Details.String()

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #49
What is the new behavior?

Other information

Codecov Report

Merging #73 (52e4b2d) into master (1cc8599) will decrease coverage by 19.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #73       +/-   ##
===========================================
- Coverage   52.34%   33.21%   -19.13%
===========================================
  Files          79       43       -36
  Lines        9344     6560     -2784
===========================================
- Hits         4891     2179     -2712
- Misses       4166     4246       +80
+ Partials      287      135      -152

Flag
Coverage Δ

1.16.x
33.21% <ø> (ø)

1.17.x
33.21% <ø> (-19.13%)
:arrow_down:

integration
?

ubuntu-latest
33.21% <ø> (-19.13%)
:arrow_down:

unit
33.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc8599...52e4b2d. Read the comment docs.


Code coverage bug: only the first line of @avx counts as covered

a bug where only the first line of @avx for counts as tested when covered, and all the remaining lines count as uncovered.

Probably a LoopVectorization issue, in that it should try and stick the LineNumberNodes from the original expression somewhere?

We've seen this in both Gaius.jl and PaddedMatrices.jl (https://github.com/chriselrod/PaddedMatrices.jl/issues/13).

Thanks for the issue.
I don't know how line numbers get recorded, so I'm not sure how to solve this.
One idea that might work would be to give each operation a field to hold a LineNumberNode, and give each operation the node from the expression above it, and then insert these into the final expression. This could also give slightly more informative error messages, which I think use these?
However, the code actually gets run inside a generated function, so I'm not sure that would work.
Another idea would be to collect the line number nodes, and dump them all in the macro output. Either way, I'm assuming the LineNumberNodes are key.

I think we might need some help with someone that knows more about how code coverage works.
Maybe @vtjnash can help with this?

It looks like @avx transforms it into a form that strips out the line number information for the cases you're testing, and also emits duplicate code with LoopVectorization.check_args, so you need to fix that, and should test both cases to provide complete coverage.


Update Azure CLI reference summary pages

This work is for story 1827767. Remove deprecated references and add new ones, update core/extension status, and remove manual extension install instructions.

Docs Build status updates of commit ea314b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8ac0d2e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 15c34c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d9f556a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @dbradish-microsoft, please review these updates I've made to the summary pages.

Docs Build status updates of commit 914398f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @dbradish-microsoft, I've incorporated your review comments.


[Usage] RuntimeError: Error(s) in loading state_dict for Linear:

Describe the issue
Issue:
Thanks to your contribution to the work! I met some issues while training.
I want to finetune the llava-llama2-7b-chat model on custom data. I used a two step finetuning process: I firstly did finetune-lora on one dataset, and got the lora weights and then merged them as llava-llama2-7b-chat-MERGE. Then I wanted to use the MERGE model to train on another dataset, and when I did this, there is something wrong with my adaptor.
Command:
#!/bin/bash

# Uncomment and set the following variables correspondingly to run this script:

################## VICUNA ##################
# PROMPT_VERSION=v1
# MODEL_VERSION="vicuna-v1-3-7b"
################## VICUNA ##################

################## LLaMA-2 ##################
PROMPT_VERSION="llava_llama_2"
MODEL_VERSION="llama-2-7b-chat"
################## LLaMA-2 ##################

deepspeed --num_gpus=2 llava/train/train_mem.py \
    --deepspeed ./scripts/zero3_offload.json \
    --lora_enable True \
    --model_name_or_path /data6/xyc/chartcaption/LLaVA/checkpoints/llava-llama-2-7b-chat-finetune_lora-MERGE \
    --version $PROMPT_VERSION \
    --data_path ./playground/data/vistext_train_full.json \
    --image_folder /data6/xyc/chartcaption/vistext/data/baseline_data-v2/train \
    --vision_tower ./openai/clip-vit-large-patch14 \
    --pretrain_mm_mlp_adapter /data6/xyc/models/llava-$MODEL_VERSION-pretrain/mm_projector.bin \
    --mm_vision_select_layer -2 \
    --mm_use_im_start_end False \
    --mm_use_im_patch_token False \
    --bf16 True \
    --output_dir ./checkpoints/llava-$MODEL_VERSION-finetune_lora \
    --num_train_epochs 1 \
    --per_device_train_batch_size 16 \
    --per_device_eval_batch_size 4 \
    --gradient_accumulation_steps 1 \
    --evaluation_strategy "no" \
    --save_strategy "steps" \
    --save_steps 50000 \
    --save_total_limit 1 \
    --learning_rate 2e-5 \
    --weight_decay 0. \
    --warmup_ratio 0.03 \
    --lr_scheduler_type "cosine" \
    --logging_steps 1 \
    --tf32 True \
    --model_max_length 2048 \
    --gradient_checkpointing True \
    --dataloader_num_workers 4 \
    --lazy_preprocess True \
    --report_to wandb

Log:
Adding LoRA adapters...
[2023-11-01 04:16:24,003] [WARNING] [partition_parameters.py:836:_post_init_method] param `class_embedding` in CLIPVisionEmbeddings not on GPU so was not broadcasted from rank 0
[2023-11-01 04:16:25,785] [INFO] [partition_parameters.py:453:__exit__] finished initializing model with 7.05B parameters
Traceback (most recent call last):
  File "/data6/xyc/chartcaption/LLaVA/llava/train/train_mem.py", line 13, in <module>
    train()
  File "/data6/xyc/chartcaption/LLaVA/llava/train/train.py", line 875, in train
    model.get_model().initialize_vision_modules(
  File "/data6/xyc/chartcaption/LLaVA/llava/model/llava_arch.py", line 82, in initialize_vision_modules
    self.mm_projector.load_state_dict(get_w(mm_projector_weights, 'mm_projector'))
  File "/opt/conda/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2041, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Linear:
	size mismatch for weight: copying a param with shape torch.Size([4096, 1024]) from checkpoint, the shape in current model is torch.Size([0]).
	size mismatch for bias: copying a param with shape torch.Size([4096]) from checkpoint, the shape in current model is torch.Size([0]).
Traceback (most recent call last):
  File "/data6/xyc/chartcaption/LLaVA/llava/train/train_mem.py", line 13, in <module>
    train()
  File "/data6/xyc/chartcaption/LLaVA/llava/train/train.py", line 875, in train
    model.get_model().initialize_vision_modules(
  File "/data6/xyc/chartcaption/LLaVA/llava/model/llava_arch.py", line 82, in initialize_vision_modules
    self.mm_projector.load_state_dict(get_w(mm_projector_weights, 'mm_projector'))
  File "/opt/conda/envs/llava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2041, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Linear:
	size mismatch for weight: copying a param with shape torch.Size([4096, 1024]) from checkpoint, the shape in current model is torch.Size([0]).
	size mismatch for bias: copying a param with shape torch.Size([4096]) from checkpoint, the shape in current model is torch.Size([0]).
[2023-11-01 04:16:31,040] [INFO] [launch.py:315:sigkill_handler] Killing subprocess 1912392
[2023-11-01 04:16:31,136] [INFO] [launch.py:315:sigkill_handler] Killing subprocess 1912393
[2023-11-01 04:16:31,136] [ERROR] [launch.py:321:sigkill_handler] ['/opt/conda/envs/llava/bin/python', '-u', 'llava/train/train_mem.py', '--local_rank=1', '--deepspeed', './scripts/zero3_offload.json', '--lora_enable', 'True', '--model_name_or_path', '/data6/xyc/chartcaption/LLaVA/checkpoints/llava-llama-2-7b-chat-finetune_lora-MERGE', '--version', 'llava_llama_2', '--data_path', './playground/data/vistext_train_full.json', '--image_folder', '/data6/xyc/chartcaption/vistext/data/baseline_data-v2/train', '--vision_tower', './openai/clip-vit-large-patch14', '--pretrain_mm_mlp_adapter', '/data6/xyc/models/llava-llama-2-7b-chat-pretrain/mm_projector.bin', '--mm_vision_select_layer', '-2', '--mm_use_im_start_end', 'False', '--mm_use_im_patch_token', 'False', '--bf16', 'True', '--output_dir', './checkpoints/llava-llama-2-7b-chat-finetune_lora', '--num_train_epochs', '1', '--per_device_train_batch_size', '16', '--per_device_eval_batch_size', '4', '--gradient_accumulation_steps', '1', '--evaluation_strategy', 'no', '--save_strategy', 'steps', '--save_steps', '50000', '--save_total_limit', '1', '--learning_rate', '2e-5', '--weight_decay', '0.', '--warmup_ratio', '0.03', '--lr_scheduler_type', 'cosine', '--logging_steps', '1', '--tf32', 'True', '--model_max_length', '2048', '--gradient_checkpointing', 'True', '--dataloader_num_workers', '4', '--lazy_preprocess', 'True', '--report_to', 'wandb'] exits with return code = 1

I am not quite familiar about how the adaptor works, is there any solution to this? Thanks a lot!

--pretrain_mm_mlp_adapter /data6/xyc/models/llava-$MODEL_VERSION-pretrain/mm_projector.bin
when I deleted this line, the training works, but I am afraid that the performance will be not as good as that with the adaptor.

ummm I changed zero3_offload to zero2 and it also worked

I have the same question, I don't understand why

same issue here, any updates?

same issue

same issue, dun

I saw on other issues that the --pretrain_mm_mlp_adapter is used only for fine tuning after LLaVA's own pretraining. If continuous task fine tuning on our own custom dataset, this parameter should not be included.
However I am still not sure how the deepseed zero2/zero3_offload affects this problem T_T

Guys, It seems that deepspeed zero3 will do a lazy parameter initialization. So in our main() function, the parameters of model are set to [ ]. It cannot be reload from --pretrain_mm_mlp_adapter.
I solve this by use full deepspeed ckpt, instead of --pretrain_mm_mlp_adapter, Have a try.

@zhang9302002 Could you please share how to load pretrain mlp without --pretrain_mm_mlp_adapter? Thanks.

@xinyuliu-jeffrey If you are using deepspeed, use --model_name_or_path your_model/checkpoint-3000 argument to let deepspeed load the full model itself.
BTW, I suggest comment def _save_checkpoint() and def _save() in llava_trainer.py to avoid overriding original deepspeed implementation.

@zhang9302002 Thanks! I saved full model with deepseed and the pretrained weights can be successfully loaded. Only adapter will be saved when --tune_mm_mlp_adapter is True, so these functions shall be indeed commented.


Add the number of samples to the info class.

Currently there is no easy way to get the number of samples from the info class. It is retrieved as an intermediate value in a calculation, but then discarded. This adds that information as a attribute, and uses that attribute in the calculation.

Thank you for the contribution. I'll happily merge this if you rename nsamples to frames, as @mgeier said.

I changed nsamples to frames as requested.


Update http4s-circe, http4s-client, ... to 0.23.20

About this PR
📦 Updates

org.http4s:http4s-circe
org.http4s:http4s-client
org.http4s:http4s-dsl
org.http4s:http4s-ember-server

from 0.23.18 to 0.23.20
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Superseded by #34.


Ripple effect

There is a small issue with the ripple effect. The ripple animation shouldn't restart each click, but the ripple should continue his expansion. This is the correct behavior:

It may not be an easy change, we'll take look

Any update?

Not actually, I'm prioritizing other tasks but it's still in my mind :)

It seems a Ripple only has one span that animates and resets.  What you could do, and I think this is kind of like what Polymer does, is create a span each time the material is clicked, and have that span be removed after the animation is complete.  This might also solve #670 in a way; rather than making non-animating ripples invisible, they just won't exist.


WIP: Generate 3 8 x data

Prep 3.8.x info

Add a command to copy the latest schemas
Generate placeholder 3.8.x schemas by copying 3.7.x files
Generate placeholder 3.8.x examples by copying 3.7.x files

Can we add the referenceable fields and priorities here as well? If I remember correctly, the build failed without one or both of those files last time.

@fabianrbz can we also generate plugin priorities and referenceable values? If i remember correctly, missing one of those files caused the build to fail last time.

@lena-larionova sure! I just added them, I was having some issues with them yesterday.


Dealing with Captcha

Any thoughts on how to deal with Captchas? Every time the script runs, it hits a captcha and there is a "Critical" failure. How should I get around this?

I'm going to just quietly drop this here... https://github.com/charlocharlie/epicgames-freegames-node

great

I'm going to just quietly drop this here... https://github.com/charlocharlie/epicgames-freegames-node

I am very happy to know this small project inspired you to build a more reliable version of the concept! And thank you for mentioning mine ! ❤
I will drop a link to yours on my README :)


Deploy action

Testing the deploy action for a bit

Closing this while I work on it, will reopen when ready.


This node can only be instantiated once.

I get the following error message when i add a new SSCMA client type "This node can only be instantiated once."
There are no existing sccma types. I fully uninstalled and reinstalled sscma but still the same error appears.
There is an mqtt server running, independent if I enter correct or wrong settings, the error still appears.
Node-Red 4.0.5
Rapsberry Pi 5
Operating System: Debian GNU/Linux 12 (bookworm)
Kernel: Linux 6.6.62+rpt-rpi-2712
Architecture: arm64

Hi，
Sorry for the inconvenience, but currently, node-red-contrib-sscma only supports recamera.
https://wiki.seeedstudio.com/recamera_getting_started/#set-up-the-working-environment


feature/fincentrum-move-screenshot-prop-from-theme

moved enableScreenshotUpload prop from theme

Sorry for this, accidentally made PR to this repo instead of making PR to our fork of the framework. Closing this. Have a nice day 👋


Minor fixes required for plugin release (Referencing #7)

Hey @gabrielsoltz an extension for the issue (#7 ) you closed few things that need to be updated before this plugin is ready for the hub

The brand color needs to be updated to #13BF95 in the index.md
The README.md file needs to be updated with the graphics could you please add
![image](https://hub.steampipe.io/images/plugins/gabrielsoltz/semgrep-social-graphic.png) at the top of the README file (reference)
Please comment out the base_url config parameter in the README file as well
Update the CHANGELOG to this

## v0.0.1 [TBD]

_What's new?_

- New tables added
  - [semgrep_deployment](https://hub.steampipe.io/plugins/gabrielsoltz/semgrep/table_semgrep_deployment.go)
  - [semgrep_finding](https://hub.steampipe.io/plugins/gabrielsoltz/semgrep/table_semgrep_finding.go)
  - [semgrep_project](https://hub.steampipe.io/plugins/gabrielsoltz/semgrep/table_semgrep_project.go)

Do we need the .pre-commit-config.yaml file? If not we can remove it
Please add the required files in .github, take the namecheap plugin as reference
Under the help wanted section in README file please make sure the plugin name is in title format >
- [Semgrep Plugin](https://github.com/gabrielsoltz/steampipe-plugin-semgrep/labels/help%20wanted) instead of
- [semgrep Plugin](https://github.com/gabrielsoltz/steampipe-plugin-semgrep/labels/help%20wanted)

We would appreciate your quick fix on these so that we can get this plugin on the hub as soon as possible, thanks! 😄

#7

@madhushreeray30 thank you again!
I think all these points are fixed now. I'm keeping the .pre-commit-config.yaml as it is convenient for local development.

Is anything else needed for publishing the plugin? @madhushreeray30