Support credit card payments through Adyen's API

Currently we only support payments that go through Adyen's Hosted Payment Pages (HPP). This change adds a new payment method for credit cards and everything required to support processing credit card payments directly through Adyen's API, using their client side encryption (CSE) library.
Credit card payments through Adyen work similar to HPP payments in that it's an asynchronous API. We make a payment request, Adyen tells us whether it was received successfully or not, and at some point in the future we get a notification if it succeeded or not. Most of the handling of notifications uses the existing HPP code with minimal modifications. We can capture, cancel, refund, and partially refund payments through Solidus and all operations will be handled like HPP, where the payment state is put into processing on a request and transitioned after we receive a notification from Adyen.
One of the challenges with Adyen is that they don't support typical payment profiles provided by services like Stripe or Braintree. Instead, Adyen supports "recurring payment contracts". These still store the user's card details with Adyen and allow them to be re-used, but they require an initial payment request to be created (such as an authorization). Because of this, we have to do the authorization during the payment checkout step when we still have access to the encrypted credit card data. That means by the time we get to confirm we've already authorized the payment and either fake the authorization to advance the payment or simply capture at that point, depending if the payment method has auto-capture enabled or not.
The payment_profiles_supported? method returns false because Solidus assumes you're following the typical flow when this is true, which causes a number of issues. However, the recurring contract is still created and the reference is stored in the gateway_customer_profile_id attribute on the source so that we can re-use the details to create payments or make modifications later.
The biggest issue with authorizing during the payment step is that we may be left with outstanding authorizations if the user abandons checkout on the confirm step. This is something to be aware of and anyone using credit card payments should periodically cancel these open authorizations.

I worked closely with luuk (and before him martin) and am :+1: on merging this. It should be completely inconsequential to anyone not using CC's.
Some bits of it are pretty unfortunate, but what part of trying to connect adyen to solidus isn't.

requires a rebase

thanks guys lgtm

@luukveenis and other guys, thank you, great work.
Could you tell me please it's not released? In master but not released, right?

@oleksiidrobiazko you are correct, this is currently an unreleased change in master


Update narrative in notebooks

Some of the narrative in the example notebooks is a little out of date now, in terms of the number of rows, or size of tables, etc. since we have added new data. Especially noticing this on the 2nd one.  Some of the example dataframe samples could also be more illustrative, if they were more specific, like showing monthly vs. annual aggregations.

The notebooks got a refresh when we moved them to Kaggle and prepared for OpenMod.


Add the slides for tergite overview

What was done

Added the slides for tergite overview presentation.

@wikfeldt Could you have a look?


Change for issue #409

This is the new pull request for the issue I opened yesterday. Hopefully this is fine with styling that time.

Yup, styling is good. Merged in https://github.com/ternjs/acorn/commit/c960152f26fe7246e1904094d63cb187947b2fa6. For the future, it would be nice if you would squash your commits for small changes. Thanks for your contribution!

Sure, I'll try to get it right on the first try :-).

@othomann By the way, just a suggestion - you might want to add that commiter email<EMAIL_ADDRESS>to your Github account so that your contributions would be associated with your profile.

Ok, thanks for the suggestion. Done.


Paths without trailing slash include trailing slash when built

Summary: static routes without trailing paths get built into path/index.html instead of path.html.
My website has paths defined without a trailing slash. So do at least some of the examples. So do real websites built on react-static, like nozzle.io.
{
  path: "/about",
  component: "src/About"
},

When building for production, react-static places server-side generated HTML into dedicated directories: dist/about/index.html. Servers treat this as a convention for a URL with a trailing slash: Apache has this behavior by default as DirectorySlash On and Netlify treats this as a mandatory normalization.  As a result, the servers redirect the user to /about/, which is unexpected.
To reproduce, visit nozzle.io/about. Notice the 301 redirect to the URL with the trailing slash. Now click “Home” and “About”. Notice how the client-side code switches to the URL without the trailing slash: /about.
This behavior is imperfect because it looks unpolished, and may even confuse users or impact SEO. It also can impact behavior of some scripts, starting with breaking Route component path matching. The latter is what caused me to notice theissue.
We can fix this by deploying the routes without a trailing slash to dist/about.html. This is a breaking change. We could also evaluate the impact and the usefulness of having both options in the codebase and maybe validate the routes to always be without the trailing slash.
The relevant code is in static/index.js. It’s not a recent addition, it’s there since the very beginning.
https://github.com/nozzle/react-static/blob/6588f6aad17c16e6fceea9e07a326e8d4f3c82ee/src/static/index.js#L423

This is related to #469, but not a duplicate. That issue talks about the <Route> and similar features breaking.
This is related to #470, but not a duplicate. Unlike the provider-specific header configuration, the convention for file on disc layout is stronger, and on top we already make a call by creating index files in a particular way, vs not doing anything for the header configuration.

I absolutely agree. I would welcome a option to use urls both with and without trailing slash.
Right now I have to manipulate with generated index.html using custom Node script. Which works fine, but it feels wrong.

Is anyone still experiencing this? We've done quite a bit of work on paths
and slashes lately.
On Thu, Apr 19, 2018 at 10:21 AM stale[bot]<EMAIL_ADDRESS>wrote:

This issue has been automatically marked as stale because it has not had
recent activity in 7 days. It will be closed if no further activity occurs.
Thank you for your contributions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/494#issuecomment-382796538,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCWIzhw9uA2ATCuh4M-eYNRHhuF0Gks5tqLmKgaJpZM4Sw677
.

I don’t have an opportunity to test it right now, but I don’t expect it to be fixed due to the code in questino still being the same:
https://github.com/nozzle/react-static/blob/33279eb563124eb3fad0a419011df9ec5349f4eb/src/static/index.js#L431
Besides, the change in behavior would be breaking backwards-compatibility, so if it is fixed, it’s also very bad. :-)

Bad bot.

How on earth is nozzle.io/about/ even working? When I do that with my react-static site on yarn serve and Netlify, I get the 404 route filling my whole screen. It loads the proper route for a split second, then it throws the 404. I don't get it. Terrible. I can't deep link to anything.

Ok, I figured out my issue. There was an Unexpected Identifier error in my console for development builds. It turns out I am writing blog posts with Markdown and in the YAML front matter, I had written a date but it didn't get wrapped in quotes during compilation. I think I might switch to using JSON front matter to be more explicit from now on. Now the trailing slashes work properly. I was banging my head against the wall trying to solve this.


output forward memory leak when transport is tls

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.

fluentd or td-agent version.
fluentd-0.14.16 and td-agent-3.0.1-0.el6.x86_64

Environment information, e.g. OS.
Centos 6.4

Your configuration

<system>
  root_dir /var/run/td-agent
  log_level error
</system>

<source>
    @type forward
    port 24284

    <transport tls>
      cert_path         /etc/td-agent/ssl/ca_cert.pem
      private_key_path  /etc/td-agent/ssl/ca_key.pem
      private_key_passphrase xxx
    </transport>
</source>

<match **>
  @id forward_a
  @type forward

  transport tls
  tls_cert_path                 /etc/td-agent/ssl/ca_cert.pem
  tls_allow_self_signed_cert    true
  tls_verify_hostname           false

  <server>
    host            <IP_ADDRESS>
    port            24284
  </server>

  <buffer>
    @type file
    flush_interval      10s
    flush_at_shutdown   true
  </buffer>

</match>

Your problem explanation. If you have an error logs, write it together.

If disable transport tls, the memory usage keep about 40MB, but when enable tls, the memory usage will increase to 340MB. No errors found in log file.

Updated fluentd to 0.14.20, this issue still there. Please let me know, if I can provide more information

Does it mean memory usage keep to increase or not increase but larger than non-TLS?

This seems same as #1767 and it is fixed in recent versions.


[Issue] i'm having a problem with my account and i loss my account

Describe the bug
i had a account named cafezin987, but i tried my password and pin of recuperaton but it didn't work, so i losed my account and i created a new account if i can recover my account i can prove that i am the owner of the account
Steps to Reproduce
i enter the hydra launcher, put my username and password or pin and doesn't work...
Expected behavior
i expected that i was going to enter my account and play the lost in play
Additional information and data

location of the files^
|
Operating System
Windows 10
Hydra Version
3.0.5
Before opening this Issue

[X] I have searched the issues of this repository and believe that this is not a duplicate.
[X] I am aware that Hydra team does not offer any support or help regarding the downloaded games.
[X] I have read the Frequently Asked Questions (FAQ).

for account recovery contact<EMAIL_ADDRESS>


Message loss still appear when use RELIABLE QoS

Currently, I am testing reliability of Micro-ROS, I used basic pub and sub program. I used Micro-ROS in ESP32 and I have set reliability QoS to RELIABLE,  durability to TRANSIENT_LOCAL and history to KEEP_ALL but during testing, the program still get lost messages. Can someone please let me know why this happend?

Could you provide steps for replicating this issue?

I have two ESP32 board and I placed publisher in one ESP32 and subscriber to the other one to communication using UDP. I created custom message which include count int32 and int32[] data. Then when a message is transmitted, count will +1. Besides, I also put another count at subscriber, so whenever subscriber receive message, I can compare these values toghether

I need:

application code
your colcon.meta files
versions of micro-ROS client and agent
agent instantiation procedure

Publisher  code:
`#include <stdio.h>
#include <unistd.h>
#include <rcl/rcl.h>
#include <rcl/error_handling.h>
#include <std_msgs/msg/int32.h>
#include <tutorial_interfaces/msg/num.h>
#include <rclc/rclc.h>
#include <rclc/executor.h>
#ifdef ESP_PLATFORM
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#endif
#define RCCHECK(fn) { rcl_ret_t temp_rc = fn; if((temp_rc != RCL_RET_OK)){printf("Failed status on line %d: %d. Aborting.\n",LINE,(int)temp_rc);vTaskDelete(NULL);}}
#define RCSOFTCHECK(fn) { rcl_ret_t temp_rc = fn; if((temp_rc != RCL_RET_OK)){printf("Failed status on line %d: %d. Continuing.\n",LINE,(int)temp_rc);}}
rcl_publisher_t publisher;
// std_msgs__msg__Int32 msg;
tutorial_interfaces__msg__Num msg;
int count = 0;
void timer_callback(rcl_timer_t * timer, int64_t last_call_time)
{
RCLC_UNUSED(last_call_time);
msg.count = count;
if (timer != NULL) {
	RCSOFTCHECK(rcl_publish(&publisher, &msg, NULL));
	printf("pub send seq %d\n", msg.count);
	count++;
}

}
void appMain(void * arg)
{
rcl_allocator_t allocator = rcl_get_default_allocator();
rclc_support_t support;
// create init_options
RCCHECK(rclc_support_init(&support, 0, NULL, &allocator));

// create node
rcl_node_t node;
rcl_node_options_t node_ops = rcl_node_get_default_options();
node_ops.domain_id = 4;
RCCHECK(rclc_node_init_with_options(&node, "freertos_int32_publisher", "", &support, &node_ops));

// create publisher
rmw_qos_profile_t pub_qos = rmw_qos_profile_default;
pub_qos.reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE;
pub_qos.history = RMW_QOS_POLICY_HISTORY_KEEP_ALL;
// pub_qos.depth = 1000;
pub_qos.durability = RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL;

RCCHECK(rclc_publisher_init(
	&publisher,
	&node,
	ROSIDL_GET_MSG_TYPE_SUPPORT(tutorial_interfaces, msg, Num),
	"freertos_int32_publisher",
	&pub_qos));

// create timer,
rcl_timer_t timer;
const unsigned int timer_timeout = 100.0;
RCCHECK(rclc_timer_init_default(
	&timer,
	&support,
	RCL_MS_TO_NS(timer_timeout),
	timer_callback));

// create executor
rclc_executor_t executor;
RCCHECK(rclc_executor_init(&executor, &support.context, 1, &allocator));
RCCHECK(rclc_executor_add_timer(&executor, &timer));

// msg.data.capacity = 10000;
// msg.data.data = (int32_t*) malloc(msg.data.capacity * sizeof(int32_t));
// msg.data.size = 0;
static int32_t memory[30];
msg.data.capacity = 30;
msg.data.data = memory;
msg.data.size = 0;

for (int32_t i =0; i < 30; i++){
	msg.data.data[i] = 1;//rand();
	msg.data.size++;
}

rclc_executor_spin(&executor);

// free resources
RCCHECK(rcl_publisher_fini(&publisher, &node));
RCCHECK(rcl_node_fini(&node));
free(msg.data.data);

vTaskDelete(NULL);

}
`

colcon.meta of Publisher:
`{
"names": {
  "microxrcedds_client":{
      "cmake-args": [
          "-DUCLIENT_UDP_TRANSPORT_MTU=2048"
      ]
  },

  "rmw_microxrcedds": {
      "cmake-args": [
          "-DRMW_UXRCE_MAX_NODES=2",
          "-DRMW_UXRCE_MAX_PUBLISHERS=2",
          "-DRMW_UXRCE_MAX_SUBSCRIPTIONS=2",
          "-DRMW_UXRCE_MAX_SERVICES=5",
          "-DRMW_UXRCE_MAX_CLIENTS=0",
          "-DRMW_UXRCE_STREAM_HISTORY=10",
          "-DRMW_UXRCE_MAX_HISTORY=2"
      ]
  }

}
}
`

Subscriber code:
`#include <rcl/rcl.h>
#include <rcl/error_handling.h>
#include <rclc/rclc.h>
#include <rclc/executor.h>

#include <std_msgs/msg/int32.h>
#include <tutorial_interfaces/msg/num.h>
#include <stdio.h>
#include <unistd.h>
#ifdef ESP_PLATFORM
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#endif
#define RCCHECK(fn) { rcl_ret_t temp_rc = fn; if((temp_rc != RCL_RET_OK)){printf("Failed status on line %d: %d. Aborting.\n",LINE,(int)temp_rc);vTaskDelete(NULL);}}
#define RCSOFTCHECK(fn) { rcl_ret_t temp_rc = fn; if((temp_rc != RCL_RET_OK)){printf("Failed status on line %d: %d. Continuing.\n",LINE,(int)temp_rc);}}
rcl_subscription_t subscriber;
tutorial_interfaces__msg__Num msg;
int count = 0;
void subscription_callback(const void * msgin)
{
const tutorial_interfaces__msg__Num * msg = (const tutorial_interfaces__msg__Num *)msgin;
printf("msg: %d, count: %d\n", msg->count, count);
count++;
}
void appMain(void * arg)
{
rcl_allocator_t allocator = rcl_get_default_allocator();
rclc_support_t support;
// create init_options
RCCHECK(rclc_support_init(&support, 0, NULL, &allocator));

// create node
rcl_node_t node;
rcl_node_options_t node_ops = rcl_node_get_default_options();
node_ops.domain_id = 4;
RCCHECK(rclc_node_init_with_options(&node, "int32_subscriber_rclc", "", &support, &node_ops));

// create subscriber
rmw_qos_profile_t sub_qos = rmw_qos_profile_default;
sub_qos.reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE;
sub_qos.history = RMW_QOS_POLICY_HISTORY_KEEP_ALL;
sub_qos.durability = RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL;
sub_qos.depth = 1000;

RCCHECK(rclc_subscription_init(
	&subscriber,
	&node,
	ROSIDL_GET_MSG_TYPE_SUPPORT(tutorial_interfaces, msg, Num),
	"freertos_int32_publisher",
	&sub_qos));

// create executor
rclc_executor_t executor;
RCCHECK(rclc_executor_init(&executor, &support.context, 1, &allocator));
RCCHECK(rclc_executor_add_subscription(&executor, &subscriber, &msg, &subscription_callback, ON_NEW_DATA));

// msg.data.capacity = 10000;
// msg.data.data = (int32_t*) malloc(msg.data.capacity * sizeof(int32_t));
// msg.data.size = 0;

static int32_t memory[30];
msg.data.capacity = 30;
msg.data.data = memory;
msg.data.size = 0;

rclc_executor_spin(&executor);

// free resources
RCCHECK(rcl_subscription_fini(&subscriber, &node));
RCCHECK(rcl_node_fini(&node));
free(msg.data.data);

vTaskDelete(NULL);

}
`

colcon.meta of Subscriber
`{
"names": {
  "microxrcedds_client":{
      "cmake-args": [
          "-DUCLIENT_UDP_TRANSPORT_MTU=2048"
      ]
  },

  "rmw_microxrcedds": {
      "cmake-args": [
          "-DRMW_UXRCE_MAX_NODES=2",
          "-DRMW_UXRCE_MAX_PUBLISHERS=2",
          "-DRMW_UXRCE_MAX_SUBSCRIPTIONS=2",
          "-DRMW_UXRCE_MAX_SERVICES=5",
          "-DRMW_UXRCE_MAX_CLIENTS=0",
          "-DRMW_UXRCE_STREAM_HISTORY=10",
          "-DRMW_UXRCE_MAX_HISTORY=2"
      ]
  }

}
}
`

I used Foxy

I create agent based on this tutorial: https://micro.ros.org/docs/tutorials/core/first_application_linux/. This mean I run agent on my Linux PC not from Docker

Does this works as expected using rclc_publisher_init_default and rclc_subscriber_init_default?
Which is the output of the subscriber? which samples are being lost?
Why have you modified the MTU value to 2048? How does it perform using the default value?

Some proposals:

Increase RMW_UXRCE_MAX_HISTORY to a greater number
Change the spin so it can let the scheduler handle low priority tasks:

	while(1){
		rclc_executor_spin_some(&executor, RCL_MS_TO_NS(100));
		usleep(10000);
	}

What is the difference between the default setup with custom QoS as I used because I want to test all QoS policy types.
I only count in the beginning and at the end when I measure. Here is the result: with 128 Bytes I got zero message loss, but with 1 Kilobyte, total message expect to receive is 2656 but total message actual receive only 2653 (during a few minutes) and I also test during 1 hour, total message expect to receive is 41294 and only receive 41244 (around 0.12% message loss rate)
Because I want to increase message size
Ros2 topic echo had the same value as actual receive message that I mentioned above

What is the difference between the default setup with custom QoS as I used because I want to test all QoS policy types.

Default QoS are defined in rmw: https://github.com/ros2/rmw/blob/master/rmw/include/rmw/qos_profiles.h#L51

I only count in the beginning and at the end when I measure. Here is the result: with 128 Bytes I got zero message loss, but with 1 Kilobyte, total message expect to receive is 2656 but total message actual receive only 2653 (during a few minutes) and I also test during 1 hour, total message expect to receive is 41294 and only receive 41244 (around 0.12% message loss rate)

It seems that you are having problems with fragmentation with big messages, see next comment

Because I want to increase message size

If you want to increase the message size, do not increase the MTU. I recommend keeping MTU to 512 B and increasing RMW_UXRCE_STREAM_HISTORY to a greater value. This way you will have more slots of 512 B to handle message fragmentation. RMW_UXRCE_STREAM_HISTORY shall be a power of two, so maybe 16 is a good starting value for your proposals.

Ros2 topic echo had the same value as the actual receive message that I mentioned above

I do not understand your answer here, ROS2 echo command receives all the messages or also experiments the losses. This is important to determine if your data loss is:

Data that is not being published correctly from the first ESP32
Data that is not being subscribed correctly in the micro-ROS client in second ESP32

Also, take this into account:
	while(1){
		rclc_executor_spin_some(&executor, RCL_MS_TO_NS(100));
		usleep(10000);
	}

By doing a rclc_spin() you are blocking FreeRTOS tasks with lower priority than the micro-ROS one.

I tried to change as you mentioned and I still get lost messages.
.

Data that is not being published correctly from the first ESP32
-> Yes, but do you might know what caused this to happen?

Could you explain which of the changes you have tried?

I changed rclc_executor_spin to rclc_executor_spin_some in the while loop as you mentioned.  and RMW_UXRCE_STREAM_HISTORY = 16 and MTU = 512.
I also cleaned build before uploading code to ESP32

Does it lose packages if you decrease the rate to for example 1 Hz?
Try to increase RMW_UXRCE_STREAM_HISTORY to 32

Yes, I can try it and I will let you know if message loss still appears but it will be too slow. Besides, did the publish rate affect to message loss rate?

A high pub/sub rate can collapse the internal middleware buffers in micro-ROS

Any update on this?

It is not an issue, it is just the nature of a full-static middleware. If it has no memory, it cannot store new data.
You can read more about the micro-ROS middleware here: https://micro-xrce-dds.docs.eprosima.com/en/latest/
In order to solve this issue just tune your balance between RMW_UXRCE_STREAM_HISTORY and rates.

Yes, thank you very much for your support


Bump versions

Where I work we're strict about maven version conflicts. Would there be any problem with bumping some of the swagger dependencies.
Full disclosure: These versions have been chosen to line up with dropwizard 1.1.0. The reflections one is the main one to update as the current version pulls in a defunct google annotations jar, the others are just nice-to-have.

@webron any concerns about updating the reflections library?

Yes, but only because there's no change log for the library at all, so can't really tell what changed and if there are any breaking changes  (yeah, yeah, semver).
It looks like our tests pass though... so let's hope for the best and go with it.

@webron, semver is an aspiration endpoint, nothing more.


Corrects the title message on deployment page when the user press the

deploy button. Partially resolves #1162.

When the user clicks on the Deploy button, the text of the title now changes from 'Press the button below to deploy' to 'Press the button below to abort the process'.

When the user presses the abort button, the text of the title now changes from 'Press the button below to abort the process' to 'Press the button below to re-start the deployment process'.

Test Server:
http://secure-meadow-20680.herokuapp.com

Screenshots to show the flow of the process:
Before pressing deploy button

After pressing deploy button and before pressing abort button

After pressing abort button

Codecov Report

Merging #1172 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1172   +/-   ##
============================================
  Coverage        63.06%   63.06%
============================================
  Files                8        8
  Lines             1397     1397
  Branches           218      218
============================================
  Hits               881      881
  Misses             516      516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045bbf6...0f802fe. Read the comment docs.


[style]: Hover efffect on top left side icon

What's the style idea?
Hover effect can be added
Add screenshots

Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

@manuel12 @ishika2021 @growupanand @mohammadanang kindly give me a attempt

For Now, It's not needed @devlohani99 , Please check another issue


Feature Request Export data locally

Hello,
would be nice if there is also the possibility to export all the manufacturing data in a local folder.
This is would be especially handy if you are not able to upload directly because of network restriction in your company for example.

I have modified the plugin quick and dirty to export the design data locally in a "Fabrication" folder inside the KiCAD project. In case anybody is interested too. Use at your own risk! Just replace the original Plugin with the content of the .zip file below.
com_github_aislerhq_PushForKiCad_LOCAL.zip


Feature: Use improved pluralization

Description of changes

Use feature flag to determine whether to set pluralName or listPluralName/syncPluralName
Issue #, if available

https://github.com/aws-amplify/amplify-cli/issues/8350
fix #252
Description of how you validated changes
Unit testing
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #255 (9feaf5d) into master (1f5e883) will increase coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   85.53%   85.55%   +0.01%
==========================================
  Files         144      144
  Lines        6609     6625      +16
  Branches     1517     1524       +7
==========================================
+ Hits         5653     5668      +15
  Misses        875      875
- Partials       81       82       +1

Impacted Files
Coverage Δ

...nc-modelgen-plugin/src/visitors/appsync-visitor.ts
95.42% <ø> (ø)

...ugin/src/visitors/appsync-json-metadata-visitor.ts
94.18% <75.00%> (-0.94%)
:arrow_down:

packages/amplify-codegen/src/commands/models.js
82.24% <100.00%> (+0.16%)
:arrow_up:

...delgen-plugin/src/visitors/appsync-dart-visitor.ts
96.93% <100.00%> (+0.02%)
:arrow_up:

...delgen-plugin/src/visitors/appsync-java-visitor.ts
93.09% <100.00%> (+0.06%)
:arrow_up:

...elgen-plugin/src/visitors/appsync-swift-visitor.ts
95.83% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5e883...9feaf5d. Read the comment docs.

Reminder this PR needs to be updated to remove the dart files changes related to Flutter (@HuiSF's comment https://github.com/aws-amplify/amplify-codegen/pull/255#discussion_r733981564)

hello, any chance to get this in the next CLI release ?

any updates on this?

Another variation of this problem exists in V2 transform, if V2 uses the improved pluralization by default for both list and sync query -> https://github.com/aws-amplify/amplify-ios/issues/1707#issuecomment-1079413894

Outstanding work on this PR. Confirm we are clear to push this for all platforms, and then rebase against current master branch.

Hi @marcvberg could you reopen this PR against the main branch?

@marcvberg let's create an asana task to get this released in the next sprint.

@alharris-at Added to my tasks

Hello, Any status when this will be merged. It blocks customer projects on this issue https://github.com/aws-amplify/amplify-ios/issues/1443 (opened since Sept. 2021). This PR is open since Oct 2021. Can you help to prioritize this ?

@sebsto what platform are you writing your workshop for? We're testing this right now to verify if we're in a good place to merge, but it looks like Android/Flutter still won't have support for improvedPluralization after this PR from my current testing.

@alharris-at workshop is for iOS / Swift
I currently have instructions guiding customers to modify the generated code
(and while I am at it, there is a warning about field ID being deprecated. but I should report that on another issue)

@alharris-at workshop is for iOS / Swift I currently have instructions guiding customers to modify the generated code
(and while I am at it, there is a warning about field ID being deprecated. but I should report that on another issue)

the warning about field ID being deprecated is a swift codegen warning. This is related to the new identifier field that is being created for the ability to create customizations of the primary key (renaming / composite, etc). To enable this, you can provide some instructions to the developer to toggle respectprimarykeyattributesonconnectionfield to true in the cli.json file before provisioning the backend (amplify push) and codegenerating the swift models (amplify codegen models)

The last comment on this PR was on October. Is someone actively working on this? I have an open issue reported: https://github.com/aws-amplify/amplify-swift/issues/2460

Thank you @marcvberg for the push. What are the next steps to get this merged ?

Looks like this issue has been fixed by https://github.com/aws-amplify/amplify-swift/issues/3135


fix: slot and primary can be different shape

See github issue #19457

@allenlavoie
the pr “https://github.com/tensorflow/tensorflow/pull/20539” relateed commit is wrong, i create a new pr again.

Nagging Assignee @caisq: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @caisq: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Add GEOSVoronoiDiagram to shapely

Per #833.
I thought it made sense to keep Delauney / Voronoi close together in the code since they're similar in use and right next to each other in the CAPI, but if you disagree I'm happy to move it to wherever.
I couldn't nail down for sure exactly when VoronoiDiagram was added to the CAPI. This entry was the best I could find indicating release version, so I went with 3.5.0.

Coverage remained the same at ?% when pulling 8eecd46307a809ec6aa8f5ac2fa872a883e5e522 on tomplex:voronoi-diagram into 91c70ba508a4030e20f2ef22e6e6acc6c1a69d82 on Toblerity:maint-1.7.

The current return value is a list of geometries. Could it also be considered to return the actual GeometryCollection (as it is returned by GEOS)? The user could then still get the list by doing result.geoms themselves.
I assume that for users that pass a single geometry, the current API returning a list is easier (and also more consisitent with the existing triangulate, which is a good reason of course ..). But returning a geometry collection would make it easier to have it compatible with the PyGEOS version.

@jorisvandenbossche, though I personally agree that a GeometryCollection feels like a better option since that's what being returned natively by GEOS, I think one of the best parts of Shapely is the consistency and therefore intuitiveness of the API, so I went with a list of geometries. I'd be happy to discuss more if you feel strongly, especially because it seems like there will be a closer union of Shapely and PyGeos in the future, so it makes sense to take such things into account.

@sgillies should I rebase this onto master?

@tomplex yes, please.
Returning a GeometryCollection would be more efficient and I'm in favor :+1:


More vision tests

Codecov Report

Merging #15 (3d17011) into master (9c09e8f) will increase coverage by 6.26%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   72.85%   79.12%   +6.26%
==========================================
  Files           8        8
  Lines         980      982       +2
  Branches      148      149       +1
==========================================
+ Hits          714      777      +63
+ Misses        237      181      -56
+ Partials       29       24       -5

Flag
Coverage Δ

unittests
79.12% <66.66%> (+6.26%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

thingsvision/model_class.py
71.34% <ø> (+8.77%)
:arrow_up:

thingsvision/vision.py
64.68% <66.66%> (+14.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c09e8f...3d17011. Read the comment docs.


Investigate pdfplumber pdf error during event scrape

We've been getting this PDFSyntax error from pdfplumber in Sentry since adding that logging in #29 (so, good confirmation that that change is reporting errors as expected). From those logs, it seems to be a different pdf causing it each time which leads me to believe that these are just temporary hitches. A pdf that triggers this error today, will most likely work just fine tomorrow. It could not encounter the error at all next time or a different pdf might cause it. This seems to be a known issue with one of its dependencies: https://github.com/pdfminer/pdfminer.six/issues/476
I'm thinking of two options. What do you think @antidipyramid:

Since these attachments get checked multiple times, it would have its chance to be checked again. We could change the sentry report to be a warning instead of an error if possible, and let it retry naturally next time.
We could try to repair the pdf when this error is raised with something similar to this comment in that mentioned issue. We'd probably copy the pdf into memory in order to repair it and retry the extraction on that memory copy, instead of actually writing a new one.

The event scrapes have continued on to succeed every time so this doesn't seem to be an urgent issue, but it is a frequent one.

If this error doesn't cause a persistent issue when handling certain PDFs, I think sending message to Sentry as a warning is reasonable.


Supercluster types should be dependency + error in their import

Due to the way Supercluster types are used here, they should be listed as dependency/peerDependency, not just devDep. The reason is the exported State interface, which refers to the Supercluster type.
Furthermore, even after installing the supercluster types to a project, typescript still fails with the following error:
node_modules/react-mapbox-gl/lib/cluster.d.ts:23:13 - error TS2749: ‘Supercluster’ refers to a value, but is being used as a type here.

23     superC: Supercluster;
              ~~~~~~~~~~~~

If I were to alter the code in cluster.d.ts:4 to be import * as Supercluster from 'supercluster'; then this error goes away. So probably this is caused by changes made in #731.
#735 referred to a build error that might be somewhat related to this.

Hey @henrinormak I am not too sure why the examples didn't pick this up, I will have a look if I have some time, meanwhile feel free to open a pull request if you have some time with a proper fix

@alex3165 I'll see if I can whip up a PR that would fix the problem, I have not touched the codebase of react-mapbox-gl before, so it might take me a bit longer to sort this out though.

Chiming in to say this is also breaking our webpack builds (we're not transpiling node_modules):
ERROR in node_modules/react-mapbox-gl/lib/cluster.d.ts(23,13):
TS2749: 'Supercluster' refers to a value, but is being used as a type here.
Version: typescript 3.6.4

Changing the import in cluster.d.ts to import * as Supercluster from 'supercluster'; as suggested by @henrinormak results in the following error:
ERROR in node_modules/react-mapbox-gl/lib/cluster.d.ts(23,13):
TS2709: Cannot use namespace 'Supercluster' as a type.
Version: typescript 3.6.4

As per #735 this was solved by installing<EMAIL_ADDRESS>"Silly me" indeed! Original report appears correct in that the types should be production or peer dependency. 👍

esModuleInterop solves the import issue; release v4.8.1 solves the type dependency issue


[Event Request] Codeunit Purch. Price Calc. Mgt. - OnBeforePurchHeaderStartDate

To get access to the Start Date handling in codeunit Purch. Price Calc. Mgt. (7010) and to the global variable "DateCaption" I would like to apply for a new integration event OnBeforePurchHeaderStartDate.
Publisher:
 [Integration]
    LOCAL PROCEDURE OnBeforePurchHeaderStartDate@100(VAR PurchHeader@1000 : Record 38;VAR DateCaption@1001 : Text[30];VAR StartDate@1002 : Date;VAR IsHandled@1003 : Boolean);

Please add following code at function PurchHeaderStartDate:
    LOCAL PROCEDURE PurchHeaderStartDate@31(PurchHeader@1000 : Record 38;VAR DateCaption@1001 : Text[30]) StartDate@1002 : Date;
    VAR
+     IsHandled@1003 : Boolean;
    BEGIN
+     OnBeforePurchHeaderStartDate(PurchHeader,DateCaption,StartDate,IsHandled);
+     IF IsHandled THEN
+       EXIT;

      WITH PurchHeader DO

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add Refactored Pod health monitoring functions previously defined in eco-gotests (ran subfolder)

Changes in this PR are now split, see https://github.com/openshift-kni/eco-goinfra/pull/570
Refactoring functions previously defined in eco-gotests RAN subfolder:

IsPodHealthy https://github.com/openshift-kni/eco-gotests/blob/4b0fbe0b32ad910f8f4421337cfe84c4f92cefc1/tests/cnf/ran/internal/ranhelper/ranhelper.go#L14 . New function name is: WaitUntilHealthy
waitForAllPodsHealthy https://github.com/openshift-kni/eco-gotests/blob/4b0fbe0b32ad910f8f4421337cfe84c4f92cefc1/tests/cnf/ran/talm/internal/helper/cluster.go#L146 . New function name is: WaitForAllPodsInNamespacesHealthy
Also adding Adding pod.WaitUntilInStatuses

Also modified the pod List function to return all namespaces when the namespace name is empty
Currently investigating unit tests

Closing this PR in favor of see https://github.com/openshift-kni/eco-goinfra/pull/570 and others (splitting each component)


Expose jsonFieldsToTruncate

It would be great to expose jsonFieldsToTruncate in this library. I'd love to pass in a list of custom fields I use frequently, to ensure they get truncated.
I frequently log entries that do not get truncated, since they're nested in some custom entry. Thus, they get dropped.
Another reference: https://github.com/googleapis/nodejs-logging-bunyan/issues/524

Hi @seeARMS, I have submitted a PR to enable custom fields truncation in this repo. Please let me know if you have any furthuer questions. Thank you!


[Docs] Upgrade to Jekyll 4.0.1

Current State:
The docs site is running Jekyll 4.0.0.
Desired State:
The docs site needs to be updated to Jekyll 4.0.1.

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

@leecalcote Meshery Docs use github pages. The github pages gem doesn't support Jekyll v4 yet. Reference ~ https://github.com/github/pages-gem/issues/651
Solution:
If we really want to upgrade to Jekyll v4.0.1, we could opt to use Github Actions. Reference ~ https://jekyllrb.com/docs/continuous-integration/github-actions/

@chandrashritii we're already running Jekyll v4.0 in our gem today.


Make combineReducers idempotent

I've been using your library for a little while now in combination with reselect and have really found it useful. However, I noticed after a little while that my reselect selectors were firing for different parts of the state tree even though those parts did not change. I investigated a little bit and found that the combineReducers here is returning a new Immutable object no matter what the child reducers are doing.
I added a test case to illustrate what is happening and updated the implementation to not unnecessarily create new Immutable objects. For my code, this has improved performance since, given an action, my selectors only fire for the part of the state tree that is different.

Thanks @chadly - merged & published new version to npm. Appreciate the fix!


Change function names to be more intuitive

There are a handful of function names with similar names:

plot_predictions
plot_forecast
forecast
predictions
predict

It isn't obvious when to use which function. To make the functions more user-friendly, I suggest changing the names to include the intended outputs. For example, plot_predictions produces a scatterplot of observed change vs. predicted change, so it could be renamed plot_obs_preds_fit. Similarly, predictions yields a vector while predict uses the same function to produce a data frame. So these could be renamed predict_vector or predict_tuple or predict_df depending on the output type.
Is there a distinction between prediction and forecast currently? We could use predict/prediction specifically for in-sample data (i.e., within the timeframe of available data) and forecast for out-of-sample future data (i.e., beyond the timeframe of available data).
Also, would there be any need for a hindcast function (i.e., before the timeframe of available data)?

Hey Zech, I think you're the best person to take a look into this from an UX perspective so please take a look into this.
predict and predictions are equivalent functions that return the predicted points of the training data by the neural network, and if new data is provided, then the function returns the predicted values by the neural network. This is the same behavior of the predict function in R. I would advocate to keep the syntax similar to R and deprecate predictions so there is a single function.
forecast extrapolates the neural network to create predictions starting from an initial point. The intention of the function is to forecast starting from the last point of the training data, but right now the code is set up to be more flexible than that. The intended experience can be obtained by setting up the initial point to be the last point of the training data by default.
plot_predictions and plot_forecast are easy ways to plot the outputs of predictions and forecast. Again, plot_predictions could be renamed to plot_predict.

I agree with the deprecation of predictions. Maybe we can modify predict to add an argument for the type of output desired (e.g., data frame, vector, array).
I think plot_predictions and plot_forecast are fine names, we'll just need to document their different usages well.

Solved on commit https://github.com/Jack-H-Buckner/UniversalDiffEq.jl/commit/c3b314e896180a1daee1f5d7cd9f440780be4d6d


Error: Evaluation Error: Error while evaluating a Function Call, The ciphertext refers to a customer master key that does not exist, does not exist in this region, or you are not allowed to access

Hi,
I am trying to use KMS with Hiera 5 but getting following error :
"Error: Evaluation Error: Error while evaluating a Function Call, The ciphertext refers to a customer master key that does not exist, does not exist in this region, or you are not allowed to access."
But when I used eyaml cli for encryption ,then it's working fine for the same AWS IAM user. So I think, it's not the AWS permission. May be I am missing some configuration in hiera yaml file
Following is my hiera.yaml :
version: 5
defaults:
  datadir: data
hierarchy:
  -
    lookup_key: eyaml_lookup_key
    name: "Secret data: per-node, per-datacenter, common"
    options:
      encrypt-method: KMS
      kms_key_id: KeyID
      kms_aws_region: aws region
    paths:
      - "nodes/%{trusted.certname}.yaml"
      - "%{::environment}.yaml"
      - "os/%{::osfamily}.yaml"

Thanks

It's working now so closing this issue..


No longer linking with fortran.

As of this commit I can no long compile OpenBLAS without explicitly defining NO_FORTRAN.
Here's some example output:
make -j$(nproc) TARGET=ARMV6
...
/usr/bin/arm-linux-gnueabihf-gcc -O2 -DMAX_STACK_ALLOC=2048 -marm -Wall -DF_INTERFACE_G77 -fPIC -DSMP_SERVER -DNO_WARMUP -DMAX_CPU_NUMBER=36 -mfpu=vfp -march=armv6 -DASMNAME= -DASMFNAME=_ -DNAME=_ -DCNAME= -DCHAR_NAME=\"_\" -DCHAR_CNAME=\"\" -DNO_AFFINITY -I..  -shared -o ../libopenblas_armv6p-r0.3.0.dev.so \
-Wl,--whole-archive ../libopenblas_armv6p-r0.3.0.dev.a -Wl,--no-whole-archive \
-Wl,-soname,libopenblas.so.0 -lm -lpthread -lm -lpthread
/usr/bin/arm-linux-gnueabihf-gcc -O2 -DMAX_STACK_ALLOC=2048 -marm -Wall -DF_INTERFACE_G77 -fPIC -DSMP_SERVER -DNO_WARMUP -DMAX_CPU_NUMBER=36 -mfpu=vfp -march=armv6 -DASMNAME= -DASMFNAME=_ -DNAME=_ -DCNAME= -DCHAR_NAME=\"_\" -DCHAR_CNAME=\"\" -DNO_AFFINITY -I..  -w -o linktest linktest.c ../libopenblas_armv6p-r0.3.0.dev.so  && echo OK.
../libopenblas_armv6p-r0.3.0.dev.so: undefined reference to `_gfortran_concat_string'
../libopenblas_armv6p-r0.3.0.dev.so: undefined reference to `_gfortran_pow_i4_i4'
../libopenblas_armv6p-r0.3.0.dev.so: undefined reference to `_gfortran_compare_string'
collect2: error: ld returned 1 exit status

make -j$(nproc) TARGET=ARMV6 NOFORTRAN=0
...
/usr/bin/arm-linux-gnueabihf-gcc -O2 -DMAX_STACK_ALLOC=2048 -marm -Wall -DF_INTERFACE_G77 -fPIC -DSMP_SERVER -DNO_WARMUP -DMAX_CPU_NUMBER=36 -mfpu=vfp -march=armv6 -DASMNAME= -DASMFNAME=_ -DNAME=_ -DCNAME= -DCHAR_NAME=\"_\" -DCHAR_CNAME=\"\" -DNO_AFFINITY -I..  -shared -o ../libopenblas_armv6p-r0.3.0.dev.so \
-Wl,--whole-archive ../libopenblas_armv6p-r0.3.0.dev.a -Wl,--no-whole-archive \
-Wl,-soname,libopenblas.so.0 -lm -lpthread -lm -lpthread
/usr/bin/arm-linux-gnueabihf-gcc -O2 -DMAX_STACK_ALLOC=2048 -marm -Wall -DF_INTERFACE_G77 -fPIC -DSMP_SERVER -DNO_WARMUP -DMAX_CPU_NUMBER=36 -mfpu=vfp -march=armv6 -DASMNAME= -DASMFNAME=_ -DNAME=_ -DCNAME= -DCHAR_NAME=\"_\" -DCHAR_CNAME=\"\" -DNO_AFFINITY -I..  -w -o linktest linktest.c ../libopenblas_armv6p-r0.3.0.dev.so -L/usr/bin/../lib/gcc/arm-linux-gnueabihf/4.8.3 -L/usr/bin/../lib/gcc/arm-linux-gnueabihf -L/usr/bin/../lib/gcc -L/usr/bin/../lib/gcc/arm-linux-gnueabihf -L/usr/bin/../lib/gcc/arm-linux-gnueabihf/4.8.3/../../../../arm-linux-gnueabihf/lib -L/usr/bin/../arm-linux-gnueabihf/libc/lib/arm-linux-gnueabihf -L/usr/bin/../arm-linux-gnueabihf/libc/lib -L/usr/bin/../arm-linux-gnueabihf/libc/lib/arm-linux-gnueabihf -L/usr/bin/../arm-linux-gnueabihf/libc/usr/lib/arm-linux-gnueabihf -L/usr/bin/../arm-linux-gnueabihf/libc/usr/lib -L/usr/bin/../arm-linux-gnueabihf/libc/usr/lib/arm-linux-gnueabihf  -lgfortran -lm -lm -lc   && echo OK.
OK.
rm -f linktest
make[1]: Leaving directory '/work/OpenBLAS/exports'

 OpenBLAS build complete. (BLAS CBLAS LAPACK LAPACKE)

  OS               ... Linux
  Architecture     ... arm
  BINARY           ... 32bit
  C compiler       ... GCC  (command line : /usr/bin/arm-linux-gnueabihf-gcc)
  Library Name     ... libopenblas_armv6p-r0.3.0.dev.a (Multi threaded; Max num-threads is 36)

To install the library, you can run "make PREFIX=/path/to/your/installation install".

Hmm. NOFORTRAN should be set automatically (by f_check) when no fortran compiler is found, and I think it would make sense not to try to link against a fortran runtime library that may not even be installed in that case. Do you see any references to fortran code being compiled in the full log of the default build ?

Yes, totally agree with that.  For some reason my CI server (which has been building openblas correctly for a few months) and which does have fortran installed doesn't link with -lgfortran.  That is unless yes explicitly set NOFORTRAN to 0.  This should be reproducible simply by running
make -j$(nproc) TARGET=ARMV6

on a machine with all required pre-request (including fortran).
You can also reproduce by building this dockerfile: https://gist.github.com/KellenSunderland/2dcd5be1dbbe54df694e13abe8f0f6f3

You can try
FC=Fake-Nothing
And/or
NOLAPACK=1
To disable fortran other ways.
btw to enable make -j you need to set MAKE_NB_JOBS=-99, otherwise it uses 1 process per cpu
Much more of build log is needed to diagnose problem.

Thanks for the info brada.  Just to be clear I'm not trying to disable fortran, I'm trying to enable it.  Let me know if you're unable to reproduce the problem, and if you are I can post some more of the build logs.

I dont have ARM with 2 cores (I have in mobile, but i dont think it can dockr container)
FC & Co should be parameters to make, not env variables.

The Dockerfile attached should work on an x86 box.  The only thing you'll need is docker installed and then run:
docker build -f Dockerfile .

The env vars are there because this is just the first part of a longer script which reuses the values.

Probably the ifeq misfires if/when NOFORTRAN is not even defined ? (My excuse is that I copied that syntax from an OSX build line further down in exports/Makefile, assuming that one to be correct - the "filter" is involved as a CBLAS-only build sets NOFORTRAN=2 for whatever reason)

Indeed wisdom of the 'net suggests the ifeq ($NOFORTRAN, $(filter $NOFORTRAN), 1 2)) should be rewritten as ifneq (,$(filter(1 2, $NOFORTRAN))) as "filter" returns an empty string for "no match" (which would match the undefined/empty NOFORTRAN in the present code).

Just ran with the latests commit and can verify everything's working.  Thanks a ton for the quick fix Martin.


buildDotnetModule: Add arg to allow private deps by using fetchurlBoot

Description of changes
This patch adds a argument to the buildDotnetModule which makes the internal mkNugetDeps function use fetchurlBoot rather than fetchurl, because the former allows using a netrc file.

This is not ready yet, as we know that builtins.fetchurl not allowed is in nixpkgs. I would ask for feedback about this, modulo that we make fetchurl an overrideable input to buildDotnetModule, so that users can override it with builtins.fetchurl if they desire.
We tested this on a proprietary project with private dependencies and our build succeeded.

Developed with @TheNeikos

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is in the history of:

https://github.com/NixOS/nixpkgs/pull/237926
https://github.com/NixOS/nixpkgs/issues/261051
https://github.com/NixOS/nixpkgs/pull/296134


[WIP] Make slice values symmetric for get/set.

This is intended to make the use of slices symmetric between the use of their String() and Set() methods. It should address an issue where flags that contain a leading and trailing brace are not parsed (e.g. [1,2,3] is not parsed, but 1,2,3 is).
This is currently a work in progress and I am seeking feedback on the approach.
TODO:

[ ] Handle string slices
[ ] Tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Quests data keeps whipping player progress.

What is your Quests version / build number (do not say "latest")?
latest
Describe the problem and how to replicate it.
Every time a server restart happens player data is erased. all of the quests and everything remains (thank God), but player quest progress is wiped.
Any console errors to share?
none

If applicable, can you provide an example quest from quests.yml?
No response

do not say "latest"

Is it standard policy to be rude and to close a valid issue instead of just
simply asking in a polite way "can you please provide the version number
you are using?" or something along those lines.
On Fri, Dec 8, 2023 at 4:51 PM PikaMug @.***> wrote:

do not say "latest"
—
Reply to this email directly, view it on GitHub
https://github.com/PikaMug/Quests/issues/2169#issuecomment-1848019719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGA36GZS732AAP3G2O7TPDYIOYXVAVCNFSM6AAAAABANEIMIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYGAYTSNZRHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

There was no intent to appear rude, but the issue was not valid for the reason quoted. You are more than welcome to create a new issue with the necessary information. An example quest you know had been wiped would also help.


error: could not remove build directory

Problem
I use devcontainer.
And /path/to/repo/target is a mountpoint.
When I run cargo clean, cargo try to delete mount point, which leads to error: could not remove build directory.
Steps
$ mountpoint /path/to/repo/target && cargo clean
/path/to/repo/target is a mountpoint
error: could not remove build directory

Caused by:
  failed to remove directory `/path/to/repo/target`

  Caused by:
      Device or resource busy (os error 16)

  Error: failed to remove directory `/path/to/repo/target`

Caused by:
  Device or resource busy (os error 16)

Possible Solution(s)
Don't try to delete mountpoint.
Notes
No response
Version
No response
Related
I run cargo clean because https://github.com/rust-lang/rust-analyzer/issues/15057#issuecomment-1777062345

This looks to be a duplicate of #11887, closing in favor of that.  If there is a distinction between these that I missed, let us know!


AttributeError: 'ConfigDict' object has no attribute 'log_level'

i am trying to run train.py with cascade rcnn model with tensorboard  on and i am  getting this error
log_config = dict(
interval=1,
hooks=[
dict(type='TextLoggerHook'),
dict(type='TensorboardLoggerHook')
])

Please use the error template, or at least provide a config and command to reproduce your errors.


Returning the object that is inserted or just the ID

Can I access the row that is inserted
conn
      |> Xandra.execute!(prepared, %{
        "async_id" => async_id,
        "facts" => Poison.encode!(facts),
        "result_set" => Poison.encode!(result_set),
        "rule_set_version_id" => String.to_integer(rule_set_version_id)
      })
    |> play_with_inserted_id

My Table
CREATE table audit_log_keyspace.rules_engine_audit_logs
        (
          id timeuuid,
          facts text,
          result_set text,
          async_id uuid,
          rule_set_version_id int,
          inserted_at timestamp,
          created_at timestamp,
          PRIMARY KEY (id)
        );"

How can I access just inserted data from above.

An INSERT operation returns a void response. You have the async_id there, you ought to be able to read the row with that.
In general, we reserve the issue tracker for issues. For questions, places like ElixirForum are more suited and you'll likely find it easier to get some help there 👍
In any case, closing this as there's no issue with Xandra per se highlighted here. Thanks @sahilpaudel-pe! 💟


[FLINK-8428] [table] Implement stream-stream non-window left outer join

What is the purpose of the change
Implement stream-stream non-window left outer join for sql/table-api. A simple design doc can be found here
Brief change log

Add left join

with non-equal predicates
without non-equal predicates

Adapt retraction rules to left join. Outer join will generate retractions
Adapt UpsertTableSink. Table mode of dynamic table produced by left join is Update Mode, even if the table does not include a key definition
Add inner join test cases which consistent with test cases in batch.
Add left join test cases which consistent with test cases in batch.

Verifying this change
This change added tests and can be verified as follows:

Added integration tests for left join with or without non-equal predicates.
Added HarnessTests left join with or without non-equal predicates.
Add tests for AccMode generate by left join.
Add tests for UpsertSink followed left join.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (already docs)

hi, @twalthr Look forward to your review, thanks  :-)

Update pr according to @walterddr 's suggestions.

Hi @twalthr @walterddr
The latest update refactors interfaces and functions to make code more friendly to right/full joins. The code of right/full joins are also ready and can be reached from https://github.com/hequn8128/flink/tree/outerjoin (branch:outerjoin).
@fhueske  It would be great if you can also take a look.
Thanks all. Hequn

Thanks @hequn8128! We're pretty busy with the Flink 1.5 release right now.
This will be one of the first features to add once 1.5 is out!
Best, Fabian


additional data from json

Is there any way to send additional data to bootgrid?

http://www.jquery-bootgrid.com/Documentation#methods
I'd set up a responseHandler, and call any methods you might need. You get access to the JSON data, so you can pass whatever you need from the server and then act upon it client side upon load time.


Make this a registered Julia package

@JuliaRegistrator register

Closed by https://github.com/JuliaRegistries/General/pull/68538
See also: https://github.com/jakewilliami/PenultimateDays.jl/commit/2e3232f5dcf768ca8a1b2a9618a006b839411090


⚠ Bofrost.be has degraded performance

In 755b4ce, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 879 ms

Resolved: Bofrost.be performance has improved in 7c042eb after 10 minutes.


Current inputs on NewRoutine.scala.html do not function

If data is put into the form and submitted, the form returns an error as though none of the fields have data.

Verified that when data is put into the new routine form and submitted, the form saves the routine and displays it on the index page. Also verified that Edit and Delete work properly. #63 #47


Move read-write APi generation related code to templates

Reference discussion: https://github.com/amazon-ion/ion-cli/pull/61#discussion_r1412361061
Currently some of the API generation related code lives in the implementation inside generator.  This needs to be moved to the templates defined for different data types.
Moving as much code to the templates makes it easy to maintain code and adopt new changes, as well as extend new APIs and templates.

Closed with #81


html

this is the html code file for the project benneats

should i merge this file bcz this is empty write now

should i merge this file bcz this is empty write now

no i will do it in a while


Problem starting the container on Raspberry Pi

Hi,
I'm poking docker and Influx/Grafana first time on Raspberry Pi. Followed the README, but container wont start:
pi@raspi4:~ $ docker start docker-influxdb-grafana
docker-influxdb-grafana
pi@raspi4:~ $ docker ps -a
CONTAINER ID        IMAGE                                          COMMAND             CREATED             STATUS                     PORTS               NAMES
6ce36eebef10        philhawthorne/docker-influxdb-grafana:latest   "/run.sh"           11 minutes ago      Exited (1) 2 seconds ago                       docker-influxdb-grafana

Trying with interactive:
pi@raspi4:~ $ docker start -i docker-influxdb-grafana
standard_init_linux.go:211: exec user process caused "exec format error"

Did I miss something, or should it even work on Raspberry Pi?

Hi,
Unfortunately looking at my dockerfile this container most likely won't run on a Raspberry Pi because of architecture issues. However due to the number of writes InfluxDB would make, it may not make sense to run this on a Raspberry Pi with an SD card.
I'll close this issue off for now. I'd be happy to accept a pull request in the future if someone wants to contribute a Raspberry Pi specific dockerfile to support this.

@philhawthorne  I don't disagree with the decision or reasoning, but could it be possible to add warning about unsupported architecture? I'm new to docker, so no idea if that's doable. But it would save some time from Raspberry Pi users :)

@harriv I can certainly add a warning to this repo's readme 👍
It won't prevent anyone attempting to run the docker run command, but might save someone some time.

@harriv @philhawthorne
Hi... I build a docker image for my pi with your code and it's running without problems...
I used git clone and docker build -t
Cheers Ronald

@harriv @philhawthorne
Hi... I build a docker image for my pi with your code and it's running without problems...
I used git clone and docker build -t
Cheers Ronald


Elementor ?

Hi,
Do you think it is possible in the current state to work with elementor on your theme?
Thank's

"Hello we are Neptune, we build a light road for light cars :D3
"5jv: Hey there, Can I still tide my hummer?"

It is possible to make simple and light pages with elementor ... !

Why using Elementor so?

It's a simple question, if your theme also reduces the impact for elementor users I find that already good.

It's not mine, I'm just a random visitor here ;)

ok :)


Off center icons

Hello,
Does anyone know why the icons are off-center, I don't understand why and I don't know how to solve it, if someone can help me...
Below I leave an example.
Thank you very much!

I've made a build that changes the way the icons are displayed and it fixes this issue.
See here:
Fixed icon and UI on HiDPi-enabled devices. #255
Please comment the pull request to give it more traction. 😄
Also, here's a beta build of the HDPi version:
TaskbarGroups_HiDpi.zip
Have a great day ! 👋


🚀 Feature: Isolating the login panel from shared links (hide login panel)

🔖 Feature description
It would be nice to be able to expose only the path to the generated links, but in such a way that the login panel is not visible from the outside. Maybe a separate port for the login panel and links? or the possibility of configuring Pingvin Share so that you can easily split /admin and /share in your own separate reverse proxy
If anyone currently has a solution for this, please share your idea.
🎤 Pitch
Preserving the ability to post public links for downloading and uploading files, but preventing viewing and logging in or attempting to log in to the user/administrator panel from outside the local network

I'm not a reverse proxy expert but I think this can be done pretty easily. Here is an example nginx configuration from ChatGPT:
server {
    listen 80;

    # Define the server name
    server_name your_server_name.com;

    # Location blocks for specific paths
    location ~ ^/(next/.*|/(img/.*|s/.*|share/.*|api/shares/.+|api/files/.+) {
        # Allow only local network access
        allow <IP_ADDRESS>/16; # Adjust this to your local network IP range
        deny all;

        # Reverse proxy settings
        proxy_pass http://your_backend_server;
        # Include other necessary proxy settings
    }

    # Default location block, denying all other requests
    location / {
        deny all;
    }

    # Other server configurations
    # ...
}

Maybe I'm missing some paths that should be allowed outside the network, but you can debug this with the browser dev tools and update the whitelist accordingly.

In my opinion this is something that shouldn't be implemented directly into Pingvin Share, because of that I'm closing the issue. Feel free to create a GitHub discussion if you need help with your custom configuration.

Maybe right, I set up Nginx Proxy Manager, and I managed to configure it using the GUI without major issues. For others who would like to achieve something similar using the GUI:
Add a regular "Proxy Host" with access for everyone.
In the "Custom Locations" tab, add 5 locations:
/s
/share
/api
/img
/upload
with the filled custom/cog field:
allow all; # Public access
and the fifth one:
/
with the filled custom/cog field:
allow <IP_ADDRESS>/24; # Local access only (IP address range)
deny all; # All other connections will be rejected
You can add more 'allow' statements before 'deny all.'
It seems to me that you could also simply block /auth and leave the rest unlocked. However, in my case, I wanted the main page not to be publicly accessible, so I blocked everything and only allowed what seemed necessary to me.


Cleanup of Go workflow

This PR introduces a couple of cleanup changes in Go workflow, as part
of work on RFC-18. Those changes are:

Moving scan job from gosec.yml to client.yml (there is no need
to keep them in separate workflows)
Adding client- prefix to scan and build-and-test jobs (to avoid
confusion in the future with other similar jobs that we may want to add
or remove from required list in branch protection settings)
Removing test result puvblishing step (we've decided to resign from
using EnricoMi/publish-unit-test-result-action action, as it worked
in a confising way sometimes - was assigning the tests results to
incorrect workflows)
Removing unnecessary comment

nkuba, following jobs can be configured as required in GitHub's settings:

client-build-and-test
client-scan


Add support for tox, Travis, and (maybe) Python 3

Because execfile went away in py3, this package won't even install.
I added a basic tox.ini that calls flake8, and tested it on py26, py27, py33, and py34. There are still no tests, so I don't know whether other Python 3 issues lurk, but at least we can try now.
https://travis-ci.org/aclevy/pygerduty/builds/56747652

Thanks!

Thanks for accepting! Any chance you'd be willing to publish a new version to PyPI? :)

pushed as 0.28


Allow to add key/value pairs to a socket i.e. a socket scope

Basically, it is analogous to the request scope defined in Servlet specification so that this attribute set should be initialized and destroyed along with the lifecycle of the socket.

[ ] Implement <T> T get(String name) in ServerSocket

It should return the value mapped to the given name.

[ ] Implement ServerSocket socket.set(String name, Object value)

It should associate the value with the given name.

[ ] Implement ServerSocket socket.remove(String name)

It should remove the value associated with the given name.
Furthermore, we can this attributes to manipulate a selection for socket delicately i.e. Sentence like server.all().has("is-admin", true).send("foo", "bar").
See the discussion at https://groups.google.com/d/topic/cettia/xAzTTqfY4FQ/discussion

I like the has method, that could be useful. What do you think about a negate function?
server.all().has("is-admin", true).not().send("foo", "bar")

Maybe the same for tags
server.byTag("tag").not().send("foo", "bar");

Don't have an use case for that. Just thinking that could be useful.

What do you think about a negate function?

Great. Furthermore, we could be inspired by fluent interfaces like Spring's RequestPredicates and CSS selectors.

Maybe an easier approach is to provide one method that takes a java.util.function.Predicate implementation as argument.

👍 Yeah, it's absolutely great. We can do this in Cettia 2 since Cettia 1 is supposed to support Java 7. This feature including socket matching operations will be one of the core features of Cettia 2.

You could backport the Predicate interface to Java 7.
public interface ServerSocketPredicate {
    boolean test(ServerSocket socket);
}

Somebody working on Java 7 can use anonymous inner classes or implementations of the interface.
  server.select(new ServerSocketPredicate() {
	@Override
	public boolean test(ServerSocket socket) {
	   return socket.tags().contains("tag1") && !socket.tags().contains("tag2");
	}
  }).send("foo", "bar");

Projects with Java 8 and Cettia 1.1 can use a lambda or an adapter if they want to use java.util.function.Predicate
server.select(socket -> socket.tags().contains("tag1") && !socket.tags().contains("tag2"))
          .send("foo", "bar");

  Predicate<ServerSocket> p1 = socket -> socket.tags().contains("tag1");
  Predicate<ServerSocket> p2 = socket -> socket.tags().contains("tag2");
  server.select(adapt(p1.and(p2.negate()))).send("foo", "bar");

  ServerSocketPredicate adapt(Predicate<ServerSocket> predicate) {
      return socket -> predicate.test(socket);
  }

If Cettia 2 moves from ServerSocketPredicate to Predicate, upgrading a project is easy. If the project only uses lambas they don't have to change anything and in the second case they have to remove the adapt method.

I think ServerSocketPredicate should extend Serializable for clustered environment, and then everything will be okay. Thanks for the suggestion.

@ralscha Inspired by your solution, I created some issues #23 #24 #25 to support "select some sockets and do something with them" intuitively, which is the basic concept of Cettia. It would be nice if you could review them when you get a chance.

[ ] Write unit tests - it's time to expose DefaultServer.DefaultServerSocket in some way.


Add manifest to collection

Maybe add a Manifest Reference to the schema to handle this.

A working example can be produced using the modified JSON schema (see  https://github.com/IIIF/presentation-validator/pull/123)
from iiif_prezi3 import Collection,Refmanifest
col = Collection(id="https://test.com",type="Collection")
refman = Refmanifest(id="https://refman.com",type="Manifest",label={"en":"mylabel"})
col.items = []
col.items.append(refman)
col.json(exclude_unset=True)

The output is correct except for the label see issue https://github.com/iiif-prezi/iiif-prezi3/issues/11.
Possibly, the method could be encapsulated in a helper function e.g. add_mannifest_to_collection.

I opened a new issue in the presentation-validator I think it should be discussed further: https://github.com/IIIF/presentation-validator/issues/128

After https://github.com/IIIF/presentation-validator/pull/130 the reference class can be used to add a reference to a manifest inside a collection see the tutorial using an helper function here:
https://github.com/giacomomarchioro/iiif-prezi3/blob/main/tutorial.ipynb

This pull request should fix the issue https://github.com/iiif-prezi/iiif-prezi3/pull/30

Hackathon/Helper tickets: #37, #42


Remove DocumentForm.documentList property

The purpose of passing a DocumentList into a DocumentForm is to allow the DocumentForm to add the created Document to the DocumentList. However, this means that DocumentForm can't be used without a DocumentList, and, it means that DocumentForm has to know about DocumentList, which it really shouldn't. To keep the easy automatic UI, the DocumentForm should have an "onSaved" event which returns a reference to the Document (new or updated) and the caller (for rapido the AddDocumentFloatingActionButton or the DocumentActionsButton) which can then interact with the DocumentList.
DoucmentForm will need a labels property, so that it knows what to edit.

This is actually going to need to be part of a larger scale refactoring.
#2 , #46 and probably some others will be fixed by this.
Document itself should have a labels property. It can be passed from the DocumentListView if the DocumentListView has labels set already.
Then to create a new one, you can go:
DocumentForm(document: document, onSaved: (Document doc ){
documentList.add(doc);
});
onSaved should not be required in the case of editing because the Document will fire onChanged, which will be picked up in the DocumentList assuming the Document was already in that list.


:bug: fixing up multimodule pom in examples

nice, demo failed successfully, so we can go ahead and update whenever you want @shawn-hurley


V2: Should discovery have a local argument to force the cache?

Problem:
getting disco servers/organizations can be slow due to the discovery server or the users network being slow. Even though we have a timeout and a cookie, it might be nice to introduce a local/cache argument to the functions
If non-zero/true this means that only the cached copy is returned. Clients can thus first call the functions with true and then asynchronously call it with false to get the most up to date copy.
This is right now the most problematic on startup where clients have no discovery cache filled

The discovery cache is initially prefilled at compile time, right? So, even on initial startup eduvpn-common should have discovery cached.

The discovery cache is initially prefilled at compile time, right? So, even on initial startup eduvpn-common should have discovery cached.

This is true but it still tries to get it from the network. If you have a slow connection it only falls back to the cache after the HTTP timeout, which may be a problem?

Didn't get a lot of +1s from the team

discussed with roop

moved to https://codeberg.org/eduVPN/eduvpn-common/issues/19


Throttle cursor redrawing in outputStream.cpp

Summary of the Pull Request
Try to throttle the cursor redrawing in the conhost world.

References
The motivation of this is the high CPU usage of TriggerRedrawCursor (#10393).
This can be seen as the conhost version of #2960.

PR Checklist

[X] Supports #10362
[X] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

I know conhost code are in maintenance mode so I'm marking this as a draft.
This should help both conhost & WT (OpenConsole).

I see no obvious cursor rendering issue after this. So I'm marking this ready for review.


Create 3rd page header component

Create a function component in React to replicate the following:-

Use svg format for the designs and do the remaining styling using scss.

can i take this issue.

can i work upon this issue

I would like to work on this issue, please elaborate.


Controlnet inpaint

adds reference as 1st CN unit option if you've got >=2 CN units enabled in settings, it's a weird option but kinda fun


Use session.verify

session.verify is currently ignored. Didn't have time for a unit test, but this is one solution.

@causton81 What evidence do you have that Session.verify is ignored? This works fine for me:
>>> import requests
>>> s = requests.Session()
>>> s.verify = False
>>> s.get('https://kennethreitz.org/')
/Users/cory/.pyenv/versions/2.7.10/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py:789: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
/Users/cory/.pyenv/versions/2.7.10/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py:789: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
  InsecureRequestWarning)
<Response [200]>

Sorry for the lack of details. The problem is when either REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE is set in the environment and session.trust_env==True, then session.verify is ignored.  I added a unit test to demonstrate. Just for completeness I missed this for awhile because I was testing with Python 2.7.3 which ignores cert issues. I noticed it when testing with Python 2.7.9 and env variable REQUESTS_CA_BUNDLE.

Ah, yes, I see the problem now.
We have a similar issue with proxy settings, where proxies set in the environment can override proxies set on the session. I'm beginning to wonder if we can fix two problems in one go here, by taking the trust_env block of merge_environment_settings and moving it below the merge_setting lines in that function.
@causton81 This is definitely a real bug, but we need a bit of time to work out what the fix is and what branch it'll go on to (while this is strictly a bug fix, it's been in the product long enough that it's also an API compatibility break and needs to be dealt with cautiously).
@sigmavirus24 What do you think about my proposed rearrangement of merge_environment_settings?

@Lukasa the rearrangement is something we had discussed for 3.0.0 because it's fundamentally backwards incompatible. I'm in favor of it though because I think the order of precendence should be (in order of least to most important):

Environment
Session settings
Per-call settings

(For those features to which this applies)

Ok, let's get this done for 3.0.0.

Ok, I'm closing this in favour of #2839.


Enhancement: Run php-cs-fixer on GitHub Actions

This PR

[x] runs php-cs-fixer on GitHub Actions

Follows #34.

Thank you, @nikolaposa!


fix(contracts): OZ-N03 Incorrect Function Visibility

Purpose or design rationale of this PR
This PR fix the following issue reported by Openzepplin: https://defender.openzeppelin.com/v2/#/audit/bca59bc7-0ff8-49a2-bcea-09f7cc7a82b8/issues/N-03

The verifyZkTrieProof function of the ScrollChainCommitmentVerifier contract is not called internally by this contract.
Consider setting this function's visibility to external instead of public in order to reduce the attack surface.

PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[x] fix: A bug fix

Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?

[x] No, this PR doesn't involve a new deployment, git tag, docker image tag
[ ] Yes

Breaking change label
Does this PR have the breaking-change label?

[x] No, this PR is not a breaking change
[ ] Yes

Review

Good morning,
Please find this fixed code :
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;
import { IScrollChain } from "./IScrollChain.sol";
import { ZkTrieVerifier } from "../../libraries/verifier/ZkTrieVerifier.sol";
contract ScrollChainCommitmentVerifier {
/// @notice The address of poseidon hash contract
address public immutable poseidon;
/// @notice The address of ScrollChain contract.
address public immutable rollup;

constructor(address _poseidon, address _rollup) {
    poseidon = _poseidon;
    rollup = _rollup;
}

/// @notice Validates a proof from eth_getProof in l2geth.
/// @param account The address of the contract.
/// @param storageKey The storage slot to verify.
/// @param proof The rlp encoding result of eth_getProof.
/// @return stateRoot The computed state root.
/// @return storageValue The value of `storageKey`.
///
/// The encoding order of `proof` is
/// ```text
/// |        1 byte        |      ...      |        1 byte        |      ...      |
/// | account proof length | account proof | storage proof length | storage proof |
/// ```
function verifyZkTrieProof(
    address account,
    bytes32 storageKey,
    bytes calldata proof
) external view returns (bytes32 stateRoot, bytes32 storageValue) {
    return ZkTrieVerifier.verifyZkTrieProof(poseidon, account, storageKey, proof);
}

/// @notice Verifies a batch inclusion proof.
/// @param batchIndex The index of the batch.
/// @param account The address of the contract in L2.
/// @param storageKey The storage key inside the contract in L2.
/// @param proof The rlp encoding result of eth_getProof.
/// @return storageValue The value of `storageKey`.
function verifyStateCommitment(
    uint256 batchIndex,
    address account,
    bytes32 storageKey,
    bytes calldata proof
) external view returns (bytes32 storageValue) {
    require(IScrollChain(rollup).isBatchFinalized(batchIndex), "Batch not finalized");

    (bytes32 computedStateRoot, bytes32 _storageValue) = verifyZkTrieProof(account, storageKey, proof);
    bytes32 expectedStateRoot = IScrollChain(rollup).finalizedStateRoots(batchIndex);
    require(computedStateRoot == expectedStateRoot, "Invalid inclusion proof");

    return _storageValue;
}

}


Genetic Variants Studies - API endpoint to get all studies resources associated to a given Genetic Variant

As developer
I want an api endpoint
So that when I send a GET request, hateoas, paginated list of all studies associated to a given Genetic Variant in the database is returned in JSON Format
Management Rules:
Rule 1: Endpoint - /v2/variants/{variantId}/studies
Rule 2: HTTP Request Method - GET
Rule 3: HATEOAS, with filer, sorting, pagination, and sizing
Rule 4: Endpoint should accept filter, and sort parameters as in /studies?accession=...&page=0&size=20&sort=...
Rule 5: Search filter should be available for: accession, reported-trait, trait, background-trait, discovery-sample-number, replication-sample-number
Rule 6: Sort feature should be available for: discovery-sample-number, replication-sample-number, association-count, summary-statistics
Rule 7: Returned Study Json entity must include: Study accession, Reported trait, Trait, Background trait, Discovery sample number and ancestry, Replication sample number and ancestry, Association count, and Summary statistics Availability
Acceptance Tests:
Given no parameter
When the front end sends a GET request to the endpoint
Hateoas compliant list of studies is returned in the specified JSON Format
Given sorting, pagination, and/or some search and filter parameters
When the front end sends a GET request to thesame endpoint
Hateoas compliant filtered list of studies satisfying the conditions in the url parameter must be returned

Development almost complete , local testing in progress. Couple of points to be noted

The API access logic currently is not optimised it checks each study against the sumstats PI GCST list for checking if sumstats is present or not , instead of that we could cache the Sumstats response & check from cache to avoid memory processing, will. implement this at a later point

On the sorting & searching part w.r.t the Discovery & Replication Sample number unfortunately these fields are not indexed in Solr & are saved as substring of a free text so there is complexity in implementing the search & sort for these , will need changes in Solr schema if we want to implement sort & Search on these fields

@ala-ebi the API details are -:
Uri -> http://gwas-snoopy.ebi.ac.uk:9780/gwas/api/v2/variants/{variantId}/studies
Search fields
` @JsonProperty("accessionId")
private String accessionId;
@JsonProperty("reportedTrait")
private String reportedTrait;

@JsonProperty("efoTrait")
private String efoTrait;

@JsonProperty("bgTrait")
private String bgTrait;`

Sort fields  -:
associationCount fullPvalueSet


add jsdoc for libs

this is minor update.

add jsdoc for libs.

Codecov Report
Patch and project coverage have no change.

Comparison is base (1e20e1a) 98.64% compared to head (c56e22f) 98.64%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   98.64%   98.64%
=======================================
  Files          15       15
  Lines        1919     1919
  Branches      324      324
=======================================
  Hits         1893     1893
  Misses         25       25
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Show if someone is following you

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When I go to someone's profile, I see "Following" but nothing like "Mutuals ' if they follow me back
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would like some sort of wording that an account is following me. Thank you.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Oops. Scratch that. I just saw "Follows You" left justified


Bug: last is not defined

The "last" variable seems to be undefined 🤔
https://github.com/RainbowJM/real-time-web/blob/672e50144667d2b8ea743eb7646ef94c54828a6f/public/js/script.js#L172

thnx u fixed it


FEATURE - Follow a particular user

Describe  feature .
I'd like to add a feature i.e following a particular user which will include:-

endpoint on the backend to add a follower to a user
route on the client-side to fetch a user and see his profile.
route on client-side to show all followers of a particular user
making changes in DB accordingly

Additional context
@rockingrohit9639  @kanak22 , I'd like to work in it , please assign :)

Go ahead

@naveen8801 any updates on this?

I'd like to work on this issue

Go ahead :)


summary plot not working with matplotlib v3.6.0

shap v0.41.0 is throwing an error when used in conjunction with matplotlib v3.6.0. It works with versions v3.5.3 and below.

Am not sure how to resolve the issue other than fixing the older version.

I'm observing the same issue with matplotlib 3.6.0.

I am having exactly the same issue!

Here is a workaround using the plotly express method strip. The dataframe df_shap includes the attribute columns and columns containing the shap values for those attributes. The list important_features contains the features/attributes ordered from most imported to least important.
def summary_plot(df_shap):
    list_ = list()
    for col in important_features:
        df_temp = df_shap.copy()
        if df_temp[col].dtypes in ['int', 'float']:
            df_temp['feature_value_quantile_bin'] = pd.qcut(df_temp[col], q=[0, .2, .4, .6, .8, 1], labels=False)
        else:
            df_temp['feature_value_quantile_bin'] = -1
        df_temp['attribute'] = col
        df_temp['shap_value'] = df_temp[f'shap_value_{col}']
        list_.append(df_temp[['attribute', 'shap_value', 'feature_value_quantile_bin']])

    df_ = pd.concat(list_, axis=0)
    df_ = df_.sort_values(['feature_value_quantile_bin'], ascending=False)

    fig = px.strip(df_, x='attribute', y='shap_value', color='feature_value_quantile_bin',
                   category_orders={'attribute': important_features},
                   title=f"Summary plot for metric {metric_of_interest}", width=1000, height=600)
    fig.show()


Allow required affinity for typha [Pick 1286 1307 to r1.14]

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

Trying to refresh license/cla


Change the porrectus compound to be diagonal at the end

Similar to the scandicus / podatus issue, when the last two notes are one pitch apart they should be diagonal not vertical.

Fixed in 43fba2b


Create demo external report

This adds a demo external report running on AWS Lambda configured with SAM.
This report has been deployed to https://learn-report.staging.concord.org/report/learner and https://learn-report.staging.concord.org/report/user, and is visible as the button "External Report Demo (query csv)".
Given a filter, this report simply prints the query parameters as CSV.

Sorry for the delay on this. Would you like master merged into this before the PR is approved?

This looks good to me. I made a new story to address issues of documenting how to deploy one of these SAM applications to both staging and production:
https://www.pivotaltracker.com/story/show/178201633


WIP Create AWS subnets in terraform

Drop aws-private config and extract useful parts from it
Manage (and tag) subnets
Derive randomized CIDR subnet block from VPC CIDR
Create (and tag) routing table
Strict firewall that deny everything but members of own security group
Add bastion host
Replace NLB with ELB
Drop public IPs from outputs to force connection to private IPs
Add "MachineDeployments" in every AZ
Configure controller-manager with cluster-name

Fixes #502
aws terraform example configuration is now creating subnets

smaller part of #728

/retest

So, terraform v0.12.10+ is required.

subnet CIDR conflict
/retest

/retest

/retest

random CIDR collide
/retest

@xmudrii in order this to pass new e2e images have to be build and integrated to prow

/test pull-kubeone-test

/test pull-kubeone-lint

/retest

/retest

/retest

/retest

/retest

/test pull-kubeone-e2e-aws-conformance-1.16

/test pull-kubeone-e2e-aws-conformance-1.16

/test pull-kubeone-e2e-aws-conformance-1.16

/retest

/test pull-kubeone-e2e-aws-conformance-1.16

/test pull-kubeone-e2e-aws-conformance-1.16

/test pull-kubeone-e2e-aws-conformance-1.16

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/test pull-kubeone-e2e-aws-conformance-1.16

/test pull-kubeone-e2e-aws-conformance-1.16

/retest

/test pull-kubeone-e2e-aws-conformance-1.15

/test pull-kubeone-e2e-aws-conformance-1.16

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest


:sparkles: Onboard konflux to main

Summary
onboard konflux on main branch by following this document: https://docs.google.com/document/d/1SWKV-9xBYKx6qIQZrJv58yP34s5LMh-pXbOx9BoJiKI/edit#heading=h.u2orph60mc1u
Related issue(s)
Fixes #

/lgtm


Adding more Geonames Feature codes

Hi there,
I'm using your fantastic package and would like to ask you for adding (or pointing out if there is already some possible solution without changing the package) more Geonames Feature codes. Currently the package supports codes like these:

PPL
PPL...
ADM1
ADM2

However, I need also support for other codes like:

PARK
MT
HLL

More listed here: http://www.geonames.org/export/codes.html ↗
I have tried to extend CitySeeder (adding new codes into array $featureCodes), but it does not seem work even with updated filter method.
My code from /database/seeders/Geo/CitySeeder.php:
<?php

namespace Database\Seeders\Geo;

use App\Models\Geo\City;
use Illuminate\Database\Eloquent\Model;
use Nevadskiy\Geonames\Seeders\CitySeeder as Seeder;

class CitySeeder extends Seeder
{
    protected static $model = City::class;

    protected $minPopulation = 5000;

    /**
     * The allowed feature codes.
     *
     * @var array
     */
    protected $featureCodes = [
        FeatureCode::PPL,
        FeatureCode::PPLC,
        FeatureCode::PPLA,
        FeatureCode::PPLA2,
        FeatureCode::PPLA3,
        FeatureCode::PPLS,
        FeatureCode::MT,
        FeatureCode::HLL,
    ];

    /**
     * Get a new country model instance.
     */
    protected function newCountryModel(): Model
    {
        return CountrySeeder::newModel();
    }

    /**
     * Get a new division model instance.
     */
    protected function newDivisionModel(): Model
    {
        return DivisionSeeder::newModel();
    }

    protected function filter(array $record): bool
    {
        // Change filter to accept also hills and mountains
        if (
            // cities above given minPopulation
            (
                in_array($record['feature code'], $this->featureCodes, true)
                &&
                strpos($record['feature code'], 'PPL') !== false
                &&
                $record['population'] >= $this->minPopulation
            )
            ||
            // or mountains and hills - minPopulation is irelevant
            in_array($record['feature code'], ['MT', 'HLL'])
        ) {
            return true;
        } else {
            return false;
        }
    }
}

Adding support for more Feature codes would make this package even more useful and flexible.
Thank you for creating and maintaining this great package.
Wishes,
Pavel

Hi @nesmrtelny. Unfortunately, currently have no time to look into it. It should work fine from what I see on the provided code. The only place where cities can be filtered is that filter method.

I also have an app that uses custom feature codes and there is no problem. So I do not even know what to recommend in this case...

Thank you @nevadskiy for the response and confirmation the provided code should work. I will test it again and I am closing the Issue. Cheers!


Consider using time_block instead of B internally

What and Why
Some places using time blocks in the code use B (like for B in graph[u, v].partitions[rp]). Some use time_block. Since B is not always clear, as opposed to a in A or a in labels(graph), which is a bit more intuitive, I recommend using time_block instead.
Possible Drawbacks
No response
Related Issues
No response

I agree - we should be consistent (not name the same thing twice) and time_block is more clear.

Better to wait until #456


Add traits to ValidatorConfigResource

The Clone trait is needed for ChainClient trait in AOS.

@bors-libra r=dmitri-perelman

:pushpin: Commit ea46629 has been approved by dmitri-perelman

:hourglass: Testing commit ea466298eda41ba3b53a43c537505885a51b71f7 with merge 0711de51463455a21ef96b7e515a38d13b9ad0d0...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: dmitri-perelman
Pushing 0711de51463455a21ef96b7e515a38d13b9ad0d0 to master...


Android Manifest problem

A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade

Android resource linking failed
C:_SVN\STAGE2021\OmraneMobile\omranMobile_branch\build\contacts_service\intermediates\library_manifest\debug\AndroidManifest.xml:11:5-24:15: AAPT: error: unexpected element  found in .

basically i just put the permissions needed in my app manifest and imported the API in my pubspec.yaml file
the generated build manifest throws this error.

it appears that this exception is thrown because of my old gradle.build version.
following this thread, the error is fixed.


Custom workspace directory

Validations

[ ] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
The workspace directory path  (/<home>/.continue, currently) does not seem customizable.
It would be desirable, e.g., when facing storage problems though.
Solution
If not already implemented (if so, how?!), it would be very nice to have the possibility (e.g., via a corresponding environmental variable) to define a custom workspace root directory, other than /<home>/.continue .

Hi @karqo , appreciate the feedback here. This would introduce a decent amount of complexity so I'm not sure if we'll tackle it in the near term, but it's good to know that you'd find value in making this configurable.

In the meantime,
it has turned out that this actually seems to be already working via setting the environmental variable CONTINUE_GLOBAL_DIR appropriately ...

Ah yes good point, we use that for testing but don't really expose/document it anywhere. Has that caused any other issues for you so far?

No, so far, I did not recognize any side effects yet, that I would relate to this matter.


Expanded use of LangChain features - tools, etc.?

Thanx for creating such a good ai dev aide. I know GE is using LangChain for LLM abstraction, which is great. Can you expand GE functionality to add more LangChain features like external tools, etc? Eg., to allow web searching, GitHub repo access, chat with private documents, etc.
Is there any interest in the GE community for this?

This sounds interesting! PoC:s welcome.
Would be great to start with an important problem to solve for users and then see what tools we need for this.


Add speed layer to process measurement in less than 1h

Currently the ooni/pipeline has a 24h batch process which is used to compress measurement for long-term archival (canning), extract features to go into the DB (centrifugation) and then expose these in OONI API.
This means that from the moment a user runs an experiment, to them moment they are available in OONI API (and hence OONI Explorer) it can take up to 24h.
One thing that we were discussing was the possibility of having a speed layer, which processes measurements as soon as they are submitted to the collector. This would allow us to at least expose some basic metrics for submitted measurements (at least show the file and acknowledge their existence).
Some more advanced features that are harder to do in real-time (for example sim-hash detection or other more sofisticated heuristics), don't necessarily have to happen here.
This would be especially useful for: https://github.com/ooni/probe/issues/816

@hellais isn't this done?

Yes it is! yay!


tests: subsys: settings: fix pointer mismatch on 64-bit targets

This fixes the following error:
passing argument 5 of ‘fsutil_read_file’ from incompatible pointer type

@ioannisg can be merged

@ioannisg can be merged

@nvlsianpu backport this?

sure

sure

We will need an issue for that


Update showcase.md

not my site but its built with v4 and has good content so worth having on the showcase.

I think I'm going to keep the site showcase a bit more professional, it seems more personal


RSA Encryption Level Option

Is your feature request related to a problem? Please describe.
Probably, because I'm unable to install the certificate generated to a Free Hosting Service like InfinityFree, it says the private key encryption is over 2048 bit. I'm using Buypass.
Describe the solution you'd like
I hope that there will be an option to choose between 2048 and 4096 bit encryptions so it will be compatible.
Describe alternatives you've considered
Use InfinityFree's SSL Generation, but those are only 90 day certificates, I want 180 day one (Buypass).
Additional context
Screenshot https://imgur.com/a/3tSFMNx

You need to specify your preferred key size in your settings.json (RSAKeyBits) : https://www.win-acme.com/reference/settings

Oh Sorry, I saw that now.