Add paragraph about ATOMIZER WEB

ATOMIZER WEB is the online tool built by Pankaj

I'm not sure if this belongs at the top of the reference page - it might be a better fit under something like our "integrations" section...

@src-code
"integrations" section? Where is that? Do you mean on the "Atomizer Tool" page?
If I can't easily find it, it may not be the best place for it...
In my opinion, it should be in people's face because it is a tool that can really help people figure things out quickly. Originally, I even planned to use some kind of fancy button rather than a simple link—to make sure people don't miss it.
I really dig that tool and I think we should make sure it has good visibility.
If it was just me, I'd even find room on the home page for it!

If it's for good visibility, I recommend adding the Integrations to the top nav bar and making it a separate page.

test: ignore
This is a test as I do not receive any notification for this repo.
Checking if adding my handle changes anything: @thierryk

@src-code could you merge for now, until we find it a better home?
Or copy/paste the paragraph I added anywhere you want.
(I think it's better to have it somewhere than nowhere at all)

@thierryk Promise I'll get this one sorted out in the next couple of days.  Been busy with some other work and haven't had time to think through how to best organize stuff like this, but I'll get to it!

Closing this one in favor of #104

@src-code please check my comments following your commits


Get-WTCurrentRelease $wtsettings.refresh() error: "You cannot call a method on a null-valued expression."

Receiving the following error:

I wonder if this is because you are using an out-of-the-box profile. What does your settings.json file look like for this profile?

If you run get-variable wt* you should see 4 values.
WTDefaults
WTDefaultsPath
WTSettings
WTSettingsPath
Do you?

You might also run import-module wttoolbox -force -verbose and look for any Verbose messages that show 'Failed'

Here's my settings.json file, which isn't far from the default:
settings.zip

There are no WT* variables defined according to get-variable wt*

There is a failure accessing settings.json with Import-Module -Name WTToolBox -Force -Verbose:

VERBOSE: Testing for settings.json
VERBOSE: Using path C:\Users\gcarr\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json
VERBOSE: Failed to find C:\Users\gcarr\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json

Complete output:
WTToolbox-Verbose-Import-Module.txt

This is helpful. Somne followup questions:

Does C:\Users\gcarr\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json actually exist and have JSON content?
How did you install WindowsTerminal? From the MS Store? Winget? This module?
Did you install the stable or release version of Windows Terminal?

Confirmed the problem when running the preview version. Working on it.

Yes, it's the preview.  As you know now, the settings.json doesn't exist.  Installed from MS Store.
Thanks,
Glenn

I just pushed v1.12.0 to the PowerShell Gallery. Update the module and try again.

Works great - thanks!

This is a good reminder that I need to include the Preview build in my testing.


Option to download all reach and node data for a given reach using one call

Right now, we are grabbing the features we need for a reach, then doing separate calls to grab those features for each node in the reach. It would be great for the number of calls, speed, and AWS costs on our end to be able to submit a request and get all of the reach and node data back. Please comment if this is not the standard format for feature requests and I will update the issue.

Thanks @Travis-Simmons - I can see this being possible in two ways, curious what you expect/prefer to see:

both the reach feature and the node features returned together in the same featurecollection (are you using geoJSON or CSV output type)? This would likely be a change to the feature=Reach behavior to maybe have a flag or a special field that indicates 'return all nodes for this reach as well as the reach specified'
an option when querying nodes to query by reach_id instead of node_id? (A change to the feature=Node behavior, would not return the reach data so would still require 2 queries on your end)

@nikki-t I think both options would require setting up another GSI on the nodes table to allow querying by reach_id, though it looks like node_id contains the reach_id of the associated reach, so maybe there's some tricky ways around this by doing something like using the granuleUR output from the reach query to find the associated node granule, and filtering to the right node features by allowing a partial node_id to be entered. We'll need to do a feature analysis to sort out the details.

The first option is exactly what I am looking for! If I could do the equivalent of something like feature=Reach&Node and get the csv (we are using csv) returned for all of the nodes and the reach that would be perfect.


Improve doc comments for host functions/conditions.

Also put SWIG hostfn callbacks behind macros (to reduce confusion for those who read headers, hence why this depends on alternate_array_interface branch).
Closes #268
Closes #270
Any further detail will need to go in the userguide.

Currently failing because the ifdef'd away functions aren't being built into the lib.
Need to either move them into the header, or turn on SWIG macro when building lib and pyflamegpu is enabled.


Add support for all existing stm32f4 devices

This patch series adds support for every existing stm32f4 devices. It is not complete yet. Serial and I2C still needs to be done. Moreover, it requires a new release of the stm32f4 crates for some devices.
Anyway, you may still want to merge the patch series, except for the last patch, which is the one actually enabling all those new devices.

Oh, indeed, it was probably not a good idea to include last patch in this pull request.
It is removed now, so this PR should be mergable.
Patch to actually enable all devices is still available here: https://github.com/aurelj/stm32f4xx-hal/commit/f92579b


feat: downloads widget

Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

[ ] Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
[ ] Pull request targets dev branch
[ ] Commits follow the conventional commits guideline
[ ] No shorthand variable names are used (eg. x, y, i or any abbrevation)

The build error is happening because of a upstream dependency issue with crypto-hash, that we provided a suggestion to fix it in the used dependency for qBittorrent: https://github.com/scttcper/torrent-file/pull/77


Changed GIFs to static images

Docs Build status updates of commit 56d8a51:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/visual-studio-code/index.md
:warning:Warning

Details

microsoft-edge/visual-studio-code/index.md

Line 32: [Warning] Invalid file link: './media/debugger-for-edge.png'.
Line 40: [Warning] Invalid file link: './media/elements-for-edge.png'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Closing as duplicate of #pr560.


Add johna.is-a-fullstack.dev

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

For my personal site
Website Link / Preview

johna.vercel.app

Cloudflare Pages doesn't seem to support subdomains

If i'm using Clouldflare Pages, there's a name and value for the CNAME record.
Would I have to add the name in the CNAME record like this?
"records": {
    "CNAME": {
        "name": "name",
        "value": "value"
    }
},

Or should it just be the value like this:
"records": {
    "CNAME": "value"
},

It would be like this:
"records": {
    "CNAME": "value"
},


Any ways to make specific weapons consume more stamina?

I made tools like pickaxe, hoe, shovel to work like weapons, and they consume a very small amount of stamina while attacking for 5.5 damage (especially shovel), so I want to find a way to make them more stamina expensive.

I'll be adding datapack support in the next update to fix this.

Cool! Good luck on development

Coming in V0.5.0!


Add useScaffoldEventHistory hook

useScaffoldEventHistory hook allows to get the events from a contract.
Only contractName and eventName are mandatory.
You can choose if you want to get the block, transaction or receipt data with the blockData, transactionData and receiptData flags. Default to false to avoid RPC calls.
fromBlock default value is set to 1000 blocks before the current block. Edited: fromBlock is mandatory now.
If you want to get all the events from the contract, set it to the block number when the contract was deployed.
Use filters to filters the events by the indexed parameters.
Example usage:
  const { data: events, isLoading: isLoadingEvents } = useScaffoldEventHistory({
    contractName: "YourContract",
    eventName: "Withdraw",
    fromBlock: 0,
    blockData: true,
    transactionData: true,
    receiptData: true,
    filters: {
    	to: "0x5dCb5f4F39Caa6Ca25380cfc42280330b49d3c93",
    }
  });

The events are not re-fetched automatically. If you want to keep the events data updated, you have to call the hook again.
Should we add support for automatic re-fetching on the hook?
closes #142

Hey @damianmarti , thanks for the PR. This hook looks really useful! Made some small comments/suggestions for additional improvements, but it's already looking good so far! :+1:

Hey @damianmarti , thanks for the PR. This hook looks really useful! Made some small comments/suggestions for additional improvements, but it's already looking good so far! 👍

+++ Tested it and works really nicely, Damu always nails it !!

Some thoughts :
Don't know how easy/hard would it be to add watch : true / pollTime which which fetch onBlock or on the interval mentioned similar to useEventListnerHook in se-1. I see there they are using useQuery which gives the power of pollTime by default which we might to think a bit and do it with raw setInterval (I don't have any idea just thinking out loud ).
Nevertheless I even really like current version of this hook and solves a lot of things already.

Hey @damianmarti , thanks for the PR. This hook looks really useful! Made some small comments/suggestions for additional improvements, but it's already looking good so far! +1

+++ Tested it and works really nicely, Damu always nails it !!
Some thoughts :
Don't know how easy/hard would it be to add watch : true / pollTime which which fetch onBlock or on the interval mentioned similar to useEventListnerHook in se-1. I see there they are using useQuery which gives the power of pollTime by default which we might to think a bit and do it with raw setInterval (I don't have any idea just thinking out loud ).
Nevertheless I even really like current version of this hook and solves a lot of things already.

I think that maybe I can finish the hook without the watch feature, merge it, and then I can try to add the watch feature if we want. What do you think?

Thanks for all the feedback!!
I already made the changes, please let me know if there is something else to improve! Thanks!

I think that maybe I can finish the hook without the watch feature, merge it, and then I can try to add the watch feature if we want. What do you think?

Yes yes, even the current state of hooks is really helpful and great

Added my last comments. I think after that it should be good for me :+1:
Nice work, @damianmarti
@carletex would be good if you had a look at this as well. Nice hook to add to the project, I think

@carletex would be good if you had a look at this as well. Nice hook to add to the project, I think

@sverps Oh yes, sorry I didn't say anything before. Damu implemented this for https://github.com/BuidlGuidl/hacker-houses-streams, a project where we needed to list historical events...and told him to make a PR here!
So @sverps || @technophile-04 feel free to merge when ready!

And great work @damianmarti <333

So @sverps || @technophile-04 feel free to merge when ready!

Merging this, look really awesome 🚀 !!


Warning System

Convert over to our own custom warning system. We would create a WarningManager class that would manage warnings and the SQL connection. We would have to take in SQLManager in our constructor so we could grab the connection that way.
^warn
^delwarn
^warnings
All helper commands
For warnings use a string builder and a result set
Also on ^warn make an embed in #log

Be sure to use PreparedStatements to avoid SQL Injection issues

@Techno-coder Absolutely, as we are not validating input and it is raw text, that would be a must.


Question: Return all tasks, in every queue, including other users

Hello
Great Repository, thanks very much for sharing.
I cant find in the IBM literature how to return all tasks, in every queue, including other users "Inbox", do you know to do it with P8BPMREST ?
queryFlags=1 only returns locked and unlocked work items, but not work items in other users own Inbox queue...
I know WorkplaceXT can list all tasks.
Any help or guidance would be appreciated
Thanks, regards, Kieren.

Hello Kieren,
Thanks for the complements, is really good to know that this repository is been helpful.
About your question, as far as I concern and also read until now, I believe that is not possible to retrieve all tasks with P8BMPREST. Since we are authenticating the user, only "user permitted (related)" tasks (work items) or queues are possible to fetch.
Like you, I'm still stuck here using Process Administrator over WorkplaceXT to access work items from other users. This is probably a limitation with the REST API.
If I ever get to confirm this in any documentation, I'll be glad to share.
Best regards,
Wanderley


Allow for first route parameter containing slash

Angular implicitly splits segments given in the first passed-in value of routerLink's array when it contains slashes. This causes a bug when the first configured route parameter contains value with slashes (i.e. product name Camera Lenses f/1.8).

QA steps:

in app.module change configured path for product page to contain :name as first param:

    routing: {
        routes: {
          product: {
            paths: [':name/product/:productCode'],

go to the list of camera lenses:

click the name of the product containing slash:

verify that you are in PDP page of this product

Works!


Service Instantly Closing After Opening

I am trying to run the Service exe with no luck. CMD pops up for a second and completely dissapears. W10 22H2

You should not be running the service executable directly. The service is automatically ran in the background.


adding support for grammar SLD

Per https://github.com/Glavin001/atom-beautify/issues/762

Published to v0.28.22


Error when trying to save Metadata

Hi All
I couldn't find an issue regarding this error.
StableSwarmUI Version <IP_ADDRESS>
A error occurs when I try to do the following:
Lora Tab > Click on Burger Menu in a Lora > Edit Metadata > Click Save in new Pop-Up Window
Console Log:

[Error] [WebAPI] Error handling API request '/API/EditModelMetadata': Internal exception: System.NullReferenceException: Object reference not set to an instance of an object.
at StableSwarmUI.WebAPI.T2IAPI.EditModelMetadata(Session session, String model, String title, String author, String type, String description, Int32 standard_width, Int32 standard_height, String preview_image, String usage_hint, String date, String license, String trigger_phrase, String tags, String subtype) in C:\Users\AI\Documents\AI\stableswarmui\5.8\StableSwarmUI\src\WebAPI\T2IAPI.cs:line 514
at StableSwarmUI.WebAPI.API.HandleAsyncRequest(HttpContext context) in C:\Users\AI\Documents\AI\stableswarmui\5.8\StableSwarmUI\src\WebAPI\API.cs:line 145

Line 514 in T2IAPI is:
actualModel.Metadata.PreviewImage = preview_image;
Seems it has something to do with the preview image
Happy to provide more infos if needed!
EDIT: Additional Info
When I toggle off Save Image in the Metadata Editor I don't get an error and the Image and Description will be saved. But when I refresh the Lora Library, the changes are gone.

Oh, no, that was a minor code bork, fixed^
If saving fails again after updating, let me know.

Oh, no, that was a minor code bork, fixed^
If saving fails again after updating, let me know.

Glad it was only a minor issue! Thanks for your fast help.
I pulled the repository and tested it again. Now the image is added without an error but unfortunately it's not persistent. Once I refresh or restart stableswarm, the Info (and image) is gone from the Metadata.
I don't see any logs when saving the metadata. Is there a debug argument I can set when launching stableswarm?

For debugging, You can go to Server -> Server Configuration and edit LogLevel to Debug
I realized that if there was an error saving the model after metadata edits it could be swallowed silently, and pushed a commit that makes sure it gets logged.

For debugging, You can go to Server -> Server Configuration and edit LogLevel to Debug
I realized that if there was an error saving the model after metadata edits it could be swallowed silently, and pushed a commit that makes sure it gets logged.

EDIT:
After writing this below I discovered something:
When I'm in the Models tab and I use the file browser (in the gui on the far left) to navigate to the Lora folder and edit the metadata there, everything is saved and persists after a refresh. But when I'm in the Lora Tab the changes are still not shown even after a refresh.
I have a custom folder structure where the .safetensors are outside the StableSwarm folder (could this have something to do with it?)
ModelRoot C:\Users\AI\Documents\AI\Models-Stable-Diffusion
SDModelFolder Model
SDLoraFolder Model/Lora
/EDIT
Thanks for pointing me to the Log-Settings location (totally missed it)
I made two tests:

Edit Metadata without generating an image first.
Edit Metadata after generating an Image first while using the LoRa I want to edit.

In both cases clicking on Edit Metadata and Save doesn't provide any Log in Debug or even Verbose .
After editing the Metadata when I hit the refresh button, the following Debug Log is generated:
[Debug] Model Lora/add-detail-xl.safetensors seems to match type Stable Diffusion XL 1.0-Base LoRA
after that it resets all entries of the Lora.
Thank you for all your hard work. StableSwarm is the only tool which generates consistent outputs for me (propably due to the ComfyUI backend).

Oh - your loras should not be in your Stable Diffusion models folder, they should be two separate folders.

Can confirm - that was the issue. Now everythings works smoothly! In the end it was an user error (sorry!)


ClapJuceWrapper::process_clap_event: handle CLAP_EVENT_MIDI_SYSEX

Pretty straightforward. WFM when patched into dexed.

Oh thanks! I just activated ci for you since you are first time. Looks good to me though and if ci works I will merge!

Ahhh looks like we need an explicit cast on linux with some compilers and some juce versions. I’ll take a peek today if you don’t get to it.

OK you submitted the PR without checking the 'maintainers can push to branch' it seems? Or at least: I can't push to your branch :)
diff --git a/src/wrapper/clap-juce-wrapper.cpp b/src/wrapper/clap-juce-wrapper.cpp
index 2b1ca2a..be638a9 100644
--- a/src/wrapper/clap-juce-wrapper.cpp
+++ b/src/wrapper/clap-juce-wrapper.cpp
@@ -1577,7 +1577,7 @@ class ClapJuceWrapper : public clap::helpers::Plugin<
         case CLAP_EVENT_MIDI_SYSEX:
         {
             auto midiSysexEvent = reinterpret_cast<const clap_event_midi_sysex *>(event);
-            midiBuffer.addEvent(juce::MidiMessage(midiSysexEvent->buffer, midiSysexEvent->size,
+            midiBuffer.addEvent(juce::MidiMessage(midiSysexEvent->buffer, (int)midiSysexEvent->size,
                                                   midiSysexEvent->header.time),
                                 (int)midiSysexEvent->header.time - sampleOffset);
         }

I think that is the diff you need to apply to make CI work. I was going to push it up but can't push here.
Thanks

Thank you! Merged.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 109964f, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 8118 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 1289a9f after 11 minutes.


ign -> gz Header Migration : ign-utils

Test run of https://github.com/ignition-tooling/release-tools/pull/712

I would consider combining the changes from https://github.com/ignitionrobotics/ign-utils/pull/53/commits/26f1a897d915e09cff0c1c1e89f5ae15d7d7d441 and https://github.com/ignitionrobotics/ign-utils/pull/53/commits/e3de70a93f2e3c434b39c669ca7f468f326a2284 into a single commit that adds the redirection headers

I would consider combining the changes from 26f1a89 and e3de70a into a single commit that adds the redirection headers

Done! The script now amends the previous commit (we need a previous commit to check for copyright changes so we can unpatch them.)
https://github.com/ignition-tooling/release-tools/pull/712/commits/84577403ebfb012ddeae167e50677d06c7acda14

there is a redirect header missing for ignition/utils/detail/Export.hh

https://github.com/ignitionrobotics/ign-utils/pull/55/commits/3ecdccbb554569bbd9b4f65338d936aea2de8009


Update configuration for PyData Sphinx Theme

This updates a few of our design and theme configuration for an upcoming release of the PyData Sphinx Theme

Updates to the latest pydata theme. closes #264
TODO: remove the noxfile install of @main when a release is out.
It adds a dark / light logo
It updates the structure of the logo to not be quite as wide. Also found a bug in header spacing, will be fixed by: https://github.com/pydata/pydata-sphinx-theme/pull/788
It also adds some documentation and a noxfile for building the docs. closes #266

This is ready to go - @consideRatio could I get a quick review and/or approve so we can iterate further? :-)

Nice!!


showTextDocument returned the wrong editor when called multiple times concurrently

It seems like there may be some race condition in showTextDocument where if it's called multiple times before the previous has completed, each call returns the last editor to be opened.
Here I have an array of two items short_test.dart and short2_test.dart and I call openTextDocument and showTextDocument for each. However the resulting editors both point at short2_test.dart:

The results from openTextDocument are correct in both cases, it's only showTextDocument that seems to be misbehaving.

I cannot copy-paste a screen shot into the editor to reproduce this. If you already make a repo how about sharing its full source code?

nvm - that should be thrown as error... Tho, that will also be the only possible fix, e.g checking that the editor is for the desired document and throw iff not. The fastest will win...

Not anywhere I can find. I checked in both the main VS Code window, and the extension host it spawns to run the test, including the DevTools there (I added a delay to stop it closing after the code ran):

I have seen those errors in the past, but I think they resulted in showTextDocument rejecting rather than returning the wrong result.

Out of interest, what's the cause of this? Why can't VS Code handle multiple requests like this? As an extension author, it seems like one request blocking behind the other would be much preferred than it just throwing. I actually have seen those errors in tests before, and have a helper that retries myself:
	try {
		return await vs.window.showTextDocument(doc);
	} catch (e) {
		logger.warn(`Failed to show ${fsPath(file)} on first attempt, trying again...`, LogCategory.CI);
		logger.warn(e, LogCategory.CI);
		return await vs.window.showTextDocument(doc);
	}

(it didn't work here because the call resolved successfully though).

I still end up with two "editors", even though presumably the first one no longer exists?

Yes, the first editor has then gone stale. That can always happens, like have a single editor reference and the user closes that. We guarantee that events are send to get this right but we cannot force extensions be correct. For text documents we have isClosed but we don't anything like that for editors, it would basically be vscode.window.visibleTextEditors.includes(someEditorReference)

There is actually an underlying bug in the workbench logic, when an editor for A is already open and two requests for A and B come in than B opens A.

adjust and run the commands from above (https://github.com/microsoft/vscode/issues/134786#issuecomment-940021250)
close all editors, all good
keep the one editor open -> bad

diff --git a/src/vs/workbench/api/browser/mainThreadEditors.ts b/src/vs/workbench/api/browser/mainThreadEditors.ts
index d458ccae1ac..e4727bcfd84 100644
--- a/src/vs/workbench/api/browser/mainThreadEditors.ts
+++ b/src/vs/workbench/api/browser/mainThreadEditors.ts
@@ -151,11 +151,12 @@ export class MainThreadTextEditors implements MainThreadTextEditorsShape {
 			resource: uri,
 			options: editorOptions
 		};
-
+		console.log('BEFORE', uri.path);
 		const editor = await this._editorService.openEditor(input, columnToEditorGroup(this._editorGroupService, options.position));
 		if (!editor) {
 			return undefined;
 		}
+		console.log('AFTER', uri.path, 'ACTUAL', editor.input?.resource?.path);
 		return this._documentsAndEditors.findTextEditorIdFor(editor);
 	}

@jrieken even when all editors are closed and I run the command for the first time, I see this:
BEFORE /Users/bpasero/Desktop/test-ts/src/extension.ts
mainThreadEditors.js:113 BEFORE /Users/bpasero/Desktop/test-ts/.eslintrc.json
mainThreadEditors.js:118 AFTER /Users/bpasero/Desktop/test-ts/src/extension.ts ACTUAL /Users/bpasero/Desktop/test-ts/.eslintrc.json
mainThreadEditors.js:118 AFTER /Users/bpasero/Desktop/test-ts/.eslintrc.json ACTUAL /Users/bpasero/Desktop/test-ts/.eslintrc.json

I am not sure the intended outcome, but I assume you had expected that the result of:
https://github.com/microsoft/vscode/blob/64081da3c8c12eddc28eaff05672fe9515e7e502/src/vs/workbench/api/browser/mainThreadEditors.ts#L156
Is matching the resource you pass in, but that is not guaranteed. The return type of openEditor is IEditorPane which is the actual container of the code editor. And we do not allow to have 2 code editors open at the same time unless you have multiple groups, so the first openEditor call will get cancelled from the second openEditor call. You still get a valid IEditorPane back because the pane is still the code editor container, but the input of that pane will be the last thing that was successfully opened.
I am not sure how to improve this, throwing an error does not seem like a wise idea.
Any suggestions?

I pushed a change to return undefined when openEditor operation is cancelled by another operation.
Given the sample code in this issue, I see that we now throw an exception back to the extension:
ERR [Extension Host] Error: Could NOT open editor for "file:///Users/bpasero/Desktop/test-ts/package.json".
	at ExtHostEditors.showTextDocument (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/common/extHostTextEditors.js:69:23)
	at processTicksAndRejections (internal/process/task_queues.js:93:5)

Originating from:
https://github.com/microsoft/vscode/blob/f523f65f3985eb6493cae5d219de35f1d7ba6f7a/src/vs/workbench/api/common/extHostTextEditors.ts#L91
I suppose extensions had to deal with this error before already as it is not a new error, but it may appear now in more cases.

@bpasero in latest Insiders, I actually don't see the exception - everything seems to work fine. I tried writing it several different ways, including for ex.:
const testFiles = [
	vs.Uri.file("/Users/danny/Dev/Dart-Code/src/test/test_projects/hello_world/test/short_test.dart"),
	vs.Uri.file("/Users/danny/Dev/Dart-Code/src/test/test_projects/hello_world/test/skip_test.dart"),
];
const editor1promise = vs.workspace.openTextDocument(testFiles[0]).then((doc) => vs.window.showTextDocument(doc));
const editor2promise = vs.workspace.openTextDocument(testFiles[1]).then((doc) => vs.window.showTextDocument(doc))
const editor1 = await editor1promise;
const editor2 = await editor2promise;
console.log(editor1.document.uri.toString());
console.log(editor2.document.uri.toString());

But both documents seem to be returned as expected:
file:///Users/danny/Dev/Dart-Code/src/test/test_projects/hello_world/test/short_test.dart
file:///Users/danny/Dev/Dart-Code/src/test/test_projects/hello_world/test/skip_test.dart

This is ofc better than throwing, although it makes me wonder if I'm not triggering it correctly so not sure if the testing is valid.

Ok thanks for trying, this is probably timing dependent too. I had reproduced it with the sample code running out of sources back when I had tried:
const testFiles = [
	vs.Uri.file("/Users/danny/Dev/Dart-Code/src/test/test_projects/hello_world/test/short_test.dart"),
	vs.Uri.file("/Users/danny/Dev/Dart-Code/src/test/test_projects/hello_world/test/short2_test.dart"),
];
await Promise.all(testFiles.map(async (testFile) => {
	const doc = await vs.workspace.openTextDocument(testFile);
	const editor = await vs.window.showTextDocument(doc);
	console.log(`Opened ${testFile}\nGot ${editor.document.uri}\n`);
}));

Yeah, I tried that one first too, but it also worked (did the thing I wanted, without exceptions). I don't know if that really verifies the fix or not though, but I certainly can't reproduce any bug now :-)


Exporting to image crops of the sides in VS code for MAC

Thanks for building this it's a great tool. I found a Bug where,
exporting an image 3000x3000px the exported area is not correctly centered and parts of the image are cropped.

Only when zooming out the whole area is visible.

It seems to be depending on the viewport. If I have the section in the upper left corner opened it exports the full image.

I think it'll help if there's an image of a case that cuts off.

[](https://imgur.com/a/CFUKxtp)

Thank you. It helped me solve the problem.

Wow you are amazing! Will test the fix on Monday.

Sorry for the late response I just tested and it seems to work like a charm.

Thank you!


How to change?

How can i change the minimize button,maximize button, Close button shapes? I just want to change those three button shapes to other shapes that i had.

To change the icons, replace them on lines https://github.com/dragonwocky/notion-enhancer/blob/master/resources/preload.js#L56 + https://github.com/dragonwocky/notion-enhancer/blob/master/resources/preload.js#L60 (always-on-top), https://github.com/dragonwocky/notion-enhancer/blob/master/resources/preload.js#L67 (minimise), https://github.com/dragonwocky/notion-enhancer/blob/master/resources/preload.js#L73 (maximise), and https://github.com/dragonwocky/notion-enhancer/blob/master/resources/preload.js#L89 (close).

how do you guys get the text format of this buttons. I had in the png format. or recommend sources that you guys used.

@maheshthedev these buttons are not images. They are unicode characters/symbols.


Set default minimal width of buttons to zero

Seems like GTK labels have no intrinsic minimal width while buttons do. Probably because they should stay clickable with an empty label.
As a result, even if all margins, padding and borders of buttons are removed the label inside the buttons may still be padded if they are too short. Setting the minimal width of buttons to zero fixes this issue.
This PR sets the min-width of buttons to zero in the default config, resolving #1731 for future adopters of Waybar.

Thx


Adds log removal support

Added log removal support for Approval, Transfer, MarketCreated, OrderCanceled, OrderCreated, and OrderFilled events.  @epheph let me know you think if this looks like a reasonable approach to log removal!

Using blockstream, we can also get notified of block removals as well, what do you think of implementing that? The current onNewBlock() code is inelegant (using db.raw). I took a pass at doing a quick fix, but will need to implement real revert detection, not just ON CONFLICT ON CONSTRAINT or the like. Here's the code from the cleanup, (but does not handle reorgs):
https://github.com/AugurProject/augur-node/compare/sbigelow/block-table-knex?expand=1

Ah, I'm not sure if BlockStream emits a special notification for blocks when reorgs happen (@MicahZoltu would prob know).  I think what we'd need to do is, if we ever see a duplicate block number (meaning that a reorg has happened), drop all blocks that are newer than the duplicate block.  The other tables are all updated off of the log notifications, so they shouldn't need manual updating in this case.

@MicahZoltu and i were discussing this yesterday, it does emit block removal notifications.

Oh nice!  Then it should be simple to just write an onBlockRemoved function that removes blocks.  Is it the same as the log notifications, where there's a removed: true field attached to the block, or how's that work?

Yes, our types in general could use a bit of cleanup, I think there's a fair amount of duplication etc. as well.


No favicons in the index.html page

We should rather use a webpack plugin to support stuff like this in my opinion. I am fine with merging #3 but we should leave open this issue and extend it then.
Webpack plugin for favicons.
Vue plugin for changing the meta tags.

Interesting. Was not aware that there was a webpack plugin to generate this (tho I'm not surprised haha). I can configure it and open another PR with that if that is preferred.

It is preferred i think. But let's wait for another opinion. I do not want to decide on this alone 🤔
The meta tag change would require a lot of changes since it needs to be adjusted for every view i guess since the title should be different.

ok... I created a 2nd alternative PR that uses the webpack plugin. That way regardless of what direction people decide to go in... the work is already done :-)
I also removed the color-theme meta tag from the original PR, since that would probably fall under the hole "title tag management" stuff

@igeligel The webpack plugin seems like a great option to generate the appropriate favicons. I'm merging the PR #4 and closing the PR #3


minor: Record attributes in attr_query for proc-macros

r? @jonas-schievink
I assume this was just forgotten but asking can't hurt

bors r+


Add doesNotHaveSameHashCodeAs assertion

Check List:

Fixes #2028
Unit tests : YES
Javadoc with a code example (on API only) : YES

Integrated thanks @lykims! I just did a few minor changes.

Thank you for integrating the changes @joel-costigliola!
The issue https://github.com/assertj/assertj-core/issues/2028 is half resolved. It was suggested to create one PR per assertion.
What's the feedback for this so I could implement doesNotHaveToString?
Should https://github.com/assertj/assertj-core/issues/2028 be reopened?


Please 1.20.1 version

I'm not sure about stability, but simply changing the mc version in the dependencies worked

oh really?
how did you do that?


add my file

Please review and discuss the new slide

created a branch, created a file and made a commit, and opened a pull request
👍

Line 5 is now about Peter Piper that completes a new branch, a commit to change with comments, a push edit for new file, commit new file to branch, and now merge branch back to master


Can't make cards for videos without subtitles

For some reason recently when I try to press ctrl+shift+x or ctrl+shift+c to make cards for videos without subtitles it won't work. Should I reinstall the extensions? I can make the asbplayer popup appear through ctrl+shift+f but ctrl+shit+x afterwards does nothing. Here's a screenshot of my shortcuts.

Edit: For context this is with youtube videos.

@YeezyYeezyWhatsGood So it used to work? Just to confirm, when you use Ctrl+Shift+C or Ctrl+Shift+X the blinking recording icon doesn't appear on the tab and even if you use either shortcut twice, nothing happens?

@YeezyYeezyWhatsGood It was a bug in the asbplayer code that I accidentally deployed a couple days ago. If you can, please let me know that you are no longer seeing the issue.

Thank you for fixing the issue it is all fixed!
P.S. asbplayer has been tremendously helpful in my journey learning Japanese. You are the GOAT!

Great!
And glad it's helping!


Some creep spritesheets cutoff the bottom parts

This makes it look like creeps are partially covered up by the floor.
This is present in both packed and raw versions so this bug doesn't originated from packing script.

Not a bug. Spritesheets are made in such a way so that it looks like a 3d model whose weapon clips through the ground. If there's no clipping then the sprite will look strange, like it's higher than the ground.


Nonsymmetrical GUI

On GUI scale 4 button for viewing server location on map is out of borders and it looks not as good as it could look

Hi, thanks for creating an issue for this! The reason that's happening is likely because a mod, although I might be wrong. If I had to guess, it's likely the mod that adds these two buttons at the top of the screen. Could you provide the name of that mod, so that I can find an approach that works with it too?

Server Browser (https://www.curseforge.com/minecraft/mc-mods/server-browser)
and
Proxy (https://www.curseforge.com/minecraft/mc-mods/proxy-server)

Actually it's none of these mods' fault, it's just that they slightly changed the position of the buttons since 1.19.4...
Mojang really started to hate modders since 1.19
But I'm working on fixing that!

Cool! Thank you for that, I really appreciate the effort you put in this mod

In new version position is ok, thanks for fox

I'm glad it fixed it! As always, if you notice any other problems, please let me know!


[Windows 7] undefined method `default_mime_type=' for Sprockets::JstProcessor:Class

I can't figure out why I have the following error when trying to run rails s on a Windows 7  x64 box:
C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets/jst_processor.rb:5:in `<class:JstProcess
or>': undefined method `default_mime_type=' for Sprockets::JstProcessor:Class (NoMethodError)
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets/jst_processor.rb:4:in `<mod
ule:Sprockets>'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets/jst_processor.rb:3:in `<top
 (required)>'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets/engines.rb:3:in `require'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets/engines.rb:3:in `<top (requ
ired)>'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets.rb:44:in `require'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets.rb:44:in `<module:Sprockets
>'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-2.12.3/lib/sprockets.rb:3:in `<top (required)>'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-rails-2.2.2/lib/sprockets/railtie.rb:5:in `requi
re'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/sprockets-rails-2.2.2/lib/sprockets/railtie.rb:5:in `<top
(required)>'
        from c:/Users/ZFTC0418/Documents/projects/rails_draft/config/application.rb:10:in `require'
        from c:/Users/ZFTC0418/Documents/projects/rails_draft/config/application.rb:10:in `<top (required)>'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/commands/commands_tasks.rb:78:in
`require'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/commands/commands_tasks.rb:78:in
`block in server'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/commands/commands_tasks.rb:75:in
`tap'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/commands/commands_tasks.rb:75:in
`server'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/commands/commands_tasks.rb:39:in
`run_command!'
        from C:/Ruby21-x64/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/commands.rb:17:in `<top (required
)>'
        from bin/rails:4:in `require'
        from bin/rails:4:in `<main>'

Reproduced with the following configuration:

OS: Windows 7 x 64bits
Ruby ruby 2.1.5p273 (2014-11-13 revision 48405) [x64-mingw32]
sprockets version 2.12.3

The Gemfile has the line with therubyracer gem commented:
#gem 'therubyracer', platforms: :ruby

I have node.js installed:
node -v
v0.10.35

and node gem too:
node (0.0.2)

Any idea on how to fix that ? Thank you.

Can you post the version of "tilt" in your Gemfile.lock? 1.4.1 is the latest you should probably have.

Hey, Josh, the titl version in Gemfile.lock is 1.1 (see its complete content at this gist: https://gist.github.com/Javix/efa6192ae995e89db950). One more details I didn't mention: I had to install all Rails related gems locally by downloading them before one by one because of firewall and proxy restrictions applied on the projet (a real headache :) )

I've just deleted the Gemfile.lock fil and re-run bundle install --local. the newly generated Gemfile.lock is different from the previous one, see the new gist: https://gist.github.com/Javix/1430ae66cfca2aa3a6f9. Now I have no problem to start the server rails s. Thank you for your feed back; I'll close the issue.


config is empty Configuration.prototype.load in configuration.js

in node_modules/gulp-jscs/node_modules/jscs/lib/config/configuration.js config is emtpy in Configuration.prototype.load = function(config) {}. This causes:
[19:09:22] TypeError: Object.keys called on non-object
  at Function.keys (native)
  at Function.<anonymous> (/home/one/github/load-balancer-service/node_modules/gulp-angular-filesort/node_modules/ng-dependencies/node_modules/sugar/release/sugar-full.development.js:180:23)
  at NodeConfiguration.Configuration._throwNonCamelCaseErrorIfNeeded (/home/one/github/load-balancer-service/node_modules/gulp-jscs/node_modules/jscs/lib/config/configuration.js:416:12)
  at NodeConfiguration.Configuration.load (/home/one/github/load-balancer-service/node_modules/gulp-jscs/node_modules/jscs/lib/config/configuration.js:52:10)
  at [object Object].StringChecker.configure (/home/one/github/load-balancer-service/node_modules/gulp-jscs/node_modules/jscs/lib/string-checker.js:66:29)
  at [object Object].Checker.configure (/home/one/github/load-balancer-service/node_modules/gulp-jscs/node_modules/jscs/lib/checker.js:26:39)
  at module.exports (/home/one/github/load-balancer-service/node_modules/gulp-jscs/index.js:31:11)
  at Gulp.<anonymous> (/home/one/github/load-balancer-service/gulp/tasks/lint.js:16:15)
  at module.exports (/home/one/github/load-balancer-service/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:34:7)
  at Gulp.Orchestrator._runTask (/home/one/github/load-balancer-service/node_modules/gulp/node_modules/orchestrator/index.js:273:3)
  at Gulp.Orchestrator._runStep (/home/one/github/load-balancer-service/node_modules/gulp/node_modules/orchestrator/index.js:214:10)
  at Gulp.Orchestrator.start (/home/one/github/load-balancer-service/node_modules/gulp/node_modules/orchestrator/index.js:134:8)
  at /usr/local/lib/node_modules/gulp/bin/gulp.js:129:20
  at process._tickCallback (node.js:419:13)
  at Function.Module.runMain (module.js:499:11)
  at startup (node.js:119:16)
  at node.js:906:3

I am using the gulp-jscs of jscs. Please let me know if this a gulp-jscs issue instead.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

I assume your configuration is set up improperly. Did you read the docs and double check you have everything set up properly? What does your code look like?

Perhaps this is a gulp-jscs issue? Or am I doing something wrong? From usage, it looks like config. is not mandatory.
https://www.npmjs.com/package/gulp-jscs
var gulp = require('gulp');
var jscs = require('gulp-jscs');

gulp.task('default', function () {
    return gulp.src('src/app.js')
        .pipe(jscs());
});

@dman777, please ask future support questions on our Google group.
JSCS needs either a provided config, or usage of a .jscsrc file. See http://jscs.info for more information. Thanks!


doc: add OpenAPI validation info to user guide

Description of the change:
The generated YAML CRD created when running operator-sdk add api ...
includes an OpenAPI v3.0 validation section. E.g.
  validation:
    openAPIV3Schema:
      properties:
        apiVersion:
          description: 'APIVersion defines the versioned schema of this representation
            of an object. Servers should convert recognized schemas to the latest
            internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources'
          type: string
        kind:
          description: 'Kind is a string value representing the REST resource this
            object represents. Servers may infer this from the endpoint the client
            submits requests to. Cannot be updated. In CamelCase.
In the case of the Memcached example, a size property should be
added to the generated CRD. This change documents that process in
the user guide.
Motivation for the change:
I got hung up on this when going through the tutorial. I thought I was missing a step or something wasn't right when examining the generated CRD files and following the user guide. Perhaps this will make it a little clearer for people just starting out.

/test e2e-aws-ansible

@estroz We don't have any of the upstream validation directive tags documented anywhere yet right?
Once we have that, then in the future I think this might be better as a separate doc that we point to from the user-guide rather than a section in here.

Thanks for this!


update readme

Current coverage is 69.34%

Merging #97 into master will not affect coverage as of 51fa494

@@            master     #97   diff @@
======================================
  Files           45      45
  Stmts         1070    1070
  Branches       268     268
  Methods          0       0
======================================
  Hit            742     742
  Partial         56      56
  Missed         272     272

Review entire Coverage Diff as of 51fa494

Powered by Codecov. Updated on successful CI builds.


Fix invalid environment variable for User Events JVM option

Description

JVM option does not affect the user-events application, because the environment variable is invalid
So I changed the name from CACHE_INVALIDATOR_OPTS to USER_EVENTS_OPTS
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[x] User events

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4655 into master will decrease coverage by 4.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #4655     +/-   ##
=========================================
- Coverage   83.12%   78.43%   -4.7%
=========================================
  Files         184      184
  Lines        8438     8438
  Branches      591      591
=========================================
- Hits         7014     6618    -396
- Misses       1424     1820    +396

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.17%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-94.74%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedListener.scala
0% <0%> (-86.67%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-76.48%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

...a/org/apache/openwhisk/common/ExecutorCloser.scala
0% <0%> (-66.67%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
7.69% <0%> (-50%)
:arrow_down:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9a780...77acc50. Read the comment docs.

LGTM


Update new-field.md

Added the missing DB migration command (Visual Code SQL lite section) to make it easy for anyone new

dotnet ef migrations add InitialCreate

You can't do that unless you deleted the migration. update looks at the DB state and runs all the migrations needed.

@tamilselvan719 check my suggested change. cc @tdykstra

check my suggested change.

Works if there's only been one migration, alternative that works regardless of number of migrations is to delete the Migrations folder.

@tamilselvan719  thanks for the PR, much appreciated. Keep them coming.


Game often crashes on dialogues or when using bursts

When you enter the dialogue, it can crash at any point during it. It is often on the exact same part. Also when using bursts, sometimes it works normally.

macOS Sonoma 14.4
Device: MacBook Pro 14" M2 Pro
CPU: Apple M2 Pro
RAM: 16GB

game_1706832602301.log

i'm having the same issue on the same mac model. some bursts work fine and others crash mid-animation. all the ones that have crashed are 5 star bursts tho, 4 star bursts works fine. also it crashed during one of the lantern rite quest dialogues.

Yes, exactly. I meant 5 star animated bursts. Tried lowering graphics to a minimum possible, did not help.

This also happens to a lot. Especially when I am in the middle of dialogues!
I am running on a M1 macbook pro 13 inch.

This is a problem I've been having again recently. More specifically, crashing during dialogue. Running an M2 Macbook Pro 14-inch.

It's a known issue some systems crashes on animations and cinematics. For people with 16Gb of ram and more, I would suggest trying crossover.

Do you still have this issue?

No, ever since crossover 24 and changing wine 1.2 to crossover in Yaagl launcher it runs perfect.


use an overridden ticker when displaying a link in the item dialog, close #1002

Deploy preview for landscape ready!
Built with commit 73808f8978cb14854a30936af348045c03241651
https://deploy-preview-1003--landscape.netlify.com


Jaeger UI not showing traces between Microservice and MongoDB service when used with Istio 1.9.5

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
Our applications are running inside a Kubernetes Cluster with the configuration below. MongoDB is one of the applications running as a Statefulset with headless service in the cluster.
Kubernetes Version :
Server Version: version.Info{Major:"1", Minor:"18",GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
OS Version :
CentOS Linux 7
Istio Version :
1.9.5
We have recently deployed Istio Operator 1.9.5 using which Istiod and Istio Ingressgateway components were installed. Tracing is enabled in the meshConfig section  and we are using Jaeger all-in-one as Trace Collector and Querier (Jaeger UI). Jaeger has been installed using the command below.
kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.9/samples/addons/jaeger.yaml -n istio-system
In the Jaeger UI (under services dropdown) we are able to see most of our services and their traces. The http calls between the microservices are traced but the calls from the Microservice to MongoDB service are not traced. Also, MongoDB related headless services are not appearing in the Services dropdown section (as in the Screenshot below).

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Calls between Microservice and MongoDB should appear as traces in Jaeger UI and also MongoDB should be visible under Services drop down in Jaeger UI
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
Istio 1.9.5
Kubernetes 1.18
How was Istio installed?
Using Istio Operator 1.9.5
Environment where the bug was observed (cloud vendor, OS, etc)
CentOS Linux 7
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

Trace is based on headers and is only available for HTTP.


Fix SaveConfigMapToFile

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/test fluid-e2e

The function is not used in Fluid's code base. How about removing it?


Initial commit

Added name and GitHub Profile URL

@Saurav1-2 one little tip from me name your or with what is does for example 'add sairav1-2'

Thanks for reviewing @schmelto


Use --no-cache for Alpine to minimize footprint

Using apk add --no-cache tini instead of apk add --update tini avoids caching and reduces the size of the resulting container. See here: https://github.com/gliderlabs/docker-alpine/blob/master/docs/usage.md#disabling-cache

Thanks! Tweaked this a little bit since there's an underlying template that needs to be kept in sync :)
Cheers,


'M' is not recognized as an internal or external command

When I run the poetry run make html in modern-python-projects-course\ch11-cli\uptimer:
'M' is not recognized as an internal or external command,
operable program or batch file.
make: [html] Error 1 (ignored)

Hmm, it's the first time I see this message and google doesn't return any meaningful results. My guess would be that you have a typo somewhere in one of the files used by Sphinx or there is some problem with the file-endings encoding.
I just cloned the repository, tried running this command and it worked:
# Create a new virtual environment (you can use venv module or any other tool)
$ vf new testmpp
Creating testmpp via ~/.local/pipx/venvs/virtualfish/bin/python …

(testmpp)$ pip install poetry
...

(testmpp)$ poetry install
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: uptimer (0.1.0)

(testmpp)$ poetry run make html
Running Sphinx v3.3.1
making output directory... done
WARNING: html_static_path entry '_static' does not exist
building [mo]: targets for 0 po files that are out of date
...
build succeeded, 1 warning.

The HTML pages are in build/html.

Can you confirm that those steps work for you?
Otherwise, if you could push your version of the code somewhere, I can take a look, but for now I have no way to replicate this issue.


Add linting to CI / Testing

This patch closes #117
It adds an npm script to lint the front end code in public/js.  It also adds the linting step to npm test.  Now linting will be part of the travis CI process, and all code will be nice and tidy.

@TheAlphaNerd this looks good, except can we turn off the no-unused-vars rule everywhere? I'm getting a lot of those warnings when I run the lints, and that error is pretty useless IMO...

We can turn off no-unused-vars... although I left it in as a warn for a reason.
It is getting some false positives in the case of functions that have declared parameters that are unused, although perhaps those should arguably be removed (or at least commented out).  There are some instances where it flags on variables that legitimately should not be there such as the inclusion of rimraf in lib/db.js
So we are left with the choice of disabling it and letting unused variables in the code... or making a decision about what to do with the unused vars in functions.

That makes sense. Warns don't fail Travis, right?

Nope.  I'll submit a seperate PR that will take a stab at getting rid of the warnings.  Once we get rid of them we can turn warn off.

Sounds good, let's get lintin'...


[WIP] Update crashlytics sample for Crashlytics 4

do not merge

I was planning on just leaving the PR unmerged until 6.15.0 is released.


[Huawei]cleancode: delete useless function

Offering:hpc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Azkaban HadoopShell jobtype

HadoopShell is a Hadoop security enabled "command" jobtype. This jobtype adheres to same format and other details as "command" jobtype with added functionality to filter commands using a whitelist and blacklist regex and hadoop_opts.

also, nice test cases

LGTM

Synced offline, it will be stated that comment in same line with execution code will not be allowed.
LGTM


Bump to version 2.0.0

Description
Bump to version 2.0.0 on main to better reflect the version on this branch.
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[ ] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Skip changelog since this wouldn't make sense to go in any changelog


Doesn't work with Browserify

Node's assert module is bundled when using Browserify and it acts differently than component's assert when checking if two arrays are equal.
component/assert returns true when assert.strictEqual(['a', 'b'], ['a', 'b']) whereas with node's assert module: AssertionError: ["a","b"] === ["a","b"].

Are you sure? I've used both extensively and strictEqual functions identically for both.

hmm I'm pretty sure but I'll check again tomorrow and update this issue.

Try this with node, it should throw an error:
var assert = require('assert')
var arrayOne = ['a', 'b']
var arrayTwo = ['a', 'b']

assert.strictEqual(arrayOne, arrayTwo)

component/assert returns true because it uses jkroso/equals which will iterate through an array and compare each value in the array.
With Node's assert module I've always had to do it myself.  This will not throw an error:
var assert = require('assert')
var arrayOne = ['a', 'b']
var arrayTwo = ['a', 'b']
var i = arrayOne.length

while (i--) {
 assert.strictEqual(arrayOne[i], arrayTwo[i])
}

Oh I just now clicked the link to component/assert and I see what you're saying.  I must have been looking at the code for deepEquals originally.  I had a specific issue with assert-element let me see if I can recreate it.

Ok, I wouldn't be surprised if there were some caveats between these different libraries, but I'm hoping they're edge-cases more than anything. If you can find the exact failure scenario, or at least something reproducible, we can re-open this.


feat: enable postcode edit from map

Description

Enable edit of property postcode for the main Patient

On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[x] iOS - Emulator
[ ] iOS - Physical device

Screenshots

Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevent
[x] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

This GIF highlights the fact that even when a postcode is updated, we don't try to refetch the map at present, and we may want to, otherwise users will think their email still requires updating?


Remove unreachable BssNotSupported error

Minor find while porting the ELF loader:
The second branch of the if expression in the writable section check is dead code.
We already check for name.starts_with(".bss") || ? so name == ".bss" is unreachable.
https://github.com/solana-labs/rbpf/blob/e9c2d206e18a5e759b63f39353b029dec6dc4247/src/elf.rs#L690-L697
The unit test for this piece of code confirms this:
https://github.com/solana-labs/rbpf/blob/e9c2d206e18a5e759b63f39353b029dec6dc4247/src/elf.rs#L2114-L2119
Related to that, we should probably add a unit test for an ELF that has a read-only .bss section.

Can you rebase onto the main branch?


Allow users to customize coursier ResolutionParams

This adds a JavaModule#resolutionParams task, allowing users to customize coursier's ResolutionParams. These allow to customize some aspects of dependency resolution.
In particular, ResolutionParams#enableDependencyOverrides, when set to Some(false), disables the recent BOM changes added (and enabled by default) in coursier 2.1.17. This might be useful, if ever users aren't happy with the versions it selects, or want to wait a bit before enabling that, or if they find out performance suffers because of it for them.
The new task is anonymous (it's not a target, it's not serialized on disk), as ResolutionParams has a field that doesn't easily lend itself to serialization (rules, because of the Rule type, which is an open abstract class).

The new task should definitely come with some documentation, since some other customizations seem to affect the final ResolutionParams as well. What overrides what?

What do you mean?

Oh, I think I see


Fix logger

Type of Change
Enhancement.
Description
Enhance log funcs to show the filename and line number.
How has this PR been tested?
Pre-CI
Dependency Change?
None

The pre-commit update in the documents.


Setting Filters programatically instead of swiping

What is an efficient way to set filters programatically instead of scrolling ?

I actually solved it by using self.filterSwitcherView.selectedFilter = self.filterSwitcherView.filters[filterIndex];


Include TLSv1.3 ciphers as recommented ciphers for HTTP2

Motivation:
We should include TLSv1.3 ciphers as well as recommented ciphers these days for HTTP/2. That is especially true as Java supports TLSv1.3 these days out of the box
Modifications:

Add TLSv1.3 ciphers that are recommended by mozilla as was for HTTP/2
Add unit test

Result:
Include TLSv1.3 ciphers as well

@slandelle all addressed


python/task/binary_search.py

Complete the given task and attach a screenshot of the code and output

Assign this to me

Please assign this issue!

Please assign this issue to me !!


Fix upzip to unzip in installing-on-linux

Title
Fix upzip to unzip in installing-on-linux
Functional impact
None.
Minimal repro steps
Go to the Install the .NET Version Manager (DNVM)
Expected result
The instruction would read
Install unzip if you don’t already have it:
Actual result
The instruction reads
Install upzip if you don’t already have it:
Further technical details
In getting-started, installing-on-linux, in the section "Installing on Debian, Ubuntu and derivatives", subsection "Install the .NET Version Manager (DNVM)". This is a minor typographical error.

Closing since this has been fixed


license confusion

The LICENSE file in this repo appears to be the MIT license, but all of the .go files in this repo have an Apache 2.0 license header.  Which license is correct?

Great catch! The intent was to use the MIT license, I just removed all of the Apache license headers.


How can I get log, graph when using webhook_sink?

Hi team, Currently, I use webhook_sink to send alerts but I don't know how to get logs, graph like telegram_sink does.

Hi, where are you sending the alerts to by webhook? I don't think we
support it on the webhook sink right now.
On Mon, Jul 1, 2024 at 11:58 AM github-actions[bot] <
@.***> wrote:

Hi 👋, thanks for opening an issue! Please note, it may take some time for
us to respond, but we'll get back to you as soon as we can!

💬 Slack Community: Join Robusta team and other contributors on
Slack here https://bit.ly/robusta-slack.
📖 Docs: Find our documentation here
https://docs.robusta.dev/master/.
🎥 YouTube Channel: Watch our videos here
@.***>.

—
Reply to this email directly, view it on GitHub
https://github.com/robusta-dev/robusta/issues/1482#issuecomment-2199606136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYUB232ZP2LNMGN4US7BTZKEK27AVCNFSM6AAAAABKFD5Z4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZGYYDMMJTGY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi, where are you sending the alerts to by webhook? I don't think we support it on the webhook sink right now.
…
On Mon, Jul 1, 2024 at 11:58 AM github-actions[bot] < @.> wrote: Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can! - 💬 Slack Community: Join Robusta team and other contributors on Slack here https://bit.ly/robusta-slack. - 📖 Docs: Find our documentation here https://docs.robusta.dev/master/. - 🎥 YouTube Channel: Watch our videos here @.>. — Reply to this email directly, view it on GitHub <#1482 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYUB232ZP2LNMGN4US7BTZKEK27AVCNFSM6AAAAABKFD5Z4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZGYYDMMJTGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hi @aantn : Could you tell me how the telegram_sink get logs and graph? My org has hundreds of Telegram users and services, each one may be receive alerts on one or more services, so we have to use webhook_sink to manage by ownself

Hi @tommy04062019,
Here is the relevant code in the telegram sink - https://github.com/robusta-dev/robusta/blob/07ca9bb0f7283f66134a7ae5f814596f1d3f045d/src/robusta/core/sinks/telegram/telegram_sink.py#L36
And here is the code for the webhook sink which you would have to add it to - https://github.com/robusta-dev/robusta/blob/07ca9bb0f7283f66134a7ae5f814596f1d3f045d/src/robusta/core/sinks/webhook/webhook_sink.py#L30
If you are interesting in contributing a PR for this, we have instructions on setting up a dev environment here - https://docs.robusta.dev/master/setup-robusta/installation/dev-setup.html
Can you explain more on how you manage it by yourself with the webhook_sink?


[Enhancement] change default setting of monitor queries

Why I'm doing:
The async-profile query use a profileTimeout=2s, checkInterval=1m, which doesn't make sense.
In particular cases, it would either expire the query very quickly, or leave a lot of queries in memory.
What I'm doing:

change default value of profileTimeout to 10s
use a dedicated thread to monitor queries, whose interval is 1s

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.4
[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0

@Mergifyio rebase


[BUG] Cron skips an instance for Western time zones

Assuming you're in a Western time zone (UTC-).
Steps to reproduce:

Call scheduler.cron
Specify use_local_timezone=True
Make a note of the hour offset between the local time zone and UTC. Let's assume for EST, this is 5 hours.
Specify a cron string whose next instance would be less than the time zone offset hours from now. If our offset is 5, specify a cron string that would next run in less than 5 hours.

For example, if I'm in EST at -5 hours from UTC, it's now 13:00 and I cron schedule for just 1 hour from now, at 14:00 every day.
Expected outcome: The next run is 14:00 today.
Actual outcome: Today's run is skipped. The next scheduled time (returned by get_next_scheduled_time) is 14:00 tomorrow.
This happens because at the time the job is scheduled, CronTab.next, called at utils.py:28 in get_next_scheduled_time, which is called from cron, is assuming a UTC time for now. When it's asked to return the next instance after datetime.now(), that instance is always in the past for time zones West of UTC, and so get_next_scheduled_time ends up missing the next instance.
A solution might involve adjusting the time sent to cron.next to subtract the time zone difference if use_local_timezone=True.

My bad. Docker containers are in UTC by default, which made it seem like crontab was operating in UTC when in fact it was the Docker environment.


Result list UI issue on iPhone 5s

The results list got extended to the top beyond the screen on iPhone 5s. Is there anything I'm missing to fix this?

did you find the solution?


GitHub webhook Lambda function fails in 0.4.1

Description
GitHub webhook lambda function fails when triggered
Steps to reproduce the bug
terraform apply with version 0.4.1 of the module
The first noticeable failure is that when PRs are opened/updated, the AWS CodeBuild check no longer appears within the PR.
The AWS SNS integration is still in place and the lambda function does get triggered, but fails with:
TypeError: Cannot read property 'replace' of undefined
at /var/task/index.js:45:205
at Array.reduce (native)
at r.default (/var/task/index.js:44:19)

Package versions

terraform-aws-github-ci: 0.4.1
terraform: v0.11.3

The last working commit is<PHONE_NUMBER>f7f0174319f7b292e67918b3fb32fc, which could probably be tagged as v3.1 (v3 contains a bug with the S3 bucket provisioning)

Found the bug:
Line 48:
var t = r.Sns.MessageAttributes["X-Github-Event"].StringValue # ...

StringValue is undefined:
console.log( r.Sns.MessageAttributes["X-Github-Event"]);
# { 'X-Github-Event': { Type: 'String', Value: 'pull_request' } }

Changing to this fixes the issue:
var t = r.Sns.MessageAttributes["X-Github-Event"].Value

I'll open a PR :+1:

Okay ... So TypeScript 🤷♂
Thought it would be as simple as changing in share/lambda/src/webhook.ts
const githubEvent = record.Sns.MessageAttributes!["X-Github-Event"].StringValue
# to
const githubEvent = record.Sns.MessageAttributes!["X-Github-Event"].Value

Running make causes the error:
[tsl] ERROR in ./share/lambda/src/webhook.ts(94,30)
      TS2339: Property 'Value' does not exist on type 'MessageAttributeValue'.

I can't see a way to ensure that when it compiles, Value is used instead of StringValue

Thanks for debugging! My mistake, I trusted the typings. It should obviously be .Value - I'll fix it straight away.

Fixed and released as part of 0.5.0. Thanks for your efforts!


[BUG] Full Screen Search Section on Main Page Creates Poor User Experience

Description of the bug
When we click on the search here button on main page then a full screen search section is open which gives a bad user experience.

Please add screenshots (if applicable)

Add any other context about the problem here
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@rohankumarchaudhary67 I am assigning the issue and looking forward for the changes. Good luck !

@rohankumarchaudhary67  any update about the issue

Hey @Deepu178 , Right now I am busy in another project, So sorry for that and Assign to someone else


Complete the feature to compare and merge run reports

Added license header for non-pytorch-model tests. pytorch mdoel tests need more vetting.

Will take care of the suggestions shortly and merge. thanks!!


Chartjs2.0: Documentation CDN link 404

The CDN link on de chartj2 documentation page directs to a 404 page.

Link will work as soon as v2 is released.

Link is up on CDNJS.


Vim9: crash when creating popup from timer

Describe the bug
In Vim9 script, creating a popup from a timer might make Vim crash.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    au BufWinLeave * reltime()
    def Func()
        popup_menu('', {})
        timer_start(0, {-> popup_create('', 0)})
    enddef
    Func()
EOF
)

E715 is raised; this is expected.
Press C-c twice to interrupt the error and get rid of its message.
Run :b: Vim crashes.
Expected behavior
Vim doesn't crash.
Environment

Vim version: 8.2 Included patches: 1-1817
OS: Ubuntu 16.04.7 LTS
Terminal: xterm(360)

Additional context

backtrace
valgrind log

The autocmd can be simplified a little; there is no need for it to execute anything; it just needs to exist:
vim9script
au BufWinLeave * #
def Func()
    popup_menu('', {})
    timer_start(0, {-> popup_create('', 0)})
enddef
Func()

Run :b: Vim crashes.

It doesn't matter which command is executed.  At that point, any command makes Vim crash.

I wonder whether it has anything to do with https://github.com/vim/vim/issues/6701.

I wonder whether it has anything to do with #6701.

The reason I mention this other report, is because in both cases:

the issue is specific to Vim9
a nested function is involved (if, here, we consider the lambda passed to the timer as a kind of nested function)
a crash is involved
an interruption is necessary to trigger the crash

Regression introduced in 8.2.0424.

I'm not sure but maybe these previous commits are somewhat related to the issue:

8.2.0420  Vim9: cannot interrupt a loop with CTRL-C
8.2.0421  interrupting with CTRL-C does not always work

I fixed it where it happens.  It's unclear why did_throw got set while current_exception isn't.
I didn't manage to write a test for this.  It may require running another Vim instance.


Don't use the global execution context

Currently, we import the global execution context for executing Futures. This is convenient, but it restricts customization of the execution environment needlessly.

Fixed as of d6d3e70ac738474d695e276a7c911ae9ae25d10c.


Add Sense UI?

Not entirely this makes sense (new to Kubernetes and somewhat to ES) but it'd be cool if you could add the Sense plugin and use kubectl proxy to be able to live query production data.
Thoughts?

You can do it with your own images that use quay.io/pires/docker-elasticsearch-kubernetes as base image. I don't think it would make sense to add that here and force everyone to use it. I've never used, for instance.

Thanks
On Sun, Jan 31, 2016 at 3:07 AM Paulo Pires<EMAIL_ADDRESS>wrote:

Closed #30
https://github.com/pires/kubernetes-elasticsearch-cluster/issues/30.
—
Reply to this email directly or view it on GitHub
https://github.com/pires/kubernetes-elasticsearch-cluster/issues/30#event-532990409
.


[Themes] New theme customization handling

In the latest commit I-ve separated theme resource into: styles, icons, sounds and fonts. This way the user can customize in any way they want.
Currently, there is no support for adding/setting custom icons and sounds in the UI.

[x] Add sound themes to build.json
[x] Add icon themes to build.json
[x] Add fonts to build.json
[x] Automatically bake in fonts to theme css (LESS)
[x] Add setting to ApplicationSettings under Theme tab
[x] Rewrite to use custom metadata files instead

Now done... sweet! :smile:


Bug: (sort-object): Cannot read properties of undefined (reading 'getTokensBefore')

Describe the bug
Getting that error when running the linter
Code example
const something = {
  b: false,
  a: true,
};

ESLint version
8.36
ESLint Plugin Perfectionist version
2.7.0
Additional comments
Apple M3 Pro
macOS Sonoma 14.3
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Looks like a problem with the typescript-eslint version.
What package manager are you using?

We're using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

BTW, I just tried upgrading @typescript-eslint/eslint-plugin, @typescript-eslint/parser and @typescript-eslint/utils to latest non breaking version 6.21.0 and the issue is still reproducible

Do you have the ability to create a small repository to reproduce the problem?

Hi, sorry for the delay, you can reproduce it here:
https://github.com/bab2683/perfectionist-121

Looks like the removing parser fix this issue.

To use typescript however, is necessary due to the differences in AST format. at least that's what they say right in the first line https://typescript-eslint.io/packages/parser/. I thought this eslint plugin was compatible with the whole @typescript-eslint suite due to the sort-interfaces rule and also because it's listed as dependency.
We use the parser in the overwrites because we have both js and ts files in the project


Kompose integration

It would be nice to have a simple way to use Kompose (https://kompose.io/) with microk8s.

Hi @bangnab
That was pleasant surprise for me! Kompose worked out of the box on an AWS machine:
ubuntu@ip-172-31-60-221:~$ sudo snap install microk8s --classic
microk8s v1.12.2 from Canonical✓ installed
ubuntu@ip-172-31-60-221:~$ curl -L https://github.com/kubernetes/kompose/releases/download/v1.16.0/kompose-linux-amd64 -o kompose
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   609    0   609    0     0   5075      0 --:--:-- --:--:-- --:--:--  5075
100 45.6M  100 45.6M    0     0  70.1M      0 --:--:-- --:--:-- --:--:-- 70.1M
ubuntu@ip-172-31-60-221:~$ ^Cl -L https://github.com/kubernetes/kompose/releases/download/v1.16.0/kompose-linux-amd64 -o kompose
ubuntu@ip-172-31-60-221:~$ chmod +x ./kompose
ubuntu@ip-172-31-60-221:~$ sudo mv ./kompose /usr/local/bin/kompose
ubuntu@ip-172-31-60-221:~$ wget https://raw.githubusercontent.com/kubernetes/kompose/master/examples/docker-compose.yaml
--2018-11-21 13:46:47--  https://raw.githubusercontent.com/kubernetes/kompose/master/examples/docker-compose.yaml
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 421 [text/plain]
Saving to: ‘docker-compose.yaml’

docker-compose.yaml                             100%[=====================================================================================================>]     421  --.-KB/s    in 0s

2018-11-21 13:46:47 (90.7 MB/s) - ‘docker-compose.yaml’ saved [421/421]

ubuntu@ip-172-31-60-221:~$ kompose up
INFO We are going to create Kubernetes Deployments, Services and PersistentVolumeClaims for your Dockerized application. If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead.

INFO Deploying application in "default" namespace
INFO Successfully created Service: frontend
INFO Successfully created Service: redis-master
INFO Successfully created Service: redis-slave
INFO Successfully created Deployment: frontend
INFO Successfully created Deployment: redis-master
INFO Successfully created Deployment: redis-slave

Your application has been deployed to Kubernetes. You can run 'kubectl get deployment,svc,pods,pvc' for details.
ubuntu@ip-172-31-60-221:~$ microk8s.kubectl get all --all-namespaces
NAMESPACE   NAME                               READY   STATUS              RESTARTS   AGE
default     pod/frontend-64447796d8-pbfpv      0/1     ContainerCreating   0          18s
default     pod/redis-master-dbcc9dcc6-kmdhr   0/1     ContainerCreating   0          18s
default     pod/redis-slave-78cf75885b-856ft   1/1     Running             0          18s

NAMESPACE   NAME                   TYPE           CLUSTER-IP       EXTERNAL-IP   PORT(S)        AGE
default     service/frontend       LoadBalancer   <IP_ADDRESS>    <pending>     80:30253/TCP   18s
default     service/kubernetes     ClusterIP      <IP_ADDRESS>     <none>        443/TCP        2m46s
default     service/redis-master   ClusterIP      <IP_ADDRESS>   <none>        6379/TCP       18s
default     service/redis-slave    ClusterIP      <IP_ADDRESS>   <none>        6379/TCP       18s

NAMESPACE   NAME                           DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
default     deployment.apps/frontend       1         1         1            0           18s
default     deployment.apps/redis-master   1         1         1            0           18s
default     deployment.apps/redis-slave    1         1         1            1           18s

NAMESPACE   NAME                                     DESIRED   CURRENT   READY   AGE
default     replicaset.apps/frontend-64447796d8      1         1         0       18s
default     replicaset.apps/redis-master-dbcc9dcc6   1         1         0       18s
default     replicaset.apps/redis-slave-78cf75885b   1         1         1       18s
ubuntu@ip-172-31-60-221:~$

I am a bit surprised because microk8s does not put its kubeconfig in the default location. Perhaps the Kompose people took microk8s into account? You can use microk8s.config -l > ~/.kube/config to add the config in the default place and sudo snap alias microk8s.kubectl kubectl to use microk8s.kubectl as if ti were kubectl.
Let me know if you are facing any issues.

I had another not so pleasant experience with Kompose this time. The problem this time was me not giving Kompose the right hints to create services and dns entries where off.

You can use microk8s.config -l > ~/.kube/config to add the config in the default place and sudo snap alias microk8s.kubectl kubectl to use microk8s.kubectl as if ti were kubectl

The problem with this approach is that you cannot change the context from microk8s and other standard kubernetes cluster that you have configured. How you could manage microk8s and other cluster with the same kubectl command? I.e. I want to switch context between dev and production where dev is on microk8s and prod is in an K8s cloud.


Improve ICMPv4 tests

Earlier tests were not going through ICMP echo core stack handlers. Due to that unable to verify echo reply. Tests are improved to verify replies.

something wrong, working on it.


Added ES6 bundle output

This PR adds an additional ES6 bundle playcanvas.esm.js as a build output. It uses the same ES6 build configuration as the unbundled playcanvas.mjs but instead simply outputs to a single output.
We plan on upgrading the launcher and exported projects to use this ES6 build to support ESM Scripts.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Very nice, people needed this for quite some time - unbundled ESM builds were causing:

no problem for local development, but long request times for every individual file over internet
services like UNPKG have request limits and simply drop further ones

Very nice, people needed this for quite some time - unbundled ESM builds were causing:

no problem for local development, but long request times for every individual file over internet
services like UNPKG have request limits and simply drop further ones

Unfortunately even the ES Modules build includes these polyfils which are likely redundant

Should we have other flavours of this bundle? At least debug, performance, and release (normal).

Should we have other flavours of this bundle? At least debug, performance, and release (normal).

Yep there's the same outputs, dbg, prf and min

Had a little discussion among the team and we'd vote for:
playcanvas.js - umd build, as before
playcanvas.mjs - the ESM bundled version
playcanvas - the RSM unbundled version
And of course .dgb, .min, .profile version of each.

We also need to change in that case:
https://github.com/playcanvas/engine/blob/631493694dd3fb23c9c79fa77c6f4a6380c3aa1c/package.json#L21

Had a little discussion among the team and we'd vote for: playcanvas.js - the UMD build, as before playcanvas.mjs - the ESM bundled version playcanvas - the ESM unbundled version
And of course .dgb, .min, .profile version of each.

Love this. Done!
Assuming the unbundled 'playcanvas' dir doesn't need to have 'playcanvas.prf', 'playcanvas.min', 'playcanvas.dbg' variants

We also need to change in that case:
https://github.com/playcanvas/engine/blob/631493694dd3fb23c9c79fa77c6f4a6380c3aa1c/package.json#L21

Yep agreed. Have updated

What would be the naming convention on these folders? Having the dot suffix
doesn't feel right. kebab case 'playcanvas-dbg/index.js' might work if we do
On Wed, Feb 21, 2024 at 12:58 PM Donovan Hutchence @.***>
wrote:

Assuming the unbundled 'playcanvas' dir doesn't need to have
'playcanvas.prf', 'playcanvas.min', 'playcanvas.dbg' variants
I think we will need variants... @mvaligursky
https://github.com/mvaligursky ?
—
Reply to this email directly, view it on GitHub
https://github.com/playcanvas/engine/pull/6073#issuecomment-1956598189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADJFLBRY3A7IWMIDWB4UQTYUXVOJAVCNFSM6AAAAABDS4UA5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGU4TQMJYHE
.
You are receiving this because you were assigned.Message ID:
@.***>

If we expect people to use the unbundled versions, we need to provide the variants, as they cannot easily replicate our processes to strip out debug info, and they need debug version at the very least.

For consistency naming the folders playcanvas, playcanvas.dbg, playcanvas.min, playcanvas.prf seems fine to me.

Though in reality the .min unbundled build has no use whatsoever (the rest do).

Have added unbundled es6 variants excluding 'min' @slimbuck @mvaligursky


Add tpoliveira-mariana to Contributors list

Hi  @tpoliveira-mariana, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.