[Request] Layer Attribute

[Layer] int layer;
Similar to other attributes that are already here, such as [Scene], it would let you choose from your project's list of layers and store the layer index in an int.

Implemented in d02322d0d2a6b4e7b34c492582584fcab03bcc8f


Include the date of creation to REUSE license comments

Description of the issue
I came across this blog post about the use of the year in the copyright statement.
https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#tldr
Ideas of solution
Add the year of creation in all REUSE statements.
Workflow checklist

[ ] I am aware of the workflow in CONTRIBUTING.md

-- Find year of reation:
💠 git log --follow --format=%as {$path} | tail -n1 | cut -c-4


Direct-install from brew?

Wouldn't this be good or is there a reason we don't want to support it?
⧑ brew install elm-platform

Error: No available formula for elm-platform
Searching formulae...
Searching taps...
Caskroom/cask/elm-platform

I have no objection, but I'm also not an expert on creating installers for all the different possibilities. Folks have created a way to install through npm, so it's certainly doable! Maybe bring it up on the mailing list and try to figure out how to make it happen?

@evancz Sounds good. Is there a "how-to-help-elm" list somewhere that I could just add this too? Its actually not my speciality to readily achieve this either.

I have been making a big list of projects here so it would be good to add a section on making installers! Can you open a PR there?

@evancz https://github.com/elm-lang/projects/pull/6 Done!

Awesome, thanks again! And if you feel like it's taking too long, don't be afraid to poke the mailing list to try to make it happen.

@evancz Sounds good. Thanks for your generosity and openness.

$ brew search elm
Caskroom/cask/elm-platform

@lagden Is that complete brew support for elm? If so update the related Readme :+1:

Yes, but you need install Homebrew Cask first and then...
$ brew cask install Caskroom/cask/elm-platform

The current formula is:
cask :v1 => 'elm-platform' do
  version '0.15.1'
  sha256 '09ad994a33215d954042c5917423eec0e2adbd6015dd6dd9ef571d5d7af9bf2b'

  url "http://install.elm-lang.org/Elm-Platform-#{version}.pkg"
  name 'Elm'
  homepage 'http://www.elm-lang.org'
  license :bsd

  pkg "Elm-Platform-#{version}.pkg"

  uninstall :pkgutil => 'org.elm-lang.*',
            :delete => '/usr/local/share/elm'
end

or
via Node.js works fine too! -> https://github.com/kevva/elm-bin


feat: add custom working-directory support

fixes #141

@mxschmitt thanks for the review, I will check on them later.


Android: Remove -fno-integrated-as, it can break arm64v8 build

We found that this flag causes this error on PR #48812 which does not add any
fancy inline assembly:
/tmp/tile_set-ce236a.s: Assembler messages:
/tmp/tile_set-ce236a.s:34676: Error: selected processor does not support `bfc x0,#32,#32'
clang++: error: assembler command failed with exit code 1 (use -v to see invocation)

That flag is mentioned in various errors related to assembler failures on
arm64v8 with Clang from the Android NDK.
It was added in Godot in #6958 when migrating from GCC to Clang, and is indeed
referenced in the NDK's Clang migration guide:
https://android.googlesource.com/platform/ndk/+/master/docs/ClangMigration.md

Especially for ARM and ARM64, Clang is much stricter about assembler rules
than GCC/GAS. Use -fno-integrated-as if Clang reports errors in inline
assembly or assembly files that you don't wish to modernize.

We don't get those errors nowadays so it seems the flag is no longer needed.

I'll do a test round for master and 3.3 on all Android architectures to be safe.

I'll do a test round for master and 3.3 on all Android architectures to be safe.

Both tests built fine with NDK 21.4 (built Mono flavor for 3.3 and classical for master).

Cherry-picked for 3.4.

Cherry-picked for 3.3.2.


distribution: Add retry in distrotest

Maybe fix #22215
Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest


Bump the selenium-webdriver version since older version 3.0.x did not…

… work
It was causing invalid argument on driver_path until I hard coded the version of selenium-webdriver to the latest

Thanks for the submission!
This commit should address the underlying problem: fc447d790f868bbd4d3525cbf9c4c9d10b5b486d
I'll do a point release shortly, let me know if that doesn't fix it.


std::uniform_int_distribution<int8_t> is undefined in the C++17 standard, but TFLite violates this limitation.

As the C++ reference mentioned, std::uniform_int_distribution<int8_t> is undefined in the C++17.
Therefore microsoft visual C++ 2017 will give the following build error when the code includes benchmark_tflite_model.cc #L496.
In fact, the recent TFLite model benchmark couldn't build on windows as my CI environment shows.
bazel build -c opt --verbose_failures //tensorflow/lite/tools/benchmark:benchmark_model

C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\random(2401): error C2338: invalid template argument for uniform_int_distribution: N4659 <IP_ADDRESS> [rand.req.genl]/1e requires one of short, int, long, long long, unsigned short, unsigned int, unsigned long, or unsigned long long
tensorflow/lite/tools/benchmark/benchmark_tflite_model.cc(496): note: see reference to class template instantiation 'std::uniform_int_distribution<uint8_t>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\random(2401): error C2338: note: char, signed char, unsigned char, int8_t, and uint8_t are not allowed

Would you like to modify benchmark_tflite_model.cc?

Would you like to delete this topic? sorry...


⚠ Visual-Crew_Builder has degraded performance

In cd53844, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 1230 ms

Resolved: Visual-Crew_Builder performance has improved in c56cceb after 19 minutes.


generate input prefix in partial view

Would it be possible to auto-generate prefixes for input elements in a partial view?
I'm trying to accomplish the following: I have a partial view that is used in several other views. All of those views are forms that post data to their specific controller. Now i would like to bind the posted model from my partial view to a specific prefix, so i can easily access these data in the controller.
As far as is know right now, i would need to prefix every input element in my partial view on its own.
So as i am using it as a partial view, is it possible to give the partial view a parameter or anything like that so MVC names the input elements in my partial view automatically with the prefix?
I saw a lot of posts, that in older MVC Versions, that was possible, e.g. with the following:
@Html.Partial("_AddHobby", Model.HobbyModel, new ViewDataDictionary { TemplateInfo = new TemplateInfo { HtmlFieldPrefix = "hobby" } })
Edit: I played a bit more with those fields and found that it actually works with the following:
@{
                    var vd = new Microsoft.AspNet.Mvc.ViewFeatures.ViewDataDictionary(ViewData);
                    vd.TemplateInfo.HtmlFieldPrefix = "Vehicle";
                }
                @Html.Partial("_Formular", Model.Vehicle, vd)

Just that constructor changed. Sorry to bother you :)

No worries :laughing:


Xamarin.UITest(3.2.3 - 4.1.0) AppDataMode.Clear and AppDataMode.Auto for a physical iOS device throws an exception (macOS Monterey)

When updating to Xamarin.UITest(3.2.3 - 4.1.0) AppDataMode.Clear and AppDataMode.Auto for a physical iOS device throws an exception this is with macOS Monterey, Xcode Version 13.1, and the latest Visual studios updated as of 11/15/2021. The startup code needs to look like this:
            .iOS
            .WaitTimes(new CustomWaitTimes())
            .DeviceIdentifier(deviceId)
            .InstalledApp({bundle id})
            .EnableLocalScreenshots()
            .DisableSpecFlowIntegration()
            .StartApp(AppDataMode.Auto);
            Or
            .StartApp(AppDataMode.Clear);

The exceptions are as follows:
Xamarin.UITest.XDB.Exceptions.DeviceAgentException : Failed to clear data for app {bundle id}

ExitCode: 134
/var/folders/g1/1jz4c5yd6bx41bgkjh7vmdw80000gn/T/Empty.xcappdata
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: _AMDDeviceAttachedCallbackv3 (thread 0x11038b600): Device 'AMDevice 0x600000858000 {UDID = 00008030-000448463438802E, device ID = 1, location ID = 0x14324400, product ID = 0x12a8}' attached.
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: _SubscribeForMuxNotifications (thread 0x11038b600): returned 0x0.
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: _UsbMuxSecureStartService (thread 0x11038b600): returned 0 starting service com.apple.mobile.installation_proxy on device 00008030-000448463438802E at port 50688, out fd = -1.
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x11038b600): returned 0x0 for device 1
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x11038b600): returned 0x0 for device 1
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x11038b600): returned 0x0 for device 1
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x11038b600): returned 0x0 for device 1
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x11038b600): returned 0x0 for device 1
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x11038b600): returned 0x0 for device 1
Nov 15 11:23:05  iOSDeviceManager[7145] <Notice>: AMDeviceStopSession (thread 0x70000b31e000): returned 0x0 for device 1

Same thing here

@Lug16  I did the same but lost functionality for iOS, I really hope they fix this issue!

+1 still exist in 3.2.6

The documentation for the iOSAppConfigurator.StartApp(AppDataMode) Method states the following for the appDataMode parameter:

appDataMode
AppDataMode
The app data mode. Whether to clear app data or not before app launch. Currently only supported in Xamarin Test Cloud.

Should it be possible to clear data when running on a physical device outside of Xamarin Test Cloud?

@jstrawther
This feature does not really apply to app-center since when app-center does its run it always does a fresh install every test for the app that you are testing. When it comes to local runs if you are coding and want to work off a physical device "AppDataMode.Clear" was the perfect feature to mirror how it runs on app-center. With this feature being broken and causing an exception it has lowered Xamarin.UITest automation framwork quality. The hope is that with any automation framework there should not be any method of that framework that causes a build error exception and this issue should be fixed as soon as possible.

@Moshex Yes, i'm with you, and agree there is a bug here. What I was getting at, and should have stated in my comment, is that I wonder if we should expect a fix to support data clearing for local physical devices, or if (as it sounds from the API docs) the data clearing behavior is no longer supported outside of test cloud. If the latter, then i'd expect a fix to maybe involve changing the API or defaults, without adding support for the data clearing.

Please don't close it 🤞

This bug is still open on version 3.2.7

As a workaround for this, I've leveraged ios-deploy directly from my test framework in a pre-test hook. E.g.,
ios-deploy --uninstall --bundle \"{Settings.IPAFile}\" --id \"{Settings.RealDeviceID}\" --bundle_id \"{Settings.iOSAppID}\"

Would be great if this was actually fixed in the library however, as it definitely used to work.

As a workaround for this, I've leveraged ios-deploy directly from my test framework in a pre-test hook. E.g.,
ios-deploy --uninstall --bundle \"{Settings.IPAFile}\" --id \"{Settings.RealDeviceID}\" --bundle_id \"{Settings.iOSAppID}\"

Would be great if this was actually fixed in the library however, as it definitely used to work.

Could you share some code? Is it in the initialization method ?
Thanks anyway for the tips 😁

A workaround that I have been using was to have the devs code me an app data clear button that is tied to the main page logo (kind of a hidden button) of the application that only works in the application's debug mode and not for prod. This button clears all the application data via the app and what is stored on the device that does make the application work like it's a fresh install.
I don't think this is ideal but it was the best workaround I could think of to deal with this.
I am not the biggest fan of using "ios-deploy" since that requires uninstalling the application and only using the IPA while I prefer using the bundle id to start the application.
I really hope they fix this issue soon this really sucks for how long this has been broken

Hi all, we are currently working on fix for this. It will be fixed in the future release.

Can't wait 🎉🎉

Same problem here. Is there a forecast when the fix will be available?

Thank you so much @IlyaBausovAkvelon  for looking into this!

Has anyone been able to test the latest version 3.2.8? I just tried with data mode set to auto and it seems 3.2.8 did not fix this for me. Reverted to 3.2.7 with .StartApp(Xamarin.UITest.Configuration.AppDataMode.DoNotClear) and it still works for me. I don't see any mention of this in the notes for 3.2.8 so I assume this fix is still on the way.

This issue still happens on version 3.2.8 I will update this ticket to reflect that.

As far as I can tell, this is still an issue. There has been no update from dev on this error. Keep open please.

This issue still happens on version 3.2.8 with.StartApp(Xamarin.UITest.Configuration.AppDataMode.Clear);
I need the fix as soon as possible because affect the execution of my test cases. I'm not able to clear the data from the app.

This issue is still open and needs a update to be fixed

Hi all.
I've the same problem. Even when I don't use AppDataMode.Clear. I tried to decrease Xamarin UI library to 3.2.7 and It didn't help. Please solve this problem as faster as possible. We haven't any ways to run UI tetsts for physical iOS devices now.

Hi all. I've the same problem. Even when I don't use AppDataMode.Clear. I tried to decrease Xamarin UI library to 3.2.7 and It didn't help. Please solve this problem as faster as possible. We haven't any ways to run UI tetsts for physical iOS devices now.

@Viktor027: Try specifying "AppDataMode.DoNotClear". This should allow the tests to run. If you simply remove "AppDataMode.Clear", not specifying any data mode, it will default to Auto, which then defaults to Clear, which is currently broken, as noted here.

@Banley
@IlyaBausovAkvelon
@sliovino
After my testing on (12-01-2022):
This issue stated in the bug still happens in version 4.0.1 I will update this ticket to reflect that. Note, {AppDataMode.DoNotClear} does still work in version 4.0.1

We will try to fix it in the next release.

Do we dare try this on MacOS 13? I call 'not it.'

This bug is still open on version 4.1.0

@Moshex we are going to fix it.

Can we see an update for this issue? I am currently having trouble running tests on ios simulators due to not being able to clear the app. [Some tests pass, others fail due to the app having not been cleared and reset as expected before the next test starts.]

As UI-Tests are an essential part of our Deployment Pipeline this bug is a really big impediment for us at the moment. Please fix it as soon as possible. Or do you know when we can expect a fix? So that we know if we have to look for workarounds...

The issue is known and we are planning to fix it in the future.

This issue can't be tested on version 4.3.0 due to not allowing Xamarin.Uitest to run on a physical device at all. See here for reference:
https://github.com/microsoft/appcenter/issues/2475#issuecomment-1774214848

But that is also reproducing on local build 🤔

Are you talking about on an iOS Simulator? AppDataMode.Clear does work for me on an iOS Simulator just not a Physical device.

I mean iOS device
Unfortunately, there are no Xamarin.UITest repo to report that issue separately

Xamarin.UITest repo

as far as I know, this is where you report issues with Xamarin.UITest repo and yes this issue is just with a Physical iOS device. This does work on App Center and Simulators.

This issue can't be tested on version 4.3.2 due to not allowing Xamarin.Uitest to run on a physical device at all. See here for reference:
https://github.com/microsoft/appcenter/issues/2475#issuecomment-1774214848

The initial issue was fixed, so I'm closing it.


Attempt to scrub all Plug.Conns in Sentry.PlugCapture

Closes #477.
This is not foolproof, but I think it's pretty effective.

@sl0thentr0py sadly we can't really do that, because we're being very specific with the shape of the Phoenix.ActionClauseError exception here. This exception has a args field that other exceptions might not. In any case, users can always filter or change reported events with :before_send_event, so this is mostly a convenience so that Phoenix user get this scrubbing done out of the box.


No longer being actively maintained? Any alternative?

This was useful while it existed, but it seems @bassrock & @rnystrom at Instagram are done with it. Are there any alternative to this?

I actually still use my fork of it in http://www.waittimesfordisneyland.com
It is slow though and open to new ideas.


Fields without a tag can still change

Example:
type Widget struct {
    B []bytes
}

defaults.SetDefaults(&Widget{})

The B field starts out nil, but will be set to an empty byte slice, even though that field has no "default" tag.
Looking at the code, I'm thinking either setDefaultValues should check for the presence of the tag, and skip the field if not present, or setDefaultValue should check the presence of the tag (after the zero value check).
Alternatively, if this was the intended behavior, then perhaps add a default:"-" option to explicitly skip the field?  Or a flag in the Filler struct to toggle the behavior?   I'd be happy to do a PR.

Sorry, this issue was buried in on a ton of others, the library should only affect fields with the tag.  So yes feel free to do a PR.

Do you still want to maintain compat with <go1.7?  Cleanest impl uses a method added then.

It's ok to upgrade to 1.8 or 1.9

There are several tests which expected the old behavior.  There are a few categories:

Several tests use example structs with no tags, but expect them to get filled anyway.  I'm treating this as incorrect test criteria, and adding a tag to the sample struct to fix.
Several tests construct the Filler{} struct without setting the Tag field.  With the old behavior, a Filler with no Tag would still end up calling filler functions.  It would be up to the implementation of the FillerFunc to fill the value, regardless of whether the tag was present or not.  The tests are expecting those filler functions to be called, even if the struct is untagged or Filler.Tag is empty.  I'm assuming the correct behavior if the field is not tagged is that the filler func should not be called.  But in the case where the Filler.Tag field is empty, I'm wondering what you would prefer.  It seems like an error to have an empty Tag field, so I can either assume that if Filler.Tag == "", I should use the default tag of "default".  Other options: 1) have Filler.Fill() panic, 2) have Filler.Fill() return silently (effectively a no-op).
The test for the "Factory()" method now fails.  The "Factory Filler" is supposed to look for the "factory" tag, but the test uses the ExampleBasic struct, which uses the "default" tag.  The test has been passing up until now, because the filler functions in the factory filler all ignore the tag entirely.  They were always called for any field with a zero value, regardless of the tags on the field, and the filler functions just filled in random values, paying no attention to the tag.   I can fix this test by changing the tag name, or using a different sample struct that has "factory" tags, but this feels like a more breaking change.

I could maintain more of the current behaviors.  I could make it so that if Filler.Tag == "", then filler functions all get called regardless of tags, effectively reverting to the old behavior.  And I would change the factory filler to make Tag == "".  That would make most of the tests pass again without altering their assumptions, and would make the factory filler backward compatible.

Hi guys,
It's still a issue :(
Do you have a workaround for this?


.stl binary format

Current implementation is ASCII format only!

Binary format stl is supported and tested, root cause was actually something else!


python38Packages.jupyterlab_server: 2.8.1 -> 2.8.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.jupyterlab_server is: "JupyterLab Server"
meta.homepage for python38Packages.jupyterlab_server is: "https://jupyter.org"
meta.changelog for python38Packages.jupyterlab_server is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.8.2 with grep in /nix/store/lvc5a4lfxr6qfiab7xlj1c87xi5xj4y2-python3.8-jupyterlab_server-2.8.2

found 2.8.2 in filename of file in /nix/store/lvc5a4lfxr6qfiab7xlj1c87xi5xj4y2-python3.8-jupyterlab_server-2.8.2

directory tree listing: https://gist.github.com/c5215cd810e36e250390093614f8e32a

du listing: https://gist.github.com/484eabbb5c271a6b7b671cca5f7b3bd6

Rebuild report (if merged into master) (click to expand)

18 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.jupyterlab
python38Packages.jupyterlab_server
python38Packages.jupytext
python39Packages.jupyterlab
python39Packages.jupyterlab_server
python39Packages.jupytext

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lvc5a4lfxr6qfiab7xlj1c87xi5xj4y2-python3.8-jupyterlab_server-2.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.jupyterlab_server https://github.com/r-ryantm/nixpkgs/archive/cbf17c4fd382ecdc22cd5aee2129c3d8c811653d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lvc5a4lfxr6qfiab7xlj1c87xi5xj4y2-python3.8-jupyterlab_server-2.8.2
ls -la /nix/store/lvc5a4lfxr6qfiab7xlj1c87xi5xj4y2-python3.8-jupyterlab_server-2.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

python38Packages.jupyterlab
python38Packages.jupyterlab_server
python38Packages.jupytext
python39Packages.jupyterlab
python39Packages.jupyterlab_server
python39Packages.jupytext

Maintainer pings
cc @costrouc for testing.

2.8.2 already in master, see https://github.com/NixOS/nixpkgs/commit/a19db8f8a6ece0675d4a868313ea2faf00357c62


[ENH] New prob metrics

Reference Issues/PRs
Expands on #2234
What does this implement/fix? Explain your changes.
Improves prob metric tests and adds interval metrics.
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
Also refactors prob metric class, changes responsibility of dealing with score_average and multioutput from _evaluate to evaluate

Draft as I need to lint and finish implementing decided changes.

Great, thanks!
Linting is failing, but only minor stuff.

Reduced scope of PR, rework of tests will be done in separate PR. This is now only for adding the interval metrics and reworking how multioutputs/scores are handled.

Can you kindly summarize the nature of your changes in the PR first post?
I would also appreciate advice and comments on this PR:
https://github.com/alan-turing-institute/sktime/pull/2502
we should make sure that the final interfaces are type consistent:
https://github.com/alan-turing-institute/sktime/pull/2502

I found the cause of the unexpected quantile multiindex output. When using the ColumnEnsembleForecaster it adds another level to the multindex with the variable name so you end up with a 3 level multindex rather than 2. I don't think this is a bug as this would be the expected output of a ColumnEnsembleForecaster prediction. But it does cause the output to be incompatible with my metrics. The solution is to run df.droplevel(level=1) but I don't know if this should be done inside or outside of the ColumnEnsembleForecaster, what are your thoughts @fkiraly?

@eenticott-shell, thanks for tracking this down - could you be so kind and be precise which functions output a 3-level multiindex, and which functions expect a 2-level multiindex? And where the clash comes from, i.e., when substituting what precisely in which function?
Re metrics, I thought the public boilerplate part was taking care of the multiindices, converting them either way to whatever is internally used.

Issue with the ColumnEnsembleForecaster was local to the forecaster and has been resolved here: https://github.com/alan-turing-institute/sktime/pull/2512
Is this ready for review again?

@fkiraly yes this is ready for review again

Or maybe not, for some reason merging it with main has caused the tests to fail.

Or maybe not, for some reason merging it with main has caused the tests to fail.

Odd - it seems to fail your own tests though?

I use native True/False everywhere apart from the tags. I think I'd seen tags done with the pickle TRUE/FALSE somewhere else and assumed it was required. I will change this

I think I'd seen tags done with the pickle TRUE/FALSE somewhere else and assumed it was required.

I didn't find any other occurrence - where was that?

I will update naming conventions in #2683. Can we merge this one now? I don't have the option


Set minimum cclib version to support ORCA 5.0

New version 1.7.2 was finally released couple days ago that supports ORCA-5.0. I am setting this as a minimum version in setup.json.
Closes #26
CC @pzarabadip
PS: It would perhaps be nice to convert setup.json to the more modern setup.cfg approach.

Hi @danielhollas
I've been working on this and mostly thinking about cclib. I believe it is a wise decision to remove the dependency to this package. The aiida-orca currently only uses this to parse few information from the output file. I am working on writing a minimal parser within aiida-orca which would makes the plugin working. We can gradually improve the parser.
The main reason is avoiding installation a massive package to gain a little benefit from it. They also introduced a hard dependency to scipy which I prefer to avoid as it can cause later issues.
It would be nice to hear about your opinion about this idea.
Cheers,
Pezhman

@pzarabadip interesting. Yeah, that's a tough but understandable decision. I am not totally against it, also given the amount of bugs I've seen in cclib. Dependency on scipy indeed does not sound ideal (does AiiDA depend on Scipy?).
I am wondering whether it could stay as an optional dependency? Not sure how much it would complicate things. Perhaps, we could have a separate cclib_parse() function that would be called by the parser only when cclib was available, or via a optional input parameter? I haven't written AiiDA parser yet so I am not totally sure whether something like this makes sense. The output from CCLib does contain a lot of stuff, which is potentially useful to future users who might not be interested in writing parsers.
For my use case, besides the ground state energy ("energy"), I need to parse excited state energies and oscillator strength ("etenergies" and "etoscs"), and also the hessian (`"atommasses", "vibdisps", "vibfreqs", "atomcoords"). (by the way it would be nice to have hessian as a custom AiiDA type, but's that's perhaps for another plugin I guess).
So essentially I am a little worried about taking on maintaing the parser. What if for example I want to switch from TDDFT to another excited state method? Will the parser still work? etc.
Anyways, decision of course up to you. To be totally transparent, it is likely that I will end up writing my own plugin to a different QM package, most likely TeraChem to speed things up, but that's still some time away. I think I would anyways use orca to get the analytical frequencies.
best,
Daniel

Thanks very @danielhollas for the detailed answer :)
Problem with scipy is the other dependencies that it has that may have/will have conflict with other main packages. I am not sure if this is the case right now and I am being a bit conservative.
You actually answered my next question. As you are the main user of plugin whom I know, I wanted to asked what are key output parameters for you which you would like to have them parsed.
I will work on writing a minimal parser for the aiida-orca which would support ORCA 5 and will let you know once the whole thing is ready to test.
Cheers.

@pzarabadip awesome, thanks!

@danielhollas  I was reading the BSD-3 license terms (which cclib) is published under it.
It let us to have part of the code (the orcaparser) here. I just need to carefully place their license in the file and mention it in the documentation.
This is the quickest solution which we can have without rewriting the while parser.

Yeah, that sounds great. :-)

So, I close this PR and will notify you once things are done. Cheers.


Add video file/subtitles -option improvement

The add video file- and add subtitles -options should be added into the same popup that asks the movie’s information to make adding videos less cumbersome

Huh? Isn't it the same pop-up? It's the manage files pop-up in movies...

Hello,
I meant the popup that appears when you click the "Create new Movie" -button. Adding video file- and subtitle options directly to this popup might make adding movies a bit faster. Currently the user has to fill in two different popups to upload a video, while they could be combined into a single form.
A screenshot of the popup: http://imgur.com/mPdZpon

Ah smart!


June 7th - Increase Juno Fees (Proposal 297)

Should https://www.mintscan.io/juno/proposals/297 pass, this PR should be merged in

Increases min fee for Juno + steps
adds IBC atom denom (channe-1) with the new fees as well.

Thanks for this. Can we please add the new fee token to Juno's assetlist? For example, this is how Carbon did it (will only need to change the channel numbers):
https://github.com/cosmos/chain-registry/blob/f165e38bac4e72bbe598c115403afd815d1d205e/carbon/assetlist.json#L538-L569


[Bug]: Error occur when import css file from node_modules package

Version
System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 14.88 GB / 31.22 GB
  Browsers:
    Edge: Chromium (128.0.2739.67)
    Internet Explorer: 11.0.19041.4355
  npmPackages:
    @rslib/core: ^0.2.0 => 0.2.0

Details
Error occur when import element-ui css file like import "element-ui/lib/theme-chalk/index.css"

Reproduce link
https://github.com/NexxLuo/rslib-demo.git
Reproduce Steps

execute yarn install in root dir
execute npm run build  in package-c
check the error output in the console

It's a known issue, keep tracking here.


DTSPO-11028 - Import unassigned subscriptions to terraform state - SBOX

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPO-11028
Change description
Import unassigned subscriptions to terraform state - SBOX
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Plan Result (sandbox-enterprise)
No changes. Your infrastructure matches the configuration.

Plan Result (prod-video-hearings)
No changes. Your infrastructure matches the configuration.

this pr is not needed anymore the changes were merged into #55


Jaeger lightning talks on KubeCon + CloudNativeCon Europe 2018

Jaeger lightning talks on KubeCon + CloudNativeCon Europe 2018
We are looking for short ~5min lightning talks on how you are using Jaeger in your organization. If you are attending it's a great opportunity to meet and share your experience with Jaeger.
At Kubecon there will be two Jaeger sessions: Project Intro and Deep Dive. The lightning talks will be probably presented during the Deep Dive session.
How to submit
Send an abstract to<EMAIL_ADDRESS>cc @rbtcollins @ledor473 @hypnoce @yqf3139 @nlamirault @jbdalido @JodeZer @bharat-p @hzariv @xdralex @mabn @hekike @pvlugter @Dieterbe @frankgreco @otisg @ejwood79 @jnewmano @bigkraig @jkandasa @sunfaces @princeop @pavolloffay @jpkrohling @prestonprice57 @jrbury @objectiser @sloev @hwinkel @Madhu1512 @yuekui2 @valichek @dianvaltodorov @ZhouZiHe @LoungeFlyZ @jeluard @diegofernandes @d-ulyanov @jyothepro @tomersimis @ruinanchen @szdavid92 @anuptalwalkar @sul4bh @Strandedpirate @julianste @awhiteside @nklmish @sweatybridge @kevinearls @felixbarny @longXboy @drzero42 @philipgian

It's after the conference, I am closing it


[Core-Vertx] Fix freaky vertx http client test in pipeline

API change check
API changes are not detected in this pull request.

/azp run java - core - ci


UI Tweaks

Reason for change

loading state when switching resource details
handle 'get [service]' button overflow for long names.

Testing

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   53.03%   53.03%
=======================================
  Files          30       30
  Lines         709      709
  Branches      164      164
=======================================
  Hits          376      376
  Misses        331      331
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea05f9...376d9c6. Read the comment docs.


Can't compile in Arduino 1.8.5

When I try to compile for esp8266, I get:
exit status 1
invalid conversion from 'const char*' to 'const uint8_t* {aka const unsigned char*}' [-fpermissive]

config.h:
/*
 * GarHAge
 * a Home-Automation-friendly ESP8266-based MQTT Garage Door Controller
 * Licensed under the MIT License, Copyright (c) 2017 marthoc
 *
 * User-configurable Parameters
*/

// Wifi Parameters

#define WIFI_SSID "wifi ssid"
#define WIFI_PASSWORD "password"

// Static IP Parameters

#define STATIC_IP false
#define IP 192,168,1,100
#define GATEWAY 192,168,1,1
#define SUBNET 255,255,255,0

// MQTT Parameters

#define MQTT_BROKER "<IP_ADDRESS>"
#define MQTT_CLIENTID "GarHAge"
#define MQTT_USERNAME "asdf"
#define MQTT_PASSWORD "asdf"

// Relay Parameters

#define ACTIVE_HIGH_RELAY true

// Door 1 Parameters

#define DOOR1_ALIAS "Door 1"
#define MQTT_DOOR1_ACTION_TOPIC "garage/door/1/action"
#define MQTT_DOOR1_STATUS_TOPIC "garage/door/1/status"
#define DOOR1_OPEN_PIN D2
#define DOOR1_CLOSE_PIN D2
#define DOOR1_STATUS_PIN D5
#define DOOR1_STATUS_SWITCH_LOGIC "NO"

// Door 2 Parameters

#define DOOR2_ENABLED false
#define DOOR2_ALIAS "Door 2"
#define MQTT_DOOR2_ACTION_TOPIC "garage/door/2/action"
#define MQTT_DOOR2_STATUS_TOPIC "garage/door/2/status"
#define DOOR2_OPEN_PIN D1
#define DOOR2_CLOSE_PIN D1
#define DOOR2_STATUS_PIN D6
#define DOOR2_STATUS_SWITCH_LOGIC "NO"

Any idea on what I need to do to get this running? :-)

Please see: https://pastebin.com/WJShtYNC
Removing the space in the ssid doesn't change the output.

Can you go into the Library Manager in Arduino IDE and tell me what version of PubSubClient you’re on? The call signatures and methods it’s complaining about are certainly in the version I developed against. Maybe you’re on an old version of PSC?
For an example, take one of the first problems it’s compaining of - that the code is trying to cast const char to const unsigned char in publish(); the current API docs clearly state that both topic and payload are const char and that retained is Boolean: https://pubsubclient.knolleary.net/api.html#publish2.

I just checked and I'm on PubSubClient 2.6, which according to GitHub is the latest release.

Ahhh - yes! This was my problem. I knew I had the PubSubClient installed, however having also had a look at https://github.com/OpenGarage/OpenGarage-Firmware I didn't realise the only version I had installed was https://github.com/Imroy/pubsubclient which was based on 1.99.1.
Having now also installed PubSubClient 2.6.0, GarHAge is now compiling :-)
Thanks!

Glad to hear it! Enjoy. :)


CI: Stop passing manifest path to windows build

I want to check which crates are built in this case.

Mmmh, we'll have to wait a bit there until the problem with freedesktop gitlab is resolved: https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/407

Seems to work but needs to be adapted somehow to find the headers for the abi tests

It should normally work fine now :)


Indexing the ENA, DRA other databases?

Hey there - I was just wondering if you have plans to index other databases for metagenomics reads as I feel our lab's meta-analysis efforts have definitely been biased towards the SRA. We've already had really cool results using this tool so again congratulations on developing it!!

ENA/DRA/SRA are mirrored, so they are already available (pending their own sync, and me downloading and indexing the datasets :joy: )
Examples:
DRA: https://wort.sourmash.bio/view/sra/DRR013902/
ERA: https://wort.sourmash.bio/view/sra/ERR2286070/
I'll start another index update this week, just finished processing all metagenomes since last index update in August.

As for other data sources, I have some datasets from IMG (from an old collaboration) and NCBI assemblies (Genbank and RefSeq), but they are not indexed with mastiff. I update the NCBI assemblies weekly in wort, but for JGI I need to figure how to download data.
My 'barrier' for adding new data sources is: how easy is to grab metadata for what was updated recently, and how to download data from it? I figured that out for SRA and NCBI assemblies, but would love suggestion/pointers for how to do it in other databases too =]
bonus points if they don't need extra software for downloading the data; I ended up installing sra-toolkit for SRA downloads, but NCBI assemblies is just a curl piped into sourmash: https://github.com/sourmash-bio/wort/blob/19ff5e32d8f8f1087ca8186877c71f2d0f13657b/wort/blueprints/compute/tasks.py )
extra bonus points if they can stream the data, instead of forcing a local copy before I can sketch them =]


upscaled_photo_url is not working

upscaled_photo_url is not working

I can't help you if you don't give me more information about the problem you are having and how you are using the package


Incorrect connection for imageMedium binding of ResizeImage template

Environment Info:

Expected result:
Connection should recieve the value user entered.
Actual result:
For binding imageMedium, it have same value with Path.
Please refer to snapshot:

Fixed here https://github.com/Azure/azure-webjobs-sdk-templates/commit/7b4195919939ae1c600d22b69a601e892094d280


Change entrypoint

Issue #, if available:
Closes #1498
Description of changes:
Updates broken entrypoint when running directly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


API is down

Your api appears to be down on the website. The status page isn't loading either.

@taxee will this be fixed soon?

Looks like this is back up now. Closing this out, thanks!


[GEP-18] Credentials rotation e2e test

How to categorize this PR?

/area security testing
/kind test
What this PR does / why we need it:
Co-Authored-By: @rfranzke
Augments the current CA rotation e2e test with more assertions for all credentials rotated by rotate-credentials-{start,complete}.
Also

allow reusing existing shoot in e2e tests
enhance the precision of CA rotation assertions

Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/3292
Special notes for your reviewer:
As part of https://github.com/gardener/gardener/issues/3292, we plan to add some advanced checks to the e2e test. E.g.: check that the kubeconfig works in all phases of the rotation, etc. This will help us to gain even more confidence.
Release note:

NONE

/assign

Very nice, thanks again for pairing on this!
/lgtm
/approve

Fixed a few things. Let's hope the test passes now.

/retest


Windows-Terminal with vim keeping UTF chars when open/close

Describe the bug
When I edit files using vim in Windows Terminal with starship.rs prompt the screen after leaving the editing session no longer shows UTF characters properly.   This causes odd layout issues.
To Reproduce
Detailed steps to reproduce the behavior:

Setup Windows Powershell with a valid Powerline capable font and run the starship.rs prompt where it loads terraform or other special modules showing UTF characters in the prompt.
Launch Windows Terminal with a Powershell Session
change into a directory that triggers this complex UTF character to show up on the prompt
Launch vim, close vim
The previous prompts above no longer show the proper characters and the layout is confused.   Example:   💠 character.

Red shows the previous - re-rendered incorrectly after exiting vim
Yellow shows a new line.

Expected behavior
When leaving vim I would expect to see the same layout as I left.
Screenshots
If applicable, copy/paste the text or add screenshots to help explain your problem.
Environment (please complete the following information):

Vim version 8.2.2488 (nightly)
OS: Windows 10, version 20H2 (OS Build 19042.746)
Terminal: Windows Terminal 1.5.10271.0 running Powershell Core 7.1.1

Additional context

Appears to be related to an issue with how vim dumps the information back to the screen when it dumps it back out.
https://github.com/microsoft/terminal/issues/9087

WindowsTerminal cannot read UTF-8 characters from the screen that have already been printed to the screen.
…However, now vim.exe should be able to restore UTF-8 characters.
Let the terminal do all the saving and resuming, instead of the Legacy Win32 console API that vim.exe does every bit of resuming on its own.
I wonder if it's good!


[WIP] Replace lazy_load with mmap + meta + assign

Follow-up to #351
Fixes #432
Fixes? #456
A caveat of this change is that since parameters are now assigned instead of copied, the convert_hf_checkpoint.py step might need to be rerun with the --dtype ... associated to the --precision ... used during training

Any progress on this front? Is #564 another solution to the problem?


afQuickField is always text Input with autoform

Probably after update i noticed that afQuickField doesn't seem to adapt to the type of field in the schema as before. I have a field with options defined but the afQuickField is still a text input. I will paste the schema fragment and the definition.
...
  io_type: {
    type:   String,
    label:  'Categoria',
    autoform: {
      options:{input:'Input',output:'Output',io:'I/O'}
    }
  },
...

This is a part of a Schema and I want to use the foreach statement to create automatically the fields. Here the spacebars template:
....
{{#autoForm  id="ctypeform" schema=ctypeSchema doc=this}}
     {{#each afFieldNames omitFields="icon"}}
         {{> afQuickField name=this.name options=afOptionsFromSchema }}
     {{/each}}
     {{> afQuickField name="icon" type="cfs-file" collection="ctypeicons" template="bootstrap3"}}

<button type="submit">Submit</button>

{{/autoForm}}
....

and here is the generated html

    Categoria
    <input type="text" name="io_type" id="c4wPYFkRGnsiS2Gwa" required="" data-schema-key="io_type">

I know this usually works, but maybe there is a slight difference with yours. Some things you could try:

Make options in the schema be a function that returns that value instead of setting to the value itself.
Use afQuickField: { options: //etc... } or afFieldInput: { options: //etc... } in the schema instead of just options.

Ok I tried all three solution you gave:

Make option a function: unfortunately didn't change anythings
asQuickField with plain option parameter: didn't work too
asQuickField with  option as function: didn't work too
afFieldInput with plain option parameter: nope :(
afFieldInput with  option as function: nope :'(

@huvber I'm having trouble reproducing this. Please link to a repo with a simple reproduction app so I can clone and investigate.

Please retest with AutoForm 5.1.0 and close if your issue is resolved.


groupBy

groupBy arg is wrong

groupBy(lambda x: x[1])
works incorrectly;
groupBy assumes that data is [k, v] by default

fixed in #5


input/pointer: add functions for modifying pointer state

These allow a compositor to do things like skip motion events on pointer constraint unlock, or not move the pointer during touch emulation.
Refs swaywm/sway#5431, swaywm/sway#5459.

Marked as draft until the Sway-side PRs are updated / we decide if this is how we want to do this.

I extracted the wlr_seat_pointer_wrap function in a145430afac6.


Add ModelAware interface

Would something like this make sense?
If yes, it can be added on all model impls that support this ...

I think it makes sense, WDYT @langchain4j ?

Totally makes sense, hovewer I was considering exposing not only model name, but also other parameters (e.g., temperature, maxOutputTokens, etc. All of parameters listed here in ChatRequest class) that can be configured when ChatLanguageModel is created. WDYT?

Yes, maybe something like:
public interface HasModelParameters {

    String modelName();
    Double temperature();
    ...

ChatRequest could also implement it

@langchain4j nah no rush.
I just wanted to get this rolling, as I think it was useful.
e.g. what about also (Chat)Response (or any type of response, as there are already a few) having this as well?
As this would ease things with something like

https://github.com/quarkiverse/quarkus-langchain4j/pull/1138
(this is where the need for this PR came from ...)

@alesj could you please clarify regarding response/token usage?
Right now ChatResponse returns TokenUsage which has unified input/output tokens.
Regarding Response classes:

Response<T> will be removed soon, each type of model (e.g., chat, embedding, image, etc) will return it's own response type.
ChatModelResponse will be removed as well, ChatModelListener will operate with ChatResponse.

So at the end there will be a single response class for each type of model: ChatResponse, EmbeddingResponse, ImageResponse, etc.

@alesj could you please clarify regarding response/token usage?

I would also need a model type in the response -- which is only available atm in ChatModelResponse (all other response types currently don't have it).
(other params - from the discussion above - might also come in handy sometime in the future, you never know :-)

@alesj

I would also need a model type in the response -- which is only available atm in ChatModelResponse (all other response types currently don't have it).
(other params - from the discussion above - might also come in handy sometime in the future, you never know :-)

By "model type in the response" do you mean model name/id (e.g., gpt-4o-mini-2024-07-18)?
ChatResponse will have modelName after https://github.com/langchain4j/langchain4j/pull/1989 is merged. Every ChatLanguageModel implementation will eventually provide it if it is available in the API response.

By "model type in the response" do you mean model name/id (e.g., gpt-4o-mini-2024-07-18)?

Yes.
Something I can match from their pricing website. :-)

@alesj please check the description of https://github.com/langchain4j/langchain4j/pull/1989, everything that you've described should be available in the new API.
Thus I am closing this PR. Thank you for opening this discussion, it helped a lot!


Report - App crashed when open a conversation with a specific account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Precondition: user should be logged in

Open app on main testing device with account A (it could be any
Open app on the second device with account B<EMAIL_ADDRESS>)
Send message from account B to account A
Open the conversation with account B on main testing device with account A

Expected Result:
Report (conversation) should be opened and message should be displayed
Actual Result:
App crashed
If you kill and relaunch app after the first crash it will crash again on startup on iPad device
The issue is only reproducible with account B<EMAIL_ADDRESS>Account A<EMAIL_ADDRESS>Account B<EMAIL_ADDRESS>Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[x] iPad Pro 11 / native
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  1.3.57-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/f22a2fe6-cbe2-414f-8c71-ee30421eff56
https://github.com/Expensify/App/assets/78819774/fa63f174-9978-4a7a-8014-55a8f479b643
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Doesn't look like these crashes (or any iOS crashes, for that matter...) are being captured in Crashlytics

i don't see anything weird in the logs, im going to try starting a conversation from a different account to that account and see if it still happens

The only potential hint I'm seeing in logs is:
TransactionIDs are not converted to string

Not sure if that's a red herring or not though. Maybe the best next step would be to:

Run iOS app on dev to see logs
Point dev at the staging API
Supportal into the user's account (on NewDot), see if it crashes and you can get logs

Though I just realized based on the testing steps - a message needs to be sent FROM that account right? I can't really do that in Supportal, can I?

This might be relevant - I looked for weirdness on the receiving account, found this request. https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:("7fbc8c204bd724bd-KBP")+AND+timestamp:[2023-08-24T14:14:51.726Z+TO+2023-08-24T16:14:51.726Z]&index=logs_expensify-023948
Will peruse now

Okay I supportaled into the receiver's account and it did not crash on web, but the issue only happens on iOS and I don't think we can supportal on that

I don't love it but I think if it's truly only this one account, and only on iOS, we might be able to not block deploy. Definitely not going to close the issue but I don't want to slow us down. What do you think, @roryabraham?
I'm trying to figure out next steps given that we have no crashlytics data nor obvious culprits in the logs, and can't otherwise reproduce.

the issue only happens on iOS and I don't think we can supportal on that

True.

I don't love it but I think if it's truly only this one account, and only on iOS, we might be able to not block deploy

Yeah, I think I agree here. @lanitochka17 please let us know if other accounts are able to reproduce the problem. Furthermore, ask the tester to log out and back in and see if that fixes the problem for them.

given that we have no crashlytics data nor obvious culprits in the logs, and can't otherwise reproduce

IDK if this can be arranged, but it might be easy to test by just pointing a dev app at staging and coordinating with the tester to log-in with the magic code sent to their email.

@dangrous Issue reproducible on iPhone 14 Pro Max
https://github.com/Expensify/App/assets/78819774/8c8bc9c1-8fef-42bb-82dd-8a8b53e816f0
Issue reproducible on  iPad Pro 11 Pro 2nd gen
https://github.com/Expensify/App/assets/78819774/54e4f262-dc47-4258-9b97-8c1017774a80

Got it, and are those the same "receiving" account? or are they new accounts?
And have you found it to happen with any other "sending" account other than<EMAIL_ADDRESS>Lastly, did logging out and back in again in the<EMAIL_ADDRESS>account fix anything, or is it still broken?
Thanks!

@dangrous  Received message to new account from<EMAIL_ADDRESS>https://github.com/Expensify/App/assets/78819774/2e2ae258-836d-4e62-ba4d-afaf9b81aeda
Message received for new account not from<EMAIL_ADDRESS>https://github.com/Expensify/App/assets/78819774/cfe1f83f-10fe-472b-875b-be20f70fbb74
Strange but I was able to go to<EMAIL_ADDRESS>2 times without failure
https://github.com/Expensify/App/assets/78819774/188dbfb3-fc0f-4e64-a10c-9a996d648e9d

hm, weird! okay, will keep looking into it

@lanitochka17 can you confirm that this is only happening on iOS? Trying to figure out how we can investigate further. Thanks!

@dangrous did not saw console errors related to the issue in web/desktop
The issue is not reproducible in web/mweb/Android
The issue is still reproducible in iOS (iPhone/Ipad)

Got it. The next step for testing I think would be to see if I can get the account logged in on my local app. Would there be a time in the next week when we could sync up live and you can send me the magic code you get sent when I try to log in?
If it helps - or hurts - I am heading to Bali tomorrow so will be in GMT +8 instead of GMT -4

I'm gonna change this to a weekly given that it does not seem to be affecting any other accounts (that we know of) but let me know @lanitochka17 if there's a time that might work to coordinate!

I'm going to be OOO the next two weeks so I'll see if someone else has time to pick this up, but it's pretty low priority so I'm guessing it might stick around

@dangrous Hello. If the bug is not reproducible in other accounts and is of low priority, let's close it

Okay cool, I'll close it for now but if you notice it again on additional accounts I can take another look!


Support for TCP?

Hey,
In our app we use a library called CocoaAsyncSocket and we want to use your library to perform certificate pinning on our TLS secured TCP connection (I couldn't find a way to properly do it in CocoaAsyncSocket's docs).
Is it possible to do that?
Thanks,
Elad

Hello,
Yes it is possible:

You need to enable and use the socket:didReceiveTrust:completionHandler method (https://github.com/robbiehanson/CocoaAsyncSocket/blob/master/Source/GCD/GCDAsyncSocket.h#L1206) to receive the server's SecTrustRef object.
Then you can pass the trust object to [TSKPinningValidator evaluateTrust:forHostname:] (https://datatheorem.github.io/TrustKit/documentation/Classes/TSKPinningValidator.html#//api/name/evaluateTrust:forHostname:). Be very careful when doing so as evaluateTrust:forHostname: will not check the certificate at all if the domain is not pinned, and you will need to do it manually or your App will be insecure.

Thank you!
I'll try it out and be back with the results.

Great! Let me know how it goes.

Worked great and was very convenient to use. Thanks for the great lib!


Improve README.md Documentation

Hi, I updated the readme and created a pull request for it!
https://github.com/raga-ai-hub/agentneo/pull/5


Time dependent flow boundary

Fixes https://github.com/Deltares/Ribasim/issues/439.

@visr how do I properly handle 'Changes requested'?

@visr how do I properly handle 'Changes requested'?

You wait until @visr gives an approval. Let's see if I can do that too.

No, seems like Martijn has to approve himself.


Bindings for android.widget.SearchView closes #41

Note: SearchView does not allow to set query text change and query text submit listeners separately which complicates the design a little bit.

What is the status of this pull request? Is there anything else that needs to be done, aside from a rebase?

+1. I'm also curious about the status of that one


proposal: unify the parameter type naming of various plugins

Description
Some plugins use Param for the parameter type, such as

github-reposcaffolding-golang internal/pkg/plugin/reposcaffolding/github/golang/param.go

type Param struct {
	Owner     string
	Repo      string
	Branch    string
	ImageRepo string `mapstructure:"image_repo"`
}

But some plugins use Options for the parameter type, such as

jiragithub internal/pkg/plugin/jiragithub/options.go

type Options struct {
	Owner          string
	Repo           string
	JiraBaseUrl    string
	JiraUserEmail  string
	JiraProjectKey string
	Branch         string
}

This is not good. I think the Options is better here.
@summingyu Would you please help to fix it?

Of course, it would be a pleasure.

Great !!!
/assign @summingyu


[FEAT] Ant Design's  <ThemedSiderV2> change button position under mobile

Is your feature request related to a problem? Please describe.
Hey, under mobile <ThemedSiderV2> is a button popup, but I've found that it can somewhat obscure the content of the page, in this case it's a problem on all pages, and a bit worse on the create and edit pages due to the presence of the breadcrumbs, I've taken a screenshot of an example from the docs:

I was wondering if it would be possible to move the menu button up into the Header? That would be much better.
Thanks, team.
Describe alternatives you've considered
No response
Additional context
No response
Describe the thing to improve
It would be possible to move the menu button up into the Header.

Hey @linkscope you can swizzle the layout and modify it according to your needs.
https://refine.dev/docs/ui-integrations/ant-design/components/themed-layout/#customizing-with-swizzle


Bug introduced by c1d418d6

Describe the bug:
Testcase:
TEST(math, descale_change_introduced_problem)
{
    using T1 = cnl::static_number<39,-30,cnl::neg_inf_rounding_tag, cnl::saturated_overflow_tag, std::int16_t>;
    T1 a{12.4434319436550140};
    EXPECT_NEAR(12.4434319436550140, (double) a, 0.000001);
    std::ostringstream ss;
    std::ostringstream ref;
    ss << a;
    ref << 12.4434;
    EXPECT_EQ(ss.str(), ref.str());
}

Fails with:
Expected equality of these values:
  ss.str()
    Which is: "4.009767005498695985e-1292913986"
  ref.str()
    Which is: "12.4434"

To Reproduce:
This commit breaks the test case:
commit c1d418d6864ab7825c0a7b0419f33c643b3ee5c1
Author: John McFarlane<EMAIL_ADDRESS>Date:   Sat Apr 10 21:58:15 2021 +0100

    Reduce trailing zeros in _impl::descale

This works for earlier versions of CNL.
This was detected by random std::cout printing. Reproduction requires quite specific numbers.

OS: Windows 10, macOS
Compiler version: gcc-10
CNL version c1d418d6864ab7825c0a7b0419f33c643b3ee5c1

That test btw. runs for 30 seconds. Quite a long loop CNL has created...

Here's a reduced repro. It's likely stuck in the loop in descale. With some work, I'm confident I can make it take longer then a minute...

How's it looking now?

Works. Thanks!!!

https://godbolt.org/z/YrGznjd69


Minor changes to jim/update-ui

Make "load" data takes only one line
(Further modification is noted in #113)

ahhhhh wrong target!


chore: add test for shopware v6.5.6

Codecov Report

Merging #113 (635fbef) into main (bb1cf97) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #113   +/-   ##
=========================================
  Coverage     71.38%   71.38%
  Complexity      112      112
=========================================
  Files             9        9
  Lines           360      360
=========================================
  Hits            257      257
  Misses          103      103


No access being made to the server

Hello,
I cant get my head around this.
I have my app files accessible at https://xxxzzz/app/production/www
also the chcp.json and chcp.manifest is there and downloaded.
But I always get an error that chcp_updateLoadFailed with Failed to download update files but there is NO access is being made to my http server.
Also to make sure of proper hashes, after cordova-hcp build everything is again uploaded to the www folder.
What am I missing?

Hi,

Check in config.xml that you set the correct config-file url and it is accessible by the app without any redirects. It should be pointing to chcp.json file on your server. If you don't see any request made to your server in the server's logs - then most likely it can't reach it.
Check, that in chcp.json on the server content_url is set to the correct location.
Also, you can open IDE and look in the app's logs. If you are running iOS app - open platforms/ios/YOUR_PROJECT_NAME.xcodeproj file in Xcode and run the app from it. If you are running Android app - open platforms/android/ in Android Studio and run the app from it.

Thanks, will do. So far what I could see is that json files are properly downloaded, the problem is with accessing content itself. Content files are properly placed next to the content manifest.

Hmm, then step 3 should give more details on what went wrong.

Interestingly iOS makes the proper requests to the server.

Ok so far seems that it was a hashes issue, my gulp tasks were messed up dependency order and cordova-hcp ran prior finishing the task. I will check and clarify.

Thanks. Glad, that you found the problem :)

Should this issue be closed?

yes, thanks.

In my case is resolved by add .scss MIME type on IIS server.


bit more verbose data and examples to help explain each function ?

I knwo its early days but if its possible to put some data examples with some background on the logic / use case if would really help me.

Hi @joeblew99,
I added some examples for both the NPV and IRR functions, see updated readme with GoDoc links.
As for the background, you are welcome to read this: https://medium.com/@_orcaman/package-financial-for-golang-the-math-behind-the-irr-function-1eedf225d9f
Cheers,
Or

@orcaman thank you.
Will have a play


Mount media/cd images

Truly impressive, if there was only a way to mount disc images, this would be a full emulation!

i guess you can mount your own .iso files on the custom profile setup, on the homepage (scroll down)

Thx for your input! Are the default OS images available somewhere ? ( so I only have to insert the cd .iso after the OS image )

Yes, it is at the bottom of the readme. You can do something like wget -P images/ https://k.copy.sh/{linux.iso,linux4.iso,buildroot-bzimage.bin,openbsd-floppy.img,kolibri.img,windows101.img,os8.img,freedos722.img}

Thx, however running for example wget -P images/ https://k.copy.sh/windows101.img only gets me a 1.4 mb .img file, which doesn't seem to be correct.

Thx, however running for example wget -P images/ https://k.copy.sh/windows101.img only gets me a 1.4 mb .img file, which doesn't seem to be correct - any idea how to get the full image ?

Does it boot?

It's floppy image

Yes, indeed windows101 boots when I load it into v86 as a floppy - I tried as hdd or CD first!
Actually, though I was looking for win98 or 2k which I can't find on k.copy.sh.
Does anyone know if a win98 or win2000 image is also available?
And also how I may add a program to it? (I'm not very read in the hardware emulation world yet)
Thx again!

how to get files from k.copy.sh: boot up a VM with the devtools network panel open. find a request for "k.copy.sh". if you do that on windows 2000 for example, you'll find https://k.copy.sh/windows2k_state-v2.bin.zst

That's actually the first thing I tried as well! However, the inspector's network tab indicates that it is of type 'stream' and the file itself only 22mb, which is too small for a whole windows 2000 OS. Also, trying to boot the file in v86 does not work.

IMO _state-v2.bin.zst is a state file, or a partial file as v86 streams data as needed - which is super clever and greatly efficient, but bad if you want to get the full image.

it's compressed with .zst

While trying to decompress with "tar --use-compress-program=unzstd -xvf windows2k_state-v2.bin.zst"
I'm getting this error
zstd: error 70 : Write error : cannot write decoded block : Broken pipe
tar: Error opening archive: Child process exited with status 70

It seems like the file is "corrupted" or not complete. While using https://copy.sh/v86/?profile=windows2000 and opening icons/using the OS, there's new data streaming in all the time, which seems to give strength to my earlier observation that the image is streamed only partly.

Is anyone able to get the full, uncompressed image ?

Never mind, I was able to open it with BetterZip (mac app),
I assume I'd need to run the extracted .bin now somehow with qemu?

Update, got it into QEMU with "qemu-system-i386 -drive file=windows2k_state-v2.bin,format=raw -boot c -cpu pentium3"
But won't boot.

Sorry for the many messages, and thanks everyone for the help so far!
I'd be super grateful if you could help me  figure out the last part on how to:

boot the .bin
install a legacy program on it, and get it back into v86.

I'd also be happy to add a step-by-step guide to the readme thereafter on "how to run legacy software / add a program to an v86 install" for all the other users with a similar "emulating legacy software" use-case which are also not so well versed in hardware emulation (which I think might be a significant chunk).
I think an easy step-by-step guide for this would greatly increase the accessibility and uses for this amazing emulating software!

you can save the v86 state

Thx for the input, Ryan! I assume you are reffering to the Save/Load State button on top of v86 ?
I'd like to save the state, but first need to install a program from an .iso image, which I'm not able to load from the standard install, therefore need a custom install (as you indicated before ).
So with a custom install, I would need to "bring my own OS", meaning the windows2000 OS image, which I only have as the .bin (or .zst). Neither one I can load in the custom loader as hdd or cd image, which bring me back to the question how can I load a .bin file into v86 or qemu.

The .bin file is a v86-specific format containing a memory dump and the state of all registers and devices. It can't be used by any other software besides v86 (as far as I know), and isn't sufficient to run an OS (except if it doesn't access the disk after the state has been saved).
The disk images aren't available for download (at least not directly). Instead, I'd suggest downloading an installer from https://winworldpc.com/library/operating-systems and creating your own image in qemu. There is some documentation for Windows 2000 and XP here.
Alternatively, it would be possible to add a floppy disk or cdrom at runtime (and possibly create a FAT or iso9660 filesystem on the fly), buthis is currently not implemented (#54, #480).
It might also be possible to transfer files through the network card or serial port (see e.g. https://github.com/copy/v86/issues/198 or https://github.com/copy/v86/issues/753)

Thx Fabian for the clear reply! I tried it out with qemu and the linked guide, got past the setup and installation of windows2000 but then, when trying to boot it again, the BIOS says  "a disk error occured".
I was able to load windows2000 in virtual box and install the software. The final step: How do I get the virtual box image into v86 ?

v86 only supports raw images. If the image created by virtual box isn't raw, you can convert it using qemu-img convert.
Note that it isn't guaranteed to work in v86, since v86 might emulate different hardware than virtual box. Windows is fragile in terms of hardware changes.


feat: add option to not quit form after submission

Adds the option to keep the form visible after submission. Afterwards the form could be reactivated using f.Init().
This is useful for when submitting something that might fail and needs some further editing.

This should close #446


Shulker boxes stack sizes reset to 1 upgrading from 1.20.1 in certain circumstances

We updated the plugin, transitioning from version 2.2.5 to 3.6.8, all done on version 1.20.1, carefully studying all the comments on Spigot. Then we updated the server to version 1.21.1, but encountered an unexpected problem: items in shulkers (whether in the inventory or ender chest) lost their properties. Potions lost their effects, tools and armor lost their enchantments, and item stacks reduced to a single unit (64 -> 1). We don't understand what to do.

This issue has been resolved through the addition of a special legacy upgrade path command
https://github.com/WiIIiam278/HuskSync/commit/50eb9a7543a7f2cfc78696783d1d20a1e3405641


There are asynchronous operations

I have a problem that when the interface is swiping with a finger, the network request interface returns data, and the interface will not move, because the interface data is very complex, so it takes a lot of time to process. So are there any good Suggestions to solve this problem? Or how do I put time-consuming operations in another thread?
The way I process data is as follows:
JsonMapper. FromMap < T > (dataMap);
Thank you very much for your reading. I am looking forward to your Suggestions. Thank you again.

Hi @PacteraJiJiaWei
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this.
You may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


InvalidDatasourceError: Datasource URL should use prisma:// protocol

I'm using prisma in nextjs, and the env urls start with postgres://. I'm working in a gitpod container. When I run next dev or build for production and run next start, I receive this error:
InvalidDatasourceError: Datasource URL should use prisma:// protocol

If I change my urls to start with prisma://, I get:
InvalidDatasourceError: No valid API key found in the datasource URL

Any ideas? Help would be much appreciated! I've listed my schema and versions of prisma below.
datasource db {
  provider             = "postgresql"
  url                  = env("DATABASE_URL")
  shadowDatabaseUrl    = env("DATABASE_MIGRATE_URL")
  referentialIntegrity = "prisma"
}

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["dataproxy", "referentialIntegrity"]
}

model User {
  id           Int            @id @default(autoincrement())
  WishlistItem WishlistItem[]
}

model Product {
  id           Int            @id @default(autoincrement())
  name         String
  price        Int
  salePrice    Int            @default(0)
  imageUrl     String
  flag         String?
  description  String?
  buyUrl       String
  marketplace  String?
  WishlistItem WishlistItem[]
}

model WishlistItem {
  id        Int     @id @default(autoincrement())
  userId    Int
  productId Int
  Product   Product @relation(fields: [productId], references: [id])
  User      User    @relation(fields: [userId], references: [id])
}

    "@prisma/client": "^3.8.1",
    "prisma": "3.8.1",
    "next": "12.0.8",

export const getServerSideProps = async ({}) => {
  const prisma = new PrismaClient()
  const products = await prisma.product.findMany()
  return { props: { products } }
}

How are you building your Prisma Client? From the preview features it seems you might be trying to use the Data Proxy, correct?

Thanks for pointing that out! This is not a bug it's just the fact that I wasn't using the dataproxy. Thanks!

TLDR: I solved this by removing dataproxy from the previewFeatures part of my schema.

@Zineeddine998 Prisma has a feature called Data Proxy, a tool for db connection management in serverless environments (better explained in this blog post from prisma), which I was not using for this project, but had enabled it as I copied code from a previous project that was. As you can see below, it was ledt enabled.

previewFeatures = ["dataproxy", "referentialIntegrity"]

When using Data Proxy, you are given a proxy url starting with the prisma:// protocol. The url in my env var started with the postgres:// protocol, and were therefore not accepted. I was unable to deduce this from the error message, and opened the issue, and @janpio's comment helped me realise. I then solved this by removing dataproxy from the previewFeatures part of my schema.

I am using Prisma Data Proxy but I am getting this issue InvalidDatasourceError: Datasource URL should use prisma:// protocol in my integration tests using docker. Is there a way to fix this for tests so it doesn't use proxy?

I am using Prisma Data Proxy but getting this issue InvalidDatasourceError: Datasource URL should use prisma:// protocol in my integration tests using docker. Is there a way to fix this for tests so it doesn't use proxy?

@pradok So you are using the dataproxy everywhere but in tests? Please could you give me more info?

I am using Prisma Data Proxy but getting this issue InvalidDatasourceError: Datasource URL should use prisma:// protocol in my integration tests using docker. Is there a way to fix this for tests so it doesn't use proxy?

@pradok So you are using the dataproxy everywhere but in tests? Please could you give me more info?

@jacobhq  I have got CI/CD pipeline running tests in a docker container so I guess Proxy doesn't make sense(?). But do I need to use Proxy in tests? I think it would be mainly for production environment.
I am using AWS Aurora with Postgres and running AWS serverless.

I am all of a sudden getting this same error. I didn't change anything. I committed unrelated code, ran yarn dev again, and now I get this error.
I'm using pscale connect wallet-activity-local dev --port 3309 so yes, I am using the dataProxy
I've tried

switching to prisma:// which gives me the "no API key" error
removed dataProxy
both at the same time, just to cover my bases, even if it doesn't make sense

What am I missing?

I'm using pscale connect wallet-activity-local dev --port 3309 so yes, I am using the dataProxy

This does not actually look like a Prisma Data Proxy, but a PlanetScale local proxy. For that you can use a normal mysql://... connection uri.

@janpio sorry - you're right. I just went and read through all of the dataProxy stuff.
I just set up data platform, and now things are working, but what's weird was it was working for most of today, and then it randomly stopped, and I had to go set this up. Did something change on the prisma side that made me have to change it?

No - Prisma's Data Proxy is purely optional. This error message can really only happen if you configure the generation process of Prisma Client to use the data proxy preview feature and engine type.

I work on a Nextjs app with:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>I get these errors on vercel logs:
404 [GET] /_vercel/insights/view
405 [POST] /api/graphql InvalidDatasourceError: Datasource URL must use prisma:// protocol when --accelerate or --data-proxy are used
I ran out of solutions. Any hint would be appreciated.

Open a new issue please @Danubius1st and provide all the information the template asks for. Thank you.

https://github.com/prisma/prisma/issues/20237


Got a weird exception: java.lang.NumberFormatException: For input string: "0;"

Hello, everyone ,
I am using the latest version of jodd-http 3.9.1.
It has bean working well all the time until I sent a request to some url, but got this exception:
"java.lang.NumberFormatException: For input string: "0;"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:580)
	at java.lang.Integer.parseInt(Integer.java:615)
	at jodd.http.HttpBase.readBody(HttpBase.java:892)
	at jodd.http.HttpResponse.readFrom(HttpResponse.java:227)
	at jodd.http.HttpRequest._send(HttpRequest.java:831)
	at jodd.http.HttpRequest.send(HttpRequest.java:814)

When I debug the code , I found that's because of Content-Length: 0; in the response below:
HTTP/1.1 307 Temporary Redirect
Cache-Control: no-cache
Connection: Close
Content-Length: 0;
Content-Type: text/html; charset=UTF-8;
Pragma: no-cache
Set-Cookie: SESSIONID=ahyuotdnzrsrpclw

Any idea on how to fix this?

is 307 redirect response header have Location?
if there's location value, maybe you can use status code to solve this redirect problem.
`HttpRequest request = HttpRequest
.get("http://localhost:8080/test_hello_javaweb/Hello2");
request.form("auth", "ac9fc9f7-d1bb-4525-85a4-e105d54dbd5d");
HttpResponse response = request.send();
System.out.println(response);
System.out.println("url: " + request.url());
final int MAX_REQUEST_TIMES = 10;
int index = 0;
URL url = null;
try {
url = new URL(request.url());
} catch (MalformedURLException e) {
e.printStackTrace();
}
if(url != null) {
while((response.statusCode() == 302 || response.statusCode() == 307) && (index++) < MAX_REQUEST_TIMES) {
String newLocation = response.header("Location");
if(!newLocation.startsWith("http")) {
newLocation = url.getProtocol() + "://" + url.getHost().toString() + ":" + url.getPort() + "/" + newLocation;
}
System.out.println("new location: " + newLocation);
response = request.post(newLocation).send();
}
		System.out.println(response);
	}`

`HTTP/1.1 307 Temporary Redirect
Connection: close
Content-Length: 0
Date: Tue, 19 Sep 2017 02:37:25 GMT
Location: Hello
Server: Apache-Coyote/1.1
url: http://localhost:8080/test_hello_javaweb/Hello2
new location: http://localhost:8080/Hello
HTTP/1.1 404 Not Found
Connection: close
Content-Language: en
Content-Length: 1004
Content-Type: text/html;charset=utf-8
Date: Tue, 19 Sep 2017 02:37:25 GMT
Server: Apache-Coyote/1.1
Apache Tomcat/8.0.46 - Error report HTTP Status 404 - /Hellotype Status reportmessage /Hellodescription The requested resource is not available.Apache Tomcat/8.0.46
`

Thanks @restmad , but no, there is no location, the whole information is above.
I can not even get the status code because the exception is thrown at jodd.http.HttpRequest.send(HttpRequest.java:814), so I don't have the chance.

The response contains an invalid content length. It has to contain digits only. Who sends that response?

it's someone else's, belonging to a third party which provides some service, so I can't manipulate it.

I'd still file it as a bug report with them. That syntax is plain invalid.
Until they fix it you could monkey patch HttpBase. Jodd is handling as it is supposed to though.

Thanks @neroux .
I agree with you that the response is invalid.
But what do you mean by saying "monkey patch" ?

https://en.wikipedia.org/wiki/Monkey_patch
You add a local version of HttpBase where you (hopefully) temporarily change the code in question. Once they fixed their code you can remove that code again.

Okay, gotcha.
Thank you so much.

Thanx @neroux for solving this! I would add at least a better exception message, so will do that now. Do you maybe think we should fix this special case? Somehow believe that this kind of issue may re-appear.

@igr Personally I think it should stay the way it is :). Why? Of course you can check and throw a more meaningful exception and of course you can strip out non-digits. But where would this exception handling stop? The RFC is pretty clear about the content of this field and Jodd handles it in the right way.
Babysitting external input should only go that far :)

I agree, @neroux, you are right.
Well, at least a better message in the exception would not hurt :)

Meanwhile, @binarywang just override the contentLength() method and filter out the ; from the string. That should do it.

That works for me, thank you @igr


argo cron should report when CronWorkflow names exceed the length limit

Summary
The argo cron command faithfully lists CronWorkflows, even ones that are rendered invalid due to the name exceeding the 52-character limit.
The workflow controller does log the issue. But argo cron gives the impression that nothing is wrong.
Use Cases
My team would benefit from this when a dev (who is unfamiliar with the workflow controller and its logs) deploys a CronWorkflow and then uses argo cron to maintain that CronWorkflow.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

No error seen in Argo Web UI either, and it's only in the workflow controller logs when first created, not when you expect it to be scheduled.

Would anyone want to submit a PR for this?

Sure, but as a non-golang, non-JS dev it might be a little clunky.  Guessing I'd need to add a generic message field to the status like Workflow has, or maybe better a NameInvalid condition given you already seem to show that in the Web UI at least.

Related: #10264 for the UI.
It would be nice if the Controller could statically reject a CronWorkflow if it can tell that its generated name would be too long. That would prevent issues like this from happening in the first place.

My team just spent far too long diagnosing why a cron workflow was not running.  Everything in the UI looked good, including saying that the workflow would run in X minutes and then it just wouldn't.
ArgoCD (which deploys the CronWorkflows) also showed that CronWorkflow was properly deployed.
I believe this is actually a pretty high priority issue because it (almost) silently prevents a CronWorkflow from running, while simultaneously indicating that all is okay and that it will run.  I completely agree that the CronWorkflow manifest should have been rejected when submitted to the cluster.
@alexec @terrytangyuan could you take another look at this issue and adjust labels if you see fit?  I'm happy to provide more details if it helps.

could you take another look at this issue and adjust labels if you see fit?

the labels are correct. we do not currently have a priority label for features.

ArgoCD (which deploys the CronWorkflows) also showed that CronWorkflow was properly deployed.

Did you use Server-Side Apply for this? Because there is also https://github.com/argoproj/argo-cd/issues/16817 when using client-side apply

I completely agree that the CronWorkflow manifest should have been rejected when submitted to the cluster.

It seems that Workflows does not seem to have a validating admission controller, which is something we could use to reject invalid resources. I mentioned this in https://github.com/argoproj/argo-workflows/issues/12693#issuecomment-1980000601 as well, and the caveat still applies -- if a validating webhook is not installed, the case of invalid resources still has to be handled in some way, and so this issue would still be relevant for that case.

I guess I would argue that a silent failure that stops CronWorkflows from running (while indicating all is good), is actually a bug rather than an enhancement.
My team deployed a CronWorkflow and expected it to run and it didn't - plus because there was no Failure message from Argo, it didn't trigger an alert.
We do have the validating webhook and Server-Side apply.

Did the metric argo_workflows_error_count with the cause CronWorkflowSubmissionError go up.
I'm not saying this is sufficient indication, but it is the indication I would expect.

I am unaware of a validating admission controller option on argo workflows. I don't think this is currently possible, I'm intrigued by what you have enabled there.

I guess I would argue that a silent failure that stops CronWorkflows from running (while indicating all is good), is actually a bug rather than an enhancement.

The Controller does log that it is invalid, per the issue description. And that is the only thing it can do at this time.
To have other tooling like the CLI -- what this issue requests -- show that it is invalid would be a feature. They are not capable of that right now. A bug would be incorrect behavior, e.g. showing it is invalid when it is actually valid. Right now it has no indication whatsoever.

Possible improvements:

display message in status that the cronworkflow is invalid due to its length
CLI validation upon creation attempt and rejecting it if length is to great

i know this won't help creation via kubectl but do u think a cli flag that runs argo lint before accepting the submission could prevent this being created via argo cli?

@jessesuen
I wonder if CRD validation rules would help: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-rules
Here is an example:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: foos.bar.test.io
spec:
  group: bar.test.io
  versions:
    - name: v1alpha1
      served: true
      storage: true
      schema:
        openAPIV3Schema:
          type: object
          x-kubernetes-validations:
          - rule: "size(self.metadata.name) <= 52"
            message: "name must be less than 52 characters."
          properties:
            metadata:
              type: object
            spec:
              type: object
              properties:
                someProp:
                  type: string
  names:
    kind: Foo
    plural: foos
  scope: Namespaced

apiVersion: bar.test.io/v1alpha1
kind: Foo
metadata:
  name: this-is-a-very-very-very-very-very-very-very-long-string
spec:
  someProp: test

$ kubectl apply -f test-for-crd.yaml

The Foo "this-is-a-very-very-very-very-very-very-very-long-string" is invalid: <nil>: Invalid value: "object": name must be less than 52 characters.

@jessesuen
I wonder if CRD validation rules would help: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation-rules
Here is an example:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: foos.bar.test.io
spec:
  group: bar.test.io
  versions:
    - name: v1alpha1
      served: true
      storage: true
      schema:
        openAPIV3Schema:
          type: object
          x-kubernetes-validations:
          - rule: "size(self.metadata.name) <= 52"
            message: "name must be less than or equal 52 characters."
          properties:
            metadata:
              type: object
            spec:
              type: object
              properties:
                someProp:
                  type: string
  names:
    kind: Foo
    plural: foos
  scope: Namespaced

apiVersion: bar.test.io/v1alpha1
kind: Foo
metadata:
  name: this-is-a-very-very-very-very-very-very-very-long-string
spec:
  someProp: test

$ kubectl apply -f test-for-crd.yaml

The Foo "this-is-a-very-very-very-very-very-very-very-long-string" is invalid: <nil>: Invalid value: "object": name must be less than 52 characters.

That feature is only stable since kubernetes 1.29, though.

I actually prefer the programmatic solution because the ValidateCronWorkflow(..) function has some valuable checks beyond the character count.


Development discussion

Hi @dennwc, many thanks for this awesome library. I have a lot of changes i want to push to this but before i start shipping tons of code, i want to ask if there's a way to contact you to discuss some general concepts i would like to see implemented and some changes i want to have in this.
I can also explain here in a ticket but since the ideas i have touch on some basic structures in the lib i would like some input first. I can always push to my fork of course and file a PR for you to see what i am talking about.

Hi @thegrumpylion ! I'm happy to discuss any details, feel free to contact me on the Gophers Slack (#webassembly).


useFetch runs twice if using layout and dynamic component

Environment

Operating System: OSX
Node Version:     v16.17.0
Nuxt Version:     3.3.1
Package Manager<EMAIL_ADDRESS>Bundler:          Vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-mujaqc?file=pages/[...slug].vue
Describe the bug
On the first load, useFetch is executed twice. On the server and once again on the client.
The problem occurs when the following three conditions are met:

Page uses dynamic components
A dynamic component uses a variable

This doesn't work (useFetch is executed on the server and client side):
<component :is="component" />
const template = 'CustomPageTemplate';
const component = resolveComponent(template);

This works (useFetch is not executed on the client):
<component :is="component" />
const component = resolveComponent('CustomPageTemplate');

The dynamic component uses NuxtLayout component

Additional context
Possibly related to https://github.com/nuxt/nuxt/issues/13369
Logs
No response

I'm experiencing useFetch firing twice within a component which uses a form submission handler method to run useFetch. I've checked and the method itself is run once, so useFetch must be at fault.

Can't reproduce this anymore ☺


Idea: Highest/Lowest temperature of today

Idea: To implement in the maintile of the temperature sensor the highest and lowest temperature of the current day?

Right 24 hours is impossible as once maxtemp is 24 hours old you wont know what the next maxtemp time is as you haven't stored all the temps for last 24 hours.
So that leaves max temp for the day as you store the highest temp for that day till midnight and it resets
so basic idea is

if(temp > maxtemp)
maxtemp = temp
if(temp < mintemp)
mintemp = temp

schedule("60 0 0 * * ?", tempReset) //reset within 60 seconds (this is to not kill ST servers) of midnight

def tempReset() (
maxtemp = temp
mintemp = temp
)

And someway to display the min and max

test code here
https://github.com/tmleafs/Xiaomi/blob/patch-2/devicetypes/bspranger/xiaomi-aqara-temperature-humidity-sensor.src/xiaomi-aqara-temperature-humidity-sensor.groovy
I dont have one so cant test myself, no display of information just look at your device page in IDE and see if its updating, you wont see anything till the next temp update though

We should be able to schedule the reset at midnight.  Then it is the daily high and low.
I have done this with my power meter so i can see my daily high and low watt usage.

Make a pull request.  I think this looks correct.  I would have to look into the scheduler a bit more to refresh my memory.

I guess I'm not the only one, but all my temp sensors (Inc 5 aqara) are logging to Google sheets so checking this should be relatively straight forward. I can install your fork tonight to check it. Midnight for me (Paris) is in around 2 hrs so a partial test tonight and full day(ish) this time tomorrow.

dont need to install my fork the old has been merged just isnt being displayed though there is a pull request to fix stuff

Kk. no worries. Email sent me here before I checked the code.

Can anyone with a temp device confirm my code is working?

its not being displayed yet need to look at your device in IDE and see if there is values stored for max & min temp

I have a value for maxTemp but not minTemp

I don't see any code for min/max temp in the tiles, where should it be so it can be displayed?

didnt add it as I cant see what it looks like due to not having a temp device I was just adding the code to make it possible

Looked in IDE for both my  Aqara and Original Temp Sensors  - updated last night - in both cases only seeing MaxTemp, not Min
That said - my Aqara went off line last night - but a few hours after I'd updated the DTH.  Will repair now and look again.

can you try replacing

if(temp < minTemp)
to
if(temp < minTemp || minTemp == null || minTemp == "")

Then wait for the next temp change

so it's showing in the IDE - but when I do my hot breath test on it -  and temp goes from 68.3 to 68.9 0 - both min and max go up and stay the same  (min should stay at 68.3 while max goes up to 68.9 right?)

And now is temp is going down they are both going down.

Try changing

if(temp > maxTemp)

sendEvent(name: "maxTemp", value: temp, displayed: false)
if(temp < minTemp)

sendEvent(name: "minTemp", value: temp, displayed: false)

to
if(temp > device.maxTemp)
sendEvent(name: "maxTemp", value: temp, displayed: false)

if(temp < device.minTemp)
sendEvent(name: "minTemp", value: temp, displayed: false)

They are still changing in tanded- that said I've had some pairing issues which could affect it.   Will let you know more definitely by a.m.

Hiya - for some reason every single one of my Xiaomi devices went off line yesterday pm - didn't realize until this morning  (at first pass I don't think it's a DTH thing).  Busy re-pairing so it will be a while until I can test this.

If you put your app into "add thing", you should be able to just press the button on each device a few times to get them to re-add.

Sometimes that works and sometimes it creates a new dni and I have to update the device in device list.  Hoping they'll start reporting.

Is this a difference between US and EU hubs?  I literally never get Xiaomi drops, months on end they hold strong. On the other hand I expect at least 1 samsung device to drop every month or so... usually a presence sensor.  Sorry, I assume you are US due to the ridiculous temp numbers in your screenshots. Again sorry but off topic but I am genuinely surprised farenheit still gets used anywhere... is it getting phased out in schools or is it still being pushed?

 I have updated the master and should definitely work (please confirm @alecm) now just needs someone to make a nice way of displaying the information now

@foz333 - I doubt it. I have not had a single device drop from my v2 hub. Well in the 2 months I've had it, anyhow.
As for the Fahrenheit thing, I think maybe people in the US just like being able to say it's over 100 degrees when it's really hot. There's was a metric campaign back in the 1970s, and that failed miserably. Old habits never die for Americans, I guess. Me personally, I lived in Vietnam for nearly a decade and had no problem working out what the temperature in Celcius meant. It is pretty silly that we don't switch.

@tmleafs - If we don't move the last checkin information up into the main info tile, then I have found a way to combine more than one piece of information into the secondary attribute text line displayed at the bottom of the main tile. Well, I'm borrowing the idea from another DTH, but that's been the best way for me to learn how to code for these sensors.

Okay, I got @tmleafs code working with the method to display two variables together up in the main tile. Here's a screenshot from my iPad (which is still running the previous iOS version of the ST mobiel app that doesn't have the messed up UI):

I did come up with a new system of resetting the min/max temps at the end of each day to avoid using a cron schedule (which ST apparently prefers not be used if at all possible), and that's the part that really needs some testing. I didn't have it perfected by midnight local time here, and it didn't work. I'm pretty sure it should work the way I have it now. It's down the in the dateFormat() function section at the very bottom of the code. Please have a look at it in my new Pull Request and let me know what you all think. I explain how it works and my reasoning in more detail in the opening comment of my Pull Request.

Wish I could help with testing - going through minor repairing everything hell - and it’s Super Bowl...but I love seeing my humidity colors implemented - thanks !

And, btw wasn’t being flip - I still can’t get either temp sensor going reliably - and my husband made a great Super Bowl meal - and I’d be dead if I spent any more time troubleshooting HA today

Closing this because it is soon to be a reality.


Add TypeScript example

Of course, *.svg files doesn’t have types.
We can improve user’s onboarding by adding some solution for TypeScript, since it is very widely used.

How do I type the imports to get rid of this error:
Cannot find module '@/icons/play.svg?component' or its corresponding type declarations.

Normally I would do:
declare module "svg" {}`

But that gets tripped up by the odd ?component. How do I account for that in my module declaration?

I think this is a solution:
declare module "*svg?component" {
  import { ComponentType, SvelteComponentTyped } from "svelte";
  const icon: ComponentType<SvelteComponentTyped>;
  export default icon;
}

Though this doesn't work for importing the component in Astro too, which I'm using.


Separate routers

Description

Separate routers handling functions
It is hard/impossible to call any code from main.py from unit or integration tests, so it's better to refactor all functions out of it

Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

one nit
/lgtm

/retest

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3548c10) 94.26% compared to head (622e4d0) 95.36%.
Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   94.26%   95.36%   +1.10%
==========================================
  Files          32       33       +1
  Lines        1115     1058      -57
==========================================
- Hits         1051     1009      -42
+ Misses         64       49      -15

Files
Coverage Δ

ols/app/main.py
94.73% <100.00%> (-1.27%)
:arrow_down:

ols/app/routers.py
100.00% <100.00%> (ø)

ols/src/cache/cache.py
100.00% <100.00%> (ø)

ols/src/cache/cache_factory.py
100.00% <ø> (ø)

ols/src/cache/in_memory_cache.py
97.56% <100.00%> (ø)

ols/src/cache/redis_cache.py
88.88% <100.00%> (ø)

ols/src/llms/llm_loader.py
74.19% <100.00%> (-0.68%)
:arrow_down:

ols/src/query_helpers/question_validator.py
100.00% <ø> (ø)

ols/src/ui/gradio_ui.py
95.83% <100.00%> (+0.08%)
:arrow_up:

ols/utils/token_handler.py
100.00% <100.00%> (ø)

/lgtm

/approve