Seeing a green rectangle around the border of the gallery app when I run it

Steps to Reproduce
Running the flutter gallery, I see a green border around it off of master.
Doctor
Version:
Flutter (Channel master, v0.3.3-pre.2, on Linux, locale en_US.UTF-8)

I just noticed this with an app I am building.  In the emulator it didn't have it. On a Nexus 5X it didn't have it either. On the Pixel 2 it is showing a green border of about the size of 1dp.
Doctor:
Flutter 0.4.4 • channel beta • https://github.com/flutter/flutter.git
Framework • revision f9bb4289e9 (12 days ago) • 2018-05-11 21:44:54 -0700
Engine • revision 06afdfe54e
Tools • Dart 2.0.0-dev.54.0.flutter-46ab040e58

I am seeing this in my app when trying to capture a screenshot or screencast from the emulator.  Is there any workaround?  I believe this is caused by something in the Android accessibility?

I have seen this before, but it is difficult to reproduce.  Visually, that does look a lot like the TalkBack a11y focus, I will take a look and see what I can find

I have this problem when test an app in a Oneplus one with android 8.1.0, but not in a moto g3 with android 6

I solved adding this:
false
to styles.xml.
https://stackoverflow.com/questions/49541354/disable-defaultfocushighlightenabled-in-the-android-part-for-a-xamarin-forms-app

Had the same issue after updating to Flutter v0.7.5 on a Oneplus 5T (Android 8.1)

Just happened to me on 0.9.4 using the Android Emulator for Pixel API 26.
I had to uninstall and reinstall.
$ flutter doctor -v
[✓] Flutter (Channel beta, v0.9.4, on Mac OS X 10.13.6 17G65, locale en-US)
    • Flutter version 0.9.4 at /Users/jpeiffer/flutter
    • Framework revision f37c235c32 (2 weeks ago), 2018-09-25 17:45:40 -0400
    • Engine revision 74625aed32
    • Dart version 2.1.0-dev.5.0.flutter-a2eb050044

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at /Users/jpeiffer/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.2
    • ANDROID_HOME = /Users/jpeiffer/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 26.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] VS Code (version 1.27.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.18.0

[✓] Connected devices (2 available)
    • Android SDK built for x86

I saw it using a Pixel 2 & 3 Emulator.  I'm not at liberty to share the code or important part of the screen, but I can share the upper right corner that at shows the issue.

This has been happening randomly since IO.  It only seems to happen in debug mode (thankfully), but the fact that it happens is creating resistance to using Flutter on a wider scale.
Results of Flutter Doctor:
[✓] Flutter (Channel beta, v1.0.0, on Mac OS X 10.14 18A391, locale en-US)
    • Flutter version 1.0.0 at /Users/jpeiffer/flutter
    • Framework revision 5391447fae (3 weeks ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/jpeiffer/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/jpeiffer/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] VS Code (version 1.30.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.21.1

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 1 category.

I solved adding this:
<item name="android:defaultFocusHighlightEnabled">false</item>
to
./android/app/src/main/res/values/styles.xml

A great way to easily repro this is to run any app on ChromeOS. Very visible.

Just saw this on my release app on a Galaxy S8 compiled with Flutter 1.7.8 hotfix 3.
Couldn't reproduce it later for screenshot. Will try the defaultFocusHighlightEnabled workaround next.

I'm having some problem but at the bottom of my app border , i tried defaultFocusHighlightEnabled and still same , Im getting yellow rectangle . Please help
Thanks

Get this on the Pixel AVD but I don't on my OnePlus 5 device with Android 9.

It showing because you activated "Repaint Rainbow".
#To hide "Repaint Rainbow" :
Run your app -> Toggle Flutter Inspector -> More Actions -> Hide Repaint Rainbow

Hope it helps :)

I can reproduce this bug consistently by pressing the Up key when my android emulator (Nexus 6P API 28) is in focus.

I solved adding this:
<item name="android:defaultFocusHighlightEnabled">false</item>
to styles.xml.

This solves it for me 😄

There was no border until I use ThemeData() to app and adding above <item name="android:defaultFocusHighlightEnabled">false</item> works what will be the reason for that ?

This happens for me too. I see the green border around the app when I focus the input and then I can't type anything.
Flutter details:
λ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.17.0, on Mac OS X 10.15.4 19E287, locale en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
[✓] Android Studio (version 3.6)
[!] IntelliJ IDEA Ultimate Edition (version 2019.3.3)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] VS Code (version 1.46.0)
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (1 available)

! Doctor found issues in 2 categories.

I am using Pixel 2 API 28 emulator.
Adding <item name="android:defaultFocusHighlightEnabled">false</item> doesn't help. Also when I add that in android studio I see the following message android:defaultFocusHighlightEnabled requires API level 26

I solved adding this:
<item name="android:defaultFocusHighlightEnabled">false</item>
to
./android/app/src/main/res/values/styles.xml

Solved with this tutorial. thanks all :)

Same problem here, I'm using RawKeyboardListener with autoFocus set to true and I'm getting a green-bordered screen.

I had this exact same issue, I got this when I clicked some key on my keyboard by mistake. Did not happen again after I went back on the emulator. But when I had this issue, hot reload was not working for me.

Notice this issue sometimes not always reproducible

nice, resolve it!

@lgArlequin Thanks man, your solution worked like a charm for me!

I just closed app on the phone/emulator and rebuilt the app. It works for me.

I've faced the same issue in the emulators, but, not just this border, whenever this border appears, the status bar size also increases.
I can't reproduce it but some keyboard shortcut triggers it, whenever it appeared, I was trying to change my laptop's brightness, so I believe, any combo of Ctrl/Shift/Alt + F10/F11/F12 triggers it any such combo doesn't disable it.

solved this with:
flutter clean
flutter run

So i've noticed this happens when im using the emulator from android studio and i select the emulator window and then press the arrow keys... i think it selects the container or something close to that.
To solve i just close de app in the emulator and open again :D (and make sure i dont press the arrow keys)

It is still happens on all devices that I used. On Android Emulator it happens if press on PC keyboard, on real devices it happens when you use a gamepad.
If remove this from AndroidManifest.xml:
<meta-data
android:name="io.flutter.embedding.android.NormalTheme"
android:resource="@style/NormalTheme"
/>

Or if you use a custom theme, it may looks like whole screen overlaying:

This <item name="android:defaultFocusHighlightEnabled">false</item> solves the issue but only for API level 26 and above.

@jbojcic1 Did you manage to solve it? I have the same problem using RawKeyboard

This problem also blocks the functioning of GameButtonB using a gamepad, I need this function please

None of the solutions here actually work. The issue still persists.

Okay, you have to remember to put it in styles.xml for values-night. People, develop for dark mode, it is important not to keep people awake at night by creating unnecessary blue light.

My general feedback for Flutter is that the Android implementation is an absolute joke, and this is supposedly made by Google who makes Android. I have to do so many little fixes for Android here that I just do not have to do in iOS. It's not a good look for your Android ecosystem and affirms the reasons why I moved away from it in my personal life.

This is not an issue.
For anyone that happens upon this, it appears to happen when using physical or an emulated peripheral (keyboard/mouse/gamepad). The problem is that it's not really a problem. This is a focus border for navigation that is usually hidden until you use a peripheral. I'd guess for accessibility reasons. The real issue is abstraction, like usual.
You can resolve this by simply closing the app and reopening it, or turning off the focus border completely. The latter may affect accessibility though.

As there should be no changes needed in the Flutter SDK itself to address this issue, I am closing this issue. However, it is reasonable that the documentation should be updated to better explain this Android specific behavior. So, I have also created a new issue to track the documentation update: https://github.com/flutter/flutter/issues/146695. Feel free to comment on the new issue if you would like to see specific information in the documentation.


test new ganache

Test new ganache from of barge (see https://github.com/oceanprotocol/barge/pull/342)

barge was updated, so closing this


Couple of issues with Koajs OpenCollective (money not arriving at intended destination)

Couple of issues:
https://github.com/koajs/koa/issues/770
and
https://github.com/koajs/koa/issues/767
Could you sort it out so the money gets to the right people as soon as possible.
Thanks.

Also the having our name and Clown-Fox's blog on the backers list but our priority is that the coders get the money I paid to them.

Hi @ThePurpleRabbits
The way OpenCollective works is that TJ and the rest of the Koa team need to submit and expense/invoice in order to retrieve the money.  We don't make automatic transfers. The reason they use OpenCollective is that they don't want to receive the money directly into their accounts and then manage it themselves. So the funds are stored in their public page https://opencollective.com/koajs and when they submit an expense or an invoice to be paid, the funds are sent via paypal.
I'll look now into why you guys are not showing up on their readme.

That's a good idea. When they need it they'll know why they need it. Important. I am hopeful about this issue now.

exactly!

I'll close this issue for lack of activity but please feel free to reopen if there's anything else that we missed!


Slash Commands are being reported as belonging to user but can't be deleted.

Undiscord Version
5.2.0
Browser
1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)
Extension
TamperMokey
Reproduction steps
Click Trash icon to bring up Undiscord.
Click me button to grab token.
Click current button to grab Server ID token.
Click >Delete button.
Actual results
Undiscord tries to grab all messages by user including slash commands for bots, which the user can not delete.
Error deleting message, API responded with status 403!	{"message":"Missing Permissions","code":50013}
Expected results
Slash commands are ignored.
Bug affects

[ ] DMs
[ ] DMs (group)
[X] Channels
[X] Channel (NSFW)

Additional information & file uploads

any updates on this?

hey so I made a fork for anyone interested
https://github.com/theSoberSobber/slash-command-fixed-undiscord/blob/master/fixed-total.js

Fixed in #629 :)


Promising

As owner of a for-the-moment useless UFiber Instant, I am really interested on this project.
For UFiber Instant, can the steps be done via a Ubiquiti EdgeRouter (in my case ER12P)? If so, more detailed instructions on how to achieve that would be highly appreciated (a mini-guide for dumbs).
Maybe - for future versions of the tool and if possible - it would also be interesting the possibility of modifying the LOID and the LOID_PW (not that my ISP checks them, but I know others that do).
I will keep following you, and no matter if I can use it or not, thank you for doing something that should be provided by Ubiquiti.... I have never understood all the problems that the ISPs give to their customers in terms of replacing their hardward, though I have somehow accepted it... But the manufacturers?????

As owner of a for-the-moment useless UFiber Instant, I am really interested on this project.

Thank you! We (and a lot of other people) are on the same boat.

For UFiber Instant, can the steps be done via a Ubiquiti EdgeRouter (in my case ER12P)?

You are not able to do that inside the EdgeRouter since all the Ubiquiti hardware uses a tiny MIPS CPU. If that was at least an ARM64, then it would be possible to build the package for that. I'm still working on testing the Fiber with its firmware. My real Fiber device will arrive Today, so I'll have more updates for you soon!

it would also be interesting the possibility of modifying the LOID and the LOID_PW (not that my ISP checks them, but I know others that do).

Oh! You are right. The LOID/LOID_PW is changeable thru the web UI on UF-Loco/UF-Nano-G but UF-Instant has no UI. I'll dig into it and update the tool soon. Thank you for remind me.

I will keep following you, and no matter if I can use it or not, thank you for doing something that should be provided by Ubiquiti....

Yeah, I've stuck without options and had to do this. We're looking to bring other tools on this GitHub org that will do what Ubiquiti doesn't. Their hardware is pretty awesome, and I can't say that enough. But their software is just crap, unfortunately...

I have never understood all the problems that the ISPs give to their customers in terms of replacing their hardward, though I have somehow accepted it... But the manufacturers?????

Yeah... I have the same feeling...
To give you an idea, I've shared this repo with a Facebook Ubiquiti user group here in Brazil and guess what? The admins banned me from the group without any explanation. And guess who are the admins? 2 Ubiquiti employees... It is just ridiculous... If you look on the official forums, there are tons of posts discussing similar methodologies used by this tool like this one and nobody was ever banned nor the post was deleted. It is just that the employees won't comment on the post which is ok, if they don't want to provide the feature, just keep silent on "alternative" solutions.
Again, thanks for the issue, I'll update you on my testes soon.

You are not able to do that inside the EdgeRouter since all the Ubiquiti hardware uses a tiny MIPS CPU. If that was at least an ARM64, then it would be possible to build the package for that. I'm still working on testing the Fiber with its firmware. My real Fiber device will arrive Today, so I'll have more updates for you soon!

With what equipment should we update the UF-Instant so that we can change the SN?
Having an ER-X-SFP, my future plan is to replace the UF-Nano-G with the ER-X with a the UF-Instant but I do not know if it will be compatible because my ISP does not use Unifi/Ubiquiti equipment's.

With what equipment should we update the UF-Instant so that we can change the SN?

You can plug it on any SFP switch port than pass --host the IP the module has along with the other parameters then reboot it. If you put it on the WAN port it will not be accessible by its internal IP.

Having an ER-X-SFP, my future plan is to replace the UF-Nano-G with the ER-X with the UF-Instant SFP but I do not know if it will be compatible because my ISP does not use Unifi/Ubiquiti equipment's.

UF-Nano-G and UF-Loco are already tested and proved to work. UF-Instant should arrive tomorrow here so I can let you know.

Ok, UF-Instant arrived here. Does any of you guys know what is the default IP address assigned to it so we can ssh/telnet on it?
Thank you!

@SrTaronja ?

Unfortunately I am not at home this week, but I don't remember it having an IP address itself. The only place I can plug mu UFInstant is in the ER12P (I have never used a SFP module before), and from there I can manually assign an IP to that interface, but I am pretty sure that the IP will "belong" to the router, not to the UFInstant. I am not familiar on how a SFP module can be configured, but I think it is not via IP address (at least, not directly as it can be done with the other 2 ubiquiti ONTs). E.g. I know some fritz routers that allow you to configure some SFP settings via the router's web interface. I guess that some device able to interface SFP with TCP (or COM) in order to do telnet/SSH woul be needed for the UFInstant. But as I say, I am totally noob on SFP (among many other topics 😅). Next week I will be at home and I can check or do some tests if you want.

@SrTaronja That SFP is kind of special. They are basically a computer on its own. It has a MCU which has linux on it which where the OMCID process is running to deal with the GPON stuff. It is just "embedded" into the MCU transceiver.
It must have an IP address. The problem is there is no documentation whatsoever about it so we can't know for sure where to start. This guy show the device connected on the terminal. I asked the IP but he didn't reply yet...

Hello galversribeiro,
I was wondering if you could make any progress with the UFInstant. I have found a forum where someone says that the default's IP address is <IP_ADDRESS> with telnet available (ubnt/ubnt) but wihout SSH (which I don't know if it can be activated via telnet):
https://forum.mikrotik.com/viewtopic.php?t=116364&start=300
I will try next week to see if I can access that IP

Hello!
I got the IP from that forum, have enabled SSH and was able to change all properties I’ve wanted except the SN. For my particular case, I don’t need the SN, so it should have worked. However, it didn’t.
When I plug the fiber cable, the omci_app processes are killed and then the device reboot.
Other folks have told me there that this is because when the Ubiquiti watchdog detects the 3rd party OLT, the UF-Instance reboots since Ubiquiti doesn’t want to you to use it outside their own OLTs.
I’m still looking for a way to patch it and upload a custom firmware with that behavior disabled. I am able to authenticate with my ISP and get the O5 fiber status, so my code is working. The only thing missing is the SN and to remove the reboot behavior.
Will keep you posted. Thanks
Get Outlook for iOShttps://aka.ms/o0ukef

From: SrTaronja @.>
Sent: Sunday, May 2, 2021 2:14:37 PM
To: Unifi-Tools/UFiber.Configurator @.>
Cc: Gutemberg Ribeiro @.>; Comment @.>
Subject: Re: [Unifi-Tools/UFiber.Configurator] Promising (#2)
Hello galversribeiro,
I was wondering if you could make any progress with the UFInstant. I have found a forum where someone says that the default's IP address is <IP_ADDRESS> with telnet available (ubnt/ubnt) but wihout SSH (which I don't know if it can be activated via telnet):
https://forum.mikrotik.com/viewtopic.php?t=116364&start=300
I will try next week to see if I can access that IP
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Unifi-Tools/UFiber.Configurator/issues/2#issuecomment-830841035, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABD64OEFZDKAXOUCSRNXOB3TLWB73ANCNFSM43S5DIKA.

Very Very Cool Project, i realy want that for UF-Instant.
I think you know that already but on my UDM-PRO using this i can access to the SFP,
ifconfig eth9:2 <IP_ADDRESS> netmask <IP_ADDRESS> up
telnet <IP_ADDRESS>
ubnt\ubnt
But after that, i don't know.
BusyBox v1.12.4 (2019-11-01 09:41:51 UTC) built-in shell (ash)
Enter 'help' for a list of built-in commands.
help
_Built-in commands:
    . : [ [[ alias bg break cd chdir continue echo eval exec exit
    export false fg hash help jobs kill let local printf pwd read
    readonly return set shift source test times trap true type ulimit
    umask unalias unset wait_

Please ask if you need any kind of help or testing

Looking forward to your progrss with UF-Instant. Like galvesribeiro, I have managed to obtain O5 with my provider (Orange Spain) on this device, however the device reboots after a while.
It has been mentioned in Russian forums that UB locked this device by modifying the omci_app, I believe it detects when some parameters have changes (SN in particular probably) and reboots it. But could be something else, like detecting the OLT side is not UB as mentioned.

Hi everyone,
I got an UDM Pro + UF-Instant, is there any news about it ?
Thank you.

Not much yet unfortunately. Only UF-Loco / UF-Nano-G fully supported.

Patching and flashing of the UF Instant:
I have seen this  on GitHub, which looks promising to me.

I got the IP from that forum, have enabled SSH and was able to change all properties I’ve wanted except the SN. For my particular case, I don’t need the SN, so it should have worked. However, it didn’t.

Hi, it seems the sn is generated, I found this info in this post: http://forum.ru-board.com/topic.cgi?forum=8&topic=80480&start=1080#11

In UF-instant, you can't just change pon seriallike you do in EGS1. UF-instant is customized omci_app so that sn is taken from the /proc/ubnthal/sn file, which is set by the ubnthal.ko driver. The driver generates sn by gluing the letters UBNT and the last 4 bytes from the mac address. The address itself is taken from the sec partition by displacement 0xA022.
Thus, to change sn you will have to patch ubnthal.ko and adjust the mac address to sec, or modify the omci_app, or even adapt the firmware from EGS1.

Further down that thread, another post:

With UF-nano G and UF-loco the situation is different, they store sn entirely as is, and do not generate it from a mac address, as UF-instant does, so there to change it in general is not a problem.
However, I already have an idea: we can try to patch the omci_app so that sn is taken not from /proc, but from a regular file in which we can put any sn, somewhere in the rw section. You just need to figure out where the optodriver gets sn from, and if he is told omci_app, then the method should work. Plus, you still need to choose the parameters for the correct repacking of rootfs, and understand how this modified rootfs can be safely flashed, so that in case of failure, you do not complicate the life of the usb console or programmer.

Hope this info helps, maybe you already knew this stuff, but I thought it was interesting to report it back here.
Keep up the good work, thanks for what you've done 'til now.


Integrate xcodeprojlint

This would lint the project after generation with https://github.com/carambalabs/xcodeprojlint to make sure no issues exist

Wow! good idea 😛. xcodeprojlint is still in progress but I'll have a few lints working soon.


[turborepo] cypress/base:18.15.0 image always invalidates the remote turbo cache in ci for Integration Cypress Tests step

What version of Turborepo are you using?
1.9.3
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Mac
Describe the Bug
Remote turbo cache always gets invalidated when using cypress/base:18.15.0 image in ci for Integration Cypress Tests step.
Expected Behavior
Instead of having all the time this - "cache miss, executing ###-###-###" the expected behaviour will be having "cache hit, replaying output ###-###-###"
To Reproduce
Use cypress/base:18.15.0 image in ci for running the Cypress Tests step. The step includes build script and then the run tests script.
- step: &e2e-cypress
        name: '💻 UI Integration Cypress Tests'
        image: cypress/base:18.15.0
        script:
          - yarn install --frozen-lockfile
          - yarn build --token=$TURBO_TOKEN
          - TURBO_TOKEN=$TURBO_TOKEN yarn cypress:ci:init

Reproduction Repo
No response

You can use --summarize flag and diff the generated summary on two runs to debug yourself as well. If you don't see a diff, please provide a reproduction!


Rebuilding discovery image

Description
Please provide a brief description of the purpose of this pull request.
Related Issue
If applicable, please reference the issue(s) that this pull request addresses.
Changes Made
Provide a clear and concise overview of the changes made in this pull request.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/hold

/unhold

/override 'KinD tests (1.20, latest)'
Rebuilding the image to fetch the latest image.

/override "KinD tests (1.20, latest)"


Add 3.0 changelog

This is mostly done, but I have some outstanding questions.

I'm not sure about most of my instructions for upgrading hosted instances. I got some guidance from @elprans (how to add repo for testing under Debian/Ubuntu, what the installation commands need to be), but I just made up the changes needed for CentOS/RHEL and the systemctl commands. I think I have the Docker tag correct, although that one isn't live yet so I can't confirm.
Seems like, based on the feedback I'm getting re: 3.0 readiness across clients, I could probably just omit the "Client libraries" section for now? The two I've heard back on so far seem to be very close but not live yet.
Does anyone see anything in the "Bug fixes" section that doesn't belong? Anything not there that should be? There were 600+ PRs to go through starting from the first 3.0 PR. I did my best to eliminate anything that was backported or related to a feature and to leave only the items that sounded like clear bug fixes, but I undoubtedly didn't get it right 100% of the time.

@tailhook Did you want something about edgedb migrate --dev-mode and --expand in here? I had some questions about them if so.

Looks good.

Should we mention that upgrades from the beta to RCs and final reversions will be "smooth" and not require a dump/restore? Might encourage people to try it more

Thank you, Devon! I've merged it and will trigger a deploy now.


New image compositing fails sometimes

[Errno 2] No such file or directory: '/home/discord/decksite/decksite/./images/spell-crumple_sanguine-sacrament_ever-after_seasons-past.jpg'

Reported on decksite by logged_out```
--------------------------------------------------------------------------------
Request Method: GET
Path: /image/Ever After|Sanguine Sacrament|Seasons Past|Spell Crumple/?
Cookies: {}
Endpoint: image
View Args: {'c': 'Ever After|Sanguine Sacrament|Seasons Past|Spell Crumple'}
Person: logged_out
Referrer: None
Request Data: {}
Host: pennydreadfulmagic.com
Accept-Encoding: gzip
Cf-Ipcountry: US
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
Cf-Ray: 451ca5a62fc1bcb6-SEA
X-Forwarded-Proto: https
Cf-Visitor: {"scheme":"https"}
User-Agent: github-camo (65c9ebe0)
Accept: /
Accept-Language: en-US,en;q=0.5
Via: HTTP/1.1 github-camo (65c9ebe0)
Cf-Connecting-Ip: <IP_ADDRESS>
X-Forwarded-Host: pennydreadfulmagic.com
X-Forwarded-Server: pennydreadfulmagic.com
Connection: Keep-Alive

--------------------------------------------------------------------------------
FileNotFoundError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2309, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/main.py", line 372, in image
return send_file(image_fetcher.determine_filepath(requested_cards))
File "/home/discord/.local/lib/python3.6/site-packages/flask/helpers.py", line 588, in send_file
file = open(filename, 'rb')

Errno 2] No such file or directory: '/home/discord/decksite/decksite/./images/phantasmal-terrain_convincing-mirage.jpg'

Reported on decksite by logged_out```
--------------------------------------------------------------------------------
Request Method: GET
Path: /image/Convincing Mirage|Phantasmal Terrain/?
Cookies: {}
Endpoint: image
View Args: {'c': 'Convincing Mirage|Phantasmal Terrain'}
Person: logged_out
Referrer: None
Request Data: {}
Host: pennydreadfulmagic.com
Accept-Encoding: gzip
Cf-Ipcountry: US
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
Cf-Ray: 45255b63ef587a2f-SEA
X-Forwarded-Proto: https
Cf-Visitor: {"scheme":"https"}
User-Agent: github-camo (65c9ebe0)
Accept: /
Accept-Language: en-AU,en-GB;q=0.8,en-US;q=0.5,en;q=0.3
Via: HTTP/1.1 github-camo (65c9ebe0)
Cf-Connecting-Ip: <IP_ADDRESS>
X-Forwarded-Host: pennydreadfulmagic.com
X-Forwarded-Server: pennydreadfulmagic.com
Connection: Keep-Alive

--------------------------------------------------------------------------------
FileNotFoundError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2309, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/main.py", line 372, in image
return send_file(image_fetcher.determine_filepath(requested_cards))
File "/home/discord/.local/lib/python3.6/site-packages/flask/helpers.py", line 588, in send_file
file = open(filename, 'rb')

[Errno 2] No such file or directory: '/home/discord/decksite/decksite/./images/phantasmal-terrain_convincing-mirage.jpg'

Reported on decksite by logged_out```
--------------------------------------------------------------------------------
Request Method: GET
Path: /image/Convincing Mirage|Phantasmal Terrain/?
Cookies: {}
Endpoint: image
View Args: {'c': 'Convincing Mirage|Phantasmal Terrain'}
Person: logged_out
Referrer: None
Request Data: {}
Host: pennydreadfulmagic.com
Accept-Encoding: gzip
Cf-Ipcountry: US
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
Cf-Ray: 452e001b9b9cbb3c-SEA
X-Forwarded-Proto: https
Cf-Visitor: {"scheme":"https"}
User-Agent: github-camo (65c9ebe0)
Accept: /
Cache-Control: no-cache
Via: HTTP/1.1 github-camo (65c9ebe0)
Cf-Connecting-Ip: <IP_ADDRESS>
X-Forwarded-Host: pennydreadfulmagic.com
X-Forwarded-Server: pennydreadfulmagic.com
Connection: Keep-Alive

--------------------------------------------------------------------------------
FileNotFoundError
Stack Trace:
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2309, in call
return self.wsgi_app(environ, start_response)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
response = self.handle_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/discord/.local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
raise value
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/discord/.local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
return self.view_functionsrule.endpoint
File "./decksite/main.py", line 372, in image
return send_file(image_fetcher.determine_filepath(requested_cards))
File "/home/discord/.local/lib/python3.6/site-packages/flask/helpers.py", line 588, in send_file
file = open(filename, 'rb')

All these work on local after changes in 74f3c8c.
Also fixed: double-faced, meld and split cards.


chore: Upgrade to flutter 3.10 & Dart 3

Description

Upgrade this repo to dart 3 and flutter 3.10 and upgrade dependencies
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[x] 🗑 Chore

Hey @lsaudon 👋🏼 Thanks so much for your contribution!
Just wanted to let you know that these changes have already been added to the repo. So, we won't be able to merge this PR.
If you have any other ideas or find other ways to contribute in the future, please don't hesitate to submit new pull requests 🙌🏼


fix(): Java SDK for Public Cloud

:tada: This PR is included in version 1.0.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


PES packets are dropped before the target TV program is started

mirakc-arib filter --sid=<SID> --eid=<EID> drops PES packets before the target TV program is started.
On the other hands, Mirakurun holds PES packets. The maximum buffer size for holding TS packets regarding the preceding TV programs is defined by maxBufferBytesBeforeReady in server.yml. The value of maxBufferBytesBeforeReady is rounded down by the TS packet size (188) when initializing TSFilter._maxBufferBytesBeforeReady.

Added the --buffer option for the filter-packets sub-command.
See commits listed below:

f67cb1fb6fdd871aff1362655b9f01930cd75f63
1924d29c77414201e0f57031b98983c9a17fccb6


build failed, "repository no longer signed"

I have used your excellent script in the past successfully, but it seems something changed recently that is giving me the following error:
Reading package lists... Done
E: Failed to fetch http://realsense-hw-public.s3.amazonaws.com/Debian/apt-repo/dists/bionic/InRelease  403  Forbidden [IP: <IP_ADDRESS> 80]
E: The repository 'http://realsense-hw-public.s3.amazonaws.com/Debian/apt-repo bionic InRelease' is no longer signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

Edit to add : Jetpack 4.4
tried ./build_opencv.sh master, same result.

That would seem to be a problem with the with intel RealSense repository configuration. You should be able to fix that by registering the public key as shown in the setup docs here:
https://github.com/IntelRealSense/librealsense/blob/development/doc/distribution_linux.md#installing-the-packages
Feel free to re-open if that doesn't fix it, or you can google the error and there are a few issues about it on the realsense repo.

Thanks, got it to work


When using the vite vue plugin to handle sfc src referencing scss files, you must explicitly indicate the lang.

Steps to reproduce
There is a Vue SFC file here that references an SCSS file, and this file has SCSS syntax.
<style scoped module src="./app.scss"></style>

There will be the following errors.
Farm ] Failed to start the server: Error: {"name":"CssSyntaxError","reason":"Unknown word","file":"/data/co/github/farm-vue-reproduce/apps/sfc-src-scss/src/App.vue","source":".logo {\n  height: 6em;\n  padding: 1.5em;\n  will-change: filter;\n  transition: filter 300ms;\n}\n.logo:hover {\n  filter: drop-shadow(0 0 2em #9f1a8faa);\n}\n.logo.vue:hover {\n  filter: drop-shadow(0 0 2em #42b883aa);\n  // Path: apps/sfc-src-scss/src/app.vue\n}\n","line":12,"column":6,"endLine":12,"endColumn":10,"input":{"column":6,"endColumn":10,"endLine":12,"line":12,"source":".logo {\n  height: 6em;\n  padding: 1.5em;\n  will-change: filter;\n  transition: filter 300ms;\n}\n.logo:hover {\n  filter: drop-shadow(0 0 2em #9f1a8faa);\n}\n.logo.vue:hover {\n  filter: drop-shadow(0 0 2em #42b883aa);\n  // Path: apps/sfc-src-scss/src/app.vue\n}\n","url":"file:///data/co/github/farm-vue-reproduce/apps/sfc-src-scss/src/App.vue","file":"/data/co/github/farm-vue-reproduce/apps/sfc-src-scss/src/App.vue"},"loc":{"file":"/data/co/github/farm-vue-reproduce/apps/sfc-src-scss/src/App.vue","line":29,"column":6},"code":"PLUGIN_ERROR","plugin":"vite:vue","id":"src/app.scss?vue&type=style&index=0&src=7a7a37b1&scoped=7a7a37b1&lang.module.css","hook":"transform"}

Must explicitly indicate lang.
<style scoped module src="./app.scss" lang="scss"></style>

https://github.com/skywalker512/farm-vue-reproduce/tree/main/apps/sfc-src-scss
What is expected?
Work like Vite.
What is actually happening?
vite will only retrieve lang from the attrs of the style tag to fill in lang.xxx, if not, it will default to using css.
https://github.com/vitejs/vite-plugin-vue/blob/plugin-vue%405.0.3/packages/plugin-vue/src/main.ts#L523-L546
Will generate such an id.
src/app.scss?vue&type=style&index=0&src=7a7a37b1&scoped=7a7a37b1&lang.module.css

However, in the farm, CSS is the first to be matched.
https://github.com/farm-fe/farm/blob/v0.16.5/packages/core/src/plugin/js/utils.ts#L74-L79

System Info
N/A

Any additional comments?
No response

Thanks for reporting issues. I'll makescss match first.

fixed in<EMAIL_ADDRESS>


Fix for #95

Added support for valueAsDate to set and get value as javascript date. As of now if value is not set then it will set default value from valueAsDate attribute instead of value attribute.

Build is getting failed as Gulp is not getting installed.


AUTH-296: Finish the removal of the root CA

This PR does a couple of things in order to be able to finally remove the root CA:

generates serving certificates for the KAS
fixes the trust for ingress CA which caused the default router cert to be signed by the service-ca
removes the root CA and most of the original crypto code as that becomes unused

depends on:

https://github.com/openshift/microshift/pull/975
https://github.com/openshift/microshift/pull/981

/retest
this is rather odd

The errors turned out to be because of the changes to assets locations, should be fixed now

@stlaz could you please rebase?

@oglok done! :+1:

Ok, PR has been reviewed and tested. Great work @stlaz ! Glad to be merging this important milestone!
/lgtm


WorldBorder not using full CPU

Hello,
I'm pre-generating a 16k x 16k (block) world and I have a problem - it takes forever and it's not using all of my CPU (2 threads).
How do you change it so it uses all 4 cores?
Thanks

The fact that nobody responded in 2 days and this is still open is triggering me; let me close this issue.
Please reopen this if you have a solution.


Aria attributes, roles, etc

Hello. I wonder why there're no aria-labels, aria-expanded, hidden, roles and other things necessary according to WAG and other a11y standards.
So how comes it's accessible?

Hi @rootical
To answer this question you should ask what "accessible" means? You can find and read about this topic everywhere online. This is just one of the online examples:

The Web is fundamentally designed to work for all people, whatever their hardware, software, language, location, or ability. When the Web meets this goal, it is accessible to people with a diverse range of hearing, movement, sight, and cognitive ability.

Web accessibility means that websites, tools, and technologies are designed and developed so that people with disabilities can use them.

Taken from www.w3.org
The attributes you specified above could help you to make of your code accessible out of the box (thanks to the modern browser support) but they do not necessarily guarantee that. Adding them to your code would not make magically things accessible, you still have to do extra work to ensure this.
If you ask a person (let's say with visual visual impairment) and tell them that your code has those attributes and hence it is accessible - it would not make much sense for them. Your "work" is accessible when it works well with assistive technology OR even better let people with different range of abilities to test it (color blindness, visual impairment, etc).
Now going back to the a11yAccordion. Yes you are right there. This code does not have those  attributes you have specified. But at the same time were just in their experimental stage 3 years ago.
What is important is that a11yAccordion was tested using different assistive technologies (JAWS, Mac built-in text-to-speech) as well as it was tested by various users with a range of abilities. Furthermore, this component was also used in ATutor which is LMS for students with various needs. ATutor in fact was written by the same developer who created AChecker mentioned as the tool to test your websites for accessibility on https://www.ontario.ca/page/how-make-websites-accessible
The only concern is that a11yAccordion was written and tested a while ago. I'm not sure how much browsers and assistive technology has changed since then. But then this code uses pretty standard DOM properties so I doubt that it would be much different.
@rootical I hope it answers your question.


feature/help with fees additional apllication

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-3723
Change description
Changes for help with fees for additional applications
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Have closed to save pods

Closed to reduce pods


Port app code to typescript

Ya TypeScript in the app. Thanks :)
It runs for me locally. I'll review.

Ya TypeScript in the app. Thanks :)
It runs for me locally. I'll review.


doc: add changelog

Codecov Report

Merging #243 (5228a66) into master (e1ed503) will increase coverage by 55.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           master      #243       +/-   ##
============================================
+ Coverage   44.56%   100.00%   +55.43%
============================================
  Files          33         1       -32
  Lines        2051         1     -2050
============================================
- Hits          914         1      -913
+ Misses        994         0      -994
+ Partials      143         0      -143

Impacted Files
Coverage Δ

pkg/apisix/nonexistentclient.go

pkg/ingress/apisix/tls.go

pkg/seven/state/solver.go

pkg/types/event.go

pkg/api/router/router.go

pkg/version/version.go

pkg/seven/conf/conf.go

pkg/types/timeduration.go

pkg/metrics/prometheus.go

pkg/seven/state/route_worker.go

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ed503...83ffb1e. Read the comment docs.


Parse name from email

Do you consider valuable and meaningful feature for parsing name out of an email address? E.g<EMAIL_ADDRESS>=> Mila Votradovec.
I am willing to contribute, but want to discuss the idea first.

Yes, I think that's a great idea. You could just split on . and then join on space. delimiter and then run the same name matching function on the string.
var emailFullName = email.split('.').join(' ');
I'm happy to have this addition.

@chovy I realised this is still here after 2 years :-D I'll try to submit a PR by the end of this week.

Sounds good!


mysql-cluster minor fixes

here are some minor fixes for the mysql-cluster project that I noticed when going through it today
also because it popped up when i was trying to find the Slave_IO_Running and Slave_SQL_Running key:value pairs and couldn't see them, that i found out about:

Starting from MySQL 8.0.22, the MASTER and SLAVE terminology in replication has been replaced with SOURCE and REPLICA. The old terms are still supported for backward compatibility, but the new terms are preferred.

So there are two changes to those key/values
But I also then adjusted some of the text to make it clearer that MASTER/SOURCE are the same and SLAVE/REPLICA are the same.
However this can read a bit weird, for example reading REPLICATION REPLICA in one of the queries is a bit unclear
@maksimov

@maksimov done
one small question what you want to have on line 22
in the original brackets was (master-slave)
could that be (source-replica)
or as I have done at the moment to remove it

@bazmurphy sorry for the delay. We internally call it "primary" (because of how Vitess calls it), but SOURCE is probably the best choice.


Implemented run goal to perform entire required lifecycle

Resolves #541

This link is for the intended second screenshot related to the run goal failure:
https://ci.appveyor.com/project/wasdevb1/ci-maven/builds/27970312/job/4yqalv2m99n5wram#L11897


[9.x] Prevent model serialization on sync connection.

It prevents additional queries from being made by not serializing models that are meant to be executed synchronously.
It might not be a big optimization but it can help reduce the request execution time, especially when the properties are QueueableCollections or QueueableEntitys that have many loaded relations.

This could introduce subtle bugs into applications as sync queue is often used when testing jobs.

This could introduce subtle bugs into applications as sync queue is often used when testing jobs.

I understand your concern, one of the reasons I am proposing this change is to reduce execution time of tests. For one test the difference is irrelevant, but if you have thousands of tests that send models to different queues it could make slight difference in your pipeline.
We use the sync queue in our testing jobs to allow them to be tested, not to make sure that the sync connection serializes and deserializales our models correctly. We should trust that is a framework feature that has already been tested.
Maybe I am mistaken, but shouldn't the model/collection being passed into the job be exactly the same as the one that was loaded miliseconds before in the same request lifecycle? So why reload it along with all its relationships?

This is to ensure that queues behave exactly the same.


Support stellar-core protocol 12

The upcoming stellar-core protocol 12 release will add support for CAP 24 ("Make PathPayment Symmetrical").
To support this change, the following steps are necessary:

Existing PathPayment operation should be deprecated (it will be renamed to PathPaymentStrictReceive in protocol 12, with behavior unchanged). Consider adding the new operation name immediately as an alias during the transition period.
Once v12 is voted on and is adopted by the network, a new operation, PathPaymentStrictSend will be available and should be provided. This is expected to happen around the end of October, 2019.
Horizon will continue to provide the old path_payment operation name in responses until Horizon 0.24. Both types of path_payment operation will be returned with the existing name. In Horizon release 0.24 (targeted for ~10 weeks from now, Horizon will change, and begin to return path_payment_strict_receive and path_payment_strict_send in the type field of responses that refer to operations or payments. You should update client code if necessary (e.g. for validation) and note this for users.

For further information, see the following issues in the SDF Go monorepo:

stellar/go#1737 - overview and rationale
stellar/go#1771 - Go SDK work pre-v12 vote
stellar/go#1772 - Horizon work related to v12
stellar/go#1773 - Go SDK work post-v12  vote

if supported in the java sdk, it should be supported here.


Make surrounding shadow configurable

At a minimum include or not.

Added exterior and interior to config settings.


Commit access to gitscm

Can we please have more people with commit access to gitscm, pushing to gitscm.com?
There are 10 pull requests and 11 issues with a huge lag. gitscm.com seems to be the first place many people hit, so it should be up to date. It links to the "git community" (git mailing list) but it's hard for that community to get involved, the way it currently is.
The alternative is forking (again) and finding a new domain, of course, but let's not go there.

i suppose i should probably ask the ML to see if anyone else wants to share the responsibility.  The problem is that not many of the Git guys I know well (ie: met at a gittogether) are big web guys.  I may be able to rope @matthewmccullough into some blog help, which would be good.
Are you volunteering?

Rope me in.  I'll help with the blog.
On Mar 5, 2012, at 10:28 AM, Scott Chacon wrote:

i suppose i should probably ask the ML to see if anyone else wants to share the responsibility.  The problem is that not many of the Git guys I know well (ie: met at a gittogether) are big web guys.  I may be able to rope @matthewmccullough into some blog help, which would be good.
Are you volunteering?

Reply to this email directly or view it on GitHub:
https://github.com/git/gitscm/issues/17#issuecomment-4327322


Can't download the dataset

When I want to download the dataset it asks me to register and then login (a couple of months ago it was available for everyone). When I register and verify my email it says:
Thank you for verifying your email address. Your request for access to the dataset is now being reviewed. You will be notified when it is approved.
In the meantime, if you wish to inquire about the status of your request, please email<EMAIL_ADDRESS>
However I haven't received any approval, and when I email that address, it says the mailbox is unavailable. So I'm stuck with no dataset. Could you please pass a link to download the dataset? I'd appreciate it very much
Thanks

a couple of months ago it was available for everyone

Nope, it's always been behind a login page :)

Could you please pass a link to download the dataset?

I'd love to but you didn't include an organization and there's no telling from your website that you don't represent a commercial entity. Sorry!


Machine mac-10 lost external connection from iPhone device.

Machine mac-10 lost external connection from iPhone device.

External connection has been restored by rebooting mac-10.


Use the same shared FileSystem instance across calls in HadoopTableOperations

Closes https://github.com/Netflix/iceberg/issues/92.

@mccheah I'm not clear on the value of this change.  The file system instance will actually get reused because it's cached at the FileSystem level (https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L156).
I really don't have a strong opinion for either implementation.  @rdblue thoughts?

The rationale explained in the issue that was in the previous repository. See https://github.com/Netflix/iceberg/issues/92 and https://github.com/Netflix/iceberg/issues/91.

I'm also very much averse to JVM-wide caching, as FileSystem.get does.

Sorry, I reviewed the copy of this in the Netflix repo: https://github.com/Netflix/iceberg/pull/108
Overall, the change is okay. I think it is fine to expose the factory method as long as it is package-private and only used by HadoopTableOperations. But that really limits the utility of it, while going against best practices for using the Hadoop FS API.
I think the best option for the use case is to subclass HadoopTables & HadoopTableOperations and replace the current behavior if you need to.

A compromise could be to have HadoopTableOperations have an overridable method like so:
FileSystem getFileSystem(Path path, Configuration conf);

The default implementation can just call Util.getFs, but overriding this can run their own caching layer.

Suggested the above in https://github.com/apache/incubator-iceberg/issues/13. If we prefer that, we can close this.

Closing in favor of #15 .


docs: improve daft integration docs

This PR improves the Daft integration docs to better highlight key Delta features.

@MrPowers - ubuntu_latest build is failing, not sure how to resolve. traceback:
running 3 tests
test test_action_reconciliation ... ok
test test_concurrency_local ... FAILED
test test_integration_local ... ok

failures:

---- test_concurrency_local stdout ----
thread 'tokio-runtime-worker' panicked at /home/runner/work/delta-rs/delta-rs/crates/test/src/concurrent.rs:149:35:
called `Result::unwrap()` on an `Err` value: ObjectStore { source: Generic { store: "LocalFileSystem", source: Metadata { source: Error { depth: 1, inner: Io { path: Some("/tmp/.tmpV3LdnO/concurrent_workers/_delta_log/_commit_900c41d2-4500-46a3-909e-90a370819a27.json.tmp"), err: Os { code: 2, kind: NotFound, message: "No such file or directory" } } }, path: "_delta_log/_commit_900c41d2-4500-46a3-909e-90a370819a27.json.tmp" } } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'test_concurrency_local' panicked at /home/runner/work/delta-rs/delta-rs/crates/test/src/concurrent.rs:69:28:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(102), ...)

@avriiil it's a flaky test that one, so no worries, I tetriggered it


Response's charset ignored when returning a dictionary (as json)

Hello,
First of all thanks a lot for the great tool, it's the best and the simplest lib to create API with python.
I saw that when returning a dict, it is automatically converted to json and the content-type header is automatically set to application/json.
That's nice but in this case the charset is ignored. Usually, we want the content-type to be application/json; charset=utf-8
(the charset can be different for those who explicitly set another charset before returning the dict, but now there is no way to set the charset in the response when returning a dict.
I think this happens at line 1960 (in bottle.py master):
    if isinstance(rv, dict):
        #Attempt to serialize, raises exception on failure
        json_response = dumps(rv)
        #Set content type only if serialization successful
        response.content_type = 'application/json'
        return json_response

Maybe we can have something like this instead:
    response.content_type = 'application/json; charset=' + response.charset

what do you think?

See http://stackoverflow.com/questions/19814908/why-content-type-header-to-use-for-json-application-json-charset-utf-8-or


making sure we don't charge an application fee on development or staging

Otherwise we have this error:
```Can only apply an 'application_fee' when the request is made on behalf of another account (using an OAuth key or the Stripe-Account header).``

@asood123 what do you recommend here? Because creating a new Stripe key won't help since it will have to be linked to a difference Stripe account altogether.


Get table record ram payer info inside of a smart contract

Please add possibility to get ram payer account name for any table record from inside of a smart contract.

Hello, do you have any news when will be possible to get ram_payer info for table records inside of a smart contract?
Right its possible to see from cleos and eosjs but not from contract.
Thanks in advance,
Bohdan

Also please add possibility to get info about table creator (who paid 112 bytes for table creation) from inside of a smart contract.


Learn CSS Rewrite 2.3 The Box Model

Individual tasks for the rewrite of the learning CSS section. This one for the third part of the CSS Building Blocks section.

Pretty similar to the existing guide to the Box Model.

What is the Box Model?
Basics of margin collapsing
Changing box-sizing

https://docs.google.com/document/d/1vN0gWLZe_IweWJnYi9q1eMBUsaxdafxfu-ed383nPI8/edit?usp=sharing

https://developer.mozilla.org/en-US/docs/User:chrisdavidmills/CSS_Learn/The_Box_Model
The original covered overflow, however I have a separate section for that.
It also covered some backgrounds and borders stuff that I think could go into a separate module as mentioned in the other issue, which could also cover color a bit more, things like gradients. This one is quite lengthy already.

Hey there! I've had a read, and here is some feedback:

The first section is way too complicated for a beginner audience, imo. For example, "The type of box applied to an element is defined by the display property and relates to the outer value of display" — I think we need to wait a while before talking about inner and outer display.

To begin with, I think we need to show just a very basic example with a few block elements, and a few inline elements, and show the difference between the two main types of display first. Say about how elements have a default display value that governs whether they sit on one line or not, etc.

Then you should talk about the fact that you can use the display property to change display types, and show something more like the existing first two examples and how you can use display: inline to make a bunch of block elements sit on the same line if you want to.

Covering display: none might be nice too — show an example, talk about its uses, talk about potential a11y problems that can result.

then talk about the box model like you have done. This bit is really good.

then move onto margin, padding, etc. like you have.

I'd also like to see some stuff about advanced display values like flex, grid, etc. Say that these will be covered in other places, and provide some links.

Maybe also touch on inner and outer display values somewhere too? I'd be careful though. I struggle with this concept, so I'm not sure how beginners would cope.

The first section is way too complicated for a beginner audience, imo. For example, "The type of box applied to an element is defined by the display property and relates to the outer value of display" — I think we need to wait a while before talking about inner and outer display.

I disagree. This is how we are going to talk about this stuff from now on. It's how it's now defined, new people get the benefit of understanding this stuff from the outset. It's confusing if you didn't start out that way as essentially we've backed this stuff into the specs as a definition.

"Then you should talk about the fact that you can use the display property to change display types"

This is about the box model not the display property though. The same for talking about grid and flex. This is about the box model. I don't think muddying the waters by talking about different layout methods now is helpful.
I need to mention these things in as much as it is important for people to understand that everything is block or inline, it doesn't matter if it is a flex container or something with display: block, but heading down the road of starting to define what grid and flex layouts are ...? We already have material on that.

I disagree. This is how we are going to talk about this stuff from now on. It's how it's now defined, new people get the benefit of understanding this stuff from the outset. It's confusing if you didn't start out that way as essentially we've backed this stuff into the specs as a definition.

OK, fair enough. But in that case you need to explain it carefully and slowly...I'm still worried that it is going to blow people's minds ;-) As it was written, you kind of mentioned it in passing, almost as if we'd talked about it previously. Maybe include a dedicated section to explain inner and outer display in a separate section somewhere?

This is about the box model not the display property though. The same for talking about grid and flex. This is about the box model. I don't think muddying the waters by talking about different layout methods now is helpful.

I need to mention these things in as much as it is important for people to understand that everything is block or inline, it doesn't matter if it is a flex container or something with display: block, but heading down the road of starting to define what grid and flex layouts are ...? We already have material on that.

Yeah, I didn't mean you should go into them in great detail; just mention in passing that there are other display types too, which we'll talk about in other places.

@chrisdavidmills so I have revised the introductory part of this one, I really think the key thing is the focus on block and inline layout, because they don't have the context of other values as yet.

This is looking much better, cheers @rachelandrew !
I had a few more comments:

"If a box is defined as a block, it will behave in the following ways:" — one key thing I think needs to go into the lists of block and inline characteristics are typical width behaviour — block elements by default span 100% of the width of their parent elements, while inline elements are as wide as their content?
In the padding example, with the .container and .box boxes, it might be nice to get them to try changing the padding of container too, and help them understand that .box is the content of .container — it works the same way even though the content is another element, not text.
In the inline block section, it might be good to highlight the inline-block characteristics, like you did for block and inline earlier on. I think it is most important to understand that boxes will not break onto a new line, but width and height will apply and padding, etc. will have an effect on the position relative to surrounding elements. Maybe also give spme examples of where inline block is so useful, e.g. the classic horizontal nav items. you don't need to show example code here, maybe just describe, show an image, and link to an example somwhere else?

I already had the width behavior (spoiler, it's not width) "The box will extend in the inline direction to fill the space.". I have added that in most cases this is width. Could link up the writing modes stuff.
People will be confused about the two value syntax if we persist on insisting that inline = width.
The padding example, that's a good addition. Have done so.
inline-block, turned out it was easier to build an example than find an example, so I have done!

All sounds reasonable. I've had a look at your latest updates, and I think it all looks good. I think we can call this one done for now. I'll probably make a few more additions when we put it in the right place.

I've added an issue which is essentially a task for going through the whole lot for consistency once I'm done, so as well as adding links and so on, making sure I haven't repeated myself or failed to mention something which will be obvious when read as one complete piece.


result service is looking for the service name 'votes' and not 'vote'

Only tested on docker-compose.yml and not simple

Actually, you are correct and it was another issue. However, I'm still seeing a query issue for votes in the logging: Error performing query: error: relation "votes" does not exist

Yes, that will happen if the results app starts before the worker (which is the service responsible for ensuring the table exists). It's not a fatal error, so you can ignore it.


Set iptables rules at startup

Hi,
I use a direct routing load balancer to balance load against my rancher servers (https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Load_Balancer_Administration/s2-lvs-directrouting-VSA.html). One of them is under RancherOS and the only way (except using arptables, which isn't available on RancherOS) to make direct routing work is editing iptables rules. Is there a way to make them persistent across restart ?
Thanks !

I think there's a way: a privileged service container that runs on boot which executes a script applying the iptables rules.
iptables-rules:
  image: yourname/iptables-rules
  command: ./set-rules.sh  # can be omitted if set in Dockerfile with ENTRYPOINT or CMD
  net: host
  privileged: true
  labels:
    io.rancher.os.scope: system
    io.rancher.os.detach: false
    io.rancher.os.remove: true
  links:
  - network

This is a compose template for such a container. You can put it under under rancher.services in your cloud-config, or make it available via HTTPS and enable it with either cloud-config (under rancher.services_include) or with ros s enable <URL>

@imikushin do you guys have documentation on all the labels and their meanings you guys are using?

@gregory currently, there is no documentation on all the labels and their meanings, but we can look into adding it into our documentation. Created this issue, https://github.com/rancher/os/issues/476, to track it.

thanks @deniseschannon  !

@moimael here below is an example where i used busybox run an init script at bootstrap:
#cloud-config
hostname: rancher-x
ssh_authorized_keys:
  - ssh-rsa ...[your ssh key]
write_files:
  - path: /opt/rancher/init/start.sh
    permissions: 0755
    content: |
      #!/bin/sh
      iptables-restore < /opt/rancher/init/rules-save
  - path: /opt/rancher/init/rules-save
    permissions: 0644
    owner: "root:root"
    content: |
      *filter
      :INPUT DROP [0:0]
      :FORWARD ACCEPT [0:0]
      :OUTPUT ACCEPT [0:0]
      -A INPUT -i lo -j ACCEPT
      -A INPUT -i eth1 -j ACCEPT
      -A INPUT -i docker0 -j ACCEPT
      -A INPUT -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
      -A INPUT -m conntrack --ctstate NEW -m multiport -p tcp --dports 22,80,443 -j ACCEPT
      -A INPUT -p icmp -m icmp --icmp-type 0 -j ACCEPT
      -A INPUT -p icmp -m icmp --icmp-type 3 -j ACCEPT
      -A INPUT -p icmp -m icmp --icmp-type 11 -j ACCEPT
      -A FORWARD -i docker0 -o eth1 -j ACCEPT
      -A FORWARD -i eth1 -o docker0 -j ACCEPT
      -A FORWARD -i eth0 -o docker0 -j ACCEPT
      -A FORWARD -i docker0 -o eth0 -j ACCEPT
      COMMIT
  - path: /etc/ssh/sshd_config
    permissions: 0600
    owner: "root:root"
    content: |
        UsePrivilegeSeparation sandbox
        Subsystem sftp internal-sftp
        PermitRootLogin no
        AllowUsers rancher
        PasswordAuthentication no
        ChallengeResponseAuthentication no
rancher:
  debug: true
  cloud_init:
    datasources:
      - ec2
  network:
    dns:
      nameserver:
        - <IP_ADDRESS>
        - <IP_ADDRESS>
  state:
    fstype: auto
    dev: LABEL=RANCHER_STATE
    autoformat:
      - /dev/vda
  services:
    init_script:
      image: busybox
      volumes:
        - /opt/rancher/init:/opt/rancher/init
      working_dir: /opt/rancher/init
      links:
        - network
      labels:
        - io.rancher.os.scope=system
      command: ./start.sh
      net: host
      privileged: true

Hi @imikushin
your example at issuecomment-127362076 could be based on a RancherOS / os-service image? So existing image could be reused with correct file permissions and the same filesystem (base).
Regards

@gregory tried your solution, but I have failed miserably

the system fails to pull the busybox image, because network may not be available at the time when this service is started (solved by wait-for-network)
/opt filesystem is not ready when booting first time (it fails on command not found)
the recent version of busybox no longer contains iptables and iptables-restore commands
when I use iptables from the host system within busybox, I get kernel panic

#cloud-config
hostname: rancher-os
ssh_authorized_keys:
  - ssh-rsa xxx
write_files:
  - path: /opt/rancher/init/iptables.sh
    permissions: "0755"
    owner: "root:root"
    content: |
      #!/bin/bash
      iptables -F
      iptables -P INPUT DROP
      iptables -P FORWARD ACCEPT
      iptables -P OUTPUT ACCEPT
      iptables -A INPUT -i lo -j ACCEPT
      iptables -A INPUT -i eth1 -j ACCEPT
      iptables -A INPUT -i docker0 -j ACCEPT
      iptables -A INPUT -m conntrack --ctstate ESTABLISHED,RELATED -j ACCEPT
      iptables -A INPUT -i eth0 -p tcp -m multiport --dports 2222 -m conntrack --ctstate NEW,ESTABLISHED -j ACCEPT
      iptables -A FORWARD -i docker0 -o eth1 -j ACCEPT
      iptables -A FORWARD -i eth1 -o docker0 -j ACCEPT
      iptables -A FORWARD -i eth0 -o docker0 -j ACCEPT
      iptables -A FORWARD -i docker0 -o eth0 -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type destination-unreachable -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type source-quench -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type time-exceeded -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type echo-request -j ACCEPT
  - path: /home/rancher/.docker/config.json
    permissions: "0660"
    encoding: b64
    content: xxx
  - path: /etc/ssh/sshd_config
    permissions: "0644"
    owner: root:root
    content: |
      Port 2222
      AuthorizedKeysFile .ssh/authorized_keys
      UsePrivilegeSeparation sandbox
      ClientAliveInterval 180
      Subsystem	sftp /usr/libexec/sftp-server
      UseDNS no
      PermitRootLogin no
      AllowGroups docker
rancher:
  cloud_init:
    datasources:
      - ec2
  network:
    dns:
      nameserver:
        - <IP_ADDRESS>
        - <IP_ADDRESS>
    interfaces:
      eth0:
        dhcp: true
      eth1:
        address: $V4_PRIVATE_IP/16
        mtu: 1450
  state:
   fstype: auto
   dev: LABEL=RANCHER_STATE
   autoformat:
     - /dev/vda
  services:
    init_script:
      image: busybox
      net: host
      uts: host
      pid: host
      ipc: host
      privileged: true
      volumes_from:
        - user-volumes
      volumes:
        - /sbin/iptables:/usr/bin/iptables:ro
      labels:
        io.rancher.os.scope: system
        io.rancher.os.after: wait-for-network, cloud-init
      command: /opt/rancher/init/iptables.sh

Well at the end I just setup iptables rules in /opt/rancher/bin/start.sh. It is possibly incorrect, but seems to work (so far, on the first sight).

A cloud config solution should be available after RancherOS 0.4.3 release.
#660

This should be working in v0.4.4.

How do we do this in v0.4.4.?
The following doesn't work
write_files:
  - path: /var/lib/iptables/rules.sh
    permissions: "0755"
    owner: root:root
    content: |
      iptables -A INPUT -p tcp -m tcp --dport 22 -j ACCEPT
      iptables -A INPUT -p tcp -m tcp --dport 80 -j ACCEPT
      iptables -A INPUT -p tcp -m tcp --dport 443 -j ACCEPT
      # the last line of the file needs to be a blank line or a comment
rancher:
  network:
    interfaces:
      eth0:
        dhcp: true
        post_up:
        - bash /var/lib/iptables/rules.sh

I'm seriously stuck on this as well.
I've tried many things throughout the day...
I can't find any debug info on services that I add to the cloud config.
  services:
    init_script:
      image: library/docker:1.10.3
      net: host
      uts: host
      pid: host
      ipc: host
      privileged: true
      volumes_from:
        - user-volumes
      volumes:
        - /opt/rancher/init:/opt/rancher/init
        - /var/run/docker.sock:/var/run/docker.sock:ro
        - /sbin/iptables:/usr/bin/iptables:ro
      labels:
        - io.rancher.os.scope: system
        - io.rancher.os.after: wait-for-network, cloud-init
      command: /opt/rancher/init/iptables.sh

I can ros s build init_script and ros s start init_script in the ubuntu-console just fine (although it doesn't seem to set my iptables command at all)
Upon reboot I get
ERRO[0025] Failed starting init_script: no such image
ERRO[0025] Failes to start: init_script : no such image
ERRO[0025] Failed [2/4] 50%
FATA[0025] no such image

I'm starting to wonder if I might not be better with ubuntu for my rancher hosts.
Did anyone here succeed at setting up custom iptables rules?

@sschueller The problem is that the file needs to be written in the network container so that the post_up can access it. We fixed this in v0.6.0 where you should be able to do this, where I added the container:network in the write_files so that the file is create in the network container.
#cloud-config
write_files:
  - container: network
    path: /var/lib/iptables/rules.sh
    permissions: "0755"
    owner: root:root
    content: |
      iptables -A INPUT -p tcp -m tcp --dport 22 -j ACCEPT
      iptables -A INPUT -p tcp -m tcp --dport 80 -j ACCEPT
      iptables -A INPUT -p tcp -m tcp --dport 443 -j ACCEPT
      # the last line of the file needs to be a blank line or a comment
rancher:
  network:
    interfaces:
      eth0:
        dhcp: true
        post_up:
        - bash /var/lib/iptables/rules.sh

Hi,
I have tried the above solution however it seems the network container do not comes with iptables.
/var/lib/iptables/rules.sh: line 1: iptables: command not found
what would be the best way to fix this issue?
Thanks!
Cam

@camrossi  True, iptables is currently only available in the console. Can you file a separate issue for this?

So I see this issue is closed, does that mean it's resolved? Or is this still not possible in rancher?

@deoxxa This is being tracked in #1362.

Okay, so that's a no. Thanks.

@deniseschannon thanks for this. Does /var/lib/iptables persist? What would happen this dir between up/downgrades? If it does not would it simply be a matter of remembering to check rules.sh after each up/downgrade?

Ahh I think I understand now, it persists because it exists in cloud-config?

So ... it's impossible to use iptables right now?

Does not work in 1.0.0:
2017/04/16 11:26:07 Writing file to "/var/lib/iptables/rules.sh"
2017/04/16 11:26:07 Wrote file to "/var/lib/iptables/rules.sh"
> time="2017-04-16T11:26:07Z" level=info msg="Wrote file /var/lib/iptables/rules.sh to filesystem"
> time="2017-04-16T11:26:07Z" level=info msg="Apply Network Config"
Failed to write to log, write /dev/kmsg: invalid argument
> time="2017-04-16T11:26:07Z" level=info msg="Applying <IP_ADDRESS>/8 to lo"
> time="2017-04-16T11:26:07Z" level=info msg="Applying ::1/128 to lo"
> time="2017-04-16T11:26:07Z" level=info msg="Applying <IP_ADDRESS>/16 to eth1"
> time="2017-04-16T11:26:07Z" level=info msg="Set <IP_ADDRESS>/16 on eth1"
> time="2017-04-16T11:26:07Z" level=info msg="removing  fe80::5800:ff:fe65:245/64 from eth1"
> time="2017-04-16T11:26:07Z" level=info msg="Removed fe80::5800:ff:fe65:245/64 from eth1"
> time="2017-04-16T11:26:07Z" level=info msg="Apply Network Config RunDhcp"
> time="2017-04-16T11:26:07Z" level=info msg="Running DHCP on eth0: dhcpcd -MA4 --nohook resolv.conf eth0"
> time="2017-04-16T11:26:07Z" level=error msg="exit status 1"
> time="2017-04-16T11:26:08Z" level=info msg="Apply Network Config SyncHostname"

My network config:
write_files:
  - container: network
    path: /var/lib/iptables/rules.sh
    permissions: "0755"
    owner: root:root
    content: |
      #!/bin/bash
      iptables -F
      iptables -P INPUT DROP
      iptables -P FORWARD ACCEPT
      iptables -P OUTPUT ACCEPT
      iptables -A INPUT -i lo -j ACCEPT
      iptables -A INPUT -i eth1 -j ACCEPT
      iptables -A INPUT -i docker0 -j ACCEPT
      iptables -A INPUT -m conntrack --ctstate ESTABLISHED,RELATED -j ACCEPT
      ... some rules for eth0
      iptables -A FORWARD -i docker0 -o eth1 -j ACCEPT
      iptables -A FORWARD -i eth1 -o docker0 -j ACCEPT
      iptables -A FORWARD -i eth0 -o docker0 -j ACCEPT
      iptables -A FORWARD -i docker0 -o eth0 -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type destination-unreachable -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type source-quench -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type time-exceeded -j ACCEPT
      iptables -I INPUT -p icmp --icmp-type echo-request -j ACCEPT
      # the last line of the file needs to be a blank line or a comment
rancher:
  cloud_init:
    datasources:
      - ec2
  network:
    dns:
      nameservers:
        - <IP_ADDRESS>
        - <IP_ADDRESS>
    interfaces:
      eth0:
        dhcp: true
        post_up:
        - /var/lib/iptables/rules.sh
      eth1:
        address: $V4_PRIVATE_IP/16
        mtu: 1450
  state:
   fstype: auto
   dev: LABEL=RANCHER_STATE
   autoformat:
     - /dev/vda

so basically, this has never worked? reopening and I'll see what I can do for v1.0.2

so reading the code, it looks like the pre_up and post_up never worked for dhcp adresses - and there's no tests for any of it :(

ok, looks like the proper fix is too complicated to 1.0.2 - it'll come out with 1.1.0
however - @felixsanz @quantverse @deoxxa rancher.network.post_cmds should work for you currently?
can you please have a go and tell me if it does/not?

@SvenDowideit can't test it - gave up on Rancher months ago. Sorry!

How can I allow access to specific port (which is forwarded to container) only for specific ip? I tried cloud-config like this:
#cloud-config

write_files:
  - container: network
    path: /var/lib/iptables/rules.sh
    permissions: "0755"
    owner: root:root
    content: |
      #!/bin/bash
      iptables -F
      iptables -I FORWARD -i eth0 -p tcp --dport 1234 -s <IP_ADDRESS> -j ACCEPT
      # the last line of the file needs to be a blank line or a comment
rancher:
  network:
    interfaces:
      "mac=08:00:27:78:2e:5c":
        gateway: <IP_ADDRESS>
        address: <IP_ADDRESS>/24
        dhcp: false
        post_up:
        - /var/lib/iptables/rules.sh

After system starts 'iptables -L FORWARD -nv' shows:
Chain FORWARD (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination
 2454  206K DOCKER-ISOLATION  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0
 1227  103K DOCKER     all  --  *      docker0  <IP_ADDRESS>/0            <IP_ADDRESS>/0
 1227  103K ACCEPT     all  --  *      docker0  <IP_ADDRESS>/0            <IP_ADDRESS>/0            ctstate RELATED,ESTABLISHED
 1227  103K ACCEPT     all  --  docker0 !docker0  <IP_ADDRESS>/0            <IP_ADDRESS>/0
    0     0 ACCEPT     all  --  docker0 docker0  <IP_ADDRESS>/0            <IP_ADDRESS>/0
    0     0 ACCEPT     tcp  --  eth0   *       <IP_ADDRESS>              <IP_ADDRESS>/0            tcp dpt:1234

So my rule is useless (because it's at the bottom). Docker will release a solution soon https://github.com/docker/libnetwork/pull/1675, but will it work with Rancher os?

After rereading the documentation I managed to solve my problem with config like this (just an example, not an actual config):
write_files:
  - path: /etc/rc.local
    permissions: "0755"
    owner: root
    content: |
      #!/bin/bash
      wait-for-docker
      iptables -I FORWARD -s <IP_ADDRESS> -j ACCEPT

I also tested the following config in VirtualBox (with dhcp enabled, Rancher os v1.0.2-rc2):
rancher:
  network:
    post_cmds:
    - iptables -I INPUT -s <IP_ADDRESS> -j ACCEPT

And after booting  'iptables  -L  INPUT -nv' showed
Chain INPUT (policy ACCEPT 1017 packets, 73428 bytes)
 pkts bytes target     prot opt in     out     source               destination
    0     0 ACCEPT     all  --  *      *       <IP_ADDRESS>              <IP_ADDRESS>/0

So it seems that post_cmds works with dhcp at least in my case. I hope this helps.

this should me more reliable in v1.1.0 due to #1869


multi-threaded libyara usage: yr_finalize_thread() questions

This API is barely documented and I am unclear as to why and when a thread must call it.
The only line I found is:

In a multi-threaded program only the main thread must call yr_initialize() and yr_finalize(), but any additional thread using the library must call yr_finalize_thread() before exiting.

I am trying to create a nice wrapper for which code would look like:
allocate_yara(rules) // main thread does this once to be efficient
scan_mem(rules, memory) // multiple loops/threads call this
free_yara(rules) // main thread calls this only

And the threading related API is the only thing that is confusing me - since only the main thread calls yr_initialize and only once, why must each thread call finalize_thread? can I somehow elegantly add it to my fantasy API?
or must each thread I know to use yara now now contain "yr_finalize_thread()" as it's last line in it's 'ThreadFunc' ??
I don't expect each consumer of my wrapper to magically know they must call a cleanup function at the end of their thread..
I don't know if free_yara is the last time a thread uses the wrapper, since it might allocate and compile rules multiple times.
Must each thread now add a CRT-style management of memory at it's end? or can I call yr_finalize_thread on each completion and it would work fine the next time a thread (or same thread) wants to use libyara?

yr_finalize_thread is deprecated since version 3.8.0 and is not needed anymore if you are using a recent YARA version (see: https://github.com/VirusTotal/yara/commit/6d5c1e682b66d5fca443adb3c219bc3dd90fcf7b). In older versions yr_finalize_thread was required for freeing resources that were allocated in a per-thread basis and stored in a TLS. yr_finalize_thread was usually called when the thread was about to die, like for example at the end of your ThreadFunc. It's safe to call yr_finalize_thread multiple times during the thread life-time, but is not recommended, as that forces the thread to create the resources when they are needed again.

In the function description is marked as deprecated:
https://yara.readthedocs.io/en/v3.8.1/capi.html#c.yr_finalize_thread
But yes, those line you mentioned should be removed in order to avoid confusion. Feel free to send a PR for that.


Correct nqp installation step in build_triple

In order to install nqp, the command 'perl install' was being used instead
of 'make install'.  This change corrects this issue and now
'rakudobrew triple YYYY.MM YYYY.MM YYYY.MM' works as expected.

Thank you!


Workflow dispatch to take inputs

Workflow dispatch needs to take inputs because the nightly trigger provides them.

Force merging to test if this works.

This was forced merged because it could only be tested on master.
Nightly builds are now confirmed to be working.


how can i solve this ?

Attribute application@name value=(android.app.Application) from (unknown)
is also present at [:async_wallpaper] AndroidManifest.xml:19:9-79 value=(com.codenameakshay.async_wallpaper.AsyncWallpaperPlugin).
Suggestion: add 'tools:replace="android:name"' to  element at AndroidManifest.xml:6:4-50:19 to override.

This is how I solved it
In your AndroidManifest.xml
Add this line inside: xmlns:tools="http://schemas.android.com/tools"
And this line inside : tools:replace="android:name"


Replace RTLCriticalSection with TCriticalSection

TCriticalSection in SyncObjs is available on FreePascal/Delphi and is cross-platform, where RTLCriticalSection is Windows only.

I cannot pull your request due code changed, but your idea is good. I will incorporate manually later. Thanks


Please document how to redirect all *.pages.dev domains in account with one Bulk Redirect

Existing documentation URL(s)
https://developers.cloudflare.com/pages/how-to/redirect-to-custom-domain/
What changes are you suggesting?
I found a really nice trick for redirecting (effectively disabling) ALL *.pages.dev domains under an account with one single Bulk Redirect. This is especially important for Free accounts, which only have 20 Bulk Redirects in total.
This nicely addresses a pretty widespread pain point in the community, so it would be nice to document this as a way to save up a lot of Bulk Redirects and manual effort in setting them up.
Additional information
This trick of course makes the "This will automatically redirect all of the preview URLs to your [target location]." part non-optional, but this is probably fine for most users.

Howdy @Hexstream, that's actually already noted in the page you listed.
Going to close this out as completed.

Disagree, the nice trick I am suggesting that page should document is extremely useful and not obvious at all.

think you


Support tsp init of Playground samples

To address the following user feedback on tsp init:

I was expecting the TypeSpec files to contain TypeSpec code, but they were empty. I had to figure out from combination of docs/playground/GitHub repo what a basic TypeSpec API would look like.
What’s the “Hello, World Console App Template” equivalent for TypeSpec?

we should consider making the playground examples available through tsp init. This would short-cut the process this user wound up using -- selecting an example in the playground and copy/pasting this into a newly created TypeSpec project.

[ ] Allow chhosing samples when executing tsp init
[ ] Documentation (playground?) for how to init with sample


[FR DateTimeV2] Fixed inconsistency between French and English in extracting time+date entities (#2486)

Fix to issue #2486.
Test cases added to French and English DateTimeModels.

@LionbridgeCSII, can you resolve the conflicts here please?

@LionbridgeCSII, can you resolve the conflicts here please?

solved


syntax update and copyright year change

In the latest version of Compass, display(flex) has been changed to display-flex(flex) so updated in the footer sections - display(flex) is also used in a few other refills on this page but haven't personally used or tested them, might be broken there too. Also updated copyright year with javascript to keep it accurate in any year.

@piratebroadcast Hi! Refills does not use Compass, rather it uses Bourbon which is where the display(flex) mixin is coming from.
I’d also rather not use JavaScript to inject the year. We could use Middleman (Refills’ static site generator) to accomplish nearly the same thing. Though, really, we just need to state the original copyright year of 2014.


Multiple AddNCronJob only registers ones

Describe the bug
Prior to version 3.3.3 you could register multiple jobs by calling AddNCronJob multiple times.
If I had a setup like this:
services.AddNCronJob(
    builder => builder
        .AddJob<TestJob1>(o => o.WithCronExpression("0/1 * * * * *"))
);

services.AddNCronJob(
    builder => builder
        .AddJob<TestJob2>(o => o.WithCronExpression("0/1 * * * * *"))
);

Current behavior
Only TestJob1 is executed
Expected behavior
Both TestJob1 and TestJob2 should be executed
Version information

NCronJobVersion: 3.3.3-5
.NET runtime version: 8 and 9

I think the change from builder.RegisterJobs(); to  services.TryAddSingleton(jobRegistry); in this commit is the cause of this behavior, but I'm not sure if it's intentional or a bug?
If this is intentional I think the second call to .AddNCronJob(... should throw an exception.

Hey @skarum
No that is absolutely not intentional (at least until now :D) and should be fixed! Thanks for the report!

Ohh -  can see I forgot to link  to the commit: https://github.com/NCronJob-Dev/NCronJob/commit/0fe7e6666d074b2c83ce0fccc679b349a1a7f41d#diff-997ac4e971e8a1108f07128317dfa5a16164555c9220704a45a2d7f26ff01eb0

As a workaround, you can "just" have one call:
services.AddNCronJob(
    builder => builder
        .AddJob<TestJob1>(o => o.WithCronExpression("0/1 * * * * *"))
        .AddJob<TestJob2>(...)
);

@nulltoken we might wanna change that in the future to remove ambiguity (and make our code simpler)

As a workaround, you can "just" have one call:
services.AddNCronJob(
    builder => builder
        .AddJob<TestJob1>(o => o.WithCronExpression("0/1 * * * * *"))
        .AddJob<TestJob2>(...)
);

Thanks, that could work.
Unfortunately I have decentralized my setup, where different parts of my code can just add stuff to the IOC container, including registering a job.
So, If you are going to fix it so it'll work in old way I'll just wait for the next release. If not I'll adjust my code. :-)

I think I have a fix - which I will push as a preview in a few minutes

A new 3.3.7-preview package will be available in a few minutes. Thanks for the report


[non-admin] Enable migplans to take in a user's identity token

As part of the non-admin work, we need the controller and the discovery svc to be able to identify the user which initiated the migration. This means that when a migplan is created, there needs to be a field in the spec to allow the user to specify an identity token. This token will be used for all actions the controller makes. The discovery svc and controller are also expected to perform SAR with this token to ensure that the originating user is not creating backups/restores of resources they do not have access to.
It is important that this identity token is agnostic from OCP's implementation of oauth. While oauth will be the primary use case here, we need the ability to support whatever third party identity provider the Kubernetes cluster has installed as long as it supports unique identifiers.

Let's consider reorganizing the MigPlanSpec as:
Replace:

SrcMigClusterRef (*ObjectReference)
DestMigClusterRef (*ObjectReference)

With:

Source

Cluster (*ObjectReference)
IdentitySecret (*ObjectReference)

Destination

Cluster (*ObjectReference)
IdentitySecret (*ObjectReference)

After our conversation last week I believe this is instead:

IdentitySecret (*SecretReference)

Identity secret contains 2 fields:

srcToken
destToken


Certain instructions have empty stack frames

Version and Platform (required):

Binary Ninja Version: 4.1.5489-dev
OS: macOS
OS Version: 14
CPU Architecture: M1

Bug Description:
Some instructions in some functions incorrectly report having no live stack variables. When used with the new Position Aware Stack View, you get an empty screen.
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

Open this binary: push-pop-automaton-macos.zip
Open stack view
Ensure Position Aware is enabled in the stack view context menu
Navigate to disassembly: 0x100003e59
Observe empty stack view

Expected Behavior:
I expected to see the stack variables present on the surrounding instructions, or really just anything at all.
Screenshots/Video Recording:

Additional Information:
Disabling Position Aware shows the remaining frames. I figure that means the stack variable api is returning the wrong things, and that it's not an issue with Stack View itself.

Fixed today

Seems like this still happens with "nop" instructions. Version 4.1.5742

The Stack view is also empty if you select the function header or the closing/ending brace in Pseudo-C. Turning off "Position Aware" makes it show back up again.


move away from custom wait for compaction to using ccm implementation

tested relevant tests locally against trunk and 2.1.
@mambocab can you review?

Running locally, but code looks good -- feel free to merge after my comment is addressed.

thanks for the feedback, fixed it up to keep behavior the same as before. will squash and merge once travis is happy.

:+1:


CIP25 merge V1/V2 in API and get rid of redundant types

V1 vs V2 from a user perspective are identical but are encoded differently e.g. as text (v1) vs bytes (v2). A user should not need to care about this. We also previously had 3 different types each for asset names and policy ids: cip25 v1, cip25 v2 and the cml-chain ones.
This modifies the outer map part of cip25 to directly use the cml-chain ones and remove the cip25 structs. The serialization for this map had already been hand-edited to allow for permissive parsing so having to move this to utils and hand-edit it shouldn't be much of an issue. Places where hand-editing was done is commented and the other code was taken directly from the auto-generated code from before.
Doing this gives better structural checking too as we didn't do any of that for the v1/v2 policy ids. This is why the noise_metadata test had to be edited.
As a result of this CIP25 has about half the types and should have a much less confusing API.

I'll add the WASM bindings later once we decide if this is the approach we want. The previous one is #193 but IMO this one gives a much cleaner API for users. It doesn't really even hurt regenerability much either since we had to modify the outer map deserialization code a bunch for permissive parsing anyway. I marked the few additional places we hand-edit here with comments in case we do ever need to regenerate. Other than that I just pasted the v1/v2 table parsing code into the new types and did those few single-line changes to directly use PolicyId/AssetName and merge the types into one.


Return exit code

run.env ignores the exit code from whatever it runs, so jobs always appear to succeed.
This PR checks for an error or non-zero status code, and exits using a non-zero code if found.

@studds Thanks for the PR.


[Question] Usage of feature fusion for Multimodal Retrieval?

Hi,  @logicwong. Thanks for your great work!!
There are some questions about image retrieval:

for (image + audio) -> image

should we first extract the features of the query image and the query audio separately and then fuse them (PS: If this is the case, by the way, how to fuse them)
or directly send the query image/audio to the network at the same time and extract only one feature? is there some API or can you provide some example scripts?

for (image + text) -> image and (image + text + audio) -> image, same question above and how to do that.

Thanks again for your amazing project. Hope to get your reply

Hello, thank you for your interest in ONE-PEACE.
As you mentioned, we extract the features of different modalities and directly sum the features. You can refer to the following code:
def shot(image, audio, text):
    features_list = []
    if image is not None:
        src_images = model.process_image([image])
        image_features = model.extract_image_features(src_images)
        features_list += [image_features]
    if audio is not None:
        src_audios, audio_padding_masks = model.process_audio([audio])
        audio_features = model.extract_audio_features(src_audios, audio_padding_masks)
        features_list += [audio_features]
    if text is not None:
        src_tokens = model.process_text([text])
        text_features = model.extract_text_features(src_tokens)
        features_list += [text_features]
    mixed_features = sum(features_list) / len(features_list)
    sims = mixed_features @ candidate_image_features.t()
    _, rank_img = sims.topk(k=20, dim=1)

    predict_image_list = []
    for i in rank_img.squeeze().tolist():
        image_path = index2image[str(i)]
        predict_image_list.append(Image.open(image_path).convert("RGB"))

    return predict_image_list

thanks for your response, got it!