Auto Brace Complete: extra quotation mark when typing string

Godot version:
3.1-beta e033699
OS/device including version:
Windows 10
Issue description:
Adding a quotation mark at end of a string with Auto Brace Complete enabled adds an extra quotation mark, when it should "pass through" the last one and put the cursor after it:

This doesn't happen if the character to the left of the cursor is whitespace; it functions correctly in that case.
Steps to reproduce:

Enable "Auto Brace Complete" (in Editor Settings, under Text Editor -> Completion)
Type a string

Is this bug still being worked on?


Multi-threaded execution is actually slower (checked on DKI model only)

The most striking issue is how useless (actually detrimental) is fitting in parallel:
Single thread:
Model fit (218370 voxels, 256 orientations) -<PHONE_NUMBER>6899921 s.

Multi-thread (16 threads):
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>0699953 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>5700036 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>3799962 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>7600005 s.
Model fit (13649 voxels, 256 orientations) -<PHONE_NUMBER>1199848 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>70001 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>2500108 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>5499936 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>539992 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>329997 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>7100122 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>4599975 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>839999 s.
Model fit (13649 voxels, 256 orientations) -<PHONE_NUMBER>279996 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>239998 s.
Model fit (13648 voxels, 256 orientations) -<PHONE_NUMBER>369997 s.

@arokem any suggestions of why DKI.fit_model takes about the same time (or even more) with 1/16 of the voxels?

Might be a speed/memory tradeoff. DKI and DTI are both implemented to use multi-threaded array operations in numpy already: https://github.com/dipy/dipy/blob/master/dipy/reconst/dti.py#L1397 (see also: https://github.com/dipy/dipy/blob/d0401e0d8f4234997f2a85a70782ddec005b12b5/dipy/reconst/dti.py#L1226), so I don't think that you will get much of a speedup for these models through this parallelization. Can you please try this with something like SFM?

That's what I thought, numpy's parallelization is definitely kicking in.

In addition, check out functionality added to DIPY in https://github.com/dipy/dipy/pull/2539. Maybe we can use that and not need any additional work on parallelization to happen here?

Closed with #103


vec_copy potential issue

Hi!
Thanks for sharing this project! I'm following along with the exercises now to learn about vectors and I noticed that in the function vec_copy line 57 you set
copy_size = src->alloc_size
Should it not be
copy_size = dst->alloc_size?
Also, line 53
vec_new(dst, src->len, dst->elem_size);
Should it have the same fail check as the other functions:
if (vec_new(dst, len, elem_size) < 0)
		return (-1);

Thanks!

copy_size = src->alloc_size
Should it not be
copy_size = dst->alloc_size?

Yeah I think you are correct. The if else statement should choose the alloc_size which is smaller. Or I think that has been the idea (it's a while since I wrote this code :D). It's arguable if it should just fail if dst is smaller than the memory we try to copy. This will quickly bring us to interesting API questions. In other languages we usually have "owning" types (like t_vec would be since it owns it's memory allocation) and reference types which refer to an owned type (often called slices or views). To take this API to the next level you would implement t_vec_view or similar which would enable slicing ranges from a vec to views and copying them instead.

Should it have the same fail check as the other functions:
if (vec_new(dst, len, elem_size) < 0)
return (-1);

Indeed!
Please make a PR :)

Thanks for the in-depth answer, will definitely look into the "owning" topic!
PR made, my first ever :)

One more note: in the vec_append function lines 179 and 181 the alloc_size and dst->alloc_size are used respectively for the vec_resize, however that function expects the len as a parameter, and in other functions, e.g. vec_push and vec_insert it was indeed len that was passed to vec_resize. This confusion may be due to the fact that in subject.md "Ex4" section and vec.h the resize function is prototyped as "static int vec_resize(t_vec *src, size_t target_size)" , while in the "Implementation" section and in vec.c it's shown as "int vec_resize(t_vec *src, size_t target_len)".
So what is the intended implementation? I imagine it would make more sense to use len over size for it, as is done in most of the functions?
Additionally, for vec_append and vec_prepend, can it be assumed that dst->elem_size == src->elem_size? It seems to me that it's necessary for the purpose of these functions. If so, then the allocation size could be assigned as (dst->len + src->len) * src->elem_size; and we could pass dst->len + src->len to vec_resize in line 179.


Disable announcement banner for v1.18 release (leaving banner on live site)

Announcements should display on the live documentation. Disable the announcement that was showing at the moment the release branch was cut.
This does not remove the announcement from https://kubernetes.io/
/kind cleanup
/cc @savitharaghunathan @jimangel @zacharysarah @kbarnard10

I'd love to keep this particular banner up in 1.18; but I can also anticipate a UX problem with inconsistent messaging across versions over time as banner functionality increments fully through CURRENT+4 version support.
Black lives matter always, past and present; and by keeping the banner active on only the current version, we keep the message strong.
/lgtm
/approve


Add Listener for engagement start in Call Visualizer

In order to trigger callback for embedded visitor code view, a listener for engagement start needed to be refactored.
MOB-1934

!squash

!merge


Report not allowed characters in identifiers

Currently only some characters are allowed in API Blueprint identifiers.
If illegal character is used the whole section is silently ignored.
Following blueprint should at least produce a warning about illegal identifier (character ')
# Group Parcel
## Parcel's sticker [/parcels/{parcel_id}/stickers.json]

Migrated to apiaryio/drafter#650


feat: add release_created per path in manifest PR

We were just implementing a release process on a vscode extension in our monorepo, and that has a separate release flow than anything else, so we'd only want the publish phase to run if a specific path was released.
This adds a release_created flag on each published package in a manifest release.

@phated this looks ready to land to me, have you signed the CLA?

@bcoe thanks for fixing these tests! I think something is broken with the bot because when I log in, it says my CLA is signed.

@googlebot I signed it!

@bcoe could the issue be that I use a dot in my email for all my git commits, but google has it down as 1 word (that's how it shows when I log in)?


What does lettering print

what does string.lettering print could pls explain in detail i can only see a 4 tuple format beside a particular letter

I don't understand your question. Lettering is a str subclass, that also has a .get_bbox() method returning the bounding box of the text in (x1, y1, x2, y2) format and a .font property

thanks for replying,i got the box boundary as four tuple but how do we get font information, i mean what is syntax of code to be used.

The .font property has the font information. Unfortunately, there isn't much documentation on this, but you can see the PDFFont class that pdfminer uses here


No access to Optical Drive (unRaid)

Hi i did everything as described but it will not recognize my Optical Drive.

The Log output for the right drives:
[cont-init.d] 95-check-optical-drive.sh: executing...
[cont-init.d] 95-check-optical-drive.sh: looking for usable optical drives...
[cont-init.d] 95-check-optical-drive.sh: found optical drive [/dev/sr0, /dev/sg2], group 19.
[cont-init.d] 95-check-optical-drive.sh: exited 0.
Here my Extra Parameters : --device /dev/sr0 --device /dev/sg2

Can you try to enable privileged mode to see if this makes MakeMKV to see your drive ?

Sorry dose not work with privileged mode enabled

It seems that some drives are not recognized by MakeMKV, event though they are seen correctly by Linux.  I'm suspecting an issue on MakeMKV side.
See https://github.com/jlesage/docker-makemkv/issues/98.

Switching to privileged mode fixed this issue for me.

@devlinandrew, could you share the permissions/ownership of Linux devices associated to your optical drive ?  E.g. ls -l /dev/sr0 /dev/sg2

See attached.

I've encountered this problem a few times as well and noticed that a full system reboot "fixes" it, but not a docker restart. I'll try to gather more info the next time it happens.

and noticed that a full system reboot "fixes" it, but not a docker restart

That seems to be the "fix" for other people also.
Closing this issue.  Please re-open if needed.


Roll engine to b856303c4e20a96877d9551572c71dada31537bd

This contains the following commits:
flutter/engine@b856303 Revert 37e20af6a324cd4cfa1324b8c644712ef8224359
flutter/engine@39c02c4 Fixed Windows build after Blink removal
flutter/engine@4a4cff9 Remove Blink code
flutter/engine@f2acd0a Roll src/third_party/skia/ f31fece65..1d686a962 (10 commits)

LG


Betterify editor documentation

"Text editor support" can imply native support within text editors themselves, as in like Atom's support for JavaScript and CoffeeScript and Eclipse's support for Java. I thought this would better convey the meaning.

Why not Text Editor Plugins...?

What about this?

That works :smile:

ping @gkz @vendethiel

@gkz is the one to ping for the website :)

Ok. Sorry. ;)


Add Autonomous mode selection

We need a shuffleboard tab with options to configure Autonomous

Robot position
Should we score anything?
Score early, or late
Should we try to pick up extra power cells after scoring?

This was implemented in #42


Error when only r_emailaddress permission is requested

In case when only r_emailaddress is requested (i.e. no r_liteprofile), the following error is returned:
{ InternalOAuthError: failed to fetch user profile (status: 403 data: {"serviceErrorCode":100,"message":"Not enough permissions to access: GET /me","status":403

It looks like Strategy.prototype.userProfile needs to be updated, to check scope and request profile and/or email accordingly. Currently, the code assumes that r_liteprofile is always granted.

Another issue is when scope is specified in passport.authenticate(), it's not passed to OAuth2Strategy.prototype._loadUserProfile:
https://gist.github.com/eezhal92/cf6b3892231b4f3c1be4b7055d394283#file-strategy-js-L363

I'm rolling this in and seeing the following (I had to add a console dump for the error @:39)
My app has r_emailaddress and r_liteprofile permissions so I'm not sure what I'm missing. Was there anything else variant about configuring this strategy to get it working?
Thanks
{ InternalOAuthError: failed to fetch user profile
    at Strategy.<anonymous> (/Volumes/External/Project/node_modules/@sokratis/passport-linkedin-oauth2/lib/oauth2.js:39:15)
    at passBackControl (/Volumes/External/Project/node_modules/oauth/lib/oauth2.js:132:9)
    at IncomingMessage.<anonymous> (/Volumes/External/Project/node_modules/oauth/lib/oauth2.js:157:7)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:978:12)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickDomainCallback (internal/process/next_tick.js:128:9)
  name: 'InternalOAuthError',
  message: 'failed to fetch user profile',
  oauthError:
   { statusCode: 403,
     data: '{"serviceErrorCode":100,"message":"Not enough permissions to access: GET /me","status":403}' } }


I want to fix Explore button

Clear and concise description of the problem
the explore button looks bad - weird color and the clickable area is only the text.
Suggested solution
I will change the color and make the button clickable area all over the button
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Welcome! It's yours 😁🧑💻


"Launch on iOS" on Windows hangs VS Code and results in never ending debug

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: 4.2.4
Cross-platform modules:
Android Runtime:
iOS Runtime:
Plugin(s):
VSCode Extension: 0.8.2

Describe the bug
"Launch on iOS" on Windows hangs VS Code and results in never ending debug
To Reproduce
1 Create NativeScript project.
2 Add NativeScript launch configuration
3 Go to Debug tab
4 Select "Launch on iOS"
5 Press play button
Expected behavior
"Launch on iOS" on Windows should show error and stop the debug operation.

Test Steps

Start vscode on Windows
Install latest version - Build version: v.2<IP_ADDRESS> - confirm that it appear in NS console output
Open project and go to debug view
Select and execute Launch on iOS
Verify that there is a vscode notification saying "iOS platform is supported only on OS X"
Select and execute Attach on iOS
Confirm that vscode is not froozen
Verify that there is a vscode notification saying "iOS platform is supported only on OS X"
Confirm that vscode is not froozen
Switch to Android and launch it - app should be launched on attached emulator/device

Tested against tns@rc(5.x) and tns@latest(4.2.4)
Build version: v.2<IP_ADDRESS>


pip install morph-kgc[all] does not work

Environment (please complete the following information):

OS: Ubuntu 22.04 LTS
Python version: 3.8.10

Morph-KGC Version
The latest available via pip install
Installation Method
Within a virtual enviroment tried to install morph-kgc via pip install. I have successfully install the morph-kgc, but since I wanted to use it with a relational db, I need to install the extra dependencies as it documented in the documentation . Unfortunately, this command
pip install morph-kgc[mysql]
does not to any available package, when I tried to remove the square brackets,
pip install morph-kgcmysql
I get the following error
^[[AERROR: Could not find a version that satisfies the requirement morph-kgcmysql (from versions: none)
ERROR: No matching distribution found for morph-kgcmysq

Which is the correct command to install the dependecies for MYSQL db? And which is the command to install the full package
pip install morph-kgc[all]

Hi @gkirtzou ,
This is weird, I just tried pip install morph-kgc[mysql] and it is working for me. I am also on Ubuntu, maybe it is related be the python version.
Alternatively, if you want to use mysql you may use the basic morph-kgc installation:
pip install morph-kgc

And install separetely the drivers for mysql:
pip install pymysql
pip install cryptography

I am on 3.10.6

I am closing this, but it can be potentially reopened if it occurs again


storage: Support custom endpoints for SignURLs

When a custom endpoint is set on the client, Sign URLs and Post Policies should automatically use that domain.
Optional: allow users to set a custom hostname for Sign URL and Post policy methods.
See the following for more information and fill out language section: go/signurl-custom-endpoint-gcs
Please add a comment or ping me if you have any questions.

When a custom endpoint is set on the client, Sign URLs and Post Policies should automatically use that domain.

Our URL signer isn't created in the context of any client - see https://cloud.google.com/dotnet/docs/reference/Google.Cloud.Storage.V1/latest#signed-urls for sample code. In other words, this will take a bit of a redesign.
We'll probably want to add a CreateUrlSigner method on StorageClient, or something similar. But it's definitely not just a matter of changing some implementation.

Our URL signer isn't created in the context of any client - see https://cloud.google.com/dotnet/docs/reference/Google.Cloud.Storage.V1/latest#signed-urls for sample code. In other words, this will take a bit of a redesign.

This was the same case for our Go client as well. We ended up adding a URL signer at the bucket level that calls the original URL signer. Other languages have the URL Signer on the object (Node, Python) or on the Client; any of these is fine.
Adding a URL signer under the client/bucket/object allows not only supporting the same custom endpoint automatically, it also enables automatic signing (which is a highly requested feature across languages) with the client's credentials.


Adding a few useful module descriptors

Self explanatory. The GFM is probably the most cryptic one of all out of everything in this vehicle.

Just adding an unrelated comment. Kudos on this repo. I'll keep tabs on it and will periodically pop in with any suggestions I have.

You know, I was going to toss a few more notes into the repo before pinging you about contributing. I was super excited when your name showed up in my email this morning :)


Update plot with AJAX

Thanks and congrats @alanjones2 for this great tutorial, about how to use Plotly directly with Flask + AJAX!
Small question: why do you create a new plot on each update after an AJAX call?
https://github.com/alanjones2/Flask-Plotly/blob/main/plotcallback-gm2/templates/chartsajax.html#L10
function cb(selection) {
            $.getJSON({
                url: "/callback", data: { 'data': selection }, success: function (result) {
                    Plotly.newPlot('chart', result, {});;
                }
            });
        }

Isn't there a way to do something else than newPlot, but rather "update plot data"?

Good question and the answer is probably laziness! I just used newPlot for the first chart and just didn't think about how efficient subsequent plotting would be.
A faster way of doing the same thing would be to use:
Plotly.react('chart', result, {})
Although, performance is not really an issue here, this seems to work the same way and is (apparently) faster than newPlot

BTW I've changed the code in the repo

Thanks @alanjones2!
I just discovered Plotly.react too!
(BTW about "react" does Plotly/Dash use ReactJS or something like this internally to do the AJAX, or did they recode such a system themselves from scratch?)

Plotly is based on d3.js and uses that library for creating plots.
The react function redraws only the changes between the given parameters and the current state of the plot. That's why it is normally faster than plot or newPlot

There is an error when i try to Fetch stock: "yFinance failed to decrupt Yahoo data response"
Do you know how to solve this error?

I think that this is an issue with yFinance and Yahoo Finance changing the way it encrypts data. See the yFinance Github page for more details. I don't know if there is a way around this but I won't be able to look any further into it or update this app in the foreseeable future a. Apologies, but I simply do not have the time, at present.

I did have a quick look. The data comes back ok but not the info so if you comment out the part that fetches this then you will still get the graphs:
                if (response.ok) {
                    //response = await fetch("/callback/getInfo?data=" + Stock);
                    //let infoJson = await response.json();
                    //info(infoJson);
                    Plotly.newPlot('chart', chartJson, {});

You also need to change the Facebook symbol fro 'FB' to 'META'

I've updated the repo with these changes and a notice on the web page to say that this functionality has been disabled

Thank you!

Is there an easy way to make the charts responsive? Thought I could add "responsive: true" to this line: Plotly.react('chart', result, {}, {responsive: true });; but that's not working. The charts size correctly when I refresh the page but not when I resize the window.

I would have done the same as you! If that doesn't work you could try calling the plot function when a window resize event is fired - see here if you are unsure how it works.
Otherwise,  maybe try asking on Stackoverflow

thanks for the reply! This worked for me:
``


Bunch of Errors appear  when z and + keys pressed together in Lightbox view of Video

When you open a Video (URL Embed or a Youtube Video) in the Lightbox view, and then press the keys z and + together, then a bunch of errors appear.

Steps to reproduce

Click on thumbnail preview of some video to open in Lightbox view.
Press the z key first, and holding it, press the + key then.
Errors appear.

Possible Reason for the Bug

This snippet which is key binding of the z and + keys pressed, is used for zooming in of view.
However, when we look at the zoomIn() function here, we see that it only handles that of $(".image-preview"), but we are dealing with a video.
The above bug hence, only reproducible in videos and not images in lightbox view.

Zulip Server and web app version:

[ ] Zulip Cloud (*.zulipchat.com)
[x] Zulip Server 7.0+
[ ] Zulip Server 6.0+
[ ] Zulip Server 5.0 or older
[x] Other or not sure

Hi @roanster007 can i work on this issue ?

Thanks for the report, @roanster007 ! I started a discussion thread on CZO.

This was fixed in https://github.com/zulip/zulip/pull/27786. @roanster007 FYI, please try to have commits include the tags to have GitHub auto-close issues.


new does not return null

This code is wrong:
CPPShift::Memory::MemoryPool* CPPShift::Memory::MemoryPoolManager::create(size_t block_size) { 	// Create memory pool 	MemoryPool* mp = new MemoryPool; 	if (mp == NULL) throw EMemoryErrors::CANNOT_CREATE_MEMORY_POOL;
By default, the call to new MemoryPool will never return null. You should either call malloc like you do in createMemoryBlock (recommended) or catch(std::bad_alloc).

Thanks for the comment, just fixed it to use malloc instead! :)


support different api version for azure openai

What problem does this PR solve?
Support different api version for Azure-OpenAI
Type of change

[x] New Feature (non-breaking change which adds functionality)

Thanks for your contributions.
Is it possible to apply this feature without DB alteration?

Thanks for your contributions. Is it possible to apply this feature without DB alteration?

Given the current architecture, it seems impossible to apply this feature without DB alteration, because the llm_factories.json file is loaded at startup and exists in the llm table.

We are gona figure it out.
Thanks anyway.


Disable gateway scoping

Mitigation for https://github.com/istio/istio/issues/28315
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

In response to a cherrypick label: new pull request created: #28835


Add result class

First basic proposal for a result class, here's how the printing looks:
>>> result = dq.mesolve(...)
>>> print(result)
==== Result ===
Options    : Rouchon1
Start      : 2023-07-02 15:12:13
End        : 2023-07-02 15:12:13
Total time : 0.45 s
y_save     : tensor (4, 101, 64, 64) [12.62 Mb]
exp_save   : tensor (4, 2, 101) [6.31 Kb]

There's a lot to add, here's a quick list on the top of my head:

[ ] Implement to_qutip() and to_numpy() returning a new object where we converted y_save and exp_save to a list of Qobj/numpy array or just big numpy arrays.
[ ] Implement save() and load(): we need to save dynamiqs current version, the commit version (+ wip if needed) and a version saving scheme (we raise an error if we try to load an incompatible version). I think it would also be nice to have a hash for each result object, e.g. if someone wants to use them as index in a database.
[ ] Implement solver specific savings (e.g. for adaptive solvers the number of iterations).
[ ] Implement a __str__ method for Options base class and child classes.

Moreover, we should probably choose other name for the api than y_save and exp_save (I think they are good internally though), we can just set aliases on the result class for the uses, what do you think about states and expects?
I'd like to rebase #141 on this once we agree on the structure.

Moreover, we should probably choose other name for the api than y_save and exp_save (I think they are good internally though), we can just set aliases on the result class for the uses, what do you think about states and expects?

Yes I like states and maybe expvals ?


Can't resize workspace tree, tabsets, or console on master on Window; icon doesn't change

I'm not seeing the cursor change to the resize cursor anywhere between my left-most editor tabset and the workspace tree (when the latter is visible).

I can't reproduce this on Ubuntu. I suspect I'm not running the latest version on the relevant Windows box.

I just built the latest version of master on the same Windows box and this behavior still afflicts me. I also can't resize any of the other elements.

It's worth seeing if this is still an issue on #1957. If it is we'll probably want to report upstream to electron

@cldwalker Will do. I can't repro this with #1957 on my Mac.

I can't reproduce this on a more recent source version on Windows


Fix Issue 13805 - groupBy over nested struct range

GroupByImpl needs to initialize _prev in the constructor when its type is a nested struct.
https://issues.dlang.org/show_bug.cgi?id=13805

Auto-merge toggled on

Thanks!


Missing rule for not inserting spaces after/before braces

From @shahata on October 9, 2016 17:55

VSCode Version: 1.5.3
OS Version: macOS Sierra

Steps to Reproduce:

Add "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false to the workspace settings
Type const a = {b: 1};
Format Code
Code is now formatted const a = { b: 1 };

I guess this is similar to https://github.com/Microsoft/TypeScript/issues/7540 and this rule considers only [ and ] as brackets and actually a new rule javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces should be added to support braces: { and }
Copied from original issue: Microsoft/vscode#13401

@shahata thank you for opening this issue.
@dbaeumer this is confirmed on latest. Is this a feature request for TypeScript language service? Or something we need to implement on our end?

From @jrieken on October 10, 2016 14:47
fyi - the pre-commit hooks goes with tsfmt.json, so if we change default we should keep them in sync

From @dbaeumer on October 14, 2016 15:8
@waderyan  Yes, I think so.

looks like a duplicate of https://github.com/Microsoft/TypeScript/issues/9613


Sporadic "rate limit is exceeded" running examples/test_contacts.py script

When running the examples/test_contacts.py script, I get "rate limit is exceeded" errors on a regular basis (though not all the time).  The exact API call it fails on seems to vary between runs.  Here's a representative example:
ERROR: test_mono_example (__main__.TestContacts)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_contacts.py", line 101, in test_mono_example
    contacts, pager = self.client.contacts.list()
  File "/home/ndavis/devel/textmagic-rest-python/python/lib/python2.7/site-packages/textmagic-2.0.3-py2.7.egg/textmagic/rest/models/contacts.py", line 63, in list
    return self.get_instances(kwargs)
  File "/home/ndavis/devel/textmagic-rest-python/python/lib/python2.7/site-packages/textmagic-2.0.3-py2.7.egg/textmagic/rest/models/base.py", line 194, in get_instances
    response, page = self.request("GET", uri, params=params)
  File "/home/ndavis/devel/textmagic-rest-python/python/lib/python2.7/site-packages/textmagic-2.0.3-py2.7.egg/textmagic/rest/models/base.py", line 156, in request
    response = make_tm_request(method, uri, auth=self.auth, **kwargs)
  File "/home/ndavis/devel/textmagic-rest-python/python/lib/python2.7/site-packages/textmagic-2.0.3-py2.7.egg/textmagic/rest/models/base.py", line 133, in make_tm_request
    msg=message, errors=errors)
TextmagicRestException:
HTTP Error 429
Your request was:

GET https://rest.textmagic.com/api/v2/contacts?search=False

Actually, I seem to get this on other scripts as well.  It seems the limit is a little less than 2 requests per second?  Or perhaps it's a time synchronization issue (assuming there are multiple servers that might handle any given request)?

Yes, there is probably some sort of a difference in fractions of a millisecond on the client and the server. I increased interval value.


fix(superset): get alternate platform value if sqlalchemy_uri param is missing

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Issue raised regarding this: https://github.com/datahub-project/datahub/issues/8668

@akhil7philip thanks for the PR! I made a small tweak but otherwise should be good to merge


[CTA Section with Content Items]: Bottom Padding is not 160px - No DDS consulting

Engineering info:

HC engineer:
HC Jira Ticket:
DDS Designer: @DragosRistici

Description
The bottom spacing of the content sections that contain the CTA section component have a bottom spacing of 136px. The bottom spacing should be 160px. However, this spacing does match what is on Storybook. Can the bottom spacing be updated to have 160px?
Component(s) impacted
CTA Section with content items
Browser
Chrome
Carbon for IBM.com version
v1.26.0
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
AEM (Marketing)
Package
@carbon/ibmdotcom-web-components, @carbon/ibmdotcom-styles
CodeSandbox example
https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/master/packages/web-components/examples/codesandbox/components/cta-section
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

There are spacing bugs related to the CTA Section layout component that was mentioned within this ticket (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/7482). The engineer that's picking up this issue should account for the discrepancies mentioned in https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/7482 as well.


[UM-729] Update repository setup

Description

Add CI/CD workflow
Update project structure (move code into src and tests into test)
Misc updates (PULL_REQUEST_TEMPLATE.md, README.md, .gitignore, package.json)

@ilia-panoply I don't have any permissions in this repository


Query with timer can throw IllegalThreadStateException

Running a query that uses a timer can cause an IllegalThreadStateException if the underlying ThreadGroup has been destroyed.
This error happens when the caller executes a query with a timeout and then doesn't execute another query with a timeout until some time has elapsed. The JVM can destroy the ThreadGroup behind the TimeoutTimer (because it contains no active threads) which causes any new query with a timeout to throw an IllegalThreadStateException.
Once the JDBC driver has entered this state any new query with a timeout will throw the exception. It's especially easy to run into this problem in demanding / multi-threaded applications.
My change makes sure the ThreadGroup is not destroyed before creating a new timer thread. If the ThreadGroup is destroyed, the code will create a new ThreadGroup.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #474 into master will decrease coverage by 0.16%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #474      +/-   ##
============================================
- Coverage     46.37%   46.21%   -0.17%
+ Complexity     2204     2195       -9
============================================
  Files           108      108
  Lines         25212    25215       +3
  Branches       4165     4166       +1
============================================
- Hits          11693    11654      -39
- Misses        11492    11535      +43
+ Partials       2027     2026       -1

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.04% <83.33%> (-0.16%)
2184 <0> (-10)

#JDBC42
46.12% <83.33%> (+0.01%)
2192 <0> (+1)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
53.7% <83.33%> (-0.49%)
0 <0> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
43.37% <0%> (-2.03%)
103% <0%> (-2%)

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
44.94% <0%> (-1.13%)
16% <0%> (-1%)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
59.17% <0%> (-0.65%)
88% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.86% <0%> (-0.41%)
242% <0%> (-4%)

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
59.06% <0%> (-0.31%)
129% <0%> (-1%)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
63.31% <0%> (-0.19%)
0% <0%> (ø)

...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java
77.62% <0%> (-0.17%)
4% <0%> (-1%)

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
42.42% <0%> (ø)
46% <0%> (-1%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c2207...9da95c5. Read the comment docs.

@maiken2051 Thank you for your effort in creating this pr. Could you please open this to dev branch?

Hi @maiken2051, would you be able to reopen this PR against the dev branch?

Thanks for rebasing the PR...

@maiken2051, just wanted to keep you posted. We are going to be doing a code review soon. Thanks again for your contributions.

Hi @maiken2051 Please sign CLA so that we can proceed with merging your PR.

I think the CLA should be OK now?

Hi @maiken2051, thanks for the contribution. The changes look good, and I approved it - but I'm curious as to where I can find the information regarding JVM destroying a ThreadGroup that contains no active threads. Could you point me to where I can read more about this?

Check out the source for ThreadGroup.threadTerminated. This is from OpenJDK but I assume all JVM implementations are similar. The docs say:

Notifies the group that the thread t has terminated. Destroy the group if all of the following conditions are true: this is a daemon thread group; there are no more alive or unstarted threads in the group; there are no subgroups in this thread group.

When a thread exits it will call this method to remove itself from the active list on its owner ThreadGroup. If it's the last active thread the group will be destroyed.


Typo ""

Hi folks,
Please type 'infrastructure' instead of "ndrastructure".
Here is the full sentence:
When either of the endpoints lies in Azure, traceroute shows up unidentified hops as Azure ndrastructure does not reveal identity to traceroute.
Cheers!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfb056c1-50bf-ac78-9332-4fd8de94620a
Version Independent ID: 344d259f-3779-9d03-b109-d76b1d0197fb
Content: FAQs - Network Performance Monitor solution in Azure - Azure Monitor
Content Source: articles/azure-monitor/insights/network-performance-monitor-faq.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @vinynigam
Microsoft Alias: vinigam

@stspinu Thank you for bringing this to our notice, will raise a PR to fix the document.

@stspinu Thanks again for bringing this to our notice and helping correct our document.
PR has been merged and the document reflects it correctly now.
Closing this issue for now, however if you have any queries please revert back. Thank you


JAVA :  Polymorphism in Java

Description
Description
Domain
Java_Domain
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

@iamtanya-22 you cannot create issues yourself, your PR won't be considered!


UHF-X Search API does not exist

What was done

Exit early if search api module is not enabled. Like in KUVA instance, where the module helfi_react_search is enabled (for some reason).

How to test

[x] Just check the code

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c19b04e) 13.07% compared to head (c7d90a4) 13.07%.

:exclamation: Current head c7d90a4 differs from pull request most recent head e76918d. Consider uploading reports for the commit e76918d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #670   +/-   ##
=========================================
  Coverage     13.07%   13.07%
  Complexity      241      241
=========================================
  Files            28       28
  Lines           941      941
=========================================
  Hits            123      123
  Misses          818      818

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update docs metadata

What this does
This copies metadata to the docs page to better match other CAP static webpages, so that all pages have as in-depth metadata as possible.
Notes

I haven't updated the screenshot of the documentation page, that's included as an open graph preview image, in case we end up updating the documentation copy.

How To Test
I've discovered that the least-error prone way to check out a branch locally is to not follow the instructions github provides on each PR. It feels much more consistent to:

Add a new remote for my fork of capstone-stone, named meaningfully (for example, named tinykite)
Run git pull tinykite to make sure you have the latest remote branches
Run git checkout update-docs-metadata to checkout this branch

Thanks Ebru!


⚠ Bofrost.es has degraded performance

In 5c1dd26, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1547 ms

Resolved: Bofrost.es performance has improved in 67da7d7.


fix parser warnings for semicolons in function arguments

Summary:
The parser is producing a confusing warning for the following ill-formed Stan program:
transformed data {
  real x = atan2(2 ; 3);
}

See the Discourse topic for more examples
Current Output:
SYNTAX ERROR, MESSAGE(S) FROM PARSER:
 error in '/Users/carp/temp2/confusing.stan' at line 2, column 17
  -------------------------------------------------
     1: transformed data {
     2:   real x = atan2(2 ; 3);
                        ^
     3: }
  -------------------------------------------------

PARSER EXPECTED: "("

Expected Output:
Something like "expected , or )" pointing before the semicolon.
Current Version:
v2.18.0

Hi,
maybe an error that only an R user a bit newb in Stan would do. But the same confusing parser warnings appears if one tries passing an int[] type to a function without declaring and expecting that it will work as it would in R... for example as following:
functions{
vector construct_eta(matrix X, vector b, int[] loc, int sK, int[] b_K, int N){
    vector[N] eta;
     if(sK > 0) {
      eta = X[loc, K] * b[b_K];
    } else {
      eta = rep_vector(0.0, N);
    }
    return(eta);
  }
}
data{
int nSubjects
}
...
transformed parameters{
for(j in 1:nSubjects){
eta = construct_eta(predictors, beta, start[j]:end[j], sK, b_K, N);
}
}

I do not know how hard might be to catch this error, but in any case I also leave the comment here for future reference.

Stanc3 says the following on @bob-carpenter 's example model (top):
Syntax error in 'temp.stan', line 2, column 17 to column 18, parsing error:
   -------------------------------------------------
     1:  transformed data {
     2:    real x = atan2(2 ; 3);
                           ^
     3:  }
   -------------------------------------------------

Ill-formed function application. Expect comma-separated list of expressions followed by ")" after "(".

and the following for @csetraynor 's model:
Syntax error in 'temp.stan', line 9, column 4 to column 13, parsing error:
   -------------------------------------------------
     7:  }
     8:  data{
     9:  int nSubjects
                      ^
    10:  }
    11:  ...
   -------------------------------------------------

Only top-level variable declarations are allowed in data and parameter blocks.

after which we can add the missing semi-colon to get the following error:
Syntax error in 'temp.stan', line 13, column 38 to column 46, parsing error:
   -------------------------------------------------
    11:  transformed parameters{
    12:  for(j in 1:nSubjects){
    13:  eta = construct_eta(predictors, beta, start[j]:end[j],  b_K, N);
                                                       ^
    14:  }
    15:  }
   -------------------------------------------------

Ill-formed phrase. We found an L-value. Parse failed on token after the L-value.

Are these considered informative enough? It's sometimes hard to give a very informative error, like in the last case, because that parse rule appears in many different contexts (meaning it's hard to give an error message that is not entirely generic). Of course, it's possible to many the grammar more complicated to get more specific error messages, but it's a matter of weighing cost and benefit then.

Does it make sense to label this Won't fix until stanc3?

Hi @VMatthijs yes
Ill-formed phrase. We found an L-value. Parse failed on token after the L-value.
would be informative enough for a user. my opinion as a current user.

Fixed in stanc3.


removing unnecessary import that causes a cyclic importing error

This error happens in certain cases and prevents me from deploying grlc (as a lib) as part of my search API (on our servers; locally it works somehow).
To circumvent this issue I managed to install grlc as follows:
pipenv install (I excluded grlc from my Pipfile to prevent issue 223)
pip install grlc

Then I had to copy my config.ini to the VENV/lib/python3.x/site-packages/grlc/config.ini to make sure it works for my code (grlc used to be able to find the config.ini in the root of my code. Would really appreciate the option to configure the location of the config.ini).
After that I noticed things were still not working because of this cyclic import error. For now I fixed this within the grlc code on the server...
So appreciated if this can be merged soon, so I can deploy it fully automatically (I use Puppet)
Cheers

hmm it still does not work properly... something with the python path or something...

Hi @jblom , thanks for this and apologies for the delay!
I think this should be safe to merge, but could you please resend the PR against the dev branch? That's where we test out stuff before deploying to master
Thanks again! A.

Hi @albertmeronyo no worries & thanks. When I'm diving back into this I'll make sure to do the PR on the dev branch.
Because of the difficulty of getting it to work I wanted to work on implementing something grlc compatible myself, so that the query retrieving/parsing/etc is the same, so that our search API does support "grlc queries", so we don't reinvent the wheel on that one (but are able put this in operations & conveniently maintain things).
Another big reason for considering building something myself is that there is a big part of the code that we don't need, which is the Swagger API part. We only need the python lib part that is able to fetch & run queries from GH.
Is that something you guys have though about? Offering a build for just the python lib (e.g. using pipenv install grlc-lib or something like that)

Is that something you guys have though about? Offering a build for just the python lib (e.g. using pipenv install grlc-lib or something like that)

This might be a good idea, and push us to define more clearly what parts go into the lib (with a good spec-gen, query-exec separation), and what parts use those lib assets from the grlc API
@c-martinez what do you think?

@albertmeronyo @c-martinez awesome that you'd consider this. It would be the perfect solution for us and I do think indeed it would help make the grlc code base more modular (and suited for different audiences).

I would be in favour of splitting grlc-api and grlc-lib if that solves this issue. On the other hand, it would be even better if we could fix the circular dependency bug without having to split the functionality -- we should go for whichever option is easiest to implement.

@c-martinez @albertmeronyo after 10,000 years I finally had the time to check out trying to fix adding grlc to our search API again.
I did end up at this old issue again (cyclic import bug) and now found out how to fix it without needing to change the grlc code (although I think there should be some fixes to avoid this in all cases: see further on).
The problem occurred because in my code I imported both the swagger & utils module (which import each other in your code base):
from grlc.swagger import build_spec
from grlc.utils import getLoader

So here I used swagger.build_spec, but the problem can be avoided by ditching the swagger import and only using utils.build_spec:
from grlc.utils import getLoader, build_spec

One thing however is, is that I see in utils.py that the utils.build_spec is going to be deprecated... So I'd say don't deprecate this until the cyclic import has been completely fixed.
This can be done by e.g. getting rid of the swagger import in utils.py and moving all swagger related functions to swagger.py (which makes more sense imho). If it is somehow necessary to keep swagger related functions in there, make sure that they are called externally only and include parameters to pass required swagger objects (so the import can be avoided).
Oh yeah I got another error when I passed the default value for extraMetadata=[] in the build_spec function. By setting the extraMetadata to None the bug was avoided (can post a bug report for this one).

Hey @jblom -- good to hear from you.
Indeed utils.build_spec should be removed one day, in an attempt to have all swagger related functionality in swagger.py, like you suggest. So indeed this will all be refactored at some point.
One thing which could be very useful is if we could have simplified version of how you using grlc, so we could incorporate it in the unit tests, and we could make sure your script would still work after refactoring.

@c-martinez Hi Carlos, good to hear from you too!
Thanks for offering the unit tests & hopefully a simplified version of grlc (that is optimised to use as a lib in code).
I hope to get in touch soon, so I can show you how we use grlc in code.
Cheers

Hey @jblom -- I'm adding some tests which I hope should cover your use case.
Cheers

@c-martinez great, thanks! I'll check these out as soon as I can. Also happy to tell you that we are finally fully back into the grlc game with our search API :-)
So hoping to show you guys some of our results and approach one of these days. We could organise a hang-out for this.

That is good to hear @jblom. Yes it would be nice to organise a hang-out and see what you guys are up to :-) -- just let us know when you have some time.


Add functionality allowing to enumerate threads of given state

Very useful new feature. Not finished playing with it yet, but so far is very helpful.

LGTM!


refactor(db) a more consistent options handling

Summary
Refactored kong.db.dao to be more consistent with the options table.
This was originally proposed in
#3710
And this is one of the series of PRs that were previously implemented in that branch.

@bungle I don't know how or why, but this seems to be triggering a "memory corruption" problem on nginx on travis.
Two possible things that could fix this (I am not sure):

maybe replace the varargs (...) with options as I mentioned before
try not localizing all the functions? Or localizing them in the scope they are used, instead of at the top of the file (shooting blind here)

@kikito memory corruption problem is unrelated to this PR. It is a problem in the Travis OpenSSL builds triggered by OpenSSL / luaossl bump.


[Bug]: Review Screen: GraphQL: Headers and query parameters key value representation is not according to the design.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Review Screen: GraphQL: Headers and query parameters key value representation is not according to the design.
Expected format: {key1: value1, key2: value2...}

Steps To Reproduce
Please refer to the design screen and the bug screenshot.
Public Sample App
No response
Environment
Deploy Preview (Default)
Issue video log
No response
Version
1.9.8

Will be fixed with the solution of #20898


TP2000-608 Unit tests for api list views

TP2000-608  Unit tests for api list views
Why
Previously the ReadOnlyModelViewSet views did not have any units tests, this story ensures that this coverage has been addressed
What
Unit testing API view sets

Codecov Report
Base: 93.46% // Head: 93.52% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (aa01370) compared to base (90ee4e5).
Patch coverage: 98.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   93.46%   93.52%   +0.06%
==========================================
  Files         345      345
  Lines       22787    22873      +86
  Branches     1764     1770       +6
==========================================
+ Hits        21297    21393      +96
+ Misses       1160     1150      -10
  Partials      330      330

Impacted Files
Coverage Δ

workbaskets/tests/test_views.py
98.73% <50.00%> (-0.32%)
:arrow_down:

additional_codes/tests/test_views.py
100.00% <100.00%> (ø)

additional_codes/urls.py
100.00% <100.00%> (ø)

certificates/tests/test_views.py
100.00% <100.00%> (ø)

certificates/urls.py
100.00% <100.00%> (ø)

common/tests/util.py
89.77% <100.00%> (+0.66%)
:arrow_up:

footnotes/tests/test_views.py
100.00% <100.00%> (ø)

footnotes/urls.py
100.00% <100.00%> (ø)

geo_areas/tests/test_views.py
100.00% <100.00%> (ø)

measures/tests/test_views.py
100.00% <100.00%> (ø)

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


HAWQ 569. Fixing an assertion failure and a potential double release of workfile_queryspace queryEntry

This commit ports Foyzur's fix on assertion failure because of multiple ExecutorEnd calls (story 114507991).

Hi @armenatzoglou,
I had merged it into branch master for the release date coming.
But I have a question: it seems that your fix doesn't fix the problem:
(1) you just move the line  'queryEntry = NULL;'  one line( if clause ) ahead.
(2) moreover, the interrupt may occurs before the line 'queryEntry = NULL;' after called SyncHTRelease().
The solution I suggest:
(1)If all memory and resource can be released even if WorkfileQueryspace_ReleaseEntry() not called. e.g. all memory palloced will be released for specific memory context released( transaction finished/statement execution finished....), then we can move the line 'queryEntry = NULL;'  to the line before calling SyncHTRelease().
(2) If cannot be auto-cleaned, then we should "HOLD_INTERRUPTS();" until we set  'queryEntry = NULL;'
Thanks.

Hi @armenatzoglou ,
Please ignore the comments above.
I look into the code of SyncHTRelease(), there is no calling 'CHECK_FOR_INTERRUPTS()' in this function or the functions it called if there is no error reported. So your fix can work I think.
Please close this PR. Thanks.

Thanks


Bench as a global .NET tool

Has the team considered packaging Bench up as a .NET Core global tool and shipping it on NuGet? I think it'd be an interesting tool for customers to have right there on the command line for benchmarking SignalR endpoints.
cc @davidfowl @anurse @chenkennt for your thoughts

I agree it's something we should do.
@ccic

@bradygaster Let us discuss it further about how to ship it on NuGet.
Something else about this tool:
Current features:
This tool currently supports performance evaluation on echo/broadcast/sendtoclient/sendtogroup on all supported transports and protocols of SignalR. In addition, it supports Azure SignalR's REST API (serverless mode).
In addition, it can be used as stability test since it allows long time running.
Feature plan:
There are some feature lists in my mind:

Friendly usage:
(1) Build a container web app which can be configured through the browser, and run it in K8S environment. Customer does not need to install anything. The behavior is similar as SignalR crank, but it does not collect CPU/Memory metrics.
(2) Expose REST API to control the benchmark master, like start/stop/query benchmark. Allow the customers to develop further based on those information.
(3) Enrich the client with support other development languages. Currently it only support C# client.

Extensible:
The benchmark is in fact a master-slave mode, and the framework is just responsible to communicate between master and slave nodes. Developers can customize their own plugins to replace the default SignalR plugin.

Deployment:
Cloud deployment: Azure SignalR service deployed this tool in Azure VMs currently. In fact, it support other deployment, like in K8S, or even in other kind of cloud.

Stress load test service:
The load test is a requirement for many products, it is better deploy it as a load service.

This tool currently supports performance evaluation on echo/broadcast/sendtoclient/sendtogroup on all supported transports and protocols of SignalR. In addition, it supports Azure SignalR's REST API (serverless mode).

We should definitely make it as effective for SignalR users as it is for Azure SignalR Service users; I think optimizing this as "a SignalR testing tool" is going to give us more customers to work with than it would if it were ASRS only.
What that means is, we'd need the global tool to be set up in such a way that a user could pass it a YAML file to parse, OR allow for parameterized calls, so I could pass it a hub name and a hub method to call from the command line.

Friendly usage:
(1) Build a container web app which can be configured through the browser, and run it in K8S environment. Customer does not need to install anything. The behavior is similar as SignalR crank, but it does not collect CPU/Memory metrics.

I don't dislike this idea, but I think we should first optimize for creating a global tool. This is a great idea, but my suggestion (this issue) was more around the idea of compartmentalizing what we can out of Bench to create a global tool that SignalR users could use to test their SignalR Hub performance and stress responses.

(2) Expose REST API to control the benchmark master, like start/stop/query benchmark. Allow the customers to develop further based on those information.

I think this is a good idea on the service side, but that we should focus on the SignalR benchmarking as a pri 0 and evaluate stretch features like this later.

(3) Enrich the client with support other development languages. Currently it only support C# client.

For the purpose of building a global tool, C# is fine - it'll be used primarily by .NET developers. Later on, once we have the tool authored, these additional features would be great to have, but I think they inflate the goals of having "a SignalR hub benchmarking global CLI tool."

Extensible:
The benchmark is in fact a primary/secondary (reworded) mode, and the framework is just responsible to communicate between primary/secondary (reworded) nodes. Developers can customize their own plugins to replace the default SignalR plugin.

I do love this idea. Again though, I think this might conflate the basic idea of a global tool. That said, if there was a way to pass in the "plugin-containing assembly" via a parameter, that'd be great. This way, a developer who authors a plugin can feed it to the tool at run-time.

Deployment:
Cloud deployment: Azure SignalR service deployed this tool in Azure VMs currently. In fact, it support other deployment, like in K8S, or even in other kind of cloud.

For a tool, I think this is orthogonal. But later, definitely.

Stress load test service:
The load test is a requirement for many products, it is better deploy it as a load service.

For a tool, I think this is orthogonal. But later, definitely.

@bradygaster

we'd need the global tool to be set up in such a way that a user could pass it a YAML file to parse

This benchmark supports simple command and YAML file to do performance test like this, but currently lack of one command to do build and run all the components like dotnet run perf -C config.yaml. Is it what you want?

We should definitely make it as effective for SignalR users as it is for Azure SignalR Service users; I think optimizing this as "a SignalR testing tool" is going to give us more customers to work with than it would if it were ASRS only.

I agree. This tool is for both SignalR and ASRS. It has already supports SignalR. The internal web app uses environment variable to enable/disable self host SignalR .

What that means is, we'd need the global tool to be set up in such a way that a user could pass it a YAML file to parse, OR allow for parameterized calls, so I could pass it a hub name and a hub method to call from the command line.

For a general test, the global tool needs to know the appserver endpoint, hub name, and scenario (hub method is included in scenario). For example, send to group, which requires the connection to join a specific group before calling the hub method. In addition, there are some other parameters, like transport type, protocol, message size, etc. That is why a YAML file is required. Of course, the tool provides many default settings. So, user does not need to input many parameters to run this test.

I don't dislike this idea, but I think we should first optimize for creating a global tool. This is a great idea, but my suggestion (this issue) was more around the idea of compartmentalizing what we can out of Bench to create a global tool that SignalR users could use to test their SignalR Hub performance and stress responses.

Agree. Let us ship the global tool first.


'Response' object has no attribute 'soup'

kg works perfect on my laptop, but on my linux machine I get the error message:
'Response' object has no attribute 'soup'
Any suggestions on how to fix this? Thanks!

I have the same problem

I have the same problem.. Please Help

Updating mechanicalsoup fixes this problem, but as the kaggle-cli hasn't been updated in years the beautifulsoup code written uses deprecated html class names and ids.


index on number type differentiates between integer and decimal notation

An index on an attribute of type number only considers a number expressed respectively with and without .0 to be diffferent, while these are just different representations of the same number. As an example, the following model prints False.
entity A:
    number x
end

implement A using std::none

index A(x)

std::print(A(x=0) == A(x=0.0))

Indexes seem to be built using repr, which comes across as very brittle to me: https://github.com/inmanta/inmanta-core/blob/0c5ce06735857cdf597279ea0c5604357b499298/src/inmanta/ast/entity.py#L384

Discussed in planning meeting:

make number behave like float: make an explicit decimal point required for the number type. The number(x) cast should be verified to work so it can be used to assign int values to number types.
create the float alias for number because it more clearly conveys what it means. Update documentation to use float rather than number.


Question: Is this package vulnerable to prototype pollution?

Popular argument parsing libraries such as minimist and yargs-parser have been hit by prototype pollution before. Is this library affected as well?
It seems that this is related to the "parse dot options as object" feature, so I suspect the answer is no. However, I'd like to ask just in case.
Also, I see multiple uses of for...in loops in the code. While it would not directly cause prototype pollution, would it be affected by objects that have inherited enumerable properties?
See also:

https://snyk.io/vuln/SNYK-JS-MINIMIST-559764
https://snyk.io/vuln/SNYK-JS-YARGSPARSER-560381

I suspect the answer is no. However, I'd like to ask just in case.

You're correct. Getopts doesn't have anything like minimist's "parse dot options as object" feature, so we're good.

While it would not directly cause prototype pollution, would it be affected by objects that have inherited enumerable properties?

You're also correct.


Printing of MHLO dialect doesn't hide large constant by default.

Please:
Consider the code
A = jnp.arange(100).reshape(-1, 10)
x = jnp.ones(10)
def f(x):
  return A @ x

print(jit(f).lower(x).compiler_ir(dialect='hlo').as_hlo_text())
print(jit(f).lower(x).compiler_ir(dialect='mhlo'))

Prints out the following text:
# ENTRY main.4 {
#   constant.2 = f64[10,10]{1,0} constant({...})
#   ...
# }

# #loc0 = loc(unknown)
# module @jit_f.4  {
#   func public @main(%arg0: tensor<10xf64> loc(unknown)) -> tensor<10xf64> {
#     %0 = mhlo.constant dense<[[0, 1, 2, 3, 4, 5, 6, 7, 8, 9], [10, 11, 12, 13, 14, 15, 16, 17, 18, 19], [20, 21, 22, 23, 24, 25, 26, 27, 28, 29], [30, 31, 32, 33, 34, 35, 36, 37, 38, 39], [40, 41, 42, 43, 44, 45, 46, 47, 48, 49], [50, 51, 52, 53, 54, 55, 56, 57, 58, 59], [60, 61, 62, 63, 64, 65, 66, 67, 68, 69], [70, 71, 72, 73, 74, 75, 76, 77, 78, 79], [80, 81, 82, 83, 84, 85, 86, 87, 88, 89], [90, 91, 92, 93, 94, 95, 96, 97, 98, 99]]> : tensor<10x10xi64> loc(#loc0)
#     ...
#   } loc(#loc0)
# } loc(#loc0)
# ...

The included largest constant makes inspecting IR generated by any more realistic program quite difficult(and slow, if the constant is very large). In the hlo case, the printing option (a HloPrintOptions object) defaults to short_parsable(I think) or at least have print_large_constants set to False, so the same problem doesn't occur.

It sounds like you want a version of https://mlir.llvm.org/doxygen/classmlir_1_1OpPrintingFlags.html#a9ffce93813bb433bc90d51d3c374baa6
which we could either achieve by something like https://github.com/google/jax/pull/9222 to let you pass additional arguments to the printer, or by having JAX return an ir.Module which you can print as you see fit.

I think it makes more sense for compiler_ir to return an ir.Module object since hlo and mhlo won't share many keyword arguments, hence I think attaching them to compiler_ir is less clean.


CDK VirtualScroll: Event when user stops scrolling in virtual scroll

What are you trying to do?
Im having a table with thousands of records to be displayed on the single page. So, Im using virtual scroll to display the data thereby I could minimize DOM manipulation.
There, I would like to apply the css at run time. Once the user stops the scrolling on my virtual scroll table, I need to apply the css to my table.
What troubleshooting steps have you tried?
I have searched for any events in cdk. I have found the scolled event in scrolldispatcher but i couldnt able to find the event while user stops the scrolling. Please help me on this.
this.scrollDispatcher.scrolled()
     .subscribe(event => {
       console.log('scrolled');
     });

Any help would be greatly appreciated!! Thanks in advance
Environment

Angular: 8
CDK/Material: 8.2.3
Browser(s): Chrome
Operating System (e.g. Ubuntu):

The typical way you would do this is by debouncing scroll events. With rxjs, you can use the debounceTime  operator:
https://rxjs-dev.firebaseapp.com/api/operators/debounceTime

Event of not scrolling is the opposite of scrolling. This can be achieved using the following syntax :
this.scrollDispatcher.scrolled().pipe(
      // don't catch each scroll event as you won't need it.
      debounceTime(10),
      // switchMap will not emit within the chain if new observable comes from scroll dispatch. Here you can configure when you consider the user has stopped the scrolling process
      switchMap(() => of('scroll stopped').pipe(delay(300)
      ))
    ).subscribe(v => console.log(v));


Wrong, do not work on editable subgrid

This event is not triggered on editable subgrid.
Is it a bug or a 'feature'?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b16f534-b222-84df-ce0c-70bd9960f20f
Version Independent ID: 8e749849-6b5f-1630-8d41-9cb04bf1e82c
Content: Subgrid OnLoad Event (Client API reference) in Dynamics 365 Customer Engagement
Content Source: ce/developer/clientapi/reference/events/subgrid-onload.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@ElMookov Thanks for this issue. Created a bug for the dev team to investigate this.

Will this work for Product Line Items Grid on Opportunity form? Looks like it is not working for me.


TS-4805: CID 1021743: Uninitialized scalar field

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/664/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/559/ for details.

:+1:


Getting "Unknown extension point: 'org.eclipse.textmate4e.core.grammars' in plugin.xml

I'm using the version from the update site, and it can't seem to find extension point 'org.eclipse.textmate4e.core.grammars' even though I have imported the correct bundles.
Require-Bundle: org.eclipse.ui,
 org.eclipse.core.runtime,
 org.eclipse.core.resources,
 org.eclipse.jdt.launching,
 org.eclipse.jdt.core,
 org.eclipse.debug.ui,
 org.eclipse.jdt.debug,
 org.eclipse.jdt.debug.ui,
 org.eclipse.jdt.ui,
 org.eclipse.jface.text,
 org.eclipse.ui,
 org.eclipse.core.resources,
 org.eclipse.core.filesystem,
 org.eclipse.ui.editors,
 org.eclipse.ui.views,
 org.eclipse.textmate4e.core,
 org.eclipse.textmate4e.ui

If I go to the "Add Extensions GUI in Eclipse, the extension point is missing there too:

Problem should be fixed but we have a problem with cloudbees https://opensagres.ci.cloudbees.com/job/textmate.java/ that we must fix it to recreate a new update site.

@ainsley please note that extension point API could change according developpers feedback like you. Any feedback are welcome!
My goal is to contribute to Eclipse https://projects.eclipse.org/proposals/textmate-support-eclipse-ide-textmate4e

Is this resolved now in the update site?

yes, but now the extension point name has changed to org.eclipse.tm4e.ui.themes.

Is there a guide where I can see instructions on how to integrate this into an existing plugin? Also, how are themes handled? Is Monokai in there?

I must improve wiki but you can read https://github.com/angelozerr/textmate.java/wiki/UI and see samples at https://github.com/angelozerr/textmate.java/tree/master/org.eclipse.tm4e.samples
I suggest you that you follow the Freemarker editor sample:

https://github.com/angelozerr/textmate.java/tree/master/org.eclipse.tm4e.samples/src/main/java/org/eclipse/tm4e/samples/freemarker

https://github.com/angelozerr/textmate.java/blob/master/org.eclipse.tm4e.samples/plugin.xml#L142

For the themes today by default it supports light and dark theme, but you can regsiter your own theme with extension point (only CSS themes is supported for the moment, see https://github.com/angelozerr/textmate.java/issues/2).

Is Monokai in there?

No but I can do it, please create a new issue.


[GH-235] Fixing nested configuration problems

https://github.com/input-output-hk/cardano-shell/issues/235
Continuation from https://github.com/input-output-hk/cardano-shell/pull/232

@deepfire merged this since it's required before merging https://github.com/input-output-hk/cardano-shell/pull/234


[MM-39708] Gekidou Thread Screen

Summary
This PR adds thread screen
Ticket Link
https://mattermost.atlassian.net/browse/MM-39708
Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[x] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on: iPhone 13
Screenshots

Release Note
Adds thread screen

Hey @anurag6713, how is this going addressing Elias' review?

@anurag6713 build is failing
><EMAIL_ADDRESS>lint
> eslint --ignore-path .gitignore --ignore-pattern node_modules --quiet .

/home/circleci/mattermost-mobile/app/screens/thread/thread.tsx
  15:9  error  'useTheme' is defined but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

Exited with code exit status 1

can you please merge the latest gekidou branch? thanks

/update-branch

/update-branch


KeyError in get_request

get_request is sometimes throwing a KeyError, because the metadata is not in the expected format.  Notably, "response-content-disposition" appears to be under the key "rscd" instead.
Full stack trace:
KeyError: 'response-content-disposition'
  File "celery/app/trace.py", line 412, in trace_task
    R = retval = fun(*args, **kwargs)
  File "newrelic/hooks/application_celery.py", line 84, in wrapper
    return wrapped(*args, **kwargs)
  File "celery/app/trace.py", line 704, in __protected_call__
    return self.run(*args, **kwargs)
  File "muckrock/portal/tasks.py", line 37, in portal_task
    method(*args, **kwargs)
  File "muckrock/portal/portals/govqa.py", line 76, in receive_msg_task
    request = client.get_request(request_id)
  File "govqa/base.py", line 217, in get_request
    "content-disposition": metadata["response-content-disposition"][

Value of metadata:
{
    'rscd': ['attachment; filename=SONYMA_Single_Family_-_Loans_by_FY2020_thru_FY2022.xlsx'],
    'se': ['2023-06-01T05:21:08Z'],
    'sig': ['McUq4LBali2JMZXmPUysQih22XJ6NoRWVvwJW4ZbDLI='],
    'sp': ['r'],
    'sr': ['b'],
    'sv': ['2015-04-05']
}

A sample of GovQA instances where this has occurred:

https://hcrny.govqa.us/WEBAPP/_rs/
https://publicrecords-spokanewa.govqa.us/WEBAPP/_rs
https://sanfranciscopd.govqa.us/WEBAPP/_rs

thanks @mitchelljkotler , could you add credentials for some of those sites to the google doc: https://docs.google.com/document/d/1MAv51uYi_CuFJNXRh78GM2eln5yBEAH1_VJ_5ZLKTsk/edit

I added two credentials to the document


Consider a different license

Hi! Thank you for sharing this research and code with the public.
Currently, other popular salient object detection implementations such as U2-Net and TRACER are licensed under Apache License 2.0. I'm curious if you are committed to the CC BY-NC-ND 4.0 license or if you are open to considering a more permissive license.
From a practical standpoint, the current license prohibits a lot of folks in the ML community from using (and therefore contributing back to or extending) this work.

Thanks for your advice and interest of this work, we are very likely to loose the license. Since I do not have any experience in this, I put a relatively tight license here.
I will update and let you know.

@samwaterbury an email sent to you~
cheers

Thanks again @BarCodeReader!


how to train?

1.how to train ?
2. how to install torchgeo>=0.5.0

@d710055071 see the train.py script for how to train on the dataset.
You can install torchgeo using pip install torchgeo


Web connection issues from edge browser

This is Edge on mac
Had a couple different issues trying to connect from github.dev to a local server. First, it seemed like it had connected successfully, but couldn't load any kernels. Later, I press enter in the server input and nothing happens.
I launched my server with the flag to enable connections from other origins

In Chrome, this all actually worked fine

This should be fixed with the l;atest kernel picker,
closing as verfication required.

Seems to work fine now!


Agent: consistent 'containerID' field in the log of the requests EP-delete and EP-create

Previously, it was difficult to find creates and deletes based on container ID due to non-consistent container ID field in the log: 'EP create' used short-form container ID, 'EP delete' used standart form. For examle:
'EP create':
level=info msg="New endpoint" containerID=77ce9db8c9 datapathPolicyRevision=0 desiredPolicyRevision=0 endpointID=3100 identity=5 ipv4=<IP_ADDRESS> ipv6= k8sPodName=default/pod subsys=endpoint
vs
'EP delete':
level=info msg="Delete endpoint request" id="container-id:7eab59b2e768e9845af3988be879558186e3215e018577c139a3405cbd424e37" subsys=daemon
This patch fixes it: 'EP delete' uses short-form container ID as 'EP create'.
Fixes: #13658
Signed-off-by: Roman Ptitcyn<EMAIL_ADDRESS>

Any reason why the below line is still there ? I am under assumption that this should be removed/updated as mentioned in github issue.
https://github.com/cilium/cilium/blob/4c827bf7d1e2c0f2a5ff4c6b606f7c17bda316fa/daemon/cmd/endpoint.go#L702-L703

Thanks Tam!
I'll update this

Any reason why the below line is still there ? I am under assumption that this should be removed/updated as mentioned in github issue.
https://github.com/cilium/cilium/blob/4c827bf7d1e2c0f2a5ff4c6b606f7c17bda316fa/daemon/cmd/endpoint.go#L702-L703

Thanks Tam!
I'll update this

test-me-please

test-me-please

LGTM 💯

Thanks :)

LGTM 💯

Thanks :)

retest-gke

retest-gke

retest-net-next

retest-net-next

Hit https://github.com/cilium/cilium/issues/12511

Hit https://github.com/cilium/cilium/issues/12511

I am not sure if K8s-1.13-Kernel-netnext  is a flake, does anyone know?
It fails on this:
[Fail] K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan [It] Tests with secondary NodePort device
19:42:40  /home/jenkins/workspace/Cilium-PR-K8s-1.13-net-next/src/github.com/cilium/cilium/test/k8sT/Services.go:892

I am not sure if K8s-1.13-Kernel-netnext  is a flake, does anyone know?
It fails on this:
[Fail] K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan [It] Tests with secondary NodePort device
19:42:40  /home/jenkins/workspace/Cilium-PR-K8s-1.13-net-next/src/github.com/cilium/cilium/test/k8sT/Services.go:892

Hit #12511

Looks like K8s-1.13-Kernel-netnext is indeed hitting this well-known flake.
[Fail] K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan [It] Tests with secondary NodePort device
19:42:40  /home/jenkins/workspace/Cilium-PR-K8s-1.13-net-next/src/github.com/cilium/cilium/test/k8sT/Services.go:892

Based 2 reviews, this is good to merge, I believe :) Adding ready-to-merge label for @cilium/janitors to pick this up.

Hit #12511

Looks like K8s-1.13-Kernel-netnext is indeed hitting this well-known flake.
[Fail] K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan [It] Tests with secondary NodePort device
19:42:40  /home/jenkins/workspace/Cilium-PR-K8s-1.13-net-next/src/github.com/cilium/cilium/test/k8sT/Services.go:892

Based 2 reviews, this is good to merge, I believe :) Adding ready-to-merge label for @cilium/janitors to pick this up.


Keyfigures_finland

I made a new pull request. I had to delete the alarm-clock sound from the assets.

Hi @tuopouk
Thanks for updating the PR.
Just curious - why did you make the figure with a clientside callback?
Could you also make a version that updates the figure with a regular callback, and does not use  dcc.Store?  It would be very interesting to benchmark the performance differences.

@AnnMarieW It's really a night and day difference. I tested it with both clientside and server side and the clientside gives almost instant feedback. I put the app on render with other region layers. You can check it out. http://keyfiguresfinland.onrender.com/

the clock file is still there, I'll make a new PR

That's great that you saw an increase in performance.  Could you please post the server side version as well as a new file?  I'd like to try running both versions.


Translated remaining title with non-standard characters

The remaining title needed non-standard characters to be translated. With the new font support it can finally be implemented.

Thanks for your contribution to Homebrew!  You rock!


Import Open API 3.x Spec into Bruno

What is required for work on this to be started? How can I help?

The feature implementation pull request has been merged, so we can close this. PR


pre-pr request: installation instructions

It took a bit time to figure it out, so I guess it may have value to add these lines to the README.
I can do PR or maybe you  can just add them.
On MacOSX 10.10+
''''''''''''''''
First run (assuming homebrew installed):
::
$ brew install llvm37
$ export LLVM_CONFIG=/usr/local/opt/llvm37/lib/llvm-3.7/bin/llvm-config

The official supported way to install Numba is to install the conda packages. We want to allow people to use other methods but we don't really want to encourage them.

I have the same issue on RedHat
$ yum search llvm
Installed Packages
Name        : llvm
Arch        : x86_64
Version     : 3.4.2
Release     : 8.el7
$ python --version
Python 3.4.5
$ pip install numba
File "/tmp/pip-build-v85qmsc6/llvmlite/ffi/build.py", line 131, in main
main_posix('linux', '.so')
File "/tmp/pip-build-v85qmsc6/llvmlite/ffi/build.py", line 94, in main_posix
"to the path for llvm-config" % (llvm_config,))
RuntimeError: llvm-config failed executing, please point LLVM_CONFIG to the path for llvm-config

Now I have the wrong LLVM
$ sudo yum install llvm-devel.x86_64
$ locate llvm-config

/etc/alternatives/llvm-config
/usr/bin/llvm-config
/usr/bin/llvm-config-64
/usr/include/llvm/Config/llvm-config-64.h
/usr/include/llvm/Config/llvm-config.h
/var/lib/alternatives/llvm-config

$ LLVM_CONFIG=/usr/bin/llvm-config  pip install numba
RuntimeError: Building llvmlite requires LLVM 4.0.x. Be sure to set LLVM_CONFIG to the right executable path.
Read the documentation at http://llvmlite.pydata.org/ for more information about building llvmlite.

Closing in favor of adding pip instructions now that we have wheels: #2586


fix: check filesize on upload and disable the upload action with corresponding error

Resolves #108

🐝 PR preview in Swarm
Preview URL: https://bafybwibdco5r6ehdbxjx7wdwlwcgp4pogvljk5gfuqjmandgkc6q47pfju.bzz.link
Swarm Hash: 2313bb1f10e30dd37fd8765d8467f1ee35569574c5a412c0346650bd0e7de54d
Commit Hash: f293bd0e7f77c55b7bc37de993ccea7d7f7c3a70
Commit Message: fix: check filesize on upload and disable the upload action with corresponding error


the lua5.3 interpreter does not define "unpack"

Hello,
src/lualib/FunctionCall.ts
src/lualib/FunctionBind.ts
src/lualib/FunctionApply.ts
all rely on the lua "unpack" function.
For me it is working fine in lua5.1 but lua5.3 does only define "table.unpack" instead.
Something like
unpack = unpack or table.unpack
at the beginning of the lualib_bundle could solve this issue.
Best regards, tjahn

LuaLib is built on distribution time at the moment. This presents a real problem when transpiling to different Lua targets. We will probably have to end up transpiling the lualib on project compilation.

It looks like all three of those lib functions already mitigate unpack in the way you suggested:
__TS__FunctionCall = function(fn, thisArg, ...)
    local args = ({...});
    return fn(thisArg, (unpack or table.unpack)(args));
end;

Are you sure you are using the latest version?

Oh yes, I am sorry. I apparently did not investigate close enough.
The problem I experienced actually did not arise in these three files.
However, this here:
function func1( ...args: any[] ){ } function func2( ...args: any[] ){      return func1( ...args );  }
compiles to that:
local func1; func1 = function(...)     local args = ({...}); end; local func2; func2 = function(...)     local args = ({...});     return func1(unpack(args)); end;

Hmmmm... strange. If I compile that code with --luaTarget 5.3 I get this:
local func1;
func1 = function(...)
    local args = ({...});
end;
local func2;
func2 = function(...)
    local args = ({...});
    return func1(table.unpack(args));
end;

What are your command-line options/tsconfig?

Oh no, I am really sorry for the inconvenience.
I selected the wrong tsconfig.json and kept building it for the default target. Should have used the command-line argument to be sure.
Many thanks for your efforts

No problem - it happens!


Resizing window to small results in broken tab

If the terminal window with text on the line the is resized to very small and then later resized to a normal size, the tab that is in focus will be in a broken/unusable state.  This happened to me when I remoted in from a different machine and there were some DPI changes, the terminal window was resized.
Environment
Version 10.0.18362.113
Windows Terminal version: 0.1.1502.0
I am on a high dpi monitor, 200%.
Any other software? No

Steps to reproduce

open new terminal window
type in some long text in the window, gibberish is fine
resize the window to be really small, minimum size
wait a few seconds
resize to normal size
-- observe tab is unusable, typing in it does nothing

Expected behavior
Tab to be usable
Actual behavior
observe tab is unusable, typing in it does nothing

Looks like it could be #1095?


Missing CSV fixture file

Tests are not passing anyway :
partialify/node_modules/tape/index.js:65
        throw err
              ^
TypeError: Object #<Object> has no method 'match'
    at resolve (partialify/node_modules/browserify/node_modules/module-deps/node_modules/resolve/lib/async.js:29:11)
    at makeTransform (partialify/node_modules/browserify/node_modules/module-deps/index.js:284:9)
    at ap (partialify/node_modules/browserify/node_modules/module-deps/index.js:203:13)
    at applyTransforms (partialify/node_modules/browserify/node_modules/module-deps/index.js:220:11)
    at partialify/node_modules/browserify/node_modules/module-deps/index.js:171:17
    at fs.js:271:14
    at Object.oncomplete (fs.js:107:15)

I don't know what's wrong but if you remove {onlyAllow: ['xml', 'csv']} https://github.com/LoicMahieu/partialify/blob/master/test/index.js#L147, tests are ok.

It would be really nice to plug this project with Travis.

Thanks for catching that! Tests pass as expected now.


How to install?

How to install? Can it be installed in JupyterLab 4.x?

https://pypi.org/project/jupyterlab-miami-nights/
pip install jupyterlab-miami-nights

yes


Remove unused Enforcer Group fields causing potential confusion

The EnforcerGroup struct (in the file client/enforcers.go) defines the request and response format for an Enforcer Group (via the hostsbatch API call to the Aqua Server). Currently, this struct includes the following line of code:
NetworkActivityProtection                 bool                 `json:"network_activity_protection"`

However, a call to the hostsbatch API does not actually return any JSON result for the key network_activity_protection. Since this unused field is very similar to network_protection and host_network_protection (both of which are used), this can lead to confusion.
To reduce the likelihood of misuse/confusion, all references to NetworkActivityProtection and network_activity_protection should be removed from Enforcer Group-related type definitions and functions.
Similarly, there is an unnecessary inclusion of hostname in the schema.Resource object returned by the function resourceEnforcerGroup (in the file aquasec/resource_enforcer_group.go), which should also be removed.

Fixed by #117


*.eventname does not fire in own namespace

Hiya,
I searched but did not find this bug. Apologies if i simply didn't search well enough. I'm newish to searching git issues.
Description of the bug:
I find the above mentioned behavior counter intuitive. I would not expect to have to separately register an event for when it fires in its own container and when it fires in a subordinate container.
eg ractive.on('myevent *.myevent'), which is what i'm finding.More exactly, since this and . can generally be used in ractive, I would expect this./{emptystring}. to be among the valid prefixes covered by *.
I would rather expect to use a special notation to indicate i'm only interested in it firing in the current container or only interested in subordinate container firings.
Perhaps *.myevent could be distinguished from a more specifically child only notation?
Versions affected:
0.7
Platforms affected:
Chrome
Reproduction:
this is exactly how i found this. Obviously, switching around which lifecycle event it's in may have nothing to do with this

Define an oncomplete method for a ractive template.
In oncomplete add an event with this.on('*.myevent',function(event){ alert('I fired!'); });
In your template add a button <button on-click="myevent">Pick Me!</button>
Create a component and include it in your template <mycomponent />
In the template add a button <button on-click='myevent'>No, Pick Me!</button>
When you view this, the button within the component will fire the event, but the one within the original template will not.

Code:
See steps to reproduce

I think it seems reasonable that this.on('*.foo') should fire on this.fire('foo') too. @martypdx?

I dunno, but personally I do not thing it should be so... I always saw the . like a namespace separator... so, this.fire('clicked') shouldn't fire for this.on('*.clicked') unless it was this.fire('foo.clicked') cause I would want these to be different:

<button on-click="clicked">...</button>
<button on-click="button1.clicked">...</button>

not sure exactly, but I may have to change some code if this were to change.

I think it's a valid change. If you consider clicked as this.clicked (this as namespace), you would expect *.clicked to be fired.


Enclave CLI adapter to use PicoCLI

Makes the Enclave use PicoCLI, which can handle a lot of the heavy lifting and boilerplate of configuration parsing.
This leaves the Enclave to only need to do its main function of starting the Enclave up with the provided configuration.
The parsing exceptions are handled at a higher layer, and are kept hidden from the Main method. This is what handleParseException method is for (to show the output of a parsing issue) and the addition of a default CliResult, which will suppress startup with code 1.
The parse exception was also not handled previously by the Enclave, but if it was desired, we could catch the library exception and handle it there instead of returning the default CliResult.

Allow exception caused by parameter parsing to be thrown up (e.g. a JSON parsing issue with the config, NOT when a parameter is missing, which is what the above explains)
Remove the old PidParser, as this is now fully replaced by the PID mixin
Add proper description for "admin" command
Removes/updates some old config styles for tests

Part of https://github.com/jpmorganchase/tessera/issues/874

Codecov Report

Merging #891 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     99.39%   99.47%   +0.07%
+ Complexity     2097     2093       -4
============================================
  Files           317      316       -1
  Lines          6112     6077      -35
  Branches        313      308       -5
============================================
- Hits           6075     6045      -30
  Misses            5        5
+ Partials         32       27       -5

Impacted Files
Coverage Δ
Complexity Δ

...quorum/tessera/cli/parsers/ConfigurationMixin.java
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

.../com/quorum/tessera/admin/cli/AdminCliAdapter.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...a/com/quorum/tessera/cli/CLIExceptionCapturer.java
100% <100%> (ø)
5 <3> (+2)
:arrow_up:

...m/quorum/tessera/config/cli/DefaultCliAdapter.java
99.36% <100%> (ø)
22 <0> (ø)
:arrow_down:

.../main/java/com/quorum/tessera/cli/CliDelegate.java
100% <100%> (ø)
12 <0> (+1)
:arrow_up:

...orum/tessera/enclave/server/EnclaveCliAdapter.java
100% <100%> (ø)
5 <4> (-3)
:arrow_down:

.../tessera/admin/cli/subcommands/AddPeerCommand.java
100% <0%> (+2.63%)
11% <0%> (ø)
:arrow_down:

.../quorum/tessera/sync/SyncResponseMessageCodec.java
100% <0%> (+3.22%)
5% <0%> (ø)
:arrow_down:

...ain/java/com/quorum/tessera/p2p/RestP2pClient.java
100% <0%> (+6.89%)
9% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf08ba...4c58b99. Read the comment docs.


Using Year only

Hi, i want ask how to pick only just year?

Is it resolved please? I had a similar problem, just need the year and month


Fix test error introduced by my last PR

Fix error introduced by my last PR (when IDE is None, return Response(status_code=405)).
Also added a test similar to test_http_get_playground_enabled() but for graphiql to increase test coverage as before my PR.

Thanks!

thanks to you actually :smiley:


TechDocs: Use external storage for publishing generated files (GCS)

This PR adds the feature to use an external storage (Google Cloud Storage) as a place to store the generated TechDocs static content. For more context, see https://backstage.io/docs/features/techdocs/architecture
It makes breaking changes to TechDocs (@backstage/plugin-techdocs and @backstage/plugin-techdocs-backend). Please read through the changeset for details.
Closes #3400
Closes #3096
Note to reviewers
This is to help you review this PR faster. If you can not go through everything, I'll be thankful if you can review just these -

Have a look at the new configs. Link
techdocs-backend Router and how it serves to TechDocs using the new techdocs-common package. Link
The abstraction of all types of publishers (Local, GCS, S3, etc.) Link
How the Google Storage publisher works. Link

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

@backstage/maintainers May I ask you to please take a look at this, one more time? Some things changed since @freben last approved it. I have added a "Note to Reviewers" in the PR description, docs and changeset should help as well.
We in @backstage/techdocs-core did a mob-review for this. Let me know if you want me to jump in for a chat with you.
Thanks! 🙏 🙇

@Rugvip @freben Review changes ✅

Thanks for the feedback @freben ! All looks good and will follow up on them. Take care 🌻

Something weird happening in CI. All the tests pass locally, but on CI it's not able to find couple of files (which exist!). 🤔

@freben @iamEAP @hooloovooo Thank you so much for your valuable review - good learning experience for me! I have followed up on all of them. Please give a +1 or suggest more changes.

@backstage/maintainers Thinking about merging this today, to unlock more smaller issues/PRs. 😁


Listener Icon Description - Does not show 'Radio' Information

The uploader_radio field seems to be ignored when displaying listener information (e.g. when a listener icon is clicked). It currently shows software name/version information in the Radio field.
Suggest we show data as follows:
Software: software_name - software_version
Radio: uploader_radio
Antenna: uploader_antenna

Solved.


#258 - sets up XSRF tokens to be used in api calls via angular

Current implementation serves as middleware.   Attaches XSRF header token to all requests made to /api/*.  Utilized by angular $http requests.   Allows the use of the ValidateAntiforgeryTokenAttribute.
For example:
[HttpPost]
[ValidateAntiforgeyToken]
public IActionResult Post([FromBody] CustomerGroupForm model)
...

#639


is anybody manage to make it work on linux?

Looks like it is not working plug and play on linux, is anybody manage to install it and detect key pressed on linux?
How?

I tried but it's not working as expected.

i cant even run a simple script like:
const ioHook = require("iohook");

ioHook.on("keypress", (event) => {
  console.log(event);
  if (event.keychar == "a") {
    console.log("wow! A pressed!");
  }
  // {keychar: 'f', keycode: 19, rawcode: 15, type: 'keypress'}
});
ioHook.start();

@hiwyn are you able to fix this error?
Error: GET https://github.com/wilix-team/iohook/releases/download/v0.9.3/iohook-v0.9.3-electron-v87-linux-ia32.tar.gz returned 404
Prebuild for current platform (iohook-v0.9.3-electron-v87-linux-ia32) not found!

@manpreet981 iohook ended support for 32 bit Linux so there is no prebuild for that platform. You can try compiling manually or use an older version of iohook.

@hiwyn can you give more info? I can run in it Linux (Ubuntu) no problem. I did the manual build approach though so that I can use electron 18 (latest) and node 16.

@jove0610 are you able to manage it with pipeline also?

@manpreet981 I just do npm ci, then download the build I created in google drive and paste it in the iohook modules.

@jove0610 same problem then here
https://github.com/wilix-team/iohook/issues/386
could you tell me the steps u follow to rebuild it?
because i did the npm rebuild but still showing the same error:
hiwyn@hiwyn:~/tendonitis$ npm rebuild
rebuilt dependencies successfully
hiwyn@hiwyn:~/tendonitis$ node index.js
load_input_helper [1918]: Using XFree86 keyboard layout.
load_input_helper [1920]: XKB support is required to accurately determine keyboard characters!
internal/modules/cjs/loader.js:1057
  return process.dlopen(module, path.toNamespacedPath(filename));
                 ^

Error: The module '/home/hiwyn/tendonitis/node_modules/iohook/builds/node-v72-linux-x64/build/Release/iohook.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 87. This version of Node.js requires
NODE_MODULE_VERSION 72. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1057:18)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/hiwyn/tendonitis/node_modules/iohook/index.js:24:21)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
hiwyn@hiwyn:~/tendonitis$

could you tell me the steps u follow to rebuild it? because i did the npm rebuild but still showing the same error:

Clone the repository with git clone https://github.com/wilix-team/iohook
If you're on windows, make sure you have Visual Studio Node.js Build Tools installed. Then, install the required dependencies for the iohook project with npm install and then build iohook with npm run build. If built successfully, you will have a builds folder with iohook built for the node version you were using.
I think this should theoretically work but i am facing an issue where the version i built doesn't work as "iohook.node is not a valid Win32 application" according to the error i get when i try to run my app which includes iohook

Duplicate #348


FYI the link to http://www.newartisans.com/software.html is broken

(In the GitHub project summary)


Chore: forbid using relative imports across the repo

Description

setup needed to #492

Type of change

Refactoring

the actual issue happened a bit earlier
https://github.com/dzcode-io/dzcode.io/actions/runs/3073564402/jobs/4965779877#step:8:35
it's now fixed, and the stage looking good on stg-v4.0.4-pr493.1