[HOLD for payment 2024-04-05] [$500] Avatar of user who sent message disappears after deleting comment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:  N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
and log in as user A
In incognito log in as user B
As user A, open the chat with user B and send a message
As user B, send two messages
As user B, delete the last sent message

Expected Result:
The avatar of user B is still displayed next to the sent message
Actual Result:
The avatar of user B disappears after deleting a message
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/2be5c4d8-56ac-4678-abe9-b8cdfa6f1c44

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010d8a4fbe15a51d30
Upwork Job ID:<PHONE_NUMBER>072977408
Last Price Increase: 2024-03-22
Automatic offers:

Pujan92 | Reviewer | 0
gijoe0295 | Contributor | 0

Issue OwnerCurrent Issue Owner: @anmurali

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this bug might be related to #vip-vsb

👀 looking into this

I'm sus of this PR https://github.com/Expensify/App/pull/36747, reverting locally and testing.

🚫 nope nevermind still reproducible

heh was probably the big comment linking PR https://github.com/Expensify/App/pull/30269/ then 😅  but i don't know that we're going to revert that.
I'm going to add external b/c I think the existing proposal makes sense, i'm a little confused how this works without anything checking for if the comment is deleted or not (ie: this should probably happen on production as well but 🤷).

Thanks for the proposal @gijoe0295. Yes, it seems to be a regression from https://github.com/Expensify/App/pull/30269.

Before that PR, we filtered out report actions by shouldReportActionBeVisible which also filtered deleted actions. But after that, we retrieved all report actions.

I do not fully agree with the RCA as earlier also we retrieved all actions in ReportScreen, we have just renamed the props there. Or maybe I misunderstood your RCA which you can help me to correct.
Issue seems to be inconsistent data passed to the InvertedFlatList and renderItem 's isConsecutiveActionMadeByPreviousActor condition. As with that PR here we are passing sortedVisibleReportActions to the InvertedFlatList, same(sortedVisibleReportActions instead of sortedReportActions) we need to pass to isConsecutiveActionMadeByPreviousActor .
https://github.com/Expensify/App/blob/32a4d9f8aa933495dd15e5720b2c5bc82e1ffd6f/src/pages/home/report/ReportActionsList.tsx#L521

We should use sortedVisibleReportActions as a param for isConsecutiveActionMadeByPreviousActor

@gijoe0295 Your solution looks correct to me. cc: @bondydaa
🎀👀🎀 C+ reviewed

@Pujan92 You can compare getSortedReportActionsForDisplay before and after the PR to see. Note that after the PR, we enabled shouldIncludeInvisibleActions in ReportScreen.

Ah, I see. Thanks @gijoe0295. So earlier from ReportScreen we are passing only visible actions but after this PR it is passing all report actions. Whereas in the ReportActionsList we created the sortedVisibleReportActions  and passed it to the InvertedFlatList but missed updating the isConsecutiveActionMadeByPreviousActor argument for displayAsGroup prop.

Great thank you for the discussion and helping get to the bottom of all that 🙇.
I think we should still block the deploy for this one since it is pretty bad to have a message from a different user end up getting shown as if it was from the wrong user.

merged the PR, requesting a CP now.

@kavimuru can you retest this and confirm it's fixed, CP should have been completed about 40 minutes ago so should be ready on staging.

Can confirm this does not happen on staging anymore. Removing the blocker label

@anmurali will handle payment

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/30269
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30269/files#r1566259198
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[X] [@Pujan92] Determine if we should create a regression test for this bug. Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Send consecutive messages from User A to User B and vice-versa
Delete any of the message
Verify that the senders info shows correctly with the messages

Do you agree 👍 or 👎 ?

Paid and added regression test.


fixing tests

I created a development environment based on the Dockerfile.alpine image. Within the development container I updated the moto.mock_* references to moto.mock_aws, which is the method provided by the current moto package. All tests ran successfully in that container as well as when I build the test image.

The changes in this PR were actually applied to the dev2024 branch, and merged with PR#19


Team renaming

It would be nice if there was support for renaming the team names from CT and T to something custom.

The game supports this with by setting the mp_teamname_1 and mp_teamname_2 cvars on the game server, or by having everyone join a Steam group and selecting that group as their clan tag.
Would either of these work for your use case?

Unfortunately not, It's for a UK Uni league and the plugin/backend they use for setting up the servers don't input the teamnames automatically and it's uni students so they don't use Steam groups, getting uni students to do anything is impossible.


OSS - Comment/improve existing material

Need to review and provide feedback ASAP: planned to present in September already.

I reviewed the material linked in the description. Can you do the same @gcharest @smellems and add your feedback?

I really like that all this already exists and is being submitted for endorsement.  They even have inventories of OSS they are using!
Recommends that:

ESDC considers OSS Solutions as the preferred option in IT procurement;
An OSS Programs Office be created.

They also reference the TBS guides on Github!
One this I noticed is that Chrome is identified as OSS.  Chromium is OSS not Chrome.

I reviewed the documents listed above and added a few comments. Overall, this is great work and I really am looking forward the presentation.
I do have a few notes regarding the presentation itself but will share them back at the office.

@gabrielcossette @smellems Just confirming I sent all my comments on presentation via email and my comments on the word document have been saved on your fork Gabriel.
Thanks! (I think we're good to close the issue?)


Changing the name of a profile renders it inaccessible

Example
Scroll to the bottom of this page and try to click on Lars Henrik Bolstad.

I may add that this is my former user, which I am not even able to access through a password reset (no email received), and have since migrated to a new user.

So the problem is we don't properly handle usernames with spaces. We should prevent the user from including a space in their username when saving.

I updated the username to lahebo and through the admin panel set your full name as a separate full name instead (not currently possible from the profile settings). Can you still not reset the password for it?

Thank you. My old password works now, so I won't risk a reset unless you really need me to. By the way, you misspelled my name. My name is Lars not Lass.

Sorry about that! I did it on my phone, but it's fixed now 😅

Thanks!


[Databrick] meta property gay between Json sample and Request structure.

Hi guys,
We notice that there is meta property gap between the Json sample code and Request structure section.
Whether it is typo in the Json sample code section?
Please refer to the following snapshot:

Best Regards,
Edward Chen

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5e5705b9-3ec2-f680-3238-acc4ab646b52
Version Independent ID: 5d6b6e4c-efa9-bc3d-e76e-8f104f3e887c
Content: Clusters API 2.0 - Azure Databricks
Content Source: databricks/dev-tools/api/latest/clusters.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@rockboyfor
Thanks for your feedback! We will investigate and update as appropriate.

@rockboyfor
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.

#sign-off


Caching modules

This PR implements an automatic caching mechanism for the optimization of player modules. All compiled modules are now automatically cached to ~/.zse_cache/{lm_name}/{role}/{optimizer}/{dataset}/module.json

Tested with optimize: true for the following games
python run_game.py -c configs/chess.yaml
python run_game.py -c configs/mathquiz.yaml
python run_game.py -c configs/gandalf.yaml


problem about the test results

Hi, thanks for your kind share.
When I run "test.py" by mode 3 and evaluate its results by running just "evaluation.py", I got the following results:
[{"name":"Accuracy","value":0.009182114614357603,"order":"desc"},{"name":"FP","value":0.005751258087706684,"order":"asc"},{"name":"FN","value":0.992451473759885,"order":"asc"}]
Is there something wrong? How can I fix this probem?

In my opinion, some paths like weigh file or result file is wrong. How about check them?


[AMBARI-23809] Identical sets of capacity scheduler properties are displayed as unequal ones in configs comparison view

What changes were proposed in this pull request?
While comparing different YARN config versions, capacity scheduler values are shown as different ones. The only displayed difference is the order of properties in those sets, though even the order is the same for both versions.
How was this patch tested?
UI unit tests:
21522 passing (25s)
48 pending

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2222/
Test PASSed.


[W6.2][W15-B3]See Jia Min Jasmine

Added an application icon and changed fonts style and size

@JasmineSee
We encourage you to get your hands dirty enough to start working on the project's UI.
Closing this PR with minimal review.


Set up PostgreSQL DB for consumption

Spin up Docker containers containing base project structure. This PR also contains the initial DB scripts, but not the scripts to populate the database in the docker containers.
Issue  #2

[x] implement db in postgres
[x] if actual db structure differs from documentation, update ERD
[x] Test current structure
[x] commit SQL files to repository

Further DB population scripts coming in a later PR


CI badges

@avik-pal would you please add the CI badge to the README? It will be nice to give visibility to this. Also feel free to add the SciML blue style badge if appropriate.

Check out this project: https://github.com/7AXEL/Web2APK


bigbed tracks show the features twice

I noticed in the latest dalliance master, when using bigBed as a track source file, all of the features in the bigbed track are displayed twice. If I load the earlier stable dalliance, I don't see this issue. I think this issue must have come up recently. It doesn't seem to matter which bigBed file I use, they all list the features twice.

Thanks, will investigate...

Thanks very much for reporting this.  I've not been able to find anything specific in the bigBed support that could explain this issue.  However, if your bigBed files all contain gene or "gene-like" data (i.e. "bed12" format with exon coordinates etc.), I think I've spotted a rendering bug which might explain what you're seeing.  I've fixed the render (which should now match 0.13 behaviour).
Could you give this a try?

Yes that fixes the issue. Thanks!


Document solution to migration name collision

This PR adds a Troubleshooting section to the readme, and explains a solution to a problem that can occur if running both normal testbench tests and Dusk tests in the same test suite.
References #26

Coverage remained the same at 83.465% when pulling 297c23df3cbd3b610b06be82f809ebf32467e255 on bjuppa:patch-1 into 1b2e42c818d4ac856542cc67f0ea88a3414054a6 on orchestral:3.8.

Thank you


Build plan for segregating namespaces for example will python and php be a subdomain or a directory

A pros and cons has been created here. This has concluded that subdomains should be utilised and to take the hit during development.

As per the description a decision has been made and documented (here)[https://github.com/RockProfile/devfaq.com/wiki/Subdomain-vs-Subfolder]


Close button on toast does not work

Bug description
The close button on a toast should dismiss the toast but that doesn't seem to happen.
Steps to Reproduce
Happens on multiple toast instances:

After deleting a publication
After publishing a publication
After withdrawing a publication
After (un)locking a publication

Risk classification
Likelihood

Frequent (always)

Consequences

Marginal

Expected behavior
The toast should disappear immediately.
System information
Desktop

OS: MacOS
Browser: Chrome

Additional context
Maybe the toast should also close upon hitting the ESCAPE key.

@nics do you have any idea? I noticed in the toast.js it says bc-toast instead of toast, but when adapting this, it did not do the job. I did however have to overwrite some css to make them visible.

@mietcls see https://github.com/ugent-library/biblio-backoffice/pull/1250


Replace Carbon Ads with CodeFund

I'll verify tomorrow with a clear head the async situation with a clear head.


rawValue Option

Hi,
is there an option like 'rawValue' on the component? If not it would be great!
Somehing that can show the mask on input but take from the variable prefix, sufix, etc.. let it with just the digits..

This is how the component works. The mask will be displayed in the input, but the model value will be a raw float or integer.
Perhaps I did not understand you issue. What are the version that you are working on? Can you give me a code example of what you are trying to accomplish?

I'm using v3.14.0, that's weird because my variables are being sent to backend like this img (exactly as it is displayed on the input)

I use money3 as component and with this config
config: {
        decimal: ",",
        thousands: ".",
        prefix: this.money ? "R$ " : "",
        suffix: "",
        precision: 2,
        masked: true
}

Maybe the problem is because I use money3 inside a component using the value with v-model, emitting an event to make two-way data binding still work ... as it says here in the documentation https://v3.vuejs.org/guide/component-basics.html#using-v-model-on-components
I'm not that experient with vue, so, it can be something dumb from mine too.. thanks in advance for the help!

Are you using the component or the directive? If you are using directive, there is a bug in this version. Please upgrade to 3.14.1

Are you using the component or the directive? If you are using directive, there is a bug in this version. Please upgrade to 3.14.1

I'm using the component, but anyway i'll upgrade.

sorry... 3.14.2

Oh, now I see... you should set masked to false

Yes, for my purpose I need to use masked: false.
I've figured out what is the problem here, as I'm using custom component with v-model and the event 'update:model-value' to propagate the value change, the mistake was the parameter being sent..
Look this:  @input="$emit('update:model-value', $event.target.value)"
I was sending the DOM input value (with prefix sufix etc..) and not the variable returned by the component money3..
Now I have another problem :| If i use as parameter the variable of v-model like @input="$emit('update:model-value', modelValue)" it sends a one step old value, see the imgs..

Could you please post the complete code of your component? Will be easier to help.

Yes, here it is https://codesandbox.io/s/eager-mendeleev-u430k?file=/src/components/HelloWorld.vue
I noticed that Vue complains about mutating the prop directly, but then I tried using a local data variable and emitting the change to the parent but the result was the same..

Nice! With an example like that it's much more easier to help. Take a look at my fork.
Inside the App.vue file I set the obj.value to 1. That can represent a value that came from the database.
data() {
  return {
    obj: {
      value: 1,
    },
  };
},

Inside the HelloWorld component a added two watchers a created hook and a model variable.
data() {
  return {
    model: 0,
  },
},
created() {
  this.model = this.modelValue;
},
watch: {
  modelValue(val) {
    this.model = val;
  },
  model(val) {
    this.$emit("update:modelValue", val);
  },
},

Remove the input event listener from the component and you are good to go.
<money3 v-bind="config" v-model="model" />

Hope it helps!

Man, thanks a lot!!


[Traefik Plugin Catalog] Plugin Analyzer has detected a problem.

The plugin was not imported into Traefik Plugin Catalog.
Cause:
failed to load readme: failed to get the readme file: GET https://api.github.com/repos/hwmland/traefik-testplugin/readme?ref=v0.0.1: 404 Not Found []

Traefik Plugin Analyzer will restart when you will close this issue.
If you believe there is a problem with the Analyzer or this issue is the result of a false positive, please contact us.

Added readme


[Bug Report] field组件的type=textarea时为何clear按钮不显示

Mint UI version
2.2.13
OS/Browsers version
任何
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/mmx38qxw/6837/
Steps to reproduce
textarea输入内容 clear图标不显示
What is Expected?
textarea输入内容 clear图标显示
What is actually happening?
不显示

现在没办法只能这样处理了下，我想知道官方为什么要在textarea时隐藏clear图标，是显示了会出现什么问题么

这个项目似乎没人维护了

It seems Eleme has abandoned this project. I emailed several committers but no one responded to me. So I decided to switch to some other library.


Update Hermes Instructions

Depends on https://github.com/microsoft/react-native-windows/pull/7101/files
This updates Hermes instructions for new build logic, changes headings between macOS and Windows to be consistent, and moves the macOS section below Windows, since Windows has more usage.

PR renaming props merged into 0.64-stable. This should be ready to merge.


Layout menu doesn't respect scaling

Godot version:
3.1 stable
OS/device including version:
Windows 10 64 bit
Issue description:
If a node has scaling other than 1 (say, 0.5) and you use Layout -> Center, it will place its top-left corner as if its scale was 1. You can see this since the node will be properly centered.

cc @groud

Duplicate of #19068

Indeed, closing as a duplicate


Autogenerated migration package violates windows naming system

The packaged autogenerated by the migration have the timestamp, for example : migrations/2021-02-11T23:54:02.230Z
This is fine for Linux and Mac users, but this don't work on windows machines, the colon is not an allowed character
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#file-and-directory-names
The following reserved characters:
< (less than)

(greater than)
: (colon)
" (double quote)
/ (forward slash)
\ (backslash)
| (vertical bar or pipe)
? (question mark)

(asterisk)

I have a project on git that I can not even checkout on a windows machine
$ git checkout feature/migrationLib
fatal: cannot create directory at 'fauna/migrations/2021-02-11T23:54:02.230Z': Invalid argument

I have pushed changed to the following package and tested it on windows (generate/apply/rollback)
https://www.npmjs.com/package/@fauna-databrecht/staging-fauna-schema-migrate
Which seems to work fine on cmd and cmder.

Confirmed it is working with CMD/Powershell and Gitbash in Windows 10 Enterprise x64 build 19042.746
Thanks for the fix


The URL /userinfo? looks like it's going to work but does not

When you use the url /launch?template=&email=required,  you are redirected to /userinfo? which prompts for an email address.
This is a very attractive link to copy and share, but reusing that link and submitting sends you to
/error?msg=TypeError:%20Cannot%20read%20property%20%27length%27%20of%20undefined
Can this error be captured up front?

Ignore. User Error.


_posts/0000-01-02-shamilSeraj.md

you have: created a branch, created a file and made a commit, and opened a pull request

hello

hello


Correct RU and UK

UK wordforms - if the wordform exactly matches the stem, empty element is generated in the MDX file.
RU wordform - two consecutive commas in the file
https://github.com/BorisNA/addflex/issues/3

UK: some lines had extra "\n" at the end - they should be removed. Redundant lines too (where there is just one form that exactly matches the stem).


Anonymise sensitive data

⚠ Check for existing issues before proceeding. ⚠

[x] I have searched the existing issues, and there is no existing issue for my problem

Where are you using SuperAGI?
MacOS
Which branch of SuperAGI are you using?
Main
Do you use OpenAI GPT-3.5 or GPT-4?
GPT-3.5
Which area covers your issue best?
Other
Describe your issue.
When adding Access tokens & sensitive data, I see that it does not get filtered. This is a small security issue.
Can you anonymize the data when it is saved and make sure this is stored safely?
As I can also see that you are deploying the web app, does this information get encrypted when sending/saving it?
How to replicate your Issue?
Connecting different services in SuperAGI
Upload Error Log Content
d

Thanks for raising this issue!
We encrypt and store OpenAI keys as of now. We recently shifted tool configuration keys to a different table and hence they are not being encrypted and stored. But it's a work in progress. It'll be done soon.

We have the fix ready for this and we are merging it to main in next release. It is already encrypted in the webapp.

Great! Always ready to help if needed. Thanks a lot for taking this into account.
Have a great day


Update flat file parameters, dictionary_close implementation, and .ino tests

These changes reflect recent flat file implementation updates.

LGTM

LGTM


[Bug]: "Can't access Redis. Please check the Redis' status."

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
liuman632
Other environment information
No response
Actual behavior
点击解析数据集报错"Can't access Redis. Please check the Redis' status."
Expected behavior
No response
Steps to reproduce
选择知识库-数据集，选择已经上传的文件，点击解析状态栏刷新或者启动图标，提示错误"Can't access Redis. Please check the Redis' status."

Additional information
for t in tsks:
assert REDIS_CONN.queue_product(SVR_QUEUE_NAME, message=t), "Can't access Redis. Please check the Redis' status."
assert的作用可以需要看一下

You can check to see if the redis service in docker is working properly

你这个问题解决了吗

请问有解决吗？同样的问题，检查了redis 是正常的

Please try latest v0.14.0


Speedup shadow plugins by ~100x

What does the code in this PR do / what does it improve?
Fix the processing time for the shadow plugins. This replaces the need  for saving them as computation is trivial
Can you briefly describe how it works?
In https://github.com/XENONnT/straxen/pull/753, the function strax.split_by_touching_windows  was used with an extreme window of 3e9 ns. This was passed on to a numba function. The result is that you are passing for each peak in the dataset a list of all peak within 3e9 ns which is really tough for your memory management, especially since we are also passing all the peaks as an argument as well.
Rather than passing all those peaks and lists of peaks, keep track of what peaks you need to have using the raw output of touching windows.
Can you give a minimal working example (or illustrate with a figure)?
The effect of this is a speed increase of ~100 x for run 033341

Are the actual changes in https://github.com/XENONnT/straxen/pull/806/commits/b705e3c275c0a223c502357d16668fa78d4653a1 ? Since you copied things it is hard to tell.

Are the actual changes in b705e3c ? Since you copied things it is hard to tell.

yeah the changes are mostly in there. It's also explained in the PR description

I have tested the plugins and they give the same results as the ones in master give.

I think with two approvals, we can merge this :)


Added My Repo for Web3 Project Submission

PLEASE CHECK issue no. #580

Thankyou @AKSHITHA-CHILUKA


added UNSAFE_ to remove warning

To remove this warning i need to change componentWillReceiveProps to UNSAFE_componentWillReceiveProps
react_devtools_backend.js:2430 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

Move data fetching code or side effects to componentDidUpdate.
If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state
Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: EnlargedImage

Coverage decreased (-5.8%) to 94.15% when pulling 0d8a00f97d267d09011fe6c5724bf17cdcfc25d7 on siyahulhaq-ceymox:master into ff834d0667f437c9d0affcd0208c2b5ce09e92ac on ethanselzer:master.


feat: run ASH image using non-root user

Issue #, if available: 78
Description of changes:
Updated Dockerfile to add a user and set that user as part of the container image build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We definitely want to "squash and merge" this one - there are a bunch of intermediate commits that are of no value after this is accepted.


[NETBEANS-54] Module Review maven.indexer

binaries-list updated to use maven coords where possible

Need solution for apache maven indexer-core SNAPSHOT - suggestion
below

no notices required - already apache licensed except for
javax.annotation-api which is presumably ok (has embedded cddl
license)
file NOTICE-patched-indexer-core-6.0.0 and mvn-indexer.patch not
licensed pending solution above.

Anything more needs to be done here?

Yes. Not sure what to do about the binary  org.apache.maven.indexer:maven-indexer:6.0-SNAPSHOT
My comment from earlier:
"Regarding org.apache.maven.indexer:maven-indexer:6.0-SNAPSHOT, I suggest we clone that into apache/netbeans owned git, apply the patch, change the maven coordinates to make it netbeans owned and deploy back to maven central.”
Not sure how you want to approach that.

On 23 Oct 2017, at 8:54 am, Geertjan Wielenga<EMAIL_ADDRESS>wrote:
Anything more needs to be done here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338512219, or mute the thread https://github.com/notifications/unsubscribe-auth/AXKC2H-yJ6WSuj7DoBsovuvDLFm3mj6yks5su7mZgaJpZM4P-f2H.

I think I'd leave them unchanged for the moment, i.e., we do not have to get everything from Maven, right now this minute. Do as much as you can in terms of the other JARs, i.e., the Lucene JARs, and let's handle that patch as a separate issue.

No worries Geertjan. Everything else is done.  I'll log an issue regarding the patch and update the APIReview doc , but you can merge this one in I think...

actually on second thoughts I should add a copyright notice to the patch, so hold off merging.

OK, I've pushed a squashed version with

copyright notice in the patch
exclusion for NOTICE-patched-indexer-core-6.0.0" (no degree of creativity)

Good to go now.

I've sorted rat excludes. (This PR already had the conflicting file(nbbuild/build.xml))

Should this be merged or closed?

I didn't realise I could resolve conflicts from GitHub.  I've done that now, but that's made a mess after the alphabetisation.  So hold up a bit and I'll sort it out.

OK, all sorted, but I haven't squashed the merge masters.  I'm not that familiar with git/squashing - is it safe to squash the merge commits?  Just a regular squash?

In all my GitHub projects I can configure how PR are handled. From allowing all types (merge, squash, etc.) to selecting one or some of them.
If squashing is the preferred way it should be probably the only option. Usually the person(s) configured to merge to trunk can choose which one.

Thanks Javier,
I didn’t know about that.  Is this something committers do? Or something I was meant to do as a contributor?
I mis-spoke in my prior comment, what I was concerned about was squashing a conflict merge, i.e. the additional commits are to do with sorting out the conflict with base (I don’t know why GitHub made me do 2 commits.  I read somewhere git can get confused with how it tracks conflicts if you mess around with squashing.
Is there something else I can do to finish this as a contributor?
Cheers
Ross

On 27 Oct 2017, at 5:40 am, Javier A. Ortiz Bultron<EMAIL_ADDRESS>wrote:
In all my GitHub projects I can configure how PR are handled. From allowing all types (merge, squash, etc.) to selecting one or some of them.
If squashing is the preferred way it should be probably the only option. Usually the person(s) configured to merge to trunk can choose which one.
https://user-images.githubusercontent.com/2817343/32070839-27439ce8-ba53-11e7-8b4b-0b97e2136695.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/incubator-netbeans/pull/163#issuecomment-339760312, or mute the thread https://github.com/notifications/unsubscribe-auth/AXKC2P8DbNMsAXydNECz8VBYZqJkHB1-ks5swNISgaJpZM4P-f2H.

@rosslamont this is done by the repository admins. What I meant is that if the admins want it merged, squashed or rebased that can be done with one click most of the time. That's the beauty of GitHub.
It can be configured to only have one option on that dropdown for the users with write access or all.

OK, not sure what is holding this back, but I've done all I can here. Ready to merge

Probably, rebase is preferred than merge when a PR is provided.
I may be wrong but...

Just in case, save your changes e.g. https://patch-diff.githubusercontent.com/raw/apache/incubator-netbeans/pull/163.diff
git remote add upstream https://github.com/apache/incubator-netbeans
git checkout master
git pull upstream master
git push origin master
git checkout maven_indexer
git reset --hard [commit id] (reset your merges)
git rebase master maven_indexer (if there are conflicts, fix them, then, add them, rebase --continue)
git push origin maven_indexer (probably, need -f option to overwrite. i.e. git push -f origin maven_indexer)

Anyone, Are these OK?

Merged - thank you.


Auto-type keystrokes setting ignored

I hope this is not duplicate or there is information about that somewhere...
Keeweb Connect extension don't follow the keystrokes setting (eg. {USERNAME}{TAB}...) stored in the entry, when "submit the form automatically"...instead old auto-type system (ctrl+alt+t) works like expected.
Thanks!

Hi! KeeWeb-Connect will not follow auto-type settings, extension just types as it is. Entering fields using the extension is an alternative to auto-typing.


Error loading module lcurl on Lubuntu 18.04 with version 0.3.8-1

/usr/bin/lua: error loading module 'lcurl' from file '/usr/local/lib/lua/5.2/lcurl.so':
/usr/local/lib/lua/5.2/lcurl.so: undefined symbol: lcurl_mime_set_lua
stack traceback:
[C]: in ?
[C]: in function 'require'
/usr/local/share/lua/5.2/cURL.lua:11: in main chunk
[C]: in function 'require'
64 bit system

Tthere was bug in this rockspec
Try use.3.8-2.
Wre do you get 0.3.8-1 version
I remove it after few days after release

Installed it shortly after 18.04 came out but didn't use it until today.
Thanks
Sent from my Android phone with GMX Mail. Please excuse my brevity.On 2018-06-21, 22:49 Alexey Melnichuk<EMAIL_ADDRESS>wrote:
Tthere was bug in this rockspec
Try use.3.8-2.
Wre do you get 0.3.8-1 version
I remove it after few days after release
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/Lua-cURL/Lua-cURLv3/issues/129#issuecomment-399238913","url":"https://github.com/Lua-cURL/Lua-cURLv3/issues/129#issuecomment-399238913","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Lua-cURL/Lua-cURLv3","title":"Lua-cURL/Lua-cURLv3","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Lua-cURL/Lua-cURLv3"}},"updates":{"snippets":[{"icon":"PERSON","message":"@moteus in #129: Tthere was bug in this rockspec\r\nTry use.3.8-2.\r\nWre do you get 0.3.8-1 version\r\nI remove it after few days after release "}],"action":{"name":"View Issue","url":"https://github.com/Lua-cURL/Lua-cURLv3/issues/129#issuecomment-399238913"}}}
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [Lua-cURL/Lua-cURLv3] Error loading module lcurl on Lubuntu 18.04 with version 0.3.8-1 (#129)",
"sections": [
{
"text": "",
"activityTitle": "Alexey Melnichuk",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@moteus",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "IssueComment",\n"repositoryFullName": "Lua-cURL/Lua-cURLv3",\n"issueId": 129,\n"IssueComment": "{{IssueComment.value}}"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "IssueClose",\n"repositoryFullName": "Lua-cURL/Lua-cURLv3",\n"issueId": 129\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/Lua-cURL/Lua-cURLv3/issues/129#issuecomment-399238913"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n"commandName": "MuteNotification",\n"threadId": 348724281\n}"
}
],
"themeColor": "26292E"
}


[SOLVED]: Cannot get contract. CATCH ERROR: NOK: Transaction not found with hash

UPDATE: Problem resolved overnight. Contract now deployed and getting all info, but it took over 6 hours. Likely was an issue with Rinkeby testnet or servers at NFTPort?
Version

[X] Yes

General Question

[X] No

What happened?
Working from latest 2.0.0 repo, following instructions as is as per "How To Create An ENTIRE NFT Collection (10,000+) & MINT With ZERO Coding Knowledge - v2.0.0"
Everything going will up to
$ npm run deploy_contract
I even see a Contract subfolder has been created in the Build folder.
But getting error msg with: $ npm run get_contract
Getting error msg CATCH ERROR: NOK: Transaction not found. Log below.
PLEASE HELP. I see other users, inc. #114 and #110 have the same issue. Thanks!
What have you tried?
I Googled and asked the community in the discord server but could not find a solution.
Relevant log output
Retrying
CATCH ERROR: NOK: Transaction not found with hash

CATCH ERROR: ERROR STATUS: 502

Protect your information

[X] I Agree

@ZnXCreators what was the solution to the transaction hash not being found.

Okay so essentially it means the NFT Port server is down and you just have to message the NFT port discord about it

I get the same error.  I was successfully able to get a contract on Rinkeby.  But not yet on Polygon.  The solution is to post on NFTPort's Discord server?

@cmapez Where did you find the NFT port discord?


if (window.admob) - not working

miqmago,
You recommended some code in a recent thread you closed (you said I could reopen it, but I don't see how), and it used the "if (window.admob)" statement, but that seemed to stop it from working. Where do you establish window.admob?
And using the code you gave me, the interstitials keep coming back immediately after you x them out.
Also, you didn't answer the question about new banner ads, which I asked because I don't know what the default behavior is: Do the banner ads change on their own, or will the same ad stay there unless it's destroyed? Also, if it must be done manually in the code, is it a good idea to change the ad? It seems like it would be, as people may not respond to one ad, but they might respond to another.
The same goes for the interstitials: do they change automatically, and if not, would it be a good idea to force them to, and if so, how do you do that?
I appreciate your help.

Reopen the issue with the gray button at left side of the green one "Comment" (normally should be there).
Second and third questions responded in old thread https://github.com/appfeel/admob-google-cordova/issues/63#issuecomment-258701763.
Please show your complete code (index.html and javascript files). Paste the code for each file, select it one by one and press the button in the comment bar <> which makes whole selected text to appear as code (or wrap each part of code with three ticks at the beginning and at the end in a new line). After the three ticks you can place 'html' for html files or 'js' for javascript files.
window.admob is automatically defined by cordova when the plugin is added. Normally it should work in emulator and real devices (it does not work in browser due to cordova obvious limitations).

I use PhoneGap Build, so admob is installed via the config file. I was testing in the android (v5) device, not in a browser.
Here's the relevant part of the index.html file (in the head section I use  to call the admob file, shown below). Notice the script at the bottom of this index file, that's how I'm bringing in the banner ad. I'm bringing in the interstitial on another page, after destroying the banner, shown below:
`

Humor Times: The News in Cartoons

presents

The News in Cartoons!

Review the news the fun way! And now that you've found your comic relief, don't keep it all to yourself -- share The News in Cartoons with everyone you know!

The News in Cartoons

Recent "News in Cartoons"

Premium Version Info

Humor Times website

HT magazine subscriptions

About

	<button onclick="window.plugins.socialsharing.share('Check out the Humor Times News in Cartoons app -- the fun way to review the news!', 'Humor Times News in Cartoons app', 'http://www.humortimes.com/wp-content/uploads/images1/HT-Sunrise-NewsCartoon-300w.jpg', 'http://www.humortimes.com/more/about-humor-times/')" class="ui-btn-left" data-icon="arrow-r" data-theme="b">Share the fun!</button>
    <button name="buttonClick" class="ui-btn-right" onclick="exitFromApp()">Exit</button>

`
Here's the admob-prepare.js, with my Publisher Id removed:
`var isAppForeground = true;
var isInterstitialAvailable = false;
function onAdLoaded(e) {
if (isAppForeground) {
if (e.adType === admob.AD_TYPE.INTERSTITIAL) {
isInterstitialAvailable = true;
}
}
}
function onAdClosed(e) {
if (e.adType === admob.AD_TYPE.INTERSTITIAL) {
isInterstitialAvailable = false;
admob.requestInterstitialAd();
}
}
function onPause() {
if (isAppForeground) {
admob.destroyBannerView();
isAppForeground = false;
}
}
function onResume() {
if (!isAppForeground) {
setTimeout(admob.createBannerView, 1);
setTimeout(admob.requestInterstitialAd, 1);
isAppForeground = true;
}
}
// optional, in case respond to events
function registerAdEvents() {
document.addEventListener(admob.events.onAdLoaded, onAdLoaded);
document.addEventListener(admob.events.onAdClosed, onAdClosed);
document.addEventListener('pause', onPause, false);
document.addEventListener('resume', onResume, false);

}
function initAds() {
var adPublisherIds = {
ios: {
banner: 'ca-app-pub-XXXXXXXXXXXXXXXX/BBBBBBBBBB',
interstitial: 'ca-app-pub-XXXXXXXXXXXXXXXX/IIIIIIIIII',
},
android : {
banner: 'ca-app-pub-XXXXXXXXXXXXXXXX/BBBBBBBBBB',
interstitial: 'ca-app-pub-XXXXXXXXXXXXXXXX/IIIIIIIIII',
}
};
var admobid = (/(android)/i.test(navigator.userAgent)) ? adPublisherIds.android : adPublisherIds.ios;

admob.setOptions({
    publisherId: admobid.banner,
    interstitialAdId: admobid.interstitial,
    tappxIdiOS: '/XXXXXXXXX/Pub-XXXX-iOS-IIII',
    tappxIdAndroid: '/XXXXXXXXX/Pub-XXXX-Android-AAAA',
    tappxShare: 0.5,
    adSize:               admob.AD_SIZE.SMART_BANNER,
    bannerAtTop:          false,
    overlap:              false,
    offsetStatusBar:      false,
    isTesting:            true,
    autoShowBanner:       false,
    autoShowInterstitial: false
});

registerAdEvents();

}
function onDeviceReady() {
document.removeEventListener('deviceready', onDeviceReady, false);
initAds();
// get banner ready at startup
admob.createBannerView();
// request an interstitial at the beginning, it will take some time to be available
admob.requestInterstitialAd();
}
document.addEventListener('deviceready', onDeviceReady, false);`
The page where I show the interstitial has this bit of script:
 function onAdLoaded(e) {     admob.destroyBannerView();     if (window.admob) {         if (isInterstitialAvailable) {             admob.showInterstitialAd();         } else {             console.log('No interstitial available at this moment :(');             admob.requestInterstitialAd();         }     }   }

If you are using PGB, then in your config.xml should be present this tag:

<gap:plugin name="phonegap-admob" source="npm"/>

The admob events (onAdLoaded, onAdClosed etc.) they are both called for banners and interstitials. In the e parameter you'll see if it is a banner or interstitial and you need to filter each type. Learn more about events here: https://github.com/appfeel/admob-google-cordova/wiki/Events. Moreover, if the event is called you don't need to filter if window.admob is present (it will be as it is the source of the event):

function onAdLoaded(e) {
   if (e.adType === admob.AD_TYPE.BANNER) {
       admob.showBannerAd();
   }
}

I would remove this bit of code and make autoShowBanner: true. Then you can simply call admob.createBannerView() and admob.destroyBannerView() as many times as you need and forget to manage if banner ad is loaded. onLoaded events for banners are raised each time a new banner is loaded, so it means that if you have a refresh of 30s, the event will be called every 30s (very unperformant ad this is not the behavior you need).

I would not destroy banner ads when you show interstitials, so when the interstitial is gone, the banner ads will still be there (but this is up to you), and again, you need to filter onAdLoaded by the adType and remove window.admob:

function onAdLoaded(e) {
    if (e.adType === admob.AD_TYPE.INTERSTITIAL) {
        if (isInterstitialAvailable) {
            admob.showInterstitialAd();
        } else {
            console.log('No interstitial available at this moment :(');
            admob.requestInterstitialAd();
        }
    }
  }

Finally, in your onDeviceReady I'd check if admob is present, just to ensure that the app is not crashing if it is not:

function onDeviceReady() {
    document.removeEventListener('deviceready', onDeviceReady, false);
    if (window.admob) {
        initAds();
        // ---get banner ready at startup---
        // If you make autoShowBanner: true, this will start showing banners automatically.
        // So when autoShowBanner: true, ensure to make this call when you need to show banners
        admob.createBannerView();
        // request an interstitial at the beginning, it will take some time to be available
        admob.requestInterstitialAd();
    }
}

Please reopen if suggestions does not work


How to request access token using enterprise SSO

Hi
My company is using enterprise SSO with pin and token to login to the azure stack tenant portal. How to request access token this way? I'm aware of using service principal to access it. However, tenant will still need to give the permission to the service principal first. Is there any other way? Thank you

Thanks for your question. Please provide us with the link to the documentation you are referring to so we can better assist.

Hi Karishma,
here is the doc if you want to request access token to azure stack api using AAD account
https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-rest-api-use?view=azs-1908
here is the doc if you want to request access token to azure stack api using service principal
https://blogs.msdn.microsoft.com/wushuai/2018/10/02/how-to-call-azure-stack-api-via-client-credential-grant/
what's missing is (if possible) how to request access token to azure stack api using enterprise SSO

Thanks for sharing the documents. I have updated the issue with doc details.
Our team is currently investigating and will update you shortly.

@jfnu If you are doing an AAD installation, you should be able to use a typical AAD Auth flow to get the token for API access. Here is AAD documentation describing the process.
If this is about a full Azure Stack multi-node installation and not the ASDK, your best bet is to create a support request if you need further assistance.

Hi Travis,
That's not the ask though. The documentation seems to be missing "How-To" on getting access token on azure stack API via Enterprise SSO. If it's not possible, that's fine. I wanted to know if there's a way and if  it's not, what would be the recommendation.
Thank you


Using locale in helper

Hey, first of all thank you for this addon! It's very convenient and useful.
Unfortunately, I'm stumbled upon the issue with the next code:
{{dayjs-from-now @comment.posted locale='ru'}}
I do have this locale in a ember-cli-build.js:
    'ember-dayjs': {
      locales: ['ru'],
      plugins: ['utc', 'relativeTime'],
    }

However the string appears in English. How can I change to other locale?
P.S. I've tried to call 'setLocale' in ApplicationController - didn't have any effect.

Hey @YaroslavPoliakov You just need set locale via dayjs service setLocale method like here. You can check the dummy app in the addon.

I've tried to set in a ApplicationController constructor - no effect. It's called and returns no errors. However the helper is still in English.
export default class ApplicationController extends Controller {
  @service dayjs;

  constructor(owner, args) {
    super(owner, args);
    this.dayjs.setLocale('ru');
  }

I've tried to set in a ApplicationController constructor - no effect. It's called and returns no errors. However the helper is still in English.
export default class ApplicationController extends Controller {
  @service dayjs;

  constructor(owner, args) {
    super(owner, args);
    this.dayjs.setLocale('ru');
  }

UPD: Looks like I luckily bumped into one helper that doesn't work properly 😅 . I've checked the ones from a dummy app, and indeed they work as intended.

Yeap. Not all helpers works with multiple locales. Maybe I should to add to doc which helpers works. Thanks for the heads up @YaroslavPoliakov

So I've ended up with changing from
{{dayjs-from-now @comment.posted locale='ru'}}
to
{{dayjs-to (now) @comment.posted}}
and also adding a setLocale('ru') call because it looks like the locale parameter doesn't work with this helper. And it did a trick :) Thank you for your help!


Feat tile gallery

Summary

The first drop of new component TileGallery

Change List (commits, features, bugs, etc)
New components

TileGallerySearch
TileGalleryViiewSwitcher
TileGalleryItem
TileGallerySection
TileGallery
StatefulTileGallery

#705
Internal issue 70

Please add a link to the issue this PR closes. Additionally, please link to the internal pal-tracking issue

@cgirani What is a TileGallery and how is different than a Dashboard?  It is another kind of dashboard?  Does it use the dashboard? Is there a PAL design for this?  Sorry for all the questions, but, this looks like a dashboard layout component.  I wish stories had some information about a the component and its intended use.
I see that 'href' is used on a tile and there is a moreInfo link.  should that be the only way to interface with this.   It would be nice to have these be event driven so that I can pop up a modal, or do some other action other than taking me to a new url.
Not sure what's being tested for at this level... but there accessibility issues, RTL issues, and the none of this is responsive (it appears to scale the screen as I resize so on a mobile device it's not usable)

:tada: This PR is included in version 2.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Onboarding and Login View

Onboarding and login view implementation

found some minor overlaps on UI for devices with smaller screens like SE but will fix it on later commit


Add image tag dropdown for publish to docker in ADS

This adds the ability to select the image tag used when publishing a sql project to docker in ADS. This is already an option in the vscode extension. The value in adding this is that users can have the option of publishing their project to a 2019 container, rather than forcing them to use the latest, which is currently 2022.
The image tags can be filtered and the image tag options are updated when the base docker image is changed:
https://user-images.githubusercontent.com/31145923/198695504-a454fbec-2d79-47e6-98dc-df682e4ec344.mp4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 27 (77.78%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 42.001%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
14
20
70.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
28910

Relevant Lines:
63954

💛  - Coveralls


Crash when using imgui

There is a situation when crash occurs when using bgfx's imgui version:

Using non-crt allocator, the allocator destroys on program shutdown
Call imguiCreate on program init
shutdown the program and call imguiDestroy
Destroy the allocator
Crash

I guess the problem is with statically defined variable inside imgui.cpp :
static ImFontAtlas      GImDefaultFontAtlas;

Which allocates some heap inside during the initialization and never releases until the end of program (which dynamic allocator is missing at that point)
As I workaround I added this line to ocornut-imgui/imgui.cpp :
void ImGui::Shutdown()
{
    ImGuiState& g = *GImGui;
    GImDefaultFontAtlas.Clear();

You should report that here: https://github.com/ocornut/imgui/issues (cc @ocornut)


HBASE-26790 getAllRegionLocations can cache locations with null hostname

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 17s
master passed

+1 :green_heart:
compile
2m 48s
master passed

+1 :green_heart:
checkstyle
0m 40s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s
the patch passed

+1 :green_heart:
compile
2m 47s
the patch passed

+1 :green_heart:
javac
2m 47s
the patch passed

+1 :green_heart:
checkstyle
0m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

34m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4565/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4565

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 903223b9684c 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
69 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4565/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
4m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

+1 :green_heart:
unit
217m 56s
hbase-server in the patch passed.

241m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4565/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4565

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f554d4596016 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4565/1/testReport/

Max. process+thread count
2692 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4565/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test failure is a timeout in TestFuzzyRowFilterEndToEnd, unrelated. Merging.
Thanks for the review Andrew


Add String's ToLowerInvariant() and ToUpperInvariant() methods

I would like to use the methods ToLowerInvariant() or ToUpperInvariant() to normalize string property values to ensure that the normalized values are the same independent of the local culture settings.
My use case is that I need to insert objects into a database that is case sensitive, but the case makes no difference to the user. So I would like to normalize string values before inserting them to lower case.
If I understood it correctly, Bridge only supports culture invariant methods of ToLower() and ToUpper()  anyway because specifying the culture is not possible in JavaScript. So could you additionally provide the methods ToLowerInvariant() or ToUpperInvariant() that simply call the methods ToLower() and ToUpper()? This would allow me to use ToLowerInvariant() in my C# code. Otherwise I would have to use ToLower() in C# which means that the normalization depends on the local culture settings.
Steps To Reproduce
A minimal example with the C# code that I would like to use:
https://deck.net/372d0bcbaf5fa5be6ba0577efbcd3f0d
public class Person
{
    public string FirstName
    {
        get
        {
            return _firstName;
        }
        set
        {
            _firstName = value.ToLowerInvariant();
        }
    }
    private string _firstName;
}

Expected Result
Bridge.assembly("Demo", function ($asm, globals) {
    "use strict";

    Bridge.define("Demo.Person", {
        fields: {
            _firstName: null
        },
        props: {
            FirstName: {
                get: function () {
                    return this._firstName;
                },
                set: function (value) {
                    this._firstName = value.toLowerCase();
                }
            }
        }
    });
});

Actual Result
I get a compile error because the String class has no method ToLowerInvariant.

@FlorianHockmann, as a workaround, you can make an extension method in your Bridge project as shown here.
public static class Extensions
{
    public static string ToLowerInvariant (this string value) => value.ToLower();
}

public class Tests
{
    static void Main ()
    {
        Console.WriteLine("M".ToLowerInvariant());
    }
}

Thanks @michaelcheers, that is really a good workaround! I haven't thought about adding extensions methods only to my Bridge project.
However I still think that the better solution would be if Bridge would support those two methods directly so that no workarounds would be necessary. Therefore I leave this issue open. But feel free to close it if you think otherwise,


npm install giving error

when i installing using command
npm install --save react-native-timer-countdown
giving below errors:
npm ERR! code ENOVERSIONS
npm ERR! No valid versions available for react-native-timer-countdown
npm ERR!      /Users/Apple/.npm/_logs/2019-12-17T11_46_08_934Z-debug.log

Yarn too.
yarn add v1.17.3
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/react-native-timer-countdown/-/react-native-timer-countdown-5.0.1.tgz: Request failed \"404 Not Found\"".

I am also getting same error @reactdevrocks.

Same here

A temporary fix is to use the content of index.js directly in the RN project

@ceaucari is there a chance that you add a valid package.json file? I deleted my node_modules for the first time in quite a while and now this is broken.

+1


Winget package not updating after build

I've just pushed the updated 1.3.2 release, and was checking it had arrived on the various platforms, and noticed winget is still sitting on 1.2.0.
This means the two releases I've pushed haven't gone to winget.
We need to get the winget updates happening as part of the build, or add some docco explaining the release procedure so I know what to do 😄

It appears winget manifests are in the installers/winget/grate/manifests/e/erikbra/grate directory.
In order to submit to the winget package repo, you should only need to do a couple steps.

Ensure winget is installed on your machine.
install wingetcreate is installed.
update the manifest with the new version by running the Create-Installer.ps1 script: installers/winget/Create-Installer.ps1

When running that powershell script, you need to pass the new version. In a powershell window... ./grate-version.ps1 1.3.1

I'm on a MacOS environment, so I can't test the creation of this new release for winget, but from Microsoft's documentation, and looking at the source, this is what I could piece together.
Also, see: https://github.com/erikbra/grate/issues/77 for additional information.

We should be able to do this as part of the release pipeline now: https://github.com/microsoft/winget-create#using-windows-package-manager-manifest-creator-in-a-cicd-pipeline
We need a separate build step, which runs on a Windows agent, and does what's described in the link above

Resolved with #231
grate 1.4.0 is on its way out to winget: https://github.com/microsoft/winget-pkgs/pull/77881


istio/istio#1160 breaks cluster-wide

see my comments.
In addition, this PR was forced merged without passing e2e smoke test, please fix it.

Qualify what you mean by "breaks cluster-wide".
The smoketest passed separately. It was a coordinated PR change which is always tricky.


useFollowCam should optionalEl.addEventListener instead of always using document

Thanks for the great library!
When I run two Three.js scenes on the same page,
your <Ecctrl> reacts to events coming from the other scene.
This happens because you document.addEventListener in useFollowCam.tsx.
Could we optionally provide an alternative root element?

I think you could just disable the followCam: <Ecctrl disableFollowCam >

I think you could just disable the followCam: <Ecctrl disableFollowCam >

Sure that works, and since I intend to refactor your code to create my own controller this is not a real problem for me.
But if someone wants to use your library unmodified without writing their own camera, it would be nice to have the option.
Happy to make a PR, and even add some types.

Imo, disableFollowCam should be enough as an option. But if you have any better thoughts or ideas, you are more than welcome to share 👍


[misc] [doc] [frontend] LLM torch profiler support

follow up to #7451
cc @comaniac @DamonFool
thanks for the tips from @sfc-gh-mkeralapura

/ready

not sure if it's appropriate to ask this here, just in case if there is any help: when I tried to run examples/offline_inference_with_profiler.py, occuring the following error RuntimeError: !stack.empty() INTERNAL ASSERT FAILED at "../torch/csrc/autograd/profiler_python.cpp":969, please report a bug to PyTorch. Python replay stack is empty, the only change I do to the code is changing the facebook/opt-125m model to my local model Llama-2-7b-hf

The output of `python collect_env.py`
Collecting environment information...

Processed prompts: 100%|██████████████████████████████████████████████| 4/4 [00:00<00:00,  6.80it/s, est. speed input: 45.93 toks/s, output: 108.88 toks/s]
[rank0]: Traceback (most recent call last):
[rank0]:   File "/root/vllm/examples/offline_inference_with_profiler_local_model.py", line 27, in <module>
[rank0]:     llm.stop_profile()
[rank0]:   File "/root/vllm/vllm/entrypoints/llm.py", line 577, in stop_profile
[rank0]:     self.llm_engine.stop_profile()
[rank0]:   File "/root/vllm/vllm/engine/llm_engine.py", line 1612, in stop_profile
[rank0]:     self.model_executor.stop_profile()
[rank0]:   File "/root/vllm/vllm/executor/gpu_executor.py", line 176, in stop_profile
[rank0]:     self.driver_worker.stop_profile()
[rank0]:   File "/root/vllm/vllm/worker/worker.py", line 145, in stop_profile
[rank0]:     self.profiler.stop()
[rank0]:   File "/root/miniconda3/lib/python3.12/site-packages/torch/profiler/profiler.py", line 722, in stop
[rank0]:     self._transit_action(self.current_action, None)
[rank0]:   File "/root/miniconda3/lib/python3.12/site-packages/torch/profiler/profiler.py", line 751, in _transit_action
[rank0]:     action()
[rank0]:   File "/root/miniconda3/lib/python3.12/site-packages/torch/profiler/profiler.py", line 206, in stop_trace
[rank0]:     self.profiler.__exit__(None, None, None)
[rank0]:   File "/root/miniconda3/lib/python3.12/site-packages/torch/autograd/profiler.py", line 352, in __exit__
[rank0]:     self.kineto_results = _disable_profiler()
[rank0]:                           ^^^^^^^^^^^^^^^^^^^
[rank0]: RuntimeError: !stack.empty() INTERNAL ASSERT FAILED at "../torch/csrc/autograd/profiler_python.cpp":969, please report a bug to PyTorch. Python replay stack is empty.

my code
import os

from vllm import LLM, SamplingParams

# enable torch profiler, can also be set on cmd line
os.environ["VLLM_TORCH_PROFILER_DIR"] = "./vllm_profile"

# Sample prompts.
prompts = [
    "Hello, my name is",
    "The president of the United States is",
    "The capital of France is",
    "The future of AI is",
]
# Create a sampling params object.
sampling_params = SamplingParams(temperature=0.8, top_p=0.95)

# Create an LLM.
llm = LLM(model="/root/Llama-2-7b-hf", tensor_parallel_size=1)

llm.start_profile()

# Generate texts from the prompts. The output is a list of RequestOutput objects
# that contain the prompt, generated text, and other information.
outputs = llm.generate(prompts, sampling_params)

llm.stop_profile()

# Print the outputs.
for output in outputs:
    prompt = output.prompt
    generated_text = output.outputs[0].text
    print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}")

Besides, do you think if it's a good idea to create a specific configuration for profiling? In my use case, I care about memory usage too, so I add profile_memory=True option when initializing the profiler like this:

However, since PyTorch Profiler offers many more options, I’m considering whether it would be beneficial to abstract this into a ProfileConfig. This way, vllm users could easily and flexibly customize their profiling according to different needs. cc @SolitaryThinker @comaniac @DamonFool

Feel free to open an issue for bug report and discussions like this.

Feel free to open an issue for bug report and discussions like this.

got it, will do, thank you!


Fix deprecated Redis defaults

With the current defaults I get the following warning from Redis on connect:
node_redis: WARNING: You activated the retry_strategy and max_attempts at the same time. This is not possible and max_attempts will be ignored.

Perhaps there is someone using the old redis driver version... let's wait a bit before removing it, or is it important for you to remove that warning?

I get quite a lot of these which probably means that I'm reconnecting quite often. Do you know if that is supposed to be happening?

It depends on your server, but I don't think this should happen quite often.
Il giorno 15-set-2016, alle ore 18:17, Ville V??n?nen <notifications<EMAIL_ADDRESS>ha scritto:
I get quite a lot of these which probably means that I'm reconnecting quite often. Do you know if that is supposed to be happening?

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/adrai/node-eventstore/pull/82#issuecomment-247378049, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABCS8jpiXctsYdbLip3-UYNperumQv_Tks5qqXE1gaJpZM4J9Fvp.

So it turns out I had a bug in my code causing reconnects which made the deprecation warnings much more prominent. Getting the warning just once is quite ok.


Method close() missing on KV Store

Spin: 2.0.1
py2wasm: 0.3.2
According to the docs, each KV store impl should have a close() method that takes zero args. This appears to be missing in the Python SDK.
Handler returned an error: AttributeError: 'builtins.Store' object has no attribute 'close'

See https://developer.fermyon.com/spin/v2/kv-store-api-guide

The Python SDK doesn't expose a close function.  It automatically closes all stores at the end of the request; there's no way to close them early.

Okay... so it's a docs problem? I'm not really sure what to do when we document a set of functions for all languages, but not all languages need them. Part of me wants to say "we should just stub out a no-op function" and part of me wants to just change the docs and say "the following SDKs auto-close: Python, ..."

I've changed the docs.  Longer term we should think about how we document the raw interface vs the SDK wrappers.  Perhaps we should be showing the WIT more as a "if you are using this raw because reasons" rather than using it as the base docs from which the languages deviate in their own idiomatic ways.
I would not like to see a no-op close function.  If we did surface a close function then it should jolly well close something.

Arguably the idiomatic thing (and the way I'm planning to handle resource lifetimes in componentize-py) is to make Store a context manager so it can be used in with statements.  I don't think there's an urgent need in this particular case, though.

Context managers have been added to componentize-py now and required documentation changes about close has been done.


btcutil.NewAmount can overflow

Multiplying the float64 input by 1e8 can result in the value overflowing the maximum value representable by an int64, causing truncation during the type conversion.  This needs to be detected and an error should be returned.

Considering closing this, and instead changing the API so that it validates that the floating point value does not exceed [-21e14, 21e14].
While the overflow checks could be done (I've already determined the min/max constants), it is still dangerous to use floating point values this large or small because the next largest/smallest floating point values might result in a 2 satoshi difference.  Inherit to floating points are losses of precision, and it would be improper to convert values such as these to an atomic Amount, even if it doesn't over/underflow the int64 data type.
If this change is made, I think it would be beneficial to introduce a new API which can convert string representations of floating point values to Amount, instead of lossy floats.

Totally in agreement with the new API to handle floats. I think the string representation should be 0-padded to ensure the mantissa is 8-decimals, then then pop off the decimal as cast with Atoi.


proposal: become a more pro extension

Would it be nice if we add more functions into this extension? Just like this:
https://addons.mozilla.org/en-US/firefox/addon/textmarkerpro/
If this is acceptable, I will do some contribution to this project.

hi @ylc395
Thank for your suggestion. I never used textmarkerpro before. Do you mean to add a feature to highlight and capture text on a web site and store in Joplin? If yes, I think it is a bit over kill for this extension. I would like to improve the text editor but I don't want to ask for more permission from user as MemoInjo is not a web clipper.


lightline.vim: Could not load colorscheme highlight.

Hi, Ian. Thanks for you very cool theme. But my plugin lightline.vim not visible theme highlight.

OS: masOS Ventura 13.2
Terminal: iTerm2
Vim version: 9.0.981
Install: PlugInstall

my-install-plugins
error
plugin lightline

Hi! That's because lightline colorschemes are not the same as Vim colorschemes -- a lightline colorscheme is essentially a variable with contents that lightline understands: https://github.com/itchyny/lightline.vim/blob/b1e91b41f5028d65fa3d31a425ff21591d5d957f/autoload/lightline.vim#L193-L195
This is in line with its README: lightline colorschemes are different from editor colorschemes: https://github.com/itchyny/lightline.vim#colorscheme-configuration
I don't use lightline (I configure my own statusline). I'll likely take a look into it, but know that I have less motivation to add support for it (so no guarantees), and I wouldn't be able to dogfood it anyhow. PRs welcome in this department!

Hi! Thanks for you answer. Good luck.


Weird issue where model is properties not all carried over

@service
namespace AzureHealthInsights {
  model PatientInfo {
    clinicalInfo?: Lib.Coding;
  }
}

namespace Lib {
  model Extension is Element {
    valueCodeableConcept?: CodeableConcept;
  }

  model Element {
    thisIsCarried: string;
    thisIsNot?: Extension[];
  }

  model Coding is Element;

  model CodeableConcept is Element {
  }
}

This only happen when using different namespace. If you move the lib models into the service namespace everything is generated correctly.
Playground Link

This  issue is quite tricky to solve
model A {
  ...B;
}
model B {
  ...C;
}
model C {
  a: A;
  b: string;
}

In those cases depending on which model you resolve first when spreading B or C we might not yet know all the properties so it only spread partially


[recorder] move sanitizing customization in ACR to test recorder

Some customization in ACR test utils can be move to centralized test recorder.

Following our tradition, closing for now until it's really needed and shared by multiple libraries


Changed youtube link for track uri

Can you elaborate more context?

For my bot, I created an API and passed a link to a YouTube video, then passed it to lavaplayer and cached it using this link, but because of the differences, the cache did not work, I looked at the library code and found a difference in the returned links. But then I realized that it was possible to use the ID of a YouTube video, and the problem disappeared.


Add Code of Conduct

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>As the title says.

LGTM


Big PR: retrying fails, reducing docker registry spam

Also improvements to the integration tests.

Codecov Report

Merging #353 into master will increase coverage by 0.11%.
The diff coverage is 79.85%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   61.53%   61.65%   +0.11%
==========================================
  Files         162      162
  Lines        8805     8921     +116
==========================================
+ Hits         5418     5500      +82
- Misses       2949     2985      +36
+ Partials      438      436       -2

Impacted Files
Coverage Δ

graph/graph.go
88.53% <ø> (-0.05%)
:arrow_down:

util/shelltest/shelltest.go
0% <0%> (ø)
:arrow_up:

util/docker_registry/client.go
9.29% <0%> (-0.09%)
:arrow_down:

util/docker_registry/dummy_client.go
59.21% <0%> (ø)
:arrow_up:

ext/singularity/recti-agent.go
41.25% <0%> (-1.06%)
:arrow_down:

lib/deploystate.go
38.46% <100%> (+38.46%)
:arrow_up:

lib/manifest.go
79.41% <100%> (+0.3%)
:arrow_up:

lib/deployment_diff.go
98.57% <100%> (-1.43%)
:arrow_down:

lib/deployer.go
100% <100%> (ø)
:arrow_up:

lib/deployment.go
82.55% <100%> (+3.9%)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335cc14...cc9e455. Read the comment docs.


Reopen issue #179

Issue # 179 was not fully fixed. I have made an adjustment and am just about ready to submit a new PR. Is this the proper procedure when this happens (opening a new issue)?

Making a PR without an issue is ok too

Making a PR without an issue is ok too

Ok... thank you!


Flexoki theme

Is your feature request related to a problem? Please describe
No response
Will you be willing to contribute this feature?

[X] Yes, I'll give it a shot

Describe the solution you'd like
I made this theme for yazi: flexoki.yazi
Describe alternatives you've considered
No response
Additional context
No response

Awesome! Would you like to create a PR and add your repo to https://github.com/yazi-rs/themes?

I think I did. First time doing a PR, let me know if something is wrong


"Incorrect syntax near" error in database maintenance section when updating MSSQL database

As reported by Corey Conway on the mailinglist the database upgrade script fails on MS SQL Server on the update of a CPE-entry
Original report
(https://groups.google.com/forum/#!topic/dependency-check/pWqBFhH2YiE)
The relevant details
I try to update my local MSSQL 2017 database with this command:
mvn org.owasp:dependency-check-maven:update-only -Dowasp.dependencyCheck.db.username=username-Dowasp.dependencyCheck.db.password=password -DcveValidForHours=1 -Dowasp.dependencyCheck.db.
dbserver=servername-Dowasp.dependencyCheck.db.dbname=dbname
It runs through the updates and then in the section marked "[INFO] Begin database maintenance" I ultimately get a SQL exception that looks like this:
Unexpected SQL Exception: Incorrect syntax near 'u'
I took a look at the source code and it looks like the issue is the way MSSQL is handling the  UPDATE_ECOSYSTEM statement in this properties file
If I cut and paste that query into MSSQL it shows me the same error.   I found a stackoverflow.com post that references this issue in MSSQL 2008:
https://stackoverflow.com/questions/4981481/how-to-write-update-sql-with-table-alias-in-sql-server-2008
According to that post it looks like MSSQL handles table alias of DB tables differently than other databases like Oracle.
Expected behavior
A successful database update

Currently have my computer working on validation of the fix (will take a while as it needs an initial import of all NVD data into a freshly provisioned dockerized SQL Server database, 2003 feed loaded in 792606 ms)


More than one virtual keyboard?

Is it possible to create more than one virutal keyboard? In other words, Is it possible to create unique virtual keyboard, each corresponding to a captured (physical) keyboard?
I have encountered a problem when using a single virutal keyboard for more than one keyboard.
To reproduce:

Press a modifier key, e.g. shift, on a keyboard (keyboardA).
Press a key, e.g. f, on another keyboard (keyboardB).
This will produce F.
However, now, subsequent presses on keyboardB will produce non-shifted letter (e.g. f), rather than shifted letter (e.g. F).
But on keyboardA, the first keypress after #2 will produce a non-shifted letter, and subsequent keypresses on that keyboard will produce shifted letters.

tl;dr -- holding a modifier key on 1 keyboard, and pressing a key on another keyboard creates problem.
Details:

Dext version: 1.15.0
Uses report.keys.insert for all keys.

Does that create problems when used for modifier keys?
Anyway, I will try to use report.modifiers.insert instead to see if it solves the problem.

Tried using a single socket, and unique socket per device.

Doesn't solve the problem.

Code: https://github.com/kmonad/kmonad/blob/master/c_src/mac/dext.cpp

@tekezo: Any suggestion/advice?

Thank you very much! :-)

What is the difference between using report.keys.insert and report.modifiers.insert for modifiers? KMonad is using the former, so I am wondering whether that would create any issues.


[Compiler] Improve validation of input objects

Given the following schema:
enum SomeEnum {
  ENUM1,
  ENUM2
}

input SomeInput {
   mandatoryInt: Int
   mandatoryEnum: SomeEnum
}

type Query {
  randomInt(input: SomeInput): Int
}

The following queries fail validation on the server
query getRandomInt {
  # missing mandatoryEnum field
  randomInt({mandatoryInt: 0})
}

query getRandomInt {
  # mandatoryEnum is not a valid SomeEnum
  randomInt({mandatoryInt: 0, mandatoryEnum: FOO})
}

These errors could be caught client-side during compilation

Closing as it is fixed in dev-3x

Closing as it is fixed in dev-3x


html5 player is stopping autoplay on playlists sometimes

html5 player is stopping autoplay on playlists sometimes when a video gets to the end instead of going to the next video it stops with a big play button in the middle of the screen.
Please do not stop flash player support on youtube.

HTML has never worked for me for videos beyond 20 minutes and I SERIOUSLY
don't look forward to the day when Flash is gone, as the frustration that I
won't be able to watch videos beyond 20 minutes in length is just going to
turn me off of YouTube entirely.  This will be something I'm not looking
forward to, but I'm sure my ISP will like the savings in bandwidth I chew
up.  In order for me to continue playing my video, I have to close the
browser tab playing the video, seek to where the player died, and then
maybe resume playing.  Even CTRL-F5 under FF doesn't properly clear
whatever cache is being used.
Unfortunately, however, speculation is that YouTube is going to be killing
off Flash entirely, which means that YTC will probably end up removing the
option to specify Flash or HTML5.  Whether Flash or HTML5 exists is up to
YouTube as YTC just mangles/manages/changes what the client does with the
information the browser receives from YouTube servers.
On Thu, May 21, 2015 at 5:03 AM, audjack99aus8<EMAIL_ADDRESS>wrote:

html5 player is stopping autoplay on playlists sometimes when a video gets
to the end instead of going to the next video it stops with a big play
button in the middle of the screen.
Please do not stop flash player support on youtube.
—
Reply to this email directly or view it on GitHub
https://github.com/YePpHa/YouTubeCenter/issues/1832.


Migrate modules with 3rd party dependencies to autogen-ext

Some modules need to be migrated to autogen-ext:
### Tasks
- [ ] [models](https://github.com/microsoft/autogen/blob/staging/python/packages/autogen-core/src/autogen_core/components/models/_openai_client.py)
- [x] Local cmdline code exec
- [x] Docker cmdline code exec
- [x] Azure code executor

Additionally, autogen-ext should be setup to use extras to manage these dependencies

Done. Remaining one tracked by #3740


Decompose ligatures when the cursor is in/beside them

Description
I use FiraCode2 with ligature support in Atom, and for the most part it's very nice.
However, I find it very difficult to edit ligatures. For example, I often need to change <$> to <*> in Haskell, but Atom does not show where in the ligature the cursor is, and I often lose time erasing the wrong part of the ligature.
Similarly, I will often try to delete the space before an arrow -> , but I end up deleting the first dash - because the cursor is shown beside the ligature, even when its actual position is in the middle.
Ideally, when the cursor was at the edge of, or inside a ligature, it would be rendered not as the single character, but as the actual simple characters which make it up.
Is this possible? If it is not, consider this a request that it be added, or at least supported in a package.
Thanks!
Steps to Reproduce

Set the font to FiraCode, HaskLig, or another ligature-supporting font
Enter a ligature, such as ->
Move the cursor from one side to the ligature of the other

Expected behavior: The ligature is decomposed into its constituent characters, or the cursor is shown inside the ligature.
Actual behavior: The cursor remains to the right of the ligature.
Versions
I've tested in 1.7.1, but it showed up in all previous versions I'd used.

What OS are you on?

@bj7 I'm on Linux.
I just tried it with Atom 1.7.2 on Windows, and the cursors show up in the middle of the ligature, which solves the problem.
I'd initially thought this was a feature request, but maybe this is a bug on Linux?
If it helps, the linux stylesheet is as follows:
// style the background color of the tree view
.tree-view {
  // background-color: whitesmoke;
}

// style the background and foreground colors on the atom-text-editor-element itself
atom-text-editor {
  // color: white;
  // background-color: hsl(180, 24%, 12%);
  text-rendering: optimizeLegibility;
}

// To style other content in the text editor's shadow DOM, use the ::shadow expression
atom-text-editor::shadow .cursor {
  // border-color: red;
}

I just updated to 1.7.2 on Linux, and the problem still persists, so it does not appear to be a version issue.

Having done some more experimenting, it seems the problem is not with Windows vs. Linux, but latter with FiraCode vs Hasklig. Both Windows and Linux show the error with Hasklig, and neither with FiraCode.
This could be an Atom bug, or just a bug wth Hasklig.
In any case, my apologies for the misdirection with this.

@JoeyEremondi, perhaps try using the Hasklig in another editor on both systems to determine if it is a rendering issue in Atom only, or if it's a larger system issue. I thought your issue was primarily with Fira Code? I haven't tried Hasklig on OS X, but I will and see if I can replicate the bug.

I can reproduce the issues in Hasklig v0.9 on OS X and Atom v1.7.2. I used Hasklig in another non-Electron-based editor to test ligature support, and it worked fine. I tested Hasklig in Visual Studio Code (Electron based) and the problem persists. Fira Code works perfectly for both Atom and VS Code. This is not Atom specific.
This may be an issue with how Electron handles Hasklig, or it could be an issue with Hasklig itself (it is only v0.9), or it could be much deeper. Electron is based on Chromium, so if Chromium does not properly handle Hasklig ligatures, then Electron would most likely not, either. This is speculation on my part since I have not investigated Electron's source enough to say what it relies on to render fonts.
I recommend this issue is either closed, or opened under Electron/Hasklig repos.

Since this is only a problem with the Hasklig font and not the Fira Code one, I'm going to close this. It does seem like it could be a problem with Electron or Chromium rather than Hasklig, but it appears that Hasklig is probably the most likely suspect right now. Please feel free to reopen this if I have misunderstood the problem.

I was able to reproduce this on macOS Sierra and the PragmataPro font with Atom stable and Atom beta. Here's a GIF of what happens when I navigate over a ligature in a completely clean Atom Beta instance:

For comparison, here's what happens in the latest nightly of iTerm2:

It seems reasonable to conclude that something is up with Atom's (or Electron's) text rendering here, but unfortunately I don't have much more insight than that. I'd be grateful for any suggestions or thoughts from @lee-dohm and the other maintainers.

...conversely, and puzzlingly, Hasklig's ligatures do not exhibit this behavior in Atom beta:

Looks like this was cleared up in i-tu/Hasklig#40. It's because Pragmata Pro uses the liga OpenType feature and Hasklig uses calt.


[multistage] leaf-node return data in non-serialized format

currently, leaf-nodd returns a datatable. However in multistage engine, this datatable gets deserialized into rows. split into chunks and then reserialized back into smaller chunks for RPC sending.
This PR directly uses the InstanceResponseBlock to get the non-serialized rows, this

avoid the useless Ser/De
splitting data into chunks more directly instead of via the block API

Codecov Report

Merging #9755 (2497a82) into master (c9a6e52) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master    #9755      +/-   ##
============================================
+ Coverage     68.47%   68.49%   +0.01%
+ Complexity     5369     4891     -478
============================================
  Files          1953     1954       +1
  Lines        104797   104839      +42
  Branches      15871    15875       +4
============================================
+ Hits          71764    71813      +49
+ Misses        27914    27895      -19
- Partials       5119     5131      +12

Flag
Coverage Δ

integration1
25.28% <7.14%> (-0.10%)
:arrow_down:

unittests1
67.57% <87.50%> (+0.01%)
:arrow_up:

unittests2
15.65% <75.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/apache/pinot/query/runtime/QueryRunner.java
80.00% <58.82%> (-1.56%)
:arrow_down:

.../pinot/core/common/datablock/DataBlockBuilder.java
73.27% <100.00%> (+0.29%)
:arrow_up:

.../pinot/query/runtime/blocks/TransferableBlock.java
70.21% <100.00%> (-0.90%)
:arrow_down:

...t/query/runtime/blocks/TransferableBlockUtils.java
96.96% <100.00%> (+5.66%)
:arrow_up:

...e/pinot/query/runtime/operator/FilterOperator.java
60.00% <100.00%> (ø)

...pinot/query/runtime/operator/HashJoinOperator.java
81.69% <100.00%> (ø)

...ot/query/runtime/operator/MailboxSendOperator.java
88.54% <100.00%> (+0.12%)
:arrow_up:

...inot/query/runtime/operator/TransformOperator.java
79.31% <100.00%> (ø)

.../pinot/query/runtime/plan/PhysicalPlanVisitor.java
96.77% <100.00%> (ø)

...nction/DistinctCountBitmapAggregationFunction.java
47.66% <0.00%> (-13.99%)
:arrow_down:

... and 48 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

FYI @ankitsultana @agavra @siddharthteotia


Antrea's EgressIP does not work correctly when using BGP and IPs from different L3 network segments

I'm trying to deploy Antrea EgressIP on different Layer3 network segments.
The LoadBalancer type service works well both inside and outside the cluster.
I can access the deployment using the IP of a different network segment in the LoadBalancer type service.
For this purpose, FRR has been configured within the cluster, as well as on network equipment outside the cluster.
The routes are announced correctly.
When EgressIP is created for 3x pods in the deployment, only the pod on the node where egressIP is configured works correctly using egressIP as the source IP.
The other pods (which are on different nodes) have traffic loss, around 33% of packets are lost when a normal ping is made to any IP outside the cluster.
This is the YAML file I am using:
01-hello-world.yaml.txt

Can you ping the Egress IP from the other nodes and see if there is similar drop?
It would be more helpful if you could collect a support bundle via antctl supportbundle and share it.

Yes, similar drop from the other nodes to the Egress IP.

Collect the supportbundle from the nodes.
node1-bundle_575221220.tar.gz
node2-bundle_675429397.tar.gz
node3-bundle_859083289.tar.gz

It seems the gateway (<IP_ADDRESS>) sending Redirect may be related. I don't know much about FRR but it seems that the gateway knows that the Egress IP (<IP_ADDRESS>) can be reached via node2 (<IP_ADDRESS>) but node1 and node3 don't know (are they configured consistently?).
To rule out the impact of Redirect, could you try disabling sending ICMP Redirects on the gateway and see if it works?

The "no ip redirects" was configured on the gateway.
The 3x nodes can now ping the egressIP fine.
The 3x pods can now get out of the cluster using the egressIP sucessfully.
No more packet loss.

Thanks for your help.


Add SecurityForEveryone

Security For Everyone provides online and free cyber security tools.

Security For Everyone provides online and free cyber security tools.

How can i help you? @scottPHW @mordon93 @Arya017638 @homieb40

I have lost access to my email<EMAIL_ADDRESS>mentioned above please enable me to access it and send verification code on my new cell phone this<PHONE_NUMBER>4668
Or at my alternative email<EMAIL_ADDRESS>

I will unsubscribe this only if you deposit 2000 USD to me
Sent from Mail.ru app for iOS
Friday, November 24, 2023 at 09:46 -08:00 from @.***  @.***>:

@skydiver1980 approved this pull request.
—
Reply to this email directly,  view it on GitHub , or  unsubscribe .
You are receiving this because you are subscribed to this thread. Message ID:  <trimstray/the-book-of-secret-knowledge/pull/378/review/1748278324 @ github . com>

I don't have a lot money 😔

Ok


Adoption of some packages from worldofpeace

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122712 at 74e11d12 run on x86_64-linux 1

3 packages built successfully:

celluloid
notejot
taxi


Bundled short options

From the docs it is unclear if short options may be bundled, e.g. -a -b specified as -ab.

M_CLI2 by default does not distinguish between "--" and "-" prefixes.  It kicks into strict mode if ALL the options are long names with a single-character short name, which is specified  like "set_args(' --one:o F --two:t F --three:T F').  That is if all the switches are defined as --LONG_NAME:LETTER  then you can combine BOOLEAN single-character options.  So if you had a program
like
program demo9
!!  long and short names using  --LONGNAME:SHORTNAME
use M_CLI2,  only : set_args, get_args, sget, rget, iget, lget
implicit none
call set_args('--length:l 1 --one:two:three F --height:h 10 --size:s 12.34567 --switch:X F --aa:a F --bb:b F --title:T "my title"')
write(*,*)'--length or -l is ',rget('length')
write(*,*)'--height or -h is ',rget('height')
write(*,*)'--size or -s is   ',rget('size')
write(*,*)'--title or -T is  ',sget('title')
write(*,*)'--switch or -X is ',lget('switch')
write(*,*)'--aa or -a is  ',lget('aa')
write(*,*)'--bb or -b is  ',lget('bb')
write(*,*)'--one ',lget('one')
end program demo9

You could call it with "demo9 -Xa" and the booleans --switch and --aa  would be true.
There are a lot of different approaches to the rules governing long and short options, bundling, and whether bundled short names can be anything other than booleans.  Older programs had a variety of rules even before long switch formats existed and varied a lot.  Some allowed only single-character switches, allowed them to be bundled, and allowed option values to appear in any order as well, others allowed long names and no bundling, some mixed that. So commands like "find" have a totally different syntax than commands like "ls" and "tar".   To this day most "tar" commands allow "tar xvfz  name.tgz", for example. Several newer formats do not allow bundling,  or only allow booleans to be bundled; some care about the prefix being "--" or "-" and others do not.  Some require all options to have a long and short name. Some allow options to be numeric values, others do not. Some require values to always follow the keyword.
Never really decided which way M_CLI2 should behave, so never emphasized how it does work for bundling.  But if all keywords have a long and short value "strict" mode kicks in,  and booleans only can be bundled. There is a single sentence in the documentation that describes that but still wondering if it shoujld be changed.
M_CLI2 only allows the definition to provide a long name + colon + single-character short name, but originally instead of a short name the colon allowed giving a list of aliases, like    --one:two:three:four [value].  The idea, which was unique to M_CLI2 as far as I know, was mostly to allow key names in multiple languages but because a lot of Fortran compilers (particularly at that time) only supported basic ASCII characters, the number of languages supported was so limited it really did not pan out; so it was changed to support the LONG:SHORT syntax in the definition.
If the current behavior seems good, I will lock it in (and QA it, have not really used it that much); but open to creating a different behavior.  Although it was originally intended that if bundling was supported, short and long prefixes would be enforced it is lacks
about that. I would probably change that to be strictly enforced when bundling was enabled.
M_CLI2 has always required values to follow the key they apply to.

PS:  The documenation for set_args(3f) is currently the only place that mentions this:
•  The simplest way to have short names is to suffix the long name with
:LETTER. If this syntax is used then logical shorts may be combined on the
command line and -- and - prefixes are strictly enforced.

Added more explicit description in demo9.f90 and description in set_args(3f) documentation on rules for enabling bundling.

Ok.  So all the special modes are controlled via the new SET_MODE(3f) procedure; and no bundling is allowed unless "SET_MODE("STRICT") is called; in which case bundling of Boolean short switches is allowed.  Other switches that require values cannot be bundled.  The documentation in SET_ARGS(3f) and SET_MODE(3f) define the behavior.

Hopefully it is now clear that Boolean (logical) short options may be bundled; but to avoid conflicts between long names and bundles of short names spelling a long name that  strict mode should be on. This is done by calling "call set_mode("strict").
In addition, other modes that were still not fully supported have been solidified and a procedure specifically fot activating the optional behavior has been documented ("set_mode(3f)").


fix(test): Added smoke + minimal tests and Parallel execution.

Started
[chrome #01-1] .......................
[chrome #01-1]
[chrome #01-1]
[chrome #01-1] 23 specs, 0 failures
[chrome #01-1] Finished in 277.813 seconds
[chrome #01-1]
[20:22:47] I/testLogger -
[20:22:47] I/launcher - 0 instance(s) of WebDriver still running
[20:22:47] I/launcher - chrome #01-0 passed
[20:22:47] I/launcher - chrome #01-1 passed
4444/tcp:            30553
8088/tcp:            30591
Functional tests OK

@sanbornsen , @ldimaggi  please review !

[test]

Sure @LenDiMaggio will do in separate PR