[BUG] Warning events are being spammed by Longhorn - CRD

Describe the bug (🐛 if you encounter this issue)
Warning events are being spammed by Longhorn because the Longhorn Node CRD doesn't seem to recognize a new message in the latest k3s release.
"Unknown condition true of Kubernetes node : condition is of the EtcdIsVoter reason is, MemberNotLearner, message is Node is a voting member of etcd cluster."
To Reproduce

Install latest k3s 1.28.4-k3s2 in cluster mode --cluster-init (for etcd)

Install Longhorn chart

Nodes that are ready will broadcast a new condition not known by the Node CRD v1beta2 and spam warning events in longhorn-system namespace.

Expected behavior

No events or logs should be present.
Environment
Longhorn: 1.5.3
K3s: 1.28.4-k3s2
3 master nodes
5 workers
Ubuntu 22.04 baremetal.

Additional context

This warning is caused by K3s setting a new node condition. This was introduced with c5cd7b3d6543ef782c84651b5c46e904ca83828b, after an issue and adr
Various K8s implementations or cloud providers are allowed to set their own node conditions and the set provided in the K8s API is just a minimal set guaranteed to be there: https://pkg.go.dev/k8s.io/api/core/v1#NodeConditionType
There is nothing to worry about with this particular node condition as it only relays information about which node's etcd instance takes what kind of responsibility, so adding and removing nodes from a k3s cluster taking this information into account doesn't jeopardize the quorum of the etcd cluster.
Longhorn exposes all unknown (to longhorn) node conditions as K8s events. This is a mechanism that only has informational value and is used as such in Longhorn as well, as it only serves to relay information to the UI. The warnings are harmless in this case.
An argument can be made to ignore all unknown node conditions by default, or alternatively just ignore this particular one. What do you think @innobead , should Longhorn assume that an unknown node condition is worthy of being a warning, just as it is now?
It should be noted here that events are only emitted for node conditions that are "true", but not for ones that are "false". However there is no convention or guidance if "true" or "false" should indicate an error condition or healthiness.
I think the best course of action would be to just ignore non-standard node conditions except when we can derive value from them.

Understood.
Yeah, I saw the commit in the K3s repository yesterday and noticed it's a new addition from 3 weeks ago.
The reason for this issue is mainly because we should have a little bit of control to what should be logged in especially when it's harmless.
(⎈|k3s:default)➜  home-cluster git:(main) ✗ k get events -n longhorn-system
LAST SEEN   TYPE      REASON                     OBJECT           MESSAGE
4m9s        Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
4m9s        Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
4m9s        Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
4m12s       Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
4m9s        Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
4m9s        Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
4m9s        Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m38s       Warning   UnknownNodeConditionTrue   node/fluffy      Unknown condition true of kubernetes node fluffy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m15s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m38s       Warning   UnknownNodeConditionTrue   node/frenzy      Unknown condition true of kubernetes node frenzy: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
2m9s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
3m7s        Warning   UnknownNodeConditionTrue   node/whirlwind   Unknown condition true of kubernetes node whirlwind: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster

Right now, for each of my master nodes, it seems to be emitting 7 messages / 60 seconds.
Could unknown conditions be ignored through a chart option to the longhorn application perhaps?

I second this, after upgrading it's quite spamming the events. An ignore on these unknown conditions by default, or giving the option would be highly appreciated.

FYI for context, I don't get these messages, however my control planes are tainted as NoSchedule, so Longhorn never runs on my control plane nodes.

This comes from here: https://github.com/longhorn/longhorn-manager/blob/268b1d63b9570e750bc13e011f475a17e6878041/controller/node_controller.go#L455-L458
Apparently longhorn will barf if any unknown condition is set to true.

An argument can be made to ignore all unknown node conditions by default, or alternatively just ignore this particular one. What do you think @innobead , should Longhorn assume that an unknown node condition is worthy of being a warning, just as it is now?
It should be noted here that events are only emitted for node conditions that are "true", but not for ones that are "false". However there is no convention or guidance if "true" or "false" should indicate an error condition or healthiness.
I think the best course of action would be to just ignore non-standard node conditions except when we can derive value from them.

Ignoring unknown condition looks reasonable to me. The other approach is at least we should not repeatedly spam the API server by only emitting the unknown condition once?

My personal preference would be to have LH ignore any conditions that it doesn't specifically derive information from. If users want to be alerted about specific conditions on their node, there are tools other than LH that will handle this.

My personal preference would be to have LH ignore any conditions that it doesn't specifically derive information from. If users want to be alerted about specific conditions on their nodes, there are tools other than LH that will handle this.

Agreed. Should just do it explicitly by watching what conditions we care about. @m-ildefons Please continue working on it. Thanks.

i find those spummy events today , so fix will be on v1.6.0 version ?

any updates on this?

This will be fixed in the upcoming 1.6.0 and backported to 1.5.4 & 1.4.5.

Verified on master-head 20231225

longhorn master-head https://github.com/longhorn/longhorn/commit/fe9dc3c5530f58b80085686718e351a8e4634229
longhorn-manager master-head https://github.com/longhorn/longhorn-manager/commit/859d43893b67a3cc86d83938f33d9c38673e3636

The test steps
https://github.com/longhorn/longhorn/issues/7290#issue-2031804175

Install k3s Server and Initialize the Cluster
NOTE: For this test case, node taints node-role.kubernetes.io/master=true:NoExecute & node-role.kubernetes.io/master=true:NoSchedule on the control plane node have NOT been added.

curl -sfL https://get.k3s.io | K3S_TOKEN=SECRET INSTALL_K3S_EXEC="server --cluster-init" sh -

Check Control Node's Conditions

# Replace CONTROL_NODE_NAME with the actual name of your control node
kubectl get node $CONTROL_NODE_NAME -o=jsonpath='Node Name: {.metadata.name}{"\n"}Conditions:{"\n"}{range .status.conditions[*]}- Type: {.type}{"\n"}  Status: {.status}{"\n"}  LastHeartbeatTime: {.lastHeartbeatTime}{"\n"}  LastTransitionTime: {.lastTransitionTime}{"\n"}  Reason: {.reason}{"\n"}  Message: {.message}{"\n\n"}{end}'

Install Longhorn
Check events in the longhorn-system namespace

kubectl -n longhorn-system get events

Result Passed

Installed Longhorn v1.5.3 on k3s cluster and observed warnings in longhorn-system namespace:

65s         Warning   UnknownNodeConditionTrue   node/ip-10-0-1-57   Unknown condition true of kubernetes node ip-10-0-1-57: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
39s         Warning   UnknownNodeConditionTrue   node/ip-10-0-1-57   Unknown condition true of kubernetes node ip-10-0-1-57: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
38s         Warning   UnknownNodeConditionTrue   node/ip-10-0-1-57   Unknown condition true of kubernetes node ip-10-0-1-57: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster
24s         Warning   UnknownNodeConditionTrue   node/ip-10-0-1-57   Unknown condition true of kubernetes node ip-10-0-1-57: condition type is EtcdIsVoter, reason is MemberNotLearner, message is Node is a voting member of the etcd cluster

Inspected node conditions and found new condition EtcdIsVoter:

- Type: EtcdIsVoter
  Status: True
  LastHeartbeatTime: 2023-12-25T14:16:26Z
  LastTransitionTime: 2023-12-25T14:16:26Z
  Reason: MemberNotLearner
  Message: Node is a voting member of the etcd cluster

Checked control plane node events in Longhorn master-head and did not observe EtcdIsVoter warnings:

I tried Longhorn and it didn't work for my need.  I removed it from my cluster, but I still have the warnings (in Lens).  How do I clear those warnings?

Any idea when we can expect 1.4.5? I accidentally encountered this bug while on 1.4 right before Christmas (idle hands make for poor decisions :grin: ) and this has crippled my homelab.

Have you figured out how to clear the warnings?  There must be some way to edit ETCD (or wherever that's stored).

I also received this warning when I installed longhorn on the specific node.
https://github.com/longhorn/longhorn/issues/7407#issuecomment-1881838982

I tried Longhorn and it didn't work for my need. I removed it from my cluster, but I still have the warnings (in Lens). How do I clear those warnings?

Hi @Ashkaan What warning are you still seeing? Have you follow the instruction to uninstall Longhorn https://longhorn.io/docs/1.5.3/deploy/uninstall/ ?

Any idea when we can expect 1.4.5? I accidentally encountered this bug while on 1.4 right before Christmas (idle hands make for poor decisions 😁 ) and this has crippled my homelab.
Hi @Sierra1011 Do you mean the cluster is frozen?

Until the new release of LH is available, the only way to stop getting the events is to downgrade to an older release of K3s/RKE2.

I tried Longhorn and it didn't work for my need. I removed it from my cluster, but I still have the warnings (in Lens). How do I clear those warnings?

Hi @Ashkaan What warning are you still seeing after uninstall Longhorn? Have you followed the instructions to uninstall Longhorn https://longhorn.io/docs/1.5.3/deploy/uninstall/ ?

Yes, I followed this:
helm uninstall longhorn -n longhorn-system
I don't have anything longhorn installed anywhere (so far as I can tell) and I get this:

You get that where? Those events are 23 days old. Normally events don't hang around that long.

Correct.  These have been lingering and driving our team crazy.  We can see them in Lens.  It happened as soon as we tested longhorn for a project.

Has someone customized your cluster configuration to retain events for longer than usual? The default event ttl is a couple hours, if I remember correctly.

Sadly, I haven't yet learned how to delete events or customize the TTL.  If you have any docs or advice, I'd really appreciate it.
Also, all other warnings go away within a couple of hours.  These always stay.

Any idea when we can expect 1.4.5? I accidentally encountered this bug while on 1.4 right before Christmas (idle hands make for poor decisions 😁 ) and this has crippled my homelab.

Hi @Sierra1011 Do you mean the cluster is frozen because of the warning events?

TL;DR I am keen to know in what sort of timeframe a backport will become available.
Even after downgrading and reverting K3s versions etc, I continued getting these alerts preventing volumes being mounted. I tried removing taints by hand and deleting all the events, but no cigar. So I can't upgrade K3s version above a certain point without stopping volumes working.
It actually started/aligned with the start of a whole saga of storage issues for me that took a lot of fixing, and while I'm not certain exactly of the root cause, it's a lot of coincidence.
I'm not trying to be petulant, apologies if I'm coming across that way; I'm reluctant to do a knee-jerk upgrade from V1 to V2 when there's only one supported release that won't break with any vaguely recent version of K3s.
TIA

I continued getting these alerts preventing volumes being mounted.

These events are purely informational and do not prevent volumes from being mounted. If you have having problems with your LH volumes, look further for the actual root cause. This is not the source of your issue.

Is there any workaround for this issue? I'm also getting flooded with multiple 100'00 errors...
Kubernetes: v1.26.11 rke2r1
Longhorn: v1.5.3

I left it another few weeks and tried the upgrade again, prompted by Flux 2.2 requiring K8s API version >=1.26.
Still on LH 1.4.4. As soon as I upgraded to 1.26(.13.k3s2), it will not provision new PVCs. Seems as though this is likely to be unrelated so will investigate further but consider me out for now.
Thanks!

Rancher UI + Longhorn is still only listed as  103.2.1+up1.5.3 ... https://github.com/rancher/charts/tree/release-v2.9/charts/longhorn  .. still waiting for 1.5.4 or 1.6.0 to drop

That is a Rancher issue. Not Longhorn.

No, the root case belongs to longhorn and is solved in longhorn     1.5.4 and 1.6.0. longhorn 1.5.4 is shot before release in rancher AppStore

LH doesn't report anything. It just creates Kubernetes events, same as many other components. Rancher shows events in the UI. This is all off-topic; the LH chart for Rancher will be updated when the Rancher team gets to it.

its already released and LH 1.5.4 solved the log spamming !!!
https://github.com/rancher/charts/commit/159d5114c62dd567723fc749318cad71f86906e7

@Ashkaan  did you ever figure out how to remove those 'Node is a voting member of the etcd cluster' warning messages from Lens? I know they aren't specifically events,  they're node conditions...the events themselves are no longer being spammed by longhorn anymore thanks to this fix here.  But I also haven't figured out how to stop them from showing on the Cluster page in Lens.
Maybe it's Lens that needs to be updated?

No, I deleted the cluster over it.  Unreal.  I’ll never try Longhorn again.
On Wed, Apr 17, 2024 at 7:21 PM vember31 @.***> wrote:

@Ashkaan https://github.com/Ashkaan did you ever figure out how to
remove those 'Node is a voting member of the etcd cluster' warning messages
from Lens? I know they aren't specifically events, they're node
conditions...the events themselves are no longer being spammed by longhorn
anymore thanks to this fix here. But I also haven't figured out how to stop
them from showing on the Cluster page in Lens.
Maybe it's Lens that needs to be updated?
—
Reply to this email directly, view it on GitHub
https://github.com/longhorn/longhorn/issues/7290#issuecomment-2062873219,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLHZCT2NPC3HF5EHDWNY4LY54UZ7AVCNFSM6AAAAABAL7F3ACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSHA3TGMRRHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Added sorting of the master redirect file.

Hi @meganbradley,
Added the ability to sort the .openpublishing.redirection.json file. Open the command pallet and quickly sort the entire file alphabetically.

@lamebrain FYI.


feat(Color): impl Default

Hey, thanks for Rustbox!
I'm working on this thingy that uses rustbox.
Any opinions on adding a Default impl for Color?

No strong opinions either way - happy to merge!
Thanks!


update aw examples for the kuberay integration doc

Issue link
What changes have been made

Update broken link
Update to Quay repo to avoid pull limit from dockerhub
Update resource in the appwrapper for the expect behavior to be observed in the demo use case

Verification steps
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] Testing is not required for this change

LGTM

/approve

/lgtm


Gives Me multiple errors

Hey I just tried to open it for a simple gif file and the script throws multiple errors.
I didnt change anything just pressed download and copied to addons, any ideas what I did wrong?
res://addons/gif-importer/gif-lzw/lzw.gd:168 - Invalid get index 'sequence' (on base: 'Nil').
res://addons/gif-importer/GIFReader.gd:106 - Invalid get index '0' (on base: 'Nil').
editor/editor_file_system.cpp:1817 - Error importing 'res://1.gif'.
editor/import/editor_import_plugin.cpp:123 - Condition "!(get_script_instance() && get_script_instance()->has_method("get_option_visibility"))" is true. Returned: true
editor/import/editor_import_plugin.cpp:123 - Condition "!(get_script_instance() && get_script_instance()->has_method("get_option_visibility"))" is true. Returned: true
res://addons/gif-importer/gif-lzw/lzw.gd:168 - Invalid get index 'sequence' (on base: 'Nil').

same issue


build failed on Example project

When I was running the example project, I encountered the following error.

Launching lib/main.dart on iPhone 15 Pro in debug mode...
Running Xcode build...
Xcode build done.                                            5.5s
Failed to build iOS app
Error (Xcode): ../../../../../.pub-cache/hosted/pub.dev/win32-4.1.4/lib/src/guid.dart:31:9: Error: Type 'UnmodifiableUint8ListView' not found.
Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.

I changed the two packages below to the latest one and the build was successful. Please refer to it.

> package_info_plus 8.1.1 (was 3.1.2)
> win32 5.8.0 (was 4.1.4)

It seems that the UnmodifiableUint8ListView part has been deprecated in win32.

This should now be hopefully fixed with latest version.


The pass keyring backend doesn't follow symlinks

Thank you for all the effort dedicated to aws-vault !
My setup is such that the pass storage location is behind a symlink
ls -lh ~/.password-store

/home/user/.password-store -> /the/real/path/to/.password-store

Keyring v1.1.4 is not able to follow the symlink to the password store directory to fetch sensitive information.
Example aws-vault with keyring v1.1.4 failing to retrieve secrets from the pass backend
aws-vault --version
v5.2.1

aws-vault --backend=pass  exec pers/aws/profiles/testground -- aws sts get-caller-identity
aws-vault: error: exec: Error getting temporary credentials: profile pers/aws/profiles/testground: credentials missing

PR to follow.

Can't reproduce this issue. Test added in d531d42


WIP: Lhash optional statistics collection.

[x] documentation is added or updated
[x] tests are added or updated

This PR makes the statistics collection in the lhash object optional and disabled by default.
This means zero locking overhead unless the gathering is enabled.
This depends on #4418 for the locking changes to the lhash object.
This is an API breaking change in the sense that the statistics functions OPENSSL_LH_stats and OPENSSL_LH_stats_bio will not function properly without adding an enable call.  The other stats calls still work.

This is WIP until #4418 is resolved.

This is WIP

You can edit subject to denote it as such :-) And apparently I can do it for you. I mean I wanted to test and it worked and I decided to leave it like that...

Thanks.

This PR is unnecessary in light of #4429


update delete handlers in the minimal API tutorial

Fixes #30026
Within the page I also found more delete endpoints/handlers that could be updated.
If this is not desired I can revert these changes.
Side note: I like the new "Examine and test the endpoint" sections for the v8 docs!

Internal previews

📄 File
🔗 Preview link

aspnetcore/tutorials/min-web-api.md
Tutorial: Create a minimal API with ASP.NET Core

Awesome @timdeschryver,  thanks for the contribution!  Thanks @tdykstra for catching the PR, I didn't notice during my morning check (and now did during my evening check).


Animation nextFrame: function (component) frame null

google translate :)
Phaser 3.53.1 Windows 10 Chrome  89.0.4389.90
/src/animations/Animation.js#L537
    nextFrame: function (component)
    {
        var frame = component.currentFrame;

        //  TODO: Add frame skip support

        if (frame.isLast)

console:
Uncaught TypeError: Cannot read property 'isLast' of null
because component.currentFrame is null
This happens when a large number of animated sprites are created and deleted. Several hundred sprites on the scene at the same time. An animation error occurs on deleted sprites.

If write "if (frame == null) return;" the error no longer occurs, but it might not be the right approach.

The hundreds of sprites that are constantly being created and removed in the scene are of course not the default engine mode. But I would like that, for example, with a large number of players in an online game, the fps only decreases, and the game does not crash with an error.

The quantity of sprites won't make any difference to this error. I need to know how you are deleting them, as that is causing the error, not the number of them.

remove:
cargo.setActive(false);
cargo.removeAll(true);
cargo.destroy();

the class to be removed:
var cargo = new Cargo(this, cargos[id]);

class Cargo extends Phaser.GameObjects.Container {
    constructor(scene, data) {
        super(scene, data.x, data.y);
...
        if (this.equipment.type == 'minerals') {
            var anim_config = {
                key: 'minerals_cargo_anim',
                frames: scene.anims.generateFrameNumbers('minerals_cargo', {
                    start: 0,
                    end: 50,
                    first: 0
                }),
                frameRate: 20,
                repeat: -1
            };
            scene.anims.create(anim_config);
            this.cargo = scene.add.sprite(0, 0, 'minerals_cargo');
            this.cargo.play('minerals_cargo_anim');
        }
...

when is this being called? I suspect it's not part of the Phaser game loop, but outside of it.

Also, you should really, really be pooling and recycling these Game Objects and not destroying them all the time. Something should only really be destroyed when the Scene ends.

        socket.on('capture', function (data) {
            if (this.cargos[data.capture_id] == null) {
                return;
            }
            var cargo = this.cargos[data.capture_id];
            var unit = this.units[data.unit_id];

            this.tweens.add({
                targets: cargo,
                duration: 1000,
                x: data.x,
                y: data.y,
                scaleX: 0.5,
                scaleY: 0.5,
                onComplete: get_cargo.bind(this)
            });

            function get_cargo() {
                cargo.setActive(false);
                cargo.removeAll(true);
                cargo.destroy();
                delete this.cargos[unit.capture_id];
            }

        }.bind(this));

@photonstorm I'm getting this error too, when doing something like this:
mySprite.on("animationcomplete", () => {
            mySprite.destroy();
});

Not sure I'm doing this right. But I guess my problem here is skipMissedFrames functionality. When this is the frame.isLast === true, an "animationcomplete" event is fired, as a callback the my sprite is destroyed. But then execution of AnimationState#update is continued and the logic for skipMissedFrames is invoked, that's where we get this: Uncaught TypeError: Cannot read property 'isLast' of null.

No error occurs when skipMissedFrames: false

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Video chat volume is too low

First of all, great job, without this component I won't release my app.
Anyone experience this on iphone?
Some of my users told me that they can't hear me, the volume is too low.
My app is on the app store,
https://itunes.apple.com/us/app/lym/id1134985541?ls=1&mt=8
So really need to fix this bug,
RN && webrtc newbie, could anyone help me?

oops, I am experiencing it on Android, iOS works great though.
on android, the default threshold may differ by devices, so you may want to control it according your experiences.
on ios, they officially recommended to implement MPVolumeView
I'm not sure if it is related to webrtc itself, but you try checking/increasing volume to see if it back to normal

@zxcpoiu Me, too. I only got low volume problem on Android. iOS goes well.

@zxcpoiu @oney sorry for the late response,
setForceSpeakerphoneOn works for me on IOS.
(.setForceSpeakerphoneOn incall-manager true)

I think this issue should be renamed: "Use speakerphone by default instead of ear speaker".
Should we advise using setForceSpeakerphoneOn from the react-native-incall-manager module? Or should we implement this directly in react-native-webrtc?
On iOS, this can be implemented with AVAudioSessionModeVideoChat and on Android with setSpeakerphoneOn.

We discuss this a little bit before and guess maybe it is better to make this library agnostic.
Because there are tons of use cases, some may have it's own logic to audio/video routes or different implementation when to screen on/off and proximity and so on.
given that the complexity to maintain audio/video/screen/locker/proximity, we decide to split these logic in different repository. that's the reason why react-native-incall-manager was born.
I think the best place to have this utils is, for example, RCTWebRTCDemo, which we can implement some simple utils like you described above, or an example how to integrate with react-native-incall-manager for different use cases.
my two cents


BUG? xfms and mat files have inverse relationship

Just tested out the xfm writing of antsRegistration and it works properly however I ran into a weird caveat.
If I run antsRegistration to generate the xfm, and then use antsApplyTransforms with the xfm to transform  the moving file, all works as expected. if however I use mincresample to apply the transform, I find that it only works if I transform the fixed image to the moving image, i.e. it acts like an inverse transform.
From what I can gleam, this is because xfms transform the coordinate system while mats transform the image data.
@vfonov can you perhaps chime in here? antsRegistration and antsApplyTransforms are internally consistent but shouldn't they both be the other way so that fixed and moving are defined properly?

to resample image one actually have to calculate the inverse of the transform. So tools like mincresample and itk_resample do it as the first step. antsApplyTransforms uses different logic - you have to provide inverse transform to resample the image.

Perhaps the ITK xfm IO should compute the inverse for writing/reading so that the files on disk are consistent with the standard interpretation?
This would make moving/fixed consistent between minc-toolkit and ITK

We compute the inverse for linear transforms within antsApplyTransforms on the fly when requested by the user but not deformable transforms as the necessary computation would be much more involved and there's no guarantee that an inverse exists for the general deformable case.

right now the output.xfm - provides transformation from fixed to moving and output_inverse.xfm - from moving to fixed. And it's been like that since I mincified old ANTS tool


Install problem

I ran pip install --upgrade -r requirements.txt on Kali2
it seemed to complete successfully but when I run:
python crackmapexec.py
I get error:
Traceback (most recent call last):
File "crackmapexec.py", line 16, in
from impacket.dcerpc.v5 import transport, scmr, samr, drsuapi, rrp, tsch, srvs, wkst, epm
ImportError: cannot import name drsuapi
When I try and install drsuapi
I'm told:
Requirement already satisfied (use --upgrade to upgrade): impacket in /usr/lib/python2.7/dist-packages

@macubergeek hi,
your impacket install from kali's repos is conflicting with the newer one that is needed. Try using a virtualenv or removing impacket with apt-get and the re-installing

also see #1


Map Issue

Using maps in USA, India etc work fine but in Pakistan it doesn't. Is that an issue or these are hidden for privacy?

Grindr hides the distance in certain countries on purpose, and I believe Pakistan is one of them.  I moved my location over there, and looking around, Turkey was the first location where any distances would show.  Places such as Pakistan could use the distance data to track down and jail or kill gay citizens unfortunately, so a while back Grindr took some  of these dangers into account and disabled showing the distances in certain countries and territories where tracking the users could endanger their safety.


[5.9] [Macros] Cope with local types and opaque result types in macros and expansions

Address a few related issues that affect local types and opaque result types within macros:

Don't add local types or opaque types encountered while parsing the arguments of a freestanding macro to the global list. When we do add them, make sure we're adding them to the outermost source file so they'll get seen later. This avoids trying to generate code for these types, because they aren't supposed to be part of the program. Note that a similar problem remains for arguments to attached macros, which will need to be addressed with a more significant refactoring.
When determining whether opaque types should be substituted within a resilience domain, check the outermost source files rather than the exact source file, otherwise we will end up with a mismatch in argument-passing conventions.
When delaying the type checking of functions that occur as part of a macro expansion, make sure we record them in the outermost Swift source file. Otherwise, we won't come back to them.

There is a common theme here of using AST state on the source file in a manner that isn't ideal, and starts to break down with macros. In these cases, we're relying on side effects from earlier phases (parsing and type checking) to inform later phases, rather than properly expressing the dependencies through requests.
Fixes rdar://110674997&110713264.

@swift-ci please test


Autodemo won't save new PBs if a season is active, unless overall record is broken

With etj_ad_savePBsOnly 1, breaking your own PB when a season is active won't save the demo, only breaking overall record will save it.

It seems this also applies to breaking an overall record if no seasonal records are set.
So the issue happens when:

Player makes a new personal best on a run
A new season is added, and it's active
Player breaks their previous record, but hasn't set a seasonal record prior to that
No record is sent, only completion -> no autodemo saved

I might be missing some other scenarios too, but something is seriously wrong with the logic in TimerunV2::checkRecord

Additionally, banner print for breaking the record won't pop up on the above scenario either, if the new record is a new overall record.


CA1052 suggests that the static keyword is meant to prevent inheritance

The current document currently gives the following explanation (emphasis mine):

Rule CA1052 assumes that a type that contains only static members is not designed to be inherited, because the type does not provide any functionality that can be overridden in a derived type. A type that is not meant to be inherited should be marked with the static modifier in C# to prohibit its use as a base type.

Is that really the correct reasoning here? A type that is not meant to be inherited should be marked as sealed to prevent it from being used as a base type. But static-ness usually refers to whether or not it is useful to instantiate the type.
Maybe something like this instead, which immediately makes more sense to me?

Rule CA1052 assumes that a type that contains only static members is not designed to be instantiated, because the type does not provide any functionality as an instance. A type that is not meant to be instantiated should be marked with the static modifier in C# to prohibit it from being instantiated.

I do see that the analyzer title “Static holder types should be Static or NotInheritable” does explicitly mention the “NotInheritable”, but the explanation still isn’t clear to me here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23439dc2-302a-1b72-9aef-b1f0daab36c5
Version Independent ID: 77b68df1-e7d1-36ea-4e4e-c167aa537a3a
Content: CA1052: Static holder types should be Static or NotInheritable (code analysis) - .NET
Content Source: docs/fundamentals/code-analysis/quality-rules/ca1052.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

This rule was brought over from the old FxCop rules, and I agree it is confusing.
"Should be marked static or NonInheritable" -> This should probably say "...static or Shared", or "...sealed or NonInheritable", since these would be equivalents in C# and Visual Basic. Or is the VB guidance to convert the class to a module?
As to why the rule suggests marking a type as static vs. sealed, I'm not sure.
You can take a look at the implementation (and comments) here.
@mavasani or @BillWagner Should we update the documentation here?


Resubmit of trending PR, sorry

As discussed on Slack and elsewhere, this will compute trending scores using a different algorithm from the existing one. I would love for someone to get this running on a server I can connect to. It should give similar (though not identical) results to https://brendonbrewer.keybase.pub/trending.html.
I'm sure more optimisations are possible. My trending scores are going into trending_mixed in claims.db, and trending_group is zeroed out, so apps can already sort correctly when connected.
A resync is required, and it will start computing trending only on the last 288 blocks (~12 hours). After that, trending is calculated every block in RAM.
Performance Note:
In case it's relevant for sqlite considerations, every block involves a read that takes about 5-15 seconds, every block divisible by 10 involves a small fast write as well, and every block divisible by 1000 involves a big write taking a minute or two.
claim.trending_mixed is now also floats rather than ints.

@kauffj is the goal that this replaces the existing ZScore based trending?
@eggplantbren this needs to be rebased on master and some basic styling / code cleanup, for example, constants in Python should be all-caps.
is this code ready for review and merging?

If you guys like it, I would be super happy for it to become official. Please try it out first and make sure you think it's sensible.
I can catch it up to master whenever you need. Also, is there a Python style guide that you conform to? I've only ever programmed myself or with one other person, so have never learned many things.

There is indeed a Python style guide, first link here: https://www.google.com/search?q=python+style+guide
If you rebase on master there is a stricter pylint rule for entire code base as well. Just run make lint to run the pylinter (or pylint --rcfile=setup.cfg lbry without make).

I've done the rebase.


fix: updated sensors

:tada: This PR is included in version 1.11.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Breaks StrictMode on first run after install app

E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
java.lang.Throwable: Explicit termination method 'close' not called
at dalvik.system.CloseGuard.open(CloseGuard.java:223)
at java.io.RandomAccessFile.(RandomAccessFile.java:263)
at zlc.season.rxdownload3.core.RangeTargetFile.createShadowFile(RangeTargetFile.kt:45)
at zlc.season.rxdownload3.core.RangeDownload.download(RangeDownload.kt:54)
at zlc.season.rxdownload3.core.RealMission.download(RealMission.kt:280)
at zlc.season.rxdownload3.core.RealMission.access$download(RealMission.kt:23)
at zlc.season.rxdownload3.core.RealMission$checkAndDownload$1.apply(RealMission.kt:268)
at zlc.season.rxdownload3.core.RealMission$checkAndDownload$1.apply(RealMission.kt:23)

你这个需要把RxDownload.create()出来的disposable在页面关闭的时候dispose(disposable)一下

Seems ok, close issue

Dispose that disposable did not fix this issue.
Only crash on first run after a clean app install.
BTW I didn't find any code called close on the shadow file created.
https://github.com/ssseasonnn/RxDownload/blob/master/rxdownload3/src/main/java/zlc/season/rxdownload3/core/RangeTargetFile.kt#L45
fun createShadowFile() {         val file = RandomAccessFile(shadowFile, MODE)         file.setLength(mission.totalSize)     }
that 'file' was only a local variable, thus leaked, you should make it a class member and close it for clean up.

Dispose that disposable did not fix this issue.
Only crash on first run after a clean app install.
BTW I didn't find any code called close on the shadow file created.
https://github.com/ssseasonnn/RxDownload/blob/master/rxdownload3/src/main/java/zlc/season/rxdownload3/core/RangeTargetFile.kt#L45
fun createShadowFile() { val file = RandomAccessFile(shadowFile, MODE) file.setLength(mission.totalSize) }
that 'file' was only a local variable, thus leaked, you should make it a class member and close it for clean up.

why is this closed? This is not fixed


Update to idea 2017 3 4

updated my IDEA Ultimate to 2017.3.4 and it's working. I also checked the buildnumber of CE and Ultimate and they are similar. In my opinion this issue would be fixed, but it would be nice if you @fharms could take a look at it


rename file names based on style guide

Updating sample to follow style guide

PR for https://github.com/alexeagle/angular-bazel-example/issues/6

Thanks Tor!!


Update version to 2.6.3-SNAPSHOT for branch-2.6

Alluxio Version:
2.6.2
Describe the bug
Since 2.6.2 has been released, need to update version to 2.6.3-SNAPSHOT for branch-2.6
To Reproduce
Expected behavior
Urgency
Trivial
Additional context
No

Branch-2.6 doesn't updates its numbers with OS releases per our release protocol. I'm closing this issue for now. If you see the necessity, feel free to reopen or raise new issue to discuss this. Thank you for your contribution!


Widget Javascript not detected under IPython 5.1.0

IPython 5.1.0
Widget Javascript not detected.  It may not be installed properly. Did you enable the widgetsnbextension? If not, then run "jupyter nbextension enable --py --sys-prefix widgetsnbextension"

I run
jupyter nbextension enable --py --sys-prefix widgetsnbextension

and rerun ipython console. But still
Widget Javascript not detected.  It may not be installed properly. Did you enable the widgetsnbextension? If not, then run "jupyter nbextension enable --py --sys-prefix widgetsnbextension"

Pardon,
Kernel restarting was not enough. I had to stop/start ipython process.


[Google Search] [Feature] Always have current search at top

Extension – Google Search
Author: @mblode

Describe the feature and the current behavior/state.
Currently, if I want to search for something, I have to wait 1-2 seconds for the autofill to populate my query. It would be great if hitting enter without any navigation always brought me to that exact search page, with suggestions as options.
Who will benefit with this feature?
Users who like to search for stuff quickly using the Google Search extension.

Great idea 👍 So the first result is always an exact match search. Are you experienced with coding and would you be able to work on the feature?

I could probably figure something out, It wouldn't be that hard to just return the current text.
I'll try something out when I have the time, and submit a PR


Perform a Database migration using alembic

Figure out a way to do a database migration with alembic to serve as an example

There is a solid chance this gets consumed by another issue


How to update envelope status from created to sent?

May I know how to set the envelopeStatus of an envelope that's in draft status("created") to "sent"? This way I can now send the envelope to all the recipients?

I created the envelope by creating EnvelopeDefinition and assigning the documents and other metadata followed by setting the EnvelopeDefinition Status to "created". This has definitely put the envelope in draft status instead of sending it to the end user and this is exactly what I wanted.

envDef.Status = "created";
var envelopesApi = new EnvelopesApi(apiClient);
EnvelopeSummary envelopeSummary = envelopesApi.CreateEnvelope(accountID, envDef);

Now, after another process brings in additional documents and recipients info I now have updated to include them in the envelope above(using the same envelopeID generated in step#1) by setting the EnvelopeDefinition Status to "sent". This time I don't see any difference and the envelope is still sitting in the Draft status while the envelope got updated with the additional documents.

envDef1.Status = "sent";
EnvelopeDocumentsResult res = envelopesApi.UpdateDocuments(accountID, envelopeSummary.EnvelopeId, envDef1)
May I know if I'm missing anything here? (or) Call additional DocuSign endpoint to now move the envelope to "sent" status so that it will be sent to the recipients?
Thanks in advance.

Hello @harshac2b2,
If the Update call is returning successful, and the only data not properly getting updated is the envelope's status, then I believe it's safe to assume that your system is not properly setting the envelope's status = "sent". Are you able to provide a small code example of this call request?
If you feel more comfortable you can open a support case to our Developer Support channel and a support engineer will be able to assist you with this issue. https://developers.docusign.com/support/

need to call Update() not UpdateDocuments()


Unconstrained type_template is falsey allowed

@andyw8, @paracycle and I found this odd behaviour of type_template, that lets you use the corresponding class even when the type is completely unset and unconstrained. Furthermore, it's illegal to try to set it with e.g. C[String], with Sorbet thinking that C isn't a generic class at all.
Input
→ View on sorbet.run
class C
  extend T::Sig
  extend T::Generic

  X = type_template

  sig { returns(X) }
  def self.example = T.unsafe(nil)
end

T.reveal_type(C.example) # => T.untyped

# Manually fixing the type is not allowed:
# > C is not a generic class, but was given type parameters
T.reveal_type(C[String].example)

Observed output
Abridged output:
editor.rb:11: Revealed type: T.untyped https://srb.help/7014
    11 |T.reveal_type(C.example) # => T.untyped
        ^^^^^^^^^^^^^^^^^^^^^^^^

editor.rb:15: C is not a generic class, but was given type parameters https://srb.help/7010
    15 |T.reveal_type(C[String].example)

Expected behavior
For C.example to be disallowed (as the type of X is unknown), and/or for C[String] to be required instead.

This all looks like the expected behavior of type_template to me. As it's not possible to instantiate a generic that uses type_template, the type of X will be defaulted to T.untyped, just like with an un-instantiated type_member.
→ View on sorbet.run
# typed: true

class C
  extend T::Sig, T::Generic

  X = type_member

  sig { returns(X) }
  def example
    T.unsafe(nil)
  end
end

T.reveal_type(C.new.example) # Revealed type: `T.untyped`

type_template is most often used to allow an abstract parent to enforce constraints on a child class. As such the pattern is usually that a parent will introduce a type_template with an upper bound, and a child class will re-declare it with fixed bound. This enforces the constraints that the parent class requires, but yields concrete types in the child:
→ View on sorbet.run
# typed: true

module Interface
end

class Parent
  extend T::Sig, T::Generic

  Elem = type_template {{ upper: Interface }}

  sig { returns(Elem) }
  def self.example
    T.unsafe(nil)
  end
end

T.reveal_type(Parent.example) # Revealed type: `T.untyped`

class Container
  include Interface
end

class Child < Parent
  extend T::Sig, T::Generic

  Elem = type_template {{ fixed: Container }}
end

T.reveal_type(Child.example) # Revealed type: `Container`

Additionally, an unconstrained type_template is fine, as it's leaving the door completely open for any fixed type that a child might choose.
Generics that use type_template can be a little bit surprising to work with, but if you're familiar with rust's associated types in trait impls, I think that's a reasonable analogy.

This is discussed at length here
https://github.com/sorbet/sorbet/blob/master/docs/variance-defaulting.md


Make localhost for local pods configurable via operator flag

Add flag for fixing localhost resolve issue: https://github.com/coreos/prometheus-operator/issues/1646

Thanks for reporting and fixing this! :slightly_smiling_face: We have the same case in the Alertmanager: https://github.com/coreos/prometheus-operator/blob/aa0166b0ee0c7efd8b99b9d9f08807036626fa5c/pkg/alertmanager/statefulset.go#L209
Would you mind fixing that as well? Thanks!

Changed local reload host to simply localhost in an attempt to generalize as I added the variable to the Thanos sidecar as well. I did a search for any additional places where this might help as well.

lgtm :+1: thanks!


Excluding a feature present on only some crates in a workspace displays warning

Excluding a feature that is not on all crates in a workspace displays warning for each crate that doesn't have the feature.
For example, in the following repo the feature docs is defined on the stellar-contract-sdk crate, but no others. When excluding the feature a warning displays for all other repos:
$ git clone https://github.com/stellar/rs-stellar-contract-sdk
$ cd rs-stellar-contract-sdk
$ git checkout 9481010ac820ce3694d5853db79beee38e302690
$ cargo hack --feature-powerset --exclude-features docs test
warning: specified feature `docs` not found in package `example_add_i32`
warning: specified feature `docs` not found in package `example_add_i64`
warning: specified feature `docs` not found in package `example_udt`
warning: specified feature `docs` not found in package `example_contract_data`
warning: specified feature `docs` not found in package `example_create_contract`
warning: specified feature `docs` not found in package `example_linear_memory`
...

Thanks! Addressed in 0.5.16.

Thanks for fixing! ❤


a question abount two squences in identify_perfect_nano.py

Hi,I want to ask a quetion abount,AAGCAGTGGTATCAACGCAGAGT and  TTTTTTTTTTTTTTTTTTTT in function m=regex.finditer(***),what are the means of them ? Are they a five-terminal primer and a three-terminal primer？Thanks!

Hi, If im not mistaken then the code you point to is just trying to locate the SMART primer: AAGCAGTGGTATCAACGCAGAGT and the polyT site of the read.

Well, if my nano sequencing isn't the same as yours, like my primer_5 and primer_3 are A and B, respectively,can I use your these code or how can I edit them

This code is really only possible for single-cell sequencing using dimer barcodes and UMIs (design found in our paper: https://www.nature.com/articles/s41587-021-00965-w). At the moment we are trying to make these commercially available and hope to have a solution in next 6 months or so.
However, you may want to look at Matt Ritchie and or Waldmann groups fantastic code for Nanopore single-cell sequencing that might be more appropriate: https://github.com/LuyiTian/FLAMES and https://github.com/ucagenomix/sicelore. You would likely need to sequencing using both Illumina and Nanopore though.

OK,thanks your reply!


Unable to write HTML code

We have written the needed data into your clipboard because it was too large to send. Please paste.

I hope I've got it right this time.

Unfortunately the description above says: We have written the needed data into your clipboard because it was too large to send. Please paste. Sorry.


Support for yaml?

I just installed this package and I got the nice pop up message inviting me to submit an issue for YAML support.
I was just wondering if this would be a possibility?

Hi cortopy,
as the spec of YAML only mentions line comments, the only possibility would be to set a "#" in the begin of every selected line.
Fortunately Atom already offers this functionality by the use of the command:
toggle-line-comments

Greetings

Working great that way. Thanks!


pub deletes SDK files during 'pub install' (Windows)

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Setup a pubscpec.yaml like so:
dependencies:
  unittest:
    sdk: unittest

execute 'pub install', then add another repo to the pubspec and execute 'pub install' again.  On my system, this will consistently delete the unit test source files in the SDK.
What is the expected output? What do you see instead?
Files should not be deleted.
What version of the product are you using? On what operating system?
Win 7 64-bit.  Dart build: 10311
Please provide any additional information below.

This issue has been moved to dart-lang/pub#59.


Solr pods never become ready when creating a new SolrCloud

Describe the bug
When creating a SolrCloud the example-solrcloud-0 pod never becomes ready.
To Reproduce
Create a simple SolrCloud example with operator args:

-zk-operator=true
-etcd-operator=false

In the logs of the pod example-solrcloud-0 this is found:
java.lang.IllegalArgumentException: A HostProvider may not be empty!
	at org.apache.zookeeper.client.StaticHostProvider.<init>(StaticHostProvider.java:88)
	at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:449)
	at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:383)

kubectl shows this:
pod/example-solrcloud-0                             0/1     Running             0          3m
The solr pod never becomes ready. When checking the pod it says ZK_HOST is "/". When watching the solr statefulset it looks like the pod template has a correct ZK_HOST. But currentRevision and updateRevision for the solr statefulset differ so it's likely that the first revision of the statefulset has an invalid ZK_HOST and the second revision has a correct one. But the pod is stuck with the first revision of the statefulset and can't recover. Kubernetes tries to restart the pod many times, but it's always the same error because ZK_HOST is still "/".
A workaround is to delete the example-solrcloud-0 pod, the installation will then continue and succeed.

	Ah interesting, I think I’ve seen this same race condition as well. Does it happen to you every single time you setup a new SolrCloud? I never dug into why, but your debugging seems to have found the root cause! Nice

	Get Outlook for iOS

On Mon, Nov 4, 2019 at 7:55 AM -0800, "timterle"<EMAIL_ADDRESS>wrote:
Describe the bug
When creating a SolrCloud the example-solrcloud-0 pod never becomes ready.
To Reproduce
Create a simple SolrCloud example with operator args:
-zk-operator=true
-etcd-operator=false
In the logs of the pod example-solrcloud-0 this is found:
java.lang.IllegalArgumentException: A HostProvider may not be empty!
at org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:88)
at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:449)
at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:383)
kubectl shows this:
pod/example-solrcloud-0                             0/1     Running             0          3m
The solr pod never becomes ready. When checking the pod it says ZK_HOST is "/". When watching the solr statefulset it looks like the pod template has a correct ZK_HOST. But currentRevision and updateRevision for the solr statefulset differ so it's likely that the first revision of the statefulset has an invalid ZK_HOST and the second revision has a correct one. But the pod is stuck with the first revision of the statefulset and can't recover. Kubernetes tries to restart the pod many times, but it's always the same error because ZK_HOST is still "/".
A workaround is to delete the example-solrcloud-0 pod, the installation will then continue and succeed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@sepulworld Yes, actually every time

Fixed in the v0.2.0 release


Moreflags but still no panics --- rocksdb & coverage

Motivation
Coverage
Have you read the [Contributing Guidelines on pull requests]
y
Test Plan
ci
Related PRs

Codecov Report

Merging #4605 into master will decrease coverage by 25.4%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4605      +/-   ##
=========================================
- Coverage    63.5%   38.0%   -25.5%
=========================================
  Files         635     830     +195
  Lines       79754   99271   +19517
  Branches    13267   45881   +32614
=========================================
- Hits        50679   37808   -12871
- Misses      19456   26621    +7165
- Partials     9619   34842   +25223

Impacted Files
Coverage Δ

.../proptest-helpers/src/unit_tests/pick_idx_tests.rs
0.0% <0.0%> (-100.0%)
:arrow_down:

...est-helpers/src/unit_tests/growing_subset_tests.rs
0.0% <0.0%> (-100.0%)
:arrow_down:

...uage/vm/serializer-tests/tests/serializer_tests.rs
0.0% <0.0%> (-91.7%)
:arrow_down:

...nguage/compiler/src/unit_tests/serializer_tests.rs
8.3% <0.0%> (-87.5%)
:arrow_down:

...test-generation/tests/control_flow_instructions.rs
0.0% <0.0%> (-87.5%)
:arrow_down:

...tools/test-generation/tests/struct_instructions.rs
0.0% <0.0%> (-86.5%)
:arrow_down:

...guage/tools/utils/src/module_generation/options.rs
15.7% <0.0%> (-84.3%)
:arrow_down:

...ools/test-generation/tests/special_instructions.rs
0.0% <0.0%> (-83.4%)
:arrow_down:

...guage/tools/vm-genesis/src/genesis_gas_schedule.rs
18.5% <0.0%> (-81.5%)
:arrow_down:

...ls/test-generation/tests/reference_instructions.rs
0.0% <0.0%> (-81.4%)
:arrow_down:

... and 759 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1295968...5f46fec. Read the comment docs.

Move-lang stack overflows with these flags.   Closing.


 adjacent to * glob breaks matching

Ludusavi version
v0.20.0
Operating system
Windows
Installation method
Scoop
Description
I noticed this with Need for Speed: Underground, and I believe the discussion I've associated below may have something to do with it. Underground's manifest entries utilize <storeUserId> (converted from <user-id>), which as you've stated, is simply interpreted as a * glob.
When backing the data up, it correctly matches <winProgramData>/NFS Underground/Adam.cfg from <winProgramData>/NFS Underground/<storeUserId>.cfg, which makes sense, given the conversion to *.cfg internally.
However, it does not match my file <winProgramData>/NFS Underground/Adam0.ugd from <winProgramData>/NFS Underground/<storeUserId>*.ugd. This may have something to do with it ending up with an internal value of **.ugd.
I've changed the entry on PCGW to make more sense (all *.ugd are saves, and I think it's not the best use of <user-id>- it's better suited to account ID than an internal game profile name), but this still brought up a very real issue in parsing.

Right now, <storeUserId> is regrettably just interpreted as *, because I'm not sure if it's feasible to account for all possible ID patterns. For example, one comment in the other ticket noted that, within a Steam root, GTA 4 used some other pattern for its ID rather than a typical Steam pattern.

Maybe we could have an option to enable stricter matching of known patterns, but there will be a risk of missing saves. For the default configuration, I think it's better to find too many files than too few, since at least it gives the user a chance to deselect them instead of miss them entirely.

Originally posted by @mtkennerly in https://github.com/mtkennerly/ludusavi/issues/236#issuecomment-1609731715

Good catch! It'll definitely need some special handling around that. Thanks :D


gulp 3.x CLI does not support both versions of gulp

If I use gulp branch 0.4 within my local project but then run gulp 0.3 (installed globally) then I get an error:
$ gulp
[12:24:51] Using gulpfile ~/src/xxxxx/gulpfile.js

/Users/ibc/.npm-packages/lib/node_modules/gulp/bin/gulp.js:129
    gulpInst.start.apply(gulpInst, toRun);
                   ^
TypeError: Cannot call method 'apply' of undefined
    at /Users/ibc/.npm-packages/lib/node_modules/gulp/bin/gulp.js:129:20
    at process._tickDomainCallback (node.js:463:13)
    at Function.Module.runMain (module.js:499:11)
    at startup (node.js:119:16)
    at node.js:906:3

May I know why gulp does not provide a separate module gulp-cli (similar to grunt-cli) whose only purpose is to locate the local gulp executable path (or the global one if not present locally)?
The idea of grunt-cli is to avoid issues as the described above. I consider it extremely useful.

Should be working in gulpjs/gulp-cli#4.0 and gulpjs/gulp#4.0 now.  Give it a shot and let me know if it works.

Can this issue be closed now that the CLI compatibility is fixed?

@ilanbiala gulpjs/gulp-cli#4.0 branch needs to be merged first and there's a blocker https://github.com/gulpjs/gulp-cli/issues/7

Maybe just rename CLI call to: gulp4 default  or write tool like nvm do the trick?

As of now, gulp-cli has a published 1.0.0 - https://www.npmjs.com/package/gulp-cli
Closing this as completed.

Woohoo!!
On Nov 18, 2015 6:56 PM, "Blaine Bublitz"<EMAIL_ADDRESS>wrote:

Closed #805 https://github.com/gulpjs/gulp/issues/805.
—
Reply to this email directly or view it on GitHub
https://github.com/gulpjs/gulp/issues/805#event-468614891.

node ./node_modules/gulp/bin/gulp.js -v
[16:21:56] CLI version 1.2.2
[16:21:56] Local version 4.0.0-alpha.2

but this really works
node ./node_modules/gulp/bin/gulp.js

Loading engines...
...scanning for engines in the core...
...scanning for engines in the edition or test directory...
- mustache engine: good to go
...done loading engines.


converted to gomod, pinned x/tools

This is my first time using go mod. Thought this was low enough hanging fruit to tackle, and seems to work fine once compiled, however doesn't seem to work when using go run main.go.
LMK if there's any amiss.
Cheers.

@morganhein you will need to execute go run *.go, since there is several go files.

@davecheney any chance you could review this? 🙏

@morganhein you will need to execute go run *.go, since there is several go files.

Ah, awesome, ty.

Currently go get github.com/davecheney/godoc2md fails on master with:
# github.com/davecheney/godoc2md
../../davecheney/godoc2md/main.go:173:6: pres.ShowExamples undefined (type *godoc.Presentation has no field or method ShowExamples)
../../davecheney/godoc2md/main.go:184:7: pres.PackageText undefined (type *godoc.Presentation has no field or method PackageText)
../../davecheney/godoc2md/main.go:186:7: pres.PackageText undefined (type *godoc.Presentation has no field or method PackageText)
../../davecheney/godoc2md/main.go:189:12: undefined: godoc.CommandLine

This PR fixes it, just fyi.

@timbunce I feel like this line: go: finding golang.org/x/tools latest indicates it's ignoring the go mod files. It should not be downloading the latest golang tools, since it's supposed to be pinned.
If you do a go mod vendor inside the gomod2doc folder, and inspect the golang.org/x/tools dep, you should see the godoc.CommandLine function, for example. If it's not, then it's ignoring the mod.


cinder - alpine - udevadm not present in image

/kind bug
What happened:
I found in the cinder nodeplugin that udevadm was no where to be found
What you expected to happen:
exec udevadm
How to reproduce it (as minimally and precisely as possible):
udevadm is present in the code :
cloud-provider-openstack% grep -r udevadm *

pkg/volume/cinder/cinder_util.go:	cmdSettle := executor.Command("udevadm", argsSettle...)
pkg/volume/cinder/cinder_util.go:		klog.Errorf("error running udevadm settle %v\n", errSettle)
pkg/volume/cinder/cinder_util.go:	cmd := executor.Command("udevadm", args...)
pkg/volume/cinder/cinder_util.go:		klog.Errorf("error running udevadm trigger %v\n", err)
pkg/csi/cinder/mount/mount.go:	cmd := executor.Command("udevadm", args...)
pkg/csi/cinder/mount/mount.go:		klog.V(3).Infof("error running udevadm trigger %v\n", err)

simple fix is to add the eudev package in the Dockerfile for the image :
cluster/images/cinder-csi-plugin/Dockerfile

cat cluster/images/cinder-csi-plugin/Dockerfile
FROM alpine:3.7
LABEL maintainers="Kubernetes Authors"
LABEL description="Cinder CSI Plugin"
RUN apk add --no-cache ca-certificates e2fsprogs eudev
ADD cinder-csi-plugin /bin/
CMD ["/bin/cinder-csi-plugin"]

@dricoco CSI code is not located here  pkg/volume/cinder/cinder_util.go, it is located in
/pkg/csi/cinder, it does not require eudev
/close

my pod "csi-nodeplugin-cinderplugin-g82dm" was logging udevadm errors until I added this package so maybe it's not required by the code in csi, but to have the example of the doc working it's probably necessary.

@dricoco which example doc??

/open

/reopen

I'm sorry I don't have the log anymore, but
if I grep again, I can see here :

pkg/csi/cinder/mount/mount.go:	cmd := executor.Command("udevadm", args...)
pkg/csi/cinder/mount/mount.go:		klog.V(3).Infof("error running udevadm trigger %v\n", err)

that it's using also udevadm on this part of the code. Sorry for the wrong grep

@dricoco there is no problem adding udevadm to docker file, it's just we have not faced any problem till now, if you are still able to reproduce the issue feel free to propose the PR

sure will :)

@adisky just did https://github.com/kubernetes/cloud-provider-openstack/pull/616

/close
Refer https://github.com/kubernetes/cloud-provider-openstack/pull/616


Loss of scoped lifetime service instances when resolving HttpClient services configured through IServiceCollection.AddHttpClient(...)

Issue description
Hi, it seems there is an issue that causes scoped lifetime service instances to be lost (and potentially re-instantiated within the same request/scope). This is completely the opposite of what one would intend when setting up a service with scoped lifetime and can cause bugs that are really cryptic to figure out (especially since the behavior can vary depending on the order in which services are defined in the constructors of the services they are injected into).
This seems to happen only when resolving services that are setup as "http clients" following the instructions in the following documentation: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-requests?view=aspnetcore-2.2
This is a bit tedious to explain, but Ill try my best here. I am using Azure Functions V2 (.Net Core 2.2 & Microsoft.Extensions.Http 2.2.0). For the purposes of the following scenarios assume I have the following:
public class Functions
{
    private readonly IScoped1 scoped1;
    public Functions(IScoped1 scoped1)
    {
        this.scoped1 = scoped1;
    }
    [FunctionName("Function1")]
    public async Task<IActionResult> Run(
        [HttpTrigger(AuthorizationLevel.Anonymous, "get", "post", Route = null)] HttpRequest req,
        ILogger log)
    {
        log.LogInformation("C# HTTP trigger function processed a request.");
        return new OkObjectResult($"Hello");
    }
}
public interface IScoped1 { }
public class Scoped1 : IScoped1
{
    private readonly IScoped2 scoped2;
    private readonly IHttpClient1 httpClient1;
    private readonly IHttpClient2 httpClient2;
    public Scoped1(IScoped2 scoped2, IHttpClient1 httpClient1, IHttpClient2 httpClient2)
    {
        Console.WriteLine($"{this.GetType().Name}()");
        this.scoped2 = scoped2;
        this.httpClient1 = httpClient1;
        this.httpClient2 = httpClient2;
    }
}

public interface IScoped2 { }
public class Scoped2 : IScoped2
{
    public Scoped2()
    {
        Console.WriteLine($"{this.GetType().Name}()");
    }
}

public interface IHttpClient1 { }
public class HttpClient1 : IHttpClient1
{
    private readonly HttpClient httpClient;
    private readonly IScoped2 scoped2;
    public HttpClient1(HttpClient httpClient, IScoped2 scoped2)
    {
        Console.WriteLine($"{this.GetType().Name}()");
        this.httpClient = httpClient;
        this.scoped2 = scoped2;
    }
}

public interface IHttpClient2 { }
public class HttpClient2 : IHttpClient2
{
    private readonly HttpClient httpClient;
    private readonly IScoped2 scoped2;
    public HttpClient2(HttpClient httpClient, IScoped2 scoped2)
    {
        Console.WriteLine($"{this.GetType().Name}()");
        this.httpClient = httpClient;
        this.scoped2 = scoped2;
    }
}

Scenario 1: If NOT using AddHttpClient the scoped lifetimes work as expected.
In this case I setup my http client services as simple Transients:
        builder.Services.AddScoped<IScoped1, Scoped1>();
        builder.Services.AddScoped<IScoped2, Scoped2>();
        builder.Services.AddTransient<IHttpClient1, HttpClient1>();
        builder.Services.AddTransient<IHttpClient2, HttpClient2>();

With this setup when I call the "Function1" httptrigger through POSTMAN I see the expected sequence of service instantiations:

Scoped2()
HttpClient1()
HttpClient2()
Scoped1()

Scenario 2: If using AddHttpClient then scoped lifetime services can be instantiated more than once per request.
In this case I setup my http client services with AddHttpClient following the documentation I referenced above:
        builder.Services.AddScoped<IScoped1, Scoped1>();
        builder.Services.AddScoped<IScoped2, Scoped2>();
        builder.Services.AddHttpClient<IHttpClient1, HttpClient1>();
        builder.Services.AddHttpClient<IHttpClient2, HttpClient2>();

With this setup when I call the "Function1" httptrigger through POSTMAN I see the unexpected re-instantiations of class Scoped2:

Scoped2()
Scoped2() --> This should be reusing the previous instantation of Scoped2
HttpClient1()
Scoped2() --> This should be reusing the previous instantation of Scoped2
HttpClient2()
Scoped1()

Additional to this example if I switch around the order of the parameters in the constructor of class "Scoped1" I also see different unexpected instantiation sequences. After playing around with this for a while I believe what is happening is that each time an "http client" service is resolved for the very first time in the lifetime of a request, it seems to clear any services that may have already been resolved in the scoped lifetime up to that point. However if that same service is resolved a 2nd+ time (within the same request lifetime) then it no longer seems to clear the scoped lifetime services.
Is this a known issue or am I misunderstanding something?
Thanks
Software versions
Check the .NET target framework(s) being used, and include the version number(s).

[X] .NET Core (v2.2) through Azure Functions V2
[ ] .NET Framework
[ ] .NET Standard

If using the .NET Core SDK, include dotnet --info output. If using .NET Framework without the .NET Core SDK, include info from Visual Studio's Help > About Microsoft Visual Studio dialog.

dotnet --info output or About VS info
<replace>

@pranavkm @mkArtakMSFT  can one of you transfer this if appropriate? If no, please respond.

After further experimentation on this I believe I have narrowed down the scenario where this issue surfaces. Anytime the HttpClientFactory internally determines that it needs to generate a new HttpClientMessageHandler it seemingly wipes out whatever scoped lifetime service instances were already instantiated at the time. Otherwise if the HttpClientFactory creates a new instance of HttpClient but without creating new HttpClientMessageHandlers then the scoped lifetime services remain intact.
This would explain why on the first resolution of HttpClients in my sample code above it forces re-instantiation of Scoped2 and on the 2nd+ resolution it doesn't... that is until some time later when the HttpClientFactory determines it must create new MessageHandlers again. At that point the scoped services are wiped out again.

Hi folks, any follow-up on this during the past months? Has someone had a chance to confirm & investigate further?
Thanks!

Ping @rynowak

@rynowak have you had a chance to confirm this behavior?
Thanks!

I believe I provided all the needed details. If the behavior is indeed as I described it blocks me from using HttpClient services since I will not have control over this behavior and it causes random failures for my solution. I would appreciate if there could be some updates here since it has been a while now.
Thanks!


Use vswhere to find Visual C++ in Windows

Description
A clear and concise description of this pull request.
Visual Studio provides vswhere to make it easier to find the path of a file provided by Visual Studio.
We should use it to find vcvarsall.bat instaed of designating its path directly.
Issue IDs
Issue and/or discussion IDs related to this pull request.
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).

OS: Windows
Steps:

cd src
Run sub commands of python ./build_mozc.py

Additional context
Add any other context about the pull request here.
We won't need to make extra changes for newer Visual Studio in the future anymore.

Thank you for your pull request. While I agree that vswhere is a nice tool we can rely on, I’m leaning towards revisiting this after we complete the migration to bazel as being tracked in #948. Feel free to resend the pull request once #948 is completed and build_mozc.py is completely removed.

We won't need to make extra changes for newer Visual Studio in the future anymore.

It’s highly unlikely that we can support any newer version of Visual Studio as long as we keep using GYP, which is no longer actively developed.

build_mozc.py is completely removed.

vs_uti.py will be also unnecessary after that, I think.


refactor: move isDeposit into BlockController

I think this refactor simplifies the code as well as adding the extra check that the block exists: it removes the isDeposit library, reduces the size of the Controller structs and makes the code a bit easier to read.
I don't feel super strongly about it though - I'm happy to leave it as it is if we think the current way is better.

Closes #466


Enable install-powershell.ps1 to work from powershell-daily folder

To make it easier to selfhost daily:

removed [validate] attribute from parameter so this script can be invoked directly from web.
This doesn't have any negative impact as the $Destination parameter will have default value if null or empty.
moved removal of destination folder later as installing the package requires packagemanagement module and archive module (on Windows)
on Windows, because files have open handles when run from existing powershell-daily install, I rename the existing files and copy over the new ones.  User needs to exit and restart pwsh to take effect (similar to macOS/Linux where you have to exit and restart anyways)

restarted macOS ci

Still testing, don't merge yet

Working for me.  I think it's ready to go.


Elixir 1.3 / OTP 19 compatibility

The change is tested locally by me, as I tried getting IElixir to work -- but unfortunately it introduces an error in one of the doctests (lib/ielixir/sandbox.ex:102):
      iex> IElixir.Sandbox.execute_code(%{"code" => "\"a\" + 5"})
      {:error, "ArithmeticError", ["** %ArithmeticError{}"]}

..where the error output is apparently more detailed in Elixir 1.3:
  1) test doc at IElixir.Sandbox.execute_code/1 (6) (SandboxTest)
     test/sandbox_test.exs:5
     Doctest failed
     code: IElixir.Sandbox.execute_code(%{"code" => "\"a\" + 5"}) === {:error, "ArithmeticError", ["** %ArithmeticError{}"]}
     lhs:  {:error, "ArithmeticError",
            ["** %ArithmeticError{message: \"bad argument in arithmetic expression\"}"]}
     stacktrace:
       lib/ielixir/sandbox.ex:102: IElixir.Sandbox (module)

I'm not sure of the best way to resolve this; if I change it, then it'll fail in earlier Elixir versions instead.

Coverage remained the same at 46.97% when pulling abbea748aab30b472cbc79402cb0758e4a820bfb on jwarlander:elixir-1.3-compat into ed3808c82be5377c33d379ba272508fa5743ab13 on pprzetacznik:master.

Sorry, had to push these commits again w/ correct email address :)

Coverage remained the same at 46.97% when pulling dfbda64b317cf82d1743000944d442b26a6bf5a2 on jwarlander:elixir-1.3-compat into ed3808c82be5377c33d379ba272508fa5743ab13 on pprzetacznik:master.

@jwarlander Thanks for that!
I think it's ok to abandon support for older OTP versions, I will try to rewrite this example but I cannot ensure that we can do that forever.


chore: fix typo on about page

Fixed the typo on the about page. From Explore what Dallas Software Developers as to offer  to  Explore what Dallas Software Developers has to offer.

Thank you


Refactor resource inheritance ver2

This PR contains rebased and updated versions of the refactor work in https://github.com/ARMmbed/mbed-client/pull/459

Merging to memory_optimizations -branch to get CI's opinion of it. If objections arrive, this content can be removed easily.


Knot-dns backup gives error: (unknown system error)

Describe the bug
Backup does not work correctly
Steps To Reproduce
$ knotc zone-backup +backupdir /var/spool/backup
error:  (unknown system error)

Expected behavior
Expected is to create a backup.
Additional context
There is nothing more in logs, even with debug level enabled.
Notify maintainers
@vcunat
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.0-31-generic, NixOS, 24.11 (Vicuna), 24.11pre650378.655a58a72a66`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.4`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Could you show us the output from strace knotc zone-backup +backupdir /var/spool/backup ?

As far as I can understand knotc is a client to knotd only, and that error message comes from knotd process - and I have no idea how to strace a server process in Nix :)

You are right, but still the error can come from knotc itself.

strace can attach to any process that's running already, if you have sufficient permissions
sudo strace -p "$(pidof knotd)"

That's cool, I had no idea that it's possible!
strace: Process 3919 attached
restart_syscall(<... resuming interrupted read ...>) = 0
poll([{fd=38, events=POLLIN}], 1, 5000) = 1 ([{fd=38, revents=POLLIN}])
accept4(38, NULL, NULL, SOCK_NONBLOCK)  = 39
recvmsg(39, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\1\20\0\vzone-backup\21\0\0\32\0\21/var/spool/"..., iov_len=262144}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, MSG_DONTWAIT|MSG_NOSIGNAL) = 43
sendmsg(6, {msg_name={sa_family=AF_UNIX, sun_path="/run/systemd/journal/socket"}, msg_namelen=30, msg_iov=[{iov_base="PRIORITY=6", iov_len=10}, {iov_base="\n", iov_len=1}, {iov_base="MESSAGE=info: control, received "..., iov_len=53}, {iov_base="\n", iov_len=1}, {iov_base="SYSLOG_IDENTIFIER=", iov_len=18}, {iov_base="knotd", iov_len=5}, {iov_base="\n", iov_len=1}], msg_iovlen=7, msg_controllen=0, msg_flags=0}, MSG_NOSIGNAL) = 89
newfstatat(AT_FDCWD, "/var/spool/backup", {st_mode=S_IFDIR|0755, st_size=0, ...}, 0) = 0
newfstatat(AT_FDCWD, "/var/lib/knot", {st_mode=S_IFDIR|0700, st_size=368, ...}, 0) = 0
newfstatat(AT_FDCWD, "/var/lib/knot/catalog/data.mdb", 0x7ffe52a401a0, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/var/lib/knot/journal/data.mdb", {st_mode=S_IFREG|0660, st_size=176128, ...}, 0) = 0
newfstatat(AT_FDCWD, "/var/lib/knot/keys/data.mdb", {st_mode=S_IFREG|0660, st_size=69632, ...}, 0) = 0
mkdir("/var/spool/backup", 0770)        = -1 EEXIST (File exists)
newfstatat(AT_FDCWD, "/var/spool/backup", {st_mode=S_IFDIR|0755, st_size=0, ...}, 0) = 0
newfstatat(AT_FDCWD, "/var/spool/backup/knot_backup.label", 0x7ffe52a40050, 0) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/var/spool/backup/lock.knot_backup", O_RDONLY|O_CREAT|O_EXCL, 0660) = -1 EROFS (Read-only file system)
sendmsg(6, {msg_name={sa_family=AF_UNIX, sun_path="/run/systemd/journal/socket"}, msg_namelen=30, msg_iov=[{iov_base="PRIORITY=3", iov_len=10}, {iov_base="\n", iov_len=1}, {iov_base="MESSAGE=error: backup init faile"..., iov_len=56}, {iov_base="\n", iov_len=1}, {iov_base="SYSLOG_IDENTIFIER=", iov_len=18}, {iov_base="knotd", iov_len=5}, {iov_base="\n", iov_len=1}], msg_iovlen=7, msg_controllen=0, msg_flags=0}, MSG_NOSIGNAL) = 92
sendmsg(39, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\1\20\0\vzone-backup\21\0\0\22\0\24unknown sys"..., iov_len=66}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, MSG_NOSIGNAL) = 66
recvmsg(39, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\0", iov_len=262144}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, MSG_DONTWAIT|MSG_NOSIGNAL) = 1
close(39)                               = 0
poll([{fd=38, events=POLLIN}], 1, 5000) = 0 (Timeout)
poll([{fd=38, events=POLLIN}], 1, 5000^Cstrace: Process 3919 detached

So it looks that knotd process thinks that directory /var/spool/backup is read only.

The error EROFS means that the file system is mounted read only. You are right that that error isn't handled by Knot and you would get unknown system error only. We will fix that.
Bear in mind that the directory specified by the +backupdir parameter is the backup itself (a Knot backup is a directory hierarchy), it isn't a directory into which you want create various backups.

I'm sorry, I don't understand the second part. According to https://www.knot-dns.cz/docs/3.3/html/operation.html#online-backup a user can specify an empty directory when he want to create a backup. As far as I can understand, some nixos policies are preventing the knotd process from writing into the directory which user specifies at his will. Do I understand it incorrectly?

Yes, you can specify any directory - either already existing (it should be empty) or a directory which is to be created. My impression was that it isn't your goal to create a single backup as /var/spool/backup, it just looks unusual.

OK, so it was an empty directory which was created for a backup, sorry for confusion.
Thank you for working on this.

Ah, systemd hardening probably.  The NixOS unit specifies ProtectSystem = "strict"; 🤦🏽
My personal opinion is that we have permissions for this, but some people just prefer to restrict everything and only add exceptions once issues are encountered.

I think this is possible to override in NixOS config by
  systemd.services.knot.serviceConfig.ProtectSystem = lib.mkForce "true";

systemd.services.knot.serviceConfig.ProtectSystem = lib.mkForce "true";

$ knotc zone-backup +backupdir /var/spool/backup
OK

Is it the final solution, can I safely keep it nixos configuration?

There's nothing unsafe about it, at least in the sense that it's "normal" not to have ProtectSystem at all.  I think I'll suggest this option for default in NixOS systemd.services.knot.

Thank you, so my problem is solved, thank you for fantastic help!


chart line border color

Expected Behavior

borderColor should be as per the list of colors
Current Behavior

borderColor is all red
Possible Solution

Environment

Chart.js version:3.5
Browser name and version:Chrome
Link to your project:

The borderColor does apply correctly, if you want each line segment to have a different color you can use segments: https://jsfiddle.net/Leelenaleee/5hudx6n9/6/

Hello to all the people in the thread. I am new to this issue and this environment.
@bucibucii, you are trying to draw a line chart, and the whole chart has 1 color. If you try to change that red color with, let's say, orange, then the whole line chart is displayed with orange-color border.
The concept of borderColor will work with bar charts of different kinds, but in line charts, it will be of one color.
Link with the updated borderColor: https://jsfiddle.net/ydkzh1sv/
If you are looking for making dots with different colors, then have a look at https://stackoverflow.com/a/46733321
Hope this helps!

@bucibucii Refer to the code in Config section under data.segment.
Refer https://www.chartjs.org/docs/latest/samples/line/segments.html

In version 3.5 is working well. In version 3.3.2 is not working as expected.
There was a cache of 3.3.2 in my node modules. I had to uninstall and reinstall again.
Now is working fine :)


fix: age calculation respecting pflanzjahr=0 and preprocess trees data

age calculation respecting pflanzjahr=0
remove generation of trees subfiles, not used anywhere
split into harvester.py and mapbox-tree-update.py
preprocess trees.csv with tippecanoe
check for Tileset generation success

merging as discussed with @ff6347


Add Cosigner capabilities to the multisig

This change will need to change the creation of multisig. At this stage, we need to provision spending limits and 2FA. It can be blocking.
This should refactor also the signing implementation to better separate domains.
When signing we need to decode the raw transaction and detect if m signatures provided (eg. 3 if it's a 3-of-5). If m-1 sigs provided we should check if also matching 2FA provided and satoshis to spent are less than the spending limit.

The spending limits and other infos are per-multisig. What you point is the creation of the wallet of the Vault instance used to get a key pair to be used in a multisig, so not correct to save that.
If we call each multisig p2sh address the wallet it's more useful to save the scriptSigHash or the public key provided in order to authorize future request


[CosmosDB] Removing PITR commands and adding Services and Graphs commands

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

CosmosDB

/azp run

@evelyn-ys do you know what is the reason of the failure in this https://dev.azure.com/azure-sdk/public/_build/results?buildId=1111224&view=logs&j=ccdac6d3-465a-5ada-8819-d5b4a6b3a631&t=ffdbba7d-e523-5908-c7bf-0703bafb81b0

@evelyn-ys do you know what is the reason of the failure in this https://dev.azure.com/azure-sdk/public/_build/results?buildId=1111224&view=logs&j=ccdac6d3-465a-5ada-8819-d5b4a6b3a631&t=ffdbba7d-e523-5908-c7bf-0703bafb81b0

It's because no help entry was found for command group cosmosdb graph and cosmosdb service

@evelyn-ys please merge if it looks good to you. TIA

@evelyn-ys please merge if it looks good to you. TIA

Can you pls address the linter failure?

	"az cosmosdb service create --resource-group MyResourceGroup --account-name MyAccount --service-name "graphApiCompute" --service-kind "GraphApiCompute" --count 1 --size "Cosmos.D4s"" is not a valid command.
	the following arguments are required: --kind/-k, --name/-n

    Help-Entry: `cosmosdb service delete` -
	There is a violation:
	"az cosmosdb service delete --resource-group MyResourceGroup --account-name MyAccount --service-name "sqlDedicatedGateway"" is not a valid command.
	the following arguments are required: --name/-n.

    Help-Entry: `cosmosdb service update` -
	There are 2 violations:
	"az cosmosdb service update --resource-group MyResourceGroup --account-name MyAccount --service-name "sqlDedicatedGateway" --service-kind "SqlDedicatedGateway" --count 3" is not a valid command.
	the following arguments are required: --name/-n, --kind/-k

	"az cosmosdb service update --resource-group MyResourceGroup --account-name MyAccount --service-name "graphApiCompute" --service-kind "GraphApiCompute" --count 1" is not a valid command.
	the following arguments are required: --name/-n, --kind/-k


Cannot read property 'lines' of undefined

I have coverage gutters v2.9.1
I am generating code coverage for Erlang using rebar3, then converting the output to Cobertura using https://github.com/covertool/covertool.
The top of the stack is..
[1643108745489][coverageparser][cobertura-parse]: Stacktrace: TypeError: filename: //Dev/game/X/_build/test/covertool/X.covertool.xml Cannot read property 'lines' of undefined
at extractLcovStyleBranches (/***/.vscode-server/extensions/ryanluker.vscode-coverage-gutters-2.9.1/node_modules/cobertura-parse/source/index.js:30:12)
at //.vscode-server/extensions/ryanluker.vscode-coverage-gutters-2.9.1/node_modules/cobertura-parse/source/index.js:77:24
at Array.map (:null:null)
at unpackage (//.vscode-server/extensions/ryanluker.vscode-coverage-gutters-2.9.1/node_modules/cobertura-parse/source/index.js:75:20)
at //.vscode-server/extensions/ryanluker.vscode-coverage-gutters-2.9.1/node_modules/cobertura-parse/source/index.js:134:22
at Parser. (//.vscode-server/extensions/ryanluker.vscode-coverage-gutters-2.9.1/node_modules/xml2js/lib/parser.js:303:18)
Which, I believe, indicates that the c (class) object passed to extractLcovStyleBranches is undefined.  Which seems to indicate that the array returned by classesFromPackages has included an 'undefined' element.
I checked classesFromPackages, and compared to the XML I have, which looks like (cut down, removed identifiers, etc)
<coverage timestamp="1643107972566" line-rate="0.564" lines-covered="1598" lines-valid="2832" branch-rate="0.0" branches-covered="0" branches-valid="0" complexity="0" version="<IP_ADDRESS>">
  <sources>
      ...
  </sources>
  <packages>
    <package name="X" line-rate="0.0" branch-rate="0.0" complexity="0">
      <classes/>
    </package>
    <package name="P" line-rate="0.026" branch-rate="0.0" complexity="0">
      <classes>
        <class name="C" filename="..." line-rate="0.026" branch-rate="0.0" complexity="0">
          <methods>
            <method name="M" signature="S/5" line-rate="0.0" branch-rate="0.0">
              <lines>
                <line number="145" hits="0" branch="False"/>
                ...
              </lines>
            </method>
          </methods>
          <lines>
            <line number="15" hits="0" branch="False"/>
             ...
          </lines>
        </class>
      </classes>
    </package>
    ...
  </packages>
</coverage>

If I remove all the packages with no classes, e.g.
<package name="X" line-rate="0.0" branch-rate="0.0" complexity="0">
  <classes/>
</package>

Then it works without error.

@reganheath Thanks for the issue, I will try to dig into it for yeah soon.
To give you something high level to try out, I know cobertura has been annoying for some to get working, so if you are able to use lcov or clover formats for coverage instead... that would be preferable.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/src/files/coverageparser.ts#L1-L4
I also found this person setup with erlang and the extension with a lcov generate they built. I am no erlang expert though so it might not work with rebar3 🤔 .
https://elixirforum.com/t/lcovex-lcov-file-generator-for-elixir-projects/32057
Maybe that will help?

@ryanluker Hi, thanks.  No rush on this.  GitLab itself handles the coverage data, so we've got that and I can easily write a small script to clean it up for coverage gutters.  Thanks!

@reganheath I might close this ticket then as eventually Cobertura will be deprecated given it isn't maintained anymore and will slowly rot... https://github.com/vokal/cobertura-parse Most of the issues that show up like this are due to bugs not being fixed in the upstream package.
We even had to pin the package to a specific commit to get what we needed 😓 .
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L281
If we could find a different js / ts package for consuming Cobertura style coverage... then we should definitely switch to that!

@reganheath I believe this is fixed with https://github.com/ryanluker/vscode-coverage-gutters/pull/360 possibly.
Keep an eye out for this fix in the 2.10.0 release, otherwise we can always open this ticket again if it didn't help.

@ryanluker Hi, unfortunately the bug persists in v2.10.1 unchanged (same stack, same cause, same result).

I have created a patch: https://github.com/fschwaiger/cobertura-parse/pull/1

@reganheath Thanks for the heads up!
Once it is merged in the upstream repo we can update the version here, and it will go out in the next release.

Any file with a package with no classes will do, e.g.
<package name="X" line-rate="0.0" branch-rate="0.0" complexity="0">   <classes/> </package>

@reganheath This will be fixed in the 2.11.0 release!

@reganheath I just saw that 2.11.0 has a bunch of stuff in it already 😅 if this ends up taking longer than a month to finish, I will do a smaller release to get this stuff out and into the marketplace store.

@reganheath sorry for the delay, 2.10.2 is going out now and includes the cobertura fix.


Doesn't have OpenGL/Vulkan Natives

"net.minecraftforge.fml.common.LoaderException: java.lang.UnsatisfiedLinkError: no /libvulkan-mod-native in java.library.path"
I do realize this is in pre-alpha state but I'd like to give it a try, so could you provide the natives it needs
thanks
crash-2016-05-08_12.20.16-client.txt

So, a few things.
First, I've just pushed a major update. I switched from Forge to MCP because Forge wasn't loading my libraries correctly. I switched from Vulkan to OpenGL 4.5 because Vulkan is complicated and OpenGL is way easier to set up.
Second, this project is in no way ready for use. Currently, all it does is create a texture atlas from Minecraft's textures and send them to the native code, and create a window from the native code. If you run it, you'll be disappointed.
Third, I don't want to provide binaries because they're large and don't work well with Git and providing binaries implies some sort of release, and this code is no where near release. However, you can build the binaries yourself. The C++ code is structured in a CMake project, so you can use that to generate build files for your favorite C++ compiler, then compile the libraries yourself.
However, even that won't get the code to run. I've made a few changes to the MC source code to add in hooks for my code, but I haven't pushed those to this repository because the Minecraft and MCP licenses definitely forbid distributing Minecraft's source code. When this software is closer to release, I'll make a nice installer to perform my changes on Minecraft itself, but until then you'll have to try to follow my changes in the changes file.

Oh, ok I was just wondering , I didn't know if it was in running state or not , someone linked this on a Reddit post , and I wanted to test out performance differences , but I guess I'm bit too early to party. I'll keep following project , and see where it goes cause Minecraft needs a newer render cause OpenGL 2.1 is very old dated  ( Also I'm not huge into coding but I could see problems using Vulkan since its brand new and its not documented that well ). But like I said sorry if I bothered you , I just wanted to see if I could test it

Sorry, it's just too early in development to have anything worth showing.


numpy.ones --> np.ones to match with the imports

To match with the import on line 2.

Coverage remained the same at 100.0% when pulling e44ae2f2297dec107915c63640d4019e45d0b190 on cclauss:patch-1 into a295340170766742026f785915c64e901cd055ce on astorfi:master.

Coverage remained the same at 100.0% when pulling e44ae2f2297dec107915c63640d4019e45d0b190 on cclauss:patch-1 into a295340170766742026f785915c64e901cd055ce on astorfi:master.

@cclauss Thanks for your observation.


Unlock Ape Tape :D

I wish we could :smile: I'm afraid we can't make that happen. It's still unclear what Ape Tape was, and whether any firmware ever contained working code for it. The recent firmware versions no longer have the Ape Tape SVG file so it's likely been removed entirely.


Search result in popup

Hi There,
I am looking to replace my existing search option with Algoia but i am not able to find any widget where search result display in popup as attached, can you please here?

Thanks,
VIneet

Please reproduce the issue in this Autocomplete.js sandbox and we'll try to debug it together.

You used syntax that doesn't work in older browsers:
            suggestion({ url, image, showFrom, starimage, _highlightResult, colours }) {
                return `

${_highlightResult.h1name.value}

${showFrom} £${_highlightResult.price.value}

 `;
                //return `<span>${_highlightResult.name.value}</span><span>${_highlightResult.h1name.value}</span>`;
            }
        }

should for example be:
            suggestion: function suggestion({ url, image, showFrom, starimage, _highlightResult, colours }) {
                return "

"+_highlightResult.h1name.value+"

"+showFrom+" £"+_highlightResult.price.value+"

 ";
                //return `<span>${_highlightResult.name.value}</span><span>${_highlightResult.h1name.value}</span>`;
            }
        }

you can check out babel for your projects to make sure it works in all browsers

I have applied your suggestion and its working with chrome fine but its still not working on safari and iPhone. it showing error as below:

Please reproduce the issue in this Autocomplete.js sandbox and we'll try to debug it together.

Above mentioned url is not working on safari browser

Which version of Safari are you using?

Based on the error, you probably need to load a Promise polyfill.

Closing for inactivity.


[Docs]  fix typos

critcal => critical

thanks, i also fixed the script responsible for the type here: a1bdbfc6d29025855ad2a73ae0021d1662db6779