table 'aws_ssoadmin_account_assignment' - feature request

Is your feature request related to a problem? Please describe.
Unable to list multiple targeted AWS account ID and PermissionSets with respective users in a single table
(tried my best below to provision the table but missing qualifications 'permission_set_arn' and 'target_account_id'.
Describe the solution you'd like
Would like to display on AWS IAM Identity Center -> AWS Accounts with associated PermissionSets and Users
Describe alternatives you've considered
I am trying to overcome the limitation of table 'aws_ssoadmin_account_assignment' , is there a way in the 'WHERE' statement to allow multiple subqueries?
Currently AWS SSO doesn't have a centralized dashboard, if steampipe could work, it will definitely boost the usage for those using AWS Identity Center (formally AWS SSO) =)
I am stuck at the last 'WHERE' statement to allow multiple AWS targeted_account_ID and PermissionSets to be ingested within the master IAM Identity Center account :
  with orgs as (
    SELECT DISTINCT id FROM aws_master.aws_organizations_account
  )
  ,
  aws_ssoadmin_principal as (
  select
    i.arn as instance_arn,
    'GROUP' as "type",
    g.id,
    g.title
  from
    aws_master.aws_ssoadmin_instance i
    left join aws_identitystore_group g on i.identity_store_id = g.identity_store_id
  union
  select
    i.arn as instance_arn,
    'USER' as "type",
    u.id,
    u.title
  from
    aws_master.aws_ssoadmin_instance i
    left join aws_identitystore_user u on i.identity_store_id = u.identity_store_id
)
SELECT
  a.name as AWSAccountName,
  a.id as AccountID,
  u.title as User,
  g.type as Type,
  p.name as PermissionSet
FROM
  aws_master.aws_organizations_account a
  LEFT JOIN aws_master.aws_ssoadmin_account_assignment aa ON aa.target_account_id = a.id
  JOIN aws_ssoadmin_principal u ON u.id = aa.principal_id
  LEFT JOIN aws_ssoadmin_principal g ON g.id = u.id
  JOIN aws_master.aws_ssoadmin_permission_set p ON p.arn = aa.permission_set_arn
WHERE
    target_account_id IN(SELECT id FROM orgs)
    AND permission_set_arn  IN(SELECT arn
    FROM aws_master.aws_ssoadmin_permission_set);

if the last WHERE statement is input with a specific target ID and PermissionSet, it works well !
But it is not for multiple AWS 'target_account_IDs' and 'PermissionSets'.
Will there be any updates to the table 'aws_ssoadmin_account_assignment' in near future?
Thanks so much!
Additional context
Add any other context or screenshots about the feature request here.

Managed to work around with SQL Query finding to list whole AWS Organization AWS accounts and PermissionSets with IAM Users/Group associated with it.

Hi Steampipe team, with the query working but the response load is v v slow. There are 5 tables to cross-relates to

https://hub.steampipe.io/plugins/turbot/aws/tables/aws_organizations_account
https://hub.steampipe.io/plugins/turbot/aws/tables/aws_ssoadmin_instance
https://hub.steampipe.io/plugins/turbot/aws/tables/aws_identitystore_user
https://hub.steampipe.io/plugins/turbot/aws/tables/aws_identitystore_group
https://hub.steampipe.io/plugins/turbot/aws/tables/aws_ssoadmin_permission_set

Can i humbly submit for a new feature request on AWS Identity Center queries where 1 single API can co-related to 5 tables directly?
The output will show like this:

@ahkai86, I appreciate your patience & input on this use case. Thank you! This is a bit experimental area for sure.
Just wanted to clarify, Do you want us to look into the provided SQL query and explore  [1] the possibility of optimisation, or do you like us to consider any [2] design change where we can use one table with all related data to provide a smooth experience to query for such use-cases?
Option 2 may lead to many other considerations to ensure this is not binding users to address only fewer use-cases and performance limiting etc.
Feel free to submit PR (if any from your side) or provide more input in the feature request, which will give more insight to the team reviewing, testing and engaging further in case we need any decisions to proceed.

Hi @rajlearner17,
Good Day! Thanks for the follow up, option [2] will be much useful and easier for users to get the required information for AWS IAM Identity Center, as AWS has undocumented API to retrieve all those info.
and AWS IAM Identity Center only gets information from 1 aws master account, theoretically i think it shouldn't traverse through the rest of the AWS accounts to get the necessary information except the master account for AWS Identity Center.
As for now on option [1], i tried various ways to optimize and encountered alot of impediments with SQL tables correlating with different tables.
Additionally, I tried to run the sql query twice and the 2nd time will just hang there, meaning i can only run once per SQL query when steampipe query dashboard is executed via "steampipe dashboard"

Just referencing the other issue with the same context https://github.com/turbot/steampipe-plugin-aws/issues/1723

Hey @ahkai86, At Steampipe, our standard practice is maintaining a one-table-per-resource model. This design choice is intentional to ensure that each table is easy to understand and use, and it helps to keep the execution times as efficient as possible.
Combining multiple resources into a single table might seem like a solution for correlating data more directly. Still, it could significantly increase the table's complexity and the query execution time.
@cbruno10 your thoughts?

We are closing this issue as we will not be creating a multi-API table. However, we encourage you to reopen this issue if you would like to share your query; we're more than happy to assist with its optimization.


[BugFix] Add Transport Security Settings in info.plist

Purpose

Fix the issue using communicationTokenFetchUrl in AppSetting.plist would cause the error: [The resource could not be loaded because the App Transport Security policy requires the use of a secure connection]

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Just found the error prompting [The resource could not be loaded because the App Transport Security policy requires the use of a secure connection] is because my url token is inputted with http:// by accident.
Close this PR then


PCB Render issues umbrella

Examples of rendering issues which don't already have a dedicated ticket.

SparkFun wavtrigger_v11.brd
A white dot/line is visible between the PW_R-PDSO-G20's 1st and 2nd pins (top right)--it doesn't seem to appear on any layer in the .brd file:

These solder jumpers render oddly, might be another instance of #33:


Update user.ts

repositories inside tasks and transactions must use the current context, the same as everywhere else.

Vitaly, I'm seriously impressed about your dedication to your library, your care of it here and at stackoverflow! Many thanks to you. this.providerRepo was formatting and outputting queries, not executing them, so technically it was not a bug, but it was a bad code for sure!


Add libdefs for styled-components

I just started using styled-components and flow yesterday, however, it seems that the current ThemeProvider error is easily fixed by adding typeof to module.exports:
declare module.exports: {
  ...
  ThemeProvider: typeof ThemeProvider,
  ...
}

After adding this there still remains an issue with interpolation in tagged template literals. This might be related to facebook/flow#2616. Maybe someone else knows how to deal with this issue?

@favll Thanks, looks like it works now :)

I'm still getting a Not covered by Flow warning when using an expression interpolation with a tagged template literate. Flow does not seem to know what tagged template literates evaluate to.
So while the current libdef is correct, shouldn't an alternative definition be shipped until flow fully supports expression interpolations and tagged template literates?

Do you have an example? For this snippet I get 100% coverage
// t.js
import styled from "styled-components"

const Center = styled.div`
  text-align: center;
`

export default () => <Center>👋</Center>

$ flow coverage t.js
Covered: 100.00% (6 of 6 expressions)

// @flow
//
import styled, { ThemeProvider } from 'styled-components'

const theme = {
  background: "papayawhip"
}

const Title = styled.h1`
  background-color: ${({theme}) => theme.background};
`;

const Component = () => (
  <ThemeProvider theme={theme}>
    <Title>Hello World, this is my first styled component!</Title>
  </ThemeProvider>
)

$ flow coverage sc-test.js
Covered: 80.00% (12 of 15 expressions)

I just looked at this again and I noticed that the problem is not with tagged template literates but rather with object destructuring. Flow does not know that the object passed to the expression interpolation has a theme property. And even if it would know that the object had a theme property it wouldn't know that it has the type Theme. So basically Flow doesn't know that ThemeProvider injects theme into its children and it doesn't know that the props passed to a styled component can be used in the expression interpolation.

Ah, that makes sense. I have no idea if we can creates libdefs that fixes that?

Thanks for the defs!
One thing, this doesn't seem to work with stateless/function components being passed to styled(...).
E.g.
const Wrapper = styled(({ height, ...props }) => <SomeComponent {...props} />)`
  height: ${(props) => props.height}px;
`;

results in
 33: const Wrapper = styled(({ height, ...props }) => <SomeComponent {...props} />)`
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ arrow function. This type is incompatible with the expected param type of
 31:     (baseComponent: React$Component<*, * , *>): StyledComponent,
                         ^^^^^^^^^^^^^^^^^^^^^^^^^ React$Component. See lib: flow-typed/npm/styled-components_v1.4.x.js:

which is a very common idiom to prevent props used for styling being passed to underlying component (think that is fixed in v2)

I've changed it to
(baseComponent: React$Component<*, *, *> | (props: any) => ?React$Element<*>): StyledComponent,

for now but there's probably better ways to do that.
E.g. looking at https://github.com/flowtype/flow-typed/blob/master/definitions/npm/react-redux_v5.x.x/flow_v0.30.x-/react-redux_v5.x.x.js#L33-L36 which seems like a similar concert, but I don't understand that declaration.

Is there anything planned for styled-components v2.0?

any progress on this?


git show operation (git show sha --name-only)

I am looking for the option to get file paths for particular commit sha
I tried with this code and getting all the files from the branch instead of committed files from the sha(like "675a60f98181fe81f8741aef4037b095292d3b9c")
        const commit = await repo.getCommit("675a60f98181fe81f8741aef4037b095292d3b9c"); //specific commit sha
         const tree = await commit.getTree();
        tree.entries().forEach(function(entry) {
          console.log("Index Entry:", entry.path());
        });
I

I would like to know is there any code available for git show option, I couldn't find any so far.
Thanks,
Bharath

@softbharath This code should do what you want. Note that you should test the deletion case as I'm not sure what newFile() will return in that case.
return commit.getDiff()
.then(function(diffList) {
  diffList.forEach(function(diff) {
    diff.patches().then(function(patches) {
      patches.forEach(function(patch) {
        console.log(patch.newFile().path());
      });
    });
  });
});


AEM CMS: Card in Card Component Update for CSS

CMS AEM team noticed that the title is slightly different to the other block cards and pascal found that this is a difference in one line of the css. we need to request them to change it to match the other block cards.
Card in Card: var(--cds-expressive-heading-03-font-size, 1.25rem)
Content Card: calc(1.25rem + 0.25 * ((100vw - 82rem) / 17))
Fix (min-width: 99rem) font-size: 1.5rem for card in card
class: dds-card-heading
This should be a minor change in our estimation.

Hi Sandeep! We have this bug captured https://app.zenhub.com/workspaces/carbon-for-ibmcom-5d449f3642eb1962336cbe52/issues/carbon-design-system/carbon-for-ibm-dotcom/5984
It's currently scheduled for Sprint 19 but I will see if we can rush it a bit. Thanks!


"Press to close the door" button

I love how we can now open the doors!
One question about the aft door. There's a button saying "Press to close the door" as seen in the linked screenshot below. Any chance that button could be used also in the mod to close the door? Rather than trying to "grab" the handle when the door has been opened.
https://i.imgur.com/RhXuyIL.jpg

This button is part ob cockpit object and not separated. Given the free time and the solution I found, I might implement it. But I can not promise.


Fix support for mistral reverse workflows

Reverse workflows require the task_name parameter to indicate where
to start the workflow. This adds support for that parameter to the
mistral runner and fixes the parameter name in the runner config.
Fixes #3994
TODO:

[x] Change runner parameter to task_name
[x] Make runner pass task_name in params
[ ] add tests that use reverse workflows
[ ] display published parameters not working?

I successfully used a reverse workflow using this patch. The only odd thing was that intermediate published vars didn't show up like a direct mistral workflow. I'm not sure why. I'm guessing it might have something to do with the really old st2vagrant box I used: v2.2.1

Please add unit test for a reverse workflow at https://github.com/StackStorm/st2/blob/master/contrib/runners/mistral_v2/tests/unit/test_mistral_v2.py. Please add an integration test at https://github.com/StackStorm/st2/blob/master/st2tests/integration/mistral/test_wiring.py. To run integration test, make sure you have st2 and mistral services running and then run make itests from the root of the directory where the st2 repo is locally.

I have another project I need to finish before I can get back to this. The
last step involves chatops :) Once I get that going, I hope to have time to
revisit all my PRs and figure out writing tests for them.
On Wed, Feb 21, 2018, 14:18 W Chan<EMAIL_ADDRESS>wrote:

@m4dcoder requested changes on this pull request.
Please rebase and include unit and integration tests. Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StackStorm/st2/pull/3998#pullrequestreview-98345531,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfIPvi9DQfKxLPIno4R9ceLySC31cb6ks5tXHoOgaJpZM4SEv7P
.

With Orquesta coming, perhaps it would be better to add a PR that explicitly disables reverse workflows (and throws a helpful error to anyone that tries to use one). I'm not sure it makes sense to improve Mistral if Mistral is going away (eventually).
If you want to fix reverse workflows then I'll look at figuring out the testing framework here.

K. I ran the mistral integration tests without this change and with them. I added two tests which fail without this PR, and pass with this PR:

K. I ran the mistral integration tests without this change and with them. I added two tests which fail without this PR, and pass with this PR:

test_basic_reverse_workflow
test_reverse_workflow_with_requires

BEFORE PR
TEST RESULT OUTPUT:
======================================================================
1) FAIL: test_basic_reverse_workflow (integration.mistral.test_wiring.WiringTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    st2tests/integration/mistral/test_wiring.py line 57 in test_basic_reverse_workflow
      self.assertEqual(ex.status, action_constants.LIVEACTION_STATUS_SUCCEEDED)
   AssertionError: u'failed' != 'succeeded'
======================================================================
2) FAIL: test_reverse_workflow_with_requires (integration.mistral.test_wiring.WiringTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    st2tests/integration/mistral/test_wiring.py line 65 in test_reverse_workflow_with_requires
      self.assertEqual(ex.status, action_constants.LIVEACTION_STATUS_SUCCEEDED)
   AssertionError: u'failed' != 'succeeded'

AFTER PR
test_basic_reverse_workflow (integration.mistral.test_wiring.WiringTest) ... passed
...
test_reverse_workflow_with_requires (integration.mistral.test_wiring.WiringTest) ... passed

ERRORS: Both Before and after this PR. So this PR has the effect I expected. Why are these other tests erroring out?
======================================================================
3) ERROR: test_rerun_and_reset_with_items_task (integration.mistral.test_wiring_rerun.RerunWiringTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    st2tests/integration/mistral/test_wiring_rerun.py line 117 in test_rerun_and_reset_with_items_task
...
      'Execution is in completed state and does not '
   Exception: Execution is in completed state and does not match expected state(s).
======================================================================
4) ERROR: test_rerun_and_resume_with_items_task (integration.mistral.test_wiring_rerun.RerunWiringTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    st2tests/integration/mistral/test_wiring_rerun.py line 142 in test_rerun_and_resume_with_items_task
...
      'Execution is in completed state and does not '
   Exception: Execution is in completed state and does not match expected state(s).
======================================================================
5) ERROR: test_rerun_subflow_and_reset_with_items_task (integration.mistral.test_wiring_rerun.RerunWiringTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    st2tests/integration/mistral/test_wiring_rerun.py line 172 in test_rerun_subflow_and_reset_with_items_task
...
      'Execution is in completed state and does not '
   Exception: Execution is in completed state and does not match expected state(s).
======================================================================
6) ERROR: test_rerun_subflow_and_resume_with_items_task (integration.mistral.test_wiring_rerun.RerunWiringTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
...
      'Execution is in completed state and does not '
   Exception: Execution is in completed state and does not match expected state(s).

@m4dcoder are the test_rerun issues a problem I need to deal with to get this merged? Those tests error both with and without this PR included, so I don't think they have anything to do with this PR.
Also, I validated that published vars are showing up. I'm not sure what I was seeing when I wrote that way back when. I'll just rebase this on master and then it is good to go.

@cognifloyd Ideally, all tests need to pass. But since these tests failed in your environment before the PR, I think it could be how you set up your development environment. I can grab this branch and run the tests to see. But Mistral is not my priority at the moment so I cannot say when I can get to it.

I can't spend any more time trying to figure out how to manually install and run everything with whatever dev conf files are required. Maybe you guys could create an st2vagrant-like box that automatically checks out st2, mistral, etc setting up the dev environment. Some things that the dev docs were missing: I had to create a symlink (or copy) the examples pack, setup the virtualenv, and mistral has to run with the conf/mistral.dev file. I also couldn't "install" mongo as indicated in the doc because that downgraded mongo to an old version.
Maybe all that's needed is a doc refresh: https://docs.stackstorm.com/development/sources.html


PHP Artisan no longer works

I installed the Sentry Laravel package in my Laravel 8 application following the installation instructions.
However, after the successful installation, the PHP Artisan CLI no longer works. So the command php artisan sentry:publish cannot be executed either.
If I uninstall the package, then I can execute PHP Artisan CLI commands!
Does anyone have the same problems or know what the problem is or how to solve it?

Hi @christophstockinger, for future readers it would be awesome if you could tell us what went wrong and how you ended up fixing it 👍


Fix lints and issues

Closes #2, #3
Thanks for bringing up the issues @Entomy!
I forgot I had written this a few years ago, and revisiting some of the source sent me back memory lane.
I'd like to mention that I kind of wrote a good portion of this expecting no one to ever use this, so sorry if this caused you any grief; cheers!
(Also #1 is relevant, but I'm just doing it for the case you mentioned for now)
Will go over this tomorrow and make sure that everything seems in line when I'm a little more awake, and probably merge!

Oh actually, I have a YouTube channel and was doing a code review of this code. I had planned on fixing/improving some things for you since I knew there was at least a few people who would use this.

(you might want to actually merge this, btw)

I can close this PR if you want to go ahead and implement said thingies, didn't mean to ruin anyone's fun :).

Well since you've already implemented a few things, I've already branched off this. As far as I can tell this is the only code generator for Ada, aside from basic snippets that purely exist within specific editors. There's definately a need/desire for this.

Alright! The code needs a lot of love and care, and cleanups are very, very possible. Let me know if you have any questions, and I'll try to answer as best as I can! I'll go ahead and merge this.


add reverse() function for arrays and vectors

Summary:
reverse(x) should return the elements of x in reversed order.
Description:
This allows, for example, a decreasing vector type by reversing an increasing one.
Current Version:
v2.11.0

Marco --- I assigned you to this because you wrote most of the other shape and order wrangling functions.  If you don't want to do it, please just unassign yourself.  No rush, I gave it a target milestone of Future.

Hello. May I know if the "reverse(x)" function still not available in current version of Rstan?

Correct.  Nobody's implemented it.  It should be an easy first issue as it doesn't interact with anything else and it's a simple algorithm.

P.S.  Almost any program using reverse outside of transformed data (where it'll only occur once) should probably be reshaped so that's not necessary.


Crash when teleporting to space station

Version of Advanced Rocketry
Unstable build 111 for 1.12.2
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
<IP_ADDRESS> for 1.12.2
Version of Minecraft
1.12.2
Crash report or log (if applicable)
pastebin.com/wFx22yLB
Description of the problem
This is on a locally hosted sponge server. I am quite certain this doesn't happen in singleplayer (this was a singleplayer world that I moved to the server). Every time I go to the station, it kicks me out of the server and every time thereafter.

Update: I noticed that the dimension folder for space stations (-2) is supposed to go into the advanced rocketry folder. In sponge however, it generates one in the normal world folder alongside the other dimensions which I assume can cause a crash.

Fixed by unstable build 113


Bring back webkit calendar picker indicator for datalists

Fixes #35386 for the time being.

Bundlewatch Failed.
I think
[list]:not([type="date"]):not([type="datetime-local"]):not([type="month"]):not([type="week"]):not([type="time"])::-webkit-calendar-picker-indicator {
 opacity: 0;
}

should be good to go.
The default datalist indicators for date and time are good enough in Chrome 96. Not sure about other versions.

Using icons is kinda heavy indeed, so we'd better go with natives. Thanks for your patience!
Customizing icons could be something to document as a snippet, in #33627: cross-linking here for now :)

Alright, I reverted the code to use native datalist icons on date or time inputs and removed the dropdown icon on text type inputs.
Used display: none instead of opacity: 0 because with opacity: 0 the indicator was still taking up space which looked like padding.
Thanks!


Please release a new version to PyPI

There have been some patches added to jingo that are not in version 0.7.
Would it be possible to do a release?

ping @jsocol since I think you can do releases on this project too, right?

Yeah I'm the primary maintainer. I'll take a look this week. Number, I think, #71 still needs to be fixed and has some comments. (A regression in the behavior of |f, whichever PR that is.)
--
Sent from my phone, please excuse the occasional typo.
On Wed, Jan 21, 2015 at 12:26 PM, Peter Bengtsson
<EMAIL_ADDRESS>wrote:

ping @jsocol since I think you can do releases on this project too, right?
Reply to this email directly or view it on GitHub:
https://github.com/jbalogh/jingo/issues/64#issuecomment-70881261

Number #71?

Oh and of course it doesn't even link issues when you comment via email. It's #59. Number #59. Number No. #59.

It seems #59 is almost ready to go. With Django 1.8 looming on the horizon, it's becoming more and more important to have a release of Jingo that support Django 1.7 (Before 1.6 is deprecated). Any chance of this getting fixed soon?

Closing this in favor of #67, and the fact that 0.7.1 is out.


Ctrl + left/right arrows doesn't work

Describe the bug
The shortcut ctrl+(left/right) arrows don't skip words in sql editor, it just don't do nothing
To Reproduce

Open a new query tab
Write some words
Use ctrl + (left/right) arrow to move the cursor
The cursor stay in place

Expected behavior
The cursor must go to beginning/end of the word
Application (please complete the following information):

App client: Mysql
App version: 0.5.15
Installation source: Snap Store

Environment (please complete the following information):

OS name: Ubuntu
OS version: 22.04
DB name: Mysql
DB version: 8.0.30

Hi @lapega,
thanks for the report.
As a temporary solution you can go on settings under shortcuts tab and delete shortcuts registered with CTRL+Left/Right

Nice!
El El mar, 23 de ago. de 2022 a la(s) 17:18, Fabio Di Stasio <
@.***> escribió:

Hi @lapega https://github.com/lapega,
thanks for the report.
As a temporary solution you can go on settings under shortcuts tab and
delete shortcuts registered with CTRL+Left/Right
—
Reply to this email directly, view it on GitHub
https://github.com/antares-sql/antares/issues/427#issuecomment-1224807306,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELYVWWIEKOVML4C5L5NGTV2UW3FANCNFSM57MKVRWA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Fixed!


install extra rustup targets from makefile

What are you trying to solve?
Add a new config for mkmf to install rustup target.
The gems that are targeting wasm32-unknown-unknown can install the required target in the makefile.

❤


Support token substitution in page navigation

Hello Dan
My name is Dave Winchurch and I work with Krister Bone. We use SpecBind extensively in all our acceptance tests. It really helps prevent the standard sprawl of custom bindings you traditionally get with SpecFlow. It's a great tool and I'm please to have been introduced to it!
We created a scenario where we find and store an id for a vacancy, apply for that vacancy then return to its page to verify some markup. There was an expectation that we could substitute this id in the PageNavigation.UrlTemplate property for a page, in this case:
//Set token
 _tokenManager.SetToken("VacancyId", vacancyId);

//Page attributes
[PageNavigation("/apprenticeship/[0-9]+", UrlTemplate = "/apprenticeship/{VacancyId}")]

//Scenario
And I navigate to the ApprenticeshipDetailsPage page with parameters
		| VacancyId   |
		| {VacancyId} |

However this simply replaced "/apprenticeship/{VacancyId}" with "/apprenticeship/{VacancyId}"
This pull request contains the small change I made to support this usage. It passes the tokenManager down a bit further in the stack and relies on the tokenManager.GetToken method's behavior of returning the original string if a value is not found for that key to maintain previous functionality.
This is actually my first ever pull request so please accept my apologies if I've done this wrong! I'd also welcome any comments or criticism if the code isn't up to your standards. I'm of course happy to make any changes you request. I'd quite like to contribute more to this project if possible.
Thanks for your time.
Dave

Sorry about the broken test!
I missed this because there are several date related tests that fail locally for me due to my local (en-GB). This means that tests similar to the following:
RunItemCompareTest("2/22/2013", "February 22, 2013", true);

Fail. I didn't spot that I'd broken a different test :$

Hi Dave,
Thanks for the work, I just merged it. I'll have to do something to update those tests for different locales at some point, if you can come up with a solution feel free to contribute it :)
-Dan


ovn_workload: Always specify load balancer VIP ports.

This is to better simulate what ovn-kubernetes does.
Signed-off-by: Dumitru Ceara<EMAIL_ADDRESS>

CC: @igsilya


Refactor to Allow Explicit Inputs.

Current production code tend to subscribe to external inputs in a way that is slightly awkward. In this example from the demo app it is quite difficult to reason about when the startLoadingNextPage event will fire.
   Feedback(predicate: { !$0.paging }) { _ in
                  nearBottomSignal.map { Event.startLoadingNextPage }
   }

I propose that we resolve this by adding explicit inputs which listen to an external input. When an input is received they evaluate a function (State, InputEvent) -> Event? which models if and how the system should react to an InputEvent given its current State.
This code would need a bit of tidying up before being merged, but I would appreciate feedback on whether explicit inputs is considered to be a good design and if the proposed implementation can be improved.
❤
@zzcgumn

@zzcgumn I had a similar issue once when I was trying to make a state to react on some external signal. But thinking of it now can we achieve the same by creating a regular Feedback from this signal and add it into feedback loop as we do for UI actions?
Here instead of Event.ui we use a new Event.extenral type of event, or we can just have a switch right in the feedback loop to return some concrete events if we don't want to wrap them like we wrap UI actions.
class ViewModel {
    init(externalSignal: Signal<ExternalSignalValue, NoError>) {
        ...
        state = Property(
            initial: .initial,
            reduce: ViewModel.reduce,
            feedbacks: [
                ViewModel
                    .userActions(actions: actions),
                ...,
                ViewModel
                    .externalSignal(externalSignal),
        )
    }
}

extension ViewModel {
    static func externalSignal(_ signal: Signal<ExternalSignalValue, NoError>) -> Feedback<State, Event> {
        return Feedback { _ in
            return signal.map(Event.external)
        }
    }
}

enum Event {
  case ui
  ...
  case external(ExternalSignalValue)
}

While I agree on the urgent need of convenience for turning external reactive sources into Events, performing conditional evaluation agains the state outside the reducer has considerable implication on consistency if not carefully crafted. I would prefer not to relax the "everything in reducer" mental model we have.

Hi gentleman. 👋 There are two parts to this proposal and we should tackle them separately and consequently in the right order and place.

Allowing these changes, proposed by Martin, to be merged. This by itself is IMO what this proposal should be about. As Anders said, this is something that was discussed before and ultimately closed, so caution is warranted. Since I am out of muly depth in this discussion, I will defer the decision to you guys and @Serg. 😅
The second part is actually adopting this approach in our codebase and it, by itself, needs a proposal in ios-playbook. Ultimately the whole team needs to understand the consequences of this approach and agree that this is the right way forward for us and our codebase. ❤

I want to make this very clear: even if this PR is approved and merged by no means it means we will adopt in our codebase without proper discussion and agreement. 😄

@inamiy what do you mean by separating reducers? If I understand correctly the way input signal would work is that it would map input values to some events which then will still go through the common reducer.

In the theory of computation, a Moore machine is a finite-state machine whose output values are determined only by its current state. This is in contrast to a Mealy machine, whose (Mealy) output values are determined both by its current state and by the values of its inputs.

According to this I would say we have Mealy state machine

@ilyapuchka

what do you mean by separating reducers? If I understand correctly the way input signal would work is that it would map input values to some events which then will still go through the common reducer.

let inputReducer: (State, ExternalEvent) -> Event? is considered as another (event) reducer along with common (state) reducer.
These are 2 separate reducers sequentially combine-able into one.
Anyway, the definition of reducer is not a problem here, but inputReducer also taking State as an argument makes not equivalent to inputSignal.map { ... } and makes state transition more complex as already mentioned in https://github.com/Babylonpartners/ReactiveFeedback/pull/32#issuecomment-439620022 , which I referred it as Mealy machine.
@sergdort

what do you mean by separating reducers? If I understand correctly the way input signal would work is that it would map input values to some events which then will still go through the common reducer.

Feedback will be an output type of state-machine in this library, which is essentially let events: (Scheduler, Signal<State, NoError>) -> Signal<Event, NoError>, which can be simplified as State -> IO<Event>.
Since this doesn't have State -> Event -> IO<Event>, I would say this library is Moore machine.

I think I was a bit wrong about relating let inputReducer: (State, ExternalEvent) -> Event? with Mealy machine since it is not actually a side-effect output, so please forget about different machine model for now.
My whole point is, let inputReducer: (State, ExternalEvent) -> Event? is too complex (relying on state) so we can simplify into let inputReducer: (ExternalEvent) -> Event?, which can be replaced with ReactiveSwift's filter + map (so we don't need protocol FeedbackInputSignal).

@inamiy Does this signature State -> Event -> IO<Event> mean that there is a set of event's that does not go via reducer or is it State -> ExternalEvent -> IO<Event>?

Isn't let inputReducer: (ExternalEvent) -> Event the same that we are doing ATM with send(action: Action) where Action is just a subset of the even's?
Also, correct me if I'm wrong, I have a feeling that you wan't something to be able to trigger effects, e.g
Signal<ExternalEvent> -> Signal<Event> am I correct?

@zzcgumn can we reach for this? Otherwise, I am afraid this needs to be closed.

@RuiAAPeres I will have a careful look at what @inamiy'a suggestion tomorrow morning. At a first glance what he suggests makes sense.

@zzcgumn awesome! Do please remember that merging this work/approach doesn't mean we will adopt it.

@sergdort https://github.com/Babylonpartners/ReactiveFeedback/pull/32#issuecomment-478646592
(Sorry for late response, seems like my prev reply hasn't been successfully sent 😢)

Isn't let inputReducer: (ExternalEvent) -> Event the same that we are doing ATM with send(action: Action) where Action is just a subset of the even's?

Current inputReducer also takes State argument, which is a big difference.

Also, correct me if I'm wrong, I have a feeling that you wan't something to be able to trigger effects, e.g
Signal<ExternalEvent> -> Signal<Event> am I correct?

Yes, so I introduced an example in #41 😉

I would prefer not to relax the "everything in reducer" mental model we have.
I'm with @andersio the issue I see here is that #41 introduce a set of events that does nothing to the state essentially reducer ignores them, and they serve as a triggers for side effects.

The signature of Signal<(Event, State)> -> Signal<Event> is effectively a signature of the Middleware in Redux. And in my opinion is a one of the down sides of it, which does not allow to model closed feedback systems (The simplest example of it could be a traffic light), where side effects got triggered only by the state changes.

To support opinions above, cf. Labeled transition systems https://ncatlab.org/nlab/show/transition+system

Definition. A labelled transition system consists of a transition system T=(S,i,E,Tran) together with a set L of labels, and a function l:E→L. We denote it by (T,L,l).

Let E = UserAction (InputEvent) and L = Event.
Then, l: UserAction -> Event is a simple function that won't contain State as argument.

To have a Signal<InputEvent> -> Signal<Event> we need a function InputEvent -> Event. This is the 𝜆 in the transition system article. Why is it an advantage to introduce this function compared to our current practise and nominate a subset of Event as inputs? I can think of three realistic ways to construct the function InputEvent -> Event.

As a pure function. In this case we have made it an explicit requirement to nominate a subset of Event as inputs. In my opinion this is better than relying on naming conventions.
As a feedback system (InputState, InputEvent) which emits Event pretty much in the same way as our view models emit routes.
As a feedback system (State, InputEvent) which again emits Event but shares the state with the main feedback system.

Intuitively, I would expect 1 to be dominating use case. I think we can have situations when 2 makes it easier to build highly dynamic user interfaces.
Scenario 3, we should probably avoid. It is essentially my original proposal. What I was worried about was that it might not be possible to calculate InputEvent -> Event without inspecting the current state. I do, however, believe that will 2 always offer a better solution.
@inamiy Does the above agree with how you are reasoning?
P.S. Am I completely wrong to think of a transition system as a Markov chain with deterministic transitions?

we need a function InputEvent -> Event

Isn't that effectively Event.ui(InputEvent)? Even though it's modelled as enum case (or in other words a subset of Event), technically it's still a function.

we need a function InputEvent -> Event

Isn't that effectively Event.ui(InputEvent)

@ilyapuchka is right.
Event.ui : InputEvent -> Event is already provided as a pure function, so we can go with Scenario 1 for sure.
For Scenario 2 and 3 (which I heard InputState is almost same as State), adding extra argument requires another reason to proof its logic, and we want to avoid putting complex logic no more than reducer and feedback.
So instead, I would like to propose a new feedback system that depends on both State and Event to achieve this PR's goal of creating (State, Event) -> /* event related something */ .
It will be based on https://github.com/Babylonpartners/ReactiveFeedback/pull/32#issuecomment-476898230 and #41 , and I will post to ios-playbook later :)

Please re-open when you can work on it. 👍


[BUG] Harvester 1.2.0 upgrade failed at first hurdle - managed chart harvester-crd is not ready

Describe the bug

Clicking the (second) Upgrade button to upgrade Harvester 1.1.2 to 1.2.0 displays the message
admission webhook "validator.harvesterhci.io" denied the request: managed chart harvester-crd is not ready, please wait for it to be ready
Having seen a similar message in the Known Issues I see that Fleet can't reuse the name mcc-harvester-crd
dobby:~ # kubectl get bundles.fleet.cattle.io -A
NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             1/1
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 1/1
fleet-local   mcc-harvester-crd                             0/1                       ErrApplied(1) [Cluster fleet-local/local: cannot re-use a name that is still in use]
fleet-local   mcc-local-managed-system-upgrade-controller   1/1
fleet-local   mcc-rancher-logging                           1/1
fleet-local   mcc-rancher-logging-crd                       1/1
fleet-local   mcc-rancher-monitoring                        1/1
fleet-local   mcc-rancher-monitoring-crd                    1/1

Unfortunately that's where the similarity ends so don't think the workaround will work.
To Reproduce
Steps to reproduce the behavior:

Go to the Dashboard of Harvester 1.1.2 cluster and click Upgrade
At the warning click the Upgrade button

Expected behavior

The upgrade should proceed.
Support bundle

supportbundle_af6572d3-42b1-43d1-8145-ce13e92f0e69_2023-09-08T16-09-31Z.zip
Environment

Harvester ISO version: 1.1.2 (upgrade through all the versions from 1.0.0)
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal with 2x Intel NUC7i7DNxE

Additional context
Add any other context about the problem here.
I may be jumping the gun but downloaded the ISO and serving locally with tweaked version.yaml file.

From the support bundle file, I found the UIDs seem to be mismatched:
$ kubectl -n fleet-local get managedcharts harvester-crd -o jsonpath='{.metadata.uid}'
7c95ea98-c5dd-4573-a010-69bd74f016a6

$ kubectl -n fleet-local get bundles mcc-harvester-crd -o jsonpath='{.metadata.ownerReferences[0].uid}'
9bc66b80-2768-4f17-91fc-1fa824bfbc0f

Those two UIDs should be the same in a healthy cluster. We may want to dig deeper into this one.
Also, though it may not be relevant to the issue, it seems that the cleanup procedure of the previous upgrade had some problems. The controller keeps complaining that it cannot remove the volume used by the upgrade VM at an earlier upgrade.
From harvester-76967d7ddb-gpwpl's log:
...
time="2023-09-08T16:08:21Z" level=info msg="Delete upgrade repo image harvester-system/harvester-iso-sc9gc"
time="2023-09-08T16:08:21Z" level=error msg="error syncing 'harvester-system/hvst-upgrade-b6zlh': handler harvester-upgrade-controller: admission webhook \
"validator.harvesterhci.io\" denied the request: Cannot delete image harvester-system/hvst-upgrade-b6zlh-v1.1.2: being used by volume harvester-system/upgr
ade-repo-hvst-upgrade-b6zlh-disk-0, requeuing"

These servers were originally installed as 1.0.0 which has then been upgraded through the versions as released although I did have problems with 1.0.3 to 1.1.0 (see #3203 ). Given your cleanup comment I guess 1.1.2 was not as successful as the 1.1.2 Upgrade Status of Success suggested (so perhaps something else to check if cleaning up is part of the upgrade and not for the next upgrade?).
If there's something you want me to do please let me know or happy to join a remote session. Note you'll likely get a quicker response from me via Slack than here but either should work.
Thanks.

@starbops running those two UID commands on my master node (the one with VIP) I'm getting the same (second) UID for both:
dobby:~ # kubectl -n fleet-local get managedcharts harvester-crd -o jsonpath='{.metadata.uid}{"\n"}'
9bc66b80-2768-4f17-91fc-1fa824bfbc0f
dobby:~ # kubectl -n fleet-local get bundles mcc-harvester-crd -o jsonpath='{.metadata.ownerReferences[0].uid}{"\n"}'
9bc66b80-2768-4f17-91fc-1fa824bfbc0f

based on the following my problems with 1.0.3 to 1.1.0 might be relevant:
dobby:~ # kubectl -n harvester-system get service | grep upgrade | sort -k6
upgrade-repo-hvst-upgrade-b6zlh   ClusterIP   <IP_ADDRESS>    <none>        80/TCP     139d
upgrade-repo-hvst-upgrade-b4zkp   ClusterIP   <IP_ADDRESS>     <none>        80/TCP     278d
upgrade-repo-hvst-upgrade-mbjbv   ClusterIP   <IP_ADDRESS>   <none>        80/TCP     290d

Checking Harvester release dates and my own notes, 139 days ago would be when I upgraded from 1.1.1 to 1.1.2, 278 days was when I upgraded from 1.1.0 to 1.1.1, and 290 days ago was when I reinstalled 1.1.0 after problems upgrading 1.0.3 to 1.1.0.

Sorry, please forget about the UID issue. It was my mistake that the UIDs seem to be different from the original support bundle file you provided while checking them with the SBK simulator. They're indeed the same without any issue.
We might need to take a closer look into the cluster status since some of the information are not packaged in the support bundle file. Thank you!

So @starbops asked me via Slack to provide the output from a couple of helm commands except helm is missing from Harvester - see #4518 . Once helm was installed I ran
dobby:~ # helm list -A
NAME                                       	NAMESPACE                	REVISION	UPDATED                                	STATUS  	CHART                                                                                APP VERSION
fleet                                      	cattle-fleet-system      	25      	2023-05-09 11:26:41.959707979 +0000 UTC	deployed	fleet-100.2.3+up0.5.3                                                                            	0.5.3
fleet-agent-home-lab                       	cattle-fleet-system      	14      	2023-05-12 18:13:06.013120668 +0000 UTC	deployed	fleet-agent-home-lab-v0.0.0+s-423c577c03291da9d6eedd26ed17dc2a962734a38441944414870c72a7020
fleet-agent-local                          	cattle-fleet-local-system	3548    	2023-09-12 08:47:13.990705539 +0000 UTC	deployed	fleet-agent-local-v0.0.0+s-dd73d018b0bf64ec25d523466c5cd267ef6a5cfffec4d6faff1cbed6951b2
fleet-crd                                  	cattle-fleet-system      	4       	2023-05-09 10:16:39.119650292 +0000 UTC	deployed	fleet-crd-100.2.3+up0.5.3                                                                        	0.5.3
harvester                                  	harvester-system         	2378    	2023-09-12 08:47:12.079633978 +0000 UTC	deployed	harvester-1.1.2                                                                                v1.1.2
local-managed-system-agent                 	cattle-system            	3501    	2023-09-12 08:47:12.670022129 +0000 UTC	deployed	local-managed-system-agent-v0.0.0+s-3dc797d90fb9a229cdadbe5004382d9ccaa0be72c1942ba3e8df17ac92efc
mcc-local-managed-system-upgrade-controller	cattle-system            	3363    	2023-09-12 08:47:11.39727712 +0000 UTC 	deployed	system-upgrade-controller-100.0.3+up0.3.3                                                        	v0.9.1
rancher                                    	cattle-system            	4       	2023-05-09 10:14:25.462106693 +0000 UTC	deployed	rancher-2.6.11                                                                                v2.6.11
rancher-logging                            	cattle-logging-system    	1615    	2023-09-12 08:47:09.188980297 +0000 UTC	deployed	rancher-logging-100.1.3+up3.17.7                                                                 	3.17.7
rancher-logging-crd                        	cattle-logging-system    	1723    	2023-09-12 08:47:38.900589644 +0000 UTC	deployed	rancher-logging-crd-100.1.3+up3.17.7
rancher-monitoring                         	cattle-monitoring-system 	1469    	2023-09-12 08:47:27.36594883 +0000 UTC 	deployed	rancher-monitoring-100.1.0+up19.0.3                                                              	0.50.0
rancher-monitoring-crd                     	cattle-monitoring-system 	2294    	2023-09-12 08:47:16.740707049 +0000 UTC	deployed	rancher-monitoring-crd-100.1.0+up19.0.3
rancher-webhook                            	cattle-system            	4       	2023-05-09 10:16:47.583584289 +0000 UTC	deployed	rancher-webhook-1.0.8+up0.2.9                                                                    	0.2.9
rke2-canal                                 	kube-system              	7       	2023-05-09 10:41:10.275282555 +0000 UTC	deployed	rke2-canal-v3.25.0-build2023020901                                                               	v3.25.0
rke2-coredns                               	kube-system              	5       	2023-05-09 10:41:09.970265511 +0000 UTC	deployed	rke2-coredns-1.19.401                                                                            	1.9.3
rke2-ingress-nginx                         	kube-system              	7       	2023-05-09 10:36:17.329706104 +0000 UTC	deployed	rke2-ingress-nginx-4.1.008                                                                       	1.2.0
rke2-metrics-server                        	kube-system              	5       	2023-05-09 10:36:15.852418501 +0000 UTC	deployed	rke2-metrics-server-2.11.100-build2022101107                                                     	0.6.1
rke2-multus                                	kube-system              	5       	2023-05-09 10:41:10.03899798 +0000 UTC 	deployed	rke2-multus-v3.9.3-build2023010901                                                               	3.9.3

dobby:~ # helm history harvester-crd -n harvester-system
REVISION	UPDATED                 	STATUS         	CHART              	APP VERSION	DESCRIPTION
2272    	Tue May  9 10:31:45 2023	failed         	harvester-crd-1.1.2	v1.1.2     	Upgrade "harvester-crd" failed: failed to create resource: the server could not find the requested resource
2273    	Tue May  9 10:32:00 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2274    	Tue May  9 10:32:28 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2275    	Tue May  9 10:32:46 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2276    	Tue May  9 10:33:01 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2277    	Tue May  9 10:40:15 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2278    	Tue May  9 10:40:44 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2279    	Tue May  9 10:41:01 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2280    	Tue May  9 11:18:19 2023	superseded     	harvester-crd-1.1.2	v1.1.2     	Upgrade complete
2281    	Tue May  9 11:19:40 2023	pending-upgrade	harvester-crd-1.1.2	v1.1.2     	Preparing upgrade

@starbops suggested I rollback the harvester-crd chart so
dobby:~ # helm rollback harvester-crd 2280 -n harvester-system
Rollback was a success!
Anyway the upgrade proceeded slowly (it's always the way when you're keeping an eye on things!) and apart from it seeming to get stuck when upgrading the first node - it didn't deploy rancher-monitoring-grafana - which I cleared with a reboot (something I've had to do with previous upgrades) both nodes upgraded and are running 1.2.0!
Thanks to both @starbops and @bk201 for their assistance!

Any chance you got a support bundle file when you were upgrading the first node? rancher-monitoring-grafana should've been ready after the apply-manifest phase. I assume the upgrade was stuck at the first node's pre-draining phase, which might relate to some volume issue.

Sorry only support bundle is the one originally attached to this issue. I can grab another now (post-upgrade) if that would help?


Update zookeeper to 3.4.8 (from 3.4.6)

http://zookeeper.apache.org/doc/r3.4.8/releasenotes.html

For testing purposes I have created a custom build of kafka with this changes here: https://github.com/mangas/kafka/releases/tag/0.10.0-zkclient-0.9-dev


Clustering av Markers

We want Clustering av Markers
https://developers.google.com/maps/documentation/ios-sdk/utility/marker-clustering
https://blog.kulman.sk/clustering-annotations-in-mkpampview/
Can this be added?

Hi, thanks for the feedback.
This functionality is on the roadmap, and we hope to have something released by the end of the year.
Please note that this is really functionality for the SDK itself, and not for the toolkit. A good place to suggest things like that is the Native SDKs Ideas community. I'd recommend searching for an existing suggestion to upvote.

Hi @jorgenstorlie I'm happy to report that clustering was added within the SDK via ClusteringFeatureReduction in August 2023. If you have any further questions feel free to create another issue, or create a post in our community forum or in the Ideas community Nicholas mentioned above. Thanks!


Update dependency request: missing<EMAIL_ADDRESS>

Is there an existing issue for this?

[X] I have searched the existing issues

Is this a regression?
No
Current behavior
$ time npm ci
npm error code EUSAGE
npm error
npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm error
npm error Missing<EMAIL_ADDRESS>from lock file
npm error
npm error Clean install a project
npm error
npm error Usage:
npm error npm ci
npm error
npm error Options:
npm error [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
npm error [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
npm error [--include <prod|dev|optional|peer> [--include <prod|dev|optional|peer> ...]]
npm error [--strict-peer-deps] [--foreground-scripts] [--ignore-scripts] [--no-audit]
npm error [--no-bin-links] [--no-fund] [--dry-run]
npm error [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
npm error [-ws|--workspaces] [--include-workspace-root] [--install-links]
npm error
npm error aliases: clean-install, ic, install-clean, isntall-clean
npm error
npm error Run "npm help ci" for more info
npm error A complete log of this run can be found in: /builds/pingen/pingen2ui/.npm/_logs/2024-09-15T18_07_56_4[22](https://gitlab.pingen.com/pingen/pingen2ui/-/jobs/82910#L22)Z-debug-0.log

I work primarily on Windows, sometimes use mac. When switching to mac I always had problems that marked and @angular/core: 17.2.0 were missing. I fixed marked because it was required by ngx-markdown we use. But the angular/core is more problematic. We are on Angular18 already but the transloco-key-manager requires v17. Can we get it updated?
Expected behavior
Update angular/core peer dependency to v18
Please provide a link to a minimal reproduction of the bug
Sorry, maybe later
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco:
 "@jsverse/transloco": "^7.4.3",
    "@jsverse/transloco-locale": "^7.0.1",
    "@jsverse/transloco-messageformat": "^7.0.1",
Transloco Keys Manager: ^5.1.0
    "@angular-devkit/build-angular": "^18.2.3",
    "@angular-devkit/core": "^18.2.3",
    "@angular-devkit/schematics": "^18.2.3",
    "@angular-devkit/schematics-cli": "^18.2.3",
    "@angular-eslint/builder": "^18.3.0",
    "@angular-eslint/eslint-plugin": "^18.3.0",
    "@angular-eslint/eslint-plugin-template": "^18.3.0",
    "@angular-eslint/schematics": "^18.3.0",
    "@angular-eslint/template-parser": "^18.3.0",
    "@angular/compiler-cli": "^18.2.3",
    "@angular/language-service": "^18.2.3",
Node: 22.0.0
Package Manager: 10.5.1
OS: Win10 / macos

Additional context
No response
I would like to make a pull request for this bug
Yes 🚀

@MikeDabrowski I think we can change it to >=17.2 no?

@MikeDabrowski Can you check v6?

@MikeDabrowski Can you try v6?

I can confirm it works with v6. Thank you!


Add all pull requests to one request

Hi this pull request merges a few different pulls into one, not merged exactly but gets the general functionality
* https://github.com/rodjek/puppet-logrotate/pull/43
* https://github.com/rodjek/puppet-logrotate/pull/41
* https://github.com/rodjek/puppet-logrotate/pull/38
* https://github.com/rodjek/puppet-logrotate/pull/32
* https://github.com/rodjek/puppet-logrotate/pull/15
As far as i can tell it also fixes
* https://github.com/rodjek/puppet-logrotate/issues/50

great!

i just noticed this old pull.  for the record im now using https://github.com/voxpupuli/puppet-logrotate


Issues with --data

I was trying to use this to create bitbucket repos via oauth.
Deletion with curlic works reliably fine, but POSTing fails. The differences between the two is POST requests have a JSON body.
I'm not sure whether it's bitbucket or curlicue that's failing here.

The issue is how curlicue always tries to interpret the request body even if the content type is
"application/json" and not "application/x-www-form-urlencoded". In should set url_params from the body if content type (the header) is application/json.

In cany case, thanks for the awesome tool. I absolutely love it.

Thanks for the report -- this is correct, if the body content-type is something else then we should ignore it for signature purposes: http://oauth.net/core/1.0a/#anchor13 Thinking about how best to deal with this.

Let me know how this works for you: https://github.com/decklin/curlicue/compare/data-not-params
It adds a curlicue option, so you have to use it in conjunction with setting the content-type header, something like
curlicue -P -- -d '{"foo": "bar"}' -H "Content-Type: application/json" http://example.com/whatever

Works great. Thanks!


WIP 44 Consolidate and Optimize Imports and Build System

Summary and Scope
Description: This pull-request satisfies #44 , removing several pieces of the build-system in favor of a simpler model. The simpler model is:

Build and run a native Python 3.10 application
Add OS Packaging for that native Python application
Simplify the Dockerfile

The intent here is to also optimize and remove dependencies, making the application smaller. Additionally leveraging PyWheels to include dependencies with the Python application itself. This will remove the need for needing to duplicate dependency lists between PyPi and the OS.
This drastically changes the root of the repository, it will look very different (less files, and a few new files). Please carefully review the structure change, and the RPM and Docker Image artifacts.
PR checklist (you may replace this section):

[ ] I have run nox locally and all tests, linting, and code coverage pass.
[x] I have added new tests to cover the new code
[x] My code follows the style guidelines of this project
[ ] If adding a new file, I have updated pyinstaller.py
[ ] I have updated the appropriate Changelog entries in readme.md
[x] I have incremented the version in the readme.md
[x] I have incremented the version in canu/.version

Issues and Related PRs

Resolves #44

Testing
Tested on:

List of virtual system tested.
List of physical systems tested.

Picking this up off/on while I'm on leave, we can look at merging officially once I'm off leave.

Still fighting through nox, I might need help debugging it.

I'll freeze the modules in setup.py in the morning

I believe I've found the root of my test failures, I'm working on these.
Where test_file_directory = Path(__file__).resolve().parent exists I need to refactor to test_file_directory = Path(__file__).resolve().

Closing and redoing.
The redo will just be the python improvement, sans build things.


fix: incorrect month of visits

close https://github.com/denoland/saaskit/issues/240

I like this idea!
But I would still change the way to save the visit date.
Because getUTCmonth() utilize zero-based indexing, it would consistently cause a discrepancy with the actual month value.

It looks like we'll need to clear the previous stats data. Is that correct?

It looks like we'll need to clear the previous stats data. Is that correct?

Ya ...

I'll merge once incrementVisitsPerDay() is re-enabled.


Genome nexus home page example 17:g.41276045_41276046del links to wrong rsid

https://www.genomenexus.org/variant/17:g.41276045_41276046del
17:g.41276045_41276046del should links to rs80357914 instead of rs397509106.
We should fix this and investigate how many other variants have the same problem
Some investigate result:
I'm trying to get rsid by hgvsg or get hgvsg by rsid

#
id
recoder (what we show in search box)
VEP
myVariantInfo (what we show for variant page - dbSNP)
Correct id

1
rs397509106
17:g.41243775_41243776del

2
17:g.41243775_41243776del
rs397509106
no rsid in response
404 not available

3
17:g.41276045_41276046del
no rsid in response, but map to 17:g.41276047_41276048del
rs80357914
rs80357410(under "gnomad_exome", no "dbsnp" object in response), still have "N/A" on variant page dbSNP because we get rsid from "dbsnp" object

4
rs80357914
17:g.41276048_41276049insCT 17:g.41276047_41276048del

5
rs80357410
17:g.41276044A>T 17:g.41276044A>C 17:g.41276044A>G

6
17:g.41276047_41276048del
no rsid in response
no rsid in response
no rsid in response

7
17:g.41276044A>G
rs80357410
rs80357410
rs80357410

I ask Ensembl why 17:g.41276045_41276046del maps to 17:g.41276047_41276048del in recoder, here is their reply:
this is expected behaviour and follows the 3' rule to shift insertions and deletions in repetitive regions to their most 3’ position of the reference sequence. You can find more information about the rule here.


Preserve timestamp on file share artifacts for artifact engine

We should preserve timestamps while downloading artifacts. Similar to the PR https://github.com/Microsoft/vsts-agent/pull/739 that was raised for the agent.

Since we aren't investing FileShare or FCS artifacts, closing this issue for now.


File picker doesn't work on linux

When using file picker on linux (I have used sample compose project) it spams with errors and doesn't work

`(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkViewport': error occurred in libfreetype
(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkPlacesSidebar': error occurred in libfreetype
(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkPaned': error occurred in libfreetype
(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkBox': error occurred in libfreetype
(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkFileChooserWidget': error occurred in libfreetype
(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkBox': error occurred in libfreetype
(java:140182): Gtk-WARNING **: 00:04:56.728: drawing failure for widget 'GtkFileChooserDialog': error occurred in libfreetype
`
System info: Arch linux
File manager: Thunar

Hi @kroune! Thanks for sharing this issue!
I found this related issue: https://youtrack.jetbrains.com/issue/CMP-6022
I will probably need some help to solve this one, it seems not trivial.


Convert SPI intel driver to DTS

the spi_intel.c driver is the last driver that needs to get convert for all SPI controller drivers to support DTS.

@nashif is there someone who can look at this.

@galak I'll do this


Deprecated /API endpoint. Now requires "Services" and "Routes"

As of 0.13.x, the "/api" endpoint is deprecated. Kong now uses "Services" and "Routes"
Any plans to support these? They are currently not available to view or setup on left side menu in Konga admin.

+1

I would also like this.
See also #197

+1

+1.
Waiting feature.

https://github.com/pantsel/konga/tree/next (initial services/routes support!)

Konga 0.11+ is here and offers that functionallity.


[next][TextField] Label, asterisk, and underline spec conformance

Work in progress
This addresses required/error conditions detailed in the spec and noted in https://github.com/callemall/material-ui/issues/5570#issuecomment-262087055

[ ] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Description
I had to capture these from a video on pause so please forgive the masking.

[x]  1. Valid label without focus (grey + grey):

[x] 2. Invalid label without focus (red + red) - focus then blur

[x] 3. Valid label with focus (blue + red):

[ ] 4. Filled field valid label without focus (grey + grey):

So I have 1-3 implemented, but I'm having a hard time with number 4.
What would you call this state or prop, filled? I'm looking for pointers on the desired implementation. If I were in my own cocoon, I would probably check the value of the input and pass a prop filled to the TextFieldLabel. @oliviertassinari and @mbrookes thoughts on approach?

Does dirty indicate the input has been filled?

@rosskevin Thanks for pushing this aspect forward :).

From what I can see, this PR is more about the error state than the required one. I can't see any issue with the implementation of required in the next branch.

Required was not implementing scenarios 4 from the PR description, which needs the pristine implementation you describe and I'll work on.  I'll also work on the bug and get tests working properly.  I'll ping you again once I'm ready for a second look.
Considering my feedback, do you want me to remove required from top level or leave it as a convenience?

@oliviertassinari this is ready to go but it still needs a new baseline screenshot for the regression test TextField/TextFieldRequired.  Is that something you need to do or can I run it?

@oliviertassinari  - two things:

I don't know how to rerun the regression baseline. I had the regression site up, just didn't see a script in any package.json to generate new baseline images
I think someone more familiar than I should look at the TextFieldInput.checkDirty change checking undefined.  My change works, but it should be cleaned up.  Here is my comment so you don't have to sift it out from above:

It seems that controlled vs uncontrolled seems to cause this, this was the visual bug you noted and is present on next.   Debugging in-browser, keydown -> handleChange -> checkDirty(this.input)(good) -> props.onDirty() ->componentWillUpdate -> checkDirty(this.props)(undefined).  I'm unclear on the semantics here of the ref vs componentWillUpdate, so whomever wrote this may want to clear this up.  I'm unsure of the fix here.

You are right, that's not really documented. Digging into, you can find the information here.
Try npm run test:regressions -- -c.
You also need to run docker cd test && docker-compose up.
We should be good with my answer
We are still missing a dot on a description 😁

Alright, that's almost good to be merged 🎉 . Good job. Let me know if you have any issue.
I can continue this PR if needed.

I'm going to look at this tonight.

superceded by #5670


[#825][part-2][followup] fix(writer): Apply a thread safety way to track the blocks sending result

What changes were proposed in this pull request?
As title
Why are the changes needed?
[INFO] Running org.apache.uniffle.test.ContinuousSelectPartitionStrategyTest
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 59.195 s <<< FAILURE! - in org.apache.uniffle.test.ContinuousSelectPartitionStrategyTest
Error:  resultCompareTest  Time elapsed: 55.751 s  <<< ERROR!
org.apache.spark.SparkException:
Job aborted due to stage failure: Task 6 in stage 1.0 failed 1 times, most recent failure: Lost task 6.0 in stage 1.0 (TID 16) (fv-az391-410.nf14wd45lyte3l5gjbhk121dmd.jx.internal.cloudapp.net executor driver): org.apache.uniffle.common.exception.RssException: Timeout: Task[16_0] failed because 9 blocks can't be sent to shuffle server in 30000 ms.
	at org.apache.spark.shuffle.writer.RssShuffleWriter.checkBlockSendResult(RssShuffleWriter.java:350)
	at org.apache.spark.shuffle.writer.RssShuffleWriter.writeImpl(RssShuffleWriter.java:246)
	at org.apache.spark.shuffle.writer.RssShuffleWriter.write(RssShuffleWriter.java:209)
	at org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59)
	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99)
	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52)

ActionLink
I debug the local test and find that all blocks are successfully send, but some blocks are not in the block tracker
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Integration test
Especially run below test in a loop of many times without a fail
mvn -B -fae test -Dtest=org.apache.uniffle.test.ContinuousSelectPartitionStrategyTest -Pspark3

@yl09099 @jerqi PTAL

Codecov Report

Merging #1260 (99ebfd4) into master (49effee) will increase coverage by 1.14%.
 Consider uploading reports for the commit de721c4 to get more accurate results

@@             Coverage Diff              @@
##             master    #1260      +/-   ##
============================================
+ Coverage     53.93%   55.08%   +1.14%
+ Complexity     2647     2642       -5
============================================
  Files           396      375      -21
  Lines         23036    20649    -2387
  Branches       1970     1964       -6
============================================
- Hits          12424    11374    -1050
+ Misses         9845     8587    -1258
+ Partials        767      688      -79

Files
Coverage Δ

...va/org/apache/spark/shuffle/writer/DataPusher.java
62.26% <ø> (ø)

...uniffle/client/response/SendShuffleDataResult.java
46.15% <100.00%> (ø)

...he/uniffle/client/impl/ShuffleWriteClientImpl.java
35.63% <95.00%> (+1.66%)
:arrow_up:

... and 22 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Continue merging rest of flash layer branch

Ok I found a non-atomic commit here.
[stderr]	/home/runner/work/agora/agora/./tests/unit/BlockStorage.d(64,21): Error: no property `signature` for type `agora.consensus.data.Transaction.Input`

Ok I found a non-atomic commit here.
[stderr]	/home/runner/work/agora/agora/./tests/unit/BlockStorage.d(64,21): Error: no property `signature` for type `agora.consensus.data.Transaction.Input`

Merging this part as it's been fixed & is green.


feat: implement BufferPool for PersistentCPStateCache

Motivation

As in serializeState.test.ts benchmark, memory allocation cost is too much while we have memory allocation demand to serialize the whole state at every epoch
part of #6250 with smaller diff to make it easier to review

Description

Implement BufferPool to improve state serialization and also state reload

define a GROW_RATIO to alloc more memory once when we reach limitation
metrics show that the use of it does not increase heap memory

Implement a new DataStore using fs for debugging purpose, will add a new flag to configure it in the next PR
This does not affect current functionality as new state caches are not used anywhere in the production code

part of #5968

thanks @nazarhussain for the vitest fix ❤

:tada: This PR is included in v1.15.0 :tada:


support RS in GF(2^k) for k <= 8

This should make it possible to use RS modes for non GF(2^8). Because many internal types are uint8_t, we can't go past 2^8.

If we modify uint8_t to uint16_t, and can resolve the GF(2^k) for k=16 ?

@fly-feixiang It won't be as easy as just widening the type. That type is so critical to how everything works that there will be a lot of explicit and implicit dependencies on it being that wide. For example, there are a lot of loops and arrays that run on 256 (or 512) items and would instead need to run 216 (or 217) items. There may also be optimizations that need to be reworked to give appropriate performance for k > 8.
I don't think the changes will be too big, but every single line of code needs to be reviewed to see how it will be affected and then new tests written to ensure everything still works.
This isn't particularly high priority for me, but if you want to get started, I can point you to what changes would be needed.

Thanks for your reply.
In most devices, the page size is set to 4094 bytes, such as the phone, so we want to apply this algorithm to the phone.We also used the BCH algorithm implemented in the linux kernel, which has good performance, but it is under the GPL, which we can't use.
I want to extend it to k=12 now. If I have any difficulty, I will ask you

Thanks for your reply.
In most devices, the page size is set to 4096 bytes, such as the phone, so we want to apply this algorithm to the phone.We also used the BCH algorithm implemented in the linux kernel, which has good performance, but it is under the GPL, which we can't use.
I want to extend it to k=12 now. If I have any difficulty, I will ask you


Text Near Right Margin Truncated During Printing

PDF file contains personal identification that can be used for identity theft.  Thus, I have not attached it.
Configuration:

Browser:  Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 SeaMonkey/2.48
Operating system and its version:  Windows 7 Ultimate SP1 (x64)
PDF.js version:  1.8.579
Is an extension:  yes

Steps to reproduce the problem:

Logon to Southern California Edison.
View current bill, which is presented in PDF.js as a PDF file.
Print page 1 of the bill.

What is the expected behavior? (add screenshot)
All text on the page should print.
What went wrong? (add screenshot)
The cents in the amount due near the right margin is truncated.
Note:  The cents -- and the rest of the page -- are fully displayed by PDF.js.  The problem occurs during printing.  Requesting the page to print at 95% does not resolve the problem; that shrinks not only the page but also the margins and still truncates the cents.
Also note:  I saved the PDF file and printed it with Adobe Reader <IP_ADDRESS> WITHOUT any adjustment to the page size.  The whole page printed okay, including the cents.
If necessary, I could likely construct a PDF file that demonstrates this problem without revealing any personal information.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

I decided to create a PDF file that demonstrates this problem without waiting to be asked.  See [http://www.rossde.com/test/PDF_truncated_print.pdf].  Print it with pdf.js.  Then download it and print it with Adobe Reader.

@DavidRoss, would it be possible that Adobe Reader fits printing area to printing margins by default?
Sorry, but i don’t have a printer myself and I cannot check it.

@DavidRoss, I tried to print to a PDF file and I got this:

But the printing dialog in Linux includes the following:

In that case, I think it would be important to have a default printing mode to fit content to printer margins only when needed.

I was able to reproduce ousia's "print-1" results.  I opened [http://www.rossde.com/test/PDF_truncated_print.pdf] via pdf.js and printed it to a new PDF file via doPDF.  There was no truncation.  Thus, I conjecture the problem is in the interface between pdf.js and Mozilla's Printing component of its Core product.  I somewhat doubt the problem is between Mozilla's Printing component and my print drivers because the problem is observed only when pdf.js prints.

This is still a problem with PDF.js 1.9.658.

This is still a problem with PDF Viewer 2.0.159.

This is still a problem with PDF Viewer 2.0.159.

I did not mean to close this.  This is still a problem with PDF Viewer 2.0.305.

I did not mean to close this.  This is still a problem with PDF Viewer 2.0.305.

Closing since we merged quite a few printing fixes recently and this prints out just fine for me. If there are still problems they are most likely upstream and can therefore not be fixed here; in that case please open a ticket on Bugzilla.


Potential secret leak bug

You can see through the dev-tools' fetch viewer

Thank you! I'll be fixing it on a the latest version


Adsk Contrib - Fix Windows link failure when compiling a static library

Fix #590.

lgtm... final approval should fall on @Shootfast

@Shootfast are you Ok with these changes to the build?

The branch is now 19 days old so it would the right time to approve or comment.


Option to copy agents when no access to internet available

Description
When no access to internet, the only option to download agents is to set a custom URL (which involves hosting JARs somewhere), or to copy the agents on the target hosts outside the roles to set a valid file URL.
This change includes a flag to set the option *_remote=false (true by default to don't break compat) on the JVM agents config, and use copy module instead.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature/Improvement (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Any variable changes have been validated to be backwards compatible

@jeqo Looks like the PR failed to pass testing due to linting issues.  If you correct the following and push the changes it should run successfully:
yamllint -c ../../.yamllint ../..
15:29:09  ../../roles/confluent.common/tasks/main.yml
15:29:09    54:8      error    trailing spaces  (trailing-spaces)
15:29:09    85:8      error    trailing spaces  (trailing-spaces)

@jeqo Almost there, there are still linting errors. Try this from the root of cp-ansible:
yamllint -c .yamllint .

@JumaX wdyt about the docs?

@domenicbove Yeah we should probably update the docs for this.  I mean we could put it in the hosts_examples.yml but not sure that's enough?


in_memory = 0

Created in_memory = 0 Why is shown in the info or 1
create test capacity=10001 prob=0.01 in_memory=0
Array
(
    [capacity] => 10001
    [checks] => 0
    [check_hits] => 0
    [check_misses] => 0
    [in_memory] => 1
    [page_ins] => 0
    [page_outs] => 0
    [probability] => 0.010000
    [sets] => 0
    [set_hits] => 0
    [set_misses] => 0
    [size] => 0
    [storage] => 18486
)

bloomd.conf
[bloomd]
port = 8673
udp_port = 8674
scale_size = 4
flush_interval = 60
cold_interval = 3600
in_memory = 0
use_mmap = 0
workers = 1
initial_capacity = 100000
default_probability = 1e-4
probability_reduction = 0.9
data_dir = /var/lib/bloomd
log_level = INFO

@km3945 The in_memory configuration prevents paging to disk when set to 1. It forces filters to never leave memory. If the setting is set to 0, then bloomd will page it to disk when needed, meaning it is allowed to be out of memory. In this case, you are creating a filter and it starts in memory, which cannot be disabled.


zip not found

Downloading launchui-v0.1.4-win32-ai32.zip
Error: GET https://github.com/mimecorg/launchui/releases/download/v0.1.4/launchui-v0.1.4-win32-ai32.zip returned 404

The architecture should be ia32, not ai32.

this is your code that generated this reference

But you pass the architecture as an option to that code. Otherwise it defaults to process.arch which shouldn’t return ai32.


Add email and phone fields in user object

Added following 2 fields in user object

email
phone

Looks good!


Bug 2139306: Process template on selected project

📝 Description
non-priv user does not have access to other namespaces so we have to process template in the selected namespace
This fix targets also this bug

/bugzilla refresh

/lgtm

/bugzilla refresh

/retitle Bug 2139299: Process template on selected project

/bugzilla refresh


Debug RSS releases

I'm still getting weird result from the Releases RSS feed.
It is mostly the same as our "Recent Releases" on the site but often there's something missing or something extra. I can't make sense of it.

I'll capture the feeds output every hour to see if there's something funny going on.

FWIF, the packages feeds seems to be working fine.

#!/bin/bash

set -eu

while true; do
    date=$(date "+%Y-%m-%d %H:%M:%S")
    curl https://swiftpackageindex.com/sitemap.xml | xmllint --format - > sitemap.xml
    git add sitemap.xml
    git commit -m "Snapshot $date"
    sleep 30*60
done

Yep, there's something not right... here's this morning's new items in Reeder, and on the site:

Also, the version number isn't showing up in the title of the releases feed, and neither feed shows any body copy (in Reeder at least). I'll raise a separate bug for that.

Just checked the feed in Reeder and it's not great:

Compared to:

???

This RSS feed! What on earth... 🤯
If it's any help, mine all show the correct dates (in Reeder too) but I pass mine through Inoreader on the way to Reeder.

Oh wait, today is the 11th 😅 . I thought it's from the future but it's probably just something old that's been flushed from my feed. Sometimes happens when it's resetting.

Ok, this is looking better now after the reset. Not celebrating yet though. I just checked and the fix went up only at 3.15pm UK time. After that my feed looks ok:

There are a couple of duplicates from earlier in the day but those are very likely from old local state.

Another interesting aspect my feed watcher just highlighted is that we do produce "out of order" entries in that list, because we don't necessarily analyse package in release order. For instance see this diff here:

Combine comes in second after Turf which appeared as new in the snapshot just before. But its release date was earlier, so it comes second in reverse chronological order.
I believe that should be fine for feed readers - is does seem to be ok, at least as of now.
One possible explanation is that due to the guids not having been unique before, the back insertions wreaked havoc with the order and pulled wrong things to the front?

As long as we output that feed ordered by the date of the release itself, not when we noticed it (which I think we are) then I think this will always be correct.

BTW, that feed that you posted here https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/issues/354#issuecomment-642689563 is the package one and that looks ok 🙂
I.e. as of right now both feeds look good on my end.


chore(RHINENG-2660): Add ability to filter by CentOS systems

To test:
Go to stage
/insights/connector/
Click "View log"
Click Systems tab
Click filter and select Operating systems
Click the dropdown
Notice that the dropdown options do not include CentOS system versions
This PR exposes CentOS versions in the inventory table OS filter.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Files
Coverage Δ

src/Components/ConnectLog/SystemsTable.js
0.00% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!.


Update icons for low and high pressure sensors

Without this change, the pressure sensors are shown using a thermometer icon.

@Kars-de-Jong
Thanks for your pr.
I have changed it to strings and changed the high icon to gauge-full.
Are you okay with this?

@BenPru Ah, sorry about the strings. That’s what you get for editing online outside an IDE.
I used gauge because it is the exact opposite of gauge-low. The scale shows 4 dots, gauge-low is at the second, gauge is at the third.
The opposite of gauge-full (which is full scale) is gauge-empty, but I found those too extreme.


Added TelemetryAsync for use in async python

In codebases uses asyncio, using requests to log will block all ongoing asyncio tasks till the request completes. I added TelemetryAsync which uses aiohttp internally, updated the readme to have async examples.
Also fixed readme bug:
from telemetry import Telemetry

to:
from telemetry_sh import Telemetry

And added better typing:
def log(self, table: str, data: dict) -> dict:

to:
def log(self, table: str, data: Union[dict, List[dict]]) -> dict:

Since telemetry supports bulk ingestion.

this is awesome, thank you!


Performance issue

The performance of the model is as follows:
Score: micro 0.0, macro 0.0 Average 0.0
Why?

sorry, i've just read your issue.
any more info?


Improve Node.js Functions programming model 🚀

Goals

Be idiomatic for Node.js developers. Users should be able to look at the code and immediately know what's going on
Let users define their own file structure (related to https://github.com/Azure/azure-functions-host/issues/5373)
Let users define function metadata in js/ts files instead of json
Take advantage of types as much as possible, including for JavaScript users (i.e. VS Code can provide Intellisense for JavaScript based on the TypeScript types as long as it can find them)
Model after an existing popular/modern framework (Fastify, Express, Firebase, Remix, etc.), but ideally be flexible enough to allow for other frameworks to be used

Plan of action
Moved to here: https://github.com/Azure/azure-functions-nodejs-worker/wiki/Roadmap#new-programming-model
Prototypes
See this repo for the example prototype: https://github.com/ejizba/func-nodejs-prototype

One of the hardest things to handle is bindings - there's nothing like .NET attributes that you can leverage, so there's really two options IMO - object literal or a fluent API.
Here's some rough prototype ideas:
import app from "@azure/functions";

// object literal
app.register(async (context: FunctionContext) => {
  context.res = {
    body: { hello: "world" }
  };
}, {(
  bindings: [{
    type: "http",
    direction: "in",
    name: "req",
    methods: ["get", "post"]
  }, {
    type: "http",
    direction: "out",
    name: "res"
  }],
  route: "/echo"
});

app.register(async (context: FunctionContext) => {
  context.res = {
    body: { hello: "world" }
  }
}).binding({
    type: "http",
    direction: "in",
    name: "req",
    methods: ["get", "post"]
}).binding({
    type: "http",
    direction: "out",
    name: "res"
}).route("echo");

Both of those are a "low level API" and I don't see why you couldn't have something more like app.registerHttp(handler: AzureFunction, route: string, methods?: ("get" | "post" | "patch" | ...)[], additionalBindings?: FunctionBinding[]) as a method which does the sensible defaults but allows more stuff to be added.

I'd be looking at libraries like Fastify/Express/etc. as inspirations for how to create the API surface area, but not try and mimic them completely as they are centred so much around HTTP only, when you want to make a programming model that fits nicely for other bindings too.

I feel honored to be in the bullet list of items that triggers this issue. JK. JK. :P

With the prominence of TypeScript, I would suggest thinking of how the new API model could leverage TS to make it a first class citizen. For example, I would push forward TS decorators as a way to define bindings and other functions settings. I know decorators' TC39 proposal is currently only stage 2, and TS decorators are already diverging a bit from that proposal. But as syntactic sugar, they're unmatched and AFAIK all most popular TS-first frameworks tools use decorators: Angular, NestJS, TypeORM, TypeGraphQL, Loopback, Ts.ED...
This is not necessarily incompatible with @ejizba's prototype approach, but could come in addition to the regular syntax:
import { Http, Get, AuthLevel, FunctionContext } from '@azure/functions';

@Http('/hello')
@Get()
@AuthLevel('anonymous')
export async function ({ req, res }: FunctionContext) {
  res.body = 'Hello World!';
}

One key point is see would be to provide sensible defaults to reduce boilerplate (as @aaronpowell  said), like in my example above the @Http() decorator would set in/out bindings associated to req and res, which is probably the most common use case.
Such an approach regarding default would also work with plain JS using functions:
import { app, FunctionContext } from '@azure/functions';

app.http('/hello', { methods: ['get'], authLevel: 'anonymous' }, async ({ req, res }: FunctionContext) => {
  res.body = 'Hello World!';
});

Or with a fluent api:
import { app, FunctionContext } from '@azure/functions';

app.http('/hello')
  .methods(['get'])
  .authLevel('anonymous')
  .register({ req, res }: FunctionContext) => {
    res.body = 'Hello World!';
  });

Of course, the full verbose would still be accessible, but reducing the amount of boilerplate for common use cases is something to not be overlooked.

I would push forward TS decorators as a way to define bindings and other functions settings

I'm going to disagree with this. From the conversations that I've had with the TypeScript team, I felt that they were not really encouraging new projects to use the decorators that are in TypeScript because, as you pointed out, they aren't in line with the spec and if/when decorators do make it into the spec, they won't be able to directly port over the current implementation, so they'll have to have two different implementations within the language itself.

The first goal is to be idiomatic for Node.js dev, and the fact is that decorators hugely popular in all TS-first Node.js libs. This is what I think is the most important point here.
Now, I don't say that the API should be built exclusively around decorators, but we can use them as syntactic sugar around the base API. When/if the new decorators spec will be defined, the whole TS ecosystem would have to think about a migration path, and the TS compiler won't drop support for the old spec the next day.

The first goal is to be idiomatic for Node.js dev, and the fact is that decorators are hugely popular in all TS-first Node.js libs. This is what I think is the most important point here.
Now, I don't say that the API should be built exclusively around decorators, but we can use them as syntactic sugar around the base API. When/if the new decorators spec will be defined, the whole TS ecosystem would have to think about a migration path, and the TS compiler won't drop support for the old spec the next day.

I support exploring the decorators option. Makes a lot of sense to me.

With decorators progressing to Stage 3 last week, it's probably more viable to consider, but we'd want to leverage the design of decorators that's spec'ed out rather than the one in TypeScript today (and that might make things harder).

I like the idea of decorators in principle but until there's support for the proposal that's going forward not the legacy one in TypeScript and Babel/swc/etc. I see it as being a really hard thing to support as a first-class citizen.

@aaronpowell IMO the object literal approach is where you should start.
Once you have that, community members interested in decorators could roll their own package.  Allowing functions to be registered via code really opens the door to a lot of potential solutions.
IMO, there was only support for fluent API, it makes it a bit harder to extend.

Hi folks! We've actually narrowed it down to one option, and it's a working prototype and everything. More details here if you're interested in giving some feedback: https://aka.ms/AzFuncNodeV4
@ChuckJonas in terms of decorators, it's definitely been on the back burner for now. We want to prototype it still, but we've been focused on a non-decorators approach as described in the link above.

@ejizba just gave it a review.  I like where this is going!
Honestly the thing I'm most excited about is just being able to specify whatever folder structure fits the project best and not have every function as a folder in the root.
Our project is using OpenAPI specs to define our API contracts along side each function.  We use openapi-typescript to get accurate request typings and validate all request using against the spec using ajv.
Overall, I think it's a pretty nice approach, but the limitations around function registration really make it harder to maintain than it would otherwise be.
Some feedback below:
Define function in code

Is the first parameter the route? Or just the function name?   I'm hoping it's the former as this would make it similar to other popular JS frameworks.

Do you have an example Service bus triggered function?

Simplified context, inputs, and outputs

The context object has been simplified to reduce duplication and make it easier to write unit tests

That will be very welcome. Been burned by missing the context duplication in our test setup a couple times now.
Are there any plans to improve Service Bus IN/OUT formats?  Guessing that might be outside the scope of this project, but I have two major problems with how service bus bindings work in AZ Function:

in: input provides only the message.body.  You have to go to the binding read the message properties / applicationProperties.

out As far as I can tell, there are no ways to set anything other than the message body.  This makes the out bindings a no-go for all but the simplest use cases (no sessionId, applicationProperties, etc)

Create a test context
Will be nice to have this out of the box...  We basically rolled out our version of something very similar in our current project.
PS: IMO, decorators don't bring much other than just making the code read closer what whats done in C#.   It feels like the ts community has shifted away from OOO in favor of more functional code.  Current approach seems more flexible and composable.

@ejizba Ran into an issue today with distributed tracing that I was wondering if you guys would be solving via this initiative.
The problem is outlined here.
IDK if maybe this could be solved with the new hooks.   I am using appinsights wrapped context, but you end up needing to rewrite all the context.log functionality because its operation id doesn't get updated.
// Default export wrapped with Application Insights FaaS context propagation
export default async function contextPropagatingHttpTrigger(context, req) {
  // overwrite with the proper traceparent from the message.
  const sbTraceParent = context.bindingData.applicationProperties['diagnostic-Id'];
  if (sbTraceParent) {
    context.traceContext.traceparent = sbTraceParent;
  }

  const correlationContext = appInsights.startOperation(context, req) as CorrelationContext;

  // Wrap the Function runtime with correlationContext
  return appInsights.wrapWithCorrelationContext(async () => {
    const startTime = Date.now(); // Start trackRequest timer

    try {
      appInsights.defaultClient.trackTrace({
        message: 'Correct Trace Context',
      });

      //wrong operation_Id
      context.log('Incorrect Trace Context');

      return await trigger(context, req);

    } catch (e) {
      context.log.error(e);
      throw e;
    } finally {
      // Track Request on completion
      appInsights.defaultClient.flush();
    }
  }, correlationContext)();
}

We're in public preview! 🎉 Try it out now and let us know what you think - read the blog post here: https://techcommunity.microsoft.com/t5/apps-on-azure-blog/azure-functions-version-4-of-the-node-js-programming-model-is-in/ba-p/3773541
I'm going to close this issue and we will track any GA work with its own individual issue


change doc example for insecureSkipVerify from string to bool

Proposed changes
This is a simple doc update.  The doc example shows insecureSkipVerify for the httpprobe to be set as a string when it should be a bool value.  Using a string will result in a validation error like the following:
spec.experiments[0].spec.probe[0].httpProbe/inputs.insecureSkipVerify: Invalid value: "string": spec.experiments[0].spec.probe[0].httpProbe/inputs.insecureSkipVerify in body must be of type boolean: "string"

Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ x] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ x] I have read the CONTRIBUTING doc
[ x] I have signed the commit for DCO to be passed.
[ x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).
n/a

Special notes for your reviewer:
This is just a doc update.

I put in 2 PRs to fix very trival doc updates and they have sat here for months.  This update fixes a blatant error, the other was just for readability.  Am I doing something wrong here?  Should I be bugging people to get this done?  Feel free to reopen when / if willing to review.


FFlags are not made(I'm lazy)

Translated so that it would be as clear as possible and the translation itself was correct.If something is wrong, please let me know
My Discord: Nubik#6549

Just FYI we cannot pull this until the FFlags are in there.

Now i fully translated everything into russian language!