[FEATURE] Update the time of issue creation on runtime

Is your feature request related to a problem? Please describe.
Currently there is a timestamp in the right bottom of issue card of the issue list which shows the time of issue creation. But it is not getting updated with the time. In the below screenshot the time is showing "6 minutes ago" but it is not getting updated along with the time.

Describe the solution you'd like
To implement a functionality which can update the time of issue creation along with the time.
Describe alternatives you've considered
None
Additional context
None

Looks pretty straightforward. I can do a quick PR

@anand346 Check out the PR https://github.com/anand346/findissues/pull/50

This issue is fixed in PR #50, thanks to @lokesh-veerappan-47's impactful contribution


Open VPN Logs

Provide a dashboard or add the ability to show openvpn logs with the AWS VPN logs.

We already provide the dashboard for AWS Client VPN. https://github.com/aws-samples/siem-on-amazon-opensearch-service/blob/main/docs/dashboard_ja.md#AWS-Client-VPN
Please tell me which log you are talking about.


feat(list): update lfi-os-files

use Daniel Meissler's Fuzzing/LFI

Fixes #2649
Signed-off-by: Felipe Zipitria<EMAIL_ADDRESS>

Added most of the modsecurity files that we use in our containers (yeah, those weren't there 😱 )
I don't think the [jboss] usage in that list will bring anything relevant

Where did those [jboss] entries come from? Are they really path components?
I noticed that we have a file called restricted-files.data, that says to keep it in sync with lfi-os-files.data. Did you check that?

Where did those [jboss] entries come from? Are they really path components?

I think those are broken. They will never match in our case. My reasoning is that they were meant to be replaced somehow by specific versions.

I noticed that we have a file called restricted-files.data, that says to keep it in sync with lfi-os-files.data. Did you check that?

No. Will do that, thanks.

Updates:

still updating the cross-reference on restricted files for this.
probably removing/changing the [jboss] to at least a fixed string would make it match. otherwise, is the same as not having it.

Ok, did a big pass here. I've cleaned a lot and written the rationale for the cleanup.

I wonder if it worth to create a rule that matches all hidden files like ^/\.[^.]+ and remove specific hidden files from that list

also, all .conf and .log are redundant because of 920440
IMO we can remove all those entries

I wonder if it worth to create a rule that matches all hidden files like ^/\.[^.]+ and remove specific hidden files from that list

If we don't have it, makes sense to me. We can create a new issue to track it so we don't liger around too much with this list update.

Thanks @theMiddleBlue and @theseion. To all our @coreruleset/core-developers , this is more or less what we need to do for our list updates. We do our best, we open to others for comments, and we iterate until we get something reasonable.

Did a new pass removing additional duplicated and applying the same rationale again.

@theMiddleBlue I don't think 920440 targets what we want, in this case. LFI has nothing to do with REQUEST_FILENAME, so we should keep the .conf and .log entries here. The filename can be part of any ARGS or other arguments.

That's true, this list is checked also on ARGS so, yes!

Much better! I left some more comments.

Good job everybody. Thank you.


Add to alpha.rsw.jp

Adayo.client.jp has moved to alpha.rsw.jp
I’d be happy if you could add it again.
This site is for Japan.

Now the page is almost empty :shrug:


[collab-hwm] Port GD32 to HWMv2 (ARM only)

Note: RISC-V part skipped, it looks like RISC-V soc/ folder will need a bit of love first.

Note: compliance failure is a false positive
 Found references to undefined Kconfig symbols. If any of these are false
positives, then add them to UNDEF_KCONFIG_WHITELIST in /home/runner/work/zephyr/zephyr/./scripts/ci/check_compliance.py.

If the reference is for a comment like /* CONFIG_FOO_* */ (or
/* CONFIG_FOO_*_... */), then please use exactly that form (with the '*'). The
CI check knows not to flag it.

More generally, a reference followed by $, @, {, *, or ## will never be
flagged.

CONFIG_BOARD_                              scripts/utils/board_v1_to_v2.py:107

Hi @gmarull ,
Not sure if compliance is a false positive here.

Hi @gmarull ,
Not sure if compliance is a false positive here.

It is, CONFIG_BOARD_ is part of a regex in the migration script.

It is, CONFIG_BOARD_ is part of a regex in the migration script.

so should be added to the list here:
https://github.com/zephyrproject-rtos/zephyr/blob/603c3af895b0f03d792252412a2255d97791df09/scripts/ci/check_compliance.py#L612-L617


Set recommended TLS cipher suites

Project Gemimi's best practices for implementations seems to recommend (for TLS 1.2) using only Ephemeral Diffie-Hellman (DHE) or Ephemeral Elliptic Curve Diffie-Hellman (ECDHE) for key agreement, AES or Chacha20 as bulk ciphers (which is already the default), and SHA2 or SHA3 hash functions.
I've also restricted the cipher suites to GCM only as the IANA TLS Parameters doesn't seem to recommend CBC ciphers.
The following code might be worth adding in the init_Context function on lib/the_Foundation/src/tlsrequest.c after line 64 or 65.
SSL_CTX_set_cipher_list(d->ctx, "ECDHE-ECDSA-AES256-GCM-SHA384:"
                                                      "ECDHE-ECDSA-CHACHA20-POLY1305:"
                                                      "ECDHE-ECDSA-AES128-GCM-SHA256:"
                                                      "ECDHE-RSA-AES256-GCM-SHA384:"
                                                      "ECDHE-RSA-CHACHA20-POLY1305:"
                                                      "ECDHE-RSA-AES128-GCM-SHA256");

I don't think hardcoding these to TlsRequest is the best way to go, but I can add a setCiphers_TlsRequest() method to set these from the application side.

I don't think hardcoding these to TlsRequest is the best way to go, but I can add a setCiphers_TlsRequest() method to set these from the application side.

I think they should be the defaults. Perhaps there should be a option to let the user choose if they want to accept weak or insecure cipher suites? It's very easy for configuration to go wrong (I think that's why we have TLS 1.3).

I think they should be the defaults. Perhaps there should be a option to let the user choose if they want to accept weak or insecure cipher suites? It's very easy for configuration to go wrong (I think that's why we have TLS 1.3).


Panic when trying to read temperature

Environment:

ESP32-C3-DevKitM-1
connected via USB cable to an USB3 port on my computer

Every time I try to read a value from the internal temperature sensor (e.g. with the http-server example) the ESP panics with
Guru Meditation Error: Core  0 panic'ed (Illegal instruction). Exception was unhandled.

Core  0 register dump:
MEPC    : 0x4200083c  RA      : 0x420006f0  SP      : 0x3fc9ab80  GP      : 0x3fc90c00
0x4200083c - http_server::main
    at ??:??
0x420006f0 - http_server::main
    at /path/to/std-training/intro/http-server/examples/http_server.rs:55
0x3fc9ab80 - _heap_start
    at ??:??
...

From my debugging it seems to occur when start_measurement is executed.
I tried googling for the issue and found this issue which suggests it might be power related. I have plugged in the ESP into ports that are able to supply higher current (powerbank and phone charger), but it seems to experience the same error.
Note: Since I don't have a serial interface on those ports I used the LED to indicate statuses and the color I programmed after the measurement never showed.
I've also tried the code from here to read the temperature in the Arduino IDE, which works.
Any advice would be greatly appreciated, thanks in advance!

The training is intended for ESP32-C3-DevKit-RUST-1 which has an SHTC3 sensor, the ESP32-C3-DevKitM-1 does not contain such sensor, hence the error.

I am working on adding support for Wokwi simulation to the exercises (#168 #154) so soon, you should be able to follow most of the training even without the hardware

The training is intended for ESP32-C3-DevKit-RUST-1 which has an SHTC3 sensor, the ESP32-C3-DevKitM-1 does not contain such sensor, hence the error.

That explains a lot. Thanks for pointing out - somehow I seem to have overlooked that. I just assumed this training would use the ESP32C3's internal temperature sensor which it seems it does not.
You might be the wrong person, but do you know if there is a way to access the internal sensor (linked above) via Rust? It seems to be possible in C as linked in the example above.
I've looked in https://github.com/esp-rs/esp-idf-hal and it does not seem like it contains a driver for the temperature sensor. But I'm not sure if it would be in that repository or if I would have to look somewhere else.
Perhaps you (or someone else) can answer some of my questions.

Just saw that you opened https://github.com/esp-rs/esp-idf-hal/issues/333, I will be closing this issue in favor of that one.

Just saw that you opened esp-rs/esp-idf-hal#333, I will be closing this issue in favor of that one.

Thanks, I forgot to close it yesterday evening.


Editing multiple racks doesn't validate devices out of bound

Issue type
[ ] Feature request
[X] Bug report
[ ] Documentation
Environment

Python version:
NetBox version:  2.1.4

Description
If you edit multiple racks and make them smaller, there's no validation to check if there are any devices left out of bound of the new rack size.
In example you can edit multiple racks from the size of 42U to say 20U, and if a device is added to a rack on position 30, this rack will not load anymore and an error is given.
Validation is done when editing a single rack and this issue does not occur then.

Somewhat related to #1136


Update CONTRIBUTING.md with instructions for creating new files in lemlib

Summary
Add instructions in CONTRIBUTING.md to run make clean quick -j when creating a new file in the lemlib folder.
Motivation
When implementing LemLib-compatible PTO, I ran into issues with the lemlib.a file in the cold package not recognizing the new files. Andrew provided me with the make clean quick -j command which allowed the project to compile properly with the new files.
Test Plan
N/A (it's text in a markdown file)
Additional Notes

Download the template for this pull request:

[!NOTE]
This is auto generated from Add Template to Pull Request

via manual download<EMAIL_ADDRESS>via PROS Integrated Terminal:

curl -o<EMAIL_ADDRESS>https://nightly.link/LemLib/LemLib/actions/artifacts/1129753966.zip;
pros c fetch<EMAIL_ADDRESS>pros c apply<EMAIL_ADDRESS>rm<EMAIL_ADDRESS>

LGTM


⚠ Cioos National CKAN has degraded performance

In 9904e85, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 29545 ms

Resolved: Cioos National CKAN performance has improved in c90ad0a after 35 minutes.


Include new tabs in the document.

Please update the document as it includes only 3 tabs - Overview, Analyst report, and Mitigations but there are a lot more tabs available now, as highlighted below:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1834aed2-8822-5a3b-c5c5-ac70b86fa277
Version Independent ID: 525f0820-aedb-8822-8518-27a5f983f68d
Content: Track and respond to emerging threats with Microsoft Defender for Endpoint threat analytics
Content Source: microsoft-365/security/defender-endpoint/threat-analytics.md
Product: m365-security
Technology: mde
GitHub Login: @schmurky
Microsoft Alias: maccruz

@amanmcse Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/7407
Thanks
Sri

@yogkumgit I received the feedback from the author stating the TA view between Microsoft Defender for Endpoint (MDE) and Microsoft 365 Defender (M365) is different. Hence the difference even in the mitigation tabs that a customer looking at the MDE portal will see compared to what a customer looking at the M365D portal will see.
Hope this helps!
Thanks
Sri


fix create table should check column name format

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Enable cross-compilation

2 options I'm aware of but haven't tried:

https://github.com/rust-cross/cargo-zigbuild
https://github.com/cross-rs/cross

my team is working on several builds for ARM architecture (MacOS/Linux). They work smoothly, but we would ideally move to a single publishing pipeline that uses a x86_64 computer to build binaries for all environments.
please upvote if you have similar requirement

Does this project need to be modified in any way to allow using these tools?

negative, my branch (without opencv dependency) compiles on both a amd64 laptop & a rockchip SoC as-is, both with the latest Debian + libhidapi-dev + libusb-1.0-0-dev.
would be interested to know how Android SDK did this

I would be interested in this as well.  Could also consider using bazel.  It could sit along side the traditional builds in the repo.  https://github.com/bazelbuild/examples/blob/main/rust-examples/02-hello-cross/README.md.  All rust all the time is cool but some things are better at handling dependencies.  My past attempts at rust cross compilation were full of difficulties, but it was awhile back.  I recently ran through the bazel build rust examples and was suitably impressed with what can be possible.   There is a learning curve with bazel, however, I do use it for another project where cross compilation is part of the process.  I would say the big win for a dev is not having to manage toolchains, and dependencies get handled cleanly.


npm install --global @stacks/cli fails

Describe the bug
Following the documentation on https://docs.stacks.co/understand-stacks/accounts, running the command npm install --global @stacks/cli fails — see console log below for details.
To Reproduce
Steps to reproduce the behavior:

Run npm install --global @stacks/cli in console
See error

Expected behavior
Proper installation of @stacks/cli, no errors on install.
Console log
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>https://about.codecov.io/blog/codecov-uploader-deprecation-plan/
npm ERR! code 127
npm ERR! path /Users/davybraun/.nvm/versions/node/v16.10.0/lib/node_modules/@stacks/cli/node_modules/@stacks/blockchain-api-client
npm ERR! command failed
npm ERR! command sh -c npx shx find lib/index.js || npm run build
npm ERR! ><EMAIL_ADDRESS>build
npm ERR! > rimraf ./lib && npm run generate-openapi && npm run build:node && npm run build:browser
npm ERR! sh: shx: command not found
npm ERR! sh: rimraf: command not found

npm ERR!      /Users/davybraun/.npm/_logs/2021-11-04T11_10_13_862Z-debug.log

Additional context
macOS 11.3
Node v16.10.0

Will be fixed with below commands.
npm i shx -g
npm i rimraf -g

Then
npm install --global @stacks/cli

Try not to duplicate the issue. Refer here: https://github.com/blockstack/stacks.js/issues/971.
Closing issue due to duplication #971


Review guidelines

Is it a good idea to define some rules to review a PR?
For example, because we are a lot of collaborators, it could interesting to have more than one approval to merge a PR.
What do you think?

https://github.com/farizrahman4u/keras-contrib/blob/master/GUIDELINES.md#addition-of-new-features

Right, I forgot it was defined because the last PRs have been merged with only one review. "Whenever possible, multiple Maintainers should review a pull requests before it is merged." this should be a priority.


Remove myself from codeowners

What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist

[ ] Changes manually tested
[ ] Automated Tests added/updated
[ ] Documentation added/updated

sad panda


InSpy could not identify the email format. Use --email

Hi,
I tried all possible options order, but always get this error:
inspy company --email<EMAIL_ADDRESS>--domain company.it

InSpy 3.0.0
ERROR:root:HunterIO - HTTP 401 Error
InSpy could not identify the email format. Use --email.

What's wrong with the email format?
Regards

It looks like that's fixed in v 3.0.1. Unfortunately, latest Kali still includes 3.0.0.


cmd/go2go: go2go translator issue with implicitly instantiated generic function

Consider the following code:
package main

func Map[T, U any](f func(T) (U, error), xs []T) ([]U, error) { return nil, nil }

func Apply(s string) func(func(string) (string, error)) (string, error) {
	return func(f func(string) (string, error)) (string, error) {
		return f(s)
	}
}

func main() {
	var input string
	var fs [](func(string) (string, error))
	Map[func(string) (string, error), string](Apply(input), fs) // works
	Map(Apply(input), fs)                                       // works, fails if previous line is removed
}

If we write out the types for Map(Apply(input), fs) everything works.  If we write them out on the first line, and then omit them on the second, it works.  But if we just omit them, the compiler returns errors (below) from the translated code; it seems to somehow be inferring func(string) string instead of func(string) (string, error) or something.
Sample errors:
./prog.go2:13: cannot use Apply(input) (type func(func(string) (string, error)) (string, error)) as type func(func(string) string) (string, error) in argument to instantiate୦୦Map୦func୮8string୮9୮0୮8string୮3୮0error୮9୦string
./prog.go2:13: cannot use fs (type []func(string) (string, error)) as type []func(string) string in argument to instantiate୦୦Map୦func୮8string୮9୮0୮8string୮3୮0error୮9୦string

Playground link: https://go2goplay.golang.org/p/J-5HQfAPIwM

CC @griesemer

This type-checks and even compiles fine with one or both Map function invocations (e.g., go tool compile -G=3 main.go); it is not a bug with type inference.
This looks like a bug in go2go (the source-to-source translator). Not clear that we want to spend time on fixing this as the real (compiler) implementation is coming along and eventually will supersede the translator. Leaving for @ianlancetaylor to decide if he wants to look into this.

Oh, yes, sorry, this is a go2go bug.  We aren't going to be fixing bugs in go2go at this point.  If someone else wants to look into it, that would be fine.

go2go is obsolete.


Pre-Built News Category

Using this API: https://newsapi.org

Ready for testing and getting feedback with 574fd193297d36743c208930958fe5e2cce5e41c

Have you tried it ?
i can't train the agent with any pre-built category (news/git/small talk)


Question regarding numbers being passed between JS and Python versions and what it means for their types

Apologies for the wall of text, it's because I really like the idea of Muon :)
TL;DR: key questions are bolded in the text below
So bit of context: I'm trying to write a JavaScript implementation, since the format is so elegantly simple that I feel I can achieve a basic version of it. My first goal is to have "feature parity" with how JavaScript handles JSON. That is: being able to roundtrip any object that you could also send through  JSON.stringify and get back from JSON.parse, and ignoring the things that it can't. After that I'll worry about the extra things Muon supports.
Having said that, the fact that Muon has more ways to encode numbers was too tempting to not play around with for size savings. The way I have handled numbers so far is assuming that everything is a double unless explicitly made a BigInt (so basically how JavaScript handles numbers), and reserving i64, u64 and LEB128 for those BigInt values. This lets me use all the other number types the AX and BX rows to always pick the minimum number of bytes necessary to encode numbers, e.g.
[8, 16, 1/16, 0.1] => 90 A8 B4 10 B9 00 00 80 3D BA 9A 99 99 99 99 99 B9 3F 91
                       |  |  |     |              |                          |
                       |  |  |     |              |                          List end
                       |  |  |     |              f64 approximation of 0.1
                       |  |  |     f32 encoding of 1/16
                       |  |  u8 encoding of 16
                       |  direct encoding of 8
                       List start

This is not a problem when just roundtripping JS-to-JS, since all values just gets promoted back to doubles in the end.
But now imagine we're sending data between Python and JS code through Muon. Python uses variable sized numbers under the hood, right? One could say all integers are "BigInt" and all floats are doubles (I think), unless one is working with NumPy. The example Python encoder from the slides either directly encodes 0-9, or uses LEB128 for all other integers.
Imagine we have a list of integers between 0 and 1000 in Python that we encode this way, then decode in my JS implementation. We would end up with an array of mixed doubles and BigInt values. So one number type gets converted to two different ones.
One way to handle this would be to say that a JS implementation of Muon has to convert LEB128 back to doubles if it safely fits in a double, but that also potentially leads to issues: say that I start in JavaScript with a list that contains BigInts, some of which could also be safely converted to doubles. First we serialize this list. Let's assume this will use LEB128 encoding because of the BigInt type, like I have so far. Now we deserialize this list in JS. Because of the rule we just established some of the BigInt values will turn into doubles - we change the number types again!
So we basically have two needs that are a little bit at odds:

serialization/deserialization within the same language should not result in type changes
serialization in one language and deserialization in another should result in predictable number types

I think the best summary of this question is: how should Muon handle the different ways languages handle number types when transmitting data between these languages?
For now, for my own implementation I will prioritize 1 over 2 (because it's a toy implementation and I'm not planning to interact with Python in my own use-cases).
PS: I'm sure this question has come up with other encodings that have support for more than just doubles, so maybe it's worth looking up what the arguments + conclusions were in those situations?

TypedArrays mostly resolve this issue, and List is defined as a sequence of abstract objects, so they can have an arbitrary type.
Muon only distinguishes ints vs floats, but JS has no such distinction. So I would suggest such rules:

TypedArrays preserve their types whenever possible
Standalone Integer values (with any encoding) in range [Number.MIN_SAFE_INTEGER, Number.MAX_SAFE_INTEGER] are encoded treated as Number. Outside this range they become BigInts.
Floats/Doubles are treated as Number (this is a direct match)

Ok! So that would mean that outside of typed arrays, BigInts in the [Number.MIN_SAFE_INTEGER, Number.MAX_SAFE_INTEGER] range can turn back into "plain" Number values after a roundtrip through muon. That's probably an acceptable trade-off as long as we're explicit about this - it's the easiest one to explain for starters.
I'll just make sure to add that as a potential gotcha in the documentation of my implementation.


feature: Trouble opens in a floating window

Did you check the docs?

[X] I have read all the trouble.nvim docs

Is your feature request related to a problem? Please describe.
I would like to have every plugin i use in floating mode, so the screen is always as clean as possible
Describe the solution you'd like
TroubleToggle opens in a floating window, instead just left,right,bottom and top, much like telescope or toggleterm
Describe alternatives you've considered
nothing else i considered
Additional context
No response

I think more generally, we should be able to pass the config table usually sent to nvim_win_set_config.
I currently use a hack that uses autocmd to achieve this, and I can't say I'm 100% happy with it.

Development on the main branch is EOL.
Trouble has been rewritten and will be merged in main soon.
This issue/feature either no longer exists or has been implemented on dev.
For more info, see https://github.com/folke/trouble.nvim/tree/dev


WARNING: VARIANTS MAY BE MISSED

I run nanopolish to polish my draft assembly and I had the warning below. Is there anything I should change? Please advice
Number of variants in span (24) would exceed max-haplotypes. Variants may be missed. Consider running with a higher value of max-haplotypes!

Hi,
You can ignore that warning message.
Jared


Implement upload of artifacts to Maven Central

We need to upload Subutai artifacts to Maven Central on release

We are using own Nexus Repo for maven release artifacts


Good Job!

I just want to say this's amazing, please keep adding new elements
Thanks in advance !!!

Thanks, Andy!


Correct the docs to reflect how subsets actually work

And add a couple of doc tests around that behaviour.

Manually merged, thanks


Rework apiv2 findings filters

This PR is the first in a series to improve DDJ APIv2. As of today the /findings api endpoint does not support:

multiple values for the same key
ordering
partial text-string search

With this PR we will be able to query most of the fields of the findings endpoint, except a few ones that are not relevant, and we'll be able to do sorting on the most relevant ones. We'll also be able ot do test-string search on strings fieds.
A couple of notes:

unified query-style: I'm not at all a REST expert but for this PR I tried to stick to one logic when supporting multiple values per keys. For all the fields that supports it, the query syntax is the following: /findings?key=value1,value2. I did it this way because only the MutipleChoiceFilter is supporting the /findings?key=value1&key=value2 syntax so I would not have been able to have unified query-style across all the fields with this style.

for long strings fields like description, title, step_to_reproduce, it's not possible to do a multiple value/key query, it's too messy to manage when there's , inside the string. I guess that's acceptable.

This change introduce breaking change for some fields like:

test__engagement__risk_acceptance
test__engagement__product
test__test__type

As mentioned in the intro I'll probably rework also some other endpoints (like products) as most (if not all) have the same limitations, so we need to properly review it and understand the pros and cons of this proposal before pushing that logic firther.

In the past we had some issues with filters like this. In this case the filter is initiliazed with a list of CWE values to choose from. Which may make sense in the UI. But if the API request tries to filter by a CWE value in that is not in the list, I'm not sure what happens. In the past I've seen cases where the filter is ignored and findings are returned regardless of CWE. So that is one thing to check. Second thing is I am still not sure if we want to have the fitler used in both places. Might be better to have a little bit of code duplication but complete flexibility. I think the API needs to be able to filter by all fields for example.

@valentijnscholten this is exactly why I created a dedicated filter for the API, there's too much things that are UI-specific to have one filter that handles both the API and the UI.
Regarding the filtering; Yes we should be able to filter on all the available fields on the findings endpoint, that's already the case with my PR.
Regarding the behavior of the API in general; I think that the API should support multiple values for the same keys for all the fields except for boolean and dates (for example; cwe=xxx,yyy,zzz, or ids=111,222,333)
Regarding the behavior with CWE; With my current proposal it'll work this way

If you don't provide any value to a key, for example api/v2/findings/?cwe= -> the filter will not be active and it'll return all the findings (I assume that it's the expected behavior ?)
If there's one or two existing CWEs  api/v2/findings/?cwe=111,222 -> it'll return the findings for both CWE 111 and 222
If the filter contains a number for existing CWEs and non existing CWEs only the findings for existing CWEs will be returned.

Let me know if that makes sense, if it does I'll continue to work into that direction.

Sounds good to me

One thing that I'm not sure is how do we want to accept list of parameter as input, do we want to repeat the key (/?id=101404&id=7267261) or pass a comma-separated list of values ? (/?id=101402,7267261)

I answer my question myself in the mean time, I'll go with /?id=101402,7267261 as most of the filters only support this style. @valentijnscholten I've removed the WIP on my side I think I'm good.

Would be really useful to get this merged.
I need filtering by date, and was just about to open a PR with a more simplistic approach like
filter_fields = {
        'id': ['exact'],
        'title': ['exact', 'icontains'],
        'date': ['exact', 'gt', 'lt', 'gte', 'lte'],
        'severity': ['exact', 'in'],
        'description': ['exact', 'icontains'],
        ...

But this is much nicer and extensive

Still feels that the cve=1&cve=2&cve3 is the more natural choice, but when looking around I see the csv based approach also being used sometimes. It's even supported by django in by user getlist() on request objects. But I can't find any native support for either way in the Django Rest Framework.  So might be almost good to go.

Would be really useful to get this merged.
You speed up the review/merge process by merging locally and testing it :-)

Still feels that the cve=1&cve=2&cve3 is the more natural choice, but when looking around I see the csv based approach also being used sometimes. It's even supported by django in by user getlist() on request objects. But I can't find any native support for either way in the Django Rest Framework. So might be almost good to go.

Yes I agree, that would have been my preferred choice if the framework supported it properly.

Thanks so far. I tempted to ask for a small addition to test_rest_framework.py to touch at least once upon this new filter type?

Thanks so far. I tempted to ask for a small addition to test_rest_framework.py to touch at least once upon this new filter type?

Of course !

@valentijnscholten I quickly checked and there's already some tests for the FindingViewSet https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/unittests/test_rest_framework.py#L182 that I modified part of this PR, so they should already validate this new filter.
I'm not super familiar with this test framework, is there anything in particular that you want me to add ? Or a new test targeting something specific that I've added ? Any hints are welcome :)

@valentijnscholten any news regarding my last comment ?

@xens you have a conflict to resolve to clear this up.
I re-requested @valentijnscholten 's quick review on this too, so we can move forward.

The conflict was easy to fix, so I went ahead and did it. Let's wait for the travis checks to (successfully) complete.

The conflict was easy to fix, so I went ahead and did it. Let's wait for the travis checks to (successfully) complete.

Awesome thanks for fixing that, I was waiting for this PR to be merged before doing the same for the /products/ endpoint

Does the swagger output also look OK with this new filter in place? We recenlty made an effort to make the swagger spec 100% so users can easily generate api wrapper from it via openapi for example. Would be good to check that.

I think it does, if you want to cross check I'm adding the /findings/ GET Swagger json output here findings_get.zip.
I also cross-checked the serialization format on the Swagger documentation and the syntax /findings?key=value1,value2  is something valid (see Query Parameters section).

I'm not that into swagger/openapi json, but I see also in current dev the swagger docs for findings_list have almost no specs on filtering. At some point we may want to look at that because a good api spec can generate good wrappers so we don't need to maintain our own wrappers. approving now so you can continue with the other PRs as well.

I need someone to click on merge :pray: ;)

I guess I just hit a breaking change with engagement__test.. more on https://owasp.slack.com/archives/C014H3ZV9U6/p1602624904093500

I guess I just hit a breaking change with engagement__test.. more on https://owasp.slack.com/archives/C014H3ZV9U6/p1602624904093500

Fixed by https://github.com/DefectDojo/django-DefectDojo/pull/3000


Failed to suppress a finding

General Issue
Failed to suppress a finding
The Question
I have the following construct:
/**
 * Copyright 2021 Amazon.com, Inc. and its affiliates. All Rights Reserved.
 *
 * Licensed under the Amazon Software License (the "License").
 * You may not use this file except in compliance with the License.
 * A copy of the License is located at
 *
 *   http://aws.amazon.com/asl/
 *
 * or in the "license" file accompanying this file. This file is distributed
 * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
 * express or implied. See the License for the specific language governing
 * permissions and limitations under the License.
 */

import * as cdk from "aws-cdk-lib";
import * as lambda from "aws-cdk-lib/aws-lambda";
import { Construct } from "constructs";
import { spawnSync } from "child_process";
// import { NagSuppressions } from "cdk-nag";

/* eslint-disable @typescript-eslint/no-empty-interface */
export interface CsharpLambdaConstructProps {
    codePath: string;
    environment?: { [key: string]: string };
    name?: string;
    timeout?: cdk.Duration;
    vpc: cdk.aws_ec2.Vpc;
    runtime?: lambda.Runtime;
    handler: string;
    memorySize?: number;
}

const defaultProps: Partial<CsharpLambdaConstructProps> = {
    timeout: cdk.Duration.minutes(1),
    runtime: lambda.Runtime.DOTNET_6,
    memorySize: 1024,
};

/**
 * Deploys C# Lambda function in a particular VPC.
 */
export class CsharpLambdaConstruct extends Construct {
    public instance: lambda.Function;
    public config: CsharpLambdaConstructProps;

    constructor(parent: Construct, name: string, props: CsharpLambdaConstructProps) {
        super(parent, name);

        props = { ...defaultProps, ...props };

        const lambdaFunc = new lambda.Function(this, "Instance", {
            /* eslint-disable @typescript-eslint/no-non-null-assertion */
            runtime: props.runtime!,
            handler: props.handler,
            code: lambda.Code.fromAsset(props.codePath, {
                bundling: {
                    local: new CsharpBundler(props.codePath),
                    image: props.runtime!.bundlingImage,
                    command: [
                        "bash",
                        "-c",
                        ["dotnet publish -c Release -o /asset-output"].join(" && "),
                    ],
                    user: "root", // ~/.dotnet is only accessible by root
                },
            }),
            timeout: props.timeout,
            environment: props.environment,
            vpc: props.vpc,
            memorySize: props.memorySize,
        });

        // NagSuppressions.addResourceSuppressions(
        //     lambdaFunc,
        //     [
        //         {
        //             id: "AwsSolutions-IAM5",
        //             reason: "Disregard IAM issue to default role assigned to a lambda.",
        //         },
        //     ],
        //     true
        // );

        // Assign Cfn Outputs
        new cdk.CfnOutput(this, "InstanceName", {
            value: lambdaFunc.functionName,
        });

        // Assign public properties
        this.instance = lambdaFunc;
        this.config = props;
    }
}

/**
 * Bundles a C# Lambda function locally for auto-deployment.
 */
class CsharpBundler implements cdk.ILocalBundling {
    private codePath: string;

    constructor(codePath: string) {
        this.codePath = codePath;
    }

    public tryBundle(outputDir: string): boolean {
        // Note that we _must_ specify the target runtime as linux-x64
        // because .NET Lambda functions run on top of Amazon Linux 2
        // On non-Linux operating systems, we're effectively cross-compiling
        const args = [
            "publish",
            "-c",
            "Release",
            "-o",
            outputDir,
            "--runtime",
            "linux-x64",
            "--no-self-contained",
        ];

        try {
            spawnSync("dotnet", args, {
                cwd: this.codePath,
                stdio: ["ignore", process.stderr, "inherit"],
            });
        } catch {
            return false;
        }

        return true;
    }
}

One of the findings is:
"AwsSolutions-IAM5","Lambda/Instance/ServiceRole/DefaultPolicy/Resource","Non-Compliant","N/A","Error","The IAM entity contains wildcard permissions and does not have a cdk-nag rule suppression with evidence for those permission."

I attempted to suppress it:
         NagSuppressions.addResourceSuppressions(
             lambdaFunc,
             [
                 {
                     id: "AwsSolutions-IAM5",
                     reason: "Disregard IAM issue to default role assigned to a lambda.",
                 },
             ],
             true
        );

However, the suppression did not work. Any advice?
cdk-nag version
2.15.3
Language
Typescript
Other information
No response

this.instance = lambdaFunc;
Are you adding permissions to the lambda function outside of the construct? It doesn't look like you've added any permissions to the Lambda function at the time of suppression so we may be seeing an error related to order of operations.

Are you adding permissions to the lambda function outside of the construct?

@dontirun , I am adding suppression inside the construct.

It doesn't look like you've added any permissions to the Lambda function at the time of suppression so we may be seeing an error related to order of operations.

These permission are there by default. The role for cloudwatch logs with default policy (ServiceRole/DefaultPolicy/Resource) gets created as part of lambda.Function.

I tried recreating this locally ,but I'm not seeing any AwsSolutions-IAM5 errors. Do you have a snippet for the stack that is using this construct?

Closing due to inactivity


no visual mode with vim-airline

vim v7.4
vim-airline v0.6
vim-multiple-cursors v2.2
putty 0.63
When i do ctrl-n multi selection works correctly. But my mode shows as NORMAL in vimair, I think it should be VISUAL ? If i press i get the error:
 Key 'i' cannot be replayed at 2 cursor locations

If i press v first it works correct. Not sure if this is a vimair issue or if i'm doing something wrong...

Seeing the same issue here!

Duplicate, see #42


If client requests latest page version with an LSN, check that no newer version exists.

Each GetPage request contains 'latest' parameter, and an LSN. When 'latest' is true, the LSN is a hint to the page server that there are no page versions newer than that LSN. We should sanity-check that there indeed aren't any newer page versions, and throw a warning or error if there are.

Related PR is merged, can this be closed? @hlinnaka

Related PR is merged, can this be closed? @hlinnaka

No, this issue is about adding an additional sanity check. When client requests the latest page, and the request includes an LSN, it means that there should not be any newer page version of the page after that LSN. We could check that in the page server, to notice earlier that the client is confused with the requests it's making.

this is blocked till #1338 is resolved and #936 is merged & integrated

@LizardWizzard is this still relevant ?

The context is still valid. We dont have such a check. Not sure if it can be cheaply added. @hlinnaka wdyt?


FINOS : Duplicate entry appears for foreign user (peterschrammel) under APPROVED CONTRIBUTORS list for "Scott Logic" organization at FINOS project

Steps :

Navigate to Signature tab : https://projectadmin.lfx.linuxfoundation.org/project/a092M00001JwBlEQAV/tools/easycla/overview/5564f18f-3252-40fc-a65b-2eef1ad45fcd/signatures
Open Signed CCLAs tab
Search Organization "Scott Logic"
Click on View All Approved Contributors

Actual Results  : Duplicate entry appears for foreign user (peterschrammel)

Expected :

Same results for Symphony LLC organization

Same results for UBS organization

Same results for JP Morgan Chase organization

@thakurveerendras Kindly verify .Removed these records that happened to be related to LinuxFoundation bot.

peterschrammel user information is removed as expected , So making issue status QA-Done
JP MORGAN CHASE

openfin

UBS

SYMPHONY LLC

Scott Logic


How to make a local server global?

[ ] Add a global server capability.

There are two ways to do this:
--bind-addr <IP_ADDRESS> option
--bind-addr BIND_ADDR
                        <IP_ADDRESS> for global, <IP_ADDRESS> for local (default: <IP_ADDRESS>)

It simply accepts access from all IP addresses to waifu2x.web instance.
You need to open the port by setting up router, firewall, etc.
This method is useful for small public access. For example, only a few friends have access.
nginx reverse proxy
waifu2x.udp.jp is managed in this way.
The advantage is that static files can be served directly from public_html/ file system.
An example setting can be found in https://github.com/nagadomi/nunif/tree/master/waifu2x/web/appendix .

I added docs on this. https://github.com/nagadomi/nunif/commit/c65574e1df29444340bc43c6dc5495ec384005ce

@nagadomi It didn't help.

@My12123
"http://<IP_ADDRESS>/" works on Linux and macOS, but not on Windows.
It is just a URL print problem of the http server library.
Use "http://<IP_ADDRESS>:8812" even if "--bind-addr <IP_ADDRESS>" is specified.


Flip xy coordinates in ENVI files

Fixes #150

@wincowgerDEV, could you maybe have a second look if the coordinates are correct now? No worries, builds are failing only because I haven't updated the tests yet ..

Not quite sure how to write a test for this but I think I got it figured out, the dcast needed to be updated too. Committing soon.

I think we got it now.

Thanks, Win!


Create bellman_ford.cpp

Bellman-Ford's single source shortest path to all the vertices
Description of Change

Checklist

[x] Added description of change
[ ] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

This is a PR for the hacktoberfest. Please consider the same after reviewing.


Fix the documentation error for controller in apictl 3.0  and 2.0

Description:
In the API CTL docs of APICTL 3.0[1] and 2.0.13[2], the api_param.yaml key related to certificate host name has to be updated. Currently the structure of the parameter file is listed as follows.
    - name: <environment_name>
      endpoints:
          production:
              url: <production_endpoint_url>
              config:
                  retryTimeOut: <no_of_retries_before_suspension>
                  retryDelay: <retry_delay_in_ms>
                  factor: <suspension_factor>
          sandbox:
              url: <sandbox_endpoint_url>
              config:
                  retryTimeOut: <no_of_retries_before_suspension>
                  retryDelay: <retry_delay_in_ms>
                  factor: <suspension_factor>
      gatewayEnvironments:
        - <gateway_environment_name>
      certs:
        - hostName: <endpoint_url>
          alias: <certificate_alias>
          path: <certificate_file_path>

It has to be updated to
environments:
    - name: <environment_name>
      endpoints:
          production:
              url: <production_endpoint_url>
              config:
                  retryTimeOut: <no_of_retries_before_suspension>
                  retryDelay: <retry_delay_in_ms>
                  factor: <suspension_factor>
          sandbox:
              url: <sandbox_endpoint_url>
              config:
                  retryTimeOut: <no_of_retries_before_suspension>
                  retryDelay: <retry_delay_in_ms>
                  factor: <suspension_factor>
      gatewayEnvironments:
        - <gateway_environment_name>
      certs:
        - host: <endpoint_url>
          alias: <certificate_alias>
          path: <certificate_file_path>

If the api_params.json file is used, we can use the hostName key. However since we are not mentioning anything about a json params file, we can omit that. We have to update the examples as well.
This has been fixed in the product from APICTL 3.1 onwards.
[1] - https://apim.docs.wso2.com/en/3.0.0/learn/api-controller/advanced-topics/configuring-environment-specific-parameters/
[2]- https://docs.wso2.com/display/AM260/Building+CICD+Pipeline#BuildingCICDPipeline-ImportingEndpointCertificates

This is now fixed in APICTL 2.0.x [1] and for APICTL 3.0.0 via [2].
[1] https://docs.wso2.com/display/AM260/Building+CICD+Pipeline#BuildingCICDPipeline-Addingenvironment-specificparametersforAPIs
[2] https://github.com/wso2/docs-apim/pull/3079


Admin Config broken in develop

template: admin/config:105:50: executing "admin/config" at <.Webhook.TaskInterva...>: TaskInterval is not a field of struct type interface {}

I'm not familiar enough with the project, nor with go, to totally understand the error but by inspecting models/webhook.go it looks like there is no such TaskInterval. So, maybe an option that has been removed?
Removing lines 104-105 from templates/admin/config.tmpl solves the problem but that would be the solution only if TaskInterval makes no sense anymore. Otherwise I don't know how to debug the problem.
By the way, what is that admin/config page for? It is just an info page, isn't it? I can't change any value in there.

Rhis page is for display only. This option have been reppaced with the realtim webhook commit. This fix have to be added.

Ok, I'm going to prepare a PR removing those lines from the template and the corresponding locale value/pairs.

This is the replacement: https://github.com/gogits/gogs/commit/fa298a2c30c358dbfa47fc123c6aca83fe9eb999#diff-c4893a32340ee2cee87e664d67f8abf3R95

TaskList was showing minutes as unit, Does QueueLength integer a value in any unit?
Not sure if I follow the code properly but looks like if TaskInterval had 1 as default value, so 1 minute. And now QueueLength default is 1000. There is not a correlation between 1 minute and 1000 something. Don't know if it should be any correlation.

I understand Queue Length has no special units so I have created the PR https://github.com/gogits/gogs/pull/1393 that should solve this issue. Thanks @tboerger for the explanation.
I updated the locale files but there must be something that I don't understand as the translation for QueueLength is not working yet even after a rebuild with go build. Some different build for locales maybe? Actually there are more locales that doesn't work on my installation as those from the issues pages.

Hi @manfer , thanks your PR and for your questions:

QUEUE_LENGTH is the maximum length of queue(a Go cached channel size). It may not make sense to you but just like a bucket size if this way helps.

As @tboerger mentioned in #1393, you need have to run go-bindata command as described here

I've did go-bindata thing for you and pushed to develop branch.


MKRWAN 1300

Hello,
This library looks great (and better documented than the MKRWAN library). But do you know what the pin settings are for the MKRWAN 1300 board? This board contains the SX1276 transmitter, but it is build in, and I can't get the library to work on that board

Hi @lodesmets
theoretically it should work, the pins for SPI are
SPI
https://github.com/arduino/ArduinoCore-samd/blob/master/variants/mkrwan1300/variant.h#L111
but you must mode the module in SPI mode as they do in the LoRa library
https://github.com/sandeepmistry/arduino-LoRa/blob/dff276e26845727049a48a624d0eb2b545f3bb6a/src/LoRa.cpp#L75
with pins
Lora RESET and BOOT
https://github.com/arduino/ArduinoCore-samd/blob/master/variants/mkrwan1300/variant.h#L71
one drawback of the MKR1300 is that it does not have access to the DIO pines

Thanks for the response @sabas1080,
But the arduino lora library only requires DIO0 and this library requires DIO0-5.
What about those, what should those values be?

Those DIOx pins on the MKR1300 are not connected to the samd21


#2199 Adds function, param logging to all lbrynet jsonrpc functions

Fixes #2199

@osilkin98 what's the next step here? does it need a review?

Yes, this is review-ready.

On Sep 4, 2019, at 10:47 AM, Alex Grin<EMAIL_ADDRESS>wrote:
@osilkin98 what's the next step here? does it need a review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


add woff- and svg-compression

##Sample shopware.woff
Original-size: 69,4 KB
After Compression-Sample: 33,5 KB
Description

Questions
Answers

Why?
Saving traffic

BC breaks?
no

Tests exists & pass?

Related tickets?

How to test?
have a look in Developer Tools, before and after implementation

Requirements met?
hope so

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19755.
Please use this issue to track the state of your pull request.

thanks for your contribution @tinect :+1: :tada:


Research and catalog raster operations to perform with GeoTrellis service

Undertake some research into raster data -- and raster operations which can be performed with GeoTrellis's Collections API.
The ultimate aim of this task is to determine a set of raster operation endpoints to create for the REST service set up in #2; the deliverable here can be an ADR to be checked into the repo or a blog post potentially for the Azavea blog.

Completed in 3e0729b and da93a27


Add specific tifffile reader

Adds a reader using tifffile to access images and their pyramids.

closed by #23.


Fix copyright in README

Signed-off-by: John Mazanec<EMAIL_ADDRESS>Description
Modify Copyright Description in README. I could not find other instances outside of the README.
Related: https://github.com/opensearch-project/.github/pull/24
Issues Resolved
#75
Check List

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #76 (4cacfab) into main (ff057f0) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #76      +/-   ##
============================================
- Coverage     82.70%   82.48%   -0.22%
+ Complexity      476      474       -2
============================================
  Files            69       69
  Lines          1821     1821
  Branches        178      178
============================================
- Hits           1506     1502       -4
- Misses          253      257       +4
  Partials         62       62

Impacted Files
Coverage Δ

.../java/org/opensearch/knn/index/util/KNNEngine.java
89.47% <0.00%> (-5.27%)
:arrow_down:

...n/java/org/opensearch/knn/index/KNNIndexCache.java
92.38% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff057f0...4cacfab. Read the comment docs.

@dblock makes sense, will update.
Which ODFE references are you referring to? I see the one in the NOTICE.txt, but there are also the licenses in the code (I assume this is not what you are talking about).

@dblock makes sense, will update.
Which ODFE references are you referring to? I see the one in the NOTICE.txt, but there are also the licenses in the code (I assume this is not what you are talking about).

I only meant OpenDistroForElasticsearch in the NOTICE


[tmp] fast_csr_matrix replacement

This is just a draft showing the differences so far - it's not even a proper commit, but I had to actual create an object to push to GitHub.  This commit will actually be several once I've finished it, and several parts will still probably change.
This will build and import, but won't pass the tests yet - it's nowhere near a complete switch over to the new type, but I've done a good chunk of it.
Improving timings
I've started to enforce a separation of concerns between the data layer, but not entirely yet.  The biggest change is that Qobj is now much stricter about enforcing correct dimensions and type interactions.  This actually makes the code way shorter, and Qobj operations like multiplication, addition and matrix multiplication now have massively reduced overheads.  For large systems obviously this doesn't make a huge amount of difference, but qubit spaces have a huge speed boost.  Examples (qutip is this branch, qutip0 is the current master):
In [1]: import qutip, qutip0
   ...: qi = qutip.qeye(2)
   ...: qi0 = qutip0.qeye(2)

In [2]: %timeit qi * qi
   ...: %timeit qi0 * qi0
30.5 µs ± 54.8 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)
71.7 µs ± 179 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [3]: %timeit 2 * qi
   ...: %timeit 2 * qi0
6.81 µs ± 44.6 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
55 µs ± 329 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [4]: %timeit 1 + qi
   ...: %timeit 1 + qi0
12 µs ± 113 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
513 µs ± 4.62 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

In [5]: %timeit qi + qi
   ...: %timeit qi0 + qi0
5.97 µs ± 18.3 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
111 µs ± 647 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

Matrix multiplication should actually be faster than 30µs, but it's currently slow because I haven't passed 'type' to the Qobj constructor afterwards, so it spends ~25µs inferring the type of the object on initialisation.  There may not be a way to avoid this with matrix multiplication, but it's a clear source of slow-down in Qobj initialisation, so it's a prime target for getting an optimised Cython backing.
Matrix multiplication
The most major change that I've made here that actually needs to be discussed is the changes to dimension handling in __mul__.  For one, I split the code handling __mul__ into two parts:

__mul__ handles multiplication with a scalar
__matmul__ handles actual matrix multiplication

I haven't actually changed which operator you need - you can still do Qobj * Qobj and it'll do matrix multiplication.  I just split the code into two places so it's easier to reason about.  As a side effect, you can also do Qobj @ Qobj now too, but it's not necessary.  We can also talk about what we want to do about the dimension handling in __mul__ and __matmul__.  Right now, it checks for dimensions after the multiplication for [1, 1] and removes any it finds.  This isn't entirely consistent, especially with handling spaces that went in as 1D.  I think we should change it, and there's two possible ways:

Completely remove this handling, and just have __matmul__('bra', 'ket') return a scalar, everything else follows the normal rules.
Keep the handling as it is, but change its logic so that a space has to become [1, 1] to be contracted.

I think method 1 is much simpler for most people - you no longer have to do anything like (bra * ket).data[0, 0] or (bra * ket).norm() to get the value (although of course you can always use bra.overlap(ket) which is faster!).  Method 2 is somewhat better with handling 1D spaces than the current method, except if you have lots of them tensored together, some of which are 'oper' and some of which aren't.  The advantage of method 2 over method 1 is that you can do (say)
>>> state = qutip.basis([2]*3, [0]*3)  # dims=[[2, 2, 2], [1, 1, 1]], type='ket'
>>> contractor = qutip.tensor(qutip.qeye(2), qutip.basis(2, 0).dag(), qutip.qeye(2))
>>> contractor * state
Quantum object: dims = [[2, 2], [1, 1]], shape = (4, 1), type = ket
Qobj data = ...

so I can define an object like X = I.<g| .I and a state |y> = |g>.|g>.|g>, i.e. a state on H_2^3, and X|y> is now a state on H_2^2.  I think the main argument against method 1 is that there isn't currently a nice way to do this kind of operation - you'd have to do something like X = I . |g><g| . I, then (X * y).ptrace([0, 2]).
We could also just have it both ways.  We can pick a way we like and bind that to __mul__ (I'd suggest method 1 for this because its logic is more consistent), and have __matmul__ do the other.  Then you have * is the default multiplication operator, and @ is the "contracting" multiplication operator (and have a setting for which is which).

Don't miss that the file qobj.py has a huge diff, it's just not expanded by default.


Promote arm64 macOS to tier 1

Summary
Github recently added a new macOS runner that is using the m1 CPU that is usable for open source projects. [1] Previously Qiskit had support for arm64 macOS at tier 3 because we were only able to cross compile for the platform and not test the binaries. Now that we can run CI jobs on the platform we're able to run both unit tests and test our binaries on release. This commit adds a new set of test jobs and wheel builds that use the macos-14 runner that mirrors the existing x86_64 macOS jobs we have. This brings arm64 macOS to the same support level as x86_64. THe only difference here is that azure pipelines doesn't have arm64 macOS support so the test job will run in github actions instead.
Details and comments
[1] https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

I've marked this as on hold until we verify the job configurations work.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.001%) to 89.338%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
94.03%

crates/qasm2/src/lex.rs
5
92.88%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
60236

Relevant Lines:
67425

💛  - Coveralls

So there are 2 big issues so far with this. The first is 6 to 12 tests are failing because of numpy precision issues that probably come down to SIMD differences or issues with accelerate on arm64. This also causes the PGO test runs to fail in the wheel builds.
The second issue is that there are no Python 3.8 official Python binaries available on macOS arm64. We were previously publishing arm64 py3.8 wheels with cross compilation on x86_64, but now that we're doing native builds for arm64 the builds fail because it tries to run with x86_64 python. I think the only path to workaround that is to add back the cross-build job and have it only run for python 3.8. This precludes doing PGO, but I think the number of arm64 macOS Python 3.8 users will be very low if there aren't official Python packages for it so that's an ok tradeoff.

I've pushed up #12197 to remove linear algebra with numpy from the equation in the isometry code path to fix the issues we're having here. This should be good to go once #12197 merges and we update the PR branch
I've tested that tests work here: https://github.com/mtreinish/qiskit-core/actions/runs/8730127221 and I'm debugging the wheel builds here: https://github.com/mtreinish/qiskit-core/actions/runs/8730127218/job/23953358067 once that's working I'll remove the test commits from this branch to get this in a mergable state again.
The only other change I think we should make here is tweaking one of the test jobs to run with MSRV instead of the latest stable. But that's trivial to do.


Error in example for Flask

The provided example for Flask is incorrect:

It should read

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed35685d-e409-d962-c450-7297a1f3c003
Version Independent ID: 224fab0f-fd26-396f-cdd8-921533d2aeba
Content: Configure Python web apps for IIS - Visual Studio (Windows)
Content Source: docs/python/configure-web-apps-for-iis-windows.md
Product: visual-studio-windows
Technology: vs-python
GitHub Login: @JoshuaPartlow
Microsoft Alias: joshuapa

Trying again, XML markup was blocked.
Changed "<" for "[, ]" brackets.
The provided example for Flask is incorrect:
[!-- Flask apps only: change the project name to match your app --]
[add key="WSGI_HANDLER" value="flask_iis_example.app"/]
It should read
[!-- Flask apps only: change the project name to match your app --]
[add key="WSGI_HANDLER" value="FlaskAzurePublishExample.app"/]

@Sultaneous -- Karim, thank you for catching this.  I am updating the article.

Noted.  Now that’s a useful tip!
Thanks,
Karim
From: William Anton @.>
Sent: September 27, 2021 6:23 PM
To: @.>
Cc: Karim @.>; @.>
Subject: Re: [MicrosoftDocs/visualstudio-docs] Error in example for Flask (#7057)
@Sultaneoushttps://github.com/Sultaneous -- Karim, for future reference, you can enclose code blocks in here with triple back ticks ``` and they will render literally:

@JoshuaPartlowhttps://github.com/JoshuaPartlow, please review private PR 8744https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/8744.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/visualstudio-docs/issues/7057#issuecomment-928362105, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABUVQOJM7UM4ZILMZ3IP6ELUEDVETANCNFSM5EEEQV6Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


xml-stylesheet tag isn't highlighted and breaks everything that follows

<?xml version="1.0"?>
<?xml-stylesheet type="text/xsl" href="test.xsl"?>
<doc>
  <title>Document Title</title>
  <chapter>
    <title>Chapter Title</title>

      <title>Section Title</title>
      <para>This is a test.</para>
      <note>This is a note.</note>

      <title>Another Section Title</title>
      <para>This is <emph>another</emph> test.</para>
      <note>This is another note.</note>

  </chapter>
</doc>

The issue was in Helix, they use this grammar as I see.

I also just ran into this in Helix. As a work around in Helix, you can set the language to HTML, but it would be nice to fix this grammar.
It seems adding any <? ... ?> construct that isn't the xml one at the beginning of the document breaks parsing.

here's the problem: https://github.com/RenjiSann/tree-sitter-xml/blob/main/grammar.js#L79
the spec uses - to represent taking the complement between the two sets. In this case, I think it means any string of length 0 or greater except for any strings of length 0 or greater that contain the substring ?>. However, in the current grammar, it's parsing the literal character -. I can't think of a way to translate the spec into a regex that doesn't use lookahead. I'm guessing the best bet is to use a heuristic like [^?]* to match the processing instruction content.


More complete example how to run phpunit on an own extension

Question
Can we provide a more complete example how to continue after the Shopware installation? Would we move the extension under test to to the custom/ folder or composer require it ? What is the intended use?

does this example help?
https://github.com/FriendsOfShopware/FroshPlatformTemplateMail/blob/main/.github/workflows/unit.yml

Absolutely! Thanks :-) Might include it into the readme somehow?

We should add that to the readme.
PS: We managed also setting up for integration tests like this:
https://github.com/iMi-digital/shopware6-password-site/blob/develop/.github/workflows/php.yml

maybe we can add this installation step into this action with an optional input parameter 🤔.

That would be awesome

I saw that the phpunit bootstrap also seems to setup the test database automatically, so not sure how much of the installation we need here.

Yes, when you just want to run phpunit tests you don't need that. The TestBootstrapper will do everything. It makes still sense to have it for E2E testing

I adjusted some the README is that fine?


Broken Styles for iPhone

Expected behaviour
If you open the video in full screen in a vertical position, the picture will be in the center.
Actual behaviour
If you open the video in full screen in a vertical position, then the picture will be at the top.
Steps to reproduce
Go to site and open the video.
Environment

Browser: Safary
Operating System: iOS
Version: 14.8, 15.2
Device: iPhone.

I think the problem is that margin: auto doesn't work on iPhone.

The problem seems to stem from your styles as the demo site works as expected. I'll do some digging.

Updating to the latest styles should fix this. It looks like you're using an older version.


Configurable sum encoding

I need to parse the Pandoc format which is produced via aeson. aeson supports configuring the sum encoding which is done as follows in Pandoc:
Aeson.sumEncoding = Aeson.TaggedObject "t" "c"

Obviously, this consumes more space than the current approach chosen by uPickle:
  def annotate[V: ClassTag](rw: R[V], n: String) = R[V]{
    case Js.Arr(Js.Str(`n`), x) => rw.read(x)
  }

Would it be possible to not import annotate by default, so that I could define it manually?
This feature would significantly increase interoperability with other picklers as there doesn't seem to be a common standard on how to serialise classes.

Possible. Would require some thought as to how to make it work well. Not sure whether typeclasses or virtual-classes would be the way to go for this

Here's my first attempt: https://github.com/tindzk/upickle/tree/change-sumencoding
It doesn't work as expected since the implicit is not resolved properly. Do you have any idea how to fix it?

This is fixed in master https://github.com/lihaoyi/upickle-pprint/blob/master/upickle/shared/src/main/scala/upickle/Api.scala#L7-L40
Now you can define your own upickle bundle and override the CaseR/CaseW sum encoding, swap between the old array-wrapped typetags and type-attribute typetags, and other things. By default I provide import upickle.legacy._ for the old encoding and upickle.default for a seemingly much-more-useful default encoding

Great, thanks!


Bumps steve

For: https://github.com/rancher/rancher/issues/25675

This can't be merged.  Sorry.  It will break things.  It's related to https://github.com/rancher/rancher/pull/25674


Reading mode

In this mode all the markdown shall be interpreted,
This page should not offer any possibilities for edit.

Library for rendering Markdown https://github.com/markdown-it/markdown-it


React to Options/Rename Configure => Add

Overload for UseCookie that takes IOptions instance (for identity/multi cookie usage)
Rename Configure methods => Add for consistency

@Tratcher

Fixes https://github.com/aspnet/Security/issues/417

:shipit:

bf2b771eabcccfd6317e50366d4869f66090b23c


App will Terminate brodcast still running

If I force close my app, the broadcast still running and streaming my room.
I am using ReplayKit Example App.

Hi @ArifJezir this is an interesting situation. Does your main app have a participant connected to the video room? If so the video room will detect that the main app participant has disconnected 30 seconds after the app is force quit. The broadcast extension could listen for remote participant disconnect events on the video room. When the main app participant disconnects the broadcast extension could detect it and handle the case. Does that make sense?

Hi @timrozum
I send the different tokens to the broadcast extension. if I leave room in my app, the extension still running and the room is not disconnected after 30 secs. I found the solution . if I leave room in my app,  the extension class "SampleHandler" room delegate function - participantDidDisconnect called. so I check my current identifier disconnect, I will disconnect room and screen sharing.
func participantDidDisconnect(room: Room, participant: RemoteParticipant) {
    if let testUserId = userDefaults?.object(forKey: "userId") as? Int {
        if testUserId.description  == participant.identity.components(separatedBy: "<>")[2] {
            self.room?.disconnect()
            self.audioTrack = nil
            self.videoSource = nil
            self.screenTrack = nil
            let userInfo = [NSLocalizedFailureReasonErrorKey: "You have Stopped Screen Sharing"]
            finishBroadcastWithError(NSError(domain: "ScreenShare", code: -1, userInfo: userInfo))
        }
    }

}


fix(HLS): Adding support for DTS Express in HLS fMP4 (#5112)

The SampleEntry box in the SampleDescription (stsd) box will have the codingname 'dtse' for DTS Express audio tracks.
This is defined in Table E-1 of ETSI TS 102 114 V1.6.1 (2019-08) DTS Coherent Acoustics; Core and Extensions with Additional Profiles.
The 'dtse' codingname has been added to the AUDIO_CODEC_REGEXPS_ list, which enables support for playback of DTS Express in HLS fMP4 streams.
The 'ddts' and 'udts' entries have been removed from the AUDIO_CODEC_REGEXPS_ list, as these are not audio codec identifiers, but FourCC values for the DTSSpecificBox and DTSUHDSpecificBox, which can be found within the SampleDescription box for DTS audio tracks.
The DTSSpecificBox (ddts) is defined in Section E.<IP_ADDRESS> of ETSI TS 102 114 V1.6.1 (2019-08) DTS Coherent Acoustics; Core and Extensions with Additional Profiles.
The DTSUHDSpecificBox (udts) is defined in Table B-2 of ETSI TS 103 491 V1.2.1 (2019-05) DTS-UHD Audio Format; Delivery of Channels, Objects and Ambisonic Sound Fields.
The Mime Types for the DTS formats supported by Shaka Player have been added to the probeSupport function.

I'm going to wait to merge it until all the tests pass


Migrate to Raycast useFetch

Description

Try to solve #5002 by migrating the HTTP request client to Raycast useFetch.
Screencast

N/A
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks a lot! I forgot it😀

@pernielsentikaer I think @raycast/utils has a bug here.
// Initial State
{
  isLoading: true, // or `false` if `options.execute` is `false`
  data: undefined,
  error: undefined
}

options.execute is false at start, however isLoading is true from useFetch, thus you see the loading animation.

If you update to @raycast/utils version 1.5.2 it should be resolved 😊

@pernielsentikaer Yes indeed. It's ready for review.


consider using mapped main and secondary topics from explore backend

perhaps with a dynamic form search through all options??

version 5? 6?


ax9000 problem with "5G Game" wifi

2021-10-28 22:22:14 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/config/custom_components/miwifi/core/luci_data.py", line 168, in refresh
await self.async_update()
File "/config/custom_components/miwifi/core/luci_data.py", line 93, in async_update
await self.api.prepare_data()
File "/config/custom_components/miwifi/core/luci.py", line 133, in prepare_data
await self.set_devices_list()
File "/config/custom_components/miwifi/core/luci.py", line 225, in set_devices_list
device["connection"] = CONNECTION_RANGES[device["type"]]
KeyError: 6

Fixed the bug itself, but haven't added support for new types yet. For this I would like to ask for help. Can you send the output of the following command http:///cgi-bin/luci;stok=/api/misystem/devicelist
mac addresses and ip can be removed if desired.

Annswer sent to your email address

Annswer sent to your email address

if it's not difficult, you can also output: http://(your ip)/cgi-bin/luci;stok=(your stock)/api/misystem/newstatus

Annwer sent to your email address

https://github.com/dmamontov/hass-miwifi/releases/tag/v1.2.7
Added support for 6G Game mode


Setting the 'cell' without Cell.all(interface)[x]

This is not a bug, but I didn't know where to ask.
Is it possible to set the 'cell' without actually searching for the available APNs?
cell = Cell(ssid=APN) obviously doesn't work, so I'm looking for a solution.
Doing Cell.all(interface)[x] is fine, as long as the index of the access point doesn't change, but if does, scheme.activate() will fail.
Thanks

I think the following might be what I'm looking for.
"
classmethod from_string(cell_string)
Parses the output of iwlist scan for one cell and returns a Cell object for it.
"
However, when I try Cell.from_string('Cell(ssid=MyCoolApn)') I get: 'Cell' object has no attribute 'encrypted'  - line 153 in scan.py

Hi @boobcoder,
Sorry for not responding earlier. I've been too busy lately.
You could use the where method on the Cell class for finding the specific interface that you want. Here's an example usage:
cell = Cell.where('wlan0', lambda c: c.ssid == 'MySSID')[0]
scheme = Scheme.for_cell('wlan0', 'nickname', cell)
scheme.save()
scheme.activate()

This might be what you want.
However, after the first time that you save it, you could just retrieve the saved scheme.
scheme = Scheme.find('wlan0', 'home')
scheme.activate()

I apologize if the docs weren't very obvious about this. So really, that's probably what you want.
As for from_string, it actually takes the output of the iwlist command, which you can see examples of here.

I'm going to close this for now, but feel free to reopen.


Measure kpocza's implementation

Please measure my implementation (https://github.com/kpocza/1brc) and add to the results table if it performs well on you machine.

Have you run 10K dataset on your side and compared its output with mine or Java?

Fair enough.
Changed the console's output encoding to utf8. Moreover there where sometimes 0.1 differences in avg calculation. Made it more precise. Now I see no differences.

The blog update is now deploying


Update node engine to >=8.10.0

Hi!
Thanks for the amazing work with tensorflow-js 🙂
I'm trying to use @tensorflowjs/tfjs-node with AWS Lambda but the engine field in package.json is conflicting. AWS Lambda is running on node 8.10.0.
I'm creating this PR to update the node engine to >=8.10.0. I think it would make sense because this package does not depend on any of the updates in the changelog from 8.10.0 to 8.11.0 and many people can't really choose their node engine.
Thanks!

This change is

I signed the CLA!

I just saw this : https://github.com/tensorflow/tfjs-node/pull/114#issuecomment-403565948
Maybe in the end it's better to keep it as >=8.11.0 🤔


add_test_pit

Description
Add test_pit.py to the tests folder.
Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_pit.py under upper directory of qlib.

Screenshots of Test Results (if appropriate):

Types of changes

[ ] Fix bugs
[x] Add new feature
[ ] Update documentation

It looks great!!


Release proposal: v1.29.0

I'm aiming to cut a new release during the week of May 12-18. Based on the commits that have landed, this will be version 1.28.1, but can become 1.29.0 if semver-minor commits land before the release is cut. If there are any questions, comments, concerns, or objections, please raise them here.

https://github.com/libuv/libuv/pull/2289 is semver-minor, so this is now v1.29.0.

libuv CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1395/
Node+libuv integration CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/95/

The failures in the libuv CI appear to be the normal cast of flaky tests. The only failure in the integration CI appears to be https://github.com/nodejs/node/issues/27611.
I'm going to move forward with the release.


Add rancher dns(RDNS) provider

#1097

/assign @Raffo

@njuettner  Thank you for your review. This PR has been modified according to your suggestion.

/unassign @Raffo
/assgin @njuettner

/assign @njuettner

@njuettner  Sure, I will add it now.

@njuettner  Thank you for your patience.
All the proposals have been revised.
Could you please review it again when you have time. :)

/lgtm
/approve


"field left undefined in constructor" compilation message if error raised outside of partial constructor

Summary
When an error is raised directly in a partial constructor, the compiler considers the constructor as partial and that it can fail at runtime (case # 1 in sample below). But if the error in that constructor is raised from a partial call to another class (cases # 2 or # 3 below), then the compiler does not see the constructor as partial and reports uninitialized fields. As consequence, compilation fails.
Sample code showing the bug
Playground

actor Main
  new create(env: Env) =>
    try
      let c = C.new_C(-45) ?
      env.out.print("Constructor succeded")
    else
      env.out.print("Constructor failed")
    end

class C
  let _f: I32

  new new_C(c: I32) ? =>
    if c < 0 then
      // #1: Error in constructor => No compilation error
      // error
      // #2: Error in another constructor => field left undefined in constructor
      let d = D.create() ?
      // #3: Error in another function => field left undefined in constructor
      // let e = E.foo() ?
    else
      _f = c
    end

class D
  new create() ? =>
    error

class E
  fun foo() ? =>
    error

Expected result
Compilation should succeed with cases # 2 and # 3.
Compiler version
Tested with compiler from Playground
0.51.4-fed8b38a [release]
Compiled with: LLVM 14.0.3 -- Clang-13.0.1-x86_64
Defaults: pic=true

The test in function verification pass could take into account that the constructor is partial before verifying that all fields are initialized:
  if(!verify_main_create(opt, ast) ||
    !verify_main_runtime_override_defaults(opt, ast) ||
    !verify_primitive_init(opt, ast) ||
    !verify_any_final(opt, ast) ||
    !verify_any_serialise(opt, ast) ||
    (ast_id(can_error) != TK_QUESTION &&
     !verify_fields_are_defined_in_constructor(opt, ast)))
    return false;

An enhancement could be made (but it could end up being expensive) to analyze all partial methods in the constructor and determine if they always error or if they might not error. In the case of might not error, then "field left undefined" is the correct error.

You're right, it was too late last night and the test I suggested could escape some non-initialized fields.
In fact, the sample code I provided is too broad (and does not reflect the situation I face). Here is a stricter sample where a constructor calls a second constructor that initializes all the fields and errors. Strictly speaking, all the class fields where initialized before the failure, but the compiler does not see it and compilation fails.
Simpler sample code
Playground
actor Main
  new create(env: Env) =>
    try
      let c = C.new_C(-45) ?
      env.out.print("Constructor succeded")
    else
      env.out.print("Constructor failed")
    end

class C
  let _f: I32

  new new_C(c: I32) ? =>
    new_C2() ?

  new new_C2() ? =>
    _f = 1234
    error

Thinking again about it, you're right that the compiler can't assert that all fields have been initialized without a global analysis of the AST. The current local analysis is probably the simplest and safest way to prevent creation of an object with uninitialized fields. The simplest workaround for the developer is to initialize all fields in the constructor, eventually with dummy values, even when it raises errors.
I'm going to close this issue.


Choice of Loss Function

Hi and thanks for sharing your code.
Why did you choose to use Kullback-Leibler divergence loss? I think in the original Hinton paper, its only used when training from an ensemble to weight the different teacher distributions. When training from only one model usually Cross Entropy is used between the high temperature soft max outputs.
Did you make any experiments with CE Loss? Or is there a specific reason to use KLDiv Loss instead?

Hi,
Actually, it is same in here. As the entropy of the teacher is constant and does not affect the gradients and the cross entropy is equal to the summation of the teacher's entropy and the KL loss, you can use both.

Ah right, I discovered that the scalar of the loss is different but didnt think about the gradients being the same. Thanks.


Enable SqsTemplate to send more than 10 messages at once

As discussed here, currently SqsTemplate fails if more than 10 messages are provided in a batch with an error from AWS SDK.
We can add support for this use case by partitioning the message list in batches of 10, while also sending the batches in parallel.
This change would likely be around here:
https://github.com/awspring/spring-cloud-aws/blob/562b9334821ea99d7eeac886e60dd59ef73451b3/spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/operations/SqsTemplate.java#L350-L356

@tomazfernandes  I started to work on it...If it's ok, can you assign this issue to me?

@tomazfernandes I'd be happy to provide a PR for this topic, in case you (@levys17) aren't working on it anymore.

@tomazfernandes I'd be happy to provide a PR for this topic, in case you (@levys17) aren't working on it anymore.

I didn't have time to finish that and I've barely worked on it in last weeks....so for me it'll be nice if you do that :D

@tomazfernandes
Currently, doSendBatchAsync sends all messages in a single batch request using the sqsAsyncClient, ensuring that FIFO queues maintain the order of messages. If we change to partitioning messages and sending batches in parallel, only messages within each batch will retain order, but the order of the batches may vary. What are your thoughts on this?

Oh, that's a great point.
I think the ideal solution would be partitioning batches per message group for fifo queues and then sending each batch in parallel.
A simpler solution would be sending batches in parallel for Standard queues and sequentially for FIFO queues.
WDYT?


Enabling struct_field_align_threshold=20 broke struct

With the following config, having just enabled the struct_field_align_threshold = 20 line, and running cargo +nightly fmt, rustfmt removed the terminating commas from some structs like the following, breaking them.
brace_style = "SameLineWhere"
comment_width = 100
edition = "2018"
fn_args_layout = "Compressed"
hard_tabs = false
match_block_trailing_comma = true
max_width = 100
merge_derives = false
newline_style = "Unix"
normalize_doc_attributes = true
overflow_delimited_expr = true
reorder_imports = false
reorder_modules = true
struct_field_align_threshold = 20
tab_spaces = 4
trailing_comma = "Never"
use_small_heuristics = "Max"
use_try_shorthand = true
wrap_comments = true

/// Playback and record buffer metrics.
#[repr(C)]
#[derive(Debug, Default, Copy, Clone, PartialEq, Eq)]
pub struct BufferAttr {
    /* NOTE: This struct must be directly usable by the C API, thus same attributes/layout/etc */
    /// Maximum length of the buffer in bytes.
    ///
    /// Setting this to [`std::u32::MAX`] will initialize this to the maximum value supported by
    /// the server, which is recommended. In strict low-latency playback scenarios you might
    /// want to set this to a lower value, likely together with the
    /// [`stream::FlagSet::ADJUST_LATENCY`] flag. If you do so, you ensure that the latency
    /// doesn’t grow beyond what is acceptable for the use case, at the cost of getting more
    /// underruns if the latency is lower than what the server can reliably handle.
    ///
    /// [`stream::FlagSet::ADJUST_LATENCY`]: crate::stream::FlagSet::ADJUST_LATENCY
    pub maxlength: u32

    /// Target length of the buffer (playback only). The server tries to assure that at least
    /// `tlength` bytes are always available in the per-stream server-side playback buffer. The
    /// server will only send requests for more data as long as the buffer has less than this
    /// number of bytes of data.
    ///
    /// It is recommended to set this to [`std::u32::MAX`], which will initialize this to a value
    /// that is deemed sensible by the server. However, this value will default to something like
    /// 2s; for applications that have specific latency requirements this value should be set to
    /// the maximum latency that the application can deal with.
    ///
    /// When [`stream::FlagSet::ADJUST_LATENCY`] is not set this value will influence only the
    /// per-stream playback buffer size. When [`stream::FlagSet::ADJUST_LATENCY`] is set, the
    /// overall latency of the sink plus the playback buffer size is configured to this value. Set
    /// [`stream::FlagSet::ADJUST_LATENCY`] if you are interested in adjusting the overall latency.
    /// Don’t set it if you are interested in configuring the server-side per-stream playback
    /// buffer size.
    ///
    /// [`stream::FlagSet::ADJUST_LATENCY`]: crate::stream::FlagSet::ADJUST_LATENCY
    pub tlength: u32

    /// Pre-buffering (playback only). The server does not start with playback before at least
    /// `prebuf` bytes are available in the buffer. It is recommended to set this to
    /// [`std::u32::MAX`], which will initialize this to the same value as `tlength`, whatever that
    /// may be.
    ///
    /// Initialize to `0` to enable manual start/stop control of the stream. This means that
    /// playback will not stop on underrun and playback will not start automatically, instead
    /// [`Stream::cork()`] needs to be called explicitly. If you set this value to `0` you should
    /// also set [`stream::FlagSet::START_CORKED`]. Should underrun occur, the read index of the
    /// output buffer overtakes the write index, and hence the fill level of the buffer is
    /// negative.
    ///
    /// Start of playback can be forced using [`Stream::trigger()`] even though the prebuffer size
    /// hasn’t been reached. If a buffer underrun occurs, this prebuffering will be again enabled.
    ///
    /// [`Stream::cork()`]: crate::stream::Stream::cork
    /// [`Stream::trigger()`]: crate::stream::Stream::trigger
    /// [`stream::FlagSet::START_CORKED`]: crate::stream::FlagSet::START_CORKED
    pub prebuf: u32

    /// Minimum request (playback only). The server does not request less than `minreq` bytes from
    /// the client, instead it waits until the buffer is free enough to request more bytes at once.
    ///
    /// It is recommended to set this to [`std::u32::MAX`], which will initialize this to a value
    /// that is deemed sensible by the server. This should be set to a value that gives PulseAudio
    /// enough time to move the data from the per-stream playback buffer into the hardware playback
    /// buffer.
    pub minreq: u32

    /// Fragment size (recording only). The server sends data in blocks of `fragsize` bytes size.
    ///
    /// Large values diminish interactivity with other operations on the connection context but
    /// decrease control overhead. It is recommended to set this to `std::u32::MAX`, which will
    /// initialize this to a value that is deemed sensible by the server. However, this value will
    /// default to something like 2s; For applications that have specific latency requirements this
    /// value should be set to the maximum latency that the application can deal with.
    ///
    /// If [`stream::FlagSet::ADJUST_LATENCY`] is set the overall source latency will be adjusted
    /// according to this value. If it is not set the source latency is left unmodified.
    ///
    /// [`stream::FlagSet::ADJUST_LATENCY`]: crate::stream::FlagSet::ADJUST_LATENCY
    pub fragsize: u32
}

Trying to compile or re-run rustfmt afterwards obviously causes compile errors.

In terms of version, just before posting these issues I'd switched from my distro's rustc to using rustup, so I had the latest stable and latest nightly. I was using the +nightly switch here, so the applicable version would have been the nightly available that day.

Please run rustfmt --version and share the output. It's a lot easier to have the information, including the commit hash, readily available inline so that folks don't have to take several extra steps just to figure out the version associated with the reported issue.

Please run rustfmt --version and share the output. It's a lot easier to have the information, including the commit hash, readily available inline so that folks don't have to take several extra steps just to figure out the version associated with the reported issue.

I understand and I appreciate that it would have been most helpful to have specified which nightly version I was actually using in the original reports. However I've updated several times since then so giving you the current version string is problematic unless I go through every report to confirm that the problems all still occur with with this version. Sigh.
So, starting with this report, the version string is rustfmt 1.4.37-stable (a178d03 2021-07-26) and yes it still occurs against my master branch of the linked project (if you add the quoted config).

However I've updated several times since then so giving you the current version string is problematic unless I go through every report to confirm that the problems all still occur with with this version. Sigh.

No worries! You mentioned running cargo +nightly fmt in the issue description, and IIRC struct_field_align_threshold is still an unstable/nightly only option so I gather your system and/or directory is defaulted to a stable toolchain and you're overriding on every invocation?
If so could you actually share rustfmt +nightly --version or cargo +nightly fmt --version?
The stable version you shared is precisely the type of thing I was looking for, but just want to make sure we've got the same toolchain you're actually using in the project. For future reference, there's no need to vet against every version or anything like that, we just need a version where it can be reproduced to have that marker on the issue.

This seems to be related to #4791, and may be solved by #5159.

@calebcartwright can this be closed? I believe this was fixed by https://github.com/rust-lang/rustfmt/pull/5159.

@calebcartwright can this be closed? I believe this was fixed by #5159.

Indeed. Do you have access to close?

Yeah, I do. I just wanted to double check that it's okay that I go ahead and close it.

closing as this has been resolved by https://github.com/rust-lang/rustfmt/pull/5159.


Add swiftpm service manager extension

hi @amraboelela thank you for the idea and PR. Was this discusses as pitch in the forums yet? For reference, we normally try to socialize ideas with the community to help define the proposal details.

No I didn’t.
How do I do that?

On Aug 17, 2020, at 4:02 PM, tomer doron<EMAIL_ADDRESS>wrote:
hi @amraboelela https://github.com/amraboelela thank you for the idea and PR. Was this discusses as pitch in the forums yet? For reference, we normally try to socialize ideas with the community to help define the proposal details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apple/swift-evolution/pull/1136#issuecomment-675156676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXSCUBOY3MBCF5DIQ7JN3SBGZG3ANCNFSM4LVIRSCQ.

Hi @amraboelela the full process is documents https://github.com/apple/swift-evolution/blob/master/process.md
First, you need to socialize and collect feedback about your idea using a forum thread in https://forums.swift.org/c/evolution/pitches, based on that you formulate the proposal as described in the above link

Hi @amraboelela closing this for now, please re-open if interested following the process described above


How to import/export/stream sequence&midi data across the grpc or socket?

I am attempting to develop a collaboration music app.
WebServer/Browser <--(Bi-direction)--> MobileApp Clients.
I may need streaming method via bi-direction.
Clients apps are not WebBrowser and need some fast seamless connection via grpc or socket.
I am thinking to utilize gRPC because Json with Http1.x is slow and heavy for this; it is not even suitable for streaming.
Seemingly, magenta takes advantage of Protobuf to serialize data, right? but where is the methods about this?
What about "sequenceProtoToMidi"? this is all about json-based data?
I couldn't find functions to import and export protobuf in midi_io.ts.
Could you show me some APIs or examples or even some tips/guides?

I think what you're looking for is in midi_io.ts https://github.com/tensorflow/magenta-js/blob/master/music/src/core/midi_io.ts#L38 You will find there a MIDI to proto's sequencer converter and vice-versa. Your server application could receive MIDI data and convert it on the fly or you could build a proto object yourself. The master proto file is available in the main magenta repo: https://github.com/tensorflow/magenta/blob/master/magenta/protobuf/music.proto and the generated JS code is available here https://github.com/tensorflow/magenta-js/blob/master/music/src/protobuf/proto.js

Looks like this was answered, closing! 🎉


user is not able to scroll when not in "edit mode"

Description
User is not able to scroll/copy text when not in "edit mode"
Note: due to pointer-events: all on NoteAreaBg

🎉 Fixed!


"calling set on destroyed object" because of not cancelled timer

In https://github.com/marzubov/ember-calendar/blob/develop/addon/components/as-calendar/timetable.js#L109 the timer is not being properly cancelled (via Ember.run.cancel)
This causes buggy behavior like I am seeing with Ember throwing an error because it couldn't set a property on a destroyed object: "calling set on destroyed object"

Hi @frank06
Thank You for finding out what caused those errors. I didn't have much time to investigate this.
By the way, PRs are welcomed 👍


[S2GRAPH-43] Bug on offset when Interval is given on query.

add check for columnFilter on queryParam.

+1

+1

1


Adding "withSourcesJar" in a Gradle quarkus-cxf build causes duplicate sources to appear in JAR

Reproducer: https://github.com/jskillin-idt/quarkiverse-quarkus-cxf-issues-859
A project with at least the following lines triggers a build failure, in which the generated source from the WSDL is attempted to be packaged more than once in the source JAR:
plugins {
    // ...
    id 'java'
    id 'io.quarkus' // 3.0.1.Final
}

// ...
dependencies {
    // ...
    implementation 'io.quarkiverse.cxf:quarkus-cxf:2.0.2'
}
// ...
java {
    // ...
    withSourcesJar()
}
// ...

An example failure using the reproducer:
> Task :sourcesJar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sourcesJar'.
> Entry wsdl2java/org/jboss/eap/quickstarts/wscalculator/calculator/Multiply.java is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/8.1.1/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.

This may be a Quarkus bug, in which case I can pass this along.

Reproducer linked.

Hi @jskillin-idt Thanks for the issue and the reproducer!
I'm no Gradle expert, but this appears to me like it is a Gradle issue.
Have you already tried adding the below to your build.gradle file?
tasks.withType(Jar).all { duplicatesStrategy 'exclude' }

If the above is not the ideal / recommended solution, can you provide some details as to why?

It'd be preferable to fix the Quarkus plugin code

This is confusing in context of this repo. Sorry. I've filed a lot of Quarkus plugin issues so this got lumped in together in my head. :laughing: I generally mean it'd be preferable to fix the root cause of duplicate source paths being added, even if it's the exact same path. I agree with the issue that Gradle could adopt a more intelligent (idempotent?) behavior here, even optionally, but currently that's not how it behaves.

@jskillin-idt would you please file a new Quarkus issue for this?

@jskillin-idt would you please file a new Quarkus issue for this?

Done: https://github.com/quarkusio/quarkus/issues/35854


⚠ Bofrost.es has degraded performance

In dd8c648, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1492 ms

Resolved: Bofrost.es performance has improved in 0fdcd8a after 1 hour, 51 minutes.