npm ERR! Unexpected token '.'

Issue:
Can't init npm, I'm getting (npm ERR! Unexpected token '.') when I run command npm init
How To Reproduce:

Open CMD
Type npm init
Press Enter

Logs
2022-10-28T14_38_02_332Z-debug-0.log
2022-10-28T14_38_03_129Z-debug-0.log
I'm using:
NVM: 1.1.9
NPM: 8.19.0
Node.js: v18.12.0

You have a non-standard version of npm. Node 18.12.0 ships with npm 8.19.2, not 8.19.0.

You may just need to uninstall/reinstall node 18.12.0 to assure you have the appropriate version of npm.

Thank you @coreybutler, I will check it Monday, and a comment if it worked. Thank you again.

@coreybutler issue seems to persist even with 8.19.2

@dhroiden - you may want to upgrade nvm to a more recent version. v1.1.10 brought back UAC prompts (i.e. it's more aligned with the v1.1.7 release you're using).

Alternatively, you may need to reinstall node v18.12.0. npm can be finicky about how it is setup/uninstalled, and this is definitely an npm issue that NVM4W merely tries to work around.

@coreybutler I updated everything, but still getting the same issue

@yassine-klilich - did you uninstall/reinstall Node 18.12.0 or run the gist? If you just upgraded NVM4W or npm, it won't have any affect. The root of the problem is in npm. Sometimes npm creates text files instead of symbolic links to directories, causing this error. The previously mentioned gist is supposed to track that down and correct it within npm. Some people find it easier to reinstall Node (to force reinstallation of npm). Others prefer to manually replace npm. Regardless, those faulty symlinks need to be corrected.
Additionally, running npm i is not the same as running npm init. Running npm i alone will fail if there is no package.json file.

@coreybutler - Worked. I uninstalled NVM and installed it again and installed Node again, and it worked fine now.

Hi,
I'm facing the same issue with npm install, I downloaded 3 node versions today and all have the same issue 18.12.0, 18.10.0 and 16.18.0. If I go back to a previously downloaded version I can build and all goes fine. With the newly downloaded versions  npm complains about the unexpected token and can't communicate with nexus/artifactory and fails the builds.
C:\>npm -version
npm WARN config `_auth`, `_authToken`, `username` and `_password` must be scoped to a registry. see `npm help npmrc` for more information.
npm WARN config `_auth`, `_authToken`, `username` and `_password` must be scoped to a registry. see `npm help npmrc` for more information.
8.19.2

I've updated to latest nvm 1.1.10 re-installed versions but same issue.
I've runned the e gist with  node npm_windows_fix.js  but same error.

yes, custom npm registry but the error internal error looked similar. The strange thing is that when I switch to another node version with nvm use it works. When I use the one's downloaded today it fails.
34 verbose stack C:\Users\garalber\AppData\Roaming\nvm\v16.18.0\node_modules\npm\node_modules\libnpmfund:1
34 verbose stack ../workspaces/libnpmfund
34 verbose stack ^
34 verbose stack
34 verbose stack SyntaxError: Unexpected token '.'
34 verbose stack     at Object.compileFunction (node:vm:360:18)
34 verbose stack     at wrapSafe (node:internal/modules/cjs/loader:1084:15)
34 verbose stack     at Module._compile (node:internal/modules/cjs/loader:1119:27)
34 verbose stack     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
34 verbose stack     at Module.load (node:internal/modules/cjs/loader:1033:32)
34 verbose stack     at Function.Module._load (node:internal/modules/cjs/loader:868:12)
34 verbose stack     at Module.require (node:internal/modules/cjs/loader:1057:19)
34 verbose stack     at require (node:internal/modules/cjs/helpers:103:18)
34 verbose stack     at Object.<anonymous> (C:\Users\garalber\AppData\Roaming\nvm\v16.18.0\node_modules\npm\lib\utils\reify-output.js:16:38)
34 verbose stack     at Module._compile (node:internal/modules/cjs/loader:1155:14)
35 verbose cwd C:\D\Projects\LPA\lpa-c-gui
36 verbose Windows_NT 10.0.19042
37 verbose node v16.18.0
38 verbose npm  v8.19.2
39 error Unexpected token '.'
40 verbose exit 1
41 timing npm Completed in 110ms
42 verbose code 1
43 error A complete log of this run can be found in:
43 error     C:\Users\garalber\AppData\Local\npm-cache\_logs\2022-11-02T14_36_43_138Z-debug-0.log

I will try to re-install as suggested.
thank you

@albertgarcias Hope re-installing NVM work for you, because it worked for me. And I tried to run node npm_windows_fix.js but I got some errors too.
@coreybutler thank you so much for your support, I appreciate it my friend.
I will close this issue since I fixed it by re-installing NVM.

Hi, I'm still having this issue.  Using nvm 1.1.10, node 18.12.1, npm 8.19.2.
I tried uninstalling and reinstalling nvm.  I also tried running the gist, all it does is print DONE.


maskDelegate is inaccessible

Hi I try to trigger the .ValueChanged on AKMaskField but as soon as i set maskExpression the event is not trigger anymore. therefore i tried to set the delegate and i have this error
'maskDelegate' is inaccessible due to 'internal' protection level
valueField.maskDelegate = self
valueField.text = value

I use the swift3 branch.
Thanks,
Have a good day.

Have the same issue as the jeremypiednoel.

Same problem here

Hi. Thx for finding this issue. To help me fix this problem I need fully stimulate your situation. Can you help me with this and past code which leads to an error?

@artemkrachulov Hello! I'll answer for jeremypiednoel:

Thanks @ursanotsomajor , indeed i removed the code from my project. so i wasn't able to show you.

I have the same issue after migrating to Swift 3
The same is for maskStatus.
cleanText is absent at all((

Fixed


Update lowlevel.rst

@johanvdw lowlevel.rst isn't rendering correctly. Can this be fixed by the proposed change?

Klopt, heb het net getest


Head assembly not functioning

Describe the bug
Pan/Tilt of head cameradoesn’t work. Throws errors like baud rate -1 is detected but the requested baud rate is 11200 (depends on current baud rate) something. We were not able to debug issue by changing the baud rate.
Pings are not functioning. Several comms errors
Expected behavior
No communication errors in head camera
Additional context
Add any other context about the problem here.

Pan/Tilt doesn’t work. Throws errors like baud rate -1 is detected but requested baud rate is 11200 (depends on current baud rate) something. We were not able to debug issue by changing the baud rate.


[docs] Add a sequence diagram with api calls, and recommended app patterns

See https://5f195e48a7719101a58a7dea--nitro-protocol.netlify.app/docs/next/app-devs/make-api-calls and https://5f195e48a7719101a58a7dea--nitro-protocol.netlify.app/docs/next/app-devs/recommended-patterns


HTTP Header Proxy-Authenticate can be conditionally forwarded.

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
When using the forwardAuth middleware and a request using the Proxy-Authenticate header, I expect the header to be forwarded to the authentication server.
Justification
Let me start by saying I am aware that Proxy-Authenticate is a hop by hop header and should normally be stripped according to RFC 2616. However, RFC 7235 extends on authentication headers. In section 4.4 it states:
   Unlike Authorization, the Proxy-Authorization header field applies
   only to the next inbound proxy that demanded authentication using the
   Proxy-Authenticate field.  When multiple proxies are used in a chain,
   the Proxy-Authorization header field is consumed by the first inbound
   proxy that was expecting to receive credentials.  A proxy MAY relay
   the credentials from the client request to the next proxy if that is
   the mechanism by which the proxies cooperatively authenticate a given
   request.

Since the forward auth middleware is delegating authentication for the proxy, the Proxy-Authenticate header can be sent along freeing up the Authorization header for applications behind the proxy that also want authentication. This would be Traefik's way of consuming the header. By optionally allowing the header to be passed, it would also allow for proxy chaining with proxy authentication and would also not not hog the application Authorization header.

I'm bumping into the same problem when using Traefik forwardAuth with Authelia.
That header is stripped by calling utils.RemoveHeaders(forwardReq.Header, forward.HopHeaders...).
var HopHeaders = []string{
	Connection,
	KeepAlive,
	ProxyAuthenticate,
	ProxyAuthorization,
	Te, // canonicalized version of "TE"
	Trailers,
	TransferEncoding,
	Upgrade,
}

Since the forward Auth is not considered a next hop but is actually part of the auth process of the current hop, the Proxy-Authorization header should not be removed.
https://github.com/traefik/traefik/blob/7928e6d0cd4c7751a14bea5f74124f8a3cb829c0/pkg/middlewares/auth/forward.go#L163

@nkonev I saw your commit for authRequestHeaders.
Could you do the removal of HopHeaders in filterForwardRequestHeaders so it allows to keep Proxy-Authentication if listed in authRequestHeaders ?
func filterForwardRequestHeaders(forwardRequestHeaders http.Header, allowedHeaders []string) http.Header {
	if len(allowedHeaders) == 0 {
		return utils.RemoveHeaders(forwardRequestHeaders, forward.HopHeaders...)
	}

A better approach would also be to not consider Proxy-Authentication as a Hop Header for the Authentication since it is actually supposed to perform that authentication.
func keepProxyAuthHeader(hopHeaders []string) []string {
	var headers []string
	for _, h := range hopHeaders {
		if h != forward.ProxyAuthorization {
			headers = append(headers, h)
		}
	}
	return headers
}

func writeHeader(req, forwardReq *http.Request, trustForwardHeader bool, allowedHeaders []string) {
	utils.CopyHeaders(forwardReq.Header, req.Header)
       // utils.RemoveHeaders(forwardReq.Header, forward.HopHeaders...)
	forwardReq.Header = filterForwardRequestHeaders(forwardReq.Header, allowedHeaders)

func filterForwardRequestHeaders(forwardRequestHeaders http.Header, allowedHeaders []string) http.Header {
	if len(allowedHeaders) == 0 {
		return utils.RemoveHeaders(forwardReq.Header, keepProxyAuthHeader(forward.HopHeaders)...)
	}

@Scapal (Unfortunately) I am not a part of traefik team, I just solved my problem with an excess Content-Type header.
I think you should make a PR with change of hop headers.

Closed by #7433.

Closed by #7433.


Multi-line regular expressions are not correctly parsed

Reported in https://github.com/weavejester/cljfmt/issues/76.
user=> (read-string "#\"a\nb\"")
#"a
b"
user=> (require '[rewrite-clj.parser :as p])
nil
user=> (p/parse-string "#\"a\nb\"")
<token: #"a">

So I took a quick look at this issue, looks like parse-regex in rewrite_clj/parser/string.clj is failing to correctly hand read-string-data returning a seq. We're destructuring the head into h and doing nothing with the tail which is where the rest of the result lives.
Solutions:
Join the result of read-string-data with newlines. Unfortunately this won't give us a :multi-line token then.
Or we could create a pattern string node that can accept multiple lines, just like string-node in string.clj.

IMO joining with newlines is the only sane thing to do.

OK, I have some code lying around. I'll clean it up and PR it.

Thanks!

PR: xsc/rewrite-clj/pull/51.

Thanks for the quick fix!


feature: Extend the default opts when calling Snacks.scratch()

Did you check the docs?

[X] I have read all the snacks.nvim docs

Is your feature request related to a problem? Please describe.
When toggling the scratch window I'd like to use the current filetype. To this end I'm doing:
{ "<leader>.", function() require("snacks").scratch({ ft = vim.bo.filetype }) end, desc = "Toggle Scratch Buffer" }
This doesn't work, more context below.
Describe the solution you'd like
It seems to me that the passed opts are not merged with the default ones. Can that be considered?
Describe alternatives you've considered
Change snacks.nvim to always default to the current buffer type.
Additional context
When I'm currently using this keymap, I'm getting an error:
E5108: Error executing lua: ...local/share/nvim/lazy/snacks.nvim/lua/snacks/scratch.lua:180: Invalid 'text': Expected Lua string
stack traceback:
        [C]: in function 'nvim_strwidth'
        ...local/share/nvim/lazy/snacks.nvim/lua/snacks/scratch.lua:180: in function 'open'
        /Users/jedrzej/.config/nvim/lua/plugins.lua:1684: in function </Users/jedrzej/.config/nvim/lua/plugins.lua:1684>

What are you using for icons?
Either way, try again, should work now, but you won't get a python icon I guess

I've just pushed some changes with better support for nvim-web-devicons.
So you should also see the python icon now.

Oh, I see now what's happening, my bad.
The filename is ~/.local/share/nvim/scratch/1_%7C_%7CScratch_%7C_%2FUsers_%2Fjedrzej_%2FProjects_%2Frobonetv3_%7Cmain.python
Notice the file extension. Looks like a mapping would be needed from the filetype to the extension. I'm not sure if that is something I need to take care about to pass as the ft argument to the Snacks.scratch(...) call or if that's something what can happen internally in Snacks.

that should actually work as is, although not ideal :)
But a file with extension markdown or python gets the proper filetype.
update snacks and try again. should properly show as python

That's great, thank you for committing your time for this! The icon works fine now both in lua and python.
If I'm using my snippet from above I am not getting LSP or treesitter in the python scratch window, because the file extension is wrong (.python instead of .py), but the scratch window is still extremely helpful! I appreciate your help.

Should also attach treesitter and LSP now :)

That's amazing! It's all I could have asked for. I appreciate your time, Folke!


32bit apps don't work while jailbroken

All 32bit apps immediately crash wile jailbroken. They do open while in safe mode though. Seems to be due to Tweak loader. I've copied a crash report from CrashReporter.
https://ghostbin.com/paste/wtyec

That should mean you have a tweak that doesn't work right on 32bit.  Anemone doesn't and was explicitly blacklisted until updated as a result but he can't go through and blacklist every bad tweak.  Remove your tweaks then reinstall them until it starts happening again and you'll know where your problem is.


Add Support for Fluvio Admin API

Add the ability to run the Fluvio admin commands.
Map rust crate admin methods https://docs.rs/fluvio/latest/fluvio/struct.FluvioAdmin.html

connect
connect_with_config

Since the create, delete, list methods are generic over various object types, they should work for combinations available to the fluvio cli:

topics (TopicSpec)

create
delete
list
list_with_params
watch

smartmodules (SmartModuleSpec)

create
delete
list
watch

partitions

list

Merged into #367


Make `C-u C-c C-j' show a Go definition in another window

I think this is a simple and very useful usability enhancement - WDYT?

We already have C-x 4 C-c C-j mapped to godef-jump-other-window, C-x 4 being the idiomatic binding for "other window". I don't think we should use C-u for this. We may want to use it for some other toggle in the future, and there's already a canonical binding for this.

Fair enough.  I thought I looked for a binding for godef-jump-other-window (with C-h w) and didn't find one, before trying this code change - but I do see that C-x 4 binding now.


Block manual payments from creating recurring contributions

Related to https://github.com/opencollective/opencollective/issues/6941

@Betree, thanks for flagging that up. I'll that as well.


Consider putting Javalin on the Context

I'm wondering if it would be good to put a reference to the current Javalin instance on the Context. This would allow you to ctx.javalin() in your controllers.
This would allow for per-instance configuration of JavalinJson, JavalinRenderer, JavalinValidation etc, and it would make it possible to register app-global dependencies that would be available in every controller:
Javalin app = Javalin.create()
    .register(ConnectionPool.class, new ConnectionPool());
    .get("/", controller)
    .start(7070);

void controller(Context ctx) {
    ctx.javalin().use(ConnectionPool.class).getConnection()
}

I'm very interested in potential downsides.
Edit: Pull request for discussion: https://github.com/tipsy/javalin/pull/364

Hmm I have been mulling this over the last few days.  All I have is it doesn't "feel" right to do this.  I'm not super familiar with the internals, but it looks like it cause a circular dependency which would prevent java from cleaning up the objects properly.   However I am not sure that even matters since the Javalin object will probably never need to be cleanup in the service lifecycle.
For what its worth, I probably will not use this register feature.  I kinda like the pattern of creating global objects in the main() function and then passing them in to each Handler constructor as needed.  I have a class per handler.  I just like to explicitly see what each handler depends on, instead of having a global registry of objects.  I feel it keeps me from making my classes too complex.
        ConnectionPool pool = new ConnectionPool();
        MyOtherObject obj = new MyOtherObject();
        Javalin app = Javalin.create().port(7070).start();
        app.get("/", new PathHandler(pool));
        app.get("/another", new AnotherPathHandler(pool, obj));

@SmithKevin Hmm I have been mulling this over the last few days. All I have is it doesn't "feel" right to do this. I'm not super familiar with the internals, but it looks like it cause a circular dependency which would prevent java from cleaning up the objects properly. However I am not sure that even matters since the Javalin object will probably never need to be cleanup in the service lifecycle.

Thanks for your feedback. This is the type of thing I'm worried about. I don't think it's a problem, but I'm not an expert on JVM internals, so I want to be very careful.

For what its worth, I probably will not use this register feature. I kinda like the pattern of creating global objects in the main() function and then passing them in to each Handler constructor as needed. I have a class per handler. I just like to explicitly see what each handler depends on, instead of having a global registry of objects. I feel it keeps me from making my classes too complex.

I feel the same way, but I understand @GerrySeidman's point of view too. I'm mostly intrigued by the possibility of configuring Jackson/JavalinRenderer/etc per instance.
I'm also thinking about #274, and the possibility of building paths to controllers:
app.buildPath(Route.PHOTOS)?
  .param(":user-id", "Steve")
  .queryParam("from-date", "2018-03-01")
  .queryParam("to-date", "2018-03-18")

It would be nice if this was available inside handlers.

Regarding your comment above wrt register/use.  I'm not familiar with that functionality, but it doesn't seem to be addressing the associating of data on the application level.}
I'm looking at Javalin as something that easily adds HTTP/WebSocket microservices to an existing application. Global variables are a big no-no in our shop and we tightly scope access via context objects.
As an example, we have multiple connection pools running in this application, some of which should not be accessible by every subsystem (both literally and for security reasons).  We would prefer scoping it to a root http endpoint (aka a single instance of a Javalin app object) than either making a global variable or (what imho is) a hacky way by attaching it independently to every session object in a before().
To be clear, we have everything working with the .before() option and are not stuck.
I originally made this suggestion since it seems like a natural extension to methods to the context:
attribute()
sessionAttribute()
applicationAttribute()  << what I was proposing ( probably both on the ctx and app objects)
Rather than having to do ctx.request().getServletContext().getAttribute() [ which I can't really leverage anyway since I can't seed the servlet context with my attributes anyway in your current api ]
Since logically (if not literally) the Javalin app object IS the servlet context.

@GerrySeidman this issue is about adding register()/use() to the Javalin instance and making the Javalin instance available through the Context. It should work like applicationAttribute(), but type safe.
Instead of using a String key:
app.applicationAttribute("connectionPool", new ConnectionPool())
((ConnectionPool) app.applicationAttribute("connectionPool")).getConnection()

You'd use a Class key:
app.register(ConnectionPool.class, new ConnectionPool());
app.use(ConnectionPool.class).getConnection()

So the syntax is different, but the scope should be what you wanted (?).

@tipsy To be clear, I am using the .before() approach which works.  I was just sharing architectural thoughts/opinions.
As for register/use, that would work, but I'm curious what your reasoning was to key it on a Class object rather than a String or Object?     Presumably it is so you don't have to cast the return value.

Cool.  When I first read it I was worried that you were using it for object creation.
This is fine since it would allow the dangling of an application specific context object (MyContext.class).
The use/register as is seems to be just a convenience alternative to attribute(), which is great for things dangling off a ctx, but the life cycle of a ctx is only a single HTTP request.  Unlike attribute, there is no session level method of achieving this.  Session attributes are much more important than request attributes.
But that gets us back to the original scoping issue (ie that IMO there should be distinct request, session and application for context data whether via attribute() or register/use()

@GerrySeidman To be 100% clear, I am just sharing architectural opinions. I am able to achive what I need with sessionAttributes and before().

Noted!

But that gets us back to the original scoping issue (ie that IMO there should be distinct request, session and application for context data whether via attribute() or register/use()

We have ctx.attribute() and ctx.sessionAttribute(), this issue is about introducing the missing application-level scope, app.attribute(). Instead of app.attribute() I want to use app.register() and app.use(), but really it's the same thing.
I'm looking for input on if it's good to add a reference to Javalin on the Context, probably via ctx.app. It could be limited to ctx.appAttribute(), but just giving access to the whole Javalin instance seems like it could be useful.

@GerrySeidman To be 100% clear, I am just sharing architectural opinions. I am able to achive what I need with sessionAttributes and before().

Noted!

But that gets us back to the original scoping issue (ie that IMO there should be distinct request, session and application for context data whether via attribute() or register/use()

We have ctx.attribute() and ctx.sessionAttribute(), this issue is about introducing the missing application-level scope, app.attribute(). Instead of app.attribute() I want to call it app.register() and app.use(), but really it's the same thing.
I'm looking for input on if it's a good idea to add a reference to Javalin on the Context, probably via ctx.app. It could be limited to ctx.appAttribute(), but just giving access to the whole Javalin instance seems like it could be useful.

I think app.register/use is fine BUT you would also then need a way to get a reference to the app from the ctx (or you would have to make app global static ... sigh) or  ctx.app().use(Foo.class).
I would vote for ctx.appUse(Foo.class) rather than exposing the app object to everyone since that would allow an evil consultant to do bad things like subverting security or something like that)

If it were a string key, then clearly appAttribute() would fit the existing pattern.
xxxProperty() naming also tends to be for Strings
appExtension is (IMHO) just confusing because it isn't an extension
What was the geneology of the register/use() naming?
My vote then is to just punt and just call it appData().

What was the geneology of the register/use() naming?

User polling.

My vote then is to just punt and just call it appData().

I'll keep the thread open for a while and keep growing the list.

ctx.appAttribute(ConnectionPool.class).getConnection()
ctx.appExtension(ConnectionPool.class).getConnection()
ctx.appProperty(ConnectionPool.class).getConnection()
ctx.appData(ConnectionPool.class).getConnection()
ctx.appPlugin(ConnectionPool.class).getConnection()
ctx.appDependency(ConnectionPool.class).getConnection()


mesa: update to 24.3.1, wayland-protocol updated to 1.38

Based on PR #1390
Update to latest mesa 24.3.1 release
Fixes DRAM DSI linking to missing library drm-rp1-dsi_dri.so
fixes https://github.com/agherzan/meta-raspberrypi/issues/1389
Added new dependencies required by msea version update.
Removed DRI3 option as it's now removed from meson build options.
Updated Wayland Protocol to 1.38 as it's minimum required version for mesa 24.3.1
This PR will be completed when 24.3.1 is final official release. For now, I'm leaving it as work of progress to help whoever have issues with RPI5 DSI.

@leon-anavi I'm still testing the build against meta-raspberrypi scarthgap latest.


problems on ubuntu 14.04

Hi ponchoblesa,
thanks for GoPro-Studio-for-linux!
Unfortunately the script gopro_import.sh does not work on ubuntu 14.04.
Running the script nothing happens. Only the folder GoPro is created, but it is empty.
Adding '-x' to the first line I read some output on the terminal. The script stopped on this point:

local folder_match=/media/gp/102GOPRO/G0237343.JPG
'[' -d //media/gp/102GOPRO/G0237343.JPG ']'
first_level=("${FOLDERS_LIST_RETURN[@]}")

Thanks in advance!
Ruggero

Hi Ruggero,
Thanks for reporting, this is the first feedback that I have of these scripts. Apparently for what you are telling me, I guess that your camera folder is wrong set.
For your particular case, I guess that your camera folder is "/media/gp"
   #!/bin/bash

   CAMERA_DIR="/media/gp"
   ...

The "CAMERA_DIR" variable should point to the root folder of the memory card. Make this check for me and tell me if works. Otherwise, tell me please your variables setup and if you are running the script with the memory card in a stick or card reader, or if you are running it trying to access to the plugged GoPro.
Thank you!
Poncho

Hi Ruggero,
Any new on this? Can I close the issue?
Cheers
Poncho

Hi Poncho,
On my notebook with ubuntu 14.04 I have these problems, but on
my workstation (also with ubuntu 14.04) all works fine!
So the problem is on my notebook configuration, sorry.
I need more "free time" to investigate.
You can close the issue.
Cheers
Ruggero
On 31 January 2016 at 18:49, ponchoblesa<EMAIL_ADDRESS>wrote:

Hi Ruggero,
Any new on this? Can I close the issue?
Cheers
Poncho
—
Reply to this email directly or view it on GitHub
https://github.com/ponchoblesa/GoPro-Studio-for-linux/issues/1#issuecomment-177563631
.

--
/****************************************
/\          Ruggero Valentinotti
//\  /
///\//\    Frazione Tozzaga
////\\/\\   Via alle Pozze, 6
/////\\\\\  38022 CALDES (TN)
||////\\\ ITALY
||||___
****************************************/
Io stimo più il trovar un vero, benché di cosa leggiera,
che 'l disputar lungamente delle massime questioni senza conseguir verità
nissuna
Galileo Galilei, 1609

Thank you Ruggero. Good luck with it ;-)


LEGO: Pull request from JUNO/hb_a12a4630-4852-4e7d-9cbc-c0e1117da1ab_20231208124320452 to main

LEGO: Pull request from JUNO/hb_a12a4630-4852-4e7d-9cbc-c0e1117da1ab_20231208124320452 to main with localized lcls

closing as this is superseded by merged PR https://github.com/microsoft/responsible-ai-toolbox/pull/2457


Support for npm dependencies + improved output

Uses the config proposed in #26, with an npm and bower key under each scenario, then the dependencies and devDependencies (and resolutions, for bower) under that. The old configuration format is still supported, but only for bower dependencies.
Supports npm dependencies, at least some way: Backs up node_modules and package.json before any commands are run, modifies package.json based on the scenario, runs npm install and npm prune, runs the command,  and to cleanup, restores the package.json and node_modules folder and runs npm install and npm prune.
Unifies the code path for ember try and ember try:testall
New output for the results of running a scenario that shows the dependencies that were changed, what was specified in the config and the actual version that was used.

Many more tests
Upgrade ember-cli

Limitation: Currently packages can be removed between scenarios (thanks to npm prune) but packages in package.json cannot be removed. This needs further thought and perhaps our own configuration syntax. This is the same as the current support for bower.
Further things to do:

Need checks against trying to vary ember-try between scenarios.
Use semver comparison to determine status of dependencies in output table (right now strict comparison)
Maybe warn if trying to vary ember-cli between scenarios.
Find out if this works on Windows.

Important Note: When specifying packages for npm in scenarios, remember to put them in the same "bucket" as in package.json -- devDependencies go under devDependencies, and so forth.

This looks awesome! Having npm support for ember-try rocks!
This will greatly help in https://github.com/switchfly/ember-test-helpers, where the ember-data-2.3 scenario needs to include ember-data as an addon via npm.
I created switchfly/ember-test-helpers#145 to use the latest ember-try code of this PR, but it seems that there is a problem when beta and canary versions for ember are resolved https://travis-ci.org/switchfly/ember-test-helpers/builds/105231965#L2376-L2379:
bower resolved      git://github.com/components/ember.git#b27df6ad05
bower resolution    Unsuitable resolution declared for ember: components/ember#release
bower ECONFLICT     Unable to find suitable version for ember
Error!
1
undefined

I just wanted to let you know of this and give you feedback on this. I don't know how finished this PR is, so please ignore if the current state shouldn't be tried out yet...
Anyway, thanks again for this!

@pangratz Thanks for trying it out. Looks like I messed something up where the resolutions for bower are no longer set to what they are in the config, so that's a good catch. I'll try to update this tonight.

Awesome, thank you kindly!

@pangratz Should be all set. Note that to use npm deps, you need to use the new config syntax, see the upgraded README

Thanks for the heads up. I have good news: switchfly/ember-test-helpers#145 is all green now! Everything works as expected.
:tada: :balloon: :+1:

Great!

:heart:


CPU utilization 95+%

Note: Please take advantage of RealSense Community and Support sites.
When i read a aligned stream like this:
uchar* pCad = (uchar*)dev.get_frame_data(rs::stream::color_aligned_to_depth);

the CPU utilization 95+%.

Required Info

Camera Model
R200

Firmware Version
<IP_ADDRESS>

Operating System & Version
Windows10

Kernel Version (Linux Only)

Hello @JokerShao,
Please provide more system details. Which processor model do you have? Do you get this high utilization with the librealsense samples? What else is running when this happens?
Regards,
Jesus
Intel Customer Support

Thanks for your reply,
I have Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz  3.40GHz.
The same problem also appear when i run the librealsense samples.
Seems like I found the reason.
In image.cpp line 522
#pragma omp parallel for schedule(dynamic)
When I comment out this code, the utilization drop to 25+%.
But the speed running these code seems not slow down.
Whether comment or not, the time run these code is equal, about 15ms.
WHY?
#pragma omp parallel for schedule(dynamic)
        for(int depth_y = 0; depth_y < depth_intrin.height; ++depth_y)
        {
            int depth_pixel_index = depth_y * depth_intrin.width;
            for(int depth_x = 0; depth_x < depth_intrin.width; ++depth_x, ++depth_pixel_index)
            {
                // Skip over depth pixels with the value of zero, we have no depth data so we will not write anything into our aligned images
                if(float depth = get_depth(depth_pixel_index))
                {
                    // Map the top-left corner of the depth pixel onto the other image
                    float depth_pixel[2] = {depth_x-0.5f, depth_y-0.5f}, depth_point[3], other_point[3], other_pixel[2];
                    rs_deproject_pixel_to_point(depth_point, &depth_intrin, depth_pixel, depth);
                    rs_transform_point_to_point(other_point, &depth_to_other, depth_point);
                    rs_project_point_to_pixel(other_pixel, &other_intrin, other_point);
                    const int other_x0 = static_cast<int>(other_pixel[0] + 0.5f);
                    const int other_y0 = static_cast<int>(other_pixel[1] + 0.5f);

                    // Map the bottom-right corner of the depth pixel onto the other image
                    depth_pixel[0] = depth_x+0.5f; depth_pixel[1] = depth_y+0.5f;
                    rs_deproject_pixel_to_point(depth_point, &depth_intrin, depth_pixel, depth);
                    rs_transform_point_to_point(other_point, &depth_to_other, depth_point);
                    rs_project_point_to_pixel(other_pixel, &other_intrin, other_point);
                    const int other_x1 = static_cast<int>(other_pixel[0] + 0.5f);
                    const int other_y1 = static_cast<int>(other_pixel[1] + 0.5f);

                    if(other_x0 < 0 || other_y0 < 0 || other_x1 >= other_intrin.width || other_y1 >= other_intrin.height) continue;

                    // Transfer between the depth pixels and the pixels inside the rectangle on the other image
                    for(int y=other_y0; y<=other_y1; ++y) for(int x=other_x0; x<=other_x1; ++x) transfer_pixel(depth_pixel_index, y * other_intrin.width + x);
                }
            }

Thanks a lot,
Best wishes for you.

Hello @JokerShao,
I found this page which describes what that #pragma line does. https://software.intel.com/en-us/articles/openmp-loop-scheduling
dynamic | Use the internal work queue to give a chunk-sized block of loop iterations to each thread. When a thread is finished, it retrieves the next block of loop iterations from the top of the work queue. By default, the chunk size is 1. Be careful when using this scheduling type because of the extra overhead involved.
It seems that there is extra overhead when (dynamic) is used.
Because of the large amounts of data required to the depth processing, RealSense applications tend to have a high CPU utilization. Even I see that on my 5th Gen Intel Core i5 system. The R200 cameras have data coming from two depth sensors and one RGB sensor. That is much more than what you get from a regular RGB camera.
Regards,
Jesus G.
Intel Customer Support

Using #pragma omp parallel for schedule(dynamic) can have very significant (negative) performance impact. In another application (here: https://github.com/ros-planning/moveit_ros/issues/563) it caused a 320% CPU load, compared to ~20% when not used.

Related to #744
Please note that you can choose to disable OpenMP using CMake build configuration.
@skohlbr, thanks for your comment. What mode of optimization would you recommend?


Remove duplicated points at ViaPoints and add getLength to Instructions

This PR fixes #1216 and also addresses parts of #1138.
This PR removes the duplicated point at ViaInstructions. Due to that we could also improve the Instructions and added the getLength method to the Instruction, which makes the code easier to read and is a step towards making instructions more similar to PathDetails.

Even better thanks!

Would you mind trying to squash these 3 commits :) ?

Squashed this PR :)

Hope it was easy :)

I am still not a fan of local squashing :). I often have uncommitted changes in my project, but you cannot squash if there are uncommitted changes, so you have to revert them or stash them.


Put ngStorage on NPM for those of us who use browserify for client-side package management

To do this, I had to make a few tweaks to the package.json file. Right now, ng-storage is on NPM under my name but I would be happy to transfer ownership to someone else upon request.
Cheers!
~Max

I believe this has been fixed.
(Just doing some clean up of PR/Issue).


Calico is blocked at Init:0/3

Expected Behavior
All Calicos are running
Current Behavior
Calico is blocked at Init:0/3
[root@master1 ~]# kubectl get pods -A -o wide
NAMESPACE     NAME                                       READY   STATUS        RESTARTS   AGE     IP              NODE      NOMINATED NODE   READINESS GATES
kube-system   calico-kube-controllers-8584f6f7f4-bpdrh   0/1     Terminating   0          30m     <IP_ADDRESS>   node1     <none>           <none>
kube-system   calico-kube-controllers-c9784d67d-9xmnj    1/1     Running       0          2m53s   <IP_ADDRESS>   master1   <none>           <none>
kube-system   calico-node-77jmv                          1/1     Running       0          2m53s   <IP_ADDRESS>   master1   <none>           <none>
kube-system   calico-node-b5rgt                          1/1     Running       0          2m53s   <IP_ADDRESS>   master2   <none>           <none>
kube-system   calico-node-hr5zr                          1/1     Running       0          2m53s   <IP_ADDRESS>   master3   <none>           <none>
kube-system   calico-node-mxmp8                          0/1     Init:0/3      0          2m53s   <IP_ADDRESS>   node1     <none>           <none>

Possible Solution
wget https://docs.projectcalico.org/manifests/calico.yaml

name: CALICO_IPV4POOL_CIDR
value: "<IP_ADDRESS>/16"
name: IP_AUTODETECTION_METHOD
value: "interface=eth.*"

kubectl apply -f calico.yaml

Context
[root@master1 ~]# kubectl -n kube-system  logs calico-node-mxmp8
Error from server (BadRequest): container "calico-node" in pod "calico-node-mxmp8" is waiting to start: PodInitializing

[root@master1 ~]# kubectl -n kube-system  describe pod calico-node-mxmp8
Name:                 calico-node-mxmp8
Namespace:            kube-system
Priority:<PHONE_NUMBER>
Priority Class Name:  system-node-critical
Node:                 node1/<IP_ADDRESS>
Start Time:           Mon, 28 Sep 2020 11:08:19 +0800
Labels:               controller-revision-hash=6bd5466b59
                      k8s-app=calico-node
                      pod-template-generation=1
Annotations:          <none>
Status:               Pending
IP:                   <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  DaemonSet/calico-node
Init Containers:
  upgrade-ipam:
    Container ID:  docker://7fed2596d75e92a4923ceda39eb3be7b7ee2b57631e453356252fb07285ccb15
    Image:         calico/cni:v3.16.1
    Image ID:      docker-pullable://calico/cni@sha256:3bae6028807375b22bf3b75f9db0e5d80b678a217f85bd1ea965889cee6e70aa
    Port:          <none>
    Host Port:     <none>
    Command:
      /opt/cni/bin/calico-ipam
      -upgrade
    State:          Running
      Started:      Mon, 28 Sep 2020 11:08:20 +0800
    Ready:          False
    Restart Count:  0
    Environment Variables from:
      kubernetes-services-endpoint  ConfigMap  Optional: true
    Environment:
      KUBERNETES_NODE_NAME:        (v1:spec.nodeName)
      CALICO_NETWORKING_BACKEND:  <set to the key 'calico_backend' of config map 'calico-config'>  Optional: false
    Mounts:
      /host/opt/cni/bin from cni-bin-dir (rw)
      /var/lib/cni/networks from host-local-net-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from calico-node-token-df9gh (ro)
  install-cni:
    Container ID:
    Image:         calico/cni:v3.16.1
    Image ID:
    Port:          <none>
    Host Port:     <none>
    Command:
      /opt/cni/bin/install
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Environment Variables from:
      kubernetes-services-endpoint  ConfigMap  Optional: true
    Environment:
      CNI_CONF_NAME:         10-calico.conflist
      CNI_NETWORK_CONFIG:    <set to the key 'cni_network_config' of config map 'calico-config'>  Optional: false
      KUBERNETES_NODE_NAME:   (v1:spec.nodeName)
      CNI_MTU:               <set to the key 'veth_mtu' of config map 'calico-config'>  Optional: false
      SLEEP:                 false
    Mounts:
      /host/etc/cni/net.d from cni-net-dir (rw)
      /host/opt/cni/bin from cni-bin-dir (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from calico-node-token-df9gh (ro)
  flexvol-driver:
    Container ID:
    Image:          calico/pod2daemon-flexvol:v3.16.1
    Image ID:
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /host/driver from flexvol-driver-host (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from calico-node-token-df9gh (ro)
Containers:
  calico-node:
    Container ID:
    Image:          calico/node:v3.16.1
    Image ID:
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       PodInitializing
    Ready:          False
    Restart Count:  0
    Requests:
      cpu:      250m
    Liveness:   exec [/bin/calico-node -felix-live -bird-live] delay=10s timeout=1s period=10s #success=1 #failure=6
    Readiness:  exec [/bin/calico-node -felix-ready -bird-ready] delay=0s timeout=1s period=10s #success=1 #failure=3
    Environment Variables from:
      kubernetes-services-endpoint  ConfigMap  Optional: true
    Environment:
      DATASTORE_TYPE:                     kubernetes
      WAIT_FOR_DATASTORE:                 true
      NODENAME:                            (v1:spec.nodeName)
      CALICO_NETWORKING_BACKEND:          <set to the key 'calico_backend' of config map 'calico-config'>  Optional: false
      CLUSTER_TYPE:                       k8s,bgp
      IP:                                 autodetect
      CALICO_IPV4POOL_IPIP:               Always
      CALICO_IPV4POOL_VXLAN:              Never
      FELIX_IPINIPMTU:                    <set to the key 'veth_mtu' of config map 'calico-config'>  Optional: false
      FELIX_VXLANMTU:                     <set to the key 'veth_mtu' of config map 'calico-config'>  Optional: false
      FELIX_WIREGUARDMTU:                 <set to the key 'veth_mtu' of config map 'calico-config'>  Optional: false
      CALICO_IPV4POOL_CIDR:               <IP_ADDRESS>/16
      IP_AUTODETECTION_METHOD:            interface=eth.*
      CALICO_DISABLE_FILE_LOGGING:        true
      FELIX_DEFAULTENDPOINTTOHOSTACTION:  ACCEPT
      FELIX_IPV6SUPPORT:                  false
      FELIX_LOGSEVERITYSCREEN:            info
      FELIX_HEALTHENABLED:                true
    Mounts:
      /lib/modules from lib-modules (ro)
      /run/xtables.lock from xtables-lock (rw)
      /sys/fs/ from sysfs (rw)
      /var/lib/calico from var-lib-calico (rw)
      /var/run/calico from var-run-calico (rw)
      /var/run/nodeagent from policysync (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from calico-node-token-df9gh (ro)
Conditions:
  Type              Status
  Initialized       False
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  lib-modules:
    Type:          HostPath (bare host directory volume)
    Path:          /lib/modules
    HostPathType:
  var-run-calico:
    Type:          HostPath (bare host directory volume)
    Path:          /var/run/calico
    HostPathType:
  var-lib-calico:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/calico
    HostPathType:
  xtables-lock:
    Type:          HostPath (bare host directory volume)
    Path:          /run/xtables.lock
    HostPathType:  FileOrCreate
  sysfs:
    Type:          HostPath (bare host directory volume)
    Path:          /sys/fs/
    HostPathType:  DirectoryOrCreate
  cni-bin-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /opt/cni/bin
    HostPathType:
  cni-net-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /etc/cni/net.d
    HostPathType:
  host-local-net-dir:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/cni/networks
    HostPathType:
  policysync:
    Type:          HostPath (bare host directory volume)
    Path:          /var/run/nodeagent
    HostPathType:  DirectoryOrCreate
  flexvol-driver-host:
    Type:          HostPath (bare host directory volume)
    Path:          /usr/libexec/kubernetes/kubelet-plugins/volume/exec/nodeagent~uds
    HostPathType:  DirectoryOrCreate
  calico-node-token-df9gh:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  calico-node-token-df9gh
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  kubernetes.io/os=linux
Tolerations:     :NoScheduleop=Exists
                 :NoExecuteop=Exists
                 CriticalAddonsOnly op=Exists
                 node.kubernetes.io/disk-pressure:NoSchedule op=Exists
                 node.kubernetes.io/memory-pressure:NoSchedule op=Exists
                 node.kubernetes.io/network-unavailable:NoSchedule op=Exists
                 node.kubernetes.io/not-ready:NoExecute op=Exists
                 node.kubernetes.io/pid-pressure:NoSchedule op=Exists
                 node.kubernetes.io/unreachable:NoExecute op=Exists
                 node.kubernetes.io/unschedulable:NoSchedule op=Exists
Events:
  Type    Reason     Age    From            Message
  ----    ------     ----   ----            -------
  Normal  Scheduled  4m38s                  Successfully assigned kube-system/calico-node-mxmp8 to node1
  Normal  Pulled     4m37s  kubelet, node1  Container image "calico/cni:v3.16.1" already present on machine
  Normal  Created    4m37s  kubelet, node1  Created container upgrade-ipam
  Normal  Started    4m37s  kubelet, node1  Started container upgrade-ipam

Your Environment
Calico version 3.16.1
k8s version 1.19.1
CentOS Linux release 7.8.2003 (AltArch)

@ShaPoHun -- looking at the describe output, it appears init-container upgrade-ipam  was started. Can you please share the logs from init-container upgrade-ipam?
I saw you mentioned a configuration in Possible Solution. Were you able to fix the issue with the Possible Solution?

Hi @ShaPoHun , it looks like something is happening on node1 since I can also see that your kube-controllers are terminating as well. How are the nodes and k8s set up? Since it appears only one of the init containers is able to start, can we get the logs from that init container as well? Should be something like kubectl logs calico-node-mxmp8 -n kube-system -c upgrade-ipam.

Closing for now, please open another issue if you're still having issues, thanks!


build error

Traceback (most recent call last):
  File "/home/deepthought/.pyenv/versions/3.7.0/bin/jpy-flette", line 11, in <module>
    sys.exit(cli())
  File "/home/deepthought/.pyenv/versions/3.7.0/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/deepthought/.pyenv/versions/3.7.0/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/deepthought/.pyenv/versions/3.7.0/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/deepthought/.pyenv/versions/3.7.0/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/deepthought/.pyenv/versions/3.7.0/lib/python3.7/site-packages/jpy_flette/jpy_flette.py", line 54, in cli
    with open(resource("fletteconf-default.yaml")) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/deepthought/.pyenv/versions/3.7.0/lib/python3.7/site-packages/jpy_flette/fletteconf-default.yaml'

seems like i need fletteconf-default.yaml files.

I use pip install jpy-flette command


follow does not follow skimdb.npmjs.com to the end

I am currently writing a program to import the npm-registry into another database. I have the program that follow stops at change-number 375253 and does not receive any more data, but skimdb has over 500000 changes right now.
The issue can be reproduced with the following code snippet:
var follow = require('follow');

follow({db: "http://skimdb.npmjs.com/registry", since: 375250, include_docs: true}, function (error, change) {
    console.log("received seq " + change.seq + " from update stream");
});

I'm getting the output
received seq 375253 from update stream

followed by nothing but a waiting console (for days). However, if I go to https://skimdb.npmjs.com/registry/_changes?feed=continuous&since=375250&include_docs=true
I get many more updates.
It would by nice if you could have a look into it.

Mhm the document coming along with change 375255 seems to be rather big (4.9 MB). Maybe that has something to do with it.

I'm closing this issue, because the example above seems not to be enough to reproduce the problem.
After waiting  a while, stream continues. I just has a longer pause, which might be cause by the large document.
My actual program is a bit more complicated and the problem could not be solved by just waiting, but I will have to try to create a new minimal example to reproduce it.

This seems to be an issue with node-version 0.12.7. The current stable (4.2.3) produces the behavior described in my last comment: About 20 seconds of being very busy (100% CPU) and then continuing.


Rubocop autocorrect and simplification

Autocorrect rubocop complaints in provisioning models and some general cleanup

@miq-bot add_label provisioning,refactoring

@Fryguy @gmcculloug please review

Big fan of this, but please add a PR description.
Looks like this is just: "Trying to clean up a bunch of random rubocop errors"

@Fryguy @gmcculloug Any concerns?

I have not had time to look through this yet but I need to before we merge.  Is this blocking you?

@gmcculloug Not blocking me, just keep running into merge conflicts

@brandondunne Can you change the PR title.  It makes it sound like the whole this is rubocop -a, but it's not.  I was about to merge because I thought it was only automated changes.

@gmcculloug Would it be easier if I split this into a couple PR's? (Rubocop autocorrects and rubocop complaints)

@brandondunne I started reviewing and noticed issues on the first 2 commits where more is changed then the commit title would suggest.  For example the first commit "alignment and whitespace" contains many other changes like converting arrays to use %w, deleting self in a few places, dropping unneeded brackets and renaming parameters to use "_".  These are all reasonable changes but having the different changes mixed into commits makes this an extremely time consuming process with such a large PR.
Any idea why these changes are mixed like this?

@gmcculloug Previous merge conflicts and rebasing got the changes in each commit a little bit messy, I updated the PR to properly split the changes in each commit.

@gmcculloug I corrected the log message as you suggested


Create Public Email and Publishing Tools

To publish the application on Google's Play Store, a common email and a signing key are necessary.
Create these tools and handle the common password that will be used to maintain the e-mail and application key.
The Application Signing Key requires a validity of at least 10 years and needs to be stored in a keystore. More information about those procedures can be found here

I've created the email address<EMAIL_ADDRESS>and I've invited you all to be administrators on the developer console.
The signing key can be done in Android Studio as indicated here: https://developer.android.com/tools/publishing/app-signing.html
We should also use ProGuard before publishing which will remove all comments and encode our code so that it uses the least amount of space possible: http://developer.android.com/tools/help/proguard.html

Has the signing key been created? If so, we can probably close this issue.


Immutable state

This pull request is adding a new version of an immutable state, one that won't allow you to add new objects nor remove objects. You can only change the attribute values of an object. In this manner, it allows for efficient hashing and equality testing, especially with name dependent comparisons.
It also includes two new hash factories specifically for immutable states. The ImmutableStateHashableStateFactory will automatically cache hashCodes with the object instances and adds in equality testing using the == operator. Which makes equality a bit faster.
I pushed ObjectInstance equality for ImmutableObjectInstances into that class itself. It requires a separate field in ImmutableObjectInstance for tracking indentifier independence, so that equals() can call the correct version. However, because it implements equals() and caches hashCodes, you can throw all the items into a set and check set equalities when comparing state equalities, which simplifies a lot.
The FixedSizeStateHashableStateFactory only works on fixed size states. For name dependent comparisons, it won't sort hash codes, and will just compare objects pair wise. For name independent, it resorts to its base class's implementation.
I added in several other minor optimizations, especially geared around StateReachability and GridWorldDomain.
It also adds in the Trove library, which allows for more space efficient maps/sets, which should help for large state spaces. It allows primitives in its collections, so that saves a lot, esp with how I've done the immutable class data structures. I've been able to easily reach state reachability analyses with > 1M states in just a few minutes.
I also added in a generic method for setting the value of an object in a state, without having to getObject/setValue separately. This makes it a little easier when switching between Immutable and Mutable state versions.
Let me know if you have any questions, or want any changes. I should do a tutorial shortly...

This looks pretty good! And looking through the changes I see no reason that it could conflict with anything else that needs to be tested. Merging.


Create GitHubPages.gitignore

Reasons for making this change:
https://github.com/github/pages-gem/issues/768
Links to documentation supporting these rule changes:
https://github.com/github/pages-gem/issues/768
If this is a new template:

Link to application or project’s homepage: pages.github.com

GO TO AMAZON SITE FOR $1000 VOUCHER: DO NOT CLICK
You will be redirected to the new address in five seconds.
If you see this message for more than 5 seconds, please click on the link above!

GO TO AMAZON SITE FOR $1000 VOUCHER: DO NOT CLICK
You will be redirected to the new address in five seconds.
If you see this message for more than 5 seconds, please click on the link above!

The new file provides enough context, however, the PR doesn't. Can you point to links to other users that have come across this issue?

I'm not @fulldecent, but I stumbled upon this PR through the Google query "Gemfile.lock GitHub Pages".
I made this search because I received a dependabot PR for a Gemfile.lock file in my Jekyll-based GitHub Pages site, and I was curious how necessary it was to actually maintain a Gemfile.lock file for a GitHub Pages site.

Can you point to links to other users that have come across this issue?

There is myself, but also a little bit of activity for this concern on this StackOverflow post.

Added link in PR towards details on the issue as per @joshuacwnewton suggestion.

Ping. Waiting for merge.


Definitely worth mentioning that trigger names cannot include underscores

Hugely frustrating time sink that could have been neatly solved by mentioning this particular quirk in the documentation somewhere. (if it's already mentioned somewhere and I missed it, I apologize.)
For python developers, normal variable naming conventions include underscores. Not supporting that in the triggers is odd, but excusable if it's documented somewhere.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ecb1e79-f603-03fd-2ef9-c6cf08ffaacd
Version Independent ID: 35c99e36-f224-350b-a258-2e0cfb8ab154
Content: Azure Blob storage trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-storage-blob-trigger.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@jpborsi We are checking this and we will get back to you.

@PramodValavala-MSFT  still an error 4 years later.


--sort-types doesn’t sort generated request param objects

Using the --sort-types or { sortTypes: true } configuration sorts the schema correctly but when combined with --extract-request-params only the response schemata have sorted fields.
Generated request params remain in the order they're defined, for example:
{
  "paths": {
    "/v1/endpoint": {
      "get": {
        "parameters": [
          {
            "name": "start",
            "in": "query",
            ...
          },
          {
            "name": "stop",
            "in": "query",
            ...
          },
          {
            "name": "id",
            "in": "query",
            ...
          },
        ],
      },
      ...
    }
  }
}

will be rendered as
export interface GetV1EndpointParams {
  start: string;
  stop: string;
  id: string;
}

With --sort-types the expected return should be
export interface GetV1EndpointParams {
  id: string;
  start: string;
  stop: string;
}

It would be awesome to get a solution for this @Aarononomous

This is done as of 13.0.0. Thanks all!


doc: ethernet 3.7 release notes

Release notes for 3.7 ethernet drivers.

Fix the compliance check, and maybe group items per driver? A lot has to do with NXP ENET for example.

I did try to group them by driver, do you mean to make some kind of header for each one?

I did try to group them by driver, do you mean to make some kind of header for each one?

Yeah, I meant a subsection.

@decsny  can you please fix the doc build issues?

@decsny please note you have missed some of the requested changes.
A separate suggestion regarding the way of working: If when a rebase is needed, the rebase is pushed first, and after the relevant updates to the PR content are pushed, reviewers can see easier from the diffs what has changed that is meaningful.


fix(bpmn): unregister commandStack.changed listener

closes #2732

Gold or metal medal? Makes a difference.

Obviously Metal :guitar:


Github Enterprise Server - Couldn't get repository details

Steps to reproduce:

Use Github Enterprise Server (not Github Enterprise) as your repository source
Azure: Sign In
Azure Pipelines: Configure Pipeline
No prompts just an error:

Couldn't get repository details. Ensure your repo is hosted on [Azure Repos](https://docs.microsoft.com/azure/devops/repos/get-started) or [GitHub](https://guides.github.com/activities/hello-world/).

Azure Pipeline Logs
(10/13/2023, 1:06:00 PM) [SchemaDetection] Detecting schema for workspace folder <redacted>
(10/13/2023, 1:06:00 PM) [SchemaDetection] Found remote URL for <redacted>: git@<redacted>:<redacted>/<redacted>.git
(10/13/2023, 1:06:00 PM) [SchemaDetection] <redacted> has no remote URL or is not an Azure repo
(10/13/2023, 1:06:00 PM) [SchemaDetection] Using cached information for <redacted>: <redacted>, <redacted>
(10/13/2023, 1:06:01 PM) [SchemaDetection] Retrieving schema for <redacted>
(10/13/2023, 1:06:01 PM) [SchemaDetection] User is not eligible for enhanced 1ESPT Schema Intellisense.
(10/13/2023, 1:06:01 PM) [SchemaDetection] Returning cached schema for <redacted>
(10/13/2023, 1:06:01 PM) [SchemaDetection] Detected schema for workspace folder <redacted>: /C:/Users/<redacted>/AppData/Roaming/Code/User/globalStorage/ms-azure-devops.azure-pipelines/<redacted>-schema.json
(10/13/2023, 1:06:13 PM) Couldn't get repository details. Ensure your repo is hosted on [Azure Repos](https://docs.microsoft.com/azure/devops/repos/get-started) or [GitHub](https://guides.github.com/activities/hello-world/).

VSCode Information
Version: 1.83.0 (system setup)
Commit: e7e037083ff4455cf320e344325dacb480062c3c
Date: 2023-10-03T16:12:16.321Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Azure Pipelines Extension: v1.228.0

Hi @coolhome,
Thank you for reporting this issue, we will take a look.

As the message notes, this is expected - only repos hosted on the cloud versions of ADO and GitHub are supported at this time.

Message is displayed also on dev.azure.com instances as well.


Rename ZookeeperTimeout to ZookeeperSessionTimeout

It's not actually a read timeout.
If this value is not enough large, ephemeral nodes will be deleted while
reconnecting to another ZK node when the leader ZK node goes down.

Ok, while this is actually a breaking change, I still think it makes sense in order to avoid confusion while configuring the consumer. Please fix the place I commented at and I will happily merge your PR. Thanks!

Thanks! Fixed the inconsistent name.

Merged. Thanks!


use semantic versioning

v1.9.0 had a breaking change (as did v1.5.0, v1.3.0, v1.2.0, and v1.1.0), so should have bumped a major version instead of the minor. Part of publishing an npm package is adhering to semver (https://docs.npmjs.com/about-semantic-versioning & https://semver.org/). Please use semantic versioning. Cheers!

@PixnBits thank you for the issue. At this point since we haven't followed semver for this repo, I don't think we will until we have the bandwidth to invest significant effort into this SDK again. I understand your frustration, we are doing the best we can.

@PixnBits Thank you for the feedback. We will plan to include this in the next major release of the SDK. Closing for now but please reopen if this is an issue.


Write unit tests for namespace.go

Is your feature request related to a problem? Please describe.
Write unit tests for namespace.go.

Closed by #213.


Ask for login details only after slot is available

Right now, we need to login everytime after the token expires i.e every few minutes. Instead of this, ask for login details just for the 1st time and then only after slots are available ask for the login details.

by the time u log in the slots will be filled.

The API needs the token to query for slots

we can use below api for getting slots
https://cdn-api.co-vin.in/api/v2/appointment/sessions/public/calendarByPin?pincode=390024&date=06-05-2021

It's better the way it is.. if you have to wait for OTP to come in and then make a booking, it will be too late.. The slots are typically gone in 10 to 15 seconds

In the current way, we have to enter otp every 12 mins or so. I would prefer to enter OTP once after the slots are available. Entering OTP wont take 10 seconds.

https://twitter.com/blorevaccine?s=21 follow this bot then.. then u can login and try your luck..  this works only for blore locations.

Thanks but I have already modified this repo's code to support my use case.


Update subscribe modal's style to support i18n, fixes #3526

Subscribe modal: make the "parent" and "sale" buttons take only as much space as necessary and the "subscribe" button takes all the remaining space, this fixes #3526.
Here's how the new style looks:
Before

After

Looks good, thanks!


Run selenium server, using docker inside binder

I am preparing some lectures in which students use library(RSelenium) in R. This requires that the students launch a selenium server in a container:
docker run -d -p 4445:4444 selenium/standalone-firefox:2.53.1

What would be the best way to achieve this functionality?

Hi there 👋!
Can we move this discussion to http://discourse.jupyter.org/ (where most of the people who hang out here also hang out, as well as more people). We are trying to streamline the different discussion places and want to use the issues on GitHub repos for technical discussions on how to change the contents of the repo. More general discussions should go to discourse so that they are easier to find, better indexed by google and generally more accessible than being hidden in the bowls of a GitHub repository ;)
Without knowing much about selenium or how the R library uses it: you can't start an additional container in binder. You only get one. However you should be able to install selenium in that container and start a selenium server/process. Once you know which commands to run take a look at https://repo2docker.readthedocs.io/en/latest/config_files.html the various config files we support to perform the steps you need to run.
Thanks!


Make JSON.parse return JSON::Any, and make it easy to traverse a dynamic JSON structure. Fixes #1832

This is the implementation for #1832
I decided to name the "cast" methods as_i, as_s, etc., to avoid confusion: if you do to_s on a value that isn't necessarily a String, will the value be converted to a String? Or if you do to_i and the underlying value is a String that can be parsed as an int, will it work? Because as_... is not related to to_... methods, which usually perform conversion/parsing, the distinction is a bit more clear.

:+1:

Awesome work :+1:


Consider image age in popularity calculations

Many high-view, and therefore by our standards, 'popular', Flickr images are simply images that are 10+ years old, and therefore have been viewed many many times. These images, especially by virtue of their age, many of them shot in the early days of digital photography with very low-quality cameras, aren't great.
The first image for a search for 'puppies', for example, is a 12 year old, 1 DPI, 320px wide image! Certainally not a 'good' result by most standards.
Alternative Approaches
Instead of making assumptions based on age, we could also look at penalizing images by other metrics, like:

DPI in exif data
Dimensions below a threshold

I thought about this a bit back at CC.  One idea was simply to have some "quality" options for the user, and let them filter out small or low-quality images (maybe that could be the default).  The reason not to naively use image ages is that some older photos are the most iconic for a given subject (think 9/11, Mars rover, etc.).


Feature/instant answer 74

close #74

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Swift 3 release

Hello EventSource team,
I noticed, that the PR with all the Swift 3 changes was merged, but there is still no tag for the most fresh version, so I would be able to use it via CocoaPods. Can it be created? If not, maybe you need some help there as my project depends on it.

hi @sashabelonogov! Sorry for the delay, we've been kind of busy. I just updated the pod, it's pointing to release  2.0.0 (swift 3.0 support) so everything should be ready to use!
Let me know if something goes wrong!


Add an error exit code when crystal tool unreachable finds results

I would like to be able to use the crystal tool unreachable command in a CI like gitlab-ci or github-actions.
For the jobs to be in error, the command would have to have the same behavior as crystal tool format --check
#sample.cr
def foo
  1
end
def bar
  2
end
bar

On text output
crystal tool unreachable sample.cr

Expected output : [...]/sample.cr:1:1	top-level foo	3 lines
Expected exit code : 1
On Json output
crystal tool unreachable -f json sample.cr

Expected output : [{"name":"top-level foo","location":"[...]/sample.cr:1:1","lines":3}]
Expected exit code : 1

I'd definitely be keen for something like this!
In the meantime I've been doing this which also works (GitHub actions example)
- name: Check for unreachable code
  run: |
    output=$(crystal tool unreachable sample.cr)
    echo "$output"
    if [ -n "$output" ]; then
      exit 1
    fi

thank you, I took your code to put it in a gitlab jobs here
unreachable:   stage: component_test   script:     - |        output=$(crystal tool unreachable src/cfp.cr)        echo "$output"        if [ -n "$output" ]; then          exit 1        fi
it unblocks me in the meantime


Add new (interesting) examples

Add new example projects to the examples/ directory, like subtractors, multipliers, gates, etc.
This does not require writing any code

It's quite difficult to make mux. I am trying to  get a module to output a switch and it's NOT value but im not just able to do that.

Btw, would you be interested in adding encoders, priority encoders, decoders to examples?

Sure, everything is appreciated.
I don't have particular specific plans to what should be added, the examples should just demonstrate what the simulator can do

Sure, everything is appreciated. I don't have particular specific plans to what should be added, the examples should just demonstrate what the simulator can do

Alright, I have put a PR related to that, please take a look @Spydr06.


Missing Learn.md [Documentation Bug]:

Describe the bug ✍
Learn.md file is missing in our current repository
@kunjgit assign this issue to me I will add it.
Provide step by step information reproduce the bug 📄
I will add all necessary sections required for this file.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Meetjain1 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

@kunjgit Could you please assign this issue to me under the GSSOC'24 label?

/assign

Hey @Meetjain1 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Adding contentType to document

Motivation and Context (Why the change? What's the scenario?)
This addresses #471.
High level description (Approach, Design)
I just added a contentType to the document. Seems to fix some problems I faced with #471.

hi @pradeepr-roboticist the PR is ready for merge, only pending CLA, see the comments above. Thanks!

please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree

hi @pradeepr-roboticist the PR is ready for merge, only pending CLA, see the comment above. Thanks!

Just agreed to CLA. Thanks for the quick review!


DataMapper batchGet method example

Hello, sorry for opening an issue but I just need to know how to use the batchGet in the Data Mapper.
I created the model classes using DataMapper Annotations and passed new instances of those classes to the batchGet method in a for await but it returns null.
These classes work fine for other methods such as get, put etc.
Example
const gets = [new Class1(), new Class2()];

for await (const item of mapper.batchGet(gets)) {
                console.log(item)
}

Thank you.

Hi @dianascarlett,
I can add examples for the batch methods to the readme file; it would probably be helpful to have examples for all methods.
The issue you're running into is that batchGet will only return results for items that exist in the table; no result is returned if the key does not exist. The first line would look something like the following (vary based on the key properties used for Class1 and Class2):
const gets = [
    Object.assign(new Class1, {keyProperty: 'keyValue'}),
    Object.assign(new Class2, {keyProperty: 'keyValue'}),
];

Hi!
I'm not sure either on how to use your library when I use annotations:
@table('Rule')
export class Rule {

    @hashKey()
    private sourceID : string;

    @rangeKey({defaultProvider: () => uuid.v4()})
    private ID : String;
...
}

public queryRulesBySourceID(sourceID : string) : AsyncIterableIterator<Rule> {
        const keyCondition = {
            sourceID: sourceID
        };
        return mapper.query(Rule, keyCondition);
    }

When I run it I get:
2018-03-10T00:32:04.509Z	744846f1-23fa-11e8-b2c1-7db081c5c204	(node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot convert object to primitive value

So, it seems that it got some results but it wasn't able to transform them.
Any idea what might be happening?


migrate to pipenv

unfortunately, due to general slowness of pipenv, the transition doesn't make much sense at this point. Besides, the main intended usage of this product is as a library which makes pipenv not that strongly applicable anyway.
https://github.com/pypa/pipenv/issues/3827


Update router.js

Hi,
Links to external hosts are now automatically ignored

Hey @ynonp, thanks for the report!
I believe that the case of external origins, aka el.host !== window.location.host, are handled in the intercept-link-clicks module, which nighthawk uses to intercept all the anchor clicks.  Here is the relevant code for that: https://github.com/wesleytodd/intercept-link-clicks/blob/master/index.js#L121
I could very well be wrong, so if you could provide a test case for the issue, I would be happy to resolve this and publish a patch.  The test for this behavior in the underlying module can be found here: https://github.com/wesleytodd/intercept-link-clicks/blob/master/test/intercept.js#L88
In theory, if you call onClick directly with your own anchor element you could hit this behavior and bypass intercept-link-clicks, so if something like this is your use case I would love to see an example, and maybe I can help find another way.


Login using wikimedia oauth system

Liked the implementation, and agree that we dont need to keep track of users in database. We just need to record the username along with batches


Remove GTM code left behind after PR #1304

Context
PR #1304 didn't quite get rid of all Google Tag Manager code.
Changes proposed in this pull request

remove (hopefully) the last bits of GTM

Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

L-GTM!


https://apps.apple.com/app/id1054747306

I need a link to this game for testflight beta.

Not yet, if you find one, welcome to submit a PR


Add the requirements.components.txt constraint file (#529)

Pull request opened by the merge tool on behalf of #529

Merged into branches iso6 in b06c81f1f803c8b6920ae631a116252b3e175110


Signal 11 was raised - native iOS crash when testing with Detox

Description
Hello, when my test is being executed, I have a "Signal 11 was raised" native iOS crash.
I don't understand this error, and I have no additional informations in the RN console or

[OK] I have tested this issue on the latest Detox release and it still reproduces

Screenshots

Environment (please complete the following information):

Detox:17.7.1
React Native: 0.63.3
Node: 12
Device: Any iOS simulator
Xcode: 12.2
iOS: 12.4 or 14
macOS: Latest

Logs
stack.txt
Thanks for the great work

Hmm, this is some special case we are not familiar with. Do you have a MapView visible? It seems rendering it is causing a crash. I will investigate.

Hello @LeoNatan I can confirm you that the MapView is causing the crash.
I removed it and the test is fine.
So it might be a bug with the MapView.

Fixed

I facing this issue. how to make it work with maps? and I saw another issue with same thing which says caused by firebase notifications. is there any solution for this?


The document creation or update failed because of invalid reference

Deploys entire ADF (v2) from JSON files to ADF instance
Version      : 0.8.180
Deployment fali with:  The document creation or update failed because of invalid reference.
I have deployed on empty Data Factory instance.
2020-10-07T13:20:09.8541313Z Start deploying object: [pipeline].[Process Noah] (3 dependency/ies)
2020-10-07T13:20:09.8688947Z Start deploying object: [pipeline].[Scale Noah database] (2 dependency/ies)
2020-10-07T13:20:10.1034287Z ##[error]Referenced object [Stage_SqlServer_Noah_] was not found.
2020-10-07T13:20:10.1929351Z ##[section]Finishing: Publish ADF from JSON files

Data set [Stage_SqlServer_Noah_] has not been deployed before [pipeline].[Scale Noah database].
Before this activity:

ok, I was able to reproduce the issue. Looking at this now.
The same name for objects of different types is the root cause likely.


Warning while training : "Attention for loop 6: immediate & carryover decomp don't sum up to total"

During the training I got this warning "Attention for loop 6: immediate & carryover decomp don't sum up to total". It didnt break the training process but i would like to know what does that mean
I am using
R 4.2.2
Robyn 3.9.0
Windows 10

I'm having exactly the same problem when running robyn_refresh with the demo.R script as in Github on the simulated dataset, as well as a couple of other errors which break the refresh. Why might that be?

Thanks for reporting this. It's an internal Q&A step to check if the sum of immediate & carryover equals to the total. It's not a fatal error. I can only debug with a dataset and model specs (robyn_inputs() and the hyperparameters) that can reproduce this warning.

unfortunatly I cant share my data but i understand . Thanks.


Add pumping power to examples

Delete unnecessary print on p_out correlation not implemented

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 22.22222% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (51629aa) to head (9eb66c4).
Report is 7 commits behind head on main.

Files with missing lines
Patch %
Lines

tools/component_tools.py
22.22%
28 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   61.86%   60.73%   -1.13%
==========================================
  Files           5        5
  Lines        1138     1164      +26
==========================================
+ Hits          704      707       +3
- Misses        434      457      +23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update action that pulls in deprecated version of Node.js

Missed an action that still pulls in a deprecated version of Node.js, so correct that now.
Description
Use of deprecated version of Node.js
Verification
Code inspection

Thanks!


Missing header makes invocation hang

Invoking a Node function without -H 'Content-Type: application/json' makes it hang.
curl http://knative-square.default.svc.cluster.local -d 2

hangs with no repsonse.
In contrast, the Command Runtime returns normally.
curl http://knative-greet.default.svc.cluster.local -d 2

Thanks for the report @kapolos.
I think you may have been bitten by https://github.com/projectriff/node-function-invoker/issues/133.
The streaming adapter, which acts as a HTTP proxy in front of streaming invokers (Node, Java but not Command), defaults the Content-Type and the Accept headers.
So your payload ends up being interpreted as application/octet-stream, and the conversion may then fail. Once the above issue is fixed (very soon), the request will not hang and you will see an explicit error.
In order for me to confirm this hypothesis, could you please re-run curl with the verbose option, tail the logs of the function container of the Knative adapter pod and share them here?
Thanks a lot!

Let me first find a non-obtrusive way to get verbose logs from the Node invoker (i.e. expose NODE_DEBUG='riff' when the adapter is started in the cluster).

Closing this as this seems to duplicate #133. Feel free to reopen it if you do not think so.


need easy way to update HLine and VLine position

This could be plt.ClearAxisLines or something else

This was easy enough with the ScottPlotDraggableMarkers demo. No change needed.
Also, plt.Clear() now has specific arguments.
https://github.com/swharden/ScottPlot/blob/bf6d1801b93d0eb4b92d84b9694a3618f49b0939/src/ScottPlot/Plot.cs#L179-L182


Negative numbers aren't parsed correctly.

Negative numbers aren't parsed correctly in command line.

Fixed.


Added unit test for missing case

Noticed while doing this exercise there was a missing test case.
Nothing like a good ol' Office reference.

This is failing CI due to https://github.com/exercism/configlet/issues/173 (which I have fixed on master) and because the sample solution doesn't handle this case properly. I'm going to merge and update the sample solution to account for this case.


Add tox-travis integration support, added py34 and py35 support.

With tox-travis, the correct python version is displayed in Travis.

Thanks, but we will migrate to GitHub Actions #215


[EMB-298] Fix up styles for status banners

Purpose
Status banners had bottom margin.
Also:

close button for dismissible jumbo status banners was being rendered off screen
banners were always dismissible due to misspelling

Summary of Changes

Refactor styles to use ember-css-modules more appropriately
Remove bottom margin for .alert
Adjust position of close button for jumbo banners so it is rendered on screen and aligns with non-jumbo banners' close buttons.
Fix spelling of dismissible

Side Effects / Testing Notes
Make sure style changes work for all types of banners (dismissible and non-dismissible, jumbo and regular).
Ticket
https://openscience.atlassian.net/browse/EMB-298
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage remained the same at 60.743% when pulling 68a8ab7f8250025f50a9d19043dcdc4e35449042 on jamescdavis:EMB-298_welcome_banner_padding into e504868855e67530929c7e37dc49762f4030c509 on CenterForOpenScience:develop.


New Google Tag Manager Connection Not Loading

Description of bug
Upgraded to latest version 9.8.1. Went to connectors, entered our GTM code in the tag manager. Reloaded site. No tag manager is being loaded. If I look at the install and upgrade packages I see the SiteAnalytics.config looks the same. I don't see any references to the new TagManager config file.

Steps to reproduce
List the precise steps to reproduce the bug:

Go to settings
Click on connectors
Enter gtm id and hit save
Refresh site
No tag manager code

Current behavior
Tag manager is not loading on dnn portal
Expected behavior
Site should load tag manager code
Screenshots

Error information
No error messages
Affected version

[X] 09.08.01 latest supported release

Affected browser

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[X] Microsoft Edge Chromium

This issue has already been documented and is fixed in the 9.9.0 release.

Awesome thank you!


:sparkles: Add checks for workflow action pinning

Please check if the PR fulfills these requirements

[X] Tests for the changes have been added (for bug fixes / features)
[X] PR title follows the guidelines defined in  https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#pr-process

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
We don't check for dependency pinning in github workflows

What is the new behavior (if this is a feature change)?
Check for dependency pinning in github workflows

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Other information:

Rebased patch from Laurent Simon

This just cleans up https://github.com/ossf/scorecard/pull/451, rebases it, fixes some go.mod issues.

This is what i did::
git pull --rebase
there were go.mod, go.sum conflicts.
git reset go.mod go.sum
git checkout go.mod go.sum
then make all
fix test failures - xyz@hash, removed the need for # comment at end
fix some frozen_test failure
git commit with go.mod, go.sum changes
then verify with
make all
make e2e
(make sure to set GITHUB_AUTH_TOKEN).


Update logic in block.getNumPins

If a block has dummypin components, getNumPins will ignore those and return the wrong number of pins. This method should be updated to account for more types of pins.

Sorry, I'm having trouble finding the string "dummypin" in ARMI.  I'm not trying to be obtuse.  Could you link an example line of code?

the issue isn't really an ARMI problem. It's that a dummypin component receives neither the dummy nor the pin flags. If it had the pin flag then the code would work fine. This can be resolved within the blueprints file itself by renaming to dummy pin.
If we think this is an issue that could affect others, we could add a conversion: example here [re.compile(r"\bINNERDUCT\b"): Flags.INNER | Flags.DUCT,]

@dlangewisch didn't you discover this problem? It will be fixed via the above mentioned blueprints update.

If we think this is an issue that could affect others, we could add a conversion: example here [re.compile(r"\bINNERDUCT\b"): Flags.INNER | Flags.DUCT,]

@john-science I am happy to make this as a small PR instead since it affects more than one test. What do you think?

just gonna fix the component name in the tests. Closing!