Improve support to atype service type

Moving here fix from https://github.com/jmdns/jmdns/pull/253
decodeQualifiedNameMapForType was not able to parse correctly the A/AAA records because the published type is of the format android_1234.local.. This was breaking as the _qualifiedNameMap recognized the type as only application name due to the underscore in the instance name. Checking the RFC and browsing I came to the conclusion that A/AAA records can only be formatted as .. The fix adds an additional regex to support the A/AAA record type format. This solved the majority of the issues where the A/AAA record where stored in cache with the wrong key and never found.
Big problem I encountered and probably will create an issue here is that one of the behaviors changed, and so the test.
One of the tests decode parses the type DIST123_7-F07_OC030_05_03941.local. as a lowercase application. This goes in contrast with all other test cases where the case of the type are all preserved and the type was not parsed and falled back to one application.
one of the other tests like  testAddress instead parses and splitpanoramix.local. into 2 parts: panoramix (instance/name) and local (domain) maintaining the case. The 2 types have the same structure but the underscore which is an allowed character.
Open to start a discussion about this, but I clearly see a case where the checks and tests are contrasting.

I'm not sure I can fully grasp the remaining issue here. Your fix seems to make sense if the RfC allows underscores in A/AAA records (which seems to be the case).

One of the tests decode parses the type DIST123_7-F07_OC030_05_03941.local. as a lowercase application.

So do you consider this test to be correct or is it simply a crappy test that we should ignore/delete from your pov?

IMHO a wrong test given the underscore and the fact that only allow lowercase when everything else maintains cases

The test we can keep it but it needs to be modified.

Ok, so then your changes should all be fine and there isn't any need for discussion then - even better!

oh wow! thanks!


[11.x] Add linesChunk method to the FileSystem class

The added method linesChunk in this PR is a slightly more advanced version of the lines method to enable us to jump and start from a particular line in the middle of a file. This is particularly useful when we want to only process newly appended files to large log files and continue on from where we last left off. The main problem with the lines method in such cases is that it read all the lines one by one (which involves a lot of "disk IO") and feeds them into the next step of lazy collection to get filtered out but with linesChunck start from
    //Create a sample ~100MB log file, with 1 million lines, 100 chars in each line.
    if (filesize(__DIR__.'/file.txt') < 10) {
            for ($i = 0; $i < 1_000_000; $i++) {

                file_put_contents(__DIR__.'/file.txt', '123456789|123456789|123456789|123456789|123456789|'.
                 '123456789|123456789|123456789|123456789|123456789|', FILE_APPEND);
            }
        }

        $files = new Filesystem;

        $t = microtime(true);
        $files->lines(__DIR__.'/file.txt')->skipWhile(function ($content, $number) {
            return $number < (1_000_000 - 10);
        })->all();
        echo (microtime(true) - $t);

        echo PHP_EOL;

        $t = microtime(true);
        $files->linesChunk(__DIR__.'/file.txt', 1_000_000 - 10)->all();
        echo (microtime(true) - $t);

The performance difference depends on the file size and hardware, and etc.
This is the result for me running on Windows 11 and an NVME drive as file storage.

Backward-compatibility:
To be fully Backward-compatible with class extenders that have overridden the lines method, I created a brand new method and did not tamper with the signature of the lines method. The lines method can now reuse the added functionality.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


313 Use Correct HTTP Codes

Closes #313

@fmueller, @mkulak could you please take a look on this PR?

👍


Mirror container setup

I reviewed the youtube Rancher meetup on May 26 but find a couple things missing that are necessary in recreating the setup. Can you provide some details on the mirror vm you set up, preferably with a means to verify it is properly mirroring the external registry. I am assuming this a v2 registry.
Also curious why you did not use vagrant where you were using vms. This would have provided much greater simplicity in reproducing this for others in your org and for demonstration purposes. Am currently working setting this up atm.
Also looking at how much of this is necessary in vms as it is. Currently I am on OSX native docker beta so there may be little use for vms at all. You can include the local machine as a host for a Rancher install and should be able to run and trigger projects directly for Jenkins builds without the need for virtualbox.

I used virtualbox as not everyone has access to Docker for Mac(windows) so wanted people to be able to replicate it. As I stated its really more of a showing what is possible rather than a prescriptive solution, so if you get it working with Docker for x...great. Docker for x also comes with its own little challenges such as setting a static ip...
In order to get the registry working I'm assuming you have created your machines as described at http://rancher.com/running-rancher-on-a-laptop/
Create the mirror and ensure that it has a static ip address. On the mirror host create file called /var/lib/boot2docker/config.yml and put the following in it:
version: 0.1
log:
  fields:
    service: registry
storage:
    cache:
        blobdescriptor: inmemory
    filesystem:
        rootdirectory: /var/lib/registry
http:
    addr: :5000
    headers:
        X-Content-Type-Options: [nosniff]
health:
  storagedriver:
    enabled: true
    interval: 10s
    threshold: 3
proxy:
    remoteurl: https://registry-1.docker.io

Then run the following command:
docker run -d -v /var/lib/boot2docker/config.yml:/etc/docker/registry/config.yml --restart=always -p 5000:5000 -e STANDALONE=false -e MIRROR_SOURCE=https://registry-1.docker.io -e MIRROR_SOURCE_INDEX=https://index.docker.io --name registry distribution/registry:2
This will now act as the mirror to docker hub.
On each host that you want to access the mirror add --registry-mirror=http://mirror_ip_address:5000 to the EXTRA_ARGS in /var/lib/boot2docker/profile
The only testing i've ever done is to pull pull a large image down once, and then pulling it again and it should be an order of magnitude faster.

Something weird happened to me with this setup it will just pull and store all images that you request from your machine but it will just use the mirror for some of them, like for example all my Docker images like this one https://hub.docker.com/r/zot24/php-fpm/ will be pulled from the registry once it's cached but if I require https://hub.docker.com/_/cassandra/ it will all the time pull it from the web instead of use my registry.
Have someone experienced this before?

Ok I just fixed! using distribution/registry:2.2 instead 👍


[v0.6.x] Adding ladon to vendor

This PR is just a sandbox to illustrate the usage of ladon and to check whether or not we want to use it for access control.
The first commit ladon vendoring.

Closing this PR until we have a first implementation of the permission model.


Preview/paulau staging

Content and navigation updates approved by ASF Marketing & Publicity @bproffitt  with support from @loganloganlogan  and @Paul-TT
Navigation updates:
Removed sub-navigation and consolidated links under a single navigation
Removed duplicated/outdated links
Content and light styling updates to:
About Us (previously named Overview in nav)
Leadership (new page)
Individual Supporters (formerly /contributing)
Sponsorship
Contact
History
FAQ
Connect & Mentor (new page)
Minor content and styling updates to:
Members
Legal & Trademark (removed old Twitter feed)
Our Sponsors (formerly /thanks)
Governance
Styling updates:
New H1, H2, H3, H4 styling for better readability
Added spacing throughout pages for better readability

@Paul-TT Can you change the branch name?

Thank you Brian and Sebb! Paul is out today and tomorrow, so your help is much appreciated.


display with rotation is not the same between vector and raster modes

to reproduce:

launch the example app from vector_map_examples
choose any map theme
rotate the map
toggle back and forth between "Vector" and "Raster"
observe the display is rotated, but not by the same amount for each mode

This issue doesn't occur with the previous version of flutter_map and version 6.0.2 of vector_map_tiles.

initial investigation makes me suspect that raster-mode is rotated by double the rotation


[SPARK-36848][SQL] Migrate ShowCurrentNamespaceStatement to v2 command framework

What changes were proposed in this pull request?
Migrate ShowCurrentNamespaceStatement to v2 command framework
Why are the changes needed?
Migrate to the standard V2 framework
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests

Test build #143619 has started for PR 34104 at commit 8bebbb5.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48131/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48131/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48131/

Test build #143619 has finished for PR 34104 at commit 8bebbb5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ShowCurrentNamespace(catalogManager: Option[CatalogManager]) extends LeafCommand

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143619/

cc @cloud-fan

Test build #143648 has started for PR 34104 at commit c5ac178.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48161/

Test build #143648 has finished for PR 34104 at commit c5ac178.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ShowCurrentNamespace() extends LeafCommand

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143648/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48161/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48161/

Thanks! Merging to master.

Thanks!


New Linter jsdebugmarkers

https://github.com/LeoLeal/SublimeLinter-jsdebugmarkers

Please make a release and it should be visible in Package Control less then an hour later.
Thanks!

The linter plugin is available on github... Is there any aditional step i
should follow?
Thanks
Em 25/09/2015 12:31 PM, "Blake Grotewold"<EMAIL_ADDRESS>escreveu:

Please make a release and it should be visible in Package Control less
then an hour later.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter3/issues/337#issuecomment-143253028
.

it needs a tag to for Package Control to detect changes.
Just create a 1.0.0 release here https://github.com/LeoLeal/SublimeLinter-jsdebugmarkers/releases

Oh! You mean that... :)
Done!
Em 25/09/2015 3:22 PM, "Blake Grotewold"<EMAIL_ADDRESS>escreveu:

it needs a tag to for Package Control to detect changes.
Just create a 1.0.0 release here
https://github.com/LeoLeal/SublimeLinter-jsdebugmarkers/releases
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter3/issues/337#issuecomment-143313840
.

https://packagecontrol.io/packages/SublimeLinter-jsdebugmarkers
Thanks again!


improve server shutdown for tests

try out https://github.com/encode/uvicorn/discussions/1103#discussioncomment-4240770

The threaded version might actually work


"load older eMails" should look like a button

Currently the button looks like a mail, which is missleading

Alternative: Remove Button and load on scroll down (Suggested by client)

So siehts momentan aus

Closed for now. We will implement the centralisation and capitalisation of the string.


Update 'int_imputation__detector_imputed_agg_five_minutes' and 'imputation__detector_summary'  model

As we have incorporated new model( average of local and regional detectors) as mentioned here #360 on top of local, regional and global regression. It is necessary to update the upstream model to reflect this. We will give the priority in the below sequence-

Local, Regional, global, average local and average global for volume, speed and occupancy

completed


Issuance.sol

Note: need to add tests.

Alright, ready for review.

Yeah, when I run yarn security I get:
myth: error: unrecognized arguments: --truffle

@obernardovieira Am I missing something?

yarn security does not work currently, because mythrill changed. I've got it working again a while ago, but it's not here. Don't use it for now. I'll open an issue to fix that. Sorry about that!

Also, rebase from dev branch and fix conflicts when you see them.

@obernardovieira Could not import ganache-time-traveler without require, it kept telling me that I don't have the d.ts file, even though it was there. Don't know what to do, any suggestions?

@obernardovieira Could not import ganache-time-traveler without require, it kept telling me that I don't have the d.ts file, even though it was there. Don't know what to do, any suggestions?

It seems to be an issue with typechain dependency. I tried to do as I usually do with other packages, and tslint says everything is ok, but when running generate-ts it fails. So I'll try to have something more specific and raise an issue at typechain repository.
Meanwhile, we can use it as it is. Just fix the conflicts and make CI work and I'll review it :+1:


Improve Somalier Pedigree checking and Slack notifications

There are some bugs in the SomalierPedigree QC stage and the way that relatedness QC flags are reported in the slack notifications.
How it works
Somalier Extract
Somalier extract downloads each sequencing group's CRAM (and index) and then runs the somalier extract command, specifying the sites file from references - /references/somalier/sites.hg38.vcf.gz (originally from the  somalier repo). This creates the Somalier "fingerprint" file - e.g. CPG12345.cram.somalier.
Somalier Relate
The way the stage works is by fetching all somalier fingerprint files for the input sequencing groups and then running Somalier Relate over all pairwise combinations of input sequencing groups within the same dataset.

Makes use of a pedigree file, taken from Metamist via the write_ped_file method from the Dataset pipelines target. The pedigree file only contains the input sequencing groups.
Uses the verify-bamid files created by the CramQC stage. Each sequencing group's verify-bamid file is read and the FREEMIX percentage is extracted from the bottom of the file (Last line, 7th column via FREEMIX=cat verify-bamid.file | tail -n1 | cut -f7)

The FREEMIX value is compared with the hardcoded MAX_FREEMIX ( = 0.04). If the sequencing group's freemix percentage is less than the maximum, the sequencing group's somalier fingerprint file is added to the list of inputs to Somalier Relate, and the sequencing group ID is added to the sequencing group IDs file.

Once all inputs sequencing groups have been decided (via the FREEMIX check above), the somalier relate command is invoked. This generates several outputs:

{output_prefix}.samples.tsv - a .ped like file with extra QC columns

Saved to gs://cpg-dataset-main/somalier/cram/<SG_HASH>/dataset.samples.tsv

{output_prefix}.pairs.tsv - IBS and other relatedness stats for all possible sample pairs

Saved to gs://cpg-dataset-main/somalier/cram/<SG_HASH>/dataset.pairs.tsv

{output_prefix}.html - interactive html

Saved to gs://cpg-dataset-main-web/cram-somalier-pedigree.html

Check Pedigree script
These results are used by the check_pedigree.py script from /cpg_workflows/python_scripts/. This script looks through the relatedness information produced by Somalier Relate, and formulates a Slack message to post to a private channel.

Read the somalier samples.tsv and pairs.tsv into pandas DataFrames.
Read the pedigree from Metamist and the somalier pedigree samples.tsv into expected_ped and inferred_ped respectively using peddy.Ped (from the creator of Somalier)
Check each expected vs inferred sex value and report on any mismatches or missing values
Iterate through the pairs of samples in each pedigree to find mismatches

Get the expected relationship between a pair of samples using peddy.Ped.relation(expected_ped_sample1, expected_ped_sample2)
Do the Same for the inferred relationship between the same pair of samples using the inferred pedigree
Ped.relation will return a string value for the type of relationship between the individuals. e.g. "mom-dad" if two samples have the same children. e.g. "unrelated" if the family ID for each sample is different.

If samples are "unrelated" but the relatedness score is > 0.1 (from pairs.tsv), then flag this as an inferred relationship where none is expected.
Formulate a report with all the flagged issues and send it to Slack.

What's not working
Unnecessary Slack message warnings of note:

"Provided: 'siblings', Inferred: 'full siblings', kin=[0.4, 0.6]"
"Provided: 'related at unknown level', Inferred: 'niece/nephew', kin=~0.25"

Both of these situations should be valid and not cause errors (I think).
Here is an example Slack post containing these warnings:
https://centrepopgen.slack.com/archives/C03BHD3EKH9/p1718751311646699

Issue with pedigree modelled correctly in Metamist, but not handled properly by cpg_workflows code:
The SomalierPedigree stage gets the "expected pedigree" from Metamist, and then compares it to the actual pedigree based on the relatedness values calculated by Somalier.
When it gets the "expected pedigree" from Metamist, what it's really doing is fetching the list of sequencing groups in the dataset, and then creating a row in the expected_pedigree.ped file for each sequencing group, via the write_ped_file method.
Because the expected pedigree is based on sequencing groups, if the parents don't have sequencing groups, then they are NOT included in this expected pedigree, leading to misreporting of errors in the Slack posts.


TFS row/col query string params removed from preview links

Links to specific functions in Team Foundation Server contain a row/col query string param.  The preview link in MarkdownLivePreview for some reason removes them from the rendered link location.  Issue does not appear to be on TFS side, as other markdown renderers link correctly.

Could you give an example of such a link? I have rewritten the whole package, and there are a lot less quirks about manipulating the final html (although there still are some because sublime's minihtml is really quirky), so I'm gonna assume it works now. If it doesn't, please reopen this issue.


Off-sample API: basic implementation to be used as Docker container

The README and example Jupyter notebook should provide enough information about how to use the API.
Design choices:

Falcon as web API framework
Gunicorn as application server
Model inference (prediction) - Fastai on top of PyTorch
Requests handled synchronously with two workers
No queue is used, so the client has to wait until the model finishes prediction for all images in the request
Parallel model inference is handled by Fastai/PyTorch

@LachlanStuart the review is not urgent and can wait till the middle of the next week


dis is not full, it has 100gb left

Error pulling image (latest) from docker.io/bigdatauniversity/spark, Untar re-exec error: exit status 1: output: write /usr/local/hadoop-2.6.0/share/doc/hadoop/hadoop-archives/images/bg.jpg: no space left on device

I believe the VM is capped at 20gb - You'll need to re-create it with a larger disk size if you're using that much space.
Take a look at: https://github.com/docker/kitematic/issues/825


Improve integration of build-tools module

The idea of the build-tools module is to easily reference certain configuration files (e.g. checkstyle config) as maven dependencies (e.g. for plugin executions). While this currently works for 3rd party projects, we cannot use the build-tools module in our own build process.
The reason for this is the introduction of a cyclic reference: The build-tools module depends on the parent module (because it inherits from the parent) and the parent module would depend on the build-tools module if we would declare it as a dependency in the plugin definitions. As a result we currently have to provide the absolute paths to the config files. This breaks the usage of some of the plugins (e.g. we cannot run the findbugs plugin in any module other than the parent, because the configuration paths are always evaluated project-relative, hence it would look in commons/build-utils/... for the configs).
With this ticket I'd like to discuss and evaluate possible solutions to this problem. So far I came up with three ideas:

do not let build-tools inherit from the parent:
This way, the build-tools module could be built before the parent and could therefore be referenced by the parent without any problem. The big downside of course is, that all (relevant) configurations currently defined in the parent would have to be copied to the build-tools module, so that it still integrates well in the build process. This would also increase the maintenance burden because all (relevant) configuration changes would need to be applied twice.
Introduce another build-parent that manages the plugin definitions:
The new build order would then be:

parent
├── build-tools
└── build-parent
    ├── algorithms
    ├── api
    ├── ...

This would resolve the cyclic dependecy, while still allowing us to configure the build process in a single place. On the other hand this adds another layer of abstraction to the already complex project structure.

Copy all plugin configurations to the current (relevant) modules:
In essence, this is the same approach of the second point, but does not introduce a new aggregating module. While this would allow us to keep the project structure as is, it suffers from the same maintenance burden (even more so) as the first point.

From a maintenance point of view, I prefer the second solution the most. Although I don't know how I should feel about this additional layer of abstraction. Any other ideas or feedback on this matter?
Note: The solution of this should also be applied to LearnLib/automatalib, as we have the same problem there.

I ended up with a small variation of my preferred solution mentioned above.
The main "trick" is, that module defintions (from top to bottom) don't always imply/require a reverse parent declaration (from bottom to top).
This way, the build-parent could simply be defined as a sibling-module, while the other modules may still reference the build-parent as their actual parent. This allows to fix our build-tools integration (single modules can now specify the -Pcode-analysis profile without error :thumbsup:) without having to make the project structure more complicated.


Update Razor version.

There isn't really any functional improvements in this insertion other than making our error telemetry Codespaces compliant

/cc @TanayParikh @ajaybhargavb @ryanbrandenburg

@NTaylorMullen Thanks!


Convert LDO to plain object

I'm trying to use LDO in a Solid React project, and I want to store data in redux. For this I need to convert LDO (which is a Proxy) to plain object. Is it currently possible?
I tried to use ldo.$toJsonLd(), but I get error Not Implemented.
Is $toJsonLD planned, or can this be achieved in some other way?
Btw i love the API and potential of this library. Great work!

After a bit of research, i was able to do it as follows:
// stringifying objects with circular reference, according to MDN:
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value#circular_references
const getCircularReplacer = () => {
  const seen = new WeakSet()
  return (key: string, value: unknown) => {
    if (typeof value === 'object' && value !== null) {
      if (seen.has(value)) {
        return
      }
      seen.add(value)
    }
    return value
  }
}

const plainObject = JSON.parse(JSON.stringify(ldo, getCircularReplacer()))

I was going to suggest using JSON.stringify as well. Unfortunately, $toJsonLd() needed to be removed because a third party library (jsonld-streaming-parser) had dependency problems with webpack. I will check to see if it's fixed next time I publish LDO.


Run firefox as non-root

Linux only.
Due to https://bugzilla.mozilla.org/show_bug.cgi?id=1323302 the firefox
executable can no longer be run by root.  So when chef tries to run
firefox -v it gets an error instead of the version.
This change adds a user to run the command as and then deletes the user.

This workaround works to fix issue #17


S3: change Bucket-URL to Bucket-ARN

already pushed out Bucket-URL, so keep the old one and use it if its set.

https://github.com/gravwell/gravwell/pull/554


Firebase Database on Consoles ??

hi,
is it possible to use Firebase Database on consoles?
like as XBOX one, PS4, Nintendo Switch and the great Google Stadia :]
thanks.

Just bumping this thread, thank you for the feature request. However, Google Stadia has officially been shut down since January 18, 2023. As for xBox one, PS4, Nintendo Switch, you'll need to create a feature request in their specific support channels. That said, I'll go ahead and close this thread.


Scope performance and external window

Improved the performance of the Scope plugin
Added options to the context menu for performance varying the size of buffer hence the number of points plotted.
Moved the line type and plot type parameters from the context menu to knobs and cv inputs on the widget
Interpolation between linetypes
Added external window for plotting. When external window open the widget no longer renders the waveform in the VCV ui

@david-c14
I am unsure if your intention is for me to merge, prepare the release, and submit to the VCV library?

@curlymorphic You can do that if you wish.    I own this project purely for historical reasons, and have no wish to be dictatorial or even proprietorial.
If you would prefer me to manage that side of things, I will. In which case just let me know in comments if you think that a push deserves submitting to the library, or if there might be further changes in the future so we should wait.
But I'm entirely happy if you want to complete and submit yourself.   You can easily find the appropriate library issue by searching for ModularFungi.

If I'm making the last changes before a new release, I usually include the change to plugin.json in the same work.  But sometimes I just make a separate PR for it called something like 'preparing for release 1.x.x'

I usually merge from develop to main using a PR as well.
Then create a release from the main branch.   This will trigger github actions which will build for all three platforms and attach the zips to the release.

@david-c14 Thanks for the advice, I shall proceed with the release process


Multi vehicle DVL + acoustic comms test case

This PR adds an integration test using 2 LRAUVs : Tethys and Daphne. Tethys is instructed to move at certain speed, its linear speed is observed using the DVL sensor, and sent to Daphne using acoustic comms. Daphne tries to catch up to Tethys with that speed.

@adityapande-1995 some tests are exceeding tolerances. This is new for non-mission tests. I wonder if something changed upstream.

@adityapande-1995 some tests are exceeding tolerances and failing. This is new for non-mission tests. I wonder if something changed upstream.

Should I increase tolerances here ? @caguero

CI is passing now

CI is passing now

I'm a bit worried about that. Seems unstable.

I've opened a PR to increase tolerance. Lets see how that goes : https://github.com/osrf/lrauv/pull/255


Project maintainance

Follow up of https://github.com/SweetIQ/schemats/issues/104#issuecomment-526201898
Some background : @xiamx the original author of this module, and @crispmark another contributor, have both left SweetIQ and can't provide maintenance anymore (see https://github.com/SweetIQ/schemats/pull/81#issuecomment-510185054).
At @Arhia (my company), we use this module everyday in a very big application and we would want this project to be maintained, so I proposed to start a fork and ensure a (at least minimal) maintenance.
Contributors will of course be welcomed.
The goal is to maintain the project and merge the potential good PR pending here.
Some questions though :
1. Organization
I created schemats organization today : https://github.com/schemats
I will invite people later (I'm still learning how to manage Collaborators rights)
2. Start point for the fork
Should the repository be forked from here or from https://github.com/xiamx/schemats/ ?
The latter is 12 commits ahead so I would like to start from it, @xiamx can you confirm it's a good idea ?
3. Forking or cloning
Forking keep the link with the original repository, but it's unlikely here that we will be able to merge back into SweetIQ/schemats so I would rather clone the repo, for clarity.
4. Npm
It looks like @xiamx owns npm account (see https://github.com/SweetIQ/schemats/issues/104#issuecomment-526375934) so we would be able to publish new version under the same name, providing a smooth transition.

I'd love to contribute to this new fork!
I think we should compose a list of all useful forks/PR's/issues that should be transferred to the new "fork"/version.
I already have #105 and an implementation of 'lookup tables' as enums pending. While creating these contributions I noticed that the current project structure doesn't have a separate build directory, I'd love to see that changed as well (probably already have a commit for that laying around somewhere).
Also I'd suggest adding dotenv to allow for easier configuration of the POSTGRES_URL and MYSQL_URL environment variables.

Should the repository be forked from here or from https://github.com/xiamx/schemats/ ?
The latter is 12 commits ahead so I would like to start from it, @xiamx can you confirm it's a good idea ?

I get the impression that @xiamx's intended for it to be a new home anyway so that'd probably work.

Forking keep the link with the original repository, but it's unlikely here that we will be able to merge back into SweetIQ/schemats so I would rather clone the repo, for clarity.

Should we change the name if we clone instead of fork to prevent confusion? I think perhaps the best possible solution would be to transfer this repository over to the new organization and go from there. This also makes merging pending material a lot easier.

Should we change the name if we clone instead of fork to prevent confusion?

You're right but all meaningful names (typedschema, etc) are already used, and if we can publish with the same name on npm, it worth keeping the name schemats

I think perhaps the best possible solution would be to transfer this repository over to the new organization and go from there. This also makes merging pending material a lot easier.

I don't think @xiamx could transfer this repository, it belongs to SweetIQ company (@xiamx can you confirm ?).
If it's the case, we will have to clone or to transfer https://github.com/xiamx/schemats/ to https://github.com/schemats

The https://github.com/xiamx/schemats/ fork is mostly url changes (SweetIQ -> xiamx), build/configuration fixes, and package updates. I think that it definitely makes sense to use that fork as the starting point.

Echoing what has already been said, I would agree that cloning makes the most sense. It's a shame that a deprecation + link from the current repo to the new one isn't likely.

This is great!

I'm not sure if I would advocate for a renaming of the codebase (as it's still the same tool), but if this was necessary I would recommend a subtle change like schema-ts.

I'm not sure if I would advocate for a renaming of the codebase (as it's still the same tool), but if this was necessary I would recommend a subtle change like schema-ts.

We should probably add a section on what this "new version" is to the README if a namechange is this subtle, to make it clear that this is the new and improved (and maintained) version.
I hope @xiamx can find a way to transfer this repository so we can avoid all confusion and keep the open issues/pull requests. Merging his fork as "starting point" would be trivial.

Unfortunately I don't think transfer of repo is a possibility. All the people I worked with before from sweetiq no longer work there...
It sucks that there's no easy way to redirect traffic from this project to the new one. But if this new fork/clone fixes important bugs, then recognition and popularity will flow in eventually 😄

That's unfortunate. Of course if we can publish to npm under the same name we can easily change all links to the new organization to direct any new users to the new location. Creating an issue in this repository with a title like "look over here for fixes" would probably be enough to direct all existing users (eventually).
That still leaves the issue of transferring PR's and issues however.

I've sent an email to github support to see if they have a way to mass copy issues and pull requests to a fork. Let's see if there's a non manual repetitive way available for us.

What’s the status of this? I would like to use Schemats in projects, but I was concerned that it looked abandoned. I can assist with maintenance if needed.

What’s the status of this?

I have forket this project to https://github.com/schemats/schemats and I'm loooking how to float the pending PR to the fork.

I would like to use Schemats in projects, but I was concerned that it looked abandoned. I can assist with maintenance if needed.

At @Arhia we will maintain it anyway, we rely on it for a very big application.

In the case that PRs cannot be transferred, what would you anticipate the fallback plan to be? I suppose that any of the larger PRs could be separately forked and merged with the the new repo prior to the full divergence.
To be honest, I would be a bit surprised if there was a non-manual way to transfer issues & PRs.

To be honest, I would be a bit surprised if there was a non-manual way to transfer issues & PRs.

Yes and no.
I will probably be able to recreate PR from the forks via the website.
For simple branches, I will have to use command line
see https://stackoverflow.com/questions/6022302/how-to-apply-unmerged-upstream-pull-requests-from-other-forks-into-my-fork

The command line probably wouldn't be necessary because you can create PR's from other people's forks (unless I'm missing something here...)

The command line probably wouldn't be necessary because you can create PR's from other people's forks (unless I'm missing something here...)

Yes, but only if there's a fork (nevertheless it should be the more common case).
I began to recreate the PR, see https://github.com/schemats/schemats/pull/1
If some folks want to send the PR themselves, they can (but I don't guarantee I will have enough time to review them and merge in the short term

If some folks want to send the PR themselves, they can (but I don't guarantee I will have enough time to review them and merge in the short term)

Maybe the folks here (and myself as well) can help contribute reviewing those.
@abenhamdine what's your npm username?

Maybe the folks here (and myself as well) can help contribute reviewing those.

Yes of course ! Let me just think about how to organize that without being overwhelmed by questions, etc...

@abenhamdine what's your npm username?

arnaudbenhamdine

@abenhamdine Is your company still planning on moving forward with this?  This repo is so getting so outdated, it'll be great to see a maintained version.

@ellis yes it's still planned, but we are currently working on a major release of our product, so it's difficult to work on it, sorry.

Also @jawj made some edits to it for https://github.com/jawj/mostly-ormless - I'm keen to use that approach at my company, but the lack of support for schemats (even moreso since his fork is likely even less-so) gives me cold feet to rely on the project. not familiar with the inner workings of the library but i'll read up a bit and see how i can help.

Hey everybody. I have forked this repo to https://github.com/mlogan/schematzah, upgraded all dependencies, made some tsconfig changes, switched to yarn, and pushed the result as the npm package schematzah.
I don't plan to do any development on this (I just needed a version built with a recent typescript), but I'm happy to merge PRs and publish new versions.
I know there was some discussion about moving PRs over to a new repo. I recommend just forking the new repo, pushing your commits to it, and then opening a new PR with a link back to the original PR.

That's awesome @mlogan !  I'll try to upgrade my projects!
On another note, in some of my projects I needed the schema types but in most of my projects what I really needed was types of the results of my queries...
Recently I've found pgTyped which does exactly that and I must say I enjoy it a lot (and it's well maintained)

Also @jawj made some edits to it for https://github.com/jawj/mostly-ormless - I'm keen to use that approach at my company, but the lack of support for schemats (even moreso since his fork is more likely to fall out of date) gives me cold feet to rely on this library. not familiar with the inner workings of the library but i'll read up a bit and see how i can help.

BTW @osdiab I've converted the 'mostly-ormless' approach into a new library, and I've rewritten out the dependency on this project. I'm currently writing up the documentation. It's at https://github.com/jawj/zapatos and published as zapatos on npm.

Another related successor project:
https://github.com/nettofarah/postgres-schema-ts


typo: apimanagement/control-plane/Microsoft.ApiManagement/apimbackends.json

parition -> partition

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-js

Can one of the admins verify this patch?

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node

Automation for azure-sdk-for-java


Un-flatten subchunkable inputs: **kwargs->op_kwargs

Do I also have to fix every cue file?

We only gotta make sure the spec/examples stay up to date, otherwise it's the responsibility of each person to maintain their folder.


doc: add patch dependence on ubuntu

Signed-off-by: qinggniq<EMAIL_ADDRESS>
When exec bazel build //source/exe:envoy-static, envoy depends on some external packages like com_googlesource_chromium_v8, when building it, bazel will patch wee8.patch. https://github.com/envoyproxy/envoy/blob/40964cc30d4e691df5c5f0c32a449a7b4462115a/bazel/genrule_repository.bzl#L12
Not all ubuntu distributions have the patch software, just now I tested on the ubuntu:16.04 from docker hub, there is no patch. So it's necessary to add this dependence.
Commit Message: improve envoy build guide doc
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: Yes
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Hi @qinggniq! Could you fill-up the PR description of why do we need patch to be installed? Thanks!

@dio filled up PR description.


2.5D alike

@kyleschaub  you can't go behind structures, it would be good if you implement 2.5D or else the character's sprite will disappear as it goes towards the structure.

2.5D is 3D seen from a 2D perspective and visibly 3D. what you want is for structures' collision box to be smaller, and their sprites to become more transparent when behind it


Support IE11?

Support IE11?

Support IE11?

Nop -> https://caniuse.com/intersectionobserver

Support IE11?

Nop -> https://caniuse.com/intersectionobserver


PTFE-679 implementing webhook endpoint and authentication

Codecov Report

Merging #332 (26c5e28) into main (17f554b) will decrease coverage by 68.39%.
The diff coverage is 72.72%.

:exclamation: Current head 26c5e28 differs from pull request most recent head 7a3b71a. Consider uploading reports for the commit 7a3b71a to get more accurate results

@@             Coverage Diff             @@
##             main     #332       +/-   ##
===========================================
- Coverage   91.77%   23.39%   -68.39%
===========================================
  Files          14       16        +2
  Lines         304      342       +38
===========================================
- Hits          279       80      -199
- Misses         25      262      +237

Flag
Coverage Δ

api
23.39% <72.72%> (+8.26%)
:arrow_up:

unit
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

runner_manager/clients/github.py
0.00% <0.00%> (-100.00%)
:arrow_down:

runner_manager/jobs/webhook.py
66.66% <66.66%> (ø)

runner_manager/models/settings.py
95.65% <100.00%> (-4.35%)
:arrow_down:

runner_manager/models/webhook.py
100.00% <100.00%> (ø)

runner_manager/routers/webhook.py
100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes


Optimized Julia calculation

Vectorization of Rust Calculations
Vec for dynamic arrays, statically typed variables for better memory and type management, and explicit lifetime and ownership rules.
Old: Each loop took on average 0.1748587581 seconds to calculate.
New: Each loop took on average 0.0789778815 seconds to calculate.

Vectorization of Julia Calculations
Implemented vectorized operations to generate and evaluate all points in one go
Efficient Timing Mechanism
Introduced Julia's built-in @timed macro, a more efficient way to measure execution time
Old: Each loop took on average 0.04459999999999999 seconds to calculate.
New: Each loop took on average 0.04069297313690186 seconds to calculate.

Thanks for your addition!


proposal: split org Propfile README to a new tab overview

like user profile, add a new overviw tab to show profile READEME when it is exist.
replace #31349 (another solution option)
example view:

Looks like Github's default page is repositories list.

Github renders:

Overview tab: Readme + Repos
Repos tab: Repos

I suggest we do the same, which should make everyone happy.

Looks like Github's default page is repositories list.

No, if I open https://github.com/go-gitea, it goes to the the overview tab.

Github renders:

Overview tab: Readme + Repos
Repos tab: Repos

I suggest we do the same, which should make everyone happy.

has add it https://github.com/go-gitea/gitea/pull/31373/commits/990584f9bd5734478f8e8de8bf9f8a66ae149864

This is not ideal because I think the members and team on the right sidebar of repository list can be removed since there is an overview tab. Of course, it can be finished by another PR.

This PR has been in reviewed/wait-merge status for long enough. I think it's time to merge.


Strange error when running a reaction back to a single component grouping

Version '2019.09.3'
I am just noting this strange behavior where the intramolecular reaction does not seem to be allowed when disconnecting a bond to an atom that is part of a separate double bond.
Example to reproduce
mol = Chem.MolFromSmiles('Cc1ccc(C(=O)/C=C/c2cnc3ccccc3n2)cc1')
rxn = AllChem.ReactionFromSmarts('[c:1][C:2](=[O])[C:3]>>([*:1][C:2]#[N].[*:3][Mg][Cl])')
p = rxn.RunReactants((Chem.AddHs(mol),))

gives
RuntimeError: Pre-condition Violation
	bgnIdx not connected to begin atom of bond
	Violation occurred on line 283 in file Code/GraphMol/Bond.cpp
	Failed Expression: getOwningMol().getBondBetweenAtoms(getBeginAtomIdx(), bgnIdx) != nullptr
	RDKIT: 2019.09.3
	BOOST: 1_67

Though removing the outer parentheses to give rxn = AllChem.ReactionFromSmarts('[c:1][C:2](=[O])[C:3]>>[*:1][C:2]#[N].[*:3][Mg][Cl]') makes the reaction work perfectly fine. I am somewhat confused by this and appreciate any help with the issue. Thanks!

Interesting, thanks. So the main difference seems to be the version?

Interesting, thanks. So the main difference seems to be the version?

You could try to run the code in the different version.

This does look like a bug, but it isn't with the components, it appears to be with chirality:
This fails:
mol = Chem.MolFromSmiles('C(=O)/C=C/C')
rxn = AllChem.ReactionFromSmarts('[C:2](=[O])[C:3]>>[C:2]#[N][*:3]')
rxn.RunReactants([mol])

This passes:
mol = Chem.MolFromSmiles('C(=O)C=CC')
rxn = AllChem.ReactionFromSmarts('[C:2](=[O])[C:3]>>[C:2]#[N][*:3]')
rxn.RunReactants([mol])

@greglandrum Chirality issues should get auto assigned to you :)


Uploading model  is ambiguous

We should improve the sentence to provide more details, such as Uploading model <model name> to podman machine. Not precising where it is upload the user could misunderstand what is really happening.
cc @slemeur @vrothberg any opinion ?

I would name it: "Copying model $model to Podman Machine."

I like it

Yep good suggestion


Reconcile ESLint and extension config.

Finished with commit https://github.com/daidodo/tsimportsorter/commit/8c537e5f2934fd9eec5058cc4cb2932f07aef4d4


Tobin free desc interface refactor

A Minor refactor to align FreeDescriptorSets() with desired architecture. Still needs some work to move the logic off into proper class(es).

:+1:

cherry-picked and pushed to master


fix: ozzo validation

OpenAPI required, nullable, min, max, minLength and maxLength influence how OZZO validation should be done.
This changes are in the direction described in the OpenAPI 3.0.3 clarification on how nullable property should work.
The following table summarize this PR interpretation of the spec on how it should be done using ozzo validations.

#
ozzo validation
type
required
nullable
min
max
minLength
format
pattern

1
Required
array
x

>0

2
Required
enum
x

3
Required
integer
x

>0

4
Required
integer
x

<0

5
Required
map
x

>0

6
Required
number
x

>0

7
Required
number
x

<0

8
Required
string
x

>0

9
Required
string
x

x

10
Required
string
x

x

11
NotNil
array
x

12
NotNil
map
x

13
NilOrNotEmpty
array

>0

14
NilOrNotEmpty
enum
x
x

15
NilOrNotEmpty
enum

x

16
NilOrNotEmpty
integer

x
>0

17
NilOrNotEmpty
integer

x

<0

18
NilOrNotEmpty
map

>0

19
NilOrNotEmpty
number

x
>0

20
NilOrNotEmpty
number

x

<0

21
NilOrNotEmpty
string

x

>0

22
NilOrNotEmpty
string
x
x

x

23
NilOrNotEmpty
string
x
x

x

How Has This Been Verified?
I run it against our live service code and also checked each generated test case.
Checklist:

[x] The change works as expected.
[ ] New code can be debugged via logs.
[ ] I have added tests to cover my changes.
[x] I have locally run the tests and all new and existing tests passed.
[ ] Requires updates to the documentation.
[ ] I have made the required changes to the documents.

The linter is failing with an internal error

level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: inspect: failed to load package : could not load export data: no export data for "slices"\n\n"

The linter is failing with an internal error

level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: inspect: failed to load package : could not load export data: no export data for "slices"\n\n"

This is fixed now

Please let me know what else is needed to get it accepted.
thanks!

@injeniero overall it looks good, but I need a bit more time to go through all of the changes and test it out locally, I am aiming that we have this merged no later than end of week

Thanks!!!


implement URLPattern

This implements URLPattern from scratch. I'm adding TODO: Optimization opportunity notes in places I think an optimization can be done. The goal is to merge this once there is no TODO: Implement this comments.
TODOs

[ ] Fix build errors
[ ] Implement WPT test runner
[ ] Fix TODO: Implement this occurrences (currently 4)
[ ] Finish the implementation for url_pattern::match

@anonrig Just to confirm... is this the spec? https://urlpattern.spec.whatwg.org

@anonrig Just to confirm... is this the spec? https://urlpattern.spec.whatwg.org

Yes that's correct @lemire

I don't particular mind, but please be aware that you are changing the coding convention. The C++ standard library uses all-lowercase with underscores names. You are using Camel case. If you merge this, it will mean that within the same library, we mix two conventions.

@jasnell @lemire would you mind taking a look? we're getting close to the finish line (although the test runner is missing).

Definitely on my todo!!!!

@anonrig Consider using the trick at the end of this blog post : https://lemire.me/blog/2024/12/16/accessing-the-attributes-of-a-struct-in-c-as-array-elements/

@lemire the last commit will not work with Node.js, and it fails to build
../../deps/ada/ada.cpp:16180:3: error: cannot use 'try' with exceptions disabled
 16180 |   try {
       |   ^
1 error generated.

@lemire the last commit will not work with Node.js, and it fails to build

I know.

@anonrig The last valid commit is https://github.com/ada-url/ada/pull/785/commits/41ec1705864758ed86d255c68a27a0c159cdd95c (5 days ago).
Everything afterward is badly broken in GCC (debug or with sanitizer).


Added eslint-plugin-flowtype-errors support, updated deps

Deps were update because eslint-plugin-flowtype-errors works with eslint 3+

ertrtr


NetCDF test for quantization and compression

NetCDF quantization, along with gzip compression provides an interesting approach to reducing the data output from models.
This is not currently implemented in XIOS. This issue aims to construct a small standalone test to demonstrate the functionality in NetCDF. The aim is to:

Write out the data without any processing
Write out the quantized data
Write out the quantized and compressed data

As there are three different quantization methods; bit grooming, granular bit round, and bit round, and I will explore all three.
https://docs.unidata.ucar.edu/netcdf-c/current/md__media_psf_Home_Desktop_netcdf_releases_v4_9_2_release_netcdf_c_docs_quantize.html#:~:text=The quantize algorithms assist with lossy compression by,built into netCDF-4%2C to better compress the data.

The example will be written in C, as this is more directly relevant to the C++ implementation in XIOS.


Critical Rendering Path - Udacity course gives 404

Page Affected:
https://developers.google.com/web/fundamentals/performance/critical-rendering-path/
What needs to be done?
The course mentioned on this page does no longer exist (or the url is wrong) on Udacity.
Please update the link if it's still on Udacity or remove the link if it is no longer available.

CC'ing author. @igrigorik

hmm. https://www.udacity.com/course/website-performance-optimization--ud884 does work on me. @kvdheuvel could you try going to the page again?

@myakura Sorry for the late reaction. Your link seems to work, thank you very much :-)


Go to definition does not go through shorthand properties

interface I {
    foo; // This is the only current result
}

function fun(): I {
    var foo; // This should also be a result
    return { foo };
}

fun().foo; // go to def on foo

The var should be shown as a definition.

I do not see why this is the case but not this:
interface I {
    foo;
}

class C {
   foo: string;
   bar: number;
}
function getI() : I {
    return new C();
}

var x: I = {foo : 0 };
var y = getI();

y.foo;
x.foo;

in both cases, the only thing we know about foo is it is the one from interface I. it is possible that they come from a different place, but that is a job for find all references.

It would certainly not be straightforward to fix, as it would require not just understanding that the function call returns an I, but diving into the return expression to figure out where that thing came from.


different models

Hi,
Thank you for this napari plugin! I was wondering if you could use different models using your platform. Is it possible to use different neural networks or to change their properties to allow for different setups?
Many thanks!
Pablo

@Pablo1990
We are currently working on enabling the modification of models and parameters from the GUI, but it is still in preparation. In terms of code, the models are defined respectively for training and inference at https://github.com/neurobiology-ut/PHILOW/blob/main/src/napari_philow/_trainer.py#L222C19-L222C31 and https://github.com/neurobiology-ut/PHILOW/blob/main/src/napari_philow/_prediction.py#L106C29-L106C29. You can use a different model by modifying these parts.


DataStoreException checkType should support kotlin vs java primitive types

The function throw error if you compare Kotlin Long (java.lang.Long) vs Java primitive long (long)

There haven't been any crashes due to this, so moving to "Code health".


关于vite项目命名规范BUG, 只要项目目录命名存在#号，开发和打包都报错

Describe the bug
关于vite项目命名规范BUG, 只要项目目录命名存在#号，开发和打包都报错

Reproduction
https://github.com/sunjianxu/vite-bug-report
Steps to reproduce
No response
System Info
window10

Used Package Manager
npm
Logs
.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

See https://github.com/vitejs/vite/issues/13123#issuecomment-1539708231


The app.config() is not being loaded

I'm having a problem, my app.config is not being called or loaded... I think that the var "app" is not ready,
I saw the Issue https://github.com/marcoslin/angularAMD/issues/123, but my configurations about RequireJs is different, follow some parts of my code:
Main.js
require.config({
    baseUrl: 'scripts/',
    paths: {
        'angular': '/bower_components/angular/angular',
        'angularAMD': '/bower_components/angularAMD/angularAMD.min',
        ...
    },
    shim: {
        'angularAMD': [ 'angular' ],
        ...
    },
    deps: ['app']
});

App.js
define(['common'], function (angularAMD) {
    'use strict';
    var app = angular.module('zuptApp', [........]);
    ...
    return angularAMD.bootstrap(app);
});

Config.js
define(['app'], function (app) {
    'use strict';

    app.config(function () {
        ...
    });
});

Looks like Config.js is a separate file for you.  Where is it being loaded?  You should really put the config in the app.js file until #123 is implemented.

My file Config.js is a dependency of the HomeController, this controller is the first controller called in my app. But, if I can not have app.config in separate file, there is no matter.
May I have my config in a separate file?

Sorry but I am having a hard time understanding why you need to have app.config in a different file.   Can you let me know what are you using this for and maybe I can think of an alternative?

In my case... Just to have each file with each responsibility.
But, there is no problem, I'll put my config in app.js
More one thing...
Just for curiosity: What's the restriction? Can I help you to fix it?
Tks for your time.

The restriction is really educating the user base that config must be ran before the bootstrap or often it is not going to work.   If you are dealing with package that can be configure after bootstrap, you can try to call angularAMD.config.

Yesterday, I had a situation. I putted the config in my app.js, but I'm using mocks for fakes data.
To config the mock, I have a file, with to many configurations, and the file is big.
To fix the problem, I created a new file to start my application: appMock.js, just for separate the things, and this file is called in main.js :
require.config({
    ...
    ...
    //start app
    deps: ['appMock']
});

I didn't like to do that, and its calling app.js yet. Its not calling the appMock.js
I don't know why.
I'll test the angularAMD.config .
Instead I receive the app parameter, I'll receive the AngularAMD?  Ex:
Currently Config.js
define(['app'], function(app) {
    ...
});

Changed Config.js
define(['angularAMD'], function(AngularAMD) {
    ...
});

Would be this?


Hangouts unable to text after receiving video

Describe the bug
Hangouts quits working after I receive a video message
My wife sent me a video, and Franz failed to load or render it, nor does it load any further messages. Furthermore, any attempts to reply simply return "Message not delivered". Logging into Hangouts via web browser shows several messages sent after the video (as well as the video), and none of the attempted messages to send.
Reloading hangouts or Franz does not fix it - the only way to resolve it is to log back out and back in.
To Reproduce
Steps to reproduce the behavior:

Go to Hangouts
While chatting with someone, have them send you a video message (a picture goes through fine)
It will fail to render, and you will be unable to reply and get the error "message not delivered"

However, if you send messages from another computer or web browser, they may show up.

Expected behavior
You should be able to receive videos and reply successfully
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. macOS, Windows 10 etc.] Mac OS X 10.15.2
Ferdi Version [e.g. 5.4.3] 5.4.3 (<IP_ADDRESS>4)

Server Used: [e.g. https://api.getferdi.com] https://api.getferdi.com

Additional context
I notice multiple 401 error codes in the console for https://hangoutsusermedia-pa.clients6.google.com which likely may be related.

same issue here
OS: Windows 10 Enterprise 1909 - 18363.752 build
Ferdi Version [e.g. 5.4.3] 5.4.4-beta.3
no server used.
It fixed itself after a couple of days, and removing and re-adding the hangouts service, but for some reason a couple of days had to pass
Probably for the conversations to pass?  And now the video is old in history and I it does not try to load it? If i scroll back up to the point of the conversation the video was sent, issue re-appears.

This is still happening for me as well (Mac), it comes and it goes, not sure what is going on here. I have done cmd + shift + R to clear things up and that sometimes (but usually doesnt) help. Note that I havent seen failures on hangouts.google.com which leads me to think it might be something ferdi related?

any update on this?

I think this happens to me, too. I couldn't verify it but could it be that loading the preview of the video fails and then corrupts the state of the site? I tried to debug it with the Service Inspector and when I open a chat with a YT link there is a 401 error trying to access some Google/Youtube URL.

I don't know how to debug this but I would bet it has something to do with security settings blocking some connections causing a corrupted state. Unfortunately I wasn't able to find out how these could be configured.

I just checked the console when this error happens and it tries to make this request:
https://hangoutsusermedia-pa.clients6.google.com/v1/usermediaservice/videoinformation?key=...&mediaItemId.legacyPhotoId.obfuscatedUserId=...&mediaItemId.legacyPhotoId.photoId=...&alt=json
Response is a 401:
code: 401
message: "Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project."
status: "UNAUTHENTICATED"

Cross-origin security settings sound like a possible culprit indeed.

Interestingly the videoinformation URL is not requested in the Firefox version of Hangouts, but only on Chrome. In Chrome proper, it returns with a 200. Comparing request headers, they appear to be largely identical, but Ferdi is missing the origin header:
origin: https://hangouts.google.com

Perhaps it would suffice to change Ferdi's user agent to Firefox?

I believe it pretends to be Firefox already but that's not sufficient. I suspect that instead of User Agent Sniffing, the app uses feature detection to do whatever it is doing there. Which is the preferred way to make such decisions but also means we cannot navigate our way around it with just user agent spoofing.

saw this issue yesterday on Ferdi <IP_ADDRESS>6

Is there maybe a way to disable link previews of all sorts?

I just tried the development version of Ferdi with the updated electron. Hangouts is working again, however there are new bugs like links don't open.

any progress on this issue?

Trust me, it's NOT stale. Ran into this issue just now. PLEASE do something to get around it, I won't be deleting convos every time someone sends a video link!

I suspect it  might not be a Ferdi issue so much as an Electron issue. Migrating Ferdie to a newer version of Electron might help -- but it might also involve a bunch of work that exceeds this bug's intended complexity :-/

I suspect it  might not be a Ferdi issue so much as an Electron issue. Migrating Ferdie to a newer version of Electron might help -- but it might also involve a bunch of work that exceeds this bug's intended complexity :-/

This is still a problem. I've switched from Franz to Ferdi and since this problem still seems to exist on both of them. On version 5.5.0 x64

I am having issues with hangout and in general with Gmails apps. Message on hangout LHS is Google Hangouts is not signed in. Please refresh the page to sign in. But I tried even restarting the machine and clearing cache. I signed out using incognito mode and the problem seems to be fixed.

@all: We are trying to unblock the nightly releases, but in the meantime, some of the issues reported above might have been fixed already in the development branch. For macos users, could I request you to please download the latest applications from this folder - and report if it fixes the issues.
Also, specific to services/recipes, there is some new self-help documentation that might also be needed to fix the issue(s).
As I have requested, once you try these, please report back on what issue is still outstanding. Thank you for your patience.

Sorry - this PR has now been merged into the main Ferdi repo: https://github.com/getferdi/ferdi/#troubleshooting-recipes-self-help

They have their Support packaged behind a wall at GitHub instead of having their own tech support. And this, even after we pay for a year subscription. Very disappointed with Ferdi.

I think you're mixing up Ferdi with Franz, which does have a paid subscription. In fact, Ferdi was created as a hard-fork of Franz to fix some if its issues, including the need for a paid subscription and giving your data to third parties. However, there are only a few (volunteer and entirely unpaid) people behind Ferdi for now, so fixing the issues may take a long time. Especially for stuff like Google services, where Google is actively working to block "unofficial" browsers.


Question about SQPOLL

With SQPOLL, a kernel will use separate thread polling for new SQEs. AFAIK the kernel may pick a new SQE at any time, so how does the kernel ensure a user has finished filling the SQE?
For example:
auto sqe = io_uring_get_sqe(&ring); // #1
io_ring_prep_nop(sqe); // #2
sqe->user_data = 123; // #3

#1 will update the SQ tail. So at this time, kernel will peek the new SQE at some time, before or after #2 and #3.
Am I correct? Does the kernel has some way to ensure the atomicity?

It isn't visible to the kernel until you do io_uring_submit().

Oh, I missed that.
Does it mean that a user should always do io_uring_submit right after filling a SQE for best performance, when using SQPOLL?

Using SQPOLL is no different than not using it, the application should basically be written in the same way. But if you don't do io_uring_submit(), the SQPOLL will never see it. The SQPOLL thread may also be currently sleeping, if the timeout has expired, and for that case you do need to enter the kernel to wake it up. io_uring_submit() takes care of that too.

Got it, thanks.


MSSQL transactions failing rollback

I'm using MSSQL as the dialect and testing the rollback functionality of a transaction by forcing a transaction to fail. When trx.rollback() is invoked, I'm consistently seeing:
Unhandled rejection TypeError: Cannot read property 'rollback' of null     at Transaction_MSSQL.rollback (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/knex/lib/dialects/mssql/transaction.js:49:20)     at Function.transactor.rollback (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/knex/lib/transaction.js:192:18)     at /Users/rod/Documents/GitHub/ripple-connect2/node_modules/knex/lib/transaction.js:47:22     at tryCatcher (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/util.js:26:23)     at Promise._settlePromiseFromHandler (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/promise.js:507:31)     at Promise._settlePromiseAt (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/promise.js:581:18)     at Promise._settlePromises (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/promise.js:697:14)     at Async._drainQueue (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/async.js:123:16)     at Async._drainQueues (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/async.js:133:10)     at Immediate.Async.drainQueues [as _onImmediate] (/Users/rod/Documents/GitHub/ripple-connect2/node_modules/bluebird/js/main/async.js:15:14)     at processImmediate [as _immediateCallback] (timers.js:383:17)
Has rollback functionality been tested with MSSQL?

There is a test. MSSQL is pretty new so there may be problems.

Interesting, trying to just remove trx.commit and trx.rollback at the end of my Promise chain within knex.transaction makes the benign error message go away, since commit() and rollback() in /node_modules/knex/lib/dialects/mssql/transaction.js are automatically invoked in a transaction :smile_cat:


Add composer and use brianlmoon/net_gearman instead of pear one

Because brianlmoon/net_gearman looks like more fresh code with support and some patches and issues solved.
https://github.com/brianlmoon/net_gearman

Please, review additions and merge.


add gitignore file

I accidentally discovered your project before and was very interested in it. I downloaded it today and plan to start reading the code. I found that your project did not have a gitignore file, and I ran all the test cases locally and found that some test data was left in the project. For this reason, I submitted this PR to fix these problems.
Please review it when you have time, Thanks in advance.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


There are shared utility functions no longer public

This makes AddEffectorInitializerAbstractProto public as a recent change
had made it private.  Alternatively we could have pushed the utility
functions to the implementation.

Can we do the same for the other new *Proto classes (if needed) and make any private or package-private functions protected (eg newEffectorBuilder).
Otherwise LGTM - good catch.


Add fast-uuid for UUID from String benchmarks

Benchmark                                    Mode  Cnt        Score        Error  Units
ValidUUIDFromString.m1_UUID_with_JDK        thrpt   15    92348.321 ±    617.624  ops/s
ValidUUIDFromString.m2_UUID_with_JUG        thrpt   15   460677.879 ±  42375.220  ops/s
ValidUUIDFromString.m2_UUID_with_fast_uuid  thrpt   15  1083386.234 ±   4874.232  ops/s
ValidUUIDFromString.m3_UUID_with_manual     thrpt   15  1023579.664 ± 139337.154  ops/s

Seems to be slightly faster/more consistent than Jackson's, at least on OpenJDK 8.
They also have an interesting method for writing UUIDs into Strings.

With Temurin JDK 17:
Benchmark                                    Mode  Cnt        Score       Error  Units
ValidUUIDFromString.m1_UUID_with_JDK        thrpt   15  1302911.592 ± 37181.621  ops/s
ValidUUIDFromString.m2_UUID_with_JUG        thrpt   15   646411.744 ± 29369.998  ops/s
ValidUUIDFromString.m2_UUID_with_fast_uuid  thrpt   15  1221578.985 ± 34914.212  ops/s
ValidUUIDFromString.m3_UUID_with_manual     thrpt   15  1359413.030 ± 13933.064  ops/s

Very interesting, both wrt fast-uuid and JDK 15+, thank you!

Would be interesting to measure UUID.toString() performance to alternatives too.

@cowtowncoder yes. There is a benchmark for that in their repo too (I submitted a PR there).
Btw, from Java 9 and onwards, UUID#toString performance is great. Same for Java 15 and onwards for UUID#fromString.
So much I submitted a PR to fast-uuid so it just uses UUID#fromString for 15

@andrebrait Interesting. Glad to see JDK improvements, some work to keep up with all of it :)

@cowtowncoder you can check their solution for that. Or just use their library, even.
My PR for them includes the code to just use JDK's UUID#fromString if the user happens to be running on >=15.

Right, I am specifically talking about detecting JVM etc.


Fix up WebXR

Fixes #1057
Fixes #582
Fixes #583
In addition to fixing the above and several related bugs, this also enables hotspots and annotations within WebXR if you flip the WebXR Incubations flag in Chrome Canary. We're still working through some bugs there, both here and in Chrome.
I've also refactored to simplify ARRenderer by using our pivot directly instead of an additional dolly and to remove the extra scene. You can verify that animation and shadows are fixed in WebXR, as I've added the button to our animation doc examples. Once WebXR is default, should we add the button to all our docs pages?

@cdata I refactored the hotspot control logic out of AnnotationMixin and into ModelScene. I also moved hotspot.ts from features to three-components. You're right, this is a better layout and addresses any casts and circular dependencies.

@cdata If you want to review this you're welcome to, but I plan to merge it tomorrow morning. Now that we have Karma and debugging is actually possible, I decided to dig into these flaky staging tests. There were some legit problems, which became more reproducible once I lowered the delay time. I believe I have removed the flakiness (and a couple files worth of code), and all without having to skip any tests!
This took awhile because I was getting used to our new debugging and testing process, but I'm quite happy now that I understand it better. Definitely a major improvement, so thanks for that!

do annotations work in AR? If you apple and android?
thank you

@christianpugger In our latest release, v0.10.0, annotations do work in AR, but only webxr mode and they require Chrome 83, which is currently Beta. You can try them out here on an ARCore-capable Android phone: https://modelviewer.dev/examples/annotations.html
There is not yet support for annotations in SceneViewer or QuickLook, and they are unlikely to support full HTML ever. WebXR is not supported on iOS for any browser.

@christianpugger In our latest release, v0.10.0, annotations do work in AR, but only webxr mode and they require Chrome 83, which is currently Beta. You can try them out here on an ARCore-capable Android phone: https://modelviewer.dev/examples/annotations.html
There is not yet support for annotations in SceneViewer or QuickLook, and they are unlikely to support full HTML ever. WebXR is not supported on iOS for any browser.

too bad, I wish I could use the AR annotations on my table.
But the same limit is for animations?

@christianpugger Yes, please bug Apple about supporting WebXR! Once they do, annotations will work in AR everywhere. I believe animations are supported in all of our AR platforms; do you have a model with animations that aren't working?

@christianpugger Yes, please bug Apple about supporting WebXR! Once they do, annotations will work in AR everywhere. I believe animations are supported in all of our AR platforms; do you have a model with animations that aren't working?

for a client I have to evaluate whether to use annotations or animations, so I was asking if and which worked in AR and not only in webxr


Add hover Button

Hover Button is Added
When you bringing their mouse it change the background color ,color and border

Thanks for the PR. The website looks dope. It has been merged.
I will be glad if you can leave a star on this repository.


Stopped all animation controllers after toggleable has been detached.

Description
Added stop animation controllers in detach.
Without it exception will be produced in case object is removed from the tree quicker than animation finished.

Closed as AUTHORS wasn't edited.

AUTHORS edited correctly.


Target package resolution error details are discarded

The details of any error encountered while attempting to resolve the target package are discarded here https://github.com/ethereum-ts/TypeChain/blob/19987e2/packages/typechain/src/utils/modules.ts#L12-L14.
Only a generic Perhaps you forgot to install @typechain/<target>? message is provided to the consumer no matter the error case (although the prompt to use the --show-stack-traces was a nice addition).

Some Background:
This manifests as a frustrating issue when using Yarn 2 PNP module resolution where require throws critical error messages detailing why resolution failed. In this specific case, typechain will fail to import @typechain/ethers-v5, and @typechain/ethers-v5 will fail to import lodash since neither declares a direct dependency on their imports.
A workaround to get PNP resolution working is to patch the dependencies in .yarnrn.yml packageExtensions - but one needs to modify, or step-through-debug the tryRequire source to discover which specific dependencies are causing the issue.
packageExtensions:
  typechain@*:
    peerDependencies:
      '@typechain/ethers-v5': '*'
  '@typechain/ethers-v5@*':
    dependencies:
      'lodash': '*'

Direct compatibility with PNP resolution can likely be achieved with optional peer dependencies - overall this would help ensure consumers are matching typechain with compatible target package versions.

Related: https://github.com/ethereum-ts/TypeChain/issues/240 (PNP support)


Version 7.0.2 of the binary ships with and/or creates expired root cert on first install.  Event log: "warn: The mitmproxy certificate authority has expired"

Problem Description
A clear and concise description of what the bug is.
The mitmproxy certificate authority ships with, or creates on first install, an expired root cert.
Steps to reproduce the behavior:

Download Version 7.0.2 of the binary.
Start mitmproxy.
Examine the Eventlog.

System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 7.0.2 binary
Python:    3.9.5
OpenSSL:   OpenSSL 1.1.1k  25 Mar 2021
Platform:  Linux-5.4.0-84-generic-x86_64-with-glibc2.31

Did you by any chance had mitmproxy installed on that machine before (maybe years ago)? Then there might still be an old CA lingering in ~/.mitmproxy. The warning should contain instructions on what to do.
https://github.com/mitmproxy/mitmproxy/blob/c90aaf55d96dc3f7722843b27fc9eb1034df3ac5/mitmproxy/addons/tlsconfig.py#L250-L256
Or does that happen on a clean machine?

You are absolutely right.  I so embarrassed!  Apologies for the distraction on this one....

No worries! :)


[Discussion] Move repo to own org?

Just wanted to get your feedback: we could move this repo to own "autocmake" org. The motivation would be that now coderefinery people don't really work on autocmake and vice versa. On the other hand the current solution might increase cross-visibility. A separate org could help building a community around cmake/autocmake development. It could also simplify holding autocmake-related repos (see also https://github.com/coderefinery/autocmake/issues/214).
Just wanted to bounce this idea off other people.

Yes, I am in favor of "autocmake.org". The "coderefinery" is common house for various projects and autocmake deserves own house.

Thanks for feedback! What I meant is github.com/autocmake as organization.

Are there branding/funding conflicts? Meaning, does it look bad to have Autocmake under CodeRefinery? If not, I'd prefer Autocmake to stay where it is now.

There is no branding/funding conflict.

Closing/postponing.


Alternative trie dependency?

This project depends on marisa-trie, which is a Cython/C++ extension module. The latest release from 2.5 years ago only has pre-built binaries for Python3.6 on macOS, and there are no releases with binaries for a newer version of Python than 3.6. This means users must build it from source, which requires them to have a compiler, the Python development headers, etc. installed. I created this issue but haven't gotten a response from the marisa-trie devs.
Would you be receptive to using a more active project, like datrie, or a pure-Python one like pygtrie?
I'm wary to distribute software that depends on langcodes because of the problems with the marisa-trie dependency.

First of all thank you so much this awesome library, you make working with languages as easy as it should be !!
I upvote this issue, in the past few weeks there were user having trouble with installing marisa-trie on macOS.
I did some benchmarking by using dict and using pygtrie (as recommended), in order to use those implentations I put the data in json dict format, I also compressed the whole data/trie folder using tar -xvzf, which compressed pretty well.
I only used example.py for benchmarking which is not enough to test everything.
But as a general thing not using marisa-trie is slower and heavier.
Below are my results and the some useful code to reproduce.

marisa-trie
python dict
pygtrie

example.py (s)
1.5
19.5
5.8

size of data/trie (Mo)
7.7
29.3
29.3

example.py gz (s)
-
20.2
6.3

size of trie.tar.gz (Mo)
-
4.9
4.9

# Convert Tries to json dicts
import marisa_trie, json
from glob import glob
for fp in glob('trie/*.marisa')+glob('trie/*/*.marisa'):
    trie = marisa_trie.BytesTrie()
    trie.load(fp)
    dd = {k: v.decode('utf-8') if type(v) is bytes else v for k, v in trie.items()}
    with open(fp.replace('marisa', 'json'), 'w', encoding='utf-8') as f:
        json.dump(dd, f)

# names.py
# Load pygtrie
def load_trie(filename):
    trie = pygtrie.CharTrie()
    with open(filename, encoding='utf-8') as f:
        for k, v in json.load(f).items():
            trie[k] = v
    return trie

# Load
def load_trie(filename):
    data_path = os.path.abspath(os.path.join(os.path.dirname(__file__), 'data'))
    filename = filename.replace(os.path.commonpath((data_path, filename)), '')
    filename = filename[1:] if filename[0] == os.sep else filename
    filename = os.path.join(*(filename.split(os.sep)[1:]))
    trie = pygtrie.CharTrie()
    with tarfile.open(os.path.join(data_path, 'trie.tar.gz'), 'r:gz', encoding='utf-8') as g:
        f = g.extractfile(filename)
        for k, v in json.load(f).items():
            trie[k] = v
    return trie

# marisa_trie.Trie.keys(lookup)
possible_keys = [k for k in trie if k.startswith(lookup)]  # dict
possible_keys = trie.keys(lookup)  # pygtrie
# marisa_trie.Trie.prefixes(lookup)
prefixes = [lookup[:i] for i in range(len(lookup)) if lookup[:i] in trie]  # both dict and pygtrie

Thanks for the comparisons, @ygorg! I wonder if speed is crucial for any users of this library, because I think a 4x slowdown, while not great, is an acceptable tradeoff to increase portability.
Also, I just want to add that when I looked into datrie, it seems that it doesn't have full support for unicode, which might be an issue here.

Due to the dependence on marisa-trie the package cannot be installed on Python 3.9 :(

@2press could you elaborate on why this happens ?

I tested his PR but couldn't build it either.

Most users installing with pip can't use the hack.

@ygorg I adapted the code you wrote above into the linked PR. Instead of tarring up the whole data/trie/ subdirectory, I gzip-compressed each json file. The performance was similar to what you reported above. Thanks again for sharing!

@rspeer sorry to poke, but do you have a minute to comment on this or the related PR #35? It's been sitting here a while and some projects (see above) have already moved on.

@goodmami - one of Robyn's coworkers here.  She's on a well-earned, much-deserved sabbatical for the last three months of the year; she might be checking in on things, but there's a good chance she hasn't been looking at work-related notifications at all, and won't get to it until she's back in January.  Just wanted to reassure you that she's not forgetting or ignoring it!

@Tahnan Got it. Thanks for the context!

marisa-trie-m can be used as a drop-in replacement on Python 3.9. People depending on langcodes can put this in their requirements.txt file for now:
marisa-trie-m
--install-option="--no-deps" langcodes

marisa-trie-m can be used as a drop-in replacement on Python 3.9. People depending on langcodes can put this in their requirements.txt file for now:
marisa-trie-m
--install-option="--no-deps" langcodes

I implemented #37 as a short-term fix, and released version 2.2. I'm going to look into #14 as a better medium-term fix.


Allow multiple modules in db

In this PR, we've added the ability to add multiple modules on the database.
Changes:
renamed module to modules
removed MaxItems attribute
Updated docs

@trentrosenbaum Could you please suggest if this PR will be merged ?


pkgr calling npm install without a HOME variable

I'm trying to build with something like this
export HOME=/home/ubuntu
pkgr package .

but I always get this error:
Error: node-gyp requires that the user's home directory is specified in either of the environmental variables HOME or USERPROFILE

Can you try with pkgr package . --env HOME=/home/ubuntu?

Closing. Please reopen if the command above didn't fix your issue.


Add remove and add functions

In this pull request:

I added Add and Remove functions.
I added README

Hi @Roland-Ntwali 😃,
As much as I appreciate your hard work on this project, I'm afraid that I can't perform a review on this pull request.
Invalid Submission

Please make sure that the Linters are passing in the PR

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready. 🙏
Cheers and Happy coding!👏👏👏
Feel free to mention @MahmoudBakr23 to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @Roland-Ntwali 👋 ,
INVALID REVIEW REQUEST
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

You have submitted a project, that does not have have Linters configured. Please configure Linters on your project and make sure that all checks are passing.
You have submitted a project, that is not documented correctly. Kindly document your project using the new README template, and make sure you add the correct steps to run the project, and also remember to fill all other relevant fields correctly.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Ecosystem instead of Explorer

What
Renaming all user visible labels of Explorer to Ecosystem.
Refactoring files, variables etc. with name explorer to ecosystem.
Why
Requested in https://github.com/7flash/flutter_seeds_wallet/issues/112

I still see a lot of "explorer" in /flutter_seeds_wallet/lib/generated/r.dart
... how is that file generated @7flash?

So each time when you add new pictures or change their names, you have to run this command:
dart ./lib/utils/asset_generator.dart

What it does, is updating pubspec.yaml and r.dart files filling with names of given pictures

Ahh... sorry missed this comment of yours 22 days ago.
I don't have the asset_generator.dart. Is that not committed?

How about the asset_generator.dart @7flash, did you forget to commit that?


panose check code is wrong

panose check code is wrong, eg if the value is 3 and it is not a monospace font, it should not be autofixed. The font in https://github.com/enathu/kavivanar reproduces this.

"panose check code is wrong, eg if the value is 3 and it is not a monospace font, it should not be autofixed."
I think that what you mean with your previous statement is something like this (I'm not sure why, though), is this right?
if name['OS/2'].panose.bProportion != PANOSE_PROPORTION_MODERN:
    assert_table_entry('OS/2', 'panose.bProportion', PANOSE_PROPORTION_ANY)

Please reopen the issue if the new implementation is still wrong.


Align the buttons in media module

Targets #{ISSUE_ID}

Description

Checklist:

[x] I have performed a self-review of my own code.

@Anjali48-hub Please also mention the ISSUE_ID in the Issue description.


[release-0.49] [Bug-fix]: Windows VM HyperV Reenlightenment enabled fails to migrate

What this PR does / why we need it:
Manual backport of this PR: https://github.com/kubevirt/kubevirt/pull/8201.
Release note:

[Bug-fix]: Windows VM with WSL2 guest fails to migrate

/cc @enp0s3
Can you PTAL?

/retest-required

/hold
I think this will make re-enlightenment VMIs not migratable when upgrading to the latest 0.49, @iholder101 can you confirm?

@iholder101 maybe we should add topology hints for existing VMIs as well so that we don't break live migration on upgrades, wdyt?

I think this will make re-enlightenment VMIs not migratable when upgrading to the latest 0.49, @iholder101 can you confirm?

That's correct.
More accurately, after upgrading to latest 0.49 such VMIs would be able to migrate only to nodes supporting the lowest tsc of the cluster.
I'll just note that even in current 0.49 although migrating such VMs is possible - it is dangerous and discouraged by QEMU. That's the reason they broke backward compatibility. So while it will limit the users, it would also protect him from bugs w.r.t. clock being consistent after migrations.

maybe we should add topology hints for existing VMIs as well so that we don't break live migration on upgrades, wdyt?

As we discussed offline, you're going to this logic in a separate PR. Great stuff :+1:

/hold

Let's keep this PR holded for a while to both let others have a chance to look and in order to wait for your follow-up PR to kick in.

@iholder101 this PR together with https://github.com/kubevirt/kubevirt/pull/9201 should fix the upgrade issue, PTAL.

/unhold

/retest-required

/hold
CI is continuously failing. taking a look.

@iholder101 Hi, I see that VMI name is test-vmi perhaps this name was re-used, which can lead to that

@iholder101 Hi, I see that VMI name is test-vmi perhaps this name was re-used, which can lead to that

Thanks @enp0s3!
Let's wait for your fix PR and merge this afterwards.

/test pull-kubevirt-e2e-k8s-1.22-sig-compute-migrations

/test pull-kubevirt-e2e-k8s-1.22-sig-compute-migrations

Hey @acardace!
The issues we see here are fixed in @enp0s3's PR: https://github.com/kubevirt/kubevirt/pull/9222.
I suggest to wait for it to merge then rerun the tests

https://github.com/kubevirt/kubevirt/pull/9222 is now merged.
/unhold
/retest

/lgtm

/test pull-kubevirt-e2e-k8s-1.23-operator-0.49


Travis, Docker and requirements updates

Bumped travis and docker to python 3.7
Reduced the kapitan docker image size by half
Updated cryptography and requests

LGTM


Update bug_report.yaml for 1.4.2

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

/azp run


Don't just show "Deploy completed" if an exception happened

It can be very misleading to have a "... stack complete." message at the end of a deploy when an exception happens during the deploy. There's no way to set the deploy_complete_message once a deploy has started so this change will set the message displayed at the end of a deploy to the message of an exception if an exception exists in state.
Ideally, there would be no informational panel if there is an exception and only the error pane would be displayed but that would require a lot more changes to make happen so this seems like a good compromise.

any chance on getting this one merged?

@mmercedes seeing how fast that last PR just got merged, is this just something you dont think you need?

Sorry for the delay on this! It LGTM


Realm icon

PR just for review.

Automated message from Dropbox CLA bot
@kkanahin, it looks like you've already signed the Dropbox CLA. Thanks!

I chatted with Steve and I think there's a reasonable case for calling these "realm_icons" rather than changing it to "realm_avatars", so let's plan on keeping the name.

I chatted with Steve and I think there's a reasonable case for calling these "realm_icons" rather than changing it to "realm_avatars", so let's plan on keeping the name.

ok, thanks

@timabbott I've done this issue and add tests. Could you please check it again.


Update Composer dependencies (2021-07-30-00-13)

Visual regression test passed!
View the visual regression test report


make View as User panel fieldless

Current

Changes

This looks like a great start..but the fields are unfortunately wrapping for me. We also have a little bit of overlap between this display and the display of the fields on the schedule publishing portion of the check in panel. I'm wondering if we can make this use  and also make it so that btn-default buttons that show in the .ccm-panel-dark() mixin are dark by default, and make sure that the times don't wrap like they do for me (they don't wrap in the schedule publishing panel.)
Finally, there's got to be something we can do about the iframe styling of the preview panel. I don't care for that drop shadow behind it – we don't use that anywhere else.


request for waybar-network interface priority and exclusion

I use Wi-Fi, four different ethernet interfaces, and VPN. Here are a few issues I've found:

When connected via WiFi and Ethernet, I would like to prioritize showing the Ethernet interface over WiFi without needing to display two network modules. Currently if I'm connected to WiFi when I plug in Ethernet, the network module does not change interface to Ethernet (even though traffic will be routed through Ethernet)
If I split network into network#enp and network#wlp with wildcard matching for the interface (enp* and wlp*), the wrong Ethernet interface is chosen. It should automatically select a connected one, not a disconnected one that is alphanumerically first.
If I try to use one network module and am on VPN, tun0 will be shown. I don't care about tun0 except for the fact that it exists. I can solve this by specifying interface but there is no way currently to exclude an interface which would be useful to exclude tun0 and create a new network#tun0 to display a lock if I'm on VPN.

I think this can be solved by either adding an interface priority configuration or changing how interfaces are chosen (always choose connected over disconnected) or preferably both.

I just noticed this as well when I switched to Hyprland on my laptop last night. I use NetworkManager which sets the priority of connections. I wonder if it would be easy enough to simply look at what device it has set as priority.

I have similar issues and was wondering how the interface is chosen.  I was expecting that the interface being used as the primary route should be displayed, and I found what seems like this approach in the code (or am I reading it wrong?).
As an example, I have wifi & ethernet both connected, and each has a default route, with the ethernet being the preferred default route (specifically a lower metric value).  In this situation the module is displaying the wifi interface, however I would expect the ethernet interface to be shown.
Here's the relevant parts of the routing table.
$ ip route | grep default
default via <IP_ADDRESS> dev enp6s0f4u2 proto dhcp src <IP_ADDRESS> metric 100
default via <IP_ADDRESS> dev wlp3s0 proto dhcp src <IP_ADDRESS> metric 600

$ ip -6 route | grep default
default via fe80::2211:33ff:fe11:ec2e dev enp6s0f4u2 proto ra metric 100 pref medium
default via fe80::2211:33ff:fe11:ec2e dev wlp3s0 proto ra metric 20600 pref medium

The behaviour seems deterministic - i.e. if I turn off wifi the module displays the ethernet interface, but when wifi is re-enabled it goes back to showing wifi.
So I'm wondering whether this is a bug - with regard to points 1 and 2, rather than a feature request?  The third point still stands though.


Cannot enter room on chrome for iOS

Describe the bug
cannot enter a session from chrome on ios.
To Reproduce
Steps to reproduce the behavior:

Deploy the last version(2.3.0)
Go to the deployed version of the app on ios device
See error: getUserMedia is not supported

Expected behavior
Enter the session
Screenshots

Environment (please complete the following information):

Browser: Chrome 80
App Version: 2.3.0

Additional context
i saw this supported browser list:
https://www.twilio.com/docs/video/javascript#supported-browsers
do we some workaround?

Thanks for the issue @moriadamri!
Unfortunately, this app doesn't work in Chrome on iOS and there are no workarounds. Chrome (and Firefox) on iOS do not have access to the needed WebRTC APIs. On iOS, Safari is the only browser that this app will work with.
I have created a ticket in our backlog to show a more informative error message when the browser is not supported. The error message you received is not very helpful, so we will be improving that experience.

It seems as though this may have changed in iOS 14.3. Does this open up possibility for support?
https://bugs.webkit.org/show_bug.cgi?id=208667

It's possible! I'm not sure if or when we will support iOS Chrome or Firefox, as these browsers would first need to pass our testing and validation. But we understand that these browsers are popular, and we would like to support them if it's possible. We're looking into it 🙂

@timmydoza do you have an issue we could track for the above support?

@timmydoza do you have an issue we could track for the above support?

@timmydoza hey just really hoping I could track that feature request somewhere, its a critical issue for us currently.


"select" and "enabled" options doesn't seem to work

Hi, first time that I try this lib, I used it with the two options that I use without any issues with react-query, "select" and "enabled".
But setting enabled to false, or setting a selected to change the returned data doesn't work, is it a known issue ? Is there a workaround ?

it's because react query parameters are the third parameter of the function. Please read the docs before jumping to coding :
http://www.zodios.org/docs/client/react#zodiosusequery

Sorry, there was no Typescript error so I havent noticed ! Gread job for the lib !


Support example for proper json MIME types

Currently only examples under application/json are supported.
However a proper json payload can be indicated by e.g. application/json;charset=utf-8, application/vnd.some.model+json.
Both examples provided confirm to MIME grammar (https://en.wikipedia.org/wiki/Media_type).
I thought simple improvement of a pattern could help. Like:
$..responses..content[?(@property.match(/[\/+]json/))].example.
However, it works only partially due to the how jsonpath-plus parser works internally - in short it uses ; as fragment separator.
So I could identify all examples with improved json-path but then identification of elements would not work.
Switching to json pointers could be a way forward.

I'm open to suggestions as long everything else works as well as before. I also rather stick to "works as designed" as to partial solutions. If you manage to find a solid holistic solution, I'm up for it 👍

I agree solving it partially is not a solution - will try to propose a holistic solution

Please take a look at the PR. I think I found a solution.
There is also a question of whether encode / decode example name methods are needed any longer. Please let me know what you think.


Series.iloc[ negative number ] can access memory it doesn't own or cause Segmentation Fault

In other words, there is no bounds checking for Series.iloc[] with a negative argument. It just accesses whatever is in the memory there. Also a security breach.
It does appear to check on write, just not on read.
Python 2.7.10 |Anaconda 2.1.0 (64-bit)| (default, May 28 2015, 17:02:03)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Anaconda is brought to you by Continuum Analytics.
Please check out: http://continuum.io/thanks and https://binstar.org

import pandas as pd
pd>>> pd.version
'0.16.2'
s = pd.Series([1,2,3])
s
0    1
1    2
2    3
dtype: int64
s.iloc[-2]
2
s.iloc[-4]
33
s.iloc[-12345]
0
s.iloc[-123123123123123]
Segmentation fault (core dumped)

looks like boundary checking is not happening correctly. pull-requests are welcome to fix.

A related issue: should s.iloc[-len(s)] raise an error?
For s = pd.Series([1,2,3]), writing s.iloc[[-3, -3]] results in an IndexError, although you'd expect the first row (index 0) to be returned twice - that's how it is for DataFrames and native Python iterables work.
So I think both _is_valid_integer and _is_valid_list_like  might need minor fixes here to be consistent, e.g. raising an error if key >= len(ax) or key < -len(ax).
I can submit a PR if noone else is working on this.

might be relevant. https://github.com/pydata/pandas/pull/6531 (though about slicing).
@ajcr yes, this prob is a simple fix, just needs some testing / logic. go for it.

closed by #10808