Refactor to facilitate amd modules.

This refractors the globals map in InternalCompiler to a map of modules containing methods. Also adds dependency tracking for module methods, so that when output to an AMD module it can load its dependencies.
The next step is to add outputting to an AMD module, but so far I have not been able to think of a way that does not require a pretty hefty refactor.

Hi Xavier:
Great work, thanks for that. I've made quite a refactoring myself lately so we need to be careful when merging the code. Your proposal seem very interesting and I'd like to have a look at the code and ask you about it later. Will this also be compatible for CommonJS/node modules?
Cheers!

That is exactly what I am thinking @alfonsogarciacaro. We should be able to make it compatible with CommonJS/node modules as well very easily.
The big issue is going to be supporting three different output types,

Global Variables
AMD Modules
Common JS Modules

Currently DefineGlobal returns a Var. I could not see an easy way of transforming that into a property call when it goes to print.  They seem to be heavily dependent on the scope, and theres not a way to transform the accessing of a Var to the accessing of a property on a module.

I think the trick is to wrap the generated code in a closure and change the parameters depending on the context. Have a look at the last lines of the Ractive.js library, but please give a couple of days to have a proper look at your code. In any case it's great to have people jumping in to improve FunScript! Welcome to the team!

I was originally thinking of an amd module per fsharp module, I see what you mean about the Ractive.js code though. Doing a single module per variable would make the implementation easier, and would allow for more optimizations using the require.js optimizer.
Glad to be a part of the team, this project is looking more awesome the more I dig into it.

The F# code that we're compiling:
module Foo

    let x() =
        "x"
    let y() =
        "y"
    let z() =
        x() + y()

My original intention was for it to be compiled to this:
define('Foo', [], function() {
    var fmodule = {
        x: function() {
            return "x";
        },
        y: function() {
            return "y";
        },
        z: function() {
            return fmodule.x() + fmodule.y();
        }
    }
    return fmodule;
});

However, this would be easier to implement, and more flexible:
define('Foo.x', [], function() {
    return function() {
        return "x";
    };
});
define('Foo.y', [], function() {
    return function() {
        return "y";
    };
});
define('Foo.z', ['Foo.x', 'Foo.y'], function(Foo_x, Foo_z) {
    return function() {
        return Foo_x() + Foo_z();
    };
});

Most of the changes having to do with type JSModule could be removed,and just keep the dependency tracking pieces.
So we could switch back to a simpler globals map, instead of a list of JSModule that contains a list of JSModuleMembers
type JSModule =
    { Dependencies: seq<JSModule>;
      Name: string;
      Var: Var;
      Assignment: List<JSStatement> }

let mutable globals = Map.empty<string, JSModule>

Mmm, I'm not sure it's a good idea to tight so much the generated code to a certain specification. Take into account that the code must be ready for a variety of scenarios: browser, node, Edge.js... The unit tests, for example, work by wrapping the code in a callback function and passing it to Edge.js (see here).
What I'm thinking at the moment is creating a namespace object and then use this object as needed depending on the context, something along these lines:
    var ns = {};
    ns['module1'] = {};
    ns['module1']['f1'] = function() { /* ... */ };
    ns['module1']['f2'] = function() { /* ... */ };
    ns['module2'] = {};
    ns['module2']['f1'] = function() { /* ... */ };

And then, if necessary, wrap it like this:
(function(global) {
    /* Previous code */

    // export as Common JS module...
    if ( typeof module !== "undefined" && module.exports ) {
	module.exports = ns;
    }

    // ... or as AMD module
    else if ( typeof define === "function" && define.amd ) {
	define( function() {
		return ns;
	} );
    }

    // ... or as browser global
    global.FunScript = ns;
}(typeof window !== 'undefined' ? window : global ) );

What do you think?

Ah, I was attacking it from the perspective of having different output methods availible at compile time, ie AMD, CommonJS, globals. A single unified output that works with all 3 would be much easier for the end user though.
The current Compile function could return JS like your first example, and then a CompileModules that compiles more like the second example.
It looks like in your second example you are including all of the generated JS in a single module. It was my goal for the modules to be separated as much as possible. The app I am going to start supplementing with FunScript has a very large client side code base, but most of the modules are not used on every request. I need for the generated modules to be as modular as possible. For instance, I need the following F# to be compiled into at least 2 modules:
module Foo
    let x() =
        "x"
module Bar
    let y() =
        "y"

What about making the api this:

Compile Same as the exisiting compile, outputs global variables.
CompileModule Would compile to a single module, with handling for CommonJS and AMD. Same as your example
CompileModules Would compile to seperate modules, with handling for CommonJS and AMD. Same as your example, just with more modules

Thanks for the clarifications, I'm getting your point better now. I would reduce your proposals to two main user cases:

FunScript is the last layer of the app and the user is not interested in making the code available to other clients. This is what the compiler assumes now, which allows several optimizations:

All the functions are made global (the generated code can be wrapped in a closure to prevent pollution of the global JS namespace) which should be more quickly accessible than a property in an object.
The function names can be compressed.
The code that is not being used won't be compiled to JS.

The user wants to create a "library" so the structure of the generated JS must reflect the that of the F# source as much as possible.

Functions (methods/properties/constructors) must be put in an object and have the same names as in F#.
All the user code must be compiled to JS.

It should be possible to make these two options available to the user when compiling. What I'm not sure yet about is generating one AMD module per F# one. If you want to prevent the loading of certain modules, they must be in separate files. Thus we must add this feature to the compiler or simply force the user create a project per module (a "project" can be a simple .fsx file).
Another thing we need to take into account is that, if users are going to use several independent modules, it may make sense to put all the FunScript.Core code (Array, List, String, Event...) in an independent library so the different modules can share it.

I agree with your spec, and I think ive already solved the issue of module separation.
I think it should be fairly easy to separate F# modules into separate AMD modules, this PR is already doing most of the work for that. There are two methods for defining 'globals' in my PR:

DefineGlobalExplicit (moduleName : string) (name : string)
Adds a property with the key of name to module moduleName
DefineGlobal (moduleType : Type) (name : string)
Calls DefineGlobalExplicit with moduleType.FullName and name.

Using the code in this PR, the following F# would be separated into multiple JSModules, but would still be output a single blob of JS.
module Foo
    let x() =
        "x"
module Bar
    let y() =
        "y"

Is translated into this data:
{ Name="Foo"
  Members: [
    { Name:"x"
      Var: ...;
      Statements: ... }]}
{ Name="Bar"
  Members: [
    { Name:"y"
      Var: ...;
      Statements: ... }]}

My PR is already doing the separation into different modules internal to FunScript, the only thing that remains is making it output to separate modules.

Just a question: if you need to develop your app in a modular fashion, why don't you keep the library modules in F# and later link them from your app code? There are several advantages in doing this: particularly because you'll only get the code you really need each time.
I assume you're writing both the library modules and the app code in F#. Or do you really need to call compiled F# from native JS? You still can do this setting explicitly the variables you want to export, but the more I think about it, the more difficulties I foresee in creating a "proper" JS library with FunScript, because the project wasn't designed with this in mind and there are many quirky ways wherein everything can fail.

@alfonsogarciacaro This is a really cool if very alpha project. As another outsider I would vote for proposal 2 above, if only because it makes sense for my use case too ;) (a small embedded library which needs to be called from JS). Keep up the good work.

Hi there! I'm working on a full new version, so this is a bit stopped right now. I'm not sure yet if it's a good idea to create a full library in JavaScript resembling the F# code, because the mechanisms for reference are very different: in F# this is automatic, in JS you usually need to pass an object containing the methods you need. Because of this, even if it's a bit more work, for users wanting to expose functionality to JS clients I think it's better to use a standard JS exporting functionality like module.exports.
In any case, I'm still trying to figure out the easiest way to interact with JS for the new version, so any idea is welcome!

@alfonsogarciacaro I understand and I would basically be happy with any module standard as long as I can export an interface per module (exposed methods/properties).
e.g. your own proposal from Mar 8th above:
var ns = {};
    ns['module1'] = {};
    ns['module1']['f1'] = function() { /* ... */ };
    ns['module1']['f2'] = function() { /* ... */ };

This seems totally logical to me instead of the current approach of just throwing everything into the global namespace with prefixed names as you do:
Utils__doc$ = (function(unitVar0)
{
    return (window.document);
});

I'm a total F# noob so not sure what's easiest but can you just the JS module pattern and F#'s access modifiers to control what gets bound to exports for a particular module, and what gets assigned to a local?
https://msdn.microsoft.com/en-us/library/dd233188.aspx
module Module1
  let internal myInternalObj = new MyInternalType()
  let publicAdd a b = a + b

Could compile to:
var Module1 = function() {
  var self = {};
  var myInternalObj = new MyInternalType();
  self.publicAdd = function(a,b) { return a + b; }
  return self;
};
//and then export for AMD/CommonJS etc
module.exports  = Module1;

This seems very sensible to me (your code is only missing the Module1 function calling itself). As an F# program may contain any number of modules I would mark one (and only one) with an attribute (like JSExport) so the compiler knows which one it should be exported.
I need to think a bit what to do with non-public properties because right now for simplicity the new version attach directly all properties to the type/module object no matter the access level in F#, and changing this would require changing a few other things.
If you want to have a peek at the new version you can have a look at the fnext branch of my fork. However, I got many new ideas after F# eXchange so there'll still be some big changes.
To see how the generated code with the new version looks like, have a look here. Please note that it's less than half of the code generated with the current version (here for comparison) and hopefully somewhat cleaner.
To read about the ideas behind the new version, check issue #171.
Cheers!
Alfonso

Thanks, that also answers my questions about the TS type providers not working for me (except the basic DOM types which work great). If you want someone to test once you're finished with the refactoring let me know. I'm checking out WebSharper too but this project is closer to what I want/need.


only check endpoints with repositoryId in it's data dictionary for pr…

…imary source endpoint.

fixes issue: https://github.com/Microsoft/vsts-agent/issues/737


Unmanaged API issue

From : https://github.com/flutter-tizen/flutter-tizen/issues/21
Investigate whether the APIs in the above issue can be removed.(or if necessary).
EGL

[ ] eglBindAPI
[ ] eglGetConfigs
[x] eglCreateContext
[x] eglMakeCurrent
[x] eglGetProcAddress
[x] eglCreateWindowSurface
[x] eglCreatePbufferSurface
[ ] eglGetDisplay
[x] eglChooseConfig
[ ] eglGetError
[x] eglInitialize
[ ] eglGetCurrentDisplay
[ ] eglSwapBuffers

ecore wayland

[ ] ecore_wl2_window_geometry_set
[x] ecore_wl2_window_new
[x] ecore_wl2_window_show
[x] ecore_wl2_window_free
[ ] ecore_wl2_sync
[ ] ecore_wl2_window_type_set
[ ] ecore_wl2_shutdown
[ ] ecore_wl2_display_connect
[x] ecore_wl2_egl_window_native_get
[x] ecore_wl2_egl_window_create
[x] ecore_wl2_egl_window_destroy
[x] ecore_wl2_window_position_set
[ ] ecore_wl2_init
[ ] ecore_wl2_display_get
[x] ecore_wl2_window_alpha_set
[ ] ecore_wl2_display_destroy
[x] ecore_wl2_window_id_get
[ ] ECORE_WL2_EVENT_WINDOW_VISIBILITY_CHANGE

tdm

[ ] tdm_client_create
[ ] tdm_client_vblank_set_enable_fake
[ ] tdm_client_vblank_wait
[ ] tdm_client_destroy
[ ] tdm_client_output_create_vblank
[ ] tdm_client_vblank_destroy
[ ] tdm_client_handle_events
[ ] tdm_client_get_output

tbm

[ ] tbm_surface_internal_unref
[ ] tbm_surface_internal_ref
[ ] tbm_surface_internal_is_valid

ecore_device_name_get
_ZTHN4dart8OSThread18current_vm_thread_E
ecore_device_class_get
ecore_device_subclass_get
__dlog_print

FYI, newer engines use some more APIs than listed in the original issue. My app which is based on the engine version 022b7c35642f8defb20517a3fa2874414983308c has received this review report: preCert_20210106024532.zip

FYI, newer engines use some more APIs than listed in the original issue. My app which is based on the engine version 022b7c35642f8defb20517a3fa2874414983308c has received this review report: preCert_20210106024532.zip

Thanks for the info.
This is a rough note for POC. If I can, I will make an other issue again and proceed.

Thanks for the info.
This is a rough note for POC. If I can, I will make an other issue again and proceed.


Masroor

Please resove this issue i have VS 2010 and appium server :<IP_ADDRESS> and selinum web driver: 2.48.0
Im faceing this below issue:
When my app launch on device on first activity my test case fails.
using System;
using System.Text;
using System.Collections.Generic;
using System.Linq;
using OpenQA.Selenium;
using OpenQA.Selenium.Appium;
using OpenQA.Selenium.Appium.Android;
using OpenQA.Selenium.Remote;
using Microsoft.VisualStudio.TestTools.UnitTesting;
namespace testappium2010
{
[TestClass]
public class UnitTest1
{
private AppiumDriver driver;
    [TestMethod]
    public void TestMethod1()
    {
        DesiredCapabilities capabilities = new DesiredCapabilities();
        capabilities.SetCapability("deviceName", "Nexus 5");
        capabilities.SetCapability("platformName", "Android");
        capabilities.SetCapability(CapabilityType.Platform, "Windows");
        capabilities.SetCapability("app", @"C:\Users\Administrator\Downloads\app-debug.apk");
        capabilities.SetCapability("device ID", "uniquedeviceid");
        capabilities.SetCapability("platformVersion", "5.0.1");
        capabilities.SetCapability("appPackage", "org.cprados.wificellmanager");
        capabilities.SetCapability("appActivity", "org.cprados.wificellmanager.auth.AuthActivity");

        driver = new AndroidDriver<AppiumWebElement>(new Uri("http://<IP_ADDRESS>:8082/wd/hub"), capabilities, TimeSpan.FromSeconds(180));

    }
}

}
Error message comes: Method not found: 'OpenQA.Selenium.Remote.CommandInfoRepository OpenQA.Selenium.Remote.CommandInfoRepository.get_Instance()'.
Appium server error:  info: [debug] Proxied response received with status 200: {"sessionId":"cb065201-a001-29e9-4061-bed77cc65155","status":0,"value":{"warnings":{},"desired":{"deviceName":"Nexus 5","platformName":"Android","platform":"Windows","app":"C:\Users\Administrator\Downloads\app-debug.apk","device ID":"uniquedeviceid","platformVersion":"5.0.1","appPackage":"org.cprados.wificellmanager","appActivity":"org.cprados.wificellmanager.auth.AuthActivity"},"deviceName":"Nexus 5","platformName":"android","platform":"android","app":"C:\Users\Administrator\Downloads\app-debug.apk","device ID":"uniquedeviceid","platformVersion":"21","appPackage":"org.cprados.wificellmanager","appActivity":"org.cprados.wificellmanager.auth.AuthActivity","takesScreenshot":true,"browserName":"selendroid","automationName":"selendroid","rotatable":true,"handlesAlerts":true,"javascriptEnabled":true,"networkConnectionEnabled":true,"version":"0.15.0","acceptSslCerts":true}}

info: <-- GET /wd/hub/session/cb065201-a001-29e9-4061-bed77cc65155 200 61.709 ms - 888

@gaditek
Hi. This issue is already reported.
#112
I think that there is a dependency conflict. By default the last stable version uses Selenium.WebDriver and Selenium.Support 2.47.0.
For now I advice to revert your Selenium.WebDriver dependency to 2.47.0.

I am trying to use Appium to test Selenium webdriver C# scripts on real iPad device.
Getting error that
Result StackTrace:
at OpenQA.Selenium.Remote.RemoteWebDriver.UnpackAndThrowOnError(Response errorResponse)
at OpenQA.Selenium.Remote.RemoteWebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
at OpenQA.Selenium.Remote.RemoteWebDriver.StartSession(ICapabilities desiredCapabilities)
at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(ICommandExecutor commandExecutor, ICapabilities desiredCapabilities)
at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(Uri remoteAddress, ICapabilities desiredCapabilities)
at UnitTestProject2.UnitTest1.TestMethod1() in C:\ED\TestAutomation\Ed.LMS\Main\UnitTestProject2\UnitTestProject2\UnitTest1.cs:line 29
Result Message:
Test method UnitTestProject2.UnitTest1.TestMethod1 threw exception:
System.InvalidOperationException: A new session could not be created. (Original error: ENOENT, stat '/Applications/Appium.app/Contents/Resources/node_modules/appium/build/SafariLauncher/SafariLauncher.zip') (33)
Tried looking for this folder on mac and found it doesn't exist there. Came across this post and tried running ./reset.sh but unable to run ./reset.sh  on mac. I already have safarilauncher installed on ipad.
Appium is under Applications and I looked into its content using Show package contents but no clue how to get to this folder contents from Terminal and how to run that command to have a SafariLauncher folder in Appium.../build.
Please help.
I have a valid development profile, provisioning profile on apple developer and my device is registered there too.
Please help.
Thanks in advance

@pshilpa1 - hey there, i don't see how your issue and the issue above relate (mind you, the issue above is also closed).  Please create a new issue and i'll be glad to chat there.

Created new issue 143.
Thanks

Hi All,
I am facing a issue.Have written a simple code to invoke appium server.But the error is thrown for setting URI.
Please help me someone,its urgent 👎
using System;
using System.IO;
using System.Threading;
using OpenQA.Selenium;
using OpenQA.Selenium.Appium;
using OpenQA.Selenium.Appium.Android;
using OpenQA.Selenium.Remote;
using OpenQA.Selenium.Appium.iOS;
using System.Diagnostics;
using OpenQA.Selenium.Appium.Service;
using NUnit.Framework;
namespace Test_Project
{
public class Program
{
//Create insatnce for appium
AppiumDriver driver;
    AppiumLocalService service = null;
    public AppiumDriver<IWebElement> getDriver()
    {
        return driver;
    }

    [SetUp]
    public void Initdriver()
    {

        String apkPath;
        DesiredCapabilities cap = new DesiredCapabilities();
        cap.SetCapability("deviceName", "Anum");
        cap.SetCapability("platformName", "Android");
        cap.SetCapability("udid", "emulator-5554");
        // apkPath = AppDomain.CurrentDomain.BaseDirectory.Replace("\\bin\\Debug", "") + "Apk/";
        cap.SetCapability("platformVersion", "8.1");
        cap.SetCapability("app", "@C:\\Users\\azargar\\source\\repos\\Store_Simple\\Store_Simple_Project\\Store_Simple_Project\\Apk\\mobile-prod-release-signed.apk" + "mobile-prod-release-signed.apk");
        cap.SetCapability("appPackage", "com.cineplex.storefront");
        cap.SetCapability("appActivity", "com.cineplex.store.android.main.MainActivity");
        //cap.SetCapability("fullReSet", true);
        cap.SetCapability("newCommandTimeout", 120);
        //  System.Uri uri = new System.Uri("http://<IP_ADDRESS>:4723/wd/hub");
        //System.Uri uri = new System.Uri(appiumURL);
        driver = new AndroidDriver<AndroidElement>(new Uri("http://<IP_ADDRESS>:4723/wd/hub"), cap);

    }

    [TearDown]
    public void AfterTest()
    {
        driver.Quit();
    }
}

}
Error is :-


Update artifact actions in GHA

https://github.com/stackrox/scanner/pull/1373 and https://github.com/stackrox/scanner/pull/1374 need to be in the same PR.

The CI test failutres are unrelated. :shipit:


acs-engine moved to journald from json-file for logs - how to forward to logger?

Is this a request for help?:
yes
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
hard to tell

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes v1.5.7
What happened:
As of fairly recently (at least currently the az acs create command line doesn't yet do it), end of March or so, acs-engine Kubernetes deployments were changed from using the json-file logging plugin to the journald Docker logging.
This means that we cannot use e.g. fluentd to tail the docker logs anymore, as the journald format is binary. Most "solutions" we have found on this topic have been very hacky or clunky at best, or they simply do not work.
Ultimately, we need to be able to ship our logs to Graylog (GELF format), which until now the fluentd agent did.
What you expected to happen:
Some guidance on how to make log shipping work, using other means than the oms-agent (which kinda works, actually!), which is not the desired log sink for us.
How to reproduce it (as minimally and precisely as possible):
See above, it's the standard configuration.
Anything else we need to know:
Are there plans on extending the documentation on how to ship logs using e.g. fluentd, or a similar shipper? To other targets than OMS, that is?

Possibly and probably related: https://github.com/kubernetes/kubernetes/issues/24677
This also does not really help: https://kubernetes.io/docs/concepts/cluster-administration/logging/
Maybe the same thing: https://github.com/Azure/acs-engine/issues/574

Somewhat related, as this could solve the issue: https://github.com/fluent/fluent-bit/issues/217

We are working with the OMS team to get the journal logs into fluentd in the default OMS settings. In the interm you can definitely use json-file. You might want to add a max log size so that you don't run out of hard drive space

Closed by #766


Allow setting container-runtime via env var for dapr init

Description
The container runtime used by dapr init reads potential value from DAPR_CONTAINER_RUNTIME env var.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1210
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@ThorstenHans Please resolve the conflicts.

👍🏼 done


windows: go.exe missing in download archive https://go.dev/dl/go1.17.5.windows-amd64.zip

What version of Go are you using (go version)?

note: I try to install go1.17.5 on a clean notebook where never go was installed before.

Does this issue reproduce with the latest release?
Yes
go1.17.4 windows zip does contain go.exe
What operating system and processor architecture are you using (go env)?
Windows 10 21H1 build 19043.1415
amd64
What did you do?
download https://go.dev/dl/go1.17.5.windows-amd64.zip
no go.exe in go1.17.5.windows-amd64\go\bin
download https://go.dev/dl/go1.17.5.windows-amd64.msi
installed
missing go.exe in c:\Program files\go\bin
What did you expect to see?
MSI install: c:\Program files\go\bin\go.exe
ZIP UNPACK: go1.17.5.windows-amd64\go\bin\go.exe
What did you see instead?
missing go.exe
NOTE: antivirus program was disabled to check if older issue go.exe detected as malware can be ruled out.
NOTE: Disable seems not to work. Download on Linux was fine and I could find go.exe in 1.17.5 zip package.

Is it possible that your AV software ate them?

Nope, had disabled both.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


[Question] How to access the methods in LocalPluginController?

Question
How to access the methods in LocalPluginController?
I am based on Shenyu version v2.5.1
For example, Get method:/plugin/findByName
Public class LocalPluginController{
/**
*Find by name mono

*@ param name the name
*@ return the mono
*/
@GetMapping ("/plugin/findByName")
Public MonofindByName (@ RequestParam ("name") final String name){
PluginData pluginData=BaseDataCache. getInstance(). obtainPluginData (name);
If (Objects. isnull (pluginData)){
Return Mono. just ("can't find this plugin:"+name);
}
Return Mono.just (JsonUtils. toJson (pluginData));
}
}
The order is as follows:

Start shenyu admin and shenyu bootstrap

Browser access

http://localhost:9195/shenyu/plugin/findByName?name=divide

It simply cannot enter the LocalPluginController method and was intercepted directly by AbstractShenyuPlugin, reporting the following error:

{
Code: -107,
Message ":" divide: Can't find selector, please check your configuration
}

pls config this ：
shenyu
  local:
    enabled: true


TrustProxies no longer valid after update to v3.7

Description
After updating to laravel-cloudflare v3.7 the laravel helper request()->isFromTrustedProxy() returns false, meaning any https URL requests get redirected to http, but because I'm enforcing https the project ends up in a 301 redirect loop.
Expected Behavior
I'm expecting the assigned full qualified URL of my resource (in this case a Page on the project website) to match the requested URL or request()->url().
Actual Behavior
Unfortunately the request()->url() returns a scheme of 'http' because the request()->isFromTrustedProxy() returns false.
Context
In my web.php route file I have the following code:
if (             $resource->uri !== '/' &&             $resource->url !== request()->url() &&             $resource->url !== request()->url() . '/'         ) return redirect($resource->url, 301);
This is designed for the requested resource to redirect to the assigned qualified URL - if the http request doesn't match. This includes redirecting the user if they have used a non-secure scheme to request the resource.
Possible Reason
It seems to be related to how it determines if the current requesting IP is in the Trusted Proxy array as received from Cloudflare. Because the environment 'REMOTE_ADDR' is now being set from 'Cf-Connecting-Ip' it is using the users IP address to determine if it is in the trusted Cloudflare array (which of course it couldn't be).
Your Environment
Laravel v9.21

You can turn off the new behavior by setting LARAVEL_CLOUDFLARE_REPLACE_IP=false in your .env file.
I am disappointed that this breaking change was made to the package in a minor version bump, and I hope that this will be corrected. My team spent many hours debugging why our signed URLs were failing to validate, and it was because we were generating them with https:// but this change was causing them to be validated with http:// - which failed, of course.

@Human018  @kohenkatz I'm sorry, I didn't expected to introduce a disruption, obviously. I will change the default of LARAVEL_CLOUDFLARE_REPLACE_IP to false, and find a better approach...

fixed by #288

@asbiin Thank you for the fix. I understand accidental breaking changes, I've done the same thing myself in the past.


releasing the content of a Lava Bucket into air crashes the game

Minecraft Version: 1.12.2
Forge Version: forge-1.12.2-<IP_ADDRESS>24.jar
Advanced Rocketry Version: AdvancedRocketry-1.12.2-1.3.0-59.jar
LibVulpes Version: LibVulpes-1.12.2-0.2.8-27-universal.jar
is this the latest curseforge build?
#Please Pastebin crash
Crash Report:
Explain issue in detail:
https://minecraft.curseforge.com/projects/forever-stranded-lost-souls/issues/186
releasing the content of a "Lava Bucket" crashes the game. testing showed that it happens if you point at an air block which has no solid blocks attached or in other words an air block enclosed with air

This was fixed in 1.12.2-1.3.0-60, with commit https://github.com/zmaster587/AdvancedRocketry/commit/b4fefb2da9903d1972a0297413bd25c79a91279e ;)
Duplicate of #1179 #1177 #1178


Correct server configuration docs for settings.workspace.library on sumneko lua server

Checking on the examples provided on https://github.com/sumneko/lua-language-server/wiki/Setting#different-clients-load-settingjson-in-different-ways , I noticed that settings.workspace.library must be a list, this particular thing was causing me some problems.

It is a list.
:lua print(vim.inspect(vim.api.nvim_get_runtime_file("", true)))
{ "/Users/michael/.config/nvim", "/Users/michael/.local/share/nvim/site", "/Users/michael/.local/share/nvim/site/pack/packer/start/gitsigns.nvim", "/Users/michael/.local/share/nvim/site/pa
ck/packer/start/indent-blankline.nvim", "/Users/michael/.local/share/nvim/site/pack/packer/start/lualine-lsp-progress", "/Users/michael/.local/share/nvim/site/pack/packer/start/lualine.nvi
m", "/Users/michael/.local/share/nvim/site/pack/packer/start/nvim-lspconfig", "/Users/michael/.local/share/nvim/site/pack/packer/start/nvim-luadev", "/Users/michael/.local/share/nvim/site/
pack/packer/start/nvim-treesitter", "/Users/michael/.local/share/nvim/site/pack/packer/start/nvim-treesitter-textobjects", "/Users/michael/.local/share/nvim/site/pack/packer/start/onedark.
vim", "/Users/michael/.local/share/nvim/site/pack/packer/start/orgmode.nvim", "/Users/michael/.local/share/nvim/site/pack/packer/start/packer.nvim", "/Users/michael/.local/share/nvim/site/
pack/packer/start/plenary.nvim", "/Users/michael/.local/share/nvim/site/pack/packer/start/telescope-fzf-native.nvim", "/Users/michael/.local/share/nvim/site/pack/packer/start/telescope.nvi
m", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-commentary", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-dirvish", "/Users/michael/.local/share/nvim/site/
pack/packer/start/vim-fugitive", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-gutentags", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-nix", "/Users/michael
/.local/share/nvim/site/pack/packer/start/vim-repeat", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-rhubarb", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-s
leuth", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-surround", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-tmux-navigator", "/Users/michael/.local/share/n
vim/site/pack/packer/start/vim-unimpaired", "/Users/michael/.local/share/nvim/site/pack/packer/start/vim-vinegar", "/Users/michael/.local/share/nvim/site/pack/packer/start/which-key.nvim",
 "/Users/michael/.local/share/nvim/site/pack/packer/start/zig.vim", "/Users/michael/.local/nvim/share/nvim/runtime", "/Users/michael/.local/nvim/share/nvim/runtime/pack/dist/opt/matchit",
"/Users/michael/.local/nvim/lib/nvim", "/Users/michael/.local/share/nvim/site/pack/packer/start/nvim-treesitter/after" }


Visual glitch in example29Tick

There is a tail here, that disappears when enabling "Show Dirty Rectangle":

There are actually many examples in RSAnimationExamples with similar issues (partially refreshing, not refreshing at all, do not displaying part of the content etc.):

example3Atom
example20CircleWaves
example21Lines
example22Lines
example23PerlnNoise
example26Bezier
example29Tick
example31RoundRectangles
example36Title
example39Duna

And in RSSVGAnimationExamples

example06AnimatedSVG

Hi, thank you very much for your feedback I fixed all examples.
For example39Duna I did not find any problem

Ah, the problem with example39Duna is that the RSExamplesBrowser default size is way too small for it, so you have to wait a long time to the visible part to react the tiny cutout :)


Better development logging

Now outputs the stack trace when not in production so reading error messages is much easier.
Closes #9

:+1:

:+1:


[Feature Request]: General purpose treasury plugin

Feature Request
Describe the Feature Request

For now, there is a TreasuryPlugin migrated from TreasuryWithdrawDaoProposal, it can only be used for token issuer to store pre-minted tokens.
There may have the need to provide a general purpose treasury  used for any user to store any token.
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

I think the general purpose treasury can use the DAO balance directly, it is more convenient than the Treasury.


Update cargo.toml for new release

Hoping to pull in updated piper with the licensing fixes, so we can include this in our repo.

What's needed to merge this?


Asset Color Expander: Building color set in ACE are ignored in TMPE CustomGetColor

Describe the problem
Hi Guys! I got back to work in Skylines and I found a incompatibility issue: The color was set in the Asset Color Expander mod is being ignore in a custom GetColor method implemented in TMPE. I pointed the code conflict below.
Steps to reproduce

Subscribe and activate the Asset Color Expander
Load a game
Go to  button, select the ACE tab and add a new rule
Type of rule filter = By Service
Allowed service =
Then go to second inner tab (Color settings) and change the coloring mode to Color List
Add a color in the list by clicking "+" button
It should change the color of all buildings of the city to that, but it have no effect

Log files
N/A
Extra appointments
I took a look in the TMPE code and found where possibly is the incompatibility source: at TMPE/TLM/TLM/Custom/AI/CustomBuildingAI
It's applying the code of the default BuildingAI behaviour, instead of call the original method. ACE uses a pre-method patch to apply the color selection: BuildingAIOverrides at ACE repo
If there's a reason for it and I need to change ACE code to add this support, let me know and I will apply it.
Thanks!

Like we've talk on discord, it won't be an issue once #1060 gets merged. I'll add this issue to autoclose on merge 😉

@krzychu124 is this fixed?

Weird, I thought I added this issue to autoclose after merge... (PR had closes keyword but didn't work 🤷♂ )

May you wrote them in list (ex: Closes #00A, #00B, #00C) instead of creating a entry to each?
(ex: Closes #00A; Closes #00B; Closes #00C)


⚠ Bofrost.nl has degraded performance

In 95dac9c, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1083 ms

Resolved: Bofrost.nl performance has improved in b9af4d0.


Did not find the .buildinfo file in debian/files

Hello.
I'm using your action to build testing packages for our project. Since yesterday, when 1.6.0 was released, action started failing at artifacts moving:
Did not find the .buildinfo file in debian/files at /github/action/scripts/move_artifacts line 35.
Example run: https://github.com/PurpleI2P/i2pd/actions/runs/4247105073/jobs/7384748674#step:3:1311
Workflow: https://github.com/PurpleI2P/i2pd/actions/runs/4247105073/workflow
Switching back to 1.5.0 fixes issue.
Any ideas? Thanks.

Hi @r4sas,
thanks for the report and sorry about the inconvenience.
From a quick look at my changes, I used an incorrect regex to find the name of the .buildinfo file. The name of your package as built from the workflow does contain a +, which this regex (wrongly) does not accept.
That's easily fixable, will do that tomorrow and release a new version.

FYI, same was when there was no + with previous version of workflow: https://github.com/PurpleI2P/i2pd/actions/runs/4246988979/workflow

FYI, same was when there was no + with previous version of workflow: https://github.com/PurpleI2P/i2pd/actions/runs/4246988979/workflow

You are right, the error affected any package name and version that contained anything besides a-z, 0-9 and _. The workflow you linked contained a - which unfortunately also made it fail.
Thanks again for the report. Its fixed now with version 1.6.1.
For reference: This was bug introduced with version 1.6.0 and 8f94178.

Thank you!

btw, example with before-build-hook is incorrect, because

git is not installs with devscripts
git would reject work with error fatal: detected dubious ownership in repository at '/github/workspace'

before-build-hook: debchange --controlmaint --local="+$(git describe --tags)" "CI build"


New module: s3-enc

This is a S3 bucket with server encryption enabled. And necessary IAM policy attached to provided IAM role.
Demoed in encrypted-s3 example.

name: Pull request template
about: Make a PR to terraform-aws-foundation
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's.  Including these will more likely lead
to your PR being reviewed and accepted.

[ ] Update the changelog
[ ] Make sure that modules and files are documented. This can be done inside the module and files.
[ ] Make sure that new modules directories contain a basic README.md file.
[ ] Make sure that the module is added to tests/main.tf
[ ] Make sure that the linting passes on CI.
[ ] Make sure that there is an up to date example for your code:
- For new modules this would entail example code for how to use the module or some explanation in the module readme.
- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
[ ] Make sure that there is a manual CI trigger that can test the deployment.

what about a bit better name? E.g. encrypted-s3-bucket?

@ketzacoatl The function of this module is used in TFE and Jenkins.


fix: add output for attachment id, profile name, and version

Description
Refer Issue - Issue-183
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Added scc_profile_attachment_id and scc_profile_info (profile name and version) to output.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

Output can be seen as below -

This is the output from one of the terraform-ibm-scc runs, where value of profile is a map and scc_profile_attachment_id is a separate value (refer image below)
@ocofaigh @akocbek - Should I add this as part of one single output like below or the current output is good to have?
scc_profile_info = [
  {
    "attachment_id" = "6c46eede-7f25-4514-8172-a722f6ae7e72/fe96bd4d-9b37-40f2-b39f-a62760e326a3/386f7fe8-6a64-4a84-97b2-ed8c7e5b07c6"
    "name" = "IBM Cloud Framework for Financial Services"
    "version" = "1.7.0"
  },
]

TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: Apply complete! Resources: 17 added, 0 changed, 0 destroyed.
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: Outputs:
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: cos_bucket = "scc-cb"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: cos_instance_id = "crn:v1:bluemix:public:cloud-object-storage:global:a/abac0df06b644a9cabc6e44f55b3880e:54842342-467e-4912-9d31-1adb8439b6ab::"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: crn = "crn:v1:bluemix:public:compliance:us-south:a/abac0df06b644a9cabc6e44f55b3880e:68acc585-2f1a-484f-83ae-999b6c7b94e4::"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: en_crn = "crn:v1:bluemix:public:event-notifications:us-south:a/abac0df06b644a9cabc6e44f55b3880e:ac4c0e32-5244-4a99-81cf-ccb8c5f79fc1::"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: guid = "68acc585-2f1a-484f-83ae-999b6c7b94e4"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: id = "crn:v1:bluemix:public:compliance:us-south:a/abac0df06b644a9cabc6e44f55b3880e:68acc585-2f1a-484f-83ae-999b6c7b94e4::"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: location = "us-south"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: name = "scc-existing-4ywsju-instance"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: plan = "security-compliance-center-standard-plan"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: profile = {
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "attachments_count" = 0
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "control_parents_count" = 0
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "controls_count" = 36
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "created_by" = "IBM Cloud"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "created_on" = "2023-12-06T03:37:10.000Z"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "hierarchy_enabled" = false
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "id" = "f54b4962-06c6-46bb-bb04-396d9fa9bd60"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "latest" = true
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "profile_description" = "Service Organization Control (SOC) reports are independent, third-party reports issued by assessors certified by the American Institute of Certified Public Accountants (AICPA) addressing the risk associated with an outsourced service. A SOC 2 report evaluates the internal controls that an organization has put in place to protect customer-owned data and provides details about the nature of those internal controls."
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "profile_name" = "SOC 2"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "profile_type" = "predefined"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "profile_version" = "1.0.0"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "updated_by" = "IBM Cloud"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "updated_on" = "2023-12-06T03:37:10.000Z"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66:   "version_group_label" = "9758fa5b-4177-4f88-9be5-e35ddc0f68e3"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: }
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: resource_group_id = "c5fc97561e834d5eb63e9f0184abc812"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: scc_profile_attachment_id = "68acc585-2f1a-484f-83ae-999b6c7b94e4/f54b4962-06c6-46bb-bb04-396d9fa9bd60/e28ffa94-652e-4683-ba0c-0e1dbf169123"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z logger.go:66: wp_crn = "crn:v1:bluemix:public:sysdig-secure:us-south:a/abac0df06b644a9cabc6e44f55b3880e:01c191f6-7b53-4d98-aeb6-0346110a57c7::"
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z tests.go:880: FINISHED: Init / Apply
TestRunExistingResourcesInstances 2024-09-10T10:25:18Z tests.go:834: START: Init / Plan / Show w/Struct

/run pipeline

@imprateeksh I think it would also really help if we included a sample of the output in a markdown doc, and had the variable description point to it. Similar to what we have in https://github.com/terraform-ibm-modules/terraform-ibm-kms-all-inclusive/blob/main/solutions/standard/DA-keys.md

/run pipeline

/run pipeline

:tada: This PR is included in version 1.20.0 :tada:
The release is available on:

GitHub release
v1.20.0

Your semantic-release bot :package::rocket:


OPNsense does not add l2tp device via Webui if configured

If you try to add a l2tp device via Interfaces -> Point to Point -> Devices -> Add, you can insert all the details needed and save it, the web ui shows a interface l2tp0 which should be correct.
After assigning the newly created interface and activating it, the logfile shows

opnsense: /interfaces.php: The command `/sbin/ifconfig -m 'l2tp0'' failed to execute ifconfig: interface l2tp0 does not exist

furthermore, if you open the advanced settings it opens an empty mask to create a new l2tp interface.
Versions | OPNsense 18.7.2-amd64FreeBSD 11.1-RELEASE-p13

There's an issue here indeed, but I'm unable to locate it at first glance.

Same issue with adding PPTP interface.

reclassified as cleanup since there wasn't an issue with operation, for details see 7fda167

reclassified as cleanup since there wasn't an issue with operation, for details see 7fda167


minor version bump after removing an impl while getting rid of compile warnings

removed custom from_str impl in favor of just implementing the FromStr trait

Coverage decreased (-0.2%) to 92.546% when pulling 6d61d286e2211a8999d08cc6695dd3d62470e949 on bump-to-v0.3.0 into 707ffd877921060040f5a402b7bff6a521bb65c8 on master.


Insert Keybind

Can I somehow change the insert keybind to any other key? Im getting a 60% keyboard with no insert key

It's possible to do that; I think that option is over there in the right tabs of the application.

Can I somehow change the insert keybind to any other key? Im getting a 60% keyboard with no insert key

You will have Insert Key, i own a 60% keyboard, just hold the "keyboard logo" or "function key" and click the key that has Insert under it (for me it's P)


Enable peer cert trust domain verification with SPIFFE

Please provide a description for what this PR is for.
This PR offers a function to choose the correct cert pool to verify the certificate of a peer corresponding to the peer's trust domain.
This is a follow up work of https://github.com/istio/istio/pull/24669.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ X ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@myidpt: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
303fccdabbeaabd22e4708a7ac3af60b7a1c1267
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-galley-k8s-tests_istio

integ-operator-controller-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-operator-controller-tests_istio

integ-multicluster-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cfdde0de6d4442e3bb8f219a61e99ace8990e8f8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


fix(templates): parse port mapping in "hostPort:containerPort" format (#2010)

See #2010

Related to #1958
I'll keep this open-right now but I'll probably implement it as a part of my work on https://github.com/portainer/portainer/issues/1800 (that will be available soon).

Closed in favor of #2017


Add proxy support for the editor

Follow-up of #47257.

Adds proxy support for HTTPRequest.
Adds network/http_proxy/{host,port} editor settings.

Labeled as "HTTP Proxy" and it's meant to be used for both HTTP and HTTPS requests. This is the same convention as seen in Android Studio's proxy settings.

Makes Asset Library and Export Template Manager setup proxy according to the editor settings.

The proxy has to be set manually in Editor Settings. It would be a separate PR trying to figure out default proxy from environment variables on different platforms 😜
Fixes #6100.

I can do a separate 3.x PR for these two proxy PRs after this one is merged. Adding the cherrypick: 3.x tag just as a reminder :smile:

The proxy has to be set manually in Editor Settings. It would be a separate PR trying to figure out default proxy from environment variables on different platforms stuck_out_tongue_winking_eye

On desktop platforms, I believe the HTTP_PROXY and HTTPS_PROXY environment variables are de facto standards nowadays.

Yeah, these environment variables are definitely the way to go. Meanwhile, on Windows and macOS, desktop applications tend to honor the system proxy settings which have to be queried via API.

This is a straighforward change after the proxy PR. Looks good, and thanks for working on this!

I'll let @Faless merge.

Thanks!

Authenticated proxy doesnt work.

Authenticated proxy doesnt work.

Please open a new issue for this, while detailing your proxy configuration (which authentication method does it use?).


Account Experienece should transfer the redirect_uri query parameter from Hydra to the login return_to query parameter

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] This issue affects my Ory Network project.
[X] I have joined the Ory Community Slack.
[X] I am signed up to the Ory Security Patch Newsletter.

Describe your problem
On a request to Hydra /oauth2/auth?redirect_uri=https://example.com endpoint the request redirects the browser to the login page of the Account Experience.
The Account Experience doesn't check for the redirect_uri query parameter which means the query parameter is ignored.
Describe your ideal solution
Add the ability to transfer the value of the redirect_uri query parameter in the Account Experience over to the return_to query parameter on the login page so that other flows, such as recovery and registration respects the return_to URL.
Workarounds or alternatives
None
Version
Latest
Additional Context
No response

What this means: We keep the OAuth2 flow only around when jumping between login and registration screen, but not when e.g. account recovery is used - there you would end up in the settings flow and not the OAuth2 page.

But I think after the settings flow was submitted, any return_to parameters passed along to the recovery flow will trigger.
So even if the UX is a bit strange, persisting the return_to here would still take the user back to the specified redirect_uri URL after updating their password.

So, I checked this out and essentially the redirect_uri doesn't just get passed along to the login / registration screen directly. Instead only the login_challenge is passed on which the UI could use to retrieve the OAuth2 request.
https://www.ory.sh/docs/reference/api#tag/oAuth2/operation/getOAuth2LoginRequest
In the Account Experience case this would then mean we would call Hydra when a challenge is present and override the return_to query parameter.
Does it make sense for us to handle in the Account Experience or should this rather be handled by Kratos?

if this can be handled on Kratos level, that sounds better to me - i don't see a reason why this should only work when using AX.

In all honesty, I don't think we need to handle anything here since the OAuth flow will do the following:
oauth2 client -> call /oauth/auth?redirect_uri=<something-url> -> redirects to /ui/login?login_challenge=<something> -> user signs in -> consent screen /ui/consent?login_challenge=<something>. -> accept / decline -> redirects to redirect_uri based on the login_challenge.
Any deviation of this to something like registration should follow the same flow.
The only exception here is the recovery flow since that will cause the user to end up at the /settings flow and in this case we would need to either store the login_challenge inside the flow and override the base URL / return_to from recovery flow to the redirect_uri.

For us to support this flow we would need to call the Hydra admin endpoint from the Account Experience on login and registration.
As a fallback we could use the client_uri if set for the return_to query parameter and any fallbacks, such as in the  OAuth2 logout deny flow.
~ ⟩ curl "https://<project-slug>.projects.oryapis.com/admin/oauth2/auth/requests/login?login_challenge=8b2d0165dcae40139d40cc43aea34ca4" -H "Authorization: Bearer ory_pat_XXXX" | jq

{
  "challenge": "8b2d0165dcae40139d40cc43aea34ca4",
  "requested_scope": [
    "openid",
    "offline_access"
  ],
  "requested_access_token_audience": [],
  "skip": false,
  "subject": "",
  "oidc_context": {},
  "client": {
    "client_id": "4b639d7c-bbe1-47f6-9968-852ef40359cc",
    "client_name": "",
    "redirect_uris": [
      "https://my-app.com/callback",
      "http://my-other-app.com/callback"
    ],
    "grant_types": [
      "authorization_code",
      "refresh_token"
    ],
    "response_types": [
      "code"
    ],
    "scope": "openid offline_access",
    "audience": [],
    "owner": "",
    "policy_uri": "",
    "allowed_cors_origins": [],
    "tos_uri": "",
    "client_uri": "",
    "logo_uri": "",
    "contacts": [],
    "client_secret_expires_at": 0,
    "subject_type": "public",
    "jwks": {},
    "token_endpoint_auth_method": "client_secret_post",
    "request_object_signing_alg": "RS256",
    "userinfo_signed_response_alg": "none",
    "created_at": "2023-03-23T08:06:33Z",
    "updated_at": "2023-03-23T08:06:33.075098Z",
    "metadata": {},
    "skip_consent": false,
    "authorization_code_grant_access_token_lifespan": null,
    "authorization_code_grant_id_token_lifespan": null,
    "authorization_code_grant_refresh_token_lifespan": null,
    "client_credentials_grant_access_token_lifespan": null,
    "implicit_grant_access_token_lifespan": null,
    "implicit_grant_id_token_lifespan": null,
    "jwt_bearer_grant_access_token_lifespan": null,
    "refresh_token_grant_id_token_lifespan": null,
    "refresh_token_grant_access_token_lifespan": null,
    "refresh_token_grant_refresh_token_lifespan": null
  },
  "request_url": "https://<project-slug>.projects.oryapis.com/oauth2/auth?response_type=code&client_id=4b639d7c-bbe1-47f6-9968-852ef40359cc&redirect_uri=https://my-app.com/callback&scope=openid%20offline_access&state=31412352365346",
  "session_id": "893bb501-ca0d-4644-b644-58d85e9befc6"
}

For basic login and registration, the user will already be taken back to the client, where the client could handle the redirect_uri URL. But since the goal is to have recovery flows eventually redirect the customer back to the redirect_uri this will require extensive testing, since the requirement involves multiple flows chained.
For example:

User initiates the OAuth2 login flow
Redirects to Account Experience login page
User wants to recover account -> recovery flow
User successfully recovers account -> settings flow
User successfully updates credential -> redirected to redirect_uri without accepting the login request.

In Kratos we only accept the login request in three places:

Login Submit
Login Create with session
Registration Submit

When accepting the request we redirect the user based on the response from Hydra https://github.com/ory/kratos/blob/master/hydra/hydra.go#L105-L126
This means that the user will need to re-initiate the OAuth2 login flow which will immediately accept the login request because the user has a session (due to recovery flow) -> Login Create with session.

To be clear on the desired outcome:
When I need to verify my address or recover my account during login, i want to proceed to the original application after competing the step.
i.e., once I complete the verification or settings (via recovery) flow, I want a button "Proceed to app" or an automatic redirect (app should decide), which takes me to the redirect_uri of the initial login request.
So what i'm wondering about:

do the "chained" flows pass on the return_to URL appropriately to follow-up flows already?
If so, would appending the return_to to the login flow do the job?
am i correct that return_to in this case would not be the final app URL, but to the next step in the OAuth2 login process (consent)?

I think it would be better to return the user to the original /oauth2/auth endpoint (so "request_url": "https://<project-slug>.projects.oryapis.com/oauth2/auth?response_type=code&client_id=4b639d7c-bbe1-47f6-9968-852ef40359cc&redirect_uri=https://my-app.com/callback&scope=openid%20offline_access&state=31412352365346",) when updating the credentials succeeded.

am i correct that return_to in this case would not be the final app URL, but to the next step in the OAuth2 login process (consent)?

No, not if we use the redirect_uri parameter from the OAuth flow.
Essentially if we return the user back to the original request (like @aeneasr mentions), then it might work and the flow will continue normally. But This is also not guaranteed, since AFAIK the login request and consent request have a lifespan which expires. So if this is too short and the recovery flow took longer than expected, the flow will fail with an error. Worst case scenario is the user need to restart the OAuth flow from the client.

The other question is, what should happen when the user fails to recover the account? Should the "back" button on the Account Experience take them back to the client_uri (if set)? or the redirect_uri? or request_url to restart the login flow?

As Aeneas suggests to take the user back to the initial login flow on the OAuth2 side, I think that'd be okay for the failure scenario too. From there, they can start again, log in as someone else, or sign up afresh.

Alright, should I prioritize this for implementation?


Synchronized with the origin

Synchronized with the origin
Occasionally PR all modifications in the origin repository

Done the repository is in sync with the origin.


Submit Workflow: Save 'ur URL

Preflight

[X] The Alfred team has invited me to submit this workflow.

The submitted workflow:

[X] Was authored by me. ⓘ
[X] Uses Workflow Configuration or has no user-facing settings. ⓘ
[X] Does not have an auto-updater. ⓘ
[X] Does not contain unsigned and non-notarised binaries. ⓘ
[X] Does not download extra software. ⓘ
[X] Uses keywords with more than one character. ⓘ
[X] Has a descriptive About section. ⓘ
[X] Has an icon of at least 256x256 px. ⓘ

Homepage
https://github.com/Stephen-Lon/Alfred-workflow-save-ur-url
Alfred Forum page
https://www.alfredforum.com/topic/20802-save-ur-url/
Gallery page content
Save, view, edit and search URLs in a single plain text or markdown file
This workflow requires Alfred 5.5.
Usage
Save
Save a selected URL from your browser or in Clipboard History with the Universal Action.

Optionally provide a title (or accept that offered) when using a plain text Links file.

You must provide a title if using a markdown Links file.

View and clear
View saved links in Alfred’s Text View, or clear all links, with the links keyword.

⏎ View Links file
⌘⏎ Send Links file to Trash and create new empty Links file
View using the configuration option to save in plain text:

View using the configuration option to save in markdown:

⌘⏎ Edit the links file (in either case)
Editing a plain text Links file opens the file  in Alfred’s Text View and editing a markdown Links file opens the file in your default markdown editor.
Search
Search the URL names in the Links file with the keyword flinks.

Select any link to open it in your browser.
Tags
URL, browser, links
Test data
No response
Homebrew dependencies
No response
Bundled libraries
No response

Thank you. Will be live soon.
One thing I noticed, not about the submission but the workflow itself, is that there is a Keyword to delete the links file (right at the bottom: {var:deleteLinksFile}) but there’s no configuration for that keyword. I’m guessing you may have forgotten to remove it when adding ⌘↩ to links?


Test are falling in Apple M1 Pro (arm64)

Not sure what is provoking this, but I have seen test fail before due to the chip architecture.
➜  /tmp git clone git@github.com:cshum/imagor.git
Cloning into 'imagor'...
remote: Enumerating objects: 8381, done.
remote: Counting objects: 100% (118/118), done.
remote: Compressing objects: 100% (79/79), done.
remote: Total 8381 (delta 45), reused 82 (delta 31), pack-reused 8263
Receiving objects: 100% (8381/8381), 6.30 MiB | 5.78 MiB/s, done.

[...]
--- FAIL: TestProcessor (11.27s)
    --- FAIL: TestProcessor/vips_basic (0.30s)
        --- FAIL: TestProcessor/vips_basic/webp (0.02s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_basic/webp
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_basic/export_webp (0.02s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_basic/export_webp
                	Messages:   	image mismatch
    --- FAIL: TestProcessor/vips_operations (10.43s)
        --- FAIL: TestProcessor/vips_operations/rotate_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/rotate_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/focal_point_animated (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/focal_point_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_center_animated (0.05s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_center_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_top_animated (0.05s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_top_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_top_animated#01 (0.05s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_top_animated#01
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_bottom_animated (0.05s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_bottom_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_bottom_animated#01 (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_bottom_animated#01
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_left_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_left_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_left_animated#01 (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_left_animated#01
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_right_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_right_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_right_animated#01 (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_right_animated#01
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/stretch_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/stretch_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/resize_padding_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/resize_padding_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_animated (0.06s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_animated_align_bottom_right (0.06s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_animated_align_bottom_right
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_double_animated (0.08s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_double_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_double_animated_2 (0.10s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_double_animated_2
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/padding_with_watermark_double_animated (0.10s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/padding_with_watermark_double_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_frames_animated (0.48s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_frames_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_frames_animated_repeated (0.50s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_frames_animated_repeated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/watermark_repeated_animated (0.05s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/watermark_repeated_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label (0.08s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_top_left (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_top_left
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_right_center (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_right_center
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_center_bottom (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_center_bottom
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_negative (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_negative
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_percentage (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_percentage
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_float (0.01s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_float
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/label_animated_with_font (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/label_animated_with_font
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/vips_operations/svg (0.10s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/vips_operations/svg
                	Messages:   	image mismatch
    --- FAIL: TestProcessor/max_frames (0.15s)
        --- FAIL: TestProcessor/max_frames/resize_top_animated (0.04s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/max_frames/resize_top_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/max_frames/watermark_repeated_animated (0.06s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/max_frames/watermark_repeated_animated
                	Messages:   	image mismatch
    --- FAIL: TestProcessor/max_frames_limited (0.09s)
        --- FAIL: TestProcessor/max_frames_limited/resize_top_animated (0.02s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/max_frames_limited/resize_top_animated
                	Messages:   	image mismatch
        --- FAIL: TestProcessor/max_frames_limited/watermark_repeated_animated (0.03s)
            processor_test.go:417:
                	Error Trace:	/tmp/imagor/vips/processor_test.go:417
                	Error:      	Should be true
                	Test:       	TestProcessor/max_frames_limited/watermark_repeated_animated
                	Messages:   	image mismatch
FAIL
FAIL	github.com/cshum/imagor/vips	11.577s
ok  	github.com/cshum/imagor/vips/pointer	0.202s
FAIL

I also attach the whole terminal output without the redacted [...].
Happy to try to help, I'm starting to play with this project and I couldn't see what is wrong in debug mode. I have the feeling it is related to webp, but it is just a hunch.
log.txt

This is because the tests resulting image pixels varies under different versions of libvips or the corresponding shared libraries libjpeg-turbo, libspng, cgif, libwebp etc. Even varies under different processors architecture.
The current suite tests against only one version that works across github workflow & amd64 docker environment, and would be re-generated when any versions changed.
It may be possible to generate golden test images against every version matrix. But given by the huge variance of libvips and shared library versions, the matrix would be really huge and the test data would become too cumbersome to maintain.

That makes sense. Servers running arm are still rare enough but the new macs are getting more common around the development world. I'm closing this issue now but I hope I can open a PR at some point to ease development in arm chips without having to change much from master nor adding tons of new goldens. Thanks!


"Error: api.err.Invalid" after controller update to 5.12.66

Describe the bug
After updating my controller to 5.12.66 my adapter is failing to connect or receive any data..
Log
unifi.0 | 2020-05-14 11:12:25.508 | error | (9185) Error: api.err.Invalid
unifi.0 | 2020-05-14 11:12:23.729 | info | (9185) Unifi adapter is ready
unifi.0 | 2020-05-14 11:12:23.704 | info | (9185) starting. Version 0.4.3 in
Versions:

Adapter version: 0.4.3
JS-Controller version: 2.2.9
Node version: v10.20.1
Operating system: linux (docker container)

My controller is running with 5.12.66 and the adapter is working without any problem. Please check your username and password.

You are right. I indeed had a user/password issue. Wonder how that happend...
Sorry to bother you and thanks for your quick reply!


select()'s first argument should be zero, if no file descriptors are selected

The most portable invocation for the zero-fds case, a widely used
portable hack for sleeping, generally involves passing NULL arguments
when the fd sets are unused. This form is used here.

Looks good but went ahead and deployed on a test node for a bit (15 minutes)


noetic

includes #150

requires

[ ] rosdep python-numpy for focal https://github.com/ros/rosdistro/pull/26767
[ ] rosdep python-progressbar for focal https://github.com/ros/rosdistro/pull/26768

use #169 instead

use #169 instead


IngressRoute with string port in TCPProxy results in an error

What steps did you take and what happened:
Created the following IngressRoute:
apiVersion: contour.heptio.com/v1beta1
kind: IngressRoute
metadata:
  name: example
  namespace: default
spec:
  tcpproxy:
    services:
    - name: tcpservice
      port: http
  virtualhost:
    fqdn: tcp.example.com
    tls:
      passthrough: true

Service definition:
apiVersion: v1
kind: Service
metadata:
  labels:
    app: tcpservice
  name: tcpservice
  namespace: default
spec:
  ports:
  - name: http
    port: 8080
    protocol: TCP
    targetPort: 8080
  selector:
    app: tcpservice
  sessionAffinity: None
  type: ClusterIP

Contour starts logging the following error message every second:
E0815 14:26:44.094569       1 reflector.go:126] pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/cache/reflector.go:94: Failed to list *v1beta1.IngressRoute: v1beta1.IngressRouteList.Items: []v1beta1.IngressRoute: v1beta1.IngressRoute.Spec: v1beta1.IngressRouteSpec.TCPProxy: v1beta1.TCPProxy.Services: []v1beta1.Service: v1beta1.Service.Port: readUint64: unexpected character: �, error found in #10 byte of ...|","port":"http"}]},"|..., bigger context ...|pproxy":{"services":[{"name":"tcpservice","port":"http"}]},"virtualhost":{"fqdn":"tcp.example.com","|...
E0815 14:26:45.097479       1 reflector.go:126] pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/cache/reflector.go:94: Failed to list *v1beta1.IngressRoute: v1beta1.IngressRouteList.Items: []v1beta1.IngressRoute: v1beta1.IngressRoute.Spec: v1beta1.IngressRouteSpec.TCPProxy: v1beta1.TCPProxy.Services: []v1beta1.Service: v1beta1.Service.Port: readUint64: unexpected character: �, error found in #10 byte of ...|","port":"http"}]},"|..., bigger context ...|pproxy":{"services":[{"name":"tcpservice","port":"http"}]},"virtualhost":{"fqdn":"tcp.example.com","|...
E0815 14:26:46.102231       1 reflector.go:126] pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/cache/reflector.go:94: Failed to list *v1beta1.IngressRoute: v1beta1.IngressRouteList.Items: []v1beta1.IngressRoute: v1beta1.IngressRoute.Spec: v1beta1.IngressRouteSpec.TCPProxy: v1beta1.TCPProxy.Services: []v1beta1.Service: v1beta1.Service.Port: readUint64: unexpected character: �, error found in #10 byte of ...|","port":"http"}]},"|..., bigger context ...|pproxy":{"services":[{"name":"tcpservice","port":"http"}]},"virtualhost":{"fqdn":"tcp.example.com","|...

What did you expect to happen:
I expected the tcpproxy to go to the port named http in my service.
Anything else you would like to add:
The error causes Contour to stop processing other ingressroutes.
Environment:

Contour version: Image:      gcr.io/heptio-images/contour:v0.14.2
Kubernetes version: (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-26T00:04:52Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-25T23:41:27Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}

IngressRoute has always defined the ports to use integers unlike Ingress spec (https://github.com/heptio/contour/blob/master//apis/contour/v1beta1/ingressroute.go#L91-L92).
We can take this into account for IngressRoute/v1 design, but right now, it's not possible to route to service and define a service port name instead of the int value.

Got it! In that case, I think we should add OpenAPI validation so that an invalid IngressRoute is rejected upfront. In the current state, a user can take down the contour control plane with that invalid IngressRoute.

Yup I agree :100:


idea: check logging level auditing

will be none / failed / successful / both
guess should warn if none

Totally agree....
EXEC xp_instance_regread N'HKEY_LOCAL_MACHINE', N'Software\Microsoft\MSSQLServer\MSSQLServer', N'AuditLevel'
Will show current audit level 1 = none, 2 = failed logins only so value must be above 1

added in with alerts for none or successful only.


fix: hide hidden fields and consider them not required for validation purposes

Fixes https://github.com/syndesisio/syndesis/issues/5566
Fixes https://github.com/syndesisio/syndesis/issues/5572
Fixes https://github.com/syndesisio/syndesis/issues/5559

PR Storybook available here


Testing page for the App framework

Summary
Describing how to use e2e tests when making changes to the app framework.

Ticket Link

sorry, I'm missing something, I need to update the docs, I'll let you know when it's ready, @mickmister if you know how to run this tests better let me know, thank you!

Really great PR @javaguirre! If I understand correctly, you need more time to finish the content, so feel free to ping me for a later review. I went ahead and reorganized your starting structure for clarity, based on my own experiences copyediting this style of tutorial. I hope those edits will help you build a strong resource for the docs. Feel free to change however is best for you! 💪

You're super helpful @azigler ! I'll do that, thank you for the changes!

Really great PR @javaguirre! If I understand correctly, you need more time to finish the content, so feel free to ping me for a later review. I went ahead and reorganized your starting structure for clarity, based on my own experiences copyediting this style of tutorial. I hope those edits will help you build a strong resource for the docs. Feel free to change however is best for you! 💪

You're super helpful @azigler ! I'll do that, thank you for the changes!

I have to complte with this and other testing related tools (gomock, unittesting)


Make create_tile() error message more accurate

I have a TileSet with some invalid tiles and it keeps spamming me with Cannot create tile. The tile is outside the texture or tiles are already present in the space the tile would cover..  It's possible to cause this error accidentally and it does not tell exactly what is wrong.
This PR breaks the message into parts and displays different error depending on what is wrong. In the most common case (see #61296), you will see the message about tiles outside texture.

I think that's a good idea, but there are plenty of other places where has_room_for_tile is used and the message is not precise too. It would be good to fix them all at once.
I would suggest the following:

rename the function to something else (not make it look like it returns a boolean) and make it public. Something like test_room_for_tile(...).
Use test_room_for_tile in most places where the has_room_for_tile is used, and print better error message there.
Keep has_room_for_tile for the exposed API, returning a boolean.


BUG: gulp serve stops working when typescript compilation found an error. spfx1.3

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
gulp serve should be able to continue on working and recompiling the script if there are any changes even if it encountered errors on version spfx 1.3
Observed Behavior
gulp serve stops working when typescript compilation found an error.
Steps to Reproduce
simply make any changes in your ts/tsx files during gulp serve and gulp serve is not continuing to recompile the scripts once it encountered errors. I have to stop the gulp serve manually and restart it again.

Did you check Gulp serve stops watching after compile error  #297 which might talk about the same thing?

Yes it's the same thing. Glad at least people noticed this issue and not sure whether microsoft takes notice about this.

Hello all, this issue will be fixed in the next release of SPFx. For now, you can bypass the error by disabling the toast. Simply update your gulpfile.js and add the following line of code before build.initialize(gulp):
build.mergeConfig({
  showToast: false
});

I'm closing this issue, but feel free to re-open if you are still seeing issues in the 1.4.0 SPFx release.