Pre hook supplied function error

Versions

NodeJS: 11.14.0
Typegoose(NPM): ^5.9.2
mongoose: ^5.7.1

Not sure why I am having this issue, it seems intermittent and inconsistent.
Video example:
https://youtu.be/GdbmYId1DDw
      export const PreSaveNote = async function() {

        console.log('httpContext', httpContext.get('state'))

        const { user, business } = httpContext.get('state')
        if (!user) return

        const { firstName, lastName } = await UserModel.findById(user)

        const modifiedPaths = this.modifiedPaths()
        const isNewDoc      = modifiedPaths.includes('createdUser')
        this.editedDate     = UnixSeconds()

        let input: Partial<Note> = {
          createdUser: user,
          createdBusiness: business,
          entity: this._id,
          entityRef: this.constructor.modelName
        }

        input.body = isNewDoc ? `Created by ${firstName} ${lastName}` : `'${modifiedPaths.map(res => _.startCase(res)).join(', ')}', Updated by ${firstName} ${lastName}`

        await new NoteModel({...input}).save()

      }

    @ObjectType()
    @Index({name: 'text', surname: 'text', email: 'text'})
    @pre<Contact>('save', PreSaveNote)
    export class Contact extends CreatedTypegoose { }

did you already test it with 6.0.0-x?

after a test, i could not reproduce it in 5.9.2 or 6.0.0-28
import { pre, prop, Typegoose } from "@hasezoey/typegoose"; //<EMAIL_ADDRESS>import * as mongoose from "mongoose"; //<EMAIL_ADDRESS>
async function hello() {
    console.log("hello run");
}

@pre<ONE>("save", hello)
class ONE extends Typegoose {
    @prop()
    public something?: string;
}
const ONEModel = new ONE().getModelForClass(ONE);

@pre<TWO>("save", hello)
class TWO extends Typegoose {
    @prop()
    public something?: string;
}
const TWOModel = new TWO().getModelForClass(TWO);

(async () => {
    await mongoose.connect(`mongodb://localhost:27017/`, { useNewUrlParser: true, dbName: "verifyS392" });

    {
        const doc = new ONEModel();
        await doc.save();

        console.log("ONE run");
    }

    {
        const doc = new TWOModel();
        await doc.save();

        console.log("TWO run");
    }

    await mongoose.disconnect();
})();

I'm still getting on the newest 6 version, but it seems it's only is happening when I include the last line "await new NoteModel({...input}).save()", if I remove this line it seems to compile.
On the latest 6 versionI'm also getting
 (node:19124) DeprecationWarning: The Typegoose Class is deprecated, please try to remove it
 (node:19124) DeprecationWarning: Typegoose Class is Deprecated!

repeatedly

On the latest 6 versionI'm also getting

thats because in v6.0.0 extends Typegoose is not needed anymore, so its deprecated and will be removed in future version

await new NoteModel({...input}).save()

could you try await NoteModel.create({...input})

Shows me a little more info, '.create' didn't change anything from what i could tell.
(node:11036) UnhandledPromiseRejectionWarning: TypeError: "Property.pre.save"'s function is not a function!     at addToHooks (F:\prosperty\server\node_modules\@hasezoey\typegoose\src\hooks.ts:101:11)     at F:\prosperty\server\node_modules\@hasezoey\typegoose\src\hooks.ts:77:29     at DecorateConstructor (F:\prosperty\server\node_modules\reflect-metadata\Reflect.js:541:33)     at Object.decorate (F:\prosperty\server\node_modules\reflect-metadata\Reflect.js:130:24)     at Object.__decorate (F:\prosperty\server\node_modules\tslib\tslib.js:89:96)     at Object.<anonymous> (F:\prosperty\server\src\entity\property\property.entity.ts:21:22)     at Module._compile (internal/modules/cjs/loader.js:816:30)     at Module._compile (F:\prosperty\server\node_modules\source-map-support\source-map-support.js:521:25)     at Module.m._compile (C:\Users\RYANNG~1\AppData\Local\Temp\ts-node-dev-hook-8024081380516404.js:56:25)     at Module._extensions..js (internal/modules/cjs/loader.js:827:10)     at require.extensions.(anonymous function) (C:\Users\RYANNG~1\AppData\Local\Temp\ts-node-dev-hook-8024081380516404.js:58:14)     at Object.nodeDevHook [as .ts] (F:\prosperty\server\node_modules\ts-node-dev\lib\hook.js:61:7)     at Module.load (internal/modules/cjs/loader.js:685:32)     at Function.Module._load (internal/modules/cjs/loader.js:620:12)     at Module.require (internal/modules/cjs/loader.js:723:19)     at require (internal/modules/cjs/helpers.js:14:16)

could you edit it to use a full code block and not an line-code?
otherwise, could you give me the @pre line it errors on?

If I move my exported function directly into my @pre function it seems to operate as normal,

I use the "path" field in my tsconfig.json to shorten my paths as shown here, even if i changed my import paths to a 'normal' import climbing the file tree I still get the error.
"paths": {
  "@core/*": ["./core/*"],
  "@entity/*": ["./entity/*"],
  "@api/*": ["./api/*"]
}

  import { Note, NoteModel } from<EMAIL_ADDRESS>  import { PolygonGeometry } from<EMAIL_ADDRESS>  import { CreatedTypegoose } from<EMAIL_ADDRESS>  import { PropertyTypeEnum } from<EMAIL_ADDRESS>

when i can trust the error, then the problem is @pre(method: given, function: missing), so could you provide the line where @pre is called + the function("header")?

I'm not exactly sure what you mean Hase,
After doing some more digging in hooks.js, it seems that the pre method never gets the args once i use the @pre decorator a couple of times when I include the "new NoteModel.save()" line.
When I remove that line it works every time.
I also changed my await statements to normal promise's and noticed no difference.

example:
@pre<TWO>("save", hello) // can you give me THIS line at where it errors
class TWO extends Typegoose {
    @prop()
    public something?: string;
}

// and

async function hello() { // i mean this line as "function header"
    console.log("hello run");
}

  @ObjectType()
  @pre<Job>('save', PreSaveNote)
  export class Job extends CreatedTypegoose { }

  @ObjectType()
  @Index({ center: '2dsphere' })
  @Index({ addressString: 'text' })
  @Index({ addressId: 1, createdBusiness: 1 }, { unique: true })
  @pre<Property>('save', PreSaveNote)
  export class Property extends CreatedTypegoose { }

  @ObjectType()
  @pre<Supplier>('save', PreSaveNote)
  export class Supplier extends CreatedTypegoose { }

  @ObjectType()
  @Index({name: 'text', surname: 'text', email: 'text'})
  @pre<Contact>('save', PreSaveNote)
  export class Contact extends CreatedTypegoose { }

  export const PreSaveNote = async function() {

    const { user, business } = httpContext.get('state')
    if (!user) return

    const { firstName, lastName } = await UserModel.findById(user)

    const modifiedPaths = this.modifiedPaths()
    const isNewDoc      = modifiedPaths.includes('createdUser')
    this.editedDate     = UnixSeconds()

    let input: Partial<Note> = {
      createdUser: user,
      createdBusiness: business,
      entity: this._id,
      entityRef: this.constructor.modelName,
      body: isNewDoc ? `Created by ${firstName} ${lastName}` : `'${modifiedPaths.map(res => _.startCase(res)).join(', ')}', Updated by ${firstName} ${lastName}`
    }

    new NoteModel({...input}).save()

  }

question: does the following change affect anything?
// from
export const PreSaveNote = async function() {

// to
export async function PreSaveNote() {

No luck on my end, trying many different export types.

i cant see a logical reason why this should happen, i will retry to reproduce it...

Yea it feels very odd to me, perhaps some outside issue here, would an older typegoose help?

would an older typegoose help?

since that 5.9.x didnt work, an older wouldnt work too

@RyannGalea now i tried 3 classes, same function each class & function in their own file (like you have), but it still works, i just cant reproduce it

Just ran through your example and it runs fine. This is tricky, I'm not sure what is affecting it.

@RyannGalea i will add it to the "known issues" section as a warning for future users
because it is solved now, as a "not an typegoose issue", could you close it?

The issue seems to be back, investigating some more.

what is causing the issue this time?... /s
i would try to help, is it with the same example again?

I'm pretty sure that I am narrowing it down to a conflict with 'type-graphql' package & union types.
It's hard to track down because It's so intermittent.

@RyannGalea any news on this?

I have opened an issue with 'type-graphql' but have not had the time to investigate the issue any further.
I have removed the need to use the union in my schema for the time being to continue development.

@RyannGalea do you have a link to the repo? there shouldn't be any issues with tsconfig paths. If you link me a repo that I can debug I can look into it.

One thing that comes to mind is a circular dependency, so when @Pre is executed the function isn't resolved yet. You could try putting the entire Contact class definition (everything after the imports) in a setTimeout() and see if the issue still happens. If not, then you probably have a circular dependency

I will delve back into this tomorrow evening

when you test it again, did version 6.1.0-6 (or higher) change anything?

To clarify @hasezoey, the "Pre hook supplied function" topic problem has been resolved, as we have discussed through the discord. I will have a look at the union type issue.

So with version '6.1.0-6' I still get the
 UnhandledPromiseRejectionWarning: TypeError: "Contact.pre.save"'s function is not a function!

when using the following code:
  @Field(type => NoteEnityUnion)
  @prop({ required: true, refPath: 'entityRef' })
  entity: Ref<Property | Contact | Supplier | User>

The type-graphql code:
export const NoteEnityUnion = createUnionType({
  name: 'NoteEnityUnion',
  types: () => [Property, BusinessProperty, Supplier, User],
  resolveType: value => {
    if ('contactType'  in value) return Contact
    if ('buildingType' in value) return Property
    if ('supplierType' in value) return Supplier
    if ('firstName'    in value) return User
    if ('property' in value && 'addressString' in value) return BusinessProperty
    return undefined
  }
})

@RyannGalea i dont know type-graphql, but i just installed it to test this case again - could you provide me the class CreatedTypegoose? (couldnt find it anymore)

import * as _ from 'lodash'

CreatedTypegoose is now named 'Globalfields and looks like this, the defaults just return a number / strings:
@ObjectType()
export class GlobalFields {

  @Field()
  readonly _id: ObjectId

  @Field()
  @prop({index: true, default: () => UnixSeconds() })
  editedDate: number

  @Field()
  @prop({index: true, default: () => UnixSeconds()})
  createdDate: number

  @Field(type => User)
  @prop({index: true, ref: 'User', default: () => HttpContext('user')})
  createdUser: Ref<User>

  @Field(type => Business)
  @prop({index: true, ref: 'Business', default: () => HttpContext('business')})
  createdBusiness: Ref<Business>

}

httpContext is the package 'express-http-context', i believe this was all an issue before i was even using this package:
Below is where context is set for using 'apollo-server-express' which just sets up my graphql server, type-graphql is just used to generate the schema. Context field is run on every request and is used to set the state in httpContext package, and state to be used in my classes using type-graphql @Ctx
    const schema = await generateSchema()
    const server = new ApolloServer({
      schema,
      context: ({req, res}: Context) => {
        const state = {...req.session.state}
        httpContext.set('state', state)
        return {req, res, state}
      },
      formatError: (err) => formatError(err)
    })

const resolverPath   = PATH.resolve(__dirname, '../../api/**/*.ts')
const emitSchemaPath = PATH.resolve(__dirname, '../../schema.readonly.gql')

export const generateSchema = () => {
  return buildSchema({
    resolvers: [resolverPath],
    emitSchemaFile: emitSchemaPath,
    globalMiddlewares: [TypegooseMiddleware],
    scalarsMap: [{type: ObjectId, scalar: ObjectIdScalar}],
    nullableByDefault: true,
    authChecker,
    container: Container
  })
}

A User:
_id: 5cda9e3f2075bd1394a8ec32
emailConfirmed: true
mobileConfirmed:false
password: password
firstName:Ryann
lastName:Galea
<EMAIL_ADDRESS>

i cut down much (like commenting out the indexes, all httpcontext things, and all "UnixSeconds" calls), i still cant reproduce the your error with pre hooks ... but i didnt use type-graphql ... (i still search how to mock it without using express)

I will create a project to try and trim everything back to simply create the error,

@RyannGalea Try this for me.
In the file that's causing the error do this to confirm that PreSaveNote is getting imported
// add the next two lines
console.log("PreSaveNote Sync:", PreSaveNote);
setTimeout(() => console.log("PreSaveNote Async:",PreSaveNote),1000)

@ObjectType()
@pre<Job>("save", PreSaveNote)
export class Job extends CreatedTypegoose { }

This will at least rule out that

Results in
[INFO] 13:05:05 Restarting: manual restart from user
Using ts-node version 8.1.0, typescript version 3.6.3
SaveNote Sync: undefined
Express server running on port: 4000
(node:21388) UnhandledPromiseRejectionWarning: TypeError: "Contact.pre.save"'s function is not a function!
    at addToHooks (F:\prosperty\server\node_modules\@typegoose\typegoose\src\hooks.ts:101:11)
    at F:\prosperty\server\node_modules\@typegoose\typegoose\src\hooks.ts:77:29
    at DecorateConstructor (F:\prosperty\server\node_modules\reflect-metadata\Reflect.js:541:33)
    at Object.decorate (F:\prosperty\server\node_modules\reflect-metadata\Reflect.js:130:24)
    at Object.__decorate (F:\prosperty\server\node_modules\tslib\tslib.js:89:96)
    at Object.<anonymous> (F:\prosperty\server\src\entity\contact\contact.entity.ts:16:21)
    at Module._compile (internal/modules/cjs/loader.js:816:30)
    at Module._compile (F:\prosperty\server\node_modules\source-map-support\source-map-support.js:521:25)
    at Module.m._compile (C:\Users\RYANNG~1\AppData\Local\Temp\ts-node-dev-hook-7129417309517636.js:57:25)
    at Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at require.extensions.(anonymous function) (C:\Users\RYANNG~1\AppData\Local\Temp\ts-node-dev-hook-7129417309517636.js:59:14)
    at Object.nodeDevHook [as .ts] (F:\prosperty\server\node_modules\ts-node-dev\lib\hook.js:61:7)
    at Module.load (internal/modules/cjs/loader.js:685:32)
    at Function.Module._load (internal/modules/cjs/loader.js:620:12)
    at Module.require (internal/modules/cjs/loader.js:723:19)
    at require (internal/modules/cjs/helpers.js:14:16)
(node:21388) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:21388) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Redis server connected
SaveNote Async: undefined
Database connection established. mongodb+srv://ryann:nokia3210@trade-eeukb.mongodb.net/trade_graphql?retryWrites=true
(node:21388) DeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes instead.
null

thanks @NickBolles , this gives me a hint at least

@RyannGalea it is not a problem with typegoose, what @NickBolles pointed out is that the function PreSaveNote does not get imported the right way (it is undefined as the test showed us)

@RyannGalea do you still use these @core/ & @entity/ like in your video?, when not, could you show it again?

@RyannGalea Another troubleshooting step could be copy the PreSaveNote implementation into the file in question to eliminate any import issues.
Here's an update to your repo @hasezoey that has type-graphql running
https://github.com/NickBolles/typegoose-testing

See repository here guys:
https://github.com/RyannGalea/typegooseErr

got it, tested it, found something:
when doing some debugging like setting some random prop export const s = "hello" before anything else, it will show up in something like "JOB" when doing
import * as SN from "../core/saveNote.middleware";
console.log('from JOB', SN, SN.SaveNote);

result:
from JOB { s: "hello" } undefined

so it is something strange with js/ts import-export, not an typegoose issue

From what i'm reading about this import issue is circular dependencies, so I'm curious if that's the issue here and how i would find it

Changing my imports as follows fixes the issue.
const SaveNote = async function() {
  // FUNCTION
}

export { SaveNote as default }

and importing as
import SaveNote from '../../core/middleware/preSaveNote.middleware'

i dont know, from what i have seen in the example repo, there isnt any circular dependencies between the imports of "SaveNote"...

i think this can be closed again because it is not an typegoose issue?

Ok, although it is not resolved i will close this for now.

although it is not resolved

didnt you say the change exports/imports have fixed it?

No i deleted that comment as it was a flase flag.

also when changing your mention in the test repo, the compiled output didnt change

nvm, found the circular dependencie:
saveNote.middleware -> note.entity -> Job -> saveNote.middleware

@NickBolles thanks again for pointing this out

Wow, we got there in the end, Thanks to @hasezoey & @NickBolles
So in my  Pre function i removed the circular dependency import and moved it inside the function.
Before:
import { startCase } from 'lodash'
import { UserModel } from '../../entity/user/user.entity'
import { UnixSeconds } from '../helpers/defaults.helper'
import { NoteModel } from '../../entity/note/note.entity'
import { NoteInput } from '../../entity/note/note.input'

export const SaveNote = async function() {

  const noteModel = require('../../entity/note/note.entity')

  this.editedDate = UnixSeconds()

  const isNewDoc                = this.editedDate - this.createdDate < 5
  const modifiedPaths           = this.modifiedPaths().filter(res => res !== 'editedDate').map(res => startCase(res)).join(', ')
  const { firstName, lastName } = await UserModel.findById(this.createdUser)

  let input: NoteInput = {
    entity: this._id,
    entityRef: this.constructor.modelName,
    body: isNewDoc ? `Created by ${firstName} ${lastName}` : `'${modifiedPaths}', Updated by ${firstName} ${lastName}`
  }

  await new noteModel({...input}).save()

}

After:
import { startCase } from 'lodash'
import { UserModel } from '../../entity/user/user.entity'
import { UnixSeconds } from '../helpers/defaults.helper'
import { NoteInput } from '../../entity/note/note.input'

export const SaveNote = async function() {

  this.editedDate = UnixSeconds()

  const isNewDoc                = this.editedDate - this.createdDate < 5
  const modifiedPaths           = this.modifiedPaths().filter(res => res !== 'editedDate').map(res => startCase(res)).join(', ')
  const { firstName, lastName } = await UserModel.findById(this.createdUser)

  let input: NoteInput = {
    entity: this._id,
    entityRef: this.constructor.modelName,
    body: isNewDoc ? `Created by ${firstName} ${lastName}` : `'${modifiedPaths}', Updated by ${firstName} ${lastName}`
  }

  const { NoteModel } = require('../../entity/note/note.entity')
  await new NoteModel({...input}).save()

}

for some that have the same issue, here is a blog post that has an ok workaround, that dosnt need to use "require on the fly"

I'll have a look at this @hasezoey, but seeing it seems to only be an issue  inside of these pre functions i will likely stay with the require solution for now. I appreciate all the time spent on this.

Sweet! I had a suspicion. But I'm surprised the setTimeout() didn't print it.
That blog post is good too.But yea, probably not worth the time.

@hasezoey is this issue related to to alias paths ? it seems to me after reading the chain of discussion that it's related to circular dependencies.
if that's the case i suggest we remove the reference of this issue in the known issues as an issue with tsconfig-paths.


Having issues with following the selfhosted tutorial

Hi there,
i followed the wiki page for creating a self hosted PWD.
I am not able to start this from scratch. I guess mainly because the l2 container is missing.
What I have done now was to use the compose file to start just the l2 container and afterwards start the pwd container manually.
What I am still missing is the port forwarding feature. Is there something that I have to configure before?
Also on many instances it does not show CPU and Memory:

The Manager Status is also not shown.
I guess I am missing a few things. Can you please help me?


Using AzureChatOpenAI

System Info
I have just updated my LangChain packages. Until a few weeks ago, LangChain was working fine for me with my Azure OpenAI resource and deployment of the GPT-4-32K model. As I've gone to create more complex applications with it,  I got stuck at one section where I kept getting the error: "InvalidRequestError: The API deployment for this resource does not exist. If you created the deployment within the last 5 minutes, please wait a moment and try again."
I have given up on this error personally, but I currently have multiple Microsoft employees trying to help me figure it out. However, all of sudden, the basic implementations of LangChain now seem to be creating the same issue. Even though the native/direct API call to Azure OpenAI services is functioning correctly with the same credentials.
I am trying to use the following code to get the basic implementation working again, following directly what is written at https://python.langchain.com/docs/integrations/chat/azure_chat_openai :
model = AzureChatOpenAI(
azure_deployment="Brian",
openai_api_version="2023-05-15"
)
message = HumanMessage(
content="Translate this sentence from English to French. I love programming."
)
print(model([message]))
This keeps getting the same error (as above with "the API deployment does not exist...") and I'm am completely stumped. How has LangChain gone from working to this error without me changing my credentials? And at the same time these credentials still work for the native Azure OpenAI API call. Any help would be massively appreciated.
Who can help?
@hwchase17 @agola11
Information

[X] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I have put the code above that you can use, but it seems more of an issue about how LangChain uses my Azure OpenAI account.
Expected behavior
WARNING! azure_deployment is not default parameter.
azure_deployment was transferred to model_kwargs.
Please confirm that azure_deployment is what you intended.
InvalidRequestError                       Traceback (most recent call last)
Cell In[16], line 9
1 model = AzureChatOpenAI(
2     azure_deployment="Brian",
3     openai_api_version="2023-05-15"
4 )
6 message = HumanMessage(
7     content="Translate this sentence from English to French. I love programming."
8 )
----> 9 print(model([message]))
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/base.py:606, in BaseChatModel.call(self, messages, stop, callbacks, **kwargs)
599 def call(
600     self,
601     messages: List[BaseMessage],
(...)
604     **kwargs: Any,
605 ) -> BaseMessage:
--> 606     generation = self.generate(
607         [messages], stop=stop, callbacks=callbacks, **kwargs
608     ).generations[0][0]
609     if isinstance(generation, ChatGeneration):
610         return generation.message
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/base.py:355, in BaseChatModel.generate(self, messages, stop, callbacks, tags, metadata, run_name, **kwargs)
353         if run_managers:
354             run_managers[i].on_llm_error(e)
--> 355         raise e
356 flattened_outputs = [
357     LLMResult(generations=[res.generations], llm_output=res.llm_output)
358     for res in results
359 ]
360 llm_output = self._combine_llm_outputs([res.llm_output for res in results])
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/base.py:345, in BaseChatModel.generate(self, messages, stop, callbacks, tags, metadata, run_name, **kwargs)
342 for i, m in enumerate(messages):
343     try:
344         results.append(
--> 345             self._generate_with_cache(
346                 m,
347                 stop=stop,
348                 run_manager=run_managers[i] if run_managers else None,
349                 **kwargs,
350             )
351         )
352     except BaseException as e:
353         if run_managers:
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/base.py:498, in BaseChatModel._generate_with_cache(self, messages, stop, run_manager, **kwargs)
494     raise ValueError(
495         "Asked to cache, but no cache found at langchain.cache."
496     )
497 if new_arg_supported:
--> 498     return self._generate(
499         messages, stop=stop, run_manager=run_manager, **kwargs
500     )
501 else:
502     return self._generate(messages, stop=stop, **kwargs)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/openai.py:360, in ChatOpenAI._generate(self, messages, stop, run_manager, stream, **kwargs)
358 message_dicts, params = self._create_message_dicts(messages, stop)
359 params = {**params, **kwargs}
--> 360 response = self.completion_with_retry(
361     messages=message_dicts, run_manager=run_manager, **params
362 )
363 return self._create_chat_result(response)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/openai.py:299, in ChatOpenAI.completion_with_retry(self, run_manager, **kwargs)
295 @retry_decorator
296 def _completion_with_retry(**kwargs: Any) -> Any:
297     return self.client.create(**kwargs)
--> 299 return _completion_with_retry(**kwargs)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/tenacity/init.py:289, in BaseRetrying.wraps..wrapped_f(*args, **kw)
287 @functools.wraps(f)
288 def wrapped_f(*args: t.Any, **kw: t.Any) -> t.Any:
--> 289     return self(f, *args, **kw)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/tenacity/init.py:379, in Retrying.call(self, fn, *args, **kwargs)
377 retry_state = RetryCallState(retry_object=self, fn=fn, args=args, kwargs=kwargs)
378 while True:
--> 379     do = self.iter(retry_state=retry_state)
380     if isinstance(do, DoAttempt):
381         try:
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/tenacity/init.py:314, in BaseRetrying.iter(self, retry_state)
312 is_explicit_retry = fut.failed and isinstance(fut.exception(), TryAgain)
313 if not (is_explicit_retry or self.retry(retry_state)):
--> 314     return fut.result()
316 if self.after is not None:
317     self.after(retry_state)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/concurrent/futures/_base.py:451, in Future.result(self, timeout)
449     raise CancelledError()
450 elif self._state == FINISHED:
--> 451     return self.__get_result()
453 self._condition.wait(timeout)
455 if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/concurrent/futures/_base.py:403, in Future.__get_result(self)
401 if self._exception:
402     try:
--> 403         raise self._exception
404     finally:
405         # Break a reference cycle with the exception in self._exception
406         self = None
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/tenacity/init.py:382, in Retrying.call(self, fn, *args, **kwargs)
380 if isinstance(do, DoAttempt):
381     try:
--> 382         result = fn(*args, **kwargs)
383     except BaseException:  # noqa: B902
384         retry_state.set_exception(sys.exc_info())  # type: ignore[arg-type]
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/langchain/chat_models/openai.py:297, in ChatOpenAI.completion_with_retry.._completion_with_retry(**kwargs)
295 @retry_decorator
296 def _completion_with_retry(**kwargs: Any) -> Any:
--> 297     return self.client.create(**kwargs)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/openai/api_resources/chat_completion.py:25, in ChatCompletion.create(cls, *args, **kwargs)
23 while True:
24     try:
---> 25         return super().create(*args, **kwargs)
26     except TryAgain as e:
27         if timeout is not None and time.time() > start + timeout:
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/openai/api_resources/abstract/engine_api_resource.py:155, in EngineAPIResource.create(cls, api_key, api_base, api_type, request_id, api_version, organization, **params)
129 @classmethod
130 def create(
131     cls,
(...)
138     **params,
139 ):
140     (
141         deployment_id,
142         engine,
(...)
152         api_key, api_base, api_type, api_version, organization, **params
153     )
--> 155     response, _, api_key = requestor.request(
156         "post",
157         url,
158         params=params,
159         headers=headers,
160         stream=stream,
161         request_id=request_id,
162         request_timeout=request_timeout,
163     )
165     if stream:
166         # must be an iterator
167         assert not isinstance(response, OpenAIResponse)
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/openai/api_requestor.py:299, in APIRequestor.request(self, method, url, params, headers, files, stream, request_id, request_timeout)
278 def request(
279     self,
280     method,
(...)
287     request_timeout: Optional[Union[float, Tuple[float, float]]] = None,
288 ) -> Tuple[Union[OpenAIResponse, Iterator[OpenAIResponse]], bool, str]:
289     result = self.request_raw(
290         method.lower(),
291         url,
(...)
297         request_timeout=request_timeout,
298     )
--> 299     resp, got_stream = self._interpret_response(result, stream)
300     return resp, got_stream, self.api_key
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/openai/api_requestor.py:710, in APIRequestor._interpret_response(self, result, stream)
702     return (
703         self._interpret_response_line(
704             line, result.status_code, result.headers, stream=True
705         )
706         for line in parse_stream(result.iter_lines())
707     ), True
708 else:
709     return (
--> 710         self._interpret_response_line(
711             result.content.decode("utf-8"),
712             result.status_code,
713             result.headers,
714             stream=False,
715         ),
716         False,
717     )
File /anaconda/envs/azureml_py310_sdkv2/lib/python3.10/site-packages/openai/api_requestor.py:775, in APIRequestor._interpret_response_line(self, rbody, rcode, rheaders, stream)
773 stream_error = stream and "error" in resp.data
774 if stream_error or not 200 <= rcode < 300:
--> 775     raise self.handle_error_response(
776         rbody, rcode, resp.data, rheaders, stream_error=stream_error
777     )
778 return resp
InvalidRequestError: The API deployment for this resource does not exist. If you created the deployment within the last 5 minutes, please wait a moment and try again.

@dosubot . I have tried upgrading the LangChain package, I am now getting this error: InvalidRequestError: Invalid URL (POST /v1/openai/deployments/Brian/chat/completions) . However, I am sure that my credentials are correct.

I am having same issue. All of a sudden my call yo azurechatopenAI stopped working with Langchain. This was my earlier call which was working fine.
model = AzureChatOpenAI(
openai_api_version=OPENAI_API_VERSION,
azure_deployment=OPENAI_DEPLOYMENT_NAME,
)
Now I keep getting this error "The API deployment for this resource does not exist. If you created the deployment within the last 5 minutes, please wait a moment and try again" No matter what I use. I even tried above suggestion.
BASE_URL = "https://.openai.azure.com"
API_KEY = ""
DEPLOYMENT_NAME = ""
model = AzureChatOpenAI(
openai_api_base=BASE_URL,
openai_api_version="2023-03-15-preview",
deployment_name=DEPLOYMENT_NAME,
openai_api_key=API_KEY,
openai_api_type="azure",
still same error. I downgradedc my openai version to 0.28.1 after reading messages online. This is frustrating. AzureChatOpenAI has stopped working. Its either lanhcgain or new openai version.
can anyone help me?


SASS variables

this theme is awesome! Now I have noticed that I can't edit SASS files as used to because variables does not get highlighted. Screenshot attached. Sass editing with the official plugin from atom:  https://atom.io/packages/language-sass
default, One Dark theme:

An old hope theme:

Good call, I'll take a look at this, thanks!


Flake8-annotations: fix errors in federated, part 1(3)

Preparations to add Flake8-annotations plugin.
This fix is only for errors in federated/data folder.
It is assumed that the next flake8-annotations errors will be ignored:
ANN002 - Missing type annotation for *args
ANN003 - Missing type annotation for **kwargs
ANN101 - Missing type annotation for self in method
ANN102 - Missing type annotation for cls in classmethod

Jenkins please retry a build


Remove cargo::rustc-check-cfg to only have one place to configure the unknown_cfgs lint

There are currently two places where the lint can be configured, in build.rs using cargo::rustc-check-cfg and in the Cargo.toml in the lints section. Generally, having only one place is better than having two, as users don't have to look into two places to find the configuration.
Since this feature hasn't been shipped to a stable compiler yet, we could currently still remove one of them without backward compatibility hazards.
The possible cfgs of a crate across all build configurations are known statically, since they're at most all that appear in the source code. This means that all possible configurations should be expressible in Cargo.toml.

The declarative approach also works for cfgs used in build.rs directly: https://github.com/rust-lang/rust/issues/125368.

Currently, we have it documented to encourage

build.rs if you specify the associated cfg in build.rs
Cargo.toml for other cases (like fuzzing)

When we document the build.rs case, we talk about the importance of keeping cargo::rustc-check-cfg close to cargo::rustc-cfg.  I think this is an important property to help ensure they are updated hand-in-hand.

@epage , please do notice my note at the end in #125368— the fact that build-rs-printf does not suppress warnings creates a problem because currently it's possible for the warning to recommend a mitigation which has no effect.
Assuming that isn't fixable, if you do keep in rustc-check-cfg, I think you should be careful to document build-rs-printf will not helpful if cfgs are used in build.rs itself, and ideally you should modify the warning hint to not recommend the build-rs-printf fix if it detects (because this is detectable) that the warning has been triggered within build.rs. Alternately, removing rustc-check-cfg would mean you don't need that complexity in messaging/warning plumbing.

I agree with @epage, keeping cargo::rustc-check-cfg is important, there are users how would be negatively affected by it's removal, like users of the cfg_aliases, which would need to manually declare the expected outside of where they define their aliases, which goes completely against what we are trying to achieve.

Assuming that isn't fixable

It is fixable. I just didn't yet have time to do it.

The declarative approach also works for cfgs used in build.rs directly: rust-lang/rust#125368.

While it works, it's also not 100% the same thing, the [lints.rust.unexpected_cfgs.check-cfg] lint config applies to build.rs, but if the config is declared by the build.rs, that probably means it isn't expected for the build.rs it-self. So putting it that the same place as the cargo::rustc-cfg instruction guarantees the same applicability.

When we document the build.rs case, we talk about the importance of keeping cargo::rustc-check-cfg close to cargo::rustc-cfg. I think this is an important property to help ensure they are updated hand-in-hand.

I see, I think this argument makes sense. It also means that tools outputting cargo::rustc-cfg can also directly output cargo::rustc-check-cfg.
I still feel that a) having a non-declarative version of the config makes it harder for tools, because they need to run untrusted code to get a list of cfgs, and b) users need to be taught about two things that do roughly the same thing, are two significant downsides to this approach.
If we started with [lints.rust.unexpected_cfgs.check-cfg] today, would the build.rs way we be added? Perhaps yes.

@mcclure

@epage , please do notice my note at the end in https://github.com/rust-lang/rust/issues/125368 — the fact that the build-rs-printf method does not suppress warnings creates a problem because currently it's possible for the warning to recommend a mitigation which has no effect.

build.rs only sets compilation flags for all other build targets and not for itself.
With the split I gave of static vs dynamic cfgs, could you give an example of a cfg that the build.rs both reads and sets where this is a problem?

build.rs only sets compilation flags for all other build targets and not for itself.
With the split I gave of static vs dynamic cfgs, could you give an example of a cfg that the build.rs both reads and sets where this is a problem?

Hi, I'm not sure I understand what you mean by "the split I gave of static vs dynamic cfgs", but the case I give in #125368 is the case of a .rs file which for whatever reason is used both in the build.rs and also in a non-build.rs target. It's true the custom cfg can be set for only non-build.rs targets, but the rustc-check-cfg warning appears also for cfg(not()) statements, and code that runs during build.rs might indeed want to happen conditionally on cfg(not(symbolname)) where symbolname is a cfg build.rs sets.

Thanks for the clarification.
At this point, the feature is stable.  We could deprecate one but I'm not seeing enough of a case to justify it.  We give a dynamic and a static way of defining these, allowing people to use the one that works well for what they are doing.
As such I propose we close this.

Second and close. Thanks everyone.


update cli readme per change in clicommon

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

purely codegen change in xxx.cli.md. Assign to Qiaoqiao to review. thanks.

Can one of the admins verify this patch?

operation and operationGroup in directive should start with a capital latter ?

actually it doesnt matter, it's case insensitive now

operation and operationGroup in directive should start with a capital latter ?

actually it doesnt matter, it's case insensitive now

operation and operationGroup in directive should start with a capital latter ?

actually it doesnt matter, it's case insensitive now

I see. Can you take a look at the go sdk failure? @NullMDR


Fix issue that surfaced on 29 Aug 2018 about 14:44 CDT, resulting in …

…'Our servers are waiting for a supercharger spot..' html msg instead of json data.  Fix inspired by https://teslamotorsclub.com/tmc/threads/error-in-tesla-api.127239/.
Apologies that I haven't spent the time to learn and run and update the test suite successfully, but I did do a 'gem build' of model-s-api with this fix, copied the .gem to my repo, did a 'gem unpack', pointed to it from Gemfile, verified it locally, checked the unpacked gem and tweaked Gemfile into my repo, deployed to heroku, and verified that my website is now collecting my car data again.
Hope this helps!

Coverage increased (+0.1%) to 81.176% when pulling cbd2547743a1fe2c8c803a9d780959fd2728fb7c on walquis:master into 9b49a19682e54248e7bf8b4b0781efba62d24145 on timdorr:master.

+1 can confirm this fix
since this is the official gem, I'd prefer we get a more accurate User-Agent header on the off chance Tesla needs to trace it back to this repo to talk about future API stuff. also, we can move it to the class level for HTTParty in the same client.rb file
module TeslaApi
  class Client
    include HTTParty
    base_uri "https://owner-api.teslamotors.com/api/1"
    headers({
      "User-Agent" => "github.com/timdorr/model-s-api v:#{VERSION}"
    })
    format :json

I'll want to re-record the cassettes to go along with this, as their fairly outdated anyways.

OK, I'm at work on the other stuff. Thanks!


Optimize WalletJob's StallMempool

After: https://github.com/nopara73/HBitcoin/issues/6
Related: https://github.com/nopara73/HBitcoin/issues/10
It's not done in the best possible way, we could gain a second or two refactoring it.

What's the purpose of mempool? Just storing unconfirmed trx associated to any tracked addresses right?

Answered here: https://github.com/nopara73/HBitcoin/issues/10#issuecomment-290838162

https://github.com/nopara73/HBitcoin/commit/987dfc6dc753708ee8e249bb4d44f039713d7fa6


Rollback button on Base Image history

before the rollback, we have screenshots like:

after the rollback, I see 503 error, but actually the config has been updated successfully. Not sure why there was 503.

I tried again, for the next several times, everything looks good. ^^
Before rollback:

After rollback:


About Tensorflow Version

If we use Tensorflow version 2.x, it may report that "placeholder" is missed. And using Tensorflow version 1.x could solve this problem.

https://stackoverflow.com/questions/37383812/tensorflow-module-object-has-no-attribute-placeholder

If we use Tensorflow version 2.x, it may report that "placeholder" is missed. And using Tensorflow version 1.x could solve this problem.

Hi, did you run the demo.py successfully using Tensorflow version 2.x?


Question about del_pos_init and get_pos_init

Hi! Could you please tell me what is the meaning of del_pos_init and get_pos_init? There is no such operations in the original torch_pruning when pruning ViT or Swin transformer. Why is positional embedding removed here and what is the effect of this on pruning?

Hi, @tasakim , Thanks for the issue.
The positional embedding approach of SAM's encoder is too complex for the dependency detection algorithm we used in pruning. As a result, we remove the positional embedding before pruning and add zero-initialized positional embedding after pruning. The performance of the compressed encoder will not be significantly affected after post-distillation.


CAMEL-13830: Remove examples folder

This will remove the examples folder. However I had to remove the generation of the examples docs from the gulp file, perhaps @zregvart if you if have any hints on how I can manage the docs for the examples in the new repo, would be highly appreciated :)

Without the examples bit in the docs/gulpfile.js we'll loose the examples from the documentation. For example this chapter would not have the example in it.
Antora requires that the examples are within the module's examples directory.
We need to either commit the examples we currently have or find a way to pull them in the build from the camel-examples repository.

@zregvart indeed is going to be pretty tricky, perhaps we can do that in jenkins? Or use a git submodule?
Anyway, I have committed back the deleted examples for the docs, at least in the meantime we have them. Can you please take a look if didn't mess anything with the docs? Thanks

I've had a look at the examples we currently reference from the documentation. Only two pages bring in examples outside of the camel (main) repository.
The console example:
https://github.com/apache/camel/blob/e7c0a9ca73d13f9d88896eae81aafff13e49655a/docs/user-manual/modules/ROOT/pages/console-example.adoc#L16
And the thorough example:
https://github.com/apache/camel/blob/master/docs/user-manual/modules/ROOT/pages/walk-through-an-example.adoc
Other examples are taken from the core or from the components. For example the mock-component documentation includes an example from the core here:
https://github.com/apache/camel/blob/e7c0a9ca73d13f9d88896eae81aafff13e49655a/components/camel-mock/src/main/docs/mock-component.adoc#L273
Perhaps it would be better to reinstate the example files copying in docs/gulpfile.js and inline the examples in the above two asciidoc files.

Aha, then I shall fix this and raise another PR. Thanks @zregvart !


[BUG] FusedDenseGELUDense, FusedDropoutLayerNorm not exported in zeta/nn/init.py

ImportError                               Traceback (most recent call last)
[<ipython-input-11-0b8f0cee3df3>](https://localhost:8080/#) in <cell line: 2>()
      1 import torch
----> 2 from zeta.nn import FusedDenseGELUDense
      3
      4 x = torch.randn(1, 512)
      5 model = FusedDenseGELUDense(512, 1024)

ImportError: cannot import name 'FusedDenseGELUDense' from 'zeta.nn' (/content/zeta/zeta/nn/__init__.py)

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

the error has been resolved


⚠ GitLab Server has degraded performance

In 4a65934, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 14244 ms

Resolved: GitLab Server performance has improved in 41f6d3b.


7.10.0 release

This PR bump chart version and Docker images to test 7.10.0.
See New branching model for more details.

jenkins test this please

jenkins test this please


Remove 'isComplete' argument from file fields as it's not needed

Is this safe to merge? Has the frontend change that removes it been deployed to production?

Ah yes! No, they haven't. I will close this until then.


androidtv-Leanback view bug

Without making any modifications to create a duplicate VIEW found not recycled to create an overlay

Hi. Can you elaborate? If there's a visual issue can you post a screenshot?

This sample has been migrated to a new location and updates are happening there (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


Configuration issue on Custom Learning Admin page

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug
Admittedly, I had been tweaking some permissions on the site when I started to experience the bug specifically for the customlearningadmin page as listed below:
Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance. [Administrators: Please see the browser console for detailed logs. For technical assistance check out the issues list at https://github.com/pnp/custom-learning-office-365/issues.] {CustomLearningAdminWebPart}
custom-learning-admin-web-part_a856afe0e07b13cfeb87.js:1
Message: 🎓 M365LP:InitService (loadUserRole) - TypeError: Cannot read properties of undefined (reading 'toString')
To Reproduce
Reproduce by trying to access to the custom learning admin page
Expected behavior
To be able to access the custom learning admin page.
Screenshots

Learning Pathways version number
4.14 on user end. After updating app in app catalog, we were unable to update learning pathways on the MLP site.
4.30 in tenant app catalog

Please share the version number of learning pathways in your tenant app catalog.

Additional context
Would it be best to delete and redeploy learning pathway? If so, how should we go about doing so?

Hi @livinusb, Thanks for submitting this issue. Please allow us sometime to investigate. We'll get back to you at the earliest. Thank you for your patience.

@livinusb thanks for reaching out. The function that is erroring out is the one that checks to make sure that the user is part of the owners or member group so most likely if you were changing permissions the user is no longer in one of the associated groups. I would suggest that you put the permissions back and see if you can get things working again.
Once that is done check to make sure that the app was deployed to the tenant app catalog with no errors. The error field is off to the right so you might need to scroll. You shouldn't need to delete it from the app catalog. You can try to upload the 4.3 sppkg file to the app catalog again and ensure there are no errors. In the learning pathways site collection you should be able to see app and in the details there you can upgrade it. Keep in mind, the user doing the upgrade needs to have permissions to do so or it will be grayed out.
Let me know if any of these comes up with any additional info.
-Derek

Hi @dcashpeterson. Thanks for getting back to me on this issue.
I had deleted the member's group and re-created it. That might be the issue. I'm currently part of the owners and member group.
I don't see the option to upgrade it at all:

I also just confirmed with our SharePoint admin that he might have deployed it via the SharePoint look book, so I'm probably barking up the wrong tree.

I ended up fixing the issue by recreating the Member's group via _layouts/15/permsetup.aspx. Thanks for the help.

I was just going to make that suggestion. I am glad it worked out.
-Derek


delete old guides

The following ALLCAPS Markdown guides should have replacements now in a folder and more descriptive file names.
PLEASE CHECK that nowhere refers to any of these old ones instead of the new ones! I think I've been pretty thorough, but I am looking for people to verify!

Not strictly speaking related but do you also want to delete old-translations/ and CHANGELOG.md as part of this? We're not going to use those I don't think so might as well delete at this point.

Only had time for a quick search, but I found a few places:

https://github.com/withastro/docs/discussions/2894
https://github.com/withastro/docs/blob/9d026521bc4ef73e817d72464df3ece3b68715cd/README.md?plain=1#L62C26
https://github.com/withastro/docs/blob/9d026521bc4ef73e817d72464df3ece3b68715cd/scripts/lib/translation-status/template.html#L229
https://github.com/withastro/docs/blob/9d026521bc4ef73e817d72464df3ece3b68715cd/src/components/FallbackNotice.astro#L8
Translations of contribute.mdx

Thanks @TheOtterlord Just did a bunch more!

(And, I also updated Chris' message re: recipe ideas!)  :joy:


⚠ Bofrost.be has degraded performance

In ced2cbf, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2957 ms

Resolved: Bofrost.be performance has improved in 5c2f453.


Improve Actions hygiene

👋 hello there! I'm a fellow Googler who works on projects that leverage GitHub Actions for CI/CD. Recently I noticed a large increase in our queue time, and I've tracked it down to the limit of 180 concurrent jobs for an organization. To help be better citizens, I'm proposing changes across a few repositories that will reduce GitHub Actions hours and consumption. I hope these changes are reasonable and I'm happy to talk through them in more detail.

(you were already doing this, thank you!) Only run GitHub Actions for pushes and PRs against the main branch of the repository. If your team uses a forking model, this change will not affect you. If your team pushes branches to the repository directly, this changes actions to only run against the primary branches or if you open a Pull Request against a primary branch.

For long-running jobs (especially tests), I added the "Cancel previous" workflow. This is very helpful to prevent a large queue backlog when you are doing rapid development and pushing multiple commits. Without this, GitHub Actions' default behavior is to run all actions on all commits.

There are other changes you could make, depending on your project (but I'm not an expert):

If you have tests that should only run when a subset of code changes, consider gating your workflow to particular file paths. For example, we have some jobs that do Terraform linting, but they only run when Terraform files are changed.

Hopefully these changes are not too controversial and also hopefully you can see how this would reduce actions consumption to be good citizens to fellow Googlers. If you have any questions, feel free to respond here or ping me on chat. Thank you!

I'm looking at the docs for this... am I correct in inferring that this will only work for pull requests not opened from a fork? I think most PRs in JAX come from forks of the repository, so this approach might be more relevant: https://github.com/marketplace/actions/cancel-workflow-action#advanced-pull-requests-from-forks

Hmm. The problem that that approach is that Actions is a FIFO queue, so you can get into a thundering herd problem where a bunch of Actions sit between your cancel workflow, meaning it won't run until other jobs have finished, defeating the point :/

OK, thanks - this looks like a good start. Let's get it merged (as soon as the workflow gets unqueued :grin:).
Would you mind squashing the changes into a single commit?

Well I want to be sure that this doesn't break your existing workflows. Let's try to coordinate a merge and then open a PR from a fork to test. Then we can easily revert if it fails. I have other ideas for this problem, but this is the easiest :).
I'm not at my computer now, but I'll squash and rebase tomorrow.

Hey @jakevdp - I'm around again if you want to try and coordinate a test.

What sort of test do you have in mind?
Side note: I'm noticing that github actions are still Queued for the commit from 19 hours ago... that doesn't seem like it would be due to organic growth in actions usage by our org. Do you know what the root cause of yesterday's sharply increased usage might be?

Yes, there are other things at play (namely a massive decrease in the number of parallel runners for the google org), and that's being addressed separately. The reason the queue keeps growing is due to the lack of good hygiene on some of the projects though (like not canceling previous builds when new commits are pushed).

The Google org has A LOT of projects, and they all share the same set of free runners with a concurrency of 20. Even just one repo misconfiguration (like not setting the default action timeout - which is 6 hours by default 😵, or not cancelling runs when new pushes happen) can eat up all of the shared resources.
Another thing that might be worth investigating is using hosted runners https://github.blog/2020-08-04-github-actions-self-hosted-runners-on-google-cloud/

@taquitos We should have this discussion internally, but our understanding is that self-hosted (or GCP-hosted) runners aren't allowable for security reasons because we are a public repo and accept public PRs. Otherwise we almost certainly would use our own runners so we can assign them more CPU.


Unable to resolve example url allure.iopump.ru

moving to brewcode.org and looking for free cloud hosting with containers support or Kubernetes )


Content in a second column is rendered as a code block

If you convert this page for example:
https://www.notion.so/d17c100b8ca94ffbacc694306461c1d1

Is rendered like this:

I know markdown doesn't support columns but I think it makes more sense to render the column as just inline content.
Also should image caption be used as img alt?

Hey there, thanks for reporting. Due to certain issues, the indentation of the block is wrong which is why it is being rendered as a code block.
I will fix and create a new release.
About the issue related to image caption:  it is already implemented, here is the pr https://github.com/souvikinator/notion-to-md/pull/12 . Try updating notion-to-md to the latest version. (v2.3.2)

@victornpb the issue is now fixed in v2.3.3
Feel free to reopen the issue for further questions.

thank you!


Implemented detection of outdated or not

This is the first time I've used React, I know this isn't clean.
If someone who is good in JS would like to clean it up / make some changes, I'd be more than grateful.

I have made the changes I think you asked for. If I missed something, I apologize. I noticed a flaw in the initial attempt where it would only set the latest stuff if they didn't have it cached. Now it's split up to

Check if the regex matches
Check if they have latest build number cached and use that
Get latest build if it's not cached
If on latest or not, set the flags


Add Aggregate Group Speed Capabilities

This is an example of a way to add aggregate group speed capabilities.
Fixes StuffAnThings/qbit_manage#494

[x] New feature (non-breaking change which adds functionality)

[x] My code follows the style guidelines of this project

[x] I have performed a self-review of my own code

[x] I have commented my code, particularly in hard-to-understand areas

[x] I have modified this PR to merge to the develop branch

This is non-functional and appears to not have been tested. Reverted and will need to be re-PRed and actually tested
def https://github.com/StuffAnThings/qbit_manage/issues/510


Token returned via aws lambda role incorrect.

Hello,
I am in the process of writing an aws lambda function in go that will get a token and use it to send a request to me eks cluster api.
The lambda is running as the same role that the eks cluster was created with.
I am able to successfully get a token, but any calls to the kubernetes api result in a 401.
Here is the code I am running (edited a bit for purpose of this issue):
import (
    "github.com/heptio/authenticator/pkg/token"
)

func GetToken(clusterId string) string {
    var tok string
    var err error
    var clusterId = "mycluster"
    gen, err := token.NewGenerator()
    if err != nil {
        fmt.Fprintf(os.Stderr, "could not get token: %v\n", err)
        os.Exit(1)
    }
    tok, err = gen.Get(clusterId)
    if err != nil {
        fmt.Fprintf(os.Stderr, "could not get token: %v\n", err)
        os.Exit(1)
    }
    fmt.Fprintf(os.Stdout, "Token: %v\n", tok)
    return tok
}

I have attempted to verify the token using the following code:
	stssvc := sts.New(session.New())
	id, _ := stssvc.GetCallerIdentity(&sts.GetCallerIdentityInput{})

	fmt.Println("id: ", id)

	tokey := GetToken(data.ClusterId)
	x := token.NewVerifier(data.ClusterId)

	i, err := x.Verify(tokey)
	if err != nil {
		fmt.Println(err)
		os.Exit(1)
	}
	fmt.Println("id: ", *i)

This results in:
id:  {
  Account: "***",
  Arn: "arn:aws:sts::***:assumed-role/EKSRole/EKS-Create-ConfigMap",
  UserId: "***:EKS-Create-ConfigMap"
}
id:  {arn:aws:sts::***:assumed-role/EKSRole/EKS-Create-ConfigMap arn:aws:iam::***:role/EKSRole *** *** EKS-Create-ConfigMap}

It appears the token I am getting back from the generator.Get() call is incorrect.
If you'd like to check the code out in more detail you can do so here:
https://github.com/JordanDeBeer/eks_configmap_lambda/tree/feature/make-work
Please let me know if you have any additional insight or if I can provide further information.

Here is the output from the "verify" command:
[jordan@x1c ~]$ heptio-authenticator-aws verify -i jordanlab -t "k8s-aws-v1.****"
&{ARN:arn:aws:sts::***:assumed-role/EKSRole/EKS-Create-ConfigMap CanonicalARN:arn:aws:iam::***:role/EKSRole AccountID:*** UserID:**** SessionName:EKS-Create-ConfigMap}

On further inspection, it appears that the UserID from the verify command does NOT match the output from calling stssvc.GetCallerIdentity(&sts.GetCallerIdentityInput{}).

I have solved this issue.  It appears that the user/role that initially creates the EKS cluster is the only one that has access to the API until further user/roles are added.


Removing timestamp information from "dc"."date" to allow year to import

Our values for "dc"."date" in Digital Commons records are timestamped (end in Z) and do not import as noted in ExLibris documentation. This rule allows us to remove all characters after the first "-" in the date field, leaving only the year as the value in "dc"."date", meaning it can import.
rule "remove timestamp for utc scholar date"
when
exist "dc"."date"
then
set TEMP"1" to dc value "dc"."date"
remove substring using regex (TEMP"1","-.*")
set "dc"."date" to TEMP"1"
end

Hi alsalatkajr,
Just looking at this now and wondering if you have seen our other date example which contains 4 different variants of this code in xml?
I'm going to close this issue with our gratitude.
Regards,
Craig.


provide none for soop keywords if no data

Codecov Report
Base: 81.00% // Head: 76.86% // Decreases project coverage by -4.15% :warning:

Coverage data is based on head (5a87943) compared to base (6d3e80e).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   81.00%   76.86%   -4.15%
==========================================
  Files          63       63
  Lines        6276     6276
==========================================
- Hits         5084     4824     -260
- Misses       1192     1452     +260

Impacted Files
Coverage Δ

stixcore/io/fits/processors.py
61.20% <ø> (-15.03%)
:arrow_down:

stixcore/io/fits/tests/test_processors.py
100.00% <ø> (ø)

stixcore/soop/manager.py
93.12% <100.00%> (ø)

stixcore/products/levelb/binary.py
55.29% <0.00%> (-39.42%)
:arrow_down:

stixcore/processing/LBtoL0.py
43.61% <0.00%> (-26.60%)
:arrow_down:

stixcore/config/config.py
81.48% <0.00%> (-18.52%)
:arrow_down:

stixcore/processing/L1toL2.py
51.72% <0.00%> (-17.25%)
:arrow_down:

stixcore/processing/L0toL1.py
56.81% <0.00%> (-14.78%)
:arrow_down:

stixcore/products/product.py
71.93% <0.00%> (-14.16%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Incorrect syntax when Generate SQL > Insert/Update is used for composite type columns

System information:

DBeaver version 21.1.2

Connection specification:

Database name and version Yugabyte SQL, PostgreSQL

Describe the problem you're observing:

When generating SQL Insert/Update statement for table with composite type, wrong type of brackets is generated.
Also value from text type sub column is not quoted.

Steps to reproduce, if exist:

Create a table with composite type column
Generate SQL Insert statement
Try to execute in SQL Editor

Expected: Query is executed
Actual: Error because [ ] should be replaced with ( ) and String is not quoted.

The same error in syntax when exporting composite columns as SQL script

Closed as duplicate https://github.com/dbeaver/dbeaver/issues/14314


Define the "Enzyme"-like cloud-agnostic API for Modin

Define main abstractions as IaC and reuse

Instance
Action
Storage
State
Runtime
Template DB

Closing this as stale for the same reason as https://github.com/modin-project/modin/issues/1484#issuecomment-1219511330


Update failuredomain regexp and prevent race condition while removing failure domain

Issue #, if available:
Add cluster condition status checking in failure domain removing logic.
Prevent one race condition that machine can be allocated to a failure domain that just being deleted.
Description of changes:
Enhance failure domain removing logic.
Don't remove machine when cluster status is ready.
Don't deploy VM in a failuredomain that is deleted.
Testing performed:
Unit testing and manual testing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
Base: 37.06% // Head: 37.23% // Increases project coverage by +0.17% :tada:

Coverage data is based on head (263dbc1) compared to base (e8988e4).
Patch coverage: 64.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   37.06%   37.23%   +0.17%
==========================================
  Files          42       42
  Lines        3327     3352      +25
==========================================
+ Hits         1233     1248      +15
- Misses       1925     1937      +12
+ Partials      169      167       -2

Impacted Files
Coverage Δ

controllers/cloudstackmachine_controller.go
59.29% <47.05%> (-1.00%)
:arrow_down:

controllers/cloudstackfailuredomain_controller.go
62.17% <100.00%> (+10.15%)
:arrow_up:

...ontrollers/cloudstackisolatednetwork_controller.go
8.51% <0.00%> (-27.66%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Documentation needs search

I'm very intrigued by Moon, given the size/functionality ratio. Unfortunately, the documentation right now is in serious need of some search, either Algolia or even Lunr.
I read in the docs that Moon supports computed properties as well, but to find how to use it, I resorted to Github search and found the example in tests.

Hey @luminarious
Totally agree, the docs aren't even complete! There is still a lot of the API to get covered. I have yet to do the computed properties (as you said), a couple more directives in-depth, and more details on components.
Right now, the best place to find information is in the API docs, it has most of the instance and global methods, along with all of the directives. I'm planning to add a search also, and I'll keep everyone posted on the status of the site.

@KingPixil is http://moonjs.ga/ open source so that people could contribute to the docs there?

I second @awitherow 's request!

Of course! The docs are in the gh-pages branch.

Finally added search, sorry it took so long. It came along with v0.10.0


Convert repo into NPM module

As the main dev work for the wrapper is complete, this ticket will focus on migration to an NPM module.

Re opening until github action file is setup for CD of package and also until package is officially published.

Re opening until github action file is setup for CD of package and also until package is officially published.


Support for failover/redundancy in traffic stats

Currently Traffic Stats runs a single instance.  If it were to fail it would mean that stats would not get written to influxDB.  We should support some sort of failover or redundancy.

Resolved.


[TEST] This should panic on AddressPRefixes used for master subnets

Do not merge
Should panic; testing theory with e2e.

panics as expected.  Test failed successfully :)


[SPARK-10435] Spark submit should fail fast for Mesos cluster mode with R

It's not supported yet so we should error with a clear message.

+1

Merged build triggered.

Merged build started.

Test build #41981 has started for   PR 8590 at commit 18f82d2.

Are any cluster mode deployments supported for R/could we make it more general?

YARN is supported

Test build #41981 has finished for   PR 8590 at commit 18f82d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41981/
Test PASSed.

merging into master


[#2708] 1.6.1-RC1 release

(1.6.1-SNAPSHOT -> 1.6.1-RC1)

Codecov Report

Merging #2724 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
+ Coverage   40.74%   40.75%   +0.01%
==========================================
  Files        1773     1773
  Lines       61124    61124
  Branches     8589     8589
==========================================
+ Hits        24905    24914       +9
+ Misses      36219    36210       -9

Impacted Files
Coverage Δ

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
72.22% <0%> (-11.12%)
:x:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.68% <0%> (-1.52%)
:x:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
88.05% <0%> (-1.5%)
:x:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
79.06% <0%> (+1.16%)
:white_check_mark:

.../profiler/sender/StandbySpanStreamDataStorage.java
81.35% <0%> (+1.69%)
:white_check_mark:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
86.25% <0%> (+2.5%)
:white_check_mark:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
78.31% <0%> (+7.22%)
:white_check_mark:

...pinpoint/rpc/ChannelWriteFailListenableFuture.java
71.42% <0%> (+14.28%)
:white_check_mark:

...npoint/rpc/server/SimpleServerMessageListener.java
100% <0%> (+20%)
:white_check_mark:

.../com/navercorp/pinpoint/rpc/packet/PongPacket.java
71.42% <0%> (+21.42%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7ca6c...e80c503. Read the comment docs.


Body Fat Prediction

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Body Fat Prediction
:red_circle: Aim : Create a ML model, for predicting the body fat.
:red_circle: Dataset : https://www.kaggle.com/fedesoriano/body-fat-prediction-dataset
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.
A Demo Project has been created to guide you about the whole structure of presenting the Project in this repository. Here's the link of the Demo Project - https://github.com/abhisheks008/ML-Crate/tree/main/Project-Demo-Folder

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
Are you a participant of SWOC 2.0?

[ ] YES
[ ]  No

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Full name : Tandrima Singha
GitHub Profile Link: https://github.com/tandrimasingha
Approach for this Project: Creating an ML model, for predicting the body fat using regression
Are you a participant in SWOC 2.0?
YES

Issue assigned to you @tandrimasingha


Be able to disable autosave

Current behavior
First of all, thanks a lot for Livebook, this is amazing! 🙂
As there isn't a way to undo changes today, autosave can be very destructive.
I deleted a section by accident, and everything was gone and got persisted to the file.
Expected behavior
If we can disable autosave, mistakes can be prevented from persisting automatically.
Thanks!

Tip: in the edge version of Livebook deleting a section requires a confirmation, and also you need to explicitly specify to delete the cells, so it should be less likely to do it by accident. Also undo feature should be in place soon (today/tomorrow) :)

Wow @jonatanklosko, things are moving fast 🤯 🚀
Great stuff man, I'll let you close this or as you see fit.
Thanks again!

With the latest changes the underlying issue should be addressed. Also, making autosave configurable is already a part of #203, so I'm going to close this one :)


Adds renovate configuration to repo - hacktoberfest

Hacktoberfest Title
Adds renovate configuration to repo.
Description of what's changing
Uses much of the methods described in this document (https://docs.google.com/document/d/1aJ3eIpX65tgyIwPL1Pympm0Qsz-phhXVfT5RhAmXM_M/edit#) and sets up the repo to use renovate to manage dependencies.
This suggested configuration will

Group PR's into two groups, Major and Minor/Patch
It will NOT auto-merge (but you can change this at anytime by setting automerge to true
Allows Renovate to manage ALL dependencies
Uses the chore commit type

What else might be impacted?
No other impact; however, this PR will not actually take affect until you merge this PR and then add the repo to the Renovate service (https://github.intuit.com/github-apps/renovate-pro/). Once both are done, you will start seeing PR's being generated by Renovate. They will not be merged automatically, and they will be in two groups to help make it easier to manage the dependency PRs: Major, and Minor/Patch.
Which issue does this PR relate to?
#26
Checklist
[x] Tests are written and maintain or improve code coverage - N/A
[x] I've tested this in my application using yarn link (if applicable) - N/A
[x] You consent to and are confident this change can be released with no regression - N/A

@joshharrison626 Not sure why the PR build is failing. We saw this issue with another PR as well but do not exactly know the root cause yet. https://github.com/intuit/user-data-for-fraud-prevention/pull/74. Do you have any idea what could be the issue?

I don't see why the CI job is failing on this PR. @skodamarthi any ideas? Can we just go ahead and merge this anyway?

Sorry I don't have access to circle-ci to help troubleshoot the test failures.

No worries @joshharrison626 - this definitely isn't an issue with your PR. We're working to fix the CI issue and I am confident merge this PR before hacktoberfest ends

Just wanted to check in and see if there was anything you need from me for this PR. Thanks!

Thanks @joshharrison626.. merging this PR now. I and @reubenae will do the configuration changes on Renovate to add our repo sometime next week. We will get back to you if we have any questions.

Very cool, and yes, I'm happy to help finish the renovate setup if you need help.

Could you please add the hacktoberfest-accepted label to this PR?

@joshharrison626 done, though we've registered this repo for hacktoberfest so it shouldn't be required for it to show up in your stats. Thanks for the contribution!


Napari [Mac ARM build] interface bug

🐛 Bug Report
I used the latest available build [0.4.19]. The Install by name/url field is missing in the build, whereas if I install with python it is showing.

But the main reason I was looking for that field was due to not being able to install napari-skimage.

This problem only exists in the app.
💡 Steps to Reproduce
Reproducible by opening the Install/Uninstall plugins window.
💡 Expected Behavior
No response
🌎 Environment

💡 Additional Context
No response

Could you clarify that you are referring to the bundle app:
https://napari.org/stable/tutorials/fundamentals/installation.html#install-as-a-bundled-app
If so, the lack of napari-skimage is likely due to the fact that the bundled app installs from conda-forge and not pypi. So until that plugin is on conda-forge it will not be installable in the bundled app via the GUI.
I am puzzled why the path option is gone, this could be also related to the use of conda for installing.
I will transfer this issue to the bundled app repo.


Virtualbox 5.0 not supported

The latest Docker Toolbox installs Virtualbox 5.0 so when I go to start up Lattice 0.5.0 after installing Docker toolbox, I get the following error:
Vagrant has detected that you have a version of VirtualBox installed
that is not supported. Please install one of the supported versions
listed below to use Vagrant:

4.0, 4.1, 4.2, 4.3

Hey @mikegehard,
What version of Vagrant do you have installed? I believe 1.7.3 is necessary to run Virtualbox 5.
It might also be worth noting that we're releasing Lattice 0.6.0 (which comes with the Virtualbox 5 guest additions and has more stable cluster components) later this week.

Thanks for the quick response.
I am running Vagrant 1.5.4 so it looks like I may be out of date. It makes
sense that Vagrant would be giving me that error and not Lattice.  :-)
I'll work on a pull request for the README (unless you have another place
for it) that let's people know about the issue.
Looking forward to Lattice 0.6.0.
On Mon, Oct 19, 2015 at 3:05 PM, Stephen Levine<EMAIL_ADDRESS>wrote:

Hey @mikegehard https://github.com/mikegehard,
What version of Vagrant do you have installed? I believe 1.7.3 is
necessary to run Virtualbox 5.
It might also be worth noting that we're releasing Lattice 0.6.0 (which
comes with the Virtualbox 5 guest additions and has more stable cluster
components) later this week.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry-incubator/lattice/issues/220#issuecomment-149347312
.

See #221

Thanks for submitting this PR, sorry for the confusion around the merge.  The v0.6.0 build is brand new but hasn't been published yet on Github.  Take a look!  It's available for download at http://lattice.s3.amazonaws.com/nightly/lattice-bundle-v0.6.0.zip and instructions for getting the CLI served by the cluster are at https://github.com/cloudfoundry-incubator/lattice-release#install-the-lattice-cli.
I'm gonna close this issue as the website change should address this with v0.6.0.
@davidwadden


[$500] Random empty chats are showing in LHN in focus mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709737869001459
Action Performed:

Open app and sign in with an account with preference set focus
Look at the LHN

Expected Result:
Should not display any random emptychats
Actual Result:
10s of random empty state chats in the LHN, with no way to remove the chats from the LHN view
Note: They seems to be the members of the workspace room I am in
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011e45e5cf4631d0fd
Upwork Job ID:<PHONE_NUMBER>242297344
Last Price Increase: 2024-04-11

I was also able to recreate this yesterday — getting eyes on this!

@tienifr Thanks for the proposal. Your RCA is not correct.

the "unread" report will always show in LHN, even if it's empty

An empty report should not be considered as unread in the first place (there is nothing unread about it)

@m-natarajan I have a bit of a hard time reproducing this issue.
Here's what I did to reproduce this issue:

login
go to profile -> preferences -> priority mode
switch priority mode to "#focus"
return to chat

I do have 3-4 chats with other sub-accounts which are empty. As expected, they are not showing up.
Only if I create a new chat I see this one empty. As expected, it is hidden as soon as I leave it.
App Version 1.4.53-2

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0137c55e8ae1d137a8

@tienifr Thanks for the update. The RCA makes sense and so the solution. Is there a specific case where lastReadTime is empty? (I'm not able to reproduce the bug)

Not really able to reproduce, always getting the lastReadTime same as the lastVisibleActionCreated.
Regarding the unread logic, I have asked in Slack to confirm the expected behaviour in such cases https://expensify.slack.com/archives/C01GTK53T8Q/p1710865076998169

Yes, I even tried creating a chat while signed out. After signing in I still find lastReadTime set. Probably getting the report via pusher, not sure why the last read time is set though. In any case we shall confirm the unread expected behaviour maybe it's expected that new chats appear as unread? (slack thread)

@tienifr Often the best thing to do is nothing. Perhaps this is no longer reproducible.

@m-natarajan Can you please retest if this is still reproducible from your end?

@m-natarajan, based on the comment here, can you test to see if this is still reproducible by EOD? Thanks!

@m-natarajan bump on the above ^^ thanks!

Issue not reproducible during KI retests. (First week)

Can we close this for now and reopen if this resurface again?

Sounds good @s77rt 👍

Agreed. Let's reopen this

Sorry about that! Reopening now!

@tienifr Let's get this fixed
🎀 👀 🎀 C+ reviewed
Link to proposal

There're other ways to check if the report is empty as well, like checking the length of the chat's reportActions, or check if the reportActions contains only the report creation action.

That sounds better to me (we can say the chat is empty if it has 0 or 1 reportActions). Maybe we should do this same update in that other spot?

isInGSDMode

I'm not sure why we named this like that, but seeing as it's called "focus" mode through the stack, let's name this to isInFocusMode

The proposal sounds fine, but why is the API returning these empty chats? Or is it that these empty chats were present locally in Onyx before switching to focus mode?

Not overdue. Issue was just reopened. Almost there

Also experiencing this, would love it fixed. Are we sure this isn't a regression somehow? cc @puneetlath I feel like in the past you had worked on this.

To keep this moving @s77rt can you provide an update on the PR by EOD today? Thanks!

PR is ready for merge

Issue not reproducible during KI retests. (First week)

PR is still in the review process.

If we can't reproduce the issue, should we close this?

This one is not easily reproducible, we closed it before but a got a new one with same root cause. Thus this has been reopened (to handle the other case).

Plan is to be merged on Monday after the merge freeze 🎉

@s77rt can you have the checklist completed ASAP, so this does not delay payment? Thanks!

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/13419
The offending PR has been commented on: https://github.com/Expensify/App/pull/13419#discussion_r1602425171
A discussion in #expensify-bugs has been started: Not needed, unique bug
Determine if we should create a regression test for this bug: No, the bug is hard to reproduce and shouldn't resurface

Payment Summary
@s77rt — paid $500 via Upwork
@tienifr — paid $500 via Upwork
Since a regression test is not needed, this can be closed. Thanks!


Remove dependency on @mui/styles

Fixes #232.

Changes proposed in this Pull Request:

Remove dependency on @mui/styles

To Test:

cd mui && yarn start
Make sure the demo still works and all of the icons are rendered

converting to a draft to refactor this in hopes of avoiding the addition of a peer-dependency (tss-react), which would result in needing a major upgrade

Whenever I run the commands cd mui && yarn && yarn start I see this type-related warning.

Have you seen this before?  Anything missing from the instructions?

@emclaug2 things are running fine on my end from a fresh clone


K Ordered LCS in Java

💥 Proposal
I would like to add K-ordered LCS using DP in Java.
Have you read the Contributing Guidelines on Pull Requests?
Yes.

/assign


Update implementation directory suggestion

Fixes #1

I don't think the documentation is wrong.
Imagine X is /home/nate/proj/coolapp. The documentation then reads as follows:

To implement the .meta standard, a tool looking for its configuration file in directory /home/nate/proj/coolapp and failing to find it should next look in directory /home/nate/proj/coolapp/.meta, if it exists, for that same file.

Ah yes I believe @strager is correct and I misread the intent of the doc.


optimizer: multi join rule should absorb filter

Otherwise some joins won't be merged together in this phase? We should have a stage to pull-up filters (or simply let multi join to absorb these filters into the condition). Otherwise some joins might not be processed by multi join rule.
e.g. if some queries generate plans like this before multi join stage:
Join
  Filter
    Join
      TableScan
      TableScan
  TableScan

The MultiJoin rule won't be able to reorder these two joins.

I believe the predicate pushdown rule ought to already push down the filter into the join condition?
Can add a regression test.


Update dotnet-packages.csv

added migration guide for service bus

@lilyjma unfortunately we made a number of changes to the packages.csv files since you opened this PR. It will probably be easier to just start over and add the links on top of the latest changes to these files to handle the conflicts.

Added these changes to https://github.com/Azure/azure-sdk/pull/4308


core-plugin-api: Deprecate Plugin register and output

Hey, I just made a Pull Request!
Deprecated register option of createPlugin and the outputs methods of the plugin instance.
Introduces the featureFlags property to define your feature flags instead.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

some forgotten api reports it seems!


New Release 0.7.1 or 0.8?

Hello
I am using moquette server 0.7 and it is working fine for me except for one thing: from time to time I got an error like:
java.lang.RuntimeException: Can't find a ConnectionDescriptor for client <paho346225969102440> in cache <{paho347664825952824=ConnectionDescriptor{m_clientID=paho347664825952824, m_cleanSession=true}, TY - 38fa76e767ce3073=ConnectionDescriptor{m_clientID=TY - 38fa76e767ce3073, m_cleanSession=true}}>
	at org.eclipse.moquette.spi.impl.ProtocolProcessor.sendPublish(ProtocolProcessor.java:439)
	at org.eclipse.moquette.spi.impl.ProtocolProcessor.forward2Subscribers(ProtocolProcessor.java:388)
	at org.eclipse.moquette.spi.impl.ProtocolProcessor.executePublish(ProtocolProcessor.java:317)
	at org.eclipse.moquette.spi.impl.ProtocolProcessor.processPublish(ProtocolProcessor.java:301)
	... 11 more

I understand this issue was solved in master branch.
Is it possible to relate a new version of the code? I could use a branch directly but the last version was from july. Perhaps it is time to publish version 0.8
Pablo

Hi Pable,
before the release I would terminate the refactoring of persistence
classes, solve some bugs and perhaps introducing RxJava as a mechanism to
execute the Interceptors.
The release should be 0.8 and probably by the end of the year.
Andrea
On Mon, Nov 16, 2015 at 8:49 AM, pabloa<EMAIL_ADDRESS>wrote:

Hello
I am using moquette server 0.7 and it is working fine for me except for
one thing: from time to time I got an error like:
java.lang.RuntimeException: Can't find a ConnectionDescriptor for client  in cache <{paho347664825952824=ConnectionDescriptor{m_clientID=paho347664825952824, m_cleanSession=true}, TY - 38fa76e767ce3073=ConnectionDescriptor{m_clientID=TY - 38fa76e767ce3073, m_cleanSession=true}}>
at org.eclipse.moquette.spi.impl.ProtocolProcessor.sendPublish(ProtocolProcessor.java:439)
at org.eclipse.moquette.spi.impl.ProtocolProcessor.forward2Subscribers(ProtocolProcessor.java:388)
at org.eclipse.moquette.spi.impl.ProtocolProcessor.executePublish(ProtocolProcessor.java:317)
at org.eclipse.moquette.spi.impl.ProtocolProcessor.processPublish(ProtocolProcessor.java:301)
... 11 more
I understand this issue was solved in master branch.
Is it possible to relate a new version of the code? I could use a branch
directly but the last version was from july. Perhaps it is time to publish
version 0.8
Pablo
—
Reply to this email directly or view it on GitHub
https://github.com/andsel/moquette/issues/127.

@andsel It would be nice to release 0.8-SNAPSHOT(nightly build) until we will get 0.8 release.

Hello Andsel.
Thanks for the update. My problem is this: I am using moquette for a product that will go online in december and I am getting those exceptions. They disconnect some servers (connected using java paho). Is it possible to have a 0.7.1 release with the needed patchs applied?
I could help preparing such release. It would be a release with only those fixes.
The reason I am insisting with a release is that there is no way my company uses an arbitrary git revision.
Perhaps other people ( @jkandasa ? :) ) could help to prepare a release branch with the patches we need.

Hi @pabloa,
we could remove some part from 0.8 and make the 0.8-SNAPSHOT the official
0.8 release, moving some feature to a next 0.9.
Could you do some test with the current master and check if it fixes your
bug? If so we could think about it.
Andrea
On Mon, Nov 16, 2015 at 9:43 PM, pabloa<EMAIL_ADDRESS>wrote:

Hello Andsel.
Thanks for the update. My problem is this: I am using moquette for a
product that will go online in december and I am getting those exceptions.
They disconnect some servers (connected using java paho). Is it possible to
have a 0.7.1 release with the needed patchs applied?
I could help preparing such release. It would be a release with only those
fixes.
The reason I am insisting with a release is that there is no way my
company uses an arbitrary git revision.
Perhaps other people ( @jkandasa https://github.com/jkandasa ? :) )
could help to prepare a release branch with the patches we need.
—
Reply to this email directly or view it on GitHub
https://github.com/andsel/moquette/issues/127#issuecomment-157163609.

@andsel Could you please give some rough estimate when we can get 0.8-SNAPSHOT version?

Hello @andsel
After 3 days of testing, revision fdf5b03 solved the issues I had. It looks solid enough too.
I vote +10 for a 0.8 release.
Pablo

Hi @pabloa
I've just terminated an important refactoring on the storage part, separating the session store and the message store, could you retry your check please.
If it works well I'm going to move the namespace (from org.eclipse.moquette to io.moquette, it's an Eclipse Foundation explicit request) and bump the 0.8 release.
Thanks, I wait for news from you
Andrea

Hi @pabloa
I've just terminated an important refactoring on the storage part, separating the session store and the message store, could you retry your check please.
If it works well I'm going to move the namespace (from org.eclipse.moquette to io.moquette, it's an Eclipse Foundation explicit request) and bump the 0.8 release.
Thanks, I wait for news from you
Andrea

ok. Testing it.
Pablo

It works! :+1:


Add support to basic auth in horreum clients

Feature idea.
with the introduction of #1711 Add machine account is now possible for clients to log in with basic authentication for these machine accounts.
Additional information
there may be some deployments where machine accounts are still manged in OIDC provider, and therefore we cannot remove that option.

Fixed in Hyperfoil/Horreum#1813
ported to Hyperfoil/horreum-client-golang#27 Hyperfoil/horreum-client-python#23


fix(tcgdiskstat): Error on invalid output format

:tada: This PR is included in version 0.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BM] Alternative Analysis

This is the initial User history for the project BatteryMonitor:
Feature: Develop a Java Battery Monitor process to protect Hardware.

Scenario: EV3Dev Startup
Given A EV3Dev platform (EV3, Brickpi & PiStorms)
When The user turn on the Brick
Then A Java process will start monitoring the battery

Scenario: Default configuration
Given A EV3Dev platform (EV3, Brickpi & PiStorms)
When The user turn on the Brick
Then A Java process will start using default configuration.
The default configuration is:
- THRESHOLD_VOLTAGE = 7.5v
- LINUX_ACTION = `sudo shutdown now`

It is necessary to analyze the possible alternatives to implement the battery monitor using Java 8.
Feature: Alternative analysis to implement Battery Monitor

Scenario: Initial
Given A Specification for Battery Monitor
When The team try to implement the solution
Then It is necessary to analyze the possible alternatives with Java 8

Related issue:
https://github.com/ev3dev-lang-java/ev3dev-lang-java/issues/229

Battery Monitor is a simple Java process using Threading solution. In order to manage the threads, we will use an ExecutorService and a Executor.newSingleThreadExecutor() because we only have to manage a single Thread.
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ExecutorService.html
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/Executors.html#newSingleThreadExecutor--

The solution was tested with Success.


Hello

Hello
Thank for knuff framework.
So I install pod "Knuff" to my app.
And try send push to this app. I copy token and choose my certificate.
But I have error 400: DeviceTokenNotForTopic
How I can fix this?

My guess is that your token is for another App ID, please make sure that your app is signed and run with the correct provisioning profile.

Thanks for answer now I try one more time


Timesheet - 25/04/2021 - Bojan Ilijevski

Task 1
Managing social media
Answering private messages on Instagram and Facebook
Following/Unfollowing people on social media
Time Spent
1 hour

Total Time Spent
1 hour
Account Number
b1b1e90107d804e5317c8527129ceaededdcb162a6737112b88712742a08bb72

Approved


Remove advertisements

No point in having them if they make no money. They will be removed and replaced with a special support notice on the home screen.

Fixed 1.41