develop branch: limits.h is required for INT_MAX

The develop branch fails to build for me at this moment (within my libc build) due to INT_MAX being referenced but not defined. I notice that limits.h is wrapped in an #ifdef, but it is needed unconditionally for INT_MAX.
#ifdef PRINTF_SUPPORT_MSVC_STYLE_INTEGER_SPECIFIERS
#include <limits.h>
#endif

Not knowing what you're up to on that branch, I just wanted to bring this to your attention rather than blindly try to fix it :).

I reviewed everything and think you should just include those headers anyway - PR opened.

Why do you believe I need those headers anyway? INT_MAX is only used when MSVC-style specifiers are supported.

Without PRINTF_SUPPORT_MSVC_STYLE_INTEGER_SPECIFIERS, the code fails to compile for me because it is referencing INT_MAX.
FAILED: printf_tests.p/printf_test_test_suite.cpp.o
ccache c++ -Iprintf_tests.p -I. -I.. -I../printf/test -fcolor-diagnostics -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -std=c++11 -O2 -isystem../printf/src -MD -MQ printf_tests.p/printf_test_test_suite.cpp.o -MF printf_tests.p/printf_test_test_suite.cpp.o.d -o printf_tests.p/printf_test_test_suite.cpp.o -c ../printf/test/test_suite.cpp
In file included from ../printf/test/test_suite.cpp:30:
../printf/src/printf/printf.c:1171:67: error: use of undeclared identifier 'INT_MAX'
          printf_size_t l = strnlen_s_(p, precision ? precision : PRINTF_MAX_POSSIBLE_BUFFER_SIZE);
                                                                  ^
../printf/src/printf/printf.c:250:41: note: expanded from macro 'PRINTF_MAX_POSSIBLE_BUFFER_SIZE'
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
                                        ^
../printf/src/printf/printf.c:1250:43: error: use of undeclared identifier 'INT_MAX'
  return _vsnprintf(&out_putchar, buffer, PRINTF_MAX_POSSIBLE_BUFFER_SIZE, format, arg);
                                          ^
../printf/src/printf/printf.c:250:41: note: expanded from macro 'PRINTF_MAX_POSSIBLE_BUFFER_SIZE'
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
                                        ^
../printf/src/printf/printf.c:1255:36: error: use of undeclared identifier 'INT_MAX'
  return _vsnprintf(out_buffer, s, PRINTF_MAX_POSSIBLE_BUFFER_SIZE, format, arg);
                                   ^
../printf/src/printf/printf.c:250:41: note: expanded from macro 'PRINTF_MAX_POSSIBLE_BUFFER_SIZE'
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
                                        ^
../printf/src/printf/printf.c:1260:43: error: use of undeclared identifier 'INT_MAX'
  printf_size_t usable_buffer_size = (n > PRINTF_MAX_POSSIBLE_BUFFER_SIZE) ? PRINTF_MAX_POSSIBLE_BUFFER_SIZE : n;
                                          ^
../printf/src/printf/printf.c:250:41: note: expanded from macro 'PRINTF_MAX_POSSIBLE_BUFFER_SIZE'
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
                                        ^
../printf/src/printf/printf.c:1260:78: error: use of undeclared identifier 'INT_MAX'
  printf_size_t usable_buffer_size = (n > PRINTF_MAX_POSSIBLE_BUFFER_SIZE) ? PRINTF_MAX_POSSIBLE_BUFFER_SIZE : n;
                                                                             ^
../printf/src/printf/printf.c:250:41: note: expanded from macro 'PRINTF_MAX_POSSIBLE_BUFFER_SIZE'
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
                                        ^
../printf/src/printf/printf.c:1267:76: error: use of undeclared identifier 'INT_MAX'
  return _vsnprintf(out_wrapped_function, (char*)(uintptr_t)&out_fct_wrap, PRINTF_MAX_POSSIBLE_BUFFER_SIZE, format, arg);
                                                                           ^
../printf/src/printf/printf.c:250:41: note: expanded from macro 'PRINTF_MAX_POSSIBLE_BUFFER_SIZE'
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
                                        ^

Around line 244 in my fork's current state:
// The printf()-family functions return an `int`; it is therefore
// unnecessary/inappropriate to use size_t - often larger than int
// in practice - for non-negative related values, such as widths,
// precisions, offsets into buffers used for printing and the sizes
// of these buffers. instead, we use:
typedef unsigned int printf_size_t;
#define PRINTF_MAX_POSSIBLE_BUFFER_SIZE INT_MAX
  // If we were to nitpick, this would actually be INT_MAX + 1,
  // since INT_MAX is the maximum return value, which excludes the
  // trailing '\0'.


When I run the code on the same images provided the output is mostly red with a little blue!

Hi All,
This is an amazing piece of code, I am exploring stereo depth estimators at the moment and this is the best so far. However, I am having an issue when I run the code. I firstly download it from GitHub and then I open the data folder (1,2 and 3) and delete the disparities and the combined.
I then run the code for each folder by changing this:
DATASET = "data/1"
But then the output for each dataset is mostly red, like this.
Data Folder 1:
My Output (1st Frame):

What it should look like:

Data Folder 2:
My Output (1st Frame):

What it should look like:

Data Folder 3:
My Output (1st Frame):

What it should look like:

I hope that you can help!
Thanks
Aiyush

Hello Aiyush,
I'm having the same issue. Did you figure it out?

Hello @Aiyush-G
I'm facing the same issue. Did you figure it out?

Same issue here. Still not solved.

try to play with the lambda and the sigma parameter in the source code. These parameters worked well with me:
wls_filter.setLambda(80000)
wls_filter.setSigmaColor(3.6)


⚠ SolarOscp has degraded performance

In e459227, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 312 ms

Resolved: SolarOscp performance has improved in b355075 after 10 minutes.


feat(Layout): introduce notification banner

Related Ticket(s)
Refs #685.
Description
Adds notification banner to the page layout. The corresponding carbon website code hard-codes the banner content and did't see a quick good way to parameterize it, so I kept it hard-coded for now.
(I'm new to the codebase and just thought if I can be of any help on this - Feel free to point out if I shouldn't have done this, or anything that should be rectified)
Changelog
New

Notification banner to the page layout.

As discussed, moved the banner portion to: https://ibm.biz/BdqtN8


Add optional field to title

So that users can tell what fields are optional.

There were the following issues with your Pull Request

Commit: e90681c70263e78409e5adebefc22692c6418608
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/ministryofjustice/fr-staffapp

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: e90681c70263e78409e5adebefc22692c6418608

Your subject line is longer than 50 characters

Commit: 6b60408593a50ad9d5c2cd830c2a0d48b3046c13

Your subject line is longer than 50 characters

Guidelines are available at https://github.com/ministryofjustice/fr-staffapp

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: e90681c70263e78409e5adebefc22692c6418608

Your subject line is longer than 50 characters

Commit: 6b60408593a50ad9d5c2cd830c2a0d48b3046c13

Your subject line is longer than 50 characters

Guidelines are available at https://github.com/ministryofjustice/fr-staffapp

This message was auto-generated by https://gitcop.com

Looks good.  Merge at will


read me v2

added instructions for one-command run
revamped getting started section

@brendan-kellam do we want to add instructions for gitlab/bitbucket (access tokens and config fields) here before merging?


ci: add workflow for pr comment

Signed-off-by: smrpn<EMAIL_ADDRESS>

Codecov Report

Merging #4 (22710ed) into master (97d71e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   79.99%   79.99%
=======================================
  Files          22       22
  Lines        3429     3429
=======================================
  Hits         2743     2743
  Misses        686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d71e3...22710ed. Read the comment docs.


⚠ Samsung has degraded performance

In b11753f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2416 ms

Resolved: Samsung performance has improved in f6f5058.


fix: LSDV-4081: fix incorrect variable name

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[x] Backend (API)
[ ] Frontend

Describe the reason for change
https://github.com/heartexlabs/label-studio/issues/4081
What does this fix?
This commit changed the name of a variable but did not update all locations of it's use in the function.
Does this change affect security?
no
What alternative approaches were there?
Reverting the commit, but then we lose the other work that the commit gave us.
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[x] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Data importing

Also, maybe CONTRIBUTING.md should be updated with the PR title requirements? I am just guessing by looking at other PR titles, and it wasn't in the PR description template.

@makseq this looks like it should be a fairly straight-forward patch to merge.

@Axel-Jacobsen thanks for your contribution!


trufflehog detect 2 leaks and gitleaks detect it as 1 leaks

Hello,
I just scanned gronit repo using gitleaks and trufflehog. And i noticed that trufflehog detect 2 leaks and gitleaks detect its as 1 leak. Can you explain for me why ?

gitleaks --verbose --pretty --repo=https://github.com/gitleakstest/gronit

INFO[2020-09-27T22:59:44+01:00] cloning... https://github.com/gitleakstest/gronit
Enumerating objects: 135, done.
Total 135 (delta 0), reused 0 (delta 0), pack-reused 135
{
        "line": "const AWS_KEY = \"AKIALALEMEL33243OLIAE\"",
        "lineNumber": 15,
        "offender": "AKIALALEMEL33243OLIA",
        "commit": "cb5599aeed261b2c038aa4729e2d53ca050a4988",
        "repo": "gronit",
        "rule": "AWS Manager ID",
        "commitMessage": "fake key",
        "author": "Zachary Rice",
        "email"<EMAIL_ADDRESS>        "file": "main.go",
        "date": "2018-02-04T19:10:58-06:00",
        "tags": "key, AWS",
        "operation": "addition"
}
WARN[2020-09-27T22:59:46+01:00] 1 leaks detected. 33 commits scanned in 70 milliseconds 46 microseconds

trufflehog --regex --entropy=False https://github.com/gitleakstest/gronit

~~~~~~~~~~~~~~~~~~~~~
Reason: AWS API Key
Date: 2018-02-05 01:43:28
Hash: eaeffdc65b4c73ccb67e75d96bd8743be2c85973
Filepath: main.go
Branch: origin/master
Commit: remove fake key
AKIALALEMEL33243OLIA
~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~
Reason: AWS API Key
Date: 2018-02-05 01:10:58
Hash: cb5599aeed261b2c038aa4729e2d53ca050a4988
Filepath: main.go
Branch: origin/master
Commit: fake key
AKIALALEMEL33243OLIA
~~~~~~~~~~~~~~~~~~~~~

Basic Info :

OS: Ubuntu 20.04 LTS
Gitleaks Version: v6.1.2

Thank you.

@khalid-lemghari by default gitleaks does not check deletions. Use the --include-deletion option for parity with trufflehog:
gitleaks --verbose --pretty --repo=https://github.com/gitleakstest/gronit --include-deletion is what you're looking for


Please clarify the use of content-available in the payload doc

I'm referring to issue https://github.com/phonegap/phonegap-plugin-push/issues/820 and https://github.com/phonegap/phonegap-plugin-push/issues/1577
@macdonst It might be helpful for all of us if you could clarify the required form of the content available property for both iOS and Android in the payload doc (https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md).
In the doc, there are actually two forms of the property content_available and content-available, so which is the right one? In the threads mentioned above yourself sometimes use one version or the other.
For the value of this property, there are "1", 1 and true, which is the correct one? Is there any different use expected for iOS and Android?

@bardu for Android: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#background-notifications
for ios: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#background-notifications-1
Let me know what is not clear.

https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#use-of-content-available-true
This part mentions content_available and content-available in a mixed fashion, we could use clarification there. The rest seems okay to me.

I agree, the comunity needs a clear example of usage for Android and iOS, using FCM and APNS, I follow the examples of the payloads docs but is very difficult to get the expected result.
I have opened #1833 for this reason, I tested with FCM and APNS, works fine except on iOS but I have lost many hours of work for this reason.


signTransaction should return r, s, and v without leading 0's

i got a error dialog with prompt "non-canonical integer (leading zero bytes) for *big.Int, decoding into (types.Transaction)(types.txdata).R" while send tokens using emerald-wallet.
it happens occasionally.
related issues:
https://github.com/ethereum/web3.js/issues/1126
https://github.com/ethereum/web3.js/issues/1170
https://github.com/ethereum/web3.js/pull/1288

@gagarin55  what's the implemention of your rpc interface "emerald_signTransaction"?

For now it uses this RPC method - https://github.com/ETCDEVTeam/emerald-rs/blob/master/docs/api.md#emerald_signtransaction
Thank you for reporting, we will check provided notes


fails if trying to include unicode in self.report message

I like to write rules to copy the problematic cell into the message for self.report().
If the problematic code includes unicode, then this results in an error

'ascii' codec can't encode character u'\xf3' in position 104: ordinal not in range(128)

I think this stems from RfLint.format() where it calls self.args.format.format().
But, self.args.format is an ascii string, so when formatting, it can't insert the unicode text into it.

Thanks for the report!
On Fri, Jul 14, 2017 at 7:21 AM, Nicholas Daley<EMAIL_ADDRESS>wrote:

I like to write rules to copy the problematic cell into the message for
self.report().
If the problematic code includes unicode, then this results in an error
'ascii' codec can't encode character u'\xf3' in position 104: ordinal not
in range(128)
I think this stems from RfLint.format() where it calls
self.args.format.format().
But, self.args.format is an ascii string, so when formatting, it can't
insert the unicode text into it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/boakley/robotframework-lint/issues/47, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABEmYhQ8GWvDoV-zmfnGbQrtg4fGO0H_ks5sN10xgaJpZM4OYMAh
.


Add smoking pipe

About the PR

Adds a reusable smoking pipe (using already ported animated sprite)
Retrieves reagents from inserted materials upon lighting
Currently allows ground tobacco and ground cannabis
Added to cigarette machine, DIY smokables crate, and detective trench coat

Screenshots

Changelog

:cl:

add: Added a smoking pipe. Get your Sherlock Holmes on!

looks good

:smoking: :heavy_check_mark:

I really should have run the tests locally before opening. If I can't fix soon, then I'll close and reopen later.

optional stretch goal of letting monkeys wear masks in another PR.

Most of the stuff in Resources/Prototypes/Entities/Objects/Consumable/Smokeables/Pipes/pipe.yml is redundant, and already covered by parenting.

Most of the stuff in Resources/Prototypes/Entities/Objects/Consumable/Smokeables/Pipes/pipe.yml is redundant, and already covered by parenting.

IIRC if you modify anything in a component in a child entity, you have to define all the fields for that component again, or else they will be returned to default values. So everything in SmokingPipe component has to be written out again or be lost, since we added a startingItem. Although, ItemSlots and Container components could probably be dropped from those two.

IIRC if you modify anything in a component in a child entity, you have to define all the fields for that component again, or else they will be returned to default values.

this is not true

Also, don't forget the names and descriptions. Those are also inherited.

IIRC if you modify anything in a component in a child entity, you have to define all the fields for that component again, or else they will be returned to default values.

this is not true

Ah ok. I remember there was some bug a while back where you could put anything in the HOP/Captain PDA slots since the whitelist got overwritten, but maybe it was due to something else.

Because the whitelist on the inheriting entity is the same field as the whitelist on the parent entity. So then the whitelists aren't merged, but the inheriting whitelist overwrites the parent whitelist. But if you specify field2 on the inheriting entity, and the parent entity has field1, then they will both be applied.

I think I got confused since the bowl_slot field is a component itself, so its nested fields can't draw from the parent (since it is technically defined). All regular (undefined) fields would inherit though.
Thanks for helping me understand!


Slackin Dockerfile is broken

Currently slackin needs reCAPTCHA configuration as per https://github.com/rauchg/slackin/pull/311
If we want our current Dockerfile to work we need to checkout a previous version of Slackin. Adding
RUN git checkout 3ff77b9

before https://github.com/src-d/landing/blob/master/Dockerfile.slackin#L15 does the trick unless we want to use the last Slackin version with reCAPTCHA integration (which would need further work)
Let me know if you want a PR containing the above change.

I guess we should upgrade then and provide a reCAPTCHA key?

Current workaround in https://github.com/src-d/landing/blob/master/Dockerfile.slackin#L16 (checkout 0.13.1)
Apparently we don't have space in landing for CAPTCHAs, so we don't use it for the moment


feat: add returnRankingInfo option to return ranking info along with results

What: return ranking info along with results
Why: make it possible to highlight the value that was matched so the user better understands why a particular result is being displayed
How: add returnRankingInfo option
I initially thought about adding a mapper function, similar to sorter, but that was much harder to type and I didn't feel like it brought any useful benefits.
Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged

Thanks for this. I just don't see how this can be used to accomplish the highlighting you're looking for. Can you demonstrate that?

I skipped a few implementation details for brevity but I had something like this in mind:
const list = [
  {id: 1, country: 'Italy', counter: 3, value: 1},
  {id: 2, country: 'France', counter: 2, value: 2},
  {id: 3, country: 'Spain', counter: 1, value: 3},
]

const keys = ['country', 'counter', 'value']

function List() {
  const results = matchSorter(list, '3', {
    keys,
    returnRankingInfo: true,
  })

  return <>{list.map(item => <Item item={item} result={results.find(result => result.item.id === item.id)} />)}</>
}

function Item({ item, result }) {
  return (

      {item.country}
      {item.counter}

  )
}

Oh interesting. So you're not highlighting the part of the word that matches, you're just highlighting it if it matches at a certain threshold at all.
You could absolutely do this without changing the implementation of matchSorter:
function List() {
  const results = matchSorter(list, '3', {
    keys,
  })

  return list.map(item => <Item item={item} shouldHighlight={results.find(r => r.id === item.id)} />)

Even if you wanted to only highlight those that match at a certain threshold, you could do that like so:
function List() {
  const results = matchSorter(list, '3', {
    keys,
    threshold: matchSorter.rankings.EQUAL,
  })

  return list.map(item => <Item item={item} shouldHighlight={results.find(r => r.id === item.id)} />)

Or if you wanted to both filter and highlight those that match a certain threshold:
function List() {
  const filtered = matchSorter(list, '3', {
    keys,
  })

  const equalResults = matchSorter(list, '3', {
    keys,
    threshold: matchSorter.rankings.EQUAL,
  })

  return filtered.map(item => <Item item={item} shouldHighlight={equalResults.find(r => r.id === item.id)} />)

I just would prefer to avoid adding extra API surface area for a single use case when there's a reasonable solution without changing anything.

Oh, interesting idea, that works for me! Thanks!

Sure thing!
To be clear, the performance won't be as good because you're calling it twice, but for most practical scenarios that shouldn't be an issue. So I'd rather keep things simple until that's necessitated.


presto generates http-request .log containing records that fail queries on the localfile catalog

The short story
presto> select * from localfile.logs.http_request_log;
... Invalid format: "2017-12-21T00:12:27Z" is malformed at "Z"
Presto is looking for timestamp in yyyy-MM-ddTHH:mm:ss.fffZ format (please note the .fff).
In case the fractional part is missing, presto yields an error.
After editing the log and changing the timestamp to "2017-12-21T00:12:27.000Z" (please note the .000) the query worked fine.
Version
presto-server-0.191
presto-cli-0.191-executable.jar
localfile.properties
connector.name=localfile
presto-logs.http-request-log.location=/var/presto/data/var/log
presto-logs.http-request-log.pattern=http-request.log
connect & run query
./presto --server localhost:8080 --catalog localfile --schema logs
presto:logs> select * from http_request_log;
Query 20171221_104944_00046_yfeuc, FAILED, 1 node
Splits: 17 total, 0 done (0.00%)
0:00 [0 rows, 0B] [0 rows/s, 0B/s]
Query 20171221_104944_00046_yfeuc failed: Invalid format: "2017-12-21T00:12:27Z" is malformed at "Z"
presto:logs>
http-request.log
dumarkov@dumarkov-presto:~/presto$ grep '2017-12-21T00:12:27Z' /var/presto/data/var/log/http-request.log
2017-12-21T00:12:27Z    <IP_ADDRESS>       GET     /v1/service/collector/general   null    1       200     0       36      1       830605f1fcac4d879453552
beeafaf4700000030d6

What does this have to do with Superset? Wong repo?

Yep, should have been PrestoDB
Get Outlook for Androidhttps://aka.ms/ghei36

From: Maxime Beauchemin<EMAIL_ADDRESS>Sent: Thursday, December 21, 2017 5:44:18 PM
To: apache/incubator-superset
Cc: David Markovitz; Author
Subject: Re: [apache/incubator-superset] presto generates http-request .log containing records that fail queries on the localfile catalog (#4105)
What does this have to do with Superset? Wong repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-superset%2Fissues%2F4105%23issuecomment-353383221&data=02|01|Dudu.Markovitz%40microsoft.com|fe230a1472ad4baf727008d54889b322|72f988bf86f141af91ab2d7cd011db47|1|0|636494678606630730&sdata=edG6eDmaT8Kn1ngD3K4MN4xXsU2gwYl82GEuvcqs7rg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZcsSES4QwG1YygurVr_WShirqDTY3KXks5tCnzSgaJpZM4RJq0f&data=02|01|Dudu.Markovitz%40microsoft.com|fe230a1472ad4baf727008d54889b322|72f988bf86f141af91ab2d7cd011db47|1|0|636494678606630730&sdata=xfj5l1VW7QhA5iNxUiDHJE5%2BYw1MJdqWqbBAM8BkkGI%3D&reserved=0.

Typo. Wrong thread


Fix broken link

Clicked on the link and it didn't resolve. I assume you meant this link.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Appreciate the lookout :-) I already fixed this up it turns out, but good look.

If you're watching this repo by the way, note that before we release everything, it's going to get deleted and recreated - just FYI!


AddIdentity and AddAuthentication don't work well together

Hi team,
Not sure if this is a bug or a mutually exclusive issue.  First I like explain my scenario then I'll show you the code that causes the issue.
We have a host service incorporating the IdentityServer  to function as our Idp. We are using the latest .NET Core 2.x versions and we are using ASP.NET Identity and EF see below:
Our goal is to add a few APIs in this service to interact with ASP.NET Identity to register users and create additional clients as the DbContext and Entities are close to our Identities Db. In addition, we want to make these APIs are secure whereby a valid user can access these resources with their access token.
References
<PackageReference Include="IdentityServer4" Version="2.0.5" /> <PackageReference Include="IdentityServer4.AspNetIdentity" Version="2.0.0" /> <PackageReference Include="IdentityServer4.EntityFramework" Version="2.1.0" /> <PackageReference Include="IdentityServer4.AccessTokenValidation" Version="2.1.0" /> <PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="2.0.1" />
Our Start Config looks like this:
`
public IServiceProvider ConfigureServices(IServiceCollection services)
{
services.AddMvc();
       // This screws things up. If we remove it, it works! But we need it.
        services.AddIdentity<AppIdentityUser, IdentityRole>()
            .AddEntityFrameworkStores<AppIdentityDbContext>()
            .AddDefaultTokenProviders();

        services.AddAuthentication(IdentityServerAuthenticationDefaults.AuthenticationScheme)
            .AddIdentityServerAuthentication(options =>
            {
                options.Authority = "http://localhost:5001";
                options.RequireHttpsMetadata = false;
            });

        return services.BuildServiceProvider(validateScopes: true);

}
`
And our Pipeline looks like this:
public void Configure(IApplicationBuilder app, IHostingEnvironment env) {        app.UseAuthentication();        app.UseMvc(); }
Now when we create tokens and pass to other services it works like a charm. However, if we use the same token to call our custom APIs within the hosted Idp, it fails with a 404 not?
We did replace it the Token Validation with MS and works but we prefer to user the IdentityServer4.TokenValidation instead.
Here's what we did to make it work with MS:
 services.AddAuthentication(o => {                 o.DefaultChallengeScheme = Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerDefaults.AuthenticationScheme;                 o.DefaultAuthenticateScheme = Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerDefaults.AuthenticationScheme;             })             .AddJwtBearer(o =>             {                 o.Authority = serverSettings.AuthtorityIssuer;                 o.RequireHttpsMetadata = serverSettings.MetadataRequired;                 o.Audience = "Channelsis-Identity-Api";             });
Any light on this matter will be greatly appreciated.
Thanks
Ross

OK, I finally got it to work! Here's what I had to do:
  services.AddAuthentication(options =>             {                 options.DefaultChallengeScheme = JwtBearerDefaults.AuthenticationScheme;                 options.DefaultAuthenticateScheme = JwtBearerDefaults.AuthenticationScheme;                             })             .AddIdentityServerAuthentication(options =>             {                 options.Authority = serverSettings.AuthtorityIssuer;                 options.RequireHttpsMetadata = serverSettings.MetadataRequired;                 options.EnableCaching = true;             });


Modify the main.yml file to fix Docker error

Docker does not load properly using YUM unless lvm2 is updated first.  Here is the fix.
file:
scale/ansible/roles/common/tasks/main.yml
...

name: Install python-pip
yum: name=python-pip
become: true

name: Update lvm2
yum: name=lvm2 state=latest
become: true

name: Install docker-py
pip: name=docker-py
become: true

name: Install docker
yum: name=docker
become: true
...

Bug from Redhat.
https://bugzilla.redhat.com/show_bug.cgi?id=1294128

This has been fixed in 6304b1eb3f48129418f6a049c723d455784d9b3f


fix chart releaser/linter gh actions

fix chart releaser/linter gh actions
https://github.com/chatwoot/charts/runs/6937897299?check_suite_focus=true

Fixed by https://github.com/chatwoot/charts/pull/66


Liquidity & DEX: Loading...

Actual behavior:
wallet app is slow e.g. when switching from "balances" to "liquidity" it takes a long time ti display data (gets stuck on "Loading..."). After checking with task manager defid.exe has high CPU load (20% or so).
What are your environment parameters?

DeFi Wallet Version: 2.4.0
Operating System (OS): Win 10
– Current free storage capacity: 200 gigs

here is the applog.log

and since defid.exe is stuck it won't let me swap:

Hi @nippur72 , thanks for the screenshot and logs, please give us time to investigate. Both Liquidity and DEX takes about 1min to load with good internet connection before you can use. The team is looking into the issue.

Hello,
I am having the exact same issue, with the same parameters as above
DeFi Wallet Version: 2.4.0
Windows 10
Current free storage capacity: 200 GB
It works fine, but it is painfully slow, Thanks for looking into it

My DEX does often not load at all.
This has always been an issue for me not just on latest V2.4.0

Same on my Windows 10 server, 12 processor, 24 GB RAM, 150 GB free disk space, Tier 3 datacenter in the USA, IONOS. Very slow, adding liquidity takes now about 10 minutes. One time I left the screen because I thought something went wrong. Then I could not do any other action anymore. Error message was that I would have to wait until the other transaction would be done. I waited about 2 hours. Nothing happend. Then I restored the wallet with snapshot. Hung at 99.98% for several hours. That gave me some sweat, because I have substantial funds on the wallet. Then I restored it 2 times again, and it could sync the second time to 100%. Then also the error message was gone. Now I am back to the slow behavior with 10 minutes for 1 single liquidity operation. It takes up to 20 minutes to show the withdrawals in the wallet sums!

Hi @ian309699 @2Dsirecrypto @RadioSteve-dev , can you save your logs and send them here please, thank you.

AppLogs.log

The link for the logs is above. Hope this helps. Thanks

Binary log is not written to disk. Tried it 3 times.

Hi @RadioSteve-dev , you need to specify where to save the log files, in the example above, the files are saved to desktop then .zip together.

I am IT specialist and you can believe me, that I specified location and filenname. Still not written. App log is written, app config is written, no binary log.

I tried also with locked and unlocked wallet.

The functions of the wallet seem to be getting worse.
Not only is it taking a very long time, it is now telling me that I have insufficient funds.
I have plenty of DFI, Also I have plenty of UTXO for the transaction fees.
For Example, I tried to send some DFI to Cake. The app tells me I have insufficient funds When I try and send DFI to myself the app tells me I have insufficient funds

@ian309699 I have the same impression. I also have plenty of UTXOs and the wallet complains that I would not have enough. Then I send again 1 DFI to one of my wallet addresses and it does 1 more liquidity operation. But all takes between 10 and 60 minutes. Incredibly slow. I am on board since the very beginning, but this behavior of the app is new.

Ah, I remember that it did not accept even 1 DFI to be sent from my wallet to my own wallet address. THen I tried 2 DFI and it worked. Slowly.

I tried to send 2 DFI to myself, and the app said I have insufficient UTXO.
Then I tried to send1 DFI to myself to fix the UTXO, and the app said I have an insufficient balance.
I feel like its trapped in a loop

A new experience. I tried just now again to add liquidity and it worked much smoother than some 8 hours ago. The liquidity op took 2 minutes and after 3 minutes in total it was reflected in my wallet data. That is bearable.

I opened up my wallet on another computer, and sent my self 1 DFI, and it worked fine.
Then I went back to my other computer and sent 3 DFI to Cake, and it went through.
very strange.

app config.zip
I opened the wallet again this morning waited for 1/2 hr still nothing
I have attached my log files as requested

Hi,
I upgraded to v2.4.1-rc.1.
My funds are still there updating with rewards. But I can only acccess BCH liquidity.
Also now It does not show receiving addresses in the app at all

I upgraded to 2.4.1-rc1 as well, DEX & Liquidity now load quickly, tough occasionally it can take up to 30 seconds. But it's a great improvement.
@ian309699 I can see my USDT-DFI pool and all the receiving addresses. The only missing thing is the TX history (discussed in another issue).

I cant even access BCH Liquidity anymore.
I have the wallet open on another computer, to test it out, and now it is showing two different DFI amounts, same wallet, same block, two amounts, and still no LM access or receiving addresses

Now I have the same DFI amounts, I fixed that. But I still have the original problem, no LM and no receiving addresses

Hi @ian309699 , can you save your logs and send them please?

here are the logs
AppLogs.log

Hi @ian309699 , well received. Regarding the issue Recipient address is missing #904, the team is in the midst of investigating and fixing, we can further discuss on the issue there. We would like to keep same issues in one thread. Thank you. Also, please look out for the latest announcements on app releases on DeFiChain Announcements (EN).

Hi @nippur72 @ian309699 @2Dsirecrypto @RadioSteve-dev , v2.4.2 is out, this is a mandatory update. Please read through the release notes before updating. Do give a thumbs up to this comment if your issue has been resolved, otherwise, please send new information (include screenshots) and app logs. Thank you.

The update did not fix the issue
My addresses are still missing
and no Liquidity pools ...
the coin amounts are correct and still updating, but no addresses or LM
here are the logs
App Logs.log

Hi @ian309699 , can you try to Rescan? Regarding the issue Recipient address is missing #904, the team is in the midst of investigating and fixing, we can further discuss on the issue there. We would like to keep same issues in one thread. You can post your logs there, thank you.

@izzycsy I upgraded to 2.4.3 but the history it's still not there. Can we reopen this issue? Here are my logs


Allow removal of whildcard ip whitelist

Change summary:

Allow removal of whildcard ip whitelist

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/811

LGTM tho, I've got a question that we only support ip address removal?

we support ip addresses plus wildcard. any others in you mind?

LGTM tho, I've got a question that we only support ip address removal?

we support ip addresses plus wildcard. any others in you mind?

Nope! I was just wondering thanks!!!

Thanks for the fast review, now merging.. @minsulee2 @liayoo


nt missing microtubule terms

PMID:15177031

abolished protein localisation the microtubule plus end during mitotic interphase
probably could do this arrangement for the other microtubule transport:
normal protein movement by microtubule-dependent transport to cell tip

normal protein movement along microtubule to cell tip
normal prtein movement on microtubule tip  to cell tip (probably)

I've added this:
abolished protein localization to microtubule plus-end during mitotic interphase FYPO:0005817
The other two terms look like they overlap with the outstanding part of #2896. I'll move that stuff over there, so we have that discussion all in one ticket, and only have one ticket open for the topic.
edit file: 36f1473d65b88ad80d84642b224c9e25ec1a766e
release: 54c4efe0d431224752d8d09a11bff7486526b729


Remove unnecessary mocks from tests

Many tests use mocks where there's no need for one. Most tests could use the contracts directly. Go through all tests and evaluate if a mock is necessary (for example, when the tested contract is abstract), and remove it where it isn't.
If you do this: THANKS!

@maraoz  Could you help me out understand the issue, so I can help

When the contract is abstract, using a "Mock" (the name mock is not even correct) makes it possible to test it, because abstract tests cannot be instantiated.
But when a contract is not abstract, you could just use the contract in tests, no need to write a "mock".

Mocks are also useful when testing a contract which exposes function modifiers you want to test

I've been looking at this, at least 6 of them. Most of them cannot be easily de-mocked because they lack of external interfaces, so mocha cannot interact with the contract for most of the test cases. LimitBalance.sol and DayLimit.sol looked good candidates for de-mocking. What would you advise?
I've refactored one test, not sure if PR is in order with regards to this issue though. https://github.com/rudygodoy/zeppelin-solidity/commit/549590d10515038c879e251293929c68115d9f6d

@rudygodoy Actually those two can't be de-mocked either because they provide modifiers...
We had the impression that some of them were unnecessary, but might have been wrong. It would be great if you could go through the rest and see if any are indeed unnecessary and remove them. We'd appreciate it!

I went through all of them. Couldn't find a case where de-mocking was possible. I've encountered and fixed some typos in comments and did the beforeEach(...); refactor when it was possible. All test pass and I've validated that the introduction of such changes doesn't change the purpose/nature of each test case.
Individual commits can be found here: https://github.com/rudygodoy/zeppelin-solidity/commits/master Let me know if a PR is in order so I can do it for those small changes.

Yes please open a new PR for this so we can do code review more easily

Thanks for looking at this, @rudygodoy!


Embedding a fragment into a query?

In my first attempts to constructing dynamic queries, I had something like:
def findFiltered(filter: Frag) = sql"SELECT * FROM table WHERE $filter"

findFiltered(sql"age = 12")

However, it turns out that you can't embed Frags into interpolated sql queries. Is this by design?
I've since discovered Spec, which for now meets my needs, but I suspect that once dynamic queries with JOINs or such come into play, Spec might no longer be enough.

However, it turns out that you can't embed Frags into interpolated sql
queries. Is this by design?

It's definitely something we can implement, but hopefully the Spec
abstraction will cover your dynamic query use case.

I've since discovered Spec, which for now meets my needs, but I suspect
that once dynamic queries with JOINs or such come into play, Spec might no
longer be enough.

When joins are required, create a database view, and then build a Spec
against the view.
On Tue, Aug 6, 2024, 4:33 AM Adam Warski @.***> wrote:

In my first attempts to constructing dynamic queries, I had something like:
def findFiltered(filter: Frag) = sql"SELECT * FROM table WHERE $filter"
findFiltered(sql"age = 12")
However, it turns out that you can't embed Frags into interpolated sql
queries. Is this by design?
I've since discovered Spec, which for now meets my needs, but I suspect
that once dynamic queries with JOINs or such come into play, Spec might
no longer be enough.
—
Reply to this email directly, view it on GitHub
https://github.com/AugustNagro/magnum/issues/34, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQOKNSQQRA7B67LGCHFGXDZQCYBHAVCNFSM6AAAAABMCELABCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TANRVGY4DGNQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hm well views seem to be quite a "heavyweight" solution, as that's a database object that you have to first create. So simply "writing a query and getting results" becomes much harder. Views are definitely a solution, but I think it would be great if magnum would be less opinionated here and allow for constructing ad-hoc complex queries as well.

Good point @adamw . Giving this some more thought, I've opened two WIP merge requests:

Support Frag parameters in the sql interpolator: https://github.com/AugustNagro/magnum/pull/51

  test("embed Frag into Frag"):
    def findPersonCnt(filter: Frag)(using DbCon): Int =
      sql"SELECT count(*) FROM person WHERE $filter".query[Int].run().head
    val isAdminFrag = sql"is_admin = true"
    connect(ds()):
      val johnCnt = findPersonCnt(sql"first_name = 'John' AND $isAdminFrag")
      assertEquals(johnCnt, 2)

Pros

Simple implementation
Very general purpose and covers all statement types

Cons:

Can be abused making the SQL layer a complicated mess. I've seen before in other slick/doobie projects and it was a main rational for the Spec class.

Enhance Spec to support a user-supplied 'prefix' Frag that ends before the WHERE clause. (WIP MR: https://github.com/AugustNagro/magnum/pull/52 )

  test("spec with prefix"):
    val age = 3
    val frag = Spec[User](sql"SELECT * FROM user")
      .where(sql"age > $age")
      .build
    assertEquals(frag.sqlString, "SELECT * FROM user WHERE (age > ?)")
    assertEquals(frag.params, Vector(age))

Pros:

Allows one to use Specs without database views if joins are required

Cons:

Still needs some design thought and only covers dynamic queries (which is however the most common case).

Right now I think both would be valuable. LMK your thoughts.

Yeah I think both proposals are supplementary. Combining SQLs from fragments is kind of a last-resort thing - discouraged, dangerous, but good to have that "ultimate flexibility" when possible. So I think I would like to have that option. But I agree that using Specs  should be the way to go as long as possible - after all, this gives us type safety. Probably documenting such a "gradual degradation path" of safety (Spec - Spec with prefix - Embedding fragments) will still cause some people to misuse the features, but what can you do ... ;)

Closed by https://github.com/AugustNagro/magnum/pull/73

Sounds good, thanks @AugustNagro! Just to make sure - "direct"-style will also still be possible?

Just to make sure - "direct"-style will also still be possible?

100%!
On Mon, Dec 2, 2024, 11:49 AM Adam Warski @.***> wrote:

Sounds good, thanks @AugustNagro https://github.com/AugustNagro! Just
to make sure - "direct"-style will also still be possible?
—
Reply to this email directly, view it on GitHub
https://github.com/AugustNagro/magnum/issues/34#issuecomment-2512623002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQOKNV63RKA3I5KXKBNFAT2DS2VVAVCNFSM6AAAAABMCELABCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJSGYZDGMBQGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Please feel free to make feature request issues with changes you'd like to
see in v2.
One thing I have in mind is refactoring the package structure.. it's not
ideal to have everything in the magnum package if using wildcard imports.
On Mon, Dec 2, 2024, 4:26 PM August Nagro @.***> wrote:

Just to make sure - "direct"-style will also still be possible?

100%!
On Mon, Dec 2, 2024, 11:49 AM Adam Warski @.***>
wrote:

Sounds good, thanks @AugustNagro https://github.com/AugustNagro! Just
to make sure - "direct"-style will also still be possible?
—
Reply to this email directly, view it on GitHub
https://github.com/AugustNagro/magnum/issues/34#issuecomment-2512623002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQOKNV63RKA3I5KXKBNFAT2DS2VVAVCNFSM6AAAAABMCELABCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJSGYZDGMBQGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@AugustNagro great to know :) I think I posted all of the issues I had so far ... maye the only thing left would be integration with various "error modes", as exemplified in https://github.com/softwaremill/bootzooka/pull/1364 (thanks for the PR!):
def transactEither[E, T](f: DbTx ?=> Either[E, T])(using IO): Either[E, T] =
     try com.augustnagro.magnum.transact(transactor)(Right(f.fold(e => throw LeftException(e), identity)))
     catch case e: LeftException[?] => Left(e.asInstanceOf[LeftException[E]].left)

this works, but the try-catch is not ideal. Maybe some way of evaluating the transaction's logic into a Commit/Rollback result would work here?


attention_mask

hi, I have attention_mask problem mismatch in the cross attenstion
can you please explain this line:
requires_attention_mask = "encoder_outputs" not in model_kwargs ?
why is comed after this:
if "encoder_outputs" not in model_kwargs:
# encoder_outputs are created and added to model_kwargs
model_kwargs = self._prepare_text_encoder_kwargs_for_generation(
inputs_tensor,
model_kwargs,
model_input_name,
generation_config,
)
is the attention mask is needed for the cross attnetion layer in the generation part?
this mismach problem accure only in the generator
the train & eval are ok.
tnx!

I think it might se related to this:
        encoder_attention_mask = _prepare_4d_attention_mask(
            encoder_attention_mask, inputs_embeds.dtype, tgt_len=input_shape[-1]
        )

In the comment written:
[bsz, seq_len] -> [bsz, 1, tgt_seq_len, src_seq_len]
but _prepare_4d_attention_mask returns src_seq_len as 1. Is this is what you ment? because it is not working well with the cross attention condition:
    if attention_mask is not None:
        if attention_mask.size() != (bsz, 1, tgt_len, src_len):
            raise ValueError(
                f"Attention mask should be of size {(bsz, 1, tgt_len, src_len)}, but is {attention_mask.size()}"
            )

i would like some help
@ylacombe

Hey @netagl, thanks for your message! not sure to understand your issue, could you send a code snippet to reproduce any potential issues ?
The attention mask is needed in the cross attention layer if you have a batch of samples, otherwise you don't need to pass it to the model!

@netagl, Is your audio_encoder_per_device_batch_size 1?


Fix GetinsightData to use new field

What this PR does / why we need it:
Fix GetinsightData to use new field
Which issue(s) this PR fixes:
Ref(PR): #1444
Does this PR introduce a user-facing change?:

NONE

Nice. Thank you.
/approve


Add Info of how to get ObjectID

I honestly spent half an hour trying to figure out where to find the ObjectID because it doesn't show up in the table view... Hope I can save someone else some time!

Thanks for contributing :)


When executing a pipeline that requires input parameters, no input box pops up

Versions used
KubeSphere:  v3.2.0
How To Reproduce
Steps to reproduce the behavior:
1、Go to pipeline list
2、Select pipeline
3、Click on 'Run'

pipeline {
    agent any
    parameters {
        string(name: 'PERSON', defaultValue: 'Mr Jenkins', description: 'Who should I say hello to?')
    }
    stages {
        stage('Example') {
            steps {
                echo "Hello ${params.PERSON}"
            }
        }
    }
}

Expected behavior
When you click to run, the following pop-up window is displayed.

/kind bug
/cc @kubesphere/sig-devops
/priority medium

same as：https://github.com/kubesphere/ks-devops/issues/839


Add Basic cluster tests for attributes constraints

Problem
There is no specific tests for the Basic cluster.
Change overview

Move the Basic cluster definition out of the Silabs's definition and update it a little
Add Test_10_1_1 for the Basic cluster
Update the templates to support optional keyword, such that an attribute is tested only if it is supported on the accessory side
Update the templates to support constraints keyword
Add minLength/maxLength constraints support (format and type still needs to be done)
Update gen/ folders

Testing

Tests were generated for the Darwin CI and the test suites using chip-tool

@Damian-Nordic @jepenven-silabs ?

@vivien-apple conflicts :(

Cannot easily review this due to large amoung of generated code.

@andy31415 fwiw, reviewing the individual changesets worked pretty well for me for this one....


Need to add additional buckets to the codebuild iam role

https://github.com/squidfunk/terraform-aws-github-ci/blob/56e3a3b59f9c026e9e91cca279d13a6d73676fb7/share/iam/policies/codebuild.json#L22
Hey,
I have some needs to push additional resources to another bucket in my build.
Any ideas on how to accomplish that?
If you do - let me know, and I'll implement :)

The codebuild role is exported as an output:
https://github.com/squidfunk/terraform-aws-github-ci/blob/56e3a3b59f9c026e9e91cca279d13a6d73676fb7/outputs.tf#L30-L33
You could use it to attach further policies like this:
https://github.com/squidfunk/terraform-aws-github-ci/blob/56e3a3b59f9c026e9e91cca279d13a6d73676fb7/main.tf#L71-L85

Yeah, I realised that the morning after :-) Thanks again for this beautiful module! 👍🏻🎉


Password placeholder positioned incorrectly

Just wondering if I can get some help with how to position this placeholder correctly?
In IE9, the password placeholder on the following page is positioned outside the password field:
http://v20140106.capl-ecsfp.ca/data-entry/
I have viewed one of the closed issues and tried using the suggested code, but it did not resolve the issue.

This appears to still be an issue (and fixable with the css mentioned).  was this ever fixed?


deploy a DataHub instance locally error

1 python version: 3.9.5
2 datahub version
datahub --version
acryl-datahub, version <IP_ADDRESS>
3  run the following CLI command from my terminal, following errors printed on the screen:
datahub docker quickstart
No Datahub Neo4j volume found, starting with elasticsearch as graph service.
To use neo4j as a graph backend, run
datahub docker quickstart --quickstart-compose-file ./docker/quickstart/docker-compose.quickstart.yml
from the root of the datahub repo
Fetching docker-compose file https://raw.githubusercontent.com/datahub-project/datahub/master/docker/quickstart/docker-compose-without-neo4j.quickstart.yml from GitHub
Pulling docker images...
unknown shorthand flag: 'f' in -f
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Options:
--config string      Location of client config files (default "/root/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var
and default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket(s) to connect to
-l, --log-level string   Set the logging level ("debug"|"info"|"warn"|"error"|"fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/root/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/root/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/root/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Management Commands:
builder     Manage builds
config      Manage Docker configs
container   Manage containers
context     Manage contexts
engine      Manage the docker engine
image       Manage images
network     Manage networks
node        Manage Swarm nodes
plugin      Manage plugins
secret      Manage Docker secrets
service     Manage services
stack       Manage Docker stacks
swarm       Manage Swarm
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Commands:
attach      Attach local standard input, output, and error streams to a running container
build       Build an image from a Dockerfile
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
exec        Run a command in a running container
export      Export a container's filesystem as a tar archive
history     Show the history of an image
images      List images
import      Import the contents from a tarball to create a filesystem image
info        Display system-wide information
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
login       Log in to a Docker registry
logout      Log out from a Docker registry
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
ps          List containers
pull        Pull an image or a repository from a registry
push        Push an image or a repository to a registry
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
run         Run a command in a new container
save        Save one or more images to a tar archive (streamed to STDOUT by default)
search      Search the Docker Hub for images
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
version     Show the Docker version information
wait        Block until one or more containers stop, then print their exit codes
Run 'docker COMMAND --help' for more information on a command.
Error while pulling images. Going to attempt to move on to docker compose up assuming the images have been built locally
unknown shorthand flag: 'f' in -f
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Options:
--config string      Location of client config files (default "/root/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var
and default context set with "docker context use")

Hello @zcw5116
You are most likely running an old version of docker. What is the output of docker compose --version? If you see an error it means you have to update your docker version. compose is meant to be a plugin do the docker cli tool.
This is a breaking change from docker where in the past you would run docker-compose (notice the -). DataHub has since migrated to the newer version and users need to update their docker installs. Sadly we can not automate this.

Your judgment is very correct. The Docker version is too old. I have updated the Docker. Everything is OK. Thank you very much.

Hello,
I was following the official quickstart instructions and I've this problem too.
The instructions state that if running on linux, one should use the v1 for docker-compose.
My configuration:
OS:
Distributor ID:	Debian
Description:	Debian GNU/Linux 11 (bullseye)
Release:	11
Codename:	bullseye

Docker and docker-compose:
Docker version 20.10.20, build 9fdeb9c
docker-compose version 1.29.2, build 5becea4c

When I try to run datahub docker quickstart I get the same error written in this issue. Also, given the old (and deprecated), docker-compose version I also get:
docker compose version
docker: 'compose' is not a docker command.
See 'docker --help'

I've solved the problem by upgrading docker-compose to Docker Compose version v2.12.0 and by following official docker documentation where it says to install: sudo apt-get install docker-compose-plugin.
Is this approach correct? If so, should the docs be updated for linux?
Thanks! :)

The Docker vers

Can you tell me which version for your Docker?

Docker compose has since been indicated as a prereq

Hello folks,
Is anyone still having issues on deploying DataHub locally?


ARROW-18028: [Dev][Archery][Crossbow] Always use GitHub Action's run page URL in PR comment

We always use
https://app.travis-ci.com/github/ursacomputing/crossbow/branches for URL of jobs that ran on Travis CI. For example:
https://github.com/apache/arrow/pull/14300#issuecomment-1269440972
It's inconvenient because we need to find the target build by ourselves.
We use another URL for job URL in nightly build report e-mail. It's GitHub Action's run page URL. For example:
https://github.com/ursacomputing/crossbow/runs/8841634652
This change uses GitHub Action's run page URL in PR comment too.

@raulcd @kszucs What do you think about this?

Oh... This breaks comment bot...
https://github.com/apache/arrow/pull/14409#issuecomment-1278351434

#14410 fixes the problem.

Oh... This doesn't use GitHub Action's run page URL from comment bot...:
https://github.com/apache/arrow/pull/14409#issuecomment-1278396923
uses
https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1e49219a52-github-r-binary-packages
not
https://github.com/ursacomputing/crossbow/actions/runs/3247080604


Update README.md

Please describe what changes you are making in this PR.

I think these are more stylistic differences, I don't think they really improve readability.


Send contact_groups to the publishing-api

Trello

Part of the work to migrate contacts_admin to use the govuk_index.
Previously publishing-api did not have the contact_groups fields.
They are now needed so that publishing-api can send them to Rummager, as opposed to contacts-admin sending them straight to Rummager.

Depends on this change to content-schemas being deployed.
Paired with @suzannehamilton.

🚢 not sure why but I don't have an approve button.


stream creation: "People to add" filter should show your name.

This input should show your name if you search for it:

It is very confusing that it doesn't, since it feels like there is no way to subscribe yourself. (Or unsubscribe yourself, if you are an admin in a realm where non-admins can't create streams, and you are creating the stream on behalf of another group of users.)

@zulipbot claim


Update version strings to 8.2.0.b1 for beta release.

Issues:
Fixes #490
Problem:
Documentation needs to reflect latest version.
Analysis:
Search and replace 8.1.0 with 8.2.0.b1.
Update release notes file present in repo.
Tests:
Review docs in fork prior to submitting PR to F5Networks.

Matt,
You are going to hate me, but I think that using the extra .b1 will break the python package build.  I can't remember what broke, but there was a reason why the alpha versions were a1 and a2 and we didn't use the dot.
I am going to play around with this.

Yes, the doc link should point to lbaasv2-driver.
-- Jodie Putrino
On Dec 16, 2016, at 7:48 PM, Jeffrey Longstaff <notifications<EMAIL_ADDRESS>wrote:
@jlongstaf commented on this pull request.

In docs/release_notes.rsthttps://github.com/F5Networks/f5-openstack-agent/pull/491#pullrequestreview-13439340:

Open Issues

See the project issues page <https://github.com/F5Networks/f5-openstack-agent/issues>_ for a full list of open issues in this release.
-Documentation can be found on Read the Docs <http://f5-openstack-lbaasv2-driver.readthedocs.io/en/latest/release_notes.html>.
+Documentation can be found on Read the Docs <http://f5-openstack-agent.readthedocs.io/en/latest/release_notes.html>.
This is a broken link. I thought release notes were always in the driver repo. @jputrinohttps://github.com/jputrino would know for sure.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-openstack-agent/pull/491#pullrequestreview-13439340, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALlMsf_kxyBPdwEaf-mNYRsB6ywgMhsMks5rI02KgaJpZM4LPubL.

Matt,
The versions of the dependencies need to be updated.  For example, the new sdk dependency is on version 2.1.0.  That release depends on icontrol-rest version v1.1.0
 $ curl -L -O https://github.com/F5Networks/f5-common-python/releases/download/v1.5.0/f5-sdk-1.5.0-1.el7.noarch.rpm
 $ curl -L -O https://github.com/F5Networks/f5-icontrol-rest-python/releases/download/v1.0.9/f5-icontrol-rest-1.0.9-1.el7.noarch.rpm
 $ sudo rpm –ivh f5-icontrol-rest-1.0.9-1.el7.noarch.rpm f5-sdk-1.5.0-1.el7.noarch.rpm

Fixed Rich's comment on sdk and icontrol versions.
Re: Jeff's comment.  The agent and driver packages will eventually need to move independently from each other.  We either need to remove the release_notes file from agent, or keep what I have now (which updated the file in both repo to reflect the same information, but with appropriate links).

I'm fine with having it in both.
-- Jodie Putrino
On Dec 17, 2016, at 10:49 AM, Matt Greene <notifications<EMAIL_ADDRESS>wrote:
Fixed Rich's comment on sdk and icontrol versions.
Re: Jeff's comment. The agent and driver packages will eventually need to move independently from each other. We either need to remove the release_notes file from agent, or keep what I have now (which updated the file in both repo to reflect the same information, but with appropriate links).

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-openstack-agent/pull/491#issuecomment-267776381, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALlMsYqQkhdi5l2UAWFuO7MCnqtX5o0iks5rJCCcgaJpZM4LPubL.


Update hiring timeline cog to use db model

Description
Context
Currently the hiring timelines announcements depends on an ENV variable to send the message, that approach is not extensible to other guilds and other channels, and is not maintainable in the time. Because of that we're migrating the configuration to the database.
This diff

Update the hiring timeline command to use the new configuration from the database

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
Tested manually in a test server
Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

develop

PR #68

PR #69

PR #70   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 5, 12:21 AM: @akotadi started a stack merge that includes this pull request via Graphite.


Always compress "compressible" files in S3

I'm starting this PR for discussion.
The idea here is to always store files in S3 in compressed format. The OONI data is highly compressible, so this should significantly reduce the costs for storage and transfer, as well as make the transfers a lot faster.
This change should be backward compatible: people accessing the files from S3 will only get compressed content if they set Accept-Encoding: gzip.
Note that I have not tested this change. I don't believe I can easily, so I'd love some guidance. It may make more sense for someone from the OONI team to test it instead.

I'm starting this PR for discussion.

Current plan regarding storage is to store "large" reports compressed with lz4 and small reports -- with tar.lz4 where lz4 frames are aligned with reports inside of tar file to make tar file "seekable". That's already implemented in pipeline-16.10 branch, but it's not part of public API yet: two versions of pipeline are currently running side-by-side.
lz4 was chosen instead of gzip because of comparable compression ratio (IIRC, 22% vs 19%) and much faster decompressor.

This change should be backward compatible

Thanks for valuable information. I assumed that S3 can't provide transparent gzip decompression to old clients.

reduce the costs for storage and transfer

Current plan is to close access to S3 gracefully and abuse generosity of our hosting provider to serve the data from another location that costs us much less. There is beta API to fetch single measurements and there can be API for to fetch compressed json.lz4 / tar.lz4 files.

Current plan is to close access to S3

We've applied to Amazon Open Data program and have got some "free" storage & transfer.

tar.lz4 .. is not part of public API yet

These tar.lz4 files are now available at s3://ooni-data/autoclaved/jsonl.tar.lz4/. They should be readable with ordinary tar -I lz4 --extract from ubuntu:16.04. It's not a part of "official" public API yet, but it's here to stay for some time as this format solves some efficiency issues of underlying jsonl format.

I think, that can be closed.
That ugly *.tar.lz4 is described in blog post: https://ooni.torproject.org/post/mining-ooni-data/
The main reason to have it was to reduce ~6M report files taking ~18TiB to ~0.2M archives taking ~3.8 TiB  to make it more friendly to HDD-based storage and avoid IO operations on reports as small as ~4kb, while preserving compatibility with possible existing consumers.
Other issues of current data format are described at #114 quite well.


chore: Code tidy up and new test

Cleanup instrumentation code again with a focus on absolute and relative paths
The main aim of this has been to clarify whether we're working with relative or absolute file paths, and removing unnecessary transformations. Although I've made a few other 'small' changes here and there.
Key changes:

Created a new private method NYC._transform, common to _maybeInstrumentSource and instrumentAllFiles.
Renamed the param in walkAllFiles forEach handler to relFile to explicitly state the file representation being used.
Let the addAllFiles visitor function rely on testExclude to determine which files to instrument
Test that the instrument command returns unmodified source if there is no transform found for a file extension.

Coverage decreased (-0.07%) to 96.349% when pulling a054fbc48782dc5d3c1d714f8c39e9944e2fbe1f on AndrewFinlay:cwd-cleanup into 1f6c3d4a2bd74e3fada35eb029ec9fb6b480e99e on istanbuljs:master.


Revamp DNS resolver and DNS cache

Motivation:
There are three problems with the current DNS resolver.

Intermediate failures of each search domain are not cached. Only the
final result of a question is cached. So a DNS resolver always sends a query to
the failed search domain regardless of negative TTL.
Slack thread: https://line-armeria.slack.com/archives/C1NGPBUH2/p1646255907387469

A ClientFactory has its own DNS resolver and DNS cache which are not
shared with other ClientFactorys. Some complex systems tend to have
multiple ClientFactory to optimize parameters for target remote peers.
The multiple DNS resolvers are inefficiency because cache miss ratio
could be increased.
See: https://github.com/line/armeria/issues/2940

It is unable to provide a precise timeout. A DNS query could send
multiple requests to DNS servers. Unfortunately, Netty's DNS resolver
applies a query timeout both for total timeout and each individual
query. For example, if a queryTimeout is set to 5 seconds, each
such query should be completed in 5 seconds, and also the final result
should be returned in 5 seconds.

Modifications:

Added AbstractDnsResolverBuilder for sharing common properties between
DnsResolverGroupBuider and DnsEndpointGroupBuilder.
Added DnsCache and its builder for sharing DNS caches across different DNS
resolvers.
Added ByteArrayDnsRecord for easily caching, removing, and expiring DnsRecords
without considering reference counting.
Added a new DnsResolver interface for composing multiple DNS resolvers
using decorator patterns. The following implementations are added.

SearchDomainDnsResolver to handle search domains.
HostsFileDnsResolver to resolve DNS question using /etc/hosts file.
CachingDnsResolver to cache DNS resolutions.
DelegatiingDnsResolver to delegate queries to Netty's DnsNameResolver.
Meanwhile, disabled search domains and hosts file resolutions in DnsNameResolver.

Deprecations

Dns{Text,Service,Address}EndpointGroupBuilder.dnsServerAddressStreamProvider()
has been deprecated in favor of Dns{Text,Service,Address}EndpointGroupBuilder.serverAddressStreamProvider()
Dns{Text,Service,Address}EndpointGroupBuilder.disableDnsQueryMetrics()
has been deprecated in favor of Dns{Text,Service,Address}EndpointGroupBuilder.enableDnsQueryMetrics(boolean)

Lint) Add PreferUnmodifiableFuture checkstye rule to enforce to use
UnmodifiableFuture.completeValue() and UnmodifiableFuture.exceptionallyCompletedFuture().

Result:

You can now set a timeout of each sub DNS query using queryTimeoutForEachAttempt().DnsAddressEndpointGroup.builder("armeria.dev")
                       .queryTimeoutMillisForEachAttempt(1000) // 👈👈👈
                       .queryTimeoutMillis(5000)
                       .build();

You can now share a DnsCache with multiple DNS resolvers.DnsCache dnsCache = DnsCache.builder()
                            .ttl(60, 3600)
                            .negativeTtl(600)
                            .build();

DnsAddressEndpointGroup.builder("armeria.com")
                       .dnsCache(dnsCache)  // 👈👈👈
                       .build();

ClientFactory factory =
    ClientFactory.builder()
                 .domainNameResolverCustomizer(builder -> {
                     builder.dnsCache(dnsCache);  // 👈👈👈
                 }).build();
WebClient.builder()
         .factory(factory)
         .build();

If unspecified, the default DnsCache is used by default.
Failed search domain queries are cached according to the negative TTL configuration.
Fixes #2940

Looks like the builds are stuck somewhere after the recent update.


Accessing musicgen demo app via gradio_client fails when not using MultiBand_Diffusion

https://github.com/facebookresearch/audiocraft/blob/5d8752d3568858f1f77747dfb82b40ef9538c4b2/demos/musicgen_app.py#L190-L192
After initializing the client:
client.submit("facebook/musicgen-medium", "Default", "Hi", "", 3,5,5,5,5,fn_index=2)

Fails with:
[....]\versions\3.10.9\lib\site-packages\gradio_client\serializing.py", line 420, in deserialize
    raise ValueError(f"Expected tuple of length 2. Received: {x}")

while:
client.predict("facebook/musicgen-medium", "MultiBand_Diffusion", "Hi", "", 15,5,5,5,5,fn_index=2)

Runs just fine.  I suspect it is because in the first case the last two items are None.

hi, bro , i got it yet. did you resolve it ?
from gradio_client import Client
client = Client("https://xxxxxxxxxxxx/")
result = client.predict(
"facebook/musicgen-large",	# str  in 'Model' Radio component
"Default",	# str  in 'Decoder' Radio component
"Howdy!",	# str  in 'Input Text' Textbox component
"",	# str (filepath on your computer (or URL) of file) in 'File' Audio component
1,	# int | float (numeric value between 1 and 120) in 'Duration' Slider component
5,	# int | float  in 'Top-k' Number component
5,	# int | float  in 'Top-p' Number component
5,	# int | float  in 'Temperature' Number component
5,	# int | float  in 'Classifier Free Guidance' Number component
fn_index=2
)

If you want to use the default option I think you can try returning something other than None, None for 3rd and 4th in line 192


analyzer produces linter warnings in dependencies

since a few days

This file is from build_runner-0.3.0 a hosted dependency.
Same with dart:xxx packages.

Dart VM version: 1.23.0-edge.804f3dfdd8c4cbe3cc2c517f98b7d4a192256a0e (Tue Feb 28 02:51:01 2017) on "linux_x64"

IntelliJ IDEA 2017.1 EAP

@danrubel Any idea what might have changed that would cause this to happen?

Just a wild guess, because I just saw the comment https://github.com/dart-lang/sdk/issues/28383#issuecomment-283363697

Need some clarification here...
Is this a Flutter project? There was a recent change that upgraded a specific Flutter related linter hint to a warning.
In addition, I recently updated dartanalyzer to find the analysis options in the same way that analysis server does (see change log). In addition, you can use dartanalyzer --verbose /path/to/some/file.dart and it will echo the analysis options file used. Hopefully that will help track down the issue.

@danrubel it's not a Flutter project. I saw it in a normal console application project and an Angular project.
I'm using analysis_options.yaml, but I don't understand how this might be related.

analysis_options.yaml determines what analysis is performed and whether it appears as an error, warning, or hint. That said, it sounds like you have not changed that file, yet you are now seeing new warnings. Not sure I can help here.

No, I haven't changed the analysis_options.yaml. #28962 seems to be about the same problem.

https://codereview.chromium.org/2734673002

https://github.com/dart-lang/sdk/commit/24d5466a72a34cfe1fca15bb6f546553dc3bf4ea


Closing window has no effect

The plot is produced via the following code:
    def display_point_clouds(self, data_dict: dict, log_img_name=None):
        self.plotter = vedo.Plotter(
            N=6,
            offscreen=self.offscreen,
        )
        self.extra_plot_params({'interactive': False, 'resetcam': True, 'elevation': -10, 'zoom': 0.5})

        pointclouds = list()
        for key, elem in data_dict.items():
            if key == "occupancy":
                data = elem["occupancy_points"].cpu().numpy()
                scale = elem["occupancy_values"].cpu().numpy()
                pointcloud = vedo.Points(data)
                pointcloud.cmap("jet", scale, vmin=0.5, vmax=1)
                pointcloud.addScalarBar3D(title="value")
                pointclouds.append(pointcloud)
            else:
                data = elem.cpu().numpy()
                pointcloud = vedo.Points(data)
                pointcloud.cmap("rainbow", data[:, 2], vmin=None, vmax=None)
                pointclouds.append(pointcloud)

        # for vedo to work as expected, we need to have len(pointclouds) == len(self.legends) == even number
        pointclouds.append([])
        assert len(pointclouds) == len(self.legends) == 6
        fig = None
        for idx, pointcloud in enumerate(pointclouds):
            legend = self.legends[idx]
            fig = self.plotter.show(
                pointcloud,
                legend,
                at=idx,
                axes=dict(
                    c="black",
                    xrange=(-10, 10),
                    yrange=(-10, 10),
                    zrange=(-10, 10),
                    xyShift=0.5,
                    numberOfDivisions=10,
                ),
                title="title",
                camera=dict(
                    position=(5.233653722575609, 4.805790731006791, 21.428978640333078),
                ),
                **self.extra_plot_params,
            )

which results in:

The window that appears cannot be closed by any of the following:
self.plotter.clear()
self.plotter.close_window()
self.plotter.close()
fig.close()
fig.close_window()
vedo.plotter.close()

When the function gets executed again, a new window appears while the previous ones are still there. Could you help to understand what's wrong?
Vedo version: 2023.4.6

Hi, can you update to the latest vedo?
pip install vedo -U

then you need to change
numberOfDivisions -> number_of_divisions
xyShift -> xyshift
addScalarBar3D -> add_scalarbar3d

Keep in mind that the show() method holds the python execution as by default enters interaction mode.
You can specify show(interactive=False) the render the scene and continue the python flow.

Sorry I think you are right it's a genuine bug!


[App]: Latex Text not Working using Plotly

Current Behavior
Latex text using plotly is not shown properly in the web app. It is displayed correctly in the local plotly figure (plt.show()) but not in the wandb app (see screenshots).
Expected Behavior
No response
Steps To Reproduce
No response
Screenshots

Environment
OS:
Browsers:
Version:
Additional Context
No response

Hi @MauroVA98,
Thank you for reporting this! I'll pass this on to our engineering team. Is it possible for you to share the code snippet for how you generated these plotly charts? It will make it much easier for us to reproduce this case and lead to a quicker fix.
Thanks,
Ramit

This could snippet reproduces the bug.
`
import time
import wandb
import numpy as np
from plotly.subplots import make_subplots
import plotly.graph_objects as go
wandb.init(project='latex bug', name=f"{time.strftime('%m_%d_%H_%M')}")
fig = make_subplots(rows=1, cols=3, subplot_titles=("$F_{x}$", "$F_{y}$", "$F_{z}$"))
for i in range(3):
x = np.linspace(0, 10, 100)
y = x**i
fig = fig.add_trace(go.Scatter(x=x, y=y, mode="lines", name="Ground Truth", ), row=1, col=i + 1)
fig.show()
wandb.log({'figure': fig})
wandb.finish()
`

Oops didn't mean to close the issue.

Hi @MauroVA98! just wanted to drop in an update here - we are internally tracking this issue and will be working to resolve this. I'll keep you posted with updates as things progress with this issue.
Thanks,
Ramit

@ramit-wandb Perfect, thank you.


ContainerRegistry: Classic SKU is now deprecated.

Bicep version
Bicep CLI version 0.4.884 (93367f3f26)
Describe the bug
res-container-registry.bicep snippets generate following code. But Classic SKU is now deprecated.
resource containerRegistry 'Microsoft.ContainerRegistry/registries@2019-05-01' = {
  name: 'name'
  location: resourceGroup().location
  sku: {
    name: 'Classic'
  }
  properties: {
    adminUserEnabled: true
  }
}

To Reproduce
deploy bicep code.
{
  "status": "Failed",
  "error": {
    "code": "DeploymentFailed",
    "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
    "details": [
      {
        "code": "BadRequest",
        "message": "{\r\n  \"error\": {\r\n    \"code\": \"ClassicSkuDeprecated\",\r\n    \"message\": \"Classic SKU is now deprecated. Please select a managed SKU. Kindly refer to docs for instructions: https://docs.microsoft.com/en-us/azure/container-registry/container-registry-upgrade\"\r\n  },\r\n  \"status\": \"Failed\"\r\n}"
      }
    ]
  }
}

Additional context
Update snippets default SKU from Classic to Basic. Also remove Classic in swagger definition.
https://github.com/Azure/bicep/blob/1f7253b80dc2c25823cf35db208c466905a5c8b3/src/Bicep.LangServer/Snippets/Templates/res-container-registry.bicep#L6

I will fix this. We should have a working ACR snippet when the module registry is launched.


Can only pick human

Currently on version 4.4.5 from the curseforge and have it installed onto the server, once joining it gives the prompt on which origin to use but can't use the arrow buttons to select a different one. I've tried it on a singleplayer world but can't do it either...

4.4.5 seems to be the version of your modpack, there is no 4.4.5 version of Origins (even for the Forge port).
Make sure the issue is caused by Origins, and find out what the version of the mod is.
Also, if you're on Forge and not Fabric, head there instead of here.


& symbol and URL's downcase

Hi,
related to the issue #33 I've changed the post_processor.rb  to skip URL's down case.
I also changed the tokenisation for the symbol "&", now you&me or m&m's are tokenised as a single token.
Could it be a configurable behaviour?
Best

Sorry @diasks2,
I'm changing the way you handle the EMOJII to avoid splitting the VARIATION_SELECTORS.
Probably are not changes you want to merge.
Thanks for your work, really well done!


[FEATURE REQ] Release SCA 6.0.0

Context
After Spring released 3.0.0 and Spring Cloud 2022.0.0, upgrade to 3.0.0 and 2022.0.0 for Spring Cloud Azure 6.0.0.
Goal
Release Spring Cloud Azure 6.0.0.

closing to avoid meaningless issue


Explicit start operation flag

It can be helpful to have an explicit way to tell inside the log formatter if the operation is logged because it is starting to run (by setting on_start=True).
I would like to have my "on start" log to look like this:
2023-09-25 12:23:39.575646: Start my_operation

Instead of the default behavior:
2023-09-25 12:40:17.905515 (Nonems): [Creating Index / None]

Currently I managed to create to achieve this by adding to the formatter the following code:
if op.result is None:
   return f"{op.start_time_utc_str}: Start {op.name}

But I prefer to be able to do something like:
if op.is_starting:
   return f"{op.start_time_utc_str}: Start {op.name}

Or
if op.result == "Start":
   return f"{op.start_time_utc_str}: Start {op.name}

So CSV logs would make more sense

Operation has a step attribute. In this case, op.step == OperationStep.START.
The documentation is not extensive enough yet, so this is not easily discoverable.
I am working on improving the documentation, and will make sure this part is covered as well :)
Thanks!


enhancement: ability to list matching test cases and to show test suite and test case details

Currently, all of the data associated with tests is embedded in the binary. But if a user wanted to explore the set of test cases, they have to go look at the source code in a git repository.
Ideally, the test runner's command-line interface would provide a way to list test cases, including filtering test cases against one or more patterns, and to show test case and test suite details.

I would find this very useful, and it would alleviate https://github.com/connectrpc/conformance/issues/887. A simple solution could be to print all test names after the line Filtered tests to 123 test case permutation(s) with the --vv flag. That's not very discoverable, but maybe it's good enough to document it in configuring_and_running_tests.md and in the flag description.


Adding json and xml formats response for project show

refs #287
WIP

Nice, I like the XML payload idea to allow us to export what we send to Mediaflux.


Design/UI for job posting builder

Current design is side-by-side boxes, basically an expansion of the existing tool so this shouldn't block work on other parts of the tool.
This issue originally created by @antislice as codeforamerica/nola-2016-fellows#61.
This issue originally created by @antislice as codeforamerica/joblint#41.

Attempted to assign issue to @skcain but they're not assignable in this repo

@skcain's design:


cleanup fixup session restore prefs

clean up the tags, descriptions if needed. e.g AFAIK session data is still being recorded despite 1020, and if we have 0102 as 0, then it becomes redundant. And in fact the second pref in 1020 (number of windows) is just an extra hindrance to those who want to enable sessions.
I have also experienced a crash which asked to, and did, restore a window and I think, some tabs (I only ever have one window open).
The Big E even said that thse two prefs 1020 don't block session restore

current session restore prefs (assuming PR on tag info is kept as is right now)
/* 0102: set START page (0=blank, 1=home, 2=last visited page, 3=resume previous session)
 * [SETTING] General>Startup>Restore previous session ***/
user_pref("browser.startup.page", 0);

0102 is fine, this is just telling FF what to start with. Has nothing to do with blocking persistent storage of any kind.
/** SESSIONS & SESSION RESTORE ***/
/* 1020: disable the Session Restore service completely
 * [BEHAVIOR] This also disables the "Recently Closed Tabs" feature
 * It does not affect "Recently Closed Windows" or any history. ***/
user_pref("browser.sessionstore.max_tabs_undo", 0);
user_pref("browser.sessionstore.max_windows_undo", 0);
/* 1021: disable storing extra session data [BEHAVIOR]
 * extra session data contains contents of forms, scrollbar positions, cookies and POST data
 * define on which sites to save extra session data:
 * 0=everywhere, 1=unencrypted sites, 2=nowhere ***/
user_pref("browser.sessionstore.privacy_level", 2);
/* 1022: disable resuming session from crash [BEHAVIOR] ***/
user_pref("browser.sessionstore.resume_from_crash", false);
/* 1023: set the minimum interval between session save operations - increasing it
 * can help on older machines and some websites, as well as reducing writes, see [1]
 * Default is 15000 (15 secs). Try 30000 (30sec), 60000 (1min) etc
 * [BEHAVIOR] This can also affect entries in the "Recently Closed Tabs" feature:
 * i.e. the longer the interval the more chance a quick tab open/close won't be captured.
 * This longer interval *may* affect history but we cannot replicate any history not recorded
 * [1] https://bugzilla.mozilla.org/1304389 ***/
user_pref("browser.sessionstore.interval", 30000);

1020 doesn't do what it says it does. I'd even say we could make max_windows inactive (if people want session restore, why limit them to the last active window) assuming the pref does what it says it does. I suspect that the value of 0 no longer (or never did) work for these prefs? Something has changed.
1021 should be fine (not sure how to test) - keep active
1022 should be fine, but needs a test - suggest we could even make this inactive (I have code to trigger a crash)
1023 is fine

The other pref to consider is user_pref("browser.sessionstore.max_resumed_crashes", 0 from someone's massive pref dump. I don't think this will do anything.
The question is, if we cannot block session store data being written to the disk, then we should probably do away with those prefs (looking at you, 1020). Seems pointless limiting number of tabs/windows

For reference: source TB 60.3.0esr-8.5-1
pref("browser.sessionstore.resume_from_crash", true);
pref("browser.sessionstore.resume_session_once", false);

// Minimal interval between two save operations in milliseconds (while the user is active).
pref("browser.sessionstore.interval", 15000); // 15 seconds

// Minimal interval between two save operations in milliseconds (while the user is idle).
pref("browser.sessionstore.interval.idle", 3600000); // 1h

// Time (ms) before we assume that the user is idle and that we don't need to
// collect/save the session quite as often.
pref("browser.sessionstore.idleDelay", 180000); // 3 minutes

// on which sites to save text data, POSTDATA and cookies
// 0 = everywhere, 1 = unencrypted sites, 2 = nowhere
pref("browser.sessionstore.privacy_level", 0);
// how many tabs can be reopened (per window)
pref("browser.sessionstore.max_tabs_undo", 10);
// how many windows can be reopened (per session) - on non-OS X platforms this
// pref may be ignored when dealing with pop-up windows to ensure proper startup
pref("browser.sessionstore.max_windows_undo", 3);
// number of crashes that can occur before the about:sessionrestore page is displayed
// (this pref has no effect if more than 6 hours have passed since the last crash)
pref("browser.sessionstore.max_resumed_crashes", 1);
// number of back button session history entries to restore (-1 = all of them)
pref("browser.sessionstore.max_serialize_back", 10);
// number of forward button session history entries to restore (-1 = all of them)
pref("browser.sessionstore.max_serialize_forward", -1);
// restore_on_demand overrides MAX_CONCURRENT_TAB_RESTORES (sessionstore constant)
// and restore_hidden_tabs. When true, tabs will not be restored until they are
// focused (also applies to tabs that aren't visible). When false, the values
// for MAX_CONCURRENT_TAB_RESTORES and restore_hidden_tabs are respected.
// Selected tabs are always restored regardless of this pref.
pref("browser.sessionstore.restore_on_demand", true);
// Whether to automatically restore hidden tabs (i.e., tabs in other tab groups) or not
pref("browser.sessionstore.restore_hidden_tabs", false);
// If restore_on_demand is set, pinned tabs are restored on startup by default.
// When set to true, this pref overrides that behavior, and pinned tabs will only
// be restored when they are focused.
pref("browser.sessionstore.restore_pinned_tabs_on_demand", false);
// The version at which we performed the latest upgrade backup
pref("browser.sessionstore.upgradeBackup.latestBuildID", "");
// How many upgrade backups should be kept
pref("browser.sessionstore.upgradeBackup.maxUpgradeBackups", 3);
// End-users should not run sessionstore in debug mode
pref("browser.sessionstore.debug", false);
// Causes SessionStore to ignore non-final update messages from
// browser tabs that were not caused by a flush from the parent.
// This is a testing flag and should not be used by end-users.
pref("browser.sessionstore.debug.no_auto_updates", false);
// Forget closed windows/tabs after two weeks
pref("browser.sessionstore.cleanup.forget_closed_after",<PHONE_NUMBER>);
// Maximum number of bytes of DOMSessionStorage data we collect per origin.
pref("browser.sessionstore.dom_storage_limit", 2048);
// Amount of failed SessionFile writes until we restart the worker.
pref("browser.sessionstore.max_write_failures", 5);

1020 browser.sessionstore.max_tabs_undo

Mozillazine:

Possible values and their effects
A positive integer

sessionstore.js Telemetry for FF29: https://wiki.mozilla.org/Firefox/session_restore

^^ Yeah, aware of all that. I was just interested in their comments and also if you look here under Implementation Status, it mentions:

After closing all tabs, we then clear the searchbox and findbox text and emit "browser:purge-session-history" (which instructs addons and various Firefox components to clear their session state)...

The document has been updated over time, but some parts of it are out of date (I re-read the entire thing last night)
We I will have to do some testing, but I think session data cannot be stopped, only limited. As said elsewhere, my files get written too regardless of trying to kill it, and the one time I crashed, it recovered at least one tab. Our whole Session Restore needs a rethink, rewording etc.

Checked - those values are the same on https://raw.githubusercontent.com/mozilla/gecko-dev/master/browser/app/profile/firefox.js
Even the value in secs for:
browser.sessionstore.cleanup.forget_closed_after
// Forget closed windows/tabs after two weeks

re 1020 : There used to be a browser.sessionstore.enabled (introduced in FF2, yup FF version TWO) which was a master switch for the Session Restore service. This has obviously been deprecated.
Just like full-screen-api.approval-required=false was replaced by using a zero in full-screen-api.warning.timeout, setting the two prefs in 1020 should mean no data is stored.
I'm watching my \profile\sessionstore-backups\* directory (using my portable Everything ) and it's getting written to every so often - its kinda hard to tell, its probably 30 seconds as per my setting, but it depends if anything changes (eg, I'm just typing in this window and looking things up the user.js in Notepad++ etc), and sometimes nothing may change in that 30 second period. I have 5 tabs open, and the current tab (this one) has had focus for about 5 minutes.
It actually looks like the two files are being updated every 30 seconds, and about 15 secs apart. Clearly the bakz4 file is irrelevant (its just a backup copy).
Interestingly, the jsonlz4 file was 12kb before I started typing this post, and it seems to have grown to double that with no other changes to tabs. I hope that the session privacy setting is being respected

The interesting thing will be to look at whats inside. And to also do some testing.

How do you view the contents of a jsonlz4? Gonna crowdsource the answer from you guys rather than google it

And even ore interesting, as soon as I posted that comment two posts up, the long one, my session restore file suddenly reduced to 12kb. To me this is indicating that it's storing form data when it shouldn't

Searching central on DXR, all I see for max_tabs and max_undo are default prefs and a bunch of tests, so I'm having a hard time even following the code.Am I doing something wrong here? Or are these prefs NOT even used any more?

How do you view the contents of a jsonlz4?

we have a recommended extension for that

^^ Oh, I don;t want to install an extension, but I spose

heh .. FYI: https://bugzilla.mozilla.org/show_bug.cgi?id=449596: master switch removed in FF 3.1a2 and comment 5 clearly says what I said .. using zero in the other pref(s) is the same as disabling it.
Am busy trying to find the zillas where these two prefs were made 100% not used, so we can move em to section 9999

side note: browser.sessionstore.max_serialize_back could be a way to reduce session data, but the service itself is probably used by FF, eg in mid session updates

should we mod 0102 to say that SR is not available in PB mode, or are we stating the obvious?
/* 0102: set START page (0=blank, 1=home, 2=last visited page, 3=resume previous session)
 * [NOTE] Session Restore is not used in Private Browsing mode (see 0110)
 * [SETTING] General>Startup>Restore previous session ***/
user_pref("browser.startup.page", 0);

^^ It doesn't do a harm if it is mentioned as suggested.

From here .. even 6 years ago it seems that the undo = 0 was used but limited it to the last active tab/window. There are some browser.sessionstore.max_serialize* prefs but not 100% sure how they all work into it today.

I don't want to waste any more time on this. So far:

SR is integrated internally with history and undo closed* etc
disabling history i think disables SR
-.SR is not used in PB mode.
1020 do not seem to be used. DXR indicates they are dead prefs. They certainly do not work as nothing recording at zero (and didn't, probably, ever = at best, in the past, it limited it the last active)

inspecting my recovery.jsonlz4 file (my settings for the prefs are 0), it was recording all open tabs in my one window.

I think we should remove 1020, or if anyone can find a bugzilla that show when they became dead, then we can move them to deprecated.

I do not like this rabbit hole. Anyway despite having data in recovery .. about:sessionrestore shows nothing

JESUS CHRIST!!
https://dxr.mozilla.org/mozilla-central/search?q=max_windows_undo
Do you not see all those lines in SessionStore.jsm ?!? they're clearly NOT DEAD PREFS!
They do exactly what their name suggests and that's control the max number of stored "UNDO" (ie closed!) tabs and windows
IDFK why I have to keep telling you not to search for the full prefname when you have such a UNIQUE substring in the pref


Set, Mul & Add modes for send

sometimes you want more than one send to influence the same value. it would be good to have Set, Mul, and Add mode available so that effects from multiple sources can be combined

SET would be redundant, as multiple sends targeting the same value already work like an "ADD". The port is reset to 0 every cycle so sends A and B targeting a port works like: calculate 0 + A + B, then add this to the modulated value.
This is pretty deep design choice in Sointu and is unlikely to change. Internally, SEND unit is already out of bit fields for flags (it uses all 16 bits it has already for it's data), so adding one more bit for "MUL" / "ADD" would require 17th bit i.e. adding new byte to the data of SEND.
Also, two sends with "MUL" set as its mode would not work quite as one would expect, as all ports are reset to 0 during one cycle so it would 0 * A * B = always 0
Can you give a specific example where Mul is needed? I think it's a pretty specific, rare use case, and there's a way to implement it using RECEIVE-RECEIVE-MULP or something like that.


Add total successful task count in nodeStats API of SearchBackpressureService.

Is your feature request related to a problem? Please describe.
Adding total successful task in searchShardTaskStats and searchTaskStats pojos to support autotune of heap based thresholds. Since the SBP Service node stats only include cancellation stats for shard and coordinator level requests, it is impossible to calculate the cancellation percentage due to a resource.
Describe the solution you'd like
We want to include total successful task count in the searchbackpressure stats at shard and coordinator level data.
Describe alternatives you've considered
N/A.
Additional context
We are planning to make use of this field to auto tune the SBP heap based cancellation thresholds at shard and coordinator level.
Related issues

RCA Issue

Shall we also include a metric suggesting whether the node is under duress or not?
IsNodeUnderDuress can be added in the SearchBackpressureStats pojo.


zsh which returns the phpbrew function body and not the path

Breaking change introduced by 08b85ebba6ce7a356ea64bbce0fe66d2a03cb023. Fixes #506.

makes sense

agh shell portability :sweat:
thanks @protomouse


Implement dedicated empty state image on the Search page

What is the motivation for adding/enhancing this feature?
We need to implement an empty state which suggests user to take action for searching the product.
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

https://www.figma.com/file/j3l0F2DioUHEuQT53NOQJY/Ionic-6-Material-UI-Kit-(Community)-(Nidhi--2023)?type=design&node-id=25710%3A22991&mode=design&t=WfQdwKvHLbKsKELv-1


chore: add docs for insert method of collections

Not sure these tests increase coverage, but good to have nonetheless. Thanks!

these tests are not for increasing coverage, but for documentation, for me the behavior of these methods was not obvious, I think the reason is inattentive reading of the documentation. For me tests, an alternative version of the documentation is the code that makes itself known.