Site health check (5.2) not present on production

Hello,
This bug report is about the Site Health check introduced in 5.2
I've noticed that in local developement, I can access to /wp/wp-admin/site-health.php + the item is present under the "Tools" menu.
As soon as I am on the production (WP_ENV=production) the menu item is no longer present, and the page /wp/wp-admin/site-health.php gives a 404 error or an authorization error (you don't have access to this page) although I'm an administrator.
Is this related to Bedrock ?

Probably DISALLOW_FILE_MODS?
Sent from my iPhone

On May 14, 2019, at 8:21 AM, Tristan Bessoussa<EMAIL_ADDRESS>wrote:
Hello,
This bug report is about the Site Health check introduced in 5.2
I've noticed that in local developement, I can access to /wp/wp-admin/site-health.php + the item is present under the "Tools" menu.
As soon as I am on the production (WP_ENV=production) the menu item is no longer present, and the page /wp/wp-admin/site-health.php gives a 404 error or an authorization error (you don't have access to this page) although I'm an administrator.
Is this related to Bedrock ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @tristanbes,
It looks like the issue template is missing from this issue. Please take a look at the Contribution Guidelines, which will tell you exactly what your ticket has to contain in order to be processable.
Please do not use the issue tracker for personal support requests (use the Roots Discourse to ask the Roots Community for help, or if you want the Roots Team to dedicate some time to your issue, we offer our services as well).

Config::define('DISALLOW_FILE_MODS', true); which is what we want in a production environement, but I don't see the reason behind not showing an important page based on this constant which has absolutely nothing to do with the site health check feature. :)
So WordPress side then ?

https://core.trac.wordpress.org/ticket/47204


Mutliple MMM-ToggleButtons

Good afternoon all,
On my mirror I am going to build in a semi hidden button in the frame made of the same material that hides modules so it is just a mirror without any distraction.
I have set this up perfectly and works lovely.
However, I would like to add a second Toggle Button on a different GPIO pin Number to hide a different selection of modules.
When I had a second ToggleButton module to the config file with a diferent Pin, neither of the buttons work. I have included code below...
`   {
module: 'MMM-ModuleToggleButton',
config: {
buttonGpioPin: 6,
moduleNames: [
'clock',
'calendar',
'MMM-PushBulletNotifications',
'MMM-page-indicator',
'newsfeed',
'compliments',
'currentweather',
'weatherforecast',
'MMM-AlexaPi',
'MMM-GoogleTasks',
'MMM-History',
'MMM-CountDown',
'MMM-Spotify',
'internet-monitor',
'MMM-portscan',
'MMM-network-signal',
'MMM-BackgroundSlideshow',
'MMM-SystemStats',
]
}
},
//    {
//      module: 'MMM-ModuleToggleButton',
//      config: {
//        buttonGpioPin: 26,
//        moduleNames: [
//		'clock',
//		'MMM-BackgroundSlideshow',
//
//    ]
//     }
//    },
`
Can anybody tell me if this is possible or where I am going wrong. THanks in advance.

In case it helps these are three optional states of the mirror I am trying to achieve.

Completely Blank.
All modules and background displayed.
Only clock and Background image displayed like a photoframe.

Cheers

Hello @JonoGee,
Thanks for using this module and very sorry for your inconvenience.
Honestly, I've never tested this module with multiple buttons (maybe that's why I named it singular, not plural ;-)), and checking the code it seems that it is not possible today.
However if you are open to do some manual hacking these steps may work (not tested):

Duplicate and rename the MMM-ModuleToggleButton folder within your mirror's modules folder (e.g. MMM-ModuleToggleButton2).
In your mirror's config refer to one of the modules with the new folder name.
In the new folder in both node_helper.js and MMM-ModuleToggleButton.js change the values TOGGLE_BUTTON_PRESSED and TOGGLE_BUTTON_CONFIG to a new value (e.g. TOGGLE_BUTTON_2_PRESSED and TOGGLE_BUTTON_2_CONFIG).

I'm not sure it will work, but it can be a quick hack. Please let me know.
I'm saving this issue as a feature request.

You’re rock n roll man!!
Thankyou for taking the time to get back to me.
I will certainly try that out. I did kinda try but I lost the plot and got myself really confused when neither button would work.
I’ll follow your guidelines and if I have any success tweaking I’ll be sure to share.
Have a great evening.
Regards
Jonathan Gee
Sent from my iPhone
On 15 Jun 2019, at 09:11, György Balássy <notifications<EMAIL_ADDRESS>wrote:
Hello @JonoGeehttps://github.com/JonoGee,
Thanks for using this module and very sorry for your inconvenience.
Honestly, I've never tested this module with multiple buttons (maybe that's why I named it singular, not plural ;-)), and checking the code it seems that it is not possible today.
However if you are open to do some manual hacking these steps may work (not tested):

Duplicate and rename the MMM-ModuleToggleButton folder within your mirror's modules folder (e.g. MMM-ModuleToggleButton2).
In your mirror's config refer to one of the modules with the new folder name.
In the new folder in both node_helper.js and MMM-ModuleToggleButton.js change the values TOGGLE_BUTTON_PRESSED and TOGGLE_BUTTON_CONFIG to a new value (e.g. TOGGLE_BUTTON_2_PRESSED and TOGGLE_BUTTON_2_CONFIG).

I'm not sure it will work, but it can be a quick hack. Please let me know.
I'm saving this issue as a feature request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/balassy/MMM-ModuleToggleButton/issues/3?email_source=notifications&email_token=AMGMOWERIL4F6MJW47S42ELP2SP43A5CNFSM4HXZMXMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYS7EY#issuecomment-502345619, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMGMOWCYIKJ3LVQTV6N52JDP2SP43ANCNFSM4HXZMXMA.


Playground tab

Would be amazing if there was something like a playground tab where I could enter a website URL, change the settings in Request (i.e. basic\plain and chrome driver and advanced options like js) and the settings in the filters and immediately see the result as plain text (snapshot)
This will be a tremendously helping tool while setting up a new page for monitoring

I believe this can be closed now that there's a "Preview" button on the filters section


Sedimentary Rock Page– Need Grain Size

The Sedimentary Rock page needs to have the forms to enter grain size and needs to display grain size. It is an issues when you try to edit the grain size or lithology for stratigraphic column intervals.
I updated the "Sedimentary Lithologies- Lithology" Kobo form, but did not deploy it.

Someone, at some point, decided grain size should be on the Lithologies -> Textures tab, not on the Lithologies -> Lithology tab. The Sedimentary Rock page is just a copy of the Lithologies -> Lithology tab.
I guess we could have the grain size information on both the Lithologies -> Lithology tab and Lithologies -> Textures tab as long as the fields are exactly the same. The same grain size information would then also then show up on the Sedimentary Rock page.
Just confirming that you want those grain size fields you added to Lithologies -> Lithology to be duplicated or did you want them removed from Lithologies -> Textures?

@panamint55 Any thoughts on this modification? Having grain size on both Lithologies -> Lithology tab and Lithologies -> Textures tab.

Probably just lithologies
From: Jessica Good @.>
Reply-To: StraboSpot/StraboSpot2 @.>
Date: Tuesday, September 26, 2023 at 12:20 PM
To: StraboSpot/StraboSpot2 @.>
Cc: Doug Walker @.>, Mention @.***>
Subject: Re: [StraboSpot/StraboSpot2] Sedimentary Rock Page– Need Grain Size (Issue #492)
@panamint55https://github.com/panamint55 Any thoughts on this modification? Having grain size on both Lithologies -> Lithology tab and Lithologies -> Textures tab.
—
Reply to this email directly, view it on GitHubhttps://github.com/StraboSpot/StraboSpot2/issues/492#issuecomment-1735969100, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACG2MN6TV7W7BYTR6Y6NWRDX4MFFRANCNFSM6AAAAAAU6MP73M.
You are receiving this because you were mentioned.Message ID: @.***>


Missing GroupVersion on AgentCluster

This is in line with the AWS provider.  Without this the cluster.InfrastructureRef is missing the Kind and APIVersion, and therefore CAPI has trouble reconciling.

For context https://github.com/kubernetes/client-go/issues/541
/lgtm
/approve


Most of icons are broken (displayed like squares)

VSCode Version: 1.51.0
OS Version: Win10 version:1903

Steps to Reproduce:

Just install the editor and open. See the screenshot

Does this issue occur when all extensions are disabled?: Yes

FYI, when launching the editor by the right-click menu of a file, icons come back, but some of them are still broken. See the screenshot below:

However, under this case, if doing "open the folder" in the screen, the icons are broken again just like the first screenshot.

Can you open the dev tools and inspect one of the broken images?

Do you mean this?

This looks like the bundled files (codicons and seti) failed to load, and the same as https://github.com/microsoft/vscode/issues/85872
I've can't repro on Windows using the same version of VS Code.

The problem is fixed by reinstall the font in #85872. Thanks for your reply!


Implements option to publish a k8s workflow in SDK

Describe your changes and why you are making these changes
Adds option to publish a k8s workflow in SDK
from aqueduct import FlowConfig
k8s_integration = client.integration("k8s_integration")
no_input_flow_k8s = client.publish_flow(
    name = "No input k8s",
    artifacts = [output],
    config = FlowConfig(engine=k8s_integration),
)

Related issue number (if any)
Eng-1555
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[x] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[x] I have run the integration tests locally and they are passing.
[x] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[x] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

API looks good to me!


Support Arbitrum network.

Is there anyone who knows the way to config the Onboard to support the Arbitrum network on metamask and Trustwallet?
Is this possible with current version? I can see only some specific networkIds are available for now.

@GuruJustin You should be able to pass in the Arbitrum networkId and the networkName as shown here.
const onboard = Onboard({
  // ... other init options
  networkId: 421611,
  networkName: 'arbitrum'
})

That networkId will get passed to which ever wallet the user selects.
For hardware wallets, you'll most likely need to utilize the custom network feature as shown here in our docs.
Let me know if that helps!


Change the wording of the interactive audit prompt so it is less confusing for users

Related issue
Supports internal backlog issue 671
Before these change:

After these changes

oh lmao, I thought you already made the change and pushes it

oh woops, I thought you already made the change and pushed it. Ill rereview after the changes are made

No problem, I'll push up the changes soon!

Hmm, one of the tests is failing:
=================================== FAILURES ===================================

_____________ TestIbmCloudIamDetector.test_verify_payload_not_json _____________

self = <ibm_cloud_iam_test.TestIbmCloudIamDetector object at 0x7f02fd1711d0>

    @responses.activate

    def test_verify_payload_not_json(self):

        responses.add(

            responses.POST, 'https://iam.cloud.ibm.com/identity/introspect', status=200,

            body='not json', headers={'content-type': 'not/json'},

        )

        with pytest.raises(Exception):

>           IbmCloudIamDetector().verify(CLOUD_IAM_KEY)

E           Failed: DID NOT RAISE <class 'Exception'>

tests/plugins/ibm_cloud_iam_test.py:134: Failed

=============================== warnings summary ===============================

tests/util_test.py::test_version_compare[0.13.0-ibm.6-dss-0.13.0+ibm.7.dss]

  /home/travis/build/IBM/detect-secrets/.tox/py37/lib/python3.7/site-packages/packaging/version.py:114: DeprecationWarning: Creating a LegacyVersion has been deprecated and will be removed in the next major release

    DeprecationWarning,

-- Docs: https://docs.pytest.org/en/stable/warnings.html

=========================== short test summary info ============================

FAILED tests/plugins/ibm_cloud_iam_test.py::TestIbmCloudIamDetector::test_verify_payload_not_json

================== 1 failed, 1214 passed, 1 warning in 9.83s ===================

ERROR: InvocationError for command /home/travis/build/IBM/detect-secrets/.tox/py37/bin/coverage run -m pytest tests (exited with code 1)

___________________________________ summary ____________________________________

ERROR:   py37: commands failed

Makefile:16: recipe for target 'test' failed

make: *** [test] Error 1

The command "make test" exited with 2.

This shouldn't have anything to do with my changes since all I'm doing is changing some auditing text. Plus the tests were passing last week for this type of change. I'm assuming it has to do with a pip package update. Investigating...

This shouldn't have anything to do with my changes since all I'm doing is changing some auditing text. Plus the tests were passing last week for this type of change. I'm assuming it has to do with a pip package update. Investigating...

Fixed this issue with pr https://github.com/IBM/detect-secrets/pull/44


BIGTOP-4062. Upgrade Spark to 3.3.4.

https://issues.apache.org/jira/browse/BIGTOP-4062
The latest maintenance release of Spark 3.3 series with security and correctness fixes is available.

ran smoke test of spark on Ubuntu 22.04 x86_64.

building and testing on Rocky Linux 8 aarch64 now.

+1, tested on Fedora 38 (x86_64). Thanks @iwasakims.
$ ./gradlew allclean spark-pkg repo -Dbuildwithdeps=true
$ (cd docker/bigtop-puppet && ./build.sh trunk-fedora-38)
$ (cd docker/bigtop-slaves && ./build.sh trunk-fedora-38)
$ (cd provisioner/docker && ./docker-hadoop.sh -d -dcp -C config_fedora-38.yaml -F docker-compose-cgroupv2.yml -G -L -k hdfs,yarn,spark -s spark -c 3)

...

org.apache.bigtop.itest.spark.TestSpark > testSparkSQL STANDARD_OUT
    SPARK_MASTER isn't set. yarn will be used as the master URL. Refer to smoke-tests/README If this isn't what you you expect.

org.apache.bigtop.itest.spark.TestSpark > testSparkR STANDARD_OUT
    SPARK_MASTER isn't set. yarn will be used as the master URL. Refer to smoke-tests/README If this isn't what you you expect.

Gradle Test Executor 2 finished executing tests.

> Task :bigtop-tests:smoke-tests:spark:test
Finished generating test XML results (0.006 secs) into: /bigtop-home/bigtop-tests/smoke-tests/spark/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.011 secs) into: /bigtop-home/bigtop-tests/smoke-tests/spark/build/reports/tests/test
Now testing...
:bigtop-tests:smoke-tests:spark:test (Thread[Daemon worker,5,main]) completed. Took 49.935 secs.

BUILD SUCCESSFUL in 2m 15s


Hugo deploy issue

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
dss7jdt6jz73o
AWS Region
us-east-1
Amplify Hosting feature
Not Applicable
Describe the bug
I'm trying to deploy my hugo site on Amplify. My personal domain is configured, but I still can't open my site, either from the domain provided by Amplify or from my own domain.
Expected behavior
Site working well
Reproduction steps
None
Build Settings
version: 1
frontend:
  phases:
    build:
      commands:
        - rm -rf /usr/bin/hugo
        - wget -q https://github.com/gohugoio/hugo/releases/download/v${VERSION_HUGO_NEW}/hugo_extended_${VERSION_HUGO_NEW}_Linux-64bit.tar.gz
        - tar -xvf hugo_extended_${VERSION_HUGO_NEW}_Linux-64bit.tar.gz
        - mv hugo /usr/bin/hugo
        - rm -rf hugo_extended_${VERSION_HUGO_NEW}_Linux-64bit.tar.gz
        - hugo
  artifacts:
    baseDirectory: public
    files:
      - '**/*'
  cache:
    paths: []

Log output

# Put your logs below this line

Additional information
Error message: Failed to load resource: the server responded with a status of 404 () allonsygamma.com/:1

Hi @yinxiangshi I deployed a basic Hugo app with your exact build script and Hugo version but I did not run into any issues. However, it appears that there isn't an index.html file generated in the public folder during the builds for your application:
!! No index.html detected in deploy folder

Can you confirm if you're able to successfully build your app locally?

I just take a look. In my local environment, I can use hugo server to deploy locally, and everything works well. I tried to use hugo to generate the public folder, and everything is still all good.

@hloriana Hi, I just opened a new app, and make all the files locally instead of using the git submodule. It successes builds, however, my pictures don't load. I got this error message: Failed to load resource: net::ERR_NAME_NOT_RESOLVED, do you know why? I am not the front developer, sorry about that. App id: d2qb4xwieziuir

@yinxiangshi Try adding this SPA redirect rule:
    {
        "source": "</^[^.]+$|\\.(?!(css|gif|ico|jpg|js|png|txt|svg|woff|ttf|map|json)$)([^.]+$)/>",
        "target": "/index.html",
        "status": "200",
        "condition": null
    }

This should allow the jpg files to load appropriately. Please refer to Redirects for single page web apps (SPA) for more guidance on this.

@hloriana Thanks for the help. Plz take a look at my newest ticket, thanks a lot.


[Core-http] support specifying service versions for ServiceClient

There are scenarios where clients with different service versions are desired. One example is to support features from multiple service versions in a single SDK library.
Currently we can only specify a service version (different from default) via x-ms-version header in RequestOptionsBase.customHeader. This is per operation. It would be nice to have option to set it at the client level.
.NET/Java support passing service version when creating clients. For example, Java has https://github.com/Azure/azure-sdk-for-java/blob/0f2e88fdb13ab4432dfc366979504badb867e266/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceAsyncClient.java#L88
@bterlson @xirzec

Is this in any way related to #5508?
cc @daviwil

As far as I can tell, #5508 is about generating constructors (whether apiVersion should be a required parameter).  I looked at service client code and haven't found any places where this version is passed to the base ServiceClient class. I have a draft PR that allows passing version via service client options.

I found that core-http walks up the hierarchy of ServiceClient, if the following is in the swagger, it can find the version value from this.version.
        "ApiVersionParameter": {
            "name": "x-ms-version",
            "x-ms-client-name": "version",
            "in": "header",
            "description": "Specifies the version of the operation to use for this request.",
            "required": true,
            "type": "string"
        },

However, blob swagger has a different config
    "ApiVersionParameter": {
      "name": "x-ms-version",
      "x-ms-client-name": "version",
      "in": "header",
      "required": true,
      "type": "string",
      "description": "Specifies the version of the operation to use for this request.",
      "enum": [
        "2019-02-02"
      ]
    },

The enum line makes the codegen file to hardcode the version, because 2019-02-02 is the only valid value. Queue also has the version hard-coded.

So in summary, it is already supported to create a client that targets a different api version, as long as the swagger json is properly authored to allow multiple versions.

After I added another valid version string to the enum in swagger json, the generated constructor has the required version parameter. So closing this because we already support multiple service versions.


Add an option to not show "Successfully ran macro" notifications

I know it may not be obvious if a macro runs successfully, but sometimes it is when the commands in the macro create their own notifications. Perhaps a user should be able to choose one of three settings: one where notifications are off on all macros, one where they're all on, and one where the user can pick per macro whether it sends a notification.

+1 to this. I use macros to enable various focus plugins, so pretty obvious when it fires :D

Yes please, it's an unneccessary distraction for me.

I didn't fix it but made it better. It's now just a very short blip.
In your vault folder in explorer or finder go to .obsidian\plugins\obsidian-better-command-palette/
Open main.js. It was very messy for me so in Notepadd++ I used the plugin JSTool, the JSFormat option of that, to tidy it up. But that's not necessary, just simpler.
Ctrl+F for
new e.Notice(Successfully ran "${this.name}"),
and comment that out with //.
Keep the !0 after if uncommented. Mine looks like this:

It's in the callAllCommands() function.
It's better now!


Convert DOS line endings to UNIX.

This change is

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Block events don't register the correct world

[13:13:02 INFO]: name=PlayerEvent event_id= game_time=5282 world=yyy x=-123 y=130 z=283 action=move player=xxxx from_x=-123 from_y=130 from_z=284 to_x=-123 to_y=130 to_z=283
[13:13:03 INFO]: name=BlockEvent event_id= game_time=3437293 world=DEFAULT x=-122 y=132 z=284 action=block_broken block_type=WOOD_STAIRS player=xxxxx base_type=WOOD_STAIRS
These blocks are being placed in a named world, not "DEFAULT"

Could be related to #10 in that this piece of code isn't handling a world name with a space well?

I don't think so. PlayerEvent world= Block Event world=DEFAULT implies the former is asking for name and the latter is asking for worldType as if it's using the wrong module for the value. can you take a look?

I have implemented a fix via PowerSchill/minecraft-app@235ed45063c5e1c56bfd2b741cc4db4d85f3dc75
The worlds are currently world, world_the_nether, and world_the_end for overworld, the nether, and the end respectively.


Changing prefix the admin panel not run

Hi,
When I change the prefix of the api, ie to "/api/v2", the admin panel do not let me login, the screen appears black and two alerts is shown whit the message "Not found" and "Error - Not found".
There are two AJAX request that response 404:

http://localhost:1337/admin/config
http://localhost:1337/auth/logout

I try to change the routes.json of the admin module, but still do not run.

duplicated #68


Huawei hosted Kuberenetes Provider

Do this yourself. Activate the cluster drivers. May need credentials.
Need new (separate) docs about activating cluster drivers.


Wrong calculation until reload

Current behavior
In some cases the extension shows wrong times and dates. This can be 'fixed' by reloading the page.
Expected behavior
The times and dates are displayed correctly in always

I noticed this happening when navigating across multiple pages:

Example: The times would be correct initially (page 1), but after clicking to the next page, they would not.

This would resolve itself if I reloaded or if I clicked a bid preference for any task on the page. This also seemed to start happening during a period of high traffic, so I don't know if that is related.

For me it looks like that this bug is also fixed (rather unintentional) by https://github.com/deichcode/chisv-helper/releases/tag/1.0.3. Can you verify this and tell me if it looks the same for you


Correctly map between UTF-8 and UTF-16 positions

Fixes #202

Current concerns:

ColIndex is always used together with LineIndex, so I would rather make the former a field of LineIndex. Any objections to this?
It would be great to have integration tests for this, but I have no idea where they should go. Any suggestions are welcome.

ColIndex is always used together with LineIndex. Though I had to write quite some boilerplate to keep them separate, in the end I would rather make ColIndex a field of LineIndex. Any objections to this?

Yeah that's a lot of duplicated boilerplate. I would rather have one "file_line_index" type method instead of both file_line_index and file_utf16_line_index.

Yeah, let's make utf16_lines: FxHashMap<u32, Vec<Utf16Char>>, a field of LineIndex!

bors r+

bors r-

I think it's important to mark somehow that col is utf16, it's not obvouls from looking at the type definition. I think a doc comment would be fine, but probably just naming field col_utf16 works best?

Otherwise, LGTM! :+1:

@matklad In the values of the utf16_lines hashmap we could use SmallVec instead of Vec to store instances of Utf16Char. We don't expect too much UTF16 chars per line, so we might as well store them inline. Do you think it is worth it or should we keep the Vec?

@aochagavia I was thinking about SmallVec, but I think that's a premature optimization: the number of lines with UTF-16 is small, so it should not matter if storage for a particular line is big.

Just pushed a commit to update col to col_utf16

bors r+

bors r+


add support for emoticons

A good Github developer is able to express her intentions and feelings with the appropriate usage of emoticons.
Repairnator should be able to do the same: to decorate its pull-requests and comments with emoticons.
For this, we could use the whole Github data to train a predictor of emoticons for software development (and GIF!).
Thanks to @TobiasWrigstad for the nice conversation where the idea popped-up:)

Repairnator could also decorate his PR with some XKCDs. (original idea by Alex Nodet)


Make phone verification mandatory

Only affects signed in users.
Does not affect users on a Devise controller.
Does not affect users in the Verifications controller.
Now redirects to root_path upon successful verification.
Additional text added to the verify page to explain its purpose and make
it less unpleasant.
The users factory will now default verified to true.
Appropriate specs added for ApplicationController.
Implements #200

Some new text added to the verify page.

I did some manual testing where I invited a new user and registered as it, then went through the verification process. Seemed to work fine. I also tried manually unflagged that user as verified, and sure it enough it redirected me as expected. I ensured that users are able to edit their registration info while signed in and unverified.

Nice new design! Looks much better.


Preserve line breaks with autocorrect

Our project has a prettier checks that fails if the key: value has more than x lines. Therefore, we run the prettier's autocorrect and everything's fine.
But the yalphabetize's autocorrect doesn't follow this logic and remove the line breaks automatically, causing potential issues for out CI
What do you think about this, can it be easily handled ?
Before autocorrect:

After autocorrect:

Thanks @MerciMax. I can look into this at some point but it might take me a while. I don't have much capacity currently. Feel free to have a go at it yourself if you fancy the challenge

The Psych library which we use to parse our yaml files doesn't offer a neat solution to this problem. I will have a go at writing some of my own logic at some point.
However this is a valid issue which would be good to address; Yalphabetize is only intended to reorder YAML mappings. It shouldn't change the structure of your YAML.
@MerciMax please could you provide me with some information about the Prettier checks which you are using to control your YAML line length? I would like to be able to recreate the YAML structure's that are being produced by Prettier.

@MerciMax I have looked more closely at your example. Could you solve your issue by using the block scalar style?
parent:
  b: "short text"
  a: |
    "Long text - Long text - Long text - Long text - Long text - Long text - Long text - Long text - Long text - Long text -"

Yalphabetize will not remove the line break in this case.

I've just checked and indeed, the block scalar style doesn't remove the linebreak. So i'm closing this issue ! Thanks a lot for the follow up :-)


Mixed precision: scheduler called in the wrong order

This bug is a result of the following PL issue: https://github.com/PyTorchLightning/pytorch-lightning/issues/5558

Closing as there's nothing actionable from the transformers side, you can keep track of that issue for progress.


Fix #3327 add multiformat_supported field

Adds a new field multiformat_supported to the bidder table, which indicates the behaviour of a bid adapter when more than one media type (banner, native, video) is being requested.
Possible values are

will-bid-on-any - bidder will bid on any media type
will-bid-on-one - bidder will prioritize one media type and ignores the others
will-not-bid - bidder will not bid at all

🏷 Type of documentation

[x] new feature

Added the new field to the pbs java and go adapter docs as well :smile:


No Api Keys

Pull Request Title

Removed  Vector Databases
Related Issue

Description

Type

[x] Bug Fix
[x] Feature Enhancement
[ ] Documentation Update
[x] Code Refactoring
[ ] Other (please specify):

Proposed Changes

Screenshots / Code Snippets (if applicable)

How to Test

Checklist

[x] The code compiles successfully without any errors or warnings
[x] The changes have been tested and verified
[ ] The documentation has been updated (if applicable)
[x] The changes follow the project's coding guidelines and best practices
[ ] The commit messages are descriptive and follow the project's guidelines
[ ] All tests (if applicable) pass successfully
[ ] This pull request has been linked to the related issue (if applicable)

Additional Information

Thanks a lot, @SubramanyamChalla24, for this PR. It's much needed, as it'll ease the process of knowing the % match score of the resumes and the JDs.
Before merging, I will be testing out this PR on:

Mac OS 14
Unbuntu 22.04 on WSL

Python Version will be 3.11 (the one with GIL)

@SubramanyamChalla24, the changes are working smoothly on MacOS!

I'll keep this PR open if anyone wants to test it on Windows, and Linux. Else, by Friday I will merge it.

@Devasy23 @imhalcyon @Sayvai Please can you help me in testing this on:

Windows
Docker
Different versions of Python 3.10 to 3.12 (I'm doing 3.11)

I'll review before Friday, but the dependencies weren't working for me on Linux with python 3.10

Okay then we make sure that we'll mention Python 3.11 specifically

Also, we'll have to clean the Requirements.txt file as well

@Devasy23, those are some excellent add-ons. Once this PR gets merged tomorrow, you can do a PR that updates this.


Permissions to view VMinsights-maps

Hi,
Can we get custom resource-provider-operations (custom RBAC role actions) which allows to view the VMinsights-maps ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a3231f7-edb9-b5a4-159a-799ffcbea1e8
Version Independent ID: 3de22e57-4beb-0d2f-337e-921fa46101ab
Content: View app dependencies with Azure Monitor for VMs - Azure Monitor
Content Source: articles/azure-monitor/insights/vminsights-maps.md
Service: azure-monitor
Sub-service: ****
GitHub Login: @bwren
Microsoft Alias: bwren

@kgopi05 Thank you for your query, we will look into it and get back to you at the earliest.

@kgopi05 Apologies for delayed response on this thread. To enable and access the features in Azure Monitor for VMs, you must have the Log Analytics contributor role, please refer to this  documentation for additional details.
Hope the above information helps. At this point it appears that there's no further edits or updates needed to the documentation. We will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


Function to convert seconds to human readable time string. - 43

[Auto generated]
Number: [#43]

pyhelper-utils(jYHS3)[PR 43]: Closing issue for PR: Function to convert seconds to human readable time string..
PR was closed.


Use milliseconds as an interval unit in EurekaEndpointGroup

Motivation:
We almost always use milliseconds as the default unit for representing a
duration or interval.  EurekaEndpointGroupBuilder.registryFetchIntervalSeconds()
is the only exception we have.
Modifications:

Add EurekaEndpointGroupBuilder.registryFetchIntervalMillis() which
deprecates registryFetchIntervalSeconds()
Miscellaneous:

Improved validation for registryFetchInterval(Duration)
HealthCheckedEndpointGroupBuilder now overrides retryIntervalMillis().

Result:

Consistency
(Deprecation) EurekaEndpointGroupBuilder.registryFetchIntervalSeconds()
has been deprecated in favor of registryFetchIntervalMillis().

I also find EurekaUpdatingListenerBuilder uses seconds instead of milliseconds. It's because Eureka exposes its node metadata in seconds. We have two options:

Accept milliseconds when building, convert it to seconds while rounding up.
Leave it as it is.

Updated EurekaUpdatingListenerBuilder to use milliseconds rather than seconds.

Stil LGTM

Thanks for reviewing!


Add support for metric collection in the Google provider

This adds support for metric collection in the GCP provider. The metrics collected are cpu, network and disk.
Note that the tests are currently pretty weak; I'm working on that now to hopefully provide more coverage, so this PR might get updated. Also, while I'm able to force metrics to get collected via the UI by pressing the C&U refresh button, I haven't yet figured out how to make ManageIQ collect metrics in the background automatically.  Any tips?

/cc @blomquisg @erjohnso @agrare

@miq-bot add_label providers/google
@miq-bot add_label enhancement

OH, another discussion point - note that I'm returning data points only every 60 seconds.  It looks like a lot of the code assumes that real-time metrics are every 20 seconds; however I haven't seen any problems yet with this (the UI looks fine at least). I assume the system treats the other data points as "missing", but I'm not entirely sure yet.

I updated the PR to have some additional specs around metrics. Please let me know if there's a better way to test metrics.

I don't know the impact of only having realtime metrics every 60sec, @Fryguy ?

@Ladas can you review this too? Dig back to when you revamped OpenStack metrics.

There is a lot of code that requires 20 second intervals both on the processing side and on the UI side.  @selmanj What you can do, and what we do in other providers, is to change the VIM_STYLE_COUNTERS to have 20s as the interval, and then when you capture the metric for a 60-second interval, just create 3 records, one at t, one at t - 20, and one at t - 40.

@Fryguy I was really hoping to avoid the interpolation on the storage-side, as it is deceptive and permanently persisted to the DB.  It also gets very strange when talking about metrics that aren't "rates" (like delta metrics for example).
Personally, I've been on the operations side and metrics are amazing for diagnosing when things go south; however you have to be able to trust metrics and as soon as we start to interpolate it gets harder to determine which points are real samples and which ones are not.
Can you point me to the code that relies on 20 second metrics?  If it's not that much code, perhaps it'd be easier to put a layer between that code and the DB that does the 20-second interpolation on demand, and then allow providers to return whatever time-intervals they want.

@selmanj I totally agree, and this is one of the driving factors behind the TSDB refactoring.  In fact part of the refactoring work is to remove that interpolation.  For now though, keeping it in the provider is probably the best bet.  It turns out that subdividing a 60 second metric into 3-20 second metrics isn't that bad.  For deltas, you just say that there was 0 change between the interpolated values.
I'm looking for the file but can't find them at the moment.  I know it used to be in the charting code in the UI, in reporting, and of course in the metrics capture and rollup code...basically there were things that assumed 180 records (3*60 = 1 minute's worth) and would divide by 180, for example, to get the average.

Added code to interpolate values for :20 and :40 second offsets.  Ready for review.

Friendly ping; this is ready for review.

@Ladas can you take a look too?

looks great :+1:
it seems to have correct 20s intervals and units, so it should work correctly :-)
btw. Google doesn't have memory utilization?

@Ladas looks like not, https://cloud.google.com/monitoring/api/metrics#gcp-compute

@Ladas if you install the logging agent on your VM, then you can get memory utilization as well: https://cloud.google.com/logging/docs/agent/
However this isn't necessarily installed on every VM.

@selmanj cool, something for future enhancements maybe. :-)

@chessbyte I think this has all the necessary LGTMs and is ready to merge.


tsp, avs, remove Update model to keep consistency with stable Swagger

Keep the model consistent with stable Swagger 2023-09-01
https://github.com/Azure/azure-rest-api-specs/blob/600a8ba6831118671ae3f42694ab20d8cdc46dd7/specification/vmware/resource-manager/Microsoft.AVS/stable/2023-03-01/vmware.json
ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[x] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

I just curious if the stable swagger is really reflecting what the service backend behavior? like those properties in the original model are really all updatable?

Allen is upgrading the whole repo for typespec 0.57/0.43. Will hold on this PR till his PR get in.

Allen is upgrading the whole repo for typespec 0.57/0.43. Will hold on this PR till his PR gets in.

Taking this PR out of review queue until work is completed on your end. Please label the PR as ready for being reviewed as soon as  upgrade work is completed.

Allen is upgrading the whole repo for typespec 0.57/0.43. Will hold on this PR till his PR gets in.

Taking this PR out of review queue until work is completed on your end. Please label the PR as ready for being reviewed as soon as upgrade work is completed.

Allen's PR merged.
I've merge latest main into this PR, and it is ready for ARM review. Thanks.


Search categories streamlined

This makes creation of references brain dead simple: X<$category,$item> is how it works instead of cryptic rules nobody understands.

The bad news is I cannot really test it with just Documentable:
➜  Documentable git:(search-categories-streamlined) ./bin/documentable setup -o
Setting up the directory...
Copying files...
Done.
➜  Documentable git:(search-categories-streamlined) ./bin/documentable start -a --force
No pod in cache associated with '/home/koto/Devel/Documentable/doc/HomePage.pod6'. Has the path changed?
  in method pod at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/16A9686EA4CFC0E9418FEB2C3BDDD0FFB09554E7 (Pod::From::Cache) line 118
  in method load at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/CF97824732E11EBB99505A3911A971224519CF0A (Documentable::Registry) line 60
  in method generate-main-page at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/677E0B857640AD7C699D43EAFA5F9550AE91E0B5 (Documentable::DocPage::Factory) line 40
  in method generate-home-page at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/677E0B857640AD7C699D43EAFA5F9550AE91E0B5 (Documentable::DocPage::Factory) line 31
  in sub MAIN at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/5DD7BBCC86020F8BEFA44ABED316A9B23D8F14AC (Documentable::CLI) line 200
  in sub RUN-MAIN at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/5DD7BBCC86020F8BEFA44ABED316A9B23D8F14AC (Documentable::CLI) line 36
  in block <unit> at ./bin/documentable line 3

➜  Documentable git:(search-categories-streamlined)

@JJ  any ideas?

I'm right now starting my holiday... Won't be able to do much this week, sorry. Will get around to it when I'm back

You might need to delete the local cache. It's surprisingly passing (mostly) in CI. I'll have to check what's the deal with circleci

You might need to delete the local cache. It's surprisingly passing (mostly) in CI. I'll have to check what's the deal with circleci

TODO: document how calculate-category works.

The errors in CircleCI seem genuine, including duplicate index terms and so on. Can you please check them out?

The bad news is I cannot really test it with just Documentable:
➜  Documentable git:(search-categories-streamlined) ./bin/documentable setup -o
Setting up the directory...
Copying files...
Done.
➜  Documentable git:(search-categories-streamlined) ./bin/documentable start -a --force
No pod in cache associated with '/home/koto/Devel/Documentable/doc/HomePage.pod6'. Has the path changed?
  in method pod at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/16A9686EA4CFC0E9418FEB2C3BDDD0FFB09554E7 (Pod::From::Cache) line 118
  in method load at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/CF97824732E11EBB99505A3911A971224519CF0A (Documentable::Registry) line 60
  in method generate-main-page at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/677E0B857640AD7C699D43EAFA5F9550AE91E0B5 (Documentable::DocPage::Factory) line 40
  in method generate-home-page at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/677E0B857640AD7C699D43EAFA5F9550AE91E0B5 (Documentable::DocPage::Factory) line 31
  in sub MAIN at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/5DD7BBCC86020F8BEFA44ABED316A9B23D8F14AC (Documentable::CLI) line 200
  in sub RUN-MAIN at /home/koto/.rakubrew/versions/moar-2022.03/install/share/perl6/site/sources/5DD7BBCC86020F8BEFA44ABED316A9B23D8F14AC (Documentable::CLI) line 36
  in block <unit> at ./bin/documentable line 3

➜  Documentable git:(search-categories-streamlined)

@JJ any ideas?

The error in CircleCI can give you additional hints, but the error in cache might be solved by deleting the local cache. It sometimes happens when there are changes in the Raku version that generated the cache.

@JJ had to take some time to get back to this emotional burden attached code, but I believe it's in a better shape now thanks to your comments now.
The tests pass for me locally, I re-instantiated some hacks and overall made the number of changes smaller.
The bad thing is I'm sure we won't be able to get backward compat here (unless explicitly introducing something like $*NEW-REFERENCES-FORMAT kind of flag, which will be both cumbersome and slower), but the older docs revisions can utilize some upper bound fixed version of Documentable, as the features are rarely getting into it now.


Update name of "MatesController"

Resolves https://github.com/arduino/library-registry/issues/500

Hi @per1234,
Do we need to do anything else on our end so that this pull request to be accepted and merged?
I read in one of the older open pull request #347 about how this is processed. I also noticed that this pull request was from a month ago.
Can you give us a bit of an idea regarding how long usually these kind of requests are processed and will take effect?

Do we need to do anything else on our end so that this pull request to be accepted and merged?

No. All that was needed from you was to update the name value in library.properties, make a tag, and submit a request for the name change. You have done all of those things perfectly so now all the rest is our responsibility.
The rename is not so simple as merging this pull request by itself. The database must be updated. Once that has been done, this pull request will be merged immediately.

I read in one of the older open pull request #347 about how this is processed.

I replied in your request with a quick overview of the situation:
https://github.com/arduino/library-registry/issues/500#issuecomment-922601271

Can you give us a bit of an idea regarding how long usually these kind of requests are processed and will take effect?

Sorry, but I don't have any idea how long it will be.

Thanks @per1234


docs: update SFRA version in response to feedback

Current dependencies on/for this PR:

main

PR #177  (this PR)

This comment was auto-generated by Graphite.

Merging this quickly so I can push to link_imgix repo @luqven


$http.delete causes non-zero Content-Length header in IE10 due to passing undefined to xhr.send

Since 1.4.0-rc1 and confirmed in 1.4.1, calling $http.delete('url') in IE10 causes a non-zero Content-Length header to be added to the request. I noticed this when the webserver was returning HTTP error code 415 on all $http.delete calls.
I tracked this down to 1.4.0-rc1 where xhr.send(post || null) in createHttpBackend was changed to xhr.send(post). When post is undefined, this problem occurs in IE10. The code below reproduces this bug in IE10 and is essentially what $http.delete('url') is doing.
var xhr= new window.XMLHttpRequest();
var post;
xhr.open('DELETE', 'url', true);
xhr.send(post);

Changing xhr.send(post) to xhr.send(post || null) fixes the problem.

This was changed in e04a887c9b506de18516600310fe6e529d9d2ca3 (which looks like a valid fix). I guess we need to find another work-around for IE (probably be explicitly passing null for the requests without body)

This issue seems to affect AngularJS 1.4.3 on IE11 as well. I was able to work around it by passing { data: null } as second parameter to the delete() method of the $http service.

This defect also affects POSTs with no data.


[SPARK-22411][SQL] Disable the heuristic to calculate max partition size when  dynamic allocation is enabled and use the value specified by the property spark.sql.files.maxPartitionBytes instead

What changes were proposed in this pull request?
The heuristic to calculate the maxSplitSize in DataSourceScanExec is as follows:
https://github.com/apache/spark/blob/d28d5732ae205771f1f443b15b10e64dcffb5ff0/sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala#L431
bytesPerCore is calculated based on the default parallelism. Default parallelism in this case is the number of total cores of all the registered executors for this application. The heuristic works well with static allocation but with dynamic allocation enabled, defaultParallelism is usually one (with default config of min and initial executors as zero) at the time of split calculation. This heuristic was introduced in SPARK-14582.
With dynamic allocation it is confusing to tune the split size with this heuristic. It is better to ignore bytesPerCore and use the values of 'spark.sql.files.maxPartitionBytes' as the max split size.
How was this patch tested?
Tested manually.

ping @davies

Can one of the admins verify this patch?

How about using spark.dynamicAllocation.maxExecutors for calculating bytesPerCore when dynamic allocation is enabled?

@gatorsmile Can you please take a look? I'd like to hear your thoughts on this.

ok to test

Generally, this looks reasonable to me. cc @cloud-fan @jiangxb1987

Test build #83736 has started for PR 19633 at commit 4157771.

Test build #83736 has finished for PR 19633 at commit 4157771.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83736/
Test PASSed.

Test build #83756 has started for PR 19633 at commit d3aff40.

Test build #83756 has finished for PR 19633 at commit d3aff40.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83756/
Test FAILed.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #93053 has finished for PR 19633 at commit d3aff40.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93053/
Test PASSed.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ping @vgankidi to update or close.


move resource options from Config to hostConfig

Cgroup resources are host dependent, they should be in hostConfig.
For backward compatibility, we just copy it to hostConfig, and leave it in
Config for now, so there is no regressions, but the right way to use this
throught json is to put it in HostConfig, like:
{
"Hostname": "",
...
"HostConfig": {
"Memory": 314572800,
...
}
}
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

@crosbymichael @unclejack @LK4D4 please take a look at this one, once this is good to go, the movement for other options will on their way soon.
Changes for test cases will in subsequent PR, these changes won't made any test cases fail.

@hqhq cool, thank you! But I think that this will be in 1.18 api version and we're now in sort of "code freeze"
@crosbymichael What should we do?

approach looks good to me.  Maybe we should do all the fields in one PR so we get everything updated in one merge.

and something in the release notes and API recent changes for those that were using the API.

updated, add all resource option changes in this PR.
@SvenDowideit do you mean add something for docs/sources/release-notes.md?
Shouldn't this be changed when we really release a version? Or do I need to do something in this PR?

I prefer to keep all related updates in one PR, that way they hit the repo together, and can't be forgotten. but tbh, I'm not sure what the process is.
so this PR is only about moving and renaming, and then #9536 adds better help?
in that case, Docs LGTM @fredlf @jamtur01

Docs LGTM

ping @crosbymichael @LK4D4

@hqhq You've got to rebase the PR because it can't be merged.

@unclejack @crosbymichael @LK4D4
Rebased.

A couple of copy-edits, otherwise docs LGTM.

I presume these API changes need to move to the 1.18 API doc

Why are we changing the CLI flag?

ping @ashahab-altiscale for the lxc template change

@jfrazelle Thanks for letting me know. Can you start an lxc build on this?

@cpuguy83 Do you mean we change --cpuset to --cpuset-cpus?
Because it's a better name, cpuset is not only for cpuset.cpus, but also for cpuset.mems, I was about to add support for cpuset.mems, by then, the name --cpuset would not be properly.

Rebased and move the API change to v1.18 API doc.

@hqhq ah, ok.  Also didn't notice originally that you did actually deprecate the old syntax properly.
So this LGTM.
Probably want to go ahead and squash commits.

LGTM

LGTM just needs commits to be squashed :) and maybe @crosbymichael because he is very good at catching weird things in the configs

Hi, sorry for the late, I'm not sure how these commits can be squashed any more, are you proposing to make all the changes in one commit?
I think it's better to do one thing in one commit, if you think it's better to take the whole movement as one thing, it's ok for me to squash it, just let me know what you think :)

Hi, this PR is depended by a lot of PRs, can we pick this up so we can move on?
@crosbymichael

ping.
@crosbymichael @jfrazelle @LK4D4

@crosbymichael @jfrazelle @LK4D4 @cpuguy83
Rebased again, I squash all commits into one commit, hope that's what you want.
Please review this, it have been taken too long (more than 4 months since the original PR), a lot of cgroup improvement are depending on this one, hope we can make some progress soon. Thanks.

ping @LK4D4 @crosbymichael @jfrazelle

As far as I can tell, this PR has both code and docs LGTM, and the commits have been squashed as requested. Thanks for you patience @hqhq, I'm merging this hoping that nobody will have any objections.


Async blob code samples

Verified correct formatting with sphinx locally.

Can one of the admins verify this patch?

client - ci and storage - ci checks are all green so I'm going to merge. Apparently there is a github bug that is causing the checks to look like they are still in progress.

client - ci and storage - ci checks are all green so I'm going to merge. Apparently there is a github bug that is causing the checks to look like they are still in progress.

verified green CI


Config system for includes/excludes is misleading (or broken)

Similar to https://github.com/cflint/CFLint/issues/185
I specify the following config and end up getting results for VAR_HAS_PREFIX_OR_POSTFIX or VAR_IS_TEMPORARY (and others).
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<!-- Available severity tags: FATAL, CRITICAL, ERROR, WARNING, CAUTION, INFO, COSMETIC -->
<config>
    <includes code="AVOID_USING_WRITEDUMP" />
    <includes code="VAR_TOO_SHORT" />
    <includes code="ARG_TYPE_ANY" />
    <includes code="VAR_TOO_LONG" />
    <excludes code="FUNCTION_TYPE_ANY" />
    <excludes code="COMPONENT_TOO_LONG" />
    <excludes code="UNUSED_METHOD_ARGUMENT" />
</config>

Using command line seems to act normal/expected:
-excludeRule FUNCTION_TYPE_ANY,COMPONENT_TOO_LONG,UNUSED_METHOD_ARGUMENT -includeRule AVOID_USING_WRITEDUMP,VAR_TOO_SHORT,ARG_TYPE_ANY,VAR_TOO_LONG
I'm not sure what the situation here is. I've seen the documentation on creating a config file, but it doesn't seem to make sense to me. It seems that if I want to use the config file, I have to go full-blown on setting up rules with class names and severities etc - and I don't think users should have to do that.  Maybe the documentation is misleading, but I want to use the default of everything essentially - just making sure that I can easily include or exclude rules via a config file.

What I've found is that in xml config the  is "all or nothing".
ie.

this works.

you leave included even one of those checks, all che "COMPONENT_" checks (actually, all checks from "ComponentNameChecker" class) are executed.

The config system developed over time - and could definitely use some attention :-).

I think this is resolved.

Is this broken again?
java -jar CFLint-1.0.0-all.jar -includeRule MISSING_VAR -file test.cfc -q -stats
results in

Instead I would expect it to only report something like

Workaround with this xml config file
<config inheritParent="false">     <includes code="MISSING_VAR"/> </config>
still sounds wrong to me.

Agreed.  I will look into this.

This came from making the 'config' hierarchical.    It is a little misleading what "include" means.  I made a minor change though: If you use the -includeRule parameter the config that is created now assumes inheritParent="false".   In the rest of the hierarchiarchy, include is additive not exclusive.


feat(cmd): kamel promote --export-gitops-dir

Introduced a --export-gitops-dir flag that will create a simple opinionated Kustomize based GitOps overlay directory. The result can be used to be stored in Git and be used as a source for any GitOps pipeline.
kamel promote my-it --to my-dest-namespace --export-gitops-dir /path/to/export/dir

Closes https://github.com/apache/camel-k/issues/5456

Release Note
feat(cmd): kamel promote --export-gitops-dir

FYI @cfitzw I think you were interested in this one.


Add Google Sign in , in the Login Screen

A Google sign in button would make the UX so much smoother for a new user to login fast.

We need server side integration also for this issue.

Yup, since this is android based i think we can keep the issue open until the backend code gets updated

Sure. I'll create a similar issue for server repo for Facebook & Google logins.

We won't be adding this to our application.


Snyk failing in Pipeline due to jsonpath-plus issue

What are the steps to reproduce this issue?
Run snyk test --severity-threshold=high on package after installing
What happens?
Issues with no direct upgrade or patch:
✗ Remote Code Execution (RCE) [Critical Severity][https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>and 1 other path(s)
This issue was fixed in versions: 10.0.0
What were you expecting to happen?
Snyk to be fine with all Orval dependencies
Any logs, error output, etc?
https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884
Any other comments?
What versions are you using?
npmPackages:
axios: ^1.7.7 => 1.7.7
msw: ^2.4.9 => 2.4.9
orval: ^7.1.1 => 7.1.1

Updating depedencies of dependencies can be tricky but PR is welcome!

it looks like the fix is there but not tagged yet
https://github.com/stoplightio/spectral/commit/5205058d1c9b48e6785b7744e2e2716cc7f1e0f4

@Mariscal6 thanks for keeping your eye on it and let us know when its released so we can bump!

Hello @melloware, it looks like the PR has been merged :)

Nice now Spectral needs to do a release.

There is another PR that needs to land in spectral: https://github.com/stoplightio/spectral/pull/2712

OK somebody let me know when Spectral releases.

@melloware looks like the PR has landed :)

Yep but spectral has not done a release yet...

I will look at this today!

PR is here but looking at it it looks like IBM OPenApiTools is what needs to update to the latest Spectral?  https://github.com/orval-labs/orval/pull/1701/files

@melloware correct, I will try to open a PR there tomorrow.

its actually not validator its @ibm-cloud/openapi-ruleset which I updated to 1.25.0 but still not sure that fixes it.

Indeed, I've created a PR to update the deps there:
https://github.com/IBM/openapi-validator/pull/697

@melloware version 1.25.1 should now be out.

PR updated! https://github.com/orval-labs/orval/pull/1702


[Bug][ONNX] use len() to extract the length of tvm.relay.expr.Var leads to crash

For the SequenceInsert converter in ONNX, the input tensor' type is the <class 'tvm.relay.expr.Var'>.
However, in the highlighted code, len() API is used to get the length of var, this can lead to crash.

    return relay.frontend.from_onnx(model, shape=shape_dict, **kwargs)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 7347, in from_onnx
    mod, params = g.from_onnx(graph, opset)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 6964, in from_onnx
    self._construct_nodes(graph)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 7079, in _construct_nodes
    op = self._convert_operator(op_name, inputs, attr, self.opset)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 7205, in _convert_operator
    sym = convert_map[op_name](inputs, attrs, self._params)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 6535, in _impl_v11
    position = len(input_sequence) + position + 1
TypeError: object of type 'Var' has no len()

Step to reproduce

download the model_seqquence_insert.onnx
compile the model using python -m tvm.driver.tvmc compile --target 'llvm' model_seqquence_insert.onnx

@vvchernov @echuraev
Could you help me check whether this crash was caused by TVM? The related onnx model and compiled command are extremely simple. I can ensure they were used correctly. I am confused about why len() was used to get the length of tvm.relay.expr.Var.
cc @KJlaccHoeUM9l

Hello @jikechao! I think it works for onnx front-end of TVM due to it checked many times on CI tests side. I guess the issue grows from tvmc, but I'm not familiar with it. Could you reproduce the failure on onnx front-end side? You can look at here.

Hello @vvchernov, thank for your comments. This is a reproducible script that only uses relay.frontend.from_onnx() API.
import onnx
import tvm
from tvm import relay

onnx_model_path = "model_seqquence_insert.onnx"
model = onnx.load(onnx_model_path)
irmod, params = relay.frontend.from_onnx(model, {'sequence': (), 'tensor': (3, )}, dtype='int64', freeze_params=True)


feat: Add support for naming and tagging subnet groups

Description
Add support for elasticache_subnet_group_name, elasticache_subnet_group_tags and redshift_subnet_group_name similar to what database subnet group already has
Motivation and Context
It is expected that naming and tagging of subnet groups work similarily in each case
Breaking Changes
Should not break anything
How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects

Force pushed some changes related to naming, I had names passed to lower() originally (as they are in database_subnet_group), but then quickly realized that it might cause breaking changes for updates. Sadly database_subnet_group name is passed through lower() so one might expect it's how naming works in all subnet groups.

lower() is used because AWS API expects it to be in lowercase all the time. I think it is good now.
Thanks for the PR.

#372 can probably be closed aswell, seems to be a zombie PR.


[semver:major] 2.0

Major overhaul. Depends on https://github.com/CircleCI-Public/orb-tools-orb/pull/90

Looks great 👍  @gmemstr to avoid an inception problem, I think we may need to manually publish this version when ready (manually pack/publish) and then update the config later with a semver:skip. That way we can use this version of the orb, in the orb-tools release.

Updating functionality/logic

I believe we are finally ready 🎉 . Giving final inspections.

Good work on everything except changing ignore for exclude XD

Good work on everything except changing var ignore for exclude XD
Breaks config from v1.x to v2.x if using @volatile
https://github.com/CircleCI-Public/shellcheck-orb/pull/22/files#diff-ef158f82f8d59ced9c306196050bd9d4R5

Hello,
This is expected. It is highly recommended not to use volatile. Orbs use semver versioning, where a major version change indicates a breaking change.


[Bug?]: "use server" doesn't always work

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
"use server" has no effect under certain conditions
Expected behavior 🤔
"use server" does what it's supposed to do
Steps to reproduce 🕹
make a route with this
import { createResource } from "solid-js"
import { isServer } from "solid-js/web"

const data = () => createResource(() => {
	"use server"
	console.log(isServer)
	return Math.random()
})

export default function Home() {
	const [ , { refetch } ] = data()

	setTimeout(() => refetch(), 1000)

	return ``
}

then open the route in a browser with the console open and after 1 second you'll see that false is logged in the browser console even though that's supposed to be server code
Context 🔦
use "use server"
Your environment 🌎
System:
	OS: NixOS 23.11.4516.e0da498ad77a (Tapir) x86_64
	CPU: 12th Gen Intel(R) Core(TM) i5-12500 (12) @ 5.90 GHz
Binaries:
	Node: 20.9.0 - /etc/profiles/per-user/samual/bin/node
	pnpm: 8.15.4 - /home/samual/.local/share/pnpm/pnpm
npmPackages:
	@solidjs/meta: 0.29.3
	@solidjs/router: 0.12.4
	@solidjs/start: 0.6.0
	solid-js: 1.8.15
	vinxi: 0.3.9

I'm surprised that even worked given that createResource cannot be declared at module-level in SSR.

it doesn't make a difference since it's not run until the component is run

Yeah it doesn't look like it handles double closures properly. First closure is fine but function in a function doesn't seem to transform.


Draw.io broken when used within table cell

Describe the bug
TinyMCE-Mode: Using Draw.io works as expected within a paragraph.
BUT if I start a drawing within a table cell, I can edit my initial drawing. But after I save it, it acts like an ordinary image. I cannot open the drawing in draw.io-editor anymore.
Steps To Reproduce
Steps to reproduce the behavior:

Open a page in edit-mode (tinymce)
Create a table
create a drawing within table cell and save it in draw.io editor.
Try to edit the drawing afterwards.

Expected behavior
See above
Your Configuration (please complete the following information):

Exact BookStack Version (Found in settings): BookStack v21.08.3
PHP Version: 7.4
Hosting Method (Nginx/Apache/Docker): Apache
tested on safari&Chrome OSX and chrome win

Thank You so much for your help!

Ah, I see,
Related to #1304

Probably related to issue #2945 as well.


Compilation problems occurred when installing open_spiel from source

I have the following problem when installing open_spiel from source：
[ 54%] Built target bridge_double_dummy_solver
/home/gaozh/pipline/dependencies/open_spiel/open_spiel/games/phantom_go.cc:70:15: error: no viable constructor or deduction guide for deduction of template arguments of 'vector'
std::vector points(placement.begin(), placement.begin() + num_handicap);
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:295:7: note: candidate function not viable: no known conversion from
'std::array<unsigned short, 9>::iterator' (aka 'unsigned short *') to 'unsigned long' for 1st argument; dereference the argument with *
vector(size_type __n, const value_type& __value,
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:283:7: note: candidate template ignored: couldn't infer template argument '_Tp'
vector(size_type __n, const allocator_type& __a = allocator_type())
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:411:2: note: candidate template ignored: couldn't infer template argument '_Tp'
vector(_InputIterator __first, _InputIterator __last,
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:348:7: note: candidate template ignored: could not match 'vector<_Tp, _Alloc>' against
'unsigned short *'
vector(const vector& __x, const allocator_type& __a)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:358:7: note: candidate template ignored: could not match 'vector<_Tp, _Alloc>' against
'unsigned short *'
vector(vector&& __rv, const allocator_type& __m)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:383:7: note: candidate template ignored: could not match
'initializer_list' against 'unsigned short *'
vector(initializer_list<value_type> __l,
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:216:11: note: candidate function template not viable: requires 1 argument, but 2 were
provided
class vector : protected _Vector_base<_Tp, _Alloc>
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:259:7: note: candidate function template not viable: requires 0 arguments, but 2 were
provided
vector()
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:270:7: note: candidate function template not viable: requires single argument '__a', but 2
arguments were provided
vector(const allocator_type& __a) _GLIBCXX_NOEXCEPT
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:326:7: note: candidate function template not viable: requires single argument '__x', but 2
arguments were provided
vector(const vector& __x)
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/bits/stl_vector.h:344:7: note: candidate function template not viable: requires single argument '__x', but 2
arguments were provided
vector(vector&& __x) noexcept
^
1 error generated.
games/CMakeFiles/games.dir/build.make:963: recipe for target 'games/CMakeFiles/games.dir/phantom_go.cc.o' failed
make[2]: *** [games/CMakeFiles/games.dir/phantom_go.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 54%] Built target bots
[ 54%] Built target game_transforms
[ 54%] Built target tests
[ 54%] Built target algorithms
CMakeFiles/Makefile2:13472: recipe for target 'games/CMakeFiles/games.dir/all' failed
make[1]: *** [games/CMakeFiles/games.dir/all] Error 2
Makefile:111: recipe for target 'all' failed
make: *** [all] Error 2
I tried installing from scratch and still get this problem. I also tried looking for answers in past questions, but unfortunately there are no such questions. Please help me to solve this problem.
this is my system info：
Linux ipdc 5.4.0-120-generic #136~18.04.1-Ubuntu SMP Fri Jun 10 18:00:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
this is clang version:
clang version 10.0.0-4ubuntu1~18.04.2

Hi @GaoZiHong,
Ah yes this is likely due to a newer language feature that is not supported in Clang 10 / Ubuntu 18.04. We stopped testing on 18.04 when 20.04 came out, so we have no way to reproduce it to help fix.
Assuming you can't or don't want to upgrade to 20.04 (or later, like 22.04), you two a few options:

Remove phantom_go (to do this, comment out references to phantom_go.h and phantom_go.cc and phantom_go_test in games/CMakeLists.txt, and remove its replay in integration_test/playthroughs and remove it from the list of games in pyspiel_test.py).

Use an older release version instead, one that was release before we removed support for Ubuntu 18.04. Seems like 1.1.0 would be the lastest version in that category: https://github.com/deepmind/open_spiel/releases/tag/v1.1.0

Fix phantom_go so it works again with Clang 10 / Ubuntu 18.04. (I don't know how to do it on first inspection but it might be easy with a few Google searches + Stack overflow)

Hope this helps!

Thank you very much!!! i download open_spiel 1.1.0 source code and install successfully without any trouble.

Great!


[BUG] - Install V0.6.4

Describe the bug
Error when installing 0.6.4 from fresh install
To Reproduce
Steps to reproduce the behavior:

Download v.0.6.4
Unzip
Click Setup.exe
Error Pops up

Expected behavior
Should install Correctly not crash

Something happened when I compiled the program. This is now fixed. V0.6.4 can be installed as a clean install.


mbedtls_ssl_cache_set incorrect time function call

incorrect work wth MBEDTLS_PLATFORM_TIME_ALT defined

Bug #666 has now beed resolved, so this can be closed.
Thanks for the contribution and support of the project!


cli: Add validator check for Dataset name

Adds validation to input for the Dataset name to ensure that the URL that's constructed is what the API expects.

Also, if you're up for a little extra challenge: add a test in cli/tests/ for this. There's a number of tests in that directory which execute the cli binary and verify its output. Here you could run with invalid name and verify it gives the helpful error message. (Could even add a test to successfully create a dataset, if you're up for it!)

@tommilligan @davidhewitt
Re-requesting reviews from both of you as I've added a new file test_datasets since that didn't exist previously, and modeled it based off test_sources. Plus I've addressed the suggestions from David!


Fixes #576 Upgrade Docker Maven Plugin to 0.13.0

Hi.
This PR fixes #576.
Andrea

Can one of the admins verify this patch?

Oh sorry @oscerd the docker plugin must be set in each maven module as they are currently. The reason is that those quickstarts each becomes a maven archetype and maven does not allow to inherit properties for its plugins you use (only dependencies etc).
Do you mind changing the PR to be like today but essentially upgrade the version in each of them.

No problema Claus :-) i'll change the pr this evening :-)
Il 07/lug/2015 18:35, "Claus Ibsen"<EMAIL_ADDRESS>ha scritto:

Oh sorry @oscerd https://github.com/oscerd the docker plugin must be
set in each maven module as they are currently. The reason is that those
quickstarts each becomes a maven archetype and maven does not allow to
inherit properties for its plugins you use (only dependencies etc).
Do you mind changing the PR to be like today but essentially upgrade the
version in each of them.
—
Reply to this email directly or view it on GitHub
https://github.com/fabric8io/quickstarts/pull/577#issuecomment-119262252
.

I've bring back the repository to the original situation and looking at #579 by @jstrachan I've updated just the quickstart projects POM.
I've also noticed that in some POM there wasn't the docker.maven.plugin.version property, so I've added it.
Andrea

Let me know if this is ok :-)

ok to test

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/641/
Test PASSed.


Dynamic brush

With the current brush example it updates the translation after the brush drag is released.
Is there a way to dynamically update the chart as the brush selection is being dragged in the x direction?
Similar to how Google finance charts work: http://bit.ly/2dvHJvo

Check the d3 api. For the particular example, event is triggered on brush end.
    var brush = d3.brushX()
            .extent([[0, 0], [width, height2]])
            .on("end", brushed);

I fixed this issue by changing the event to "brush end".


Negotiate/NTLMv2

I'm not sure who has the best golang winrm going now but I thought I'd throw this idea around here.  I've done near zero Cgo so I'm not sure what the barriers are, but freerdp have a pretty full on sspi implementation complete with NTLMv2(one of a kind AFIAK) and Negotiate: https://github.com/FreeRDP/FreeRDP/tree/master/winpr/libwinpr/sspi .
What would the difficulty be in utilizing this via Cgo?  This should allow win-rm negotiate auth(ntlmv2) and give us the security without the server certificates.

I've just written an implementation in Go: http://github.com/paulmey/go-ntlmssp
This library does the bare minimum for auth, but I think that should be enough for most cases?

@paulmey this looks interesting. I'll have a look as soon as I can find some time.

Since #33 is merged now, this issue can potentially be closed... :-)


Attribution changes

Just aligning attribution across crates, please let me know if you're okay with this!

Yep, sounds great to me! 🍻


Fix definition of the CPU sets for the system services

The 'dom0_max_vcpus', 'eve_max_vcpus', 'ctrd_max_vcpus' kernel arguments represent the amounts of CPUs that are assigned to the corresponding CPU sets when cgroups are created. The CPU set is defined with CPU indexes, that start with 0, not 1. So, the proper CPU set shoudl look like '0-$((total_amount - 1))'.
Signed-off-by: Nikolay Martyanov<EMAIL_ADDRESS>

@OhmSpectator, your changes looks good, but there is one Unit test failing (https://github.com/lf-edge/eve/blob/master/pkg/pillar/worker/workerpool_test.go), it can be related to your commit?

@rene good question... Actually, I'm not sure, what exactly the test does.
A big change, that is made with the PR: all the system services now run on one CPU (as it is supposed to), not on two.
But the failing test is a Unit test, that runs even not on a real system, so I'm not sure...
@eriknordmark @giggsoff do you have any idea of what could it be?

You are right, unit tests executed outside of EVE-OS, so failure cannot be related.
Regarding the changes: probably it would be nice to checks that we have at least one CPU defined to not hit negative numbers. It is odd to see dom0_max_vcpus=0, but better to check.

@giggsoff I can compare the value with 0 and set it to 1 in this case. Would it be a solution?

Added a check for 0-value in the "*_max_vcpus" args.

That unit test is a bit too sensitive to race conditions.


Push and Pull Grid System

Quickly one:
What does the push-* and pull-* columns in the grid system?

Have you read the documentation? Push and pull are for when you want to position your columns kind of like offset except with a little more control. You can push columns to the right and pull them to the left. You can see an example in the documentation.


Sort by Multiple Columns

Right now, it seems that you can only set one default sort and you can only click one column header at at time in list view to change the sort.
What I'd like to do is set a default sort using multiple columns.
My specific scenario is that I'd like to use Fluidity to show the latest reviews (sort by date descending) that are marked as not yet approved (sort by approved, starting with unapproved first).
This would allow the editor to see the most recent reviews that have not yet been approved.
As far as I can tell, this does not seem possible right now. My temporary (less than ideal) solution is to sort by date only:
collection.SetSortProperty(x => x.Created, SortDirection.Descending);

I tried this, but it seemed to just be sorting by date:
collection
    .SetSortProperty(x => x.Active, SortDirection.Descending)
    .SetSortProperty(x => x.Created, SortDirection.Descending);

Will need to have a look at adding ability to set a default sort order with multiple fields, but it's unlikely we'll update the UI to allow sorting on multiple (mostly because a) I don't think sorting on multiple columns is very initiative and b) we are limited by the list view angular control we are reusing from core)
There are a couple of things you could do though. To allow sorting on multiple props by default, you could create a [ResultColumn] that joins the two fields so that you can do a single sort operation on it. Not ideal, but it's something you can do now.
Secondly, and something that would likely fit your scenario better is to look at using Data Views https://umco.github.io/umbraco-fluidity/api/collections/list-view/#defining-data-views This would allow you to create multiple views of your data so you might have an "Approved" and "Unapproved" view that the editors can switch between. Then with this, you would only need the single sort on the created field as the view would already be filtered to just approved or unapproved.
Will leave this open, but I'll be considering the scope of this issue just to be about defining a default sort order over multiple fields. Sorting in the UI would then override this.

That data view option does sound useful for my scenario. Thanks.

The data view seems to work nicely. Thanks again for the recommendation. For others to reference,  here's what I did:
// Configure the list view.
collection.ListView(listView =>
{

    // Configure the fields in the list view.
    listView.AddField(x => x.Active);

    // Add a view of the reviews that haven't been approved.
    listView.AddDataView("Not Yet Approved", x => !x.Active);

    // Add a view of approved reviews.
    listView.AddDataView("Already Approved", x => x.Active);

    // Add a view of all reviews.
    listView.AddDataView("All Reviews", null);

});

Seems like I can pass in null for the predicate to create the default view that displays all rows. I had initially tried x => true, which bombed out.


Righteous Might error

Righteous Might grants a ridiculous amount of AC (like 50 for a lvl 12 character, where it should be 32).
Also it offers no attack like Animal Form or such.

@stwlam Is this still an issue we can't currently resolve?


Fix KML ground overlay distortion bug

Fixes #5914

Welcome to the Cesium community @jburr-nc!
Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?
I am a bot who helps you make Cesium awesome! Thanks again.

Awesome!  Thanks for fixing this @jburr-nc!
Could you add a unit test? I imagine it will be similar to this one, just check that stRotation is also correct: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/DataSources/KmlDataSourceSpec.js#L794-L812
As soon as we receive your CLA we'll be able to merge this.

@hpinkos The CLA for Novetta should be submitted. I added an additional check to rotation test that was already there. Would you prefer a brand new test instead?

Thanks, I can confirm that we have your CLA.  And that test looks fine to me!
Thanks again @jburr-nc!


How to stream 16:9 Video in portrait mode?

Hello Pedro!
I want to stream 16:9 video in portrait mode only, my app won't use landscape.
I have this but the preview seems to be stretched, what can I do to stream 1280x720 in portrait
if (rtmpCamera1!!.prepareAudio() && rtmpCamera1!!.prepareVideo(1280,720,30,2000000,false,15,90)) {
            rtmpCamera1!!.startStream(liveStreamingUrl+streamName)

        } else {
            Toast.makeText(this, "encoder not init", Toast.LENGTH_LONG).show()
        }

Gracias!

Are you using inmersive mode?

@pedroSG94 any idea on how to achieve this?

I can't reproduce it.
Can you tell me your device model?
Do you have this problem only in preview or also in stream / record result?

Stream goes 720x1280 portrait
I want to stream 1280x720 on portrait mode but the preview is automatically changed to 720x1280
Not sure what to change on the code to make it happen

I’m testing on 5 devices: moto g4 moto e5 Samsung j2 lg volt
I’m not using full screen
I’m using surface view , is it better to use open gl?

Ah ok. I understand now.
First of all if you want fix preview stretched you should use openglview or lightopenglview with this parameters set to true:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/app/src/main/res/layout/activity_open_gl.xml#L12
About resolution 720x1280 in portrait this is intentional. The idea is emulate a camera app.
If you record a video in a camera app in portrait with resolution to 1280x720 you will get a video like 720x1280 (You are creating a video with 1280x720 but with metadata rotation set to 90 but you can't do it on stream so to fix it I did that rotation manually and we can avoid a bad orientation result).
This a video created with camera app in portrait mode and rotation set to 0 with this ffmpeg command:
ffmpeg -i original.mp4 -c copy -metadata:s:v:0 rotate=0 result.mp4

videostest.zip

Ok, I'll try it with a live stream and see if that fixes it, thank you!

ok I see the videos you posted for download, but the 16:9 video is sideways, so is not usable, I have seen other libraries that can stream video like this one from Larix, so I wonder if this is possible to do here on yours:
larixsample_video.zip

I guess this should be a feature request then, to allow horizontal video streaming while in portrait mode, what do you think?

In this case you can't get a full screen preview in portrait. You will get a preview with resolution 1280x720 adapted to portrait like in your screenshoot. The result will be the same like in your screenshoot.
I will mark it like feature.

Pedro, how about if you allow the resolution 720x1280 and then use rotation 90? that way it won't be stretched...


Cleans up Stop handling in Treadle

When stop happens during circuit evaluation

Create and StopException
Save it in the engine
At end of circuit evaluation

Check for saved StopException
Throw it

Create richer StopException

Includes stopValue, stopName, info
These can be used for richer analysis and reporting

Fix up some tests
Fix up randomization implementation

Exposed by problem when running RandomizeCircuitTest

Addresses Issue #334


update vllm_online_benchmark script to support long input

Description

1. Why the change?
update vllm_online_benchmark script to support long input
2. User API changes

3. Summary of the change

4. How to test?

[x] Manual test in docker container
[ ] ...

5. New dependencies

[ ] New Python dependencies
- Dependency1
- Dependency2
- ...
[ ] New Java/Scala dependencies and their license
- Dependency1 and license1
- Dependency2 and license2
- ...

Add new parameter guide on here


cmake.sourceDirectory cannot be configured with ${variant:}

Brief Issue Summary
I have a complex code that I want to configure in a flexible way and enable only one component.
Doing so involve changing cmake.sourceDirectory
for example changing settings.json like this
"cmake.sourceDirectory": "${workspaceFolder}/${variant:components}",

${variant:components} contains the name of the component and directory
unfortunately ${variant:components} is not expanded in cmake.sourceDirectory
I believe this is a bug
CMake Tools Diagnostics

here is what I get from vscode:
[rollbar] "sourceDirectory" is not a directory {"sourceDirectory":"<expansion of workspaceFolder>/${variant:components}"}

"${workspaceFolder}" is expanded properly but not ${variant:components}
Cmake does not start because cmake tools complains that the sourceDirectory does not exist.
I believe this is a bug and should be easily fixed by allow expansion of ${variant:variantname} in cmake.sourceDirectory.
Also the doc says that cmake.sourceDirectory supports substitution, this seems limited to ${workspaceFolder}

@prudhomm, thank you for pointing out this scenario. We would like to improve this at some point. We may not be able to do this immediately and in the meantime we will also monitor the community upvotes to evaluate where this best fits in our backlog.

I'd like to upvote this feature request. :)

@rrahn Please click on the  in the first post and select 👍 to upvote.


Changing entropy 'mnemonic length' does not show 'calculating' feedback

Enter 300 dice rolls to the entropy field
Change 'mnemonic length' to 'from entropy length'
Note that there is a period of computation (approx 3s on my laptop) but no 'calculating' feedback shown

This is confusing and makes the UI feel like it's locked-up or frozen or unresponsive.
Suggested change is to show 'calculating' feedback message whenever the mnemonic is updated using 'mnemonic length' select box in the entropy section.

See https://github.com/iancoleman/bip39/commit/0eda54f5a7a05bcc6fb94b90f288c5f93d5cfd0b - Improve showing feedback for pending calculations


Update Script for Changed iPhone Image and Video Folder Paths

Issue Description:
I've been utilizing your script and find its intended functionality invaluable. However, recent iOS updates have prompted a change in the location of image folders, causing the script to deviate from its expected behavior.
Updated Image Folder Path:
The image folders are now situated at: "This PC\Apple iPhone\Internal Storage"
Problem:
The script assumes the folder structure is "This PC\Apple iPhone\Internal Storage\DCIM," leading to functionality issues. Despite attempting to modify the paths and code, my non-programmer background hindered my ability to resolve the issues. For testing, I used the iPhone 13 Pro with iOS Version 17.2.1.
Additional Problem:
I've observed that the script selectively copies only a few videos and photos, primarily older ones. The majority of folders and files are either not copied, or the resulting folders in the destination directory are left empty.
Request:
I kindly request an update to the script to align with the new image folder path and rectify the issue of selective copying. I believe this adjustment will significantly enhance the script's compatibility with the latest iOS changes.
Note:
As a non-programmer, there's a possibility that my attempts to address the issues might not be accurate. Any guidance or assistance in resolving these problems would be tremendously appreciated.
Thank you for your attention to this matter.

Hi GitHubKitten,
I'm glad you find the script useful. :)
I pushed some updates to the code today, I use this version with iOS 17.2.1, it works fine for me.
I noticed that sometimes files on the phone get moved to folders that have a letter suffix, for example "202301_a" and the script detects these as new files. The latest version of the script treats these folders as if they did not have a letter suffix (i.e. "202301__") and copies them as such.
Could you check whether it works for you now?
Adam


OpenSSL 1.1.x stable anytime soon?

Hi,
will there be a release of OpenSSL 1.1.x on conan-community anytime soon?
Thanks,
Claas

Sorry, I tried to adapt the 1.0.2 branch to build the 1.1.x but it fails in some points and I don't have time enough to achieve it. Maybe @bincrafters organization could help with this?


DeleteByIdAndAttr is not working

Expected Behavior
When calling the repository.deleteByIdAndSomeAttribute doesn't work when the SomeAttribute is the primary sort key.
Actual Behavior
A org.socialsignin.spring.data.dynamodb.exception.BatchDeleteException is thrown with the following stacktrace:
org.socialsignin.spring.data.dynamodb.exception.BatchDeleteException: Processing of entities failed!; nested exception is com.amazonaws.services.dynamodbv2.model.AmazonDynamoDBException: The provided key element does not match the schema (Service: AmazonDynamoDBv2; Status Code: 400; Error Code: ValidationException; Request ID: 8GO7K4Q4AV4OA14MF45MQKPEDFVV4KQNSO5AEMVJF66Q9ASUAAJG)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_181]
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[na:1.8.0_181]
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[na:1.8.0_181]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[na:1.8.0_181]
	at org.socialsignin.spring.data.dynamodb.utils.ExceptionHandler.repackageToException(ExceptionHandler.java:40) ~[spring-data-dynamodb-5.0.3.jar:5.0.3]
	at org.socialsignin.spring.data.dynamodb.repository.query.AbstractDynamoDBQuery$DeleteExecution.execute(AbstractDynamoDBQuery.java:268) ~[spring-data-dynamodb-5.0.3.jar:5.0.3]
	at org.socialsignin.spring.data.dynamodb.repository.query.AbstractDynamoDBQuery.execute(AbstractDynamoDBQuery.java:311) ~[spring-data-dynamodb-5.0.3.jar:5.0.3]
	at org.springframework.data.repository.core.support.RepositoryFactorySupport$QueryExecutorMethodInterceptor.doInvoke(RepositoryFactorySupport.java:590) ~[spring-data-commons-2.0.9.RELEASE.jar:2.0.9.RELEASE]
	at org.springframework.data.repository.core.support.RepositoryFactorySupport$QueryExecutorMethodInterceptor.invoke(RepositoryFactorySupport.java:578) ~[spring-data-commons-2.0.9.RELEASE.jar:2.0.9.RELEASE]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185) ~[spring-aop-5.0.8.RELEASE.jar:5.0.8.RELEASE]
	at org.springframework.data.projection.DefaultMethodInvokingMethodInterceptor.invoke(DefaultMethodInvokingMethodInterceptor.java:59) ~[spring-data-commons-2.0.9.RELEASE.jar:2.0.9.RELEASE]
....

Steps to Reproduce the Problem

Create DynamoDB with a primary sort key defined. In my case the primary partition key is "id" and the primary sort key is "childId"
Create some records in DynmoDB
Using the String Data conventions extend the repository to delete by id and childId

Excerpt:
@EnableScan
public interface ProgramCrudRepository extends CrudRepository<Program, String> {
    void deleteByIdAndChildId(String id, String childId);
}

Invoke the deleteByIdAndChildId

Specifications

Spring Data DynamoDB Version: 5.0.3 (2.0)
Spring Data Version: 2.0.9-RELEASE
AWS SDK Version: 1.11.407
Java Version: 1.8.0_181
Platform Details: Mac OS X 10.13.6

I just created a test case for the described scenario:
https://github.com/derjust/spring-data-dynamodb/pull/208/files#diff-dcdb5f59762ba17e758ce60997071885R196
If I understand correctly, the given situation is that id is the Hash key and childId is the Range key.
As with the entity model itself, DynamoDB's structure and the way spring-data expects doesn't perfectly align:
The deleteById (Id as the conceptual thing represented by two fields on the DynamoDB side but as a distinct entity class on the spring-data side) on the repository must be used - as per the referenced example.
Otherwise the childId is considered a regular attribute - which is not the case as it marked as part of the  (conceptual) id

Updated the wiki.


Maintain existing state instead of overwriting

I raised this issue yesterday (https://github.com/SpectoLabs/hoverfly/issues/764), this branch seems to fix it.
After some debugging it seemed like the entire state was being overwritten each time a new sequence is added. I'm new to Hoverfly and new to Go, so feedback is very welcome 😄
I ran through the existing tests and it didn't seem to cause any new failures.

Excellent spot, very much appreciated @john4744! Thank you!


XY was created with unknown prop 'topmost'

I get <ModalXY> was created with unknown prop 'topmost' console warning when creating/displaying a new modal. Is topmost is a valid property in this context?
<aside class="s-modal-portal {$$props.class ?? ''}">
  {#each $store as modal, index (modal.id)}
    <svelte:component
      this={modal.component}
      {...modal.props}
      topmost={index === $store.length - 1}
      on:resolve={(event) => onResolve(modal, event)}
    />
  {/each}
</aside>

@BCsabaEngine The topmost prop is used internally by the Modal.svelte component exported from @svelte-put/modal. If you are writing your own custom modal component, it has no effect so you can safely ignore the warning. This is definitely one of the decision that I regret when looking back, and something to improve in the future.


Updated devops pipelines to stop silently failing builds - the new pi…

…peline will also roll back to the previous green version if it fails

:shipit:


feat(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1292

Questions ?
Please refer to the Backport tool documentation


Honda: use common DBC for CRV H and Accord Diesel

Similar situation to https://github.com/commaai/openpilot/pull/23659. Used the ILX gear definitions and we maintain all previous gears + we get neutral (previously was unknown to openpilot as it wasn't defined correctly for these cars).

Ready to merge if the jenkins test fail isn't related