YouTube: unable to download video data: Remote end closed connection without response

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.09.10. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.09.10

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

[debug] System config: ['--prefer-free-formats']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=c6Lt9jf9wAQ']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.09.10
[debug] Python version 3.6.6 (CPython) - Linux-4.17.19-200.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight
[debug] exe versions: ffmpeg n4.0.2, ffprobe n4.0.2, phantomjs 2.1.1
[debug] Proxy map: {}
[youtube] c6Lt9jf9wAQ: Downloading webpage
[youtube] c6Lt9jf9wAQ: Downloading video info webpage
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'https://r3---sn-8pgbpohxqp5-ajtl.googlevideo.com/videoplayback?txp=5532332&key=yt6&signature=04228F2C522146AF79166EC57C4F338C2B34BDCB.2E05ABA3B4B3A7EA026E3D8EB7B0364223F0D5E4&gir=yes&dur=262.474&aitags=133%2C134%2C135%2C136%2C137%2C160%2C242%2C243%2C244%2C247%2C248%2C271%2C278%2C298%2C299%2C302%2C303%2C308%2C313%2C315&source=youtube&lmt=1535786944134868&requiressl=yes&fvip=4&itag=315&expire=1536637510&keepalive=yes&mn=sn-8pgbpohxqp5-ajtl%2Csn-aigl6ner&mm=31%2C29&id=o-AKoqCC8bmOQ21s1xkAbTwiav51XWz-eRRC9ovI12nKoI&mv=m&mt=1536615824&ms=au%2Crdu&ei=5uWWW5WpIoGEVf-YoeAP&ip=<IP_ADDRESS>&pl=22&initcwndbps=1285000&c=WEB&ipbits=0&clen=867526321&sparams=aitags%2Cclen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cexpire&mime=video%2Fwebm&ratebypass=yes'
ERROR: unable to download video data: Remote end closed connection without response
Traceback (most recent call last):
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 1902, in process_info
    partial_success = dl(fname, new_info)
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 1847, in dl
    return fd.download(name, info)
  File "./youtube-dl/youtube_dl/downloader/common.py", line 364, in download
    return self.real_download(filename, info_dict)
  File "./youtube-dl/youtube_dl/downloader/http.py", line 341, in real_download
    establish_connection()
  File "./youtube-dl/youtube_dl/downloader/http.py", line 109, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 2211, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib64/python3.6/urllib/request.py", line 526, in open
    response = self._open(req, data)
  File "/usr/lib64/python3.6/urllib/request.py", line 544, in _open
    '_open', req)
  File "/usr/lib64/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "./youtube-dl/youtube_dl/utils.py", line 1139, in https_open
    req, **kwargs)
  File "/usr/lib64/python3.6/urllib/request.py", line 1321, in do_open
    r = h.getresponse()
  File "/usr/lib64/python3.6/http/client.py", line 1331, in getresponse
    response.begin()
  File "/usr/lib64/python3.6/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/lib64/python3.6/http/client.py", line 266, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

The above URL is an example but it's happened with numerous other videos on youtube. I get a similar error if I run it with python2:
[debug] System config: [u'--prefer-free-formats']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=c6Lt9jf9wAQ']
[debug] Encodings: locale UTF-8, fs UTF-8, out None, pref UTF-8
[debug] youtube-dl version 2018.09.10
[debug] Python version 2.7.15 (CPython) - Linux-4.17.19-200.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight
[debug] exe versions: ffmpeg n4.0.2, ffprobe n4.0.2, phantomjs 2.1.1
[debug] Proxy map: {}
[youtube] c6Lt9jf9wAQ: Downloading webpage
[youtube] c6Lt9jf9wAQ: Downloading video info webpage
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on u'https://r3---sn-8pgbpohxqp5-ajtl.googlevideo.com/videoplayback?c=WEB&key=yt6&ei=nuaWW5-SCISOV5aDpqgB&txp=5532332&ipbits=0&clen=867526321&source=youtube&aitags=133%2C134%2C135%2C136%2C137%2C160%2C242%2C243%2C244%2C247%2C248%2C271%2C278%2C298%2C299%2C302%2C303%2C308%2C313%2C315&signature=A2F2FF04AF2A3734BCB7E70F93958518A425AB8F.DD5E2175822ED5DED0B5990B40B0ED0FFEFE111B&expire=1536637694&lmt=1535786944134868&requiressl=yes&gir=yes&mime=video%2Fwebm&fvip=4&keepalive=yes&sparams=aitags%2Cclen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cexpire&id=o-ACmylxsmbPq8aW5Go8GOWTco5Opk2fxxdTg9ESxJP9bJ&mt=1536615931&mv=m&dur=262.474&initcwndbps=1306250&itag=315&ms=au%2Crdu&ip=<IP_ADDRESS>&mm=31%2C29&mn=sn-8pgbpohxqp5-ajtl%2Csn-aigzrn7z&pl=22&ratebypass=yes'
ERROR: unable to download video data: ''
Traceback (most recent call last):
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 1902, in process_info
    partial_success = dl(fname, new_info)
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 1847, in dl
    return fd.download(name, info)
  File "./youtube-dl/youtube_dl/downloader/common.py", line 364, in download
    return self.real_download(filename, info_dict)
  File "./youtube-dl/youtube_dl/downloader/http.py", line 341, in real_download
    establish_connection()
  File "./youtube-dl/youtube_dl/downloader/http.py", line 109, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 2211, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib64/python2.7/urllib2.py", line 429, in open
    response = self._open(req, data)
  File "/usr/lib64/python2.7/urllib2.py", line 447, in _open
    '_open', req)
  File "/usr/lib64/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "./youtube-dl/youtube_dl/utils.py", line 1139, in https_open
    req, **kwargs)
  File "/usr/lib64/python2.7/urllib2.py", line 1203, in do_open
    r = h.getresponse(buffering=True)
  File "/usr/lib64/python2.7/httplib.py", line 1121, in getresponse
    response.begin()
  File "/usr/lib64/python2.7/httplib.py", line 438, in begin
    version, status, reason = self._read_status()
  File "/usr/lib64/python2.7/httplib.py", line 402, in _read_status
    raise BadStatusLine(line)
BadStatusLine: ''

Most likely a connectivity issue between you and youtube host.


expose Object ID in the properties pane in the Web UI

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Hello,
It would be nice if the object ID would have been exposed in the properties pane of the selected object.
Object IDs are used in some plugins that work with diagrams.net, such as a flowchart plugin for Grafana solution. The plugin dynamically changes the attributes of the objects based on the telemetry data collected, and it uses object ID to select the right object - https://algenty.github.io/flowcharting-repository/STARTED.html#flowchart-definition
It would be way nicer, if we would have been able to access those IDs in the web ui of the drawio web interface.

It will be available in the next release

It will be available in the next release


Some programs do not open in full screen, because some incomprehensible upper panel appears

Thank you for the program, but I encountered a very unpleasant bug right from the start. After starting your program, some programs do not open in full screen, because some incomprehensible upper panel appears (in some programs, such as Chrome, a white bar, in others, such as Word, it is transparent, as if duplicating the frame of the window itself, as can be seen in the screenshot, another close key, which is partially cut off). Two artifactual pixels also appear. In everything else, it seems to work properly and aligns the windows, but it takes more time to say for sure.

Hi @LisaJackson24-2.
Thank you for your feedback. I tested the program on different devices running on Windows 10/11 and never got the bug you described. Maybe there's another program that conflicts with Window Centerer? Try to stop other processes from task manager.

Hi @LisaJackson24-2. I also faced the problem today. I found the reason and will fix it in the next update

Oh great, I'll wait.
It would also be nice if you somehow added the ability to disable auto-align. I understand that this program is more like a service and does not have a graphical interface, but I noticed that very often it resets the window size for some programs, especially the explorer in applications when downloading files, it shrinks too much, the window becomes too small, and if it is stretched manually, it will still shrink again when reopened. Therefore, it would be better for me to already use positioning via Shift, and not to stretch the windows anew every time.

Fixed in f3cef76, version 0.0.6


Application context for storing user data?

I'm using Sanic with a database, and I'd like to store the db engine and session creator with the app object, so anywhere I have the app I can get the db. Is there any supported way to attach my own data to a Sanic app object? Right now I'm just doing this when creating my app:
def setup_database(app: Sanic):
    db = init_db(app)
    app.db = db

but it seems questionable to just add a 'db' object to the app because in future Sanic could define that attribute.

No, there is no supported way to do this, and no shared application context like you'd find in Flask or pylons.
This is a big problem for plugin authors, because quite often plugins need to store context per-application and per-request.
To address this, I created Sanic Plugins Framework. It adds this feature (and a few others) to sanic.
Its aimed at plugin developers, but it might be able to help you out.
https://github.com/ashleysommer/sanicpluginsframework

@garyo you can try contextvars (in the upcoming Python 3.7) or something bound to the current asyncio.Task, like the backport of contextvars, but is does not provide support for asyncio just yet; aiocontextvars that covers some of the contextvars functionality and will be deprecated when the contextvars backport comes out or even aiotask-context that enables some level of context in async applications. To create your own context bound to asyncio.Task, you can take a look at this snippet from sanic-jwt project (and yes, I created that code but I just referenced it because it's quite simple to implement, actually) :wink:

@vltr thanks contextvars works well in 3.7, imo the request could be realised as such or could contain some convenience functionality to deliver a shared contextvars (imho)

@cinatic yes, I agree with you. But, since Sanic aims for Python 3.5+, we can't use contextvars for it. Now, if you want a simple way of storing shared data (in the request context), you can use the Request object itself, since it is a dict:
# in the middleware
request["hello"] = "world"

# in the handler
assert request["hello"] == "world"

:wink:

@vltr oh okay well that's super easy... thanks for the hint


fix broken links

The cluster-configuration.yaml replaced by layout.yaml

Coverage decreased (-5.3%) to 52.794% when pulling 5ef4262cbca14b06bb0bad596ff337e8560d77ac on hao/fix_broken_links into d14acdab1ea426bfab46dbab87914bdc92a2fb1f on master.


[AMLII-1976] Disk Management for Logs From Integrations

What does this PR do?
Adds disk usage management for log files created by logs from integrations. This PR allows users to set individual file size limits, as well as total allowed disk usage (both as an absolute size and relative disk usage space). A future PR will include support for file rotation.

Motivation
Needed to ensure integration logs files don't use too much disk on host machines.

Additional Notes

Possible Drawbacks / Trade-offs

Overhead for reading files and creating/deleting them.
Describe how to test/QA your changes

Set the logs_config.integrations_logs_files_max_size to a size of your choice (default is 10 MB, but you can set it to something like 1 MB for this case)
Create a valid integrations config so the agent will create and start reading logs, the following should work:

logs:
  - type: integration
    service: my_service
    source: my_source

Make sure the agent creates an appropriate log file based off this configuration, it should be located in /opt/datadog-agent/run/integrations/{integration_id}.log
Write logs to this file until the file size reaches limit set by logs_config.integrations_logs_files_max_size, keep writing data to the file, the agent should delete it and recreate it again.

You should also test multiple file max usage

Set the logs_config.integrations_logs_total_usage to something low, like 2 MB
Create multiple valid integrations configs using the template above.
The agent should create multiple files (one for each valid integrations config).
Write data to the logs until their combined size is the size you set logs_config.integrations_logs_total_usage
The next log write should trigger the agent to delete one of the integrations logs files and remake it.

/merge

/merge

/merge

/merge

/merge

/merge

/merge


Update utility for SPDX 2.3

[x] mapping component type to package purpose
[x] additional checksum algorithms to map
[x] additional security external refs (advisory, fix, URL)
[ ] release date
[ ] built date
[ ] valid until date

There is no equivalent properties for the release, built and valid until dates

Resolved with PR #15


Testing bot integration

We are accepting issues and we want your feedback.

Description
Describe your issue.
Expected behaviour

Current behaviour

Possible solution

Steps to reproduce

Environment

It works!


Makes main reexecution work with non-ES modules

Closes #377. This is needed to make steal production apps work.

tests failing is caused by https://github.com/canjs/can-stache/issues/336 . Will circle back later and fix it.


Add defaultroute' fact, improve ipaddress' fact

Parse netstat output to determine the default route and its associated network
interface. Using this information, we can determine the "real" IP address of a
multi-homed host more accurately.

Hi Ben, thanks for your contribution! As part of our development process, we need you to create a redmine account at projects.puppetlabs.com and sign our Contributor License Agreement so we can get this merged. In addition, creating an issue associated with this pull request will help track the changes we make between versions, so associating this pull request would be most helpful.

I'm really a big fan of this patch ... Ben - there is an open ticket here: http://projects.puppetlabs.com/issues/10268.
If you want to just add yourself as a watcher to that existing ticket, or add a comment pointing to this pull request that would be awesome. We'll need you to sign the CLA once you create an account like Adrien says so we can get the legal stuff out of the way:
https://projects.puppetlabs.com/contributor_licenses/sign
Being a watcher on a ticket with a CLA flag makes it easy for us to see thats done which is the main reason. We are quite keen to work with you on this patch, so I hope this doesn't get in the way.

From the ticket:
Hey. I reviewed both sets of code here, and none of them are acceptable.
Specifically, both of them assume that there is A default route, which is flat-out untrue. Unless I see code and, especially, tests that handle other common network situations I am going to reject these as very, very misleading and troublesome in the real world:

a machine that has no default route at all
a machine with multiple default routes, same priority
a machine with multiple default routes, different priority
a machine with no /0 route, but two /1 routes, same priority, same router

If the submitted code does anything about network interfaces, I also expect to see the permutations of network interfaces (eg: all routes on one interface, all routes on different interfaces) thoroughly tested as well.
The pull request also misleadingly assumes that the default route is the “real” IP of a machine, which may be part of a heuristic to help take a guess at that, but calling it anything but a guess is also pretty undesirable.
Given that I am going to close the pull request; it can either be reopened or reissued when those changes are addressed.


Ajax Search Support (paginator issue)

http://iamisti.github.io/mdDataTable/ -> Ajax Search Support
For example, if you go to page 4 and then you search "Palomitas" or "Palou" it stays on page 4! The paginator doesn't restart to page 1.
If you go back to page 3, No results, page 2, no Results... page 1... 1 or 2 results and paginators limits change to 1 of 1 page

Very good catch @orekav !
Will be fixed in the next 24 hour 👍

I saw that when search has not get results, paginator shows 0-0, but when it does... it stills doing the same thing (Stays in an advance page)
[Sorry about my english]

Hi @orekav , no it doesn't. Did you try it with incognito mode? Just make sure you don't have anything cached.
For me it works fine. If you still experiencing the issue, please write me some repro steps to see it.
By the way the original issue is fixed already.

Ajax Search Support

Search value: 41 (You'll see 1-5 of 30)
Seach value:  (empty)
Go to page 10 (You'll see 51-55 of 659313)
Search value: 41 (You'll see 51-30 of 30)
Go one page back (to page 9) --> Empty results and know you can't go to page 10

When I'm on page 10 and search a new Value... It should stays on page 10 if there are rows, if not... it should go to page 1

good finding! Thanks for reporting it. I'll have a look at it and fix it!

Fixed with v1.8.8

Fixed with v.1.8.8 or the future release v.1.8.9 ?
I tried it again and it did the same thing

You right, it's still not fixed. I thought I fixed it with one of my fixings but apparently I didn't.
I'm fixing it now and will be part of the next release.

I'm confirming the bug (with master version, being close to v2.1.0 I guess). When filtering results, the mdt-row-paginator callback (paginatorCallback) gets called with the 1st parameter (page) undefined, and second parameter (pageSize) correctly set though. But in the meantime, the paginator stays on the current page on screen, which is confusing as the server returns the 1st page of filtered data.
I guess the right behavior would be to pass 1 as the 1st parameter (page) and for the paginator to get back to the first page.
An alternative would be to stay on the same page number, but the case is more complex because it would mean that the server would need a way to inform the client to change the page number if there is not enough results to stay on the current page, so that it can switch to a prior page... Sounds unnecessary to me: When filtering, simple reinitialize the page counter to 1, period.


#864 Fix following issue when searching on a new Win10

invoke-webrequest : The response content cannot be parsed because the Internet Explorer engine is not available, or Internet Explorer's first-launch configuration is not complete. Specify the UseBasicParsing parameter and try again.

Thanks for this.


Enchanced visualization and resolved signoff issue

Signed-off-by: Eric Wei<EMAIL_ADDRESS>Description
Enhanced visualization tab.

New layouts
New viz types

pie
guage
heatmap
text

enhanced viz types

bar
line

New table view
Config Panel
Sidebar

Field insights

Saved objects supporting visualization configs

Will add types/interfaces and some fixes for existing visualization rendering with following PRs.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #483 (de12105) into feature/enhanced_visualization (7dd774d) will increase coverage by 13.84%.
The diff coverage is 90.00%.

@@                          Coverage Diff                          @@
##             feature/enhanced_visualization     #483       +/-   ##
=====================================================================
+ Coverage                             59.25%   73.09%   +13.84%
  Complexity                              273      273
=====================================================================
  Files                                   205       38      -167
  Lines                                  7164     2126     -5038
  Branches                               1406      235     -1171
=====================================================================
- Hits                                   4245     1554     -2691
+ Misses                                 2718      409     -2309
+ Partials                                201      163       -38

Flag
Coverage Δ

dashboards-observability
?

opensearch-observability
73.09% <90.00%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ensearch/observability/model/SavedVisualization.kt
85.18% <88.88%> (+0.05%)
:arrow_up:

...opensearch/observability/model/OperationalPanel.kt
74.72% <100.00%> (ø)

.../public/components/custom_panels/helpers/utils.tsx

...ervability/public/components/explorer/explorer.tsx

...ility/public/components/explorer/sidebar/field.tsx

...ity/public/components/explorer/sidebar/sidebar.tsx

...er/visualizations/config_panel/configPanelItem.tsx

...lorer/visualizations/config_panel/config_panel.tsx

...izations/count_distribution/count_distribution.tsx

...omponents/explorer/visualizations/frame_layout.tsx

... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd774d...de12105. Read the comment docs.


Traefik ingressroutetcp does not work with letsencrypt certs

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I wanted to have TLS for TCP service  so I created the following
IngressRouteTCP manifest
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRouteTCP
metadata:
  name: mq-ingess-tcp
spec:
  entryPoints:
    - mqs
  routes:
    - match: HostSNI(`mq.example.com`)
      services:
        - name: mq
          port: 1883
  tls:
    certResolver: le-prod
    domains:
      - main: mq.example.com
        sans:
          - mq.example.com
    passthrough: false
    options:
      name: tlsoptions
      namespace: traefik

As the above did not generate cert I also created the following which got the Letsencrypt cert
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: mq-ingess
spec:
  entryPoints:
    - websecure
  routes:
    - kind: Rule
      match: Host(`mq.example.com`)
      services:
        - name: mq
          port: 1883
      middlewares:
        - name: security
          namespace:  traefik
  tls:
    certResolver: le-prod
    domains:
      - main: mq.example.com
        sans:
          - mq.example.com
    options:
      name: tlsoptions
      namespace: traefik

What did you see instead?
#without SNI
openssl s_client -showcerts -connect mq. example.com:443 > default traefik cert
openssl s_client -showcerts -connect mq. example.com:8883 > default traefik cert
#with SNI
openssl s_client -showcerts -connect mq. example.com:443 -servername mq. example.com > letsencrypt cert
openssl s_client -showcerts -connect mq. example.com:8883 -servername mq. example.com > NO CERT
What version of Traefik are you using?
Traefik: 2.7.1
Helm chart: 10.23.0
What is your environment & configuration?
logs:
  general:
    level: INFO
  access:
    enabled: true
    format: json
additionalArguments:
    #letsecrypt staging
  - "--certificatesresolvers.le-staging=true"
  - "--certificatesresolvers.le-staging.acme.tlschallenge=true"
  -<EMAIL_ADDRESS>  - "--certificatesresolvers.le-staging.acme.storage=/data/acme-s.json"
  - "--certificatesresolvers.le-staging.acme.caserver=https://acme-staging-v02.api.letsencrypt.org/directory"
  #letsecrypt PROD
  - "--certificatesresolvers.le-prod=true"
  - "--certificatesresolvers.le-prod.acme.tlschallenge=true"
  -<EMAIL_ADDRESS>  - "--certificatesresolvers.le-prod.acme.storage=/data/acme-p.json"
  - "--certificatesresolvers.le-prod.acme.caserver=https://acme-v02.api.letsencrypt.org/directory"

#enable external svc
  - "--providers.kubernetesingress.allowexternalnameservices"
  - "--providers.kubernetescrd.allowexternalnameservices"

ports:
  mqs:
    port: 18883
    # hostPort: 18883
    expose: true
    exposedPort: 8883
    # The port protocol (TCP/UDP)
    protocol: TCP
  mq:
    port: 11883
    # hostPort: 11883
    expose: true
    exposedPort: 1883
    # The port protocol (TCP/UDP)
    protocol: TCP

volumes:
 - name: traefik-config
   mountPath: /config
   type: ConfigMap

persistence:
  enabled: true
  storageClass: "managed-nfs-storage-retain"
  name: data
  accessMode: ReadWriteOnce
  size: 512Mi
  path: /data

providers:
  kubernetesCRD:
    allowCrossNamespace: true

service:
  spec:
    externalTrafficPolicy: Local

If applicable, please paste the log output in DEBUG level
No response

Running into a similar problem where it works for https, but not tcp.

@rtribotte Yes i was trying to terminate the tcp-tls connection with traefik (also behind a hetzner-loadbalancer with proxy-protocol).
Since that didn't work, i disabled the proxyprotocol and had the same config as @ankycooper .
After some hours of testing and trying i just let cert-manager generate an ingress for the subdomain and referenced that directly:
apiVersion: v1
items:
- apiVersion: traefik.containo.us/v1alpha1
  kind: IngressRouteTCP
  metadata:
    name: emqx
  spec:
    entryPoints:
    - emqx
    routes:
    - match: HostSNI(`emqx.$TLD`)
      services:
      - name: emqx
        port: 1883
        proxyProtocol:
          version: 2
        terminationDelay: 100
        weight: 10
    tls:
      secretName: emqx.$TLD

Now it works. After all that i am not 100% sure i didn't mix up some configuration with the proxyprotocol somewhere. Will try to re-do this tomorrow with a fresh brain and report back.


bump compileSdkVersion to 28

#24  Summary
fixes issue #43
Compatibility

OS
Implemented

iOS
❌

Android
✅

Checklist

[X] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Can this be merged soon? And same we need for react-native-community/progress-view for iOS

I hope this gets merged soon as the library is unusable with RN 0.62 in its current state.

@Naturalclar Could you please bump npm package?
And could you please update the ios progress-view library with the same fix? Thanks a lot!

@oleksandr-dziuban I've bumped both progress-view and progress-bar with the fix :+1: Both of them should have the fix applied in version 1.0.3


Add integration test for Nunjucks renderer

This commit adds an integration test for rendering the Jinja GOV.UK Template with the Nunjucks template rendering engine. The test setup is based on the Mustache inheritance one.
The two templating languages are mostly compatible. Having a test will ensure that we don’t get caught out by any of the incompatibilities.
This is to avoid having to maintain two separate, but identical versions of the template for the two different languages, as discussed in #193.

:star2:


DEV-127: Double Counting CD For AB and BSE

References

Linear: https://linear.app/hoagie/issue/DEV-127/double-counting-cd-for-ab-and-bse

Proposed Changes

Updated double counting rules for CD

lgtm


Dependency Update

A handful of dependencies have known vulnerabilities in the required versions. A little housekeeping to resolve theses would be much appreciated.

forgot password reset link , see the video link completely solved
https://youtu.be/daGZO6YAkRg

@davideast resolved, or?


Add note for non-Linux users about IP binding

Thanks!
Btw. for new contents to be written, I'd suggest to avoid very long lines.
They make it harder to view changes in the diff view (e.g. no word-diff highlighting on GitHub). Instead of a fixed length, though (which forces constant re-wrapping after changes), we've made good experiences with using the rule "one sentence or line of thought per line" in the Hibernate docs. I.e. shorter sentences will be on their own line, for longer ones one would move to a new line after a comma.
E.g. like so:
Btw. for new contents to be written, I'd suggest to avoid very long lines.

They make it harder to view changes in the diff view (e.g. no word-diff highlighting on GitHub).
Instead of a fixed length, though (which forces constant re-wrapping after changes),
we've made good experiences with using the rule "one sentence or line of thought per line" in the Hibernate docs.
I.e. shorter sentences will be on their own line, for longer ones one would move to a new line after a comma.


is this package maintained anymore?

Hei,
It seems last update for this package is 15 months old, and h3 4.x is not implemented.
Additionally I get with flutter run and connected android phone the following,
which to my understanding comes from new google-requirements this package does not fullfill.
So is this package dead?
Terveisin, Markus
flutter run
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':h3_flutter'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 3s
Running Gradle task 'assembleDebug'...                              4.0s
Error: Gradle task assembleDebug failed with exit code 1

There is no answer here, so I assume it confirms my observation that this package is obsolete and should not be used anymore.
I go around the problem by writing geojson on with python h3 library and reading geojson in flutter.
Terveisin, Markus

Hi,
You're right, there's no active development for this project and it's pretty much abandoned.
Unfortunately, I don't use this package anymore and currently have no time to develop it further. I do, however, have some drafts for 4.x and hope to finish them at some point, but I wouldn't make any promises.
At this point, If you can avoid this package, i would suggest doing so, or maybe creating a fork (PRs are welcome, too).
As for the problem you mentioned - it looks like something simple to fix, so I'll try to look into this more these/next weekends, thank you for reporting it.
I would keep this issue open, if you don't mind, because I think it's important for the project.


fix:empty table name bug

Fixed bug that creates table with empty name
Issue-https://github.com/Shivansh-yadav13/SQLite-UI/issues/30

Can anyone please look into my PR?


rxjs_1.Observable.create(...).finally is not a function

Possible noob question, I have the minimum possible Undux store setup but when I call withStore I get that error.
My store (taken from readme example):
import { connect, createStore } from 'undux'

// Create a store with an initial value.
let store = createStore({
    sessionKey: '',
    sessionFetching: false,
})

export let withStore = connect(store);

Where I use withStore:
import React, { Component } from 'react';
import { withStore } from 'utils/store';

const App = withStore(({ store }) =>  // This call causes the error

gChat

Session:{}

)

export default App;

The error (x2):
TypeError: rxjs_1.Observable.create(...).finally is not a function
Emitter../node_modules/typed-rx-emitter/index.js.Emitter.createChannel

I'm using regular JS with create-react-app, not typescript; is that the problem? Any advice is much appreciated.
(Also great library, exactly what I was looking for after the verbosity of Redux!)

Hi @gregdumb! From the error message, it's not clear what's throwing the error. Think you can put a self-contained, reproducible example in a zip (or better yet, on Stackblitz or Codepen) so I can reproduce what you're seeing?
As a first step, how are you including RxJS in your build?

As a first step, how are you including RxJS in your build?

You made me realize that I had installed RxJS ^6.0.0,  so I tried with ^5.0.0 and that works! Is 6 not supported?

Good to hear! It seems like Rx6 is still in RC, but in the meantime I will do a couple of things:

Give a better error if Rx 5 is missing, so you can find out quickly #24
Investigate supporting both Rx 5 and 6 concurrently
Investigate making the Rx library pluggable #8

@gregdumb Undux 4.3 is shipped, with out of the box support for both Rx6 and Rx5.

Wow sweet! Appreciate the fast turnaround.


v11.0.0 new path processor

Current coverage is 95.49%

Merging #222 into master will increase coverage by +0.03% as of 8fc7ab0

@@            master    #222   diff @@
======================================
  Files           26      26
  Stmts          375     377     +2
  Branches         0       0
  Methods         83      83
======================================
+ Hit            358     360     +2
  Partial          0       0
  Missed          17      17

Review entire Coverage Diff as of 8fc7ab0

Powered by Codecov. Updated on successful CI builds.


feat: merge service account id to subject id

if a client has service account enabled, the sub presented in the JWT is the service account id
the client id is never used for authentication purposes and can then be dropped (a client cannot authenticate by itself if service account is not enabled)

what is exactly a client's service account ?

A service account is a type of client that is able to obtain tokens on its own behalf. (https://www.keycloak.org/docs/latest/securing_apps/#terminology)


[ITensors][NDTensors] An attempt to address contract compile time

Description
The lowest contract function in NDTensors is explicitly dependent on the number of tensor indices for tensors A, B, and C, for a generic tensor contraction C = A * B. Therefore when we change the number of modes for A, B or C, we need to recompile the full stack of contract functions.
Fixes #(issue)
Because most of the contractions fall into a matrix contraction (gemm), we could refactor the original ITensors into ITensors of order-2 and then follow the standard contract approach. This would mean that we only have to recompile the top-most function which converts order-N tensors into order-2 tensors.
Minimal demonstration of previous behavior
i = Index(5)
j = Index(10)
l = Index(3)
k = Index(20)
m = Index(30)

A = randomITensor(i,j)
B = randomITensor(j,k,l)

@time A * B  # Need to compile all of the contract functions
  3.910665 seconds (19.21 M allocations: 1.084 GiB, 8.31% gc time, 99.93% compilation time)

@time B * A  # This would also need to recompile all of the contract functions
  0.866481 seconds (4.16 M allocations: 212.052 MiB, 3.91% gc time, 99.74% compilation time)

A = randomITensor(i,j,m)
@time A * B
1.517049 seconds (6.71 M allocations: 360.763 MiB, 4.15% gc time, 99.81% compilation time)

Minimal demonstration of new behavior
i = Index(5)
j = Index(10)
l = Index(3)
k = Index(20)
m = Index(30)

A = randomITensor(i,j)
B = randomITensor(j,k,l)

@time contract(A, B; matricize=true)  # Need to compile all of the contract functions
3.697179 seconds (17.44 M allocations: 1010.773 MiB, 7.74% gc time, 99.88% compilation time)
@time contract(B, A; matricize=true) # This only need to recompile the top most function
  0.238060 seconds (590.71 k allocations: 35.695 MiB, 2.87% gc time, 99.16% compilation time)

How Has This Been Tested?
Tests will be added in the contract section that use the matricize portion of contract and give the exact same result as the non-matricized portion
Checklist:

[ ] My code follows the style guidelines of this project. Please run using JuliaFormatter; format(".") in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have added tests that verify the behavior of the changes I made.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

@emstoudenmire I looked into the error and its one I helped Ryan with last week. A recent update to the Julia version 1.9 causes an issue in the Zygote package. As a result one of our unit tests fails. So the failing test is not related to the work in this PR. (Ryan made a PR with only a change to documentation and was worried about why the unittest were failing)

To keep you in the loop @mtfishman , Karl and I discussed this in detail today, and agreed it's more of an experimental PR to see what kinds of compilation speedups might be possible to get and how to get them. Karl is going to add some more examples that put even more pressure on the compiler to see how big the speedups can be. A final PR implementing these ideas would need to be designed differently (some parts of the new code here being absorbed into functions above, and other parts being moved to NDTensors.jl).

Sounds good, glad this is getting explored and it's good timing with the release of Julia 1.9 which should make precompilation more effective once we refactor the contraction code properly.
This was a branch I was working on which refactored the contraction code logic to help with precompilation: https://github.com/ITensor/ITensors.jl/tree/ITensors_precompile. It's similar in spirit, where I was creating function barriers to split apart the logic of converting the tensors to matrices and then performing the contraction, but at a lower level in the NDTensors code. The goal was to make it so that less of the code had to get recompiled for tensors with new tensor orders that get input into the contract function, and therefore make precompilation more effective. I think there is a way to do that and make the contract code logic simpler, I would even hope to get rid of, or at least simplify, the ContractionProperties struct.
In our next meeting, we can try to go through the logic of the contract function in NDTensors and go through the changes I had been making in the ITensors_precompile branch.

I'll close this since it will be easier to refactor to improve compile times with changes in #1206, #1222, etc.


how can I change the loding animation and load custom animation

@tonypius since the latest version there is an onInitCallback provided in the options (see documentation here).
You can display a spinner and use this callback to hide it when your grid is ready to render.

Since the latest version (v2.2.0) there's an official built-in spinner animation, please consult https://yiotis.net/filterizr/#/documentation/vanilla/options


[evm] Contract modules and storage parameters (1st step)

This implements the first step towards passing references to contract storage to callables instead of requiring to use borrow_global<T>(self()). The intended functionality is not yet implemented but this prepares it.

Now contracts are associated with modules. One has to use #[evm_contract] as a module attribute to identify an EVM contract. Only callables inside of that particular module are recognized to belong to the EVM contract. This also addresses and closes #91.
As a result, one package can contain multiple contracts. However, the compiler will issue a warning if there is more than one contract and ignore all but the first because the remaining tool chain isn't yet prepared for dealing with multiple contracts.
The #[storage] attribute now indicates that callables should take a reference to this struct. This attribute is optional, so old-style contracts which use move_to and borrow are still supported. Because #[storage] is not fully implemented yet, it has been removed where it was used, as all existing tests still use old-style storage.
There was some heavier refactoring needed to be able to emit code for move_to and other storage related operations. Because the new regime requires to call move_to, borrow etc. outside of the FunctionGenerator, those functions had to be moved on Generator level. This is only partly used until now and will be fully leveraged in the 2nd step.

Nits:

Compiler output of the package system has been redirected to stderr instead of stdout. This was done because hardhat drops stdout somehow, and seems cleaner anyway.

Test Plan
Existing tests

This was done because hardhat drops stdout somehow, and seems cleaner anyway.

@wrwg I took a look at the plugin code and can confirm that it does print out both stdout and stderr, but only if there's an error. Was this the thing that confused you? But you did mention you fixed the problem by changing the compiler output to stdout so I'm not sure if this is the real cause...

This was done because hardhat drops stdout somehow, and seems cleaner anyway.

@wrwg I took a look at the plugin code and can confirm that it does print out both stdout and stderr, but only if there's an error. Was this the thing that confused you? But you did mention you fixed the problem by changing the compiler output to stdout so I'm not sure if this is the real cause...

There was an error. It printed the fact that there is an error to stderr which showed, but the error messages where printed to stdout which did not show.


Like Lists

Im trying to get the lists a user has liked with the Likes Endpoint but all i get back is a (405) Method Not Allowed Error the URL I'm using is https://api.trakt.tv/users/me/likes/lists. I'm able to use the other endpoints like https://api.trakt.tv/users/me/lists so its not an auth issue. Any help would be appreciated.

That endpoint was added/updated recently and what you're seeing may be a bug. For the authenticated user you should be able to use /users/likes/lists as expected for now (passing the access token), and then once the issue is resolved the /users/:id/likes/lists should work for other users (including using me). @rectifyer may have more information.


Efficient scheduling clarification

The section "Efficient Scheduling" contains the following claim:
The runtime schedules execution of a large number of single-threaded grains across a custom thread pool with a thread per physical processor core.
I believe the above should say logical processor core, instead of physical, to take into account hyperthreading. Please clarify with Orleans team and update the docs if needed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 03c92a61-dca1-a507-e434-4d2c95f468bd
Version Independent ID: 228b228c-f72e-0dec-4345-ee8682bf50e1
Content: Orleans benefits - .NET
Content Source: docs/orleans/benefits.md
Product: dotnet-orleans
GitHub Login: @IEvangelist
Microsoft Alias: dapine

We should change it, yep. It uses the .NET Thread Pool now, not a custom thread pool. Perhaps something like:

The runtime schedules execution of a large number of single-threaded grains using the .NET Thread Pool, which is highly tuned for performance


[sparkTest] Two dataframes with no common columns with failOnMissingExpectedCol=false should not be equal

test("with failOnMissingExpectedCol config") {
    val actualDf = dataframe("{c:0}")
    val expectedDf = dataframe("{a:0, b:false}")
    withConfiguration(failOnMissingExpectedCol = false)(
      actualDf.assertEquals(expectedDf)
    )
  }

I think the test should not pass when two dfs have no columns in common, even though both failOnMissingExpectedCol and failOnMissingOriginalCol options are false. We only want it to pass when we find common columns and those are equal.

Indeed, can you fix it?
On Mon, 28 Oct 2019, 21:29 Harrison Cheng<EMAIL_ADDRESS>wrote:

test("with failOnMissingExpectedCol config") {
val actualDf = dataframe("{c:0}")
val expectedDf = dataframe("{a:0, b:false}")
withConfiguration(failOnMissingExpectedCol = false)(
actualDf.assertEquals(expectedDf)
)
}
I think the test should not pass when two dfs have no columns in common,
even though both failOnMissingExpectedCol and failOnMissingOriginalCol
options are false. We only want it to pass when we find common columns and
those are equal.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/univalence/spark-tools/issues/26?email_source=notifications&email_token=AAAUKL7DHMMIVXJEHV7K6ADQQ5DS5A5CNFSM4JF7R7Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HU374WA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUKL32IVQLFHHDYNJPP4DQQ5DS5ANCNFSM4JF7R7ZQ
.


e2e tests fail since some of the images are not available in Github registry

          After extensive debugging on this PR, I identified the reason behind the failure of the `MinorVersionCompatibility` test. The issue is unrelated to the changes in this PR. Instead, it stems from certain versions of `celestia-app` not being available on [ghcr.io](https://github.com/celestiaorg/celestia-app/pkgs/container/celestia-app) (or failing to be pulled).

Context and Reproducibility:
To reproduce the issue, run the MinorVersionCompatibility test from this branch. You will notice that the second validator, node 1,  running version 1.33.0 fails:
--> Running end to end tests
go run ./test/e2e MinorVersionCompatibility
test-e2e2024/08/28 15:03:42 === RUN MinorVersionCompatibility
test-e2e2024/08/28 15:03:42 Running minor version compatibility test versions v1.0.0    v1.1.0  v1.10.0 v1.10.1 v1.11.0 v1.12.0 v1.13.0 v1.14.0 v1.2.0  v1.20.0 v1.21.0 v1.22.0 v1.23.0 v1.24.0 v1.25.0 v1.26.0 v1.27.0 v1.28.0 v1.29.0 v1.3.0  v1.30.0 v1.31.0 v1.32.0 v1.33.0 v1.34.0 v1.4.0  v1.5.0  v1.6.0  v1.7.0  v1.8.0  v1.9.0  v2.0.0  v2.0.0-rc0      v2.0.0-rc1      v2.0.0-rc2      v2.0.0-rc3      v2.0.0-rc4      v2.1.0v2.1.1  v2.1.2  v2.1.2-rc0      v2.1.2-rc1
INFO[0000] Initializing knuu with scope: runMinorVersionCompatibility_20240828_150342
INFO[0000] The .env file does not exist, continuing without loading environment variables.
INFO[2024-08-28T15:03:42-07:00]knuu/knuu.go:264 LOG_LEVEL: info
test-e2e2024/08/28 15:04:18 Starting node node 0 version v1.12.0
test-e2e2024/08/28 15:04:18 Starting node node 1 version v1.33.0
test-e2e2024/08/28 15:04:18 Starting node node 2 version v2.0.0-rc0
test-e2e2024/08/28 15:04:18 Starting node node 3 version v2.0.0-rc4
test-e2e2024/08/28 15:04:18 Creating txsim
{"level":"info","name":"txsim","directory":"/var/folders/gl/8f7g64t91rxc6hsz_gj0mqfh0000gn/T/txsim","time":"2024-08-28T15:04:20-07:00","message":"txsim keyring directory created"}
{"level":"info","name":"txsim","pk":"PubKeySecp256k1{038C900FC60525F5365DDD2AC8803C9AEC1E7D76FF5797A2730A7ED8C394461C01}","time":"2024-08-28T15:04:20-07:00","message":"txsim account created and added to genesis"}
{"level":"info","name":"txsim","image":"ghcr.io/celestiaorg/txsim:pr-3541","time":"2024-08-28T15:04:20-07:00","message":"setting image for tx client"}
test-e2e2024/08/28 15:04:20 Setting up testnet
{"level":"info","name":"val0","directory":"/var/folders/gl/8f7g64t91rxc6hsz_gj0mqfh0000gn/T/val0","time":"2024-08-28T15:04:20-07:00","message":"Creating validator's config and data directories"}
{"level":"info","name":"val1","directory":"/var/folders/gl/8f7g64t91rxc6hsz_gj0mqfh0000gn/T/val1","time":"2024-08-28T15:04:20-07:00","message":"Creating validator's config and data directories"}
{"level":"info","name":"val2","directory":"/var/folders/gl/8f7g64t91rxc6hsz_gj0mqfh0000gn/T/val2","time":"2024-08-28T15:04:20-07:00","message":"Creating validator's config and data directories"}
{"level":"info","name":"val3","directory":"/var/folders/gl/8f7g64t91rxc6hsz_gj0mqfh0000gn/T/val3","time":"2024-08-28T15:04:20-07:00","message":"Creating validator's config and data directories"}
test-e2e2024/08/28 15:04:20 Starting testnet
{"level":"info","time":"2024-08-28T15:04:26-07:00","message":"forwarding ports for genesis nodes"}
{"level":"info","name":"val0","version":"v1.12.0","time":"2024-08-28T15:04:34-07:00","message":"started and ports forwarded"}
{"level":"error","error":"timeout while waiting for instance 'val1-ccd8d54e' to be running","name":"val1","version":"v1.33.0","time":"2024-08-28T15:05:34-07:00","message":"failed to start and forward ports"}
2024/08/28 15:05:34 Failed to start testnet: node val1 failed to start: timeout while waiting for instance 'val1-ccd8d54e' to be running

The logs of the validator indicate pod initialization failed which may not provide much insight, but using Lens revealed more details about the cause: Error: ImagePullBackOff meaning that the image for that version seems unavailable.
You can also reproduce the issue by running E2ESimple with the version set to v1.33.0 and will get the similar results, i.e., failure in pulling the image.
You may change the seed in the MinorVersionCompatibility test, for example, to 45. This change results in different versions being assigned to the validators, but some versions, such as v1.34.0, still fail to be pulled.
Originally posted by @staheri14 in https://github.com/celestiaorg/celestia-app/issues/3817#issuecomment-2316334165

The issue was identified as being related to the local machine from which the git tag -l command was run, causing it to retrieve tags that were irrelevant to the celestia-app repository. So, can close the issue with no further actions needed.


Zend\Navigation: update isActive from MVC page and remove all relations to module

If no route for page is set then don't compare with route from RouteMatch
Removed unneeded "matched route name" from unit tests
Removed unneeded "active" property from MVC page
Removed all relations to module (ZF1) in MVC page and unit tests

The active property is defined in "AbstractPage" and the value is also "false".
https://github.com/zendframework/zf2/blob/master/library/Zend/Navigation/Page/AbstractPage.php#L134


Minor changes

Add 3 functions in Entity.js in order to generate setters functions : (generateSetterFunction, generateAddItemToListFunction, generateAddItemsToListFunction) with the checking of type
Add the tests linked to the functions
Add an non-undefined eventID and recordTime in EPCIS Document examples
Use the functions in almost all the setters in Event.js

It would also be great to test the directly the each setters with a good case and a wrong case to be sure that everything is ok. You can do that in the ObjectEvent test file.


Rename doesn't work for generic types

Renaming generic types doesn't work. E.g. for original code
type MyGenericType<'T1,'T2>() =
  member this.Foo = "Bar"

[<EntryPoint>]
let main argv =
  let myInstance = new MyGenericType<int,int>()
  printfn "%A" argv
  0

when I press F2, the line with let myInstance... becomes let myInstance = new MyGenericTypeMyGenericType() even before renaming, and after renaming to MyRenamedGenericType the result is:
type MyRenamedGenericType<'T1,'T2>() =
  member this.Foo = "Bar"

[<EntryPoint>]
let main argv =
  let myInstance = new MyRenamedGenericTypeMyRenamedGenericType()
  printfn "%A" argv
  0

I.e. all usages of the type duplicate the new type name and erase generic types.
VisualFSharp version <IP_ADDRESS>40101

Fixed in https://github.com/Microsoft/visualfsharp/pull/2955


Add support for LIMIT OFFSET for db2

Since 2016, DB2 has supported the LIMIT x OFFSET y construct. This PR supports the new construct in a BC manner via a feature flag. To use with TableGateway:
$tableGateway = new TableGateway($table, $adapter);
$decorator = $tableGateway->getSql()->getSqlPlatform()->getDecorators()['Zend\Db\Sql\Select'];
$decorator->setSupportsLimitOffset(true);

PR against wrong branch…


requests plugin

Tasks

[x] pinned main
[x] tests
[x] release
[x] readme documentation
[x] dev documentation

Required for

[x] NR
[ ] MOSBRI

@mesemus what is the status on the MOSBRI part?


⚠ Bofrost.de has degraded performance

In 622ae15, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1112 ms

Resolved: Bofrost.de performance has improved in 40b2270 after 32 minutes.


Update NuGet Packages

Related issue
Requested by Mark as part of the .NET 6 upgrade
Description

Auto-updated all NuGet packages in NuGet package manager
Also includes the update of Codelyzer to v2

Additional context

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Will review as part of the net6 branch


napari docs for npe2 cookiecutter not matching reality

I just wanted to clarify a comment I made on Zulip about the documentation for getting started (https://napari.org/plugins/stable/npe2_getting_started.html#create-the-project-using-cookiecutter). The docs says:

When the cookiecutter asked to include a reader plugin, we selected y, and in the next question we told cookiecutter that our reader should be invoked for files matching the *.npy glob pattern.

However, when I used the cookiecutter I never got asked that "next question". It simply defaulted to the npy case. If it's really planned to support choosing the import format in the cookiecutter that would very cool. If not I guess the above sentence should be removed form the napari docs (or clarified if I misunderstood).

I'm fixing the docs thanks to you!

choosing the import format in the cookiecutter that would very cool

Even though the cookiecutter prompts don't ask you for it, you can (and should) edit the napari.yml file to add filename_patterns that your reader will recognize.
We initially had that prompt in the cookiecutter, but removed it to keep the prompts from getting too cluttered.


Bump LEAP edu image version

Adding updated image version for LEAP edu image to support @RobertPincus teaching efforts.

Running into some unexpected pre-commit errors here. We just had the same issue over at xgcm and we got it fixed by setting the default-language-version to python3 from python3.9. Not sure if that is helpful here...

@jbusecke It was fixed by https://github.com/2i2c-org/infrastructure/pull/2117 Rebasing your PR should resolve the tests


empty commit

Just to trigger test env deployment

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

@GrzegorzKowalik Can we close it?


Improve ci

Add go 1.19 to test
Add redis 6 to test
Run benchmark in tests too
Use docker compose to start redis
Add dependabot configuration
Fix some data races

Let's avoid running benchmarks in tests, usually when we touch performance it's simpler to just run benchmarks manually, in CI this will be just an additional time.


Low gradient texture quality on Android in GLES 2

Godot version:
3.1.1 stable
OS/device including version:
Android / Windows 10
Xiaomi Redmi 5, Samsung Galaxy S8
Issue description:
On Android textures look like this.
No matter which flags are chosen, it does not affect the quality.
In version 2.1 everything looks the same as on the PC, so the problem only appeared in 3.1.
The problem is most noticeable with white or gray shades

Steps to reproduce:
Export to Android any texture that has gradient with transparency
Minimal reproduction project:

A minimal reproduction project would still be useful imo, as it is not clear what we are looking at in the pics in terms of transparency etc. Is this occurring with an uncompressed texture?

All textures are lossless compressed, but their quality as if they are vram compressed

It's not a bug. Enabling the 32_bits_framebuffer option solved the problem. It's strange, the same option in 2.1 did not affect anything


Performance issues

Noticing a really bad drop in FPS in the Unity IDE. Music is stuttering and I'm unable to get a stable framerate.
Need to test that this is just an IDE issue and not present in a desktop build. Also, need to look into any issues I may have created when extending the SoundData class or introduced the new UI layer.

I also made changes to the wrap logic in the TextureData class that may be causing the slow down as well?

UI has been optimized to only render when needed.


Add Dismissible state to Flash component

Broken out from #415
I'm submitting a ...

[ ] bug report
[ ] feature request
[x] support request

What is the current behavior?
Currently there is a prop thats being created in this PR (#417) for a dismissible flash message. However some work needs to be done to this component by an engineer to make sure its written properly and functions as intended.
What is the expected behavior?

When a dismissible flash (<Flash dismissible> is used
[ ] Then I can click the close button and the flash will no longer be visible.

When writing this component:

[ ] I would like for the close button component to be included inside the flash component itself so that when youre using it all you have to write is <Flash dismissible> Dismissible flash message </Flash and the close button will be included.
[ ] Harmonium doesnt have icons working so well need to use x or - for the close button for now.

[ ] HOWEVER, we should make it so that users could easily plug in different icons to be used as the close button (most likely using the icon component)

For feature requests: why should the behavior change?
Because we use a dismissible flash message on most projects and so it would be nice to have a component that we can pull from and use instead of reinventing the wheel every time.

@blazebarsamian im gonna pick this up and just branch off of #417. Ill make a PR into that

@blazebarsamian FYI this was merged into https://github.com/revelrylabs/harmonium/pull/417 -- would you mind taking another look at that PR to see if it can be merged?


Code Actions for React

| - activation range
Create ref
Before:

After:
const divRef = useRef<HTMLDivElement>()

Also supports custom components that contain prop ref in types
Generate handler
Before:

After:
const handleDivClick = useCallback((event: MouseEvent<HTMLDivElement>) => {

}, []);

Activated when the prop starts with on*, where * is any text starting with a capital letter. Also supports custom components that contain prop on* in types. Should automatically create an array of dependencies
Wrap handler into useCallback()
Before:

| { e.preventDefault() }} />

After:
const handleDivClick =  useCallback((e: MouseEvent<HTMLDivElement>) => {
  e.preventDefault();
}, []);

Activation when an arrow function is passed as an argument to a prop. Should automatically create an array of dependencies.
Maybe we should improve the Wrap into useCallback instead of adding a new Code Action.
Create (prop_name) prop
Before:
// App.tsx
<MyComponent |newUnknownProp={123}| />

// MyComponent.tsx
interface Props {
	someExistsProp: string;
}

const MyComponent: React.FC<Props> = (props) => ...

After:
// App.tsx
<MyComponent newUnknownProp={123} />

// MyComponent.tsx
interface Props {
	someExistsProp: string;
	newUnknownProp: number; // Infer type from value
}

const MyComponent: React.FC<Props> = (props) => ...

Activated when the user writes an unknown prop to a component. Should work only on components whose imports are outside of node_modules. If there is no Props interface, you need to create it. The type must be infered from the value, if there is no value, the boolean type by default.
Perhaps we need to create a setting that will control how to create types for the component:

Via generics (const MyComponent: React.FC<Props> = (props) => ...)
Via props (const MyComponent = (props: Props) => ...) (should be default, reccomended by React)

This will also be useful for Create Props interface Code Action
Infer (useState|useRef) type
Before:
const [name, setName] = |useState|();

useEffect(() => {
  setName('Agent_RBY_')
}, [])

After:
const [name, setName] = useState<string>();

useEffect(() => {
  setName('Agent_RBY_')
}, [])

Activated when useState or useRef has no type specified.
For useState: if has a default value, then it must evaluate from it (except with null, undefined and [])
Create useState variable (variable_name)
Before:
<button name={|buttonName|} />

After:
const [buttonName, setButtonName] = useState<string>();

<button name={buttonName} />

Activated when an non-existing identifier is passed as a prop. The type must be infered from the prop type

Create ref

I suppose before example should contain not defined indentifier, so this is quickfix to define ref with the name (similar to Create (prop_name) prop or builtin define not defined method quickfix)

Generate handler

While Wrap handler into useCallback() will be easy to implement, this one will be much much harder I think. So the question is: why can't user write e =>  and then use Wrap handler into useCallback() callback? On the other hand, since this plugin is intended to work with vscode only, I guess we can find workaround here.

Wrap handler into useCallback()

I think this refactoring should should activate in following cases:

any position in => of function or attribute name
either only attribute initializer selection (the whole function) or whole attribute selection

Create (prop_name) prop

I really like this one, but I was always in need for this in the following case:
interface Props {
	someExistsProp: string;
}

const MyComponent: React.FC<Props> = (props) => {
    props.newUnknownProp
}

Though if we use recommended way to specify Props interface TypeScript will suggest Declare missing property 'newUnknownProp' quickfix. So I'm good for adding this one.

Activated when useState or useRef has no type specified.

No type and initializer for useState. Also I think it would make sense to ignore setState invokations with callbacks.
And obviously declare property and add ref or useState won't have activation ranges since they are quickfixes


Roadmap goal suggestion

I was poking through the roadmap and saw this:
"Some way of extracting fuel from Thaumcraft nodes?"
Perhaps if you can use Venenum, Metallum, Potentia, and Praecantitio essence in some kind of machine to produce Yellorium? Or piping them in directly to an individual reactor, like you do Steam into the Turbine. Turning a Wisp/Mana Bean farm into RF this way would be awesome.

Could you post some pseudo code? This would be cool to add.

I think lore wise it would look like this:
Radioactivity has similar properties to flux (the letter is far waker tough). If you handle vis incorrectly, flux is being made.


BUG: stats: Fix numerical issues of recipinvgauss

The distribution recipinvgauss had issues:

The pdf and logpdf methods returned nan at x=0.
The cdf method might return negative values for small x
(e.g. recipinvgauss.cdf(0.05, 0.5) returned ≈ -1.31e-18,
but the correct value is ≈ 6.59e-20).
The sf method lost precision for large x, and for
sufficiently large x, would return 0 when the true value was
well within the limits of what can be represented with 64 bit
floating point (e.g. recipinvgauss.sf(80, 0.5) would return
0, but the correct value is ≈ 2.6998e-18).

This fixes an error that has started occurring in the Azure scipy.scipy (Main prerelease_deps_coverage_64bit_blas) CI check.  It shows up in the error summary of recent PRs as
FAILED scipy/stats/tests/test_continuous_basic.py::test_cont_basic[500-200-recipinvgauss-arg86]

Click for the full error message.
_________________ test_cont_basic[500-200-recipinvgauss-arg86] _________________
[gw1] linux -- Python 3.8.12 /opt/hostedtoolcache/Python/3.8.12/x64/bin/python
scipy/stats/tests/test_continuous_basic.py:153: in test_cont_basic
    check_pdf_logpdf_at_endpoints(distfn, arg, distname)
        arg        = (0.6300426780936912,)
        distfn     = <scipy.stats._continuous_distns.recipinvgauss_gen object at 0x7f70ab5cd0a0>
        distname   = 'recipinvgauss'
        m          = array(2.58719407)
        n_fit_samples = 200
        rng        = RandomState(MT19937) at 0x7F70471CA240
        rvs        = array([ 0.90944723,  4.33037421,  2.29749106,  1.0814838 ,  4.01982858,
        5.026032  ,  1.07908812,  2.30885547, ...55935 ,  0.81400617,  1.91073139,  3.9250574 ,
        0.81997577,  1.68208607,  1.42569254,  4.59027769,  1.00540439])
        sm         = 2.432196935657447
        sn         = 500
        sv         = 2.932514428289115
        v          = array(3.58719407)
scipy/stats/tests/test_continuous_basic.py:568: in check_pdf_logpdf_at_endpoints
    pdf = distfn.pdf(vals, *args)
        args       = (0.6300426780936912,)
        distfn     = <scipy.stats._continuous_distns.recipinvgauss_gen object at 0x7f70ab5cd0a0>
        msg        = 'invalid value encountered in multiply'
        points     = array([0, 1])
        sup        = <numpy.testing._private.utils.suppress_warnings object at 0x7f703f01f4c0>
        suppress_messsages = ['divide by zero encountered in true_divide', 'divide by zero encountered in log', 'divide by zero encountered in power', 'invalid value encountered in add', 'invalid value encountered in subtract', 'invalid value encountered in multiply']
        vals       = array([0.])
scipy/stats/_distn_infrastructure.py:1913: in pdf
    place(output, cond, self._pdf(*goodargs) / scale)
        args       = (array(0.63004268),)
        cond       = array([ True])
        cond0      = True
        cond1      = array([ True])
        dtyp       = dtype('float64')
        goodargs   = [array([0.]), array([0.63004268])]
        kwds       = {}
        loc        = array(0)
        output     = array([0.])
        scale      = array([1])
        self       = <scipy.stats._continuous_distns.recipinvgauss_gen object at 0x7f70ab5cd0a0>
        x          = array([0.])
scipy/stats/_continuous_distns.py:7290: in _pdf
    return 1.0/np.sqrt(2*np.pi*x)*np.exp(-(1-mu*x)**2.0 / (2*x*mu**2.0))
E   RuntimeWarning: divide by zero encountered in divide
        mu         = array([0.63004268])
        self       = <scipy.stats._continuous_distns.recipinvgauss_gen object at 0x7f70ab5cd0a0>
        x          = array([0.])

The other failures in scipy.scipy (Main prerelease_deps_coverage_64bit_blas) are fixed in https://github.com/scipy/scipy/pull/15192


Added a GUI

Following a proposal in #3, I added a quick GUI for the program using Tkinter. But since the API isn't super easy to tag a GUI into, it throws the values from the text boxes into the program by calling it with subprocess.
Here's what the GUI looks like on Windows 10:

The text boxes with grey text simply use a default string if the user doesn't enter any text, and the advanced options is a collapsible panel. These are widgets from my library, hence the new requirement (pkinter). All the text boxes (apart from the file ones) have tooltips as well!
TODO:

[ ] Video and/or audio preview (requires a video and/or audio widget -- I'll write these for pkinter)
[x] Make use of the TTK Spinbox and/or Scale widgets for numeric values (Spinbox's would require a similar wrapper widget as the Entry's have, shouldn't be hard)
[x] Support for YouTube videos (requires syncing with master)

Bugs:

[x] Entry widgets are being passed instead of their values (what a blunder)
[x] The output selector uses filedialog.askopenfile, it should use filedialog.asksaveasfile

Edit: I haven't actually tested this since I don't have a video on hand to try it with, but it should still work.

dam you put mine to shame

Tried this, for some reason, can't import Hovertip
any help?

the next step is probs to make the api better so we can get some data from it to display the video

When i try to set a custom output name, it says that the path isnt found
oof

Oh! I didn't realise someone else was working on a GUI, I'm sorry, @elff1493. I should have submitted an issue and said I was going to work on one... My bad. You can do the video part if you want? It might take some time and it'd require a decent knowledge of the Canvas widget... If not, I can get a widget written up for my library and use it here.
@A-Random-Birb, it does? Was that error thrown through by the GUI or the program itself? Did you use the button to select a file?

TODO:
A video preview of the output, with a preview button next to the run button

@DeflatedPickle  Instead of a preview button, a checkbox next to RUN will be more suitable and easier to implement and understand. What do you think?

@abhiTronix, I say a preview button as then it would only have to process the video once when the user clicks it. If it was a checkbox, it seems like it would have to update each time the user updated a value, which could cause a bit of lag depending on their settings. Or were you thinking of implementing it differently?

I made a lil' gui about 8 hours ago or so :P. Wouldn't be easilly mergable though because in the process I also rewrote parts of the actual jumpcutter code to allow for better ffmpeg integration, not having to have two python processes spinning up, etc.

Ah, and so I have bested as well, @Bottersnike. You even have a nice progress window for the progress!

It looks really good! I made one too with Qt Designer, but yours look better.

Yeah, I took a look. Good work, @A0A3R2E6! It's a bit messy but I believe you can hammer out the kinks!
It's my first time contributing to a project like this and already there are 3 different things like my thing! I'm nervous yet hopeful.

@abhiTronix, I say a preview button as then it would only have to process the video once when the user clicks it. If it was a checkbox, it seems like it would have to update each time the user updated a value, which could cause a bit of lag depending on their settings. Or were you thinking of implementing it differently?

@DeflatedPickle I was thinking to display preview video at the end when the processing part is done i.e. by clicking the RUN button. This checkbox will be checked [ON]  by default. A user can disable this by simply clicking it again if he doesn't want to preview file or will be disabled by default if the input is audio only.

Thanks @DeflatedPickle !! It'd be nice if we all could merge our UI's into one so we could help create somewhat of a decent app. At this point we are all part of a team.

@abhiTronix, but if they've already run it and saved it to a file, there's not much point in previewing it in the GUI? Usually, a preview would come before it was saved.
@A0A3R2E6, as nice as that would be, I don't think it'd be super smart. As it wouldn't be very easy to merge a Qt UI into a Tk one, and you and (and I think) @Bottersnike used Qt. But we could work on improving one of the designs together?

@DeflatedPickle Well, by merging I meant of combining efforts, but yes it's true that literally combining all of the UI's would not be easy. But It'd be nice to work with you and @Bottersnike on improving one of the designs. Sign me in anyday.

@A0A3R2E6, ah, alright. @Bottersnike's changes aren't open-source last I checked, so they might not be up to have them pulled. So it's between yours and mine... Would you be okay working on mine?

@DeflatedPickle Alright then, we will work on yours.

this is really nice

@DeflatedPickle When I try to use the GUI jumpcutter.py throws an error saying that silent speed has an invalid float

Thank you, @cthpw103! If you have any suggestions for changes or ideas, please leave them in a comment and I can add them to the to-do list.
@will9183, right... So I think I forgot to convert the values in the text boxes to the proper types... I'm kind of ashamed it got this far without testing, I mean, someone even packaged it up in an EXE without reporting this. Thanks for bringing it up, I'll commit a fix after din-dins.

@DeflatedPickle No problem. I was planning on updating my installer anyways so it all works out.

@will9183, actually, I don't know what I was thinking. The values should be passed in as strings and then argparse casts them to the type they should be. So it might just be a problem with what you entered for the silent speed.
Also, I apologise. I didn't remember it was you who used this for the EXE. Sorry about that. :v

Oops, it is actually silent threshold that is having an issue. This is the actual error:
usage: jumpcutter.py [-h] [--input_file INPUT_FILE] [--url URL]                      [--output_file OUTPUT_FILE]                      [--silent_threshold SILENT_THRESHOLD]                      [--sounded_speed SOUNDED_SPEED]                      [--silent_speed SILENT_SPEED]                      [--frame_margin FRAME_MARGIN] [--sample_rate SAMPLE_RATE]                      [--frame_rate FRAME_RATE] [--frame_quality FRAME_QUALITY] jumpcutter.py: error: argument --silent_threshold: invalid float value: '.!toggledlabelframe.!frame2.!entrytext'
The default value is 0.03

@will9183, okay, I think I might have figured out where the bug is. I'm using my own widgets wrong, geez. I'm gonna commit what might be a fix in a bit.

@DeflatedPickle Yup it fixed it. Thank you, I will update my EXE tonight.

Great, @will9183! Thank you for bringing it to my attention, I'm not sure it would have been fixed otherwise!

@DeflatedPickle And now there is another error. I don't know if it is the gui or not but I get this halfway through ffmpeg's stuff and this shows up:
Traceback (most recent call last):   File "jumpcutter.py", line 158, in <module>     wavfile.write(sFile,SAMPLE_RATE,audioChunk)   File "C:\Users\will9\AppData\Local\Programs\Python\Python37\lib\site-packages\scipy\io\wavfile.py", line 359, in write     bytes_per_second, block_align, bit_depth) struct.error: required argument is not an integer
Sorry for the inconvenience

@will9183, it seems to be due to FFMPEG not wanting a float value for the sample rate. Changing the type for the sample rate argument to an int solves this issue for me. But I am getting an error past that. It's possible these are inconsistencies between the Windows and Linux versions, I'm not sure.
I'll run it under Linux and see if it goes well tomorrow. I'll submit an issue if it does work there, so a patch for Windows can be made. I'll also rebase this branch with carykh:master and add support for the YouTube downloader.

@DeflatedPickle Changing line 63 (55 in the old file) of jumpcutter.py from parser.add_argument('--sample_rate', type=float, default=44100, help="sample rate of the input and output videos") to parser.add_argument('--sample_rate', type=int, default=44100, help="sample rate of the input and output videos") solves the problem for me.

@will9183, then it seems like it is just an inconsistency. If it's not fixed in master somebody should probably make an issue or pull for it. :lul:

@DeflatedPickle I just did. #73

Couldn't find the Pkinter widget for the output file picker, so I used something like this instead as a means to fix the bug issue.
self.output_file = ttk.Button(self, text = self.bButtonText.get(), command = self.browse_output)
self.output_file.grid(row=1, column=1, sticky="we", padx=6, pady=2)

Then function -
 def browse_output(self):
        self.file = tk.filedialog.asksaveasfilename(filetypes=[("MP4 Files", ".mp4")],\
                                                                defaultextension=".mp4",)
        self.bButtonText.set(self.file)
        print(" Output file is :" + self.bButtonText.get())

Couldn't figure 'proper' passing of the filename string to the python subcall, but just used the get method.
Also switched subprocess.call for subprocess.Popen, although I bet a more thorough multithreaded approach would be best.

@tomesparon, I don't recall if I made a save dialog for pkinter, but if I didn't then that's great! I tend to use projects like these to improve my libraries, so I would have added one!
Also, if you want to make a change, it'd be better to make a pull request to my fork than just mention it.

can i run it on windows? i got this error.

I made a lil' gui about 8 hours ago or so :P. Wouldn't be easilly mergable though because in the process I also rewrote parts of the actual jumpcutter code to allow for better ffmpeg integration, not having to have two python processes spinning up, etc.

can you email me the code, i can't figure out it.

@katyperry13 If you are using the command line, it looks like you need to put your file address locations in quotation marks.

@katyperry13, your issues don't seem relevant to this pull request. Could you please remove them and take them elsewhere?

@UltraNiels, I think it's ready to be pulled now, if you want it. I can squash the commits first too, if you want a single commit for the pull.

@DeflatedPickle Yes! Great

@UltraNiels, just reminding you that it's ready to be pulled if you want it.

@DeflatedPickle I know it has been a year since the last update on this thread, but a few days ago I started looking back at this project to reattempt my installer and I tried running your gui program and I got this error while it was trying to run:
Traceback (most recent call last):   File "C:\Users\will9\Downloads\jumpcutter-gui (1)\jumpcutter-gui\gui.py", line 160, in <module>     window = Window()   File "C:\Users\will9\Downloads\jumpcutter-gui (1)\jumpcutter-gui\gui.py", line 62, in __init__     self.output_file = pk.FilePicker(self, "save", filetypes=filetypes, defaultextension=".mp4") TypeError: __init__() got multiple values for argument 'filetypes'
It seems like an error with Pkinter, but I cannot really tell.

@will9183, I think there was an update for Tkinter that changed the file dialogues. I haven't been keeping track of it as I no longer actively do Python or Tkinter code. I guess I can take a look at it tomorrow though? I think this is actually more popular than anything else I've made.

@DeflatedPickle Yeah, I do think all jumpcutter things are starting to get more popular lately, as now there is a group effort working on an online version, but that same group is also trying to maintain the current offline version of jumpcutter. I want to attempt to recreate my installer package from a year ago (and actually make it work) and present it to the group. I do believe your GUI has been the most easiest to work with (because it is in python and I know how to use it to an extent). Thank you for taking a look at it.

@will9183, it is? I'm super out of the loop with this. But thank you!

@DeflatedPickle Your welcome and this issue page has more information on what has been going on with the jumpcutter project as well: #148

I recommend that the gui also show time reduction + sections excluded + ability to manually make sure that certain sections are left in the video

@eladmw, I'm not going to work on this any more, but if you would like to fork my fork and make these changes, you're welcome to.

A label showing the time reduction wouldn't be hard, though it would need to render the video (on a second thread?) before exporting
I don't think there was an easy way to grab the removed sections, though I haven't looked through this code since it was written
Manually selecting sections to keep would require there was a way to find removed sections and most likely a new window to preview those sections, which could need some video player


segfault when trying to encrypt a file with xchacha20 when an undofile exists

The undofile got disabled for xchacha20, but looks like there are some problems if there's already an undofile; with set undofile in my vimrc:
$ vim newfile
"newfile" [New]

:set cm=blowfish2
:X

" Make some changes

:wq
"newfile" [New][blowfish2] 1L, 7B written

Okay, now:
$ vim newfile
Enter encryption key:
"newfile" [blowfish2] 1L, 7B

:set cryptmethod=xchacha20
:w

"newfile" [New][xchacha20] 1L, 7B written

Okay, that worked, but opening it gives me a segfault after entering my password (a here for testing):
$ vim newfile
Need encryption key for "newfile"
Enter encryption key: *
Note: Encryption of swapfile not supported, disabling swap- and undofile
Vim: Caught deadly signal SEGV
zsh: segmentation fault  vim -p newfile

In another example it segfaulted in step 2 (trying to first write as xchacha20); maybe because this is an older file with a longer history/undo file? I rm'd the undo file, copied the backup I made back, and then it didn't segfault. I can't readily reproduce that now any more (even when I make sure there's an undo file by making some changes in the blowfish file).
Either way, that also seems related to the undofile.
Vim 8.2.3061 054794c20 on Linux with libsodium 1.0.18

I'll fix the crash, but what should really happen is that the undo file is deleted.

Also, when 'cryptmethod' is set to "xchacha20", 'undofile' is still set.  Perhaps it's best to set it when writing or reading a file, so that 'cryptmethod' can be set without side effect until actually writing.  Since that is applying the current option values to the file.  Also that's when the undo file would be deleted, since it's no longer valid.  When reading we can simply ignore an existing undo file.

I am confused. Anything more to do for encryption here? Not sure if there is anything expected here from me 😕

Seems good after I update: it no longer crashes. But I'm not sure if Bram wanted to do something else based on his comments(?)

What still needs to be done is when writing a file, if the crypt method used is "xchacha20", then reset 'undofile' and make sure any existing undo file is deleted (it's invalid and might contain text that is now encrypted).
Then when changing 'cryptmethod' there is no need to reset 'undofile'.

I'll have a look. But it will take me some time.

okay, I think I have done that in #8630


Mouse Without Borders - Shortcut to Connect/Disconnet from machine(s)

Description of the new feature / enhancement
Add shortcut keys to connect or disconnect a machine from mouse without borders.
Scenario when this would be used?
Being able to connect or disconnect from a machine without having to open the interface would greatly improve productivity when you only want to work on a specific machine and not have your mouse move to another machine by accident.
Supporting information
For example something like Ctrl + Alt + X + <number> shortcut to disconnect from a machine and Ctrl + Alt + C + <number> to connect to a specific machine.

Use the toggle to disable easy mouse.  And they have a shortcut to switch between machines.

Use the toggle to disable easy mouse. And they have a shortcut to switch between machines.

Good point, but I still think there is a use case when you want to use easy mouse with specific machines. Some times I want to switch easily between two machines with easy mouse while disconnect from a third one temporarily. Other times I want to use easy mouse on all three machines, so on and so forth.


Initial support for backend reindexing visitor functionality

@geirst @toregge please review
@jonmv FYI
Introduces the concept of a read-for-write visitor operation which
blocks all mutating operations from starting for a bucket being
visited. This read-for-write mode is used if (and only if) the visitor
library being specified by the client is "reindexingvisitor".
Since read-for-write visitors cannot race with concurrent write
operations, starting such visitors are deferred until no further
mutations are pending.
Also adds a basic reindexingvisitor implementation to the content node
which sends all documents as Puts containing a special TaS token
that will let the operation through even if a bucket is locked. This
token is cleared by the distributor before it is passed on to the
content nodes.
Note: this feature is not yet production ready. For now the following
caveats apply:

Mutating vs non-mutating pending ops to a bucket are not tracked
separately, so it’s possible to starve a reindexing visitor by
sending constant pending read load, as read load is not blocked by
the operation sequencer.
Ideal state operations towards locked buckets are not blocked, so
it's possible for e.g. a split to be sent for a bucket that is being
visited.

@geirst PTAL at the two latest commits


[BFCL] Bug Fix parse_nested_value function for model_handler utils

In the parse_nested_value function, added a check to determine whether we are dealing with another function call or if its a regular dictionary. Previous version of the code incorrectly assumed that this was always a function call and did not consider the case where the function argument is a dictionary.
Fix https://github.com/ShishirPatil/gorilla/issues/652

@HuanzhiMao Thank you for catching. Should be fixed in the latest commit.


Basename in memory history

Hello, I'm here to re-open an issue of basename in memory history.
I've read issues/409 and I understand what you were explaining but, in my opinion, it could be changed in 2019. Your lib is now used but other librairies and depends on the internal working of history (e.g. connect-react-router with what I'm having an issue). Even if you recommend not to use memoryHistory on server side, it's also used this way today.
For sure, maybe these libs should no do it like that and change, or maybe we should upgrade history to work with it !
AS @TiddoLangerak said in this comment, we can't properly use basename in server-side rendering because url generated on server will be different on client. It's clear that duplicating routes or prefixing all Link components with a basename (like langage or country) are not some good practice, so I have to find a way to improve that.
URL are not exclusive to browser environnements and SSR with js applications is growing !
This option should works same for client, server, testing, etc...
So why should we restrict a functionnality that can help to do something that might be 'logic' (for me at least :smile:). I've tried to implement it fast on my local project and it works great (just a little poc to understand the code of your lib !
What do you think about it ? Maybe i'm misleading myself and taking this probleme the wrong way.
Thx anyway ! (ps : sorry approximative english)

Can you please tell me a little more about your use case? Are you building a native app that needs basename support?

Hello, I'm building a reactJS app integrated with Symfony. And I'm using server side rendering too (done with a nodejs env). So, for client side, I have to use browserHistory, and on server side I use memoryHistory. They cant take the same params, so it's not build the same way, and when my links are generated, there is no prefix on server side...


📦 NEW: Add automated latest solution stack by regex feature

Types of changes
What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING.md doc.
[x] I have added necessary documentation (if appropriate).
[x] Any dependent changes have been merged and published in downstream modules.

@mcosta1105 @luiz-dnx could you guys approve that again?


Update now that ARM64 packages are natively supported by Visual Studio and the Microsoft Store.

I tested this @benhillis - works fine. I already updated the Debian app and uploaded it to the certification process. Thanks for the heads-up 👍

Great! Thanks for the second set of eyes.


favicon.ico

Dear @Echsecutor ,
I like your idea of adding a favicon - many thanks!
Any chance to move it into the image folder? I would have done it myself, but I don't see it referenced.
Kind regards,
Ralph

Withdrawn for the moment...


java serialization for JsonFormat

I am trying to so spray json in spark.  Spark tasks must be serializable, so this JsonFormat become problematic if trying to write generic code like
def toJson[A : JsonFormat](rdd: RDD[A]) = rdd.map(_.toJson.toString)

since JsonFormat[A] will be closed over but they are not Serializable (at least not in the DefaultJsonProtocol.
Quickly scanning through the code, it seems like most if not all JsonFormats should be Serializable.  Would it make sense to make JsonFormat extend Serializable?  If that is too heavy-handed, could the JsonFormats defined by the DefaultJsonProtocol be marked with Serializable wherever possible?

+1


Ensures the QueryBatchCursor cleans up resources

The QueryBatchCursor now checks the cursor is operable on result of getMore.
Updated the Async test to ensure connectionB is used.
JAVA-5214

Please update the commit message to reference JAVA-5214.

Fixed commit message JAVA-5124 -> JAVA-5214

Thanks @stIncMale - so no bug, just unclear tests.
I've simplified / clarified the initial connection and tests in the CommandBatchCursor refactor.  Closing this PR.


Add help text for field

Awesome Contentful app, it would however be very helpful if this component would also support adding a help text.

You should be able to set help text with the app parameters, make sure the id is set to helpText
Reference https://www.contentful.com/developers/docs/extensibility/app-and-ui-extension-parameters/


DataViewer does not keep column names at the top as always visible

Keep the column names always visible while scrolling.
Having a row number would be nice.

Hi @bruno-mueller-sas! Thanks for the feedback 😊. I think your suggestions make a lot of sense. I'll add this to the list of improvements we're planning for the data viewer.

This will be taken care of as part of https://github.com/sassoftware/vscode-sas-extension/issues/308


shortlist page

changed content.

if you have more than 1 response the page tells you to follow the guidance on how to shortlist.

if you don't have any responses the page tells you to start again.

also added back link to the overview page.

Question: this has changed things so that the CSV download link is always shown.  Is this right?  I thought we had agreed that responses should only be downloadable once the brief is closed.

Should we also tell buyers with zero eligible responses that "Suppliers that did not meet all your essential requirements have already been told they were unsuccessful."?

I've fixed some of the logic about when text should be shown, and made the tests pass, but earlier questions are still relevant.  Changes need to be made either way depending on whether we want to allow csv download on open briefs.

Updated, think this is all good now.
New screenshots:

Brief is closed

Brief is still open

@TheDoubleK you’re right, we should keep the line about 'Suppliers that did not meet all your essential requirements have already been told they were unsuccessful.' if there are 0 responses.

Latest view of zero-eligible version of the page:

content for zero-eligible should be:
No suppliers met your essential skills and experience requirements.
If you still need this service, you should start the buying process again.

No suppliers met your essential skills and experience requirements.
All the suppliers who applied have already been told they were unsuccessful.
If you still need this service, you should start the buying process again. Consider:

talking to suppliers before you start
rewriting your requirements

Back to overview

I fixed my own issue but ran it past @TheDoubleK. Everything else is good so :+1:


Saturn Style Router

Is your feature request related to a problem? Please describe.
The default router we have is fairly straight forward but it might become verbose and annoying to write for larger applications, it also doesn't help to figure out the structure of a web application
Describe the solution you'd like
The way Bix uses routes is similar to the EndpointRouter from Saturn, we define a list of routes and then we match on them via URLPattern, Ideally we should be able to create a similar router we might not have pipelines and plugs at the beginning but at least routers and controllers should be present
let todoController: RouteDefinition list =
  controller {
    // operation: HttpContext -> Promise<BixResponse>
    find (ctx -> BixResponse) // get /todos
    findOne (id -> ctx -> BixResponse) // get /todos/:id
    update (ctx -> BixResponse) // put /todos
    updateOne (id -> ctx -> BixResponse) // put /todos/:id
    create (ctx -> BixResponse) // post /todos
    delete (ctx -> BixResponse) // delete /todos
  }

let routes: RouteDefinition list =
  router {
    // verbOperation -> string -> HttpHandler
    get url HttpHandler
    post url HttpHandler
    put url HttpHandler
    patch url HttpHandler
    delete url HttpHandler
    custom verb url HttpHandler
    forward url handler // ideal
    // alternative in case the above proves to be complicated
    controller "/todos" todoController
  }

Describe alternatives you've considered
A plain Giraffe style of routing
Additional context
Add any other context or screenshots about the feature request here.

Some updates

this was merged in #2


Delete unnecessary spaces

Unnecessary spaces: When copying from the web page, there is an unnecessary space after the code.
Indent: Indentation is misaligned.

@changeworld : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

@changeworld @Mikejo5000 Mike Jones (DEVUE) FTE - We're in the process of pulling these commits to the private repo, so we can verify the content on staging. We'll post a new PR # shortly and then close this PR.

@changeworld @Mikejo5000 - The commits in this PR were moved to the private repo (PR 3887) for validation and staging. We'll close this PR now.


⚠ Bofrost.fr has degraded performance

In 6079d14, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1458 ms

Resolved: Bofrost.fr performance has improved in 7d144e4 after 310 days, 18 hours, 36 minutes.


Ci/add to workflow & modify dependabot

This PR adds the following workflows :

build
publish
release
test

it also modifies the existing workflows:

follow-contributor: minor action version upgrade
lint: add linter workflow for dockerfile, typescript, json files. There are also some minor changes.

It also adds a Dockerfile and adds standalone output.

@ccamel Thanks Christophe I've added the changes you suggested.


Installation failed on Craft 3.7.43

`Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for doublesecretagency/craft-cpcss ^2.5 -> satisfiable by doublesecretagency/craft-cpcss[2.5.0].
- doublesecretagency/craft-cpcss 2.5.0 requires craftcms/cms ^4.0.0-beta -> satisfiable by craftcms/cms[4.0.0, 4.0.0-RC1, 4.0.0-RC2, 4.0.0-RC3, 4.0.0-beta.1, 4.0.0-beta.2, 4.0.0-beta.3, 4.0.0-beta.4, <IP_ADDRESS>, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5, <IP_ADDRESS>, <IP_ADDRESS>, 4.0.6, 4.1.0, <IP_ADDRESS>, <IP_ADDRESS>, 4.1.1, 4.1.2, 4.1.3, 4.1.4, 4.1.x-dev, 4.2.x-dev] but these conflict with your requirements or minimum-stability.
Installation failed, reverting ./composer.json to its original content.`
According to https://plugins.craftcms.com/cp-css it should be compatible with Craft 3 as well though...

Looks like you're trying to install the Craft 4 version of CP CSS (v2.5). The last Craft 3 compatible version is CP CSS v2.4.0.
Try lowering your composer requirements to ^2.4. And if that doesn't work, you can lock it in as 2.4 exactly.
"doublesecretagency/craft-cpcss": "2.4"


UI: Party creation review screen

The application should provide more user-feedback and review. We can do this by including a review screen when a user submits a new election. The review screen would be the final step to review the relevant info they are about to submit in the party.
i.e.

name
description
resolved ens side-by-side plain addresses
etc

Is this a Good First Issue candidate, please?
Frontend, Node, React, Chakra skills, but what else?
Where would it hook into the existing implementation, what current page looks closest?