Commands "Add File to Cody" and "Add Selection to Cody"

Just like the title sais, this is what the new features do.
Add File to Cody
Does the same thing as Add Folder to Cody, just for files

Add Selection to Cody
Select some files with ctrl+mouse1, right-click on the selection and run the command, and all files and folders that are selected will be added to Cody

Problems
Currently, when >1 file is selected, the "add selection" command always shows up in the right click menu. When run on a file that isn't in the selection, it adds only that file, nothing else. I haven't found a way to prevent it from showing up in that situation :/

Also contains adding shallow directory together with non-shallow directory now


[TS migration] Migrate 'ReimbursementAccountLoadingIndicator.js' component to TypeScript

Details

[TS migration] Migrate 'ReimbursementAccountLoadingIndicator.js' component to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/25075
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Open the app
Go to Settings -> Workspaces -> Open any Workspace
Go to Reimbursements section
Tap Connect bank account
Make sure the loading indicator which displays for a second, looks as expected

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

Open the app
Go to Settings -> Workspaces -> Open any Workspace
Go to Reimbursements section
Tap Connect bank account
Make sure the loading indicator, which displays for a second, looks as expected

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Usually we require C+ review and reviwer checklist, but his Pr is such a small change that I think we can straight merge this. Wdyt @arosiclair?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.45-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


How to detect foreground/background mode after receiving the push notification on iOS

Description
Hi,
How to detect foreground/background mode after receiving the push notification on iOS? According to the documentation for the Android we can check if message property is empty. How to reach the same on iOS?
if (message === null || message === undefined) {
   // Android messages received in the background don't include a message. On Android, that fact can be used to
   // check if the message was received in the background or foreground. For iOS the message is always present.
   title = 'Android background';
   message = '<empty>';
}

I use Ionic 4 with this plugin: https://ionicframework.com/docs/native/app-center-push
Repro Steps
Please list the steps used to reproduce your issue.

Send the notification
Click on a notification

Details

Which SDK version are you using?
0.3.4
Which OS version did you experience the issue on?
Android 8, Android 9
What version of Cordova, Cordova platforms, Cocoapods, and Ruby are you using?
Cordova version 8.0.0
What device version did you see this error on?  Were you using a simulator or a physical device?
Nokia 7Plus, Huawei P10 Lite
What third party plugins are you using?
cordova-android-firebase-gradle-release 3.0.0 "cordova-android-firebase-gradle-release"
cordova-android-play-services-gradle-release 3.0.0 "cordova-android-play-services-gradle-release"
cordova-plugin-actionsheet 2.3.3 "ActionSheet"
cordova-plugin-app-version 0.1.9 "AppVersion"
cordova-plugin-appcenter-analytics 0.3.4 "App Center Analytics for Cordova"
cordova-plugin-appcenter-push 0.3.4 "App Center Push for Cordova"
cordova-plugin-appcenter-shared 0.3.4 "App Center shared code for Cordova"
cordova-plugin-background-mode 0.7.2 "BackgroundMode"
cordova-plugin-browsertab 0.2.0 "cordova-plugin-browsertab"
cordova-plugin-camera 4.0.3 "Camera"
cordova-plugin-cocoapod-support 1.6.0 "Cordova CocoaPods Dependency Support"
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-contacts 3.0.1 "Contacts"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-dialogs 2.0.1 "Notification"
cordova-plugin-inappbrowser 3.0.0 "InAppBrowser"
cordova-plugin-ionic-keyboard 2.1.3 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 3.1.2 "cordova-plugin-ionic-webview"
cordova-plugin-ms-adal 0.10.1 "ADAL for Cordova"
cordova-plugin-network-information 2.0.1 "Network Information"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-sqlcipher-adapter 0.2.1 "Cordova sqlcipher adapter"
uk.co.workingedge.phonegap.plugin.launchnavigator 5.0.4 "Launch Navigator"

Hi there! In the PushNotificationReceived callback on iOS, there's no way to distinguish between these modes.
However, there are multiple options if you want to achieve that:

You can check out this comment in the thread. It is about React Native iOS SDK but the same applies to Cordova iOS SDK.
If you want pure ionic solution, you can check out multiple Stackoverflow questions on this, for example, setting pause/resume listeners


State update

I'm still not convinced that ids is better than pagination.
First represents structure. Second represents intent.
Latter sounds more reasonable.


Fixed typo - removed ` from command

Removed an extra ` (backtick) that was causing the command to fail.

@tonymitchell : Thanks for your contribution! The author, @hansenms, has been notified to review your proposed change.


Dynamic variables in key names

This change adds support for resolving key names in objects using variables. For example, if the data passed to carbone.render contains:
{
  "language": "de",
  "item": {
    "names": { "en": "Washing machine", de: "Waschmaschine" }
  }
}

Then, in the template, we can use a key from item.names that depends on the passed language by using a Carbone variable (also called "alias" in the Designer documentation) with a new de-referencing syntax:
{#lang = d.language}
{d.item.names.$$lang}

Under the hood, this key reference translated to an IIFE that evaluates _root.d.language or returns an empty string on error (like when some object along the path is null/undefined).
Only references to known variables are replaced with dynamically-computed keys, so this change preserves compatibility for users of key names with $$ in them (they work as usual) - unless you define a variable of the same name.
Square brackets were considered to give developers more familiarity (would have been similar to obj[variable] in JS), but ultimately a "$$" syntax was chosen that requires minimal changes to the parser/renderer logic.
Note that this function only supports plain, parameter-less aliases/variables so far (no array filters), and the variable code (the part after =) must be eval-able.
Basic tests for this renderer feature are provided.

@dgrelaud is there anything that should be done to merge this change?

is there anything that should be done to merge this change?

Yes, this our top priority next feature.
I think it will be available at the end of december (with other great features! )
The solution provided by rkaw92 is great but it does not work in all cases with nested arrays for example.
Stay tuned!

The new v2.0 includes this feature now.
Thank you for your help.

Does this work on an array.
For example:
{#lang = d.language}
{d.items[i].$$lang}

I am trying this and everything is rendering apart from {d.E.1[i].$$customer}


Problem when using player on 2 consecutive screens

First of all thanks for this amazing player. Recently i replaced Chewie with Meedu player because I liked this interface/UI. But I am facing one problem with this player. I have a list of routes on each route there is a video. The first route's video plays without any problem but as soon as i do Navigator.pushReplacementNamed() to any route the video player gives error.
Upon trying to debug i found that dispose() method of previous route is being called late after initState() of new route which means the playerController is being disposed after new route is opened so on new route it gives the red error (screenshot attached below).  For now sadly i need to move back to Chewie because it working fine in this same scenario. Please fix this issue if possible...
A VideoPlayerController was used after being disposed

My init method:
_init() {     _meeduPlayerController.setDataSource(       DataSource(         type: DataSourceType.network,         source: optedVideo['video'].toString(),       ),       autoplay: true,     );   }
My dispose method:
void dispose() {
    _playerEventSubs?.cancel();
    Wakelock.disable();
    _meeduPlayerController.dispose();
    super.dispose();
  }

First of all thanks for this amazing player. Recently i replaced Chewie with Meedu player because I liked this interface/UI. But I am facing one problem with this player. I have a list of routes on each route there is a video. The first route's video plays without any problem but as soon as i do Navigator.pushReplacementNamed() to any route the video player gives error.
Upon trying to debug i found that dispose() method of previous route is being called late after initState() of new route which means the playerController is being disposed after new route is opened so on new route it gives the red error (screenshot attached below). For now sadly i need to move back to Chewie because it working fine in this same scenario. Please fix this issue if possible...
A VideoPlayerController was used after being disposed

My init method:
_init() { _meeduPlayerController.setDataSource( DataSource( type: DataSourceType.network, source: optedVideo['video'].toString(), ), autoplay: true, ); }
My dispose method:
void dispose() {
    _playerEventSubs?.cancel();
    Wakelock.disable();
    _meeduPlayerController.dispose();
    super.dispose();
  }

Thanks for you feedback. I will try to reproduce the issue, also make sure that each route has an unique MeeduPlayerController and before call Navigator.pushReplacementNamed() you must dispose the MeeduPlayerController like this

Future<void> videoDispose()async{
  if(_meeduPlayerController!=null){
    _playerEventSubs?.cancel();
    Wakelock.disable();
    await   _meeduPlayerController.dispose();
   _meeduPlayerController = null;
 }

}

goTo ()async{
 await  this.videoDispose();
Navigator.pushReplacementNamed(context,'your-route);
}

@override
void dispose() {
    this.videoDispose();
    super.dispose();
 }

If you can provide your code to replicate the issue that will be great

First of all thanks for this amazing player. Recently i replaced Chewie with Meedu player because I liked this interface/UI. But I am facing one problem with this player. I have a list of routes on each route there is a video. The first route's video plays without any problem but as soon as i do Navigator.pushReplacementNamed() to any route the video player gives error.
Upon trying to debug i found that dispose() method of previous route is being called late after initState() of new route which means the playerController is being disposed after new route is opened so on new route it gives the red error (screenshot attached below). For now sadly i need to move back to Chewie because it working fine in this same scenario. Please fix this issue if possible...
A VideoPlayerController was used after being disposed

My init method:
_init() { _meeduPlayerController.setDataSource( DataSource( type: DataSourceType.network, source: optedVideo['video'].toString(), ), autoplay: true, ); }
My dispose method:
void dispose() {
    _playerEventSubs?.cancel();
    Wakelock.disable();
    _meeduPlayerController.dispose();
    super.dispose();
  }

Thanks for you feedback. I will try to reproduce the issue, also make sure that each route has an unique MeeduPlayerController and before call Navigator.pushReplacementNamed() you must dispose the MeeduPlayerController like this
Future<void> videoDispose()async{
  if(_meeduPlayerController!=null){
    _playerEventSubs?.cancel();
    Wakelock.disable();
    await   _meeduPlayerController.dispose();
   _meeduPlayerController = null;
 }

}

goTo ()async{
 await  this.videoDispose();
Navigator.pushReplacementNamed(context,'your-route);
}

@override
void dispose() {
    this.videoDispose();
    super.dispose();
 }

If you can provide your code to replicate the issue that will be great

Hi,
I have tried everything including your suggested workaround but it doesn't work. My code is very simple.
`@override
void initState() {
super.initState();
log("new player route opened");
_getItems(); //Firebase database call
_playerEventSubs = _meeduPlayerController.onPlayerStatusChanged.listen(
  (PlayerStatus status) {
    if (status == PlayerStatus.playing) {
      Wakelock.enable();
    } else {
      Wakelock.disable();
    }
  },
);

WidgetsBinding.instance.addPostFrameCallback((_) {
  _init();
});

}
_init() async {
await _meeduPlayerController.setDataSource(
DataSource(
type: DataSourceType.network,
source: optedVideo['video'].toString(),
),
autoplay: true,
);
}
@override
void dispose() {
this.videoDispose();
super.dispose();
}
`
The problem seems to be something to do with how MeeduController disposes itself when controller.dispose is called.
Look at this log, the dispose event is being called late after new screen is opened.

First of all thanks for this amazing player. Recently i replaced Chewie with Meedu player because I liked this interface/UI. But I am facing one problem with this player. I have a list of routes on each route there is a video. The first route's video plays without any problem but as soon as i do Navigator.pushReplacementNamed() to any route the video player gives error.
Upon trying to debug i found that dispose() method of previous route is being called late after initState() of new route which means the playerController is being disposed after new route is opened so on new route it gives the red error (screenshot attached below). For now sadly i need to move back to Chewie because it working fine in this same scenario. Please fix this issue if possible...
A VideoPlayerController was used after being disposed

My init method:
_init() { _meeduPlayerController.setDataSource( DataSource( type: DataSourceType.network, source: optedVideo['video'].toString(), ), autoplay: true, ); }
My dispose method:
void dispose() {
    _playerEventSubs?.cancel();
    Wakelock.disable();
    _meeduPlayerController.dispose();
    super.dispose();
  }

Thanks for you feedback. I will try to reproduce the issue, also make sure that each route has an unique MeeduPlayerController and before call Navigator.pushReplacementNamed() you must dispose the MeeduPlayerController like this
Future<void> videoDispose()async{
  if(_meeduPlayerController!=null){
    _playerEventSubs?.cancel();
    Wakelock.disable();
    await   _meeduPlayerController.dispose();
   _meeduPlayerController = null;
 }

}

goTo ()async{
 await  this.videoDispose();
Navigator.pushReplacementNamed(context,'your-route);
}

@override
void dispose() {
    this.videoDispose();
    super.dispose();
 }

If you can provide your code to replicate the issue that will be great

Hi,
I have tried everything including your suggested workaround but it doesn't work. My code is very simple.
`@override
void initState() {
super.initState();
log("new player route opened");
_getItems(); //Firebase database call
_playerEventSubs = _meeduPlayerController.onPlayerStatusChanged.listen(
  (PlayerStatus status) {
    if (status == PlayerStatus.playing) {
      Wakelock.enable();
    } else {
      Wakelock.disable();
    }
  },
);

WidgetsBinding.instance.addPostFrameCallback((_) {
  _init();
});

}
_init() async {
await _meeduPlayerController.setDataSource(
DataSource(
type: DataSourceType.network,
source: optedVideo['video'].toString(),
),
autoplay: true,
);
}
@override
void dispose() {
this.videoDispose();
super.dispose();
}
`
The problem seems to be something to do with how MeeduController disposes itself when controller.dispose is called.
Look at this log, the dispose event is being called late after new screen is opened (this happens even after implementing ur suggestion).

Great thanks please update to meedu_player: ^3.3.3 and check if the problem persists

Thank you so much the problem is fixed.


Testbench fails on fresh checkout of dev?

@rdaly525 I fetched the upstream of coreir, checked out dev and tried to build the testbench with a new floating point test, but when I did make test I got a testbench failure. The output is below:
bash-3.2$ make test -j
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C src dylib
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C passes
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C analysis
make[3]: Nothing to be done for `all'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C transform
make[3]: Nothing to be done for `all'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C ir dylib
make[2]: Nothing to be done for `dylib'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C simulator dylib
make[2]: Nothing to be done for `dylib'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C coreir-c dylib
make[2]: Nothing to be done for `dylib'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C libs dylib
make[2]: Nothing to be done for `dylib'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C tests
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C unit
make[2]: Nothing to be done for `all'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C unit-c
make[2]: Nothing to be done for `all'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C ext
make[2]: Nothing to be done for `all'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C float
make[2]: Nothing to be done for `all'.
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C simulator
Makefile:23: warning: overriding commands for target `build/simtests'
Makefile:16: warning: ignoring old commands for target `build/simtests'
make[2]: Nothing to be done for `all'.
cd magma/inline && ls && ./run_tests.sh
conftest.py			run_tests.sh			test_const.v			test_simple_top.json		test_two_ops.json
gold				test_const.json			test_inline_operators.py	test_simple_top.v		test_two_ops.v
coreir.cpp:186 Running Runningvpasses
Numargs=1
In Run Generators
Done running generators
Numargs=1
Numargs=1
Numargs=1
Numargs=1
Numargs=2
Numargs=1
Numargs=2
Creating verilog for coreir.add
Creating verilog for global.Top
coreir.cpp:192 Running vpasses
coreir.cpp:228 Modified?: No
test_simple_top.v gold/test_simple_top.v differ: char 1, line 1
coreir.cpp:186 Running Runningvpasses
Numargs=1
In Run Generators
Done running generators
Numargs=1
Numargs=1
Numargs=1
Numargs=1
Numargs=2
Numargs=1
Numargs=2
Creating verilog for corebit.const
Creating verilog for coreir.add
Creating verilog for coreir.not
Creating verilog for global.Add8_cin
Creating verilog for global.Sub8
Creating verilog for global.test_two_ops
coreir.cpp:192 Running vpasses
coreir.cpp:228 Modified?: No
test_two_ops.v gold/test_two_ops.v differ: char 1, line 1
coreir.cpp:186 Running Runningvpasses
Numargs=1
In Run Generators
Done running generators
Numargs=1
Numargs=1
Numargs=1
Numargs=1
Numargs=2
Numargs=1
Numargs=2
Creating verilog for coreir.add
Creating verilog for coreir.const
Creating verilog for coreir.mul
Creating verilog for global.test_const
coreir.cpp:192 Running vpasses
coreir.cpp:228 Modified?: No
test_const.v gold/test_const.v differ: char 1, line 1
make[1]: *** [all] Error 1
make: *** [test] Error 2

Any idea whats wrong?

I cannot reproduce.
>cd coreir
>git checkout dev
>get pull
>make clean; make uninstall;
>make -j
>make test

This seems to pass for me.


backport: v3.7: dts: arm: st: stm32h5: fix spi 1-3 clocks

Backport issue to get https://github.com/zephyrproject-rtos/zephyr/pull/77923 backported on V3.7
Describe the bug
The STM32 SPI driver, spi_ll_stm32.c, reads the clock frequency via clock_control_get_rate(). The first clocks index is used as subsystem argument if there is no second index, but this is not the source clock for SPI 1, 2, and 3.
This causes the prescaler value calculation to be incorrect, resulting in a frequency potentially above the spi-max-frequency value.
Required fix
Add clock source for SPI instances 1, 2 and 3, that matches the default clock configuration register reset value, which resolves the issue.

Closing as PR is merged.


Fix an incorrect auto-correct for Style/ClassMethodsDefinitions

This PR fixes the following incorrect auto-correct for Style/ClassMethodsDefinitions when defining class methods with class << self and there is no blank line between method definition and attribute accessor.
% cat example.rb
class A
  class << self
    def three
    end
    attr_reader :two
  end
end

% bundle exec rubocop --only Style/ClassMethodsDefinitions -a
(snip)

Inspecting 1 file
C

Offenses:

example.rb:2:3: C: [Corrected] Style/ClassMethodsDefinitions: Do not
define public methods within class << self.
class << self ...
^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

Before
The syntax is broken as follows.
% cat example.rb
class A
  class << self    attr_reader :two
  end

  def self.three
  end
end

% ruby -c example.rb
example.rb:2: syntax error, unexpected local variable or method,
expecting ';' or '\n'
class << self    attr_reader :two
example.rb:7: syntax error, unexpected `end', expecting end-of-input

After
Safe auto-correction is done.
% cat example.rb
class A
  class << self
  attr_reader :two
  end

  def self.three
  end
end

NOTE: This change may leave unwanted whitespace, which can be resolved with Layout/EmptyLinesAroundClassBody. On the other hand, cannot auto-correction for syntax error, so this PR fixes the syntax error first priority.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!

Thanks!


Join engine improvements

Add Sorted-Merge-Joins
Add Group-Joins

References:
https://en.wikipedia.org/wiki/Sort-merge_join
https://link.springer.com/content/pdf/10.1007/s00778-022-00765-x.pdf
http://www.vldb.org/pvldb/vol4/p843-moerkotte.pdf

Added the info to https://github.com/crate/crate/issues/13893

Added the info to https://github.com/crate/crate/issues/13893


Validators have missing rewards

I'm looking at the rewards tab for a validator account, and it seems the rewards are missing after block 4914139/epoch 8186.
Not sure this is an implementation issue in Oasis Explorer or just with the hosted instance of Oasis Monitor...

For reference had also listed this issue on the #oasismonitor channel on the Oasis Slack...

The updates after 95f0adc946dd64f92d7a72a7ceceb36e2ac3c53f and d49a1c3cd7653d860e7bdc9e3c85087b8c0999a4 committed on Nov 4, 2021, seem to have resolved the official Oasis Monitor hosted instance.
Appreciate the fix, closing this issue...


yank does not validate yanks

anything is always yanked succesfully

By validation I think you mean that something was actually deleted? Yes, currently if you yank a non-existing shot, it's considered successful.
This needs enhancements for k8s-client too, it currently does not "report" the operations it does during shot firing.

yep


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/types-typed-ast-feedstock#4.


[Feature Request] Drag resource pack between available and selected

Being able to drag the resource packs in selected is helpful but i feel like it would help greatly to the utility if you could drag resource packs between available and selected as well.

Yea I have already had requests for this. Unfortunately I'm not quite sure how I would implement it as the available packs list is ordered (not quite sure how) by the vanilla game and the selected packs has a specific order. If you have any ideas about how to do that then I would love to hear them and hopefully speed up the process to adding this feature.

FYI: there was a discussion in my discord server about it but we never figured out how it was going to work

This method requires overriding the Resourcepacks button and pointing to a new GUI

I guess doing a complete remake of the resource pack screen would allow me to implement cross-disable/enabled list dragging without bodging into the vanilla resource pack menu


POST arguments should support arrays as well.

// MyController.hx
@:route(POST, "/create")
public function create(args:{name:String, groups:Array<String>})
{
  //...
}

Currently the above code fails as Array<String> is not supported as a kind of POST arguments. However, it is possible to pass an array of values from an <select> element in html
<select id="groups" name="groups" multiple>
  <option value="1">Group 1</option>
  <option value="2">Group 2</option>
  <option value="3">Group 3</option>
</select>

PR created for this https://github.com/ufront/ufront-mvc/pull/13


letting the user finish input before field adjust - so that decimal i…

…s read

Let's discuss later.


Instructions on train and inference.

First of all very nice work.
It would be very nice if you add minimum code/commands to train your model or do inference on it.
It will help the fellow community.

You can try the following for training.
python $ROOT/train_net.py \
  --num-gpus 8 \
  --config-file PATH/configs/deform_detr.yaml

For inference add --eval-only

You can try the following for training.
python $ROOT/train_net.py \
  --num-gpus 8 \
  --config-file PATH/configs/deform_detr.yaml

For inference add --eval-only

You can try the following for training.
python $ROOT/train_net.py \
  --num-gpus 8 \
  --config-file PATH/configs/deform_detr.yaml

For inference add --eval-only

Thanks is it possible to shared the trained model? and way to load it.


Short solution needed: "Using retry_on_timeout in Redis" (python-redis)

Please help us write most modern and shortest code solution for this issue:
Using retry_on_timeout in Redis (technology: python-redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Using retry_on_timeout in Redis


Fix libpng-sys benchmark.

Fixes #7.
Maybe use row_stride: 0 (see comments) for a safer implementation, because I have not observed any benefits speed-wise.
I have not updated the table in the README, because I suppose these benchmarks were run on your system.

@FrankenApps thanks!  I'll work on updating the benchmarks in the README.


[DROOLS-6730] move drools-static from kogito to drools

JIRA: https://issues.redhat.com/browse/DROOLS-6730
Related PRs:
https://github.com/kiegroup/drools/pull/4052
https://github.com/kiegroup/kogito-runtimes/pull/1763
https://github.com/kiegroup/optaplanner/pull/1700

The (build) kogito-apps check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.


QPPSF-8611, Terraform upgrade to version 15

Information

Fixes #_.
QPPSF-8611

Changes proposed in this PR:

Upgraded terraform required_version from 0.14.11 to 0.15.5
Upgraded aws provider version from 3.65.0 to 3.67.0
Ran terraform init and plan in all Environments dir

Checklist

[ ] All JUnit tests pass (mvn clean verify).
[ ] New unit tests written to cover new functionality.
[ ] Added and updated JavaDocs for non-test classes and methods.
[ ] No local design debt. Do you feel that something is "ugly" after your changes?
[ ] Updated documentation (README.md, etc.) depending if the changes require it.

DEV:
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:

create
~ update in-place

Terraform will perform the following actions:
aws_s3_bucket.certs_bucket will be updated in-place
~ resource "aws_s3_bucket" "certs_bucket" {
id                          = "qppsf-conversion-tool-artifacts-ssl-bucket"
tags                        = {
"Name"            = "qppsf-ct-s3-certs-bucket"
"application"     = "ConversionTool"
"git-origin"      = "https://github.com/CMSgov/qpp-conversion-tool.git"
"owner"           = "qppar-final-scoring"
"pagerduty-email" =<EMAIL_ADDRESS>"project"         = "qppsf-ct"
"sensitivity"     = "PII/PHI"
"terraform"       = "true"
}
# (10 unchanged attributes hidden)
  ~ lifecycle_rule {
        id                                     = "default-lifecycle"
        tags                                   = {}
        # (2 unchanged attributes hidden)

      - expiration {
          - days                         = 0 -> null
          - expired_object_delete_marker = false -> null
        }
    }

    # (2 unchanged blocks hidden)
}

module.conversion-tool.aws_security_group_rule.ct-ingress-from-https-elb-to-ui will be created

resource "aws_security_group_rule" "ct-ingress-from-https-elb-to-ui" {

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-030ae9a65cdad1954"
self                     = false
source_security_group_id = "sg-0377d36214f7db48c"
to_port                  = 8443
type                     = "ingress"
}

Plan: 1 to add, 1 to change, 0 to destroy.
IMPL:
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:

create

Terraform will perform the following actions:
module.conversion-tool.aws_security_group_rule.ct-ingress-from-https-elb-to-ui will be created

resource "aws_security_group_rule" "ct-ingress-from-https-elb-to-ui" {

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-04460af49075eec77"
self                     = false
source_security_group_id = "sg-013c1f26005939b02"
to_port                  = 8443
type                     = "ingress"
}

Plan: 1 to add, 0 to change, 0 to destroy.
DEV-PRE:
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:

create

Terraform will perform the following actions:
module.conversion-tool.aws_security_group_rule.ct-ingress-from-https-elb-to-ui will be created

resource "aws_security_group_rule" "ct-ingress-from-https-elb-to-ui" {

from_port                = 443
id                       = (known after apply)
protocol                 = "tcp"
security_group_id        = "sg-07205d6051519c30a"
self                     = false
source_security_group_id = "sg-0dbc84bd77b8b70e5"
to_port                  = 8443
type                     = "ingress"
}

Plan: 1 to add, 0 to change, 0 to destroy.
PROD:
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
module.conversion-tool.aws_security_group.ct_app will be updated in-place
~ resource "aws_security_group" "ct_app" {
id                     = "sg-0e171ff1419a3a8ce"
~ ingress                = [
- {
- cidr_blocks      = []
- description      = ""
- from_port        = 443
- ipv6_cidr_blocks = []
- prefix_list_ids  = []
- protocol         = "tcp"
- security_groups  = [
- "sg-0ddf985740c094a69",
]
- self             = false
- to_port          = 8443
},
- {
- cidr_blocks      = []
- description      = ""
- from_port        = 8443
- ipv6_cidr_blocks = []
- prefix_list_ids  = []
- protocol         = "tcp"
- security_groups  = [
- "sg-0ddf985740c094a69",
]
- self             = false
- to_port          = 8443
},
+ {
+ cidr_blocks      = []
+ description      = null
+ from_port        = 8443
+ ipv6_cidr_blocks = []
+ prefix_list_ids  = []
+ protocol         = "tcp"
+ security_groups  = [
+ "sg-0ddf985740c094a69",
]
+ self             = false
+ to_port          = 8443
},
]
name                   = "conversion-tool-app-prod"
tags                   = {
"Name" = "conversion-tool-app-prod"
}
# (7 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.


txn: Fix wrong constraint check when txn is overlapping (#5128)

Signed-off-by: MyonKeminta<EMAIL_ADDRESS>
What have you changed? (mandatory)
Cherry picks #5128, which fixes a bug that constraint check at insertion may be incorrect when pessimistic transaction is enabled.
What are the type of the changes? (mandatory)

Bug fix (change which fixes an issue)

How has this PR been tested? (mandatory)
By CI
Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No

/run-integration-ddl-test
/integration-compatibility-test

/run-integration-compatibility-test


Silence systemctl messages

systemctl status can be noisy if the log has been rotated, showing this message:

Warning: The unit file, source configuration file or drop-ins of
podman.socket changed on disk. Run 'systemctl --user daemon-reload'
to reload units.

This can be especially problematic in --quiet mode. This patch fixes that by redirecting stderr of the systemctl call used to get the running state of podman to /dev/null.

Sure, why not, can do both, will update.


Make pytest treat warnings as errors

Warnings are usually a sign of something that can be improved or even wrong, like tasks not being properly awaited or cancelled, so it's a good idea to treat them as errors to avoid them getting unnoticed.
This PR also moves pytest options to the pyproject.toml files, so they are easier to change and more flexible.

Mmm, the deprecations are annoying. It would be good to have them as errors too normally, I guess. Not sure. It can be sometimes annoying when one is not planning to upgrade in the short term.
If we wanted to not treat warnings as errors only in the pytest_min session, we could also pass the default::* flags in the nox session.
But I guess for now this is the less problematic approach and it is a big improvement over the previous status quo, so we can go one step at the time.


Updated warning about TLS certificates

"Self-signed or expired certificates will not be accepted." Updating doc to reflect potential failures customers may experience with the new event system rollout.
Description of the change:
Reason for the change:
Link to original source:

Closes #

@krischoi07 this is a really good point. thanks for the update!!

Hello @krischoi07,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Upgrade cargo-maven2-plugin from 1.5.0 to 1.6.2

Test component - used for controlling of application servers during integration tests.

@psiroky Can you please look on this?

This should be fine I believe, let's just run the full build to be sure.
Jenkins execute full downstream build

The failure may be related:
java.lang.RuntimeException: java.lang.NullPointerException
	at org.codehaus.cargo.container.internal.http.HttpConnection$1.getPasswordAuthentication(HttpConnection.java:136)
	at java.net.Authenticator.requestPasswordAuthentication(Authenticator.java:317)
	at sun.net.www.protocol.http.HttpURLConnection$1.run(HttpURLConnection.java:453)
	at sun.net.www.protocol.http.HttpURLConnection$1.run(HttpURLConnection.java:448)
	at java.security.AccessController.doPrivileged(Native Method)
	at sun.net.www.protocol.http.HttpURLConnection.privilegedRequestPasswordAuthentication(HttpURLConnection.java:447)
	at sun.net.www.protocol.http.HttpURLConnection.getServerAuthentication(HttpURLConnection.java:2429)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1719)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at org.codehaus.cargo.container.internal.http.HttpConnection.connect(HttpConnection.java:258)
	at org.codehaus.cargo.container.internal.http.HttpConnection.post(HttpConnection.java:154)
	at org.codehaus.cargo.container.wildfly.internal.AbstractWildFlyRemoteDeployer.undeployDeployable(AbstractWildFlyRemoteDeployer.java:170)
	at org.codehaus.cargo.container.wildfly.internal.AbstractWildFlyRemoteDeployer.undeploy(AbstractWildFlyRemoteDeployer.java:106)
	at org.kie.server.integrationtests.controller.ContainerRemoteController.undeployWarFile(ContainerRemoteController.java:59)

Yes, that is related to upgrade of Cargo remote deployment for WildFly. Already preparing fix.

Jenkins execute full downstream build

@sutaakar @psiroky to me these three failures are completely not related to this change, wdyt?

@mswiderski I agree

Yeah, the failures does not seem to be related (but we need to make sure they get fixed or at least looked at).

@psiroky Do you know who to ask to check these issues?

@sutaakar I am not 100 % sure. I think for now it should be enough to e-mail bsig or create JIRAs for these and let project leads distribute the issues to specific people.

Created respective JIRAs [1] [2]
[1] https://issues.jboss.org/browse/JBPM-5576
[2] https://issues.jboss.org/browse/JBPM-5577

I am merging this since the test failures are really not related and we don't even run the full downstream build regularly, so from that point of view, there is no need to hold off the PR any longer.


Ability to copy python objects from the UI for inputs and result files.

Current scenario:

The input and results value for both electron and lattice will be shown as a plain string on the GUI.

Expectation:

The input and results file will now have a copy button next to the string representation. This will allow the users to copy the byte value (python object) corresponding to the input/result in the below format.
#----- Copied----- import pickle import base64 pickle.loads((base64.b64decode(TransportableObject._object.encode("utf-8"))))

cc : @santoshkumarradha

PS : @Prasy12  if you are anyway using python backend you can potentially simplify this by doing tthis a=(base64.b64decode(TransportableObject._object.encode("utf-8"))) and copying
import pickle
pickle.loads("whatever_a_is")

as this reduces the complexity a bit more from user side

Hi @Prasy12, this is an interesting feature. Would the encoded object be decoded when it is saved to the user's clipboard? If so, in what Python environment would the decoding take place, and how would it be accessed from the web browser?

@cjao The feature would look something like this.
screen-capture (29).webm
We will be giving them a 2 liner when they give a copy button and when they run the decoding will happen. It is just the pure python code and they can run it in any python environment that they desire.

@cjao The feature would look something like this. screen-capture (29).webm
We will be giving them a 2 liner when they give a copy button and when they run the decoding will happen. It is just the pure python code and they can run it in any python environment that they desire.

A small correction they can run it on any environment where the dependencies are installed to unpickle it. The expectation is that the ability to unpickle the object is assumed.


Protocol handler "web+blockstack:" versus "blockstack:" problems on Linux

Blockstack portal registers the web+blockstack: protocol handler in ApiSettingsPage.js:76
However, blockstack.js attempts to use the blockstack: protocol handler. This isn't registered in the browser, so it doesn't work, redirecting users to the https://blockstack.org/auth page.
If blockstack.js switched to using the web+blockstack protocol handler, everything works correctly. I'm not sure where to report the issue (here, or in blockstack-portal)?
The issue #205 may be related.

The ability to register web+blockstack: in browser shouldn't be available anymore.


Update LoginBox.java

This is related to issue #5  Windows doesn't like OpenSSL for whatever reason. I figure if you're using Windows though, you aren't concerned about security.


Creating VM using Managed Disk Name and Fixing Query Bugs

Updated the documentation to use the Managed Disk Name.
Also fixed Query Bug. It should not include the single quotes for the query to work properly.
Provided the name of the disk to be consistent with the previous cmdlets as well.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks for those changes, they look good.
This can be merged, please #sign-off

@HarvestingClouds : Thanks for your contribution to the Azure documentation! The author, @iainfoulds, has been notified to review your proposed change.


Add support for processing instructions and comments

Currently xmlToJSON only support element, cdata, and text nodes.

This is related to issue #21 .  Without significantly altering the format of the JSON object, there is not a simple approach to maintaining ordering for same-key nodes that are interspersed with other nodes.  Without strict ordering, context is lost for items such as comments and processing instructions.  And in the end, you really should just parse the xml if you need that level of fidelity :)

https://github.com/javadev/xml-to-json will help


Fixed dialog bugs

Fixed a problem with editing links that are not CMS plugins
Fixed a problem with prefilling fields when editing CMS plugins

LGTM

Coverage remained the same at 82.486% when pulling 0f1421bebd64cee9abccc2c16b56f82350d677d1 on vxsx:bugfix/editing-links into d6dd84c3b5e5574b9b0c2d19bcd15d22cdf19092 on divio:master.


"Reset Capitalization" in "Auto-edit Lyrics" changes all standalone and contraction "I" to "i"

I am using 1.6.
When using Reset Capitalization, lyrics such as this:
Because there's no place that I'd be without you
We know it's too far to discard the life I once knew
Will be set to this:
Because there's no place that i'd be without you
We know it's too far to discard the life i once knew
The "I", should stay capitalized, along with all its personal pronoun contractions such as I'm, I've, I'll and I'd.

Duplicate of  #83


func.apply in _.once is breaking my asynchronous validations

Hi. I've been working on a Coffeescript class to handle Judge validations. It is based off a Javscript I found here. It's throwing errors related to Underscore.js.
When I instantiate my class judgment = new JudgeJudy({form: $("#new_suggestion")}) I'm seeing this error in the console:
Uncaught TypeError: func.apply is not a function

and it references line 683 in the Underscore.js library.

Here's that Coffeescript:
# This class was inspired by code found
# here: http://blog.bananacoding.com/blog/client-side-form-validation-using-judge-gem

@JudgeJudy = class JudgeJudy
  constructor: (@options)->
    @form = @options.form
    @validate_form()

  valid: (element, deferred)->
    $(element).removeClass('error').addClass('valid')
    deferred.resolve()

  invalid: (element, deferred)->
    $(element).removeClass('valid').addClass('error')
    deferred.reject()

  validate_form: ->
    that = @
    @form.on 'submit', (event) ->
      event.preventDefault()
      $('.error_container').empty()

      defers = []

      that.form.find('.form-control').each (index, element)->
        defers.push(that.validate_input_async(element))

      $.when.apply($, defers).done ->
        that.form.unbind 'submit'
        that.form.submit()

  validate_input_async: (element)->
    deferred = new $.Deferred()

    q = judge.validate element,
      valid:
        @valid element, deferred
      invalid:
        @invalid element, deferred

    deferred.resolve() if q.validations.length
    deferred

I was poking around the Judge repository and noticed that the Underscore version in use is 1.4.4 but Underscore.js is currently at 1.8.3. I'm not sure if it's my code, Underscore, or something else but I'm wondering how you would recommend I update this Underscore library to the latest version to see if that resolve my issue.
I struggled for a whole day thinking it was my call to apply on $.when that was throwing the error but then I got smart and actually looked at the error message closely. :smile_cat:
If you've got any feedback or ideas I'm all ears!!

So, I dropped in the underscore-rails gem and ... this error cropped up again but on a different method (_.before), same code (memo = func.apply(this, arguments);). Looks like I'll need to take this up with the Underscore repository. If you've got any input I'd love to hear it but I'd also understand if you wanted to close this issue since it doesn't look to be an actual issue on Judge.

Yeah, looks like it may be an issue with the coffeescript or dependency order. Unfortunately I'm not great with coffeescript so I'm not much help here.
Since this isn't an issue with the gem I'm going to close this one out.

After posting over in the Underscore repo it was pointed out to me that I wasn't properly creating the callbacks as methods. I've been staring at this code by myself for so long I'd totally missed it.  In case anyone needs to know, this is the fix that did it.
q = judge.validate element,
      valid: (element)=>
        @valid element, deferred
      invalid: (element)=>
        @invalid element, deferred


Add compression summary as a table in PR body (fixes #102)

see demo https://github.com/dabutvin/test/pull/8#issue-204579859


SAK-30133 Added IS_VOLATILE to Quartz tables.

 Doh.


[Identity] [External] MSAL should allow canceling DeviceCode authentications

While the canceling option of the DeviceCode authentication method exists, we weren't able to use it. The MSAL team is aware and has made some updates here: https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/3229
Once that is resolved, please update our source code and resolve this issue.

MSAL has a PR here fixing the issue: https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/3229


Calculator is updated as plateform independent

To make calculator as platform independent , I modified calculator code .

Thanks @rakeshsagalagatte


Fix khr-animation-pointer with uv transforms

https://forum.babylonjs.com/t/khr-animation-pointer-with-uv-transforms/49081/28

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14964/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14964/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14964/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14964/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14964/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14964/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14964/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14964/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14964/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14964/merge/testResults/webgl2playwright/index.html


Limitation on validating managed Certificate and custom domain for container apps with only internal Ingress

This issue is a:

[x] bug report -> please search issues before submitting
[x] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
I've created a container apps with ingress through an internal vnet. at the time of assigning the custom domain, it can't validate the domain name and after spending 2 days of investigating the issue, it turns out there is a limitation in container apps and not publicly available apps.
I just wanted to confirm this first and also know the reason behind this as we are targeting to move all of our services from App Services, AKS, etc to this and this type of managed certificate is already available in all of the environments in the same way so I appreciate if you help me to understand this better. From my point of view, it more like a bug to me rather than a lack of feature however I will appreciate if there is a better clarification on this.

Hi @vinisoto
That is correct. We are still in a hybrid environment that our DNS server is maintained in our AD on premises and we have DNS forwarder to forward our DNS queries through our zones in our Azure subscriptions.
The Managed Environment and apps are hosted in Azure and are attached to a private VNet which has ingress traffic to/from our on premises environment.
The issue that we are facing is to enable custom domain we need certificate and manage certificate for ACA seems to have a requirement for publicly available apps. Use of the managed certificate make the process much easier for us and we already have the same configuration both for App Services and AKS so it is not clear for me what the problem is with ACA unless that is a missing feature to to the timing.
We already implementing a workaround to use or own certificate (dedicated or wildcard one) and it is working but it is nicer and more practical if we have the chance of using managed certificate

Unfortunately, this is not something that we are able to support in currently. Our control plane needs to be able to reach your DNS to validate ownership and the certificate issuer (DigiCert) needs to be able to reach your application over the internet (to validate root/APEX domains)


forge coverage report does not show modifiers that revert

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (7226aa06b 2024-07-02T23:13:43.699201000Z)
What command(s) is the bug in?
forge coverage
Operating System
macOS (Apple Silicon)
Describe the bug
I have the following contract and test:
Contract A:
pragma solidity ^0.8.24;

contract ContractA {
    error CustomError();

    modifier withValidNumber(uint256 number) {
        if (number > 1e18) {
             revert CustomError(); // this line is never hit by `forge coverage`
        }
        _;
    }

    function mockWithValidNumber(uint256 number) external view withValidNumber(number) {
        // Do Nothing
    }
}

Test of Contract A
pragma solidity ^0.8.24;

import {ContractA} from "ContractA.sol";

contract ContractATest is Test{
    function testInvalidNumber() public {
        ContractA contract = new ContractA();
        vm.expectRevert(ContractA.CustomError.selector);
        contract.mockWithValidNumber(1.5e18);
    }
}

The test testInvalidNumber passes, but in the forge coverage the line with revert CustomError(); is never hit.

hm, I cannot reproduce the issue, see below

I used
forge coverage --mt testInvalidNumber --report lcov
genhtml lcov.info -o report --branch-coverage && firefox report/index.html

with a slightly changed test (imported ds-test and renamed contract var)
pragma solidity ^0.8.24;

import {Test} from "forge-std/Test.sol";

import {ContractA} from "src/ContractA.sol";

contract ContractATest is Test {
    function testInvalidNumber() public {
        ContractA a = new ContractA();
        vm.expectRevert(ContractA.CustomError.selector);
        a.mockWithValidNumber(1.5e18);
    }
}

Are you sure forge coverage --mt testInvalidNumber --report lcov does not yield any test failure?

ping @joaobrunoah can you pls check comment above? thanks!

@grandizzy, you're correct. I tested it here, and it works with ContractA. I have a scenario in which it does not work, but I couldn't isolate the reason. It may be related to my code somehow.
For now, I think the best alternative is to close this issue. If I find the reason and it's a forge bug, I can reopen this or open another ticket.


[SPARK-37478][SQL][TESTS][FOLLOWUP] Unify v1 and v2 DROP NAMESPACE error

What changes were proposed in this pull request?
According to #cmt, unify the error of v1, v2 and hive external catalog in DROP NAMESPACE tests.
Why are the changes needed?
Currently, v1 and hive external catalog command throw AnalysisException, while v2 command throws SparkException. The error messages of v1 and hive catalog are also completely different from v2.
So this PR is for unifying those errors to AnalysisException. The error message will have one difference between v1/hive and v2: Cannot drop a non-empty database: ... vs Cannot drop a non-empty namespace: ...
Does this PR introduce any user-facing change?
No
How was this patch tested?
v1/v2 and Hive v1 DropNamespaceSuite:
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *DropNamespaceSuite"

cc @cloud-fan @huaxingao. FYI !

Test build #146548 has started for PR 35007 at commit e1793be.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51023/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51023/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51023/

Test build #146548 has finished for PR 35007 at commit e1793be.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146548/

Test build #146556 has started for PR 35007 at commit a881d22.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51031/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51031/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51031/

Test build #146556 has finished for PR 35007 at commit a881d22.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146556/

Please take a look if you have time @cloud-fan, @huaxingao . Many thanks!

thanks, merging to master!


Sending song to CHAT will stop the radio stream

Evertytime a song is sent to the CHAT, it start to play the song even if the vc was started using a STREAM_URL before!

Fixed


Issue in NTMapPos for iPhone X

CartoMobileSDK (4.1.2)
Swift 4
In Our project we are taking the NTMapPos at the Zoom Level of 25meters, When using iPhone X we are sending the mapview and by using the below code we are getting the values, But When converting the NTMapPos to coordinates and tried to plot on Google maps, the topRight, bottomRight, bottomLeft points do not match what we see in Carto map in Phone and Google maps.
Do we need to send any Zoom value or others?

func getBoundingBoxInMapPos(mapView:NTMapView)->[NTMapPos]{
    let width: Float = Float(mapView.frame.width)
    let height: Float = Float(mapView.frame.height)

    let topLeft :NTMapPos = mapView.screen(toMap: NTScreenPos.init(x: 0, y: 0))
    let topRight :NTMapPos = mapView.screen(toMap: NTScreenPos.init(x: width, y: 0))
    let bottomRight :NTMapPos = mapView.screen(toMap: NTScreenPos.init(x: width, y: height))
    let bottomLeft :NTMapPos = mapView.screen(toMap: NTScreenPos.init(x: 0, y: height))
    return [topLeft,topRight,bottomRight,bottomLeft,topLeft]
}

What numbers do you exactly get? you should get internal coordinates, which needs to be converted to Wgs84 to get latitude and longitude what Google Maps expects. Something like:
let projection = mapView.getOptions().getBaseProjection()
let topLeftWgs = projection.toWgs84(topLeft)!
let topRight Wgs = projection.toWgs84(topRight)!
...

@jaakla
The coordinates i am getting is
topLeft   [52333.5533661467,6752706.87406307]
topRight [52539.1839352835,6752706.87406307]
bottomRight  [52539.1839352835,6752364.46108686]
bottomleft [52333.5533661467,6752364.46108686]
Later we are converting these points using a website and tried to Plot on the Google maps,
Below is the URL where we transform the topRight points
https://epsg.io/transform#s_srs=3857&t_srs=4326&x=52539.1839353&y=6752706.8740631
I am attaching the screen shot of in which location we get the points and On the map where it is Plotted.
If you see it The black lines on the image The topLeft spotted the Black line but it is plotted much before the Black line.
If you have doubt in location you can see a street name "Legg Street" in phone and google maps.
Can you please help me of it.

From where do you get that 52333.5533661467,6752706.87406307 is in EPSG3857, is it in documentation somewhere? If it is, then this is not correct, these are internal coordinates which are not defined in any specific projection, actually in different SDK versions they may be different.
You should always use SDK's EPSG3857 class (you can get it from mapView as options.baseProjection class, or just create new class) and method projection.toWgs84(MapPos) of this to convert the coordinates to the 4326 coordinates which are good for Google maps and any other tools. Same way, if you have your data in lat/long then you shoudl use fromWgs84() method of the projection to convert them.

I got the Points from below code.
In the docs we have option for getting the screen positions, So the ScreenPostion cant give the exact postions?
    let width: Float = Float(mapView.frame.width)
    let height: Float = Float(mapView.frame.height)

    let topRight :NTMapPos = mapView.screen(toMap: NTScreenPos.init(x: width, y: 0))

The problem is that you do some conversions from internal coordinates to WGS84 (lat/long) outside SDK, assuming they are in some projection, you should never do this. You should convert coordinates inside SDK to Wgs84, and then use these values.


Update MarkovChain Tests

To support new functions, and clean up some old stuff.

Will you add JLD to require and retry?

Excellent! thank you!


Re-enable e2e tests for pages/extensions/extensions.spec.ts

Is your feature request related to a problem? Please describe.

With the migration of the ui-plugin-examples to Vue3, we should be in the position to re-enable e2e tests for pages/extensions/extensions.spec.ts that were being skipped
Describe the solution you'd like

re-enable e2e tests for pages/extensions/extensions.spec.ts that were being skipped
Describe alternatives you've considered

Additional context

/backport release-2.10

/backport release-2.10


Footnotes Processed Improperly for Beamer Output

When attempting to use footnotes for beamer output, they are rendered incorrectly in the final PDF.  Footnotes are rendered correctly when using the default beamer template or when using pandoc-latex-template to output non-beamer pdfs.
Modifying the footnotes-pretty and footnotes-disable-backlinks options did not affect this behavior.
Pandoc versions tested: pandoc 2.2.1 and <IP_ADDRESS>
Replication:

Invocation to replicate error behavior:

pandoc mfe.md -o mfe.pdf --pdf-engine=xelatex --from markdown+footnotes --to beamer --slide-level 2 --template ./pandoc-latex-template/eisvogel.tex --resource-path=. --listings

Invocation for valid result without template:

pandoc mfe.md -o mfe-default.pdf --pdf-engine=xelatex --from markdown+footnotes --to beamer --slide-level 2  --resource-path=. --listings

mfe.md
--
title: "minimal example"
author: [cesuslow]
date: "2021-01-21"
subject: "subject"
keywords: [intro]
lang: "en"
...

## A Header
- A bullet
	- A subbullet
- A bullet with a footnote[^1]

[^1]: The footnote

Resultant PDFs:
mfe.pdf
mfe-default.pdf

Thank you for reporting this issue! Unfortunately I have to inform you that Eisvogel was never really made for beamer output. I try to fix all issues and merge with the upstream template regularly, however beamer will always be inferior to the normal article output. Nonetheless, thank you for your Report. I'll leave this issue open, but it may be open for quite some time.


Fix markdown lint issues in nvm/README.md

nvm/README.md:3 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Step 1: Install developer tools"]
nvm/README.md:5 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""] nvm/README.md:5 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: ""]
nvm/README.md:7 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""] nvm/README.md:8 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Step 2: Install NVM"] nvm/README.md:10:81 MD013/line-length Line length [Expected: 80; Actual: 220] nvm/README.md:14 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Step 3: Configure your $HOME/.nvmrc file"] nvm/README.md:16 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""]
nvm/README.md:16 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: ""] nvm/README.md:23 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Step 4: Set necessary environment variables"] nvm/README.md:25 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""]
nvm/README.md:25 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: ""] nvm/README.md:31:81 MD013/line-length Line length [Expected: 80; Actual: 143] nvm/README.md:32 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: ""]
nvm/README.md:32 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
nvm/README.md:41 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Step 5: Run nvm!"]
nvm/README.md:41:19 MD026/no-trailing-punctuation Trailing punctuation in heading [Punctuation: '!']
nvm/README.md:42:81 MD013/line-length Line length [Expected: 80; Actual: 192]

Would be happy to handle this issue.


Cannot resolve localhost to an IPv6 address on ubuntu-latest (all Python versions affected)

Describe the bug
As of today I am getting the following error resolving localhost to an IP address on Ubuntu latest:
[Errno -5] No address associated with hostname

The resolving process is done via Python:
socket.getaddrinfo(...)

It affects all Python versions: 2.6, 3.5, 3.6, 3.7, 3.8 pypy2 and pypy3
This has not happened a few days ago and it also does not happen on MacOS or Windows
Area for Triage:
https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700746839#step:5:2368

Question, Bug, or Feature?:
Bug

Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[X] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
localhost is resolved to ::1 (IPv6)
Actual behavior
The following error is thrown:
[Errno -5] No address associated with hostname

https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700886122#step:5:21
Reproducible via the following Python snippet on ubuntu-latest on all available Python versions.
import socket
socket.getaddrinfo("localhost", None)

https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700886122#step:5:21

I've investigated this further and it seems like IPv6 support is simply gone: https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700860054#step:5:37
It smees to be working for IPv4, but not for IPv6 anymore.

Probably, similar to #668

Probably, similar to #668

I don't think so. As I wrote above, the problem started as of today (yesterday). It all worked fine before.

@cytopia does the same happen on Ubuntu 16? I wonder if it's related to this PR https://github.com/actions/virtual-environments/pull/881

Give me a few minutes, will add pipelines for these to try it out

Seems to be the same issue on Ubuntu 16: https://github.com/cytopia/pwncat/runs/701818515?check_suite_focus=true#step:5:22 No IPv6 support available anymore

@cytopia
Could you please test with step?
sudo bash -c "cat > /etc/hosts" << EOL
<IP_ADDRESS>       localhost
::1     localhost ip6-localhost ip6-loopback
EOL

@al-cheb is there something where I can tell it for a step to only do this on Linux?

if [ `uname` = "Linux" ]; then
sudo bash -c "cat > /etc/hosts" << EOL
<IP_ADDRESS>       localhost
::1     localhost ip6-localhost ip6-loopback
EOL
fi

Looks good so far. I can resolve it to IPv6 again. Will however also wait for the whole pipeline and report back here

@al-cheb we've started running into a very similar issue, specifically with Percy.io's image downloading functionality:
Error: getaddrinfo ENOTFOUND [foo.bar].localhost

We use .localhost as a TLD, which up until 5/22 worked just fine, but starting on 5/22 (and I believe alongside the 20200518.1 virtual env release), requests for our assets on that domain are no longer working.
I tried including your suggested change to /etc/hosts, and unfortunately still no luck. Any help here would be greatly appreciated!

Hello, @agrobbin
Could you please validate with step?
- name: revert
  run: |
        sudo ln -sf /run/systemd/resolve/stub-resolv.conf /etc/resolv.conf

@al-cheb that line did the trick!

@al-cheb is this something that will be resolved in a future virtual environment release, or should we anticipate having to include this in our Actions YAML file going forward?

@agrobbin, Sorry for the inconvenience. We are planning to revert the https://github.com/actions/virtual-environments/pull/881 PR that is the root cause of this issue. Not until we roll-out a new image with a fix you should use the temporary workaround. I will provide feedback to you when we can delete the workaround.

Sounds good, @al-cheb thanks again for all of your help! In the meantime, I'll keep an eye on these issues.

https://github.com/yidongnan/grpc-spring-boot-starter/runs/760320005?check_suite_focus=true#step:3:7
I still have this problem after deleting this patch, is there any cache here?

@yidongnan, Hello
Could you please try to test  https://github.com/actions/virtual-environments/issues/929#issuecomment-633032894 ?

@al-cheb I just confirmed that removing our patch for this issue no longer causes resolution issues. Looks like things are fixed! Thanks so much for your help.

@al-cheb Using this patch will work, I read the comment  saying that the patch removal is work. I thought the problem was fixed, but when I removed the patch, it found that it did not work.
This is my modification
https://github.com/yidongnan/grpc-spring-boot-starter/pull/367

@al-cheb I just confirmed that removing our patch for this issue no longer causes resolution issues. Looks like things are fixed! Thanks so much for your help.

@al-cheb Using this patch will work, I read the comment saying that the patch removal is work. I thought the problem was fixed, but when I removed the patch, it found that it did not work.
This is my modification
yidongnan/grpc-spring-boot-starter#367

I think we have got several issues one with resolving IPv4 localhost(revert fixed the issue) and the second one with IPv6.

Hello, @yidongnan
I can reproduce this behavior with resolving IPv6 localhost name on clean Ubuntu VMs with OS version 18.04+(Azure VM, Hyper-V). The default /etc/hosts file on Ubuntu Server 14.04+ is (e.g. for other linux distros - https://gist.github.com/ghoneycutt/e531984406b4b86ace687ea8958a6dc3#file-hosts-md):

I have created a simple test:
import java.net.InetAddress;

public class Test {
    public static void main(String[] args) throws Exception {
        InetAddress[] inetAddresses = InetAddress.getAllByName(args[0]);
        for(InetAddress inet : inetAddresses){
            System.out.println(inet);
        }
    }
}

Output:
ubuntu:~$ java -classpath . Test localhost
localhost/<IP_ADDRESS>
ubuntu:~$ java -classpath . Test ip6-localhost
ip6-localhost/0:0:0:0:0:0:0:1

Update /etc/hosts/ file and add the alias localhost for ::1:
ubuntu:~$ sed -i 's/::1 ip6-localhost ip6-loopback/::1     localhost ip6-localhost ip6-loopback/g' /etc/hosts
ubuntu:~$ java -classpath . Test localhost
localhost/<IP_ADDRESS>
localhost/0:0:0:0:0:0:0:1

We are not planning to change/update default name resolution due to unexpected behaviors for other customers.
Workaround:

Add  the alias localhost for ::1 manually to the pipeline - https://github.com/actions/virtual-environments/issues/929#issuecomment-633032894
Change localhost name to ip6-localhost or ::1 in your test
Use only <IP_ADDRESS> or ::1

We are not planning to change/update default name resolution due to unexpected behaviors for other customers.

@al-cheb Thanks for your reply,  I see that ubuntu 18.04 and 14.04 have added ::1 localhost by default, so I think it’s more appropriate to be consistent with the ubuntu official. I think that only by being consistent will no unexpected behavior happen.

Hello, @yidongnan
Fix with alias for ::1 localhost has been deployed. Could you please check from your side?

@al-cheb Looks like things are fixed! Thanks so much for your help.


Set Optional Data via Formly

I wanna set placeholder or extra optional data from formly .... [Angular 1]
I set custom value to editor.options.placeholder but its not working ... What is missing from me ? Thankx

Logs
placeholder 1 :  halo
placeholder 2 : newplaceholder

i think one issue issue is enough ...


fix: make GetRoleARN support GovCloud

GovCloud support was added in #197 / b4e7839 and #204 / 9787f11.
Taking the role as an env var was added in #208 / 396d453, which added
GetRoleARN which ignored region and, thus, broke GovCloud.
Both of these were released as v0.23.0, so no version of aws-okta
supported GovCloud.
Separately, GetRoleARN was split into a lib function and a Provider
function in #218 / e13ae0f, which left behind a code duplication TODO
and an unused Provider function.

could we get a 0.24.2 release to pick this up? https://github.com/segmentio/aws-okta/compare/v0.24.1...master

I think a release is in order but I think this might warrant a 0.25 release given that it's adding new functionality. @nickatsegment you have any issues w/ cutting v0.25.0?

Yeah, kind of on the fence on that one, but meh, minor versions are cheap

v0.25.0 is out and contains these changes.


Has anyone tested this with Redmine 4.2

Has anyone tested this plugin with 4.2?
If no one has tested, if anyone can guide me on how to make it compatible with 4.2, this could include tinkering with the redmine core, or the repo itself... please let me know.

Redmine 4.2.2
I started using the plugin on a Unicorn instance with Nginx reverse proxy.
I removed the closed() statement in grack_git_adapter.rb
It throws the following error upon authentification:
NoMethodError (private method `eof?' called for #<Unicorn::TeeInput:0x0000aaaac5cdbd68>):

plugins/redmine_git_server/lib/redmine_git_server/grack_git_adapter.rb:11:in `block in command'
plugins/redmine_git_server/lib/redmine_git_server/grack_git_adapter.rb:10:in `popen'
plugins/redmine_git_server/lib/redmine_git_server/grack_git_adapter.rb:10:in `command'

Then I removed the `eof? ' method and this is what you get  from git:
nginx proxy-error.log
2021/09/21 01:44:50 [crit] 296979#296979: *10 SSL_do_handshake() failed (SSL: error:141CF06C:SSL routines:tls_parse_ctos_key_share:bad key share) while SSL handshaking, client: <IP_ADDRESS>, server: <IP_ADDRESS>:443
2021/09/21 01:47:00 [error] 296979#296979: *11 upstream prematurely closed connection while reading response header from upstream, client: <IP_ADDRESS>, server: redmine.webelectrica.com, request: "POST /projects/bu40/repository/gong_bu40_fw/git-upload-pack HTTP/1.1", upstream: "http://<IP_ADDRESS>:3000/projects/bu40/repository/gong_bu40_fw/git-upload-pack", host: "redmine.webelectrica.com"

nginx proxy-access.log
<IP_ADDRESS> - - [21/Sep/2021:01:44:58 +0000] "GET /projects/bu40/repository/gong_bu40_fw/info/refs?service=git-upload-pack HTTP/1.1" 401 27 "-" "git/2.30.1.windows.1"
<IP_ADDRESS> - ivan [21/Sep/2021:01:44:58 +0000] "GET /projects/bu40/repository/gong_bu40_fw/info/refs?service=git-upload-pack HTTP/1.1" 401 27 "-" "git/2.30.1.windows.1"
<IP_ADDRESS> - ivan [21/Sep/2021:01:44:59 +0000] "GET /projects/bu40/repository/gong_bu40_fw/info/refs?service=git-upload-pack HTTP/1.1" 200 414 "-" "git/2.30.1.windows.1"
<IP_ADDRESS> - ivan [21/Sep/2021:01:47:00 +0000] "POST /projects/bu40/repository/gong_bu40_fw/git-upload-pack HTTP/1.1" 502 150 "-" "git/2.30.1.windows.1"

unicorn.stderr.log
E, [2021-09-21T04:47:00.608485 #5841] ERROR -- : worker=0 PID:5935 timeout (121s > 120s), killing
E, [2021-09-21T04:47:00.655277 #5841] ERROR -- : reaped #<Process::Status: pid 5935 SIGKILL (signal 9)> worker=0
I, [2021-09-21T04:47:00.676007 #6044]  INFO -- : worker=0 ready

redmine.production.log
Processing by GitServerController#info_refs as */*
  Parameters: {"service"=>"git-upload-pack", "id"=>"bu40", "repository_id"=>"gong_bu40_fw", "path"=>"info/refs"}
  Current user: anonymous
(Git Server) Successful authentication for 'ivan' from <IP_ADDRESS> at 2021-09-21 01:44:58 UTC
Completed 200 OK in 329ms (ActiveRecord: 44.4ms)
Started POST "/projects/bu40/repository/gong_bu40_fw/git-upload-pack" for <IP_ADDRESS> at 2021-09-21 04:44:59 +0300
Processing by GitServerController#handle_pack as
  Parameters: {"id"=>"bu40", "repository_id"=>"gong_bu40_fw", "path"=>"git-upload-pack"}
  Current user: anonymous
(Git Server) Successful authentication for 'ivan' from <IP_ADDRESS> at 2021-09-21 01:44:59 UTC
Completed 200 OK in 42ms (ActiveRecord: 11.0ms)

and git
git.exe clone --progress -v<EMAIL_ADDRESS>"D:\work\projects\current\Rovaland\Gong\Soft_uC_TRC\1\gong_bu40_fw"
Cloning into 'D:\work\projects\current\Rovaland\Gong\Soft_uC_TRC\1\gong_bu40_fw'...
POST git-upload-pack (225 bytes)
error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502
fatal: the remote end hung up unexpectedly

I replaced "unicorn" with "thin" and everything started working correctly.


Crosswalk for Kubernetes

Docs & Code - TODOS
Docs: https://github.com/pulumi/docs/tree/crosswalk
Code: https://github.com/pulumi/kubernetes-the-prod-way/tree/crosswalk

General

Docs

[ ] Limit codeblocks to ~30 LoC: https://github.com/pulumi/docs/issues/1969
[ ] Fix k8s lang chooser bouncing around on click: https://github.com/pulumi/docs/issues/1961
[x] Add aliases for old ktpw pages to closely mapped new pages in crosswalk. See here for details.
[x] Rename all full code header links to point to master of ktpw repo instead of the crosswalk branch.
[x] Fix page sidebar overview - it should only be showing headers for the cloud chosen, not all of the headers on the page: https://github.com/pulumi/docs/issues/1962
[x] Work in @spara Feedback PR: https://github.com/pulumi/docs/pull/1964/
[x] Add FAQ to Crosswalk index / landing page
[x] Update cake diagram on index / landing page (BSTRO is handling this)
[x] Address Levi's GCP feedback
[x] Move FAQ from bottom of index to its own page to shorten the index page length
[x] Add DigitalOcean to FAQ

Code

[x] Add readme to each ktpw stack of the necessary config & stack references.
[x] Add ktpw readme
[x] Sync up all stack config files to be similar

Managed Services:

Docs

[x] Add push image example to ACR
[x] Add push image example to GCR

Control Plane:

Docs

[x] Refactor AWS YAML & TS code for StorageClasses into k8s-language chooser
[x] Azure: Add k8s-language chooser and content for using PVCs like in AWS
[x] GCP: Add k8s-language chooser and content for using PVCs like in AWS

Config Defaults:

Docs

[x] PSP - Add TS & YAML examples for all clouds

Cluster Services:

Docs

[x] Logging

[x] AWS
[x] GKE
[x] AKS

[x] Monitoring

[x] AWS
[x] GKE
[x] AKS

[x] Datadog DaemonSet

Code

[x] Logging

[x] AWS

fluentd-cloudwatch

[x] GKE

Stack driver

[x] AKS

Azure Monitor blog post

[x] Monitoring

[x] AWS

cloudwatch metrics

[x] GKE
[x] AKS

Azure Monitor blog post

[x] Datadog DaemonSet

App Services

Docs

[x] Datastores

[x] AWS - Postgres RDS & Redis
[x] GKE - Cloud SQL & Redis
[x] AKS - Cosmos DB

[x] General App Services

[x] NGINX ingress controller

Code

[x] Datastores

[x] AWS - Postgres RDS & Redis
[x] GKE - Cloud SQL & Redis
[x] AKS - Cosmos DB

[x] General App Services

[x] NGINX ingress controller

Apps - TS

Docs (TS)

[x] build container, push it to registry, run it as Deployment
[x] wordpress with pvc
[x] configmap roll out - link to tutorial
[x] Deployment with Secret for DB connection info
[x] DaemonSet
[x] Job
[x] Cron Job
[x] Stateful Set
[x] Sidecar

Code (TS)

[x] build container, push it to registry, run it as Deployment
[x] wordpress with pvc
[x] Deployment with Secret for DB connection info
[x] DaemonSet
[x] Job
[x] Cron Job
[x] Stateful Set
[x] Sidecar

Apps - TS KX

[x] build & deploy - AWS
[x] build & deploy - Azure
[x] build & deploy - GCP
[x] Job
~[ ] DaemonSet~
~[ ] CronJob~
~[ ] StatefulSet~

</details

Closing out with https://github.com/pulumi/docs/pull/1864


 You are almost done. However, there are some issues you should fix. Please fix them and your project will be approved.

💯  Highlights 💯

Nice work setting up your  project ✔

♻ Request changes ♻

[x] Check the comments .
[ ] Please ensure all tasks have someone assigned to them.

__
Optional suggestions
_Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 💻 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Nice work implementing the required changes ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


macOS build fixes and instructions

Fixes #7
See avast-tl/llvm#1 and avast-tl/fileformat#2

Nice! How large is your output folder? Maybe we can make a Homebrew package? (They handle pushing to Bintray too.)

@Manouchehri 3.9 GB :S

@Manouchehri 3.9 GB :S

Most likely this is due to the yara_patterns in share. Mine is ~3.7 GB.
u@x220 /u/s/generic> du -hs yara_patterns/
3.8G	yara_patterns/

Thanks for working on this. I had a cursory look but didn't go further than that.
There seemed to be a bunch of CMakeLists.txt files that checked for Clang using ... STREQUAL "Clang" which obviously won't detect AppleClang. Changing STREQUAL to MATCHES should fix those.
In your PR, looks like README.md was deleted/renamed?

@petmac there's only one file checking for compiler, and it should not confuse AppleClang and Clang there :)

@petmac Wow, thanks, I've cleared README.md somehow :\

@stek29 I've tried to compile your branch on a 10.13.2 system. It complains about a missing library (which is not available on osx afaik). Maybe some makefiles with a missing switch?
Scanning dependencies of target capstone2llvmirtool
[ 17%] Building CXX object deps/capstone2llvmir/src/capstone2llvmirtool/CMakeFiles/capstone2llvmirtool.dir/capstone2llvmir.cpp.o
[ 17%] Linking CXX executable capstone2llvmir
ld: library not found for -lrt
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [deps/capstone2llvmir/src/capstone2llvmirtool/capstone2llvmir] Error 1
make[1]: *** [deps/capstone2llvmir/src/capstone2llvmirtool/CMakeFiles/capstone2llvmirtool.dir/all] Error 2
make: *** [all] Error 2

@ostefano

See avast-tl/llvm#1 and avast-tl/fileformat#2

@stek29 @petmac is correct with the STREQUAL vs MATCHES comment. Without that you do get an error "Unsupported compiler. Supported: GCC, Clang." in the openssl dependency.

@sarnau Are you sure you have fileformat and llvm with my patches merged?
See this
Just making MATCHES is not a good idea. If it prints "Supported: GCC, Clang", then it thinks it's Linux, and that's not correct. So better it says "Unsupported compiler" than silently fails with lots of issues about trying to use linux kernel crypto features on macOS.

Just out of curiousity - how did you avoid that the original Apple flexversion got picked up? My build was failing until I renamed the original Apple files.

@newkit README is made for reading it.

Oh really? ;-) I know it is mentioned there and I had installed it through homebrew. And changed the PATH variables as mentioned, but still yaramodpicked up Apples /usr/bin/flexand failed building.

@newkit Did you also change two other variables? Did you put homebrew's flex/bison in the beginning of PATH?


man-db: 2.11.1 -> 2.11.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/man-db/versions.
meta.description for man-db is: An implementation of the standard Unix documentation system accessed using the man command
meta.homepage for man-db is: http://man-db.nongnu.org
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.11.2 with grep in /nix/store/lfjvp8kx5d4bv97khzp9qk5941ryy71q-man-db-2.11.2
found 2.11.2 in filename of file in /nix/store/lfjvp8kx5d4bv97khzp9qk5941ryy71q-man-db-2.11.2

Rebuild report (if merged into master) (click to expand)

30545 total rebuild path(s)

30545 package rebuild(s)

First fifty rebuilds by attrpath

ArchiSteamFarm
AusweisApp2
BeatSaberModManager
CHOWTapeModel
ChowCentaur
ChowKick
ChowPhaser
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
EBTKS
EmptyEpsilon
Fabric
HentaiAtHome
LibreArp
LibreArp-lv2
MACS2
MIDIVisualizer
MMA
OSCAR
OVMF
OVMFFull
PageEdit
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_image_2_0_5

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lfjvp8kx5d4bv97khzp9qk5941ryy71q-man-db-2.11.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A man-db https://github.com/r-ryantm/nixpkgs/archive/82a0533e0a682a54a6dc973e2f5d5ace187de470.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lfjvp8kx5d4bv97khzp9qk5941ryy71q-man-db-2.11.2
ls -la /nix/store/lfjvp8kx5d4bv97khzp9qk5941ryy71q-man-db-2.11.2/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

@ofborg build man-db man-db.passthru.tests


Tag TestNSMgrRestartRestoreNSE as basic

Signed-off-by: Artem Belov<EMAIL_ADDRESS>Description
Add tag "basic" for TestNSMgrRestartRestoreNSE
Motivation and Context
TestNSMgrRestartRestoreNSE does not have tag
How Has This Been Tested?

[x] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

/rebase


feat: add lang parameter to the queriesPreview hash

Pull request template

When we made the implementation of cached the queries preview, we didn't realize that a queryPreview could work with different languages, but obtain different results.
Now when we change the language and a queryPreview return results in both languages we are not making a new request of the query with the new language. That's because the query is already saved in the state.
The change that we have made in this PR is to add the lang param to the QueryPreview hash.
Motivation and context

[ ] Dependencies. If any, specify:
[X] Open issue. If applicable, link: RST-2449

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[X] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that causes existing functionality to not work as expected)
[ ] Change requires a documentation update

What is the destination branch of this PR?

[X] Main
[ ] Other. Specify:

How has this been tested?

Install this version in Bigbuy, change the language and set queriesPreview to [].
Then check that the first carousel (innovagoods) changes it results when you set a new lang.
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review on my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.

Great job!
Maybe it makes sense to add a test to prove that the same query can be requested consecutively from 2 different langs without being cancelled?


Add Trajectory selection (on dashboard)

Use the preferred DashBoard in order to make a convenient drop-down selection button for the four autonomous trajectories.

Added trajectory selection using null for the sendable chosser until we create the autonomus commands for the two trajectories


The multiplication of matrix

Hello author, thank you very much for your work. But I have a problem with the multiplication of this matrix: if X is a matrix of size (d,b), then the transpose of X x X has size (b, b), and WX-X has size (d, b), then how can the two matrices be multiplied? Look forward to your reply, thank you!

This was a typo in an earlier submission. The updated equation is on Arxiv. https://arxiv.org/pdf/2407.04620

This was a typo in an earlier submission. The updated equation is on Arxiv. https://arxiv.org/pdf/2407.04620

Thanks！


use px4_poll in modules with block structure for simulation

I encountered high CPU load of the mainapp and therefore lag in the simulation. I found with the help of @tumbili that usage of px4_poll is crucial for simulation on a linux pc! Otherwise probably random things get polled by the linux kernel and the poll call is not blocking the px4 module anymore.
Maybe consider to also use px4_poll in other places, i just replaced the ones using the block structure with updateSubscriptions(); because there you get the high CPU load and lag.
switch the modules implementing the block structure to px4_poll such that in posix_sitl simulation the poll works as expected, blocks the module and doesn't overload the CPU

Thanks, merged!


Impossible to install wallet

Describe the error
I can have the zipped version. Because with the exe version 1.0.0 the wallet is not installed on windows 10.

Please open this issue in the Wallet repository https://github.com/nemgrouplimited/symbol-desktop-wallet/issues and provide more details about the error.


mise generate

I want to see a new top-level topic for us to store some codegen things for mise.

[ ] mise generate config - currently we have this as mise config generate—should be moved here. Potentially this could also be aliased as mise init.
[ ] mise generate github-actions - generates a github action yml, typical use-case would be to install dependencies and execute a task like mise run test. We can talk about exactly what this should do.
[ ] mise generate dockerfile - generates a dockerfile which will install mise, run mise install, and probably add the shims directory. How it gets the .mise.toml I'm a little unsure of right now though.

closing in favor of #2115


Voronoi case study

hi @jmb280cam
the section https://sje30.github.io/catam-julia/casestudies/voronoi/voronoidiagrams.html#5619eeaa-d0ae-4752-987a-abc6b9236725 would be easier to understand I think with a figure to help demonstrate how your algortihm works?  Could you sketch one? (either just in a png or using Plots() to draw it.)

Ok, I think I could do a few diagrams in Plots

I've added a few diagrams, hope they get the idea across better

great, thanks!


fix: don't escape dash in define regex

Description

fix #9964
Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

As you explained in https://github.com/vitejs/vite/issues/9964#issuecomment-1235534424, the define feature needs to work both during build and dev. So we can't allow dashes if they are only going to work during build. I think your recommendations in #9964 were on point, and we should keep define as is.

👍🏻👍🏻
I still think that constructing an invalid Regex isn't really sound though. What do you think about fixing the Regex so it doesn't throw an obscure error anymore, but printing a warning if a define key contains a character that can't be part of a variable/identifier?

@jonaskuske that sounds like a great improvement 👍🏼

Given that we now use esbuild for define (#11151), I guess this is no longer needed.