CNF-7517: Proposal for Enabling pre-caching of user-specified images

Enhancement proposal for CNF-7517: Enabling pre-caching of user-specified images.
/cc @imiller0 @jc-rh @vitus133 @sabbir-47 @sudomakeinstall2  @ijolliffe

Good work :+1:

/approve

/approve


KEIndexedVariableTest has no test at all

There is no test in KEIndexedVariableTest class but code. A test class is only to tests features of the code.

Oops. I added two test cases in this class. The first one is "exampleCreateIndexedValue" and the last one is "exampleIndexedExpression". They are in revision 643.

These are not tests !
Tests just start with testXXXX or they are not tests and they don't appear in the test runner. Looks at other tests in the system.

Thank you. I change their names and commit my code as well. My revision is 646.

ok integrated in last version


lone hits are in ADC

This is quire misleading, why is it not simply in PE

Perhaps we want to reopen https://github.com/XENONnT/straxen/pull/272 at some point

Answer is very simple, hits are always in ADC, we might want to change the datatype for this specifics if needed. However, this than obscures the purpose of lone-hits serving as an easy check if the ADC->PE conversion is done right.


Analog Villain3DS

There is a proposal to make an analogue Villain3DS . The database will be original tickets from different consoles of the world and will be replenished.There are 4 tickets in my database.

hm? I might have not understood, make an "analogue Villain3DS"?
What are you trying to issue here?

I got my answer on what "Villain3DS" is.
That's a no. If you're issuing this here, you must clearly have not read the Notice on README.md.
A loading a local database, like your own private ticket.db or a custom one with your tickets alone would be one thing. Now what you're asking me is to have it use a database that will be original tickets from different consoles of the world, that's sounds like very explicitly piracy, because you are not getting tickets you bought yourself from the eshop, and I'm guessing you want an online kind of service like the title key databases that existed, but where people share out full tickets.
If you want one, better off making it yourself or finding someone else.
And read the README.md. I got a warning there about ticket's console unique data. Think twice.


Set column width, fixes #1

Since you're already working on this code, please capitalize the second "t" in the Time tracking column heading


WiP - Natural Language Testing

This patch refactors the test package into an opaque, black box that utilizes Ginkgo testing in order to produce a comprehensive, natural language test harness.

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   28.54%   28.54%
=======================================
  Files          34       34
  Lines        1993     1993
=======================================
  Hits          569      569
  Misses       1363     1363
  Partials       61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d414c47...e3c32a9. Read the comment docs.

Hi @codenrhoden,
Your view of things is correct. In the end the driver's only test file is like so:
// +build !libstorage_storage_driver libstorage_storage_driver_vfs

package vfs

import (
	"testing"

	apitests "github.com/codedellemc/libstorage/api/tests"

	// load the ginko test package
	_ "github.com/onsi/ginkgo"

	// load the vfs driver packages
	"github.com/codedellemc/libstorage/drivers/storage/vfs"
	_ "github.com/codedellemc/libstorage/drivers/storage/vfs/client"
	_ "github.com/codedellemc/libstorage/drivers/storage/vfs/storage"
)

func TestSuite(t *testing.T) {
	apitests.RunSuite(t, vfs.Name, nil)
}

However, there's no reason you could not also execute your own tests from the driver's test file.

Hi @dvonthenen,
I'd appreciate if you'd take a look at this PR as well. Please note how the file vfs_test.go has changed. It makes writing tests for drivers as simple as calling a single function.


USS Savannah: Episode IV An Old Hope

About the PR
Feel free to ping me here or in discord and ask/demand for some additions.
A fourth refit of USS LCS-14 Savannah:

Requi line is now a little bit bigger.
Third refit of engineering
Escape pods
Escape shuttles
Power
Orbital Cannons
More cozy places to slowly bleed out

Media
https://tunguso4ka.github.io/map-viewer/?map=Savannah

Changelog
:cl:

add: A somewhat unlucky USS Savannah returns from her refit.

I think i overdid amount of escape pods (12) and lifeboats (2).

sick stuff
Besides if the amount of pods proves to be an issue it can always be modified later. On one side it's a smaller ship but on the other there's still a lotta personnel so ya know


Review - Video for Functions

the video can be found here: https://www.youtube.com/watch?v=_kbJhpKNBa0&feature=youtu.be

Comments:
4m37s: rows 6 - I can't understand how it appears in parenthesis (magicianName: "David Blane"). It doesn't appear at my side, it appears only the parameter "David Blane". Is this important or could be ignored?
5m59s you clicked "Step Into", what's the difference beteen it and "Step Over"

the typing speed is quite big, but when I get used with your style and also using the pause in youtube videos, I can follow you and I can understand almost everything. In order for videos to be much more easier to be understood by the public , you need to improve the balance betwwen the speed of writing and the perfect timings for micro-breaks (pause) in video editing.
the english orthography still remains an issue to be improved.
perhaps you can do new revised videos with a clean product at the end...

for the "magicianName", there is a feature in newest versions of Idea - Parameter hinting: http://stackoverflow.com/a/39787499
and : https://blog.jetbrains.com/idea/2016/09/intellij-idea-2016-3-eap-faster-git-log-parameter-hints-and-more/   -   Parameter hints

I'll slow down the video speed, so it'll slightly better, yet, it'll take longer time to watch!
yeah.. english is bad so far.. I mean.. for teaching, is not enough, I'll try to find someone who can help with this.


mocha --opts not working anymore

As soon as I include "yaml-schema-validator": "^1.1.9" in my package.json and npm install it, mocha --opts mocha.opts fails with this error message:
$ mocha --opts mocha.opts
error: unknown option `--opts'

My project has these dependencies:
"devDependencies": {
    "chai": "^4.2.0",
    "chai-as-promised": "^7.1.1",
    "eslint": "^6.5.1",
    "eslint-config-airbnb-base": "^14.0.0",
    "eslint-plugin-import": "^2.14.0",
    "fast-xml-parser": "3.13.0",
    "mocha": "^6.2.1",
    "nyc": "^14.1.1",
    "yaml-schema-validator": "^1.1.9"
  },
  "dependencies": {
    "app-root-path": "^2.2.1",
    "bluebird": "^3.7.0",
    "config": "^3.2.3",
    "glob": "^7.1.4",
    "js-yaml": "^3.13.1",
    "json5": "^2.1.1",
    "jszip": "^3.2.2",
    "lodash": "^4.17.11",
    "moment": "^2.22.2",
    "moment-range": "^4.0.1",
    "moment-timezone": "^0.5.23",
    "normalize-path": "^3.0.0",
    "ramda": "^0.26.1",
    "sql.js": "^1.0.0",
    "winston": "^3.2.1",
    "yargs": "^14.2.0"
  }

If I remove yaml-schema-validator, the command mocha --opts mocha.opts runs all tests as expected.
The problematic behavior is observed regardless of platform, it's the same on Linux, Windows, or macOS. Node.js version 10.16.3 was used.

I have observed the exact same behavior with Jest. Having yaml-schema-validator in the package.json and installed does not cause issues for me. Only when it is imported with require('yaml-schema-validator') in my project, the error: unknown option xxxxx errors arise.
See https://github.com/facebook/jest/issues/9379 for my original report assuming Jest would be the culprit. It contains steps to reproduce the issue from the failing commits from my Travis-CI pipeline.

I just tried with "yaml-schema-validator": "1.0.0" pinned dependency and the issue exists there already, so it is probably there from the beginning and not a regression.
C:\Data\GitHub\juice-shop>npm run frisby

><EMAIL_ADDRESS>frisby C:\Data\GitHub\juice-shop
> nyc --report-dir=./build/reports/coverage/api-tests jest --silent --runInBand --forceExit

Determining test suites to run...error: unknown option `--silent'

Removing the only const validateSchema = require('yaml-schema-validator') in my code base (which does not even have to be called - it just has to be imported) makes my test suite run perfectly fine again.

I think the culprit is the design of the module as a mix of CLI and programmatic library all in one. I have no experience with the commander module, but I suspect that this code section is somehow "eating" the command line arguments of the jest or mocha call:
program
  .version(pkg.version)
  .command('validate')
  .option('-f, --filePath <filePath>', 'path to the target file for validating')
  .option('-j, --json','passed if target file is in JSON format')
  .option('-s, --schema [schemaPath]','path to an external schema.js file')
  .action(validateSchema);

program.parse(process.argv);

if(process.argv.includes('help')) {
  help()
}

If this would be extracted into its own file - which then serves for the CLI use case - the programmatic use case would import the actual validator only but not the CLI code.

✅ The problem can be bypassed by programmatically importing const validateSchema = require('yaml-schema-validator/src')  as a workaround.

thanks @bkimminich for coming up with this. It can work as a temporary workaround till I mitigate the root cause.
Looks like an issue in one of the dependencies and not in the package itself. Would certainly recommend to upgrade to node version 10+ or 11 to avoid this scenario.
Closing this issue.

I'm using Node 10, 12 and 13 in my project and they all had this problem.

Same error  here  running jest --coverage. Tested with the following node versions:

v10.24.1
v12.22.3
v14.17.4

 ●  process.exit called with "1"

      5 |
    > 6 | const validateSchema = require('yaml-schema-validator');
        |                        ^
      8 |

      at Command.Object.<anonymous>.Command.unknownOption (node_modules/yaml-schema-validator/node_modules/commander/index.js:823:11)
      at Command.Object.<anonymous>.Command.parseArgs (node_modules/yaml-schema-validator/node_modules/commander/index.js:661:12)
      at Command.Object.<anonymous>.Command.parse (node_modules/yaml-schema-validator/node_modules/commander/index.js:474:21)
      at Object.<anonymous> (node_modules/yaml-schema-validator/index.js:24:9)
      at Object.<anonymous> (src/config/settings.js:6:24)


Galeforce always boosts.

Description says after max pull, but u can spam right click and have infinite Speed boost.
In Off Hand you also get a dash (with cd), but also even after one right click.
Kinda op ngl
And I love calculated fall for darkin blade, but movement is so weird. you just get a little boost upwards with almost no momentum. I guess I kinda expected it to slingshot (to a degree) you wherever you look..
Don't know what's your planning with that.
Ik Aatrox is not that mobile with his Q, but also combine Q with his E. :3
So yeah, not that fun to use it for only jump basically.

Oh and what is Umbral Trespass and how can I use it? Against whom? Really no clue

Umbral Trespass "mounts" the last mob you hit when using it. In this state, you take no damage, and on dismount, you will damage the mob.
I do know of the Galeforce bug, haven't decided whether I want it to be a feature or not, but yeah I agree that it is kinda op.
As for the Darkin Blade, I'll add a small boost so it feels less clunky.


Coding cookies and buying upgrades, like a computer factory or social media app, that create more cookies, in order to reach $1 billion in value.

How do you play your game?
The prompts are shown in-game, but press S to create cookies, and W to buy new cookies. Each upgrade has its own button to press.

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

Hi, there was an error in my code, I've solved that now so it should be able to pass these workflows now 😄


Node gen video error when complete

env: nodejs v14.20.1
when i use ffcreator gen video. got resource lock err:

but file were generated in cache dir:

Kill process try again

uploading my code please wait

Here is my code

I almost didn't try to restart the computer

could i use ffcreator and ffcreatorLite together？
Maybe this caused the problem...

please

don't share cache file

could i use ffcreator and ffcreatorLite together？
Maybe this caused the problem...

don't share cache file

could i use ffcreator and ffcreatorLite together？
Maybe this caused the problem...

don't share cache file

im not shared the cache file. and when error accuse, just run ffcreator gen video code, instead of ffcreatorlite. but got error too.


The UI does not render once djoser URLs are added

Once djoser URLs are added into the project urls the UI does not render. And it throws the following error:
TypeError at /api-UI/
getattr(): attribute name must be string
Stacktrace

I got the same problem here. Is this a djoser or swagger problem?

@5ak3t @svschannak Have either of you figured out a solution to this?

Linking your gist here:
https://gist.github.com/anonymous/04c923a2171d4e1f44231c3510ddf981
I have not used djoser so I am not sure, however, looking at the stacktrace, it appears to be an exception coming from DRF schemas. I suggest opening an issue on Django REST Framework and provide a failing test to demonstrate the bug.
File "/Home/uname/.virtualenvs/openx/lib/python3.5/site-packages/rest_framework/schemas.py" in get_description
  402.         method_docstring = getattr(view, method_name, None).__doc__

Exception Type: TypeError at /api-docs/
Exception Value: getattr(): attribute name must be string
Request information:

Did a bit of digging on this, looks like a fix has been made in the djoser package: https://github.com/sunscrapers/djoser/pull/172 but has not been released to PyPI.
With that said, in DRF schemas.py https://github.com/tomchristie/django-rest-framework/blob/06df61e38c6ed99732007b0e9f3cc26e8317389e/rest_framework/schemas.py#L401, we could probably add an additional check to verify that the method_name is an instance of str() rather than trust the view. This seems like an edge case though...

Looks like djoser pushed to pypi:
https://github.com/sunscrapers/djoser/pull/172#issuecomment-269964656


Issue 22: Update CHANGELOG

Merge Checklist

[ ] Have you linked this Pull Request to an Issue?
[ ] Have you updated any relevant README files, to explain how this new feature works (with examples)?
[ ] Have you added relevant test cases for your change?
[ ] Do all tests and code style checks pass with ./gradlew check --info?
[ ] Have you successfully run your change in a pipeline in a Jenkins instance?
[x] Have you updated the CHANGELOG?

Issue #22

Codecov Report

Merging #26 (de994f7) into master (eee3cc0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           22        22
=========================================
  Hits            22        22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee3cc0...de994f7. Read the comment docs.


Use SLSA publish action to include verified build information

Fixes #210
cc @ianlewis if this looks about right to you - obviously aren't really able to test this completely outside of an actual github action.

@ianlewis you mean you wanna recommend something like what I have now, going forward, for the install & test phases or a build, rather than using the run-scripts argument to the builder?

@ianlewis you mean you wanna recommend something like what I have now, going forward, for the install & test phases or a build, rather than using the run-scripts argument to the builder?

tbh, It's not a big deal either way. You could do it the way you have it for convenience's sake if that makes sense for you. There just isn't really a specific reason to run the tests in the builder.

I tested this out on hereby as a low-risk test before we do this to critical packages, and unfortunately it didn't seem to work: https://github.com/jakebailey/hereby/actions/runs/5483129736/jobs/9989176122#step:11:404

I tested this out on hereby as a low-risk test before we do this to critical packages, and unfortunately it didn't seem to work: https://github.com/jakebailey/hereby/actions/runs/5483129736/jobs/9989176122#step:11:404

Yes, this is a bug. Will fix ASAP.
https://github.com/slsa-framework/slsa-github-generator/issues/2359

With 1.8.0 out, I got my first working SLSA level 3 build: https://github.com/jakebailey/hereby/actions/runs/5768389689
Feel free to copy my (now working) pipeline for this, though we'll have to get it into everyone's heads to stop doing local releases 😄

With 1.8.0 out, I got my first working SLSA level 3 build: https://github.com/jakebailey/hereby/actions/runs/5768389689
Feel free to copy my (now working) pipeline for this, though we'll have to get it into everyone's heads to stop doing local releases 😄

Thanks! I'm glad things are working for you now. Hopefully v1.8.0 allows us to move forward.


JSdoc/TS fix of EllipsoidTangentPlane.fromPoints

The EllipsoidTangentPlane.fromPoints misses a return type, it creates a new instance of EllipsoidTangentPlane. Missed to report this in #8926.

Thanks for the pull request @zoran995!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks @zoran995!

@hpinkos @zoran995 Hey guys. I realize this is a bit of a nitpick, but could one of you correct the minor typo in the changelog regarding this PR? (CI skip)

... which didn't listed a return type.


Fixed #246: 2.8 version of Redis on Debian 8 errors out

On Debian 8, the apt-policy still keeps outdated 2.8.17 preferable, so the outdated version gets installed. This fix makes sure the right version will be installed.
See #246

I'm going to close this since I'm working on updates that drop Debian 8.


custom layers in scrollable area

Custom layers in inner scrollable area would be useful to place some non-virtualized content. Eg.:

links between items across lines
"row" / "column" borders (1 row table for rendering columns and 1 column table to render row borders)

Example markup based on kendo gantt:

        <colgroup>
            <col>
        </colgroup>

        <colgroup><col><col><col><col><col></colgroup>

Can try to self assign on it, but will need your approve and API suggestions.

Honestly not sure how this would work without significantly complicating the rendering logic.

Let this issue sit for a bit and sink in and basically it's not something that I know how to approach in a generic way.
I think you could use the onScroll callback in a similar way as ScrollSync to implement this type of functionality if you wanted. You'd essentially just need to position another
 (or custom component) on top of the Grid and then put whatever you want inside of it- keeping it "synced" with the visible cells using the callback.
If you'd like to tackle implementing it I'd be happy to review a PR. If it seems generic enough we could bundle it with react-virtualized. If it seems too use-case specific we could include it in the recipes/examples section. :)
I don't plan to work on this myself though so I'm going to close the issue for now. (I don't like leaving issues open that I don't plan to act on.) We can continue to discuss this feature here, or through PRs, though.

@bvaughn it looks as easy as just:
diff --git a/source/Grid/Grid.js b/source/Grid/Grid.js
index 2ba198b..1ffe02b 100644
--- a/source/Grid/Grid.js
+++ b/source/Grid/Grid.js
@@ -487,6 +487,7 @@ export default class Grid extends Component {
               pointerEvents: isScrolling ? 'none' : 'auto'
             }}
           >
+            {this.props.children}
             {childrenToDisplay}

         }

Works as I expect:
<Grid ...props>

    any background content

</Grid>

VirtualScroll and FlexTable hocs could also pass their (non FlexColumn) children to Grid as well.

That definitely seems like an over-simplification.

How do you plan to sync your childrenToDisplay (horizontally and vertically) to ensure that they line up with the rendered cells underneath of them?
How do you plan on informing the childrenToDisplay of which cells are being displayed (and where) so you can align your overlay?
Presumably your grid contains many many cells (or you wouldn't need to virtualize them). How do you plan on windowing the content in childrenToDisplay so avoid rendering all of it (and defeating the purpose of using the Grid in the first place)?

@bvaughn it is not over-simpification it is really only thing I need:
<ScrollSync ...ssProps>
  {({ onScroll, scrollLeft, scrollTop }) => (
     <TimelineHeaderGrid scrollLeft={scrollLeft} ...timelineProps />

       <VirtualScroll
         onScroll={onScroll}
         scrollTop={scrollTop}
         width={1024}
         height={200}
         rowsCount={10}
         rowHeight={20}
         rowRenderer={
           index => <GanttTask ...getGanttTaskProps(index) /> // task positioned in a row
         }
         {...props}
       >
        <RowsBackground
         width={1024}
         height={200}
         rowsCount={10}
         rowHeight={20}
        />
        <ColsBackground ...colsBackgrounProps />
        <Dependencies ...depsProps />
       </VirtualScroll>

  )}
</ScrollSync>

I have all what I need to manually position dependencies on background layer: rowsCount, rowHeight, and tasks positioned horizontally.

I don't need to virtualize every cells because background comes only with n + m elements, not n * m

If you don't need to virtualize cells, and none of the questions I asked above are problems for you, then why does this need to be inside of the VirtualScroll at all?
<ScrollSync>
  {({ onScroll, scrollLeft, scrollTop }) => (
    <TimelineHeaderGrid scrollLeft={scrollLeft} ...timelineProps />

      <VirtualScroll
        onScroll={onScroll}
        scrollTop={scrollTop}
        width={1024}
        height={200}
        rowsCount={10}
        rowHeight={20}
        rowRenderer={
          index => <GanttTask ...getGanttTaskProps(index) /> // task positioned in a row
        }
        {...props}
      />

        <RowsBackground
          width={1024}
          height={200}
          rowsCount={10}
          rowHeight={20}
        />
        <ColsBackground ...colsBackgrounProps />
        <Dependencies ...depsProps />

  )}
</ScrollSync>

Because it would require to hook it on ScrollSync too. Which seems complete overkill, because it can be scrolled natively within container.

I can try to prepare a pr with demo

I don't think it's overkill, considering this seems to be a special use-case.

@bvaughn just try any ScrollSync on mobile or Internet Explorer. You'll see that it is not so smooth. I try to avoid using ScrollSync on mobile views and decrease using it at all on desktop ones too. Just can't find any reason to use it, because placing layer to existing scroll container doesn't requires to redraw layer on scroll, but ScrollSync does.
I have created a little demo: Source Deployed (see ScrollSync demo)

The scroll-sync demo you linked to looks fine to me, even for IE10 in my crappy little Virtual Box VM (which is the only way I have to test IE) and in the iOS simulator.
Anyway, I don't think this example test-case you've created is very representative in terms of windowing performance because you're only drawing a few small lines to connect certain cells. How is it going to perform when you're connecting thousands of cells? (It won't, I don't think, without windowing.) Which makes me think that you'd do better stacking 2 windows components on top of each other (like 2 Grids).

It works acceptable in ie10+, but lag is pretty notable by eye. It always happens in IE. I don't know any existing solution to make good controlled scroll behaviour.
But even without taking IE in account can't get why I have to create one scrollable area over another with the same container and inner scrollable area sizes and keep them in sync.
I know how important and hard to keep library's public API narrow and focused, but can't see why you against of this change. Do you see any drawbacks?

I already pointed out a few issues I saw with this feature request. I'll try to word them differently.

How do you convey position of grid-cells (or table rows) to your custom layer to ensure that things line up?
How do you inform your custom layer of which cells are currently being displayed so you can implement windowing? (And if you don't plan on implementing windowing in the custom layer, why use a react-virtualized component at all?)

I’m also will be glad about the opportunity to pass children to Grid.
Looks like everyone who is doing Gantt charts will find this issue eventually, so I will try to answer the questions and describe the use case:
Here is the code:
<AutoSizer>
  {({ height, width }) => (
    <Grid
      rowsCount={1}
      width={width}
      height={height}
      columnWidth={col_width}
      columnsCount={columns_count}
      rowHeight={height}
      renderCell={this.renderGridCol}
    >
      <Grid
        className={styles.rowsContainer}
        rowsCount={rows.length}
        width={columns_count * col_width}
        height={height}
        overscanRowsCount={15}
        columnWidth={columns_count * col_width}
        columnsCount={1}
        rowHeight={unit_height}
        renderCell={this.renderRow} />
    </Grid>
  )}
</AutoSizer>

As you can see here are 2 Grids: the parent one is rendering background cols, so it is just one row and n-cols.
The child Grid is rendering task rows: so just one col and m-task rows.
Child grid styles are pretty simple too:
.rowsContainer {
  position: absolute;
  top: 0;
}

With that composition there is no need to do scroll syncing, browser is doing that for us.
And as soon as we have 2 distinct windowing: horizontal and vertical, no need to pass anything from the parent grid, scroll doing everything for us here too.
Hope that makes sense!

Hey @somebody32,
Your example code is functionally no different than stacking 2 Grids (position one so that it covers the other). Without ScrollSync (or a similar technique) only the top Grid will be scrollable by the user. (The browser will not sync them for you. Scroll events don't pass through the z-index like that.)
What you are asking for is already possible as I mentioned above with the ScrollSync. Your code would just need to change slightly:
<ScrollSync>
  {({ onScroll, scrollLeft, scrollTop }) => (
    <AutoSizer disableHeight>
      {({ width }) => (
        [
          <Grid
            k='backgroundGrid'
            scrollLeft={scrollLeft}
            scrollTop={scrollTop}
            {...backgroundGridProps}
          />,
          <Grid
            k='foregroundGrid'
            onScroll={onScroll}
            {...foregroundGridProps}
          />
        ]
      )}
    </AutoSizer>
  )}
</ScrollSync>

@bvaughn,
It is working already (I've cloned the repo and added {props.children} into Grid's render).
Here is an example:

These color bars are the rows from the second grid, the background is generated by the parent one.
I've tried stacking 2 grids too + scroll sync, but that was showing some delay and as a result, the table had kind of parallax effect :) You can see an example in the GIF of that if you take a look at the Gantt Grid header (it is yet another Grid which is ScrollSync'ed with the two others from the previous example), its today mark flows away from the grid's one. I know that I need to optimize header rerenders, but if it is possible to avoid usage of ScrollSync I think it is good to do so.

Hm. Share your code with me? (Link me to your fork?)
If you stack 2 scrollable containers, only the top one will get scroll events, so I don't understand how the lowest-z-index Grid is getting scrolled.
In Aleksey's previous examples, the additional children were just absolutely positioned within the scrollContainer and so they scrolled naturally with the rest of the content, but that tosses out the benefits of windowing.

@bvaughn it is totally identical to Aleksey's except {this.props.children} are rendered after the {childrenToDisplay}.
Sorry, forgot to tell that color rows are horizontally positioned with translatex, but windowing is still working because I'm interested in vertical windowing for them, not the horizontal one.
Will be glad to share more code/examples.  maybe just resulting html will work?

Ah, then the code sample you pasted above (a Grid within a Grid) would not work. Scrolling doesn't automatically get synced that way. I'm a bit confused. I'm going to need to see a complete coding example. (Something I can check out and run, or a demo with source I can view.)

@bvaughn I will try to prepare repo today

Take your time. This is not a job/project I'm paid for so I can't really work on it during the day. I'll check back this evening.

I've created the demo, click on Grid  to see it live.
The code is here

Ah. I see what you're doing. It seems pretty limited though. The inner Grid isn't being virtualized along the x-axis (there's no horizontal windowing) because its width is 2600 pixels. The outer Grid is only scrollable horizontally. So this only works if each Grid only needs to scroll along one axis.

One approach you could consider trying if the Grids seemed out of sync with the ScrollSync approach I recommended would be to sync both Grids based on an invisible scrollable div. In other words something like this:

        <ScrollSync>
          {({ onScroll, scrollLeft, scrollTop }) => (
            <AutoSizer>
              {({ height, width }) => (

                  <Grid
                    className={styles.gridStyle}
                    {...bottomGridProps}
                    scrollLeft={scrollLeft}
                    scrollTop={scrollTop}
                  />
                  <Grid
                    className={styles.gridStyle}
                    {...bottomGridProps}
                    scrollLeft={scrollLeft}
                    scrollTop={scrollTop}
                  />

 onScroll({ scrollLeft: event.target.scrollLeft, scrollTop: event.target.scrollTop })
                    }
                    style={{
                      width,
                      height,
                      overflow: 'auto',
                      position: 'absolute',
                      zIndex: 1
                    }}
                  >

              )}
            </AutoSizer>
          )}
        </ScrollSync>

And in the above example, the gridStyle class could disable default scrolling:
.gridStyle {
  overflow: hidden !important;
  position: absolute !important;
  top: 0;
  left: 0;
}

This is a great idea! Tried that and scroll sync seems way better now (no lags for header and grids). The only problem that this approach has is: this new div steals all pointer events from the grids. Looks like there is no way to do scrolling and also do hovers/interaction with grids' content

Hm. Tried swapping the
 with the onScroll handler to the bottom? Seems like that should still work though I admit I haven't tried it.

Yep, I've tried moving it to the different places, but the problem seems the same: it needs to get pointer events to be scrollable, but then grid's children will receive nothing

Hm. Your previous demo above suggests that scroll events can go through one item to another if the top item has it's overflow: hidden. That's why I thought it might work if the onScroll div was in the back.

I think it only works when you're trying to scroll children because an event is bubbling up to the parent, but here we have everything all in one layer. Looks like it is not possible to solve without placing one grid into another

Ah, I see. I guess you could put the Grids inside of the onScroll div then. But you'd have to move them as the user scrolled which would probably end up being too much of a hack. Rats.

So maybe then you can accept PR for rendering children inside the Grid? This will allow avoiding onScroll div and relay on the browser native one

I've just published a new example (http://somebody32.github.io/react-virtualized/, click on Grid, here is the code).
It uses one scrollable div as the parent of both Grid's and then positions grids depending on the current scroll value.
What do you think?

That actually looks pretty reasonable to me. Although I think you could further simplify by...

  <ScrollSync>
    {({ onScroll, scrollLeft, scrollTop }) => (
      <AutoSizer>
        {({ height, width }) => (

 this.wrapper = node}
            style={{height, width}}
            className={styles.grid_wrapper}
            onScroll={onScroll}
          >

                <Grid
                  className={styles.gridStyle}
                  rowsCount={1}
                  width={width}
                  height={height}
                  columnWidth={COL_WIDTH}
                  columnsCount={COLS}
                  rowHeight={height}
                  renderCell={this.renderCol}
                  scrollLeft={scrollLeft}
                  scrollTop={scrollTop}/>
                <Grid
                  className={styles.gridStyle}
                  rowsCount={rows.length}
                  width={width}
                  height={height}
                  columnWidth={grid_width}
                  columnsCount={1}
                  rowHeight={ROW_HEIGHT}
                  renderCell={this.renderRow}
                  scrollLeft={scrollLeft}
                  scrollTop={scrollTop}/>

        )}
      </AutoSizer>
    )}
  </ScrollSync>

PS. You can deep-link by the way, by adding ?component=Grid (eg. http://somebody32.github.io/react-virtualized/?component=Grid)

Yep, thanks, obviously I don't need this.position at all, because there are already scrollLeft, scrollTop available.
But you need an extra check for if (this.wrapper !== event.target) return; inside the top div's onScroll because Grids are producing scroll events too and they are bubbling. If you omit this check, then top could be reset to 0 for a short period of time and everything jumps and seems broken.
Anyway, looks like everything is working great now, thanks a lot for your help and for your hard work on this library! If you're interested and you think this can be useful for users, I can prepare a PR with this example

Makes sense.
Yeah, this would probably make a good example to add to the playground folder. If you'd be willing to put together a PR, that would be great. :)

Hey @Guria  and @somebody32. I wanted to let you know about the recent release 6.1.0 as it has a feature I think you would both find useful.
You can provide a custom render function to create Gris children. Among other things, this should allow you to do your layering within a single Grid instance.

@bvaughn thank you for notifying about that! Our Gantt product is in the final stages before the release now, but I will try to refactor our current 2 grid implementation into one in the first iterations after it asap.
And as a sidenote: thanks a lot for your hard work on this lib, it is really amazing!

@somebody32 does your gantt completely internal? is there a plans to make it public?

@Guria in terms of code or product? if the last one, then it will be released as part of redbooth.com soon

@somebody32 in terms of code but only gantt part as component

@Guria I think after the 6.1 release of react-virtualized and new CollectionView that is coming it is really easy to make it yourself (and I will try to make a PR with an example as I said earlier). I don't think that extracting something more will be useful for the wide audience because it is really coupled to our product.

Hi! I know this issue is kind of old, but I'm currently trying to refactor a Gantt component that I developed using react virtualized. My major problem is that I can't set relations between nodes (visually) because the data is not rendered at all time as it should be with this library, but... How can I draw relations between two or more nodes using for example ScrollSync? @bvaughn


Add New Collaborators

I've gotten really busy lately and haven't been able to keep up with issues as well as I ought. Is anyone interested in being a collaborator for this project? Reply in this thread or email me if so.

:hand: I can take it on.
I'm maintaining a lot of gulp plugins whose owners are too busy to maintain them:

hparra/gulp-rename#35
adamayres/gulp-wrap#16
adametry/gulp-eslint#24
https://github.com/lmtm/gulp-front-matter/pull/5#issuecomment-65747363
kombucha/gulp-assets#8
kombucha/gulp-assets#8
shinnn/gulp-gh-pages#50

@dlmanning When I'm back at my desk next week I'd be happy to help.

Hey I made a PR to make gulp-sass work with node-sass 3.0 (https://github.com/dlmanning/gulp-sass/pull/207) but it should probably not be merged since it's still in alpha-beta.
I was thinking of writing a gulp-sass 2.0 to solve some of the open issues and maybe do some breaking changes (like removing the callbacks, unless someone has a valid usecase for those), I'll post a link to it once I've done it

@Keats : Were you also wanting to be added as a collaborator then?

I can help yes

@Keats @Snugug I've added you both as collaborators. Feel free to fix what needs fixing, though I'd like to at least LGTM any complete rewrite. Thanks for your help!

@Keats I couldn't find you in the list of people to invite. We've got a Gitter set up to chat


internal: private messages exist in state.narrows, but not in state.messages

Under as-yet-unknown circumstances, IDs for private messages are listed in state.narrows[ALL_PRIVATE_NARROW_STR] which do not exist in state.messages.
Known effects of this so far include getPrivateMessages returning (in defiance of its explicit type) an array containing one or more undefined, which in turn results in various flavors of TypeError: undefined is not an object (...) eventually being raised, which in turn results in a Sentry event and (presumably) a crash.

By chance I just today ran across some code that I suspect causes a very similar bug!
The code quoted in #3752, in our narrows reducer:
const updateFlagNarrow = (state, narrowStr, operation, messageIds): NarrowsState => {
  if (!state[narrowStr]) {
    return state;
  }
  switch (operation) {
    case 'add':
      return {
        ...state,
        [narrowStr]: [...state[narrowStr], ...messageIds].sort(),

is cited there for its buggy use of nullary Array#sort, but another thing going on is that it goes and adds some message IDs to a narrows array, in a circumstance where I don't believe we necessarily have the corresponding message.
Can't be the cause of the symptom reported here, though, because it only affects the "starred" and "mentioned" narrows.

Ugh. The fact that this can happen in multiple ways suggests that we may just want to run with it: abandon the idea that messages is a superset of everything in narrows, and have an explicit Inbox (?) type which represents an unreceived message (in the same way that Outbox objects are reifications of unsent messages).

This may be unrelated, but it's noted in https://github.com/zulip/zulip-mobile/issues/3654#issuecomment-573270791 that sometimes private messages do not exist in state.narrows; sometimes this is intended (we don't want to add too-recent messages to a narrow in which we're browsing ancient history), sometimes not, as described in that comment.
Interestingly, at least as I've seen in the buggy case, I'm seeing the message appear in state.messages but not in state.narrows -- an additional misalignment that's the opposite of what this issue describes.


Feature request: Open image in a new tab

Hello,
First, great plugin. Extremely useful.
Just a quick "Feature request".
Include an option to open image in a new tab.
I use the theme Minimal, and when I click on an image, this will temporary, overlay in full screen.
So, I cannot keep the image as full screen.
Workaround:

Click on the image
Ctrl+Click on the image name
The images open in a new tab

Thank you for your consideration.

Hi!
I like the feature idea well enough and I think it's feasible. I looked around in the Obsidian API and I'm not clear on how to do this. I don't think I'll do this anytime soon due to time constraints, sorry. If you know other plugins that use the open in new window mechanism comment them, they might help me to explore the problem.
In the meanwhile, I recommend checking out other plugins that might have the functionality you need:
https://github.com/sissilab/obsidian-image-toolkit
https://obsidian.md/plugins?search=image

@juanbretti Created a pull request for duplicate request https://github.com/NomarCub/obsidian-copy-url-in-preview/issues/36
It opens the image in a new tab, with the path displayed as title. The middle mouse button can also be used to open in new tab.

I just released 1.7.0, which includes this functionality. Let me know if there's anything wrong, either here or in a new issue.


game crashing

crash-2016-11-04_21.03.30-server.txt
at joshie.harvest.npc.entity.ai.EntityAISchedule.func_75246_d(EntityAISchedule.java:83)
What reason is this?

Honestly I've had a look and i'm not entirely sure. Was this consistent, easy way to recreate it?

No response in a month so closing.


Missing bundling for sap-ui-core-nojQuery.js / sap-ui-core-nojQuery-dbg.js

Follow-up of #176

Hi Tommy,
can you please have a look?
Best regards,
Jiawei
Dispatcher


Non-availability outside docker container

Unlike nodejs process, PHP React HTTP listens to something that doesn't allow localhost to be seen outside the container.
What to do? See netstat comparison of ReactPHP and Nodejs

This is actually a Socket feature and it works as expected and documented :-)
If you want to listen on all or some public interfaces, you have to specify which address your server socket is listening on like this:
$server = new Server('[::]:80', $loop);

See https://github.com/reactphp/socket#server for more details.
I hope this helps :+1:


Bump sync-nats feature dependency to latest sync-nats release which fixes CVE

Please see latest release here
Please see example PR on a fork of this repo synced to the main branch here

I just realized I'm dumb. I think the way y'all have nats = { version = "0.24.0", optional = true } will just select the highest 0.24.x to 0.25.0 so this issue is not necessary. See specifying dependencies from the cargo book


Choosing the value of alpha and beta

In the research paper, it is mentioned that alpha = 0.05 for short text collections and =50/K for normal text collection and beta = 0.01. Should we proceed with the default values mentioned in the runExample.sh?

Yes, this parameter setting is fine in most of data I tested. However, the
best values of these parameters depend on data.
2017-10-31 14:01 GMT+08:00 deepikay<EMAIL_ADDRESS>
In the research paper, it is mentioned that alpha = 0.05 for short text
collections and =50/K for normal text collection and beta = 0.01. Should we
proceed with the default values mentioned in the runExample.sh?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xiaohuiyan/BTM/issues/15, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHMkgkl4ycLroTNPffPQD6DtS71cZFSuks5sxrfIgaJpZM4QMQB3
.


1.0.1 update

tried to update to the latest version, i uninstalled / deleted any files relating to the previous version. upon doing a fresh install the program would fail to update all assets, after closing down that page the program would load but I would be unable to download anything. Ive got screenshots of this + the error console.
Noticed the error console talked about "movies.txt (access denied) and what had downloaded in my files wasnt a .txt file but a folder (screenshot provided) after downloading the correct "movies.txt" and deleting the folder the program loaded.

Ah my mistake ok thank you for reporting.
I was in a rush and didn't really test that.
I will fix this alongside the other issues in a bit

This issue has fixed in: 1.0.2


Implemented rough draft of check write mode.

This is an attempt to address #2536. Of the items to handle in the list, this PR handles:

[x] check to the rustfmt bin options
[x] implement check like diff mode, but with different exit codes.

It does not, at press time:

[ ] document the check mode
[x] add a test to make sure this works.

I'll add the latter two this weekend.
(This PR is somewhat clunky, as I was able to propagate WriteMode by adding an additional field to the Summary struct. Alternatives include returning a FmtResult<(Summary, Option<WriteMode>)>, but that felt messy.)

In commit 533df58, I introduced a simple test case for --write-mode=check using assert-cli, but that introduces a new dependency, and I'm not sure that's a good decision. If introducing this dependency is okay, I'd happily write some additional test cases for the other WriteModes and/or introduce more testing for the CLI options.
Additionally, in commit b0ece6b5, I've documented the check option in the README.
I'm not too happy with how I'm handling propagation of WriteMode—I feel like I'm using the Summary struct as a de-facto context object. Would appreciate advice on handling this better.

Thanks for the PR! The 'hard' bit of running the new write mode looks great. I agree that it would be better to avoid adding the write mode to the summary and have suggested a possible solution in a review comment.
I think adding assert-cli as a dev-dependency is fine. Would be good to test a few of the exit code situations.

Thanks for the PR! The 'hard' bit of running the new write mode looks great. I agree that it would be better to avoid adding the write mode to the summary and have suggested a possible solution in a review comment.

Thanks! Will address shortly.

I think adding assert-cli as a dev-dependency is fine. Would be good to test a few of the exit code situations.

Sounds good, I'll write test cases for those. Should I move the assert-cli tests away from main.rs, or...?

So far:

Added better documentation for WriteMode::Check, both in --help and README.md.
Implemented Default for WriteMode, where default is Overwrite. This removes several Options in summary and main.

Still to do:

Refactor/simplify exit codes (I think the acceptance criteria for this PR should be this.)
Write assert-cli tests for the new exit code system.

Sorry for the delay; work happened. I correct the exit code handling as I understood https://github.com/rust-lang-nursery/rustfmt/issues/1977#issuecomment-372167773. I'd like to clarify—should I log cause with eprintln! for non-zero exit codes?

should I log cause with eprintln! for non-zero exit codes?

Yes, I think there should be some kind of error message. However, if we're emitting errors or warnings or whatever anyway, then I don't think we need to emit an additional message.

Sorry about the slowness on my end. I've been on-call at work, but that's over. With the coming holiday, I should be able to devote some time to landing this issue. Anyways:

I updated the README.md as per @nrc's suggestion.
Made the exit-code handling less bad.
Moved WriteMode out of the summary, handling parsing in fn main() {...}

That being said, the way I'm handling WriteMode isn't great. I think if I'm to refactor how exit code handling and argument parsing are handled, I'd like to use StructOpt, but I'd like to be sure that it's okay I introduce this dependency. Thoughts?

I'd like to use StructOpt, but I'd like to be sure that it's okay I introduce this dependency. Thoughts?

How does using StructOpt help? I'm kind of OK (I like StructOpt), but worry it might be churn for no benefit.

How does using StructOpt help? I'm kind of OK (I like StructOpt), but worry it might be churn for no benefit.

I had some more time to think about it—it won't. Oops.

@davidbarsky How's it going on this? Got any questions I can answer?

@nrc Hi Nick! Yes! Some guidance around changing fn execute. I'm thinking that, based off your suggestion above—quoted for reference:

I think that by moving some code around in the main function so that we know the write mode (i.e., process the opts outside of execute), then we don't need to save it into the summary.”

—fn execute can be broken into a function that handles the parsing of getopts/reading of configuration files, and another function than does the the actual formatting process. The results of the command/config parsing can threaded through main so that the result of the attempted run of rustfmt can be associated with the user's command config, thereby not overloading fn execute or Summary with extraneous information. Does this seem reasonable?
(apologies for the delay.)

Does this seem reasonable?

Yes, I think so

Will need to rebase on mainline, but this I'm getting errors with rustc-ap-rustc_errors. Main thing—I'm not sure how I can make the handling of WriteMode/exit codes better even with refactoring. I'd like to avoid holding up further work/progress on this, I'll post what I've got. If this isn't what y'all are looking for, feel free to take this work and build atop of it/drop it.

Okay, rebased. Should be conflict-free.

This looks great, thank you!


Profile tab behaviour different if swiped or tapped

Tap on ‘Profile’: a ‘Sign In’ sheet is shown.
Swipe right to Profile view: a blank screen is shown. (In addition, the icon in this state is grey whereas on other tabs the selected tab icon is blue)

This was an issue with initial not-logged in state. This is fixed in the next beta.


Tenor Api key not working

Hi! I can't get my tenor api key to work with gif search. I got the key from my google console and it's still not working. I feel like I'm missing something big but idk what. I'm pretty stuck so any help is appreciated! 😭

Did it get fixed? @arjavpd

nope. got a api key from https://tenor.com/gifapi/documentation#quickstart and then pasted it in my gif search component but it didn't work :(

I think the issue is with tennor V2 tokens , here they use V1 API call for tenor.
https://github.com/Thanasis1101/react-native-gif-search/blob/ccc124ff20ae55606f38cc66133c715e78c6f3e1/src/GifSearch.js#L19

gonna have to patch the module, @rogueloop have you done that?

https://twitter.com/d4rkcyph3r/status/1655904564095356929?t=rJ3SKrPWFusF6yxUTHvkMA&s=19

I am also facing same problem with tenor V2 tokens, got the tenor api key from here : https://tenor.com/gifapi/documentation#quickstart but it is not working , please suggest me any possible solution ?

Try this plugin https://github.com/HexmosTech/expo-tenor-search


transport: Error while dialing dial tcp [::]:6060

Issue reporting
Am running clair on minikube and am getting the error in the logs
{"Event":"Start fetching vulnerabilities","Level":"info","Location":"ubuntu.go:88","Time":"2017-12-17 23:10:41.165052","package":"Ubuntu"}
{"Event":"Start fetching vulnerabilities","Level":"info","Location":"alpine.go:52","Time":"2017-12-17 23:10:41.165317","package":"Alpine"}
{"Event":"Start fetching vulnerabilities","Level":"info","Location":"debian.go:63","Time":"2017-12-17 23:10:41.165986","package":"Debian"}
{"Event":"Start fetching vulnerabilities","Level":"info","Location":"oracle.go:119","Time":"2017-12-17 23:10:41.166213","package":"Oracle Linux"}
{"Event":"Start fetching vulnerabilities","Level":"info","Location":"rhel.go:92","Time":"2017-12-17 23:10:41.166555","package":"RHEL"}
2017/12/17 23:10:42 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:10:43 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:10:46 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:10:50 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:10:57 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
{"Event":"finished fetching","Level":"info","Location":"updater.go:290","Time":"2017-12-17 23:10:58.348510","updater name":"alpine"}
2017/12/17 23:11:07 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:11:24 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
{"Event":"finished fetching","Level":"info","Location":"updater.go:290","Time":"2017-12-17 23:11:36.645906","updater name":"debian"}
2017/12/17 23:11:53 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:12:36 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:13:38 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:15:25 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
{"Event":"could not get notification to send","Level":"warning","Location":"notifier.go:132","Time":"2017-12-17 23:15:41.159017","error":null}
2017/12/17 23:17:41 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:19:50 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
{"Event":"could not get notification to send","Level":"warning","Location":"notifier.go:132","Time":"2017-12-17 23:20:41.258043","error":null}
2017/12/17 23:22:11 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
2017/12/17 23:24:08 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
{"Event":"could not get notification to send","Level":"warning","Location":"notifier.go:132","Time":"2017-12-17 23:25:41.381871","error":null}
2017/12/17 23:26:25 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp [::]:6060: connect: cannot assign requested address"; Reconnecting to {[::]:6060 }
Why am i getting this error what are the config files and if you can provide the samples

Why am i getting this error what are the config files and if you can provide the samples

Hi @vyasprashant, looks like everything you need should be in the Clair repo.
https://github.com/coreos/clair/blob/master/Documentation/running-clair.md#deployment-strategies

transport: Error while dialing dial tcp [::]:6060: connect

I am not sure but using ipv6 vs ipv4 could be the root of the issue. Is Clair listening on ipv6? sudo netstat -ptln | grep 6060
In general, this is a Clair config issue vs etcd issue it seems.

I agree with @hexfusion that this is a clair rather than etcd issue. So closing here.


Nextjs example showing { Invariant Violation: Argument of 'query' passed to parser was not a valid GraphQL DocumentNode }

Hi, I was using this plugin v2.3.5 with nextjs with-apollo example. I have set up .babelrc according to instruction and took out the graphql query in PostList.js component to file allPosts.graphql. However I kept getting
{ Invariant Violation: Argument of   query allPosts($first: Int!, $skip: Int!) {
    allPosts(orderBy: createdAt_DESC, first: $first, skip: $skip) {
      id
      title
      votes
      url
      createdAt
    }
    _allPostsMeta {
      count
    }
  }
 passed to parser was not a valid GraphQL DocumentNode. You may need to use 'graphql-tag' or another method to convert your operation into a document

Could it be babel-core v6.26.0 that's causing this? I have uploaded the repo here https://github.com/flexlee/with-apollo-app. It would be nice to have a working example. Thank you.

It looks like you have the first line of your graphql file indented. My package doesn’t currently trim or account for leading whitespace on the first non-comment line and checks that it starts with “query”, “mutation”, “subscription”, or “fragment”. I’ll make the check a little more robust later but for now just remove the spaces at the beginning of line 1 of the allPosts.graphql file.

Sorry, I fixed the indention. But it's giving me the same error.

@detrohutt you're right. It works now. Thanks.


Update Developer Guide Shashah

Each member should describe the implementation of at least one enhancement she has added (or planning to add).
Expected length: 1+ page per person
The description can contain things such as,

How the feature is implemented (or is going to be implemented).
Why it is implemented that way.
Alternatives considered.

Issue resolved


connection.commit() does not immediately commit the transaction to the Azure Synapse SQL pool

Question
Hi JDBC team, I'm from Azure Data Factory team and recently we are working on a project where we use JDBC (8.4.0) to send some T-SQL to an Azure Synapse SQL pool and manage transactions by ourselves within a Spark application. Below is our typical pattern:
connection.setAutoCommit(false);
// do some DMLs
connection.commit();
// Reuse the connection to do a new transcation immediately after the commit().
We find after the commit(), the transaction is not immediately committed to Synapse. I searched and found a relevant issue #872 which seemd to focus on the issue of setAutoCommit() instead of commit(). Based on the information from that issue, currently I added a setAutoCommit(true) after the commit() as a workaround and it did implicitly do the commit.
connection.commit();
connection.setAutoCommit(true);
But the semantics looks very weird because a commit() does not actually commit the transaction but a setAutoCommit(true) does...
So here comes my question: is this by design or a known bug? What should I do (what function/method should be called) to guarantee that a transaction is committed? In our scenario, the order of transaction commit is quite important, we must know for sure a transaction is committed before we go to the next one.
BTW, we have a similar issue on Stackoverflow: https://stackoverflow.com/questions/48300627/transaction-not-getting-completed-after-commit-in-azure-sql-data-warehouse
Your suggestions are much appreciated. Thanks.
Relevant Issues and Pull Requests
#872

Hi @lewischeng-ms, I'd like to look into this myself, but the team is busy with an official release that's scheduled for end of this month. We will look into this issue as soon as we have some bandwidth.

Hi @lewischeng-ms, I'd like to look into this myself, but the team is busy with an official release that's scheduled for end of this month. We will look into this issue as soon as we have some bandwidth.

As a note, I tried this with SQL Server and this behavior couldn't be reproduced, so this has to be related to the difference in Azure Synapse's behavior.

As a note, I tried this with SQL Server and this behavior couldn't be reproduced, so this has to be related to the difference in Azure Synapse's behavior.

@peterbae Thanks for the response. Yes, exactly. There is no issue with SQL Server or Azure SQL DB. As noted in the StackOverflow question, the issue only happens when we use mssql-jdbc to connect to Azure SQL DW (Synapse).

@peterbae Thanks for the response. Yes, exactly. There is no issue with SQL Server or Azure SQL DB. As noted in the StackOverflow question, the issue only happens when we use mssql-jdbc to connect to Azure SQL DW (Synapse).

Today I took a look into the JDBC source code myself and found the root cause.
First, my previous thought was incorrect.The issue was NOT that JDBC commit() does not commit the transaction. It does but it’s just that we cannot execute any DDL after commit() other we would get an error “111212;Operation cannot be performed within a transaction.” which misled me to think the previous transaction was not immediately committed.
The real cause is:
According to https://docs.microsoft.com/en-us/sql/t-sql/statements/set-implicit-transactions-transact-sql?view=sql-server-ver15#remarks, when we turn off implicit transaction (because we want to control transaction on our own), even a DDL like CREATE TABLE statement would automatically trigger a BEGIN TRANSACTION, which begins a user-defined transaction. As a note that, when we turn on implicit transaction, it’s NOT a user-defined transaction.
But according to https://docs.microsoft.com/en-us/azure/synapse-analytics/sql-data-warehouse/sql-data-warehouse-develop-transactions#limitations, Synapse SQL pool does not support any DDL within a user-defined transaction so any CREATE TABLE statement would fail.
As you can see, these two implicit automatic server behaviors are actually contrary. It’s not JDBC’s problem. You just can never issue any DDL when implicit transaction is turned off in Synapse SQL pool.
The solution is simple: we just turn on implicit transaction by conn.setAutoCommit(true) before executing any further DDL.

Today I took a look into the JDBC source code myself and found the root cause.
First, my previous thought was incorrect.The issue was NOT that JDBC commit() does not commit the transaction. It does but it’s just that we cannot execute any DDL after commit() other we would get an error “111212;Operation cannot be performed within a transaction.” which misled me to think the previous transaction was not immediately committed.
The real cause is:
According to https://docs.microsoft.com/en-us/sql/t-sql/statements/set-implicit-transactions-transact-sql?view=sql-server-ver15#remarks, when we turn off implicit transaction (because we want to control transaction on our own), even a DDL like CREATE TABLE statement would automatically trigger a BEGIN TRANSACTION, which begins a user-defined transaction. As a note that, when we turn on implicit transaction, it’s NOT a user-defined transaction.
But according to https://docs.microsoft.com/en-us/azure/synapse-analytics/sql-data-warehouse/sql-data-warehouse-develop-transactions#limitations, Synapse SQL pool does not support any DDL within a user-defined transaction so any CREATE TABLE statement would fail.
As you can see, these two implicit automatic server behaviors are actually contrary. It’s not JDBC’s problem. You just can never issue any DDL when implicit transaction is turned off in Synapse SQL pool.
The solution is simple: we just turn on implicit transaction by conn.setAutoCommit(true) before executing any further DDL.


Question on case 010_clb_lutinit

I'm researching on principles working on  fuzzer cases. But I could not understand  top.v.
What are the principles of function "xorshift32/hash32/hash64" ?

What should I take into account when modify  top.v or write my own 'top.v'?

@mithro Hi, would you give me some suggestions on how to understand fuzzer cases or how I add a new verilog and ensure cover bits completely?

@mithro I just want to know how to verify if these fuzz cases like top.v can generate a complete function-bits set.


Create a task to update file permissions

Create a task to update file permissions of configurable directories and files.
Related issue: #7

Moving this issue to 0.2.0 because of the pending due date of 0.1.0.

Maybe allow acl when available

I'm working on a PR for this issue. However at this point your desired solution is unclear to me...
On what level do you want the permissions to change? Possibilities are the release directory, the directory of the version it's installing, recursive, non-recursive...
Do you want to configure the directory in your accompli json? Do you want the possibility to configure the permissions per directory...?

IMO it should should be configurable which directories/files should be writable by the group the webserver (/apache) runs under. All other directories should not be writable.

So you shouldn't be able to configure an entire set of permissions, like: 0770 for example? Just the directories?

From a flexibility point of view it would be nice. Though, from a security point of view I'd rather not support making something world writable.

Would something like this suffice?
{
    "class": "Accompli\\Task\\FilePermissionTask",
    "paths": {
        "a/path/within/release": {
            "recursive": true|false,
            "userRead": true|false,
            "userWrite": true|false,
            "userExecute": true|false,
            "groupRead": true|false,
            "groupWrite": true|false,
            "groupExecute": true|false
        }
    }
}

How about changing the group?
{
    "class": "Accompli\\Task\\FilePermissionTask",
    "paths": {
        "a/path/within/release": {
            "recursive": true|false,
            "permissions": "-rwxrwxr-x",
            "group": "www-data"
        }
    }
}

Trying to make something world writable should throw an exception

Changing the group would require administrator rights through something sudo on Linux-based systems. sudo expects a password unless configured as NOPASSWD (which is insecure in my opinion).
Actually providing a password by Accompli is not really doable at the moment, but could be solved by something I'm working on with #177.
This task should focus on permissions for now, not ownership.

A user (owner) can change the group without needing any superuser rights, no password needed.
Only changing the owner is a superuser thing, because you could incriminate someone for instance. When acl is available even the required user can be added

Ok. Guess I was doing something wrong with that then. :smiley:
Your proposal would create a more compact configuration.
Adding group ownership would probably make the name Accompli\Task\FileOwnershipPermissionTask more appropriate? Or just stay with the previous one?

FilePermissionTask is fine


[FEATURE REQ] Add github actions and update github templates to handle issues in spring-cloud-azure repo.

Context
There are still some opened issues in repo microsoft/spring-cloud-azure.
This repo is only used to host our Spring Cloud Azure reference docs, any issue about Spring Cloud Azure is recommended to create in Azure/azure-sdk-for-java/issues .
We could do something to remind our users to create issues in  Azure/azure-sdk-for-java/issues instead of microsoft/spring-cloud-azure/issues
Goals

[ ] Add a section in readme to remind users create Spring Cloud Azure related issues in  Azure/azure-sdk-for-java/issues.
[ ] Add github actions to use a bot to reply new created issues in microsoft/spring-cloud-azure/issues automatially with reminder: Suggest users to create Spring Cloud Azure related issues in  Azure/azure-sdk-for-java/issues .
[ ] Update github templates in microsoft/spring-cloud-azure to remind users create Spring Cloud Azure related issues in  Azure/azure-sdk-for-java/issues.

If this works for microsoft/spring-cloud-azure, we should also take care of other repos.
A repos checklist:
Issues in MicrosoftDocs/azure-dev-docs
Issues in Azure-Samples/azure-spring-boot-samples
Issues in microsoft/azure-spring-boot
Issues in microsoft/spring-cloud-azure
Issues in microsoft/spring-data-cosmosdb
Issues in microsoft/spring-data-gremlin


[Bug]: Remove 300 ms delay from fetchDynamicValues flow

Is there an existing issue for this?

[X] I have searched the existing issues

Description
We are waiting for 300ms when fetching dynamic values after we get the notification that evaluations are complete to allow for the data tree to be updated. We can work to remove this delay by

Hooking up the trigger to a different action that notifies when the new tree is ready
Create a non-blocking wait/delay.

Steps To Reproduce
This is part of a code optimisation, the new effects can be seen in dynamic value fetching.
Public Sample App
No response
Version
Cloud

Verified it based on regression


Remove microbenchmarks

Cherry-pick of @apavlo's sequences refactor to remove the microbenchmarks.

Coverage increased (+0.01%) to 77.158% when pulling 3922384bd73349a86038eb9c128b713c529dd11c on lmwnshn:remove_benchmarks into 2b67714fcbbf26b75c962e92afee374b4a5208de on cmu-db:master.


Add button via webui

Not ready for merge yet

Edit still missing, but I'd like to merge anyway because this is a massiv change already


Some leaked networked access in LibXML::Schema parsing

Just following recent activity on Perl 5 XML::LibXML. Github blead has recently disabled network access by default. However this is not enough to disabled the schema validator, fixed with https://github.com/shlomif/perl-XML-LibXML/commit/e29829f5aee40bb2f11cf77b426458abf80e8792
These Raku bindings currently have the same weakness, ie although !net is the default for parser contexts, this is not sufficient to disable Schema network access.

I want to look at globally setting the default external entity loader to :!net, and selectively re-enabling when requested for schema loading, ie secure by default (that's the plan anyway).

Err, there's a much more basic problem, which trumps this original ticket. f2e19a0093cf04ad4c06e78da6dd7322085f31f3 purports to disable networking, but seems to do the opposite. Compounded by a lack of appropriate testing.
The following is returning 'True', instead of 'False'.
$ perl6 -I . -e'use LibXML; say LibXML.new.network'
Will fix in both the Parser and Schema loader.

Fixed options. Set Schema default to :!network.  Released as 0.2.0.


checks 7.122 and 7.116 fail due to Missing Glue permissions

prowler returns these errors:
7.122 [extra7122] Check if Glue ETL Jobs have Job bookmark encryption enabled. - glue [Medium]
An error occurred (AccessDeniedException) when calling the GetSecurityConfiguration operation: User: arn:aws:sts::XXXXXXXXXXXX:assumed-role/ProwlerExecRole/prowler is not authorized to perform: glue:GetSecurityConfiguration because no identity-based policy allows the glue:GetSecurityConfiguration action
7.116 [extra7116] Check if Glue data catalog settings have metadata encryption enabled. - glue [Medium]
An error occurred (AccessDeniedException) when calling the SearchTables operation: User: arn:aws:sts::XXXXXXXXXXXX:assumed-role/ProwlerExecRole/prowler is not authorized to perform: glue:SearchTables on resource: arn:aws:glue:us-east-1:XXXXXXXXXXX
the permssions glue:SearchTables and glue:GetSecurityConfiguration need to be added to the configuration files create_role_to_assume_cfn.yaml and prowler-additions-policy.json located in prowler/iam.

HI @Jae-Danner,
With the above message we can't identify what's happening.
Please, try to execute Prowler with the following bash -x ./prowler -options > debug.log 2>&1 then attach here debug.log
Also, complete the following information:
From where are you running Prowler?

Resource: [e.g. EC2 instance, Fargate task, Docker container manually, EKS, Cloud9, CodeBuild, workstation, etc.)
OS: [e.g. Amazon Linux 2, Mac, Alpine, Windows, etc. ]
AWS-CLI Version [aws --version]:
Prowler Version [./prowler -V]:
Shell and version:
Others:

Thanks @Jae-Danner, glue:SearchTables  is already in there for next release 2.7 (in a branch so far), we´ll add glue:GetSecurityConfiguration as well.

we can close this one now since has been fixed in PR #995


Use UserNotifications to create/dismiss local notifications

This is an extension of #50; that PR adds support for enumerating/dismissing delivered notifications
by ID, but UserNotifications notifications and UILocalNotification notifications have a different set of IDs (a notification created using UILocalNotification will have an ID that does not match the
notification's ID in the UserNotifications world and hence cannot be used to dismiss that notification). This PR creates the notifications using UserNotifications if the user is on iOS 10 so that the IDs returned by localNotification can be used to dismiss the notifications after they are delivered.

Thanks for a great job!
Small question, this PR include #50 inside? Should check #50 and this together or only this one?

I think that merging this should automatically close #50, since I merged
those commits into this branch. I'm not positive, though.
On Aug 15, 2017 12:08 AM, "Ran Greenberg"<EMAIL_ADDRESS>wrote:

Thanks for a great job!
Small question, this PR include #50
https://github.com/wix/react-native-notifications/pull/50 inside?
Should check #50
https://github.com/wix/react-native-notifications/pull/50 and this
together or only this one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wix/react-native-notifications/pull/103#issuecomment-322393297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEoWdJ-kvIhK0WcNyFVHoN6T7AA5Tw31ks5sYUP9gaJpZM4O29m7
.

Can u plz check that all tests passed and the example project running without any errors?

Yes, I will double check in the morning
On Aug 15, 2017 12:17 AM, "Ran Greenberg"<EMAIL_ADDRESS>wrote:

Can u plz check that all tests passed and the example project running
without any errors?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wix/react-native-notifications/pull/103#issuecomment-322394662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEoWdKkSUolaCbzT5HeKs2znFj8jCqlxks5sYUYagaJpZM4O29m7
.

I rebased onto master and added a line so that categories get set properly for the new UN notifications. Tested on iOS 9 and iOS 10 and looks good to me

Thanks again for the hard work! 🤘


Reimplement NamedTuble#fetch(String) using a Trie

Instead of comparing each string key one by one, build a Prefix Tree at compile-time and make a single comparison per char. This improves performance by 16x on large named tuples and about 1.5x on smaller ones.
Large benchmark: https://gist.github.com/lbguilherme/c7249c408d2a226bdbb6892dda5e9ab2
Small benchmark: https://gist.github.com/lbguilherme/7dba63104c4b44d3adcd5bcc9f9d7c20
See #3143 and #2966

I like this 👍 . Since you have a brach in the logic for more than 16 keys of the same size I would say we need some specs to cover that. Just to be sure it does not break in the future.
Let's see if some else agree with this before.

I'm not sure about this, a named tuple is not to be used as a hash. They represent named arguments, to a method, and methods usually don't have many arguments. I'd rather have a short and simple implementation, even if a bit slower, than a complex, macro heavy one.
I'd need to find a real use case where big named tuples are used, and indexed with an arbitrary key.

If you have such a big datastructure, I don't see a point in using a NamedTuple as well.
A Hash has about the same lookup speed anyway, in this example it's even faster. But I had to cut down the number of entries in the NamedTuple since the compiler maxes at 300.
check every key   2.99  (334.04ms) (±24.93%) 341.02× slower
    trie lookup  34.87  ( 28.68ms) (± 9.12%)  29.28× slower
           hash   1.02k (979.55µs) (±11.60%)        fastest

https://gist.github.com/straight-shoota/cb903575c6dd86d1c6c86c372d842666

NamedTuple looks like returning value pattern, and eats less memory afair.
No more.

Closing because too complex, and NamedTuple shouldn't normally be used.


Python debugging fails to unpack env variables in launch args

@AjawadMahmoud commented on Wed Jul 10 2019
Issue Type: Bug
Using the following launch.js config:
		{
			"name": "Debug with env variables",
			"type": "python",
			"request": "launch",
			"env":{
				"FW_PACKAGE":"my_package",
				"FW_TEST":"test_name"
			},
			"program": "${workspaceFolder}/appd.py",
			"args": ["--env", "dev", "--packages", "${env:LIMP_PACKAGE}", "--test-flush", "--test", "${env:LIMP_TEST}"],
			"console": "integratedTerminal"
		}

I get in terminal:
cd 'd:\path\to\project'; ${env:FW_PACKAGE}='my_package'; ${env:FW_TEST}='test_name'; ${env:PYTHONIOENCODING}='UTF-8'; ${env:PYTHONUNBUFFERED}='1'; & 'C:\Python37\python.exe' 'c:\Users\USER\.vscode\extensions\ms-python.python-2019.6.24221\pythonFiles\ptvsd_launcher.py' '--default' '--client' '--host' 'localhost' '--port' '58452' 'D:\path\to\project/appd.py' '--env' 'dev' '--packages' '' '--test-flush' '--test' ''

As it's seen in the terminal debug command, it's failing to unpack both env variables although the command was prefixed with env variables setter. And to confirm the env variables are assigned I was able to print them in the terminal after the debug command failed, and I got the env variables with the respective values correctly.
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.18932

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6650U CPU @ 2.20GHz (4 x 2208)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (6.88GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

vscode-angular2-files
ale
1.6.2

githistory
don
0.4.6

jbockle-format-files
jbo
3.0.0

chat
kar
0.15.5

code-beautifier
mic
2.2.1

azure-pipelines
ms-
1.152.0

vscode-azureappservice
ms-
0.15.0

vscode-cosmosdb
ms-
0.10.2

python
ms-
2019.6.24221

azure-account
ms-
0.8.4

vsliveshare
ms-
1.0.488

vsliveshare-audio
ms-
0.1.59

vsliveshare-pack
ms-
0.3.2

team
ms-
1.149.2

(2 theme extensions excluded)

Note: This is not an extension issue, we're sending the right information to the Debug Adapter.

For reference, I created #77050 but was refused.

Any luck on this? @DonJayamanne, since you confirmed this is not python extension issue do you have any workaround?

Sorry, but I don't understand the intended behavior of the launch config from above.
In the launch config from above the "env" section defines "FW_PACKAGE" and "FW_TEST" but then later "LIMP_PACKAGE" and "LIMP_TEST" is used. How are they related?
In addition please note: the "env" section is passed to the debug extension which sets the environment for the target program.  The "env" section does not affect the VS Code environment variables and  the variables defined in the "env" section are not available for "${env:ENV_NAME}" variable substitution in the launch config.

@weinand, you are right I wrongly copied two different versions of the launch config when I was reporting this bug, but this mistake doesn't invalidate the report.
Also there seems a confusion here. Let me try to clear it with few points:

env attribute of Python extension launch config has the following description:

Environment variables defined as a key value pair. Property ends up being the Environment Variable and the value of the property ends up being the value of the Env Variable.

Passing any pair of key and value to env is correctly being captured by the process by prefixing the debug command with the setters of these pairs. The issue has sample debug command showing the correct variables being set BEFORE running the debugger.
Before launching the project with debugger, the env variables value is null, however after running it (at least once) I can print the value of the environment variable from [power]shell and get the coorect value, which means the prefixed setters to the debug command are doing correct job.
Even if I manually set the environment variable without using env attribute, I'm still getting empty values in launch args where the environment variables like {env:ANYTHING_WOULD_NOT_WORK} would always be translated into empty string.

Point 4 is what made me sure this was a bug when I first report it, because whether I'm using env or manually setting the environment variable before launching the debugger I'm still getting no hope.

The "env" attribute is implemented by the Python extension. Since VS Code does know what "env" is, it does not interpret "env" in any way (and it does not change any environment variables because of it).
The Python extension sees the "env" attribute, knows its semantic and can do something with it. But whatever the Python extension does with "env" it can not influence VS Code directly.
And since VS Code performs the variable substitution before the Python extension sees "env", the variable substitution can not be affected by "env" directly.

Closing since this works as designed:
VS Code's variable substitution is done before the command line is executed in a command prompt/terminal. As a consequence variable substitution cannot take into account anything that is the result of running a command in the command prompt/terminal.

@weinand, this makes sense now. Is this something Python extension team can manipulate or that this sequence can never be updated by an extension? IOW is this an extension bug that they are not timing env passing correctly or that vscode doesn't allow this to happen in the first place, therefore it should become a feature request?

@AjawadMahmoud this is neither a bug of an extension nor of VS Code. It is just a consequence of a design decision that we made for variable substitution in launch configs.


Vmix Support

Hi Community, i´m struggling trying to create a Vmix plugin for this amazing app. Can someone create it or help me in the process? Thanks!

Take a look here: https://github.com/Macro-Deck-App/Macro-Deck/wiki/Plugin-API
If you have any more questions, feel free to join our Discord server.


Add Node.js ESM compatibility (resolves #292)

Currently, if you try to import Human into a pure Node.js ESM project, it fails (see #292)
This change points the Node.js module resolver to use the Node version instead of the ESM one

this looks like a valid approach, i'll do some testing before merge.


Array.indexOf not supported in IE8

Array.indexOf is used in several places which is not supported in IE8 and the project says that IE8 is supported.. this causes problems.
ctrl.setActiveItem for example.

Closing as guidance for IE8 is given in Wiki which says to include shim.


Using Expanded-NodeId-Strings rather then regular NodeId-String in configuration

Example:
NodeId -> ns=2;s=IoTSensors
Expanded-NodeId -> nsu=http://myIoTSensorNamspace/UA;s=IoTSensors
In scenarios in which changes happen on the shopfloor (OPC UA Server) there is the chance that the NamespaceIndex changes and your configuration will be broken.
Using the NamespaceIndex in a configuration is not a good practice, you should consider switch to the Expanded-NodeId format which uses the NamespaceUri instead of the index. In order to leverage the benefits of the expanded format the OPC UA Client needs to:

Connect
read the NamespaceArray
convert the Expanded-NodeIds once to the correct Index (verification that, i am on the correct server with the correct namespaces, which i would expect)
continue with reading/subscribing/...

this would lead to a much more robust behavior of the OPC UA Client. And if something changes e.g. someone imports a UA-Model or a CS your config will still be valid. This is a issue most commercial products get wrong in implementation!

I have a need for this as well. I tried implementing a PR earlier but got stuck when I discovered I had to include the NamespaceArray in the ParseExpandedNodeIds function call.
func ParseNodeIDs(incomingNodes []string) []*ua.ExpandedNodeID {

	// Parse all nodeIDs to validate them.
	// loop through all nodeIDs, parse them and put them into a slice
	parsedNodeIDs := make([]*ua.ExpandedNodeID, len(incomingNodes))
	// Get NamespaceArray from the server
	// How do I do this?
	namespaceArray := []string{"http://opcfoundation.org/UA/"}

	for _, id := range incomingNodes {
		parsedNodeID, err := ua.ParseExpandedNodeID(id, namespaceArray)
		if err != nil {
			return nil
		}

		parsedNodeIDs = append(parsedNodeIDs, parsedNodeID)
	}

	return parsedNodeIDs
}

Do you have any suggestions on how to get the namespace array from the server?
Check out the draft here: #14

you need to read the value of the nodeid "i=2255" which is present in every server and then you need to resolve the namepace name with the index in the array.

Thanks, I will hopefully have time to give it a try this coming week 🙂


Regression: Memchr not compatible with no_std (since 834d442)

Memchr relies on libc, which is not available in a no_std context. The result is the following error:
error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-unknown-none` target may not be installed

error: aborting due to previous error

error: Could not compile `libc`.

try to compile with `default-features = false" ?

I attempted to compile nom with default-features = false, unfortunately I don't believe there's a way to influence the libc compilation. If I go one commit before, it works perfectly, though does indeed give the same error if I re-enable default-features.

I think with https://github.com/rust-lang/cargo/pull/712 (original idea here https://github.com/rust-lang/cargo/issues/633#issuecomment-59089252 ) it can be achievable.
I probably won't have the time to test this until thursday, would you be willing to test and make a patch for it?

Sure, I'll take a look into that over the next day or two. Thanks for your help, I'll report back here after my investigations.

your fix is released in nom 3.1, thank you for your help!


get_or_create returns an AuthToken with token_key, digest, salt  = '' when creating the first instance of AuthToken.

Steps to reproduce: (in django shell)

user = YourCustomUser.objects.get(username='your_username')
AuthToken.objects.all().delete()
token, created = AuthToken.objects.get_or_create(user=user)
token.token_key

Here the token will have empty strings for token_key, digest and salt fields when the AuthToken is created for that specific user for the first time. When you run the get_or_create command again, it returns the created Token without issues.
Of course, get_or_create throws error when multiple tokens exist for the User. Which is expected behaviour.
Also, in the admin interface, I cannot delete this bugged out token. Although I can use token.delete() in my Django shell.

This also ties to TokenCreateView.
When you post to the endpoint it tries to run the get_or_create method and returns an empty token or throws an exception because more than one token exists.
If no tokens exist, it returns an empty token because it never reaches the model manager create method. I am not sure the best approach but it seems like the utils.login_user could be updated to do some manual checking for latest token or running the create method if one does not exist.
I don't mind trying to fix and do a PR if that makes sense, but again, not sure the best way to address this issue.


Adding HappyBase system tests for families and counters.

These tests exposed an issue with regex filters. When a protobuf bytes field received a unicode object, bad things happened.

@tseaver PTAL

@tseaver LGTY to merge?

LGTM


Empty response after session.create

When I try to create a new session with this code:
var Client = require('./client/v1');
var device = new Client.Device('myuser');
var storage = new Client.CookieFileStorage(__dirname + '/cookies/myuser.json');

const promise = new Client.Session.create(device, storage, "myuser", "mypassword");
console.log(promise);

I receive an empty response beacuse the Client.Session.create return this":
Promise {   _bitField: 0,   _fulfillmentHandler0: undefined,   _rejectionHandler0: undefined,   _promise0: undefined,   _receiver0: undefined }
Note: I use var Client = require('./client/v1') beacuse var Client = require('instagram-private-api').V1; return an error.
Please help me XD

I had a similar issue, however it was because i was using express. As soon as a I switched to vanilla node it worked for me.

try using this to get the error
var Client = require('./client/v1');
var device = new Client.Device('myuser');
var storage = new Client.CookieFileStorage(__dirname + '/cookies/myuser.json');

try{
const promise = new Client.Session.create(device, storage, "myuser", "mypassword");
console.log(promise)
}catch(err){
 console.log(err)
}


spop count argument missing

http://redis.io/commands/spop
vs
def spop[R: ByteStringDeserializer](key: String): Future[Option[R]]
Happy to submit a patch later today.

Hi,
Go ahead
Probably something new in 3.0
On Mon, Feb 29, 2016, 19:33 Shikhar Bhushan<EMAIL_ADDRESS>wrote:

http://redis.io/commands/spop
vs
def spop[R: ByteStringDeserializer](key: String): Future[Option[R]]
Happy to submit a patch later today.
—
Reply to this email directly or view it on GitHub
https://github.com/etaty/rediscala/issues/130.

@etaty you are right! it's only from 3.2

@etaty will you implement the extra argument? I just accessed the latest version and it is still not there.
Thank you


Cut v1.21.0

Required PRs

https://github.com/kubernetes-sigs/cri-tools/pull/737
https://github.com/kubernetes-sigs/cri-tools/pull/739

Proposed release notes
# Changelog since v1.20.0

## Changes by Kind

### Feature

- Added `*.sha256` sum files to release artifacts ([#717](https://github.com/kubernetes-sigs/cri-tools/pull/717), [@saschagrunert](https://github.com/saschagrunert))

### Bug or Regression

- Fixed `StartedAt` and `FinishedAt` of the container status ([#724](https://github.com/kubernetes-sigs/cri-tools/pull/724), [@Iceber](https://github.com/Iceber))
- Moved all test images to the `gcr.io/k8s-staging-cri-tools` registry ([#733](https://github.com/kubernetes-sigs/cri-tools/pull/733), [@saschagrunert](https://github.com/saschagrunert))

### Uncategorized

- Add support for mips64le architecture as release-artifact ([#719](https://github.com/kubernetes-sigs/cri-tools/pull/719), [@houfangdong](https://github.com/houfangdong))

Done :heavy_check_mark:


Fix Locale & KeyPairGeneratorSpec deprecation warnings

This commit resolves a few deprecation warnings by implementing dedicated methods:

config.locale=locale has new method setSystemLocaleLegacy  , otherwise config.setLocale(locale)
context is set by new method setContextConfigurationLegacy ,otherwise context = context.createConfigurationContext(config);
AlgorithmParameterSpec is obtained with new method makeAlgorithmParameterSpecLegacy, otherwise same as before

Thanks @0biWanKenobi


Bootstrap configurations sorting does not work

Looks like BootstrapApplicationListener has typo:
125            List<Class<?>> sources = new ArrayList<>();
               ...
136            builder.sources(sources.toArray(new Class[sources.size()]));
137            AnnotationAwareOrderComparator.sort(sources);
138            final ConfigurableApplicationContext context = builder.run();

Another problem is that AnnotationAwareOrderComparator is from spring core and does not know anything about AutoConfigureBefore/After annotations. I found AutoConfigurationSorter in spring-boot-autoconfigure project, but it has package level protection.

What typo?
AutoConfigureBefore/After are unrelated to bootstrap configuration, so I wouldn't expect them to be involved here.

What typo?

Sources is set to builder (line 136), before sorting (line 137).

AutoConfigureBefore/After are unrelated to bootstrap configuration, so I wouldn't expect them to be involved here.
Ok, thank you.

Ok. Thanks for the clarification. To me, a typo is a misspelling. That just looks like a bug :-)


arima and sarimax init value

In version 1.0.2 to 1.0.5, the init value of quniform HPs in arima and sarimax is int which doesn't pass the validity check. So these init values are not respected.
I propose a change in PR #575 .
Also, I suggest adding a performance test like https://github.com/microsoft/FLAML/blob/619107edf504905b069e0ca77f117f8aca32d042/test/automl/test_notebook_example.py#L73 for the forecasting task (@int-chaos ) as well as the nlp tasks (@liususan091219 ) to prevent similar issues to happen.

Hi I see a merged PR for this issue
Is there something left to close this issue?


README IN FRENCH

Just thought its a good repo and the more understand it the better it is.

Please just fork the repo, translate the README to your native language then make a PR to include the actual link to your translated repo, example:
[French Translation by Bansalhere](link to your translated repo here)


README for creating a LabVIEW measurement is out-of-date

Bug Report
https://github.com/ni/measurement-plugin-labview/blob/main/docs/README.md is out of date and needs to be updated.

There is now a UI library and a measurement library in the template.
The UI and template are much more complicated than a simple array in / array out. Update instructions and screenshots.

Your Environment

OS & Device: Windows
ni-measurement-plugin-sdk-service version <IP_ADDRESS>

Test to get the AzDO sync to happen.


docs: Add nightly build and start API

Took a few guesses at the API.  I need
some guidance.

I'll be the bot for now.  PTAL.
https://nvidia-merlin.github.io/systems/review/pr-77/


Setup test sheet (MVP testing)

What
Test form for MVP
Test form necessities
About the subject

[ ] Knowledge of AR/VR (never tried, once, alot)
[ ] Skin color
[ ] Glasses
[ ] Sex and age

First configuration of MVP

[ ] Scale between 1-10 of realism, real window: 10. (for the XYZ configuration)

Testing 2nd and 3rd configuration

[ ] In comparison to the previous configuration, is there any improvement? (Way worse, ok, way better)

Testing for all configurations

[ ] Movement in real-world translate to the virtual world (5 steps, no correlation to complete mimic)
[ ] Comfort using the tool (very uncomfortable to no problem)

Test form


Example with react router?

This could be quite helpful.

Yes, it would.
Wanna take this @QuantumInformation ?

Hello guys. Is this being done? If not, maybe I could help out.
@matheusml

I've been snowed this month

@guilherme6191 and @QuantumInformation any of you still want this one?

yes pls

Ok @QuantumInformation

Anyone of you have used redux-zero with react-router before? I am having a problem with it. The store is emptied every time I navigate to a new page.

@usmanmunara do you have a fiddle to reproduce this?

STORE.JS
`import createStore from 'redux-zero';

const initialState = {todos: [], user:[], error: "", currentuser:{}};
const store = createStore(initialState);
export default store;`

ACTIONS.JS
`const actions = store => ({
increment: state => ({ count: state.count + 1 }),
decrement: state => ({ count: state.count - 1 })
});

export default actions;`

ROUTER.JS
`import React from 'react';
import {BrowserRouter, Route} from 'react-router-dom';

import { App } from './App';
import { Log } from './Components/LogSign/log-sign';
import MuiThemeProvider from 'material-ui/styles/MuiThemeProvider';
const Routers = () => (

);
export {Routers};`

I'm going to try on codesand today

Is that what you were talking about?
https://codesandbox.io/s/github/rmlSardinha/redux-zero-router/tree/master/
https://github.com/rmlSardinha/redux-zero-router

Thanks for this @rmlSardinha
Could you please add this to the project with a PR?

@rmlSardinha do you need some help?


Request for adding DeepCRISPR

We added DeepCRISPR in the "Guide design" section. If there remains any question, please inform us. Thanks!

Great. Thanks for your contribution!