Consumer batch API consumes last message multiple times

The following code demonstrates the problem:
kafka = Kafka.new(seed_brokers: ['kafka.server.local:9092'])
topic = "consumer-group-bug-#{Time.now.to_f}"

producer = kafka.producer
producer.produce('hello', key: 'world', topic: topic)
producer.deliver_messages

consumer = kafka.consumer(group_id: 'foo')
consumer.subscribe(topic)
consumer.each_batch do |message_batch|
  message_batch.messages.each do |message|
    puts "Received key=#{message.key}, value=#{message.value}"
  end
end

This outputs the following:
Received key=world, value=hello
Received key=world, value=hello
Received key=world, value=hello
Received key=world, value=hello
Received key=world, value=hello
Received key=world, value=hello
Received key=world, value=hello
Received key=world, value=hello
...

This was found in ruby-kafka 0.3.5 which includes the fix for #165.

Can you paste some log output?

Here's some log output:
New topics added to target list: consumer-group-bug-1461764323.689352
Fetching cluster metadata from kafka.server.local:9092
Opening connection to kafka.server.local:9092 with client id ruby-kafka...
Sending request 1 to kafka.server.local:9092
Waiting for response 1 from kafka.server.local:9092
Received response 1 from kafka.server.local:9092
Discovered cluster metadata; nodes: <IP_ADDRESS>:9092 (node_id=0)
Closing socket to kafka.server.local:9092
Failed to assign partitions to 1 messages
Failed to send all messages; attempting retry 1 of 2 after 1s
Fetching cluster metadata from kafka.server.local:9092
Opening connection to kafka.server.local:9092 with client id ruby-kafka...
Sending request 1 to kafka.server.local:9092
Waiting for response 1 from kafka.server.local:9092
Received response 1 from kafka.server.local:9092
Discovered cluster metadata; nodes: <IP_ADDRESS>:9092 (node_id=0)
Closing socket to kafka.server.local:9092
Current leader for consumer-group-bug-1461764323.689352/0 is node <IP_ADDRESS>:9092 (node_id=0)
Sending 1 messages to <IP_ADDRESS>:9092 (node_id=0)
Opening connection to <IP_ADDRESS>:9092 with client id ruby-kafka...
Sending request 1 to <IP_ADDRESS>:9092
Waiting for response 1 from <IP_ADDRESS>:9092
Received response 1 from <IP_ADDRESS>:9092
Successfully appended 1 messages to consumer-group-bug-1461764323.689352/0
Joining group `foo`
Getting group coordinator for `foo`
Sending request 2 to <IP_ADDRESS>:9092
Waiting for response 2 from <IP_ADDRESS>:9092
Received response 2 from <IP_ADDRESS>:9092
Coordinator for group `foo` is <IP_ADDRESS>:9092 (node_id=0)
Sending request 3 to <IP_ADDRESS>:9092
Waiting for response 3 from <IP_ADDRESS>:9092
Received response 3 from <IP_ADDRESS>:9092
Joined group `foo` with member id `ruby-kafka-5475e5a5-6596-4c18-b8f4-726cbdf31d79`
Chosen as leader of group `foo`
Sending request 4 to <IP_ADDRESS>:9092
Waiting for response 4 from <IP_ADDRESS>:9092
Received response 4 from <IP_ADDRESS>:9092
Partitions assigned for `consumer-group-bug-1461764323.689352`: 0
Sending request 5 to <IP_ADDRESS>:9092
Waiting for response 5 from <IP_ADDRESS>:9092
Received response 5 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset earliest
Resolving offset `-2` for consumer-group-bug-1461764323.689352/0...
Sending request 6 to <IP_ADDRESS>:9092
Waiting for response 6 from <IP_ADDRESS>:9092
Received response 6 from <IP_ADDRESS>:9092
Offset for consumer-group-bug-1461764323.689352/0 is 0
Sending request 7 to <IP_ADDRESS>:9092
Waiting for response 7 from <IP_ADDRESS>:9092
Received response 7 from <IP_ADDRESS>:9092
Received key=world, value=hello
Committing offsets for 1 messages
Sending request 8 to <IP_ADDRESS>:9092
Waiting for response 8 from <IP_ADDRESS>:9092
Received response 8 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset earliest
Resolving offset `-2` for consumer-group-bug-1461764323.689352/0...
Sending request 9 to <IP_ADDRESS>:9092
Waiting for response 9 from <IP_ADDRESS>:9092
Received response 9 from <IP_ADDRESS>:9092
Offset for consumer-group-bug-1461764323.689352/0 is 0
Sending request 10 to <IP_ADDRESS>:9092
Waiting for response 10 from <IP_ADDRESS>:9092
Received response 10 from <IP_ADDRESS>:9092
Received key=world, value=hello
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset 1
Sending request 11 to <IP_ADDRESS>:9092
Waiting for response 11 from <IP_ADDRESS>:9092
Received response 11 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset 1
Sending request 12 to <IP_ADDRESS>:9092
Waiting for response 12 from <IP_ADDRESS>:9092
Received response 12 from <IP_ADDRESS>:9092
Committing offsets for 1 messages
Sending request 13 to <IP_ADDRESS>:9092
Waiting for response 13 from <IP_ADDRESS>:9092
Received response 13 from <IP_ADDRESS>:9092
Sending heartbeat...
Sending request 14 to <IP_ADDRESS>:9092
Waiting for response 14 from <IP_ADDRESS>:9092
Received response 14 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset earliest
Resolving offset `-2` for consumer-group-bug-1461764323.689352/0...
Sending request 15 to <IP_ADDRESS>:9092
Waiting for response 15 from <IP_ADDRESS>:9092
Received response 15 from <IP_ADDRESS>:9092
Offset for consumer-group-bug-1461764323.689352/0 is 0
Sending request 16 to <IP_ADDRESS>:9092
Waiting for response 16 from <IP_ADDRESS>:9092
Received response 16 from <IP_ADDRESS>:9092
Received key=world, value=hello
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset 1
Sending request 17 to <IP_ADDRESS>:9092
Waiting for response 17 from <IP_ADDRESS>:9092
Received response 17 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset 1
Sending request 18 to <IP_ADDRESS>:9092
Waiting for response 18 from <IP_ADDRESS>:9092
Received response 18 from <IP_ADDRESS>:9092
Committing offsets for 1 messages
Sending request 19 to <IP_ADDRESS>:9092
Waiting for response 19 from <IP_ADDRESS>:9092
Received response 19 from <IP_ADDRESS>:9092
Sending heartbeat...
Sending request 20 to <IP_ADDRESS>:9092
Waiting for response 20 from <IP_ADDRESS>:9092
Received response 20 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset earliest
Resolving offset `-2` for consumer-group-bug-1461764323.689352/0...
Sending request 21 to <IP_ADDRESS>:9092
Waiting for response 21 from <IP_ADDRESS>:9092
Received response 21 from <IP_ADDRESS>:9092
Offset for consumer-group-bug-1461764323.689352/0 is 0
Sending request 22 to <IP_ADDRESS>:9092
Waiting for response 22 from <IP_ADDRESS>:9092
Received response 22 from <IP_ADDRESS>:9092
Received key=world, value=hello
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset 1
Sending request 23 to <IP_ADDRESS>:9092
Waiting for response 23 from <IP_ADDRESS>:9092
Received response 23 from <IP_ADDRESS>:9092
Fetching batch from consumer-group-bug-1461764323.689352/0 starting at offset 1
Sending request 24 to <IP_ADDRESS>:9092
Waiting for response 24 from <IP_ADDRESS>:9092

Yeah, this looks like a bug in the offset commit manager. This is tricky to get right – I'll try to get a fix in ASAP.

Can you try running against #174?

I'm sorry for the instability of the consumer API – it's still very much alpha, and I haven't had a chance to run it in production yet.

@dasch maybe you should distinguish that somehow in the readme? Producer works like a charm ;)

@mensfeld

@dasch Yeah I know but people tend to read only few first lines in the readme ;) you could put it on top of everything just to prevent people from using it (or just ot make them aware of the current state)

@mensfeld it's literally stated in the second paragraph of the README...

@dasch - Looks like #174 fixes the issue. We definitely know the consumer API is in alpha and aren't using it in production. Do you want use to continue testing it and filing issues or would you rather we hold off until you have time to stabilize it?

Awesome!
As long as you don't go to production with it I'd love for you to keep testing it. I'm also open to accepting PRs, although currently the consumer code is slightly messy.


Chinese README.md

README.md Chinese translation

Hey @mofengfs,
What's the benefit of having everything in Chinese? This is not an addition, this is just replacement. and I feel like having international version is better.

No response, not needed. thanks for your time. closing


Fix function comments based on best practices from Effective Go

Hi, we updated some exported function comments based on best practices from Effective Go. It’s admittedly a relatively minor fix up. Does this help you?

Thanks for your contribution! I rebased the patch onto master and merged it in fd8f41dc08b02ca6e19a823c7ef8ef8985ab377b.


Problem with installation. /lib/active_support/whiny_nil.rb:48:in method_missing': undefined method klass' for nil:NilClass (NoMethodError)

After running rails g rails_admin:install I was have this:
[34m           -  Hello, RailsAdmin installer will help you sets things up![0m
[32m           -  I need to work with Devise, let's look at a few things first:[0m
[32m           -  Checking for a current installation of devise...[0m
[32m           -  Found it![0m
[32m           -  Looks like you've already installed it, good![0m
[32m           -  And you already set it up, good! We just need to know about your ser model name...[0m
[32m           -  We found 'user' (should be one of 'user', 'admin', etc.)[0m
[33m           ?  Correct Devise model name if needed. Press  for [user] > [0m

Ok, Devise looks already set up with user model name 'user':
-  Now you'll need an initializer...
create  config/initializers/rails_admin.rb
/home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/whiny_nil.rb:48:in method_missing': undefined method klass' for nil:NilClass (NoMethodError)
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activerecord-3.1.1/lib/active_record/reflection.rb:393:in block in source_reflection'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activerecord-3.1.1/lib/active_record/reflection.rb:393:in collect'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activerecord-3.1.1/lib/active_record/reflection.rb:393:in source_reflection'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activerecord-3.1.1/lib/active_record/reflection.rb:538:in derive_class_name'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activerecord-3.1.1/lib/active_record/reflection.rb:128:in class_name'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activerecord-3.1.1/lib/active_record/reflection.rb:173:in klass'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/adapters/active_record.rb:329:in association_child_model_lookup'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/adapters/active_record.rb:103:in block in associations'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/adapters/active_record.rb:96:in map'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/adapters/active_record.rb:96:in associations'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/adapters/active_record.rb:90:in belongs_to_associations'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:20:in block in module:Fields'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:65:in call'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:65:in block (2 levels) in factory'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:65:in each'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:65:in find'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:65:in block in factory'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:61:in each'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/fields.rb:61:in factory'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/has_fields.rb:129:in _fields'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/has_fields.rb:127:in _fields'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/has_fields.rb:107:in all_fields'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/rails_admin/config/has_fields.rb:82:in fields'  from (erb):85:in block in template'
from (erb):82:in map'  from (erb):82:in template'
from /home/snake/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/erb.rb:753:in eval'  from /home/snake/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/erb.rb:753:in result'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/file_manipulation.rb:111:in block in template'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:54:in call'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:54:in render'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:63:in block (2 levels) in invoke!'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:63:in open'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:63:in block in invoke!'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/empty_directory.rb:114:in call'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/empty_directory.rb:114:in invoke_with_conflict_check'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:61:in invoke!'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions.rb:95:in action'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/create_file.rb:26:in create_file'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/actions/file_manipulation.rb:110:in template'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/bundler/gems/rails_admin-5579332f8a58/lib/generators/rails_admin/install_generator.rb:59:in install'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/task.rb:22:in run'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/invocation.rb:118:in invoke_task'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/invocation.rb:124:in block in invoke_all'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/invocation.rb:124:in each'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/invocation.rb:124:in map'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/invocation.rb:124:in invoke_all'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/group.rb:226:in dispatch'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/thor-0.14.6/lib/thor/base.rb:389:in start'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/railties-3.1.1/lib/rails/generators.rb:168:in invoke'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/railties-3.1.1/lib/rails/commands/generate.rb:12:in <top (required)>'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:240:in require'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:240:in block in require' from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:223:in block in load_dependency'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:640:in new_constants_in'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:223:in load_dependency'
from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/activesupport-3.1.1/lib/active_support/dependencies.rb:240:in require'  from /home/snake/.rvm/gems/ruby-1.9.2-p290@forestry/gems/railties-3.1.1/lib/rails/commands.rb:28:in <top (required)>'
from script/rails:6:in require'  from script/rails:6:in '

I am having a similar problem.  I am trying to upgrade from 3.0.0 to head.
/Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/whiny_nil.rb:48:in method_missing': undefined method context_class' for nil:NilClass (NoMethodError)
from /Library/Ruby/Gems/1.8/gems/sass-rails-3.1.5/lib/sass/rails/railtie.rb:61
from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/initializable.rb:30:in instance_exec'         from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/initializable.rb:30:in run'
from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/initializable.rb:55:in run_initializers'         from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/initializable.rb:54:in each'
from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/initializable.rb:54:in run_initializers'         from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/application.rb:96:in initialize!'
from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/railtie/configurable.rb:30:in send'         from /Library/Ruby/Gems/1.8/gems/railties-3.1.3/lib/rails/railtie/configurable.rb:30:in method_missing'
from /Users/bleach/dev/inventory/config/environment.rb:5
from /Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in require'         from /Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in require'
from /Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in load_dependency'         from /Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:640:in new_constants_in'
from /Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in load_dependency'         from /Library/Ruby/Gems/1.8/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in require'
from /Users/bleach/dev/inventory/config.ru:4
from /Library/Ruby/Gems/1.8/gems/rack-1.3.6/lib/rack/builder.rb:51:in instance_eval'         from /Library/Ruby/Gems/1.8/gems/rack-1.3.6/lib/rack/builder.rb:51:in initialize'
from /Users/bleach/dev/inventory/config.ru:1:in `new'
from /Users/bleach/dev/inventory/config.ru:1

I fixed this by running rake rails:update...

Me too. cbleach +1


Go test only checks main_test.go

https://github.com/nx-go/nx-go/blob/d6fe9430be4a11a1a5a4cce417d7f97efb7e881a/packages/nx-go/src/builders/test/builder.ts#L11
Uses go test /apps/name/**/*.go However this seems to only check the main_test.go. Perhaps apps/name/... might work better.
I can help if needed.

I think this needs to change from this:
export function runBuilder(options: BuildBuilderSchema, context: BuilderContext): Observable<BuilderOutput> {
  return from(context.getProjectMetadata(context?.target?.project)).pipe(
    map((project) => {
      const root = project.root
      const sources = `-v ${root}/**/*.go`

      return runGoCommand(context, 'test', [sources])
    }),
  )
}

to this:
export function runBuilder(options: BuildBuilderSchema, context: BuilderContext): Observable<BuilderOutput> {
  return from(context.getProjectMetadata(context?.target?.project)).pipe(
    map((project) => {
       const sources = `./... -v`;
        return runGoCommand(context, 'test', [sources], { cwd: project.root});
    }),
  )
}

I think this needs to change from this:
export function runBuilder(options: BuildBuilderSchema, context: BuilderContext): Observable<BuilderOutput> {
  return from(context.getProjectMetadata(context?.target?.project)).pipe(
    map((project) => {
      const root = project.root
      const sources = `-v ${root}/**/*.go`

      return runGoCommand(context, 'test', [sources])
    }),
  )
}

to this:
export function runBuilder(options: BuildBuilderSchema, context: BuilderContext): Observable<BuilderOutput> {
  return from(context.getProjectMetadata(context?.target?.project)).pipe(
    map((project) => {
       const sources = `./... -v`;
        return runGoCommand(context, 'test', [sources], { cwd: project.root});
    }),
  )
}

The best approach it would allow to allow any extra arg be passed extra, that would allowd to had for example -race

The best approach it would allow to allow any extra arg be passed extra, that would allowd to had for example -race

@beeman let me know if you want me to PR on this

@beeman let me know if you want me to PR on this

Also forgot about this, in the workspace.json it the builder needs to change from:
"test": {
  "builder": "@nx-go/nx-go:test",
  "options": {
    "main": "apps/api/main_test.go"
  }
}

to just:
"test": {
  "builder": "@nx-go/nx-go:test"
}

Also forgot about this, in the workspace.json it the builder needs to change from:
"test": {
  "builder": "@nx-go/nx-go:test",
  "options": {
    "main": "apps/api/main_test.go"
  }
}

to just:
"test": {
  "builder": "@nx-go/nx-go:test"
}

@beeman let me know if you want me to PR on this

Hey @Narven - I would really appreciate a PR! I should have some time this weekend en next weekend to look at nx-go!
I'm about to start a pet project that uses Go so I'll be using this again!

@beeman let me know if you want me to PR on this

Hey @Narven - I would really appreciate a PR! I should have some time this weekend en next weekend to look at nx-go!
I'm about to start a pet project that uses Go so I'll be using this again!

@beeman I do not have permissions to push a new branch

@Narven you can create a Pr by forking this repo and creating a branch on your fork. Then you should be able to open a PR here.

This is now fixed in version 1.3.0

The best approach it think, it would be to allow any extra arg be passed, that would allowd to had for example -race or -cover

Thanks for the suggestion! These are available and enabled by default in 1.4.0.


[Bug] Project fails to build due to incorrect STREQUAL usage in a submodule's CMake project

I'm using CMake 3.18.4.
CMake Error at firebase-cpp-sdk/external/src/firestore-build/external/src/abseil-cpp/CMake/AbseilHelpers.cmake:178 (message):
  Invalid build type: static
Call Stack (most recent call first):
  firebase-cpp-sdk/external/src/firestore-build/external/src/abseil-cpp/absl/base/CMakeLists.txt:42 (absl_cc_library)

The issue was fixed in abseil/abseil-cpp@22771d471930ce88e1e75d0ca9dd8c65a7b0f895.

Thanks..we will upgrade absl version to fix this.

Thanks..we will upgrade absl version to fix this.

@wu-hui Did this upgrade happen in the iOS SDK?

Is this fixed in 8.8.0? Can't seem to find any info.


Add a FromEither trait

There is an into_inner() method on Either<T, T> that can "unwrap" the inner value as long as both arms have the same type.
This is useful, but a more generic conversion could be implemented for any Either<A, B> to any type T that implements From<A> + From<B>.
Such a trait would be simple to blanket implement:
pub trait FromEither<A, B> {
    fn from_either(either: Either<A, B>) -> Self;
}

impl<A, B, T> FromEither<A, B> for T
where
    T: From<A> + From<B>,
{
    fn from_either(either: Either<A, B>) -> Self {
        match either {
            Left(a) => Self::from(a),
            Right(b) => Self::from(b),
        }
    }
}

Programmers would rarely implement this directly, but rely on the blanket implementation to kick in when they've implemented From for each arm of an Either on their type.
Why would this be useful? Consider an Iterator of Either values. One may with to transform those values into another enum:
#[derive(Debug)]
struct A;
#[derive(Debug)]
struct B;
#[derive(Debug)]
enum C {
    A(A),
    B(B),
}

impl From<A> for C {
    fn from(a: A) -> Self {
        C::A(a)
    }
}

impl From<B> for C {
    fn from(b: B) -> Self {
        C::B(b)
    }
}

fn main() {
    [Left(A), Right(B), Left(A), Right(B)]
        .into_iter()
        .map(C::from_either)
        .for_each(|c| {
            println!("{c:?}");
        });
}

If the arms are the same, we could use Either::into_inner as the function passed to map(). FromEither is useful specifically if the arms are different but still convertible to a common type.
My current workaround is to use map(|ab| ab.either(C::from, C::from)) in situations like this, which works, but is a little more verbose than map(C::from_either).

I think either_into<T> broadly meets this need -- your example can write .map(Either::either_into::<C>), or drive the type inference for C elsewhere like .map(Either::either_into).for_each(|c: C| ...). It's a little wordy, perhaps, but at least you don't need to import an extra trait to make it work.


Python exception: Waifu2x-caffe: only constant format 32-bit float input supported

I am just new to vapoursynth and I always get this error whenever loading a video file

I am using the portable version x64
and how do you actually output the waifued video file? not just preview

As the error message said, you must convert the bit depth of the clip to 32-bit first. You can use core.fmtc.bitdepth(clip, bits=32) to do the conversion. For outputting, the official documentation at http://www.vapoursynth.com/doc/gettingstarted.html#output-with-vspipe already has an example.

ok I managed to successfully preview the script, but when using VSPIPE
I am getting an error but it outputs yet the video file is like corrupted and the output frames is less than the input, (i.e the input has like 69 frames but the output is only 13 frames)
Here is the code:
import vapoursynth as vs import mvsfunc as w core = vs.get_core() clip=core.ffms2.Source(source=r"E:\Python35x64\boobiesagain.avi") clip=core.fmtc.bitdepth(clip, bits=32) clip=core.caffe.Waifu2x(clip, noise=1, scale=4, block=128, photo=True, cudnn=True, tta=False) clip.set_output()
vspipe --y4m wew.vpy - | E:\Downloads\ffmpeg-20160201-git-b62825a-win64-static\ffmpeg-20160201-git-b62825a-win64-static\bin\ffmpeg.exe -i pipe: encoded2.mkv
Here what vspipe is saying

Here what the output video looks like

You need to reduce the bit depth to 8 (or 10 if you're encoding in 10-bit) before clip.set_output(). Otherwise you are sending 32-bit video to the encoder and are likely to get garbage.

I set the code like this
import vapoursynth as vs core = vs.get_core() clip=core.ffms2.Source(source=r"E:\Python35x64\boobiesagain.avi") clip=core.fmtc.bitdepth(clip, bits=32) clip=core.caffe.Waifu2x(clip, noise=1, scale=4, block=128, photo=True, cudnn=True, tta=False) clip=core.fmtc.bitdepth(clip, bits=8) clip.set_output()
but instead of a total of 69 frames, the total frames output is 68 frames but otherwise I can now watch the output video is there a way to fix the incomplete output frame?

Well...I'm quite not fond of answering arbitrary questions which have nothing to do with the filter itself. Firstly, VapourSynth itself doesn't have official support for audio. You need to remux the audio stream from the source file with your encoded file. Secondly, it's the encoder(x264 or ffmpeg) to decide what quality(lossy or lossless) the output file will be, not vspipe.

ok thanks I am using ffmpeg when using vspipe so what commands to set it's quality specifically lossless?

Then you need to consult the documentation of ffmpeg yourself. I don't use ffmpeg for encoding. For x264, the option is --qp 0.

Thanks for when using the x264  vspipe can it accept RGB?

http://forum.doom9.org/showthread.php?t=163518
Again, we cannot give much advice about ffmpeg since we simply don't use it. For x264 it accepts RGB input without any problems, though with lower efficiency. YCgCo could be a better choice to preserve RGB color. Again, they are not common practices.


Use Image Devcontainer Step in GitHub Actions

This helps ensure that we get/cache the image in a unique job and then have other jobs :needs it.
https://github.com/rails-lambda/lamby_benchmark/commit/c3af7728acad23e9f2ae10558ac781d708201bcc

Seems like you already did this if you want to modify let me know


dist folder is missing

is the repo complete? instructions refer to files not present.

They are there: https://www.jsdelivr.com/package/npm/json-formatter-js

Sorry for highjacking this issue, but how should load this in my HTML page? Should I link to<EMAIL_ADDRESS>

@bretcamblempc @adrfantini or @mohsen1 I was curious if anyone figured out how to use this nice library through a CDN?


Is there anyway to provide offset?

Hi. great work. Is there any way we can add some top offset to the divs being monitored?

@raviayadav unfortunately not at the moment but it is something we can look to add in the future. I will try and look into this when I get a chance.

okay, thanks

I'm going to reopen this issue until we add this feature so we don't forget it.

+1

You can provide an offset for any

@tratohecho3, could you post an example?

  content...

  content...

  content...

Use the css that I already posted

Another way to offset the <sn-scroll-spy-section> component is to wrap it in a custom component and position absolute the <sn-scroll-spy-section> N pixels upwards to force the offset. That way the scroll spy active class will be added N pixels before it arrives at the top of your screen:
Wrapper component template:
<sn-scroll-spy-section
    class="scrollspy-trigger"
    ...
</sn-scroll-spy-section>
<ng-content></ng-content>

Wrapper component scss:
:host {
  display: block;
  position: relative;
}

.scrollspy-trigger {
  position: absolute;
  top: -60px;
  bottom: -60px;
  left: 0px;
  right: 0px;
}


Airflow integration is not reporting status changes in a timely manner

Describe the bug
We submit say 50 jobs via Airflow that jobs sleep 10s and exit
Airflow marks most jobs as completing in 10s - as expected
However a non-trivial (10-20%) number of jobs don't get marked as succeeded for 15m
Expected behavior
We would expect Airflow to mark the jobs as completed shortly after the JobSucceeded event is sent from Armada
Actual behavior
It is taking 15 minutes to detect the job has succeeded
Additional context
Logs from the Armada operator show it doesn't identify the job as completed for ~15minutes
AIRFLOW_CTX_DAG_RUN_ID=manual__2023-03-03T08:35:03.501508+00:00
[2023-03-03, 08:35:43 UTC] {armada.py:108} INFO - Running Armada job armada2 with id 01gtk9sqkrtsabz51r0gxzgfe3
[2023-03-03, 08:35:43 UTC] {armada.py:112} INFO - Lookout URL: <REDACTED URL>?job_id=01gtk9sqkrtsabz51r0gxzgfe3&newest_first=true
[2023-03-03, 08:51:21 UTC] {armada.py:121} INFO - Armada Job finished with JobState.SUCCEEDED and message: Armada armada2:01gtk9sqkrtsabz51r0gxzgfe3 succeeded
[2023-03-03, 08:51:21 UTC] {taskinstance.py:1318} INFO - Marking task as SUCCESS. dag_id=testing, task_id=armada2, execution_date=20230303T083503, start_date=20230303T083541, end_date=20230303T085121

However Armada events show it finished within the expected time:
Mar  3 08:35:43 | Queued:   9, Leased:   0, Pending:   0, Running:   0, Succeeded:   1, Failed:   0, Cancelled:   0 | JobSubmittedEvent, job id: 01gtk9sqkrtsabz51r0gxzgfe3
Mar  3 08:35:43 | Queued:  10, Leased:   0, Pending:   0, Running:   0, Succeeded:   1, Failed:   0, Cancelled:   0 | JobQueuedEvent, job id: 01gtk9sqkrtsabz51r0gxzgfe3
Mar  3 08:35:55 | Queued:   9, Leased:   1, Pending:   2, Running:   7, Succeeded:   1, Failed:   0, Cancelled:   0 | JobLeasedEvent, job id: 01gtk9sqkrtsabz51r0gxzgfe3
Mar  3 08:35:55 | Queued:   0, Leased:   9, Pending:   3, Running:   7, Succeeded:   1, Failed:   0, Cancelled:   0 | JobPendingEvent, job id: 01gtk9sqkrtsabz51r0gxzgfe3 pod: 0
Mar  3 08:36:00 | Queued:   0, Leased:   0, Pending:   3, Running:  16, Succeeded:   1, Failed:   0, Cancelled:   0 | JobRunningEvent, job id: 01gtk9sqkrtsabz51r0gxzgfe3 pod: 0
Mar  3 08:36:12 | Queued:   0, Leased:   0, Pending:   0, Running:   4, Succeeded:  16, Failed:   0, Cancelled:   0 | JobSucceededEvent, job id: 01gtk9sqkrtsabz51r0gxzgfe3 pod: 0

Taking a look. Adding more logging to the operator as a first step.


Path too long when building zed

error: failed to get `pet` as a dependency of package `languages v0.1.0 (D:\a\zed-windows\zed-windows\zed\crates\languages)`

Caused by:
  failed to load source for dependency `pet`

Caused by:
  Unable to update https://github.com/microsoft/python-environment-tools.git?rev=ffcbf3f28c46633abd54[48](https://github.com/buptsad/zed-windows/actions/runs/11358102453/job/32439663070#step:7:49)a52b1f396c322e0d6c#ffcbf3f2

Caused by:
  path too long: 'C:/Users/runneradmin/.cargo/git/checkouts/python-environment-tools-903993894b37a7d2/ffcbf3f/crates/pet-conda/tests/unix/conda_env_without_manager_but_found_in_history/some_other_location/conda_install/conda-meta/python-fastjsonschema-2.16.2-py310hca03da5_0.json'; class=Filesystem (30)
Error: Process completed with exit code 1.

Try rerunning it.

it still got the same error
30s
Run cd zed
info: syncing channel updates for '[1](https://github.com/YuenSzeHong/zed-windows/actions/runs/11657421063/job/32455048703#step:7:1).81-x86_64-pc-windows-msvc'
info: latest update on 2024-09-05, rust version 1.81.0 (eeb90cda1 2024-09-04)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-std' for 'aarch64-apple-darwin'
info: downloading component 'rust-std' for 'wasm32-wasip1'
info: downloading component 'rust-std' for 'x86_64-apple-darwin'
info: downloading component 'rust-std'
info: downloading component 'rust-std' for 'x86_64-unknown-linux-gnu'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-std' for 'aarch64-apple-darwin'
info: installing component 'rust-std' for 'wasm32-wasip1'
info: installing component 'rust-std' for 'x86_64-apple-darwin'
info: installing component 'rust-std'
info: installing component 'rust-std' for 'x86_64-unknown-linux-gnu'
info: installing component 'rustc'
info: installing component 'rustfmt'
    Updating crates.io index
    Updating git repository `https://github.com/kvark/blade`
    Updating git repository `https://github.com/pop-os/cosmic-text`
    Updating git repository `https://github.com/zed-industries/font-kit`
    Updating git repository `https://github.com/XDeme1/xim-rs`
    Updating git repository `https://github.com/ConradIrwin/xkbcommon-rs`
    Updating git repository `https://github.com/zed-industries/tree-sitter-heex`
    Updating git repository `https://github.com/tree-sitter-grammars/tree-sitter-markdown`
    Updating git repository `https://github.com/zed-industries/async-pipe-rs`
    Updating git repository `https://github.com/zed-industries/lsp-types`
    Updating git repository `https://github.com/microsoft/python-environment-tools.git`
error: failed to get `pet` as a dependency of package `languages v0.1.0 (D:\a\zed-windows\zed-windows\zed\crates\languages)`
Caused by:
  failed to load source for dependency `pet`
Caused by:
  Unable to update https://github.com/microsoft/python-environment-tools.git?rev=ffcbf3f28c46633abd5448a52b1f396c322e0d6c#ffcbf3f2
Caused by:
  path too long: 'C:/Users/runneradmin/.cargo/git/checkouts/python-environment-tools-903993894b3[7](https://github.com/YuenSzeHong/zed-windows/actions/runs/11657421063/job/32455048703#step:7:8)a7d2/ffcbf3f/crates/pet-conda/tests/unix/conda_env_without_manager_but_found_in_history/some_other_location/conda_install/conda-meta/python-fastjsonschema-2.16.2-py310hca03da5_0.json'; class=Filesystem (30)


Add entityURL property

Add a property for external access URL to entities
See #578

This also seems like a good way to address the concern in the first full paragraph on page 19 of the phase 1 assessment report.


Float types are not supported

Float types are not supported,  comparing JSON with a float type throws an error

Add a case for floats to walker.go:
	if modified.Bool() != current.Bool() {
		w.replace(pointer, modified.Bool(), current.Bool())
	}
case reflect.Float64, reflect.Float32:
	if modified.Float() != current.Float() {
		w.replace(pointer, modified.Float(), current.Float())
	}
case reflect.Invalid:
	// undefined interfaces are ignored for now
	return nil

and to patch_test.go:
Uint32  uint32  `json:"uint32"`
Uint64  uint64  `json:"uint64"`
UintPtr uintptr `json:"ptr" faker:"-"`
Float32   float32   `json:"float32"`
Float64   float64   `json:"float64"`

}
It works for me.

Hi @igor-plotnikov,
Thank you for submitting an issue, feel free to create a pull request with the suggested changes.
Cheers,
Norwin

Norwin,
I've tried to create a branch with the fix, but I don't have the write
rights for your repository
Regards
Igor
On Tue, Nov 23, 2021 at 1:53 AM Norwin Schnyder @.***>
wrote:

Hi @igor-plotnikov https://github.com/igor-plotnikov,
Thank you for submitting an issue, feel free to create a pull request with
the suggested changes.
Cheers,
Norwin
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/snorwin/jsonpatch/issues/13#issuecomment-976350202,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANUMOA5Q6TRITNMGSDKKCBLUNNQCTANCNFSM5ISWU2CQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You need to create a fork first (https://docs.github.com/en/get-started/quickstart/fork-a-repo). On you personal fork you then can create branches and PR to the main branch of this repo here.

@snorwin would you have time to look into any of the provided PRs. That would be amazing 🤩


use everywhere BigInteger or Integer

Id go for BigInteger for the simple reason that MongoRepository can handle the ID creation out of the box. Otherwhise we need to implement own logic to generate Ids.

Or does it break the api? then we should probably consider implementing own id generator or sequence - whatever

only for uniformity and the understanding


fix(parsers/regexp): add injection of global flag if it's not present

This PR closes #55
Outstanding issues before merge:

Should this be categorized as a fix and not feat? It's not breaking anything that worked correctly before, technically it's an implementation detail that should've been avoided, but because of the unclear docs and lack of context this could've been perceived as a bug.
Are doc changes sufficient?

I actually considered this as a feature, not a fix. 🤔


Redesign IPC from read/write DB to pub/sub with zeromq

IO with DB requires lots of polling and makes it hard to keep track of world sim update events.
Right now every reader is polling the world DB at the rate of updates or more.
In the worst case, the robot allocator is offset from the world sim by up barely under one cycle, so when it generates paths for the next timestep, by the time it writes to the DB the world sim has already stepped to the next time step, causing a off-by-one pathing error which will result in a collision.

[x] #46 we should measure this and visualize it
[ ] we should replace IO -> pub/sub, pyzmq will work and there's node bindings as well for the visualizers.

https://zguide.zeromq.org/docs/chapter1/

Using the profiler we can directly see that the robot allocator update steps are not synced with the world_sim, and in several instances run during the update step of the world sim

This definitely will and does lead to unintended behavior including several collisions (likely due to the RA sending paths that are out of sync (wrong time step) with the actual state of the world.

Collisions occur where 2 robots are on the same tile, the only way this can happen currently is because of a path starting time mismatch between the robot allocator and the world sim.
2023-04-24 16:40:23,026 - ERROR - Robot collision (7, (1, 1), (2, 1), 0, (1, 1), None)
2023-04-24 16:40:26,524 - ERROR - Robot collision (4, (5, 1), None, 2, (5, 1), (6, 1))
2023-04-24 16:40:26,633 - ERROR - Robot collision (3, (4, 1), (4, 1), 2, (4, 1), (5, 1))
2023-04-24 16:40:27,613 - ERROR - Robot collision (7, (8, 1), None, 6, (8, 1), (9, 1))

Some of the updates when a lot of jobs change take 100-150ms

Looking in the logs
2023-04-24 16:40:54,999 - DEBUG - update start
2023-04-24 16:40:55,000 - DEBUG - generate_path took 0.000628 sec : (10, 3) -> (2, 1) max_steps=40 : [(10, 3), (9, 3), (8, 3), (7, 3), (6, 3), (5, 3), (4, 3), (3, 3), (2, 3), (2, 2), (2, 1)]
2023-04-24 16:40:55,031 - INFO - Sending Robot 1 back home for task Task 2 [COMPLETE]: Item 1x1 to Station 1: [(10, 3), (9, 3), (8, 3), (7, 3), (6, 3), (5, 3), (4, 3), (3, 3), (2, 3), (2, 2), (2, 1)]
2023-04-24 16:40:55,033 - DEBUG - generate_path took 0.001279 sec : (10, 3) -> (8, 13) max_steps=40 : [(10, 3), (10, 4), (9, 4), (8, 4), (8, 5), (8, 6), (8, 7), (8, 8), (8, 9), (8, 10), (9, 10), (9, 11), (9, 12), (8, 12), (8, 13)]
2023-04-24 16:40:55,152 - INFO - Sending robot 1 to station for task Task 11 [IN_PROGRESS]: Item 1x1 to Station 5
2023-04-24 16:40:55,153 - DEBUG - update end, took 0.154056 sec

Using 0MQ for notifying RA when to update is enough, as DB gets are fast (~1ms) when not colliding, and are probably as fast/faster than TCP messages with more reliability.


Wifi improvements

Updates to the wifi connection code as originally presented by @mrexodia on #173
I have created a PR as this code addressed the board crashing issues I had mentioned in #87
Introduces better logging and network information, disconnects and retries connections with no IP address, applies some elements from the RP2040 manual on correctly configuring a wifi connection.
Critically, introduces a disconnect command after reading upload, which I believe is the part that fixes my board crashing issues.
I have adjusted the originally provided code to only disable power saving mode if on a USB supply, placed the wifi country in the config file and also replaced the custom logging function with the PHEW logging module for consistency.
I have tested correct behaviour on well behaved networks, also those that fail to give an IP and note correct disconnect and retry. I have also seen better performance in terms of no board lockups where they were guaranteed before after ~ 2 hours of frequent polling.

I notice that this PR has been open for the last few months, but from the comments it doesnt look like it is pending any work after September. Are there any plans to merge this into any specific future release? I have 12 enviro indoor's deployed, and manually adding these changes to each of them is rather time consuming. So would prefer to wait for a release if there are plans for that already.

@basil-dsouza I am ready for it to be reviewed for merge. I emailed Pimoroni a couple of months ago and was advised that while this project wasn't abandoned, it also wasn't under active review at the moment due to other priorities. It was briefly revisited after that with some preparatory PRs processed, but I've not seen any activity since. So while it's not impossible this will be revisited, I wouldn't say that it is likely either.

please review and reject or merge, to say this project is isn't under active review isn't great, this is a paid for product, which the software has been opened up to the community to evolve which is great, but it needs to be maintained or handed over, but as this is the core software of a paid for product I'd be disappointed to not see either merge and release, or a rejection of this PR rather than leaving it open

I think us users are going to have to call out pimoroni and get them to activly maintain this project or add another person that can do what they can not be bothered to do. I need the battery status that was " temporarly removed" months ago added back as my enviro weather is sitting in a box in the cupboard doing nothing as it is unusable as it stands. It works for weeks or months then boom its dead becuase the batteries have died, I am disabled and need to arrange to get someone to go and change batteries, at least if I knew they were close to discharged I could make prior arrangements ..

Sorry for the radio silence here. I won't waste words on excuses.
@sjefferson99 thank you for taking the time to identify, fix and communicate these WiFi issues. Are you comfortable rebasing this pull request to remove the merges? And, more so, willing to do so? That should give some clean commits I can merge and also kick the CI to produce some more test builds. I am hoping to merge this PR and produce an interim release.
Following that, I need to run some tests, merge and release the new MicroPython v1.22.1 firmware (
https://github.com/pimoroni/pimoroni-pico/pull/892) and update Enviro to build against it. This might contribute some additional, much-needed stability and reliability fixes. (Or it might not 😬, so we probably want to be a little reserved here)
I can't comment on any specific outstanding bugs - particularly the issue with battery level monitoring - but I am spending some time to get up to speed with this project and see if I'm able to help.

@Gadgetoid I've had a quick google and a test on a spare repo and I believe I have achieved the necessary rebasing of the merges from main. Let me know if this is what you intended and appears correct.

@sjefferson99 nailed it. Thank you.
For anyone logged into GitHub, a full firmware with these fixes is available from the CI - https://github.com/pimoroni/enviro/actions/runs/7545806918/artifacts/1174690874
And the filesystem only build - https://github.com/pimoroni/enviro/actions/runs/7545806918/artifacts/1174690873
You can usually find these be expanding the PR checks, clicking "Details", navigating to "Summary" and scrolling down for the artifacts.

I'm still very much focussed on fixing the unholy mess Pi 5 and Bookworm OS have made of our Pi software ecosystem, which is why I've blinked and another month has flashed by on this PR. It's still on my radar, though. By way of an update-
There's a bug fixed in the MicroPython/cyw43 side of things for wireless networks without a password that we'll probably want to try and include in a new release. (https://github.com/micropython/micropython/commit/699477d12d1aa1cb57ff6cfc3f5dc5e97524dbe6)
I'm currently over on our main repository testing a bump to MicroPython v1.22.2, which is another patch release that snuck up on me.
Current Enviro releases currently track our release v1.20.4 which is based upon MicroPython v1.20 (April 2023) so it's quite behind 😬, but the recent release add their own little bit of fun to the mix- upgrading LittleFS so you can't downgrade from a newer firmware to an older one without losing your filesystem (though in Enviro's case, where Python code and firmware are almost one and the same, this might be less of a problem).
I remember @ZodiusInfuser mentioning somewhere that this changeset, and I quote, "adds a new issue of thinking it's connected to a WiFi network when it hasn't", though I am not clear on the circumstances that reveal this bug. No doubt my thoroughly terrible wireless network might surface them.
Some feedback from anyone who has used this build (available from CI as mentioned above) would be really helpful. Thank you!

be nice to get an official release of this now - the WIFI stability the interim release supplies is a huge benefit, anything beyond that is a bonus or should not block a major stability upgrade and can be worked on for a later release. @sjefferson99 huge thanks for. your efforts on this, it's made a real difference to me

@Gadgetoid I've found in further testing that this code was disconnecting on every check even when connected, which is due to the following line from @mrexodia original code at line number 163:
if status >= CYW43_LINK_JOIN and status <= CYW43_LINK_UP:

I believe it should be:
if status >= CYW43_LINK_JOIN and status < CYW43_LINK_UP:

To not disconnect when a healthy connection is in place. This is working much better on my test setup.
I can make this change on my branch for this PR, but equally if that will delay this entering the main code branch, I can raise another PR when this is committed.

@sjefferson99  did you make the change in this PR, it doesn't look like it from what I can see, the change you suggested looks beyond minor and fixes an incorrect 'equal to' check.
This needs releasing

@ikonia It's definitely worth fixing, but I am not familiar with the Pimoroni release testing process and do not want to make a further change if it prolongs the release of this PR. However, if it's as simple as "yeah looks good" from Pimoroni along with my own testing, then will happily adjust the PR to accommodate it. I can't do more without input from someone like @Gadgetoid but I feel like there might be some other larger issues in the raspberry pi space taking their attention at the moment, from other threads I've seen in the interwebs.

fully understand and appreciate your comment @sjefferson99 I also see the bigger issues with the Pi5 and bookworm platforms taking up a huge effort, but this is the point of community contribution, to share the load and for a single individual to not be a bottleneck (no critique of pimironi individuals they can only do so much)

if it's as simple as "yeah looks good" from Pimoroni along with my own testing, then will happily adjust the PR to accommodate it

Yeah, looks good!
If you add the change here, then the CI should build a firmware that others can grab and test. Avoids having to wait for me to make an official release.

@Gadgetoid @ikonia Branch updated and I can see reflected above in PR.

Updated in my new-MicroPython PR also, builds should pop up here: https://github.com/pimoroni/enviro/actions/runs/8784459020/job/24102730608

amazing effort, thank you

My strategy post merge is to tag a release against the current version of MicroPython, then merge my MicroPython bump and tag a new release against that. This should give us two firmwares that have:

WiFi fixes
MicroPython Bump and WiFi fixes

So there's something to roll back to if the MicroPython bump causes any new problems. I don't imagine this being the case, but I'd rather be safe than sorry.
@sjefferson99 thank you for your continued help and support here, I'm juggling quite a bit of software and it's dangerously easy to overlook things.

Thankyou @Gadgetoid . I might actually get to use my enviro now if it stays up for more than 12 hours. I suppose I better hunt the box out again and bench test for a while.  Fingers Crossed.

The work that's been done in this thread, I've been testing for a few days from the CI build, and the difference is huge, stability, and oddly accuracy on the thermal sensor is improved along with minor stuff too. This is a big deal release, and it's very much appreciated


Fix cleanup policy methods in Ops::Backup model

The cleanup methods in the Ops::Backup model where actually outside the model definition, so they weren't properly called by the backup job.
I've also removed a couple of test methods from the class - I assume they're not really needed.

thanks - needs further cleanup indeed :)


Hec 1192 internal auth

ticket details -> https://jira.tools.tax.service.gov.uk/browse/HEC-1192
This PR includes changes for hec only, will send PR for config changes after LB changes .

Build failures- working on removing unnecessary imports


[ContentBundle] Add parent page to smart content data for template

By @danrot from https://github.com/sulu-cmf/SuluContentBundle/issues/164
The parent or DataSource of the smart content should also be populated to the twig template, so that e.g. the name of the parent page can be used.

Should be fixed here: https://github.com/sulu-cmf/sulu/blob/develop/src/Sulu/Bundle/ContentBundle/Content/Types/SmartContent/SmartContent.php#L195

@danrot hmm i think this should include the page data of selected datasource ... but this is not used from everyone and if it is needed it can be loaded over content_load(view.smart_content.dataspource) so i think it is ok when it is closed!


azure cli doesn't support passing in name of synapse workspace managed resource group (unlike the cli)

When I create a Synapse workspace from the UI I can provide it the name I want to use for the managed resource group; however, there is no such parameter that I see in the az cli. https://docs.microsoft.com/en-us/azure/synapse-analytics/quickstart-create-workspace-cli. Is this by design? I would like to be able to specify this from the cli as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc1de0e7-d4fd-0712-77df-e8205efc6573
Version Independent ID: 2f842e65-6e8b-0b03-8d2b-c676e785b8e0
Content: Quickstart: Create a Synapse workspace using Azure CLI - Azure Synapse Analytics
Content Source: articles/synapse-analytics/quickstart-create-workspace-cli.md
Service: synapse-analytics
Sub-service: workspace
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@roalexan As per the CLI documentation, looks like there is no parameter named managed resource group in Azure CLI.

You may leave the feedback at the bottom of the Azure CLI documentation to include this parameter:

Hope this helps.

agreed, and that's what I think we should consider adding - a new parameter e.g. managed-resource-group. So, this is not really a bug/issue, but a product feature request. Not sure best way to file this.

@roalexan thanks for this feedback. The best place for product feedback like this is Azure Synapse Analytics feedback in the feedback.azure.com hub. Thanks!
#please-close


Editorial

Description
This is v1 of a Craft version of the Wordpress Editorial Starter Kit found at https://github.com/Upstatement/editorial-wp-theme
To Do

[ ] Gallery / Modal Gallery does not exist yet.
[ ] Needs more testing
[ ] I would like to smooth out the import content process to be part of the bin/install command rather than being a manual import.

How to test

Pull the branch.
Run composer install
Run npm install
Follow the instructions in the Readme for restoring the database backup.
Then ./bin/start to start the server.

@bchiang7 @mgburns Any whomever else I should tag. I think this is probably ready for preliminary review / testing. As noted above, i still have a few things that I want to do with it, but I think it is in a pretty okay place.

@bchiang7 @mgburns Any whomever else I should tag. I think this is probably ready for preliminary review / testing. As noted above, i still have a few things that I want to do with it, but I think it is in a pretty okay place.

Excellent! Thanks for doing this @michaelpelletier, will take a look asap.

@michaelpelletier I'll try to take a look at this as soon as possible! Just noting that I might not have time until The 19th ends (~1.5 weeks)

Still haven't had time to take a look at the code yet, but I wonder if we should move this to a separate repo like editorial starter? or not merge into master?

@bchiang7 - To answer your question with a question, would there be value in having the Craft Starter without the Editorial Kit? (CC @mgburns)

@bchiang7 - To answer your question with a question, would there be value in having the Craft Starter without the Editorial Kit? (CC @mgburns)

I think the question is:

will the defaults set in this PR be useful for the majority of our sites?

If yes, I don't see any reason to complicate with separate repos. On the other hand, if we find ourselves ripping stuff out when we start every project it might warrant another repo (or perhaps just a long-lived branch of this repo).
WordPress requires a number of customizations (primarily via the Ups Blocks plugin that's embedded in the Editorial Starter theme repo) to get the admin to behave. That is less true for Craft because the admin is less opinionated.
Generally I like having two options -- bare and "batteries included". Craft Starter (prior to this PR) is pretty bare, Editorial Starter has lots of batteries, and Skela is somewhere in the middle. Whatever we decide to do I'd like for it be consistent across CMSs.

Another factor to consider is that Skela is open source (like Craft Starter) and Editorial starter is still private


[BUG] Clicking on "Add an Action Block" (using the inline menus) doesn't place it right under the focussed block

🔵 Describe the bug:
It seems that clicking on "Add an Action Block" (using the inline menus) doesn't place it right under the focussed block.
🔵 To reproduce: (Steps to reproduce the behavior)

Edit a macro
Click on  the "Add an Action Block" icon (from one of the "inline menus")
The block gets added at the bottom

🔵 Screenshots:

🔵 Expected behavior:
A new block placed right under the current focussed block.
🔵 GSE.lua file:
GSE.lua.txt
🔵 Desktop
OS: Windows 10 64bits pro
Hardware: nvidia GTX 1070 8GB - driver: 471.11
🔵 Game Version
World of Warcraft Shadowlands version <IP_ADDRESS>804 (French language)
🔵 GSE Version

Version: 3.0.45
Downloaded From: Curseforge (via Ajour)

I have the same issue except mine always goes to the top


Interact with Kubernetes Dapr apps using Dapr CLI

I recently completed my first deployment of Dapr onto our Kubernetes Cluster and wanted to do some tests against the Dapr apps.  I was hoping to use invokeGet, invokePost and Publish for these tested only to realize that the kubernetes implementation of these features does not exist.
It will be very helpful if one is able to use invokeGet, invokePost and Publish with the -k option to invoke and publish against Dapr app sidecars running in a kubernetes cluster.

This would totally be a nice feature for development but I wanted to raise a question around security.  My assumption is that the sidecars should only trust communication from the app containers in the same pod and the other running Dapr sidecars (via mTLS, etc). Would exposing a mechanism to use invokeGet, invokePost, and publish essentially bypass that level of trust? Am I missing something?
I'm wondering if maybe a solution (granted pie in the sky) would be to deploy some sort of REPL container behind a Dapr that is adheres to the security pattern above. One could use OPA/admission controllers to make this this never accidentally gets deployed into production K8s environments. Thoughts?

This would totally be a nice feature for development but I wanted to raise a question around security.  My assumption is that the sidecars should only trust communication from the app containers in the same pod and the other running Dapr sidecars (via mTLS, etc). Would exposing a mechanism to use invokeGet, invokePost, and publish essentially bypass that level of trust? Am I missing something?
I'm wondering if maybe a solution (granted pie in the sky) would be to deploy some sort of REPL container behind a Dapr that is adheres to the security pattern above. One could use OPA/admission controllers to make this this never accidentally gets deployed into production K8s environments. Thoughts?

Also might consider using kubectl port-forward to accomplish this.
https://kubernetes.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/#forward-a-local-port-to-a-port-on-the-pod
One downside is that you would not receive a callbacks to a Publish operations.

Also might consider using kubectl port-forward to accomplish this.
https://kubernetes.io/docs/tasks/access-application-cluster/port-forward-access-application-cluster/#forward-a-local-port-to-a-port-on-the-pod
One downside is that you would not receive a callbacks to a Publish operations.

One downside is that you would not receive a callbacks to a Publish operations.

The app running on k8s will receive the callbacks. Your local machine won't. :)

One downside is that you would not receive a callbacks to a Publish operations.

The app running on k8s will receive the callbacks. Your local machine won't. :)

I am currently working on an iot platform based on Dapr. We chose dapr because dapr can be used in both kubernetes mode and self-hosted mode.
We extend Dapr CLI so that the invoke command supports Kubernetes mode. The goal is to simplify documentation and testing.
Compared with kubectl port-forward, using invokeGet and invokePost with the -k option will make the whole process more concise. This allows Dapr CLI to have a consistent experience in kubernetes mode and self-hosted mode.
The process is similar:

Get the Pod corresponding to the App
Complete the specific communication through the SubResource("proxy") of RESTClient
Direct access to App's AppPort port or access to daprd's HttpPort port

                                      +-----------------+
                                      |                 |
                     AppPort          | +-------------+ |
         +----------------------------> |    APP      | |
  +----------+                        | +-------------+ |
  | dapr cli |                        |                 |
  +----------+                        | +-------------+ |
         +----------------------------> |    Daprd    | |
                    HttpPort          | +-------------+ |
                                      |                 |
                                      |            pod  |
                                      +-----------------+

This sounds interesting.
/cc @yaron2 thoughts?

I support adding this functionality. @imneov would you be willing to submit a PR for this?

@yaron2 yes, that was the plan 🙂

@imneov  please comment as /assign in this issue to work on this. Please close the other issue in this case also.

/assign


Added About Us Component

Description
This PR adds About Us component to the React Application and could possibly close #103 .
Demonstration Video :
aboutus.webm
Please merge this PR @arnab2001

This is the new Location of About Us link in Footer

Fresh About Us page

I decided to remove the Image as it was looking dull on putting it above.
Please Review and merge the PR. Thanks @arnab2001


eRPC - Impressive recent research from CMU and Intel

Datacenter RPCs can be General and Fast
http://www.cs.cmu.edu/~akalia/doc/nsdi19/erpc_nsdi19.pdf
https://github.com/erpc-io/eRPC

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0db2d29c-ebfd-9c79-4b08-61fc5192f3c3
Version Independent ID: 048d1977-93aa-f28a-60ec-6806dec3f70a
Content: Introduction to gRPC on ASP.NET Core
Content Source: aspnetcore/grpc/index.md
Product: aspnet-core
GitHub Login: @JunTaoLuo
Microsoft Alias: johluo

@JamesNK  should Alternative Framework Scenarios list these?

I don't think so. It looks like an implementation of RPC that is focused on performance, but doesn't yet have a community of users.
I'm not sure what the action is from this issue. It could probably be closed.


Fix warnings introduced by Rust/Clippy 1.57.0

Which issue does this PR close?
Closes #991.
Rationale for this change
Upgrading is great! Passing CI is great!
What changes are included in this PR?
I've fixed a number of new warnings. The only one I chose to allow is a new one for a field that's unread, and I'm not sure if that's on purpose or not.
Are there any user-facing changes?
Shouldn't be!

Codecov Report

Merging #992 (16a5283) into master (e9be49d) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   82.31%   82.28%   -0.03%
==========================================
  Files         168      168
  Lines       48763    48762       -1
==========================================
- Hits        40139    40126      -13
- Misses       8624     8636      +12

Impacted Files
Coverage Δ

arrow/src/compute/kernels/take.rs
95.21% <ø> (-0.01%)
:arrow_down:

arrow/src/datatypes/field.rs
53.37% <0.00%> (-0.31%)
:arrow_down:

arrow/src/datatypes/schema.rs
66.12% <0.00%> (-0.81%)
:arrow_down:

...ng/src/flight_server_scenarios/auth_basic_proto.rs
0.00% <ø> (ø)

parquet/src/record/reader.rs
89.83% <0.00%> (-0.63%)
:arrow_down:

arrow/src/array/equal/utils.rs
74.00% <33.33%> (ø)

arrow/src/array/transform/boolean.rs
76.92% <100.00%> (ø)

arrow/src/compute/util.rs
98.90% <100.00%> (ø)

arrow/src/ipc/writer.rs
84.12% <100.00%> (ø)

parquet/src/arrow/arrow_writer.rs
98.06% <100.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9be49d...16a5283. Read the comment docs.

Thanks @carols10cents for the quick fix. Could you run fmt too to fix the formatting errors?


Context is Initialized per Service in GraphQL Subscriptions

Description:
In GraphQL subscriptions, the Context object is initialized when the WsService object is initialized. This is wrong. The context should be created per request.

This currently blocked due to ballerina-standard-library/#3145

Continue with dummy http:RequestContext until the ballerina-standard-library/#3145 get resolved.


Replace HCC1143 "tumor" test files with files actually derived from tumor.

Ideally these snippets would have a few events/segments.  Right now the "tumor" test files are actually derived from the normal.

Just noting for the record that the files were already derived from the tumor.


Fixed issues obtained during the publishing of the solution

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Release notes are not added.
Offer name in Partner Center (Cognytetechnologiesltd.microsoft-sentinel-solution-cognyteluminar) doesn't match with the solutionId (cognytetechnologiesisraelltd.microsoft-sentinel-solution-cognyteluminar) in mainTemplate.json in package.
The link (https://aka.ms/sentinel-CognyteLuminar-azuredeploy) is not working
The logo is breaking.
Please raise a Pull Request with the changes. Push the offer to certification once that approved/merged.

Hello @RamboV, Thanks for raising this PR.
This PR will be investigated and we will update you about the same before 22 December, 2023.

Hello @RamboV, Thanks for raising this PR. This PR will be investigated and we will update you about the same before 22 December, 2023.

Hello @v-prasadboke , can you take this as a priority please, we are waiting for this to get the publishing process completed, its been reviewed thoroughly before I did not know why all these issues are being raised now while we publish the package.

Hello @RamboV, I have updated the shortlinks the links would work now. And we dont put actual raw hyperlinks. We use shortlinks instead


🥋GEONET daily coordinates in InfluxDB

As a part of Sensor Integration activity.
I may adopt daily coordinates data under the Adopt Geodata philosophy.
Data are available at https://terras.gsi.go.jp/pos_main.php

First, I am depositing raw daily coordinate files into IPFS for easier access.

https://github.com/optgeo/f5-ipfs

Why hfu is working on this.

To consider open-source software options for sensor integration. Test if Influx DB, Telegraf, etc. would work and we can make use of it.
Time-series is some upcoming agenda for hfu's domestic work, too. There can be some synergy.

IPFS adding stage was complete.
https://github.com/optgeo/f5-ipfs/blob/main/f5.md

#274
Closing due to lack of response, feel free to reopen later.


Support embedded ICC color profile

It seems CactusView does not yet support viewing images with embedded ICC color profile properly. I tested with both JPG and PNG.
Test image source:

Web page containing multiple images: https://people.csail.mit.edu/ericchan/hdr/hdr-jxl.php
Image in question: https://people.csail.mit.edu/ericchan/hdr/jxl_images/20140606_102418_IMGP0297.jxl

Test images transcoded by me:

forest.zip

JPEG example
Sample image can be transcoded to JPG with ICC profile using libjxl ( https://github.com/libjxl/libjxl/releases/tag/v0.9.1 ) like so:

With XYB: ".\libjxl-v0.9.1\cjpegli.exe" ".\forest.jxl" ".\forest_xyb.jpg" --quality=90 --xyb --chroma_subsampling=444
Without XYB: ".\libjxl-v0.9.1\cjpegli.exe" ".\forest.jxl" ".\forest.jpg" --quality=90 --chroma_subsampling=444

Result in CactusView vs. GIMP
Using XYB

Not using XYB

PNG example
Sample image can be transcoded to PNG with ICC profile using libjxl ( https://github.com/libjxl/libjxl/releases/tag/v0.9.1 ) like so:

".\libjxl-v0.9.1\djpegli.exe" ".\forest.jpg" ".\forest.png"

Result CactusView vs. GIMP

I will need to inspect how these things are encoded and how I should display them. I don't have much knowledge about how these are done. if you have any info or tips I'd appreciate it.

Cool. 😊 I don't know much about that either, sorry. Maybe the source code of other projects (viewers, decoders?) that handles ICC can be helpful.

I'll take a look into it once I find the time


Bpm change crashes for me.

Describe your bug here.
When I put in a bpm change in my song, the game would crash after hitting a note after the bpm change.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No, all i did so far was add a new character and a song.

It is most likely that it's an issue with your chart, but i will need more information.


Feature: culling gas tanks similar to not-generating prefilled liquid tanks NEI/creative

is it possible to add a config option or feature to reduce lag in NEI/creative to not generate /prefilled gas tanks similar to the way the liquid portable tanks were done? I always run mekanism with the portable tanks prefilled setting as "false", but am looking for more ways to improve search-lag in NEI/creative

Prefilled gas tanks should be causing little to no lag at all; I definitely don't think they would be the cause of a problem.


bpf: enable hairpin optimizations to avoid fib lookup also for tc

Make 0532f887eb8e ("bpf: avoid using fib lookup in nodeport for dsr v4/v6
hairpin case") generic such that also the tc BPF case can benefit from it
when only a single external device was specified or detected on the node.
Signed-off-by: Daniel Borkmann<EMAIL_ADDRESS>

test-me-please

retest-net-next


GRSISort meeting September 22nd

Most of you probably already got the email, but just in case:
Dear all,
at the last GRSISort meeting it was suggested that we have such meetings twice a year. Since we will have both a TIGRESS and GRIFFIN experiment running in September (barring any changes of the schedule), we decided to have the meeting at TRIUMF on September 22nd. The meeting will be in the Main Office Building Conference Room (downstairs across from the cafeteria).
This time we won't have as many talks from Guelph, just one overview talk and one talk about changes made to the code since the last meeting. This will give us time to have talks from other people about their analysis. So if you have anything you want to talk about, please send me an email. This can include the status of your analysis, problems you've run into/have solved, ideas for improvements of the code, etc.
I will try and come up with a schedule for the meeting once I know who is willing to give a talk, so please send me any contributions you plan until September 5th.
Please let me know if you plan to come to the meeting, we need a rough idea of the number of people so that Adam can arrange catering.
Cheers,
Vinzenz

This is a first draft of the program for the meeting:

Time
Speaker
Topic

9:00 -  9:30
Ryan Dunlop
GRSISort overview

9:30 - 10:00
Vinzenz Bildstein
Updates and Changes since the last meeting

10:00 - 10:30

Coffee break

10:30 - 11:00
Steffen Cruz
Sharc analysis

11:00 - 11:20
Connor Natzke
Compton Polarimetry

11:20 - 11:50
Jenna Smith
Summing

11:50 - 13:30

Lunch break

13:30 - 13:50
Tammy Zidar
33Mg analysis

13:50 - 15:00

Open discussion


Upgrade react-router-dom package

Upgrade these packages to version and handle any breakages/refactors if any
react-router-dom               ^6.3.0  →  ^6.4.1
 uuid                           ^8.3.2  →  ^9.0.0

can i work on this ?


Support for php7

When will be there support for PHP 7?
Because PHP already flagged PHP 5.5 as End Of Life. And php 5.6 will be End Of Life in January 2019

See the Travis build configs. PHP 7 and 7.1 are included.

That's weird, when I try to require this package, it will throw a php version error that the latest version allowed is 5.5.9. Maybe there's something wrong with my environment, let me check that first.

That's weird, when I try to require this package, it will throw a php version error that the latest version allowed is 5.5.9. Maybe there's something wrong with my environment, let me check that first.


Test Django Framework

Add django project with two apps

demo_app
demo_app_2pages

Django Project with apps was created by tutorial  found in official docs

Note: How to ignore pyflakes error imported but unused:
Not working solutions are:
between code and # was two or one space
from django.db import models  # silence pyflakes

from django.db import models  # NOQA

from django.db import models  # flake8: noqa

from django.db import models  # noqa

from django.db import models  # noqa: F841

All tries mentioned above could be used only with flake8 in my opinion
Working solution is:
from django.db import models

__all__ = ['models']

Remove hardcoded links with templates system is there removing hardcoded urls

Problem with freeze django project to find module with app:
python -m freezeyt tests.fixtures.demo_project_django.demo_project.app build_django

Error occures:
  File<EMAIL_ADDRESS>line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'demo_project'

Did you set PYTHONPATH to the directory with demo_project_django?
This isn't necessary for other test apps, since they don't import anything, but for a multi-file app it will be necessary.

No, I don't 🙂

PYTHONPATH helped, but there is occurs another problem
My steps were:
$ export PYTHONPATH=freezeyt/tests/fixtures/demo_project_django/

$ python -m freezeyt tests.fixtures.demo_project_django.demo_project.app build_django

Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File<EMAIL_ADDRESS>line 87, in _run_code
    exec(code, run_globals)
  File "/Users/stroch/Documents/Python/develop/freezeyt/freezeyt/__main__.py", line 3, in <module>
    main()
  File "/Users/stroch/.virtualenvs/freezeyt/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/stroch/.virtualenvs/freezeyt/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/stroch/.virtualenvs/freezeyt/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/stroch/.virtualenvs/freezeyt/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/stroch/Documents/Python/develop/freezeyt/freezeyt/cli.py", line 65, in main
    freeze(app, dest_path, cli_params)
  File "/Users/stroch/Documents/Python/develop/freezeyt/freezeyt/freezing.py", line 177, in freeze
    result = app(environ, start_response)
  File "/Users/stroch/.virtualenvs/freezeyt/lib/python3.9/site-packages/django/core/handlers/wsgi.py", line 132, in __call__
    request = self.request_class(environ)
  File "/Users/stroch/.virtualenvs/freezeyt/lib/python3.9/site-packages/django/core/handlers/wsgi.py", line 87, in __init__
    self._stream = LimitedStream(self.environ['wsgi.input'], content_length)
KeyError: 'wsgi.input'

Problem to find path to app static folder

Unfortunately, image with static folder wasn't created so another error occured:
  File "/Users/stroch/Documents/Python/develop/freezeyt/freezeyt/freezing.py", line 113, in start_response
    raise ValueError("Found broken link.")
ValueError: Found broken link.

for link:
Saving to build_django/image_page.html
link: http://localhost:8000/static/smile.png
path_info: /static/smile.png
b'/static/smile.png'
b'/'
Not Found: /static/smile.png

That's really strange when I startup my web app by python manage.py runserver then link -> http://localhost:8000/static/smile.png is OK in web browser - I see the image
I supposed that problem will be in path_info, because we need demo_app/static/smile.png, but we got /static/smile.png

Code 304 Not Modified means the server is saying that the file wasn't changed; the browser should use a copy it already has downloaded. (For this to work, the request needs to indicate which copy the browser has available, using headers like If-Modified-Since or If-None-Match.)
Read https://docs.djangoproject.com/en/3.1/howto/static-files/#serving-static-files-in-development instead of the docs for production. Freezeyt should be used with development servers, not production ones. (Remind me to explain more on the stream.)

I've set up static file exactly as described in https://docs.djangoproject.com/en/3.1/howto/static-files/#serving-static-files-in-development
Django application works...
$ python manage.py collectstatic works
But freezeyt can not still found static files:
link: http://localhost:8000/demo_app/static/demo_app/smile.png
path_info: /demo_app/static/demo_app/smile.png
b'/demo_app/static/demo_app/smile.png'
b'/'
Not Found: /demo_app/static/demo_app/smile.png

I don't know which other tests should be beneficial.... Could you give some other idea about other beneficial tests
I supposed that these test could be fine to add:

css as static file

It should be enough to test CSS files with Flask. It's not that different from images, and the Django admin already includes CSS.


Show current versions of game types in the game creation window.

White indicates that the downloaded version is current. Orange - is outdated.
The version number is not shown if it has not been downloaded.
FAF, FAFBeta, FAFDevelop is always shown.
Clicking on the version text opens the Github branch.
The most important thing is to see if you need to update.
Can replace the Git version with a date.
I'm sure it will be useful and not too difficult.
People will know when something has been updated and that something is happening at all.
Since patches take a long time to download, can postpone the game and not get into trouble.
They will also learn that there is a FAFBeta and FAFDevelop.
Preferably the same for mods.
Continuously polling all potential file versions of all featured mods is not acceptable from server performance.
Cache the state of the featured mods.
Stop closing it.

I can also comment on closed issues. Please refer from reopening exact same issue.

If you want to implement it because it is so important to you I can reopen it

U need to understand that issue are also I way of organizing what to do. And if I leave all issue open I end up with a thousand issue. Which is no help at all. So I got to close issue that I see no sense in doing.

I have not previously received comments from you on closed issues.
It's important to me but I can't do it myself.
If you don't want to do this, let others see this issue.

Well closed issue are also seen, and everybody active on this project sees them and gets notified about it.

Start recruiting a dev on zulip then

184 issues since 2015. No one will look at a closed issue, much less do it.
Start recruiting a dev on zulip then
To do this, there is "Issues"

Let it be open for 2 months.


Someone can share for me a project using  stored proc ( view , insert, update)). Thanks

See https://github.com/volkanceylan/Serene/tree/master/Serene/Serene.Web/Modules/BasicSamples/Grids/StoredProcedureGrid

Thanks @Estrusco but i dont know create file  CustomerGrossSalesListRequest in TS file

its in \Modules\Common\Imports\ServerTypings

please help!

You must create a C# class derived from ListRequest (or other Request or Response) then transform all T4 templete and those create for you the .ts relative file
See CustomerGrossSalesListRequest.cs in example
The T4 transformation is in Compile menu.

Thanks @Estrusco

@Estrusco  i try T4 template but not create file.ts
with output
Transforming templates for all project items.
Transforming template ClientTypes.tt with TextTemplatingFileGenerator ... failed.
Transforming template MVC.tt with TextTemplatingFileGenerator ... succeeded.
Transforming template ServerTypings.tt with TextTemplatingFileGenerator ... failed.
Text templating transformation complete.

Use that request in some service. Search project for that request and see what you miss.


Inconsistent SET: Handling of Binary Keys Differs Between DiceDB and Redis

The command SET is not consistent with Redis implementation.
Here are the steps to reproduce the issue
Execute Command - SET key value (Where key is an binary data) E.g. key = "\x00\x01\x02"
Excute Command - GET key
Here's the output I observed in Redis v7.2.5
# On Redis v7.2.5:
<IP_ADDRESS>:6379> SET "\x00\x01\x02" value
OK
<IP_ADDRESS>:6379> GET \x00\x01\x02
(nil)
<IP_ADDRESS>:6379> GET "\x00\x01\x02"
"value"

and here's the output I observed in DiceDB's latest commit of the master branch
# On DiceDB:
<IP_ADDRESS>:7379> SET "\x00\x01\x02" value
OK
<IP_ADDRESS>:7379> GET \x00\x01\x02
"value"
<IP_ADDRESS>:7379> GET "\x00\x01\x02"
"value"

(Observe the value printed by GET in absent of double-quotes)
To summarise -
In DiceDB, both the raw binary key (\x00\x01\x02) and the escaped string representation ("\x00\x01\x02") retrieve the value correctly.
In Redis, the raw binary key (\x00\x01\x02) returns (nil), while the escaped string version ("\x00\x01\x02") correctly retrieves the value.
Make the implementation consistent with the Redis implementation.
Make sure you are using Redis version 7.2.5 as a reference for the
command implementation and to setup Redis
from source code, or
use Docker.

@JyotinderSingh  can you assign this to me, I want to give it a try.

@Shimanshu83 assigned, thanks for contributing.

Hello @Shimanshu83,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

Hello @arpitbbhayani ,
Noted was bit busy but I will wrap the issue  this weekend.

Hello @arpitbbhayani, @lucifercr07
I was able to recreate the above issue while using redis-cli for redis and dice-cli for dicedb.
Interestingly, when using redis-cli for both Redis and DiceDB, the behavior remains consistent.
Kindly refer below screenshot for your reference.

Upon further investigation, I observed that the issue was rooted in the difference between the CLI implementations:
Redis-CLI: When binary values are enclosed within double quotes, Redis-CLI interprets and sends the data in its binary form.
DiceDB-CLI: No matter if binary data is enclosed in double quotes, it is sent as a string instead of its binary representation.
Below is the tcp request made from redis-cli where you can see \x00\x01\x02\x03 represented as 00 01 02 03 not in string format

But the same request made from dicedb-cli the binary key is represented as string value itself  \x00\x01\x02\x03

In conclusion the issue is with difference in cli implementations not with the dicedb set command.

Hello @lucifercr07  we can close this issue as this is related to differnece in  implementations between dicedb-cli and redis-cli not with dicedb set command.


BUG: Adding an override or failsafe to a feed that has no data

...will cause problems depending on the index type.

#61


Make sure empty block doesn't break on method declaration

closes #133

I'm merging this because the generic class stuff has a similar edge case to fix and I don't want to introduce conflicts.


How to install Opencv 2.4.13 & NetBeans on MacOS Sierra

I am trying to use opencv 2.4.13 with netbeans on macOS Sierra. Can some one help me how to do this step by step.

This area is for crouton issues only, sorry.


readme.md update

Describe the bug
under Install shell completion > bash
change to: echo "source '~/.tenv.completion.bash'" >> ~/.bashrc

Thanks for reporting. Can you make a PR, please?

done :)


kotatogram-desktop: switch to qt5 build?

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I bet it's going to be broken again after merging the current staging-next due to glib/gobject-introspection update

We need this patch, mapped to cmake/external/cppgir

I would be thankful if you try calls if you have already built this cause I have suspicion ffmpeg 7 is likely to break calls. If not, I can check that on my own a little bit later.

Ok, seem to work just fine. I'm even surprised that just replacing kdePackages with libsForQt5 is enough to run with Qt 5 (I was expecting some libraries to be named differently).
Result of nixpkgs-review pr 350831 run on x86_64-linux 1

2 packages built:

kotatogram-desktop
kotatogram-desktop-with-webkit

Did someone try to bump https://github.com/desktop-app/codegen/compare/6462cda46ec5d48a9ae452ba1b6f7dfe1b6d882d...master instead?

So... Do we need anything else to get this merged?

@ofborg build kotatogram-desktop

Darwin errors seem to be trivial, here's the fix (and fixed version number while on it): https://github.com/NixOS/nixpkgs/pull/351995


Photoshop: Removed redundant copy of extension.zxp

Changelog Description
extension.zxp shouldn't be inside of extension folder.

So, next up is updating this ancient Readme mentioning Avalon, etc.? 😄


[Accelerate] [vDSP] DFT, FFT, DCT, and Biquad

This PR contains Swift overlays to simplify DFT, FFT, DCT, and biquad filtering operations.
This is just @FlexMonkey 's https://github.com/apple/swift/pull/24183 rebased onto current master to get rid of conflicts.

@swift-ci please test

@swift-ci please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - 0727d18f19f0001a95c2ae896c5677185e6b963f

@swift-ci smoke test linux


[<IP_ADDRESS>5] Bug:

Bug found testing Stacks Wallet for Web.
Error
Loadable: api.account-data
Message: Unable to fetch account data from https://stacks-node-api.xenon.blockstack.org
Environment
Version: <IP_ADDRESS>5
Branch: feat/launch-misc
Commit: 6190d5f

I problem Login sir

I problem Login sir


NuGet Package?

Would be great to have packaged up on NuGet

Done: https://www.nuget.org/packages/Xam.Android.ImageLoading/ :)


Error when running on real device

Hi,
Just installed the Framework as shown in the video. When running on the simulator it works fine.
When I try and run it on a real iOS device though I the the following errors.

I've tried it on Xcode 6.2 and the latest 6.3 release.
Any ideas?
Thanks,
Anthony

Honestly, i'd check out iRate for now. I got this same message as you and eventually got it fixed (check out the video. I followed that and fooled around until it worked.). However, when it was time to submit to the app store I got some warnings and couldn't figure it out.
Tried iRate, dragged the files in, removed Armchair and submitted to the app store in a couple of minutes without any issue.

Don't use iRate, it is not as feature complete as UAAppReviewManager.

@zenoah01 https://stackoverflow.com/questions/24002836/dyld-library-not-loaded-rpath-libswift-stdlib-core-dylib/27109546#27109546
Import the framework in the Embedded Binaries rather than in to the Linked Frameworks and Libraries.
Embedded Binaries are under Projects Settings -> -> General
@coneybeare You might want to update installation procedure.

I am getting the error below when trying to run on a real iOS device running iOS 9:
ld: -bundle and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together
I have tried setting ENABLE_BITCODE to No in my project and the Armchair project but still get the same error.  I'm not sure how to resolve this.

Ok - I got it to work.  It turns out I had only disabled bitcode at the target level but not the project level.  Turning it off for the project and target resolved the error.

I have the same issue with ArmchairLocalizable :
ld: -bundle and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together


poetry config requires pyproject.toml?

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: Arch linux
Poetry version: 1.0.0b1
Link of a Gist with the contents of your pyproject.toml file:

Issue

$ poetry config -vvv

[RuntimeError]
Poetry could not find a pyproject.toml file in /home/foo or its parents

Traceback (most recent call last):
  File "/home/foo/.poetry/lib/poetry/_vendor/py3.7/clikit/console_application.py", line 132, in run
    status_code = command.handle(parsed_args, io)
  File "/home/foo/.poetry/lib/poetry/_vendor/py3.7/clikit/api/command/command.py", line 119, in handle
    status_code = self._do_handle(args, io)
  File "/home/foo/.poetry/lib/poetry/_vendor/py3.7/clikit/api/command/command.py", line 167, in _do_handle
    return getattr(handler, handler_method)(args, io, self)
  File "/home/foo/.poetry/lib/poetry/_vendor/py3.7/cleo/commands/command.py", line 92, in wrap_handle
    return self.handle()
  File "/home/foo/.poetry/lib/poetry/console/commands/config.py", line 81, in handle
    local_config_file = TomlFile(self.poetry.file.parent / 'poetry.toml')
  File "/home/foo/.poetry/lib/poetry/console/commands/command.py", line 10, in poetry
    return self.application.poetry
  File "/home/foo/.poetry/lib/poetry/console/application.py", line 55, in poetry
    self._poetry = Poetry.create(os.getcwd())
  File "/home/foo/.poetry/lib/poetry/poetry.py", line 86, in create
    poetry_file = cls.locate(cwd)
  File "/home/foo/.poetry/lib/poetry/poetry.py", line 251, in locate
    cwd

In the latest 1.0.0b1, poetry config command seems like requires pyproject.toml file. But I think this is a bug.

Also encountering this issue

Same here, this is new, and breaks the build of one of our python build images

Just ran into this. This bug makes config command pretty much useless. Maybe it should have higher priority.

It should be fixed in the latest pre-release version


Unconditionally add GOPATH/bin to PATH

What this PR does / why we need it:
This PR changes E2E tests script to unconditionally add $(go env GOPATH)/bin to $PATH.
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/test pull-kubeone-e2e-aws-upgrade-1.14-1.15


[100 SigmaUSD] OraclePool should only be instantiated once and passed to the users

To avoid https://github.com/ergoplatform/oracle-core/pull/96.
Plus, there is no real need for all interested parties to have their instance.

Also, not all users need the whole OraclePool struct. If only one or two properties are used, consider passing them instead.

I thought about lazy_static, but I see it as a sort of "last resort". I mean it's essentially an immutable global var, which we cannot mock in tests. I'd prefer passing an instance as a parameter and if it gets too ugly, make it a lazy_static.

Do we need implement Sync for OraclePool first?

Do we need implement Sync for OraclePool first?

Good question. I'd keep it as simple as possible. If it becomes too much of a hassle, we can pass only needed fields as arguments.

For simplicity, maybe a channel and spawned OraclePool can be introduced. But the performance will be limited to single thread(or multi by mpmc and multiple spawned). Do you have any good idea?

For simplicity, maybe a channel and spawned OraclePool can be introduced. But the performance will be limited to single thread(or multi by mpmc and multiple spawned). Do you have any good idea?

Oh, it sounds way too complicated. It's essentially a bunch of parameters of simple types used to query the node. I mean, I'm not even sure that we need OraclePool to keep those "scans" together. I believe we can pass them directly to the interested parties. Also, *Scan types are not set in stone and can be altered if needed.

The bounty is sent. Thank you!


例程recognize编译失败

提示是缺失一堆数学函数sin,log之类。

If you can provide debug logs in the monitor, it will help solve the problem.
there are two tips:

Check your ESP-IDF version is release/v4.0.
In addition, you can try to use the latest commit

If you can provide debug logs in the monitor, it will help solve the problem.
There are two tips:

Check your ESP-IDF version is release/v4.0.
In addition, you can try to use the latest commit
编译时错误信息.txt
这是编译信息，用的是v4.0

最新版本的源码可以编译通过

This error may be due to  some problems in CMakeLists.txt. The latest code is recommended

@2502797718 If your question is resolved, please close the issue. Thanks!