scroll not working on search result page

papermerge 2.0rc48
latest papermerge core as of march 18
Searching works, and displays all the results, which can be seen if zoomed out alot. But I am unable to scroll. This is a fresh install on ubuntu , without docker.

I was able to reproduce this but. Thanks for opening this ticket!

Fixed. Will be shipped with (soon to be published) release 2.0.0.

Hi, thanks for this work
Has this amendment been published?😶


ci: fix and align GitHub Actions workflow

@Normo Could you please check this one? I would like to fix the ansible-lint violations in another change. Otherwise, I guess this change will be too complicated to review.


.root() returns text of a function

There's something weird going on here:

A bug that has been introduced recently?

ahh!
thanks. will check it out!

No worries :+1:
On 29 Apr 2016 10:33 pm, "spencer kelly"<EMAIL_ADDRESS>wrote:

ahh!
thanks. will check it out!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/nlp-compromise/nlp_compromise/issues/108#issuecomment-215737407

hey, i got this fixed, check it out in v4.9.1.
It's an undocumented/sorta-experimental method, my idea being text.normal() still needs to be readable, but text.root() can be way more aggressive. Let me know if it's doing what you'd like it to.
cheers!

Still returns function text for me. Tried in 4.9.1 and 4.10.1
Something I'm doing wrong on my side?
Cheers

hey joseph, i may have just forgotten to build it, should be fixed now
console.log(nlp.text('she sells seashells').root());
//she sell seashells

cheers

All good now! :+1:
Great work with the library - as it becomes more stable I think it'll come in handy on quite a few projects - thanks!


[5pt] Error in building HEC-RAS models for some feature ids

Running ras2fim for HUC 12090301, produces below error message for ~15 feature_ids:

The line of the error (line 606 in worker_fim_rasters.py) is the starting point of processing model results using RAS Controller.  However, opening the HEC-RAS model created by ras2fim for above feature_id (5789992) and trying to run it will fail as shown below:

Therefore, the actual bug is for the method ras2fim is building sub-models for those feature ids, which will result in failure of its HEC-RAS run (and then failure in processing model results).

Error Investigation
The above error occurs in function fn_create_hecras_files in worker_fim_rasters.py file where ras2fim applies a two cross section buffer for the most upstream and downstream cross sections of ras shown in red box below:

t
The preceding functions identify the index of the most upstream Xs (int_first_index variable) of the sub-model after conflating the parent model Xs with NWM reaches. In this section, ,


Error after install, loading the lua language server

I installed the quarto-kickstarter from scratch. I'm getting the following error when trying to access the settings from the starter page, or when trying to open any lua file:

"Spawning language server with cmd: lua-language-server failed. The language server is either not installed,  missing from PATH, or not executable."

When googling the problem I found a suggestion to have the following option added to the mason setup:
require("mason").setup({
     PATH = "prepend", -- "skip" seems to cause the spawning error
 })

I tried this, but, unfortunately, it did not work. Do you have any suggestion about how to fix the issue?

I'm expecting this to happen the first time you open the config, but afterwards Mason should automatically install the language servers. Try opening nvim and :Mason to check that this is indeed happening and don't close it until the language servers have been installed. Afterwards you should be good to go.

Worked. Thanks!


incorrect line and column numbers

Running the following document through scxml-to-scjson:
<scxml xmlns="http://www.w3.org/2005/07/scxml"
  version="1.0"
  initial="s1">

<datamodel>
  <data id="counter"
    expr="0"/>
</datamodel>

<state id="s1">
  <transition target="pass"/>
</state>

<final id="pass"/>

</scxml>

yields the following {local.name, line, and column}:
onopentag scxml 2 15
onopentag datamodel 4 11
onopentag data 6 14
onopentag state 9 15
onopentag transition 10 29
onopentag final 13 18

Intuitively one would expect the line and column to reflect the location of the beginning of the start tag:
onopentag scxml 1 8
onopentag datamodel 5 12
onopentag data 6 9
onopentag state 10 8
onopentag transition 11 15
onopentag final 14 8

There are a couple of issues here:

The SAX module provides line and column info using offset 0.
The SAX module updates the line and column when it encounters a \n which, as demonstrated in the above example, may occur before the onopentag event is emitted after all the attributes of the tag are consumed.

The fix is to hook the onopentagstart event and track the state of the line and column for use when the onopentag event fires.

@mattoshry Please try this again. SCION is now using a custom version of sax-js with better parsing behavior.


Lifes + GameOver

The level must be terminated when we our life count is 0, with a gameover basic menu (NOT HARDCODED)

Done.


[FR]: Field type to support YAML multiple values (not tags)

Contact Details
<EMAIL_ADDRESS>Present your request
Current DB-Folder Tags field type allow multiple values for a unique field, but those values are saved in DB settings to be used in the entire DB scope. It's perfect to be used to Obsidian internal tags field.
On the other hand, the Obsidian internal field aliases doesn't match any DB-Folder field type. aliases field is meaningful only to a specific row of the DB. For example, if I have "Microsoft Office" in a row, the alias could be "MS-Office" and "Office", but those values doesn't make sense to the other rows, so they couldn't be "suggested".
So I ask for a new field type that allows list without suggestions.
For which platform do you request this request??
Cross

Hi @www-wagner ,
So for example to use aliases like this example yaml?
aliases: Office, MS-Office
myValue: a
myValue:b

Dataview transforms aliases into an array an our current yaml writter show them as a dot list
aliases:
  - Office
  - MS-Office
myValue: a
myValue: b

Obsidian does not recognize the second format?

Let's show a better example.
If I have the following YAML field:
 or
In the UI, it shows as Text type field (truncated, because I can't resize to fit the contents):

If I delete the second item using UI, the things are messed up:

In this case, I have to update the row directly in the file, to keep the things right!
My suggestion is having another field type, like List or Array, to keep itens isolated from each other. Tags type couldn't be used because the values are related only to current row.

I guess could be easy to check if a text cell its an array or add a new toggle config per text column that interprets that it is an array

Let's show a better example.
If I have the following YAML field:  or
In the UI, it shows as Text type field (truncated, because I can't resize to fit the contents):
If I delete the second item using UI, the things are messed up:
In this case, I have to update the row directly in the file, to keep the things right!
My suggestion is having another field type, like List or Array, to keep itens isolated from each other. Tags type couldn't be used because the values are related only to current row.

would a temporary workaround be to use inline fields instead of yaml? Im on my phone right now, can’t easily test it out.
I run into this same problem because I use “quick add” plug-in to add to yaml bulleted list throughout the day. But if I make an edit in DB folder GUI, the reformatting essentially breaks my quick add shortcut.

with the last update of 2.7.2 we are refactoring the edit engine to support objects.
Could be a partial solution controlling arrays too
try to write [a,b,c] inside a text cell

With the next version you can use the text column as a list with [] wrapper
https://user-images.githubusercontent.com/11924043/207966083-3a696021-20fd-41f3-b751-efe5fd004832.mov

Well I thought using inline fields was a decent workaround, but with DB Folder 3.2.3, unwanted bullets are showing up. See picture. Would love to be able to use "quick add" to log multiple data into one field throughout the day. Any suggestions for accomplishing that? I was using a YAML method, but there were some problems with that.


question: check backend.tf file && opa policies from bundles

Hi, i am a very new user of tfsec, I have been reading your docs and so on, because I need to use opa to customize some policies.
But I couldn't find something with opa to check the backend.tf file where I define where the state is gonna be saved, so I found what you call "Custom Checks" https://aquasecurity.github.io/tfsec/v1.18.0/guides/configuration/custom-checks/
But even with that I don't have it clear yet, because the custom checks specify that is possible to define what type you want to check (requiredTypes) and this types are "resource, data, module, variable" and I don't know where my config fits on one of these options because my backend.tf file looks like this:
terraform {
  backend "s3" {
    bucket               = "bucket-name"
    workspace_key_prefix = "project"
    key                  = "path/to/tfstate/project.tfstate"
    region               = "region"
    acl                  = "bucket-owner-full-control"
    encrypt              = true
  }

  required_providers {
    aws = {
      source = "hashicorp/aws"
    }
    postgresql = {
      source = "cyrilgdn/postgresql"
    }
    random = {
      source = "hashicorp/random"
    }
  }

  required_version = "~> 1.0.0"
}

I've been trying with this custom check config:
checks:
- code: CUS001
  description: Custom check to ensure the S3 backend has the correct configuration
  impact: By not having key prefix we won't have the correct configuration for tf.states
  resolution: Add the s3 workspace_key_prefix, key fields and acl must be equal to "bucket-owner-full-control"
  requiredTypes:
  - resource
  requiredLabels:
  - backend
  severity: CRITICAL
  matchSpec:
    action: isPresent
    name: workspace_key_prefix
    subMatch :
      action : and
      predicateMatchSpec:
        - action : isPresent
          name : key
        - action : equals
          name: acl
          value : bucket-owner-full-control

When I try tfsec with this configuration there's no difference that if I don't specify custom checks
The command line that I use is:
$ tfsec /path/to/terraform/files
When I want to use opa policies is:
$ tfsec /path/to/terraform/files --rego-policy-dir /path/to/rego/policies
and my directory where I saved the custom checks and config for tfsec is the same where I execute the above commands in the ".tfsec" folder and its content is like we can see in the image:

is there a way to specify a block like the defined on my .tf file inside the custom checks?
or is it possible from a custom policy with opa?
also I would like to know if is there a way to download bundles of policies (many rego files) from a server and use them to check terraform config, this because the idea is to have these rego policies in a centralized server.

I'll really appreciate your answer, and thanks in advance for your awesome tool.

Hey @jSebastianAR  - custom checks might not be able to support this but I'll have a little go now.
In other news, we support Rego if you want to use that https://aquasecurity.github.io/tfsec/v1.22.1/guides/rego/rego/

You were pretty much there with your custom check - this works
checks:
- code: CUS001
  description: Custom check to ensure the S3 backend has the correct configuration
  impact: By not having key prefix we won't have the correct configuration for tf.states
  resolution: Add the s3 workspace_key_prefix, key fields and acl must be equal to "bucket-owner-full-control"
  requiredTypes:
  - terraform
  requiredLabels:
  - "*"
  severity: CRITICAL
  matchSpec:
    action: isPresent
    name: backend
    subMatch :
      action : and
      predicateMatchSpec:
        - action: isPresent
          name: workspace_key_prefix
        - action : isPresent
          name : key
        - action : equals
          name: acl
          value : bucket-owner-full-control

Apologies for the delay in responding - hope this is still useful


Limited size of large assets in light mode

In light mode, some images got out of bounds. Fixed it by limiting it's maximum width in a @raw html block.

And don't think this solves the core issue. Why is this happening only for light mode? Is there a problem with the CSS? Why is this problem not happening elsewhere?

The solution is to change center-images.css to:
img {
  display: block; /* Ensures the image behaves as a block element */
  margin-left: auto;
  margin-right: auto;
}


How to update components that use sapling?

For non-major versions, it should be as easy as updating the minor version, and calling it a day. Everything will be backwards compatible. There may be some cases where the component developer will have to make some changes on their end to get the new feature, but it is optional to do so.
For major versions updates, these will be breaking. This means that component developers must do some of the lift to get their components working with the new version of react-sapling.
We will provide a changelog for every minor and major versions of react sapling (which will also cover patches that were included).
The question is:
Is it worthwhile adding an "update" command that carries out these changes if possible? Is that reaching too far for a tool like this? It obviously can't cover all scenarios & updates, but could potentially save some time for the person trying to update components (especially when the number of components under sapling grows).

This is interesting. Looking at major libraries they have codemods which automate API upgrades, not sure what the changes would be like here...
I could see this getting pretty involved though.


Add SerializationContextInitializer#registerSchema(ClassLoader, Seria…

Closing as fixed by https://github.com/infinispan/protostream/commit/3d13f20679c10a7e31c35b5736fde75884ffdbd3


Add gorilla/websocket to list of packages provided

Currently the websocket package is not listed on http://gorillatoolkit.org, even though http://www.gorillatoolkit.org/pkg/websocket is available, and it appears to be the only top-level (non-helper) package missing.

Thanks :)


[Question] Rsyncing the dataset with WSL

Considering I have a Windows server with the Linux Subsystem, is the dataset and the files (Windows doesn't like certain characters in file names that linux supports) compatible with and will I be able to sync the dataset with rsync onto my NTFS formatted drive?

Hi, I've not found any special characters in gwern's dataset. The folders are numbers from 0000 to 0999 ; the filenames are all numeric; even the raw metadata files don't use special characters!
When I first downloaded the dataset (Danbooru2018) I did so on my Windows NTFS box.
Hope that helps!

Yes it has, thank you, I managed to pull the entire dataset, even if at times error 12 came up I seem to have everything!


[Card-14] Create README.md files

 Publish Package "Expandable Rich Text"

[README.md] https://github.com/DevCrew-io/expandable-richtext/tree/card-14-publish-package
[example/README.md]https://github.com/DevCrew-io/expandable-richtext/tree/card-14-publish-package/example
[CHANGELOG.md] https://github.com/DevCrew-io/expandable-richtext/blob/card-14-publish-package/CHANGELOG.md
[LICENSE] https://github.com/DevCrew-io/expandable-richtext/blob/card-14-publish-package/LICENSE


[UI]: Flash Messages are not disappearing after clicking on it.

After clicking on any Flash message, it is not disappearing. It should disappear after clicking on it.

@sbulage We changed to use the PatternFly messages that should have an X on the right to close them.  Is that not showing for you?


Updated to work with latest version of coverlet.collector

I couldn't get the existing version to work with version 3.1.0 of coverlet.collector due to changes in how it generates tests.
This new version runs the tests via: dotnet test --collect:"XPlat Code Coverage" with an optional --settings <path>/coverlet.runsettings. And when it creates the test runs, it places them in folders with procedurally generated names.
To make the library work with both the old and new versions, I made some updates. First, I introduced a couple optional parameters called filename and discover-directory. If neither are set, it operates pretty much exactly as it did before. If discover-directory is set to true, it'll try to get the directory by checking the directory in the path specified in path. If it finds one, it gets appended to the path, and the filename is appended to that.
The documentation still needs to be updated.

Correction on my part. While (as far as I can tell) the current version works with MSBuild integration, it does not work with vstest. My modifications will make the coverage reporter work for both MSBuild and VSTest. To use VSTest integration with my modifications, one simply needs to create a coverlet.runsettings file in the solution directory with the following contents:
<?xml version="1.0" encoding="utf-8" ?>
<RunSettings>
  <DataCollectionRunSettings>
    <DataCollectors>
      <DataCollector friendlyName="XPlat code coverage">
        <Configuration>
          <Format>opencover</Format>
        </Configuration>
      </DataCollector>
    </DataCollectors>
  </DataCollectionRunSettings>
</RunSettings>

And the test CLI command needs to be updated to be:
dotnet test --collect:"XPlat Code Coverage" --settings coverlet.runsettings

I'm currently looking at building a slightly different, wildcard-based version of this. Since actions can't use third-party libraries, I'm trying to come up with the most efficient way to do this easily.

Thanks for the PR @JerrettDavis, and I'm sorry for not having a look at it before now.
I just want to check up on the status before I merge it and release a new version. Is it still valid functionality that you would like to have added or is this deprecated?

Hi @simon-k. This code change should still be operation in its current state. I had hoped to expand it with pattern matching, but the submitted code changes do what is described in my original comment.


Extract support for SDKMS provider

Problem Statement
Adding support for dataFrom[*].extract to SDKMS / Fortanix provider
Proposed Changes
Implements GetSecretMap()
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

Hi @Skarlso! Are there any other pending changes I should do before this PR is ready for merge?


Not working in internet explorer.

Has anyone had any luck running this in internet explorer. Feed does not come across and there seems to be not related error in the console.

Oh? Which feed are you using?

Its a custom feed but it works all browsers except internet explorer.


feat: react tooltips, tooltips for table

Added tooltip link component
Added tooltip button component
Implemented tooltip feature in Table

@samspi Thank you for the PR!
I added a story for the tooltip and updated the docs for Table. Also, I removed the TooltipButton component (or rather moved it locally to table, where it is used internally), as I feel that it was a bit too specific to export as a public part of the library.


Max amount of fixtures

Hi. I'm currently on 2.0@beta and trying to load 100k database records through Alice. When i load 1.000 records, it's going within a second. When i load 10.000 fixtures, i'm given the warning that the database will be purged but after that, nothing really happens.
Is Alice/ this bundle meant for such an amount of fixtures? Or am i just doing it wrong? Is there a way to maybe load 10x 1.000 fixtures, instead of 1x 10.000 (without copy pasting the fixtures 10 times)?

Interesting question. I would say it highly depends on your fixtures. Alice by default is quite generic, and it allows you do generate a certain number of objects and then persist them. There a few potential bottlenecks:

The sheer number of data to generate. I don't know how big are the data sets of Faker, but I'm not sure it can generate 100K fixtures without a lot of redundancy.
The sheer number of objects: Alice have to load everything at once. It is not designed to receive a stream of files to load and output a stream of objects, simply because there might be dependencies between objects so this kind of architecture would be a complete nightmare to design.
The persistence layer: Doctrine ORM for example (but that's true for any ORM), does pretty badly at persisting huge amounts of objects.

The best use case for Alice I think is to load small amounts which fits specific scenarios you may need for integration tests, or enough data for a demo or something. If you want to load huge amounts of data, it is doable, but you'll have to dig in the library, identity the bottleneck and see how to solve them. There is actually a lot of places that can be optimized but are not done by default in Alice simply because it depends too much on your case and demands to know too much of your domain. But here's a few leads:

Being careful of Alice DSL. For example @user* requires alice to retrieve all the IDs and filter them to know which one are valid.
Watch of the unique flag. It is a very nice feature but a costly operation. Basically the idea is that a pool stores the values being used, have a max number of try, and when a value is being resolved/use, store it in the pool. If already there, will try again until obtaining a new value or reaching the number of try. Simple, but dreadful if you have too few unique data upstream.
There is a few places where Alice tries to instantiate, access to some values or set values in a generic way. While that works (and fast enough in most cases), it is certainly not as performant as you might want and you could replace that part by something more specific.
How you are loading files: by default, Alice tries to load all the files first and then persist them. As a result, all the objects are loaded into memory before being persisted, and they are all persisted at once... In your case I think you use a different strategy to be more efficient. It's not done by default because of potential dependencies between files, which Alice doesn't know about.
How you are persisting your objects: you could rely on a custom persister instead of Doctrine or another ORM to persist your objects in a more efficient manner.

TL:DR; Alice is not really meant for that. It's doable, but you'll have to dig into it.

Thanks for your response. Indeed I see Alice as a way to populate your database with realistic data. What im trying to do is pump a number of records in the database, to test various interfaces. Because later in my project i need the realistic data, i was trying to do it with Alice so i have one solution for all.
For now, for this, im going with DoctrineFixtures and just persist 100k rows, and flushing every 1000 rows.
Thanks again!


Add rizzo next to precompile, update to named AMD module

Rizzo Next needed to be updated to be included as a named module so that it wouldn't break when it actually ran in the browser. Also needed to add rizzo-next.css to the precompile so it gets deployed to s3.

:+1: from @laserchicken


ngbv always assigning version 0.0.0

I have a clone of this in my project. I believe that it used to correctly carry through the major and minor numbers from my package. Now, it seems that ngbv always assign version 0.0.0.
Was there an underlying change in the ngbv tool or the build system that would cause this? I don't think I've changed any of the build scripts for a couple months.

Sorry, pilot error. I was missing the version.json file in the project.


[Bug Report] el-select is broken by object as value

Element UI version
2.4.11
OS/Browsers version
Firefox: 63.0.3 ; Chrome: 70.0.3538.110
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/m7860gx9/2/
Steps to reproduce
Have any :value of the the el-option be an object
What is Expected?
The value-object gets inserted into the v-model and the label is shown as chosen the option's label.
What is actually happening?
The chosen label is actually just the label of the last option, while the v-model is still the correct value( the object).
When a chosen value is an object, all other object's option's labels are shown in blue.
When a chosen value is not an object, but they are present in the options, all options in the dropdown become blue.

A version with the object only being on a single option's value so people don't think it's due to non-unique value.

Something goes wrong in here:
https://github.com/ElemeFE/element/blob/dev/packages/select/src/select.vue#L531

Having the value BE the whole item also breaks the select, but differently:
https://jsfiddle.net/m7860gx9/4/

@wacky6 My original usecase was every possible value being an object. I think I'm using the key-value correctly here?
If it's meant that the value-key is the key to the choice object's value then that should just be 'value' here, right? Like so:
https://jsfiddle.net/m7860gx9/9/
I made every value unique too since it states "unique identity key name for value". I mean, the value key will never be unique so that might be a misnomer, but the option object's value on the non-unique key is unique.
But neither of these work correctly either

The correct usage for value-key is: https://jsfiddle.net/bqzeknc5/1/

@wacky6 Weird but thanks.

you can  using  JSON.stringify(item) for value of el-option


api_demo.py demo fails

getting toes wet with SchwabAPI.
I have a developer account, test application, and app key and secret.
Created simple web page using IIS.
updated .env with provided app key and app secret.
upon testing, apparently, the return URL from Schwab is not in the expected format.
Recommendations?
Test session recorded and available for view at:
https://www.youtube.com/watch?v=3h0hB0mOo54

Your app status is "Approved - Pending", you must wait for status "Ready for Use".

Yeah.  My bad . late night. Figured it out about 3am.  Did a Home ‘DOH!!!’ realized the time and went to bed
From: Tyler Bowers @.>
Sent: Tuesday, November 19, 2024 7:15 AM
To: tylerebowers/Schwab-API-Python @.>
Cc: Dan Murray @.>; Author @.>
Subject: Re: [tylerebowers/Schwab-API-Python] api_demo.py demo fails (Issue #37)
Your app status is "Approved - Pending", you must wait for status "Ready for Use".
—
Reply to this email directly, view it on GitHub https://www.google.com/url?q=https://github.com/tylerebowers/Schwab-API-Python/issues/37%23issuecomment-2485495545&source=gmail-imap&ust=1732623273000000&usg=AOvVaw3-1QV9cC-L4y1c4fG2IKDa , or unsubscribe https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/AHBTSJKCYSNQ6CAJQMEEKQT2BMTSPAVCNFSM6AAAAABSBGJ4NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBVGQ4TKNJUGU&source=gmail-imap&ust=1732623273000000&usg=AOvVaw1zJtZAdddSa4eeWLKnzqyL .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AHBTSJOL7ZPGDPC46YK72GD2BMTSPA5CNFSM6AAAAABSBGJ4NSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUUEWTPS.gif Message ID: @.*** @.***> >

Ok, closing issue.


Center map with raster dataset icon

Context
Go to a map, select a given vector layer and you will see it has a button / icon that helps the user to center the map in that precise dataset
Steps to Reproduce
See Context but try with a raster
Current Result
Raster dataset doesn't have that button right now
Expected result
Now that we can center rasters from the dropdown menu, it makes sense to have this option here

Done here: https://github.com/splashblot/dronedb/commit/a181512cd723bf9c5324f8b73906fcee7b746d7d


Small description on concurrency pattern examples

Adds description texts as comments on code. The texts are taken from the videos, with small changes where necessary.
Changes the read function name to readCSV, as was used already on the pipeline pattern example code.
Adds "\n" to a few fmt.Errorf

Thanks @dpsigor


Trigger - C# example - Code block mixes v.1.x and v.2.x syntax

[FunctionName("ServiceBusQueueTriggerCSharp")]
public static void Run(
[ServiceBusTrigger("myqueue", AccessRights.Manage, Connection = "ServiceBusConnection")]
string myQueueItem,
Int32 deliveryCount,
DateTime enqueuedTimeUtc,
string messageId,
ILogger log)
{
log.LogInformation($"C# ServiceBus queue trigger function processed message: {myQueueItem}");
log.LogInformation($"EnqueuedTimeUtc={enqueuedTimeUtc}");
log.LogInformation($"DeliveryCount={deliveryCount}");
log.LogInformation($"MessageId={messageId}");
}
This example is for Azure Functions version 1.x. To make this code work for 2.x:
omit the access rights parameter
change the type of the log parameter from TraceWriter to ILogger
change log.Info to log.LogInformation
The Code-Block mixes v.1.x and v.2.x syntax. The text below the code-block describes that log.Info should be changed to log.LogInformation - but this is already the case in the code block.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0440205f-adcc-0fc5-3adb-db4dbe1d1292
Version Independent ID: 14ad1300-590c-8102-6887-366078e1882a
Content: Azure Service Bus bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-service-bus.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@perkops Thanks for catching that! We will review and update accordingly.

@perkops We have worked up a PR to address this and which should reflect in a couple of hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Support device control from LIFF

1, Added new device control mechanism from LIFF
2, support version information
Added new characteristic to allow LIFF to control the device.
This is not require firmware change. Possible to read, write, and notify execution control from the LIFF side.

liff-starter.js は、starter ではないので名前を変えるべき

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: cpulabs:x: technoYou have signed the CLA already but the status is still pending? Let us recheck it.


Adds a configurable setting for hping interval and cleans up help

Hello!
This PR makes hping interval a configurable setting (and shows the default in hping help). Also cleaned up the syntax a little in hping help.
PS. This build might fail in travis because http/ping references github.com/mehrdadrad/mylg/cli and this PR has some changes in cli/config.go.

@gummiboll Thanks, just it needs the below change when you get a chance.
- Interval string `json:"interval" tag:"interval"`
+ Interval string `json:"interval" tag:"lower"`

this tag forces CLI package to make the argument to lowercase.

Heh, whoops. Knew that, I just failed. Fixed now :)

Changed the default interval to 1s for hping instead of 0s which seems a bit.. dangerous. 1s really isn't that much better but usually HEAD-requests are quite light.


include yaml files from other folders other than template

Can we include yaml files from other folders in helm or is this mandatory to have all yaml under templates for a helm chart.
Cloud Provider/Platform (AKS, GKE, Minikube etc.):  Azure

duplicate of #3276.


suggestion: cuboid full outline

Right now we have a get_outline tag for cuboids which return the corners of a cuboid and the lines connecting them. Could we have a similar tag that gets every single block on the outline of the cuboid?

... do you know what an outline is :o

IT NOT BOUT ENGLISH IT BOUT MAKING HAPPEN IT

cuboid.get_shell or somethin' ya feel


Filter

if you use filter and select just brand and not 2nd line then apply you get system.nullReferenceException : object reference not set to instance of object

Should be fixed up now. I think both are required


feat: Add GITHUB_USE_WEBHOOK environment variable

This new environment variable can be used to disable creating a GitHub web hook on new Insights. This is useful for local development situations where there is no public URL that GitHub can use to initialize the webhook.
The default is true so there is no change in behavior.
An error is logged if GITHUB_USE_WEBHOOK is true, but PUBLIC_URL is not set.

:tada: This PR is included in version 2.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ssh-add fails with "Error Loading Key: error in libcrypto"

I have this error when trying to clone submodule (private).
I add the public key on the submodule without the comment ; And I add the private key on the public repo with link to the private repo.

Is this still an active issue?
Seems to be an error message generated by ssh-add when trying to load a key.
https://github.com/openssl/openssl/issues/13443 might be related.

Relevant

Relevant

It helped me https://github.com/openssl/openssl/issues/13443#issuecomment-1354750805

TLDR; so basically You just add newline to make it works, thanks.


docker: fix binding on <IP_ADDRESS>

/cc @audub

I understood this is wanted for Mac OS.  Two comments:

Would simple port mapping without IP work well on that platform?  (e.g. - "29300:9300")

What about changing other remaining occurrences of <IP_ADDRESS> in Docker configuration and in the installation docs?

$ git grep '<IP_ADDRESS>'
Dockerfile:ENV INVENIO_WEB_HOST=<IP_ADDRESS>
Dockerfile:ENV INVENIO_WORKER_HOST=<IP_ADDRESS>
docker-compose.yml:    - INVENIO_WEB_HOST=<IP_ADDRESS>
docker-compose.yml:    - INVENIO_WORKER_HOST=<IP_ADDRESS>
docker-compose.yml:    - "<IP_ADDRESS>:5000:5000"
docker-compose.yml:    - "<IP_ADDRESS>:25432:5432"
docker-compose.yml:    - "<IP_ADDRESS>:26379:6379"
docker-compose.yml:    - "<IP_ADDRESS>:29200:9200"
docker-compose.yml:    - "<IP_ADDRESS>:29300:9300"
docker-compose.yml:    - "<IP_ADDRESS>:24369:4369"
docker-compose.yml:    - "<IP_ADDRESS>:45672:25672"
docs/installation/installation-quick.rst:  firefox http://<IP_ADDRESS>:5000/records/1
docs/installation/installation-quick.rst:  firefox http://<IP_ADDRESS>:5000/records/1
docs/installation/installation-quick.rst:  firefox http://<IP_ADDRESS>:5000/records/1


Typo on Bash code snippet

Under the "Create a resource group and Azure Container Registry" sub heading in Step 3:
ACR_PASSWORD=$(az acr credential show
--resource-group web-app-simple-rg
--name webappacr123
--query "passwords[?name == 'password'].value"
--output tsv)
should be
$ACR_PASSWORD=(az acr credential show
--resource-group web-app-simple-rg
--name webappacr123
--query "passwords[?name == 'password'].value"
--output tsv)

Package Name:
Package Version:
Operating System:
Python Version:

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
1.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@biggernaaz can you share a link for where you see this typo? I can't find it. Thanks!

@biggernaaz can you share a link for where you see this typo? I can't find it. Thanks!

Hi @kristapratico - https://learn.microsoft.com/en-us/azure/developer/python/tutorial-containerize-simple-web-app-for-app-service?tabs=web-app-flask
In this code snippet the $ needs to be in front of "ACR_PASSWORD=" I believe.
ACR_PASSWORD=$(az acr credential show
--resource-group web-app-simple-rg
--name webappacr123
--query "passwords[?name == 'password'].value"
--output tsv)
Corrected version:
$ACR_PASSWORD=(az acr credential show
--resource-group web-app-simple-rg
--name webappacr123
--query "passwords[?name == 'password'].value"
--output tsv)

Hi @biggernaaz , thanks for your feedback! Our doc team is working on it, I'll update here when the snippet is updated.

@biggernaaz We've merged the fix in our end, the portal content would get updated soon.

@biggernaaz We've merged the fix in our end, the portal content would get updated soon.

You're very welcome @YalinLi0312. Thanks for the heads-up.


How to remove the blue highlighting?

How can I remove the blue highlight color? This happened when there is no text selection.

It disappear when there is a selection:

I actually had this exact same problem, but I found an easy "fix". Go to settings and find sqltools.format. You will have to edit the settings.json. You will need to create  a variable highlightVariable, set to false. The default is true. This is what mine looks like:
"sqltools.format": {
        "reservedWordCase": "lower",
        "indentSize": 2,
        "highlightQuery": false
    },

Of course, only the second to last line, "highlightQuery": false is specifically relevant, but it shows you what it should look like in context.
Further down in my settings, I also found "sqltools.highlightQuery": false,.
Once all of this was set to false, it stopped giving me that highlighting, which I confess, I did not care for either.

@Choens thanks for contributing this solution.


Bump longhorn/backupstore version to add KubernetesStatus metadata to volume.cfg

Proposed Changes

Pass labels to backup volume structure
Add unit-test to test parseBackupVolumesList
Consolidate two backupVolume/BackupVolume structure into one
Bump longhorn/backupstore version to add KubernetesStatus metadata to volume.cfg

Linked Issues
https://github.com/longhorn/longhorn/issues/1539

Bump the longhorn/backupstore version, ready to review :bow:


Iterator::scan too limited

Surely for the simplest case, it works. However, the unfinished state may contain extra data that may hint us generate one or more Bs.
I believe the more sound way is call f for each item wrapped with Some(), and then call f with None until it yields None...

The issue is a bit unclear to me. Can you make a small example?

Suppose i want to write a tokenizer, that is, split a string into an array of strings containing each word.
One possible thinking is that store the unfinished word into the initial_state and send it out when it is finished. However for the last item, there's never the chance to do so, and the unfinished word inside the state get lost.

I see.
We can't change the stable Iterator::scan at this point. You're welcome to suggest a new iterator adaptor that would work better.
Be sure to look inside  other places in the crates.io package ecosystem. Those can host your new adaptor with a lower bar of entry, presumably.


CHAOS-5175 Guided onboarding

Guided onboarding to:

Discover services
Create network map
Create chaos experiments
Run chaos experiments
View resilience score

Preview

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66313339a645950621d382d2--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6631d241d551ba82cf166bd6--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66337f127d8336c20839d54b--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6633d4c833c9ad2926945bc2--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6634be6c207e47039b5b67de--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66385d0af6a8fe6ceaa6411e--harness-developer.netlify.app


Missing debug symbols.

Describe the bug
The debug symbols for Microsoft.WindowsAppRuntime.dll are missing for 1.4.1. The symbols for other libraries seem to be available without any issue.
Steps to reproduce the bug
Write an application that references and uses the Windows App SDK.
Run the application.
Check Visual Studio's modules window.
Expected behavior
The debug symbols are properly loaded for this library.
Screenshots
Screenshot showing the missing symbol file.

Screenshot showing other libraries from the Windows App SDK loading symbols correctly.

Screenshot showing the symbol loading settings are correct.

Screenshot showing that Microsoft.WindowsAppRuntime.dll isn't excluded.

NuGet package version
Windows App SDK 1.4.1: 1.4.230913002
Packaging type
Unpackaged
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

@DarranRowe thanks for reporting this.  It will be resolved in the next release of Windows App SDK.

This has been resolved with https://www.nuget.org/packages/Microsoft.WindowsAppSDK/1.4.240211001


Replace 'new Date()' calls in the client side code with native methods from hammerehead

If the client code of the tested site overrides the Date constructor, the TestCafe tests will be have a lot problems with timeouts.

Duplicate of https://github.com/DevExpress/testcafe/issues/5447


Add documentation for the `Description' field of Java action parameters

As this is part of 6.10, I changed the base branch to 6.10


Rename IEventData to IEvent

EventData to Event

applied with https://github.com/stoveproject/Stove/commit/04db39adc441ceebc7b783a721d2cfbb484cb56b


Compatibility issue with elasticsearch version 8.0.0

It's basically a feature request. Need this plugin to work with elasticsearch version 8.0.0.

Hi, is there any progress on that?

@ReyanshKharga , @grzegdl I have a (hopefully temporary) fork with v8.x build available. Perhaps it can be of help?


Set app window size to 90% of screen size instead of fixed 1200x760

I don't know if this bothers anybody else but the first thing I do when I open OB is resize the window! I'm running on OSX, and unlike most other OSX apps, OB doesn't "remember" if its window size was manually adjusted the last time it was run. I find the default 1200x760 too small, it cuts off the bottom of the first row of listings (see screen shot) and I personally just like every app I interact with to use as much screen real estate as possible. I find this 90% setting much more satisfying to interact with, and still leave a margin around the app to click the desktop, etc.

Here's the "after" with window size at 90% of screen size... NICE!

@morebrownies what do you think?
I don't know if we want to set it to scale for all users, since it was designed for a particular width.
Maybe we could add in whatever is needed to have the app remember it's last size?

It looks like there isn't a built in way to remember the last window stat in Electron. There are a few libraries out there that could help.
https://github.com/mawie81/electron-window-state
https://github.com/Sethorax/electron-window-state-manager


bpf-linker: 0.9.12 -> 0.9.12-unstable-2024-07-31

Diff: https://github.com/aya-rs/bpf-linker/compare/v0.9.12...7585ff7c0709bae13f2ad25f421450d493b02c1a
Description of changes
In case we don't get a response in time: https://github.com/aya-rs/bpf-linker/issues/218

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc @l2dy @nbdd0121 @cpick


TLS 1.2

Mailchimp will soon deprecate TLS 1.0 and 1.1 support: https://devs.mailchimp.com/blog/tls-1-0-and-1-1-deprecation/
What's the best way to enforce TLS 1.2 with gibbon?

FYI I've released Gibbon 3.2 including this change. I went w/ 3.2 b/c it could be a breaking change depending on one's server configuration.


Please officially add Teensy 4.0 and 4.1 support

Recently, the ArduinoXInput_Teensy library added Teensy 4.0 and 4.1 support, and I wanted to ask if you could adapt the SBC library to work with them as well. Also, could you please update the instructions on Hackaday to reflect these new developments?

I spent several hours getting this to work today.
Good News!  Nothing has to be done to the library at all, you just need to install the latest version of Teensy.
Just copy over the new Xinput files:
https://github.com/dmadison/ArduinoXInput_Teensy/releases/tag/v1.1.1
And then in Arduino go to Tools->Manage Libraries
in the Library Manager select Xinput and click Update, you should be at version 1.2.6
I suggest testing it with the HIDjoystick example and follow the hackaday instructions to test.
WARNING!!!
what took me forever tonight to figure out was that my XBox->USB adapter was not making proper connection.  I may end up replacing the entire USB cable to go straight to USB as I have never owned an original XBOX.  I had to push on it with my thumb to make sure the connection was good.

I updated the site as well.  Thanks for bringing all this to my attention.


fix(provider): post state get didn't get receipts

Provider for getting PostState was not faulty and didn't insert the receipts.
Added tests data and fixed the bug.

Codecov Report

Merging #2360 (5bcb9d7) into main (e2c2707) will decrease coverage by 53.21%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2360       +/-   ##
===========================================
- Coverage   72.05%   18.84%   -53.21%
===========================================
  Files         480      480
  Lines       58130    58149       +19
===========================================
- Hits        41886    10960    -30926
- Misses      16244    47189    +30945

Flag
Coverage Δ

integration-tests
18.84% <0.00%> (+<0.01%)
:arrow_up:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/storage/provider/src/test_utils/blocks.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

crates/storage/provider/src/transaction.rs
0.00% <0.00%> (-89.86%)
:arrow_down:

... and 328 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LGTM but missing context here on what this is fixing, was it assumed to be faulty before?

Updated the description.


Add white/black list

What would you like to be added:
Filter for white/black, can be ip address, backend endpoint.
Why is this needed:
Control if ip can request to backend or backend can be call by proxy

get


Cosmos DB SDK Performance Windows vs Linux Azure App Service

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
This is not a bug but a query, didn't find a template for query. Based on below Stack overflow discussion Cosmos DB SDK has different performance in Windows and Linux platforms, can you please confirm if it still holds true with the latest SDK version?
https://stackoverflow.com/questions/63447218/performance-issues-in-running-net-core-apis-in-azure-app-services-for-linux
Expected behavior
No performance difference between Windows and Linux.
Environment summary
SDK Version:
OS Version:  Windows & Linux

@joshidp That Stackoverflow post does not contain any technical evidence nor examples of how the measurements were taken, what was the volume, frequency or length of the test. I would not consider that source of any valid information.
In order to compare performance you'd need:

Processor level information
Number of cores/RAM
Length of test, minimum 1 hour.
Latency measurements: P99, P95, P999.
Exact code that is performing operation (in the post it says "Simple Ping", what is that? or "15 parallel calls to Azure Feature Management", that is not an SDK operation)

The only operation that I am aware of that might have some difference is executing Queries that require a Query Plan: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/performance-tips-query-sdk?tabs=v3&pivots=programming-language-csharp#use-local-query-plan-generation, on Linux, obtaining this Query Plan would require an extra network call. But this is only on Queries (which have no latency SLA) and only for queries that need a Query Plan.

Thanks @ealsur  for the response.
What are the criteria's for "query plan generation", in below link it's mentioned that " Queries that don’t require distribution can confidently skip some processes, such as client-side query plan generation ", can you please explain this. Is there a way to know this before-hand without running the query?
https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/performance-tips-query-sdk?tabs=v3&pivots=programming-language-csharp#use-local-query-plan-generation,

@joshidp Not an expert on Query but "don't require distribution" probably means they are Single Partition queries: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/performance-tips-query-sdk?tabs=v3&pivots=programming-language-csharp#use-single-partition-queries
@neildsh might know more about what other types of queries might not require Query Plan.

@joshidp
Some single partition queries may require distribution and some cross partition queries may not. Distribution loosely refers to any type of client side post-processing of intermediate results coming from the server. Whether a query requires distribution depends on actual query and in some cases the collection & query execution configuration.
Please find some examples below. It also talks about a feature released recently (in preview for opt-in at the moment) intended to optimize execution in some such cases:
https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/performance-tips-query-sdk?tabs=v3&pivots=programming-language-csharp#optimizing-single-partition-queries-with-optimistic-direct-execution


 within template

Hi,
I am using Handlebars.Net to generate HTML pages, I need to set some JavaScript vars within the template, but noticed that any tokens within
What would be the solution? I'm keen to keep the script in the templates rather then output via a helper.
Thanks

Handlebars treats the entire template as a string; it doesn’t have any notion of HTML JavaScript. Suggest you post the parts that are giving you trouble to see what’s wrong with them.


How to setup Gigablast to provide results in "Videos" ???

Hello.
Gigablast is able to return Web, Images and News results.  But do not return search results in Videos.  Is there a way to allow Gigablast to provide results in "Videos" ???
If so, how to set this from the Administrator's area ???

hello do you have gigablast running?
pls see my issue in images and install
i cant get it running
if you did can you kindly provide how?
Lisa
thank you

Hello.
I can help you to run gigablast search engine by all its dependencies.
Email me<EMAIL_ADDRESS>


Document incompatibility with gradient clipping

Hello, thanks for the great optimizer. I think the README should warn users not to use gradient clipping. During a failed model training postmortem, we realized that gradient clipping was confusing the prodigy optimizer, causing it to use inappropriately high learning rates. I didn't figure it out until I examined the prodigy internals for clues.

Hi, thanks for coming by to share the feedback!  We've used gradient clipping to have norm not exceeding 1, and Prodigy seemed to work fine. So the specific reasons it didn't work well in your case are a bit unclear to me, can you share more information about your setting?

Hmm, interesting! Yes, we were norm clipping using a value of 5. We were smoke-testing a new library using a vanilla resnet50 with the optimizer swapped out for Prodigy.
When we trained for 1 epoch using Prodigy, the gradient norms were pinned at their max value of 5, and the dlr kept steadily climbing up until we would start getting spikes in the loss and infs in the gradient norm. I happen to have put a screenshot in my experiment notebook, here:

x-axis is mini-batch count.
When we disabled gradient clipping and repeated the test run, the dlr looked more typical: it found a stable equilibrium, and would take occasional steps up. Overall, the dlr plateaued at a value 20x  lower than with grad clipping enabled. Unfortunately I did not put a screenshot in my experiment log.


Update Github Workflow

Hi @yaronzz I've updated the Github Workflow to fix the Node.js 12 warnings.

@yaronzz can you look at this PR?


Using with Duende

Hi @mallibone ,
Using this example with Duende client that is configured for 'CodeFlowWithPkce'.  It returns a valid code, session_state, etc. after authentication but no AccessToken.
Have i configured my client incorrectly?

Hey @pvanroos, I hope you have solved your problem so far? (Aka, sorry for the late reply.)
If you are getting a valid code, you are halfway there. Since the initial response from the Identity Service (in your case, Duende) will reply a code. You can then get the Access Token (and the other tokens) by requesting it from the Token endpoint, which the OIDC client does automatically based on the reply of the IBrowser.

That's great.  Thanks @mallibone


.zip release is no longer available

Contour Terminal version
<IP_ADDRESS>45
Installer source
GitHub: release page
Operating System
Windows 11 23H2
Architecture
x86-64
Other Software
scoop 0.3.1
Steps to reproduce
Hey! this isn't really an issue to "reproduce" so I'll just use this field to explain the problem.
I noticed that my package manager (scoop) hasn't automatically updated it's contour manifest.
I tried to investegate and looks like it tried to look for the .zip and didn't find it, and indeed .zip releases were removed in https://github.com/contour-terminal/contour/commit/7ea39920fe76a48e63f15a2ed6a4a7ecf0cf73df right before the <IP_ADDRESS>45 release.
This is a bit problematic because the .msi release cannot be silently extracted, instead the user has to face the "unknown publisher" dialog and click stuff to proceed since the .msi doesn't have a security certificate.
Expected Behavior
Keep .zip release for Windows or use security certificates.
Or in case I haven't looked hard enough please point me to the relevant discussion 😅
Actual Behavior
.zip releases are no longer available
Additional notes
Thanks for making great stuff!

Hey @T-727 Oh many thanks. We'll soon be releasing 0.4.1 (this year ASAP). We'll be re-adding .zip files for Windows again. Many thanks for your feedback. Is it okay to wait for a couple of more days for 0.4.1 to also include a win64 ZIP package?
Have nice Christmas days.

We'll be re-adding .zip files for Windows again.
Great! Thank you so much.
Is it okay to wait for a couple of more days for 0.4.1 to also include a win64 ZIP package?
Absolutely, take your time.

Thanks also for the quick response 😄
And happy holidays to you too


Callback to _unsubscribeSocket is not needed since unsubscribe can never fail

E.g. Here: https://github.com/SocketCluster/socketcluster-server/blob/master/scserver.js#L535
Having this asynchronous logic can affect the order of 'unscribe', 'disconnect' events so it's better keep it synchronous.
Unsubscribe events can never fail before Node.js IPC guarantees delivery unless the socket connection fails; in which case the broker will automatically unsubscribe the socket - So it's not possible to end up with stale subscriptions once an unsubscribe message has been issued to the broker.

Fixed in socketcluster-server v11.0.0.


Make a training document for how to add a PDF to Weekly update

Document the steps to add a weekly update PDF for new content creators.

[x] Make a steps document with screenshots
[x] Convert it to PDF for later reference
[x] Train Kalin Kipling on steps
[x] Send her the PDF

Draft document: https://docs.google.com/document/d/1GqFP-owCQgHLg1TGudtGEKTdQm96D6xydtOGCwtc97c/edit

Trained Kalin and had her publish the 1/10/22 update. All went well.


Update changelog for v1.14.0

Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

There's a breaking change in Jaeger 1.14, but I'm not sure there's something we can do in the Jaeger Operator side. @pavolloffay, could you confirm whether noop is a valid upgrade step from 1.13.1 to 1.14.0? This is what I see in the Jaeger's changelog:
Create ES index templates instead of indices (#1627, @pavolloffay)

This can break existing Elasticsearch deployments if security policies are applied.
For instance Jaeger X-Pack configuration now requires permission to create index templates - manage_index_templates.

The first commit in this PR includes all the changes between the versions. The second commit is my suggestion for the changelog. Let me know if anything from the first commit should be reinstated.


The PyPI package is no longer maintain due to some reasons

All our users,
Glad to create and maintain this project, and happy to know people love it. From the stat, I see every day hundreds of people visiting this repo and using this work. We've also made a PyPI for you, packing all the need for convenience. Many users have involved in this project, contribute your code and report issues.
But I regret to tell you we've just lost the PyPI repo a few minutes ago, I just received a notification mail from PSF said the ownership of the tensorboard PyPI repo has been changed to Google. Without any acknowledgment from me :(
As I've mentioned in #19, a guy from TensorBoard dev team reached me, maybe a month ago, and asked me to give up the ownership as they're going to release the TensorBoard on its own so they want the tensorboard name.
I understand his concerns and respect the work the origin dev team have done. I was going to work with them, trying to push the Standalone TensorBoard a step forward, which is the motivation of this project, to make it benefits even more users. We even discussed possible ways to keep my project's stability, backward compatibility(to merge the logging part back to TensorBoard) and the value of creating a framework-independent layer for logging summaries, then achieve our goal. But I have some work to do before directly hand over the repo to them, as the TensorBoard dev team is in leading position, then I was waiting for their plan.
But the discussion was not satisfying, as the guy from TensorBoard said they're going to keep having TensorFlow as a runtime dependency, which means, even we use the TensorBoard they've released, you still have to log the summary via TensorFlow. He said they might provide a configuration endpoint for our project to change the final built binary tensorboard so there won't be any confusion. But I haven't seen that tool. Throughout the conversation, it made me feel that I have no choice but to do as they want. Besides, I'm going to change the project name(as they want) by using the independent version TensorBoard but failed to do so, because of the TensorFlow dependencies.
Then a guy from PSF came to me and asked me the same thing. I have to claim the rights I have as a PyPI user, the work I have to do as a project maintainer, and explain the objectives of this project and why we do so. Here I want to tell everyone, the reason I kept the tensorboard name is, same as most of the users, that I appreciate the work the TensorBoard team have done(you can also get this message after you read the headline of this project). The PyPI tensorboard we've provided is also for convenience, people won't have to install TensorFlow to use TensorBoard. I have no interest in the name itself, but to provide a pure, framework-independent TensorBoard, a real open-sourced tool.
We'll keep going in this direction, but seems we're not allowed to use words like tensorboard or even tensor I guess, I wish I can use PyPI without afraid of losing it overnight. For our users, we'll keep the source code building method and provide another PyPI after we finish the work.
Here I want to call for your contribution, let's make a real open-sourced project for every deep learning lovers. I guess maybe it's time for me to learn some frontend or backend web dev skills.
Best,
Zihao

Big thanks to Zihao for the extraordinary work of this standalone tensorboard project. I have used this tool in my research and I feel very happy with it. I know many other teams and companies are using it too, and, well, they might feel upset losing it. I see the true spirit of open source from this project: making it open and benefit more people.
I feel very sad that Google took the repo just for themselves, refused to add backward compatibility and discarded all we non-tensorflow users: they didn't even act like a gentleman but just grabbed it from PSF.
Let's think positive: I agree with Zihao that, it can be a good milestone that we can start from scratch and build a tool without any 'tensor' inside, and provide to all MXNet/Caffe(2)/CNTK/Chainer users.

In my understanding, Google team first develops tensorboard to ease the visualization of tensorflow. Because of their API design, it is also possible for those non-tensorflow users to use this. I don't know why they didn't register tensorboard on PyPi at the beginning, but their request is reasonable, since they contribute much more to tensorboard project.

@Lyken17 no, Google doesn't have any plan to merge the change for non-tensorflow compatibility, all they want is the PyPI repo, that is it, so they use their legal power to press on PSF and take the repo. I don't think it follows the open source way, ironically Google claims they welcome open source. It feels like Hooli in HBO's Slilicon Valley where Gavin Belson can take anything he wants.

Would like to cc @rajatmonga FYI so we have a complete two-sided story.
Disclaimer: I am not a stakeholder. Am only told about this incident afterwards. Being friends with both dmlc and google, I hope things are / have been addressed in a friendly manner.

Thanks for adding me @Yangqing
We did build TensorBoard for TensorFlow users, however looking at all the usage across many different projects, we decided to separate it out into its own project so it would be easier to use for many more projects. Along with this change we would like to make it available directly on PyPi - again the goal is to make it available to everyone.
@zihaolucky we appreciate all your work you have done to support this community. Our move is not intended to make it harder for you and others, but easier. Our current changes will make it easier to  add new changes and also make them more maintainable. Unfortunately in the short term this may mean some breaking changes - although our team is looking hard to see how we can make this transition happen with the least concern to the community.
We would love to see more collaboration with the community around making TensorBoard better for all. Please do not hesitate to reach out to me for things I can help with.

@rajatmonga thanks for the nice other-side-of-story. As a user of @zihaolucky 's standalone tensorboard, I'm very uncomfortable where this is going. Thanks to @zihaolucky, I used to be able to use the visualization tools in tensorboard with other machine learning frameworks, such as mxnet, caffe2, and pytorch, without suffering the hunk of tensorflow dependency. Now I can't. Great job "to make it available to everyone".
It's frustrating to see how inconsiderate and indifferent certain google teams can be about making breaking changes. I feel very sorry to see the actions the team at google decided to take against the contributor of its own open source project, including demanding access without any intention of working with the contributors in the community, threats, and forcibly depriving contributor's access and nullifying his work. The Tensorboard team member certainly has a funny way of showing that "we appreciate all your work you have done to support this community".
As much as I'm disappointed as a user, what's done is done, evil or not. Going forward, I sincerely hope that @zihaolucky won't be devastated by this, and that there will be even more awesome visualization and monitoring tools coming from @zihaolucky and the community, without a fat dependency such as tensorflow.

@rajatmonga Thank you for your reply. Thank @szha and @Yangqing for bringing up the further discussion, the number of potential or actual users of this project might be more than I can imagine.
Dan has written me about this and we have a friendly discussion at the beginning, mostly on how he'll help this project move smoothly and their plan on developing TensorBoard, then I got his reply that they would keep the TF dependency. Then things went wrong and we haven't settled a proper solution for both of us, then a lawyer from PSF came to me and then this unhappy event came afterward.
I acknowledge the issues of the name tensorboard, at first I think if Dan took actual help like help me changing the project an 'appropriate' name, finish the work then everything could be done. I would definitely give the PyPI to him as I've said in the first email that I would give him the control after we finished the necessary work.
But the lawyer from PSF came and that annoyed me. Why? As an individual contributor like many others in the world, I maintain the project after work and it's impossible for me to work as a full-time engineer like him. And I think he might want to be more active on this issue.
In my point of view, a proper solution for this argument is to make both projects go step further, the TensorBoard has its own repo and PyPI named tensorboard, the standalone version in this project supports more features as the origin TensorBoard provides, such as embedding, currently we have scalar, histogram and image.
@rajatmonga could you help our community by providing this embedding feature? I think @Yangqing, @szha and many more users are happy to see this. Thank you!

@rajatmonga Thanks for the explanation. But is there a schedule as to when tensorboard will support other framework?
As @zihaolucky has said, this incedent was easily avoidable, should google tensorboard team had shown some interest on merging the changes in this repo. Sadly, the damage had been done. So now it leaves us in doubt if you and you team is really interested in making Tensorboard available for other framworks. If you are, which is great, then you must have a schedule. Please show it to us, and we would be more than happy to do whatever we can to help. But withput a solid schedule, it is hard to believe your team has taken that into consideration. And it is then obvious that you have taken the PyPI repo by force only for the benefit of the company, but not for the interest of the outer world.

@hjk41 we are happy to accept contributions to the main TensorBoard repo to make it easier to use with other frameworks. The team is interested in collaboration, but that is hard if the other party stops responding.
Here are the steps we are taking to help:

PyPi today still contains the project by @zihaolucky.  It should be easy enough to put this project on another name repository on PyPi - my understanding is that @zihaolucky is now planning to use tensorboard-lite on PyPi. Once you put this out, we are happy to add documentation on PyPi TensorBoard pointing users to this site.

We are looking to support the APIs provided by this project in the TensorBoard repo as well. If you are interested in helping with this, it may go faster. That way when the TensorFlow/TensorBoard project gets published on PyPi it can be compatible with your users. Note: This is hard as the TensorBoard project has moved ahead of this fork, and is going to be a maintenance burden for us.

The last concern for this group is the dependency on TensorFlow. This will take a bit more work to remove, but it does make sense to keep it independent and we will remove it.

Overall we are trying to be good citizens and helping as many users as we can - there are lots of TensorBoard users that don't use this fork, and we need to consider them as well. Maintaining forks is hard, and we can't sign up to maintain/support a fork of our own project - that is not how open source moves forward. We are happy to support more collaboration on the main TensorBoard project itself.

As a previous open source committer, I always appreciate inspiring from each other. I think tensorboard is a trademark of Google, so surely Google should have right to take the PyPI. But as all of our goal is same: AI democracy, I believe we can achieve the goal in cooperate way. Looking forward to pushing forward the technology together and achieving AI democracy. @rajatmonga @Yangqing @zihaolucky

@antinucleon Agree.


Support downloading byterange manifests with aria2c

Checklist

[X] I'm reporting a feature request
[X] I've verified that I'm running yt-dlp version 2021.10.22. (update instructions)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
Support external downloaders such as aria2c to be able to download concatenating requests from m3u8 streams. An example of one is listed below where the audio is separated from the several video streams.
This would allow these m3u8 streams to be downloaded much faster than the default built-in downloader.
https://gist.github.com/Golumpa/78038929ac5bafb3478bf3b9a0f40596

It's already supposed to be supported, but as an alternative you could try -N 16 with the native downloader.

The given manifest uses byterange which aria2c does not support. Otherwise, fragmented downloads through aria2c is already supported

OP's actual issue is that some funimation videos cant be downloaded with aria2c since it is a byterange based manifest. This is expected behavior since aria2c doesnt allow us to specify the byteranges.
However, in funimation's case in specific, the server allows requests without byterange and so support for this can technically be added in the future for specific extractors that we know works with arbitrary byteranges

However, in funimation's case in specific, the server allows requests without byterange and so support for this can technically be added in the future for specific extractors that we know works with arbitrary byteranges

This can be tracked in https://github.com/yt-dlp/yt-dlp/issues/1507


Add new Microsoft certificate thumbprint

There is a new certificate thumbprint for the Microsoft signing certificates used to sign NuGet packages.

I merged this to unblock @mjcheetham's next steps tomorrow.


connect.multipart() and connect.limit() will be removed in connect 3.0

I'm getting those errors/warnings on startup with v0.8.1:
=> Meteor server restarted
(STDERR) connect.multipart() will be removed in connect 3.0
(STDERR) visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
(STDERR) connect.limit() will be removed in connect 3.0

Whoops, unrelated to restivus.
Its a json-routes issue https://github.com/stubailo/meteor-rest/issues/18

Thanks for submitting that PR for simple:json-routes. I've updated the dependency in Restivus to the latest version, so the deprecation warnings are gone. Restivus v0.8.2 is now published with these changes. Great work!

\o/


Add a GetCertificateWithContext function

This basically would allow us to pass a context into the "certmagic world", from which it then would get passed through back to our storage implementation.
The reason we want that is so that we can actually set up application performance monitoring by instrumenting the calls.
Note that this does add a new public function, but unless you specifically set your GetCertificate in the TLSConfig to something that uses this function, everything should stay the same.
Our setup looks like this, very simplified:
certmagicConfig.Issuers = []certmagic.Issuer{acmeIssuer}

tlsConfig := certmagicConfig.TLSConfig()
tlsConfig.GetCertificate = func(clientHelloInfo *tls.ClientHelloInfo) (*tls.Certificate, error) {
	txn := monitoring.StartTransaction("TLS/GetCertificate")
	defer txn.End()
	txn.AddAttribute("hostname", clientHelloInfo.ServerName)
	txn.AddAttribute("supportedVersions", supportedVersionsToString(clientHelloInfo.SupportedVersions))

	// ... do some checks here to make sure we want to handle this request

	ctx := newrelic.NewContext(context.Background(), txn)
	cert, err := certmagicConfig.GetCertificateWithContext(ctx, clientHelloInfo)
	if err != nil {
		// ... review the error and possible ignore it/handle it differently
	}
	return cert, err
}

Hi, sorry for the lack of reply -- I'll be getting around to this soon as I prepare the Caddy 2.7 beta 1 release :)


Mipmap generation breaks at very low resolutions

Godot version
4.0.dev
System information
Windows 10, GTX 1070, 496.49, Vulkan
Issue description
While implementing FSR for the upcoming 4.0 release, a bug was discovered where if the render target was at very low resolutions, mipmap generation would fail because it would request more mipmaps then allowed.
Steps to reproduce
In any project, enable FSR and set the quality to as low as it goes
Minimal reproduction project
No response

Does this occur with textures that use Lossless compression (instead of VRAM Compressed)? You can change a texture's compression mode in the Import dock after selecting it in the FileSystem dock.

Does this occur with textures that use Lossless compression (instead of VRAM Compressed)?
This issue does occur when textureless objects are in the scene, so it does not appear to be related

I think I have the same issue with generating mipmaps on NoiseTexture3D. Godot requests more images than it is possible with pixel size.
Good example would be setting texture size to 1x1x2, which results in an error: Data for slice index 0 (mapped to layer 0) differs in size (supplied: 12) than what is required by the format (8). format is RGBA8 (1 pixel = 4 bytes size).

This issue is a huge roadblock (straight up impossible to create planned feature set) in implementing NoiseTexture3D resource.

In the meantime, you could probably disable mipmap generation if one of the dimensions is below a specified size.

This issue is a huge roadblock (straight up impossible to create planned feature set) in implementing NoiseTexture3D resource.

In the meantime, you could probably disable mipmap generation if one of the dimensions is below a specific size.

I don't think that's a good idea, it would be better to just wait for fix or add mipmap generation later, or I could clamp depth to width but that would be sketchy anyway. Clamping depth to width seems like the best option tbh, it would work well with fog as that's the main use case for it.


Not for reivew

Codecov Report

Merging #13810 into main will decrease coverage by 0.08%.
The diff coverage is 51.20%.

@@            Coverage Diff             @@
##             main   #13810      +/-   ##
==========================================
- Coverage   59.93%   59.84%   -0.09%
==========================================
  Files         684      686       +2
  Lines       37962    38053      +91
  Branches     5466     5481      +15
==========================================
+ Hits        22753    22774      +21
- Misses      14048    14097      +49
- Partials     1161     1182      +21

Impacted Files
Coverage Δ

...ent/pythonEnvironments/discovery/locators/index.ts
85.71% <ø> (ø)

...nments/discovery/locators/services/pipEnvHelper.ts
25.00% <25.00%> (ø)

...discovery/locators/services/windowsStoreLocator.ts
63.26% <28.00%> (-28.74%)
:arrow_down:

...pythonEnvironments/common/environmentIdentifier.ts
88.88% <50.00%> (-1.59%)
:arrow_down:

.../discovery/locators/services/currentPathService.ts
79.68% <50.00%> (-10.79%)
:arrow_down:

src/client/interpreter/interpreterService.ts
65.30% <66.66%> (-0.32%)
:arrow_down:

src/client/common/platform/fileSystem.ts
80.07% <87.50%> (+0.23%)
:arrow_up:

...ts/discovery/locators/services/KnownSearchPaths.ts
95.45% <95.45%> (ø)

...client/interpreter/autoSelection/rules/baseRule.ts
94.91% <100.00%> (+0.08%)
:arrow_up:

src/client/interpreter/contracts.ts
100.00% <100.00%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d1bc1...3b7759b. Read the comment docs.


[$2000] Workspace - Deleted user from workspace can chat in previously created workspace room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create WS
Add member X
Create room (member X is added, as he is in WS)
Send some message s in the room
Delete member X from WS
Send some messages in the room

Expected Result:
Member X should not see messages in the room as was eliminated from workspace
Actual Result:
Member X continues to stay in the room and can see and send messages, but with room tag "unavailable workspace"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/223731729-2947b5bc-c0d8-4180-ab65-eb5321055971.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019fa2485ed55ee079
Upwork Job ID:<PHONE_NUMBER>408375808
Last Price Increase: 2023-03-29

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hi @kbecciv was there a slack channel for this one?

Hm I'm also unable to reproduce this. What I did was this:

Create WS on one browser
Add member X
Go to incognito and sign is as member X, open the announce room
Go to announce room for WS, write message from the creator
Confirm in incognito that member X sees message
Delete member X from WS
Send some messages in the room

member X was immediately removed

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

@kevinksullivan I think you did not follow the steps:

Create a new WS
Add user to WS
Create room (member X is added, as he is in WS)
Send some message s in the room
Delete member X from WS
Send some messages in the room
I can reproduce the issue with latest build <IP_ADDRESS>

https://user-images.githubusercontent.com/93399543/226662452-4b54108e-48fa-472d-a114-b617a8d8c539.mp4

Ah, thanks for breaking that down and reproducing again @kbecciv . Going to export!

Job added to Upwork: https://www.upwork.com/jobs/~019fa2485ed55ee079

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

Triggered auto assignment to @joelbettner (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@kevinksullivan you only need to add the External label. Adding External and Engineering can lead to 2 CMEs being assigned, like it did here 😅. going to unassign myself since @joelbettner was the one picked for the External label

@joelbettner @kevinksullivan @rushatgabhane @kbecciv this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

📣 @spantheslayer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~017416d65c91a9dfa3

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@rushatgabhane thank you!! I can now access new room function.

I have checked the mentioned Version Number: <IP_ADDRESS> & the latest build. Could not reproduce the issue, seems it is working as expected. Trying with version number: <IP_ADDRESS> as you mentioned above. Will keep posted :)

@joelbettner, @kevinksullivan, @rushatgabhane, @kbecciv Huh... This is 4 days overdue. Who can take care of this?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Even after removing a user from a workspace, user can still send messages to any rooms related to the workspace user was a member earlier.
What is the root cause of that problem?
In src/libs/actions/Policy.js , line no. 212, pendingActions method is deleting the user but it is not updating.

What changes do you think we should make in order to solve the problem?
If we change pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE to
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE , It is updating the user side as well and user can't send the message anymore. Although the room is visible to the user side but upon sending a message user gets below error

Working flow

What alternative solutions did you explore? (Optional)
I have tried to update the satet reportID but that did not work. Tried to replicate the flow of how the announce room get detached everytime a user is removed from a workspace but that did not really work as I could really find the root of this flow.

Hey @joelbettner  thanks for pointing out exactly what needed to be done. Can I do the changes and make or update the proposal?

@joelbettner @kevinksullivan @rushatgabhane @kbecciv this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@joelbettner exactly my thought! I agree with all 3 changes.
There is one more case that we need to handle - when the workspace itself is deleted, we have the same bug and we should do all those 3 changes for this case as well.
Maybe you can start working on the backend changes while we land on a proposal here.

Make front end changes that hide the workspace from the removed user's UI

One question -
What exactly do we mean by removing workspace from UI?

How to handle LHN
i. We could remove it completely from LHN - bad idea because you can't read previous conv.
ii. We could push the room to the bottom of chat list in LHN - this is also kinda weird because you suddenly cannot find your room. Is this acceptable? @kevinksullivan @joelbettner
iii. We could do nothing in LHN, but add a message to the chat from backend - "User X has been removed form this room".
iv. ....?

How to handle room in search
i. I think we should keep the room here. Do nothing

Are there other places where you can see the room from? Maybe accessing the link directly

@spantheslayer yes please! You're welcome to drop in any thoughts, ideas, questions or an updated proposal.

@joelbettner, @kevinksullivan, @rushatgabhane, @kbecciv Eep! 4 days overdue now. Issues have feelings too...

Hey @rushatgabhane ! What's the latest on this one?

@joelbettner @kevinksullivan @rushatgabhane @kbecciv this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

on it

@kevinksullivan waiting on proposals and backend changes

@joelbettner, @kevinksullivan, @rushatgabhane, @kbecciv Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@joelbettner, @kevinksullivan, @rushatgabhane, @kbecciv Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@joelbettner, @kevinksullivan, @rushatgabhane, @kbecciv Whoops! This issue is 2 days overdue. Let's get this updated quick!

What exactly do we mean by removing workspace from UI?
How to handle LHN
We could remove it completely from LHN - bad idea because you can't read previous conv.
We could push the room to the bottom of chat list in LHN - this is also kinda weird because you suddenly cannot find your room. Is this acceptable? @kevinksullivan @joelbettner
We could do nothing in LHN, but add a message to the chat from backend - "User X has been removed form this room".
....?
How to handle room in search
I think we should keep the room here. Do nothing
Are there other places where you can see the room from? Maybe accessing the link directly

@rushatgabhane
In LHN I personally think we should remove the workspace entirely if the user is removed from it. If they need to read pervious convos they can try to search it or get re-added to the workspace.
I think it should still show up in the search. So, I agree with your "do nothing" assessment.
@kevinksullivan your thoughts on this^?

Hm I think I agree with @rushatgabhane for now, that the chat should show and be searchable. If we want to discuss making changes beyond that they should be brought to the wider team.

@joelbettner, @kevinksullivan, @rushatgabhane, @kbecciv Eep! 4 days overdue now. Issues have feelings too...

What's the latest on this one @joelbettner ?

@kevinksullivan I do not have the bandwidth to actually make these backend changes. I'm not sure what the protocol is in this situation...

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Re-adding the engineering label to pick up a new internal engineer.

I'm going to re-assign as well. I am focused on threads today and am about to go OOO for a week.

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

We didn't get an assignment, so I triggered again.

PS @joelbettner and @stitesExpensify for future reference, if you get assigned a GH like this as internal and can't take it, can you please post in slack to find a volunteer next time? That ensures that this will land into the hands of someone who can certainly push it forward.

Hey! I just got assigned this and my plate is really full atm with Manual Requests. I posted here to look for another volunteer to take this on, but maybe we could also re-add the engineering label?

Good question! Given that you don't have room on your plate either (and nor do the prior 2 assigned engineers), I think we need to stop using the random assignment of the engineering label because it's causing a delay. My recommendation is to assign the original engineer and that person should be responsible for completing the GH or finding a replacement.
Basically, we should not be unassigning GHs and re-assigning the label. Once it's assigned to to an engineer, it's their duty to ensure it's completed by them or someone else.

Taking over as I am assigned to a duplicate internally https://github.com/Expensify/Expensify/issues/280702
This issue also exists when demoting someone from admin to employee, they can still chat in #admins. I intend to fix both in this issue.

I reproduced, I started looking into the fix but had some questions about expected behavior: https://expensify.slack.com/archives/C04QEB4MJEQ/p1683832301167299

I sent a PR to send pusher updates, but I still need to:

Understand and investigate what happens with public and private rooms
Followup with another PR that ensure the member gets the chat removed from the LHN if they are offline when it happens, which is related to other bugs I'm assigned to

PRs are in final review.

WIP POC PR sent for the offline case.

I posted a Problem/Solution for feedback here: https://expensify.slack.com/archives/C01GTK53T8Q/p1684863673526879

I have been working on other room access bugs, I'll get to this at some point.

I'm reassigning Kevin, because the latest process is to always have a BZ assigned to a Bug regardless of Internal or External.

Ok, should we take this off Daily @flodnv ? Is that the right priority level for this?

It can be weekly, yeah

Can it though? https://expensify.slack.com/archives/C03U7DCU4/p1685965481640849

All bugs should be daily unless they are on hold.

Hmmm strange, I was convinced this bug still existed, but after trying several times I am unsuccessful 😕
@kevinksullivan @kbecciv is either of you able to reproduce?

No, I cannot reproduce it. The room was immediately hidden after user X was removed.

Dissussing here
https://expensify.slack.com/archives/C049HHMV9SM/p1686066293110289

Confirmed the bug is no longer reproducible!


Transform of dragged elements causes overlap of adjacent content

Problem
When a sortable element is dragged, an attribute of transform: translateZ(0) is added (looks like to fix an old rendering issue in Chrome - #1276); however, when the element is dropped this attribute is not removed, resulting in any absolutely position children of the draggable element (such as a tooltip) that extend past their parent's bounds to be overlapped by any following dragged/draggable elements.
To recreate
https://jsfiddle.net/4kcbzLse/

Add 2-3 list items using button
Drag a list item to the top
Hover over tooltip on the right of dragged list item
Observe how border of following item overlaps

Fix is very easy - just need to add a line:
css(dragEl, 'transform', '')

To line 1353 of ./src/Sortable.js (within the _onDrop: function() { ... } call). This will remove the attribute again once an element has been dropped.
Tested locally and fixes the issue for me, though to be clear - I have not experienced the issue #1276 myself, so not sure if this will cause conflicts with that. Might be worth further testing

Should add: happy to do a PR, though given further testing is required might be best if someone who is familiar with original issue has a look?

Merged PR in e97937010a112b4550b613e47f9e0019624d827d


Return stable edge IDs in public transit routing JSON responses

Purpose: Return stable edge IDs in GH transit responses
Usage: Assuming the proper OSM/GTFS files for NYC specified in config-nyc-pt.yml are in their proper places, run java -Xmx8g -jar web/target/graphhopper-web-1.0-SNAPSHOT.jar import config-nyc-pt.yml to generate a GH graph for use in transit requests that has stable edge IDs encoded for each edge (thanks to the recently merged change that adds stable IDs when using the import command).
Once the graph has been built, start the server with java -Xmx8g -jar web/target/graphhopper-web-1.0-SNAPSHOT.jar server config-nyc-pt.yml. For the current GTFS file used in the config, I know that Jan 21st, 2019 is a "valid date" for those PT lines, so set the date in GH to that date, choose start/end points, then use your browser's web dev features (eg, Chrome's "inspect" feature) to view the json response when you click to route the request. You'll see that for each leg of each trip, as well as for each trip as a whole, a list of stable edge IDs should be returned
Changes made in this PR:

Added back the reader-gtfs module, for the sole purpose of "overriding" a small number of classes from that module to add the needed functionality. In particular, CustomGraphHopperGtfs, CustomPtRouteResource, and CustomTripFromLabel were added here; javadoc comments in each describe what was changed. All other classes from reader-gtfs come from the 1.0-pre42.3 dependency, as was the case prior to this PR
Changed necessary dropwizard/jersey/etc web server code to point to custom classes (see changes to GraphHopperBundle)
Added replica-common module, and moved all stable edge ID-specific classes to this module, because now both web-bundle and reader-gtfs need to access these classes, and it makes things much cleaner.
Changed dependency chain from web-bundle -> graphhopper-matrix 1.0-pre42.3 (which contains deps to all core GH modules), to web-bundle -> reader-gtfs -> replica-common -> graphhopper-matrix 1.0-pre42.3. This insures that the necessary modules we added here (reader-gtfs and replica-common) don't cause unnecessary complexity WRT transitive dependencies. Now, each pomfile we have has as few deps as possible, and the dep chain is very explicit and easy to follow

Want to show me what sections are new code (i.e. not copied over from gh).

Added a description to the PR outlining some of this, and added javadocs/inline comments to the classes I modified specifying what was copied/what was modified for the large classes I added/messed with in this PR.

Also, where is the route id constructed?

Good question, not sure! I'll poke around the codebase to see where that happens, it wasn't something I touched when making these changes

After learning that this approach doesn't make sense in this discussion, I'm closing this in favor of this new approach, which essentially runs a more-efficient GTFS link mapper during GH's graph build process, and stores/returns the resulting mapped stabled edge IDs at query time.


Second edition

We were waiting for the second edition to be at least in press before making it master. The code did evolve from the first edition, but there are enough differences that it could be confusing.
Why do you prefer to have this merged now?
This should happen pretty soon.


Update thunder to <IP_ADDRESS>0

Checklist

[x] The commit message includes the cask’s name and version.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

I’ve deleted them this time, but in the future please delete the parts of the checklist that don’t matter to your submission, as the instructions ask.

I know.


Using promauto to initialize the metric and testutil in tests

Hi!
First of all I really like the idea for the project you are building here, and thank you for doing that!
While browsing through the source code I noticed that you could be some additional parts of prometheus repo to  make the integration more straight forward. I added the use of promauto since it is way too easy to forget the call to register.
I also added the testutil package for unit tests to be more explicit with checking the metric value.
Let me know what you think of the changes.

Hi @pBiczysko!
Thank you for these great additions! I didn’t know about these packages and it looks way better to manage things like that :)
I am on vacations now but will look on next week to tag a new version.