Add no_std support, by adding an std feature

I was really hopeful initially that this could be done without
having an std feature, but it turns out that bytes has a bunch
of special additional integration with std::io stuff, e.g.
std::io::Reader and std::io::IoSlice.
To make the library work as no_std we add an std feature which
is on by default. When it is off, we compile as no_std and make
parts of the API that require std::io conditional on the std
feature.

Hi -- I'm interested in getting bytes to work and build as a  no_std library relying on the newly-stabilized alloc crate to get Vec etc.
My motivation for doing this is that we want to use prost for serialization inside of an SGX enclave. Inside SGX you may have an allocator but you can't talk to the OS directly. bytes is a dependency of prost.
I think it's pretty unlikely that all of tokio could be ported inside of sgx, but if you are interested in no_std support in some of these low-hanging dependencies like bytes that are really fundamental, it will make them maximally portable and help the ecosystem.
LMK if you are interested in a patch like this! Thanks

@cbeck88 you should probably check out:
#269
#256
#255
#153
#135

@tarcieri My PR is very simple -- alloc has been standardized, and master is already on edition 2018. So the only thing we have to do is get things from the right namespace, and feature-gate the use of std-only trait bounds. This is a simple and mechanical change. This is not new functionality or code change at all, so it's hopefully not controversial.
#269 seems orthogonal and way beyond my goals
#256 and #255 are both stale since iovec was dropped. They also do some complex stuff with
#[cfg(feature = "std")]
use prelude::*;

that seems totally unnecessary.
#153 and #135 are both from 2 years ago. Is there anything from these threads in particular that you want to draw attention to? They look moot to me.

I pointed it out to note that there are other open PRs for this same general issue, for the ample historical discussion if nothing else. #269 describes solutions which can work for heapless no_std users (which this PR doesn’t help)
re: a crate-local prelude

that seems totally unnecessary

It’s necessary for compatibility with Rust versions prior to 1.35. It’s certainly much cleaner to support 1.35+, and I’m not sure what MSRV plans are for bytes 0.5.

@tarcieri I see -- I had mistakenly thought that edition: 2018 already put us past 1.35
Yeah if MSRV for bytes 0.5 is 1.35 or less then my patch needs more work

Perhaps @carllerche can tell us what he's thinking re: bytes 0.5 MSRV?

MSRV of Bytes 0.5 is 1.36.
https://github.com/tokio-rs/bytes/blob/234d814122d6445bdfb15f635290bfc4dd36c2eb/azure-pipelines.yml#L15-L23

@cbeck88 Could you please resolve current conflicts?
Master branch targets 2018 so it is perfectly fine as PR.
I'm still not sure what sort of no_std support we should have, but I believe support for global allocator would be good first step

@cbeck88 I made some changes to your PR.
I believe we don't need to link against alloc when std is already present

@DoumanAsh

I believe we don't need to link against alloc when std is already present

okay, but to my understanding there is no separate target to "link against". the symbols exported in std are simply re-exports of what is in alloc. so i think it's simpler to just always take the symbols from alloc and not do if std use std::..., because that just adds boilerplate that literally doesn't do anything.
that said, i'm happy with these changes if they make this PR acceptable to reviewers

Hm maybe you're right, I usually do not link to alloc because it is a bit unclear about it's status when building in std enviornment

@tarcieri @DoumanAsh let me know if you guys see anything else to improve here, i don't have plans to make further changes at this time

@tarcieri i realized that my idea about moving Buf and BufMut to a smaller crate will hit a problem after this recent commit:
https://github.com/tokio-rs/bytes/commit/b6cb346adfaae89bce44bfa337652e6d218d38c4#diff-c423debf79de47ec6dd3f075e0fc9cdcR901
because now trait Buf has a dependency back on the Bytes type, which would be circular if they were two crates
I've been trying to brainstorm a simple solution to this, because I don't want to sabotage long-term goals of core-only heapless version of this crate.
I think another approach might be, instead of buf::to_bytes() something like
impl Bytes {
   ...
   fn from_buf(arg: Buf) -> Bytes {
       let mut ret = BytesMut::with_capacity(arg.remaining());
       ret.put(arg);
       ret.freeze();
       ret
    }
}

or some such, because then Buf trait doesn't need to know about bytes
This has the downside, though, that you don't get the benefit described in commit message:

The advantage of Buf::into_bytes is that it can be optimized in cases where converting a T: Buf into a Bytes instance is efficient.

A different direction is, maybe bytes_core would contain simple versions of Buf and BufMut that don't have knowledge of Bytes type.
Then, bytes makes its own versions of Buf and BufMut which are defined as
pub trait Buf: bytes_core::Buf + Into<Bytes> {}

and this is what bytes exports as Buf and BufMut. The implementors of buf can implement Into<Bytes> how they want, and Bytes can do the efficient thing. There might be a way to make it so that the default implementation is there but the user can specialize it...
But in heapless context you wouldn't try to have Bytes or Into<Bytes> at all, you would just use the bytes_core versions of traits and probably do some kind of allocator-aware thing as described in earlier PR's
IDK I don't have personal need of heapless bytes in my own projects right now but I'm interested to keep brainstorming, and interested what others think: @DoumanAsh ^
My feeling is that bytes crate Buf and BufMut objects are much nicer than the std::io stuff. I worked in embedded c++ development at tesla in their autopilot project for a year, and I ended up writing some very similar stuff to Buf and BufMut, but in C++, to help them do zero-copy logging and serialization in the critical path throughout their codebase. This part of bytes documentation speaks volumes to me:

At first glance, it may seem that Buf and BufMut overlap in functionality with std::io::Read and std::io::Write. However, they serve different purposes. A buffer is the value that is provided as an argument to Read::read and Write::write. Read and Write may then perform a syscall, which has the potential of failing. Operations on Buf and BufMut are infallible.

If I were ever to write a serialization lib in rust I would probably try to use bytes rather than the std::io stuff, just as prost did. And if I wanted it to not make dynamic memory allocations (which can be forbidden in safety-critical programming contexts), and use pre-sized arenas etc., then I guess I would probably want a core-only version of bytes::Buf and BufMut. So anyways I'm really sympathetic to this as a development goal. There should be a way to make it possible, I'm just not sure what the best way is.

@cbeck88 right now the main solution we have for this particular problem in an embedded context is to used fixed-sized fields for everything in the protos, so e.g. fixed32 for all integers, and fixed-sized string/bytes, then more or less handrolling the parser/serializer to slice the data up or write it out to a fixed-sized buffer with constant protobuf framing. It'd sure be nice to find some way to leverage heapless in conjunction with prost though, so we could have prost autogenerate the parser/serializer, even for embedded.

@cbeck88 I'm not sure in particular what will be benefit of moving traits themself, but this particular memthod could be maid through trait extension rather than moved. i.e. BufExt should be in the same crate as Bytes

@DoumanAsh it's only to try to separate out the ideas and reduce the need for features to configure the package
it might be simpler to just say, there will be an std feature, and an alloc feature, and when neither are on we try to provide Buf and BufMut without Bytes type or related api
if we think that sounds better, it might be a good idea to add an alloc feature, even if it doesn't do anything right now, so that people can select it and it won't be a breaking change later if we make the core-only config work

@cbeck88 I believe right now it should be quite simple to make the crate no_std compatible.
I don't really think we'll need a need for alloc feature because even if we link with it, it is not necessary to use it as long as you're not touch allocations.
I don't really see much harm in splitting but I'm myself unsure of whether we should fragment such small crate, I'd suggest to hop onto tokio gitter and discuss it


Add support for Images to Markdown field plugin

In order to support images in the wyswiyg, a specialized Node View will have to be added. We have an ImageNodeView in the forestryio source code.
There may need to be a specialized ImageNodeView for handling Gatsby's relative path transformations.

We already have a NodeView for images, I am not sure if this task is still valid.

The base of this issue is technically complete. Further work will have to be done later specifically around:

Rendering local images via the wysiwyg
Uploading images via the wysiwyg

We can look to the Image Field for inspiration and consistency on how to address these issues.
Rendering Images
Here's a bit more background on the first problem.
In Gatsby sites the image paths in markdown files get transformed at build time. A markdown file might have this in the body:
![](../assets/cute-cat.jpg)

but it will actually be turned into this at build time:
<img src="/public/assets/cute-cat.jpg" />

That means the URL in the markdown source won't actually work for previewing.
A solution like that found in the "image" field would probably work and be flexibile enough to cover whichever use case. For that field, there is a previewSrc function that accepts the frontmatter value and outputs the url to used for previewing. It is the field user's responsibility to tell it how to work. (Aside: this adherence to the dependency inversion principle is pretty core to Tina's philosophy.)
The "markdown" field config might look something like this:
useForm({
  fields: [
    {
      name: "markdownBody",
      component: "markdown",
      imagePreviews(url) {
        return url.replace('../', '/public/')
      }
    }
  ],
  // .....
})

Hey @spbyrne , @DirtyF : we also need to work on showing loading state in editor when image is uploaded.


Improve readme

@Shopify/cloudplatform @kirs @xldenis
This PR improves the repo's README. Until now, its secondary features were far-better documented than the main ones! I'm giving a presentation on this gem at a meetup early next week, so I would like for these improvements to be in before we (hopefully) get more people interested in reading about it.
Helps with https://github.com/Shopify/kubernetes-deploy/issues/105

Updated! Please take another look, particularly at the new intro para.

@KnVerey I really like this. I think some future work could be:

Description of a few workflows like:
Getting started - using stuff from an 'examples' directory
Walk through the steps of a deploy
Screen record your terminal running a deploy locally, and turn it into a gif - put this right near the top of the readme to add a bit of "wow" factor and get people interested. If a picture is worth a thousand words, a gif is worth a million?

None of this needs to be incorporated into this PR, just some ideas :)

I don't think there's a way to PR this change, but wdyt about updating the repo's description? Currently it is:

Collection of scripts to deploy apps to Kubernetes

I'm thinking of pulling one of these lines from this PR:

A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result

A command-line tool providing clear, actionable pass/fail results for Kubernetes deploys

A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result

My vote^

cc @alindeman, who I've spoken to about this project before, and can provide some truly fresh 👀 from outside Shopify on the documentation

I'm going to merge this now. I'll make a follow-up that adds a gif, improves --help and removes the more obscure option descriptions from the readme. I can address any further feedback in that one.


Failed to build qemu-tci on emscripten.

Description
I tried to use the qemu-tci on emscripten on the commit: 788e909f3e702bbd7209fa86037cbd8cfb444e36, and followed the commands of the README.md.
However, I got an error exec /bin/sh: no such file or directory as follows when I executed ./out/c2w --assets=. --to-js --build-arg OPTIMIZATION_MODE=native --target-arch=aarch64 alpine:3.19 /tmp/out-js4/htdocs/, and it seems that I failed to execute /bin/sh in the ubuntu:22.04 base image.
Could you give me some advice?🙏
Error details
...
#19 [rootfs-aarch64-dev 2/9] RUN apt-get update -y && apt-get install -y mkisofs
#19 0.210 exec /bin/sh: no such file or directory
#19 ERROR: process "/bin/sh -c apt-get update -y && apt-get install -y mkisofs" did not complete successfully: exit code: 1

#20 [gcc-aarch64-linux-gnu-base 2/2] RUN apt-get update && apt-get install -y gcc-aarch64-linux-gnu linux-libc-dev-arm64-cross git make
#20 0.221 exec /bin/sh: no such file or directory
#20 ERROR: process "/bin/sh -c apt-get update && apt-get install -y gcc-aarch64-linux-gnu linux-libc-dev-arm64-cross git make" did not complete successfully: exit code: 1

#13 [golang-base 1/1] FROM docker.io/library/golang:1.21-bullseye@sha256:6815d296f20c3cb3afa67bf5dc862a831b6080f5dd8b5b423bb5f862539299de
#13 sha256:3d53ef4019fc129ba03f90790f8f7f28fd279b9357cf3a71423665323b8807d3 55.10MB / 55.10MB 6.7s done
#13 CANCELED

#17 [glib-emscripten-base 1/6] FROM docker.io/emscripten/emsdk:3.1.40@sha256:c1e807a6e03ac5bd5b37bae2ace3c46c08579e2ddeb951037a3b8dac7067f2cc
#17 sha256:8b795d8f70cabbff9c390138dc5ec98b1d2cf5c8af157991ed028b2fce6292ba 247.49MB / 397.30MB 6.7s
#17 sha256:a128c619347831c893bb6823ab47c91deb0591459722f505047f74247949fc41 203.42MB / 225.32MB 6.7s
------
 > [gcc-aarch64-linux-gnu-base 2/2] RUN apt-get update && apt-get install -y gcc-aarch64-linux-gnu linux-libc-dev-arm64-cross git make:
0.221 exec /bin/sh: no such file or directory
------
------
 > [rootfs-aarch64-dev 2/9] RUN apt-get update -y && apt-get install -y mkisofs:
0.210 exec /bin/sh: no such file or directory
------
Dockerfile:298
--------------------
 296 |
 297 |     FROM ubuntu:22.04 AS gcc-aarch64-linux-gnu-base
 298 | >>> RUN apt-get update && apt-get install -y gcc-aarch64-linux-gnu linux-libc-dev-arm64-cross git make
 299 |
 300 |     FROM gcc-aarch64-linux-gnu-base AS linux-aarch64-dev-common
--------------------
ERROR: failed to solve: process "/bin/sh -c apt-get update && apt-get install -y gcc-aarch64-linux-gnu linux-libc-dev-arm64-cross git make" did not complete successfully: exit code: 1
exit status 1

Environment
$ lsb_release -a
Linux *** 6.5.0-35-generic #35~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue May  7 11:19:33 UTC 2 aarch64 aarch64 aarch64 GNU/Linux

$ go version
go version go1.20 linux/arm64

$ docker --version
Docker version 26.1.3, build b72abbb

$ docker buildx version
github.com/docker/buildx v0.14.0 171fcbe

@yomaytk  Thanks for reporting the issue. Possible solutions:

Solution A: Enable buildx's QEMU-based multi-platform build because the current our Dockerfile relies on x86_64-based base images: https://docs.docker.com/build/building/multi-platform/#qemu (maybe slow conversion)
Solution B: Run c2w on x86 machine.
Solution C: Patch Dockerfile to use aarch64-based base images.

@ktock Thank you for giving the some solutions.
It worked by the solution B. Thanks. However, I executed the conversion (./out/c2w --assets=. --to-js --build-arg OPTIMIZATION_MODE=native --target-arch=aarch64 alpine:3.19 /tmp/out-js4/htdocs/) with root user because I failed to mknod in the rootfs-aarch64-dev image. Can I execute without sudo?

It worked by the solution B.

:+1:

I failed to mknod in the rootfs-aarch64-dev image. Can I execute without sudo?

Are you running BuildKit as rootless mode (i.e. inside user namespace)? I don't think mknod is possible inside user namespace.

@ktock
Thanks for the advice, and I'm sorry for the late reply.

Are you running BuildKit in rootless mode (i.e. inside the user namespace)? I don't think mknod is possible inside user namespace.

As you said, I used the buildkit with rootless mode, and it worked without rootless mode. Thanks!

I will close this issue because it is resolved.


Frontity packages better explanation

Can you update about your newly added packages so me as wordpress developer can read and understand the usecase and benifits of that package or article? so i can make sure my team following same method instead of any other long or old method ?

https://community.frontity.org/t/guide-for-frontity-packages/2092

Yeah one thing i couldnt find in docs that how to link an element with custom page( in which data is comming from acf feilds) when we are linking element and adding custom handlers on opening that link from frontend its opening in same window like default wordpress pages get open so quickly with loading window

https://community.frontity.org/t/guide-for-frontity-packages/2092/3?u=juanma

We close this one as this issue is already covered and solved in the "new" api.frontity.org


update: codeowners

rm xlyk
touch izzy64
🗣 Description
update codeowners file
💭 Motivation and context
xlyk will no longer be working with us.
Adding in izzy64 to help review and approve PRs in this repository
🧪 Testing
no testing needed
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

Please fill out the PR template ("Description" and "Motivation and context" sections) so we have some record of why these changes were made.

@jsf9k done


Fails to start. Illegal instruction

When running
docker run -v /pool/Bittorrent/incoming:/watch -v /pool/Bittorrent/complete:/downloads -v /pool/Bittorrent/incomplete:/incomplete -v /pool/Bittorrent/config:/config -p 45555:45555 -p 9091:9091 -e "USERNAME=username" -e "PASSWORD=password" timhaak/transmission

I get
/start.sh: line 21:     8 Illegal instruction     (core dumped) /usr/local/bin/transmission-daemon --foreground --config-dir /config --log-info --username ${USERNAME} --peerport 45555 --password ${PASSWORD} --auth --watch-dir /watch --download-dir /downloads --incomplete-dir /incomplete

Hi
Are you building it your self? Or are pulling the image.
If your puling the image have you pulled the latest version.

Sorry ignore me I see your using timhaak/transmission.
Have done a
docker pull timhaak/transmission:latest

recently?
I've just tested with the latest version on my side and it all works?
More trying to see how to replicate the problem.

Hi,
I tried pulling again and docker fetched something, however re-running the same start command again, resulted in the exact same error.
My guess is it's got nothing to do with the container configuration/setup but more to do with my host OS and the ports I'm trying to open. I will get back to you.

Cool thanks.
What os are you on? Also which version of docker are you running ?

Hi,
Sorry I didn't get back to you. I gave up on this container :(
My OS is Manjaro (Arch) running Linux 3.19.4 and docker 1.5.0.
If you have any ideas, I'm willing to try it again.

I've pushed  some update to the git repo.
Though will start properly testing tomorrow. Managed to break my internet so waiting for them to fix before start pulling images down to test.

@timhaak did those updates make it through to the docker hub? I pulled the latest version from there a few hours ago and I've also run into the Illegal instruction error.
Host machine is a 64 bit Ubuntu. Cpuinfo:
fpu_exception	: yes
cpuid level	: 4
wp		: yes
flags		: fpu de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pse36 clflush mmx fxsr sse sse2 syscall nx lm nopl pni cx16 hypervisor lahf_lm
bogomips	: 4533.49
clflush size	: 64
cache_alignment	: 64
address sizes	: 40 bits physical, 48 bits virtual
power management:

I had a successful install of this image about a week ago onto a Digital Ocean host.

I did.
I'm also running on ubuntu 14.04 though off a real server.
I'll try find some time this weekend to spin up a server on digital ocean and test.
Just confirming that your using 14.04

Please try now found a place that I can replicate and think it should be fixed.
Also some strangeness when I build locally it works but when its built on the index it doesn't with some of the old stuff.
But think it should be sorted everywhere.

Going to close as working on the system that was broken.
If you still have problems shout and will re-open

Yep, it works now. Thanks.
On Thu, 14 May 2015 at 17:45 Tim Haak<EMAIL_ADDRESS>wrote:

Going to close as working on the system that was broken.
If you still have problems shout and will re-open
—
Reply to this email directly or view it on GitHub
https://github.com/timhaak/docker-transmission/issues/1#issuecomment-102099232
.


error when scanning the qr code

info:     [session:client] Auto close configured to 60s
Error: Evaluation failed: TypeError: Cannot read property 'default' of undefined
at Object.window.WAPI.window.WAPI.restartService (C:\Users\miteb\OneDrive\Escritorio!!!\Stickerworld-master\node_modules\venom-bot\dist\lib\wapi\wapi.js:1:57963)
at puppeteer_evaluation_script:1:28
at ExecutionContext._evaluateInternal (C:\Users\miteb\OneDrive\Escritorio!!!\Stickerworld-master\node_modules\puppeteer\lib\cjs\puppeteer\common\ExecutionContext.js:217:19)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async ExecutionContext.evaluate (C:\Users\miteb\OneDrive\Escritorio!!!\Stickerworld-master\node_modules\puppeteer\lib\cjs\puppeteer\common\ExecutionContext.js:106:16)

Been facing the same isssue.
output of npm -v = 6.14.11
output of node -v = v14.16.0
My theory is that it's somehow calling for macos specific dependencies on windows. Then again, I could be completely wrong.

Sorry for the problems, whatsapp updated the whatsapp web backend and then one of the main libraries of the project was updated, everything was solved in the last commit: https://github.com/kaiserdj/Stickerworld/commit/fe8528a18578461c8f5bfa7a043e98a7056cd864
I close the issue as solved, any problem reopen it or create another


SFML Android will not build with NDK r16

It appears that the structure of the NDK changed in r16. The first issue encountered is that api-level.h has moved locations and changed structure (so just fixing the path doesn't work).
This problem can be worked around by using NDK r15 or older.
In the future, it would probably be desirable for builds to work with the latest version of the NDK. This link appears to have the solution: NDK r16 has its own cmake toolchain files which can be used instead (hopefully reducing the workload on SFML developers):
https://github.com/caffe2/caffe2/pull/1740/commits/39622be4ca8e243d530ff0a08c5cfd483dda96ba
Unfortunately I am still not able to get an android build working on Windows 10, so I can't test this process further.

SFML no longer provides its own toolchain file (for the very reason of reducing maintenance work) and is (right now) meant to be used with the one provided by CMake. Not really sure how up to date that one is at the moment. As for your other issues, no idea, it builds fine for me under Windows 10. We'd need more details there.

Ok, thanks.
My other issue is that somehow the build doesn't detect any of the libraries like Freetype or OpenAL:
I'm building using MinGW, NDK r15c and SDK 26, and a clone of SFML/master from a couple of days ago.
Attempting to build using the command:
cmake -G "MinGW Makefiles" -DANDROID_ABI=armeabi -DANDROID_STL=stlport_shared -DANDROID_NATIVE_API_LEVEL=26 -DCMAKE_TOOLCHAIN_FILE=../../cmake/toolchains/android.toolchain.cmake ../..
I get the error:

CMake Error at cmake/Macros.cmake:291 (message):
Missing item in FREETYPE_LIBRARY
Call Stack (most recent call first):
src/SFML/Graphics/CMakeLists.txt:137 (sfml_find_package)

I tested commenting out the bit where it searches for Freetype, but then it fails on OpenAL. All those libraries appear to have .a or .so files where I think it is looking: ../../extlibs/libs-android/armeabi, so I'm very confused why it isn't finding them.
This appears to be the problem encountered by this person:
https://en.sfml-dev.org/forums/index.php?topic=23699
and they worked around it using android studio.

You're using outdated instructions. You no longer have to use a toolchain file, just define CMAKE_SYSTEM_NAME and set it to Android, see PR #1350.

It works! I can build SFML. Thank you so much!
I was thrown off by the wiki page, which specified the build process I was using. I'll try and edit the wiki tomorrow.
For anyone else reading this, I built with:
cmake -G "MinGW Makefiles" -DANDROID_ABI=armeabi -DANDROID_STL=stlport_shared -DANDROID_NATIVE_API_LEVEL=26 -DCMAKE_SYSTEM_NAME=Android ../..
followed by
mingw32-make.exe && mingw32-make.exe install
Then I tried building the example project, I had to create a file local.properties containing the line:

sdk.dir=C:/Users/Me/AppData/Local/Android/Sdk/

I downloaded gradle 4.7 and, after a few errors, uninstalled all javas, then reinstalled only JDK 1.8u172.
It now runs gradle successfully, but gradle build fails with the error:

C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android>gradle build

Task :app:generateJsonModelDebug FAILED
process_begin: CreateProcess(NULL, "", ...) failed.
C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android\app\src\main\jni\Android.mk:20: *** Android NDK: Aborting.    .  Stop.

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:generateJsonModelDebug'.

Build command failed.
Error while executing process C:\Users\Me\AppData\Local\Android\Sdk\ndk-bundle\ndk-build.cmd with arguments {NDK_PROJECT_PATH=null APP_BUILD_SCRIPT=C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android\app\src\main\jni\Android.mk NDK_APPLICATION_MK=C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android\app\src\main\jni\Application.mk APP_ABI=armeabi-v7a NDK_ALL_ABIS=armeabi-v7a NDK_DEBUG=1 APP_PLATFORM=android-14 NDK_OUT=C:/Users/Me/source/repos/SFML/SFML-android/SFML/examples/android/app/build/intermediates/ndkBuild/debug/obj NDK_LIBS_OUT=C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android\app\build\intermediates\ndkBuild\debug\lib APP_SHORT_COMMANDS=false LOCAL_SHORT_COMMANDS=false -B -n}
Android NDK: C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android\app\src\main\jni\Android.mk: Cannot find module with tag 'third_party/sfml' in import path
Android NDK: Are you sure your NDK_MODULE_PATH variable is properly defined ?
Android NDK: The following directories were searched:
Android NDK:
process_begin: CreateProcess(NULL, "", ...) failed.
C:\Users\Me\source\repos\SFML\SFML-android\SFML\examples\android\app\src\main\jni\Android.mk:20: *** Android NDK: Aborting.    .  Stop.

Am I supposed to set NDK_PROJECT_PATH somewhere? Where should it point?
I feel I'm so close to having it working...

From memory, so might be wrong: Add ndk.dir to your local.properties and set it to your NDK directory.

Adding the NDK dir to local.properties has helped, although it seems to have revealed another problem in my build: It couldn't find the armeabi-v7a files.
As mentioned in https://github.com/SFML/SFML/pull/1350 the ABI flag has changed from ANDROID_ABI (which is silently ignored) to CMAKE_ANDROID_ARCH_ABI, and so it was still targeting armeabi:

-- Android: Targeting API '26' with architecture 'arm', ABI 'armeabi', and processor 'armv5te'

The working build command is now:
cmake -G "MinGW Makefiles" -DCMAKE_ANDROID_ARCH_ABI=armeabi-v7a -DANDROID_STL=stlport_shared -DANDROID_NATIVE_API_LEVEL=26 -DCMAKE_SYSTEM_NAME=Android ../..
which targets v7a:

-- Android: Targeting API '26' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'

Unfortunately gradle build (and gradle assembleDebug or gradle assembleRelease) still fail:

C:/Users/Me/source/repos/AndroidNDK/android-ndk-r15c/build//../build/core/build-binary.mk:688: Android NDK: Module sfml-example depends on undefined modules: sfml-main-d sfml-system-d sfml-window-d sfml-graphics-d sfml-audio-d sfml-network-d sfml-activity-d

It looks like it is trying to pull in the debug versions, and I'm not sure how to stop this?

It's actually configured that way right now, something we probably should change (the whole updated build is still work in progress, unfortunately massively low on time atm).
In examples/android/app/src/main/jni there are Application.mk and Android.mk, both referencing the debug versions with -d. Edit them and it should build.

Thanks for the lightning fast response!
I tried changing to stlport_static but I get the same corrupt/crash behaviour.

I have given up on the current build for the moment. It will be great when it works for me, but I can't find a way to get valid apks at the moment.
I did manage to get a valid build of the example working using old SFML and old tools and the Windows tutorial https://github.com/SFML/SFML/wiki/Tutorial%3A-Building-SFML-for-Android-on-Windows
with the changes I list in this thread (it is hard to get hold of the outdated tools necessary to build with the old instructions now):
https://en.sfml-dev.org/forums/index.php?topic=21547.msg162773#msg162773


Not detecting any structures on a specific server

Hi so ive been playing in this multi world server and on  one of it the seedcracker is not detecting the structures everything is turned on and also tried reload and i have 1.19.3 and latest version of seedcracker. Is it because any server plugins that stopping the seedcracker to detect? If so how do i counter it

I have the same issue on 1.19.3

I just found the solution! While you are near a structure like a shipwreck just type in "/seedcracker finder reload" and it will detect the structure.


update README.md

changed jb install github.com/coreos/prometheus-operator/contrib/kube-prometheus/jsonnet/kube-prometheus to jb install github.com/coreos/kube-prometheus/jsonnet/kube-prometheus

Thanks a lot!


feat: work during --watch

Not sure if this is possible with how vite's --watch is set up, but would be great if this plugin worked during watch mode.
This would be helpful for building a library and testing it out (i.e. with yarn link) in a separate app at the same time. Right now, in watch mode the types are removed from the output after reloading.

Thanks for your suggestion.
My original intention is for generating declaration in build mode, but not adequately considering the watch mode.
This idea broadens development of the plugin, I will take a try later.

Could you use any help on this? Would really help my development!


Remove code climate github action

In my latest PR https://github.com/beluga-php/docker-php/pull/66 I changed the action that was publishing the code coverage report because I thought the env variable CC_TEST_REPORTER_ID was somehow added to the CI builds of the master branch but I apparently is not.
Should we remove until someone is willing to configure code climate again?

I think that CodeClimate was never really setup for this project/repository and was just here as part of forking the original project. I'll take a look at it right away :)

CodeClimate is now setup: https://codeclimate.com/github/beluga-php/docker-php
I've re-run the action but there is still some issue when prefer-lowest combination is used. I don't have enough bandwidth right now to look at it, but I'll do later.

Here is an attempt to fix that https://github.com/beluga-php/docker-php/pull/68

Great fix @rodrigoaguilera ! Thank you once more!


Facing issue when using arun with VectorDBQAWithSourcesChain chain

Using VectorDBQAWithSourcesChain with arun, facing below issue
ValueError: run not supported when there is not exactly one output key. Got ['answer', 'sources'].

same

+1

same: not supported when there is not exactly one output key. Got ['answer', 'sources'].
Although I'm using the chain as a tool so maybe I didn't set something correctly

I'm facing the same technical issue. My code works fine with VectorDBQA, but not with the source one.

        vector_db = Milvus.from_texts(
            docs,
            AzureEmbedding
        )
        text_field = vector_db.text_field
        collection_name = vector_db.collection_name

        docs = vector_db.similarity_search(qa_req.query)

        chain = load_qa_with_sources_chain(AzureLLM, chain_type="stuff")
        result = chain({"input_documents": docs, "question": qa_req.query}, return_only_outputs=True)

2023-04-04 21:32:14,229 - ERROR - chat_completion error: 'source'
Traceback (most recent call last):
File "D:\go_path\src\kgpt\kgpt_engine\routers\chat_routers.py", line 53, in chat_qa
qa = chatService.qa(qa_req)
File "D:\go_path\src\kgpt\kgpt_engine\service\chat_service.py", line 84, in qa
result = chain({"input_documents": docs, "question": qa_req.query}, return_only_outputs=True)
File "D:\python\py3.9.6\lib\site-packages\langchain\chains\base.py", line 116, in call
raise e
File "D:\python\py3.9.6\lib\site-packages\langchain\chains\base.py", line 113, in call
outputs = self._call(inputs)
File "D:\python\py3.9.6\lib\site-packages\langchain\chains\combine_documents\base.py", line 56, in _call
output, extra_return_dict = self.combine_docs(docs, **other_keys)
File "D:\python\py3.9.6\lib\site-packages\langchain\chains\combine_documents\stuff.py", line 87, in combine_docs
inputs = self._get_inputs(docs, **kwargs)
File "D:\python\py3.9.6\lib\site-packages\langchain\chains\combine_documents\stuff.py", line 64, in _get_inputs
document_info = {
File "D:\python\py3.9.6\lib\site-packages\langchain\chains\combine_documents\stuff.py", line 65, in
k: base_info[k] for k in self.document_prompt.input_variables
KeyError: 'source'
same problem

+1

This is probably an error because RetrievalQAWithSourcesChain doesn't have a run method like some other chains. It would be great if it does because that would make it easier for people to use it as a tool for an agent.

Still having this issue!!!!!

File "/Users/alfredwahlforss/Documents/projects/merlin/ask-me-anything/.venv/lib/python3.10/site-packages/langchain/chains/combine_documents/stuff.py", line 64, in _get_inputs
document_info = {
File "/Users/alfredwahlforss/Documents/projects/merlin/ask-me-anything/.venv/lib/python3.10/site-packages/langchain/chains/combine_documents/stuff.py", line 65, in
k: base_info[k] for k in self.document_prompt.input_variables
KeyError: 'source'

One solution is to pass the RetrievalQAWithSourcesChain into the func parameter of Tool without calling .run()
Example
exampleBook = RetrievalQAWithSourcesChain.from_chain_type(llm=llm, chain_type="stuff", retriever=docsearch.as_retriever())

tools = [
    Tool(
        name = "ExampleBook",
        func=exampleBook,  **// exampleBook instead of exampleBook.run()**
        description="useful for when you need to answer questions about the exampleBook.
    ),
]

memory = ConversationBufferMemory(memory_key="chat_history", return_messages=True)

agent = initialize_agent(tools, llm, agent=AgentType.CHAT_CONVERSATIONAL_REACT_DESCRIPTION, verbose=True, memory=memory)

Was having this same issue, fixed it with @thorgexyz's solution.

VectorDBQAWithSourcesChain

could you provide more information about your program, especially regarding AzureLLM and the PromptTemplate. i think the KeyError 'source' is because your prompt template missing the key.

If you are getting KeyError: 'source' it's because the documents in your vectorstore don't have the source field in it's metadata. Add this to your payloads/metadata of your vectorstore data and it should resolve the issue. You can see in the documentation example that they are adding a source field
https://python.langchain.com/en/latest/modules/chains/index_examples/vector_db_qa_with_sources.html

Was having this issue running getting an error of 'run' not supported when there is not exactly one output key. Got ['output_text', 'source']. Using the following code:
qna = RetrievalQAWithSourcesChain.from_chain_type(
     llm=llm, chain_type="stuff", retriever=docsearch.as_retriever())
resp = qna({"question": message}, return_only_outputs=True)

I tried @thorgexyz solution but then was getting an error of: Saving not supported for this chain type. (which is weird because all the chain types but map_rerank implement the needed property 🤷 .
I was able to get around the limitation by querying for the documents manually rather than passing the retriver into the RetrievalQAWithSourcesChain.from_chain_type function:
docs = docsearch.similarity_search(message, k=5)

chain = load_qa_with_sources_chain(llm, chain_type="map_rerank", metadata_keys=['source'])

resp = chain({"input_documents": docs, "question": message}, return_only_outputs=True)

With the following code
index_name = 'test'
docsearch = Pinecone.from_existing_index(index_name, embeddings,text_key = 'content')
llm = OpenAI(model_name = "gpt-3.5-turbo",temperature=0)
param_similarity=dict(k=3,search_type="similarity")
retriever = docsearch.as_retriever(search_kwargs=param_similarity)

qa_chain = load_qa_with_sources_chain(
    llm = llm,
    chain_type = "stuff",
    prompt=QAPROMPT,
    return_intermediate_steps=True,
    verbose = True,
)
chain = RetrievalQAWithSourcesChain(
    combine_documents_chain=qa_chain,
    retriever=retriever)
    return_source_documents=True)

having the error

ValueError: Document prompt requires documents to have metadata variables: ['source']. Received document with missing metadata: ['source'].

Thus inserted ->  metadata_keys=['id'] in the load_qa_with_sources_chain because didn't want to change metada.
But now i'm having the following error ->

ValidationError: 1 validation error for StuffDocumentsChain metadata_keys
extra fields not permitted (type=value_error.extra)

Any idea @crwgregory ?
Many thanks in advance

@eloijoub Hard to say, I'm no expert.
What I had to do was save the data in my vector store with a source metadata key. I'd suggest you re-insert your documents with a source tag set to your id value. Langchain is expecting the source. I'm also passing a lot of other metadata, but I think the source might be required. It depends on what loader you are using how you can configure that.

@crwgregory
I don't fully understand your solution. Are you using an agent and are running
resp = chain({"input_documents": docs, "question": message}, return_only_outputs=True)
as the func of the agent?
Also this is confusing me, so you have to create the agent again for every user input? So I need to do:
docs = docsearch.similarity_search(user_input, k=5)
first and create the agent with doc after that?


Add missing return to file picker cancellation fix (#92)

Sorry - the previous PR (#92) was missing a return statement and so caused a crash when cancelling the file picker prompt.

Sorry - the previous PR (#92) was missing a return statement and so caused a crash when cancelling the file picker prompt.

Oh! I didn't test that. I'll surely merge this one now.
Thanks for updating.


Proxy not used when call https based service

Our proxy http://corporate.proxy:8080 should be used for all protocols.
Am I using the RestAssurred proxy incorrectly when making an HTTPS rest call or is this not currently supported?
NOTE: I'm testing against "https://jsonplaceholder.typicode.com" as its the only public https rest api I can find.
PreemptiveBasicAuthScheme auth = new PreemptiveBasicAuthScheme();
auth.setUserName("XXXX");
auth.setPassword("XXXX");

String url = "https://jsonplaceholder.typicode.com/posts";

Response r2 = RestAssured
		.given()
		.header("Proxy-Authorization", auth.generateAuthToken())
		.proxy("corporate.proxy", 8080)
		.get(url);

Thanks for the issue report. It should definitely work with https as well but I have not tested this (I have automated tests for http only). I was not aware of https://jsonplaceholder.typicode.com so perhaps that will help. But could it seems like https://jsonplaceholder.typicode.com/ has a problem with its certificate so that might be the problem. Could you try adding a "relaxedHttpsValidation()" to the given statement and try again?

Didn't make a difference :-(
		Response r2 = RestAssured
			.given()
			.relaxedHTTPSValidation()
			.header("Proxy-Authorization", auth.generateAuthToken())
			.proxy("host", 8080)
			.get("https://jsonplaceholder.typicode.com/posts");

Thanks for trying it out. It could be that relaxedHTTPSValidation is not applied for proxy requests for some reason. Need to look into this further.

Whoohoo!  Finally able to talk through the proxy via https.  I don't know if you will be able to adapt this for RestAssured but here is the solution:
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.InetSocketAddress;
import java.net.Proxy;
import java.net.URL;
import java.security.cert.X509Certificate;
import javax.net.ssl.HttpsURLConnection;
import javax.net.ssl.SSLContext;
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509TrustManager;
import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.SSLSession;

/**
 *
 * A complete Java class that shows how to open a URL, then read data (text) from that URL,
 * HttpURLConnection class (in combination with an InputStreamReader and BufferedReader).
 *
 * @author orginal code from alvin alexander, devdaily.com, all the https stuff came off the web
 *
 */
public class JavaHttpUrlConnectionReader
{
	public static String doAction() throws Exception
	{
		String url = "https://jsonplaceholder.typicode.com/posts";
		// if your url can contain weird characters you will want to
		// encode it here, something like this:
		// myUrl = URLEncoder.encode(myUrl, "UTF-8");

		String results = doHttpUrlConnectionAction(url);
		System.out.println(results);
		return results;

	}

	/**
	 * Returns the output from the given URL.
	 *
	 * I tried to hide some of the ugliness of the exception-handling
	 * in this method, and just return a high level Exception from here.
	 * Modify this behavior as desired.
	 *
	 * @param desiredUrl
	 * @return
	 * @throws Exception
	 */
	private static String doHttpUrlConnectionAction(String desiredUrl) throws Exception
	{
		URL url = null;
		BufferedReader reader = null;
		StringBuilder stringBuilder;

		try
		{
			// Create a trust manager that does not validate certificate chains
			TrustManager[] trustAllCerts = new TrustManager[] {new X509TrustManager() {
				public java.security.cert.X509Certificate[] getAcceptedIssuers() {
					return null;
				}
				public void checkClientTrusted(X509Certificate[] certs, String authType) {
				}
				public void checkServerTrusted(X509Certificate[] certs, String authType) {
				}
			}
			};

			// Install the all-trusting trust manager
			SSLContext sc = SSLContext.getInstance("SSL");
			sc.init(null, trustAllCerts, new java.security.SecureRandom());
			HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());

			// Create all-trusting host name verifier
			HostnameVerifier allHostsValid = new HostnameVerifier() {
				public boolean verify(String hostname, SSLSession session) {
					return true;
				}
			};

			// Install the all-trusting host verifier
			HttpsURLConnection.setDefaultHostnameVerifier(allHostsValid);

			// create the HttpURLConnection
			url = new URL(desiredUrl);

			// Set proxy
			Proxy proxy = new Proxy(Proxy.Type.HTTP, new InetSocketAddress("hostname", 8080));

			HttpURLConnection connection;

			if (desiredUrl.startsWith("https")) {
				connection = (HttpsURLConnection) url.openConnection(proxy);
			} else {
				connection = (HttpURLConnection) url.openConnection(proxy);
			}

			// Set proxy authentication
			String uname_pwd = "user" + ":" + "pasword";
			String authString = "Basic " + new sun.misc.BASE64Encoder().encode(uname_pwd.getBytes());
			connection.setRequestProperty("Proxy-Authorization", authString);

			//connection.setSSLSocketFactory(sc.getSocketFactory());
			//connection.setHostnameVerifier(allHostsValid);

			// just want to do an HTTP GET here
			connection.setRequestMethod("GET");

			// uncomment this if you want to write output to this url
			//connection.setDoOutput(true);

			// give it 15 seconds to respond
			connection.setReadTimeout(15*1000);
			connection.connect();

			// read the output from the server
			reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
			stringBuilder = new StringBuilder();

			String line = null;
			while ((line = reader.readLine()) != null)
			{
				stringBuilder.append(line + "\n");
			}
			return stringBuilder.toString();
		}
		catch (Exception e)
		{
			System.out.println(e.getClass().getName() + ": " + e.getMessage());
			throw e;
		}
		finally
		{
			// close the reader; this can throw an exception too, so
			// wrap it in another try/catch block.
			if (reader != null)
			{
				try
				{
					reader.close();
				}
				catch (IOException ioe)
				{
					ioe.printStackTrace();
				}
			}
		}
	}
}

Thanks for sharing

Hmm but doesn't it work if you go to an https site such as https://www.google.com? This makes me think that it's nothing wrong with the proxy but rather with the certificate.

And actually this works for me:
given().
        relaxedHTTPSValidation().
        proxy("<IP_ADDRESS>").
        param("firstName", "John").
        param("lastName", "Doe").
when().
        get("https://jsonplaceholder.typicode.com/posts").
then().
        log().all().
        header("Via", not(isEmptyOrNullString()));

The logging says:
HTTP/1.1 200 OK
Server: Cowboy
Connection: keep-alive
X-Powered-By: Express
Vary: Origin
Access-Control-Allow-Credentials: true
Cache-Control: no-cache
Pragma: no-cache
Expires: -1
X-Content-Type-Options: nosniff
Content-Type: application/json; charset=utf-8
Content-Length: 2
Etag: W/"2-11FxOYiYfpMxmANj4kGJzg"
Date: Tue, 27 Oct 2015 05:15:28 GMT
Via: 1.1 vegur

[

]

Are you really using the latest version of REST Assured?

I will have another go.  Does relaxedHTTPSValidation() automatically trust all hosts and certificates?  That was what finally got the HttpsURLConnection working.

Yes it should trust all hosts and certs.

Have you tried this? I want to make a new release of REST Assured today and if I don't here anything a possible fix for this issue will not be included in the next release.

Sorry, I haven't had a chance and won't get to it until Monday now.
Date: Fri, 30 Oct 2015 02:59:56 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [rest-assured] Proxy not used when call https based service (#596)
Have you tried this? I want to make a new release of REST Assured today and if I don't here anything a possible fix for this issue will not be included in the next release.
—
Reply to this email directly or view it on GitHub.

No problem, not actually sure anymore if I have time to make a new release today. But it'll happen soon :)

Finally got around to trying the 2.6.1-SNAPSHOT
Still getting "Results in 407 Proxy Authentication Required." when calling https, http works just fine. If it wasn't for the error message I'd be assuming it was an issue with host/certificate validation.
String result3 = RestAssured.
given().
relaxedHTTPSValidation().
proxy(ProxySpecification.host(ConfigUtils.getProxyHost()).withPort(ConfigUtils.getProxyPort()).withAuth(ConfigUtils.getProxyUser(), ConfigUtils.getProxyPassword())).
when().
get("https://jsonplaceholder.typicode.com/posts").asString();

@andrew-sumner I think that the reason might be the the proxy can't decrypt https. If it can't decrypt the http request it can't add headers. See http://stackoverflow.com/questions/20446088/can-proxy-insert-headers-to-a-https-request.

Closing due to inactivity


The native editor will now wrap all its content

instead of showing a horizontal scrollbar.
For #7272

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #7336 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7336      +/-   ##
==========================================
- Coverage   58.36%   57.91%   -0.45%
==========================================
  Files         493      493
  Lines       21667    21667
  Branches     3486     3481       -5
==========================================
- Hits        12645    12549      -96
- Misses       8242     8331      +89
- Partials      780      787       +7

Impacted Files
Coverage Δ

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

src/client/common/utils/platform.ts
64.7% <0%> (-23.53%)
:arrow_down:

src/client/common/utils/icons.ts
83.33% <0%> (-16.67%)
:arrow_down:

src/client/datascience/cellFactory.ts
75.86% <0%> (-13.8%)
:arrow_down:

src/client/common/logger.ts
68.55% <0%> (-6.92%)
:arrow_down:

src/client/providers/providerUtilities.ts
83.33% <0%> (-5.56%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7362b25...16e871d. Read the comment docs.


APIM duplicating API even though it already exists

API-Manager CLI Version
1.3.12
API-Manager and Service-Pack Version
7.7
Question
APIM is always creating new configs even though nothing has changed and API already exists and it is published.
I enabled DEBUG and I can see this:
4015   DEBUG APIManagerAPIAdapter| No existing API found based on filter: [apiPath=/bank/party/v3 vHost=apiz3-syst.exttest.lab filter=APIFilter [id=null, name=null, vhost=apiz3-syst.exttest.lab, apiPath=/bank/party/v3, queryStringVersion=null, state=null, deprecated=false, retired=false, loadBackendAPI=false]]
I can see the API in there for the same vhost and it just keeps creating new ones (even without ANY CHANGES):

What am I missing?

Based on the information you shared @pgcastro, that looks like a bug to me. Can you maybe enable Traffic-Monitoring for the API-Manager Port (default 8075) so that you can see the REST-API-Calls executed by the APIM-CLI.
I'm most interested into the following request:

Open that request and share the request details:

And check, if there is a response:

If yes, I would like to know:

how many APIs are returned
confirm the returned API(s) include the VHost as configured

I tested it locally and it works as expected.

Hi @cwiechmann, first of all thank you so much for the quick response. I tried to make it work for a long while but had no clue on what to do anymore.
Because I turned DEBUG on I can see the call being made:
https://apiz3-manager-syst.ext.sun:443/api/portal/v1.3/proxies?field=path&op=eq&value=%2Fbank%2Fparty%2Fv3&field=state&op=ne&value=published
When I call that I get no results (even though API is indeed there). If I remove the "not equals to published" and call this instead:
https://apiz3-manager-syst.ext.sun:443/api/portal/v1.3/proxies?field=path&op=eq&value=%2Fbank%2Fparty%2Fv3
I get the response:
[
{
"id": "980e0dba-b297-4505-9bc8-04d5505f1b03",
"organizationId": "ba897bc4-4ac6-4731-885d-b103f71f5aa4",
"apiId": "280ecb37-dda3-4b33-82ef-9d1331c8fd1d",
"name": "Bank Party API v3",
"version": "3.0.0",
"apiRoutingKey": null,
"vhost": "apiz3-syst.ext.sun",
"path": "/bank/party/v3",
"descriptionType": "original",
"descriptionManual": null,
"descriptionMarkdown": null,
"descriptionUrl": null,
"summary": null,
"retired": false,
"expired": false,
"image": null,
"retirementDate": 0,
"deprecated": false,
"state": "published",
"createdOn":<PHONE_NUMBER>866,
"createdBy": "b3c31b4a-52d4-4200-ae24-b1f59e0bfccb",
...........
Does that help?

That helps a lot. For any reason the API-Manager does not return the API even it's published and of course the GET /proxies endpoint supports filtering on the state.

http://apidocs.axway.com/swagger-ui/index.html?productname=apimanager&productversion=7.7.0&filename=api-manager-V_1_3-swagger.json#!/API_Proxy_Registration/get_proxies
I quickly checked in the Source-Code, why the actual API is looked up incl. the state, as my request was without the state. I assume you are using an Org-Admin account.
Can you confirm?

Hi @cwiechmann ,
I'm not really sure to tell you the truth. Axway manager is handled by another team and they are the FULL ADMINs.
I know for sure my service account (the one I use to run APIM) is also not a FULL ADMIN but the APIs were created using the same service account before the second run so it should be considered an "owner"?
Is there any workaround that I can use?

You see what the code is doing. It skips/ignores all "Published" APIs, if the user has no Admin-Role. The reason for that is, that Org-Admins cannot change that API anyway.
Have you enabled the flag, which has been introduced in one of the more recent releases?:
<ConfigurationFragment>
    <VMArg name="-Dapi.manager.orgadmin.selfservice.enabled=true"/>
</ConfigurationFragment>

This is a feature flag for the API-Manager to enable Org-Admins more privileges. This would explain, why your APIs are published, even an Org-Admin is used. But the APIM-CLI is not fully supporting this flag right now.
You read more about this flag here:
https://docs.axway.com/bundle/axway-open-docs/page/docs/apim_relnotes/20200930_apimgr_relnotes/index.html
https://docs.axway.com/bundle/axway-open-docs/page/docs/apim_relnotes/20201130_apimgr_relnotes/index.html
It would be really good to know, if this flag is configured.

I'll try to find out with the Axway team. So for the time being, there nothing I can do for this to work?
I'll have to first unpublish my apis and then run import? Or is there any other workaround you can think of?

Hi @pgcastro, I'm afraid at the moment unfortunately not. It's a complicated topic. I created another issue to add support for the mentioned feature flag: #217.
In the meantime it would be great, if you can check if the flag is set or not. If not, I would be really surprised about the actual behavior.

Unfortunately the workaround was not enough. Even unpublishing the existing api before running APIM, the config gets duplicated saying it didn't find an existing one. :(
FYI the flag is indeed configured.


[Question]: Add example code

What is your question?
Please add some example code in plugin documentation.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @muneebshahzad95
There are examples in the topics section:

Dialogs
Decorations

Also there are App examples


Tushar Shah needs to be added to the teams page

Tushar Shah needs to be added to teams page
Tushar Shah's Title:          Senior Customer Engineer
Tushar Shah's Linkedin:    https://www.linkedin.com/in/tusharrshah
Tushar Shah's git:              https://github.com/tusharshahrs

@tusharshahrs Did you want to submit a PR for this yourself?

Updated picture provided as per Christian

@tusharshahrs You can add yourself to the team page. See https://github.com/pulumi/docs/pull/3828 for a previous pull request that shows how.


Add a new meetup to community section

Adds Helsinki, Finland to community meetups page.

Can you resolve the conflicts? :) We can add Helsinki to the list ;)


[DO-NOT-MERGE] Investigate Appveyor failure of preview

What changes were proposed in this pull request?
Do not merge.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

Test build #112750 has started for PR 26277 at commit 5c87fe3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17695/
Test PASSed.

Test build #112751 has started for PR 26277 at commit edf6683.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17696/
Test PASSed.

Test build #112751 has finished for PR 26277 at commit edf6683.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112751/
Test PASSed.

Test build #112750 has finished for PR 26277 at commit 5c87fe3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112750/
Test PASSed.


⚠ ESPN has degraded performance

In 408e5ed, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 1845 ms

Resolved: ESPN performance has improved in fbba2d1.


clientv3: only start lease stream after first keepalive call

Fixes #7274

lgtm defer to @xiang90

Failing on unrelated issue #7283. Jumping the turnstile and merging.

LGTM


"partitioner returned an invalid partition index" Error when using "NewManualPartitioner"

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version: 1.12.0
Kafka Version: <IP_ADDRESS>
Go Version: 1.8.1
Configuration
What configuration values are you using for Sarama and Kafka?
in the gist https://gist.github.com/dinesh-chander/7497d403e3e48503442c32a9b80509a3
Logs
Sarama logs
Producer2017/05/20 20:53:10 client.go:115: Initializing new client
Producer2017/05/20 20:53:10 config.go:329: ClientID is the default of 'sarama', you should consider setting it to something application-specific.
Producer2017/05/20 20:53:10 config.go:329: ClientID is the default of 'sarama', you should consider setting it to something application-specific.
Producer2017/05/20 20:53:10 client.go:631: client/metadata fetching metadata for all topics from broker <IP_ADDRESS>:9092
Producer2017/05/20 20:53:10 broker.go:146: Connected to broker at <IP_ADDRESS>:9092 (unregistered)
Producer2017/05/20 20:53:10 client.go:427: client/brokers registered new broker #0 at <IP_ADDRESS>:9092
Producer2017/05/20 20:53:10 client.go:159: Successfully initialized new client
Publishing Message in Partition: 5
Producer2017/05/20 20:53:11 client.go:629: client/metadata fetching metadata for [users.recording] from broker <IP_ADDRESS>:9092
Producer2017/05/20 20:53:11 client.go:640: client/metadata found some partitions to be leaderless
Producer2017/05/20 20:53:11 client.go:620: client/metadata retrying after 250ms... (3 attempts remaining)
Producer2017/05/20 20:53:11 client.go:629: client/metadata fetching metadata for [users.recording] from broker <IP_ADDRESS>:9092
kafka: Failed to produce message to topic users.recording: kafka: partitioner returned an invalid partition index
Publishing Message in Partition: 2
kafka: Failed to produce message to topic users.recording: kafka: partitioner returned an invalid partition index
Publishing Message in Partition: 1
kafka: Failed to produce message to topic users.recording: kafka: partitioner returned an invalid partition index
Publishing Message in Partition: 0
Producer2017/05/20 20:53:13 config.go:329: ClientID is the default of 'sarama', you should consider setting it to something application-specific.
Producer2017/05/20 20:53:13 async_producer.go:584: producer/broker/0 starting up
Producer2017/05/20 20:53:13 async_producer.go:596: producer/broker/0 state change to [open] on users.recording/0
Producer2017/05/20 20:53:13 broker.go:144: Connected to broker at <IP_ADDRESS>:9092 (registered as #0)
Publishing Message in Partition: 5
kafka: Failed to produce message to topic users.recording: kafka: partitioner returned an invalid partition index
Publishing Message in Partition: 4
kafka: Failed to produce message to topic users.recording: kafka: partitioner returned an invalid partition index
Message Published in Partition: 0
Publishing Message in Partition: 4
kafka: Failed to produce message to topic users.recording: kafka: partitioner returned an invalid partition index
Publishing Message in Partition: 0

Problem Description
I'm trying to publish messages in different partitions which are under the same topic. But I'm getting the error
kafka: partitioner returned an invalid partition index

Do I need to create partitions before publishing the messages?

Do I need to create partitions before publishing the messages?

Yes

I have two questions

Is there any method for creating new partitions?
Why was a partition with '0' partition id created?

Sarama currently doesn't support any methods to create topics or partitions. You have to use the tools that the Kafka broker ships with.
Kafka has an option to automatically create topics when you start using an unknown topic. That's probably enabled for you. You can configure kafka to enable or disable this, and with how many partitions new topics are created,.


env() returns first value in two laravel apps while doing curl from one to another on the same server

Laravel Version: 5.3.23
PHP Version: 5.6.23

Description:
I am working on micro-services based project in which I am using multiple Laravel/Lumen Apps which communicate to each other using GuzzleHttp. I am using XAMPP in Windows 8.
My issue is when I call an API on one of the app, in which another server side request is made to the second app is showing error that requested db table is not found. When I checked the DB used in the second app is the DB defined for the first app, not the DB defined for the second app.
I have verified that the issue is env method in second app is returning the configuration set for the first app.
Steps To Reproduce:
Laravel App 1
.env
DB_DATABASE=laravel1
web.php
Route::get('/', function () {
    $response = file_get_contents('http://localhost/labs/laravel2/public/');
    $result = [
        'local' => env('DB_DATABASE'),
        'remote' => $response
    ];
    return $result;
});

Laravel App 2
.env
DB_DATABASE=laravel2
web.php
Route::get('/', function () {
    return env('DB_DATABASE');
});

Output
http://localhost/labs/laravel1/public/
{"local":"laravel1","remote":"laravel1"}
http://localhost/labs/laravel2/public/
laravel2
This issue happens only in Windows and is working fine in Linux. Not sure what is causing this issue.

This is due to a php bug with the putenv which is used by the vlucas/phpdotenv. This happens in the thread safe version since the subrequest made from first app is still under the same process.
This php bug is marked as won't fix. But I think this will be a major issue in Lumen when different microservices are deployed on the same server.

When using laravel you can use the config cache feature to mitigate all issues like this. I imagine we'll at some point implement something similar for lumen.


Update README.md

Added how to troubleshoot the Port error when a todomvc launch is attempted.

It says in the directions how to get things running. I'd rather just make the directions clearer.


Best_ids as k_ids into ClustData

Seasonal storage integrated in alpha phase with passing on best_ids "manually" through the functions, needs to be improved. And it's super exiting! I wonder if you should penalize the loading and unloading of the battery rather than the installed capacity (because of the 6.000 cycle per battery life time and not 25 years with whatsoever)
It would be a much nicer workflow for the Opt part, if best_ids would be included in ClustData - What's your opinion on that one?

Done


Conditionals in fastfile

Is the fastfile written in ruby?
I'm not very used to ruby, so I have to ask, how do I add conditionals to my fastfile?
With a lane sending a gym built file to testflight using pilot, that lane ultimately asks for username when it hits the pilot command. Which is a lot later than when the lane starts. So I would like to have it check and/or ask for username already before the gym step. I assume I could collect username through a |values| parameter, but then I need to check that the username is really set.
This is what I have so far, but it doesn't work. It does not follow the if path, it always goes to else no matter what.
theusername = values[:username]

puts "Sending to testflight, username is '#{theusername}'"

if theusername == ''
	puts "Missing username!"
else
	# code here to build and send...
end

Again, forgive me my lack of knowledge of Ruby.

I got it, like this:
lane :sendtestflight do |values|
theusername = values[:username]

if theusername.nil?
	puts "Please specify username like this: fastlane ios sendtestflight<EMAIL_ADDRESS>else
  	puts "Sending to testflight, username is '#{theusername}'"


Feature request: nearest neighbor search

Hey Thomas, thanks for your work! Have you considered looking into nearest neighbor search algorithms in 3D? It'll be very valuable for a lot of projects.

Hi @jackguo709, I'm not super familiar with nearest neighbor problems, could you point me towards a paper or blog post describing the problem? Needless to say, it's not something on my radar at the moment. I am guessing you are referring to a spatial partitioning technique like what is described in 32.2 here, where objects are hashed into "spatial cells", then the cells are sorted?


autoSave does not work for select combo for layers

So the input ids are:
node-input-22763fab_3c8ea-features-txt and
node-input-22763fab_3c8ea-features-map
both need to get change listeners registered. It seems this is only happening for the txt one?

see: https://github.com/boundlessgeo/wps-gui/commit/ff2a8f286efa07a34c47a2e7c880a962e28aab74


fix: Correct the bad env name of users tenant

fix: #94

Brief Summary of The Change

Pull Request checklist
I confirm that the following checklist has been completed.

[x] Add/Change test cases for the changes.
[x] Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
[x] (Optional) Add your change to UPDATING.md when it is an incompatible change.

Codecov Report

Merging #97 (465302b) into main (7fb5a33) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   90.75%   90.75%
=======================================
  Files          63       63
  Lines        2314     2314
=======================================
  Hits         2100     2100
  Misses        214      214

Flag
Coverage Δ

unittests
90.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/pydolphinscheduler/configuration.py
97.01% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


make js fails

Trying to install from source according to https://posativ.org/isso/docs/install/
I got this error when i make js:

r.js -o isso/js/build.embed.js out=isso/js/embed.min.js
Error: Error: ERROR: module path does not exist: /home/floreal/work/isso/isso/js/components/almond/almond.js for module named: components/almond/almond. Path is relative to: /home/floreal/work/isso
at /usr/lib/node_modules/requirejs/bin/r.js:30214:35
Makefile:40: recipe for target 'isso/js/embed.min.js' failed
make: *** [isso/js/embed.min.js] Error 1

What information do you need to help me ?
What am I supposed to do ?

Have you run
cd isso/js; bower --allow-root install almond requirejs requirejs-text jade

?
Also the installation from source is currently slighty broken (that's what you get when using hipster technology). Anyways, currently you need r.js and bower in your PATH
npm install requirejs bower

Then you run the bower command I first wrote. Currently it looks like you also need to install jade via NPM.
Then you might get an error in require-js/text, you can fix that by moving isso/js/components/text to isso/js/components/requirejs-text.

Hi agaim,
thanks a lot. It did work fine
Cheers


Texts from a 2nd, 3rd file in the .xliff cannot be edited

Try to edit the target texts for one of the texts in en.xliff.zip that is empty, f.e. $(PRODUCT_NAME). It stays empty after pressing enter, I assume because it comes not from the first file of the xliff file:

I think that because xliff doesn't have  for that translation and looks like editor can't add it


Improving Update-DbaInstance

Type of Change

[x] Bug fix (non-breaking change, fixes #4730, fixes #4728. fixes #4727 )
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[x] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Adding new functionality and improving messaging and UX across the board
Approach

less warnings, more details
removing one internal function altogether - functionality was merged with another one
Commands to test

Screenshots

Learning

🎉 ! thank you!!!


Can't find variable: require, in Sketch 48

I've build the plugin package using newer version of sketch 50. But it's not working for some of the users having Sketch 48.
The error is as below:
Exception: ReferenceError: Can't find variable: require
on Line
module.exports = require("sketch");
Can anyone help me to resolve the issue?

yeah the new API and require is only available from Sketch 49, nothing we can do about that.
More than 90% of Sketch users are on the latest 2 versions (eg 51 and 50). And that percentage is even higher if you look at the latest 3 versions (so >= 49). Up to you to decide if you want to support users using an older version

Any alternative suggestions to make it work quickly? Or does it require to re-build plugin from scratch?


Maybe use serialize and check the payload

If a project switched from the original Laravel encrypter to this (without clearing the browser cache), there will be an error:
Undefined offset: 1
in https://github.com/scrothers/libsodium-laravel/blob/master/src/SodiumLibrary.php#L228
Maybe we should check the payload before the decryption starts:
https://github.com/bitbeans/lencryption/blob/master/src/Lencryption.php#L89

Actually, I like the idea of encapsulating in base64 like you are. I'm currently re-working the code to better maintain it right now as well.
I'm working on some interoperable libraries for Node.js and PHP currently, my PHP work up is here:
https://github.com/simpleapisecurity/php
My Laravel package based off that is here:
https://github.com/simpleapisecurity/laravel
I eventually plan on deprecating this in exchange for the other, it's a lot faster in phpunit (I didn't check why, I'll determine why afterward).
I'm also working on code documentation, and better commenting right now. You're more than welcome to see where I head :)
I'm definitely going to use your code sample though, I'll of course credit you in the commit.


x,y,z coordinates instead?

The api would make a little more sense to me if you were to define the plane as a polygon with [x, y, z] coordinates instead of {a: z1, b: z2, c: z3} properties? Could we have it both ways?

Actually, this is no longer kosher in the land of GeoJSON IETF draft

An OPTIONAL third
position element SHALL be the height in meters above or below the WGS
84 reference ellipsoid.

The shall means that if the 3rd is supplied then it must be altitude. Given that planepoint is not necessarily dealing with altitude, we shouldn't use the Z value imho.


Required version of numpy can't be installed on Python 3.9

The numpy dependency in requirements.txt has to be updated .
      compile options: '-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Inumpy/core/include -Ibuild/src.linux-x86_64-3.9/numpy/core/inc
lude/numpy -Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/sr
c/npysort -I/home/lampam/cpp/other/rust/rsp2/venv/include -I/usr/include/python3.9 -Ibuild/src.linux-x86_64-3.9/numpy/core/src/private -Ibuild/src.linux-x86_
64-3.9/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.9/numpy/core/src/private -Ibuild/src.linux-x86_64-3.9/numpy/core/src/npymath -Ibuild/src.linux-x86_6
4-3.9/numpy/core/src/private -Ibuild/src.linux-x86_64-3.9/numpy/core/src/npymath -c'
     clang: numpy/random/mtrand/mtrand.c
     numpy/random/mtrand/mtrand.c:43635:34: error: no member named 'tp_print' in 'struct _typeobject'
       __pyx_type_6mtrand_RandomState.tp_print = 0;
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

I think this will ultimately require updating to support a newer version of phonopy.

It's possible that all of the main blockers preventing the phonopy dependency from being updated were removed back in f650e17 or nearby commits. Looking into this

The original blockers were related to the phonopy diagonalizer, which is long gone, but there are new, smaller issues in that Phonopy made breaking changes to its CLI:

--sym is now --symmetry
disp.yaml is deprecated and no longer generated (superceded by phonopy_disp.yaml)

Shouldn't be too bad.


mapping element of widening result when lmul < 1

Hi
As v0.9 add new case of fractional LMUL, not quite sure what's the element map result for vwop.
If my design is SLEN = VLEN = 128bit and set LMUL = 1/2 & sew32, after executing a vwmac.vv v2, v4, v8,
as vd EEW = SEW*2 and EMUL = LMUL *2 = 1/2 * 2 = 1, vwmac will update v2 [127:64][63:0].
Is my result correct?

yes


[Modify Event] - Report 7000082 Settle Docs. in Posted PO - OnBeforePostedDocOnPostDataItem

We need  modify event in report 7000082 "Settle Docs. in Posted PO":
LOCAL [IntegrationEvent] OnBeforePostedDocOnPostDataItem(VAR PostedDoc : Record "Posted Cartera Doc.";VAR PostedPmtOrd : Record "Posted Payment Order";VAR BankAccPostBuffer : Record "BG/PO Post. Buffer"; var IsHandled: Boolean)
And modify the code
        trigger OnPostDataItem()
        var
            VendLedgEntry2: Record "Vendor Ledger Entry";
            PostedDoc2: Record "Posted Cartera Doc.";
            IsHandled: Boolean;
        begin
            if (DocCount = 0) or (GroupAmount = 0) then begin
                if DueOnly then
                    Error(Text1100003 + Text1100004);

                Error(Text1100003 + Text1100005);
            end;

            **IsHandled := false;**
            OnBeforePostedDocOnPostDataItem(PostedDoc, PostedPmtOrd, BankAccPostBuffer**,IsHandled**);
            if **not IsHandled and** BankAccPostBuffer.Find('-') then
                repeat
                    VendLedgEntry2.Get(BankAccPostBuffer."Entry No.");
                    PostedDoc2.Get(1, VendLedgEntry2."Entry No.");
                    PostedPmtOrd.Get(PostedDoc2."Bill Gr./Pmt. Order No.");
                    BankAcc.Get(PostedPmtOrd."Bank Account No.");
                    GenJnlLineNextNo := GenJnlLineNextNo + 10000;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Incorporating the CF data model into the conventions

See issue #159 for discussion of these changes.

There seem to be some technical problems at this point: appi.adoc is not included in cf-conventions.adoc, probably something like
:numbered!:
include::appi.adoc[]

should be added to the end of the list of appendices.
When I do that locally, the document doesn't compile to pdf anymore.
I'll see if I can submit a PR/fix for that.

Also, the png figures don't scale very well. Any chance of svg, pdf, or eps versions?

Thanks - I have updated cf-conventions.adoc to include appi.adoc. And thank you for investigating why it doesn't build.
I should .eps have versions of the figures - I'll have a look

That would be great. It looks like standard uml class diagrams. Maybe you even have the source figures still?

Hi @zklaus I have added PDF versions of the images in the images. I haven't changed the "png" references in the text because when I did the GitHub rendering at https://github.com/davidhassell/cf-conventions/blob/CF_data_model/appi.adoc ignored them. Can you help?
I would like to merge this PR soon so that the text can be further worked on. It would be really nice to get the figures right first, but if there are difficulties with this, going ahead and merging with the PNG images and working on this aspect later would be fine by me.
Many thanks,
David

Implements https://github.com/cf-convention/cf-conventions/issues/159


Add support to force container removal

Just one line of code to add support for the "force" parameter when removing a container.

Hey @pvcnt, thanks for your work! Can you add a unit test for this, and maybe a use case in the documentation?

Hi @ubermuda, I've included some tests and documentation. I also modified the removeContainers to include the force parameters. I had to correct another failing test to go green.
By the way, if I try to remove a running container (without --force), I get an APIException, while I was expecting a UnexpectedStatusCodeException. It seems the error (conflict, status code 409) returned by the Docker API is not caught by the Docker client.

:+1: Thanks !


Show feature value for explain_prediction

For numeric features it can be valuable to know the feature value: for example, some feature can be either positive or negative depending on it's value, and it can be made more obvious if we add a third column "Value" to the feature weights table.
On the other hand, it's possible (and rather easy) to implement it outside of eli5, so I'm not sure if it's worth including.

Yeah, makes sense. It is not only about sign, but also about feature scale. Do we show features multiplied by weights now, or just the weights?

We show features multiplied by weights, and in case of trees we also show final contribution, so features with different scales will have the same weight if they have equal contribution.
I was also thinking that " (missing)" that we are discussing in #123 is also a special case of feature value. But I don't have a good idea how it fits together.


s/query_scope/records_for for preloader_extension.rb

Closes #24 for Rails v5.1.x compatibility.
s/query_scope/records_for for preloader_extension.rb, because AR::Associtations::Preloader::Association#query_scope was removed at https://github.com/rails/rails/pull/26379
This PR makes below 2 failing tests succeeded. Still we need to solve all failing tests (see for CI) for complete Rails v5.1.x support.
  7) Error:
PrecountTest#test_precount_has_many_with_scope_counts_properly:
NoMethodError: undefined method `map' for #<Favorite:0x007fd5eab49908>
Did you mean?  tap

  8) Error:
PrecountTest#test_polymorphic_precount:
NoMethodError: undefined method `map' for #<Notification:0x007fd5ee0904e0>
Did you mean?  tap

@k0kubun Would you review this 🙏 ?

Your description is very easy to understand and review! Greaaaaaaaaat work!! 👍 👍

Thanks for your quick reviewing :)

@k0kubun Would you mind releasing this fix with patched version, say for v0.6.4? 🙏
This is because our app relies on this gem's precount API. Though all API have no complete Rails 5.1 compatibility yet, this fix is necessary and sufficient for our app to upgrade the Rails.

Sure. Pushed as v7.0.0.beta1.

Thank you 👍


Pushbullet Implemented

Hi,
Is there any way that we could get pushbullet implemented into the bot?
Thanks

Once we get new build system working, we'll try to make notification system

Thx, it would be good to have a all platform bot program


Adds node_modules to the exclusion list

Since from Rails 5.1 come with yarn support, we need to ignore node_modules.
There can be some .rb files inside that. Example node_modules/node-sass/src/libsass/extconf.rb if node-sass is added.

Good catch! Thanks! 💯

this has been released as v0.3.0!
@saneef


[QUESTION] Import function returns blank array sometimes ?

I am trying to import Excel file (xlsx) and read the data as an array.But sometimes it reads as blank especially when testing on server (CentOS server).
On Local environment it works fine.
Local & Server environment :
PHP 7.2
Laravel 5.8
Laravel -excel 3.*
Can you please explain why that might happen ?

What kind of troubleshooting did you already do? So we know what we should ask and which information would help. Thanks.

Prerequisites

[x] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[ ] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[x] Checked that your issue isn't already filed.
[ ] Checked if no PR was submitted that fixes this problem.
[ ] Filled in the entire issue template

Versions

PHP version: 7.2.22
Laravel version: 5.8.*
Package version: ^3.1

Description
I am facing a weird issue where I am not able to read a xlsx file through import method.This file is getting read on local environment but the moment I am trying it on server (CentOS server) it's showing blank response.
I have even tried to use PhpOffice\PhpSpreadsheet methods to read that file but same issue.
File was modified & saved on Windows Microsoft Machine.

Steps to Reproduce
Try to read the following file.
demo.xlsx

Expected behavior:
File should be read in import.

Actual behavior:
File is not getting read.

If you have used PhpSpreadsheet directly then the issue doesn't lie within this package. Check if you have installed all the server requirements of PhpSpreadsheet. Perhaps Stackoverflow is a better location for this question.

I checked with phpspreadsheet as a last resort.Requirements of it are in place already. Thanks for the help anyways !


nit: add syntax highlighting to readme

Coverage: 99.367% (+0.0%) from 99.367% when pulling d783ec27ac41da7c3e0ebe6337ef6912d4eb207b on amilajack:patch-1 into b8c0be0323182a58132cf196b575893db5de6450 on knicklabs:main.


Wrong download link on draculatheme.com

Hey, the download link for the eclipse theme on your website is pointing to the wrong repository (https://draculatheme.com/eclipse).
It's : https://github.com/dracula/dracula/archive/master.zip
It should be : https://github.com/dracula/eclipse/archive/master.zip

Hey @svensto190, great spot! Thanks for pointing that out :),
I have corrected the link within the repo. I am unsure how long this may take to apply at draculatheme.com/eclipse.
I'll leave this issue open until I see the link has updated on the site. (Feel free to close if it has updated for you).
Cheers Z.


Add onResponse callback to sendProxy and proxyRequest

Describe the feature
Sometimes it is necessary to add/modify headers for proxy response. For example, we need to add some header or remove secure attribute from the cookie.
I suggest to add onResponse callback to sendProxy and proxyRequest (similar to onProxyRes in the http-proxy), which takes proxy event as argument, so we can do:
return proxyRequest(event, target, {
  headers,
  onResponse(_event) {
    setHeader(_event, 'foo', 'bar')
  }
})

Additional information

[X] Would you be willing to help implement this feature?

I think its better to upgrade proxyRequest to make it return modified response instead of sending response directly from method. @pi0

@pi0 Can you please share your thoughts on this?


Is there a way to influence data order?

Hi,
Great work on porting Chartkick to Python. Is there a way to display the data below sorted by keys?
{'02': 4397, '03': 0, '01': 9064, '06': 35622, '07': 14724, '04': 4745, '05': 14618, '08': 12947, '09': 11058, '12': 9112, '11': 9022, '10': 10373}
Tested sorting before rendering the template, but the order does not seem persistent.
Thanx a lot.
Regards,
Gerard.

I found a way to do it .. Jinja supports dictsort, except then you have to render the data dict in javascript, and control Google charts directly. This bascially renders chartkick.py obsolete and I would like to keep using it.
It gives a neat template code implementation., most code stays in the python modules and not in the templates.
However, this is the data loop to sort the dict on keys:
        var data = google.visualization.arrayToDataTable([
        ['Year', 'Visits', { role: 'style' } ],
            {% for month, count in data|dictsort %}
                ['{{ month|safe }}', {{ count }}, ''],
            {% endfor %}
      ]);

Any thoughts?
Regards,
Gerard.

Facing the same problem here.
Found this hacking on StackOverflow.


Added new ecu firmware code

What is your dongle id?

Here it is do you need more info?
Nic
Get Outlook for iOShttps://aka.ms/o0ukef

From: Shane Smiskol @.>
Sent: Sunday, April 30, 2023 11:04
To: commaai/openpilot @.>
Cc: nicakp @.>; Author @.>
Subject: Re: [commaai/openpilot] Added new ecu firmware code (PR #28067)
What is your dongle id?
—
Reply to this email directly, view it on GitHubhttps://github.com/commaai/openpilot/pull/28067#issuecomment-1528936927, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVXAGECD7KGUSKPA6HWS6L3XDXTWBANCNFSM6AAAAAAXQKFIHA.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Shane my comma3 still give the error of car unrecognized:(


feat(schematics): include code-editor as part of ng add

Description
Include code-editor as part of ng add schematics. Takes care of #1420
What's included?

Running ng add prompts user to setup covalent code editor

If chosen yes,  it adds @covalent/code-editor as a dependency in package.json

Test Steps

[ ] Navigate to covalent/scripts directory
[ ] Run ./precommit-schematics.sh : this is the script to test this entire feature locally as we haven't published it to npm yet.

General Tests for Every PR

[ ] npm run serve:prod still works.
[ ] npm run tslint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build:lib still works.

Screenshots or link to StackBlitz/Plunker

Awesome 👍


How to schedule monthly notification in ios?

Before openning an issue

Reproduce it with the example project in this repo.
If you can't receive iOS notification, make sure you can receive notification using quickstart-ios project provided by Firebase team

When openning an issue, please include following information for better support

What version of RN and react-native-fcm are you running?
What device are you using? (e.g iOS9 emulator, Android 6 device)?
Is your app running in foreground, background or not running?

I would say this has to be done on your server not in the React Native app

Android supports up to only weekly.
Since it is monthly, you can schedule 12 non-recurring notifications.


Update openshift preflight to v1.9.1 for v1.0.0

Description
Update preflight to v1.9.1 for v1.0.0
Follow up task to automate this with renovate was created by me :)
Checklist

[ ] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.87%. Comparing base (e2f7924) to head (42085d2).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.0    #2896   +/-   ##
============================================
  Coverage        67.87%   67.87%
============================================
  Files              250      250
  Lines            13670    13670
============================================
  Hits              9278     9278
  Misses            3585     3585
  Partials           807      807

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.