Breaks after Astro updates to 5.0.3

What version of starlight are you using?
0.29.2
What version of astro are you using?
5.0.3
What package manager are you using?
pnpm
What operating system are you using?
Linux
What browser are you using?
Firefox
Describe the Bug
Astro asked me to update to version 5. So I did:
pnpm dlx @astrojs/upgrade

 astro   Integration upgrade in progress.

      ◼  @astrojs/check is up to date on v0.9.4
      ◼  @astrojs/sitemap is up to date on v3.2.1
      ●  @astrojs/starlight will be updated to v0.29.2
      ▲  astro will be updated to  v5.0.3

  wait   One package has breaking changes. Continue?
         Yes

 check   Be sure to follow the CHANGELOG.
         astro Upgrade to Astro v5

 ██████  Installing dependencies with pnpm...

╭─────╮  Houston:
│ ◠ ◡ ◠  Have fun building!
╰─────╯

…which I immediately regretted…
npx astro dev
16:58:46 [vite] (ssr) Error when evaluating SSR module /home/chaas/projekte/ispmail-astro/workaround/astro.config.mjs:
|- Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './jsx/renderer.js' is not defined by "exports" in /home/chaas/projekte/ispmail-astro/workaround/node_modules/.pnpm/@astrojs+mdx@3.1.8_astro@5.0.3_rollup@4.24.0_typescript<EMAIL_ADDRESS>imported from /home/chaas/projekte/ispmail-astro/workaround/node_modules/.pnpm/@astrojs+mdx@3.1.8_astro@5.0.3_rollup@4.24.0_typescript@5.6.3_yaml<EMAIL_ADDRESS>    at exportsNotFound (node:internal/modules/esm/resolve:314:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:662:9)
    at packageResolve (node:internal/modules/esm/resolve:842:14)
    at moduleResolve (node:internal/modules/esm/resolve:926:18)
    at defaultResolve (node:internal/modules/esm/resolve:1056:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:654:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:603:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:586:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:242:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:135:49)

[astro] Unable to load your Astro config

Package subpath './jsx/renderer.js' is not defined by "exports" in /home/chaas/projekte/ispmail-astro/workaround/node_modules/.pnpm/@astrojs+mdx@3.1.8_astro@5.0.3_rollup@4.24.0_typescript<EMAIL_ADDRESS>imported from /home/chaas/projekte/ispmail-astro/workaround/node_modules/.pnpm/@astrojs+mdx@3.1.8_astro@5.0.3_rollup@4.24.0_typescript@5.6.3_yaml<EMAIL_ADDRESS>  Stack trace:
    at exportsNotFound (node:internal/modules/esm/resolve:314:10)
    at packageResolve (node:internal/modules/esm/resolve:842:14)
    at defaultResolve (node:internal/modules/esm/resolve:1056:11)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:603:25)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:242:38)

Link to Minimal Reproducible Example
https://github.com/Signum/starlight-astro5-breakage
Participation

[ ] I am willing to submit a pull request for this issue.

Seeing this as well after upgrade to v5 👍

As a temporary fix, add this to your package.json:
"overrides": {
  "@astrojs/mdx": "^4.0.0"
}

@morellodev added the override, but still got the same issue

@morellodev added the override, but still got the same issue

Did you re-run npm install again? Which package manager are you using?

same here, and i am using pnpm for now

The work around is fine for me, if you use pnpm you need to edit the package.json as follows (reference here):
"pnpm": {
  "overrides": {
    "@astrojs/mdx": "^4.0.0"
  }
}

and then re-run pnpm install. This should fix the issue!

Thanks @morellodev , after removing the node_modules and use your configuration, works fine now. Thanks!

@morellodev I am using Yarn

@morellodev I am using Yarn

"pnpm": {
  "overrides": {
    "@astrojs/mdx": "^4.0.0"
  }
}

@samrith-s I think you can use resolutions: https://yarnpkg.com/configuration/manifest#resolutions

"pnpm": {

"overrides": {

"@astrojs/mdx": "^4.0.0"

}

}

@samrith-s I think you can use resolutions: https://yarnpkg.com/configuration/manifest#resolutions

@DavidJFelix tried doing that, but still got the same error unfortunately

For bun, this worked for me:
"overrides": {
  "@astrojs/mdx": "^4.0.0"
}

And had to add this to astro.config.mjs:
legacy: {
    collections: true,
  },

Delete node_modules and then bun i

Support for Astro v5 has been released in Starlight v0.30.0. Thanks for your patience.

Something’s still broken. If you open the official StackBlitz template linked from getting started, it uses astro 5.0.8 and @astrojs/starlight 0.30.2, but it shows an error page and the following console output:
❯ npm install && npm run dev

added 417 packages in 11s

206 packages are looking for funding
  run `npm fund` for details

><EMAIL_ADDRESS>dev
> astro dev

14:00:37 [types] Generated 4ms

 astro  v5.0.8 ready in 7137 ms

┃ Local    http://localhost:4321/
┃ Network  use --host to expose

The collection "docs" does not exist or is empty. Ensure a collection directory with this name exists.
14:00:41 [content] Syncing content
14:00:41 [content] Content config changed
14:00:41 [content] Astro version changed
14:00:41 [content] Clearing content store
14:00:41 [content] Synced content
14:00:41 watching for file changes...
14:00:46 [ERROR] [RenderUndefinedEntryError]
  Hint:
    Check if the entry is undefined before passing it to `render()`
  Error reference:
    https://docs.astro.build/en/reference/errors/render-undefined-entry-error/
  Stack trace:
    at /home/projects/yqnimzjvjx.github/node_modules/astro/dist/core/errors/errors.js:13:5
    [...] See full stack trace in the browser, or rerun with --verbose.

Something’s still broken. If you open the official StackBlitz template linked from getting started, it uses astro 5.0.8 and @astrojs/starlight 0.30.2, but it shows an error page and the following console output:

Astro seems to be struggling with race conditions around content collections in v5. If you manually run astro sync before astro dev, things seems to work OK. Hoping we can find a solution soon.

Starlight with @astrojs/starlight-tailwind still breaks with the same error.
13:31:44 [vite] (ssr) Error when evaluating SSR module ~/Projects/hali/docs/astro.config.ts:
|- Error: Cannot find module<EMAIL_ADDRESS>    at createEsmNotFoundErr (node:internal/modules/cjs/loader:1181:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:1169:15)
    at resolveExports (node:internal/modules/cjs/loader:591:14)
    at Module._findPath (node:internal/modules/cjs/loader:668:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1130:27)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (~/Projects/hali/docs/node_modules/sucrase/dist/computeSourceMap.js:1:92)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)

[astro] Unable to load your Astro config

node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error: Cannot find module<EMAIL_ADDRESS>    at createEsmNotFoundErr (node:internal/modules/cjs/loader:1181:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:1169:15)
    at resolveExports (node:internal/modules/cjs/loader:591:14)
    at Module._findPath (node:internal/modules/cjs/loader:668:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1130:27)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (~/Projects/hali/docs/node_modules/sucrase/dist/computeSourceMap.js:1:92)
    at Module._compile (node:internal/modules/cjs/loader:1376:14) {
  code: 'MODULE_NOT_FOUND',
  path<EMAIL_ADDRESS>}

Node.js v20.11.1

Starlight with @astrojs/starlight-tailwind still breaks with the same error.


async router bug: async route with multiple children throws exception if you page load with full url path to child route

Note: for support questions, please use one of these channels: Chat: AngularClass.slack or Twitter: @AngularClass

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
bug

What is the current behavior?
If you have an async route that has multiple children, and you attempt to load the page with the full URL (i.e. www.mydomain.com/route/childroute/params), an unhandled exception will be thrown for "ChildRoute component cannot be found". Execution continues, but the router reverts to the base href /.

Just to be clear, when I say async route with multiple children, let's say +detail's routes is this:
export const routes = {
  path: 'detail', component: Detail,
  children: [
    { path: '', component: Index },
    { path: 'hello', component: Hello},
    { path: 'world', component: World},
    { path: 'user/:id', component: User}
  ]
};

and I want to load the page at: http://localhost:3000/detail/user/xyz123 this will throw the exception and the router reverts to /.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

What is the expected behavior?
Router should not throw exception and a full URL path with child routes should be supported.

What is the motivation / use case for changing the behavior?
This is a standard feature of any router

Please tell us about your environment:
June 30th build of angular2-webpack-starter. Running on mac, Chrome 51.0.2704.106

Angular version: 2.0.0-beta.X
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

this problem will be fixed in angular rc.5. For now, you have to manually create the async version of your routes
https://github.com/AngularClass/angular2-webpack-starter/blob/master/src/app/app.routes.ts
export const routes: RouterConfig = [
  { path: '',      component: Home },
  { path: 'home',  component: Home },
  // make sure you match the component type string to the require in asyncRoutes
  { path: 'about', component: 'About',
    resolve: {
      'yourData': DataResolver
    }},
  // async components with children routes must use WebpackAsyncRoute
  { path: 'detail', component: 'Detail',
    canActivate: [ WebpackAsyncRoute ],
    children: [
      { path: '', component: 'Index' }  // must be included
    ]},
  { path: '**',    component: NoContent },
];

for you would be
export const routes: RouterConfig = [
  { path: '',      component: Home },
  { path: 'home',  component: Home },
  // make sure you match the component type string to the require in asyncRoutes
  { path: 'about', component: 'About',
    resolve: {
      'yourData': DataResolver
    }},
  // async components with children routes must use WebpackAsyncRoute
  { path: 'detail', component: 'Detail',
    canActivate: [ WebpackAsyncRoute ],
    children: [
      { path: '', component: 'Index' },
      { path: 'hello', component: 'Hello'},
      { path: 'world', component: 'World'},
      { path: 'user/:id', component: 'User'}
    ]},
  { path: '**',    component: NoContent },
];


Added metrics to Smartling TMS sync

Adds latency metrics to the Smartling Third Party Sync to enable a better understanding of where performance bottlenecks may occur.

@aurambaj Just to note that there is some existing instrumentation on the overall push/pull methods using the @Timed annotation
  @Timed("SmartlingSync.push")
however we can't use tags with this approach as the specific runtime repo/locale isn't available at compile time. With this in mind should I remove the above annotation and rename the new stats to match the old stat or leave them as they are in the PR at present?


Support for CloudFlare DNS provider for Federated clusters

 Issue by thecodeassassin
Wednesday Jul 26, 2017 at 14:27 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/49639

/kind feature
Currently federation only supports Google CloudDNS, Route53 and CoreDNS. I would love if if CloudFlare could also be supported since we use them for our DNS zones. I'm sure this will be a popular addition as well. It's already supported for ExternalDNS. I'm sure most of the work can be driven from existing providers and ExternalDNS:
https://github.com/kubernetes-incubator/external-dns/blob/master/provider/cloudflare.go
Maybe it would be nice to merge them at some point. Is there anybody already working on this or will it be my summer project?

 Comment by thecodeassassin
Wednesday Jul 26, 2017 at 14:30 GMT

/sig federation

 Comment by Krymonota
Sunday Aug 20, 2017 at 14:20 GMT

I, too, would love to see this feature being implemented.

 Comment by quinton-hoole
Saturday Sep 02, 2017 at 00:32 GMT

@thecodeassassin @Krymonota a PR from you would be most welcome.

cc @thecodeassassin


Change sed regex to match beginning of line

Not having the ^ in the regex causes sed to match over the
entire line.
The python-django==3.1.2 would be removed from test.txt because
of that.

Same issue and same fix here @snowcrshd :wink:

This fix was finally made in https://github.com/edx/cookiecutter-django-app/pull/25 ; sorry for the delay.


Adding a analyzer which will analyze radial solvent density profile

This pull request is to add a RadialSolventVelocityAnalyzer for mpcd particles so it analyse the density profile of mpcd solvent.
Checklist:

[ ] I have reviewed the Contributor Guidelines.
[ ] I agree with the terms of the HOOMD-blue Contributor Agreement.
[ ] My name is on the list of contributors (sphinx-doc/credits.rst) in the pull request source branch.

Currently these are rough changes-
Just added 2 files -
RadialSolventAnalyzer.h
RadialSolventAnalyzer.cc

Now after above commit, the code has updated changes according to the suggested changes in previous review and also added the solvent radial velocity part.

Thanks alot! I went through the code and everything looks okay to me.


fix: make js files path valid

Details
The isPathInvalid method use this variable to check if a path is valid.
Added .js to make  #371, #368 and #363 work.
Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I checked the current PR for duplication.

btw @pd4d10 this was released in canary. I'm working on some other issue atm, will include this in next patch sometime this or next week


Splat quality decrease after upgrading to gsplat 1.0.0

Splat quality significantly decreases after upgrading nerfstudio & gplat. I am using nerfstudio in a docker container based off of the nerfstuido/nerfstudio image after I ran into problems using the dromni/nerfstudio image a few months back.
Steps to reproduce the behavior:
Upgrade nerfstudio & gplat with pip install -U nerfstudio
Process images with ns-process-data images
Process Splat with ns-train splatfacto
Observe splat model in viewer. The statue is not recognizable
Expected behavior
The statue should be easily noticeable after loading the splat model
Statue splat before upgrading gsplat & nerfstudio

Statue splat after upgrading gsplat & nerfstudio

Both of these splats used the same source video, which can be viewed when clicking on the "Download Original Video" button in the splat viewer, which is at https://ez3d.nyc.
Thanks again to all the folks at nerfstudio for all of your awesome work. Please let me know if there is any more information I might need to provide to help resolve this issue.

What torch version are you using? There are problems with Torch 2.0.1. If so, you could upgrade to 2.1.2.

 I was indeed on Torch 2.0.1. After running pip install -U torch==2.1.2 it worked! Training did seem to be a bit faster, but tough to notice due to colmap still :/ That said, what was most impressive was that the splat took up half the disk space than the one produced from the previous nerfstudio version. Literally went from 5.4 MB to 2.7 MB which is so huge when trying to render these splats on the client. Congrats on the awesome work, I am looking forward to regenerating all of my splats now, lol

Closing this one for the related issue #3235


compute_pixel_cluster_channel_avg is prohibitively slow

Is your feature request related to a problem? Please describe.
The compute_pixel_cluster_channel_avg function takes as long as the actual mapping of pixels. This isn't a big deal for small datasets, but for large datasets this single function takes almost 14 hours to run.
Describe the solution you'd like
Given that the only point of this function is to create the weights for the heatmap, I think some aggressive downsampling for the number of FOVs that this average is computed from would work.
Describe alternatives you've considered
Is there different logic we could use to create this @cliu72? The same function gets called again in the metaclustering step, which doubles the amount of time devoted to this

@ngreenwald I'll also do some timing tests to see where the big bottlenecks are coming from.

This function has a for loop through all the FOVs. Can't think of another way to do it if we want to read in all the data. Downsampling should be okay, we can do some tests to see how much the heatmaps change with different amounts of downsampling.

Also, what is the reason that we need to compute this for pixel clusters, in addition to the pixel metaclusters?
In the consensus clustering we read in the computed cluster expression for each pixel cluster, update the labels to have the metaclusters, and then save it. Is there a scenario where people care about the expression in each cluster, rather than metacluster?

https://github.com/angelolab/ark-analysis/blob/3454c62f9fa9d6947ba732450e0d7299430261cf/ark/phenotyping/som_utils.py#L1336

Also, what is the reason that we need to compute this for pixel clusters, in addition to the pixel metaclusters?
In the consensus clustering we read in the computed cluster expression for each pixel cluster, update the labels to have the metaclusters, and then save it. Is there a scenario where people care about the expression in each cluster, rather than metacluster?

https://github.com/angelolab/ark-analysis/blob/3454c62f9fa9d6947ba732450e0d7299430261cf/ark/phenotyping/som_utils.py#L1336

This is mostly done to ensure support for the metacluster remapping GUI, which requires data in the format of pc_chan_avg_som_cluster_name (channel expressions for each SOM cluster, with additional mapping to meta cluster).
I'm not sure if people will actually care about the SOM channel expression, since the desired results should be based on meta clusters. @cliu72 have there been any applications where people have preferred the results generated by the SOM clusters over the meta clusters?

Also, what is the reason that we need to compute this for pixel clusters, in addition to the pixel metaclusters?
In the consensus clustering we read in the computed cluster expression for each pixel cluster, update the labels to have the metaclusters, and then save it. Is there a scenario where people care about the expression in each cluster, rather than metacluster?

https://github.com/angelolab/ark-analysis/blob/3454c62f9fa9d6947ba732450e0d7299430261cf/ark/phenotyping/som_utils.py#L1336

This is mostly done to ensure support for the metacluster remapping GUI, which requires data in the format of pc_chan_avg_som_cluster_name (channel expressions for each SOM cluster, with additional mapping to meta cluster).
I'm not sure if people will actually care about the SOM channel expression, since the desired results should be based on meta clusters. @cliu72 have there been any applications where people have preferred the results generated by the SOM clusters over the meta clusters?

I'm a little confused. Isn't the pixel SOM x marker expression values needed for the GUI (like you mentioned)? So this table needs to be created.

@cliu72 my bad, my question wasn't worded well. The remapping interface applies to meta clusters, just wondering out of curiosity how many applications you've seen where the user skips the remapping step completely due to relying on just the SOM labels.
In either case, agreed, I don't think it's possible to remove this merge_asof step because of the data format the remapping GUI takes. Additionally, the merge is being done on a DataFrame that's just 100 rows, so it isn't a massive computational step.

We can first try taking advantage of the method @ngreenwald and @camisowers researched in #751, where appending pandas dataframes to a list and concatenating outside the loop runs ≈5x faster. This might won't be enough of an optimization in itself but this could allow us to reduce the amount of downsampling needed.

Agreed that it's worth updating, since it's a free speedup. However, the underlying issue is that the per-FOV function is very time intensive, so with lots of FOVs it takes forever. We'll also need to add in the downsampling ability

Having talked with @cliu72 I think all this change will entail is adding a new parameter like subset_proportion in create_pixel_matrix to compute_pixel_cluster_channel_avg and randomly sample each FOV pixel DataFrame prior to averaging, unless there's additional considerations to the sampling that need to be taken into account.

Agreed, that's what I was thinking as well


Align ReverseDSC extract with a given version of SPDSC Module

Since the ReverseDSC versioning is now in-line with the SharePointDSC release cycle, and since it tightly-coupled with it, we would need to have the extracted DSC configuration specify what version of the SharePointDSC module is was extracted against in the Import-DSCResource statement.

Fixed in v<IP_ADDRESS>


[WIP] DO NOT REVIEW - Temporary PR to cherry-pick unmerged DW changes and build an image in CI

Please disregard this. The changes in this diff are from other PRs, I'm using this to trigger the CI image build because I'm lazy.

Replaced by https://github.com/opendatahub-io/odh-dashboard/pull/2673.


Edits to outline

These are the edits that I suggested. I will add some concrete examples tomorrow.

OK, I've added some specific examples for us to use. Feel free to amend if you have better ones.


:package: feat: Init blockexplorer package

Description
Init blockexplorer package. Blockexplorer package provides utils for interacting with a block explorer. Currently included are utils for generating block explorer urls
Testing
Unit tests
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address: evmts.eth

Current dependencies on/for this PR:

main

PR #506

PR #507   👈

PR #505

PR #503

This comment was auto-generated by Graphite.


Failed to configure container host for Azure Dev Spaces Controller

azds-sdk-2020-02-16-23-57-23-23044.txt
Describe the bug
We have Azure kubernetes services instance hosted in Australia East region, 3 nodes. agent nodes is in 'Ready' state,  one node reach 70% of the total CPU. I checked the service principal is valid.  Still getting the following error every time I try to enable azure dev spaces - both in CLI and on web.
Long running operation failed with status 'Failed'. Additional Info:'Failed to configure container host for Azure Dev Spaces Controller. Please check that the service principal used to create the cluster is valid and the agent nodes are in 'Ready' state and not running low on resources.
To Reproduce
Steps to follow to reproduce this issue.

Expected behavior
A clear and concise description of what you expected to happen.
Logs
Attach logs from the following directory:
For Windows: %TEMP%/Azure Dev Spaces
Environment Details
Client used (CLI/VS Code/Visual Studio):
Client's version:
Azure Dev Spaces CLI
1.0.20200204.4
API v3.2
Operating System:
Windows 10
Additional context
Add any other outputs from the clients or context you would like to share.

Hi @leizhang Thank you for reporting this issue. I have logged a bug for our team to investigate this.

Hi @leizhang Thank you for reporting this issue. I have logged a bug for our team to investigate this.

Thanks, @pragyamehta.

@leizhang It looks like this controller has been deleted. From our service logs I can see that we were unable to run the pod on this cluster and get the logs from it.
tunnelfront pod in kube-system namespace is responsible for maintaining the connection to get logs, deleting it and recreating it can solve the tunneling problem if there is one. Also please check that the cluster nodes have enough CPU and memory.
In case you still see this issue, please don't remove the dev spaces controller for further investigation. Thanks!

@sanar-microsoft,  thank you for your reply! Straight to the point.  After I deleted the tunnelfront pod in kube-system, I'm able to enable dev-space in our instance. Thank you.

@leizhang It looks like this controller has been deleted. From our service logs I can see that we were unable to run the pod on this cluster and get the logs from it.
tunnelfront pod in kube-system namespace is responsible for maintaining the connection to get logs, deleting it and recreating it can solve the tunneling problem if there is one. Also please check that the cluster nodes have enough CPU and memory.
In case you still see this issue, please don't remove the dev spaces controller for further investigation. Thanks!


Add suggested actions flow layout

Fixes #2745.

Changelog Entry
Added

Resolves #2745. Added new inline layout to suggested actions, by @compulim in PR #XXX

Description
Added a new layout to suggested action: inline. And a new option to curb the height of the container and make it scrollable: suggestedActionsInlineMaxHeight.

Specific Changes

Added new layout to SuggestedActions.js, and refactored
Modified SuggestedAction.js to use non-flexbox for laying out images inside buttons
Updated styleOptions:

Added new inline option to suggestedActionLayout
Added new suggestedActionsInlineMaxHeight

[x] I have added tests and executed them locally
[x] I have updated CHANGELOG.md
[x] ~I have updated documentation~

Review Checklist

This section is for contributors to review your work.

[x] Accessibility reviewed (tab order, content readability, alt text, color contrast)
[x] Browser and platform compatibilities reviewed
[x] CSS styles reviewed (minimal rules, no z-index)
[x] ~Documents reviewed (docs, samples, live demo)~
[x] ~Internationalization reviewed (strings, unit formatting)~
[x] ~package.json and package-lock.json reviewed~
[x] ~Security reviewed (no data URIs, check for nonce leak)~
[x] Tests reviewed (coverage, legitimacy)

When will this be released? Also what is the exact usage?
e.g. suggestedActionLayout: 'inline',

When will this be released? Also what is the exact usage?
e.g. suggestedActionLayout: 'inline',


Help with breaking the reviews file into json

I am working on a project and I have a csv file which I want to convert the reviews present in the csv file to json, I have been able to do that and I have a large json file, but I was wondering how you broke your json file such that you have each reviews from 1-1000 well labelled

A small bit of JavaScript was written to handle the conversation and splitting. We checked it in when we open sourced the code, check the tools folder:
https://github.com/IBM/watson-discovery-food-reviews/blob/master/tools/csvtojson.js

@stevemar to get that done to my csv file, would I need to use javascript as well, because the file I am working with is a csv file having  productid, productname and reviews,

`const csvFilePath='C:/Users/KazeemTijani/Desktop/mainTPS.csv';
const csv=require('csvtojson');
const fs=require('fs');
// Filters
let everyNth = 10;  // Keep every Nth row
let rowLimit = 2000;  // Max number of rows to parse
let padding = '000';  // to Line up the numbers and slice(-4).
let fileLimit = 2000;  // Max number of files to write
let files = 0;
let lines = -1;
csv({
headers:['surveyId','ProductCode','ltrScore','comments'],
noheader:false,
colParser:{
'ltrScore':'number',
},
checkType:false
})
.fromFile(csvFilePath)
.preFileLine((fileLineString, lineIdx)=>{
lines += 1;
if (rowLimit > 0 && lineIdx - 1 > rowLimit) {
return '';
}
if (everyNth > 0 && ((lines % everyNth) > 0)) {
return '';
}
return fileLineString;
})
.on('Desktop',(jsonStr)=>{
files += 1;
if (files - 1  < fileLimit) {
fs.writeFile('C:/Users/KazeemTijani/Desktop/offering_review/review_' + (padding + files).slice(-4) + '.json', jsonStr, (err) => {
if (err) throw err;
// console.log('The file has been saved!');
});
}
})
.on('done',(error)=>{
if (error) throw error;
// console.log('end');
});`

Kindly help check through that if it made any sense, its my first time using Javascript, But i need to get the json file to split, thanks

@Tkprudent - hello. If you aren't familiar with Javascript, this may not be the best code pattern for you to attempt. As for your changes to the script, one problem I see is you use on('Desktop'. This needs to be changed back to on('data'. Those are events being returned from the stream, and not file locations. I would recommend running the script and see what it does. Easy enough to delete bad files and try again as you work through any issues.

Thanks Steve and Rich for taking time to help out


allow tags as a type property in custom swagger types

Use standard openapiv3 attributes for tag...  See component object: https://swagger.io/specification/
example seal rule
allow subject group patissiers to manage products.inventory where ctx.tag["department"] == "bakery" and ctx.name == "cheesecake";

It should look like products.inventory swagger file:
openapi: "3.0.0"
components:
  schemas:
    products.inventory:
      type: object
      properties:
        id:
          type: string
        name:
          type: string
        tags:
          $ref: '#/components/schemas/tag'
      x-seal-actions:
      - allow
      - deny
      x-seal-verbs:
      - inspect
      - use
      - manage
      x-seal-default-action: deny

global swagger file defines tag type - see #76:
openapi: "3.0.0"
components:
  schemas:
    tag:
      type: object
      additionalProperties: true

references:
see https://github.com/infobloxopen/seal/pull/25

$ref: '#/components/schemas/tag' seems to be ok only in case tag is defined at the same swagger file


chore(bb readme): Document how to Honk Noir programs

Document:

Basic example of how to use bb prove_ultra_honk, bb write_vk_ultra_honk and bb verify_ultra_honk with Noir
Preliminary example of how to use bb contract_ultra_honk as @Maddiaa0 shared (to confirm validity pending a new BB release is cut with the functionality)
Minor note on bb <command>_mega_honk for people wanting to use MegaHonk

~TODO: Wait for Barretenberg v0.47.1 <> Noir compatibility and complete Solidity verifier workflow~ Done
To consider in future Issue(s):
Recommend prove_keccak_ultra_honk as default; prove_ultra_honk (Poseidon) as advanced proving for off-chain + recursion use cases only

@ludamad grateful for your LGTM


CurlNoise function

I would like to use the CurlNoise function and was wondering who's the author (to mention her/him). Is that you @spite or someone else? I'm talking about this one:
vec3 curlNoise( vec3 p ){
	const float e = .1;
	vec3 dx = vec3( e   , 0.0 , 0.0 );
	vec3 dy = vec3( 0.0 , e   , 0.0 );
	vec3 dz = vec3( 0.0 , 0.0 , e   );
	vec3 p_x0 = snoiseVec3( p - dx );
	vec3 p_x1 = snoiseVec3( p + dx );
	vec3 p_y0 = snoiseVec3( p - dy );
	vec3 p_y1 = snoiseVec3( p + dy );
	vec3 p_z0 = snoiseVec3( p - dz );
	vec3 p_z1 = snoiseVec3( p + dz );
	float x = p_y1.z - p_y0.z - p_z1.y + p_z0.y;
	float y = p_z1.x - p_z0.x - p_x1.z + p_x0.z;
	float z = p_x1.y - p_x0.y - p_y1.x + p_y0.x;
	const float divisor = 1.0 / ( 2.0 * e );
	return normalize( vec3( x , y , z ) * divisor );
}

By the way I also noticed that 2 other curl noise and 1 noise functions are not even used! You could remove ~100 lines. Amazing how short and clean is the code, compared to the complexity of the result. Bravo :)

Curl noise is a fairly standard way of getting divergence free fields. There's many GLSL implementations out there. Differences in the implementation yield different results in the simulation. Here's some examples:
https://github.com/dli/flow
https://github.com/cabbibo/glsl-curl-noise
https://codepen.io/timseverien/pen/EmJNOR
In this case i'm using cabbibo's, but i don't remember where he got it from.

Thanks @spite


chore: bdd-sbhg-import-1587850315 to 0.0.1

chore: Promote bdd-sbhg-import-1587850315 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Node is slow to receive payments

We've noticed one of our nodes consistently taking longer to receive payments when compared to the rest. This one takes around 1 minute while others take under 10 seconds.
The node ID is 035458b2dd3e2a89213f6ea4cb205463c6d1c3bbbafd30d77ffa1875e957ae1382

Ok, looking into session_id=7197154242203648 from 2024-05-17T10:41:29+02:00
Timeline

2024-05-17T10:41:29 Node scheduled

2 channels, no HTLCs pending

2024-05-17T10:41:32 Node startup complete
2024-05-17T10:41:35 Signer 0 connected
2024-05-17T10:41:36 Gossip sync complete
2024-05-17T10:41:40 Both channels are correctly re-established
2024-05-17T10:42:46 Signer 1 connected
2024-05-17T10:43:44 Signer 0 dies
2024-05-17T10:43:48 Receiving an incoming HTLC
2024-05-17T10:43:50 Blockchain sync not completed yet (843793), deferring the commit
2024-05-17T10:44:24 Finally synced with the chain, committing changes now that we can be sure the channel is still alive

Blockchain sync in progress from block 843708 to 843837.
So the root cause for this 30 second receive is the blockchain lag that the node had at that time (129 blocks). Obviously the payment itself may have taken longer to find a route and actually route the payment to us, but that's the part we have control over. This is the counterpart to https://github.com/ElementsProject/lightning/pull/7190 which we just release a couple of weeks ago. We are planning to tackle this in two ways:

Ensure the blocklag is reduced, resulting in a reduction of time until we can acknowledge the HTLC
Free us from having to fully sync altogether by splitting the final CLTV into two components: lag-allowance and security parameter. Lag allowance allows us to accept HTLCs before being synced by extending the security parameter by a buffer. Should we notice the channel closed in the meantime, we can still punish the counterparty by using the security margin.

Both regions are now back in sync with the blockchain, with individual stragglers due to different block processing speeds, depending on number of addresses we're checking for.


ci: Temporarily disable publishing to GitHub Packages

Description

On the first publishing CI run, publishing to GitHub Packages succeeded, but failed for Maven Central due to a credentials issue.
This temporarily skip GH Packages publishing so we can try to get the Maven Central publish working.
If both succeed at the same time, this should be unnecessary
If we think we might ever hit one-succeeds and one-fails again, we could consider splitting the publishing workflows for the two repositories apart
References

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

The Auth0 folks prefer the shorter 'dev.openfga' group id (See: https://github.com/openfga/java-sdk/pull/18) and changing the group id will prevent the next publish workflow from colliding, so this PR is unnecessary.
Will close this


faster Rust programs

grr, conflicts. rebasing...

...rebased.

Thanks for the PR, Time - I/O reduced from 38ms to 23ms.
I will have to create a new folder for this as it's so far from the other implementations. I think I will call it "rust_max"


Support multiple input volumes

Some models are trained using multiple input images (e.g. https://github.com/Project-MONAI/tutorials/tree/main/auto3dseg/tasks/hecktor22)
Selectors could be dynamically created when segmentation model is selected.

Hi @che85,
Thanks for opening this issue.
I've updated the inference script here: https://github.com/lassoan/SlicerMONAIAuto3DSeg/pull/29
We'll be working on the UI part so it sends a dictionary with the image paths.


Index alert text

Added Alert Text to the Elasticsearch Index, which is useful for teams / tools which leverage the index as their alert database, and for looking back over old alerts

this can get awkward with alert bodys that add the fields


[backport] Fix sparse.__getitem__ not to return view of input

Backport of #3975

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit be5dfff154b181bf3bd92e58a979bc2e58f24830, target branch v8) succeeded!


[HUDI-6423] Incremental cleaning should consider inflight compaction instant

Change Logs
Illustration of issue before fix
Incremental has a sliding window that bounds it's cleaning partition as shown below. If there is an async table service action as shown in the illustration below, partitions might be skipped if it falls behind the cleaning window.

Note: The illustration might not be the entirely correct in the determination of earliest commit to retain, but it does give a general illustration of the sliding window.
Fix
In #7568, clean will be blocked by any pending action. As such, by factoring COMPACTION actions into the active timeline, the sliding window of incremental range will be bounded correctly to not ahead of any pending writes made via compaction.

Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure

@hudi-bot run azure

@hudi-bot run azure

There are many test failures:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=18249&view=logs&j=600e7de6-e133-5e69-e615-50ee129b3c08&t=bbbd7bcc-ae73-56b8-887a-cd2d6deaafc7&l=16819
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=18249&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=e0ae894b-41c9-5f4b-7ed2-bdf5243b02e7&l=569172

There are many test failures:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=18249&view=logs&j=600e7de6-e133-5e69-e615-50ee129b3c08&t=bbbd7bcc-ae73-56b8-887a-cd2d6deaafc7&l=16819
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=18249&view=logs&j=b1544eb9-7ff1-5db9-0187-3e05abf459bc&t=e0ae894b-41c9-5f4b-7ed2-bdf5243b02e7&l=569172

TestCleaner.testKeepLatestCommitsWithPendingCompactions has been fixed, seems that TestGlobalIndexEnableUpdatePartitions is not my problem.

@hudi-bot run azure

Description and context please...
Illustration of issue before fix
Incremental has a sliding window that bounds it's cleaning partition as shown below. If there is an async table service action as shown in the illustration below, partitions might be skipped if it falls behind the cleaning window.

Note: The illustration might not be the entirely correct in the determination of earliest commit to retain, but it does give a general illustration of the sliding window.
Fix
In https://github.com/apache/hudi/pull/7568, clean will be blocked by any pending action. As such, by factoring COMPACTION actions into the active timeline, the sliding window of incremental range will be bounded correctly to not ahead of any pending writes made via compaction.

Description and context please...
Illustration of issue before fix
Incremental has a sliding window that bounds it's cleaning partition as shown below. If there is an async table service action as shown in the illustration below, partitions might be skipped if it falls behind the cleaning window.

Note: The illustration might not be the entirely correct in the determination of earliest commit to retain, but it does give a general illustration of the sliding window.
Fix
In #7568, clean will be blocked by any pending action. As such, by factoring COMPACTION actions into the active timeline, the sliding window of incremental range will be bounded correctly to not ahead of any pending writes made via compaction.

Description and context please...
Illustration of issue before fix
Incremental has a sliding window that bounds it's cleaning partition as shown below. If there is an async table service action as shown in the illustration below, partitions might be skipped if it falls behind the cleaning window.

Note: The illustration might not be the entirely correct in the determination of earliest commit to retain, but it does give a general illustration of the sliding window.
Fix
In #7568, clean will be blocked by any pending action. As such, by factoring COMPACTION actions into the active timeline, the sliding window of incremental range will be bounded correctly to not ahead of any pending writes made via compaction.

Thanks for the description of the scene~~  Added to current pr change-logs.

Thanks for the description of the scene~~ Added to current pr change-logs. @voonhous


Add ability to retrieve Docker version(s)

New methods:

docker_version()
docker_client_version()
docker_server_version()

default behavior is to query the master for this information, but
methods support host specification.

@mesosphere-ci retest this please

retest this please

@mesosphere-ci retest this please

@mesosphere-ci retest this please

@mesosphere-ci retest this please

Failures are unrelated to the code in this PR; if a cluster can properly be provisioned by AWS, the results pass.
cc: @falseperfection and @colin-msphere: I've addressed your earlier comments.


Benchmark fails to run since changing TargetFramework to: net8.0-windows

With <TargetFramework>net7.0-windows</TargetFramework> it was fine - I tried it today.
I was integrating nuget: Friflo.Engine.ECS.
This change in the *.csproj file now throws the error dumped below.
<TargetFramework>net8.0-windows</TargetFramework>
If I change to <TargetFramework>net8.0</TargetFramework> it runs.
But I have to remove MonoGame from benchmark because it is not compatible with net8.0.
I guess the suffix -windows prevents running on Linux & macOS. Not sure.
Would be nice if tests can run also on these platforms.

G:\_dev\ECS\Doraku-Ecs.CSharp.Benchmark\source\Ecs.CSharp.Benchmark\bin\Release\net8.0-windows\6b12e65d-f600-4641-9739-7a9ac928b996\BenchmarkDotNet.Autogenerated.csproj : error NU1201: Project Ecs.CSharp.Benchmark is not compatible with net8.0 (.NETCoreApp,Version=v8.0). Project Ecs.CSharp.Benchmark supports: net8.0-windows7.0 (.NETCoreApp,Version=v8.0)
  Failed to restore G:\_dev\ECS\Doraku-Ecs.CSharp.Benchmark\source\Ecs.CSharp.Benchmark\bin\Release\net8.0-windows\6b12e65d-f600-4641-9739-7a9ac928b996\BenchmarkDotNet.Autogenerated.csproj (in 97 ms).
  1 of 2 projects are up-to-date for restore.

// BenchmarkDotNet has failed to build the auto-generated boilerplate code.
// It can be found in G:\_dev\ECS\Doraku-Ecs.CSharp.Benchmark\source\Ecs.CSharp.Benchmark\bin\Release\net8.0-windows\6b12e65d-f600-4641-9739-7a9ac928b996
// Please follow the troubleshooting guide: https://benchmarkdotnet.org/articles/guides/troubleshooting.html

Additional note:
I tried the latest version without my changes.
https://github.com/Doraku/Ecs.CSharp.Benchmark/commit/70c0f5482e913dc7c0bc518dca9a270062f55123

there was an other error during initialisation with the Morpeh context at runtime which was not picked up by the ci for some reason :/ not sure if this was linked.
I also changed the monogame dependencies so it should be compatible with more os.
Currently trying to rerun everything on my potato computer to update readme and results.

I also changed the monogame dependencies so it should be compatible with more os.

I tried following revision now successful
https://github.com/Doraku/Ecs.CSharp.Benchmark/commit/3574b2dfb948e941a208f77eaf9e94b73d58e6bf
So with all your csproj changes.
Thx for fast response!


bug: default subnet generate ippool for non-spiderpool pod

https://github.com/spidernet-io/spiderpool/pull/1254


Updated UI of Team Section on Home Page

Changes Made:
Updated UI from:

to

It is good but we want color theme according to the color palette in style-guide. Do check it and update, also see add 3 more cards for team members. Add hover effect similar to current one (check existing design on website) to each of the cards.

Noted


Universal SQL: Source Refresh Experience

This is going to be centred around the CLI command:

Polish the overall build sources system
Offer a convenient way to re-execute source queries
Offer enough feedback in dev mode on which queries are running (prevent a broken app state while they are running)
Prevent booting the dev mode without built sources / auto build on boot, with some cacheing
VS Code button to execute a source rebuild for all sources
Not need to re-boot dev server upon building sources
Remove query status as appropriate

run build:sources - runs all sources
run build:sources sales_snowflake runs just the sales_snowflake source

For re-execution it may be a good idea to allow database connectors to expose some function onSourceFileChange or similar; this would get passed the connector options and the filepath of the changed source file, and possibly a way for the database connector to invoke HMR / a page refresh (from vite/rollup).
Implementing it this way would allow connectors to take control of when things need to be re-executed (e.g. postgres probably only cares if the .sql files change, while duckdb cares if the .duckdb file changes or if the .sql files change)


Preprocessing training data

Hello,
I want to understand the preprocessing of the cityscapes dataset to deploy it on a custom dataset.
Since this part is sparsely documented, I have some question.
In the provided prepossessed  dataset (http://robotics.ethz.ch/~asl-datasets/Dissimilarity/data_processed.tar) are semantic and synthesized images.
As far as I could follow, the semantics are created with the python file "create_unknown_examples.py" and not with the segmentation network?
With the temp folder created with this script, the synthesized images are created?
So then my observations right, the segmentation network is needed for the hole pipeline to make predictions on new pictures, but not for the training of the dissimilarity network.
I haven't found a python script for creating the logit-distance, mae-features and entropy. How did you calculate them?
Have i forgotten a step, that is needed to create the datasets?

Hello @TobiasMei, I also want to use custom datasets. Can you tell me how you prepare dataset?
Looking forward to your reply


removing dead code/unused constant

ENABLE_MAGIC is unused in the car/fob source, and can be omitted.

@dtwalter approved


Hiding code scanner from view does not release the camera

Closing the containing sheet does release the camera though.
The trick that works to re-initialise the camera on re-appearance (https://github.com/twostraws/CodeScanner/issues/120) does not help camera to disappear.
Is it something that can be done with or without library change? Maybe expose some method to disable the camera?

I just noticed a similar case as well:
Steps to reproduce:

Open a view that has the camera and wait for the camera session to be started
Navigate to another app (slide at the bottom or receive a call)
When you come back to the app, quickly switch to another tab that doesn't have the camera screen
After some time the camera session starts even though the view is no longer visible

Possible fix:
Remove if captureSession?.isRunning == true { check from ScannerViewController.swift's viewDidDisappear.
Why? Calling self.captureSession?.startRunning() from setupSession() hasn't completed yet before we switch to another screen, which results in isRunning returning false.
Or better refactor the state management with an enum instead of depending on multiple booleans, something like:
enum CameraSessionState {
  case stopped
  case requestedToStart(Run?)
  case running
  case interrupted
}

Thinking about it a bit more, is there a memory leak that's keeping the session? 🤔


Updated a link in the README

The current link to contribute code doesn't link to anything real helpful, so I changed it
to an actual link in the documentation that is very helpful.

merged in f7bf135f62297c580e9b36af4c2470adb652fbaf, thanks.


react/no-unused-prop-types with reassigning this

Sorry if this is a duplicate, but I couldn't find it.
I get the ubiquitous PropType is defined but prop is never used when using the following (stripped down) code. I assume this is all because I am re-assigning this to self as if I replace self.props with this.props, everything works.
import React, { Component } from 'react';
import PropTypes from 'prop-types';

import loggerShape from '../propTypes/logger';

class Video extends Component {
  constructor(props) {
    super(props);
  }

  componentDidMount() {
    const self = this;

    const { src, logger, contentType } = self.props;

   ...

    function addListener(eventName, logMethod = 'info') {
      self.player.on(eventName, () => {
        logger[logMethod](`player event - ${eventName} - ${src}`);
      });
    }

    addListener('abort', 'error');

    setSource({
      src,
      type: contentType,
    });

   ...
  }

  render() {
    return (
      <div className="video">
         ...
      </div>
    );
  }
}

Video.propTypes = {
  contentType: PropTypes.string.isRequired,
  logger: loggerShape.isRequired,
  src: PropTypes.string.isRequired,
};

export default Video;

ESLint versions
"eslint": "4.19.1",
"eslint-config-airbnb": "17.1.0",
"eslint-plugin-import": "2.14.0",
"eslint-plugin-jest": "21.21.0",
"eslint-plugin-jsx-a11y": "6.1.1",
"eslint-plugin-react": "7.11.0",

Understood :-) i just mean that var self = this shouldn't really ever appear in any code authored in an ES2015+ environment.


Fedora

Hello, I love the program. I am just having trouble installing this on fedora 25. I think it may be a problem with the naming structure of fedora vs ubuntu? I have installed all the dependencies, but it keeps complaining about not having PyQt5. I think fedora may call it "python-qt5". Is there any way to fix this?

Could you please append the console output of a run of lcurse?
Make sure pyqt5 is installed.
Make sure, that the following line works in python commandline:
from PyQt5 import Qt

It was user error. I had to do "python3 -m pip install PyQt5" to install PyQt5. I really hate they python version variances.
Once I did that lcurse ran great. Thanks for the excellent program!

Glad you could fix it!


Update to JupyterLab 2.0

JupyterLab 2.0 is coming soon, and we can start upgrading to it:

switch to lumino
kernel refactoring: use of sessionContext

Link to the migration guide: https://jupyterlab.readthedocs.io/en/latest/developer/extension_migration.html


Create a Solar constants dataclass

In order to integrate SPLASH, the constants imported as global variables in the solar module of the feature branch in #69 need to be extracted into a pyrealm style configurable dataclass.
Suggested location:
pyrealm.core.solar_constants.py

To avoid creating multiple constants classes that need adding as arguments to classes and methods, this is better addressed by extending the CoreConsts introduced by #139.


Fix segmentation fault error

Looks good. Please update podspec version as well

@rnkyr Done. New version is 0.6


“Account Private”

I like to check my stats on Leafapp.co but it says my account settings are set to private. I checked with Halo infinite settings and they are public, as well as HaloWaypoint, but my statistics aren’t viewable. It seems it’s an issue with Leafapp not updating properly or verifying the settings.

Have a gamertag I can peek against?

We solved on Discord. Closing.


Minimum Version 15.3.3 Doesn't Work

I have a PowerShell script that installs various tools to ensure all developers have the same set of tools.  The script mostly uses Chocolatey and NPM, but for VS2017 I use vswhere.exe to check for a minimum version and prompt to install or update if needed.  I tried setting the minimum version to 15.3.3 when I had version 15.3.2 installed and it still found my installation (and therefore, my script did not prompt to install the update).  If I set the minimum required version to "15.4" then it finds no such version installed and my script prompts to run the installer (but then it will keep doing so because the latest available right now is 15.3.3).
Here's the relevant portion of my script:
$here = if ($PSScriptRoot) { $PSScriptRoot } else { "." }
$minRequiredVS2017Version = "15.3.3"
$vs2017path = &"$here\vswhere.exe" -latest -version "[$minRequiredVS2017Version,99.0)" -property installationPath

if (-not $vs2017path) {
    # Prompt to run VS2017 installer (and run it)
    exit
}

The build number of Visual Studio does not work like that. It's actually a date-based build number. The .3 is more of a branding version to indicate a servicing release.
While we can't really change this (there are far too many layers that depend on the real build version),  we could perhaps find a way to publish a table of how the versions relate

So, will vswhere.exe work correctly with the real build version?
I checked the about dialog and it just says that I now have 15.3.3, so I don't know what to try.  I've already installed 15.3.3, but I could try the real build version and then increment that by 1 to verify that it no longer finds it.

That dialog gets values from a different location that pertains only to branding. If you already have 15.3.3 and indeed require a fix/change in 15.3.3 or newer, run vswhere on your machine to find the installationVersion. For example, on one of my machines with 15.3.3 vswhere shows me "15.3.26730.12", so if you run the following command you will find 15.3.3 or newer.
vswhere -version 15.3.26730.12

Ok, thanks!  I should have realized that vswhere itself can tell me the actual version since I have already installed the "15.3.3" branded update on my own system.  It would be nice to have a table of VS versions in the readme.md for this repo for reference, but I have what I need for now, so I will close this issue.
Using a minimum required version of "15.3.26730.12" in my script finds my install and if I change it to "15.3.26730.13", then VS is not found and my script prompts that VS is out-of-date and it will run the installer.


compatibility to Magento <IP_ADDRESS>

Please document every experience regarding compatibility to latest magento CE <IP_ADDRESS>

Installed <IP_ADDRESS> a couple of days ago, no issues at all with PHP 7.0.2 that aren't fixed by this module.

Same here - no issues with <IP_ADDRESS> (and none were expected, frankly).


Provide defaultValue on input types in schema introspection

Resolves https://github.com/movio/bramble/issues/254

@andyyu2004 sure thing! Got it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.75%. Comparing base (27b4d1d) to head (37641c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   69.49%   69.75%   +0.25%
==========================================
  Files          28       28
  Lines        4213     4219       +6
==========================================
+ Hits         2928     2943      +15
+ Misses       1133     1124       -9
  Partials      152      152

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


"PSPath" alias in Diagnostics cmdlets

All cmdlets use "PSPath" alias for the "LiteralPath" parameter.
Only the following Diagnostics cmdlets use "PSPath" alias for the "Path" parameter and should be fixed:

Export-Counter
Get-Event
Import-Counter

(Also the cmdlet use "PSPath" alias (won't fix):

Join-Path (haven't "LiteralPath" so it is Okay)
Start-Process (haven't "LiteralPath" so it is Okay)
Send-MailMessage (haven't "LiteralPath" so it is Okay)
Update-Data (haven't "LiteralPath" so it is Okay)
Set-TraceSource (haven't "LiteralPath" so it is Okay)
Trace-Command (haven't "LiteralPath" so it is Okay)
Import-WorkFlow (haven't "LiteralPath" so it is Okay)
Invoke-Command (haven't "LiteralPath" so it is Okay)
)

Closed. Diagnostics cmdlets don't use LiteralPath.


Broken

Bot just keeping refreshing the shop page..

I have updated the bot today. It was because it is the first drop of the season so the bot wasn't stable.


number_format in various pages

Added number format to various places:
profile page for pvp/ai wins
ramen shop heal amount/prices
pvp

battle log

We had this convo a few times in chat, I think its aesthetically better without the number format in some places (like battle, bar #s) but there's definitely a subjective element to my preference.


StorybookAndMaterialUi

Added STORYBOOK_UI environment variable to select which Vulcan UI package to use when starting Storybook (instead of having to uncomment code)
Added storybook-material script in package.js to launch Storybook using the Material UI package
Modified build-storybook script to build Storybook stories for both Bootstrap and Material UI and save them to docs/storybook-bootstrap and docs/storybook-material respectively so that they can be published using GitHub Pages
Updated vulcan:ui-material, including the new TooltipButton component which replaces both TooltipIntl and TooltipIconButton

Thanks a lot, I am reviewing the PR.
Currently I stumble on this issue with Babel/core-js: https://github.com/coinbase/rest-hooks/issues/25

Awesome PR!
I have merged, my remarks are:

I removed the "docs" folder. I don't know if it's best to keep it or not but I am not fond of having autogenerated stuffs to be stored in the github. That would be preferable to push it to a github pages or something from time to time instead.
Being finnicky, we could try to avoid loading stories containing "material" when bootstrap is selected, by modifying the regex used in config.js. We could have special "bootstrap.stories.js" and "material.stories.js" files for this usage
I locked version to 5.0.x. Further versions of Storybook use<EMAIL_ADDRESS>and that's a HUGE mess with versions. I did not know core-js existed only a few weeks ago but it has been my nemesis lately, it breaks up every updates of every libs... We will have to avoid updating anything related to Babel for a while until it stabilizes

Otherwise the STORYBOOK_UI env variable with Bootstrap as a default is awesome

@eric-burel I am happy to collaborate with you - this stuff is not straight forward and two heads are better than one - though you did most of the heavy lifting. Thank you!

I removed the "docs" folder. I don't know if it's best to keep it or not but I am not fond of having autogenerated stuffs to be stored in the github. That would be preferable to push it to a github pages or something from time to time instead.

That makes sense. What we should be doing is adding a build step to CircleCI to build storybook and deploy it to GitHub Pages, or Netlify, so that we can link to life, functioning stories from the Vulcan Docs.

Being finnicky, we could try to avoid loading stories containing "material" when bootstrap is selected, by modifying the regex used in config.js. We could have special "bootstrap.stories.js" and "material.stories.js" files for this usage

You are right, but I would add a third regex pattern: "vulcan.stories.js", which would be build for both bootstrap and material. If fact the majority of the components should be common between the two and should function the same betweetween the two UIs - although they will look different. So for Bootstrap we would build anything that matches *.vulcan.stories.js and *.bootstrap.stories.js, and for Material UI we would build *.vulcan.stories.js and *.material.stories.js.
Again, thanks for your efforts in getting Storybook working with Meteor and Vulcan - very useful, especially once we can publish the stories somewhere online to enhance our Docs.

Thanks! Hopefully Sacha initiated this otherwise I was going to rewrite an offbrand Storybook directly in Vulcan instead on heading toward webpack lol


Testing, please ignore. (ogdegb)

This is a bug bounty test - please ignore.. Please DO NOT APPROVE THIS! (ogdegb)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ogdegb iyhes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


CRUD Field: slug

Checks the slugs table with AJAX to see if the slug is taken or not.

A simple text field will do, and sluggable will take care of the rest.
A more advanced version of this was added in https://github.com/tabacitu/crud/commit/47bc8b8a3215582a0ececaf65afa16cac17db987, named page_or_link, which allows to pick a page or type an internal link or external link. This one's used in MenuManager.


How to handled multiple files from the same output module within a job

Within the context of large output files, it might be beneficial to use the feature of cmssw to create multiple files of ~fixed size from each single job instead of making 20G*ncore single output file.
Is that functionality already in ?

I've played around with this in the Tier0 a long time ago but decided at the time it was not useful. As far as I remember mainly because you couldn't really control where it split, so you couldn't really treat these as separate files, they always had to be handled as a unit (if you cared about data integrity).
As such, this isn't really useful since our tools can't deal with multiple files that have to be treated as a unit in term of bookkeeping, processing, data management etc.

In other words, while the wmagent probably supports this more or less out of the box, you likely screw up data management in DBS and PhEDEx and subsequent processing that uses these files as input.


Error During CMake command Execution

I'm encountering an issue while installing MaEve, I'm encountering an error exactly while executing the "cmake .." .
It seems that cmake is unable to locate the everest-cmake package during the configuration phase.
Could you provide guidance on how to resolve this error? I'm not sure why cmake is unable to find the everest-cmake package, as I haven't explicitly installed it. I'd appreciate any help in resolving this issue and configuring my project correctly.

Hi @tefelberson , try to check out https://github.com/EVerest/everest-cmake in the same workspace where libocpp is checked out.

I installed it directly in the Libocpp directory present in the Everest folder and it works.


Missing sidebar RTL exception

I'm not quite sure if this is a bug or how it was intended, but I thought I'd point out that the comments in the sidebar composition include this line which doesn't have a matching exception:
EXCEPTIONS
.sidebar[data-direction='rtl']: flips the sidebar to be on the right

Is this intended to be a hint for how this could be used or is something actually missing?

Ah this is a carry-over from a project, so that comment just needs removing


Introduce Project perspective

The platform needs to be project focused, as in - the first thing that a user should see is the list of projects that the user is invited to work on or means to create a new project if the user is allowed to (only admin role can create new project):

The project may look similar to the below screenshot:

Project configuration view should enable CRUD for a model entry. Model entry should be described by the following fields:

name
description
nature (library or project)
derived editing nature (default is Git, T4C if T4C project and repo is linked)

Model configuration view should enable the following:

link/unlink T4C repository and project
add git repo (and set repo as primary)
if T4C is set -> configure sync from T4C to git (when, how, credentials)

Current state, the following steps are missing:

[ ] Make request session working
[ ] Create projects doesn't work for users without admin rights
[ ] Manage models (backups, linked sources)
[ ] Mange Dockerimages in settings (as Tools setting)
[ ] Add spinner for Git modelsource (settings)
[ ] Team4Capella model source integration
[ ] Guacamole credentials in database

Since this issue includes a complete new version, the issues will be tracked in smaller variants in the future. You can filter for the related issues with the label "version:v2": https://github.com/DSD-DBS/capella-collab-manager/labels/version%3Av2


Percentage of 304 responses heavily reduced after some commit

When I made https://github.com/RSS-Bridge/rss-bridge/pull/793 I created a gnuplot script that shows number of responses and number of 304 responses given by my rss-bridge instance.
Last results:
https://feed.eugenemolotov.ru/plots/2018-10-13.png
https://feed.eugenemolotov.ru/plots/2018-10-14.png
https://feed.eugenemolotov.ru/plots/2018-10-15.png
https://feed.eugenemolotov.ru/plots/2018-10-16.png
https://feed.eugenemolotov.ru/plots/2018-10-17.png
As you may attention, on Oct, 16, percentage of 304 responses reduced to approx 0% so fast. On 3:00 YEKT (same timezone in graphs) there was rss-bridge code update to latest master. So pretty sure something broke functionality with 304 responses.
grep-ed server logs: https://pastebin.com/8VxDZMc7

Thanks for reporting this issue!
I might have accidentally broken 304 responses in #841. The code is based an the code you added in #793 but heavily adjusted to work in index.php:
https://github.com/RSS-Bridge/rss-bridge/blob/9820ad5c0f4bc5c82608f03c5a54175fb574f19a/index.php#L228-L243
I remember changing this specific line (from #793):
https://github.com/RSS-Bridge/rss-bridge/blob/422c125d8e25b9ac5209580b1976fb5d75dab8f8/lib/BridgeAbstract.php#L311
Instead of parsing the cached time using gmdate we now parse the last modified time using strtotime:
https://github.com/RSS-Bridge/rss-bridge/blob/9820ad5c0f4bc5c82608f03c5a54175fb574f19a/index.php#L237
It seems to be working on my end, but maybe it is local specific? (or maybe I'm not doing it right :smile:)
Can you check if your original solution works better here?


updating action to node20 to address deprecation warning

this will address warnings like these

looks like someone else already started this effort


improve miner diagnostics handling

Currently we have the following:
https://github.com/NebraLtd/hm-diag/blob/262e7c76772a7d6269f70c151a8fcfab63dd852e/hw_diag/utilities/miner.py#L21-L25
This can be improved in a few ways:

MC
MD
MR

@shawaj I'm closing this one out as we are in the midst of refactoring this a fair bit.


Should I put gem dependencies in a .gemspec file?

I am having trouble using gems for file uploads (tried carrierwave and refile).  I noticed that the docs recommend gem dependencies for engines be placed in a .gemspec file, not a Gemfile. (source)
Not sure if this is related to my problems, but any reason why we are not doing this?

I didn't see the locations.gemspec file.  This was the source of my issues as I was putting the gem dependencies in the wrong place (i.e., the Gemfile)


Outdated vendor packages causing import issues

What did you do?
I am trying to import prometheus-operator into a project as a dependency using go dep.
dep ensure -add<EMAIL_ADDRESS>
What did you expect to see?
An imported library in my vendor path.
What did you see instead? Under which circumstances?
<EMAIL_ADDRESS>ensure Solve(): No versions of k8s.io/client-go met constraints:
	master: Could not introduce k8s.io/client-go@master due to multiple problematic subpackages:
	Subpackage k8s.io/client-go/pkg/api/v1 is missing. (Package is required by<EMAIL_ADDRESS>Subpackage k8s.io/client-go/pkg/api is missing. (Package is required by<EMAIL_ADDRESS>	v4.0.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint master from project .../namespace-operator.
	v4.0.0-beta.0: Could not introduce<EMAIL_ADDRESS>as it is not allowed by constraint master from project .../namespace-operator.
...

Environment
My current project already imports the master of k8s.io/client-go and related libraries. This is unfortunately at odds with the libraries prometheus-operator use since client-go has been refactored massively since then. For example nearly all logic in k8s.io/client-go/pkg has moved.
[[projects]]
  branch = "master"
  name = "k8s.io/api"
  packages = ["admissionregistration/v1alpha1","apps/v1beta1","apps/v1beta2","authentication/v1","authentication/v1beta1","authorization/v1","authorization/v1beta1","autoscaling/v1","autoscaling/v2beta1","batch/v1","batch/v1beta1","batch/v2alpha1","certificates/v1beta1","core/v1","extensions/v1beta1","networking/v1","policy/v1beta1","rbac/v1","rbac/v1alpha1","rbac/v1beta1","scheduling/v1alpha1","settings/v1alpha1","storage/v1","storage/v1beta1"]
  revision = "81aa34336d28aadc3a8e8da7dfd9258c5157e5e4"

[[projects]]
  branch = "master"
  name = "k8s.io/apiextensions-apiserver"
  packages = ["pkg/apis/apiextensions","pkg/apis/apiextensions/v1beta1","pkg/client/clientset/clientset","pkg/client/clientset/clientset/scheme","pkg/client/clientset/clientset/typed/apiextensions/v1beta1"]
  revision = "a5bbfd114a9b122acd741c61d88c84812375d9e1"

[[projects]]
  branch = "master"
  name = "k8s.io/apimachinery"
  packages = ["pkg/api/equality","pkg/api/errors","pkg/api/meta","pkg/api/resource","pkg/apis/meta/internalversion","pkg/apis/meta/v1","pkg/apis/meta/v1/unstructured","pkg/apis/meta/v1alpha1","pkg/conversion","pkg/conversion/queryparams","pkg/conversion/unstructured","pkg/fields","pkg/labels","pkg/runtime","pkg/runtime/schema","pkg/runtime/serializer","pkg/runtime/serializer/json","pkg/runtime/serializer/protobuf","pkg/runtime/serializer/recognizer","pkg/runtime/serializer/streaming","pkg/runtime/serializer/versioning","pkg/selection","pkg/types","pkg/util/cache","pkg/util/clock","pkg/util/diff","pkg/util/errors","pkg/util/framer","pkg/util/intstr","pkg/util/json","pkg/util/mergepatch","pkg/util/net","pkg/util/runtime","pkg/util/sets","pkg/util/strategicpatch","pkg/util/validation","pkg/util/validation/field","pkg/util/wait","pkg/util/yaml","pkg/version","pkg/watch","third_party/forked/golang/json","third_party/forked/golang/reflect"]
  revision = "3b05bbfa0a45413bfa184edbf9af617e277962fb"

[[projects]]
  branch = "master"
  name = "k8s.io/client-go"
  packages = ["discovery","dynamic","kubernetes","kubernetes/scheme","kubernetes/typed/admissionregistration/v1alpha1","kubernetes/typed/apps/v1beta1","kubernetes/typed/apps/v1beta2","kubernetes/typed/authentication/v1","kubernetes/typed/authentication/v1beta1","kubernetes/typed/authorization/v1","kubernetes/typed/authorization/v1beta1","kubernetes/typed/autoscaling/v1","kubernetes/typed/autoscaling/v2beta1","kubernetes/typed/batch/v1","kubernetes/typed/batch/v1beta1","kubernetes/typed/batch/v2alpha1","kubernetes/typed/certificates/v1beta1","kubernetes/typed/core/v1","kubernetes/typed/extensions/v1beta1","kubernetes/typed/networking/v1","kubernetes/typed/policy/v1beta1","kubernetes/typed/rbac/v1","kubernetes/typed/rbac/v1alpha1","kubernetes/typed/rbac/v1beta1","kubernetes/typed/scheduling/v1alpha1","kubernetes/typed/settings/v1alpha1","kubernetes/typed/storage/v1","kubernetes/typed/storage/v1beta1","pkg/version","rest","rest/watch","tools/auth","tools/cache","tools/clientcmd","tools/clientcmd/api","tools/clientcmd/api/latest","tools/clientcmd/api/v1","tools/metrics","tools/pager","tools/record","tools/reference","transport","util/cert","util/flowcontrol","util/homedir","util/integer"]
  revision = "82aa063804cf055e16e8911250f888bc216e8b61"

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.1", GitCommit:"f38e43b221d08850172a9a4ea785a86a3ffa3b3a", GitTreeState:"clean", BuildDate:"2017-10-12T00:45:05Z", GoVersion:"go1.9.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.1", GitCommit:"f38e43b221d08850172a9a4ea785a86a3ffa3b3a", GitTreeState:"clean", BuildDate:"2017-10-11T23:16:41Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
Minikube

Manifests:

NA

Prometheus Operator Logs:

NA

I have a couple of options here...

I can change my code to match the client-go used by prometheus-operator. This is less than ideal since it will eventually mandate we all move forward in code versions.

We update prometheus-operator to use master client-go. I'm not sure what the implications here are with using those versions, but I am will to help out.

Not use prometheus-operator as a library... I am trying to create a namespace-operator where the operator watches for a CRD object instance and generates a namespace plus all expected goodies as defined by an internal policy (RBAC policies, ResourceQuotas, Ceph Secrets, etc.) as well as a Prometheus instance. I am constructing these objects and creating them using the API. However, is there a way to create a Prometheus object dynamically using e.g. OpenAPI or Swagger that I am not aware of?

We can't update to client-go master, but we are planning on updating to client-go 5 as soon as there is a release for it. Apart from that, you should be able to just vendor the client package, that package should not have any transitive dependencies on the remaining packages, and if it does, then we need to fix that.

Closing this as it’s outdated. Feel free to re-open or open a new issue.


HDDS-8822. [S3G] Improve list performance in LEGACY/OBS bucket

What changes were proposed in this pull request?
[S3G] Improve list performance in LEGACY/OBS bucket when listing delimited by '/'
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8822
How was this patch tested?

Manual test

(1) LEGACY bucket list optimization
keys info:
hadoop fs -count ofs://om/s3v/buk-lg/*
           6        54712             109424 ofs://om/s3v/buk-lg/s3put
           1            1                238 ofs://om/s3v/buk-lg/test1
          61        30489              30489 ofs://om/s3v/buk-lg/test2
          21       100000             100000 ofs://om/s3v/buk-lg/test3

hadoop fs -count ofs://om/s3v/buk-lg/test3/*
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir0_47640
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir10_19047
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir11_99507
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir12_43926
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir13_98700
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir14_30007
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir15_32065
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir16_42162
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir17_71071
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir18_46050
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir19_86567
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir1_78108
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir2_53468
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir3_60271
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir4_41931
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir5_92207
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir6_93526
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir7_98836
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir8_71060
           1         5000               5000 ofs://om/s3v/buk-lg/test3/dir9_11147

time before and after optimization:
$ time aws s3api --endpoint http://<old-s3g-ip>:9878 list-objects-v2 --bucket buk-lg --prefix 't' --delimiter '/'
{
    "CommonPrefixes": [
        {
            "Prefix": "test1/"
        },
        {
            "Prefix": "test2/"
        },
        {
            "Prefix": "test3/"
        }
    ]
}

real	0m13.022s
user	0m0.952s
sys	0m0.161s

$ time aws s3api --endpoint http://<new-s3g-ip>:9878 list-objects-v2 --bucket buk-lg --prefix 't' --delimiter '/'
{
    "CommonPrefixes": [
        {
            "Prefix": "test1/"
        },
        {
            "Prefix": "test2/"
        },
        {
            "Prefix": "test3/"
        }
    ]
}

real	0m3.210s
user	0m0.969s
sys	0m0.169s

Detail data are shown in the following table:

time with prefix
t
test3/
''

before optimization
13.022s
10.381s
16.430s

after optimization
3.210s
3.134s
3.132s

(2) OBS bucket list optimization
keys info:
aws s3api --endpoint http://<s3g-ip>:9878 list-objects-v2 --bucket buk-obs --prefix 'obs1/obs2/obs3/' --max-keys 100000 | grep Key | wc -l
9986
aws s3api --endpoint http://<s3g-ip>:9878 list-objects-v2 --bucket buk-obs --prefix 'obs1/obs2/obs31/' --max-keys 100000 | grep Key | wc -l
10002
aws s3api --endpoint http://<s3g-ip>:9878 list-objects-v2 --bucket buk-obs --prefix 'obs1/obs2/obs311/' --max-keys 100000 | grep Key | wc -l
57549

time before and after optimization:
$ time aws s3 --endpoint http://<old-s3g-ip>:9878 ls buk-obs/obs1/obs2/obs3
                           PRE obs3/
                           PRE obs31/
                           PRE obs311/

real	0m9.165s
user	0m0.919s
sys	0m0.114s

$ time aws s3 --endpoint http://<new-s3g-ip>:9878 ls buk-obs/obs1/obs2/obs3
                           PRE obs3/
                           PRE obs31/
                           PRE obs311/

real	0m3.124s
user	0m0.927s
sys	0m0.159s

Detail data are shown in the following table:

time with prefix
obs1/obs2/obs3
obs1/obs2/
''

before optimization
9.165s
9.112s
9.045s

after optimization
3.124s
3.067s
3.014s

Note：reduce ozone.client.list.cache to simulate multiple calls to iterators

Related to https://github.com/apache/ozone/pull/4868

Sorry for the late follow-up. I added the test and method doc for listKeys, and also tested the s3 list for legacy and obs buckets in the test environment. @captainzmc   please help triger ci, thanks !

@whbing，Sorry for the late reply. CI has been triggered

@whbing，Sorry for the late reply. CI has been triggered

@captainzmc Thanks! I will add more test cases if needed  and improve some other boundary cases in the coming days.

@captainzmc Thanks for review. I added a param ozone-s3g.list-keys.shallow.enabled  to compare the efficiency before and after using this feature. The time taken for both the true and false settings corresponds with the initial description provided on this page.

Let's merge this, Thanks @whbing for the patch. And Thanks @ivandika3 @xichen01 for the review.


remove link and wright download required

https://covidstore.netlify.app/ doesn't work. requires download

lol, i don't use that. but yea for sure i will mention that @LinusSexTipsHub 👍


Update expected_win_probability to match math in glicko_update

Update expected_win_probability to Glicko-2 math, as if it were extracted from glicko_update. This is based on the assumption that the E in Glicko-2 still means "expected win probability".
Previously this function was using the math from Glicko-1.
Relates to #45.
Replaces #54. Note: the math domain error I thought #54 would fix does not go away with this commit. That has been fixed directly via #57.

Thanks!


Implement basic building placement

This resolves #10 by adding a way to retrieve the nearest possible BWAPI::TilePosition to the Player starting position

Closing due to using BWEM and BWEB libraries.


Warning: [react-router] Location "/D:/original/22-02-2017/job2.html" did not match any routes

I am working with typescript-with-react. And i m using webpack as a compiler . And my directory structure is as follows:
d:/original/22-02-2017/
-

and my entry point in web.config.js is ./src/index.tsx file.
my components placed inside src/components/demo.tsx

and my index.tsx file is as follows

and inside /job2.html i have following links

but when i am trying to run program it gives me following error
Warning: [react-router] Location "/D:/original/22-02-2017/job2.html" did not match any routes
and i am not using server port i am just running my app at
file:///D:/original/22-02-2017/job2.html
i have tried many  but not get succeed. please help me what is wrong with my code?

This is an issue tracker, not a support system. Please ask questions at StackOverflow.
When you include code in comments on GitHub, it should start and end with lines containing three backticks. When you include unformatted code, most people will just ignore your post.
If you include this text:
```
const x = () => { console.log('called x') }
```
it will be formatted as:

const x = () => { console.log('called x') }

The actual answer is that browserHistory does not work with static sites. You need to use hashHistory for that.

@pshrmn thank you for reply and how i can use it?


cublas verison

Hi,
It's a very interesting work. Thanks a lot for doing this!
Can I know what is the cublas version in this work (and probably the CUDA version as well)
Thanks,
Yuan

Hi @Yfeng-44 ,
Thank you for your interest in our work!
The cuBLAS and CUDA versions of this project are 10.2.
Best,
Taha

Hi @tekdogan ,
Thanks for replying. Could I know do you use CUDA 10.2 (and cublas) for GPGPUSim as well? in the log, there's 8.0 in the logfile.
Yuan

Hi @Yfeng-44 ,
Yes, we also used CUDA 10.2 (and cuBLAS) for GPGPUSim as well.
Actual experiments were run on a V100 with version 10.2. However, we also made earlier tests on Pascal, where we used version 8.0. Logs are probably heritage from the previous machine.
Best,
Taha

Hi @tekdogan ,
Thanks for your information, but I got cublass error when I run SAG with PubMed datasets on a fresh clone with the same setting (V100 GPU, CUDA  cuBLAS 10.1 and 10.2). It yields either CUBLAS_STATUS_NOT_INITIALIZED or CUBLAS_STATUS_EXECUTION_FAILED.
I've tried more than one machines. Is there anything I miss?
Thanks.
Yuan

Hi @Yfeng-44 ,
Yes, the topic has changed. Let's move on with the other issue.
Best,
Taha