Adding more interesting benchmarks

Issue Number

#1098
Overview

[x] I have added n=2,10,100 fixture wallet scenarios
[x] I have added n=10,20,100 transaction in a wallet scenario

Comments

Looking good. Perhaps we could move the statistics and results formatting functions up to the top-level.
I also pushed a commit on this branch to remove a fixme that I added which wasn't really a fixme.

now the following benchmarks are run :
Benchmark latency: RUNNING...
Latencies for 2 fixture wallets scenario
    listWallets         - 20.9 ms
    getWallet           - 9.7 ms
    getUTxOsStatistics  - 1.9 ms
    listAddresses       - 6.5 ms
    listTransactions    - 2.6 ms
    postTransactionFee  - 2.1 ms
    listStakePools      - 1.7 ms
    getNetworkInfo      - 0.2 ms
Latencies for 10 fixture wallets scenario
    listWallets         - 99.2 ms
    getWallet           - 9.8 ms
    getUTxOsStatistics  - 1.9 ms
    listAddresses       - 6.5 ms
    listTransactions    - 2.7 ms
    postTransactionFee  - 2.2 ms
    listStakePools      - 1.8 ms
    getNetworkInfo      - 0.2 ms
Latencies for 100 fixture wallets scenario
    listWallets         - 1337.2 ms
    getWallet           - 13.3 ms
    getUTxOsStatistics  - 2.4 ms
    listAddresses       - 9.9 ms
    listTransactions    - 4.5 ms
    postTransactionFee  - 2.6 ms
    listStakePools      - 3.1 ms
    getNetworkInfo      - 0.4 ms
Latencies for 2 fixture wallets with 10 txs scenario
    listWallets         - 21.5 ms
    getWallet           - 10.1 ms
    getUTxOsStatistics  - 2.3 ms
    listAddresses       - 7.8 ms
    listTransactions    - 5.9 ms
    postTransactionFee  - 2.5 ms
    listStakePools      - 1.6 ms
    getNetworkInfo      - 0.2 ms
Latencies for 2 fixture wallets with 20 txs scenario
    listWallets         - 21.6 ms
    getWallet           - 10.3 ms
    getUTxOsStatistics  - 2.3 ms
    listAddresses       - 8.2 ms
    listTransactions    - 7.6 ms
    postTransactionFee  - 2.6 ms
    listStakePools      - 1.6 ms
    getNetworkInfo      - 0.2 ms
Latencies for 2 fixture wallets with 100 txs scenario
    listWallets         - 23.1 ms
    getWallet           - 11.7 ms
    getUTxOsStatistics  - 3.4 ms
    listAddresses       - 12.9 ms
    listTransactions    - 18.2 ms
    postTransactionFee  - 3.6 ms
    listStakePools      - 2.0 ms
    getNetworkInfo      - 0.2 ms
Latencies for 10 fixture wallets with 10 txs scenario
    listWallets         - 98.9 ms
    getWallet           - 10.3 ms
    getUTxOsStatistics  - 2.2 ms
    listAddresses       - 8.0 ms
    listTransactions    - 6.3 ms
    postTransactionFee  - 2.5 ms
    listStakePools      - 1.9 ms
    getNetworkInfo      - 0.2 ms
Latencies for 10 fixture wallets with 20 txs scenario
    listWallets         - 97.8 ms
    getWallet           - 10.6 ms
    getUTxOsStatistics  - 2.4 ms
    listAddresses       - 8.4 ms
    listTransactions    - 8.1 ms
    postTransactionFee  - 2.7 ms
    listStakePools      - 1.9 ms
    getNetworkInfo      - 0.2 ms
Latencies for 10 fixture wallets with 100 txs scenario
    listWallets         - 102.4 ms
    getWallet           - 12.2 ms
    getUTxOsStatistics  - 3.6 ms
    listAddresses       - 13.2 ms
    listTransactions    - 20.3 ms
    postTransactionFee  - 3.8 ms
    listStakePools      - 2.1 ms
    getNetworkInfo      - 0.2 ms
Benchmark latency: FINISH

What about being a bit "harsher" on the fixtures and bench cases? You mentioned in the weekly this morning you wanted to also compare that with the database benchmark.
We are actually testing much more extreme cases in the db benchmark like:

benchmarking UTxO (Read)/1 CP x 100000 UTxO
benchmarking TxHistory (Read)/10000 [1..10000] DESC - 42..1337

10, 20, 100 for transactions seems pretty small to me ^^" .. What about pumping a bit those numbers to 10, 100, 1000, 10000 :) ?
In particular, for the listAddresses endpoint, we still do a lot of the filtering in-memory and, on large UTxO, I am expecting a huuuuge latency for this endpoint.
cc @paweljakubas @rvl

@rvl I plan to check this API endpoint benchmark results with corresponding ones for DB layer in next PR. Especially these cases :

20ms, 100m, 1350ms when listWallets is invoked (for 2, 10, 100 wallets, respectively)
getAddresses (8ms, 8ms, 13ms)/getTransactions (6ms, 8ms, 20ms) for a given wallet when it has history of 2, 20, 100 txs
First of all point 1 as it seems a lot at first glance.

bors r+


Clean up eval-launcher scripts

A lot of refactoring, some constants, and the same codepath for cross-run and same-run matches.

LGTM


Implement settings dialog UI ideas

I implemented several UI ideas which popped up recently (partly from https://github.com/godotengine/godot/issues/14380). I've changed the windows as follows (with before / after images). Feedback and discussion welcome.
Editor Settings

General tab: Removed search and section labels.

Shortcuts tab: Removed search and section labels.

Search box of each tab is automatically focussed and all text selected.
Bugfix: Changing the theme did not update the icon and tree colors.

Indifferent about removal of Search label. Fact is that the "Search Help" dialogues never had something like it, and I made it similar to them. On the other hand, the Project Settings dialog always has something like a label or button in front of the actual input box.
Property Editor

Made splitter between tree and properties draggable (HBoxContainer -> HSplitContainer). I just recently manually increased the width of the tree to fit some new section texts, but in other languages, this might not have been enough.

Project Settings

General tab: Remove section labels.

Input Map: Remove section labels and inline "toolbar" controls.

AutoLoad tab: Remove section labels and inline "toolbar" controls.

I think it looks great :) But I'd like @djrm's opinion too.

@RayKoopa AutoLoad: please switch path -> nodename to nodename -> path, just like it displayed in table. Constantly forgot to make a PR on this subject :)

You're right about that, even though the UI can automatically fill out name only after you selected a path.

looks nice.

Aww, merged without a chance on implementing @krakean's idea?


(CLOUD-406) Sql database server type

Closing as, although the type makes sense it's impossible to implement as-is with the classic API.


Many "is not a function" errors after first scroll, after which scrolling breaks.

Not sure what's happening, because this used to work, but Im suddenly getting a lot of console errors after the first "swipe" followed by scrolling breaking all together. Any ideas?
Uncaught TypeError: engine.scrollBody.useDefaultSpeed is not a function
    at wheelGestureEnded (commons.js:13946)
    at handleWheel (commons.js:13990)
    at commons.js:83454
    at Array.forEach (<anonymous>)
    at dispatch (commons.js:83453)
    at publishWheel (commons.js:83622)
    at end (commons.js:83846)
4commons.js:13946 Uncaught TypeError: engine.scrollBody.useDefaultSpeed is not a function
    at wheelGestureEnded (commons.js:13946)
    at handleWheel (commons.js:13990)
    at commons.js:83454
    at Array.forEach (<anonymous>)
    at dispatch (commons.js:83453)
    at publishWheel (commons.js:83622)
    at processWheelEventData (commons.js:83689)
    at HTMLDivElement.feedWheel (commons.js:83584)
commons.js:13946 Uncaught TypeError: engine.scrollBody.useDefaultSpeed is not a function
    at wheelGestureEnded (commons.js:13946)
    at handleWheel (commons.js:13990)
    at commons.js:83454
    at Array.forEach (<anonymous>)
    at dispatch (commons.js:83453)
    at publishWheel (commons.js:83622)
    at end (commons.js:83846)
3commons.js:13946 Uncaught TypeError: engine.scrollBody.useDefaultSpeed is not a function
    at wheelGestureEnded (commons.js:13946)
    at handleWheel (commons.js:13990)
    at commons.js:83454
    at Array.forEach (<anonymous>)
    at dispatch (commons.js:83453)
    at publishWheel (commons.js:83622)
    at processWheelEventData (commons.js:83689)
    at HTMLDivElement.feedWheel (commons.js:83584)

Hmm looks like embla team may have broken this: https://github.com/davidcetinkaya/embla-carousel/commit/4f38e7ee91d45718dfac170f6a40869a132ea3df#diff-bbb406ed0487e957fb0e631fc711042557f382619e305e48761bf38ecd625b8e

I fixed this by reverting to version 4.0.3 of embla, but you may want to update this package so Im going to leave this open.

@xiel and @bradley, I think this is caused by the internal useDefaultSpeed method being renamed to useBaseSpeed in version 4.0.6 of embla. This package needs to be updated accordingly.

@bradley thanks for the notice, will update this later tonight.

@xiel here's is the commit for reference. Thanks!

@xiel I can change the name back to useDefaultSpeed again if this is causing you a lot of headache?
Let me know if you think this is a better approach.
David

@davidcetinkaya the new name is fine for me :)
fixed and released with v1.0.6

Allright then @xiel, great work 🎉 !


Experiment with waking from low power mode

Figure out how to wake arduino from low power mode on pin going high.

Successful testing of interrupt handling on Arduino. Was not successful with waking the Arduino from sleep using an interrupt


Update SSL server secure defaults

This PR updates the cipher list used for SSL::Context to only include ciphers from the intermediate compatibility level of the Mozilla recommandedation (https://wiki.mozilla.org/Security/Server_Side_TLS).
Besides less ciphers, NO_TLS_V1 and NO_TLS_V1_1 are added to the default options.
It also integrates a script to automatically update these cipher definitions and a script to test it with testssl.sh.. Maybe those could also be integrated into the CI setup.
Fixes #9022

The testssl reports are available at https://gist.github.com/straight-shoota/d767dfa330e126519c4b60e27b656b58
With this change it looks pretty good 👍
During the ssl test the server however raises lots of SSL_accept errors that are not handled anywhere. They should probably be rescued and ignores / turned into Log.debug messages.

For OpenSSL 1.1.0 the recommended means to select supported versions is through set_min_proto_version instead of setting individual options.

More detailed info than provided by Mozilla's recommendation:
https://github.com/ssllabs/research/wiki/SSL-and-TLS-Deployment-Best-Practices

This is awesome!
How often do you think we should update the guidelines? Before each release?
Should we expose the guideline version in a constant? We could use it to check for updates later.

We could technically check for a new version of the recommendations on every nightly build 🤷
I suppose watching https://github.com/mozilla/server-side-tls for releases should be sufficient.

It's too bad Mozilla doesn't have a "semi-modern" recommendation requiring AEAD+PFS with TLS 1.2-TLS1.3.  All major browsers, etc. have supported AEAD+PFS for years already.

@x448 We could still consider adding such a configuration, even if Mozilla doesn't have it.

@x448 We could still consider adding such a configuration, even if Mozilla doesn't have it.

@straight-shoota that would be great!
Suggestions for "semi-modern":

Allow both TLS 1.2 and TLS 1.3
Ciphers must be AEAD+FS but avoid DHE (see list below.)
Client preferred order for ciphers (phones, etc. will move CHACHA20 to the front)
Server preferred order for named groups:
x25519, secp256r1, x448, secp384r1, secp521r1

CIPHERS_SEMIMODERN =
"TLS_AES_128_GCM_SHA256
 TLS_CHACHA20_POLY1305_SHA256
 TLS_AES_256_GCM_SHA384
 ECDHE-ECDSA-AES128-GCM-SHA256
 ECDHE-RSA-AES128-GCM-SHA256
 ECDHE-ECDSA-CHACHA20-POLY1305
 ECDHE-RSA-CHACHA20-POLY1305
 ECDHE-ECDSA-AES256-GCM-SHA384
 ECDHE-RSA-AES256-GCM-SHA384
 !RC4 !aNULL !eNULL !LOW !3DES !MD5 !EXP !PSK !SRP !DSS"

I moved CHACHA20 ahead of AES256 and removed DHE.  Looks like Firefox did the same!
Firefox ESR on linux-amd64

I'd prefer to discuss that in a separate issue. Let's focus here.

OK, deleted suggestion for semi-modern settings.  I misunderstood "@x448 We could still consider adding such a configuration, even if Mozilla doesn't have it." as invitation in this PR.
I think the inclusion of DHE cipher suites (instead of limiting to ECDHE) will lead to security issues.  It was one of the issues addressed by semi-modern settings.

Please remember this is only defaults, meant to support most clients, trying to keep breakages to a minimum. You can tweak the context to add/remove support for clients in your applications (be careful).
Using rules from an external authority —that knows much better than we do— allows us to provide acceptable defaults, but also meant to avoid arguments on security topics. What could be discussed (in a dedicated issue) is introducing the modern and legacy levels, in addition to the intermediate level.
Introducing a script to create the context automatically from these recommendations is very welcome :+1:

I opened #9060 which affects all TLS settings that allow DHE.


Width and height of heliostats or facets

Ambigous parameters
The heliostat_properties.json files from PAINT and the .binp files from Stral contain parameters for width and height of something. They are for example height": 2.559999942779541, "width": 3.2200000286102295. It seems like this is the height and width of an entire heliostat. However in the paint_to_surface_converter and in the stral_to_surface_converter those values are passed to every facet, making it seem like every facet has those width and height measurements.
To reproduce
Steps to reproduce the behavior:

Open example scenario.h5 files and look at the facet parameters.
Open heliostat_properties.json files and look at width and height.
Compare

Expected behavior
Either the heliostat_properties.json files should have more specific names like facet_width and facet_height or the paint_to_surface_converter and the stral_to_surface_converter need to be corrected.
Additional context
Neither width or height is ever used in ARTIST, so as of now its irrelevant. If it will never be used in the future as well we could delete those parameters.

width and height have been removed from facet


algorithm.run vs run_algorithm

Also, what is the difference between
QuantumAlgorithm.run()

and using
run_algorithm(algo_input,params)

I personally don't think and algorithm should be able to run with a method. I think it should contain be ran by passing an algorithm and a backend to run_program (see #153).

Yes @jaygambetta, those in my opinion are advanced notebooks where the person is taking control of the whole process and getting variational form instance, optimizer instance passing data etc instead of using a json dictionary. I guess to be able to comment on each step. I will talk to the guys about it.

Ok but then I think we need to make this clear that this is finner steps. There are a few of them I would need to look in detail but my first impression I got myself confused between the two operational ways.

As indicated run_algorithm is the entry point to Aqua for regular users of Aqua. Internally it runs an algorithm (QuantumAlgorithm) instance via methods that are overridden from the base class, such as run(). This is a public method as such for an algorithm developer. As a developer of Aqua algorithms you are exposed to these 'internals'. Since we want to encourage both regulars users of Aqua as well developers to augment the library we have notebooks showing both. Aqua can be used the latter way too though its more intended for developers or maybe advanced users that wish to experiment more with the internals.

It is not clear from the tutorials or the documentation when to use it. If it is to be public we need to make it clear when run gives an advantage over run_algorithm otherwise it looks like both work and you can just use either.


x4fp module should be declared as a select and not a climate.

Currently, the x4fp module creates a climate entity which is not the best in my point of view because it is not thermostat, just 6 running modes. As a consequence, the gui displays a thermostat without temperature setting point and current temperature.
It would more appropriate I think to create a select entity with 6 options which are the 6 modes available with fils pilotes. As a workaround an option could be added in the configuration file in order to choose between climate or select.
Thank you

hello,
climate entities in HA handle no temperature as many other integrations, so it's the right way to use it, as it manage global states among other things
you can use a template climate over it to include an external temperature sensor entity


[BUG] Error: Uncaught [Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of ForwardRef.]

Description
When I run yarn jest, I expected pass the test to happen but the above error happened instead.
This error happens in v4.9.0 or greater, but it doesn't happen in v4.8.0.
Do you have any ideas to solve this?
chakra-react-select Version
4.9.0
Link to Reproduction
https://codesandbox.io/p/devbox/yhhghw
TypeScript?

[X] Yes I use TypeScript

Steps to reproduce

Go to https://codesandbox.io/p/devbox/yhhghw
Click on New Terminal
type yarn jest and hit return key
See error

Operating System

[ ] macOS
[ ] Windows
[X] Linux
[ ] iOS/iPadOS
[ ] Android

Additional Information
No response

Facing the same issue here and it's also only happening in a test environment (coincidentally also using Jest). Our Jest currently doesn't support Pure ESM modules and it seems that version 4.9.0 switched this module to ESM only or at least made related changes to the package.json - see https://github.com/csandman/chakra-react-select/compare/v4.8.0...v4.9.1

I see, yeah v4.9.0/v4.9.1 updated the package to make ESM work properly, where as before that it was kind of "fake" ESM, but this package still has a CommonJS version. You can see more info about it in my PR description for 4.9.0. If this is causing the issue, it should be possible to force jest to get the CJS version of this package, but I'm not 100% sure of the proper way. I don't have a ton of experience getting Jest to look for the proper versions of files. It should
I'll try and see if I can find the right config change necessary to get this to work properly and get back to you.

Ok, so I ended up switching the "type" of the project back to the default of "commonjs", and this fixes the issue for me. If you install v4.9.2, let me know if the issue is fixed for you all!

@csandman I was able to upgrade successfully. Thank you for the quick fix!


Issue #7493 Move $rem-base before utils import

The $rem-base variable would never change to a custom value, since the default was being initialized prior to parsing the global overrides. Moving the variable directly before the utils import corrects this.
Now changing $global-font-size to a pixel based value such as 14px, as well as changing $rem-base: $global-font-size outputs a max-width: 85.71429rem

Hey @gakimball, we'll need to fix this on our end because the settings file is generated dynamically through octophant, correct?

@zurbrandon Yes, or maybe there's another way around it. I'll look into it.

Hey @ocularrhythm  We'll need to fix on our end since that file is generated on deploy. Thanks for the PR though.


move --urls and --tests into sub-commands

sub-commands, rather than flags due to how Marill will not continue to scan after these flags are passed.
Flags can be passed by reference to each sub-command since inheritance isn't a thing with the cli-package we're using.
Also, on this same note, app.Copyright should be properly set as well.

I'm wondering if this still can be accomplished with SkipFlagParsing..


TypeError right after install

I installed this project with npm install -g stacks-cli
When i run stacks-cli with https://github.com or any other Domain i get
TypeError: Object.values is not a function
at wappalyzer.analyze.then.json (~/.nvm/versions/node/v6.11.4/lib/node_modules/stacks-cli/bin/cli.js:155:50)

What is your nodejs version ?
Using : node --version

I'm using nvm (node version manager) and i installed it under node/v6.11.4
(Also node --version output is 6.11.4)

Try using nodejs 8/7, in 6.11.4 Object.values isnt supported
http://node.green/#ES2017-features-Object-static-methods-Object-values

Yeah. Like its shown in the prequires. Seems i can't read.. ;-) I'll close this.


Android: add host destination to the workspace

The Termux app sets the PREFIX environment variable with its root of /data/data/com.termux/files/usr, so read that and set the SDK path for Android.
Until now, I was simply hard-coding that path at compile time. This is the last patch needed to build SPM natively on Android.

@swift-ci please smoke test

Thanks for the quick turnaround.


Expose methods to eject documents from IDocumentSession

I don't think it should ever be necessary, but it is to some users so let's do it real quick.

This is already there. Not sure what the user was seeing now.


Nix: fix findlib warnings & completions in utop

Update opam-nix to fix some warnings.

It seems there's less of those warnings, but they're still there.
utop # #require "findlib: [WARNING] cannot read directory /nix/store/a1l4rqb0zp65s70km390y0ra36b53xjn-base-unix-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/l0dkmazx80zcnab5wjfbbi21hq061jvh-ocaml-config-2/lib/ocaml/4.14.0/site-lib: No such file or directory───────────────────┬──────────────────┬───────────────────────────┬───────────────────┐
findlib: [WARNING] cannot read directory /nix/store/lg6hdpkd8sl8mwlsdhhv8myhl1qbgv7d-ocaml-base-compiler-4.14.0/lib/ocaml/4.14.0/site-lib: No such file or directorye_async│async.log_extended│async.persistent_connection│async.unpack_sequen│
findlib: [WARNING] cannot read directory /nix/store/lg6hdpkd8sl8mwlsdhhv8myhl1qbgv7d-ocaml-base-compiler-4.14.0/lib/ocaml/4.14.0/site-lib: No such file or directory───────┴──────────────────┴───────────────────────────┴───────────────────┘
findlib: [WARNING] cannot read directory /nix/store/ll3phar66vqi89f048jrhaym6bwrlg0c-ocaml-4.14.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/mvrqj3lapw8c00sljjiplqdhj000v8nl-base-threads-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/aizwf3krhcjz1jad2y05adrbc8ja0lgd-base-bigarray-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/3yjv7h5ks7y8ma7rs1gcm2yycplrz4jp-conf-pkg-config-1.1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/43bj5iq61p6b944i5jw7lbwnsm4gnk2g-conf-libssl-2/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/dxxzfv6lm6y241xh8cqbklxfgrlvd0p2-base-bytes-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/qrkxlpwnwl407713nv7rsrzcqid89dfa-conf-perl-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/xh50h82251gyxdzx7vpsr9b2h6z0m1li-conf-gmp-2/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/7f92vwp174221ih8mqyymdxdjl1qbz63-conf-postgresql-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/55xjkac0dp28sl047vbifry29qpay70m-conf-g++-1.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/s7ml3gr1b9jkfvxlz7hpkf0fg272yc7n-conf-libffi-2.0.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/byn5ysbfalwljvlyhf1iwfz2sxnkyyfp-conf-m4-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/izj0lfli77gx0gzvzmswd4znsg1i7zw7-conf-openssl-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/cj6y5976653by9dfczd4mhy1xwsskci1-conf-which-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/c4gv5gib713n2a69bpphmjxxlhm69caf-ocaml-options-vanilla-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/vhdvnw7v14kpgf6m8cr3mhdp138pgji1-opam-depext-1.2.1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/a1l4rqb0zp65s70km390y0ra36b53xjn-base-unix-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/l0dkmazx80zcnab5wjfbbi21hq061jvh-ocaml-config-2/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/lg6hdpkd8sl8mwlsdhhv8myhl1qbgv7d-ocaml-base-compiler-4.14.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/lg6hdpkd8sl8mwlsdhhv8myhl1qbgv7d-ocaml-base-compiler-4.14.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/ll3phar66vqi89f048jrhaym6bwrlg0c-ocaml-4.14.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/mvrqj3lapw8c00sljjiplqdhj000v8nl-base-threads-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/aizwf3krhcjz1jad2y05adrbc8ja0lgd-base-bigarray-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/3yjv7h5ks7y8ma7rs1gcm2yycplrz4jp-conf-pkg-config-1.1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/43bj5iq61p6b944i5jw7lbwnsm4gnk2g-conf-libssl-2/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/dxxzfv6lm6y241xh8cqbklxfgrlvd0p2-base-bytes-base/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/qrkxlpwnwl407713nv7rsrzcqid89dfa-conf-perl-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/xh50h82251gyxdzx7vpsr9b2h6z0m1li-conf-gmp-2/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/7f92vwp174221ih8mqyymdxdjl1qbz63-conf-postgresql-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/55xjkac0dp28sl047vbifry29qpay70m-conf-g++-1.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/s7ml3gr1b9jkfvxlz7hpkf0fg272yc7n-conf-libffi-2.0.0/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/byn5ysbfalwljvlyhf1iwfz2sxnkyyfp-conf-m4-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/izj0lfli77gx0gzvzmswd4znsg1i7zw7-conf-openssl-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/cj6y5976653by9dfczd4mhy1xwsskci1-conf-which-1/lib/ocaml/4.14.0/site-lib: No such file or directory
findlib: [WARNING] cannot read directory /nix/store/c4gv5gib713n2a69bpphmjxxlhm69caf-ocaml-options-vanilla-1/lib/ocaml/4.14.0/site-lib: No such file or directory

After reloading direnv reload and rebuilding the environment it worked though. Thank you! :+1:


Communication

Hi,
The code runs fine in my python platform. Kindly could you let me know how to install it properly and run commands to the conex agap motor controller?
Thanks
Rajan

Hi @seb5g
I am trying to connect my Conex agap ag m100d, motorized mirror mount via python. I installed this package still, I am unable to construct the main function wherein I can command the mirror or establish communication with it. Kindly could you let me know how to do it or share an example of the file to send commands to the motor?
Thanks
Rajan

Well you have to install the driver from newport and let the daq_move module know where to look for the conex library default is:
conex_path='C:\\Program Files\\Newport\\Piezo Motion Control\\Newport CONEX-AGAP Applet\\Samples'
Then you should be able to use it with the DAQ_Move module interface

Hi @seb5g , thanks for the response! I have mentioned the path in DAQ_Move conex.
Where can I find the  DAQ_Move module interface?
Thanks
Rajan

https://pymodaq.cnrs.fr/en/latest/usage/How_to_start.html

Hi, I am running the python -m pymodaq.daq_move.daq_move_main from my venv.
Getting this error : QWindowsContext: OleInitialize() failed:  "COM error 0xffffffff80010106 RPC_E_CHANGED_MODE (Unknown error 0x080010106)"
Could you suggest something to fix?
Thanks
Rajan

seems so be an issue with Qt5 QWindows but difficult to say more. I usually start pymodaq from a dedicated conda env where python version can be tailored while venv use one installed python version...

Hi @seb5g , thanks for helping with this! I am running the form test with actuator Conex, getting the error: The parameter is incorrect. any suggestions regarding this?
Thanks
Rajan


Don't ask where to save when a file is opened

If I run smith file.rs, make some changes and hit Ctrl+s a prompt appears asking where to save to. Maybe there could be a separate shortcut for Save As, like Ctrl+Shift+S?

That's intended behavior. I'm trying to keep the few keybindings simple and essentially emulate the behavior of nano's ^O.
I'm certainly willing to add new keybinds if they make sense (a Ctrl+f would certainly be in scope), but not just to save one RET keystroke.

Fair enough

If there has to be one shortcut for saving, then in my opinion it shouldn't be save as. I've probably saved a million things in my life, but I've only used save as once or twice. As I see it Smith is a minimal editor, with a carefully selected set of features, that doesn't cover every edge case; and saving to another file is an edge case. If it ever occurs, all it takes is a cp.

We're veering into bike-shedding territory here, but I tried to give the idea a fair hearing.
So I've been taking a look back at some of the text editors that share the scope, and using the latest micro I've found that I quite like the ^S to save or prompt if we don't know the filename. It does break my flow a little less than nano when editing multiple files.
Ultimately the goal is to be unsurprising with the keybinds, and looking at the software I have around ^S is indeed usually an immediate save.
So I guess in the end I do agree with this change.


Inconsistent look of the login/signup pages

There should be an image containing a "wave" on the bottom of the page for both the login and the signup pages. If you have a screen that is large enough, you can see the tip of this "wave":

However, if you resize the window so the vertical vs horizontal ratio gets bigger on the vertical side, you'll get the following:

In this case, we can perfectly see the wave. I believe that this is inconsistent, and therefore a bug. The wave should always be shown.

I would change the title of this bug because it isnt inconsistency between both screens but a bug in the responsiveness of the wave.

Here how the Login looks on small screen:

Fixed in f8a0a74e9a55d066166f8a8769d7c93b84e4b61f

@cyntss that looks really cool, but maybe the placeholders should be white. We had a contribution recently that added a cross-platform mixin that change the placeholder color named input-placeholder. It's implemented in app/assets/stylesheets/mixins.scss

Really nice @cyntss! However I agree with @mssola about the placeholders

Sure no problem. I didnt like it white because it was too noticeable, but I also was expecting to receive this feedback haha.. so yes, i will change it now.


Make it possible for contributors who don't have a Nova license to run the site locally

https://twitter.com/stauffermatt/status/1279106042287271936

Might not be viable because of how it would affect composer.lock, trying to think of / figure out clever solutions

Previous title was "Move Nova into suggests and then update instructions to talk about bringing it back".. not sure if that's actually the best solution?

Wait.. this is a duplicate of #237? Geez. My brain.

OK, for now I'm just gonna do suggests for now. I had a plan to try out all the other suggestions, but I'm just gonna do this at the moment.

... and nevermind, because then all the packages that depend on it would fail. :sigh:

I just want to translate, no need for nova!
Do you have reasanable steps to go just for translations?

Nope. Honestly I don't yet.

This issue is fixed by #380. Closing.


Please update requirements for on-prem synced users and better written expressions for customers to follow

We need some updates to the wording in this article.  Specifically, the section located at :
https://learn.microsoft.com/en-us/azure/active-directory/authentication/concept-certificate-based-authentication-certificateuserids#update-certificate-user-ids-using-azure-ad-connect
It currently shows :
To update certificate user IDs for federated users, configure Azure AD Connect to sync userPrincipalName to certificateUserIds.
This needs to be updated to synced users from on-prem AD.  If a customer is using PHS/PTA they still need to follow these steps to sync a value into AAD for the certificateUserIds attribute.  I've had two customers not running federation try to follow this document and totally skipped the section on creating outbound sync rules since they didn't have federation.
This section is also very hard for customers to follow :
https://learn.microsoft.com/en-us/azure/active-directory/authentication/concept-certificate-based-authentication-certificateuserids#synchronize-x509pnprincipalnamevalue
To synchronize X509:RFC822Name, create an outbound synchronization rule, choose Expression in the flow type. Choose the target attribute as , and in the source field, add the expression <"X509:"&[userPrincipalName]>. If your source attribute isn't userPrincipalName, you can change the expression accordingly.
I've had a couple of customers try to create a rule that says :
<"X509:"&[userPrincipalName]>.
The "<" and ">" and "." are not valid for the rule and it's not clear for customers to understand the way it's currently written.  Can we change the webpage to put the rule inside of a box that allows them to copy the exact expression (like below in the webpage for other expressions)?  There's just poor consistency for how the various expressions are displayed in this article and not user friendly for customers to follow.
This expression also needs a copy box in the article :
https://learn.microsoft.com/en-us/azure/active-directory/authentication/concept-certificate-based-authentication-certificateuserids#synchronize-x509rfc822rfc822name

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 48633296-c827-8106-7d08-1c3a3f291ad2
Version Independent ID: 3aeae449-1617-16a0-51f8-ea7c55f3f467
Content: Certificate user IDs for Azure AD certificate-based authentication - Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/authentication/concept-certificate-based-authentication-certificateuserids.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@tomdan-MSFT
Thanks for your feedback! We will investigate and update as appropriate.

@tomdan-MSFT
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

@Justinha
Can you please check and add your comments on this doc update request as applicable.

Thanks for your feedback. We need to close all open issues at this time so we can migrate to a new Entra repository. I created a work item to have an expert review this feedback and update docs accordingly. #please-close


wrong routing when reloading page

When I have href="./" as the base my routing is not working as expected. If I refresh the page at localhost:5000/page/1 my "root" url will be "localhost:5000/page. When I removed the . everything works as I would expect.

Hi @Abrissirba I'll have a look at this, sorry I just scene the pull request now. Thanks a million. Will get back to you.  @FabianGosebrink Maybe if you have time?

Hey, I just merged. Thx @Abrissirba! Greets to Sweden :)


Enhancement Request: Output the buffer

Is it possible to also output the incoming buffer as part of the JSON output string? I need to do some follow-on image manipulation once I have the JSON info. For example, I want to crop the original image to just save the bounding box of the vehicle.
Optionally it would be nice to output the cropped vehicle image. This would be similar to what the current Stream SDK does.

Hi @jmorris644,
I see now that I have not described this on my readme page.  The input message is forwarded to the output.
Suppose your image buffer arrives in the input image as msg.payload and your recognition result is stored (via output field also in msg.payload.  Then your image in the message will be overwritten by your recognition results.  But if you store e.g. your recognition results in msg.myresults, then your msg.payload should still contain your original input image...
Bart

That makes perfect sense.

Optionally it would be nice to output the cropped vehicle image.

Yes indeed that can be useful.  But as a separate node, so it can be reused to crop the image output of other nodes also.  Will put it on my todo list...

I am currently using node-red-contrib-image-tools to do the cropping.


InitUnlockedBalance will be unlocked from the vesting balance instead of being extra balance

Summary
Currently, the behavior of the InitUnlockedBalance feature involves adding an extra unlocked balance to the locked accounts. However, there's a need to reconsider this approach and change it based on the made decision.
Problem Definition
To establish an unlocked balance of x amount for a vesting account, the procedure currently involves adding this amount to the account's balance within the bank module. While this approach is presently effective, we need to make adjustments in accordance with the final decision. Instead of adding an extra unlocked balance, we are considering unlocking a portion of the vesting balance to fulfill the same purpose.
Proposal
It is simple to do that.
Currently the functions that receive vesting account's details and generate a genesis version with its balances, have the following line of code to add extra unlocked amount:
balance = banktypes.Balance{
		Address: address,
		Coins:   initUnlockedCoins.Add(vestingBalance...),
	}

we need to change that code to the following:
balance = banktypes.Balance{
		Address: address,
		Coins:   vestingBalance,
	}
vestingBalance = vestingBalance.Sub(initUnlockedCoins...)

there are 3 functions that need to be modified:

NewGenesisDelayedVestingAccount
NewGenesisPeriodicVestingAccount
NewGenesisContinuousVestingAccount

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Sorry I don't understand the motivation or context around this issue. Also, the "made decision" link to Slack doesn't work for me. Can you please rephrase the Summary or Problem Definition?

Sure I will


WIP: wallet encrypt and decrypt with sync

There's a flow error you can hopefully fix up.
There seems to be an odd case when you have a synced wallet, then turn off sync, and then change the password. When you go back to turn it on, it will prompt for the old password and everything gets set back there. I'm thinking we ask to enable sync on the wallet encrypt page also.

Closing this to avoid clutter. Will re-open when we start on this again.


/stats improvements

Maybe make it also "responsive" so that we can modify the behavior of the Command like we want it to be.
This is not needed for the v1 Release!

unclear what i meant lol


*BSD: Add ioctls for BPF/network interface operations

Adds a few additional structs for BPF operations (bpf_version, bpf_stat, bpf_zbuf) as well as ioctl constants. Adds constants used for creating/manipulating network interfaces via ioctls.
Resolves #3626

Resolves #3626

@semarie you may want to put up a proposal at some point in rust-lang/rust to promote one of the OpenBSD targets to Tier2, not sure if that has been brought up before. This would let us start testing it in CI here.

@rustbot label stable-nominated

Looks like this has been approved by semarie, just needs to be merged @tgross35

This is labeled S-waiting-on-review so it is already in my queue. I am just trying to get the branch branches better in sync and fix some testing things before I merge more new features.

Here are all the applicable header files for this PR:
Header file for MacOS SIO* const definitions:
https://github.com/apple-open-source/macos/blob/47164d22c8d9bbf590e605d0a77fcae4fd35bea0/xnu/bsd/sys/sockio.h
Header file for MacOS BIO* const,  bpf_* struct definitions:
https://github.com/apple-open-source/macos/blob/47164d22c8d9bbf590e605d0a77fcae4fd35bea0/xnu/bsd/net/bpf.h#L170
Header file for MacOS RTA_*/RTAX_* definitions:
https://github.com/apple-open-source/macos/blob/47164d22c8d9bbf590e605d0a77fcae4fd35bea0/xnu/bsd/net/route.h#L238
Header file for MacOS SIO*_IN6 const definitions:
https://github.com/apple-open-source/macos/blob/47164d22c8d9bbf590e605d0a77fcae4fd35bea0/xnu/bsd/netinet6/in6_var.h#L588
Header file for MacOS u_int typedef:
https://github.com/apple-open-source/macos/blob/47164d22c8d9bbf590e605d0a77fcae4fd35bea0/xnu/bsd/sys/_types/_u_int.h#L28
Header file for DragonFly BIO* const, bpf_* struct definitions:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/83e7061fc08c2bcaeaaa75ad86aff4605a2904ea/sys/net/bpf.h#L104
Header file for DragonFly RTA_*/RTAX_* const definitions:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/83e7061fc08c2bcaeaaa75ad86aff4605a2904ea/sys/net/route.h#L277
Header file for DragonFly SIO* const definitions:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/83e7061fc08c2bcaeaaa75ad86aff4605a2904ea/sys/sys/sockio.h#L39
Header file for DragonFly SIO*_IN6 const definitions:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/83e7061fc08c2bcaeaaa75ad86aff4605a2904ea/sys/netinet6/in6_var.h#L406
Header file for FreeBSD BIO* const, bpf_* struct definitions:
https://github.com/freebsd/freebsd-src/blob/2b7f2890a812eb09dccaa8069483566a3b292338/sys/net/bpf.h#L120
Header file for FreeBSD RTA_*/RTAX_* const definitions:
https://github.com/freebsd/freebsd-src/blob/2b7f2890a812eb09dccaa8069483566a3b292338/sys/net/route.h#L318
Header file for FreeBSD SIO* const definitions:
https://github.com/freebsd/freebsd-src/blob/2b7f2890a812eb09dccaa8069483566a3b292338/sys/sys/sockio.h#L70
Header file for FreeBSD SIO*_IN6 const definitions:
https://github.com/openbsd/src/blob/202e2461a0d9a8e3abe70503423141a09ea1c4f4/sys/netinet6/in6_var.h#L272
Header file for OpenBSD BIO* const, bpf_* struct definitions:
https://github.com/openbsd/src/blob/202e2461a0d9a8e3abe70503423141a09ea1c4f4/sys/net/bpf.h#L114
Header file for OpenBSD RTA_*/RTAX_* const definitions:
https://github.com/openbsd/src/blob/202e2461a0d9a8e3abe70503423141a09ea1c4f4/sys/net/route.h#L310
Header file for OpenBSD SIO* const definitions:
https://github.com/openbsd/src/blob/202e2461a0d9a8e3abe70503423141a09ea1c4f4/sys/sys/sockio.h#L41
Header file for OpenBSD SIO*_IN6 const definitions:
https://github.com/openbsd/src/blob/202e2461a0d9a8e3abe70503423141a09ea1c4f4/sys/netinet6/in6_var.h#L272
Header file for NetBSD BIO* const, bpf_* struct definitions:
https://github.com/NetBSD/src/blob/c973030f42bbf6ada20cd8850b840349a4971a75/sys/net/bpf.h#L109
Header file for NetBSD RTA_*/RTAX_* const definitions:
https://github.com/NetBSD/src/blob/c973030f42bbf6ada20cd8850b840349a4971a75/sys/net/route.h#L325
Header files for NetBSD SIO* const definitions:
https://github.com/NetBSD/src/blob/c973030f42bbf6ada20cd8850b840349a4971a75/sys/sys/sockio.h#L128
Header files for NetBSD SIO*_IN6 const definitions:
https://github.com/NetBSD/src/blob/c973030f42bbf6ada20cd8850b840349a4971a75/sys/netinet6/in6_var.h#L383
Compiling these has made me realize I put a lot more into this PR than I initially thought (scope creep from adding MacOS-only definitions to including all BSD variants)--sorry about the premature ping! This should definitely take some time to review.

I've converted this to a draft as I discovered that different flavors of BSD have differing sizes for ifreq and similar structs. A portion of the value of ioctl codes are meant to convey the size of the struct they are passing, so those won't work. I found this out after setting up CI for OpenBSD/NetBSD/DragonFlyBSD on a Rust library I'm writing.
I'll eventually get around to adding the _IOC, _IOW and _IOWR macros as constant functions in this PR, and then defining the values of IOCTL keys based on that.

:umbrella: The latest upstream changes (presumably #3945) made this pull request unmergeable. Please resolve the merge conflicts.

I think this has some work left based on the above, or is there something specific needed from me?

I'll eventually get around to adding the _IOC, _IOW and _IOWR macros as constant functions in this PR, and then defining the values of IOCTL keys based on that.

We should get these with https://github.com/rust-lang/libc/pull/3865, assuming that lands in the near future.
@rustbot author


Integration Test - Release - 2022/05/24 11:21:57

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#please-close

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#unassign PRMergerTest1

#unassign NonAllowedUser


ADCInput missing?!

Hi Max,
im using this repo with PlatformIO. But anyhow it is missing the ADCInput.h that is found in Earle's core see here: https://github.com/earlephilhower/arduino-pico/tree/master/libraries/ADCInput
I get an include error and didn't find the corresponding header in the core's files:

Do you have any idea? Any help is very much appreciated because I'm currently depending on this to work...

Yes, the core reference is not always up to date since I want to make it compiles and works file when I update. Will be updated soon after I verify bluetooth examples from SDK 1.5 upgrade work.

That makes sense, thank you for your work by the way :)

Arduino-Pico was updated in 090343e4478f749da5347487ca42c231df75aab3.


Update typography and font tokens

Rename current font and typography token to fontspec and font respectively.

can I trouble to update the storybook documentation at http://localhost:6006/?path=/docs/foundations-typography-introduction--docs and http://localhost:6006/?path=/docs/foundations-typography-lifesg--docs ?


UI sometimes shows an incorrect "old" version of a table

Sometimes, when working on queries in a code studio, it's possible to wind up in a state where a UI panel is incorrectly pointing to an old version of a table that used the same variable name.
For example, in the screenshot below, if you look at t5 on the left (the old/bad version of t5) vs. the t5 on the right (the new/good version of t5), you can clearly see from the "ModTime2" column that they are actually different tables.

This is with Version 1.20230511.106 (29a6afd7).
Here is an easy way to reproduce this:

Run any simple query (e.g. t = db.i("DbInternal", "ProcessEventLog").where().sort("Timestamp"))
Click the button to show the table (e.g. the t button):
Run another query using the same table variable (e.g. t = db.i("DbInternal", "QueryPerformanceLog").where())
Now you have two different tables called t: . (The one on the left is wrong; it should have updated to show the QuryPerformanceLog.)
If you disconnect the code studio, the first panel (the wrong one) stays around, even with "Close tables on disconnect" checked:

One other detail — when this happens, the "old, broken" tab still hangs around after I restart my console session, even though I have "Close Panels on Disconnect" checked

I also have these warnings/errors in the browser:
LogProxy.js:87 Failed to apply filters: [Id == "9056cafb-8e02-4df4-bf0b-6be4582d8885"] Table was changed before request completed, this can be safely ignored.
isEnabled.console.error @ LogProxy.js:87
LogProxy.js:87 Failed to apply filters: [Id == "ce34460a4-c9b0-47e5-9073-8bcea167872d"] Table was changed before request completed, this can be safely ignored.
irisapi.nocache.js:56030 WebSocket is already in CLOSING or CLOSED state.
$lambda$1_17 @ irisapi.nocache.js:56030
irisapi.nocache.js:56030 WebSocket is already in CLOSING or CLOSED state.
$lambda$1_17 @ irisapi.nocache.js:56030
b9fab0f5-89de-488c-bfd1-1590c687b0bd:1 Uncaught (in promise) Table was changed before request completed, this can be safely ignored.

This also happens if you right-click a tab and select "Copy panel". In that case, the copy won't update when you redefine the table:


Update ot-sitemap-cli to adjust date in <lastmod> tag

After submitting sitemaps for our 21.06, Google notified me that the sitemaps have a date formatting error in the <lastmod> tag. This error does not prevent Google from indexing the site as it doesn't really consider the <lastmod> tag in its indexing algorithms.

According to the Google Search documentation, if a sitemap specifies a time in the <lastmod> tag, it must also specify a timezone. This appears to only be a requirement for Google as Bing does not require explicit mention of the time zone.
In the ot-sitemap-cli can we please adjust the code so that the <lastmod> tag does not include the time but only displays the W3C Datetime-compliant date? (e.g. 2005-02-21)

I'll take this @mbdebian: it's my mistake.

Perfect - thank you @JarrodBaker!
And no worries - it's just Google being very picky as other search engines accept the date as originally formatted 😂


Cleanup gateway vhost config gen

Fixes #12655

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: frankbu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frankbu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
22d5e3615689edd290b713f52223a0616b1ff6de
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
22d5e3615689edd290b713f52223a0616b1ff6de
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
22d5e3615689edd290b713f52223a0616b1ff6de
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
22d5e3615689edd290b713f52223a0616b1ff6de
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
a94471fe11ddf1885cedfabfec0d32b6a757bfa5
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a94471fe11ddf1885cedfabfec0d32b6a757bfa5
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
a94471fe11ddf1885cedfabfec0d32b6a757bfa5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
a94471fe11ddf1885cedfabfec0d32b6a757bfa5
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
7865c22488ed9ba6c1d41f40642c15003b9cc8c3
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
7865c22488ed9ba6c1d41f40642c15003b9cc8c3
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
7865c22488ed9ba6c1d41f40642c15003b9cc8c3
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7865c22488ed9ba6c1d41f40642c15003b9cc8c3
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram, I addressed your comments and added some unit tests. I also tested the vhost generation code by manually running the below config. It did turn up a couple of bugs, one with the Gateway host validator, and one with the intersection function returning "foo.com" twice, since it matched two of the gateway (overlapping) hosts. The result added the "foo.com" routes twice in the vhost, which would work but not so nice.
We should probably add the following test, or something similar, to the build tests, but I think that can be left for a future PR. PTAL.
# This config should produce the folloiwing vhosts in ingressgateway:
#
#  "blah.com:80"
#    "/blahNs2path"
#
#  "foo.com:80"
#    "/fooNs1path"
#    "/fooNs2path"
#    "/fooNs3path"
#    "/starNs4path"
#
#  "h1.host.com:80"
#    "/h1ns1path2"
#    "/h1ns1path1"
#
#  "h2.host.com:80"
#    "/h2ns1path"
#
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: test-gw
  namespace: default
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - "ns1/*"
    - "*/foo.com"
    - "ns2/blah.com"
    port:
      name: http
      number: 80
      protocol: HTTP
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v1
  namespace: ns1
spec:
  gateways:
  - default/test-gw
  hosts:
  - h1.host.com
  http:
  - match:
    - uri:
        exact: /h1ns1path1
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v2
  namespace: ns1
spec:
  gateways:
  - default/test-gw
  hosts:
  - h1.host.com
  http:
  - match:
    - uri:
        exact: /h1ns1path2
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v3
  namespace: ns1
spec:
  gateways:
  - default/test-gw
  hosts:
  - h2.host.com
  http:
  - match:
    - uri:
        exact: /h2ns1path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v4
  namespace: ns1
spec:
  gateways:
  - default/test-gw
  hosts:
  - foo.com
  http:
  - match:
    - uri:
        exact: /fooNs1path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v5
  namespace: ns2
spec:
  gateways:
  - default/test-gw
  hosts:
  - foo.com
  http:
  - match:
    - uri:
        exact: /fooNs2path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v6
  namespace: ns2
spec:
  gateways:
  - default/test-gw
  hosts:
  - h1.host.com
  http:
  - match:
    - uri:
        exact: /h1ns2path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v7
  namespace: ns2
spec:
  gateways:
  - default/test-gw
  hosts:
  - blah.com
  http:
  - match:
    - uri:
        exact: /blahNs2path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v8
  namespace: ns3
spec:
  gateways:
  - default/test-gw
  hosts:
  - h1.host.com
  http:
  - match:
    - uri:
        exact: /h1ns3path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v9
  namespace: ns3
spec:
  gateways:
  - default/test-gw
  hosts:
  - blah.com
  http:
  - match:
    - uri:
        exact: /blahNs3path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v10
  namespace: ns3
spec:
  gateways:
  - default/test-gw
  hosts:
  - foo.com
  http:
  - match:
    - uri:
        exact: /fooNs3path
    route:
    - destination:
        host: productpage
        port:
          number: 9080
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: v11
  namespace: ns4
spec:
  gateways:
  - default/test-gw
  hosts:
  - "*"
  http:
  - match:
    - uri:
        exact: /starNs4path
    route:
    - destination:
        host: productpage
        port:
          number: 9080

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
53ab249d8e665027b992c34996b6d56a89abc05c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-trustdomain.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTests

prow/e2e-simpleTests-minProfile.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-simpleTestsMinProfile

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-trustdomain.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-trustdomain

prow/e2e_pilotv2_auth_sds.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

/test e2e-simpleTestsMinProfile

@frankbu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-trustdomain.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test e2e-bookInfoTests-trustdomain

prow/e2e_pilotv2_auth_sds.sh
80122be52126a6ddeaae52f89c20210ff82e4f1b
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Pixie helm chart should allow you to set nodeSelector

Describe the bug
We currently have mixed clusters running both windows and linux, to facilitate this we make heavy use of the nodeSelector field in our deployments. Currently the Pixie helm chart does not support setting this field.
To Reproduce
Steps to reproduce the behavior:

Attempt to deploy pixie using the helm chart (we are using the nri-bundle chart through new relic)
Have windows nodes in your cluster
Get really confused for like 5 minutes about why it's not deploying to just a few nodes in your cluster and then face palm as you realize it's the windows nodes.

Expected behavior
Allow setting the nodeSelector field in the helm chart options so we can specify which nodes install pixie.
Logs
N/A
App information (please complete the following information):
N/A
Additional context
I consider this a bug as it prevents successful deployment of the software. In addition I see that others have put in requests for multi arch #248 and #250, which is another area where you would want to have the nodeSelector field.

Pixie now applies nodeAffinities by default to select for linux nodes. So if your cluster's nodes are labeled with kubernetes.io/os, this should be done automatically.
However, we also do allow you to specify node selectors now using our patches flag. These behavior similar to kubectl patch.
If deploying through helm, this will look something like:
--set patches.vizier-pem='\{\"spec\"\: \{\"template\"\: \{\"spec\"\: \{ \"nodeSelector\"\: \{\"pixie\"\: \"allowed\" \}\}\}\}\}'

Or, through the CLI:
px deploy --patches='vizier-pem:{\"spec\":{\"template\":{\"spec\":{\"nodeSelector\":{\"pixie\": \"allowed\"}}}}}'


Fix issue that lost some integer tags

@ascrutae Please open an issue to describe the bug, and link to this.

Coverage remained the same at 69.497% when pulling 6081f7f7b16bb616fc3df037b7f1a80ada357bd8 on ascrutae:zhangxin/fix/lost-int-tags into 0b4b4b17590d45c95f494964c8883947a0057574 on wu-sheng:master.

Relate: #247
Cause By: This tagWithInt variable  re-assigned value when it was not null. Here is the code


Issue #7160 Add styling for disabled attribute button

Add disabled attribute selector to include the disabled styling for buttons.

I guess this partly addresses #7387 and #7379:
Maybe the &[aria-disabled] should also be in the selector. @andycochran @davefuentes


Upgrade project-factory version so we can use 4.x provider versions.

The old version (11.1.1) did not allow provider versions 4.0 or higher.

/gcbrun


Proposal: Strongly typed .NET APIs to get Application resources

Would be handy to have methods to get strongly typed resource values on the Application (or on the ResourceDictionary) class:
public class Application:
{
     T GetResource<T>(string name) => (T)Resources[name];
}

Also, have methods to get a style, so we don't have to state the Style generic type:
Style GetStyleResource(string name) => GetResource<Style>(name);

Generate strongly typed properties from keys defined in the App.xaml
Ideally, similar to how the Resources class is generated from resx, it would be awesome to have strongly typed properties generated based on the keys in the App.xaml file:
public class CurrentApplicationResources {
      public Style MyButtonStyle {
          get {
               return Application.Current.Resources["MyButtonStyle"];
          }
      }
}

Note that XAML supports dynamic loading so this wouldn't quite work well. You can already have an x:Name on a resource if the dictionary is associated with a class. Adding a typed generic GenericResource method seems like a good idea however since the Windows Runtime doesn't support generics, could be exposed as an extension method through a .NET assembly. Similar can be done for C++ and (in future) Rust.

@Jaiganeshkumaran

Note that XAML supports dynamic loading so this wouldn't quite work well.

As I mentioned, I'm referring specifically to the App.xaml

@MikeHillberg FYI


Fallback for empty AccessToken

Fallback to extra fields provided if AccessToken is empty (case witt GCP IAP)
Fixes #480

@googlebot I signed it!

Commited through #483: https://github.com/google/cloudprober/commit/f40ed7edb0fe88142a55b0e968b623bb9a8be92b.
Thank you once again!


Remove None & NoneType from parameter types in docstrings.

Based on comment: https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2580#pullrequestreview-5178193
Uses this script:
https://gist.github.com/tswast/fa8bd1cbdf84e0777109d217c2271622
I manually adjusted whitespace to fix lint errors.

@dhermes Okay to merge? Travis looks happy.

@tswast Am I crazy:
$ git grep -l NoneType
bigquery/google/cloud/bigquery/client.py
bigquery/google/cloud/bigquery/dataset.py
bigquery/google/cloud/bigquery/job.py
bigquery/google/cloud/bigquery/query.py
bigquery/google/cloud/bigquery/table.py
bigtable/google/cloud/bigtable/client.py
bigtable/google/cloud/bigtable/column_family.py
bigtable/google/cloud/bigtable/table.py
core/google/cloud/_helpers.py
core/google/cloud/client.py
core/google/cloud/connection.py
datastore/google/cloud/datastore/client.py
datastore/google/cloud/datastore/key.py
datastore/google/cloud/datastore/query.py
dns/google/cloud/dns/changes.py
dns/google/cloud/dns/client.py
dns/google/cloud/dns/zone.py
error_reporting/google/cloud/error_reporting/client.py
logging/google/cloud/logging/client.py
logging/google/cloud/logging/logger.py
logging/google/cloud/logging/metric.py
logging/google/cloud/logging/sink.py
monitoring/google/cloud/monitoring/client.py
pubsub/google/cloud/pubsub/client.py
pubsub/google/cloud/pubsub/subscription.py
pubsub/google/cloud/pubsub/topic.py
resource_manager/google/cloud/resource_manager/client.py
resource_manager/google/cloud/resource_manager/project.py
scripts/rewrite_imports.py
speech/google/cloud/speech/client.py
storage/google/cloud/storage/_helpers.py
storage/google/cloud/storage/acl.py
storage/google/cloud/storage/blob.py
storage/google/cloud/storage/bucket.py
storage/google/cloud/storage/client.py
vision/google/cloud/vision/client.py
$ git log -1 --pretty=%H
1fab75689b56bc67d08e4726175b4a41a82fbef7

Not crazy, I noticed a few, too, since sending that PR. Most are :rtype: which I didn't remove (waiting until we decide how to document these) and some are where the NoneType spilled onto a second line from the parameter type.

Ouch, I see some lines like :type message: Protobuf message or :class:NoneType`` I'm somewhat surprise the script didn't catch these. Although, I guess this one is because the first type has a space in it.

No worries, at least we made it some of the way to the finish line?

Yeah 407 lines of progress. :-)


Extension error handling

Sometimes we run into issues iterating over extensions where certificates might not have been issued in adherence with basic constraints. Here we log these errors instead of failing outright.

Coverage decreased (-0.03%) to 65.966% when pulling 7e107f05ea6b9aede49fe3246c4ccd339003819e on kevgliss:extension-handling into 2b8c2f612ecfdfc74be43d09a29bf4a4e9539f41 on Netflix:master.


New translation for romanian language

More info here:
https://protonmail.com/blog/translation-project/
https://protonmail.com/blog/translation-instructions/


Theme doesn't setup

If you follow the setup instructions, running ./setup.sh fails with:
Error: Error building site: failed to render pages: render of "taxonomyTerm" failed: ".../mysite/themes/pico/layouts/taxonomy/list.html:21:38": execute of template failed: template: taxonomy/list.html:21:38: executing "main" at <$otherTags.Values>: can't evaluate field Values in type *maps.Scratch

It does work for me. Could you provide more information, such as the frontmatter of the markdown files used, your hugo version and node version

It does work for me. Could you provide more information, such as the frontmatter of the markdown files used, your hugo version and node version


Dunn County, WI

emailed:
<EMAIL_ADDRESS>

Hello;
Although not in shapefile format but geodatabase format, you can download a lot of local statewide data
from the Robinson Library at UW Madison This includes the address point layers from different years.
We do not provide this data as part of our land records sales program however.
Thank you
Steve.
Stephen J. Kochaver PLS
Land Information Officer
Dunn County Department of  Administration
Information Technology Division
V:<PHONE_NUMBER>

emailed back asking for data directly from county instead of going this route. I asked for parcels.

Hello;
So that data is collected through our Statewide GIS collection program and comes directly from each County, including ours.
This is also true for the parcel layers that are available through the Statewide website. So, I am saying that this data is as accurate as each county
prepares and submits to the state through this grant based program.
That being said, our County does offer the countywide parcel layer for sale, $20.00 using this webpage and selecting the
appropriate data you wish to receive. Our parcel layer can be delivered as a shapefile if that's the preference.
Thank you for your interest.
Steve

@ingalls will this work? I dont really like the fields here. I emailed back and asked for a city field to join to the data if possible. This would be a one and done shapefile grab for the time being. Let me know your thoughts. Thanks amigo!
Justin
dunn_county_wi_address_shapefile.zip


Added bash scripts install.sh and run.sh to install dependencies and then run the bot, respectively.

Short Description:
Included bash scripts to install dependencies, update submodule(s), and then run the bot. Additionally, a bug was fixed that broke the bot if 'release' or 'catch' keys were not found in config.json.
Fixes:

install.sh added to automate installing dependencies for the bot
run.sh added to easily run the bot with ./run.sh instead of the full python command
Bug was fixed that broke the bot if 'release' or 'catch' keys were not found in config.json

I made another pull request for these changes, disregard this please. Thank you!


Fixed the bug that cannot read the s3 directory tree

What is the purpose of the change
When using the S3 file system, it is impossible to correctly traverse directories. This PR fixes this bug and has been verified in our own environment.
Related issues/PRs
Related issues: #5052

[x] I have read the Contributing Guidelines on pull requests.
[x] I have explained the need for this PR and the problem it solves
[x] I have explained the changes or the new features added to this PR
[x] I have added tests corresponding to this change
[x] I have updated the documentation to reflect this change
[x] I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
[x] If this is a code change: I have written unit tests to fully verify the new behavior.

ping ~ @sjgllgh


Improve performance of businessCalendar's add()

Context
Similar to edgelaboratories/tarantino#674
This PR improves the performance of the function add.
Content
Modification to add to avoid looping and calling itself.
Benchmark added
How we know it works
Tests pass. No new test added
Benchmark results
Intro
I considered four shift values 17, -17, 7778 and -7778, referred to in the function names as xxx_17, xxx_m17, xxx_7778, xxx_m7778. The large values are irealistic and are used only for considerations of extremes.
Results
version in master
BenchmarkShiftBusinessDays_17-8         	87126721	        11.93 ns/op	       0 B/op	       0 allocs/op
BenchmarkShiftminusBusinessDays_m17-8   	127907304	        9.362 ns/op	       0 B/op	       0 allocs/op
BenchmarkShiftBusinessDays_7778-8       	99965977	        11.94 ns/op	       0 B/op	       0 allocs/op
BenchmarkShiftBusinessDays_m7778-8      	100000000	        11.71 ns/op	       0 B/op	       0 allocs/op

version in this branch
BenchmarkShiftBusinessDays_17-8         	196057020	         6.129 ns/op	       0 B/op	       0 allocs/op
BenchmarkShiftminusBusinessDays_m17-8   	196296846	         6.138 ns/op	       0 B/op	       0 allocs/op
BenchmarkShiftBusinessDays_7778-8       	197015299	         6.086 ns/op	       0 B/op	       0 allocs/op
BenchmarkShiftBusinessDays_m7778-8      	195863832	         6.120 ns/op	       0 B/op	       0 allocs/op

Discussion
The new version is slightly slower than tarantino's. I would assume this is because tarantino avoid using a date.Date. Also, the old version of calendar was not as bad as tarantino's old version. As a consequence, the improvement is not as extreme as observed in edgelaboratories/tarantino#674.

Here are the existing benchmarks :

Benchmark_Calendar_Add

On master :

On this branch :

Benchmark_Calendar_DaysBetween

On master :

On this branch :

@borisdavid thx for this :wink: Benchmark_calendar_add sets are quite consequential (similar gain to the ones added in this PR), but the others don't show any significant impact. That's because the DaysBetween function still uses a for loop. I guess we could apply the same change there as well - in this case I'd find reasonable to do it here, as it's the same concept

I reworked the function daysBetween by trying out some other way to compute businessDays (hopeful not too creative :sweat_smile:). The for-loops contained in this function were quite marginals (not leading to a linear complexity) so the improvement will be minor compared to the function add. Here is the new benchmark for daysBetween :

@borisdavid please leave an issue for @RemiMattheyDoret so that he can concile the benchmarks later on :+1: many thx for your contribution!


test: combo tests for getAllowedResourceTypesForOperation & getSearchFilterBasedOnIdentity

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I originally had 2 PRs but consolidated them. Ill reopen the other one