Fix issue parsing Image Details from API due to incorrect struct json field

Description

Issue is described here: https://github.com/cloudflare/cloudflare-go/issues/1378
API returns the metadata object under the field meta. However the SDK expects the field metadata thus it always drops this data from the response.
Has your change been tested?
Yes - after changing the struct field for Metadata to meta, GetImage calls return images with Metadata field populated.

Screenshots (if appropriate):
https://developers.cloudflare.com/api/operations/cloudflare-images-image-details
Refer to the response example of Image details. Specifically the meta field. The current SDK expects metadata and thus it always drops the metadata from the response.
Types of changes
What sort of change does your code introduce/modify?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

Codecov Report

Merging #1379 (12bd338) into master (b9ac804) will increase coverage by 0.00%.
Report is 203 commits behind head on master.
The diff coverage is 49.62%.

@@           Coverage Diff            @@
##           master    #1379    +/-   ##
========================================
  Coverage   48.33%   48.34%
========================================
  Files         133      139     +6
  Lines       13023    13749   +726
========================================
+ Hits         6295     6647   +352
- Misses       5201     5453   +252
- Partials     1527     1649   +122

Files Changed
Coverage Δ

access_audit_log.go
79.31% <ø> (ø)

access_bookmark.go
72.44% <ø> (ø)

access_keys.go
71.42% <ø> (ø)

access_organization.go
53.84% <ø> (ø)

access_service_tokens.go
51.85% <ø> (ø)

account_members.go
65.54% <ø> (ø)

account_roles.go
53.84% <ø> (ø)

accounts.go
50.81% <ø> (ø)

addressing_address_map.go
39.04% <ø> (ø)

addressing_ip_prefix.go
45.45% <ø> (ø)

... and 121 more

... and 1 file with indirect coverage changes


greeter: requires restarting cosmic-greeter-daemon to login

Hi,
These days, every time I start my Cosmic specialisation, I get a blank gray screen with a working cursor. This implies that cosmic-comp came up, but greeter failed to start up enough to even paint a (fallback) wallpaper.
If I switch to tty2, restart cosmic-greeter-daemon, switch back to tty1, the greeter loads and I can login.
I'm reporting this here, it may be one of these, or a combo. It seems others aren't easily reproing, maybe others will chime in with more thoughts/data:

We don't properly configure the greeter services to match upstream.
Something is wrong with how upstream prescribes running the greeter services.
There's simply a bug in greeter/greeter-daemon and I'm just getting unlucky?

(I did spot check upstream, this module, etc. Nothing... seems wrong?)

I can reproduce this consistently on the latest kernel (6.9) but not on LTS (6.6). My laptop doesn't work well with the LTS kernel so I'm also trying to root cause this, so far no luck.

@mbrea-c Just for the sake of gathering info, etc, can you provide details about your setup. For example, are you also on a dual-AMD gpu system?

Sure! I'm also on dual-amd, specifically on a framework 16 with the following specs:
    System: Ryzen™ 9 7940HS
    Storage: WD_BLACK™ SN850X NVMe™- M.2 2280 - 2TB
    Memory: DDR5-5600 - 32GB (2 x 16GB)
    Expansion Bay Module: Graphics Module (AMD Radeon™ RX 7700S)

Other than that, I'm on the latest kernel (6.9.x) and running a Btrfs filesystem.

I have a similar but bit different issue.
After login, return this error log without cursor and gray screen.
It happens about 80%.
2024-06-10T10:26:48.496437Z  INFO cosmic_session: Starting cosmic-session
2024-06-10T10:26:48.496933Z  INFO launch_pad: starting process ' COSMIC_SESSION_SOCK=12 cosmic-comp '
2024-06-10T10:26:49.159451Z ERROR launch_pad: process ' COSMIC_SESSION_SOCK=12 cosmic-comp ' failed with code 101
2024-06-10T10:26:49.159495Z ERROR cosmic_session::comp: cosmic-comp exited with error code 101
2024-06-10T10:26:49.159518Z  INFO launch_pad: draining stdin receiver before restarting process
2024-06-10T10:26:49.159559Z  INFO launch_pad: sleeping for 6ms before restarting process cosmic-comp (restart 0)
2024-06-10T10:26:49.167155Z  INFO launch_pad: restarted process ' COSMIC_SESSION_SOCK=12 cosmic-comp ' , now at 1 restarts
2024-06-10T10:26:49.167215Z  INFO launch_pad: process 'ProcessKey(1v1)' cancelled

And rarely more wired issue happens that returning this error and screen blinking again and again.
But IDK why, this only happens on my desktop but not on my laptop.
Both of them have almost same config(latest kernel, bcachefs and so on).
Desktop

intel 8700
nvidia 1660Ti with 555 open(issue happens at least 550)

Laptop

intel 155H

In my case this seems to be caused by greetd.service hitting its restart limit, this is the output of systemctl status greetd.daemon:

Can you grab a journalctl -b0 with maybe more context on the failure?

Here it is:
Jun 10 17:54:27 nixframe systemd[1]: Started greetd.service.
Jun 10 17:54:27 nixframe greetd[1299]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 10 17:54:27 nixframe greetd[1299]: gkr-pam: gnome-keyring-daemon started properly
Jun 10 17:54:27 nixframe greetd[1299]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 10 17:54:27 nixframe greetd[1296]: error: check_children: greeter exited without creating a session
Jun 10 17:54:27 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 10 17:54:27 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 1.
Jun 10 17:54:27 nixframe systemd[1]: Started greetd.service.
Jun 10 17:54:27 nixframe greetd[1379]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 10 17:54:27 nixframe greetd[1379]: gkr-pam: gnome-keyring-daemon started properly
Jun 10 17:54:27 nixframe greetd[1379]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 10 17:54:27 nixframe greetd[1378]: error: check_children: greeter exited without creating a session
Jun 10 17:54:27 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 10 17:54:28 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 2.
Jun 10 17:54:28 nixframe systemd[1]: Started greetd.service.
Jun 10 17:54:28 nixframe greetd[1430]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 10 17:54:28 nixframe greetd[1430]: gkr-pam: gnome-keyring-daemon started properly
Jun 10 17:54:28 nixframe greetd[1430]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 10 17:54:28 nixframe greetd[1429]: error: check_children: greeter exited without creating a session
Jun 10 17:54:28 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 10 17:54:28 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 3.
Jun 10 17:54:28 nixframe systemd[1]: Started greetd.service.
Jun 10 17:54:28 nixframe greetd[1484]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 10 17:54:28 nixframe greetd[1484]: gkr-pam: gnome-keyring-daemon started properly
Jun 10 17:54:28 nixframe greetd[1484]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 10 17:54:28 nixframe greetd[1483]: error: check_children: greeter exited without creating a session
Jun 10 17:54:28 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 10 17:54:29 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 4.
Jun 10 17:54:29 nixframe systemd[1]: Started greetd.service.
Jun 10 17:54:29 nixframe greetd[1525]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 10 17:54:29 nixframe greetd[1525]: gkr-pam: gnome-keyring-daemon started properly
Jun 10 17:54:29 nixframe greetd[1525]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 10 17:54:29 nixframe greetd[1524]: error: check_children: greeter exited without creating a session
Jun 10 17:54:29 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 10 17:54:29 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 5.
Jun 10 17:54:29 nixframe systemd[1]: greetd.service: Start request repeated too quickly.
Jun 10 17:54:29 nixframe systemd[1]: greetd.service: Failed with result 'start-limit-hit'.
Jun 10 17:54:29 nixframe systemd[1]: Failed to start greetd.service.

Small bit of additional info, I checked the logs again today and this time gkr-pam is throwing some error message:
Jun 11 18:21:20 nixframe systemd[1]: Started greetd.service.
Jun 11 18:21:20 nixframe greetd[1382]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 11 18:21:21 nixframe greetd[1382]: gkr-pam: gnome-keyring-daemon started properly
Jun 11 18:21:21 nixframe greetd[1382]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 11 18:21:21 nixframe greetd[1381]: error: check_children: greeter exited without creating a session
Jun 11 18:21:21 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 11 18:21:21 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 1.
Jun 11 18:21:21 nixframe systemd[1]: Started greetd.service.
Jun 11 18:21:21 nixframe greetd[1433]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 11 18:21:21 nixframe greetd[1433]: gkr-pam: couldn't unlock the login keyring.
Jun 11 18:21:21 nixframe greetd[1433]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 11 18:21:21 nixframe greetd[1432]: error: check_children: greeter exited without creating a session
Jun 11 18:21:21 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 11 18:21:21 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 2.
Jun 11 18:21:21 nixframe systemd[1]: Started greetd.service.
Jun 11 18:21:21 nixframe greetd[1475]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 11 18:21:21 nixframe greetd[1475]: gkr-pam: gnome-keyring-daemon started properly
Jun 11 18:21:22 nixframe greetd[1475]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 11 18:21:22 nixframe greetd[1474]: error: check_children: greeter exited without creating a session
Jun 11 18:21:22 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 11 18:21:22 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 3.
Jun 11 18:21:22 nixframe systemd[1]: Started greetd.service.
Jun 11 18:21:22 nixframe greetd[1509]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 11 18:21:22 nixframe greetd[1509]: gkr-pam: couldn't unlock the login keyring.
Jun 11 18:21:22 nixframe greetd[1509]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 11 18:21:22 nixframe greetd[1508]: error: check_children: greeter exited without creating a session
Jun 11 18:21:22 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 11 18:21:22 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 4.
Jun 11 18:21:22 nixframe systemd[1]: Started greetd.service.
Jun 11 18:21:22 nixframe greetd[1542]: pam_unix(greetd:session): session opened for user cosmic-greeter(uid=996) by (uid=0)
Jun 11 18:21:22 nixframe greetd[1542]: gkr-pam: gnome-keyring-daemon started properly
Jun 11 18:21:22 nixframe greetd[1542]: pam_unix(greetd:session): session closed for user cosmic-greeter
Jun 11 18:21:22 nixframe greetd[1541]: error: check_children: greeter exited without creating a session
Jun 11 18:21:22 nixframe systemd[1]: greetd.service: Deactivated successfully.
Jun 11 18:21:23 nixframe systemd[1]: greetd.service: Scheduled restart job, restart counter is at 5.
Jun 11 18:21:23 nixframe systemd[1]: greetd.service: Start request repeated too quickly.
Jun 11 18:21:23 nixframe systemd[1]: greetd.service: Failed with result 'start-limit-hit'.
Jun 11 18:21:23 nixframe systemd[1]: Failed to start greetd.service.

Can you try adding
  environment.variables.XDG_RUNTIME_DIR = "/run/user/$UID";
  security.pam.services.gdm.enableGnomeKeyring = true;

and see if that fixes the problem?

Can you try adding
  environment.variables.XDG_RUNTIME_DIR = "/run/user/$UID";
  security.pam.services.cosmic-greeter.enableGnomeKeyring = true;

and see if that fixes the problem?

It doesn't unfortunately, same error as before.

Edit: Switching back to 6.8 fixes my issues.

But this did fix it, and 6.8 is working perfectly on my machine so for now I'm calling this a win :)
Thanks!

@mbrea-c 6.9.4 fixes these issues for me. Can you check it again?

@addy419 I can still reproduce it in 6.9.4,

@addy419 Yep, both AMD CPU and GPU

    Laptop: Framework 16
    System: Ryzen™ 9 7940HS
    Storage: WD_BLACK™ SN850X NVMe™- M.2 2280 - 2TB
    Memory: DDR5-5600 - 32GB (2 x 16GB)
    Expansion Bay Module: Graphics Module (AMD Radeon™ RX 7700S)

Do you think it's related?

@mbrea-c Yes, kernel 6.9 introduced the new p-state drivers for amd cpus and all my amd systems have been super unstable since 6.9. 6.9.4 is definitely more stable since I don't see the issue for now, but I can't say for sure yet.
I'm using 7600X.

I have the same issue with the blank screen where cosmic greeter should display the login. I documented the error here: https://github.com/pop-os/cosmic-comp/issues/633. For me, it started a few weeks ago when they added the new KMS backend.
I am running the 6.8 kernel. AMD cpu. NVIDIA gpu.

Everything is working for me now
Sent from Proton Mail for iOS
On Tue, Aug 6, 2024 at 11:14 AM, quasigod @.***(mailto:On Tue, Aug 6, 2024 at 11:14 AM, quasigod < wrote:

Is this issue still occurring? I had this issue until the recent update, but it's working fine now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Closing since people have reported it working now. Feel free to reopen if you are still experiencing this

Hi all, I'm still experiencing this. Although, it only started again (as far as I remember) when I switched to stable from unstable. Does anyone use this flake with nixos stable?

One thing I noticed is that it consistently happens when I just played a game on steam. If I do a hard restart and try to suspend, it works fine. Not sure what Steam has to do with it (or maybe my AMD GPU, D3cold is disabled can that be the cause?)


GithubAPI Groovy Script conversion

In this PR I have converted the GithubAPI script into a Java class. I have reduced code and implemented better error handling.
API and implementation are separated and can be called via Singelton.
Overall, this PR should work simply because the classes and calls have the same names

Waiting for #3936 get merged

Tests needs be added


GPII-1335:  Add support for multiple template directories...

See GPII-1335 for details.

Closing in favor of:  https://github.com/GPII/gpii-handlebars/pull/15


Support toml markup for Platform struct

It would be very helpful to have toml markup for Platform struct in https://github.com/opencontainers/image-spec/blob/main/specs-go/v1/descriptor.go#L53 .
For example, we are trying to add an option of Platform type in containerd's config.toml and toml markup for this struct would be handy:
// Platform describes the platform which the image in the manifest runs on.
type Platform struct {
	// Architecture field specifies the CPU architecture, for example
	// `amd64` or `ppc64le`.
	Architecture string `toml:"architecture" json:"architecture"`

	// OS specifies the operating system, for example `linux` or `windows`.
	OS string `toml:"os" json:"os"`

	// OSVersion is an optional field specifying the operating system
	// version, for example on Windows `10.0.14393.1066`.
	OSVersion string `toml:"os_version" json:"os.version,omitempty"`

	// OSFeatures is an optional field specifying an array of strings,
	// each listing a required OS feature (for example on Windows `win32k`).
	OSFeatures []string `toml:"os_features" json:"os.features,omitempty"`

	// Variant is an optional field specifying a variant of the CPU, for
	// example `v7` to specify ARMv7 when architecture is `arm`.
	Variant string `toml:"variant" json:"variant,omitempty"`
}

Thoughts?

I worry that this might perhaps encourage other formats to also request inclusion in our tags here, and I'm not sure it makes sense to maintain all that here 😅  I think this is an unfortunate limitation of Go's struct tagging conventions 😞
Is there a way to convince toml to read the json tags, perhaps?

Both go-toml and encoding/json support encoding and decoding without tags if the markup name for a field is the same as the struct name

Not sure I understand this - "Both go-toml and encoding/json support encoding and decoding without tags if the markup name for a field is the same as the struct name" .
Does it mean we don't need explicit toml markups if we reference the struct members as is (case sensitive) from a go file?

Cleaning this up, see the discussion at https://github.com/opencontainers/image-spec/pull/1074#issuecomment-2115891422.


Support other data sources

These can be added without too much effort (all are supported by parquet-go-source):

GCS
Azure Blob
HTTP
HDFS
some others

GCS: https://github.com/hangxie/parquet-tools/pull/53

Azure blob: https://github.com/hangxie/parquet-tools/pull/56

Closing for now as all 3 major cloud storage are supported.


<EMAIL_ADDRESS>version not working with<EMAIL_ADDRESS>-- It was working till after noon 17Oct-2022

<EMAIL_ADDRESS>- Error: Module build failed (from ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js):
TypeError: Cannot create property 'message' on string<EMAIL_ADDRESS>This application depends upon a library published using Angular version 14.1.1, which requires Angular version 14.0.0 or newer to work correctly.
Consider upgrading your application to use a more recent version of Angular
Error: node_modules/@angular-architects/module-federation-tools/lib/web-components/web-component-wrapper.d.ts:25:18 - error TS2314: Generic type 'ɵɵComponentDeclaration' requires 7 type argument(s).
25     static ɵcmp: i0.ɵɵComponentDeclaration<WebComponentWrapper, "mft-wc-wrapper", never, { "options": "options"; "props": "props"; "events": "events"; }, {}, never, never, false>;

Use  "@angular-architects/module-federation": "~14.2.3", with angular 13.
Version 14.3 is for angular 14


Known built-in script limitations

Godot version
efd0db8
System information
W10
Issue description
Here's a list of known limitations of built-in scripts. It might not be complete, because built-in scripts have more issues, but the others I found seem fixable. If they turn out otherwise, I will add them here later.
We should make sure that the users know these limitations. My idea was to add a big tooltip/dialog in the script creation dialog when you click something, e.g. a button next to this warning:

The list is (including explanations and theoretical fixes):

Can't open built-in scripts in external editor. They are saved inside scene, so to edit them, you need to edit scene file.

It is possible to extract built-in script into temporary file and synchronize with the scene, but it's ultra hacky and overkill to implement.

Can't use class_name in bult-in scripts. Class names are registered as references to script files, so in this case the class would need to point to a resource inside scene. Even if it was possible, you'd need to load the whole scene each time you want to parse it.
Can't create script documentation for built-in scripts. Same reason as above. Docs are created based on script files.
Built-in scripts don't list in scene dependencies if they preload something. Again, same as above. The ResourceLoader will parse every external script referenced in the scene looking for preloads. But built-in scripts require parsing the scene itself.
Built-in scripts can't be extended nor preloaded. You can't do extends Scene.tscn::scriptid. Same reason as above. Parser doesn't recognize internal paths. Interestingly, using load() will work.

2, 3, 4 and 5 could be fixed if we had a way to partially parse a scene to load a built-in resource. For text scenes it might not be a problem, but binary scenes could be more problematic, idk. Also internal resource paths need to be recognized by the parser (right now it assumes actual file paths for extend, preload etc).
But even then, fixing 2 and 3 could cause performance issues, because every scene would need to be parsed in search of built-in scripts, so it's likely not feasible.

Only GDScripts and VisualScripts can be built-in. Not sure about GDNative, but C# requires actual script file to compile it. Maaybe it could use a fix similar to 1., i.e. save the script as temporary file and compile it, but it's not worth it, as other languages aren't supported by the script editor anyways.

Steps to reproduce

Create built-in script.

Minimal reproduction project
No response

Right, I should add it too. C# for example needs a script file to compile.

Search>Find In Files... inside Godot doesn't show results from built-in scripts.

Search>Find In Files... inside Godot doesn't show results from built-in scripts.

This is not a limitation. Built-in scripts are inside scenes, so you need to add tscn to search extensions in Project Settings.

https://github.com/godotengine/godot/issues/64213 also caused by a limitation of built-in scripts.

#64213 is a bug (and a duplicate).


code.google.com points to console.developers.google.com

I'm trying to install on a headless server, but I can't find what the documentation describes.
It says:
Click "Services" in the left-hand pane (will take you to https://code.google.com/apis/console/?pli=1#:services). Turn on the service "Drive API".
First of all, that code.google.com redirects to console.developers.google.com and there is no select API access thing to click on. Can you please update this documentation?

From the hamburger menu, you should select API Manager, then Library -> Drive API, then ENABLE. This link has some screenshots: http://www.iperiusbackup.net/en/how-to-enable-google-drive-api-and-get-client-credentials/

I figured it out;) Thanks.


Add domains selection under protein/gene

i.e., for Spike, this could be the n-terminal domain, or the RBD

Closed by #233


Get yaml header read only header

Changes
The get_yaml_header function used to read the whole file into memory (which is prohibitive for large files).
Now it only reads until the header is finished, e.g. the binary part of the ASDF file starts.
Optionally the function now returns the parsed YAML header as a dictionary.
Also added a test for allowed inputs and the new parse option.

this makes a lot of sense 👍
please update the CHANGELOG with the new option of returning a parsed dict

Thanks, I will update the changelog then.

this should be ready.

Hello @marscher! Thanks for updating this PR.

In the file scripts/welding_schema.py:

Line 304:1: W391 blank line at end of file

The tag information of the TaggedDict is private and so I guess is only meant to be used internally. But if we really want, we could use some day. Lets just leave it like this for now.

That's more precise, thank you!

The tag information of the TaggedDict is private and so I guess is only meant to be used internally. But if we really want, we could use some day. Lets just leave it like this for now.

yes I'm sure it will come in handy later


Fix collapsing of func param attribute

Currently the pretty printer does not add a break after a function parameter attribute, which will now be more common in SwiftUI due to the @ViewBuilder attribute. This results in the following behavior:
Before formatting:
func foo<Content: View>(@ViewBuilder bar: () -> View) {
      bar()
}

After formatting:
func foo<Content: View>(@ViewBuilderbar: () -> View) {
      bar()
}

This PR adds a break after the attribute's lastToken to ensure a space (or break) is maintained in this case.
Note: I've been unable to get the tests to run locally due to a SwiftSyntax parser incompatibility error, so I haven't been able to confirm this works as expected.

Note: I've been unable to get the tests to run locally due to a SwiftSyntax parser incompatibility error, so I haven't been able to confirm this works as expected.

You'll need the trunk development snapshot that matches the swift-syntax dependency in the branch you're developing on, so for master that's 09-26, but unfortunately it looks like that can't be downloaded from swift.org anymore 😕   So we'll need to move to a new version of swift-syntax, but that'll also involve some refactoring...
Another option would be to develop against swift-5.1-branch (which should work with a stock Xcode 11 release) and then patch your change back into master for the PR. I'll test it locally before merging.

Sounds good, will do momentarily!

Thanks again for the quick fix! Merging now.

Of course—thanks for the quick review and merge!


RET-4097

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/RET-4097

Change description
Case Flags - Upgrade to v2.1

Checklist

[X] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

Closing as long standing PR


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit 736aaa3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch eecb387e-6e9b-41c1-9a6f-8e05e6a15b4d has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


i.e., a.m., p.m., e.g., et cetera

Initialisms, when separated by "." are threaded as separate words, which make them harder to understand (e.g.: e.g.  becomes e. g. ;-) ).
Another use case are Initialisms that are not separated with dots but written all uppercase (e.g.: BTW ). Those are also harder to understand as they represent multiple words and you have to transcode them first.
Proposal: identify both patterns, display them as a single word, but increase the delay before the next word shows up.

fyi possible oartial resolution in thread auto-reffed above.


Fix arm64 FPU deadlock

[RFC] As discussed in #58056, this PR fixed arm64 FPU deadlock but is really a workaround. Expecting a better way to fix the issue
Using FPU with FPU sharing in a spin-locked critical section might cause a 'deadlock'. When core 0 got a spinlock that other cores are waiting for, it will 'deadlock' if the core 0 current threads' FPU context is living in another one that is waiting for the spinlock but never receives the FPU IPI.
The issue is found in the test case tests/lib/p4workq/ test_stress with SMP on the arm FVP platform
threads use spinlock to sync, core 0 got a spinlock, other cores (say core 1,2,3) are waiting in cas loop (spinlock, with IRQ disabled). The test case on core 0 goes into the spin-locked section and calls the assert which will access FPU registers thus causing an FPU trap. Then it finds out the current thread's FPU context is living in core 1. So core 0 raises IPI to inform core 1 to save the FPU context. But core 1 is in spinlock with IRQ disabled, so deadlock happens.
CC @npitre @carlocaione

Please have a look at PR #58086 which I think is a better solution.

What's the actual lock being contended?  It's worth pointing out that arch_switch(), called for cooperative context switches, does not actually hold the scheduler lock (though it does enter the function with interrupts masked).   With care, you might be able to unmask them around the "request foreign FPU flush" code and break the deadlock.
And my guess is that you're probably not deadlocking between interrupt handling, because if you were the IPI mechanism might not be reliable anyway?  (Not sure what the IPI priority is on arm64, but I doubt it's always going to preempt).

Close this, since https://github.com/zephyrproject-rtos/zephyr/pull/58086 will benefit all architectures


WebSocket does not have support for extensions

The WebSocket class does not have support for extensions. Which is part of the rfc6455 standard:
https://tools.ietf.org/html/rfc6455#section-9
It should read the Sec-WebSocket-Extensions HTTP header from the client.
The WebSocket class does not expose a Extensions property.

Depends on upstream support in System.Net.WebSockets.
Depends on issue dotnet/corefx#11874.

Did you have any specific extensions you want to use?

No, this exposes to the server the extension(s) that the client requests.
Then the server have to negotiate with the client and send back which extensions it supports.
Then any extension has to be implemented by the client and the server on top of this which only exposes the requested extension.

Note this hasn't been done yet because there has been little interest expressed for any websocket extensions. We're unlikely to add the the property if we don't think it will actually get used.


Include route information when user hovers on the generated doc

Clear and concise description of the problem
When user hovers on some element in the generated doc, he can see the route information about how the element is generated from typespec.
We would need compiler and emitter support to provide the route information to show in ide. @allenjzhang will provide more detail about this feature and design.
Checklist

[x] Follow our Code of Conduct
[x] Read the docs.
[x] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Duo of https://github.com/microsoft/typespec/issues/1993
This needs design in the compiler library api

Per https://github.com/microsoft/typespec/issues/1993, more accurately, it is an ask of including the effective full HTTP route when hovering over an operation.

@timotheeguerin , @allenjzhang , the #1993 is like more than one year ago. Do we have more update/design discussion on it recently?
And in my opinion, the feature request here is very specific for HTTP route though we want to have a general solution for it. But if we think about the request more generally. I think what our customers want is to be able to view the typespec and the final outcome together in some way easily. Then how about solving this request by support side-by-side preview? so instead of hovering, when user selects an element, he can view the output on the right clearly and easily which would cover either the route info or anything else he's interested? I think in this way

our customer can view route info or any other related info easily side-by-side. And I believe this would further benefit more customers in much broader user scenarios.
our emitter only needs to generate mapping file (one time effort); they don't need to keep making change and adding info into hover when there are more stuffs user wants to view
our compiler is clean.
of course, the side-by-side preview would need support of mapping file which may need some cost. I am not sure. But to be honest, I think we will need to support side-by-side preview sooner or later anyway.
So let me know how you think about it. Or maybe PM can also help to validate which feature our customers would prefer. thanks.

If we can get the side by side preview of input to output(again needs to be generic to workin the IDE, cannot make any assumption that they want openapi3) then that also would be pretty awesome but I think that is a lot more work.
For the design we don't have anything finalized. What I was thinking is providing the following a library could define
export const $hooks = defineHooks({
  // This would get called by the lsp when hovering a type for example
   info: (type: Type) => {
    return // some estabnlished structured info information that the lsp in turn can display
  },

  // This is for library/emtiter author to help in the playground(Though we could maybe integrate in lsp too)
  inspect(type: Type) => {
    return {
      pagingInfo: () => ... // return paging info data by calling paging info helper
   }
  }

})

yeah, I guess that would have higher cost. Just think if the side-by-side preview feature can meet our customers' needs (also more general and benefit in my opinion) and we need to do it anyway sooner or later, then maybe we can save the cost for this one and make it in one step.
About the design you shared. I am not quite sure I understand it correctly. Do you mean lsp would need to iterate each emitters/lib in the project and then call info() on each to get things to show for hovering? Then how would the emitters/lib get these info without compiling? I think these information needs to be figured out when compiling (or emitting) isn't it? And would it cause some perf issue if we call it separated for each emitter/lib, like compilation is triggered (somehow) multiple times?
and some other idea, how about handle it like the diagnostics as the output of compile? (it's kind-of some information helping diagnostic from some point of view, right? :) ) for example, when compiling, emitters can report these info as typespec_diagnostics (or some better name), then IDE can retrieve all these typespec_diagnostics in one compilation and then somehow parse and show them as contracted (i.e. somehow figured out it's linked with some Type)


Facter 4 compatibilty

Since Facter 4 was released, it appears the selinux_python_command.rb fact has started to fail when rpm is not present. This happens when running tests on a non-Red Hat OS where rpm is not present:

Error while resolving custom fact fact='selinux_python_command', resolution='': Could not execute 'rpm -q python3-libsemanage'

It looks like Facter::Core::Execution.execute now raises an exception when the command fails where previously it didn't.

Looks like this was also an issue in early Facter 2: https://tickets.puppetlabs.com/browse/FACT-409

ping @IrimieBogdan

Are you certain that the confine statement is working?  Seems like the exec statement shouldn't be evaluated at all on non-RedHat nodes although you would also run into issues on a RedHat based OS where rpm is not available.

Note that this is in CI, which is always a bit different. I suspect the RH facts are loaded on an Ubuntu machine. That might mess up things.

@ekohl thanks for the info, in the next release of Facter 4 (probably tomorrow) this will be fixed. Facter::Core::Execution.execute will no longer throw exception and will log a message if it failed to execute command.

Great to hear. I'll revert https://github.com/theforeman/puppet-pulpcore/commit/011f84bcaab7b07440a763f39ecdf643f70cda76 to verify it's been fixed.

@ekohl We have identified the problem, when running Facter 4 in a gem context, the exit code should be 0, even if there were errors. There is an experimental fix, but it will not get in today's release. You can expect the fix to get in early next week.

Thanks for the update! https://github.com/theforeman/puppet-pulpcore/pull/83 should test that branch.

It looks like that passes, but still outputs the error. Now that makes me wonder: were custom facts always executed in CI?

@ekohl a new release of Facter 4 is out https://rubygems.org/gems/facter/versions/4.0.13 Please give it a try.

Closing due to the new facter version.


A surprise video from me will come soon.

What will it be?
You guess you guess you guess 你猜你猜你猜!!! 🤔🤔🤔🤔🤔
You will only know in Week 12 or Week 13.
Clues:

Toilet
No lecturing

2 hour video of "Intro to Java Programming".

no
clue: toilet paper
Get Outlook for iOShttps://aka.ms/o0ukef

From: Austin Kong @.>
Sent: Tuesday, March 26, 2024 4:21:17 PM
To: nus-cs2030/2324-s2 @.>
Cc: Zhang Hao Dong @.>; Author @.>
Subject: Re: [nus-cs2030/2324-s2] A surprise video from me will come soon. (Issue #350)
2 hour video of "Intro to Java Programming".
—
Reply to this email directly, view it on GitHubhttps://github.com/nus-cs2030/2324-s2/issues/350#issuecomment-2019794974, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBRJ5GV6XECP5YCAHAMHIHLY2EVX3AVCNFSM6AAAAABFHF3ILGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZG44TIOJXGQ.
You are receiving this because you authored the thread.Message ID: @.***>

How Henry's ideology of toilet paper in one of his lectures helps other students taking this course

No
Get Outlook for iOShttps://aka.ms/o0ukef

From: kaiju10 @.>
Sent: Tuesday, March 26, 2024 4:27:36 PM
To: nus-cs2030/2324-s2 @.>
Cc: Zhang Hao Dong @.>; Author @.>
Subject: Re: [nus-cs2030/2324-s2] A surprise video from me will come soon. (Issue #350)
How Henry's ideology of toilet paper in one of his lectures helps other students taking this course
—
Reply to this email directly, view it on GitHubhttps://github.com/nus-cs2030/2324-s2/issues/350#issuecomment-2019806687, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBRJ5GQDB6DH3WIBUVBQSUDY2EWPRAVCNFSM6AAAAABFHF3ILGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZHAYDMNRYG4.
You are receiving this because you authored the thread.Message ID: @.***>

How toilet paper will help me do functional programming

Nvm.
Guess guess guess!!!
Get Outlook for iOShttps://aka.ms/o0ukef

From: LimJiaWeng @.>
Sent: Tuesday, March 26, 2024 9:18:07 PM
To: nus-cs2030/2324-s2 @.>
Cc: Zhang Hao Dong @.>; Author @.>
Subject: Re: [nus-cs2030/2324-s2] A surprise video from me will come soon. (Issue #350)
How toilet paper will help me do functional programming
—
Reply to this email directly, view it on GitHubhttps://github.com/nus-cs2030/2324-s2/issues/350#issuecomment-2020408625, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBRJ5GTPZR44SYLGIMKGYADY2FYQ7AVCNFSM6AAAAABFHF3ILGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGQYDQNRSGU.
You are receiving this because you authored the thread.Message ID: @.***>

Keep the guesses coming!


TODO url_helper needs fixing

Helpers/url_helper::url_title has a todo note...
Remove old 'dash' and 'underscore' usage in 3.1+.

This looks to be complete. In looking at the current code, you can't pass the strings 'dash' or 'underscore' to mean '-' or '_'.


Activate .NET code analysis

Taken from the open BaGet PR https://github.com/loic-sharma/BaGet/pull/784

According to the build workflow, there is still one issue left:

Maybe you can integrate 2 more changes from PR #46 (then #46 is superfluous and can be closed)

in src/BaGetter.Core/Entities/Converters/StringArrayToJsonConverter.cs: line 14 v => (!string.IsNullOrEmpty(v)) ? JsonConvert.DeserializeObject<string[]>(v) : Array.Empty<string>())
in tests/BaGetter.Tests/HostIntegrationTests.cs: line 65 .CreateHostBuilder(Array.Empty<string>())

@Regenhardt Can you merge?


Remove version: ChilliBits.Spice version 0.18.3

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/spicelang/spice/releases/download/0.18.3/spice_x64_setup.msi
Status Code: 200
(Automated message - build 857)


Auto format source code with black

@jorgefandinno I would go for this version based on your second proposal. I had a look at the one using pre-commit but did not like it because pre-commit just clones repositories but does not install any dependencies. The latter would be the most useful aspect.

Do you need to pass ${{ secrets.PAT_POTASSCO_BOT }} to checkout?
This prevents CI to work on forks.

@jorgefandinno, no clue where your comment went. It is indeed a problem that the action won't run for collaborators. That's what this is all about after all. Without the secret, the actions won't trigger in the subsequent commits. Now, I am not sure what the best thing to do is. We could just use black as a linter and leave it to the user/local hook script to format the code. Other options would be to use an external service like pre-commit.ci or write an own bot. I don't want anything complicated though...

I moved the comment to review so I point to the line.
I am not sure what do you mean by subsequent commits. The ones created automatically?
I wonder if I can just create a secret with the same name and permits in my repository and this would work. If you let me know what permits you put and how to create I can try. We can then document it in the README.

@rkaminsk I moved the comment to review so I point to the line.
I am not sure what do you mean by subsequent commits. The ones created automatically?

For example 794a5c913d207e6263cad264b117b21f89cb1c72 above.

I wonder if I can just create a secret with the same name and permits in my repository and this would work. If you let me know what permits you put and how to create I can try. We can then document it in the README.

I don't think this will work. To me it looks a bit like the auto formatting won't happen online and there will just be a hook script.

I don't think this will work. To me it looks a bit like the auto formatting won't happen online and there will just be a hook script.

Why do you think so? For me, does it work when you do a pull-request from inside the same repository? So far, I only checked for pulls. Did you check for pull-requests?

Why do you think so?

Because the secrets of the potassco repository will be used not the ones from your repository.

I'll remove the auto formatting from the action and use your pre-comment config to run black locally. We'll have to document how to set it up in the readme.

T

I'll remove the auto formatting from the action and use your pre-comment config to run black locally. We'll have to document how to set it up in the readme.

Wait a second, can you Zoom in?

Wait a second, I got it to work, replacing token by ssh-key

Be careful. Better do not put your private ssh key online. I created a separate account for this experiment. But PAT or SSH, I don't think it matters. The secrets won't be taken from your repository. And even if. We would have to explain to collaborators to set this up first. Which is overkill for things like one-time contributions. A short doc saying you have to:
python -m pip install pre-commit
pre-commit install

Or maybe
python -m pip install nox
nox

to run unit tests and linting is easier.
I'll call it quits for today.

Be careful. Better do not put your private ssh key online. I created a separate account for this experiment. But PAT or SSH, I don't think it matters.

I created a new ssh key specific for this repository and only has access to it.

The secrets won't be taken from your repository.

As I see it, the problem with PAS is depends on the organization name while the SSH secret can have any name. If there is a copy of the secret with this name in each repository it will take the secret for that repository. On a push on my repository takes my secret. On a pull-request from a fork to potassco/python-clingox, it will take the on on potassco.
And even if. We would have to explain to collaborators to set this up first. Which is overkill for things like one-time contributions. A short doc saying you have to:

python -m pip install pre-commit
pre-commit install

Or maybe
python -m pip install nox
nox

to run unit tests and linting is easier.
I'll call it quits for today.

Have you tried without the secret? I tried removing it in my repo and it works without secret just fine.

@jorgefandinno, this is what I would use after looking at all the options. I also updated the readme. Thanks for helping out with this.

It looks good. Happy to help. Thanks for making the workflow easy.
I am not familiar with nox, yet.
Let us try it for a while and we will see how well it integrates into the workflow.


Added comment about basic implementation

Added some explanation about the read model repositories.
Addresses some unclarities about the current implementation

:shipit: :+1:


feat: support deterministic deployment proxy contract transaction (#2287)

Description:
This PR adds support for the Foundry deterministic deployment proxy contract transaction, and add acceptance tests to cover the new support.
**Notice:
Currently waiting for https://github.com/hashgraph/hedera-services/pull/12713 to be included in the next Services release
Related issue(s):
Fixes #2287
Notes for reviewer:

Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

@quiet-node you should be able to test this with v0.49.0 of services now

@quiet-node you should be able to test this with v0.49.0 of services now

Thanks for the heads up! Will do!

https://github.com/hashgraph/hedera-json-rpc-relay/pull/2393


New logo/icon

Hi, I am a graphic designer, I want to help others in graphic design.
After I reviewed your project, you have no logo on this project. Therefore I want to contribute to this project by creating a new logo / icon. what do you think?

Hey @mansya
Would love to get brand new logo for this project by your side.
Before getting your hands in, please do have a look at the previous issues/PRs to get a clear understanding of why I didn't accept the previously offered logos.
Go ahead and fork the repo!
Cheers!

ok. I will see that

I have designed a logo for this app. What do you think ? do you like it ?

I use 2 letter F it describes that text F is like fade. and I designed the frame shadow behind it to illustrate that this app is a text-based fade app

Hi @mansya
I appreciate your concern for this project and I really like the way you try to explain things with your work. Can you please change the Ff with Tt? Also, I would recommend you (not mandatory) for playing around with the dotted lines a bit or just change them with solid ones. This is somewhat the kind of logo I've been wishing for this repo. I like the blue ones especially.

I have changed it with the letters Tt. and I have also changed the frame. I create a frame like that for the logo to look unique and interesting. What do you think ?

This looks perfect to me!
Go ahead and fork the repo, implement changes and send me a PR. Great work!

I have uploaded all files to this link.
https://drive.google.com/open?id=1o6nbcCKKyyi6t0fJN-QtC-gF7CDm8PKG
and I have also sent you Pull Requests. Please check

The PR has been merged. Will add the logo in the app soon.


Having any inflight messages (those NOT acked or nacked) result in unexpected behaviour with the pubsub iterator.   One of two things happen with inflight messages after one calls MessageIterator.Stop():

a) If one stops the readers by calling MessageIterator.Stop() without canceling the provided context.  Then the KeepAliver hangs waiting on it's waitgroup in KeepAliver.Stop().   Which will not happen until all messages are Acked/Nacked and removed from the keepaliver.

b) If one stops the readers by canceling the provided context and then calling MessageIterator.Stop(), then all ack's waiting in the acker queue are dropped and replay'ed after they expire.

Case b makes sense and is what I would expect.  Case a) is unexpected, as I would expect it to flush the acker (which it does) and then just kill the KeepAliver as it's no longer needed.
Thoughts?
I coded up a test case that reproduced the issue and my idea for fixing case a).   The code changes are just there to present the idea and are rough draft.   The basic idea is to use child context objects for the subcomponents so they can be shutdown in a controlled order.
https://github.com/epsniff/google-cloud-go/pull/2

We'll be removing iterators soon, and the implementation won't match what you describe. However, behavior (a), which is the intended behavior, will remain. (b) will no longer be possible (though we can add it back if desired).

The new design of the pub-sub SDK correctly documents that this is behavior, so I'm closing this ticket.


MLIL display crash in x64 with base address above 0x100000000

Describe the bug
Crash due to access violation when displaying MLIL of a x64 Windows driver with a base address above 0x100000000.
To Reproduce
Steps to reproduce the behavior:

Open Binary Ninja
Open C:\Windows\System32\drivers\dxgmms1.sys (current Windows 10; driver version 10.0.19041.906)
Set UI view to LLIL
Go to address 0x1c005ad35
Set UI to MLIL
Experience a binary ninja crash due to access violation on deref of 0x18

If you stop before step 5 and try to list out the instructions from python you can see:
>>> list(current_mlil.instructions)
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "C:\...\AppData\Local\Vector35\BinaryNinja\plugins\..\python\binaryninja\mediumlevelil.py", line 368, in __repr__
    return "<il: %s>" % str(self)
  File "C:\...\AppData\Local\Vector35\BinaryNinja\plugins\..\python\binaryninja\mediumlevelil.py", line 359, in __str__
    tokens = self.tokens
  File "C:\...\AppData\Local\Vector35\BinaryNinja\plugins\..\python\binaryninja\mediumlevelil.py", line 405, in tokens
    if not core.BNGetMediumLevelILInstructionText(self._function.handle, self._function.source_function.handle,
OSError: exception: access violation reading 0x0000000000000018

Digging into the MLIL instruction list, the first item that throws exception during repr appears to have a 64-bit pointer truncated to 32-bits in the value:
hex(current_mlil[20].operands[1].operands[1].operands[0])
0xc002e0a0

That value should be 0x1c002e0a0, the import address for g_IsInternalRelease.
Expected behavior
Don't crash, raise error.
Expected view of MLIL in UI to render.
Expected the constant to have 1 in the upper 32 bits.
Desktop (please complete the following information):

OS: Windows
Version 10

Additional context
Observed in 2.3.2779-dev, introduced at some point after 2.2.2486-dev.

We've released an interim patch that will at least fix the critical crashing issue in builds >= 2800 (should be live on dev in a few minutes) but I'm leaving this bug open because there's still a different underlying issue that we are still investigating.

Fixed in > 2.3.2800


fix typo

Fix typo
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

The forked branch no longer exists. This is prevent Jenkins from cleaning up other PRs and causing disk issues. Please move these changes to a new branch.


[visibility] - Add visibility middleware to prevent anonymous users to a...

...ccess api data and pages when config variable visibility is 'hidden' #733

When visibility == 'hidden' I'm getting this error when I enter to the app:

because items is null here:


I can't start the process in the background

Hi,
I followed this guide: https://github.com/akalongman/php-telegram-bot/wiki/Нow-to-launch-getUpdatesCLI.php-script-in-background-(getUpdate-installation)%3F
The php file if run as web works but if I start the command "start nameOfTheDaemon" does not works.
(I get no answers of the bot to my telephone, in the command line return the bot is started but if i send command status returns not started)
It possible simplify the wiki to understand it better?
Thanks

Ok, I've revised the wiki page, please do try it again.
Note: This method is for Ubuntu, using Upstart.

it works perfectly.
Thanks for your immediate answer.

You're welcome, glad it works now 👌


Breaks in Strict Mode

When I type in moon help, it gives me this error:
const rl = readline.createInterface({
^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

Just wanted to let you know :smile:

First of all, help isn't a command, adding the option --help is. But this will be fixed in the next version. The strict mode issue should be fixed as well.


Worked flawless

Obviously, not an issue, but I don't know how to contact you otherwise. Just wanted to say thanks.
Your script really helps a lot!
Cheers
Markus

Agree! Worked perfectly. Thanks very much!


issue in thresholding

Hello,
I applied
pyapetnet to 5-bed PET/MRI data. It finished successfully using model
190528_paper_bet_10_psf_mlem, but core dump using osem models.  Following is the message:
>
Optimization terminated successfully.
> Current
function value: -1.045613
>
Iterations: 1
> Function
evaluations: 42
> terminate
called after throwing an instance of 'std::bad_alloc'
>
what():  std::bad_alloc
> Aborted
(core dumped)

After a couple
of test runs, osem models work with 3-bed data. Then the resultant images were
compared:
| min | max | avg | std | X,Y, Z | filename
-- | -- | -- | -- | -- | -- | --
1 | 0.0 | 78688.0 | 1323.8 | 4910.4 | 447x230x577 | pyapetnet-psf-bet_bed123.nii
2 | -1445.8 | 110723.0 | 1104.1 | 4254.1 | 479x247x938 | pyapetnet-pdf-mlem_bed12345.nii

Questions:
1. it is a surprise that mlem had no problems in memory use,
but osem led to core dump. Any thought?
2. there are negative voxel values in the resultant images
from mlem model. Is it due to the mismatch of the PET recon method (for my PET
images, osem) and the model (mlem)?
3. It seems that pyapetnet reduces image matrix size by
thresholding/extracting the input images. This leads to different x,y
dimensions in 3- and 5-bed results (see comparison above). Further, half or
more than half of the skull on top of the head was thresholded/removed. I
wonder if there is a remedy/workaround for these? For example, a switch to
choose thresholding value/method. Or a switch to skip the image
thresholding/extracting step, and users have to threshold/extract images before
applying pyapetnet.

Thank you.

Hi,

The core dump looks very strange. I suspect that it is due to the alignment performed via SITK. Can you rerun with the --no-coreg_inputs option to skip the co-registration?
By default, the images are cropped the bounding box containing the "foreground" in the MR. You can use the --no-crop_mr option, to skip the cropping.
Concerning the negative values: Which model are you using for the prediction? Whether the output is non-negative depends on the last layers of the model (ReLU vs PreLU).

Thank you for the note.

I tried osem model with --no_coreg, it skipped printing the messages about optimization and gave the error message:

terminate called after throwing an instance of 'std::bad_alloc'
what():  std::bad_alloc
Aborted (core dumped)

it is nice to have the switch --no_crop. Definitely will use it.
thank you. I will zero the negative values.

To debug (1), you post:

operating system you are using (with or without CUDA)
pyapetnet version that you are using (and how you installed it)
exact call that produces the error
full output


Unexpected - MegaPatch.it(requests.post) not taking

Would expect this to work:
MegaPatch.it(requests.post, return_value=response)

Nevermind, plugin running


SINGLE RUN with HDF5 crash

Issue Description
relap_pwr_loca_sampler.txt

What did you expect to see happen?
N/A
What did you see instead?
(    0.04 sec) SIMULATION               : Message         -> -- Beginning step sampleRELAP of type: SingleRun                    --
(    0.04 sec) STEP SINGLERUN           : Message         -> ***  Beginning initialization ***
(    0.04 sec) STEP SINGLERUN           : Message         -> ***    Initialization done    ***
(    0.04 sec) STEP SINGLERUN           : Message         -> ***       Beginning run       ***
(    0.04 sec) Code                     : Message         -> job "None" submitted!
(    0.06 sec) Code                     : Message         -> Execution command submitted: /usr/local/tools/RELAP53D_INL/4.3.4/SLE12/relap/bin/relap5.x -i typpwr_PTC.i -o out~typpwr_PTC.o
Traceback (most recent call last):
File "/home/wmorrison/RAVEN_July_18/raven/framework/Driver.py", line 281, in
raven()
File "/home/wmorrison/RAVEN_July_18/raven/framework/Driver.py", line 234, in raven
simulation.run()
File "/home/wmorrison/RAVEN_July_18/raven/framework/Simulation.py", line 791, in run
stepInstance.takeAstep(stepInputDict)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Steps.py", line 312, in takeAstep
self._localTakeAstepRun(inDictionary)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Steps.py", line 462, in _localTakeAstepRun
model.collectOutput(finishedJob,output)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Models/Code.py", line 667, in collectOutput
output.addRealization(evaluation)
File "/home/wmorrison/RAVEN_July_18/raven/framework/Databases.py", line 248, in addRealization
self.database.addGroup(rlz)
File "/home/wmorrison/RAVEN_July_18/raven/framework/h5py_interface_creator.py", line 189, in addGroup
groupName = str(rlz.get("prefix")[0] if not isinstance(rlz.get("prefix"),basestring) else rlz.get("prefix"))
TypeError: 'NoneType' object has no attribute 'getitem'
Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error.  The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or improvement?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
[x] 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?

Wayne,
does this fix your problem?

5050101:3
time,
tempf_345010000,
cntrlvar_23,
cntrlvar_21,
mflowj_335010000,
p_335010000,
httemp_3360001_9,
httemp_3360001_16,
httemp_3360002_9,
httemp_3360003_9,
httemp_3360004_9,
httemp_3360005_9,
httemp_3360006_9

              tempf_345010000,
cntrlvar_23,
cntrlvar_21,
mflowj_335010000,
p_335010000,
httemp_3360001_9,
httemp_3360001_16,
httemp_3360002_9,
httemp_3360003_9,
httemp_3360004_9,
httemp_3360005_9,
httemp_3360006_9

Hi Diego,  Andrea resolved this issue -- the problem with the HDF5.  Thanks!

See PR #674

An email should be proposed, and the defect is only happened to the devel, not affect to the stable branch.

Checklist is satisfied, and an email is proposed in PR#673


update dependabot (#6858)

Pull request opened by the merge tool on behalf of #6858

Merged in d9e8f9b724d7bee4e19731c1928647bc3939618b


Support tansmux RTC to RTMP

For #2199
1.增加rtc to rtmp功能 视频h264 音频 opus格式,目前还不支持opus to aac
2.边缘为rtc时, 如果rtc play回触发rtmp回源
3. rtc source 如果没有推拉流时, 自动资源清理
4. gb28181 demo去掉flash, 默认开启rtc 与flv 播放
5. api返回rtmp webrtc, flv, hls等播放地址

Codecov Report

Merging #2200 (7c9d32d) into develop (4df6fa5) will decrease coverage by 0.80%.
The diff coverage is 0.24%.

@@             Coverage Diff             @@
##           develop    #2200      +/-   ##
===========================================
- Coverage    55.86%   55.05%   -0.81%
===========================================
  Files          124      125       +1
  Lines        55057    55869     +812
===========================================
+ Hits         30756    30759       +3
- Misses       24301    25110     +809

Impacted Files
Coverage Δ

trunk/src/app/srs_app_config.cpp
64.07% <0.00%> (-2.55%)
:arrow_down:

trunk/src/app/srs_app_config.hpp
100.00% <ø> (ø)

trunk/src/app/srs_app_rtc_rtp_rtmp.cpp
0.00% <0.00%> (ø)

trunk/src/app/srs_app_rtc_source.cpp
11.54% <0.00%> (-0.20%)
:arrow_down:

trunk/src/app/srs_app_rtc_source.hpp
0.00% <ø> (ø)

trunk/src/app/srs_app_source.cpp
0.73% <0.00%> (-0.02%)
:arrow_down:

trunk/src/protocol/srs_rtmp_stack.cpp
89.01% <ø> (ø)

trunk/src/app/srs_app_rtc_conn.cpp
9.20% <12.50%> (+0.02%)
:arrow_up:

trunk/src/protocol/srs_service_utility.cpp
72.97% <0.00%> (+0.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df6fa5...81d3765. Read the comment docs.

Closed for moved to #2204


Publish easy stacks to crossplane org

What problem are you facing?
Per resource packs one-pager, three resource packs are implemented that allow you to create a connected set of resource classes configured for minimal node requirements that you can use with your claims.  For faster prototyping, I worked on them under my account.

How could Crossplane help solve your problem?
They need to be moved under crossplaneio for better maintenance. Here is the list of the stacks:
https://github.com/muvaf/minimal-gcp
https://github.com/muvaf/minimal-aws
https://github.com/muvaf/minimal-azure
In its current form, the stacks themselves contain almost nothing meaningful other than kustomize resources folder and stack metadata. As reconciler, they all use the following generic one:
https://github.com/muvaf/crossplane-resourcepacks (after moving, we should probably name it resourcepack-runtime or something else)
Probably, we won't need the generic reconciler after these stacks are ported to template stacks but I still think it should go to crossplaneio org.

@muvaf I have moved all the repos over to the following new crossplaneio repos:

https://github.com/crossplaneio/stack-gcp-minimal
https://github.com/crossplaneio/stack-aws-minimal
https://github.com/crossplaneio/stack-azure-minimal
https://github.com/crossplaneio/resourcepacks

I think you'll need to follow up with some new PRs to get all the import refs updated to use the moved general reconciller, so I'll assign this issue to you now.
I think we may want to clean up a bit with the naming/terminology.  I think we're not using the term resource pack anymore, but we have code refs and a repo still using that.  Let's consolidate and change repo names if needed.  Let me know if you need help with that.  Thanks @muvaf!

@jbw976 thank you for moving all of them! I'll test them and open fix PRs if needed.
About naming, I think stack-gcp-minimal implies that this stack is a minimal version of infra stack stack-gcp in the sense that it has less resource support, like a lite version. However, it's a completely different thing.
We could possibly go with stack-minimal-gcp or something else but I don't think stack-gcp-minimal captures the intent.
About the resource packs, I honestly am not sure what to name that repo. It's a generic reconciler that you can initiate in your controller code in order to deploy the YAMLs in your container image. However, I wouldn't worry too much either since we'll port the easy stacks to template stacks and that resourcepacks repo will not be used anymore.

All three of them are published:
https://hub.docker.com/r/crossplane/stack-minimal-gcp
https://hub.docker.com/r/crossplane/stack-minimal-aws
https://hub.docker.com/r/crossplane/stack-minimal-azure


types: add basic v7 types

The function returning the library results in a hard to type library... I simplified a bunch of things so some things are only typed one way and not the other.
closes #61
commons are not accessible via WBK({…}).isEntityId.
They can only be used as direct import (import {isEntityId} from …).
Typing both creates a lot of ugly code that did not seem as necessary
wikidata-sdk has to be used with wikibase-sdk typings because of these common imports:
import wdk from 'wikidata-sdk'
import {isEntityId} from 'wikibase-sdk'

I tested the typings with existing code of mine I updated to v7.
Personally I would like to separate this library into two separate things/repos: methods independent from the Wikibase instance and methods using a specific instance. These should only have one way to include. The 'commons' can currently be either imported directly or used from the instance specific object which makes them way more complicated than I expected before.

is there a way those types could be maintained outside of wikibase-sdk itself? I'm not using typescript, and having those types in the repo only increases my reluctance to change code, which is a big red flag for me

Understandably. Having types separate to code is always not ideal for both changing the code and adapting the types.
They can be added to DefinitelyTyped instead.

Hi @EdJoPaTo, I'm now using VSCodium and definitely see the added benefit of types declarations :D Will you be willing to re-base this branch and re-open this PR?

I like hearing the interest in types again!
But I'm not sure its a good idea to add manual typings again. I think the effort of refactoring this package into TypeScript (and maybe separate code which is either dependent/independent of a Wikibase instance) will outweigh the downsides of having both types and code.
With the current code its relatively hard to manually write typings correctly. The function with the wikibase instance as an argument for initialization makes the typings quite complicated. Mistakes can and will happen easily there. Using TypeScript directly will generate the exact typings for the code and wont make mistakes.
TypeScript will also ensure that the types wont get out of sync on new fixes/features.
Guess the first version could be just a renaming of .js to .ts and using TypeScript to generate the dist folder then. TypeScript can already assume some basic things about the code without type annotations. Then type annotations can then be added/improved to the code directly (also doing type checks in the code for free).
I implemented some functions in wikibase-types (like this). I would be happy to deprecate my wikibase-types package in favor of wikibase-sdk with types. That would be awesome!
I would like to help with the TypeScript migration but I am not sure how much time I could use. Feel free to include me for TypeScript related discussions and ask me for code reviews!


hoogle data consumes a lot of space

Installing haskell-vim-now consumed several GB of space on my VM. Most of it due to hoogle database creation. Should hoogle database creation be left to the user instead?

That's odd, the hoogle database on my system is only 8.8mb.
One thing that takes up space is Stack's sandbox. It contains the packages needed to build the helper binaries for haskell-vim-now. However you'll need to build a Stack sandbox at some point anyway if you want to create haskell programs.
Can you supply more information about exactly which files/folders take up the most space and how much it is?

I had stack installed and in heavy use already so I expected that it wouldn't consume any more space. I have seen the hoogle problem before as well. Here goes some du output:
cueball:~/.stack/snapshots/x86_64-linux/lts-5.2/7.10.3/share/x86_64-linux-ghc-7.10.3/hoogle-4.2.43(master)*$ du -sm databases/
1328	databases/
cueball:~/.stack/snapshots/x86_64-linux/lts-5.2/7.10.3/share/x86_64-linux-ghc-7.10.3/hoogle-4.2.43/databases(master)*$ du -sm downloads/
1293	downloads/

1.3 G in databases dir. Out of that almost all is in downloads. Let's see what's inside:
cueball:~/.stack/snapshots/x86_64-linux/lts-5.2/7.10.3/share/x86_64-linux-ghc-7.10.3/hoogle-4.2.43/databases/downloads(master)*$ du -sm *
1	base.txt
1	base.txt.cache
604	cabal
3	cabal.index
218	cabal.tar
11	cabal.tar.gz
278	hoogle
1	hoogle.index
153	hoogle.tar
27	hoogle.tar.gz
1	keyword.htm
1	keyword.htm.cache
1	platform.cabal
1	platform.cabal.cache

I see what you mean!
$ du -d 1 -h ~/.stack/snapshots/x86_64-osx/lts-5.12/7.10.3/share/x86_64-osx-ghc-7.10.3/hoogle-4.2.43/databases
 20K	./snapshots/x86_64-osx/lts-5.12/7.10.3/share/x86_64-osx-ghc-7.10.3/hoogle-4.2.43/databases/.shake
936M	./snapshots/x86_64-osx/lts-5.12/7.10.3/share/x86_64-osx-ghc-7.10.3/hoogle-4.2.43/databases/downloads
971M	./snapshots/x86_64-osx/lts-5.12/7.10.3/share/x86_64-osx-ghc-7.10.3/hoogle-4.2.43/databases

Oddly the .hoo databases aren't very big, it's that huge downloads directory. Maybe there's a way to find it and clean it up during haskell-vim-now install.

It looks like Stack will soon handle hoogle. When this is merged https://github.com/commercialhaskell/stack/pull/1939 then we can add a key binding to run stack hoogle -- generate --local and remove the hoogle data from our installer.

Will this be able to provide a "jump to definition" functionality? I'm really looking forward to that.

Actually this functionality already exists. If you press ,tg (aka "leader Tag Generate") it uses codex to create a ctags file for your project and all the dependencies. If you then press CTRL-] on a symbol it will jump you to the definition, even in library files.

YES! I was really hoping you were going to say that!
Coincidentally I had tried CTRL-] right before my first reply, but I had missed the ,tg step. This is great :)

Do you think the ,tg step could be better communicated in the readme? If so, care to send a pull request to improve that?

Done ;)

Another thing to note is that ,tg does not work unless your current directory is the one which has .cabal file.
We can look for a .cabal in the parent dirs and generate tags if we find one rather than forcing the user to be in that same directory for generating tags.

Thanks - I didn't run into that problem because other bad things happen when I start my editor in a directory other than the one with the .cabal file, so it's habitual that I always run vim from the project root.


New sample: Hub site association

Added new sample to hub site association using PnP-PowerShell.

Nice double sample, thank you @chandaniprajapati, this will be live shortly 🎉


Service pool sorting by name should be case insensitive

Create a service pool name aaa and Zzz. When you sort it by name, Zzz appears first. Sort by name should be case insensitive.

@sureshms @harshach
We have a generic search API "api/v1/catalog/search?detail=true&namespace=<cluster/namespace/topology>&sort=<fieldName>&desc=<true/false>" to sort.
Example API path for service pool (sort by name):
api/v1/catalog/search?detail=true&namespace=cluster&sort=name&desc=false
Need to handle this case insensitivity issue on the backend.

@shahsank3t, can you try with https://github.com/hortonworks/streamline/pull/635 ?

@arunmahadevan I tried your PR and it resolves all search (case insensitive) issues.


feat: Tailwind

Tailwind for easy styling.

added tailwind + postcss via vite-preprocess with postcss.config.js


About Listener in iOS

When openning an issue, please include following information for better support

What version of RN and react-native-fcm are you running?  "^9.6.2"
What device are you using? (e.g iOS9 emulator, Android 6 device)? iOS Actual device, Android device
Is your app running in foreground, background or not running? running all

This is about listener issue when the app is in background and not running in case of iOS. What I am trying to do is, sending a message from server side, when get the message from mobile side. From server side, I didn't set notification payload because I am going to popup notification from mobile side using presentLocalNotification function. My question is why the listener is NOT triggered when app is background/not running in iOS? it works perfectly in Android as well as foreground in iOS.
If it's iOS system limit not allowing catch listener while not in foreground, I should setNotificationPayload. In that case, iOS get notification while in background BUT the listener (FCM.on(FCMEvent.Notification, async (notif) => { ... ) is not triggered which was triggered in Android version.

MY MAIN CONCERN is that how can my listener keep working even if the app is swiped off by a user in iOS??
Once I swipe off the app, listener never received message even in background which works before swiping off. This is weird too..

Here is code.
Server Side
// resend the incoming message to all participants
CcsOutMessage outMessage = new CcsOutMessage(senderRegId, messageId, inMessage.getDataPayload());
CcsClient client = CcsClient.getInstance();
client.sendBroadcast(outMessage, listRedIds);

Mobile Side

App.js
registerAppListener();
export default class App extends React.Component {
   ...
}

function registerAppListener(){
  FCM.on(FCMEvent.Notification, async (notif) => {
    //Need to get into this Listener. So I can popup using presentLocalNotification and do some stuffs.
    //Android is working perfectly fine fore/background, not running. However iOS works only in foreground but background/not running doesn't come into this trigger.
  }
}

this is frequently asked question. readme has some explanation.
iOS will wake up when receive notification in most cases and your JS callback will be triggered.
HOWEVER, if you swipe off your app, the app won't wake up anymore until launched by user again. System design.
in short, so don't use this approach for iOS.

just a quick question.
if iOS doesn't wake up the app, Does it mean, all the JS callback is ignored?
I have to store some data in mobile side whenever I get notifications which is done in my callback function.


DEEJ doesnt work when Windows is turned on after sleep

Deed does not works after turning on the Windows PC after a sleep.
Then we need to quit the application and re-launch it.

Same problem happens when the USB cord is disconnect and reconnected again.

I just finished building my first deej and was super excited about it, but ran into this issue immediately. Unfortunately, this issue makes it pretty useless for me (having to manually start the process every time the PC wakes eliminates the convenience of having a hardware mixer in the first place). It looks like this issue has been known for years, is there any indication that it will be fixed? Building from an old branch that is behind the main by years doesn't seem like a great solution

I tried making a batch script that automatically kills deej when a certain COM port is disconnected and start deej when its connected again, also make a task in task scheduler to start it when the user logs in. The only issue I am running into is whenever I try to start deej using the start command it does not run, tried in cmd and powershell. Also tried adding the path in environment variables. Clicking it would start deej instantly but had no luck running it with a script.


Clone Z-95 Killer Initiative

Initiative should be 2, ship currently playing as 3
Cheers

Thanks! Fixed, and it will be included in the next release.


✨ Feat(sentry): #85ztztgbu[TESTING]

Setup sentry with session replays and error boundary

Task linked: CU-85ztztgbu Setup Sentry


outdated

i cant even install it

I use npm to install.
It says outdated. Update the repo its not compatible with the current
version of react
On Thu, Aug 3, 2023, 6:26 PM Abdulhakim Zeinu @.***>
wrote:

What method have you used to install?
Make sure to use the correct package name
$ yarn add react-qty-picker
—
Reply to this email directly, view it on GitHub
https://github.com/AbdulhakimZ/quantity-picker/issues/3#issuecomment-1664192451,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4DSJNVLMMZ5QA4PA5RBRQLXTO7JNANCNFSM6AAAAAA3C4MD74
.
You are receiving this because you authored the thread.Message ID:
@.***>

Will work on it.
Also if you would like to contribute the door is open for open source contributors.

Thanks, I will.
On Fri, Aug 4, 2023, 5:48 PM Abdulhakim Zeinu @.***>
wrote:

Will work on it.
Also if you would like to contribute the door is open for open source
contributors.
—
Reply to this email directly, view it on GitHub
https://github.com/AbdulhakimZ/quantity-picker/issues/3#issuecomment-1665734890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4DSJNS3NIJ4PW47YAVE3YLXTUDTTANCNFSM6AAAAAA3C4MD74
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix typo in configuration guide

minor typo

Thanks for the fix, I'll update the docs in a bit once I'm at my computer!


stuff changed

This is really important change, merge it!

Coverage decreased (-0.94%) to 99.06% when pulling ac110861d825b4f6c03516f6813e6c9e7703138e on feature-bad into e4912d79967d6e859415d6773356d39c5dac1904 on master.

Coverage decreased (-0.95%) to 99.05% when pulling d0a4a648d0a2f1db054f906ad127887e29375dc3 on feature-bad into e4912d79967d6e859415d6773356d39c5dac1904 on master.

Coverage decreased (-0.95%) to 99.05% when pulling d0a4a648d0a2f1db054f906ad127887e29375dc3 on feature-bad into e4912d79967d6e859415d6773356d39c5dac1904 on master.

Coverage decreased (-0.95%) to 99.05% when pulling c53eccc8cb141d5f7c2ed1fd6e0eae91551982a8 on feature-bad into e4912d79967d6e859415d6773356d39c5dac1904 on master.

Coverage decreased (-0.95%) to 99.05% when pulling c53eccc8cb141d5f7c2ed1fd6e0eae91551982a8 on feature-bad into e4912d79967d6e859415d6773356d39c5dac1904 on master.

Coverage decreased (-0.95%) to 99.05% when pulling c53eccc8cb141d5f7c2ed1fd6e0eae91551982a8 on feature-bad into e4912d79967d6e859415d6773356d39c5dac1904 on master.


Feature Request: Allow vaiables to act on other variables

For example, getting the uppercase of the clipboard contents.
I can do it if I create a keyword "clipcont" containing "#{clipboard}" by doing:
#{upper:clipcont}
but there is no way to do it using the clipboard variable directly.
The ideal solution (in my mind) would be to have variables just be combos, so you'd be able to do:
#{upper:#{clipboard}}
or:
#{lower:#{envVar:USERNAME}}
If they were treated as combos you'd have the additional benefit of being able to do #{date} anywhere to get Friday, September 13, 2019 or #{dateTime:yyyy-MM-dd}T#{dateTime.HH.mm.ss} for 2019-09-13T10.13.12

I know this is a limitation of the current variable system. Alas, this would require quite some development for a decent parser, and I opted to focus on other features.
As you mention, there is a workaround for the issue, by creating intermediate combo (that you can disable).


TEXT_HTML_SANITIZE don't work for onclick attribute

Hi all,
I have a contact form placed in ckeditor plugin which is send via ajax call from onclick attribute. I've found out that this attribute is still stripped out with TEXT_HTML_SANITIZE = False which is very confusing.
also tried to TEXT_ADDITIONAL_ATTRIBUTES = ('onclick,) without luck...
djangocms-text-ckeditor (2.3.0)
Regards

The offending line seems to be https://github.com/divio/djangocms-text-ckeditor/blob/master/djangocms_text_ckeditor/html.py#L18, if it's set to False it should probably just return the input.
In a related note, I feel like the docs about this setting should make the dangers of this setting more explicit.

@dPeS You can configure the sanitiser https://github.com/divio/djangocms-text-ckeditor#configurable-sanitizer by allowing specific attributes to be preserved.
@ojii while I tend to agree with you, sanitisation is a standard term for this operation. We migth add big fat warnings in the relevant section of the documentation to warn against disabling it, though

"also tried to TEXT_ADDITIONAL_ATTRIBUTES = ('onclick,) without luck... "

@dPeS Did you re-enable TEXT_HTML_SANITIZE? Still on version 2.3?

yes a was trying >one< option in time, could redo tests if You want

If it does not work with 2.5.2, it's definitely a bug that needs to be addressed

ok, I will test it on 2.5.2 today and let You know
On Sun, Jun 21, 2015 at 8:58 AM, Iacopo Spalletti<EMAIL_ADDRESS>wrote:

If it does not work with 2.5.2, it's definitely a bug that needs to be
addressed
—
Reply to this email directly or view it on GitHub
https://github.com/divio/djangocms-text-ckeditor/issues/250#issuecomment-113870198
.

tested on 2.5.2 with:
TEXT_ADDITIONAL_ATTRIBUTES = ('onclick',)
still the same, attribute is removed

@dPeS thanks for your report and checks. Which version of html5lib is installed?

pip install ==2.5.2 forced html5lib 0.999 to install, but before with 2.3.0 I had 1.0b1 installed

@yakky any progress here?

for me is not relevant anymore - found a workaround, thanks d.


Create kadirov.txt

@kadirov I am sorry, but this domain does not seem to belong to a university or a college.
If you need a license with a discount, please take a look at https://www.jetbrains.com/store/?fromMenu#edition=personal (the section Discounted and Complimentary Licenses at the bottom of the page). It may happen that you are eligible for a free license because of another reason, it's not just students' privilege.
As of now, I have to close your request without merging. Please reopen and comment if you have an update regarding the abovementioned issue. Thank you for the understanding!


Arouter helper 添加 支持kotlin的导航跳转。

支持

ARouter.getInstance().build("/xx/xxx").navigation(context)
@Autowired(name = "/yourservicegroupname/hello")
与
@Route(path = "/xx/xxx")
@Route(path = "/yourservicegroupname/hello", name = "test service")
之间的相互跳转。（只支持kotlin之间的跳转

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.liwei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


IE9 Support

Hi,
On CHANGELOG omnivore seems to support IE9. But if you try to open any of the Mapbox Omnivore samples (like https://www.mapbox.com/mapbox.js/example/v1.0.0/omnivore-kml/) on IE9, page will hang an browser will say that "mapbox.com is not responding".
Trying on home, i got the message "No such interface supported" on JS console. Char 29 on this line:
https://github.com/mapbox/leaflet-omnivore/blob/v0.3.0/leaflet-omnivore.js#L786
I'm testing on the IE 9/Win 7 virtualbox image from modern.IE
Hope that you can fix it, there is a lot of people still using IE9...
Thanks.

Closing; happy to accept a pull request implementing this change, otherwise IE9 is not a high maintainer concern.


Fonts are too small

Font size in wallet is far too small for all eyes to easily read so things will be missed and mistakes will be made by users.

Also the tab label text for the inactive tabs is too light. No contrast with background so the tabs are barely visible
Image here

Also the tab label text for the inactive tabs is too light. No contrast with background so the tabs are barely visible
Image here


:racehorse: Optimize realpath checks

Use a cache
Use async realpath

This optimization doesn't make much of a difference on my machine. I never noticed any slowness to begin with, and even in a directory with lots of symlinks (my ~/.atom), indexing was already fast without this. But it might make a difference on a machine with an HDD.


Disable enrichment option if the template is being used in a portal

If the template is configured using a portal that may be offline or not have access to enrichment services, we should not show the enrichment steps.

That’s a good point. I’ll log a github issue to disable enrichment if in portal mode.
Matt Driscoll | Web Developer
Esri | 380 New York Street | Redlands, CA 92373 | USA
T<PHONE_NUMBER> x3587 |<EMAIL_ADDRESS>| esri.com
From: Ian Wittenmyer<EMAIL_ADDRESS>Date: Thursday, January 15, 2015 at 3:53 PM
To: Molly Zurn<EMAIL_ADDRESS>Kim Peter<EMAIL_ADDRESS>Matt Driscoll<EMAIL_ADDRESS>Subject: RE: Impact Summary
This template can be used to sum numerical data and doesn’t require output from the tools mentioned in order to work.  The key piece of info is that it ‘can be any integer data…’. I think its ok to leave the second paragraph as is since it just says ‘For instance…’
In the 3.7 update, it will support Enrichment from within the application builder.
Matt,
Will you be checking the self-call for isPortal true and disabling this functionality?
From: Molly Zurn
Sent: Thursday, January 15, 2015 3:03 PM
To: Kim Peter; Ian Wittenmyer
Subject: RE: Impact Summary
“ArcGIS Online web map” isn’t really a meaningful term, especially now that Pro creates web maps.
A web map is a web map is a web map…..
Do you mean the map viewer?
From: Kim Peter
Sent: Thursday, January 15, 2015 2:50 PM
To: Ian Wittenmyer
Cc: Molly Zurn
Subject: Impact Summary
The item details for Impact Summary mention using analysis tools that are only available in Online, right?  Maybe this is one place where the item details should call out using it with Online. (i.e., “For instance, in an ArcGIS Online web map, you could enrich your polygon demographics, landscape, infrastructure…”)

@driskull
We are fetching GPServer enrichment process url from portal info.

So we can disable the enrichment process if this information is not available in portal.
Need you inputs on this.
Thanks!

Yep. that sounds good.

@driskull
For ArcGIS trial accounts we are able to perform the analysis(Geo enrichment) but in users portal information we are not able to get the 'Analysis url'.
So user can perform the enrichment process in ArcGIS but not in our application.
We are investigating on this and will keep you updated.
Thanks!

Ok, keep me posted. thanks


perlPackages.ack: 2.28 -> v3.0.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@dtzWill do you mind rebasing?

@GrahamcOfBorg build perlPackages.ack

ack is already 3.0.2 in nixpkgs
this PR is obsolete

Obsolete since 967127db209e23a9ba4b632e74176dc524f38964


Publish Buildkite Packages without Docker

Following on from #2824 and #2824, it looks like the deploytools image is only available when authenticated to ECR:

I started by copy/pasting the auth gear from the other steps which use deploytools .. but then realised all these steps need are bash, buildkite-agent, and curl .. and those are all available on the host. So just remove all the docker plugin stuff and let it run on the host.

(rebased because GitHub wanted it updated)


Feedback views can't use @staff_member_required

We are taking away staff priovileges from other comittees than dotKom when the dashboard gets made, which makes these checks in feedback irrelevant.
I suggest you make your own decorator here, where you validate whether or not the user is in a comittee that should be able to see feedbacks.
I don't know if we should allow dotKom and/or HS as well? Thoughts?

Could also be implemented using django-guardian for object level permissions. https://github.com/dotKom/onlineweb4/blob/23e6e704665d9135ef385377702000bc3634c444/apps/posters/dashboard/views.py#L171


fix(rollup-relayer): check if previous bundle or batch is finalized in fake finalize mode

Purpose or design rationale of this PR
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[x] fix: A bug fix

Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?

[x] Yes

Breaking change label
Does this PR have the breaking-change label?

[x] No, this PR is not a breaking change

Codecov Report
Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (3ab5752) to head (912561a).

Files with missing lines
Patch %
Lines

rollup/internal/controller/relayer/l2_relayer.go
15.38%
8 Missing and 3 partials :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1563      +/-   ##
===========================================
- Coverage    52.78%   52.74%   -0.04%
===========================================
  Files          157      157
  Lines        12652    12665      +13
===========================================
+ Hits          6678     6680       +2
- Misses        5392     5400       +8
- Partials       582      585       +3

Flag
Coverage Δ

rollup
58.93% <15.38%> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PyTorch Lightning + Heterogeneous Graph Learning Example

Codecov Report

Merging #3098 (6f06aec) into master (84c87c7) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
+ Coverage   72.94%   73.29%   +0.34%
==========================================
  Files         287      287
  Lines       13619    13594      -25
==========================================
+ Hits         9935     9964      +29
+ Misses       3684     3630      -54

Impacted Files
Coverage Δ

torch_geometric/transforms/base_transform.py
75.00% <0.00%> (-5.00%)
:arrow_down:

torch_geometric/data/temporal.py
28.57% <0.00%> (-2.68%)
:arrow_down:

torch_geometric/transforms/gdc.py
78.35% <0.00%> (-0.23%)
:arrow_down:

torch_geometric/loader/graph_saint.py
97.97% <0.00%> (-0.05%)
:arrow_down:

torch_geometric/nn/models/gnn_explainer.py
95.75% <0.00%> (-0.03%)
:arrow_down:

torch_geometric/nn/conv/rgcn_conv.py
98.51% <0.00%> (-0.03%)
:arrow_down:

torch_geometric/deprecation.py
100.00% <0.00%> (ø)

torch_geometric/nn/dense/linear.py
100.00% <0.00%> (ø)

torch_geometric/nn/conv/gmm_conv.py
100.00% <0.00%> (ø)

torch_geometric/nn/models/re_net.py
100.00% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c87c7...6f06aec. Read the comment docs.