How to get query args in resolver ?

Hi. I try to get access to query args in my resolve field function, but gets empty object.
My schema:
type Query {
  users(data: UsersInput): [User!]!
}

type User {
  USERID: ID!
  name: String!
  lastname: String
  acclog: [Log!]!
}

type Log {
  id: ID!
  time: String!
}

input UsersInput {
  id: ID
  dateStart: String
  dateEnd: String
}

When I query for users I need dateStart and dateEnd for resolve acclog filed.
my User.js
const User = {
  async acclog(parent, args, { conn }, info) {
    console.log(args);
...
    return result.recordset;
  }
};

But I see {} in my log.
How can get args here ?

Hey @frenzymind we @the-guild-org are new maintainers of this project. We are actively working on v2. Would love to get your feedback on beta release @graphql-yoga/node@beta!


automate test to check sync on IP address change on client side

Is your feature request related to a problem? Please describe.

when IP of the mobile app or command line app changes, sync behaviour is unknown

Describe the solution you'd like

explore options to automate change of IP address
check sync progress/status after IP address changes

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

duplicate of https://github.com/atsign-foundation/at_client_sdk/issues/550


Add devices endpoint

TODOs

[ ] Unit tests.
[ ] API Specs Doc.

Description and Motivation

Add device list service model.
Add devices controller.
Add device api model.
Add device list api model.

Change type

[ ] Bug fix
[x] New feature
[ ] Enhancement
[ ] Breaking change (breaks backward compatibility)

This change is

Endpoint is not needed.


Improve "OpenSearch exited with code 137" OOM error message on OSX

On attempting to setup OpenSearch and OpenSearch Dashboard, with Docker compose using only this documentation - it does not show expected behaviour and the dashboard is unavailable:
https://opensearch.org/downloads.html
Here is the terminal output on running the "docker-compose up" command as mentioned in the documented steps:
TerminalOutput.txt
Operating System: Amazon Linux 2 x86_64

The opensearch dashboard doesn't connect and gives this error on following the documentation instructions (https://opensearch.org/downloads.html):
opensearch-dashboards  | {"type":"log","@timestamp":"2021-07-16T18:22:29Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: getaddrinfo ENOTFOUND opensearch-node1 opensearch-node1:9200"}
However, if you set:
vm.max_map_count=262144
in the /etc/sysctl.conf file and use sudo sysctl -p to reload, the opensearch dashboard should work now and you will see the below message instead:
opensearch-dashboards  | {"type":"log","@timestamp":"2021-07-16T19:56:41Z","tags":["listening","info"],"pid":1,"message":"Server running at http://0:5601"} opensearch-dashboards  | {"type":"log","@timestamp":"2021-07-16T19:56:41Z","tags":["info","http","server","OpenSearchDashboards"],"pid":1,"message":"http server running at http://0:5601"}

Dashboard returns connection error with OpenSearch because the opensearch process exited on bootstrap check failures.
opensearch-node2         | [2021-07-16T22:11:19,768][INFO ][o.o.b.BootstrapChecks    ] [opensearch-node2] bound or publishing to a non-loopback address, enforcing bootstrap checks
opensearch-node2         | ERROR: [1] bootstrap checks failed
opensearch-node2         | [1]: max virtual memory areas vm.max_map_count [65536] is too low, increase to at least [262144]
opensearch-node2         | ERROR: OpenSearch did not exit normally - check the logs at /usr/share/opensearch/logs/opensearch-cluster.log

On a Linux machine, it fails with proper error indicating bootstrap check failures due to vm.max_map_count [65536] is too low. However, when I run the same from Mac, this messaging seems ambiguous.
On Mac, it returns -
opensearch-node2         | OpenSearch exited with code 137
Exit code 137 stands for OOM failure. We need to fix this.
Anyways, the fix is increasing the vm.max_map_count to 262144 (as recommended above) https://gist.github.com/slovenski/48cbcbdfe05fda0bbe02f988c75914fa

I renamed this issue to say that the error message needs to be improved on OSX and marked it as "good first issue". Maybe someone on this thread can PR a fix!

I tried running OpenSearch with Docker compose on Mac with the default vm.max_map_count as 65535 and got the expected error message
ERROR: [1] bootstrap checks failed opensearch-node1         | [1]: max virtual memory areas vm.max_map_count [65535] is too low, increase to at least [262144] opensearch-node1         | ERROR: OpenSearch did not exit normally - check the logs at /usr/share/opensearch/logs/opensearch-cluster.log opensearch-node1         | [2021-07-21T16:40:32,973][INFO ][o.o.n.Node               ] [opensearch-node1] stopping ... opensearch-node2         | ERROR: [1] bootstrap checks failed opensearch-node2         | [1]: max virtual memory areas vm.max_map_count [65535] is too low, increase to at least [262144] opensearch-node2         | ERROR: OpenSearch did not exit normally - check the logs at /usr/share/opensearch/logs/opensearch-

Failure logs from last run for docker mac w/ exit code 137 error - https://gist.github.com/setiah/5c500960ebc76ab04e00a542e9709e37
^[[32mopensearch-node2         |^[[0m [2021-07-16T19:46:56,428][INFO ][o.o.t.TransportService   ] [opensearch-node2] publish_address {<IP_ADDRESS>:9300}, bound_addresses {<IP_ADDRESS>:9300}
^[[32mopensearch-node2         |^[[0m [2021-07-16T19:46:56,909][INFO ][o.o.b.BootstrapChecks    ] [opensearch-node2] bound or publishing to a non-loopback address, enforcing bootstrap checks
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:46:57,309][DEPRECATION][o.o.d.c.s.Settings       ] [opensearch-node1] [node.max_local_storage_nodes] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:46:59,115][WARN ][o.o.s.c.Salt             ] [opensearch-node1] If you plan to use field masking pls configure compliance salt e1ukloTsQlOgPquJ to be a random string of 16 chars length identical on all nodes
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:46:59,195][INFO ][o.o.s.a.i.AuditLogImpl   ] [opensearch-node1] Message routing enabled: true
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:46:59,331][INFO ][o.o.s.f.SecurityFilter   ] [opensearch-node1] <NONE> indices are made immutable.
^[[36mopensearch-dashboards    |^[[0m {"type":"log","@timestamp":"2021-07-16T19:46:59Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: connect ECONNREFUSED <IP_ADDRESS>:9200"}
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:46:59,878][INFO ][o.o.a.b.ADCircuitBreakerService] [opensearch-node1] Registered memory breaker.
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:47:00,524][INFO ][o.o.t.NettyAllocator     ] [opensearch-node1] creating NettyAllocator with the following configs: [name=unpooled, suggested_max_allocation_size=256kb, factors={opensearch.unsafe.use_unpooled_allocator=null, g1gc_enabled=true, g1gc_region_size=1mb, heap_size=512mb}]
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:47:01,022][INFO ][o.o.d.DiscoveryModule    ] [opensearch-node1] using discovery type [zen] and seed hosts providers [settings]
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:47:03,152][WARN ][o.o.g.DanglingIndicesState] [opensearch-node1] gateway.auto_import_dangling_indices is disabled, dangling indices will not be automatically detected or imported and must be managed manually
^[[36mopensearch-dashboards    |^[[0m {"type":"log","@timestamp":"2021-07-16T19:47:03Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: connect ECONNREFUSED <IP_ADDRESS>:9200"}
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:47:04,361][INFO ][o.o.p.h.c.PerformanceAnalyzerConfigAction] [opensearch-node1] PerformanceAnalyzer Enabled: false
^[[36mopensearch-dashboards    |^[[0m {"type":"log","@timestamp":"2021-07-16T19:47:04Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: connect ECONNREFUSED <IP_ADDRESS>:9200"}
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:47:04,830][INFO ][o.o.n.Node               ] [opensearch-node1] initialized
^[[33mopensearch-node1         |^[[0m [2021-07-16T19:47:04,830][INFO ][o.o.n.Node               ] [opensearch-node1] starting ...
^[[32mopensearch-node2         |^[[0m Killing performance analyzer process 11
^[[32mopensearch-node2         |^[[0m OpenSearch exited with code 137

I can reproduce it at my end.
Below steps were followed on Mac (same as described on the website) -

Download docker-compose.yml from https://opensearch.org/downloads.html
Run docker-compose up

Docker Images

➜  opensearch-docker docker images
REPOSITORY                                TAG                 IMAGE ID       CREATED         SIZE
opensearchproject/opensearch              latest              88b67cc9e81f   12 days ago     1.54GB
opensearchproject/opensearch-dashboards   latest              6a109c3fbebf   12 days ago     1.63GB

Setup
Docker version : Docker version 20.10.5, build 55c4c88
ProductName:	Mac OS X
ProductVersion:	10.14.6
Logs - https://gist.github.com/setiah/e05c93f5e925e2eb942d06febf0becd7

I'm not able to reproduce the error by building docker image locally using ./gradlew assemble and it's running as expected. We can add in the document () to increase the vm.max_map_count to 262144.
Ref: https://github.com/elastic/elasticsearch/issues/23498#issuecomment-284728221

Hi there,
we installed OpenSearch via Docker on Debian 10. The error "...[ConnectionError]: getaddrinfo ENOTFOUND opensearch-node1..." could be solved by adjusting the mentioned kernel parameter.
Regards

@setiah Sounds like we do have a repro, what's different?
@owaiskazi19 Definitely track down adding the right thing(s) to the doc(s), please.

Code 137 is lack of memory indication.
If we are using Docker Desktop for Mac or Windows, need to have at least 4GB of RAM for Docker Engine to run or OpenSearch nodes might fail.

The original issue was that we don't log the recommendation of changing a JVM setting on OSX. I can't tell by the above whether that's still the case or not? What's the definitive answer?

Basically, we need to add these pre-requisites before running docker-compose up.

For linux, increase the vm.max_map_count to 262144. The default value is 65536.

1. Add the following line to /etc/sysctl.conf:
vm.max_map_count=262144
2. Reload the config:
sudo sysctl -p
3. Check the new value:
cat /proc/sys/vm/max_map_count

For Mac, increase the docker desktop runtime memory to 4GB.  By default, Docker Desktop is set to use 2 GB runtime memory, allocated from the total available memory on your Mac.

Issue to fix the documentation on website - https://github.com/opensearch-project/project-website/issues/222

...is this a memory usage regression from Open Distro? I don't recall having to set this and it's not in the documentation where the docker-compose file was sourced from.

@dblock the reason we don't see this on OSX is because we don't have this bootstrap check for OSX. It is only there for linux. I'm not sure of the reason, but seems like operating system specific difference.
It crashes on mac due to lower RAM allocated to docker by default. Increasing the RAM to 4GB fixed it.

@dblock the reason we don't see this on OSX is because we don't have this bootstrap check for OSX. It is only there for linux. I'm not sure of the reason, but seems like operating system specific difference.

Ok, so this seems like we want this implemented for OSX, which is the original issue reported here.

It crashes on mac due to lower RAM allocated to docker by default. Increasing the RAM to 4GB fixed it.

@stockholmux it's mentioned on https://opensearch.org/docs/opensearch/install/important-settings/. As @setiah mentioned we need to fix the documentation on website and add the above link there.

@stockholmux odfe documentation calls out increasing docker RAM to 4G https://opensearch.org/docs/opensearch/install/docker/.
docker-compose file is sourced from the download link on the website. https://opensearch.org/downloads.html

OK. Fair enough 🤦♂.  We'll add the same notice about 4gb to the download page.

Fixed by opensearch-project/project-website/issues/222

@owaiskazi19 and @setiah can either of you confirm that the vm.max_map_count is actually needed in docker in Linux?
The documentation indicates otherwise: "For production workloads, make sure the Linux setting vm.max_map_count is set to at least 262144. On the OpenSearch Docker image, this setting is the default."

Yes @stockholmux. Here is the Linux docker-compose up logs with default vm.max_map_count.
opensearch-node1         | [1]: max virtual memory areas vm.max_map_count [65530] is too low, increase to at least [262144] opensearch-node1         | ERROR: OpenSearch did not exit normally - check the logs at /usr/share/opensearch/logs/opensearch-cluster.log opensearch-node1         | [2021-07-22T23:52:53,072][INFO ][o.o.n.Node               ] [opensearch-node1] stopping ... opensearch-node1         | [2021-07-22T23:52:53,072][INFO ][o.o.s.a.r.AuditMessageRouter] [opensearch-node1] Closing AuditMessageRouter opensearch-node1         | [2021-07-22T23:52:53,073][INFO ][o.o.s.a.s.SinkProvider   ] [opensearch-node1] Closing InternalOpenSearchSink opensearch-node1         | [2021-07-22T23:52:53,073][INFO ][o.o.s.a.s.SinkProvider   ] [opensearch-node1] Closing DebugSink opensearch-node2         | [2021-07-22T23:52:53,084][INFO ][o.o.n.Node               ] [opensearch-node2] stopped opensearch-node2         | [2021-07-22T23:52:53,085][INFO ][o.o.n.Node               ] [opensearch-node2] closing ... opensearch-node1         | [2021-07-22T23:52:53,084][INFO ][o.o.n.Node               ] [opensearch-node1] stopped opensearch-node1         | [2021-07-22T23:52:53,085][INFO ][o.o.n.Node               ] [opensearch-node1] closing ... opensearch-node2         | [2021-07-22T23:52:53,089][INFO ][o.o.s.a.i.AuditLogImpl   ] [opensearch-node2] Closing AuditLogImpl opensearch-node1         | [2021-07-22T23:52:53,089][INFO ][o.o.s.a.i.AuditLogImpl   ] [opensearch-node1] Closing AuditLogImpl opensearch-node2         | [2021-07-22T23:52:53,091][INFO ][o.o.n.Node               ] [opensearch-node2] closed opensearch-node1         | [2021-07-22T23:52:53,091][INFO ][o.o.n.Node               ] [opensearch-node1] closed opensearch-node2         | Killing performance analyzer process 11 opensearch-node2         | OpenSearch exited with code 78 opensearch-node2         | Performance analyzer exited with code 143 opensearch-node1         | Killing performance analyzer process 11 opensearch-node1         | OpenSearch exited with code 78 opensearch-node1         | Performance analyzer exited with code 143 opensearch-node2 exited with code 0 opensearch-node1 exited with code 0 opensearch-dashboards    | {"type":"log","@timestamp":"2021-07-22T23:52:54Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: getaddrinfo ENOTFOUND opensearch-node1 opensearch-node1:9200"} opensearch-dashboards    | {"type":"log","@timestamp":"2021-07-22T23:52:57Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: getaddrinfo ENOTFOUND opensearch-node1 opensearch-node1:9200"} opensearch-dashboards    | {"type":"log","@timestamp":"2021-07-22T23:52:59Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: getaddrinfo ENOTFOUND opensearch-node1 opensearch-node1:9200"} opensearch-dashboards    | {"type":"log","@timestamp":"2021-07-22T23:53:02Z","tags":["error","opensearch","data"],"pid":1,"message":"[ConnectionError]: getaddrinfo ENOTFOUND opensearch-node1 opensearch-node1:9200"}

OK - I have a PR for the website that address all plaforms: https://github.com/opensearch-project/project-website/pull/241 - I'm waiting on an update to the docs site to deploy it (there is also a merged but not deployed change on Docs for this issue).
However, I've been doing some reading on the vm.max_map_count and it seems setting it for WSL on windows is a long unresolved problem with Docker. Most search results on google for vm.max_map_count related someone trying (and failing) to run Elasticsearch. Do we know what the root cause of needing to use vm.max_map_count actually is? Can we fix it?

OpenSearch uses mmapfs to store the indices which requires virtual memory space of the host machine. We want to set or increase the virtual memory using vm.max_map_count for the host machine and not on the container level. This is the reason why it should be set manually and can be reset later.

@owaiskazi19 OK. Makes sense.
I'm wondering if it would be wise to use a different index.store.type for those just trying out OpenSearch via docker-compose. This would likely get around special settings and reduce friction for those wanting to get started on a desktop machine. Of course, for production workloads mmapfs would be better.

We can bypass the bootstrap check (where it checks for vm.max_map_count) by setting some flag (https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/bootstrap/BootstrapChecks.java#L307) but I'm not sure if it's the correct way to do it and what all needs to be addressed if we create a flag.
cc: @setiah @saratvemulapalli

@owaiskazi19 following up on this one.
Could you help understand what more work is needed here?

@saratvemulapalli we have already changed the steps for downloading opensearch.
Ref: https://opensearch.org/downloads.html. We can close this issue.


"webrtc/offer: unknown error" when using "mode: webrtc"

Running a PC with HA supervised install. With Chromium on the GUI on that PC I can't use webRTC streams. It displays "webrtc/offer: unknown error".  All other devices on the network can use RTC.

Anyone else having this issue?

Seems that this and the previous issue (defaulting to MSE) was solved by update to Debian Bookworm or kernel v6. I'm thinking the previous kernel <IP_ADDRESS> did not properly support Ryzen 5000 chips and therefore did not have hardware acceleration.


Translatation is missing for specific notifications in webhooks

Describe the Bug
I'm using a Discord server with a few channels for BookStack notifications only and if I restore a revision in BookStack, I just receive the following message:
Julian activities.revision_restore
The same happens if I change admin settings in BookStack:
Julian activities.settings_update
Also if a maintenance has been started:
Julian activities.maintenance_action_run
Steps to Reproduce

Use "German" as language
Create a webhook, in my example for Discord
Make some changes in BookStack to receive alerts via Discord
Switch to Discord and you'll see non-translated messages

Expected Behaviour
I expected translated messages like ...

Julian started a maintenance
Julian restored a page

Screenshots or Additional Context

Browser Details
Firefox 112.0.2 (64-Bit) on Windows 10
Exact BookStack Version
v23.05
PHP Version
8.1.2
Hosting Environment
Ubuntu 22.04.2 LTS VPS, installed using official installation script

Thanks for reporting.
I've now added activity text for each activity type within commit f39938c4e3b8750668442a6a17e1006953b5cef2.
This will be part of the next feature release.
Might take a little extra time for language variations to trickle down.


git diff pane squashed

I'm trying to view a diff of my modified file from within Atom using the git-plus package. The diff does appear but it is too small to be readable / useable. It seems to be limited to 7 characters width (see attached screenshot).
Steps to reproduce:

Make changes to file
Select git plus diff on file
Observe opened diff pane

Expected results:
Git plus diff pane is able to be viewed filling the available space available.
Actual result:
Git plus diff pane is squashed to 7 columns.

I was able to reproduce this by changing my preferred line length to 7 and enabling 'Soft Wrap' and 'Soft Wrap At Preferred Line Length' in the 'Word Diff Grammar' section of the package settings.
I think if you have the line length preference set globally in editor settings then I think you need to override it in settings of this package

Thanks @akonwi. Yes I had set a global line length that I had forgot about. Making the change in the git-plus package settings allowed me to view diffs again!
Something interesting though, I tried to set the line length in git-plus package settings to be the same as my global settings (160) but it would not allow this. It seems that 159 and 161 are allowed. I physically can't enter 160 into the entry box. It clears my value and prints Unscoped value: 160. Is this the intended behaviour?

The default values for those input fields in atom are shown as the placeholder text. So if your global setting is 160, that's why it's just showing 160 as placeholder text. The 'Unscoped` means it's coming from outside of the package I think.

Sorry I don't think I explained my issue correctly. My global settings aren't being respected. git-plus is defaulting to 8 when I try and match the global settings in the package settings. 8 isn't a feasible line length and I don't know where that is coming from.
I've made an animated gif it it helps?

What I expect to happen is:

If a global setting has been set, then use it.
git-plus isn't respecting my global settings at the moment.
Otherwise use a sensible package default. I would argue that 8 is not a sensible default, perhaps 80?
In either case allow the user to override the global setting / package default with a package setting even if it is with the same value as the aforementioned settings / defaults.
At the moment I try and override the package setting with the value of the global setting and it doesn't allow me to do this. Instead it snaps back to the package default of 8, which is inappropriate to view diffs.

That is odd.
The package doesn't have a default line length setup so that '8' may have come from your input accidentally at some point. When you cleared the field it defaulted to the global setting though so it's odd that the guide didn't move at that point. I would suggest leaving that field empty and re-opening the diff file to see if it resets the guide.
This package doesn't do anything with those particular configuration options. Those are generated by atom because the package provides the diff grammar. The Word Wrap package uses those config options on a per file basis.
I recreated the same scenario and it works as expected. I started with a 160 as the global value, then put 8 in the package config and cleared it out and it defaulted back to 160 and the guide moved accordingly.

Thanks. Yes very frustrating. I still couldn't reproduce what you were seeing so I looking in my config.cson file I saw the following:
".diff":
  editor:
    preferredLineLength: 8
    softWrapAtPreferredLineLength: true
    tabLength: 4

I have no idea where this came from. I don't remember setting this and can't find a package that sets this either. Removing that block causes the git diff to respect my global settings. Is this something that git-plus set / used to set? If not, any idea where it came from? Many thanks for helping troubleshoot!

This package provides the diff grammar BUT it does not provide any configurations for the grammar. Those settings for the grammar are generated by atom.
The default values for those configurations that atom creates are inherited from the global values.
The config.cson contains the user provided values that replace package or editor defaults. I'm not quite sure where that block you have is coming from because I don't have it. The key in my config is ".diff.source" so i'm not sure why yours would be different. With that said, I changed mine from ".diff.source" to just ".diff" and I started seeing the behavior you showed in the gif. It seems like ".diff" overrides the global values as the default for the diff grammar.
This means at some point, you probably mistyped 8 as the line length preference and then somehow, the config block for ".diff" you just shared, was created. And then when you entered "160" or cleared the field, atom saw that as the global default of 160 so that's what the "Unscoped value: 160" is. But the guide doesn't move and that's probably because the wrap guide package saw the new override for the diff grammar from your config.cson as 8 still.
This is a weird bug/mistake. I suspect you could recreate this with any grammar in atom if you copied the config block and removed the 'source' part from the key. This is probably a bug in atom's settings package or the Word Wrap package


Additional query parameters when calling openid-configuration

Hi Azure AD team,
My issue is the same than this one already closed but no solution provided:
Is it possible to have additional query parameters when calling openid-configuration endpoint?
I'm using @azure/msal-browser v2.8.0 with Microsoft Azure AD B2C as the authority. And my MSAL code is as follows:
const msalInstance = new PublicClientApplication({
  auth: {
    clientId: '523c07bb-fb03-45e4-90af-f8354f4a1234',
    authority: 'https://myapp.b2clogin.com/app.mydomain/v2.0',
    knownAuthorities: ['b2clogin.com'],
    protocolMode: ProtocolMode.OIDC
})

// Somewhere in a button:
msalInstance.loginRedirect(scopes)

When I call msalInstance.loginRedirect() the browser first makes an Ajax call to the OpenID configuration end-point. The URL of this end-point is:
https://myapp.b2clogin.com/app.mydomain/v2.0/.well-known/openid-configuration?p=b2c_signup_signin

Instead the MSAL library omits/doesn't include the query parameter p ?p=b2c_signup_signin and makes a call to:
https://myapp.b2clogin.com/app.mydomain/v2.0/.well-known/openid-configuration

and the server returns a 404 error.
If on the auth config I set authority to:
auth: {
  authority: 'https://myapp.b2clogin.com/app.mydomain/v2.0?p=b2c_signup_signin',
  // ...
})

the Ajax call to the OpenID configuration end-point will be made to
https://myapp.b2clogin.com/app.mydomain/v2.0?p=b2c_signup_signin/.well-known/openid-configuration < Incorrect
https://myapp.b2clogin.com/app.mydomain/v2.0/.well-known/openid-configuration?p=b2c_signup_signin < Correct

which the response will be another 404 error.
I also tried using the authorityMetadata property:
const msalInstance = new PublicClientApplication({
  auth: {
    authority: 'https://myapp.b2clogin.com/app.mydomain/v2.0?p=b2c_signup_signin',
    authorityMetadata: 'json content',
    // ...
  }
})

But this property just seems to be ignored, in addition to no exist on the auth config object msal-browser source code. Do I correctly assume msal-browser uses msal-core under the hood? Is msal-core the old 1.x version and instead msal-browser 2.x uses now msal-common? Is authorityMetadata property implemented for msal-common?
Is there a way to add extra params to the query? Otherwise it seems it will be impossible to use Azure AD B2C as authority? Am I missing something?

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description

Source

[ ] Internal (Microsoft)
[x] Customer request

So I see on the Dev branch the authorityMetadata property is added to Configuration.ts. But this change isn't merged yet to Master (Configuration.ts on Master).
Any idea when Dev is going to be merged into Master for a public release?

So I see on the Dev branch the authorityMetadata property is added to Configuration.ts. But this change isn't merged yet to Master (Configuration.ts on Master).
Any idea when Dev is going to be merged into Master for a public release?

@AntonioRedondo We do not support query parameters on the openid-configuration call. In order to support B2C you should set your authority to https://myapp.b2clogin.com/app.mydomain/b2c_signup_signin and remove protocolMode from your config. Can you let us know if that resolves this?

@AntonioRedondo We do not support query parameters on the openid-configuration call. In order to support B2C you should set your authority to https://myapp.b2clogin.com/app.mydomain/b2c_signup_signin and remove protocolMode from your config. Can you let us know if that resolves this?

Hey @tnorling,
Yeah, that works. Thanks! 💝

Hey @tnorling,
Yeah, that works. Thanks! 💝


test_quic_tserver flakey on FreeBSD 12

I am testing the master branch at commit:
833840be97 (github/master) QUIC TXP: Add extra test

running the test in a loop, it succeeds on the 4th (variable) try. Failure example below.  On a Fedora36 system 20 successive attempts all pass.
$ make TESTS=test_quic_tserver test
make depend && make _tests
( SRCTOP=../openssl  BLDTOP=.  PERL="/usr/local/bin/perl"  FIPSKEY="f4556650ac31d35461610bac4ed81b1a181b2d8a43ea2854cbae22ca74560813"  EXE_EXT=  /usr/local/bin/perl ../openssl/test/run_tests.pl test_quic_tserver )
00-prep_fipsmodule_cnf.t .. skipped: FIPS module config file only supported in a fips build
Files=1, Tests=0,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.17 cusr  0.01 csys =  0.19 CPU)
Result: NOTESTS
70-test_quic_tserver.t ..
        # ERROR:  @ ../openssl/test/quic_tserver_test.c:201
        # timeout while attempting QUIC server test
        #
        # 0040B20008000000:error:80000023:system library:dgram_recvmmsg:Resource temporarily unavailable:../openssl/crypto/bio/bss_dgram.c:1520:
        # 0040B20008000000:error:80000023:system library:dgram_recvmmsg:Resource temporarily unavailable:../openssl/crypto/bio/bss_dgram.c:1520:
        # 0040B20008000000:error:80000023:system library:dgram_recvmmsg:Resource temporarily unavailable:../openssl/crypto/bio/bss_dgram.c:1520:
        # OPENSSL_TEST_RAND_ORDER=1690256148
        not ok 4 - iteration 4
# ------------------------------------------------------------------------------
    # OPENSSL_TEST_RAND_ORDER=1690256148
    not ok 1 - test_tserver
# ------------------------------------------------------------------------------
../../util/wrap.pl ../../test/quic_tserver_test ../../../openssl/test/certs/servercert.pem ../../../openssl/test/certs/serverkey.pem => 1
not ok 1
70-test_quic_tserver.t .. 1/? --------------------------------------------------
#   Failed test at ../openssl/test/recipes/70-test_quic_tserver.t line 19.
70-test_quic_tserver.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests

Test Summary Report
-------------------
70-test_quic_tserver.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  6 wallclock secs ( 0.01 usr  0.00 sys +  4.08 cusr  4.38 csys =  8.47 CPU)
Result: FAIL

Thanks. This is under investigation.

I'm still unable to reproduce this on FreeBSD 12 or 13 (50,000 iterations).
I expect this bug is real but it's going to be hard to catch it without a viable reproducer. Is there any possibility of temporary access to the machine on which you're able to reproduce this? @vdukhovni

We also get this almost nightly in our CI that runs on s390x:
        # ERROR:  @ test/quic_tserver_test.c:201
        # timeout while attempting QUIC server test
        #
        # OPENSSL_TEST_RAND_ORDER=1690748376
        not ok 2 - iteration 2
        # ERROR:  @ test/quic_tserver_test.c:201
        # timeout while attempting QUIC server test
        #
        # 000003FFB86757C0:error:8000000B:system library:dgram_recvmmsg:Resource temporarily unavailable:crypto/bio/bss_dgram.c:1520:
        # 000003FFB86757C0:error:8000000B:system library:dgram_recvmmsg:Resource temporarily unavailable:crypto/bio/bss_dgram.c:1520:
        # 000003FFB86757C0:error:8000000B:system library:dgram_recvmmsg:Resource temporarily unavailable:crypto/bio/bss_dgram.c:1520:
        # OPENSSL_TEST_RAND_ORDER=1690748376
        not ok 4 - iteration 4
    # OPENSSL_TEST_RAND_ORDER=1690748376

Note that we run with make HARNESS_JOBS=$(nproc) test, i.e. run the tests concurrently. This has often caused trouble with testcases that are not prepared to run concurrent....

Before I look into giving you some sort of SSH access, perhaps there's a more verbose or modified test I can run on your behalf? The test seems to always succeed under ktrace. There's some sort of race condition in the test that tracing it suppresses.

Yeah, it's a race condition of some kind. Unfortunately there is no real verbose logging available for this sort of thing right now, which is something we have planned in future. I don't really have a better way to diagnose it than interactively with a shell.

Note that we run with make HARNESS_JOBS=$(nproc) test, i.e. run the tests concurrently. This has often caused trouble with testcases that are not prepared to run concurrent....

HARNESS_JOBS runs separate tests concurrently, it doesn't affect the behaviour of an individual test binary. So it shouldn't in principle be disruptive to multiple tests running concurrently here.
I seem to recall IBM has some kind of developer access program for s390x?

We run the whole OpenSSL test suite in about 11 systems every night, and that test fails on 3-4 systems every night. However, when I manually run the test I can't get it to fail..... I don't know what triggers the failure.

I seem to recall IBM has some kind of developer access program for s390x?

You may try this one:
https://linuxone.cloud.marist.edu/#/register?flag=VM
or if you rather want a permanent server, then this one:
https://www.ibm.com/community/z/open-source/virtual-machines-request/

In tonight's run it did not fail!
Could this be due to the QUIC related commits that where merged yesterday?

In tonight's run it did not fail! Could this be due to the QUIC related commits that where merged yesterday?

Minor issues are always being fixed in each QUIC PR, so it's entirely possible.

That's what I normally see, yes.


Fix/rac 4.1 update

Thanks for the updates, much appreciated :-)

@ColinEberhardt No problem! This has inspired me to write a ReactiveTwitterSearch of my own after lessons learned from your project, and others alike.


Passing through arguments yields Swift compiler error

PromiseKit version: 3.5.3
Xcode version: 8.2.1 Swift 2.3

createChannel([selectedUser!.userID!]).then { channelId in
     // I need to be able to pass 'channelId' to the next .then {} block below.
     return retrieveMessagesForChat(channelId).then { (channelId, $0) }
}.then { channelId, messages -> Void in
     let controller = ...
     controller.messages = messages
     controller.user = selectedUser!
     controller.chat = JXChatModel()
     controller.chat.id = channelId // <- Needed here.
     self.navigationController?.pushViewController(controller, animated: true)
}

I followed the example given on the FAQ page.
However, clang gives the following error:
Contextual closure type '(AnyObject?) -> AnyPromise' expects 1 argument, but 2 were used in the closure body.

This error happens on the following line:
}.then { channelId, messages -> Void in

I am not sure how to fix this. Any help would be appreciated!
Thank you,
David.

Swift gives spurious error messages when errors happen in closures. Chances are the error is actually in the code inside the closure.
Split the code out into its own function:
func containingFunc() {
func foo(_ channelId: _, _ messages: _) {
    let controller = ...
    controller.messages = messages
    controller.user = selectedUser!
    controller.chat = JXChatModel()
    controller.chat.id = channelId // <- Needed here.
    self.navigationController?.pushViewController(controller, animated: true)
}

createChannel([selectedUser!.userID!]).then { channelId in
     // I need to be able to pass 'channelId' to the next .then {} block below.
     return retrieveMessagesForChat(channelId).then { (channelId, $0) }
}.then {
    foo($0, $1)
}

}


First step for ModuleConcatenationPlugin support

Refine es2015 tests for webpack 3 changes
Test for ModuleConcatenationPlugin
Successfully cache modules that depend on modules in a Concatenated Module

This support allows previously cacheable modules and modules depending on ConcatenatedModules to be cached to disk in webpack 3. More follow up work will give full support for caching module outside and inside a ConcatenatedModule.

First step for #142


CSS issue in teacher activity

After the students are loaded in the student pane, the students heading overlaps the search box.

Which browser are you using? I cannot reproduce it with Firefox (62) nor Chrome (69).

You need a long list of students to reproduce this bug AFAIK.


fix: grounded volume

Purpose

increase volume of !grounded

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

Thanks for helping with this @lukeocodes 👍 (Sorry it took a while to get to)

I'll let you off :)


missing wheel dependency

Cookiecutter version: 1.4.0
Template project url:
Python version: 3.5.2
Operating System: debian sid

Description:
Installing cookiecutter from a freshly created python 3.5 virtualenv fails for me. Installing wheel fixes the issue.
What I've run:
$ pyvenv-3-5 venv35
$ . ./venv35/bin/activate
$ pip install cookiecutter
[...]
Building wheels for collected packages: click, future, chardet, arrow, MarkupSafe
  Running setup.py bdist_wheel for click ... error
  Complete output from command /home/rm/src/venv35/bin/python3.5 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-tqrkfu4i/click/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /tmp/tmpq0tsfvsapip-wheel- --python-tag cp35:
  usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
     or: -c --help [cmd1 cmd2 ...]
     or: -c --help-commands
     or: -c cmd --help

  error: invalid command 'bdist_wheel'

@xrmx this seems to be a problem of pip or setuptools.
please, try updating pip, setuptools wheel
first, load the virtualenv and after, run
pip install pip setuptools wheel -U

and try again install cookiecutter
pip install cookiecutter -U

The problem is that my virtualenv has pip but not wheel installed. And pip tries (wrongly?) to call the missing bdist_wheel when installing some requirements.
As written in the bug report installing wheel fixes the issue for me.
Said that wheel is not a requirement for pip's setup.py so we can't take it being there for granted. Since cookiecutter's  setup.py calls bdist_wheel itself in case of publish subcommand i think that adding wheel as requirement is the right thing to do though.

@xrmx apparently, wheel is required by setuptools https://github.com/pypa/setuptools/blob/master/setup.py#L187
I can not reproduce the error.
In my machine, pyvenv-3.5 create a virtualenv with a very old version of pip and setuptools.
after you create and load a new virtualenv with pyvenv-3.5, what is the output of:
python -c "import setuptools,pip;print('setuptools',setuptools.__version__,'\npip',pip.__version__);"

@luzfcb Here it is:
(fresh35) rm@rieux:~/src$ python -c "import setuptools,pip;print('setuptools',setuptools.__version__,'\npip',pip.__version__);"
setuptools 20.10.1
pip 8.1.2

Btw trying to debug with pypa people why my virtualenvs are borked.
@luzfcb I think we can close the bug, thanks for your help and sorry for the noise!


Can't build demo-transformer due to missing CompositionPlayer in CompositionPreviewActivity

Version
Media3 main branch
More version details
No response
Devices that reproduce the issue
All devices.
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
Run the demo: demo-transformer .
Expected result
Provide androidx.media3.transformer.CompositionPlayer.
Actual result
In CompositionPreviewActivity we can't import androidx.media3.transformer.CompositionPlayer since it's missing.
If CompositionPlayer is ready to be imported then make it public.
Media
Not applicable
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

The fix is already on the way

In the meantime, you could comment out CompositionPreviewActivity from the Manifest file and comment out the content of CompositionPreviewActivity. It should allow you to compile the demo app

Thanks.

Should be fixed now with the latest commit. Thank you for reporting the issue


Snapps Doc Page

Create a docs page for snarks (request from emre):
https://docs.google.com/document/d/1vNYzQ1OobMvMdnnr5NviADjSnI0PDu0ftHWeEKmrbRA/edit

no longer relevant


feat: ssrBuild flag in config env

Fixes #8835
Description
Adds a flag to apply conditional configuration depending on SSR build. This doesn't apply for SSR dev, as the config is shared for it.
Should we pass the value of config.build.ssr instead, so the user can also config depending on the SSR entry?
Edit: Blu said yes, it is now implemented as string | boolean 👍🏼

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Alternative for the API, defineConfig could receive a PartiallyResolvedConfig as the env. So instead of ssrBuild, it will be:
export default defineConfig(({ command, mode, build: { ssr }}) => {
  // ...
}

The issue that I see is that people without TS may be confused by using build as a flag as:
build ? ... : ..., or be confused if they use ssr alone which may seem to imply is also true for dev SSR.
So I prefer we keep the current ssrBuild API and a flat env.

Modified the PR so ssrBuild is boolean only as decided in the last team meeting.

There seems to be little usage for this feature. We opened a discussion to check if we should stabilize or deprecate it in Vite 5:

https://github.com/vitejs/vite/discussions/13809

Are you currently using this feature @Kingdutch?


Azure SQL Database Deployment - Print outputs not shown, even when set to verbose

Environment

Server - Azure Pipelines
Agent - Hosted VS2017

Issue Description

Task name - Azure SQL Database Deployment

Basically I want PRINT outputs from Invoke-Sqlcmd (which is used in case of "Inline SQL Script" and "SQL Script File") to show up in the log when -Verbose is provided.
Setting system.debug to True is not a real option.
Task logs
Nothing shows up between Invoke-Sqlcmd and Finishing but many PRINT outputs should be shown:
2019-02-04T08:23:05.7040752Z ##[section]Starting: Execute pre-deployment script
2019-02-04T08:23:05.7047737Z ==============================================================================
2019-02-04T08:23:05.7047887Z Task         : Azure SQL Database Deployment
2019-02-04T08:23:05.7047949Z Description  : Deploy Azure SQL DB using DACPAC or run scripts using SQLCMD
2019-02-04T08:23:05.7048046Z Version      : 1.2.9
2019-02-04T08:23:05.7048095Z Author       : Microsoft Corporation
2019-02-04T08:23:05.7048153Z Help         : More Information
2019-02-04T08:23:05.7048263Z ==============================================================================
2019-02-04T08:23:14.4480132Z Sql file: D:\a\r1\a\Foo\Database\PreDeployment.sql
2019-02-04T08:23:14.4481060Z Invoke-Sqlcmd -ServerInstance "foo.database.windows.net" -Database "Foo-Pre-Production" -Username "foo@bar"  -Password ******  -Inputfile "D:\a\r1\a\Foo\Database\PreDeployment.sql" -Verbose -ConnectionTimeout 120
2019-02-04T08:23:19.2047193Z ##[section]Finishing: Execute pre-deployment script

@timmkrause
In order to get debug logs (output of PRINT statement) in SQL script using SQL Azure Dacpac deployment task, it includes two steps:

Enabled release debug logs ( Add release variable system.debug with value true)
In additional arguments of task, provide -verbose.

E.g.
Enable release debug logs

Provide -verbose argument

Task output

As I just mentioned "setting system.debug to True is not a real option".
IMHO this should only be used in debugging scenarios because it makes the whole pipeline noisy.
What I want is fine-grained control over certain tasks. In these 2 scenarios:

When deploying a DACPAC I want to see the actual change script, I achieved this via /Diagnostics:True (Azure SQL Database Deployment task uses sqlpackage.exe) - This is working totally fine, sqlpackage forwards the additional output produced by /Diagnostics:True and I am able to see (besides other stuff) the change script.

When executing a script file (or an inline script) Invoke-Sqlcmd is used to achieve this task, my assumption was if I apply -Verbose to the Azure SQL Database Deployment task I am able to produce the same behavior as with sqlpackage and /Diagnostics:True which means that Invoke-Sqlcmd -Verbose logs should just be shown by the task.

At a minimum this is an inconsistent behavior if not to say a bug?
We will pretty likely move into the direction of calling Invoke-Sqlcmd -Verbose directly so that there is no instance in between which swallows these logs.

Agree with you over inconsistent behaviour for verbose logs across Dacpac deployment and Script execution.
We will surely look into this.

Sounds great, thank you!

I am having the same issue. Thanks for opening and solving this ticket!

Why?

PR - https://github.com/Microsoft/azure-pipelines-tasks/pull/9741

I'm not convinced this is resolved. I have tried a simple PRINT 'Hello World'; both inline and in a file and the only way of getting "Hello World" to appear in the release log is to set system.debug to "True" and as stated this is not a real option. Far too much noise.
Adding -Verbose appears to do nothing as well.
Below is the yaml
steps:
- task: SqlDacpacDeploymentOnMachineGroup@0
  displayName: 'Deploy using : !Config_ExecuteScriptByDevOps.sql'
  inputs:
    TaskType: sqlQuery
    SqlFile: '$(System.DefaultWorkingDirectory)\OOTB.Config.Database\Deploy\Publish\!Config_ExecuteScriptByDevOps.sql'
    ServerName: '$(SqlServer)'
    DatabaseName: '$(ConfigDatabaseName)'
    AuthScheme: sqlServerAuthentication
    SqlUsername: '$(SqlUserName)'
    SqlPassword: '$(SqlUserPassword)'
    AdditionalArgumentsSql: '-Verbose'

If there is anything I can check, change or confirm; I'm love to know.
Thanks.

I used sqlAdditionalArguments: '-verbose' and it worked fine for me. below is an example of what i used.
            - task: SqlAzureDacpacDeployment@1
              displayName: 'test'
              inputs:
                azureSubscription: "test"
                AuthenticationType: 'servicePrincipal'
                Servername: '$(ServerName)'
                DatabaseName: '$(DatabaseName)'
                deployType: 'SqlTask'
                SqlFile: 'test.sql'
                sqlAdditionalArguments: '-verbose'

I'm not convinced this is resolved. I have tried a simple PRINT 'Hello World'; both inline and in a file and the only way of getting "Hello World" to appear in the release log is to set system.debug to "True" and as stated this is not a real option. Far too much noise.
Adding -Verbose appears to do nothing as well. Below is the yaml
steps:
- task: SqlDacpacDeploymentOnMachineGroup@0
  displayName: 'Deploy using : !Config_ExecuteScriptByDevOps.sql'
  inputs:
    TaskType: sqlQuery
    SqlFile: '$(System.DefaultWorkingDirectory)\OOTB.Config.Database\Deploy\Publish\!Config_ExecuteScriptByDevOps.sql'
    ServerName: '$(SqlServer)'
    DatabaseName: '$(ConfigDatabaseName)'
    AuthScheme: sqlServerAuthentication
    SqlUsername: '$(SqlUserName)'
    SqlPassword: '$(SqlUserPassword)'
    AdditionalArgumentsSql: '-Verbose'

If there is anything I can check, change or confirm; I'm love to know. Thanks.

Thank you so much! This is the answer that I was looking for! It is very confusing because I was expecting there to be verbose output but couldn't see it and would never have guessed to set system.debug true.
I agree that this is inconsistent behaviour and needs aligning.


Emails are recognized as URLs

Hi,
we found that an email is wrongly partially recognized as a URL.
For ex<EMAIL_ADDRESS>will detect bar.com as a URL.
This is complicated as @ is allowed in URLs (but for now, they are not correctly handled:
For ex<EMAIL_ADDRESS>will only detect bar.com as a URL.
Not sure if it's possible to do within the regex ?

Tagging onto this, this library almost met my needs, except it failed on matching a mailto: uri, as noted here. Support for mailto would be great.

It would be great if this library could detect mailto pattern as well. thank you.


Allow to change the url jwks.json.

I use your bundle against our own JWT provider.
In the bundle, the url for retrieving the jwks is hard coded with the value .well-known/jwks.json
But the url for retrieving jwks on our provider is /.well-known/openid-configuration/jwks.
How can I configure this value with what I need?

@waldo2188 - Thanks for the report here. That's actually hard-coded into the PHP SDK, which this bundle relies on. I'm not seeing any way to configure that at all currently but I will add that as an issue in the SDK and see if we can find a fix here.
If you have control over the JWKS URL, can you add a redirect from .well-known/jwks.json to .well-known/openid-configuration/jwks?

That's my problem, I can't change or add a redirect to this URL. So for now, I have change the URL directly in the PHP SDK. I know it's not a good things to do, but it works.
Thanks for your reply.


Protobuf unmarshal behavior

I have a proto file as this
syntax = "proto2";

package unmarshal;
message SomeEvent {
    optional SomeData data = 1;
}

message SomeData {
    repeated SomeField fields = 1;
}

message SomeField {
    optional string name = 1;
    optional string old = 2;
    optional string new = 3;
}

And I have some logic as follows:
package main

import (
	"fmt"

	pb "example/proto_unmarshal/gen/go/test.pb"
	"github.com/golang/protobuf/proto"
)

func main() {

	event := &pb.SomeEvent{
		Data: &pb.SomeData{
			Fields: []*pb.SomeField{
				{
					Name: proto.String("rick"),
				},
				{
					Name: proto.String("morty"),
				},
			},
		},
	}

	eventToMarshal := &pb.SomeEvent{
		Data: &pb.SomeData{
			Fields: []*pb.SomeField{
				{
					Name: proto.String("summer"),
				},
			},
		},
	}

	marshaled, err := eventToMarshal.Marshal()

	err = event.Unmarshal(marshaled)
	if err != nil {
		panic("Unmarshal error")
	}

	fmt.Println(event)
}

The output I get is :
data:<fields:<name:"rick" > fields:<name:"morty" > fields:<name:"summer" > >

My question being why is unmarshalling appending to the existing fields?
Is this expected behavior?
If yes, this seems unintuitive.
Or is this not how unmarshall is supposed to be used? If so, can someone point me to good examples?

I use a company wrapper around protoc. I will ask them about this. Thanks for the clarification!


[Bug] opening chests with free chest hack doesnt save when reopening gd

Describe the bug
when i use the "free chest" hack and i open some chests, i get the items right? well when i close and reopen gd it undoes all the chest opening i did
To Reproduce
Use "free chest" to open a chest, close and reopen gd, the chest you opened will now be closed and whatever you got from it will be gone
Expected behavior
For me to keep the items that i got from the chest
Screenshots
If applicable, add screenshots to help explain your problem.

duplicate of #14

oh thanks


[WEB] Sourcemap warning

Package version: 2.7.0
React Native version: 0.71.3
Expo version: 48

When running npx expo web the app starts and works as expected, but the terminal is full of these warning:

Only happens when using on the web. iOS and Android doesn't show any warning.

sorry, no idea why that is happening. If you can debug this and figure out what's wrong, I'd appreciate a PR!

It can be fixed by upgrading bob, I just did all my own libraries

PR: https://github.com/mrousavy/react-native-mmkv/pull/529

https://github.com/expo/expo/issues/21276

Hi @victorwpbastos  I had the same issues solve it  by upgrading react-native-build-bob as @RichardLindhout mentioned plus manually copying of https://github.com/mrousavy/react-native-mmkv/tree/master/src to  node_modules/...mmkv/src

PR is merged! @mrousavy could you do a release?

Done! 2.8.0 is out, which also includes support for id on web! 🎉

@mrousavy did you run yarn install before release? The warning is still there

hi @RichardLindhout from my understanding the error is related to the fact that the src folder doesn't exist
as you can see in the images below

@0x10Ayoub Ah that could be it, in my libraries it was the upgrade to bob which was fixing this error but indeed I think the src needs to be there too :)

@mrousavy any chance you could publish the library with the src directory inside npm?

I see you already committed a fix, but it is not released yet :)

yea

@mrousavy Hi. I still don't the release published. Will it take time?


Connection difference between 9.6 and others

Hi,
I have some issues to connect to database with original docker image in version 9.6, not with the others.
Difference:
In 9.5, "cat /var/lib/postgresql/data/postgresql.conf | grep listen":
listen_addresses = '*'

In 9.6, "cat /var/lib/postgresql/data/postgresql.conf | grep listen":
#listen_addresses = 'localhost'

With this config, only localhost can connect on the database 9.6, is this normal ?
PS: In version 10, I can connect with original Dokerfile receipe too.

I can't seem to reproduce: :confused:
$ docker pull postgres:9.5
9.5: Pulling from library/postgres
Digest: sha256:888b62ebb1265a7df59258fa22227e707faa2b39d9abfe2a1d6f9e3cd5936468
Status: Image is up to date for postgres:9.5

$ docker run -dit --name test postgres:9.5
b1353cbf79cd38590f7e3a6ff9da6cf3aed893f87a077e4d8e8ef3c448e91bf1

$ docker exec -it test grep listen /var/lib/postgresql/data/postgresql.conf
listen_addresses = '*'

$ docker pull postgres:9.6
9.6: Pulling from library/postgres
Digest: sha256:8df3344385deb0d5d781c442b2e275f7c321d601652d6317ce25ed8ffad03427
Status: Image is up to date for postgres:9.6

$ docker run -dit --name test postgres:9.6
12bff35bf9942bd7a7d3ce73e91f142c346a2f6895048cd569ada155a5a31bdb

$ docker exec -it test grep listen /var/lib/postgresql/data/postgresql.conf
listen_addresses = '*'

$ docker pull postgres:10
10: Pulling from library/postgres
Digest: sha256:d5787305ec0a3b9a24d0108cb5fdbb4befbd809f85639bf04aa1941138df9701
Status: Image is up to date for postgres:10

$ docker run -dit --name test postgres:10
0eba553132a1536b04ef2dc72c4a0cf273679c8c4dd28572463c77bb73581838

$ docker exec -it test grep listen /var/lib/postgresql/data/postgresql.conf
listen_addresses = '*'

We can close this issue, I found my problem.
In my recipe, I reinstalled a package that was already installed (postgres-contrib). This fact reconfigured all the postgres installation too.
I don't understand why but the reconfiguration only happened with version 9.6.
Sorry for inconvenience.


Improve labeling on Student Profile V2 Summary boxes

Attended today's Student Support Team meeting at the Healey school to observe how they used Student Insights. One thing I noticed:
A UI issue caused some confusion during the meeting. One student had an "Absences count" of 3 noted in her summary box at the top of the profile. The staff wanted to double-check that number and so they looked at the student's activity feed. There were many more than 3 absences in the activity feed. It wasn't clear to the staff that the "Absences count" listed at the top referred only to absences in the current school year, not overall number of absences.
Clearly labeling which values refer to current school year only would be helpful here. May also be useful to segment the activity feed events by school year, with headers for each school year. Finally, we may also want some kind of label for the spark lines to make it clear that they are all-time trends as opposed to the current-school-year-only figures directly above them.

Segmenting the feed events by school year should be done, I agree. It's #218.

#218 will be fixed when #399 is merged.

Note to self: we are now going with bar chart sparklines instead of arrows.

Closing this in favor of #593.


Bug: Making collection offer with new account doesn't work

https://www.loom.com/share/9b8164d4a5d54f249563061b0b5739be

I will close this and re-test once flow changes latest have been made


New simpler step router

By step router, do you mean the orthogonal router? If so, I would love to test it out.

I just ended up optimizing the current orthogonal one instead of creating a new one (which I should do, it will be a simple one).
Improved orthogonal router is 5x faster than the old one.


Data Formats?

I would like to know where we can find information on the data formats for these policies.
e.g. NetworkAccess_DoNotAllowAnonymousEnumerationOfSamAccountsAndShares
Is it an integer?  A string?  How do we find this out?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 773b74b2-7dc2-d0e5-1e3b-bd6445bceda4
Version Independent ID: 34b55057-9078-6bd0-a9ac-2f6403b84be7
Content: Policy CSP - LocalPoliciesSecurityOptions
Content Source: windows/client-management/mdm/policy-csp-localpoliciessecurityoptions.md
Product: w10
GitHub Login: @MariciaAlforque
Microsoft Alias: maricia

@officedocsbot assign @e0i

@BigIve
The issues section of this repository is intended for documentation and content related issues.
Please open a support ticket via the link below so that that your question gets answered quickly.
Windows 10 Support
Thank you.

@e0i,
This is a documentation question.  Or a lack thereof.  Because if the required documentation was in place I wouldn't need to be asking the question would I?  In general, the documentation for Intune based policies by Microsoft is horrendous, and I find it very annoying each time this is raised Microsoft does it's level best to avoid the questions.  The number of support tickets that are required to be raised to get to speak to someone who can provide basic formatting information for a published CSP is just ridiculous.  Looks like this repository is heading down the same useless path.
Thanks for your "help" with my question.

Per secpol.msc the InteractiveLogon_MachineInactivityLimit integer should be supplied in seconds. Please update your documentation accordingly.

Hello @BigIve
I would like to know where we can find information on the data formats for these policies. - it is available here
e.g. NetworkAccess_DoNotAllowAnonymousEnumerationOfSamAccountsAndShares Is it an integer? A string? How do we find this out? - it is integer, you can see it in the "DFFormat" section in the article I provided above.
I will add the note to the original article and add the link.
Thank you

@BigIve
With the help of your feedback, the content has been updated with relevant changes accordingly. Thanks.


Stuck creating ingress

Because the ingress isn't being made the kube-lego pod is stuck testing reachability of http://subdomain.domain.net/.well-known/acme-challenge/_selftest

kube-lego was creating a nginx ingress instead of gce - fixed

How did you direct kube-lego to create a GCE controller? I am experiencing the same issue right now.

Do you have:
    kubernetes.io/tls-acme: "true"
    kubernetes.io/ingress.class: "gce"

I did not have the kubernetes.io/ingress.class: "gce" annotation. Thank you.


Update community.md

Removing non-OSS providers

@brockallen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@brockallen Nice catch! Thank you for the fix.


feat: add --set-json flag to set json values.

When used with helm install, helm template, helm upgrade, it enables
to set json values (scalars/objects/arrays) from the command line.
Closes #10428
Signed-off-by: Luca Di Rocco<EMAIL_ADDRESS>What this PR does / why we need it:
This PR allows to set any key of the exposed values (scalars, objects, arrays) of a chart, by using a json value on the command line.
It become easier and more concise to update entire portions of the exposed values, as json data structures on command line, rather than setting the value of each individual leaf attribute of the data structure (#10428 provides an example)
Special notes for your reviewer:
The implementation has tried to reuse as much as possible the existing code and the standard libraries, and is quite straightforward.
There are some obvious changes in cmd/helm/flags.go and pkg/cli/values/options.go in order to include the new option flag (--set-json)
The parser logic from pkg/strvals/parser.go is reused, with an extra field in the parser struct (isjsonval bool, true only for --set-json) and some extra code in the following two functions, to parse a json value when a "=" char is met:
func (t *parser) key(data map[string]interface{}) (reterr error)
func (t *parser) listItem(list []interface{}, i int) ([]interface{}, error)
If applicable:

[X] this PR contains documentation
Little updates in the description constants of cmd/helm/install.go and cmd/helm/upgrade.go to.
Together with the info from cmd/helm/flags.go, this should update the documentation when "helm docs --type markdown --generate-headers" is executed.
[X] this PR contains unit tests
Some extra unit tests with function TestParseJSON in pkg/strvals/parser_test.go
[X] this PR has been tested for backwards compatibility
All unit test run, I don't know if something else is required. Being this a new feature, there are no changes in existing functionalities.
Please note that I had also to remove the ending new line '\n' from an errors.Errorf statement in the
func compare(actual []byte, filename string) error, in file ./internal/test/test.go, because go lint was failing and also tests were not running.

LGTM, but I'm not an approver.

@joejulian
Am I required to take any action (e.g. look for an approver)?
It's unclear to me what next a steps should be.
Can you please clarify?

LGTM, thanks @lucadirocco

Thank you @hickeyma

This need approval from another maintainer to merge.


i cant see all of a channel's playlists?

https://www.youtube.com/view_all_playlists
https://www.reddit.com/r/youtube/comments/b02wv8/i_cant_see_all_of_a_channels_playlists/

https://www.youtube.com/playlist?list=PLnpi2JbiKJNdrG7DrocwOPqUuC0MFFcCi
https://www.youtube.com/playlist?list=PLnpi2JbiKJNcLl-aUEL1fIV3SMnh07mVj


Feature request: Autogenerate a list of external references.

Web Bluetooth does a nice job presenting the terminology brought in from other specs: https://webbluetoothcg.github.io/web-bluetooth/#terminology (yay, @jyasskin!). I've done similar things in various WebAppSec specs (https://w3c.github.io/webappsec/specs/upgrade/#terms-defined-by-reference, for instance). Currently, these lists are lovingly hand-crafted, which is somewhat absurd. :)
@tabatkins: How would you feel about a patch to bikehsed that captured the references used to generate a document (probably by making ReferenceManager::getRef return a reference rather than a URL, and storing a de-duped list on the CSSSpec object (which we should totally rename to WebAppSecSpec or something :) )?

Heh, my list is a workaround for https://github.com/w3c/respec/issues/332 not being finished.

Yeah, this seems quite reasonable. Only problem is that there's no real mapping between anchor spec names and biblio entries; they should quite often coincide, but won't always.  Though I suppose we can generate at least a minimal biblio entry from the specs database when there's no match.  You could also supply a custom biblio entry if desired.
And yeah, CSSSpec is one of the few remaining things pointing out that I clearly designed this for the CSSWG at first. ^_^

Closing this, since the PR was merged.
Also: just landed the ability to auto-generate biblio entries from spec data, if the shortname isn't in the biblio data.  The spec data should match the autolink data, except for manually-added anchor data, so you should get all the biblio entries filling in now.


[CON] docs layout refactor

Description

This PR brings intended layout refactor related to #1887
Top level community nav link and sidebar.
More config references under reference.
Advanced section
Tutorial section

Remaining docs rewrite is coming in next PR

Checklist

[x] The base branch of this PR is dev, rather than main
[x] The relevant docs, if any, have been updated or created

Nice! Excited to take a closer look later today!

@TyDunn also should take a look

@priyashpatil Thanks for putting all of the work in here—I'm starting with some initial feedback on the copy within the pages. I know Ty also wants to spend some more time reviewing structure and adding his 2 cents, so can we pause on the next parts of work that you have planned until we have that ironed out? Want to avoid you doing duplicate work

@priyashpatil Thanks for putting all of the work in here! I'm starting with some initial feedback on the copy within the pages. I know Ty also wants to spend some more time reviewing structure and adding his 2 cents, so can we pause on the next parts of work that you have planned until we have that ironed out? Want to avoid you doing duplicate work

Yep works. 👍

Cool, thanks. I do think we're probably going to want to take on writing most of the docs language ourselves, largely because this is such a core part of Continue. Will share updates later next week!

@priyashpatil FYI we've now moved the docs work which was inspired by this over to the docs-refactor branch and are approaching a PR soon! Going to close this so we can focus on having it all in one place


ON clicking share my profile user id is not copied to clipboard

user id should also be there in the url.

It cannot be in url because we are not fetching our data again when we go to our profile , but we can give the id in the share button


Make PackageRevision's metadata.uid field unique

The .metadata.uid field of PackageRevisions are  simply created from  the name and revision of the package. It is not unique in the whole cluster, because it doesn't contain the name of the registry or the namespace.
Fixes https://github.com/nephio-project/nephio/issues/748
Based on #57

/retest

/retest

/approve
/lgtm


🐞 Refresh on dashboard goes back and forth between dash and login

Since the profile and session context are null on first load, the user is redirected to login. Then the context is filled and they are redirected back to dashboard. On good connection this is not noticeable, but it is less than ideal. We should wait for the context to be filled before deciding on navigation. Not sure if we need to store the context in localStorage or can just add a bit of delay to resolve this.

Closed by #666


Filter driver missing in illustrates

The Filter driver is not shown in the illustration.
Also this illustration may should also be copied to or at least linked to from:

NDIS driver types - Windows drivers | Microsoft Docs https://docs.microsoft.com/en-us/windows-hardware/drivers/network/ndis-drivers
Introduction to Network Drivers - Windows drivers | Microsoft Docs https://docs.microsoft.com/en-us/windows-hardware/drivers/network/introduction-to-network-drivers

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0510b76-a16d-f571-82a6-7b94fcb0d153
Version Independent ID: 1f2ed947-ff5b-7eec-5060-404baaaff33e
Content: Intermediate drivers - Windows drivers
Content Source: windows-driver-docs-pr/network/ndis-intermediate-drivers.md
Product: windows-hardware
GitHub Login: @duncanmacmichael
Microsoft Alias: dumacmic

Hi @agowa338, thanks for the thoughtful feedback. Here's my take, which we can use as a starting point for discussion if you'd like.
For your first point: after examining this page, the pages to which you linked, and the Filter driver page, I think the diagrams are appropriate as-is. Intermediate drivers sit between protocol drivers and miniport drivers and act as both, hence including all three in the illustration for intermediate drivers. Filter drivers are a lighter-weight alternative to intermediates and are independent of them. Technically, either page's illustration could include the other, but it isn't necessary to understand how each one works.
For your second point, perhaps you are looking for more of an overall diagram that shows all the driver types, like on the NDIS Driver Stack topic. But, I can certainly link to there from these individual pages if you think that would help.
What do you think?

LGTM.

@agowa338 Great, thanks for the feedback! I'll go ahead and close this issue, then.


Move 'Spin CLI' from 'Guides' to 'Reference'

The information under 'Guides' is more persona-focused rather than component-focused. 'Reference' seems a better place for that?
/cc @jtk54

Yeah, if I can split the referency stuff from the how-to stuff without making it too much work to use the separated docs, then I'll do that. Else I'll either keep it where it is or move it wholesale, depending on how I feel after spending some time analyzing it.
@demobox Note that I'm thinking of this based on what types of content should go in a reference, rather than the model of what types of content we have in there now. (For example, all our Halyard docs are in reference—not just the command reference.)

A lot of the content under Spin CLI are how-to(s)

Hm...would this split makes sense?

Install and Configure Spin CLI to Reference
Manage Applications and Manage Pipelines overviews to Reference
Other "How To" sections to User How-Tos with titles such as "Manage Applications via the CLI"? Or include in appropriate existing articles?

Install & configure doesn't feel like reference material to me, given that all other install & configure lives in Setup.
Manage Applications & Pipelines feels more like a guide, depending on how user-focused it is.

What seems referencey is the config material: /.spin/config. One could also make reference content from the commands themselves. But they way it's written now ("Managing your application's lifecycle," "Delete a single application with delete") it's more of a guide. That is, how do I do ______? rather than how does the _______ command work?
The way I feel about it right now, I think it should all remain in guides, but in time we should create a command reference.

@demobox
See #1390
Point taken about the content in the Overview sections of the user-guide topics, because those include some referency material. They're presented in the context of guide instructions, though, so keeping them there for now.
Mean time, I've moved the setup to /setup/, per above PR.

#1390


[eas-cli] use correct method to determine android application identifier

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary.
[ ] I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why
use the correct method to determine android application identifier, more details: https://github.com/expo/eas-cli/pull/427#discussion_r640438388
Test Plan

[ ] current tests still pass

I'll merge this so it's included in the next release.


Preview feature feedback: migrate diff & db execute

Please share your feedback about the new Preview migrate diff & db execute commands released in v3.9.0 in this issue.

If you encounter a bug, please open a bug report in this repo.
If the feature is working well for you, please share this in a comment below or leave a :+1: on this issue.

If you have any questions, don't hesitate to ask them in the #product-feedback channel in the Prisma Slack.

I guess this potentially closes #9707 😺

Is it possible to execute multiple SQL files by a single prisma db execute command? None of the following methods work:
prisma db execute --preview-feature --schema ./prisma/schema.prisma --file ./prisma/views/*.sql
prisma db execute --preview-feature --schema ./prisma/schema.prisma --file "./prisma/views/view1.sql:./prisma/views/view2.sql"
prisma db execute --preview-feature --schema ./prisma/schema.prisma --file ./prisma/views/view1.sql --file ./prisma/views/view2.sql

@livthomas No only one file can be provided here to --file at the moment. So you would need to call db execute for each file.
What's are you trying to do here?, I'm curious to understand your need/workflow/context, so we can take this feedback in for a potential improvement.
Also, if you provide multiple files, what are your expectations? (Do you expect files to run in a specific order?, for example)

@Jolg42 What I'm trying to do is to create database views in a seed command since Prisma doesn't support views at the moment (see #678).
I previously used prisma.$executeRaw which required me to have all the queries inside a TS file. With this new db execute command, I can have the views defined in separate SQL files which is much better.
The only thing that could be improved is an ability to execute all of them in a single command. I guess it would even be faster because of the overhead around connecting to a database, etc.

@Jolg42 And to answer your last question: If it was possible to execute multiple SQL files in a single db execute command, I would definitely expect them to be executed in the specified order. Although the order is not really important in this particular use case (when creating views).

Thanks! This is great feedback, I'll share that with the team.

In the "Moving forwards and applying missing changes" section you say:

You need to either alter or delete the offending rows.

Does this imply that you then issue manual commands to alter or delete the offending rows before proceeding to prisma migrate diff step?  I would never do this on a production database.
What if you realized ahead of time that this conflict would exist and you want to address it preemptively as part of the migration.  In other db migration tools, I would add code/script to to fix up the data prior to applying the new constraint.  How would this be supported in Prisma?

Hi @blevine  — since the migrations from migrate are arbitrary SQL, you can totally do that preemptively in the migration. The best practice is usually to keep schema and data migrations separated, but if it's more convenient, nothing prevents altering / sanity-checking the data from inside your schema migrations.

This is an awesome feature, especially for teams using Prisma as part of a CI/CD pipeline.
My team's use case is deploying to a PostgreSQL database within an Azure environment. When we want to run migrations against the database, it's something I normally have to do manually from my computer. I would love to make migrations part of our deploy process, however I want to have our database get all database changes in addition to migration history. I know I could just execute the SQL file against the database, but again I lose out on changing internal Prisma tables to know what migrations have been applied (and what their statuses are).
It would be great for this command (or another one) to generate an SQL file which would also include any updates to tables used to track migrations - That way the SQL file could be executed as part of a CI/CD process with different security provisions (virtual networks, authentication). Right now I'm not able to simultaneously authenticate with Azure and run the migration in an automated environment - I can only do one or the other.

Hey Shea - thanks for the detailed feedback! I have some follow up questions to fully understand your need if you don't mind 😊

My team's use case is deploying to a PostgreSQL database within an Azure environment. When we want to run migrations against the database, it's something I normally have to do manually from my computer.

Could you elaborate why you can't apply migrations in CI/CD. Did you consider using migrate deploy in CI?

I would love to make migrations part of our deploy process, however I want to have our database get all database changes in addition to migration history. I know I could just execute the SQL file against the database, but again I lose out on changing internal Prisma tables to know what migrations have been applied (and what their statuses are).
It would be great for this command (or another one) to generate an SQL file which would also include any updates to tables used to track migrations - That way the SQL file could be executed as part of a CI/CD process with different security provisions (virtual networks, authentication). Right now I'm not able to simultaneously authenticate with Azure and run the migration in an automated environment - I can only do one or the other.

Are you asking for a way to use the output from migrate diff as part of a normal migrations workflow (e.g. new file in migrations folder and after file is applied to the database also the table managing the migrations gets updated?
If easier, we could also hop on a call. You could email me at "loelhoeffel at our domain" so we can coordinate.

Thank you for reaching out to me! I will send you an email soon :)

Thank you for the reply!

Could you elaborate why you can't apply migrations in CI/CD. Did you consider using migrate deploy in CI?

Our database exists within a virtual network in Azure's infrastructure. I haven't found a great way to create a CI/CD pipeline that also authenticates with a virtual network in order to facilitate connections. I could create a virtual machine for the sole purpose of CI/CD, but that might be overkill and potentially expensive for just migrating. (It might not be either of those things - it could be easier! But I've fought with it for a while and haven't found a great solution here.) If I had access to a single SQL file that took care of everything, I could execute it with something like this: https://github.com/Azure/sql-action

Are you asking for a way to use the output from migrate diff as part of a normal migrations workflow (e.g. new file in migrations folder and after file is applied to the database also the table managing the migrations gets updated?

Something like that - I want to perform the entire migration in a situation where access to the CLI may not be possible, but access to the database would be (within a vnet or some other mechanism for executing SQL)

@SheaBelsky would programmatic access in node work? E.g. the ability to run migrate.deploy() from within your app code?

It would be good if the migrations diff command would fallback to existing information specified in package.json / the schema file. For example, instead of
prisma migrate diff --preview-feature
      --from-migrations <path to migrations>
      --to-schema-datamodel <path to schema>
      --shadow-database-url <database connection string>

on should be able to run prisma migrate diff --preview-feature --from-migrations --to-schema-datamodel, which then takes the migration and schema location from the package.json, and the database url from the schema file.

Sure! I think this is a good approach.

You mention in your shortened example that the url is taken from the schema but the --to-schema-datamodel option would actually not take the url but the datamodel from the file.

Sorry for being imprecise. The path to the schema (the arg to --to-schema-datamodel) should be taken from package.json, while --shadow-database-url should fallback to the url specified in the schema file.

@tobiasdiez: I think you should split that out into a feature request, so we can tackle this later - when we have more confidence as @do4gr mentioned. Thanks.


issue with cancel_order()

Hello,
I am afraid I do not know how to use cancel_order function. I tried the following and it seems it didn't work.
get_order_orders did return an object and cancel_order needs a str which is not what is returned by get_open_orders
orderid = get_open_orders(security)
cancel_order(orderid)

hi weiyiw0816,
I believe the answer to you question is in the Readme page... however, it's possible that it's not clear enough:
when retrieving open orders for specific security, you will receive an array of order objects, you will need to loop through the array, identify the order you want to cancel and use the id of the order to cancel it.
Something like the following:
Retrieve all open orders by security
open_orders = get_open_orders(security)
for open_order in open_orders:
    log.info("AAPL open_order=%s" % open_order)
    cancel_order(open_order.id)

within the for loop, you may do some conditions on different properties of the order object (look at the readme file to see all the properties) to identify which order you would like to cancel... you may want to cancel all open orders, in that case the above sample code will do the trick.
Regards,
CodeSociety


Reset changes

I needed the following changes to build the simulator:
https://github.com/lowRISC/ibex-demo-system/pull/97

Observations, not intended to be addressed at this stage:

rst_ctrl perhaps deserves to be integrated into ibex_demo_system, since
it will need to be common to all FPGA targets
it would be quite nice to have Ibex be capable of resetting the system under sw ctrl, if it cannot already reset itself
JTAG/DMI will perhaps want to reset the entire design rather than just the Ibex core
in time, at least for Sonata, we shall have multiple clocks and rst_ctrl should preferably count on the slowest clock
there will be resets to multiple clocking domains; necessary to ensure that peripherals are reset when software is downloaded

I mention these just for consideration going forwards, with both the Ibex Demo and Sonata Systems.

My last force push was a rebase on top of main.


Expand battle logs functionality

Related to #152

Track health of players
Display battle UI (health, portraits, etc.)
Track jutsu names / effects?
Changes for combat update?

Expand limit for history based on seal (20->30)?

Move Battle History into its own tab within View Battles

@aumu1031
I know you've been putting a lot of work into this feature. Has any of this been incorporated with the most recent logs update?

Yep this can be closed.

@aumu1031 I know you've been putting a lot of work into this feature. Has any of this been incorporated with the most recent logs update?

Yep can be closed.


Indeterminant linear system detected while working near variable

Hello,
Firstly thank you for making this package.
Describe the bug
I'm trying to run the ROS2 package without IMU. Seeing the error in global optimization as described below.
To Reproduce
Set IMU to false and use the CPU method instead of GPU
Expected behavior
Error should not come
Screenshots

Environment (please complete the following information):

CPU/GPU: 12th Gen i7
OS: Ubuntu 22.04
ROS: ROS2 Humble
CUDA: None

That error happens when IMU is disabled and there is absolutely no overlap between submaps. Please try the following configuration that force creating odometry-based relative pose constraints to make the system well constrained.
config_global_mapping_gpu.json :

create_between_factors : true
between_registration_type : NONE

https://github.com/koide3/glim/blob/64a98d8ce59e83e07ae59e7765e656b677296c60/config/config_global_mapping_gpu.json#L33

I'm getting a similar error, and I have IMU.
What could be the issue?

I run into the same issue with the data you provide -- os1_128_01.
Reprodue: set IMU to true and use the CPU method instead of GPU

Hi @koide3,
I'm using the CPU only method for now as I don't have GPU on the robot.
Having overlap between submaps is understandable. Is it possible to integrate wheel odometry in the factor graph to handle this? I have really good wheel odometry and it's updated at 30 Hz

Can anybody share a bag file with me to reproduce and fix the issue?

Can anybody share a bag file with me to reproduce and fix the issue?

I completely forgot to send!
I'll send you one tomorrow 😅😅😅

@koide3
Sent you the dataset to your email!
Bare in mind my dataset is quite long :sweat_smile: - there are 5 rosbags that needs to be played in order, using glim_rosbag. On the 4th rosbag, the reconstruction starts to break, despite good LiDAR overlaps and IMU sensor being present.
The error from GTSAM disappears when I used global mapping with pose_graph instead of just gpu.

@changh95
Thanks a lot for providing the rosbags! These were really helpful to find the cause of the issue.
I found that the issue stems from a long trajectory without loops that causes a numerical stability issue in global optimization.
I added a mechanism to fix the factor graph when an indeterminant linear system is detected.
I would be glad if you could check if the patch https://github.com/koide3/glim/pull/92 fixes the issue on your side.
I'm also trying to add a few mechanisms to further improve the stability of global mapping, and they will soon be added to https://github.com/koide3/glim/pull/92.

@koide3
Tested the code on my side (the same rosbag I sent you).
It works nicely!
The code can deal with the exceptions rising, and the factor graph management resets the state. With this, GLIM can go all the way to the end of the data sequence. :+1:


Implement basic klient identification for server side security

To use some request unique identifier which can be verified on server side.

implemented with this algorithm:
c = BASE64(MD5("device id" + "position date/time in format yyyy-MM-dd'T'HH:mm:ss" + "user defined security string"))
Strings are UTF-8 encoded


cleanup: remove crash handler

Fixes #4236
We will just remove the crash handler completely. It was not super useful for debugging, and our examples don't crash anymore.

This change is

Given that the examples throw, you might want to add the
int main(int argc, char* argv[]) try {
  ...
  return example.Run(argc, argv);
} catch (std::exception const& ex) {
  std::cerr << ex.what() << "\n";
  ::google::cloud::LogSink::Instance().Flush();
  return 1;
}

wrapping instead.

our examples don't crash anymore.

:-)

Given that the examples throw, you might want to add the /*code*/ wrapping instead.

Oops. Thanks.


Composer fails to finish

while running composer setup
composer setup
> composer install --ansi --no-dev

Error
> Illuminate\Foundation\ComposerScripts::postUpdate
> php artisan optimize
PHP Parse error:  syntax error, unexpected '->' (T_OBJECT_OPERATOR) in /var/lib/nginx/html/app/Console/Commands/RunTasks.php on line 70

  [Symfony\Component\Debug\Exception\FatalErrorException]
  syntax error, unexpected '->' (T_OBJECT_OPERATOR)

Script php artisan optimize handling the post-update-cmd event returned with error code 255
Script composer install --ansi --no-dev handling the setup event returned with error code 255

On Alpine Linux 3.4
php -v
PHP 5.6.26 (cli) (built: Sep 23 2016 14:47:01)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies

Confirmed on CentOS with 5.6.26
> Illuminate\Foundation\ComposerScripts::postUpdate
> php artisan optimize
PHP Parse error:  syntax error, unexpected '->' (T_OBJECT_OPERATOR) in /var/www/html/app/Console/Commands/RunTasks.php on line 70

  [Symfony\Component\Debug\Exception\FatalErrorException]
  syntax error, unexpected '->' (T_OBJECT_OPERATOR)

Script php artisan optimize handling the post-update-cmd event returned with error code 255
Script composer install --ansi --no-dev handling the setup event returned with error code 255

This can be fixed by removing the unnecessary brackets around Carbon::now() in the file mentioned in the error output (this worked for me yesterday at least).
Just change Line 70 in app/Console/Commands/RunTasks.php from
$tasks = Models\Task::where('queued', 0)->where('active', 1)->where('next_run', '<=', (Carbon::now())->toAtomString())->get();

to
$tasks = Models\Task::where('queued', 0)->where('active', 1)->where('next_run', '<=', Carbon::now()->toAtomString())->get();


Using ETWReloggerTraceEventSource to gather events just from a certain time start/stop doesn't include stacks

I wanted to use the relogger to gather all events that occur within a certain start/stop time in a trace and then write that to a new etl file.  What I found is that the stacks are not included (ex: CPU stacks).
using (var relogger = new ETWReloggerTraceEventSource(inputFileName, splitFileName))
{
relogger.AllEvents += delegate (TraceEvent data)
{
if (data.TimeStampRelativeMSec >= startTimeMS && data.TimeStampRelativeMSec <= endTimeMS)
{
relogger.WriteEvent(data);
}
};
            relogger.Process();
        };

I think that should work, but you need to add the rundown information and dynamic JIT compiled code events from earlier/later times as well + process start/stop events + Image ID events which were added during the merge step to get a working ETL file where symbols can be decoded.
Writing such a splitter is more complex than it looks at first glance. But I am pretty sure inside MS something exists. Could someone from MS make it public?
Such a capability would be a great addition to this tool: https://github.com/Siemens-Healthineers/ETWAnalyzer on which I am working.


Handle ".java" endings in directory names

Running utility I've got an error:
java.io.FileNotFoundException: /home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw6.java (Is a directory)/home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw5.java java.io.FileNotFoundException: /home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw5.java (Is a directory)/home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw3.java java.io.FileNotFoundException: /home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw3.java (Is a directory)
Problem occurs because probably utility thinks it is source java file but in fact it is a directory.

Good one! Thanks. I’ll take a look
Verstuurd vanaf mijn iPhone

Op 5 jun. 2019 om 13:45 heeft Mikhail Pravilov<EMAIL_ADDRESS>het volgende geschreven:
Running utility I've got an error:
java.io.FileNotFoundException: /home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw6.java (Is a directory)/home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw5.java java.io.FileNotFoundException: /home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw5.java (Is a directory)/home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw3.java java.io.FileNotFoundException: /home/mikhail/Documents/Development/java_hw_au_hse_dataset/hse-19/babushkin/hw3.java (Is a directory)
Problem occurs because probably utility thinks it is source java file but in fact it is a directory.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@RamSaw Fixed. Feel free to use the version in the branch for now.


Fix Pad Shape

Motivation
#10722
Modification
Fix the bug and add test
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make the custom UILabel a Cocoapods component.

Will you start a dedicated repository per cocoa component ?

Will do yep. But probably under my personal github for not polluting the ChessCorp main projects. What do you think @alcibiade ?

If think this makes sense as if I understand right, this component isn't at all chess-related but rather a generic component that you would use in chess-ios.

Exactly ! This is a simple UITextField with an animated placeholder. Nothing related to chess 😉
Check it out here


Migration doer is a participant in all conversations

Gitea version (or commit ref): 1.12.0+dev-212-g82a979707

Description
When a repository is migrated, the doer gets added as a participant of all issues and PRs. This seems very inconvenient regarding subscriptions and notifications. Perhaps there should be a way to add those posts and comments so that the migrator doesn't become irremediably subscribed to them.
Screenshots

@guillep2k Good catch!


[SR-11947] SPM using wrong name for linked library on linux?

Previous ID
SR-11947

Radar
rdar://problem/57888489

Original Reporter
rmann (JIRA User)

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Package Manager

Labels
Bug

Assignee
None

Priority
Medium

md5: 6cd95e507db6ba57eec9c2432d238bc2

Issue Description:
From my post on the forums: https://forums.swift.org/t/spm-using-wrong-name-for-linked-library-on-linux/31589
I made a ton of progress getting my Swift/SDL app working. Builds fine under SPM and Xcode on macOS, but on Linux I'm running into some issues. In particular, the way it's trying to link SDL2_ttf is wrong. That is, it should be linking against libSDL2_ttf, but instead it’s trying to link against libSDL2TTF. I can't actually find that string anywhere in my code, and pkg-config gives this:
$ pkg-config --cflags --libs sdl2_ttf
-D_REENTRANT -I/usr/local/include/SDL2 -I/opt/vc/include -I/opt/vc/include/interface/vcos/pthreads -I/opt/vc/include/interface/vmcs_host/linux -L/usr/local/lib -lSDL2_ttf -Wl,~~rpath,/usr/local/lib -Wl,~~-enable-new-dtags -lSDL2

But when Swift goes to link, it does:
$ swift build --verbose
lsb_release -r
uname
pkg-config --variable pc_path pkg-config
'CSDL2TTF' sdl2_ttf.pc: warning: non whitelisted flag(s): -D_REENTRANT, -Wl,~~rpath,/usr/local/lib, -Wl,~~-enable-new-dtags
'CSDL2' sdl2.pc: warning: non whitelisted flag(s): -D_REENTRANT, -Wl,~~rpath,/usr/local/lib, -Wl,~~-enable-new-dtags
/usr/local/swift/versions/5.1.1-armv7-DebianBuster/usr/bin/swiftc -sdk / -L/usr/local/lib -lSDL2_ttf -L/usr/local/lib -lSDL2 -L/usr/local/lib -lSDL2 -g -L /home/rmann/InfoDisplay/.build/armv7-unknown-linux-gnueabihf/debug -o /home/rmann/InfoDisplay/.build/armv7-unknown-linux-gnueabihf/debug/InfoDisplay -module-name InfoDisplay -emit-executable -Xlinker '-rpath=$ORIGIN' @/home/rmann/InfoDisplay/.build/armv7-unknown-linux-gnueabihf/debug/InfoDisplay.product/Objects.LinkFileList -target armv7-unknown-linux-gnueabihf -L /usr/local/swift/versions/5.1.1-armv7-DebianBuster/usr/lib
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
/usr/bin/ld.gold: error: cannot find -lSDL2TTF
clang: error: linker command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)

You can see more details here.
Here’s my Package.swift for the library:
// swift-tools-version:5.0
// The swift-tools-version declares the minimum version of Swift required to build this package.
import PackageDescription

let package = Package(
    name: "SDL",
    products: [
        .library(
            name: "SDL",
            targets: ["SDL"]),
        ],
    targets: [
        .target(
            name: "SDL",
            dependencies: ["CSDL2", "CSDL2TTF"]),
        .systemLibrary(
            name: "CSDL2",
            pkgConfig: "sdl2",
            providers: [
                .brew(["sdl2"]),
                .apt(["libsdl2-dev"])
            ]),
        .systemLibrary(
            name: "CSDL2TTF",
            pkgConfig: "sdl2_ttf",
            providers: [
                .brew(["sdl2_ttf"]),
                .apt(["libsdl2-ttf-dev"])
            ]),
        ],
    swiftLanguageVersions: [.v5]
)

I can’t figure out why it’s trying to do that. It’s finding SDL2 just fine.

I have had the same problem while trying to link libuvc. On Mac, it was fine linking to -luvc as pkg-config suggests but on Linux side, it was linking to -llibuvc. I've changed the line from  modulemap file from link "libuvc" to link "uvc" and it is linking the right library. It seems on linux side, it doesn't seem to be using pkg-config result for linking.


Secure Elasticsearch

This is not tested.
The new elasticsearch_host variable should be overridden in host-specific vars, and should be set to the internal IP address of the host.
These changes are based on Elasticsearch's blog post about the vulnerability.
@czue, @snopoke, buddies @calellowitz, @sravfeyn

thanks! i'm going to do some testing with this so put a don't merge on it. I think we are going to need to tweak it a bit since we need ES to be available on the VPN interface and not just localhost but the direction seems good.

@kaapstorm I reverted https://github.com/dimagi/commcarehq-ansible/commit/7afba087cb329e5ffa840840cdd28e94c77ea2a7 in favor of https://github.com/dimagi/commcarehq-ansible/pull/295/ but the other change is g2g