Distributions.Normal: results differ when calling static and non-static methods

Hi,
Tests reveal that the implementation of static and non-static methods of the class Distributions.Normal differ, i.e. for small percentile values - e.g. up to 7 standard deviations, the values returned by the static cdf method converge very/too quickly towards 0 whereas the non-static method returns a value which is small but larger than 0 and which also complies with the value returns by MS EXCEL.
A quick code inspection reveals that static and non-static Normal.CDF methods differ when they call ErfImpl. One is calling Erf and the other one is calling Erfc. From a pure theoretical point of view both implementations should provide the same output but in practice rounding issues kick in, i.e. even when using double precision, for small percentile values, i.e. 7 std deviations or smaller, 1 - epsilon = 1 when 0 + epsilon <> 0.
A quick way to fix this difference would be to use the same ErfImpl for static and non-static methods, i.e. remove the boolean from the ErfImpl and keep the code of the non-static method which provide the expected results, i.e. compliant with MS EXCEL up to MS EXCEL numerical precision.
What do you think ?

Yes, indeed, both should use the same implementation, and we should avoid such potentially fatal subtractions (similar to the classical exp(x)-1 case).
I'll have a look at it. Thanks for reporting this!

Fixed in master, thanks again.


Update RPC documentation for commands involving subaddresses

References #694.
Includes documentation and examples for new commands dealing with subaddresses.
Updates for existing commands that now deal with subaddresses. Some fields unrelated to subaddresses were missing, and are now included.

Thankyou for the thorough review @moneromooo-monero and @mattcode55 :+1:
Will make the requested changes, and update the PR.

Changes looks correct (but i'm not a dev). Could you copy the files in the other languages directory?
Then i could build and test before approving.

By the way, does this includes all the multisig-related commands?
I can see 12 times the multisig word here.
If so we should tell it solves #522

Changes looks correct (but i'm not a dev). Could you copy the files in the other languages directory?

@el00ruobuob I missed this part of the README, thank you for the reminder.

By the way, does this includes all the multisig-related commands?

This PR does not include all the multisig-related commands. Those commands I did update for multisig, also needed subaddress updates.
I don't really have a lot of time at the moment to add the missing commands in this PR. I'll leave the few multisig-related updates for whomever adds the multisig docs (maybe me).

I don't really have a lot of time at the moment to add the missing commands in this PR. I'll leave the few multisig-related updates for whomever adds the multisig docs (maybe me).

I'll do a full update of wallet RPC once this and #703 would be merged. I might ask you a few questions about them on #monero-dev at that time.

@coneiric could you remove the polish transalation from your PR? And also the template, to be compatible with the upcoming #744? And after that, i rebase would also be nice.
Sorry for asking that much, but i'm waiting for this to be merged on behalf of @rehrar to start working on the full refresh.

@el00ruobuob I can make the changes you requested, and rebase the commits. So, now the workflow will be to implement the changes in the contributor's native language, then copy to other localizations?
Rebasing will squash the separated commits, but if that's fine with reviewers, I'll do it.

@coneiric the exact workflow must be pointed out by @erciccione in an update of readme.md soon.
At least, we now need to remove the template as it does not longer exist. And I believe we should include updates of all untranslated version when updating English, just to keep them up to date.
I'm working on a versioning solution to help us handle this part.
Regarding the squash I think it's not an issue to have it done before reviews. Anyway @luigi1111 will ask you to do it before it's merged.

Regarding the squash I think it's not an issue to have it done before reviews.

Alright, all requested changes are pushed. If reviewers still would like the changes in their split-up version, I created a backup branch. The changes to the language localizations are simple copies of those split-up changes.

Appart from the untranslated snippet mentioned by @erciccione it's ok on the following platforms:
| Edge | IE 11 | Chrome | Firefox | Opera | Vivaldi
-- | -- | -- | -- | -- | -- | --
Windows 7 | - | OK | OK | OK | OK | OK
Windows 10 | OK | OK | OK | OK | OK | OK
Ubuntu 18.04 | - | - | OK | OK | OK | OK
CentOS 7 | - | - | - | OK | OK | OK

No more 'Untranslated' snippet on English version, thanks.
Builds perfectly.

You're welcome, glad it's working now :+1:

ping @rehrar & @luigi1111 Could we merge this?


ipset names must be different for ipv6 and ipv4 ipsets

ipv4 ipsets require family inet and ipv6 ipsets require family inet6
Therefore, we need to create different ipsets for each type of address. To do so, the SHA that is part of the ipset name needs to be different and thus, we should include the ipFamily to it.
At the end of pkg/controllers/netpol/policy.go, we should add the ipFamily parameter to the SHA calculation to the first three functions:
func networkPolicyChainName(namespace, policyName string, version string, ipFamily api.IPFamily) string {
        hash := sha256.Sum256([]byte(namespace + policyName + version + string(ipFamily)))
        encoded := base32.StdEncoding.EncodeToString(hash[:])
        return kubeNetworkPolicyChainPrefix + encoded[:16]
}

func policySourcePodIPSetName(namespace, policyName string, ipFamily api.IPFamily) string {
        hash := sha256.Sum256([]byte(namespace + policyName + string(ipFamily)))
        encoded := base32.StdEncoding.EncodeToString(hash[:])
        return kubeSourceIPSetPrefix + encoded[:16]
}

func policyDestinationPodIPSetName(namespace, policyName string, ipFamily api.IPFamily) string {
        hash := sha256.Sum256([]byte(namespace + policyName + string(ipFamily)))
        encoded := base32.StdEncoding.EncodeToString(hash[:])
        return kubeDestinationIPSetPrefix + encoded[:16]

Of course, the places where we are calling these functions must be changed to include ipFamily (it's pretty easy as all calls to those functions have access to ipFamily)

Fixed and pushed

You forgot to add + string(ipFamily))) to:

policySourcePodIPSetName
policyDestinationPodIPSetName

Fixed and pushed


Feat: Cloud gateways networking diagram

Description
Networking diagram and private vs public networks section on the dedicated cloud gateways page.
@Guaris do you think this would make more sense on the transit gateways page?
https://konghq.atlassian.net/browse/DOCU-3793
Testing instructions
Preview link: https://deploy-preview-7226--kongdocs.netlify.app/konnect/gateway-manager/dedicated-cloud-gateways/#private-vs-public-networks
Checklist

[x] Review label added
[x] Conditional version tags added, if applicable.

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).
Use any of the following keys:

gte:<version> - greater than or equal to a specific version
lte:<version> - less than or equal to a specific version
eq:<version> - exactly equal to a specific version

You can do the same for older versions.

This is awesome. I think putting it on the transit gateways doc makes sense. @lena-larionova


fix Elixir service binding not working

The codegen didn't convert Service into an id, cause user code cannot pass service as a Service struct.
Fixes #6091

@sipsma I rebased it. The lint task looks fine now.


Use buffered stream for keyring file read

Without this change, we get thousands of I/O read calls as the used library calls
InputStream#read() one byte at a time
Track trace:
java.io.FileInputStream.read(FileInputStream.java)
org.bouncycastle.bcpg.ArmoredInputStream.readIgnoreSpace()
org.bouncycastle.bcpg.ArmoredInputStream.read()
java.io.InputStream.read(InputStream.java:293)
java.io.BufferedInputStream.fill(BufferedInputStream.java:244)
java.io.BufferedInputStream.read(BufferedInputStream.java:263)
org.bouncycastle.bcpg.BCPGInputStream.nextPacketTag()
org.bouncycastle.openpgp.PGPKeyRing.readOptionalTrustPacket()
org.bouncycastle.openpgp.PGPKeyRing.readSignaturesAndTrust()
org.bouncycastle.openpgp.PGPPublicKeyRing.readSubkey()
org.bouncycastle.openpgp.PGPPublicKeyRing.()
org.bouncycastle.openpgp.PGPObjectFactory.nextObject()
org.bouncycastle.openpgp.PGPObjectFactory$1.getObject()
org.bouncycastle.openpgp.PGPObjectFactory$1.hasNext()
org.gradle.security.internal.SecuritySupport.loadKeyRingFile(SecuritySupport.java:111)

@bot-gradle test and merge

I've triggered a build for you.

Thank you Aurimas!
This will be in Gradle 8.1


reference implementation

This is sample implementation oа Combine promise.
I have some questions.
A Promise needs an unwrapped value for a Result. Неre you can see the unwrapping.
The callback, potentially, may have a (nil, nil) return. For that matter I added the last 'else' block.
Is there any "Generic"/Unknown error for that matter? Should I use that approach to complete the task or we are more into exceptions?
Is it what's expected from this task?

This should not be on master. Please point it to v10.

Thanks @jsflax. I need this only to ask some questions. I'll remove it.


chore: cleanup white space

:tada: This PR is included in version 2.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added Get Cluster list and Primary Cluster function with unit test co…

…verage

Are there integration tests for these two modules?

yes , in next PR i will raise other funcitons and test coverage

If the aim is to reduce the amount of code in a review I appreciate the motivation. However, that's a misguided way to split things up.
Tests should always accompany code. It can be good to separate functionality, for example - with the CRUD style PRs that we have they could be created like this:

First PR, create, and either get or list - some way to verify that the create worked.
Second PR, list or get - whichever one wasn't part of the first PR
Third PR, update (if possible)
Final PR, delete

Each PR should include comprehensive unit & functional tests for the operations in the PR.

I have raised another PR with IT coverage https://github.com/saltstack/salt-ext-modules-vmware/pull/251
But i need to discuss a scenario with you there before merging the PR
Creation of cluster takes long enough time,  so when it reaches to deletion step , the error is thrown
cluster is currently not in a state where it can be deleted. Please try once the status is READY or FAILED


ARM docker image issue

Hi Team,
I am trying to get the project for arm machine using docker,
codeplot-front The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested 0.0s
Attaching to codeplot-api-1, codeplot-front-1
codeplot-api-1    | exec /usr/local/bin/docker-entrypoint.sh: exec format error
codeplot-api-1 exited with code 1
Any other information needed, plz let know

Hey @raaghulr !
We now have ARM64 image support available on Docker Hub. Could you please verify this?
Thank you

Closing, since we already support ARM images.


Document and expand the open options

The options that can be passed to the os when opening a file vary between
systems. And even if the options seem the same or similar, there may be
unexpected corner cases.
This RFC attempts to

describe the different corner cases and behaviour of various operating
systems.
describe the intended behaviour and interaction of Rusts options.
remedy cross-platform inconsistencies.
suggest extra options to expose more platform-specific options.

rendered

@pitdicker Thanks so much for taking this on; it's clearly a huge amount of work! I'm excited to dig into the details and hope to leave feedback soon.

Sorry for making some more commits to the RFC, I am clearly an amateur...
I mainly found some more corner cases on Windows that have to do with .truncate(), and a lot of typos.
But this should be it.

Just a note about an issue I ran into today. Opening a path to a directory as a file has different results on different platforms, and should be documented also. I was only able to test UNIX, but the results on UNIX were:

Opening with read(true) and/or append(true) returned an Ok(File). Setting other options returned os error 21 (is a directory).
Calling metadata on that file successfully returned the metadata for that directory.
Calling the other file methods caused the program to abort on bad syscall.
Calling read() on a directory opened in read mode returned error 21 (is a directory).
Calling write() on a directory opened in append mode returned error 9 (bad file descriptor).

The documentation here is pretty extensive. Is it worth mentioning how create_new is the file option option for creating PID files on Unix? This is a really important option for systems programming which isn't available yet.
Also, wouldn't it be better to yield an error if people start mixing flags in broken ways? create(true).truncate(true).create_new(true) will just ignore create and truncate? Seems like a bug if they were all provided together.

@withoutboats, @ehiggs thanks for your comments!
@withoutboats
The combination op open() whith something that is not a file, is quite a hole in this rfc. Thanks for pointing it out.
@ehiggs
I feel a bit difficult for making .create(true).truncate(true).create_new(true) yield an error, as this RCF already indroduces serveral errors while there were none before :(.
So any extra errors should have a good reason.
In this case:
.create(true) and .create_new(true) can not both work together. One has to take precedence over the other, or this should return an error.
.create_new(true) and .truncate(true) are nonsensical. You can not open an existing file, but if you do, truncate it...
In this case I think it is best to return an error if .create_new(true) is combined with .create(true), instead of having the meaning of the code depend on a precendence rule in the documentation. And if we already disallow one combination, then also just disallow the nonsensical combination with .truncate(true) also.

.create_new(true) and .truncate(true) are nonsensical. You can not open an existing file, but if you do, truncate it...

IMO it can be thought about in a way that makes sense:

Open a file only if it does not exist (the create_new part). Truncate it (which is a no-op). The fact that truncate is a no-op does not make this combination nonsensical at all.

I think OpenOptions should always try to avoid erroring and try to do something intuitive.

@nagisa Yes, .create_new(true) and .truncate(true) can be ok, but what do you think about the combination of .create_new(true) and .create(true)?

It need not be an error, but could be a lint. I'll open an issue over at clippy for now.

Would be nice to somehow advance it since the discussion has stalled. Could it be possible to include into schedule of the next libs team meeting?

Yes, .create_new(true) and .truncate(true) can be ok, but what do you think about the combination of .create_new(true) and .create(true)?

I realised I never answered your question. I fear I’ve forgotten original point I wanted to do here. Here’s my current thoughts (that may or may not differ from whatever I said earlier):
In case where two options are mutually exclusive, it is always possible to encode that in the API by removing the possible intersection point. In case of create and create_new the intersection point would be (true, true) which could be reified by doing something along the lines of:
enum CreateType { Create, CreateNew, NopeNopeNope };
fn create(…, type: CreateType)…

However, since we are bound by stability guarantees, I guess simply panicking in the builder finalizer (the open method) is fine.

Just a heads-up: clippy now contains a nonsensical_open_option lint.

I don't see why the exact conflicting-options-behaviour (supercede, one takes priority...) matters as long as it is well documented.
Anyway, looks like an amazing API (from my semi-ignorant viewpoint). I'd offer to help with impl/testing (Linux) but it looks like you're way ahead of me.

Sorry for taking so look to get around to this @pitdicker, but it all looks great to me! It'd be nice to have a concise overview of the OS-specific extension traits in terms of what the APIs would look like, but I think it's also relatively easy to infer to it's not critical.
I agree with @nagisa and I'll try to bring this up soon at a libs team meeting to move into FCP.

Everyone thanks for the comments and persueing. Sorry for not doning this
myself, I got a bit distracted...
I have changed my opinion about 'no access mode set'. It does not really have
any use, and I think it is best to not allow it for now (conservative).
Also, I have rewritten the caching part of the rfc, put not yet pushed.
When I look at it now, it may be better to remove a some parts of the rfc.
What do you think, should the parts about file locking and caching be removed?

@llogiq I keep being amazed how much you can lint for! Very nice to see a nonsensical_open_option lint.

I'd be fine with no access mode == error, I think we'd definitely be able to expand that in the future to return success if an interesting case came up. I'd also be ok leaving the caching/file locking to a separate RFC, although ensuring there's design space for it is fine to mention (although with a builder-style thing we should be pretty set)

@pitdicker We haven't even made a dent in the surface of what can be linted. The nonsensical_open_options lint is actually quite simple.
Btw. if you see other APIs that have ambiguous or confusing API items, just file a clippy issue, no matter if you think it possible to lint or not.

@pitdicker I have no clue who would make use of the Windows-specific share mode. It replaces one set of problems with another, though I guess it would be nice to know writes wouldn't collide (if this could be done cross-platform).
Speaking of which, the atomic append operations appear to be limited in length. See here and specifically here. Anywhere from 256 bytes to 4k. Makes it useless for what I wanted to do, but anyway.

@dhardy I did some testing for the length of atomic append because of these posts, and did not find a limit. I think they found a limit because that language uses buffered IO or a pipe with a buffer.
That is why I put in the rfc to write all data in one operation, or "use a buffered writer with a more than adequately sized buffer".

@pitdicker great news. Sounds like it should be tested on a few different platforms still.

@llogiq: that's great news about the lint. My concern about nonsensical flags are basically solved. Thanks!

Well, in a perfect world, a lint wouldn't be needed, but when using the type system isn't possible (in this case because of backwards-compatibility), it's the best we can do.

:bell: This RFC is now entering its week-long final comment period :bell:

The libs team discussed this during triage today and the decision was to merge. @pitdicker would you be ok moving the sections about caching and such to alternatives as well? We were thinking that for now we may not want to dive into those domains but it's certainly possible in the future!

@alexcrichton Great news!
I have moved the sections about caching and file locking to the alternatives. Let me know if this is what you had in mind.

I have a local branch with most of the changes proposed by this rfc, but it is messy and I don't have time to clean it up before the Christmas holidays. If anyone wants to implement it, let me know. Maybe you can use it as a starting point...

Looks good to me, thanks @pitdicker! Feel free to send the PR whenever, and thanks so much again for the RFC!


System not rebooting if sudo is present and --extra-files is used

When using --extra-files, I've noticed that the system is not rebooting automatically after installation.
I think the installation is failing at the point where the extra files are copied across
https://github.com/nix-community/nixos-anywhere/blob/9ba099b2ead073e0801b863c880be03a981f2dd1/src/nixos-anywhere.sh#L580
Is maybeSudo supposed to be used here even in the kexec environment? As it's logging that the command cannot be found in the installer kexec environment.
Uninstalling sudo before running nixos-anywhere works fine.

Perfect timing, I was encountering the issue as well right now. Workaround also works for me as I log in root before kexec.

When using terraform all-in-one, this error is "flaky" - as in it occurs roughly 50% the time. I'm not sure why the error only occurs sometimes when I run terraform apply, and does not occur every time I run terraform apply.


feat(lvs): special error code for out-of-metadata condition

Previously, when a blob store ran out of free metadata page during volume creation, an ambigious ENOMEM error was returned. Now, in order to allow to have meaningful client-faced error message and codes, EMFILE is returned instead.
A test for a proper error when exceeding pool metadata capacity was added.
LVS errors refactored to eliminate the use of low-level Errno in high-level LVS code.
Low-level Errno codes from SPDK are now mapped to high-level error enum.
Several bugs in Errno conversion fixed in LVS code (negative vs positive errno in SPDK function return value).

bors try

This is a really awesome enhancement to SPDK.

We should consider contributing this upstream.

bors try

bors merge


x/crypto/ssh/agent: TestMalformedRequests/Short_body failures on darwin/arm64 since 2021-12-08

--- FAIL: TestMalformedRequests (60.00s)
    --- FAIL: TestMalformedRequests/Short_body (60.00s)
        client_test.go:230: ServeAgent returned expected error: read tcp <IP_ADDRESS>:60723-><IP_ADDRESS>:60727: read: connection reset by peer
2021/12/14 08:02:42 agent 23: agent: incorrect passphrase
FAIL
FAIL	golang.org/x/crypto/ssh/agent	60.279s

greplogs --dashboard -md -l -e 'FAIL: TestMalformedRequests'
2021-12-09T19:36:57-4570a08-de690c2/darwin-arm64-12_0-toothrot
2021-12-08T04:14:00-5770296-a19e72c/darwin-arm64-11_0-toothrot

This is a release-blocker via #11811.
Given the timing, it could be related to the fix for #49932 (CC @rolandshoemaker @julieqiu @katiehockman). Note that at least one of the failures is on release-branch.go1.17, so this does not appear to be a regression in Go 1.18 itself.

Checking in on this as a release-blocking issue. Are there any updates?


Driver.compileOfAst fails on Xamarin.Mac due to reference to .NET Core

I am trying to port my .NET IDE Continuous to macOS. Unfortunately, the latest F# compiler service is failing due to a type load exception with Microsoft.DotNet.DependencyManager.
It is importing the .NET Standard 2.0 version of "lib/netstandard2.0/FSharp.Compiler.Service.dll"
Ironically, this same package works fine on Xamarin.iOS with AOT.
My guess is this is a bug in the DependencyManager, but I would love to know if I can use the F# compiler without it. I swear I had this working on older versions. Is the DependencyManager new?
System.TypeLoadException: Could not load type of field 'Microsoft.DotNet.DependencyManager.AssemblyResolveHandlerCoreclr:handler' (1) due to: Could not resolve type with token 01000013 from typeref (expected class 'System.Runtime.Loader.AssemblyLoadContext' in assembly 'System.Runtime.Loader, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:System.Runtime.Loader, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Runtime.Loader.AssemblyLoadContext member:(null)
  at Microsoft.DotNet.DependencyManager.DependencyProvider..ctor (Microsoft.DotNet.DependencyManager.AssemblyResolutionProbe assemblyProbingPaths, Microsoft.DotNet.DependencyManager.NativeResolutionProbe nativeProbingRoots) [0x00014] in /Users/chethusk/oss/FCS/src/fsharp/Microsoft.DotNet.DependencyManager/DependencyProvider.fs:266
  at Microsoft.DotNet.DependencyManager.DependencyProvider..ctor (Microsoft.DotNet.DependencyManager.NativeResolutionProbe nativeProbingRoots) [0x00000] in /Users/chethusk/oss/FCS/src/fsharp/Microsoft.DotNet.DependencyManager/DependencyProvider.fs:325
  at FSharp.Compiler.CompileOps+TcConfigBuilder.CreateNew (FSharp.Compiler.ReferenceResolver+Resolver legacyReferenceResolver, System.String defaultFSharpBinariesDir, FSharp.Compiler.AbstractIL.ILBinaryReader+ReduceMemoryFlag reduceMemoryUsage, System.String implicitIncludeDir, System.Boolean isInteractive, System.Boolean isInvalidationSupported, FSharp.Compiler.CompileOps+CopyFSharpCoreFlag defaultCopyFSharpCore, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] tryGetMetadataSnapshot) [0x002ce] in /Users/chethusk/oss/FCS/src/fsharp/CompileOps.fs:2489
  at FSharp.Compiler.Driver.main1OfAst[a,b,c,d] (a ctok, FSharp.Compiler.ReferenceResolver+Resolver legacyReferenceResolver, FSharp.Compiler.AbstractIL.ILBinaryReader+ReduceMemoryFlag reduceMemoryUsage, System.String assemblyName, FSharp.Compiler.CompileOps+CompilerTarget target, b outfile, Microsoft.FSharp.Core.FSharpOption`1[T] pdbFile, Microsoft.FSharp.Collections.FSharpList`1[T] dllReferences, System.Boolean noframework, d exiter, FSharp.Compiler.Driver+ErrorLoggerProvider errorLoggerProvider, Microsoft.FSharp.Collections.FSharpList`1[T] inputs) [0x00000] in /Users/chethusk/oss/FCS/src/fsharp/fsc.fs:1954
...

Repro steps
Provide the steps required to reproduce the problem:

Crate a Xamarin.Mac application
Reference FCS 37
Use the Compile API

Expected behavior
Compile proceeds
Actual behavior
FSharp.Compiler.Driver.main1OfAst fails because Microsoft.DotNet.DependencyManager has a hard reference to a .NET Core assembly (I'm using .NET Standard).
System.TypeLoadException: Could not load type of field 'Microsoft.DotNet.DependencyManager.AssemblyResolveHandlerCoreclr:handler' (1) due to: Could not resolve type with token 01000013 from typeref (expected class 'System.Runtime.Loader.AssemblyLoadContext' in assembly 'System.Runtime.Loader, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:System.Runtime.Loader, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Runtime.Loader.AssemblyLoadContext member:(null)
  at Microsoft.DotNet.DependencyManager.DependencyProvider..ctor (Microsoft.DotNet.DependencyManager.AssemblyResolutionProbe assemblyProbingPaths, Microsoft.DotNet.DependencyManager.NativeResolutionProbe nativeProbingRoots) [0x00014] in /Users/chethusk/oss/FCS/src/fsharp/Microsoft.DotNet.DependencyManager/DependencyProvider.fs:266
  at Microsoft.DotNet.DependencyManager.DependencyProvider..ctor (Microsoft.DotNet.DependencyManager.NativeResolutionProbe nativeProbingRoots) [0x00000] in /Users/chethusk/oss/FCS/src/fsharp/Microsoft.DotNet.DependencyManager/DependencyProvider.fs:325
  at FSharp.Compiler.CompileOps+TcConfigBuilder.CreateNew (FSharp.Compiler.ReferenceResolver+Resolver legacyReferenceResolver, System.String defaultFSharpBinariesDir, FSharp.Compiler.AbstractIL.ILBinaryReader+ReduceMemoryFlag reduceMemoryUsage, System.String implicitIncludeDir, System.Boolean isInteractive, System.Boolean isInvalidationSupported, FSharp.Compiler.CompileOps+CopyFSharpCoreFlag defaultCopyFSharpCore, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] tryGetMetadataSnapshot) [0x002ce] in /Users/chethusk/oss/FCS/src/fsharp/CompileOps.fs:2489
  at FSharp.Compiler.Driver.main1OfAst[a,b,c,d] (a ctok, FSharp.Compiler.ReferenceResolver+Resolver legacyReferenceResolver, FSharp.Compiler.AbstractIL.ILBinaryReader+ReduceMemoryFlag reduceMemoryUsage, System.String assemblyName, FSharp.Compiler.CompileOps+CompilerTarget target, b outfile, Microsoft.FSharp.Core.FSharpOption`1[T] pdbFile, Microsoft.FSharp.Collections.FSharpList`1[T] dllReferences, System.Boolean noframework, d exiter, FSharp.Compiler.Driver+ErrorLoggerProvider errorLoggerProvider, Microsoft.FSharp.Collections.FSharpList`1[T] inputs) [0x00000] in /Users/chethusk/oss/FCS/src/fsharp/fsc.fs:1954
  at FSharp.Compiler.Driver.compileOfAst (FSharp.Compiler.AbstractIL.Internal.Library+CompilationThreadToken ctok, FSharp.Compiler.ReferenceResolver+Resolver legacyReferenceResolver, FSharp.Compiler.AbstractIL.ILBinaryReader+ReduceMemoryFlag reduceMemoryUsage, System.String assemblyName, FSharp.Compiler.CompileOps+CompilerTarget target, System.String targetDll, Microsoft.FSharp.Core.FSharpOption`1[T] targetPdb, Microsoft.FSharp.Collections.FSharpList`1[T] dependencies, System.Boolean noframework, FSharp.Compiler.ErrorLogger+Exiter exiter, FSharp.Compiler.Driver+ErrorLoggerProvider loggerProvider, Microsoft.FSharp.Collections.FSharpList`1[T] inputs, Microsoft.FSharp.Core.FSharpOption`1[T] tcImportsCapture, Microsoft.FSharp.Core.FSharpOption`1[T] dynamicAssemblyCreator) [0x00000] in /Users/chethusk/oss/FCS/src/fsharp/fsc.fs:2222
  at<EMAIL_ADDRESS>(FSharp.Compiler.ErrorLogger+Exiter exiter) [0x00000] in /Users/chethusk/oss/FCS/src/fsharp/service/service.fs:182
  at FSharp.Compiler.SourceCodeServices.CompileHelpers.tryCompile (FSharp.Compiler.ErrorLogger+ErrorLogger errorLogger, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] f) [0x0001f] in /Users/chethusk/oss/FCS/src/fsharp/service/service.fs:157
  at FSharp.Compiler.ErrorLogger+ErrorLoggerExtensions.ReraiseIfWatsonable (System.Exception exn) [0x0003f] in /Users/chethusk/oss/FCS/src/fsharp/ErrorLogger.fs:369
  at FSharp.Compiler.ErrorLogger+ErrorLoggerExtensions.ErrorLogger.ErrorRecovery (FSharp.Compiler.ErrorLogger+ErrorLogger x, System.Exception exn, FSharp.Compiler.Range+range m) [0x000d8] in /Users/chethusk/oss/FCS/src/fsharp/ErrorLogger.fs:417
  at FSharp.Compiler.ErrorLogger+ErrorLoggerExtensions.ErrorLogger.StopProcessingRecovery (FSharp.Compiler.ErrorLogger+ErrorLogger x, System.Exception exn, FSharp.Compiler.Range+range m) [0x000b4] in /Users/chethusk/oss/FCS/src/fsharp/ErrorLogger.fs:430
  at FSharp.Compiler.SourceCodeServices.CompileHelpers.tryCompile (FSharp.Compiler.ErrorLogger+ErrorLogger errorLogger, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] f) [0x00034] in /Users/chethusk/oss/FCS/src/fsharp/service/service.fs:160
  at FSharp.Compiler.SourceCodeServices.CompileHelpers.compileFromAsts (FSharp.Compiler.AbstractIL.Internal.Library+CompilationThreadToken ctok, FSharp.Compiler.ReferenceResolver+Resolver legacyReferenceResolver, Microsoft.FSharp.Collections.FSharpList`1[T] asts, System.String assemblyName, System.String outFile, Microsoft.FSharp.Collections.FSharpList`1[T] dependencies, System.Boolean noframework, Microsoft.FSharp.Core.FSharpOption`1[T] pdbFile, Microsoft.FSharp.Core.FSharpOption`1[T] executable, Microsoft.FSharp.Core.FSharpOption`1[T] tcImportsCapture, Microsoft.FSharp.Core.FSharpOption`1[T] dynamicAssemblyCreator) [0x00039] in /Users/chethusk/oss/FCS/src/fsharp/service/service.fs:180
  at<EMAIL_ADDRESS>(Microsoft.FSharp.Core.Unit unitVar) [0x0000d] in /Users/chethusk/oss/FCS/src/fsharp/service/service.fs:1060
  at<EMAIL_ADDRESS>(System.Threading.CancellationToken ct) [0x00000] in /Users/chethusk/oss/FCS/src/absil/illib.fs:741
  at<EMAIL_ADDRESS>(FSharp.Compiler.AbstractIL.Internal.Library+CompilationThreadToken ctok) [0x00007] in /Users/chethusk/oss/FCS/src/fsharp/service/Reactor.fs:188

Known workarounds
No know workarounds. :-( I would love to hear some options.
Related information

Operating system: macOS 10.15.6
.NET Runtime kind: Mono with Xamarin.Mac
Editing Tools: VS for Mac

Oof, that's a rough one. The provider itself I believe is a required component now, but individual implementations of dependency providers (ie #r "nuget:") are optional. If the core component is crashing then we have a pretty serious problem.
If possible, can you test your app with the latest FCS dependency from the MS nightly feeds? FCS is published there on a nightly cadence now and it should quickly let us know if that's still a problem. The nuget feed source url is https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json and it should have FCS 38 prereleases in it.

OK I'll give 38 a whirl.
Did you say I can swap that component out? Would love to hear more if that's true.
I'm a bit afraid of what the default implementation of #r is going to do on iOS. :-)

You can swap out #r handler implementations (or have none at all if you don't include any dlls that implement them), but from what I see in your stacktrace the problem is that the component that discovers/manages those implementations is blowing up.
The overall mechanism is just a hook for providing #load and #I statements, really :D

It’s too bad this hook is broken. Wish they we could just set a function for this behavior instead of relying on IoC.


[bugfix] fix default email template rendering

emails sent from builds from HEAD are missing the HTML template,
which is a result of the missing Close() call on the HTML Part.
@stuartnelson3

Closed in favor of #1009


NIFI-1660 - Enhance the expression language with jsonPath function

Allows JSON path application in EL.

Can someone please kick the Travis CI build.
Failed tests:
TestStandardProcessSession.testManyFilesOpened:775 » OutOfMemory GC overhead l...
This should work.
Thanks!

Please ignore the request to kick the Travis build.  I rebased and that did it.   :-)

This appears to have been based on the 0.x branch, not master (so the PR has conflicts). If you'd like to submit the PR against 0.x, do you mind updating the PR? If you'd like to submit against master, can you rebase against the latest master and force push the branch again? Please and thanks :)

@mattyb149, @markap14  I am working on your suggestions.  Thanks.

I've rebase on master.  Other suggested changes are in the works.

@mattyb149, How would I test a non-StringLiteralEvaluator?

@ckmcd not sure what you mean. If you're referring to the test I suggested adding, it would be just like the valid JSON test but missing the last brace, so the attribute would be set but the content is not valid JSON.

@markap14 wrote

In the vast majority of use cases, I would expect that the JSON Path will be a literal string that does not reference any attributes. In this case, I would want to avoid compiling the JSON Path every time. Would recommend that if the jsonPathExp is an instance of the StringLiteralEvaluator, we pre-compile the JSON Path. We follow a similar pattern with the MatchesEvaluator for pre-compiling regular expressions, and it can make a pretty huge difference on performance.

Mark, can you show me an example of how to write an expression that would not be using a StringLiteralEvaluator?
Thanks!

@ckmcd an example would be something like:
${ hello:jsonPath( '$.${elementOfInterest}.items[0]') }
Here, we are referencing an attribute within the JSON Path, so it is not a String Literal.

This pull request should be good to go as all feedback has been incorporated.

@ckmcd  looks good! I was able to test it locally. Unit tests are good. I did find that a Reader was opened in a unit test and not closed, which i addressed, and a couple of NOTICE files needed to be updated. Otherwise, all is good. Pushed to master and 0.x branches. Thanks for contributing this back!

Hey @ckmcd!  Looks like we missed the magical incantation to have this closed on the commit.  Would you mind closing this when you have the opportunity?
Thanks!


Fix load empty xmlstring

According to the PHP-Manual using load, loadXML LoadHTML and loadHTMLFile with an empty string or filename will generate a warning which is not generated by libxml and can not be handled by libxml's error handling functions. In my opionion this leads to bad client code. So i added checks for the empty string/filename cases and throw a fDOMException. Maybe you consider this pull request or you may have some better ideas to handle such cases.

I think the this is the root cause
https://github.com/php/php-src/blob/master/ext/dom/document.c#L1492


Update Svelte Template

Project template is out of date. Updating to latest version.

The React template has been deprecated. Its project should simply replace this one.


Add Ibex_AXI submodule

Please provide the fusesoc command to compile the ibex_axi core into Vivado project in this repository. Thanks!

The usage of fusesoc has been append to the readme of the submodule. Please take a look.

Should I cd into pynq_z2/pl first before running fusesoc?

Got it, thanks! Would you provide the instruction for a fresh clone to build the Vivado project? You can edit README.md of this repo.

No problem. The step instructions has been added to the REAME file.

Great! Thank you! :+1:


fix URLSession crashing on HTTP/0.9 simple-responses

also add tests for misbehaving HTTP servers.
we discovered that if the server is just returning random bytes, the whole app would crash with fatalError("Received body data, but the header is not complete, yet.") . The reason we can get into that state is that CURL support HTTP/0.9 simple-responses which are just the body bytes...
The issue is also discussed on CURL's github.
To make sure we don't regress and to document the current behaviour, I also wrote tests for a few other cases when the HTTP server is misbehaving or behaving oddly.

@swift-ci please test

@swift-ci please test

@swift-ci please test

This is interesting. The change and the tests look good to me.
Does Foundation on Darwin also gracefully handle such responses?

@pushkarnk two intentions in this pull request

most importantly don't just crash the program on unexpected server response as that's terrible for the user
document the current behaviour in unit tests

I haven't tried how regular Foundation behaves, but it certainly won't just crash ;). Do we want to match regular Foundation exactly or what is the intention here? With my patch we handle these not so common server responses just the way CURL handles them which is what we seem to do usually in Swift Foundation's URLSession.

@pushkarnk @parkera @phausler My suggestion would be to get this patch in as soon as possible to be sure it'll land in Swift 4 as it's just terrible if the program crashes if the server misbehaves. Worst is that if you connect to HTTP2-only servers you might hit that behaviour (as a HTTP2 only response looks like a HTTP/0.9 simple-response to CURL versions without HTTP2 support).
After we addressed the crasher issues we should talk about what we want to achieve here and how we want to handle all the special cases. See here for the list of odd server behaviours I could quickly come up with. We should then go through that list one by one and decide what the appropriate behaviour should be.
But IMHO more importantly we should get something in to fix the crashes. We can then always decide later that we want to throw away HTTP/0.9 simple responses even though CURL handles them.

Specifically, if the server is using HTTP/1.1 but the header is malformed (as you've demonstrated in the tests) does Darwin also return an HTTPURLResponse with httpVersion set to 0.9?

Do we want to match regular Foundation exactly or what is the intention here?
Yes, we'd ideally want to. Unless we are sure that the Darwin Foundation isn't doing the right thing

In short, I seem to have only two questions:

Is the behaviour consistent with Darwin? (Do we desire that? I'd say yes!)
Is the HTTPURLResponse being returned valid in all the failure scenarios pointed out?
Having said that, I agree that we need to fix these crashes first.
@parkera @phausler What would you suggest?

@pushkarnk so in Darwin Foundation, it's really a NSURLHTTPResponse that's created using a CFURLHTTPResponse that's created with a CFHTTPMessageCreateResponse and that is initialised with the following parameters:
* thread #2, queue = 'com.apple.CFNetwork.LoaderQ', stop reason = breakpoint 1.5
    frame #0: 0x00007fff2d1be705 CFNetwork`CFHTTPMessageCreateResponse
CFNetwork`CFHTTPMessageCreateResponse:
->  0x7fff2d1be705 <+0>: pushq  %rbp
    0x7fff2d1be706 <+1>: movq   %rsp, %rbp
    0x7fff2d1be709 <+4>: pushq  %r15
    0x7fff2d1be70b <+6>: pushq  %r14
Target 0: (URLSessionRepro) stopped.
(lldb) po $rdi
\<CFAllocator 0x7fff579b1f10 [0x7fff579b1f10]>{info = 0x7fff5def2000}

(lldb) po $rsi
200

(lldb) po $rdx
<nil>

(lldb) po $rcx
HTTP/0.9

(lldb)

so it does indeed treat it as HTTP/0.9 too but the string seems to be HTTP/0.9 not just 0.9. I will change my patch accordingly.

@pushkarnk also the NSURLHTTPResponse doesn't actually seem to have a property so it seems like you won't be able to query the HTTP version anyway but I guess we want it compatible.

@swift-ci please test

@swift-ci please test

@pushkarnk tests seemed to have passed. Any further comments/questions? @phausler happy with this?

The change looks sensible to me


Wishlists: merge list/detail pages

Tangent's UX team has suggested it would be better to merge the wishlist list and detail pages that currently sit within the accounts section.  The page would still be a list view but would also show the contents of each wishlist in a table underneath.  This would streamline things nicely.

closing all issues that are feature requests that don't have PR's attached.


Missing "refresh_token"

The authorization token response is missing the "refresh_token".
How do we need to call the endpoint to get a refresh_token?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78411727-ea56-aef5-4f04-b016c25afba9
Version Independent ID: 8687b7bc-a196-6fd0-fa57-9fa5dd2d4545
Content: Send custom metrics for an Azure resource to the Azure Monitor metric store by using a REST API
Content Source: articles/azure-monitor/platform/metrics-store-custom-rest-api.md
Service: azure-monitor
GitHub Login: @anirudhcavale
Microsoft Alias: ancav

Thank you for taking the time to share your product and documentation feedback with us. Your input is valued because it helps us create the right documentation for our customers. Due to the volume of issues in our queue, we are closing open issues older than 90 days. We hope to continue hearing from you. Thank you.

Please share the solution.
I am having the same issue where Azure is not returning the refresh_token which is required by mod_auth_openidc.

I found articles that mentioned the offline_access scope being related to the refresh_token attribute.
The process now works as expected after adding the offline_access scope to OIDCScope in Apache and adding offline_access to the Microsoft Graph API in Azure.


Why map not shown in struct?

Content of svPtr.nameMap not shown in debugger variables...
package main

import (
    "fmt"
)

type (
    structInfo struct {
        nameMap   map[string]*fieldInfo // mapping from struct field names to field infos
        pkNames   []string              // struct field names representing PKs
    }

    structValue struct {
        *structInfo
        tableName string        // the db table name for the struct
    }

    fieldInfo struct {
        name   string // field name
        dbName string // db column name
    }
)

func main(){
    fi1Ptr := &fieldInfo{
        dbName: "dbName1",
        name: "name1",
    }
    fmt.Printf("%+v\n", fi1Ptr)

    fi2Ptr := &fieldInfo{
        dbName: "dbName2",
        name: "name2",
    }
    fmt.Printf("%+v\n", fi2Ptr)

    mapFi := map[string]*fieldInfo{
        "fieldInfo1": fi1Ptr,
        "fieldInfo2": fi2Ptr,
    }
    fmt.Printf("%+v\n", mapFi)

    mapNames := []string{"one", "two"}

    siPtr := &structInfo{
        nameMap: mapFi,
        pkNames: mapNames,
    }

    svPtr :=&structValue{
        structInfo: siPtr,
        tableName: "tableName",
    }
    fmt.Printf("%+v\n", svPtr)
    fmt.Printf("%+v\n", svPtr.nameMap)
}

C:/Go\bin\go.exe build -o C:\Users\Andy\AppData\Local\Temp\Unnamedgo -gcflags "-N -l" tests/nameMap(DELVE)
API server listening at: <IP_ADDRESS>:7109
&{name:name1 dbName:dbName1}
&{name:name2 dbName:dbName2}
map[fieldInfo1:0xc042040400 fieldInfo2:0xc042040480]
&{structInfo:0xc0420404e0 tableName:tableName}
map[fieldInfo1:0xc042040400 fieldInfo2:0xc042040480]

https://github.com/go-ozzo/ozzo-dbx/blob/master/struct.go

You just reached the maximum recursion depth, with the command line version of delve you would be able to do: print svPtr.nameMap to see the value of svPtr.nameMap, I don't know how to do it inside IntelliJ.
cc @dlsniper

I think we need to do a better job at detecting the struct type and render it.
@aarzilli I'd suggest keeping this open for now in case we want to contribute back to delve a way to just list the map and values w/o the internal structure (in order to simplify the clients).
@kolkov please open an issue in the plugin repo linked to this. Thank you.

Closing, client problem.


Finding missing scans on FreeBMD2

FreeBMD1 text on scan page: If the scan does not contain the entry you may be able to find the scan yourself by clicking here. If the scan does not contain the entry you can leave feedback by clicking here.
On Entry Information Page, below scans, text now needed, suggest:
If the scan does not contain the entry you may be able to find the scan yourself by clicking here [links to FreeBMD1? or ??? - page is (e.g.) https://www.freebmd.org.uk/cgi/scan-response.pl?y=1838&q=1&e=1&a=find&d=bmd_1600692744&r=IANSON|John|St Giles|1|30&signature=zjeTvn0aNjxG0%2BmyQv4l6w&extra=ANC-01,340&extra=LDS%2F1838b1-I-0340.jpg,340. If the scan does not contain the entry you can leave feedback by clicking here
That takes you to a page with text (e.g. )
Are you sure that record
IANSON,John,St Giles,1,30
is not in scan
ANC-01/1838B1-I-0340.jpg
Please do not use rejection to indicate that the record has been incorrectly transcribed, rather use the correction process on the Information page.

with a 'confirm button.

For Decision: do we create this process on FreeBMD2 for MVP, or simply link through to FreeBMD1 at this point (sending the information needed to generate the correct data in the links?
Depending on decision, we may need to use this text https://docs.google.com/document/d/17EzCa8Gl130ACmG00LEJFKcAU-83Yg2Z8Oiu0Cu0BeU/edit?usp=sharing

@Vino-S to investigate/explore options here.

Finding missing scan takes us to the FreeBMD image server(https://images.freebmd.org.uk/cgi/choose.pl) so we need to provide a link for the image server from BMD2

@Vino-S to update the story once code move to vervet

ready for testing in test2

ready for testing in test2

I can't see any difference on test2, @Vino-S  -

@Vino-S needs more info on what difference is expected

@PatReynolds to take a look and clarify for Vino.

I have made a document showing what I see on test2, and what I expected to see: https://docs.google.com/document/d/1WOZVdbxCbdXtl0BFxyHv_99zdLv05FwZvcwziItS8vo/edit?usp=sharing

@Vino-S to take a look and see if the requirement is now clear.

Improved display of scans in test3
Record Example with scan:

First Name: Martha, Surname: TASKER, Volume: 19 and Page: 34

The expected text isn't on the scan page (just dispays as a GIF).

Wrote to Allan and Barrie 25 Sep 2021, but realise that this is about reporting errors on scans, not missing scans (the subject of this issue).

@Vino-S to check FreeBMD1 to see if we need to add a statement about how to report missing scans (Report a Data Problem button)

In FreeBMD1 researcher can provide feedback if the Scan has the searched record or they can reject the Scan.

Agreed to go with ranking via BMD1 site for now and hold off on any additional features/implementation of this on BMD2 until post MVP. To check on product requirements list.


Prototype SSH certificates and AuthorizedKeysCommand

Prototype the our intended use of SSH certificates and AuthorizedKeysCommand on a VM.

protoyping complete


dvyukov clang ci

pkg/cover: fix tests with clang
executor: work around clang-format issue
tools/docker/big-env: install clang-14
Makefile: run more test with clang

o we need to upload new docker images first, so that the new checks begin to pass

I've already uploaded it.

Ah, ok. But all images on github still seem to be old ones.


Glitch demo site error: "This project has received too many requests, please try again later."

** PLEASE READ THIS BEFORE COMMENTING ON THIS ISSUE **
I'm submitting a:

[x] bug report
[ ] feature request

What OS are you using?
Mac OS 10.14.5
What browser(s) is this bug affecting:
Chrome 79
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36
Current behavior:
the demo site does not work
Expected behavior:
the demo site works
Steps to reproduce:
go to the glitch demo site linked at the top of this repo

cc @e111077

we might have to consider bundling and serving with es dev server...

Fixed on their side


Mixed reality overlay

Hi,
Would it be possible to overlay the semantic segmented map on top of the Post-processed camera view to create a mixed-reality view?

I think this should be done in the client side, it shouldn't be too difficult to blend the two images in Python

I don't exactly understand your objective.  What do you mean by mixed-reality view ?
Just a simple merge between labels and rgb ? This could be easy to be done on the client
side. If you do it, maybe it is a good function to eventually add to the client.

I'm exploring shared semi-autonomous control where a human driver is assisted by local-AI in the car. Here's a reference: http://ieeexplore.ieee.org/abstract/document/6232153/
In this case, a simple merge with a transparency layer should work, right?

Yes ! It should work!
Please share with us after you do it !


enables multi threaded scheduler again

With the migration to capnproto, I enabled the multithreaded tokio scheduler again. RSS is at 1.4 MB on my machine. Might be worth it based on todays discussion on managing multiple log streams.

discussed in slack


[DO NOT MERGE] Allow CI to test paging

🤖 AutoRest automatic feature coverage report 🤖
feature set version 2.6.4
❌ General: 97%
15 out of 543 features are not covered by tests
FileStreamVeryLarge, additionalPropertiesSubclass, animalNotFoundError, expectedNoErrors, expectedPetHungryError, expectedPetSadError, getArrayEnumValid, getArrayStringEnumValid, getComposedWithDiscriminator, getComposedWithoutDiscriminator, intError, linkNotFoundError, putArrayEnumValid, putArrayStringEnumValid, stringError
❌ Azure: 95%
6 out of 122 features are not covered by tests
AzureXmsCustomNamedRequestId, AzureXmsCustomNamedRequestIdParameterGroup, AzureXmsRequestClientOverwrite, AzureXmsRequestClientOverwriteViaParameter, LROPostDoubleHeadersFinalAzureHeaderGetDefault, PagingMultipleLRO

Don't need the PR anymore, core has been merged to master


RN 0.49 crash in iOS release mode

After upgrading from RN 0.47 to 0.49, the app crashes in iOS 10 in release mode.
2017-10-21 22:52:35.287874+0800 MyApp[286:15231] Unhandled JS Exception: undefined is not an object (evaluating 'l.View.propTypes.style')
However, there is no problem in debug mode.
May i seek for your help?
Many thanks.

I have exactly the same problem. Please reopen

React-Native 0.49. Xcode 9.0.1. Debug build works just fine on simulator and actual iPhone. Release build crashes on iPhone crashes with above error

@pongponglau did find out anything more?

Same here, for iOS and Android both. Please reopen.

It turned out that a number of third party modules that I was using were not react 16 compliant. I patched them myself or found forks where they had been patched. After I traced them all, things started working. It's not clear why some of them showed up only in release mode, but ultimately they were the culprit.
I would suggest you search your own code and the code in node_modules (third party modules) for things that break in react 16:

PropTypes imported from react vs prop-types. Or the occurrence of React.PropTypes.
View.proptypes being used instead of VieePropTypes

If you see them, they need to be fixed.

I checked my dependencies, but they seem to use the prop-types package. Have a look at this issue I posted #16567
Thank you for your comment btw @ujwal-setlur  😄

any easier way to tell which dependencies is having this issue when it crashed?
I tried to inspect my npm package one by one but still unable to find which one causing the issue

Please reopen this issue. There're too many 3-party dependencies need to be fixed!

This is technically not an issue with react-native, thigh I must say the developer experience has been terrible. Previous breaking upgrades have also been terrible experiences, so something absolutely has to be done.

Hi, everyone. After spending tons of time to find out a better solution, I found out there's no need to modify all 3rd party library. The tricky part is to make sure your dev dependencies are correct and use<EMAIL_ADDRESS>to build your release.
"devDependencies": {
    "babel-jest": "21.2.0",
    "babel-preset-react-native": "4.0.0",
    "jest": "21.2.1",
    "react-test-renderer": "16.0.0-beta.5"
  },


NPO Start Plus

I have a NPO Start Plus subscription, but the NPO is still lacking an Apple TV app.
Is there a way to build the higher quality streams an such into the app? Does NPO provide an API for that?
Would be awesome!
Now that side loading can be done wirelessly I am back in the game of side loading!

Hey Renzo,
The app is actually using adaptive streams, which means that your stream quality will adapt to your connection speed. So you should be able to see HD like quality if your connection allows it.
Side note is that the NPO has moved to a new authenticated API (see comments on #24) which basically means the current API is being deprecated. While it currently still works, the NPO can decide to kill the API whenever they like, which means the app will stop working.
For now we're still good, let's hope it stays that way...
Cheers, Jeroen

I know that is uses adaptive streaming, but the app doesn't know if I am a paid subscriber, right? I thought the free subscription isn't HD at all.
Isn't there a new API to use?

The free streams also have HD quality, except for the themed channels. There is a new API, but that one requires an API token only the NPO will give out (and invalidate). I did some tests and while I have found an API key, the NPO can revoke it anytime they would like to. When I have time I need to investigate whether or not it's worth investing time into...


Git branch idea

Branch Naming Conventions

Main Branches:

main: The main branch where the source code of HEAD always reflects a production-ready state.
develop: The development branch where the latest development changes are integrated. This branch is used for integration and testing before merging into main.

Feature Branches:

Naming: feature/short-description
Purpose: For developing new features.
Example: feature/add-bollinger-band-strategy

Bug Fix Branches:

Naming: bugfix/short-description
Purpose: For fixing bugs.
Example: bugfix/bollinger-band-calculation-error

Hotfix Branches:

Naming: hotfix/short-description
Purpose: For urgent fixes that need to be applied to the production code.
Example: hotfix/bollinger-band-urgent-fix

Release Branches:

Naming: release/version-number
Purpose: For preparing a new production release.
Example: release/1.0.0

Experiment Branches:

Naming: experiment/short-description
Purpose: For testing new ideas or experimental features.
Example: experiment/test-bollinger-band-parameters

Summary of Corrected Steps

Start from develop:

git checkout develop

Create an Experiment Branch:

git checkout -b experiment/study-openapi-integration

Do Miscellaneous Things and Trial-and-Error in the Experiment Branch.
Finalize the Code in the Experiment Branch.
Merge Experiment Branch into develop:

git checkout develop
git merge experiment/study-openapi-integration
git push origin develop

Create a Feature Branch from develop:

git checkout develop
git checkout -b feature/add-openapi-integration
Implement the Feature in the Feature Branch.

Merge Feature Branch into develop:

git checkout develop
git merge feature/add-openapi-integration
git push origin develop

Simplified Branching Strategy

Main
Development
Feature
Bug Fix


bug

[14:35:11] [Server thread/ERROR]: Could not pass event InventoryClickEvent to Jobs v4.11.0
java.lang.NoSuchMethodError: io.lumine.xikage.mythicmobs.mobs.MythicMob.getDisplayName()Ljava/lang/String;
	at com.gamingmesh.jobs.MythicMobs.MythicMobs4.getDisplayName(MythicMobs4.java:64) ~[?:?]
	at com.gamingmesh.jobs.config.NameTranslatorManager.Translate(NameTranslatorManager.java:120) ~[?:?]
	at com.gamingmesh.jobs.container.JobInfo.getRealisticName(JobInfo.java:83) ~[?:?]
	at com.gamingmesh.jobs.Gui.GuiManager.CreateJobsSubGUI(GuiManager.java:205) ~[?:?]
	at com.gamingmesh.jobs.listeners.JobsListener.onGuiLeftClick(JobsListener.java:243) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1320.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.13.2.jar:git-Paper-626]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.13.2.jar:git-Paper-626]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:66) ~[patched_1.13.2.jar:git-Paper-626]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:520) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:2288) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.PacketPlayInWindowClick.a(SourceFile:33) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.PacketPlayInWindowClick.a(SourceFile:10) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:15) ~[patched_1.13.2.jar:git-Paper-626]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
	at net.minecraft.server.v1_13_R2.SystemUtils.a(SystemUtils.java:108) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1018) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:940) ~[patched_1.13.2.jar:git-Paper-626]
	at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:837) ~[patched_1.13.2.jar:git-Paper-626]
	at java.lang.Thread.run(Thread.java:834) [?:?]

Could you please send more information about plugin?
The jobConfig file about the job.

Could you please send more information about plugin?
The jobConfig file about the job.

https://www.dropbox.com/s/aw29dfge3ohcqdj/jobConfig.yml?dl=0

The Hunter job in MMKill action, these names in the MythicMob is exist?

The Hunter job in MMKill action, these names in the MythicMob is exist?

yes

The Hunter job in MMKill action, these names in the MythicMob is exist?

4.10 no this error

What MythicMob version are you using?

Now I tested this, and this working properly for me. Make sure you have using the latest free version of MythicMob plugin and using the dev. version of Jobs in Releases tab. We only supports the free version.

Now I tested this, and this working properly for me. Make sure you have using the latest free version of MythicMob plugin and using the dev. version of Jobs in Releases tab. We only supports the free version.

mm 4.7 no free

MythicMobs 2.7 changed its API which causes this issue to appear. For time being it will not be supported until we can get access to new version which can be used in compiling a plugin.
7cbdf517135abe67d92f880d4768826427135ce7


Conditionally calling :bp or :x  to close either the buffer or quit Vim

Not really an issue, but more of a feature request/question.
Since enabling tabline for my vim buffers, it made me very productive and kept my work space nice and clean. so kudos for that :beers:
But one thing that has been I've had to adjust to is the difference closing a vim window, :x, and closing a buffer, :bp.
Is there any way we can wrap these command in a function to do the following:

closing the current active buffer
switch to the next buffer in numeric order
if the last buffer isn't a saved file, run :x

cheers

something like that should definitely belong in your vimrc, as it doesn't really have anything to do with the status or tabline.


workflow-es-mongodb 2.1.1 was not built before it was published to NPM!

So the costructor in src/mongodb-provider.ts in the source code looks like this:
    constructor(connectionString: string) {
        var self = this;
        this.connect = new Promise<void>((resolve, reject) => {
            const options =  { useNewUrlParser: true,  useUnifiedTopology: true };
            MongoClient.connect(connectionString, options, (err, client) => {
                if (err)
                    reject(err);
                self.client = client;
                const db = self.client.db();
                self.workflowCollection = db.collection("workflows");
                self.subscriptionCollection = db.collection("subscriptions");
                self.eventCollection = db.collection("events");
                resolve();
            });
        });
    }

But the costructor in build/mongodb-provider.js in the built code from the npm package looks like this
    function MongoDBPersistence(connectionString) {
        this.retryCount = 0;
        var self = this;
        this.connect = new Promise(function (resolve, reject) {
            console.log("Connecting to mongo...");
            mongodb_1.MongoClient.connect(connectionString, function (err, db) {
                console.log("Connected to mongo");
                self.db = db;
                self.workflowCollection = self.db.collection("workflows");
                self.subscriptionCollection = self.db.collection("subscriptions");
                self.publishCollection = self.db.collection("unpublished");
            });
        });
    }

Note that this built code makes no reference to self.client. I believe that the source code was not rebuilt before it was published to NPM.
If you can fix this ASAP it would be much appreciated!

I'm so sorry about that... can you confirm 2.1.2 is correct?

No worries. Just did an npm install of 2.1.2 and it is now working. Thanks!
Also just to help other folks out would request that you deprecate or unpublish 2.1.1.


Map Shop Owner -DB

Possible future addition of treasure maps leading to small-large rewards depending on difficulty.

As awesome of an idea as this is, I think the work involved for doing this would put way too much on our plate at this point.
Up to you, but I think what he have outlined currently will be more than enough at this point?

Think this idea will be shelved in lieu of everything else we have added


Dark coin icons are difficult to read in dark mode

For coins such as Algorand and BitTorrent which have black icons, there is very poor contrast between the icons and the background when the user is in dark mode.
The icons appear to be SVGs so it should be possible to add a white outline via CSS which would remedy this, but my initial tinkering with <svg><use href={c.icon} /></svg> was unsuccessful. I'm opening an issue for this as a reminder to loop back for another attempt.

@evan-cohen See #300 for another coin that is struggling with dark mode.


s3: uploading with no bucket doesn't give a sensible error

This shouldn't be allowed, instead it gives a rather cryptic error
$ rclone -v copy /tmp/many_files/file1.tst s3:
2015/11/08 09:57:40 S3 bucket : Modify window is 1ns
2015/11/08 09:57:40 Attempt 1/3 failed with 1 errors and: MethodNotAllowed: The specified method is not allowed against this resource.
    status code: 405, request id:

Probably should check all methods in s3, swift and googlecloudstorage that they have a bucket/container where necessary.

Just hit this with 1.3.7. The console filled up with hundreds of lines.
Problem #1: MethodNotAllowed error is not helpful
Problem #2: rclone doesn't stop when it hits the error

This fixes the immediate problem with the unhelpful error message.  However it should probably be added to all the external methods, and it should be added to all the bucket/container based remotes which is a lot more work!
diff --git a/s3/s3.go b/s3/s3.go
index 0ea6fe4c..468edf2b 100644
--- a/s3/s3.go
+++ b/s3/s3.go
@@ -686,6 +686,9 @@ func (f *Fs) dirExists() (bool, error) {

 // Mkdir creates the bucket if it doesn't exist
 func (f *Fs) Mkdir(dir string) error {
+	if f.bucket == "" {
+		return fs.ErrorListBucketRequired
+	}
 	f.bucketOKMu.Lock()
 	defer f.bucketOKMu.Unlock()
 	if f.bucketOK {


GDPR compliance

This gem is ok with the new law?
The cookies should be disabled for rails if user declines their use.
It would also be a good feature to be able to be more strict, not allowing cookies until the user clicks OK.
I'll see if I can help.

I think there needs to be some form of modification.
The user should be able to disable all optional categories of cookies. Only neccessary cookies shouldn't be able to be opted out of by the user as far as I'm aware.

Own cookies (session for example) are needed and should not be blocked only third party cookies are a problem for the law.

Do you mean GDPR compliance?

@seanfcarroll I think he just made a typo :)
@pmaojo So, how did you imagine that? Having a "Not agree" button which will call a method in which you can do whatever you want?

GDPR in English
RGPD in Spanish

@gabskoro The button should be "Agree", but if the Agree cookie is not set, all cookies should be rejected. In Spain, in theory, third party cookies that store data that could identify user should be disabled until user allows them.

Yes, looks like this is still a necessary change. We probably also need a configurable list of cookies, put into categories (mandatory, analytics etc...), that the user can opt into and out of.

I think this gem should not be in charge of that. Maybe we could just render a "NO" button which will trigger a specific route and then you can block whatever you would like. What do you think?


build-sys: make pedantic revive the default

I wonder if we are really prepared to remove the non-pedantic option completely.

How I see it is: Today's codebase satisfies revive-pedantic.toml, that can change if we accept weaker rules. enforcing pedantic revive on projects that currently satisfy the pedantic rules prevent weaker code from being accidentally committed

slog and gossipcache currently pass the make PEDANTIC=1 test, so I don't see a reason to justify allowing those projects to be weakened again

v0.4.3 tagged


Metadata page requires style-src hash in CSP

For some reason, the metadata page of engineblock won't display properly in Edge/Chrome without a CSP style-src hash.  Investigate why this hapens.

Note: currently no CSP header is set on engine.


what is the training set, validation set and testing set in your work?

Hi, thank you for releasing such excellent research on image enhancement.  May I ask a few questions about your experiments?

How you split the EyeQ dataset into training/val/testing sets? In your paper, you mentioned that We utilize EyeQ [3] as our first dataset, which consists of 28792 fundus images with three quality grades (“Good”, “Usable”, “Reject”) and has been divided into a training set, a validation set, and a testing set. I noticed that on the EyeQ dataset website, they split the total dataset into training/testing sets, also on the Kaggle challenge website, I didn't find any places explain how they split the dataset.

How long it takes to train your network on your machine?

Thank you!

Thanks for your attention.

We followed the DR classification task dataset split in my teammate's work (arxiv.org/pdf/2110.14160.pdf). I think you can just split 20% of the training data as the validation set, which seems also okay.
We trained the total framework for 1day on 8 RTX 2080ti. We observed that a small batch size dose does not influence the performance significantly. You can try training it on fewer GPUs with smaller batch sizes.

Since we used InstanceNorm in our backbone, it works much better than BN when your computation resource is limited.


Add support for end of URL matching

Things to keep in mind:

[x] Must omit query parameters at end of URL - /?hello=world&yee=haw
[x] Must omit fragment identifiers at end of URL - /#scroll-to-content
[x] Must account for trailing slash at the end = /post/my-fancy-article-is-here/

All items addressed with v1 release


Update s3, sdk-core, sqs to 2.17.156

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.143 to 2.17.156.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #460.


Date related tests do not pass in a different timezone/locale

Describe the bug
Date related tests do not pass in a different timezone/locale
Steps to reproduce
Run the tests in a different timezone/locale
Expected behaviour
They pass

Some DateTimeOffset and DateTime tests seem to fail due to a different time zone, e.g.:
Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
Some float tests seem to fail due to a different decimal separator character depending on the current culture, e.g.:
Expected: 123,45   -->   Actual:   12345

List of failing tests, 55 in total:
tests (55 tests) Failed: 55 tests failed
  MediumTests (55 tests) Failed: 55 tests failed
    Vogen.IntegrationTests.SerializationAndConversionTests (55 tests) Failed: 55 tests failed
      ClassVos (15 tests) Failed: 15 tests failed
        DateTimeOffsetVoTests (net6.0) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (net5.0) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp3.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp2.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (net461) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.

        DateTimeOffsetVoTests (net5.0) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp3.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp2.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (net461) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.

        DateTimeOffsetVoTests (net5.0) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp3.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp2.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (net461) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.

        DateTimeOffsetVoTests (net5.0) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp3.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (netcoreapp2.1) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.
        DateTimeOffsetVoTests (net461) (1 test) Failed: One or more child tests failed: 1 test failed
          WhenDapperValueConverterUsesValueConverter Failed: Expected actual to be 15.01.2022 19:08:49 +00:00, but found 15.01.2022 19:08:49 +01:00.

One other issue that was found when fixing was the following code showed that there's no dapper converter from decimal to a VO with an underlying type of decimal, e.g.
            var parameters = new { Value = 123.45f };
            IEnumerable<DapperDecimalVo> results = await connection.QueryAsync<DapperDecimalVo>("SELECT @Value", parameters);

The Parse method that's generated has this:
            public override DapperDecimalVo Parse(object value)
            {
                return value switch
                {
                    global::System.Int32 intValue => DapperDecimalVo.Deserialize(intValue),
                    global::System.Int64 longValue when longValue < global::System.Int32.MaxValue => DapperDecimalVo.Deserialize((global::System.Int32)longValue),
                    global::System.String stringValue when !global::System.String.IsNullOrEmpty(stringValue) && global::System.Decimal.TryParse(stringValue, out var result) => DapperDecimalVo.Deserialize(result),
                    _ => throw new global::System.InvalidCastException($"Unable to cast object of type {value.GetType()} to DapperDecimalVo"),
                };
            }

We need to add the primitive itself into the switch expression.


Issue deriving tuple types on overridden method

🔎 Search Terms
tuple type infer inference inheritance
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about tuples and type inference.

⏯ Playground Link
https://www.typescriptlang.org/play?alwaysStrict=false&target=2&jsx=0&module=5&ts=5.3.3&filetype=ts#code/CYUwxgNghgTiAEAXAngBwQZUTAlgOwHMAxHGAZ0QBUBXVCBAXngG0LdCAaeAOl6j2QBdANwAoUZChky8IgHs58AN6j4a+GXRgAFAEoAXPCztipCjToIV6m-DiJqMPCwBEACxAQIcl4NXqAX1EgiWhpeAAhWHgQAA9EEDxgGXlFa3VNcD1lf1s7EAcnVwIFYAAjZBAXLiUyOQBbArd8AkMXTzIqgL8bIICgA
💻 Code
declare type StringFirstTuple = [string, ...any];

class Foo {
    spec(): StringFirstTuple {
        return ["hello"]
    }
}

class Bar extends Foo {
    spec() {
        return ["goodbye", {something: "else"}]
    }
}

🙁 Actual behavior
The spec method on Bar failed to typecheck, despite unambiguously implementing the same type signature as spec on Foo.
Annotating Bar's spec method to return a StringFirstTuple typechecks properly.
The error message seems to indicate that the return type of spec in Bar has been generalized to Array<string | {something: string}> before checking the overridden type.
🙂 Expected behavior
A function that returns an array that is hard-coded to match a tuple type should be substitutable for a function that is specified to return that tuple type.
Additional information about the issue
No response

Methods don't inherit the types of the methods they're overriding, so the type of your Bar.spec method is inferred from the return type. #32082 matches this the most.

I suppose that's fair, though from an ergonomics perspective it feels odd to me that TS would mark a type mismatch between Bar.spec and Foo.spec, but never actually check whether Bar.spec and Foo.spec could be described equivalently.
In a TypeScript-forward project, where relying on implicit types is generally discouraged, the current behavior may be completely reasonable; I'm running into this in a Javascript project with JSDoc types, and the lack of inference is an unfortunate hurdle for most consumers (especially as the tuple type gets pushed deeper inside a nested object).

You can't really remove this inconsistency, only change where it appears. If you had written this, for example, m is unambiguously inferred as string[] and the code still fails
class Bar extends Foo {
    spec() {
        const m = ["goodbye", {something: "else"}]
        return m;
    }
}

@RyanCavanaugh I'm not sure I follow your argument. In your example, m will always be inferred as Array<string | {something: string}> (unless I'm really missing something), and no, neither string[] nor Array<string | {something: string}> will satisfy [string, ...any].
On the other hand, [string, ...any] describes an array of any length which has a string at index 0, which absolutely can be satisfied by a string[]. And while it's similarly correct to say that ["goodbye", {something: "else}] is an Array<string | {something: string}>, it is also a [string, ...any] (and a [string, object], and many other things).
To someone unfamiliar with the implementation of TypeScript, it definitely feels like a defect to say that a hard-coded value like ["goodbye"] is not a satisfactory "array that begins with a string" unless it is also explicitly described as such.

On the other hand, [string, ...any] describes an array of any length which has a string at index 0, which absolutely can be satisfied by a string[].

Arrays can be empty, not having a string at index 0.

On the other hand, [string, ...any] describes an array of any length which has a string at index 0, which absolutely can be satisfied by a string[].

Arrays can be empty, not having a string at index 0.

Fair point.

@pvande the vibes might be off, but the "fix" is that the method return type inference algorithm gets more complex (and very much more non-local in this case), and "the type system is too complicated to understand" is already a problem that people talk about. Everything can be made more complicated, but complexity itself is also understood to be a defect. It's not infrequent for people to claim that the inference system should be "worse" (less likely to understand implicit intent) for the sake of being "simpler". I'm not saying this is an absolute must-not-change, but it's also not a bug in the sense of producing unsound behavior. And even in the presence of a fix, m is also "wrong", so it's not like a fix here relieves you of the burden of understanding the concept that the inferred type of an expression might be wider than its tightest possible bound.

@RyanCavanaugh Thanks for your patience with me about this.

… the "fix" is that the method return type inference algorithm gets more complex…
That does seem likely.

It's not infrequent for people to claim that the inference system should be "worse" (less likely to understand implicit intent) for the sake of being "simpler".
Not being a regular member in this community, that's not something I've been aware of, though it also seems reasonable.

…it's also not a bug in the sense of producing unsound behavior.
Completely agree. At worst, it's a spurious error in VS Code for folks leveraging a typed API in a typeless Javascript project.

And even in the presence of a fix, m is also "wrong", so it's not like a fix here relieves you of the burden of understanding the concept that the inferred type of an expression might be wider than its tightest possible bound.
I can imagine a world in which implicitly typed literals are lazily evaluated and "cast" at point-of-use. In such a world, all of the following seem reasonable:

const value = ["string", {number: 2}, /s/]

let a: [string, ...any] = value
let b: [any, {number: number}, any] = value
let c: [...any, RegExp] = value
let d: Array<string | {number: number} | RegExp> = value

function e(arg: [string, ...any]): void { arg }
e(value)

const f = () => value
a = f()
b = f()
c = f()
d = f()

What I don't know offhand is what the practicalities and drawbacks of such an implementation are, though I'm confident they exist.
That said, my only goal in opening this issue was to call attention to a sharp edge that my team encountered, to raise awareness and discussion.

I can imagine a world in which implicitly typed literals are lazily evaluated and "cast" at point-of-use. In such a world, all of the following seem reasonable:

This is an interesting thought and not something I personally ever considered.  One of the fundamental tradeoffs you make with a typed language is that you give up the ability to speak of individual values in favor of giving the compiler (and potentially, the programmer) an easier job by being able to reason about more general types (i.e. constraints) of values instead.  But I could definitely imagine a world too where e.g. object literals (which might satisfy several different constraints thanks to contextual typing) have type inference "deferred" until they're actually assigned to something with an explicit type annotation.
That said, deferral brings with it its own problems.  See, e.g. conditional types in a generic context.


Binaries built outside of the Dockerfiles

Bug description:
Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [x]

Expected behavior:
This might be a bit more of a question than a bug report, so sorry for the extra noise. I noticed across most of the dockerfiles that the bins are built outside of the container rather than using a builder container and copying them into the final image. I was curious, why is that approach taken as it could lead to a dependency on the build system or local tools to ensure a repeatable build where as doing the build in the container provides kind of a "clean room" approach?
Steps to reproduce the bug (as precisely as possible):
Build the Dockerfiles under ./dockerfiles.
Example:
FROM gcr.io/distroless/static
COPY osm-controller /

Rather than:
FROM golang:1.13.15 as builder
WORKDIR /workspace

# Run this with docker build --build_arg $(go env GOPROXY) to override the goproxy
ARG goproxy=https://proxy.golang.org
ENV GOPROXY=$goproxy

# Copy the Go Modules manifests
COPY go.mod go.mod
COPY go.sum go.sum
# Cache deps before building and copying source so that we don't need to re-download as much
# and so that source changes don't invalidate our downloaded layer
RUN go mod download

# Copy the sources
COPY ./ ./

# Build
ARG ARCH
RUN CGO_ENABLED=0 GOOS=linux GOARCH=${ARCH} \
    go build -a -ldflags '-extldflags "-static"' \
    -o osm .

# Copy the controller-manager into a thin image
FROM gcr.io/distroless/static:latest
WORKDIR /
COPY --from=builder /workspace/osm .
USER nobody
ENTRYPOINT ["/osm"]

@nojnhuh do you have any input on this issue?

I'm not sure exactly how that decision got made initially to build the images natively vs. in Docker (@draychev, do you have more context?). The only reason I can see justifying keeping it the way we have it that it hasn't broken yet, but I agree that building the binaries within Docker would reduce the risk of the issues you describe, @devigned.

@devigned @nojnhuh @ksubrmnn There is no particular reason why we build on bare metal. I agree this could be improved.
This is going to be a fun issue - will bring it into v0.8 - we can improve the developer experience!

@devigned @nojnhuh @ksubrmnn There is no particular reason why we build on bare metal. I agree this could be improved.
This is going to be a fun issue - will bring it into v0.8 - we can improve the developer experience!

Done in #4402


refactor: improve contact form

:tada: This PR is included in version 0.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Solution for BST related question

Your device hardware:

Issue details:
Given the root node of a binary tree, can you determine if it's also a binary search tree?
Complete the function which has  parameter: a pointer to the root of a binary tree. It must return a boolean denoting whether or not the binary tree is a binary search tree. You may have to write one or more helper functions to complete this challenge.

boolean checkBST(Node root) {
return checkBSTUtil(root, null, null);
}
private boolean checkBSTUtil(Node root, Node min, Node max){
if(root == null){
return true;
}
if(min != null && min.data >= root.data){
return false;
}
if(max != null && root.data >= max.data){
return false;
}
return checkBSTUtil(root.left, min, root) && checkBSTUtil(root.right, root, max);
}

Log (optional):

@kapishmalik kindly add this as a PR. Also, add the Hackerrank problem URL on your code just like I've done.

@Kvaibhav01 Done.


CentOS7 issue - revert "Remove link following in minimize_access file resource"

On my (default installation) CentOS 7 systems this commit purges /bin and /sbin, as both directories are symbolic links:

/bin -> usr/bin
/sbin -> usr/sbin

Therefore link -> 'follow' must be included here!

@mcgege master is fixed now, could you please rebase our PR on the latest master?

@artem-sidorenko rebase done


add Olapic as user

fixes #406 ; added Olapic as a user of babel

Mind running this through ImageOptim or another PNG optimizer?

@thejameskyle done, I changed for a svg

Heh, can you make this 500x200 then and run it through svgo?


question about volume data rendering

@jbms
Can neuroglancer render volume data to achieve the following effects?
https://threejs.org/examples/webgl2_materials_texture3d.html

I have tried  in neuroglancer, but can only get one slice in each of the three directions x / y / z:

Direct volume rendering is planned for the near future but not yet supported.

Direct volume rendering is planned for the near future but not yet supported.

Ok, hope to be available soon
thank you very much

There is now experimental volume rendering support available, check the "Experimental volume rendering" box on an image layer.  It still needs a bit of work but is fairly usable.


Badges for dependencies status

PR checklist

[X] New feature, bugfix, or enhancement
[X] Documentation update

Overview of change:
Added three badges for not losing sight of dependecies status.

Is there anything you'd like reviewers to focus on?
Only lines three to five are relevant. The others are code formatting changes made by prettier.
CHANGELOG.md entry:

@JoshuaKGoldberg merge conflicts resolved


[Feature Request]: Embedding chat page doesn't show the cited documents.

Is there an existing issue for the same feature request?

[X] I have checked the existing issues.

Is your feature request related to a problem?
No response
Describe the feature you'd like

Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

Duplicated with #732


Test for ENABLE_EXTRA_HOST_DEV condition

We're missing a test case to cover the following code. Specifically, we need to check that, when SNAT is enabled, ingress packets that don't have a mark (i.e., identity not deduced by inherit_identity_from_host()) will not match policies for the host.
https://github.com/cilium/cilium/blob/b8a3accbaffbfe54a016ce23b1c78a153d8a03f6/bpf/bpf_netdev.c#L275-L287
The #ifndef was recently inverted in #10776 and put back in #10843 without triggering any CI failure.

Addressed by 79e4db9399df ("bpf: Remove ENABLE_EXTRA_HOST_DEV").


Only install enum34 for python<3.4.

What are your thoughts on the new pip way of specifying this as enum34;python_version<="3.4"?

That works great in requirements.txt for pip.  There is an alternate syntax
for setup.py that is available with setuptools >=36.2, but how do you
guarantee the starting version of setuptools without requiring multiple
installation runs?
On Tue, Feb 26, 2019 at 8:42 PM James Brown<EMAIL_ADDRESS>wrote:

What are your thoughts on the new pip way of specifying this as
enum34;python_version<="3.4"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EasyPost/syslog-rfc5424-parser/pull/11#issuecomment-467688929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEBr5sBkXxpcqryqol9VMW4RWCikUgFks5vReKbgaJpZM4bRRRI
.

Have you thought about how you'd like to resolve this?
As it stands, it breaks our py3 migration.
Traceback (most recent call last):
File "/vpp/.tox/py36/lib/python3.6/warnings.py", line 505, in
_processoptions(sys.warnoptions)
File "/vpp/.tox/py36/lib/python3.6/warnings.py", line 186, in _processoptions
_setoption(arg)
File "/vpp/.tox/py36/lib/python3.6/warnings.py", line 192, in _setoption
import re
File "/vpp/.tox/py36/lib/python3.6/re.py", line 122, in
import enum
ModuleNotFoundError: No module named 'enum'

This is resolved in version 0.3.1. Sorry for the delay.

Thank you so much!
On Tue, Mar 19, 2019 at 9:38 PM James Brown<EMAIL_ADDRESS>wrote:

This is resolved in version 0.3.1. Sorry for the delay.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EasyPost/syslog-rfc5424-parser/pull/11#issuecomment-474649793,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEBrw2j6hozu3IYjWceSpk16AxuQz9Eks5vYZELgaJpZM4bRRRI
.


extract_features.py  is too slow

when i used the code in extract_features.py
'''
for result in self.estimator.predict(input_fn, yield_single_examples=True)
'''
i found it spend about 4s，could some ways can i do？

@sjm1992st
check this, it may help!
https://github.com/hanxiao/bert-as-service#book-tutorial


I am getting the following error when exporting keras model to tensorflow

from tensorflow.python.saved_model import builder as saved_model_builder
from tensorflow.python.saved_model import utils
from tensorflow.python.saved_model import tag_constants, signature_constants
from tensorflow.python.saved_model.signature_def_utils_impl import build_signature_def, predict_signature_def
from tensorflow.contrib.session_bundle import exporter
export_path = 'plantmodelproduction'
builder = saved_model_builder.SavedModelBuilder(export_path)
signature = predict_signature_def(inputs={'images': new_model.input},
outputs={'scores': new_model.output})
with K.get_session() as sess:
builder.add_meta_graph_and_variables(sess=sess,
tags=[tag_constants.SERVING],
signature_def_map={'predict': signature})
builder.save()
INFO:tensorflow:No assets to save.
INFO:tensorflow:No assets to write.
ERROR:tensorflow:==================================
Object was never used (type <class 'tensorflow.python.framework.ops.Tensor'>):
<tf.Tensor 'IsVariableInitialized_3579:0' shape=() dtype=bool>
If you want to mark it as used call its "mark_used()" method.
It was originally created here:
File "C:\Users\isheunesu\Anaconda\lib\site-packages\IPython\core\interactiveshell.py", line 3287, in run_code
return outflag  File "", line 2, in
model=load_model('plantdiseasemodel.h5')  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\engine\saving.py", line 422, in load_model
h5dict.close()  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\engine\saving.py", line 288, in _deserialize_model
K.batch_set_value(weight_value_tuples)  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\backend\tensorflow_backend.py", line 2581, in batch_set_value
get_session().run(assign_ops, feed_dict=feed_dict)  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\backend\tensorflow_backend.py", line 206, in get_session
session.run(tf.variables_initializer(uninitialized_vars))  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\backend\tensorflow_backend.py", line 199, in
[tf.is_variable_initialized(v) for v in candidate_vars])  File "C:\Users\isheunesu\Anaconda\lib\site-packages\tensorflow\python\util\tf_should_use.py", line 189, in wrapped
return _add_should_use_warning(fn(*args, **kwargs))
ERROR:tensorflow:==================================
Object was never used (type <class 'tensorflow.python.framework.ops.Tensor'>):
<tf.Tensor 'IsVariableInitialized_3578:0' shape=() dtype=bool>
If you want to mark it as used call its "mark_used()" method.
It was originally created here:
File "C:\Users\isheunesu\Anaconda\lib\site-packages\IPython\core\interactiveshell.py", line 3287, in run_code
return outflag  File "", line 2, in
model=load_model('plantdiseasemodel.h5')  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\engine\saving.py", line 422, in load_model
h5dict.close()  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\engine\saving.py", line 288, in _deserialize_model
K.batch_set_value(weight_value_tuples)  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\backend\tensorflow_backend.py", line 2581, in batch_set_value
get_session().run(assign_ops, feed_dict=feed_dict)  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\backend\tensorflow_backend.py", line 206, in get_session
session.run(tf.variables_initializer(uninitialized_vars))  File "C:\Users\isheunesu\Anaconda\lib\site-packages\keras\backend\tensorflow_backend.py", line 199, in
[tf.is_variable_initialized(v) for v in candidate_vars])  File "C:\Users\isheunesu\Anaconda\lib\site-packages\tensorflow\python\util\tf_should_use.py", line 189, in wrapped
return _add_should_use_warning(fn(*args, **kwargs))

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!


Invalid Security Certificate

Hi,
There is a problem after installing the certificate

Hello,
My default test certificate is a sample self-signed certificate for testing OPC UA with secured communication and for certificate-based login. It is not designed to be used as a general purpose trusted certificate. For that, you will likely need to purchase a signature from a trusted authority.
Regards,
Nauful


Added item create

arcgis.item.create({
  type: "Web Mapping Application",
  title:"My item",
  tags: ["dev"],
  owner: "aturner"})
.then(function(e) {
    console.log(e)}).catch(function(error) {console.log(error)
})

cool! i'll take a closer look at this very soon.


Upgrade to support Visual Studio 2019 RC+

Just small updates for Visual Studio 2019 RC+

Thanks!


Avoid compiler warnings if 'command' and 'argument' are unused

Well, I do not get these warnings with clang, with gcc I do. Possibly gcc is just more "pedantic"...


Locally Determining Nearest ComID & Upstream/Downstream flows from coordinates

What is your question?
Sorry to bother you guys again, but I was wondering if there was a way to—given a set of coordinates—locally determine the nearest ComID and then calculate upstream/downstream facilities. (I have a list of ~600,000 facilities with coordinates, and I'm trying to locate the closest Water Quality Portal monitoring site immediately upstream and downstream from the facility.) Currently, I've been using the findNLDI function in the dataRetrieval package to do this, but I don't think it's sustainable for the number of API calls I'll need to make, as it would take several days to run to completion. I also tried the discover_nhdplus_id package from the nhdplus package but this just uses dataRetrieval::findNLDI under the hood.
I was thinking the only way I might be able to do this then is to be able to identify the nearest ComID locally, without having to do an API call each time. Is there any way I might be able to do this in a relatively quick manner?
Side Note: Also, I was wondering if hydrosequence data exists beyond the ComID level. For my purposes, if I locate the upstream ComID, there might be multiple water monitoring sites so it'd be difficult to know for sure which is the closest upstream site.
Thanks so much for the advice!

Hi @jerrylin3321 -- It is certainly possible but it's not quite as easy as the NLDI calls.
You'll need to geometry on your local machine.
Then you'll want get flowline index and friends. Or do an sf::st_within to find which catchment your facilities are in. -- there are some nuances here depending how you want to relate facilities to rivers that are well beyond the scope of a github issue.
-- note that if you are working in a small area, get_flowline_index() with download=TRUE may work but if your facilities are national, you should just download the whole nhdplus geodatabase.
Hydrosequence is tied to comid -- if you need to order monitoring sites are all on the same catchment, you will need more precise indexing (reachcode and measure). The WQP sites in the NLDI have not been indexed to that precision, but if you have the data locally and want to attempt it, see the indexing and referencing functions -- it wouldn't be too hard but I'm sure you would have a number of errors in the resulting indexed locations -- depending on your use case, this may or may not be OK -- that's for you to determine.
Good luck!