iOS Status Bar and this plugin causing web view to shift down 20px

This issue popped up again on install of iOS 9.0. Basically the webview gets pushed down 20px and you see a white bar, under the StatusBar.
I previously solved it by doing
StatusBar.hide();
StatusBar.overlaysWebView(false);
StatusBar.backgroundColorByHexString('#eddd1a');
StatusBar.styleLightContent();
StatusBar.show();
And this would magically fix the positioning problems. But its not working anymore.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27148648-ios-status-bar-and-this-plugin-causing-web-view-to-shift-down-20px?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

I can't reproduce this error.

I'll provide a repo for you to test later. Here are a few screenshots...
Notice the webview shifted down. The green absolute div gets shifted down past the view.
Before the plugin is installed...

After the plugin is installed and built

Does this also happen when you run on the iPhone / iPhone Simulator?

Please have a look at this comment:
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/242#issuecomment-60128928

I actually commented in that thread, which was awhile ago, found the aforementioned workaround, which I described in the original post and after the upgrade to iOS 9.0 it no longer works.

I've tested myself. This can't be fixed atm, sorry. It will only work when StatusBar.overlaysWebView(true) is called. (iOS7+ behave).
Setting StatusBar.overlaysWebView(false); is < iOS 7+ and not best practice by Human Interface Guidelines. Of course, setting this is allowed, but should be avoided.

@Hirbod The real problem here is that the webview is pushed down 20px. Not the overlaysWebView part. Either a true or false values for the overlay setting causes the webview to be pushed down 20px. Which can be seen as the green div at the bottom being not shown. Not sure if your aware of a workaround for that.

I just tried myself, I only got the white bar problem when I set StatusBar.overlaysWebView(false).

Correct, white bar no longer shows up (because its under the status bar) but if you put a div at an absolute, bottom : 0. with another color, You can see that its pushed down outside the view. Without this plugin the div is correctly positioned at 0 and you can see its entirety.

I guess I can't fix this due to knowledge issues.. You need to take this issue into account when working with css (maybe margin-top -20px) till we find an acceptable solution. I hope someone with more knowledge (maybe @wf9a5m75, but he don't watch this plugin currently) have any ideas.
From what I can see, something happened since iOS9 with delayed plugin initialization or timing issues, that's why #623 also occured.

Ok. Thanks for the responses. Tried Margin Top before and unfortunately that was a no go as well. I'll keep trying and reply back if I find a consistent solution.

I'll will also try to find a solution.

Ok I dug around a bit and put my very small objective c experience to work.
So this works, for my specific cordova version and ios 9.0. I don't know if this will work for every other one, I can try to test out when I have other devices / os versions to test with.
What I did was fix the webview rect being passed - 20.
 CGRect fixedFrame = self.webView.frame;
    fixedFrame.size.height -= 20;
    fixedFrame.origin.y -= 20;

  self.pluginLayer = [[MyPluginLayer alloc] initWithFrame:fixedFrame];

Which file did you patch? I will try this and also add a check around it to proof, if StatusBar Plugin is installed.

GoogleMaps.m I guess it might better belong in MyPluginLayer.m when its initialized. Ill provide you with the full pr when Im near a computer again if you need.

yeah, please provide one..

K no problem. Should be able to get that out tonight.

:+1:

  Class CDVStatusBarCls = NSClassFromString(@"CDVFile");
  CGRect fixedFrame = self.webView.frame;

  // check if statusbar is installed and remove 20px
  if(CDVStatusBarCls != nil) {
    fixedFrame.size.height -= 20;
    fixedFrame.origin.y -= 20;
  }

But this actually does not work for me. I did not have any problems before, no I do.

Please could you pull a "cordova plugin version" and tell me your plugin-version?

actually your code seems fine.. I did some wrong (or not correct anymore) maths do get the screenheight. I will merge this code soon

I will communicate the change like this:
Important notice
Since plugin version 1.3.3, we will check if the StatusBar plugin is installed, and substract -20px from the mapview and also move  y-offset by -20px. This will not affect you when you're using StatusBar with default settings, but it will affect you, when you set StatusBar.overlaysWebView(false)
To fix that 20px at the bottom, just add 20 extra pixels to your #map_canvas (with jQuery or vanilla js)
I do something like this
// default (when overlayed)
$('#map_canvas').css('height', $('.ons-page-inner:last').height());
// when not overlayed
$('#map_canvas').css('height', $('.ons-page-inner:last').height() + 20);

Please ignore my ons-page-inner class, this is just an example (im my case, I need exactly the height of ons-page-inner)

Thanks @Hirbod.

Hi All,
did anybody fixed this issue.
i am facing same problem.
@Hirbod. and @pmwisdom did you get solution  for this

@kamakshi417 @pmwisdom
Open GoogleMaps.m
Inside of PluginInitilize
search for
self.pluginLayer = [[MyPluginLayer alloc] initWithFrame:self.webView.frame];

and replace with
CGRect viewBounds = [self.webView bounds];
viewBounds.origin.y -= 20;
viewBounds.size.height = viewBounds.size.height + 20;
self.pluginLayer = [[MyPluginLayer alloc] initWithFrame:viewBounds];

@Hirbod For the record, I had to replace it with the following:
CGRect viewBounds = [self.webView bounds];
viewBounds.size.height = viewBounds.size.height + 20;
self.pluginLayer = [[MyPluginLayer alloc] initWithFrame:viewBounds];

I did not add the line viewBounds.origin.y -= 20; as that caused a gray bar at the bottom of the screen instead.

Finally I found a workaround for this issue. I only tested it in IOS 9. Let me know if it works in Android and other version of IOS:
In the "deviceready" I added the following code:
StatusBar.hide();

setTimeout(function ()
{
    StatusBar.show();
}, 1500);

And before opening the map:
//The Status Bar closes and opens quickly and it was unnoticeable in my phone
StatusBar.hide();
map.showDialog();
StatusBar.show();
I hope it helps.


⚠ Secret Website 3 has degraded performance

In d9062db, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2056 ms

Resolved: Secret Website 3 performance has improved in b45c8ec.


⚠ Fetchers has degraded performance

In e56e93e, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 383 ms

Resolved: Fetchers performance has improved in 74e8b24.


Does it support sugarss?

Understands CSS-like syntaxes: stylefmt is powered by PostCSS, so it understands any syntax that PostCSS can parse, including SCSS.

Most likely, Yes. Now I cannot work on this feature – PR welcome 🌮

Fixed by #159.


Issue while i sign up as a new user

When I sign up as a new user the browser shows the alert message " Unexpected token '<', "<!DOCTYPE "... is not valid JSON"

Generate the tokens inside the user model.
Create two tokens "access and refresh token"
While creating user don't send the password and access token as a response, through cookie.
Like this:-
const newuser = await User.create({
fullName,
Profile-pic: profilePic?url,  //use multer and cloudinary for uploading images
coverImage: coverImage?.url || "",
email,
password,
username: username.toLowerCase()
})
const createdUser = await User.findById(user._id).select(
    "-password -refreshToken"
)

if (!createdUser) {
    throw new ApiError(500, "Something went wrong while registering the user")
}

return res.status(201).json(
    new ApiResponse(200, createdUser, "User registered Successfully")
)

And use "async-await  and try catch" while working with database.
Use cookieparser in it.


Payroll contract example

The contract demonstrates a simplified but relatable real world scenario where a payroll management contract can add and pay employees.
Among other things it demonstrates how and where to use macros for Rbac and patterns around collections, storage keys and Promises and handling errors in a non-trivial example.
Next step is to handle more error cases, include a multi-sig approval in this and create test cases to show how it works.

One limitation with the multisig implementation is that it does not allow different roles to approve the action. So in this particular example if I want the manager and the employee to approve the action of disbursing pay it's not possible because they have different roles. If the multisig were to allow multiple enum variants to approve the same action, it's still possible that two employees could approve the action, or a different employee could approve.
Here we want to specific accounts to make a combined approval.
I don't think the default implementation supports such a pattern. This can be documented more clearly that the approval requires m votes among n equal peers (equal as in the same role).
For this example will a custom implementation be more useful or is there some other helpful macro?

So the #[simple_multisig] macro is the K out of N approval scheme. Maybe it should be renamed? The approval system is generic enough to allow approvals from entities of different standing, however.

I believe simple_multisig is a common terminology in payments and contracts. It's just that I missed it when reading the documentation. Still the documentation can be updated to reflect in simpler terms that, as you say, it's a K out of N voting scheme and currently the voting can only be done among users of the same role.

In the meantime I'll look into implementing a custom approval flow for this. It's for the best I think since the example will demonstrate a slightly more complex approval implementation.

I've updated the example with a custom approval management. I've also noted down my documentation and design comments as TODO in src/approval/mod.rs. Overall I feel that the approval manager is well designed and guides the programmer to good design. But it is also very generic and needs more documentation and examples to help understand how to actually use it.
Any suggestions for improving the example?
There is one thing left to make it complete i.e. to subtract the logged hours once the transfer is complete.

I'm working on the sandbox tests and I often get errors like this.
thread 'successful_request' panicked at 'called `Result::unwrap()` on an `Err` value: ExecutionResult { total_gas_burnt:<PHONE_NUMBER>520, transaction: ExecutionOutcome { block_hash: `9gcZ6Xr2EP49T5BnT17MhKGZKkopGroisfnTsEPhg18u`, logs: [], receipt_ids: [`9qDj5a2auqXNhaUVeajyvxmUUt4tP4R8J4peCYUZZTU1`], gas_burnt:<PHONE_NUMBER>010, tokens_burnt:<PHONE_NUMBER>01000000000, executor_id: AccountId("dev-20221204143310-60254843734169"), status: SuccessReceiptId(9qDj5a2auqXNhaUVeajyvxmUUt4tP4R8J4peCYUZZTU1) }, receipts: [ExecutionOutcome { block_hash: `BNTrFnQ9EFXDf2QRuf6FkVDBbG2aVa3vMJ64tD2SAEw1`, logs: [], receipt_ids: [`4BCGPLwqny35MnjDJqqfFvE9SVJkAANoe92bXNB4AXSd`], gas_burnt:<PHONE_NUMBER>010, tokens_burnt:<PHONE_NUMBER>01000000000, executor_id: AccountId("dev-20221204143315-66270547170103"), status: Failure(ActionError(ActionError { index: Some(0), kind: FunctionCallError(MethodResolveError(MethodNotFound)) })) }, ExecutionOutcome { block_hash: `7QV8P9UnJBixPCFSotBcxB4uawXhbMDbiWqzWgBfZyik`, logs: [], receipt_ids: [], gas_burnt:<PHONE_NUMBER>00, tokens_burnt: 0, executor_id: AccountId("dev-20221204143310-60254843734169"), status: SuccessValue(``) }], value: ActionError(ActionError { index: Some(0), kind: FunctionCallError(MethodResolveError(MethodNotFound)) }) }', /Users/twitu/.cargo/registry/src/github.com-1ecc6299db9ec823/workspaces-0.6.1/src/result.rs:222:28

It doesn't actually mention which method call or which line failed which makes it much harder to debug. Is there anyway to expose this information? It'll certainly help newcomers using repo.

Also I found that there are no examples where the output of a transaction call is used. While trying to do this I found that the result of a transaction is actually the base64 encoding of the return value.
However the ExecutionResult docs type does not mention this and does not provide any method to decode the base64 value. Is this handled using a helper? or some utility script?

A custom implementation of ApprovalManager is pretty non-trivial to use. After initializing the configuration in the contract #[init] function, it still gives not initialized errors when running tests.
impl Payroll {
    #[init]
    pub fn new(owner: &AccountId) -> Self {
        let mut contract = Payroll {
            hourly_fee: 1000,
            logged_time: UnorderedMap::new(PayrollKey::LOG),
        };
        <Payroll as ApprovalManager<PayrollAction, PayrollApproval, PayApprovalConfiguration>>::init(PayApprovalConfiguration {});
        contract.add_role(owner, &Role::Manager);
        contract
    }
}

thread 'test_disburse_payment' panicked at 'called `Result::unwrap()` on an `Err`
<--snip-->
value: ActionError(ActionError { index: Some(0), kind: FunctionCallError(ExecutionError("Smart contract panicked: init must be called before use")) }) }'


Autocomplete Ctrl+space

At the moment, I have the impression that you always need at least 1 character to display autocompletion.
It would be cool to have the list of possible object properties without having to type a first letter to get the list.
Just by pressing Ctrl+Space I'd like to have the complete list of possibilities.
Like here in the Codemirror documentation:

I would also appreciate this feature

@vharny terribly sorry that this shortcut was dropped in 2.x accidentally

@vharny you can enable this with configuration in codemirror 6 (the docs you linked to are for 5), we are just a language mode library!

if you want this feature in codemirror 6, please use the @codemirror/commands library
https://codemirror.net/docs/ref/#commands


using DelayedJob results in multiple email Amazon SES

I had the same problem as he(https://github.com/collectiveidea/delayed_job/issues/260)! This section in the Readme not working with SES.

You may also wish to consider using Active Job with Action Mailer which provides convenient .deliver_later syntax that forwards to Delayed Job under-the-hood.

ruby '2.7.1'

gem 'rails', '~> <IP_ADDRESS>'
gem 'delayed_job', '4.1.10'
gem 'delayed_job_active_record', '4.1.7'
gem 'aws-sdk-s3', '~> 1'
gem 'aws-sdk-rails'

I need use mailer before method, Mailer.delay.method.


Add Doctors[1 Xpt] Team member #1

[ ] When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.

completed


Add additional info about csrf-token to README

Instead of gem installation it is possible just add a few strings of code to angular app

I think this is going to have issues with Turbolinks when the CSRF token changes. Additionally, I don't think depending on the meta attribute should be encouraged, especially over angular_rails_csrf cookie approach.


Weird behavior of typeRoots option

TypeScript Version:  2.4.1
See: https://github.com/fanzeyi/typescript-resolution
In the first commit everything works fine (type definition is placed under typing/node_module/@types) and typeRoots is configured as ./typing/node_modules/@types in tsconfig.json.
However, after renaming the folder into ./typing/node_modules/types in the second commit. TypeScript will complain when building the project:
typing/node_modules/types/jquery/index.d.ts(2955,63): error TS2304: Cannot find name 'Iterable'.

I tried to run tsc with --traceResolution and looked at the differences between two setup. Weirdly that in the broken setup, the compiler can correctly found the typing definition but it failed to use it while the module resolving later. I strongly think this is a bug in the module resolution process.
Here is a diff of the trace resolution between two commit:
diff --git a/./trace.out b/./trace-types.out
index 69b6301..376e55c 100644
--- a/./trace.out
+++ b/./trace-types.out
@@ -40,39 +40,39 @@ Found 'package.json' at '/Users/fanzeyi/typescript-resolution/node_modules/backb
 'package.json' has 'main' field 'backbone.js' that references '/Users/fanzeyi/typescript-resolution/node_modules/backbone/backbone.js'.
 File '/Users/fanzeyi/typescript-resolution/node_modules/backbone/backbone.js' exist - use it as a name resolution result.
 ======== Module name 'backbone' was successfully resolved to '/Users/fanzeyi/typescript-resolution/node_modules/backbone/backbone.js'. ========
-======== Resolving type reference directive 'backbone', containing file '/Users/fanzeyi/typescript-resolution/__inferred type names__.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'. ========
-Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'.
-Found 'package.json' at '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/package.json'.
+======== Resolving type reference directive 'backbone', containing file '/Users/fanzeyi/typescript-resolution/__inferred type names__.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'. ========
+Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'.
+Found 'package.json' at<EMAIL_ADDRESS> 'package.json' does not have a 'typings' field.
 'package.json' does not have a 'types' field.
-File '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/index.d.ts' exist - use it as a name resolution result.
-Resolving real path for '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/index.d.ts', result '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/index.d.ts'.
-======== Type reference directive 'backbone' was successfully resolved to '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/index.d.ts', primary: true. ========
-======== Resolving type reference directive 'jquery', containing file '/Users/fanzeyi/typescript-resolution/__inferred type names__.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'. ========
-Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'.
-Found 'package.json' at '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/package.json'.
+File<EMAIL_ADDRESS>exist - use it as a name resolution result.
+Resolving real path for<EMAIL_ADDRESS>result<EMAIL_ADDRESS>+======== Type reference directive 'backbone' was successfully resolved to<EMAIL_ADDRESS>primary: true. ========
+======== Resolving type reference directive 'jquery', containing file '/Users/fanzeyi/typescript-resolution/__inferred type names__.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'. ========
+Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'.
+Found 'package.json' at<EMAIL_ADDRESS> 'package.json' does not have a 'typings' field.
 'package.json' does not have a 'types' field.
-File '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts' exist - use it as a name resolution result.
-Resolving real path for '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts', result '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts'.
-======== Type reference directive 'jquery' was successfully resolved to '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts', primary: true. ========
-======== Resolving type reference directive 'underscore', containing file '/Users/fanzeyi/typescript-resolution/__inferred type names__.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'. ========
-Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'.
-Found 'package.json' at '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/underscore/package.json'.
+File<EMAIL_ADDRESS>exist - use it as a name resolution result.
+Resolving real path for<EMAIL_ADDRESS>result<EMAIL_ADDRESS>+======== Type reference directive 'jquery' was successfully resolved to<EMAIL_ADDRESS>primary: true. ========
+======== Resolving type reference directive 'underscore', containing file '/Users/fanzeyi/typescript-resolution/__inferred type names__.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'. ========
+Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'.
+Found 'package.json' at<EMAIL_ADDRESS> 'package.json' does not have a 'typings' field.
 'package.json' does not have a 'types' field.
-File '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/underscore/index.d.ts' exist - use it as a name resolution result.
-Resolving real path for '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/underscore/index.d.ts', result '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/underscore/index.d.ts'.
-======== Type reference directive 'underscore' was successfully resolved to '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/underscore/index.d.ts', primary: true. ========
-======== Resolving type reference directive 'jquery', containing file '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/index.d.ts', root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'. ========
-Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/types'.
-Found 'package.json' at '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/package.json'.
+File<EMAIL_ADDRESS>exist - use it as a name resolution result.
+Resolving real path for<EMAIL_ADDRESS>result<EMAIL_ADDRESS>+======== Type reference directive 'underscore' was successfully resolved to<EMAIL_ADDRESS>primary: true. ========
+======== Resolving type reference directive 'jquery', containing file<EMAIL_ADDRESS>root directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'. ========
+Resolving with primary search path '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types'.
+Found 'package.json' at<EMAIL_ADDRESS> 'package.json' does not have a 'typings' field.
 'package.json' does not have a 'types' field.
-File '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts' exist - use it as a name resolution result.
-Resolving real path for '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts', result '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts'.
-======== Type reference directive 'jquery' was successfully resolved to '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/jquery/index.d.ts', primary: true. ========
-======== Resolving module 'underscore' from '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/index.d.ts'. ========
+File<EMAIL_ADDRESS>exist - use it as a name resolution result.
+Resolving real path for<EMAIL_ADDRESS>result<EMAIL_ADDRESS>+======== Type reference directive 'jquery' was successfully resolved to<EMAIL_ADDRESS>primary: true. ========
+======== Resolving module 'underscore' from<EMAIL_ADDRESS>========
 Explicitly specified module resolution kind: 'NodeJs'.
 'baseUrl' option is set to '/Users/fanzeyi/typescript-resolution/src', using this value to resolve non-relative module name 'underscore'.
 'paths' option is specified, looking for a pattern to match module name 'underscore'.
@@ -89,34 +89,16 @@ File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/index.ts' doe
 File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/index.tsx' does not exist.
 File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/index.d.ts' does not exist.
 Loading module 'underscore' from 'node_modules' folder, target file type 'TypeScript'.
-Directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/backbone/node_modules' does not exist, skipping all lookups in it.
-Directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/types/node_modules' does not exist, skipping all lookups in it.
+Directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types/backbone/node_modules' does not exist, skipping all lookups in it.
+Directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types/node_modules' does not exist, skipping all lookups in it.
 File '/Users/fanzeyi/typescript-resolution/typing/node_modules/underscore.ts' does not exist.
 File '/Users/fanzeyi/typescript-resolution/typing/node_modules/underscore.tsx' does not exist.
 File '/Users/fanzeyi/typescript-resolution/typing/node_modules/underscore.d.ts' does not exist.
-Directory '/Users/fanzeyi/typescript-resolution/typing/node_modules/@types' does not exist, skipping all lookups in it.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore.ts' does not exist.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore.tsx' does not exist.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore.d.ts' does not exist.
-Found 'package.json' at '/Users/fanzeyi/typescript-resolution/node_modules/underscore/package.json'.
+File<EMAIL_ADDRESS>does not exist.
+Found 'package.json' at<EMAIL_ADDRESS> 'package.json' does not have a 'typings' field.
 'package.json' does not have a 'types' field.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/index.ts' does not exist.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/index.tsx' does not exist.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/index.d.ts' does not exist.
-Directory '/Users/fanzeyi/typescript-resolution/node_modules/@types' does not exist, skipping all lookups in it.
-Directory '/Users/fanzeyi/node_modules' does not exist, skipping all lookups in it.
-Directory '/Users/node_modules' does not exist, skipping all lookups in it.
-Directory '/node_modules' does not exist, skipping all lookups in it.
-'baseUrl' option is set to '/Users/fanzeyi/typescript-resolution/src', using this value to resolve non-relative module name 'underscore'.
-'paths' option is specified, looking for a pattern to match module name 'underscore'.
-Module name 'underscore', matched pattern '*'.
-Trying substitution '../node_modules/*', candidate module location: '../node_modules/underscore'.
-Loading module as file / folder, candidate module location '/Users/fanzeyi/typescript-resolution/node_modules/underscore', target file type 'JavaScript'.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore.js' does not exist.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore.jsx' does not exist.
-Found 'package.json' at '/Users/fanzeyi/typescript-resolution/node_modules/underscore/package.json'.
-'package.json' has 'main' field 'underscore.js' that references '/Users/fanzeyi/typescript-resolution/node_modules/underscore/underscore.js'.
-File '/Users/fanzeyi/typescript-resolution/node_modules/underscore/underscore.js' exist - use it as a name resolution result.
-======== Module name 'underscore' was successfully resolved to '/Users/fanzeyi/typescript-resolution/node_modules/underscore/underscore.js'. ========
-typing/node_modules/types/jquery/index.d.ts(2955,63): error TS2304: Cannot find name 'Iterable'.
+File<EMAIL_ADDRESS>exist - use it as a name resolution result.
+Resolving real path for<EMAIL_ADDRESS>result<EMAIL_ADDRESS>+======== Module name 'underscore' was successfully resolved to<EMAIL_ADDRESS>========
+typing/node_modules/@types/jquery/index.d.ts(2955,63): error TS2304: Cannot find name 'Iterable'.

typing/node_modules/types/jquery/index.d.ts(2955,63): error TS2304: Cannot find name 'Iterable'.

suggests you need to add --lib es6

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


merge package from arlac77/npm-package-template

package.json

chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(engines<EMAIL_ADDRESS>chore(package): add xo from template
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

.travis.yml

chore(travis): remove node versions 10.13
chore(travis): add node versions 10.14

Coverage remained the same at 83.951% when pulling fd8275c9cdb2342062f8c8900f257cac54b77fb5 on template-sync-1 into 4fa516c2b21050a61474e62d83bfd4d2cf10b8cb on master.


Fix TrueColors in console

Ok, this is still so unclear and unsupported by whole bunch of terminals. Putty isn't supportling it, xfve4-terminal is not, as well. We can modify 16 plaete colors to work witch gruvbox, but ... no. simply nope.


GroupedTruncate=false

I started using that to avoid deadlocks, it seemed to improve.

Closing this as it seems to take 10 minutes with this approach instead of 4.


Admin Panel: Vue.js integration

Long term Vue.js integration for Admin Panel Frontend

moved to https://github.com/flextype-plugins/admin/issues/85


[android-embedding] Tool cannot find the plugin main class

In some cases, a plugin's directory structure might not match the Java package. For example, the cloud function plugin.
As a result, the tool would have to find the plugin's main class in any location under the android/src/main directory.

I'd say that this is a plugin bug and that the tool shouldn't allow building it...
cc @jonahwilliams

Did the old plugin structure intentionally support this?

If so, it doesn't necessarily make sense that we'd want the new structure too.
If not, we should be consistent

This seems similar to the changes we needed to make to some ios plugins that don't follow objective-c naming conventions.
It should be possible to update the offending plugins right?

I don't know if that was intentional, but I doubt. @collinjackson maybe you have some more ancient context?
It is possible to update offending plugins, I guess it technically is a breaking change to the Java API, I wish we had a way to estimate how many plugins have this issue.

I don't think it was intentional. I'd prefer if plugins were forced to conform to the correct directory naming. Although it would be a breaking change, it seems like a worthwhile one.

What's the follow up here? Show an error in flutter_tools or in pub publish?

@blasten you moved this to the done column. Did you mean to close this bug too?

As per https://github.com/flutter/flutter/issues/42661#issuecomment-541885505, there's no more work left here.


mixer: add missing attribute declarations

Fixes https://github.com/istio/istio/issues/11589
/assign @douglas-reid
/assign @bianpengyuan

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bianpengyuan, kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-presubmit

prow/istio-unit-tests.sh
70f18632046e9774aff79dc1ff8e1c3a474dafa7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e49d4f62645d04fd9ce660a987a593d31c7b71b9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e49d4f62645d04fd9ce660a987a593d31c7b71b9
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
e49d4f62645d04fd9ce660a987a593d31c7b71b9
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wenchenglu do you mind merging this bug fix?


Choozi - Recombine app files and some improvements

Combine code for both apps
Better colors for Bangle.js 2
Fix selection animation for Bangle.js 2
New icon
Slightly wider arc segments for better visibility
Extract arc drawing code in library

Forgot to give lib the center values as parameter for completely custom arcs.

Looks great - thanks for pulling out the arc into a library!

Is there a reason it's still a draft though, or shall I merge?

Will push a fix for the lib missing the center point argument in my lunch break :)

@gfwilliams This is now ready for merging :)

Thanks!


pull request for e2e test at 12/29/2016 03:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Using custom fonts without font files

Hi,
it appears it's not possible to use system-installed fonts that are not added in a "fonts" folder via the "font-directory" property of the Map class.
On the other hand, the e.g. "Bright" default style has this in the comments:
// All fontsets should have a good fallback that covers as many glyphs
// as possible. 'Arial Unicode MS Regular' and 'Arial Unicode MS Bold'
//are recommended as final fallbacks if you have them available.

This suggests that the style files in fact don't necessarily need to have all the fonts available in order for them to be used with the style.
My question is: why is it not possible to add fonts that cannot be seen by Mapbox Studio Classic, but might exist on the end-user's machines (browsers that run Mapbox-gl-js with the custom style)?
For example, we'd like to have our style use Apple's San Francisco as the font if the map is opened on an iOS9 device, falling back to another font if SF is not available. If the font rendering really is done by the browser using JS/CSS within mapbox-gl-js, we don't see a reason why this wouldn't be possible.
We've tried manually editing the project files and adding the San Francisco font reference, which results in Mapbox Studio Classic being unable to open the project. Is it possible to upload the style anyway to Mapbox, perhaps somehow from the command line?
Note that Apple's font licence prevents the font being included directly in the style package (as far as we know).
Thanks!

After inspecting the code of mapbox-gl-js, it seems that it needs direct access to the raw glyphs. Presumably this means the only way to use a font is to directly embed it. Also, mapbox-gl-js styles doesn't support Mapbox Studio Classic styles anyway. Closing the issue.


Why can't I put multiple broadcaster_id in GetChannelInformationRequest?

Is it that I don't know how? Or is it not supported?
i used twitch_api2 v0.6.1

good catch! This is indeed a fault in the library and should be supported.
in 2020 when this code was added this was not documented
https://web.archive.org/web/20201126161544/https://dev.twitch.tv/docs/api/reference
I'll make sure this gets added to 0.7.0

To fix this https://github.com/twitch-rs/twitch_api/blob/2d4b88d8644af0c9e21826712778ed13622bf028/src/helix/endpoints/channels/get_channel_information.rs#L50 needs to be changed to
pub struct GetChannelInformationRequest<'a> {
    /// ID of the channel
    #[cfg_attr(not(feature = "deser_borrow"), serde(bound(deserialize = "'de: 'a")))]
    pub id: Cow<'a, [&'a types::UserIdRef]>,
}

and all other applicable places and documentation needs to be updated accordingly


🐛 BUG: Uncaught error when initializing two top level WASM modules

Which Cloudflare product(s) does this pertain to?
Miniflare
What version(s) of the tool(s) are you using?
3.20231218.0
What version of Node are you using?
v20.10.0
What operating system are you using?
Mac
Describe the Bug
When using dynamic imports to load two wasm modules in parallel using top-level await, any second await attempt failed with an uncaught error.
Minimal Reproduction: https://github.com/pi0/miniflare-reproduction
mode-a.mjs and mode-b.mjs:
const mod = (await import("./sum.wasm")).default;
const instance = await WebAssembly.instantiate(mod);

export const sum = instance.exports.sum;

worker.mjs:
let [a, b] = ["-", "-"];

// Only works if one await happens!
a = await import("./mod-a.mjs").then((r) => r.sum(1, 2));
b = await import("./mod-b.mjs").then((r) => r.sum(3, 4));

export default {
  async fetch(request, env, ctx) {
    // This works (also in parallel)
    // a = await import("./mod-a.mjs").then((r) => r.sum(1, 2));
    // b = await import("./mod-b.mjs").then((r) => r.sum(3, 4));

    return new Response(JSON.stringify([a, b], null, 2), {
      headers: { "content-type": "application/json" },
    });
  },
};

Note: Importing alone works, but any attempt to access or call exports fails with error:
Stack trace: (attached)
(minfilare config uses modules: true + moduleRules for CompiledWasm)

Context: Discovered in tests while working on https://github.com/unjs/unwasm/pull/11/ (unwasm will be used as the default WASM handler for Nuxt and Nitro projects and also for CF deployments 🔥 )
the
Please provide a link to a minimal reproduction
https://github.com/pi0/miniflare-reproduction
Please provide any relevant error logs
workerd/jsg/modules.c++:336: error: Async module was not immediately resolved.
service core:user:: Uncaught ReferenceError: Cannot access 'sum' before initialization
  at src/worker.mjs:5:47
/Users/pooya/tmp/miniflare-reproduction/node_modules/miniflare/dist/src/index.js:8890
      throw new MiniflareCoreError(
            ^

MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.
    at #assembleAndUpdateConfig (/Users/pooya/tmp/miniflare-reproduction/node_modules/miniflare/dist/src/index.js:8890:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Mutex.runWith (/Users/pooya/tmp/miniflare-reproduction/node_modules/miniflare/dist/src/index.js:3861:16)
    at async #waitForReady (/Users/pooya/tmp/miniflare-reproduction/node_modules/miniflare/dist/src/index.js:8940:5)
    at async Miniflare.dispatchFetch (/Users/pooya/tmp/miniflare-reproduction/node_modules/miniflare/dist/src/index.js:9004:5)

Fantastic minimal reproduction! Thank you @pi0
I suspect this is an issue with workerd itself rather than Miniflare...

Ideally we need a reproduction that only uses workerd, then I can transfer this over to https://github.com/cloudflare/workerd

I just tried deploying the worker and it actually seems to be working fine in workerd 😕 : https://wasm-bug-worker.dario-piotrowicz.workers.dev/

I managed to reproduce this just with workerd: https://github.com/petebacondarwin/toplevel-async-wasm-workerd-repro
So I propose we transfer this issue there...
Interestingly @pi0 - the issue can be avoided if you do not use the async WebAssembly.instantiate() call but instead use the sync new WebAssembly.Instance() constructor.


Update puffin to 0.16

This change breaks the example. It still uses the old puffin-imgui crate which links an old puffin crate, which ends up having no data when running it. But I'll look into updating, it will likely require other stuff to be updated as well.

Completed in #54


BUG: Hamburger button

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Fix the alignment of the hamburger button with nav-items

Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a Hacktoberfest'23 contributor
[ ] I want to work on this issue

@dakshsinghrathore assign it to me

@dakshsinghrathore please look into the PR and close the issue if it is completed


[Bug Report] not full sidebar screen

Element UI version
1.3.0-beta.2
OS/Browsers version
chrome51
Vue version
2.3.2
Reproduction Link
https://jsfiddle.net/e0afe187/
Steps to reproduce
侧边栏不是垂直全屏的，只有一小部分
What is Expected?
希望能在左面上下是通透的。
What is actually happening?
左面上下不是通透的额

I upated jsfiddle link to  https://jsfiddle.net/e0afe187/

This should be handle on the user's end.


Not able to attach the confirm event to un-rendered buttons in data table

Hi,
I am using data table to show records and which can be deleted. I have used jquery.confirm for confirmation dialog. I am showing 10 rows in table for which confirmation works perfectly. But when pagination or sorting is done then for rest of the records confirmation is not working. I tried '.on' but it didn't work. After using '.on' i need to click delete button twice, which i want to avoid.
Can somebody help me on this? Below is my code.
Html code:

        Name
        FileType

    @foreach (var item in Model)
    {

<EMAIL_ADDRESS><EMAIL_ADDRESS>
                <button type="button" title="Update" class="glyphicon glyphicon-pencil" onclick="EditClick(this)"></button>
                <button type="button"<EMAIL_ADDRESS>title="Delete" class="confirm glyphicon glyphicon-trash" ></button>

            <td<EMAIL_ADDRESS>

    }

Javascript code:
$(document).ready(function () {
$("#tableD").DataTable({
    ordering: false,
    sort: false,
    columnDefs: [{
        "defaultContent": "-",
        "targets": "_all"
    }]
});

})
$('.confirm').confirm({
title: "Delete Confirmation",
text: "Do you want to delete row?",
confirm: function (button) {
         button.fadeOut(2000).fadeIn(2000);
        deleteItem(button.val(), "DeleteData") // Call delete method on confirmation
    },
    cancel: function (button) {
        button.fadeOut(2000).fadeIn(2000);

    },

    confirmButton: "Yes",
    cancelButton: "No",
    confirmButtonClass: "btn-default",
    cancelButtonClass: "btn-default"

});

Thanks in advance.

Using $document.on("click", ".button",function(){}); should do the trick.
Dale
Sent from my iPhone
On Aug 5, 2016, at 1:34 AM, mandarbt <notifications<EMAIL_ADDRESS>wrote:
Hi,
I am using data table to show records and which can be deleted. I have used jquery.confirm for confirmation dialog. I am showing 10 rows in table for which confirmation works perfectly. But when pagination or sorting is done then for rest of the records confirmation is not working. I tried '.on' but it didn't work. After using '.on' i need to click delete button twice, which i want to avoid.
Can somebody help me on this? Below is my code.
Html code:

Name
FileType

    @foreach (var item in Model)
    {

@item.Name
@item.FileTypeName

  title="Delete" class="confirm glyphicon glyphicon-trash" >

@item.DriverId

    }

Javascript code:
$(document).ready(function () {
$("#tableD").DataTable({
ordering: false,
sort: false,
columnDefs: [{
"defaultContent": "-",
"targets": "_all"
}]
});
})
$('.confirm').confirm({
title: "Delete Confirmation",
text: "Do you want to delete row?",
confirm: function (button) {
     button.fadeOut(2000).fadeIn(2000);
    deleteItem(button.val(), "DeleteData") // Call delete method on confirmation
},
cancel: function (button) {
    button.fadeOut(2000).fadeIn(2000);

},

confirmButton: "Yes",
cancelButton: "No",
confirmButtonClass: "btn-default",
cancelButtonClass: "btn-default"

});
Thanks in advance.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/craftpip/jquery-confirm/issues/135, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQw9yGysq-WDhIePdDTFfCHxXtpynG4Sks5qcsuFgaJpZM4JdXoM.


How to update table size if container DOM is resized?

I have a table in a container that might be resized, but the table size is not automatically adjusted properly. Isn't there a function to refresh it?

Hi,
Try to use tableWidth and tableHeight set to "100%" ?


Fixes #19845 no 3d Compilation issue

You true, I had copied it just for a mistake, I've already updated it
On Sun, Jul 1, 2018 at 12:28 PM, Rémi Verschelde<EMAIL_ADDRESS>wrote:

@akien-mga commented on this pull request.
In scene/3d/skeleton.cpp
https://github.com/godotengine/godot/pull/19886#discussion_r199344602:

@@ -691,6 +693,8 @@ void Skeleton::physical_bones_remove_collision_exception(RID p_exception) {
_physical_bones_add_remove_collision_exception(false, this, p_exception);
}

+#endif _3D_DISABLED
I'm not sure #endif can take a named define? Usually we put #endif //
_3D_DISABLED
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/19886#pullrequestreview-133449225,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH9MR8A8mzDZGMXJT27TumBX6k6Z_qOpks5uCKRXgaJpZM4U-RIJ
.


[BETA] Test failure & Typo in "React: Create a Controlled Form" Waypoint

Challenge Name
https://beta.freecodecamp.org/en/challenges/react/create-a-controlled-form
Issue Description
Typo: The lesson states -

The submit handler will be called when the formed is submitted.

Suggested Replacement:

The submit handler will be called when the form is submitted.

Test Failure
Can't get last test to pass [no closed or open issues here, nor on forum], despite testing JSX proving that my code does do what is asked. (I added some html elements to the render() method to prove to myself I wasn't crazy and that the <input/> tag was triggering onChange events that were being handled properly. The extra code I added in the attached codeblock is as follows:

{this.state.input}

The second line should (and does) update with every added or deleted character in the input.
The first line creates a horizontal rule that separates the
 from the
 that displays the value of {this.state.submit}, but doesn't appear until the button is clicked. If the error messages were correct, and "Typing in the input element [doesn't] update the input property of the component's state," then the h2 element shouldn't mirror the input's value.
Browser Information

Browser Name, Version: Firefox 59.0.2
Operating System: Win 8.1, 64-bit
Mobile, Desktop, or Tablet: Desktop

Your Code
class MyForm extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      input: '',
      submit: ''
    };
    this.handleChange = this.handleChange.bind(this);
    this.handleSubmit = this.handleSubmit.bind(this);
  }
  handleChange(event) {
    this.setState({
      input: event.target.value
    });
  }
  handleSubmit(event) {
    // change code below this line
    this.setState({
      submit: this.state.input
    });
    event.preventDefault();
    // change code above this line
  }
  render() {
    return (

        <form onSubmit={this.handleSubmit}>
          { /* change code below this line */ }
          <input value={this.state.value} onChange={this.handleChange} />
          { /* change code above this line */ }
          <button type='submit'>Submit!</button>
        </form>
        { /* change code below this line */ }

{this.state.submit}

{this.state.input}

        { /* change code above this line */ }

    );
  }
};

Your input value should be {this.state.input} instead.

Thanks! The tests pass now. Which implies to me that the testing suite is looking at something other than the state variables themselves. I am just getting started, so I don't know if those state variables are accessible outside of components in React, or if the test is a regex on the JSX. If the latter, and the test is the best it can be, should I edit my issue back down to just the typo?

It's not a regex matching. The test simply compares value of the input with this.state.input. I'm not 100% sure but looks like if value of input is set to this.state.value which doesn't exist, the test fails to grab the input value itself?

Thanks for the peek under the hood. I was a little confused as to why the behavior seemed to work despite my typo (which I only introduced on the fourth try of resetting my code because I couldn't wipe out other, weirder errors.

Can I fix the typo?

@EditB Thanks for your consideration. I already did it. Their are many issues, no one is working on. You can takeup those issues. Make sure you comment on that issue, that you are working on it. So, anyone else don't duplicate his/her efforts. Happy Coding!

Thanks @varunzxzx. I have a browse and see what else I can fix.


feat: set publicDir to false to disable copied static assets to build dist dir

Description
#3141  feature
~I do not recommend setting publicDir to false or null directly.Because this feature only takes effect during build,
if publicDir is set to false,we need special processing when starting vite dev,eg. change publicDir from false to public.
So I think adding a separate build.ignorePublicDir option is clearer and the changes are smaller.~
Support set publicDir to false to disable copied static assets to build dist dir.
This PR modified post-processing：
publicDir:false -- do not process static files
publicDir:true -- set default 'public'
publicDir:'' -- set default 'public'
not set value -- set default 'public'
What is the purpose of this pull request?

[ ] Bug fix
[X] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines.
[X] Read the Pull Request Guidelines and follow the Commit Convention.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I think that build.ignorePublicDir is going to generate confusion. It is not good that the public dir still works during dev.
IMO the best is to have publicDir: false, but completely disallow the public directory feature both in dev and build.

I think that build.ignorePublicDir is going to generate confusion. It is not good that the public dir still works during dev.
IMO the best is to have publicDir: false, but completely disallow the public directory feature both in dev and build.

If publicDir is disabled in dev, all static assets requests may return a 404 error.  We should ensure that 'vite dev' can work normally. If build.ignorePublicDir is confusing, should we change it to another name such as 'build.notCopyAsserts' ?

I'm against the name notCopyAssets as it involves doubled negation
So at least copyAssets with default true
But could you please explain a bit more why there are assets in dev needed but then should be ignored in prod? Or did I understand something wrong?

Taking this a bit further, is include/exclude of glob pattern useful here?

But could you please explain a bit more why there are assets in dev needed but then should be ignored in prod? Or did I understand something wrong?

Thank you for your proposal!
I think you are right, we should make the dev and build have the same behavior. I will try to support 'publicDir: false', disallow the public directory feature both in dev and build.

See #3152 (comment)
@ygj6 we discussed this with Evan, and he approved this feature. The only think is that we should already do the change for the undocumented behavior of publicDir: '' now to mean disabled in User config. So if we change the PR to reflect that (as in the comment above), we can merge this. Thanks for all the discussions here 👍🏼

That’s great, I don’t have a computer around me on holiday now, I will deal with it in a few days.

If I understand correctly, cause this is a feature, we need a third approval 🙂


Remove Titles from Names When Saving the Name

Automatically remove titles from the name field when saving a name.  I will supply a list of titles.

It seems like there is a list of titles that can't be easily confused with people's names. The suggestion is to add this list to the dictionary and have client-side validation that prevents a user from adding a name containing these. This applies to people creation and onboarding.
The validation error should be something along the lines of:
"You must provide a valid name without ranks, titles, and grades. %offendingValue% is not allowed in name fields"

Added to #1972


prep for GA-beta

[x] fix _checkoutCommand; need to debug the checkout for gitlab experience. appears to not download all of the repo correctly.
[x] fix _decorateAuthor; debugging users that should exist still get DEFAULT_AUTHOR
[ ] update documentation in the README.md
[x] add tests -- ALOT OF test cases!
[ ] implement _getOpenedPRs
[x] implement _getPermissions

https://github.com/bdangit/scm-gitlab/commit/154998bfd192f19e6a9fcb0e70a9979ddfd81885
https://github.com/bdangit/scm-gitlab/commit/6c1c137be0d61d4cb0b01bd353cb27a65d96bab1
https://github.com/bdangit/scm-gitlab/commit/dd0255681b3335443b4c2482df9768db5e0ea3a1
https://github.com/bdangit/scm-gitlab/commit/ca8998ebc0f51ec0f5055c38c1230e3c41611bab
https://github.com/bdangit/scm-gitlab/commit/b3b492355122dbff42b503f21c168a9342ce9752
https://github.com/bdangit/scm-gitlab/commit/e6665ea9c48f8ed0a2d01d87463f6d9c12341155
https://github.com/bdangit/scm-gitlab/commit/fb272b72a45d365fc292d74349751856fc8db835
https://github.com/bdangit/scm-gitlab/commit/ea399c8793a961c8867c6b966b5ffe49a3daaf26
yes... i know! these should PRs!

#4

#5 adds support for getOpenedPRs

#9

scm-gitlab plugin is in semi ready condition.  Need people to help test and sort out issues.


Add GCP adapter for S3 compatible interfaces and added data mover interfaces for GCP backend

New updated PR, this PR adds GCP adapter for S3 compatible interfaces and migration scenario from GCP to AWS also tested.

Hi, two suggestions:

Migration from other cloud  to GCP also need to be tested.
Remove duplicated import record, for example, the following two records are duplicate:
"github.com/webrtcn/s3client"
. "github.com/webrtcn/s3client"

Hi,

Migration from other cloud to GCP is done.

"github.com/webrtcn/s3client"
. "github.com/webrtcn/s3client" both import have different significant so it generate errors if removed.
(.) import let  the package's exported identifiers  declared in the current file's file block and can be accessed without a qualifier.so some places it is utilising reference.

Well, for the second one, maybe you can try to reference each identifier exported from the package in the same way, say, with the prefix of (s3client.)
But that is not necessary, just a suggestion.

@sfzeng it is increasing complexity so if current way is accepted please let us know.

OK, go ahead please.

@sfzeng thanks. we are waiting for your final review and merge update.

@Click2Cloud-Gamma It's OK, need @xing-yang to merge.

LGTM~


[Blake Stone] Game fails to run at all.

Game
Blake Stone: Aliens of Gold/Planet Strike
Engine
bstone
Linux Distribution
SteamOS v3.6.21 Beta
Luxtorpeda Version
v71.0.0
Bug description
Both Blake Stone games refuse to start at all.
Steps To Reproduce

Attempt to run Aliens of Gold or Planet Strike.
Insta-crash!

Expected Behavior
Games should start without such a fuss.
Additional Context
No response
Relevant log output
BStone v1.2.13+ac86299e75e3fffae4bf60a20b92b510b1de2684
=======================================================

<<< Start up SDL system manager.
Compiled version: 2.30.10
Linked version: 2.30.10
<<< Start up SDL audio manager.
Built-in drivers:
  "pulseaudio"
  "alsa"
  "dsp"
  "disk"
  "dummy"
Devices:
  1. "Razer BlackShark V2 HS BT"
  Frequency: 48000 Hz
  Channels: 2
  2. "ACP/ACP3X/ACP6x Audio Coprocessor Speaker"
  Frequency: 48000 Hz
  Channels: 2
  3. "ACP/ACP3X/ACP6x Audio Coprocessor Headphones"
  Frequency: 48000 Hz
  Channels: 2
>>> SDL audio manager started up.
Start up SDL event manager.
<<< Start up SDL video manager.
  Modes:
    1280x800 60 Hz
    160x256 59 Hz

Start up SDL mouse manager.
Start up SDL window manager.
Start up OpenGL current context.
>>> SDL video manager started up.
>>> SDL system manager started up.
Looking for game content.

Shut down OpenGL current context.

[ERROR] (jm_free.cpp:754:find_contents) Content not found.
[ERROR] (bstone_sys_message_box_sdl2.cpp:93:show)
(bstone_sys_exception_sdl2.cpp:26:sdl2_ensure_result)
(bstone_sys_exception_sdl2.cpp:15:sdl2_fail) No message system available

There was an issue with the new build which I've fixed. Can you see if this fixes it for you?
With this, I was able to play the game with the Apogee Throwback Pack.
If this does not work for you, link the game or games you're trying to play.

Got it working now, after moving the bstone executable to the games' root directories.

What game are you playing? It shouldn't be necessary to manually move the binary around

Can you send me links to those games on steam?

Aliens of Gold: 358190
Planet Strike: 358310

Thanks! I'll see if I can replicate this

https://store.steampowered.com/app/358190/Blake_Stone_Aliens_of_Gold/
https://store.steampowered.com/app/358310/Blake_Stone_Planet_Strike/

Tested both and they work fine on my end without any changes.


Oskar gdev 2548 fix scoring

Pull request questions
Which issue does this address
Issue number: 2548
Why was change needed
Changes based on customer requests and bug fixes.
What does change improve
Makes scoring more accurate and handles bugs.

Thanks for a great review @timadair.  I have addressed or responded to your points.  Let me know if you are happy with them.  I understand that you are not comfortable with approving the PR.  No problem.  This has been a great help.


wordRight at the end of the final line jumps back to the beginning of the line.

not sure when this got fixed but I can no longer reproduce it


Feature request: Keychords

What are keychords?
Keychords are keybindings that can be chained to one another. A famous example is Emacs’ keybind for opening a file C-x C-f (read it as Ctrl-x then Ctrl-f).
Why keychords?
While simple keybindings are easy to implement and fast to press, their number can become quickly limited on a keyboard, especially when trying to keep things organized. Accidentally hit alt when typing Super+q? Guess your computer will shut down instead of just going to sleep.
While keychords require a bit more hand movements, the amount of assignable keybindings becomes virtually limitless while allowing the user to keep their keybindings organized.
Additional and implementation ideas
Keybindings could be organized in keymaps which could be accessed by other keybindings. I believe this is how i3 handles their own keychords.
Something I really enjoy from Emacs and StumpWM is their which-key-mode showing the current keymap’s keybinds, so we never forget them.

Do you mean something like this?

submap is the feature you are looking for on the wiki

Submaps look like a different feature. From what I understand, once you enter a submap, you will not exit it if you press another key than Escape. This looks like an interactive keymap rather than a simple keymap.
With keychords, there is no need to press escape, you simply press for instance Super+Space a b and you’re done, the keybind is executed and you’re back on the global keymap.

From what I understand, once you enter a submap, you will not exit it if you press another key than Escape. This looks like an interactive keymap rather than a simple keymap.

no, read the wiki

Is that a difference between the functions bind and binde? If so, I think there should be at least a paragraph about it, I find it very easy to miss.

what

Per the wiki and the link shared earlier:

if you press ALT + R, you can enter a “resize” mode, resize with arrow keys, and leave with escape

Correct me if I’m wrong, but if I type Alt+R, I can type Right/Left/Up/Down as many times as I wish, and I’ll stay in the submap, right? Is that due to the code using binde instead of bind? Or is that due to the bindings being in the submap itself?
As I understand the Wiki, the only way to exit the submap is to reset it with something like bind=,escape,submap,reset. The comment given on that line seems to indicate resetting the submap is the only way to exit it, which is not the behaviour of keychords.

I believe this should be explicitly documented then, the only mention of binde I can find in the wiki is the example code, and it can people believing submaps must be explicitly left, especially because of this line:

IMPORTANT: do not forget a keybind to reset the keymap while inside it! (In this case, escape)

As I now understand it, this is only because all the other bindings in the example use binde, this should also be explained.

binde is mentioned in https://wiki.hyprland.org/Configuring/Binds/#bind-flags, but yes the submap section can be improved.

https://github.com/hyprwm/hyprland-wiki/commit/75ae8c5c9fe3041bb730c932033494c379c6b78e fixed here.

should we close this then? Behavior possible already.


fix(mappings): remove unnecessary div around create mappings button

This PR fixes a spacing issue for the empty state of the mappings page. By removing the unnecessary div, PatternFly styles seem to do the expected thing without any modification. Should help close https://github.com/konveyor/forklift-ui/issues/641

Are you sure this doesn't break the tooltip that can appear when the button is disabled because there are insufficient providers? (Can't test now, just posting before I forget)


Bump version to v22.11.1

Release notes: https://github.com/ElementsProject/lightning/releases/tag/v22.11.1
Build was successful on arm64 and amd64. To run I had to use --database-upgrade=true.

merged to master

@nolim1t thanks! Could you tag it on GH, to trigger a Docker image build with the version as a tag?


valhalla: upstream fix for gcc-13 build

Without the change valhalla build fails on staging-next as https://hydra.nixos.org/build/245511803:
/build/source/src/baldr/transitdeparture.cc: In constructor 'valhalla::baldr::TransitDeparture::TransitDeparture(uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t, bool, bool)':
/build/source/src/baldr/transitdeparture.cc:24:16: error: 'runtime_error' is not a member of 'std'
   24 |     throw std::runtime_error("TransitDeparture: Exceeded maximum transit line Ids per tile");
      |                ^~~~~~~~~~~~~
/build/source/src/baldr/transitdeparture.cc:3:1: note: 'std::runtime_error' is defined in header '<stdexcept>'; did you forget to '#include <stdexcept>'?
    2 | #include "midgard/logging.h"
  +++ |+#include <stdexcept>

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Yeah, master would be the best target.
Sometimes maintainers prefer fixing it where there regression was introduced to ease testing by ofborg. Sometimes they prefer to bucked fixes by rebuild amount.
Retargeted to master.


Format

LGTM!

Please name PR as "Types extraction from PostgreSQL database." or something along these lines.


Updating uPortUartInit() for Power Savings

On an nRF9160, we can save several mA by disabling the serial port with CONFIG_SERIAL. Please consider wrapping the the KERNEL_VERSION_MAJOR block with "#ifdef CONFIG_SERIAL" so an error isn't thrown when trying to compile.

Ah, so I guess uart0 disappears if CONFIG_SERIAL is not defined?

Correct.
For anyone else searching, this is the error you will get without the wrapper.
d:/ncs/toolchains/31f4403e35/opt/zephyr-sdk/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd.exe: app/libapp.a(u_port_uart.c.obj): in function uPortUartInit': D:\ncs\Code\ubxlib\port\platform\zephyr\src\u_port_uart.c:344: undefined reference to __device_dts_ord_78'
d:/ncs/toolchains/31f4403e35/opt/zephyr-sdk/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd.exe: D:\ncs\Code\ubxlib\port\platform\zephyr\src\u_port_uart.c:344: undefined reference to `__device_dts_ord_80'

That is exactly what I have and it works.

Perfect: testing has passed, will merge tomorrow after review.

Now available on master here at this commit:
https://github.com/u-blox/ubxlib/commit/97f7c89c6a4e633bc8405e01abb58c9e2501cd60
Will delete the preview branch and close this issue: please feel free to re-open it or open another if there are problems.


CCM-5100: Update repo description for nhs-notify-iam-webauth

Description
The nhs-notify-iam repo has been renamed to nhs-notify-iam-webauth and this PR updates the repo description accordingly

Context

Type of changes

[ ] Refactoring (non-breaking change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Documentation

Checklist

[x] I am familiar with the contributing guidelines
[x] I have followed the code style of the project
[ ] I have added tests to cover my changes
[x] I have updated the documentation accordingly
[ ] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Merging as a marginal improvement, will need revisiting once we decide how repo titles should be formatted


Add support for PEP 695

Summary
PEP 695 adds new syntax for type parameters and generics. A few examples:
class ClassA[T: str]:
    def method1(self) -> T:
        ...

type ListOrSet[T] = list[T] | set[T]

There are a few pieces of work involved in this:

Adding these elements to the AST.
Adding these elements to the parser (especially the type soft keyword).
Adding these elements to the visitor, and to any rules that do custom visiting.
Adding these elements to our semantic model (need to look into how scoping and resolution works).

This will be Ruff's first time undergoing a significant grammar and syntax change (apart from adding structural pattern matching), so it's a great opportunity to set the project's standards for keeping up with Python's evolution.
Specifically, the final Python 3.12 release is expected on 2023-10-02. We should aim to support PEP 695 by that date at the latest.

\cc @zanieb who's working on this :)

Progress on the Rust Python parser can be tracked at https://github.com/RustPython/Parser/issues/82

Additional resource; may be useful for refinements to scoping https://jellezijlstra.github.io/pep695


cant find \r in regex mode

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2
OS Version: Windows 10 21H1

Steps to Reproduce:
select CRLF for line end sequence
write some lines
abc\r\n
def
ctrl + f to open search
select regex mode (.*)
try \n: new lines are selected
try \r: no results
Also, if you try replacing \n with \r\n, \r is written literally instead.
I'm reopening this issue from five years ago.
There is also this StackOverflow question from almost two years ago about this same issue.

Is it possible to search for files with \r\n ending?

as noted in the linked issue, this is by design. workbench.action.editor.changeEOL can be used to change line endings.


RFC: try_catch

This RFC proposes a new Context method for catching any JavaScript exceptions that may be thrown during the execution of a computation. The result of the API uses Rust's standard Result enum to distinguish between normal return values and exceptional values:
match cx.try_catch(|cx| { cx.throw(42) }) {
    Ok(v) => { /* ... computation produced a normal result ... */ }
    Err(v) => { /* ... computation threw an exception ... */ }
}

Rendered

A user may choose not to operate on the Result of a try_catch. With the current design, a small amount of boilerplate to transform the Result<Handle<'a, T>, JsValue<'a>> into a JsResult<'a, T> for returning from a method:
let value = match result {
    Ok(v) => Ok(v),
    Err(err) => cx.throw(err)?,
};

I propose adding to this RFC an implementation of JsResultExt to remove ease this boilerplate:
impl <'a, V, E> JsResultExt<'a, V> for Result<Handle<'a, V>, Handle<'a, E>>
where
    V: Value,
    E: Value,
{
    fn or_throw<'b, C: Context<'b>>(self, cx: &mut C) -> JsResult<'a, V> {
        match self {
            Ok(v) => Ok(v),
            Err(err) => cx.throw(err),
        }
    }
}

This would simplify to:
let value = result.or_throw(value)?;

Notes from feature flagged implementation:

There are some additional trait bounds required (notably UnwindSafe for legacy)
Lifetimes are slightly different (requires 'b: 'a)
Documentation should include the panic behavior on a manually constructed Err(Throw)


[wip] misc bugfix

Codecov Report

Merging #929 into master will increase coverage by 0.02%.
The diff coverage is 4.34%.

@@            Coverage Diff            @@
##           master    #929      +/-   ##
=========================================
+ Coverage    7.63%   7.65%   +0.02%
=========================================
  Files         357     356       -1
  Lines       55508   55230     -278
=========================================
- Hits         4236    4228       -8
+ Misses      50874   50604     -270
  Partials      398     398

Flag
Coverage Δ

#aFlag
7.65% <4.34%> (+0.02%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/hostman/storageman/nbd/nbdman.go
55.88% <100%> (ø)
:arrow_up:

pkg/util/ucloud/region.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/regiondrivers.go
20% <0%> (ø)
:arrow_up:

pkg/compute/models/cloudsync.go
0% <0%> (ø)
:arrow_up:

pkg/util/aws/disk.go
0% <0%> (ø)
:arrow_up:

pkg/util/esxi/manager.go
0% <0%> (ø)
:arrow_up:

pkg/util/esxi/vdisk.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/purge.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/disk.go
0% <0%> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d9684...c84debb. Read the comment docs.


add fix for unknown timezone

Fix https://github.com/omnistrate/saasbuilder/issues/138

@coderabbitai review


Datasweet formula not show values when aggregation is 0

Hello!
Thanks for the excelent plugin!
Just one question, i've noticed that when the aggregation that we are using in the formula is zero, the metric of Datasweet does not shows the value zero.
Is there any way to accomplish this?
Thanks in advance!
Example:

Hi @gferrette, what version of Kibana are you using? Here below, a 6.7.1 does the job correctly.

Hello Lionel!
Thanks for the quick response!
I'm using Kibana on version 7.0.1, and datasweet version from the package https://github.com/datasweet/kibana-datasweet-formula/releases/download/v2.2.1/datasweet_formula-2.2.1_kibana-7.0.1.zip
Do you know if on a later version of Kibana it will work?
Thanks in advance!


Issue on recent new update 2 hours ago

h. MGM-v5-MIDSIDE-44100-BETA1
i. MGM-v5-MIDSIDE-44100-BETA2
j. MGM-v5-Vocal_2Band-32000-BETA1
k. MGM-v5-Vocal_2Band-32000-BETA2
l. LOFI_2band-1_33966KB
m. LOFI_2band-2_33966KB
n. HighPrecison_4band_1
o. HighPrecison_4band_2
p. NewLayer_4band_1.pth
q. NewLayer_4band_2.pth
r. NewLayer_4band_3.pth
s. Ensemble All Models (14 Models) - Final Outputs Save to Ensembled Folder!
Type the letter associated with the option you choose and hit 'Enter': s
Include Deep Vocal Extraction Instrumental? [Y/N]: n
Ensemble All Models
loading MGM-v5-4Band-44100-BETA1... done
C:\Users\jobas\AppData\Local\Programs\Python\Python37\lib\site-packages\librosa\core\audio.py:162: UserWarning: PySoundFile failed. Trying audioread instead.
warnings.warn("PySoundFile failed. Trying audioread instead.")
loading & stft of wave source... Traceback (most recent call last):
File "ensemble_inference.py", line 385, in
main()
File "ensemble_inference.py", line 250, in main
X_spec_s[d] = spec_utils.wave_to_spectrogram(X_wave[d], bp['hl'], bp['n_fft'], mp, True)
File "C:\Users\jobas\OneDrive\Desktop\Desktop\Documents\Vocal Remover Update\lib\spec_utils.py", line 35, in wave_to_spectrogram
elif mp.param['mid_side_b']:
KeyError: 'mid_side_b'
Press any key to continue . . .

all the recent update on you did the last 4 hours or so have alot of error it rewind the music and error

Fixed


Construct Mirror Tree

I would like to implement the algorithm for constructing a mirror tree for given binary tree.

Is this issue still open? I would like to contribute to it!!


[Create New Issue]:  Age Calculator

Calculator Functions
The objective is to create a simple application to tell age of a person to the present day.
The output will be of the form: - Age: YY years MM months DD days. Ex:- 11 years 6 months 13 days.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign


Toolkit - 200.3.0 Release checklist, v.next merged with main

Merged v.next into main in the branch.
No build errors, done a sanity test, no issues noticed.
No diff between v.next and v.next_merged_with_main branches.
Note: We want to cherry pick - Brian's changes for https://devtopia.esri.com/runtime/qt-common/issues/8690.

Cherry picked https://github.com/Esri/arcgis-maps-sdk-toolkit-qt/pull/605 to the branch @bri12415


{{#each}} iteration includes undefined first time computed array is changed

Test: http://jsfiddle.net/pzyzcpf0/2/
I'm running into this with 0.7.3, but after writing the test I noticed it passes with edge version. Just thought I'd document it here anyway.
In the test if you change the check() function to use console.log() you can see that "undefined" is logged 3 times, once for each item of the array that is filtered out. It only happens the first time the computed array changes; subsequent changes behave as expected. Open the dev console and check out http://jsfiddle.net/v4r2x2d4/1/

Since it's appeared to be fixed in 0.8, my suggestion would be to upgrade ASAP :smile:.
I'm going to close this thread as wontfix, but as you said, it's good to have this bug documented nonetheless.


Remove welcome mail customize your wizard link

Doesn't take you to wizard customization anymore.

Hi Matt! Sorry this happened, but can you maybe send a screenshot or maybe explain a little better? What browser are you using?
TJ

I've removed the customize wizard link from the 'Welcome email' template.


bug: regular search won't update label in other window when the pattern matchs nothing in current window

Did you check docs and existing issues?

[X] I have read all the flash.nvim docs
[X] I have searched the existing issues of flash.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.1
Operating system/version
MacOS 13.2.1
Describe the bug
In regular search mode, if the pattern matches nothing in current window, then it won't show the correct labels in others windows.
Steps To Reproduce

Expected Behavior
Labels will be shown in other windows correctly even the pattern match nothing in current window.
Repro
{
  "folke/flash.nvim",
  event = "VeryLazy",
  keys = {
    {
      ";",
      mode = { "n", "x" },
      function()
        -- default options: exact mode, multi window, all directions, with a backdrop
        require("flash").jump()
      end,
      desc = "jump by multiple keys",
    },
    {
      "t",
      mode = { "n", "o", "x" },
      function()
        require("flash").treesitter()
      end,
      desc = "select by Treesitter node",
    },
    {
      "r",
      mode = "o",
      function()
        require("flash").remote()
      end,
      desc = "Remote Flash",
    },
  },
  opts = {
    modes = {
      char = {
        enabled = false,
      },
    }
  },
}

I'm not able to reproduce this.
Do you have lazyredraw or something similar enabled?

My settings

lazyredraw: off
Not map /
my current flash.nvim: 5e1096e

I have updated my flash configuration for repo, but it is nothing special. I am guessing it is due to conflict with other plugins. However I do not have any clues about this.
I will update any findings once I have.

Closing this, since I can't reproduce it with a minimal repro.lua


Updated the main README.md and icon README.md

Updated README.md to enhance readability and understandability

Thank you for the contribution!

Hello,
The first one seems like an unintentional error however the in the second
one including 'of' suggests the amount in question is a part of the sale.
If 'of' doesn't seem right, 'from' is a more clear choice for this instance.
I hope this helps.
Best,
Shahzeb
On Mon, 5 Oct 2020, 9:07 pm Boris<EMAIL_ADDRESS>wrote:

@whyboris commented on this pull request.
Thank you for the improvements!
I think there are 2 changes that are not needed - let me know your
thoughts 🤝
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/whyboris/Video-Hub-App/pull/542#pullrequestreview-502208221,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSR2HM3CXBSDUOO4FBIH7DSJHVL7ANCNFSM4SBL4SZA
.

How about a re-wording of the whole thing?
$3.50 of every sale goes to the [Against Malaria Foundation](https://www.againstmalaria.com/), a [_cost-effective_](https://www.givewell.org/charities/top-charities) charity rated highly by [GiveWell](https://www.givewell.org).

Also, are you suggesting $3.50 from rather than $3.50 of ? Either one is fine -- seems like the same meaning to me.

Rewriting the entire text isn't necessary, it is perfectly clear.
"3.50 of" and "3.50 from" do entail the same meaning, but "from" is more
direct and explicit in comparison to "of" hence a better option, in my
opinion.
Best,
Shahzeb
On Mon, 5 Oct 2020, 10:48 pm Boris<EMAIL_ADDRESS>wrote:

How about a re-wording of the whole thing?
$3.50 of every sale goes to the Against Malaria Foundation, a cost-effective charity rated highly by GiveWell.
Also, are you suggesting $3.50 from rather than $3.50 of ? Either one is
fine -- seems like the same meaning to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/whyboris/Video-Hub-App/pull/542#issuecomment-703787182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSR2HLDCD7FGBEHY5F2N2LSJIBINANCNFSM4SBL4SZA
.

Sounds good. I'm still urging reverting your change from including of before AMF -- and keeping the sentence as it was before your change.

@Shahzeb-Kazmi thank you for the proposed changes. I decided to resolve the conflicts myself and revert one of your proposed changes to how it was before.
Thank you for the contribution 🤝


prompt and --no-color

Hello
When you exec fly staging --no-color and use local.prompt('Enter value:'); then fly prompt with gray color. It must be without color normally.
Thank, Ami44

Thanks for reporting, will be fixed in the next days.

Thank

0.6.1 has been released and should fix this problem :beers:


Info Window <==> Map Item Mismatch

Clicking on Info Window for a specific feature focuses on a different feature as the one currrently in focus on the map.
How to replicate

Open the Kujaku app
Open the Map activity
Open the info window by clicking on any feature on the map
Scroll to the first info window & click on it
Note the feature
Click on the second info window & note it's position
Click on the currently focused window

the carousel focuses on a different info window

Unblock when #23 is fixed.


Using HTTP challenge provider results in pod stuck at ContainerCreating stage

From slack:
" Trying to create http ingress with certificate. Following this guide: https://github.com/appscode/voyager/blob/master/docs/user-guide/certificate/create.md#create-certificate-with-http-provider. After created the ingress, pod stuck at ContainerCreating stage because the xxxxxx-cert-secret-volume is not mounted. According to the guide, it suppose to be created after the cert resource is created. Looks like a chicken and egg problem. Did I miss anything? "

I manage my own dns using a solution from BlueCat Networks. I manually created the domain name there.

This is also addressed in #505

Fixed in #506


Incorrect extruded terrain tiles requested/displayed

@chrisgervang
Description
I've been exploring the new terrain layer a bit. When viewed with positive pitch, and when the terrain is extruded, it appears that tiles are removed before they actually leave the viewport. Here's a gif of the Sierra Nevada, California (i.e. terrain with significant elevation), where you can see that terrain/surface tiles are prematurely removed.

This doesn't happen in SF at sea level, or when viewed directly from above, so I presume it's due to the terrain extrusion.
There are also a few other small things that "feel weird" due to the terrain extrusion:

when rotating the map (i.e. cmd + click + pan), the map rotates around the "elevation zero" clicked point. So it doesn't feel like the map is rotating around the point actually picked, since the picked point has positive elevation.

It's easy to zoom in below the terrain extrusion.

I don't know how hard these are to fix, and I understand if you don't want to tackle every 3D terrain edge case. As it is, the terrain layer is really cool!
Repro Steps
import React from 'react';
import {render} from 'react-dom';
import DeckGL from<EMAIL_ADDRESS>
import {TerrainLayer} from<EMAIL_ADDRESS>import {StaticMap} from 'react-map-gl';

const INITIAL_VIEW_STATE = {
  latitude: 37.1,
  longitude: -118.86,
  zoom: 13,
  bearing: -100,
  pitch: 56
};

const TERRAIN_IMAGE = `https://s3.amazonaws.com/elevation-tiles-prod/terrarium/{z}/{x}/{y}.png`;
const SURFACE_IMAGE =<EMAIL_ADDRESS>
const ELEVATION_DECODER = {
  rScaler: 256,
  gScaler: 1,
  bScaler: 1/256,
  offset: -32768
};

export default function App({
  surfaceImage = SURFACE_IMAGE,
  wireframe = false,
  initialViewState = INITIAL_VIEW_STATE
}) {
  const layer = new TerrainLayer({
    id: 'terrain',
    minZoom: 0,
    maxZoom: 17,
    strategy: 'no-overlap',
    elevationDecoder: ELEVATION_DECODER,
    terrainImage: TERRAIN_IMAGE,
    surfaceImage,
    wireframe,
    color: [255, 255, 255]
  });

  return (
    <DeckGL
      initialViewState={initialViewState}
      controller={true}
      layers={[layer]}
    >
      <StaticMap
        mapStyle="https://raw.githubusercontent.com/kylebarron/fiord-color-gl-style/master/style.json"
        mapOptions={{hash: true}}
      />
    </DeckGL>
  );
}

export function renderToDOM(container) {
  render(<App />, container);
}

Environment (please complete the following information):

Framework Version: deck.gl master
Browser Version: Chrome 80.0.3987.116
OS: Mac OS X 10.15.3

Logs
None

When TileLayer calculates the geo bounds of a viewport, we call viewport.unproject(screenPoint), which by default returns a location at z=0. This is usually fine until all data has significant z, as evident in the use case of TerrainLayer.
var viewport = new WebMercatorViewport({width: 800, height: 600, longitude: 0, latitude: 0, zoom: 10, pitch: 60});

viewport.unproject([800, 600]);
// [ 0.1741263234231441, -0.26118858051076876 ]

viewport unproject([800, 600], {targetZ: 1000});
// [ 0.16905832765026527, -0.2691632761216681, 1000 ]

We could add a zRange prop to TileLayer to control the tile generation. TerrainLayer will need to figure out what z to request, though - maybe using the combined elevation range from all visible tiles? @chrisgervang

I'm assuming this would be updated here?
https://github.com/uber/deck.gl/blob/4e1c12cfd1e0b6f9bb8e2091dddd95e2313d05aa/modules/geo-layers/src/tile-layer/utils.js#L158-L175


Markdown tutorial

One section in the Foundations outline that is still blank: Formatted text in the notebook with Markdown
I still think this is important enough to cover, as it's a foundational skill for both working with notebooks and collaborating on GitHub.
If anyone has any useful source material for this, drop some links here!

As discussed at today's EWG meeting, some great source material from Unidata is here


[SPARK-48578][SQL][FOLLOWUP] add UTF8 string validation related functions

What changes were proposed in this pull request?
Fix the dataType for make_valid.
Why are the changes needed?
Wrong dataType was returned originally.
Does this PR introduce any user-facing change?
Yes, make_valid will now work properly.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master.


iox-#1533 Standalone roudi environment

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[x] Assign PR to reviewer

Notes for Reviewer

This PR creates a separate package for the RouDiEnvironment which does not depend on gTest and can also be build without the tests. This is important for the Rust bindings since they need the RouDi environment for its own tests but not the iceoryx C++ tests which take quite long to build.
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #1533

@mossmaurice @dkroenke @MatthiasKillat @elfenpiff
I came to the conclusion that it was not one of my brightest moments to add all the committer as reviewer since everybody would think that another one would already review. My new approach is now to ping all the committer in a comment and the ones who like to do the review can add themself as reviewer. I hope this makes it more clear when a PR has sufficient reviewers :)


F3D exits with error code 0 (success) despite an error having occurred (invalid json config file)

Describe the bug
When running f3d with an invalid json file as input to the --config commandline parameter, it exits with an error message output on stderr but returns exit code 0 to the shell, which signifies success.
The error message that f3d outputs looks like this:
"/tmp/myconfig.json" is not a file of a supported file format.
This is a headless build of F3D, interactive rendering is not supported

This constitutes 2 distinct problems;

F3D exists with 0 when clearly there is an error preventing normal operation
F3D tries to default to interactive mode upon failing to read the json and subsequently fails since we are using the headless version which has no support for interactive mode.

To Reproduce
Steps to reproduce the behavior:

Create an invalid json file on disk named test.json
Run headless version of F3D (other versions may be affected as well) like so: f3d --config=test.json

Expected behavior
I expect the program to report the error and exit with a non-zero exit code such as 1
System Information:

Debian 11 x64 inside docker
F3D v2.2.1 headless

Probably related to https://github.com/f3d-app/f3d/issues/310
Are you using the occt plugin?

Please should your "myconfig.json" file

here is the file that was invalid for @mrdeveloperdude , but it is working well for me.
Test_files_F3D.zip
Lets consider that for this issue, the .json is just and we should improve error management in this context

Original info from the Discord discussion:

Commandline looks like this:
/usr/bin/f3d --config= /tmp/1FGYnjiFIDanGgzNtCGOBT0bCfaO1fzdu_1702839294626.json /tmp/1FGYnjiFIDanGgzNtCGOBT0bCfaO1fzdu_1702839294626.stl
.stl file is present and should be valid
The error output produced by f3d looks like this:
"/tmp/1FGYnjiFIDanGgzNtCGOBT0bCfaO1fzdu_1702839294626.json" is not a file of a supported file format
This is a headless build of F3D, interactive rendering is not supported
(produced on stderr)

"foo.bar" is not a file of a supported file format is the message you get when opening an invalid scene/model/3d file.
The command /usr/bin/f3d --config= foo.json bar.stl has a space after --config= so config is actually "" and foo.json is part of the inputs. --config=foo.json (equal and no space) or --config foo.json (no equal) should work, assuming the json file is valid
Even though this is not a bug, possible improvements on F3D's side include:

maybe the model loading error message could be more specific? eg. "foo.bar" is not a file of a supported model/scene/3D file format, could not open 3D model/scene "foo.bar" (unsupported format), ...
--config="" (and equivalent --config=  typo) should be invalid or at least give a warning (ideally that would mean using a proper optional type to mean "no value" internally instead of an empty string so the app can tell the difference. Or allow multiple --config arguments so empty vector is ok but empty/blank elements can be treated as invalid or at least suspicious)
maybe failing to load a model is fine in interactive mode but it should be an error in rendering to file mode? related question: what about multiple inputs when rendering to file, should that generate a warning when all but the first are ignored?

Ask and you shall receive, @snoyer :)

https://github.com/f3d-app/f3d/pull/1111
https://github.com/f3d-app/f3d/pull/1112

So I did not adress the incorrect syntax --config= path/to/conf.json. cxxops is unhelpfull so this will wait for #434

All other point raised by @snoyer have been adressed.


Update to Cedar-14

When deploying to heroku I got this warning message:
Cedar-10 will reach end-of-life on November 4th, 2015.
 !   Upgrade to Cedar-14 at your earliest convenience.
 !   For more information, check out the following Dev Center article:
 !   https://devcenter.heroku.com/articles/cedar-14-migration

This has to be done on the heroku settings, has nothing to do with DOS.


Finish up bloom logic

Make sure we have proper sizing per optimality equations
Combining blooms together as more info is discovered
Resizing at saturation point

Does resize relate to scalable bloom filters, chains of bloom filters...


[WIP] New permission types

I have started to refactor the bitwise permission into its own module. This will to allow other encodings like json, as suggest here #470
Currently it is very much work in progress, but as of now I have moved the bitwise encoding to its own module and all the old tests parses. Next task is to implement a json encoder and then make the interface simpler to make it easier for people to write their own encoders.
To avoid breaking changes I didn't change the module name from bitwise to permissions, but maybe it is something we should consider?

@Hanspagh I will look through this later today or tomorrow but I'm loving the refactoring so far! I'm all for improving the maintainability of the code. 🎉

@Hanspagh now would be the time to change the module name. While V2 is merged, it has not been released, and this could be included as V2 is a breaking change.
Thoughts?
cc @yordis

Definitely, prefer to do the changes that would introduce breaking change as V2

I have now renamed the base permission module and added text and atom encoding modules. Fell free to have a look.

Any feedback on this?

@Hanspagh sorry, I wasn't aware if this was ready for code review or not. I will do some CR today.

Sorry @Hanspagh, like @yordis I saw the WIP I thought this was still being worked on. I removed the label and I'll look this over today.

@doomspork should we use do ... end block over do:  all the time?
This is the only thing that I would give feedbacks so far but I am not sure if that should be the case.

@yordis only if it is multiple lines. I think trying to use , do: with long single-line functions makes it difficult to read.

I sorry for the long delay, I will fix the last requested changes today

Fixed the pipelines issues, bad habit of just putting everything in a pipe

@Hanspagh travis is failing btw

Codecov Report

Merging #585 into master will increase coverage by 0.7%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #585     +/-   ##
=========================================
+ Coverage   84.97%   85.68%   +0.7%
=========================================
  Files          17       20      +3
  Lines         406      426     +20
=========================================
+ Hits          345      365     +20
  Misses         61       61

Impacted Files
Coverage Δ

lib/guardian/permissions/permissions.ex
90.47% <ø> (ø)

lib/guardian/permissions/bitwise_encoding.ex
100% <100%> (ø)

lib/guardian/permissions/text_encoding.ex
100% <100%> (ø)

lib/guardian/permissions/atom_encoding.ex
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c1f5c...52ede25. Read the comment docs.

Travis should be happy now

Thank you @Hanspagh!!

@yordis would you like to prep the next release?

@doomspork Aye!
Then I need to close https://github.com/ueberauth/guardian_phoenix/issues/2