runtime: lock order violation between gscan and profInsert after CL 544195

#!watchflakes
post <- builder ~ `.*-staticlockranking` && log ~ `lock ordering problem` && log ~ `profInsert`

https://build.golang.org/log/9ef94ae07bd07605e17fcd241ef0d38d5064b41f
https://build.golang.org/log/3f80d959a6cc683334f8521b8a3b002dda1bd6b3
https://build.golang.org/log/a5bfdd06fa69808fe6378b412610e65b06ddd8ff
Taking profInsert after gscan is indeed an explicit violation based on our defined lock order: https://cs.opensource.google/go/go/+/master:src/runtime/mklockrank.go;l=125-138;drc=23c0d30244d5e38d928e68661bf39458eb85d2b2.
That said, I am currently confused about the entire STACKGROW category (long day, perhaps). As far as I can tell, the gscan "lock" is only ever held from the system stack, so I don't understand how any of these other locks could "grow the stack", or what exactly we are protecting against.
cc @rhysh @mknyszek

Should this be a release blocker? Lock inversion in the runtime seems like a pretty severe bug. 😅
(Or is this an existing issue that was only recently exposed by testing?)

It should be a release blocker until we understand better. It is a new issue, not just uncovered.

I'd thought this was an issue with instrumentation / reporting, but it's not: Although the (new in Go 1.22) code for adding runtime-internal lock contention events to the mprof hash table is guarded by a check to run only when the last lock is released (https://github.com/golang/go/blob/400e24a8be852e7b20eb4af1999b28c20bb4ea21/src/runtime/mprof.go#L673, checking gp.m.locks==1 because its caller has yet to decrement the count down to zero, https://github.com/golang/go/blob/400e24a8be852e7b20eb4af1999b28c20bb4ea21/src/runtime/lock_futex.go#L134), the gscan lockrank appears to not be an actual "lock/unlock" mutex. The lock rank is used directly (https://github.com/golang/go/blob/400e24a8be852e7b20eb4af1999b28c20bb4ea21/src/runtime/proc.go#L1082) without (it seems) resulting in a change to gp.m.locks.
I'm not up to speed on gscan / casgstatus / castogscanstatus.
Does that look like an accurate description, @prattmic ? If so, then it seems the lock rank builder is trying to warn us of a real problem.

Come to think of it, I think I may have been the one that added the Gscan lock rank. It was because we'd encountered a few Gscan-related deadlocks and they were hard to debug, so we wanted to avoid that in the future. Gscan acts like a kind of spinlock on ownership of the G, but indeed, it does not increment gp.m.locks. Perhaps it should.

I haven't yet been able to come up with a way that this could cause an actual deadlock, but I agree that having gscan increment gp.m.locks seems like it would fix this problem if there is one.

Oof. I think we narrowly miss a real deadlock issue here and it turns out to just be a limitation of our lock modeling.
Here's an almost problematic ordering:
(1) G1 is running on T1 and calls into blockevent, say for a mutex. It eventually calls stkbucket, acquires profInsertLock, and realizes G1 is out of stack space. G1 goes to acquire its own Gscan bit.
(2) Meanwhile the GC is enabled and T2 acquires G1's scan bit for scanning its stack. It then acquires and releases a lock, calling unlock, leading to trying to acquire profInsertLock.
(2) can't actually happen but the reasons are very subtle. There are only three cases where the GC tries to acquire a goroutines Gscan bit.
One is after asynchronously preempting, but asynchronous preemption will back out early if any locks are held by the target goroutine, so that can't happen.
Another case is where the Gscan bit is acquired and it's on a running goroutine in anticipation of a preemption, here: https://cs.opensource.google/go/go/+/master:src/runtime/preempt.go;l=199?q=preempt.go&ss=go%2Fgo. Luckily nothing happens that could cause a lock to be acquired between the acquire and release of the Gscan bit.
Finally, the Gscan bit can be acquired for a blocked goroutine, but if that was the case for G1 above, then (1) couldn't have been happening, since the goroutine needs to be running to acquire it's own scan bit.
One other possibility is that two GC threads compete for the same Gscan bit. One acquires and releases a lock while that bit is held, causing profInsertLock to be acquired. The other somehow starts trying to scan a goroutine while profInsertLock is held. The latter can't happen because nothing happens while profInsertLock is held that could cause a goroutine to get scanned (i.e. no memory allocations leading to a GC assist).
Modeling this properly in the lock ranking is going to be a pain. And I'm not a fan of incrementing gp.m.locks when acquiring the Gscan bit right now just because it could conceivably cause some "holding locks" failure. It's risky at this point in the release.
OK, that's all the bad-ish news. Our saving grace for the release is that this can only happen with GODEBUG=runtimecontentionstacks=1, so it's not a true release blocker. Note that all three failures happen during TestRuntimeLockMetricsAndProfile which enables the GODEBUG explicitly. This test was disabled by https://go.dev/cl/550775, so we're fine for now.
Moving out of release-blocker and into Go 1.23.

Like #64253, I think this can be worked on as a test-only fix for Go 1.22 still. The lock ranking mode is entirely for our own testing, and this issue only pops up with TestRuntimeLockMetricsAndProfile currently.
But there's no reason this has to block the Go 1.22 release at all, hence why I moved it to Go 1.23.

I'm also seeing a similar problem in TestDeltaProfile, between gscan and profBlock:
https://ci.chromium.org/ui/p/golang/builders/try/gotip-linux-amd64-staticlockranking/b8757359611155253553/test-results?q=ExactID%3Anet%2Fhttp%2Fpprof.TestDeltaProfile+VHash%3A3abbce2caef9f684&sortby=&groupby=

#66004 looks similar. @mknyszek , is this an acceptable point in the release cycle to have Gscan users modify gp.m.locks?

Yes, I think so


Interoperability of database with BIS

We will partner with @aulenbac to create a database which is interoperable with the Biogeographic Information Systems, used to generate interactive visualization maps such as National Biogeographic Map.

We will partner with @aulenbac to create a database which is interoperable with the Biogeographic Information Systems, used to generate interactive visualization maps such as National Biogeographic Map.

The real process here will be modeling the data, information, and knowledge required by the USAvian use case into the always evolving BIS. Much of what you've sketched out will find its way into the Spatial Feature Registry part of the work. This is a bit of a hash at the moment in our infrastructure, but we should use your use case here as a way to clean up and move that forward.
We have some but not all of the geopolitical boundaries that you will want to use tied into the system that is building a somewhat dynamic index for use via API, but we should be able to get other sources added readily enough. Some of your conservation units are represented in PAD-US, but we should tie in with current work we are doing on a new process to dynamically pull original sources together into multiple forms beyond PAD-US. We'd definitely be interested in cataloging sources for cooperative units beyond the few we've dealt with so far and bringing those together as well.
The USAvian entity can then reference those assets via API by class of feature or more detailed query parameters as needed. That process will also give you persistent, resolvable identifiers that can be used in the knowledge graph to connect related information.
We should also talk about identification of bird species with the Taxa Information Registry concept we've been pursuing in different use cases (SGCN, FWS National Listing Workplan, WLCI Species, etc.) but not yet instantiated in a cohesive manner.


don't work urlhum help me

hi...
I have a web site urlhum  uploaded but don't work please help me ?
mail adress<EMAIL_ADDRESS>web site :indirya.net

Hello,
could you better explain the problems you're encountering so we can help you?

urlhum script don't working  web site run now  loking you   indirya.net

You need to point the root directory in your webserver config file (Virtualhost) to the /public directory.
Also, I recommend to disable Apache file indexing to avoid exposure of server files.

Your Anchor Text


Changing orientation in paged mode

Pages are misaligned after changing orientation.

How exactly are they misaligned? Can you provide screenshots?

Start example, choose paging strategy layout, swipe to page other than 1st or last, rotate device, gridview will display space be somewhere in a middle of two pages, and not automatically scroll to beginning of page.

Yup I'm able to reproduce it. Will be fixed soon.

I think I'm experiencing the same issue (see screenshot). Any updates on this issue? Thanks!

Next in my list !
Out of curiosity, what's this app? Already in the appStore?

Awesome, thanks! Let me know if there's anything I can do to help (although I'm quite a newb with iOS).
(The app isn't released yet, but I'll definitely tell you more about it once it is!)

@gmoledina how'd you go with this error? I'm seeing it while using the development branch on an iPhone app.

I fixed the issue for myself by implementing

(void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView {
CGFloat pageWidth = _scrollView.frame.size.width;
currentPage = floor((_scrollView.contentOffset.x - pageWidth / 2) / pageWidth) + 1;
}

in GMGridview
and doing
CGRect frame = _scrollView.frame;
frame.origin.x = frame.size.width * currentPage;
frame.origin.y = 0;
[_scrollView scrollRectToVisible:frame animated:NO];
at the end of - (void)relayoutItemsAnimated:(BOOL)animated in GMGridview
more of a bandaid-fix but it works.

I'll give you an easier answer:

- (void)willRotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration
{
    [[self imageScrollView] willRotateToInterfaceOrientation:toInterfaceOrientation duration:duration];
    [super willRotateToInterfaceOrientation:toInterfaceOrientation duration:duration];
}

- (void)willAnimateRotationToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration
{
    [[self imageScrollView] willAnimateRotationToInterfaceOrientation:toInterfaceOrientation duration:duration];
    [super willAnimateRotationToInterfaceOrientation:toInterfaceOrientation duration:duration];
}

Add that to your view controller (where [self imageScrollView] is your GMGridView instance.

@tonyarnold I'm a bit confused, how does that work? GMGridView doesn't seem to implement those selectors.

@kylefox asked myself the same question. All I can say is that my bandaid-fix works, but it would be better to only reupdate after a rotation and onlly when in horizontal-paging-mode for performance reasons. Maybe I will handle this, but at the moment it just works as it is for me.

@LauterAlsDerRest Interesting, I couldn't get your fix working either. Neither _scrollView nor currentPage existed. Are you using the master or develop brach?

@kylefox you have to add and track the currentPage as a properry for yourself, sorry for not being clear. _scrollView is/was a property for the underlying scrollview in the master-branch.

@kylefox I'm working with the development branch. Perhaps these delegate methods have not made it into master yet.

@LauterAlsDerRest Great, thanks for clarifying.
@tonyarnold Weird, I'm using the development branch as well. Aren't those methods located on UIViewController, rather than UIScrollView (from which GMGridView inherits)? When I try this with the latest code from the develop branch Xcode tells me:
No visible @interface for 'GMGridView' declares the selector 'willRotateToInterfaceOrientation:duration:'

Completely my bad — you're correct. I was thinking about some other code, and somehow got it mixed up with GMGridView.  I hoped I was just overlooking something ;)
@gmoledina Any updates / suggestions for how to tackle this issue? I've been hacking on the GMGridView but cannot seem to find the source of this bug. Probably because of my newness to iOS :)
Any clues would be greatly appreciated, I really want to squash this issue!

For anyone else experiencing this issue, here's how you can patch it in your UIViewController:
-(void)willRotateToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration {
    CGPoint offset = CGPointMake(_currentPage * self.view.frame.size.height, 0);
    [UIView
     animateWithDuration:duration
     animations:^{
         self.gridView.contentOffset = offset;
     }
     completion:nil];
}

- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView {
    CGFloat pageWidth = scrollView.frame.size.width;
    _currentPage = floor((scrollView.contentOffset.x - pageWidth / 2) / pageWidth) + 1;
}


how to set "PUT" with ttl and how to watch a directory

hi
after upgrade to cli V3, how to set "PUT" with ttl and how to watch a directory ?
thx

@oikomi You need to attach lease to your key https://github.com/coreos/etcd/tree/master/etcdctl#lease-subcommand
And there's no key-hierarchy in v3. You can watch by prefix though.
https://github.com/coreos/etcd/tree/master/etcdctl#watch-options-key-or-prefix-range_end

@oikomi This doc might be helpful too: https://github.com/coreos/etcd/blob/master/Documentation/op-guide/v2-migration.md#migrate-client-library

thx , resolved.


Make plots demonstrating database holdings

puts scripts in /scripts/examples
put generated figures in documentation/figures/

Add version number filename and to caption of figures.

Could eventually turn into github action to autoupdate after releases.  Figures could also be added to the website.

I see that there are some figures in the documentation folder but I'm not sure where the script is which generated them.
I would also love for this script to be run and figures autogenerated by a github action everytime we do a release.

I added the "help wanted"  tag because doing the Github action thing could be fun for someone in the future.

Scripts should already be under /scripts/examples/plotting_example.py but may need some revision.


Automated Package Upgrade

:tada: This PR is included in version 26.0.35 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Not works after crossing dimensions

Playing on Minecraft 1.20.1 ， Forge 47.3.5
After switching between the Overworld and the Nether, the mod's functionality no longer works, even though config says it's on. until I re-enter the save

I think issue #7 is the same reason, it's a completely reproducible issue

I think issue #7 is the same reason, it's a completely reproducible issue

Issue #7 sounds more like it refers to gaining oversaturation while already oversaturated. If that is the case it's working as intended, and that is configurable to be allowed but defaults to not (personal tastes but the config exists for those who prefer otherwise.) As for the crossing dimensions, I think with the way the game handles dimension teleports it is stripping the capability off (or more accurately not transfering it to the new playerentity created. That is something I can fix in code and is an oversight as I wasn't aware it handled things that way (not counting coming back from the End which is techincally treated as a special case death and respawn). Either way I will see if I can fix it, and I am working on a better way to handle the saturation limits that may end up working better.

It sounds like this is going to be a problem that will be fixed right away, and I'm anxiously waiting for you to fix this and look forward to seeing your new release!:)


GUVNOR-2338: Copy/Rename modal doesn't disappear when used from Project Explorer links

Depends on: https://github.com/uberfire/uberfire-extensions/pull/174

jenkins retest this

Other than the change to use the Presenter's hide() method I think this is much clearer to follow than the flag you had before. Thanks for making the changes... once you switch to using the Presenter I'll OK the merge.

+1 to merge.

There are currently two compilation errors in DesignerPresenter:
[ERROR] /home/jeremy/Documents/gitRepositories/droolsjbpm/jbpm-designer/jbpm-designer-client/src/main/java/org/jbpm/designer/client/DesignerPresenter.java:[251,61] error: getDefaultView() has private access in CopyPopup
[ERROR] /home/jeremy/Documents/gitRepositories/droolsjbpm/jbpm-designer/jbpm-designer-client/src/main/java/org/jbpm/designer/client/DesignerPresenter.java:[360,67] error: getDefaultView() has private access in RenamePopup

Hi @jlindop , it's because this PR depends on https://github.com/uberfire/uberfire-extensions/pull/174

@paulovmr ah yes, my mistake. Apologies!

@jlindop No problem. :)

master: 42f15f2ba4b604b0f098303cfe8731066f5eaf04


Rill E2E setup

rill devtool start e2e

This looks incorrect. I'd expect it to pull cloud-e2e.env.

Fixed
I ran rill devtool start e2e and I see that it's connected to the same Postgres database as rill devtool start cloud. I'd like rill devtool start e2e to always start with a fresh Postgres database (and for my rill devtool start cloud Postgres database to remain untouched). Can we do that? (This comment may be resolved if this behavior is due to point 1.)
Created an ephemeral postgres for e2e only, will get cleaned up everytime we restart.
Also, it'd be nice to have the option to run rill devtool seed e2e to seed the e2e database in the same way as rill devtool seed cloud.
not able to make it work for cloud too :(

Created an ephemeral postgres for e2e only, will get cleaned up everytime we restart.

Wondering – what specifically do you mean by this? Locally, on a subsequent run, I only was able to reset the db via rill devtool start e2e --reset. When I didn't pass --reset, my state was retained (which is fine; the semantics are clear).

Created an ephemeral postgres for e2e only, will get cleaned up every time we restart.

Wondering – what specifically do you mean by this? Locally, on a subsequent run, I only was able to reset the db via rill devtool start e2e --reset. When I didn't pass --reset, my state was retained (which is fine; the semantics are clear).

So essentially if u restart docker then the volume is gone :)
dev is persisted to disk under dev-cloud-state but not of e2e. So yeah we need to reset or restart the docker.
we can change the behavior i believe.


list: support long and verbose version listing of casks

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Add support for long listing of casks with brew list --cask -l, full Caskroom path listings with brew list --cask -v, and include cask versions when running brew list --versions.

Review period will end on 2022-03-29 at 00:00:00 UTC.

Review period ended.


sync-blobs should clear out unused blobs

If a blob exists in the blobs folder that is not referenced in blobs.yml it should be removed when sync-blobs is run.
If you don't do this, packages that pull in artifacts using globs can accidentally include files they should not have.

@jpalermo Got this: https://www.pivotaltracker.com/story/show/138579069

Closing - the linked story has been accepted and the behavior is present in recent CLI versions (>=2.0.1). If you're still seeing problems, feel free to open a new issue.


Concerns Regarding "Sequencing Saturation" in the "DNBelab C4 scRNA-seq v2" Workflow Reports

Our collaborator Recently sequenced the same library using both V2 and V3 versions of the chips. We have some questions regarding the interpretation of the pipline report results:
① Based on the Median UMIs and Median Genes index for each cell, we observed that the average number of UMIs per gene for the V2 chip is about 1, while for the V3 chip, it is close to 3. According to our understanding, the sequencing saturation for V3 should be higher than that for V2. However, the reportes show that the maximum Saturation values  for V2 reaches nearly 60%, while V3 is below 20%, indicating that the sequencing saturation for V3 is much lower than for V2. This contradicts our intuitive understanding. How should we explain this situation?
② We also observed a significant difference in the sequencing reads counts between the two chips. V2 produced 300M of mRNA reads, while V3 produced 900M. What factors are mainly associated with this difference in sequencing?

We would appreciate your expert explanation on these issues.

The V3 version of the reagent has significantly optimized the mRNA capture capability, especially enhancing the capture of long fragments and intron regions. Compared to the V2 version, V3 captures more mRNA and a higher proportion of introns （increased antisense ratio ）.
In short, V3 achieves more transcript capture by improving RT reaction efficiency and the binding ability to long fragments, whereas the V2 version is weaker in this aspect and more prone to saturation.
If your research does not specifically focus on low-expression genes or transcripts, the current number of UMIs and genes captured by the V3 version is sufficient to support conventional analysis without the need for additional sequencing. However, if you need to explore the recovery of low-expression genes more deeply, it is recommended to consider adding some additional data.

This result is from Nuclear sample.
The V3 version of the reagent has significantly optimized the mRNA capture capability, especially enhancing the capture of long fragments and intron regions. Compared to the V2 version, V3 captures more mRNA and a higher proportion of introns （increased antisense ratio ）.
In short, V3 achieves more transcript capture by improving RT reaction efficiency and the binding ability to long fragments, whereas the V2 version is weaker in this aspect and more prone to saturation.
If your research does not specifically focus on low-expression genes or transcripts, the current number of UMIs and genes captured by the V3 version is sufficient to support conventional analysis without the need for additional sequencing. However, if you need to explore the recovery of low-expression genes more deeply, it is recommended to consider adding some additional data.

Thank you so much for your response.


Spark/visitor optimized create hive table as select command visitor

Problem
Implementations of Command in org.apache.spark.sql.hive.execution
Closes: #369
Solution
Implement OptimizedCreateHiveTableAsSelectCommandVisitor

Note: All schema changes require discussion. Please link the issue for context.

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
Checklist

[X] You've signed-off your work
[X] Your pull request title follows our guidelines
[X] Your changes are accompanied by tests (if relevant)
[X] Your change contains a small diff and is self-contained
[X] You've updated any relevant documentation (if relevant)
[X] You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
[X] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)

squashing unsigned-off commits in another pull request


Publish a release

Please do a release - it helps ppl using GH package managers to properly install it without browsing the release page.
I know it's still in development
Thx !

Also needed for eget:
$ eget mrjosh/helm-ls
404 Not Found (URL: https://api.github.com/repos/mrjosh/helm-ls/releases/latest)

Hi.
Sorry for the late response, i've been busy lately and couldn't focus on this project
First ever release has been published
Hope this helps you to install helm-ls easily
https://github.com/mrjosh/helm-ls/releases/latest
Thank you

@mrjosh thanks !!


BUG: Search Bar

Is there an existing issue for this?

[x] I have searched the existing issues

What happened?
While hovering on to the search bar in the right side of nav bar  it was hovering above the logo and same issue with "Become a Seller"  which looks odd sir,
please assign me these work i will work on it.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hello sir i think if someone looking a website / app the user always  want that should be user friendly and as a developer we should make that much user friendly and our designing should me more perfect and attractive but in this issue  the search bar in the right side of nav bar it was hovering above the logo and same issue with "Become a Seller" which looks odd sir, so please assign this issue i want to work on this more proficient way.


Remove ndarray.ptp from fallback tests

numpy.ndarray.ptp was removed in NumPy 2.0.

/test mini

/test head


[2024 Symposium] Data Catalog

Items to be completed in support of Data Catalog in advance of the OHDSI Symposium

Demonstrate how to find, configure, and load PM2.5 data into the GIS backbone
Show catalog functionality for registering new data sources
Prepare documentation/demonstration of the process

TODO:

[ ] #351

@tibbben, @kzollove, @fils, @AEW0330, @martyalvarez -- We didn't meet this week. We are scheduled to meet Monday or Tuesday of next week at a time when Kyle is able to join. That being said, we tentatively (by way of osmosis) put together our learning objectives for review/discussion in our meeting next week

Doug has been looking at how to merge GDSC work with the OHDSI GIS schema

Are we situated to bring the OpenGeoPortal resources into our own Data Catalog? Would that work through the pipeline that Data Catalog team has been developing?

Kyle
Can you provide a link to these resources so I can look at this more carefully with Doug and Tim?
Thanks.
Sorry about today.
We did have a good meeting though,
Jay
On Sep 6, 2024, at 10:50 AM, Kyle Zollo @.***> wrote:
Are we situated to bring the OpenGeoPortal resources into our own Data Catalog? Would that work through the pipeline that Data Catalog team has been developing?
—
Reply to this email directly, view it on GitHub https://github.com/OHDSI/GIS/issues/346#issuecomment-2334231997, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAZGN7PDBSSDRMZPVVL7O7LZVG6LDAVCNFSM6AAAAABMYFDWXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGIZTCOJZG4.
You are receiving this because you were assigned.

@jaygee-on-github

Can you provide a link to these resources so I can look at this more carefully with Doug and Tim?

I can direct you to https://opengeoportal.io/ and https://geoblacklight.org/, but I believe @tibbben might be able to direct you to the more relevant links within those sites

We need to ensure that the data sources are represented identically in the GDSC data catalog and gaia-db @tibbben @kzollove

[ ] What fields need to be added to gaia-db
[ ] Which data_sources/variable_sources (subset of the SEDACS dataset) need to be added to gaia-db and GDSC?

Can we table this somehow and actually use the table in the code?GDSC could be a superset and there may be different namesSent from my iPhoneJay Greenfield202.271.3179On Sep 27, 2024, at 10:59 AM, Kyle Zollo @.***> wrote:
We need to ensure that the data sources are represented identically in the GDSC data catalog and gaia-db @tibbben @kzollove
What fields need to be added to gaia-db
Which data_sources/variable_sources (subset of the SEDACS dataset) need to be added to gaia-db and GDSC?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Python 3

Hi
Do you have a version of gazeNet that runs on python 3 instead of 2 or are you planning to make this update?
Laure

Hi,
no, I do not have plans upgrading this repo. It should probably be straight forward - updating print statements to print() function should mostly do it.


chore: Address misc one click binding feedback

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Add a TL;DR when description is extra long (helps content team)
Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

PR fixes following issue(s)
Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skipTests=true

/ok-to-test

/build-deploy-preview skipTests=true

/ok-to-test

/build-deploy-preview skipTests=true

LGTM!
Tested and verified for:

Order of queries - show select queries on top and order by last executed query
Converting from JS to dropdown should be possible for the following cases
{{Query.data}}
Improve query names to be generated using the data table or collection we use
undefined table data value should show an error on the property pane
Download option should be disabled when table is generated using one click binding
Remove the insert binding option from the dropdown

/ok-to-test

/ok-to-test


debianutils: 5.20 -> 5.21

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/debianutils/versions.
meta.description for debianutils is: Miscellaneous utilities specific to Debian
meta.homepage for debianutils is: https://packages.debian.org/sid/debianutils
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.21 with grep in /nix/store/bwihz0mwymw1f1zmbn90d0vlgnyabbnz-debianutils-5.21
found 5.21 in filename of file in /nix/store/bwihz0mwymw1f1zmbn90d0vlgnyabbnz-debianutils-5.21

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

debianutils
ntfy-sh

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bwihz0mwymw1f1zmbn90d0vlgnyabbnz-debianutils-5.21 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A debianutils https://github.com/r-ryantm/nixpkgs/archive/773ad53e66fdf630e0e779255fe2b7a188e97874.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/773ad53e66fdf630e0e779255fe2b7a188e97874#debianutils

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bwihz0mwymw1f1zmbn90d0vlgnyabbnz-debianutils-5.21
ls -la /nix/store/bwihz0mwymw1f1zmbn90d0vlgnyabbnz-debianutils-5.21/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 3 packages built:

debianutils
debianutils.man
ntfy-sh

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361293

aarch64-darwin

:white_check_mark: 3 packages built:

debianutils
debianutils.man
ntfy-sh


Trouble training ESRGAN with jpeg artifact images.

Hello! Thank you for posting your code on GitHub. I successfully recreated the first part of your method (training DSGAN). Specifically I trained for jpeg artifacts and generated a paired dataset for the SR network (ESRGAN-FS). The generated dataset looks convincing, DSGAN was able to generate jpeg artifacts that look real. Then I trained ESRGAN-FS with your given codes/options/jpeg/train_TDSR.yml config file (all settings unchanged and placed the RRDB_ESRGAN_x4.pth pretrained model in the appropriate folder).
However, I am getting very weird results on the validation set. The images look cartoonish and the details are missing. This is for the TDSR case (50000 iteration), where I am trying to get clean HR images from generated LR images from DSGAN with jpeg artifacts.

Now, the weird thing is that, I even checked the supervised training where LR images are real images with jpeg artifacts (not generated) and still get the same cartoonish ouput. So the problem is with ESRGAN-FS, not DSGAN generated dataset. In addition, I also train the original ESRGAN (from BasicSR repo), and the got the same problem.
Can you help me with this? Maybe the issue is with the training configs (learning rate, loss weights) in the options files?

Hi jfun9494.
The results look as expected. The TDSR task is quite difficult and the results are not perfect yet.

Thank you for the response! Yes I also found TDSR to be quite a challenging task. Also thanks for sharing the pretrained models.


Update request: bazel_7 7.0.2 → 7.1.0

Package name: bazel_7
Latest released version: 7.1.0

Current version on the unstable channel: 7.0.2
Current version on the stable/release channel: 7.0.0

[x] Checked the nixpkgs pull requests

Notify maintainers

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

According to readme file in the bazel directory maintainers team is @NixOS/bazel

Closed by https://github.com/NixOS/nixpkgs/pull/299358


let(:node) not working

Hi There,
In the documentation, it says that I can specify a node name with:
let(:node) { 'host.example.com' }
However, the tests are failing unless the hostname of the machine I'm testing on, is defined in the puppet manifests/nodes.pp (which is included in site.pp), with the following error:
"Could not find default node or by name with 'test-host.example.com,test-host.example, test-host on node test-host.example.com".
As soon as I add "test-host.example.com" as a node in my puppet's nodes.pp config, the tests pass, which makes me think rspec-puppet is ignoring the let(:node) definition in my spec. Ideas?

And it appears that I've been writing to the wrong file... Long day, not enough coffee... :/


add pause_for to lock a queue for a limited amount of time

I want to use this to throttle processing of the queue.
You think that will work?

Thanks a lot, yes, sounds like it should work.
Probe count shouldn't be affected by pause so it's ok.

Thanks a lot, yes, sounds like it should work.

It does a really nice job allowing to evenly distribute a batch of jobs over a few days, by adding Sidekiq::Queue[:queuename].pause_for_ms 7.days * 1000 / number_of_jobs at the top of the worker perform method.

Nice example, thanks!


Standardize to canonical company name

Using OpenCorporates API? (https://api.opencorporates.com/)

How would we use this API for this task? Is it to remove things like "Updated Notice" by finding the company name in a string, or would we use CorporateGroupings to find constituent companies, or something else?


0x prakhar g patch 2

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Thanks! 🎉

When will this branch get merged?

Thanks! 🎉

When will this branch get merged?

Once it gets approved by another maintainer, it will be merged into the main branch. 🙂

Thanks! 🎉

When will this branch get merged?

Once it gets approved by another maintainer, it will be merged into the main branch. 🙂

Okay Cool✌🏻


Apply cve-2021-20288 fix to Rook 1.5.11 and 1.0.4-14.2.21

how come you dont need configmap-rook-config-override.yaml for 1.5.11?

It's already there https://github.com/replicatedhq/kURL/pull/1808/files#diff-ec3404a67f3aad4493e8f1a2165ffb00de5bf50c2c383befb93919fa8f7bc6c1


Change wording in docs from "builder methods" to "fluent setters"

Actually these should be called "fluent setters" not "builder methods". Builder methods usually refer to a separate builder object that may have incomplete fields and need to be consumed to become the built object, e.g. https://docs.rs/typed-builder.

Originally posted by @SOF3 in https://github.com/ratatui-org/ratatui/issues/647#issuecomment-1827029219

As part of making sure we use consistent and accurate language in docs, use "setter methods" / "fluent setters" instead of "Builder methods" or "builders" to refer to the methods in Ratatui types that set values.

I  agree with it. The builder pattern in most cases be like: FooBuilder::new().name(String::from("Y")).build();.
According to the grep result, this fix is limited in doc string, I'd like to pick this issue up. @joshka
23 results - 9 files

src/buffer.rs:
  439:     /// Builds a minimal sequence of coordinates and Cells necessary to update the UI from

src/layout.rs:
  268:     /// Builder method to set the constraints of the layout.
  296:     /// Builder method to set the margin of the layout.
  316:     /// Builder method to set the horizontal margin of the layout.
  333:     /// Builder method to set the vertical margin of the layout.
  350:     /// Builder method to set the direction of the layout.
  373:     /// Builder method to set whether chunks should be of equal size.

src/lib.rs:
   26: //! library that provides a set of widgets and utilities to build complex rust TUIs. Ratatui was
  210: //! The [`Text`], [`Line`] and [`Span`] types are the building blocks of the library and are used in

src/title.rs:
   90:     /// Builder pattern method for setting the title content.
   99:     /// Builder pattern method for setting the title alignment.
  105:     /// Builder pattern method for setting the title position.

src/widgets.rs:
  3: //! All widgets are implemented using the builder pattern and are consumable objects. They are not

src/widgets/barchart.rs:
  853:     fn build_test_barchart<'a>() -> BarChart<'a> {
  872:         let chart: BarChart<'_> = build_test_barchart();
  892:         let chart: BarChart<'_> = build_test_barchart();
  911:         let chart: BarChart<'_> = build_test_barchart();

src/widgets/sparkline.rs:
  21: /// # Builder methods

tests/widgets_paragraph.rs:
  138:      intermediate buffers. This means that at each new frame you should build all widgets that are \

src/widgets/barchart.rs (a7bf4b3):
   971:     fn build_test_barchart<'a>() -> BarChart<'a> {
   990:         let chart: BarChart<'_> = build_test_barchart();
  1010:         let chart: BarChart<'_> = build_test_barchart();
  1029:         let chart: BarChart<'_> = build_test_barchart();

ref
https://www.wikiwand.com/en/Fluent_interface
https://rust-unofficial.github.io/patterns/patterns/creational/builder.html

Go for it :)


Fix links in README.md

There was another pull request from @micmarti85 updating the readme so merged that PR instead and closing this one. Thanks for the reviews.


Competitions home page

Story
As a user
I want a homepage where I can see all info about comps and teams
So that I can find and join a team and compete in games
Acceptance Criteria

[x] I can view the homepage when I am NOT part of a team as per figma 2
[x] There are CTAs to (details behind these to follow):

[x] Create a team
[x] Join a team
[x] Play as a lone wolf

[x] A grid is displayed showing the active games (these are to be reused directly from the work done by @MadalinaRaicu over here.
[x] A leaderboard is displayed showing the top 10 teams as sorted by total rewards earned (full logic for defining this table is on #5487)

Tasks

[ ] UX (if needed)
[ ] Design (if needed)
[ ] Team and stakeholder review
[ ] Specs reviewed and created or adjusted
[ ] Implementation
[ ] Testing (unit and/or e2e)
[ ] Code review
[ ] QA review

Sketch

Additional details / background info
Figma here: https://www.figma.com/file/SPSdqynG3Xk4RzBJ7NKpdi/Competitions-%26-Referrals?type=design&node-id=3166-5839&mode=design&t=lti5mow1FpKvrv78-0

Marking this as done since all ACs are covered and any additional work / snags has been covered in other tickets.


Non-partitioned topic with '-partition-[number]' suffix conflicts with partitioned topic

Is your feature request related to a problem? Please describe.
First, create a non-partitioned topic with the '-partition-[number]' suffix, such as  'topic-name-partition-0'.
And then, create a partitioned topic which name is 'topic-name' by cli.
The result is that the non-partitioned topic that was originally created will be overwritten.
The consumer that previously planned to consume the non-partitioned topic will also consume the message published by the producer of the partitioned topic.
Describe the solution you'd like
If the user created a partitioned topic  with the same name after creating a non-partitioned topic with a '-partition-[number]' suffix, throw exception and prohibit creation.
Describe alternatives you've considered
If we think that it is a consensus to not be able to create a topic like this
Only tell the user through the documentation not to use this way

If the user created a partitioned topic with the same name after creating a non-partitioned topic with a '-partition-[number]' suffix, throw exception and prohibit creation.

+1 Pulsar should prohibit the creation of a partitioned topic with the same name if there is already a non-partitioned topic already exists.


docs: refine tests(typo, grammar)

Rationale for this change
Fixed typos for clarity in the documentation.

What changes are included in this PR?
 some typo corrections refine grammars
Are these changes tested?
This is just docs text modify

Thanks for the PR!

:tada: This PR is included in version 1.78.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Add] Full Stack Javascript by the odin project

Site URL
https://www.theodinproject.com/paths/full-stack-javascript
Description of the above provided site
This site takes you through our entire JavaScript curriculum. You'll learn everything you need to know to create beautiful responsive websites from scratch using JavaScript and NodeJS.
Category
Languages
Sub Category
JavaScript
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[ ] I am a GSSoC'23 contributor

I would be happy to contribute and work on this issue. If it hasn't been assigned yet. I'm in GSSoC'23. Thank you! @rupali-codes

Ooh sorry @mhdamaan79! There's a pull request for this already. I highly recommend reviewing it. It's a great way to see how to contribute to LinksHub, practice your written communication and collaboration skills, and gain some green squares on GitHub! :) Here’s an article on how to review a PR

No worries at all. I'll review the existing pull request and learn from it. @CBID2


Delete an account from the service

As a developer
I need to implement an API to delete an account
So that the account can be removed from the system
Details and Assumptions

The API should receive the account ID to delete the specific customer account.
Deleted accounts cannot be recovered.

Acceptance Criteria
Given an account exists
When the API is called with the account ID
Then the account is deleted from the database

Estimated Story Points: 5


feat: improve cli log for the workflow command

This is great. Thanks so much for adding this!
I have a suggestion that could be a future PR. Instead of the quiet option, in the future we could add a verbose parameter. Some packages have a verbose option to vaguely indicate how much output to expect. Valid values could be like 0, 1, or 2.

0 -> quiet
1 - > minimal output. For workflows, I'm thinking it would print the job status and job id for each job, but suppress the output values
2 -> full output

The reason this is valuable is that sometimes the job output is a complex object that fills up the terminal. Depending on how people are using the workflows, it can make sense to have something in between printing full output and no output.

@krisbitney  I agree about verbosity level and I believe this shouldn't be limited to the workflow but applied to CLI as a whole and we need a holistic plan for implementing it. I think this should be done post origin.

@krisbitney I agree about verbosity level and I believe this shouldn't be limited to the workflow but applied to CLI as a whole and we need a holistic plan for implementing it. I think this should be done post origin.

That sounds like a great plan


As of @sveltejs/kit version 1.2.2, crypto doesn't seem to be included (?)

Describe the bug
Looks like prior to 1.2.2, crypto (the webcrypto global) was apparently polyfilled. Now it doesn't seem to be. Using adapter-cloudflare-workers if that makes a difference.
Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-zank98?file=README.md,src%2Froutes%2F%2Bpage.js,package.json&terminal=dev
Steps to repro:

Run npm run build with SK 1.0.0. Note it builds fine.
Run npm i -D @sveltejs/kit@latest
Run npm run build and observe that src/pages.js throws an error because crypto is undefined

Logs
No response
System Info
System:
    OS: macOS 13.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1.05 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.10.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.2.0 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 109.0.5414.87
    Safari: 16.2
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0 => 1.0.0
    @sveltejs/adapter-cloudflare-workers: ^1.0.0 => 1.0.0
    @sveltejs/kit: ^1.0.0 => 1.0.1
    svelte: ^3.54.0 => 3.55.0
    vite: ^4.0.0 => 4.0.4```

Severity
blocking an upgrade
Additional Information
Tried to debug this as best I could and it may be related to this PR: https://github.com/sveltejs/kit/pull/8338

You could confirm whether it's that PR by testing with 1.0.3 and 1.0.4 and reporting whether or not they work
I would also be curious if either typeof Deno === 'undefined' or typeof Bun === 'undefined' evaluate to true on Cloudflare

Good tip — tracked it down to a version 1.0.13 which was this PR: https://github.com/sveltejs/kit/pull/8429
Stackblitz is updated as well.

Problem is that should_polyfill is checked too late, it should happen in postbuild/index.js already since nodes are already loaded there. Let's wait for #8636 to land since that moves stuff around quite a bit, then fix this.

I brought this up in another issue, but it seems this is the most relevant issue.
I am seeing pretty much the same error described in here, except with the fetch object. Moving from 1.0.12 to 1.0.13 causes our builds to fail during the Prerendering step because fetch is not defined.
In our case, we actually want to disable prerendering entirely, so it's a little baffling why the prerendering is even happening.

The solution we're going with for now came from a Discord post, and some other issues related to prerendering:
We're using the building environment flag to just avoiding the code that was using fetch. Fortunately for us it was only in one place, so not too bad.
import {building} from "$app/environment";

...
if (building) return;
fetch(...);


Testing for documentation change in MS Learn

Minor change to see how can work on MS learn for documentation

@jaggyi - thanks for the PR, but Microsoft style is no periods in the metadata title.
#please-close
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Change checked out fork in RTScanner test

Closes #860 in a way according to the discussion in the aforementioned issue.
Still need to give travis-ci access to the repairnator organization, but after that there should be no faults.

I've activated travis-ci access, what's next?

I believe we just have to wait for travis-ci to complete a build and then restart this one.

thanks


Spring cloud dataflow local server to authenticate via azure ad

May be I am posting this issue in wrong place pardon me for that.
I am using spring-cloud-dataflow-server-local and spring-cloud-dataflow-ui, I want to integrate spring oauth2 with Azure Ad.
I am reffering this doc http://docs.spring.io/spring-cloud-dataflow/docs/current-SNAPSHOT/reference/html/configuration-security.html#customizing-authorization
& https://spring.io/guides/tutorials/spring-boot-oauth2/#_social_login_simple
best part is I am able to login with github and facebook as per the doc.
but when I am trying to integrate Azure AD I am keep on getting 401 error.
in application.yml file my configuration is
security:
  oauth2:
    client:
      client-id: XXXXXXXXXXXXXXXXXXX
      client-secret: XXXXXXXXXXXXXX
      access-token-uri: https://login.microsoftonline.com/<tenent>/oauth2/token
      user-authorization-uri: https://login.microsoftonline.com/<tenent>/oauth2/authorize
      tokenName: access_token
      authenticationScheme: header
      clientAuthenticationScheme: form
      scope:  openid,profile,User.Read, Mail.Send
    resource:
      user-info-uri: https://graph.microsoft.com/v1.0/me

Can any one help me to do needfull.
What are the relevant configurations to be done in spring security?

Hello,
I have the same issue. Did you manage to fix your issue @brijesh1100 ?
What I understand, in UserInfoTokenServices, line 112, in this call:
(Map)((OAuth2RestOperations)restTemplate).getForEntity(path, Map.class, new Object[0]).getBody();
In this call, the bearer code is put in the uri_param, like this :
https://graph.microsoft.com/v1.0/me?oauth_token={bearer_code}
Or if we read the Microsoft Azure AD specification, the bearer_code should be sent in the header:
Header: "Authorization: Bearer {bearer_code}"
But I don't find a solution to fix this call, by adding this header during the graph.microsoft.com call.
Does anyone have an idea?
Thanks in advance


update the attribute name for process ID

The attribute name for picked process id when attaching the debugger is pid, not processId.
https://github.com/vadimcn/codelldb/blob/master/MANUAL.md

Thanks!


#263 Added Delete Cached image option for Candidate, Organization and Voter

Restore original twitter/facebook image urls in respected tables
Delete cached images from aws
Delete cached image entries from WeVoteImage Table

👍


Allow off main thread tree traversal

I'm getting an abysmal frame rate with the new google dataset, https://developers.google.com/maps/documentation/tile/3d-tiles.
The killer is the tree traversal. Maybe because the dataset is not implicit and it has many .json files?

Doing the entire tileset update on a worker thread drastically improves performance. In my case I still process the models into Unity friendly mesh data in the worker thread on the native side but I do the resource creation after the tileset update on the main thread on the c# side.

I understand this is a big ask as it goes against the way cesium-native was designed but there is nothing stopping it from working, aside from some pesky asserts inside ReferenceCountedNonThreadSafe.h.
I bring this up to start a dialogue and to ask that we don't break the worker thread tree traversal ability with future updates.

@ZackOfAllTrades are you saying you have your own implementation of 3D Tiles in Unity, and you're not using Cesium for Unity?
I'm very surprised by your 155ms frame time. I see far better than that with the Google tileset in Cesium for Unity, and I have an absolute potato of a GPU.
As far as thread safety, cesium-native itself doesn't care what thread you run the updateView on. But it does require that you always run it on the same thread and that the "main thread" parts of resource prep happen on that same thread. If you're violating those rules, you're likely to run into race conditions and undefined behavior eventually, even if it appears to work most of the time.

I'm very surprised by your 155ms frame time. I see far better than that with the Google tileset in Cesium for Unity, and I have an absolute potato of a GPU.

Here's to potato GPUs! Cesium-native runs runs nicely on an integrated GPU (AMD Renoir) that's nothing special.

As far as thread safety, cesium-native itself doesn't care what thread you run the updateView on. But it does require that you always run it on the same thread and that the "main thread" parts of resource prep happen on that same thread. If you're violating those rules, you're likely to run into race conditions and undefined behavior eventually, even if it appears to work most of the time.

This is interesting. vsgCs could do all of the prep in a "worker" thread and in fact has to do extra work because the Tile object isn't passed to the worker thread functions. Even though the Cesium main thread does not need to be the graphics engine main thread, I'm not sure I can do much better as long as there is only one main thread, and updateViews is called from it.

Sorry I was not clear, the drop in frame rate was not because I was GPU bound, running through the tilesetUpdate was taking 16ms on a debug build in editor, I will close this out as I have not done enough research and comparisons to justify any action, but my main takeaway is you can do the tilesetUpdate on a worker thread, even if you do nothing in the prepareInMainThread the update still takes time to run through the tree and do its comparisons.
If you run the update and get the result asynchronously that result is good and no tile will be deleted until you run the update again. So at this time I can run through all the tile pointers in the result, create my resources and render them knowing that all tile pointers are safe.
So a sample async Update method would look something like.
private async void Update(){
           ViewState viewState = CalculateViewState();
            foreach (var tileset in tilesets)
            {
                if (tileset.IsUpdating || !tileset.IsActive)
                    continue;

                tileset.IsUpdating = true;
                TilesetUpdateResult updateResult = await tileset.UpdateTilesetAsync(viewState); // update on worker thread
                RenderTileset(tileset, updateResult); // use the result to create gameobjects on main thread
                tileset.IsUpdating = false;
            }
}


Cannot find module 'rxjs/interfaces'

Got an error on npm start
ERROR in node_modules/@ngxs/store/src/of-action.d.ts(1,34): error TS2307: Cannot find module 'rxjs/interfaces'.
seems like there is an issue with rxjs-compat
got these rxjs packages versions installed:
<EMAIL_ADDRESS><EMAIL_ADDRESS>ng -v:
Angular CLI: 1.7.3
Node: 8.9.1
OS: win32 x64
Angular: 6.0.0-rc.1
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

@angular/cdk: 6.0.0-rc.0
@angular/cli: 1.7.3
@angular/flex-layout: 5.0.0-beta.14
@angular/material-moment-adapter: 6.0.0-rc.0
@angular/material: 6.0.0-rc.0
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.4.8
@angular-devkit/schematics: 0.4.8
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.10.2
@schematics/angular: 0.4.8
@schematics/package-update: 0.3.2
typescript: 2.7.2
webpack: 3.11.0

This is fixed in latest code.
Previously I was monkey patching ngxs npm module


sCFO - 2021-2022

By approving this pull request merge, you approve Bhavyaa Chauhan for the position of Epoch Shadow Chief Financial Officer for the 2021-2022 school year, and Epoch Chief Financial Officer for the 2022-2023 school year.

I approve

I approve

I approve
On Sun, Nov 21, 2021 at 3:36 PM Dev Singh @.***> wrote:

@devksingh4 https://github.com/devksingh4 requested your review on: #10
https://github.com/epochml/bylaws/pull/10 sCFO - 2021-2022.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/epochml/bylaws/pull/10#event-5650534690, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AK7M36D7KCYZNVPSWX4BOVLUNFQ55ANCNFSM5IPTHECA
.


x/tools/cmd/vet: warn about unused non-exported functions

It's common to leave dead functions in larger packages as a result of refactoring over
time. go vet could issue warnings (some functions we may want to leave for debugging).

More generally, this could apply to all top-level consts, types, vars, and funcs - at
least to some extent.

Do we need this? If so, I could work on it in 1.9. Let me know.

IMHO, probably ok as an optional vet check, but as gri mentioned, it will
give false positive on debug functions, so we can't make it part of the
default checks.
Also note the check has to take test files and excluded files (via build
tags) into consideration too. Such a test would be nice, but I think it's
too complicated to get 100% right.

I think it's probably too hard to get the false positives rate low enough in the real world.
It might work as a lint check, which can be looser.
Closing.

I think that might be too much even for lint, but if anyone does want this check,
https://github.com/dominikh/go-unused already does it.


HAWQ-67. Wrong variable type for saving fgetc() return value

This is to fix a bug of processing return value of fgetc(). char variable may cut the return value, int is utilized now.

Looks good to me. +1

+1, looks good.


Rap 4243

rap-4243 is fixed by removing ' ?

Yep. There’s an apostrophe in that string. Java is fine with it, but Python isn’t.
I haven’t looked at RAP tickets for a bit so forgot I had not addressed this.
script://poms/workflows/positionRoll/start
— that’s how we roll.

On Sep 29, 2016, at 3:43 PM, Jonathan Major<EMAIL_ADDRESS>wrote:
rap-4243 is fixed by removing ' ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/RapturePlatform/Rapture/pull/332#issuecomment-250613400, or mute the thread https://github.com/notifications/unsubscribe-auth/AFlTbz7VYLV2BMvF1QGCYdB9pSpcdirlks5qvD8qgaJpZM4KKjqM.

Yeah i'm triaging some today.


[Languages] Implement remote objects using java RMI server interface

NOTE: All 1st-time contributors should know Topic approval and PR submission does NOT guarantee your Topic/Article will be published. Our team of Peer Reviewers and Content Moderators will review all PRs that come in to make sure they adhere to the standard of quality we expect from the EngEd community.
We expect all community memebers to go through provided examples, resources, and previously published material before submitting content. As a rule of thumb, please only submit articles (pull requests) that are complete, formatted correctly, and include a fully polished article (ready to be published and error free).
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue). Any PR that is submitted incomplete (meaning not ready to be published as is) will be closed. A PR being closed does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
NOTE: Any topic suggestion copied/taken/modified from YouTube may Lead to a permanent ban from the community.
Topic Suggestion
Implement remote objects using java RMI server package
Proposed title of article
Implement remote objects using java RMI server interface.
Proposed article introduction
Java is an Object oriented programming language that enables developing programs through classes and objects. We shall create a client server interface. This is a useful in communicating with remote objects by invoking methods responsible in using method call on the stub discussed in Remote Method Invocations runtime which can be executed in one or multiple separate threads.
Key takeaways
This tutorial will form a basis for the learner to:-
1 construct remote objects
2 Export a peer-to-peer remote object without extending remote object class itself.
3 Passing RMI call by replacing the object in the remote object's stub.
4. Understand cloneable interface property.
5. Use Load Handler interface to load and trigger events.
Article quality
How is your article unique? Tell us what makes your approach different from similar articles that have published on the same topic?
Is yours more in-depth? Does it cover additional topics? Do you provide handy tips or anecdotal advice?
References
Please list links to any published content/research that you intend to use to support/guide this article.
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Great topic 🚀 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid potential article closure, it should not overlap with existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved.

Just and FYI I will be closing this topic form just to help clear up the queue where possible - can be REOPENED at anytime when ready to link a PR. 👍


[TS migration] Migrate 'ReceiptUtils.js' lib to TypeScript

Details
Migration of 'ReceiptUtils.js' to Typescript.
Fixed Issues
$ https://github.com/Expensify/App/issues/24883
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps

Test request money flow, specifically receipt flow

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/46095609/50cd98de-17d0-4731-8512-f5eb783f120d

Mobile Web - Chrome
https://github.com/Expensify/App/assets/46095609/b8928b17-d985-40dc-9904-f6be7811947e

Mobile Web - Safari
https://github.com/Expensify/App/assets/46095609/8a3b9b04-9732-4c03-99c0-871f74b37002

Desktop
https://github.com/Expensify/App/assets/46095609/17b57c82-9716-42b0-abff-1c5a45904778

iOS
https://github.com/Expensify/App/assets/46095609/46961050-9184-4024-b562-d9c983d01f65

Android
https://github.com/Expensify/App/assets/46095609/62133324-c111-4cce-9548-efeba40966b1

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/25230417/9908fb13-8195-4618-9c1e-8d3ab2cce47f

Mobile Web - Chrome

Mobile Web - Safari
https://github.com/Expensify/App/assets/25230417/00dd5e43-a1aa-494d-ba31-91cac504e531

Desktop
https://github.com/Expensify/App/assets/25230417/4da2074a-0575-40e3-bf28-5cd10fe1f1a8

iOS
https://github.com/Expensify/App/assets/25230417/094d5ec0-5da1-412e-a6a6-43bfc47687dc

Android
https://github.com/Expensify/App/assets/25230417/27113d3d-c09c-4b21-88e6-59b990003499

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


added some change in database access

If you want to add some library compatibilities examples, you can do it here:
https://github.com/src-d/go-mysql-server/blob/master/SUPPORTED_CLIENTS.md
To be able to add as a supported client here, you must add an integration test. You have some examples here: https://github.com/src-d/go-mysql-server/tree/master/_integration


Device groups: device-groups get spec.

Description
This was missing from original PR
Fixes #
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run go fmt ./... to check that my code is properly formatted
[ ] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #629 (8ca6b9a) into main (0caeb9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage   31.76%   31.76%
=======================================
  Files          37       37
  Lines        3970     3970
=======================================
  Hits         1261     1261
  Misses       2530     2530
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0caeb9b...8ca6b9a. Read the comment docs.

LGTM


weird issue

Hello.
for some reason when clicking the top link on the right of servers to view bans, it doesn't do anything.
http://bans.tronopolis.net

How many servers have you added in total? Exactly 10?
Because I assume its a incrementation issue, the id 10 works fine:
http://bans.tronopolis.net/index.php?action=searchplayer&server=10&player=%25
(Started counting from 1 instead of 0)

@tyler2k15 bump

@frdmn Apologies for the very late response. I forgot I had this issue open until I began getting more issues from it.
We have 9 servers currently on the Web UI, after I removed three today because I thought it was causing issues with it being over 10.
http://bans.tronopolis.net/index.php
The issues I'm experiencing are the aforementioned, and now upon clicking on a name it doesn't do anything.
For example, most of the names I clicked as a test just refreshed the page.
Then I clicked on the first entry in the second row (Modsauce, Player ShockSand), and it gave me ShockSand's ban record for Hub, which is the second server in first row.
Is there any solution to this or would I be better off removing the entire web ui and reinstalling?
I can provide files I am using if needed.

@tyler2k15 Can you provide your settings.php file please? Obviously mask any connection details. This issue is odd, it looks like the ids aren't quite correct. E.g. on the homepage, it appears that Modsauce is server id 3, but on the player page, it's showing Modsauce as server id 6.

@frdmn @confuser https://gist.github.com/tyler2k15/52a999e65e710d4489bfd986117286e6

Not sure if this was noticed, but clicking the Past server bans in the list on the top right acts as the first two just refresh, then the 3rd one goes to bans for the 1st, then 4th goes to 2nd, and so on

@confuser I think the issue is that from when I removed servers using the Admin portion of the UI it didn't remove it from the config. I re-cloned and added the servers and it seems to be behaving correctly.
If you would like to, i have the old version available at http://nd4.tronopolis.one/bans-old

That's odd, removing a server should remove it from the serialized array within settings.php
@frdmn Looks like https://github.com/BanManagement/BanManager-WebUI/blob/master/ajax/deleteserver.php#L23 could perhaps be the cause

Trying to reproduce tomorrow!

@confuser It was becaus the RegEx apparently didn't finish to the end of the line, so it overwrite only half of the value inside $settings['servers'].
@tyler2k15 Can you check the latest changes from master branch and confirm the fix?

@frdmn @confuser That issue seems fixed, but I found a new bug....
When I was deleting servers (need to change the connection info), I accidentally hit the move arrow button while deleting them and now it shows as: http://prntscr.com/b80e18
http://prntscr.com/b80es6

After reviewing the settings.php it seems the remaining servers are the only ones in the file, but when I click on one of the items it doesn't allow me to do anyhing, just a page refresh
They are linked to server =1 and =2

I've been able to reproduce this.
For some reason, deleting a server leaves the index, but not the value. Example dump immediately after the unset. It's been quite awhile since I've used PHP, so I can't recall at the moment why this is the behaviour.
Array
(
    [0] => Array
        (
            [name] => Local
            [host] => <IP_ADDRESS>
            [database] => local_bans
            [username] => root
            [password] =>
            [playersTable] => bm_players
            [playerBansTable] => bm_player_bans
            [playerBanRecordsTable] => bm_player_ban_records
            [playerMutesTable] => bm_player_mutes
            [playerMuteRecordsTable] => bm_player_mute_records
            [playerKicksTable] => bm_player_kicks
            [playerWarningsTable] => bm_player_warnings
            [ipBansTable] => bm_ip_bans
            [ipBanRecordsTable] => bm_ip_ban_records
            [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
        )

    [1] => Array
        (
            [name] => Local 2
            [host] => <IP_ADDRESS>
            [database] => local_bans
            [username] => root
            [password] =>
            [playersTable] => bm_players
            [playerBansTable] => bm_player_bans
            [playerBanRecordsTable] => bm_player_ban_records
            [playerMutesTable] => bm_player_mutes
            [playerMuteRecordsTable] => bm_player_mute_records
            [playerKicksTable] => bm_player_kicks
            [playerWarningsTable] => bm_player_warnings
            [ipBansTable] => bm_ip_bans
            [ipBanRecordsTable] => bm_ip_ban_records
            [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
        )

    [3] =>
    [4] => Array
        (
            [name] => Local 5
            [host] => <IP_ADDRESS>
            [database] => local_bans
            [username] => root
            [password] =>
            [playersTable] => bm_players
            [playerBansTable] => bm_player_bans
            [playerBanRecordsTable] => bm_player_ban_records
            [playerMutesTable] => bm_player_mutes
            [playerMuteRecordsTable] => bm_player_mute_records
            [playerKicksTable] => bm_player_kicks
            [playerWarningsTable] => bm_player_warnings
            [ipBansTable] => bm_ip_bans
            [ipBanRecordsTable] => bm_ip_ban_records
            [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
        )

    [5] => Array
        (
            [name] => Local 6
            [host] => <IP_ADDRESS>
            [database] => local_bans
            [username] => root
            [password] =>
            [playersTable] => bm_players
            [playerBansTable] => bm_player_bans
            [playerBanRecordsTable] => bm_player_ban_records
            [playerMutesTable] => bm_player_mutes
            [playerMuteRecordsTable] => bm_player_mute_records
            [playerKicksTable] => bm_player_kicks
            [playerWarningsTable] => bm_player_warnings
            [ipBansTable] => bm_ip_bans
            [ipBanRecordsTable] => bm_ip_ban_records
            [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
        )
)

Moving/deleting a server has an impact on any links that have been shared. They'll either show the results for a different server, or they'll show a player not found error.
Perhaps generating a UUID or a unique slug for each server would work better in the above cases.
I'm not sure if it'll be worth refactoring that part at this point in time, it depends on when I get round to starting #27. Perhaps in a couple of weeks.

Thanks for the research James. I'll fix this soon! :)
Von meinem iPhone gesendet

Am 25.05.2016 um 11:59 schrieb James Mortemore<EMAIL_ADDRESS>I've been able to reproduce this.
For some reason, deleting a server leaves the index, but not the value. Example dump immediately after the unset. It's been quite awhile since I've used PHP, so I can't recall at the moment why this is the behaviour.
Array
(
[0] => Array
(
[name] => Local
[host] => <IP_ADDRESS>
[database] => local_bans
[username] => root
[password] =>
[playersTable] => bm_players
[playerBansTable] => bm_player_bans
[playerBanRecordsTable] => bm_player_ban_records
[playerMutesTable] => bm_player_mutes
[playerMuteRecordsTable] => bm_player_mute_records
[playerKicksTable] => bm_player_kicks
[playerWarningsTable] => bm_player_warnings
[ipBansTable] => bm_ip_bans
[ipBanRecordsTable] => bm_ip_ban_records
[consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
)
[1] => Array
    (
        [name] => Local 2
        [host] => <IP_ADDRESS>
        [database] => local_bans
        [username] => root
        [password] =>
        [playersTable] => bm_players
        [playerBansTable] => bm_player_bans
        [playerBanRecordsTable] => bm_player_ban_records
        [playerMutesTable] => bm_player_mutes
        [playerMuteRecordsTable] => bm_player_mute_records
        [playerKicksTable] => bm_player_kicks
        [playerWarningsTable] => bm_player_warnings
        [ipBansTable] => bm_ip_bans
        [ipBanRecordsTable] => bm_ip_ban_records
        [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
    )

[3] =>
[4] => Array
    (
        [name] => Local 5
        [host] => <IP_ADDRESS>
        [database] => local_bans
        [username] => root
        [password] =>
        [playersTable] => bm_players
        [playerBansTable] => bm_player_bans
        [playerBanRecordsTable] => bm_player_ban_records
        [playerMutesTable] => bm_player_mutes
        [playerMuteRecordsTable] => bm_player_mute_records
        [playerKicksTable] => bm_player_kicks
        [playerWarningsTable] => bm_player_warnings
        [ipBansTable] => bm_ip_bans
        [ipBanRecordsTable] => bm_ip_ban_records
        [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
    )

[5] => Array
    (
        [name] => Local 6
        [host] => <IP_ADDRESS>
        [database] => local_bans
        [username] => root
        [password] =>
        [playersTable] => bm_players
        [playerBansTable] => bm_player_bans
        [playerBanRecordsTable] => bm_player_ban_records
        [playerMutesTable] => bm_player_mutes
        [playerMuteRecordsTable] => bm_player_mute_records
        [playerKicksTable] => bm_player_kicks
        [playerWarningsTable] => bm_player_warnings
        [ipBansTable] => bm_ip_bans
        [ipBanRecordsTable] => bm_ip_ban_records
        [consoleId] => 6f54f9d4-518d-4dcb-aa6f-b504ad89d6ba
    )

)
Moving/deleting a server has an impact on any links that have been shared. They'll either show the results for a different server, or they'll show a player not found error.
Perhaps generating a UUID or a unique slug for each server would work better in the above cases.
I'm not sure if it'll be worth refactoring that part at this point in time, it depends on when I get round to starting #27. Perhaps in a couple of weeks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

As i see it the problem is that for some reason value 3 is missing  (which is removed)
we want it to be 0,1,2,3,4 instead of 0,1,2,4,5 - Correct?
If so then a fix would what i did in pull request #140

Resetting the index isn't ideal, as it'll invalidate any hyperlinks that have been shared. Ideally the indexes should remain as it is. The issue is that [3] remained as an element without a value, when it should have been removed in its entirety.

Yeah i saw that after reading through it again.
I don't have that issue on my PHP 7 machine - not sure why it would do it like that


Feature/setup actions

Setup GitHub Actions for CI & CI/CD

Pushes on all branches except main will trigger Run CI which runs:

npm ci
npm run lint
npm run type-check
npm run package (builds the project)

Tag pushes starting with v (e.g., 0.0.1-alpha.6) will trigger Run CI/CD which runs:

npm ci
npm run lint
npm run type-check
npm run publish (publishes distributable packages / installers to GitHub Release)

Actions run on a matrix, consisting of the following images (both CI and CI/CD)

macOS-latest
windows-latest
ubuntu-latest

The publish action will automatically create a release on GitHub (tag needs to be existing already)
Version of git tag and version in package.json should match!
Packages are created for all supported architectures by electron (x64, arm64, ia32, armv7l)
Cleaned up package.json-metadata a bit

Closes #7

looks good, it currently does not work on my mac to install and run the app -> #20. I will merge nontheless, so we have the checks enabled on the other branches.