Typing problem on indexing pandas DataFrame with a Callable

Environment data

Language Server version: 2022.12.20 (pyright 621d886b)
OS and version: Mac OS Ventrua 13.0.1 (22A400)
Python version (& distribution if applicable, e.g. Anaconda): 3.9.15 | packaged by conda-forge | (main, Nov 22 2022, 08:55:37)

Code Snippet

import pandas as pd # version 1.5.2

df = pd.DataFrame(dict(var=[1, 2, 3, 4]))
new_df = df[lambda x: x["var"] > 2]

Expected behavior
No typing problems found. It is a usual way to filter elements of DataFrame using a Callable that returns pd.Series.
Actual behavior
The expression df[lambda x: x["var"] > 2] gives the following problem:
Argument of type "(x: Unknown) -> Unknown" cannot be assigned to parameter "idx" of type "tuple[Unknown, ...] | Series[bool] | DataFrame | list[_str] | list[ScalarT@__getitem__] | Index | np_ndarray_str | np_ndarray_bool | Sequence[tuple[Scalar, ...]]" in function "__getitem__"
  Type "(x: Unknown) -> Unknown" cannot be assigned to type "tuple[Unknown, ...] | Series[bool] | DataFrame | list[_str] | list[ScalarT@__getitem__] | Index | np_ndarray_str | np_ndarray_bool | Sequence[tuple[Scalar, ...]]"
    "object" is incompatible with "tuple[Unknown, ...]"
    "object" is incompatible with "Series[bool]"
    "object" is incompatible with "DataFrame"
    "object" is incompatible with "list[_str]"
    "object" is incompatible with "list[ScalarT@__getitem__]"
    "object" is incompatible with "Index"
    "object" is incompatible with "np_ndarray_str"Pylance[reportGeneralTypeIssues](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportGeneralTypeIssues)

This problem was mentioned in #252 (see comment), but does not seem to be solved there.

Okay, I found the answer here: the problem is that lambda is typechecked as (x: Unknown) -> Unknown, and it's too broad.

Yeah this works for me:
df2 = pd.DataFrame(dict(var=[1, 2, 3, 4]))

def varGt2(s: pd.DataFrame) -> pd.Series:
    return s["var"] > 2

new_df = df2[varGt2(df2)]

@rchiodo Your example does not actually "fixes" my problem, as I pass Callable into [], and in your example, it is pd.Series (as you already applied function to a dataframe). Nevertheless, I see that it does not seem to be pylance bug anyway: it's partially not a bug (it should fail, as Unknown -> Unknown is too broad) and partally upstream bug in pandas-stubs I referenced (it's still open as type-checking fails even on correctly specified Callables).
At the same time, it is quite unfortunate that syntax like df[lambda x: x['var'] > 2] cannot be correct from the typechecker's perspective unless we allow Unknown -> Unknown callables there, as there is no way to specify the signature of lambda function. I use this syntax as a default way to filter pandas DataFrames in the method chaining pattern, and there's basically no alternatives exists in pandas except of .query which I personally do not like at all. It seems that I need to add # type: ignore to any line where this syntax is used, and that's the only solution we have.


Leave the Gemfile unedited if possible

I like to think of the Gemfile version specifications as informative of the expected version support. For example, if my nokogiri dependency is ~> 1.2, that means that I expect my application to work against any 1.x version higher or equal to 1.2. For example, because I needed a feature released with nokogiri 1.2 when I introduced the dependency.
When dependabot updates nokogiri to, say,  1.3.0, I would actually prefer the Gemfile to be left alone (unless changing it is needed to update the dependency), because it's not necessary, and because it obscures the reason why the version specifier was introduced.
Is this something you would be willing to change or to introduce as an option?
As always, thanks for dependabot!

Since this is already configurable for other languages I've made it configurable for Ruby, too. If you got to the dashboard and click to edit any of your Ruby update configs you should be able to adjust the Gemfile update strategy to Only increase version if necessary.
Thanks for the feedback, as always!


Fix computed global scoping behavior

Computed globals should not participate in path factoring, since
(global Foo).x looks much more like (select Foo).x or
(detached Foo).x than Foo.x.
Additionally, fix links off of computed globals not being deduplicated.
Fixes #4388.

Do we have reasonable documentation or explanation of our longest path factoring anywhere? I only know of https://www.edgedb.com/docs/reference/edgeql/eval, which specifies it but kind of assumes the reader has some idea what is going on already.

I think we should have a reasonable simple explanation of factoring and scopes somewhere high enough. @colinhacks do you have ideas on how we can better present scoping?   Maybe even with a picture?


feat: start dotnet feature extraction

closes #951
closes #950
closes #947
closes #946
closes #945
closes #957

[x]  No CHANGELOG update needed

pending tests passing this is ready for review and merge.

updated with PR feedback; pending tests passing ready for final review, squash, and merge into dotnet-main.

yes, let's add tests and then send it!

tests added; reopening for review 🚀


"this" has been rewritten to "undefined" warning during the Rollup build (ESM)

Hi,
We encountered an issue where tss-react gives me a warning during the ESM build with Rollup.
Here is the detail of the warning:
(!) "this" has been rewritten to "undefined"
https://rollupjs.org/troubleshooting/#error-this-is-undefined
node_modules/tss-react/esm/tss.js
1: /* eslint-disable @typescript-eslint/ban-types */
2: var __rest = (this && this.__rest) || function (s, e) {
^
3:     var t = {};
4:     for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
...and 1 other occurrence
node_modules/tss-react/esm/withStyles.js
1: var __rest = (this && this.__rest) || function (s, e) {
^
2:     var t = {};
3:     for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
The link below serves as a reference for this error:
https://rollupjs.org/troubleshooting/#error-this-is-undefined

Also below with the same issue:
node_modules/tss-react/esm/withStyles.js
1: var __rest = (this && this.__rest) || function (s, e) {
^
2:     var t = {};
3:     for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)

Hello, thanks for reporting. Do you experience any bug besides this warning?

Hello, thanks for reporting. Do you experience any bug besides this warning?

Not sure mate, we haven't tried, but this is the only warning we had during the build

Well, this warning sucks because this is perfectly valid code. Anyway I changed the compilation target for the ESM distribution in<EMAIL_ADDRESS>Thanks for reporting

Thanks for your quick fix mate


Swashbuckle does not see route parameters in Wolverine HTTP method attributes

When using route parameters in my Wolverine HTTP method attributes, Swashbuckle cannot see them.
Example:
public static class GetUserProfileEndpoint
{
    [Authorize]
    [WolverineGet($"{Routes.Users}/{{userId}}")]
    public static async Task<UserProfile?> GetUserProfile(Guid userId, IQuerySession session)
    {
        // query logic omitted for brevity
        return userProfile;
    }
}

Although Swashbuckle can see the endpoint itself, the userId parameter is not listed.

If I hit the endpoint with a userId value, Wolverine does successfully pick it up. Additionally, the [FromRoute] attribute allows Swashbuckle to correctly identify the parameter, as does moving the endpoint into a minimal API.

If you specify [FromRoute] on the userId it does work, although you don't need it for Wolverine to work.

Related !446

Folks, this worked OOTB with the current Wolverine main folder today. Not really sure what's changed.

I'm still adding a second layer of IFromRouteMetadata though


Rename the attribute_extractor to meta_extractor

:notebook_with_decorative_cover: Description
Does what the title says and removes the support for the deprecated #timestamp attribute form entirely.
Should not be merged before the February release!
:memo: Checklist

[x] All user-facing changes have changelog entries.
[x] The changes are reflected on docs.tenzir.com/vast, if necessary.
[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions
By commit.

Before merging, please add a changelog entry.

[ch21495]


Copy / move&link README install and build to docs

We now have nice install and build docs in README  - should this be copied or probably best moved to the docs and we provide links in README - so that all docs are in one place and README is just a quick intro and pointers to key resources.

While we will have all the GitHub actions for PyPI and RtD it is good to have full local install instructions too for developers and testers;) I used something like this just now for AlphaImpute2 (let's do all these bits for AlphaPeel and then we repeat for other tools).
git clone --recurse-submodules https://github.com/AlphaGenes/AlphaImpute2.git
mv AlphaImpute2 AlphaImpute2_upstream_test
cd AlphaImpute2_upstream_test
git pull
git checkout devel
git pull
python3 -m venv AlphaImpute2_env
source AlphaImpute2_env/bin/activate
python3 -m pip install --upgrade pip
python3 -m pip install --upgrade build
python3 -m build
python3 -m pip install dist/AlphaImpute2-0.0.3-py3-none-any.whl
cd example
chmod a+x run_script.sh
./run_script.sh
deactivate AlphaImpute2_env

@gregorgorjanc The AlphaPeel version would be something like the following
git clone --recurse-submodules https://github.com/AlphaGenes/AlphaPeel.git
cd AlphaPeel
python3 -m venv AlphaPeel_env
source AlphaPeel_env/bin/activate
python3 -m pip install --upgrade pip
python3 -m pip install --upgrade build
python3 -m build
python3 -m pip install dist/AlphaPeel*.whl
cd example
bash runScript.sh
deactivate AlphaPeel_env

But it is basically the build instructions in the README. Do we need to keep the build instructions and write a new one, or modify the build instructions to be the local install instructions?

I suggest we add build instructions to dev section of the docs and link to it from the README. This way we have all this dev stuff in one place.

@gregorgorjanc I mean do we need to separate build instructions and the local install instructions you mentioned above or do we need to put them together and only write once in the documentation as they are quite similar?


VPC endpoint service complications with availability zone restrictions

I ran into a problem attempting to provision an SES endpoint: the default is to use all private subnets but some are for unspecified reasons unsupported — in my case us-east-1a,e,f are listed as “Service not supported in this Availability Zone” in the console and so an apply fails:
Error: Error creating VPC Endpoint: InvalidParameter: The VPC endpoint service com.amazonaws.us-east-1.email-smtp does not support the availability zone of the subnet: subnet-0de46d7dcc06da2a7.

For anyone else who, like me, needed to be reminded that Terraform's dependency graph crosses module boundaries, the fix is relatively easy. It might be easiest to start with a documentation update for this situation since it would be a bit of work to update the endpoint service code to do this automatically:
module "vpc" {
  source                 = "terraform-aws-modules/vpc/aws"
  version                = "~> 2.44"
…
  enable_ses_endpoint              = true
  ses_endpoint_private_dns_enabled = true
  ses_endpoint_security_group_ids  = [aws_security_group.vpc_endpoints.id]
  ses_endpoint_subnet_ids          = data.aws_subnet_ids.private_subnets.ids
}

# Not all VPC endpoint services are supported in all availability zones. This
# caused a problem when 1 of the 4 VPCs used for bard-development didn't support
# SES. Fortunately we can make a separate query for that service information and
# use the results to filter the subnet list.

data "aws_vpc_endpoint_service" "ses" {
  service = "email-smtp"
}

data "aws_subnet_ids" "private_subnets" {
  vpc_id = module.vpc.vpc_id

  filter {
    name   = "subnet-id"
    values = module.vpc.private_subnets
  }

  filter {
    name   = "availability-zone"
    values = data.aws_vpc_endpoint_service.ses.availability_zones
  }
}

Just to add that I banged my head against the desk for some time on this, until I realised that what looks like a circular dependency works. Can't post the real code, but something like this:
module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "~> v2.10.0"
...
  ssm_endpoint_subnet_ids = module.vpc.private_subnets
...
}

This is new in TF12, and somewhat hard to predict working. The example above is more complex, but if you follow it through, does much the same thing.

@coofercat, not sure that you solution address the issue at hand? if the subnets are created in AZ that dont support a give VPC endpoint it will still fail. you are just explicitly specifying subnets that are passed to the vpc endpoints as is.
@acdha can you open a PR to add some docs on the subject with the given example? i think its the best way to go around this issue.

+1


 Completely agree. Initially noted in https://github.com/jameshopkins/webapptest/pull/19#discussion_r86224281 and created the issue at https://github.com/jameshopkins/webapptest/issues/32

I've started using that in Atom. It works fine, but produces very... airy code - lots of new lines and empty lines :) I assume that's what the style guide says, but not sure I'm a fan...

yeah, it's very vertical. Still, after a little adjustment period you don't really notice it, and then you never have to think/argue about style ever again,
Every language should have a formatter.

A little bit of work required here, to mention the use of elm-format in our docs and the need to use it in your IDE, all of which can go under 'Dev setup' or similar

Would be nice to also enforce a check in CI that refuses code not matching the style

Yep, completely agree


Disable dynamic loading of images?

Wow, what an excellent extension! Thank you so much @thebaer ! I have a request but I'm not sure if it's possible.  When  I open a page, none of the images below the fold are actually loaded which means if I disconnect from the network (during a commute), I won't see any of the images below. Would it be possible to load all the images when the page loads? Thanks!

Yep, this was pretty straightforward to add! I tested it out on this post and it seems to work well.
You'll see it as an option to Disable lazy image loading in the next version, ideally going out tonight.

Thanks so much @thebaer !!!


Adjusting help message

On stable, running with --help|-h shows information about file-lines which is a nightly-only option (#4798). This commit removes all mention of file-lines from the help message on stable.
There is room for improvement here; perhaps a new struct called, e.g., StableOptions could be added to complement the existing GetOptsOptions struct. StableOptions could have a field for each field in GetOptsOptions, with each field's value being a bool that specifies whether or not the option exists on stable. Or is this adding too much complexity?

Can I get a bit of help with this? I'm not sure what's wrong with the failing checks. All of them (except the Windows ones) seem to have some error like the below when compiling
error[E0658]: unsizing casts to types besides slices are not allowed in const fn
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_ast-712.0.0/src/ptr.rs:136:37
    |
136 |                 std::mem::transmute(NonNull::<[T; 0]>::dangling() as NonNull<[T]>)
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #64992 <https://github.com/rust-lang/rust/issues/64992> for more information
    = help: add `#![feature(const_fn_unsize)]` to the crate attributes to enable

error: aborting due to previous error

What can I do about this?

What can I do about this?

So sorry @murchu27, this slipped past me in my notification inbox somehow. You should be able to rebase on the master branch of this repository to resolve (just be sure to reference the upstream or whatever remote name you used for this, since we've subsequently changed the master branch to contain the same 1.x version of the code you were working with, refs #4801)


Remove %s in formatting

previously %s was used to display variable for string formatting which won't work.

Looks like the integration tests have failed due to some reason with the api


Handle UpdateSurface edge case with compressed mip levels

Fixes #2150 .

We should rather check if it is aligned OR the mip size, otherwise return D3DERR_INVALIDCALL.

based on the test I added in tests/d3d9


adding a meta field under the plans model

Would it make sense to add a meta to the plans model?
meta = JSONField(blank=True, null=True)

There are cases where I would like to have some additional data on the plan itself. Thoughts?

Hi @macmichael01, I don't see a reason why not to have it.
Can you give an example of a case?


Set bt-dev-prod team as CODEOWNERS for all build scripts

Closes https://github.com/gradle/gradle-private/issues/3710

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge

I've triggered a build for you.


Update index.md

add API Gateway pattern and one .NET tools for it.

add API Gateway pattern and one .NET tools for it.


Revert "Release number as string (#103)"

These CRD changes are causing incompatibilities. We did this for tests, we are no longer using that approach. This is just a straight git revert on PR 103

/lgtm
/approve


Gui theme textures should have a name for Debugger -> Video Memory

Operating system or device - Godot version:
2.1.3
Not sure if this an issue but I'm pretty sure it is. I've seen this for about 2 years now but never really reported because.. I don't know lol
Anyway:

Is this intended, what exactly are the unnamed textures and where are they coming from? :O

Could you test on current master branch? Also are you able to provide some kind of minimal example project in which this issue can be observed? Thanks.

This is ok, it's probably the default GUI theme textures. We could name
them so you know what they are..
On Mon, Jul 17, 2017 at 7:51 PM, kubecz3k<EMAIL_ADDRESS>wrote:

Could you test on current master branch? Also are you able to provide some
kind of minimal example project in which this issue can be observed? Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9679#issuecomment-315907788,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z23WXNxlBtMcHCeXfTDDWptjIwolUks5sO-VxgaJpZM4OampR
.

yeah that's probably a good idea to avoid confusion

Bug triage note: The original issue reporter closed all their issues before deleting their account. If you are affected by a similar issue/want a similar feature, please file a new ticket (referencing this one if it contains useful information) so that it can be further looked at and eventually resolved.


Fix off-by-one error in Delay impl

This makes two changes:

Updates the MAX_RVR to a 24-bit (not 25-bit) number
Moves tracking variable update for better potential precision

This brings the stm32f3 delay impl up to date with the nrf52 delay impl.

@Sh3Rm4n, this change works a treat on top of my https://github.com/sirhcel/stm32f3xx-hal/commit/2a9b8f7e897b81bdaf9228550a01f8564709fda3. Isn't this something for the next release as well?

Thanks @jamesmunns! This for fixing this bug and keeping this HAL implementation up to date with the other implementations.
Only rustfmt is unhappy, so this PR is almost good to go. I can fix this myself, if you don't mind though :)


Websockets versions are incompatible

wsproto 0.11.0 has requirement h11~=0.7.0, but you'll have h11 0.8.0 which is incompatible.
discord-py 1.0.0a1467+g6b75179 has requirement websockets<4.0,>=3.0, but you'll have websockets 5.0.1 which is incompatible.

This results in the bot not playing anything.

What @AndyTempel said is correct. We run our own branch of d.py which is near-identical to the upstream and automatically syncs updates with backstroke, but we run the latest websockets from the master branch and also aiohttp. The websocket issue has not only been fixed, it's been really looked into over the last 30 days. There are at least 7-8 commits dedicated to this. It was just that the developer was busy and didn't get a chance to review PRs that had fixed the issue long before.

Thing is, I just reinstalled Discord.py today... And it still has that error (latest rewrite)

The error you provided can be ignored. It's more or less a warning but shouldn't affect the library's operation unless Danny hasn't patched it (which based on the replies I believe he has)

It seems like he hasn't, this there are no errors on either Lavalink, nor the bots logs. It says that it's playing (on the user side), but it's not playing...
Did that make sense?

What websockets version are you running?

The library isn't patched - you have to upgrade manually.

Let me test that, I'll get back to you.
What you said made it seem like that it was automatic, sorry for the confusion!

Oh sorry, I didn't mean it that way. I meant that we have a fork of the library on GitHub which I pull everything from instead of the main rewrite branch of discord.py - so yeah, in our case it is automatic as our websockets and aiohttp are defined to use latest versions, but you'd have to upgrade manually.

Nope, when running python -m pip install websockets --upgrade after pulling a fresh copy of rewrite:
discord-py 1.0.0a1467+g6b75179 has requirement websockets<4.0,>=3.0, but you'll have websockets 5.0.1
which is incompatible.```

Your bot may be trying to check requirements and pulling discord.py again after you upgrade on startup so it errors.
Try:
python3 -m pip install --upgrade --force-reinstall websockets

Guessing now this is a good error, since it updated?
wsproto 0.11.0 has requirement h11~=0.7.0, but you'll have h11 0.8.0 which is incompatible. discord-py 1.0.0a1467+g6b75179 has requirement websockets<4.0,>=3.0, but you'll have websockets 5.0.1  which is incompatible.

(at least I think it did)

You should see something like that in the logs:
2018-06-07 14:30:37,946 DEBUG client > Frame(fin=True, opcode=10, data=b'', rsv1=False, rsv2=False, rsv3=False)
2018-06-07 14:30:38,144 DEBUG client < Frame(fin=True, opcode=1, data=b'{"op":"playerUpdate","state":{"position":33540,"time":1528374638194},"guildId":"404731402429530132"}', rsv1=False, rsv2=False, rsv3=False)

@AndyTempel I do, but alas, no sound still.

(note: this only happened after moving to a VPs, yes, I edited state.py)

Then this is not the clients issue. Also check what volume do you have set in lavalink and discord. But if you see that lavalink and the client are conversing then this is not the clients issue.

state.py doesn't need editing on V2+

I guess you already tried disconnecting and restarting everything.

Is Lavalink supposed to log anything else?
2|pika.py- | [12:21:33] [ INFO ] [SimpleUrlHandlerMapping] Mapped URL path [/webjars/**] onto handler  of type [class org.springframework.web.servlet.resource.ResourceHttpRequestHandler]                    2|pika.py- | [12:21:33] [ INFO ] [SimpleUrlHandlerMapping] Mapped URL path [/**] onto handler of type  [class org.springframework.web.servlet.resource.ResourceHttpRequestHandler]                            2|pika.py- | [12:21:33] [ INFO ] [SimpleUrlHandlerMapping] Mapped URL path [/**/favicon.ico] onto hand ler of type [class org.springframework.web.servlet.resource.ResourceHttpRequestHandler]                2|pika.py- | [12:21:34] [ INFO ] [AnnotationMBeanExporter] Registering beans for JMX exposure on start up                                                                                2|pika.py- | [12:21:34] [ INFO ] [Http11NioProtocol] Starting ProtocolHandler ["http-nio-<IP_ADDRESS>-2333" ]                                                                                2|pika.py- | [12:21:34] [ INFO ] [NioSelectorPool] Using a shared selector for servlet write/read 2|pika.py- | [12:21:34] [ INFO ] [TomcatWebServer] Tomcat started on port(s): 2333 (http) with context  path ''                                                                                2|pika.py- | [12:21:34] [ INFO ] [Launcher] Started Launcher in 7.803 seconds (JVM running for 9.489) 2|pika.py- | [14:12:28] [ INFO ] [[/]] Initializing Spring FrameworkServlet 'dispatcherServlet' 2|pika.py- | [14:12:28] [ INFO ] [DispatcherServlet] FrameworkServlet 'dispatcherServlet': initializat ion started                                                                                2|pika.py- | [14:12:28] [ INFO ] [DispatcherServlet] FrameworkServlet 'dispatcherServlet': initializat ion completed in 39 ms                                                                                2|pika.py- | [14:12:28] [ INFO ] [AudioLoaderRestHandler] GET /loadtracks 2|pika.py- | [14:12:29] [ INFO ] [AudioLoader] Loaded playlist Search results for: pikachu theme song 2|pika.py- | [14:25:44] [ INFO ] [AudioLoaderRestHandler] GET /loadtracks 2|pika.py- | [14:25:45] [ INFO ] [AudioLoader] Loaded playlist Search results for: pikachu theme song

Should be logging any received voice server/state updates

@Devoxin here's the bots side:
0|pika.py- | [14:12:28] [lavalink.py] [DEBUG] Requesting tracks for query ytsearch:pikachu theme song
0|pika.py- | [14:12:28] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'s
essionId': '11741c4092f2d85ee25d3a481cfd8ccf', 'op': 'voiceUpdate', 'guildId': '406656930510143488', '
event': {'token': '94c340692581ecc7', 'guild_id': '406656930510143488', 'endpoint': 'us-central130.dis
cord.gg:80'}}
0|pika.py- | [14:12:30] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'o
p': 'play', 'guildId': '406656930510143488', 'track': 'QAAAhgIAIkJsdWUgU2F0ZWxsaXRlIOKAkyBQaWthY2h1J3M
gVGhlbWUACkF2aWVuY2xvdWQAAAAAAAHkYAALQkJaVkdEb0dEbG8AAQAraHR0cHM6Ly93d3cueW91dHViZS5jb20vd2F0Y2g/dj1CQ
lpWR0RvR0RsbwAHeW91dHViZQAAAAAAAAAA'}
0|pika.py- | [14:12:30] [lavalink.py] [DEBUG] Dispatching event of type TrackStartEvent to 1 hooks
0|pika.py- | [14:12:39] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'o
p': 'stop', 'guildId': '406656930510143488'}
0|pika.py- | [14:12:39] [lavalink.py] [DEBUG] Dispatching event of type QueueEndEvent to 1 hooks
0|pika.py- | [14:12:41] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'o
p': 'stop', 'guildId': '406656930510143488'}
0|pika.py- | [14:25:44] [lavalink.py] [DEBUG] Requesting tracks for query ytsearch:pikachu theme song
0|pika.py- | [14:25:44] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'s
essionId': '11741c4092f2d85ee25d3a481cfd8ccf', 'op': 'voiceUpdate', 'guildId': '406656930510143488', '
event': {'token': '741f5ca8936d24f4', 'guild_id': '406656930510143488', 'endpoint': 'us-central130.dis
cord.gg:80'}}
0|pika.py- | [14:25:45] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'o
p': 'play', 'guildId': '406656930510143488', 'track': 'QAAAhgIAIkJsdWUgU2F0ZWxsaXRlIOKAkyBQaWthY2h1J3M
gVGhlbWUACkF2aWVuY2xvdWQAAAAAAAHkYAALQkJaVkdEb0dEbG8AAQAraHR0cHM6Ly93d3cueW91dHViZS5jb20vd2F0Y2g/dj1CQ
lpWR0RvR0RsbwAHeW91dHViZQAAAAAAAAAA'}
0|pika.py- | [14:25:45] [lavalink.py] [DEBUG] Dispatching event of type TrackStartEvent to 1 hooks
0|pika.py- | [14:25:55] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'o
p': 'pause', 'guildId': '406656930510143488', 'pause': True}
0|pika.py- | [14:25:59] [lavalink.py] [DEBUG] Send called before websocket ready; queueing payload {'o
p': 'pause', 'guildId': '406656930510143488', 'pause': False}
0|pika.py- | [2018-06-07 14:54:04,240] <IP_ADDRESS> GET /stats h11 200 42 11303
0|pika.py- | [2018-06-07 14:54:11,155] <IP_ADDRESS> GET /stats h11 200 42 10270

Send called before websocket ready, there's no indication that Lavalink.py connected to Lavalink, check your Client parameters match your Lavalink configuration

@Devoxin ```0|pika.py- | Task exception was never retrieved
0|pika.py- | future: <Task finished coro=<WebSocket.connect() done, defined at /root/pika.py/venv/lib/
python3.6/site-packages/lavalink/WebSocket.py:30> exception=InvalidMessage('Malformed HTTP message',)>
0|pika.py- | Traceback (most recent call last):
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/websockets/client.py", line 80, in
read_http_response
0|pika.py- |     status_code, headers = yield from read_response(self.reader)
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/websockets/http.py", line 120, in
read_response
0|pika.py- |     status_line = yield from read_line(stream)
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/websockets/http.py", line 196, in
read_line
0|pika.py- |     raise ValueError("Line without CRLF")
0|pika.py- | ValueError: Line without CRLF
0|pika.py- |
0|pika.py- | The above exception was the direct cause of the following exception:
0|pika.py- |
0|pika.py- | Traceback (most recent call last):
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/lavalink/WebSocket.py", line 52, i
n connect
0|pika.py- |     self._ws = await websockets.connect(self._uri, loop=self._loop, extra_headers=headers
)
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/websockets/client.py", line 404, i
n await
0|pika.py- |     extra_headers=protocol.extra_headers,
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/websockets/client.py", line 262, i
n handshake
0|pika.py- |     status_code, response_headers = yield from self.read_http_response()
0|pika.py- |   File "/root/pika.py/venv/lib/python3.6/site-packages/websockets/client.py", line 82, in
read_http_response
0|pika.py- |     raise InvalidMessage("Malformed HTTP message") from exc
0|pika.py- | websockets.exceptions.InvalidMessage: Malformed HTTP message

Does the websocket host & port match the address in your lavalink config?

I think?
server: # REST server
  port: 2333
  address: <IP_ADDRESS>
lavalink:
  server:
    password: "[redacted]"
    ws:
      port: 80
      host: <IP_ADDRESS>
    sources:
      youtube: true
      bandcamp: true
      soundcloud: true
      twitch: true
      vimeo: true
      mixer: true
      http: true
      local: false
    sentryDsn: ""
    bufferDurationMs: 400
    youtubePlaylistLoadLimit: 600

Judging by this
0|pika.py- | [2018-06-07 14:54:04,240] <IP_ADDRESS> GET /stats h11 200 42 11303
0|pika.py- | [2018-06-07 14:54:11,155] <IP_ADDRESS> GET /stats h11 200 42 10270

You have another webserver running (integrated with your bot?)
Try change the WS port from 80 as this may be conflicting

Do you also have a web server on the same machine?
Also please show your Lavalink.py client config (client object) without your password of course.

Oh, yes. I do have a WS.
Let me change that...

@AndyTempel When I changed the port...
[17:07:00] [ INFO ] [Launcher] Starting Launcher on ubuntu with PID 75445 (/root/lavalink/Lavalink.jar
 started by root in /root/lavalink)
[17:07:00] [ INFO ] [Launcher] No active profile set, falling back to default profiles: default
[17:07:00] [ INFO ] [AnnotationConfigServletWebServerApplicationContext] Refreshing org.springframewor
k.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@6d00a15d: startup date [
Thu Jun 07 17:07:00 UTC 2018]; root of context hierarchy
[17:07:04] [ INFO ] [TomcatWebServer] Tomcat initialized with port(s): 2333 (http)
[17:07:04] [ INFO ] [Http11NioProtocol] Initializing ProtocolHandler ["http-nio-<IP_ADDRESS>-2333"]
[17:07:04] [ INFO ] [StandardService] Starting service [Tomcat]
[17:07:04] [ INFO ] [StandardEngine] Starting Servlet Engine: Apache Tomcat/8.5.28
[17:07:04] [ INFO ] [AprLifecycleListener] The APR based Apache Tomcat Native library which allows opt
imal performance in production environments was not found on the java.library.path: [/usr/java/package
s/lib/amd64:/usr/lib/x86_64-linux-gnu/jni:/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnu:/usr/lib/jni
:/lib:/usr/lib]
[17:07:04] [ INFO ] [[/]] Initializing Spring embedded WebApplicationContext
[17:07:04] [ INFO ] [ContextLoader] Root WebApplicationContext: initialization completed in 4007 ms
[17:07:05] [ INFO ] [ServletRegistrationBean] Servlet dispatcherServlet mapped to [/]
[17:07:05] [ INFO ] [FilterRegistrationBean] Mapping filter: 'characterEncodingFilter' to: [/*]
[17:07:05] [ INFO ] [FilterRegistrationBean] Mapping filter: 'hiddenHttpMethodFilter' to: [/*]
[17:07:05] [ INFO ] [FilterRegistrationBean] Mapping filter: 'httpPutFormContentFilter' to: [/*]
[17:07:05] [ INFO ] [FilterRegistrationBean] Mapping filter: 'requestContextFilter' to: [/*]
[17:07:05] [ INFO ] [GarbageCollectionMonitor] GC monitoring enabled, reporting results every 2 minute
s.
[17:07:05] [ INFO ] [AudioSendFactoryConfiguration] OS: Linux, Arch: amd64
[17:07:05] [ INFO ] [AudioSendFactoryConfiguration] JDA-NAS supported system detected. Enabled native
audio sending.
[17:07:05] [ INFO ] [AudioSendFactoryConfiguration] Setting buffer to 400ms
[17:07:05] [ INFO ] [AudioSendFactoryConfiguration] Setting playlist load limit to 600
[17:07:05] [ INFO ] [Launcher] No sentry dsn found, turning off sentry.
[17:07:05] [ ERROR] [SocketServer] Caught exception in websocket
java.net.BindException: Address already in use
        at sun.nio.ch.Net.bind0(Native Method)
        at sun.nio.ch.Net.bind(Net.java:433)
        at sun.nio.ch.Net.bind(Net.java:425)
        at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
        at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
        at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
        at org.java_websocket.server.WebSocketServer.run(WebSocketServer.java:315)
        at java.lang.Thread.run(Thread.java:748)
Exception in thread "WebsocketSelector18" java.lang.NullPointerException
        at org.java_websocket.server.WebSocketServer.stop(WebSocketServer.java:257)
        at org.java_websocket.server.WebSocketServer.stop(WebSocketServer.java:263)
        at org.java_websocket.server.WebSocketServer.handleFatal(WebSocketServer.java:539)
        at org.java_websocket.server.WebSocketServer.run(WebSocketServer.java:321)
        at java.lang.Thread.run(Thread.java:748)
[17:07:07] [ INFO ] [RequestMappingHandlerAdapter] Looking for @ControllerAdvice: org.springframework.
boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext@6d00a15d: startup date [Th
u Jun 07 17:07:00 UTC 2018]; root of context hierarchy
[17:07:07] [ INFO ] [RequestMappingHandlerMapping] Mapped "{[/loadtracks],methods=[GET],produces=[appl
ication/json]}" onto public java.lang.String lavalink.server.player.AudioLoaderRestHandler.getLoadTrac
ks(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse,java.lang.String) thro
ws java.io.IOException,java.lang.InterruptedException
[17:07:07] [ INFO ] [RequestMappingHandlerMapping] Mapped "{[/decodetrack],methods=[GET],produces=[app
lication/json]}" onto public java.lang.String lavalink.server.player.AudioLoaderRestHandler.getDecodeT
rack(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse,java.lang.String) th
rows java.io.IOException
[17:07:07] [ INFO ] [RequestMappingHandlerMapping] Mapped "{[/decodetracks],methods=[POST],consumes=[a
pplication/json],produces=[application/json]}" onto public java.lang.String lavalink.server.player.Aud
ioLoaderRestHandler.postDecodeTracks(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServ
letResponse,java.lang.String) throws java.io.IOException
[17:07:07] [ INFO ] [RequestMappingHandlerMapping] Mapped "{[/debug/nashorn],methods=[POST]}" onto pub
lic java.lang.String lavalink.server.util.DebugRestHandler.getLoadTracks(javax.servlet.http.HttpServle
tRequest,javax.servlet.http.HttpServletResponse,java.lang.String,java.lang.String)
[17:07:07] [ INFO ] [RequestMappingHandlerMapping] Mapped "{[/error],produces=[text/html]}" onto publi
c org.springframework.web.servlet.ModelAndView org.springframework.boot.autoconfigure.web.servlet.erro
r.BasicErrorController.errorHtml(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletR
esponse)
[17:07:07] [ INFO ] [RequestMappingHandlerMapping] Mapped "{[/error]}" onto public org.springframework
.http.ResponseEntity<java.util.Map<java.lang.String, java.lang.Object>> org.springframework.boot.autoc
onfigure.web.servlet.error.BasicErrorController.error(javax.servlet.http.HttpServletRequest)
[17:07:07] [ INFO ] [SimpleUrlHandlerMapping] Mapped URL path [/webjars/**] onto handler of type [clas
s org.springframework.web.servlet.resource.ResourceHttpRequestHandler]
[17:07:07] [ INFO ] [SimpleUrlHandlerMapping] Mapped URL path [/**] onto handler of type [class org.sp
ringframework.web.servlet.resource.ResourceHttpRequestHandler]
[17:07:07] [ INFO ] [SimpleUrlHandlerMapping] Mapped URL path [/**/favicon.ico] onto handler of type [
class org.springframework.web.servlet.resource.ResourceHttpRequestHandler]
[17:07:07] [ INFO ] [AnnotationMBeanExporter] Registering beans for JMX exposure on startup
[17:07:07] [ INFO ] [Http11NioProtocol] Starting ProtocolHandler ["http-nio-<IP_ADDRESS>-2333"]
[17:07:07] [ ERROR] [StandardService] Failed to start connector [Connector[HTTP/1.1-2333]]
org.apache.catalina.LifecycleException: Failed to start component [Connector[HTTP/1.1-2333]]
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:167)
        at org.apache.catalina.core.StandardService.addConnector(StandardService.java:225)
        at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.addPreviouslyRemovedConnectors
(TomcatWebServer.java:255)
        at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.start(TomcatWebServer.java:197
)
        at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.startWebSer
ver(ServletWebServerApplicationContext.java:300)
        at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefre
sh(ServletWebServerApplicationContext.java:162)
        at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationC
ontext.java:552)
        at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(Ser
vletWebServerApplicationContext.java:140)
        at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:752)
        at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:388)
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:327)
        at lavalink.server.Launcher.main(Launcher.java:54)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:48)
        at org.springframework.boot.loader.Launcher.launch(Launcher.java:87)
        at org.springframework.boot.loader.Launcher.launch(Launcher.java:50)
        at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:51)
Caused by: org.apache.catalina.LifecycleException: Protocol handler start failed
        at org.apache.catalina.connector.Connector.startInternal(Connector.java:1021)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
        ... 19 common frames omitted
Caused by: java.net.BindException: Address already in use
        at sun.nio.ch.Net.bind0(Native Method)
        at sun.nio.ch.Net.bind(Net.java:433)
        at sun.nio.ch.Net.bind(Net.java:425)
        at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
        at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
        at org.apache.tomcat.util.net.NioEndpoint.bind(NioEndpoint.java:210)
        at org.apache.tomcat.util.net.AbstractEndpoint.start(AbstractEndpoint.java:1150)
        at org.apache.coyote.AbstractProtocol.start(AbstractProtocol.java:591)
        at org.apache.catalina.connector.Connector.startInternal(Connector.java:1018)
        ... 20 common frames omitted
[17:07:07] [ INFO ] [Http11NioProtocol] Pausing ProtocolHandler ["http-nio-<IP_ADDRESS>-2333"]
[17:07:07] [ INFO ] [StandardService] Stopping service [Tomcat]
[17:07:07] [ INFO ] [LifecycleBase] The stop() method was called on component [StandardServer[-1]] aft
er stop() had already been called. The second call will be ignored.
[17:07:07] [ INFO ] [Http11NioProtocol] Stopping ProtocolHandler ["http-nio-<IP_ADDRESS>-2333"]
[17:07:07] [ INFO ] [Http11NioProtocol] Destroying ProtocolHandler ["http-nio-<IP_ADDRESS>-2333"]
[17:07:07] [ INFO ] [GarbageCollectionMonitor] GC monitoring disabled.

Config: https://gist.github.com/ThatNerdyPikachu/4782e0c40c843fbbccde32d1aafc1573

Tomcat webserver couldn't start because the address/port is in use. Try change the port your REST server uses.

If it helps at all, it queries successfully,,and it says now playing and such

Can you dump your code somewhere? (e.g. Hastebin)

It's literally the example cog code (for now), with the ports changed

It successfully sends stuff to the REST server, but not to WS

REST is a different matter. Could you try call lavalinkClient.WS.connect()?

all its doing is it says "connecting..." but never finishes

[21:57:06] [lavalink.py] [DEBUG] Preparing to connect to Lavalink
[21:57:06] [lavalink.py] [DEBUG]     with URI: ws://localhost:5244
[21:57:06] [lavalink.py] [DEBUG]     with headers: {'Authorization': '[redacted]', 'Num-Shards': 1, 'User-Id':<PHONE_NUMBER>68615680}
[21:57:06] [lavalink.py] [INFO] Connecting to Lavalink...

lavalink shows nothing on its side

@Devoxin It finally connects!
Yet, when I try to play...
Uncaught exception in thread "WebSocketWorker-16":java.lang.NoClassDefFoundError: com/sedmelluq/discord/lavaplayer/jdaudp/NativeAudioSendFactory
        at lavalink.server.io.SocketContext.lambda$getAudioSendFactory$7(SocketContext.java:146)
        at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1660)
        at lavalink.server.io.SocketContext.getAudioSendFactory(SocketContext.java:141)
        at lavalink.server.io.SocketContext.lambda$getCore$3(SocketContext.java:90)
        at java.util.HashMap.computeIfAbsent(HashMap.java:1127)
        at lavalink.server.io.SocketContext.getCore(SocketContext.java:87)
        at lavalink.server.io.SocketServer.onMessage(SocketServer.java:137)
        at org.java_websocket.server.WebSocketServer.onWebsocketMessage(WebSocketServer.java:551)
        at org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:696)
        at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:367)
        at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:212)
        at org.java_websocket.server.WebSocketServer$WebSocketWorker.run(WebSocketServer.java:888)
Caused by: java.lang.ClassNotFoundException: com.sedmelluq.discord.lavaplayer.jdaudp.NativeAudioSendFactory
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:93)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 12 more

What version of Java are you using? Upgrade to v10 if you can, especially if you're on v8.

Fixed by upgrading Lavalink to dev branch


Refresh the sample app

updated dependencies
removed buildToolsVersion - the project automatically uses a default version of the build tools that the plugin specifies. docs
renamed compose function to follow compose naming convention
removed lint warnings - add an experimental annotation for Coil
sorted contacts in descending order by "isStarred" - to imitate the original Google contacts application
removed test runner - sample app does not have any tests

@tatocaster I saw you pushed some changes. Everything looks good from my end, but I am not sure if you are done with your changes. Are you happy for me to merge?

At this moment, yes 🚀 This PR is completely related to the sample app. I will merge it immediately when you approve
Thanks for the quick response 🙏

@alexstyl looks like, you need to merge those changes 🙌

Merged. Thanks again for the contribution @tatocaster :)


Create RandomSource

To test the importance of custom initialization, it is useful to have a source that has a randim uniform morphology, with a SED read of by projecting into the observation frames.
The first part is trivial, the second requires functionality that we might want to have anyways.

I'll look into that. MuSCADeT has random or 0 initialisation, which works because we don't optimise for the SED. But a good initialisation of the SEDs should do the trick too.


Large int64 rendered as negative number

Hi. If a pandas dataframe column contains large int64 numbers the DataGrid renders some of them as negative numbers.
data = {
    'A': np.random.randint(1e15, 1e18, size=10, dtype='int64'),
    'B': np.random.randint(1e15, 1e18, size=10, dtype='int64'),
}

test_df = pd.DataFrame(data)

grid = DataGrid(test_df, layout={'height': '600px'},
                base_column_size=100,
                base_row_size=32,
                selection_mode='cell',
               )
grid

While transforming such columns into str solve the problem, it then takes a lot of time to construct and render the DataGrid. Any solution for that?

Seems like pandas views the int64 as an unsigned representation, while DataGrid is using a signed representation.


Update Debugging WinForms Controls tutorial page to indicate this doesn't work for .NET controls.

Users are attempting to use this page to create and debug WinForms .NET controls. This no longer works given that our designer now runs out of process. @KlausLoeffelmann is creating a doc to show how to do this. We're working on blogs and other docs to cover the WinForms .NET controls creation process currently and how to debug them. We will be creating an WinForms Designer SDK Extensibility samples repo shortly that will include samples and how to docs for everything.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cf24e8a-af35-53f6-093d-5392128ad3fb
Version Independent ID: f493ff27-e2e1-ad7e-38d4-46ded0c45022
Content: Debug Custom Controls at Design Time - Windows Forms .NET Framework
Content Source: dotnet-desktop-guide/framework/winforms/controls/walkthrough-debugging-custom-windows-forms-controls-at-design-time.md
Product: dotnet-framework
Technology: dotnet-winforms
GitHub Login: @adegeo
Microsoft Alias: adegeo

@merriemcgaw This still works for .NET Framework projects though, right?

Yes, it does. Well, at least for .NET Framework projects in the classic WinForms Designer. There will be scenarios, where even .NET Framework projects need to be designed in the .NET Framework OOP Designer, namely when you need to design 32-Bit Components in a .NET Framework App in VS 2022 (which is 64-Bit). For that, you would also need to use the .NET Framework WinForms OOP Designer. That one is work in progress, though.

What @KlausLoeffelmann said 😄


[SMT] Creates a new event rollup to kafka connect new relic

Hi,
I have created this PR to make possible to a different kind of event from the available "agent" could be uploaded to New Relic.
This has been tested with Kafka Connect base 6.0.1.
I hope it can get some reviews and be part of the project.
Thank you very much,
Guilherme

@wolvery Can you give a brief description of the use case that was driving this PR?  Thanks.

@JimHagan, we are using this connector to export events from an avro topic to new relic. We emit events when some problem occurs and we need them at New Relic to alert

Hi @wolvery - thanks for the PR.  The changes are are in the right sprit. However, there is currently an open PR for v2.0 which I believe would handle both of your use cases (Avro messages, and processing single events without having to use an SMT to insert them into a list).

Well, in this case, we can close this PR.
I look forward to this new version!
Thank you very much.

Closing, as functionality is inclusive in 2.0.0


I having some issues to insert a new Node in mobile mode

Hi, I need support of how insert a new Node in the IChart throw click event or touch event.
I understand that the Drag and Drop event is the actual solution, but i have a case when my website is in mobile mode where drag and drop doesnt works.
I will a appreciate any feedback of how to archive my goal in this.
Best Regards

Hi, @MrBlenny . I trying to use your library in mobile mode. So,  I trying to add touch event to manage link conection between ports, but I cant capture  the html element inside the event when "touchend" happened. Only appear the html where started the touch event. This is in Port.wrapper.tsx
Do you have any comment regarding of this?
Best Regards

I haven't really been testing it on mobile. Happy to accept any PRs if you find a fix.


Caliptra model for SoC Cmodel

NVIDIA uses an SoC C-model to do code development and validation for fullchip collateral. We would want to integrate a Caliptra model of the external registers https://ereg.caliptra.org for the boot process and the SoC ROM code to develop against.
@nstewart-amd had proposed a similar problem statement to @korran and @vsonims during December meet-up. Unclear whether there was a follow-up, so filing the ticket.

Yeah, this is on my plate. Will send out some header files for review later this week.

I have an example API in the branch:
https://github.com/korran/caliptra-sw/tree/hwmodel-c

caliptra_model.h
test_case.c (example)

Is an interface to caliptra-sw-emu model the only one requested?


automation: backport e2e tests to 2.8

Summary
Fixes #

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

[ ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[ ] The PR has a Milestone
[ ] The PR template has been filled out
[ ] The PR has been self reviewed
[ ] The PR has a reviewer assigned
[ ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Closing this pr. meant to compare to release-2.8 branch, not master


REM

Hey 👋
Really cool idea editor!
Just one question - why would you use REM in 2020 for font sizes?

Hey, and thanks!
Short answer: Material-UI's Theme uses rem units by default for typography font sizes
Longer answer: The theme options object shown in the code editor is piped directly into createMuiTheme(). Values shown in the Tool Panel are pulled directly from the resulting Theme object. Material-UI uses rem font sizes by default for typography font sizes, so unless explicitly set, that's the unit used.
The Font Size input in the Tool Panel has a drop down on the units to select different units:

Or, if you explicitly set the font size for a typography type in the code editor, it will switch to that unit in the Tool Panel
e.g.
{
  palette: {
    type: 'light',
    primary: {
      main: '#3f51b5',
    },
    secondary: {
      main: '#f50057',
    },
  },
  typography: {
    h1: {
      fontSize: 75,
    },
  },
}

On that note, though, I'm not particularly aware of a reason not to use rem. It's relative to the font-size of the root html element, so with it being used as default, you can change all of the typography element sizes at once. e.g. if you'd like to increase the font-size of all typography elements by, say, 25%, you could change the base typography fontSize from 14px to 17px.
{
  palette: {
    type: 'light',
    primary: {
      main: '#3f51b5',
    },
    secondary: {
      main: '#f50057',
    },
  },
  typography: {
    fontSize: 17,
  },
}

Do you know of a reason not to be using rem units in 2020?

The idea of REM is to provide a better accessibility by allowing the user to increase the base font size.
Actually that's a great idea and therefore was used a lot especially before all browser vendors provided a good zoom feature.
The problem with consistency - when using REM for parts of the page you need to use it everywhere (media queries, paddings, margins, animations, ...) or your page you will most likely break if the user changes their base font size.
I guess with your dropdown it's good enough - it let's the developer decide if they really want to use REM 👍

After playing around with some of my apps and my browser font size settings, I can definitely see what you mean about spacing issues, and some areas breaking. Thanks for bringing that up, it's a good reminder to ensure accessibility needs are being supported.
Based on the Material-UI docs on Font Size, rem units appear to be an intentional choice, citing accessibility support as a reason. I always understood that and the MDN note on font-size to mean that using rem/em is strongly encouraged in the case that the user changes their base font size, so I'm a bit surprised to hear this opinion.
I must admit though, I'm not up-to-date on what methods the visually-impaired use to navigate the web, so purely as a learning opportunity for me, if you have any links to info about that, and guidelines for developing for that, I'd be very interested in reading it!
In any case, I think the best stance is to keep the theme editor unopinionated about it, and default the decision to Material-UI.
I definitely agree though, best not to force that opinion on developers, and have a dropdown to change it.


Can't find API page in AU

I'm in australia and under my account I didn't find the API application button. In account page it says: Account opening and access are not available in your current region.

Seems I can't visit it from url: https://www.webull.com/. I'm using https://www.webull.com.au ?

No support for au yet, will be available in 2025


Refactor KerasModelCaller to prevent using an unassigned variable.

Should #756. Instead of misusing try-finally the common code is just extracted in a method and then called before returning. This should not fail on unassigned variable.

Makes sense!

Thanks. Unfortunately, keras.py is not covered by tests. I only tried that in my Jupyter notebook and went fine - it just uncovered an unrelated exception that caused the variable being unassigned.


systrayhelper: 0.0.4 -> 0.0.5

Motivation for this change
updates to the latest release v0.0.5 which includes some fixes and dependency updates.
also includes a checkPhase using xvfb_run to spawn go test, which starts i3 and the helper and then uses xdotool to send clicks back to the helper
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/using-xvfb-in-checkphase/1497/4

Is this a WIP? Otherwise, you need remove commented out code / todos (don't forget ...)

@rasendubi: indeed an oversight, thanks!
I'll try to add the ffmpeg record mechanics in pre/postCheckHook so that I can use them through an override from the source.

updated to respect review comments and rebased on master.

@GrahamcOfBorg build systrayhelper

nix-review fails for me with the following error:
builder for '/nix/store/pbyhaj1ls312xlmvxgxljls5n7m2bwcv-systrayhelper-0.0.5.drv' failed with exit code 1; last 10 log lines:
      xvfb_test.go:32: found i3-msg here: /nix/store/nnskv7cmcv35nvhsac5pcjfddqd6i2lr-i3-4.16.1/bin/i3-msg
      xvfb_test.go:32: found xdotool here: /nix/store/ivkzr71ck6in70p5k8gr0mqm8zbxdi81-xdotool-3.20160805.1/bin/xdotool
      require.go:794:
          	Error Trace:	xvfb_test.go:31
          	Error:      	Received unexpected error:
          	            	exec: "systrayhelper": executable file not found in $PATH
          	Test:       	TestClicking
          	Messages:   	did not find systrayhelper
  FAIL
  FAIL	github.com/ssbc/systrayhelper/test	0.003s
cannot build derivation '/nix/store/f3fyzpn9y8j0h1kblx5mrhsfhvfb2749-env.drv': 1 dependencies couldn't be built

I think export PATH=$PATH:$(pwd)/go/bin is still needed in checkPhase (without i3 and xdotool)

I'm closing as CI fails and OP seems to not care as for making this update work and to much time has passed.


include bash script to automatically config udev rules

include bash script to automatically config udev rules and define TURTLEBOT_3D_SENSOR and TURTLEBOT_BATTERY

-1: turtlebot uses astra_camera, not the other way around. So turtlebot should know about astra, but in this repo there should not be any mention of turtlebot at all.

That script is to configure an Astra on a specific laptop (Acer E3-111-C0QT) before the needed Astra changes were synced to stabled debs.

makes sense!


x/tools/godoc/static: test failure for go1.9 (static.go is stale)

From the build log:
darwin-386-10_11 at 1746cff738c7c801988f18cd25ca0cb488889873 building tools at c995a088887b4ae00a4c85a984117cbc8d86ca3d

ok  	golang.org/x/tools/benchmark/parse	0.005s
ok  	golang.org/x/tools/blog	0.013s
?   	golang.org/x/tools/blog/atom	[no test files]
...
ok  	golang.org/x/tools/godoc	0.758s
?   	golang.org/x/tools/godoc/analysis	[no test files]
ok  	golang.org/x/tools/godoc/redirect	0.025s
--- FAIL: TestStaticIsUpToDate (0.08s)
	gen_test.go:25: static.go is stale
FAIL
FAIL	golang.org/x/tools/godoc/static	0.085s

This is currently preventing the x/tools builders from turning "green".

This has changed because of a change in the status of the Unicode code point \u9fe5.  In Go 1.9 strconv.IsPrint('\u9fe5') returns false.  In 1.10 and 1.11 it returns true.  This changes the behavior of strconv.Quote, which changes the behavior of the %q used by the Generate function being tested.
The change to strconv.Quote happened in https://golang.org/cl/63953, which updated the package to Unicode 10.0.0
I think if we want this test to be stable across Go releases we should not be using %q to print non-string data.
CC @agnivade

Thanks for the analysis @ianlancetaylor. I believe you are talking about this part of the code -
if utf8.Valid(b) {
	fmt.Fprintf(buf, "`%s`", sanitize(b))
} else {
	fmt.Fprintf(buf, "%q", b)
}

I think if we are to simply use %s, there is some more sanitization that needs to be done. Because if I  try to print with `%s`, it throws an illegal UTF-8 encoding error.  ping @bradfitz who probably wrote/reviewed the sanitize function.
Or should we maintain per-release copies of static.go and delete it once 1.11 is released ?


"Cannot create a Trace from null" from 'pub get', because commondatastorage.googleapis.com:57255 is unresponsive

First time trying Dart, so this could be me. Not sure if this is related to the other "Cannot create a Trace from null" issue (16408) or not.
What steps will reproduce the problem?

Download DartEditor
Create new Polymer application
Do a 'pub get'

What is the expected output? What do you see instead?
I don't know, because it's my first time with Dart. But I get errors.
What version of the product are you using? On what operating system?
Tried current stable Linux 64-bit and last night's nightly
Please provide any additional information below.
This appears to be cause by a particular service, commondatastorage.googleapis.com:57255, being unresponsive.
Here's the 'pub --trace get' output: https://gist.github.com/anonymous/8746784

This issue has been moved to dart-lang/pub#840.


How to modify the voxel's size(range)

I succeed in training and testing with Kittidataset.
It works well. Thank you!
By the way, i have my custom dataset(Format is same with Kittidataset)
so i want to change the voxel generator range on config.py
I changed like this
range=[0, -40.0, -3.0, 70.4, 40.0, 1.0], -> range=[-52.8, -32.0, -3.0, 52.8, 32.0, 1.0],
But i got this error
RuntimeError: The size of tensor a (84480) must match the size of tensor b (70400) at non-singleton dimension 0
I know this error is caused by incorrect the number of voxel from the different range.
Is there any ways to train and test with like my different range without changing existing model architecture?
What should i change?

The feature map size will also be changed, so you need to check the network details and data preprocess carefully to comply with your new range.

@Vegeta2020
Did you test with only Kitti Dataset or Have you tested with others like Nuscense, Lift?

I test it only on kitti.


support 103 Early Hints for renderer

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/103
Will depend on https://github.com/nodejs/node/pull/44180.
https://github.com/unjs/nitro/blob/main/src/runtime/renderer.ts

Added via https://github.com/nuxt/framework/pull/7893 for nuxt


[BUG] @cython.cfunc is applied to inner functions too

Describe the bug
The cython.cfunc decorator is applied not just to the function that is decorates, but to all enclosed functions. This causes a compiler crash.
I suspect that there's other decorators that this applied to as well (e.g. cython.returns, cython.cclass, etc). I haven't made a thorough check of these yet though.
To Reproduce
Code to reproduce the behaviour:
import cython

@cython.cfunc
def f():
    def inner():  # should not be a cfunc
        pass
    return inner

The error message ends with
Cython/Compiler/ParseTreeTransforms.py", line 2783, in create_class_from_scope
    if not node.py_cfunc_node:
AttributeError: 'CFuncDefNode' object has no attribute 'py_cfunc_node'

(but I don't think this is actually hugely useful to the bug)
Expected behavior
f should be a cdef function, inner should be a regular function.
Environment (please complete the following information):

OS: Linux
Python version: 3.8.8
Cython version: current master branch

IIRC, we previously ignored this issue because cdef functions cannot have closures anyway.
It definitely shouldn't crash, though. Does it also happen with cdef syntax?

Does it also happen with cdef syntax?

Works and runs fine:
cdef f():
    def inner():  # should not be a cfunc
        pass
    return inner

Fails correctly with "C function definition not allowed here"
cdef f():
    cdef inner():  # should not be a cfunc
        pass
    return inner

I can confirm @cython.cclass also has a very similar bug.


ssh_certificate role fails when the file private key file is already present using the ssh_key_generation_type provide feature

PROBLEM SUMMARY
ssh_certificate role is returning an error on its second execution when the variable ssh_key_generation_type is set to providedand an existing public key is provided.
STEPS TO REPRODUCE
Set the ssh_key_generation_type toprovidedand thessh_public_key_path` to provide an existing public key, execute your playbook twice and in the second executing you'll receive the above mentioned error
EXPECTED RESULTS
The following error appears:
\tResponse: b'{\"Response\":{\"ErrorCode\":41,\"ErrorMessage
\":\"Unique public key data must be used. Requested public key hash: 2E737935ED7C51A9EDDEBE11D93B446919A4911B\",\

ACTUAL RESULTS

ENVIRONMENT DETAILS

venafi.machine_identity 0.7.5

COMMENTS/WORKAROUNDS

No Workaround found so far.

@ricrodriguezg This is expected behaviour. The error comes from SSH Protect. By default, the SSH certificate issuance templates disallow private key reuse. However, this can be adjusted on the issuance template.


Issues with targetMaxTimeInterval

There are two problems with targetMaxTimeInterval

The comments says "Option: desired maximum time in seconds stored in a log file, if 0, no maximum (log files may exceed this, it's a guideline only)"

However, the code does:
   if targetMaxTimeInterval < 1 {
                targetMaxTimeInterval = 600
            }

So, setting it to 0 will set it to 600 (vs infinity)

AutoRotatingFileDestination.init has code

   if shouldRotate() {
            rotateFile()
        }

This code is executed before we had opportunity to set targetMaxTimeInterval or targetMaxFileSize. As result, this code will always check against default value (which is 600). So it will always rotate after an app restarted in 10 minutes.

Found this issue, too.
Tackled it with a pull request  #-> #207

#207 merged, should resolve this issue. Thanks!


How can I save the current scene？

I listened to the Scene's onUpdate event.
When I start  A Activity to B Activity and back, the model in the scene disappeared and I couldn't add it any more.
The  code is as follows：
@Override
    public void onUpdate(FrameTime frameTime) {
        Frame frame = playFragment.getArSceneView().getArFrame();
        if (frame != null) {
            Iterator var3 = frame.getUpdatedTrackables(Plane.class).iterator();
            while (var3.hasNext()) {
                Plane plane = (Plane) var3.next();
                if (plane.getTrackingState() == TrackingState.TRACKING) {
                    playFragment.getPlaneDiscoveryController().hide();
                    Iterator<Anchor> iterableAnchor = frame.getUpdatedAnchors().iterator();
                    if (!iterableAnchor.hasNext()) {
                        List<HitResult> hitTests = frame.hitTest(getScreenCenter().x, getScreenCenter().y);
                        Iterator hitTestIterator = hitTests.iterator();
                        while (hitTestIterator.hasNext()) {
                            HitResult hitResult = (HitResult) hitTestIterator.next();
                            centerPose = hitResult.getHitPose();
                            if (anchorNode == null) {
                                Anchor modelAnchor = plane.createAnchor(hitResult.getHitPose());
                                anchorNode = new AnchorNode(modelAnchor);
                                anchorNode.setLocalScale(new Vector3(0.2f, 0.2f, 0.2f));
                                anchorNode.setParent(playFragment.getArSceneView().getScene());
                                node.setParent(anchorNode);
                                float tx = centerPose.tx();
                                float ty = centerPose.compose(Pose.makeTranslation(0.0f, 0.05f, 0.0f)).ty();
                                float tz = centerPose.tz();
                                node.setLocalPosition(new Vector3(tx, ty, tz));
                            }
                        }
                    }
                }
            }
        }
    }

How can I save the current scene or re-add the model to the current scene?

how did you solve this??????????????

how did you solve this??????????????

It is not really solved, just save some data of the current scene, and re-place it when you come in again, but the effect is not good.


Update Typeorm

What does this PR do?
Updated TypeORM, there are breaking changes in their new version.
Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this be tested?

[x] Unit tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code and corrected any misspellings
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

LGTM. Tested POST,PATCH,DELETE,GET operations plus migration with postgres.


Update Peering SDK to 2020-04-01 API version

/azp run net - mgmt - ci

Hello @psanapathi

Please add a link to the openapi spec review PR here
peering_resource-manager.txt is in old format, please update your build tools and make sure the SDK is generated by running src/generate.ps1
Update api tag in AzSdk.RP.props, release notes in csproj
Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

API spec PR: https://github.com/Azure/azure-rest-api-specs/pull/9361
Metadata is updated now
API tag, version, and release notes are updated now


CytoSnake Bug Fixes From Cell-Health Data Usage

modified from EmbeddedArtistry
Description
Thank you for your contribution to CytoSnake!
Please succinctly summarize your proposed change.
What motivated you to make this change?
Please also link to any relevant issues that your code is associated with.
This PR fixes bugs that were found and squashed on the cell-health dataset  when using CytoSnake locally.
The next step is to make a release after this PR is merged, and use it as a dependency for the cell-health dataset
What is the nature of your change?

[X] Bug fix (fixes an issue).
[ ] Enhancement (adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] This change requires a documentation update.

Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.

[X] I have read the CONTRIBUTING.md guidelines.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added tests that prove my fix is effective or that my feature works.
[X] I have deleted all non-relevant text in this pull request template.

Alright all comments have been addressed! Merging !


Nightly K8s Matrix CI 2023-08-16: Failed

action url: https://github.com/spidernet-io/spiderpool/actions/runs/5883386451

[FAILED] failed to create v6 ippool v6pool-b6cca3011aafa4d ,err is admission webhook "spiderippool.spiderpool.spidernet.io" denied the request: SpiderIPPool.spiderpool.spidernet.io "v6pool-b6cca3011aafa4d" is invalid: spec.ips: Forbidden: overlap with IPPool v6pool-58d00d199ab2798 in IP ranges [fd00:81cc::2], total IP addresses of an IPPool are jointly determined by 'spec.ips' and 'spec.excludeIPs'

  Expected success, but got an error:
      <*errors.StatusError | 0xc0006a4e60>:
      admission webhook "spiderippool.spiderpool.spidernet.io" denied the request: SpiderIPPool.spiderpool.spidernet.io "v6pool-b6cca3011aafa4d" is invalid: spec.ips: Forbidden: overlap with IPPool v6pool-58d00d199ab2798 in IP ranges [fd00:81cc::2], total IP addresses of an IPPool are jointly determined by 'spec.ips' and 'spec.excludeIPs'
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "admission webhook \"spiderippool.spiderpool.spidernet.io\" denied the request: SpiderIPPool.spiderpool.spidernet.io \"v6pool-b6cca3011aafa4d\" is invalid: spec.ips: Forbidden: overlap with IPPool v6pool-58d00d199ab2798 in IP ranges [fd00:81cc::2], total IP addresses of an IPPool are jointly determined by 'spec.ips' and 'spec.excludeIPs'",
              Reason: "Invalid",
              Details: {
                  Name: "v6pool-b6cca3011aafa4d",
                  Group: "spiderpool.spidernet.io",
                  Kind: "SpiderIPPool",
                  UID: "",
                  Causes: [
                      {
                          Type: "FieldValueForbidden",
                          Message: "Forbidden: overlap with IPPool v6pool-58d00d199ab2798 in IP ranges [fd00:81cc::2], total IP addresses of an IPPool are jointly determined by 'spec.ips' and 'spec.excludeIPs'",
                          Field: "spec.ips",
                      },
                  ],
                  RetryAfterSeconds: 0,
              },
              Code: 422,
          },
      }
  In [It] at: /home/runner/work/spiderpool/spiderpool/test/e2e/annotation/annotation_test.go:596 @ 08/16/23 20:33:00.666


Before

After

All Promptflow Contribution checklist:

[x] The pull request does not introduce [breaking changes].
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Also change this to absolute path?

should use another way to do, leveraging debug info, will open another PR to do so


Fix legend color not matching line color

Legend color does not match multi series charts if default color scheme is not used. Please check if the logic is correct before merging.
I am currently working around this by declaring an extra field "option" and filling in mock data to bypass the check

Thank you, it was indeed a mistake from me.


Build(deps): Bump simple-git from 3.14.0 to 3.15.1 (#4416)

Pull request opened by the merge tool on behalf of #4416

Merged in aebbe7aa3796800d1360402de4ac928acd53f7bb


Implement ErsatzTV style 'filler kinds'

ErsatzTV filler 'kinds' are nice and fairly difficult to replicate in old dizqueTV. The following types are supported (pulled from ErsatzTV website):
Pre-roll: filler that plays before each media item
Mid-roll: filler that plays between chapters within each media item
Post-roll: filler that plays after each media item
Tail: filler that plays after all media items/filler and before the next schedule item
Fallback: filler that is looped and cut as needed to fill any remaining gaps

Another filler type could be a "bookend" filler. Instead of being bound to media, this filler is bound to other filler. i.e. bumpers that play before the start of and at the end of a "commercial break".

Would be cool if there was a way to tag filler, and add filler by said tag. Tags such as: kid-friendly, adult, and genre specific. That way you can exclude filler that doesn’t fit the target audience.

If I may add an additional enhancement over ETV to this, a more advanced "mid-roll" filler would be nice. ETV will put filler between all chapters present in a file, but there may be more (or I guess even less) chapters than places where there should be breaks. For instance I have a series with chapters laid out such as follows:
00:00:00.000: en:Prologue
00:01:50.027: en:Opening
00:03:19.991: en:Part A
00:10:44.102: en:Part B
00:22:26.136: en:Ending
00:23:56.060: en:Preview

however this show should only have breaks in three places, between opening song and part a, between part a and part b, and between part b and ending song. ETV's mid-roll filler would add two additional filler spots to this, meaning for instance you'd get a filler break, the theme song for the show would play, and then you'd go right into another filler break. ETV's only solution to this is to edit the chapters within the file, which not everyone is willing/able to mass edit their media libraries for something like this.


Time varying solver

While working on #826, I noticed that time-varying solveOnePeriod methods, passed in a list, are read going forwards in the list. All other parameters in timeVary are read backwards from the list, so I believe this is a bug.
(Alternatively one could create the ``solveOnePeriod` list going backwards in time, but I don't think that's the desired behavior)
This PR fixes the issue.

Yikes, let me take a look at this.  That would be a pretty fundamental error.

As @mnwhite is very busy, I've been assigned to review this PR.
My first observation is that the code change has not modified any automated tests, and has not caused any automated tests to fail.
That implies that the functionality effected by the change is not currently covered by an automated test.
Therefore, I do not think this PR is ready to be merged.
@Mv77 would you be able to write an automated test for the functionality being addressed?
I am happy to meet and work with you to introduce you to the automated testing framework if that would be helpful.

As @mnwhite is very busy, I've been assigned to review this PR.
My first observation is that the code change has not modified any automated tests, and has not caused any automated tests to fail.
That implies that the functionality effected by the change is not currently covered by an automated test.
Therefore, I do not think this PR is ready to be merged.
@Mv77 would you be able to write an automated test for the functionality being addressed?
I am happy to meet and work with you to introduce you to the automated testing framework if that would be helpful.

Yes, the reason why no behavior is modified is that (I think) no example or test in HARK uses the time-varying solver functionality.
Sure, I could take a stab at writing a test. We'd need to talk about how the test would look like however, since none of the agent types currently in HARK lends itself to this functionality very easily.

It looks like there is already an issue for this here: #678 If this problem interests you, I suggest you claim it. May we add you as a collaborator on the repository?
Perhaps @mnwhite and @llorracc  have some downstream code that demonstrates its usefulness that could be converted into an example and test combination.
One the other hand, I believe this functionality is also being staged for a redesign.
The discussion in #798 about periods and frames pertains mainly to model definitions and includes a discussion of "cyclic" problems. There has been a rather large amount of difference of opinion about the best way to handle 'cycles', 'lifecycles', etc.
One part of that redesign which I believe is not yet fully specified is how to organize methods for backwards induction at each frame.
See also #495 for background discussion.

Writing a test for this would be rather cumbersome: he would have to add an
entire new model to HARK. Mateo is doing this anyway, which is how he found
this error. This PR is independent of that model.
On Wed, Sep 30, 2020, 10:52 AM Sebastian Benthall<EMAIL_ADDRESS>wrote:

It looks like there is already an issue for this here: #678
https://github.com/econ-ark/HARK/issues/678 If this problem interests
you, I suggest you claim it. May we add you as a collaborator on the
repository?
Perhaps @mnwhite https://github.com/mnwhite and @llorracc
https://github.com/llorracc have some downstream code that demonstrates
its usefulness that could be converted into an example and test combination.
One the other hand, I believe this functionality is also being staged for
a redesign.
The discussion in #798 https://github.com/econ-ark/HARK/issues/798
about periods and frames pertains mainly to model definitions and includes
a discussion of "cyclic" problems. There has been a rather large amount of
difference of opinion about the best way to handle 'cycles', 'lifecycles',
etc.
One part of that redesign which I believe is not yet fully specified is
how to organize methods for backwards induction at each frame.
See also #495 https://github.com/econ-ark/HARK/issues/495 for
background discussion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/pull/835#issuecomment-701442336, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFMAGWNVOPNDLAO2COLSINA2HANCNFSM4RL3KH7A
.

I just verified: It's a one line change. He fixed an indexing issue that came up when timeFlip() was removed from the code.  The model Mateo is working on will use this feature, but I don't think we need a PR where 5 characters are changed to fix an index, and then 2000 lines of code are added to show that this is correct.

Sounds like you're the reviewer now, @mnwhite .
I defer to you.


tuple to struct event variants

This pull request changes the pallet Events variants from tuples to structs with named fields.
Part implementation for #9903, #9993, #10184 & #10206
Pallets with changes

recovery
session

polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

bot merge


Bump 0.2.dev0 version

Reopening this, not sure why the actions were not triggered the first time.


deployment succesful but not able to access code - Invalid request

Hi, I deployed the quicjk start but6 when I clicked on the Repo URL, authentication dialogbox displayed and I was not sure which login to use then I used my aws root login and password as it is with this login I triggered the deployment bu I get
"Invalid request"
Also, once the app is deployed, how can we access the app as a user, ehere is the url for the application?
Thanks

Hello! The repo URL shown in the output parameters is meant for the cloning the repository to a local development machine rather than one meant for browsing via a Web browser. There are multiple ways in which you can configure access control to a CodeCommit repo: for more information on how you can configure authentication for CodeCommit, please see https://docs.aws.amazon.com/codecommit/latest/userguide/auth-and-access-control.html. I will also ensure the QuickStart guide  is updated to include the above documentation URL.
The application itself is accessible using the URL presented by the LoadBalancerUrl output parameter; this is the URL to an application load balancer that uses the Fargate service as a load balancing target.


Release timeline

Question
Is there a rough timeline for a first release of this provider available?
Any link or just a rough quarter would be nice to know. :)

Hi @phumberdroz, thanks for the question!
Unfortunately it's still a bit early for us to provide any timeline for a first release. We will, however, definitely keep everyone updated when we have any dates or other news about the provider.

Hi Pierre, our rough estimate to ship the first version (v0.1.0) by the end of the year.

The terraform provider has been released and is available in the Terraform Registry as 0.1.0-beta: https://registry.terraform.io/providers/elastic/ec/latest


Exception in C2dTextureTintManager#gc when aggressive = true

The offending line is: https://github.com/rdkcentral/Lightning/blob/b17dedcdeea6301f2ffe4e95d5290be071a20be0/src/renderer/c2d/C2dTextureTintManager.mjs#L128
as clear() is an undefined function on textures. I believe this may be a typo and this line should actually be cache.clear().

Hi @Moussa
you are correct, thanks for contributing.
Best regards

Resolved by #246


Update sbt-mdoc to 2.2.16

Updates org.scalameta:sbt-mdoc from 2.2.2 to 2.2.16.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #179.


Private maven repo in generated compose project

Describe the bug
A small thing, I noticed settings.gradle.kts contains:
        maven("file:///Users/mike/Hydraulic/product/open/build/repo")

To Reproduce
Run ./conveyor-2.1/bin/conveyor generate compose --rdns=test
Expected behavior
No local paths are present in settings.gradle.kts

D'oh! Thanks for letting us know. This will be fixed in the next bugfix release.

By the way - it's safe to just delete this line. It doesn't have to be changed to anything else.


Refreshing Online List

Even though a player logouts from the server it still shows that he is still online on the page who is online. I've checked the player_online table and it works correctly.
I noticed if I login on player name "Test" logout it says on website "Test" is online. But when I login on "Test2" and logout it now ways Test2 is online. "Test" is does no longer show as online, but instead "Test2"
I've also set the cache to
[Cache]
Default = "5m"
Purge = "1m"

This issue was tested (with MiterTinkz) and everything worked fine.


OCM-10263 | ci: fix id:57094

`$ ginkgo --focus 57094 tests/e2e/
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
Ginkgo CLI Version:
2.14.0
Mismatched package versions found:
2.17.1 used by e2e
Ginkgo will continue to attempt to run but you may see errors (including flag
parsing errors) and should either update your go.mod or your version of the
Ginkgo CLI to match.
To install the matching version of the CLI run
go install github.com/onsi/ginkgo/v2/ginkgo
from a path that contains a go.mod file.  Alternatively you can use
go run github.com/onsi/ginkgo/v2/ginkgo
from a path that contains a go.mod file to invoke the matching version of the
Ginkgo CLI.
If you are attempting to test multiple packages that each have a different
version of the Ginkgo library with a single Ginkgo CLI that is currently
unsupported.
Running Suite: ROSA CLI e2e tests suite - /home/aaraj/ocm-forked-code/rosa/tests/e2e
Random Seed:<PHONE_NUMBER>
Will run 1 of 168 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 168 Specs in 167.446 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 167 Skipped
PASS
Ginkgo ran 1 suite in 3m3.617026034s
Test Suite Passed
`

/lgtm


One-directional sync?

Howdy :wave:
I use tools such as bugwarrior with my install of task, and such, prefer to use task as a sort of overview as well as a todo list. Queries such as task +DUETODAY are never too far behind in my shell history :smile:
Here's my question:
I have a bazillion google calendars to keep track of. I don't want to edit all of these (aside from maybe 1 or 2). Can I just pull in events from calendars?
Cheers!
kayak

Hi, sorry for the late reply,
Currently one-directional sync isn't possible, I'm afraid.
I'll keep this issue around though in case I find some time to work on it

No worries :+1:

Closing this since one-way sync is still not not in scope for this tool


Default values for readiness criteria and height after grazing for stubble height is not showing -- should be to one decimal

@LisaMoore1 once there issues are resolved I would recommend actually closing them to signify that.

I think @LisaMoore1 is trying to keep track of what is in production via whether or not it is closed.  I think she's moved them to done in zenhub,  but we could label them 'ready for prod' if that makes more sense.

But all the changes in dev are eventually going to be in production anyway, since it's just a promotion of the branch. Regardless if it's deployed or not, once an issue is resolved, it's no longer an issue. I think tracking what changes are in prod should be a different process, eg. using releases.

A few things here (I just did some learning):

I need to move things out of sprint pipeline as I test so I can see what I've looked at
burndown for a milestone is based on issues being closed (no burndown until they are closed)
in general burndowns should show when within the sprint the work is being done -- over time we could identify if we have a big drop early or late --> we should be aiming for steady burndown which would be mean moving cards to closed when they pass testing but haven't necessarily been deployed to prod
I'm OK with marking something as "closed" so long as there is certainty that those things will be moved to prod
ideally we are able to complete a "chunk of work" (i.e. a user story) in a sprint so that we can do a release into prod at the end of the sprint
I'm not familiar with the deploy process but if I can have confidence that if I mark something as closed it will actually end up in prod I'm pumped to hit closed on them when they are working (that is where the fun is at)

Make sense?

I hear you.  I opted to go this route for now because it makes it very easy for non devs to see which issue fixes and changes have made it in to the field.  I'm flexible on how stuff gets tracked on here we just have to teach Lisa how to easily see what is in the field or not, be it releases or whatever.

@LisaMoore1 and @micheal-w-wells I think you both raise good points. My understanding of the deploy pipeline is that once we merge a change into the dev branch, it's going to eventually end up in production, ie. we can't pick and choose which pull requests end up in prod. Because of that, fixes for any issues are guaranteed to make it into production. The burndown graph was actually what made me realize none of the issues were closed, since it only knows an issue is resolved if it's closed. For us, closing issues when they are fixed is the ideal workflow.
How we know when to promote dev to prod I'm not sure about. I imagine it will coincide with an epic or user story being finished.

@micheal-w-wells @calebissharp Since this is a grand experiment of a sprint why don't we close the ones that I've already tested (and will yet test) for this sprint and until I'm able to learn about the merging etc. and we have a more concrete release plan I will trust it will happen.
As for releases I'm strongly in favour of releasing when  a user story is complete.

It's a plan. If they pass testing I'll close them. In a week or two we can see if that is working for us or not.

Sounds good!


Loop() is not goroutine safe

Package tests run a second connection with go irccon.Loop(), like here.
I've been using this code in my own libraries with -race and discovered a bunch of race conditions, such as github.com/thoj/go-ircevent.(*Connection).RunCallbacks() and github.com/thoj/go-ircevent.(*Connection).AddCallback()
These issues seem like they could easily be solved by adding some mutexes around unsafe operations like callback map access. I may have the time to fix this in the next few weeks, but I'm not sure.

Work in progress. Latest change will fix some of the issues. See da78ed515c0f0833e7a92c7cc52898176198e2c1

Most races has been fixed.


MinimumFileAgeDays Discrepancy

This is conflicting information regarding MinimumFileAgeDays which should be rectified. I assume the correct information is based on the created time especially since dedup supports files in use if enabled for the volume.
Per this site: https://docs.microsoft.com/en-us/windows-server/storage/data-deduplication/advanced-settings

The Default and HyperV usage types set this value to 3 to maximize performance on hot or recently created files.

While on this page it says:

-MinimumFileAgeDays
Specifies a number of days. The deduplication engine optimizes files that users have not accessed in the number of days that you specify. If the last access time is not available, then the deduplication engine uses the last modified time.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53037750-a381-fc0c-b36f-8a6ab2e148bf
Version Independent ID: f417a83e-dbea-2d77-b753-23e665546b8b
Content: Set-DedupVolume (deduplication)
Content Source: docset/windows/deduplication/Set-DedupVolume.md
Product: w10
Technology: powershell-windows
GitHub Login: @andreabarr
Microsoft Alias: v-anbarr

@dyehya Hello,
Thank you for trying to make MicrosoftDocs a better place.
The link that you have provided says that the default value for Default and Hyper-V usage types is 3. You can still override this setting by specifying the MinimumFileAgeDays parameter. I do not see any conflict between the two. Probably it is useful to have this information in the parameter description as well.

Thank you both for the updates.
Can we get confirmation from the Product Group/Team on whether or not the deduplication engine uses the last access time or last modified time at all?
The updated documentation now makes it sound like it ONLY goes by created date but I do not believe the Deduplication Engine is exclusively using the created date.

Hello, @dyehya It seems that your follow-up question can best be answered via PowerShell Community Links
Since the associated PR has been merged and the content has been updated according to your feedback, the issue is being closed because the issues section of this repository is used to address content related issues.
Thank you.

I am concerned regarding the content because it still doesn't add up is my point.

The Default and HyperV usage types set this value to 3 to maximize performance on hot or recently created files. You may want to modify this if you want Data Deduplication to be more aggressive or if you do not care about the extra latency associated with deduplication.

Logic dictates that if:

MinimumFileAgeDays | Number of days after the file is created before the file is considered to be in-policy for optimization.

Then how can the documentation state that it is the number of days after the file is created only when it does use the access time if it is available. The documentation is wrong... just because you updated it doesn't make it consistent or correct. I suggested the Product Group because they would be the definitive expert on the system vs a user like myself but the logic issue is obvious here.
Also, it specifically mentions if the data is hot OR recently created. Therefore it will not optimize if it is was recently accessed or modified (depending on how the engine works).
I know how to work Powershell. I am not asking for support. I am asking you to correct the documentation and the relevant pages so they are consistent and correct.

I do want to also clarify that I do not think documenting that it only works based on the created date was the correct "Correction" to the documentation in case that was not clear above because the dedup engine will not dedup if the data has been accessed or modified recently which is the intended behavior and the documentation should reflect this in all places.

This repository is for PowerShell core documentation. You seem to be looking for support, which we can't provide here.
I suggest you try posting your issue with context in one of the available community support forums.