[BUG] TypeError not callable : rich.print_exception

Hello !
Describe the bug
I use print_exception with uvicorn and print_exception got an exception "Field not Callable", I patched uvicorn/protocols/http/httptools_impl.py:404 this way
        except BaseException as exc:
            msg = "Exception in ASGI application\n"
            # PATCH start
            from rich.console import Console

            self.console = Console()
            self.console.print_exception(extra_lines=5, show_locals=True)
            # PATCH end
            self.logger.error(msg, exc_info=exc)
            if not self.response_started:
                await self.send_500_response()
            else:
                self.transport.close()

The exception which occured (the first part is the error in my side ; the second is the error in rich, both printed by uvicorn)
future: <Task finished name='Task-5' coro=<RequestResponseCycle.run_asgi() done, defined at .venv/lib/python3.9/site-packages/uvicorn/protocols/http/httptools_impl.py:396> exception=TypeError("'Field' object is not callable")>
Traceback (most recent call last):
  File ".venv/lib/python3.9/site-packages/uvicorn/protocols/http/httptools_impl.py", line 398, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File ".venv/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in __call__
    return await self.app(scope, receive, send)
  File ".venv/lib/python3.9/site-packages/fastapi/applications.py", line 199, in __call__
    await super().__call__(scope, receive, send)
  File ".venv/lib/python3.9/site-packages/starlette/applications.py", line 112, in __call__
    await self.middleware_stack(scope, receive, send)
  File ".venv/lib/python3.9/site-packages/starlette/middleware/errors.py", line 181, in __call__
    raise exc from None
  File ".venv/lib/python3.9/site-packages/starlette/middleware/errors.py", line 159, in __call__
    await self.app(scope, receive, _send)
  File ".venv/lib/python3.9/site-packages/starlette/exceptions.py", line 82, in __call__
    raise exc from None
  File ".venv/lib/python3.9/site-packages/starlette/exceptions.py", line 71, in __call__
    await self.app(scope, receive, sender)
  File ".venv/lib/python3.9/site-packages/starlette/routing.py", line 580, in __call__
    await route.handle(scope, receive, send)
  File ".venv/lib/python3.9/site-packages/starlette/routing.py", line 241, in handle
    await self.app(scope, receive, send)
  File ".venv/lib/python3.9/site-packages/starlette/routing.py", line 52, in app
    response = await func(request)
  File ".venv/lib/python3.9/site-packages/fastapi/routing.py", line 201, in app
    raw_response = await run_endpoint_function(
  File ".venv/lib/python3.9/site-packages/fastapi/routing.py", line 148, in run_endpoint_function
    return await dependant.call(**values)
  File "./openapi_server/utils/routes.py", line 26, in filter_fields
    response = await func(*args, **kwargs)
  File "./openapi_server/apis/geographic_address_api.py", line 74, in list_geographic_address
    return await handler.objects()
  File "business/business/handlers/handler.py", line 39, in objects
    query_set = await self.query_set.limit(self.limit)
  File ".venv/lib/python3.9/site-packages/tortoise/queryset.py", line 900, in __await__
    self._make_query()
  File ".venv/lib/python3.9/site-packages/tortoise/queryset.py", line 862, in _make_query
    self.resolve_filters(
  File ".venv/lib/python3.9/site-packages/tortoise/queryset.py", line 129, in resolve_filters
    modifier &= node.resolve(model, annotations, custom_filters, model._meta.basetable)
  File ".venv/lib/python3.9/site-packages/tortoise/query_utils.py", line 390, in resolve
    return self._resolve_kwargs(model, table)
  File ".venv/lib/python3.9/site-packages/tortoise/query_utils.py", line 344, in _resolve_kwargs
    key, value = self._get_actual_filter_params(model, raw_key, raw_value)
  File ".venv/lib/python3.9/site-packages/tortoise/query_utils.py", line 338, in _get_actual_filter_params
    raise FieldError(f"Unknown filter param '{key}'. Allowed base values are {allowed}")
tortoise.exceptions.FieldError: Unknown filter param 'buildings__id'. Allowed base values are ['X', 'Y', 'buildings_FR', 'coverage_infra_ftto_FR', 'id', 'numéro', 'répétiteur', 'voie', 'voie_id']

Traceback (most recent call last):
  File ".venv/lib/python3.9/site-packages/uvicorn/protocols/http/httptools_impl.py", line 404, in run_asgi
    self.console.print_exception(extra_lines=5, show_locals=True)
  File ".venv/lib/python3.9/site-packages/rich/console.py", line 1719, in print_exception
    traceback = Traceback(
  File ".venv/lib/python3.9/site-packages/rich/traceback.py", line 223, in __init__
    trace = self.extract(
  File ".venv/lib/python3.9/site-packages/rich/traceback.py", line 350, in extract
    locals={
  File ".venv/lib/python3.9/site-packages/rich/traceback.py", line 351, in <dictcomp>
    key: pretty.traverse(
  File ".venv/lib/python3.9/site-packages/rich/pretty.py", line 686, in traverse
    node = _traverse(_object, root=True)
  File ".venv/lib/python3.9/site-packages/rich/pretty.py", line 672, in _traverse
    child_node = _traverse(child)
  File ".venv/lib/python3.9/site-packages/rich/pretty.py", line 509, in _traverse
    args = list(iter_rich_args(obj.__rich_repr__()))
TypeError: 'Field' object is not callable

To Reproduce
It is complex to reproduce it :/ Maybe I could reproduce it, it seems to come from tortoise orm, I will try later.
Platform
Linux
Diagnose
I quickly fixed the problem (but it seems to reduce the quantity of details) by patching rich this way (rich/pretty.py:509) :
            # PATCH start
            # args = list(iter_rich_args(obj.__rich_repr__()))  # replaced line
            try:
                args = list(iter_rich_args(obj.__rich_repr__()))
            except TypeError:
                args = []
                # print("FAILLED")
            # PATCH end

I'm guessing that Tortoise ORM does some magic which breaks the pretty printing. It appears as though __rich_repr__ exists and is not callable. Have you added a __rich_repr__ callable anywhere?

No, I have not used "rich_repr" :
grep -r "__rich_repr__" .
./.venv/lib/python3.9/site-packages/rich/layout.py: ...
./.venv/lib/python3.9/site-packages/rich/color.py: ...
...

Then might it be a __getattr__ or __getattribute from Tortoise ORM ?

To reproduce the error :
from rich.console import Console

console = Console()

class Field:
    def __init__(self, name):
        self.name = name

class Table:
    def __getattr__(self, name):
        return Field(name)

if __name__ == "__main__":
    try:
        t = Table()
        raise BaseException("Whatever")
    except BaseException:
        console.print_exception(extra_lines=5, show_locals=True)

Please try v10.10.0 Fixes your example code.

Perfect ! I tried, it works smooth, thx :)


New timeout prompt

Fixes 78804070

appears after 17 minutes
puts focus on alert UI when it appears
extend timeout now works when user chooses to extend
redirects to /abandon after a further 3 minutes if time not extended
does not change interface
timeout prompt moved to MOJ Elements for reuse and included via Bower

Assuming handlebars is a gem here, would it not make sense to just drop it in the Gemfile?

Handlebars is a front-end asset which is included with bower automatically as it's a dependancy of TimeoutPrompt.

This looks ready to :ship: to me. Do @nicolekobilansky or @leighmoney need to review the prompt?

Correct, we need @leighmoney to review the explanation of what happens when it "times out".
See https://github.com/ministryofjustice/prison-visits/pull/147/files#diff-6

And @leighmoney, while you're looking please review the content of timeout and refer to the Civil Claims timeout.

This looks like it's ready to :ship: now. I shall merge on Monday!


Release Prep

Prepare for the v1 release. Complete all documentation and licensing related changes and also any changes needed to upload to Maven Central.

Module prep is complete, pending repo activation in OSSRH for deployment to Maven Central. JIRA ticket OSSRH-13676 has been opened for it.

OSSRH setup is complete, deployed a snapshot to verify and subsequently staged and promoted v1.0.0 release which should be sync'd to Central shortly.


add basic testing functionality

@svenwillger
as discussed via webex, implement a few rules in snaketests.smk that call (= test working state) all functions in the pyutils module. If appropriate, add a very simple reference container in the refcon repo that would results in a tiny reference container with some mock file to also test the functions related to refcon handling.
I created the add-testing branch for this functionality.

A workflow was created with rules that check functionality of the functions in 02_pyutils.smk.
New functions to get the username and the timestamp were added to 02_pyutils.smk.
The rule "dump_config" from the branch add-config_dump was also added to this branch.
Folders and files that are required for the tests were added:

the folder test_folder with the required files for the tests was added to the main folder
a scripts folder was added to /workflow with a test script
"test_container.yaml" was added to config to point to the test container

The whole /workflow folder was checked and modified by snakefmt to standardize the code.
The commit message is "add testing workflow with required files" and the hash is b493662.


Added a suggestion of solution with a simple for loop

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

xxx

hi

hh

nh

@thecodingaviator I made the changes you suggested.  Please merge if everything is good now.
Thanks.

Congrats @tiagosalema on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Drone: centralize location of 'generate' function

Soon it will be convenient to modify Drone tests by adding new operating systems / compilers.
Customized functions.star: https://github.com/cppalliance/ci-automation/blob/master/ci/drone/functions.star.

Nice


New Alliance for ACH?

Called and left a message. We have a chunk of escrow there already.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12602260-new-alliance-for-ach?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

"We don't offer that here."


Make Timecop an npm module

This change was very minimal, mostly changes to the package.json since timecop.js is already exports properly.  The build task bumps versions.
To test you can either npm install from my master branch or just require('./timecop') in node in the root of the project.
All test pass

+1


Unrecognizable Font in the tabs of a Table Datagrid view

Description
Hello,
I find that the Tabs' text of the Table Data grid view, gets unrecognizable, as soon as I changed the font style of my Computer System.
The below picture screen shot can reveal the real scenario,,,

Thanks you
DBeaver Version
Community Edition Version <IP_ADDRESS>412011650
Operating System
Windows 11 Version 24H2 (OS Build 26100.2314)
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Thanks for the bug report.


Add policy hash to UpsertPolicy response

Description of change
Drive-by: Simplify Upsert to do an unconditional Put, moving the
"avoid accidental overwrite" check to aperturectl itself.
This prepares the controller for fluxninja/cloud#11517.
Checklist

[ ] Tested in playground or other setup
[ ] Screenshot (Grafana) from playground added to PR for 15+ minute run
[x] Breaking changes (kinda: old aperturectl with new controller would behave as if --force was assumed. The additional return value shouldn't be breaking).

Summary by CodeRabbit

New Feature: Updated the UpsertPolicy function in both PolicyService and Controller services to return a new message type UpsertPolicyResponse instead of google.protobuf.Empty. This change provides more detailed responses from these functions.
Refactor: Simplified error handling and removed redundant code in createAndApplyPolicy function, improving readability and maintainability.
Bug Fix: Added logic to check for existing policies before updating in UpdatePolicyUsingAPI function, preventing unnecessary updates.
Chore: Removed unused import statements and deprecated fields, enhancing code cleanliness.

Aperture


Cannot send button template after lastest whatsapp update

Send button only can send to my number, how to solve it? thanks

Please provide request payload you're using

Like this...

Issue is found on Ios Devices.

but when i use dependencies "@adiwajshing/baileys": "^4.2.0" it works. But when the dependencies upgraded to 4.3.0 that's show bug cannot use button to the other people even though in android devices

Yes, i have also checked issue is coming on android devices as well.

ok im waiting for your updates. Thanks a lot

Any update?

Still doesn't work...

Closing this due to inactivity


Callback api Web same tab

Hello I'm using the api web url to use SumUp, it works good but when fail/success it returns the url to a new browser tab... Is there any way to callback in the same web tab without opening a new one?
Thanks.

Hello, did you find a solution about that, I have the same problem ? Thank you :)


Builds fail with "no such device or address"

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description

All of a sudden podman stopped building images, when it tries to commit the first build step, it always fails with no such device or address:
Steps to reproduce the issue:

I don't how to get podman into this state

Describe the results you received:
DEBU[0072] COMMIT
DEBU[0072] parsed reference into "[overlay@/home/jreimann/.local/share/containers/storage+/run/user/XXX/containers:overlay.mount_program=/usr/bin/fuse-overlayfs]docker.io/library/808b6b1ad1d9de6f7d21a816efa7d62de5b50a6fe15690813aa168d8dde6de77-tmp:latest"
DEBU[0072] committing image with reference "containers-storage:[overlay@/home/jreimann/.local/share/containers/storage+/run/user/XXX/containers:overlay.mount_program=/usr/bin/fuse-overlayfs]docker.io/library/808b6b1ad1d9de6f7d21a816efa7d62de5b50a6fe15690813aa168d8dde6de77-tmp:latest" is allowed by policy
DEBU[0072] parsed reference into "[overlay@/home/jreimann/.local/share/containers/storage+/run/user/XXX/containers:overlay.mount_program=/usr/bin/fuse-overlayfs]@9382431041983a6d9bc305bddbe238b262d8d5a888667c8b0075e0261c44077d"
DEBU[0072] base image "9382431041983a6d9bc305bddbe238b262d8d5a888667c8b0075e0261c44077d" is already present in local storage, no need to copy its layers
DEBU[0072] layer list: ["fc86ad79496a0932dd56764ae4e00954f6a760d84a27967bd61a41c6ce0bc59c" "91ede8b45c8090bf46f464486216e90182dcbaa6fdb1060ea3020da416156d3d"]
DEBU[0072] using "/var/tmp/buildah869835859" to hold temporary data
DEBU[0072] compressing layer "91ede8b45c8090bf46f464486216e90182dcbaa6fdb1060ea3020da416156d3d" with gzip
DEBU[0072] overlay: mount_data=ro,lowerdir=/home/jreimann/.local/share/containers/storage/overlay/fc86ad79496a0932dd56764ae4e00954f6a760d84a27967bd61a41c6ce0bc59c/empty,upperdir=/home/jreimann/.local/share/containers/storage/overlay/fc86ad79496a0932dd56764ae4e00954f6a760d84a27967bd61a41c6ce0bc59c/diff,workdir=/home/jreimann/.local/share/containers/storage/overlay/fc86ad79496a0932dd56764ae4e00954f6a760d84a27967bd61a41c6ce0bc59c/work,context="system_u:object_r:container_file_t:s0:c338,c515"
Error: error committing container for step {Env:[DISTTAG=f31container FGC=f31 container=oci  PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:run Args:[microdnf -y install java-11-openjdk-headless] Flags:[] Attrs:map[] Message:RUN microdnf -y install java-11-openjdk-headless Original:RUN microdnf -y install java-11-openjdk-headless}: error copying layers and metadata for container "015c297dc28b5c6d29e323a257660177a3576cbc1444e10819afd294e0dbf8e7": Error initializing source containers-storage:fedora-minimal-working-container: error extracting layer "91ede8b45c8090bf46f464486216e90182dcbaa6fdb1060ea3020da416156d3d": no such device or address

Describe the results you expected:
A working build, as before.
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
$ podman version
Version:            1.8.0
RemoteAPI Version:  1
Go Version:         go1.13.6
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.13.6
  podman version: 1.8.0
host:
  BuildahVersion: 1.13.1
  CgroupVersion: v2
  Conmon:
    package: conmon-2.0.10-2.fc31.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.10, commit: 6b526d9888abb86b9e7de7dfdeec0da98ad32ee0'
  Distribution:
    distribution: fedora
    version: "31"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 110147
      size: 1
    - container_id: 1
      host_id: 120000
      size: 165536
    uidmap:
    - container_id: 0
      host_id: 110147
      size: 1
    - container_id: 1
      host_id: 120000
      size: 165536
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>8
  OCIRuntime:
    name: crun
    package: crun-<IP_ADDRESS>-1.fc31.x86_64
    path: /usr/bin/crun
    version: |-
      crun version <IP_ADDRESS>
      commit: cd7cea7114db5f6aa35fbb69fa307c19c2728a31
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  SwapFree:<PHONE_NUMBER>0
  SwapTotal:<PHONE_NUMBER>0
  arch: amd64
  cpus: 8
  eventlogger: journald
  hostname: flunder
  kernel: 5.5.7-200.fc31.x86_64
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31.x86_64
    Version: |-
      slirp4netns version 0.4.0-beta.3+dev
      commit: bbd6f25c70d5db2a1cd3bfb0416a8db99a75ed7e
  uptime: 101h 0m 55.65s (Approximately 4.21 days)
registries:
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - quay.io
store:
  ConfigFile: /home/jreimann/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-0.7.5-2.fc31.x86_64
      Version: |-
        fusermount3 version: 3.6.2
        fuse-overlayfs: version 0.7.5
        FUSE library version 3.6.2
        using FUSE kernel interface version 7.29
  GraphRoot: /home/jreimann/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 1
  RunRoot: /run/user/110147/containers
  VolumePath: /home/jreimann/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.8.0-2.fc31.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
physical

Could you try the podman release that is in updates-testing?

Also make sure you have the latest crun and fuse-overlayfs

I just figured out, that it doesn't seem to be an issue with my machine, but with the base image:
It fails with FROM registry.fedoraproject.org/fedora-minimal:31, but works when I change back to registry.access.redhat.com/ubi8/ubi-minimal.

Could you try the podman release that is in updates-testing?

If you can tell me "how", sure.

dnf -y update podman --enablerepo=updates-testing

So here is a bit more information:

When I use a RUN touch foo step, it seems to work. When I use my original command RUN microdnf -y install java-11-openjdk-headless it fails (but works when using the UBI image, however that might also indicate some issue with the RPM or microdnf)

Next I installed podman from testing:
$ rpm -q podman && podman --version
podman-1.8.0-2.fc31.x86_64
podman version 1.8.0

I see no change with the updated version:
STEP 3: COMMIT
Error: error committing container for step {Env:[DISTTAG=f31container FGC=f31 container=oci  PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:run Args:[microdnf -y install java-11-openjdk-headless] Flags:[] Attrs:map[] Message:RUN microdnf -y install java-11-openjdk-headless Original:RUN microdnf -y install java-11-openjdk-headless}: error copying layers and metadata for container "873b04708bff2da664bfad51e10a556b5944feddb14adaa43a1159f080270c96": Error initializing source containers-storage:fedora-minimal-working-container: error extracting layer "a5e18415fc61888a750929d9a94ba829a062d99cd84e58f36adf34f3dacd0ac5": no such device or address

@giuseppe Any ideas?

Is this the same issue as https://github.com/containers/buildah/issues/2161?

For the record, I see this problem when building from registry.fedoraproject.org/fedora:32 or registry.fedoraproject.org/fedora:rawhide images but not with registry.fedoraproject.org/fedora:31, registry.fedoraproject.org/fedora:30, or registry.fedoraproject.org/fedora:29.

@adelton it may be the same, but I'd like to keep this open until we fully determine that.  Sure looks like it though.

@adelton @TomSweeneyRedHat Still looking at this or should we close?

I do not experience any issues with rootless podman-1.8.2-2.fc31.x86_64.

I can no longer reproduce this issue. Maybe it was my update to podman 1.8.2, or maybe it was due to some update in the fedora images, I can't tell. Now it works for me.


A new action on quick open to browse files

Problem to solve:

if I put something in "files.exclude", the the excluded files are not revealed in quick open. This is unfortunate somethimes. For example I often put .gitignore in the list and it is a pain to type code .gitignore in the terminal to edit the file.

Suggestion:

add a new command . in the quick open to navigate from the current project root. the behavior is like this,

when typing ., the dropdown list shows the root name.
In the mult-root case, it shows a list of roots to select.
when typing ./, list all files and folders in the dropdown list. and filter them when typing more, the list content should just like the list shown in zsh after pressing a tab. Note that this list should be complete and ignore the files.exclude or .gitignore settings. This should also support standard wildcards. When the match is unique, it is good to autocomplete as in the address bar in chrome.
In the multi-root case, it indicate the selected root in some way. For example, use a badge at the right side of quick open bar.
In addition, we can support ../ for open files outside the root folder.
Don't know whether the following is useful, but maybe we can support absolute path using / as action name.

Is anyone doing this right now? I would like to try this. Can I get any help?

I do not think core devs will do this in near future. It has no assignee and do not in backlog.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

 If that's the case, attach a proper wont fix-like label would be great. Otherwise, the closing action is confusing, I thought this do not fit into

close obsolete/fixed issues

in https://github.com/Microsoft/vscode/issues/38209.


[Issue]: 23.11.1 Not working with HIP ROCm [Windows]

Problem Description
Installed AMD-Software-PRO-Edition-23.Q3-Win10-Win11-For-HIP.exe.
Downloaded hashcat 6.2.6, tried hashcat.exe, and it says:
hiprtcCompileProgram is missing from HIPRTC shared library.
Tried also blender cycles on HIP-RT, and it also drops to the OpenCL, (CPU load is high, GPU is 0%)
Operating System
Windows 10
CPU
3700x
GPU
7800xt
ROCm Version
5.5
ROCm Component
No response
Steps to Reproduce
Install Windows 10.
Install 23.11.1.
Install HIP SDK.
Try to use ROCm in any application.
Output of /opt/rocm/bin/rocminfo --support
I don't have this on windows. Is it even supposed to work on windows?

I have managed to deal with blender, GPU usage is still pretty low in rendering though, and hashcat is still not working with ROCm, only OpenCL.

Any updates on here?

@108806 Can you please try the latest HIP SDK 5.7.1 (https://www.amd.com/en/developer/resources/rocm-hub/hip-sdk.html)? Thanks!

Hi @108806, at this time, there are currently no plans for ROCm to support hashcat. Please open a new issue if you are still experiencing low GPU utilization on Blender with HIP SDK 5.7.1. Thanks!


IMAP Support

From<EMAIL_ADDRESS>on November 06, 2013 09:33:04
Create an IMAP driver for Saturn Mail.
Original issue: http://code.google.com/p/foam-framework/issues/detail?id=47

This doesn't seem like it was ever done, but Saturn Mail is orphaned. Assigning to @kgrgreer to make the call on this.

Obsolete.


Routing url miss match with the backend

Currently, I'm trying to route to my local openrouteservice by changing the Gruntfile.js. Seems like the routing parameters are miss-matching with the backend URL.

app request

curl http://localhost:8082/v2/directions\?attributes\=detourfactor%7Cpercentage\&coordinates\=116.529236,39.967122%7C116.554298,39.930801\&elevation\=true\&extra_info\=steepness%7Cwaytype%7Csurface\&geometry\=true\&geometry_format\=geojson\&instructions\=true\&instructions_format\=html\&language\=en-US\&preference\=fastest\&profile\=driving-car\&units\=m

However, the backend require the request to have the profile in the endpoint. Also the starting and ending point parameter are wrong.
Am I missing something?

Greetings @pingrunhuang,
this application is still running the old version of the API. Can you please remove the v2 and try again?
http://localhost:8082/ors/routes?...

Not sure which version you are running on for backend ors. For me, I see  here indicating the endpoint seems to not what you claimed.
I am running the master version, please tell me if I am wrong.

That is correct and what I mean above is that the openrouteservice-app client does not consume this version of the API which we call v2, it uses one previous version, please select v1 here https://openrouteservice.org/dev/#/api-docs/directions

But I want the openrouteservice-app to consume my local backend which is using the v2 version. And I don't see any endpoint for v1 exists in the source code of ors backend, how come the app client could visit the v1 endpoint?

@pingrunhuang openrouteservice-app does not consume the v2 backend, as already stated above, it uses the previously implemented API using tomcat only without spring -> https://github.com/GIScience/openrouteservice/tree/master/openrouteservice/src/main/java/heigit/ors/services/routing the API documentation I posted above and to run ORS locally please use these instructions: https://github.com/GIScience/openrouteservice


Fix issue with k8s.io/docs/concepts/cluster-administration/cloud-prov…

This fixes #20695 .
At Line 398,
The link for "Planning your cluster and worker node setup" might seems to be changed from cloud.ibm.com.
The link has to be changed as "https://cloud.ibm.com/docs/containers?topic=containers-planning_worker_nodes".

/assign

Thanks @kitch for the technical review.  Great job @pjhwa! Thank you for your contribution!
/lgtm
/approve


Spellcheck fix

Describe the pull request:

[ ] Bug fix
[ ] Functional change
[ ] New feature
[ ] Code cleanup
[ ] Build system change
[x] Documentation change
[ ] Language translation

Pull request long description:

Make spellcheck action not fail
Changes made:

Addition to word list of new word
Typo fix

Thanks for reminder, fixing a PR (for sensitive-data-archive should be enough?)

Thanks for reminder, fixing a PR (for sensitive-data-archive should be enough?)

i think currently neic-sda gets the readme for the services from sda-pipeline, there is no hook to my knoweledge for the new repo sensitive-data-archive


Precedence of C# 8.0 switch expression

As discussed on StackOverflow, currently the documentation doesn't mention the precedence of the new switch expressions (which is between the categories multiplicative and range).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7eeac581-6235-2192-d909-e7fe3d21197f
Version Independent ID: 9d8e2a57-1c18-8cba-9bd4-eef546fe2dcb
Content: C# operators - C# reference
Content Source: docs/csharp/language-reference/operators/index.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

I agree we should update the docs with this information. I checked the spec on recursive patterns, and I don't see confirmation for that decision.
/cc @gafter to verify the suggestion above for precedence of the switch expression is correct.


Get a list of maintainers to suggest onboarding

Let's gather some data to provide a list of good candidates to contact directly with the onboarding.
Suggestions of the characteristics of such a candidate:

A lot of packages.
Packages are simple

no patching or just a few long-term ones
specfile is not complicates
...

Frequent releases.

TODO:

[ ] Prepare a script that outputs a list of maintainers to contact (ideally, with additional info so we understand the packages when contacting the person).
[ ] Share the list within a team.
[ ] Prepare the follow-up cards for the first N (let's say 5) maintainers to contact and add the card to the #2204 epic.

ping @xsuchy

I would suggest to also try to do a sync_release run on those packages to identify any potential issues in advance.

To be honest I meant trying it only locally and without a PR, I do that myself sometimes, of course it requires one to stop the execution before push.

To be honest I meant trying it only locally and without a PR, I do that myself sometimes, of course it requires one to stop the execution before push.

We should make a CLI option for that..;)

Quick'n'dirty script to check if a user uses Packit:
First save list of his packages to file /tmp/r and then:
for i in $(cat /tmp/r); do
  fedpkg clone --depth 1 $i
  ls $i/packit || echo "User use packit";
done


Bump version

This change is

@bors-servo: r+

:pushpin: Commit 68c6398 has been approved by jdm

:hourglass: Testing commit 68c63984caaf97e3b1b4ea82b02c56dd3c90348c with merge 00f3454a632f3053f9dbaaa4cec36448000e42b9...

:sunny: Test successful - status-travis
Approved by: jdm
Pushing 00f3454a632f3053f9dbaaa4cec36448000e42b9 to master...


[Bug]: API server - config list will output configuration in json dict

The current API call config.list will output the configuration as JSON by design. Provide endpoint that will output original Turbinia config file so it can be edited/re-used with Turbinia.

Not a bug. That API output by design is JSON format.  It seems you're asking for a feature that just lets you download the configuration file instead.

Understood, rewritten and labeled as enhancement.


Add generation of test data using the faker library

Perhaps a good feature would be to include generation of test data. Nobody likes creating test data and there are good libraries out there for it.
django-faker does this but it appears that it is no longer maintained and has no support for Python 3. Can be implemented using the faker library.
Example command: python manage.py fake api 15, would add 15 of each object in the api app.

This isn't drf-specific, so I've created a new repo for it django-seed.

Closing this. This isn't drf specific, so I've made a new package for it! See django-seed.


Data sequence visualization Error

When I ran to the Data sequence visualization under Getting Started, it reported an error as follows：
[Open3D WARNING] GLFW Error: X11: The DISPLAY environment variable is missing
[Open3D WARNING] Failed to initialize GLFW
Traceback (most recent call last):
File "v2xvit/visualization/vis_data_sequence.py", line 35, in
color_mode=opt.color_mode)
File "/home/coop/gyt/v2x-vit-main/v2xvit/visualization/vis_utils.py", line 571, in visualize_sequence_dataloader
vis.get_render_option().background_color = [0.05, 0.05, 0.05]
AttributeError: 'NoneType' object has no attribute 'background_color'
May I ask how to solve it？

I have the same problem with you,need a solution!

Do I think there is a problem with the installed library version? And I haven't installed any data visualization software either.

Please check this issue: https://github.com/DerrickXuNu/OpenCOOD/issues/74


401: Authentication error: invalid x-api-key

Hi there, not sure what I'm doing wrong or if I missed/skipped something in the setup, but Melty worked 1st couple of days after the extension installation into VS Code on my macOS, but now each time, I'm trying to use it gives me the following error:
Melty encountered an error: 401 {"type":"error","error":{"type":"authentication_error","message":"invalid x-api-key"}}. Try again?

I guess, I'd need to provide a new API key, but which one? And from where?
Maybe some instructions in README.md could help.

Melty uses Claude. You can set the API key by searching for melty.anthropicApiKey in the user preferences (cmd+, or ctrl+,)

Thank you for the instructions! It helped.
I had to sign up with Anthropic AI... I'd probably need to give up on Open AI.
Maybe, in the future it could be possible to switch the IA model/vendor.


Use git --depth and --branch flags to save space/time

By default, git will clone the full history of the Linux kernel.  Using the --depth and --branch flags allows us to clone exactly what we need, greatly saving both disk space and network I/O.
Signed-off-by: Karl Magdsick<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
This makes the instructions work much faster on slow internet connections.  My ISP seems to have started throttling the connection part way through cloning the full Linux kernel history.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b04d967 Use git --depth and --branch flags to save space/time

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign lucperkins after the PR has been reviewed.
You can assign the PR to them by writing /assign @lucperkins in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @kmag! It looks like this is your first PR to falcosecurity/falco-website 🎉

By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Please note that https://github.com/falcosecurity/falco-website/blob/master/CONTRIBUTING.md is currently 404'ing for me.  This link appears in the instructions commented below.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign lucperkins after the PR has been reviewed.
You can assign the PR to them by writing /assign @lucperkins in a comment when ready.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
* **[OWNERS](https://github.com/falcosecurity/falco-website/blob/master/OWNERS)**

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/check-dco

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b04d967 Use git --depth and --branch flags to save space/time

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/check-dco

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b04d967 Use git --depth and --branch flags to save space/time

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/check-dco

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b04d967 Use git --depth and --branch flags to save space/time

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/check-dco
Your contributing guide link is 404'ing.  I've registered my email address over at linuxfoundation.org and gone through the CNCF signoff process associated with this bot's documentation, but it seems I need to associate with something else over at linuxfoundation.org.  Is that correct?

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b04d967 Use git --depth and --branch flags to save space/time

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Karl Magdsick<EMAIL_ADDRESS>/check-dco

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b04d967 Use git --depth and --branch flags to save space/time

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


generate changelog from two repos

Hi,
At nanoFramework we are running a project that has several repos. Because the issues usually touch more than one project, we have them centralised at the Home repo. The usual development workflow occurs in the individual repos (PRs, merges, etc)
When generating the change log for one of the repos we would like to use the PRs and tags from the "self" repo and link to the issues that are on the "home" repo.
Is this something that can be accomplished with the current version?

Short answer: No.

hi, @josesimoes there was similar issues about this case.
Here is

a several difficulties with automatic parsing and merges issues from forked repos
logically the correct case to generate history since the fork.

But it could be possible to put previous history changelog part as prefix. here is very old and wanted feature.  #213 I believe that what you need and will help you. feel free to +1 it 👍

related with #472

and dup of #252

Hi @skywinder ! Thanks for looking into this. I believe it's more with #252 than with forked repos.
I've added my comment there as upvote.
BTW, great work you guys have done here! 👏


Restart API every 2 hours

Fixes #144
Replaces the cron for root on the cs*1 box.

This needs to be updated to use bastion hosts. Closing until I can get this done.


dynamic choice update

so i need to fetch some data from first option and using this data create choices

Afaik this isn't possible
You can update them after the command had been used, but not will it's become used
Is this roughly what you are looking for: issue on discord-api-docs

ok


Flutter 2 Null Safety support

Hey there,
Are there any plans to get null-safety support for this library?
I am using it as a crucial dependency in my project and due to the "connectivity" package still using old dependencies, it is causing bugs in running pub-update.
Thanks

Hi @TJMusiitwa
Thanks for being a user of the package. I will definitely push the null safety update soon.
Thanks

That would be great or if possible just updating the connectivity package to the earliest version that supports Flutter 2 and having it on a pre null-safe branch that I could use whilst you work behind the scenes would do me wonders.

Anyhow I should make this stable. I will have to update the docs and push it to latest version directly. I believe there are not many complex things involved.

Alright kindly push a quick comment here when all is well on your end and I will add it back to my project. You could say it is somewhat the glue holding my project together

@TJMusiitwa will push the connectivity pkg update, Null safety to be added later.

any plans to update package to null safety

Sure I planned to push the update tomorrow.

new version is released, v1.0.0


[QUESTION] Archive logs using Elasticsearch snapshots

We are currently using LME for about Windows servers in our infrastructure.
Due to disk space restrictions we can currently only keep two weeks of logs on the LME server.
We would like to achieve a log retention time of 90 days.
Therefore we would like to backup and archive our LME logs to another location (e.g. AWS S3).
We are thinking of using the Elasticsearch snapshot feature for it.
https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-snapshots.html
Has anyone looked into that before?
Any hints on where to configure this within LME?
Thank you.

Hi @kamouchka - glad to hear that you're using LME and it's being helpful to you.
Snapshot/Restore procedures differ based on the version of ELK that you're using. The build that is part of the main branch is a little more 'hands-on' (Elastic 7.3 includes a UI feature). We don't provide the means to enable this out of the box, but you can add in an environmental variable ('path.repo') and may need to add another volume mount point within the Elastic definition in the docker-compose file.
This may change in the future, but it is not part of the core LME product and therefore support, at this time.
Hope this helps

To snapshot directly to S3 you will also need to add in a plug-in to do so. Again, this is outside of the core LME project's scope so we won't be able to provide comment on how to achieve this, but Elastic's documentation will help:
https://www.elastic.co/guide/en/elasticsearch/plugins/master/repository-s3.html


"Invalid data returned" when loading index

Output of restic version
restic 0.7.1 (v0.7.1-62-g03e39b2)
compiled with go1.8 on darwin/amd64

This is the add-cache branch, by the way 👍
How did you run restic exactly?
date && sudo ./restic -r sftp://HOSTNAME/restic backup ~/Library/Mail/
What backend/server/service did you use?
SFTP on a machine of my own.
Expected behavior
Not seeing the below stack trace.
Actual behavior
enter password for repository:
load <index/4fc62d740f>: invalid data returned
github.com/restic/restic/internal/repository.(*Repository).LoadAndDecrypt
	src/github.com/restic/restic/internal/repository/repository.go:78
github.com/restic/restic/internal/repository.LoadIndexWithDecoder
	src/github.com/restic/restic/internal/repository/index.go:558
github.com/restic/restic/internal/repository.LoadIndex
	src/github.com/restic/restic/internal/repository/repository.go:436
github.com/restic/restic/internal/repository.(*Repository).LoadIndex.func1
	src/github.com/restic/restic/internal/repository/repository.go:378
github.com/restic/restic/internal/repository.ParallelWorkFuncParseID.func1
	src/github.com/restic/restic/internal/repository/parallel.go:74
github.com/restic/restic/internal/repository.FilesInParallel.func1
	src/github.com/restic/restic/internal/repository/parallel.go:39
runtime.goexit
	/usr/local/Cellar/go/1.8/libexec/src/runtime/asm_amd64.s:2197

Steps to reproduce the behavior
Probably to cut off the network connection to the backend at the very end of the backup (approximately at 99.95%) while the index is being uploaded. This is what happened to the backup run just before this one (the computer was put to sleep and then moved from the network), and is likely what caused the issue.
Do you have any idea what may have caused this?
Yes, the above? Are you not reading what I'm trying to tell you? I thought we already had this conversation, I thought we worked it through.. 😞 💔
Do you have an idea how to solve the issue?

It was however suggested by him that I delete the index file (or rather, the index file starting with that hash in the error message) manually, and doing so made it work again.

Run rebuild-index, it'll be cleaned up afterwards.

I get the same error  (Fatal: load <index/c9b29647e7>: invalid data returned) but rebuild-index is not helping... it returns the same error

I get the same error (Fatal: load <index/c9b29647e7>: invalid data returned) but rebuild-index is not helping... it returns the same error

I had the same error some minutes ago and rebuild-index did not work either. Clearing the restic cache in ~/.cache/restic and then running rebuild-index did the trick for me.

FYI cache dir in MacOS is in /Users/sheerun/Library/Caches/restic


issue #20 CLI operations improved

#20 So the main issue was:

Support for create operation: The writer function has been extended to include options for ephemeral and sequential nodes.
Bug when socket is closed by write function: The updated code now includes error handling for handling the case when the socket is closed by the write function.

Issues Resolved.

@shailendrasingh117 I'm confused - the code in the PR replaces the existing implementation, does not implement any handling of arguments, and it's very different from what has been posted in issue #20. Furthermore, you mentioned fixing a bug for socket closure - this one is also missing.

This PR will be closed due to a lack of responses to the code review and no activity.
If you want to continue working on this issue, please feel free to push changes and reopen it :)


Fix for ToBasePermission when rights attribute not set on custom action

When provisioning custom actions without any rights attribute an exception is raised (at basePermissionString.Split)

Thx Mårten, appreciated.


Fix issues with URLs that are problematic

This is a catchall ticket for any URLs I know are a bit weird.

Loading this URL just hangs forever, and eventually the command fails with no output: https://magazine.atavist.com/a-thousand-pounds-of-dynamite/

Loading this URL fails because you get an interstitial warning in WebKit telling you this is a potentially malicious website (and then the page just fails anyway): http://incl.ca/excluded-confoo-speaker-dinner-happened-made-feel/


Bulk Posts?

I've been poking around with this module for a couple of days now and one thing I can't determine is if you have the ability to post objects in bulk?
I.E. I need to post thousands of individual Hosts, and Networks objects and doing this 1 by 1 takes hour(s).
I skimmed through the few examples but didn't notice any bulk posts, I didn't notice any in the YouTube video either, and VS Code intellisense isn't pointing me to a solution.
Anyway, I love this module. Thank you for writing and maintaining it.

Oh hey, I found the Bulk method but it says it's specific to AccessRules :disappointed:

Alas, the Bulk API call is only related to AccessRules.  I don't know of
one that can bulk import other things.  (At least you have fmcapi to
loop through your host entries instead of doing it manually.)  :-)
On 3/24/20 12:47 PM, Chase Wright wrote:

Oh hey, I found the Bulk method but it says it's specific to
AccessRules 😞
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/daxm/fmcapi/issues/63#issuecomment-603440675, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZOMZ7CAH3HIDUHFACTR4DRJD55ZANCNFSM4LS4Z7UA.

I can't find a single example or any documentation for how to use the Bulk class for AccessRules...can you help me out here?

Bulk is a pretty "rough" tool.  You "add" JSON formatted strings into a list that then gets POST'ed to the FMC.  Alas, you need to know the format of the JSON.  Probably the best way to know that is to turn on debugging and do a GET of an AccessRule that matches what you are wanting to do in the BULK post.
I didn't write this function and I have had no need to use it.  However, I do think I know someone who works in TAC that has used it.  If you get stuck I can try to find their name again.

I figured it out enough that I can use it...
First create an AccessRules, then use show_json to get the JSON of the AccessRules object, use Bulk.add() to add that JSON, populate the url for Bulk, then post...
However, the "chunk" feature doesn't work...and the URL attribute is wack too
E.G.
acpId = "<some guid>"
accessRule1 = AccessRules(fmc=fmc, acp_id=acpId)
# Create Rule Here
accessRule2 = AccessRules(fmc=fmc, acp_id=acpId)
# Create Rule Here
bulkPost = Bulk(fmc=fmc,url=(accessRule1.URL + "?"))
bulkPost.add(json.loads(accessRule1.show_json))
bulkPost.add(json.loads(accessRule2.show_json))
bulkPost.post()

The url is the url to post the AccessRules to, which we know from the AccessRules object, but you have to add "?" it doesn't seem to get added automatically so it'll fail.
I was able to post using this however, if I tried to post more than 1,000 objects, it only posted the first 1,000 objects. The code appears to be chunking but it didn't work. So I split the object myself and did multiple Bulk posts, which is fine.
The Bulk class could use some TLC...


Clean start + modularization

So far, our changes to the JMT code have been oriented around getting a proof-of-concept integration with pd, and using that proof-of-concept to understand how the code works, how we can integrate it, and what we'd need to do to integrate other ecosystem components (e.g., IBC) into it. However, while we've learned a lot from this process, these changes have been somewhat piecemeal, and as a result, it's difficult to understand what changes have been made to the original JMT code, and for what reason. To fix this, we should put the existing repo history to the side, restart from an earlier state, and produce a sequence of relatively atomic changes as follows:

Start with a "clean" import from the Diem code, which includes the work to pull all of the transitive dependencies it requires from the rest of the Diem workspace.  This should include all of the original test code, but have no changes beyond what's needed to make it compile with passing tests.  (The current state of the pre-async branch is potentially close to this already).
Add CI to the repo; just the basic actions-rs quickstart config (without clippy) should be fast and easy. Then all subsequent steps can have test runs.
Do some basic cleanup to the code organization; it's not important that this is perfect, but it would be helpful to:

move code into leaf modules, rather than having, e.g., lib.rs filled with implementation details; this doesn't have to go all the way to "one struct per file", but smaller files with re-exports are much easier to manage.
move test code into test modules, either as submodules of the code they're testing, or as a top-level ::tests module in the crate root for general tests. (Another, in this case less preferable, option would be to move general tests into integration tests under jmt/tests/ rather than as part of the crate under jmt/src, but integration tests can't access crate internals, so if we're planning to cut down the public API, keeping the tests internal prevents having to move them around at that step).

Simplify the API and cryptography, changing the structure from operating on typed Values with bespoke SHA3 instances to a simple, byte-oriented key/value store using SHA2:

[x] Change the key type from a generic HashValue sometimes representing a pre-hashed key to KeyHash type that hashes a byte slice K: AsRef<[u8]>.  To do this, it would probably be helpful to:

[x] add a HashedKey(pub [u8; 32]) type, and re-export it from the crate root;
[x] add an impl<K: AsRef<[u8]> From<K> for HashedKey that performs SHA2 hashing with some domain separator (b"JMT::Key"?);
[x] change any methods that take HashValues representing keys to instead take KeyHashes;
[x] change any methods that return HashValuess to instead return HashedKeys.

[x] Remove the Value trait, and replace it with V: AsRef<[u8]> on the way in and Vec<u8> on the way out, hashing value bytes with SHA2 with some domain separator (b"JMT::Value").
[x] Define (non-derived) methods for any required hashing of internal nodes, also using SHA2.

Do API cleanup; some changes we flagged while looking through the existing code:

[x] Delete all other existing hashing code, including the hash module, the define_hash macro, and anything that depends on them.
[x] hide the MissingRootError; we're moving to anyhow anyways, and it's not clear why it would be useful to downcast to it;
[x] hide the node_type module;
[x] create a storage facade module under the crate root, and re-export the node types required for implementing the reader and writer traits from it;
[x] remove the metrics code;
[x] hide the types module;
[x] consider hiding the iterator and restore modules, and re-exporting their contents from the crate root.
[x] other changes (?), as determined by looking at the public API with cargo doc and checking whether it makes sense.

Finally, redo the sync -> async changes onto this minimized crate state, keeping only an async interface, rather than a synchronous one.

Part 6 being moved into new re-asyncification issue


Use time.Duration as type for timeouts

This PR replaces instances of where timeout was an int representing the number of seconds by time.Duration, as suggested by #230 .
Not entirely sure about the float64 -> int conversion, also thought about using strconv.FormatFloat(v, 'f', 0, 64) for formatting it as an integer. WDYT ?

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "timeout-as-time.Duration" git@github.com:pdalpra/engine-api.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@pdalpra cool :+1: Using strconv.FormatFloat makes more sence to me (reading it at least).

should I introduce this a utility function or inline the code for the time being ?

@pdalpra maybe a utility function it types/time :stuck_out_tongue_closed_eyes:

sorry for keeping it stale, will update the PR today

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "timeout-as-time.Duration" git@github.com:pdalpra/engine-api.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@vdemeester PR (finally !) updated

LGTM :angel:
/cc @aaronlehmann @calavera

I can take of the matching PR on docker/docker if you like

LGTM

I'm a bit late to the review.
First, great thought and contribution @pdalpra. It is much appreciated and I think it is good practice to use time.Durations for our timeout durations.
I do not like that we convert an int to a float then parse the float to convert to a string.

Too much conversion when it should be just number to number. (This is more of an aesthetics thing)
This adopts float semantics for an integer. (I think this is mainly to be used with full seconds, so it does not matter so much)

My suggestion would to be add a comment on the rounding, just so no-one expects to get sub second precision, or to adopt what is in the godocs for time.Duration, i.e. the calculation becomes int64(duration/time.Second) instead of the float/string parsing. That also does a rounding (always round down) with no sub second precision.
Thanks again @pdalpra for the contribution here and in docker/docker#23344!


fix class editor issues

remove modwarfare class management
add max level hack

use of regular class editor possible now.


Eliminate redundant into_iter() functions in favor of IntoIterator

Currently, many collections (including Vec) both implement the IntoIterator trait (which has .into_iter() as a required method) and implement .into_iter() as an inherent method. I think that we should remove the inherent method and put the IntoIterator trait in the prelude.

cc me, this was an oversight that can likely be rectified before 1.0

See https://github.com/rust-lang/rfcs/pull/1030


Lamp types don't work anymore

What the title says. Clicking on any lamp type button doesn't change the lamps rendered.

Fixed in the next release. The signals got disconnected for some reason.


[e2e]: generic schedule main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3305781702
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Sun Oct 23 04:38:41 UTC 2022

Transient errors. Re-running test.

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3305781702
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.default.slsa3.yml
Trigger: schedule
Branch: main
Date: Sun Oct 23 23:26:27 UTC 2022
Tests are passing now. Closing this issue.


feat: allow library users to specify how PKCE challenge codes are generated

First off, thanks for your work on this library - much appreciated and great to see it is certified.
I'm raising this PR to give consumers more control over how PKCE challenge codes are generated. Currently PKCE challenge codes in the latest release are UUIDs (in master they are Base64 URL encoded UUIDs) and the library user has no way to change this. However, a consumer may need to for the following reasons:

An OIDC provider only accepts challenge codes of certain lengths or using certain alphabets. Okta, for instance, rejects PKCE challenge codes shorter than 43 characters.
A library consumer may wish to fine tune the security of the challenge code - for instance, by using a specific source of randomness or by choosing longer or shorter challenge codes depending on.

This PR demonstrates a possible approach to allowing consumers to control how PKCE challenge codes are generated. I don't necessarily expect you to accept it as is - although I've tried to match the coding style used in the rest of this repo, this is a bit of a drive-by PR to try to solve a problem I'm facing right now and potentially breaks any custom implementations consumers have of the RelyingParty interface by adding a new method to it. However hopefully it helps get to a place where consumers have more control over PKCE challenge code generation.

Hi @Osipion
Thanks for your feedback and this PR. I was thinking about exchanging the UUIDs and take random bytes using the crypto package. But I like your approach even more. I'll take a closer look tomorrow and give you some feedback.

@livio-a - thanks for your response. There's probably a couple of things that should be tweaked (not sure it was a great idea to make the default code generator a public variable for instance) - feel free to suggest any changes you think are neccessary. As a bit of extra context, I was just reviewing RFC-7636 and it turns out that code verifiers are supposed to be a minimum of 43 characters (maximum of 128) - so the comment I put about 36, and the original UUID implementation, are both contrary to the standard I think.

Just linking this to #126  😁

Hey @Osipion
Finally found some time to think about your proposal, especially the problem of breaking current implementations of the RelyingParty interface.
How about creating a second interface RelyingPartyCodeChallenge which extends the RelyingParty interface with the PKCECodeGenerator method:
type RelyingPartyCodeChallenge interface {
	RelyingParty
	PKCECodeGenerator() PKCECodeGenerator
}

The default implementation could implement the new interface:
//NewRelyingPartyOIDC creates an (OIDC) RelyingPartyCodeChallenge with the given
//issuer, clientID, clientSecret, redirectURI, scopes and possible configOptions
//it will run discovery on the provided issuer and use the found endpoints
func NewRelyingPartyOIDC(issuer, clientID, clientSecret, redirectURI string, scopes []string, options ...Option) (RelyingPartyCodeChallenge, error) {
...

But doesn't even have to, because the GenerateAndStoreCodeChallenge would just have to check whether the provided RP also implements the RelyingPartyCodeChallenge interface:
func GenerateAndStoreCodeChallenge(w http.ResponseWriter, rp RelyingParty) (string, error) {
	codeGen := defaultPKCECodeGenerator
	c, ok := rp.(RelyingPartyCodeChallenge)
	if ok {
		codeGen = c.PKCECodeGenerator()
	}
	codeVerifier, err := codeGen()
	if err != nil {
		return "", err
	}
	if err := rp.CookieHandler().SetCookie(w, pkceCode, codeVerifier); err != nil {
		return "", err
	}
	return oidc.NewSHACodeChallenge(codeVerifier), nil
}

And as you mentioned, I would not have the defaultPKCECodeGenerator variable public. I can't remember or think of a reason I did this with the DefaultErrorHandler.
What do you think of that?

Hey @livio-a apologies for taking a couple of days to get back to you. If you're happy adding a bit more complexity to the API to retain backwards compatibility then I am too 🙂 . I've made the changes. I've also changed how default codes are generated (concat 2 UUID strings) to make sure the default is spec compliant WRT length. In my own custom implementation I use:
var (
	ErrInvalidPKCEVerifierLength = errors.New("PKCE verifiers must be between 43 and 128 characters")
	PKCEVerifierAlphabet = []rune("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~")
)

func String(l int, alphabet []rune) (string, error) {
	chars := make([]rune, l)
	ln := big.NewInt(int64(len(alphabet)))
	for i := 0; i < l; i++ {
		idx, err := rand.Int(rand.Reader, ln)
		if err != nil {
			return "", err
		}
		chars[i] = alphabet[idx.Int64()]
	}
	return string(chars), nil
}

func PKCEChallenge(l int) (string, error) {
	if l < 43 || l > 128 {
		return "", ErrInvalidPKCEVerifierLength
	}
	return String(l, PKCEVerifierAlphabet)
}

Not sure if that's a good fit here?

@Osipion looks good.
Quick question to the default implementation change: Wouldn't the base64 representation of a single uuid be enough. The uuid is always 36 chars long, so the base64 representation will always be 48 long. Which would suit the specs.
But as already mentioned, I thought about switching to a similar approach to generate the challenge as you did with generating a random string. So we could as well take this into the library as default.

hi @Osipion thanks for your help so far, do you have further feedback for @livio-a

Wouldn't the base64 representation of a single uuid be enough. The uuid is always 36 chars long, so the base64 representation will always be 48 long. Which would suit the specs.

@Osipion @thomas-welch are you still interested in this improvement? It looks like a question is still open 😁

@Osipion @thomas-welch friendly ping if you still need this merged?

@Osipion looks good.
Quick question to the default implementation change: Wouldn't the base64 representation of a single uuid be enough. The uuid is always 36 chars long, so the base64 representation will always be 48 long. Which would suit the specs.
But as already mentioned, I thought about switching to a similar approach to generate the challenge as you did with generating a random string. So we could as well take this into the library as default.

If you still need to switch the random string generation, I can pick that up separately. Perhaps create a issue for it first? Btw, the above PR uses a slice of []rune but using a constant string is way faster.

Closing this due to inactivity. However, feel free to ping us if you want to proceed to merge this.


CASMPET-7059: Make SBPS Marshal agent RPM part of CSM release distrib…

…ution
- Add SBPS (Scalable Boot Projection Service) Marshal agent RPM part of
  CSM release distribution.

Summary and Scope
Need to make SBPS (Scalable Boot Projection Service) Marshal agent RPM part of CSM release distribution.
SBPS Marshal agent RPM artifact is getting published @ https://artifactory.algol60.net/artifactory/csm-rpms/hpe/stable/noos/sbps-marshal/noarch/sbps-marshal*
Please refer feature confluence page for more info on SBPS Marshal Agent component: CSM: Replace the use of DVS for boot content projection - CSMTemp - HPE R&D Wiki - PROD (hpecorp.net)
Issues and Related PRs
Main JIRA for this RPM: https://jira-pro.it.hpe.com:8443/browse/CASMPET-6793
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves [issue id](issue link)
Change will also be needed in <insert branch name here>
Future work required by [issue id](issue link)
Documentation changes required in [issue id](issue link)
Merge with/before/after <insert PR URL here>

Testing

Tested on baremetal system (Odin) with 6 worker nodes.

Tested on:

Tested on baremetal system (Odin) with 6 worker nodes.

Test description:
This SPBS Marshal agent has been verified by manually downloading (wget) from the artifactory location https://artifactory.algol60.net/artifactory/csm-rpms/hpe/stable/noos/sbps-marshal/noarch/sbps-marshal* and installing on the baremetal systems like Odin. Verified that this SBPS Marshal agent (systemd service) is properly installed and working as per the functionality (https://jira-pro.it.hpe.com:8443/browse/CASMPET-6793) when this systemd service is started (with systemctl)
Risks and Mitigations
None
Are there known issues with these changes? Any other special considerations?
None
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[ ] License file intact
[x] Target branch correct
[x] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

@ravikanth-nalla-hpe You need to assign CASM-Release-Ready label to JIRA ticket (CASMPET-7059), when you ready to add your change to CSM release.


Add http/xpath source

Resolves #59
A simple yet working example.yaml is provided for #56.
Dockefile
Mike now uses python:slim base image, because it takes soooooome time to build lxml and alpine is not compatible with Python wheels - docker-library/docs#904
Image size is bigger, but the build time is under reasonable limits.
REPOSITORY                                      TAG                 IMAGE ID            CREATED             SIZE
mike                                            latest              90628b250c16        57 seconds ago      314MB
vs
macbre/mike                                     latest              9cb9746db092        13 hours ago        177MB
b6f8eef

https://hub.docker.com/r/macbre/mike/tags
latest tag now weights 106 MB (was 63 MB)


Jan 2016

@lawnsea

:+1:

@lawnsea i'll go ahead and respond to the previous tweet w/ the blog post

:+1:

thnx @beaktor !


refactor(app): Remove loader from Devices page

Overview
Remove from Looking for robots... loader from Devices page.
This fixes #10080

Changelog

Removed the Scanning component from DeviceLanding component
Removed a test case for Scanning component

Review requests

No loader when open Devices page

Risk assessment
low

we should also delete the Scanning component - this is the only place it is used

@brenthagen
Deleted the Scanning component and the test.


Update city_of_saint_johns.json

The "house number" attribute is in the CIVIC field, STREETNUM is a unique identifier for the street.

Thanks!


Update README.md

Updating read me based on feedback from Matt Germonprez. Refer to issue no. 801
Signed-off-by: Vinod K. Ahuja<EMAIL_ADDRESS>

Closing this and recreating it through a revised KB  structure. https://docs.google.com/spreadsheets/d/1dEMY-vtiGPdM4N4poyi_zy4jKdYloWycJl23YfTzCU8/edit?pli=1#gid=2145599958


OSX Build issues for Docker image

Hi, I tried to installed following:
# OS - Macos 10.13.4
$ git clone https://github.com/EOSIO/eos.git --recursive
$ cd eos/Docker
$ docker build . -t eosio/eos

But it failed.
Logs for reference
sudo docker build . -t eosio/eos
Password:
Sending build context to Docker daemon  31.74kB
Step 1/17 : FROM eosio/builder as builder
 ---> 7856d2feef90
Step 2/17 : ARG branch=master
 ---> Using cache
 ---> 9dfb94a3a119
Step 3/17 : ARG symbol=SYS
 ---> Using cache
 ---> a4f847a16a34
Step 4/17 : RUN git clone -b $branch https://github.com/EOSIO/eos.git --recursive     && cd eos && echo "$branch:$(git rev-parse HEAD)" > /etc/eosio-version     && cmake -H. -B"/tmp/build" -GNinja -DCMAKE_BUILD_TYPE=Release -DWASM_ROOT=/opt/wasm -DCMAKE_CXX_COMPILER=clang++        -DCMAKE_C_COMPILER=clang -DCMAKE_INSTALL_PREFIX=/tmp/build  -DSecp256k1_ROOT_DIR=/usr/local -DBUILD_MONGO_DB_PLUGIN=true -DCORE_SYMBOL_NAME=$symbol     && cmake --build /tmp/build --target install && rm /tmp/build/bin/eosiocpp
 ---> Running in 2b72758999d7
Cloning into 'eos'...
Checking out files: 100% (12758/12758), done.
Submodule 'contracts/libc++/upstream' (https://github.com/EOSIO/libcxx.git) registered for path 'contracts/libc++/upstream'
Submodule 'contracts/musl/upstream' (https://github.com/EOSIO/musl.git) registered for path 'contracts/musl/upstream'
Submodule 'externals/binaryen' (https://github.com/EOSIO/binaryen) registered for path 'externals/binaryen'
Submodule 'externals/magic_get' (https://github.com/EOSIO/magic_get) registered for path 'externals/magic_get'
Submodule 'libraries/appbase' (https://github.com/eosio/appbase) registered for path 'libraries/appbase'
Submodule 'libraries/chainbase' (https://github.com/eosio/chainbase) registered for path 'libraries/chainbase'
Submodule 'libraries/fc' (https://github.com/EOSIO/fc) registered for path 'libraries/fc'
Submodule 'libraries/softfloat' (https://github.com/eosio/berkeley-softfloat-3) registered for path 'libraries/softfloat'
Cloning into '/eos/contracts/libc++/upstream'...
Cloning into '/eos/contracts/musl/upstream'...
Cloning into '/eos/externals/binaryen'...
Cloning into '/eos/externals/magic_get'...
Cloning into '/eos/libraries/appbase'...
Cloning into '/eos/libraries/chainbase'...
Cloning into '/eos/libraries/fc'...
Cloning into '/eos/libraries/softfloat'...
Submodule path 'contracts/libc++/upstream': checked out '2880ac42909d4bb29687ed079f8bb4405c3b0869'
Submodule path 'contracts/musl/upstream': checked out '8a34536ac9764c90c86cc0b62d0cda07449fd5d8'
Submodule path 'externals/binaryen': checked out 'e13b8b74d210b882f19252dc11dc3df73294ae13'
Submodule 'test/emscripten' (https://github.com/kripken/emscripten.git) registered for path 'externals/binaryen/test/emscripten'
Submodule 'test/spec' (https://github.com/WebAssembly/testsuite.git) registered for path 'externals/binaryen/test/spec'
Submodule 'test/waterfall' (https://github.com/WebAssembly/waterfall.git) registered for path 'externals/binaryen/test/waterfall'
Cloning into '/eos/externals/binaryen/test/emscripten'...
Cloning into '/eos/externals/binaryen/test/spec'...
Cloning into '/eos/externals/binaryen/test/waterfall'...
Submodule path 'externals/binaryen/test/emscripten': checked out '1d979a75722a513b586e6705d662ff4ee0ea832b'
Submodule path 'externals/binaryen/test/spec': checked out '668281b3d7dfe9be6cbc3c4500b537c49d6449b9'
Submodule path 'externals/binaryen/test/waterfall': checked out '900646fc880d526160b0df9b78bc9dd4f02dc1ab'
Submodule path 'externals/magic_get': checked out '89fda1da702e6c76a22bfb6233e9e3d0641708ec'
Submodule path 'libraries/appbase': checked out '44d7d88e561cc9708bcac9453686c8d0f0ffa41e'
Submodule path 'libraries/chainbase': checked out 'b40a1ec99ee0eb16e28ee1c1a9577f1af7d48b84'
Submodule path 'libraries/fc': checked out '9e4755ad191b60101f9fb359713a247bd64797a5'
Submodule path 'libraries/softfloat': checked out '9dff375a6e3a9728a024b30afa127c88fcb40ea2'
-- The C compiler identification is Clang 4.0.1
-- The CXX compiler identification is Clang 4.0.1
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using custom FindBoost.cmake
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   thread
--   date_time
--   filesystem
--   system
--   program_options
--   signals
--   serialization
--   chrono
--   unit_test_framework
--   context
--   locale
--   iostreams
-- Configuring EOSIO on Linux
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- binaryen building with -std=c++11
-- binaryen building for platform x86-64
-- binaryen building with -Wall
-- binaryen building with -Werror
-- binaryen building with -Wextra
-- binaryen building with -Wno-unused-parameter
-- binaryen building with -fno-omit-frame-pointer
-- binaryen building with -fPIC
-- binaryen building with -O2
-- binaryen building with -UNDEBUG
-- binaryen building with -fcolor-diagnostics
-- Using 'SYS' as CORE symbol name
-- Using 'EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV' as public key for 'eosio' account
-- Found WASM: /opt/wasm/bin/clang
-- Using WASM clang => /opt/wasm/bin/clang
-- Using WASM llc => /opt/wasm/bin/llc
-- Using WASM llvm-link => /opt/wasm/bin/llvm-link
-- Found Secp256k1: /usr/local/lib/libsecp256k1.a
-- Found GMP: /usr/lib/x86_64-linux-gnu/libgmp.a
-- Configuring fc to build on Unix/Apple
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.a
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- zlib found
-- Configuring Builtins
-- Configuring SoftFloat
-- Using custom FindBoost.cmake
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   thread
--   date_time
--   filesystem
--   system
--   chrono
--   unit_test_framework
--   locale
-- Configuring ChainBase on Linux
-- Using custom FindBoost.cmake
-- Boost version: 1.67.0
-- Found the following Boost libraries:
--   thread
--   date_time
--   filesystem
--   system
--   chrono
--   program_options
--   unit_test_framework
--   locale
-- Configuring AppBase on Linux
-- Found Git: /usr/bin/git (found version "2.17.0")
-- Git commit revision: 379cb1a9
-- Git commit revision: 379cb1a9
-- Found Intl: /usr/include
-- Git commit revision: 379cb1a9
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Doxygen not found.  Contract documentation will not be generated.
 Generally these failures occur due to docker having insufficient memory to complete the build.


[9.4.x] ISPN-11341 Client requests go to wrong server with binary storage

https://issues.redhat.com/browse/ISPN-11341

integrated! thanks @gustavonalle !


include minified js and css in npm package

The dialog-polyfill NPM package does not currently include minified versions of the js and css.
As a result, many NPM users, and therefore users of the unpkg.com CDN, pull in unminified versions of these assets into their pages. Would you consider including minified versions in the NPM package?
Thanks for your consideration and for the great work on dialog-polyfill!

ref: https://unpkg.com/dialog-polyfill/

It's something I've thought about. I do it for e.g. inert-polyfill, which was created much more recently.
QQ: Inert includes the minified CSS inside the JS and adds it to the page as needed. Would that be useful for dialog, or is that actually a pretty weird concept?

Including the CSS in the JS sounds great to me, thanks, and glad you're amenable to this!

There are a few lib including the css in the js, Google is doing it...

@samthor would you be open to a PR for including minified css in the js? I'm happy to take this on.

I've got a PR that injects the css into the document head, open for improvement suggestions if this is something we'd find useful.

@mreinstein happy to accept PR.

@samthor  this is where we left off https://github.com/GoogleChrome/dialog-polyfill/pull/180


Resolve an issue where on some Android devices the videoSize is not cast correctly

On Android if the videoSizeChanged event is never triggered the default VideoConfig is used https://github.com/ThibaultBee/StreamPack/blob/main/core/src/main/java/io/github/thibaultbee/streampack/data/VideoConfig.kt#L99, which the width and height are returned as int. To ensure the dart size fields always has a double as expected, we need to toDouble here.

Hi,
Thanks for fixing this :) 🙏
And I think you also fixed issue https://github.com/apivideo/api.video-flutter-live-stream/issues/28.
Nice  👍

Hi,
I have seen that this solution is in main, but will it be available in pub.dev?

Done!


Can't assign mouse buttons or mouse wheel to editor shortcuts

Godot version:
All versions including v4.0.dev.custom_build.1d45a269f
OS/device including version:
W10 1903
Issue description:
Can't assign mouse button inputs to editor shortcuts
Steps to reproduce:
Editor Settings > Shortcuts > Try to set any mouse button, can't
Minimal reproduction project:
None
Some related issues:
#6366
#26999
The editor settings only allows key inputs, as shown below, where the event is cast to InputEventKey.
https://github.com/godotengine/godot/blob/f6e29addd433130100061935b9a2b8f6de38254b/editor/settings_config_dialog.cpp#L318-L330
I think being able to assign BUTTON_XBUTTON1 and BUTTON_XBUTTON2 would be helpful, especially for back/forward editor navigation. In order to not let people mess up the general usage of the editor, I think it may be a case of only allowing the above 2 mouse button input types to be assigned... i.e. not allowing rebinding of MB1, MB2, scroll, etc (unless they are modified...? e.g. with shift, alt, ctrl).
Making this change would be relatively simple (I think - haven't looked into it too deep), but it would require changing a decent amount of existing code within the file above, since last_wait_for_key would need it's type altered.
Happy to work on a PR if the general consensus is that this is worthwhile.

See also #36910, where I had to hardcode the keys due to this limitation (in addition to not being able to assign multiple shortcuts to the same action).

Duplicate of #6648 basically, but it's more detailed.

Yeah so I think the issue with the solutions mentioned so far is that they limit flexibility. If the button is hard-coded then people who use those for Push To Talk wouldn't be happy, as some have already expressed in those issues.
This would allow for more opions, as those people could even rebind the key to ctrl/alt/shit + Mouse Button X in order to have both functions available to them.
I will start to implement this change and keep this issue up to date if I run into any hurdles... if not, expect a PR soon :D

@Calinou @KoBeWi So I pretty much have this done (shortcuts working - tested after assigning):

Only one issue, as below. The shortcuts use as_text() on the InputEvent to get the display information. Fine for keyboard... not so fine for mouse, as you can see.

I have thought about solutions and have considered:

Adding another virtual method to InputEvent to get the text (not preferred)
Changing as_text() to as_text(bool p_readable) or something similar. Where p_readable=false is what it gives now, and p_readable = true would give the same thing given in the first image above. The exact wording of the parameter could be anything of course.

As far as I can tell as_text() is only used in shortcut.cpp, in get_as_text() so it would not have wide reaching changes.
Keen to hear thoughts.

@EricEzaM I think it would be better to make as_text() return an human-readable string for all input event types. If we still need a debugging-friendly conversion, it could be done as an implicit _to_string() conversion (like array/dictionary types).

Bit of an update...
Using keys only for shortcuts is quite deeply ingrained in the engine code... Most checks for shortcuts happen on _unhandled_key_input(...) which clearly is not helpful when it comes to implementing non-key shortcuts.
So basically everywhere where shortcuts are read (so far only seems to be <5 classes) key input needs to be changed to check for mouse button input also. PR to come soon I hope.

FYI reduz is against this change currently due to fundamental differences bwteen how KB and Mouse input is handled.
Or at least he was several months ago when this was discussed on IRC.

FYI reduz is against this change currently due to fundamental differences bwteen how KB and Mouse input is handled.
Or at least he was several months ago when this was discussed on IRC.

I think this is a useful feature.
Without going into implementation details, I can assume that for the end user, keyboard keys and mouse buttons are all buttons.
And assigning actions to mouse buttons is a fairly common practice.
If it is difficult to implement within the current editor's shortcut system architecture, then work-rounds could be provided, for example, ability to create a custom/additional shortcut system.
btw, what about something similar to InputMap?
That is, all shortcuts assignments could be stored in EditorSetting, etc.

I think this is a useful feature.
Without going into implementation details, I can assume that for the end user, keyboard keys and mouse buttons are all buttons.
And assigning actions to mouse buttons is a fairly common practice.
If it is difficult to implement within the current editor's shortcut system architecture, then work-rounds could be provided, for example, ability to create a custom/additional shortcut system.
btw, what about something similar to InputMap?
That is, all shortcuts assignments could be stored in EditorSetting, etc.

I'd find this particularly useful to rebind some rather irritating bindings that I can't change as of now. At least for my mouse, tilting the mouse wheel is bound to panning the graph editor, which happens often on accident when I try to click the mouse wheel in to pan by dragging. Often, this ends up happening:
https://user-images.githubusercontent.com/56076033/108091880-82dbbc80-7052-11eb-8b1b-f8db70a4565b.mp4

@MagdielM If this happens to you, it might be worth using dedicated software to disable the lateral mouse wheel buttons.

I would like to set shortcut for next/prev editor tabs via Ctrl+Shift+MouseWheelUp/Down. Does this issue relative for this?

I would like to set shortcut for next/prev editor tabs via Ctrl+Shift+MouseWheelUp/Down. Does this issue relative for this?

Yes, this issue is about any editor shortcut that can be configured. These shortcuts can be configured:


Fixed bug in search API indexclaimhas instead of indexclaim parameter

Fixed bug in search API indexclaimhash instead of indexclaim as query parameter.

@barclayn
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

#sign-off

#sign-off


Added .editorconfig file

Description
Added the .editorconfig file.
Related Issue
Closes #51
Additional Information
This'll resolve the annoying task of changing end of line sequence manually each time a new file is created. You'll have to install an extension for your text editor for the .editorconfig to work.

LGTM


Add mention of LOAD/INSTALL to httpfs documentation page

Saw someone having issues figuring out they had to INSTALL/LOAD the extension, figured this might help make it more obvious

Thank you for including this! I'm sure it will help folks just getting started with this extension.


Publish a list of know bugs/issues on the Website/Docs

This Issues is only regarding the documentation/website.
I would like to see a (easy to find) list with current issues and things that won't work or may never get supported.
Some examples:

Safari on Windows does not work without QT
M4A (AAC) doesnt work yet.
OGG/Vorbis doesnt work Cross-Browser

This will save a lot of time developers consider to use mediaelement.js

Compatibility with File Format and User Agents are covered on the site
http://mediaelementjs.com/#devices

Safari on Windows w/o QuickTime is rare since it's in general unpopular, and Safari and QuickTime are packaged together.
I'm not sure that it's practical mention M4A and AAC, since they are in general not supported by browsers.  MP3 is covered.
The OGG/Vorbis should be perhaps added, WebM is gaining more support, but it is possible to play OGG in Flash.

Safari on Windows is popular for developers who like to test a website but dont have access to such devices. I am aware about the reasons why it won't work, but it took me a lot of time to find out.
According to wikipedia all Apple products and Android based devices support m4a/acc, it has also a more friendly license for distribute content compared with mp3.
It's ok for me if mediaelement won't work with anything because I like simple & easy designed software/libraries. But its really helpful to have a complete list with all popular codecs. Oh, and OGG/Vorbis, thats REALLY missing!


Support for Swift 3.0 and Xcode 8

Used the migration assistant to convert to Swift 3.0. Compiled without errors or warnings using Xcode 8b3.

@jeremygibbs thanks, but all the swift files are generated by a script based on definitions to avoid repetitive coding, so I think the definitions should be changed too


Skip EL8 osg -> osg-upcoming tests for packages that won't be in osg

Hrm, this means we lose the CE upgrade test. Yet Another YAML file?


Fix false positive when the node is the only one inside of if/else branch

Fixes #648

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.

@bquorning it seems that you've reviewed the old version of the diff. It's already called last_child? and doesn't return any nil :)


#234 Update Rust ascii art

#234 I think Ferris is a more interesting as a logo for Rust so here you go. Example art on the main repo itself:

This looks amazing @nguyenquannnn
Thanks a lot!
Hopefully, this won't be your last contribution.

So cute :heart_eyes:
Thanks a lot  @nguyenquannnn
Hopefully, this won't be your last contribution.

Haha yes, I'm learning Rust so this would be perfect for hands on Rust practice


operator keysight-loadcore-agents (0.2.7)

Adding Operator keysight-loadcore-agents version 0.2.7 - DCI Job: 7a02216e-ad5f-4450-9839-19bb46e63254

Pull request not merged due to "merge: false" in ci.yaml.

Pull request not merged due to "merge: false" in ci.yaml.

Yes I know. I do not want it merged yet


PyTorch DistributedDataParallel training with multi nodes

could you provied a demo for PyTorch DistributedDataParallel training with multi nodes?

Does it work for you ? https://github.com/kubeflow/training-operator/blob/master/examples/pytorch/mnist/v1/pytorch_job_mnist_nccl.yaml


Unable to proxy root path / to back end server

Expected behavior
When the proxy setting is like the following
proxy('/', {target:'http://localhost:8080'})

Only the request to the root path should be proxied. No other requests should be proxied. In my opinion, since the wildcard already provides the ability to match any requests, context / should be used to match the root path. In this way, it becomes possible for an app to proxy the root path to the back end server for rendering the initial HTML content.
Actual behavior
Any requests are proxied.

A little more background detail on the use case.
I'm setting up a Spring Boot + Vue.js project and I want to proxy the root path to the back end server and use the back end server to dynamically generate the HTML which will be sent back to the client side and start loading js, css, and other assets.
The reason to use back end server to generate the HTML dynamically is because I need to save some data to the HTML rather than to use a static HTML file. For example, I can save some logged in user's info, like name, avatar image, to save the effort of sending an additional request for that when using a static HTML file.
And that's why it is important for me to proxy the / to the back end server.

Thanks for reporting this @jamesjieye .
Changing this will break the current behavior unfortunately, as documented here:
https://github.com/chimurai/http-proxy-middleware#context-matching
There are a couple of context matching improvements I want to make and I'll certainly consider to add this one to the list.
For now you can provide a custom function to determine when to proxy a request:
function filter(path) {
  return path === '/';  // only proxy root path
}

proxy(filter, {target:'http://localhost:8080'});

@chimurai Thanks for the tip!
The custom function is a good workaround for me.


Show tool bar in side by side view

Anyway to show the toolbar in the side by side view?

There is toolbar as a default when you toggle side by side view

@boomtothemoon thanks, I see what our issue is then, the Bootstrap header for the site has a z-index greater than that of the side by side toolbar.  Fixed by overriding the rule for the side by side toolbar. like so:
.editor-toolbar.fullscreen {
  z-index: <a number higher than your bootstrap header>;
}


How to generate  $contig_label   used for metaMIC train

Hi,
I was stuck in training on a new dataset. Could you please tell me how to build a  $contig_label file?
metaMIC train -o $output_dir -a $New_model_name --label $contig_label
Thanks,
Peter

Hi,
I also encounter the same problem. Can you answer us how to prepare the contig_lable file?

Also the same problem. Look forward to the solution.


missing c-header files for memcpy and printf

The g++ compiler needs to include the  header for memcpy and the  header for printf.

in ckwargs.cpp the function memcpy is used, this needs for g++ the header <cstring>.
in SomeFunction.cpp the function printf needs the inclusion of <cstdio>

I finally got this fixed and could compile the code on Linux with g++ 12.

Thanks.  That's odd.  I will put them into the respective files.  On my main environment they are somehow automatically included.
Weird.  The error completely makes sense. I can't reproduce it, but it won't hurt to add them.
I'll be able to test more in gcc vs. msvc coming up.


State of this repository? Or: Is the README up to date?

This repository appears to be very active, font installation seems to be working well, people seem to be using it, but… the readme still says that it's pre-release, not even alpha, and refers to an issue from 2014.  The issue has been closed early this year though, without any further updates.
So what's the state of this repo now?  Is it alpha or not?  Can I safely use it?  Would you recommend me to use it?

Check the open issues. Two of them pertain to problems that affect the majority of casks. They won’t even pass audit.
Like all of homebrew-cask, this repo works fine and many people already depend on it, but at their own risk.


No module named 'wakeup' in v0.0.9 adafruit_io_fixes PR

Nuke flashed Pico and flashed using pimoroni-picow-v1.19.10-micropython.uf2 and manually uploaded the latest code from https://github.com/pimoroni/enviro/tree/patch/adafruit_io_fixes/enviro.
In log.txt it states:
2000-01-01 01:10:05 [info     / 131kB] > performing startup
2000-01-01 01:10:05 [debug    / 129kB]   - running Enviro 0.0.9, MicroPython 9dfabcd on 2022-11-18
2000-01-01 01:10:05 [exception / 126kB] ! Traceback (most recent call last):
  File "main.py", line 37, in <module>
  File "enviro/__init__.py", line 474, in startup
  File "enviro/__init__.py", line 305, in get_wake_reason
ImportError: no module named 'wakeup'

2000-01-01 01:10:05 [info     / 123kB] > going to sleep
2000-01-01 01:10:05 [debug    / 122kB]   - clearing and disabling previous alarm
2000-01-01 01:10:05 [info     / 120kB]   - setting alarm to wake at 01:15am
2000-01-01 01:10:05 [info     / 118kB]   - shutting down
2000-01-01 01:10:05 [debug    / 136kB]   - on usb power (so can't shutdown). Halt and wait for alarm or user reset instead

Can't find wakeup.py searching Github in main branch or PR. Code was added in PR https://github.com/pimoroni/enviro/pull/113/files. Is there a file missing?

You could try installing

Then just copy over the upodated files from the patch branch to see if that works?

Hi @djbloc. Wakeup is a module over in Pimoroni Pico (https://github.com/pimoroni/pimoroni-pico/tree/main/micropython/modules/wakeup), so you need to flash your Enviro with a recent version of the pimoroni-picow_enviro Micropython, like the one dave-ct linked to.

Thanks @dave-ct, @ZodiusInfuser. Will try that.


xit and xdescribe do not mark tasks as pending

I notice that the latest versions of Jest defaults to Jasmine 2 but for some reason xit and xdescribe do not mark tests as pending. Is this by design? Is there a way of writing pending tests?

Hello, I'm not sure what "pending" means but an x in front of it or describe will disable the test. I think Jest counts disabled tests so and they'll show up as passed tests even though they are disabled.

Hi @cpojer, I guess it depends on how your feature parity is with the test runner you're using. Jasmine2 is the default test runner for the latest version of Jest. Jasmine2 and Jest handle xit and xdescribe differently. In Jest, if I've marked a test as xit, or have not placed a function within an it callback, the tests pass:
describe('some tests', () => {
  xit('not ready to write out the code for the test, but I know this test should pass');
  it('not ready to write out the code for the test either, but I know this test should pass');
});

The above tests would pass under Jest, but when run under Jasmine2 they show up as pending, instead of passed. I've attached screenshots:
Jasmine displays at the bottom 3 specs, 0 failures, 2 pending:

While Jest displays at the bottom 3 tests passed:

I believe this is a significant difference and should be addressed. There are times when you're working on a team and a set of tests are written up as text before any code is written, it's good to know how many tests are awaiting bodies.

@mbrio I see. I wasn't aware of the difference between Jasmine's reporting and Jest's reporting. We never reported pending tests before (not even when Jasmine 1 was the default). Would you be interested in fixing the reporting around this so that at the end we say 2 passed, 1 pending, for example? :)

Ha! I'll check it out tomorrow, I'll see what I can do.

Fixed by #788