Reset button disabled in charts

@giobetti I have noticed that if I zoom on a chart then I cannot go back. For example, if I zoom in on the heatmap then there is no way for me to zoom out. Shall we re-enable the home button at the top right of the chart?

Have you tried double clicking on it? That should do it
Sent from my iPhone
On 2. Sep 2021, at 11:00, Federico Tartarini @.***> wrote:

@giobettihttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgiobetti&data=04|01||1681dcba478144fa1b9108d96df02d70|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637661700579403199|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=flf%2BKT5u%2BE1F9J1ZCf6JFn9YaVaPJ3JCYSK1CsDXxXU%3D&reserved=0 I have noticed that if I zoom on a chart then I cannot go back. For example, if I zoom in on the heatmap then there is no way for me to zoom out. Shall we re-enable the home button at the top right of the chart?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCenterForTheBuiltEnvironment%2Fclima%2Fissues%2F97&data=04|01||1681dcba478144fa1b9108d96df02d70|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637661700579413196|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kj5TGlSJQFYBHPq0lEgTfMkINpMBKyRHvJTQYWPQN7c%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIWZJAB4OWIQCCUCUAWP5SDT744MRANCNFSM5DISSAMA&data=04|01||1681dcba478144fa1b9108d96df02d70|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637661700579413196|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=W0GrF7eOQbb%2Bgj6SQYU7l%2BNdw%2BKZJKTd01kSJHeV%2Blw%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||1681dcba478144fa1b9108d96df02d70|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637661700579423188|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=b8YDkztBWm%2BbGWRSp%2FpUCO%2BgSQVjBV%2BQPch8yogrZ98%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||1681dcba478144fa1b9108d96df02d70|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637661700579423188|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=lWmnrai6C7ie%2FTZDJDtgB0TG3OkTEkZL6yvBNgsPSh8%3D&reserved=0.

Yes, that works but in my opinion, it is not very intuitive. I could not figure it out even if I developed part of the website 🙂 . I believe that it would be nice to have the reset view button like in the EPW map.

We can certainly add that back, one just has to modify the ‘config’ dictionary and it should propagate to all graphs.
On 3. Sep 2021, at 04:00, Federico Tartarini @.***> wrote:

Yes, that works but in my opinion, it is not very intuitive. I could not figure it out even if I developed part of the website 🙂 . I believe that it would be nice to have the reset view button like in the EPW map.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCenterForTheBuiltEnvironment%2Fclima%2Fissues%2F97%23issuecomment-912193316&data=04|01||82f1a159b7264a0084e408d96e7e9080|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637662312137717150|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=1w2m1MEy4W%2FGIs5531%2Fg5tPAQkcwRSy6lghuRk7gi8U%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIWZJADSCG2GMK7Q5ED52A3UAAT2XANCNFSM5DISSAMA&data=04|01||82f1a159b7264a0084e408d96e7e9080|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637662312137727141|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=78FdjTnv7x1uo0zPFIs91geYvlmtZM2EkSbgS80qlSU%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||82f1a159b7264a0084e408d96e7e9080|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637662312137727141|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=2VLVFzTkEGtCjNmGk0Y3aRFyMJ7RGOxsglSkt%2F%2FQ3jA%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||82f1a159b7264a0084e408d96e7e9080|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637662312137737132|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=IJyjpJ3CQnRQlnwTuF6fyglSkXrByI5V4sMps6Og%2BG8%3D&reserved=0.

great I will do that now, I just wanted to get your go ahead.


Grouping by a COUNT() not supported

From a Wikidata query example subquery:
PREFIX wd: <http://www.wikidata.org/entity/>
PREFIX wdt: <http://www.wikidata.org/prop/direct/>
PREFIX schema: <http://schema.org/>
SELECT DISTINCT ?path (COUNT(?pwPart) AS ?genes) WHERE {
   ?path wdt:P2410 ?WikipathsID .
   ?path wdt:P527 ?pwPart .
   ?pwPart wdt:P31 wd:Q7187 .
}
GROUP BY ?path ?genes

And on Scientists:
SELECT DISTINCT ?sc (COUNT(?partner) as ?partners) WHERE {
   ?sc <is-a> <Scientist> .
   ?sc <Spouse_(or_domestic_partner)> ?partner .
}
GROUP BY ?sc ?partners

The last log message before the crash is the following warning
WARN:  Group by variable ?partners is not part of the query.

So thinking about this, it's a bit weird as the COUNT() is counted over the groups. In Blazegraph it looks like GROUP BY ?path ?genes in the example above is exactly the same as GROUP BY ?path.

That is not a valid SPARQL query and QLever now indeed returns an error message saying that.


Add context menu entry to toggle offline tabs

Adds an entry to toggle the visibility of offline tabs, as mentioned in https://github.com/Chatterino/chatterino2/issues/5315#issuecomment-2048367176.
I'll note that the context menus for the notebook, split-header and the menu of a split are shown when pressing the mouse, not when releasing it, which is unintuitive.

I'll note that the context menus for the notebook, split-header and the menu of a split are shown when pressing the mouse, not when releasing it, which is unintuitive.

This is a platform-specific discrepancy we have. On Linux, the norm is to show the menu on mouse-down rather than mouse-up


Added ESSID list option for WPA-ENT-only beaconing and probe responses

--essidlist_wpaent allowes to beacon a list of APs with single AKM type PMKSA as some clients that have a fixed expected ESSID and AP-type won't react to dual-AKM with PMKSA+PSK
field akm in macessidlist_t lists will be acknowledged when sending beacons and proberesponses
--beaconparams IEs will only be added to reactive and essidlist beacons, not to open and hidden ones send by --active_beacon

Great. Merged, thanks.


update method _getQuery

Coverage remained the same at 65.791% when pulling 30f92a63f880887dfaa2dc715ccb28cc8e847ab8 on indriHutabalian:dev into 1c32343d8aa7d57cc75108568c8976d506754d23 on danliris:dev.


Add action to check URLs

Given that academic website URLs often change with no redirect, it might be nice to have a GitHub action that automatically checks for invalid URLs.
Such an action exists here: https://github.com/lycheeverse/lychee-action

Just ran it on this repo and here's an example of the output.  Would need to do some work to exclude certain links (e.g. private project boards) and files (e.g. _extensions/).

 lychee output
  2121/2121 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                Issues found in 21 inputs. Find details below.

[./_book/hiring.html]:
✗ [ERR] https://ucap.arizona.edu/content/university-staff-pay-structure | Failed: Network error: error sending request for url (https://ucap.arizona.edu/content/university-staff-pay-structure)
✗ [ERR] https://ucap.arizona.edu/career-architecture/work-dimensions-staff-pay-structure | Failed: Network error: error sending request for url (https://ucap.arizona.edu/career-architecture/work-dimensions-staff-pay-structure)
✗ [ERR] file:///Users/ericscott/Documents/GitHub/group-procedures/_book/arizona.edu/job-functions-families | Failed: Cannot find file
✗ [ERR] https://ucap.arizona.edu/ | Failed: Network error: error sending request for url (https://ucap.arizona.edu/)
✗ [404] https://community.rstudio.com/t/post-jobs-gigs-here/9254 | Failed: Network error: Not Found

[./_book/software.html]:
✗ [404] https://docs.hpc.arizona.edu/display/UAHPC/HPC+Documentation | Failed: Network error: Not Found

[./_book/vignettes/spreadsheet-database-vignette.html]:
✗ [404] https://github.com/cct-datascience/group-procedures/blob/main/vignettes/spreadsheet-database-vignette.qmd | Failed: Network error: Not Found

[./_book/code-of-conduct.html]:
✗ [ERR] https://arizona-advocate.symplicity.com/public_report | Failed: Too many redirects: error following redirect for url (https://arizona-advocate.symplicity.com/public_report/index.php/pid436748?)
✗ [ERR] https://arizona-advocate.symplicity.com/public_report | Failed: Too many redirects: error following redirect for url (https://arizona-advocate.symplicity.com/public_report/index.php/pid009004?)

[./_book/publishing-to-web.html]:
↻ [404] https://datascience.arizona.edu/analytics-powerhouse/rstudio-connect | Cached: Error (cached)

[./_book/impact.html]:
✗ [401] https://docs.google.com/document/d/1m8X8kVeEIDU9Xo3xzLXr0kb2HL_aQYYoh5Qp8a33wHI/edit#heading=h.bfh5rd50u0d7 | Failed: Network error: Unauthorized
✗ [401] https://docs.google.com/spreadsheets/d/1TNv0PG2iqRSLJJxX7mBFBsO0j1_EpabGH8Auqk3obEw/edit#gid=0 | Failed: Network error: Unauthorized
✗ [401] https://docs.google.com/spreadsheets/d/1Ji9A_Aozb8Hp15b2JrLHx4lqoiJXae883Fga71rqkuM/edit#gid=127724424 | Failed: Network error: Unauthorized
✗ [401] https://docs.google.com/spreadsheets/d/19Nxa4HiCYmQ4oXa41XR7kBIpRoatxD-Efp0VBUpRLDk/edit#gid=0 | Failed: Network error: Unauthorized
✗ [401] https://docs.google.com/spreadsheets/d/1jHzCgfyQLcKOuMIJpCqlS--nDgs5hIEQ-8dOafaIUlw/edit#gid=0 | Failed: Network error: Unauthorized

[./_book/emma.html]:
✗ [404] https://github.com/cct-datascience/group-procedures/blob/main/emma.qmd | Failed: Network error: Not Found

[./_book/networking.html]:
✗ [401] https://docs.google.com/spreadsheets/d/1jHzCgfyQLcKOuMIJpCqlS--nDgs5hIEQ-8dOafaIUlw/edit#gid=0 | Failed: Network error: Unauthorized

[./_book/workshops.html]:
✗ [401] https://docs.google.com/spreadsheets/d/155tcna1dMWwsZymdKFZPCrnZf3xocw4hPv1JKwOu9MQ/edit#gid=0 | Failed: Network error: Unauthorized
✗ [401] https://docs.google.com/spreadsheets/d/1SU8Wtx7Ku1IMv8DOAU-37E12-AZP0CjnRy1vPSkmNGQ/edit#gid=0 | Failed: Network error: Unauthorized
✗ [404] https://datascience.cals.arizona.edu/services-overview/workshops | Failed: Network error: Not Found

[./_book/group-expectations.html]:
✗ [401] https://calendar.google.com/calendar/embed?src=c_2c2cc9b6aa62ca6f9fc2fcc2d8558836290595f7a5db54fa5610d5da4f5d3346%40group.calendar.google.com&ctz=America%2FPhoenix | Failed: Network error: Unauthorized
✗ [404] https://hr.arizona.edu/employees-affiliates/leaves/university-winter-closure | Failed: Network error: Not Found

[./_book/vignettes/boxr.html]:
✗ [404] https://github.com/cct-datascience/group-procedures/blob/main/vignettes/boxr.qmd | Failed: Network error: Not Found

[./_book/sprint-planning.html]:
✗ [404] https://github.com/orgs/cct-datascience/projects/8/views/10 | Failed: Network error: Not Found
✗ [404] https://github.com/orgs/cct-datascience/projects/8/ | Failed: Network error: Not Found
✗ [401] https://docs.google.com/spreadsheets/d/1k4B59FdpGxAd2sNrgbXRLrYIVgcxjvnYF5yJoaIcOAA/edit#gid=0 | Failed: Network error: Unauthorized

[./_book/vignettes/creating-r-packages.html]:
✗ [404] https://github.com/cct-datascience/group-procedures/blob/main/vignettes/creating-r-packages.qmd | Failed: Network error: Not Found
✗ [ERR] file:///Users/ericscott/Documents/GitHub/group-procedures/_book/vignettes/incubator.qmd | Failed: Cannot find file

[./_book/vignettes/vignettes_overview.html]:
✗ [404] https://github.com/cct-datascience/group-procedures/blob/main/vignettes/vignettes_overview.qmd | Failed: Network error: Not Found
✗ [ERR] file:///Users/ericscott/Documents/GitHub/group-procedures/_book/vignettes/contributing.qmd | Failed: Cannot find file

[./_book/annual-reviews.html]:
✗ [404] https://hr.arizona.edu/supervisors/performance-management/performance-feedback-faqs | Failed: Network error: Not Found
✗ [404] https://hr.arizona.edu/sites/default/files/UACareerConversation%20Form.docx | Failed: Network error: Not Found
✗ [404] https://hr.arizona.edu/sites/default/files/SMART-Goal-Setting-Template.pdf | Failed: Network error: Not Found
✗ [404] https://hr.arizona.edu/sites/default/files/Career%20Conversations%20in%20a%20Remote%20Setting.pdf | Failed: Network error: Not Found
✗ [404] https://hr.arizona.edu/sites/default/files/hr/forms/HR-Conversations/UACareerConversationGuide.pdf | Failed: Network error: Not Found

[./_book/outreach-communication.html]:
✗ [ERR] https://www.labsexplorer.com/c/twitter-and-scientists-a-love-story_185 | Failed: Network error: error sending request for url (https://www.labsexplorer.com/c/twitter-and-scientists-a-love-story_185)
✗ [401] https://docs.google.com/document/d/1LIxkktiP219_Xd24vXpgA1Qz7j7WcuRORtN26p2Qujw/edit | Failed: Network error: Unauthorized
✗ [ERR] https://bcf.arl.arizona.edu/news | Failed: Network error: error sending request for url (https://bcf.arl.arizona.edu/news)
✗ [404] https://datascience.cct.arizona.edu/all-news | Failed: Network error: Not Found

[./_book/regular-meetings.html]:
✗ [401] https://docs.google.com/spreadsheets/d/1k4B59FdpGxAd2sNrgbXRLrYIVgcxjvnYF5yJoaIcOAA/edit?usp=sharing | Failed: Network error: Unauthorized
✗ [404] https://github.com/orgs/cct-datascience/projects/9 | Failed: Network error: Not Found
✗ [404] https://github.com/orgs/cct-datascience/projects/7 | Failed: Network error: Not Found

[./_book/general-info.html]:
✗ [422] https://keating.bio5.org/ticket_support/tickets.php | Failed: Network error: Unprocessable Entity

[./_book/onboarding.html]:
✗ [ERR] file:///Users/ericscott/Documents/GitHub/group-procedures/_book/stache.arizona.edu | Failed: Cannot find file
✗ [401] https://docs.google.com/spreadsheets/d/1N95GgtAgvpQ9PhpiYwqWYewWu-FOzeIoQxzX2oldUuk/edit?usp=sharing | Failed: Network error: Unauthorized
✗ [404] https://github.com/orgs/cct-datascience/projects/7 | Failed: Network error: Not Found
✗ [404] https://github.com/orgs/cct-datascience/projects/8 | Failed: Network error: Not Found
✗ [403] https://hackmd.io/team/cct-datascience?nav=overview | Failed: Network error: Forbidden
✗ [401] https://docs.google.com/spreadsheets/d/18ANZGFdBHBU8l9WbFTE0fErcCaTva3LyazuhAex4FFE/edit#gid=129820665 | Failed: Network error: Unauthorized

[./_book/vignettes/publishing-to-web.html]:
✗ [404] https://datascience.arizona.edu/analytics-powerhouse/rstudio-connect | Failed: Network error: Not Found
✗ [404] https://github.com/cct-datascience/group-procedures/blob/main/vignettes/publishing-to-web.qmd | Failed: Network error: Not Found

[./_book/incubator.html]:
✗ [404] https://github.com/orgs/cct-datascience/projects/7 | Failed: Network error: Not Found
✗ [ERR] https://casrai.org/credit/ | Failed: Network error: error sending request for url (https://casrai.org/credit/)

🔍 2121 Total (in 7s) ✅ 1976 OK 🚫 57 Errors 💤 87 Excluded
💡 There were issues with GitHub URLs. You could try setting a GitHub token and running lychee again.%

That is...a LOT of broken links 🚨

Yeah, I suggest we merge #78 and then fix the broken links in a separate PR.


[Configure] A more versatile az configure

az configure currently only supports setting and listing the default section:
> az configure -h

Command
    az configure : Manage Azure CLI configuration. This command is interactive.

Arguments
    --defaults -d      : Space-separated 'name=value' pairs for common argument defaults.
    --list-defaults -l : List all applicable defaults.  Allowed values: false, true.
    --scope            : Scope of defaults. Using "local" for settings only effective under current
                         folder.  Allowed values: global, local.  Default: global.

For other sections described in Azure CLI configuration, users will have to manually edit the ~/.azure/config file, like
[core]
collect_telemetry = no
no_color = yes

[logging]
enable_log_file = no

This is inconvenient.
To improve the user experience, az configure needs to

Support set, get and unset
Support sections other than default

Did a quick evaluation: https://github.com/jiasli/azure-cli-spec/blob/master/az-configure.md
Hope it brings more ideas.

add to S171

az configure can set the properties in the core/logging section, but it is interactive mode so that it is not script friendly.

az configure show only shows what has been set, right? Then we can add az configure list-available command to show all the options that can be configured to increase their publicity.


Not working correctly in IE 8

When I open my site in IE 8, it gives an error -  " 'target' is null or not an object error.  Line 4 Char: 217."
I am using latest version of tap.min.js.

if this issue is not gonna be fixed, should we close it?

@xipengyang @pukhalski :+1: for closing.


buildbot: 3.7.0 -> 3.8.0

Description of changes
Updates buildbot to the latest version: https://github.com/buildbot/buildbot/releases/tag/v3.8.0
Closes #228784
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

#229521


fix nag pfio test

When mAPL is built by Nag in debug mode, pfio test failed. This PR is trying to fix the crash.
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[ ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[ ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

The changes here have been directly pushed . closed.


The discord invite url is expired.

Is there a new link?

hi, thanks for reporting, we have updated the link in the readme.


NavLink doesn't work with react-redux

if react component connect redux, NavLink 's active doesn't work

@ppeerit did you solve this?

yes, just like this
const SidebarComponentWithRouter = withRouter(SidebarComponent)
and use it as normal component
<SidebarComponentWithRouter/>


zfs: Improve import handling

Motivation for this change
Addresses https://github.com/NixOS/nixpkgs/issues/42178
This is a big sledgehammer, but it should be a reasonably safe sledgehammer: Use the ZFS tools to check if the pool is importable as ONLINE (as opposed to DEGRADED), and if not, sleep. It does cause serious performance degradation, but in practice that means adding another second or two to boot time, worst-case.
What I don't like, and which I can't find a cause for, is that this also increases the size of a ZFS-enabled initrd from 12 to 120 MB. By examination, this is because it ends up including all of ncurses, the glibc headers, and so on and so annoyingly forth.
I don't know why. The only added dependency is gawk, which only depends on glibc, which is already in the initrd.

...nope, busybox awk has the same problem. I'll get back to this when I'm more awake.

###### Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
   - [x] NixOS
   - [ ] macOS
   - [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

---

I've tested this manually, by restarts with a machine in various stages of (ocassionally non-)degradation. I haven't been able to test degradation of the root device, as I only have a single NVMe root disk, but I see no reason why that should fail.

Probable output when no devices are broken:
-- Logs begin at Sat 2018-06-16 01:41:18 IST, end at Tue 2018-06-19 20:59:04 IST. --
Jun 19 20:53:44 tsugumi systemd[1]: Starting Import ZFS pool "stash"...

Got it. It's obvious in retrospect; I'd replaced the carefully copied zpool binary with a direct reference to the zpool package. That bloat never had anything to do with awk at all.
Now it's good.

Anything else that needs doing?

@GrahamcOfBorg test installer.zfsroot

@woffs can you test the import service? I only have zfs as a root pool.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: tests.installer.zfsroot
Partial log (click to expand)
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/nixos/release.nix:30:25, called from /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/lib/attrsets.nix:199:52:
while evaluating 'hydraJob' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/lib/customisation.nix:162:14, called from /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/nixos/release.nix:30:28:
while evaluating the attribute 'drvPath' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/lib/customisation.nix:179:13:
while evaluating the attribute 'drvPath' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/lib/customisation.nix:146:13:
while evaluating the attribute 'buildCommand' of the derivation 'vm-test-run-installer-zfs-root' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/pkgs/stdenv/generic/make-derivation.nix:170:11:
while evaluating the attribute 'testScript' of the derivation 'nixos-test-driver-installer-zfs-root' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/pkgs/stdenv/generic/make-derivation.nix:170:11:
while evaluating 'isFunction' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/lib/trivial.nix:213:16, called from /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/nixos/lib/testing.nix:104:12:
while evaluating 'testScriptFun' at /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/nixos/tests/installer.nix:68:19, called from /var/lib/gc-of-borg/nix-test-rs-21/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-21/nixos/tests/installer.nix:267:20:
Non-EFI boot methods are only supported on i686 / x86_64

Success on x86_64-linux (full log)
Attempted: tests.installer.zfsroot
Partial log (click to expand)
machine# [    6.627932] systemd-shutdown[1]: All loop devices detached.
machine# [    6.628714] systemd-shutdown[1]: Detaching DM devices.
machine# [    6.630723] ACPI: Preparing to enter system sleep state S5
machine# [    6.631594] reboot: Power down
collecting coverage data
syncing
test script finished in 468.35s
vde_switch: EOF on stdin, cleaning up and exiting
cleaning up
/nix/store/q9mkir8x3i29ffy2j7xlnmah9m0md04y-vm-test-run-installer-zfs-root

@Mic92 I applied 1f50c87c83d0c46a11d44958f59bd408db74bbc2 onto nixos-18.03-small and rebooted. It worked, the pool (consisting of 24 devices) was cleanly imported.

@Baughn can you re-add data pool encryption support?

@woffs you could open a new pull request on top of this one.

I can try updating this one, but it's problematic rebasing it on top of unstable -- I don't run unstable on any of my computers, anymore. Perhaps I should.

I rebased it. It might work. But at the moment unstable doesn't build, so we'll never know.

I was able to test it. It seems to work...

This seems to cause a 2min 25secs downtime for me when booting my notebooks from mirrored SSDs
https://github.com/NixOS/nixpkgs/issues/43797


Window Issue, border bleeding onto second monitor

Issue Type: Bug
I have a 2nd monitor extended when VS Code is maximized the border bleeds on to the second monitor by 1px. This only occurs with this application.
Expected Results
Window border should not bleed onto second monitor and only be visible in the retained screen.
VS Code version: Code 1.48.2 (a0479759d6e9ea56afa657e454193f72aef85bd0, 2020-08-25T10:13:11.295Z)
OS version: Windows_NT x64 10.0.19041

/duplicate of #85310

My bad.


Fixup develop

Explain your changes:

Fixup https://github.com/MinaProtocol/mina/pull/14035
Related snarkyjs and snarkyjs-bindings: https://github.com/o1-labs/snarkyjs/pull/1105 and https://github.com/o1-labs/snarkyjs-bindings/pull/135

Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me

!ci-build-me


Add support for external rules

With this I could build standard-readme as a semantic rule checked by mdast-lint.
I think about smth like this:
{
  "standard-readme": true
}

or even with customization:
{
  "standard-readme": {
    "optional-blocks": ["badges", "reference"]
    "order": ["heading", "badge", "description"]
  }
}

First: loading extra rules wouldn't be very hard. I’ll just require('standard-readme'), and expect it to expose an object of ruleId’s to rules.
Then, every rule could define the options it accepts.
So, to me, something like this fictional .mdastrc could work:
{
  "plugins": {
    "lint": {
      "external": [
        "standard-markdown"
      ],
      "maximum-line-length": 60,
      "some-standard-markdown-rule": false
    }
  }
}

But an alternative would be the following:
{
  "plugins": {
    "lint": {
      "external": {
        "standard-markdown": {
          "some-standard-markdown-rule": false
        }
      },
      "maximum-line-length": 60
    }
  }
}

However, this setup (just a rule object as exports) would not support plug-in specific settings...

I would opt for the first version, as same names imply same rule.
At edge-cases we can still prefix.
So every external rule is configurable at the level where lint rules currently are.
For me this makes most sense, and keeps the nesting kinda flat.
Is there currently anything that restricts plugin options to bool/string?
Following would be nice as customization to external rules:
{
 "plugins": {
   "lint": {
     "external": [
       "standard-markdown"
     ],
     "maximum-line-length": 60,
     "standard-markdown-optional-blocks": ["badges", "reference"]
   }
 }
}

Rules can receive anything. Only the settings relating to reset (null, undefined, false, and true) have an extra meaning (hiding or showing the messages).
Still, as i explained earlier, all rules are run regardless of value, and receive that value as a third argument.

I agree btw that your example looks good :)

@zcei Hmm, I’m still missing one part, how about the JS API, something like this?
var mdast = require('mdast');
var lint = require('mdast-lint');
var standard = require('mdast-lint-standard');

var processor = mdast().use(lint, {
  'external': [standard],
  'maximum-line-length': 60,
  'standard-markdown-optional-blocks': ['badges', 'reference']
});

I'd rather have the plugin configured befure:
var mdast = require('mdast');
var lint = require('mdast-lint');
var standard = require('mdast-lint-standard');

standard.optionalBlocks(['badges', 'reference']);

var processor = mdast().use(lint, {
  'external': [standard],
  'maximum-line-length': 60
});

Then you can easily reuse some parts without fuzzy work with removing the configuration values from the object.
For the .mdastrc (not sure whether we need yet another .*rc) it's more "long-living" than for code, so for me it's better to stick to our consensus from above there.
But then, having two different styles in .*rc and API is kinda ugly.
Thoughts on this?

To be consistent in the example:
var mdast = require('mdast');
var lint = require('mdast-lint');
var standard = require('mdast-lint-standard');

standard('optional-blocks', ['badges', 'reference']);
standard.optionalBlocks(['badges', 'reference']);

lint('maximum-line-length', 60);
lint.maximumLineLength(60);

lint('external', [standard]);
lint.external([standard]);

var processor = mdast().use(lint);

TBH I’d rather not add much difference to the CLI/API. Especially the boilerplate needed for many getters/setters seems unnecessary to me!
In addition, the above setters all set options on the global standard object, which wouldn't work well for different settings for different files, and when other tools use standard.
Why not just use JSON when possible for settings?

Guess you're right - there is no negative argument I could provide against your provided solution.

Alright :) however, it's your plugin, so you can do whatever! But this system is already in place so it'd be less of a hassle!

Err.. what kind of community are we in here? :)
Your arguments are reasonable, and in no intention harmful to me, so of course I'm interested in what others think about.
And due to its intention to serve as a standard for the community there is no "do whatever you want", more like "do whatever everyone wants" :dart:


Add Devcontainer Support

Is your feature request related to a problem? Please describe.
I would like to propose adding devcontainer support to the Spring Cloud Commons repository. Currently, setting up the development environment can be cumbersome for new contributors, leading to inconsistencies and potential issues across different machines.
Describe the solution you'd like
I propose adding a devcontainer.json configuration file to enable developers to easily set up a consistent development environment using Visual Studio Code's Remote Development feature. Here is a basic example of what the devcontainer.json file
Describe alternatives you've considered
I don't find any alternative solutions but with this setting up and running the project will be quick and easy.
Additional context
Adding devcontainer support would simplify the onboarding experience for new developers and ensure a consistent development environment. I believe this enhancement would be beneficial for both current contributors and future ones.

In setting up a development environment to contribute to the Spring Cloud Commons project. I faced few challenges Here are some of those and added some more hypothetically
Incomplete  Documentation
The README file does not generated properly https://github.com/spring-cloud/spring-cloud-commons
Test Setup
Understanding how to run tests effectively and interpret the results
Environment Configuration / dependency
I don't find any idea on how to configure the environment and tools required mostly related to first point
Tools Version changes
With change of java version / other tools and compatibility it will be easier to switch if we using this approach

The README file does not generated properly https://github.com/spring-cloud/spring-cloud-commons

We can fix this that.

Understanding how to run tests effectively and interpret the results

These will be run as part of the maven build.

I don't find any idea on how to configure the environment and tools required mostly related to first point

That should be made clean once the README is fixed
https://github.com/spring-cloud/spring-cloud-build/blob/main/docs/modules/ROOT/partials/contributing.adoc

With change of java version / other tools and compatibility it will be easier to switch if we using this approach

Meaning you need to change Java versions on your machine?
`

Yes Switching java versions for different projects managing through IDE but dev container will work with code space and all for quick fixes

I have fixed the readme that that should make things easier.
I don't think we are going to use dev containers.  If the instructions in the readme are not clear please open a separate issue so we can address it.

I know that this is not in priority or not in the roadmap but I believe some key value additions that can be brought to our ecosystem. can I start work on this based on my availability?

You can submit a PR but like I said above and I can discuss with the team if it is something we would like to incorporate, but I would not count on us merging it if we feel like supporting it and maintaining it adds more work in the long run.


Lacking step for terminal to display colors in BASH or the default shell for the Terminal App

Lacking step for terminal to display colors in BASH or the default shell for the Terminal App. To be helpful, instructions should mention that Users (using 10.13.4 or later), should run:
export PS1="\[\033[36m\]\u\[\033[m\]@\[\033[32m\]\h:\[\033[33;1m\]\w\[\033[m\]\$ "
export CLICOLOR=1
export LSCOLORS=ExFxBxDxCxegedabagacad
alias ls='ls -GFh'

Please see #2, #3, #4, #7, etc.
The colorscheme is meant to change the colors the Terminal uses to highlight text. It is up to the user to create/use colored prompts and commands with colored text.
Additionally, installation instruction issues belong in the repo for the site (dracula/dracula.github.io)—the screenshot is using a custom zsh prompt anyway, not bash, so you’re instructions are not pertinent to all users (zsh uses %-escapes in its prompt string).
Again, by my read, this falls into the user domain of customization. We just provide the color palette.


Add retry to GrpcStore.

The GrpcStore does not currently perform any retrying on failure.  This
is contrary to the S3Store that does.  This causes issues when the upstream
is under heavy load.
Implement retry in the same manner as the S3Store in the GrpcStore.  No
retry is implemented for write, the same as the S3Store, as this would
require buffering of the file data which is not easily possible.

This change is

cas/store/grpc_store.rs line 150 at r2 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
nit: I think you can do this without needing to make a copy of request. Something like:
self.perform_request((), |_| {
  let request = &request;
  async move {
    // `request` at this point is borrowed.
  }
});

Can't borrow it because Request::new requires a full instance, so we end up cloning there instead.


Error running on mac after install

After installing on mac and running cs251tk, I get the following error:
Traceback (most recent call last):
  File "/Users/Hannes/Library/Python/3.7/bin/cs251tk", line 11, in <module>
    load_entry_point('cs251tk==2.5.1', 'console_scripts', 'cs251tk')()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pkg_resources/__init__.py", line 480, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2693, in load_entry_point
    return ep.load()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2324, in load
    return self.resolve()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2330, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/Users/Hannes/Library/Python/3.7/lib/python/site-packages/cs251tk/toolkit/__main__.py", line 18, in <module>
    from ..webapp import server
ModuleNotFoundError: No module named 'cs251tk.webapp'

Any ideas?

It looks like pip isn't including that module for some reason. Any ideas @hawkrives?

How is the SOURCES.txt file in cs251tk.egg-info created? That seems to include all the files except the ones in webapp.

Is it possible that an init.py is required in the webapp package?

No idea. Python packaging has always been a black art to me.
I can take this on and try to investigate.
All the egg stuff is generated by setup.py invocations, for what it's worth.

Yup. It's the init.py. When python3 setup.py sdist bdist_wheel is called, it only includes the package if there is a init.py there. I tested with test.pypi.org and it worked.


Support ddof = 0 for rollingStd

First of all, thank you for the awasome library with Typescript support.
Describe your feature request
The rollingStd function should optionally accept a parameter called ddof that can be set to 0. This is necessary for calculating the population standard deviation.

nodejs is using rs-0.32 which is behind the Python release stream.
Once we upgrade to rs-0.34 we can look into adding this option.


Upgrade AngularJS and UI-Bootstrap

Upgrade AngularJS and UI-Bootstrap to reasonable recent versions.

AngularJS 1.5.3 (not the most recent version, but what UI-Bootstrap has been tested with)
UI-Bootstrap 1.3.3

The original reason behind this was to get tooltips working again (see #887), but I also fixed the comment popups in the prefix list. In addition to this I did some cleanup among the JavaScript libraries and made sure we use minified versions of the libraries.
To get tooltips with HTML working with the new versions I had to disable the Strict Contextual Escaping-feature of AngularJS, see 79b5912 for more details. As a consequence to this it became apparent that NIPAP is vulnerable to an XSS attack where a user could insert elements into the DOM by crafting tags with HTML in them.I've greated #937 to handle this issue.

I can't review this code. Can only take a look at the result, i.e. look at the UI in a web browser. An idea that I just got around this.. wouldn't it be sweet if we could build docker container for every PR and could ask the nipap-demo machine to spin up a set of containers so it's easy to try out... or maybe I'm thinking too much about something that isn't that hard to try out today. Docker container images would be sweet regardless...

I agree, this is pretty difficult to review. Spinning up a docker container so the web interface can be manually tested easily is an excellent idea. Sure, it's not very difficult to fetch the PR branch and perform tests locally, but automating it would lower the barrier.
We should also look into introducing unit tests for the parts of the web interface which can be tested. After all that's something which is put forward as a strength with AngularJS.

So it seems our psutil changes have made nipapd incompatible with Ubuntu 14.04 LTS. I think this is fine since 16.04 LTS is out but since my dev laptop is 14.04 it poses a slight challenge to me. Need to upgrade or build containers...

You know how trying to fix one problem leads to finding another problem and in trying to fix that problem you.. yeah, you get it.
I wanted to run this. I couldn't on my current dev env. So I wanted to put it in a docker container, which would be really sweet in lots of ways.. but to do that I wanted to fix a few other things, like #947. I think after #947 I can post some Dockerfiles so that I will be able to run everything in docker and thus I can test this :)

Yay @houndci-bot doing it's best not to be very helpful at all. Lemme see if I can docker the shit out of this PR =)

Neither the prefix comment or any other tooltips (I can't really remember where they are) are working for me :/ Tested using Chrome on Mac OS X with nipap-www served through docker.

My bad yo. Though I'd be clever and tag the image I built for this and then I failed to use the docker compose file I had updated with the tag.
Now that I really tried it out: This thing is working beautifully! LGTM et al. Will merge.


Adas empty

Why adas module has adas.cpp and its header empty? We have also got many stability issue on training varying samples size, number of feature and weak counter.

I have a similar question with regard to the use of Integral Channel Features for object detection. My goal is to use it for car detection on highways. Having obtained a nice dataset I am training the classifier using ICF but unfortunately I am also experiencing that the detector is highly unstable to the parameters (feature_count, weak_count). My original question was posted over here: http://answers.opencv.org/question/56263/integral-channel-feature-detector-for-cars-bad-results/ but I got the advise to try here as well :-)
Does anyone have some good ideas of how to set the parameters?

The adas module has been removed during latest GSoC, thus considering issue invalid.


Modify macOS ots-sanitize installation documentation

This PR modifies the homebrew-based ots-sanitize installation documentation for the macOS platform. It changes the recommended approach to a curl pull of the compiled binaries from Khaled's ots repository releases with a manual move of ots-sanitize to the /usr/local/bin directory so that it is accessible on the system PATH for Font Bakery testing.  This achieves a faster install c/w the homebrew process (eliminates the compile on the user system) and it allows users to install the current release version of ots-sanitize which is not currently supported through homebrew.
Associated issue reports:

https://github.com/googlefonts/fontbakery/issues/2041
https://github.com/googlefonts/fontbakery/issues/2057

I am a bit worried that this will require constant maintainence as we're suggesting version-specific install instructions here. But I can see how this is a bit better than what we currently have, which is completely broken.

it would be good, though, to have some sort of more permanent install instructions that can remain good eve after an OTS version bump.

@felipesanches thoughts about a make based install process for macOS and Linux?  That could be maintained with make targets to keep dependencies both pinned where you want them and move to new versions when tested and ready.  It would not work for the proprietary software that is included but those are optional installs.

There are upsides and downsides to letting users stay always current with cutting edge releases of your dependencies.  They may be picking up new features but they may also be breaking something in the FB testing that you haven't had time to anticipate.

There is also the fact that python is a runtime environment while homebrew requires xcode/a compiler and a dev environment. Not every user wants to install all of that. In fact few do.


Update travis

Use stable version of grpc pecl package
Force travis to use PHP 5.5.38

Current coverage is 89.30% (diff: 100%)

Merging #37 into master will not change coverage

@@             master        #37   diff @@
==========================================
  Files            16         16
  Lines          1113       1113
  Methods         120        120
  Messages          0          0
  Branches          0          0
==========================================
  Hits            994        994
  Misses          119        119
  Partials          0          0

Powered by Codecov. Last update deebfc0...959ca00

LGTM


Installation Guide does reference packages that doesn't exist

There are references to hip and hip3.5.0, such thing doesn't exist.
My guess there is hip-base ?

Hi @baryluk
Thanks for reaching us.
Can you please elaborate your query.

I don't know, that was 6 months ago. There were some weird tables and stuff on the https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html

You are correct, @baryluk. The ROCm documentation is evolving, and we are constantly updating the content and website. We recommend that you review the documentation/webpages periodically for corrected and updated ROCm content.
As always, we welcome your constructive and timely feedback.

Going to close it. If I find this issue again, or remember where it was and it is still there, I will reopen or something

Thanks @baryluk for your update.
Request you to file a new ticket anytime in future.
Thank you.


Cannot parse mjml string if node process has no permissions on current directory

If the nodejs process has no permission to read the current directory, parsing an MJML string fails. Simple script :
require('mjml')('<mjml></mjml')
Put this in /home/test-user/test.js. Switch to root, then do
cd /root; sudo -u test-user node /home/test-user/test.js
This fails with :
Error: Specified filePath does not exist
    at MJMLParser (/home/test-user/node_modules/mjml-parser-xml/lib/index.js:85:13)
    at Object.mjml2html [as default] (/home/test-user/node_modules/mjml-core/lib/index.js:193:42)
    at main (/home/test-user/send-alerts.js:173:48)

Moreover, mjml will complain being unable to read its configuration file (but this is not a fatal error) :
Error reading mjmlconfig :  Error: EACCES: permission denied, open '/root/.mjmlconfig'
    at Object.openSync (fs.js:461:3)
    at Object.readFileSync (fs.js:364:35)
    at readMjmlConfig (/home/test-user/node_modules/mjml-core/lib/helpers/mjmlconfig.js:30:48)
    at handleMjmlConfig (/home/test-user/node_modules/mjml-core/lib/helpers/mjmlconfig.js:135:25)
    at Object.<anonymous> (/home/test-user/node_modules/mjml-core/lib/index.js:410:28)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Object.<anonymous> (/home/test-user/node_modules/mjml/lib/index.js:10:41)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14) {
  errno: -13,
  syscall: 'open',
  code: 'EACCES',
  path: '/root/.mjmlconfig'
}

Will be a bit hard to fix, maybe if we can just ignore filePath option if mj-include is disabled @kmcb777 ?

@iRyusa for the filePath i agree that it would be the best solution
concerning .mjmlconfig, i think we should just handle this case as if no mjmlconfig file has been found, it shouldn't be blocking anyway, what do you think ?

Speaking as a user, what weirded me out is mjml trying filesystem accesses when nothing in my code used any file. Had I used includes, I would not have considered as a bug that access to current working directory was required.
If I read the code right (https://github.com/mjmlio/mjml/blob/master/packages/mjml-parser-xml/src/index.js#L44), the error comes from resolving cwd, which is only used by handleInclude. Why not move the cwd resolution inside handleInclude ?

unfortunately cwd is also used in the parsing to determine absoluteFilePath, but this one is only used for validation errors messages so we don't need to try to read it
so what we could do is assume that filePath is a dir in the first place because there is no risk doing this, and only in handleInclude determine if it's a directory

Speaking as a user, what weirded me out is mjml trying filesystem accesses when nothing in my code used any file. Had I used includes, I would not have considered as a bug that access to current working directory was required.

Yep, I think mj-include shouldn't be part of mjml parser but there's no way to fully replace them "on the fly" sadly. Even if it's a convenient feature for users, it should be handled with a templating language (imo, it would support, layout, include & other stuff) but now that's here and a lot of developer are using it, we can't really do something about it.

I think we did solve this one by wrapping the mjmlconfing in a try catch https://github.com/mjmlio/mjml/blob/43b164b3f5095169ea301b5f68c7e5bdab6d4a5e/packages/mjml-core/src/helpers/mjmlconfig.js#L7
Please reopen if needed


Cherry-pick: Emit source maps for wasm in flutter build web --wasm (#151643)

This will make

flutter run have source maps enabled by default
flutter build have source maps disabled by default

which mirrors what happens already today with the js compilers.
For local development this works quite well - even better than with dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler, see [1]
[0] flutter/flutter/issues/151641
[1] dart-lang/sdk/issues/56232

The PR can land once the current dart-lang/sdk@stable was rolled upstream into engine & framework stable branches.

@itsjustkevin When I git checkout origin/stable; git cherry-pick ... I didn't get any merge conflicts. How come the presubmit checks above say there's conflicts? Do we have to make cherry-pick requests based on another branch, not origin/stable?

I guess it has to be flutter-3.24-candidate.0.
=> https://github.com/flutter/flutter/pull/153310


RC6 Error: Generic type 'Type' requires 1 type argument(s)

v.0.7.0
this error is in:
\node_modules\ng2-bs3-modal\ng2-bs3-modal.d.ts

+1

same error. it seems the npm version does not get updated.

Hey all, I just published v0.8.0. Give that a try and lemme know what happens.

cool -- i'm going to test in a few hours.

Fast question,
How can i get the last version ?
When I type npm install ---save ng2-bs3-modal I get the version with rc4

Hmm... that should do it, depending on your npm version I guess. Try updating your package.json manually to ^0.8.0.

For the record
npm version 3.10.3
and that works!

@curlyfro success?

sorry -- i haven't check yet.  checking now.  give me 30mins.

cool -- it works!

@curlyfro, awesome. Thanks for the followup.


Feature request: Please consider a change similar to #189 for allowing executable checking to work in more diverse contexts

I understand the sentiment not to want to build in bug fixes for other entities' software, but I would like to make an appeal to accommodate a change similar to #189, originally authored by @geeky-smurf, albeit a slightly different approach.
Two different, but overlapping permission checks is not inconsistent with pre-commit.
@geeky-smurf's approach was quite elegant in that it does very nearly what the existing code does in precisely the same place. It's almost just as readable. There's no "if running in Docker" or "if running on MacOS" nonsense. It's using proximal primitives in an intended way.
It's understandable you wouldn't want to lose or replace the os.access(path, os.X_OK) check. In that case, there's a tweak worth considering:
executable = os.access(path, os.X_OK) or \
    os.stat(path).st_mode & stat.S_IXUSR  # no need to check group or other bits

That would allow the nuances of os.access to persist, but fall back to looking for executable permissions in @geeky-smurf's alternate way. Again, it's almost just as readable. Any impact to maintainability should be slight, if not negligible.
pre-commit is already using a proxy for the intended source of truth: the Git index.
pre-commit is looking to the filesystem as a proxy to checking whether Git thinks the files are executable. Strictly speaking, it's already compromising on that front. What it's really after is something like git ls-files --stage <path> …. Most of the time, the filesystem permissions are in concert with this value, but not always. Git is the source of truth. Expanding os.access(…) to inclusively check os.stat(…).st_mode gets closer to that on more systems than either standing alone.
The corresponding Docker issue is not easily dismissible as a bug. It's a deliberate tradeoff, and accommodating it may enhance pre-commit's utility in architectures beyond Docker on OS X.
@djs55 has a decent write up here. The short version is that, when running on OS X, Docker affords access to the host filesystem using FUSE as an intermediary, which also makes tradeoffs of complete executable permission detection and performance.
Docker is probably the most popular place this comes up, but it could come up elsewhere. The likelihood of encountering another case only increases as pre-commit gains popularity.
Being flexible on ferreting out the executable status improves usability without compromising correctness, which only serves pre-commit and its users.
To my knowledge, doing a os.access(…) or os.stat(…).st_mode & … is not over broad. In other words, I don't think the change will all of a sudden start identifying non-executable files as executable. Assuming that's correct, then such a change doesn't lead to correctness issues that take away from pre-commit's value. However, by adding the change, pre-commit becomes a smidge more flexible on systems where this problem might occur, which is of value to a greater audience of users.
If #189 does not appeal to you, please consider my proposed alternative.
If you are amenable, #290 is now up for your review. Thank you very much for your time and consideration.

@asottile, I understand you don't want to accept this, but can you offer some insight as to why?

there's several duplicates which answer that -- please search the issue tracker next time


String literals don't properly narrow with if cond or (literal == "")

local literal: "a" | "b"
local separateCond = ...

if separateCond or (literal == "a") then
	if literal == "b" then -- Type error, "a" cannot be compared with "b"
		print()
	end
end

This shouldn't error, because literal isn't guaranteed to be "a", it could be "b" due to the separateCond condition in the if statement.

Tweaked the example to be more obviously a bug (as separateCond value is arbitrary)


Newgrounds Rip doesn't work anymore

When I try to download from newgrounds, the ripper doesn't find anything in the galleries.
Links I tried:
https://cutenikechan.newgrounds.com/art
https://intrastele.newgrounds.com/art
https://sony-shock.newgrounds.com/art
other links also doesn't work.
I'm using the latest version of RipMe: v.1.7.95

please check here: https://github.com/ripmeapp2/ripme/releases


Empty schema {} causes validation failure

Currently If the schema contains empty schema {} the validation fails.
"properties": {
  "anyOf": [
    {
      "items": {
        "properties": {
          "name": { "type": [ "null", "string" ] },
          "value": { "type": [ "null", "string" ] }
        },
        "type": [ "null", "object" ]
      },
      "type": [ "null", "array" ]
    },
    {
      "properties": {},
      "type": ["null", "object"]
    }
  ]
}

In the code above "properties": {} will cause failure

@RuslanBergenov this might have been solved by your latest schema fixes.
As discussed, let's put a schema validation phase before converting to BQ schema.

@RuslanBergenov this might have been solved by your latest schema fixes.
As discussed, let's put a schema validation phase before converting to BQ schema.

This is not a bug. Catalog Files need to be completely and entirely defined.  BigQuery requires a properly defined schema to accept data and the only way to do that is to parse the catalog file into a BigQuery Schema object. The catalog files often have gaps, you’ll need to dig into the tap output or tap source API documentation  and properly define every field in the catalog. Make sure the data type is correct as well. Oftentimes these catalogs don’t switch timestamps to date-time. It’s frustrating, but in the end will lead to better data in your warehouse.
We're working on a feature to detect incomplete schemas in the catalog file at the start of a run.

This is not a bug. Catalog Files need to be completely and entirely defined.  BigQuery requires a properly defined schema to accept data and the only way to do that is to parse the catalog file into a BigQuery Schema object. The catalog files often have gaps, you’ll need to dig into the tap output or tap source API documentation  and properly define every field in the catalog. Make sure the data type is correct as well. Oftentimes these catalogs don’t switch timestamps to date-time. It’s frustrating, but in the end will lead to better data in your warehouse.
We're working on a feature to detect incomplete schemas in the catalog file at the start of a run.


fix for scope saving

Fixes #48, #630
It's a sniping-at-years-old-bugs Friday!

Thanks for your work :).

Good to go?


Possibility of infinite loop when waiting for missing metrics to appear

When using InstrumentedRunnable.WaitSumMetricsWithOptions(...) together with e2e.WaitMissingMetrics() it's possible that tests get stuck forever because of this loop.
It would be great to have a safety mechanism to timeout the wait. It helps avoid long running CI jobs, which can be $$$ friendly.

Yes, this is a good catch, I think it would make sense to do metricsWaitBackoff.Wait() here as well - even if metric is missing, we should be counting this towards the total number of retries.


adding OVERPASS_TIME & OVERPASS_SPACE

you recently add OVERPASS_RATE_LIMIT and it will be great to also add OVERPASS_TIME & OVERPASS_SPACE like i do in commit 674e428 on my repo.
i need to use them like explain here :
https://listes.openstreetmap.fr/wws/arc/overpass/2016-08/msg00001.html
Thank you.

Thank you for your submission, I had to edit the commits, as there were some unresolved conflicts in your files.


Remove clause from 'DROP GRAPH clause'

All clauses under Clauses section don't have 'clause' after their name. Only DROP GRAPH has it. Remove it.

Also, clauses are put in alphabetical order, so keep the order as it should be

Also, as I commented on PR, should DROP GRAPH even be under Clauses?

I think that at the moment, Clauses is the best place to DORP GRAPH docs. I'll fix the other reported issues, but I'll leave the page where it is located at this point.


billing address not stored with customer/invoice

I'm using the client-server code with python and added billing_address_collection="required", to the server-side create checkout session code. With the payment form, the billing address is shown, but it is not stored with neither the customer nor the invoice.

Sorry for the delayed response! The billing address will be on the PaymentMethod attached to the Customer.

@cjavilla-stripe Hi, sorry to open the topic up again, but this leads to big issues.
The invoice created from a subscription through checkout does not contain the customer address. I think the reason is, that the customer created by stripe checkout does not have the billing address set, but only contains it on the PaymentMethod.
Do you have any proposal on how to fix it?

One option is to update the customer when you receive the checkout.session.completed event.

Thanks for the very fast answer, after looking through available events, I will try to do it this way:
if (stripeEvent.Type == Events.PaymentMethodAttached)
                {
                    var element = stripeEvent.Data.Object as Stripe.PaymentMethod;

                    var service = new CustomerService();
                    var customer = await service.GetAsync(element.CustomerId);
                    if (customer.Address == null)
                    {
                        var address = element.BillingDetails.Address;
                        await service.UpdateAsync(element.CustomerId, new CustomerUpdateOptions()
                        {
                            Address = new AddressOptions()
                            {
                                City = address.City,
                                State = address.State,
                                Country = address.Country,
                                Line1 = address.Line1,
                                Line2 = address.Line2,
                                PostalCode = address.PostalCode
                            }
                        });
                    }
                }

So when the first payment method is attached, I will apply the address to the customer.
Only question is if I'm fast enough, so that the update is done before the invoice is created and sent to the user. I just hope so and will need to check in Live-Mode, as in Dev Mode the email is not created.

Thanks for the update, @Phmager. Happy to hear this solution works for you.