[5.2] Add support for testing Eloquent model events

Currently, when testing one's application, you cannot check for eloquent events. The reasons for this are two-fold:

The mock used by expectsEvents / withoutEvents doesn't record until calls.
The event dispatcher is stored statically on the eloquent model and therefore doesn't update when the instance updates on the container.

Others have had issues with testing against model events as well (#12711) and this should fix those issues too.

I'll squash all the commits once/if everything is okayed.

Note: I also have a test that verifies that the mock isn't carried between test cases. if you feel that it would be useful to have, I'll commit it. It does use a hardcoded class name to detect the mock but the other option would be checking if the class name starts with Mockery_. Neither of which I like that much.

Report of this breaking things: https://github.com/laravel/framework/pull/13331

From a first glance it appears that more methods need to be mocked. Taking a look.

Actually, mocking listen (and forget since the Eloquent Model uses it as well) might break things depending on how things are being tested. Specifically Model Observers and custom model event listeners using Model::saved, Model::created, etc… break because listen isn't mocked and therefore doesn't exist. If listen is mocked it would probably break many more things that depend on it.
I'm a bit hesitant to suggest it but the only way around this (afaik) is using partial mocks.
cc @GrahamCampbell you have any ideas? I'm not aware of what you were testing but an example test that's broken that shouldn't be failing would be immensely helpful.

https://travis-ci.org/CachetHQ/Cachet/jobs/126048238
https://github.com/CachetHQ/Cachet/blob/2.2/tests/Api/AbstractApiTestCase.php#L30
This seems to be caused by my validation listener more specifically. It calls listen('eloquent.saving...', 'AltThree\Valida...'. The full stack trace is provided at https://github.com/laravel/framework/pull/13331.

This is the validation trait: https://github.com/AltThree/Validator/blob/master/src/ValidatingTrait.php.

Oh, I didn't even realize Cachet was open source. Yeah, just from looking it looks like a Partial mock might be the only decent solution but I'm not sure how well that would work out in practice. I'll work on this later this evening and use those for a testing baseline. Thanks!

Great. ;)

So, I haven't had a lot of time to work on this but I keep running into issues: The Mock has to be a partial of the actual dispatcher but it run's the code firing observer methods instead of skipping it as I thought they would. I guess I'm not sure how partial mocks work. A testing stub of the Event Dispatcher would likely get around the problem with observers but I'll need to try it to be sure.
Another potential solution I've thought of that would have the least potential for breakage is to introduce another test method: expectsModelEvents or expectsEloquentEvents. Thoughts?

I think a separate method could be useful.

Okay, cool. I'll redo the PR when I get home today.

@thecrypticace Did you ever make any more progress on this? Hitting the same brick wall and after following the flurry of commits and reverts I am now at the same position.

I did.  I wasn't 100% pleased on the way I had to write the tests for it but I just opened the PR anyway: https://github.com/laravel/framework/pull/14374


README: Update supported version section [ci skip]

This PR only updates the Ruby versions README section to include what's in the Travis matrix.

Great, thanks!

Hehe, well, Rubinius is no longer in the matrix.

Perhaps using the names which work for this project, you can add it back?
https://travis-ci.org/rubinius/travis-canary

@olleolleolle I removed it in the past because it would often fail to even install, and as a mini-protest to the current maintainer. But I'm definitely open to adding it back if it would have stable installs.

@janko-m If you're not keen on adding it to the CI matrix, I'd like to see it gone from the "supported versions" list. That would mean: It could work, but there's no on-going effort to keep it working.

Done


Warning: Failed context type: The context stripe is marked as required in Elements, but its value is undefined.

I've working on signup form which has 3 steps signup form and i am using redux-form wizard form, after submit first form it throws error:
Warning: Failed context type: The context `stripe` is marked as required in `Elements`, but its value is `undefined`.
Uncaught TypeError: Cannot read property 'elements' of undefined

Help needed with this issue, here is my code repo (https://github.com/yasharma/socialapp/tree/develop/src/components)

Main Component Register.js
Step 1 AccountSetUp.js
Step 2 Subscription.js
Step 3 Confirm Payment

As soon as code reached step 3 it throws error. I am using individual Element* to create my stripe form and then on form submit it called stripe.createToken(),
Need assistance and guidance on this

Thanks for reporting this and for the provided example!
I think due to the way reduxForm uses shouldComponentUpdate and does not take context changes into account.
To prevent this issue you can try to add the pure: false option to your reduxForm() call.
Also see  https://github.com/stripe/react-stripe-elements#troubleshooting for more details on that issue.
Please let me know if that fixes your issue!

Thanks @cweiss-stripe for correct reference, However even with pure: false problem is still there, sometimes when comes from another routes it throws error but sometimes not, i mean this is not complete solution, initially i think its fixed but i saw same error in console during development other things, when moves to that page but not every time. so what i think and i even test this with normal form without redux form, its working fine so i am going with that solution, until found something solid.


[twitch] New URLs for past-broadcasts, highlights and uploads

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.07.16
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.twitch.tv/spamfish/videos?filter=archives']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.07.16
[debug] Python version 2.7.15 (CPython) - Linux-4.19.57-gentoo-x86_64-AMD_Ryzen_5_2600_Six-Core_Processor-with-gentoo-2.6
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3, rtmpdump 2.4
[debug] Proxy map: {}
[twitch:stream] spamfish: Downloading stream JSON
ERROR: spamfish is offline
Traceback (most recent call last):
  File "/home/leo/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/home/leo/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/home/leo/bin/youtube-dl/youtube_dl/extractor/twitch.py", line 581, in _real_extract
    raise ExtractorError('%s is offline' % channel_id, expected=True)
ExtractorError: spamfish is offline

Description

It looks like Twitch changed its URLs for users's videos lists (ie. going from https://www.twitch.tv/user/videos/past-broadcasts to https://www.twitch.tv/user/videos?filter=archives).

Opened PR #21812


Fix gcc's warning/error when building with -Wmisleading-indentation

Hi,
I am having troubles when including "boost/test/unit_test.hpp" with gcc 6 and -Wall -Werror turned on. gcc (wrongly) complains about misleading indentation in the macro DEFINE_FPV_COMPARISON. This is likely caused by the fact that we have extra indentation after each line so that the backlslashes are properly aligned, and the macro is eventually putting this on a single line. Anyway, an easy fix is to use braces around all block of code.
Ok for the merge ?
(Similar to https://github.com/boostorg/spirit/pull/222)
Cheers,
Romain

Thanks, this is a duplicate of #103 that is already merged to a feature/check branch.

In develop


DEV-125: display toast on error response for adding courses

Description
If a user tries to add a duplicate course in the same semester, a toast error will be displayed and the course is not added.
Implementation
Works with DEV-125 branch on backend repo.
Each time the add course route is called on front end, toast is displayed if error is returned and prints error message.
Also, when adding prereqs, the error causes adding prereq mode to close.
Testing
Local testing done
attempted to add the same course (i.e. adding Gateway Python twice) which triggers toast

attempted to add courses with same number but different names (i.e. two different ProfComm classes) which is allowed

please run prettier with new changes from dev ^^ and the tests should pass;


improve epsagon integration

the epsagon integration could be done on each adapter target, or individually by the actions like today.
if it's done in the adapter, it would be transparent for the actions but also make it difficult to use different configuration.
if it's done in the actions, we need to create an universal-api epsagon integration, i.e. directly contributing to https://github.com/epsagon/epsagon-node. they restructured their api quite a bit, maybe it's possible to write an integration externally.

closing for now.


symlinkJoin doesn't work on WSL

Build 16257
Nixpkgs ghcWithPackages fails because symlinkJoin doesn't work. See https://github.com/NixOS/nixpkgs/issues/26506
To reproduce, install nix, then using nix try to install ghc with packages. For example:

curl https://nixos.org/nix/install | sh
echo "{}: {foo=(import  {}).haskellPackages.ghcWithPackages (h: [h.text]);}" > foo.nix
nix-env -f foo.nix -i -A foo

The following errors are produced:
installing ‘ghc-8.0.2-with-packages’
these derivations will be built:
  /nix/store/b8vq8x4zf7064k03br4arzwxq17q9ccn-ghc-8.0.2-with-packages.drv
building path(s) ‘/nix/store/6ngxwi2xpnzcivvkwiy78cjg09r9f1mc-ghc-8.0.2-with-packages’
.: File exists
..: File exists
.: File exists
..: File exists
lib: /nix/store/gyw8sz9pmg34hpwxs5rz1g90q8fvia3q-text-<IP_ADDRESS>/lib
share: /nix/store/gyw8sz9pmg34hpwxs5rz1g90q8fvia3q-text-<IP_ADDRESS>/share
rm: cannot remove '/nix/store/6ngxwi2xpnzcivvkwiy78cjg09r9f1mc-ghc-8.0.2-with-packages/bin/ghc': Permission denied
builder for ‘/nix/store/b8vq8x4zf7064k03br4arzwxq17q9ccn-ghc-8.0.2-with-packages.drv’ failed with exit code 1
error: build of ‘/nix/store/b8vq8x4zf7064k03br4arzwxq17q9ccn-ghc-8.0.2-with-packages.drv’ failed

I'm not about to install NixOS, but this is almost certainly #2229. Right now that issue is EWONTFIX. Which will have to be revisited eventually.

This bug is blocking me from effectively developing Haskell using Nix. (I'm on Build 16251)

I can't seem to find a reliable definition of what st_nlink means for a directory (if there is one, please share). The general words seem to suggest that the value can be relied on when > 1.
As @SvenGroot suggests in #2229, would it make sense to update LNDIR to take the sub-optimal path when the value of st_nlink is < 2?

The "reliable" definition is that it is the number of hard links to that directory inode. For a directory with one subdirectory, that number is three. One for the directory name (dentry) itself, say foo/. One for the . dentry alias of the inode. And one for the ../ dentry alias of the inode in the sub-directory. If the foo directory inode has two subdirectories, then there are two ../ dentries aliases for the that inode. And so on.
But note st_nlink does not indicate the number of subdirectories. For example, let's say you have an empty directory foo/ with two hard links to it 'bar/' and 'baz/'. st_nlink would be 4: foo/, ./, bar/, and baz/ all pointing to the same inode. The ./ and ../ dents aren't special. They are just hard links.
So when people say directory foo/ will have a st_nlink of at least 2 because of ./ and ../ they're just not correct. It is at least 2 because of foo/ and ./.
One thing that is interesting is that ntfs-3g on Linux I believe gets st_nlink right. I hesitate only because I don't have one handy atm to test, and I could be wrong. Might be worth a look-see.
Also check out this post from the Cygwin people (from 2008). You've tried 2. You've tried 0. I think maybe the number you are looking for is 1, failing doing whatever it is that ntfs-3g is doing.

@therealkenc - thanks for the explanation. I don't really see why 1 needs to be differentiated from 0, when both say the same thing "don't trust me". But, maybe, historically, some tools have differentiated these for whatever reason. I did a quick search for the source code for lndir, and if the source here is to be trusted, it looks like changing to 1 won't help.

Yeah, that looks about right. The only semi-constructive thing I could say would be making it '1' would make it bug-compatible with ntfs-3g. Would that make any practical difference on existing code? No, probably not. In the other issue I just gave a thumbs up without really understanding the full scope of the problem. Having finally caught up with where Sven has been all along, yeah, I see the dilemma. It would take a really big hammer to fix this.

It's cheaper to fix the tools to handle values < 2, than trying to come up with a value that satisfies all the tools. So, if someone is feeling up for it, we would recommend getting these tools "fixed".

Repurposing as a feature request to make the behavior bug-compatible with ntfs-3g. [Which can be declined at some future date without prejudice.]


Add ErrorGroup.resolutionStatus Field

Recently a new field was added to ErrorGroup named resolutionStatus:
https://cloud.google.com/error-reporting/reference/rest/v1beta1/projects.groups#ErrorGroup
The latest release (0.120.3-beta) of this Java lib doesn't seem to have that field. Can it be added?

I believe this field has been added internally, can we sync it?

We are in the process of using this library and just ran into this issue as well....I'm on the latest version of proto-google-cloud-error-reporting-v1beta1(0.86.32), but it doesn't seem to have this field.
Any word on when this would be released?

This PR #618 should add resolutionStatus field. There was a mixture of pipeline issues that caused this to be delayed.

Thanks for the update!


Export union types as objects

When generating enums, it would be good to centralise the options for use in select menus etc
When enums are produced at the moment it creates:
export type Payment = 'Debit' | 'Credit';

Preferentially it could be
export enum Payment {
    Debit = 'Debit',
    Credit = 'Credit'
}

Now you can access array of options:
Object.values(Payment)

Alternatively define the array of enumerated values and then define the type from that, then it will avoid the typescript enum issues


SQL array results to JSON array (instead of string)

Issue Type: Feature Request
I have a column from my SQL query results that prints out the following:

researcher

[12,3,4]

[5,3,19]

I then save the SQL query results (above) using the 'Save As JSON' button in the results pane.
However when I save as JSON, the researcher values are wrapped in quotes like so:
[
  {
    "researcher": "[12,3,4]"
  },
 {
    "researcher": "[5,3,19]"
  }
]

Ideally values in brackets would be treated as a JSON array when saving as JSON, and the JSON output would look like:
[
  {
    "researcher": [12,3,4]
  },
 {
    "researcher": [5,3,19]
  }
]

Azure Data Studio version: azuredatastudio 1.34.0 (83a4316cf89cbf961a0f09a72c861379cfd01fa9, 2021-12-15T20:47:33.863Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

this is by design, since the column string typed, it will be serialized as a string.

To resolve this after exporting the query results to JSON, I loaded the results in Visual Studio Code and used the following string search and replace to remove the quotes from the JSON.
"researcher": "\[(.+)\]"   --- regex search text
"researcher": [$1]          --- replace text


[in-process] Initialize AsmParser

Fixes inline asm which was broken by enabling in process compilation.

LGTM


Create Apple developer account

https://developer.apple.com/support/compare-memberships/
we need to create an Apple developer account to deploy the app with
apply: https://developer.apple.com/enroll/type/edit
Definition of done:

[x] Apple developer account is created for the Tonomy Foundation
[x] See if we can get a free account, as we are a non-profit
https://developer.apple.com/support/membership-fee-waiver/
[x] Account is created with<EMAIL_ADDRESS>

application sent, waiting on processing

We’ve received your enrollment request. Once we verify that you have the authority to bind your organization to Apple Developer Program legal agreements, we’ll email you with instructions on how to complete your enrollment.

done and paid for


DRILL-7368: Fix Iceberg Metastore failure when filter column contains nulls

Jira DRILL-7368.

@vvysotskyi please review.


7.1 Update: Paths missing for Weapon Skill actions in the Pap Editor.

for example if you choose the Monk Action, Shadow of the Destroyer, its pap End path should be: chara\human\c0101\animation\a0001\bt_clw_clw\ws\bt_clw_clw\ws_s16.pap
But currently the End path is missing and only the Hit path is shown.

found this issue, I had a mod that changed action pap from a prio patch. I think since they changed action pap in 7.1 with the new sam ability, this older modded version was interfering with non-aciton pap somehow.


C language syntax highlighting breaks after declaring pointer to function argument

VSCode Version: 1.10.2
OS Version: Windows 8
Extensions:  cpptools / ms-vscode / 0.10.3
Language: C

Steps to Reproduce:

Create .c or .h file
Declare function with the pointer to function argument (just type something similar to):

arguments types (I tried char, int, long, void) are not highlighted after the pointer to function argument. Type modifiers (const) are highlighted.

Please file this issue against the cpptools / ms-vscode extension

As far as know cpptools extension does not provide c/c++ syntax highlighting, but I will ask there with the reference to this thread.

@weinand Our C++ Extension doesn't provide syntax highlighting for C++. It's provided by VS Code as part of atom/language-c. So the fix needs to go there, but who provides the fix is "up in the air"...it's open source so anyone can submit a fix, but it's hard to get anyone to take responsibility for actually submit the fix.


don't redefine migration defines

RHEL kernels have some of the migration work backported
Signed-off-by: Thanos Makatos<EMAIL_ADDRESS>

I accidentally included an unrelated change, please re-approve.


Add bullets of "why kerchunk"

Fixes #125

@martindurant this looks great!    The failing tests are not important, right?


Todoist service makes you login after restart

I'm running OS X 10.12.6, with the current version of Franz  (5.0.0-beta.10).
The Todoist service forgets I'm logged in every time I close and re-open the app, forcing a re-login every time. I'm assuming this isn't expected behaviour, as it doesn't happen with any other service I use.
I'm using a normal (ie non google/facebook omniauth) login.

This repository is only for the Franz client. Please report issues in the dedicated recipe repository.
https://github.com/avatarkava/recipe-todoist


Issue with k8s.io/docs/concepts/services-networking/connect-applications-service/

This is a Bug Report
Problem:
In the Securing the Service section the service/networking/nginx-secure-app.yaml references an image named "bprashanth/nginxhttps:1.0" with no explanation of what this image really contains, who owns it, etc.
I don't know if this image is safe to use. Why isn't it using the normal "nginx" image?
Proposed Solution:
Use a proper widely known image or provide more details on the image used.
Page to Update:
https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/

/remove-lifecycle rotten

/language en

I have the same concern.

/reopen
Fixing this sounds trivial. Please someone help confirm if the "official" nginx image works for this example.
/help

/remove-lifecycle rotten
/triage accepted


Add network label filter support

This patch did following:

Make filter check logic same as docker ps  filters

Right now docker container logic work as following:
when same filter used like below:
-f name=jack -f name=tom
it would get all containers name is jack or tom(it is or logic)
when different filter used like below:
-f name=jack -f id=7d1
it would get all containers name is jack and id contains 7d1(it is and logic)
It would make sense in many user cases, but it did lack of compliate filter cases,
like "I want to get containers name is jack or id=7d1", it could work around use
(get id=7d1 containers' name and get name=jack containers, and then construct the
final containers, they could be done in user side use shell or rest API)

Fix one network filter bug which could include duplicate result
when use -f name=  -f id=, it would get duplicate results

Make id filter same as container id filter, which means match any string.
not use prefix match.

It is for consistent match logic
Closes: #21417
Signed-off-by: Kai Qiang Wu(Kennan<EMAIL_ADDRESS>

The jenknis failed because of the issue https://github.com/docker/docker/issues/21490

ping @vdemeester @calavera and @thaJeztah
This PR not include doc change, as I found https://github.com/docker/docker/pull/21270 still have doc-revisit. :0

Although it changes the way filters worked on network before (It's now an and instead of an or), it's coherent with how filters work on other command so, design LGTM :wink:

ping @calavera and @thaJeztah

PTAL the new change, Thanks
ping @calavera and @thaJeztah

Do we have any plan for this PR ?

Sorry about that, it's been busy for the release candidates and @calavera had a few days off.
ping @calavera @vdemeester PTAL

Design and code LGTM for me

ping @calavera  PTAL. Thanks

LGTM. This will need to be added to the documentation.

Since https://github.com/docker/docker/pull/21270  still have doc-revisit , so not sure if it is good start from this patch, as this patch doc depend on that #21270 doc changes

Docs for #21270 were added in https://github.com/docker/docker/pull/21522 (the "revisit" is to check if additional changes are still needed). But this feature is separate from that PR, so if you can update;

https://github.com/docker/docker/blob/master/docs/reference/commandline/network_ls.md#filtering (add the new option to the list of supported filters, and possibly an example
same for https://github.com/docker/docker/blob/master/man/docker-network-ls.1.md#filtering

This may also need changes to the bash and zsh completion scripts, so ping @albers, @sdurrheimer

Thanks @thaJeztah  I misunderstood doc-revisit
Will add doc changes, do we need separate PR or still in this PR ?

@HackToday please as part of this PR, and (given that the code changes are not that large), I think it can be in the same commit

I'll take care of the bash completion part (if noone objects) after this is merged. Thanks for the ping, @thaJeztah

ping @thaJeztah   PTAL  Thanks

Looking good!! I just realized we should also document that the API accepts a new "filter" type for the /networks endpoint. Can you add a note under https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api.md#v124-api-changes, something like;
GET /networks now supports filtering by label.
Also, can you add the new filter to the list of accepted filters here; https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.24.md#list-networks

ping @thaJeztah  PTAL the docs change. Thanks

retest this please

docs LGTM, thanks!
ping @vdemeester @MHBauer PTAL

LGTM :+1:

note: bash completion support for this was added by @thaJeztah in #22319


[fuzz] split out the uber filter test class

Refactor to split out the uber filter test class. Projects depending on Envoy can use the fuzz method of the class with an HttpFilter and HttpData input.
@nareddyt (You might need to do something similar to the post-processor mutation I have to specify the type of the Any to be one of your 4 filters, this helps guide the protobuf mutator).
Testing: no-op
Risk: Low
Signed-off-by: Asra Ali<EMAIL_ADDRESS>

Sorry this feel off the radar last week -- thank you! Merged master as well


KeyError 'bbox' in draw_overlaps

There seem to exist glyphs for where there is no bbox. What should happen then?

I think this is fixed in 0.6.5.


Feature Request - Add stack name to services API in addition to stackid

The addition of the field would make it easier to monitor the state of the services without having to translate the stackID to a named value.
Rancher Version:
1.2
Docker Version:
1.12
OS and where are the hosts located? (cloud, bare metal, etc):
RancherOS
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single Node Rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Access Rancher API for services
Results:
"stackId": "1st4", is listed.
Expected:
"stackId": "1st4",
"stackName": "Blah",

There's a link to the stack of the service from within the service that should give you that info (checked on 1.5.9). Closing this out.


[6.5.x][JBPM-5288,RHBPMS-4086] manage scanner lifecycle directly by KieConta…

…inerInstanceImpl

the refactoring also makes sure the scanner status is always
consistent between InternalKieScanner and KieScannerResource
(both as fields of KieContainerInstanceImpl)

Forward-port of #665

jenkins retest this

jenkins retest this


ReadFile: semantics of bytesRead

Just spent a couple of hours trying to figure out an issue with my FS.
Turned out that Dokan expects the implementation of ReadFile to always fill the entire buffer when offset + buffer.Length are within the file length, and read exactly remaining bytes when offset + buffer.Length are more than file length.
I was calling .NET Stream.Read with the buffer, and my filesystem would return garbage to some programs. The reason is Stream.Read by its contract does not have to fill your entire buffer. For example, when reading from a TCP connection if you specify 1MiB buffer and 1KiB packet arrives, NetworkStream will fill 1KiB and return 1024 even though the connection is still open and it will be possible to read more data in the future.
Now I don't know what the kernel APIs expect in this case, but IMHO one of the following should be done:

documenting this behavior
if this behavior is the result of a bug (perhaps the value returned in bytesRead is not used everywhere it should be), fixing that bug
considering changing .NET wrapper code to repeat ReadFile calls until either buffer is filled or end of file reached (this would remove the need for documenting the discrepancy)

Hi @lostmsu ,

Turned out that Dokan expects the implementation of ReadFile to always fill the entire buffer when offset + buffer.Length are within the file length, and read exactly remaining bytes when offset + buffer.Length are more than file length.

Dokan does use bytesRead to inform the system how much was actually read. It does not expect that the buffer is always fill.
That said, the calling application must handle the bytesRead it will receive and reissue a read to get the next data.

The scenario I worked with is dumpbin from C++ build tools, and it failed
with my FS until I did fill the buffer (but didn't fail on a raw file).
I there might be a bug in .NET wrapper. In the decompilation it looked like
it copies the whole buffer regardless of bytesRead for some reason, which
is suspect.
On Mon, Mar 18, 2024, 7:18 PM Liryna @.***> wrote:

Hi @lostmsu https://github.com/lostmsu ,
Turned out that Dokan expects the implementation of ReadFile to always
fill the entire buffer when offset + buffer.Length are within the file
length, and read exactly remaining bytes when offset + buffer.Length are
more than file length.
Dokan does use bytesRead to inform the system how much was actually read.
It does not expect that the buffer is always fill.
That said, the calling application must handle the bytesRead it will
receive and reissue a read to get the next data.
—
Reply to this email directly, view it on GitHub
https://github.com/dokan-dev/dokan-dotnet/issues/352#issuecomment-2005618237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB2PIGIYWKT5V3WLKQSZ7TYY6OAHAVCNFSM6AAAAABE4ROWWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGYYTQMRTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I assume that you have seen this line:
https://github.com/dokan-dev/dokan-dotnet/blob/master/DokanNet%2FDokanOperationProxy.cs#L411
And yes, it looks like it copies the whole buffer. But the value of rawReadLegth is reported back to the OS because it is a ref parameter, so this should never cause any issues. Have you checked and made absolutely sure that you return the correct read length in the bytesRead output parameter?

Reasonably sure. This is the end of the method before the fix
bytesRead = stream.Read(buffer, 0, buffer.Length);
return DokanResult.Success;

Okay. I think it would be interesting in your case to just try and change the Marshal.Copy code in the library to use the reported length instead of initial length and see if that makes any change in this case.

So I tried the suggested change, and dumpbin is still misbehaving when I read less than requested. Could still be bug elsewhere in dokan, but maybe it is a bug in dumpbin, where they unreasonably expect to read the exact amount requested.
This is what I put into DokanOperationProxy:
if (rawReadLength < 0)
    throw new ArgumentOutOfRangeException("bytesRead", rawReadLength, "bytesRead must be greater than or equal to zero.");
if (rawReadLength > rawBufferLength)
    throw new ArgumentOutOfRangeException("bytesRead", rawReadLength, "bytesRead must be less than or equal to the length of the buffer.");
Marshal.Copy(buffer, 0, rawBuffer, rawReadLength);

This is what I put into Mirror.ReadFile (+ further down replaced all  buffer.Length with read):
int read = Math.Min(buffer.Length, 128);

I copied apphost.exe to the mirrored folder and tried to dumpbin /dependents mirror\apphost.exe which gave

LINK : warning LNK4094: 'apphost.exe' is an MS-DOS executable; use EXEHDR to dump it

When I replace with read = buffer.Length it works correctly.
The sad part is that if Microsoft tool is misbehaving like that, how many other apps silently rely on a similar behavior? I guess I will have to ensure full reads now in all file system implementations for compatibility purposes. 😭

Thanks for testing! Based on your results, it seems like something we probably need to address somehow. I'll take a closer look at this next week when I am back in office.

BTW, if you are considering forcing the compatibility thing at Dokan level, I think simply repeating reads until buffer is filled is going to break potential scenarios where FS is backed by something like sockets.

I have confirmed that bytesRead behave as expected. The caller will receive the value set by the FS implementation.
The only thing I saw is that the library did not use this value to copy the data to the destination buffer https://github.com/dokan-dev/dokan-dotnet/commit/2f15c8a0bd2e84ace51661c2d0b52c8438547fab Not sure if this solves dumpbin case but worth a try.
Procmon might also be useful to see what is going on with dumpbin.
@lostmsu Are you able to reproduce the issue with the C# Mirror ? C Mirror / Memfs ?

@Liryna please see above. You can repro the issue with Mirror if you limit the amount of bytes read to 128 in ReadFile implementation.

@Liryna also, see my suggested change instead of your fix, that guards against bad number returned by bytesRead. It is nice to have foot guards 😁

@Liryna please see above. You can repro the issue with Mirror if you limit the amount of bytes read to 128 in ReadFile implementation.

But that is not a correct implementation. If fewer than requested bytes are returned for a file by the file system, it means that the read reached end of file. It is not like reading from devices such as communication channels. So, effectively, dumpbin will obviously treat the file as just 128 bytes long if you do this (which means it will only get the MZ header and not the PE header and assume it is a DOS exe etc etc).

@Liryna also, see my suggested change instead of your fix, that guards against bad number returned by bytesRead. It is nice to have foot guards 😁

It is a bit of an issue when an implementation actually wants to return fewer than requested bytes. That should be perfectly fine to do, to indicate that only that much data was available towards the end of the file.

@LTRData the guards are against negative values and values that are higher than requested.

From MSDN it sounds like @LTRData is correct
E.g. a file system that serves files should always read the requested amount when possible.

From MSDN it sounds like @LTRData is correct
E.g. a file system that serves files should always read the requested amount when possible.
IMHO, what should be done is by default Dokan should repeat ReadFile calls from IDokanOperations until the buffer is filled or the end of file is reached, but there's should be a way for an FS implementation to opt out of this behavior somehow.

Sorry but I do not agree. That would limit possibilities for implementations that actually want to return fewer bytes read to indicate reached end of file and to avoid further unnecessary reads. Dokan should not send another unnecessary read request to the implementation in that case.

@LTRData that's why I propose there should be an option for an implementation to opt out of this behavior. E.g. a property on IDokanOperations, or another optional interface, or something else.

@LTRData that's why I propose there should be an option for an implementation to opt out of this behavior. E.g. a property on IDokanOperations, or another optional interface, or something else.

Yes, but I think it should be the other way around in that case. There should be some kind of compatiblity layer to implement if this behavior with subsequent reads are needed by the implementation. Because this is not how file system implementations normally need to handle requests.

The problem with the "other way around" is that is just calls for bugs. BTW, the whole conversation should also apply to dokan native repository, because in C standard library read call has the same semantics as .NET Stream.Read - the only requirement is that 0 means end of file.
For instance, I have not looked at SSHFS implementation, but there's a good chance that it exhibits the same issue because it reads from the network, and network does not have the semantics used in Windows ReadFile call for files.

And to prove my theory: https://github.com/dokan-dev/dokan-sshfs/blob/3577c47f92e6f67be80554a7b1a91a922e627495/DokanSSHFS/DokanOperations.cs#L518 yes, it does have this bug.

Agree there is no good reason for the library to retry reads. It is unable to know why the file system returned this value. Retry could be bad. Even if it is an option, maybe one read case returned less bytes for a good reason and a retry will be bad.

And to prove my theory: https://github.com/dokan-dev/dokan-sshfs/blob/3577c47f92e6f67be80554a7b1a91a922e627495/DokanSSHFS/DokanOperations.cs#L518 yes, it appears to have this bug.

No. That is not an issue. For regular files, .NET Stream reads and C library reads always return the number of requested bytes except towards end of file. The concept of returning fewer bytes and reads should be retried only applies to things like communication devices, network sockets and similar.

.NET Stream reads and C library reads always return the number of requested bytes

This is never guaranteed, and maybe true right now on Windows, but actually may not be.
For instance, from FileStream.Read documentation:

Returns
Int32
The total number of bytes read into the buffer. This can be less than the number of bytes allocated in the buffer if that many bytes are not currently available, or zero (0) if the end of the stream has been reached.

.NET Stream reads and C library reads always return the number of requested bytes

This is never guaranteed, and maybe true right now on Windows, but actually may not be.
For instance, from FileStream.Read documentation:

Returns
Int32
The total number of bytes read into the buffer. This can be less than the number of bytes allocated in the buffer if that many bytes are not currently available, or zero (0) if the end of the stream has been reached.

It is never guaranteed as a general concept for everything that could be read from. But for regular files it definitely is, on all platforms and frameworks. There are a huge number of things in many places that would break otherwise.

I'm sorry, but what you say just doesn't match the documentation that I quoted.

In fact, there's more down there:

The method is free to return fewer bytes than requested even if the end of the file stream has not been reached

In fact, there's more down there:

The method is free to return fewer bytes than requested even if the end of the file stream has not been reached

Even Win32 ReadFile frequently returns fewer bytes in cases like network sockets, serial ports etc (the documentation for ReadFile that you quoted is wrong/incomplete in this way).
But this does not happen for regular files.
In any case, it is something that you need to take into account if you are reading from sources that could behave like this. But the code in sshfs that you linked to is not an example of such scenario because there they read from a steam buffer that is known to the implementation and the exact behavior is well defined. You can compare that to when they read from sockets and similar, which is entirely different in this aspect.


Created .npmignore

Added .npmignore file to remove unnecessary files and folders when publishing to npm.
basically we just need the lib/ folder

There is the "files": ["lib"] property in the package.json. It should publish only the lib/ folder right ?
Checkout the documentation
If, given the structure of your project, you find .npmignore to be a maintenance headache, you might instead try populating the files property of package.json, which is an array of file or directory names that should be included in your package. Sometimes a whitelist is easier to manage than a blacklist.

Testing whether your .npmignore or files config works

If you want to double check that your package will include only the files you intend it to when published, you can run the npm pack command locally which will generate a tarball in the working directory, the same way it does for publishing.

I tried with npm pack and it seems to work

Yeah, the lib folder will be publish, only the files in .npmignore want be added to npm registry when you npm publish

Testing whether your .npmignore or files config works
If you want to double check that your package will include only the files you intend it to when published, you can run the npm pack command locally which will generate a tarball in the working directory, the same way it does for publishing.

When you run "npm pack", there is no src and no screenshots folders and other files you included in .npmignore

Yeah I saw it.
The files property will do :)
Im closing this pr


Add XAML Island example

Thanks @fghzxm - I'm in the process of moving the examples to a new home:
https://github.com/microsoft/windows-samples-rs
That will allow the examples to be a lot more reusable as they can refer to the windows crate via crates.io and each have their own workspace for dependencies. I should have the samples moved over today. I'd love for you to contribute the Xaml Islands example. I would only ask that you not include any dependencies for things that can be achieved with the Windows crate. I realize windowing is a little hard right now, but I'd like to keep the examples focused on the Windows crate usage.


SPFx app permission policy

Category

[x] Bug

Describe the bug
SPFx app permission policy can be bypassed by creating another app, in which you put a tab to a blocked app.
Steps to reproduce
-Create new SPFx Teams Personal application APP1
-Create an app permission policy so that user is blocked from accessing APP1
-Create another personal app APP2 in which APP1 (blocked) is a tab. You can do this by adding the following content URL (https://{tenant-url}/_layouts/15/TeamsLogon.aspx?SPFX=true&dest=/_layouts/15/teamshostedapp.aspx%3Fteams%26personal%26componentId={component-id}%26forceLocale=en-us)
User is able to access APP1, using the tab in APP2
Expected behavior
-User is not able to access APP1 through the catalog and user is not able to access APP1 from the tab in APP2
Environment details (development & target environment)

OS: Windows 10
Target Environment: Teams
Browser(s): all
Tooling:  VS Code, SPFx v1.10.0

Thanks for your contribution! Sharing is caring.

Unclear... can you provide more detail? There's no such thing as an app permission policy in SPFx...


Singletons vs transient vs scoped

Is it possible to retrieve non scoped dependencies via the inject attribute? It looks like, the dependencies directly injected into the function are always scoped and will be destroyed after function execution had been left.

Hi PureKrome,
actually to be honest I just had a look onto the code. Maybe code changed meanwhile, I just had another look here. Scope is generated per function and services are resolved from service provider. Should work out, I guess. Still unsure about services that may last longer than a function call in case when a service lifecycle is not limited to function lifecycle.
Let me know your thoughts.


adjust image size to fit current view

When I use a fixed size for the CameraView like in the first picture, i realised the size of the saved photo differs from the displayed in the app
I came up with a fix to crop the image to only save the portion of the picture the user is really watching in the app. The comparison of the previous saved image and the cropped is show below.

I signed it!

I signed it!

I signed it! Again


feat(tests): add Python 3.8 and remove Python 3.6 from the testing suite

Relates to https://github.com/python-zk/kazoo/issues/607
Changes

Test Kazoo with CPython 2.7, CPython 3.7 and CPython 3.8.
Deploy new Kazoo version only on CPython 3.8 job success.

LGTM


Validation rule: check for valid service name

java generator through an error. fern check missed it.
"not a valid name: DestinationService:"
services:
  http:
    DestinationService::
      docs: |
        A destination is any endpoint to which your webhooks can be routed.
      auth: true

services are no longer named based on user config, but rely on filenames. stale so closing


Add Loading to Est Account & Steem Trending Charts

Fixes # .

Est. account value doesn't show up

Changes:

Add loading to Est Account Value
Add loading to steem trending charts

Sometime there is a NaN showed while loading. Also for the Estimated account value i don't see loading icon but 0.00$ i think the loading icon is less confusing.

On small screen (when sidebar are not visible) we should remove border on left & right and border-radius of the boxes in center (similar than on the feed):

Just spoted this also, something wrong with SP conversion for claim reward, i did not claim 54K SP :)

@bonustrack just made those fixes you requested

@jm90m border radius should be removed too on small screen:

@bonustrack done, removed border radius for small screens

You need to remove all of them.

Also remove double border here:

@bonustrack good catch just removed


Not enough space

When sending large prompts i get the following error:
ggml_allocr_alloc: not enough space in the buffer (needed 561259008, largest block available 102924288)
GGML_ASSERT: /private/var/folders/qj/w85147014pq9yp4k5j6g66tw0000gn/T/pip-install-5wl_01v9/llama-cpp-python_451859871b5d42ada35cd84d4620a385/vendor/llama.cpp/ggml-alloc.c:139: !"not enough space in the buffer"

Does this mean, my machine does not have enough RAM (can't veryify, there seems to be RAM left), or is there an option i can give this process more memory (can't find an option)?
thank you for your answer!

Same issue here with the llama-2-7b-chat model.


Set up this to run using node-cron

We could also fetch manually, or just use normal cron.

@lgierth can you automate this? I feel we are already missing a ton of contributors.

better make it part of the respective website deploys. i wanna get rid of the separate gh-contributors service.

Graphql would be a better move these days, anyway.
On Fri, Jun 16, 2017 at 12:33 PM Lars Gierth<EMAIL_ADDRESS>wrote:

better make it part of the respective website deploys. i wanna get rid of
the separate gh-contributors service.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ipfs/get-gh-contributors/issues/3#issuecomment-309003353,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3lodzjD27hcHpmwvI1p3hN3_JuCsqKks5sEmgPgaJpZM4MO3wz
.

@olizilla let's include this as a next sprint item :)


Time series double check

Double check that all time series use the profile of the same year (2019) and the same time zone (UTC)

Wind and solar
Hydro ROR and reservoir
General consumption
Buildings (OK!)
EVs
(Hydrogen)

wind and solar time zone and year seem to be correct


add university name generator

generates university names:
> 10.times { puts Faker::University.name }
West Beahan University
The Alabama Academy
Eastern Murray College
Eastern O'Kon
East Oklahoma Institute
Northern Vermont University
Northern Mante
North Dare Institute
Western Mosciski Institute
Hahn College

noice


Correct unspecifiead to unspecified

This patch just corrects a small spelling error.

@bors r+

:pushpin: Commit b9bee5297e4ad615dad95e7696d98ef97a15ae14 has been approved by epage
It is now in the queue for this repository.

Thanks!
@bors r+

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #12364

:pushpin: Commit b9bee5297e4ad615dad95e7696d98ef97a15ae14 has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit b9bee5297e4ad615dad95e7696d98ef97a15ae14 with merge 31eda6f7c360d9911f853b3014e057db61238f3e...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 31eda6f7c360d9911f853b3014e057db61238f3e to master...


add JSON schema for a demes graph

I haven't added all of the constraints. This is because some constraints are rather complicated (we need initial_size, but this can be definied directly for the deme, or instead in the epoch(s)) or impossible to define with a JSON schema (e.g. sum of proportions must be 1).

Thanks guys, I'll fix the issues you've raised. As for repetition of selfing_rate and cloning_rate` at multiple levels, I agree, it would be nice to just define these at the epoch level. I'm not really sure how to do that, but then still allow it at higher levels in a simplified model. I'll keep poking it and see what falls out.

Is this to only be used on a "verbose" or "redundant" graph (whichever language we've settled on), or also a simplified graph?

I've updated this so that it corresponds with a fully-qualified graph. I reckon the fully-qualified case is the easier to specify than the more general/flexible simplified case, so I've started there.

Ok, thanks @jeromekelleher. I'll merge this much and leave the more flexible schema for another day.


Error using script

Hello.
I'm not much of a Python user, so I don't really know how to proceed and fix this problem.
The issue is that after installing pysword via pip3 install pysword this is what happens after cloning the repository and trying to use the script:
$python3 sword_to_json.py --source_file KJV.zip --bible_version KJV --output_file KJVNew.json
Traceback (most recent call last):
  File "/Users/michael/Downloads/Bibles/SWORD-to-JSON/sword_to_json.py", line 5, in <module>
    from past.builtins import xrange
ModuleNotFoundError: No module named 'past'

I tried removing these two lines:
if sys.version_info > (3, 0):
    from past.builtins import xrange

But that only made things worse:
$python3 sword_to_json.py --source_file KJV.zip --bible_version KJV --output_file KJVNew.json
Traceback (most recent call last):
  File "/Users/michael/Downloads/Bibles/SWORD-to-JSON/sword_to_json.py", line 54, in <module>
    if __name__ == "__main__": main()
  File "/Users/michael/Downloads/Bibles/SWORD-to-JSON/sword_to_json.py", line 51, in main
    bible_dict = generate_dict(args.source_file, args.bible_version)
  File "/Users/michael/Downloads/Bibles/SWORD-to-JSON/sword_to_json.py", line 18, in generate_dict
    for chapter in xrange(1, book.num_chapters+1):
NameError: name 'xrange' is not defined. Did you mean: 'range'?

That's when I decided to open this incident...

OK, I posted too soon. After posting this, I decided to replace xrange with just range, and it finally worked after doing that.
So the fix was to remove these lines
if sys.version_info > (3, 0):
    from past.builtins import xrange

and delete the x from xrange in two places.


Consistent pattern for sync vs async function calls

Multiple endpoints such as CreateAccount and CreateTransfer have an x-wait-for header that changes the response body. I am wondering if we need to pass a sync/async parameter to these function calls or just separate them into two different function calls such as moov.CreateTransfer() and moov.CreateTransferAsync()
Not sure if most people will want the synchronous function call?

@wadearnold, I believe that for API calls such as creating an account, linking a card, most people will prefer the synchronous call. Asynchronous API calls place the responsibility of polling (or listening for webhooks) on the developer's shoulders, which doesn't make their life easier.

@alovak there is no polling or waiting the developers have to do.

There are a few libraries which offer a Promise type we could use.

https://github.com/chebyrash/promise/blob/master/promise.go
https://github.com/reugn/async/blob/master/promise.go


super-productivity: update electron to version 13, as 11 is EOL

This is more or less a backport of https://github.com/NixOS/nixpkgs/pull/148162/commits/61d5e58435cca65f085217600c730fdd4110ecaf , but keeping the changes minimal as we're on a release branch.
Built and tested on NixOS 21.11

https://github.com/NixOS/nixpkgs/pull/158555
FYI electron 13 is also marked as EOL two days ago.

Hmm so my testing shows electron 14 not actually being able to run the current super-productivity version (it freezes on the startup screen). Do you have opinions on how to fix this? I guess there's no other choice but to update super-productivity itself too, even though that's not really stable...

You can still install packages marked as insecure via NIXPKGS_ALLOW_INSECURE=1.

Right, but if it's what we're suggesting to people running on the stable channel then why bother marking the electron package as insecure in the first place? Electron isn't even a user-facing program, so if we recommend people on stable to use NIXPKGS_ALLOW_INSECURE then the insecure warning would be useful for basically only people who use electron to develop apps, and these people are probably going to be the least touched by the insecure marking.

Well, I'm landing this already given it's an incremental improvement; if someone else wants to take over backporting super-productivity to 21.11 I'd be more than happy to review the backport but it may take me some time to get to it on my own.


Add ANSI bright colors

Add the birhgt_ versions of the standard ANSI colors. See https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit

Implemented by 68fe7e780daecdaf08b511870277674508142cbf.


Sort entries into alphabetical order.

Sort entries into alphabetical order.
By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

Duplicate of #348

#384 requires the modifications that this pr contains. You seem to agree with the cause, then why not merge this?

I didn't agree with it #348. I just said that his argument was valid too. I'm not going to change the sort order.


Docker image 0.4.0 actually contains 0.3.1 acme-dns-azure library

I was using docker image ghcr.io/zeiss/acme-dns-azure:0.4.0 for workload_identity.
But it was throwing error:
strictyaml.exceptions.YAMLValidationError: while parsing a mapping
  in "<unicode string>", line 1, column 1:
    use_workload_identity_credentials ...
     ^ (line: 1)
unexpected key not in schema 'use_workload_identity_credentials'

After debugging, I found that, 0.4.0 container actually contains 0.3.1 acme-dns-azure library.
I have also tested with edge version, which is working properly.

Thanks for your feedback - currently working on a fix. The issue was caused by the cache of the container build for the package - old version was cached.
We will rebuild the tag 0.4.0 with the correct package.


enable restarting the script

I would suggest (and maybe if it is liked code) having the install script try chsh again after a failed installation,
or retry chsh 3 times like sudo does,
to prevent a password typo from having to remove the folder and start over

If chsh fails you don't have to restart the installation, just run chsh afterwards. The OMZ installation will be alright nonetheless. In fact, that's what the installer tells you: https://github.com/robbyrussell/oh-my-zsh/blob/09fbc163663cd814488cb4be474f034525a8cca0/tools/install.sh#L90-L91


deploy to my own web app: Missing name after . operator. (line 22, file "bundle")

Are you requesting a feature or reporting a bug?
Attempting to deploy to my own web app.
If reporting a bug, is there already an issue open for this same bug?
No
What is the current behavior?
Web page shows: Missing name after . operator. (line 22, file "bundle")  when I run the script.
What is the expected behavior?
Expect to see the Copy Folder interface
How would you reproduce the current behavior (if this is a bug)?
I've never used Google Apps Script before. I followed your How To (https://github.com/ericyd/gdrive-copy/blob/master/howto_for_non-developers.md). Although you don't document the use of clasp I didn't want to try to copy/paste files manually.
$ clasp create
? Clone which script? standalone
Created new standalone script: https://script.google.com/d/1xWFZDYWrcbHL2OgV2Bb9-hHFCH72r7oq6cKtGfeTENWnDH6vTEo9AkYw/edit
Cloned 1 file.
└─ appsscript.json

In a separate folder:
$ git clone https://github.com/ericyd/gdrive-copy.git
Cloning into 'gdrive-copy'...
remote: Enumerating objects: 160, done.
remote: Counting objects: 100% (160/160), done.
remote: Compressing objects: 100% (100/100), done.
remote: Total 4449 (delta 114), reused 95 (delta 60), pack-reused 4289
Receiving objects: 100% (4449/4449), 3.44 MiB | 11.15 MiB/s, done.
Resolving deltas: 100% (2920/2920), done.
$ cd gdrive-copy/
$ npm --version
$ npm install

><EMAIL_ADDRESS>install /Users/simon/sandbox/medstack/gdrive-copy/node_modules/fsevents
> node install

[fsevents] Success: "/Users/simon/sandbox/medstack/gdrive-copy/node_modules/fsevents/lib/binding/Release/node-v57-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile

><EMAIL_ADDRESS>install /Users/simon/sandbox/medstack/gdrive-copy/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Download already available at /var/folders/06/pf351r853073hbrfbb71qpmh0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip
Verified checksum of previously downloaded file
Extracting zip contents
Removing /Users/simon/sandbox/medstack/gdrive-copy/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /var/folders/06/pf351r853073hbrfbb71qpmh0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1551420549014/phantomjs-2.1.1-macosx -> /Users/simon/sandbox/medstack/gdrive-copy/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /Users/simon/sandbox/medstack/gdrive-copy/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs

><EMAIL_ADDRESS>postinstall /Users/simon/sandbox/medstack/gdrive-copy/node_modules/sinon
> node scripts/support-sinon.js

Have some ❤ for Sinon? You can support the project via Open Collective:
 > https://opencollective.com/sinon/donate

added 1597 packages from 1300 contributors and audited 7390 packages in 23.456s
found 364 vulnerabilities (169 low, 184 moderate, 9 high, 2 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

$ npm run build:prod

><EMAIL_ADDRESS>build:prod /Users/simon/sandbox/medstack/gdrive-copy
> npm run webpack:prod && npm run gulp:prod

><EMAIL_ADDRESS>webpack:prod /Users/simon/sandbox/medstack/gdrive-copy
> webpack --config ./config/webpack.config.prod.js

Hash: f9fde7dfd9e21a391d47
Version: webpack 2.7.0
Time: 11684ms
         Asset       Size  Chunks                    Chunk Names
     bundle.js     586 kB       0  [emitted]  [big]  index
    styles.css    5.48 kB       0  [emitted]         index
styles.css.map  377 bytes       0  [emitted]         index
   [0] ./~/react/index.js 190 bytes {0} [built]
  [14] ./~/react-dom/index.js 1.36 kB {0} [built]
  [35] ./src/util/picker.js 3.22 kB {0} [built]
 [113] ./src/index.js 827 bytes {0} [built]
 [114] ./src/css/main.scss 41 bytes {0} [built]
 [115] ./src/App.js 5.38 kB {0} [built]
 [119] ./src/views/About.js 4.18 kB {0} [built]
 [220] ./~/material-ui/Tabs/index.js 483 bytes {0} [built]
 [232] ./~/material-ui/styles/MuiThemeProvider.js 2.14 kB {0} [built]
 [251] ./~/react-dom/cjs/react-dom.production.min.js 100 kB {0} [built]
 [255] ./~/react/cjs/react.production.min.js 6.24 kB {0} [built]
 [264] multi ./src/index.js ./src/css/main.scss 40 bytes {0} [built]
 [266] ./~/css-loader!./~/postcss-loader/src!./src/css/main.scss 5.29 kB [built]
 [267] ./~/css-loader/lib/css-base.js 1.51 kB [built]
 [268] ./~/style-loader/addStyles.js 6.91 kB [built]
    + 254 hidden modules
Child extract-text-webpack-plugin:
       [0] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
        + 1 hidden modules
Child extract-text-webpack-plugin:
       [0] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
       [1] ./~/css-loader!./~/postcss-loader/src!./src/css/main.scss 5.29 kB {0} [built]

><EMAIL_ADDRESS>gulp:prod /Users/simon/sandbox/medstack/gdrive-copy
> gulp build

[01:09:29] Using gulpfile ~/sandbox/medstack/gdrive-copy/gulpfile.js
[01:09:29] Starting 'js'...
[01:09:29] Starting 'html'...
[01:09:29] Starting 'css-prod'...
[01:09:29] Starting 'img'...
[01:09:29] Finished 'img' after 589 μs
(node:4344) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
[01:09:29] Finished 'css-prod' after 106 ms
[01:09:29] Finished 'html' after 108 ms
[01:09:29] Finished 'js' after 118 ms
[01:09:29] Starting 'build'...
[01:09:29] Finished 'build' after 26 μs

$ cd ../mydrive-copy/
$ cp -r ../gdrive-copy/dist/* ./
$ ls
application.gs   bundle.js        empty.gs         index.html       styles.css
appsscript.json  css.html         icons/           js.html          styles.css.map
$ cat appsscript.json
{
  "timeZone": "America/New_York",
  "dependencies": {
  },
  "exceptionLogging": "STACKDRIVER"
$ clasp push
? Manifest file has been updated. Do you want to push and overwrite? Yes
└─ application.gs
└─ appsscript.json
└─ bundle.js
└─ css.html
└─ empty.gs
└─ index.html
└─ js.html
Pushed 7 files.
$ clasp deploy
Created version 2.
- AKfycbxEj89FFY2Z2mYg2WA6NePCTzCS-J-swSD9BwWxPmIAOcoElouaMPtd-B2mj3MxUVzW @2.

Then I followed your instructions under "Step 7: Enable Drive API"
Then Publish > Deploy as Web App
Then open the URL in a new tab and the resulting web page displays the Google Apps Script logo and the error message:
Missing name after . operator. (line 22, file "bundle")
Specify your

operating system: MacOS 10.14.3
browser: Chrome 72.0.3626.119

bundle.js is a temporary build artifact. It should not be included in the deployed web app. Its a valid point that it probably shouldn't be built to dist if it shouldn't be included. I'll leave this open so I can modify the build process slightly.
In the meantime, you should just delete the bundle.js file and it should work.

OK, I deleted bundle.js from mydrive-copy folder. I look forward to your updated version!
13:28 $ clasp push
? Manifest file has been updated. Do you want to push and overwrite? Yes
└─ application.gs
└─ appsscript.json
└─ css.html
└─ empty.gs
└─ index.html
└─ js.html
Pushed 6 files.
✔ ~/sandbox/medstack/mydrive-copy
13:29 $ clasp deploy
Created version 4.
- AKfycbwp7d0_sD-OqcJs7mzA4ahaAowP6A2jv151avkldSQdkLvxhNxH7bDek7BRhOqr9V6I @4.

Then in Google Apps Script Dashboard, Publish > Deploy as Web App.
Selected Execute the app as: to be User accessing the web app and Who has access to the app: to be Only myself.
Then opened the provided URL and got:

TypeError: Expected argument of type object, but instead had type undefined. (line 3, file "application", project "Mydrive-copy")

Sorry in advance for being a newbie to Google Apps Script. I'm very glad you are offering this as open source! It's really helpful from a security/privacy point of view. (I think I saw a project that allowed you to copy the project directly from the Dashboard.)

OK, never mind all of the above. I got it running using your PR https://github.com/ericyd/gdrive-copy/pull/90
In addition to what you had documented, I also did this:
clasp create --type webapp
clasp setting rootDir dist
clasp settings fileExtension ts

Now the app is running!
However I am still having an issue, I'll open a new ticket for that.

New issue: https://github.com/ericyd/gdrive-copy/issues/92


⚠ GitLab Server has degraded performance

In 98082d9, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6471 ms

Resolved: GitLab Server performance has improved in 2945e21.


flags file

Is your feature request related to a problem? Please describe.
It would be nice if one could provide a ~/.config/webcord-flags.conf to configure electron runtime flags (--enable-features=WaylandWindowDecorations --ozone-platform-hint=auto in my case). Other applications I use (vscode, tons of browsers) provide such a file and thus are easy to configure.
Describe the solution you'd like
Either a hint to an existing flags-file or an implementation of such.
Describe alternatives you've considered
Setting the flags in the .desktop file. Vanishes with each update.

Is your feature request related to a problem? Please describe.
It would be nice if one could provide a ~/.config/webcord-flags.conf to configure electron runtime flags (--enable-features=WaylandWindowDecorations --ozone-platform-hint=auto in my case). Other applications I use (vscode, tons of browsers) provide such a file and thus are easy to configure.
Describe the solution you'd like
Either a hint to an existing flags-file or an implementation of such.
Describe alternatives you've considered
Setting the flags in the .desktop file. Vanishes with each update.

This is impossible to implement via the application itself. The problem is that some flags such as --ozone-platform-hint=auto aren't applied correctly via the Electron API (at least once I've been testing that). On Arch some apps like even the Chromium itself provide such file by wrapping the binary into a shell script, so I guess I could implement something like this in my AUR PKGBUILD.

 Would be very nice if we could have one along with webcord!

You might as well request this for another AUR packages.

Good idea, will do. Perhaps first you add it to webcord-git, so one can point to a diff as an example.

Actually setting --ozone-platform-hint=auto seems to be enough to start the current version on wayland without the "blur". I guess we could just add that to the regular .desktop file?

Actually setting --ozone-platform-hint=auto seems to be enough to start the current version on wayland without the "blur". I guess we could just add that to the regular .desktop file? That way even non-arch wayland users would profit.

Native Wayland support in Chromium (as well as in some other browsers like Firefox/Gecko-based ones) as well as in Electron itself is still considered to be experimental through and while it could actually work better for some, others might experience more crashes and visual artifacts when switching to native Wayland than staying with XWayland. Using WebCord for that reason is still a bit problematic, although I'm trying my best to make it the best experience possible. For that reason, I think it should be kept the way it is.

Setting the flags in the .desktop file. Vanishes with each update.

You can place modified .desktop file into ~/.local/share/applications/ directory and it will override the system one.
https://wiki.archlinux.org/title/Desktop_entries#Modify_desktop_files

Uh, thank! Never knew that.

@boredland Implemented for @reforged/maker-appimage in cb7a7ab. This will both affect WebCord in the future release of ReForged as well as other Electron projects which will toggle this feature.
As described in docs, it follows the same file format as described in Arch Wiki, including the support for ignoring the lines starting with hash (#).

As WebCord v4.3.0 now comes with new AppImages supporting these flags, the only thing that holds me from closing this issue ticket is to implement this in webcord-git on AUR. And even inside AppImages this feature might only be Arch-dependant, as I don't want to implement something that is non-standard in other distros or packages.
If I would want to make this feature work across all distributables, I would probably need to use hooks and generate a wrapper that would be used instead of Electron binary to make this happen.

(...)  the only thing that holds me from closing this issue ticket is to implement this in webcord-git on AUR.

Or maybe it is better to rely on currently available Arch Linux wrapper for Electron that already interprets electron-flags.conf and do no updates? @boredland any thoughts?


Pretrained Models and Performance

Hi,
I am wondering if there are any pretrained pytorch models that could be downloaded.
In addition, could you pls let us know the performance of this tsn-pytorch on UCF 101 / HMDB 51/ kinetics?
Thanks a lot!

Even I trained the models using default settings for split-1 of the UCF-101 dataset and am getting a lower performance than reported. Below are the numbers I got:
RGB - 85.57%
Flow - 84.26%
RGB + Flow - 90.44%
What could be the reason for this?

This code reproduces the performance of Caffe TSN on UCF101. We haven't tested it on HMDB51.


Usability of ImportMixin

Latest docs describe an amazing ImportMixin where we can set specific fields for all rows. But it seems that it is not documented and only partially implemented in v1.2.0. Specifically, get_form_kwargs is never called.
How baked is ImportMixin?

Hi @chrismerck, can you define "baked"? And what would you like to see? Care to submit a PR with changes you envision?

Sorry, my post was terribly unclear. I'll take it that the presence of the Customize admin import forms section  in the "latest" docs means that it should work on v1.2.1.dev0. I was just uncertain as I did not get it to work immediately and thought I may need to wait for a release version.


Addition of liquibase.update() Enhancement Request #1614

Added .update()

some JavaDocs.

Environment
Liquibase Version: 4.3.0
Liquibase Integration & Version: maven
Liquibase Extension(s) & Version: N/A
Database Vendor & Version: N/A
Operating System Type & Version: Win 10
Pull Request Type

[ ] Bug fix (non-breaking change which fixes an issue.)
[x] Enhancement/New feature (non-breaking change which adds functionality) closes #1614
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Described in issue itself.
Steps To Reproduce
Described in issue itself.
Actual Behavior
Described in issue itself.
Expected/Desired Behavior
Described in issue itself.
Screenshots (if appropriate)
N/A
Additional Context
N/A
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[x] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Added Test Harness Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel

Hi @Betlista
Thanks for providing this PR.
Here’s what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest:

Changes based on guidelines for PR submission
Additional tests (unit and/or integration) and/or Test Harness Tests
Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.
We’ll let you know when it’s ready to move to the next step or if any changes are needed.

Hi @Betlista
Thanks for providing this PR.
Here’s what happens next:
A member of the Liquibase team will take a look at your contribution and may suggest:

Changes based on guidelines for PR submission
Additional tests (unit and/or integration) and/or Test Harness Tests
Provide other feedback, like requesting changes.

The PR will be prioritized according to our internal development and testing capacity.
We’ll let you know when it’s ready to move to the next step or if any changes are needed.

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.


Custom texture doesn't create models files

Describe the bug
Creating a new seed with custom textures doesn't create the models json to display the textures, while applying a color to the base texture works.
To Reproduce
In the json file "mysticalcustomization/crops" remove the "color" line and add the "seeds" line to "textures" and put the path of the custom textures (e.g. "kubejs:item/aquite_essence")
Expected behavior
Show textures ingame with custom textures applied
Screenshots / Scripts / Logs
Logs:
https://pastebin.com/xq7R2ABc

This is my json file for an Aquite seed
https://pastebin.com/ZDRDr0pp
Versions (please complete the following information):

Minecraft: 1.20.1
Forge: 47.1.47
Cucumber: 1.20.1-7.0.1
Mystical Agriculture: 1.20.1-7.0.3
Mystical Customization: 1.20.1-5.0.0

Thank you for your work !

I somewhat unintentionally removed the automatic model generation in 1.20. I'll see if I can re-add that in some form if it doesn't cause issues.
In the mean time you could probably add those files to your resource pack manually. I'm not sure how it would work using kubejs. Theoretically, you could add the models to a resource pack in the mysticalagriculture namespace corresponding to the generated block/items in game and they should load like normal.

I was hesitant to add them manually in the first place, so I'm going to add them while waiting for an update that will potentially fix the problem.
Thank you =)

I looked into re-adding this earlier and figured out why I removed this functionality in the first place. In 1.19.3 Mojang changed a ton of the internals for model loading which made it so my method of dynamically generating them didn't work anymore.
I think what I'll do is add documentation for this use case since doing it dynamically is significantly more difficult now.

I added a section to the docs with examples: https://blakesmods.com/docs/mysticalcustomization/adding-crops#custom-models


Improve development process

This development process for this project is not ideal. There is no versioning, and all PRs merge directly to master, which is also the only active branch. This might be ok for a small project with few contributors, but librespot is far too big.
I would suggest starting simple:

Creating a "develop" branch.
All PRs go to "develop".
Now and then, when the develop branch is in a good state, it's merged to master-
When develop is merged to master, a tag is created with a version number following semantic versioning.

Other ideas and suggestions?

Add CI builds to PRs. No merge unless passing. Maybe with some more example to get better coverage.

I tried to find some kind of protobuf replay/mocking library for integration testing (like pyvcr) but couldn't find anything.

Also relevant - https://github.com/librespot-org/librespot/issues/130

Many good points in that discussion! And most people seemed to more or less agree, but then nothing happened.
Being able to specify a tag would be a big help for any project depending on librespot yes. And for those who don't specify, having a separate development branch would help making sure that master is always good.
Travis already builds PRs, but yes it would be very good to extend the examples and add them to CI.

Are you guys ok with moving to GitHub Actions? I have workflows that can just be dropped in without modifications whatsoever that trigger on PRs. I can extend them to create a tag when pushing to master without a lot of work.

It should also be the case that, ideally, when a release is tagged and pushed to master, the varoius crates are built and pushed to crates.io. Saves us having to remember to manually publish the packages.

Github Actions seems like a good idea. I haven't had time to try yet but it seems like an competitor to Gitlab CI/CD which is very useful.
Anyway I think we need the maintainer to join this discussion. @awiouy ?

I can open up an issue that adds the workflows this weekend :)

Github actions aren't enabled yet for this repo/organisation, will probably need to signup via the organisation account.

Could we start with adding a 2nd branch? It shouldn't take 5 mins. And then also deciding which one you want to be the default on here, I suggest the develop branch else everyone unknowingly opens their PRs against the stable branch. It is of course trivial to change that afterwards.

I can do that now if you want. Have enabled actions @ashthespy. Not sure if @awiouy has a ton of time atm?

Also created dev -- lets figure out what works best!

I suggest we just set that to master and get on with it. It'll require people to update their git configs, but tbh it has to be done at some point so might as well be now?

Have changed it to dev. I also think we should get any PRs that are good and waiting to merge merged, then create a release, and get 0.1.0 pushed to crates.io. it may not be perfect atm, but at least its a starting point.

I think I've got an email today saying github actions is available for everyone

@SirWindfield It's already been enabled on this repo..

The wiki is quite out of date, especially the section on Compiling/Development. The various feature flags are also not fully documented.  Any volunteers?
Also what is the consensus on rustfmt? I would propose to bite the bullet and update the entire codebase to Edition 2018 and format once.

I'm indifferent to rustfmt to be honest. It's been a pain in the past, it confuses would be contributors when Travis breaks, and it is just a superficial change. Whilst I'm in favour of having rustfmt as the style guide for the project, I'd rather just have someone run it every now and then as opposed to seeing potential PRs and contributions delayed. Similarly, if someone working on the project feels that the style throughout absolutely must be consistent, they can always run it and update as part of their PR. I'd stick a note in contributing along the lines of It is recommended that you run rustfmt on your code before submitting a PR.
Just my 2 cents. If anyone else feels differently/strongly feel free to overrule.

Best would be a simple pre-commit hook that runs rustfmt :)

Best would be a simple pre-commit hook that runs rustfmt :)

IMHO this is a major pain for anyone who's trying to keep a fork up to date. Sometimes I've spent more time solving merge conflicts due to formatting than with the actual code changes.

Hmm, you're right on that, didn't think of it but thinking back to when we had rustfmt I also had my fair share of merge conflicts due to formatting...

I feel you pain as well on the forks front, but IMO we had rustfmt running way before it hit stable, and thus making a lot of noise for no reason. I believe it's much more stable now, and comes pre-installed with newer versions of Rust.

Did you update your local branch to use the new dev branch? You might have to delete your local dev branchm, git fetch and switch if you had a branch previously named dev for local development as I did. In any case, the dev and master branches are now even, as I just merged them with my recent changes.
With regards to those recent changes, it's all basically dependencies. I dumped rust-mdns in favour of libmdns, which is on crates.io. rust-tremor has been forked and now resides here, with the old local tremor gone so that librespot can be published to crates.io.
Speaking of crates.io, librespot is now on crates.io, version 0.1.0. With all the blockages out of the way, I figured we'd waited long enough to get it published, so decided to crack on. I've added some publishing notes which spell out the basics and the order in which things needed to be published, as well as merged my changes with development, development with master, then published from master and tagged it at the time of release. It should hopefully be easier to release now, as the initial PITA was with dealing with crates.io not liking the fact that the project depended on previously unpublished crates.
There is still a discussion to be had on how we wish to version things though, namely do we want per crate versioning, which allows development flexibility from crate to crate, but kills automated publishing when say a new tag is pushed, and also means that the repo version tags will diverge from the crate versions, or do we want repo version tagging, which enables automated releases on tagging, but limits development flexibility from crate to crate, and kind of makes the crates.io packaging redundant? Personally I'm in favour of the latter, but please chime in.

Woohoo! 🎉 Thanks for the effort! cargo install librespot worked just fine on my Windoze..

Did you update your local branch to use the new dev branch? You might have to delete your local >dev branchm, git fetch and switch if you had a branch previously named dev for local development >as I did. In any case, the dev and master branches are now even, as I just merged them with my >recent changes.

Apparently I looked at it after you merged it, but got confused as I didn't see any merge commits..
W.t.r the crate flexibility, given the interdepended nature of the crates, do we really require such flexibility? We should look into tokio or one of the other nested crates to get a feel for it..

We should look into tokio or one of the other nested crates to get a feel for it..

Had a look into the rust-protobuf crate as I noticed the version numbers were the same when updating to exact dependencies, they look to have taken the second approach to versioning, where the repo is versioned. As mentioned previously I'd be fine with this.

@dtcooper the recent release on crates.io might also be of interest to you as it ) provides a stable librespot library and b) should make installing librespot easier during the build process.

Have just creates a publish.sh script and added it to the dev branch, I suggest that we use that for releasing versions in future, as it abstracts away some of the tedious processes. I took an executive decision and decided to work on the basis of repo versioning, so all librespot-* crates will have the same version at any given time. The main benefit of this is that we can now setup the CI to run whenever a new tag is pushed to the repo, though we need to do some checking to make sure only semver tags are published. Once that's setup, we shouldn't need to ever manually publish any crates, instead we can just let the CI handle all of that.
If someone has some experience with the Github CI and wants to write up the config for that, it would be most welcome, otherwise I'll do it at some point. Ideally we'd test a release with the script first just to make sure I haven't missed anything.

Hello, what is the process for merging back dev into master? As far as I've understood is there were quit a lot of improvements commited onto dev, which haven't made it into master yet.

Hello, what is the process for merging back dev into master? As far as I've understood is there were quit a lot of improvements commited onto dev, which haven't made it into master yet.

Would guess all the changes will be merged into master when a new version is published on crates.io


MIXEDARCH-80: Guide on using node affinity to safely schedule pods in heterogeneous clusters.

Description of the change:
Expanded guide for operator support for multiple architectures that covers setting nodeAffinity for pod-defining objects to ensure safe scheduling.
Motivation for the change:
There is already a guide for creating an operator with support for multiple architectures, but this is not sufficient to cover the nuances of scheduling pods on a cluster with multi-architecture compute nodes. This guide leverages the existing sample applications to deep dive into the changes needed for operators of each type (ansible, go, helm).

I'd expect to see some discussion of the subscription.spec.config.nodeSelector and subscription.spec.nodeAffinity(new 4.12) and how that can also set nodeselector/affinity values on the operator deployment.

@bparees I completely agree that the subscription is an important topic. I need to check with @perdasilva in terms of where those docs should live in full, since I feel like it would probably be closer to the OLM functionality than OperatorSDK. I can absolutely cross-link the docs for that from this guide, though.

I feel like it would probably be closer to the OLM functionality than OperatorSDK. I can absolutely cross-link the docs for that from this guide, though.

yup, my original draft of my comment said something like "this may not belong in SDK docs, but....."
So yeah, this may not be the spot to document it fully, but these docs should reference the functionality since it has implications for how someone's operator may get configured/installed by the admin.

So yeah, this may not be the spot to document it fully, but these docs should reference the functionality since it has implications for how someone's operator may get configured/installed by the admin.

I agree, mentioning them here is a good idea.

Besides updates to address the discussion above, I'm working with Camila to get https://github.com/kubernetes-sigs/kubebuilder/pull/2906 nailed down before updating this to the next draft, since much of the same guidance will be present.

/remove lifecycle rotten

/remove-lifecycle rotten

/lifecycle frozen
(just so it stops making it rotten)

A refresh for this PR is coming soon. I prioritized work on:

https://github.com/operator-framework/api/pull/276
https://github.com/operator-framework/audit/pull/144

/unhold

@jmrodri I think this is ready for another review if you're up for it. :)

/retest

/retest

Thanks guys! :)


Opt-Out Mode with No Enabled Destinations

Proposed changes
I've added a note explaining what to expect when opt-out mode is used with a source that’s not connected to enabled destinations
Merge timing
ASAP once approved
Related issues (optional)
JIRA: https://segment.atlassian.net/browse/LIBRARIES-2179

@atitsh @prigiattiperrut Are

just remembered we are going to be adding another table to this doc when engg finishes one other defect in the wrapper.
The new table can be seen here: https://docs.google.com/document/d/1o8XQ-9N6nBxR2XjNIrTPs6y6gZRnzU_38r3CNfo2esw/edit?tab=t.0#bookmark=id.lqel9qezsfmm and covers

Are we still holding off on this one, or can we merge it now?

@forstisabella can you review this table  and see how we could incorporate it in our onetrust wrapper doc now that the code fix has been deployed.

@forstisabella can you review this table  and see how we could incorporate it in our onetrust wrapper doc now that the code fix has been deployed.

@atitsh - I sure can! In the meantime, should we close this PR or merge it?


Add DerivedFieldMapper and support parsing it in mappings

Description
Adds a DerivedFieldMapper to support the Derived Fields feature enhancement as well as updating the mapper parsing logic to recognize and currently parse derived fields in the mappings.
Some parts will need to be revisited as they are dependent on the query implementation. These sections have been marked with TODOs.
Related Issues
Resolves #12506 and #12507

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] ~Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Requesting initial review by @rishabhmaurya and @msfroh on the draft.

Are we at the point where it makes sense to add the feature to the changelog? Or is there another PR required first?

@msfroh Backport 2.x PR - https://github.com/opensearch-project/OpenSearch/pull/13036


fix(build): migrate setup.py to pyproject.toml

:tada: This PR is included in version 0.25.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Image Duplicate Finder for the latest version of fastai

https://towardsdatascience.com/how-to-build-an-image-duplicate-finder-f8714ddca9d2

The best approach is to use nmslib.


Better tags in the repository

Up until now, I've been half-heartedly using the default tags provided by GitHub. But a lot of things that need attention, such as testing, continuous integration, and even specific features, don't exactly fall into the default categories. It would be better to have a custom set of tags for this repository, given the size of the code base (which is almost 20,000 LOC at this point).

Here's a rough draft proposal:
Categories

Bug
Crash
Unsoundness
Regression
Performance
Code Quality
Dependencies
Documentation
Enhancement
Testing
Benchmarking
Tracking Issue
Continuous Integration
Compilation

Semantic Versioning

Deprecation
Patch
Minor
Major
MSRV

Priority

Low
Medium
High

Status

Unstaffed
Blocked on Dependency
Blocked on Rust Feature
Duplicate
Needs Investigation
User Error
Won't Fix

Subject

Storage
Querying
Systems
Scheduling

Features

serde
rayon

I've added nearly all of the tags enumerated above. I left out a few (such as some related to semantic versioning), figuring that if they are needed later they can be added.


Create design of spaces page consisting of images of various offices by canva/figma

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hey, I would like to work on this issue please assign this one to me.

Hey @vivekmeena9999 , task assigned.
You can start working on this.

Don't forget to star the repo.
Happy contributing.

Hey, there sorry for the late reply. I have made the design please check it out here, if any changes need to be made them please do tell me.
File link:-

good design , keep it up.
To make a pull request in asset folder their is design.md file add your link there and make the pull request.


i18nextLng Local Storage Key/Value Created Even Though Not Used In Configuration

🐛 Bug Report
The library seemingly is creating a local storage key/value pair called i18nextLng.
To Reproduce
All of the configuration (what is pasted below) refers to the language key as "lng" and not i18nextLng. It should be using "lng" everywhere.
    // order and from where user language should be detected
    order: ['querystring', 'cookie', 'localStorage', 'sessionStorage', 'navigator', 'htmlTag', 'path', 'subdomain'],

    // keys or params to lookup language from
    lookupQuerystring: 'lng',
    lookupCookie: 'lng',
    lookupLocalStorage: 'lng',
    lookupSessionStorage: 'lng',
    lookupFromPathIndex: 0,
    lookupFromSubdomainIndex: 0,

    // cache user language on
    caches: ['localStorage', 'cookie'],
    excludeCacheFor: ['cimode'], // languages to not persist (cookie, localStorage)
    // optional set cookie options, reference:[MDN Set-Cookie docs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie)
    cookieOptions: { path: '/', sameSite: 'strict' }

Expected behavior
A key with this name should not be created since it is not configured to use this key name. Because of extensive privacy legislation, it is important that applications know what is being created and what it is being used for.
Your Environment

runtime version: node v8.11.3
i18next version: 19.8.4
os: Mac

How does your code look like?
Can you create a reproducable example?

I have a same issue here. To reproduce, it's enough to pass basic options to init(), for instance:
i18n
    .use(LanguageDetector)
    .init({
        resources: {
            en: { translation: translationEN },
            de: { translation: translationDE },
        },
        fallbackLng: 'en',
        detection: {
            order: ['navigator']
        }
    });

Here i don't want to use localStorage or cookies intentionally, but the i18nextLng entry is created.
P.S.: i found out, that by specifying empty caches parameter, the localStorage is not used:
i18n
    .use(LanguageDetector)
    .init({
        resources: {
            en: { translation: translationEN },
            de: { translation: translationDE },
        },
        fallbackLng: 'en',
        detection: {
            order: ['navigator'],
            caches: []
        }
    });

exactly, because caches: ['localStorage', 'cookie'] is default

The problem isn't just where it is stored, but also the name of the cookie. I mean, the name is clearly indicated in the config, but it is not calling it "lng" and instead it is calling it "i18nextLng". So it seemingly isn't respecting the naming in the config.

@rabidkitten how does your initialization look like?

Here is the full file:
import i18n from 'i18next';
import Backend from 'i18next-xhr-backend';
import { initReactI18next } from 'react-i18next';
import LanguageDetector from 'i18next-browser-languagedetector';
i18n
.use(LanguageDetector)
.use(Backend)
.use(initReactI18next)
.init({
backend: {
/* translation file path /
loadPath: '/translations/{{lng}}.json',
},
fallbackLng: 'en',
debug: false,
/ can have multiple namespace, in case you want to divide a huge
translation into smaller pieces and load them on demand */
ns: ['translations'],
defaultNS: 'translations',
keySeparator: false,
interpolation: {
escapeValue: false,
formatSeparator: ',',
},
react: {
wait: true,
},
// order and from where user language should be detected
order: ['querystring', 'cookie', 'localStorage', 'sessionStorage', 'navigator', 'htmlTag', 'path', 'subdomain'],
// keys or params to lookup language from
lookupQuerystring: 'lng',
lookupCookie: 'lng',
lookupLocalStorage: 'lng',
lookupSessionStorage: 'lng',
lookupFromPathIndex: 0,
lookupFromSubdomainIndex: 0,

// cache user language on
caches: ['localStorage', 'cookie'],
excludeCacheFor: ['cimode'], // languages to not persist (cookie, localStorage)
// optional set cookie options, reference:[MDN Set-Cookie
// docs](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie)
cookieOptions: { path: '/', sameSite: 'strict' },

});
export default i18n;

@rabidkitten your config is wrong...
all detection options needs to be placed inside the detection options:

I asked myself the same question, but where does 'i18nextLng' come from?
it would be good to clarify that the module adds by default in the localStorage i18nextLng

I asked myself the same question, but where does 'i18nextLng' come from?
it would be good to clarify that the module adds by default in the localStorage i18nextLng


Bacalhau docker run does not respect docker image updates

Context
If you run a docker image on Bacalhau, update the image, and then try to run it again, Bacalhau does not use the latest image.
Steps to Reproduce
Create a basic dockerfile that echos something
FROM ubuntu
CMD echo "Hello World!"
# CMD echo "¡Hola Mundo!"

Now build the image and push to DockerHub
$ docker login
$ docker build -t <username>/<image_name>:tag .
$ docker run <username>/<image_name>:tag
> Hello World!
$ docker push <username>/<image_name>:tag

Now run the image on Bacalhau
$ bacalhau docker run <username>/<image_name>:tag
$ bacalhau describe <job_id>
 > stdout: |
         Hello World!

Now uncomment the line echoing Hello World in Spanish and rebuild + push image using the same name and tag
$ docker build -t <username>/<image_name>:tag .
$ docker run <username>/<image_name>:tag
> ¡Hola Mundo!
$ docker push <username>/<image_name>:tag

Now try to run the image again in Bacalhau
$ bacalhau docker run <username>/<image_name>:tag
$ bacalhau describe <job_id>
 > stdout: |
         Hello World!

Bacalhau continues to echo Hello World even though the image has changed.
Expected Behavior
Bacalhau always uses the latest image from DockerHub.
Thoughts
Is this expected behavior? I think it could get really confusing if Bacalhau only remembers the first version of an image it runs.
I can also reproduce this using no tag (latest). Docker only seems to remember the first time the image is run. After that first run, Bacalhal does not seem to recognize any updates to the image on dockerhub.
My guess is that Bacalhau is caching the image and not invalidating the cache if the image digest has changed on DockerHub.
Workaround
Whenever you make an update to an image, always use a new tag or name.
Environment
Client Version: v0.3.19
Server Version: v0.3.19

SOOOO i think you will find this is actually the docker daemon. The issue is that docker will not redownload an image if the tag is the same as the one it's already downloaded.
We actually had a bug to warn the user that we were using a cache - https://github.com/filecoin-project/bacalhau/issues/1603
I wonder if there's a better way?

BTW, the reason your thing works is because you've actually cached the new tag with the new build. if you set up two environments side by side, and execute in the other one, you'll note that it doesn't pull the cache.

Got it. That makes sense if I am using a tag, but what about when I am not using a tag?
I see when I run an image without a tag I get a message as implemented in https://github.com/filecoin-project/bacalhau/pull/1763
$ bacalhau docker run <username>/<image_name>
> Using default tag: latest. Please specify a tag/digest for better reproducibility.

I think I am a bit confused on how https://github.com/filecoin-project/bacalhau/issues/1603 was resolved. According to my testing, no-tag images ARE cached and NOT refreshed when updated. When I update a tag-less image and run it in Bacalhau, it never runs the latest image. The image is always set to whatever it was when it was first run.
If Bacalhau is using the default tag: latest, I would assume it is using the latest, but it's not.
I would argue that https://github.com/filecoin-project/bacalhau/pull/1763 does not fix https://github.com/filecoin-project/bacalhau/issues/1603.

Not sure any message within the CLI would be sufficient. Perhaps find a way to work this into the docs. Thanks for your help. Closing this one now.

Yeah, i'm really sorry about this @jsolly - it's just what we've been given with Docker. It IS interesting, what if we blocked on NOT using a tag? Or asked for an extra flag if not?

No, I don't think blocking is a good idea. The lower barrier to entry, the better...and most people don't appreciate being corraled like that.
I think a FAQ that covers common 'gotchas' might be nice, but this was purely a user error on my part for not understanding how Docker works.


Update url_helper.php

redirect refresh added to time

The 'Refresh' header is a non-standard one and while we may keep it for backwards-compatibility, we won't be enhancing its support.


  That was added a little while ago.

v run <whatever.v> automatically deletes the binary after it is run. That was added a little while ago.

where is it?

Get the latest version of V.

Closed. See https://github.com/vlang/vscode-vlang/pull/196#issuecomment-751408395.


Feature/third qi choice

Now the third option actually works. One source of truth... removed column/field need_advisor from project.

Looks Good


Is Development still Happening or is this project Dead?

It's not dead. I'm currently taking a break and I'll continue development later this year. There are many things to do: bugfixes, Babel instead of Traceur, ES6 classes, and more.

Nice!! Can't wait for the react integration. Spider is the only thing that's going to keep me on nodejs or iojs platform. I was planning to switch to Go because of all the headaches we had with coffeescript. Plus I like the go syntax maybe a gofmt like formatter might also do good to make code standardised.

I was planning to switch to Go because of all the headaches we had with coffeescript.

@pyros2097 Of course, this probably makes sense to you, but I have no idea what you are talking about here. What is CoffeeScript has to do with this? :smile:

So we do all my backend code in coffeescript and sometimes get a lot of weird errors even in production  untraceable and its mostly related to some variable being undefined or overwritten or some the way coffeescript transpiles to, without us knowing it. So after I found out spiderscript had features like Go and also threw a lot of compiler errors if something was wrong with your code (which btw coffeescript doesn't do) I was impressed and planned on rewriting some of my projects to spiderscript.

Fair enough. You can also use plain JavaScript.

Nooooooo.........oooo!!!!!! Its been 3 months already !!

Hi @pyros2097 "Go" like syntax has inspired more than one javascript transpiler project, you may want to check yosbelms/cor if still feel Go-syntax passion.

@yosbelms Cor seems interesting ... especially the way classes are initialized .. gives way to declarative interfaces.. thanks.