[9.x] Add modulepreload links for Vite assets

It is currently possible to end up with a waterfall problem where the entrypoints end up importing a chunk that was externalized to be shared between various entrypoints. Depending on the how the dependencies are determined, it could turn into a rather large waterfall of requests. This PR adds a step of converting the entrypoint's imports into <link rel="modulepreload">s.
modulepreload isn't terribly well supported right now. However, the Vite documentation says to import a polyfill to account for it. I think that how Laravel handles the inclusion of that polyfill as beyond the scope of this PR. As far as I'm aware, browsers that don't understand modulepreload will just ignore them. I believe this PR could be merged without any negative impact and then followed up with another one to resolve the handling of the polyfill once a decision is made.

Hi @Magnesium38,
Thanks for this. With regards to the polyfill, I think the easiest solution would be to add the import to the app.js file in the skeleton, Jetstream, and Breeze. Unless you can think of a better solution?

Hey @jessarcher,
Yeah, I think including it in the skeletons and such would be a reasonable option, although personally I can say that I always immediately blow away the skeletons and it should be called out in the docs somewhere in the Vite section if that's the route that's chosen. It's definitely the simplest solution because it means that it isn't something that Laravel has to maintain in any way.
I had the thought that if Laravel were to generate a modulepreload link that it could also create an additional script that includes the polyfill. It's fairly lightweight so I don't think it would be a terrible solution. I think this falls apart once we take other Vite plugins into account. To be fair, they should have the chance to do work on the polyfill if they wanted to.
That could maybe be alleviated by always creating an entrypoint that includes only the polyfill that would also get added transparently. As in the laravel-vite-plugin would inject an additional entrypoint that has a known name, then the @vite directive would additionally output that chunk if it necessary.
On the plugin side, I haven't looked at all if it would be possible, but I think the most reasonable solution would be if the laravel-vite-plugin would automatically inject the polyfill into the entrypoints based on the same Vite config property (build.polyfillModulePreload). That way it's transparent on the framework side and is solely the responsibility of the plugin. I feel like this is the most appropriate solution and the closest to how Vite would work on it's own.

@Magnesium38 thanks again for this PR. We have been experimenting on our end with this.
We have been unable to create a situation where we found that modulepreload had a noticeable positive impact on load times - even in Chrome where the feature is natively supported.
We also found that the polyfill made things slower in other browsers as it would attempt to fetch the same resource multiple times, often fetching the same resource twice at the same time.
With back-end implementations, because the polyfill is in the entrypoint, it means that the polyfill is not even activated until after the entrypoint has been loaded and executed. We have considered injecting the polyfill for developers before the script tags instead of having it in the entrypoints, but we still were not able to find a positive impact.
Although I understand in theory this feature makes sense and it is available in other back-end Vite implementations, we are hesitant to merge it until we can see a reproduction of the feature having a noticeable positive impact on performance. It could just be our contrived testing that is the problem.
If we can see this feature in action and having an improvement, we would re-consider it for sure.
Thanks again.

@timacdonald Thanks for the detailed response on this. I can agree that waiting on this is sensible choice. I knew going into creating these PRs that I likely wouldn't be able to prove what was broken. It's always difficult to simulate real world usage.
I made this PR and #42935 because I have a project that I'm wanting to immediately pivot into using Vite and they both address potential issues that I discovered whilst playing around with the prerelease. The project scale is small enough to likely not be affected by the potential waterfall issue and we use Tailwind for the CSS so duplicate files is pretty unlikely too. However, it'll be a better playground to test performance against at the least. Once the project is decently established I'll do some performance testing and follow up with some more tangible data if I can see any notable results.
Again, thanks for the detailed response. It's much appreciated!

Would love you to follow up with anything you find! Thank you ❤


Explain why custom style expressions don't work with Point Clouds

I was trying to get a point cloud to have a custom expression, and I copied the following snippet directly from the doc:
var style = new Cesium.Cesium3DTileStyle();
// Override show expression with a custom function
style.show = {
    evaluate : function(feature) {
        return true;
    }
};

But to my dismay, it crashes!
TypeError: this.show.getShaderFunction is not a function
TypeError: this.show.getShaderFunction is not a function
    at Cesium3DTileStyle.getShowShaderFunction (http://localhost:8080/Source/Scene/Cesium3DTileStyle.js:1603:67)
    at createShaders (http://localhost:8080/Source/Scene/PointCloud.js:934:39)
    at PointCloud.update (http://localhost:8080/Source/Scene/PointCloud.js:1384:13)
    at PointCloud3DTileContent.update (http://localhost:8080/Source/Scene/PointCloud3DTileContent.js:329:20)
    at Cesium3DTile.process (http://localhost:8080/Source/Scene/Cesium3DTile.js:1370:23)
    at processTiles (http://localhost:8080/Source/Scene/Cesium3DTileset.js:1890:22)
    at Cesium3DTileset.prePassesUpdate (http://localhost:8080/Source/Scene/Cesium3DTileset.js:1750:9)
    at PrimitiveCollection.prePassesUpdate (http://localhost:8080/Source/Scene/PrimitiveCollection.js:384:27)
    at prePassesUpdate (http://localhost:8080/Source/Scene/Scene.js:3205:20)
    at tryAndCatchError (http://localhost:8080/Source/Scene/Scene.js:3301:13)

Sandcastle.
@lilleyse mentioned it was because the Point Cloud shader backend doesn't support custom expressions like this. This limitation is alluded to in the spec. But it's weird as a user to try something directly out of the docs and get a non-meaningful error.
We could potentially support it by creating some kind of on-the-fly shader recompilation as the value changes, but for now we should at least mention something in the docs, or better yet, have the error that comes up explain this.

I don't see an error in the console when I view the Sandcastle example. Is this issue still current?


[TextFiels] floating label should change color depending on focus state

See https://material.google.com/components/text-fields.html#text-fields-labels
Colored when focused, grey when not

good

Can you share the code you use? Because the color of my floating label is changing based on the focus state.
const TextfieldWithFloatingLabel = MKTextField.textfieldWithFloatingLabel()
  .withPlaceholder('Number...')
  .withStyle(styles.textfieldWithFloatingLabel)
  .withFloatingLabelFont({
    fontSize: 10,
    fontStyle: 'italic',
    fontWeight: '200',
  })
  .withKeyboardType('numeric')
  .build();

I should have added: when text is entered, I mean yes the color changes when the label goes from big (placeholder) to small (small label above) and vice-versa, but once I enter text, that small label's color should depend on the focus state too.
<MKTextField ref={this.ref} // this is a method
  value={String(value)} // comes from redux-form
  placeholder="Test"
  floatingLabelEnabled={true}
  highlightColor="#00ACC1" // cyan600
  style={{}} // must set it even if empty, otherwise the height of the fields is broken
  textInputStyle={{color: '#222'}}
  {...props} // rest of redux-form props like onChange, except name/value/touched/error
/>

Note that I have to pass a style prop even if empty, otherwise the height of the fields is broken O.o

Much more detailed thank you! Will take a look


Can't call plugin methods or maybe just documentation issue

Perfect code, excellent documentation & cool examples...
However I can't found what I need :( for some reason.
All I need is to simply add few tags using Javascript into already created input element, not during initialization (using perfect declarative way which shown 1000s times in docs / examples)
I.e. I go over all docs, but seems can't found the way how to invoke textext plugin methods!
For example, if I need to call some methods in 'ItemManager' (http://textextjs.com/manual/itemmanager.html), I can easy do something like (the bad thing that no such examples at all in the docs):
  var textext = $('#keywords').textext()[0];
  var item =  textext.itemManager().stringToItem('cool');

However, when I tried to call something like:
  var textext = $('#keywords').textext()[0];
  var item =  textext.tags().addTags(['hello','shit']);

It just fails....
The same happens with:
  var textext = $('#keywords').textext()[0];
  var item =  textext.TextExtTags.addTags(['hello','shit']);

etc.
I.e. seems can't found any "easy" way to call dirrectly plugin methods??? Strange.. because I think every such library should have at least methods which are easy accessible and documented well, like $('#keywords').textext()[0].addTags('hello','shit') or var tags = $('#keywords').textext()[0].getTags() etc.
Am I miss something?
Big thanks!

+1
Simple question: How do you add TextExt tags programmatically?
On http://textextjs.com/manual/examples/tags.html I see an addTags(tags) method... but can't find the pointer to call it correctly.

@seanodotcom @evereq Thanks for feedback, I released "emergency" 1.2.0 which just includes this feature, please see the demo
http://textextjs.com/manual/examples/tags-adding.html

excellent and quick! Thanks! :)

Side note: if you select order of plugins for example like "plugins: 'prompt focus autocomplete arrow tags'" than yes, feature works. However if you use order like 'tags prompt focus autocomplete arrow' new feature do NOT work for some reason :) Spend few minutes today to figure out this :D Seems you may need to fix it in next version ;-)

I used this to add any text remaining in the input as a tag upon form submission (something I think is expected behavior for tag inputs, by the way).
I can confirm evereq's issues as well: the feature will expect 'tags' to be the last plugin specified in the options parameters.  Otherwise, it will select whichever plugin is last instead.
   $('#form_element').submit(function(){
      var input_element = $('.textext-input-element');
      input_element.textext()[0].tags().addTags([ input_element.val() ]);
   });

Hi evereq!
Try it:
$('#keywords').textext()[0].tags().addTags([ { name: 'Hello', id: '1' },{ name: 'Shit', id: '2' } ]);


Remove history page link from register homepages

Is it safe to remove this usage also? https://github.com/openregister/deployment/blob/e48989bf81062ce8365a83247707bd388675554f/ansible/roles/openregister_config/templates/openregister-config.yaml.j2#L108

The issue is just talking about to remove them from the config generation. It says explicitly not to remove the code that make them configurable.


Add the possibility to bulk create entities

for POST /sources/ and POST /source/:id/targets/

implemented POST /source/bulk for now.


fix #148 auto-updating p5 libraries

use a single tag_name for the p5.js release to determine if it's necessary to update p5.js, p5.dom.js and p5.sound.js. Individual tags for each file are no longer part of the github api.
don't overwrite files if there is any error
check to see that all of the files have /*! p5 at the beginning before overwriting

Thank you!!


[RFC] ProjectSettings magic removal

Clean up some of the settings

Yeah, maybe it's just as well to scrap that code for now, and rather remake other camera modes when/if needed. It will make the rewrite much easier if we eliminate some dead/non-functional code first.
What do you think, @StraToN?

I added two commits that help a bit with customization.
I tried asking around on irc, and looking online, but couldn't find any good information on how to deal with references within the scene tree and gave up.
To make working on Escoria easier, like not having to pick commits and worry about your game messing with the Escoria tree, this should be the general strategy.
Anyway, this branch should be mergable IMO. Comments?

What kind of references are you thinking of? If you are thinking of how to navigate the scene tree, you should find the information you need in
http://docs.godotengine.org/en/3.0/getting_started/step_by_step/scene_tree.html
and
http://docs.godotengine.org/en/3.0/classes/class_node.html
You can always find a node in the current scene by navigating from get_node("/root") or the equivalent $"/root".

device/ui/hud.tscn contains lines like these
[ext_resource path="res://globals/hud.gd" type="Script" id=1]
[ext_resource path="res://ui/inventory.tscn" type="PackedScene" id=2]

So basically even if the path to hud.tscn could be a setting in ProjectSettings (I don't know if it can, but these are very recursive anyway so my point is the same) can res://ui/inventory.tscn be a setting and hud.tscn look it up?
I don't think it can, which means copies need to be made and altered accordingly, or something, but it would be nice if this could be decoupled.
Did make it more understandable?

Ah, I see what you mean now. No, I don't think that's possible, but I'm thinking that hud.tscn isn't something a developer should need to touch, but the inventory and verb/action menu, etc. should be instanced from code and have their location defined in project settings, since those are likely to be modified by a developer.

Yeah, maybe hud.tscn doesn't require that, but can we then have it so that hud.gd looks up the setting and injects it into hud.tscn ?

If we don't hear from @StraToN this weekend and you're eager to get this PR merged (I am), what I would be most comfortable with is:

squash your commits from 14th February (d723a1c through 5d708f1) into a single "settings revamp" commit
keep 9700ebe as it is. I'm not 100% sure about it, but I think it's a good idea, and that way it will be easy to change back if needed.
change 1600726 to still check for escoria/platform/use_custom_camera, but set the default to true in the project settings (I think that requires a rebase with the previous commit hash and edit on this one, but I'm not 100% sure).
squash the last three commits into another settings related commit

I'm sorry for bugging you with this, but I think it would give a cleaner and more meaningful graph, and it hopefully isn't too much work for you.

I did the proposed changes in my own branch, which you may force into your own, if you agree with the changes: fleskesvor/escoria/commits/projectsettings-magic
This is my rebase:
git rebase -i 6f583e6a6a4b8a71f7df8a554402b88e506a90db
pick d723a1c Collect escoria settings in one place
squash 20996da Update get_settings for old application
squash fdedf0d `print_clicked_control` was not referenced anywhere
squash 3a55c9e Update get_setting for old debug
squash 4868a41 Update get_settings for old display
squash 6935d00 Update get_settings for old platform
squash 17c5b2e Remove bunch of unreferenced settings
squash 5d708f1 Update get_settings for old ui
pick 9700ebe Prefer Godot's window handling code over old custom
edit 1600726 Use regular camera instead of magic custom camera
squash d3258f9 Implement unreferenced force_text_ids
squash bf652bc Do not hard-code the path to in_game_menu
squash 01b0043 confirm_popup does not have to be hard-coded either

@fleskesvor ok, commits d723a1c through 5d708f1 are easily squashed and having had them separate has served its purpose. I may do that now because I don't know if it matters to @StraToN but the old commits are still available for reference and can be reverted and so on.
c0f9b5d has replaced what once was 9700ebe, because of amending the variable removal.
I dislike the idea of leaving "custom camera" in there. It's undocumented magic code that breaks everything. Naturally if you wish, I will comply, and setting it to true is a huge win.
I will not diverge my fork from being all about PRs into something I primarily use, but because I feel strongly about this (for whatever reason :D) I feel I have to open an issue about deprecating it.
I get a notification about your rebase while typing things here, I'll investigate and see.

git reset gh-flesk/projectsettings-magic ftw. I also re-edited in the removal of game_size, as stated in the new commit message.

I dislike the idea of leaving "custom camera" in there. It's undocumented magic code that breaks everything. Naturally if you wish, I will comply, and setting it to true is a huge win.

It's not that I have strong feelings about it, but I find it difficult to tell if there are use cases where removing it might break things, and I'd prefer to let someone else make that call.

I will not diverge my fork from being all about PRs into something I primarily use, but because I feel strongly about this (for whatever reason :D) I feel I have to open an issue about deprecating it.

This is a good idea.

The PR has some regressions for the test scene compared to previous commits, since it now runs in windowed mode with the scene positioned in the bottom right corner, but the current head of master does not work at all, so overall it's an improvement.
Thanks for the contributions, @mjtorn. 🙂

@fleskesvor thank you for merging :)
As for regressions and such, my prototype repo is so messed up wrt the main Escoria development, I will have to recreate the prototype game as a submodule when I have time at the office.
This may give me insight into how to fix the test scene, but I think it's best someone else look into the test scene and such, because that's a second opinion.


Improve search UI

[ ] Compact filter UI
[ ] Able to use filters without query

Wait until ElasticSearch lands

BLOCKER
Pending change to a shared elastic search between holodex and musicdex. Search ui might need to support both Vue and React, depending on future of Holodex migration


Disabled Feature-specific Segment Overrides interfere with isFeatureEnabled evaluation

Describe the bug
Feature-specific Segment Overrides interfere with the evaluation of isFeatureEnabled even their individual toggle is disabled
Given that I have a Feature in the Development environment that has configured a Segment Override based on a "trait" which is a numerical value and using the IN clause (in my example: "deployment_id" IN (179,8161),
When the Feature is Enabled, and the Feature-specific Segment is Disabled
Then the Feature-specific Segment interferes with the computation, considering the feature disabled for this case (even though the feature-specific segment condition is 'true')
Instead it should ignore all disabled segments and return according to the global feature status (in this case disabled)
To Reproduce
Steps:

Go to a Edit Feature
Click on Enable so the feature is enabled
Click on Segment Overrides
Create a feature specific segment with a condition that can be true for the values of the traits we are going to evaluate
Evaluate the feature using the Java SDK -> the result to isFeatureEnabled is "true" --> CORRECT
Disable the feature specific segment using either the individual toggle or the disable all button
Evaluate the feature using the Java SDK -> the result to isFeatureEnabled is "false" -> this is the ERROR
Remove the "feature specific segment" leaving the feature with no segments (using the bin button)
Evaluate the feature using the Java SDK -> the result to isFeatureEnabled is "true" --> CORRECT

Expected behavior
Having a disabled feature-specific segment should have the same computational effect than deleting the segment it, however, as described above it doesn't, and it is being strangely applied
Screenshots

How are you running Flagsmith?

[ ] Self Hosted with Docker
[ ] Self Hosted with Kubernetes
[x] SaaS at flagsmith.com
[ ] Some other way

Additional context
We are currently evaluating Flagsmith with a Free plan

Hi @guillemcorominas, thanks for the detailed bug report. If I am understanding correctly, I think this is just a misunderstanding of how the Flagsmith segments work. The value of the toggle that you have included in the screenshot is the 'enabled' value that will be provided to any identity that evaluates as 'in' the segment. If you want to 'disable' the segment from affecting evaluations, you need to remove the segment from the feature entirely, as per steps 8 & 9 in your description.
Essentially, if a segment is shown in the list of segment overrides on a feature, it will always have an effect on the value that is given to any identities that match that segment (ignoring any ordering).
Hopefully that helps to clear things up here?

For more context, this essentially allows you to use segments to override features that you might want 'on' by default, but turned off for a given segment of your users.

Hi Matt,
I understand your answer, however, it is then not very intuitive to me. If
I understand correctly, what Flagsmith does then is "negate" the segment,
which is very different to disabling it. Additionally, given that you are
using the same UI toggle for both the feature enable/disable and the
segment toggle, it is confusing.
Anyway, I still believe that it make sense to disable a segment (without
deleting it), for example to prepare a rollout to be applied certain day.
But that is up to you.
Thanks for the fast response,
Guillem
El dl., 8 de gen. 2024, 14:48, Matthew Elwell @.***> va
escriure:

For more context, this essentially allows you to use segments to override
features that you might want 'on' by default, but turned off for a given
segment of your users.
—
Reply to this email directly, view it on GitHub
https://github.com/Flagsmith/flagsmith/issues/3247#issuecomment-1881045229,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFEL5XNUJWEQ6RV2MZ7VX3YNP2KVAVCNFSM6AAAAABBRKUNB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGA2DKMRSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

It's not negating the segment. The toggle widget you highlighted in your original screengrab is just showing what the boolean state of the flag will be if that segment override takes effect.
So for example, the if the environment default of the flag is On, but you want to override for a segment to turn it Off, thats what your screen grab is showing.

Hi Ben, nice to meet you and congrats for the product you guys are building!
I think we are saying the same thing: when I say negating I mean applying
the inverse to the result of the evaluation function. So if the evaluation
function is user_role = 'ADMIN' and the toggle is enabled, it will let
admin users use the function. If the toggle is disabled (like in my
screenshot), it will explicitly block the access to the feature to admin
users (even if the feature is enabled globally).
I understand your point that it is not a bug, however I find this toggle
confusing and probably requires some UI/UX change (label/component
type/placement/etc) to make it cristal clear what it does.
Those are my five cents, I hope you take it as constructive feedback
Cheers
Guillem
El dl., 8 de gen. 2024, 17:41, Ben Rometsch @.***> va
escriure:

It's not negating the segment. The toggle widget you highlighted in your
original screengrab is just showing what the boolean state of the flag will
be if that segment override takes effect.
So for example, the if the environment default of the flag is On, but you
want to override for a segment to turn it Off, thats what your screen grab
is showing.
—
Reply to this email directly, view it on GitHub
https://github.com/Flagsmith/flagsmith/issues/3247#issuecomment-1881442440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFEL5U7N6S6QA3V5YO6R2TYNQOSRAVCNFSM6AAAAABBRKUNB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGQ2DENBUGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yeah I get where you are coming from, but theres no concept in the platform of "negating" a default flag or similar.


Handle abs path mounts and init global Config using overwrite method

fix #133

LGTM, thanks @carlmontanari


Allow for passing a callback function as "displayName"

I'm submitting a feature request

Library Version:
1.0.0-beta.1.0.0

Current behavior:
The FluentRules.displayName()  method takes a string.
Expected/desired behavior:
For cases where the displayName is dynamic (varies due to other control values) I need a way to return the a calculated display value.  A callback function that returns a string would be ideal.

What is the expected behavior?
When building the error message the StandardValidator.getMessage() call would check if displayName is a function, and call it if it is.

closing- this has been added


[Feature] Inter-cluster low-level tablets replication

Feature request
Is your feature request related to a problem? Please describe.
We need a feature to implement a High-availability Starrocks cloud architecture.
There will be two starrocks clusters: Main & Standby. The Main cluster will be serving all the normal read/write/ingestion workload. The Standby cluster will have the same topology(i.e. same number of BE node) and receive the  tablets  updates that are caused by the Write/Ingestion happening on the Main cluster.
As the sync of tablets are happening as low-level I/O operations, the actual computing resources on the Standby cluster should be very minimal.
In this way we could have Standby cluster mirroring the Main cluster in real-time with minimal computing resources. And in case of failure in Main cluster, we could seamless failover to the Standby cluster.
Describe the solution you'd like
Describe alternatives you've considered
N/A
Additional context

I think you can consider our next-generation architecture, which will decouple the storage and computing. In this architecture, all data will be stored in S3. You even don't need a stand-by computing cluster at all.
When the Main cluster crash, you can create the stand-by cluster and start to serve.

Will the performance, e.g. query latency be significant higher when storing data on S3 v.s. on a SRs managed EBS disk?

When the data is stored in S3, it will be slower to read data from S3 than from EBS/local disk. But starrocks has local cache, if all the data is cached in local disk, the speed will be the same


Could not load file or assembly System.Interactive.Async

I recently updated to newest version of firestore 1.0.0-beta20 (from version beta11) - everything runs ok on windows but when I upload my app (dotnet core 2.1 app) to linux with installed dotnet core 2.1 than I get following error
Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'System.Interactive.Async, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=94bc3704cddfc263'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)    at Google.Cloud.Firestore.Query.GetSnapshotAsync(ByteString transactionId, CancellationToken cancellationToken)    at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)    at Google.Cloud.Firestore.Query.GetSnapshotAsync(ByteString transactionId, CancellationToken cancellationToken)
I also tryed to install nuget pacage System.Interactive.Async, but wit no success. (I tryed several versions)

Please could you show me what your project file looks like so I can check all the dependencies? I'll try to reproduce this tomorrow.

Sorry it look that problem was on my side - Reinstalling of firestore nuget fixed it

Hooray - my favourite kind of issue :)


Fix multiturn conversation error Groq

Fixes #289

Groq assistant turns can only have content: <str>, no arrays or multimodal
Warning that Groq cannot handle response_format argument: This is because the way that its passed, I'm working on a separate commit for that.

I'm working on getting Groq to handle response formatting I got it working in some tests, don't merge yet

https://console.groq.com/docs/text-chat

I'm not sure we should add response format to this because it opinionates the library with a specific prompt

I agree. I‘ve also been working on patching it with Instructor if that’s preferable.
On Sun, Oct 20, 2024, at 08:52, William Guss wrote:

I'm not sure we should add response format to this because it opinionates the library with a specific prompt —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this bec
DuckDuckGo removed one tracker. More https://duckduckgo.com/-if6B_sAfHNraFo0CMIcrW83c1-qRmgrchFeLTlLZ5v_xXoqjbAbwPBJTLITdtztT8xgAwNCYID6j1yPZTBCzpCvQ1AQhC4v-UCzcfJ3cv6RPi6Vj5VX-7vzm-W6kvYI3KGzI0-yUdDLn1nJzzF8_30S0fk1mVih5SEAPQyKDtFyHTuH3jzfFMy92iYAxP3wIdte0mEPoYltTnWhqktZcmNZR-F-Ep7Ihy9_AFNyAjT3HCxER0LMx6HUiE9aADtyGXo2dqffvRAmZOWEX3TbFEk_gatHyqmZtBQp67WNE08C9FW7RJG6f8AF1Qe1p1pRXZh8gFiAwtfjt533uAlk6MZ2HfSyS2f-4pnv_sBSpkW3Wn19vPRCR2PzSoilyY0zYIZRHWLqZofBGtVamrEwDvUlEIdqkDAtl5EBqZ_f7I8H5fKX-V7EixTDXK3bLiJHUPYpDYK
Report Spam https://duckduckgo.com/-if6B_sAfHNraFo0CMIcrW83c1-qRmgrchFeLTlLZ5v_xXoqjbAbwPBJTLITdtztT8xgAwNCYID6j1yPZTBCzpCvQ1AQhC4v-UCzcfJ3cv6RPi6Vj5VX-7vzm-W6kvYI3KGzI0-yUdDLn1nJzzF8_30S0fk1mVih5SEAPQyKDtFyHTuH3jzfFMy92iYAxP3wIdte0mEPoYltTnWhqktZcmNZR-F-Ep7Ihy9_AFNyAjT3HCxER0LMx6HUiE9aADtyGXo2dqffvRAmZOWEX3TbFEk_gatHyqmZtBQp67WNE08C9FW7RJG6f8AF1Qe1p1pRXZh8gFiAwtfjt533uAlk6MZ2HfSyS2f-4pnv_sBSpkW3Wn19vPRCR2PzSoilyY0zYIZRHWLqZofBGtVamrEwDvUlEIdqkDAtl5EBqZ_f7I8H5fKX-V7EixTDXK3bLiJHUPYpDYK
I'm not sure we should add response format to this because it opinionates the library with a specific prompt
—
Reply to this email directly, view it on GitHub https://github.com/MadcowD/ell/pull/312#issuecomment-2424945813, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYA6EZYBTD4U7LMHPTTJ6LZ4ORSVAVCNFSM6AAAAABP6KLR3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRUHE2DKOBRGM.
You are receiving this because you authored the thread.Message ID: @.***>

@MadcowD Is there any good reason not to leverage Instructor for that? It is widely used and better to not reinvent the wheel if it works well. Also, if I understand correctly, adjusting the system prompt is one of the techniques Instructor uses to coerce tool use and structured responses.

@reecelikesramen  i prefer folks ot use instructor and override the client etc (see instructor_ex) file for now. I'd like to merge this but I need you to remvoet he "resposne_format" stuff would you mind doing that so we don't add a system prompt to the library?

@MadcowD here, I reverted to the first commit of this PR which handles just the stated issue

Wooo thank you


Disputed step is not validated

newDisputedStep is computed, but it is not validated that the disputed step is being replaced with a different step.
(This fact also seems missing from the spec?)

Currently, the following happens:

The dispute witness is validated to ensure that the dispute hash is in the merkle tree.
The last hash in the hash list replaces the dispute step. We ensure that the last hash is different from the disputed hash.

What other step(s) would you add?


Move away from deprecated Redis commands

Currently getting this warning :
[sidekiq#5788] Redis has deprecated the `zrangebyscore`command, called at ["~/.rvm/gems/ruby-3.2.0/gems/sidekiq-scheduler-5.0.2/lib/sidekiq-scheduler/redis_manager.rb:109:in `block in get_schedule_changes'"]

We should move away from deprecated redis commands.
Sidekiq did it already, might contain useful pointers to help the transition :

https://github.com/sidekiq/sidekiq/issues/5788
https://github.com/sidekiq/sidekiq/commit/1aca434e5cd830cbd0020f1f82ef3a3cb6b2d477

We have already migrated away https://github.com/sidekiq-scheduler/sidekiq-scheduler/pull/437, I just didn't have time to push a release. I will keep the issue open until I push the release


Document how ANCM generates log file names

Fixes #3906
Related: aspnet/AspNetCoreModule#130
Reference: https://github.com/aspnet/AspNetCoreModule/blob/93b37e14db9d568dc4b13b9956b74fa4d3b48c7d/src/AspNetCore/Src/serverprocess.cxx#L1207
cc/ @bgever @pan-wang @shirhatti

Thank you! 👍🏻


fails to recognise default module.exports

example from aws-promised
'use strict';

var AWS = require('aws-sdk');
var memoize = require('./lib/util/memoizeWithOptions');
var promisifyAll = require('./lib/util/promisifyAll');

function cloudFront(options) {
  return promisifyAll(new AWS.CloudFront(options));
}
module.exports = memoize(cloudFront);

The above results in the error '\'default\' is not exported by node_modules/aws-promised/cloudFront.js
Changing the last line to this makes it work:
export default memoize(cloudFront);

same issue here.
it seems this plugin is unmaintained?

@boussou it is maintained. @BryanCrotaz show your config. Also changing to export default will prevent converting require to import in this module.

@TrySound I am glad to know  ;-)
I myself just treid the sample from the repo:
// cjs_exporter.js

This does not work::
//module.exports = { show_named: show_named };
//exports.show_named=show_named;

I am forced to do this :
export {  show_named };

Error log:
or
rollup v1.19.4
bundles src/example-script.js → built/main.js...
[!] Error: 'show_named' is not exported by src/modules/cjs_importer.js
https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
src/modules/another-module.js (21:9)
19:
20:
21: import { show_named } from './cjs_importer';
	     ^
22:
23: show_named();
Error: 'show_named' is not exported by src/modules/cjs_importer.js
    at error (/usr/lib/node_modules/rollup/dist/rollup.js:9435:30)
    at Module.error (/usr/lib/node_modules/rollup/dist/rollup.js:13407:9)
    at handleMissingExport (/usr/lib/node_modules/rollup/dist/rollup.js:13327:21)
    at Module.traceVariable (/usr/lib/node_modules/rollup/dist/rollup.js:13712:17)
    at ModuleScope.findVariable (/usr/lib/node_modules/rollup/dist/rollup.js:12422:39)
    at Identifier$1.bind (/usr/lib/node_modules/rollup/dist/rollup.js:8348:40)
    at CallExpression$1.bind (/usr/lib/node_modules/rollup/dist/rollup.js:7977:23)
    at CallExpression$1.bind (/usr/lib/node_modules/rollup/dist/rollup.js:10377:15)
    at ExpressionStatement$1.bind (/usr/lib/node_modules/rollup/dist/rollup.js:7977:23)
    at Program$1.bind (/usr/lib/node_modules/rollup/dist/rollup.js:7973:31)

my config
import serve from 'rollup-plugin-serve';
import livereload from 'rollup-plugin-livereload';

import commonjs from "rollup-plugin-commonjs";
import node_resolve from "rollup-plugin-node-resolve";

import buble from 'rollup-plugin-buble';
import sizes from 'rollup-plugin-sizes';

export default {
  input: 'src/example-script.js',

 output: {
    file: 'built/main.js',
    format: 'iife',
    name: 'App',
    sourcemap: true,
  },
  plugins: [
   buble(),
    node_resolve(),
    commonjs(),
    sizes(),
    serve({
    open: true,
    openPage: '/example-pour-rollup-dev.html',
    verbose: true,
    contentBase: 'built',
    host: 'localhost',
    port: 3000,
    headers: {
	'Access-Control-Allow-Origin': '*',
	foo: 'bar'
    }
    }),
    livereload(),
  ],
};

In your case named export is probably hard to recognise. For such cases there is namedExports option where you may explicitly describe all possible exports. If your code can be run in node try this
import * as reactDom from 'react-dom';

commonjs({
  namedExports: {
    'react-dom': Object.keys(reactDom)
  }
}

Maybe I misunderstood the usage of this plugin.
I basically need to migrate a Backbone application. We made the effort to move from AMD to CJS.
And to keep things compatible with existing projects, we would like to keep the commonJS way require/exports/modules (if possible without using es6 imports - but I think it is not).
Thanks for your reactivity btw ;-)

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid.
We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets reopened and transferred to the new repo. :beer:


Update filter for not

Currently, all the items in the list are wrapped within quotes ("). Tho, if the item is a number, it should not be wrapped in them.
I have only changed the not filter because this is the only one I have experience with, but I guess this should be handled at _cleanFilterArray. What do you think?
#32

@bdlukaa
Great point! This is great! Agree that this should be done within _cleanFilterArray!

sure!


monitoring: raise CPU limits for blackbox-exporter container from 50 to 100m

See https://github.com/bfritz/homelab-apps/pull/30#issuecomment-978092480 .

bors r+

Ping stats look much better now:


Add hideFromGraphQL to InverseAssocEdge

When creating an edge, there's no way to hide the inverseEdge from graphQL.

+1 also ran into this the other day


urllib2.HTTPError: HTTP Error 520: Origin Error

hi my python script close some times with this error :
Traceback (most recent call last):
File "start.py", line 82, in
data = api.balance()
File "/usr/local/lib/python2.7/dist-packages/cexapi-0.1-py2.7.egg/cexapi/cexapi.py", line 66, in balance
return self.api_call('balance', {}, 1)
File "/usr/local/lib/python2.7/dist-packages/cexapi-0.1-py2.7.egg/cexapi/cexapi.py", line 53, in api_call
answer = self.__post(url, param)  # Post Request
File "/usr/local/lib/python2.7/dist-packages/cexapi-0.1-py2.7.egg/cexapi/cexapi.py", line 40, in __post
page = urllib2.urlopen(req).read()
File "/usr/lib/python2.7/urllib2.py", line 127, in urlopen
return _opener.open(url, data, timeout)
File "/usr/lib/python2.7/urllib2.py", line 407, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 520, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 445, in error
return self._call_chain(_args)
File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain
result = func(_args)
File "/usr/lib/python2.7/urllib2.py", line 528, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 520: Origin Error
Can you have a look ?
Thanks.

Did you resolve this?

Yeah same here


Application does not cleanup old files wasting disk space on exit

Ran it a few times, job didnt complete cause i ran outnof disk soace.
Apparently it doesnt clean up old image files extracted from videos?
would be tood if i could change the cache paths

Might be a good idea to allow people to skip the resizing procedure as its slow af as well and not nessesary as they may like to keep the image 100% instead of 75%

Hi, actually the "cache folder" cleans everytime starts a new video upscaling.
But i will make it clean when upscale finish, which seems a more correct thing :)
Currently, in addition to resizing the images, qualityscaler prepares them in the best possible way for the passage in the neural network, so it can't skip even putting 100% resize. But i'm also working to make resize faster :)


Agents: Short-Horizon Actor Critic

This is an implementation of https://arxiv.org/pdf/2204.07137.pdf
Not sure if there is interest merging this into the main branch. This might be an algorithm
worth supporting as it leverages the differentiable simulator to outperform PPO according
to the paper.
Note that many of the environments don't actually have rewards that are differentiable
w.r.t. the actions, in which case this algorithm performs poorly. For example, the fast
environment used for testing APG and SHAC isn't. I added a fast_differentiable env and
also made APG use this by default, after which the performance is much better.
Still could do with tuning for environments and replicating the performance benefits seen
in the original manuscript.
Addressed #247

BTW I would love any feedback on this. It seems much slower than I had hoped. I'm not sure if there are some functions that should be fitted, such as the policy gradient function https://github.com/peabody124/brax/blob/shac/brax/training/agents/shac/train.py#L185

Oh wow this is great!  Thanks for the clean implementation!
Could you provide us some benchmarking of this method versus the other ones we support?  Something like training curves vs. Ant for this / APG without this / PPO / SAC with reward and wallclock time on a public TPU colab runtime would be fantastic.  Basically, we want to make sure it's competitive before committing to supporting this.

Hey, nice indeed to see this. Im also curious if the performance benefits claimed in the paper manage to replicate in this implementation., on a scenario not too terribly synthetic.

Great to see the interest! I'm pretty busy right now but hopefully in Feb can get some benchmarking numbers. I'm not blown away by the performance I saw. I was using it with a humanoid environment, but have the impression differentiating through the physics engine causes quite an increase in wall time. This may not be the SHAC aspect, because I see similar things with a PPO modification I made to try and differentiate and optimize some anthropomorphic properties of the models, and enabling this easily halfs the sps.
However, I should tune it up on ant and cheetah and and produce some benchmarks to really evaluate it and see if it is worth merging or something to motivation some optimization.

Re-reading the paper, where they claim noticable gains in wall clock time is really only for the very high degree of freedom walker env they try; which im not sure has an analogue in brax. For the ant there does appear to be a modest objective benefit; but of a magnitude that I can easily see vaporize under an alternative implementation, as these things often do. Still; when you are say you are not blown away by the wall time, what are we talking about? Similar OOM as PPO, or something much worse?
If its true the backprop is not really worth the trouble, its interesting to reflect on that. In theory, backprop should be of a similar computation cost as a forward pass. The results of difftaichi also show this in practice. Is this then more the fault of JAX than anything? Frankly after working with JAX for quite a bit in the past year, im still kinda uncomfortable with the black box nature of some things; the fact that differentiating through a scan 'just works' is pretty cool; but the fact that I have no control over checkpointing, or good visibility as to what is optimized and what isnt, is a little eerie.
Even if the wall clock time is not an obvious win given the constraints of brax/jax, I still think there is value in merging/maintaining this; since it does remain a very valuable benchmark in probing that exact question, as to wether there actually is a point to this whole differentiable physics in JAX thing. If the answer is no, thats also good to know. And aside from wall time, I can see both theoretical reasons, and empirical support in their paper, that a hybrid of a learned critic plus BPTT should converge better / more robustly in some type of environments; which can be a fantastic thing even if you have to wait 10x longer for the result.

@peabody124: hope you dont mind the ping, but im still curious; can you give a one-sentence impression of the kind of performance you did observe, compared to ppo for instance?
@cdfreeman-google: Last time I did a deep dive into brax a year ago I dont think its contact implementation was particularly differentiable. Where would you say it stands today, with respect to the known issues with differentiable contact handling? can we opt in to a moderate penalty based form of contact that should preserve differentiability? Or are there other solutions; or solutions on the horizon? Is there any currently supported (nontrivial) env where you feel SHAC 'should' work fine; or would it perhaps be good to implement something like an inverted cartpole in brax, as a trivially differentiable but not entirely trivial benchmark for this kind of algorithm?

I refamiliarized myself with the latest brax code; looking at this line here I would expect brax to indeed fare poorly in envs that involve contact; since there is no cimpliance term here this line implies that all contact handling is hard contact handling, you will run into issues with your gradients without time-of-impact logic.
It would be a simple fix to add a compliance term into the linked line though; if you can tune your setting such that a compliant contact resolves over several timesteps, allowing for some interpenetration, you will recover differentiable gradients. But with contact handling like this I wouldnt expect SHAC to work very much, if at all, on something like a walker environment.
That being said; contactless systems like a cartpole should still provide a good benchmark I think; and my expectation would be that SHAC would outperform APG or PPO; perhaps in terms of wall time, or total reward.
On a related note; ive been working on really reviewing this PR in detail, and it sure is not easy on me! Its pretty clean code, but all these nested function definitions are hard to isolate and test in isolation; either formally, or just mentally. While I do love JAX functional paradigm, I suppose I am still not as fluent in reasoning about it as I would more traditional imperative code. For the record I have not found anything wrong with it yet; though my code has diverged a lot from the code as it is here in my attempts to pull it apart into more unit-testable components.

Thanks @EelcoHoogendoorn for looking into it.
I totally relate to you on the challenges understanding the different nesting layers of rollouts etc. Quite confusing to track. For another project, I made a modified PPO where various anthropomorphic had to be propagated through the rollouts which also really pushed me to delve into it.
I'm still trying to carve out some time to benchmark this more fully. I know on my humanoid testing, the performance benefits were underwhelming. However, I think there is a lot to be set for a benchmark like you described. The fast differentiable unit test and humanoid where my prior two main tests.

Ive been moving on from the unit testing to some cartpole-benchmarking myself; but to give an initial impression, I am not having much luck yet.
class HardInvertedPendulum(InvertedPendulum):
  def __init__(self, h=0.1):
    super(HardInvertedPendulum, self).__init__()
    self.h = h
  def _noise(self, rng):
    return jp.random_uniform(rng, (self.sys.num_joint_dof,), -1, 1) * self.h

Ive added a tunable hardness parameter since the default cartpole is kind trivial and solved in one epoch by PPO. Its probably just my hyperparams but even with h=0.3 PPO isn't making much progress on this problem, so that does make it an interesting benchmark.
I suppose reverse-engineering the actual intended meaning of the high level parameters would be the first order of busines... just wasted 3 hours coming to realize the importance of the num_evals parameter (I guess in my time the kids used to call that n_epochs; or maybe I still dont understand its true meaning?). Good times. I realize youve just been following the brax conventions; whom in turn are just following what appears to be the broader RL community spirit of 'real men dont need docstrings'. But yeah.

One thing im struggling with is with the intended meaning of num_minibatches. I imagined its only intended to impact the value function training; but it also appears in the length of the policy rollout? It feels wrong that you can completely screw over the sensibility of your policy rollout length by changing a parameter which shouldnt really have anything to do with policy training; but its perfectly possible I misunderstand the actual intent.

Indeed im also getting massive slowdowns in both compile and runtime compared to the same simple env using PPO. (and zero convergence as well so far; though that could very well be a matter of hyperparameters).
Im kinda wondering if the compiler isnt choking a bit here on the sheer number of nested scans. There is the action_repeat scan of the env_wrapper, the num_training_steps_per_epoch unroll scan; (which I kinda doubt adds much value when a single train step already takes a solid amount of time?). And then also the extra scan in rollout_loss_fn to chain multiple scanned unroll_lengths together. The purpose of this nested unrolling is not obvious to me, by the way. Why not just train on / process a single unroll_length trajectory of data at a time? Its not clear to me that the original paper is arguing in favor of such, but I could be missing something.
So I count 3 nested scans just to do a rollout; plus whats specific to the training loop. I dont have any concrete evidence that this might be an issue; but if its half as confusing to the jax compiler as it is to me, it might spell trouble; and I am not aware of any other uses of JAX where this amount of nested scanning is going on. If seen the JAX compiler stack freak out about more mundane constructions; its not that mature yet. But I could be completely off-base here.

Heh; ive moved on to setting up the simplest possible SHAC first; and ive gotten some quite nice results on an inverted pendulum. It did teach me a lot of lessons about JAX development though. Ive become quite adamant about putting shape asserts on all input and output shapes. Its really easy to get disastrous but hard to notice under JITing broadcasting errors with things like your action/reward returning either a shape (1,) or shape (), and so on.

Hi @peabody124 and @cdfreeman-google,
I am wondering if there are any recent benchmarking results comparing how SHAC (or APG) performs on the current Brax environments versus PPO or SAC. I tried training the built-in APG agent but was unable to achieve comparable results to PPO - the agent didn't learn as well.
I attempted the parameters suggested in this issue but ran into OOM errors even on an A100 (80GB) with 1024 parallel environments. The issue comments also indicate APG is much worse than PPO, although with different evaluation settings.
I also tried the implemented SHAC code from the PR but was unable to get the expected level of performance, especially in contact-rich environments.
Have there been any promising benchmarking results yet showing these differentiability-leveraging algorithms like SHAC or APG can match the performance of PPO or SAC on the Brax environments? I'm curious if they can achieve parity.
Please let me know if you have any insights on tuning these algorithms or can point me to recent benchmark comparisons. Thanks!

I didnt try and further for a literal reproduction of the paper. However, I have iterated quite a bit within the conceptual space of learned critics and short horizon differentiable rollouts. My general impression is that many of the specific of the SHAC paper are not essential and can readily be tuned to specific applications. I did not get around to any formal or comprehensive benchmarking but qualitatively I was quite happy getting reasonable performance and decent robustness.

Thank you for your response! @EelcoHoogendoorn
I was wondering if you could provide further details about your personal experiences with SHAC and APG. Have you achieved promising results using Brax or any other environments? Lately, I've been facing challenges while attempting to apply SHAC to more extensive benchmarks. If you have any advice or insights, I would greatly appreciate it. Thank you!

Its not part of a public repo unfortunately; but its a context with a simulator qualitatively similar to Brax; the most salient difference being that the compliance of contacts is configurable using XPBD logic; and the problems I have been applying it to have either been contact-free; or had 'well resolved' contacts, meaning the contacts were sufficiently compliant that theyd be resolved over multiple simulation timesteps. Thats a significant difference with brax; or the hard-contact-context ive seen in many papers trying to use differentiable simulation. But for what it worth, in such a context, the advantages over pure APG / no learned critic, or things like PPO, seems quite solid.


Firefox not working

What were you trying to do (and why)?
application does not work in firefox
What happened (include all command output)?
firefox crahses
What did you expect to happen?
working firefox
Provide bug output
No response
Verification

[X] I checked the issues repository and confirm this is not a duplicate

This is a duplicate of #21
This thread will be closed.


I used tritonserver to run it, but stop_words didn't work, even though I directly changed it directly in the preprocessing/model.py section.

The format of the stop_words I used should be the format of the original fastertransformer.

For issue of triton backend, please create issue in tensorrtllm_backend repo to help check. Thank you.


cmd/go: internal error in go work sync

Go version
go version go1.21.5 darwin/arm64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/trajan0x/Library/Caches/go-build'
GOENV='/Users/trajan0x/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/trajan0x/go/pkg/mod'
GONOPROXY='github.com/synapsecns/*'
GONOSUMDB='github.com/synapsecns/*'
GOOS='darwin'
GOPATH='/Users/trajan0x/go'
GOPRIVATE='github.com/synapsecns/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/opt/homebrew/Cellar/go/1.21.5/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.21.5/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21.5'
GCCGO='gccgo'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/12/8xtw48x951g0vv4z_ctcr2hr0000gn/T/go-build1424252971=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

git clone https://github.com/synapsecns/sanguine
 go work sync
git checkout 995354fca4e89c0931ea5f6f0a77f170aac2f13e (this is happening across a couple commits and I found it on  synapsecns/sanguine#1840, just providing a single commit on master for reproducibility)

(Note: recipe won't work for this kinda bug, but I created a repl of the repo here and ran the command just for ease of debugging.
What did you see happen?
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>panic: internal error: found a version conflict, but no constraint it violates

goroutine 1 [running]:
cmd/go/internal/modload.editRequirements({0x1010edbd0, 0x1014830a0}, 0x14013bbaaa0, {0x0, 0x0, 0x1400bb7e828?}, {0x14007bac000, 0x108, 0x1400bb7e800?})
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/cmd/go/internal/modload/edit.go:336 +0x2bc0
cmd/go/internal/modload.EditBuildList({0x1010edbd0, 0x1014830a0}, {0x0, 0x0, 0x0}, {0x14007bac000, 0x108, 0x200})
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/cmd/go/internal/modload/buildlist.go:640 +0x64
cmd/go/internal/workcmd.runSync({0x1010edbd0, 0x1014830a0}, 0x140000265b8?, {0x14?, 0x1010248c0?, 0x100adbc6c?})
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/cmd/go/internal/workcmd/sync.go:117 +0x4d0
main.invoke(0x10143fd80, {0x140000201a0, 0x1, 0x1})
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/cmd/go/main.go:268 +0x4f0
main.main()
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/cmd/go/main.go:186 +0x754

What did you expect to see?
Success, another error, but not a panic.
The fact that this isn't handled gracefully tells me it's probably unintended behavior. But I'm a little unsure based on the context in edit.go

Some notes:

This does appear to be perfectly reproducible in synapsecns/sanguine@995354fca4e89c0931ea5f6f0a77f170aac2f13e.
<EMAIL_ADDRESS>is at go 1.16 and therefore unpruned. It is required directly by several of the modules in the workspace.

When a pruned module has a requirement on another root module, and that root is unpruned, we need to transition from the pruned side of the module graph to the unpruned side. I suspect that isn't happening when it needs to in dqTracker.path.

The bug is triggering in the contrib/terraform-provider-helmproxy module, and the conflict is coming about because the workspace-selected version of github.com/google/pprof is ending up lower than the module-selected version — but github.com/google/pprof isn't relevant to this module anyway.
sanguine/contrib/terraform-provider-helmproxy$ go list -m github.com/google/pprof
github.com/google/pprof v0.0.0-20210506205249-923b5ab0fc1a

sanguine/contrib/terraform-provider-helmproxy$ GOWORK=off go list -m github.com/google/pprof
github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1

The dependency on the mismatched pprof comes through an old<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
But  k8s.io/api v0.25.5 is at go 1.19, so it normally has module graph pruning enabled — it must be getting pulled in through some other dependency.

Ok, here's the actual bad path: github.com/hashicorp/terraform-provider-google/v4 v4.2.0 is explicitly required and unpruned (at go 1.16).
From there, we reach the bad pprof unpruned:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
So it appears that in workspace mode we are failing to load the transitive dependencies of<EMAIL_ADDRESS>

contrib/tfcore/go.mod is using a wildcard replace directive to replace google.golang.org/api with the source code of a specific version of that module:
	google.golang.org/api => google.golang.org/api v0.86.0

So the skew in the versions seems to come from applying the replace directives inconsistently in go work sync.

When we load the module graph for the first time, we use the replace directives from the workspace overall: https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/workcmd/sync.go;l=57-60;drc=ce8146ed3361f584ba79427ac6c6d6fe9c297bea
But when we later reload each module in the workspace individually, we end up using only the replace directives of the individual module: https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/workcmd/sync.go;l=105-117;drc=ce8146ed3361f584ba79427ac6c6d6fe9c297bea

Moreover, the error returned from EditBuildList causes go work sync to silently continue instead of erroring out:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/workcmd/sync.go;l=117-120;drc=ce8146ed3361f584ba79427ac6c6d6fe9c297bea

So, to summarize:

There is one bug in how editRequirements applies module graph pruning when diagnosing unresolvable conflicts, which should be fixed by https://go.dev/cl/571800.
There is another bug in how go work sync applies replace directives, which will need a separate fix.

We weren't able to get this done in time for 1.23, and the original error in the first issue comment isn't showing up anymore so we're going to push this to 1.24.


Add enqueueMicrotask

Resolves #266
Requires resolution to #280

Thanks Jonathan!  Looks like the setTimeout variant isn't configured.  We'll probably need some further changes to this after we agree an approach for #280.

I was getting the best speed tests with setInterval, but I left setTimeout in there because it’s closer to how ASAP did it. It has been removed.


Feat: Adding hovering effect on images of shop section.

Issue:
Adding hovering effect on images of shop section.
Description:
Applying proper border on the images of shop section and also applying hovering effects on the images of shop section.
How Hover Effects on Images Improve a Website
Hover effects on images can significantly improve a website’s user experience (UX) and user interface (UI) in the following ways:

Enhances Visual Appeal
Engagement and Aesthetics: Hover effects make static images more dynamic and visually interesting, encouraging users to engage with the content. Instead of just seeing a picture, users get a more interactive experience.

Improves Navigation and User Interactions
Indicates Interactivity: By adding hover effects, you make it clear that the image is clickable or interactive. This is especially important for images that link to another page or open a larger version.

Provides Visual Feedback
Immediate Response: Hover effects provide immediate feedback to the user’s actions, making them feel in control of the interface. This helps users understand that their actions (like hovering) are recognized and will result in a change or response.
.

@Mujtabaa07 Kindly assign this issue to me,I will start working after 31st dec

@Mujtabaa07 Thank you,I will raise the PR after 31st Dec


VAAPI: Set gop_size to INT16_MAX

Ideally it should be INT32_MAX, but vaapi doesn't like that.

Can you also include this change with nvenc?

I can't test it on nvenc so I'd rather not touch it.

Don't worry I'll get someone to test it on Nvidia, before I'll merge it.

Merging.


String arguments containing quotes are not displayed

Describe the bug
String arguments containing quotes are not displayed on transaction page
Transaction ID : 0x709ba5bdf936302c9e7bd7aac6e4cf4a048eff3e00e2728a3fb5a27cecd8a9a5
Address : SP2GW18TVQR75W1VT53HYGBRGKFRV5BFYNAF5SS5J.Cerulean-Marketplace-v1
Block#  #130419 #819137
To Reproduce
Steps to reproduce the behavior:

Go to https://explorer.hiro.so/txid/0x709ba5bdf936302c9e7bd7aac6e4cf4a048eff3e00e2728a3fb5a27cecd8a9a5?chain=mainnet
Click on https://api.hiro.so/extended/v1/tx/0x709ba5bdf936302c9e7bd7aac6e4cf4a048eff3e00e2728a3fb5a27cecd8a9a5
compare the last arguments (satisfaction-vote)
See that they are shown differently

Expected behavior
Show satisfaction-vote also on the explorer page
Screenshots

Thanks @friedger for reporting.
We also see that the service does not show in the explorer.

Thanks @friedger for reporting.
We also see that the service "job-title" does not show in either testnet and mainnet explorer.

@andresgalante thank you for fixing and closing!


chore: refactor

This commit does two things mainly

Simplifies components. For example, instead of Source and Target now there is CodeEditor
Uses effector for managing the state.

As per our discussion, I removed the use of effector but kept the other changes I made.

We have an initial CSS snippet that is intended to show up initially so that the users can get an idea regarding the usage. Also, it should be the case if the textarea field was cleared (left empty).

This should be fixed now.

Thanks


switch from dev to 1.7.0

I have switched from dev-1.7.x to 1.7.0 as it is the same version without any dev labels. Now only the letsdrink/ouzo-goodies ;-)

now also letsdrink/ouzo-goodies to 1.8.0
Can you merge this one and make an new version?


Expose finalPackages

Access to finalPackages was useful for some troubleshooting.
This also adds the docs to CI and adds a script to preview the docs locally.

@roberth Why does finalOverlay use default (in options) to define the value, unlike outputs which uses config to do it? What is the difference between the two, in general?


fix: filter out replicas from nodeToClusters map

fixes the filtering applied to map nodes to CNPG clusters when a node
is cordoned, to create reconciliations only from primary instance pods
Closes #1193
Signed-off-by: Jaime Silvela<EMAIL_ADDRESS>

/test


Parsey's parser is deprecated

Parsey is deprecated, and therefore a new parser for lki should be implemented.

lki is discontinued.


Check language fallback for bundle resources

func TestBundleResourceLanguageBestMatch(t *testing.T) {
	files := `
-- hugo.toml --
defaultContentLanguage = "fr"
defaultContentLanguageInSubdir = true
[languages]
[languages.en]
weight = 1
[languages.fr]
weight = 2
[languages.de]
weight = 3
-- layouts/index.html --
{{ $bundle := site.GetPage "bundle" }}
{{ $r := $bundle.Resources.GetMatch "*.txt" }}
{{ .Language.Lang }}: {{ $r.RelPermalink }}|{{ $r.Content }}
-- content/bundle/index.fr.md --
---
title: "Bundle Fr"
---
-- content/bundle/index.en.md --
---
title: "Bundle En"
---
-- content/bundle/index.de.md --
---
title: "Bundle De"
---
-- content/bundle/data.fr.txt --
Data fr
-- content/bundle/data.en.txt --
Data en

`
	b := Test(t, files)

	b.AssertFileContent("public/fr/index.html", "fr: /fr/bundle/data.fr.txt|Data fr")
	b.AssertFileContent("public/en/index.html", "en: /en/bundle/data.en.txt|Data en")
	b.AssertFileContent("public/de/index.html", "de: /de/bundle/data.en.txt|Data en")
}

@jmooring if I could borrow your eyes for a minute.
The above test passes in the master branch, which surprises me a little. I guess most people have their defaultContentLanguage defined as their first language.
The surprise is this:
b.AssertFileContent("public/de/index.html", "de: /de/bundle/data.en.txt|Data en")

What fallback text file would you expect in the de bundle?

Yes, that is surprising. I would expect to see "Data fr".
We should use the same fallback logic for resource selection that we use for lang.Translate.
In the example above, lang.Translate for a word missing from i18n/de.toml falls back to the value in i18n/fr.toml (the default content language). This is the correct behavior; the language weight is irrelevant.
I may be forgetting some details, but from a site/theme author's perspective the language weight is only useful for things like ordering .Page.Translations and .Page.AllTranslations for language switchers, etc.

I may be forgetting some details, but from a site/theme author's perspective the language weight is only useful for things like ordering .Page.Translations and .Page.AllTranslations for language switchers, etc.

To sum up my understanding:

Translations/AllTranslations are ordered by the language order (weight etc.)
All other language ordering (including the bug above) is ordered first by the default content language, then by weight etc.

Remember https://github.com/gohugoio/hugo/issues/9216? My fix for that #10909 was limited to translation.
The behavior described above is the same problem. We are falling back to "en", not the default content language, not the "lightest" weighted language. This is evident if you change the test case to use "es" files instead of "en" files.


Added binary test & some fixed

Tested binary prediction under test/binary/. ( #9 done binary classification)
Run following code
sh run.sh
XGBoost and Keras are tested.
And modified base_fixed_fold.py

Modified PATH variables

Fixed how to create CV-fold index file ( #4, #6 )

User need to define own create_cv_id()

Delete arguments of keras(i.e., show_accuracy)

Delete save_pred_as_submit_format() ( #5, #6 )

User need to create submission format file(i.e., adding prediction ID, name...)

多分OK!


refactor: uniformise and prepare authorization system for no login mode

Fix public url request redirection (Closes #1255)
Remove unecessary layer with  keycloak-react package (move code to launcher-app)
Fix bug where request query  was removed in openshift redirect_uri
Fix bug where requert query was removed in cleanUrl (end of init)
Uniformise and refactor Authorization (prepare for #1254)
Remove hack and standardize AuthenticationError

This PR was deployed with mocked data in the following URLs for your appreciation:

Frontend: https://fabric8-launcher-frontend-pr-1256-app.surge.sh
Welcome App: https://fabric8-launcher-frontend-pr-1256-welcome-app.surge.sh
Storybook: https://fabric8-launcher-frontend-pr-1256-storybook.surge.sh


Creating a project, then going to home page, doesn't show the project

If someone with project-creation rights (such as our manager user in the test data) creates a project, they are taken straight to the project page, where it clearly exists. But if they then click on the Home button in the breadcrumbs, they will not see their newly-created project until they refresh the page.

This is probably a GraphQL cache issue similar to #838. Also, while solving this issue it might be good to check if creating a project based on a draft project will remove the darft project from the GraphQL cache, or if the admin dashboard will continue to show a draft project that no longer exists after the real project is created.


Changing the lightness of everything in the left sidebar

This is great. I have a question:
Would it be possible to add the ability to change the lightness of “folder names," “note titles” and basically all UI elements like the star symbol, plug-in icons, etc in the left-sidebar? Already have the monitor set to dark and it makes it hard to see UI elements and folders.
I poked around inside the internals with the console open, using the inspector, then hovering over the element saw the color is #808080 and I’d like it to be #878787 for folder names and note titles etc. This doesn't seem to universally apply to them all though, only specific folders etc.. I'd just add some custom CSS snippet there, but not seeing how to change any and all elements in your theme for left sidebar to something lighter. Thanks for any pointers or considering that as an option.

I would definitely encourage you to explore CSS snippets, there is a ton of reference around how to use them on the Obsidian forum and you can always ask for help in the Obsidian Discord.
You can also explore the obsidian.css for this theme and create your own CSS snippet that modifies the following variables:
--icon-muted:1;  /* expects a 0.5 to 1 value */
--text-muted:;
--text-faint:;


No-filter / pager mode

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Problem / Steps to reproduce
Sometimes I want to see the context near the matching lines and select e.g. a line above the match or below. It would be great to have a no-filter mode, where the search query doesn't filter out the lines but only highlight the matches. There would be separate key bindings to jump between the matches.
Usage scenario examples:

navigating git log with possibility to output a commit earlier or later than a matching one.
interactive git rebase, where you have to use a commit earlier than the one in interest.
music finder: jump to any song in an album or mix that contains the match.

It's like fzf being a pager which can also print selected lines to standard output.

Thanks for the suggestion, but it's not something I want to add to fzf. I want to keep fzf simple and straightforward and I don't want to make it more complicated by introducing different "modes" of execution. I suppose there are different tools that are better suited for the use case.

@noscript

It would be great to have a no-filter mode, where the search query doesn't filter out the lines but only highlight the matches

Such feature can be realized relatively easily without adding mode concept into fzf.
I'll show just an idea.
cat tmp.txt | fzf --phony --ansi --bind "change:reload:cat tmp.txt | python3 highlight.py {q}"

where
tmp.txt (which represents search target passed through fzf)
hoge hoge
hoge fuga
hogehoge

and
highlight.py (which is a tiny sketch implementation for highlighting regular expression matched region. It requires colorama installed.)
import re
import argparse
from typing import List
from pprint import pformat

from colorama import Fore, Style

def main() -> None:
    parser = argparse.ArgumentParser()
    parser.add_argument('query', type=str)
    args = parser.parse_args()
    lines: List[str] = []
    while(True):
        try:
            line = input()
        except Exception:
            break
        lines.append(line)
    for line in lines:
        ms = re.finditer(r'{}'.format(args.query), line)
        start_indices = []
        end_indices = []
        for m in ms:
            start_indices.append(m.start())
            end_indices.append(m.end())
        res = ''
        last_end_index = 0
        for start_index, end_index in zip(start_indices, end_indices):
            res += '{}{}{}{}'.format(
                line[last_end_index:start_index],
                Fore.RED,
                line[start_index:end_index],
                Style.RESET_ALL,
            )
            last_end_index = end_index
        res += line[last_end_index:]
        print(res)
    return

if __name__ == '__main__':
    main()

Here is the demo which incrementally highlights parts of lines matching the queried regular expression.
Of course, as the highlighting program is invoked every time query is changed, you should implement it with Go, Rust or something compiled language for better usability.

@relastle thank you for suggestion but unfortunately this has problems:

requires something like rafms, as the data to be dumped first into a temporal file (slow storage + storage wear out), which is then re-read and reprocessed by both fzf and highlighter every time the query is changed (performance implication)
jumping between matches cannot be implemented


python3Packages.rdkit: 2023.03.1 -> 2023.03.2

Description of changes
Diff: https://github.com/rdkit/rdkit/compare/Release_2023_03_1...Release_2023_03_2
Changelog: https://github.com/rdkit/rdkit/releases/tag/Release_2023_03_2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python3Packages.rdkit python3Packages.rdkit.passthru.tests


Delete property on change event

Issue
RES protocol currently provides no way of deleting a model property once it is set.
Suggested solution
A special object, eg. {"action":"delete"}, could indicate deletion.
{
	"foo": "New or changed value",
	"bar": {"action":"delete"}
}

Fixed in pull request https://github.com/jirenius/resgate/pull/9


Search editor: Add hover to context lines hover

It's not obvious that this text box is for context lines. A hover would clear this up

Duplicate of https://github.com/microsoft/vscode/issues/169322
Closing this one in favor of the older one
/duplicate


Get error when start a scene using plugin rexUI

Version

Phaser Version: 3.14 and 3.15.1

Operating system: Windows 10

* Browser: Google Chrome
70.0.3538.102 (Official Build) (64-bit) (cohort: Stable)

Description

My game have plugin rexUI from rexUI to create a simple scroll view (use GridTable) in a scene called Menu. Everything works fine, until I click an item view, this call a callback to start a scene (called Game). In console, it showed error and the game got frozen.
Actually, the game got frozen in version 3.14. When I update to version (just downloaded in webs) 3.15.1, it no longer frozen, the Game scene is loaded but the error still thrown.
Example Test Code
Import plugin in scene (Menu)
preload() {         this.load.scenePlugin({             key: 'rexuiplugin',             url: 'assets/libs/rexuiplugin.min.js',             sceneKey: 'rexUI'         });     }
Event:
// event         table.on('cell.click', function (cellContainer, cellIndex) {                 console.log('Game scene with index ' + cellIndex);                 this.scene.start('Game');             }, this);

Additional Information

Here is screen shot:

I guess, the problem is when start a scene, the old scene is destroy, but not everything, specially is plugin. I tried use 'switch' scene instead, it's working like a charm, but I don't want to change scene like this.

Please report to my github, with a very simple and run-able test code. I would like to solve it first.

thanks to @rexrainbow , plugin was fixed.


Make sure BIO values are legit

This fixed the problem in the test case and in the 100 habitus files

See also https://github.com/clulab/habitus/issues/161.

LGTM @kwalcock !


Shift-move of stack is PERMANENTLY sticky

With Firefox browser, I press Shift to move a stack and I don't have to hold Shift.  In fact, the stack is frozen together as a stack and cannot be separated from each other regardless of keystroke.  The only way I've separated the stack is to Autofill them apart.  Or move the stack to a location that only needs 1 or two amis.

I just fixed this today.

Confirmed.  Fix pushed 45 minutes!  Closes #4


refactor(unit-tests/coverage): update istanbul to 15 and add reporters

[x] Updated istanbul to 15 because 14 had issues related to coverage
[x] Copy-pasted the matcher utils functions from rxjs, with changes related to jasmine instead of chai usage
[x] Excluded the matcher utils from istanbul coverage, as it's only pasted here because not exposed by rxjs

I wil fix the coverage before asking for review ;)

The changes are good, I'll land it when you're ready

Thanks @brandonroberts
I will fix the coverage to 100% before merging, the else clause of this if https://github.com/synapse-wireless-labs/jasmine-marbles/blob/master/src/marble-unparser.ts#L30 is not yet tested. Do you have a clue ?

I don't. Some of the code has been picked up from RxJS code and has been tested already, so I think the coverage is good as-is for now.


Allow larger display names?

6 chars is awfully small... maybe 8 or 12?

Good idea. There is space for it.
Also, all of the visual objects should be dynamically sized based on the window size and resolution. Feel free to submit a pull request for that :)


Normalize Species Profiles

Alias species profiles to include all of the following URLs:

/species/singluar/species-name
/species/plural/species-name
/wildlife/singluar/species-name

Taxa Subsections (/wildlife/mammals) should also be aliased

/wildlife/mammal
/species/mammals
/species/mammal

Header information should be normalized

Taxon: Amphibian (family)

Closed via<PHONE_NUMBER>510e8c91c8c78c4b68c3ff6714ebf0


timer never triggering in a busy select

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.7rc5 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/tv/go"
GORACE=""
GOROOT="/home/tv/src/go-1.6"
GOTOOLDIR="/home/tv/src/go-1.6/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

https://play.golang.org/p/uAyqR8uG--
Won't run on playground, but grab https://play.golang.org/p/uAyqR8uG--.go and run locally.

What did you expect to see?

Some number of dots, and then "timeout" and program ending.

What did you see instead?

Infinite dots.
Adjusting timings makes the select sometimes notice the timer (second->dots, millisecond->dots, microsecond->"timeout" no dots, nanosecond->"timeout" no dots), but it seems far from "uniform pseudo-random" (https://golang.org/ref/spec#Select_statements), or the timer just doesn't trigger.
https://github.com/golang/go/issues/15706 might be relevant, but that issue is supposedly closed in 1.7rc5.

Your program is buggy. Each iteration makes a new 1 second timer.

Hah! Thanks. This came up on IRC and managed to fool at least three of us.


Relocate Scala files placed in the java/ directory

Ran across a handful of Scala files that were in the java/ directory hierarchy.  This relocates them to the scala/ hierarchy.

build


Works with browserify?

For the moment, I don't succeed to make it work with browserify.
var MobileDetect = require('mobile-detect')
var md           = new MobileDetect( window.navigator.userAgent )

console.log( md.mobile() ) // null
console.log( md.phone() ) // null
console.log( md.tablet() ) // null
console.log( md.userAgent() ) // null
console.log( md.os() ) // null
console.log( md.is('iPhone') ) // false
console.log( md.is('bot') ) // false
console.log( md.version('Webkit') ) // NaN
console.log( md.versionStr('Build') ) // null
console.log( md.match('playstation|xbox') ) // false
console.log( md ) // Object { ua: "Mozilla/5.0 (Macintosh; Intel Mac O…", _cache: Object, maxPhoneWidth: 600 }

Sorry, I've got no experience with browserify.
What kind of error do you get?

It seems to be ok, thanks. Just weird os() and userAgent() return null.

OK. Good to know that it works with browserify...
Some day I'll try it myself.

In fact, I think I misunderstood this project. I thought it was UA sniffing in general but it's mostly mobile oriented. ;)


Deliver some last minute design changes to create button and type column

Signed-off-by: Feng Xiang<EMAIL_ADDRESS>
Add psuedo grouping to create button dropdown, since this is throw away code
Removed links in the Type column and just display the application type

/test e2e-cluster

/test e2e-cluster

/test e2e-cluster


unhelpful error message on incorrect use of .elsewhen

Chisel code:
          when (cmd.stop) {
            byteState := s_byte_stop
            bitCmd    := I2C_CMD_STOP
          }
          .elsewhen {
            byteState := s_byte_idle
            bitCmd    := I2C_CMD_NOP

	    // generate command acknowledge signal
            cmdAck    := true.B
          }

Error message:
[error] ... :426: type mismatch;
[error]  found   : Unit
[error]  required: chisel3.core.Bool
[error]             cmdAck    := true.B
[error]                       ^
[error] one error found
[error] (sifiveBlocks/compile:compileIncremental) Compilation failed

We don't know how to make a better error message here, this is a problem caught by the Scala type checker which we don't have control over. Though if you have a solution, a PR is welcome!


86b1u7k1d

@ThilanN please resolve conflicts

Move this file to /docs/schema/README.md

@thlurte please check the necessity of the tables I have mentioned above since this is related to your task 86b1uje03.


Guess the language(s) of a document and choose the correct OCR language(s) to process it

Is your feature request related to a problem? Please describe.
OCR of documents needs me to select the OCR language from the installed OCR languages. This is somehow tedious if I have to scan and OCR documents in different languages.
Describe the solution you'd like
I suggest to implement an algorithm which is able to guess the language(s) of a document and choses the correct OCR language. If the correct OCR language is missing or the algorithm cannot guess the right language or the algorithm is unsure then I would be prompted to decide what to do with an OCR scanning of the document in question.

This is something definitely possible. But I need to mark it as out of scope at this stage.
At this point it Papermerge is missing "must" features - likes versioning (coming in 2.0).

Another argument why it is out of scope - is because language detection must be performed by 3rd party tool - it is not task of DMS system to guess languages - similar to the fact that it is not task of DMS tool to OCR - that is performed by 3rd party tool.
If you are aware of such language guessing open source tool, I will gladly consider it.

Thanks for discussing the feature suggestion. I would like to suggest three Python projects dealing with language detection:

Python langdetect: https://pypi.org/project/langdetect/ : It seems a bit outdated although it is (was) rather widely used
Python spaCy : https://github.com/explosion/spaCy : It seems up to date, well maintained and documented
Python TextBlob: https://github.com/sloria/textblob : It seems up to date, well maintained and documented

On "Detect an Unknown Language using Python" they offer different examples on text detection. However, the right mix of "time to detect" as well as accuracy seems to be different between the projects but is important for guessing the correct OCR language in the Papermerge project.

@wechsler42 well your examples work well once you have text! However to get the text you first need to OCR which ... needs a language! ;-) So the only real solution is to OCR with all possible languages and then use e.g. langdetect to decide which one is most probable. How many languages we are talking about here?
If this is something @ciur will accept as PR (it will be computationally heavy) I'm willing to do it.
Another alternative is to specify multiple languages to the OCR I tested with ocrmypdf (also see my PR in papermerge-core) and it will work for German and English by specifying --language deu+eng. However, sometimes results are better when giving the correct language of the document...

@wechsler42 well your examples work well once you have text! However to get the text you first need to OCR which ... needs a language! ;-) So the only real solution is to OCR with all possible languages and then use e.g. langdetect to decide which one is most probable. How many languages we are talking about here?
If this is something @ciur will accept as PR (it will be computationally heavy) I'm willing to do it.
Another alternative is to specify multiple languages to the OCR I tested with ocrmypdf (also see my PR in papermerge-core) and it will work for German and English by specifying --language deu+eng. However, sometimes results are better when giving the correct language of the document...

@DocLambda is perfectly right:

However to get the text you first need to OCR which ... needs a language! ;-)

I didn't realize this point at the beginning. It is called infinite recursion which results in stack overflow... :)))
Jokes apart, I think this ticket is good to be closed.

@DocLambda is perfectly right:

However to get the text you first need to OCR which ... needs a language! ;-)

I didn't realize this point at the beginning. It is called infinite recursion which results in stack overflow... :)))
Jokes apart, I think this ticket is good to be closed.


Feat: Added Fetched and created separate page for comments for admin successfully Issue 440

Pull Request Resolves [#440 ]
Title: Added Fetched and created separate page for comments for admin successfully.
Description

In backend, created API controoler for comment deletion and similarly routes also.
In frontend, created a new file for comment section where I am fetching the posts with its comments and also adding delete button so, that admin can delete the spam comment.
The design is responsive.

Related Issues
Fixes #440
Changes Made
New feature: Added Fetched and created separate page for comments for admin.
Screenshots

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.

@VaibhavArora314 @Ultimateutkarsh11  there are many comments in the style share right now, but it is not fetching at all I don't want is the problem ?
In status card also:

In comment which i currently worked in this pr:

I don't know what is wrong is going on !

@VaibhavArora314 @Ultimateutkarsh11 there are many comments in the style share right now, but it is not fetching at all I don't know is the problem ? In status card also:

In comment which i currently worked in this pr:

I don't know what is wrong is going on !

@VaibhavArora314 @Ultimateutkarsh11  there are many comments in the style share right now, but it is not fetching at all I don't know is the problem ?
In status card also:

In comment which i currently worked in this pr:

I don't know what is wrong is going on !

@VaibhavArora314 Bruh level 2 ? see all the code please

Frontend + backend integration and UI also please give level 3 🙏

@Ultimateutkarsh11 !


Release: 2.10.1

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Add a way to query formats supported by a PhysicalDevice

There seems to be a way to do this with the low-level vulkano code already, it may just need to be exposed. https://github.com/vulkano-rs/vulkano/blob/master/vulkano/src/swapchain/surface.rs#L535-L549

PhysicalDevice now has a format_properties method.