Implement uname

That might be helpful to print basic system information. For example it's being used at https://conda-forge.org/download/ for Linux / macOS. If we implement it, and add a command-line installer, the Windows installation can be the same as on Linux/macOS.

Already implemented:
$ uname -a
Windows_NT LAPTOP-EQE44SIG 10.0 22631 x86_64 MS/Windows (Windows 11)

Regarding the conda-forge unification, it is close:
$ echo "Miniforge3-$(uname)-$(uname -m).sh"
Miniforge3-Windows_NT-x86_64.sh

While the actual name they use is Miniforge3-Windows-x86_64.exe. We can later maybe remove "_NT" from uname. Regarding .sh vs .exe, that's for later: right now conda-forge does not distribute .sh on Windows, but once our shell is in wide use, it could.
Also for pixi we can unify the installation.


Android - Preferences - Option to enable staging server is missing

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app and login
Go to Setting > Preferences

Expected Result:
Test preferences section to enable secure staging server toggle appears
Actual Result:
Test preferences section is missing
Workaround:
Unknown
Platform:

Where is this issue occurring?

Android

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

@johnmlee101 This issue seems to intro in build 1.1.68-x

I'm having a hard time detecting this in the diff between 1.1.68 and its previous versions
https://github.com/Expensify/App/compare/1.1.67-0...1.1.68-2
@mvtglobally are you saying this first appears in the 1.1.68-x versions?

I've been attempting to get android running locally. Going to rope in more people if I can't get it up

@johnmlee101 thats what we believe, as we don't actively test this particular section we mainly look at the adding bank account flow.

Bump!

Where is this android version coming from? I got it working once I checked to see that it was coming from the beta branch of the play store (can't be a built version we hand out)


fix(Dockerfile): force gunzip of license files

I'm still running into issues with make docker-build locally. This fixes it.

Codecov Report

Merging #475 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   55.86%   55.86%
=======================================
  Files          29       29
  Lines        1219     1219
=======================================
  Hits          681      681
  Misses        500      500
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b792f27...e3ecdc6. Read the comment docs.


feat: [SEI-6919]: Migrate prop-docs to Harness Developer Hub

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664f41e96d2998007eb21cce--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://665df4eb9dd3e61decb8bedd--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://665ee57bdcb6b1f6b0504edf--harness-developer.netlify.app


7.7.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

The windows builds on this seem to be failing due to "Out of heap space" memory issues.
We used to see this (https://github.com/conda-forge/ocp-feedstock/issues/9) but not recently. Perhaps 7.7.2 requires more memory during compile, for whatever reason. I proposed https://github.com/CadQuery/OCP/issues/90 some time ago. I'm not actually sure it will fix the issue, but it might be worth a shot.

Trying to increase the pagefile according to: https://conda-forge.org/docs/maintainer/conda_forge_yml.html

@conda-forge-admin, please rerender

@whophil seems that it worked. Do you know what needs to be done to get py3.12 in the matrix?

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

OK, merging.


add host for OCSP request

This seems to work for me, don't know if it is correct

That looks like an awfully LE-specific value, to be hard-coded like that.
Bearing in mind that this needs to work across any ACME-compliant CA, is there a more dynamic way to detect and set this, if it's required?

I don't know...

What does ${ocsp_url} evaluate to? Is there a way to extract the desired host header from that?

http://ocsp.int-x3.letsencrypt.org

I can't write the code while I'm mobile, but what about using cut, splitting on the forward slashes, and just keeping the third field? I think that should extract just the host...

@it-can mh for me this works fine without an additional host argument... can you please post the output of dehydrated --version? Just interested on why this fails, not meaning that this will not be fixed.
Otherwise (as @txr13 stated) this pull-request is LE-specific and it also will probably only work with that specific sub-CA and will break in the near(ish) future. I'll rewrite this to take the existing parameter, closing this pullrequest.

[root@server dehydrated]# ./dehydrated --version
# INFO: Using main config file /etc/dehydrated/config
Dehydrated by Lukas Schauer
https://dehydrated.de

Dehydrated version: 0.4.0
GIT-Revision: 4f3bd3e9567e97e963cb80141c3ba9147605360c

OS: \S
Used software:
 bash: 4.2.46(1)-release
 sed: sed (GNU sed) 4.2.2
 curl: curl 7.29.0
 awk: GNU Awk 4.0.2
 grep: grep (GNU grep) 2.20
 mktemp: mktemp (GNU coreutils) 8.22
 diff: diff (GNU diffutils) 3.3
 openssl: OpenSSL 1.0.1e-fips 11 Feb 2013

I am getting this error without the HOST parameter:
openssl ocsp -no_nonce -issuer "123.chain" -verify_other "123.chain" -cert "../certs/test.com/cert.pem" -respout "test.der" -url "http://ocsp.int-x3.letsencrypt.org"
Error querying OCSP responsder
140201268983712:error:27076072:OCSP routines:PARSE_HTTP_LINE1:server response error:ocsp_ht.c:250:Code=400,Reason=Bad Request

Please see e339b28159a86720898ad60bb90207ca68977192, this should fix your issue.

Doesn't seem to work...

yup, removed the ocsp.der file and called dehydrated, no new file...

mmm it seems to work when I remove the domain directory...

I can reproduce the issue now, it seems that openssl has changed the syntax for the header parameter from version 1.0.x to 1.1.x... Meh... :disappointed:

aaah, yeah that makes sense...

Please see 2b76d038d374acc9b4237da7e224be9e48ac2439, does this work for you?

yes that seems to work! One question, everytime I call the dehydrated script will it generate a new ocsp.der file?

aah there is a age check in there I see

So to summarize, older versions of openssl did not include the Host header for OCSP requests, and on top of that, the syntax of specifying headers changed. (Between versions 1.0 and 1.1)
That's interesting.

I am running Centos7
openssl version
OpenSSL 1.0.1e-fips 11 Feb 2013


Include as ts prop

[x] Add as prop to ts interface

:tada: This PR is included in version 5.5.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CE bomb improvements by gary-stu

Patch submitted in #998 by gary-stu, also added fix for inconsistent OK button detection (also by gary-stu).

Closing in favor of #1383


Fix compiler warnings.

Description
Fix compiler warnings, Android build.  Fixes #993 .

Unused 'cleanup' label in generated code: refine code generator to include when it is used
always true (or false) comparisons (platform dependent!) -- add pragma warning and comment
unused variable: used in assert only, which is ignored on release -- add pragma warning
shift overflow: use 1ULL for correct larger size.

Testing instructions
Android compile  /tools/android-build
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

There is no compile warning for project code in any of the 3 CI builds (latest builds, commit
8741606).

@hewigovens , now that there are warnings, maybe we should turn on warnings-to-errors to enforece no warnings.

New added warnings or existed? I wonder that’s too strict


Update mqtt to 6.1.2

https://github.com/ioBroker/ioBroker.mqtt/issues/482

node.js 22.x tests ok
see https://github.com/ioBroker/ioBroker.mqtt/pull/490


Paste plugins?

Is your feature request related to a problem? Please describe.
In the Minecraft community, people have created browser extensions for remapping stack traces / code. It would be cool if paste could have any sort of processing functionality for obfuscation mappings.
Describe the solution you'd like
Clearly Paste's scope is wider then the Minecraft community, and the main reason that people fork / create their own services in the first place is to have more control over paste service functionality. Would you be open to having a plugin/extension system allowing for extensions to paste?
Describe alternatives you've considered
Forking and maintaining a paste fork, browser extenstions

I'm still not sure what I think about this. The idea is modules that can be dynamically loaded by a server operator.
I'm not sure what sort of API that would include and I'm not sure how complex that would make our underlying code, which is not pretty right now.
I feel favourable about making extensions for these kind of specific issues, but I understand that is fraught with annoyances like minor adjustments to layouts becoming breaking changes. However, it is much less work for me, and keeps the codebase simple without introducing potential for new bugs/attack vectors. On the other hand, it wouldn't affect the API and asks users to install something. On the other other hand, it's a very niche use-case that I can't really see the justification for having an entire subsystem to add and maintain, and those users could probably handle installing an extension.
Any sort of plugin would have to be a .so or .dylib that would have to be compiled (albeit, from any language that can compile to a shared library) and match the ABI for paste's "plugin API." I see high potential for crashes when interacting with Rust from non-Rust due to memory management, and if the ABI changes without an upgrade for the plugin, the server will crash, which will lead to more support and a more unstable product.
I'm leaning towards a no for this. @AKPWebDesign mentioned allowing instance operators to add their own JS instead of doing a more backend solution, and I'd like to point out that you can currently do this by editing templates. Obviously, this also doesn't affect the API and won't work for users with JS off, but it doesn't require an installation of an extension.

Honestly with the way the web is going these days, being able to edit the template is probably good enough anyway (and this was more an off the top of my head request, wondering what you were thinking long term, as I'm not even yet a user). Additional functionality could be provided by another micro-service as long as rest API's / auth exists for paste.

paste does have a REST API with and without authentication, so another service could interact with paste to clean up stack traces, yes. An extension could even tap into that and query the API based on the paste ID in the URL, since that's all that's necessary (except for private pastes, in which case, scraping or asking for an API key are options).
I'm going to close this, since I'm not going to be implementing it, but feel free to ask questions on Discord or open other issues for other ideas! :)


Question about study timeslots

Thank you for making this script! I have a question about the features.
To my understanding, when the script scrapes the SONA system for the timeslots, it's only doing it for the timeslots on the researcher account specified under constants.py. Would it be possible to add an option so that it can just scrape all signed up timeslots for all researchers from one particular study?
Thanks in advance!

Sorry about the late reply. I think you can run multiple instances of the script to achieve that. Personally I feel like it would be unsafe to store multiple researchers' password in one place, so I'd just ask different researchers to run their own thing.

Thanks for replying!
As the Lead Researcher on SONA though, I can view, edit, and assign timeslots for the other researchers. In that case, would the script be able to scrape the timeslots of the other researchers from just my account alone? Or does SONA structures their timeslot data separately still?

I believe the script should scrape all timeslots in this case, but I don't have a lead researcher's account so haven't tested this. Feel free to let me know if you have other questions when using this.


how to set proxy for flutter application

Hi. I want to set a proxy for all of the connections of my app. how can I do this?
actually, I want to set proxy for firebase.

Did you try to get an answer on StackOverflow?

my account is blocked in stackoverflow and i can't find a way for my problem in stackoverflow!

Probably related to #20376

Duplicate of #26359


Is there a way to attach more data on registration/update event?

Hello,
So, I have been using the webhook to synchronize user registration data with my database and I was wondering if there is some way to include in the event object more data, like client roles, or user attributes.
I understand that I can fetch the extra data i need via keycloak REST API but if the event object can carry them it would definitely be helpful.
Thank you for your time.

🤔 Sure. But it's an event. It'll mean fetching those data directly in the keycloak and potentially increasing the payload. The part in the code responsible of it is here. What other data would be need in that case?

Thanks for writing back @stephane-segning

I understand that I can fetch the extra data i need via keycloak REST API but if the event object can carry them it would definitely be helpful.

So, it seems that you can not do that inside the register event :) The reason is, from what I understand and please someone correct me if I am wrong, that the events are called synchronously from Keycloak. That means, that when the register event is fired, the user is not actually in the keycloak database yet and therefore you can not make API calls to fetch associated information. Some related information can be found here.
Implementors can leverage the fact that the onEvent and onAdminEvent are run within a running transaction. Hence, if the event processing uses JPA, it can insert event details into a table, and the whole transaction including the event is either committed or rolled back. However if transaction processing is not an option, e.g. in the case of log files, it is recommended to hook onto transaction after the commit is complete via the [KeycloakTransactionManager.enlistAfterCompletion(KeycloakTransaction)](https://www.keycloak.org/docs-api/22.0.2/javadocs/org/keycloak/models/KeycloakTransactionManager.html#enlistAfterCompletion(org.keycloak.models.KeycloakTransaction)) method, so that the events are stacked in memory and only written to the file after the original transaction completes successfully.

If the above means what I think it means, then attaching data to the event will definitely be useful if your synchronization user flows depends on some user attribute or some role that is assigned during registration and I believe that it will be done more cleanly in the hook than waiting for the user the login to your system and then make the synchronization.

But it's an event. It'll mean fetching those data directly in the keycloak and potentially increasing the payload.

The first thing I checked was if there was some kind of option to "attach token mapper to event" from the keycloak UI like you do with token mappers and "add to id token/add to access token/add to user info". That would definitely help controlling the payload size easier and it would be friendlier in general for more customization. I understand that this is not in the scope of this library I am just saying that it would have been nice :)

What other data would be need in that case?

I guess that this depends. Personally (for my case at least) I find realm roles/client roles and user attributes useful to include and if you are worried about the payload they can only be included in the register event that happens once instead of including them in events that happen very often (e.g. token refresh).
Also there are some other cases that I've noticed that you could have an extra field or two in the payload. For example, the CLIENT_ROLE_MAPPING-CREATE does not include the role name, just the id. Wouldn't it make sense to include it instead of doing an API call to get it from Keycloak?
Just throwing my thoughts out there :)

[...] from what I understand and please someone correct me if I am wrong, that the events are called synchronously from Keycloak

I would also like to say here that if the above is indeed true, and the hooks are called synchronously, then it would be very helpful if keycloak-webhook took under consideration the response http status from the remote it's calling.
For example, if a non 2xx response is returned (or a network failure maybe), the plugin code could throw an error and force a rollback of the keycloak transaction as a whole. Very useful in cases like registration (or any event really) in which the http remote fails to handle the incoming event payload (e.g. to sync it with own database) but the user is written in keycloak database. Now you have a user in keycloak, but not on your side, and you have to make extra checks to actually sync data from keycloak to your database.
I understand that this might not be the behavior everyone wants so an extra setting for the plugin might be helpful.

@stephane-segning ,I've been playing around some more with the plugin and the admin events also need some more data in order to make sense. For example, I delete a user from the Keycloak UI, and my backend receives a USER-DELETE event like the following:
{"clientId" => "7a568878-e210-4bb8-b30b-6c5afad58c7e", "id" => "28cc0396-ebf9-4362-bb73-1a130082d380", "ipAddress" => "<IP_ADDRESS>", "realmId" => "b1d47d38-238d-433e-9ea0-1e217c6b94e1", "time" =><PHONE_NUMBER>966, "type" => "USER-DELETE", "userId" => "1bb1679d-07ac-4234-9cd6-b0992ead7d73"}

At first, I thought that the userId key contains the user id that this event is about. Unfortunately it's not. It's the id of the user who triggered this event.  In my backend I want to delete from my database the user who just got deleted on the keycloak side but I have no idea what to delete based on the payload I got.
In the Keycloak UI, you can see the admin events like so:

Notice in the screenshot above the resourcePath. It contains the resource endpoint that this event is about. Now that's something that I could use for example and can easily be added in the admin event that keycloak-webhook sends. There is also another key in the event (if I am not mistaken) called representation. Not sure what that contains, I just noticed it in the UI somewhere. Might have more useful info in there that worth sending with the event.
In general, like I have mentioned in my previous posts in this issue, I think that a bit more data on which the receiving end can act upon, could be added to the event payload.

Hello,
So, I have been using the webhook to synchronize user registration data with my database and I was wondering if there is some way to include in the event object more data, like client roles, or user attributes.
I understand that I can fetch the extra data i need via keycloak REST API but if the event object can carry them it would definitely be helpful.
Thank you for your time.

I did what you asked for here
https://github.com/vymalo/keycloak-webhook/pull/19

@valid-var cheers! I will give it a try very soon :)


Portability (#2)

The -o option isn't supported by uname on OpenBSD (and various other implementations), so instead
use -s. I've been unable to verify this doesn't break Cygwin support though..

It seems github added a few more commits to the request; those were some minor misc fixes.


Fix #278, only render flash message when add song to current playlist…

… in turbo native

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1033

Relevant Lines:
1033

💛  - Coveralls


As a host I want to have a visualisation of the prioritised-choice  results

Duplicate of #221 / #220.


Return response data as JSON instead of a string when in PENDING status

Fixes issue with response data format when status is PENDING.
When in PENDING state, response data is currently returned as a string. Add fix to rpc-controller to return data as JSON when status not COMPLETED.

Closing this PR as there is no longer any data to return when status is PENDING


Create a new option disable_xr for disbling xr nodes and server

Supposed usage
For 3d game that doesn't use xr (its almost all 3d games)
Structure of the PR

First two commits introduce disable_xr option. These are 99,99% safe because they only shuffle some files (files on which no one depends)
One commit about removing openxr options which effectively is the same as module_openxr_enabled.  I think it doesn't need any dedicated solution which just mirrors behavior of existing systematic feature. So it even could be standalone PR. The only problem here that it breaks backward compatibility
Disabling XR checks inside servers/rendering/renderer_rd and drivers/gles3 which are essentially checks for additional settings necessary for xr which are useless if you doesn't want to have xr. I am almost sure these are harmless
Finally disabling xr server and all the places which depend on it.  The code wasn't designed for these defines so they look really weird. I am sure there are plenty of bugs and problems but I can't see them

It works but with the simplest project. It compiled and I even could normally export and run minimal 3d project with one model, light and camera
Results
Linux binary size comparison (scons target=template_release production=yes use_llvm=yes):

Without disabling anything: 71.409 MiB (74878304 bytes)
Disabling all xr modules: 70.163 MiB (73571648 bytes)
Disabling all xr modules, nodes and server: 69.487 MiB (72863040 bytes)

Previously you could achieve the results of disabling all xr modules so this PR will let you to save 0.675 MiB (708608 bytes). Which is much less than any normal 3d model and even less than it's texture... So it didn't have any sense... There are archived and not planned labels so I think this PR is perfect for them.
P.S Yeah, I read best practices for contributors in docs. And yeah I violated two of them, so sorry...

One commit about removing openxr options which effectively is the same as module_openxr_enabled. I think it doesn't need any dedicated solution which just mirrors behavior of existing systematic feature. So it even could be standalone PR. The only problem here that it breaks backward compatibility

I would keep openxr=no as an alias for disable_xr=yes (with a message printed to tell the user that the openxr option is deprecated). This way, we avoid breaking people's build scripts.
Something like this: https://github.com/godotengine/godot/blob/506d6e427a4eecfc1e5e5ee1180019a876119701/SConstruct#L365-L370

I don't think this should replace the openxr switch. OpenXR is but one implementation that uses the XR system.
If the XR nodes are removed (which is very little code, the bulk is in the modules) then yes, any core XR module should be removed with it (e.g. WebXR, OpenXR, MobileVR etc), but people targeting "Cardboardish" VR or WebXR, or use any of the external XR interfaces such as TiltFive or OpenVR, may wish to remove just the parts they are not using.
WebXR is a bit of an exception here seeing web already selectively excludes the other modules but the principle stands.

I would keep openxr=no as an alias for disable_xr=yes (with a message printed to tell the user that the openxr option is deprecated). This way, we avoid breaking people's build scripts.

I understand what you mean but like already was said these options aren't equal. And openxr=no is the same as module_openxr_enabled so creating an alias isn't difficult but will require two modifications:

As you proposed to check it with if if env["openxr"]
Mention it in definition of the property itself so scons -h will warn you too
https://github.com/godotengine/godot/blob/506d6e427a4eecfc1e5e5ee1180019a876119701/SConstruct#L227-L227

I agree with Bastiaan. If we add a disable_xr option, setting disable_xr=yes should imply openxr=no and webxr=no, but we still need to have the openxr and webxr options, since someone may want to keep XR enabled, but disable openxr, if, for example, they wanted to build an app for Tilt5 and were going to use the Tilt5Godot4 extension.

I agree with Bastiaan. If we add a disable_xr option, setting disable_xr=yes should imply openxr=no and webxr=no, but we still need to have the openxr and webxr options, since someone may want to keep XR enabled, but disable openxr, if, for example, they wanted to build an app for Tilt5 and were going to use the Tilt5Godot4 extension.

But it they already exist. I just add option to disable xr nodes and xr server.
Currently we have 3 xr modules each of them can be disabled:

module_openxr_enabled="no"
module_webxr_enabled="no"
module_mobile_vr_enabled="no"

And we have option openxr="no" which is absolutely the same as module_openxr_enabled="no". What my PR does is removes unnecessary openxr="no" which because it is just a module and should be disabled via module_openxr_enabled="no". And this PR introduces disable_xr which is an alias for all 3 module disabling + disables xr nodes and servers. If you doesn't use xr you just use disable_xr to disable whole xr. If you use any xr, you disable modules you doesn't need. Before this pr you could disable 3 modules and still you can disable 3 modules without disabling server and nodes but this pr lets you to disable them if you want.
What about openxr option it just doesn't have sense to have two options for disabling one module. openxr doesn't do anything except disabling one openxr module. We have module_openxr_enabled which is "auto-generated" option it is much better...

There is disable_3d option. Which disables all 3d modules + disables 3d nodes and servers. But if you need 3d but doesn't need some modules you can disable them without fully disabling nodes and using disable_3d. Here is the same thing...

And we have option openxr="no" which is absolutely the same as module_openxr_enabled="no". What my PR does is removes unnecessary openxr="no" which because it is just a module and should be disabled via module_openxr_enabled="no".

Ah, ok, I didn't realize that the openxr option was extra. I guess then it's just a question of whether we want to keep it as an alias (so we don't break folks build scripts) or remove it completely.

Not mergeable anymore. I don't want to update it and it didn't got any testing. It will also become less actual if I or someone else will start enhancing the builtin editor which can disable nodes. Though openxr option is useless and not well. Users don't suffer so...


New version of VanillaFix wont ping server

When I updated to the new version of Vanillafix, I get the just Pinging messaging under Multiplayer and then it throws a crash and won't show the servers online unless I drop Vanillafix back a version.
https://paste.dimdev.org/rixixaceqe.mccrash

Well, this isn't a major issue, but something I will address. Just try and enter the server once you open multiplayer for now, it'll be fixed in the next release which should be soon

I'll just downgrade till then

Anyone looking for a temp fix for this can simply change B:bugFixes= to false

Was coming to report this same issue. @TacticalUniverse don't close an issue if it's not fixed yet...


[Program]: Write a TypeScript program to find second smallest number in an array

Description
Write a TypeScript program to find second smallest number in an array
Input  : [1, 2, 3, 4, 5]
Output : 2

How to contribute

Save the solution in program/program/find-second-smallest-number-in-an-array/program/FindSecondSmallestNumberInAnArray.ts file

!assign

CLOSE THIS ISSUE, ITS ALREADY SOLVED!

Hey @abhishekkumar35
Thanks for reporting this 👍🏻
File Link: https://github.com/codinasion/codinasion/blob/master/program/program/find-second-smallest-number-in-an-array/FindSecondSmallestNumberInAnArray.ts


Adding New fields + fields from Kong OSS PR  8841

Related: https://github.com/Kong/kong/pull/8841

Agree on the word smithing.

Agree on the word smithing.

This PR depends on this one right? https://github.com/Kong/kong/pull/8841

@Guaris Correct. Unit tests failing for odd reason, one error was an unrelated postgres and the other error idk how my SRC changes could have even caused that failure after studying it a few times.

If you could ping me when that other PR gets merged. I'll merge this one then.

I'm closing this PR on account of the other PR being closed
https://github.com/Kong/kong/pull/8841
please reopen this PR when you are ready!


Title extraction: newlines captured

▶  start     Starting to render "README.md"
…  awaiting  Deleting attachment "example.png" ...
…  awaiting  Uploading attachment "example.png" for "example
" ...
…  awaiting  Fetch current page for "example
" ...
✔  success   No change in remote version for "README.md" detected, no update necessary
Done in 2.80s.

Fixed in 0aa4b4ca662b49f73352530d7e701542a79654df


[NavigatorIOS] not working with background image

Hello
It appears that the NavigatorIOS is not displaying the current content when there is a full screen background image as a sibling to it.
Can you please let us know if there is a workaround, we don't want to move the background image into each and every of our component pages.
Thank you very much
Bernd
Here the example code:
https://rnplay.org/apps/wrntpQ
'use strict';

var React = require('react-native');
var {
    AppRegistry,
    StyleSheet,
    Text,
    View,
    Image,
    NavigatorIOS
    } = React;

var SampleComponent = React.createClass({
    render: function() {
        return (
            <View style={{
        flex: 1,
        justifyContent: 'center',
        alignItems: 'center',
        backgroundColor: 'transparent'
      }}>
                <Text style={{color: 'red'}}>Hello</Text>
            </View>
        );
    }
});

AppRegistry.registerComponent('SampleComponent', () => SampleComponent);

var SampleApp = React.createClass({
    render: function() {
        return (
            <View style={styles.container}>
                <View style={styles.bgContainer}>
                    <Image
                        style={styles.logo}
                        source={{uri: 'http://facebook.github.io/react/img/logo_og.png'}}/>
                </View>
                <NavigatorIOS
                    style={styles.navigator}
                    initialRoute={{
                  component: SampleComponent,
                  title: 'My View Title'
                        }} />
            </View>
        );
    }
});

/*
 // It works if you put the following line in line 39
 <SampleComponent style={styles.navigator} />

 // But it doesn't work when you put the following lines in 39
 <NavigatorIOS
 style={styles.navigator}
 initialRoute={{
 component: SampleComponent,
 title: 'My View Title'
 }} />
 */

var styles = StyleSheet.create({
    container: {
        flex: 1,
        justifyContent: 'center',
        alignItems: 'center',
        backgroundColor: '#F5FCFF',
    },
    bgContainer: {
        position: 'absolute',
        left: 0,
        top: 0,
        right: 0,
        bottom: 0
    },
    logo: {
        flex: 1,
        // remove width and height to override fixed static size
        width: null,
        height: null,
        // make the background transparent so you actually see the image
        backgroundColor: 'transparent'
    },
    navigator: {
        flex: 1,
        backgroundColor: 'transparent'
    },
    welcome: {
        fontSize: 20,
        textAlign: 'center',
        margin: 10,
    },
    instructions: {
        textAlign: 'center',
        color: '#333333',
        marginBottom: 5,
    },
});

AppRegistry.registerComponent('SampleApp', () => SampleApp);

module.exports = SampleApp;

Hi there, this isn't currently supported. I strongly suggest that you use Navigator instead of NavigatorIOS (see the comparison docs here) and then you won't have this issue. NavigatorIOS is not actively being worked on -- it is a "Community Responsibility" because it is essentially unused by Facebook and by other core contributors, and the community hasn't been particularly interested in pushing it forward either (very few pull requests), so it would be unsafe to build your app around this.

I think the confusion here is that Facebook is using a NavigatorIOS in this main demo - https://github.com/facebook/react-native/blob/master/Examples/Movies/MoviesApp.ios.js


log.Warning("Watch to '%s' stopped at revision %d", prefix, w.revision)

log.Warning("Watch to '%s' stopped at revision %d", prefix, w.revision)
what is this warn mean?
confd tell this and cannot receive new watch update

I have located this situation.
It is caused because etcd client auth token expires, etcd server gives auth: invalid auth token: xxxxxxxx. You can stop and wait sometime then restart etcd server to reproduce it.
The etcd client v3 doesn't give a WatchError, because its version is too old. I upgrade it to 3.3.15 and watch this error ERROR Watch error: rpc error: code = PermissionDenied desc = etcdserver: permission denied

https://bbs.huaweicloud.com/blogs/151610


Fixes behavior of progress_messengers

Closes https://github.com/tomchor/Oceanostics.jl/issues/71
Simple fix so that the SingleLineProgressMessenger is actually single line

Could make sense to test this

Could make sense to test this

Testing that the number of lines matches what we expect? I don't know of a simple way to write such a test...

After some trial and error it looks the following will work. First create one file with
using Oceananigans
using Oceanostics

grid = RectilinearGrid(size=(4, 4, 4), extent=(1, 1, 1))
closure = ScalarDiffusivity(ν=1e-6, κ=1e-7)
buoyancy = Buoyancy(model=BuoyancyTracer())
coriolis = FPlane(1e-4)
model = NonhydrostaticModel(; grid, closure, buoyancy, coriolis, tracers=:b)

messenger = SingleLineProgressMessenger(initial_wall_time_seconds=1e-9 * time_ns())
simulation = Simulation(model; Δt=1e-2, stop_iteration=1)
messenger(simulation)

Then if this file is "run_progress_messenger.jl", the test looks something like
using Test
io = IOBuffer(append=true)
run(pipeline(`julia --project run_progress_messenger.jl`, stderr=io))
@test countlines(io) == 1

After some trial and error it looks the following will work. First create one file with
using Oceananigans
using Oceanostics

grid = RectilinearGrid(size=(4, 4, 4), extent=(1, 1, 1))
closure = ScalarDiffusivity(ν=1e-6, κ=1e-7)
buoyancy = Buoyancy(model=BuoyancyTracer())
coriolis = FPlane(1e-4)
model = NonhydrostaticModel(; grid, closure, buoyancy, coriolis, tracers=:b)

messenger = SingleLineProgressMessenger(initial_wall_time_seconds=1e-9 * time_ns())
simulation = Simulation(model; Δt=1e-2, stop_iteration=1)
messenger(simulation)

Then if this file is "run_progress_messenger.jl", the test looks something like
using Test
io = IOBuffer(append=true)
run(pipeline(`julia --project run_progress_messenger.jl`, stderr=io))
@test countlines(io) == 1

to test multiple closures, the closure could be an input argument to run_progress_messenger.jl OR you can just loop over closures within that file and then @test countlines(io) === number_of_closure. Or something.

Couldn't make this work. Apparently running commands from within Julia isn't super easy and isn't the same from environment to environment. I found many threads likethis one.
For me, even running this gives me an error:
julia> run(pipeline(`julia`, stderr=io))
ERROR: IOError: could not spawn `julia`: no such file or directory (ENOENT)
Stacktrace:
 [1] _spawn_primitive(file::String, cmd::Cmd, stdio::Vector{Any})
   @ Base ./process.jl:99
 [2] #637
   @ ./process.jl:112 [inlined]
 [3] setup_stdios(f::Base.var"#637#638"{Cmd}, stdios::Vector{Any})
   @ Base ./process.jl:196
 [4] _spawn
   @ ./process.jl:111 [inlined]
 [5] _spawn(::Base.CmdRedirect, ::Vector{Any})
   @ Base ./process.jl:139
 [6] run(::Base.CmdRedirect; wait::Bool)
   @ Base ./process.jl:439
 [7] run(::Base.CmdRedirect)
   @ Base ./process.jl:438
 [8] top-level scope
   @ REPL[15]:1

I think I'm gonna merge this as it is right now and we can open a new PR once we come up with a different way to test this.

julia> run(pipeline(julia, stderr=io))
ERROR: IOError: could not spawn julia: no such file or directory (ENOENT)
Stacktrace:

You may need to run a script, eg julia script.jl rather than launch the REPL.


Abstract away ADPCM subformats, add "SB4" codec

Use WAVE subformat 0x200 for SB4 ADPCM as per https://www.iana.org/assignments/wave-avi-codec-registry/wave-avi-codec-registry.xhtml
Please refer to https://wiki.multimedia.cx/index.php/Creative_8_bits_ADPCM for encoding and decoding scheme
Now I am not sure whether there are any WAVE files out there that actually use this subformat, but I figured it would be OK to use it anyway. It's main advantage over IMA is decoding speed, which is at least 50% faster and primarily targets low end and old devices that natively output 8-bit samples, such as SegaCD and/or Sound Blaster Pro. The quality is surprisingly good, all things considered.
The pull request also implements decoder for this subformat and should make it easier to add other ADPCM subformats in the future.

Thanks for this!
I'll take a look in the next few days, play around with it, and probably just pull it in...  :smile:

Thanks!

I have verified that this doesn't seem to cause any issues with the IMA format and pulled it in.
However, in testing the SB4 format I noticed that even if I deselect noise-shaping (-f for flat) the resulting quantization noise is still rather steeply tilted toward the low end. With the IMA format this results in a ruler flat noise spectrum (especially with higher look-ahead). I didn't spend enough time to determine if this is simply a deficiency in the format or a bug in this encoder (or decoder perhaps). Can you shed any light on this? If not I'll try to get a chance to look into it at some point.
Thanks again for the patch!

Hm, I suppose the noise is intrinsic to the format since the output samples are 8-bit, but I'm not 100% sure. The decoder that I came up could probably be cross-checked against the one found in SOX: https://github.com/skratchdot/sox/blob/master/src/adpcms.c#L38
As for the encoder, the place that I feel might be the primary suspect is decode_sb4_sample, which took a few tries to get sounding right, at least to my ears.

What players have you verified these encoded file with? The reason I ask is I just tried FFmpeg and VLC and they both sound terrible (noisy and loud glitches). Of course, I think VLC uses FFmpeg for decoding some things, so these may actually just count as one, but it's still not great. They sound fine using adpcm-xq for decoding, but that doesn't really prove much.
Also, I just noticed that the performance of IMA encoding went down about 50%. I hadn't noticed the changes in minimum_error() and since it can already be quite slow, I'm not sure this is the best solution; maybe duplicating that function would be better?
Anyway, I'm sorry, but I think I jumped the gun and would like to revert this change until I can investigate further. Thanks!

That's alright, I get why you'd want to keep the performance on the same level. It's probably the overhead of calling functions by pointers and lack of inlining that's killing it with all the abstraction levels added. I can rewrite that part, np.
As for the playback tools, there aren't many. The SB4 format is really ancient and I don't think that any of the modern programs support it fully. However, for testing I used Audacity where you can use the Import -> Raw.. functionality:

Just make sure your test file is at 44kHz Mono - the other options don't seem to work properly, at least in my version. It's still not 100% correct due to occasional pops and clicks, but works fine otherwise.

@dbry hi David!
Any chance you might want to look into the SB4 codec some time again? :)

Hi @viciious !
I think I'd like to leave this program doing IMA ADPCM, especially now that I've made it a lot more complex already with 2-bit, 3-bit and 5-bit versions and am adding some other experimental raw versions that people use. Trying to handle a bunch of non-IMA stuff (or even just one) just doesn't seem like a great idea to me (especially one we couldn't even get a working reference decoder for).
What might make sense though would to fork the repo instead and use the recursive search structure and code and apply it to SB4. That would probably be cleaner (you could rip out ADPCM) and I assume that's the part that you think is worth something. I'm actually thinking of doing that for SDX2 and CBD2 which I've recently become perversely interested in.
Cheers!

Sure, no problem at all!
Just in case you might get perversely interested in SB4/Creative ADPCM codec some time again, I just found a project on github that implements both the encoder and decoder: https://github.com/TerrySoba/VocTool/blob/master/src/encode_creative_adpcm.cpp
The codec is used in Creative's old VOC file format, which I didn't feel like adding support for to adpcm-xq and reused WAVE/RIFF instead. Now that there's an alternative encoder, it might actually make more sense some day.
Regards,
Victor

Sorry, there is no discussion section.

I'm actually thinking of doing that for SDX2 and CBD2 which I've recently become perversely interested in.

As in the same SDX2 by Phil Burk I mentioned the other day?

Just in case you might get perversely interested in SB4/Creative ADPCM codec some time again, I just found a project on github that implements both the encoder and decoder: https://github.com/TerrySoba/VocTool/blob/master/src/encode_creative_adpcm.cpp

Interesting that this guy also uses lookahead to improve the quality! Maybe I'm missing something but it sounds like this covers all the bases.

Sorry, there is no discussion section.

I'm actually thinking of doing that for SDX2 and CBD2 which I've recently become perversely interested in.

As in the same SDX2 by Phil Burk I mentioned the other day?

Yes, the same. I am wondering if my lookahead and noise-shaping algorithms might improve this format too. And I think you mentioned the only available encoder is an old Apple binary? Seems like we might be able to fix that.

Just in case you might get perversely interested in SB4/Creative ADPCM codec some time again, I just found a project on github that implements both the encoder and decoder: https://github.com/TerrySoba/VocTool/blob/master/src/encode_creative_adpcm.cpp

Interesting that this guy also uses lookahead to improve the quality! Maybe I'm missing something but it sounds like this covers all the bases.

Not quite as it doesn't have noise shaping.. So I guess the ultimate way forward would be to marry adpcm-xq with VocTool :)

And I think you mentioned the only available encoder is an old Apple binary? Seems like we might be able to fix that.

Yes, though I'm in the process of porting it to modern C/C++ based tool I'm working on. I have source for the cli tool from MacOS if you want it. Or do you have some other source of info on the codec?

BTW... I've been in contact with Phil and he even came to visit our Discord server a couple months ago when I reached out to him. So if you like I could introduce the two of you. If you can get your work to improve his I'm sure he'd at least get a kick out of hearing about it. You're also welcome to join the Discord: https://discord.gg/kvM9cQG

And I think you mentioned the only available encoder is an old Apple binary? Seems like we might be able to fix that.

Yes, though I'm in the process of porting it to modern C/C++ based tool I'm working on. I have source for the cli tool from MacOS if you want it. Or do you have some other source of info on the codec? (edit: besides the patent)

Ah, there's a patent? That's interesting! There are several open-source decoders (FFmpeg, aifc2wav, vgmstream) so I figured out the format pretty quickly and already have a working encoder, so I don't want to be corrupted yet with other code. Let me see if my ideas produce any better results and then we can figure out what to do.


bokeh is broken

Need to replace from bokeh.objects import HoverTool, ColumnDataSource with from bokeh.models import HoverTool, ColumnDataSource  (as of Nov. 2014)
bk.hold() and that style of plotting has been deprecated (https://github.com/bokeh/bokeh/blob/7af50c4dc2dd9c2335a7a8a7855a4bb2f90bc6d2/sphinx/source/docs/releases/0.7.0.rst)
The API is so unstable that I suspect we should stay away.

(1) is an easy enough fix (https://github.com/pandegroup/osprey/blob/master/osprey/execute_plot.py#L15) but (2) requires more cycles than I have

https://github.com/pandegroup/osprey/pull/85


upgrade to support dbt-core v1.5.0

Background
The latest version of dbt Core,dbt-core==1.5.0rc1, was published on April 13, 2023 (PyPI | Github).
How to upgrade
https://github.com/dbt-labs/dbt-core/discussions/7213 is an open discussion with more detailed information. If you have questions, please put them there!
The above linked guide has more information, but below is a high-level checklist of work that would enable a successful 1.5.0 release of your adapter.

[x] Add support Python 3.11 (if you haven't already)
[ ] Add support for relevant tests (there's a lot of new ones!)
[ ] Add support model contracts
[ ] Add support for materialized views (this likely will be bumped to 1.6.0)

the next minor release: 1.6.0
FYI, dbt-core==1.6.0 is expected to be released at the end of July, with a release cut at least two weeks prior.

I'm super excited for the governance features (e.g. constraints) to be supported in table_hive_ha materialization. :)


Use RxJS 5 version of websocket subject

Right now we have a home-rolled Websocket Subject (client/src/socket.js). RxJS 5 has a built in websocket module we could use, but it has a different interface from our current one. Obviously, it's better from a maintainability perspective to use the one from the library.
Then again, it may become moot if we move to something like engine.io, so we should think about this

Since we've gone completely 360 on engine.io since I opened this issue, this seems like a good idea again

Things the new websocket subject needs to do beyond the one included in rxjs 5:

[ ] Multiplex by request_id
[ ] Send a handshake on opening the socket
[ ] Block requests from being sent until the handshake is accepted
[ ] Send end_subscription messages when unsubscribing
[ ] Complete an observable that gets a state: complete message
[ ] Deserialize pseudotypes, not just jsonify
[ ] Serialize valid objects to json (including pseudotypes) before sending

Current bug is that the handshake is emitted, but the connection gets closed after the handshake, so it's not still open next time you try to use the connection

Fixed by #619


Simple script for running samples

Hi, great project and paper! I was learning about the capabilities of SpaGFT and thought I could expose them through a argparse script. So in this PR I did just that.
The core of this PR is the script and a markdown file explaining how to use it, but I also updated some conflicting dependencies and notebooks. I also modified plot.py so that automatic plot showing can be turned off, since this would block the script when used in a non-interactive way.
Thank you for your time and effort!

Thanks for your detail work on SpaGFT, which is greatly helpful to improve this project.


Enable beavis-ci on this repo again

beavis-ci has been moved out as a standalone tool, but we should enable it to run on this repo again. And this time maybe let it run on both tutorials and contributed? (cc @drphilmarshall)
This will also help us to make sure all tutorial notebooks are free of obvious bugs.
(cc @reneehlozek as this is one of the hackuDC2 preparation task)

I have set this up, reconfiguring my cron job from July. Standalone beavis-ci executes every notebook it can find, so as long as the contributed folder has a good README.rst file, it should show the badges and links as usual. I only see a markdown file in there for now, though.
The README.rst for the tutorials folder does now show how well we're doing. I see some notebooks failing with missing catalog errors:
.beavis/DC2-analysis/tutorials/log/extragalactic_gcr_cluster_colors.log:KeyError: 'Catalog `cosmoDC2_v1.0_small` does not exist in the register. See `available_catalogs`.'
.beavis/DC2-analysis/tutorials/log/extragalactic_gcr_cluster_members.log:KeyError: 'Catalog `cosmoDC2_v1.0_small` doesnot exist in the register. See `available_catalogs`.'
.beavis/DC2-analysis/tutorials/log/extragalactic_gcr_hod.log:KeyError: 'Catalog `cosmoDC2_v1.0_small` does not exist in the register. See `available_catalogs`.'
.beavis/DC2-analysis/tutorials/log/extragalactic_gcr_mass_relations.log:KeyError: 'Catalog `cosmoDC2_v1.0_small` does not exist in the register. See `available_catalogs`.'
.beavis/DC2-analysis/tutorials/log/extragalactic_gcr_redshift_dist.log:KeyError: 'Catalog `cosmoDC2_v1.0_small` does not exist in the register. See `available_catalogs`.'
.beavis/DC2-analysis/tutorials/log/truth_gcr_intro.log:KeyError: 'Catalog `dc2_truth_run1.2_static` does not exist in the register. See `available_catalogs`.'
.beavis/DC2-analysis/tutorials/log/truth_gcr_variables.log:KeyError: 'Catalog `dc2_truth_run1.2_variable_summary` doesnot exist in the register. See `available_catalogs`.'

I'm running with the desc-stack kernel. If this is as expected, feel free to close this out! Cron will run beavis-ci every 6 hours, at 0355, 0955, 1555, 2155 PDT.

Many thanks, @drphilmarshall. The failing is due to the shared python env has not been updated with the latest packages. They should go away once Heather updates the shared env.
I'm closing this now.


Drawing "Freehand" with a stylus pen zooms in-and-out at the same time

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When drawing "Freehand" with a stylus, erratic and unexpected zoom-ins happen.
For an example: it is almost impossible to write 3 times a letter "A" without zooming in aggressively.
It draws a line and zooms in-and-out at the same time.
Shapes like "A", "N" and "M" are most problematic.
It doesn't matter if the palm is touching the screen or just the stylus tip - the behavior is the same.
It seems that every 3rd-5th line is interpreted as pinch zoom at the same time.
To Reproduce

Using Microsoft Surface GO 2, touchscreen and stylus enabled.
Drawing "Freehand" with the pen.
Writing anything with the pen..

Expected behavior
Zoom level stays the same while drawing freehand with a stylus pen.

draw.io version 21.8.2

Desktop (please complete the following information):

OS: Windows 11

Additional context
The problem is the same whether it is a Windows Desktop app, online web app or VS Code plugin.

And a big thank you for a powerful and free graph drawing software!

https://github.com/jgraph/drawio-desktop/assets/34673712/4f03590a-0518-4705-9a55-5f508ad42a37
A video of zooming behavior when writing/drawing.

Hi,
I just wanted to confirm that the weird behavior is still the same in latest version 22.0.3
Freehand drawing with the stylus on Microsoft Surface GO 2 is unusable because of zoom-ins.

Did you rest the palm of your hand on the screen while drawing with the pen? If yes, can you check if this happens without resting the palm of the hand on the screen?

Sorry for not answering promptly, I haven't had the device with me for a long time.
The version is 22.1.2.
It still does the same thing.
Video shows the behavior:

no palm on the screen, just the pen tip
palm resting on the screen
drawing with finger

https://github.com/jgraph/drawio/assets/34673712/1418c82d-1f95-46c9-bd1b-ff0b8edbfc12

I also meet this issue in my Android Tablet freehand drawing & Win11+ Wacom pen freehand drawing. It is pretty annoying when I use pen to draw .....

@alderg  to clarify what I said about reproducing thisin latest web version(v22.1.16)
In my Android Tablet + sketch, when click freehand tool.

use my finger to draw the first line. It is OK
use my finger to draw the second or more free lines. Unexpected zoom in/zoom out sometimes happen when my finger moves vetically.

I also reproduce this issue in win11 + Wacom stylus pen. It is less frequency than tablet but it still happens.
If I use win11 + mouse, i don't see this issue.
Thanks a lot for looking into this bug. I often share my screen when I do the drawing in presentation, so it will make the viewer a lot.

I have same issue, I am using Windows 10 and UGEE Drawing Tablet S640W

I have the same issue, but I found a workaround.
Enabling "Mouse Mode"  instead of "Pen Mode" in my Wacom settings stops the zoom bug.

Windows 10
Draw.io: 24.6.4
Wacom Bamboo (Very old)

Another solution:
Disable "Windows Ink" if your tablet settings let you.

This fixed the zoom bug, and I can still use "Pen Mode".


Wrong binding of fetch_withRequest

https://github.com/rescript-lang/experimental-rescript-webapi/blob/main/src/Global.res#L496-L509
@send should be removed

Hello, thanks for reporting this issue!
I believe you are right, this might have happened when refactoring this method on the Window type.
Are you interested in sending a PR for this?


[TESTING] #15307

Commit Message: TESTING: PLEASE IGNORE
Additional Description:
testing #15307
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

https://storage.googleapis.com/envoy-pr/15331/docs/index.html


ScriptAnalyzer categories for rule severities

Consider an extensible model for rule severity categories.
It would be good to have another „severity“ level named „Performance“, to eventually being able to also submit rules that point to performance issues, and ultimately providing autofixes that would increase script performance.

Per Tobias' suggestion, create standardization a la standard PS verbs. These can be expanded later as the community suggests them.
These should probably be enumerated using something like -Tag Performance,Stability.
I'll also open the floor here to suggest tags that should be standard.
To be clear here, we would not be eliminating -Severity but rather adding -Tag as an additional metric of filtering.


show amount receiving instead of giving on button

@dianaclarke points out that showing the amount you give violates the anonymity principle. Instead of showing just the text "Gittip," how about if we show the amount the person is receiving? That'd be more like GitHub's "Star" widget and Twitter's "Follow" widget. We should show a depressed button if we wanted to indicate tippage without giving away the amount.
One problem is that we have limited width due to the hard-coded iframe embed.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

AFAIK it's done.

@nobodxbodon, you should check the grtp.co repo amd reticket widget stuff there if it needs to be.

@mattbk actually I checked the one served on shields.io, and seemed it's showing amount receiving. Thus I closed this one. Sorry I should have made it clear.


Allow Analyzer configuration in JS Interop

Currently we specify an Analyzer in JsInterop with no way to override that choice from the pure Javascript interface.
Discovered in https://github.com/cozydev-pink/protosearch/pull/92

This is no longer an immediate issue as we've opted to serialize and ship the Analyzer's as part of the Index in https://github.com/cozydev-pink/protosearch/pull/181. So I'm going to close this as there's nothing actionable right now.


Fetch logs path added as var

Description
adding the ability to control the path of the on controlled nodes logs fetching directory, currently set to /tmp

LGTM. Thanks @MosheBlumbergX Have you tested this out too?

Cheers @utkarsh5474 , yes this was test with a failure of broker to make sure that the path is used via a var in the inventory file


APKEditor Recompile Error/Failed !

Describe the bug
How to aapt2 use in APKEditor Like Apktoo
l
APKEditor

Apktool

ApkTool and APKEditor uses same smali We have a plan to move to our own dex lib soon.
Your issue is the most common one, in short the dex file you are editing is full. So try to re locating few *.smali files to new classes[xxx] (in your case classes7)

How to resolve with command


Pre-trained model sharing?

Hi, Thank you for sharing your code, I am currently looking for a pre-trained tacotron model, it seems you have talked about this in previous issues, but I cannot find any links to pre-trained models. Did you remove that? Probably there are some legal issues? Thank you.

Oh my god! Absolutely no. There's no legal issues at all when I share my pretrained model on the LJ dataset or the WEB data. I was totally forgetting it. And what is even worse is I can't find them! Let me retrain them. It should take around five days. Please check them again in five days. Sorry.

@Kyubyong That will be much appreciated! Thank you.

I've just updated README.md with the links for pretrained models. I'm not lazy so I didn't check if they work, so please let me know if there's some problem with them.

@Kyubyong I tried with your newly uploaded checkpoint, and it looks good. The quality of generated voice is more than acceptable. Thank you.

Closed for the author has uploaded the model checkpoint.

@Kyubyong ,This is not an issue, still...
Could you tell a measure of accuracy for all the pretrained models with respect to the state-of-the-art TTS service available?


Family

Do you plan to "revive" some other members of Z80 family too, in the future? Such as CTC or PIO?
I can provide some testing of real samples on logic analyser.
How fast the new Z80 will be?

CTC or PIO
No plans for CTC and PIO yet, mostly because I don't know 8-bit computers that ever used them. If you have a good example / case why they would be important - please let me know!

Instead, I was thinking about packaging Z80 with AY sound processor, Spectrum ULA and maybe TMS99xx, HD6845. Basically making small SoC (System on Chip) that could handle ZX Spectrum, Amstrad CPC and some MSX models. But that is a long term project.

I can provide some testing of real samples on logic analyser.
That would be great! There are couple of people that volunteered for hardware testing already and I will be looking for several more! I will keep you posted.

How fast the new Z80 will be?
According to simulation 50 MHz, but maybe 66 MHz.

No plans for CTC and PIO yet, mostly because I don't know 8-bit computers that ever used them. If you have a good example / case why they would be important - please let me know!

They are, but not so frequently as CPU. Most used is CTC (and also simplest), then PIO. Sharp MZ for example. The rarest is DMA and DART.

Instead, I was thinking about packaging Z80 with AY sound processor, Spectrum ULA and maybe TMS99xx, HD6845. Basically making small SoC (System on Chip) that could handle ZX Spectrum, Amstrad CPC and some MSX models. But that is a long term project.

This is a good idea. Spectrum ULA is becoming rare. But there is a little problem: Some pins are analog. Video output for example. But ULA is well documented at technology and gate level

But there is a little problem: Some pins are analog.

This is not FPGA :) we can do analog pins!


Revert adding tx_history

Revert the changes that were added when adding the tx_history. This should instead be tracked by the caller.

Tx history is no longer managed by the sp_client.


Update pubspec to sdk >= 2.6.0-dev.8.2

This should turn travis green again, assuming it picks up dev versions.


Following the lecture

I mostly changed the align environment to $$ that I couldn't parse for the presentation.
Two more things:

Line 72 with the <,> was also causing some problems, so I replaced by \langle and \rangle.

Also, this sentence was not clear to me:
"Another way to write this is that $x_k$ is orthogonal to all the rest of the vectors in the set $X$."
and I was understanding it as:
"Another way to write this is that any $x_k$ has a component orthogonal to all the rest of the vectors in the set $X$."
Is that what you meant?

@vincentqb What system were you running this on and what version of Jupyter?  I am surprised that the aligns did not work.

Also, for the orthogonality, the precise statement should be $\forall v \in X, <x_k, v> = 0$ except when $v = x_k$.  Does that better represent the statement?

On Ubuntu 16.04, from Jupyter notebook's about:
The version of the notebook server is 4.2.3 and is running on:
Python 3.5.2 |Anaconda 2.5.0 (64-bit)| (default, Jul  2 2016, 17:53:06)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
Python 3.5.2 |Anaconda 2.5.0 (64-bit)| (default, Jul  2 2016, 17:53:06)
IPython 5.1.0 -- An enhanced Interactive Python.

Huh, the version of Jupyter and IPython are the same.  The only big difference is the version of Python (I usually use 2.7 still).  Seems odd that it would have regressed though.  Does the following fix the rendering?
https://github.com/jupyter/nbviewer/issues/590

X is a list of vectors, not necessarily forming a linear space, right? I understand x_k to be a generic linear combination of vectors in X that may or may not be in X. Is that correct? For example, if I take x_k as (1,0) but X={(0,1),(1,1)} then x_k is a linear combination of vectors in X, but x_k is not orthogonal to the vectors in X. Did I get x_k and X right?

X is a set of linearly independent vectors.  From the wording I see how this could be confusing though as x_k \in X but in the cell above is written as a contradiction of the statement.

I changed some of the aligns and fixed the angled brackets in commit e3a0bca5b5c2d53a16a122eea5c20a08b1387adc


Zoom shows wrong location/region

Firstly many thanks for the many enhancements included in this implementation.
Zoom is one of the nice features but when I tested the latest code, it displays a zoomed-in region very far from the pointer. The expected zoomed-in region should be around the mouse position or using the mouse position as the top left corner of the zoomed regions.

Not entirely sure if the preview being far away from the pointer was actually intentional but regardless, I'd also like to add that because of this: trying to zoom to the edges of the screen will cause flickering on the viewfinder.
https://user-images.githubusercontent.com/88552647/128542785-0b8a3717-a35c-4500-b0b6-cc1b1735ed03.mp4
Also the pointer is smaller and misplaced compared to what I had on screen for some reason. I used ShareX with FFmpeg to record this vid.
I'm using a dual monitor setup if that's relevant. And also I'm really glad I found this app, I was having trouble with DemoHelper and Zoomit, so thanks for that.

a) on the edges, the area to be copied overlapped out of "screen" and the capture is capturing bad area. I knew this symptom but no one complained about yet. I will see if I can fix that quickly
b) ffmpeg does not capture screen cursor size and keep it at 32x32 : the bug is on its size😉 You can replace the cur files with a 32x32 and it will fix the global behavior
c) I also would recommand you to have a look at #92 discussion :  you should set the properties to ensure not trouble with mutltiple screen.

Can you try this version for the zoom on the borders:
ppInk64_Zoom07a.zip
About your issue with the cursor, have you tried OBS ?

Can you try this version for the zoom on the borders:
ppInk64_Zoom07a.zip
About your issue with the cursor, have you tried OBS ?

Yes I usually use OBS anyway so it's no problem, I just use ShareX and ffmpeg for short video screenshots and things like that.
I've tried out the new file, and the flickering isn't present anymore, it just shows black instead, so definitely workable now in my case :D And the offset of the viewfinder to the cursor is still present, which I'm still not sure if it's intentional or not. So thanks for that 😊

Sorry I think I sent you to the wrong thread
Try this :
https://github.com/pubpub-zz/ppInk/issues/97#issuecomment-877617071

Sorry I think I sent you to the wrong thread
Try this :
#97 (comment)

Yea okay, I've changed it. I don't really see a difference 😅 but I'll keep it on so I don't encounter any bugs regarding DPI and all that... Thanks 😊

@rexelbartolome,
Just to confirm : the problem of offset is only visible through ffmpeg and you get no offset when looking directly at the screen ?

@chuong,
Have you tried
#97 (comment)

@rexelbartolome,
Just to confirm : the problem of offset is only visible through ffmpeg and you get no offset when looking directly at the screen ?

Hmmmm no, either way the zoom viewfinder still has an offset from the cursor. I double-checked and I might be mistaken on my previous post as only the size of the cursor changed with using ffmpeg and I must've thought that the placement of it also changed, turns out it might be the same offset. I used OBS now for this clip and used the new version that you provided, it still has an offset but the cursor size is correct since I'm not using ffmpeg anymore :)
https://user-images.githubusercontent.com/88552647/128647993-b78f9dbd-4d1b-4891-a2d0-644b3d342bf2.mp4

I have some troubles to see the offset you are talking about;
When I search the  center position of the zoom it matches the head of the arrow:

I checked quickly everywhere and it looks good. If you don't think so, can you provide the snaptshot.

Oh okay I understand now, the offset I was talking about was the distance between the point of the cursor and the blue box, which is highlighted in yellow

I guess it's more noticeable when the cursor is on the lower right and the viewfinder is on the upper left.

I see it as an offset because I used to use Windows' native magnifier in lens mode and the cursor is on the center of the viewfinder. I just expected the cursor to be at least inside the viewfinder, not outside of it

https://user-images.githubusercontent.com/88552647/128693054-e62be3a3-0cd0-43ba-97f2-34bbcd6d26d1.mp4
But I guess that answers my question whether or not the offset was intentional or not, so maybe I just need to get used to it 😅 This way might be a better way of handling it too, since the viewfinder almost never gets clipped unlike Windows' version where if we zoom in on the corners, it gets clipped and goes outside the screen :)

My zoom is 100% dynamic, because of that, the enlarged area can not be displayed behind the cursor (zoomIt takes a snapshot only once and can not show changes behind.
On the pictures you have provided you can seen the zoom area is always centered on the cursor ( this is why now pixels within the rectangle centered on the cursor but out of the screens are now blackened) : the "yellow line" you've plot will never change even on borders. 😊

@chuong  @rexelbartolome
I propose to close this thread

@chuong @rexelbartolome
I propose to close this thread

I'm okay with it 😄


Error in Markmap Action: Failure when no changes required for commits

Checked for duplicates
Yes - I've already checked
Website or Best Practice Guide?
Website
Describe the bug
When a release is performed, automation regenerates Markmap markup for publication to the SLIM website. When an .md file changes anywhere in the repository tree, the action is triggered. When no markmap-generated files change, no commit is made to the repository and the action fails. The failure is precipitated by Git not finding any files to re-commit to the repository. This is an erroneous failure.
What did you expect?
Git should detect when there are no commits and the script should exit gracefully with a success exit code since that is performing as expected.
Reproducible steps
1. Change a markdown file, like `CHANGELOG.md`.
2. Perform a product tag/release.
3. Check the Actions tab to see a failed markmap action.

Environment
- GitHub `ubuntu-latest`
- Node 16 per recent GitHub requirements changes -- see https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Thanks for reporting this bug @jpl-jengelke


FLINK-2125

Attempt to complete task https://issues.apache.org/jira/browse/FLINK-2125

mvn verify went successful with 0 errors but my travis ci doesn't finish everything correctly. Still don't have solution for that

Hey,
Thanks for picking up this issue. The main task here is that the Reader#read() method returns an int representation of a character. To use String delimiters longer than a single character this solution is not sufficient. :)

Yes that's true. Wasn't sure what to do with that

Are there any tests for this functionality in the Flink code?

This pull request needs some work. All builds fail and the commit history needs a bit of cleanup.

What's the state of this PR @hczerpak? Are you still working on it?

I'll close this PR as nothing has happened since about 2 months.
@hczerpak Please open a new PR if you are still working on this issue.
Thanks!


(In Code Review) Add ability to retrieve Twitter accounts with username

https://jira.desk.technology/browse/APIJ-56

:+1:


Clumsy Bird

Game_Name
Clumsy Bird #236

Description 📃
In this game , you have to control bird such that it does not get touch to the pipes around.
To get points you have to pass through every hurdles in between.
functionalities 🎮
Easy to play
Can be operate through arrows or space bar
Fully responsive design
Fun to play

How to play? 🕹
Start the game by clicking Enter
Control the bird using space bar or arrows

Screenshots 📸

Thank you @Keya17Desai ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

follow proper guideline and then create a PR

Thank you  @Keya17Desai , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


wallet connect v2 test

📝 Changed routes:

/dashboard/wallet
/wallet-sdk

(view full size)
(view full size)

Commit 9b09f0e52b012ec2539c326e140cbc2c1a7486d9 (https://thirdweb-d5jc8rvdo.thirdweb-preview.com).


Use create3 in basic order creation

Summary by CodeRabbit

New Features

Introduced a new library for contract deployment using CREATE3.
Enhanced order creation functionality with a new salt parameter to prevent reuse.
Added new events for better tracking of order creation and salt usage.

Bug Fixes

Corrected the parameter name in the OrderCreated event for clarity.

Documentation

Updated documentation comments for improved clarity on function purposes and parameters.

Tests

Updated test cases to reflect changes in order creation and error handling logic.

Compiler show me warning
Warning (2018): Function state mutability can be restricted to pure
   --> test/BasicOrder.t.sol:427:5:
    |
427 |     function getTestSwapData() internal view returns (bytes memory) {
    |


WIP - Replaces truncation with rounding when setting CH shortcut weight.

Truncating the shortcut weight before storing it introduces small deviations from Dijkstra, which sometimes makes it harder to check the correctness of CH. Therefore I have replaced the long truncation with a Math.round() call.
Performance-wise isolated Math.round() will certainly be slower, but the profiler shows that the time spent on weight setting during the CH preparation is negligible. setWeight is only used for CH preparation.

tests failed with API limit reached ...

@ammagamma Would a higher precision also help? As it is very likely that we change this behaviour (we could use the same EncodedValue approach we have for non-CH but then it would be likely without rounding) can you introduce a test that is different with the rounding?

can you introduce a test that is different with the rounding

Good point. I added a test showcasing the problem where CH yields a different route than Dijkstra. Its quite intricate and I had to carefully pick distance values to reproduce the problem. I am not even sure if the test will fail on any machine. Not sure how deterministic the code / truncation is, need to refresh my knowledge here. I think the problem is that something like 2.010 might be represented as 2.009999 and after the truncation it will be 2.009. If this happens a few times a shortcut or set of nested shortcuts appears to be shorter than the real road and CH can take another way than Dijkstra.
Also this test does not pass with my previous fix, so I reverted it for now.
@Azbesciak Thanks for posting your problem, I might have a look and see if this is related to the issue I am referring to here.

I updated this to master, but I am still unsure. I think rounding is definitely 'more correct' than truncating and e.g. when comparing CH with Dijkstra we get less deviations (but they are always quite small). For better consistency we might even apply the rounding in EdgeAccess#setDist (which I have done here). But I am not sure if this is worth it. Asking the other way around: What are the cons of using Math.round instead of truncation ?

What are the cons of using Math.round instead of truncation

Good question. Maybe performance. But we do this now already in FactorizedDecimalEncodedValue and MappedDecimalEncodedValue too:
private int toInt(double val) { return (int) Math.round(val / factor); }
And so this should be probably not be a big issue. Especially since rounding would then just more consistent.

But we do this now already in FactorizedDecimalEncodedValue and MappedDecimalEncodedValue too.

Ok in this case I think we should apply the changes of this PR.

Will remove the "-1" for clarity


chore(main): release 4.16.0

:robot: I have created a release beep boop
4.16.0 (2023-08-25)
Features

bump twilio from 4.15.0 to 4.16.0 (38ce8d2)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/somleng/somleng-node/releases/tag/v4.16.0 :sunflower:


SDLWindow::Close causes double free?

https://github.com/openfl/lime/blob/4b2520a13f5e61046586812ec12fd5b49b78ba14/project/src/backend/sdl/SDLWindow.cpp#L173
SDL_DestroyWindow will be called in destructor again when finalizer is executed?
It might be better to do delete this instead of just destroying SDLWindow. You can then use val_gc(handle, NULL) or free_abstract to unset finalizer/C++ pointer.

I believe this is resolved, but please tell me if there are more issues here


doc: demos: add styled qr code generator demo

This demo was originally submitted by @stock90975 via a GitHub discussion.

Codecov Report
Patch coverage has no change and project coverage change: -0.39 :warning:

Comparison is base (8d70b6d) 70.51% compared to head (8d5d0a3) 70.12%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   70.51%   70.12%   -0.39%
==========================================
  Files          82       82
  Lines        5433     5433
  Branches     1176     1027     -149
==========================================
- Hits         3831     3810      -21
- Misses       1323     1347      +24
+ Partials      279      276       -3

see 14 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


K/V database

A simple database that maps keys to IDs, and IDs to IDs.

Have you seen https://github.com/boltdb/bolt?

Yep, love it.  That's what I'm using :)


webapp: Would like more categories than Incomplete/Done/Unusable

I think the webapp would be a good record of past talks and why the videos exist or don't exist.
Thinking ahead to additional categories to label the talks.

Unusable due to video quality

audio is bad
video is bad
it's missing chunks or cut-off.

Unusable because it is a BoF

maybe we could filter the BoFs out of the list of talks that the web app recognizes

Don't publish

Need manual editing

What is BoF?
Considering adding a notes field to each talk, then it's infinitely flexible. Unusable will be catch-all status, ideally with notes explaining why.

Ok, there's a notes field for each talk now. Editable by any role until cut is approved, then only editable by reviewers and admins.


Add ioloop utilization metric

@kunev just wondering what this diff is intended for? I don't see a description nor any reviewers. as a consumer of this library it'd be nice to see a description + discussion or a associated issue that carries that information.


[SPARK-45309][SQL] Remove all SystemUtils.isJavaVersionAtLeast with JDK 9

What changes were proposed in this pull request?
This PR removes all conditions related to JDK 9+.
Why are the changes needed?

To remove unused code.
We dropped JDK 8 and 11 at SPARK-44112 so no need to check lower versions conditionally.

Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI in this PR should test them out.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @dongjoon-hyun

@LuciferYang and @cloud-fan . They are mostly Hive and SQL direct buffer stuff.

For the following case, it should also be possible to perform cleanup:
https://github.com/apache/spark/blob/5d422155f1dae09f1631375d09e2f3c8dffba9a5/core/src/test/scala/org/apache/spark/util/UtilsSuite.scala#L1021
https://github.com/apache/spark/blob/5d422155f1dae09f1631375d09e2f3c8dffba9a5/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala#L338

Let me clean them up together here. Thanks!

For first and second, they are being fixed in a different PR (as it directly relates to one specific past fix, and I would like the author to review).

Let me turn this to draft for now. I think some tests might fail.

Merged to master.

Oops, I realised that there wasn't an approval here. I can revert or address the comments if there are some. Apologies.


More than 3 parent directories (..) in path ignored on Windows

cross-env version: 7.0.2
node version: 12.18.0
npm (or yarn) version: 6.14.5

Multiple parent directories (in my case, 5) has been treated as 3
package.json
{
...
  "scripts": {
    "prepare": "cross-env-shell \"cd ../../../../../otherproject && npm ci build\""

Output
> cross-env-shell "cd ../../../../../otherproject && npm ci build"

'..\..\..\otherproject ' is not recognized as an internal or external command,
operable program or batch file.
events.js:292
      throw er; // Unhandled 'error' event
      ^

Error: spawn ..\..\..\otherproject && npm ci build ENOENT
    at notFoundError (….\node_modules\cross-spawn\lib\enoent.js:6:26)

Note that only three sets of ".." are present in the error.  Placing an absolute path in the command works, so the problem is restricted to the parsing of the parent directories.

Note that this is not an issue for the developers using a Linux based OS

https://github.com/kentcdodds/cross-env/issues/257


not possible to run examples

Problem
Not possible to run examples .
Missing doc how to run them.
Examples looks they are prepared for both wasm-bindgen and wasm-pack but I think it cannot be mixed together.
wasm-pack needs this and must have main method defined within lib.rs
[lib]
crate-type = ["cdylib", "rlib"]

lib.rs
#[wasm_bindgen(start)]
pub fn run_app() {
    yew::start_app::<Model>();
}

wasm-bindgen needs main.rs and must not have crate-type = ["cdylib", "rlib"] in Cargo.toml
Environment:

Yew version [master]
Rust version [1.42.0]

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[x] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

Cool, yeah I think someone recently went through and added
[lib]
crate-type = ["cdylib", "rlib"]

for wasm-pack support because wasm-pack runs crates as libs. Which honestly isn't my favorite approach. Patiently waiting for this to get fixed in https://github.com/rustwasm/wasm-pack/pull/736 :)
I prefer using wasm-bindgen because it supports binary crates, @fbucek thoughts?

@jstarry I have learning repo where I have silly sort  implementation. There are two examples. One prepared for wasm-bindgen and second for wasm-pack, both using same index.html in static folder.
Both examples produces "same" results.
https://github.com/fbucek/yewbulma/tree/feat/table/examples

Whoops, I assume that's my bad. I've recently ported tests from using std_web/``cargo-web to use wasm-pack for the router's test suite and didn't know about a conflict with wasm-bindgen. I'm inclined to defer to using wasm-bindgen instead if everything else is set up to use that.

No, not your bad @hgzimmerman. web-sys examples have been busted since we added support ofr it (just more noticeable that it's just web-sys examples now in the root examples dir)


Add cross-cluster-replication to 2.7 manifest

Description
Add cross-cluster-replication to 2.7 manifest
Issues Resolved
https://github.com/opensearch-project/cross-cluster-replication/issues/763
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3397 (207b6de) into main (d626dfe) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #3397   +/-   ##
=======================================
  Coverage   91.74%   91.74%
=======================================
  Files         172      172
  Lines        4991     4991
=======================================
  Hits         4579     4579
  Misses        412      412

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Distribute throws EADDRNOTAVAIL

Hi,
I stumbled upon your library and have to admit I really like it. A few more examples and more documentation would help a lot (willing to help her). But conceptually really great.
While playing around with it, I wanted to reduce the time, my processing takes in order to test more variations on my logic. When using the distribute function, I am getting the following error:
Error: listen EADDRNOTAVAIL <IP_ADDRESS>
    at Object._errnoException (util.js:992:11)
    at _exceptionWithHostPort (util.js:1014:20)
    at Server.setupListenHandle [as _listen2] (net.js:1338:19)
    at listenInCluster (net.js:1396:12)
    at doListen (net.js:1505:7)
    at _combinedTickCallback (internal/process/next_tick.js:141:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    at Function.Module.runMain (module.js:695:11)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3

My Pipeline looks like this:
const nodeStream = readStream.pipe(JSONStream.parse());
DataStream.from(nodeStream)
  .each(validate)
  .catch(console.error)
  .remap(makeRemap())
  .distribute(cpus, subprocess)
  .reduce(reduceSum, result)
  .then(writeToFile)
  .then(() => console.log(result))
  .catch(console.error)
  .then(() => console.timeEnd('process'));

Some of the functions are not in this code, so here is the gist with everything:
https://gist.github.com/KeKs0r/f44834378254b7a6a1a953759467648d

Interesting, can you also add some info on your system?
It would be nice to see output from ip a and some general info. I'll look into this and try to reproduce.

I am running osx.
I tried to run my script on node 10.6.0 as well as 8.11.3.
What exactly do you mean with ip a?

Hi,
Sadly we don't have a mac machine in an automated pipeline - that's one of the things to set up for us...
I think I won't be able to check this before Monday. I'll update with my findings...

Thanks a lot for looking into this. If i can help by providing some input or test something. Let me know.

Well the reason for this is a different network stack or some permissions that doesn't allow me to use the whole <IP_ADDRESS>/8 network.
In this case it's just a matter of identifying that condition and using a narrower range of ip's.
If you could change the line:
https://github.com/signicode/scramjet/blob/master/lib/stream-worker.js#L42
to one of these:
        this.ip = `127.0.${process.pid % 256}.${process.pid >> 8}`; // or
        this.ip = `127.0.0.${process.pid % 256}`;
        this.ip = `<IP_ADDRESS>`;

and tell me which one helped.
The code is on the list for a major rewrite in scramjet v5.

I tried all options and it seemed that only the last one is working:
this.ip = `<IP_ADDRESS>`;

But when running I am getting this error:
internal/child_process.js:675
    var string = JSON.stringify(message) + '\n';
                      ^

TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at process.target._send (internal/child_process.js:675:23)
    at process.target.send (internal/child_process.js:586:19)
    at process.on.e (/Users/marc/Workspace/mmm/node_modules/scramjet/lib/stream-child.js:71:47)
    at emitTwo (events.js:126:13)
    at process.emit (events.js:214:7)
    at emitPendingUnhandledRejections (internal/process/promises.js:108:22)
    at process._tickCallback (internal/process/next_tick.js:189:7)
internal/child_process.js:675
    var string = JSON.stringify(message) + '\n';
                      ^

TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at process.target._send (internal/child_process.js:675:23)
    at process.target.send (internal/child_process.js:586:19)
    at process.on.e (/Users/marc/Workspace/mmm/node_modules/scramjet/lib/stream-child.js:71:47)
    at emitTwo (events.js:126:13)
    at process.emit (events.js:214:7)
    at emitPendingUnhandledRejections (internal/process/promises.js:108:22)
    at process._tickCallback (internal/process/next_tick.js:189:7)
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at _errnoException (util.js:992:11)
    at WriteWrap.afterWrite [as oncomplete] (net.js:864:14)

@KeKs0r can you try the new version and confirm it's fixed now?


showCoverageOnHover triggered wrong

I have the following problem: I am using markerCluster for Leaflet with the showCoverageOnHover option set to true. However, in Firefox (v 46.0.1), the event showCoverageOnHover is not triggered correctly, meaning that the cluster area is shown not only when the mouse is hovered over the cluster, but also if the mouse is far away from that cluster. Basically, I am using the standard procedure to create a markerClusterGroup, but with a customized icon creation function (Using d3 to draw a Pie chart). For details on my code please see http://stackoverflow.com/questions/37280535/leaflet-markercluster-showcoverageonhover-triggered-wrong.

Can you publish a fiddle/codepen/playground that displays this behaviour?

Sure, here is my Fiddle: https://jsfiddle.net/FindTheApple/sqeypmrn/

Solution is published in  http://stackoverflow.com/questions/37280535/leaflet-markercluster-showcoverageonhover-triggered-wrong.


Continuously generating useless particles

hence the title, the mod just makes useless particles everywhere. I think it might be a problem with the dimension stacking feature, but I'm not sure. I just know this mod is causing the problem.

also it's in version 0.14-mc1.16.4

also it's in version 0.14-mc1.16.4

Forge?

Forge?


⚠ Samsung has degraded performance

In 61687a4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2163 ms

Resolved: Samsung performance has improved in b4f8dc6.


Refactor team profile components for enhanced readability and added t…

…ype safety to the playground file

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[x] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
The primary motivation behind these changes was to improve the clarity and efficiency of the codebase while leveraging TypeScript's type safety features. This will help prevent potential bugs and facilitate easier collaboration among developers.
Test Plan
Verified that all components render correctly with the updated structure.
Ensured that TypeScript checks pass without any errors or warnings.
Conducted manual testing to confirm that all links and translations function as expected.
Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

Thanks, but these components are already well-typed and I fail to see how this PR improves any safety.

Nothing, don't mind. I saw some redundant code and created TeamRow component that takes a list of profiles and renders them, reducing redundancy in the individual team row components. Anyway I agree these components are well-typed.
I saw these components don't have tests. Can I make a pull request to test them individually or you think it's not needed?
Cheers!

I don't think that's needed. They are changed less than once a year and we can just visually test them.


Missing mass

Dear ChEBI team,
when I retrieve data through the sdf file, some molecules have the field Mass filed whereas another do not have.
do you any idea why?
for example the molecule: CHEBI:15714 seems no to have a Mass attributes in the export file (ComplteSdf)
could you precompute all mass when a chemical formula is available?
Thank a lot
Francois
Reported by: flefevre

done


Any plans for 0.8.0?

It's been five months and almost 200 commits since 0.7.0, just curious if/when 0.8.0 would get cut. Thanks!

Yeah, it is overdue.  I think we just go ahead and cut one now.  Thought @kamalmarhubi @fiveop @nix-rust/nix-maintainers ?

I'm tempted to ask for a libc release, and then there's a tiny improvement we can get to one recently merged PR that I can't find right now :/

@posborne let's wrap up a few outstanding PRs that are really close, then release? And no later than Friday...

Ok, I propose we let the following PRs get merged then cut 0.8:

#518 (BaudRate enum), waiting on https://github.com/rust-lang/libc/pull/530 which also looks close
#520 (ppoll(2)), waiting on https://github.com/rust-lang/libc/pull/537 which looks close to done
#522 (README mentions Rust version requirement)

Those libc PRs are merged. Asked for a release in https://github.com/rust-lang/libc/issues/539

In the future, anyone of us should feel free to bump the version whenever a few changes have accumulated. Given how we seem to work on this project in spurts, this will not happen more often than once a month anyway :)

Can we please wait for the release until after PR #506 finishes?  That PR changes an API that was introduced after 0.7.0.

Quick status update: libc release is blocked on https://github.com/rust-lang/libc/pull/538 (unrelated but soon-to-be-merged).

Selfishly going to add #540 and #541 to the blocking list.

I'd also like to nominate #527 which is done and just waiting on CI to finish.

@Susurrus I think you'll get your chance: yesterdays' S3 outage delayed https://github.com/rust-lang/libc/pull/538... :-)

@Susurrus I'm going to push a PR to bump to v0.8.0 now. We'll get your changes in soon. There's no reason we went five months between releases; it's certainly not a policy!

@kamalmarhubi Ack.

This is now tagged and published. Need to figure out how to get the changelog in the github release page some time.


grammatical errors(also my first PR)

Closes #

Changes

Flags

Screenshots or Video

Related Issues

Issue #
Pull Request #

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[x] Merging to master from fork:branchname
[ ] Manual accessibility test performed

[ ] Keyboard-only access, including forms
[ ] Contrast at least WCAG Level A
[ ] Appropriate labels, alt text, and instructions

Closing as inactive. Please reopen if you come back to it.


fix: NO-JIRA update exports and peerDependencies

Updated exports and peer dependencies

Updated dialtone-vue 2, dialtone-vue 3 and mono-package exports
Updated vite.config on dialtone-vue 2 and dialtone-vue 3 to divide common/* files and disable minification to help on debugging.
Updated peer dependencies versioning to exact version to avoid installing incompatible versions.

Some unit test errors, seems like something to do with multiple taptap versions being loaded.

Some unit test errors, seems like something to do with multiple taptap versions being loaded.

Yes, seems like different versions for vue 2, vue 3 and root packages were being installed, now it's more important that ever that we use exact versions to avoid ending up having multiple versions on multiple packages without noticing due to pnpm


Add option to shear tree-plot to feature metadata

Relevant to #419. Currently implemented only in tree-plot not community-plot.
Adds the --p-shear-to-feature-metadata parameter to tree-plot. This parameter, if set to True, shears the tree to only include tips present in the feature metadata. If the feature metadata file includes only internal nodes an error is raised. By default this option is set to False.

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

Thanks @gibsramen! :scissors:  :sheep:


Load clear-globals after global timer mocks load

If clear-globals loads before clear-intervals and clear-timeouts, it
will end up removing those modules' timer mocks. This fixes that issue.

WIP: This PR relies on merge and release of the following PRs:
https://github.com/segmentio/clear-intervals/pull/3
https://github.com/segmentio/clear-timeouts/pull/2


Add compute shell command -> drops to interactive python

I find myself hacking this function in over and over, in order to implement new functionality. It makes more sense to just do it once as a command.

Great idea :+1:
just a small comment on the message text


Fix compatibility with Storybook 5

Storybook v5 has changed setStories API, this causes to break Client#searchTargetStories ( this line )
At Storybook v5, setStories event's callback receive not Array, but Object.
ref. https://github.com/Quramy/zisui/issues/6

https://github.com/storybooks/storybook/blob/cfacc56856f13465bce2e0dd2434384d7334e40b/lib/api/src/index.tsx#L143
https://github.com/storybooks/storybook/blob/cfacc56856f13465bce2e0dd2434384d7334e40b/lib/api/src/modules/stories.ts#L71

Hi. We've released the next version of this project, formally Storycap (And Storycap's was based zisui sources). Storycap supports Storybook v5.2. Please check it out!