Synching new actions into master

Fancy holding off on this and its going to need updating straight away for the new repo name?

Fancy holding off on this and its going to need updating straight away for the new repo name?

Sounds good might Aswell get 2 birds with 1 stone

Sounds good might Aswell get 2 birds with 1 stone


Container fails to rebuild

Returns exit code 4 due to invalid url https://svn.wald.intevation.org/svn/openvas/trunk/tools/openvas-check-setup
Tried two alternatives both worked.

http://svn.wald.intevation.org/svn/openvas/trunk/tools/openvas-check-setup
https://raw.githubusercontent.com/jackl0phty/opschef-cookbook-openvas/master/files/default/openvas-check-setup

I'm unable to replicate this issue currently. I see that pages cert may have an issue but we had automated build run on docker hub a few hours ago without issue. I'm rerunning tests now.

@mikesplain Sorry for this probably was a temporary problem. I retried again the link with https and worked. Sorry for any inconvenience caused. My only concern is that in first try i hadn't mark as safe the link on my browser. (which at some point did). So I will try to see if I can replicate it this way.

@stafot Hey no worries! Thanks for reporting it. The master build I kicked off failed, it doesn't seem related but when I tested that URL a few times I did see some slowness. It may be flakey at the moment but it's still the documented URL for openvas.  Either way just browser testing your URL seems to be faster and more reliable.


Implicit many-to-many relations not working !?

Bug description
Hi,
I have a problem getting implicit many-to-many relations to work with the generated code.
Attached you find my schema and client-code.
Problem is, VSCode and Angular Live Deployment Server both show the same TypeScript error, related to the generated type:
error TS2739: Type '{ create: { id: number; name: string; }[]; }' is missing the following properties from type '{ connect: { id: number; } | { id: number; }[]; create: { name: string; } | { name: string; id: number; } | { name: string; }[] | { name: string; id: number; }[]; connectOrCreate: { create: { name: string; } | { ...; }; where: { ...; }; } | { ...; }[]; }': connect, connectOrCreate

53             tags: {
               ~~~~

  ./prisma/trpc/schemas/objects/ProjectUncheckedCreateWithoutAuthorInput.schema.ts:12:3
    12   tags: z.object(TagUncheckedCreateNestedManyWithoutProjectsInputSchemaObject),
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    The expected type comes from property 'tags' which is declared here on type '{ id: number; tags: { connect: { id: number; } | { id: number; }[]; create: { name: string; } | { name: string; id: number; } | { name: string; }[] | { name: string; id: number; }[]; connectOrCreate: { create: { name: string; } | { ...; }; where: { ...; }; } | { ...; }[]; }; ... 4 more ...; desc: string; }'

So the type needs all of create, connect & createOnConnect methods ?!
Or am I doing something else wrong ?
With plain prisma the same query is working perfectly.
How to reproduce
use my schema, the generator & my client code
Expected behavior
Type should work with create method only
Prisma information
schema:
model User {
  id        Int       @id @default(autoincrement())
  createdAt DateTime  @default(now())
  email     String    @unique
  name      String?
  password  String?
  projects  Project[]
}

model Project {
  id        Int              @id @default(autoincrement())
  createdAt DateTime         @default(now())
  published Boolean          @default(false)
  title     String
  shortDesc String
  desc      String
  author    User             @relation(fields: [authorId], references: [id])
  authorId  Int
  tags      Tag[]
}

model Tag {
  id       Int              @id @default(autoincrement())
  name     String
  projects Project[]
}

client-code:
trcp.mutation('user.createOneUser', {
  data: {
    email<EMAIL_ADDRESS>    name: 'Fabian Dreßen',
    projects: {
      create: [{
        title: 'Sample project  ',
        shortDesc: 'BlaBla Blub',
        desc: 'adasdasd dasdasdasd',
        tags: {
          create: [
            { name: 'sometag' },
            { name: 'anothertag' },
          ],
        }
      }],
    }
  }
});

Environment & setup

OS: Ubuntu
Database: SQLite
Node.js version: v14.18.1

Prisma Version
prisma                  : 3.14.0
@prisma/client          : 3.14.0
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 2b0c12756921c891fec4f68d9444e18c7d5d4a6a (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 2b0c12756921c891fec4f68d9444e18c7d5d4a6a (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 2b0c12756921c891fec4f68d9444e18c7d5d4a6a (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 2b0c12756921c891fec4f68d9444e18c7d5d4a6a (at<EMAIL_ADDRESS>Default Engines Hash    : 2b0c12756921c891fec4f68d9444e18c7d5d4a6a
Studio                  : 0.460.0

Far more, what I just found out,
with my schema, I cannot create a tag, without related projects:
client.mutation('tag.createOneTag', {
  data: {
            name: 'sometag' ,
  }
});

Tells me:
Property 'projects' is missing in type '{ name: string; }'

But in pure Prisma its working fine:
prisma.tag.create({
    data: {
         name: 'sometag' ,
    }
})

Hey @brainwind-software
Thanks for the report. It definitely  seems like a bug in the generated schemas.
Under the hood it uses prisma-zod-generator.
Working on it now.

Thanks for the report. This is affecting me too. Object maybe undefined on input errors on mutations in the generated routers.
@omar-dulaimi thanks for the project

Hey @brainwind-software
Thanks for the report.

@brainwind-software @rrmckinley
Should be fixed with 0.1.10.
This was a very stubborn bug.
Please make sure to star the repo if you like this project. Thank you :)


Add Open Graph / Twitter meta tags

Allow content to generate proper "cards" on Twitter and be better indexed by adding Open Graph meta tags (and twitter card type)

I believe we'd only need to set twitter:card for that, as the rest of the required tags would be pulled from the description etc. tags that mdBook already provides.

I believe we'd only need to set twitter:card for that, as the rest of the required tags would be pulled from the description etc. tags that mdBook already provides.

As far as I can see, every page just has this tag <meta name="description" content="The single, most comprehensive technical reference to Game Boy available to the public.">, whatever content it presents :/


$redirecting Store

Is your feature request related to a problem? Please describe.
For example...if I am redirecting on login I want the loading spinner to stay on even though the form is done submitting.
Describe the solution you'd like
I think it would be cool to have $redirecting store, like $delayed and $submitting so we can easily track it.
Describe alternatives you've considered
I could just easily add a flag onResult but I think it would be nice to have the Store easily accessible, like the others are.

This is already included in the timers, if a redirect result is returned,  then the SvelteKit navigation store is used to clear the timers. If that doesn't work for you, something isn't right. Can you make a MRE?

This is already included in the timers, if a redirect result is returned, then the SvelteKit navigation store is used to clear the timers. If that doesn't work for you, something isn't right. Can you make a MRE?

Here is a MRE: https://stackblitz.com/edit/superforms-2-testing-qcncdj?file=src%2Froutes%2F%2Bpage.svelte
I wonder if it's because of the page transition?

When I submit on the MRE, the spinner is visible up until the transition, isn't that how it's supposed to be?

When I submit on the MRE, the spinner is visible up until the transition, isn't that how it's supposed to be?

Well technically speaking I suppose yes, but it's a little jarring during a transition when the button state changes. I could just add a flag but was thinking of a cleaner way to do this as it's a common pattern for me, and I often already have $delayed or $submitting on the submit button - but perhaps it's unnecessary

Then I guess SvelteKit doesn't take transitions into account for the navigation store. Some future version of Superforms may have a custom callback for when the submission is determined to be completed, but not right now. :)


v1.0.0

This is large since it was easiest to do a complete rm -rf and rewrite.
There's definitely some things I'd like to improve and some missing functionality, but I think it's ready to get some use and feedback.

@skalee FYI

Thank you @dewyatt for the milestone. Merging now.

@ronaldtse Also, the new docs are available here if you want to add a link to description or elsewhere.

@dewyatt we'd definitely want to add them at https://github.com/riboseinc/rnpgp.com


Write a migration script for lists (Android)

I think we can close this issue, isn't-it?

@teolemon I think we can close this issue for Android

Is this feature tested

We haven't written a test, but empirical testing shows it works (on Android, the only platform to have lists)


Fix make verify

What this PR does / why we need it:
make verify did not work on the existing code base.
Which issue this PR fixes :
NONE
Special notes for your reviewer:
Checkout master and try make verify
...
Verifying ./bin/../bin/checks/verify-golint.sh
FAILED   ./bin/../bin/checks/verify-golint.sh	0s
...

checkout this PR and try make verify all tests pass.
other make tasks also continue to work as expected.

This change is

@philoserf could you please add that well crafted golint to the make verify?

The is what line 24 of bin/common.sh does.

@philoserf sorry are you sure about that?

@philoserf please i must be looking at the wrong file, let me know if thats what you meant. Ready to merge this in today if possible.

I think this is ready. I will share my one liner to run individual verify sub tasks with out of band.

Hold. I have one minor update coming.

Here is the one-liner to check subtasks. In this example I check each file with golint.
git ls-files "**/*.go" "*.go" | grep -v -e "vendor" -e "cmd/bindata.go"|xargs -I {} golint {}

All clear. Tests Pass. Verify works.


Ignore specific Block Devices using Regular Expression

We are adding the capability in the plugin to Ignore certain block devices, We need to pass the commandline Argument  ignore-block-devices-regex with regular expression matching the block device name that we want to ignore

@vakul-gupta-flp can you please provide little bit of description to the pull request on why & what is it solving?

@vakul-gupta-flp Can you see why the bdd tests are failing with the change.

@vakul-gupta-flp could you fix the bdd failure?

@pawanpraka1 @akhilerm I have tried running the device-driver in local and it's working fine but I am not sure why it's not coming up when we are running the tests. Can you verify that everything is ok at the CI pipeline end

@vakul-gupta-flp can you DCO singoff this commit.

@vakul-gupta-flp can you rebase the changes and push. We have fixed the BDD failure.

@pawanpraka1 I have rebased the changes


ngx-monaco-editor is showing no Suggestions

Cloned this project & customizing the same - Word Suggestions are coming only for Css & JavaScript languages as they are default.But requirement is Java,Csharp editors.
Html code -
<ngx-monaco-editor [options]="options" [(ngModel)]="displaycode" (onInit)="onInit($event)"></ngx-monaco-editor>

TypeScript code -
options = {theme: 'vs-dark'};
onInit(editor) {
  this.editor = editor;
}

I tried
1) options = {theme: 'vs',quickSuggestions: true,wordBasedSuggestions: true};

2) Inside ngOnInit function:

this.options = Object.assign({}, this.options, {theme: 'vs',language: java});
Theme changes are reflecting & if i debug language is updated in options.

3)  updateOptions() {
     this.toggleLanguage = !this.toggleLanguage;
     if (this.toggleLanguage) {
           this.code = this.javaCode;
           this.options = Object.assign({}, this.options, { language: 'java' });
     } else {
          this.code = this.cSharpCode;
          this.options = Object.assign({}, this.options, { language: 'csharp' });
     }

Image of editor showing - no Suggestions
i went through github links like https://github.com/Microsoft/monaco-editor/issues/632, but didn't find any help
How can i get word Suggestion working in the editor for Java & cSharp ?
Thanks in advance.

Hi!
I think what you mean is Intellisense for Java and C#, or?
Monaco doesn't have support for Java or C# Intellisense out of the Box...
https://microsoft.github.io/monaco-editor/

haven't tried it for now, but Intellisense for other Languages as the ones which are built-in, should be possible with a Language Server.
I don't know a Language Server for Java, but for C# there is Omnisharp! ->
http://www.omnisharp.net/
and there is also a Library for Monaco which connects Monaco with a Languageserver. ->
https://github.com/TypeFox/monaco-languageclient
I haven't seen any real implementation which uses Monaco and Omnisharp together, but i also have this need and will try to get it working togehter...

As i want Monaco-editor in my angular 5 project i went through https://github.com/Microsoft/monaco-typescript
I want the editor to support C sharp & Java on a toggle button.
Auto-suggestion, indentation & other things are fine.
But the entire code is in same color. Am expecting Keywords (like 'import' ) in different color.
I went through

https://github.com/Microsoft/monaco-editor/blob/master/test/playground.generated/customizing-the-appearence-tokens-and-colors.html
https://github.com/Microsoft/monaco-css
monaco.editor.colorizeElement(document.getElementById('container'));
https://github.com/TypeFox/monaco-languageclient

But no changes are reflected.
Any help on this ?

Is something implemented to solve this?
I want the recommendation to work with java and csharp, and java.
@manasagirinatham Did you solve the problem of the colors?

i handed over the problem to tech lead, so not sure about the status.
Will ping you once i came to know the update.
On Fri, Oct 12, 2018 at 12:13 PM YeisonGomez<EMAIL_ADDRESS>wrote:

Is something implemented to solve this?
I want the recommendation to work with java and csharp, and java.
@manasagirinatham https://github.com/manasagirinatham Did you solve the
problem of the colors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atularen/ngx-monaco-editor/issues/45#issuecomment-429221456,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUBHdds6AFzhkqAye_j20ZcjrHu3Zitfks5ukDn4gaJpZM4Ti43p
.

Is anyone got an idea how to add java language support with monaco editor


Docs.MS Release Updates for azure-resourcemanager-eventgrid

Update docs metadata and targeting for release of azure-resourcemanager-eventgrid

Docs Build status updates of commit 17933b6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/resourcemanager-eventgrid-readme.md
:warning:Warning
View (azure-java-preview || azure-java-stable || azure-java-legacy)
Details

package.json
:white_check_mark:Succeeded

docs-ref-services/preview/resourcemanager-eventgrid-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c002fc6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/resourcemanager-costmanagement-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-eventgrid-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-hdinsight-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-kusto-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-loganalytics-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-relay-readme.md
:warning:Warning
View (azure-java-preview)
Details

package.json
:white_check_mark:Succeeded

docs-ref-services/preview/resourcemanager-costmanagement-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-ref-services/preview/resourcemanager-eventgrid-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-ref-services/preview/resourcemanager-hdinsight-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-ref-services/preview/resourcemanager-kusto-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-ref-services/preview/resourcemanager-loganalytics-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

docs-ref-services/preview/resourcemanager-relay-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


spotlight search

Description of the new feature / enhancement
Spotlight search like search in windows
Scenario when this would be used?
it can be used in various scenarios such search in a very descriptive way.
Supporting information
No response

We have a powertoys called PowerToys Run. Please read about it here: https://docs.microsoft.com/windows/powertoys/run


feat: 🎸 Normalize AssetID to AssetId

Description
Update latest polymesh types, mainly updating AssetID to AssetId
Breaking Changes
NA
JIRA Link
DA-1331
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward

:tada: This PR is included in version 5.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Video Conference Mute < Universal Mute/Push to Talk Key

Description of the new feature / enhancement
Not sure if this is what this feature is going for, but I like using it as a universal Mute/Push to Talk Key for all apps and games that have voice chat.
It works great, obviously, but right now it only toggles mute, which is great, but it'd be great if it also had Push to Talk, and there was different indicators, like Discord does it great, it's icon changes on the taskbar depending if the mic is muted, open, or transmitting sound.

Scenario when this would be used?
Using any voice chat game or app.
Supporting information
No response

/dup #6308


0-RTT not working

Currently, we're creating a new CookieGenerator in the cryptoSetupServer. That means that the STK won't be valid across sessions. We should only have a single CookieGenerator for the whole server.

Fixed by #890.


merge custom config with prowler's default config

New feature motivation
When using prowler with the option --config-file, the given config file replaces prowler's own default config file. Therefore, users have to merge their config with prowler's config on every new release of prowler which is not only quite tedious but can also be forgotten.
Usually, users put in their custom config only those values that they want to match their specific requirements. These values should just overwrite prowlers default config values.
It is counterintuitive to require the user to provide a complete configuration that is already provided by prowler when they only want to specify a few custom configuration values.
Solution Proposed
I suggest that prowler merges both configs by giving precedence the values of the custom config file passed by --config-file. This behaviour must be documented.
Describe alternatives you've considered
I don't see any alternative. At the very least, the behavior of how a user-defined configuration file is used by prowler, i.e. overwriting or replacing, and also the consequences when upgrading prowler should be clearly documented.
Additional context
No response

Hello @kagahd, we were thinking about this when we realised that Prowler's config has default values in the places where the configuration values are used, so I think that if you just pass your config the rest of values should be defined as the default ones. Could you please verify it?
If this is not what you are suggesting, please let me know.
Thanks!

Hello @jfagoagas, thanks for your feedback!

so I think that if you just pass your config the rest of values should be defined as the default ones. Could you please verify it?

Yes, I just verified it for the check awslambda_function_using_supported_runtimes:
If I use my custom config.yaml by using prowlers --config-file parameter, the check finds obsolete runtimes only if my custom config contains the obsolete_lambda_runtimes array with the obsolete runtimes.
As soon as I remove obsolete_lambda_runtimes from my custom config, the check awslambda_function_using_supported_runtimes finds nothing anymore.
That's why I asked in the prowler forum if prowlers parameter --config-file replaces prowler's config instead to merge both.
Since you colleague @drewkerrigan confirmed my assumption, I opened this feature request.

Hello @kagahd, you're right and that's an issue in Prowler because each parameter should have the default value configured regardless if the config is passed/merged or not.
We will review and get back to you once we have an update.
Thanks!


Remove unnecessary AWS config and Amplify references

Looks like this file is not used in the web and caused troubles to setup our amazing interns to onboard and run the web app : )

looks good to me!


Permission denied when converting to draft

Maybe just a question, but I tried this but can't get it to work. Says I don't have permission to update the PR but it doesn't say how to fix this. I can't find any OAuth2 scopes that seem relevant. I'm sure I'm missing something.
❯ gh pr status

Relevant pull requests in Jeff-Walker/.....

Current branch
  #3  test [test]

Created by you
  #3  test [test]

Requesting a code review from you
  You have no pull requests to review

❯ gh pr-draft 3
gh: Jeff-Walker does not have permission to convert the pull request PR_kwDOGsTjSc40QvjS to draft.

Hi @Jeff-Walker
Suppose you ran gh pr-draft in your private repository?
As described in this document, the draft pull request is not available with a private repository belong to a personal account.

Ok, fair enough. I was using a personal, private repo to test. Thanks for the help.


Website not working

requestrepo.com
Is currently the website not available? I'm having issues with getting into it.

Should be up now.
Opened #35 since it seems that the DNS server went down.
Thanks for notifying me!


Update to Svelte@5

Resolves https://github.com/ngyewch/svelte-leafletjs/issues/42
Done

Updated codebase accordingly to Svelte 5 migration guide

(breaking) events now passed as object instead of array (they are also more typed)

Updated tooling
Updated dependencies

Thanks for this!


[Issue] Duplication of messages / Дублирование сообщений

Sometimes notification messages sent by bot are duplicated for some users.
Иногда сообщения от бота дублируются и присылаются по два раза.

Reason is in GCP's inability to strictly limit the number of concurrent runs of Cloud Functions.
Rarely, but Google ignate two parallel functions, which are resulted in 2x messages. Additional checks inside the code are causing delays (due to PSQL calls), which makes mass-notifications to thousand users significantly slower.
No vialble solution found so far, which will be able to guarantee "only one delivery" and "appropriate code performance" at the same time.

fixed


Set the canvas width and height using options

Current: The code inside particle is to create a canvas with 100% width and height.
Expected: Allow to use custom value for the canvas width and height.
I wanted to create a small-bottom-only particle background, this is why i need custom height values. I'd gladly work on it and create pull request if needed.

You can wrap your canvas. Particles.js is then using the dimensions of the parent element to render the canvas. Check this if you need a example: https://jsfiddle.net/m97g98sx/1/


Give git process clues in SCM input placeholder

This PR uses the SCM input placeholder to help a git novice know what to do.
When no changes exist:

When changes or untracked files exist but nothing has been staged yet:

After staging something the usual placeholder appears:

@gjsjohnmurray, thank you very much for your contribution. Rather than going down the path that is being proposed in this pull request, I would like to factor in this feedback in the work that is currently being tracked in https://github.com/microsoft/vscode/issues/135992. I am hoping that this is something that we could probably take a look at next milestone.
//cc @misolori

@misolori I confess I went straight to creating this PR. Pretty sure it arose from having responded to an issue in which a user was having a problem with the SCM view and seemed not to have grasped the sequence of steps. But I can't find that issue any more.
I created a branch to try out the idea on, then it seemed simpler to submit it as a PR than open a discussion issue first. No problem with me if you want to close it unmerged.

Found the issue which prompted it - #142335

@gjsjohnmurray, thanks again for your contribution. Today's Insiders release (2022-06-27) contains a Commit new action button which hopefully help users with committing their changes. Please give it a try and let me know what you think. I would like to further improve that experience in favour of using the placeholder text in the SCM Input. If you do not mind I will go ahead and close this PR.


Clarify WeakRefStrings purpose

Remove a few pitfall functions that allowed direct processing of WeakRefStrings. Clarify in docs that WeakRefStrings are for IO optimization and not actual string processing. Cleanup the WeakRefStringArray type parameters and constructors
cc: @nalimilan @alyst: I see this as step one to the plan in https://github.com/JuliaData/CSV.jl/pull/140
Should resolve #19 (@andreasnoack).

The key difference w.r.t #20 is that here WeakRefStringsArray{T} <: AbstractArray{T}.
I.e. for dispatch it's still an array of WeakRefString (or Union{WeakRefString, Missing}) elements, and only eltype(A) says it's String (or Union{String, Missing}).
So if e.g A::WeakRefStringsArray{WeakRefString{UInt8},1}, then B = A[1:2] yields B::Array{WeakRefString{UInt8},1}, so if A is gc-ed, the elements in B will point to invalid memory, and we are back to dataframe corruption problems of JuliaData/CSV.jl#132.

Yeah, I think this is mostly orthogonal to #20. I wonder whether it's a good idea to remove features, though. As long as CSV doesn't export WeakRefString and that indexing a WeakRefStringArray only returns String, there's no risk people will use them without being aware of the risks.
BTW, I wonder whether we could find a type which would be easier to understand, especially for WeakRefStringArray, which does not actually use weak references AFAICT since it ensures the backing memory isn't freed, and doesn't return WeakRefString entries now.

BTW, I wonder whether we could find a type which would be easier to understand, especially for WeakRefStringArray, which does not actually use weak references AFAICT since it ensures the backing memory isn't freed, and doesn't return WeakRefString entries now.

What's worrysome to me with the current usage pattern is that upon any string-like operation WeakRefString calls string() each time creating a copy of the string. So if WeakRefStringArray stays longer than just for CSV parsing, it might actually be less effective than Array{String}. OTOH in my experience many dataframe columns are either not used at all or dropped immediately after the frame is read. So it still makes sense to keep WeakRefStringArray in the resulting dataframe to avoid unnecessary allocation of strings. I was just wondering whether WeakRefStringArray could be transformed into something like:
struct LazyStringArray{T <: LazyString, N} <: AbstractArray{String, N}
    data::Vector{Any}
    elements::Array{Union{String, T}, N}
end

The idea is that if elements[i] isa LazyString, it's substituted with string(elements[i]), and all subsequent accesses return that same string. It could also be extended to handle missing data (if 0.7 doesn't support efficient storage of elements::Array{Union{String, T, Missing}, N}, it should be possible to use 2 arrays as a workaround). With this design LazyString (aka WeakRefString) is just a tuple of string start and length, so it could be kept completely internal to the package.

I think we could also have the data field be an Array{String}/Array{Union{String,Missing}, but leave entries that have never been accessed as undef. You'd just need to call isassigned before accessing entries.
Though that LazyStringArray approach is really equivalent to filling an Array{String} progressively as entries are accessed. So maybe we should just return an Array{String}, and leave WeakRefStringArray opt-in, for cases where you know it's more efficient to recreate String objects on every getindex call.

Though that LazyStringArray approach is really equivalent to filling an Array{String} progressively as entries are accessed. So maybe we should just return an Array{String}, and leave WeakRefStringArray opt-in, for cases where you know it's more efficient to recreate String objects on every getindex call.

If all columns/rows of the dataframe created by CSV.read() are used, then IIUC it's certainly better/easier to return Array{String} right away. But that's not always the case. Suppose you are loading the table of all protein sequences of a certain organism (ID column + sequence string column), but then you keep (by looking at the IDs) only those that are observed in your experiment -- with the lazy approach you just never access and never allocate unobserved sequences.

On the question of storing data::Vector{UInt8} in a LazyString directly, it makes a huge difference. What you describe is essentially the current definition of SubString, and will always be heap allocated because Array is a mutable object. By only storing a pointer and length, it's a true immutable object that can be stack allocated. That's a big part of the entire efficiencies WeakRefStrings provide.
I'm also not entirely sure on the need to inherit from AbstractArray{String, N} here; it feels weird to "spoof" our element type on a type definition level as opposed to just overloading eltype. Like, what if someone defined a method specifically for AbstractVector{String}, assuming String layout, yet a WeakRefStringArray would get dispatched to it? The "GC-corruption bug" @alyst mentioned in JuliaData/CSV#132 is just a simple bug in how I understood the AbstractArray interface to work. I thought if you implemented the scalar getindex, the multidimensional would utilize the scalar, but that doesn't quite seem to be the case. I've fixed that issue, however, in my latest commit.

I'm also not entirely sure on the need to inherit from AbstractArray{String, N} here; it feels weird to "spoof" our element type on a type definition level as opposed to just overloading eltype. Like, what if someone defined a method specifically for AbstractVector{String}, assuming String layout, yet a WeakRefStringArray would get dispatched to it? The "GC-corruption bug" @alyst mentioned in JuliaData/CSV#132 is just a simple bug in how I understood the AbstractArray interface to work. I thought if you implemented the scalar getindex, the multidimensional would utilize the scalar, but that doesn't quite seem to be the case. I've fixed that issue, however, in my latest commit.

AFAIK the T in AbstractArray{T} is supposed to reflect the result of eltype. It doesn't say anything about the storage type -- and how could it do that, given that there's no defined interface other than getindex to access the elements of an AbstractArray? CategoricalArray{T} is an AbstractArray{CategoricalValue{T}}, yet it doesn't actually store the entries as CategoricalValue.
And why would you want dispatch not to accept a WeakRefStringArray as an AbstractArray{String}? It behaves like an array of strings, so it should definitely be considered as such.

It will be considered as AbstractArray{<:AbstractString}, which seems good enough to me? I like how simple the type definition and methods are right now for the type, and I feel like the extra type parameter gymnastics in order to subtype AbstractArray{String} seem not worth it.

"Good enough" doesn't seem enough to me when we can easily implement the correct definition (and already have code by @alyst for that). We've been that way with DataArray already, and in the end it created small problems in many cases which we would better have avoided from the start, rather than having to break people's code later.

But what if we end up implementing a proper AbstractString interface for WeakRefString directly? And all the sudden we actually want the element type to be WeakRefString? All that changes in my current definition here is we change what eltype returns, as opposed to more (breaking) type parameter gymnastics to undo a hard-coded String eltype.
If there are actual cases where subtyping AbstractArray{AbstractString} instead of AbstractArray{String} will be problematic, I'm all ears; but I've yet to see a compelling case here that would be worth the extra code complexity.

By only storing a pointer and length, it's a true immutable object that can be stack allocated. That's a big part of the entire efficiencies WeakRefStrings provide.

:+1:

as opposed to more (breaking) type parameter gymnastics

Nah, it was not a "type parameter gymnastics". We can do much more overcomplicated things than that ;)
Actually, I agree with @nalimilan. I think the issue of WeakRefStringsArray <: AbstractArray{T} inheritance is straightforward:

I always thought that eltype() is just a convenience method to get T
T should be the type returned by simple getindex() (see JuliaLang/julia#9586). If it's not the case, then WeakRefStringsArray breaks AbstractArray concept and will have to override (and maintain) a lot of Base AbstractArray methods (similar(), copy() etc).
T should be concrete and immutable for performance reasons
T should not be WeakRefString, because if it leaks outside of WeakRefStringsArray, there would be GC-related memory corruption problems. Also, CategoricalArray is an example of a container whose elements (by design) don't have sense without the container. That introduces a lot of issues, yet CategoricalValue at least has a proper reference to the pool.

I think that leaves us with T === String.

See what the manual says:

Note that it's very important to specify the two parameters of the AbstractArray; the first defines the eltype(), and the second defines the ndims().

Anyway, moving from AbstractArray{String} to AbstractArray{WeakRefString} isn't more breaking than changing the result of eltype.

Thanks for making these changes

What you describe is essentially the current definition of SubString, and will always be heap allocated because Array is a mutable object.

I don't think this is so simple anymore. @yuyichao has improved the compiler such that some of these allocations can be avoided. I also think that Base.String is quite a bit faster than when WeakRefStrings was created. Switching from WeakRefString so Base.String in TextParse had a quite limited effect on the performance when reading a very large and text-heavy dataset so it might be worth doing some benchmarks to figure out exactly when unsafe optimizations are really worth it.


Rework, clarify and deduplicate on/offhours documentation

As discussed in gitter, this is my attempt at fixing up the on/offhours documentation, largely based on the internal documentation I wrote for it for my employer. The general idea is that, in addition to some textual changes which I thought clarified the behavior, I combined all of the common on/offhours documentation on to one page, and cross-linked with the EC2- and ASG-specific use cases.
I'll be happy to fix anything up as required. I can probably also push the sphinx build somewhere if that would help.

Cool, thanks so much!
I was unaware of the RDS support, but I also haven't used it so I'm not sure I'm comfortable writing documentation for it...


Add O_SEARCH to freebsd, solarish, and fuchsia

What does this PR do
Checklist:

[x] I have read CONTRIBUTING.md
[x] I have written necessary tests and rustdoc comments
[ ] A change log has been added if this PR modifies nix's API

Hi, thanks for contributing to Nix, this patch LGTM expect that alias:)

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi,  emscripten ?

Hi, would you still want to add this symbol for these platforms :)

Hi, would you still want to add this symbol for these platforms :)

done - I just was scared by the long cfg line :)

(I would also like to see it on apple, but it's currently missing from libc - https://github.com/rust-lang/libc/pull/3659 )


Select product identifier position in settings

Current behavior

The product identifier selector for the cycle count app should show in the app section not the OMS section. Please refer to all apps with the same card for reference.

Will be fixed in https://github.com/hotwax/inventory-count/pull/366

Issue verified and working fine. Hence, closing this ticket.


Add prow jobs for gardener-extension-registry-cache repo

/kind enhancement
What this PR does / why we need it:
This PR adds prow jobs for unit tests and image builds of gardener-extension-registry-cache repository.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
These are test runs of these jobs:
ci-gardener-extension-registry-cache-unit
pull-gardener-extension-registry-cache-unit
pull-gardener-extension-registry-cache-verify-image-build
post-gardener-extension-registry-cache-build-images

/approve


Update ai statistics

增加用户扩展 log & span attribute 机制

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.31%. Comparing base (ef31e09) to head (6033011).
Report is 96 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
+ Coverage   35.91%   44.31%   +8.40%
==========================================
  Files          69       75       +6
  Lines       11576     9823    -1753
==========================================
+ Hits         4157     4353     +196
+ Misses       7104     5142    -1962
- Partials      315      328      +13

see 80 files with indirect coverage changes


Controls and text are pixelated on Windows when scaling set to 200%

On a HiDPI display with scaling set to 200% libui applications render pixelated.

OS: Windows 11

I have some code that sets font size and DPI awareness:

I have some code that sets font size and DPI awareness

Nice, much better.

Here's all the code, just a few extra things done in the init function
https://github.com/petabyt/libui-dev/blob/660b9fe16817e7888d8ad2af571138813ebcec9e/extras/win_init.cpp#L18

Hi @wezm, there is an old PR for DPI awareness that needs to be finished. See #147.


Allow access to /dev/net/tun inside containers (port to 16.09)

Motivation for this change
This is a backport of https://github.com/NixOS/nixpkgs/pull/18822 to 16.09. Fixes https://github.com/NixOS/nixpkgs/issues/18708.
Note that I haven't tested this.
/cc author @wlhlm, and @danbst who is interested in this.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks! I've checked this patch on top of https://github.com/NixOS/nixpkgs/commit/6751f9464f6793cd4540129009ec266f3916d47d
enableTun = true; is crucial for the following NixOps configuration to work:
{

  vbox = { config, pkgs, lib, nodes, ...}: {
    deployment.targetEnv = "virtualbox";
    deployment.virtualbox.headless = true;

    environment.systemPackages = [
      pkgs.traceroute
      pkgs.telnet
    ];

    containers.c-analy = {
      autoStart = true;
      bindMounts."/var/lib/containers".hostPath = "/var/lib/containers";
      privateNetwork = true;
      hostAddress = "<IP_ADDRESS>";
      localAddress = "<IP_ADDRESS>";
      enableTun = true;
      config = {
        environment.systemPackages = [
          pkgs.traceroute
          pkgs.telnet
        ];
        networking.extraHosts = ''
          <IP_ADDRESS> vbox vbox-unencrypted
          <IP_ADDRESS> vboxServer vboxServer-unencrypted
        '';

        services.openvpn.servers.client.autoStart = false;
        services.openvpn.servers.client.config = ''
            remote vboxServer 1194
            dev tun
            proto tcp-client
            ifconfig <IP_ADDRESS> <IP_ADDRESS>
            secret /root/static.key
            verb 10
        '';
        services.postgresql.enable = true;
      };
    };

    networking.nat.enable = true;
    networking.nat.internalInterfaces = ["ve-+"];
    networking.nat.externalInterface = "enp0s8";

    system.stateVersion = "16.09";
  };

  vboxServer = { config, pkgs, lib, nodes, ...}: {
    deployment.targetEnv = "virtualbox";
    deployment.virtualbox.headless = true;

    environment.systemPackages = [
      pkgs.traceroute
      pkgs.telnet
    ];

    services.openvpn = {
      servers.main.autoStart = false;
      servers.main.config = ''
        dev tun
        proto tcp-server
        ifconfig <IP_ADDRESS> <IP_ADDRESS>
        secret /root/static.key
        port 1194
      '';
    };
    networking.firewall.allowedTCPPorts = [ 1194 ];
    system.stateVersion = "16.09";
  };

}

Hi,
I'm not sure this is a change eligible for backporting to stable, however perhaps so. Usually the only backports are security fixes and major bugfixes. This one seems a bit more minor / enhancement category.
That said, I'm not any sort of final decider on that, so I'll ping some people.
Thank you!

The bug makes openvpn unusable inside containers. I believe that's pretty major for some people.

Correct me if I'm wrong, but https://github.com/NixOS/nixpkgs/pull/18822 added the ability to run openvpn in containers, and before that it was impossible. In that sense, it is a feature addition and not a bug fix. In fact, the features being added are:

Specify arbitrary capabilities
Specify arbitrary devices available

While I hear the pain from not having these features, in that you can't run openvpn in the container, it is similar to saying it is a bug that you cannot run frotz in stable either, which is a new package introduced in unstable.

It is also a fairly large and invasive change. This is pretty tough to backport to our stable release, as we very much want to keep it stable. It would require extensive and careful testing to port.

@grahamc Actually, I'm the person who requested this PR. I have openVPN in containers in production on nixos-16.03
I guess the regression was introduced by https://github.com/NixOS/nixpkgs/commit/fd5bbdb4363cbd2935b0d5a37c4e7355f45e61a4, which ended up in 16.09
Some guys fixed that by introducing "an ability" to enable openvpn back (which is this PR about). In some sense the fix introduces new features, I agree here, but enableTun = true; fixes regression.
To be pedantic, this should be in release notes too. But I guess those little people affected can google the problem.

cc @domenkozar could I get your eyes on this?

I'm very vague about that part of our ecosystem and I won't have time to dig into this soon. Maybe @edolstra has thoughts?

@grahamc security

I want to weight in here:
For me this is not a regression for one very simple reason: There is no automated test that proves that it now works and didn't work before. If there was such a test here in this PR (or in its original on master branch), one could backport that to 16.03 and prove that it worked there and got broken. No test, no prove, no reason for me to approve this PR.
Of course maintainers might think otherwise. But I would really, really love to see a test for this feature and maybe also for openvpn in general. NixOS/nixpkgs provides an excellent infrastructure to set up these kind of tests. We should use it and maybe enforce usage of it. And if the test infrastructure is not up to par: the more users, the more fixers.

@kampfschlaefer I agree with you, that there should be more tests. I've adapted the above nixops deployment as NixOS test
Please, test as following:
# set up a basic VPN between server and container in client and ping container from server
$ NIX_PATH=nixpkgs=https://nixos.org/channels/nixos-16.03/nixexprs.tar.xz nix-build /var/proof.nix   # WORKS
$ NIX_PATH=nixpkgs=https://nixos.org/channels/nixos-16.09/nixexprs.tar.xz nix-build /var/proof.nix   # doesn't work
$ NIX_PATH=nixpkgs=https://nixos.org/channels/nixos-unstable/nixexprs.tar.xz nix-build /var/proof.nix   # doesn't work

This prooves the regression. In similar manner it is easy to show, that adding nodes.client.containers.c-analy.enableTun = true; will fix the test for nixos-unstable.
import <nixpkgs/nixos/tests/make-test.nix> ({ pkgs, ...} :

let key = pkgs.runCommand "static.key" {} ''
  ${pkgs.openvpn}/bin/openvpn --genkey --secret $out
'';
in {
  name = "vpn-in-container";

  nodes.server = { config, pkgs, lib, nodes, ...}: {
    virtualisation.vlans = [ 1 ];
    networking.firewall.allowedTCPPorts = [ 1194 ];
    environment.etc.deploy-key.source = key;
    services.openvpn.servers.main = {
      autoStart = false;
      config = ''
        dev tun
        proto tcp-server
        ifconfig <IP_ADDRESS> <IP_ADDRESS>
        secret /root/static.key
        port 1194
      '';
    };
   };

  nodes.client = { config, pkgs, lib, nodes, ...}: {
    virtualisation.vlans = [ 1 ];
    networking.nat.enable = true;
    networking.nat.internalInterfaces = ["ve-+"];
    networking.nat.externalInterface = "eth1";
    environment.etc.deploy-key.source = key;

    containers.c-analy = {
      autoStart = true;
      privateNetwork = true;
      hostAddress = "<IP_ADDRESS>";
      localAddress = "<IP_ADDRESS>";
      config = {
        networking.extraHosts = ''
          ${(pkgs.lib.head nodes.server.config.networking.interfaces.eth1.ip4).address} vpn-server
        '';

        services.openvpn.servers.client.autoStart = false;
        services.openvpn.servers.client.config = ''
            remote vpn-server 1194
            dev tun
            proto tcp-client
            ifconfig <IP_ADDRESS> <IP_ADDRESS>
            secret ${key}
        '';
      };
    };
  };

  testScript =
   let clientKeyPath = "/var/lib/containers/c-analy/root/static.key"; in
      ''
        #startAll;
        $server->start;
        $client->start;
        $server->sleep(10);
        $server->succeed("cat /etc/deploy-key > /root/static.key && chown root:root /root/static.key && chmod 600 /root/static.key");
        $server->succeed("systemctl start openvpn-main.service &");
        $server->waitUntilSucceeds("ping -c 1 <IP_ADDRESS>");

        $client->succeed("cat /etc/deploy-key > ${clientKeyPath} && chown root:root ${clientKeyPath} && chmod 600 ${clientKeyPath}");
        $client->succeed("systemctl start openvpn-client.service -M c-analy &");
        $client->waitUntilSucceeds("nixos-container run c-analy -- ping -c 1 vpn-server");

        $server->succeed("ping -c 1 <IP_ADDRESS>");
      '';
  })

From my point of view this is in fact a regression. Yes, there was no test covering this functionality, which is indeed very unfortunate. But it was trivially & without hacks possible through the NixOS module system to enable and use the openvpn service a NixOS container. This is not only a problem for VPN daemons but all services requiring special device nodes.
We've thus removed useful and expectable functionality in 16.09 compared to 16.03 without and easy and natural way to override these restrictions using the module system. Classical regression IMHO.
Thanks for the test! LGTM in principle, could you please open another PR for that?
This commit does indeed touch a lot of chunks of code in the container code which also makes me feel a bit uneasy. I've checked the history of nixos/modules/virtualisation/containers.nix and made the following observations:

There was some cleanups to the code that is to be backported to 16.09 here. Specifically 69713a882ca0f3e1febf03c8f73b00d06d2cd2ae, a67b597b22b6572b08b0fbd875299a052efab02e, b6023f37ad981f8eacb57d49ce18f708b43adc43. As we didn't deprecate optionSet in 16.09 we don't need to backport as they provide no functional changes.

Cherry-picking https://github.com/NixOS/nixpkgs/pull/18822 from master into 16.09 (which this PR does) yields no conflicts. :tada:

Before that PR, only b9df84cd4f6b70bdfa395a91dbf3d712adc7e18d with a fix d6ce2e4bcb586870ef11a295b1634649fed36667 changed code in containers.nix. These are completely independent of the other changes and can thus be ignored in the context of this PR.

Therefore I think it's safe and useful to backport this to 16.09. :+1:

@danbst, could you please open a PR for adding the test to NixOS test suite?

Sorry I missed this for so long...!


chore(main): release 9.12.0

:robot: I have created a release beep boop
9.12.0 (2024-11-19)
Features

:sparkles: CodeCompanionCmd to write command-line commands (da52e53)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v9.12.0
:sunflower:


remove unnecessary application events

Anything kubernetes or scheduler-related that aren't human readable messages or important to the application operator should be removed. For example:
><> deis logs
INFO [go]: bacongobbler created initial release
INFO [go]: domain go added
INFO [go]: bacongobbler deployed 779ca3d
INFO [go]: Cleaning up RCS for releases older than v2 (latest)
INFO [go]: Cleaning up orphaned environment var secrets
go-v2-web-n1ykl -- 2016/04/27 18:20:36 Successfully copied home/go:git-779ca3d7/push/slug.tgz to slug.tgz
go-v2-web-n1ykl -- 2016/04/27 18:20:36 listening on 5000...
go-v2-web-n1ykl -- 2016/04/27 18:23:03 <IP_ADDRESS> GET /
go-v2-web-n1ykl -- 2016/04/27 18:23:03 <IP_ADDRESS> GET /favicon.ico

These lines should either be removed or made more generic because it is too verbose for application logs. The user should not know about the platform infrastructure. This is still important information for the platform administrator, however.
The log lines I'm talking about are specifically
INFO [go]: Cleaning up RCS for releases older than v2 (latest)
INFO [go]: Cleaning up orphaned environment var secrets
go-v2-web-n1ykl -- 2016/04/27 18:20:36 Successfully copied home/go:git-779ca3d7/push/slug.tgz to slug.tgz

That last message is a symptom of https://github.com/deis/builder/issues/306 and https://github.com/deis/object-storage-cli/issues/10

Right now they are INFO, we could make them DEBUG instead, so it is around if people want the verbosity, how does that sound?

I don't think deis logs or the logger filters by log level. It dumps anything in the application logs.

We'd make it do that if it doesn't already. I don't think we should show any DEBUG messages anyway unless DEBUG is on


Read "comments" tag for FLAC audio file

Hello,
I'm working on a sample project to read FLAC audio tags and I'm encountering an issue with the "comments" tag. Despite there being comments in the FLAC files, tags.metadata.comment is returning nil.
I would really appreciate your insights or any suggestions you might have on how to resolve this issue.
Thank you so much for your help!
Example project:
https://drive.google.com/file/d/1k6jun1LG_WM_tDefBiBl4YN9l9xiyUzY/view?usp=sharing

The issue is that the file contains a field named COMMENT while the canonical name for a comment in a Vorbis comment field is DESCRIPTION. Perhaps it would be better to look for a COMMENT field if a DESCRIPTION field is absent but you can access the other fields via the additionalMetadata dictionary.

It also seems that Picard uses COMMENT so perhaps DESCRIPTION is outdated despite what the spec says.

The issue is that the file contains a field named COMMENT while the canonical name for a comment in a Vorbis comment field is DESCRIPTION. Perhaps it would be better to look for a COMMENT field if a DESCRIPTION field is absent but you can access the other fields via the additionalMetadata dictionary.

I just wondering why TagLib reads this... so logically its wrapper in this repo should too, but it's not. Maybe as fallback?
Anyway, users reported me this problem, telling me that some files missing that comments filed, but other audio apps reads it.

It's somewhat a question of mapping. The higher-level TagLib accessor for Xiph comments use DESCRIPTION if found, COMMENT next, or "" if neither are present, joining multiple fields with the same name using /. I use the raw fields directly and follow the Xiph spec with regard to naming.

Hey @sbooth, will this issue be resolved anytime soon?

I suppose I need to be convinced this is an actual issue first.
In the meantime it's simple enough to test if the format is FLAC, and if so, check the additional metadata for the COMMENT field if the DESCRIPTION field is empty.


Fixed large and smallish memory leak

From not destroying renderer. And not destroying wlr_surface.

How can I ensure they all get destroyed in the right order @philpax?

The destruction order is in reverse order of declaration: https://stackoverflow.com/questions/29168162/destruction-order-of-class-data-members


An idea to update the README.md

To update and change the README.md, from the issue #56 , I made separate sections, and put the resources in tables. Please take a look and see if you approve.

@CodingSpecies Looks good @AvidCoder101 what you think about it?

LGTM, I like the way @CodingSpecies has organised it. Good job 🙂

I changed the icons, and changed the whole README.md to see how it would look.

@CodingSpecies Good Job, I need to review it and see impact of this and then merged this PR.

@CodingSpecies Good Job, Your PR is merged. I will share more issues on #56

Thank you @MRslimcoder , also, is it possible to be part of the organisation please?

Thank you @MRslimcoder , also, is it possible to be part of the organisation please?

I will ask owner for that.


Pre- and post-conditions on period state evaluated in initial/final rounds

Is your feature request related to a problem? Please describe.
The period state is used across multiple apps if apps are chained. It would be desirable to let the developer specify pre and post conditions that need to be met.
Describe the solution you'd like
For all initial states of an app, developer specifies the keys which need to be set on the period state.
For all final states of an app, developer specifies the keys which need to be set.
The framework then checks that the keys are indeed set at runtime.

We do this now at the chaining time.


Use 2019 build queue

Also needs changing here: https://github.com/spatialos/UnrealGDKExampleProject/blob/feature/vs2019/ci/nightly.template.steps.yaml


Adjust vocabulary loading process to account for new data architecture

Implement changes to the vocabulary loading process (into workspace) with regard to the new data architecture.
It is possible that everything will already work as expected, but we need to double check it.

I assume you don't want to change REST API and if so, it should work without a change.


feat: Enable API users to request sections with regex patterns

Summary
Adds an m_section_regex parameter to the pipeline_api function, making a section_regex file parameter available in the API. Enables users to request a section by passing in a regex pattern. Requested patterns are treated as raw strings. Enforces a 60 second timeout on regex execution to defend against regex denial of service attacks. A TimeoutError will result if the regex runs too long.
Testing
The following API call should work after running make run-app-dev:
curl -X 'POST' \
  'http://localhost:8000/sec-filings/v0.0.1/section' \
  -H 'accept: application/json' \
  -H 'Content-Type: multipart/form-data' \
  -F<EMAIL_ADDRESS>\
  -F 'section_regex=risk factors' \
-F 'section=RISK_FACTORS' | jq -C . | less -R

The resulting JSON should have both RISK_FACTORS and REGEX_0 keys.

LGTM once i can figure out to pass special regex characters via the API. May be worth adding to the README as well.

This works via the API with special characters. I'll add it to the README
curl -X 'POST' \
  'http://localhost:8000/sec-filings/v0.0.1/section' \
  -H 'accept: application/json' \
  -H 'Content-Type: multipart/form-data' \
  -F<EMAIL_ADDRESS>\
  -F 'section_regex=^properties$'  | jq -C . | less -R

-F<EMAIL_ADDRESS>-F 'section_regex=^properties$'  | jq -C . | less

how about with a backslash special character like \s? (maybe this is what was causing me issues)

@cragwolfe - I think I got the \s characters working, standby for the fix

@cragwolfe - This should work now
 curl -X 'POST' \
  'http://localhost:8000/sec-filings/v0.0.1/section' \
  -H 'accept: application/json' \
  -H 'Content-Type: multipart/form-data' \
  -F<EMAIL_ADDRESS>\
  -F "section_regex=^(\S+\W?)+$"

@cragwolfe - This should work now

worth updating README?


Update M001176.yaml

fixing https, making first dropdown select required (it loads the form). leaving all the javascript for purpose of fullness.  thanks!

awesome, thanks! Assuming travis checks out, will merge!


support more color codes and modes

Refactored color code parsing a bit.
Added support for 8-16 color pallets.

black
red
green
orange
blue
magenta
cyan
gray
darkgray
lightred
lightgreen
lightyellow
lightblue
lightmagenta
lightcyan

Added support for additional modes:

blink
blink_rapid
reversed
hidden
crossed

By eagerly parsing the codes, this also fixes an issue: prior to these changes, the code couldn't handle color code parts prefixed with "0".
For instance, "01;36" should be treated as both bold and cyan, but the parts[i] === "1" condition would fail.

Made a couple last minute fixes, but I think it's all good to go now.


[5.5][WIP] Sync Str with Stringy 3.0.1

This PR intends to sync our core Str class with the behavior provided by Stringy library.
There's a few things that we should consider:
@ was removed from the library so it no longers changes to at, the library manually changes @ to - when generating the slug, I kept the previous behavior and moved it to the slug function, this way we can override the array in the future without caring about this and we also don't change the current behavior.
The library now uses locale's to replace characters according to the specific language. This also fixes some issues we had in the past of incorrect behavior, for example:
ü previously was being replaced by ue now it is replaced by u and is replaced by ue just when using the de locale.

@taylorotwell it's WIP, and lacks of additional actions like https://github.com/danielstjules/Stringy/blob/master/src/Stringy.php#L1863

@iwex I've done that https://github.com/laravel/framework/pull/18974/files#diff-d19e1b0b8c742f268aabdbf1595bcfbdR614 just simplified it a bit.

@iwex I've done that I just simplified the function https://github.com/laravel/framework/pull/18974/files#diff-d19e1b0b8c742f268aabdbf1595bcfbdR614
The behavior is the same $charsArray is a local static variable with all languages that are loaded, it contains the languages that were used before and add's new entries to the array whenever you use a new one, i removed this since there's just one language it would be overkill right now...
You might have confused it with the other $charsArray variable that contains all characters...

@fernandobandeira thanks for explanation :) Stringy has really messy method


Auto-casting types, better type detection for InfluxDB

Until then, we used LIMIT 1 in InfluxDB added to the original query to read the first line and determine the types of columns (and in case of no data, i.e. returning null, the assumed type was hard-coded to Double). Since recently String sensors came into use, so this way doesn't infer the types correctly anymore.
So, the proposed solution adds SELECT first(*) FROM <original-query> to obtain first non-null value, to correctly determine the type (if there is no data at all, it still returns null, but in the function registry it is converted to Result.fail or NaN, so false positive alerts are excluded).
Also, to avoid manual type casting in some cases, picking of best-match function (when one with exact signature was not found) was added (it works via the measure of "castability", i.e. priority for casting, for example, int-to-double casting is high-priority (no presicion loss), while double-to-int and int-to-string are low-priority (the former loses precision, and the latter can lead to unexpected results)).

Please rebase master to this

I've merged master to this, it works (but still unready to merge due to some false-positive alerts)

Now it contains changes for #63, so it should be merged after.


OCPBUGS-12736: Fix microshift-etcd signal handling by calling wait on the process after creating it

Call cmd.Wait on the microshift-etcd process asynchronously to make sure SIGCHLD is handled in case the etcd process exits before the microshift process. In this scenario, microshift should exit right after to avoid flooding the system log with error messages about not being able to connect to the etcd service.
Closes OCPBUGS-12736

/assign @pmtk

lgtm, thanks for fixing this Giga!

/lgtm

/retest e2e-openshift-conformance-reduced

/test e2e-openshift-conformance-reduced

/retest-required

/test microshift-e2e


feat: check-conformance cmd added that runs sonobuoy and shows failed…

… conformance tests
Checklist

[ ] Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
[ ] The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
[ ] The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
[ ] Helm releases are meeting otomi's baseline security policies, if applicable.
[ ] Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@srodenhuis this PR will add otomi check-conformance, and uses sonobuoy under the hood. It takes over an hour to run on an AWS 3 node c5.xlarge cluster, so please be sure to include that in the docs...


Follow-Up Fixes for gRPC

Slight wrap-function doc change to reflect previous changes
Comments summarizing start and end span points
Check agent.shouldTrace to determine whether span should actually be started
Renamed func object to serverMethod internally (less confusion)
No longer dealing with arguments - apply calls changed to call with actual arguments
Collapse consecutive if statements with identical conditions
switch instead of if...else if statement for picking wrap function

Given that 'shouldTrace' sampling was a bugfix (the rest are mostly cosmetic, structure), would it be possible to add a test to make sure we do in fact have functional sampling that we don't regress in the future?

@ofrobots Added a test to show that shouldTrace is being called. Do you think I should also test this for the other hooks?


Move to single-use (symmetric) keys in threads

In the past, we used to do some signing with the thread key-pairs, which required asymmetric encryption (private/public keys). However, we don't need to do this anymore, and we already generate symmetric keys for other uses, which are more efficient. Let's move to using these everywhere.
This is probably a pretty fast change (says the person who probably won't have to do it), and for compatibility, we could do something like: try to unmarshal into ed25519, and if that fails try AES.

We currently use the inline ed25519 keys in which we get a public ID for free (view libp2p-crypto). The inlining won't be relevant anymore since we won't have a public key, but we'll still need a deterministic way to derive a public ID out of these symmetric keys. I think we could just hash and encode it (base58(sha-256)), basically same as before?


Add tutorial byproducts to gitignore

Installing the project in a virtualenv and running through the tutorial produces a number of directories. This change ignores them, as well as Python 3 caches.

Yay! Now I am a contributor.


Add a  or some kind of popup component

It's becoming increasingly obvious that we require some kind of component that would present UI in separate windows. For example, the UI for importing profile data https://github.com/mozilla/tofino/issues/1214 or other general popups.
Ideally such a component could just wrap existing components and everything would still work automagically: redux's connect, dispatching actions etc., just as if a single store is available for all windows.
I don't know if new windows absolutely need to have their own processes. Currently, every single browser window we have has a separate app state etc. because it lives in a separate process. This is not ideal, and will get extremely hairy in the long run where more windows are needed for different purposes or we want to present UI in different windows for some reason.
Someone who writes UI code should not have to think about these issues and the nuances need to be abstracted away. Someone should simply be able to wrap an existing component with a window component and everything still work properly.

Electron's dialog module I think would work for some interactions, but we can also just spawn new BW's with whatever custom window we want. Any changes should be global and each browser chrome BW should receive changes via UAS

Spawning a new browser window would spawn a new process and we'll end up having a different redux store. I don't think that's desirable.


Cookies now always redirects to Login/AccessDenied Paths

This commit broke a pretty nice feature : https://github.com/aspnet/Security/commit/b883920befce4afaac89ec031d30d868a48df666?_pjax=%23js-repo-pjax-container , why was this changed?
I created an angular app which calls my mvc api and if it was not authenticated the cookie authentication automatically returned a 401 and my angular app recognised this so it displayed a login dialog. Now the api call receives a 302 and is redirected to a non existent api call resulting in a 404 and no login dialog :(
This feature was not broken, why was it 'fixed' ?

Yeah, it was broken. That 401 was being sent without a www-authenticate challenge which is invalid.
That said, Cookies shouldn't be used with WebApi anyways. You should be using Bearer or some other non-interactive login.

That's too bad..
Why do you state "cookies should not be used in a webapi anyways"?
I agree that they should not be used for anything that involves retaining state on your api by means of a session or anything, but I am using claimbased authentication which uses cookies to communicate the claims to the server : https://msdn.microsoft.com/en-us/library/ff423674.aspx?f=255&MSPPError=-2147217396 , all microsoft tech, and also designed to be used with api's.
It used to work transparent and out of the box, but this change breaks it.

because of XSRF

Got a point there... :)
Well, I guess I have some work to do then, thanks for your time.


Add Search Filter to otcdocstheme

Proposed Fixes:

check what happens if there is no HC page
Fix following names: Service-Type / Document-Type filter -> Service / Document filter

regate

regate


More FlightSQL endpoints

[ ] do_get_statement

@ahirner i apologize for missing your comment - not sure how I missed it.
This issue is specifically for improving the flight sql server implementation within dft. The client capabilities would be improved through other issues. That being said I think I saw there was a flight sql table provider / factory and I do think it would make sense to include that here. I have been on a brief dft pause for the holidays but I will be getting back into it shortly and can look into it more then.
Depending on the apis they implement in that repo it may be trivial to add this with a table provider factory in case you're interested in trying it out.

Thanks, I thought this issue was about the server.

@ahirner perhaps i misunderstood then - i looked at the example in the link you provided and it seemed to be more about a client implementation (it created a FlightSqlServiceClient whereas the server implementation uses FlightServiceServer).

It's about the server implementation in service.rs. We are using this crate's implementation to run a flightsql server in production.
https://github.com/datafusion-contrib/datafusion-federation/blob/main/datafusion-flight-sql-server/src/service.rs

Ah thanks for that.  I will have to look a little further into it - on the surface it may make sense but the direction im moving with this is to have a much more opinionated / integrated setup (for example with metrics endpoint on the server and using same session context across local client and server to facilitate debugging.
Some parts that are limited to just plugging the session state into their SessionStateProvider may work fine (object stores, table providers, etc) but then that may hinder the local experience ive been working on.

Im also planning / hoping to have a builder pattern in place where any endpoints implementation can be customized by user.


Reported issue #46 on decentraland/editor-sdk7

issue https://github.com/decentraland/editor-sdk7/issues/46

will review this on a Windows machine


Unlicense License?

Hi.
I stumbled across this file, and it seems like a really cool idea to bind chaiscript to ImGui's functions.
I would like to use part of this in a project, however, there's no license information with the code.

I am proposing to you to add the unlicense license to this project. It seem to be the right thing to do. Of course, it's yours, so you do what you want.

@JuJuBoSc I know that this is just one file that you put out-there 3 years ago, but it would be nice to get a response on this question... :wink:

I'm sorry I never seen that PR until now ! I didn't know that would be useful to someone really haha, enjoy it


Add subtree CoM jacobian

Fix https://github.com/stack-of-tasks/pinocchio/issues/839
Add jacobianSubtreeCenterOfMass and associated python bindings.
This function computes the jacobian of the center of mass of
a subtree, as a barycenter of individual body jacobian.

@jcarpent Thanks for the review. I had a look at the way jacobianCenterOfMass was implemented (I guess you are talking about the JacobianCenterOfMassBackwardStep algorithm), but I felt that, since the jacobians of the joints are already computed, the code would be much more readable by reusing them. It's less efficient but I was ready to live with it. I'll probably need some help reimplementing it the other way around...
Since I was only adding one function, with associated unit test and python bindings, I felt this all belonged to one commit. Sorry about the trailing spaces, my IDE actually automatically removes them on file save - and I though it made more sense to leave it that way (in fact I would suggest you remove all trailing spaces from pinocchio and all configure your editors to work that way, it makes the code look cleaner). Do you want me to revert the files to their previous states ?

I'll probably need some help reimplementing it the other way around...

You made the structure, I may provide a proposition. Is it fine for you?

Since I was only adding one function, with associated unit test and python bindings, I felt this all belonged to one commit. Sorry about the trailing spaces, my IDE actually automatically removes them on file save - and I though it made more sense to leave it that way (in fact I would suggest you remove all trailing spaces from pinocchio and all configure your editors to work that way, it makes the code look cleaner). Do you want me to revert the files to their previous states ?

I do understand, and unfortunately, we haven't been serious on this point since the beginning of the project. I would suggest not wasting your time, but next time it would be nice if you can split your work into several pieces.

I will close this PR as #843 offers a better solution.


Compatibility with Rasa NLU >= 0.14.0

Hi,
In Rasa NLU version 0.14.0, released 2019-01-23, the /config endpoint was removed (see https://rasa.com/docs/nlu/changelog/#v0-14-0).
The Rasa UI project readme currently says that Rasa NLU version 0.14.0 is supported, but Rasa UI still attempts to make use of /config.  Rasa NLU returns 404s for the request.  I believe this is resulting in the Rasa UI "input" sidebar's model dropdown not being populated.
Is it actually the case that 0.14.0 and later is not currently supported?
Thank you for your work on this project!
Best,
Brian Schinazi

Yup. This is the case. /config endpoint has been removed and this is now an issue, since we can't load the current project data. At least for me. I'm on 0.14.6.

Hi @schinazi and @joneriktalvio  - if you are still using the project I would suggest checking out the v3 branch.


AOT: Property 'panelOpenState' does not exist on type 'ExpansionPanelComponent'

Bug, feature request, or proposal:
"ng build --env dev --aot" gives error:
Property 'panelOpenState' does not exist on type 'ExpansionPanelComponent'
What is the expected behavior?
Build success
What is the current behavior?
Property 'panelOpenState' does not exist on type 'ExpansionPanelComponent'
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Current package.json:
"dependencies": {
"@angular/animations": "^5.1.3",
"@angular/cdk": "^5.1.1",
"@angular/common": "^5.1.2",
"@angular/compiler": "^5.1.2",
"@angular/core": "^5.1.2",
"@angular/forms": "^5.1.2",
"@angular/http": "^5.1.2",
"@angular/material": "^5.1.1",
"@angular/platform-browser": "^5.1.2",
"@angular/platform-browser-dynamic": "^5.1.2",
"@angular/router": "^5.1.2",
"@auth0/angular-jwt": "^1.0.0-beta.9",
"@ngrx/effects": "^4.1.1",
"@ngrx/entity": "^4.1.1",
"@ngrx/router-store": "^4.1.1",
"@ngrx/store": "^4.1.1",
"bootstrap": "4.0.0-alpha.6",
"core-js": "^2.5.3",
"font-awesome": "^4.7.0",
"lodash": "^4.17.4",
"rxjs": "^5.5.6",
"zone.js": "^0.8.19"
},
"devDependencies": {
"@angular/cli": "^1.6.7",
"@angular/compiler-cli": "^5.1.2",
"@angular/language-service": "^5.1.2",
"@compodoc/compodoc": "^1.0.5",
"@ngrx/store-devtools": "^4.1.1",
"@types/jasmine": "~2.5.53",
"@types/jasminewd2": "~2.0.2",
"@types/node": "^6.0.95",
"angular-in-memory-web-api": "^0.5.2",
"codelyzer": "~3.2.0",
"commitizen": "^2.9.6",
"cz-conventional-changelog": "^2.1.0",
"jasmine-core": "~2.6.2",
"jasmine-spec-reporter": "~4.1.0",
"karma": "~1.7.0",
"karma-chrome-launcher": "~2.1.1",
"karma-cli": "~1.0.1",
"karma-coverage-istanbul-reporter": "^1.3.3",
"karma-jasmine": "^1.1.1",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.1.2",
"ts-node": "~3.2.0",
"tslint": "~5.7.0",
"typescript": "~2.4.2"
},
Is there anything else we should know?

I've clean uninstalled an re-installed cli, material, and cdk.

It seems like the only mention of that property is in one of our examples. Are you sure that it's not something that is missing in your code?

Yep, that was it... @crisbeto many thanks.  This issue can be closed.

@momoadeli Care to share what it was? I am having the same issue...


Add compare/diff options to File explorer context menu

It would be nice to have vscode working as a machine-wide file diff tool. It already has the capability. Just add "Select for Compare" and "Compare with ..." to file explorer context menu, like "Open with Code". Also this should be configurable with settings.

Related- #5770

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


Update pipdeptree which solves issue 5652

Thank you for contributing to Pipenv!
The issue
Fixes #5652
The fix
Upgrades to the new release of pipdeptree
The checklist

[X] Associated issue
[X] A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius tests are failing, and also we are using deprecated functionality:
ests/integration/test_cli.py:137: AssertionError
----------------------------- Captured stdout call -----------------------------
$ pipenv graph --reverse --json

Command failed...
----------------------------- Captured stderr call -----------------------------
Warning: Using both --reverse and --json together is not supported. Please select one of the two options.


[Enhancement] Integrated Cucumber with TestNG support

Hi it would be nice to have cucumber reports separated from TestNG ones if TestNG runner used for Cucumber.
Dependency used
groupId:info.cukes
artifactId:cucumber-testng
version:1.2.4

@GiannisPapadakis thanks for suggestion
I have no idea what are you talking about.

@baev
I am using the dependency described above for running cucumber features with TestNG runner. In @Test methods we can provide one or multiple .feature files. We have a listener that extends  ru.yandex.qatools.allure.testng.AllureTestListener and i can override onTestStart in order to start new TestSuiteStartedEvent (Here the test method behaves as a suite). The problem is that in AllureTestListener executed onStart and reports TestSuiteStartedEvent in the beginning with the name of the test method that runs the cucumber feature. So ideally i would like to configure the listener if running cucumber. Allure supports Cucumber-JUnit and TestNG separately but i would like to configure listener if cucumber runs with TestNG.

I guess you should write your own adaptor for cucumber-testNg
Note: in case you extend ru.yandex.qatools.allure.testng.AllureTestListener you should use the  spi-off classifier for avoid the results duplication.

Ok thanks @baev i will try to implement a new adaptor and let you know

closed due to no response


Reset content-length header

Resets the content-length header after smee removes whitespace from JSON body. Addresses issues #136 and #116.

This is still relevant. Can this PR be merged and a new release created? @JasonEtco @tcbyrd

Just got tripped up by this.
Happy to help with testing or anything else needed to resolve.


HHH-15512 Querying for an entity persisted but not flushed to the database causes the exception 'A collection with cascade="all-delete-orphan" was no longer referenced by the owning entity instance'

https://hibernate.atlassian.net/browse/HHH-15512

When an entity has been persisted but the session has not been flushed and then a query is executed

Shouldn't the execution of the query, since it touches query spaces that have pending flushes, cause a partial flush before the query can execute? This is usually handled by session.autoFlushIfRequired( affectedTableNames );
Maybe I'm missing something, but IMO this fix shouldn't be necessary i.e. I suspect the bug is somewhere else.

yes the method is called but the db has been hit so in the DefaultAutoFlushEventListener the method flushIsReallyNeeded(...) returns false because source.getActionQueue().areTablesToBeUpdated( event.getQuerySpaces() ) returns false.


[Android] Correct the default user agent of network requests

See the discussion https://github.com/facebook/react-native/issues/3138

v


Remove legacy code

https://github.com/stevermeister/ngx-wig/blob/5f271e70fd1e06d411f14ce7b3c80ef0fbeaa79f/projects/ngx-wig/src/lib/ngx-wig.component.ts#L121:L123
This could be removed since IE is no longer supported from Angular itself

@Akxe thanks for the hint!
https://github.com/stevermeister/ngx-wig/pull/165/files


Build broken with non-GNU make

$ git blame mc/Makefile.in
0cc5859c (Axel ... 393) binunits:     ../src/binunits.o
0cc5859c (Axel ... 394)       cp $< $@

This broke non-GNU make (namely FreeBSD (b)make). As far as I can tell, $< being the first prereq in GNU make is amended by only if suffix rules are also at play with bmake. As there are no suffix rules here, $< evaulates to empty, and now the build is broken:
awk -F" " 'BEGIN {OFS=FS; print "Msgno", "Msgtext"; print "-----", "-------"; n = 0}  $2=="us" {print n++, $3}' <../src/mcmessag.rdb | sed 's/{NULL}//g' >mcmsg.rdb
awk -F" " '$2=="us" {print $3}' <../src/mcmenus.rdb  | tr ';' , >mcmnu.rdb
cp  binunits
usage: cp [-R [-H | -L | -P]] [-f | -i | -n] [-alpsvx] source_file target_file
       cp [-R [-H | -L | -P]] [-f | -i | -n] [-alpsvx] source_file ... target_directory
*** Error code 64

Stop.

Additionally, as all Makefiles call make and not $(MAKE) when doing recursion, it's also impossible to build with gmake, since the first recursion will revert back to using system (potentially not GNU) make.

This may or may not be interesting or relevant (I don't understand half of it).

Brilliant, thank you very much!


Fixing broken build

Looks like the api for rsapi has changed since my pr causing this to break so updating.

Code Coverage is 80.8%, details at https://s3.amazonaws.com/rs-code-coverage/rsc/2015-07-01_330_Coverage-80.8.txt (sometimes the URL can take a few minutes to be available)


Add in deprecated aliases

Description
This PR adds in class aliases which are present in the existing codebase.
This is one of those things that we can get rid of in the Next Major.

I noted that I made a mistake here, namespaces not defined, etc, so I want to fix that before merge.

Well, I released the 2.0. Closing, not going to do this.


List all types, modifiers and states, etc.

Get the info from the .scss file

Action Bar: Only components inside
Alert: Types
Button: Types, modifiers, states
Card: Types, states
Card Group: Types
Dropdown: State
Forms: Complex, Types, modifiers, states
Icons: Types
Input Group: Types
List: Types of list item
Pagination: none
Status Indicators: Types, modifier
Table: Modifier
Toggle: Type, States
Toolbar: Only the components inside
Tree: Types of rows, Modifier
Modal: Only components inside

@jeannewalters
Most of the components -the simple ones- can be fitted in the pattern,

Types
Modifiers
States

@xak @joseegm I was looking at these components with states, types and modifiers - how would the right rail work? Would we have a combination of the state, type, modifier for each link in the right rail or would they be radio buttons like Lightning does it?  (https://www.lightningdesignsystem.com/components/accordion/?variant=base)
Based on our last meeting, I thought these links in the right rail would be jump links.
Maybe to determine this, we will need the specific state, type and modifier (and/or combination) for each component - not just what they have as listed below.
Copying @LeoT7508 as part of this too.

@jeannewalters I don't think we can do the Lightning approach for now.
In some instances like Buttons and Cards we are showing most modifications and states, in others like Dropdown we aren't not showing how you open the menu — toggle aria-expanded and aria-hidden attributes OR toggle class is-expanded and is-hidden. See https://github.com/SAP/techne/blob/v2.0/scss/components/dropdown.scss#L40
The Lightning approach is very different, selecting options to generate code and see examples. Bootstrap is better example for showing base and variants in the right rail.

Yes, I was all the time thinking in the Bootstrap variant that Zack linked in the previous post.
That's why we need a "pattern" to structure the documentation. So the right trail will link to the "subheaders" which in correspond to the right types, modifiers, etc.

@jeannewalters
Here is the list of concrete types, modifiers and states for the Button components so you can incorporate a real life example on the wires:

Types: Standard, Text, Link, ActionBarButton, Contextual Menu
Modifiers: With icon, Sizes (small, default, large)
State: normal, selected, disabled

Here is the button page. We can review it all together in the meeting.

@joseegm @LeoT7508 Here is the updated button wire based on feedback from our call earlier today:

@jeannewalters
This looks good. I'll start modifying the Buttons website page to reflect this new structure. That can be done in code.
One small thing, do we need to have the "Usage" headline for every variation? I think with only the description will be fine. And only use "Usage: page1, page2" when linking to the starter pages. What you think?


Faceverification record privacy strategy should be implemented

Options:

hash user zoomid+gdaddress and store in db

used to verify user isnt trying to whielist another address with same whitelisted zoomid
cons: if user lost his wallet we dont have a way to find his old gdAddress and unwhitelist him, could be exploited for fraud.

this could be mitigated if we automatically unwhitelist accounts after some time and require face verification again. so fraud period is limited to the amount of time between re-verifications

pros: very private

keep zoomid in our records

pros: if user looses his wallet we can delete his old account and let him register again
cons: less private as in case of hacking some biometric data might be exposed

BUT very insignificant data can be pulled from server (need to verify with zoom what data that is), probably user image which is already public on his many profiles
we can also keep this record identifier encrypted which could only be accessed via special protocol inside GoodDollar

See attached spec
https://docs.google.com/document/u/2/d/1giGZLjx2GU0nJqium5NLFABPi3-YqRSw-qk9-7yp__U/edit?usp=drive_web&ouid=113040146852067786774


content_keywords有什么用？

通过源码发现，大模型会返回 content_keywords这个属性。但源码中对content_keywords没有存储起来
在检索的时候，也没有用到content_keywords
content_keywords起到什么作用？
===============================================================================
Through the source code, it was found that the large model will return the content_keywords attribute. But the content_keywords are not stored in the source code
When searching, content_keywords were not used either
What is the function of content_keywords?

The content_keywords is a reserved interface, and we haven't developed any functionality based on it yet.


[Feature] Create a filter component for challenge input data types

What product(s) is this feature for?
OpenChallenges
Description

Enable the user to visualize all the input data types that exist
Enable to configure the filter so that only the input data types that are associated to at least one challenge are visible
Enable the user to type keywords in an input field to filter further input data types
The filter component/service generates an array of data types ID (e.g. EDAM concept class id) that can later be used to filter challenges

To discuss: how could we represent the hierarchical relationship between different data types since EDAM support this? Identify the pros and cons (potentially more difficult to implement; less user-friendly?)
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

The first version of the filter could be a list of checkboxes with a input field to filter the concepts. This would be the same implementation as the one we implemented previously and then removed to make room for the EDAM concepts.

Create endpoint to search EDAM concept (#2608)
Create the UI component (this ticket)

@tschaffter It seems the EDAM data concepts fit more into the "Input Data Type" category. Is the operation also part of the "Input Data Type" filter?

For now we are only using "Data" concepts as values for the input data types.


Update README.md

Description:
This Pull Request fixes a grammatical error in the README.md file.
Changes Made:
Fixed some grammatical errors in the README.md
Additional Information:
This fix is not related to any existing issue. It's a minor grammatical error that I noticed while reviewing the README.
Thank you for considering this contribution.

I appreciate the interest in compact_str! Unfortunately at the moment we're receiving an influx of PRs which simply update a few characters of the README. I'm unsure what caused the sudden increase, but given these PRs are relatively low impact, for the time being I'm going to close them under the idea that they're spam.
I sincerely apologize if this PR was opened in good faith, please don't allow this to discourage you from open source contributions in the future!


[BUG] #todo in H1 Title size is inconsistent

When making an H1 title in live Preview, tags have inconsistent sizing.

I'm also having this issue with tags in any level of H titles.
Although I also noticed that this happens with other themes too, I wonder if it's because something has changed behind the scenes with the Live Preview because it started to happen for me after the first Live Preview update.

Hi, thanks for submitting this issue! I just published a new release that should address this bug.
I'll close the issue for now, but feel free to reopen if it's not resolved for you.
Thanks again and thanks for using Things!


demo possibly not working   test_with_openai.py

Windows 10
test_with_openai.py
User_proxy (to chat_manager):

Let's start the game!

--------------------------------------------------------------------------------
Player (to chat_manager):

***** Suggested function Call: get_random_number *****
Arguments:
{}
******************************************************

--------------------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\REPO\autogen\test\test_with_openai.py", line 77, in <module>
  File "C:\REPO\autogen\test\test_with_openai.py", line 73, in test_function_call_groupchat
    user_proxy.initiate_chat(manager, message="Let's start the game!")

snip
api_requestor.py", line 763, in _interpret_response_line
raise self.handle_error_response(
openai.error.InvalidRequestError: Invalid parameter: only messages with role 'assistant' can have a function call.
I tried a few gpt variants. thought I should report

This should have been fixed in the latest version. Could you verify?

Closing this issue due to inactivity. If you have further questions, please open a new issue or join the discussion in AutoGen Discord server: https://discord.com/invite/Yb5gwGVkE5


Mario clips through thin walls

In the Bob-omb Battlefield example, Mario clips one way through the fences. It seems to depend on which way the normals are facing, but if you have a thin object with collision Mario will clip through it even if you have normals facing out on both sides.

Actually, from what I can tell, these meshes don't actually have normas on both sides, the culling mode on them is simply disabled. This isn't because the fences are "too thin", A thin cube mesh would still work properly. Because the meshes are sent to the libsm64 as triangles facing a specific way, "widthless" planes will only have collisions on one side. Maybe I should add a new parameter to the SM64SurfacePropertiesComponent node in order to allow for both side faces collision, since the current behavior is still pretty usefull for one-way surfaces. I'll have to think about a good way to export this to the API.

If you could add that parameter it would be great! I tested having a thin cube mesh and it seems to have the same issue. If you have two one way normals facing out it, it has issues and Mario tends to get stuck in the middle of the two shapes.

Oh now that I've done some more testing I understand, it's not just a matter of (not) having multiple faces. I tried out having a 0.2 meter wide cube and it seems to work until this point (at the default SM64Global.scale), lower than that it kinda stops working.
In all honesty, as far as I can tell this is basically a core limitation of the SM64 engine (and not a code mistake on my part) and as such, my addon is thusly "working as intended", maybe it would be best to just avoid thin walls if you can help it. If you want to stop this from happening in your project you might want to do some custom physics on top of Mario, maybe by having a StaticBody3D move and collide alongside with the Mario node and then dynamically reposition Mario with the SM64Mario.teleport function as the Body collides. It may seem a bit silly but this addon is supposed to expose an 100% accurate simulation of the Super Mario 64 engine, bugs and all.

If you could add the double sided property it might help. I was just trying to replicate the fences from the sm64 because as of right now I am unsure how to go about it.

Unfortunately I've found that double sided property only makes this worse, Mario will now clip no matter how wide it is. I even booted up SM64 to check out the original fences, I'm really not sure how they work exactly, I would have to dig into the decompilation project to seek how the fences work. Maybe it's a combination of planes with a specific Surface Property.

the actual model is different than the collisions in mario 64.

sometimes the actual model is different than the collisions in mario 64. fences have a triangular like collision

here the actual collision

I figured the model wasn't the same, I did use a CC-BY-4.0 recreation of Bob Omb Battlefield, not the actual level extracted from the ROM.
Thanks for the insight! This certainly explains how the fence collision works, it's a boxed wall with a triangular prism on the top. Where did you get this image?
I think I'll close this issue now @Savbyn , I feel like this is proof enough that the reported behavior is the expected one, hopefully now you can recreate the fence how you want. If you want to make the fence have a different collision to the actual model, you can instead make an "collision" mesh for the fence, add it to the libsm64_static_surfaces group and then simply make it invisible. I tried to make my addon be able to use the native Godot Collision Shapes but I'm having trouble figuring out how to break the shapes down to vertices the same way you can do to meshes, since that's the only way to pass the collision shapes to libsm64.

I figured the model wasn't the same, I did use a CC-BY-4.0 recreation of Bob Omb Battlefield, not the actual level extracted from the ROM.
Thanks for the insight! This certainly explains how the fence collision works, it's a boxed wall with a triangular prism on the top. Where did you get this image?
I think I'll close this issue now @Savbyn , I feel like this is proof enough that the reported behavior is the expected one, hopefully now you can recreate the fence how you want. If you want to make the fence have a different collision to the actual model, you can instead make an "collision" mesh for the fence, add it to the libsm64_static_surfaces group and then simply make it invisible. I tried to make my addon be able to use the native Godot Collision Shapes but I'm having trouble figuring out how to break the shapes down to vertices the same way you can do to meshes, since that's the only way to pass the collision shapes to libsm64.

image is from this video: https://youtu.be/kRCjVLqjST4?si=-2eBDigqTt_b2bfL
the tool can be found on this video's description
https://youtu.be/CLNSw11RQCQ?si=arOm7fp-8tV_gCz4