Insecure flag not passed to rclone?

First of all: thanks for building and sharing this project with the rest of the world! I'm trying to use it on a freshly built k3s test "cluster" (single node), but run into some issues. I will create separate issues for each of those. This should make it easier for newbies (like me) to get chorus installed and working.
I'm using two Ceph S3 test clusters for "one" and "two", one being "main". Both of them are configured to use plain HTTP for now. So far I managed to get chorus to replicate the buckets for the users, but no data has been transferred. I have tested with a standalone rclone (my work station) to validate the working of both clusters, credentials, etc. That works. Checking the logs from the worker pods shows that although I have described to use isSecure: false for both storages. My hypotheses is that creating users / buckets is done by chorus itself, but that actual data transfer is done by rclone, and that the isSecure: false flag is not passed to rclone resulting in rclone using (the default?) port 443. If my hypotheses holds true this would be a bug.
Can you prove me wrong?

Hi @hydro-b, thank you for the interest in the project. I am very happy that we can test chorus installation steps on different environments and close gaps in our charts and docs. I'll attempt to replicate any issues on our test environment and will get back to you.

@hydro-b i think you are correct. Project e2e tests are passing with insecure config, because storage address in config contains schema. If address is passed to rclone with schema, then insecure flag is not required.
I will create a fix.
Is your storage config contains schema? If no can you please try with http://?

Thanks for the quick response!

Is your storage config contains schema? If no can you please try with http://?

The storage config I used was not using http://, just the plain ip-address. I have changed that to use http://ip-address-here as well and now it works! \o/
Well, only after pointing it directly to the RGW daemons and not to the HAproxy (ingress) that is in front of it (must be some config issue there). That did give an interesting error message though (although not related to this issue):
{"level":"warn","app_id":"cojomn1f2chs73c6a0j0","app":"worker","task_type":"migrate:object:copy","task_id":"mgr:co:one:two:fliepje01:ceph_volume/__init__.py","task_queue":"migrate_obj_copy1","task_max_retry":25,"task_retried":7,"error":"SerializationError: failed to unmarshal error message\n\tstatus code: 503, request id: , host id: \ncaused by: UnmarshalError: failed to unmarshal error message\n\t00000000  3c 68 74 6d 6c 3e 3c 62  6f 64 79 3e 3c 68 31 3e  |
|\n00000010  35 30 33 20 53 65 72 76  69 63 65 20 55 6e 61 76  |503 Service Unav|\n00000020  61 69 6c 61 62 6c 65 3c  2f 68 31 3e 0a 4e 6f 20  |ailable
.No |\n00000030  73 65 72 76 65 72 20 69  73 20 61 76 61 69 6c 61  |server is availa|\n00000040  62 6c 65 20 74 6f 20 68  61 6e 64 6c 65 20 74 68  |ble to handle th|\n00000050  69 73 20 72 65 71 75 65  73 74 2e 0a 3c 2f 62 6f  |is request..</bo|\n00000060  64 79 3e 3c 2f 68 74 6d  6c 3e 0a                 |dy>.|\n\ncaused by: expected element type <Error> but have ","caller":"/build/service/worker/server.go:169","time":"2024-04-23T10:20:24Z","message":"process task failed. task will be retired"}

Is indeed "retired" meant here? Or is it a typo and should it read "retried"? Just checkin' ;-).

yes, retried 🤣


Invalid procedure call or argument on Intl.DateTimeFormat

If I try to instantiate a Intl.DateTimeFormat with very specific values (see below) I get the above exception.
So far this only happens with these values. Tried others combinations (for dates, times) and they all seems to be working.
This is not locale specific. It happens with any available locale.
new Intl.DateTimeFormat("en-US", {"minute" : "numeric"});
new Intl.DateTimeFormat("en-US", {"minute" : "2-digit"});
new Intl.DateTimeFormat("en-US", {"second" : "numeric"});
new Intl.DateTimeFormat("en-US", {"second" : "2-digit"});

@MSLaguana Microsoft Edge 41.16299.547.0, Microsoft EdgeHTML 16.16299

I don't see that behavior in a more recent version of edge, Microsoft Edge 42.17134.1.0, so this might have been fixed already.

The only thing that I can add is the errorcode (-2146828283). The stacktrace doesn't seems to have anything useful 'TypeError: Invalid procedure call or argument at Global code (file:///D:/Code/ExtremeFX/edge.html:8:3)'

Perhaps an RS3 bug in WinGlob? I don't think we ever report invalid procedure call except for on COM errors. @Microsoft/target-dev FYI, we can also discuss this offline to figure out if we can get a good repro.

Just tested in Microsoft Edge 42.17134.1.0/Microsoft EdgeHTML 17.17134. Same behavior. Please note that I have enabled "Break on all exceptions" on the debugger.

Hmm, even with 'break on all exceptions' I still don't see this. How are you running the code? I was just using the f12 console to type it in, but it looks like you are using some html page; can you provide a complete repro?

Well, yes, but that's not something quite complicated :)
Here you have:
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
	<title>Title</title>
</head>
<body>
	<script>
		new Intl.DateTimeFormat("en-US", {"minute" : "numeric"});
		new Intl.DateTimeFormat("en-US", {"minute" : "2-digit"});
		new Intl.DateTimeFormat("en-US", {"second" : "numeric"});
		new Intl.DateTimeFormat("en-US", {"second" : "2-digit"});
	</script>
</body>
</html>

For what its worth, I am seeing this as working on windows build 17728, though I suspect it will work with any ICU-enabled build of Chakra/Core.

@jackhorton Please confirm this is fixed and close if so.

FWIW, I could repro this on RS4. Not sure if the ask is if this is fixed in RS5 though?

This is fixed in RS5 with the move to ICU


cause onClick to fire twice on parent

I ran into an issue with click handlers and drag handlers being fired twice on a
, and found that it happens when I have <Dropzone> as a child of the
.
Before <Dropzone>:

 console.log("click", e)}>

Clicking the
 results in:

After <Dropzone>:

 console.log("click", e)}>
  <Dropzone className="upload-drop-area"
            activeClassName="upload-drop-area-accept"
            rejectClassName="upload-drop-area-reject"
            multiple={false}
            onDragEnter={this.onDragEnter}
            onDragLeave={this.onDragLeave}
            onDropAccepted={this.onDropAccepted}>
  </Dropzone>

Clicking the
 results in two events:

I've never seen this kind of thing in React before. Any idea what's going on?

A few more observations:

If I replace the <Dropzone> with equivalent content
<input/>
 the problem doesn't exist. Only when I use <Dropzone> does it happen.

The problem happens for onClick but not onMouseOver.

Dropzone handles clicks and it will bubble the event up to its parents.
https://github.com/okonet/react-dropzone/blob/master/src/index.js#L276
You should prevent the event going down the tree in your handler if you want to prevent this behavior.

I'm not sure I understand. Bubbling shouldn't result in multiple events.... you're saying that because Dropzone has an onClick handler that causes two callbacks to fire on the parent?

I think this is the problem:
https://github.com/okonet/react-dropzone/blob/master/src/index.js#L182
You are calling click() on the input from an onClick handler, the input click event bubbles so you end up with two onClick callbacks getting fired.

im not quite sure about the behavior. Can you create an isolated example with a vanilla JS and DOM? We probably should stop propagation as you said. Mind creating a PR?

Sure I'll give this a shot next week.

@okonet Looking into this. Just curious about the workflow (I don't maintan any libraries myself), how do you go about visually testing this? Do you just create a separate project and add react-dropzone as a dependency?

Yes, I'd do something like it. It would be great to get the isolated case in the end if not the PR with a the bug fix.

As far as an isolated case, a fresh project (using create-react-app) with this code:
import React from 'react';
import ReactDOM from 'react-dom';
import Dropzone from "react-dropzone";

ReactDOM.render(

 console.log("click", e)}>
    <Dropzone>

Click me.

    </Dropzone>

,
  document.getElementById('root')
);

Gives this output when you click the dropzone:

Notice the first event target is input and the second event target is div.
If I stop the input event from propagating by modifying Dropzone rendering of the input to this:
<input
  {...inputProps/* expand user provided inputProps first so inputAttributes override them */}
  {...inputAttributes}
  onClick={e => e.stopPropagation()}
/>

Then I just get the single div click as expected. I think this is the right way to handle it, I can't think of any case you'd expect to see the input click event, since this is basically an implementation detail of how Dropzone spawns the browser file picker dialog. I'll add a PR for this change.
As for the drag events firing twice, that does not happen in the above simple test, so I'll have to dig deeper to find out why that was happening in my real app. Maybe nothing to do with Dropzone.

I've tried to add a test but the bug isn't really introducible. This is what I've used:
it('invoke onClick only once', () => {
      const onClickSpy = spy();

      const component = TestUtils.renderIntoDocument(

          <Dropzone>

Click me

          </Dropzone>

      );
      const content = TestUtils.find(component, '#content')[0];
      TestUtils.Simulate.click(content);
      expect(onClickSpy.callCount).toEqual(1);
    });

You need to simulate the click on the inner div (or possibly the inner Dropzone though I'm not sure that's an accurate test since it's not a DOM element.) I couldn't work out how to do it, all my attempts to select the inner element with TestUtils led to invariants about trying to find the wrong thing, or simply gave me 0 results.

No matter where I simulate the click, it only triggers 1 call :/

Hm. Does my original example not exhibit the behavior for you? It could be that simulate click doesn't behave the same (intentionally?) as a real DOM click. It's certainly a weird test case: testing the behavior of a wrapping component when the component under test is put inside it...

I'm trying Enzyme today and will see if I can repro it on JSDom. Ill let you know

i have same issue , but not working yet

It's been fixed in https://github.com/okonet/react-dropzone/releases/tag/v3.8.0. Please upgrade

already upgrade v3.8.0

@pouu69 I'm not sure what you're saying. Is it still reproducible in 3.8?

I am already version 3.8.
but not working click event.
This is the same situation as the above issue.

        <Dropzone
            multiple={false}
            className="block-dropzone"
            disableClick={true}
            accept="image/*"
            ref='dropzone'
            style={styles.dropzone}
            onDrop={this.html5FileHandling}
        >

        </Dropzone>

disableClick={true} will disable the click event on dropzone. I'm not sure what you expect and what's the actual result you're getting so please create a repo where I can reproduce it.

With current fix an IconMenu from MaterialUI stopped working properly as it is not hiding after clicking on a DropZone.
I deeply believe that e.stopPropagation() shouldn't be invoked when disableClick is true.

You're probably right. Can you create a PR with the fix and a test for this please?

I'm having this issue as well, using 3.11.0.

@weisjohn this https://github.com/okonet/react-dropzone/pull/335 should have been fix this issue. If you it's a different issue, please create a new GHI with a minimal root cause. Even better would be a PR that would fix it. Thanks!

I have exactly same issue as aaronbeall who started this thread on Oct 13, 2016, am using 3.11. I have a parent div which contains dropzone. Whenever one of the buttons on the parent div is clicked, the event happens twice. If i remove the dropzone, event is triggered once only.

Just add a pointer-events: none; css-rule on the dropzone DIV dom-node.. that fixed it for me.

That's a bad advice since it will break click to open file dialog functionality AFAIK. Also it seems that it was resolved or is it still happening?

@okonet it does not break click to open file dialog functionality. The bug is still happening, just tried it yesterday on v3.13.1.
I know it sounds way off and ugly with the css-fix, but the alternative for me is that the "open dialog" hit's twice - where the first file selection is dropped.

@LaustAxelsen the reason for me saying this is that I tried it and it broke something for me. I can't remember what was it though.
I think this issue should be fixed in this package. Anyone?

Can someone create a reproducible example?

Same issue here. Newest version. Use dropzone in a semantic-ui project, and the <Dropzone> node triggers 3 times the click event - opens the file dialog - reloads the page.
Behaviour seems consistent across browsers. Use newest release (3.11).
It's obviously an edge case, thus reproducing this bug might headache on its own.
I will try to find the time and make a proper Bug Report and maybe PR.
My current assumption is, this happens when Dropzone has children like input/button/a. Clicking these results in bubbling the event upwards, and for some reason this results in multiple click events. First event handled properly by <Dropzone>, and others bubble further up.

fixed my bug. really obvious, sorry for the noise:
<Dropzone
    multiple={false}
    className="dropzone"
    activeClassName="dropzone-active"
    onDrop={this.onDrop}
    onDragEnter={() => this.setState({ isDragging: true })}
    onDragLeave={() => this.setState({ isDragging: false })}
    ref={(node) => { dropzoneRef = node; }}
    >
        <Button
            onClick={(e) => {
                e.preventDefault(); // --> without this onClick fires 3 times
                dropzoneRef.open();
            }}>
            <Icon name="upload" />Click here
        </Button>
</Dropzone>

I am also getting this same issue. Version 3.13.1. Even with e.preventDefault()

I am also getting this on 3.13.2. I only have text as a child of the Dropzone element.

@okonet https://github.com/kylepotts/react-dropzone-bug-example
Just do the normal npm install npm start. First dropzone will console.log twice. Second dropzone will console.log once.

I've created a bugfix here https://github.com/okonet/react-dropzone/pull/437. It should still respect the onClick event in inputProps if that is set.

I've spent some time on this one today and I still can't reproduce it the way the issue title says. Here is what I tried:

 {
   console.log('parent')
 }}
>
 <Dropzone
   disableClick={false}
   >
 </Dropzone>

This is example code from one of the comments. If you paste it on https://react-dropzone.js.org, depending on disableClick prop being true or false you'll see either a file dialog or parent in the console but not both. I've tried the same code with CRA setup and the behavior was exactly the same. So, if you experience this issue, I still encourage you to create a minimal reproducible example as a GitHub repository and share it with me.
As for @kylepotts example, it's less trivial. I've tested the code you provided at https://react-dropzone.js.org/ and couldn't reproduce the issue with invoking twice. But I could reproduce it when checked out from GH locally! Looking at your example, it seems to be a different from the described here since you don't nest the button element in the Dropzone.
Changing the example to the following (note how I nest a button in dropzone):
let dropzoneRef1;

        <Dropzone ref={(node) => { dropzoneRef1 = node; }} onDrop={(accepted, rejected) => { alert(accepted) }}>

Drop files here.

                 <button type="button" onClick={() => { console.log('this will execute twice'); dropzoneRef1.open() }}>
          Open File Dialog
      </button>
        </Dropzone>

(You can paste it into one of the example's code on https://react-dropzone.js.org/ to test)
This will open the file dialog twice but it will log once. That is expected behavior. Since by default Dropzone will open File Dialog when you click on it. See https://react-dropzone.js.org/#proptypes. If you don't want this behavior, you have to use disableClick prop on it.
@kylepotts I think there is another issue that causes this but I don't understand what it is. I've tried to reproduce it on webpackbin: https://www.webpackbin.com/bins/-Km_p_Qa7aTNt4sn5PxC but it works as expected there. Any idea?

disableClick:false
Chrome - double dialog
Safari - doesn't work
Firefox - ok
disableClick:true
Chrome - ok
Safari - ok
Firefox - doesn't work

@okonet I'm still experiencing this – the "Choose File" dialogue appears twice. If I exit after the first dialogue, no file is uploaded.

I also got the "Choose File" dialog twice, but only if the <input> and the
 have other elements between them (I am using Grommet):

            <input {...getInputProps()} />
            <Box align="center" pad="large">

                Drop an image or click to select a file to upload.

            </Box>

If I modify the above code like this, then I only get one upload dialog:

            <input {...getInputProps()} />
            <Box align="center" pad="large">

                Drop an image or click to select a file to upload.

            </Box>

Could be helpful to open a new issue with a bit of description and a reproducible example because it's hard to figure out from all the comments what the issue is.

Maybe a few more pointers:
I experienced the same issue as here but it only seems to happen in Chrome. Firefox handles it correctly (IMO).
Code to paste on https://react-dropzone.js.org:
import React from 'react';
import {useDropzone} from 'react-dropzone';

function Basic(props) {
  const {acceptedFiles, getRootProps, getInputProps, open} = useDropzone();

  const files = acceptedFiles.map(file => (

      {file.name} - {file.size} bytes

  ));

  return (

        <input {...getInputProps()} />

Drag 'n' drop some files here, or click to select files

        <button onClick={open}>Browse Files</button>

Files

{files}

  );
}

<Basic />

Reproducing:

click on the dropzone: all works well. File dialog only opens once
click on browse files button: FF: all works well. Chrome: file dialog opens twice, and only the second one actually uploads the file

Using e.preventDefault() doesn't help:
<button onClick={(e) => { e.preventDefault(); open(e)}>Browse Files</button>

only removing the onClick handler seems to help and all still works.

Can confirm this issue still persists

Working in an old project and landed with this issue. Someone got that solved?
Like that seems to work:
  const onOpen = useCallback<MouseEventHandler>(
    e => {
      e.preventDefault();
      e.stopPropagation();
      open();
    },
    [open],
  );

Adding in onClick the functions: e.stopPropagation(),  e.preventDefault() and open();  it fixed the issue

it might not be a solution for other developers who commented here.
but in my case I had it this way.

   ...

        <input {...getInputProps()} />

what happens here is that the label links to the closest input child.
and that's why it triggered twice in my case.


enable to add manual labels to help propagation in cases with low contrast (e.g. CSM)

idea is to have the user draw a mask of the cord in slices that would be problematic (e.g. poor contrast), and then modify the input image by adding 0/1 voxels outside/inside the cord.

@jcohenadad in branch bdl_propseg I implemented some code to resolve this issue. Basically, users can provide a mask with some points and the segmentation will be attracted to these points.
Here is an example on sct_example_data/t2 image:
cd sct_example_data/t2
sct_label_utils -i t2.nii.gz -p create -o t2_mask_correction.nii.gz -coord 208,140,14,1:209,140,14,1:210,140,14,1:206,140,15,1:207,140,15,1:208,140,15,1:210,140,15,1:211,140,15,1:212,140,15,1:205,140,16,1:206,140,16,1:212,140,16,1:213,140,16,1:205,140,17,1:213,140,17,1:214,140,17,1:205,140,18,1:214,140,18,1:205,140,19,1:214,140,19,1:215,140,19,1:205,140,20,1:215,140,20,1:216,140,20,1:205,140,21,1:216,140,21,1:217,140,21,1:205,140,22,1:217,140,22,1:205,140,23,1:217,140,23,1:205,140,24,1:217,140,24,1:205,140,25,1:217,140,25,1:205,140,26,1:217,140,26,1:205,140,27,1:217,140,27,1:205,140,28,1:216,140,28,1:217,140,28,1:205,140,29,1:216,140,29,1:205,140,30,1:206,140,30,1:215,140,30,1:216,140,30,1:206,140,31,1:214,140,31,1:215,140,31,1:206,140,32,1:207,140,32,1:213,140,32,1:214,140,32,1:206,140,33,1:207,140,33,1:212,140,33,1:213,140,33,1:206,140,34,1:207,140,34,1:208,140,34,1:211,140,34,1:212,140,34,1:208,140,35,1:209,140,35,1:210,140,35,1:211,140,35,1
sct_propseg -i t2.nii.gz -c t2 -mesh -mask-correction t2_mask_correction.nii.gz
fslview t2.nii.gz t2_seg.nii.gz -l Red -b 0,1 -t 0.7 &

Below are the results on MITKWorkbench. In magenta is the old segmentation, in red are the pixels that were selected for correcting the segmentation and in green the new segmentation.

AWESOME! :+1:


Settings do not apply.

The plug-in setting information works in the default profile, but does not work in the separate profile.
vscode :1.76.2 user setup

I have met the same problem, have you solved it? thanks

I also encountered a similar situation, even if I created the assets folder manually, the pasted images were always saved in the same directory of the markdown file. I use the same configuration in the workspace, user area.

vscode：1.79.1
window10：22h2

Here too!

Potential: Using ctrl + v to paste.
if following works, then that is the problem,

Open the command palette: Ctrl+Shift+P (Cmd+Shift+P on Mac)
Type: "Paste Image" or you can use default keyboard binding: Ctrl+Alt+V (Cmd+Alt+V on Mac).


"zed lake delete" needs a ztest & help text adjustment

While reviewing a revision of the Zed lake design doc as a user, I got the mistaken impression that zed lake delete could be used on commits, not just objects. @mccanne confirmed this is as designed, though.

That behavior is now handled by revert.  delete is still useful (delete individual data objects instead of reverting a commit) and I meant to make a test for it so the issue should just be create a test for delete.

In addition to creating a test, it looks like the help text also needs to be adjusted, since as of Zed commit b2643c2 it still indicates can take "a list of commit tags".
$ zed -version
Version: v0.29.0-493-gb2643c22

$ zed lake delete -h
NAME
    zed lake delete - delete commits or data objects from a pool branch

USAGE
    delete -p pool[@commit] id [id ...]

OPTIONS
    -message commit message
    -p name of pool
    -q quiet mode (default "false")
    -user user name for commit message (default<EMAIL_ADDRESS>
    [lake flags]
    -R URI of path to Zed lake store (default "/Users/phil/logs")

    [zed flags]
    -cpuprofile write cpu profile to given file name
    -h display help (default "false")
    -hidden show hidden options (default "false")
    -memprofile write memory profile to given file name
    -version print version and exit (default "false")

DESCRIPTION
    "zed lake delete" takes a list of commit tags and/or data object tags
    in the specified pool branch and deletes all of the corresponding data
    objects. Once the delete operation completes, the deleted data is no
    longer seen when read data from the pool.

    No data is actually removed from the lake.    Any delete can be "undone"
    by adding the commits back to the log using "zed lake add".

As for the Zed lake design doc, I've already got a branch in progress with some other fixes, so I'll propose the fix to that one.

Completed with https://github.com/brimdata/zed/pull/3216


Push Notification Registration tidy up custom timeout

Describe the solution you'd like
It would be beneficial for app developers to be able to set a custom duration after which the Push Notification registration is tidied up within App Center.
Developers know more about their apps and how they are used than App Center and this arbitrary length of time seems unhelpful
As it currently stands, according to App Center Support "We tidy up registrations upon two criteria, the first one is that your app has not been used in the past 90 days on the device. The second criteria for removing a registration is if the PNS tried to send to the device and received invalid feedback indicating the app has been uninstalled."
Describe alternatives you've considered
I don't see that there is an alternative if your app is only likely to be used once a year for example.
Additional context
Some apps are used on a second by second basis and some are only opened after a long delay or weeks or even months.
Our app may only be opened once per year and then used for an extended period of between a few days up to a few weeks. We need to be able to push notifications in the meantime without fearing that the device has been automatically removed from the system.

@ChrisMGilbert thanks for this suggestion, I'll track it as a feature request. Just to make sure I'm clear, you're talking about the device registration, right? Not a notification.
Since we don't know if a user uninstalls an app, we can't know a device token is invalid until we try to send to it. Since the App Center SDK automatically refreshes the token on startup, that's how we're able to implement the automatic purge (assuming if the user hasn't opened the app, they're not using it).
So what I hear you asking for is the ability to set a flag that says don't delete at 90 days, or the ability to set a expiration date?

the ability to set a flag that says don't delete at 90 days, or the ability to set a expiration date?

Yes exactly this.
Thanks

@ChrisMGilbert I’ll take this into consideration, but I’m not sure its possible - I imagine the platform token will expire before then. If the user may open the app only once a year, then push notifications may not be the right approach.


[Leagues] Add an option to hide quests/music tracks/diaries based on region requirements

QOL thing, would be satisfying to see my quest list completely green!

The Trailblazer league has finished, and I don't think we are going to retroactively add region-based filtering for quests. If ever they announce they will run another Trailblazer league, we may revisit this.

The Trailblazer league has finished, and I don't think we are going to retroactively add region-based filtering for quests. If ever they announce they will run another Trailblazer league, we may revisit this.


Add Ruby 2.5.0 to the build matrix

Because why not, right?

Coverage remained the same at 100.0% when pulling a975d21946da75eb60db6b58d7f3068cf78dfc7a on thedrow:patch-1 into c1d467becef5645e14ff822860f3fc2a9868c066 on dtan4:master.

Coverage remained the same at 100.0% when pulling a975d21946da75eb60db6b58d7f3068cf78dfc7a on thedrow:patch-1 into c1d467becef5645e14ff822860f3fc2a9868c066 on dtan4:master.

Coverage remained the same at 100.0% when pulling a975d21946da75eb60db6b58d7f3068cf78dfc7a on thedrow:patch-1 into c1d467becef5645e14ff822860f3fc2a9868c066 on dtan4:master.

Sorry for missing!
I added the latest Rubies including 2.5.1 to CI platform at https://github.com/dtan4/terraforming/pull/425.
Thank you for submitting a patch.


Make registry key_path evaluation case insensitive

This PR aims to make registry key_path evaluation case insensitive

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


(#27)(#39)(#46)(#45) Rework and update the repository

This is a major rework and update of the files in the repository. This removes ketarin references, switches au to chocolatey-au, and updates the scripts based on updates to the the majkinetor and chocolatey-community/chocolatey-packages repositories.
Fixes #27
Fixes #39
Fixes #45
Fixes #46

@JPRuskin @TheCakeIsNaOH what are we waiting for?
I just about went and started on this work myself, before I saw the PR ;-)

@Jaykul I'm waiting for review on this PR, it should be someone else that approves and merges this (or asks for changes).

@AdmiringWorm have you looked at the appveyor changes?


Enabled RequestResponseChannelCache (CBS, Management channel cache) and ReactorSessionCache by default.

Opting in for the new RequestResponseChannelCache and SessionCache ( “com.azure.core.amqp.cache”) by default
Addressing the Java Doc feedback reported here https://github.com/Azure/azure-sdk-for-java/issues/39084

/azp run java - servicebus - tests

API change check
API changes are not detected in this pull request.


Add Apache 2.0 license

Description
Add Apache 2.0 license to the repo, and an acknowledgement in the README that this fork is based on Jeremy Silver's original work.
Checklist
Please confirm that this pull request has done the following:

[x] Documentation added (where applicable)

Notes

@JeremySilver I can't add you as a reviewer, but I thought I would flag you in this PR in case you had any comments on the acknowledgement or the license. Let me know if you would like any changes.


Unable to launch: GPU process isn't usable

Ubuntu 21.10 with NVIDIA driver 470.63.01 getting the following error:
$ ./lens
info:    ▪ 📟 Setting Lens as protocol client for lens:// +0ms
info:    ▪ 📟 Protocol client register failed ❗ +7ms
info:    ▪ 🚀 Starting Lens from "/opt/Lens/lens" +51ms
info:    ▪ 🐚 Syncing shell environment +0ms
info:    ▪ 💾 Loading stores +48ms
info:    ▪ [KS]: LOADED from /home/wojtek/.config/Lens/lens-user-store.json +17ms
info:    ▪ [GA]: LOADED from /home/wojtek/.config/Lens/lens-cluster-store.json +4ms
info:    ▪ [UU]: LOADED from /home/wojtek/.config/Lens/lens-hotbar-store.json +2ms
info:    ▪ [YT]: LOADED from /home/wojtek/.config/Lens/lens-extensions.json +1ms
info:    ▪ [QC]: LOADED from /home/wojtek/.config/Lens/lens-filesystem-provisioner-store.json +1ms
info:    ▪ [EI]: LOADED from /home/wojtek/.config/Lens/lens-weblink-store.json +3ms
info:    ▪ 🔌 Starting LensProxy +13ms
info:    ▪ [LENS-PROXY]: Proxy server has started at <IP_ADDRESS>:39293 +4ms
info:    ▪ 🔎 Testing LensProxy connection ... +1ms
info:    ▪ ⚡ LensProxy connection OK +92ms
info:    ▪ 🖥  Starting WindowManager +2ms
APPIMAGE env is not defined, current application is not an AppImage
info:    ▪ 🧩 Initializing extensions +22ms
info:    ▪ [EXTENSION-DISCOVERY] loading extensions from /home/wojtek/.config/Lens +1ms
info:    ▪ [EXTENSION-INSTALLER] installing dependencies at /home/wojtek/.config/Lens +82ms
info:    ▪ [EXTENSION-INSTALLER] dependencies installed at /home/wojtek/.config/Lens +475ms
info:    ▪ [EXTENSION-DISCOVERY] watching extension add/remove in /home/wojtek/.k8slens/extensions +1ms
Native extraction module not loaded, msgpackr will still run, but with decreased performance. Cannot find module 'msgpackr-extract'
Lens Cloud Extension activated
info:    ▪ [C]: LOADED from /home/wojtek/.config/Lens/extension-store/lenscloud-lens-extension/auth-token-store.json +48ms
info:    ▪ [C]: LOADED from /home/wojtek/.config/Lens/extension-store/lens-survey/preferences-store.json +2ms
telemetry main extension activated
info:    ▪ [N]: LOADED from /home/wojtek/.config/Lens/extension-store/lens-telemetry/preferences-store.json +35ms
info:    ┏ [IPC-RENDERER]: adding extension listener +75ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'deleteOneCluster',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ┏ [IPC-RENDERER]: adding extension listener +1ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'loadRemoteSpacesClusters',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ┏ [IPC-RENDERER]: adding extension listener +1ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'createOneSpace',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ┏ [IPC-RENDERER]: adding extension listener +0ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'leaveOneSpace',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+17ms
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+4ms
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+0ms
[CLUSTER-CONNECT] cluster proxy started on port 36329
[CLUSTER-CONNECT] cluster proxy is using aes-256-gcm for end-to-end encryption
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+13ms
[14047:0909/093000.192380:FATAL:gpu_data_manager_impl_private.cc(415)] GPU process isn't usable. Goodbye.
Failed to generate minidump.Illegal instruction (core dumped)

Prime Profile

Thats Lens 5.2.x from .deb. The one from snap (4.x) works fine. But it's an older version...

Would you be able to set the following env var's to true and run Lens again from the command line?
ELECTRON_ENABLE_LOGGING

ELECTRON_DEBUG_NOTIFICATIONS

ELECTRON_ENABLE_STACK_DUMPING

@Nokel81
ELECTRON_ENABLE_LOGGING=1 ELECTRON_DEBUG_NOTIFICATIONS=1 ELECTRON_ENABLE_STACK_DUMPING=1 lens
info:    ▪ 📟 Setting Lens as protocol client for lens:// +0ms
info:    ▪ 📟 Protocol client register failed ❗ +7ms
[2594989:0913/154001.164252:ERROR:file_path_watcher_linux.cc(316)] inotify_init() failed: Too many open files (24)
info:    ▪ 🚀 Starting Lens from "/opt/Lens/lens" +53ms
info:    ▪ 🐚 Syncing shell environment +0ms
info:    ▪ 💾 Loading stores +54ms
info:    ▪ [KS]: LOADED from /home/wojtek/.config/Lens/lens-user-store.json +16ms
info:    ▪ [GA]: LOADED from /home/wojtek/.config/Lens/lens-cluster-store.json +3ms
info:    ▪ [UU]: LOADED from /home/wojtek/.config/Lens/lens-hotbar-store.json +2ms
info:    ▪ [YT]: LOADED from /home/wojtek/.config/Lens/lens-extensions.json +2ms
info:    ▪ [QC]: LOADED from /home/wojtek/.config/Lens/lens-filesystem-provisioner-store.json +1ms
info:    ▪ [EI]: LOADED from /home/wojtek/.config/Lens/lens-weblink-store.json +2ms
info:    ▪ 🔌 Starting LensProxy +13ms
info:    ▪ [LENS-PROXY]: Proxy server has started at <IP_ADDRESS>:42907 +2ms
info:    ▪ 🔎 Testing LensProxy connection ... +1ms
info:    ▪ ⚡ LensProxy connection OK +28ms
info:    ▪ 🖥  Starting WindowManager +1ms
APPIMAGE env is not defined, current application is not an AppImage
info:    ▪ 🧩 Initializing extensions +22ms
info:    ▪ [EXTENSION-DISCOVERY] loading extensions from /home/wojtek/.config/Lens +0ms
[2594989:0913/154001.369944:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 1 time(s)
info:    ▪ [EXTENSION-INSTALLER] installing dependencies at /home/wojtek/.config/Lens +99ms
[2594989:0913/154001.576465:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 2 time(s)
[2594989:0913/154001.759962:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 3 time(s)
[2594989:0913/154001.862934:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 4 time(s)
info:    ▪ [EXTENSION-INSTALLER] dependencies installed at /home/wojtek/.config/Lens +475ms
info:    ▪ [EXTENSION-DISCOVERY] watching extension add/remove in /home/wojtek/.k8slens/extensions +1ms
Native extraction module not loaded, msgpackr will still run, but with decreased performance. Cannot find module 'msgpackr-extract'
Lens Cloud Extension activated
info:    ▪ [C]: LOADED from /home/wojtek/.config/Lens/extension-store/lenscloud-lens-extension/auth-token-store.json +42ms
info:    ▪ [C]: LOADED from /home/wojtek/.config/Lens/extension-store/lens-survey/preferences-store.json +1ms
telemetry main extension activated
info:    ▪ [N]: LOADED from /home/wojtek/.config/Lens/extension-store/lens-telemetry/preferences-store.json +31ms
[2594989:0913/154001.968323:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 5 time(s)
info:    ┏ [IPC-RENDERER]: adding extension listener +55ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'deleteOneCluster',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ┏ [IPC-RENDERER]: adding extension listener +2ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'loadRemoteSpacesClusters',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ┏ [IPC-RENDERER]: adding extension listener +0ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'createOneSpace',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ┏ [IPC-RENDERER]: adding extension listener +0ms
info:    ┃ [1] {
info:    ┃ [2]   channel: 'leaveOneSpace',
info:    ┃ [3]   extension: { name: 'lenscloud-lens-extension', version: '5.2.0-latest.20210908.1' }
info:    ┗ [4] }
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+14ms
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+3ms
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+0ms
[CLUSTER-CONNECT] cluster proxy started on port 44063
[CLUSTER-CONNECT] cluster proxy is using aes-256-gcm for end-to-end encryption
info:    ▪ [EXTENSION]: enabled<EMAIL_ADDRESS>+10ms
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: EMFILE: too many open files, watch '/home/wojtek/.k8slens/extensions'
    at FSWatcher.<computed> (internal/fs/watchers.js:218:26)
    at Object.watch (fs.js:1525:34)
    at createFsWatchInstance (/opt/Lens/resources/app.asar/node_modules/chokidar/lib/nodefs-handler.js:119:15)
    at setFsWatchListener (/opt/Lens/resources/app.asar/node_modules/chokidar/lib/nodefs-handler.js:166:15)
    at NodeFsHandler._watchWithNodeFs (/opt/Lens/resources/app.asar/node_modules/chokidar/lib/nodefs-handler.js:331:14)
    at NodeFsHandler._handleDir (/opt/Lens/resources/app.asar/node_modules/chokidar/lib/nodefs-handler.js:559:19)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async NodeFsHandler._addToNodeFs (/opt/Lens/resources/app.asar/node_modules/chokidar/lib/nodefs-handler.js:609:16)
    at async /opt/Lens/resources/app.asar/node_modules/chokidar/index.js:451:21
    at async Promise.all (index 0)
[2594989:0913/154002.073575:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 6 time(s)
[2594989:0913/154002.175730:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 7 time(s)
[2594989:0913/154002.263346:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 8 time(s)
[2594989:0913/154002.355372:WARNING:gpu_process_host.cc(1283)] The GPU process has crashed 9 time(s)
[2594989:0913/154002.355399:FATAL:gpu_data_manager_impl_private.cc(415)] GPU process isn't usable. Goodbye.
Failed to generate minidump.Received signal 4 ILL_ILLOPN 56129abc7818
#0 0x56129d33a3b9 (/opt/Lens/lens+0x43473b8)
  r8:<PHONE_NUMBER>00006c  r9:<PHONE_NUMBER>000000 r10: 0000301b50941deb r11:<PHONE_NUMBER>000293
 r12: 00007f417a43a410 r13: aaaaaaaaaaaaaaaa r14: 00007f417a43a430 r15: 00007f417a43a880
  di: 00005612a118f5b8  si:<PHONE_NUMBER>000000  bp: 00007f417a43a870  bx: 00007f417a43a898
  dx:<PHONE_NUMBER>000001  ax:<PHONE_NUMBER>000000  cx:<PHONE_NUMBER>000000  sp: 00007f417a43a360
  ip: 000056129abc7818 efl:<PHONE_NUMBER>010246 cgf: 002b000000000033 erf:<PHONE_NUMBER>000000
 trp:<PHONE_NUMBER>000006 msk:<PHONE_NUMBER>000000 cr2:<PHONE_NUMBER>000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

seems to work now


Show returns CIRCULAR when nothing actually circular

Running this:
import { Record, Partial, Number, String } from 'runtypes';
import show from 'runtypes/lib/show';

const t = Record({
	x: Number,
}).And(Partial({
	y: Number,
}));

console.log(show(t));

on 4.0.2 returns:
{ x: number; } & { y?: CIRCULAR number; }

Doesn't happen when using for example one Number and one String. Works correctly on 4.0.1.

On a side note, how does one even define a circular type with runtypes?

On a side note, how does one even define a circular type with runtypes?

The Lazy operator permits this:
type Person = { name: string; likes: Person[] };
const Person: Runtype<Person> = Lazy(() => Record({ name: String, likes: Array(Person) }));

Should be fixed in v4.0.3, thanks for the report!

Thank you for the project and for the fast fix :) checked the actual use case, all good.


:seedling: Add url validation to the subfield of image

Signed-off-by: Zhou Hao<EMAIL_ADDRESS>

What this PR does / why we need it:
Verify that the values of Image.URL and Image.Checksum are valid urls.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/test-v1b1-ubuntu-integration

/test-v1b1-ubuntu-integration

/test-v1b1-ubuntu-integration


Header can be sent between the nodes

This pr allows header to be sent between different nodes.

@rogeralsing This pr will reduce about 15%-20% of remote performance. This is mainly due to https://github.com/google/protobuf/blob/31c54d1289f2ae44158eff631526762366ba1707/csharp/src/Google.Protobuf/Collections/MapField.cs#L77
Each RemoteDeliver message will need allocate a new Dictionary and LinkedList for header even if it is null.
This perf drawback does not exist in Go version.
Considering this is necessary to make header/middleware actually working, I think we should just let it be? = )

@PotterDai Would it make a difference if we make the message_header optional in the proto file?

What if we make an intermediate message holding the map, and then have a reference to that message from the envelope?

message MessageEnvelope {
  int32 type_id = 1;
  bytes message_data = 2;
  int32 target = 3;
  actor.PID sender = 4;
  int32 serializer_id = 5;
  MessageHeader header = 6;
}

message MessageHeader {
     map<string, string> message_header = 1;
}

something like that.
(also, never reassign the proto field tags, that breaks all version cmpat.)

@cpx86 @rogeralsing  I ended up with Roger's solution. = )
@rogeralsing  It just worked! Now perf has no drawback. I will fix Go version as well.

Looks good to me!

@rogeralsing  Thx!
Just another question, shall we add ReceiveMiddleware property to Future? In that case, context.RequestAsync can pass its ReceiveMiddleware to Future, and when Future receive response, it can go through that middleware as well.

@PotterDai sounds good, that might ever help diagnose some issues if we can see that there is a future process involved in the message flow.


replace [generate markers] with comments

since the route generations is now independent, we should replace the markers for comments so the generated code is compilable in case someone does not wish to use our plugin to generate their routes.

In order to make the project compilable without the plugin and to maintain the same structure as what is generated, we will need

[ ] a rest() route with a producer in RoutesGenerated
[ ] a consumer route in RoutesImplementation
[ ] a sample api (greeting.yaml in the tests) in generated/api and an interceptFrom in RoutesGenerated


RxGroovy Bootstrap

RxGroovy has been extracted from RxJava prior to 1.0 as per https://github.com/ReactiveX/RxJava/issues/589
I have done this with a simply copy/paste/commit for now. Commit history remains in the 0.20.x branch of RxJava: https://github.com/ReactiveX/RxJava/tree/0.20.x
If anyone wishes to replace the code in this project with files that retain commit history, go ahead and make the changes.
Over the coming weeks the build and release process will be updated.
This project does not need to release immediately as 1.0. It can continue with 0.x releases until it makes sense to hit 1.0. Its lifecycle is now decoupled from RxJava.

Any benefits on replacing the java code with groovy one - e.g. compilation time?
For sure RxJava is the active in development branch so is there any benefit?

I don't understand your question. Can you elaborate please?

This project -if I am correct- has been created and is being updated based on the RxJava one with copy/pastes.
There is still 40% of code in Java. Just asking if it would it make any sense (see benefits) to replace the java code with groovy one. And of course other than the consistency one.


GEOMESA-763,764 Param Swap Fix and BufferedImage scaling

fixed swap of query envelope params
wrote buffered image scaling function
removed imgscalr from pom

Signed-off-by: Andrew Annex<EMAIL_ADDRESS>

Committed as bad231272386bfdbfbed6a814cdc3287391c1527 on f_wcs_4.


Go to top arrow shows when setings is activated

When u open the settings menu and scroll up the go-to top arrow pops up on top of the settings page.

Bug fixed in version 3.0.0 by KeyKoder

Bug fixed in version 3.0.0 by KeyKoder


Revert "Hash file for cache filename"

Reverts dylanaraps/pywal#308

Any plan to return to this? Ended up back here because I ended up having the same issue I originally put up the PR for haha (updated a file with new contents, but pywal's cache had the wrong data).


Upgrade MongoDB backend.

We're still using version 3.0. There are plenty of new improvements on the MongoDB that we can take advantage, like experimenting with the Wired Tiger engine, better memory management etc.

Fix on 2.0.1+


Parallel creation of prefixes from pool result in duplicate error 409

When creating new prefixes from a pool with an automated process that sends bulks of create requests in parallel, some of the queries return error 409. The requests don't specify the IP address for the prefix, they only pass the from-pool argument expecting NIPAP to allocate the next available prefix.
The reason for error 409 is that when 2 processes call the find_free_prefix() in nipap.backend it would return the same prefix for the 2 processes and only 1 of them would proceed successfully with the creation. It could only work if the database would be locked until the create request finishes either successfully or with a failure, so there could be no conflict.
Is this the intended behavior? If so, would a PR even be accepted that would aim to fix this problem?
I couldn't find any related open issues, but please link it here if it already exists.

No, that is not the intended behaviour and I wonder if you are speculating on behaviour or how come you are saying this? What have you observed?
This was designed from the beginning to handle concurrency and we do that https://github.com/SpriteLink/NIPAP/blob/master/nipap/sql/functions.plsql#L474 by wrapping the whole prefix insertion in a loop. We try to insert and if that is successful we return, otherwise we continue spinning in the loop and try again. It is designed exactly to handle this sort of race.
So no, it doesn't require locking, we just retry until we are successful! :)

Thanks for the quick response and for the clarifications. You are right, I'm only speculating, sorry for not being well-prepared with proper debug details. I'm going to post as many as I can, let me check what am I doing wrong.
My observations that my ticket is based on is that when we call add_prefix with "from-pool" in the arguments we end up here:
https://github.com/SpriteLink/NIPAP/blob/master/nipap/nipap/backend.py#L2645
which will look for the next free prefix here:
https://github.com/SpriteLink/NIPAP/blob/master/nipap/nipap/backend.py#L2985
and end up here:
https://github.com/SpriteLink/NIPAP/blob/master/nipap/sql/functions.plsql#L358
My theory was that if 2 processes call this at the same time, it is possible that both of them get the same result from the find_free_prefix function, and only one of them could successfully add the prefix here:
https://github.com/SpriteLink/NIPAP/blob/master/nipap/nipap/backend.py#L2662
Again, please allow me to get proper stacktraces and debug logs, I should've collected them before opening this ticket.
The origin of the problem is that we try to add new prefixes in an automated fashion in a parallelized process (while creating new subnets in a virtual environment) and we occasionally get duplicate error 409 responses. We don't specify the prefix, only the pool name.
I'll get back with better details, I appreciate your time looking into this.

@kkaresz have you been able to look deeper into this?

@garberg I could not look deeper yet. Since we could work around the issue on our client side, the priorities shifted and I could not make time for it. I'll definitely update this thread once I managed to do some debugging. Also, sorry for the late response.


Documentation

Is your feature request related to a problem?
I am following this : https://chillicream.com/docs/hotchocolate/get-started but it's not up to date!
the IDE doesn't even look like that anymore and I don't seem to see the files that I expect to see
The solution you'd like
please update the documentations!
Product
Banana Cake Pop

I have already started to update the guide in #4451, but I'm waiting on another UI Refresh planned for 12.5.0, before finalizing the screenshots. :)

okay great! I also found out your template demo code has different classes than the one in the explanation, just wanted to let you know :)


Datepicker not working

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Datepicker control
What is the current behavior?
Console log error
Uncaught Error: Template parse errors:
Can't bind to 'matDatepicker' since it isn't a known property of 'input'. ("

<mat-form-field>
  <input matInput [ERROR ->][matDatepicker]="picker" placeholder="Choose a date">
  <mat-datepicker-toggle matSuffix [for]="picke"): ng:///AdminModule/ClientComponent.html@43:18
Can't bind to 'htmlFor' since it isn't a known property of 'mat-datepicker-toggle'.
1. If 'mat-datepicker-toggle' is an Angular component and it has 'htmlFor' input, then verify that it is part of this module.
2. If 'mat-datepicker-toggle' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.
3. To allow any property add 'NO_ERRORS_SCHEMA' to the<EMAIL_ADDRESS>of this component. ("t matInput [matDatepicker]="picker" placeholder="Choose a date">
  <mat-datepicker-toggle matSuffix [ERROR ->][for]="picker"></mat-datepicker-toggle>
  <mat-datepicker #picker></mat-datepicker>
</mat-form-field>"): ng:///AdminModule/ClientComponent.html@44:35
'mat-datepicker-toggle' is not a known element:
1. If 'mat-datepicker-toggle' is an Angular component, then verify that it is part of this module.
2. If 'mat-datepicker-toggle' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message. ("
<mat-form-field>
  <input matInput [matDatepicker]="picker" placeholder="Choose a date">
  [ERROR ->]<mat-datepicker-toggle matSuffix [for]="picker"></mat-datepicker-toggle>
  <mat-datepicker #picker></"): ng:///AdminModule/ClientComponent.html@44:2
'mat-datepicker' is not a known element:
1. If 'mat-datepicker' is an Angular component, then verify that it is part of this module.
2. If 'mat-datepicker' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message. ("older="Choose a date">
  <mat-datepicker-toggle matSuffix [for]="picker"></mat-datepicker-toggle>
  [ERROR ->]<mat-datepicker #picker></mat-datepicker>
</mat-form-field>

"): ng:///AdminModule/ClientComponent.html@45:2
    at syntaxError (compiler.js:215)
    at<EMAIL_ADDRESS>(compiler.js:14702)
    at<EMAIL_ADDRESS>(compiler.js:22709)
    at<EMAIL_ADDRESS>(compiler.js:22696)
    at compiler.js:22639
    at Set.forEach (<anonymous>)
    at<EMAIL_ADDRESS>(compiler.js:22639)
    at compiler.js:22549
    at Object.then (compiler.js:206)
    at<EMAIL_ADDRESS>(compiler.js:22548)

What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV

Standard code from https://material.angular.io/components/datepicker/overview is not working
app.module.ts

import { MatDatepickerModule } from "@angular/material/datepicker";

@NgModule({
  declarations: [
    AppComponent,
    DeleteDialogComponent,
  `],`
  imports: [
    AppRoutingModule,
    AuthModule,
    AdminModule,
    HttpClientModule,
    BrowserModule,
    BrowserAnimationsModule,
    MaterialModule,
    FormsModule,
    ReactiveFormsModule,
    MatSnackBarModule,
    MatInputModule,
    MatDialogModule,
 MatDatepickerModule,

html
<mat-form-field>
  <input matInput [matDatepicker]="picker" placeholder="Choose a date">
  <mat-datepicker-toggle matSuffix [for]="picker"></mat-datepicker-toggle>
  <mat-datepicker #picker></mat-datepicker>
</mat-form-field>

What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?

AngularJS: 6.0.5
AngularJS Material: 6.3
OS: Linux elementary
Browsers: Chrome

Is there anything else we should know?

@tomislavplecko, it seems that your are asking for some help with your local config. Material is working fine with Angular (AngularJS is a complete different framework, but I think you've just mistyped it). This chanel works exclusively for bugs/feature requests. https://stackoverflow.com is a much better place to get help with setup, doubts and other things.
BTW, MaterialModule shouldn't be imported. Take a look at the Getting Started Guide.

@julianobrasil thank you for reply.


loss_test.py fails in test_gradient_error

Hello,
When I tried to change the values of t1 and t2 in loss_test.py line 98 (test_gradient_error function)to be:
t1 = 0.5
t2 = 1.0
instead
t1 = 0.5
t2 = 1.5
The test failed.
Here is the ERROR message:
Traceback (most recent call last):
File "/home/tanya/code/loss_test.py", line 123, in test_gradient_error
activations, labels, 0.5, 1.0)
File "/home/tanya/code/bitempered_loss/loss.py", line 174, in _internal_bi_tempered_logistic_loss
beta = 1.0 + one_minus_t1
UnboundLocalError: local variable 'one_minus_t1' referenced before assignment
It looks like the one_minus_t1 is calculated only in case that t2>1.0, and so it fails when t2=1.0 and t1<1.0
Thanks.

This issue should be fixed with the recent changes. Thank you for bringing this to our attention!


Wabbjack Install Of Elysium Giving error

Im getting this error after upgrading to the AE version
00:36:56.996 [FATAL] (Wabbajack.Installer.StandardInstaller) Unable to download Data_Scripts.zip (GameFileSourceDownloader+State|SkyrimSpecialEdition|1.6.1130.0|data\scripts.zip)

I was getting more errors about missing bsa files but now its just this single error

@jgore077 Hey, I see you marked this as completed, did you find a solution? I'm facing the same issue.

Yes I had to install the creation club through steam and after that the error was gone

For whoever else may read this: I needed the anniversary edition DLC, had just SE installed


[BUG] : On click of Reset button on visualization the input field value does not gets reset.

What is the bug?
On click of Reset button on visualization the input field value does not gets reset.
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to Observability/Event Analytics/Explorer page
Select any chart from the chart selector which has  Input field
e.g. bar chart has input field of 'Label Size'
( In Time Series 'Legend Size' and 'Label Size', Gauge has 'Title Size' and 'Value Size' like this etc.)
Give value as 20 for Label Size
click Reset

What is the expected behavior?
Expected Behavior- The Label Size should set to auto
Actual Behavior- The value remains 20 here in panel but the chart gets updated
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

@anirudha @mengweieric
cc : @abasatwar @spattnaik

hi @btzeng  ,
Let us know your thought on keeping this reset button.
Just fyi, we have recently removed preview button.
cc: @spattnaik , @mengweieric @anirudha
Thanks,
Amruta

@btzeng @mengweieric , could you please confirm on this ?

issue solved


The "Send" Button in the Footer Section Should Be Centered

Description
The "Send" button in the footer section is not currently centered, which affects the overall visual balance and consistency of the page design. To improve UI performance and maintain uniformity, the button should be centered within the footer.
Current Behavior

The "Send" button is misaligned and not centered, causing an uneven layout in the footer section.

Expected Behavior

The "Send" button should be horizontally centered within the footer, improving both aesthetics and user experience.

Screenshots

Any additional information?
I hope you're doing well. I am currently contributing as a participant in GSSoC'24 Extended Edition. I'll work on this issue and 'll successfully submit a pull request
What browser are you seeing the problem on?
Chrome
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct
[X] The changes don't break the code
[X] Please attach the screenshots and video of the development work once it is done

Assign this task to me , i will correct up this issue
please assign the task to me

Thank you for your interest @arpit74170  in this issue! However, I have already identified this bug and have a clear solution in mind. Since it's something I'm currently working on as part of my contribution, I’d like to continue with it. I’ll make sure to resolve it promptly and provide a fix soon. Appreciate your understanding!

Assign me this issue

have a look

check it , if it is okay then revert back


Made changing editor_lock/display_folded in code update their value in editor

Previously if you changed display_folded in code this wouldn't be reflected in the editor until reload, same was true for changing editor_lock.
Fixes #21406

Closing as per https://github.com/godotengine/godot/pull/22132#issuecomment-423182589, _change_notify is obsolete and @reduz is working on removing it/replacing it by the better system offered by EditorInspector.


Support of protobuf services

This library generating messages in good format. But no support of generating proto services to python and creating server and client

The library focuses on only one thing--generating the Pydantic Mode code for Message.
grpclib or betterproto that you want?


[Event Request] Codeunit 134 OnBeforeUploadFile

New Publisher needed:
OnBeforeUploadFile in function UploadFile
Signature:
[IntegrationEvent(false, false)]
procedure OnBeforeUploadFile(var IncomingDocumentAttachment: Record "Incoming Document Attachment")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


HTML tab

If you have two elements of frontend i.e., CSS and Javascript, then you should even add HTML.
If you agree to this, i can send the snippets for all the basics of HTML.
Please consider this and give my chance to step into it.
Thank you.

Hey there!
HTML has been discussed in the past and the reality is that there is very little not covered in already existing resources, therefore we will let others who already handle this topic well handle it instead of repeating the very same thing.


Update the i18n dictionary from sling:MessageEntry based to JSON-file based

According to the Sling documentation, loading of JSON-file based dictionaries is much faster than loading the ones based on sling:MessageEntrys and should be used preferably.
Please update the Archetype to generate a JSON-file based dictionary.
Expected Behaviour
The archetype should generate a JSON-file dictionary in the following format:
   /apps/__appsFolderName__/i18n/
           +-- fr.json (nt:file, mix:language)
           |    +-- jcr:language = fr
           |    +-- jcr:content (nt:resource)
           |         + jcr:data

The jcr:data of the file:
{
    "© {0} iZotope Site. All rights reserved.": "© {0} iZotope Site. Tous droits réservés.",
}

Actual Behaviour
The archetype generates a sling:MessageEntry dictionary in the following format:
   /apps/__appsFolderName__/i18n/
           +-- fr (nt:folder, mix:language)
           |    +-- jcr:language = fr
           |    +-- copyright (nt:folder, sling:Message)
           |    |    +-- sling:key = "© {0} iZotope Site. All rights reserved."
           |    |    +-- sling:message = "© {0} iZotope Site. Tous droits réservés."

(CQ-4276179)


add lint task for markdown

https://github.com/open-telemetry/opentelemetry-js-contrib/pull/395#issuecomment-805120282

PR opened, ready for reivew

@obecny can this issue be closed now that the PR is merged?


container delete wizard

show containers, delete them

Requires separating the network reservation from the rest of reservation (done already)
Requires keeping track of workloads per solution/reservation https://github.com/threefoldtech/jumpscaleX_threebot/issues/529

Closing as duplicate of #529


red/magenta issues

This is a continuation of the discussion started in https://codeberg.org/dnkl/foot/pulls/1331
In short, the red and magenta (and at least for me, the red in particular) are a bit hard to read. Not excessively so, but still a bit worse than the other colors.
At least for me, it's perceived as red and magenta almost being a bit blurry.
Relevant comments from the codeberg issue

This theme maybe helpful for colorblind people but it does have some accessibility issues
* the red color (CF1745) fails WCAG AA and AAA against the background (242424)
* the magenta color (D926AC) also fails WCAG AA and AAA against the background (242424)
The lightness values of the colors on the CIELAB color space are also considerably different which makes the perception of colors to be skewed.

https://codeberg.org/dnkl/foot/pulls/1331#issuecomment-891796
and

I personally think this would be a fairly good default theme. I do however agree with @ayushnix that the magenta, and red in particular, are a bit hard to read.
@helene have you considered upping their intensity levels a bit? Or darkening the background?
FWIW, the bright colors appear to be fine.

https://codeberg.org/dnkl/foot/pulls/1331#issuecomment-979642

I've already added a new WCAG-like tester (atm it uses an API but it may be possible to reproduce the algorithm in shell) in colors/wcag.sh.
In short, it programmatically determines contrast ratio to background, with in-script configurable warn and fail thresholds (currently set to the WCAG AAA and AA recommendations respectively).
I'll try and see if I can do anything re the two colors.
Initial impressions are that darkening the background (e.g to 161616) just makes it look worse without significantly impacting contrast, while trying to naively bump luminance up enough ends up leaving no space for a "bright" variant.
I'm sure I'll find something though.

The v4 branch is an attempt at a "rewrite" using Lch as a base instead of HSV.
Here's a preview:

Any opinions @dnkl ?
I've already checked for colorblindness things, and aimed for a 4:1 contrast ratio (slightly lower than "even" WCAG AA, but seems to be alright).
I discovered that the lightness values being "all over the place" is inevitable in this specific use-case, but I think I got it to work and still be "recognizably" starlight.

The red is definitely more readable now! So is the new magenta (and I personally prefer its new shade over the old one).
As for the other colors, I'm fine with the new versions, though I do prefer the old cyan over the new one. Or rather, for me (who suffers no color blindness at all, as far as I know), the old cyan/blue were more easily distinguishable than the new ones). I might also have a slight preference for the old green variant... But all this is something I leave up to you; all colors in v4 are readable (to me).

I will most likely change the cyan, since with my color blindness my ability to differentiate it from the blue is not absent, but conditional. I will make it closer to the old one (more green), though this may require more L and C fiddling.
I'll take a look at the green differences.
Likely over this weekend for both of these.
Once everyone's happy with the new values I'll merge v4 in.

If I release foot today, would you prefer I use v3, or v4 as it is now? I would probably prefer v4 as it is.
As I've already mentioned, I'll do a patch release of foot once v4 is done, but it may not happen immediately.

I would say v3, since it's an actual "finalized" version. I don't like putting my name on exploratory unfinished things.
V3 has been used for almost a year now, so it's generally ok.
If you wanted to have a temporary patch, you could use v3 with v4 reds and magentas (since those are most likely going to stay).

An updated cyan.

About 20 hue points more "green" for both, much more differentiable to me.
If I have no more improvement ideas I'll test drive it for a week or two before release.

New magentas.

In the end they were too close to the blues and cyans if you have protanopia or deuteranopia, after which it took a bit to adjust them otherwise.
Magenta is really the worst color for this, since directly left of it hue-wise is blue (tritanopia) and directly right of it is red...
Because of this, I went the borderline pastel route, so it can be differentiated via luminance.

This has been merged, so I'm closing.
Potential revisit points for v5 would be the red, which has a contrast ratio of 4:1 (which is a bit low, but seems to still be readable to everyone I've asked to check).
Similarly to magenta, it's very non-trivial to make it contrast well while still fitting into sRGB...
Regardless, should be good for the point release @dnkl
If people complain, I could advance the v5 schedule, but IMO this is still a big improvement over the previous versions (which were already much better than most other options I've had the mispleasure of dealing with, maybe besides tango).

P.S. I ported the contrast checker into contrast.sh.
The output looks like this now:

There's an unfortunate bug re: precision loss, since POSIX bc does not support non-integer exponentiation, which means I have to emulate it using e() and l(). The color did not change from the previous iteration, and it is still "truly" 4.0. Values close to target should just be evaluated by a human.
Part of my goals with starlight were also to have a sort of "starting off" point for other people making ANSI themes - basically establishing tooling and generation systems. Just change colors.sh and you just have foot support etc built-in :)

Looks good to me, appreciate your work! PR for foot: https://codeberg.org/dnkl/foot/pulls/1413


CoverFlowView gets out of sync with rapid trigger of SelectedIndex

I've found something that might be a new little bug. I'm using the CoverFlowView to display 3 distinct cards. I also have 3 distinct buttons, one for each card. When I click one of the buttons, the SelectedIndex is changed for the CoverFlowView. The issue arises when I trigger the SelectedIndex very quickly - it appears that the animations get out of sync, that's the best that I can describe it. I've included a link to a screen-recording of this behavior in an iOS Simulator, hopefully that is helpful.
https://i.imgur.com/9bliSWu.mp4
Thanks for the work on this plugin!

nice catch!)

need to think, how to work around it.
Will you be OK with "fade in"/'fade out" animation in case of fast selcetedIndex changes?

https://github.com/AndreiMisiukevich/CardView/issues/286
like this

or we can "ignore" fast taps.

@joshykautz if you want to ignore fast taps, you may observe IsAutoAnimationRunning (it true, then ignore button click)

That sounds like a good option. However, the closest thing to IsAutoAnimationRunning that I see is IsAutoInteractionRunning  - unfortunately I this didn't prevent the bug I was experiencing.

Hi
Are you sure that IsAutoInteractionRunning doesn't help? How do you use it?

Hey there. I wouldn't be so naive as to say that I'm sure, but I wasn't able to access an ** IsAutoInteractionRunning** property. I did resolve my issue by doing something a little hacky.
async void OnButtonClicked(object sender, EventArgs args)
{
     if (!App.isAnimating)
     {
          App.isAnimating = true;
          Carousel.SelectedIndex = 0;
          await Task.Delay(350);
          App.isAnimating = false;
     }
}

Each time the button is pressed to cause the animation, I set a global variable that indicates an animation is in progress. After 350ms (roughly the duration of the animation) the global variable is cleared, and another animation is permitted if the user taps a button again. Works well enough for me 🤷♂

....
if(cover.IsAutoInteractionRunning) // skip
?

Works perfectly - thank you Andrei!

Your new changes handle this perfectly - thank you a ton Andrei!

@joshykautz thanks for the quick feedback :)

This is still an issue on iOS - Rapid swiping on CarouselView makes data go out of sync. This happens if the CarouselView.ItemTemplate contains a StackLayout with BindableLayout.ItemsSource and BindableLayout.ItemTemplateSelector

This is still an issue on iOS - Rapid swiping on CarouselView makes data go out of sync. This happens if the CarouselView.ItemTemplate contains a StackLayout with BindableLayout.ItemsSource and BindableLayout.ItemTemplateSelector

Read attentively. This issue is about CoverFlowView, not CarouselView.
I think you can try to work around your issue by setting IsViewReusingEnabled = false

Okay will create a new issue for CarouselView - I have tried using IsViewReusingEnabled = false but still causes issues on swipe.

We're using the CoverFlowView in our app that we're deploying to a FireTv.  If I set SelectedIndex during the page initialisation or the user navigates too quickly the content fades out and never returns.  I solved the rapid navigation by setting IsAutoNavigatingAnimationEnabled="False", Unfortuntely this doesnt cure the initialisation issue, so we simply dropped it for the time being (so the CoverFlow no longer auto navigates to the users last saved selection).
I haven't spent much time diagnosing the issue, but I suspect that an exception is occuring in CardsView.HardSetAsync/SetAllViews (see code below) which is preventing the reverse animation from actioning.  It could be as simple as putting the animation in a try .. finally, but I think that may bring the UI back in a broken state.
`
//https://github.com/AndreiMisiukevich/CardView/issues/286
protected virtual async Task HardSetAsync()
{
var opacity = Opacity;
var scale = Scale;
var time = 150u;
        await Task.WhenAll(
            this.FadeTo(0, time, Easing.CubicIn),
            this.ScaleTo(.75, time, Easing.CubicIn));
        SetAllViews(true);
        await Task.Delay(10);
        await Task.WhenAll(
            this.FadeTo(opacity, time, Easing.CubicOut),
            this.ScaleTo(scale, time, Easing.CubicOut));
    }

`

We're using the CoverFlowView in our app that we're deploying to a FireTv. If I set SelectedIndex during the page initialisation or the user navigates too quickly the content fades out and never returns. I solved the rapid navigation by setting IsAutoNavigatingAnimationEnabled="False", Unfortuntely this doesnt cure the initialisation issue, so we simply dropped it for the time being (so the CoverFlow no longer auto navigates to the users last saved selection).
I haven't spent much time diagnosing the issue, but I suspect that an exception is occuring in CardsView.HardSetAsync/SetAllViews (see code below) which is preventing the reverse animation from actioning. It could be as simple as putting the animation in a try .. finally, but I think that may bring the UI back in a broken state.

Hmmm, interesting.
Would you like to try override HardSetAsync and perform something like
protected override async Task HardSetAsync()
{

    var opacity = Opacity;
    var scale = Scale;

    try
    {
	    await Task.WhenAny(
	        base.HardSetAsync(),
	        Task.Delay(350));
    }
    finally
    {
        Opacity = opacity;
        Scale = scale;
    }
}

Well, I was completely wrong.  HardSetAsync is being called multiple times the last of which is when the Opacity is set to 0 from a previous call.

Well, I was completely wrong. HardSetAsync is being called multiple times the last of which is when the Opacity is set to 0 from a previous call.

Then we should fix that :)

Try 2.6.5

All good in 2.6.5, thanks for the quick turnaround.
From: Andrei<EMAIL_ADDRESS>Sent: 25 October 2020 22:27
To: AndreiMisiukevich/CardView<EMAIL_ADDRESS>Cc: Stewart Draper<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [AndreiMisiukevich/CardView] CoverFlowView gets out of sync with rapid trigger of SelectedIndex (#313)
Closed #313https://github.com/AndreiMisiukevich/CardView/issues/313.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/AndreiMisiukevich/CardView/issues/313#event-3918297919, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANR7WK6WZQQZHH23TTGNJN3SMSQZXANCNFSM4JPT6TAQ.
Click herehttps://www.mailcontrol.com/sr/SnJrw6UckJDGX2PQPOmvUujshICbHL2sirjvlz29flVfcI0vC0jdBoE-oa52ctCbR3e-F2YuvtwX_sYT9IPN0A== to report this email as spam.

All good in 2.6.5, thanks for the fix and quick turnaround.

Hi Andrei,
We're seeing OOM FireTV client crashes with sustained rapid navigation (either repeated manual taps or by holding down the L/R navigation button.
AppCenter has caught the following stack traces:
<
Stacktrace
mono.java.lang.RunnableImplementor.run(RunnableImplementor.java:30);
Reason
Java.Lang.Error: Failed to allocate a 8294412 byte allocation with 3722960 free bytes and 3MB until OOM

and
<
Stacktrace
crc643f46942d9dd1fff9.Platform_DefaultRenderer.onLayout(Platform_DefaultRenderer.java:72);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc64ee486da937c010f4.FrameRenderer.onLayout(FrameRenderer.java:47);
crc643f46942d9dd1fff9.Platform_DefaultRenderer.onLayout(Platform_DefaultRenderer.java:72);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc64ee486da937c010f4.FrameRenderer.onLayout(FrameRenderer.java:47);
crc643f46942d9dd1fff9.VisualElementRenderer_1.onLayout(VisualElementRenderer_1.java:91);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc643f46942d9dd1fff9.Platform_DefaultRenderer.onLayout(Platform_DefaultRenderer.java:72);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc643f46942d9dd1fff9.Platform_DefaultRenderer.onLayout(Platform_DefaultRenderer.java:72);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc643f46942d9dd1fff9.PageRenderer.onLayout(PageRenderer.java:72);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc64720bb2db43a66fe9.NavigationPageRenderer.onLayout(NavigationPageRenderer.java:65);
com.xamarin.forms.platform.android.FormsViewGroup.measureAndLayout(FormsViewGroup.java:37);
crc643f46942d9dd1fff9.PlatformRenderer.onLayout(PlatformRenderer.java:55);
Reason
Java.Lang.Error: Failed to allocate a 8294412 byte allocation with 3630376 free bytes and 3MB until OOM

I've tried removing the fade/scale in HardSetAsync to see if that's the issue, but that had no effect.
When these occur the app is terminated and the user left at the home page.

I don't think I can fix this issue without a reproduction sample :(
It seems to be a memory leak, right?
Would you like to debug CardsView to find where does it happen (Or maybe it's not related to CardsView at all?)

Hi Andrei,
This looks to be a problem with my code.  I’ve put an image in the CoverFlow.ItemTemplate that’s using a file that’s stored on the device rather than an embedded resource and I suspect that its loading them too fast for the large object heap garbage collector to keep up.  If I take the image off the template it doesn’t have the problem.  I’ll go back to the drawing board and come up with some better memory management.
Thanks for getting back to me (again).
From: Andrei<EMAIL_ADDRESS>Sent: 11 November 2020 22:48
To: AndreiMisiukevich/CardView<EMAIL_ADDRESS>Cc: Stewart Draper<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [AndreiMisiukevich/CardView] CoverFlowView gets out of sync with rapid trigger of SelectedIndex (#313)
I don't think I can fix this issue without a reproduction sample :(
It seems to be a memory leak, right?
Would you like to debug CardsView to find where does it happen (Or maybe it's not related to CardsView at all?)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/AndreiMisiukevich/CardView/issues/313#issuecomment-725703892, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANR7WK4ZZKLIVB72FMTAAOTSPMIB3ANCNFSM4JPT6TAQ.
Click herehttps://www.mailcontrol.com/sr/KxCeCCfW_xvGX2PQPOmvUujshICbHL2sppzLljtigyWzjk45rG0tvPfGNHnq4waG4ESQRA0Ks4MgL4AI7al_HQ== to report this email as spam.

@xariosstewart thanks for letting me know 👍


Office League - PWA - Hash key

Generate hash from graphql request+variables and pass it as parameter
This will allow us to have unique url and will ease up the caching by the service worker

Hashing functions: https://github.com/enonic/lib-text-encoding

The problem is that I would like to do it on client-side.
Do you know what is the reference in JS. I see a lot of mentions of cryptoJS

Ah, of course should be client side.
I think this one is good for crypto.
https://github.com/bitwiseshiftleft/sjcl
But I think it's a bit overkill for this. We don't need it for security,
just for caching. Maybe better a simple sha hashing function without a
whole lib around?
On Wednesday, March 15, 2017, Glenn Ricaud<EMAIL_ADDRESS>wrote:

The problem is that I would like to do it on client-side.
Do you know what is the reference in JS. I see a lot of mentions of
cryptoJS
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/enonic/app-office-league/issues/88#issuecomment-286667795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaSk3unjFyQbn4pxgDGI3a9d-_Q0LDSks5rl5rdgaJpZM4McqUx
.

--
Vennlig hilsen/Best regards
Alex Rodriguez
Senior Developer
+4797100753
https://enonic.com - A web operating system for your sites and applications

I included the sha1 part of CryptoJS in the end. Pretty small (3KB).
And it is under MIT license (Your lib was gpl).
Notice.txt should be updated when done


Added additional README domains

Docs Build status updates of commit 7be8d46:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/concepts/Security-Best-Practices.md
:warning:Warning
View
Details

docs/TOC.md
:white_check_mark:Succeeded
View

docs/create-packages/Package-authoring-best-practices.md
:white_check_mark:Succeeded
View

docs/nuget-org/package-readme-on-nuget-org.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU1703.md
:white_check_mark:Succeeded
View

docs/release-notes/NuGet-5.8.md
:white_check_mark:Succeeded
View

docs/concepts/Security-Best-Practices.md

Line 122, Column 56: [Warning-hard-coded-locale] Link 'https://azure.microsoft.com/en-us/resources/3-ways-to-mitigate-risk-using-private-package-feeds/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


color permissions showing blueish color again

color.#FF7519
should be orange, and its showing blueish in-game
http://www.w3schools.com/tags/ref_colorpicker.asp

Does a message with a color in chat does the same?

other colors work normally, only that value show as blue

Did you add someone to more than one group? I found I made this mistake when I had myself added to two different groups.


shapeit4 vs INFO

Shapeit4 removes certain information from the vcf header. Check how this is handled - can influence the INFO column.
Maybe safer, instead of phasing at the end, phase at the beginning before adding the ancestral allele information.

This is resolved. Phsing genotypes before adding info column.


\cite and \ref autocomplete indexing issues

There is an issue with the \cite, \ref and related commands. I'm not able to isolate it completely, but in my case it seems to relate to using Tikz figures inside floats. When triggering autocomplete using e.g. \cite or \ref, the following error gets thrown:

The related Tikz code is included like this:
\begin{figure}
	\centering
	\input{tikz/boxplotOverallWorkload.tikz}
	\caption{Work load}
	\label{fig:boxplotOverallWorkload}
\end{figure}

I should mention at this point that these Tikz files exist and that my document builds. This occurs when using autocomplete in the "main" file, as well as when being triggered from files that live inside an Include directory which are linked to the main file using %!TEX root comments.
There are two issues with this:

I don't think an error should be reported since the files exist, and, in my opinion LatexTools shouldn't even be interested in the existence of the Tikz files. However, I do understand that files in \input commands in general should be checked.
The alert pops up for every for every "missing" file every time autocomplete is triggered, blocking any other user interaction than clicking the OK button. As autocomplete still works, blocking UI seems an excessive manner of reporting this error.

Furthermore, after 7 files are reported not found, the package throws an error:

(see below for error details)
Lastly, on a related note, consider this piece of code:
\newcommand{\qres}[3]{%
	\begin{figure}[H]
		\centering
		\input{tikz/qresults#1.tikz}
		\caption{#2}
		\label{fig:#3}
	\end{figure}
}

This will actually reported tikz/qresults#1.tikz as missing, showing that the file is being indexed. Anything inside command (re)definitions is not executed at that point and as a result should not be indexed, I suppose.
Error information
Atom Version: 1.7.0-beta0
System: Mac OS X 10.11
Thrown From: latextools package, v0.8.0
Stack Trace
Uncaught TypeError: Cannot read property 'split' of null
At /Volumes/--volumename--/Users/--username--/.atom/packages/latextools/lib/completion-manager.coffee:89

TypeError: Cannot read property 'split' of null
    at CompletionManager.module.exports.CompletionManager.citeComplete (/Volumes/Macbook HD/Users/--username--/.atom/packages/latextools/lib/completion-manager.coffee:111:27)
    at CompletionManager.module.exports.CompletionManager.refCiteComplete (/Volumes/Macbook HD/Users/--username--/.atom/packages/latextools/lib/completion-manager.coffee:49:8)
    at /Volumes/Macbook HD/Users/--username--/.atom/packages/latextools/lib/latextools.coffee:280:28
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1357:25

Commands
     -3:48.5.0 project-manager:list-projects (atom-text-editor.editor.is-focused)
     -3:47.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -3:43.9.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
     -3:37.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  4x -3:22.2.0 core:undo (atom-text-editor.editor.is-focused)
  3x -3:21.3.0 core:redo (atom-text-editor.editor.is-focused)
     -2:47.7.0 settings-view:open (atom-text-editor.editor.is-focused)
     -2:42.4.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  8x -2:12.4.0 editor:newline (atom-text-editor.editor.is-focused)
  8x -2:11.4.0 core:move-up (atom-text-editor.editor.is-focused)
  3x -2:10.3.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:52 core:copy (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "markdown-writer",
      "latex",
      "atom-live-grammar-reload",
      "dev-live-reload",
      "livereload"
    ],
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_Store",
      "._*",
      "Thumbs.db",
      "*.acn",
      "*.acr",
      "*.alg",
      "*.aux",
      "*.bbl",
      "*.blg",
      "*.cb",
      "*.cb2",
      "*.dvi",
      "*.fdb*",
      "*.fls",
      "*.glg",
      "*.glg",
      "*.glo",
      "*.gls",
      "*.gz",
      "*.gz(busy)",
      "*.ist",
      "*.log",
      "*.out",
      "*.sbl",
      "*.sym",
      "*.thm",
      "*.toc"
    ]
  }
}

Installed Packages
# User
git-log, v0.4.1
language-latex, v0.6.1
language-matlab, v0.2.1
latextools, v0.8.0
markdown-scroll-sync, v2.1.2
minimap, v4.21.0
project-manager, v2.7.6

# Dev
language-matlab, v0.2.0

Thanks for this. Its always useful to have such detailed issue reports. A couple of things:

Handling for files without a .tex extension that are \inputed or \included is a bit rough right now. However, if you add ".tikz" to the texFileExtensions setting, the messages for files that do actually exist should disappear.

latextools doesn't care about tikz files per se, but it does care about things you include or input since labels in your final document could be defined there and otherwise, we wouldn't find them.

The modal dialog boxes are annoying. In the (not yet released) master, these have been switched to atom notifications which don't block user interaction and automatically clear themselves. The balance that needs to be struck here is between providing some kind of feedback (especially in the case of typos) versus not interrupting someone's workflow too much.

You're right about probably not including things inside command definitions (\newcommand, \renewcommand, etc.) The way we search for commands, etc. isn't terribly sophisticated, which sometimes has its virtues, but, as in the case of your \qres obviously isn't doing the right thing. Eventually, we will probably do something a bit more sophisticated to try and filter-out or otherwise deal with such constructions.

Again, thanks for the bug report and the helpful suggestions.

Thanks for the swift reply. Adding ".tikz" to the texFileExtensions is a good fix to prevent the modal dialogs from appearing. Looking forward to the update!

@ig0774 In general, I believe that parsing tex files is a bad idea. In my understanding the module should relay on the latex output as much as possible. Otherwise, the module have to implement every peculiarity of tex/latex processing and bugs of this type will appear sooner or later. This is a direct analogy with c/c++ completion, which was not successful until lexical parsing was offloaded to clang (and later gcc versions).


Feature Request: Create a feature to import modules and/or components and web components

Angular architects has their own code to import modules using import(). https://github.com/angular-architects/module-federation-plugin/blob/main/libs/mf-runtime/src/lib/loader/dynamic-federation.ts
You have an example doing something similar for React. https://github.com/module-federation/module-federation-examples/blob/master/advanced-api/dynamic-remotes-runtime-environment-variables/host/src/hooks/useFederatedComponent.js
Would it be possible to generalize what your code uses like how angular architects has? It would be amazing if there was a single library that could leverage the high customization level the advanced mod fed plugin has and provides functions that can create a shared scope, import MFEs and even create web components. This library has everything I want to customize the remoteEntry.js file, but now it needs some helper functions to import these MFEs and share a scope object between them.

Sorry, meant to post this in the @module-federation/webpack repository.


Is it possible to override schema rules in a custom validator?

Hi, I have some rather complex calculations that need to be performed to figure out the min/max for a schema field.  To accomplish this I have to pass some extra info to the custom schema rule (autoform magic on the client, the extendedCustomContext on the server), this part is working.  However, the say max may change based on the result of what goes on in the 'custom' rule function.  I've tried  something like the following:
if (this.value > x.annualSalesLimit) {
                    this.definition.max = x.annualSalesLimit;
                    return "maxNumber";
                }

However, when the validation fails based on the return of 'maxNumber' the [max] value in the error message is whatever it was originally set in the schema.  I can't seem to use a function as 'max' either as I don't get all the context info I need to perform the calculation when it's evaluated.  On the server it has no access to the extendedCustomContext.  On the client, it blows up when using the AutoForm functions (getCurrentDataPlusExtrasForForm",etc) as I think it's causing some sort of circular dependency (maybe autoform is calling max to initialize the form, but then max is calling autoform to get info about the form that's being created)

I will try to support this in an upcoming release by allowing more complex ways of adding invalid keys / messages within a custom function. There is a separate issue for that.