Always use --pic when using GCC on Linux

Solution to #1484 has been decided that we will check for gcc for running on linux and use --pic in those cases by default. We believe this should make for a better experience for users. It might cause some issues but we can address them if they arises.

We decided against this.

Hi Sean, could you explain that decision? I just installed Pony on Ubuntu 16.10 and ran into the exact same problem. I'm thinking about others who like me ran into the same issue but might have just given up -- and leaving with a bad first impression of Pony (ie: it doesn't even compile "helloworld").

Hi @sebastien, I can.
Some Linux distros require --pic, others don't. Building with --pic everywhere would hurt performance on platforms where it isn't required. As such we decided that doing for gcc in general was a bad idea. There are probably better ways to address than the rather blunt instrument of turning on for gcc.

OK, so what about testing for $DISTRIB_ID="Ubuntu" and set the --pic flag accordingly in the build system?

If that consistently works and doesn't cause issues, then yes, that seems
like a reasonable PR.
On Tue, Jun 27, 2017 at 4:29 PM, Sébastien Pierre<EMAIL_ADDRESS>wrote:

OK, so what about testing for $DISTRIB_ID="Ubuntu" and set the --pic flag
accordingly in the build system?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ponylang/ponyc/issues/1811#issuecomment-311475931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAL0PIpS-xKQxrgr_bEnHDgiKGsCNpbsks5sIWZGgaJpZM4M0ufs
.

@sebastien Sorry, I'm a bit lost - where does this DISTRIB_ID come from?

@jemc it is defined in /etc/lsb_release. I am not sure where to add the code, but if it were to be in pony's Makefile, it would look like this:
ifeq ($(shell test -f /etc/lsb-release && grep DISTRIB_ID /etc/lsb-release | cut -d= -f2),Ubuntu)
    BUILD_FLAGS  += --pic
    LINKER_FLAGS += --pic
endif

Am happy to create a pull request if you can point me to which file sets up the build environment variables for the ponyc command.

Curious - is the PIC performance impact measurable? In particular, I wonder if it would make sense to just enabled PIC on x86_64 hardware, where afaik there is no meaningful performance impact.

There's definitely a performance impact. It adds a level of indirection that wouldn't otherwise exist. The higher the load on your system, the more you will feel the impact of that impact.


Automated Package Upgrade

:tada: This PR is included in version 5.0.434 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Preserve localized path prefix

I have an app-wide url structure for localized pages:
/:locale/{rest-of-path}
Unless the user has selected a new language, the locale will always be the same as the previous route. Is there anyway to retain the previous locale part of the route without having to pass the current locale to each component?

Could suggest you supply it with context and use your own Link component instead of next-routes own.
import React from 'react'
import { Link as RoutesLink } from '../routes'
import { CurrentOrganizationContext } from '../lib/withCurrentOrganization'

export default props => (
  <CurrentOrganizationContext.Consumer>
    {currentOrganizationId => (
      <RoutesLink {...props} params={{ organizationId: currentOrganizationId, ...props.params }} />
    )}
  </CurrentOrganizationContext.Consumer>
)


Openfhe: get mulDepth from LWE type

Related to #1145. This is a step towards a generic configuring crypto context pass, as the Lattigo backend also needs one.
Since we have RNS lowering for secret-to-, we can get mulDepth from LWE type.
Still marked as draft as the CKKS RNS lowering has not landed. All tests working when merged with #1176
Several changes

hasMulOp becomes hasRelinOp as we actually does not emit openfhe.mul (implicit relin)
the configure_crypto_context_complex.mlir removed scf.if and used arith.add instead, as

we can not lower correctly through a plaintext scf.if for now
for oblivious if, arith.select also does not have a lowering

Rebased and Marked as ready since #1176 merged.

Oh this one should wait until #1190

Rebased and ready now.


mcustomscrollbar breaks chat inside cross-domain iframe

We planned for www.eternagame.org to (temporarily) load the chat from irc.eternagame.org as an iframe. A bug in the custom scrollbar causes an error when this happens.
There is a patch for this at https://github.com/malihu/malihu-custom-scrollbar-plugin/pull/451, but apparently, the repo is not maintained. Should we fork it and merge in the fix (@omei, I think this would be up to you)? Or should we use a different library? This will be replaced once the rewrite happens anyhow (assuming we use Vue, we should ditch jQuery as a dependency).

Two examples:
https://github.com/noraesae/perfect-scrollbar
https://github.com/idiotWu/smooth-scrollbar

May I patch any of them in? If so, are there any preferences to which?

@guyguy2001 Preferences to which what?

Which library to use

Frankly, what I care about is that it works and it looks ok. :)

Resolved in 3201bac


Guicify ExecutorApiClient

Guicify ExecutorApiClient

Create a singleton of ExecutorApiClient with Guice
Mock it with Mockito in unit tests

I need this because I want to create more test cases in ExecutorManagerTest.java. For example this kind of real-life scenario:

web submits an execution to executor, executor accepts it
executor is restarted
web asks executor for the execution, executor returns an error "Flow does not exist"
web marks the execution as FAILED

So with this change I will be able to mock the executor responses.

Now using the @Singleton annotation.


Adding Signal Subgraph: vertex screening and sparse optimization

Reference Issues/PRs
Fixes #120
What does this implement/fix? Explain your changes.
This adds iterative and non-iterative vertex screening functionality to the package.
Any other comments?

Codecov Report

Merging #304 into master will increase coverage by 0.11%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   88.36%   88.48%   +0.11%
==========================================
  Files          39       42       +3
  Lines        2467     2588     +121
==========================================
+ Hits         2180     2290     +110
- Misses        287      298      +11

Impacted Files
Coverage Δ

graspy/subgraph/__init__.py
100% <100%> (ø)
:arrow_up:

graspy/subgraph/base.py
85% <85%> (ø)

graspy/subgraph/itscreen.py
92.3% <92.3%> (ø)

graspy/subgraph/nonitscreen.py
96.15% <96.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedb18f...b7a7bde. Read the comment docs.

All pass with up to date version of Graspy directory @j1c @bdpedigo

Ok. Im gonna try the code a bit more, but consider it done for the class.

Alright, thanks a lot @j1c
Sorry for the late at night submission

Also the proof notebook is located here

Figured it wouldn't make sense to make an additional PR so I just added the stuff addressing https://github.com/neurodata/graspy/issues/150. There's something wrong with my hard drive right now because I thought I accidentally deleted the notebook, tutorial, etc yesterday, but I redid them today and I know I didn't delete them and now they're deleted. Also new files I make are automatically being deleted so I'm going to add to this PR as soon as possible with all of the files that I will recreate on another computer.

Added fixes to #321 and #324 , not sure how to make two PRs yet

@caseypw need you to move these new commits over to a new branch and make separate PRs

@caseypw closing for now because looks redundant with #349 but correct me if wrong


keybindings not working for me

'.editor':
  'ctrl-cmd-u': 'sftpdeployment:uploadcurrentfile'

I have the above in my keymap.cson but it is not working...what am I missing?

Hi @duncanmapes,
I will take a look.
Thank you for using my package.

me too :(


Add strict option to loaders

fix #2772
enhance #2195

I withdraw the PR being a duplicate of #2601.
Sorry.


Offseason#2 Landing and Post Meta Update

landing page update with featured post splash section - as well as key images for each category as webp
recent posts by category cleanup
you can now add a thumbnail to your post by adding 'thumbnail: filename' to the configuration
note: any new thumbnails are best added as webp for filesize reasons, and only images within assets/theme will be used - lmk and I can throw one together or convert images to webp for ppl as needed
upcoming changes:

latest post splash is going to become a recently posted slideshow, showing the latest 3 posts
will update the thumbnail system to apply a default thumbnail by category in case it is omitted, and to change where it looks for the images so that post-specific thumbnails can go in the post's folder instead of the theme folder
working on individual post indexes for each category

Preview:
Landing Featured Post

Landing Post Categories

Post View

Absolutely impressive, thank you for your work!


chore(package): update got to version 11.0.2

Coverage remained the same at 88.217% when pulling 287484110a9832ef26725e72127320ac12ebeb92 on greenkeeper/got-11.0.2 into 782fb41292615e663843b3323c5f8bfb15381cec on master.

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   86.30%   86.30%
=======================================
  Files           3        3
  Lines         314      314
  Branches       28       28
=======================================
  Hits          271      271
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782fb41...2874841. Read the comment docs.


battery_level vs. usable_battery_level #321

As a first step I added usable_battery_level to positions table and summary page.
Sorry, but I'm not familiar with the Elixir yet and I'm sure there are still things missing (translation, test,?)...

Tests passing on my dev env now.
Here I get:
12:49:44.528 [error] Postgrex.Protocol (#PID<0.1069.0>) disconnected: ** (DBConnection.ConnectionError) owner #PID<0.3853.0> exited

Looks really good! After rerunning the tests everything passes :)

How can you restart the test without commit? Just in case i happens again.

There is a "restart build" button on the Travis page. But I'm not sure if it allows you to do that. Ideally, it shouldn't be required to rerun that often. Some tests are sensitive to timing though and therefore can be flaky.

Excellent. Will merge soon!

Finally it was cold enough for a snowflake. By using usable_battery_level, the projected range is not changing that much with temperature. I think it gives a better degradation overview.

It took a little longer, but I could finally take a closer look at the PR. I made a just few adjustments:

Replaced the existing degradation dashboard with your 'projected range' dashboard
Moved the "(xxx km 100%)" text into a tooltip
Added a test for the snowflake icon

Thanks again! :)

Resolves #321

Will I see the tooltip in iOS Safari?
Most of the time I view it on my phone.

Should work with 3904a18e2406089b50fc2c933cfa9baf5f180704


Cannot play video with android API level 21

HI Brad,
Thanks for your great plugin.
There is a issue with Android API level 21 (Lollipop 5.0). Video can not play with that android version

I've tested with Android Kitkat and It worked great
Please help me check it!
Thank you so much

Is it the videos from the demo? They work for me in the demo with Android
7.0 and emulators running all versions. Do any of the events work in the
demo for you?
On Wed, Jul 26, 2017, 5:33 PM Tuan Nguyen<EMAIL_ADDRESS>wrote:

HI Brad,
Thanks for your great plugin.
There is a issue with Android API level 21 (Lollipop 5.0). Video can not
play with that android version
[image: screenshot_1501108360]
https://user-images.githubusercontent.com/17693275/28646654-b5ea5a88-7217-11e7-8631-625a68125aee.png
I've tested with Android Kitkat and It worked great
Please help me check it!
Thank you so much
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bradmartin/nativescript-videoplayer/issues/81, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFulhLAbiCFbxw3NH6jf8_xBmNMADh00ks5sR77MgaJpZM4OkkpL
.


how can I set dialogMessageTextStyle programmatically

Hi
Thanks for the great library. Can you please help me to set dialogMessageTextStyle programmatically. I have the below
DialogsList dialogsList = view.findViewById(R.id.dialogsList);

Sample:
https://github.com/stfalcon-studio/ChatKit/blob/master/sample/src/main/java/com/stfalcon/chatkit/sample/features/demo/styled/StyledDialogsActivity.java

@qcuong97
Hi basically I want to set app:dialogMessageTextStyle ="bold" programmatically instead of xml. Can you please let me know how can I achieve that. I did not find that in the sample link you shared.

@qcuong97
Hi basically I want to set app:dialogMessageTextStyle ="bold" programmatically instead of xml. Can you please let me know how can I achieve that. I did not find that in the sample link you shared.

i think you be should custom layout


Receive NoMethodError when trying to register new tool

This issue is seen when clicking the 'Update' button for the tool registration process described in step 11 of the "Getting It Running" section of the README.

I tried to resolve the issue by resetting the databases back to a clean state by issuing the command bundle exec rake db:seed in each application directory.  When run in the tp_sample_app directory, it aborted with a messages stating that there was 1 pending migration.
I then ran the command bundle exec rake db:migrate which resulted in the following:
~/workspace/lti/LTI2-Reference/tp_sample_app/db$ bundle exec rake db:migrate
(in /home/tim/workspace/lti/LTI2-Reference/tp_sample_app)
==  CreateLti2TpRegistries: migrating =========================================
-- create_table(:lti2_tp_registrations)
rake aborted!
An error has occurred, this and all later migrations canceled:

SQLite3::SQLException: table "lti2_tp_registrations" already exists: CREATE TABLE "lti2_tp_registrations" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "tenant_key" varchar(255), "tenant_name" varchar(255), "tenant_id" integer, "user_id" varchar(255), "reg_key" varchar(255), "reg_password" varchar(255), "tc_profile_url" varchar(255), "launch_presentation_return_url" varchar(255), "status" varchar(255), "message_type" varchar(255), "tool_consumer_profile_json" text, "tool_profile_json" text, "tool_proxy_json" text, "tool_id" integer, "lti_version" varchar(255), "end_registration_id" varchar(255), "proposed_tool_proxy" text, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) /var/lib/gems/1.9.1/gems/sqlite3-1.3.8/lib/sqlite3/database.rb:91:in `initialize'
/var/lib/gems/1.9.1/gems/sqlite3-1.3.8/lib/sqlite3/database.rb:91:in `new'
/var/lib/gems/1.9.1/gems/sqlite3-1.3.8/lib/sqlite3/database.rb:91:in `prepare'
/var/lib/gems/1.9.1/gems/sqlite3-1.3.8/lib/sqlite3/database.rb:134:in `execute'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/sqlite_adapter.rb:278:in `block in execute'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/abstract_adapter.rb:280:in `block in log'
/var/lib/gems/1.9.1/gems/activesupport-3.2.6/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/abstract_adapter.rb:275:in `log'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/sqlite_adapter.rb:278:in `execute'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/abstract/schema_statements.rb:170:in `create_table'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:466:in `block in method_missing'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:438:in `block in say_with_time'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:438:in `say_with_time'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:458:in `method_missing'
/home/tim/workspace/lti/LTI2-Reference/tp_sample_app/db/migrate/20141020133931_create_lti2_tp_registries.lti2_tp.rb:4:in `change'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:407:in `block (2 levels) in migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:407:in `block in migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:123:in `with_connection'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:389:in `migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:528:in `migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:720:in `block (2 levels) in migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:775:in `call'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:775:in `block in ddl_transaction'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/connection_adapters/abstract/database_statements.rb:192:in `transaction'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/transactions.rb:208:in `transaction'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:775:in `ddl_transaction'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:719:in `block in migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:700:in `each'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:700:in `migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:570:in `up'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/migration.rb:551:in `migrate'
/var/lib/gems/1.9.1/gems/activerecord-3.2.6/lib/active_record/railties/databases.rake:153:in `block (2 levels) in <top (required)>'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

I then renamed the development.sqlite file and reran the migrate command which seemed to work.  Unfortunately, when I tried to register a tool, I saw the following screenshot:

The problem seems to be that there is a pending database migration that needs to be applied to the 'Tool Provider' app.  Unfortunately, simply attempting to do the migration with bundle exec rake db:migrate results in a Sqlite error that states that the lti2_tp_registrations already exists.  Deleting this table allowed the database migration to proceed without error and the application does not then get the error described above when clicking 'Update' in the during the tool registration process.

@tmciver-mhe I'll take a look later in the week.

I have the same problem...

Has any progress been made towards a solution for this?

I have not had time to look into this yet.

I was able to fix the schema migration by fixing the last migration file.  The table and most entries already existed, just the new columns needed to be added.
20141020133931_create_lti2_tp_registries.lti2_tp.rb
# This migration comes from lti2_tp (originally<PHONE_NUMBER>2233)
class CreateLti2TpRegistries < ActiveRecord::Migration
  def change
    add_column :lti2_tp_registrations, :end_registration_id, :string, :after => :lti_version
    add_column :lti2_tp_registrations, :proposed_tool_proxy, :text, :after => :end_registration_id

  end
end

But now the TC throws a 500 server error

NoMethodError (undefined method `disposition=' for #Lti2Tc::DeploymentRequest:0x007fe63a54beb0):

Will try to dig into it more later.

I've been on medical leave (double knee replacement) since January 27th of this year and just coming back on stream in the last couple of weeks.  It looks like there's been activity here during that time.
This repo is supposed to represent LTI2 version 2.0.  LTI2.0 was released without support for 'reregistration'; that is, the ability to use the existing LTI trust relationship to renegotiate and update the ToolProxy (including credentials).  However in this repo's master branch we picked up some tentative work on LTI2.1 with reregistration support.  The 'disposition' parameter was an early approach to signal reregistration.  It is no longer used in the 2.1 reregistration support.  References to 'disposition' and to reregistration support should be able to be commented out to get this branch working.
Alternatively it looks like the branch labeled LTI2.0 in the LTI-Reference is an earlier version without disposition.  This may also satisfy.  But I haven't tried it and would have to reinstall some older RoR versions to get it working.
What I would recommend is the following: there is a much reworked version of all this which includes the real (still unreleased) 2.1 code.  It also contains a much more elegant structure that James Rissler (jrissler) created based on Rails mountable engines.  It is the version we've been using in production for some months now.  I'll migrate that over to this public repo in the next week or so.  However before I release it to LTI2-Reference I'll want to review it with our team to ensure we're not dragging over some proprietary stuff.  So if you can wait for that it might be the best bet.

Thanks John,
Don't know why I didn't try that before but yeah, the LTI2.0 branch seems to work just fine.  Thanks for the response and I hope you're starting to feel better.

+1 @jtibbetts on moving the new model over instead of repairing this one.


ui: Open statement and slow log in new tab

This is a workaround for https://github.com/pingcap/tidb-dashboard/issues/641 to improve UX without changing too many codebase.
However most ideally we should implement page memorization and bring back "Back" again.
Also fixes https://github.com/pingcap/tidb-dashboard/issues/796
Signed-off-by: Breezewish<EMAIL_ADDRESS>

Maybe later we can try to use use-swr to help cache the API response.

how about using react-keep-alive?

how about using react-activation?

Feel free to dig it!


Use tempfile instead of tempdir

tempdir is deprecated in favour of tempfile, and all of the function is available in tempfile 3.0.
In addition, tempdir depends on remove_dir_all, which suffers from a TOCTOU vulnerability in the version tempdir uses.
See https://github.com/XAMPPRocky/remove_dir_all/commit/7247a8b6ee59fc99bbb69ca6b3ca4bfd8c809ead for details on the vulnerability.

@mikedilger Is it possible to get a release with this change in it?

I've pushed a 0.6.1 with all the fixes.
Version 0.7 probably coming soon with upgraded dependencies in incompatible ways.


Fetch modules in parallel

This is all @swankjesse, it just happened to occur on my machine.
Fetches are now actually occurring in parallel, though I don't see any performance difference.

Lemme take over this PR to add the parallelism & IOC!

We went another way with this.


add url check to component unit test

Describe your changes
add url to method and metric unit test
Issue ticket number and link
Closes #154
Checklist before requesting a review

[x] I have performed a self-review of my code

Check the correct box. Does this PR contain:

[ ] Breaking changes
[ ] New functionality
[ ] Major changes
[x] Minor changes
[ ] Bug fixes

[x] Proposed changes are described in the CHANGELOG.md

[ ] CI Tests succeed and look good!

waiting for a fix of #111

Please merge main into this branch!


Fix badge in README.md

Details
Resolution for this which was causing the badge to improperly display at the top of the README.
Checklist

[ ] Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
[ ] CI/CD jobs passed ✔
[ ] Validated SPL logic.
[ ] Validated tags, description, and how to implement.
[ ] Verified references match analytic.

Screenshot of fix:


Issue #50 detect invalid fields

1st commit updates schema to detect condition where both the Validator and the Schema haven't been set and return an error.
2nd commit fixes up the Encoder so that it is more robust when emitting field properties.

@smyrman @rs it's not the prettiest implementation, so feedback as always appreciated. Passing all tests though.

OK need to review failing tests.


Interest in D wrapper and sample apps?

I've translated usrsctp.h and many of the sample programs to D.  Would there be interest in a PR to add those D files to this repo or would it be better to keep those separate?  Let me know what you prefer.

I would prefer to keep them separate, since I'm not sure how to test and maintain them.


ENH: stats: add array API support to combine_pvalues

towards #20544
Adds array API support to combine_pvalues

Just test_monotonicity to go

Ready for review

Happy to tackle the test refactor and native axis argument but would prefer them to be follow ups

Thanks @j-bowhay. Re test-refactor and native axis argument, would you also calculate statistic values and recalculate p-values with metap? E.g. for Stouffer:
options(digits=16)
library(metap)
x = c(0.01, 0.2, 0.3)
sumz(x)

Fine to use default tolerances in xp_assert_close, but I think it will be worth checking out any failures.


docs: generate and update API reference for cala.sh

I think we should only update docs when there is a release - not every commit to main. Is it possible to filter to only execute the action on tagged commits?


Add name to a test steps

Signed-off-by: Ruquan Zhao<EMAIL_ADDRESS>
What type of PR is this?
Add one of the following kinds:
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

   NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/hold

/hold cancel
/ok-to-test

/lgtm
/approve


Error Reading Keybase/private

The app notified me via macOS notification that it was unable to access the /private/ folder and asked that I generate a log and send.  Being a good direction-follower, I did just that.
I appear to still be able to access my /private/ folders.
my log id: ca80d76e6ea43d5dafeb351c

Thanks for being a good KBFS citizen!  @maxtaco @patrickxb, it looks like he timed out trying to get the favorites list from the API server.  From the service log:
99843 2016-07-25T14:20:51.996490 ▶ [DEBU keybase engine.go:66] a841 - RunEngine(FavoriteList) -> ERROR: API network error: doRetry failed, attempts: 6, timeout 11.390625s, last err: context deadline exceeded

Could be a temporary network hiccup or something, but pointing it out in case you want to take a lok.


Build manager binary in a modular way

Why we need this PR

Allow default values for building Golang manager binary using build.sh, and support for other flags.
Changes made

Build manager binary in a modular way

Relates to ECOPROJECT-1972
Test plan

Similar to https://github.com/medik8s/node-maintenance-operator/pull/135

/test ?

/test 4.16-openshift-e2e

/lgtm

/retest

/retest

/cherry-pick release-0.3


feat: [DEV-2351] Add implementation for all DID URL dereferencing parameters

Task linked: DEV-2351 Add implementation for all DID URL dereferencing parameters (paths, queries, fragments) and how each should respond


Update web3 transaction formatter to transaction result formatter

#49

It was done here https://github.com/gnosis/gnosis-py/pull/43
Thanks! 😉


[WIP] Embed popover container directly into window

If merged this PR will (at time of writing, nearly) address:

#11: as we no longer present a view controller, just slap a view in the window
#13: as the popover can be designated to not take focus

There are still a few bits left that need a peek:

Popovers in popovers show the disclosure symbol. This might be deliberate, however worth double checking (see screenshot)
Popovers being presented while using a control seem to immediately disappear (see the "Form Validation" example).

Raising this now to keep branches easier to manage/other folk may finish faster due to IRL commitments on my end.

Nice! I'll check out the PR and do some more testing.

Popovers in popovers show the disclosure symbol

I think this is ok for now. You can always disable it with attributes.accessibility.dismissButtonLabel = nil.

Popovers being presented while using a control seem to immediately disappear

I'll work on this.

Popovers being presented while using a control seem to immediately disappear

Weird, couldn't reproduce, tried on my iPhone and the simulator

Made a couple updates to the form validation. Looks good enough to merge for now. I'll do some more polishing up, then release this in v1.2.0.


react-i18next:: You will need to pass in an i18next instance by using initReactI18next

Hello I have an react-i18next error when I build my project.
I'm using next-i18next & next 13
Here is my dependencies :
"eslint": "8.40.0",
"eslint-config-next": "13.4.2",
"next": "13.4.3",
"next-i18next": "^13.2.2",
"postcss": "8.4.23",
"qs": "^6.11.2",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-icons": "^4.8.0",
"react-player": "^2.12.0",
"react-slick": "^0.29.0",

The issue occur on my page /src/pages/game/[name].jsx
On the top of the page I added this :
const path = useRouter().asPath;
const { t, ready } = useTranslation()
console.log(ready, t('play'), path)

Here is the console logs when I build :
[    ] - info Generating static pages (0/14)react-i18next:: You will need to pass in an i18next instance by using initReactI18next
false play /game/[name]
TypeError: Cannot read properties of undefined (reading 'attributes')
true JOUER /game/game1
true JOUER /game/game2
true JOUER /game/game3
...

Eveything is working in dev.
How can I fix this issue please?
Thank you in advance

useTranslation() should be used only in components (it's a react hook), and not at the top of the page.
btw. make sure you import useTranslation from next-i18next and NOT from react-i18next. https://github.com/i18next/next-i18next#usetranslation

Hello,
I'm using useTranslation() on top of my component. Here is the code
import Image from "next/image";
import ReactPlayer from "react-player";
import Link from "next/link";
import React from "react";
import { useState } from "react";
import { useTranslation } from "next-i18next";
import { serverSideTranslations } from "next-i18next/serverSideTranslations";

const Details = ({ data }) => {
  const { t } = useTranslation("common");
  ....
}

export async function getStaticPaths() {
  const { data } = await api.get("/sites");
  const sites = data.data;

  const paths = sites.map((site) => ({
    params: { name: site.attributes.slug },
  }));

  return { paths, fallback: true };
}

export async function getStaticProps({ locale, params }) {
  const currentLocale = locale;
  const { name } = params;
  ....
  return {
    props: {
      ...(await serverSideTranslations(locale, ["common"])),
      data: pageData,
    },
  };
}

What's wrong @adrai ?

Hello,
I'm using useTranslation() on top of my component. Here is the code
import Image from "next/image";
import ReactPlayer from "react-player";
import Link from "next/link";
import React from "react";
import { useState } from "react";
import { useTranslation } from "next-i18next";
import { serverSideTranslations } from "next-i18next/serverSideTranslations";

const Details = ({ data }) => {
  const { t } = useTranslation("common");
  ....
}

export async function getStaticPaths() {
  const { data } = await api.get("/sites");
  const sites = data.data;

  const paths = sites.map((site) => ({
    params: { name: site.attributes.slug },
  }));

  return { paths, fallback: true };
}

export async function getStaticProps({ locale, params }) {
  const currentLocale = locale;
  const { name } = params;
  ....
  return {
    props: {
      ...(await serverSideTranslations(locale, ["common"])),
      data: pageData,
    },
  };
}

What's wrong @adrai ?

Here is my _app.js
import { Layout } from "@/components/layout";
...
import { appWithTranslation } from 'next-i18next';
import Head from "next/head";
import { useRouter } from 'next/router';

function App({ Component, pageProps }) {
  const router = useRouter();

  return (
    <Layout>
      <Head>
       ....
      </Head>
      <Component {...pageProps} />
    </Layout>
  );
}

export default appWithTranslation(App);

Please create a minimal reproducible example repo.

Please create a minimal reproducible example repo.

https://github.com/ricoxor/i18n-next-build-error

this is only occurring because you've set fallback to true:

So for a non-existing route the serverSideTranslations function is never executed.

Thank you @adrai


Fix ESLint errors, add some docs

Pull Request Description

Fix ESLint errors
Add documentation for some functions with blank documentation

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.
[x] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.

If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 Can we put reformat/fix eslint commits into .git-blame-ignore-revs?

@MrFlashAccount yeah, definitely. although of course we probably want to do that in a follow up PR


Improvements to set content safely

Replace deprecated request-promise-native library with axios
Upgrade to yarn v2
Use post for set family of methods according to v1.8.18 docs (for instance https://etherpad.org/doc/v1.8.18/#index_sethtmlpadid-html)
Sanitize HTML before sending it to Etherpad

Note: make sure to review src/query-etherpad.ts
TODO

test against actual etherpad service

@dialexo I think you committed the .yarn/cache directory.
You might want to add:
# yarn
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

to the .gitignore 😅

@dialexo I think you committed the .yarn/cache directory. You might want to add:
# yarn
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

to the .gitignore sweat_smile

woops, will do that, thanks :facepalm:


Expose peripheral registers when enabling the unstable-pac feature.

Foremost, thanks a ton for your great work!
The HAL cannot cover all use-cases, and at some point users may need to access the registers directly.
This can currently be achieved by enabling the unstable-pac feature and accessing the registers.
Unfortunately, there is currently no way for the user to associate the HAL peripherals with their registers
meaning that they cannot abstract over the peripherals themselves, since the registers are exposed only through the Sealed traits.
I propose exposing the regs values from the Sealed traits when enabling the unstable-pac feature. Just the registers
should be enough, there is no reason to enforce any extra public API requirements like exposing the helper Sealed trait methods
(although I personally would find that very useful as long as the HAL does not make any promises about the compatibility between versions).
Note that this is already the case with some peripherals, like AnyPin that allow exposing their GPIO port through the block method. The best example is perhaps the timer traits and low_level driver.
This allows users to bypass the HAL locally when needed without having to change the external interface of the code.
As an example, I demonstrate one of my recent use cases:
I am using the following DACs through SPI: https://www.rohm.com/products/data-converter/d-a-converters/10bit-d-a/bu22210muv-product.
I need to run 3 SPI daisy-chains with x2 of them in each one and approach ~10khz update rate for each channel.
This is implemented on the STM32H745IIx by using  DMA Streams triggered by a timer and chained DMAMUX requests to trigger SPI DR register writes and synchronized GPIO BSRR register writes for the CS handling.
The implementation, at a high-level, looks like this:
TIM CH1 -> DMA1_CH1 -> SPI1 DR (also triggers DMAMUX's GEN1)
TIM CH2 -> DMA1_CH2 -> SPI1_CS BSRR with proper PIN values to set/reset (also triggers DMAMUX's GEN2)

DMAMUX_GEN1 -> DMA1_CH3 -> SPI2 DR
DMAMUX_GEN1 -> DMA1_CH5 -> SPI3 DR

DMAMUX_GEN2 -> DMA1_CH4 -> SPI2_GPIO BSRR
DMAMUX_GEN2 -> DMA1_CH6 -> SPI3_GPIO BSRR.

This is set up to run in circular mode without interrupts, writing to the DACs is achieved by writing to proper buffer positions
associated with the SPI DR writes.
Assuming that the Dmamux peripheral and Dma requests are exposed through an appropriate driver module, (I am in the process of establishing the API to make an upstream PR), the initialization function could like so:
fn init_dacs<
    Spi1: spi::Instance,
    Spi1Sck: SckPin<Spi1>,
    Spi1Mosi: MosiPin<Spi1>,
    Spi2: spi::Instance,
    Spi2Sck: SckPin<Spi2>,
    Spi2Mosi: MosiPin<Spi2>,
    Spi3: spi::Instance,
    Spi3Sck: SckPin<Spi3>,
    Spi3Mosi: MosiPin<Spi3>,
    Tim: timer::CoreInstance + timer::GeneralInstance4Channel,
    DMAMUX: dmamux::Instance,
>(
    dmamux: DMAMUX,
    tim: Tim,
    chain_1: ChainInfo<impl gpio::Pin, Spi1, Spi1Sck, Spi1Mosi, impl timer::Ch1Dma<Tim>, impl timer::Ch2Dma<Tim>>,
    chain_2: ChainInfo<
        impl gpio::Pin,
        Spi2,
        Spi2Sck,
        Spi2Mosi,
        impl dmamux::GenDma<DMAMUX>,
        impl dmamux::GenDma<DMAMUX>,
    >,
    chain_3: ChainInfo<
        impl gpio::Pin,
        Spi3,
        Spi3Sck,
        Spi3Mosi,
        impl dmamux::GenDma<DMAMUX>,
        impl dmamux::GenDma<DMAMUX>,
    >,
) ;

(taking liberties with the dmamux module)
Unfortunately, I don't use the DMA streams in a conventional manner. Streams driven by peripherals are used to
trigger writes to registers of different peripherals. It does not feel as if that could be cleanly encapsulated in the HAL Api.
The best I can do here, is to drop to the dma::Transfer level and start a circular transfer manually. The problem is that this requires specifying the peripheral register target and specifically that of the SPIs. Unfortunately, their registers are not exposed from the spi::Instance s.
I am forced to drop to the metapac level, but then I lose the type-safety of the above Api, needing to leak the metapac to the public interface of the function and restricting its use. I feel exposing the Sealed traits' registers would be a clean solution to this, easily generalized for other use-cases but still limiting the user so they are encouraged to contribute to the HAL instead.

I was just going to open an issue about this. I have a similar use-case, where I have an ADC which has a dual-SPI-like interface connected to an STM32 SPI in Receive-only-slave mode, plus some unusual DMA configuration.
Previously I was using stm32-rs/stm32h7xx-hal which has fairly comprehensive support for peripheral configuration, but still maybe 10% of my peripherals had some configuration which wasn't supported natively in the HAL. When this situation came up I had a few choices:

Use the HAL peripheral, but after the HAL configures it change a few values in the registers directly.
Copy the HAL peripheral implementation into my project and modify it to work as necessary.
Add support for the feature I needed to upstream, usually after having tested the changes by doing option 1 or 2.

Adding upstream support was preferred but was often way more work, as I'd need to come up with an expansive new general interface for the feature and implement it for all of the supported microcontrollers - not just a specific hack for my specific microcontroller. Often it's not practical for an upstream HAL to support the full breadth of a peripheral's possible configurations, as the implementation and interface would be massive and complex.
Options 1 and 2 would often break when updating the HAL since they relied so much on HAL internals, but they were still very useful and convenient compared to having to create a whole new peripheral from scratch based on just the PAC. embassy-stm32 sealing away its internals makes life more difficult for me.


Add windows node graceful shutdown doc

Description

Issue
https://github.com/kubernetes/enhancements/issues/4802
code PR:
https://github.com/kubernetes/kubernetes/pull/127404

Closes: #

Hi @zylxjtu 👋
Just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ahead of the "Ready for Review" deadline on Tuesday November 19th 2024 18:00 PST.
Thank you!

/approve
Considering that the upstream code has landed.

/lgtm
/hold
in case @jsturtevant wants to re-review

/sig windows
/sig node

/hold cancel


[vulkan] Pop markers before commands flush

The flush call to command buffer resets the mCurrent pointer in VulkanCommands such that popGroupMarker will actually trigger the creation of a new buffer.
Before we flush (and reset the client-side state), we should pop group markers if there is one.
This needs a follow-up where we need to make sure that the pop after flush should never happen.

Is this a fix for #6192 or #6292 ??

#6192 actually.  I'll update the RELEASE_NOTES.md

Abandoning PR to do a different workaround


Section 1.10 unnecessary instruction

In the Getting Started With Saving part of section 1.10 it looks like the last code example and the preceding instruction above are not necessary as they are actually covered in the first code example and it's preceding instruction.

Good catch, thanks! I'll be uploading a fixed version shortly.


Bottom sheet inside scroll view

Content not scroll inside bottom sheet when we put bottom sheet inside scroll view.

Hi,
can you please provide a code example? 😄
Anyway you can try something like if it fits with your use case:
<View>
   <ScrollView>
     // Your scrollable content
   </ScrollView>
   <BottomSheet>
     // Your bottom sheet content
   </BottomSheet>
</View>


Launching st and specifying name

Hello,
I am trying to launch st with the -n option. To be more specific: st -n <somename> -e nvim and here is the result:

I don't have any problem without specifying the name. I would also like to add that the font is not the right one, the one specified in my Xresources.
I don't know if it's relevant to the problem, but I have this message when executing the command:
erresc: unknown csi ESC[22;0;0t
erresc: unknown csi ESC]11

I also tested with the "official" st and I didn't face any problem when specifying the name (-n).
Thank you very much in advance for your help.

Does this happen with any other tui programs? It might be some vim plugin interacting with st. I don't have any issue like this with nvim.

Thank you for your quick response. I think I found the problem. In my init.vim config, I had the gruvbox plugin and the airline plugin. When disabling them both, not juste one, the problem is resolved. For the moment I am unable to see the source of the problem.
Thank you very much for your help.

Okay. I'm going to close this issue. Yeah, vim plugins interact in very strange ways I find. I have a couple of glitches due to them.

Thank you for your time and help.


Can a parameter be used as a domain boundary?

Hi,
While modeling a heat exchanger thanks to this (amazing) package, I tried to use a parameter as a boundary of the domain I am discretizing on.
The reason being that later on I could more easily do parametric study of the length of said heat exchanger by simply swapping the parameter without having to discretize again.
However, when I try to do something like:
domains = [t ∈ Interval(0.0, 1.0),
x ∈ Interval(0.0, L)]

I get the error
ERROR: TypeError: non-boolean (Num) used in boolean context

When trying to perform symbolic_discretize on the PDESystem
Is there any workaround? Is it something doable in the first place?
Thanks

Unfortunately this straight up will not work, until the generated ODEFunction is size invariant. Generated functions are not currently invariant under domain size so there is no way to get this to work outside of re-discretizing every time L changes

I'm afraid that'd be what I recommend, best of luck! Could you consider posting your model when you get it running so I can add a tutorial for this?

Thanks!
I will share a simplified version if I end up doing that, absolutely


Add an initial round of tests

Currently we only have a placeholder test.
Test for cellfinder-napari should focus on UI testing and workflow testing (actual computations done and tested in cellfinder-core)
Workshop of 19th January by napari devs should give us some additional guidance/tips to write tests.
Still need to decide on what exactly test contents will be.

A possible strategy for initial round tests
Given that we should trust that napari widgets work as expected and cellfinder-core works as expected (and if not, we should raise an issue there!), the aspects of cellfinder-napari that need testing are (at least as an initial step):

user inputs are validated correctly and expected error messages are thrown (#37 )
progress bars show correctly and reaches end (e.g. #38 )
maybe an integration test with some example data (~ check that hitting run on cellfinder-napari with the default parameters gives the same result as calling cellfinder-core itself with the same data and parameters)

@paddyroddy @dpshelio @adamltyson feedback on the above appreciated. What did I forget?

Dare I say, some unit tests? I know it's less critical but probably worth the effort

Sure, what kind of things would said unit tests be testing? I guess some of the helper functions we already have (and we'll probably create more)?

yeah just test each function is doing what we expect. Usual stuff 🤷

https://napari.org/plugins/test_deploy.html is a useful resource for writing tests for plugins


Moved corporate-staff-rostering member infrastructure from mp repo

A reference to the issue / Description of it
#5926
How does this PR fix the problem?
Member infrastructure code moved from mp repo to corporate-staff-rostering environment

@Khatraf Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

@Khatraf Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

@Khatraf Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform


feat(amplify-graphql-types-generator): improve error message when graphql.parse fails.

Fixes issue #1967
Description of changes:

Wrapped graphql.parse with a try catch block to output a more helpful error message to the user
Added a test for the behavior

When given a file with invalid graphql queries it will output :
Could not parse graphql operations in path/to/file/invalid-gqlQueries.js
Syntax Error: Unexpected Name "world"
query : world and other words

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hey @rakannimer
I added some changes so the spinner doesn't fail and print the stack trace. I submitted the pr on your branch.
https://github.com/rakannimer/amplify-cli/pull/1