tog-crowdsourcing: Add backoff to api retries, support US E, W icons

… icons

I'll fix the build when i have time in the next day or so


HTTP/2

Does it support HTTP/2 now? If not, when?
const server = http2.createSecureServer({
  key: fs.readFileSync('server.key'),
  cert: fs.readFileSync('server.crt')
}, app);

error TS2345: Argument of type 'Express' is not assignable to parameter of type '(request: Http2ServerRequest, response: Http2ServerResponse) => void'.
  Types of parameters 'req' and 'request' are incompatible.
    Type 'Http2ServerRequest' is not assignable to type 'IncomingMessage | Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>'.
      Type 'Http2ServerRequest' is missing the following properties from type 'Request<ParamsDictionary, any, any, ParsedQs, Record<string, any>>': get, header, accepts, acceptsCharsets, and 26 more.

18 }, app);

Hello, and sorry for your issue. The TypeScript definitions are not kept in this repository, instead they are maintained at the https://github.com/DefinitelyTyped/DefinitelyTyped project. If you are having an error with typings, you'll need to open an issue or make a pull request there for the express typings.
As for using it with express, it is possible, though there are still issues with the Node.js compatibility API you may run in to. The Node.js project has a list of them at https://github.com/nodejs/node/issues/29829 . I hope this helps!


Filesystem.listenFile causes loop to crash and be causes loop to be unable to be uninstalled

    await filesystem.listenFile(
      '/Users/michaellatman/Desktop/lol.txt',
      event => {
        console.info('Received Event', event);
      }
    );

The loop stops working, and changing the code to remove the filesystem does not fix the issue until you can reinstall the loop from scratch.
{"level":"info","system":"authenticated application","system":"secureloops","loopID":"3c3dae7a-fa35-47ac-96f4-9ebbf1cee8dc","time":"2021-05-06T13:25:29-04:00","message":"loop stopped"}
{"level":"trace","system":"authenticated application","service":"clipboard","method":"listen","session":{"loopId":"3c3dae7a-fa35-47ac-96f4-9ebbf1cee8dc"},"requestID":"83e4f98d","runtime":11419.554645,"time":"2021-05-06T13:25:29-04:00","message":"end message loop => internal"}
{"level":"trace","system":"authenticated application","service":"filesystem","method":"listenFile","session":{"loopId":"3c3dae7a-fa35-47ac-96f4-9ebbf1cee8dc"},"requestID":"36d9ff45","time":"2021-05-06T13:25:29-04:00","message":"start message loop => internal"}
{"level":"trace","system":"analytics","event":{"documentEncoding":"","documentHostname":"","documentLocationUrl":"","documentPath":"","screenColorDepth":"","screenResolution":"","userAgent":"","userLanguage":"","viewportSize":"","action":"UI Event Handlers","category":"Errors","label":"failed to restart secure loop: failed to start loop: failed to create session: token already exists"},"time":"2021-05-06T13:25:41-04:00","message":"Sending event"}
{"level":"trace","system":"analytics","routineGroup":"internal/analytics.manager.Run","routine":"track event.27","status":"starting","time":"2021-05-06T13:25:41-04:00","message":"routine transition"}
{"level":"trace","system":"analytics","routineGroup":"internal/analytics.manager.Run","routine":"track event.27","status":"started","time":"2021-05-06T13:25:41-04:00","message":"routine transition"}
{"level":"trace","system":"analytics","routineGroup":"internal/analytics.manager.Run","routine":"track event.27","status":"stopping","time":"2021-05-06T13:25:42-04:00","message":"routine transition"}
{"level":"trace","system":"analytics","routineGroup":"internal/analytics.manager.Run","routine":"track event.27","status":"stopped","time":"2021-05-06T13:25:42-04:00","message":"routine transition"}
{"level":"debug","system":"authentication","addressSidekickAPI":"https://sidekick.oliveai.com/api","time":"2021-05-06T13:25:54-04:00","message":"Performing user HTTP request"}
{"level":"debug","system":"authentication","StatusCode":200,"time":"2021-05-06T13:25:54-04:00","message":"Auth response"}
{"level":"debug","system":"authenticated application","approved":true,"loop ID":"5fcaa196f7b08f0714b478f6","loop parent status":"approved","loop status":"approved","loop version":"42","user domain":"oliveai.com","time":"2021-05-06T13:25:54-04:00","message":"loop library status"}
{"level":"trace","system":"analytics","event":{"documentEncoding":"","documentHostname":"","documentLocationUrl":"","documentPath":"","screenColorDepth":"","screenResolution":"","userAgent":"","userLanguage":"","viewportSize":"","action":"UI Event Handlers","category":"Errors","label":"failed to restart secure loop: failed to start loop: failed to create session: token already exists"},"time":"2021-05-06T13:25:59-04:00","message":"Sending event"}

@latman-oliveai - Thanks for reporting. Some other teams are also experiencing this problem.
We have created an internal task for this: SIDE-2220. We are also seeing similar issues with filesystem.listenDir, which we plan to address with this internal task.

I've done some troubleshooting with Kevin, it appears that the listenDir/listenFile capabilities are causing the process to hang altogether, the promise doesn't even get returned. I cannot reproduce this locally but I'm working with a different build. Given that we're cutting a release today/tomorrow we're going to see if this issue still exists and then deal with it from there.

I suspect that the Loop itself is also stuck in the "starting" state and never getting to "started".

Thanks for the update @richseviora, we saw this same behavior with another team today - they were pointed at the OH release from last week.

LDK V 3.0.0.beta.3 and Olive Helps V 0.17.3 have been released. This issue should now be resolved. If you find that it is still not working for you, please reopen the ticket.


documentation-update

Creating and/or updating documentation code for SAT.

Source code documentation has been updated.
https://github.com/The-Nuvo-Group/SAT_macro/commit/42e69e8a57d3b41d8fb4471e31b7646a9b556ee9


Upgrade SharpZipLib from 0.86.0 to 1.3.3

Summary
This PR upgrades SharpZipLib to the latest version.
Potential breaking changes include:

The ICSharpCode.SharpZipLib.Checksums namespace has been renamed ICSharpCode.SharpZipLib.Checksum.

Is this removal of SharpLib announced in advance? We now have 3rd party modules break because SharpLib is no longer there.

@schotman this PR was not intended to remove SharpZipLib from the installation, that was an oversight. Thanks for testing! I'll be submitting a PR to add the SharpZipLib library to the installation

Thanks, Question: do we want to remove SharpLibZip in a future upgrade? if so we need to want 3rd party module devs

Yes, the APIs that depend on SharpZipLib have been marked as deprecated and will be removed in v11.0.0. Our current intention is that we would remove SharpZipLib at that time. Any 3rd party module could then start including SharpZipLib if they require it, or migrate to System.IO.Compression as we did in #5127


Produce Add2App youtube video for Android

Produce Add2App youtube video for Android

gentle bump

Just merging this into https://github.com/flutter/flutter/issues/20660

@RedBrogdon wink wink


"Let there be color"

As I promised in our first "TensorPack-meeting", I will start contributing again after the CVPR deadline.
I found the Siggraph paper:
Let there be Color!: Joint End-to-end Learning of Global and Local Image Priors for Automatic Image Colorization with Simultaneous Classification
http://hi.cs.waseda.ac.jp/~iizuka/projects/colorization/en/
relatively straight-forward to implement. Please note, I haven't trained it until the end (still ongoing).
Not sure about the results. In some cases, I prefer the predicted images over the ground-truth.
some failure cases

working cases

Please consider this as a first draft. I will clean up the implementation when training is done.

comparison

I think, that this model is equally good at the Place Dataset, but does not generalize as good as the authors model. Seems to be reasonable, it is their teaser image which usually shows the best results. Further, there is some resizing going on in their inference code and they filtered out some images from the Place-Dataset, without describing details. And of course, I did not train the model for 3 weeks.
Any suggestions?

changed status from WIP -> "I do not want to touch it again"

I cleaned the README and the pre-trained model is here.


[10.x] Add toBase64() and fromBase64() methods to Stringable class

This PR adds two very simply methods to the fluent Stringable class:

toBase64()
fromBase64()

I recently needed to manually inspect a JWT in a guard and the Stringable class had every other built in function I needed except when it came to base64. Base64 has enough use in things such as JWT to files transmitted over the web. These simple helper methods make it easy to work with inside the context of a Stringable object similar to how Laravel supports upper and lower.
Example usage:
// Decoding a JWT token
$decodedJwt = collect(explode('.', $jwt))
    ->map(function (string $value) {
        $value = (string) Str::of($value)->fromBase64()->replace('_', '/')->replace('-', '+');
        return json_decode($value, true) ?? [];
    })
    ->reject(fn ($value) => empty($value))
    ->mapWithKeys(fn ($array) => $array)
    ->toArray();

// Simple encoding
return Str::of('foobar')->toBase64();

These should probably be added to the string helper as well. So Str::toBase64(...) is possible.


Playbook rerun results in duplicate inventory and playbook information being passed

210511030525.535 DEBUG 'ansible_navigator.main' Default collection_doc_cache_path set to: /Users/bthornto/.cache/ansible-navigator/collection_doc_cache.db
210511030525.535 DEBUG 'ansible_navigator.main' EDITOR environment variable not set
210511030525.535 DEBUG 'ansible_navigator.main' Default editor_command set to: vi +{line_number} {filename}
210511030525.535 DEBUG 'ansible_navigator.main' No config file set by ANSIBLE_NAVIGATOR_CONFIG
210511030525.535 DEBUG 'ansible_navigator.main' Skipping .ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.535 DEBUG 'ansible_navigator.main' Skipping .ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.535 DEBUG 'ansible_navigator.main' Skipping .ansible-navigator/ansible-navigator.json because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Users/bthornto/github/ansible-navigator/ansible_navigator/../etc/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Users/bthornto/github/ansible-navigator/ansible_navigator/../etc/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Users/bthornto/github/ansible-navigator/ansible_navigator/../etc/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Users/bthornto/.config/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Users/bthornto/.config/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Users/bthornto/.config/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /etc/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /etc/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /etc/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' Skipping /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.536 DEBUG 'ansible_navigator.main' No valid config file found, using all default values for configuration.
210511030525.536 DEBUG 'ansible_navigator.main' Command provided: 'run site.yml --ce docker -i inventory.yaml --eei quay.io/ansible/network-ee -e eei=quay.io/ansible/network-ee --ll debug'
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for cmdline. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for collection_doc_cache_path. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for editor_console. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for execution_environment. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for inventory. (changed=True)
210511030525.536 DEBUG 'ansible_navigator.main'  before: '['inventory.yaml']'
210511030525.536 DEBUG 'ansible_navigator.main'  after: '['/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/inventory.yaml']'
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for inventory_column. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for log_file. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for mode. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for osc4. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for pass_environment_variable. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for playbook. (changed=True)
210511030525.536 DEBUG 'ansible_navigator.main'  before: 'site.yml'
210511030525.536 DEBUG 'ansible_navigator.main'  after: '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site.yml'
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for playbook_artifact_enable. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for playbook_artifact_load. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for plugin_name. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Completed post processing for set_environment_variable. (changed=False)
210511030525.536 DEBUG 'ansible_navigator.main' Collection doc cache not mounted
210511030525.536 DEBUG 'ansible_navigator.main' Collection doc cache: 'path' is '/Users/bthornto/.cache/ansible-navigator/collection_doc_cache.db'
210511030525.536 DEBUG 'ansible_navigator.main' Collection doc cache: 'current version' is '0.6.0'
210511030525.537 DEBUG 'ansible_navigator.main' Running with app as 'run' (str/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with cmdline as '['-e', 'eei=quay.io/ansible/network-ee']' (list/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with collection_doc_cache_path as '/Users/bthornto/.cache/ansible-navigator/collection_doc_cache.db' (str/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with container_engine as 'docker' (str/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with editor_command as 'vi +{line_number} {filename}' (str/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with editor_console as 'True' (bool/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with execution_environment as 'True' (bool/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with execution_environment_image as 'quay.io/ansible/network-ee' (str/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with inventory as '['/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/inventory.yaml']' (list/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with inventory_column as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.537 DEBUG 'ansible_navigator.main' Running with log_file as '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/ansible-navigator.log' (str/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with log_level as 'debug' (str/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with mode as 'interactive' (str/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with osc4 as 'True' (bool/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with pass_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.537 DEBUG 'ansible_navigator.main' Running with playbook as '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site.yml' (str/cli parameters)
210511030525.537 DEBUG 'ansible_navigator.main' Running with playbook_artifact_enable as 'True' (bool/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with playbook_artifact_load as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.537 DEBUG 'ansible_navigator.main' Running with playbook_artifact_save_as as '{playbook_dir}/{playbook_name}-artifact-{ts_utc}.json' (str/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with plugin_name as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.537 DEBUG 'ansible_navigator.main' Running with plugin_type as 'module' (str/default configuration value)
210511030525.537 DEBUG 'ansible_navigator.main' Running with set_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.546 DEBUG 'ansible_navigator.ui_framework.ui._set_colors' curses.COLORS: 256
210511030525.546 DEBUG 'ansible_navigator.ui_framework.ui._set_colors' curses.can_change_color: True
210511030525.546 DEBUG 'ansible_navigator.ui_framework.ui._set_colors' self._osc4: True
210511030525.546 DEBUG 'ansible_navigator.ui_framework.ui._set_colors' _custom_colors_enabled: True
210511030525.547 DEBUG 'ansible_navigator.ui_framework.ui._set_colors' Custom colors set
210511030525.567 DEBUG 'ansible_navigator.actions.run.run' run requested in interactive mode
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' No config file set by ANSIBLE_NAVIGATOR_CONFIG
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping .ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping .ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping .ansible-navigator/ansible-navigator.json because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Users/bthornto/github/ansible-navigator/ansible_navigator/../etc/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Users/bthornto/github/ansible-navigator/ansible_navigator/../etc/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Users/bthornto/github/ansible-navigator/ansible_navigator/../etc/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Users/bthornto/.config/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Users/bthornto/.config/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Users/bthornto/.config/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /etc/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /etc/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /etc/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible-navigator.yml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible-navigator.yaml because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Skipping /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible-navigator.json because it does not exist
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' No valid config file found, using all default values for configuration.
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Command provided: 'run'
210511030525.573 INFO 'ansible_navigator.actions.run_20cc._update_args' 'mode' cannot be reconfigured. (restore original)
210511030525.573 INFO 'ansible_navigator.actions.run_20cc._update_args' 'mode' cannot be reconfigured. (apply defaults)
210511030525.573 INFO 'ansible_navigator.actions.run_20cc._update_args' 'mode' cannot be reconfigured (apply previous cli)
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for cmdline. (changed=False)
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for collection_doc_cache_path. (changed=False)
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for editor_console. (changed=False)
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for execution_environment. (changed=False)
210511030525.573 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for inventory. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for inventory_column. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for log_file. (changed=False)
210511030525.574 INFO 'ansible_navigator.actions.run_20cc._update_args' 'mode' cannot be reconfigured. (post process)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for osc4. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for pass_environment_variable. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for playbook. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for playbook_artifact_enable. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for playbook_artifact_load. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for plugin_name. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Completed post processing for set_environment_variable. (changed=False)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with app as 'run' (str/cli parameters)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with cmdline as '['-e', 'eei=quay.io/ansible/network-ee']' (list/previous cli command)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with collection_doc_cache_path as '/Users/bthornto/.cache/ansible-navigator/collection_doc_cache.db' (str/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with container_engine as 'docker' (str/previous cli command)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with editor_command as 'vi +{line_number} {filename}' (str/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with editor_console as 'True' (bool/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with execution_environment as 'True' (bool/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with execution_environment_image as 'quay.io/ansible/network-ee' (str/previous cli command)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with inventory as '['/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/inventory.yaml']' (list/previous cli command)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with inventory_column as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with log_file as '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/ansible-navigator.log' (str/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with log_level as 'debug' (str/previous cli command)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with mode as 'interactive' (str/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with osc4 as 'True' (bool/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with pass_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with playbook as '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site.yml' (str/previous cli command)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with playbook_artifact_enable as 'True' (bool/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with playbook_artifact_load as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with playbook_artifact_save_as as '{playbook_dir}/{playbook_name}-artifact-{ts_utc}.json' (str/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with plugin_name as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with plugin_type as 'module' (str/default configuration value)
210511030525.574 DEBUG 'ansible_navigator.actions.run_20cc._update_args' Running with set_environment_variable as 'Constants.NOT_SET' (Constants/value has not been set)
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_image:quay.io/ansible/network-ee
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: process_isolation_executable:docker
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: process_isolation:True
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_volume_mounts:None
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_options:None
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_workdir:None
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: json_mode:True
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: quiet:True
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cancel_callback:<bound method BaseRunner.runner_cancelled_callback of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x105dd42e0>>
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: finished_callback:<bound method BaseRunner.runner_finished_callback of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x105dd42e0>>
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: envvars:{'ANSIBLE_CONFIG': '/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible.cfg'}
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cwd:/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: executable_cmd:ansible-playbook
210511030525.575 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cmdline_args:['-e', 'eei=quay.io/ansible/network-ee', '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site.yml', '-i', '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/inventory.yaml']
210511030525.577 DEBUG 'ansible_navigator.actions.run_20cc._run_runner' runner requested to start
210511030525.577 INFO 'ansible_navigator.actions.run_20cc._init_run' Run initialized and playbook started.
210511030525.683 DEBUG 'ansible_navigator.actions.run_20cc._take_step' autoscroll enabled
210511030527.445 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 4 events
210511030527.959 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 4 events
210511030528.167 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 2 events
210511030528.270 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 3 events
210511030528.373 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 2 events
210511030529.302 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 3 events
210511030530.132 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 3 events
210511030530.646 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 1 events
210511030530.751 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 1 events
210511030530.856 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 4 events
210511030530.958 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 1 events
210511030531.061 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 1 events
210511030531.167 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 3 events
210511030531.271 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 1 events
210511030531.375 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 1 events
210511030531.692 DEBUG 'ansible_navigator.actions.run_20cc.update' runner finished
210511030531.692 INFO 'ansible_navigator.actions.run_20cc.update' Playbook complete
210511030531.692 DEBUG 'ansible_navigator.actions.run_20cc.write_artifact' Formatted artifact file name set to /Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site-artifact-2021-05-11 03:05:31.692736+00:00.json
210511030531.693 DEBUG 'ansible_navigator.actions.run_20cc.write_artifact' Resolved artifact file name set to /Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site-artifact-2021-05-11 03:05:31.692736+00:00.json
210511030531.730 INFO 'ansible_navigator.actions.run_20cc.write_artifact' Saved artifact as /Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site-artifact-2021-05-11 03:05:31.692736+00:00.json
210511030535.452 DEBUG 'ansible_navigator.actions.select.run' selection made
210511030535.452 DEBUG 'ansible_navigator.actions.select.run' Requested next step in run_20cc will be task_list
210511030539.507 DEBUG 'ansible_navigator.actions.select.run' selection made
210511030539.508 DEBUG 'ansible_navigator.actions.select.run' Requested next step in run_20cc will be task
210511030540.100 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 16:(807, 568, 470)
210511030540.101 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 17:(709, 807, 658)
210511030540.101 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 18:(337, 611, 839)
210511030541.535 DEBUG 'ansible_navigator.actions.back.run' back requested
210511030541.535 DEBUG 'ansible_navigator.actions.back.run' Stepping back in run_20cc from task to task_list
210511030543.726 DEBUG 'ansible_navigator.actions.rerun.run' rerun requested
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_image:quay.io/ansible/network-ee
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: process_isolation_executable:docker
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: process_isolation:True
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_volume_mounts:None
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_options:None
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: container_workdir:None
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: json_mode:True
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: quiet:True
210511030543.727 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cancel_callback:<bound method BaseRunner.runner_cancelled_callback of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x10706e2b0>>
210511030543.728 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: finished_callback:<bound method BaseRunner.runner_finished_callback of <ansible_navigator.runner.api.CommandRunnerAsync object at 0x10706e2b0>>
210511030543.728 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: envvars:{'ANSIBLE_CONFIG': '/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/local/etc/ansible-navigator/ansible.cfg'}
210511030543.728 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cwd:/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info
210511030543.728 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: executable_cmd:ansible-playbook
210511030543.728 DEBUG 'ansible_navigator.runner.api.generate_run_command_args' Runner arg: cmdline_args:['-e', 'eei=quay.io/ansible/network-ee', '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site.yml', '-i', '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/inventory.yaml', '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site.yml', '-i', '/Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/inventory.yaml']
210511030543.732 DEBUG 'ansible_navigator.actions.run_20cc._run_runner' runner requested to start
210511030543.732 DEBUG 'ansible_navigator.actions.run_20cc.rerun' Playbook rerun triggered
210511030545.601 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 2 events
210511030545.703 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 2 events
210511030546.118 DEBUG 'ansible_navigator.actions.run_20cc._dequeue' Drained 127 events
210511030546.323 DEBUG 'ansible_navigator.actions.run_20cc.update' runner finished
210511030546.323 INFO 'ansible_navigator.actions.run_20cc.update' Playbook complete
210511030546.323 DEBUG 'ansible_navigator.actions.run_20cc.write_artifact' Formatted artifact file name set to /Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site-artifact-2021-05-11 03:05:46.323942+00:00.json
210511030546.324 DEBUG 'ansible_navigator.actions.run_20cc.write_artifact' Resolved artifact file name set to /Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site-artifact-2021-05-11 03:05:46.323942+00:00.json
210511030546.324 INFO 'ansible_navigator.actions.run_20cc.write_artifact' Saved artifact as /Users/bthornto/github/ansible-navigator/share/ansible_navigator/ee_info/site-artifact-2021-05-11 03:05:46.323942+00:00.json
210511030549.429 DEBUG 'ansible_navigator.actions.log.run' log requested
210511030549.482 DEBUG 'ansible_navigator.ui_framework.ui._color_lines_for_term' Added color: 19:(415, 600, 333)
210511030619.398 DEBUG 'ansible_navigator.actions.log.run' autoscroll disabled

Note the ansible_navigator.runner.api.generate_run_command_args when playbook is rerun

Fixed here https://github.com/ansible/ansible-navigator/commit/5d35386c22b13f55ee2c78d41d833476e8d51969#diff-578f02706608c07364fadd817966fe772520c2885f2562d8898ded054d9b8526R553

@ganeshrn :)


Demo: Build with vite

Part of the effort to address tsup issues.
Pros:

Very popular and maintained build tool
Simple configuration

Cons:

Bundles everything by default, so need to tell it which dependencies to keep external (or add a plugin)
Doesn't generate .d.ts by default, so need a separate tsc task or a separate plugin (which only generates for ESM or CJS - is CJS still necessary?)
Feels like it's designed for bundling apps, not libraries

Superseded by #528 and migrating to Vite
Thanks so much for your help!


Don't instantiate a TimeoutException on each request

Hi,
Maybe it's better to not instanciate a TimeoutException on each request :
https://github.com/spring-cloud/spring-cloud-gateway/blob/aaa52670ca283447aa21a6a24922db6d7f94859b/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/NettyRoutingFilter.java#L192-L193
Mono.defer can prevents it :
.timeout(responseTimeout,
    Mono.defer(()->Mono.error(new TimeoutException("Response took longer than timeout: " + responseTimeout))))

But maybe it was intended. Mono.defer can be slower than create an exception ?

PRs welcome


Support for nested Formatted*

The current wrapper for Formatted* in React Native doesn't support nested Formatted* such as below. This PR will fix this problem and make it work as normal.
<FormattedMessage
  id='app.greeting'
  defaultMessage='{hello}, {name}!'
  values={{
    hello: <FormattedMessage id='app.hello' defaultMessage='Hello' />,
    name: 'James',
  }}
/>

Awesome. Thank you!


.net core support

Hi,
Is there any support for .net core with the XSAPI?
Thanks!

Not exactly.   XSAPI does support a WinRT API which is callable from C# on UWP platforms.  More info here: https://docs.microsoft.com/en-us/windows/uwp/xbox-live/introduction-to-xbox-live-apis


Paloma Wallet

Background
Paloma chain needs a wallet, so users can interact with the chain. We want to use station.terra as basis for this.
Done when

[ ] nest.palomachain.com is set up in vercel and points to palomachain/nest
[ ] references to terra in palomachain/nest are removed and replaced with Paloma
[ ] the app is pointed to our paloma testnet

this has been broken out into multiple tasks


fix: LSDV-4937: Label missing from outliner when multiple labels are selected

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
When user was selecting two or more labels from different  for the same annotation the labels weren't being shown in the outliner sidebar, also if user was selecting two or more labels from the labels that has the property choice="multiple" set, in the outliner all labels was being shown but all with the same color, normally the same color as the first region selected.
What does this fix?
For both cases, now all selected regions are shown in the outliner sidebar and they are being shown with their colors
What libraries were added/updated?
none
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
NA
What feature flags were used to cover this change?
NA
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[x] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Codecov Report
Patch coverage: 100.00% and project coverage change: +31.71 :tada:

Comparison is base (04c7c24) 33.29% compared to head (402e1ad) 65.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1477       +/-   ##
===========================================
+ Coverage   33.29%   65.01%   +31.71%
===========================================
  Files         439      439
  Lines       27428    27437        +9
  Branches     7267     7165      -102
===========================================
+ Hits         9133    17839     +8706
+ Misses      15223     9598     -5625
+ Partials     3072        0     -3072

Impacted Files
Coverage Δ

...mponents/SidePanels/OutlinerPanel/OutlinerTree.tsx
65.15% <100.00%> (+16.47%)
:arrow_up:

... and 304 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/git merge master


changing the loopduration

Whoops, this is very important to correctly determine the frame.

Also didn't compile.


Automate the creation of the gitignore workflows

@danielrbradley I found a bug in the implementation of the native providers generation that always treated as yaml therefore the |. That's now fixed :) I will let you fine peeps discuss what needs to go into the gitignore file now :)


Give foreign methods a userData field

This lets a single WrenForeignMethodFn implement multiple foreign methods or otherwise change its behaviour based on a void *userData.  My use case is the Vala bindings, in which I dispatch from a single WrenForeignMethodFn to any number of implementations based on userData.  However, I believe others will find many uses for this!
Thank you for considering this PR!
High-level changes:

Make WrenForeignMethodFn take (WrenVM* vm, void *userData) instead of just vm
Make WrenBindForeignMethodFn return both a WrenForeignMethodFn and a userData value
Corresponding changes throughout

Notes:

All tests pass
Fixes #942.  Makes it much easier to implement #959 (only about 10 more lines of code! --- example)
I am happy to make this a compile-time option if you would like.
I can also split up the changes into commit(s) differently.

Timing analysis
This plot shows the results from the baseline txt file.  The Y axis is score, so higher numbers are better.  I ran benchmark.py --generate-baseline 10 times for each commit, and saved the baseline.txt files.

The tests are, in order left to right:

api_call
api_foreign_method
binary_trees
binary_trees_gc
delta_blue
fib
fibers
for
map_numeric
map_string
method_call
string_equals

I do not know why the change in api_call --- I looked at the code, and it is barely making any foreign method calls that I can tell.  Any ideas?

This change is too breaking.

Side note: That's true for any breaking change @ChayimFriedman2 this one is no different or worse.

This change is too breaking. It will break any application that embeds Wren.

While it is breaking, I can see the advantage to api's that cannot create C functions.
WrenGo currently simulates this behavior by uses an arbitrary number of C functions that access an array of Go functions. This has a major limitation that I cannot bind more functions then allocated during compile.
With this change, instead of allocating an arbitrary number of C functions during compile, I can instead store go functions in a map and call them from Go

No, I meant: we may accept breaking change that makes the situation "more correct" if it affects only a small amount of embedders, but this one affects anyone, no way you don't have foreign methods.

Edit: I agree it is useful, I'm just saying we need to find a less breaking way.

If we want a less breaking way, I'm not sure how hard it would be but would it be possible to call a function to get the name of the currently running method with it's class type and module name? that way we don't really change the signature of that function but embedders can still tell which function was meant to run from the VM.

Result are better than I anticipated. The deviation in the api_vall benchmark was expected, since it rapidly fire foreign functions to benchmark state of that specific path in the VM (Due to the extra C stack manipulation and memory growth of the class method array).
As this, it is good enough.
Maybe something like DEF_PRIMITIVE should be publicly provided to limit the impact of future breaking changes like this one.

They make it impossible to support dynamically loaded Wren version.

@mhermier I think you must be right about the size of the class method array being a factor.  I retested with this change on top of the PR:
--- a/src/vm/wren_vm.c
+++ b/src/vm/wren_vm.c
@@ -682,1 +682,1 @@
-  method->as.foreign(vm, method->userData);
+  method->as.foreign(vm, NULL);

The results were substantially the same as with the fetch of method->userData.  In the picture below, yellow is a re-run of this PR, and green is with the diff above.  Five runs of each.

@mhermier @ChayimFriedman2 If we changed the API, we could make the internals a compile-time condition, like the optional modules are now.  The API would still provide userdata, but it wouldn't be stored in the interpreter unless the compile-time condition were true.

@cxw42 while its sounds safer, I would discourage to do so. We already have 2 dimensions to the code that are usually not well tested (debug and alternative value representation)... Let's not add another one.

@mhermier I moved the foreign-method userData values into a separate Buffer and got better results:

All: would you please glance at https://github.com/cxw42/wren/commit/2ea1e89cc082dd54c19fa471487c4ecc74cbdb5a and see if the general approach seems reasonable?  If so, I will squash that back into this PR.  Thanks!

Nice improvement.
I only fing the usage of wrenForeignMethodUserDataBufferFill a bit
suspicious in case the order of the method declaration mess the fill...
Otherwise it seems to be good for me.

@mhermier interesting point about order --- I'll try a few different orders when I write tests.

@mhermier I just squashed and updated --- seems like it works OK!  See test/api/foreign_method_user_data.wren for the orders I tried.
All, I have not yet updated the docs.  If this code change is approved, I will change this PR to include the updates docs, or submit a second PR.
Thanks!

@ruby0x1 would you be willing to review, at your convenience?  The GitHub interface isn't letting me request a review for some reason.  Thank you in advance!

want to throw in that I have learned c# unity il2cpp will need this change

I feel like #959 those 10 lines should be in done in the same PR. or at least be considered to be part of this PR

@Orcolom I'm happy to do so if the project maintainers don't mind!

I updated the documentation.  Any other thoughts or comments?

It will break any application that embeds Wren.

It would also in many cases only be a 1 or 2 line change, no?  Requiring someone to update their WrenBindForeignMethodFn API signature? And if they were linking against the library dynamically perhaps it would even just continue to work since the extra param would just be NULL? (I'm unsure of this though).
My 0.02: I feel worrying about breaking changes [so early] while we're still 0.x is a bit premature.  Sure, we shouldn't break things for no reason if we can avoid it, but if we have a reason to break things I don't think the bar should be super high to breaking them if that results in an improvement (even a small one).
If someone wants stability they can ping to a specific version.  When upgrading someone should expect they may need to update some of their code.

in many cases only be a 1 or 2 line change, no?

Yes, as far as I know.  We can't count on the extra param --- for reliability, I would recommend relinking.
0.4.0 made a similar change:

API
BREAKING: Add userData to wrenReallocateFn

(from https://github.com/wren-lang/wren/blob/main/CHANGELOG.md)

0.4.0 made a similar change:

API
BREAKING: Add userData to wrenReallocateFn

You're both right and wrong.
Right, because it's a breaking change.
But wrong, because usually you don't bother to change wrenReallocateFn. The default is good enough, unless you're building an OS and need your own allocator.
OTOH, each and every embedder have foreign methods. Changing their signature will break everyone.

@ChayimFriedman2 fair point!  What alternative would you suggest?

I don't know. Maybe it is the right way. But it should be on the table.

Rebased on latest main
Added a comment that foreignMethodUserDatas is separate from struct Method for performance reasons.

No functional changes.

Could you take advantage of vm->config.userData here?

No. Current model rely on the fact that the user has to generate one entry point per native method. Adding that parameter, permits to have only one entry point, and discriminate the native method at runtime . It can be usefull on full featured language binding where you can create an object that automagically transform wren parameters to language binding type, without passing via the the manual decoding of parameters.


Fix regular expression option in replace menu. Closes #1834

Fix regular expression option in replace menu
Also change the behavior for escaping plain strings : new lines and tabs characters are no more escaped as \n and \t, but suppressed like other non printable characters. This is more consistent with the advice given to the user (using "regular expression" option and not plain string to search for new lines or tabulations)

To test and check nothing is broken : try to redo all the steps of this project
test.openrefine.tar.gz


Clean up build.gradle with releasing to Maven Central

Some more cleanups after #20.

LGTM 👍

Thanks!


fix: allow file writing if not the paste buffer

:tada: This PR is included in version 1.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


A lexer for F*, an ML dialect for program verification

Ported from https://bitbucket.org/birkenfeld/pygments-main/pull-requests/763

Covered by #1409 , so closing this one.


new(modern_bpf): Relax required kernel version for modern bpf

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Currently, modern bpf engine supports only kernels newer than 5.8, assuming all the dependencies (BTF and ring buffer maps) are supported on those kernels. This prevents it from supporting older versions, where BTF and ring buffers were back patched.
Make modern bpf engine to check required dependencies explicitly:

Examine the kernel config to find out if CONFIG_DEBUG_INFO_BTF is present. The implementation is based on similar functionality in bpftool.

Use libbpf helpers to verify if ring buffer map type is supported.

Introduce a new parameter for modern probe engine to pass the custom kernel config path if needed.

Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: erthalion
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

ea4e362 new: Relax required kernel version for modern bpf

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Welcome @erthalion! It looks like this is your first PR to falcosecurity/libs 🎉

/cc @FedeDP @Andreagit97

Ei @erthalion thank you very much for this!! You used libbpf_probe_bpf_map_type to check the ring buffer presence, while you searched BTF explicitly looking at the kernel config. Since in the modern bpf probe, we use BPF_PROG_TYPE_TRACING programs what about using libbpf_probe_bpf_prog_type to check for this kind of program? These programs always need the vmlinux in your system so if libbpf is correctly able to load them we are sure that BTF are available! In this way, we could avoid the new kconfig param and all the manual inspections. What do you think about this approach?
Moreover probably the right place for these checks is libpman since all the libbpf usages are contained in that library. The modern bpf engine doesn't use libbpf explicitly. We could add a simple API like pman_check_support that simply calls:
ret = libbpf_probe_bpf_map_type(BPF_MAP_TYPE_RINGBUF, NULL);
ret = ret ?: libbpf_probe_bpf_prog_type(BPF_PROG_TYPE_TRACING, NULL);

Ei @erthalion thank you very much for this!! You used libbpf_probe_bpf_map_type to check the ring buffer presence, while you searched BTF explicitly looking at the kernel config. Since in the modern bpf probe, we use BPF_PROG_TYPE_TRACING programs what about using libbpf_probe_bpf_prog_type to check for this kind of program?

Yeah, makes sense.

These programs always need the vmlinux in your system so if libbpf is correctly able to load them we are sure that BTF are available! In this way, we could avoid the new kconfig param and all the manual inspections. What do you think about this approach?

It indeed sounds tempting, because the final change set will become much smaller. But error reporting will have to be tighten up to clearly state the cause of failure if libbpf wasn't able to load vmlinux btf. After a quick experiment it looks like at the moment it would look like this, which is a bit cryptic:
libbpf: failed to parse target BTF: -2
libbpf: failed to perform CO-RE relocations: -2
libbpf: failed to load object 'bpf_probe'
libbpf: failed to load BPF skeleton 'bpf_probe': -2
libpman: failed to load BPF object (errno: 2 | message: No such file or directory)

I'll check if it could be improved as part of the PR.

Moreover probably the right place for these checks is libpman since all the libbpf usages are contained in that library. The modern bpf engine doesn't use libbpf explicitly. We could add a simple API like pman_check_support that simply calls:
ret = libbpf_probe_bpf_map_type(BPF_MAP_TYPE_RINGBUF, NULL);
ret = ret ?: libbpf_probe_bpf_prog_type(BPF_PROG_TYPE_TRACING, NULL);

Right, I wasn't sure about this myself, so will try out with libpman. I'll post soon an updated version.

@Andreagit97 @incertum @Molter73 here is the new smaller version that handles only required BPF features leaving vmlinux to libbpf. Note, that this approach puts more emphasize on the clean error reporting. One immediate follow-up is #934 , and handling a custom path to vmlinux with BTF will require some extra efforts (libbpf is not great at that). I'm preparing the PR for the latter one as well.

/milestone 0.11.0

LGTM label has been added.  Git tree hash: c90a27b0b91fa296a14087074d5ad8d94a1e3d0d

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, erthalion
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, erthalion, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

Sorry just one minor point, if we want to have better logging why don't we use pman_print_error() after each libbpf_probe...() with a precise description of what is going on, for example, "BTF are not available on your system"
nit: we could remove https://github.com/falcosecurity/libs/pull/928/files#diff-963efeeb7163b733866ca9fbd143acf420b9c0ce4807a63eb3b72c7808462d06R32-R34 these macros since they are no more useful

probably we could do that stuff also in https://github.com/falcosecurity/libs/pull/934, in this way we can merge this one :)

/unhold

Thanks! Will take a look at extending #934.


Evaluating expressions in the context of a stack frame, instance

As far as I can see there's no way to evaluate an expression in the context of a particular stack frame. And it's not clear how to evaluate in the context of an instance either.

Inspectors have text-box evaluators. The debugger has an eval command ('print').


⚠ Bofrost.de has degraded performance

In b0f16ec, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 3155 ms

Resolved: Bofrost.de performance has improved in c58a0cb after 49 minutes.


Duplicate and frequently changing IRC nickname colors assigned to users

I am having an issue where several users from Discord will share the same color (always purple) for their IRC nickname. Although there are 5-8 people using the bridge, all of them save one or two will have the same color. Occasionally, they will suddenly have unique colors, but this never seems to last for more than a few minutes.
Steps to reproduce:
Have the IRC nickname color option enabled? Sorry I cannot be more helpful in this regard. I will attach some screenshots to better illustrate.
Expected Behavior:
I would expect each user to be assigned a unique color code, and for these to remain assigned to each user for the remainder of their session.
Environment:
OS: linux
npm: 3.10.10
discord-irc: Current
Images:

This image shows multiple users sharing the same color, despite there only being about 6 users.

This image shows multiple users suddenly receiving unique colors, and then returning to sharing the same color a few minutes later. Again, oddly, this behavior only affects users who are initially given purple.
Please let me know if any other information would be helpful.

The color is based off the first letter and length of the nickname. (Code is here: https://github.com/reactiflux/discord-irc/blob/7f7505cae7ebc1ee254792c04c2ec7f4ac55c143/lib/bot.js#L274)
It makes sense that jan Kisi would change color when becoming janKisi, since that's reduced in length, and also would make sense than jan Kawa and jan Kisi would be the same color (same initial letter, same length). I'm not however sure why jan Kawa would be a different color in the start of the second image. Which of those users (^^^^, d__b) is the discord-irc bot? Or are they both discord-irc bots?

Oh, thanks for the info on the first part, that makes a lot more sense.
^^^^ is teleirc, a bridge between IRC<>discord, and d__b is the discord-irc.

I don't think there's any unexpected behavior here, then? It looks like d__b is doing colors consistently with the behavior described.
(I personally wouldn't expect it to track users and then make decisions for how not to collide – that sounds like it would require weird heuristics and also the clients I've used which color nicknames don't handle it that way.)

Yep. I was unaware of the way that colors were handled, my apologies, nothing unexpected happening here.


Unable to find template<EMAIL_ADDRESS>

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[X]

Hello,
After a succesfull installation and deployment of the dev environment, I'm having trouble with the translations web interface.
It's throwing the error Unable to find template<EMAIL_ADDRESS>I saw in other threads that this error already occured, and that you even found a workaround on schmittjoh's git repository.
However, I've tried to setup the framework as written, to update from the latest version on schmittjoh's repo - without success.
Do you have any idea how I could solve that issue ?
If you need any kind of specifications for my environment, please let me know.
P.S. : If this is an issue you would like to discuss in direct chat, I am French. :)
Thanks in advance !

Hello,
Indeed we have identified this issue. A fix will be available in few days.
In the meanwhile could you try this fix:
cd vendor/jms/translation-bundle/JMS/TranslationBundle/Resources/views
ln -s Translate translate

Hi guys,
Thanks, that's a solved one ! ;-)


update docs with new @inner_content

As of Phoenix 1.5, when using:
<%= render @view_module, @view_template, assigns %>
the following warning occurs:
warning: Rendering the child template from layouts is deprecated.
Instead of:

    <%= render(@view_module, @view_template, assigns) %>

You should do:

    <%= @inner_content %>

Refer to Phoenix 1.5 release notes: https://gist.github.com/chrismccord/e53e79ef8b34adf5d8122a47db44d22f#update-your-layouts

@nbw I created a new PR for this that takes in this doc update but addresses some other warnings in https://github.com/beam-community/bamboo_phoenix/pull/14.


Fix lambda role

Trying to use the CloudFormation template from the HEAD of master yields this error: Error: ROLLBACK_COMPLETE: ["The following resource(s) failed to create: [AutoscalingLambdaExecutionRole]. . Rollback requested by user." "Value of property Policies must be a list of objects"] (Note we are running the stack through terraform but I don't think that is necessarily related).
This PR fixes that issue.

Thanks @jradtilbrook

Well, seeing as how I introduced it in a broken state, that is quite alright! :tada:
I've now tested it from the stack built on master and it's working for me now with KMS encryption and SSM parameter (from the lambda side). There's another issue now though that I'll raise in a separate issue


A couple changes related to task/child cancellation

When the task running open_in_process() is cancelled, we now send
a SIGINT and give the child a chance to terminate before sending
a SIGTERM.
When a child raises asyncio.CancelledError, that gets converted
into a ChildCancelled exception

Also renames Process.@result to Process.get_result_or_raise() as
having a property that is expected to raise an exception is at
the very least unexpected.

With this change we'll be able to get rid of some trinity code that does the same thing (https://github.com/ethereum/trinity/blob/00dc1a032851ef830ab04cedc4ce39070c83b18a/trinity/extensibility/asyncio.py#L37-L51), thus consolidating the handling of child termination and avoiding double sigints/sigterms like the one I was trying to fix in https://github.com/ethereum/trinity/pull/1610


enable private rustls feature when rustls backend feature is enabled

This was introduced in #59 and by the name it follows the precedents set by other crates to define this as a private feature flag. I assume downstream crates should not use this feature flag, but theRustlsConnector is hidden behind this flag.
This enables the __rustls feature when a rustls backend is selected downstream, reqwest does this similarly, and I think this was missed in #59.

 Thanks for fixing!


Remove localhost normalization hack

We need to fix hyperbahn runbooks first.
We need a way to adress hyperbahn workers in prod.
We could have hyperbahn workers bind to all addresses in prod.
We could update the run books to load the ip into an environment variable.

I don’t think we’ll be able to land this realistically. We are committed to the hack without a decent alternative.


Add warning/error if user running without broadcaster and multiple workers

Full user issue in our slack:
https://opal-access.slack.com/archives/C01RUUYV3TP/p1641240327028500
we need to check if UVICORN_NUM_WORKERS  > 1 and OPAL_BROADCAST_URI is None - criticial error or at least warn the user.

@roekatz this is a good first issue :)

@asafc
I don't want to look up UVICORN_NUM_WORKERS from within OPAL code (Coupling it with gunicorn as its orchestrator).
How about checking it in the start.sh script?
Another option I'm thinking of - having "memory://" as the default for "OPAL_BROADCAST_URI".
This would just make OPAL Server container work even if the user configured more than 1 worker but no external BROADCAST_URI. Do you see any downside?

Not sure if the memory:// broadcaster will perform correctly. i think you could:

change the default UVICORN_NUM_WORKERS to 1 in all places
check the settings where ever you want - start.sh is fine :)

Maybe worth checking if the memory option works well. 🤔
On Wed, Jan 19, 2022 at 11:02 AM Asaf Cohen @.***>
wrote:

Not sure if the memory:// broadcaster will perform correctly. i think you
could:

change the default UVICORN_NUM_WORKERS to 1 in all places
check the settings where ever you want - start.sh is fine :)

—
Reply to this email directly, view it on GitHub
https://github.com/permitio/opal/issues/200#issuecomment-1016222266, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAP3ULO4MMZ75DILZHN2VW3UWZ4ZNANCNFSM5LF6J6KA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Create a playbook for tuning custom monitoring

This doc is a playbook for

adjusting the custom metrics to be exported to backends, especially Cloud Monitoring
disabling custom monitoring

/hold

/cc @karlkfi
/cc @nan-yu

so great to see these docs in the repo.

/retest-required

/retest-required

/ok-to-test

/unhold

@karlkfi
re:
Config Sync doesn't revert changes to the ConfigMap it created?

What if we want to change the config string in a Config Sync update? Don't we want it to push out the new config to the ConfigMap? We don't want to stomp on customer config. I thought that's why the -custom config is supported.

Somehow I could not reply to this message so creating a new thread. The -custom config was designed as an option for users to freely configure any pipelines that suits the use case, as far as I know of.
Since this guide is a work around, it makes sense to me to patch over the current working otel config. Otherwise we will need to explain why we want users to add this Cloud Monarch pipeline into the -custom config.
And you are correct about the ConfigMap, pod loads the ConfigMap by name, but not exactly managing the versions of it or force reverting anything.

@tiffanny29631 If config sync is NOT updating the otel config map, then I won't be able to push out changes to it with my upcoming metrics refactor. And if config sync IS updating the otel config map, then this workaround will be overwritten when the next CS update happens.
Neither of these are good. Telling the user to use the -custom name fixes both problems.

@karlkfi Confirmed that the ConfigMap will be restored to default when reconciler-manager has a restart. I've added notes for switching to otel-collector-custom.

/retest-required

Question: how do I find out that these playbooks exist?

Question: how do I find out that these playbooks exist?

This is the first one. I suggested having them closer to the code, since they're open source. But we haven't put any links to direct people here yet, but we could maybe link here from the ACM troubleshooting gdoc.

we could maybe link here from the ACM troubleshooting gdoc.

I have CL linking to this doc in support doc, just waiting for this one to be merged first.
It could also be referred in our main playbook directory.

/lgtm


Remove whitespace at end of blank doc comment lines.

Since commentLineStart had a space at the end of it, if the
line in the comment was blank, there would be a space at the end
of that blank line.
In Rust, this resulted in a bunch of lines modified by rustfmt,
so it would be nicer to just not generate that extra bit of
whitespace.

This is a revision of #663 to address the concerns that @schani had.

Great, thank you!


Add note for EDTF form elements

Similar to https://github.com/iandees/wof-editor/issues/3.
We don't need a date picker (as EDTF date notation is more flexible), but for (edtf:cessation, edtf:deprecated, edtf:inception, edtf:superseded)
Let's add example text to the first one, like:

Supports EDTF date notation like: 2000, 2000-01, 2000-01-01 and approximate dates like ~2000. Defaults to uuuu when unknown.

I appended this note to the existing text:

Verified.


Fix issues with animation markers drawing

Animation markers introduced in https://github.com/godotengine/godot/pull/91765 draw unnecessary separator lines in the header over the already existing lines. This seems to be an oversight because those lines don't seem to have anything to do with markers and double lines are hard to spot in the default theme. However in my theme they introduced a noticeable regression because I'm not using those separators and https://github.com/godotengine/godot/pull/91765 drew  some unthemable ones.
I also added missing EDSCALE when drawing marker lines for better HiDPI support and added a little space around the marker label text
Before/After fixes in this PR:

You can notice the line being drawn twice in the default theme in close comparison:

Thanks!


rel.2.2.x -- port chain_kv from develop-boxed to rel.2.2.x

Change Description

Copy latest chain_kv to rel.2.2.x.
Change Type
Select ONE:

[ ] Documentation

[ ] Stability bug fix

[x] Other

[ ] Other - special case

Testing Changes
Select ANY that apply:

[ ] New Tests

[ ] Existing Tests

[ ] Test Framework

[ ] CI System

[ ] Other

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

This is duplicated by https://github.com/EOSIO/eos/pull/10625. Close it.


Fix Metallurgic Infuser not auto-ejecting output

Fixes #2268
(it was trying to auto-eject energy cells :P)
I checked all of the other TileComponentEjector instances for similar errors, the rest of them look okay.

Thanks! Nice PR.


how  to get json file that defines the mapping between text and layout.

Excuse me , how  to get json file that defines the mapping between text and layout if I want to generate images in a freestyle way?What is the label value?

Thanks for your reply ! Could you please tell me what tool you used to get the pixel values for each region in the layout?
Thank you a lot~

It depends on how you get the layout images. Those provided in ./examples/ are from COCO-Stuff dataset, and you can refer to
this to obtain the pixel values.

Thanks for your reply ! your reply help me a lot!


Vite plugin should activate when vitest present in deps

The vite plugin only loads when vite is a dependency. However, vitest may be used without explicitly installing vite. If vitest is installed, packages used in vite.config.ts should not be marked as unused even if vite is not explicitly installed.

Agreed, should be fixed in v5.24.0.


Mercurial gauntlet doesn't trigger the reward popup

Describe the bug
Mercurial gauntlet doesn't trigger the reward popup on the 15th of every month.
Expected behavior
Upon logging in on the 15th of the month after reset, a popup showing MG rewards can be claimed should be visible, if the user has unlocked MG and made progress in it. Clicking this should grant the reward
Additional context
This is driven by monthly_wall_reward_list from the response given by login/index. Set the quest_group_id equal to the MG quest group and the reward status to Available and the popup will appear on login.

Closed by #797


Indicate a canvas has multiple image resources in Thumbnail filmstrip

Some sort of visual clue, like a + sign

I could see this being more confusing than helpful. Why would a user want to know this in the thumbnail view (other than demoing multi-image support, and wanting to select something that showed that feature)?
It might be an example of exposing too much of the model to the user.

Rashmi and I were discussing in the context of a potential drag&drop of thumbnails into the layers tab.  I don't think it's important any longer since the decision was made last week not to drag & drop a canvas thumbnail into the layers tab.   That said, generating a proper thumbnail for a canvas could get trickier as more support for canvas authoring is added to Mirador since the thumbnail supplied with the manifest may no longer be valid after the canvas is modified.


Describo tabs should show indicator when required fields not filled in

From @beepsoft
On each tab, there may be required fields that do not have metadata. The tab heading should show an indicator to the user that that tab needs the user to add metadata.
The indicator should be a red dot similar to what is shown on the field when it's not filled in.

This comment also pertains to #64.
@beepsoft What do you think?

Required data is missing - red X next to tab name

All required data provided and the tab has some data on it - green tick. Notice the other tabs have neither an X nor a tick?

Second tab doesn't have required fields but at least one field has data - green tick.

Regarding the red and green icons, perhaps something more subtle would be preferable, so it's less obtrusive. I liked the little dot in the required fields. Could we use similar icons (filled circles) in red and green maybe?

I used el-badge initially the as I did with required properties (https://github.com/describo/crate-builder-component/blob/master/src/crate-builder/RenderEntity/RenderEntityProperty.component.vue#L11) but it's visually difficult to see the difference when it changes because it's so small from red to green. On the required property it's less of a problem because the property name is red or it goes to black.
And then there's the issue for color blind users. Red/green are bad colours. Having an icon mitigates that. Hence why I chose it.

Thanks for the CSS override tip! I was also thinking that it might be worthwhile to add semantic class names to each field so they can be more easily targeted with CSS.
Something like this:

...

It would result in a HTML like this:
There maybe other places where we could add such semantic classes for future CSS customizations.

Absolutely. I have to ask - do you have a need to have property level classes or is this a "wouldn't it be good if idea?". If you need it, then let's add it now. If it's the latter, then I would prefer a direct use case first.

a1caf1d4cc57aeff0b6e68e3c23448a1bd5a731e
This does not include the CSS discussed above so keeping this ticket open for now.

Done - and extra styling added via other work by @beepsoft


Modify TypedTextGenerator to use TextGenerator lines

The text generator currently moves an alpha tag to change what characters are visible, which is not optimal for garbage collection. A solution to this is to use the following code in place of the function that changes the location of the alpha tag, but some changes would likely need to be made since this is mostly unmodified from the system that I use.
     // textField is the text object that the player sees, and is also where the unformatted text starts // I don't remember what tempString does, I just know that you need it // I also don't remember what start or end index do , but again, they are very important public void InitializeText()     {         textField.color = Color.clear;         textField.text = text;         Canvas.ForceUpdateCanvases();         for (int i = 0; i < textField.cachedTextGenerator.lines.Count; i++)         {             int startIndex = textField.cachedTextGenerator.lines[i].startCharIdx;             int endIndex = (i == textField.cachedTextGenerator.lines.Count - 1) ? textField.text.Length : textField.cachedTextGenerator.lines[i + 1].startCharIdx;             int length = endIndex - startIndex;             tempString += textField.text.Substring(startIndex, length) + "\n";         }         textField.text = string.Empty;         textField.color = Color.white; // Replace with whatever color you need         text = tempString;     }
I'm sorry I don't know as much as I should about a script that I wrote, but I wrote this a very long time ago, and I never used to put comments in my code (I have since learned my lesson), so I hope you can make at least some sense of this. Despite all of these problems with it, I hope you get at least some use out of this script even though it was very poorly done, and i will probably need to redo it at some point

It looks like Github completely messed up the code, so here it is
public void InitializeText()
{
textField.color = Color.clear;
textField.text = text;
Canvas.ForceUpdateCanvases();
for (int i = 0; i < textField.cachedTextGenerator.lines.Count; i++)
{
int startIndex = textField.cachedTextGenerator.lines[i].startCharIdx;
int endIndex = (i == textField.cachedTextGenerator.lines.Count - 1) ? textField.text.Length : textField.cachedTextGenerator.lines[i + 1].startCharIdx;
int length = endIndex - startIndex;
tempString += textField.text.Substring(startIndex, length) + "\n";
}
textField.text = string.Empty;
textField.color = Color.white; // Replace with whatever color you need
text = tempString;
}

Thanks for submitting the code sample! Some day soon I'll look to adapt the typer for Unity 2017 and Text Mesh Pro, and maybe this will come in handy.


Fix that nasty Unicode bug for blogs.perl.org

The blogs.perl.org feed doesn't transmit a content encoding, which was causing problems. It's the same problem as in http://ask.metafilter.com/26130/How-to-fix-an-Atom-feed
I changed to using Mojo::UserAgent because I think it's easier to handle Unicode. the ->body is octects and I can decode that.
But, XML::Atom::Client apparently has problems, which might simply be how it's documented. I tried XML::FeedPP and it handles the Unicode.
I also assumed that all Atom feeds will be UTF-8, which might be a problem later.

Aha! I switched over to XML::FeedPP in the branch unicode_fixes. If it looks good to you, I'll merge.

Ok I think this is fixed ...


Allow % based configuration of max workers

Summary
We have various machines in use between 4-16 threads but we always need to have spare threads available for other things like puppeteer/chrome. Doing this will allow simple --maxWorkers=50% to always have spare CPU available;
Test plan
$ node ./packages/jest-cli/bin/jest.js getMaxWorkers.test.js
 PASS  packages/jest-config/src/__tests__/getMaxWorkers.test.js
  getMaxWorkers
    √ Returns 1 when runInBand (3ms)
    √ Returns 1 when the OS CPUs are not available (1ms)
    √ Returns the `maxWorkers` when specified
    √ Returns based on the number of cpus (1ms)
    % based
      √ 50% = 2 workers
      √ < 0 workers should become 1 (1ms)
      √ 0% shouldn't break

Test Suites: 1 passed, 1 total
Tests:       7 passed, 7 total
Snapshots:   0 total
Time:        1.315s, estimated 2s
Ran all test suites matching /getMaxWorkers.test.js/i.
Done in 2.96s.

Thoughts @cpojer?

Sure.

LGTM, thanks!


Updated the Rollbar snippet to use the v1.4.4 code which fixes a bunc…

…h of issues, including browser tests.

lgtm. thanks @coryvirok!


Unable to install Ruby 2.6.3 on macOS 10.14.5 Mojave

help me....
This is the first time to install Ruby.
when I run "rbenv install 2.6.3," this happens.
I cannot figure the solution out.
what steps do I have to fix it??
ruby-build: use openssl from homebrew
Downloading ruby-2.6.3.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.3.tar.bz2
Installing ruby-2.6.3...
BUILD FAILED (OS X 10.14.5 using ruby-build 20190423)
Inspect or clean up the working tree at /var/folders/ss/t826qgw50bg9_k1vdfq1q2940000gn/T/ruby-build.20190802010118.21626
Results logged to /var/folders/ss/t826qgw50bg9_k1vdfq1q2940000gn/T/ruby-build.20190802010118.21626.log
Last 10 log lines:
tool/config.guess already exists
tool/config.sub already exists
checking build system type... x86_64-apple-darwin18.6.0
checking host system type... x86_64-apple-darwin18.6.0
checking target system type... x86_64-apple-darwin18.6.0
checking whether the C compiler works... no
configure: error: in /var/folders/ss/t826qgw50bg9_k1vdfq1q2940000gn/T/ruby-build.20190802010118.21626/ruby-2.6.3': configure: error: C compiler cannot create executables See config.log' for more details
make: *** No targets specified and no makefile found.  Stop.

I'm sorry you have had trouble. I don't know what causes this, but see other threads: https://github.com/rbenv/ruby-build/issues/1364 https://github.com/rbenv/ruby-build/issues/1203 https://github.com/rbenv/ruby-build/issues/1193 https://github.com/rbenv/ruby-build/issues/779 https://github.com/rbenv/ruby-build/issues/640 https://github.com/rbenv/ruby-build/issues/353 https://github.com/rbenv/ruby-build/issues/319


Add support for 'new.target'

I'm not sure what a polyfill would look like, but we need to at least parse it.
http://closure-compiler-debugger.appspot.com/#input0%3Dclass%2520foo%2520%257B%250A%2520%2520constructor()%2520%257B%250A%2520%2520%2520%2520if%2520(new.target)%2520%257B%2520%250A%2520%2520%2520%2520%2520%2520this.foo%2520%253D%25201%2520%250A%2520%2520%2520%2520%257D%250A%2520%2520%257D%250A%257D%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions-runtime-semantics-evaluation
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-built-in-function-objects

ctrl-F for new.target in the spec doesn't find anything particularly readable. http://www.2ality.com/2015/02/es6-classes-final.html has a much clearer explanation.

I'm inclined to make new.target a token. Does that seem reasonable?

Is new   .    target syntactically valid? If so it might be easier if the new and the . and the target are all separate tokens.

Tyler, are you proposing that we make it a getprop? AFAICT, we'll never treat new.target as a property access, it is its own separate thing, it just happens to have a dot in its name. But it should probably be a separate token.

 Once we're done parsing, Token.NEW_TARGET probably makes sense.

OK, cool, we're on the same page then.

I was thinking in terms of a lexer token, but upon reflection and looking
at the spec, I won't do that.
Creating a Node with type = Token.NEW_TARGET makes sense, though.
On Fri, May 6, 2016 at 9:51 AM Dimitris Vardoulakis <
<EMAIL_ADDRESS>wrote:

OK, cool, we're on the same page then.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/google/closure-compiler/issues/854#issuecomment-217496344


[SPARK-13823][HOTFIX] Increase tryAcquire timeout and assert it succeeds to fix failure on slow machines

What changes were proposed in this pull request?
I'm seeing several PR builder builds fail after https://github.com/apache/spark/pull/11725/files. Example:
https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test/job/spark-master-test-maven-hadoop-2.4/lastFailedBuild/console
testCommunication(org.apache.spark.launcher.LauncherServerSuite)  Time elapsed: 0.023 sec  <<< FAILURE!
java.lang.AssertionError: expected:<app-id> but was:<null>
	at org.apache.spark.launcher.LauncherServerSuite.testCommunication(LauncherServerSuite.java:93)

However, other builds pass this same test, including the test when run locally and on the Jenkins PR builder. The failure itself concerns a change to how the test waits on a condition, and the wait can time out; therefore I think this is due to fast/slow machine differences.
This is an attempt at a hot fix; it's a little hard to verify since locally and on the PR builder, it passes anyway. The change itself should be harmless anyway.
Why didn't this happen before, if the new logic was supposed to be equivalent to the old? I think this is the sequence:

First attempt to acquire semaphore for 10ms actually silently times out
The changed being waited for happens just after that, a bit too late
Assertion passes since condition became true just in time
release() fires from the listener
Next tryAcquire however immediately succeeds because the first tryAcquire didn't acquire anything, but its subsequent condition is not yet true; this would explain why the second one always fails

Versus the original using notifyAll(), there's a small difference: wait()-ing after notifyAll() just results in another wait; it doesn't make it return immediately. So this was a tiny latent issue that was masked by the semantics. Now the test asserts that the event actually happened (semaphore was acquired). (The timeout is still here to prevent the test from hanging forever, and to detect really slow response.) The timeout is increased to a second to allow plenty of time anyway.
How was this patch tested?
Jenkins tests

Test build #53319 has started for PR 11763 at commit dac7205.

Test build #53319 has finished for PR 11763 at commit dac7205.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53319/
Test PASSed.

I'm going to merge so I can see if this resolves the failures on the QA test pull request builder.


Sorting not working Intergrate with datatable

I m sorry for my bad english. But I have following issue.
My sorting not working when intergrate with datatable.
It's work well after initation, but when i resized window then it became to not good (just only in Edge Windows 10). the same state when i tried sample on homepage (http://mkoryak.github.io/floatThead/datatables/).

and it works fine in Chrome and firefox on windows 10?
This will take me a while to reproduce - I currently do not have windows 10 / edge.
you can try the follow code which may fix the issue for you:
$(function(){
   var $table = $(.... your table selector ...);
   $(window).on('resize', function(){ $table.triggerHandler('reflow'); });
});

Thanks for reply soon.
It works fine on Chome and IE11 on Windows 10. But not works in Edge.
I put your code in my source but it cant resolve.
Actually, if use $table.trigger('reflow'); then the same error still occurs.
Thanks for  supporting.

I think The click event on thead was lost when reflow, but i dont know how to fix it.
Thanks

i remember this. I think there was a reason for using prepend vs append - i need to look into this more. this change could break a lot of other browsers

Yes, maybe break a lot of other browsers, i think too.
Thanks for replying and i m waiting for new version.

sorry, highly unlikely that i am going to work on this unless more people have this issue. I will accept a PR that was tested on all browsers if you have a fix like that on hand.


feat: add rule no inline styles

Summary
A new rule was added and the respective documentation was also added.
Related Issues
#206
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation update

The PR ci failed, please check the details 👀

Its failing because you didn't add the reportNoInlineStyles to the rulesReport.ts file ⬇

You can check details by running yarn rules:missing


Typos and recursive dataset structure in utils.bench

Directory structures like:
root
  - train
    - img01
    - ...
  - val
    - img01
    - ...

are currently not supported by the utils.bench module. I added an os.walk() to recursively build a file list.
Misc changes:

Typos
Added a missing abstract method implementation in BinaryCodec
Added .idea to .gitignore for PyCharm users

Hey, thanks for the PR. We'll probably want to propose some minor change. I'll review it soon.

Thank you for the PR! We'll push the changes soon.


Looking forward to get involved and contribute to the community 🎉

First Name
Ayan
Last Name
Gupta
Discord Username (if applicable)
No response
Let us understand your motive.
To learn and grow

Hey @Ayan-thecodeking 👋🏻
Thanks for requesting an invite! Welcome to SidHacks Community 🎉
Before going ahead, I would want you to complete the below To-Do list.
Your To-Do List ✔

Accept the invitation sent to you via mail.
Change the appearance of this organization to "Public" from the people list here.
Join our Discord Server here.

Accept the Rules from #📓〡rules channel.
Introduce yourself to our community in 👋〡introduction channel.

Feel free to share your excitement on socials with #SidHacksCommunity. You can also tag me @siddharth_hacks.

Close this issue once you complete all the above points.

Looking forward to interacting with you in our community! Welcome once again! 🤓


Create sub-packages: desktop, web

To expand: we don’t need to publish desktop or web on NPM, and we don’t need to support “dev” mode for core. But we do want to lint and compile all.


Inject AggregatedHttpMessage into a DynamicHttpFunction method automatically

Motivation:
AggregatedHttpMessage is useful for the most cases of restful API.
So it is better to aggregate stream messages automatically and inject the aggregated message into a DynamicHttpFunction method.
Modifications:

Inject AggregatedHttpMessage into a DynamicHttpFunction method automatically.
Support AggregatedHttpMessage as a return type.

Result:
Fixes #562.

@trustin Thanks!

Could you add a test case that make sure that the method like the following is not accepted?
public HttpResponse method(HttpRequest req, AggregatedHttpMessage aReq);

Currently the case you mentioned is accepted. I think it's better to deny that case while building a service. I will fix it!

Also, what do you think about handling the case where the return type is AggregatedHttpMessage? e.g.
public AggregatedHttpMessage handle(AggregatedHttpMessage req);

Handling AggregatedHttpMessage as a response has not been covered until now. I will try to figure out how to handle it.

Handling AggregatedHttpMessage as a response has not been covered until now. I will try to figure out how to handle it.

It's up to you. You can take care of it in a separate PR if you want.

@trustin I fixed DynamicHttpFunctions.convert methods to support AggregatedHttpMessage as a return type. I'm not sure this fix is the best, please take a look on it and let me know if you have any concerns.

Thanks, @hyangtack!


AntiBot/Minion not found

i test the serverScrambleLevel in 1, 2 , 3, and not found
AgarioPowerups worked on 3 level's :/
FIX THIS PLEASE

@Jhair2015 I will work on this.

@Megabyte918 Are you adding Pellet Mode? xD just asking not forcing

Hmm , agario powerups just duplicates the playercell . so we need an option that only allows one IP per player

serverIpLimit = 2
serverMinionIgnoreTime = 5
serverMinionThreshold = 5
serverMinionInterval = 500
serverScrambleLevel = 3
playerBotGrow = 0


Dependencies: Upgrading packages

Upgrading Packages
Current as of 2020-01-04

Outdated and not merged. Closing and we'll re-do it with more current code


optionally restrict scheme type

See https://github.com/coreos/alb-ingress-controller/compare/master...r0fls:restrict-scheme-configmap?expand=1#diff-76e731333fb756df3bff5ddb3b731c46 for a description of the changes.

@r0fls, we'll need to update some of the annotations tests based on the new function signatures
https://travis-ci.org/coreos/alb-ingress-controller/builds/336374451?utm_source=github_status&utm_medium=notification


best effort backup and bootstrap backup to different directory

Issue #, if available:
Description of changes:
Updating first workload cluster backup to be best effort. Will first attempt a backup with no cluster filter, then backup with filter if that fails.
Added a check to only take bootstrap cluster backup if bootstrap cluster reference is not nil. Also updated bootstrap backup to not overwrite workload backup and instead write to a separate folder.
Testing (if applicable):
unit tests added
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherrypick release-0.17