Pytest requirement not compatible to python3.7

EDIT
I just noticed the info on the system requirements for pycsw which states that python 3.5 is supported. Strangely the PEP479 has been introduced on python3.5.
EDIT-EDIT
Even more strangely, your travis server runs the python 3.7 tests absolutely fine.
Description
While I was working on some code related to #617 I tried to run the already existing tests using
py.test

I faced some errors unrelated to the tests themself, but rather some strange StopIteration and NoneType issues:
=========================================================================================================== test session starts ===========================================================================================================
platform linux -- Python 3.7.3, pytest-3.0.3, py-1.8.1, pluggy-0.4.0
rootdir: /home/****/PycharmProjects/pycsw, inifile:
plugins: timeout-1.2.0, flake8-0.8.1, cov-2.4.0
collecting 474 items / 1 errors
================================================================================================================= ERRORS ==================================================================================================================
_________________________________________________________________________ ERROR collecting venv/lib/python3.7/site-packages/importlib_metadata/tests/test_api.py __________________________________________________________________________
venv/lib/python3.7/site-packages/_pytest/python.py:172: in pytest_pycollect_makeitem
    raise StopIteration
E   StopIteration

The above exception was the direct cause of the following exception:
venv/lib/python3.7/site-packages/_pytest/runner.py:163: in __init__
    self.result = func()
venv/lib/python3.7/site-packages/_pytest/main.py:460: in _memocollect
    return self._memoizedcall('_collected', lambda: list(self.collect()))
venv/lib/python3.7/site-packages/_pytest/main.py:331: in _memoizedcall
    res = function()
venv/lib/python3.7/site-packages/_pytest/main.py:460: in <lambda>
    return self._memoizedcall('_collected', lambda: list(self.collect()))
venv/lib/python3.7/site-packages/_pytest/python.py:404: in collect
    return super(Module, self).collect()
venv/lib/python3.7/site-packages/_pytest/python.py:318: in collect
    res = self.makeitem(name, obj)
venv/lib/python3.7/site-packages/_pytest/python.py:330: in makeitem
    collector=self, name=name, obj=obj)
venv/lib/python3.7/site-packages/_pytest/vendored_packages/pluggy.py:745: in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
venv/lib/python3.7/site-packages/_pytest/vendored_packages/pluggy.py:339: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
venv/lib/python3.7/site-packages/_pytest/vendored_packages/pluggy.py:334: in <lambda>
    _MultiCall(methods, kwargs, hook.spec_opts).execute()
venv/lib/python3.7/site-packages/_pytest/vendored_packages/pluggy.py:613: in execute
    return _wrapped_call(hook_impl.function(*args), self.execute)
venv/lib/python3.7/site-packages/_pytest/vendored_packages/pluggy.py:250: in _wrapped_call
    wrap_controller.send(call_outcome)
E   RuntimeError: generator raised StopIteration

Many articles or posts identified the problem's source in an incompatibility between 'old python style' and python 3.7due to the  PEP479 change from 2014:

Python 3.7: StopIteration could be your next headache
Github Bmap-Tools Issue
Stackoverflow

As seen in the error message above, the error source is located in the pytest package, which is still sticking to version 3.0.3 according to the requirements-dev.txt.
Removing this version constraint/changing it to the latest release, as well as for the related plugins underneath, fixes this error for me and the tests are starting.
Environment

operating system: Deb10 Buster
Python version: 3.7
pycsw version: 2.4.2
source/distribution

[x] git clone
[ ] DebianGIS/UbuntuGIS
[ ] PyPI
[ ] zip/tar.gz
[ ] other (please specify):

web server

[ ] Apache/mod_wsgi
[ ] CGI
[x] other (please specify): simple wsgi for dev purposes

Steps to Reproduce

Set up venv using python 3.7
Set up fresh cloned source code
Try to run py.test

Additional Information
None

The harvesting pytest checks gave me a nice headache. There are 23 tests - all from the harvest test suite - which do not run properly.
Since I knew from your travis server, that the tests have to run fine I took a look on your test calls over there and you seem to skip the harvesting tests using
 -k 'not harvesting'

Not gonna critizice, I just would like to know why is that? I get some 404 or Bad Gateway errors on the tests you are skipping there.

The reason why we are skipping the harvesting tests is because they deal with remote resources, which, from a continuous integration perspective, may or may not be available.  We can/should mock out the harvesting tests IMHO to run them with consistency.

So, while tests are running fine on Travis (for Python 3.5, 3.6 and 3.7), they fail on your local dev machine, using the same requirements-dev.txt? Indeed seems weird.
From what I can see, Travis is running Python 3.7.6 while you have v3.7.3 - I would think that would not be so relevant though.
I've made a quick pytest run on my local machine (Ubuntu 20.04, with Python 3.8.2) and I could run all non-harvest tests without any problem.
cd ~/dev/pycsw
python3 -m venv ./test_venv
source test_venv/bin/activate
pip install -r requirements-dev.txt
pip install -e .
cd tests
pytest -v -x -k 'not harvesting'
...
=== 438 passed, 36 deselected in 30.59 seconds ===

# running all tests, including harvesting
pytest -v
...
=== 21 failed, 453 passed in 144.53 seconds ===

Could this be something on you local env?
Regarding not running the harvesting tests on Travis (which we should track as a different issue), as @tomkralidis says, it is not something we are too proud of, and the eventual plan is to do a proper mock of these external services. Not having these constantly running in CI is a perfect way to let them rot, as can be attested by my own local test run, which shows 21 fails, all are harvesting-related.
In fact, the same could be said about us not running Travis tests against a postgresql database, which I think is more representative of a typical production environment.
Seems like a good place for some extra help, from someone who is test-savvy, if you catch my drift :wink:
Anyway, jokes aside, I think this is definitely something that should be improved upon.

Hey guys,
thanks for your replies! Since I moved on a while after opening this issue, I do not have the same setup right now to check again, sorry.
But when it runs on all your machines fine - beside the harvesting tests - , it surely must be something on my machine.

Seems like a good place for some extra help, from someone who is test-savvy, if you catch my drift wink

Oh dear, look at the time, I will miss that really important thing that I have to attend if I won't go now. :smile:
Thanks for your time and good luck on solving the remote test data task ;)


Using objects for handler implementations

As mentioned in #365 (here), it should be possible to use objects as handler implementations.
// ...

def handler = new Handler {
  def catch[R]{ p: => R / Exc } { h: String => R } =
    try { p() } with Exc {
      def raise[A](msg) = h(msg)
    }
}

def main() = try { p() } with handler;

Currently, this is not possible but should be for tail-resumptive operations.

Related to #252

def main() = {
  with x = handler;
  p()
}

desugars to
def main() = {
  handler { x =>
    p()
  }
}

def main() = {
  with {cap} = handler;
  p()
}

should desugar to
def main() = {
  handler { {cap} =>  // still explicit...
    p()
  }
}


Add support for static and transitive modifiers of 'requires' in module-info

Fixes #144

Codecov Report

Merging #145 (7da11c1) into develop/1.9.0 (168a24c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##             develop/1.9.0     #145      +/-   ##
===================================================
- Coverage            77.59%   77.58%   -0.01%
- Complexity            7665     7668       +3
===================================================
  Files                  201      201
  Lines                24261    24266       +5
  Branches              6342     6344       +2
===================================================
+ Hits                 18825    18827       +2
- Misses                3526     3530       +4
+ Partials              1910     1909       -1

Impacted Files
Coverage Δ

.../jetbrains/java/decompiler/code/CodeConstants.java
80.95% <ø> (ø)

...rg/jetbrains/java/decompiler/main/ClassWriter.java
72.99% <100.00%> (+0.14%)
:arrow_up:

...org/jetbrains/java/decompiler/util/TextBuffer.java
64.86% <0.00%> (-1.23%)
:arrow_down:

...decompiler/modules/decompiler/stats/Statement.java
80.83% <0.00%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168a24c...7da11c1. Read the comment docs.


prevent download when dependencies already exists

I don't know if i'm using bower correctly but when I do bower install it always redownload all dependencies even if they already exists on my bower components directory.
How can I prevent this behaviour?
Thanks in advance.

By default it should download only new components. Maybe you're using old bower version? You can use --offline flag to force using offline cache for packages. It's generally to better ask support questions on Stack Overflow.


freebayes-parallel, no output and no error

Hi,
I am running freebayes-parallel but never get any output in the vcf file. There are no errors, top shows the correct number of processors being utilized and resources (cpu, memory), but the output file remains empty. I tried running with --debug, but didnt find any extra output. If I run freebayes, without parallel, everything behaves as expected. This is most likely something with my specific system, but wanted to toss the question in case others are having a similar issue or solution.
OS: Red Hat Linux release 7.3 (Maipo)
freebayes version: v1.10
gnu parallel version: 20160122
gcc: 5.2.0
cmake: 3.4.1
Command tried 1
bamtools coverage -in bam | coverage_to_regions.py ref.fa.fai 500 > ref.fa.500.regions
then,
freebayes-parallel ref.fa.500.regions 20 -f ref.fa  --use-best-n-alleles 6 --genotype-qualities --min-alternate-count 2 --min-repeat-entropy 1 --no-partial-observations --max-coverage 500 --bam-list fb.bamlist --populations fb.poplist > fb.par.20.vcf
Command tried 2
freebayes-parallel <(fasta_generate_regions.py ref.fa.fai 100000) 36 -f ref.fa OPTIONS

I have the same problem and looked into it.
It looks like the freebayes-parallel script was modified to add some local paths, which break the pipes if you are in any other folder:
"| ../vcflib/scripts/vcffirstheader
| ../vcflib/bin/vcfstreamsort -w 1000"


Copy symbolic errors when composing

Fixes #87.

Another one for you to review, @AaronLasseigne. This suffers from the same problems mentioned in https://github.com/orgsync/active_interaction/pull/194#issuecomment-43345208, but I think the tradeoffs are worth it.
I think #245 could provide a better long-term solution for this. I don't want to let perfect be the enemy of good, though.

It looks good and what we currently do is (as you pointed out) not very good. I think we just need to mention some of these sharp edges in the docs.

Should I add that to the "Errors" section or the "Composition" section?

Probably the "Errors" section and then link to it from the "Composition" section. Does that sound reasonable?

:+1:

I updated the documentation.

:shipit:

This is a breaking change, so it'll need to be merged into a branch for v3.0.0.

True.


[Question] Why not just use encodeURI?

i fail to see why someone would want to use this rather than using just the built in encodeURI / encodeURIComponent.
Could you give an example / use case what this lib dose differently and what it's trying to solve that encodeURI / encodeURIComponent dose not?
Thanks.

I mean, it just does what it says in the README, so as long as that is your use case, then that's what it is for. It was my use-case at least. If you don't need to use this and want to use the built in encoding functions, I have no objections. Not sure why I have to prove my module has a use case, as I just made it for mine and put it out there if anyone else neede to use it, but I am not forcing anyone to use it.

The encoding this module does most closely matches how the URL constructor works, though was available before URL was added to Node.js (and just works on strings without needing to construct a URL instance). My main use case was to take a URL that one could enter into the web browser location bar and encode it to ASCII-only for putting in to a HTTP header value. The URL constructor does this now, though it has some extra validations and doesn't do a few things like encode % that is not part of a valid sequence (I added that because I felt it was less ambiguous to see %25foo than %foo).

Thanks for the explanation.
I will stick to using URL then.
Maybe it would be worth mentioning using URL in the README instead?

Yea, I can do that. What should it say, exactly? I am not familiar with the exact URL algorithm since this was not based on it, instead it was based on encodeURL. Just from some light testing they this module doesn't work exactly the same, so probably would need to list out how it is different, just like how it mentions encodeURI and what the differences are between thos module and that.

Yea, would need to actually figure out the something something something before I add anything to the README otherwise it will just lead to more confusion. I only just looked in to the URL constructor after your issue was made and noticed they seemed to maybe be the same? I really don't know all the details and if it is possible to move. Just using this module's own tests as a guide it seems to be different in a bunch of ways. This module was just me fixing encodeURI to be what I wanted; it was not made in order to backport URL constructor encoding or anything, as I wasn't even aware of that until just today, so that normative seems misleading to include, as it would imply that this module was some how supposed to be like URL, though it wasn't. I'm very much not comfortable stating in the README that it "dose pretty much the same thing" because I have no idea is that is true without actually looking at the algorithm.

So at best it should just say exactly how it is different, not state to use one over the other, as they don't work the same way.

if that's the case. then yea maybe it would be better to highlight the differences. i just suggested it cuz you said

"The encoding this module does most closely matches how the URL constructor works"

Could also mention that URL is only available in NodeJS v10+
Some known ports get stripped out for normalization
new URL('https://localhost:443')+'' // https://localhost
new URL('http://localhost:80')+'' // http://localhost

Yea, sorry, it is a holiday here so I am mostly mobile and when i first looked at URL constructor it, at the time of my comment, did seem to most closely match it. But as I have been digging in, there are actually more differences between this module and the URL constructor than this module and encodeURI function. Seems like there are a LOT of differences between this and URL constructor in fact. Seems you gound yet another one. I was probably incorrect to suggest the URL constructor as an alternative in my comment, I apologize, I was misunderstanding the URL constructor.

That's alright.
I'm not going to push you any further to suggest to folks that they should change to using URL instead and that you change the README
What you decide to do or not do is up to you.
I only wanted to know the reasoning behind why the need for this package exist.
Only wanted to know if this would bring me any usefulness into my own application / library.
Enjoy your holiday 👋


Is there any Lucene.NET object mapper?

Hello,
Is there an efficient Lucene.NET object mapper?
Best Regards,

While this is something I wanted to do before the 4.8.0 release, it probably isn't going to make the cut unless it is contributed by the community.
Since Lucene.NET 4.8.0 is still a pre-release, most of the ORM tools out there are not compatible with the latest beta so would need to be recompiled at the least and possibly have some design changes to be compatible.

LukeMapper - Hasn't been updated since Lucene.NET <IP_ADDRESS>, but takes an interesting Dapper-like approach to generate efficient code. More info here.
Lucene.Net.Linq - Hasn't been updated since Lucene.NET 3.0.3. More about it here.
Flucene - Hasn't been updated since Lucene.NET 3.0.3.
Lucene.Net.DocumentMapper - compatible with 4.8.0-beta00016
Lucene.Net.ObjectMapping - Hasn't been updated since Lucene.NET 3.0.3.
Lucene2Objects - Hasn't been updated since Lucene.NET 2.9.2. More info here.
LuceneNetExtensions - Hasn't been updated since Lucene.NET 3.0.3.
ActiveLucene.Net - Hasn't been updated since Lucene.NET 3.0.3.
LrNet.Lucene.Fluent - Hasn't been updated since Lucene.NET <IP_ADDRESS>.

This list may not be everything that exists, but this should get the ball rolling. Unfortunately, since I haven't experimented with any of these libraries, I cannot tell you how they perform or how easy they are to use.

If anyone wants to experiment with these and come up with an approach that we can use to either integrate using partial classes in the Support folder or extend Lucene.NET with another NuGet package, please join the discussion. Ideally, whatever approach is taken would have both an attribute-based and a fluent API configuration, similar to Entity Framework.

LukeMapper uses Reflection.Emit to generate on-demand MSIL code at runtime, which it compiles and caches after the first hit. This is a very good approach that will have a small impact on runtime performance.
However, the object mapping could potentially be made into a compile-time source generator, which would eliminate the need for the initial runtime compile and cache. In other words, there would be absolutely no runtime performance impact because it would generate the cumbersome-to-maintain code based on the easy-to-maintain configuration, which would be compiled into the end user's assembly. There is an extensive list of source generators being maintained where various approaches to source generation can be analyzed.
LukeMapper's entry point is on IndexSearcher. IndexSearcher may be used with SearcherManager to make it threadsafe, which should be taken into account in the design.


Upgrade to<EMAIL_ADDRESS>to get rid of the node-uuid deprecation

And also update vow to get it up to date with vow-fs.
https://github.com/dfilatov/vow-fs/blob/master/package.json#L18

Thanks.

❤ you're welcome


Improves the profile picture Layout on resizing

This PR improves the current bug of profile image resizing issue due to different screen resolution. Now the profile pictures at the top, won't overflow when the screen is too narrow, or there's too many pictures!
Fixes #12

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

LGTM!


Add reconnect retry and longer timeouts for verisure

Description:
Add reconnect retry and and longer reconnect timeouts to handle the wrong error messages from verisure mypages.
I have been running this for a while and it has been working so far.
Related issue (if applicable): #
#1289
Checklist:
If code communicates with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Looks good! :dolphin:


1682cost

Since cost is working, no reason why it shouldn't live in 1682 master.

Merged via command line.

I don't think that got pushed.

You were right.  Not sure what happened.  Just pushed it now.


[SPARK-32440][CORE][TESTS] Make BlockManagerSuite robust from Scala object size difference

What changes were proposed in this pull request?
This PR aims to increase the memory parameter in BlockManagerSuite's worker decommission test cases.
Why are the changes needed?
Scala 2.13 generates different Java objects and this affects Spark's SizeEstimator/SizeTracker/SizeTrackingVector. This causes UT failures like the following. If we decrease the values, those test cases fails in Scala 2.12, too.
$ dev/change-scala-version.sh 2.13
$ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none -DwildcardSuites=org.apache.spark.storage.BlockManagerSuite
...
- test decommission block manager should not be part of peers *** FAILED ***
  0 did not equal 2 (BlockManagerSuite.scala:1869)
- test decommissionRddCacheBlocks should offload all cached blocks *** FAILED ***
  0 did not equal 2 (BlockManagerSuite.scala:1884)
...
Tests: succeeded 81, failed 2, canceled 0, ignored 0, pending 0
*** 2 TESTS FAILED ***

Does this PR introduce any user-facing change?
No.
How was this patch tested?
$ dev/change-scala-version.sh 2.13
$ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none -DwildcardSuites=org.apache.spark.storage.BlockManagerSuite
...
Tests: succeeded 83, failed 0, canceled 0, ignored 0, pending 0
All tests passed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31175/
Test PASSed.

cc @srowen

Test build #126555 has started for PR 29238 at commit 3c896e9.

Thank you for review, @srowen . Currently, GitHub Action sparkr test seems to be broken. I'll wait for Jenkins result.

I'll merge this this is a test only PR on core module and it passed in GitHub Action. sparkr failure is irrelevant to this one.
Merged to master.

Test build #126555 has finished for PR 29238 at commit 3c896e9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126555/
Test PASSed.

LGTM

Thank you, @HyukjinKwon .


[New Port Request] intel media sdk

Library name: intel media sdk
Library description: Intel® Media SDK provides a plain C API to access hardware-accelerated video decode, encode and filtering on Intel® Gen graphics hardware platforms.
Source repository URL: https://github.com/Intel-Media-SDK/MediaSDK
Project homepage (if different from the source repository): https://software.intel.com/content/www/us/en/develop/tools/media-sdk.html
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Add Rack instrumentation

Overview
Adds rack instrumentation adapter implementation, ported from existing dd-trace-rb functionality.
rack instrumentation is required by rails instrumentation, which does not exist yet.
Details

adds a working example, runnable via docker-compose, e.g.,

docker-compose run --rm ex-adapter-rack
bash-5.0$ ruby trace_demonstration.rb

adds functionality to trace 'front-end' request (queue time) and retain middleware names
QueueTimeimplementation is directly from dd-trace-rb
config options include:retain_middleware_names, :allowed_response_headers, :allowed_request_headers

Related

#67 - port datadog instrumentation
#148 - faraday instrumentation
#149 - sinatra instrumentation

@mwear Thank you for that last round of feedback!  I believe I have addressed and resolved the points you mentioned.

Hey @mwear , thanks for that last round of suggestions!  I think I've resolved the points so far.
Notable outstanding is the error handling (i.e., "record and re-raise").

Last call for comments. It'd be nice to merge this tomorrow after the SIG meeting.

I've resolved the merge conflicts.

The conflicts are back.

conflicts: resolved. :smile:

I approved. I'll still extract my comment to an issue, since I think the spec will have to address this at some point, and we may need to revisit. This is 👍 for now tho.


"report" command not working / is it still valid?

This looks like it initially was intended to be used perhaps towards some "verify" command; however, it is not used anywhere within the code and invoking it via the command line results in an exception.
$ ./wskdeploy report
----==== OpenWhisk Deployment Status ====----
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x13b928e]

goroutine 1 [running]:
github.com/apache/incubator-openwhisk-wskdeploy/cmd.printDeploymentInfo(0x0, 0x0, 0x1671240)
	/Users/Matt/go/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/report.go:86 +0x8e
github.com/apache/incubator-openwhisk-wskdeploy/cmd.glob..func6(0x16a2fa0, 0x16c2c58, 0x0, 0x0, 0x0, 0x0)
	/Users/Matt/go/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/report.go:49 +0x9e
github.com/spf13/cobra.(*Command).execute(0x16a2fa0, 0x16c2c58, 0x0, 0x0, 0x16a2fa0, 0x16c2c58)
	/Users/Matt/go/src/github.com/spf13/cobra/command.go:650 +0x457
github.com/spf13/cobra.(*Command).ExecuteC(0x16a31e0, 0xc4200aff78, 0x100670c, 0xc420072058)
	/Users/Matt/go/src/github.com/spf13/cobra/command.go:729 +0x339
github.com/spf13/cobra.(*Command).Execute(0x16a31e0, 0x0, 0x0)
	/Users/Matt/go/src/github.com/spf13/cobra/command.go:688 +0x2b
github.com/apache/incubator-openwhisk-wskdeploy/cmd.Execute()
	/Users/Matt/go/src/github.com/apache/incubator-openwhisk-wskdeploy/cmd/root.go:66 +0x40
main.main()
	/Users/Matt/go/src/github.com/apache/incubator-openwhisk-wskdeploy/main.go:26 +0x20

We should discuss if this is still valid/valuable... if it is we need to make it work OR remove it.  At minimum we should disable it in the near term.

@mrutkows This is an obvious bug, which needs a quick fix.


PlaywrightServiceProvider introduction

Easy approach to use PageObjects via DI in testclass. Including handy helpers and extensions. Should become template project for new ui test automation projects

Can you write an explanation about the introduced concepts to the readme.md?


JSON access log has trailing ; on UPSTREAM_CLUSTER

It was not updated to use UPSTREAM_CLUSTER_RAW like the non-json format. Probably unintentional?
cc @keithmattix

Yeah I just missed this. If someone can get to it before me, knock yourself out, otherwise I'll push a PR when I'm back next week

https://github.com/istio/istio/pull/54224


Feature Request: User's associated subuser #209

Figure I would update this since I applied this change myself. The formatting of the user itself on the Users > View page is missing some table fields for the subuser.
Because of this, "Subuser" shows in the "Nodes" column and the actual node gets moved to the right. Figured it was worth mentioning for aesthetics before the next full release.

#209

Looks fine on my end.


Not streaming with Apache and PHP-FPM...

HI,
I have the plugin set up running on a local dev machine fine, but when on our staging server no events are received by the browser (tested on chrome and firefox osx).
I needed to add this to the flush mthod...
    public function flush()
    {
        echo str_pad(' ', 2048, ' ');
        echo PHP_EOL;

        @ob_flush();
        @flush();
    }

Its on Apache and PHP-FPM and I cant see any way to disable output buffering like you can on nginx.....
is there a nicer work around to this?   chunked response maybe?

You should turn off the proxy buffer, so that the data would send to the client as soon as it arrive the server.
For apache please set the ProxyIOBufferSize and ProxyReceiveBufferSize in mod_proxy_fcgi to be 512 as apache force to have at least 512.
You may refer to here.
Replacing Apache with nginx would help much as it allow completely disable the buffer.

Yeah, nginx would be better, but that will have to wait!  Cheers for the response.


Which log format should I use?
Thanks

Hi @iranbingo
You need a custom LogFormat...
Maybe you can try this, at goaccess.conf:
date-format %d/%b/%Y
time-format %H:%M:%S
log-format %^[%d:%t %^] "%m %U" %s %b "%^" "%^" %h
A unique problem will be parse correct URL because you have 2 distinct case -- i.e. with HTTP/1.1 and without protocol.
Do you have some solution for that, @allinurl ?
Note:
You can disable Panel/Chart that LOGFILE not have any info.
In this LOG, add or uncomment the follow options:
ignore-panel OS
ignore-panel BROWSERS
ignore-panel REFERRERS
ignore-panel REFERRING_SITES
ignore-panel KEYPHRASES

Hi,
I used -no-ip-validation with File Format Combined and it worked.
Thanks,

Hi @iranbingo
But, It is not be process LOGFILE correctly.
See output HTML in your browser and will be confirm this.

@0bi-w6n-K3nobi thanks for answering that. You raised a good point, you have two log formats in there. Right now there's no way to parse both of them. I believe we have that in the to-do list. A workaround will be to pre-process the log and either strip that with awk/sed or artificially add it to each line if it doesn't exist. If it's not important to you @iranbingo, I'd personally leave it off.

Hi @allinurl
Thanks for the answer. Yes, I also wish that my log files are analyzed correctly. How can I determine whether the analysis went correctly or incorrectly?
since goaccess shows no errors and analyzes logs quickly and easily with --no-ip-validation.

Hi @iranbingo
Maybe you can look the Chart/Data called Visitor Hostnames and IPs.
And you concluded that parse had been wrong, or partially wrong.
Maybe here be off-topic @allinurl , but ... Did you think about a "optional" field, like a regular-expression?
Possibility, it will be resolve several problems include strange date formats.


Updated Camljs.d.ts to 2.5.2 version of the Camljs library

@andrei-markeev thanks mate!

Thank you!


Schema: update readme for how to validate manually

The latest go is using gomod, but the repo has no go.mod,
adding GO111MODULE=off to disable gomod and build it locally.
Signed-off-by: bin liu<EMAIL_ADDRESS>

oh thanks, @liubin. I think this PR is obsoleted by #1084
Closing. Let me know if it is still an issue for you.


@web3uikit/web3 not working anymore in react/nextjs

As moralis is updating to v2 lots of user had to stay to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>for beeing able to use last react-moralis functionality. Unfortunately @web3uikit/web3 is throwing a server error:
Server Error
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
I wonder if this is coming because of the use of<EMAIL_ADDRESS>as dependencies on your side?
lots of users are facing same issue and can't use @web3uikit/web3 anymore. Can you have a look at it?
many thanks.

thanks for using the kit and reporting the issue @KMean
can you take a look at this one please @AbhinavMV 🙏

hey @KMean have you seen that you must connect to SDK V1?
https://github.com/MoralisWeb3/changelog/blob/main/2022-08-08-moralis-v1-support.md

In addition to what @BillyG83 mentioned, to use it with react, you should use the following packages:
react-moralis: 1.4.1 (or above)
moralis-v1: 1.11.0 (or above)
moralis-v1 is a copy of the original moralis package. We will use this package for bug fixes on the v1 build.

Unfortunately no one can use that versions as moralis throws an error:
Unhandled Runtime Error
TypeError: Right-hand side of 'instanceof' is not callable
this came up already a lot on the moralis forum and on discord and it looks like the only way to fix it is reverting to<EMAIL_ADDRESS>using moralis-v1 is fine but @web3uikit/web3 is throwing another error:
NoMoralisContextProviderError: Make sure to only call useMoralis within a
of course my app is wrapped by a MoralisProvider so it should work.
can you try and replicate the issue?

Hey @AbhinavMV can you have a go at recreating this issue when you are free please? I'm on the FE 2.0 build and the Ending Legacy Epic right now 🙏

Hey @KMean,
I tested this by creating a react and nextjs app and it seems to be working with following package versions.
    "@web3uikit/web3": "^0.1.5",
    "moralis": "1.11.0",
    "react-moralis": "1.4.0",

Please don't upgrade react-moralis to 1.4.1 yet, that's where I am facing the issue TypeError: Right-hand side of 'instanceof' is not callable

tried it with no luck:

It seems to be working for me with all the packages from your package.json file.

Could you try deleting node_modules folder and package.lock.json and do npm install again... @KMean ?

Hey @AbhinavMV ,
thanks for trying to replicate the error. I tried also starting from scratch and I got the same error:
https://user-images.githubusercontent.com/5776449/184686698-6fcaeb5e-c37f-43e8-9dc0-ec00b20ae4e9.mp4

hey @KMean I am sorry, this really sucks that it is not working for you. Unfortunately this is an open source project and @AbhinavMV has only a small amount of his time allocated to this. We mostly work on it on our own time.
So if the project works for Ahbinav with this setup
"@web3uikit/web3": "^0.1.5",
"moralis": "1.11.0",
"react-moralis": "1.4.0",

that is about all we can do amigo, so sorry. If we look into every dependancy of dependancy in every framework issue, its a full time job that we do not have.
At this point I would have to ask you to dig into it yourself and if you find the problem or a fix please share it with everyone on Discord. 😞
Thanks so much for trying the kit, if you can help us improve it we would be so grateful to have you as a contributor on this open source project

Hey @BillyG83, I understand... as far as i know most people facing same issue decided to remove the kit and implement moralis functionalities from scratch... at the end is not difficult to create a button and code the auth part of it. Was nice because especially at the beginning of a project you need quick implementations to try things out but it's ok. Still using the rest of your kit. If I'll have time to investigate more I'll let you know.
Thanks.

For those that still facing this issue, I noticed that this is fixed with the latest version of react-moralis (1.4.2):
    "moralis-v1": "^1.11.0",
    "react-moralis": "^1.4.2",
    "web3uikit": "^1.0.4"

thanks @stiucsib86 very nice of your to chip in here
hey @KMean is it ok for us to close this now my friend?
TY both for using a kit 💚

thanks @stiucsib86 very nice of your to chip in here
hey @KMean is it ok for us to close this now my friend?
TY both for using a kit 💚

Yes, thank you. Keep up the good work 💪

Unfortunately on one can use that versions as moralis throws an error:
Unhandled Runtime Error
TypeError: Right-hand side of 'instanceof' is not callable
this came up already a lot on the moralis forum and on discord and it looks
like the only way to fix it is reverting to @.***
using moralis-v1 is fine but @web3uikit/web3 is throwing another error:
NoMoralisContextProviderError: Make sure to only call useMoralis within a

of course my app is wrapped by a MoralisProvider so it should work.
can you try and replicate the issue?
Kim Ranzani
Visual Effects Supervisor
https://www.linkedin.com/in/kim-ranzani-0a271216/
https://www.imdb.com/name/nm3915574/
Il giorno lun 15 ago 2022 alle ore 16:18 Erno Wever <
@.***> ha scritto:

In addition to what @BillyG83 https://github.com/BillyG83 mentioned, to
use it with react, you should use the following packages:
react-moralis: 1.4.1 (or above)
moralis-v1: 1.11.0 (or above)
moralis-v1 is a copy of the original moralis package. We will use this
package for bug fixes on the v1 build.
—
Reply to this email directly, view it on GitHub
https://github.com/web3ui/web3uikit/issues/773#issuecomment-1215067087,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMCIQKPJGB7EGZNXOAX333VZJGUHANCNFSM56SKHUTA
.
You are receiving this because you were mentioned.Message ID:
@.***>

hey @KMean we are planning to remove the "Moralis Server" functionality soon and move toward our enterprise facing Moralis 2.0 APIs... so this issue will most likely never be fixed. Sorry for any inconvenience, but NextJS is one of the two Moralis API solutions we will offer with the kit so stay tuned 😁


Use ActiveRecord::Migration[7.0] in migrations

Hey,
First of all, thank you so much for amazing Solid Queue! ❤
Migrations are using version 7.1, but support is provided from Rails 7.0 onwards, so users installing migrations using Rails 7.0 will get an error and will have to manually change the version of the migrations class. This PR fixes that.

Oh, indeed! Great spot 🙏  Thank you!


Git repository disappeared 🤷

Any help on this would be stupendous because it doesn't make sense at all to me.
For, a seemingly non-reason, cap just lost the ability to see my git repo..
00:00 git:wrapper
      01 mkdir -p /tmp
    ✔ 01<EMAIL_ADDRESS>0.245s
      Uploading /tmp/git-ssh-digiramp-production-atebit.sh 100.0%
      02 chmod 700 /tmp/git-ssh-digiramp-production-atebit.sh
    ✔ 02<EMAIL_ADDRESS>0.250s
00:01 git:check
      01 git ls-remote git@github.com:adjustcreative/digiramp.git HEAD
      01 ERROR: Repository not found.
      01 fatal: Could not read from remote repository.
      01 Please make sure you have the correct access rights
      01 and the repository exists.

Caused by:
SSHKit::Command::Failed: git exit status: 128
git stdout: Nothing written
git stderr: ERROR: Repository not found.
fatal: Could not read from remote repository.

I've copied the line git ls-remote git@github.com:adjustcreative/digiramp.git and pasted directly into terminal and get this:
git ls-remote git@github.com:adjustcreative/digiramp.gitatebit:digiramp atebit$ git ls-remote git@github.com:adjustcreative/digiramp.git
fa174f9d90d2b7fdfa20cf921d7e219bfda0d447	HEAD
905ac6f5b57d34c82e6955d503cfa802d43ff3d9	refs/heads/heroku_mods
fa174f9d90d2b7fdfa20cf921d7e219bfda0d447	refs/heads/master
22bee22ded9d347519146f7ea5a646fb7a4cc23e	refs/heads/vultr_mods

The ssh keys are valid, and added to both Github and locally with ssh-add..
Has anyone seen this issue before?

I'm experiencing the same issue on my Ubuntu 20 server after doing an apt-get upgrade. Everything was working well before that. Quite strange.
@atebit Did you find a solution for this?

Okay. I figured it out. On the remote server, a colleague of mine had created a public-private key pair. I deleted them and it worked.


[portsdiff] Optimize for identical commits

There is no need to actually calculate the difference between 2 commits if they are the same.

That's fair, thanks :)


CF Release

Updates
Added

cf-typography: [patch] Add rule to make link lists be medium weight
cf-typography: [patch] Fix whitespace under m-meta-header elements to match vertical grid standards.

Review

@cfpb/front-end-team-admin

I am a bot
After this PR is merged, I will instruct Travis to automagically perform the following steps:

Increment Capital Framework's version per our guidelines.
Add a timestamped entry to the changelog with the new version and its changes.
Tag the release and push it to GitHub.
Publish both capital-framework and any individually updated components to npm.
Update both canary, our development branch, and master, our release branch.

If I do something wrong, blame a human.

Please ignore. Running some EXPERIMENTS.


public image urls requiring token

Bug report
Describe the bug
A clear and concise description of what the bug is.
The docs states that for public buckets, we can access the assets without a token or auth header and we can do so using getPublicUrl.

When accessing public files from storage using getPublicUrl, I get a 404 error, "Not Found".
When copying the url of the asset from the dashboard, I get a url with generated token. When that token is removed, I get "querystring should have required property 'token'"

To Reproduce

Ensure policies for bucket has SELECT access set to public. One way to do this is to use the auto generated 'avatars' bucket when creating a new project. This is the bucket I was using.
Get url of asset by either going to the dashboard and select "Copy URL" from side menu of asset or use getPublicUrl using js api.

Expected behavior
Expected behavior described in docs, where accessing the public asset should not require a token, and using getPublicUrl would return the final url, ready to be stored in db.

Hi @madleo-dk,
Thanks for reporting this. I think this is more an issue with our docs than the actual behaviour itself.
Would you mind checking if the bucket has the public label next to it in the storage explorer?

If your bucket is already set to public and you're still getting this error, please reopen this issue, and I'll investigate further. I'll also make a note to update the docs to reflect this.

I am getting the issue, my bucket is public yet i keep being asked for a token.

I'm getting this error {"statusCode":"400","error":"Error","message":"headers must have required property 'authorization'"}

Same here. Bucket is public, no RLS policies on any tables, yet I have the same issue.

same here.  Bucket is public, no RLS policies on any tables, yet I have the same issue.

For anyone getting this issue, please open a support ticket here since this looks to be project specific

Has anyone solved it?

Anyone solved it ?

Same error here, but figured out when it goes wrong. Basically if you create a bucket, and AFTER creation you switch it to public, it will still require the token.
If during the creation of your bucket, you set from the start, that its a public bucket, no token will be required.
Hope it helps

Same error here, but figured out when it goes wrong. Basically if you create a bucket, and AFTER creation you switch it to public, it will still require the token.
If during the creation of your bucket, you set from the start, that its a public bucket, no token will be required.
Hope it helps

This solved my issue. Guess there's a weird edge case where uploadToSignedUrl is still called after unchecking public.

This solved my issue. Guess there's a weird edge case where uploadToSignedUrl is still called after unchecking public.
Also these docs are wrong, it says the link is https://[project_id].supabase.co/storage/v1/public/[bucket]/[asset-name] when it is actually https://[project_id].supabase.co/storage/v1/object/public/[bucket]/[asset-name], i.e. the link in docs is missing the /object part of the path.

Thanks @ishan0102 , that worked for me.
Even the UI returns the path with a token and not the public one without any token.

Return:  /storage/v1/object/sign/file.txt?token=...
Expected: /storage/v1/object/public/file.txt

Devs, please update the docs and fix this!

Has anyone fixed it yet

In my case the issue was with "Other policies under storage.objects" and "Policies under storage.buckets" in storage > policies.
When I set enable read access for all users to All in  both of them it works.

In my case creating "New Policy" under the bucket worked:
Policy name: Public access
Target roles:  Defaults to all (public)
USING expression:  (bucket_id = 'bucket_name'::text)


Was the response data hijacked after ProductPage requested Reviews?

Was the response data hijacked after ProductPage requested Reviews? Does the response data go directly to ProductPage, or is it hijacked to Envoy? Looking at the iptable rules, I feel that it is hijacked to 15001,15001 how to handle the response data, I do not understand.

please checkout this blogs about how istio work: https://www.solo.io/blog/istios-networking-in-depth/
blogs in chinese: https://cloudnative.to/blog/istio-traffic-management-series-service-management-concept-theory/

please checkout this blogs about how istio work: https://www.solo.io/blog/istios-networking-in-depth/ blogs in chinese: https://cloudnative.to/blog/istio-traffic-management-series-service-management-concept-theory/

That's not my concern. I'm concerned with iptables.

Another question, when I access www.google.com through curl in Sidecar pod, is traffic hijacked to 15001? If so, what did Envoy do?


Root permission required

According to the README [1] is should be possible to run this as non root user as long as bluealsa can write to `/var/run/bluealsa``. I tried that with version 1.1.0 as user bluealsa but it fails not being able to initialize a thread.
 start-stop-daemon --start --exec /usr/bin/bluealsa --user bluealsa --group bluealsa --make-pidfile --pidfile /var/run/bluealsa/bluealsa.pid -- --disable-hsp
/usr/bin/bluealsa: Couldn't initialize controller thread: Permission denied
 * start-stop-daemon: failed to start `/usr/bin/bluealsa'

# grep bluealsa /etc/passwd
bluealsa:x:129:962:added by portage for bluez-alsa:/dev/null:/sbin/nologin
# grep bluealsa /etc/group
bluealsa:x:962:

[1] root privileges are not required per se, the only requirement is a write access to /var/run/bluealsa

It seems, that I've got carried away a little bit with my non-root assumption. At first, root was not required, but later I've added permissions related code, which is not compatible with this statement. However, I'm not sure if forcing root user is a good idea.
I'll explain how it works right now, and maybe you will have some thoughts regarding this issue - I'm open to any suggestions.
From the user perspective, connected Bluetooth device should be seen as an extra audio device. All actions (reading, writing, controlling) should be managed with the same permissions as other ALSA devices (e.g. PCI audio card). Therefore, I'm using the "audio" group to manage access permissions. That's why you see "Permission denied" message - user bluealsa is not able to change controller socket group to "audio". Starting daemon with --group audio fixes this issue.
Internally, bluealsa has to register audio profiles in BlueZ, which is done via D-Bus. However, accessing BlueZ interface is controlled via the policy file /etc/dbus-1/system.d/bluetooth.conf (at least on gentoo). Obviously, root has granted access, but bluealsa user has not. I haven't seen this issue before, because my user belongs to the plugdev group, so I'm also able to interact with BlueZ.
So, long story sort. After granting BlueZ access to user bluealsa:
# cat /etc/dbus-1/system.d/bluetooth.conf
...
<policy user="bluealsa">
  <allow send_destination="org.bluez"/>
</policy>
...

and changing daemon group to audio:
start-stop-daemon --start --exec /usr/bin/bluealsa --user bluealsa:audio

I'm now able to run bluealsa as a non-root user and any user who belongs to the audio group is able to connect to virtual Bluetooth PCM device.
I've tested this on the current master snapshot, however v1.1.0 should be compatible.

Thanks for reply and explanation, I'll poke at this some more and report how things went :smile:

However, accessing BlueZ interface is controlled via the policy file /etc/dbus-1/system.d/bluetooth.conf (at least on gentoo).

I can make bluealsa part of the plugdev group to fix that.
The problem I see now is that bluealsa (any non root user probably) is not allowed create files/dirs in /var/run. And this is where I am getting the permission denied from. When I create the dir manually and change the permission accordingly I can start it with start-stop-daemon.
But then when I try to create the bluealsa dir in /var/run through Portage it complains (rightly so) that I have no business doing things in there. Wouldn't /var/lib/ be a better place to create and tear down these sockets?

Had a quick look at avahi, they appear to set everything up (pid file, dirs etc) and then drop root privileges.

I've chosen /var/run/ because it points to /run/ (at least on Gentoo and OpenSUSE), which is a tmpfs, so I do not have to worry about cases when bluealsa crashes and there are leftovers in the directory. This directory guarantees, that in the worst case scenario, reboot will do its job (like on Windows™ :D). But to be honest, I don't know if this directory is a right place to keep communication stuff.

bluealsa is not allowed create files/dirs in /var/run

Why not just create this directory within the init script? Before running start-stop-daemon do run:
mkdir -p /var/run/bluealsa
chown bluealsa:audio /var/run/bluealsa

I know this is kinda ugly, however I'm not sure if dropping privileges is necessary. I'm not against the idea of dropping privileges, but bluealse does not require root privileges (in theory). It does not interact with the OS in a destructive way. The only interaction it has, is with D-Bus and filesystem.
Incorporating setreuid in the codebase requires new program argument. Then, if there is --user argument, it is kind of natural to add --group argument. Then (like in e.g. avahi) I might add PID file, which brings the need of adding code for daemonization. And so on, and so on :) I'm not against new features, but new features (imho) should be related to the problem the program is trying to solve. Since, there is start-stop-daemon, it is more UNIX way to let it do its job. What do you think?

Since, there is start-stop-daemon, it is more UNIX way to let it do its job. What do you think?

Yeah, adding all that is a bit much for bluealsa. I submitted my modified ebuild and init script to the gentoo bug tracker [1]. It builds and runs correctly now, creating the directory if needed. Thanks for the help :smile:.
[1] https://bugs.gentoo.org/show_bug.cgi?id=592310


Added favicon

Because it just bothers me to see HTTP 404 favicon errors in DevTools, here's a favicon taken from https://design.google.com/icons/#ic_assignment

Thanks :)


useResource

Assuming createResource is implemented to work akin to createContext, we could have a useResource API like useState to register a resource dependency. The resource will return a tuple – the data and a dispatcher to update the data.
Taking https://github.com/facebook/react/issues/14248 as an example, the following model might look something like:
const TodoResource = createResource(data => fetch(`/details`))

function LeftPanel (props) {
  const [state, dispatch] = useState(props)
  const [resource, fetch] = useResource(TodoResource)

  return <button onClick={e => fetch(state)}>Click Me

}

function RightPanel (props) {
  const [resource, fetch] = useResource(TodoResource)

  return
{JSON.stringify(resource)}

}

function App () {
  return (
    <Suspense fallback="Loading...">
      <LeftPanel/>
      <RightPanel/>
    </Suspense>
  )
}

Hi, thanks for your suggestion. RFCs should be submitted as pull requests, not issues. I will close this issue but feel free to resubmit in the PR format.


pub/pub_uploader_test flaky

http://build.chromium.org/p/client.dart/builders/pub-linux/builds/2321/steps/pub tests failures/logs/stdio
Marking this as flaky in the status file

This issue has been moved to dart-lang/pub#408.


huawei & ucloud fix

这个 PR 实现什么功能/修复什么问题:

华为云&ucloud&aws 问题修复

是否需要 backport 到之前的 release 分支:

release/2.10.0

/cc @swordqiu @ioito
/area region

Codecov Report

Merging #2102 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2102      +/-   ##
=========================================
- Coverage    7.16%   7.15%   -0.01%
=========================================
  Files         445     445
  Lines       69552   69568      +16
=========================================
- Hits         4982    4980       -2
- Misses      64157   64174      +17
- Partials      413     414       +1

Flag
Coverage Δ

#aFlag
7.15% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/multicloud/ucloud/securitygroup.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/disk.go
0% <0%> (ø)
:arrow_up:

pkg/compute/guestdrivers/aws.go
6.41% <0%> (-0.17%)
:arrow_down:

pkg/compute/models/loadbalancercertificates.go
5.11% <0%> (-0.06%)
:arrow_down:

pkg/compute/guestdrivers/ucloud.go
12.82% <0%> (-1.47%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0809c...9258f5a. Read the comment docs.


docs: document async apis - IN-PROGRESS

#closes #287

Let me know when this PR is ready for review.

Any updates? Would you prefer someone else to do finish it?

Hi @santoshyadavdev ,
Since we are very close to the v1 release, we want the website to be completed. We have decided to reuse the work done in this PR and create individual PRs for each pending schema/method/action (example). This PR will be closed once we have successfully reused all of the content changes of this PR.


OCPBUGS-42680: Rebase etcd 3.5.16 openshift 4.17

This PR rebases etcd 3.5.16 into openshift-4.17.
running make locally
SUCCESS: etcd_build (GOARCH=arm64)
./bin/etcd --version
etcd Version: 3.5.16
Git SHA: 2db4e405d
Go Version: go1.22.7
Go OS/Arch: darwin/arm64
./bin/etcdctl version
etcdctl version: 3.5.16
API version: 3.5
./bin/etcdutl version
etcdutl version: 3.5.16
API version: 3.5

Note: Upstream has refactored clientV3 here. This the changed func was being used downstream in https://github.com/openshift/etcd/blob/d984c31e8f83fdd6718502a06046b65554d92e78/client/v3/patch_cluster.go#L17
cc @openshift/openshift-team-etcd

/payload 4.17 nightly informing

/payload 4.17 nightly blocking

/jira refresh

/override ci/prow/configmap-scale

/lgtm

/assign @geliu2016
/assign @sandeepknd

/label cherry-pick-approved

/label backport-risk-assessed

/retest-required


RO-4397 Update rocky dependencies

Automated dependency update pull request, see individual commits for details.

Do not merge this until https://review.openstack.org/605504 merges upstream and the dependency update includes that patch.

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.


runtime: deadlock when running concurrent builds on MacOS

What version of Go are you using (go version)?

$ go version
1.20.2

Does this issue reproduce with the latest release?
Yes, this could be reproduce on 1.20.3 but cannot be reproduce on 1.19.8
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/sluongng/Library/Caches/go-build"
GOENV="/Users/sluongng/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/sluongng/work/golang/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/sluongng/work/golang"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/private/var/tmp/_bazel_sluongng/5c02d8a9b82454292bdfef7b6f9ac04e/external/go_sdk"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/private/var/tmp/_bazel_sluongng/5c02d8a9b82454292bdfef7b6f9ac04e/external/go_sdk/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/sluongng/work/bazelbuild/rules_go/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/ly/gjsqx9wd0cv1ck7xdslrt6t00000gn/T/go-build51901763=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

In Bazel's rules_go, we need to compile a helper binary using go build ... before building anything else.
However, due to different Bazel configurations existing in the same repo (i.e. CGO enable/disable), this same helper binary is built multiple times, once for each unique set of configurations.
When trying to build a test in rules_go with bazel build //tests/core/go_path:copy_path, the helper binary was scheduled by Bazel to be compiled 9 times in parallel. This resulted in 6 different go build processes running in parallel at once.

Each of these build process could spawn multiple compile subprocess as a result

What did you expect to see?
Build to complete without issue
What did you see instead?
All these builds are stuck in a deadlock that completely freeze applications running on the same machine. Opening a new Chrome tab, or running git config would never finish.
Using Activity Monitor's sampling feature we could see call graphs like such for each go build process

It seems like there are 3 types of stack relating to libsystem_kernel.dylib / libsystem_pthread.dylib
    2430 Thread_44978   DispatchQueue_1: com.apple.main-thread  (serial)
    + 2430 ???  (in <unknown binary>)  [0x1358]
    +   2430 runtime.asmcgocall.abi0  (in go) + 124  [0x100b702ac]
    +     2430 runtime.syscall6.abi0  (in go) + 56  [0x100b71a98]
    +       2430 __wait4_nocancel  (in libsystem_kernel.dylib) + 8  [0x1a17a04f4]

    2430 Thread_44999
    + 2430 runtime.asmcgocall.abi0  (in go) + 201  [0x100b702f9]
    +   2430 runtime.pthread_cond_timedwait_relative_np_trampoline.abi0  (in go) + 28  [0x100b717ec]
    +     2430 _pthread_cond_wait  (in libsystem_pthread.dylib) + 1276  [0x1a17d45a0]
    +       2430 __psynch_cvwait  (in libsystem_kernel.dylib) + 8  [0x1a1797710]

    2430 Thread_45038
    + 2430 runtime.kevent_trampoline.abi0  (in go) + 40  [0x100b71518]
    +   2430 kevent  (in libsystem_kernel.dylib) + 8  [0x1a179a060]

The last stack seems to be waiting for some event that never finishes (?).
This bug could be reproduced consistently for me with go 1.20.2 and 1.20.3. It's a bit painful though as I would need to restart my laptop each time. It would go away if I try to build the binary sequentially by limiting Bazel's parallelism, or if I were to downgrade the go version to 1.19.8.
Here is some additional system info
> uname -a
Darwin Sons-Laptop.local 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64

I tried spindump on the stuck processes, unfortunately, it never finishes as it seems to get stuck on the same IO lock.

This seems to be a problem with Bazel building a helper binary.  That seems like a problem that needs to be fixed in Bazel.  It's not clear to me that there is anything that the Go project can change to fix this.

Hey Ian, i think that's miss characterizing the issue.
Bazel was mentioned to provide the context that multiple similar "go build" commands were being executed in parallel by a build tool. I don't think Bazel is causing the OS-level lock here. I suspect the root cause is multiple "go build" commands raced against the same kevent api.

GOCACHE=$(mktemp -d) GOPATH=$(mktemp -d) external/go_sdk/bin/go build -o bazel-out/darwin_arm64-opt-exec-2B5CBBC6-ST-40abec92b10a/bin/external/go_sdk/builder -trimpath
 go/tools/builders/ar.go
 go/tools/builders/asm.go
 go/tools/builders/builder.go
 go/tools/builders/cgo2.go
 go/tools/builders/compilepkg.go
 go/tools/builders/cover.go
 go/tools/builders/edit.go
 go/tools/builders/embedcfg.go
 go/tools/builders/env.go
 go/tools/builders/filter.go
 go/tools/builders/filter_buildid.go
 go/tools/builders/flags.go
 go/tools/builders/generate_nogo_main.go
 go/tools/builders/generate_test_main.go
 go/tools/builders/importcfg.go
 go/tools/builders/link.go
 go/tools/builders/pack.go
 go/tools/builders/read.go
 go/tools/builders/replicate.go
 go/tools/builders/stdlib.go
 go/tools/builders/stdliblist.go
 go/tools/builders/path.go

Here is the effective command that's being executed in parallel by Bazel. The only difference between them would be the output path darwin_arm64-opt-exec-2B5CBBC6-ST-40abec92b10a, everything else is identical.

I don't think that Bazel calls go build.  I don't see how Bazel could possibly call go build, because the directory layouts are different.  And when I look at your screenshots above (by the way, they are very hard to read; please post plain text as plain text, not screenshots), I see external/go_sdk/builder, not go build.

This is the relevant code from rules_go which will generate the command I shared above. https://github.com/bazelbuild/rules_go/blob/3125d8f0971bee56f069bbb33beb6686109fb71d/go/private/rules/binary.bzl#L451-L463
Here we are compiling the builder binary using go build (in an action called GoToolchainBinaryBuild).
After this, the builder binary will be used as a wrapper for various go tool to compile/link other go packages.

OK, and it seems to me that the deadlock occurs when running the builder binary, not when building the builder binary.  Am I wrong about that?

@ianlancetaylor the deadlock does indeed occurs during "building the builder binary".
You could double check my screenshots to see that the stuck process trees are composed of go and sub-process is compile. They correspond to go build and go tool compile respectively.

Again, this bug would be much simpler to understand if you used plain text rather than screenshots.
What I see in the first screenshot is "9 actions running" and then 8 lines starting with "GoToolchainBinaryBuild external/go_sdk/builder [for tool]".  Nothing in that tells me that it is running "go build" to build the builder binary.  That looks to like it is running 8 or 9 instances of the builder binary.
The other screenshots are inconclusive.  The Bazel builder binary almost certainly invokes the Go compiler by running go tool compile.
I'm pretty sure that there is an option you can specify to Bazel that tells it to print out the commands that it executes; maybe it is -s.  Try doing that to see exactly what it is running when this problem occurs.
Let me add that while of course it is possible that there is a bug in go build, nobody who is not using Bazel is reporting any bug similar to this.  So my first guess has to be that this is specific to something that Bazel is doing.

master ~/work/bazelbuild/rules_go> bazel build tests/core/go_path/... -s
INFO: Analyzed 21 targets (5 packages loaded, 250 targets configured).
INFO: Found 21 targets...

Hey Ian,
I do apologise for the lack of text.
This issue is quite painful to reproduce as everytime the deadlock happen, I have to reset my laptop as most process/application stopped working.
The above is the --subcommand you are looking for.

Thanks.  You're quite right, it does seem to be running go build.  It appears to be running the same command several times in parallel.  Any idea why it is doing that?
The stack traces you show above seem to show cmd/go waiting for a subcommand to complete.  Based on the process tree it is likely waiting for cmd/compile to compile something.
What does top show when this is happening?  Are the cmd/compile processes working, or are they waiting for something?  I can't think of what they might be waiting for.

Thanks. You're quite right, it does seem to be running go build. It appears to be running the same command several times in parallel. Any idea why it is doing that?

It's because of different Bazel's build configurations, generated from a combination of multiple transitions augmented the Bazel buildgraph. So each action is executed multiple times, once for each unique build configuration.

What does top show when this is happening? Are the cmd/compile processes working, or are they waiting for something? I can't think of what they might be waiting for.

Im a bit busy until the end of this week so I will provide a reproduce with top later.
But from my original issue description, you could review the sampling result of the go processes, which seem to be stuck on some runtime.kevent_tramboline calls. Not sure if top could provide additional info or if there are some other ways 🤔

Note: Since this issue was created, we have merged https://github.com/bazelbuild/rules_go/pull/3536 in rules_go to limit the concurrency of the go build action, making the deadlock less likely to happen, as a temporary workaround. So reproduce attempt should use an earlier commit in rules_go for a more consistent result.

The kevent_trampoline calls are normal and don't mean anything special.  The key in the stack trace is that the program is waiting at a call to wait4.  In other words, it's waiting for a subprocess to complete.  Given that it is running go build, and given the process tree that you showed, it is most likely waiting for go tool compile to complete.  So if there is a deadlock we need to understand why go tool compile is not completing.


Issue with favorite server buttons

I have set a server button to start a local server of tr_walkway, I have attatched the gamemenu.res file here, let me know if you need another file. I get Unknown command "engine" in consle.
If it makes a difference I run a Mac and used Atom to edit the files
Thanks, I love all the changes.
EDIT: It did work with the multiplayer MicSnobs button I made

Heya!
Looks like you have "engine" twice; instead of engine engine map tr_walkway_rc2, set it to `engine map tr_walkway_rc2 and it should work.
Let me know if you have any other issues :)

oh...
all around me are familiar faces...

happens to the best of us :D


theme colors are not added every where

I've spotted 2 occasions where the css variables aren't added used for theme colours:

pagination on PLP
submit button on (invalid) form

QA steps

Open the login page

Open your dev tools

Go to this section

Change the value for --cx-color-primary to blue, the login button should be blue

Go to the PLP, when hovering over another page number in the pagination, the button should become red (or blue if you kept the variable from step 4) and the number should remain white

Tested on dev19.

After changing the value of --cx-color-primary to blue, the  color is reflected on login button & page number button on hovering.

@KateChuen I can still see the red on the first pagination button, that seems wrong actually.

@tobi-or-not-tobi  yes, I see the first pagination button colored red after the color change.
Setting back to ToDo per your comments.

I took a look but I can't replicate the issue.

My bad. I thought the color should only change on hover for the pagination buttons. I will retest this on my side again.

I can constantly reproduce it on dev19, on chrome....

I have the latest from develop on my local and I can't get the same results.

I also pulled from develop on my local, pointing to dev17 & dev19 for backend. And I see this issue (i'm confused).
I also see this issue on dev17 & dev19 frontend.
I opened in incognito window too and still same issue :(

@KateChuen can you check this branch again?

I deployed feature/GH-3236 branch locally, and it looks good. I see the pagination in blue.
But will need to wait until it's merged with develop and have it deployed on a server to do the real final test.

Fixed by GH-3627

Tested on dev10, with theme calydon enabled.
It's now fixed.


[WFLY-17805] Validate need for javax.resource.api / javax.xml.bind.ap…

…i package declarations in ee layer
https://issues.redhat.com/browse/WFLY-17805
Draft to see what CI thinks

Won't do -- see https://issues.redhat.com/browse/WFLY-17805?focusedId=22165527&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-22165527


chore: client error fail without 500 error

Applicable spec: N/A
Overview
When there is a github client error (e.g. A non existing user is queried), the error is not caught and repo-policy-compliance will fail and return 500 error without any helpful explanation. This change aims to fix that.
Example 500 internal server error run
Rationale
To not have 500 server error and give out explanation on why repo-policy-compliance has failed.
Module Changes
All modules now catches and handles Github client error.
Checklist

[x] The contributing guide was applied
[x] The documentation is generated using src-docs
[x] The PR is tagged with appropriate label (urgent, trivial, complex)
[x] Version has been incremented on pyproject.toml

Does this fix https://github.com/canonical/repo-policy-compliance/issues/788 ?

@cbartz ah yes it does :) thanks for the ref

As discussed, I don't think an issue with the token should lead to a failed report since we haven't established whether there is a problem with the repository setup and instead we had a problem producing the report in the first place. A 500 series error is probably appropriate, perhaps it could include additional details of what went wrong to help the operator debug


Night shift produces a white line on the top.

Hello! Noticed that when using night shift there's a white line on the top of the page, it's not on the sidebar but on the content page.

The white line on the top with the sidebar pinned.

Here the sidebar is retracted and the white line is shown on the whole page.

Here it's fullscreened with the sidebar retracted.

Fullscreen with the sidebar pinned.

Fullscreen with the sidebar open by hovering over it.
I noticed that the sidebar is still open when hovering over it and leaving the window with the mouse, not sure if intentional or not.

Still happening in v1.4.0.

Hi @felixrieseberg @JohnONolan
This might be necessary to change in Ghost Admin (CSS) and in Ghost Desktop (Injection).
In Ghost Desktop it would be recommended to remove CSS file: \public\assets\inject\css\win32.css
This causes the injection of the border-top attribute in CSS selector class gh-main.
In general this works as long as the user doesn't use Dark Theme in Windows 10.
To achieve the same effect but without colour issue under Windows please consider to change the CSS selector class gh-viewport instead.
.gh-viewport {     max-height: 100%;     border-top: 1px solid #dfe1e3; }
And in night shift mode have the following in "ghost-dark.css":
.gh-viewport {     max-height: 100%;     border-top: 1px solid #263238; }
Thanks for consideration.
Cheers, JoKi

@jochenkirstaetter if you want to make the two PRs for this to ghost-admin/desktop - I'd be happy to merge. Just make sure you use the correct color --var rather than the hex values, but other than that you approach sounds 👍  to me.
Ref. this issue from both :)


Can't save HLS .ts format to S3

I would save a HLS encoded Video to S3
VIDEO IS ENCODED BUT ONLY .m3u8 file IS SAVED TO S3
All .ts files are missing
All works fine in local but with s3, only .m3u8 is saved
FFMpeg::open('my_movie.mov')
    ->exportForHLS()
    ->setSegmentLength(1) // optional
    ->addFormat($lowBitrate, function($location) {
            $start = \FFMpeg\Coordinate\Timecode::fromSeconds(1);
            $end = \FFMpeg\Coordinate\Timecode::fromSeconds(30);
            $clip = new \FFMpeg\Filters\Video\ClipFilter($start, $end);
            $location->addFilter($clip);
        })
    ->addFormat(...another format)
    ->toDisk('s3')
    ->save('my_movie.m3u8);

HI! and Thanks in advance for help!!

ok, I see Issue 124

ok, I see Issue 124
https://github.com/pascalbaljetmedia/laravel-ffmpeg/issues/124

HLS to a remote disk is unsupported at the moment but I'm working on a branch with this feature: https://github.com/pascalbaljetmedia/laravel-ffmpeg/tree/hls-external
Please continue the discussion in this topic: https://github.com/pascalbaljetmedia/laravel-ffmpeg/issues/124


In Style.php line 1012

Pint Version: 0.1.7
PHP Version: 8.1.5

Description:
./vendor/bin/pint --test is throwing this error

In Styles.php line 1012:

  [Error]
  Call to undefined function Termwind\ValueObjects\mb_strimwidth()

Exception trace:
  at phar:///home/(project_path)/vendor/laravel/pint/builds/pint/vendor/nunomaduro/termwind/src/ValueObjects/Styles.php:1012
 Termwind\ValueObjects\Styles::trimText() at phar:///home/(project_path)/vendor/laravel/pint/builds/pint/vendor/nunomaduro/termwind/src/ValueObjects/Styles.php:833

Please make sure that you have the mbstring extension installed on your system.

Thanks it worked.

Great, thanks! We've added this to the dependencies.


Update introduction.md

🚀 Deployed on https://65a95fc8a159d000ada0c3a9--cozy-fox-0defec.netlify.app


Multiple anonymous return values are incomplete in debugging(Solidity Locals)

As shown. i have three anonymous return values, but only one can be seen. so I modified the name rules for anonymous properties
var attributesName = param.attributes.name === '' ? `$${inputParam}` : param.attributes.name

I think this has not completely fixed the problem, maybe the code below has other potential issues, because I don't know what it does
  var variableDeclaration = resolveVariableDeclaration(tree, step, sourceLocation)

  if (variableDeclaration && !tree.scopes[scopeId].locals[variableDeclaration.attributes.name]) {
    tree.traceManager.getStackAt(step, (error, stack) => {
      if (!error) {
        tree.solidityProxy.contractNameAt(step, (error, contractName) => { // cached
          if (!error) {
            var states = tree.solidityProxy.extractStatesDefinitions()
            var location = typesUtil.extractLocationFromAstVariable(variableDeclaration)
            location = location === 'default' ? 'storage' : location
            tree.scopes[scopeId].locals[variableDeclaration.attributes.name] = {
              name: variableDeclaration.attributes.name,
              type: decodeInfo.parseType(variableDeclaration.attributes.type, states, contractName, location),
              stackDepth: stack.length,
              sourceLocation: sourceLocation
            }
          }
        })
      }
    })
  }

covered in #1422 . Thanks @EthanWan


rango font is missing

Bug report
Preconditions

master branch

Steps to reproduce
It is important to provide a set of clear steps to reproduce this bug.If relevant please include code samples.

The file is instead located in packages/Webkul/Velocity/src/Resources/assets/sass/ but the fonts are missing from the asset folder

Hi @ghermans,
If you check the publishable folder in Velocity's package, you will indeed find the fonts folder. Maybe for avoiding duplicate files not given in the assets folder.


Dependencies: Blizzard_AuctionUI

after last game update Addon goes to disabled state and in addon's menu was warning - Dependencies: Blizzard_AuctionUI

Hey, sorry for not replying for so long, I have removed the dependency as it seems to be that Blizzard loads Auction UI at all times on client start


[Fixes #6943] Unit Testing Page Model Throws Null Ref On ModelState check

I'll add tests later.
We can't do anything for IUrlHelper


[feature] Add Aerodrome Oracle on Base Chain

Seeing more tokens only listed on Aerodrome on Base, and example is WELL - 0xa88594d404727625a9437c3f886c7643872296ae
No price can be found
https://basescan.org/address/0x0AdDd25a91563696D8567Df78D5A01C9a991F9B8#readContract

8 million of liquidity

Would appreciate this as well 🙏🏻

Thank you for improving the Oracle and drawing attention to the missed liquidity.


Arabic latex support

Markwon version: {4.6.2}

I am using JLatexMathPlugin to display math formula it works well in english equation but when i want to display Arabic equation The Arabic letters appears well, but the numbers still appears in English.
FYI: the Arabic number is displayed well in Markwon without latex plugin but when using JLatexMathPlugin the arabic number doesn't display in Arabic.
Below is the code i used
 Markwon.builder(context) // required plugin to support inline parsing
                .usePlugin(MarkwonInlineParserPlugin.create())
                .usePlugin(HtmlPlugin.create()) // support html
                .usePlugin(JLatexMathPlugin.create(textSize) { builder -> // ENABLE inlines
                    builder.inlinesEnabled(true)
                })
                .usePlugin(SoftBreakAddsNewLinePlugin.create()) // to add new line
                .build()

Screenshot of how it looks like with english equation.

Screenshot of how it looks like with arabic equation.

any solution for this @noties ?

Hello @AzharRagab ,
I'm not really versed in Arabic and do not know how it is rendered in LaTeX. But it appears that you should be able to achieve that by manually specifying text for the power values, like this:
2^{2} + 3^{yep}

=
2^{2} + 3^{yep}


Remove explicit check for unique days = n_days

Description
Removing explicit check to let validator handle missing dates
Fixes

USA-facts will start working again

Looks like you have failing tests -- largely the one testing the behavior this PR removes though, so it's okay to remove that test as well.


python37Packages.python-gnupg: 0.4.4 -> 0.4.5

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-python-gnupg/versions.
meta.description for python37Packages.python-gnupg is: '"A wrapper for the Gnu Privacy Guard"'.
meta.homepage for python37Packages.python-gnupg is: '"https://pypi.python.org/pypi/python-gnupg"

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.4.5 with grep in /nix/store/68wfd9788rv1rx9xg5hnfhf52j1ppx15-python3.7-python-gnupg-0.4.5

directory tree listing: https://gist.github.com/fa84a2d5e37f8caeb6ebfb0bc4cb608e

du listing: https://gist.github.com/73e522e4de5f64fe14785e0749897591

Rebuild report (if merged into master) (click to expand)

21 total rebuild path(s)
7 package rebuild(s)
7 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
gajim
hash-slinger
iceshelf
paperless
python27Packages.pyspread
python27Packages.python-gnupg
python37Packages.python-gnupg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/68wfd9788rv1rx9xg5hnfhf52j1ppx15-python3.7-python-gnupg-0.4.5 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.python-gnupg https://github.com/r-ryantm/nixpkgs/archive/b279c87ff1dc7adad0ec282acffe46ea8aaaff65.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/68wfd9788rv1rx9xg5hnfhf52j1ppx15-python3.7-python-gnupg-0.4.5
ls -la /nix/store/68wfd9788rv1rx9xg5hnfhf52j1ppx15-python3.7-python-gnupg-0.4.5/bin

cc @copumpkin for testing.

@GrahamcOfBorg build iceshelf


version 0.12.1 causes ClientTlsConfig to explode with invalid CryptoProvider

Bug Report
ClientTls causes a panic in latest tonic client
Version
cargo tree | grep tonic
├── tonic v0.12.1 (*)
├── tonic-health v0.12.1
│   └── tonic v0.12.1 (*)
├── tonic-reflection v0.12.1 (*)
├── tonic-types v0.12.1 (*)
├── tonic-web v0.12.1
│   ├── tonic v0.12.1 (*)
│   ├── tonic v0.12.1 (*)
│   ├── tonic-health v0.12.1 (*)
│   ├── tonic-reflection v0.12.1 (*)

Platform
Darwin arm64
Description
We recently updated to v0.12 (tried both v0.12.0 and v0.12.1). When I try to run the code like
    let tls_config = ClientTlsConfig::new().domain_name("secretmanager.googleapis.com");

    Channel::from_static("https://secretmanager.googleapis.com")
        .tls_config(tls_config)?
        .connect()
        .await

It panics with the following:
no process-level CryptoProvider available -- call CryptoProvider::install_default() before this point

It turns out this was an issue with metrics-exporter-prometheus requiring aws_lc_rs

@tzilist I'm running into this same issue but not using metrics-exporter-prometheus. How did you narrow the issue down to that particular dependency?

I came across the same issue. Do we know how metrics-exporter-prometheus interferes ?


Fix to the tab height (Issue #81500)

This PR changes the tab bar height when there is an icon and a text from a constant value to an user input, fixing the overflow when the icon + child widgets height is greater than 72
This PR fixes #81500
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This PR it's ready for a review @Hixie.

@Piinks changes and tests added

1 month anniversary \o/


Notification configurability

The Bot Detector: N Player Names Uploaded Successfully! message triggers notifications in RuneLite.
This clashes with users that rely on the Idle Notifier plugin to play afk.
Please can we keep the ability to contribute automatically, but remove the in-game chat message and notification. It would be nice if it's configurable if we want to see the number for some reason. It should really default to off

Hello! Once this pull request is merged into the RuneLite Plugin Hub's master branch there will be an option to disable notifications. Hopefully it'll be live soon!

86e4e60ff22fa06f11ec6b25dd642f679de67be5 Is the commit with the fix.


Fix for #400

This is a fix for issue #400 (re-comitted)

I think it is a good practice to also include test specs to verify new conditions. It also helps to measure the impact of a future change. What is the policy in here for tests?

You're correct @diegomart2000, we require tests for all features. @pash7ka can you add tests to see that transfers to 0x0 are rejected?
Can you also please remove the irrelevant commits in the branch? You can do it with an interactive rebase: git rebase -i HEAD~6.

I'll add tests and resubmit everuthing from scratch.

You don't need to create a new PR! You can rebase and force push (git push -f). 🙂
Thanks for your work though!

Sorry, I don't understand what I have to do with all this commits now.
I've tried git rebase -i HEAD~6 and git push -f and it seems just created more mess..
My current brunch https://github.com/pash7ka/zeppelin-solidity/tree/issue-400 contains correct files and tests.

Don't worry, I'll merge the commits manually. (You will remain the author.)

Thank you!


Generated Swagger UI does not show all possible HTTP response codes

Hello,
When I customize the HealthCheckOptions in the call to MapHealthChecks() in my health check to do the following:
        ResultStatusCodes = new Dictionary<HealthStatus, int>()
        {
            [HealthStatus.Healthy] = StatusCodes.Status200OK,
            [HealthStatus.Degraded] = StatusCodes.Status500InternalServerError,
            [HealthStatus.Unhealthy] = StatusCodes.Status503ServiceUnavailable,
        },

the resulting Swagger UI only shows 200 and 503 as a possible response. It seems to be missing the customized Degraded response of 500. Am I missing something?

Hi @rkwright3 thanks for checking out this library :)
Unfortunately, I couldn't figure out a way for the library to access the definitions that are configured in the HealthCheckOptions at the right point in the configuration lifecycle, so it's unable to automatically generate matching result status codes. If you want to modify the codes that are reported in the swagger doc, you'll need to configure them explicitly by adding a response definition within the WithOpenApi extension method during your configuration. It would look something like this:
app.MapHealthChecks(
        "/healthz",
        new HealthCheckOptions
        {
            ResponseWriter = reportFormatter.WriteDetailedReport,
        })
    .WithOpenApi<HealthCheckReport>(
        metadata =>
        {
            metadata.OperationId = "GET_healthz";
            metadata.Summary = "Returns information about the health of the system";
            metadata.ResponseDefinitions.Add(
                new HealthCheckResponseDefinition
                {
                    StatusCode = StatusCodes.Status500InternalServerError,
                    ResponseType = typeof(HealthCheckReport),
                });
        });

The key addition is the call to metadata.ResponseDefinitions.Add()
Please let me know how you get on!

Thanks for letting me know. And I'm glad you find the library useful!


Avoid setting padding, margin & inset shorthand as they use physical properties

Description
When using padding, margin or inset shorthand syntax, the underlying properties set are physical, not logical. This becomes significant if different values are set at opposite ends of the same axis. It is incorrect for Libero to use this approach: Libero should be using logical properties throughout, even implicitly. This behaviour of the shorthand syntax, using the inline axis as the example, has been characterised for padding and margin.
Action
The padding(), margin() and inset() mixins should be changed to explicitly use logical properties (with fallbacks) when different values are set for different ends of the same axis in these situations, for (non-exclusive) example:

https://github.com/libero/pattern-library/blob/master/test/sass/mixins/spacing.spec.scss#L115
https://github.com/libero/pattern-library/blob/master/test/sass/mixins/spacing.spec.scss#L313
https://github.com/libero/pattern-library/blob/master/test/sass/mixins/spacing.spec.scss#L1458
https://github.com/libero/pattern-library/blob/master/test/sass/mixins/spacing.spec.scss#L1483

It should be fine when the values are the same, eg https://github.com/libero/pattern-library/blob/4e5a8987a9ee9ea777f3eb32d2c737ea2ba57cfe/test/sass/mixins/spacing.spec.scss#L330. (Though the redundant values should be removed.)

Can probably be safely ignored for block-axis for now, as we've not fully implemented logical properties for vertical writing modes yet.

PR for review at https://github.com/libero/pattern-library/pull/106


/var/run issue when running on Ubuntu host

I was trying to deploy kubevirt to my existing k8s cluster running with Ubuntu 16.04 workers and discovered that virt-handler could not talk to libvirtd. The problem was that the socket was not available on the host.
This is is because /var/run is a symlink to /run (whereas on Fedora it is a symlink to ../run) this means that the socket does not get into the host OS.

Thanks for reporting this. It's unclear to me why the distinction between an absolute vs. relative symlink would cause this issue.
Within the context of the KubeVirt k8s manifest files, the path to the libvirt runtime directory is only ever referred to as /var/run/libvirt. So in either case, the symlink must be followed. Is there a context where an absolute reference to /run would be incorrect?

On fedora the ../run would point to /host/run (so still on the host fs) but if it is a relative path then it would point to /run which is the "container" rootfs.

After conferring on IRC, the source of this issue was that the libvirt container on master is not yet fully functional, but that's not clear from the git tree.

Sadly it is not very easy at the moment to set up libvirt the reight way when not running it from within our vagrant environment. https://github.com/kubevirt/community/pull/2 will give us the easy solution. For now you have to do the follwing things

Configure libvirt like we did here: https://github.com/kubevirt/kubevirt/blob/master/cluster/vagrant/setup_kubernetes_common.sh#L82
place our libvirt emulator script cmd/virt-launcher/qemu-kube at /usr/local/bin/qemu-x86_64 on the host (qemu-x86_64 is the script name)
install the emulator script dependencies (sudo, nsenter, cgclassify)
give the script sudo privileges: https://github.com/kubevirt/kubevirt/blob/master/cluster/vagrant/setup_kubernetes_common.sh#L101

We should start working on https://github.com/kubevirt/community/pull/2 soon.

With eb5e9ef443a84ec64f94c3a877d47c82cd0911a9 libvirt moved into a container, which should prevent this issue.
Please reopen if necessary.


drawer supports new apis in order to keep synchronous with ant design

What problem does this feature solve?
Drawer module supports new apis like [nzExtra].
What does the proposed API look like?

[nzExtra]

[nzSize] maybe overlap with nzHeight and nzWidth.

Reference from Ant Design: https://github.com/ant-design/ant-design/pull/30908


Does anyone maintain this project anymore?

Anyone willing to fork and take care of if not?

Thank you for the reply. I'll try to go with the arduino package

Thank you for the reply. I'll try to go with the arduino package


Auto Ack don't ack if user already acked

Even if auto ack is turned on, the code needs to pay attention to if the message has been acked by the user, for instance nak'd or inProgress, etc. so that the client does not change the intended user behavior.

This was fixed a while ago with subscription and ordered consumer changes


BottomSheet content does not update after initial render

Hey there! I'm having an issue where the contents of the bottom sheet does not change after initial render even though the content view build is re-run and returns a new view.
My code looks something like the following:
.bottomSheet(item: self.$selectedItem, detents: [.medium()], prefersGrabberVisible: true) {
    if let item = self.selectedItem {
        Text("Item: \(item.title)")
    } else {
        Text("No item selected").
    }
}

When initially rendering this the view which has the bottomSheet modifier, self.$selectedItem is nil and thus the bottom sheet is not presented but the content view builder is invoked. This is expected. The initial render will produce the "No item selected" label.
When self.$selectedItem is updated to refer to a selected item I want the bottom sheet to be presented and display the item's title. What happens instead is that the bottom sheet is presented but displays "No item selected". Using breakpoints in Xcode I can confirm that the content view builder re-invoked when an item is selected and the correct branch of the if statement is invoked, so it should be displaying my item title. It seems that the hosting view controller is not updated with the new content view though.

I had a similar issue. I was trying to build a similar library to this, but I was adding the ability to programatically change the detent in swiftui.
Its as you said. It seems the UIHostingControllers are not updated.
I wonder if there is a way to hook into the default SwiftUI Sheet and use that to present these bottom sheets. As under the hood, it is using a UISheetPresentationController.


HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…

…hot clone (#4617)

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446)

Reorganize MOB compaction tests for more reuse.

Add tests for mob compaction after snapshot clone operations

note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez<EMAIL_ADDRESS>

spotless:apply to fix HBaseTestingUtility

Fix error-prone errors

Signed-off-by: Esteban Gutierrez<EMAIL_ADDRESS>Co-authored-by: Sean Busbey<EMAIL_ADDRESS>

A backport from branch-2 to branch-2.5.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 16s
branch-2.5 passed

+1 :green_heart:
compile
2m 46s
branch-2.5 passed

+1 :green_heart:
checkstyle
0m 46s
branch-2.5 passed

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 46s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
2m 45s
the patch passed

-0 :warning:
javac
0m 31s
hbase-common generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)

-0 :warning:
javac
2m 14s
hbase-server generated 4 new + 189 unchanged - 4 fixed = 193 total (was 193)

+1 :green_heart:
checkstyle
0m 45s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m 27s
Patch does not cause any errors with Hadoop 2.10.1 or 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

39m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4704

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 86d1affa1621 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / da472aac06

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 52s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 28s
branch-2.5 passed

+1 :green_heart:
compile
0m 50s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
0m 51s
the patch passed

+1 :green_heart:
javac
0m 51s
the patch passed

+1 :green_heart:
shadedjars
4m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-common in the patch passed.

-1 :x:
unit
187m  6s
hbase-server in the patch failed.

210m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4704

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6775756d6dd4 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / da472aac06

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/testReport/

Max. process+thread count
2160 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 22s
branch-2.5 passed

+1 :green_heart:
compile
1m 10s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 59s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 28s
hbase-server generated 1 new + 90 unchanged - 0 fixed = 91 total (was 90)

_ Other Tests _

+1 :green_heart:
unit
1m 57s
hbase-common in the patch passed.

+1 :green_heart:
unit
216m 52s
hbase-server in the patch passed.

242m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4704

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3fc95726a348 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / da472aac06

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/testReport/

Max. process+thread count
2315 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4704/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I run the failed test case TestSplitRegionWhileRSCrash locally, it passed.