[youtube] Stuck in infinite loop grabbing API JSON on channels

ytdl-errorapi.txt
Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
North America or Worldwide
Description
I did my best to search the bug tracker but couldn't find anything about this.
I am getting stuck in seemingly infinite loops where the youtube extractor tries to download the API JSON for channels. This bug does not appear to be channel specific, it simply triggers after either going through multiple other channels, or randomly with a single channel. I am unsure if it's some kind of blackholing effect as a limiter.
Please see the verbose log for an example. The linked channel does not have over 1000 pages, let alone over 100.
This also occurs with other channels, it's random.
https://www.youtube.com/channel/UC5Jj_A0NjP2vtcZZvvYU7qw/videos
or https://www.youtube.com/channel/UCnFP0IU4gpnmcLnVzDLUtfw
I've tried grabbing with different IPs over VPNs or powercycling my modem, with no change.
I can provide more details when needed. Thanks!
Verbose log
$ yt-dlp -Uv --config-location ./youtube-dl.conf
[debug] Command-line config: ['-vvv', '--config-location', './youtube-dl.conf']
[debug] Custom config file: ./youtube-dl.conf
[debug] Custom config: ['-f', 'bestvideo[ext=webm]+bestaudio[ext=webm]/bestvideo[ext=mp4]+bestaudio[ext=webm]/bestvide
o+bestaudio', '-i', '-o', '/mnt/youtubedl/%(uploader)s (%(uploader_id)s)/%(upload_date)s - %(title)s - [%(resolution)s] [%(id)s].%(ext)s', '--ffmpeg-location', '/usr/local/bin/', '--no-write-playlist-metafiles', '--concurrent-fragments', '16', '--downloader-args', '-x 16 -s 16', '--retries', '20', '--download-archive', '/mnt/youtubedl/youtube-dl-archive.txt', '-a', '/mnt/youtubedl/youtube-dl-channels.txt', '--merge-output-format', 'mkv', '--write-sub', '--all-subs', '--convert-subs', 'srt', '--add-metadata', '--write-description', '--write-thumbnail', '-v']
[debug] Batch file urls: ['https://www.youtube.com/channel/UCyduf4VRZnF7RXSrqqexX5w',]
WARNING: --downloader-args given without specifying name. The arguments will be given to all external downloaders
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, err UTF-8, pref UTF-8
[debug] yt-dlp version 2<IP_ADDRESS> (zip)
[debug] Python version 3.7.3 (CPython 64bit) - Linux-5.10.0-0.bpo.8-amd64-x86_64-with-debian-10.11
[debug] exe versions: ffmpeg 4.2.1 (fdk), ffprobe 4.2.1
[debug] Optional libraries: Crypto, keyring, sqlite
[debug] Proxy map: {}
[debug] Loading archive file '/mnt/youtubedl/youtube-dl-archive.txt'
yt-dlp is up to date (2<IP_ADDRESS>)
[debug] [youtube:tab] Extracting URL: https://www.youtube.com/channel/UCyduf4VRZnF7RXSrqqexX5w
WARNING: [youtube:tab] A channel/user page was given. All the channel's videos will be downloaded. To download only th
e videos in the home page, add a "/featured" to the URL
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w: Downloading webpage
[debug] [youtube:tab] Final URL: https://www.youtube.com/channel/UCyduf4VRZnF7RXSrqqexX5w/videos
[download] Downloading playlist: Grace Motley - Videos
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 2: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 3: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 4: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 5: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 6: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 7: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 8: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 9: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 10: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 11: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 12: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 13: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 14: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 15: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 16: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 17: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 18: Downloading API JSON
[...]
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1638: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1639: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1640: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1641: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1642: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1643: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1644: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1645: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1646: Downloading API JSON
[youtube:tab] UCyduf4VRZnF7RXSrqqexX5w page 1647: Downloading API JSON
^C
ERROR: Interrupted by user

Currently appears to be a YouTube issue, I'm getting this too. Passing the channel's uploads playlist should workaround it for now.

Thanks for the insight, glad it isn't just me. I will sit tight for a proper fix, and for urgent stuff will use your workaround!

An option to automatically derive and use the uploads playlist URL from the channels videos URL could be a useful addition to yt-dl to mitigate this problem in the future.

For what it's worth, same issue occurs on youtube-dl, so definitely something changed on Youtube side.

@coletdjnz : I make my own webradio with mpv --ytdl-format=140 --shuffle [channel’s URL], and I had the (bad) surprise to see the command do nothing this morning (CET). Thankfully, using the uploaded videos playlist URL works.
Could you past the link to the tweet ackowledging this is a bug?
Plus, there is a bug with videos repeated again and again on the “Videos” page: https://twitter.com/TeamYouTube/status/1458363111799496710
Hopefully, all these bugs will be fixed soon and we will use youtube-dl/yt-dlp again without updating them.

@coletdjnz : I make my own webradio with mpv --ytdl-format=140 --shuffle [channel’s URL], and I had the (bad) surprise to see the command do nothing this morning (CET). Thankfully, using the uploaded videos playlist URL works.
Could you past the link to the tweet ackowledging this is a bug?
Plus, there is a bug with videos repeated again and again on the “Videos” page: https://twitter.com/TeamYouTube/status/1458363111799496710
Hopefully, all these bugs will be fixed soon and we will use youtube-dl/yt-dlp again without updating them.

The one you linked is pretty much what they are responding with atm - that's the issue that's causing this issue with yt-dl(p). I've reworded my comment since they technically haven't acknowledged it as a bug yet afaik.

An option to automatically derive and use the uploads playlist URL from the channels videos URL could be a useful addition to yt-dl to mitigate this problem in the future.

This wont solve anything. Maybe next time, they will break playlists and not /videos 🤷
The uploads playlist does not contain all videos of the channel for very large channels. So an auto-redirection is not good. It must be user's own choice to choose one or the other

An option to automatically derive and use the uploads playlist URL from the channels videos URL could be a useful addition to yt-dl to mitigate this problem in the future.

This wont solve anything. Maybe next time, they will break playlists and not /videos shrug

The uploads playlist does not contain all videos of the channel for very large channels. So an auto-redirection is not good. It must be user's own choice to choose one or the other

I wasn't aware of that caveat, I'll keep an eye out for it  -  thanks!
Although I didn't mean to imply auto-direction without use of a command line option, I get your point ...on reflection it's perhaps a confusing overload of functionality to put something like this into yt-dl.  Messing with the URL used to scrape channels would be better handled as a function within my "multiple channel scraper" script.  I just added one, and it's also got me thinking about other ways I could play with the download URL to make update runs more efficient and or robust ready for the next youtube breakage 😀
Thanks for the great tool in yt-dl.

Issue seems to be sorted for me now in the UK.

I can't replicate this in Canada either. I tested by using the URLs in the original comment. Seems like the issue is fixed on YouTube's end and yt-dlp doesn't need to do anything?

Can confirm that issue no longer appears to be occurring.

Seems to be fixed

It has not been fixed, it is just a lot more rare now, but it definitely still keeps happening.

Oh, Does it happen in browser too? or only in yt-dlp?

I can confirm. It still happens. However, it seems to be random which makes it harder to give example. When I try to redownload it work and obviously when I look in browser it also works. I hope this is not some kind of countermeasure/honeypot for applications like yt-dlp but simple youtube bug.

I can't say as I don't use YouTube enough myself for this to happen. The yt-dlp jobs I have load channels tens of thousands of times a day and even with that it is still pretty rare. As rare as it may be, it is still critical if not caught.

@coletdjnz Do you have any idea if we can detect this issue and raise an error instead of the infinite loop?

@pukkandan I propose we could detect the same video IDs repeated an abnormal number of times (this would not work for playlists, but would be fine for channel video pages).

I've experienced this only very rarely on Topic pages. --playlist-end works well
https://m.youtube.com/channel/UCodMGMP1NNN7Bg-i8x5VrNA/videos

I've experienced this only very rarely on Topic pages. --playlist-end works well
https://m.youtube.com/channel/UCI4-cRRz7SKOg5LxAruPpbQ/playlists


Mac OSX - Doesn't actually write the file using export()

As per the title really. It plays the audio, when it finishes it says it has saved. But no file exits anywhere.
Code I have tried...
say.export("Welcome", 'Alex', 0.95, './hal.wav', (err) => {
      if (err) {
        return console.error(err)
      }
      console.info('Text has been saved to hal.wav.')
    })

say.export("Welcomee", 'Alex', 0.95, '~/nodejs-app/hal.wav', (err) => {
      if (err) {
        return console.error(err)
      }
      console.info('Text has been saved to hal.wav.')
    })

EDIT: It seems as though "Alex" isn't installed on Mac by default - It's using "Daniel" but not telling me.
Still doesn't work though...

I believe this was fixed in https://github.com/Marak/say.js/pull/74

Hmm, doesn't seem to write for me.

For anyone checking in here in 2023... I could only get export to work by specifying the name "Daniel" and exporting to a .wav specifically - if you try a different name or exporting to something like .mp3 it won't work (and won't throw any error either!)


NuGet package

Hi, first of all thanks for building this fancy task builder! From my first few tests it works like a charm! I came across it, because someone used your TaskBuilder.fs to improve the performance of the Giraffe web framework and therefore I would be interested in consuming it via a NuGet package rather than having to copy/paste it every time you improve it or bug fix something. It would also make it easier by having it as a well documented dependency and avoid other contributors to try and change the TaskBuilder.fs in Giraffe when really they should probably discuss any changes/improvements with you here first so that everyone can benefit from it.
Would you be interested in making your TaskBuilder.fs accessible via a NuGet library? If yes I can even help out with a PR myself. Let me know and thank you for open sourcing it!

I'm in favor of it in principle. I don't know whether it should be a package including the source file or a compiled .dll, but I guess people can always grab the source themselves if they prefer to do it that way...
Anyway, feel free to open a PR!

If this happens you might also want to add/change the Obsolete attribute on the TaskBuilder to just use EditorBrowsable(EditorState.Never) as it's in a different assembly that should work.


Uncaught TypeError: Cannot read property 'nodeType' of undefined

VueTables version: 1.5.6
Vue.js version: 1.0.26
consumed using: webpack
FULL error message (including stack trace):

Uncaught TypeError: Cannot read property 'nodeType' of undefined
compileNode	@	?d41d:7097
compile	@	?d41d:6876
Vue.$compile	@	?d41d:9491
ready	@	ready.js?a6ef:3

relevant code: ready.js mixin
steps for reproducing the issue: just load a page with the table component on it

Unable to replicate. (Also both the demo and the options are working on the latest dist version, and there is no error). Please try to delete the folder from your node_modules and reinstall.

That's so weird, I switch to 1.5.5 and it works fine. Ill see what I can find. thanks

This was added to the new template and I used a custom one, fixed now. Thanks


Make locking 'idempotent' in consul coordination (closes #61)

@hseeberger please, check if this fits you. thanks!.

Looks great. Thanks!


Basket. Validations. Wrong validation for Stake more

Description
Shows Not enough funds to complete operation, but actually account has that founds

Example
https://github.com/novasamatech/nova-spektr/assets/40560660/550d3651-52ce-4110-88e8-e0b77a11f5b1

Test data:
accounts.json
balances.json
basketTransactions.json
wallets.json
Steps to Reproduce

Go to staking page with wallet from test data
Create operation for Stake more 0.1 WND
Add this operation to the basket
Go to the basket

Expected Behavior
Can successfully sign the operation
Actual Behavior
Not enough funds to complete operation validation error
Environment
https://github.com/novasamatech/nova-spektr/commit/36c791f377a0a3f16c7fca5cc1945b59428d328c

Status verification: ❌
What has been verified:

The problem is still reproduce

Status verification: ✅


[Proposal] Add built-in function register_executing() and register_recording()

Hi Bram and list,
I added a state of recording into register and/or executing the register to built-in function mode(1).
See the modified document in the patch.
How about this?
Possibly, should we add another function?
--
Best regards,
Hirohito Higashi (h_east)

Codecov Report

Merging #2745 into master will increase coverage by <.01%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
+ Coverage      75%   75.01%   +<.01%
==========================================
  Files          92       92
  Lines      134183   134188       +5
==========================================
+ Hits       100643   100657      +14
+ Misses      33540    33531       -9

Impacted Files
Coverage Δ

src/evalfunc.c
83.61% <69.23%> (+0.01%)
:arrow_up:

src/ex_cmds.c
79.39% <0%> (-0.23%)
:arrow_down:

src/misc1.c
84.34% <0%> (-0.07%)
:arrow_down:

src/term.c
60.21% <0%> (ø)
:arrow_up:

src/if_py_both.h
76.59% <0%> (ø)
:arrow_up:

src/screen.c
77.45% <0%> (+0.02%)
:arrow_up:

src/syntax.c
78.27% <0%> (+0.02%)
:arrow_up:

src/normal.c
73.13% <0%> (+0.02%)
:arrow_up:

src/channel.c
82.79% <0%> (+0.04%)
:arrow_up:

src/os_unix.c
54.61% <0%> (+0.13%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295ac5a...635d3b0. Read the comment docs.

Hirohito Higashi wrote:

I added a state of recording into register and/or executing the register to built-in function mode(1).
See the modified document in the patch.
How about this?
Possibly, should we add another function?

Yeah, this is not part of the mode, this state doesn't change what
commands will do.
Perhaps recording() can return the register name and executing() can
return one or zero.
--
Microsoft is to software what McDonalds is to gourmet cooking
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I reverted mode() modification and added function register_executing() and register_recording().

I reverted mode() modification and added function
register_executing() and register_recording().

Looks OK, but the names are a bit long.  How about reg_executing() and
reg_recording()? That's clear enough, right?
We could make them event a bit short:
reg_excute()
reg_record()
But that sounds like actions, not a good choice.
--
hundred-and-one symptoms of being an internet addict:
48. You get a tatoo that says "This body best viewed with Netscape 3.1 or
higher."
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Rename function name to reg_executing() and reg_recording() :+1:

@xtal8 Thanks! I fixed.

This is really neat!  Of course, the only thing missing now is an autocmd or two on "start recording" and "stop recording" :).


Azure IoT Provisioning service public API and inbound message processing

Public API changes:

Changing from span, out_span to char*, size, nullable *out_len containing NULL-terminated strings.
Remove custom payload parsing. (@jspaith FYI)
Public API naming to match Azure SDK guidance.
Adding SAS token documentation links.

Feature/bug fixes:

Add inbound Provisioning message parsing. Optimizing string matching.
Enable the Paho transport in CI.
Fix User-Agent

Question: Why did you explicitly rebase/squash all your commits into one before merging the PR? We "squash and merge" when merging the PR anyway, so just curious. Having the commits within the PR (with breakdown on how the particular feedback was addressed), could be useful for some, especially for future reference.

Question: Why did you explicitly rebase/squash all your commits into one before merging the PR? We "squash and merge" when merging the PR anyway, so just curious. Having the commits within the PR (with breakdown on how the particular feedback was addressed), could be useful for some, especially for future reference.

I think that's up for the dev submitting the PR.
In this case the PR was large do to the large dependency changes and the merge-block in place for the last few weeks. Having the PR large meant that the review took too long and was blocking me from making progress. I rebased & squashed to simplify my work-flow when building on top of the PR branch.


Add Per Topic IncomingMessages metric for Kafka.

What does this PR do?
This adds a per topic incoming message rate for Kafka brokers.
Motivation
At the moment there is no way to easily see incoming messages by topic. This can make diagnosing upstream problems difficult. I've placed this under kafka.topic to avoid confusion with overall broker stats.
Review checklist

[x] PR has a meaningful title or PR has the no-changelog label attached
[x] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
[ ] If PR adds a configuration option, it has been added to the configuration file.

Additional Notes
Even with tagging by topic, this should come well under the 350 metric JMX limit.

👍  on this.
It actually used to be part of this check about two years ago, not sure why it was removed, and when I asked no one at Datadog knew why it was removed... I suspect it was accidentally deleted when the checks were split out from the main dd-agent repo into this integrations-core repo.


Fix instantiating observers on app boot.

When adding support for Rails 4.1, 4.2 and 5.0, the instantiate_observers
call that happened after boot was erroneously removed.
https://github.com/rails/rails-observers/pull/39/files#diff-9db46e46113d0c2eeb41f5d6f08bcac4L24
This covered a regression in the test suite for the rake integration and
also broke the gem for apps.
The reason the test/rake_test.rb failed was that a require to active_record/base
had been removed which rails-observers depended on.
https://github.com/rails/rails/commit/9e9793b440c044b765f2d1f702feeb92aef2b139
Without that we're this circular dependency error:
kaspers-macbook-pro:observer kasperhansen$ cat Rakefile

require_relative 'config/application'

namespace :user do
  task :count => :environment do
    puts User.count
  end
end

Rails.application.load_tasks

kaspers-macbook-pro:observer kasperhansen$ bin/rake user:count
rake aborted!
Circular dependency detected while autoloading constant User
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:334:in `observed_class'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:325:in `observed_classes'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:345:in `observed_classes'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/activerecord/observer.rb:100:in `observed_classes'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:341:in `initialize'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:186:in `instantiate_observer'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:108:in `block in instantiate_observers'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:108:in `each'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/active_model/observing.rb:108:in `instantiate_observers'
/Users/kasperhansen/Documents/code/rails-observers/lib/rails/observers/railtie.rb:42:in `block (2 levels) in <class:Railtie>'
/Users/kasperhansen/Documents/code/observer/app/models/application_record.rb:1:in `<top (required)>'
/Users/kasperhansen/Documents/code/observer/app/models/user.rb:1:in `<top (required)>'
/Users/kasperhansen/Documents/code/observer/Rakefile:8:in `block (2 levels) in <top (required)>'
Tasks: TOP => user:count
(See full trace by running task with --trace)

That's because User loads ActiveRecord::Base which then instantiates
the observers in its on_load hook, finally calling observed_class
which constantizes the very User constant we're loading!
One fix is to add a require to active_record/base manually here, because
we depend on the load hooks having been fired before model constants are
loaded.
(I didn't look into reorganizing the code such that observed_class isn't
needed on observer instantiation.)
This has the added benefit of not breaking the gem should Rails remove
the require's in console or runner blocks as well.
I can reliably reproduce the above circular dependency error by commenting
out the added require "active_record/base". And when it's in the rake
task works:
kaspers-macbook-pro:observer kasperhansen$ bin/rake user:count
1

@rafaelfranca you worked on https://github.com/rails/rails/commit/9e9793b440c044b765f2d1f702feeb92aef2b139, but don't the console and runner blocks have the same problem of triggering set_configs too soon?
https://github.com/rails/rails/blob/83f39a3bcf3f50d12d41bff4a110c57e2e4be605/activerecord/lib/active_record/railtie.rb#L52-L60


[FR] Allow to publish with GHA on an existing content already deployed

It would be interesting to be able to have a way to publish to an existing content.
With rsconnect, there is several solution for that:

Most of the time, i'll use the appId because you can easily find it (in the url of the content).
deployApp also allow to pass the appName which is unique - but unless you remember what you set or you consult with rsconnect::deployments to find it again. I am not sure you can find it easily in your app webpage.

The API offer another way using the GUID (which you can easily find in the INFO part of your app page).
I think I would like to do something like this (example using a bookdown project, deploying static bookdown result here in book folder already containing a manifest)
      - name: Publish the book
        uses: rstudio/actions/connect-publish@main
        with:
          api-key: ${{ secrets.RSC_BETA_TOKEN }}
          url: https://beta.rstudioconnect.com/
          access-type: logged_in
          dir: _book
          content-id: 14655

or
      - name: Publish the book
        uses: rstudio/actions/connect-publish@main
        with:
          api-key: ${{ secrets.RSC_BETA_TOKEN }}
          url: https://beta.rstudioconnect.com/
          access-type: logged_in
          dir: _book
          content-guid: 1d9c4665-eae0-4b3c-ab75-5652653ecb2f

It would also be the app name which is unique on connect
      - name: Publish the book
        uses: rstudio/actions/connect-publish@main
        with:
          api-key: ${{ secrets.RSC_BETA_TOKEN }}
          url: https://beta.rstudioconnect.com/
          access-type: logged_in
          dir: _book
          name: demo-bookdown-deploy

This is a broader topic, but being able to set most of what rsconnect::deployApp could do would be great. But that is Bonus.
Currently, without this feature describe above, I can't really switch from a Manual Deployment workflow for a GHA deployment workflow without removing my previous content and re-publishing
See examples workflows I am testing in https://github.com/cderv/deploy-bookdown-demo/tree/master/.github/workflows. I can do it with

rsconnect-python CLI tool : https://github.com/cderv/deploy-bookdown-demo/blob/d1a13809959cb1ef37c8175046df08ca762b59ff/.github/workflows/bookdown-rsconnect-python.yaml#L56
Using R connectapi 📦 : https://github.com/cderv/deploy-bookdown-demo/blob/d1a13809959cb1ef37c8175046df08ca762b59ff/.github/workflows/bookdown.yaml#L56

This should now be possible for the cases where you want to specify an app GUID or name, e.g.:
      - name: Publish the book
        uses: rstudio/actions/connect-publish@main
        with:
          api-key: ${{ secrets.RSC_BETA_TOKEN }}
          url: https://beta.rstudioconnect.com/
          access-type: logged_in
          dir: _book:1d9c4665-eae0-4b3c-ab75-5652653ecb2f

      - name: Publish the book
        uses: rstudio/actions/connect-publish@main
        with:
          api-key: ${{ secrets.RSC_BETA_TOKEN }}
          url: https://beta.rstudioconnect.com/
          access-type: logged_in
          dir: _book:demo-bookdown-deploy

Please reopen if you the above examples don't work correctly :grin:

This is working partially:
The app is correctly deploy (as in I can access it on the server), but the action still show failure : https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:44
I see that:

New app is correctly created: https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:44
Vanity path is still trying to be set when I provide a app name only - obviously this is still failing (I wasn't expecting this to be hapenning if no vanity url is asked): https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:24
Access right is correctly set: https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:27
Bundle is correctly uploaded: https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:30
And app correctly deployed: https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:33
But a last polling is unsuccessful it seems: https://github.com/cderv/deploy-bookdown-demo/runs/1545562709?check_suite_focus=true#step:9:43

not sure what the error is - But I can confirm the app can be access on beta.rstudioconnect.com here


Refactor pool creation token selection

Changes:

Added windowing to token list in pool creation
Added metapool creation identifier in summary
Added clear button for clearing form in token selection
Added crvUSD to all supported networks quick lists in token selection
Added basepools checkbox in token selection

first token is fraxbp, and usdc still shows. it should not show.

also if user has chosen basepool as the first token, the view basepool option should be removed for the second token.

Pool Type is illegible.

gaps seem non-uniform?


Replace deprecated string interpolation usage

This PR replaces the now deprecated (as of PHP 8.2) ${var} usage in string interpolation by {$var}.
Note that this change is backwards compatible with previous versions of PHP.
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/tests/HTML5DOMDocumentTest.php on line 67
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/tests/HTML5DOMDocumentTest.php on line 74
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/src/voku/helper/SimpleHtmlDom.php on line 508
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/src/voku/helper/SimpleHtmlDom.php on line 520
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/src/voku/helper/SimpleHtmlDom.php on line 555
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/src/voku/helper/SimpleXmlDom.php on line 458
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/src/voku/helper/SimpleXmlDom.php on line 470
Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /usr/src/app/src/voku/helper/SimpleXmlDom.php on line 505

Reference: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

This change is

This PR looks good to me.  Can we get a new release that will support PHP 8.2 without depreciations?  Also see PR https://github.com/voku/simple_html_dom/pull/93
Thanks!

LGTM too,  and I need this update too

Check out PR https://github.com/voku/simple_html_dom/pull/93 while you are at it.  This is a more serious issue, as the library does not work on 8.2.

Actually I dont know about #93 issue, I used 8.2 on production and it work as expected. Just have deprecated warning like on this PR.
But yeah, I hope that will be merged too. Maybe in the future  I use the feature that has issue on 8.2.

Version 4.8.8 is released with this fix.


Allow list indirectly dependant modules as optimized dependencies.

Clear and concise description of the problem
When use with https://github.com/antfu/vite-plugin-optimize-persist, it heuristic find out dependencies and persistence them as optimizedDeps. But a real-world app contains a huge number of indirect dependencies, we startup app failure since can't resolve the force included dependencies.
Assume this structure:

Vite entry project sub-package A imports sub-package B.

// @monorepo/packageA
import { B } from '@monorepo/packageB'

sub-package B imports cjs packages C, D, E, they are installed as dependencies of sub-package B.

// @monorepo/packageB
import C from 'c';
import D from 'd';
import E from 'd';

plugin writes the B's dependencies C, D, E as optimizeDeps of sub-package A. Cause dev error after cleaning node_modules:

Suggested solution
consider reuse indirect dependencies if we added them.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Vite already supports listing indirect dependencies via optimizeDeps.include: ['@monorepo/packageB > c', 'foo > bar > baz']. vite-plugin-optimize-persist would need to be configured to generate this form of syntax. I'd suggest opening an issue there to use this feature instead.

Vite already supports listing indirect dependencies via optimizeDeps.include: ['@monorepo/packageB > c', 'foo > bar > baz']. vite-plugin-optimize-persist would need to be configured to generate this form of syntax. I'd suggest opening an issue there to use this feature instead.

Can you take a look at this wip branch ?
https://github.com/zheeeng/vite-plugin-optimize-persist/blob/wip/example/monorepo/foo/package.json
Console reports reosving dependency failure. I can't figure out how to set the correct optimizeDeps option.

@zheeeng The > syntax is only supported in Vite 2.5.2 and above. It looks like the repo is using Vite 2.4.4


Optimize String#to_u methods for the case of a negative number

This makes String's to_u64_info method return early when the number that should be converted to an unsigned integer is negative.
Benchmark.ips do |bm|
  bm.report("old") do
    "-112978314788778".to_u64 { false }
  end

  bm.report("new") do
    "-112978314788778".new_to_u64 { false }
  end
end

old  58.13M (  17.2ns) (± 5.40%)  0 B/op  10.21× slower
new  593.7M (  1.68ns) (± 4.43%)  0 B/op        fastest

Benchmark.ips do |bm|
  bm.report("old") do
    "-112978314788778913431478989314731437891343734789943413789474187178137914713173484137134780".to_u16 { false }
  end

  bm.report("new") do
    "-112978314788778913431478989314731437891343734789943413789474187178137914713173484137134780".new_to_u16 { false }
  end
end

old  43.73M ( 22.87ns) (± 8.58%)  0 B/op  13.42× slower
new 586.69M (   1.7ns) (± 3.40%)  0 B/op        fastest

It improves performance in an edge case only, but that doesn't mean it's not worth merging, as it's only a small bit of code.


Open API Documentation - Add errors based on resource's managed object annotations

Open API documentation should add the following errors:

409 if the managed object has a @Column(unique: true) annotation
400 for POST operations if the managed object has a non-nullable field

@joeconwaystk let me know if this doesn't make sense and i'll close it.

Is this for ManagedObjectController?  if so, that makes sense

Well, technically all could return a 409 because a primary key is always unique.


[SPARK-18723][DOC] Expanded programming guide information on wholeTex…

What changes were proposed in this pull request?
Add additional information to wholeTextFiles in the Programming Guide. Also explain partitioning policy difference in relation to textFile and its impact on performance.
Also added reference to the underlying CombineFileInputFormat
How was this patch tested?
Manual build of documentation and inspection in browser
cd docs
jekyll serve --watch

Can one of the admins verify this patch?

I added a few more sentences describing the cases in which the user might want to use the argument. However, I am afraid this might be a little too descriptive.

Test build #3483 has started for PR 16157 at commit d76c6c5.

OK, net-net I am OK merging this doc change even if it's not exactly what I might write. It does contain useful additional detail that's accurate at the moment.

Sorry for the delay. You are probably right that the partitioning is primarily determined by data locality and that it is therefore appropriate in some cases and shouldn't be worded such as to imply it isn't usually appropriate. I will think about how to word it more appropriately and remove the implementation specifics.

Test build #3505 has started for PR 16157 at commit 781a11e.

Test build #3505 has finished for PR 16157 at commit 781a11e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master


fix: address dependencies issues

This PR addresses issues related to the launch of voice2image and real-time-translation, which arise from problems related to dependencies usage.
Even after installing all the dependencies, the following 2 commands were failing
python voice2image/main.py

python real-time-translation/main.py

Description

Adjusted the import of environment keys
Resolved errors related to the gradio library
Added requirements.txt for easy installation for development environment.

Impact:
Now voice2image and real-time-translation are both launching.

@diegofiori

@0xf333 thanks a lot for the contribution 😄


cmdstan fails to build

Summary:
See https://github.com/stan-dev/cmdstan/issues/770. I just tried with 2.29.0 and get the same error.
Description:
Describe the issue as clearly as possible.
Reproducible Steps:
Please report steps to reproduce the issue. If it's not possible to reproduce, please include a description of how you discovered the issue.
If you have a reproducible example, please include it.
Current Output:
The current output. Knowing what is the current behavior is useful.
Expected Output:
Describe what you expect the output to be. Knowing the correct behavior is also very useful.
Additional Information:
Provide any additional information here.
Current Version:
v2.29.0

I wonder if https://github.com/stan-dev/math/pull/2618 could have resolved this?


Install Python Requirements

I tried to run "Install Python Requirements" to see if i have missing documents, but i received multiple errors such as
1.###  "Could not find a version that satisfies the requirement opencv-python==<IP_ADDRESS> (from versions: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>)
No matching distribution found for opencv-python==<IP_ADDRESS>"****
2. "Could not find a version that satisfies the requirement opencv-contrib-python==<IP_ADDRESS> (from versions: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>)
No matching distribution found for opencv-contrib-python==<IP_ADDRESS>"
3. "Command "c:\users\bahaa\anaconda3\python.exe -m pip install --ignore-installed --no-user --prefix C:\Users\Bahaa\AppData\Local\Temp\pip-build-env-4840oel0 --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- wheel setuptools Cython "numpy==1.9.3; python_version=='3.5'" "numpy==1.12.1; python_version=='3.6'" "numpy==1.13.1; python_version>='3.7'"" failed with error code 1 in None"
Even though i already have opencv-python <IP_ADDRESS> & opencv-contrib-python latest version. Do i ignore these errors?
Kindly Find attached files.

Thank you

We're pinning the versions to the latest versions we tested. You might want to try more current versions and comment out (or update) the pip commands.  I just updated them in PR #23 .
Also the error can happen due to old versions of pip or wheel requirements that are not on your platform. Should not be much of a problem if you were able to install more current versions, though. So we'll just update.


ci: Update actions/checkout to always use v4

CI was using a mix of version 3 and 4. Version 3 results in a warning within the GitHub Actions UI as it was using a version of NodeJS that is deprecated within the GitHub Actions infrastructure.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ignore_case + regex support in have.value & co

Consider adding regex support to the following conditions:

have.value
have.value_containing
have.attribute(name).* (all *)
have.no.* versions of same conditions

Take #529 as example of implementation and also the corresponding ignore case implementation...

ignore_case was implemented for value-like attribute conditions in one of commits for #530 on applying _EntityHasSomethingSupportingIgnoreCase and _CollectionHasSomeThingsSupportingIgnoreCase... Something similar can be implemented in context of ...SupportingRegexPatterns


Missing extension: Please add icon pack extension like VS code

SQL Operations Studio Version: 0.31.4

Please add icon pack extension like VS code
Steps to Reproduce: -

Closing older issues.  Please reactive if this is impacting an extension under active development.


Update README.md

Inheritance is closer to Java than C++. C++ allows multi-inheritance, D doesn't. Classes are also classes in D, just like Java; both reference types. In C++ classes are value-types and are basically wrappers on-top of structs.

thanks!


Top level attribute definition in a devfile

The existing devfile does not have a way to define global attributes. If there are some values that I wanted to reuse in different sections of the devfile, I need to repeat those values in various places within a devfile.
Sample use case:
I wanted to create a couple of maven stacks and all of them have pretty much the same content except that the commands/images will make use of a different version of java. If I can define global attributes in a devfile, I can use the attribute key in places where I need to reference the java version, e.g. image path, commands, etc. Then, I can just have a  single parent for those maven stacks and each child devfile of them just override the java version attribute in the devfile to provide the specific java version behaviour in different stacks.
Proposal:

Define attributes as a map of implementation-dependent free-form YAML attributes on the top level in a devfile.
Use {{attribute-name}} to refer to the attribute with the key attribute-name
To the implementation simple and avoiding to the need introducing hierarchy path on attribute reference, only attributes on the top level can be resolved within a devfile. Attributes defined on other levels, e.g. attributes defined under a command, cannot be resolved.

Example:
This example defines a global attribute java version number on the top level and references the value of the variable in the container image field.
schemaVersion: 2.0.0
metadata:
  name: java-maven
  version: 1.1.1
attributes:
  javaVersion: 11
components:
  - name: tools
    container:
      image: quay.io/eclipse/che-java{{javaVersion}}-maven:nightly
...

Note: Using this mechanism, we can also address the requirement https://github.com/devfile/api/issues/149 where each container can refer to the global attribute value and add the required environment variables in the container definition.

The logic on replacement of the attributes needs to be part of the API  implementation.

Since a child and a parent could each define a given attribute with a different value, it seems like we'd have to define the order of global attribute substitution vs. child/parent merge.   It seems like we might need to do the global attribute substitution in the child first if we need to use the value in order to reference the parent.    At that point, when we merge in the parent, we'd need to merge the global attributes of the child + parent (child overriding) to resolve substitutions in content coming from the parent.

The attribute should have the same overriding rule as the rest of the other elements:

If a child is declaring an overriding global attribute, i.e. under the parent element, the attribute value will be resolved as the overriding value from the child.
If a child tries to define a new global attribute outside of the parent element but the parent devfile also has the same attribute, it will result in a validation error.

If we stick to these generic overriding rules, then we can just merge the parent and child first and then do the attribute substitution on the merged model.

JIRA: https://issues.redhat.com/browse/RHDEVDOCS-2668

For the record, here is a summary of what we are going to do for the top-level free form attributes, global string variables, and the existing attributes in the metadata: https://github.com/devfile/api/pull/352#issuecomment-806857030

@elsony I think we should rename the issue title, since this logic is for variables. And open one more for top level attributes for a historical perspective?


Editor not updating reference when class file moved to new folder

Environment data
dotnet --info output:
.NET Core SDK (reflecting any global.json):
Version:   2.1.402
Commit:    3599f217f4
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.13
OS Platform: Darwin
RID:         osx.10.13-x64
Base Path:   /usr/local/share/dotnet/sdk/2.1.402/
Host (useful for support):
Version: 2.1.4
Commit:  85255dde3e
.NET Core SDKs installed:
1.0.1 [/usr/local/share/dotnet/sdk]
2.1.402 [/usr/local/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.4 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.4 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 1.0.4 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 1.1.1 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.4 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
VS Code version:
Version 1.29.1 (1.29.1)
bc24f98b5f70467bc689abf41cc5550ca637088e
C# Extension version:
1.17.1
MacOS 10.13.6 (17G3025)
Steps to reproduce
See also animated GIF below

dotnet new console
Open VS Code
Create root-level folders "Tests" and "Payroll"
Move Program.cs to Tests folder
Update Program.cs namespace to new folder
Create declaration and instantiation to a variable of a new type
Use CMD-. fix to generate new class in new file
Move newly created file to Payroll folder
Update namespace in new file
Add using statement in Program.cs to reference Payroll namespace
Save all files
Hover over declaration statement in Program.cs. Note type can't be found and is referred to as being in Tests namespace

Expected  behavior
New type should be found in correct namespace
Actual behavior
New type is not found in correct namespace
Other info
Restarting OmniSharp via command palate corrects issue
Related to Issue 2040?

This is really annoying! Thanks for making a nice bug report.
I was investigating this recently and found problem with vscode extension not properly reporting FileChangeEvents to o#. A lot of fileChangeEvents are simply "eaten", and I suspect a lot of it is upstream in VSCode's FileSystemWatcher.
In the example you provided: once you drag'n'drop file from folder A to B, what should correcty happen is this:

file delete event for old filePath
file creation event for new filePath, creating new transient file at new filePath

what actually happens:

no file deletion event:  o# still thinks old file is alive, as if it has never been deleted
no file creation event at new path
file buffer update on new path a moment later - creating new transient file at newFilePath
since old path was never deleted, o# now thinks there are two files with the same content, leading to a storm of "Already defined" events.

Also note: moving file in the same folder (renaming) dispatches file change events ok, but renaming folders / moving from folder to folder never works

I'm having a similar issue renaming classes (might be the same issue because like moving a file, the reference to it changes). The problem is solved by restarting VSCode so the extension is also reloaded and recognizes the renamed class (is there a way to reload the extension without restarting VSCode?). Another issue also happened that it was reporting that this renamed class had duplicated methods, when they weren't. Reloading VSCode fixed it. Maybe all this is related to this issue well reported here.

@delroh You can use the "Restart OmniSharp" command instead of restarting Code

@jimholmes I believe a simple version of this bug is:

dotnet new console
create a directory next to the csproj
move Program.cs into the new directory
intellisense doesn't work in Program.cs

Addressing this with https://github.com/OmniSharp/omnisharp-roslyn/pull/1368

A lot has changed with project watching since this issue as opened. If you are still running into problems, please open a new issue.


Nesting of pkg_filegroup is not possible

I am using pkg_filegroup on sources that are a pkg_filegroup again.
This fails with
in srcs attribute of pkg_filegroup rule //:codeql-cpp: '//odasa-buildutils:dist-generic' does not have mandatory providers: 'PackageFilesInfo' or 'PackageDirsInfo' or 'PackageSymlinkInfo'.

Is there any specific reason that this is not allowed?
Using pkg_files everywhere (except at the top-level) is legal starlark, but needs very careful strip_prefix handling to not have too many/the wrong prefixes (or I don't understand strip_prefix well enough).

Thanks for asking.

Is there any specific reason that this is not allowed?

I thought about doing this in the original pkg_filegroup design, but in discussions with @aiuto, we concluded that doing so would add too much complexity for a feature without immediate use.  That aside, it should be doable.

Using pkg_files everywhere (except at the top-level) is legal starlark, but needs very careful strip_prefix handling to not have too many/the wrong prefixes (or I don't understand strip_prefix well enough).

Yeah, you do need to be careful with strip_prefix, and the behavior can be confusing or surprising at times.  We're looking into making it more intuitive in #354.
I'm not opposed to implementing this in the long-term, and would be willing to look at patches to add such support.

To add to Andrew's point about "too much complexity ... without immediate
use".
Please feel free to show a good example of what you want to accomplish with
a syntax that is intuitive and not to bulky.
We are driving a lot of design from actual use cases and a "why this
feature is important" is super helpful.
On Thu, Aug 19, 2021 at 1:56 PM Andrew Psaltis @.***>
wrote:

Thanks for asking.
Is there any specific reason that this is not allowed?
I thought about doing this in the original pkg_filegroup design, but in
discussions with @aiuto https://github.com/aiuto, we concluded that
doing so would add too much complexity for a feature without immediate use.
That aside, it should be doable.
Using pkg_files everywhere (except at the top-level) is legal starlark,
but needs very careful strip_prefix handling to not have too many/the
wrong prefixes (or I don't understand strip_prefix well enough).
Yeah, you do need to be careful with strip_prefix, and the behavior can
be confusing or surprising at times. We're looking into making it more
intuitive in #354 https://github.com/bazelbuild/rules_pkg/issues/354.
I'm not opposed to implementing this in the long-term, and would be
willing to look at patches to add such support.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/issues/415#issuecomment-902122571,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHDYLWHWGIYSBBFZQLLT5VAVFANCNFSM5COOFVKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Okay, let me explain better what I want to achieve, with hopefully not too many internal terms.
I am building a prototype how to package what we call a CodeQL distribution (a zip file containing our software).
This is a zip archive that contains:

A base distribution (arch-specific, think compiled C binaries)
A base distribution (generic, think config files+java binaries)
1..n language packs

Each language pack again can contain an arch-specific part and a generic part.
It makes sense for us to package up these language packs into zip files independent from the distribution, but also re-use the same pkg_filegroup to pack the distribution.
Thus, I want to map:

Each part of the CodeQL distribution to a pkg_filegroup. These get joined together by a pkg_filegroup of filegroups into the main distribution (no prefix-stripping or anything going on, just taking the union of the filegroups).
each languagepack can consist of a filegroup of arch-specifc and generic bits, as these usually need different prefix-munging applied to land in the correct paths

These filegroups can then serve as input to a bunch of pkg_zip targets, for different combinations.
Think: A full distribution/just a single language pack/a base distribution+a single language pack.
In the future, I'd also like to generate a pkg_tree instance for each of the zip targets, as we then can skip the zip/unzip part for the local development cycle.
For local development, we need the packaging step to move all the files to the correct paths, as our source paths and the paths in the released artifact are different, but we do not need to spend CPU cycles on actually packing/compressing anything.
Syntax-wise, I think you're there already, if I could use a pkg_filegroup label as srcs for another pkg_filegroup, and no extra path munging is applied. I.e. the top-level pkg_filegroup would just be a union over the pkg_filegroups specified as srcs.

We actually found a internal use case for this functionality, and a colleague of mine has implemented it.  A PR for it should be available soon.


bdd-spring-1557241283 to 0.0.1

Promote bdd-spring-1557241283 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create Benchmarking folder for relevant modules

@denisshevchenko you should have a look at this. It will touch the modules you use in the tx gen.

bors r+


T01.02-Solution-DisplayToyList

/*

Copyright (C) 2016 The Android Open Source Project

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

 http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package com.example.android.favoritetoys;

import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.widget.TextView;
import java.util.ArrayList;
public class MainActivity extends AppCompatActivity {
// TODO (1) Declare a TextView variable called mToysListTextView
TextView mToysListTextView;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    mToysListTextView = (TextView) findViewById(R.id.tv_toy_names);

    // TODO (3) Use findViewById to get a reference to the TextView from the layout
    ToyBox t = new ToyBox();
    String[] names = t.getToyNames();
    // TODO (4) Use the static ToyBox.getToyNames method and store the names in a String array
    for (int i=0 ; i<names.length; i++){
        mToysListTextView.append(names[i]+"\n\n\n");
    }
    // TODO (5) Loop through each toy and append the name to the TextView (add \n for spacing)
}

}

Any explanation on why this didn't work??
for (String toy: listOfToys) {
            mToysListTextView.append(toy + "/n/n/n");
        }


[BUG] APK recompilation without changes fails

Information

Apktool Version (apktool -version) - Compiled from the latest source
Operating System (Mac, Linux, Windows) - Windows 10 20H2 19042.906
APK From? (Playstore, ROM, Other) - From ROM: MIUI (umi 21.3.31 cn Beta)

Stacktrace/Logcat
java -jar Tools\APKTool\apktool.jar b --output ..\MiuiGallery_APK\MiuiGallery_.apk ..\MiuiGallery_APK  -p Tools\APKTool\Frameworks
I: Using Apktool 2.5.1-baf8bb-SNAPSHOT
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether sources has changed...
I: Smaling smali_classes2 folder into classes2.dex...
I: Checking whether sources has changed...
I: Smaling smali_classes3 folder into classes3.dex...
I: Checking whether resources has changed...
I: Building resources...
W: Failed to generate resource table for split ''
W: C:\Users\Luffitys\Downloads\Porting-Tools\Porting-Tools\..\MiuiGallery_APK\res\values\dimens.xml:3450: error: Error: String types not allowed (at 'APKTOOL_DUMMY_242' with value '').
W:
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\Luffitys\AppData\Local\Temp\brut_util_Jar_86514711303219238359035965874581013338.tmp, p, --forced-package-id, 127, --version-code, 266832, --version-name, <IP_ADDRESS>, --no-version-vectors, -F, C:\Users\Luffitys\AppData\Local\Temp\APKTOOL8898803618868309521.tmp, -e, C:\Users\Luffitys\AppData\Local\Temp\APKTOOL5615666844594734149.tmp, -0, arsc, -I, Tools\APKTool\Frameworks\1.apk, -I, Tools\APKTool\Frameworks\16.apk, -I, Tools\APKTool\Frameworks\18.apk, -S, C:\Users\Luffitys\Downloads\Porting-Tools\Porting-Tools\..\MiuiGallery_APK\res, -M, C:\Users\Luffitys\Downloads\Porting-Tools\Porting-Tools\..\MiuiGallery_APK\AndroidManifest.xml]

Steps to Reproduce

apktool d MiuiGallery.apk -p frameworks
apktool b MiuiGallery -p frameworks

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
https://drive.google.com/drive/folders/1HIaPML57LhBRHuzcVolmKfzCLUhpbNY7?usp=sharing
APK
If this APK can be freely shared, please upload/attach a link to it.
https://drive.google.com/drive/folders/1HIaPML57LhBRHuzcVolmKfzCLUhpbNY7?usp=sharing
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? - Yes
If you are trying to install a modified apk, did you resign it? - /
Are you using the latest apktool version? - Yes

Decompiling and recompiling results in an error caused by a bad dimens.xml. Removing the dummy lines from dimens.xml and public.xml results in a successful recompilation, however I don't know if it breaks APK functionality.

Duplicate of #2501 #2462

Thanks, as mentioned above. Duplicates in a few tickets.


Tag sidebar search bar shown but not interactable with tag types shown

Open a binary
Open the tag sidebar widget
Switch to Tag Types
Notice that the tag filter is still shown but cannot be interacted with

The widget is actually disabled but there's no visual indication unless the user had typed something in the filter box already

Resolved in dev builds >= 4.1.4917. It should now be far more obvious when a FilterEdit is disabled.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

ok i do it


websocket feature parity

Is there a roadmap that discusses websocket features? It looks like websockets is pretty far behind in feature parity.
I'm considering moving from kafka to pulsar but topics regex consumer is an important feature for me.

feature parity would indeed be pretty awesome and would imho help adoption further

for latest state see: https://github.com/apache/pulsar/wiki/Client-Features-Matrix

imho websocket is for pulsar something like the window to the web world. It enables usage of pulsar for fields like web-tracking,live  chat and many more...
If one see the potential of this community, on should give websocket bugs and features a fair priority in the next releases.
While writing this there are roughly 25 issues regarding websocket topics open.
https://github.com/apache/pulsar/issues?q=is%3Aissue+is%3Aopen+websocket+
3 includes open pull request.
Of course not all fields have the same importance for adoption of pulsar.
But the points

docs
security and
performance
are important for everyone thinking about using pulsar with websocket..


Conflicting Type definitions - Typescript vs Webpack Module Resolution

I'm having an issue that I believe must be related to the difference in how Webpack and Typescript resolve moduals.
When I use this plugin I get a number of conflicting type definitions.
I'm posting here because I've scoured the internet and haven't found a solution to this.
ERROR in<EMAIL_ADDRESS>(103,13): Cannot redeclare block-scoped variable 'console'.

ERROR in<EMAIL_ADDRESS>(148,13): Duplicate identifier 'require'.

ERROR in<EMAIL_ADDRESS>(2381,15): Duplicate identifier 'URL'.

ERROR in<EMAIL_ADDRESS>(2399,15): Duplicate identifier 'URLSearchParams'.

ERROR in<EMAIL_ADDRESS>(2417,14): Cannot export 'URL'. Only local declarations can be exported from a module.

ERROR in<EMAIL_ADDRESS>(2417,19): Cannot export 'URLSearchParams'. Only local declarations can be exported from a module.

ERROR in<EMAIL_ADDRESS>(8723,14): Duplicate identifier 'require'.

ERROR in<EMAIL_ADDRESS>(8741,11): Cannot redeclare block-scoped variable 'console'.

ERROR in<EMAIL_ADDRESS>(8749,18): Subsequent property declarations must have the same type.  Property 'geolocation' must be of type 'Geolocation', but here has type 'GeolocationStatic'.

ERROR in<EMAIL_ADDRESS>(8752,11): Cannot redeclare block-scoped variable 'navigator'.

ERROR in<EMAIL_ADDRESS>(203,13): Duplicate identifier 'require'.

ERROR in project/node_modules/rxjs/scheduler/VirtualTimeScheduler.d.ts
(24,15): Property 'work' in type 'VirtualAction<T>' is not assignable to the same property in base type 'AsyncAction<T>'.
  Type '(this: VirtualAction<T>, state?: T | undefined) => void' is not assignable to type '(this: AsyncAction<T>, state?: T | undefined) => void'.
    The 'this' types of each signature are incompatible.
      Type 'AsyncAction<T>' is not assignable to type 'VirtualAction<T>'.
        Property 'index' is missing in type 'AsyncAction<T>'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(13389,11): Duplicate identifier 'URL'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(13405,13): Duplicate identifier 'URL'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(13412,11): Duplicate identifier 'URLSearchParams'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(13439,13): Duplicate identifier 'URLSearchParams'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(15720,13): Duplicate identifier 'URL'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(15721,13): Duplicate identifier 'URLSearchParams'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(15747,13): Cannot redeclare block-scoped variable 'navigator'.

ERROR in project/node_modules/typescript/lib/lib.dom.d.ts
(15920,13): Cannot redeclare block-scoped variable 'console'.

Here's the diff of my webpack config:
───────────────────────────
modified: config/webpack.config.dev.js
───────────────────────────
@ webpack.config.dev.js:8 @ const webpack = require('webpack');
const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
const WatchMissingNodeModulesPlugin = require('react-dev-utils/WatchMissingNodeModulesPlugin');
const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin');
+const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
const getClientEnvironment = require('./env');
const paths = require('./paths');

@ webpack.config.dev.js:129 @ module.exports = {
            include: paths.appSrc,
            loaders: [
              require.resolve('babel-loader'),
-              require.resolve('ts-loader'),
+              {
+                loader: 'ts-loader',
+                options: {
+                  transpileOnly: true,
+                },
+              },
            ],
          },
          // Process JS with Babel.
@ webpack.config.dev.js:264 @ module.exports = {
    // https://github.com/jmblog/how-to-optimize-momentjs-with-webpack
    // You can remove this if you don't use Moment.js:
    new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/),
+    new ForkTsCheckerWebpackPlugin({
+      tsconfig: paths.appTsConfig,
+    }),
  ],
  // Some libraries import Node modules but don't use them in the browser.
  // Tell Webpack to provide empty mocks for them so importing them works.

Why don't you take a working example and try and plug your code into that? https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker
Might make things easier for you.

Thanks for the quick reply.
I've taken a look a that as well as read the documentation. It looks like my issue is with this:
https://github.com/Realytics/fork-ts-checker-webpack-plugin#modules-resolution
The Webpack module resolution doesn't import the types that are conflicting however TypeScript does.
@johnnyreilly  Is there something in examples that I'm missing that resolves these conflicting Type definitions?

I'm going to guess that the problem either lies in your tsconfig.json or in your usage of the tsconfig-paths-webpack-plugin (I don't use it myself and so if that is the issue you might want to try asking on that project.)
Does your tsconfig.json  include all the files? Might be worth explicitly ensuring that it does and see where that leads.

FWIW I don't supply the tsconfig.json to the fork-ts-checker-webpack-plugin myself. Don't know if that's relevant

I was encountering this as well and some some people saying it's possibly to mismatched type definition packages. A rm yarn.lock && rm -rf node_modules && yarn fixed it for me.
 If that's the case you might have to do some manual surgery on them.
This was the main issue I was reading that led me down that path: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/18484

Thanks everyone!
@qdot's solution worked for me.


License?

Hello,
I was wondering under which license you are distributing this datepicker? It looks really great :-)
I'd love to use it for one of my projects but I need to have the license question answered.
Thanks in advance,
Peter

Hi! MIT
https://github.com/KosyanMedia/tp-datepicker/commit/23fe487823b4f9a440137b926187df145dc9e462
Thank you!

thanks


Add ability to use multiple Facets of the same type

e.g.
<Entity>
  <Image src="https://example.com/img1.jpg" width="100" height="150" position={[0, 0, 0]} />
  <Image src="https://example.com/img2.jpg" width="10" height="10" position={[90, 10, 0]} />
  <ThreeView>
    <mesh></mesh>
  </ThreeView>
</Entity>

Will require a way to query for multiple facets, e.g.
query.loop([ThreeView, [Image]], (e, [view, image]) => {
    });

Or potentially, Facet could inherit from React.Component to allow children?
<ImageFacet>
  <image one>
  <image two>
</ImageFacet>

Will need some knowledge of mapped types in order to implement arrays of types in queries.


aws-wrangler creating new versions for iceberg table and creating metadata for each new version

As I am trying to write data to the existing iceberg table using the AWS-wrangler without changing any schema, where it is generating the new versions for each record that we are inserting in the iceberg table and the old versions metadata was stored in our S3 bucket in huge amount. As we are writing records frequently to that table, versions increasing every time and metadata storage also crossed over 170 TB.
Is there any fix for this version increase issue? Can't this AWS wrangler library write to iceberg table without changing version every time, even if the schema was same?
The below is the code snippet that I am using, you can reproduce the issue using below code.
wr.athena.to_iceberg(
            df=df,
            database='test_database',
            table='my_table2',
            table_location='s3://bucket-testing1/my_table2/',
            temp_path=f's3://bucket-testing1/temp_path/',
            keep_files=True
        )

@jaidisido

I assume you are referring to the metadata under the temp_path? Is there any reason why you are setting the keep_files=True flag? Switching it to False would delete files under the temporary path. Beyond that my understanding is that the metadata is created by the Athena service and AFAIK we don't control that. @kukushking can you think of anything else here?

@jaidisido  we tried with keep_files=False as well but we are facing the same issue, and the temp_path is not for metadata, in that library they are using temp_path to create the temporary table and inserting records from that temporary table to iceberg table and then they deleting the temp table and temp_path.

Hi @B161851 @jaidisido Iceberg writes data in snapshots and keeps the metadata to support time travel. Consider optimizing the table via OPTIMIZE or VACUUM queries. More in the User Guide.


chore: Update Rubocop to 1.66.0

Replace all the dependabot PRs with one PR to resolve them all.
Dependabot PR description
Updates the requirements on rubocop to permit the latest version.

Release notes
Sourced from rubocop's releases.

RuboCop 1.66
New features

#13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. (@earlopain)
#13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. (@earlopain)
#13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. (@zopolis4)
#13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. (@earlopain)

Bug fixes

#13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. ([@koic][])
#13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. ([@koic][])
#13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. ([@koic][])
#13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. ([@koic][])
#13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. ([@koic][])
#13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. ([@koic][])
#13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. ([@koic][])
#13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. ([@koic][])
#13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. ([@koic][])
#13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). ([@koic][])
#13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@fatkodima][])
#13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. ([@koic][])
#13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. ([@koic][])
#13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. (@earlopain)
#13137: Fix an error for Style/ParallelAssignment when using __FILE__. (@earlopain)
#13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. (@earlopain)
#13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. ([@vlad-pisanov][])
#13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). ([@vlad-pisanov][])
#13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). ([@vlad-pisanov][])
#13126: Fix a false positive for Style/Alias when using multiple alias in def. ([@koic][])
#13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. ([@koic][])
#13118: Fix a false positive for Style/MapIntoArray when splatting. (@earlopain)
#13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. ([@koic][])
#13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. ([@koic][])
#13134: Fix false negative for Lint/Void when using using frozen literals. ([@vlad-pisanov][])
#13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. ([@koic][])
#13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. (@earlopain)
#13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. (@earlopain)
#13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. ([@protocol7][])

Changes

#13050: Allow get_!, set_!, get_?, set_?, get_=, and set_= in Naming/AccessorMethodName. ([@koic][])
#13103: Make Lint/UselessAssignment autocorrection safe. ([@koic][])
#13099: Make Style/RedundantRegexpArgument respect the EnforcedStyle of Style/StringLiterals. ([@koic][])
#13165: Remove dependency on the rexml gem. ([@bquorning][])
#13090: Require RuboCop AST 1.32.0+ to use RuboCop::AST::RationalNode. ([@koic][])

... (truncated)

Changelog
Sourced from rubocop's changelog.

1.66.0 (2024-08-31)
New features

#13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. ([@earlopain][])
#13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. ([@earlopain][])
#13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. ([@zopolis4][])
#13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. ([@earlopain][])

Bug fixes

#13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. ([@koic][])
#13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. ([@koic][])
#13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. ([@koic][])
#13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. ([@koic][])
#13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. ([@koic][])
#13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. ([@koic][])
#13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. ([@koic][])
#13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. ([@koic][])
#13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. ([@koic][])
#13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). ([@koic][])
#13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@fatkodima][])
#13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. ([@koic][])
#13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. ([@koic][])
#13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. ([@earlopain][])
#13137: Fix an error for Style/ParallelAssignment when using __FILE__. ([@earlopain][])
#13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. ([@earlopain][])
#13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. ([@vlad-pisanov][])
#13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). ([@vlad-pisanov][])
#13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). ([@vlad-pisanov][])
#13126: Fix a false positive for Style/Alias when using multiple alias in def. ([@koic][])
#13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. ([@koic][])
#13118: Fix a false positive for Style/MapIntoArray when splatting. ([@earlopain][])
#13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. ([@koic][])
#13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. ([@koic][])
#13134: Fix false negative for Lint/Void when using using frozen literals. ([@vlad-pisanov][])
#13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. ([@koic][])
#13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. ([@earlopain][])
#13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. ([@earlopain][])
#13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. ([@protocol7][])

Changes

#13050: Allow get_!, set_!, get_?, set_?, get_=, and set_= in Naming/AccessorMethodName. ([@koic][])
#13103: Make Lint/UselessAssignment autocorrection safe. ([@koic][])
#13099: Make Style/RedundantRegexpArgument respect the EnforcedStyle of Style/StringLiterals. ([@koic][])
#13165: Remove dependency on the rexml gem. ([@bquorning][])
#13090: Require RuboCop AST 1.32.0+ to use RuboCop::AST::RationalNode. ([@koic][])

1.65.1 (2024-08-01)

... (truncated)

Commits

c8edd7d Cut 1.66
9c106a5 Update Changelog
1e4b4c8 Add new Lint/UselessNumericOperation cop
d6b05cd [Fix #13150] Don't consider get_!, set_!, get_?, set_?, get_=, and ...
9e1e493 [Fix #13061] Add new Style/RedundantInterpolationUnfreeze cop
0431023 Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], ...
a2ef5b4 Fix false negatives for Style/MapIntoArray when initializing the destinatio...
2382ecb Fix false negative for Lint/Void when using using frozen literals
be6e656 Merge pull request #13172 from koic/fix_error_for_layout_empty_lines_around_e...
d8e0c87 Merge pull request #13175 from Earlopain/no-forwardable
Additional commits viewable in compare view

Given that 1.66.1 is out, I ran the latest patch release from the root of the repo and everything on the linter still passed.


Added notes count to each notebook

@levlaz Ok?

Fixed here https://github.com/levlaz/braindump/pull/195


能支持表格吗

Wish to add form

This issue was closed because it has been inactive for 7 days since being marked as stale.


fix: Load all known client-go auth plugins

Resolves: #40
Signed-off-by: Daniel Pacak<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fec324e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #41   +/-   ##
========================================
  Coverage          ?   5.50%
========================================
  Files             ?      22
  Lines             ?     800
  Branches          ?       0
========================================
  Hits              ?      44
  Misses            ?     755
  Partials          ?       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec324e...3983198. Read the comment docs.


Build non static binary with CGO

Hi
We use some tools that inject code in our apps for monitoring/tracing needs
For example, the tool Dynatrace (https://www.dynatrace.com) do that
Such tools inject code at runtime in JVM for example. For binary code, it can inject code in system calls via glibc.
The actual build of traefik (statically linked) is not compatible with these tools, as we need the binary use the OS glibc
Here i recompiled traefik with CGO and some docker image tuning to get my expected result
Does it make sens to you to build also a CGO enabled docker image (linux amd64 for my needs) ? I think others companies (big ones) use such tools to get deep monitoring of their apps.
If yes, i can make a PR quickly on the 1.7 branch and discuss about that

For more information on how to build for this use case, see : https://www.dynatrace.com/support/help/technology-support/application-software/go/#application-must-contain-a-symbol-table

Hi @WTFKr0 , thanks a lot for your interest and the description of your use case (please next time: keep the issue template, it make it easier to manage issues).
We are going to close refuse this feature request for the following reason: compiling dynamically Traefik would make it impossible to run inside the scratch Docker image, as it would create a strong dependency to underlying glibc. It might even have impacts on the alpine Docker image as it's using musl instead of glibc.
Again, we are sorry for the inconvenience. Don't hesitate to open a topic on the Community forum at http://community.containo.us, other users might have already been stuck on this use case and we could exchanges solutions, as orchestrating the Dynatrace agent around Traefik's docker container for example.


Keep an eye on warnings in target/soil_biosample_interleaved_generated.log

Closing in preparation of archiving this fork. Use the main DataHarmonizer repo for development.


AMBARI-25384 Ambari Files View is Vulnerable to XSS attack

What changes were proposed in this pull request?
AMBARI-25384 Ambari Files View is Vulnerable to XSS attack
(Please fill in changes proposed in this fix)
How was this patch tested?
Tested in UI,
Local Build Success
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 43.211 s
[INFO] Finished at: 2019-10-01T10:54:10+05:30
[INFO] Final Memory: 65M/597M
[INFO] ------------------------------------------------------------------------
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.

Hi @venkatasairamlanka  @sreenaths,
Can you please help me reviewing this PR

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5456/
Test PASSed.


Gallery examples of ModelChains for the DOE Solar Data Bounty Prize systems

The U.S. Department of Energy sponsored a Solar Data Bounty Prize that resulted in publication of detailed monitoring data and system configuration specs for five commercial PV systems.  I think we should create a section in the example gallery containing "reference models" for these systems.  This section could be expanded over time to have models corresponding to other public PV datasets too (RTC, NIST, etc).
System descriptions:

https://openei.org/wiki/PVDAQ/Sites/Farm_Solar_Array
https://openei.org/wiki/PVDAQ/Sites/Maui_Ocean_Center
https://openei.org/wiki/PVDAQ/Sites/SR_CO
https://openei.org/wiki/PVDAQ/Sites/Shine_On_Solar_Facility
https://openei.org/wiki/PVDAQ/Sites/Simon_Solar_Farm

Data available for download here: https://data.openei.org/s3_viewer?bucket=oedi-data-lake&prefix=pvdaq%2F2023-solar-data-prize%2F
It would be great to get these pages created and merged before March 21 so that they can be mentioned in the Modeling Tools webinar, so I'm tagging this for v0.10.4 (scheduled for mid-March).

Did DOE put funds aside for such work (seems like that would've made sense)?

To my knowledge, no special funding is currently available for this work.

I really like this idea.
SR_CO looks like thin-film with true-tracking, and I think Simon Solar Farm is fixed tilt 2P crystalline, so both could be good for validation of self-shade models.

A note for whoever makes these models: it's a little hard to tell, but from google street view it looks like SR_CO is a 4L array, so don't be surprised if the simple linear self-shading model doesn't perform very well.

https://www.google.com/maps/@40.3848262,-104.547199,3a,15y,351.87h,88.67t/data=!3m6!1e1!3m4!1szpxv4gM0fGnA5kIHnMoA1Q!2e0!7i16384!8i8192?entry=ttu

Here is a rough example model page for one system (SR_CO): https://gist.github.com/kandersolar/2ab973ea0b5d8cd45531a38c6e1fd06f
Feedback is welcome.
One general consideration for including this kind of example page in the docs is that to actually run the model and perform the comparison requires a lot of i/o (fetching PSM3 data and fetching the measured power data).  So far we have managed to avoid performing significant i/o in the example gallery, and it would be great to keep it that way.  I suggest we configure these particular examples to not be executed during the docs build, and just include the comparison plots as static PNGs.  We could also just omit the plots entirely, but IMHO the figures make the example page a lot more engaging.

Looks good to me. I'm surprised that you  have to guess at metadata given that that these are presumably the five winners.  Are they?
If we settle on a way to deal with large data in examples, then we could migrate some examples from DuraMAT to pvlib as well.

Regarding guessing metadata, I think that a lot of array geometry info (pitch, collector width, GCR, tracker height) was left off of the list of requested metadata for the bounty prize. And manufacturer/model info was optional to provide.
@kandersolar: all of your assumptions look reasonable to me.

Why not move the gallery to it’s own repo?

Why not move the gallery to it’s own repo?

I guess these models could be a repository alongside the other tutorial repositories, but (1) I don't envision these to really be tutorials, just examples, and (2) I don't think that would completely solve the i/o problem anyway -- the Data Prize datasets are pretty large (some 100s of MB), which is a lot to be downloading or storing no matter what repository the code lives in.

given that that these are presumably the five winners. Are they?

Yep, those are the winners.  It's too bad that more detailed design information wasn't collected, but at least it's possible to cobble together estimates for enough missing pieces to make a simple but still reasonable model.

Perhaps we don't really need those examples for pvlib purposes, but in your opener you also called them "reference models".  I think it would be a great open source/open data/open science achievement to run with the partial published data; scrape, glean and reverse engineer the missing bits and meta-bits; and then publish a complete reference model with documentation for each!


Encrypted Backups?

Per https://docs.microsoft.com/en-us/azure/sql-database/sql-database-automated-backups?tabs=single-database#encrypted-backups SQL Databases provide automatic encrypted backups if TDE is enabled.  Does Azure Synapse provide the same?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7c1ff9c-547c-e90f-36a7-2178a17d7951
Version Independent ID: 27aba9c4-cf0b-865f-ea24-513b65fc696a
Content: Backup and restore - snapshots, geo-redundant - Azure SQL Data Warehouse
Content Source: articles/sql-data-warehouse/backup-and-restore.md
Service: sql-data-warehouse
Sub-service: manage
GitHub Login: @kevinvngo
Microsoft Alias: anjangsh

@yuyuma Thank you for reaching out.
Yes it applies to Synapse as well. Please find more information here

We will proceed to close this issue now.
If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Test timeouts under CI.

• Failure [1.001 seconds]
61 type Queue
62 /home/runner/work/infix/infix/queue/queue_test.go:50
63 when the queue is running
64 /home/runner/work/infix/infix/queue/queue_test.go:87
65     func Track()
66     /home/runner/work/infix/infix/queue/queue_test.go:219
67       when a message is tracked while loading from the store
68       /home/runner/work/infix/infix/queue/queue_test.go:260
69         does not duplicate the message [It]
70         /home/runner/work/infix/infix/queue/queue_test.go:261
71
72         Unexpected error:
73             <context.deadlineExceededError>: {}
74             context deadline exceeded
75         occurred
76
77         /home/runner/work/infix/infix/queue/queue_test.go:272

I'm seeing pretty regular timeouts under GHA. I'm reasonably convinced it's just a slow platform. The most recent one I've noticed was for BoltDB tests.

2020-04-18T09:47:59.8418240Z type Provider
2020-04-18T09:47:59.8418740Z /home/runner/work/infix/infix/persistence/provider/boltdb/provider_test.go:15
2020-04-18T09:47:59.8418895Z   persistence provider
2020-04-18T09:47:59.8419317Z   /home/runner/work/infix/infix/persistence/internal/providertest/suite.go:36
2020-04-18T09:47:59.8419496Z     type queuestore.Transaction
2020-04-18T09:47:59.8419987Z     /home/runner/work/infix/infix/persistence/internal/providertest/queuestore/transaction.go:20
2020-04-18T09:47:59.8420166Z       func SaveMessageToQueue()
2020-04-18T09:47:59.8420630Z       /home/runner/work/infix/infix/persistence/internal/providertest/queuestore/transaction.go:53
2020-04-18T09:47:59.8420816Z         when the message is already on the queue
2020-04-18T09:47:59.8421289Z         /home/runner/work/infix/infix/persistence/internal/providertest/queuestore/transaction.go:54
2020-04-18T09:47:59.8421517Z           it does not update the message when an OCC conflict occurs
2020-04-18T09:47:59.8421985Z           /home/runner/go/pkg/mod/github.com/onsi/ginkgo@v1.12.0/extensions/table/table.go:92
2020-04-18T09:47:59.8422314Z             too high [It]
2020-04-18T09:47:59.8422800Z             /home/runner/go/pkg/mod/github.com/onsi/ginkgo@v1.12.0/extensions/table/table_entry.go:43
2020-04-18T09:47:59.8422893Z
2020-04-18T09:47:59.8423174Z             Expected
2020-04-18T09:47:59.8423363Z                 <context.deadlineExceededError>: {}
2020-04-18T09:47:59.8423513Z             to equal
2020-04-18T09:47:59.8423705Z                 <*errors.errorString | 0xc0000926d0>: {
2020-04-18T09:47:59.8423924Z                     s: "an optimistic concurrency conflict occured while persisting to the queue store",
2020-04-18T09:47:59.8424215Z                 }

And another for the queue >_<

And yet another for that same queue test. I can't seem to reproduce this one locally, however.

Closing for now - this issue has not happened since increasing the timeouts a little.


TasitAction: Rename Contract.waitForNonceToUpdate function

Refs: https://github.com/tasitlabs/TasitSDK/pull/174#discussion_r252344226
Rename to Contract.waitForOneConfirmation()

@marcelomorgado Can we make this change sometime soon? I think about it pretty regularly since we use this function so much, haha

https://github.com/tasitlabs/TasitSDK/pull/355


Feature Request: Collab with Signature Switcher @signatureswitch-me

This is a great app, and glad to see you developed.
I have multiple accounts in my Gmail, and different signatures depending on which "from" address I am using.
Also for replies/ forwards I use a simpler signature - which is stored in Gmail.
So it would be great to see this app work with Signature Switcher.
https://github.com/4ch1m/mozext/tree/master/signatureswitch-me

Hey! Thanks for the feedback!
Regarding the different From addresses, I think it should already be supported by syncing with different identities, isn't it?

I can confirm that it is, indeed, supported in exactly this manner.


Errors when search result returns nothing.

When a search result in anime watch --new returns nothing (i.e. anime watch --new "Kanpai"), it still displays a list of search results, even though it's completely empty.

If you select an option, it aborts the search, telling you to input a number less than 31:

I think this should be made more graceful. There should either be an option for the user to abort the search on their own or it should tell the user that there are no search results and then abort.

Yeah. There are a lot of things to be ironed out in that category.
Funny of me to assume one will get 30 results for every search. If you're willing to open a PR, I'm happy to merge it.

If you are okay with it, let @KashTag take up this issue. I'm sure you'll find a lot more bugs!

No problem at all. I'll keep looking.

That's great @Enderlein.
@KashTag If you are interested, please look into this issue.

I changed the code like this.

I wish I knew how to make it rerun the function instead of exiting.
Now it shows the following:

#14 closes this.


About the training scheme on ShapeNet cars

Hi,
would you mind enlightening me that during the experiment on ShapeNet cars, do you train and evaluate on all 3094 cars, or just select a certain number of cars?
It would be of great help to me.
Thanks.

Hi,
Thanks for your interest! Since we learn to reconstruct surfaces from a raw point cloud without requiring training sets or ground truths. The results under ShapeNetCars dataset are conducted only on the raw point clouds of the test set of  ShapeNetCars with the same split as GIFS, the training set of ShapeNetCars are not used.
Best,


generated xlsx file but office show error when open it

test.xlsx
test2.xlsx
the first xlsx is generated by client-zip
the second is unzip by 7zip and then zip again with store only option
office can open the second correctly but show error for the 1st

This may be the same thing as #59 . Can you try with client-zip v1 and see if you still can't open the file ?

I tried downloading your test files, but I end up with an empty file for the first, and just 9 bytes for the second. Might be an issue with GitHub hosting those files.
I'm going to close this issue because it's very, very likely to be a duplicate of #59. Reopen if not.


Proper output of 8-bit values

Feeding 8-bit values into std::ostream result in characters rather than numbers. Fix this by enforcing string output.

Abstract code to show issue:
quantity<second, uint8_t> seconds;
std::cout << seconds << std::endl;

Hi, thanks for raising the issue. However, I am not happy with the resolution. Forcing the usage of to_string for any representation type all the time is too much. I will provide an alternative fix soon.

I oushed the solution yesterday with https://github.com/mpusz/mp-units/commit/7b47b2fe572fcfef638ebdd1b1311eda6bc168b4


Added AAB support for uploading to the Huawei AppGallery.

Thanks for collaboration. I will review PR tomorrow morning and try to deploy to bitrise repo asap.

@AesSedai101 FYI: https://github.com/bitrise-io/bitrise-steplib/pull/2602


joinEager with ManyToMany relation failing with error

Objection Version: 1.6.9
Knex Version: 0.19.3
I'm executing the below code to search through a table:
                   Army
                        .query()
                        .select(
                            "army.u_id",
                            "army.name",
                            "army.email",
                            "army.contact_no",
                            "army.status",
                            "army.gender",
                            "army.created_at"
                        )
                        .joinEager("[insta, paymentInfo, industry, city]")
                        .where("army.name", "like", `%${search_key}%`)
                        .modifyEager("paymentInfo", builder => {
                            builder.orderBy("created_at", "desc");
                        })
                        .orWhere("army.email", "like", `%${search_key}%`)
                        .orWhere("army.contact_no", "like", `%${search_key}%`)
                        .orWhere("insta.username", "like", `%${search_key}%`)
                        .limit(parseInt(query.limit))
                        .offset(parseInt(query.offset))

The reason I'm using joinEager instead of plain eager is that I need to add a few filters to the data. Below is the relation I have defined in the Army model:
industry: {
                relation: Model.ManyToManyRelation,
                modelClass: Industry,
                filter: builder => builder
                    .select("industries.id", "industries.name", "army_industry.level"),
                join: {
                    from: "army.u_id",
                    through: {
                        from: "army_industry.u_id",
                        to: "army_industry.industry_id"
                    },
                    to: "industries.id"
                }
            }

Now the error I'm getting is
"Error: ER_BAD_FIELD_ERROR: Unknown column 'army_industry.level' in 'field list'\n

If I remove the  'army_industry.level' from the filter the query works fine. But I need that data to be returned from this query. What am I doing wrong?

The army_industry table is given an alias other than army_industry by joinEager. If the industries table doesn't have a column called level you can simply drop the table name from the select like this:
                filter: builder => builder
                    .select("industries.id", "industries.name", "level"),

The army_industry table is given an alias other than army_industry by joinEager. If the industries table doesn't have a column called level you can simply drop the table name from the select like this:
                filter: builder => builder
                    .select("industries.id", "industries.name", "level"),

Hey there, thanks for the response. I tried that before. Dropping the table name. But the same error is thrown.

There's a built in feature those called extra properties. You can try using that instead of your own select in a filter
https://vincit.github.io/objection.js/recipes/extra-properties.html#join-table-extra-properties