Now that Guzzle7 is out use the guzzle7 adapter

I was getting errors trying to install this package with the Guzzle6 adapter, I was able to get everything working bu upgrading to Laravel 8 (and Guzzle 7).
This PR just bumps the guzzle adapter to 7.
I was able to successfully get this working on a Laravel 8 package using the following command:
composer require jdecool/clockify-api php-http/guzzle7-adapter

Thanks @swilla
This PR make me realize that we should not constraint any guzzle version in the Composer.
I use php-http/httplug to be independant of any http client library. If we need to bump Guzzle because your application use a specific version, it's a mistake.
So I suggest to simply remove the guzzle dependency in the composer.json and let the user and the application tell which client to use.

@jdecool I removed the guzzle constraint.  For the record, it is still working in my application. I have also updated the readme.

I just tag a new release with this PR.
See https://github.com/jdecool/clockify-api/releases/tag/0.2.0


[wallet-ext] Remove legacy dapp interface

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Current dependencies on/for this PR:

main

PR #8934   👈

This comment was auto-generated by Graphite.


Rationalises the SearchObjectRequest semantics.

This PR changes the semantics of all SearchObjectRequests so they require the ID of a single container object, if applicable. Currently, a number of different conventions exist, making implementation and authorisation difficult. This solves issue #247 and is related to the issues in #248.
Most of the changes are straightforward, and just require the change of a field like (for example) array<string> dataSetIds = []; to string dataSetId;. There are some problematic cases:

SearchCallsRequest and SearchAlleleCallsRequest both had a large list of options for the containers that they could search over. As an initial strawman I've reduced this to just the parent CallSet to be consistent with all the other objects. Reasoning for these:

Since a CallSet is part of a VariantSet, the variant set is implied by specifying callSetId.
Finding  Calls for a particular variantId is redundant, since Calls are embedded in Variant objects. If we wish to find the calls for a given variant, we can either find them directly using SearchVariantsRequest or make a call to GET /variants/<id>/
We are then left with iterating over all calls in a CallSet, which seems like a peculiar thing to do without reference to the containing Variant object. However, this might be updated with more meaningful semantics later.

SeachAlleles is problematic; what is the interplay between the variantSetId and the sequenceId? If sequenceId is required, then why do we need the variantSetId? Conceptually, it seems natural that an Allele belongs to a single VariantSet.

In terms of backwards compatibility, obviously there are some breaking changes here. These are minor, however, and easily worked around. Server-side, this is a considerable simplification, and so implementation can simply be a special case of the existing semantics. Client-side, users that are using the multi-container search semantics will need to now explicitly iterate over the container IDs that they are interested in.

Any thoughts on this? The current situation with numerous different conventions for object search is a major impediment to implementation, so it would be good to resolve this soon.

@adamnovak could you comment on Jerome's SearchAlleles question? I'd very much like to see the proposed simplifications as a server developer, but can't comment on the impact these will have on intended usage.

I am fine with the treatment of dataset, but I would recommend to delay the variant part until we are fully confident. For now, I am not. The ideal model in my head is very different from the current schema. I have not sent a pull request because we have some fundamental questions unanswered, such as "what is an allele?" "what is a Variant made of?". We have not reached a consensus yet.
More specifically, you said "Conceptually, it seems natural that an Allele belongs to a single VariantSet". This is also suggested by the current schema. However, I think the central role of the unary model is to break the boundaries between VariantSets. In that view, an Allele is global, not specific to any VariantSet. I have asked this question but have not got a definite answer from others.
On your point 1, my preferred data model is to embed the AlleleCall equivalent to another object and get rid of both SearchCallsRequest and SearchAlleleCallsRequest.

+10 Heng!  I definitely prefer the model you mentioned.  We want to share as many unique Alleles across multiple VariantSets, which will simplify searches and also is a more natural way to think.  We had a similar discussion about reads way-back here https://github.com/ga4gh/schemas/issues/24, which simplified our current implementation.  I would definitely prefer to see a PR on this, and would be great to hash this out via an in-depth discussion where more folks jump in.

I still need to catch up with the exchanges on definition of Allele etc., but it also makes sense to me that Alleles are global top level objects, not specific to a VariantSet.
I guess they are in the context of a particular ReferenceSet, though in fact they are defined on sequences, and so may be identifiable across reference sets if the same
underlying reference sequences are present.
Richard

On 18 Mar 2015, at 17:31, Heng Li<EMAIL_ADDRESS>wrote:
I am fine with the treatment of dataset, but I would recommend to delay the variant part until we are fully confident. For now, I am not. The ideal model in my head is very different from the current schema. I have not sent a pull request because we have some fundamental questions unanswered, such as "what is an allele?" "what is a Variant made of?". We have not reached a consensus yet.
More specifically, you said "Conceptually, it seems natural that an Allele belongs to a single VariantSet". This is also suggested by the current schema. However, I think the central role of the unary model is to break the boundaries between VariantSets. In that view, an Allele is global, not specific to any VariantSet. I have asked this question but have not got a definite answer from others.
On your point 1, my preferred data model is to embed the AlleleCall equivalent to another object and get rid of both SearchCallsRequest and SearchAlleleCallsRequest.
—
Reply to this email directly or view it on GitHub https://github.com/ga4gh/schemas/pull/253#issuecomment-83071383.

--
The Wellcome Trust Sanger Institute is operated by Genome Research
Limited, a charity registered in England with number 1021457 and a
company registered in England with number 2742969, whose registered
office is 215 Euston Road, London, NW1 2BE.

+10 again for "Allele is global, not specific to any VariantSet."  I have been wondering why this design decision was made in the first place because it seems topsy-turvy.  For the initial G2P schema, I have chosen to use the proposed Feature in the sequence-annotation branch instead of Variant for this specific reason.

David also said allele is global. In principle, an allele could be species specific, but due to the way we find/name alleles, a GA4GH allele is specific to a ReferenceSet. Different ReferenceSets get different alleles.

Thanks for all the feedback. The consensus seems to be, "this change is OK, but there are some details to be worked out". Is this fair?
I'm perfectly happy for an Allele to be global, but we will need to think about what the implications for search and authentication are. Will we want to search for all the Alleles in a given VariantSet or ReferenceSet? (That is, an Allele can exist in multiple VariantSets and ReferenceSets) This is fine by me once we limit the semantics to exactly one of either.
In terms of authentication, how do we decide whether a user has permissions to see a given allele? I'd imagine the model of allowing users to search over a given VariantSet or ReferenceSet or not will give us the restrictions we require.
@lh3 - I'm happy to delete both SearchCall and SearchAlleleCall: I don't think they are particularly useful.

Jerome, I think authentication was deemed to be resource-specific and not part of this API based on the latest post:
https://github.com/ga4gh/schemas/issues/148#issuecomment-76011682

I think the client/server and the reads/Multi-BAM slicing discussion will prove fruitful for future aspects of the API, so I put  a link to it here in case folks want to refer to it later:
https://github.com/ga4gh/schemas/pull/253#discussion-diff-26700450
Paul

Thanks for all of the comments on this PR so far, it has been a very interesting discussion. Multi-BAM merge is important, so I accept that it should stay.
I've updated the PR to reintroduce the readGroupIds field in the SearchReadsRequest object, so that it will support merging reads across many ReadGroups. I have changed the semantics slightly, in that we no longer accept the empty list (interpreted as search all readGroups) as an argument. I think this is very important.
Any comments on this or any of the other changes would be much appreciated.

Hi Richard (@richarddurbin),
Regarding a reference server - which would be a big win - we should just start simple just the way search engines are built via an inverted index.  Below are the general steps:

The genome is split into equally sized regions.

Each region is contains a pointer to a list of sample ids.  A hash function (i.e. md5sum, sha256sum, etc) is generated between the tuple (region, sample_id) for optimized lookup of the reads for that sample in the specified region.

The hash is then accessed in O(1) for the collection of reads it contains for that region.

This would also enable efficiently parallelized across multiple machines.  The storage can also be optimized via the Log-Structured-Merge (LSM) Tree data structure with Differentiated Indexing (Diff-Index), which I put a reference for below.
References
A nice graphical description of an inverted index is shown at the following link:
https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/SearchKitConcepts/searchKit_basics/searchKit_basics.html
Regarding a deeper description on inverted indices, below is a nice paper from Google, that contains a description of it:
http://static.googleusercontent.com/media/research.google.com/en/us/pubs/archive/37367.pdf
Below is another nice paper from Google/IBM/GeorgiaTech regarding the Log-Structured-Merge (LSM) Tree data structure and with Differentiated Indexing (Diff-Index):
http://researcher.watson.ibm.com/researcher/files/us-wtan/DiffIndex-EDBT14-CR.pdf
Let me know what you think.
Thank you,
Paul

@jeromekelleher, that multi-BAM change addresses the biggest concern I saw raised -- thanks.
There are 12 separate changes in this PR, and I was finding the diff's hard to read, so I made the summary below. Assuming I got it right, I:

am +0 on the 6 "not yet published" changes (they look reasonable, but I haven't been part of those design discussions)
am +1 on the 2 "published but not implemented" changes
would like to be sure there aren't any bad consequences to the 4 "already implemented" changes.

A few questions:

@jeromekelleher -- does it look like I correctly caught all twelve changes?
@calbach -- does it look like I binned them correctly into "not yet published", "published but not implemented", and "already implemented"? (I think I got them right, but please double-check.)
@calbach -- of the 4 potentially breaking changes, do you have any thoughts on which if any could cause real problems in existing code?

6 not yet published APIs
Backwards compatibility isn't an issue here.
src/main/resources/avro/metadatamethods.avdl
record SearchIndividualsRequest {
-  array<string> groupIds = [];
+  string groupId;

record SearchSamplesRequest {
-  array<string> individualIds = [];
+  string individualId;

src/main/resources/avro/variantmethods.avdl
record SearchVariantSetSequencesRequest {
-  array<string> parentIds = [];
+  string parentId;

record SearchAllelesRequest {
-  array<string> variantSetIds = [];
+  string variantSetId;

record SearchCallsRequest {
-  array<string> callSetIds = [];
-  array<string> variantSetIds = [];
-  array<string> variantIds = [];
+  string callSetId;

record SearchAlleleCallsRequest {
-  array<string> callSetIds = [];
-  array<string> variantSetIds = [];
-  array<string> alleleIds = [];
-  array<string> variantIds = [];
+  string callSetId;

2 published APIs, with unimplemented behavior
As far as I know these changes don't break any existing implementations, so again backwards compatibility isn't an issue.
src/main/resources/avro/variantmethods.avdl
record SearchVariantSetsRequest {
-  array<string> datasetIds = [];
+  string datasetId;

record SearchVariantsRequest {
-  array<string> variantSetIds = [];
+  string variantSetId;

4 published APIs, with implemented behavior
These changes are small, but might cause a backwards compatibility issue.
src/main/resources/avro/variantmethods.avdl
record SearchCallSetsRequest {
-  array<string> variantSetIds = [];
+  string variantSetId;

src/main/resources/avro/readmethods.avdl
record SearchReadsRequest {
-  array<string> readGroupIds = [];
+  array<string> readGroupIds;

record SearchReadGroupSetsRequest {
-  array<string> datasetIds = [];
+  string datasetId;

src/main/resources/avro/referencemethods.avdl
record SearchReferencesRequest {
-  union { null, string } referenceSetId = null;
+  string referenceSetId;

Thanks for the summary @dglazer, this is very helpful. Your summary looks accurate to me. Since the original PR, another set of APIs has been merged in #246, so I've updated the methods here to follow the single-parent-container-unless-absolutely-necessary paradigm. These go into the not yet published APIs bucket:
src/main/resources/avro/sequenceAnnotationmethods.avdl
record SearchFeaturesRequest {
-    array<string> featureSetIds = [];
+    array<string> featureSetId;

-    array<string> parentIds = [];
+    array<string> parentId;

(Apologies for the whitespace noise in the diff --- I can get rid of this if you prefer).

@jeromekelleher, @dglazer - One thing to keep in mind, it is not uncommon to merge variants or to search across many variant sets at the same time.  So removing this array<string> variantSetIds = []; most likely would be very temporary.
Just out of curiosity, if it is removed, does that mean that before querying across multiple VariantSets, I would merge some or all VariantSets into one gigantic one in order to search across multiple ones.  These would be so many that it would defeat the purpose of removing array<string> variantSetIds = [];.  My recommendation is to always design the system to match the most natural and flexible means of asking the biological questions if such a search is possible,  which in this case it is.  This is the foundation of MapReduce and relational algebra.
Paul

@dglazer yes, that summary looks correct to me.
Aside from the referenceSetId change (I'll comment inline), I'm +1 on the other breaking changes and unimplemented changes. I think they don't remove any important functionality, so the tradeoff for implementation simplicity is worth it.
I'm neutral on the unpublished methods.

+1 [with great enthusiasm]
It's very important to try to make the GA4GH APIs more consistent and rational.  The current state of the queries are a result of different committees as opposed to a single design effort.  So it's done a good job of defining requirements but not one of defining an overall consistent API.
This PR is an excellent step in right direction.  It can and will evolve once we get more experience with using it.  However, we need to make incremental changes like this to move forward.

By my count, we now have three +1s and all of the contentious issues have been resolved. Unless there are any objections, I think this is mergable.

I'm a bit concerned about losing the ability to search Calls and AlleleCalls by VariantSet. Isn't a CallSet allowed to occur in multiple VariantSets? Or did we drop that?

Once Adam's query is resolved, I'm 1+.

I don't really understand what we need the SeachCallRequest and SeachAlleleCallRequest for  @adamnovak. What's the use case for getting Calls outside of the context of the encapsulating Variant?

@jeromekelleher, this has applications to the Beacon project:
The Beacon project is a project to test the willingness of international sites to share genetic data in the simplest of all technical contexts. It is defined as a simple public web service that any institution can implement as a service. The service is designed merely to accept a query of the form “Do you have any genomes with an “A” at position 100,735 on chromosome 3?” (or similar data) and responds with one of “Yes” or “No.” A site offering this service is called a “beacon”.
~p

@jeromekelleher I agree that SeachCallsRequest and SeachAlleleCallsRequest are maybe not useful to have, if all you can do is iterate through the Calls or AlleleCalls in a CallSet. The primary purpose of SearchCallsRequest was, I think, to allow paging through the Calls of a Variant that has too many of them. If you're OK with forcing people to get all the Calls at once, there's not much point in the method.
On the AlleleCalls side, if we drop all those parameters from searchAlleleCalls(), or drop the method altogether, then we also need to make Allele hold AlleleCalls like Variant holds Calls, or to come up with another way to retrieve AlleleCalls. As far as I can tell, the current proposal offers no way to retrieve AlleleCalls other than to iterate through all of them for a CallSet until you find the one you want.
So in order for me to like this PR, it needs to:

Provide/document a way to take a CallSet ID and a Variant ID and retrieve the Call object (even if that is just "download the whole Variant and scan it").

Provide/document a way to take a CallSet ID and an Allele ID and retrieve the AlleleCall object(s). I don't think "page through all the AlleleCalls in the CallSet until you find the one for your Allele" is going to be good enough, but that's the only method that looks possible here.

While I much prefer to drop SeachCallsRequest and SeachAlleleCallsRequest, I agree with @adamnovak that simply removing them without heavily modifying other part of the schema will lead to a non-workable schema. I think we should not touch SeachCallsRequest and SeachAlleleCallsRequest in this PR.

Excellent, thanks for this @adamnovak and @lh3. I think one of these is easy to resolve, but I'm not sure about the other (mostly because I don't understand the subtleties of Allele and AlleleCalls). I have a couple of questions/suggestions, and hopefully we can arrive at a solution quickly.
To address @adamnovak's points above:

This is simple I think: just provide the callSetId in the callSetIds field in searchVariants. There's no other way of getting the variant's ID, so you might as well get the Call at the same time as you get the variants. I see the point about having large numbers of calls, but I think we should probably fix that problem when we hit it. So, I would be in favour of just deleting SeachCallsRequest as it doesn't really serve much purpose.

Sorry for the stupid question, but would it be possible to embed allele calls into the variant object in the same way that they are for classic mode (ie., just make the calls field a union of {Call, AlleleCall``}), and we can then use the same API for both? If not, I'm happy enough to revert this change with a more focused SearchAlleleCallsRequest, with say, variantId and callSetIds as arguments.

Any thoughts here @adamnovak? I'm happy to reinstate a version of SearchAlleleCalls, I'd just like to get your views on the questions above first.

Bump... @adamnovak, any thoughts on the above?

Forcing searches only to one Dataset id is extremely limiting.  This goes against the whole idea of querying all datasets for determining similar variants.  This is the foundation of Matchmaker and Beacon.

Forcing searches only to one Dataset id is extremely limiting. This goes against the whole idea of querying all datasets for determining similar variants.

More generally, we need to associate Dataset with meta data and search for them. When there are thousands of datasets (think about SRA), not being able to search across datasets is a deal breaker. I used to propose something a year ago but at that time others thought that was not the task of read/refvar groups. It is still an unsolved problem.

I thought we'd agreed at this point that a single dataset was a good idea and were resolving the finer issues of how we search for calls and alleles and so on.  Are you disagreeing with this @lh3, or making a different point about what Datasets are and how we should use them? I agree that the Dataset concept is far too vague right now (see #248), and it needs a lot of work to make it into a useable concept.

I guess I was just generally talking about long-term goals and what we are missing most in this course. It is fine to use a single-dataset for now, but proper support of multiple datasets, the server is likely to remain as a prototype.

@jeromekelleher, if we limit the schema now, then people will start implementing clients with such a limitation in mind and it will be impossible to turn back with large datasets already loaded using a specific design.  I think this is already a reality for some.  We should not merge this until we solve this issue as @lh3 clearly elucidated.  One will not be able to perform the searches easily that we critically need if we limit ourselves too much in the schema design.  Here is a scenario that would throw us but we would need to perform, using my classic example:
So I open my Genome Browser and select a specific region(s) of a chromosome(s).  I then want to search across all datasets for VariantSets where I filter by VariantSet.metadata.info for a specific cancer subtype, setting chromosome via Variant.referenceName, in the region [Variant.start - Variant.end) with  Calls filtered by Call.genotypeLikelihood to find those rare mutations.  Then collecting these as an enriched set, I want to find similar ones to mine that are in other datasets that are not cancer and tell me the samples that they come from.
Thus we would need to provide a set (array) of Dataset ids, and not just a specific value.
By looking at what #248 provides, it has some benefits but would be limiting in other aspects. For instance, having one call belonging to exactly one Variant and one CallSet might make indexing costly, though there are other approaches that would cut down those costs.  We are still below version 1.0, and adding too many limitations would limit the potential of the possiblities of what we can do with the API.
We need to make the schemas at least the most flexible because the technology for performing these types of mega-searches is already here for several years, and we should not limit something that would be difficult or impossible to revert back to.
Paul

@lh3 Thanks for the clarification. I agree we absolutely need to support datasets properly and define what they mean. I don't think this means that we need to make all of our methods take multiple parent containers  as arguments though: there's no reason a client can't send off a bunch of requests, one for each dataset. It's not limiting at all in terms of what can be done with the API to restrict the attention of each individual API call to a single parent container.

But can we search for a sample across multiple datasets? And this is similar to retrieving across read groups. Say I want to get the allele frequency across thousands of datasets. Ideally, this should be done with one query. We wouldn't want to query fire 1000s queries just to get this number on the client side and sometimes querying individual datasets might be prohibited due to security concerns.
Anyway, this is for future. For now, I am fine with the current design.

This is a good point @lh3, but I think we'd want a specialised query for this case (it sounds very much like a Beacon-style query). Anyway, we agree that the approach in this PR is good for the short/medium term and will provide us with something workable that we can make progress on. Excellent.
Now we just need to resolve the issues relating to callsets/alleles. @adamnovak, can you respond to my questions above from ~3 weeks ago please, or at least give some sort of indication of where you are with this? I would be in favour of simply removing the SearchCalls and SearchAlleleCalls requests, as SearchCalls is of very limited utility, and the model for dealing with Alleles is still under discussion. We re-can add API methods for searching for Allele calls when the model allele has been agreed on.

@lh3 For what we're are asking, we would need to implement distributed, replicated balanced inverted indices like this:

Paul

Sorry I wandered off.
I don't think that access to AlleleCalls can be effectively provided by embedding them in the Variant object, because in the allelic model you will commonly have AlleleCalls on Alleles that do not participate in Variants at all, and so there is no Variant object that could hold them.
A more focused SearchAlleleCallsRequest that takes alleleId and callSetId might be the way to go with this. I originally wanted to embed the AlleleCalls in the Alleles like the Calls in Variants, but since we are moving towards Alleles as global across VariantSets I don't think that would actually work.
I am definitely +1 on the single dataset search for now. We might need to add back search across multiple data sets in a single query later, for efficiency, but it's not good to optimize that step before we know it's slow. For now we can send several queries when we need to use several data sets. Remember that we do have a /datasets/search (in readmethods.avdl, which might not be appropriate anymore) to loop over all of them.

Thanks for the feedback @adamnovak. I've fixed the bugs you pointed out. I've also removed the SearchCalls and SearchAlleleCalls endpoints, in an attempt to get this PR through. I agree that it's not good to have no way of searching for allele calls in the API, but I propose that we open an issue on this and work out the right way to resolve it there rather than holding this PR up any longer. It has been open for over two months now.
Since it has been open for so long, and it classifies as a major enhancement, I think we need to update  the votes. @delagoya, can you ping the relevant people please so we can get a final vote on this?

Since this touches so many files I added a few labels for this issue. If your group does not have a comment on it, please let me know and I will remove the label

Major Enhancement
The commit touches readMethods.avdl which was a major artifact from the Reads Task Team, which is no longer holding regular meetings. As such the, major enhancement review process will be applied to this pull request.
-1
To clear the vote, the following people need to respond with +1 votes after this message for explicit approval of the changes:
@jeromekelleher (done)
@fnothaft
@dglazer
@vadimzalunin
@saupchurch
@lh3
(P.S. if any of the people above do not want to be part of future explicit approval list, let me know).

I am +1.

+1 for me.
I agree with @adamnovak concerning early optimization.   Single search (thus multiple request) is fine for now with the caveat that usage metrics once we have them may require us to re-visit this in future.

Hi Angel, appreciate you watching out for reads people, but why the need to
get all the people from the retired reads group to 1+ the pull request?
Surely just a couple of 1+s from ex reads members would be sufficient? - it
would have been when the reads group still existed!
On Wed, May 13, 2015 at 12:03 PM, Angel Pizarro<EMAIL_ADDRESS>wrote:

Major Enhancement
The commit touches readMethods.avdl which was a major artifact from the
Reads Task Team, which is no longer holding regular meetings. As such the, major
enhancement review process
https://github.com/ga4gh/schemas/blob/master/CONTRIBUTING.md#retired-task-teams
will be applied to this pull request.
-1
To clear the vote, the following people need to respond with +1 votes
after this message for explicit approval of the changes:
@jeromekelleher https://github.com/jeromekelleher (done)
@fnothaft https://github.com/fnothaft
@dglazer https://github.com/dglazer
@vadimzalunin https://github.com/vadimzalunin
@saupchurch https://github.com/saupchurch
@lh3 https://github.com/lh3
(P.S. if any of the people above do not want to be part of future explicit
approval list, let me know).
—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/pull/253#issuecomment-101778431.

Precisely because the changes effect the implementations made by a group that no longer meets regularly.
I'm really just acting as a box checker, so if there is a process change that needs to be made please put it on the agenda for the DWG meetings or for Leiden.

Fair enough. I guess I'll make a pull request against the contributions doc!
On Wed, May 13, 2015 at 9:59 PM, Angel Pizarro<EMAIL_ADDRESS>wrote:

Precisely because the changes effect the implementations made by a group
that no longer meets regularly.
I'm really just acting as a box checker, so if there is a process change
that needs to be made please put it on the agenda for the DWG meetings or
for Leiden.
—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/pull/253#issuecomment-101912287.

Thanks @delagoya -- I don't see any concerns; I'll take a closer look in the morning and vote officially.
(I wish GitHub made it easy to see all changes made between my earlier +1 at the end of March and the latest version.)

@dglazer I think you are in luck, and it's a piece of cake :)  Just follow link below and adjust accordingly the link parameters. In this case I am comparing master from 63 days ago against @jeromekelleher's present pull request :)
https://github.com/ga4gh/schemas/compare/master@{63days}...jeromekelleher:rationalise-search-requests
To view the changes just go to the split view, by clicking first on the File Changes tab and then selecting the Split button, as highlighted by the red arrow in the screenshot below:

Let me know if this is what you were looking for, or if it was something different.
Thanks,
Paul

+1 on the changes to already-published methods (which afaict are the same as the last time I looked closely in March), and +0 on the changes to not-yet-published methods. Thanks @jeromekelleher for pushing this forward.
Small process suggestion for next time -- break things up into smaller pieces. For example, I think the big changes to brand-new methods, like {search,get}VariantSetSequences and search[Allele]Calls, could easily  have been split out, as could the changes to comment formatting. I expect that would make the discussion and approval process much quicker and easier.
P.S. In case it's useful to others, here are the 5 substantive edits to already-published methods that I found:
src/main/resources/avro/variantmethods.avdl (not yet implemented)
record SearchVariantSetsRequest {
-  array<string> datasetIds = [];
+  string datasetId;

record SearchVariantsRequest {
-  array<string> variantSetIds = [];
+  string variantSetId;

src/main/resources/avro/variantmethods.avdl
record SearchCallSetsRequest {
-  array<string> variantSetIds = [];
+  string variantSetId;

src/main/resources/avro/readmethods.avdl
record SearchReadsRequest {
-  array<string> readGroupIds = [];
+  array<string> readGroupIds;

record SearchReadGroupSetsRequest {
-  array<string> datasetIds = [];
+  string datasetId;

Thanks @dglazer, I appreciate the feedback. I agree about making PRs smaller when possible. Apologies for making it difficult to see the additional changes: this is the drawback of squashing commits before a PR is fully ready for merging.

@vadimzalunin and @lh3 there were some changes since you last approved. Since there is an active working group and two out three major implementations weighing in as +1, I'll give another day to respond before I remove the -1 process vote. Thanks!

bump... I think we need to @lh3 and @vadimzalunin to weigh in here?

@jeromekelleher let me reach out via email. If they have not responded by tomorrow, we should take a look at the process to see if there is a time limit and best effort for further review.

+1

@delagoya, I think we're still waiting on @lh3's +1 here?

Ample time a multiple contact tries with now response, so I'm going to call it and merge.

Thanks @delagoya!


Add a placeholder to datepicker-dropdown

Similar to HTML input's placeholder attribute.
I think all that's needed is a new parameter description to datepicker-dropdown-args-desc and a corresponding argument to anchor-button.

Could you elaborate on this (or provide a PR)? Do you want to place something like "Enter date" there? I'm wondering why this is better than just providing a default date to model. In which case, would you seed model with nil? So when they open the calendar, what date would they see? No date or today's date? If today's date, I presume you would immediately feed that into model?
Our general philosophy is to never leave a component in an undefined or invalid state.

Sure, I'll provide a PR when and if we have an agreement on how to implement it (if at all).
Yes, something like "Enter date". In my particular case, I have two date fields in a small space with placeholders "From" and "Till".
The default date says nothing about semantics. While one, of course, can provide an external label, it's not always an optimal solution (e.g. not coherent with other design elements, or tight space requirements).
Yes, the model would be nil, maybe also an empty string (value of a not filled date input in Google Chrome is an empty string). When you open the calendar, you'd see no date selected, and maybe a small hint on the current day (again, just as Google Chrome shows date input).
In my understanding, nil is not an undefined state - it's the state without any date selected. The parameter :model can be explicitly set to nil - nothing undefined about it, in my opinion.

@kimo-k @Gregg8 In our apps-lib variant(s) I had a similar usecase. The dropdown date range picker (also using a from and to with 2 pickers) is used as a filter criteria in which context it is optional to specify, hence :model is nil and in my specific example I wanted to show "Include all dates" in the label. I implemented a parameter :label-when-none with a default of an empty string, so that it behaves as normal for backward compatibility. What do we feel about this approach ?


loader .find doesn't seem to be batching calls

I have a virtual resolvers like so:
listItems: virtual(async (item, context) => {
    return context.params.loader.service('lists').find({
      ...getAuthenticatedParams(context),
      query: { $select: ['name', 'path'], _id: { $in: item.lists } },
    }).then(l => l.data);
  })

And when logging my lists service I'm not seeing any batched requests. Am I missing something?

Also seems like .load doesn't like it when I pass query: { $select: ['name', 'path'] }

.find does not do any "batching". It is really only a cached find. Use the .load method for batching.

Okay good to know. I've been digging in the docs some more and slowly learning all the ways to use load.

I've been meaning to update the docs and make them better. I know they aren't great. Sorry.


A new desktop is created each time the same user logs in

In this image, the same user "keainini" reconnects, creating a new desktop each time.
When I log in as user 'keainini' and disconnect, then log in again, and then log in again, I will create a new desktop every time I log in, but I will not enter the last successful login desktop. How can I configure that the same user who disconnects and reconnects will enter the desktop when the user last logged out?

Please, attach your RDPConf screenshot and termsrv.dll.

I have the exact same problem

I have the exact same problem

@codezbq
Please, attach your RDPConf screenshot and termsrv.dll.

我有同样的问题

@codezbq 请附上您的 RDPConf 屏幕截图和 termrv.dll。

i have same question,
on windows server 2019 and some 2022 ,if i use mstsc logon new user,the host session switch to new user's desktop

我有同样的问题

@codezbq 请附上您的 RDPConf 屏幕截图和 termrv.dll。

i have same question, on windows server 2019 and some 2022 ,if i use mstsc logon new user,the host session switch to new user's desktop

@kz1989 不是截图版本号，是上传termsrv.dll文件

I've been having the same issue for a while, and it's continued with the latest offsets from sebaxakerhtc

Have tried toggling Single User Per Session, Default RDP Auth, different RDC apps, all with no luck.
termsrv.dll uploaded here

This problem has been bothering me for two days, but it has now been resolved. You can refer to it.
win+r run gpedit.msc，计算机配置-管理模板-windows组件-远程桌面服务-远程桌面会话主机-连接
启用：将远程桌面服务用户限制到单独的远程桌面服务会话

Fix mentioned by @forilux above has also solved my issue. Here's the English translation of the policy setting location:

Open Group Policy Manager (run gpedit.msc, search in start, etc)
Navigate to: Computer Configuration -> Administrative Templates -> Windows Components -> Remote Desktop Services -> Remote Desktop Session Host -> Connections
Change "Restrict remote desktop services users to a single remote desktop services session" to ENABLED.

I didn't have to reboot, it worked immediately I tried to reconnect.

Fix mentioned by @forilux above has also solved my issue. Here's the English translation of the policy setting location:

Open Group Policy Manager (run gpedit.msc, search in start, etc)
Navigate to: Computer Configuration -> Administrative Templates -> Windows Components -> Remote Desktop Services -> Remote Desktop Session Host -> Connections
Change "Restrict remote desktop services users to a single remote desktop services session" to ENABLED.

I didn't have to reboot, it worked immediately I tried to reconnect.

----thank you very much it worked for me

Save this as a .ps1 script and run in elevated Powershell and use to easily switch back and forth:
<#
.SYNOPSIS
Manages Remote Desktop Services single-session policy.
.DESCRIPTION
Enables or disables RDP single-session restrictions through Group Policy modifications.
Requires administrative privileges.
.NOTES
File Name: Manage-RDPSessions.ps1
Author: Claude
Version: 1.0
#>
Verify Administrative Privileges
function Test-AdminPrivileges {
$identity = [Security.Principal.WindowsIdentity]::GetCurrent()
$principal = New-Object Security.Principal.WindowsPrincipal($identity)
return $principal.IsInRole([Security.Principal.WindowsBuiltInRole]::Administrator)
}
Policy Management Functions
function Set-RDPSessionPolicy {
param (
[Parameter(Mandatory=$true)]
[ValidateSet("Enable", "Disable")]
[string]$Action
)
$registryPath = "HKLM:\SOFTWARE\Policies\Microsoft\Windows NT\Terminal Services"
$propertyName = "fSingleSessionPerUser"

try {
    # Ensure registry path exists
    if (-not (Test-Path $registryPath)) {
        New-Item -Path $registryPath -Force | Out-Null
    }

    # Set policy value
    $value = if ($Action -eq "Enable") { 1 } else { 0 }
    Set-ItemProperty -Path $registryPath -Name $propertyName -Value $value -Type DWord

    return $true
}
catch {
    Write-Error "Failed to $Action policy: $_"
    return $false
}

}
Main Execution Block
function Main {
if (-not (Test-AdminPrivileges)) {
Write-Error "This script requires administrative privileges."
exit 1
}
do {
    Clear-Host
    Write-Host "RDP Session Policy Manager"
    Write-Host "------------------------"
    Write-Host "Options:"
    Write-Host "e - Enable single session restriction"
    Write-Host "d - Disable single session restriction"
    Write-Host "x - Exit"
    Write-Host ""

    $choice = Read-Host "Enter selection"

    switch ($choice.ToLower()) {
        'e' {
            if (Set-RDPSessionPolicy -Action "Enable") {
                Write-Host "Single session policy enabled successfully." -ForegroundColor Green
            }
            pause
        }
        'd' {
            if (Set-RDPSessionPolicy -Action "Disable") {
                Write-Host "Single session policy disabled successfully." -ForegroundColor Green
            }
            pause
        }
        'x' {
            return
        }
        default {
            Write-Host "Invalid selection. Please try again." -ForegroundColor Yellow
            pause
        }
    }
} while ($true)

}
Script Entry Point
Main


Put HashLib4CPP source in a namespace

Maybe one called HashLib4CPP?

That's a nice idea, I will do that asap. Thanks!


Make eba testing less hardcoded, for instance api url is in code

https://github.com/GLEIF-IT/reg-pilot/pull/160


Feature/additional vob data for Sound/SoundDaytime

This PR focuses on loading vob data based on vobType.
It covers VobSound and VobSoundDaytime functionality.
CC: @JucanAndreiDaniel

Merged, thanks!


TODAY

List of short fixes:

[x] Fix #90 (Audioslider)
[ ] Fix #91 (Permissions)
[ ] Close #76 (Database persistens)
[ ] Close #88 (Database)
[x] Next Button in settings leads to Login Page and not to main Menu #92
[ ] Motivating message after each exercise should be added #102
[ ] Check if language switching works correctly based on locals
[ ] Visual improvements for session overview #93
[x] Fix #95 (App crashes)
[ ] Fix #97 (Profile Page Back button)
[ ] Improved spanish Translation (@PauPerezT )

Comment all things down below, what you thinks need to be done today! If we think it is doable, add it to the list

Check permissions? If the app doesn't have permissions it just chrashes after the first erxercise

Audio Slider does not seem to react to sound input @PKlumpp

App State is not persistent

Exercises restart even if session finsihed @AKuederle

Next Button in settings leads to Login Page and not to main Menu

Motivating message after each exercise should be added

Cleanup Exercises, that are not implemented in the new way

Reorder file structure for Layout files

Clean up general file structure

Rename everything to camel case

If you press back in the main menu you get to the splash screen


Graph example doesn't work - yOrientCommandException: Cannot find a command executor for the command request: sql

I tried to run example from GitHub "A GRAPH Example"
It fails at line
eat_edges = client.command("""
create edge Eat
from (select from Animal where name = 'rat')
to (select from Food where name = 'pea')
""")
with exception:
C:\Python27\python.exe C:/Eriks/PythonScripts/pyorient_tests.py
Traceback (most recent call last):
File "C:/test/PythonScripts/pyorient_tests.py", line 40, in
""")
File "C:\Python27\lib\site-packages\pyorient\orient.py", line 220, in command
.prepare(( QUERY_CMD, ) + args).send().fetch_response()
File "C:\Python27\lib\site-packages\pyorient\messages\commands.py", line 140, in fetch_response
super( CommandMessage, self ).fetch_response()
File "C:\Python27\lib\site-packages\pyorient\messages\base.py", line 143, in fetch_response
self._decode_all()
File "C:\Python27\lib\site-packages\pyorient\messages\base.py", line 127, in _decode_all
self._decode_header()
File "C:\Python27\lib\site-packages\pyorient\messages\base.py", line 115, in _decode_header
raise PyOrientCommandException(cmd_exc, [])
pyorient.exceptions.PyOrientCommandException: Cannot find a command executor for the command request: sql.
create edge Eat
from (select from Animal where name = 'rat')
to (select from Food where name = 'pea')

com.orientechnologies.orient.core.command.OCommandExecutorNotFoundException

Process finished with exit code 1

You're right, documentation is wrong, this is the right code:
    eat_edges = client.command(
        "create edge Eat from ("
        "select from Animal where name = 'rat'"
        ") to ("
        "select from Food where name = 'pea'"
        ")"
    )

I updated the doc

Thanks. Now its working
But it seems that there is one more error. Self isn't needed in line below.
What each animal eats?
animal_foods = client.command("select expand( out( Eat )) from Animal")
for food in animal_foods:
animal = **self.**client.query(
"select name from ( select expand( in('Eat') ) from Food where name = 'pea' )"
)[0]

Thanks :)


Add openjdk:8 to base.yml. openjdk:8 is based on Debian

Signed-off-by: Steve Taylor<EMAIL_ADDRESS>

Fixes issue #18


[DateRangePicker] Do not render disabled month before/after last disabled date

Thanks for new feature DataRangePicker!!

On disableFuture is show next month disabled, will be better for user experience if on second month in two calendar props, that the second calendar be the actually calendar.

Actually:

Sugestion:

Environment

Tech
Version

@material-ui/pickers
lastest alpha

material-ui
lastest realease

TypeScript

React

Browser

Peer library
moment

Yes, it would be very useful.

Yes, it would be very useful.


Remove some trailing commas in our data.json file

Our data.json file was invalid JSON because of some trailing commas, but the data.gov validator was still seeing it as valid.
This change removes those trailing commas, and the file parses as valid JSON and passes the data.gov validator.
How to test this PR

Confirm that the contents of the data.json file are valid JSON with https://jsonlint.com/
Confirm that the contents of the data.json file are valid for the federal data.json schema with https://labs.data.gov/dashboard/validate

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)

Tell me you're a python programmer without telling me you're a python programmer


Rename "Administrative Console" -> "Vectara Console"

Looks like the nav still uses the old term. Maybe we can do a "Find all" to find all references to "administrative" and replace it globally.

Created PR 118 with relabeling


[MXNET-470] [WIP] Gluon Style Transfer Example

Description
fixes https://github.com/apache/incubator-mxnet/issues/9989
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Feature1, tests, (and when applicable, API doc)
[x] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Don't merge yet, the new model is pending.

@szha This PR should be ready to merge, after the model is uploaded. Can be tested by running:
cd example/gluon/style_transfer
python models/download_model.py
python main.py eval --content-image images/content/venice-boat.jpg --style-image images/styles/starry_night.jpg --model models/21styles.params --content-size 1024 --cuda 0

fixes https://github.com/apache/incubator-mxnet/issues/9989

The model is HybridBlock now.
fixes https://github.com/apache/incubator-mxnet/issues/9813


Semantic type for CO2 concentration

Hi,
I can't find a semantic type for CO2 concentration.
Which one do you think would be best to use?
https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v2/dtdlv2.md#semantic-types

Are you looking for ppm to g/m3 conversion https://www.teesing.com/en/page/library/tools/ppm-mg3-converter ?

Are you looking for ppm to g/m3 conversion https://www.teesing.com/en/page/library/tools/ppm-mg3-converter ?

Hi @milijan ,
Thanks for reply.
Consider changing to g/m3.


Template literals are improperly being coerced

According to <IP_ADDRESS> template literal expressions should be coerced to strings.

Let sub be the result of evaluating Expression.
Let middle be ToString(sub).

var x = { toString: function () { return "foo"; }, valueOf: function () { return "bar"; } };
console.log(`${x}`);

Actual:
var x = { toString: function () { return "foo"; }, valueOf: function () { return "bar"; } };
console.log(("" + x));

Expected:
var x = { toString: function () { return "foo"; }, valueOf: function () { return "bar"; } };
console.log(("" + String(x)));

Relevant V8 bug report here.

If you've been following the discussion on the PR it is not clear we care about fixing this. To fix this we need to make sure that we throw for symbols which makes the generated code pretty ugly (and slower).
Maybe Traceur should follow Babel and use a spec/loose mode?

@arv I think that's a good approach. I'm concerned about performance too since template literals are almost certainly going to appear in hot code. Not sure whether it's a good idea to do it by default though. Perhaps it can be considered the same as the typeof symbol rewriting (opt-in)?


When running Nylas Mail with --background (or -b) it doesn't start in the background, instead it starts the first startup screen.

Are there any related issues?

#1251 Kind of related
What operating system are you using?
Linux Mint 18.1 (64-bit)
What version of Nylas Mail are you using?
2.0.18
--
Bug?
Do you have any third-party plugins installed? If so, which ones?
No
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
No
Is the issue reproducible with a particular attachment, message, signature, etc?

Try running /path/to/nylas-mail ---background or /path/to/nylas-mail -b
Screenshots

Feature Request?
Does this feature exist in another mail client or tool you use?
...

I'm seeing the same issue in Ubuntu 17.04.

Same issue on KDE Neon 5.9.4. I've told about it in #3401, but it was closed.

I'm encountering the same issue in Ubuntu Gnome 16.04 LTS

Same here. It seems it's because Nylas Mail launches in background only in dev mode.

I think the problem is the same key is used for benchmark mode and background start.

Same problem in Linux Mint 18.1 with KDE 5.8.6!
Nylas Mail does not open in the background and every time it opens it asks for password keyring!
This problem greatly irritates Linux users!

I can confirm the same problem on Xubuntu 16.04 LTS.

I was trying to add Nylas to autostart on Ubuntu 16.04 and I encountered same issue.

Same issue with me on Linux Mint 18.1


how to install my project and how to build , which package to choose?

💬 Questions and Help
Hello
i want to install a version of hospitalrun to start develop my own app, but i don`t know what a repo should i use to install on windows ,
and want to know how to develop then build my own app with electron container ?
can you help ?
Please note that this issue tracker is not a help forum and this issue may be closed.
Before you submit an issue we recommend you drop into our Spectrum channel and ask any questions you have or mention any problems you've had getting started with HospitalRun.

Hi. This monorepo is related to version 2 (still under development).
You are probably looking for version 1.0.0-beta. You can find the relative branches on hospitalrun-frontend and hospitalrun-server.


Adhere to new Github policy

It's recommended to adhere to the new Github rules and regulations, please see the migration docs. It's now also recommended to rename your default branch.

I propose to close this as equivalent to issue #21749


Documenter: class comment should be empty if a class has no comment

Currently Coder displays a default Pharo class comment template if there is no class comment:

We want to have an empty editor instead in such cases.

Now the class comment is empty


unable to customize AdminClientConfig programmatically

Due to security reason, our kafka credentials are stored in aws secrets manager and are extracted on the fly during the application bootstrap. With the ProducerConfigCustomizer and ConsumerConfigCustomizer beans, we can connect to our cluster successfully by injecting the SASL config into the producer / consumer properties. However, we are getting this error in the log.

2021-01-15 17:51:52.660  INFO 1 --- [| adminclient-6] o.a.k.c.a.i.AdminMetadataManager         : [AdminClient clientId=adminclient-6] Metadata update failed
org.apache.kafka.common.errors.TimeoutException: Timed out waiting to send the call.

From KafkaTopicProvisioner. it seems that the provisioner always creates the AdminClient from properties. Is there any way which we could customize the AdminClientConfig via a AdminClientConfigCustomizer bean? Thanks

Hi @colaho Here is a sample that demonstrates how to access a Kaka cluster with security by providing binder level properties. By providing it at the binder level, these security properties are applicable to all the components such as producer, consumer and admin client.
https://github.com/spring-cloud/spring-cloud-stream-samples/tree/master/kafka-security-samples/kafka-ssl-demo
This is the config for this project: https://github.com/spring-cloud/spring-cloud-stream-samples/blob/master/kafka-security-samples/kafka-ssl-demo/src/main/resources/application.yml
Here is another project that uses multi-binder support with security: https://github.com/spring-cloud/spring-cloud-stream-samples/blob/master/multi-binder-samples/kafka-multi-binder-jaas/src/main/resources/application.yml
Please let us know if they satisfy your use case. Thanks!

Hi @colaho Here is a sample that demonstrates how to access a Kaka cluster with security by providing binder level properties. By providing it at the binder level, these security properties are applicable to all the components such as producer, consumer and admin client.
https://github.com/spring-cloud/spring-cloud-stream-samples/tree/master/kafka-security-samples/kafka-ssl-demo
This is the config for this project: https://github.com/spring-cloud/spring-cloud-stream-samples/blob/master/kafka-security-samples/kafka-ssl-demo/src/main/resources/application.yml
Here is another project that uses multi-binder support with security: https://github.com/spring-cloud/spring-cloud-stream-samples/blob/master/multi-binder-samples/kafka-multi-binder-jaas/src/main/resources/application.yml
Please let us know if they satisfy your use case. Thanks!

Hi @sobychacko, our case is a bit different from the examples.
Because the credentials are secretly stored on the aws (in another words, we won't even know it in production) and are rotated regularly, we could not put it statically in the properties. As mentioned, for consumer and producer, we used the ProducerConfigCustomizer and ConsumerConfigCustomizer beans to dynamically inject the credentials and it works.
    @Bean
    public ProducerConfigCustomizer producerConfigCustomizer() {
        return props -> {
            props.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, "SASL_SSL");
            props.put(SaslConfigs.SASL_MECHANISM, "SCRAM-SHA-256");
            props.put(SaslConfigs.SASL_JAAS_CONFIG, String.format("%s required username=\"%s\" password=\"%s\";",
                    ScramLoginModule.class.getName(),
                    awsSecret.get("USERNAME"),
                    awsSecret.get("PASSWORD")
            ));
        };
    }

But this doesn't apply to the AdminClient because there is no such AdminClientConfigCustomizer now.

Hi @sobychacko, our case is a bit different from the examples.
Because the credentials are secretly stored on the aws (in another words, we won't even know it in production) and are rotated regularly, we could not put it statically in the properties. As mentioned, for consumer and producer, we used the ProducerConfigCustomizer and ConsumerConfigCustomizer beans to dynamically inject the credentials and it works.
    @Bean
    public ProducerConfigCustomizer producerConfigCustomizer() {
        return props -> {
            props.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, "SASL_SSL");
            props.put(SaslConfigs.SASL_MECHANISM, "SCRAM-SHA-256");
            props.put(SaslConfigs.SASL_JAAS_CONFIG, String.format("%s required username=\"%s\" password=\"%s\";",
                    ScramLoginModule.class.getName(),
                    awsSecret.get("USERNAME"),
                    awsSecret.get("PASSWORD")
            ));
        };
    }

But this doesn't apply to the AdminClient because there is no such AdminClientConfigCustomizer now.

@colaho Sure, that makes sense. We can think about adding a hook to customize the admin config. We will let you know if there are any updates.

@colaho Sure, that makes sense. We can think about adding a hook to customize the admin config. We will let you know if there are any updates.


"invalid need: expected Call, have Poll"

When I try to use PromptDialog.Confirm, I get this error. The code:
`
[LuisIntent("Define")]
public async Task Define(IDialogContext context, LuisResult result)
{
PromptDialog.Confirm(context, AfterConfirming_TurnOffAlarm, "Are you sure?");
context.Wait(MessageReceived);
}
public async Task AfterConfirming_TurnOffAlarm(IDialogContext context, IAwaitable confirmation)
{
 if (await confirmation)

    {
            await context.PostAsync($"Ok, alarm disabled.");

    }

   else

   {

       await context.PostAsync("Ok! We haven't modified your alarms!");

    }

   context.Wait(MessageReceived);

  }

}
`

You only need to use PromptDialog.Confirm or context.Wait(MessageReceived) not both - the prompt dialog itself will call context.Wait(MessageReceived) internally.

I'm going to close this issue - feel free to re-open to discuss.

I am getting invalid need exception when I iterated a for each loop over a JSON object(two-dimensional). I want to display the keys in JSON object one after another and also had to wait for response from user after every question. I getting this exception first and after that the first question is displayed. I am using choice selection and confirmation dialogs for every question. Can anyone suggest me a solution.


[HEXAGON] Disable automatic unrolling in LLVM

Automatic unrolling in LLVM was causing significant issues with compile time and binary size of a bert int8 model. This patch disables unrolling in LLVM for the hexagon backend. While not a permanent solution, this should unblock some development efforts on this path.
cc @mehrdadh

@joshherr-quic please update the PR description :)

I see that this is failing CI on Hexagon with this error (link):
[2022-08-29T22:19:07.000Z] tests/python/contrib/test_hexagon/test_2d_physical_buffers.py::TestElementWise::test_build[nhwc-nhwc-int8-16-32-32x32-nhwc-global-hexagon] LLVM ERROR: Cannot select: 0x3fbc580: v8i8 = HexagonISD::VASL 0x3e53240, Constant:i32<1>
[2022-08-29T22:19:07.000Z]   0x3e53240: v8i8,ch = load<(load (s64) from %ir.cgep31, align 64, !tbaa !97)> 0x3da4928, 0x3d14738, undef:i32
[2022-08-29T22:19:07.000Z]     0x3d14738: i32 = add 0x3d14390, Constant:i32<-128>
[2022-08-29T22:19:07.000Z]       0x3d14390: i32,ch = CopyFromReg 0x3da4928, Register:i32 %14
[2022-08-29T22:19:07.000Z]         0x3d14a78: i32 = Register %14
[2022-08-29T22:19:07.000Z]       0x3d13f80: i32 = Constant<-128>
[2022-08-29T22:19:07.000Z]     0x3f81c38: i32 = undef
[2022-08-29T22:19:07.000Z]   0x3d14120: i32 = Constant<1>
[2022-08-29T22:19:07.000Z] In function: default_function_compute_
[2022-08-29T22:19:07.000Z] Fatal Python error: Aborted

If CI is using LLVM build provided by Hexagon SDK <IP_ADDRESS> (link), does this mean CI would need a newer version of the Hexagon SDK for this PR?

Is this crash solved by https://github.com/llvm/llvm-project/commit/3c817574c2db9dbb003914dc40d58fe1dcfda855? If so, this could be gated on TVM_LLVM_VERSION >= 160

Contributor

Accidentally closed....

Is this crash solved by https://github.com/llvm/llvm-project/commit/3c817574c2db9dbb003914dc40d58fe1dcfda855? If so, this could be gated on TVM_LLVM_VERSION >= 160

That's correct, I'll go ahead and gate it and push a followup commit.


Invalid example, postgresql -> postgres

Example is invalid. Should be postgres, see for another example: https://github.com/Kong/kong/blob/2.0.1/kong/plugins/basic-auth/migrations/000_base_basic_auth.lua

Yes, this PR is correct! Thanks @teunis90 for the fix and @h3xar0n for the ping!

Thanks for accepting.


Fix publish/release workflow

The release workflow still mentions this repository with the old name.

This is due to a repository name change.


just testing

Just added myself to the list . Please let me in :)

well i want to change my name in  the list "which i have spelled incorrectly"just add this one


[WIP] [i18n-KO] Translated auto class tutorial

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@gabrielwithappy  @wonhyeongseo, @jungnerd, @0525hhgus, @KIHOON71, @sim-so, @gabrielwithappy
Please review this PR

이게 뭡니까?

제목 외에는 번역된 것이 없습니다. 추가 작업 부탁드립니다.


fixes white space at bottom on compliance dialog

Coverage remained the same at 27.594% when pulling 546d04cc94aa48942430143ee060ae8b4a7e8587 on theseyi:fix-dialog into a20ca2a0ddff7d341fda5d937fa4a7e7db3c2e41 on linkedin:master.

Codecov Report

Merging #1256 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1256   +/-   ##
======================================
  Coverage    5.83%   5.83%
======================================
  Files          57      57
  Lines        2211    2211
  Branches      478     478
======================================
  Hits          129     129
  Misses       2082    2082

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20ca2a...546d04c. Read the comment docs.


Dangerous chown in cmd/security-secretstore-setup/entrypoint.sh

Use chown -Rh . Without the -h chown will follow symlinks and can corrupt other parts of the OS (like making a symlink to /etc/shadow suddenly owned by edgex-user.

@bnevis-i I'm on it...

@bnevis-i I'm on it...

PR created to fix this: https://github.com/edgexfoundry/edgex-go/pull/3024

PR created to fix this: https://github.com/edgexfoundry/edgex-go/pull/3024


Bold subscripts have wonky letter positioning

Description
I think the issue is best described in the following image:

Basically, bold text-mode subscripts have very wonky positioning. This issue does not affect superscripts or math-mode subscripts.
Additionally, I'm not very sure but it seems like even R#sub[peak] has inconsistent spacing in between letters.
R#sub[peak] #sym.arrow.l ```typst R#sub[peak]```

*R#sub[peak]* #sym.arrow.l ```typst *R#sub[peak]*```

Reproduction URL
https://typst.app/project/r6hqHZ9hgfPdvR9oJYlaTi
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

I suspect that this is a font issue

Seems like it, if I change the font like #set text(font: "Fira Mono") or #set text(font: "Barlow") the issue disappears.

Doesn't seem like the switch to Libertinus Serif fixed this. :/
Not sure whether this is related: https://github.com/alerque/libertinus/issues/511
cc: @alerque

This does look like o bug in the Bold weight of Libertinus (even if Linux Libertine has the same bug and we just inherited it, the whole point of the fork was to fix outstanding bugs). I can look into it but no promise as to when. My just-born son is in NICU so everything in life is topsy turvey for a while. I only happened to see this notification on a drive-by glance at GitHub. If somebody would report a full issue to the Libetinus repo that would be great (and of course PR's are welcome too!).

Congratulations on your newborn! 🎊


Query bootstrap node

Depends on https://github.com/keep-network/keep-core/pull/3240

The script should query the bootstrap node for the list of connected peers and for each peer, extract information about the client version and the number of pre-parameters in the pool. Aggregate the result and publish it to a bucket on GCP

There are two scripts that need to be run to publish peers data to GCP bucket.

scripts/diagnostics.sh - collects and aggregates the peers data and saves it locally under diagnostics/peers_<timestamp>.json file
scripts/upload_peers.sh --oauth2-token <path-to-oauth2-token> - uploads the diagnostics/peers_.json` to the GCP bucket. The oauth2-token must be obtained from GCP and stored locally.

Example JSON that would be stored on GCP https://storage.googleapis.com/diagnostics_test/peers_1663587803.json
{
   "peers":[
      {
         "chain_address":"0x5232E393602c498D216d680C4cAbb0Cd179d1d16",
         "version":"v1.3.1-5904-g06081c6af (revision 06081c6af)",
         "preParamPoolSize":279
      },
      {
         "chain_address":"0xcAB2a402bAc470686d14956FB310D51BbEF9fA31",
         "version":"v1.3.1-5904-g06081c6af (revision 06081c6af)",
         "preParamPoolSize":103
      }
   ]
}

Creation of GCP Bucket and a service account
Bucket creation
Cloud Storage -> Buckets -> Create. Follow the steps to create a bucket.
Create a service account

IAM & Admin -> Service Accounts -> Create Service Account -> follow the steps

Making a bucket public
Go to the buckets list -> select a bucket -> edit access

Add a service account to a bucket

Cloud Storage -> Buckets -> select a bucket -> Permissions tab -> Add a service account with "Storage Object Creator" role.

List GCP accounts and set a service account

gcloud auth list
gcloud config set account <SERVICE_ACCOUNT>

Get oauth2 token

gcloud auth print-access-token
or https://developers.google.com/oauthplayground/

Did you test this script with our testnet? Can you provide an example of a call for this scenario?

Did you test this script with our testnet? Can you provide an example of a call for this scenario?

I've run my local node instance pointing to Goerli network, but Goerli nodes don't have all the latest changes so the API call will return null for the version and pre-params size. This PR also adds address to the JSON result. To fully test it on Goerli, this PR should be merged first and then we can run diagnostics.sh and upload_peers.sh.
I've tested it on my local box too.

Overall it works great. But I noticed that sometimes happens that the addresses property is returned as null.
{
    "client_info":
    {
        "chain_address": "0xaabeB99Ece50a1dbeE06217e31fc45Bf18D37eEC",
        "network_id": "16Uiu2HAkwHzFwbHjoWRT7qPfmD7MzobSYSe8579ud1Rhjidssna8",
        "revision": "unknown",
        "version": "unknown"
    },
    "connected_peers":
    [
        {
            "addresses":
            [
                "<IP_ADDRESS>"
            ],
            "chain_address": "0xB8d1511aFab121f07cfDC7D1086371b1Fa758Fa2",
            "network_id": "16Uiu2HAm1buBFu8sHmgToezz6994uqQCZZ42azxrJP5GTxWmcBPA"
        },
        {
            "addresses":
            [
                "bootstrap-1.test.keep.network",
                "keep-client-1.default.svc.cluster.local"
            ],
            "chain_address": "0xcAB2a402bAc470686d14956FB310D51BbEF9fA31",
            "network_id": "16Uiu2HAm3eJtyFKAttzJ85NLMromHuRg4yyum3CREMf6CHBBV6KY"
        },
        {
            "addresses":
            [
                "bootstrap-0.test.keep.network",
                "keep-client-0.default.svc.cluster.local"
            ],
            "chain_address": "0x0eC14BC7cCA82c942Cf276F6BbD0413216dDB2bE",
            "network_id": "16Uiu2HAmCcfVpHwfBKNFbQuhvGuFXHVLQ65gB4sJm7HyrcZuLttH"
        },
        {
            "addresses":
            [
                "keep-validator-0.eks-ap-northeast-2-secure.staging.staked.cloud"
            ],
            "chain_address": "0xCa8754f7060A0648824f274e3a4d897FA497139D",
            "network_id": "16Uiu2HAm77eSvRq5ioD4J8VFPkq3bJHBEHkssCuiFkgAoABwjo2S"
        },
        {
            "addresses":
            [
                "<IP_ADDRESS>"
            ],
            "chain_address": "0x1F91c3e91745aB09cc8e619ceD8Fa79B602e3649",
            "network_id": "16Uiu2HAky2Y4Tyq5vTA1CxikcDes6o5EH11i2qcg5dBV9W3Lks5c"
        },
        {
            "addresses":
            [
                "<IP_ADDRESS>"
            ],
            "chain_address": "0x37847B906612885d7172639947Cecf76036458bA",
            "network_id": "16Uiu2HAmQaxEutkqzahSE19b9DhSXGCdb1BAfkGrt26obq1n6N9k"
        },
        {
            "addresses": null,
            "chain_address": "0x5232E393602c498D216d680C4cAbb0Cd179d1d16",
            "network_id": "16Uiu2HAmMosdpAuRSw1ahNhqFq8e3Y4d4c5WZkjW1FGQi5WJwWZ7"
        }
    ]
}


TypeName.Name doesn't return full assembly qualified type name

When we are loading the default style for an object, we need the full assembly qualified name, so that we can form the appropriate URI to load generic.xaml from.
Repro:

Create a new WinUI Desktop App for C#

Add reference to Microsoft.Toolkit.Uwp.UI.Controls.DataGrid nuget package, version 8.0.0-preview1 from this feed: https://dotnet.myget.org/gallery/uwpcommunitytoolkit

Add the DataGrid control to MainWindow.xaml and F5

When we try to resolve the type name for the control so we can load the appropriate generic.xaml file, we QI the DefaultStyleKey property for IReference<TypeName>, when this QI succeeds, we get the TypeName.Name property and use that to find the assembly the control is located in.
.NET Native: Microsoft.Toolkit.Uwp.UI.Controls.DataGrid, Microsoft.Toolkit.Uwp.UI.Controls.DataGrid, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
.NET5: Microsoft.Toolkit.Uwp.UI.Controls.DataGrid

@dotMorten for FYI

@stevenbrix Thanks! This is definitely a blocker issue for us.

@dotMorten you can workaround this by putting a line like this in your app.xaml:
<Application.Resources>
   <ResourceDictionary.MergedDictionaries>
       <ResourceDictionary Source="ms-appx://Esri.ArcGISRuntime.WinUI/Themes/Generic.xaml"/>
   </ResourceDictionary.MergedDictionaries>
</Application.Resources>

This has been fixed by the latest dotnet. (net 5.0.100 RTM or greater).

closed by mistake

This issue should be fixed with this commit
@stevenbrix @RealTommyKlein
Please check if the upcoming update of CsWinRT fixes this.

@ujjwalchadha this looks like something we can validate ourselves, right?

I'll be more than happy to validate too, once preview 3 ships, unless you want to share a preview of the preview with me again 😉

@dotMorten Thanks! We’ll let you know if that’s necessary.

Fixed with CsWinRT1.0.1


[3.2] Improve Raycast render debug

Fix Raycast node render debug not showing in editor camera preview.
Use dynamic mesh update to change the ray on-the-fly without too much extra cost when collision debug is enabled.
Fixes #43571
PR on master: #45197

Thanks!

Thanks!


Add option to save as simple file instead of folder

I've experienced some problems with the "folder"/"archive" models for workbooks.
My setup is that I'm using workbooks for tutorials.
As part of this I would like several workbooks to share a shared.csx script
However, when I use #load "shared.csx" then Xamarin workbooks insists on making a folder and taking a local copy of shared.csx - which means that the script is not longer really shared.
Is there any way to prevent this from happening?
If not, would you accept a PR that added "flat file" an option in this list:

(maybe linked to my hopefully-soon-to-come PR for #189?)

Any time you reference a resource (be it image, csx, dll, whatever) with a relative path, Workbooks tries to package it up. It might only be if the file is alongside the .workbook file, though.
I think an option to save as a flat file would be ok, but we would need to warn the user that they are responsible for keeping their resources accessible to the workbook somehow.


Name steps

Applied mkpr on .github/workflows/ci.yml
sed s/run: npm run cover --if-present/name: test and coverage\n        run: npm run cover --if-present/

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.519%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
165

Relevant Lines:
209

💛  - Coveralls


Release 4.0.0

Bumps the version in package.json and updates the changelog
Replaces https://github.com/MetaMask/eth-token-tracker/pull/72, because as @Gudahtt recognized in this comment, this version includes the breaking change of updating the minimum node version

A new version of the package @metamask/eth-token-tracker (4.0.0) was published at 2022-01-13T15:21:49.966Z from
redacted]. The shasum of this package was f3129855873a857ef675d4c28f532be684241b61.


Fixed JSON samples

The JSON for the full sample host.json and for the http section were missing a comma and a value.

@gbellmann : Thanks for your contribution to the Azure documentation! The author, @tdykstra, has been notified to review your proposed change.

@gbellmann Thanks for the corrections!
#sign-off


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 644

Questions ?
Please refer to the Backport tool documentation


Updated profile description [WIP]

Started refactoring the profile description, but still work-in-progress.

Looks great!
Just thinking about whether we should move the Overview part or a reduced version of it into the README, like we did in the ARC profile?
There you could also beautify it a bit by using the assay and run image from here to showcase the similarity of assays and runs.

Sounds like a good idea!

@HLWeil What do you think about the "Example Workflow Run Crate configuration in ARCs" paragraph (the text, not the figure)? I'm not sure what to do with it, since I also don't really understand everything explained there. Should we keep it, modifiy it or remove it?

@HLWeil What do you think about the "Example Workflow Run Crate configuration in ARCs" paragraph (the text, not the figure)? I'm not sure what to do with it, since I also don't really understand everything explained there. Should we keep it, modifiy it or remove it?

I think the main point of this text is that to keep down complexity:

each workflow should have a top-level workflow description
each run should have one top-level run description
the top-level run description should be the execution of one top-level workflow description

Very nice!
Could you move the images in the README into an images folder? Then we're goog to go


use https for repo url rather than http

Module should default to using https rather than unsecured http. This would also be consistent with official installation docs for logstash.

+1


Training the model using Arabic characters

Hi Holmeyoung,
I have built my own dataset, which consist of Arabic characters. I have followed your steps for building my dataset. I was able to convert my dataset to lmdb successfully. However, when I tried to train the model,  got this error:
CRNN(
(cnn): Sequential(
(conv0): Conv2d(1, 64, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1))
(relu0): ReLU(inplace)
(pooling0): MaxPool2d(kernel_size=2, stride=2, padding=0, dilation=1, ceil_mode=False)
(conv1): Conv2d(64, 128, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1))
(relu1): ReLU(inplace)
(pooling1): MaxPool2d(kernel_size=2, stride=2, padding=0, dilation=1, ceil_mode=False)
(conv2): Conv2d(128, 256, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1))
(batchnorm2): BatchNorm2d(256, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(relu2): ReLU(inplace)
(conv3): Conv2d(256, 256, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1))
(relu3): ReLU(inplace)
(pooling2): MaxPool2d(kernel_size=(2, 2), stride=(2, 1), padding=(0, 1), dilation=1, ceil_mode=False)
(conv4): Conv2d(256, 512, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1))
(batchnorm4): BatchNorm2d(512, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(relu4): ReLU(inplace)
(conv5): Conv2d(512, 512, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1))
(relu5): ReLU(inplace)
(pooling3): MaxPool2d(kernel_size=(2, 2), stride=(2, 1), padding=(0, 1), dilation=1, ceil_mode=False)
(conv6): Conv2d(512, 512, kernel_size=(2, 2), stride=(1, 1))
(batchnorm6): BatchNorm2d(512, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(relu6): ReLU(inplace)
)
(rnn): Sequential(
(0): BidirectionalLSTM(
(rnn): LSTM(512, 256, bidirectional=True)
(embedding): Linear(in_features=512, out_features=256, bias=True)
)
(1): BidirectionalLSTM(
(rnn): LSTM(256, 256, bidirectional=True)
(embedding): Linear(in_features=512, out_features=69, bias=True)
)
)
)
Traceback (most recent call last):
File "train.py", line 177, in
cost = trainBatch(crnn, criterion, optimizer)
File "train.py", line 154, in trainBatch
t, l = converter.encode(cpu_texts)
File "/Volumes/EXTERNAL/Models/crnn_pytorch-master/utils.py", line 61, in encode
index = self.dict[char]
KeyError: '٩'
It sounds like the model can't recognize Arabic characters. Any suggestions?
Thanks

Hi, you need to add the characters appearing in your training labels to the alphabets.py .
For example
alphabet = '''٩'''

Thank you for your quick replay. I just added the characters to the alphabets.py and it works. However, as I can't download your pre-trained model, I used different pre-trained models, but I got this error:
RuntimeError: Error(s) in loading state_dict for CRNN:
size mismatch for rnn.1.embedding.bias: copying a param with shape torch.Size([37]) from checkpoint, the shape in current model is torch.Size([71]).
size mismatch for rnn.1.embedding.weight: copying a param with shape torch.Size([37, 512]) from checkpoint, the shape in current model is torch.Size([71, 512]).


Minecraft 1.18 compatibility

Plugin refuses to work on 1.18, I know that the latest release is 1.17, but it refuses to load on 1.18.

Hi @AmIlluminati,
That's because Minecraft 1.18 came just a few days ago! 😜
Anyways, I've made some changes to add support for 1.18 and released a new Yamipa version (v1.2.0).


context: DeadlineExceeded silently implements net.Error

// DeadlineExceeded is the error returned by Context.Err when the context's
// deadline passes.
var DeadlineExceeded error = deadlineExceededError{}

type deadlineExceededError struct{}

func (deadlineExceededError) Error() string   { return "context deadline exceeded" }
func (deadlineExceededError) Timeout() bool   { return true }
func (deadlineExceededError) Temporary() bool { return true }

The fact that context.DeadlineExceeded implements net.Error with both Timeout() and Temporary() returning true is not visible in the public documentation.
I guess it is way to late to remove those methods, so I propose to mention that fact in the documentation.

@gopherbot documentation

/cc @neild who recently filled a somewhat related proposal

the implementation is intentional #14238

I guess I don't see why it's interesting to specifically document this fact.  How does that help people?

It's interesting to me to document that DeadlineExceeded implements net.Error and returns true for Temporary(). Here's why: I had some code that errored out with a "context deadline exceeded" error. I'm planning to add retries to avoid that problem. The most generic way to add those retries is to check for err.Temporary() (with appropriate errors.As(..) casts).
I went looking for documentation on whether DeadlineExceeded is a Temporary error (I could see arguments either way), and wound up here. It would be great to have this in the official documentation rather than a GitHub issue.

net.Error.Temporary is meaningless. As you note, it's been deprecated.
It seems obvious to me that DeadlineExceeded is a timeout. I'd be very surprised if DeadlineExceeded implemented net.Error but returned false for Timeout.
So the question is whether context should document that the standard implementation of Context returns errors that implement net.Error. I suppose we could, but I suspect that doing so would cause more confusion than benefit: Now users will wonder if they should be type converting context errors to net.Error and checking the Timeout method, when the simple path is direct comparison to context.DeadlineExceeded.

Direct comparison to context.DeadlineExceeded is only appropriate if all possible timeout errors return context.DeadlineExceeded or something that wraps it. For non-stdlib packages that can definitely be a grab bag. Is it true of stdlib packages? For instance, if a net/http request errors out due to a ReadTimeout or a WriteTimeout, is that a context.DeadlineExceeded?

For instance, if a net/http request errors out due to a ReadTimeout or a WriteTimeout, is that a context.DeadlineExceeded?

It is not - probably historical reasons. There has been an attempt to change it.


Show zeros and process integers according to precision.

When the value of the field is 0 the actual code does not add the zero + decimal precision (e.g 0.00) to the field UI. A fix for that is provided here.
When the value of the field is an integer, the actual code takes the precision decimals from the integer.
For example, if the original value is 600, and the precision is set to 2, what will be displayed is 6.00.
A fix for this issue is also provided here.
Also added more samples to the demo/index.html file.
Note:
Code from the pull request #6 also added here.
No need to accept pull request #6 if this pull request is accepted.

@samcarecho I didn't get why you did some points in your code.. for example this snippet:
    var multiplier = Math.pow(10, this.precision);

   var value = (this.value * multiplier) / multiplier;

   var fraction = value % 1;

   var decFraction = (fraction * multiplier) / multiplier;

Gabrielle,
The changes were requested long ago.
In the meanwhile, we decided to build our own component.
All the changes made to the code have a reason. I will need to go through my old notes to recall what I've done and why. As soon as possible I will do that.
Cheers


Fix "milage" typo in tips and tricks

Before submitting a pull request, make sure it's targeting the right branch:

For fixes to Ink 1.0, use master.
For fixes to Foundation for Emails 2, use v2.0.

Happy coding! :)

Hi @ecirish,
Many thanks for your contribution to Foundation Emails.


Reverse order of menuitems

Why did you choose to swap these menu items?

@mennoo1996 I could argue for 6 hours about whyplacing stuff beneath the usual location of your Quit button is illegal in 20 countries, or I could just say "Because we don't hate our users". It's bad. Very bad.

On a sidenote, merging. Cool.


DELETE with body params not rendered correctly

Consider the following action:
delete: {
  summary: "Delete components",
  description: "Remove components",
  produces: [
    "application/json"
  ],
  parameters: [
    {
      in: "path",
      name: "page_id",
      description: "Page identifier",
      type: "string",
      required: true
    },
    {
      in: "path",
      name: "page_access_user_id",
      description: "Page Access User Identifier",
      type: "string",
      required: true
    },
    {
      in: "body",
      name: "component_ids",
      description: "List of component_ids",
      type: "array",
      items: {
        type: "string"
      },
      required: false
    },
    {
      in: "body",
      name: "dummy",
      type: "string",
      required: false
    }
  ],
  responses: {
    204: {
      description: "Remove components"
    }
  },
  operationId: "deleteComponents"
}

When rendered in ReDoc, this shows up like this:
REQUEST BODY SCHEMA: application/json
Array
string

The field name is missing, as is the second parameter.

This is most likely related to #617, however the workaround in that issue does not work here.

Your spec is invalid. You can have ONLY ONE in body parameter.
Bellow are screenshots from the spec:

Also, body parameter must be described using schema:

I think you wanted this:
delete: {
  summary: "Delete components",
  description: "Remove components",
  produces: [
    "application/json"
  ],
  parameters: [
    {
      in: "path",
      name: "page_id",
      description: "Page identifier",
      type: "string",
      required: true
    },
    {
      in: "path",
      name: "page_access_user_id",
      description: "Page Access User Identifier",
      type: "string",
      required: true
    },
    {
      in: "body",
      name: "name_doesnt_matter_for_body_parameters",
      schema: {
        type: "object",
        properties: {
          component_ids: {
            description: "List of component_ids",
            type: array,
            items: {
              type: "string"
            }
          },
          dummy: {
            type: "string"
          }
        }
      }
    }
  ],
  responses: {
    204: {
      description: "Remove components"
    }
  },
  operationId: "deleteComponents"
}


feat(AlgebraicGeometry/EllipticCurve/Jacobian): implement group operations on nonsingular rational points for Jacobian coordinates

Define a addition-preserving bijection toAffine_addEquiv with the affine case to prove Point is an abelian group.
This is the fourth in a series of four PRs leading to #9405 and is analogous to #9420

[x] depends on: #9432
[x] depends on: #9433
[x] depends on: #9435
[x] depends on: #13060

Seems we need to add Jacobian.lean to style-exceptions (see here), or compress it (e.g. lemmas that fit in a single line, and blanks between such lemmas), or split it up.

Thanks 🎉
maintainer merge

Thanks!
bors merge


fixing relative paths to automation/.../ definitons.json and web/.../commondefinitions.json

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

 https://github.com/Azure/azure-sdk-for-ruby/pull/1209

 https://github.com/Azure/azure-sdk-for-python/pull/1730


Fixed tests target (path to Info.plist was wrong, so tests didn't run)

When I created a project using "./configure", then opened Xcode and hit "Cmd+U" (to run the tests). Xcode can't find Info.plistor the tests, because in a base project it is located in Tests folder, but in project.pbxproj it was "__PROJECT_NAME__Tests/Info.plist". Removing "PROJECT_NAME" in plist path fixed the problem.
P.S. Thanks a lot for this template - very useful.

The files you are editing are actually a derived build product of the RECIPE.md. Could you please also send the change to the original recipe?

I've added steps to the recipe, also did my changes in Xcode to the template.

Looks great, thank you!


Add timestamps to tagging-sync-check build

A day may come when this sort of thing is templated into all jobs.
But it is not this day.
See https://github.com/alphagov/govuk-puppet/pull/4472

👍  when green


Add generation scripts for ts/js files

Summary
Currently autogenerated ts, js files added to /client/generated
And It has a dependency for .proto files
Proposal
so It would be better to add generating scripts to update JS/TS files according to the change of .proto files
@clockworkgr Could I get the scripts you used to generate these files?  or could you add them as a PR?

For Admin Use

[x] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

These were generated by starport (built from develop branch at the moment).
As long as config.yml in the liquidity repo contains the key:
client:
  vuex:
    path: "generated"

If you run starport build --rebuild-proto-once , it will regenerate the client ts/js files.

Once the new starport versions is released, we could try and automate this in a github action to rebuild on pushes to develop (and potentially autopublish  to npm, although this woud require TS/JS to be generated in a deterministic way so we can check whether it's changed or not...currently it isn't, see: https://github.com/tendermint/starport/issues/838)


Add support for newer slurm pam module

Slurm has a newer pam module pam_slurm_adopt.so, which enables ssh connections to compute nodes to adopt the cgroups of the running reservations. This PR allows for enabling this module instead of pam_slurm.so.
New variables:

pam_enable_slurm_adopt (default: False) : Enables pam_slurm_adopt.so. Incompatible with pam_enable_slurm (this is not checked in the task). This also disables pam_localuser.so and pam_localuser.so as they overwrite the module.

New tests:

There's now molecule tests that run in Docker and test for these three different cases:

No slurm
pam_enable_slurm enabled
pam_enable_slurm_adopt enabled

Installation instructions for molecule are included in molecule/default/INSTALL.rst.

Looking good.


Have to manually change current working directory

I currently use git-rev as follows:
process.chdir(__dirname)
git.short(function (str) {
  // ...
})

But isn't the first line redundant? In the beginning of git-rev's index.js file, there is this:
exec(cmd, { cwd: __dirname }, function (...) { ... })

So git-rev should automatically take care of changing the current working directory. However, if I simplify my code:
git.short(function (str) {
  // ...
})

Then it doesn't work unless I already am in the correct directory.

Hang on. It turns out that the version in my node_modules/ folder (which I got via npm) is really old -- the latest version was published 5 years ago.
Duplicate of #7, then?


Show quickInfo on mouse hover?

I don't think it's supported so far, but it would be nice to support quickinfo on mouse hover. Often I'm not interested in having the quickinfo box always showing when I move my cursor/caret around, but sometimes I would like to quickly inspect types/docs on identifiers by hovering over them with my mouse, instead of moving the cursor around. Sorta like how most non-vim based IDEs do.

I have a similar quibble. I find the persistent popping up of the quickinfo popup window annoying; I would like to reduce this by either

having a mode where only mouse hover triggers the popup
suppressing the quickinfo whenever the cursor is not over a symbol name. currently, e.g. in ocaml code, i get a quickinfo window showing type information of the enclosing function when the cursor is anywhere in the function body, including whitespace. that's too much.


[Feature] Change endpoints in installments and issuers

// Description
Cambios:

Se cambian los endpoints de getIssuers() y getInstallments(). Ahora apuntan a /checkout

Note: Los cambios de back todavia no estan deployados en /v1, estan solo en beta
Requirements

[ ] Coverage > 90%

Note:

[X] Android Lint check

Note:

[ ] Code Style checked

Note:

[ ] Tested with "Don't keep Activities" configuration.

Note:
If impacts documentation (new components, inputs or outputs?)

[ ] PR to develop-docs

Note: No aplica

Codecov Report

Merging #630 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #630   +/-   ##
========================================
  Coverage    27.36%   27.36%
========================================
  Files          230      230
  Lines        16895    16895
  Branches      1474     1474
========================================
  Hits          4623     4623
  Misses       11773    11773
  Partials       499      499

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a3176...92d542c. Read the comment docs.


feat: Add modular_exponentiation.cpp

Description of Change

Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

@ayaankhan98 @kvedala Please review my pull request.

@kvedala @ayaankhan98 I have added the tests. Please review and approve my request.

@ayaankhan98 Please review and merge my request.


Draft: [API Proposal]: Add listenAddress parameter to Server classes

Pull request for #79
ToDo:

[x] Implement initial changes for testing
[x] Add new Constructor signatures as not to break existing code
[ ] Add / Update documentation
[ ] Test changes with Tom

A few things:

the Server class's constructor shouldn't take in an IP address, as that class needs to be transport-agnostic, and not all transports use IP addresses (like the Steam transport),
the TcpPeer class shouldn't require any changes—binding to a specific IP is something that's only necessary for the server (right?),
the IPAddress listenAddress parameter should be an optional parameter, and should go at the end of the parameter list in order to not change the current API,
the SocketMode type should still be respected in cases where no specific IP is supplied,
pull requests should be based on and merged into the dev branch, not main, and
commit messages should use the format described in the contribution guidelines.

I may just quickly make the changes myself as it should only be a few lines of code.

Closed as Tom already made the necessary changes


IGNORE NULLS breaks window function parsing

Minimal example with "IGNORE NULLS" included in the window function.

And here it is working without:

select
    last_value(a) ignore nulls over (
        partition by c
        order by d
        rows between unbounded preceding and unbounded following
    ) as a,
    last_value(b) ignore nulls over (
        partition by c
        order by d
        rows between unbounded preceding and unbounded following
    ) as b
from some_table
where a = 1

Modifying the sql to the following fixes the issue:
select
    last_value(a ignore nulls) over (
        partition by c
        order by d
        rows between unbounded preceding and unbounded following
    ) as a,
    last_value(b ignore nulls) over (
        partition by c
        order by d
        rows between unbounded preceding and unbounded following
    ) as b
from some_table
where a = 1


Chrome cannot be dragged , but edge can。

Chrome cannot be dragged , but edge can。
My chrome version 103.0.5060.134（64 位）

Which version of taskcafe are you using?

Hm. I have tested both on the latest Brave and Edge (both are Chromium-based), as well as on Safari and Firefox — all the latest versions as of January 2023 — and they all work under macOS Big Sur 11.7.3. Taskcafé is commit 998db2a5da497a7902198a728ddc040fcacbacd6 (schema migration 65).

Unable to replicate on my end


Listing branch

Change branch name to Brandon Branch
Changes implemented:

Login Page Authentication + Register
Login Detail JSON
Setting Preferences