I'm reviewing the documentation and noticed that the links to [QGP_Bayes] and [nsat] in the README are not working. Would it be better to link directly to their repositories? If so, I can do it.

@wildsm Hoping that I'm in the correct PR...
I'm reviewing the documentation and noticed that the links to [QGP_Bayes] and [nsat] in the README are not working. Would it be better to link directly to their repositories? If so, I can do it.

Please do

This is a minor issue.
All SDKs listed here have the title 'BAND SDK v0.2' except for SAMBA, which says 'BAND SDK v0.4'. My understanding is that we use BAND SDK v0.2 for BAND Framework v0.4. If that's correct, @asemposki needs to update the title. Otherwise, we'll need to update all the other titles—except Alexandra's! :)

Thanks @ozgesurer for pointing that out; I will fix that submodule.

Thanks @ozgesurer for pointing that out; I will fix that submodule.

If I click through the current develop
https://github.com/bandframework/bandframework/tree/develop/software
I see the SAMBA sdk as v02, so the previous submodule was OK with this.
On the other hand
https://github.com/bandframework/bandframework/tree/develop/resources/sdkpolicies/README.md
links to
https://github.com/asemposki/SAMBA/blob/main/SAMBAbandsdk.md
in order to capture any updates that the packages have made to their SDKs.
With @asemposki's recent change to SAMBA's main the above link also shows v0.2.
Thanks both.

With authors complete, this is ready for review.
After approval and merge, we will not yet delete the branch so that subsequent changes can employ it until the release


⚠ Bofrost.at has degraded performance

In 03e6ea2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1301 ms

Resolved: Bofrost.at performance has improved in 241f580.


uBiome processing error

Currently fails on processing, some sort of file access error

Fixed by PersonalGenomesOrg/open-humans-data-processing@1abb584


FQDN filtering is GA

Hi, in the Azure Firewall documentation, FQDN filtering seems to be GA now. Does this page need an update or is using this feature through Firewall Manager somehow still in preview?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bbf29a05-078a-8637-36a1-748135e8d454
Version Independent ID: 33692686-5895-420d-949f-ffd0ea1aaec8
Content: Azure Firewall Manager filtering in network rules (preview)
Content Source: articles/firewall-manager/fqdn-filtering-network-rules.md
Service: firewall-manager
GitHub Login: @vhorne
Microsoft Alias: victorh

Article updated
#please-close


Sentry Relay: Reboot might fail to start nginx

We seem to have some race condition when starting nginx. We are explicitly binding on the external IPv6 address, which might fail if this address has not yet been assigned to the interface. In this case, we see the following logs:
May 13 17:27:46 sentry-relay-terraform systemd[1]: Starting nginx - high performance web server...
May 13 17:27:47 sentry-relay-terraform nginx[631]: nginx: [emerg] bind() to [2001:1438:4010:4700::5:e2]:80 failed (99: Cannot assign requested address)
May 13 17:27:47 sentry-relay-terraform systemd[1]: nginx.service: Control process exited, code=exited, status=1/FAILURE
May 13 17:27:47 sentry-relay-terraform systemd[1]: nginx.service: Failed with result 'exit-code'.
May 13 17:27:47 sentry-relay-terraform systemd[1]: Failed to start nginx - high performance web server.

Following, the service is not retrying to start the instance. Manually restarting nginx worked, but until I did so, the whole nginx server was not available (and thus the relay).

I already started to look around how to resolve this issue. My quick search revealed two potential solutions:

Adding an overwrite to the systemd config of nginx, making it dependent of the network being online. Potentially, the required change would be similar to the solution sketched in this ticket.
Allowing all applications, including nginx, to bind to a non-existing IP address, also known as non-local address. This would work as it would allow nginx to complete the boot process and hopefully just serve requests as soon as the address is available. Proceeding with this solution requires changing a kernel parameter, and is done separately for IPv4 and IPv6. If my search was correct, the setting can be changed globally or only for a specific network interface.

I am undecided, but was slightly in favor of the second solution with a change to the kernel parameter (since it would allow nginx to start even when one interface is temporarily not available). While the man page for the respective entry warns about potential issues, it seems like it only affects an assumption developers could make: Namely, the availability of a given IP address on the host if binding this address is successful. nginx and other proxies are aware of this, so that they shouldn’t make any issues.

Fixed by implementing an Ansible task that configures the second solution both for IPv4 and IPv6.


Fix for error[E0282] issue at attest-guest step

Downgraded latest rust installation to version 1.70 as a temporary fix to resolve error[E0282]: type annotations needed for Box<_> issue

#13 should update the snpguest version to 0.5.2, and then this PR will not be necessary. We can close it when that happens. @larrydewey @DGonzalezVillal

snpguest was updated and this bug was fixed there.


fix(3.2): The oneToOne method of the ReactorServerCalls class will cause the request to hang when the result is Mono Empty

What is the purpose of the change
When the return value is Mono Empty, it will cause the request to hang.
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ  @icodening  @EarthChen PTAL


[upload] Uploading build info to artifactory

Yesterday at the JFrog SwampUP! Conference in Munich I heard about JReleaser for the first time, you did a great job there! When asked about the following feature, I was asked directly to post it here as an feature request so here we go.
Is your feature request related to a problem? Please describe.
Uploading artifacts to JFrog Artifactory already works great, but it would be awesome if it could also upload a build info object (bill of materials) that was previously created when building the software, e.g. by using the Jenkins Artifactory plugin.
Describe the solution you'd like
An optional field in the Artifactory upload configuration for the buildInfo file to display all build information and software dependencies in Artifactory.

JReleaser supports releasing/uploading all kind of files that do not necessarily match a particular distribution (see distributions)
The files section may be used to configure additional files for release/upload/checksum/sign.
Build info files may be uploaded in this way regardless of how they were created. This means you may continue to generate build info files in the same way as you do today. Additionally, JReleaser may generate build info files for assembled distributions using the assemble command. This includes BINARY, JLINK, NATIVE_IMAGE, and NATIVE_PACKAGE.


use pkgconf instead of pkg-config when on bsd

That Fedora CI was just due to a timeout when downloading the tarball.
Given that all the others passed, it's probably safe to say that would have too.
But we could run the CI again.
Besides that, it seems like the BSD CIs passed!


Dates Wrong

Still getting error: Enable-SPOCommSite : The requested operation is part of an experimental feature that is not supported in the current
environment.
This page says it should work after 5/15

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 052c9917-ce90-f835-fa87-db8c0e492038
Version Independent ID: 4c7ea433-77d3-22c9-9931-07ba83d0baca
Content: Enable-SPOCommSite (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Enable-SPOCommSite.md
Service: sharepoint-powershell
GitHub Login: @trent-green
Microsoft Alias: trgreen

@officedocsbot assign @yogkumgit

We are also on Targeted Release for our organization and still receiving error: Enable-SPOCommSite : The requested operation is part of an experimental feature that is not supported in the current
environment as of 5/28/19.

Hello @trent-green can you kindly shine some light here on this matter? I appreciate

Yes, please update us on this as I've been waiting a long time for this feature and would love to use it.

The paragraph has been updated to reflect the most recent updates for the feature.  Thanks

Didn't see anything change in the paragraph above... it still states that Targeted Release would have it available after the 15th. Haven't spoken to anyone that has gotten this to work for their tenancy yet - was the rollout for Targeted Release delayed, or are you hopping straight to GA in the next week or two like the article implies?

@pyoungberg As @trent-green said, changes should be reflected soon, as the changes are not already being reflected, you can see the commit for these changes here https://github.com/MicrosoftDocs/office-docs-powershell/commit/96277b32eaf5faa18b298509bed894746542b3a1#diff-10d599650067fcfcd152e0666f40f283
Hope this information helps you. This change should go live soon.

Rollout delayed until at least Q3, got it. Thanks for the info!

Grrrr - so frustrating. Our Intranet home page has been in limbo for 6 months, awaiting this change.

I am also facing this issue. For months I am receiving this error... how long does it take for this update to roll out......

@get-itips / @trent-green can you update the article again please? We're in Q4 and the feature still hasn't rolled out to GA so the reference to 'more info in Q3' is misleading. You could probably just link it to https://www.microsoft.com/en-us/microsoft-365/roadmap?featureid=46338 and call it good.

Hello @pyoungberg Paul, I'll update the article as you requested. Thanks

@officedocsbot reopen

@trent-green Please merge this PR #4174

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @danmyhre Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Access to all pipelines

Is the setting "Allow access to all pipelines" removed? Last week it was still there. Personally I think it's a good thing, but I want to be sure it's definitely out.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8a872110-349f-1957-ae25-b2bf5275167c
Version Independent ID: 4044ea34-94c6-a5eb-161d-c01b0b053aca
Content: Variable groups for Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/library/variable-groups.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-library
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

@jkvbe -- thank you for your question.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@RoopeshNair -- please look into this issue.

@jkvbe You can lock or allow access to your resource from your Variable Group > Pipeline permissions as shown below. See Authorize a YAML pipeline for more details. See also Grant access permission to all pipelines.


fix(logger): ROX-21493: fix rate limited logger test

Description
I've noticed a flake in the rate_limited_logger, instead of expecting variadic arguments it expected a slice.
The assertion changed to a slice to match the variadic function arg of the log call.
Secondly the line number of the log line needed to be updated.
    rate_limited_logger.go:296: Unexpected call to *mocks.MockLogger.Logf([debug %s%s%s /code/pkg/logging/rate_limited_logger_test.go:213 -  This is a template for debug logs with 2 arguments to convert ]) at /code/pkg/logging/rate_limited_logger.go:296 because:
        expected call at /code/pkg/logging/rate_limited_logger_test.go:211 doesn't match the argument at index 2.
        Got: [/code/pkg/logging/rate_limited_logger_test.go:213 -  This is a template for debug logs with 2 arguments to convert ] ([]interface {})
        Want: is equal to pkg/logging/rate_limited_logger_test.go:213 -  (string)
    controller.go:98: missing call(s) to *mocks.MockLogger.Logf(is equal to debug (zapcore.Level), is equal to %s%s%s (string), is equal to pkg/logging/rate_limited_logger_test.go:213 -  (string), is equal to This is a template for debug logs with 2 arguments to convert (string), is equal to  (string)) /code/pkg/logging/rate_limited_logger_test.go:211
    controller.go:98: aborting test due to missing call(s)I facing a flake in the rate_limited_logger.

I've yet not understood why these tests succeeded on master but failed in my branch https://github.com/stackrox/stackrox/pull/8885.
Additionally the log tests are more verbose and omit the iteration calls. Before this change the only indication for this test failure was the exit code.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed

Fixed CI test

/retest

/retest


[WOC] Setup linting and other necessary repo bioler-plates

You may not require to add everything but this pr can be used as reference

@abhibhaw I would like to work on this.

@abhibhaw Is this project is gonna use .editorconfig or Js standard style is enough?

Editor config isn't required

fixed


march 8 translations v2

added French translations on feature and some overall improvements on terminology from @pierresauvignon

French translations...


Remove combine flag from microscope call

test-me-please

@eloycoto combine flag is removed, new --rich flag was added to show the column ui, combined view is default in 1.0.0

@nebril
It's working:
['cilium', 'monitor']
2018-04-25 12:03:38,942 WARNING Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError(SSLError(1, '[SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:2273)'),)': /api/v1/namespaces/kube-system/pods/cilium-l77lb
2018-04-25 12:03:38,940 WARNING Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError(SSLError(1, '[SSL: SSLV3_ALERT_BAD_RECORD_MAC] sslv3 alert bad record mac (_ssl.c:2273)'),)': /api/v1/namespaces/kube-system/pods/cilium-nwf8v

k8s1: Listening for events on 2 CPUs with 64x4096 of shared memory
k8s1: Press Ctrl-C to quit
k8s2: Listening for events on 2 CPUs with 64x4096 of shared memory
k8s2: Press Ctrl-C to quit
k8s2: <- host flow 0xb09c88f9 identity 1->0 state new ifindex enp0s8: <IP_ADDRESS>:6443 -> <IP_ADDRESS>:39060 tcp ACK
k8s2: -> endpoint 48896 flow 0xb09c88f9 identity 1->27475 state reply ifindex lxccd8b4: <IP_ADDRESS>:443 -> <IP_ADDRESS>:39060 tcp ACK
k8s2: <- endpoint 48896 flow 0xc9e98537 identity 27475->0 state new ifindex 0: <IP_ADDRESS>:39060 -> <IP_ADDRESS>:443 tcp ACK
k8s2: -> stack flow 0x4c3a168c identity 27475->2 state established ifindex 0: <IP_ADDRESS>:39060 -> <IP_ADDRESS>:6443 tcp ACK
k8s2: <- endpoint 48896 flow 0x587cd88f identity 27475->0 state new ifindex 0: <IP_ADDRESS>:39392 -> <IP_ADDRESS>:443 tcp ACK
k8s2: -> stack flow 0xc299379c identity 27475->2 state established ifindex 0: <IP_ADDRESS>:39392 -> <IP_ADDRESS>:6443 tcp ACK
k8s2: <- host flow 0x65825fd9 identity 1->0 state new ifindex enp0s8: <IP_ADDRESS>:6443 -> <IP_ADDRESS>:39392 tcp ACK
k8s2: -> endpoint 48896 flow 0x65825fd9 identity 1->27475 state reply ifindex lxccd8b4: <IP_ADDRESS>:443 -> <IP_ADDRESS>:39392 tcp ACK
k8s2: <- endpoint 48896 flow 0x587cd88f identity 27475->0 state new ifindex 0: <IP_ADDRESS>:39392 -> <IP_ADDRESS>:443 tcp ACK
k8s2: -> stack flow 0xc299379c identity 27475->2 state established ifindex 0: <IP_ADDRESS>:39392 -> <IP_ADDRESS>:6443 tcp ACK
k8s2: <- host flow 0x65825fd9 identity 1->0 state new ifindex enp0s8: <IP_ADDRESS>:6443 -> <IP_ADDRESS>:39392 tcp ACK


include atracker event routing in upgrade test

Description

https://github.com/terraform-ibm-modules/terraform-ibm-observability-instances/issues/272
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

As per the comment https://github.ibm.com/GoldenEye/issues/issues/4525#issuecomment-56117078 I reduced the number of tests creating routes, but this fails the upgrade test. Any action is needed here now?

Adding codeowners for review

Closing this PR as this work is being continued in this PR https://github.com/terraform-ibm-modules/terraform-ibm-observability-instances/pull/508


Lock TeamSpeak Package

Resolves issue on v3.8.0 where TeamSpeak failing connection
Further investigation required to updated to latest package

@AxonC @atoff Can either of you just sanity check this please, locking to known working version


Don't close standard file handlers

When 'shelling out' to an async operation, FileHandler.standardOutput can be passed in to see the output in realtime, in the same way as if the command had been executed in the Terminal:
try shellOut(to: "pod repo update", outputHandle: FileHandle.standardOutput)
ShellOut currently calls closeFile() on the passed in  output handler and error handler. In the case that one of the 'standard' handlers has been passed in, this causes issues such as print() not working.
This PR checks for the 3 standard handlers (input, output, error) and bypasses the call to closeFile(). Any other passed in FileHandler will receive the call.
@JohnSundell let me know how you feel about this solution. It does add a special casing for the 3 handlers (which is a bit weird), but the advantage is that there's no additional complexity to the api, which is probably a good thing for a scripting library!

Hey @JohnSundell. No problem, it's nice to finally get it merged in! 👍


why InsertValue rewrite the parameters?

Question
the method InsertValue.getParameters use parametersCount to subList the parameters。but when counting the paramCount just accept ParameterMarkerExpressionSegment. so that when my insert sql has parameters like ifnull(?,1)  , the value of paramCount is uncorrected 。finally
throw a java.sql.SqlException： No value specified for parameter 。

Why need to rewrite statements when there are no tables to sharding?

This part is still in refactoring.


Generating git hash value throws an error if using the release version of SCT

Because the SCT release version does not have any GIT metadata, calculating the version in qc throws an exception.

do we need to calculate the version in qc?

The bug has reappeared as a possible regression.


Download in the background process

If the user locked the screen the download is stopped. When I searched about it I found in Apple's documentation it recommends using NSURLSession instead of NSURLConnection here apple docs.
Is there a way to prevent the download from stopping when the app enters background. Or do I have to edit the implementation and use NSURLSession.

Hi,
This library was developed prior to the implementation of NSURLSession. See https://github.com/thibaultCha/TCBlobDownloadSwift for an implementation using NSURLSession. Als see #38 for a similar question.

Thanks. I am going to check it.

I used this code in [Apple Docs] (https://developer.apple.com/library/ios/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html#//apple_ref/doc/uid/TP40007072-CH4-SW5) as you suggested and it works fine.


TCPRoute is not getting attached to gateway

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
I created a TCPRoute with parentref pointing to TLS type section of my gateway. However the TCP route is not getting attached to the gateway section. I also have a couple of HTTPRoutes which are working fine with the same gateway. I also tried to use a seperate gateway for the TCP ingress but with the same result.
I then tried the TCP Traffic Shifting tutorial for Gateway API with the same result.
In the logs I found the following log messages.
2024-04-09T19:53:41.663914Z    warn    no virtual service bound to gateway: istio-io-tcp-traffic-shifting/tcp-echo-gateway-istio-autogenerated-k8s-gateway-tcp-31400
2024-04-09T19:53:41.664235Z    warn    gateway istio-io-tcp-traffic-shifting/tcp-echo-gateway-istio-autogenerated-k8s-gateway-tcp-31400:31400 listener missed network filter
2024-04-09T19:53:41.664383Z    info    gateway omitting listener "<IP_ADDRESS>_31400" due to: must have more than 0 chains in listener "<IP_ADDRESS>_31400"

Name:         tcp-echo-gateway
Namespace:    istio-io-tcp-traffic-shifting
Labels:       <none>
Annotations:  gateway.istio.io/controller-version: 5
API Version:  gateway.networking.k8s.io/v1
Kind:         Gateway
Metadata:
  Creation Timestamp:  2024-04-09T19:51:02Z
  Generation:          1
  Resource Version:    19077219
  UID:                 66461034-3cfa-4485-81c9-6f3b0d33975e
Spec:
  Gateway Class Name:  istio
  Listeners:
    Allowed Routes:
      Kinds:
        Group:  gateway.networking.k8s.io
        Kind:   TCPRoute
      Namespaces:
        From:  Same
    Name:      tcp-31400
    Port:      31400
    Protocol:  TCP
Status:
  Addresses:
    Type:   Hostname
    Value:  a7917d408dd9948d5980f02740bda264-581318275.eu-central-1.elb.amazonaws.com
  Conditions:
    Last Transition Time:  2024-04-09T19:51:03Z
    Message:               Resource accepted
    Observed Generation:   1
    Reason:                Accepted
    Status:                True
    Type:                  Accepted
    Last Transition Time:  2024-04-09T19:51:06Z
    Message:               Resource programmed, assigned to service(s) tcp-echo-gateway-istio.istio-io-tcp-traffic-shifting.svc.cluster.local:31400
    Observed Generation:   1
    Reason:                Programmed
    Status:                True
    Type:                  Programmed
  Listeners:
    Attached Routes:  0
    Conditions:
      Last Transition Time:  2024-04-09T19:51:03Z
      Message:               No errors found
      Observed Generation:   1
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-04-09T19:51:03Z
      Message:               No errors found
      Observed Generation:   1
      Reason:                NoConflicts
      Status:                False
      Type:                  Conflicted
      Last Transition Time:  2024-04-09T19:51:03Z
      Message:               No errors found
      Observed Generation:   1
      Reason:                Programmed
      Status:                True
      Type:                  Programmed
      Last Transition Time:  2024-04-09T19:51:03Z
      Message:               No errors found
      Observed Generation:   1
      Reason:                ResolvedRefs
      Status:                True
      Type:                  ResolvedRefs
    Name:                    tcp-31400
    Supported Kinds:
      Group:  gateway.networking.k8s.io
      Kind:   TCPRoute
Events:       <none>

Name:         tcp-echo
Namespace:    istio-io-tcp-traffic-shifting
Labels:       <none>
Annotations:  <none>
API Version:  gateway.networking.k8s.io/v1alpha2
Kind:         TCPRoute
Metadata:
  Creation Timestamp:  2024-04-09T19:51:03Z
  Generation:          2
  Resource Version:    19077935
  UID:                 8d237bfb-73a9-404e-9094-6ab75540c71b
Spec:
  Parent Refs:
    Group:         gateway.networking.k8s.io
    Kind:          Gateway
    Name:          tcp-echo-gateway
    Section Name:  tcp-31400
  Rules:
    Backend Refs:
      Group:
      Kind:    Service
      Name:    tcp-echo-v1
      Port:    9000
      Weight:  80
      Group:
      Kind:    Service
      Name:    tcp-echo-v2
      Port:    9000
      Weight:  20
Events:        <none>

Version
Istio (via Helm):
base-1.21.1
istiod-1.21.1

Kubectl:
Client Version: v1.28.4
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.6-eks-508b6b3

Helm:
v3.12.2+g1e210a2

Additional Information
No response

Did you install with PILOT_ENABLE_ALPHA_GATEWAY_API=true?

I thought so but it seems I haven't set this option. Might have confused it with a similiar settings for cert-manager. After settings this option it works fine now.
So HTTPRoute with Kubernetes gateway already works out of the box but TCPRoute needs the additional option right?
I will close the issue as this was not a bug but incorrect installation/configuration from my sid.e


Improvements

improve tests

Current coverage is 49.17% (diff: 100%)

Merging #14 into master will increase coverage by 8.48%

@@             master        #14   diff @@
==========================================
  Files            63         63
  Lines          1096       1096
  Methods           0          0
  Messages          0          0
  Branches         87         87
==========================================
+ Hits            446        539    +93
+ Misses          617        517   -100
- Partials         33         40     +7

Powered by Codecov. Last update 9ed3b28...30ca9b0


CollisionPair

The current implementation of CollisionPair inverts the index to have them in logical order. It is not very convenient.
A user who wants to read the distance results to get the closest points has no way to know that the indexes have been inverted and that the closest points have to be inverted.
I seems this is used only to ensure that there is no duplicates in the list. If this is the case, I see two options:

option A : the user must remember whether the indexes have been inverted,
option B: add an operator== to CollisionPair which handle inverted pairs.

I'm in favour of option B because I do not like the fact that the inversion of collision pairs is done in the back of the user.

Just  to be clear, I sum up your proposition B:
You want to suppress the forced ordering and have any ordering. And add an operator== which takes into account the two situations. Isn't it?
I also suggests to add a method to sort all collision pairs by first index value for example. Just to be efficient in the when calling algorithms.

I mean this:
ColPairA == ColPairB <=> (ColPairA.first == ColPairB.first && ColPairA.second == ColPairB.second) || (ColPairA.first == ColPairB.second && ColPairA.second == ColPairB.first) ||
About the method to sort, I agree. But I think the method should not be called automatically. Or, at least, ahoud be such that the user can disable sorting the pairs.

I can do a pull-request with option B.

Let's do that !

Solved by #255.
Maybe we still need to check the Python interface.


Option to choose custom selxCompiledLibraryComponents.h

Let users write their own selxCompiledLibraryComponents.h to fully customize which components will be compiled into SuperElastix. Useful for speeding up development.
Currently the Debug build consumes too much memory on Windows (due to 32 bit build chain). This option creates a temporary solution for this too.
Follow-up on #71

became PR #186


"apidump --out" creates empty folder / no har file?

I'm trying to use akita apidump with --out to a local folder. The out folder gets created but is empty. I've tried both on MacOS and Linux, both built from source and with the official binary (mentioned in the docs) and got the same result. Am I doing anything wrong?
Results received:
Empty out folder, no .har file.
Expected:
.har file gets created in the out dir.
Example:
Before: out dir doesn't exist:
$ ls -a
.  ..

running as user root:
$ akita apidump -c 'curl -I -L https://api.github.com/users/torvalds/events/public' -u root --out ./dumpdir
[INFO] Running learn mode on interfaces lo, ens18, cni-podman0
[WARNING] --filter flag is not set, this means that:
[WARNING]   - all network traffic is treated as your API traffic
[WARNING]   - outbound witness collection is disabled
[INFO] Running subcommand...

======= _AKITA_SUBCOMMAND_ =======
======= _AKITA_SUBCOMMAND_ =======
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0  299k    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
HTTP/2 200
server: GitHub.com
<...>

======= _AKITA_SUBCOMMAND_ =======
======= _AKITA_SUBCOMMAND_ =======
[INFO] Subcommand finished successfully, stopping trace collection...
[INFO] Success! 🎉

After: out dir got created but is empty:
$ ls -a
.  ..  dumpdir
ls -a dumpdir/
.  ..

Sorry for the noise. I was mistaken that apidump should work both for in- and outbound traffic. Dumping inbound traffic works fine. #close

Hi, Christian. I think there are a couple things going on here, and the tool could be clearer about the results (or lack thereof).
apidump will work for outbound traffic as well if you include a filter; you can do --filter "port 443" or --filter "port 80"
However, because the connection is encrypted with HTTPS, the tool cannot see which URLs are being accessed.  A combination that worked for me is:
sudo bin/akita apidump -c 'curl -I -L http://api.github.com/users/torvalds/events/public' --out ./dumpdir -u root --filter "port 80"
But it is not very interesting because all it shows is the redirection to HTTPS.

hi @mgritter,
ah, thanks a lot, now it makes sense.
Just hacked together a little proxy server (really bad code, but just to try) that listens on unencrypted http and translates http:// urls to https:// urls while proxying. Now I seem to be able to do:
$ jetis
starting proxy server on localhost:8888 ...

and
sudo akita apidump -c 'curl --proxy http://localhost:8888 http://api.github.com/users/torvalds/events/public' --out . -u root --filter "port 8888"

and I'm getting a 400 KB .har file with promising content. 🎉
(Maybe as a feature idea ... a built-in proxy in akira apidump might be useful, so you don't have to hook up another proxy tool like charles to record outgoing requests?)


Docsreview

Opening this draft so we easily compare changes across branches.

docs/API/overview.md and docs/API/images.md have some phrasing that I found a bit confusing and not sure if I understand it enough to rewrite it myself. @LouisDesdoigts :))

Closing so a new PR can be opened by @maxecharles so I can approve!


Swing state displaying in white / no background

See example below - Maine displaying w/o background color

AHA Good catch. This happens when a state is split-vote and leading.


License headers are missing in the forgetme.sh

Description:
License headers are missing in the forgetme.sh tool in the latest pack.
Affected Product Version:
wso2am-2.1.0-update13

Fixed with https://github.com/wso2/product-apim/pull/2952


DateFilter

A date filter using DatePicker component.

can set maxDate, minDate and timezone
can create a range filter with range() method

Hey, thank you for the contribution, but let's keep this in a plugin. I think that it might even be a plugin already. The implementation of such a filter is just too subjective for an official feature IMO


When double-clicking on a message, search for the first viewable stackframe

Begin search at the top of the callstack. If the top fails to open, try the next one, etc.
This avoids the problem where you double-click on a message, the first stack frame is in glue code (like DebugHandler.Internal_Log), where source code is not available. With this in place, the default configuration of UberLogger makes double clicking on a message jump straight to the Debug.Log line which produced the message.

I have included a second fix in this PR because it touched the same lines of code:
Do not attempt to open source if filename is null
Sometimes the stack walk will be unable to resolve an address. This results in a stackframe with FileName == null and LineNumber == 0. Do not attempt to open the source for those frames.

Hmm, wait -- I have changed double-click behaviour for the Editor window but not for the App window. I will look into changing this for the App window as well.


file: Should AddBatch insert at the correct position?

ACH Version: v1.6.2
What were you trying to do?
When calling AddBatch(..) the Batch being added is currently appended to the end of the file. This works for some use-cases but also means fields like the BatchNumber and TraceNumbers need to be valid within the contents of that file.
What did you expect to see?
AddBatch(..) should create valid files wherever possible.
What did you see?
AddBatch(..) creates an invalid file.

I don't think we would want to add that responsibility to AddBatch(..). The caller should call Create() after calling AddBatch() to transform the file into a valid state.


CIP-???? | X509 RBAC Registration (1/5) - Metadata Envelope

This is a draft PR for a standard to create an Envelope to secure Auxiliary Data and a Transaction to prevent replayability of a transaction's Auxiliary data and for an attempt to replay the data to be detectable off chain.
It is the first in a series of PR's detailing a x509 based Role-Based Access Control (RBAC) registration scheme for a dApp on Cardano.

(latest version in branch)

Per @rphair point about the multiple submitted documents...
It would seem that proposals #1-4 all define (together) the standard and several, if not all of them, do not work when isolated out of scope and context of the larger payload. These should all be rolled together into a singular submission and proposal.
Proposal #5 seems to be specific to Project Catalyst implementation of this standard so may make sense to be separate.
However, in that case, this will create a precedent similar to what we've seen with CIP-67/68 where we end up needing a registry/repository entry as well as the standard definition and this should be considered and defined within the scope of the standard before progressing these.

yes @Crypto2099 that's why I didn't speed ahead with the format reviews & at tonight's meeting we might confirm the need to combine these into 1 or 2 proposals; although @stevenj in the meantime I have had to take care of this issue, to speed up the introductory review at the CIP meeting:

👉 Comparing them side by side is difficult while digging the READMEs out of your branches & we shouldn't have to work off of personal bookmarks.  Can you please add a link in your first comment above to each of these which points to either the current README.md file or directory (as we suggested in CIP-0001 that authors do for any proposal)?

... it's always a nice touch with authors take care of this 🙏 https://github.com/cardano-foundation/CIPs/blob/master/CIP-0001/README.md#1a-authors-open-a-pull-request

Note In the original comment for your pull request, please include a link to the README.md for the CIP in your working branch, so readers and reviewers can easily follow your work. If this link changes (e.g. from the CIP directory being renamed), please keep this link updated.

BTW @Ryun1 @Crypto2099 I should modify this language I added to CIP-0001 which isn't always correct... in some cases, as in these where there are asset files, it makes more sense to link to the containing directory than to the README.md.

@rphair I believe that even linking directly to the README.md file is sufficient as assets should usually use relative links to the .md file in most cases and should correctly populate in the "rendered" version so that is probably a minor point that's not worth introducing the additional complexity to concern ourselves with and we can handle on a case-by-case basis of PR's, particularly those that may be longer lived due to a lot of back/forth?

@stevenj I'll follow the pattern of using this PR as a container for the others that were submitted concurrently.
At the CIP Editors' Meeting tonight we confirmed the feeling that combining the ones currently numbered 1 through 4 would produce a document without unnecessary cross references to explain different parts of the same system.  It might be different if any of these interdependent pieces could have applications in future CIPs, but it doesn't seem that way after a quick review by @Crypto2099 & me because the components all seem uniquely mated to each other.
There could conversely be a strong argument for keeping number 5 separate if it would be used more frequently by Catalyst designers to contain a "registry" that needed to be updated often... and therefore should be in a separate CIP from the description of the main X509 RBAC scheme.
In any case please consider rewriting as such as this material comes out of "draft" and @stevenj please post if you have any strong feelings to the contrary.  Considering the work is all currently on separate branches it would be best to resolve this question early in the editorial process... and to keep this review history I would support merging the content for at least proposals 2/4 through 4/4 into this branch.  (cc @Ryun1)

Hi @rphair We are in the process of implementing initial versions of theses CIPs to validate the approach.
After that process has completed, we will edit the Cips to incorporate any changes found to be necessary and also to take into account the feedback given so far.
Currently, they should be considered draft, and I can make the PR's draft if thats preferable.

thanks for the update  @stevenj - yes it's preferable from the repository view, and sounds appropriate based both on your progress, to mark the whole set as Draft for now.


Three Services Section

Looks great on standard desktop, tablet, and mobile (nice work on the alignment); however if you scale a desktop window down, you end up with this left alignment look that is a bit awkward. Any way we can improve that?

Alignment is correct now; however, the bottom of the icons get cut off on Tablet resolution


I need to use the cooccurance of words, how to check the cooccurance of the words?

@RoderickGu Hello! Have you got the cooccurance matrix?

I did not get that. Sorry
On Tue, Dec 10, 2019 at 5:28 AM heslowen<EMAIL_ADDRESS>wrote:

@RoderickGu https://github.com/RoderickGu Hello! Have you got the
cooccurance matrix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stanfordnlp/GloVe/issues/145?email_source=notifications&email_token=AKRMVV7M47GFONFUZ5B5VEDQX6KRFA5CNFSM4H23DF42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGPHD3I#issuecomment-564031981,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRMVV42V66O4KZVHAPHE73QX6KRFANCNFSM4H23DF4Q
.


Final scores in percentage when leaving the game

After entering the exit door, the percentage of the solved elements should be shown. E.g if we have 10 molecules, and the student finished 5 of them, the ratio should be accessible to track in the resulting scene.

The percentage is not visible in the game , however it is accessible through the game manager.
Also you can add the tracking in the Game manager => ExitSimulation() where you just track the int playerProgress.

Okay, I guess it is public float playerProgress;?

Yes but it is an int.


Better conversion between torch.Tensor and ffi.cdata in lua binding.

RT

Close as these changes is included in #63 .


Error on updating extension

When I want to update the brackets extension from the extension manager I am getting the following error:

What windows do you have?

It's not Windows, it's Deepin Linux (Ubuntu Trusty based distribution).

I don't have Linux but maybe @mackenza can help here.

@p4bl1t0 what extension were you updating?

Brackets-Git

it's actually worse than that. I cannot install an extension on Linux either. I think it has to do with the temp folder the zip file is being downloaded to. I am looking into this.

should be addressed by #14

@p4bl1t0 can you test this again and confirm/close?

It's working properly. Things that I tested:

Update an extension
Add a new extension
Delete one extension

The changes preserve also after closing and reopening Brackets


base_url + suggestion

It would be nice if each sitemap link was on it's own line.  Since it's gzipped anyways, doesn't really add anything to the file size.
also, there's a bug with using :base_url instead of  :url_options, I think the code is looking for @path_url or something instead.
thanks for a great project!

Indents and newlines are now included in 0.8.5.


Add alpha package manager install instructions to v4 docs

This question seems to come up often enough in the chatrooms to possibly warrant it.
For example, should
bower install bootstrap

be changed to
bower install bootstrap#{{site.current_version}}

Merged #17576.


Building for x86_64-unknown-linux-gnu on Windows host fails on Rust 1.50

After upgrading to Rust 1.50, I can no longer build for Linux from a Windows host.
It looks like Cross tries to run the Linux toolchain under Windows and then fails because of some conflict with the documentation:
$ cargo init crosstest
     Created binary (application) package
$ cd crosstest/
$ winpty cross build --target x86_64-unknown-linux-gnu
warning: toolchain '1.50-x86_64-unknown-linux-gnu' may not be able to run on this system.
warning: If you meant to build software to target that platform, perhaps try `rustup target add x86_64-unknown-linux-gnu` instead?
info: syncing channel updates for '1.50-x86_64-unknown-linux-gnu'
info: latest update on 2021-02-11, rust version 1.50.0 (cb75ad5db 2021-02-10)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: using up to 500.0 MiB of RAM to unpack components
info: installing component 'clippy'
info: installing component 'rust-docs'
info: rolling back changes
error: failed to install component: 'rust-docs-x86_64-unknown-linux-gnu', detected conflict: '"share/doc/rust/html/std/keyword.self.html"'
error: couldn't install toolchain `1.50-x86_64-unknown-linux-gnu`
caused by: `"rustup" "toolchain" "add" "1.50-x86_64-unknown-linux-gnu"` failed with exit code: Some(1)
note: run with `RUST_BACKTRACE=1` for a backtrace

That looks like it does not start a Docker container, and tries to install the tools on the host machine.
In Rust 1.49, it works:
$ rustup default 1.49
info: using existing install for '1.49-x86_64-pc-windows-msvc'
info: default toolchain set to '1.49-x86_64-pc-windows-msvc'

  1.49-x86_64-pc-windows-msvc unchanged - rustc 1.49.0 (e1884a8e3 2020-12-29)

$ winpty cross build --target x86_64-unknown-linux-gnu
   Compiling crosstest v0.1.0 (/project)
    Finished dev [unoptimized + debuginfo] target(s) in 14.22s

(I'm running MSYS2, where the winpty command is required to run Cross with Docker. On the failed command it wasn't needed because it didn't use Docker in the first place.)

A workaround is to set the minimal profile before building:
rustup set profile minimal
Then rustup won't try to install documentation, and will not fail at that step. Still strange that this changed between 1.49 and 1.50, but it may not be a bug in Cross. #533 seems to be the same.

but it may not be a bug in Cross

I don't think it is, but a workaround may be necessary in cross (if that's even possible).
Relevant rustup comment: https://github.com/rust-lang/rustup/issues/2661#issuecomment-783717159

Hi, wearing a rustup-maintainer hat I would argue this is a bug in cross: since cross knows it is doing a generally unusal thing (installing toolchains that cannot work on the host, and doing so solely for automation), cross should override the profile on the toolchain install request to rustup - always installing new toolchains with the minimal profile. This will make cross faster, use less network resources, and avoid this conflict.

This also happens to me on Windows for embedded (thumb*) builds. @vilcans solution fixed it.

I think the problem is caused by these lines of code:
https://github.com/rust-embedded/cross/blob/3d4004cf62de81c0bb9fffcae045cbeed449211d/src/rustc.rs#L61-L65
As @rbtcollins said, if the toolchain being used on the host is not *-x86_64-unknown-linux-gnu, cross will try to download one, and then bind the corresponding sysroot directory into the docker container.
https://github.com/rust-embedded/cross/blob/efb6e591e43a29965fbb6b924c4ad0e8ce37164d/src/docker.rs#L191

This should be fixed as of e05540fbf329a446aa4cab47ced9269c3273f640. Please let me know if the issue still reproduces: I've tested this fairly regularly on other hosts (for example, x86_64-pc-windows-msvc)  so I don't believe this is still relevant.


the Deploy folder name is should  lower-case

we need follow a general convention to adjust the project layout. the lower-case is fine in linux culture. please consider it. thanks a lot.

Thanks for the suggestion.  But we intentionally name it with a upper-case letter to inform user it's not a go package.

Docker project use https://github.com/docker/docker/tree/master/contrib as folder name. you can consider it.

+1

This is no longer valid as we don't have deploy folder anymore.


unparse with comments: source_range: undefined method location

Getting this error when trying out unparser with comments:
/Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser/comments.rb:108:in `source_range': undefined method `location' for [s(:lvasgn, :x, (NoMethodError)
  s(:send,
    s(:lvar, :x), :+,
    s(:int, 1))), [#<Parser::Source::Comment (string):2:1 "# This is a comment">]]:Array
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser/comments.rb:19:in `source_range'
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser/comments.rb:82:in `take_before'
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser/generation.rb:70:in `emit_comments_before'
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser/generation.rb:45:in `with_comments'
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser/generation.rb:15:in `write_to_buffer'
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser.rb:68:in `block in unparse'
	from <internal:kernel>:90:in `tap'
	from /Users/neilongkingco/.rbenv/versions/3.0.1/lib/ruby/gems/3.0.0/gems/unparser-0.6.7/lib/unparser.rb:63:in `unparse'
	from /Users/neilongkingco/src/ruby/parser/parser_test.rb:17:in `<main>'

RUBY_VERSION 3.0.1
Gem versions:
    diff-lcs (1.5.0)
    parser (<IP_ADDRESS>)
      ast (~> 2.4.1)
    unparser (0.6.7)
      diff-lcs (~> 1.3)
      parser (>= 3.2.0)

Source:

require 'parser'
require 'parser/current'
require 'unparser'

puts "Parser"
ast = Unparser.parse_with_comments(
"
# This is a comment
x = x + 1
")
puts ast

puts "Unparser"
#has problems with parse_with_comments
puts Unparser.unparse(ast)

@neil-ongkingco-apollo thanks for the report.
I have got very limited time for OSS work, outside of the features I need. Comment reproduction is not a feature I need currently. So I'd be very happy you could try to do a patch here.
Otherwise be prepared this will take a while.

Found the problem, I wasn't passing the comments on. Fixed it by doing this:
ast, comments = Unparser.parse_with_comments
...
Unparser.unparse(ast, comments)

Planning to do some rewriting of jbuilders to plain ruby. I think unparser will make that a lot easier.

k, thx.


Migrate TFEstimator to ray train

Thanks @KepingYan. I'll merge this. The failed CI is unrelated to this PR.


Tried in UE5, receives Error message

I have tried to use in Unreal Engine 5. The problem is that I receive this error message:
LogOSC: Warning: Failed to parse OSCBundle of invalid format. #bundle identifier not first item in packet.

Sorry, it's not yet compatible with UE5.
Thank you for reporting.

I solved the issue. Thank you,


append new line after dashes in mriqc_run help text

One more time with feeling.

Let's remove the dashes. Don't bother about them :+1:


ScrollBarHelper.VerticalScrollBarOnLeftSide brake horizontal scrollbar

Using this line of code in TreeView
controls:ScrollBarHelper.VerticalScrollBarOnLeftSide="True"

leads to broken horizontal scrollbar like on the screenshot below

When deleting this code, everything works correctly:

fixed with c0c94fb39cc4d8892f260af462d026655042fb01


Forge import hybrid jar RuntimeException: Namespace mismatch, expected srg got intermediary

A fabric + forge hybrid jar import by gradle will cause wrong namespace since there is AW in jar but not srg namespace

Those jars are not supported by the Architectury toolchain. An AW in the wrong namespace, even if it's in a Forge jar, is going to crash.
To be more specific, mods used as dependencies on Forge should not contain fabric.mod.json files as Loom is going to process Fabric-specific contents such as access wideners in the Forge context.


[ADLA - ADLS] - Object refactor

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

Can you show us an example of the difference between the JSON result before and after the change?

Please fix the CI as well.

 The new return types have fewer properties. It may break user script. Please make sure it is what you expect.

JobInformationBasic
  {
    "degreeOfParallelism": 1,
    "endTime": "2017-09-20T19:14:46.906304+00:00",
    "jobId": "10b69fb7-839d-46d4-a3dc-a1f87a16400e",
    "logFilePatterns": null,
    "logFolder": null,
    "name": "testJob",
    "priority": 1000,
    "related": {
      "pipelineId": null,
      "pipelineName": null,
      "pipelineUri": null,
      "recurrenceId": null,
      "recurrenceName": null,
      "runId": null
    },
    "result": "Failed",
    "startTime": null,
    "state": "Ended",
    "submitTime": "2017-09-20T19:14:41.249992+00:00",
    "submitter"<EMAIL_ADDRESS>    "type": "USql",
    "tags": {}
  }

JobInformation
  {
    "degreeOfParallelism": 1,
    "endTime": "2017-09-20T19:14:46.906304+00:00",
    "errorMessage": null,
    "jobId": "10b69fb7-839d-46d4-a3dc-a1f87a16400e",
    "logFilePatterns": null,
    "logFolder": null,
    "name": "testJob",
    "priority": 1000,
    "properties": null,
    "related": {
      "pipelineId": null,
      "pipelineName": null,
      "pipelineUri": null,
      "recurrenceId": null,
      "recurrenceName": null,
      "runId": null
    },
    "result": "Failed",
    "startTime": null,
    "state": "Ended",
    "stateAuditRecords": null,
    "submitTime": "2017-09-20T19:14:41.249992+00:00",
    "submitter"<EMAIL_ADDRESS>    "type": "USql",
    "tags": {}
  }

@troydai Yes, this is expected.  For these three LIST operations, the properties that are now left out in "Basic" were not returned by the service due to performance.  So while this is technically a breaking change, it should not have a significant impact because those fields were null in the first place.


[QUERY] Copy source authorization from access key

Query/Question
In Put Blob From URL we're able to specify a copy source authorization, for example a bearer token based on Azure AD (see #29083).
But it is not clear how we might instead provide a signature derived from an account key, one reason being that the "x-ms-date" header is not known in advance.
Why is this not a Bug or a feature Request?
It's unclear at this time whether this is a question/query or a feature request.

Hi @malthe thanks for reaching out to us via this GitHub issue.  @jaschrep-msft could you please follow up?  Thanks

Hi @malthe ,
Thank you for reaching out. In regards to your question, unfortunately we only support AAD for Put Blob from From Url, so it would not be possible to get the x-ms-date from the shared access key.
You can find more information here
Let us know if this helped and if you have any more questions.
Thanks!


XOutput causes dosbox to lose mouse input.

So I discovered a weird phenomenon, when I have Xoutput running and I am using dosbox at the same time Xoutput will cause dosbox to lose all mouse functionality a few minuets into gameplay. After this the only way to get it back is to exit and reenter fullscreen on dosbox.

I have the same issue, the game cannot get the mouse input after I started the XOutput virtual controller.


Pagination on ListView

Is it possible to enable pagination on ListView? When I have more than ~50 images - opening a folders takes a lot of time and sometimes I get timeouts.

Hm this shouldn't be part of the driver itself, I guess this is handled by the FAL. The driver is build against the the AbstractHierarchicalFilesystemDriver which doesn't offer any possibility to do something with paging. Normally this should work. I will have a look into it anyway! :)

I guess I've found a solution to speed thinks up! Currently I'm fetching the complete blob, even for lookups. I will change this behavior in the next update, that only the meta data is fetched! I think this will speed up thinks massively - at least  I hope so 😄

Thank you! Will be great!

I'm working on a new release, hopefully I will bring it online later this day. I was able to achieve a good increase performance wise and paging should also work then. 😃

@zbychu555 please ty out Version 0.3.1 and let me know if It's better now! :)

Wow! Thank you for really fast and good job! When I open folder first time it's still long time, but pagination works great (so time is shorter than before:))
But what can I see, there are no folders in ListView in right area, I can see only images.

Hi @zbychu555, sorry for the late response. Do you still have the problem? Unfortunatley I'm not able to reproduce this Problem. 😕

I've found the problem, it's related to the processed folder and the limit of 5.000 files per call to the storage API. I will investigate the problem.

Version 0.3.3 partially fixes the problem I guess - please have a look at the patch notes for detailed Informationen regarding this issue. :-)

Hi, sorry for really log silence from my side... I can see 'folders in folder' but not main folders which are in my root. But it's not big issue in my opinion :)

Just to be clear about that. With you can't see folders inside your root folder, means you can't see the folders "Documents", "Images" and "user_upload" like in the example?

Yes, I cannot see this folders.

Since which version do you use the extension? I'm asking, because in one of the first versions, there was a change which had impact on the file/folderidentifier hash.

I have the latest master commit (b36023e). This is strange because I see that it works for you :)

As I remember it was my pull request which changed hashes:) I think it's no a problem for me, because I started using Azure after this change.

Hmmm :confused:  ... I'm sorry, for the moment, I've no idea.

Thanks a lot for your work on this issue. I'm so happy that pagination works - missing 'root' folders in my installation don't be a big issue in this case :)


Remote temp file prefix

Requirements
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Mark the following tasks as done:

[x] Checked the codebase to ensure that your feature doesn't already exist.
[x] Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
[ ] Adjusted the Documentation.
[x] Added tests to ensure against regression.

Description of the Change
Added a remote_prefix option to the temporary file configuration.

Why Should This Be Added?
When storing the temp files on a remote server such as S3, it can be useful to specify a prefix for the temp files (ie. tmp/) so that lifecycle rules can be applied to periodically clean up files with a common prefix.

Benefits

Possible Drawbacks

Verification Process
I'm using this on my app to apply a tmp/ prefix to my files. My temp files now show up under a tmp directory in my S3 bucket, and I'm able to apply lifecycle rules to expire the temp files after 24 hours.

Applicable Issues

Thanks for this addition, can you also add a test and add some docs about this, thanks

@tooblue any update on this?

@patrickbrouwers sorry, been busy! I should be able to get to it later this week. :)

Running into this issue as well when queueing a job.
@patrickbrouwers Can you please tag merged as 3.1.18?

@tooblue the tests are failing, can you have a look at that?

@patrickbrouwers not sure why it was failing before, but it's passing now after I restarted the build. 👌


feat(traces): rework trace creation

Overview
Depends on https://github.com/celestiaorg/celestia-node/pull/2468
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2476 (cf206c1) into main (11dced4) will decrease coverage by 0.34%.
The diff coverage is 4.87%.

@@            Coverage Diff             @@
##             main    #2476      +/-   ##
==========================================
- Coverage   52.88%   52.55%   -0.34%
==========================================
  Files         156      156
  Lines        9971     9998      +27
==========================================
- Hits         5273     5254      -19
- Misses       4236     4279      +43
- Partials      462      465       +3

Impacted Files
Coverage Δ

cmd/celestia/util.go
56.52% <ø> (-5.02%)
:arrow_down:

cmd/celestia/version.go
0.00% <0.00%> (ø)

nodebuilder/settings.go
45.68% <5.71%> (-18.60%)
:arrow_down:

... and 7 files with indirect coverage changes


Documentation related to need for pre-processing of comment (text).

Do we need to pre-process comment?, remove @username, remove html formatting, remove intentional repetitions, non sentence chars ecc. Specification related to how the text should be pre-processed (if needed) seems missing

Thanks, I'll update the docs. Comments are assumed to be utf8 raw text of the comment/text to be checked. Emoji and other non-ascii characters can be included. Raw HTML will probably result in lower performance.

Updated the docs:
https://github.com/conversationai/perspectiveapi/commit/d941486dd50fdb1eb35110217ef0787e9ca54639


Editor > Suggest: Insert Mode setting seems forced to 'replace'

Describe what happened:
From the guest/participant side, selecting an autocomplete suggestion with the cursor in the middle of a line adds the selection but overwrites characters to the right of the cursor. On the host side, behaviour is as expected for the same action (insertion without overwriting).
What was your system configuration?
Product and Version: VSCode
OS Version: Host: Windows 10, Guest: macOS Big Sur (not tested with other platform combinations)
Live Share Extension Version: 1.0.3577
Target Platform or Language: JS (Node), also seen with ActionScript - seems unimportant
Steps to Reproduce / Scenario:

Open a workspace as host (tested from Windows 10) and start a LiveShare collaboration session.
Join the session using the collaboration link (tested from macOS Big Sur).
Check that host and guest settings (user, workspace, folder) all have the setting Editor > Suggest: Insert Mode left at insert.
With a file (e.g. JavaScript) open as the participant/guest, position the cursor in the middle of a line, but at the end of a known symbol, and activate autocomplete by typing a . (dot).
Select a suggestion with the return key.
Observe that the suggest appears but instead of being inserted cleanly, it overwrites characters (and not always the entire symbol to the right).

Please attach logs to this issue:
ls.zip
Screenshots

@smvanderweide we're probably not appropriately capturing this setting in our LSP messages. Could you have a look?

Thanks for reporting this @admvx. We will take a look at why this is happening.

Apologies for the delay here. We’ve made improvements in this area since this issue was filed. We believe this may have improved your experience and are closing this issue. If this issue still persists for you, please reopen the issue and let us know. Thank you.


SAA-1009 prep work to support cancellation of attendances on reciept of a prisoner being received back into prison.

The changes in this PR are in preparation for the cancellation of (suspended) attendance records on the receipt of a prisoner be received back into prison event.
Part two will be changing the event to utilise the changes in this PR.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (18779e3) 84.55% compared to head (997c7e1) 84.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #466      +/-   ##
============================================
- Coverage     84.55%   84.55%   -0.01%
- Complexity     2211     2212       +1
============================================
  Files           290      290
  Lines          8313     8312       -1
  Branches        503      502       -1
============================================
- Hits           7029     7028       -1
  Misses         1025     1025
  Partials        259      259

Impacted Files
Coverage Δ

.../hmppsactivitiesmanagementapi/entity/Attendance.kt
91.60% <100.00%> (-0.71%)
:arrow_down:

...ctivitiesmanagementapi/entity/ScheduledInstance.kt
91.93% <100.00%> (+1.93%)
:arrow_up:

...smanagementapi/service/ScheduledInstanceService.kt
87.80% <100.00%> (-1.09%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


by country

top-10 and bottom-10,

exclude countries that don't a have two-letter code
the changes and all-time top 10s are the same

color-gradient fix, to spread out colors

Froom #36,

[ ] dislpay men and women added total added as well as the currently existing percentage figue.

[ ] under changes section: hover-over should say "change in wigi" instead of "wigi"


Add .env support

[x] Following CODE_OF_CONDUCT.md.
[x] Checked for duplicate enhancements.
[x] Title is a summary of the enhancement request, in present tense, and ideally < 50 characters

Enhancement
This is useful for every project I know of.
Notes:

Include item in .gitignore file
Include .env.example file (is this the convention?)
Include items in documentation for developers to alter the .env file
Import manually within source files, or force the import via CLI scripts?

:tada: This issue has been resolved in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Implement the array interface to cupy.ndarray

http://docs.scipy.org/doc/numpy-1.10.0/reference/arrays.interface.html

We close this issue, since supporting the NumPy array interface is problematic in some situations (it makes some codes silently copies arrays over CPU/GPU).


BUG: creating network creates ghost copies of each node

I've discovered what looks to be a bug in the to_graph algorithm.
The number of nodes in the graph resulting from to_graph is double the number of nodes pulled by get_network.  Furthermore, exactly half the nodes in the graph have no geometry attribute (which is how I found the problem).
I have not yet checked whether it always does this, or whether it is a byproduct of one of the options I'm using.
I also haven't checked whether the edges are also doubled.
thisAreaData = pyrosm.OSM('../Data/OSMData/kanto-latest.osm.pbf', bounding_box=thisBoundingPolygon)
nodes, edges = thisAreaData.get_network(nodes=True, network_type="walking")
print("numNodes1:", len(nodes))   ##---> 104,950
thisWalkingGraph = thisAreaData.to_graph(nodes, edges, graph_type="networkx", osmnx_compatible=False, retain_all=True)
print("numNodes2:", walkingNetwork.number_of_nodes())    ##---> 209,900

@bramson Thanks for reporting this! I actually one time popped into this one, but forget about it.
This behavior is a bit weird and it relates to building networkx graph. I haven't seen similar happening with igraph or pandana (haven't done a proper check though). For some reason, networkx doubles the number of nodes in the graph when it is constructed. 🤔 Need to investigate more..

@bramson Would you happen to have a clipped PBF file of the region that produces this bug? I don't seem to be able to reproduce this behavior so it's a bit difficult to debug.. 🤔 Parsing the networkx graph from Tokyo at least works as I would assume.

Ha, now I was able to reproduce. It seems to happen when using osmnx_compatible=False.

@bramson Okay, found the issue. You can get it fixed by installing from master, once all the tests have passed and the merge is ready.


Fix: ansi-color-names-vector: vector -> vconcat

ansi-color expects this type of vector ["color1" "color2" "color3" ...]
(vector sequence) returns [(seq uen ce)] while
(vconcat (sequence)) returns [seq uen ce]

Good catch, thanks!


onClickOutside ignored when a button is clicked.

In this React-Redux search app the filter box is wrapped by OnClickOutside.

In general it works well. But when a different Filter Button is clicked it's filter box opens as well, and the onClickOutside is ignored.

This is an undesired result. When there is a click outside, even on such a button, we'd like for the onClickOutside handler to be executed.
There is no event.stopPropogation set on the filter button. We use onClickOutside with it's default settings.
Any suggestions? Please let me know if you need more info. I can also add the map to the live site, so u can see the source code in the browser.

I think the best way is to add a dedicated URL for this purpose, which will include the search page plus the map file. This way you can view in Chrome dev tools both relevant components - the FilterBtn component, and the filter's DecisionBox component. Does this work for you?

Honestly I'd rather have a real PoC, so something with maybe two components, of which the filter component is used several times, and shows off this interplay with exactly the minimum amount of code, stripped from any surrounding website-specific code like other components, libraries, CSS, etc. Trying to modify a running React application on an active site is not a good way to do debugging.
Just copy the site to a new dir, remove anything that isn't the main container and the filters, remove all the CSS except CSS critical for the menu placement, replace any text with generic placeholders that are just long enough to give visually understandable content, etc.
Basically if you're running into this, that minimizing exercise helps you figure out if this is you, or if this is the library. That should be sortable with a minimal example that I would be surprised surpasses 50 lines of code.

I made a siginficant effort to create a minimal version. I removed most libraries, all of Redux, and all other components. With deployment it took about 2 hours.
https://bug-demo.firebaseapp.com/
I use a method called "atomic-design", which means the components structure is very modulare. And the CSS style is within the components, so removing the CSS from the components themselves will require lots of time. Hope you understand.

I used emotion-react to create styled components. The problem was that styled component of the filter btn, was created within the functional component of the FilterButton. Which basically means that everytime the FilterButton was rendered an new instance was created in the dom. After removing that
StyledComponent out of the function, and just refering to it in the returned JSX the problem was solved.

Good to hear you found it. And good to hear the mcve exercise helped reveal it.

Sorry to disappoint, but It was not the MCVE. I looked at the filterBtn for a different reason, and noticed the problematic structure.


Add nominee: Juniper

Automatic addition of a new nominee submitted through the online form available at https://digitalpublicgoods.net/submission

Closing in favor of #172


Kotlin Multiplatform support

I might be wrong, but i think the only thing stopping this project to be usable in KMM is the fact that processor_annotations module is based on kotlin jvm instead of being common kotlin. Processor module can stay jvm, since it is running only on dev machine (but i might be totally mistaken here). Is there anything that is forcing this module to be jvm bound? I think supporting KMM would be an another major advantage over the MapStruct

The only stop signal here is that I have not tested it with KMM yet. Also it implies that it should be supported in the future.
In general I agree that it's something that should be tested and enabled if possible so I'll try to do that. Contribution here is welcome as well :).


Adding a list of users to share power app with

"You can share an app with a list of aliases, friendly names, or a combination of those (for example, Meghan Holmes<EMAIL_ADDRESS>if the items are separated by semicolons. "
In an attempt to register multiple users at once it does not work as described.
I attempted to use this partial list<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>without the double quotes. Perhaps you can expand your example to include multiple users at once, like described.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 55c12582-519a-606c-1f2e-8fe1f6ac5d2a
Version Independent ID: 537b3097-4aa4-f3e5-b252-ffb832ecb1dc
Content: Share a canvas app with your organization - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/share-app.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @alaug
Microsoft Alias: alaug

Thanks for your comment, @shinyion. This issue has been assigned to the doc author for review.

Thanks for your comment, @shinyion. This issue has been assigned to the doc author for review.


Add static web app routing config

Routing works correctly in the environment deployed as part of this PR.


Code style policy changes

The purpose if this issue is to open discussion about changing coding style - https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/Documentation/coding-style.md
Currently we only ask contributors to follow the coding style, yet we do not have any rules on whether or not a code can be accepted if it violates the coding style.
The current code base uses different code styles and a lot of code violates many rules of the current style.
I think we should define both - the rules we want (as the current rule set is not sufficient) as well as the policy about how this is or is not enforced - i.e. which rules are required and which are only recommended.
This issue is for StratisBitcoinFullNode project only at this moment, and once we converge to something here, other projects are welcome to follow the outcome as well.
Besides the rules and the policies on their enforcement, we should also define the decision process of which rules will be applied should contributors disagree on some (i.e. who is the boss if any, are there any vetos, or is this just majority voting?).
PROPOSING RULE (NEW OR CHANGE): If you want to propose a new rule, or change the text of the current rule, please start your comment starting with RULE PROPOSAL and use three sections: DEFINITION - in this first part just write the rule as you would like to see it; RATIONALE - try to explain why you think this is a good idea to have; POLICY - explain what kind of policy you would like to have on this rule (i.e. would you like it to have only as a general guideline/recommendation, or strictly enforced - i.e. not accepting new code violating it?).

Indeed the policy is if you are working on some part of the code that they styling is different then bring them in line.
Code should not be accepted if it violates the code-style but it wasn't an iron rule (for various reasons).
My take on adding optional and strict on some of the rules seem fine, some contributors are used to other styling from other projects and we can make it easy to contribute by not staying too strict

Do you think someone would actually have a problem if in the PR review the reviewer would say "here and here, please fix the style according to code style"? I've seen you already do that in the review process, and I think it is the right think to do - you have a code style for a reason. For example, I have 2 space indentation by default in MSVS, but I changed that to 4 to comply with the project code style. I can't imagine it would be acceptable if I started submitting code with 2 spaces. It would just create messy code.

RULE PROPOSAL
Properties should be written on a single line unless having a non-trivial getter or setter.
Examples:
public int X { get; set; }
public int X { get; private set; }
public BlockPuller Puller { get { return this.puller; } }
public BlockPuller Puller => this.puller;
RATIONALE
Class (auto)properties are currently written in all different kinds of forms and it looks very inconsistent in the code. We do have probably all possible variants in the code from the above mentioned one liners to
       public bool Whitelisted         {             get; set;         }
or
      public bool Whitelisted         {             get;             set;         }
or
      public bool Whitelisted         {             get             {                  return this.whitelisted;             }         }
POLICY
Soft / general guideline

RULE PROPOSAL
Properties with trivial or automatic getters and setters should be written on a single line . Trivial means return x; or x = value;.
Examples:
public int X { get; set; }
public int X { get; private set; }
public BlockPuller Puller { get { return this.puller; } }
public BlockPuller Puller => this.puller;
RATIONALE
Class (auto)properties are currently written in all different kinds of forms and it looks very inconsistent in the code. We do have probably all possible variants in the code from the above mentioned one liners to
        public bool Whitelisted
        {
            get; set;
        }

or
        public bool Whitelisted
        {
            get;
            internal set;
        }

or
        public bool Whitelisted
        {
            get
            {
                 return this.whitelisted;
            }
        }

POLICY
Strict / Hard

RULE PROPOSAL
Use PascalCase for Constants.
Examples:
public const bool DefaultEnableReplacement = true;
private const int SomeNumber = 1;
RATIONALE
This can be found in the current code base:
			this.EnableReplacement = config.GetOrDefault("mempoolreplacement", MempoolValidator.DefaultEnableReplacement);
			this.MaxOrphanTx = config.GetOrDefault("maxorphantx", MempoolOrphans.DEFAULT_MAX_ORPHAN_TRANSACTIONS);

There seem to be no difference between kinds of those two constants, so why to write them in different style?
POLICY
Strict / Hard

from our coding style guide:
12. We use PascalCasing to name all our constant local variables and fields.

tx, i missed that, i deleted that proposal

Single line getters and setters is fine with me do you want to add it to the styling guideline and also add the example? (we might need to update the current example so you can just take the BlockPuller)

I also think this is actually ok
        public bool Whitelisted
        {
            get
            {
                 return this.whitelisted;
            }
        }

The point of this issue is to avoid changing the code style guideline every so often. Rather to give it some time here to come with new rules and then make the change at once.
As for
 public int MaxItems { get; set; } = 100000;

I'm OK to forbid that. But as @bokobza gave a thumbs up on the original proposal that allows this, let him have a say before I edit the proposal.
As for
        public bool Whitelisted
        {
            get
            {
                 return this.whitelisted;
            }
        }

this seems longwinded and actually the proposed rule forbids it in favor of these:
public BlockPuller Puller { get { return this.puller; } }
public BlockPuller Puller => this.puller;

yeah I don't like  public int MaxItems { get; set; } = 100000; either. When you debug, unless all the properties are at the top (where they should be really), your debugger jumps up and down. I no like.
This one is my favorite: public BlockPuller Puller { get { return this.puller; } }
I'm not used to this yet: public BlockPuller Puller => this.puller;
But I'm fine with either way.

Cheers, proposal upgraded to forbid that initialization.

RULE PROPOSAL
Parentheses in expressions are mandatory except for simple terms, such as x, x.field, or x.Method() etc., where they are forbidden. Multiple parentheses around a single expression are also forbidden.
Examples:
if ((x.Value > 5) && y && z.Eval() && ((a + b) > c))
bool q = (x.Value > 5) && y && z.Eval() && ((a + b) > c);
bool q = z.Eval();
return x == 1;
Forbidden:
if (x.Value > 5 && y)
if ((x.Value > 5) && (y))
if ((x.Value > 5) && (z.Eval()))
if (((x.Value > 5)))
if (y && a + b > c)
if (y && (a + b > c))
if (y && (a + b) > c)
bool q = (x.Value > 5);
bool q = (y);
bool q = (z.Eval());
return (x == 1);
return (x) == 1;
return x == (1);
RATIONALE
Use of parentheses that are not required by the language are valuable because they capture intent of the developer. Otherwise it is hard to distinguish whether the developer is just ignorant of the operator priority or if the code works as intended. In some (rare) cases of refactoring, not using all parentheses could change the code behavior silently.
POLICY
Strict / Hard

Agree on this.

RULE PROPOSAL
Interfaces must start with an "I".
RATIONAL
It's the common practice and this way the code is more homogeneous.
POLICY
HARD

@bokobza: I'd probably add to that rule that we have "-Async" suffix for async methods and "-Locked" suffix for methods that require the caller to hold one or more locks. For async the rationale is the same. For locks it is great prevention of bugs.

agree with these.
Also "[typename]Extensions" for extensions methods.
What about convention for abstract classes? I vote for not using "-Base" but rather having a name that describe the object properly, like Vehicle or Shape.

Yes for Extensions.
I actually use -Base, I don't see any cons with it. Maybe we are not that much different here. You probably want Triangle: Shape, where I would very much agree with Shape, except it would be ShapeBase or ShapesBase

RULE PROPOSAL
Make test method names more readable
RATIONAL
Currently methods names are not so readable.
I propose to change any name to have an '_' between words
This is less readable
        [Fact]
        public void WalletCanReceiveAndSendCorrectly()
        {

This is more readable
        [Fact]
        public void Wallet_Can_Receive_And_Send_Correctly()
        {

Additionally we may want to start adding the 'Given – When – Then' syntax to each method.
Example:
 [Fact]
        public void Given_a_valid_wallet_When_a_trannsaction_is_created_Then_it_can_send_and_Receive()
        {

POLICY
HARD
@Neurosploit thoughts?

@dangershony In testing guidelines, we currently have this:

The test method name follows the following structure: {MethodName}{GivenContext}{ExpectedOutcome}. Example for a method called Query: QueryWithoutInitializedRepositoryThrowsException.

I think many tests are not complying with this. I tried to comply with that creating this test method
AssignBlocksToPeersWithNodesWithDifferentChainsCorrectlyDistributesDownloadTasks
and I don't think it is more readable if you add _ after every word there. However, I think the best format here would be {MethodName}_{GivenContext}_{ExpectedOutcome}, which would make this method
AssignBlocksToPeers_WithNodesWithDifferentChains_CorrectlyDistributesDownloadTasks
which is probably best. I think it is better than AssignBlocksToPeersWithNodesWithDifferentChainsCorrectlyDistributesDownloadTasks as it ads separations between the logical parts of the name and it is better than Assign_Blocks_To_Peers_With_Nodes_With_Different_Chains_Correctly_Distributes_Download_Tasks exactly for the very same reason - the separation here has not separated the logical parts.
So I suggest that existing guideline to be changed to {MethodName}_{GivenContext}_{ExpectedOutcome} instead of what you suggested.

Testing some readable scenarios:
Option 1:

Assign_Blocks_To_Peers_With_Nodes_With_Different_Chains_Correctly_Distributes_Download_Tasks

Option 2:

AssignBlocksToPeers_WithNodesWithDifferentChains_CorrectlyDistributesDownloadTasks

Option 3:

Assign_Blocks_To_Peers__With_Nodes_With_Different_Chains__Correctly_Distributes_Download_Tasks

Option 4:

Given__we_assign_blocks_to_peers__When__nodes_are_in_different_chains__Then__correctly_distribute_download_tasks

Option 5:

Given_AssignBlocksToPeers_When_NodesWithDifferentChains_Then_CorrectlyDistributesDownloadTasks

The most important thing is that the test method is instantly encapsulates its purpose and is very easy t o read (considering we will have a lot of tests)

My favorites are 2 or 5.

I agree with option 2 or 5. Preferring option 2.

2 for me as well, second place also 5.

My opinion here is that option 4 is most readable:

Given__we_assign_blocks_to_peers__When__nodes_are_in_different_chains__Then__correctly_distribute_download_tasks

I think tests methods should not be neat but very easy to read and quickly convey the story of the test.
If a test has more context option 2 becomes also hard to read:

AssignInvalidBlocksToSlowDownloadingPeers_WithNodesWithDifferentChains_CorrectlyDistributesDownloadTasks

Given__we_assign_invalid_blocks_to_slow_downloading_peers__When__the_nodes_have_different_chains__Then__correctly_distributes_the_download_tasks

[Given]xxx[When]xxx[Then] adheres to BDD style of testing, I am going to discuss with the product managers if they want it we go with 5 else, I see a preference with option 2.

I see [Given]xxx[When]xxx[Then] as problematic because if I open Test Explorer in MSVS, I see all tests and if I am looking for a specific test there (which is quite often), having the method name being the first thing there is the key. If the first thing there is "Given__" followed by unpredictable sentence (looking for a test I don't really know what should follow by Given) I won't be able to find it.
So if you want to go with 4 or 5, then please consider 6 first:

AssignInvalidBlocks_Given__we_assign_blocks_to_peers__When__nodes_are_in_different_chains__Then__correctly_distribute_download_tasks

i.e. {MethodName}_[Given]xxx[When]xxx[Then]xxx

Interesting, putting the [key] first (method name being the key).
I like that very much actually, you get a proper separation by key in the explorer and still keep the test story.
I will try this with the FundTrasnaction tests I am currently writing and we can see if it feels right.

Yes, but in my opinion tests should be commented just as any other code (see that AssignBlocksToPeersWithNodesWithDifferentChainsCorrectlyDistributesDownloadTasks example). I don't think that trying to put all the description into the test name is useful (if comments are there).
So I'd rather see less descriptive test method names and comments for tests describing the scenarios. The current test code base we have is hugely lacking comments of the tests.

It might even make sense to have module first {Module/Component Name}{MethodName}... for even better navigation in the test explorer.

Thinking of this, many people here liked option 2:

AssignBlocksToPeers_WithNodesWithDifferentChains_CorrectlyDistributesDownloadTasks

but that also suffers from not having Module/Component name in the first place, so in fact in test explorer, you are still kind of lost, unless you remember which module implements which methods
So let's say option 7

PullerDownloadAssignments_AssignBlocksToPeers_WithNodesWithDifferentChains_CorrectlyDistributesDownloadTasks

The names of these methods are getting out of hand in my opinion.
How about adding categories/module to the tests as traits?
We can already filter by namespace, class, traits and even search by name from within the test explorer, I don't think we need other visual clues.

OK, that's true, possibly this long list of all tests is maybe not that important

Come on I didn't say the list is not important, I said we can make it as navigable without having to resort to longer names.

No I mean I agreed with you and possibly changed my mind about the naming - I was previously not using the search, now trying it seems good enough to find the tests you are looking for, so that seems like satisfying my primary requirements.

Cool then. Sorry mate, it's hard to see if someone is speaking frankly or being sarcastic online 😸

Normally we don't put descriptions on tests, so that's why putting description on the method name is more important.
Apparently there are different ways and many discussions https://stackoverflow.com/questions/155436/unit-test-naming-best-practices
We need to decide on one way.

@bokobza no worries :) but yes, no sarcasm was meant
@dangershony and I think that is a mistake "not to put descriptions on tests", the very same arguments for commenting your code applies here - describe what you intend to do, so that someone can check that you implemented it right

hi @detroitpro would you like to make a recommendation?

These look good to me. One suggestion if you don't want to have too many rules is to have a blanket statement something along the lines of "Unless explicitly mentioned in these rules please use the .NET core library style." That way you don't have to have a rule for every little thing.
BTW I'm not sure if you guys have seen this but here is some of MS rules https://github.com/aspnet/Home/wiki/Engineering-guidelines#coding-guidelines

Those ASP.NET MS rules are terrible for me and I think so they are for @dangershony because they very much contradict to what this project had before I even joined :-)
So I'm OK to have the ruleset based on external template, but certainly not that one :-)

Yeah I am very much against many of the asp.net rules.
But I might adopt their test naming policy (or lack of policy)

Unit test method names must be descriptive about what is being tested, under what conditions, and what the expectations are. Pascal casing and underscores can be used to improve readability. The following test names are correct:
PublicApiArgumentsShouldHaveNotNullAnnotation
Public_api_arguments_should_have_not_null_annotation

https://github.com/aspnet/Home/wiki/Engineering-guidelines#unit-test-method-naming
perhaps the that's a good approach we dont restrict test method name and allow anything that makes sense as long as the test method name is descriptive and readable.
Also rule 6 of the guidelines seems a nice one to adopt

Use any language features available to you (expression-bodied members, throw expressions, tuples, etc.) as long as they make for readable, manageable code.
This is pretty bad: public (int, string) GetData(string filter) => (Data.Status, Data.GetWithFilter(filter ?? throw new ArgumentNullException(nameof(filter))));

https://github.com/aspnet/Home/wiki/Engineering-guidelines#coding-style-guidelines--general

On the rule 6 you've mentioned, I'd be much happier if the logic was inverse there:

Don't use language features available to you (...) unless they make for readable, manageable code.

Happy with not having strict rules on the tests methods names, as long as it's descriptive enough as in the rule above.


[RESEARCH] Image Upload - content moderation tradeoffs

Users are asking for direct image upload. I need to do research and understand what the liability / tradeoffs are.

covered off in other tickets


Rule Normalization and Refactoring

As described here: https://github.com/openraven/magpie/wiki/Proposal-for-changes-to-policies-and-rules.  It's probably best to create the new repo (cspm-kb) and move rules and policies into this as they are refactored.

@stefansjfw  https://github.com/openraven/cspm-kb is ready to go!

Already done.


Change '--multus-conf-file=auto' to multus default install method

This change fixes #313, change 'multus-conf-file=auto' as multus
default install method. Flannel deployment yaml goes to NPWG's
reference-deployment repo as following.
https://github.com/K8sNetworkPlumbingWG/reference-deployment

Pull Request Test Coverage Report for Build 768

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.373%

Totals

Change from base Build 762:
0.0%

Covered Lines:
655

Relevant Lines:
1275

💛  - Coveralls

closed due to dupped.


.help is not working on Windows

.help Usage command is not working on the Windows platform.

This is because we were checking against \n which is not correct.
So now we are checking if the EOL is a New Line Feed or a Carriage Return using ASCII values.
This is going to solve the issue for Windows

Git Bash on windows:

Windows PowerShell:

Ubuntu 20.04 on wsl2:

Marking this issue closed and deleting related branch


Review and overhaul docs (placeholder)

Complexity: 1
See the discussion in Sprint Poker #29
Powered by Parabol

Impact: 4
See the discussion in Sprint Poker #30
Powered by Parabol

Urgency: 3
See the discussion in Sprint Poker #30
Powered by Parabol

No relevant/unspecific, closing


Memory measurement on OpenBSD

Memory info isn't being displayed correctly, i.e.:

Memory: -180MB / MB

I see that neofetch relies on dmesg to get the total memory, in my case, it's not possible because dmesg output gets filled by errors (on my system, at least) and 'real mem' can't be found there.
Another thing is that free mem is not what it seems, the memory part of top -d 1 (taken from neofetch) in my system is:

Memory: Real: 1078M/1735M act/tot Free: 252M Cache: 397M Swap: 57M/2295M

From this line, 252M it's not obviously the free memory.
My suggestion is to gather the total memory from the output of that line; and should be, in this case: 1735M + 252M, and get the free memory by substracting the result of the previous sum with 1078M.

I've booted up an OpenBSD VM and I'm working on this now, thanks for opening the issue.

I see that you're also getting a buggy output with CPU and Uptime, I want to also fix these issue for you.
What's the output of these commands?
sysctl -n hw.model
sysctl -n kern.boottime

sysctl -n hw.model

Intel(R) Pentium(R) 4 CPU 2.80GHz ("GenuineIntel" 686-class)

sysctl -n kern.boottime

1458597577

Thanks!
Does this command below work on your system? What it does is print the 3 numbers we'll be doing math on in a single line so that I can add them to an array.
top -d 1 | awk -F ':  |/| |M' '/Memory:/ {printf $4 " " $6 " " $11 "\n"}'

# Output in my VM:
17 83 1892

Yes! That's the one:
top -d 1 | awk -F ':  |/| |M' '/Memory:/ {printf $4 " " $6 " " $11 "\n"}'

1007 1675 312

Memory output should work now, try out https://github.com/dylanaraps/neofetch/pull/179.

Yes, it works now!

Are you having any other issues with the script while we're on the topic of OpenBSD support?

No, everything is being displayed correctly.

Awesome! :+1:
I'll merge the PR once the uptime changes have been tested on OS X.


Add changes on the floating arrow

add the possibility to display or not the floating button
add click on the floating action button to skip all pages si needed

Merged to master... Thanks for your contribution


refactor: use core grpc

I think the recent upgrade to gax 1.x borked master, I think this should fix it.

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Thanks @callmehiphop, the changes look good to me!


Chapter 7 JSON body error.

In JSON body from: self.sender.to_owned() should be from: self.sender_as_ref().to_owned().
Credit to /u/Azdle on /r/rust for the fix.

Thanks, fixed 😁

Thanks, fixed 😁


auto-gen docs of flex

What do these changes do?

Auto-gen the docs of flex and remove the pre-built html files. Due to the reduction of dependencies at build time (e.g. using cmake for flex), a new Doxygen file was created, namely Doxygen-flex.
Related issue number
#2726

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Shen Sijie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.