PipelineRun is canceled prior to its child TaskRuns being canceled.

Expected Behavior
If a PipelineRun is cancelled during execution, the PipelineRun should be marked as terminal status by pipelinerun reconciler after all its child TaskRuns have been cancelled successfully by taskrun reconciler. To users, this means that

PipelineRun completion time should be greater than its child TaskRuns completion time.
The final PipelineRun update should be emitted after all its child TaskRuns' final updates are emitted.

Actual Behavior

Final PipelineRun update is emitted before child taskruns are emitted.

Steps to Reproduce the Problem

patch this commit that adds logs into controller
Run this pipelinerun

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: tekton-pr
spec:
  pipelineSpec:
    tasks:
      - name: t1
        taskSpec:
          steps:
            - image: busybox
              script: |
                sleep 600

Cancel the PipelineRun by applying this modified yaml.

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: tekton-pr
spec:
  status: "Cancelled"
  pipelineSpec:
    tasks:
      - name: t1
        taskSpec:
          steps:
            - image: busybox
              script: |
                sleep 600

Check the pipeline controller log, you will see the log that shows that the terminal pipelinerun is emitted first and has smaller completion time (searching >>> emitting).

{"severity":"warn","timestamp":"2024-06-06T15:49:43.749Z","logger":"tekton-pipelines-controller","caller":"pipelinerun/pipelinerun.go:253","message":">>> emitting pipelinerun, name: tekton-pr, completion time: 2024-06-06 15:49:43.749423811 +0000 UTC m=+87.911781253, condition status: False, condition ltt: {2024-06-06 15:49:43.749422032 +0000 UTC m=+87.911779516}","commit":"9760223-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"5bb03973-86fb-42e4-b1f6-858ef01876fe","knative.dev/key":"default/tekton-pr"}
{"severity":"warn","timestamp":"2024-06-06T15:49:43.749Z","logger":"tekton-pipelines-controller","caller":"taskrun/taskrun.go:777","message":"stopping task run \"tekton-pr-t1\" because of \"TaskRunCancelled\"","commit":"9760223-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"090e81e8-7394-4ddc-8d15-4551931c8abd","knative.dev/key":"default/tekton-pr-t1"}
{"severity":"info","timestamp":"2024-06-06T15:49:43.749Z","logger":"tekton-pipelines-controller.event-broadcaster","caller":"record/event.go:364","message":"Event(v1.ObjectReference{Kind:\"PipelineRun\", Namespace:\"default\", Name:\"tekton-pr\", UID:\"32b2ce33-3cb2-4502-9165-fcf4457e7375\", APIVersion:\"tekton.dev/v1\", ResourceVersion:\"169834134\", FieldPath:\"\"}): type: 'Warning' reason: 'Failed' PipelineRun \"tekton-pr\" was cancelled","commit":"9760223-dirty"}
{"severity":"warn","timestamp":"2024-06-06T15:49:43.768Z","logger":"tekton-pipelines-controller","caller":"taskrun/taskrun.go:166","message":">>> emitting taskrun, name: tekton-pr-t1, completion time: 2024-06-06 15:49:43.749754967 +0000 UTC m=+87.912112418, condition status: False, condition ltt: {2024-06-06 15:49:43.74975262 +0000 UTC m=+87.912110080}","commit":"9760223-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"090e81e8-7394-4ddc-8d15-4551931c8abd","knative.dev/key":"default/tekton-pr-t1"}

Additional Info

Kubernetes version:
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:41:01Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"28", GitVersion:"v1.28.9-gke.1000000", GitCommit:"21b78d6e66a8659125f752293620ab9b2ed9bd7b", GitTreeState:"clean", BuildDate:"2024-04-17T09:14:21Z", GoVersion:"go1.21.9 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.23) and server (1.28) exceeds the supported minor version skew of +/-1

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

latest main

It looks like Tekton intends to mark PR as canceled after all its child TRs are marked as canceled successfully (code source).
However, taskrun reconciler needs a bit time to reconcile to mark child TR as canceled and to emit the final update after pipelinerun reconciler patches the tr. Since pipelinerun reconciler cancels the PipelineRun and emits it immediately after patching the taskruns, the pr is emitted prior to tr being emitted and has earlier completion time.

Looked into the log a bit more. It looks like the parent pipelinerun was canceled twice and thus 2 terminal pipelinerun events were emitted (first line and last line in the following log). Both 2 events reported pipelinerun with condition status==false meaning it's done, which is confusing.
{"severity":"warn","timestamp":"2024-06-07T00:02:46.271Z","logger":"tekton-pipelines-controller","caller":"pipelinerun/pipelinerun.go:253","message":">>>> emitting pipelinerun, name: tekton-pr-emit-ha, completion time: 2024-06-07 00:02:46.271534506 +0000 UTC m=+113.976747118, condition status: False, condition ltt: {2024-06-07 00:02:46.271533558 +0000 UTC m=+113.976746181}","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"3501b088-0278-43ac-b67c-e25e44298096","knative.dev/key":"default/tekton-pr-emit-ha"}
{"severity":"info","timestamp":"2024-06-07T00:02:46.271Z","logger":"tekton-pipelines-controller.event-broadcaster","caller":"record/event.go:364","message":"Event(v1.ObjectReference{Kind:\"PipelineRun\", Namespace:\"default\", Name:\"tekton-pr-emit-ha\", UID:\"e96bb31f-a06b-46f9-b3a1-a74a50360d04\", APIVersion:\"tekton.dev/v1\", ResourceVersion:\"170179062\", FieldPath:\"\"}): type: 'Warning' reason: 'Failed' PipelineRun \"tekton-pr-emit-ha\" was cancelled","commit":"edf7e90-dirty"}
{"severity":"warn","timestamp":"2024-06-07T00:02:46.286Z","logger":"tekton-pipelines-controller","caller":"taskrun/taskrun.go:166","message":">>>> emitting taskrun, name: tekton-pr-emit-ha-matrix-task-ha, completion time: 2024-06-07 00:02:46.271505564 +0000 UTC m=+113.976718177, condition status: False, condition ltt: {2024-06-07 00:02:46.271493449 +0000 UTC m=+113.976706071}","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"e0a1fea5-640b-40ec-a647-984ee0248077","knative.dev/key":"default/tekton-pr-emit-ha-matrix-task-ha"}
{"severity":"info","timestamp":"2024-06-07T00:02:46.288Z","logger":"tekton-pipelines-controller.event-broadcaster","caller":"record/event.go:364","message":"Event(v1.ObjectReference{Kind:\"TaskRun\", Namespace:\"default\", Name:\"tekton-pr-emit-ha-matrix-task-ha\", UID:\"941e7a91-c8b3-400c-b29c-56f79237057f\", APIVersion:\"tekton.dev/v1\", ResourceVersion:\"170179063\", FieldPath:\"\"}): type: 'Warning' reason: 'Failed' TaskRun \"tekton-pr-emit-ha-matrix-task-ha\" was cancelled. TaskRun cancelled as the PipelineRun it belongs to has been cancelled.","commit":"edf7e90-dirty"}
{"severity":"info","timestamp":"2024-06-07T00:02:46.296Z","logger":"tekton-pipelines-controller","caller":"controller/controller.go:550","message":"Reconcile succeeded","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"3501b088-0278-43ac-b67c-e25e44298096","knative.dev/key":"default/tekton-pr-emit-ha","duration":0.047430652}
{"severity":"info","timestamp":"2024-06-07T00:02:46.296Z","logger":"tekton-pipelines-controller","caller":"pipelinerun/cancel.go:139","message":"cancelling TaskRun tekton-pr-emit-ha-matrix-task-ha","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"47592fa6-3a06-4274-b05e-58d33303fc21","knative.dev/key":"default/tekton-pr-emit-ha"}
{"severity":"info","timestamp":"2024-06-07T00:02:46.311Z","logger":"tekton-pipelines-controller","caller":"controller/controller.go:550","message":"Reconcile succeeded","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"e0a1fea5-640b-40ec-a647-984ee0248077","knative.dev/key":"default/tekton-pr-emit-ha-matrix-task-ha","duration":0.040763412}
{"severity":"info","timestamp":"2024-06-07T00:02:46.312Z","logger":"tekton-pipelines-controller","caller":"taskrun/taskrun.go:149","message":"taskrun done : tekton-pr-emit-ha-matrix-task-ha \n","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"a65f95f4-9b47-40f6-9b0f-93f325712bca","knative.dev/key":"default/tekton-pr-emit-ha-matrix-task-ha"}
{"severity":"info","timestamp":"2024-06-07T00:02:46.312Z","logger":"tekton-pipelines-controller","caller":"controller/controller.go:550","message":"Reconcile succeeded","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"a65f95f4-9b47-40f6-9b0f-93f325712bca","knative.dev/key":"default/tekton-pr-emit-ha-matrix-task-ha","duration":0.000230135}
{"severity":"warn","timestamp":"2024-06-07T00:02:46.331Z","logger":"tekton-pipelines-controller","caller":"pipelinerun/pipelinerun.go:253","message":">>>> emitting pipelinerun, name: tekton-pr-emit-ha, completion time: 2024-06-07 00:02:46.331209788 +0000 UTC m=+114.036422401, condition status: False, condition ltt: {2024-06-07 00:02:46.331207784 +0000 UTC m=+114.036420413}","commit":"edf7e90-dirty","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.pipelinerun.Reconciler","knative.dev/kind":"tekton.dev.PipelineRun","knative.dev/traceid":"47592fa6-3a06-4274-b05e-58d33303fc21","knative.dev/key":"default/tekton-pr-emit-ha"}

/assign @renzodavid9

/assign me

/assign @renzodavid9

Hello there,
To elaborate on @chitrangpatel comment, this change will make PipelineRun cancellation asynchronous. With this, we would need the PipelineRun to enter a "Cancelling" state when cancellation is triggered and remain there until all child TaskRuns are cancelled, at which point it will mark itself as "Cancelled". We currently don't have such a "Cancelling" state, so we'll need to add it and make the transition as explained before. It would look something like:

When cancellation is triggered:

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: pipeline-execution
...
status:
  conditions:
  - lastTransitionTime: ...
    message: PipelineRun "pipeline-execution" is cancelling
    reason: Cancelling
    status: Unknown
    type: Succeeded

After all the PipelineRun child tasks stop, it will go to "Cancelled":

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: pipeline-execution
...
status:
  conditions:
  - lastTransitionTime: "2024-07-22T20:13:42Z"
    message: PipelineRun "pipeline-execution" was cancelled
    reason: Cancelled
    status: "False"
    type: Succeeded

I would like to validate this idea here to see if anyone have any thoughts about it @tektoncd/core-maintainers
Thanks!

I think I like the idea, but I wonder how impactful it might be for existing clients (and the change / addition of a new "reason"). I would think it might not be super breaking as the "end state" doesn't change, there is just going to be an "unknown" state, but we need to asses this. Otherwise, it makes sense to me.

Is it possible to add a condition in the annotation instead of adding the condition state Cancelling, similar to tekton.dev/canceling-state, so that it will not affect existing clients?

@chengjoey I'ld rather go with the Condition state. This is not "backward" incompatible per se, it's just that client might not know this state, but all other state they know are still there, so it shouldn't break them.


Proposal: TreeView selection changed event

Proposal: TreeView selection changed event
Summary
What is the right way to get notified when TreeView selection changed. Would it be possible to introduce something similar to the list view selection changed

Looks like we just neglected to add this event when bringing Selection-things to TreeView. Seems like a reasonable request, @predavid can you take a look?

@AlexeyBKuznetsov - Thanks for opening this feature request. This is certainly an issue we want to pursue as soon as we get done with the current investments in our Win3.0 roadmap : https://github.com/microsoft/microsoft-ui-xaml/issues/717.
Please do review the article and provide us your feedback.

I desperately need this feature. Any ETA?

Realistically we wouldn't get to this at least until the new year, but I think we would accept a contribution for either the API spec proposal and implementation. If you could propose an API we could help write up that API spec proposal and then we can tag this with "help wanted" to get some external help.

@japf thanks for this!

any word on this?

@beatnikthedan The API is currently in preview (available in WinUI preview versions like 2.5 previews). API spec (draft) here.


Dynamic DASH: sometimes it starts to play at the beginning of the availability window

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.0.4
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Tizen 4.0 (but it can happen on every platform/device)
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Full Model=UE32N5302
Firmware=T-KTSNDEUC-1292.1
(but it can happen on every platform/device)
What are the manifest and license server URIs?
Some Dynamic DASH

What did you do?
Play some Dynamic DASH.
What did you expect to happen?
It should start to play according to suggested/default presentation delay.
What actually happened?
Sometimes it starts to play at the beginning of the availability window.
You can see the following in the log:
16:02:56.047 main.9a313483.js:1 console: (audio:3) checking buffer length
16:02:56.051 main.9a313483.js:1 console: (audio:3) buffer behind okay because nothing buffered: presentationTime=50557.013000011444 bufferBehind=8
16:02:56.063 main.9a313483.js:1 console: (audio:3) appending media segment
16:02:56.095 main.9a313483.js:1 console: Segment downloaded: deltaTimeMs=330 numBytes=65536 lastTimeChosenMs=1593180175435 enabled=false
16:02:56.130 main.9a313483.js:1 console: Playhead before start & start is unbuffered
16:02:56.138 main.9a313483.js:1 console: Jumping forward 50523.81599998474 seconds to catch up with the seek range.

This looks related to #2748.


last.ckpt

Thank you for this inspiring work! I want to know which last.ckpt weight for VQGAN should be used in the Step3 of supervised prompt retrieval?

Hi sorry to bother you again. When conducting Step3 evaluation I find that each sample has only one grid sample. In evaluate_semgnetation.py each canvas fetched in line128 has 1 element in the 0-th dim.
I assume all training samples should be composed with each sample for the input grid of inpainting network, so that the performance can be sorted and used for following steps. I am not sure if I have any misunderstanding. Can you help me with this problem? Thank you!

evaluate_semgnetation.py

What do you mean "one grid sample"
"evaluate_semgnetation.py" is from which project?

Thank you for your reply. The problem is that when I conduct Step4 to get positive and negative samples, I find that the iou_dict is empty after deleting similarity of each sample itself (line41-line44 in get_positive_negative.py). So I suspect that there are some problems when running ./evlaluate/evaluate_segmentation.py in Step3, but I'm not very sure about that.

Moreover, L141 in ./evlaluate/evaluate_segmentation.py should generate at most 3 images for each idx. However I only get visualization with grid_idx 0 for each idx.

https://github.com/ZhangYuanhan-AI/visual_prompt_retrieval/blob/8c307493d4ac8f2b5652345b9004b21703eb9294/evaluate/pascal_dataloader.py#L100
You can get more grid by changing the value here

Is changing it to range(50) appropriate, or is this same to your original setting?

it should be one, if your in-context example is one image-label pair.

This is what I get when using the original code. Not sure if there is any problems.

can you check the "XXXtop50-similarity.json ?"

Sure. It seems have no problem.

So can you debug this part?

Looks fine

I've uploaded a full log.txt here https://drive.google.com/file/d/19Nq9QBqN2D0clF-0cvfneSn65aKcowXy/view?usp=sharing. If this data is fine then I have no clue why I can't get reasonable result from Step4.

Yes, but if it's one then by deleting self-similarity the iou_dict for each sample_idx is empty. In this way how to select pos/neg samples for training?

Any thoughts about why does iou_dict become empty?

Ok, I understand why.
In the repository located at https://github.com/ZhangYuanhan-AI/visual_prompt_retrieval/blob/seg_val2train/SupPR.md, there are two 'evaluation stages.'

During the first 'evaluation' stage, our goal is to obtain the Intersection over Union (IoU) related to the top 50 similar examples based on cosine similarity. Therefore, in the script at https://github.com/ZhangYuanhan-AI/visual_prompt_retrieval/blob/8c307493d4ac8f2b5652345b9004b21703eb9294/evaluate/pascal_dataloader.py#L100, we should set the number to 50.
In the second 'evaluation' stage, the aim is to obtain the IoU of the top 1 similar example, which utilizes a trained feature extractor. For this stage, the number should be set to 1.
Therefore, please ensure that the code is correctly adjusted according to the stage you are in.

Thank you!


Adding the 'register' template

Description

Creating a template and view for the register navigation of new users.
Connecting the landing page to redirect to the register page.
Connecting the navigation page to the owner / seeker creation form
Creating a minor test to check the response status.

Issues close by this PR
fix #130
Screenshots

Nice!


adding animation in the socialmedia icons in footer

want to add animation in the all social media icons in the footer

please assign me with the task @aslams2020

Hi @ritikm31 You can start working on it.
I got my account back today. Sorry for the inconvinience.

Ok I'll gonna work on it


Support find_by_name for Organizations

Currently, the person class supports find_by_name, but this is also available in the API for organizations. Please add support for that class as well.

Ah, sorry, this already exists. It looks like the gem just hasn't been updated. Could we get a new version of the gem?
Thanks!

I think it's resolved
We use finding organisations by term (this means also in other string fields)

So term searches beyond just the name? This would be good for some cases, but not if you are specifically searching by name.
Per my second comment, the code actually supports searching by name, a new release of the gem just hasn't been pushed since that change was made. Can you push a new version of the gem?

Yeah, term aims in different fields also.
This is gem which uses public API
there is no other way to query it according to:
https://developers.pipedrive.com/docs/api/v1/#!/Organizations/get_organizations_find

Ah, I see what you mean. The find_by_name method is actually implemented as a term search, regardless.
Perhaps I'm missing something, but I'm not seeing anything in the ruby code for how to do a term search for an organization. If you could point me to it, I'd appreciate it.
Per my previous messages, there is the following code which is labeled as find_by_name (which does the term search), but it is not part of the current version of the gem, and I was hoping you could release it as a new version.
https://github.com/amoniacou/pipedrive.rb/blob/master/lib/pipedrive/organization.rb#L9

oh true that, it's not released ; /
merged 3 years ago
we use
gem 'pipedrive.rb', git: 'https://github.com/amoniacou/pipedrive.rb.git'

@choosen Can you share example of find_by_name example for organization.

sorry , not in the project with pipedrive anymore. Cannot paste it

Unfortunately I don't have access to the project using pipedrive as well.


Crash during calendar initialization (ver. 6.0.1, Xcode 8.1)

calaccessd-2016-10-11-112832.crash.zip

Fixed, that line caused the issue:
 currentDate = calendar.date(byAdding: addingDateComponents, to: currentDate)!

cool


Give effect levitation 255 from XML don't work

As you can see: give effect levitation 255 from XML don't work.
Example:
_
KITS
 <kit name="take-levitation" force="true">       <potion duration="oo" amplifier="255">levitation</potion>     </kit>
REGIONS
    <apply kit="take-levitation">       <region name="levitation-bridge"/>     </apply>
_
Well, the result of that doesn't give me levitation 255, it gives me another type of levitation like 240 or something like that.

@esprimer In /effect, you specify an amplifier (amplifier 255 is effect lvl 256), in PGM, where you specify amplifier, you specify a level (amplifier 255 is effect lvl 255), what you are looking for is amplifier="256"

i'M sUrE It woRks On EPGm!!!!11111

Thanks @Pablete1234 sorry for that!


[Master Tracking] Create an Onboarding / New Expensify Training for Existing Users

Problem: We’re observing a lot of user confusion when existing users come into New Expensify. Most of them are just coming over to talk with Concierge, but they start clicking around and find themselves confused because it is different than Expensify Classic.
Solution: Provide existing users coming over with onboarding/training and the value-added of New Expensify.
The solution is still very much of a WIP. Given the predesign, we're likely going to bring a couple of different potential solutions to the team to explore and then go from there. But it will likely include some combination of:

Modal with text and/or video
Messaging from Concierge or in the workspace chat, maybe with an instructional video
Embedded tool tips to point the user to the features they need to explore

Predesign 1 is here. More updates to come.

Thanks for spinning this up @danielrvidal !

I don't think this is a bad idea:

let's just start with the MVP onboarding that explains how the system works overall, and then we can extend it with admin-specific (and other workflow-specific) onboarding later

Posted an update in the migrate channel here

Going to rename this one, as I keep losing it.

Conversation is ongoing, @dubielzyk-expensify is making mocks.

Going to spin up a design issue to keep track.

Added current solution to the design issue here

Design doc is being written and we're making daily progress.

Actively being worked on, there were a few outstanding quetsions on backwards compatibilities but largely good here.

Doc has been sent out, reviewing comments!

Doc is in detailed phase.

Doc is in detailed.

Whoops!

We are in the detailed, there were a few conversations impacting that, e.g. here

Detailed has been shipped, there is a discussion here I need to catch up with @danielrvidal about! https://expensify.slack.com/archives/C07NMDKEFMH/p1731431756356499?thread_ts=1731354813.312789&cid=C07NMDKEFMH

We are having a broader discussion about this here - https://expensify.slack.com/archives/C07HPDRELLD/p1732732935190809

This is in implementation so being worked on.

Being worked on here: https://github.com/Expensify/Expensify/issues/437980

@danielrvidal thoughts on closing this issue out and managing in that central project one?

@danielrvidal let me know what you think? As the updates seem to be happening and more centralised there, I think we can close this out and then handle follow up in separate GH issues but lmk if you disagree?

We are handling this in the central issue that is linked above, I've asked Daniel if he disagrees with closing and haven't heard back! So I'm just gonna take the step here and close this issue out and manage this in the central tracking issue for the main design doc.
@danielrvidal feel free to reopen if you disagree!

Sorry, I didn't see this until now but agree. Always feel free to hit me up in slack/DM!


Cannot find libclang error

When running the fifth code block in Evaluation_VulBERTa-MLP.ipynb, an error occured:
LibclangError: [WinError 126] 找不到指定的模块。. To provide a path to libclang use Config.set_library_path() or Config.set_library_file().
And then I find that "cidx = cindex.Index.create()" in class Mytokenizer is responsible for this error. Looks like clang cannot find libcland.dll.
Someone can help me? Thanks

The error might stem from a missing libclang library.
The easiest way to solve the libclang dependency problem is to install the libclang package instead of clang'. Because clangrequires you to manually install Clang LLVM compiler into your system, whereaslibclangwill provide you the library. So, try:  pip install libclang`

@hazimhanif
Thanks! I had solved this problem by installing Clang LLVM compiler into my Windows system, but there were some troubles when I tried to install Clang LLVM compiler into my Ubuntu.
Two hours ago I tried to install libclang and solved this problem in Ubuntu.
Thanks again!


Best approach to error message translation

Hi, we are using async-stripe on our rust server and i've been tasked with making it so all the possible error messages sent to the client be translated in another language. I was curious to know what the best approach would be and if that may even be something done directly onto the crate as a new feature.

Hmm, interesting question. The errors are hardcoded in english atm but that only affects the result of displaying them. You could conceivably match on the error type and provide your own translations but then you now have to punt along and translate all the serde erorrs (or provide a basic 'oops, can't serialize') as well as serde_qs, all of stripe's api errors, and finally the http client's errors which are deliberately left as a raw string since they are pluggable.
https://github.com/arlyon/async-stripe/blob/refactor/crates/crates/async_stripe_core/src/error.rs#L8-L23
I'm wondering if something like this would be good enough (pseudocode)?
trait ErrorMapper {
    fn map(err: StripeError) -> String;
}

struct JapaneseMapper;
impl ErrorMapper for JapaneseMapper {
    fn map(err: StripeError, lang: &ErrorMapper) -> String {
        match err {
            StripeError::Stripe(_) => "支払いプロバイダーの問題",
            StripeError::QueryStringSerialize(_) | StripeError::JsonSerialize(_) => "リクエストを作成できませんでした",
            ...
        }
    }
}

fn main() {
    let mapper = JapaneseMapper;
    client.do_request().map_err(mapper.map);
}

@arlyon
Would there be a way to make StripeError::Stripe give its ErrorCode and then map the codes to japanese and display them?
Like these guys:
    AccountCountryInvalidAddress,
    AccountInvalid,
    AccountNumberInvalid,
    AlipayUpgradeRequired,
    AmountTooLarge,
    AmountTooSmall,
    ApiKeyExpired,
    BalanceInsufficient,
    BankAccountExists,
    BankAccountUnusable,
    BankAccountUnverified,
    BitcoinUpgradeRequired,
    CardDeclined,
    ChargeAlreadyCaptured,
    ChargeAlreadyRefunded,
    ChargeDisputed,
    ChargeExpiredForCapture,
    CountryUnsupported,
    CouponExpired,
    CustomerMaxSubscriptions,
    EmailInvalid,
    ExpiredCard,
    IdempotencyKeyInUse,
    IncorrectAddress,
    IncorrectCvc,
    IncorrectNumber,
    IncorrectZip,
    InstantPayoutsUnsupported,
    InvalidCardType,
    InvalidChargeAmount,
    InvalidCvc,
    InvalidExpiryMonth,
    InvalidExpiryYear,
    InvalidNumber,
    InvalidSourceUsage,
    InvoiceNoCustomerLineItems,
    InvoiceNoSubscriptionLineItems,
    InvoiceNotEditable,
    InvoiceUpcomingNone,
    LivemodeMismatch,
    Missing,
    OrderCreationFailed,
    OrderRequiredSettings,
    OrderStatusInvalid,
    OrderUpstreamTimeout,
    OutOfInventory,
    ParameterInvalidEmpty,
    ParameterInvalidInteger,
    ParameterInvalidStringBlank,
    ParameterInvalidStringEmpty,
    ParameterMissing,
    ParameterUnknown,
    PaymentMethodUnactivated,
    PaymentIntentUnexpectedState,
    PayoutsNotAllowed,
    PlatformApiKeyExpired,
    PostalCodeInvalid,
    ProcessingError,
    ProductInactive,
    RateLimit,
    ResourceAlreadyExists,
    ResourceMissing,
    RoutingNumberInvalid,
    SecretKeyRequired,
    SepaUnsupportedAccount,
    ShippingCalculationFailed,
    SkuInactive,
    StateUnsupported,
    TaxIdInvalid,
    TaxesCalculationFailed,
    TestmodeChargesOnly,
    TlsVersionUnsupported,
    TokenAlreadyUsed,
    TokenInUse,
    TransfersNotAllowed,
    UpstreamOrderCreationFailed,
    UrlInvalid,```

I will look into this, sounds useful.


Check event logs until process start time

Test failure: https://github.com/aspnet/IISIntegration/issues/1194

It's not that test failure.

Test failure: https://github.com/aspnet/IISIntegration/issues/1346


[TEST] [Wait PR# 24 ] Add testing during packaging

Add run test during build.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #25. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ec2-54-180-96-14.ap-northeast-2.compute.amazonaws.com/.

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ec2-54-180-96-14.ap-northeast-2.compute.amazonaws.com/nntrainer/ci/repo-workers/pr-checker/25-202004031708310.24151992797852-c12a0f47da2db3400cbf7fd874e076c21ccbaa7d/.


docs: blog post on AI Lab recipes

What does this PR do?
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes https://github.com/containers/podman-desktop-internal/issues/342
How to test this PR?

[ ] Tests are covering the bug fix or the new feature

thanks @Firewall for your suggestions/corrections. I've applied them.


sortedlist 试两次

{ "hash": "0x39c767e230f1cc4d8fa7baa4ef8c39bc2e4add8680d09bfe086e1efdaa0d6437", "score": 290 }, // 10
{ "hash": "0x39c767e230f1cc4d8fa7baa4ef8c39bc2e4add8680d09bfe086e1efdaa0d6438", "score": 290 }, // 10

看那个先进

According to  current implementation, two items with the same score are sorted in order of insertion, from first to last. If the inserted item has the same score as the last one in list, the insertion will be considered invalid.

I updated the testcase to include insert two items which has same score. it will ranked by their insert order.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-rbac-auth

prow/e2e-suite-rbac-no_auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-rbac-auth

prow/e2e-suite-no_rbac-auth.sh
756d4a94128d7928ebdf7a59b637fc8a42fb4a06
link
/test e2e-suite-no_rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

it's fantastic we have an auto update - thanks ! (the bogus mixer tag was driving me crazy)
but ... will that loop not happen again ? what's the root cause ? can we detect said loops ?

the loop is related to the fact that we require admins to have follow the same guideline as normal users. This was not intented for the submit queue. in k8s they have few admins.

I disabled that check for now as it is preventing SQ to do its job.


DAG automatic layout

Tips

Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds checkstyle plugin.)
Brief change log
(for example:)

Add maven-checkstyle-plugin to root pom.xml

Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added dolphinscheduler-dao tests for end-to-end.
Added CronUtilsTest to verify the change.
Manually verified the change by testing locally.

Codecov Report

Merging #1497 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev   #1497   +/-   ##
=====================================
  Coverage   2.69%   2.69%
=====================================
  Files        271     271
  Lines      13596   13596
  Branches    2159    2159
=====================================
  Hits         367     367
  Misses     13212   13212
  Partials      17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81810f5...20e3592. Read the comment docs.

Hello, When calling API creation process, Incoming parameters locations and connects are empty, Will this automatic init be triggered ?


Copy files into a container

https://docs.podman.io/en/latest/_static/api.html#operation/PutContainerArchiveLibpod

Already implemented as Container::copy_to and Container::copy_file_into


Extracts zipkin-tests jar before we publish to o.a.z.zipkin2 namespace

This fixes an anti-pattern before we commit to it in the new namespace.

the following release command failed before I made this change.. not sure if this is the only change left or not..
$ VERSION=2.13.0 NEXT_VERSION=2.13.1-SNAPSHOT GPG_TTY=$(tty) ./mvnw release:prepare -Papache-release  --batch-mode -nsu -DreleaseVersion=$VERSION -Dtag=v$VERSION -DdevelopmentVersion=$NEXT_VERSION -Darguments="-Dmaven.test.skip=true" -DpushChanges=false -DautoVersionSubmodules=true

yep the release command works after this.


Visitor tracking via custom activities

According to the Engage team, current tracking does not track visits to single-page applications properly. Tracking can be implemented by when you use custom activities. I've added the tracking code, a sample custom activity call and a tutorial that allows you to try how the tracking works.

I will make the review.

Review:
@iamlucie
Please use project guid of the sample application that is stored in Client.js (975bf280-fd91-488c-994c-2f04416e5ee3) to be consistent with the deliver API.
I would be awesome to extract sample logging calls to separate module from Header.js. Ideally does not log anything until user does not set the code name of the activity for the users who does want to just install sample and take a look how does it look like without activity feature.
Testing:
Works as expected.

@Simply007 Thanks for the review. Don't you know whether there's some best practice in React or JS in general to separate the logging calls?

To see changes, check the first and the last commit. The other two are there because I was confused whether I am pulling the updates to this fork or not.

As we have discussed, we want to prepare the sample app to not track any activity after the user just download, just prepare an "architecture".
After a user will connect the app with its own sample app we want to provide a tutorial how to enable logging activity.
TODO:

Set parameter from function call in header.js to empty string
Set activity codename parameter from ActivityLogging.js to empty string
Reflect changes in in README.md
** Just one note for step 5 - ket('start', ''); is not a function it is a function call :-)

Thank for the pull :+1:

A note for myself based on our discussion: Also make the function name more specific, LogAboutUs or similar.


Add documentation for requireVlanName parameter

There is a requireVlanName parameter in the lldp namespace that allows LLDP imports where the VLAN name isn't set (this is the case for some Arista switches for instance). It's not documented anywhere else than the reference configs though, so this PR adds a quick section about it. See #466 as well.
@tumblr/collins @byxorna

👍


Baby geese don't drop what they are holding when they die

So geese like to steal things and get aggressive when provoked - I made the mistake of spam throwing eggs, which of course then hit a baby goose for 0 damage, provoking all others in the cage.
Long story short, I died, dropped all my items and didn't immediately know how to get them back (seems dropping seeds on the ground is the go-to way), so I ended up killing them.
Adult geese do drop what they are holding but I learned the hard way that baby geese don't and lost some important items due to that.

Thanks for reporting! This is due to the fact that baby entites by default don't drop their loot.
I disabled goslings from picking up items now. Since they also don't attack you I think this is the most sensible solution.
Will be fixed in the next release of the mod.

Makes sense, although I do think baby foxes do drop the item they are holding, this is just as good of a solution.
Thanks for the quick reply!


shopify app serve does not work with Shopify Cli 3

shopify app serve does not work with Shopify CLI 3
How to run in dev?

same question

If you referenced https://shopify.dev/docs/apps/tools/cli/migrate#requirements to migrate your shopify CLI to 3.x, then you should be able to use npm run dev to run your dev. Please note that the server port will change (no longer 8081), which should be shown in dev server message.


weston fails to start from tty

On debian buster options --weston and --weston-xwayland fail to start from console with error message:
[13:52:45.514] initializing drm backend
[13:52:45.514] fatal: drm backend should be run using weston-launch binary, or your system should provide the logind D-Bus API.
[13:52:45.514] fatal: failed to create compositor backend

weston-launch fails with:
weston-launch: Permission denied. You should either:
 - enable systemd session support for weston-launch.
 - or add yourself to the 'weston-launch' group.

Related debian bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=799325
The bug should be fixed in weston 5.0.0-3. Hopefully the update is published soon.

Bug is fixed in weston 5.0.0-3


Update Fedora versions in update paths

As Fedora 35 is now EOL we need to refresh versions.

/packit test


RuntimeError: CUDA error: no kernel image is available for execution on the device

when i run train.py ,this error is occured.
File "/home/caihua/desktop/r3det-on-mmdetection/mmdet/core/bbox/assigners/max_iou_assigner.py", line 119, in assign
assign_result = self.assign_wrt_overlaps(overlaps, gt_labels)
File "/home/caihua/desktop/r3det-on-mmdetection/mmdet/core/bbox/assigners/max_iou_assigner.py", line 143, in assign_wrt_overlaps
dtype=torch.long)
RuntimeError: CUDA error: no kernel image is available for execution on the device
my environment as foloows:
sys.platform: linux
Python: 3.7.10 | packaged by conda-forge | (default, Feb 19 2021, 16:07:37) [GCC 9.3.0]
CUDA available: True
CUDA_HOME: /usr/local/cuda-10.1
NVCC: Cuda compilation tools, release 10.1, V10.1.243
GPU 0,1,2,3: Tesla V100-PCIE-32GB
GCC: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
PyTorch: 1.5.1+cu101
PyTorch compiling details: PyTorch built with:

GCC 7.3
C++ Version: 201402
Intel(R) Math Kernel Library Version 2019.0.5 Product Build 20190808 for Intel(R) 64 architecture applications
Intel(R) MKL-DNN v0.21.1 (Git Hash 7d2fd500bc78936d1d648ca713b901012f470dbc)
OpenMP 201511 (a.k.a. OpenMP 4.5)
NNPACK is enabled
CPU capability usage: AVX2
CUDA Runtime 10.1
NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_37,code=compute_37
CuDNN 7.6.3
Magma 2.5.2
Build settings: BLAS=MKL, BUILD_TYPE=Release, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -fopenmp -DNDEBUG -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DUSE_INTERNAL_THREADPOOL_IMPL -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, USE_CUDA=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_STATIC_DISPATCH=OFF,

TorchVision: 0.6.1+cu101
OpenCV: 4.5.2
MMCV: 0.6.1
MMDetection: 2.1.0+8f3868f
MMDetection Compiler: GCC 7.5
MMDetection CUDA Compiler: 10.1
how to fix this problem? thanks a lot

I had solved this problem by trying all kids of different Pytorch. Finally ,i find pytorch==1.6.0 is well , i think pytorch<1.6.0 is not suitable for V100, and pytorch >1.6.0 is not good for mmdet ==2.1.0.
i use conda install pytorch==1.6.0 torchvision==0.7.0 cudatoolkit=10.1 -c pytorch to install pytorch==1.6.0


can GeoSpark support GB2312  for shapefile?

when i read shapefile, i has set "geospark.glboal.charset" to gb2312, but it doesn't read Chinese in the shape file correctly.
Expected behavior

Actual behavior

Steps to reproduce the problem
System.setProperty("geospark.global.charset", "gb2312");
String shapeInputLocation = Learn02.class.getResource("/gzgj").toString();
SpatialRDD rdd = ShapefileReader.readToGeometryRDD(sc, shapeInputLocation);

Settings
GeoSpark version = 1.2.0
Apache Spark version = 2.4.3
JRE version = 1.8
API type = Java

Hi
You need to set it to utf8 in order to read Chinese.
Thanks,
Jia
On Tue, May 28, 2019 at 00:49 HuiWang<EMAIL_ADDRESS>wrote:

when i read shapefile, i has set "geospark.glboal.charset" to gb2312, but
it doesn't read Chinese in the shape file correctly.
Expected behavior
[image: 图片]
https://user-images.githubusercontent.com/22127608/58460304-ef68a680-815f-11e9-85ee-f0bd87fa3f1d.png
Actual behavior
[image: 图片]
https://user-images.githubusercontent.com/22127608/58460293-eaa3f280-815f-11e9-9bda-b691909a45e4.png
Steps to reproduce the problem
System.setProperty("geospark.global.charset", "gb2312");
String shapeInputLocation = Learn02.class.getResource("/gzgj").toString();
SpatialRDD rdd = ShapefileReader.readToGeometryRDD(sc, shapeInputLocation);
Settings
GeoSpark version = 1.2.0
Apache Spark version = 2.4.3
JRE version = 1.8
API type = Java
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DataSystemsLab/GeoSpark/issues/363?email_source=notifications&email_token=ACTRCADREMJTE5YZDFMOL73PXTPZHA5CNFSM4HQAUSM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWE6FCA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTRCAA5SYHXJK76RKN7EQLPXTPZHANCNFSM4HQAUSMQ
.

--

Jia Yu,
Ph.D. Student in Computer Science
Arizona State University http://www.asu.edu/
Reach me via Jia Yu's Homepage http://www.public.asu.edu/~jiayu2/ | GitHub
Repositories https://github.com/jiayuasu

it  still doesn't work

@scially As you can see from GeoSpark source code https://github.com/DataSystemsLab/GeoSpark/blob/aa9ec969d6c6eacfee6306c7bd4e4985a0d460c7/core/src/main/java/org/datasyslab/geospark/formatMapper/shapefileParser/parseUtils/dbf/DbfParseUtil.java#L201, setting it to UTF8 will make GeoSpark use a slower but proper decoder.
From my understanding, there are two possibilities: (1) these Chinese characters are there but cannot display properly. If this is the case, I guess you can proceed to other steps without worrying about this problem. (2) these Chinese characters are loaded improperly. In this case, if you don't mind, you can send me your shapefile and I will try it. We didn't meet this problem before and many Chinese people are using our shapefile reader.

thanks.
Can geospark read the geometry of postgresql?

by geospark sql....


chore: v2.16.5

Codecov Report

Merging #780 (50693fb) into main (154d373) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   58.59%   58.57%   -0.03%
==========================================
  Files        1209     1210       +1
  Lines       74915    74969      +54
  Branches    15561    15586      +25
==========================================
+ Hits        43900    43914      +14
- Misses      28268    28301      +33
- Partials     2747     2754       +7

Impacted Files
Coverage Δ

...ages/quick-open/src/browser/quick-input-service.ts
22.50% <0.00%> (-1.83%)
:arrow_down:

...ages/quick-open/src/browser/quickInput.inputBox.ts
7.61% <0.00%> (-2.14%)
:arrow_down:

...kages/theme/src/browser/workbench.theme.service.ts
71.17% <66.66%> (-0.05%)
:arrow_down:

packages/theme/src/browser/icon.service.ts
83.68% <75.00%> (-0.28%)
:arrow_down:

...xt/src/browser/services/file-tree-model.service.ts
53.88% <86.66%> (+0.36%)
:arrow_up:

packages/components/src/recycle-tree/tree/Tree.ts
91.30% <100.00%> (ø)

...es/file-tree-next/src/browser/file-tree.service.ts
62.33% <100.00%> (ø)

...es/src/browser/userstorage/user-storage.service.ts
57.30% <0.00%> (-5.62%)
:arrow_down:

packages/file-service/src/browser/watcher.ts
95.65% <0.00%> (-4.35%)
:arrow_down:

packages/core-common/src/node/port.ts
43.93% <0.00%> (-3.04%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009ccd9...50693fb. Read the comment docs.


Problems – Regression Tests

Hello everyone,
I’m experiencing some difficulties to pass all the available regression tests. I’m always getting the following results:
The following tests FAILED:
9 - UAE_Dnwind_YRamp_WSt (Failed)
16 - SWRT_YFree_VS_WTurb (Failed)
19 - 5MW_OC3Trpd_DLL_WSt_WavesReg (Failed)
20 - 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth (Failed)
21 - 5MW_ITIBarge_DLL_WTurb_WavesIrr (Failed)
23 - 5MW_OC3Spar_DLL_WTurb_WavesIrr (Failed)
Errors while running CTest
I’m using:

Windows 10 - 64 bits
Cygwin
GCC: version 7.3.0
GNU Fortran: version 7.3.0
Python: version 3.6.8
Make: version 4.2.1
CMake: version 3.14.5

I’ve already tried some of the suggestions in issue #274, such as:

Using GCC and GFortran 7.4.0 instead of 7.3.0
Using the dev branch
Compiling in debug mode (cmake .. -DBUILD_TESTING=ON -D CMAKE_BUILD_TYPE=Debug)
Using RelWithDebInfo as my compile type (cmake .. -DBUILD_TESTING=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo)

Unfortunately, none of the above helped with the problems. Has someone else experienced the same issues? What could I do to overcome these failures?
I’ve also compared the results with the baseline. I’ve found out that:

UAE_Dnwind_YRamp_WSt -> Local and baseline results are very similar.
SWRT_YFree_VS_WTurb -> Slightly different results. The most relevant are:

5MW_OC3Trpd_DLL_WSt_WavesReg -> Local and baseline results are very similar.

5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth -> There were some important differences:

5MW_ITIBarge_DLL_WTurb_WavesIrr -> Many different results:

5MW_OC3Spar_DLL_WTurb_WavesIrr -> Many different results:

Thank you for the comments, @andrew-platt and @rafmudaf. After running the python script to print the results and compare it to the MACOS GNU baseline, I’ve found that:

UAE_Dnwind_YRamp_WSt -> Local and baseline results are very similar
SWRT_YFree_VS_WTurb -> Slightly different results. The most relevant are:

5MW_OC3Trpd_DLL_WSt_WavesReg -> Local and baseline results are very similar
5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth -> Local and baseline results are very similar
5MW_ITIBarge_DLL_WTurb_WavesIrr -> Local and baseline results are very similar
5MW_OC3Spar_DLL_WTurb_WavesIrr -> Local and baseline results are very similar

The SWRT model has an instability, and I would not be concerned about any differences around that period of instability. In fact, I have noticed that almost any change to the code or compiler options will affect the results around 20 seconds.

Dear all,
Sorry for disturbing, I’m asking for your expert opinion to understand/decide if I can actually consider acceptable the two “FAIL” reg-tests that I got and, therefore, proceed with the executable I compiled. Those two are: SWRT_YFree_VS_WTurb (the 5 highlighted parameters in the .html file are: TwrClrnc1, TwrClrnc2, TwrClrnc3, LSShftFxs and YawBrFzn) and 5MW_ITIBarge_DLL_WTurb_WavesIrr (there’s only 1 highlighted parameter in the .html file, the Azimuth, but that one actually seems quite acceptable to me, while there are others that differ far more).
According to what I’ve been reading on some other “issues” here on GitHub, it’s fairly common for those two to appear to fail, since they’re more sensitive to numerical roundoff. In particular, it seems that: 1) it’s common for the SWRT_YFree_VS_WTurb to fail, especially because of an instability around 20 sec; 2) the ones with “Irr” in their names usually have (or used to have, because it got fixed?) problems due to the random number generator used for irregular waves.
I’m using: Windows 11 - 64 bits, Visual Studio Community 2019 (v16.11.22), Intel(R) Fortran Compiler Classic 2021.8.0, OpenFAST-v3.3.0. Also, Anaconda3 (Anaconda v2022.10 ; Python v3.9.13.) for the final part of the procedure to execute the reg_tests.
In the zipped files I’m attaching, you can find the following files for both reg_tests: the .html , the .out , the .log , the excel with the plots I made.
Thank you so much for your time!
Lyudyu
SWRT_YFree_VS_WTurb.zip
5MW_ITIBarge_DLL_WTurb_WavesIrr.zip

Dear @Lyudyu,
Your results look fine to me.  For the 5MW_ITIBarge_DLL_WTurb_WavesIrr case, the difference is purely numerically, likely the result of differences in the compiler/settings.  This case uses the RANLUX pseudo-random number generator to generate the irregular wave loads, which should not be different between compilers.  I tend not to really look at the SWRT* model test results, because this model will not produce meaningful results until the furling and tail-fin aerodynamic capability is added back into OpenFAST.
Best regards,

Dear @Lyudyu,
Here are my responses:

The FAST_Registry is used to auto-generate source code from the Registry files.  The FAST_Registry itself is not linked with OpenFAST, but the files it auto-generates (the _Types.f90 files) are compiled and linked with OpenFAST.  So, the FAST_Registry can remain in 32 bits even though you are compiling OpenFAST in 64 bits.

I would generally expect the single and double precision versions to give similar, but not identical results; there will likely be some differences related to numerical round-off in the single-precision version.  I would suggest running the r-tests for the executable you want to use (which I would expect to be the single precision "Release" version).

Best regards,

Dear @jjonkman,
Thank you so much again for your precious help!
I’m really sorry for bothering you again. The executable I want to use is indeed the single precision "Release" version, so I ran the r-tests for it as you suggested. After reading your reply, I was expecting results worse than the “Release_Double” version, but I don’t know if this is acceptable or too much: this time I got 9 fails (2 of which actually “Failing to complete”, but their names end with _Linear and I remember reading on some other “issues” here on GitHub that they’re not real tests, so I guess I shouldn’t be worried about them) rather than just 2.
The above mentioned 9 (specifying the highlighted parameters that caused them to fail) are:

5MW_ITIBarge_DLL_WTurb_WavesIrr (as last time, because of: Azimuth)
5MW_Land_DLL_WTurb (because of: Azimuth)
5MW_OC3Spar_DLL_WTurb_WavesIrr (because of: Azimuth)
5MW_OC4Jckt_ExtPtfm (because of: YawBrMzp)
5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti (because of: Azimuth)
HelicalWake_OLAF (because of: many parameters, about 22, 9 of which are the B1N…Fd)
Ideal_Beam_Fixed_Free_Linear (failed to complete)
Ideal_Beam_Free_Free_Linear (failed to complete)
SWRT_YFree_VS_WTurb (as last time, because of: TwrClrnc1, TwrClrnc2, TwrClrnc3, LSShftFxs and YawBrFzn. But I do remember you saying not to really consider the test results of this model, so I’m not worried about this one anymore).

The ones I’m mostly concerned about are the 5MW_OC4Jckt_ExtPtfm (seems to have significant differences) and the HelicalWake_OLAF (seems to have many and significant differences).
In the zipped files I’m attaching, you can find the following files for all of the failed r-tests: the .html , the .out , the .log , the excel with the plots I made.
Could you, when you have time, please take a look at them and let me know what you think?
(Hoping it may help deciding whether my results are acceptable or not, I point out that the simulations I’ll need to run will focus on floating offshore wind turbines).
Thank you very much for your time!
Kind regards,
Lyudyu
5MW_ITIBarge_DLL_WTurb_WavesIrr.zip
5MW_Land_DLL_WTurb.zip
5MW_OC3Spar_DLL_WTurb_WavesIrr.zip
5MW_OC4Jckt_ExtPtfm.zip
5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti.zip
HelicalWake_OLAF.zip
Ideal_Beam_Fixed_Free_Linear.zip
Ideal_Beam_Free_Free_Linear.zip
SWRT_YFree_VS_WTurb.zip

Dear @Lyudyu,
Just a few comments:

Regarding 5MW_OC4Jckt_ExtPtfm case, this case seems to result in negligible yaw moment, so, while the differences appear large, the values themselves are negligible and the differences are simply the result of numerical precision.
Regarding the HelicalWake_OLAF case, I'm not sure as I'm not familiar with this case.  Perhaps @andrew-platt or @ebranlard can comment.
The Ideal_Beam* cases seem to be failing because the tower length is very small (0.00005 m); my guess is this fictitious length has to be increased slightly to get it to pass in single precision.
I agree that the results for other cases are close, with these small differences expected between precisions.

Best regards,

Dear @jjonkman,
I’m really thankful for your help!
I followed your suggestion regarding the two Ideal_Beam_…_Linear cases: I had to increase the fictitious length from 5e-5 to 7e-4 in order to avoid the “Failed to complete” scenario. With such change, both cases ran and got to complete, even if unfortunately they both failed the comparison. Since they didn’t generate any html file (which I guess it’s normal since none of those ending with _Linear did either) and, therefore, I didn’t have any hint on which parameter/s caused the comparison to fail, I compared the files on KDiff and found out that there are quite some differences. I’ll attach the two folders and I’d really appreciate your opinion on that when you have time.
By the way, about the other failed cases mentioned in my previous comment, I realized that you might be more familiar with looking at plots generated using the Python script provided, so I’ll also attach: the html file with plots for the HelicalWake_OLAF case, while only screenshots of the plots regarding the failing parameter/s for the other 6 cases (since I would have otherwise exceeded the 25 MB limit).
For what regards the HelicalWake_OLAF case, I’d be super thankful if @andrew-platt or @ebranlard could take a look at it when they have a moment.
One last thing that I forgot to ask/point-out last time and that I’ve been wondering if it may be the cause for some of those cases to fail: in the “3.2. Regression tests” chapter, the last step of the “<IP_ADDRESS>.1. Windows with Visual Studio regression test” section says to type “python manualRegressionTest.py ..\build\bin\openfast_x64_Double.exe Windows Intel 1e-5”, which doesn’t actually work because the Anaconda command prompt asks for a different syntax, which is “Executable-Name Relative-Tolerance Absolute-Tolerance”, so I modified the initial command into “python manualRegressionTest.py ..\build\bin\openfast_x64.exe 1e-5 1e-5”, assuming Relative-Tolerance and Absolute-Tolerance to have the same value since I didn’t find any recommendation regarding such aspect. Is this last assumption correct, or shall I be using other values?
Thank you so much for your time and patience,
Best regards,
Ideal_Beam_Fixed_Free_Linear.zip
Ideal_Beam_Free_Free_Linear.zip
Plots from Python.zip

Hi @bmazetto. I had a quick look at your OLAF results. I can see that there is a weird spike going on around 37s in the elastic loads. Apart from that, most signals, and in particular the aerodynamic signals appear to match fairly well. I wouldn't worry about it because you are using an older compiler. Try using gfortran 10.3 if you can, and compile in double precision.

Dear @ebranlard,
Thank you so much for finding the time to have a look at my results.
Actually, the compiler I'm using is Intel(R) Fortran Compiler Classic 2021.8.0 (I'm not the same person who opened this issue, I just commented here a few days ago: about eight comments above, you can find the list of what I'm using).
I've already compiled in double precision and the OLAF case passed the test. Now I'm testing the single precision, since that's the one I'll need to use, and I'm trying to understand if the differences in results are acceptable.
Kind regards,

Dear @Lyudyu,
I'll let @ebranlard or @andrew-platt comment regarding the OLAF case in single precision.  And I'll let @andrew-platt or @rafmudaf comment regarding the Python script syntax.
Regarding the Ideal_Beam* cases, I do see differences in the resulting *.lin files between your single and the original double precision versions, but this is to be expected given the differences in numerical round-off between the two versions.  Nothing stands out to me as a major difference.  I'm not sure what you mean when you refer to "KDiff".  That said, if you are concerned with the differences, I would suggest computing the eigensolution of the state matrix "A" stored in the resulting *.lin files to ensure that the eigenfrequencies of the beams are consistent between the two sets of results.  This would provide a physically meaning assessment of the differing results in the *.lin files . The MATLAB and Python toolbox provide scripts for performing an eigenanalysis on the "A" matrices stored in *.lin files
Best regards,

Dear @jjonkman,
Sorry for the late reply and thank you so much for your detailed answer!
What you said about the absence of major differences is comforting, and thank you for suggesting a way to assess the physical meaning of the differing results.
Regarding “KDiff”, with that I was actually referring to the software KDiff3 (I’m sorry, I should have been more clear).
If @ebranlard or @andrew-platt could comment on the OLAF case in single precision considering the details pointed out in my previous comment, that would be very helpful.
Also, I would be really thankful if @andrew-platt or @rafmudaf could comment regarding the Python script syntax.
Thank you all for your time!
Best regards,

Hi, I wouldn't worry about the difference between single and double precisions in the OLAF case at that time.

Regarding the python script syntax, The tolerances have different meanings after changes in https://github.com/OpenFAST/openfast/pull/1217, but the documentation hasn't been updated (see https://github.com/OpenFAST/openfast/issues/1225). Based on the defaults listed in #1217, this is what I have been using:
python manualRegressionTest.py -p -v C:\openfast\build\bin\openfast_x64.exe 2 1.9

There is a PR started to address the documentation on the manual regression tests: #1419 (a few more details will be added prior  to merging).

Dear @ebranlard, @bjonkman and @andrew-platt,
Thank you all so much for your help!!
Sorry for bothering you @bjonkman. I was starting to feel quite confident that my results were acceptable (meaning that the reasons for some of my tests to fail could be simply attributed to small differences between precisions and numerical roundoff), but then I tried running (in single precision) the r_tests using the updated tolerance values you mentioned (I also read #1217) and I got way more fails: 23 instead of my previous 9. Is that normal?
Actually, 4 of those 23 are the ones stated to have been disabled in #1217 (specifically: 5MW_ITIBarge_DLL_WTurb_WavesIrr, 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth, SWRT_YFree_VS_WTurb and UAE_Dnwind_YRamp_WSt), so I guess I could/should neglect those 4 failed tests, right?
I attach the screenshots of the plots of the parameters that caused the remaining 19 tests to fail, and I would be really grateful if, when you have time, you could take a quick look at them and let me know if you think they are acceptable (especially: 5MW_OC4Jckt_ExtPtfm and HelicalWake_OLAF).
(By the way, for each failed test I’ve added a txt file saying which parameters I’m more worried about).
In case it might be of any help, I will add that I also tried running the r_tests using the updated tolerance values in double precision and got 4 fails (the same 4 stated to have been disabled in #1217) instead of my previous 2 (only 2 out of those 4: 5MW_ITIBarge_DLL_WTurb_WavesIrr and SWRT_YFree_VS_WTurb).
Thank you very much for your time and patience!!
Best regards,
Failed r_tests plots.zip

Also, in case I couldn’t/shouldn’t neglect “those” 4 failed tests, I attach the screenshots of their plots too, and the ones I’m most worried about are: 5MW_ITIBarge_DLL_WTurb_WavesIrr and 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth.
Thank you so much again!
Best regards,
Failed r_tests plots_2.zip

Dear @bjonkman,
I am really sorry for bothering you again.
I was just wondering if you would have time to take a look at my last two comments from last week.
Thank you very very much in advance!!
Kind regards,

Dear @bjonkman and @jjonkman,
I am really sorry for bothering you again.
I was just wondering if you (and @ebranlard when it comes to the OLAF case) could find some time to take a look at my last two comments from four weeks ago.
Thank you very much in advance!!
Kind regards,

Dear @bjonkman and @jjonkman,
I am really sorry for bothering you again with this.
I was just wondering if you (and @ebranlard when it comes to the OLAF case) could find a little time to take a look at my last two comments.
I am back working on my thesis and having your expert opinion about what I asked above would be a huge help!
Thank you very much in advance!!
Kind regards,


[Review] Request from 'kalabiyau' @ 'SUSE/Portus/review_150417_own_user_repository'

Please review the following changes:

5f574f0 Fixed controller spec
dfeee62 Merge branch 'images' of github.com:SUSE/Portus into review_150417_own_user_repository
0f85cac Fix for nbf field skew
0a21a50 My own repository access authorization
97e0ecb Rubocop cleanup
eae29dd Fix controller tests
7865a97 Fix broken test
19ac5fe Apparently the specs are loaded also by the environments != from testing
d22fd4b More code refactoring
a009ce4 Code refactoring for notification handler
c6ba447 Code refactoring: move regexp into constant
023ad29 Code cleanup: use respond_with
f686347 Add missing indexes
41bba1d Remove useless class
ac79c9c Code cleanup
746c92e Introducing Repositories, Images and Tags

LGTM, but before merging we have to:

do an interactive rebase to merge lots of commits together
fix the naming issues (repository -> namespace; image -> repository)


[Admin] Area-Management/AreaView/ViewSite Export CSV Field Fixes

On the area-management, areaview, and viewsite export CSV features:

Please include the Year and Cycle as columns
For all of the test scores (pre/post attitudinal/acadmic), put a percentage on the export csv field instead of a row of data separated by commas

/cib csv-field-fixes

Branch 195-csv-field-fixes created!


Age calculator using python

Is your proposal related to a problem? Please describe.
Python age calculator is a console-based application where you have to give your birth date it will provide the current age of yours
Add any other context or screenshots about the proposal request here.
Tech Stack
python
datetime(python module)

@Kushal997-das Please assign this issue to me under Gssoc 2022

@Kushal997-das the pr is made #621


QuestionAnsweringBERTTest

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-409-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-409/1/index.html

Hi @yirawan1996,
Could you please add a description to this PR and the reason why you wish to merge it into AutoGluon?

It is still unclear to me the reason why this PR has been requested and if any steps are being made to move it forward. Can someone please clarify within this PR?

Job PR-409-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-409/2/index.html

It does not appear that progress is being made, so I am closing this PR. Please re-open the PR with additional information added to continue the PR process.


add event wrappers for event retargeting abstractions

fixes https://github.com/dart-lang/polymer-dart/issues/598

lgtm


Compiler crashes when compiling JsonDoc.data assigment statement

I get a compiler crash when assigning a value to the JsonDoc data field. Sample code on playground
I get the same error when compiling it on Ubuntu on Virtual box with the same version. Commenting out jd.data = I64(15) compiles.
This code compiles correctly with 0.17.0 but fails from with version 0.18.0 onwards.
Code
use "json"

actor Main
  new create(env: Env) =>
    let jd = JsonDoc
    let s: String = "Hallo"
    jd.data = I64(15)
   env.out.print("Hello crash")

Compiler version:
ponycd --version
0.19.1-0b561fdb [debug]
compiled with: llvm 3.9.1 -- cc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406

Output
peza@peza-VirtualBox:~/Documents/pony-ws/issue-1$ ponycd --pic --debug
Building builtin -> /home/peza/Documents/ponybuild/ponyc/packages/builtin
Building . -> /home/peza/Documents/pony-ws/issue-1
Building json -> /home/peza/Documents/ponybuild/ponyc/packages/json
Building collections -> /home/peza/Documents/ponybuild/ponyc/packages/collections
Building ponytest -> /home/peza/Documents/ponybuild/ponyc/packages/ponytest
Building time -> /home/peza/Documents/ponybuild/ponyc/packages/time
Building format -> /home/peza/Documents/ponybuild/ponyc/packages/format
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
src/libponyc/codegen/genoperator.c:349: assign_field: Assertion `t != NULL` failed.

Backtrace:
  ponycd(ponyint_assert_fail+0xee) [0x560f00fb9de3]
  ponycd(+0x121326) [0x560f00fb3326]
  ponycd(+0x121823) [0x560f00fb3823]
  ponycd(gen_assign+0xad) [0x560f00fb4c5f]
  ponycd(gen_expr+0x39b) [0x560f00fa873c]
  ponycd(gen_seq+0x4e) [0x560f00fb4d1c]
  ponycd(gen_expr+0x88) [0x560f00fa8429]
  ponycd(+0xce2ff) [0x560f00f602ff]
  ponycd(genfun_method_bodies+0xe7) [0x560f00f60f49]
  ponycd(gentypes+0x44b) [0x560f00fabc01]
  ponycd(genexe+0x22f) [0x560f00f7ab07]
  ponycd(codegen+0x154) [0x560f00f533bb]
  ponycd(generate_passes+0x35) [0x560f00edaeb9]
  ponycd(+0x47e4c) [0x560f00ed9e4c]
  ponycd(main+0x49a) [0x560f00eda2fb]
  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7f88d2f7f3f1]
  ponycd(_start+0x2a) [0x560f00ed9bea]
Aborted (core dumped)

The problem is that the type iso->JsonType (i.e. (F64 | I64 | Bool | None | String | JSonArray tag | JSonObject tag)) isn't considered reachable, even though you're accessing an object of this type through jd, which is a JSonDoc iso.
I think the solution here is to reach the viewpoint-adapted field type when accessing a field (with either a read or a write).

Indeed, declaring the type of jd as JsonDoc ref compiles correctly.


[Bug report] Apache Kafka topics are displayed in semi-random order

Version
main branch
Describe what's wrong
Topics are not ordered

Error message and/or stacktrace
N/A
How to reproduce
Create a number of topics and see how they are ordered
Additional context
No response

This ordered list was obtained from the API. @mchades Please help to pay attention this issue.

It's the same question with #2623 ?

I will close this as it is a duplicate of #2623


zh: some mirror updates

What is changed, added or deleted? (Required)

update some links to MySQL docs because slave has been updated
add more explanation about HA
add max-allowed-packet into task config sample
mirror updates the format about TiUP doc

Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v3.0 changes)
[x] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[ ] Have version specific changes
[ ] Might cause conflicts after cherry-picked

@lance6716 @ireneontheway PTAL

LGTM

/merge


feat(plugin-chart-echarts): add support for generic axis to mixed chart

SUMMARY
Add support for generic x-axis to Mixed Time-Series chart. In addition do the following changes:

Make the chart name and description dependent on the feature flag
Implement temporal x-axis scaling that was introduced in #19686
Remove the "Predictive" tag from the Mixed chart (it doesn't support the predictive analytics functionality)
Minor refactoring/cleanup

AFTER
When the feature flag is enabled, the x-axis control appears, making it possible to use a non-temporal x-axis:

Now the chart is called "Mixed chart" instead of "Mixed Time-series Chart":

TESTING INSTRUCTIONS

Enable GENERIC_CHART_AXES feature flag
Go to chart picker and notice that Mixed time-series chart has been replaced with Mixed chart with a description that doesn't mention the words "timeseries" or "temporal"

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up FEATURE_GENERIC_CHART_AXES=true

An example chart on the eph env: http://<IP_ADDRESS>:8080/superset/explore/p/gG3OYRVY0wj/


"Old mode detected on camera" error.

Hello,
Thank you for supporting catkin_make error. I resolved issue by the latest update.
I tried to use launch file example. Then, it has firmware version error...
Camera SDK is the latest image file which are downloaded version 4.2.0 of Win GUI. ADSD3500 firmware is also latest.
Windows GUI said.
ADSD3500 firmware version <IP_ADDRESS>
SD card image version:microsd-4.2.0-b260ad46.img
kernel version: lf-5.10.72-2.2.0
u-boot version: imx_v2020.04_5.4.70_2.3.0
Can I confirm the supported SDK version and ADSD3500 firmware version for the ROS driver?
If the SDK imge or firmware will update in couple of weeks, I would like to wait the update.

Thanks again.
Jun

Hi!
The error is caused by the older firmware version that exists on your camera.

 But your camera is configured to work with old modes ("mp", "qmp") as opposed to new modes ("lr-native", "sr-native", "lr-qnative", "sr-qnative"). I would say that you have 2 options:

Use the SDK v4.2.0 (which is currently the latest release) on you PC. This version will be the last version to support old modes.
Replace your camera module with a newer one (part name is ADTF3175BMLZ) that is configured to work with the new modes.

Thank you so much.
I see. I will get newer module for this.
Best regards,
Jun


Plugin runs but does not parse markdown

Hi!
First I would like to thank for the awesome plugin! But I am having a little bit of trouble trying to make it work here.
I try to run the plugin with the exact same bit of css as in the example you have and a see the "Successfully created style guide!" output on the CMD, the style guide file is generated with the specific title I pass as a parameter to the plugin. The thing is that the page does not render the markdown from my css.
I have a separated folder for my gulp tasks that I then import with babel on the project root folder. I don't know if that might be a problem, but I can't see why it would.
I have the following structure:
app / css / test.css
gulp / tasks / styleguide.js
build/styleguide/index.html
gulpfile.babel.js

test.css contains the following:
/*
@document

# I love Twitter Bootstrap

Use the button classes on an `<a>`, `<button>`, `<input>` element.

<button class="btn">Button</button>

    <button class="btn">Button</button>

*/

.btn {
  display: inline-block;
  padding: 6px 12px;
  margin-bottom: 0;
  font-size: 14px;
  font-weight: normal;
  line-height: 1.42857143;
  text-align: center;
  white-space: nowrap;
  vertical-align: middle;
  touch-action: manipulation;
  cursor: pointer;
  user-select: none;
  background-image: none;
  border: 1px solid transparent;
  border-radius: 4px;
}

.btn:hover,
.btn:focus,
.btn.focus {
  color: #333;
  text-decoration: none;
}

the styleguide task looks like this:
gulp.task('styleguide', function () {
  let output = global.isProd ? config.styleguide.prodDest : config.styleguide.dest,
    processors = [
      styleguide({
        project: 'A awesome title',
        dest: output + '/index.html',
      })
    ],
  return gulp.src('app/css/*.css')
          .pipe(postcss(processors, {syntax: scss}))
});

the output bit is correct since the style guide file is generated.
This plugin would be really really good if it worked for my next project. Thanks again if you have to look into it  ;)

@vhlongon Thank you for your report. Please tell me the output html file and your development environment(ex. OS, Node version, postcss-style-guide versioin)

@morishitter I am running win 10, node 4.2.3, postcss-style-guide ^0.11.0.
I had a quick look on the plugin and it seems like the problem is under analyser.js, well the css-annotation plugin doesn't parse the comment.text correctly. If you log the meta variable you will see that the object has a .text property, but when you you call the annotation plugin it returns on the check (!meta.documents && !meta.document && !meta.docs && !meta.doc && !meta.styleguide), because meta is just an empty object

Here is the output file. It looks like it should. I see the title a pass as parameter and it is written on the right place as well. But as you see it does not render the markdown from the comment on the css file:
<!doctype html>

        <meta charset="UTF-8">
        <title>Lights by TENA Style Guide</title>

A awesome title

Generated by postcss-style-guide

Sorry, I didn't test in windows. What are the string of comment.text?

'@styleguide\r\n@docs\r\n\r\n# I love Twitter Bootstrap\r\n\r\nUse the button classes on an `<a>`, `<button>`, `<input>` element.\r\n\r\n<button class="btn">Button</button>\r\n\r\n    <button class="btn">Button</button>'

fmm.. maybe this is the bug of postcss-style-guide.
If you can fix this bug, feel free to send PR :)

sure, no problem. I can try, but since it the annotation.read(comment.text) is returned as just an empty object don't you think that the problem is actually with the css-annotation plugin?

what it the expected result of annotation.read(comment.text) ?

Thanks!

don't you think that the problem is actually with the css-annotation plugin?

There is also the possibility.

what it the expected result of annotation.read(comment.text) ?

{ styleguide: true }

ok, So I have removed that check and it works, so it is definetely an issue with the annotation plugin. I had a look on the rest of the logic and it works like a charm!

I have also checked the annotation plugin, but regex is really not my cup of tea :dancer:

This commit may be related to this bug.

Just released css-annotation v0.6.1. Please re-install postcss-style-guide and confirm again.

I see the new version here, but still doesnt work. The weird thing is that if I test the exact same string returned from the postcss with the regex express on the browser console it returns  ["@styleguide"] as expected, but now on the style-guide plugin. it still return empty :|

on line 77 of index.js (for the css-annotation):
var names = commentText.match(/\@.+?(\n|$|\s.+?(\n|$))/gm)
the fix works but it was only used on the parse method and not the read :)

can you please update the css-annotation with the fix as well? Thanks!

Released v0.6.2 including this commit.

@morishitter Great dude! thanks for the quick reply! Again, awesome plugin!

@vhlongon Thank you for your help :)


[Docs] - Add context for windows authentication from linux

Describe your changes:
Fixes

I worked on the mssql connector docs because it was requested by Harsha to update this page after resolving the connection issue on Slack support channel. Thank you @harshach and @ulixius9! https://openmetadata.slack.com/archives/C02B6955S4S/p1695229785643939?thread_ts=1694206363.231229&cid=C02B6955S4S

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani can you advise how to submit a docs update without failing these tests?


Renaming of a installed npk happens after mount

The move of a newly installed npk into the registry happens after mounting it. Not sure if this is a good idea since the loopback refers to a file that is moved out of it's location.
See console::installation_finished.

Fixed by #134


Channel Island census searchers on island need removing

Currently the names of individual islands (e.g. Jersey) appear in the 'County' table, but searching using these fails to find anything.  If 'Channel Islands' is selected, then the individual islands appear in the 'Place' table, and can be selected.  Remove individual islands from the county list to prevent searches being made from that list.

NB, no records for Sark? Possibly with Alderney? Brenda to check

Pat to check for Sark

removed the individual islands from the census county list on test2

also on production

I've now  run some experimental searches, with the conclusion that: for place of Birth search for Sark, FC2 is better than FC1 (i.e. you can do it).
For enumeration place, the structure is Channel Islands (county) > Guernsey (place) > Sark (civil parish).  Sark is often treated as a dependency of Guernsey, but is in fact an independent country (with its own UN code) so people might reasonably expect to see Sark in a listing 'one down' from the Channel Islands.
I think this issue can now be closed, but I will open a new one about enhancing searches on  place of enumeration.


Adding Architecture Decision Records

8 Use GOVUK Verify for claimant identity assurance
9 Capture a Teacher Reference Number to validate a claimants qualifications
10 DfE can download claim data during private beta phase

@tekin I didn't attempt 'ADR for using NAV as the payment solution', not sure it's a decision yet or that I have enought context.


Lufr v3

[x]  Fields rho and theta removed from the opted information structure
[x] Optional additional of the layout field, included verbatim
[x] New record types logentry and layout taking keys 5 & 6 resp.
[x] Additional field in group with precomputed translated group name from ID
[x] Detector indices in LUFR enumeration are now 1-4, instead of 0-3, renaming removed for v3
[x] Restructure for a single enumeration when requested

Fixed in #31


Factory method parameters do not match constructor @Assisted parameters. Both parameter type and name must match.

Dupe of #81. This requirement will be gone in the next release.


Support for building different arch's such as Rpi / Arm

Hi,
I've been experimenting to see if I can get the demo app to build then run on a Rpi with ubuntu mate installed (17.10), I've managed to get it working.
But I'd like to request if we could specify different arch's in the options / arguments to electronize build though to make it easier
I've included some info below for anyone that wants to have a go.
Build for Linux X64
First run electron build for linux-x64
dotnet build
dotnet electronize build linux

Build for Linux arm
Next run dotnet publish specifying the arm arch
dotnet publish -r linux-arm --output "obj\desktop\linux-arm\bin"

Next copy over the api directory / main.js / package.json
cd obj\desktop\linux-arm
xcopy ..\linux\api .\api
xcopy ..\linux\main.js .\
xcopy ..\linux\package.json .\
xcopy ..\linux\package-lock.json .\

Next run npm
npm install
npm install electron-packager --global

Finally manually generate the package
electron-packager . --platform=linux --arch=armv7l --out="electron-packager . --platform=linux --arch=armv7l --out="..\..\..\bin\desktop-arm" --overwrite" --overwrite

Deploying to the Rpi

At this point zip up the files under bin\desktop-arm
copy across to the Pi
unzip on the Pi

Setting up on the Rpi
If you get an error regarding MIT-MAGIC-COOKIE-1 then just try
rm ~/.Xauthority

If this has been built under windows instead of Linux
Then once you've unzipped the contents onto the rpi box you need to make ElectronNET.Host executable. But there's also other files that need to be made executable as well (not exactly sure which ones) to avoid other random errors.
To get around this cd into the directory where you've extracted the files and just make everything executable as a quick workaround
find . -exec chmod +x {} \;

At this point you should be able to run with just
./ElectronNET.Host

I would add this to the wiki but I don't think it's open for public access

We released a new version and now support addional params for the build command like this:
dotnet electronize build /target custom win7-x86;win32 /electron-arch ia32
The "custom" target can be used to specify the desired .NET Core platform and the desired electron packager platform. Be aware that the electron packager itself has an addional parameter called arch, which specifies x86/x64 etc.
You should now be able to mix everything that you want :)
Just update the CLI to version 0.0.9


Updated "Get IP Address"

Added verification from the docker inspect documentation https://docs.docker.com/reference/commandline/cli/#inspect

Thanks!

@wsargent You're welcome, you have put together some fantastic information!


HADOOP-16939. fs.s3a.authoritative.path should support multiple FS URIs

add unit test, new ITest and then fix the issue: different schema, bucket == skip
factored out the underlying logic for unit testing; also moved
maybeAddTrailingSlash to S3AUtils (while retaining/forwarnding existing method
in S3AFS).
tested: london, sole failure is
testListingDeleteauth=true
...filed HADOOP-16853
Change-Id: I4b8d0024469551eda0ec70b4968cba4abed405ed

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 12s
trunk passed

+1 :green_heart:
compile
0m 35s
trunk passed

+1 :green_heart:
checkstyle
0m 27s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
15m 30s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s
trunk passed

+0 :ok:
spotbugs
1m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 58s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 20s
hadoop-tools/hadoop-aws: The patch generated 0 new + 32 unchanged - 1 fixed = 32 total (was 33)

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 14s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

+1 :green_heart:
findbugs
1m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 16s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

59m  9s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1914/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1914

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1077dd506797 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e3fbdcb

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1914/1/testReport/

Max. process+thread count
421 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1914/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

through yetus first time -I am pleasantly surprised.
Tested: S3 london


No module named 'dill'

Error message:

File "cli.py", line 10, in
import bin.utility as cli_util
File "/home/grzana/Desktop/mugen-master/src/bin/utility.py", line 8, in
import mugen.paths as paths
File "/home/grzana/Desktop/mugen-master/src/mugen/init.py", line 5, in
from mugen.video.video_filters import VideoFilter
File "/home/grzana/Desktop/mugen-master/src/mugen/video/video_filters.py", line 4, in
import mugen.video.detect as v_detect
File "/home/grzana/Desktop/mugen-master/src/mugen/video/detect.py", line 15, in
from mugen.video.segments.VideoSegment import VideoSegment
File "/home/grzana/Desktop/mugen-master/src/mugen/video/segments/VideoSegment.py", line 8, in
from mugen.video.segments.Segment import Segment
File "/home/grzana/Desktop/mugen-master/src/mugen/video/segments/Segment.py", line 11, in
from mugen.mixins.Persistable import Persistable
File "/home/grzana/Desktop/mugen-master/src/mugen/mixins/Persistable.py", line 1, in
from dill import dill
ImportError: cannot import name 'dill'

Using Ubuntu 18.04
I installed dev env version but on every type env the same error happend
First i have this error https://github.com/scherroman/mugen/issues/17 but i fix this and now i have this error

Hey Nerdrod2, thanks for reporting this. Try pulling the latest version of mugen, this should be fixed now.
You can now also install mugen via pip, then use the mugen command anywhere once installed. See the Practical Install section in the readme for details!


Add support for checking library_names in the generator auditor

This fixes spurious warnings when library_names is set instead of library_name.
Fixes #476.

library_name is the fallback libname for those headers that are not captured by library_names.
# library_name = ">/+-;'[]{}()!@#$%^&*~`"
library_names = {}

Alrighty, I did a second attempt in 891aff4. Now the auditor will check both library_name and the lib names in library_names for validity, and it'll only log a warning if library_name is not set and library_names doesn't contain entries for all the headers. I had to modify the Audit pass and TranslationUnit a bit to make that work since we don't store the passed headers in a Context (and I figured it made sense to store the file path with its TranslationUnit).

Thanks folks!


Fix attachment description

Fixes issues with attachment_description:

Do not return an array of all metadata if there is none with the key _wp_attachment_image_alt
Do not return nil if there is no metadata at all

:+1:


[BUG] Body is always parsed as JSON regardless of media_type

Describe the bug
This is to continue the discussion at https://github.com/tiangolo/fastapi/issues/579#issuecomment-589263249. Body accepts an argument media_type, but regardless of the media_type Body is parsed as JSON. This is a problem for other media_types such as plain/text, application/sql, etc. And this is not compliant to OpenAPI content. Body should be able to represent plain text as str too.
Basically I wish I could do this:
request: str = Body(..., media_type='text/plain')

However, this produces 400 parsing error because Body is parsed as JSON anyway.
To Reproduce

Create a file with:

from fastapi import FastAPI, Body

app = FastAPI()

@app.post("/")
def read_root(body: str = Body(..., media_type='text/plain')):
    return {"I received:": body}

Run the server.

Then execute: curl -d 'I want to print this' -H 'Content-Type: plain/text' http://localhost:8000

It returns {"detail":"There was an error parsing the body"}

But I expected it to return {"I received": "I want to print this"}.

Expected behavior
My expectation is that the Body should be parsed based on the Content-Type header always.
Screenshots
I think the information is quite comprehensive without screenshots.
Environment

OS: Ubuntu 18.04
FastAPI Version: 0.49.0
Python 3.7.4

Additional context
The associated part is: https://github.com/tiangolo/fastapi/blob/9c3c9b6e78768374868d690bc05918d58481e880/fastapi/routing.py#L114
This does not check Content-Type. My proposal is to fix it as
if body_bytes and request.headers['Content-Type'] == 'application/json':
# if body_bytes and request.headers.get('Content-Type', 'application/json'): # if the content type should be assumed.
    body = await request.json()
else:
    body = body_bytes

I can make a PR for this, but I would like to learn the maintainers' opinion on this.
@tiangolo @dmontagu @phy25, thanks for the great project!

Looking forward to this. I have a bunch of raw text (words from files) I want pumping into my api with a simple api as possible..

I have the fix suggested above implemented, and it works in the project that I'm currently developing, but I'm unable to figure out a way to get all of the tests to pass. For example, I'm getting a test failure on tests/test_tutorial/test_body/test_tutorial001.py during test_post_broken_body(). The value of response.status_code is 422, which is causing the assertion of assert response.status_code == expected_status to fail. Any suggestions, anyone?

Oh, that's why I cant have a YAML body in an endpoint...
With @jbkoh's proposal, I get this error in the tests:
fastapi/routing.py:151: error: Incompatible types in assignment (expression has type "bytes", variable has type "Optional[FormData]")
Found 1 error in 1 file (checked 40 source files)

@heitorPB What's the input here?

@jbkoh
This is the output of the scripts/tests.sh with the changes you suggested. I'm running on master branch.
Did you run the tests?

@heitorPB Ah, no I didn't. I was waiting for the maintainers' response before properly implementing the proposed solution. I will try to find some cycles to actually run the test. I guess @jacob-vincent had a similar issue.

If you are sending plain text files, the best way to do it (and the common practice / "standard") is to send them as form data.
Here are the docs for that: https://fastapi.tiangolo.com/tutorial/request-files/
Another option is to read the body directly as a stream by getting the request directly: https://fastapi.tiangolo.com/advanced/using-request-directly/

@jbkoh About the suggested change, I'm not sure yet how it would work and what else would need to interact with it, but maybe you can start a PR and we can see what else could break or what else would be needed for it.

Another option is to read the body directly as a stream by getting the request directly: https://fastapi.tiangolo.com/advanced/using-request-directly/

The downside is that it is not documented in the OpenAPI.json file.

What's the point of the media_type option in Body if it won't be honored.

What's the point of the media_type option in Body if it won't be honored.

@htapal It's currently passed onto openapi generation.

What's the point of the media_type option in Body if it won't be honored.

@htapal It's currently passed onto openapi generation.

What good does that do if the framework doesn't honor the media type of the body? Passing on to the openapi spec is a by product, cherry on top you could say for the functionality provided by the framework.  In this case, setting the media_type of the Body correctly sets up the API docs with the interactive docs even customizing the form based on what the resource is declaring is the media type it accepts, however, when posting the data, the framework completely ignores the declare Body media type.
The workaround of using Form or the request directly is not acceptable.  Fastapi is a framework to build REST apis and it's a very, very good one.  But for it to only expert JSON and form-data as the request body is very short-sighted especially since the Body class allows you to declare the media type.

@jacob-vincent did you had any success to make the tests pass?

Any update on the fix for this? I'd love to be able to get my API docs to include the request body documentation for text/plain POST endpoints. :)

Any update on this? This will be highly useful for media types like yaml, graphql, etc where the parsing can be done in the api implementation.

Any update on this? This will be highly useful for media types like yaml, graphql, etc where the parsing can be done in the api implementation.

from fastapi import FastAPI, Request

app = FastAPI()

@app.post("/some/path/{arbitrary_url_param}")
async def arbitrary_endpoint(arbitrary_url_param: str, request: Request):
    client_host = await request.body()

@laanak08 What I'm looking for is to provide the body as application/text content-type in the apidocs ui so that I don't have to provide the input as json always for normal text, yaml, graphql inputs. I believe if this issue is fixed, the functionality can be achieved.

Right, the problem here is that there is no way to both handle a non-JSON body and display a body field in OpenAPI/Swagger UI.  Right now it's either-or: the only way to have a body field show up in Swagger UI is to accept only JSON.

Funny, now that it is merged and I have updated, the $http of legacy angular generates error, because it sents a json without content-type.

https://github.com/tiangolo/fastapi/commit/fa7e3c996edf2d5482fff8f9d890ac2390dede4d could be  extended to first use body_field.media_type when provided, or go with current logic when unspecified. This would allow to force using proper content-type e.g. for callbacks/hooks where 'content-type' received is not under control of an endpoint's implementer.


[CN DateTimeV2 Python] ”五天前“ , "5天前” and "2小时前" are not extracted

Platform: Python
Version of package: recognizers-text-date-time 1.0.1a0

>>> from recognizers_date_time import DateTimeRecognizer, Culture

>>> model = DateTimeRecognizer(Culture.Chinese).get_datetime_model()

>>> model.parse('5天前')
[]
>>> model.parse('五天前')
[]
>>> model.parse('2小时前')
[]

Re-open as PR #1904 only fixed this in JS.