Is it possible to set concurrency level for SequentialDnsAddressResolverFactory in Quarkus extension?

We're using Quarkus extension 3.18.1, and we observed DnsNameResolverTimeoutException occasionally. We have a lot of k8s pods connecting to AWS Elasticache cluster. We'd like to try to tune the concurrency level of SequentialDnsAddressResolverFactory as suggested in #4577.
Is it possible to configure the concurrency level of SequentialDnsAddressResolverFactory in Quarkus extension?

I'm afraid no. You need to create a subclass of SequentialDnsAddressResolverFactory  and specify it in config


Add a native SwiftUI button

This change adds a native SwiftUI button, and seeks to provide further native Swift support (#49).
This PR will also lay the foundation for more Swift-specific development by establishing a separate library.

Look into using the --include-podspecs flag for pod lib lint for loading the GoogleSignIn podspec from the local repo.


Phantomjs install failed on arch linux

Expected behavior
Phantom should be succesfully install
Actual behavior
[user@pc tmp]$ sudo npm install phantom -g

><EMAIL_ADDRESS>install /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Download already available at /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Verified checksum of previously downloaded file
Extracting tar contents (via spawned process)
Removing /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1529376414558/phantomjs-2.1.1-linux-x86_64 -> /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt/lib/phantom
chmod failed: phantomjs was not successfully copied to /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!
What happens without -g?
Sent via my iPhone

On Jun 18, 2018, at 7:51 PM, foi<EMAIL_ADDRESS>wrote:
Expected behavior
Phantom should be succesfully install
Actual behavior
[user@pc tmp]$ sudo npm install phantom -g

<EMAIL_ADDRESS>install /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt
node install.js

PhantomJS not found on PATH
Download already available at /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Verified checksum of previously downloaded file
Extracting tar contents (via spawned process)
Removing /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1529376414558/phantomjs-2.1.1-linux-x86_64 -> /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt/lib/phantom
chmod failed: phantomjs was not successfully copied to /usr/lib/node_modules/phantom/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-06-19T02_46_59_401Z-debug.log
Steps to reproduce the behavior
sudo npm install phantom -g
Environment
OS: Manjaro Gnome testing
Node version (node -v): 10.4.1
package version: latest
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@amir20 it's works. Thank you


measure performance

Now that we can run basic pods in kube we'll need some sort of benchmarks from kube e2e density to gather info such as how many pod per min, pod per node and whatnot. Let's leave this open for anyone to contribute

@jeremyeder team is beginning to look at this.

JFYI @sjug we can report data back here once we've run tests and reviewed internally.

I think @sjug runs these regularly.  I am closing this issue.


Ungap the Map ideas

add a count of businesses along the route
add some idea of directness / ease of wayfinding

@hussein-mahfouz

Some notes I had on route directness (based on conversations with you and @juanfonsecaLS1:

more turns leads to cognitive overhead. Direct paths are preferable for cyclists
BUT we can have a straight path that is much longer than the shortest path
we want a metric that combines path length with number of turns to get a perceived shortest path

Calculating number of turns
1. Change in Bearing
Paper: Turn calculations for the indoor application of the fewest turns path algorithm
Figure 2 shows a basic turn calculation algorithm. It calculates the angle between 3 consecutive nodes, and if it is above a defined threshold then we have a turn
2. Number of options at Node / Intersection
From a wayfinding perspective, we should only consider it a turn if it is a node/interestion with more than one allowable turn
Using number of turns to calculate perceived route length
Paper: The role of turns in pedestrian route choice: A clarification
"Based on prior findings from pedestrian path choice studies, we can state that the “perceived” length of a route (c) depends both on the route's objective length (l) and the number of turns along the route (t), such that c = l + σt, where σ is a scaling factor that standardizes turns into distance equivalent units. We can additionally denote paths that are perceived to be shortest between a given origin and destination in terms of both distance and turns combined as i =  min (c), and paths that are simply shortest in terms of distance alone as j =  min (l). For any pedestrian origin-destination pair in a street network, we can thus examine whether the shortest objective route j also happens to be the shortest perceived route i, or whether alternatives exist where a lower perceived length (c) can be found on different routes, which may include fewer turns than the shortest length route j. We can quantify the difference in perceived length (c) on both the objectively shortest distance route j and the shortest available perceived length route i by a score z, such that z = (c(j) − c(i))/c(j). In other words, z describes how much (in percentage terms) the “perceived” length of the route can be reduced from the shortest objective route by using an alternative route that involves fewer turns."
"To factor in a distance- equivalent penalty for each turn (σ), we used the estimated distance- equivalent effects for turns by Sevtsuk et al. (2021), who reported one turn to be equivalent to 62.3 m in San Francisco."


Add "Open with Codeanywhere" badge to README.md

Why?
With Codeanywhere, devs and contributors can:

Instantly launch a cloud or local IDE with remote dev environment.
Automatically set up and configure a remote dev environments if a devcontainer.json file is present.

Benefits:

Faster onboarding for new contributors.
Consistent and ready-to-use development environments.
Flexibility to work in the cloud or locally.

Sadly registration is there to fight off malign users. Anyway, mroe options is always better, for example user can hit limits with available hours on other services. And also, Codeanywhere has GPUs. But, yes, Codespaces could also be added.


net/can: Save simple options to socket_conn_s

like other protocols(e.g. ip, tcp, udp)
Change-Id: Ia62558272c4a41178d3ed176bb19d32cb6d4969a
Summary
Impact
Testing

[Experimental Bot, please feedback here]
No, this PR does not meet the NuttX Requirements.
Missing Information:

Summary: The provided summary is too vague. It doesn't explain the purpose of the change, what code is being modified, or how it works.
Impact:  All impact sections are blank. The PR needs to describe the potential consequences of the changes on users, the build process, hardware, documentation, security, and compatibility.
Testing: The "Testing" section lacks specific details. It needs to include:

The operating systems, CPUs, and compilers used for the build host.
The target architectures, boards, and configurations used for testing.
Actual testing logs before and after the change, demonstrating the issue and the fix.

To meet the NuttX requirements, the PR should provide comprehensive information in each of the required sections.


What are the benefits to upgrade from v2 to v3

Hi all,
We are using @sap-cloud-sdk version 2 in our applications, and we received warning log to recommend us to upgrade to version 3.
I am always interested in catching up with latest stable version, but I need some strong reasons to convince my teammates that we should upgrade. However, after go through the upgrade guide, I didn't find any content regarding why we should upgrade to version 3, it's definitely not convincible just because v2 is no longer actively maintained, can you guys kindly help give some benefits? (and I do think add WHY section in upgrade guide is really helpful)

Hi @1993hzh,
thank you for your feedback, I agree that we should add a WHY section to our upgrade guide and will bring this up to the team.
Here is a rough list of benefits for upgrading to version 3.

First and foremost: Our new resilience package, which enables you to build different resilience middlewares into your application with ease
Support for the latest node LTS version
Aligned APIs between our odata and openapi clients and generators
A cleaner API, meaning better documentation, naming of variables, and removal of redundant functionality
Last but not least, our support in case you face issues or find bugs in the future

I would add one more point to @tomfrenken 's list:

dependency updates, which helps reduce the risks of vulnerabilities. Of course, as a consumer, you can also manage transitive dependencies by your own, but some users prefer centralised fix (security incident) instead of doing it by their own.

Please check our release policy here.


Publish "winthing/system/online" before suspend or hibernate

Should'n winthing publish a "winthing/system/online:false" message just before the suspend or hibernate command is executed?
Ideally it would also publish this when the system is suspended by other means than an MQTT command ;-)
And it would be great if it also could publish a "winthing/system/online:true" after resuming from suspend or hibernate.

This is done automatically by connection management and MQTT broker: https://github.com/msiedlarek/winthing/blob/4358cdbafcc07c5a3c7ef404e57bbafae9804090/src/main/java/com/fatico/winthing/systems/system/SystemController.java#L25-L40


dbmate: 1.16.2 -> 2.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/amacneil/dbmate/releases.
meta.description for dbmate is: Database migration tool
meta.homepage for dbmate is: https://github.com/amacneil/dbmate
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.1 with grep in /nix/store/43w4rbs1ld9yj9a3xwy5hi5q8fgyj5gm-dbmate-2.0.1
found 2.0.1 in filename of file in /nix/store/43w4rbs1ld9yj9a3xwy5hi5q8fgyj5gm-dbmate-2.0.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dbmate

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/43w4rbs1ld9yj9a3xwy5hi5q8fgyj5gm-dbmate-2.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dbmate https://github.com/r-ryantm/nixpkgs/archive/66b05cfb9a00cfd8ec246e9591d5afbea7adca2e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/43w4rbs1ld9yj9a3xwy5hi5q8fgyj5gm-dbmate-2.0.1
ls -la /nix/store/43w4rbs1ld9yj9a3xwy5hi5q8fgyj5gm-dbmate-2.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dbmate

Maintainer pings
cc @manveru for testing.

Result of nixpkgs-review pr 219984 run on aarch64-darwin 1

1 package built:

dbmate


BUG - Load Preset doesn't work

Does the issue occur in the electron-app or the web-app?

[x] midi-bricks-electron
[ ] midi-bricks-web-app

Can you determine, which version was used?
Version: 1.2.5
Describe the bug
The app doesn't load my preset, which was created under 0.14.7 and still was loaded under 1.1.8x
Steps To Reproduce
Steps to reproduce the behavior:

Load a preset
Nothing happens after loading.

Expected behavior
Load preset ;)
Desktop Version (please complete the following information):

OS: Win10

As it seems to me, the app does not like js files anymore. But JSON does work here fine. Would you try to rename your preset to json? Does that work?

I renamed my preset file from .js to .json, but this doesn't work as well :(

Please send me your preset via dropbox!

I found a way to load old presets. Should be fixed with 1.2.8: https://github.com/TimSusa/midi-bricks-mono/pull/152 would you please try?

Loading old presets works fine in 1.2.8.
Both work: .js and .json


Possible issue reading cpil field from m4a tags.

Reproducer
Repo for reproduction is here:
https://github.com/milesegan/lofty-aac-compilation-bug
Summary
There seems to be an error reading the cpil compilation flag field from m4a tags. In the sample file the value is 1 but the tag reads as 0.
Expected behavior
No response
Assets
No response

It seems like maybe the issue is here?
https://github.com/Serial-ATA/lofty-rs/blob/79336cd3048985cc7bb6c99600311e5c6bb837eb/lofty/src/mp4/ilst/read.rs#L123-L126
When I read the tag the content is [0, 0, 0, 1] which gets parsed as false. Maybe an endian issue?


Compilation error: cannot find -lipasircryptominisat5

When compiling pandaPIengine, I encountered the following issue (after Linking CXX executable pandaPIengine seemed to be successful):

/usr/bin/ld: cannot find -lipasircryptominisat5
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/pandaPIengine.dir/build.make:221: pandaPIengine] Error 1
make[1]: *** [CMakeFiles/Makefile2:257: CMakeFiles/pandaPIengine.dir/all] Error 2
make: *** [Makefile:84: all] Error 2

I tried to compile pandaPIengine with -DSAT=ON. The error occurred both on WSL and native Ubuntu.
My build configuration/environment was (on both systems):

20.04.2
gcc version 9.3.0
make 4.2.1
cmake 3.16.3
gengetopt 2.23

It seems that cryptominisat is not properly built during the build process. This is not an issue, if the shared library crpytominisat.so can already be found on the machine (typically under /lib or /urs/lib). If, however, one has no root access, what worked for me is to place the .so file at some directory /dir/subdir I have access to and add it temporary to the PATH via export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/dir/subdir.


updated README to use mamba, added pip to env

https://github.com/ProjectPythia/kerchunk-cookbook/issues/26

Thanks Raphael! FYI I asked about whether the Pythia leaders are concerned about consistency between cookbooks in terms of environment instructions in https://discourse.pangeo.io/t/mamba-mature-enough/3154/8, so we should wait for a response before merging this.

I think based on https://discourse.pangeo.io/t/mamba-mature-enough/3154/9 we can merge this - thanks again Raphael!


[ConstraintSystem] Fix crash on function conversion reliant on conditional conformance

This PR fixes a compiler crasher related to a function conversion reliant on conditional conformance. Example:
protocol P {}
struct S<T> {}
extension S : P where T : P {}

func foo(_ fn: (S<String>) -> Void) {}
func bar(_ fn: (P) -> Void) {
  foo(fn)
}

Resolves SR-10992.

cc @xedin

@xedin Do you mean you want the exact same method in FailureDiagnostic as well (which would then internally call CS.getConstraintLocator(anchor, path, flags))?

@theblixguy Yes, I think it could be done separately but it would make sense to call it on FailureDiagnostic instead of current indirect way. At least it would be great to audit where summaryFlags is set to 0 at the moment and change that here.

@xedin Okay, I have added it to FailureDiagnostic! Found two more uses of summaryFlags being 0 which I removed.

@swift-ci please test

@swift-ci please test

@swift-ci please test

All tests have passed! I'll cherry pick this to 5.1 if that's okay?

@theblixguy Sounds good, thanks!


New version: CiderCollective.Cider.Nightly version 1.5.4-beta.10

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

closing, i placed it in the wrong directory


Ability to use own session save handler

This is a new feature that allows you to use your own session save handler.
See: http://php.net/session_set_save_handler
To use, you need the following:

The handler class must implement the interface Zend\Expressive\Session\SessionHandlerInterface
The class must be added to the container configuration as a factory or invokable.

return [
    'dependencies' => [
        'factories' => [
            \Zend\Expressive\Session\SaveHandlerInterface::class => MyOwnSaveHandler::class,
        ],
    ],
];

If the above are correct, it will use your own session save handler

Hello @batumibiz,
this should be addressed in https://github.com/zendframework/zend-expressive-session-ext, i.e. in the persistence package that deals with php-ext-session where a save-handler (default is files) (implementing SessionHandlerInterface) is actually used. This package is persistence agnostic, or better, it delegates the persistence matter to subpackages or third-party packages.
kind regards

Agreed with @pine3ree . As an example, zend-expressive-session-cache would not make use of this, as it is specific to ext-session.

Thank you, I agree with you


Verify email with app

Describe the feature you'd like
Add the content provider to receive URL and send the token to the server to verify email.
Would you like to work on the issue?

[x] Yes
[ ] No
Other:

No endpoint on the server. Issue: https://github.com/fossasia/open-event-server/issues/6038
Eventbrite is using it already.


Closing the terminal?

Ctrl-C doesnt close the terminal, found that Ctrl-D closes it but that too doesnt seem to work.
How do I close the terminal? :D

Yes, Ctrl-C does not close the prompt like it does not close bash shell.
But Ctrl-D closes thee prompt if the buffer is empty.
I guess you pressed Ctrl-D after input something characters.
>>> <Ctrl-D> # then prompt will be closed.

>>> input something values<Ctrl-D> # then prompt won't be closed because the buffer is not empty.

These behaviors are the same with bash shell.
Let me close this issue. If Ctrl-D doesn't work even if the buffer is empty. I'm welcome to file a bug report.


feature request : download last x number of claimed e-books

Could you add a parameter so that we can download last "x" number of claimed e-books? (e.g. last 10 claimed e-books)
I'm a Python newbie, I couldn't do it.
Thanks

hello!
I think such feature is not very needed or even convenient to use.  The books are already being downloaded in such order (from last claimed to the oldest ones) If you really need this you can easily check when nrOfBooksDownloaded  variable is bigger than 10, then finish it. Best regards!

I didn't know that variable exists. That should do the trick. Thanks.


Convert Unit

Issue #36

Hold on a second. Something went wrong with the PR. Lemme commit the code again.

Oh wait.. the commits merged with the previous PR. Aight give me a sec. I'll make some changes.

There ya go. Most of the code went with the PR #35. Added some changes so that this PR is valid.

@Subhradeep10 any updates on this PR?


Use edge RuboCop for internal_investigation task

This configuration reproduces internal_investigation task of rubocop-hq/rubocop repo.

Thanks for checking this out.
I feel it's best not to add rubocop as a dependency to be sure that rubocop-ast is well self-containted.
Bundler setups all dependencies so it would be hard to detect if the rubocop-ast gem was actually requiring some code from the main rubocop gem. Specs would pass, but the gem wouldn't actually be self contained and anyone requiring just this gem could have their code crash...

Ah... sure! rubocop-ast will be a widely used gem outside the RoboCop core. I misunderstood this gem as part of RuboCop 💦 Thank you for gemify and explanation!

😆  Not sure it will be widely used outside of RuboCop, but the goal is that it can be used separately 😸
I will add a note in the gemspec and Gemfile.


Configure load balancer for GCP deployment

See: https://cloud.google.com/load-balancing/docs/https/setting-up-https-serverless

Closed it as we are not planning to support GCP in short-term. And when we do - likely we'll file new issues based on AWS configuration.


Raspberry Pi IP "Unknown"

Please provide the following information:

OS: Ubuntu 22.04
ROS Distro: Humble
Built from source or installed: installed
Package version: Don't recall

Expected behaviour
ssh into Raspberry Pi once connected to network
Actual behaviour
Our university wifi was problematic in getting the Turtlebot4 to connect. I assigned the bot to a wifi network, got an IP for the Raspberry Pi, but the university network wasn't allowing the robot to connect. Needed to update wifi connection, but any attempt to get back into the Pi failed. Hard wired into raspberry pi to ssh and change wifi, did it successfully, but it still wouldn't connect. After many attempts and a restart, Raspberry Pi now reads "Unknown" IP and I can't ssh. I suspect I need to reset the raspberry pi to put on a new network I have setup that doesn't have nearly the restrictions that the university wifi has.
To Reproduce
Provide the steps to reproduce:
Tough to do because of how many attempts I did to try to get the bot to connect to the various networks.
Other notes
If I can't ssh I am dead in the water. My knowledge of networks is not robust.

Hello @EMWetzel
You need to check your Internet(WiFi), speed.
This means you need to connect the TB4 with 5.0GHz, then this issue will be resolved,
I think you have a 2.4GHz Wifi Connection that's why it shows an "Unkwon" IP address.
Hope it will resolve your problem.
thank you

@EMWetzel If you are unable to SSH in over ethernet, you can either try to connect a micro HDMI to the RPi and use a keyboard and monitor to log in and change the networking, or re-flash the SD card with the latest image. Instructions for flashing are available here.

I have reimaged the sd card, but I am still getting the "Unknown" error when I reinsert and restart the bot. I assumed reimaging would take me all the way back to the start - is that not the case? Do i need to clear the sd card before reimaging?

@EMWetzel Are you able to SSH into the RPi4? If so can you check the turtlebot4 service logs with sudo journalctl -u turtlebot4 -r?

I have the same problem as OP and am unable to ssh into the Pi. Did you find a solution to this problem?

@HyydenJakcz It is not clear to me which part of this issue that you are running into. These sorts of issue are generally user error and can have many many different sources based on the specifics of what a particular user has done.  Can you please open your own issue and give us the full details on what you have done and where you started to encounter issues? I can help you troubleshoot it there. If your issue is that the robot won't turn on properly after flashing the sd card then most commonly it means that the sd card was not flashed properly. If your issue is being unable to ssh in then there are several different possible causes including misconfigured networking, improper sd card flashing, or the raspberry pi having its power disconnected.

Got this issue fixed. That said, I ran updates to the Raspberry Pi (as is stated in the documents), and now the robot wont start up correctly. Only the light ring, no screen, no lights, and the raspberry pi has red lights inside the bot.

how did you manage to solve the Unkown IP@ for the RPi, i put wrong credentials for my wifi, so i connected the RPi to the laptop via ethernet, and i tried to ssh into the rpi but they are requesting a password that i'm confused about. what password should i put? the default rpi password doesn't work

@hilary-luo , you were right. I am new to using raspberry Pis and Linux so I did it incorrectly. It works fine now.

@hilary-luo , you were right. I am new to using raspberry Pis and Linux so I did not flash the SD card correctly. It works fine now after reflashing it correctly.

@HyydenJakcz i am also a beginner, and i see that you ran into my problem. I put wrong wifi credentials (i think) and i got unkown ip@, i connected my rpi to my laptop via ethernet, but i cannot ssh because i dont know what password they want. do you have any suggestions?

@judyakl I believe your problem is different. When you ssh in across the wired connection you need to use the turtlebot user credentials. These are easily confused with the access point credentials but are not the same. The credentials are listed here: https://turtlebot.github.io/turtlebot4-user-manual/setup/basic.html#ssh-into-the-raspberry-pi , the only difference being that if you are connecting over the ethernet connection then you will use the ethernet port IP address as listed here https://turtlebot.github.io/turtlebot4-user-manual/setup/basic.html#recovering-the-raspberry-pi.
In summary, you should be able to ssh using the password turtlebot4 and then use the turtlebot4-setup tool again to fix the wifi credentials.

@hilary-luo thank you for your reply! i've been trying to follow the links for several days now but i'm getting "no route to host" error, according to the setup webpage i might need to work on the rpi's sd card. i hope i figure it out before i do that though

@judyakl I don't know where you are located, but I am at a university with wifi that has a number of secondary password requirements. Two factor authentication and Turtlebot don't mix well. I ended up just getting a hotspot for the bot, reflashing the sd (mmcblk0, not SDA), and then entering the single UN and PW. A couple of troubleshooting things I went through. Initially the bot should be really close to the computer and controller it is connecting to and the wifi signal should be strong between the two. Startup takes longer than you would expect for all 5 LEDs to shine green. I had trouble with the controller they sent and had to go buy a separate PS4 controller. I started with the youtube video setup because I figured that would be easier, but it never worked for me. I moved over to Github and got it after the university wifi debacle. Because I stated with the youtube video, I removed the Cyclone DDS line from the .bashrc before doing the Github setup because that is not in there.
All of this to say, if you are still having trouble with setup, the easiest thing to do is to start fresh. Pull the SD, reflash, and start over.

@EMWetzel that's what i'm gonna do. i will sadly start fresh as well. i will pull the SD, reflash and do everything all over again. maybe i should've thought of the university wifi security before connecting but it never crossed my mind. thank you for replying!

This issue is being closed due to inactivity. If you are still experiencing the issue, feel free to reopen this ticket when you are ready to continue the troubleshooting process.


Summary qlevels ilevels

Hi Vincent,
I detected an issue in g.analyse. If you look at the summary data frame, you can see how the weighted percentiles (qlevels) and distribution of acceleration (ilevels) are only calculated for the last metric selected. This is because the keepindex_46 and the keepindex_48 variables store only the last indices, when the loop runs, the new values overwrites the previous ones. Here keepindex_46 and keepindex_48 are two matrices that store the indeces for each metric, so we can run a loop to calculate qlevels and ilevels for all the metrics selected.
I have tested it in some files and it works well.

Codecov Report

Merging #19 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #19      +/-   ##
=========================================
- Coverage    2.57%   2.56%   -0.01%
=========================================
  Files          49      49
  Lines        7504    7510       +6
=========================================
  Hits          193     193
- Misses       7311    7317       +6

Impacted Files
Coverage Δ

R/g.part1.R
0% <ø> (ø)
:arrow_up:

R/g.analyse.R
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d94e58...dd85f26. Read the comment docs.

thanks Jairo, I aim to review your changes next week and then merge it


Added support for lightning module

Thank you for contributing to Nuitka!
!! Please check that you select the develop branch (details see below link) !!
Before submitting a PR, please review the guidelines:
Contributing Guidelines
What does this PR do?
Adds support for the lightning module by including the missing version.info file
Why was it initiated? Any relevant Issues?
The lightning module is not currently able to be used after being built by nuitka
PR Checklist

[x] Correct base branch selected? Should be develop branch.
[x] Enabled commit hook or executed ./bin/autoformat-nuitka-source.
[x] All tests still pass. Check the Developer Manual about Running the Tests. There are GitHub
Actions tests that cover the most important things however, and you are welcome to rely on those,
but they might not cover enough.
[x] Ideally new features or fixed regressions ought to be covered via new tests.
[x] Ideally new or changed features have documentation updates.

I decided to make this PR in order to address my issue with the lightning module and enable other users to be able to use the module as well. I have based my fix on the discussion on this thread and merged PR
Add support for pytorch-lightning

This is the error I get without the fix:
(nuitka_env) [user@spark-devops-shell-rhel8 test_nuitka]$ ./__main__.dist/__main__.bin  Traceback (most recent call last):   File "/home/user/test_nuitka/__main__.dist/__main__.py", line 3, in <module>   File "<frozen importlib._bootstrap>", line 1178, in _find_and_load   File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 690, in _load_unlocked   File "/home/user/test_nuitka/__main__.dist/lightning/__init__.py", line 17, in <module lightning>   File "<frozen importlib._bootstrap>", line 1178, in _find_and_load   File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 690, in _load_unlocked   File "/home/user/test_nuitka/__main__.dist/lightning/__version__.py", line 8, in <module lightning.__version__> FileNotFoundError: [Errno 2] No such file or directory: '/home/user/test_nuitka/__main__.dist/lightning/version.info'

Thanks, this will likely make it to the next hotfix due this weekend.


Index signature of object with type list of properties

TypeScript Version:  2.0.7
After set the noImplicitAny option to true in tsconfig.json, I get an "Index signature of object type implicitly has an 'any' type" even if I define the exact list of index key.
Code
type HttpMethod = 'get'|'post'|'head'|'put'|'patch'|'delete'|'options';
interface IRouter {
    get: (path: string, callback: any) => {};
    post: (path: string, callback: any) => {};
    head: (path: string, callback: any) => {};
    put: (path: string, callback: any) => {};
    patch: (path: string, callback: any) => {};
    delete: (path: string, callback: any) => {};
    options: (path: string, callback: any) => {};
}

let router: IRouter;
let method: HttpMethod = 'post';

router[method]('foo', () => {});

Expected behavior:
As I define all properties that could be used dynamically, I expect that tsc can work with these values:
> tsc
>

Actual behavior:
> tsc
Index signature of object type implicitly has an 'any' type

Thank you.

This works as you expect in the current nightly builds. It was fixed as part of #11929.

Wow! Amazing!
My bad, I don't use correct keyword to find this issue.
Great, I'm waiting for the new release, thank you :)


disable LTO for CI

https://github.com/RustPython/RustPython/issues/1978#issuecomment-1207262094

for compile time improvements? Do you remember?

Yes, it was. But it needs measurements if it actually reduce CI time or not.


el.insertAdjacentHTML is not a function

When trying to load the card. (Using your example code) it keeps giving the el.insertAdjacentHTML is not a function error.

Linking the original card library as script fixed it.

Yeah, of course you need original card.js :)

@arnoabraham what do you mean Linking the original card library ?
The el.insertAdjacentHTML is already from the original card library so you had it linked ...
(I'm just saying b/c I have the exact same problem and can't figure out a way to fix it)

@refaelos as I understood, he forgot to include js from https://github.com/jessepollak/card

To be able to work, you need both card/card.js and angular-card/card.js

You need to load the original card.js library first and than the angular-card.js. If you only load angular-card.js it won't work.

@gavruk @arnoabraham This error is coming from card.js so it's linked already.
see the stack:
TypeError: el.insertAdjacentHTML is not a function
    at Function.QJ.append (http://localhost:9000/bower_components/card/lib/js/card.js:1646:13)
    at Card.render (http://localhost:9000/bower_components/card/lib/js/card.js:1795:8)
    at new Card (http://localhost:9000/bower_components/card/lib/js/card.js:1788:10)
    at link (http://localhost:9000/bower_components/angular-card/src/card.js:82:9)
    at http://localhost:9000/bower_components/angular/angular.js:8783:44
    at invokeLinkFn (http://localhost:9000/bower_components/angular/angular.js:8789:9)
    at nodeLinkFn (http://localhost:9000/bower_components/angular/angular.js:8289:11)
    at compositeLinkFn (http://localhost:9000/bower_components/angular/angular.js:7680:13)
    at compositeLinkFn (http://localhost:9000/bower_components/angular/angular.js:7684:13)
    at compositeLinkFn (http://localhost:9000/bower_components/angular/angular.js:7684:13)

Can you show me what version of angular, card and angular-card you have installed?

Sure.
"angular": "1.4.7"
"angular-card": "~0.3.4"
card is actually a dependency in angular-card so it fetches it automatically. Looking into your bower.js it looks like you're fetching card: >=1.1.0

Looks like it fetched card#1.2.2

Will be great if you can provide a simple html/js that reproduces this issue. Because I cannot reproduce

I wish I could :) It's deep inside the angular app. Do you want to remote control my machine and take a look?

Can you just paste the parts where you:

include card.js and angular-card.js
define a form for card
You can also try to update angular-card to v0.3.5 and re-install bower modules, but I don't think this will help

I include card.js and angular-card.js using lazyloading.

            {name: 'angular.card',               files: ['bower_components/card/lib/js/card.js',
                                                        'bower_components/angular-card/src/card.js'], serie: true}

The form is exactly like the example:

<form
          name="cardForm"
          data-card
          data-width="500"
          data-card-container="#card-container"
          data-placeholders="lookalikes.cardPlaceholders"
          data-options="lookalikes.cardOptions"
          data-messages="lookalikes.cardMessages"
          class="form-horizontal">

        <input placeholder="Card number" type="text" name="CardNumber" card-number data-ng-model="card.number" />

        <input placeholder="Full name" type="text" name="CardName" card-name data-ng-model="card.name" />

        <input placeholder="MM / YYYY" type="text" name="CardExpiry" card-expiry data-ng-model="card.expiry" />

        <input placeholder="CVC" type="text" name="CardCvc" card-cvc data-ng-model="card.cvc" />

        <input type="button" value="Change card" data-ng-click="changeCard()" />
        <input type="button" value="Clear" data-ng-click="clear()" />

    </form>

I'll try to update.

You can also try to clone https://github.com/gavruk/angular-card, run bower install and then open example/example.html to see if it works for you.
Maybe the issue is with lazy loading

Finally I got it... I didn't set the card-container correctly. I didn't have the div that correlates that variable.
Sorry for the hassle guys. Thanks!

@refaelos great that you solved this. This will help people who will have this issue in future :)

Hi,
getting the same error when using modal panel with ui.bootstrap.modal
Moving it to normal container (not modal) works perfectly.
Is this an known issue?
best regards Ivan

@ivanstojkovicapps  did you fix that modal's issue? I'm have the same problem here.

For the sake of future mistake-makers:
If your container is under ng-if (and evaluated falsy) at the time the form (or new Card) was called, it will yield the above error as the container element isn't present on the DOM.
quick solve - change to ng-show 👍


⚠ Bofrost.at has degraded performance

In 443b258, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1490 ms

Resolved: Bofrost.at performance has improved in cd9e61c.


admin: TimelockController

The operator will send tx to the ProtocolHandler through a Timelock controller from OZ
It needs to be deployed.

The security council will have the CANCELLER role
The operator will have the PROPOSER and EXECUTOR role
Ensure there is NO ADMIN / NO OPEN ROLE

OZ contracts are not yet audited

to fix your trouble check this solution click
maybe this will solve your problem.


support HttpResponse to get response headers

for #83 .
Add HttpResponse return type support to get http response headers.

rebase to current master, thx

Thanks a lot for your PR, @soundTricker, and sorry for such a long time it took me to get to you.
I fully understand you motivation and agree to have it there, yet have a comment to your implementation.
Please, could you create a mechanism to have either:

current JSON-data result (so it was also backward compatible),
full result (not limited to observe: 'response'),

Plus

not generating that much additional code (I believe a couple of lines could make it),
still staying fully type-safe (aware).

I would suggest adding an optional parameter with default value leading to what we are getting now.
Thanks.


Update react-router-dom to v6

Is your feature request related to a problem? Please describe.
At this moment, the react-router-dom dependency is at v5.  Sometimes, I get an error on vercel deployment because of the useHistory hook import, despite it shouldn't be a problem in v5:
../../node_modules/beautiful-react-hooks/esm/useQueryParam.js
Attempted import error: 'useHistory' is not exported from 'react-router-dom' (imported as 'useHistory').

Describe the solution you'd like
It would be nice to update the react-router-dom dependency to v6, changing the useHistory hook to useNavigate: https://github.com/remix-run/react-router/blob/main/docs/getting-started/tutorial.md
Describe alternatives you've considered
N/A
Additional context
N/A

@carlosrsabreu hi Carlos, thanks for opening this issue...
useQueryParam is build to provide a state-like functionality to change the URL query parameters in react-router-dom version 5.
In react-router 6 this can easily be archived by simply using useSearchParams from react-router-dom, please read the documentation here
For this reason is pointless to update react-router-dom to version 6

If you're using vite and you run into this issue like so:
'useHistory' is not exported by ../node_modules/react-router-dom/index.js, imported by node_modules/beautiful-react-hooks/esm/useQueryParam.js
file: /Users/cymen/dev/surge/gondor/component-library/node_modules/beautiful-react-hooks/esm/useQueryParam.js:2:9
1: import { useCallback, useRef } from 'react';
2: import { useHistory } from 'react-router-dom';
            ^
3: import useDidMount from './useDidMount';
4: import useURLSearchParams from './useURLSearchParams';

The solution is to do as the README examples show and import the hooks like so:
import useGlobalEvent from "beautiful-react-hooks/useGlobalEvent";

Instead of:
import { useGlobalEvent } from "beautiful-react-hooks";

Using @cymen workaround works, yet my IDE complains, so it's a bit annoying 😕


Image-builder and ansible incompatibility

Trying to run the image-builder utility to create the ubuntu OVA.
I have installed ansible using
python3 -m pip install --user ansible
which defaults to ansible version 9.5.1 and ansible-core-2.16.6
Upon running the image-builder utility, it errors out saying
The version of ansible-core (ansible [core 2.16.6]) does not match the version (2.15.9) which has been tested by the EKS-A team.  (Recommened) Remove this version and rerun your image build and the correct version of ansible-core will be installed.
So I uninstalled ansible-core using pip uninstall ansible-core and re-ran the image-builder utility
Now ansible errors out stating ansible version 9.5.1 requires ansible-core-2.16.6 and ansible-core-2.15.9 is incompatible.
Can you please ensure a clarity of the exact version of ansible to be installed such that it satisfies the EKS-A validated procedure for latest version Image-builder

Hey @thecloudgarage, can you please provide the following information?

OS version of the machine on which image-builder is run
EKS-A version used to download the image builder CLI
Image builder version
Python3 version
Ubuntu version for which the OVA is built (20.04 or 22.04)
Release channel when running the image builder CLI

OS version of the machine on which image-builder is run: ubuntu 20.04
EKS-A version used to download the image builder CLI: v0.19.5
Image builder version: v0.4.0
Python3 version: 3.10.12
Ubuntu version for which the OVA is built (20.04 or 22.04): 20.04
Release channel when running the image builder CLI: 1-29

I managed to get it done using a workaround by exporting the variable EKSA_SKIP_VALIDATE_DEPENDENCIES=true. Thereafter the image-builder rendered a successful image.
However, this issue and incompatibility is not adequately documented and neither is this workaround. EKS-A has been validated with ansible-core which is 2.15 and is only compatible with ansible 8.x which is now in an Unmaintained (end of life) after Ansible 8.7.0.

@thecloudgarage ,
We run into the same problem. A "better workaround" is to install the proper version. In our case it was the following on our Ubuntu 22 based build host:
sudo apt install python3-pip && python3 -m pip install --user ansible==8.7.0 ansible-core==2.15.9
export PATH=$HOME/.local/bin:$PATH

Since then there were some version update of EKS-A so you may need to adjust the versions in the command...

Hello @thecloudgarage,
We align with the version of Ansible that upstream image-builder checks for in the preflight script. This is true for all other tools such as Packer, goss, etc. These are the versions we build and test in CI, and hence we have a validation that image-builder CLI users also use the same build toolchain. Hence, as @Cajga says, we highly recommend to use these versions to build your images.

Request you to improve the documentation for custom image section where image-builder references are made.


Imputing features for inference sources

When imputing features for inference sources, we can either:
(1) always use the mean/median/KNN regression results for sources in the training dataset, or
(2) self-impute using stats computed from each batch of inference sources (usually 100,000 sources in a batch).
Option (1) has the advantage of a uniform approach for all inference fields/batches, but if there are significant discrepancies between the training and inference source populations, the imputed values may be inaccurate. Option (2) tailors imputation to the characteristics of each individual batch of sources at the cost of a less uniform approach. Our code can already support both approaches - which do you think is preferable @AshishMahabal, @mcoughlin?
(Regardless of the choice above, all features will be scaled using identical statistics to ensure consistency between training and inference).

(2) feels better, especially as I assume the batches will be in the same field and therefore similar parts of the sky.

I agree.

Thank you both!


FcosCriterion not found

Hi,
I was looking to try your model but I encounter an error: I was trying the model with config file "basictad_slowonly_e700_thumos14_rgb_96win_anchor_free.py" which in the train_engine employ the FCosCriterion.
The problem is that I cannot found that module inside the repository, can you help me please?
Thanks a lot!

Sorry for that, this problem is fixed.


Questions on the Tracking Protection Settings

During the testing period (today until Q3 2024) when the #test-third-party-cookie-phaseout flag is enabled, the Tracking Protection in the address bar will allow users to re-enable third-party cookies for 90 days on a given site.

Is the option to re-enable third-party cookies a one-off thing? What will happen after 90 days?
Is the expiration independent of the sites, in cases where multiple sites are allowed?

By Q3 2024, when third-party cookies are already deprecated, will the Tracking Protection still be available?

After 90 days the temporary exception created by that UI expires.  You can see the current exceptions and their expiry on chrome://settings/trackingProtection.
The UI in the address bar to create these exceptions is anticipated to remain beyond when third-party cookies are deprecated.  A deprecation timeline for it is TBD, but we don't reasonably expect every website to function without third-party cookies in Q3.

When the temporary exception expires, will there be an option to enable it again?

Yes, they can be recreated the same way again.  Permanent exceptions are also possible through the settings page.

Hi, @kgraney. Just a follow-up on my query above, thanks!

Hi @rdugenia

I tried adding a site manually to allow the use of third-party cookies, and it doesn't show an expiry date compared to the site that I allow by using the eye icon on the address bar.

I believe that's what @kgraney is referring to. As you say, you don't get an expiry date shown for sites added directly from chrome://settings/trackingProtection. That's intentional: the eye icon is to temporarily re-enable third-party cookies for a website, whereas chrome://settings/trackingProtection allows a user to set permanent exceptions from third-party cookie restrictions, for an entire domain.

Hi, @samdutton.
Thank you for the verification! In line with this, if we want to manually add a specific domain under chrome://settings/trackingProtection, is there a policy that needs to be configured or how can we apply this across multiple users? So that we don't have to update this setting per user.

is there a policy that needs to be configured or how can we apply this across multiple users

Two Enterprise policies that might be useful:

CookiesAllowedForUrls (and CookiesBlockedForUrls and CookiesSessionOnlyForUrls)
BlockThirdPartyCookies=false

Please also see this article intended for enterprise admins to prepare for third-party cookie phase-out.

Great! Thank you so much @kgraney, @samdutton, and @krgovind


What is the data format

i'm kinda of stuck here, and need some help in getting the tree displayed.

I did play with jstree first, and load the following data correctly. I know the only thing matters is the text and state, but I need the rest of data there for other purpose.
[
{
"created": "",
"name": "/",
"type": "directory",
"size": 0,
"children": [
{
"created": "1422994495000",
"name": "homepage",
"type": "directory",
"size": 136,
"children": [
{
"created": "1422994489000",
"name": "carasole",
"type": "directory",
"size": 68,
"children": [],
"text": "carasole",
"state": {
"opened": true
}
}
],
"text": "homepage",
"state": {
"opened": true
}
},
{
"created": "1422994495000",
"name": "others",
"type": "directory",
"size": 204,
"children": [
{
"created": "1422993066000",
"name": "bc",
"type": "directory",
"size": 68,
"children": [],
"text": "bc",
"state": {
"opened": true
}
}
],
"text": "others",
"state": {
"opened": true
}
}
],
"text": "/",
"state": {
"opened": true
}
}
]

I used the following line
             <div js-tree ng-model="treeData" tree-events="ready:treeReady;create_node:createNodeCB"></div>

and monitored the treeReady so that i know the tree is loaded

I know the treeData is there, because I can print it {{ treeData }}

however my tree is not displaying, so i wonder what i did wrong. Btw i didn't set any treeConfig. please help.

I checked the test, apparently this is the data format we used,
    scope.data = [
        { id : 'ajson1', parent : '#', text : 'Simple root node' },
        { id : 'ajson2', parent : '#', text : 'Root node 2' },
        { id : 'ajson3', parent : 'ajson2', text : 'Child 1' },
        { id : 'ajson4', parent : 'ajson2', text : 'Child 2' }
    ];

but i tried, it doesn't work either, so it might not be the data issue. I might not wire it correctly.
the behavior is the widget will spin for 1 sec, and then disappears like it didn't get any data.

Hi
Please create a plunker and share it, i will look at it there

ok, i couldn't manage to get plunker running with angularJS, but i did download the demo, and plugged in my data, and it worked, so i know there's something I did wrong.
one thing that i noticed is that you used (function(angular) { vs just
var app = angular.module("App");

ok, i finally get it working, the issue i had is the following.
app.controller('FileListController', function ($scope, $state, File, $modal, $window, $http) {
    $scope.treeData = [
        { id : 'ajson1', parent : '#', text : 'Simple root node' },
        { id : 'ajson2', parent : '#', text : 'Root node 2' },
        { id : 'ajson3', parent : 'ajson2', text : 'Child 1' },
        { id : 'ajson4', parent : 'ajson2', text : 'Child 2' }
    ];
    $scope.treeConfig = {
        core: {
            multiple: false
        },
        version: 1
    }
    $scope.$on('$viewContentLoaded', function() {
        // get directories
        $http.get('http://localhost:1337').success(function(data) {
            $scope.treeData = [
                { id : 'ajson1', parent : '#', text : 'Simple root node' },
                { id : 'ajson2', parent : '#', text : 'Root node 2' },
                { id : 'ajson3', parent : 'ajson2', text : 'Child 1' },
                { id : 'ajson4', parent : 'ajson2', text : 'Child 2' }
            ];
            $scope.treeConfig.version++;
        })

ok, if i set $scope.treeData at the beginning, it's working, but if i put it under a $http, the tree doesn't appear.
Then i try played with should-apply, doesn't work, and eventually i realized the trick is on version ++
        $scope.treeConfig.version++;

I believe everything is mentioned in the Documentation on the front page.

Yes, if you change the treeData object you should change the version and this will recreate the tree (destroy the element and create it again).

By the way, you can achieve this without recreating the tree. Declare all the configuration in an object, and provide an empty array for the treeData. Once your $http request is finished, push all the data that you need to the treeData array and don't replace its reference. This will work for sure, as this is the right way to use it.

i see, that's right, that's how it works with jstree directly. I'll try it and let you know.
FYI, currently, i don't declare a empty treeData initially, seems to me the tree only load once now after $http. Anyway, your approach might be most robust, since you never know what angularJS do before it reaches your http code.

H
jsfile.txt
i ezraroi,
modified in the way u suggested to make empty array and pushed the response data but it failed to create child nodes and gives error while trying to open a parent node.
treeCtrl: error from js tree - {"error":"nodata","plugin":"core","id":"core_05","reason":"Could not load node","data":"{"id":"ajson1"}"}
my config and data to load initial tree is like this.Given some initial data to populate tree because it is not creating any node in other ways.
vm.treeData = [
{ id : 'ajson1', parent : '#', text : 'Simple root node', state: { opened: false},children:true },
{ id : 'ajson2', parent : '#', text : 'Root node 2', state: { opened: false},children:true },
];
    vm.treeConfig = {
        core : {
            multiple : false,
            animation: true,
            error : function(error) {
                $log.error('treeCtrl: error from js tree - ' + angular.toJson(error));
            },
            check_callback : true,
            worker : true
        },
        types : {
            default : {
                icon : 'glyphicon glyphicon-flash'
            },
            star : {
                icon : 'glyphicon glyphicon-star'
            },
            cloud : {
                icon : 'glyphicon glyphicon-cloud'
            }
        },
        version : 1,
        plugins : ['types','checkbox']
    };

I am getting data from http service like this:
var promise = ravensService.getChildren();
I am calling the follwing function on "open_node" event of jsTree.But before this event i am getting above error :(
vm.openChildNode = function()
{
vm.treeData.push(data.data);
};
    promise.then(function (data)
    {
    vm.treeData = data.data;
    console.log(vm.treeData);
    });

I have tried all the stuffs and working on same from days but unable to find solution.I am using jsTree in Angularjs.Since i am new to this please help in this regard.Thanks in advance.PFA for Js.


[hyperclient] Logging

Browsers don't support colors in logging.

Disable in js or add add a way to disable loggin in HyperClient?

Will disable logging


Improve project:create (create) command

Hide timeout options in help
Wait and retry while fetching the project
Recommend the "get" command afterwards
Avoid fetching /regions twice

Looks great!


How "tamper" is represented in the "matter" specification？

"tamper" in the zigbee specification, the cluster id is 0x0500, but no similar cluster id is found in the matter specification, how does it solve the problem of tamper alarm?

The General Diagnostics cluster has an attribute ActiveHardwareFaults which contains TemperDetected.

Not an SDK issue.

@fuxiaoming-lumi thank you for your answer. When the "ActiveHardwareFaults" attribute is subscribed, the following code is called, but the attribute value reported to chip-tool is still empty. Why is this, and I hope to get your help again, thanks again?

And are you changing the value that GetActiveHardwareFaults() returns to reflect the new value?

@bzbarsky-apple , I don't think calling the GetActiveHardwareFaults() function has any effect, because its content does not return anything, and its code is as follows:
**_CHIP_ERROR DiagnosticDataProviderImpl::GetActiveHardwareFaults(GeneralFaults & hardwareFaults)
{
#if CHIP_CONFIG_TEST
ReturnErrorOnFailure(hardwareFaults.add(EMBER_ZCL_HARDWARE_FAULT_TYPE_RADIO));
ReturnErrorOnFailure(hardwareFaults.add(EMBER_ZCL_HARDWARE_FAULT_TYPE_SENSOR));
ReturnErrorOnFailure(hardwareFaults.add(EMBER_ZCL_HARDWARE_FAULT_TYPE_POWER_SOURCE));
ReturnErrorOnFailure(hardwareFaults.add(EMBER_ZCL_HARDWARE_FAULT_TYPE_USER_INTERFACE_FAULT));
#endif
return CHIP_NO_ERROR;

}_**

I don't think calling the GetActiveHardwareFaults() function has any effec

No, you need to implement GetActiveHardwareFaults to return the actual state of your device (in fact, you need to implement the entire DiagnosticDataProvider).  The code you are citing is from some default test-only implementation, which you should not be using in production.

@bzbarsky-apple thank you，I have implemented chio-tool to read the ActiveHardwareFaults attribute with a value of 10 (EMBER_ZCL_HARDWARE_FAULT_TYPE_TAMPER_DETECTED). I join the device to the Home pod mini. The Home app of the iPhone does not see the "Tamper" alarm, is it because the iPhone app does not yet support the "Tamper" alarm display?


fix(header): Added getting-started header and logos

Added getting-started header and OpenShift logos per latest mockups.
FYI, @jryhanyc @catrobson

There were the following issues with your Pull Request

Commit: a68d446e357de72256aa71807042ebf0ae96014b
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

@dlabrecq snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-979-fabric8-ui.int.rdu2c.fabric8.io


'assemble' task generates native-image if using GraalVM

If the user is running a GraalVM JVM, the task assemble will generate a native-image by default.
$ java -version
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (build 1.8.0_252-b09)
OpenJDK 64-Bit Server VM GraalVM 20.3.0-dev (build 25.252-b09-jvmci-20.2-b01, mixed mode)

$ ./gradlew assemble
> Task :compileJava
Note: Writing native-image.properties file to destination: META-INF/native-image/com.example/basic-app/native-image.properties
Note: Writing reflection-config.json file to destination: META-INF/native-image/com.example/basic-app/reflection-config.json
Note: Writing resource-config.json file to destination: META-INF/native-image/com.example/basic-app/resource-config.json
Note: Creating bean classes for 6 type elements
Note: /home/ivan/workspaces/micronaut-graal-tests/micronaut-basic-app/src/main/java/example/micronaut/httpclient/BintrayLowLevelClient.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :processResources
> Task :classes
> Task :runnerJar
> Task :buildLayers
> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip

> Task :nativeImage
[basic-app:104568]    classlist:   5,203.02 ms,  1.76 GB
[basic-app:104568]        (cap):     856.87 ms,  1.76 GB
[basic-app:104568]        setup:   3,106.86 ms,  2.05 GB
....

When the user uses a regular (non-GraalVM) JVM, then the nativeImage task is skipped:
ivan@nobita:~/workspaces/micronaut-graal-tests/micronaut-basic-app$ java -version
openjdk version "1.8.0_265"
OpenJDK Runtime Environment (build 1.8.0_265-b01)
OpenJDK 64-Bit Server VM (build 25.265-b01, mixed mode)

$ ./gradlew assemble
> Task :compileJava
Note: Creating bean classes for 6 type elements
Note: /home/ivan/workspaces/micronaut-graal-tests/micronaut-basic-app/src/main/java/example/micronaut/httpclient/BintrayLowLevelClient.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :processResources
> Task :classes
> Task :runnerJar
> Task :buildLayers
> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :nativeImage SKIPPED <--------
> Task :assemble

BUILD SUCCESSFUL in 2s
9 actionable tasks: 9 executed

As a user I wouldn't expect to get a native image as a result of running the assemble task even if I'm using a GraalVM JDK.
Keeping the Rule of Least Surprise in mind, I think is better to only generate the native-image when the user runs the nativeImage task and always generate the fatjar with assemble.

Totally agree with @ilopmar. I was very surprised when assemble and build tasks created long build with generation of native image.


unable to see any Authentication attempts

Hi,
In GPO I enabled the Audit Account Logon Events, Audit Account Management, Audit Logon Events, Audit Object Access, Audit Policy Change and Audit System Events but nothing coming trough...
It seems to show in the event log but is not populated on the dashboard

What log shipper are you using and version?


'glossgroup.element' and 'glossentry.element' are not contributed to the idElements pattern in their modules

Expected Behavior
In glossgroupMod.rng and glossentryMod.rng, the glossgroup.element and glossentry.element patterns are not contributed to the global idElements pattern.
However, these two elements do have ID attributes:
      <define name="glossgroup.attributes">
        <attribute name="id">
          <data type="ID"/>
        </attribute>

      <define name="glossentry.attributes">
        <attribute name="id">
          <data type="ID"/>
        </attribute>

Actual Behavior
They are missing. However, as evidenced by the presence of their element names in the glossgroup.rng topic shell, they should be included:
  <div>
    <a:documentation>ID-DEFINING-ELEMENT OVERRIDES</a:documentation>
    <define name="any">
      <zeroOrMore>
        <choice>
          <ref name="idElements"/>
          <element>
            <anyName>
              <except>
                <name>topic</name>
                <name>concept</name>
                <name>glossgroup</name>
                <name>glossentry</name>
                <nsName ns="http://www.w3.org/1998/Math/MathML"/>
              </except>
            </anyName>

Possible Solution
Update the two modules to add those elements to the idElements group.
Steps to Reproduce
Search the following OASIS files for 'idElements' and note that it is not defined:
./rng/technicalContent/rng/glossgroupMod.rng
./rng/technicalContent/rng/glossentryMod.rng

Environment
DITA-OT version 3.1.3, running in Windows 10 WSL (Ubuntu)

The update in #3617 includes the fix for this in the draft DITA 2.0 grammar files. As Eliot mentioned, there is not going to be an update to the DITA 1.3 grammar files, so we expect those to remain as they are now.

Fixed for DITA 2.0 grammars with #3617


Possible bug: tf.reverse() does not accept bool type 'dim' argument in r0.12

I think tf.reverse() got messed up in r0.12. Though the documentation says the argument 'dim' has to be 'bool', while running it complains -- "Value passed to parameter 'axis' has DataType bool not in list of allowed values: int32, int64". I can see that this comes from a new op -- tf.reverse_v2(). I saw that in r0.11 this runs with no complains. I have prepared a mwe for this (link provided below).
Either the documentation needs to be updated (for r0.12) or this needs to be fixed so that dims can accept boolean. I'd, rather, opt for a fix as this might be a reason for backward incompatibility in some legacy code.
Environment info
Operating System: Centos 7
Installed version of CUDA and cuDNN: cuda 8.0, cuDNN 5.1
If installed from source, provide

The commit hash (git rev-parse HEAD): e4dde23d58a10c9d0c14005d20d1ecdd599539ac
The output of bazel version - 4.2

If possible, provide a minimal reproducible example (We usually don't have time to read hundreds of lines of your code)
I have prepared a mwe for this (Just 26 lines of code). This tries to reproduce one of the examples given in the documentation. Attached
here
Logs or other output that would be helpful
Traceback (most recent call last):
File "mwe.py", line 16, in
t, dims, t_rev = flip()
File "mwe.py", line 10, in flip
t_rev = tf.reverse(t, dims)
File "/scratch/virtual_envs/tensorflow_r12_env/lib/python2.7/site-packages/tensorflow/python/ops/array_ops.py", line 2679, in reverse
return gen_array_ops.reverse_v2(tensor, axis, name)
File "/scratch/virtual_envs/tensorflow_r12_env/lib/python2.7/site-packages/tensorflow/python/ops/gen_array_ops.py", line 2963, in reverse_v2
name=name)
File "/scratch/virtual_envs/tensorflow_r12_env/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 585, in apply_op
param_name=input_name)
File "/scratch/virtual_envs/tensorflow_r12_env/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 61, in _SatisfiesTypeConstraint
", ".join(dtypes.as_dtype(x).name for x in allowed_list)))
TypeError: Value passed to parameter 'axis' has DataType bool not in list of allowed values: int32, int64

There's been some backward incompatible changes: https://github.com/tensorflow/tensorflow/blob/c72d891418c326794a913cc13382c104255fe1f2/RELEASE.md#breaking-changes-to-the-api
tf.reverse() now takes indices of axes to be reversed. E.g. tf.reverse(a, [True, False, True]) must now be written as tf.reverse(a, [0, 2]). tf.reverse_v2() will remain until 1.0 final.
does that help?

@yaroslavvb, I see. Thats quite a list. Yes, the workaround works. I just thought, as it is not conforming to the documentation, it might be an unintentional bug. Please close the issue if its not unintentional.

I suspect you were looking at the wrong documentation -- your commit hash is 21 hours old so you have a version newer than 0.12 and should be looking at documentation from head. Navigate to "VERSIONS" and click HEAD, the link should be:
https://www.tensorflow.org/versions/master/api_docs/python/array_ops/slicing_and_joining#reverse

@yaroslavvb, got it. I never knew I can get the latest documentation in such way. Thanks for the pointer. Closing the issue.


Fix SyntaxWarning over comparison of literals using is

Fixes #62

I'm archiving this repo and closing all open tickets and pull requests.


[ET-221] Move SAML/LDAP check into pre-flight

This change moves the check for SAML/LDAP into the pre-flight checks.
It adds a new AuthPreflightValidator class.

:+1: pending ssd's suggestion to just pull the  attributes we need into the node, since there's just 1

Updated w/ change to just pull the attributes instead of merging.

:+1:


Support hosting swagger ui in apiserver

Why are these changes needed?

Related issue number
https://github.com/ray-project/kuberay/issues/339

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

lgtm


GithubApiProvider: injectible interface for code that calls [github] (also affects [suggest])

This interface was designed as part of the work in #1205. Right now it's just a wrapper around the legacy code, though it facilitates making this all dependency-injectible. This is the interface between the github logic and the badge code, so it grabs the bulk of the miscellaneous changes from that WIP PR.
See also https://github.com/badges/shields/pull/1205#issuecomment-408519405

Warnings

:warning:

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

:warning:

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

:warning:

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

:warning:

This PR modified services/github/github-api-provider.integration.js but not services/github/github-api-provider.integration.tester.js. That's okay so long as it's refactoring existing code.

:warning:

This PR modified services/github/github-api-provider.js but not services/github/github-api-provider.tester.js. That's okay so long as it's refactoring existing code.

:warning:

This PR modified services/github/github-api-provider.spec.js but not services/github/github-api-provider.spec.tester.js. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS

In order to try out a PaaS, it's going to be important to make our Github token persistence platform-friendly, which means closing out the work of #1205. That's still a really hairy PR, and getting this in is the next step in paring it down.

@PyvesB would you have a moment to review this? It would be very helpful for moving forward on the github work in #1848.


Reintroduce support for 'var' type format when generating C#

Since adding value tuples, it became more complex to support both var and explicit types. For the sake of time constraints, the support for emitting vars were removed in #423
This needs to ultimately be supported again. Have a look at the changes in PR #427 and revert them too.

Since adding value tuples, it became more complex to support both var and explicit types. For the sake of time constraints, the support for emitting vars were removed in #423
This needs to ultimately be supported again

From an earlier discussion it was decided it is not that important to support var in the output c#. In fact, the code is more understandable having explicit types visible, especially since variable names are not named to give better context.
Due to the complexity of all the moving parts and the limited resources at the moment, it does not make sense to pick up this issue right now. It will be closed.


Add filter to set listener options

User can open the detail setting screen for the app
If user turn on the switch that on the top the screen(right below the appBar), then all notifications from that app will be filtered
If user add some details like title, subText, etc, then notifications that have same packageName and those informations will be filtered
User can turn on/off those detailed filters, so options should be stored in shared preferences.
ex)

Filter 1 : All notifications that have below packageName
packageName: exampleApp

Filter 2 : All notifications that have below packageName and some other fields.
packageName: exampleApp
title: example notification
subText: dummy text

Done with 68d69c6


  ;)

No, that's definitely a bug :-) Fixed now, it'll get into the next build soon.


[Question] Mobile support

Hello,
thank you for your awesome project! I was in the process of porting mcumgr to Javascript when your library showed up, so it really made my work easier.
I have ported this library to @capacitor-community/bluetooth-le, so it works on all 3 platforms (web, Android, iOS).
Would you be interested in integrating it here, or would you rather keep it as a separate project?
I guess we could also refactor the code to be transport independent to support web serial (all the work is pretty much done here: https://github.com/devanlai/mcumgr-web/blob/serial/js/mcumgr.js).
What do you think?
@devanlai @boogie

Hi, sorry for the slow response. I can invite you to this project as an owner, and I am happy to see you improving the code.

Thanks a lot!
I'll have a few spare hours this weekend, so I'll try to finish and publish my changes.


gitignore: rm beam

beam is for Erlang, which has nothing to do with Haskell.
First discovered in
https://github.com/exercism/xrust/pull/129#discussion_r64982860

Agreed. I think that if people submit changes to the gitignore for files that are not directly relevant to the language in question we should encourage them to update their own global gitignore file.


agent: add support for custom OCI hooks inside guest

In order to allow OCI hooks to be executed during the lifecycle of the container inside the guest the path "/usr/share/oci/hooks/" has been designated to allow for 'drop-in' hooks.
Signed-off-by: Edward Guzman<EMAIL_ADDRESS>

Who will put the hooks into /usr/share/oci/hooks/ ?

@caoruidong @amshinde I am assuming the hooks will be added to that directory at the time of rootfs image creation. The use case for this is trying to leverage this existing OCI hook: https://github.com/NVIDIA/nvidia-container-runtime

Just chiming in to point out that this drop-in hook mechanism was inspired by what Project Atomic's fork of Docker is doing:
https://github.com/projectatomic/docker/tree/docker-1.13.1-rhel#add-dockerhooks-exec-custom-hooks-for-prestartpoststop-containerspatch
And also libpod (for CRI-O):
https://github.com/containers/libpod/blob/v0.8.5/pkg/hooks/docs/oci-hooks.5.md
As @eguzman3, we want to ship one or multiple pre-start hooks in our guest rootfs.

@eguzman3 Could you combine your two PRs into one? I see that they already share some common change. They are in fact adding the same functionality to the agent. There is no need to separate them. Within one PR, you can still have multiple commits.


Nested arrays resolve fix

link to solution 1-pager
Change Type (required)
Indicate the type of change your pull request is:

[ ] patch
[ ] minor
[ ] major

Does your PR have any documentation updates?

[ ] Updated docs
[ ] No Update needed
[ ] Unable to update docs

closing this pr as we won't continue with this solution. This part will be covered by streaming player part2.


Doesn't keep checking for locations if none is found

The requestAvailableLocation function should keep looping if it doesn't find any available locations that match the criteria. My nearest locations aren't always available so it ends up checking for dates with no locations.

Suggested adding a loop like this in the run method:
while (this.availableLocation == null || this.availableLocation.length == 0) {
    await this.requestAvailableLocation();
}

Hi! Thank you for your response! I will fix it on the next commit :). Also, I think this will be better:

If the location is null or the array is empty, prompt the user can't find location within the criteria and exit the program :).

Hi! Thank you for your response! I will fix it on the next commit :). Also, I think this will be better:

Why exit the program if the location they're looking for doesn't always show up? They'll have to keep rerunning the program randomly until their location shows up.

hm, how about increasing the miles request by 5 every time check to the API ?

That won't resolve the issue if someone is only looking for locations within their criteria/preference. It can take minutes for the nearest locations to show up and they disappear quickly so you would want to keep checking frequently.

Oh, I know what you mean! So this function only finds a location within the area and saves it to an array. Then the program will find an appointment base on that array.
Send request -> to get an array of location -> infinitive loop that array to check for appointments


Add advice / documentation in readme on using cookies

Please describe your feature request:
We need to be clear about the expected format of using a cookie in headless mode. I believe it is:
katana -u "https://hackerone.com" -H 'cookie: ab={"x:{y}"}'
But we should be more clear about what the format is and what the parser expects.

What this mean?

@olearycrew cookies use the standard format defined by RFC. There is no expected format besides the one required by the specific web app being crawled. @dogancanbakir, can you check if the docs need to be extended with examples of authenticated crawling?

@Mzack9999 @olearycrew While it's indeed helpful to have as much detail and clarity in our documentation as possible, adding a specific section for using cookies in the README may not be necessary in this case. Since this usage is common across many tools and not unique to katana, it is typically expected that users would be familiar with it or can easily find information on it.

I think we’ve seen this question many times in the community so I think we should consider documenting an example somewhere.
Perhaps @pd-jason and Carrie can weigh in here

we’ve seen this question many times in the community

Then let's address it, on it!

Sorry to intervein, I asked that question on Discord if I remember.
It was not an ephemeral question, but rather something that requires a documentation update.

more info added at https://github.com/projectdiscovery/katana#authenticated-crawling


Add spam filtering integration (spam sieve)

Would this be more of a responsibility of the mail provider?

Yeah this is really something done at the mail provider level (e.g. Gmail, Cyrus, Dovecot, etc.)

it would be nice to be able to add even some rudimentary level of it though; not all provider spam filtering is created equal.
there are actually node.js libraries for spam assassin, for what it's worth.
e.g. https://www.npmjs.com/package/node-spamd
it could be too much for most folks, but possibly a nice addition as a plugin.

+1

I see this issue is closed, meaning there is no intention to have some level of spam filtering in N1. My provider does not provide any spam filtering unfortunately so this is a serious issue for me.

This is somewhat of a deal breaker for me guys, need the spam filtering or at least have a some sort of plan beyond passing the buck.


hi! I have tried to run the code but I really can't solve the following problem. I have java installed and have set the environment path. But It still can't work.

Traceback (most recent call last):
File "D:\pycharm\KB-BINDER-main\few_shot_kbqa.py", line 12, in
from pyserini.search import FaissSearcher, LuceneSearcher
File "D:\pycharm\venv\lib\site-packages\pyserini\search_init_.py", line 17, in
from .base import JQuery, JQueryGenerator, JDisjunctionMaxQueryGenerator, get_topics,
File "D:\pycharm\venv\lib\site-packages\pyserini\search_base.py", line 26, in
from pyserini.pyclass import autoclass
File "D:\pycharm\venv\lib\site-packages\pyserini\pyclass.py", line 27, in
from jnius import autoclass, cast
File "D:\pycharm\venv\lib\site-packages\jnius_init.py", line 18, in
java = get_java_setup(sys.platform)
File "D:\pycharm\venv\lib\site-packages\jnius\env.py", line 60, in get_java_setup
JAVA_HOME = get_jdk_home(platform)
File "D:\pycharm\venv\lib\site-packages\jnius\env.py", line 335, in get_jdk_home
raise Exception('Unable to find JAVA_HOME')
Exception: Unable to find JAVA_HOME

hi! I've solve the above problem. Unfortunatelly, I met another one:
File "jnius\jnius_export_func.pxi", line 22, in jnius.find_javaclass
File "jnius\jnius_utils.pxi", line 79, in jnius.check_exception
jnius.JavaException: JVM exception occurred: org/apache/lucene/search/Query has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0 java.lang.UnsupportedClassVersionError
I both try the java8 and java11. But neither can help to solve this.

could you try install the java environment with
conda install -c conda-forge openjdk=11
the above error comes from the pyserini dependency
https://github.com/castorini/pyserini/blob/master/docs/installation.md

could you try install the java environment with conda install -c conda-forge openjdk=11 the above error comes from the pyserini dependency https://github.com/castorini/pyserini/blob/master/docs/installation.md

I notice that hyde repos have the index for FaissSearcher, can you provide it for KB-BINDER or the way to get it? Thank you!


libc++abi.dylib: terminating with uncaught exception of type NSException

New issue checklist

[x] I have read all of the README, documentation, and FAQ.
[X] I have reviewed the contributing guidelines. Confirmation: ____
[X] I have searched existing issues and this is not a duplicate.

General information

Library version(s):Last
iOS version(s):10
Devices/Simulators affected: Both

What happened?
I'm getting this error when I use this data source code below.
override func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int {
       print(self.messageObjects.count)
       return self.messageObjects.count
   }

   override func collectionView(_ collectionView: JSQMessagesCollectionView, messageDataForItemAt indexPath: IndexPath) -> JSQMessageData {
       //let message = self.messages[indexPath.row]
       let messageObject = self.messageObjects[indexPath.row]
       let message = JSQMessage(senderId: messageObject.user?.objectId, senderDisplayName: messageObject.user?.name!, date: messageObject.createdAt, text: messageObject.message)
       return message!
   }

   override func collectionView(_ collectionView: JSQMessagesCollectionView, messageBubbleImageDataForItemAt indexPath: IndexPath) -> JSQMessageBubbleImageDataSource {
       let messageObject = self.messageObjects[indexPath.row]
       let message = JSQMessage(senderId: messageObject.user?.objectId!, senderDisplayName: messageObject.user?.objectId, date: messageObject.createdAt, text: messageObject.message)
       return (message!.senderId == self.senderId ? outgoingBubble : incomingBubble)!
   }

   override func collectionView(_ collectionView: JSQMessagesCollectionView!, avatarImageDataForItemAt indexPath: IndexPath!) -> JSQMessageAvatarImageDataSource! {
       let messageObject = self.messageObjects[indexPath.row]
       let moa = Moa()
       var avatarImage: UIImage?
       moa.onSuccess = { image in
           avatarImage = image
           return image
       }
       moa.url = messageObject.user?.profileImage?.url!
       let avatar = JSQMessagesAvatarImageFactory.avatarImage(with: avatarImage, diameter: 0)
       return avatar
   }
   override func collectionView(_ collectionView: JSQMessagesCollectionView, attributedTextForCellTopLabelAt indexPath: IndexPath) -> NSAttributedString? {
       /**
        *  This logic should be consistent with what you return from `heightForCellTopLabelAtIndexPath:`
        *  The other label text delegate methods should follow a similar pattern.
        *
        *  Show a timestamp for every 3rd message
        */
       if (indexPath.item % 3 == 0) {
           let messageObject = self.messageObjects[indexPath.row]
           let message = JSQMessage(senderId: messageObject.user?.objectId!, senderDisplayName: messageObject.user?.name!, date: messageObject.createdAt, text: messageObject.message)
           //let message = self.messages[indexPath.item]

           return JSQMessagesTimestampFormatter.shared().attributedTimestamp(for: message?.date)
       }

       return nil
   }
   override func collectionView(_ collectionView: JSQMessagesCollectionView, attributedTextForMessageBubbleTopLabelAt indexPath: IndexPath) -> NSAttributedString? {
       let message = messages[indexPath.item]

       // Displaying names above messages
       //Mark: Removing Sender Display Name
       /**
        *  Example on showing or removing senderDisplayName based on user settings.
        *  This logic should be consistent with what you return from `heightForCellTopLabelAtIndexPath:`
        */

       if message.senderId == self.senderId {
           return nil
       }

       return NSAttributedString(string: message.senderDisplayName)
   }

   override func collectionView(_ collectionView: JSQMessagesCollectionView, layout collectionViewLayout: JSQMessagesCollectionViewFlowLayout, heightForCellTopLabelAt indexPath: IndexPath) -> CGFloat {
       if indexPath.item % 3 == 0 {
           return kJSQMessagesCollectionViewCellLabelHeightDefault
       }

       return 0.0
   }

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


fix(ci): don't run PR actions on PRs targeting stable

This PR updates the PR actions to not deploy preview bundles for release PRs targeting stable. The PR should still test and bundle the code but not deploy to any preview environments.

@andy-haynes Is this ready to be reviewed? Also, @Patrick1904 and I were discussing about having PRs from forks being able to also have a preview environment deployment.  Manual activation of deployment previews on a PR by a Near-wallet org member would be great if that is possible.
For clarity, see this PR that fails to build previews for test environment.

@andy-haynes Is this ready to be reviewed? Also, @Patrick1904 and I were discussing about having PRs from forks being able to also have a preview environment deployment. Manual activation of deployment previews on a PR by a Near-wallet org member would be great if that is possible.
For clarity, see this PR that fails to build previews for test environment.

IIRC we were looking at a simpler solution as this ended up being too much of a kludge for use in CI. The goal behind this was only to eliminate an unnecessary step in deployment PRs, in practice it's just awkward for these specific PRs (that only we create) until we're doing trunk-based development.
The S3 preview environment was/is a proof of concept that still needs lots of work to be production ready, including DNS configuration (likely requires CloudFront) and securing S3 uploads for non-contributors. This is why we were going to retain Netlify/Render for the time being, so that previews could continue to be supported until this was worked out.


Regenerate PACs with svd2rust 0.21.0, replace LFS pointers with submodule

This PR

replaces the LFS-stored PACs with a submodule to an unofficial SVD mirror (see below why);
regenerates all PACs with svd2rust 0.21.0;
bump PAC versions to match svd2rust version;
updates the HAL for the PAC API changes (usart0 flushing only);
gates HAL build behind the device-selected feature;
renames the HAL to atsamx7x-hal to imply the support for the ATSAM{E,S,V}7{1,2}* MCUs. I also propose the repo is renamed to this.

The LFS usage has been replaced because all allowed bandwidth has been used up; I was not able to git lfs fetch the PACs. Instead of wrangling with that I believe it is beneficial to use an upstream repository that contains the SVDs we use.
This PR is a draft because the SVDs for the ATSAMS MCUs are currently missing from the CMSIS-SVD repo. These should be added there and this PR amended before merge.

I'm unsure if GitHub pings the maintainer on draft PRs, so @michalfita.

ATSAMS PACs have now been generated. We should wait for https://github.com/posborne/cmsis-svd/pull/149 before merge.
Names of some registers differ across devices, e.g. us_csr c.f. us_csr_{lin,lon,lon_spi,usart_lin,usart}_mode. I do not know why this is the case. Best approach may be to patch the SVDs.

@tmplt Thank you. Looks promising. A few aspects to address in general:

Why sudden interest in that? Is it related to my appeal on Matrix?
I'm planning to move this repo into atsam-rs organization. Can rename the repo in the mean time to atsamx7x-rust.
Q: Are you interested to become the member of the organization? I'd still prefer PRs for work happening there (even if I cannot probably actively work on it at the moment)
I'm working on PR with SVD for the CMSIS-SVD repo at the moment. Will post link to the PR here soon.
While it makes sense to use common repository of SVD files, the downside is that from now on everyone would have to clone the whole CMSIS-SVD repo, while it would make sense for them to create the organisation and keep one repo per manufacturer.

https://github.com/posborne/cmsis-svd/pull/150 is the PR for missing SVD files.

ATSAMS PACs have now been generated. We should wait for https://github.com/posborne/cmsis-svd/pull/149 before merge.

@tmplt Your PR doesn't add SAMV70, look at mine https://github.com/posborne/cmsis-svd/pull/150

Names of some registers differ across devices, e.g. us_csr c.f. us_csr_{lin,lon,lon_spi,usart_lin,usart}_mode. I do not know why this is the case. Best approach may be to patch the SVDs.

I'd be careful, in a few cases I've checked these are reflected in Data Sheets.

Why sudden interest in that? Is it related to my appeal on Matrix?

We'll be using several ATSAM variants internally at @GrepitAB, hence this PR. Adding support for the V variant was initially investigated for atsamd-hal, but the peripheral layouts were deemed too different to support it in the HAL. See https://github.com/atsamd-rs/atsamd/pull/572.

I'm planning to move this repo into atsam-rs organization.

The ecosystem currently appears fragmented: there is also https://github.com/atsamd-rs and https://github.com/atsam-rs. Do you know if there is some effort to collect all ATSAM crates in a single place?

Can rename the repo in the mean time to atsamx7x-rust.

Sure.

Q: Are you interested to become the member of the organization?

Yes. There will be more contributions from my end.

While it makes sense to use common repository of SVD files, the downside is that from now on everyone would have to clone the whole CMSIS-SVD repo

This is not much different from the previous LFS approach: a new contributor would have to fetch all the SVDs, but this was not possible due to the bandwidth limit.

while it would make sense for them to create the organisation and keep one repo per manufacturer.

I don't understand. Could you elaborate?

They I suggest svd is renamed to cmsis-svd as submodule cannot point at the subdirectory of another repository.

Agreed. I'll amend when https://github.com/posborne/cmsis-svd/pull/150 has been merged.

I'd be careful, in a few cases I've checked these are reflected in Data Sheets.

If that's the case then the different registers should of course be accounted for, and not be patched without good reason. I have yet to look too deeply into the register definitions between the variants.

We'll be using several ATSAM variants internally at https://github.com/GrepitAB, hence this PR. Adding support for the V variant was initially investigated for atsamd-hal, but the peripheral layouts were deemed too different to support it in the HAL. See https://github.com/atsamd-rs/atsamd/pull/572.

ATSAMDxx are completely different family and they don't share peripherals, not only layout wise, but functional wise as well. I know designs of them come from different teams in Atmel.
It's interesting the sudden interest in this family and Rust came from two different angles. The gentleman who approached me is going to benefit from all work that will happen here.

The ecosystem currently appears fragmented: there is also https://github.com/atsamd-rs and https://github.com/atsam-rs. Do you know if there is some effort to collect all ATSAM crates in a single place?

It's not that bad - all three organisations are taking responsibility for three distinctive families of ARM MCUs from Atmel/Microchip. There was typo in my post (the link was right) and I meant atsams-rs organization. I wonder if @jamesmunns or someone from @ferrous-systems is going to join...

This is not much different from the previous LFS approach: a new contributor would have to fetch all the SVDs, but this was not possible due to the bandwidth limit.

They had to fetch only SAMx7x SVD files, now it's much more and they're large. And then within the submodule we have to navigate their directory tree - I wonder if leaving svd as symlink to the data/Atmel directory in cmsis-svd submodule wouldn't make sense, would it?

while it would make sense for them to create the organisation and keep one repo per manufacturer.

I don't understand. Could you elaborate?

See the explanation above. There's a lot of data to clone with SVDs for all brands supported by that repo.
We should move that discussion to discussions and leave this PR's thread for the PR.

@tmplt These changes? AFAIR I had them in a template and regenerated automatically from the script, just to avoid error prone manual copy&paste. Wouldn't be wide to follow that practice?

Michał Fita @.***> writes:

@tmplt These changes? AFAIR I had them in a template and regenerated
automatically from the script, just to avoid error prone manual
copy&paste. Wouldn't be wide to follow that practice?

That is what I did. I updated the template and ran ./update.py.

I was thinking more about expanding the process to cover regeneration of hal/Cargo.toml.

Michał Fita @.***> writes:

I was thinking more about expanding the process to cover regeneration of hal/Cargo.toml.

Ah, yes, that would be beneficial.

Just as a note, I'm also attempting to work on SAME70 support, and even having LFS enabled while using @tmplt's fork means that I can't do any git operations, due to the over-quota messages.
For now, I'll do a hard-fork of the SAME70 project, but if there is some way to merge the submodule work, and squash away the history that expects/uses LFS, that would be awesome.

@tmplt yeah, it's possible there was a way for it to work, though I tried to pull this branch, and push it to my fork, however I received errors about LFS over quota.
I don't commonly work with git-lfs, so I'm not sure how to configure the repo locally to "ignore" it.

@jamesmunns and @tmplt Let me try something if it's my quota that's depleted. I'll move the repo to the organisation now - it should get a new quota.
@tmplt let's get this PR ready to merge, OK?

OK, for now on it's not my own repository any more. @jamesmunns You've been invited to the organization as well.
Hopefully the organization has it's own LFS quota and you can use it to fully clone and start working.

I found no obvious good approach to generate hal/Cargo.toml right now. I propose we postpone that change for a later PR.

The HAL may not necessarily with every PAC in mind: I have not tested all of them. A CI would be apt but I think that is better fit for a separate PR.

Thanks, @tmplt. I'm going to collect ideas and postponed work in https://github.com/orgs/atsams-rs/projects/1; for now these are drafts, but they may be turned into issues, that can be closed by PRs when merged.

Locally,
$ find pac | wc -l
52208

so Github reports it correctly: each register has its own file and we have 67 (!) PACs. I do not know what the best approach is to review PRs as large as this, but you will probably have an easier time doing it locally.

I have only 49155 in pac, so there is some large number or you count with binaries... I'm trying to take a look locally.

Notes:

README.md.template has Windows' new line character committed.
Where the 0.21.0 version for PACs comes from?
-all_svd_files = glob.glob("./svd/*.svd") => +all_svd_files = glob.glob("./svd/ATSAM[E,S,V]7[0,1]*.svd") where there any rogue SVDs there?

Does other projects like that keep PACs crates in separated repos? It starts to look like maintenance hell if kept together? @jamesmunns what are idoms in that regard followed elsewhere?

It starts to look like maintenance hell if kept together?

How so? Changing to this submodule approach is a one time cost, presuming that Atmel does not release any new revisions.

Does other projects like that keep PACs crates in separated repos?

Not what I have seen. Most other HALs ship the SVDs in the same repo, without LFS.

were there any rogue SVDs there?

Could you elaborate?

what looks like attempt to avoid some files you don't want to deal with.

Correct. The directory also contains SVDs for other families, e.g. the ATSAM[D,E]5* family, handled by the atsamd crate.

@tmplt I cannot approve it from here as approvals work from files section which will not open with 50k files... merging.