Add a HomeBrew formula

This adds an easy method for macOS users to install SuperCalc.
Now, installation is as simple as:
brew tap C0deH4cker/SuperCalc https://github.com/C0deH4cker/SuperCalc.git && brew install super-calc

Additionally, updates to SuperCalc will be automatically built and installed as the repository is updated, whenever brew update is run.
In the future, it may be useful to include generate a release and point the formula to it, although it isn't strictly necessary (as I have discovered!). This version of the formula will build SuperCalc at whatever the current HEAD of the master branch might be.
Enjoy!

pls merge 😓

the only thing on my christmas wishlist this year is for this to finally be merged lol

Hey, sorry that this has been left ignored for so long! I'd be willing to merge a PR adding brew support now. However, I've since changed the build system to no longer use autotools and to instead build from a standalone Makefile. I think it should be pretty straightforward to update the brew formula for this. Would you be willing to do so (and remove the now-irrelevant README changes)? I'll merge when that's done :)
To build, you now just need to run make. I also have a proper test suite now, which can be run via make check.
Thanks for working on this btw, I'd love to support easier building/installation via brew.

Hey,
Awesome!! I'll go ahead and make the appropriate updates :)


[BUG] hyperf3.0 单元测试未支持权重

Execute the command and paste the result below.
Command: uname -a && php -v && composer info | grep hyperf && php --ri swoole
$ uname -a && php -v && composer info | grep hyperf && php --ri swoole
Darwin jin 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000 arm64
PHP 8.1.23 (cli) (built: Aug 30 2023 08:23:26) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.23, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.23, Copyright (c), by Zend Technologies
hyperf/async-queue                 v3.0.37 A async queue component for hyperf.
hyperf/cache                       v3.0.37 A cache component for hyperf.
hyperf/code-parser                 v3.0.37 A code parser component for Hyperf.
hyperf/codec                       v3.0.37 A codec component for Hyperf.
hyperf/collection                  v3.0.37 Hyperf Collection package which come from illuminate/collections
hyperf/command                     v3.0.37 Command for hyperf
hyperf/conditionable               v3.0.37 Hyperf Macroable package which come from illuminate/conditionable
hyperf/config                      v3.0.37 An independent component that provides configuration container.
hyperf/constants                   v3.0.37 A constants component for hyperf.
hyperf/context                     v3.0.37 A coroutine/application context library.
hyperf/contract                    v3.0.37 The contracts of Hyperf.
hyperf/coordinator                 v3.0.37 Hyperf Coordinator
hyperf/coroutine                   v3.0.37 Hyperf Coroutine
hyperf/database                    v3.0.37 A flexible database library.
hyperf/db-connection               v3.0.37 A hyperf db connection handler for hyperf/database.
hyperf/devtool                     v3.0.37 A Devtool for Hyperf.
hyperf/di                          v3.0.37 A DI for Hyperf.
hyperf/dispatcher                  v3.0.37 A HTTP Server for Hyperf.
hyperf/engine                      v2.10.1 Coroutine engine provided by swoole.
hyperf/engine-contract             v1.9.0  Contract for Coroutine Engine
hyperf/event                       v3.0.37 an event manager that implements PSR-14.
hyperf/exception-handler           v3.0.37 Exception handler for hyperf
hyperf/framework                   v3.0.37 A coroutine framework that focuses on hyperspeed and flexible, specifically use for build microservices and middlewares.
hyperf/guzzle                      v3.0.37 Swoole coroutine handler for guzzle
hyperf/http-message                v3.0.37 microservice framework base on swoole
hyperf/http-server                 v3.0.37 A HTTP Server for Hyperf.
hyperf/logger                      v3.0.37 A logger component for hyperf.
hyperf/macroable                   v3.0.37 Hyperf Macroable package which come from illuminate/macroable
hyperf/memory                      v3.0.37 An independent component that use to operate and manage memory.
hyperf/model-listener              v3.0.37 A model listener for Hyperf.
hyperf/pipeline                    v3.0.37 Hyperf Macroable package which come from illuminate/pipeline
hyperf/pool                        v3.0.37 An independent universal connection pool component.
hyperf/process                     v3.0.37 A process component for hyperf.
hyperf/rate-limit                  v3.0.37 A rate limiter implemented for Hyperf or other coroutine framework
hyperf/redis                       v3.0.37 A redis component for hyperf.
hyperf/serializer                  v3.0.37 A serializer component for Hyperf.
hyperf/server                      v3.0.37 A base server library for Hyperf.
hyperf/stringable                  v3.0.37 Hyperf Stringable package which come from illuminate/support
hyperf/support                     v3.0.37 A support component for Hyperf.
hyperf/tappable                    v3.0.37 Hyperf Macroable package which come from illuminate/tappable
hyperf/testing                     v3.0.37 Testing for hyperf
hyperf/token-bucket                v2.0.0  Implementation of the Token Bucket algorithm.
hyperf/translation                 v3.0.37 An independent translation component, forked by illuminate/translation.
hyperf/utils                       v3.0.37 A tools package that could help developer solved the problem quickly.
hyperf/validation                  v3.0.37 hyperf validation

swoole

Swoole => enabled
Author => Swoole Team<EMAIL_ADDRESS>Version => 5.0.3
Built => Sep 28 2023 17:19:58
coroutine => enabled with boost asm context
kqueue => enabled
rwlock => enabled
http2 => enabled
json => enabled
pcre => enabled
zlib => 1.2.12
async_redis => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => Off => Off
swoole.unixsock_buffer_size => 262144 => 262144

Description:
使用单测过程中，发现未支持权重中间件
Steps To Reproduce:
中间件直接用命令创建
php ./bin/hyperf.php gen:middleware TestMiddleware

增加一个TestController
php ./bin/hyperf.php gen:controller TestController

控制器内容如下:
<?php

declare(strict_types=1);

namespace App\Controller;

use App\Middleware\TestMiddleware;
use Hyperf\HttpServer\Annotation\Controller;
use Hyperf\HttpServer\Annotation\GetMapping;
use Hyperf\HttpServer\Annotation\Middleware;

#[Controller(prefix: "test")]
class TestController extends AbstractController
{
    #[GetMapping("")]
    #[Middleware(TestMiddleware::class, 3)]
    public function index()
    {
        return 'test';
    }
}

单元测试controller如下
<?php

declare(strict_types=1);
/**
 * This file is part of Hyperf.
 *
 * @link     https://www.hyperf.io
 * @document https://hyperf.wiki
 * @contact<EMAIL_ADDRESS> * @license  https://github.com/hyperf/hyperf/blob/master/LICENSE
 */
namespace HyperfTest\Cases;

use HyperfTest\HttpTestCase;

/**
 * @internal
 * @coversNothing
 */
class ExampleTest extends HttpTestCase
{
    public function testExample()
    {
        var_dump($this->get('/test'));
        $this->assertTrue(true);
    }
}

抛出异常 [ERROR] Invalid middleware, it has to provide a process() method.
正常启动打印 AbstractRequestHandler 的 middlewares 如下
array(1) {
  [0]=>
  string(29) "App\Middleware\TestMiddleware"
}

单测异常打印 AbstractRequestHandler 的 middlewares 如下
array(1) {
  [0]=>
  object(Hyperf\HttpServer\PriorityMiddleware)#16 (2) {
    ["middleware"]=>
    string(29) "App\Middleware\TestMiddleware"
    ["priority"]=>
    int(0)
  }
}

@limingxinleo


Inverted withVerticalLabels and withHorizontalLabels

Hi, there seems to have been a mix between the X and the Y axis.
X axis is the horizontal line and Y the vertical
but the code in abstract-chart.js and specific the renderVerticalLabels and renderHorizontalLabel mixes this up.
I am not sure if this affects something else but when I do a withHorizontalLabels={false} my vertical labels (Y axis labels) gets hidden and vice versa.
not a big issue but I don't think you would like this to stay this as there is some wrong the naming then.

I agree the naming is confusing. Originally it meant that the labels add some meaning to the grid behind the chart. I suppose it'd be better to name the withXAxisLabels... At this point it seems like a very breaking change for not much benefit.

You don't understand.
withHorizontalLabels actually turns off vertical labels.
withVerticalLabels actually turns off horizontal labels.

Vertical could mean Y axis, but it also could mean labels for vertical lines behind the chart (X axis)


when i  use the mock option it always return random response ,how can it return the example in swagger.json file

Same here, even if I set mock.dynamic: false

I figured it out with @pytlesk4 answered in #111
You should use examples definition in responses(spec) rather than example in schema (spec), and set
x-stoplight:
    mock:
      enable: true
      dynamic: false

in swagger specification.
Then if defined examples in responses, it will return example response, the otherwise dynamic response returned.

@lzbpythoner could you provide a little bit more information?

What version of prism are you using?
Can you share your spec file?
What is the command you using?


Database is empty

Hi,
I'm trying to install PowerDNS-Admin on Ubuntu 18.04 using MySQL as the database backend following the wiki https://github.com/ngoduykhanh/PowerDNS-Admin/wiki.
When I run flask db upgrade, the "powerdnsadmin" database stays empty:
`(flask) root@pdns:/opt/web/powerdns-admin# flask db upgrade
INFO  [alembic.runtime.migration] Context impl SQLiteImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> 787bdba9e147, Init DB
INFO  [alembic.runtime.migration] Running upgrade 787bdba9e147 -> 59729e468045, Add view column to setting table
INFO  [alembic.runtime.migration] Running upgrade 59729e468045 -> 1274ed462010, Change setting.value data type
INFO  [alembic.runtime.migration] Running upgrade 1274ed462010 -> 4a666113c7bb, Adding Operator Role
INFO  [alembic.runtime.migration] Running upgrade 4a666113c7bb -> 31a4ed468b18, Remove all setting in the DB
INFO  [alembic.runtime.migration] Running upgrade 31a4ed468b18 -><PHONE_NUMBER>77, Upgrade DB Schema
INFO  [alembic.runtime.migration] Running upgrade<PHONE_NUMBER>77 -> 0fb6d23a4863, Remove user avatar
INFO  [alembic.runtime.migration] Running upgrade 0fb6d23a4863 -> 856bb94b7040, Add comment column in domain template record table
INFO  [alembic.runtime.migration] Running upgrade 856bb94b7040 -> b0fea72a3f20, Update domain serial columns type
INFO  [alembic.runtime.migration] Running upgrade b0fea72a3f20 -> 3f76448bb6de, Add user.confirmed column
`
`mysql> use powerdnsadmin;
Database changed
mysql> show tables;
Empty set (0.00 sec)
`
Here is what I have in the default_config.py file:
`import os
basedir = os.path.abspath(os.path.abspath(os.path.dirname(file)))
##BASIC APP CONFIG
SALT = '$2b$12$yLUMTI'
SECRET_KEY = 'e951e5a1f4b94151'
BIND_ADDRESS = '<IP_ADDRESS>'
PORT = 9191
HSTS_ENABLED = False
OFFLINE_MODE = False
##DATABASE CONFIG
SQLA_DB_USER = 'pdnsadminuser'
SQLA_DB_PASSWORD = 'password'
SQLA_DB_HOST = '<IP_ADDRESS>'
SQLA_DB_NAME = 'powerdnsadmin'
SQLALCHEMY_TRACK_MODIFICATIONS = True
##DATABASE - MySQL
SQLALCHEMY_DATABASE_URI = 'mysql://'+SQLA_DB_USER+':'+SQLA_DB_PASSWORD+'@'+SQLA_DB_HOST+'/'+SQLA_DB_NAME
##DATABASE - SQLite
##SQLALCHEMY_DATABASE_URI = 'sqlite:///' + os.path.join(basedir, 'pdns.db')
##SAML Authnetication
SAML_ENABLED = False
SAML_ASSERTION_ENCRYPTED = True
`
Any idea?

Sorry, it was my fault. For the database configuration, I was executing  export FLASK_CONF=../configs/development.py so the default_config.py wasn't taken into account.
One thing here is that the error was silent. There should be an error message saying that it couldn't connect to the database I believe.


Adding additionalNotificationRecipients property to scope model in ac…

Overview
This pr is to expose a new additionalNotificationRecipients properties for sending additional notification in the "accessReviewScheduleDefinition" object.
An accessReviewScheduleDefinition contains access review instances. Now every accessReviewScheduleDefinition contains multiple instances[one for every invocation of the review. For ex: if a schedule definition running weekly, there's one instance every week]. Every instance automatically inherits the list of reviewers and fallbackReviewers from an accessReviewScheduleDefinition when it's created
We now want to expose additionalNotificationRecipients in both accessReviewScheduleDefinition and accessReviewInstance so that developers can change it for an actively running instance if they want.
Changes
Expose properties: additionalNotificationRecipients, List of AccessReviewNotificationRecipient
AccessReviewNotificationRecipient contains

notificationTemplateType - what type of notification send to recipients
principalId - recipient ID
principalType - recipients type (group/user)

Expose route for POST and PUT instance
MSFT employees can try out our new exp
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
OCT 2021
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
OCT 2021
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Please go through the contribution checklist added as part of the review and mark them completed. It will help you fix most of the issues and improve the quality of swagger and help close the PR faster. This is a requirement before review can be continued.

Hi- Thank you, I’ve went through the checklist. If the design got approved we’ll start publishing the change in prod.
From: Chirag Gupta [MSFT] @.>
Sent: Saturday, September 25, 2021 12:21 PM
To: Azure/azure-rest-api-specs @.>
Cc: Jing Yang @.>; Mention @.>
Subject: Re: [Azure/azure-rest-api-specs] Adding additionalNotificationRecipients property to scope model in ac… (#15984)
Please go through the contribution checklist added as part of the review and mark them completed. It will help you fix most of the issues and improve the quality of swagger and help close the PR faster. This is a requirement before review can be continued.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F15984%23issuecomment-927171152&data=04|01|Jing.Yang%40microsoft.com|2259159bd41548ec581408d98059987b|72f988bf86f141af91ab2d7cd011db47|1|0|637681944587927696|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xc%2Fs81bYkPEaw829OQ1ms6C9eUyd%2FL9y2tQrCMWHrHk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAT7WIPIKRNTBKKEBHPIGWODUDYOJNANCNFSM5DX44NGA&data=04|01|Jing.Yang%40microsoft.com|2259159bd41548ec581408d98059987b|72f988bf86f141af91ab2d7cd011db47|1|0|637681944587927696|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2Fa44PXJ6mrfFDKOaVWcCVnYE1b%2BwBpFx0nZJjZ4%2BncM%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|Jing.Yang%40microsoft.com|2259159bd41548ec581408d98059987b|72f988bf86f141af91ab2d7cd011db47|1|0|637681944587937667|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bJHV3pylmrjCtkJqI49Fu%2FsuGel8Y2%2Bjo0%2F37xiQmDg%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|Jing.Yang%40microsoft.com|2259159bd41548ec581408d98059987b|72f988bf86f141af91ab2d7cd011db47|1|0|637681944587937667|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=qtBOD9PvGD05R7WV5bmK4LaS8hNm0pC84fpjGr0bRDM%3D&reserved=0.

It looks like you are trying to update an existing API version and submit a new API version in the same PR. Please separate this into two PRs, one to update the existing API version, and another to create a new API version. Be sure to fill out the checklist according to the different purposes of the two PRs. For the one that's creating a new API version, it is critical to make the first commit by copying the existing files unchanged to the new API version folder, so we have a baseline to diff against.

It looks like you are trying to update an existing API version and submit a new API version in the same PR. Please separate this into two PRs, one to update the existing API version, and another to create a new API version. Be sure to fill out the checklist according to the different purposes of the two PRs. For the one that's creating a new API version, it is critical to make the first commit by copying the existing files unchanged to the new API version folder, so we have a baseline to diff against.

I just saw that the new API version has no changes from 2021-07-01-preview, so ARM review isn't required for it. The update to the existing API version is a breaking change, so you will need to go through breaking change review.

close pr as first commit does not include new version

Hi, @jingyang1114. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.


Refactor project setup + update to RN 68.2 + update dev dependencies

This PR bases on https://github.com/lottie-react-native/lottie-react-native/pull/877 but includes a decent amount of additional changes to make the project better aligned to the rest of open source libraries out there. These changes are needed so that I can have two fully different example projects: one for fabric and one without fabric.
Summary of the major setup changes

The new setup creates two fully separated areas: lib (root) and example
The lib is the root folder (as before) which takes care of actually containing the lib source code and building the lib files via babel.
The example is fully separated from the lib and only has a "weak" reference to that one via "lottie-react-native": "file:..". That allows us to build multiple example projects without having to deal with the additional complexity in the root folder which should just take care of the lib creation.

Because of these changes I was able to simplify the examples quite a lot and make them a lot closer to how this library will be used in a final project.
Android can finally use npx react-native ... to be compiled instead of the strange previous way.

Remove npm offline usage. That is causing some problems with the new setup.

Testing via example project

[x] Android
[x] iOS
[ ] Windows - I need help with that. I don't have a Windows setup for this.

Testing for other project related areas

[x] Lib folder creation with Babel - The lib output files look fine to me and seem to work when using them via the example project.
[ ] NPM deployment - @emilioicai I think that only you who can help me verify that part.

Additionally this PR includes some project specific changes

Using the RN 0.68.2 upgrade helper to make changes to the whole project.
Update dev dependencies - there were plenty which were extremely outdated and I have not noticed any issues so far. Please correct me if I missed something. I am happy to revert some of these dependency updates.

Missing setup changes and known issues

When using the example, you need to ensure that the root folder does not have a node_modules folder. If that is the case, react native will not be able to correctly display the lottie native view. So you need to run yarn install in the root, have the lib folder updated, remove node_modules, remove node_modules in the example project and run yarn install there again. That can be managed and is just a few steps but something which can ideally be automated.

Next
With having a better project setup, I would start adding the actual RN new architecture code as part of the next PR. It would be great if we could have this one merged in the next days so that I can get really started on the fabric part.

@AlexanderEggers thanks for the contribution, are there any news on this PR?

@Willham12 I am still waiting for feedback by @emilioicai  for this PR and I need help to verify if the publishing and thd windows version are still working fine.

@emilioicai Can we merge this PR prior to any additional changes to develop? Otherwise the changes are going to be extremely difficult for me to maintain. I noticed that you merged some changes which require a rebase from my side now. I will try to take care of that some time tomorrow.

Hey Alex, yes, sorry for not being  that active, these weeks have been quite hectic for me. I started reviewing and hopefully merge before the week ends. I promise I won't commit any large changes into the repo before this PR is merged

It seems that there are some merge conflicts @AlexanderEggers. Can you fix them?

Isn’t it better to upgrade to 0.69.3. It has been a while that this PR is still open.

At some stage, yes. But I want to avoid to keep updating this PR and just have a base ready for now.

You can just pick this commit if you don't want to put time into fixing the comments.
https://github.com/lottie-react-native/lottie-react-native/commit/aa10ae3040f7a02f1a6fcfa7a98e53962c553403

@matinzd Thanks for doing the review. I will try to have a look at your comments by the end of this week.

@matinzd Thanks again for the review. I cherry-picked your commit into this branch and added a few minor additional changes. Let me know if you can notice anything else.

@matinzd Thanks again for the review. I cherry-picked your commit into this branch and added a few minor additional changes. Let me know if you can notice anything else.

I am going to test windows today on my wife’s latpop and setup the environment 😅.

@emilioicai @matinzd I started working on the fabric support. I think it would be great if we can get this first part either merged into /master or we create a /fabric branch which we will use internally for now until it is stable enough for the public. What do you think?
The relevant work is currently sitting in this branch: https://github.com/AlexanderEggers/lottie-react-native/tree/feature/add-fabric-support I haven't had a chance to work much on that. I just migrated the android and JS code to technically support fabric but I am having troubles running the non-fabric example project at the moment.
Let me know how you want to proceed with this PR and the future fabric work.

@emilioicai @matinzd I started working on the fabric support. I think it would be great if we can get this first part either merged into /master or we create a /fabric branch which we will use internally for now until it is stable enough for the public. What do you think?
The relevant work is currently sitting in this branch: https://github.com/AlexanderEggers/lottie-react-native/tree/feature/add-fabric-support I haven't had a chance to work much on that. I just migrated the android and JS code to technically support fabric but I am having troubles running the non-fabric example project at the moment.
Let me know how you want to proceed with this PR and the future fabric work.

That would be great! We also need to start working on fabric and make it backward compatible. There is a repo in react native community with examples for making fabric backward compatible, so we can use that.
https://github.com/cipolleschi/RNNewArchitectureLibraries/tree/feat/back-fabric-component-070

@matinzd Yep I'm using that one 👍 Can you create a /fabric branch based on master so that I can retarget this PR?

@matinzd I finally managed to have the windows support tested and everything looks good on that front 🙌
@AlexanderEggers I created that fabric branch for you to target, thanks again for your support!

@emilioicai Thanks for creating the branch. I re-targeted the branch to that branch now. I think the only remaining thing we need to verify is the NPM deployment but we could also do that when we closer to the actual going public, what do you think?

@emilioicai
Where are we going to release v6 if we are targeting this on fabric branch?

About NPM deployment we can start with lottie-react-native@next for /fabric branch?

I think that's a great idea 👍

Let's change base branch to master again so that @emilioicai can release the latest changes as a patch. Then we can start fabric branch based on master. @AlexanderEggers

@emilioicai Would it be possible if we can get this PR merged into /fabric this weekend? I'm pretty close with the android fabric work and got actually plenty of notes that we need to discuss together.


ROS2 Beta2 released, and this code is incompatible with the new API

The API has changed on some things and if you try to compile this rmw_coredx with the new Beta2 release, it fails to build.

I've updated so it now compiles OK against the ros2 beta2.

Looks good. 1 follow-up question: which ros2.repos file did you use to build against?
We have a custom one, but it seemed to work even though I didn't expect it to.
I pulled the coredx branch of the rms_implementation repo, which doesn't have the latest API, and it still worked.
I'm a bit confused....


Improve Datadog integration

This should allow us to better understand the performance of the eth-rpc-adapter and to make the appropriate optimizations

@xlc do we still need it?


Scheduled downloading issues

When using scheduled downloads, sometimes the recording time stops and the capacity keeps increasing.
When I check the .ts file, it is only recorded up to the time it stopped.
If I stop recording and turn it back on, it works fine.
It doesn't mean your network is down or something.
What could be the problem?

Duplicate of #68


More datails on data flow?

Hi sbmjais,
Thank you for your fabulous explaination on the data flow.
We are a health provider in Australia. We'd very much likely to use the Customer Voice product. However, by legal restriction / regulations, all client identifiable data cannot be flow outside of Australia. Is there anyway that we can overcome this e.g., skip the Customer Voices Service step and store the data directly into Dataverse?
Do you happen to know any organisations from healthcare sectors who are currently using the MS Customer Voice?
Cheers,
Robin

Close

Thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: https://docs.microsoft.com/dynamics365/get-started/support/
Closing this issue.


Fix printing of T48 firmware version

The minor version needs to be padded to two digits using a leading zero.
Firmware version 1.07 was being reported as 1.7.
This is confirmed if one looks at the 2 first bytes of a firmware binary,
which encode the minor and major version, respectively.
If one uses xgecuPro on Windows to program a firmware binary with
those leading bytes, it displays the T48 firmware version as "01.07".
I also confirmed that bytes of 0x10 0x01 is displayed as "01.10".

thanks for your contribution!


feat(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1623

Questions ?
Please refer to the Backport tool documentation


Update tool callbacks to send the actual response from the tool

Privileged issue

[X] I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content
Reproducible issue. on_tool_end logs the string representation of the tool. All tool callbacks need to be updated to accommodate
from langchain_core.tools import tool
from langchain_core.documents import Document

def foo(x):
    return {
        'x': 5
    }

@tool
def get_docs(x: int):
    """Hello"""
    return [Document(page_content='hello')]

chain = foo | get_docs

async for event in chain.astream_events({}, version='v1'):
    if event['event'] == 'on_tool_end':
        print(event)

https://github.com/langchain-ai/langchain/discussions/18694

This is a bug in the astream_events API and an enhancement for existing tool callback handlers

@eyurtsev I am taking this and working on it.

@keenborder786 thanks for taking a look at this! The fix is actually more involved since it needs to be backwards compatible with existing callback handlers. I'm going to scope it out today

@eyurtsev oh okay. Can you please explain a little about the backwards compatibility in this case so I can help you as well. All the existing handlers that are using on_tool_end need to work properly??? Correct.

Any code that relies on the output from the handlers should not break

Okay.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Eugene Yurtsev @.>
Sent: Friday, March 8, 2024 8:59:08 PM
To: langchain-ai/langchain @.>
Cc: Mohammad Mohtashim Khan @.>; Mention @.>
Subject: Re: [langchain-ai/langchain] Update tool callbacks to send the actual response from the tool (Issue #18760)
CAUTION: This email has originated from outside of LUMS. Do not click links or open attachments unless you recognize sender’s email address and know the content is safe.
Any code that relies on the output from the handlers should not break
—
Reply to this email directly, view it on GitHubhttps://github.com/langchain-ai/langchain/issues/18760#issuecomment-1985950359, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKZFN65Z4NUICCEXMS3C6ITYXHN4ZAVCNFSM6AAAAABELY4UW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVHE2TAMZVHE.
You are receiving this because you were mentioned.Message ID: @.***>

I'm looking through to figure out what can be affected. For example, one thing is BaseTracer which is used to power both astream_log and astream_events. If we change the output of the on_tool_end, we will fix the output from astream_events, but we also might cause an unexpected breaking change (e.g., if they're relying on those APIs and sending the content from the backend to the frontend the content will suddenly stop serializing).
it's a bit tricky in some of these cases to figure out whether to make a breaking change (and keep the code simple) or make a more involved change so that we don't break user code

OK @keenborder786 I think we can proceed with the PR that you made! I'm going to outline a few places to propagate information to so that we break the minimum amount of code

PR merged will be available in next release

@eyurtsev I don't see this issue (#18760) referenced in the latest release: https://github.com/langchain-ai/langchain/releases/tag/v0.1.12
When I test the original code that output a str(Document), I still see the same problematic output:

Can you confirm that this issue was not fixed by the latest release?

It looks like this PR might have to be merged before this issue can actually be corrected in a release. Is that correct?


Renamed 'examples' to 'implementations'

Pull request for issue https://github.com/json-api/json-api/issues/493.

Thanks!


Can't install release version of 'ms-vscode.remote-explorer' extension because it has no release version

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.72.1
OS Version:  Darwin arm64 21.6.0

Steps to Reproduce:

Update VScode to 1.72.1
The Remote - SSH extension asks me to update. When I click update, I get the error Can't install release version of 'ms-vscode.remote-explorer' extension because it has no release version

This is now fixed in https://github.com/microsoft/vscode-remote-release/issues/7330


WIP - Make use of fs.FS (new to go 1.16, with polyfill for 1.15) to allow for reading source files from diverse filesystems (local, embed, custom), configured via Options.Filesystem ( feature #1200 )

For feature #1200
THIS IS STILL WORK IN PROGRESS, BUT I REALLY NEED FEEDBACK TO MAKE SURE I'M APPROACHING THIS APPROPRIATELY.

Options has a new field Filesystem FS so users can supply their own read-only filesystem containing source code.

Defaults to the local filesystems (via RealFS - a thin os.Open wrapper made to look like a fs.FS) so regular users should see no change in behaviour.
When no filesystem is available (e.g. WASM, or if you want to embed code to retain single binary distribution) an alternative filesystem is preferable to Eval(string) as that requires the stringy code to be a single file monolith instead of multiple files. By using an fs.FS we can use EvalPath() and gain the ability to handle multiple files and packages.
For go < 1.16 it polyfills fs.FS as closely as it can.
go 1.16+ can make use of embed filesystems (https://pkg.go.dev/embed) and custom filesystems obeying the fs.FS interface (I use one for http served zip files when targeting wasm as there is no local filesystem on wasm). Tests for 1.16 can make use of fstest.Map.
NOTE: This does NOT affect what the running yaegi code considers its local filesystem, this is only for the interpreter finding the source code.

EXAMPLE:
See example/fs/fs_test.go for an example.
TODO:

[x] Fix any broken tests (?)

There seem to be broken tests already (at least when I run master locally), how can I tell if I broke something new?

[x] // +build go1.16 (using fs.FS)  and  // +build !go1.16 (polyfill) versions.
[x] New test(s) to cover new functionality

[x] For 1.16+ tests use fstest.MapFS as the testing filesystem - https://pkg.go.dev/testing/fstest#MapFS
[x]  For 1.15- I'll have to create the equivalent of a MapFS. [ wow, it's ugly! ]

[ ] Update docs to show how to use this new config option for both 1.16+ and 1.15-

QUESTIONS:

What's the oldest version of go yaegi supports being compiled with? [ CI and docs seem to indicate 1.15/1.16, but the go.mod says 1.12 - which the linter uses to enforce some rules. Master does not compile with 1.14 so I think it's safe to assume 1.15 minimum? Maybe the go.sum should be updated to 1.15? ]
Does this change affect what running yaegi code considers its own filesystem? I assume not... but needs checking.

Maybe I should rename the option ReadonlySourcecodeFilesystem fs.FS to hammer the point home?

When I run make tests locally on my mac tests fails 28 tests on master - is this expected?

I don't know if some tests are expected to fail when run locally because they're placeholder, or maybe something is up on macos wrt tests? It makes it tricky to ensure my changes aren't breaking stuff.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for this proposal. I'm happy with the way you are approaching it so far.

What's the oldest version of go yaegi supports being compiled with? [ CI and docs seem to indicate 1.15/1.16, but the go.mod says 1.12 - which the linter uses to enforce some rules. Master does not compile with 1.14 so I think it's safe to assume 1.15 minimum? Maybe the go.sum should be updated to 1.15? ]

The oldest version of go we support for yaegi is go1.15. We should indeed update go.sum to this version. Note that we will bump it to go1.16 as soon as go1.17 is released.
Regarding the polyfill of go1.15, as release of go1.17 should come quite soon now (in august, according to https://github.com/golang/go/milestones), we should probably wait for it and skip the polyfill entirely). We usually update yaegi quickly after a new Go version is release anyway. In the mean time we could keep this PR opened if necessary.

Does this change affect what running yaegi code considers its own filesystem? I assume not... but needs checking.

As far as I see, this change does not affect what yaegi considers as its filesystem, or at least it should not. But the virtualisation of FS through embed is something that we would certainly consider in the sandboxing layer soon after this PR. Note: at this moment only os.Stdin, os.Stdout and os.Stderr file descriptors are sandboxed.

Maybe I should rename the option ReadonlySourcecodeFilesystem fs.FS to hammer the point home?

this option name, although a bit too long for my taste, should be fine.

When I run make tests locally on my mac tests fails 28 tests on master - is this expected?

Will look at it on my side.

@mvertes I think waiting for 1.17 is a good idea, the ugliest part of this PR is the 1.15 polyfill and it seems silly to add it now only to remove it soon. So I'll remove the polyfill code from this PR and it can sit open until 1.17 support lands and 1.15 is retired. Thank you for your time and efforts <3

@TheMightyGit I think this PR is almost ready for merge. Is it ok for you to remove the draft status, and maybe provide additional documentation about the new filesystem config option, if you feel so. Thanks.


feat: add filter for modref

It can be hard to remember all the types of modifier KoL offers (e.g. for a hat drop, there is item drop, gear drop and hat drop).
Add a filter for modref so you can type modref @Drop to get all the drop modifiers (and some other stuff where the name contains "drop", but this is good enough for me).

Maybe we want to use * and treat it as a wildcard instead? @ feels unintuitive to me. Great change though

I picked @ because modref already takes an item name with no extra flags and I figured @ was the least likely character to appear in an item name.
My initial hope was that modref Drop could give you all the drops, without having to add wildcards. Because of the item name thing, you also can't provide more than one word (or I have to figure out how to do the flags for that, but I don't want to make it inconvenient to use).

So why not use *?

"Item name" thing? Example, please?
So, you are worried there might be an item name that starts with a *?
I think * is more intuitive than @.


Careers page

Includes slight variations of existing blocks to suit the page.
Test URLs:

Original: https://www.sunstar.com/careers/

Before: https://main--sunstar--hlxsites.hlx.live/careers

After: https://careers_2--sunstar--hlxsites.hlx.live/careers

[X]  If you are adding a new block or a variation to an existing block, please fill below:
Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0

The change in blocks/hero is expected as I added a new hero block variation.
Looking at the LHS issue.

For some reason the change in the latest commit was not pushed to Edge Delivery. Closing this PR in favour of #170.


Passwords

Great project.  Are you planning on making the password handling more secure?  I'd be worried that someone in my network could gain access to my firewall.

Hello @MPLedward
This bouncer don't handle directly password , they just consume it from an external source through a ENV variable.
Depending on how you run it (docker, k8s, ..) you have different choice for managing it in a secure way
with Docker you can rely on docker secrets
with k8s , you can use secret ressource or external vault and native k8s integration (ex: https://github.com/external-secrets/external-secrets)

Thanks for your reply!  I'm new to both docker and Go, so my question probably shows my ignorance.  I'll look more into this, thanks for the link.  If you happen to think of any more links that may be helpful to bringing a n00b up to speed more quickly, I'd appreciate it.  :)

No problem @MPLedward
to strength your knowledge I can advice you https://medium.com ,a lot of great articles, whatever the subject your want to dig.
take care


ElAutocomplete - throw error when clear input. In handleChange rase error: "TypeError: Cannot read property 'value' of undefined"

ElAutocomplete. In handleChange:2090 rase error: "TypeError: Cannot read property 'value' of undefined" when  you try to clear input.


Investigate best way to save player parties

We need a way to associate player parties with the client connecting. For example, if a player has created a party and is rejoining the campaign there has to be a predetermined way of identifying which party is theirs on the host.
Find out the best way to identify player parties and save that identification.

The best idea here is to use a custom file that is saved in the mod directory.

The best idea here is to use a custom file that is saved in the mod directory.


[Question] How to configure ADFS auth provider without integrating with rancher?

On the integrated rancher ui dashboard, I'm able to see ADFS as an inactive auth provider. Is there a way to configure ADFS without integrating harvester with rancher? I do not want to manage multiple clusters, I just need a way to configure ADFS and some users

small ping on this, is this possible at all? Do I need to bring in any rancher controllers to make this possible


fix: error instead of panic

Checklist

[X] I have read the coding guide

Description
There's a case when a noOp method is being called and that crashes the process.
Closes: #3082

This change is

I am really anxious to see this arrive in Swarm-Desktop because it fixes more than just the panic that the title implies, specifically #3082

I'm really anxious to see this in swarm-desktop so that I can resume using that ultra-light node for retrievals from the swarm!

you can also do a make binary in the root of the repo and then copy the executable to your ~/.local/share/bee-desktop-nodejs.
after restart it should use the newly build version.


Check for pills as member of dropdown method params.

pills not assigned to parent params. Would error when layer was initially filtered on the same field. Second fix - when using pills keep placeholder in the dropdown.
Description
Layer with a filter initially set in the workspace. When filtering on the same field by pills dropdown
access to current in filter would fail:
was: params.pills && pills.add(entry.title)
should be: params.pills && params.pills.add(entry.title)
Additional change: when using pills keep the dropdown placeholder. Join values only when pills not in use.
GitHub Issue
Provide the link to the relevant GitHub issue it addresses.
Type of Change

✅ Bug fix (non-breaking change which fixes an issue)

Testing Checklist
Please delete options that are not relevant, and select all options that apply.

✅ Existing Tests still pass
✅ Ran locally on my machine

Code Quality Checklist
Please delete options that are not relevant, and select all options that apply.

✅ New and existing unit tests pass locally with my changes

Parameter properties for the filter_in method docs have been changed from param to property.
The current filter for the filter.field must be excluded from the distinct_values query.
The ui/elements/dropdown module was missing the module block which is required to show the module documentation.
The dropdown method returned from the dropdown module has been named.
While technically an object, the dropdown method returns an HTMLElement.
Assigning the li elements to the ul variable used within nested methods of the parent method will cause confusion later down the road. It much better to assign the li elements to the li_elements variable which is only required in the construction of the params.ul element group. The params.ul element is used in the pills removeCallback method to find a li element. With good variable naming a log of the comments are redundant. params.ul for example is much better understandable than using e.target.nextElementSibling where the e.target is the header element and assuming that the ul element is the next element sibling.

The headerOnClick method has been unnested from the dropdown method and cleaned up.
Assigning variables which are used only once to a name just for them to be used in a single calculation which result is stored in a different variable adds unnecessary cognitive overload.
The classList toggle returns true when a class is added. This is much more concise than checking whethe the class exists and then add or remove the class based on whether the class exists.
  const active = dropdown.classList.toggle('active');

  if (active === false) return;

create ulElements method with nested liOnClick method; updated docs.


add llama 3.1

Summary
What/Why
Added llama 3.1.
Your approach
Added as llama 3.1 is the most recent llama model.
What to review
Only 2 files changed.
Checklists

This pull/merge request meets the following requirements:

[x ] code runs
[ x] developments are ethical
[ x] developments are secure (no data or notebook output)
[ x] you have made proportionate checks that the code works correctly
[ x] minimum usable documentation written in the docs folder

Comments have been added below around the incomplete checks.

Typo changed alongside README

Closes issue #38


Fix navbar responsiveness

Fixes #1189

Codecov Report

Merging #1200 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   69.44%   69.44%
=======================================
  Files         116      116
  Lines        6250     6250
  Branches      756      756
=======================================
  Hits         4340     4340
  Misses       1742     1742
  Partials      168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07be011...bebe537. Read the comment docs.


feat(KFLUXINFRA-741): Add "Local" cloud

The "Local" cloud configuration is meant to allow a remote-capable
piepline task to run locally in the cluster by creating a dummy SSH
secret for it that only has the "host" key set to "localhost.
While we could in theory create a host pool that contains "localhost",
that would've caused the controller to try to SSH into it to configure
user accounts, etc.

This helps complete the picture for konflux-ci/build-definitions#1216

Setting hold, please do not merge until redhat-appstudio/infra-deployments#4241 is merged.


Fix handling of unpickle errors

fixes #73
fixes #83
avoids the need for #102

Coverage decreased (-1.7%) to 82.265% when pulling 5e632f09e0e3128f78420271946a1f025b32e667 on fdemmer:73-delete-on-unpickle-errors into 3633d43fa3e97bc9f92ea83a749925bbad215393 on reclosedev:master.

Thnaks! I'll add test


save_files not saved after execution failures

When running TurbiniaTask.execute(foo, save_files=[]), the save_files are not saved when there are errors in the binary execution.  This is by design because generally the files in save_files list are created by the execution, so if the execution fails, the status and existence of the save_files is in an undefined state.  For example though, in the Plaso Task, the Plaso log file which is created doesn't get saved, which means that failures are difficult to debug.
I think adding a new log_files parameter to task.execute() that would save even if the execution fails would work.  It would basically be the same thing as the existing save_files, but would always be saved.

I'm pretty new to open source and working on code I didn't write myself in general so I just wanted to make sure I understood this correctly. Are you essentially wanting log_files to do the exact same thing save_files does in execute except outside of the conditional that prevents the for loop from running? If that is the case, is there a reason for making log_files a parameter instead of just copying save_files into log_files?

Closing this now since #340 was merged. Thanks!


suggested updates

changed to .net 6.0
removed obsolete webclient and replaced it with http client
probably destroyed everything in the process !

Remove the update to .NET 6.0 for sure. We discussed and opted to keep .NET 5.0 with RollForward. This means it should work on .NET 6.0 runtime but .NET 5.0 works as well. We don't really need any features from .NET 6.0 or performance improvements and I'd rather just not break for users.
Regarding the change to HTTP Client & rendering it seems fine to me but I'll leave that up to @factubsio and @BarleyFlour who wrote those.


Allocate Elastic IP to hcommons-prod-idp and update config files

Currently, this instance is set up with a public IP that is not an Elastic IP. This means that when the instance is rebooted, it will get a different IP assigned to it and this would sever any connection to it that is using the public IP.
There was an entry under Elastic IPs for this instance, but it was in fact for hcommons-dev-idp

Current public IP: <IP_ADDRESS>


Add FAQ entry about scipy.special

Thanks to this project:
https://numba-special.readthedocs.io/en/latest/index.html
There are now wrappers for the scipy.special functions.  We should mention this project in our FAQ.
As a side question: This implementation requires individually extracting all the function pointers using a .pyx file:
https://github.com/person142/numba_special/blob/master/numba_special/function_pointers.pyx
I wonder if there is a way to do that more automatically...

See "scumba" discussion here: https://github.com/numba/numba/issues/4292

The Numba extension project now supports this feature: https://github.com/numba/numba-scipy this should be mentioned instead.


Use fake smtp connection class instead of bool.

We are typechecking mail tests now https://github.com/typeddjango/django-stubs/pull/208 and this patch would help us to pass tests without ignoring errors. Not sure would you accept such patches to test modules, let me know if I have to create ticket for it.

@kalekseev Thanks :+1: Do we need FakeSMTPConnection? I would use backend.connection = mock.Mock() in these tests.

Do we need FakeSMTPConnection? I would use backend.connection = mock.Mock() in these tests.

@felixxm it mostly developer's choice, I prefer fakes because they give me a real interface while mock happily accepts any calls to it, more details: link1, link2. In this case tests doesn't call connection object, otherwise connection = True would fail, so mock is good enough. Another reason was the effort to make tests pass mypy typecheck, boolean instead of SMTPConnection was clear type violation but mock should work.
So I'm okay with mocks too, let me know if I should update pr with mock version.

In this case tests doesn't call connection object, otherwise connection = True would fail, so mock is good enough.

Exactly, we don't really use connection in these tests, I think object() for a fake connection would be even better than Mock(). If it's fine for mypy typecheck, I would change FakeSMTPConnection() to object().

If it's fine for mypy typecheck, I would change FakeSMTPConnection() to object()

Bare object won't pass mypy typecheck, I updated pr with mock.Mock(spec=object())

@kalekseev Thanks :+1:


feat: CLI stacking tutorial

This PR adds a guide on using the CLI to participate in stacking.
Related issue: https://github.com/blockstack/stacks.js/pull/857
Type of Change

[x] New feature
[ ] Bug fix
[ ] API reference/documentation update
[ ] Other

Does this introduce a breaking change?
No
Are documentation updates required?
N/A
Testing information
Run through the guide and ensure all commands work as expected.

Would be great to get this merged soon, I've found myself wanting to point folks to Stacking using the CLI several times recently 🙏🏽

@timstackblock confirmed it can be merged


[Backend] Validation on Notice Keys within Region

Closes #3353
Description Of Changes
When creating or updating a notice, check all existing notices, as well as any incoming notices to see if there are going to be any notice key overlaps within a specific region.
Code Changes

[x] Create a function patterned off of the data use check function that validates notice keys and run this when creating or updating a notice.

Steps to Confirm

[ ] Via the API, run some notice key checks that should fail. For example:
POST /privacy-notice

[
   {
      "name":"Profiling",
      "notice_key": "profiling",
      "regions":[
         "us_oh"
      ],
      "description":"Making a decision solely by automated means.",
      "consent_mechanism":"opt_in",
      "data_uses":[
         "personalize"
      ],
      "enforcement_level":"system_wide",
      "has_gpc_flag":false,
      "displayed_in_overlay":true
   },
   {
      "name":"Essential",
      "notice_key": "profiling",
      "regions":[
         "us_oh"
      ],
      "description":"Notify the user about data processing activities that are essential to your services' functionality. Typically consent is not required for this.",
      "consent_mechanism":"notice_only",
      "data_uses":[
         "essential.service"
      ],
      "enforcement_level":"system_wide",
      "displayed_in_overlay":true
   }
]

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

@allisonking hoping to get your thoughts on this as I believe you pointed out this issue in the original implementation!


blog: Kong Ingress Controller and Istio

This PR is to add a new blog post on how to combine an ingress controller with a service mesh deployed on Kubernetes. Using Kong Ingress Controller and Istio as open-source options, I wanted to create an easy step-by-step guide for anyone trying to recreate this use case.

/retest

/retest

Hello @devadvocado! Unfortunately, you may have to close this and re-open/re-do the PR due to some issues with Netlify 😢

hey @onlydole! if you go ahead and close this, I'll create a new PR with the changes requested above 😄  sorry for the slow response, been on the road

No worries at all, @devadvocado! Thank you for the help - I'll close this for now 😄

/close


ported to Ryven 3.1 dev and minor refactoring

PR to port this to Ryven 3.1 which is not released yet, so do not merge yet. Ryven 3.1 will be a major upgrade for this project too, see also my comment here.

integrated 3d3eede2c4a17c41f56911f585177f19bdd17eee

When ready to pull, could you integrate the last commit about the Section_Node change?
https://github.com/Tanneguydv/Pythonocc-nodes-for-Ryven/commit/ab01677ab676c18ffa8528319fa568831756946c

alright, I added the remaining parts, I think you can merge

your 'added versions' commit consists in adding verion = 'v0.1' to each node, did you mean version = 'v0.1' ?

oh my goodness, you're right, sorry about that, just fixed it


Missing (peer-)dependency on @types/react

react-popper is missing a (peer-)dependency on @types/react.

It will be annoying for not typescript users.

It will also be a hell for TypeScript users to install every missing required dependency by themselves. react-popper chose to include TypeScript types so it should also take the responsibility to declare it's dependencies. Non-TypeScript users wil not notice the difference.

Well, then it should be a direct dependency, but not peer.

I also don't think you will miss to add react in react-ts project.

A direct dependency would be perfect.
I think you are missing the point here. If you have a dependency on a 3rd party dependency you add it to your package.json instead of asking users to also add this package as a dependency in the documentation. If everybody does not add their @@types@ dependencies because it is "annoying" then we might as well just push them all back to DefinitelyTyped. Then there is no point in bundling TypeScript types with packages if all dependencies are missing (even if obvious).


Publish Redshift benchmark results

Publish Redshift benchmark results for native and default approach.
The existing dataset failed with schema mismatch error while inserting rows.
The pandas auto-detection created schema with columns as varchar(256) limiting
the values to be 256 bytes long. However, some row contained a value larger than 256
bytes and then it complained with value too long error.
Hence, we have created new fake data set and kept in S3 with data
of required various sizes for benchmarking purposes and have also updated
the datasets.md to provide details of this new files.

@pankajkoti why did we have to use a fake dataset for redshift?

@pankajkoti why did we have to use a fake dataset for redshift? Can you please add this to the description?

@dimberman That is already added to the description.

@pankajkoti why did we have to use a fake dataset for redshift? Can you please add this to the description?

@dimberman Updated the description. Please check

@pankajkoti Let's not merge this PR until we resolve - https://github.com/astronomer/astro-sdk/pull/805


[FLINK-5836] Fix race condition between offer slot and submit task

The solution is the same as what till described in jira: activating the slots when reserving them on TaskExecutor before offering to JobManager

hi @tillrohrmann, the CI is failing because of my changes, could you help take a look it.

Btw: The failing travis build is due to exceeding the build time.


(issue #5163) Append reminder to nest multi-prompt router prompt output in JSON markdown code block, resolving JSON parsing error.

Resolves occasional JSON parsing error when some predictions are passed through a MultiPromptChain.
Makes this modification to multi_prompt_prompt.py, which is much cleaner than appending an entire example object, which is another community-reported solution.
@hwchase17, @baskaryan
cc: @SimasJan

@wnmurphy thanks, happy to merge this in.
I would expect only a minor improvement to parsing from this change to the prompt. I think to get a larger boost, one would need to add examples that are more concrete.


Simplify how new components are added to Pipeline editor

Currently adding new components to the pipeline editor requires the backend implementation, and updates to multiple canvas related JSON files (pallet, common properties, etc). KFP provides component definitions that can be used to introspect and generate these to simplify the user experience when adding new components.

[ ] Generate pipeline editor configuration dynamically via REST API (see #454)
[ ] Investigate how we could introspect KFP component YAML to generate pipeline editor config files
[x] Integrate discovered components into pipeline editor UI
[x] investigate the need for a whitelist of components
[x] how to support multiple runtimes on this scenario (e.g. only display KFP vs airflow components)

Going back to the overall idea here, imagine we have a KFP component like this:
name: 'Train Spark Model - IBM Cloud'
description: |
  Train a Spark Model using IBM Cloud Spark Service
metadata:
  annotations: {platform: 'IBM Cloud Spark Service'}
inputs:
  - {name: bucket_name,      description: 'Required. Object storage bucket name'}
  - {name: data_filename,    description: 'Required. Name of the data binary'}
  - {name: model_filename,   description: 'Required. Name of the training model file'}
  - {name: spark_entrypoint, description: 'Required. Entrypoint command for training the spark model'}
outputs:
  - {name: model_filepath,           description: 'Spark Model binary filepath'}
  - {name: train_data_filepath,      description: 'Spark training data filepath'}
implementation:
  container:
    image: docker.io/aipipeline/train_spark:latest
    command: ['python']
    args: [
      -u, train_spark.py,
      --bucket_name, {inputValue: bucket_name},
      --data_filename, {inputValue: data_filename},
      --model_filename, {inputValue: model_filename},
      --spark_entrypoint, {inputValue: spark_entrypoint}
    ]
    fileOutputs:
      model_filepath: /tmp/model_filepath
      train_data_filepath: /tmp/train_data_filepath

The idea is that we would produce a palette.json for the canvas component that would then include the discovered Train Spark Model, and we would also introspect the metadata for this component and harvest inputs, outputs, etc to generate a valid properties.js that would be used by common properties component to allow the user to provide parameters to these components.

@lresende @kevin-bates i would interested in assisting with this effort

This requested functionality was delivered with the introduction of component catalog connectors.


[Docs] Page on postponed annotations is confusing (example doesn't actually contain postponed annotations?)

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
https://docs.pydantic.dev/latest/concepts/postponed_annotations/ This doc page is a bit confusing - I might be confused, but the initial section doesn't actually contain anything that requires postponed annotations? What is it trying to show?
Example Code
No response
Python, Pydantic & OS Version
Irrelevant

The example is pretty contrived as it indeed does not require stringified annotations to work. I'm in the process of writing docs for our forward annotations evaluation logic, so I'm going to tackle this at the same time (https://github.com/pydantic/pydantic/pull/10592).


fix(material-experimental): strong focus indicator clipped in checkbox and radio button

In order to support density scaling, the MDC checkbox and radio button have border-radius: 50% on their ripple element which is also used as the strong focus indicator. Since the indicator is a square, it'll be clipped, unless we also make it into a circle.
For reference, here's what the circular indicators look like:

cc @zelliott

LGTM


Get height of the scailed image

Is your feature request related to a problem? Please describe.
When we do {{ slide.thumbnail.height|resize(1000) }} the original image height is being used of course.
Describe the solution you’d like
I'd like to have the way of knowing the height after image is being resized
Describe alternatives you’ve considered
I have to use for example resize(0, 1000) to get fixed height

Agreed! I find a good place to start with something like this is to imagine the API you'd expect (or desire) to work with in Twig. Then it becomes easy(er) to reverse engineer and figure out how to supply the correct values. Do you have thoughts on that Q? @errand ?

For now i ended up with an extra function for calculating future dimentions of the image:
function getScaledDimentions($originalHeight, $originalWidth, $newWidht = 1, $newHeight = 1, $val = 'w'){ 	$aspectRatio = $originalWidth/$originalHeight; 	if($val == 'w'){ 		return floor($newHeight * $aspectRatio); 	} else { 		return floor( $newWidht / $aspectRatio); 	} }
Eventually i'm not so sure that timber is lacking of the function i'm demanding. We can extend it ourselve.

Seems like this can be closed?

Seems like this can be closed?

@acobster agreed. We got plenty of open issues; something that can always be revisited should the universe demand

@acobster agreed. We got plenty of open issues; something that can always be revisited should the universe demand


WIP: [ci] [python-package] fix missing import, test that lightgbm can be imported with only required dependencies (fixes #5631)

Fixes #5631.
#5271 added an import from scikit-learn but didn't add the corresponding empty import in compat.py to handle the case where scikit-learn is not installed.
As a result, I believe that using the Python package without scikit-learn has been broken for the last 4 months.
This PR proposes the following:

fix that specific import issue
add a check in CI to prevent issues like this in the future

I initially just pushed the CI changes, and can see that they DO catch the exact error reported in #5631 🎉

ImportError: cannot import name '_LGBMBaseCrossValidator' from 'lightgbm.compat'

And only on the regular task, as intended

❌ regular (macOS-latest, Python 3.8) (Azure build link)
❌ Linux regular (Azure build link)
❌ Linux_latest regular (Azure build link)
❌ macOS regular (Azure build link)

Now that there's evidence that that check would catch this, I'll push a fix for the specific issue.

Do you think it'd be worth (maybe in a separate PR) to run the tests as well without the required dependencies? It could help us avoid issues like #4638.

Do you think it'd be worth (maybe in a separate PR) to run the tests as well without the required dependencies?

Yeah I think that could be helpful for catching other issues like the one you linked and like #5631!
I'd also love to see us take on tests like the following:

oldest-supported CMake + oldest-supported versions of pandas, scikit-learn, numpy, scipy

I should really write this up in an issue....I'll do that

#4406
#4407


Extra documentation added to pitfalls section

I added some confusing points to the documentation.
These are discussed in:
https://github.com/detekt/detekt/issues/2663
https://github.com/detekt/detekt/issues/2645#issuecomment-622217315

Thank you very much!


Meta information on blocks, items, and mobs.

This is a feature request.
It would be nice if the Malmo library could provide more meta information about blocks, items, and mobs. For example, which block types block the agent's movement, which don't? Which ones block the view partially or completely? E.g., we can walk through a potato field, and we can see "through" the plant blocks. This is losely related to #173, however, the ability of blocks to drop as items is only one property of interest.
Simple example, the information whether a block type blocks movement or not is essential for path planning. Of course, this information can be learned from trial and error. But if I want to provide it to the agent as expert knowledge then it must be hard-coded, and doing this in the library is more efficient than everyone creating their own property lists (that's what I currently do, it is cumbersome and error-prone).
Is it possible to extend Types.xsd for this purpose? On the software level, an interface for querying properties by name would be nice, but compile time constants (arrays) are also fine.
Aside from technical considerations, it is not really clear which properties (formulated in high-level terms of game mechanics) are useful, but anyway, providing a basic set is probably a good start.

I take your point about the efficiency of hard-coding this expert knowledge centrally, but I'm not convinced the core Malmo platform is the place to do this. One thing we'd really like to avoid is re-implementing Minecraft logic in Malmo. We'd like to keep the roles separate: Minecraft provides the world; the agent experiences the world; Malmo provides the interface to make that happen. As far as possible, the agent should be learning directly from Minecraft, not from Malmo itself.
Perhaps the grid observations, when we revamp them, could distinguish between solid and permeable blocks - but you'd still have issues with things like water or cobwebs, which are technically permeable, but which slow the agent, or move them around. Minecraft is a rich environment, where most simple rules have exceptions - doors obstruct you, but not if they are open... closed doors obstruct you, but not if they are linked to a pressure-plate... lava obstructs you, but not if you are impervious to fire... There's a limit to what properties we can usefully expose before we find ourselves having to implement all of Minecraft's game logic in our own library...
We'll have a think, but when it comes to specific hard-coded expert knowledge, I suspect it's better if everyone provides their own. It's readily available on the internet, on all the various Minecraft wiki sites, and my suspicion is that every researcher will have different requirements.

I understand that you don't want this to be part of Malmö. Keeping it slim and simple is good for many reasons. Lists of properties are hard to maintain. And sure, learning is preferred over engineering. However, sometimes we may want to bring an agent up to speed without solving all lower level problems first, or we may want to create a "teacher" agent. Whether this makes sense or not depends on the research question.
Driving your argument to the extreme, the lists of block and item lists should be removed. The information could be learned. No, please don't do that :) All I want to say is that the amout of hard-coded information is somewhat arbitrary.
One example where trial-and-error based learning is actually hopeless is figuring out the crafting recepies. Also as a human player you have to look them up on the wiki, because the space of possible recepies is huge, something like pow(number of block and item types, 9). So they have to be made available to the agent, in one way or the other. For this case Malmö already provides a sensible solution via the "craft" command, in combination with listing all block and item types. Similarly, a function a la bool AgentHost::can_I_enter_this_block(...) could be helpful.
For many properties, I agree that rules are necessarily fuzzy. Covering 95% is easy, the rest would be prone to over-engineering. So this is hard to represent in data. Crawling the wiki could indeed be a sensible solution for the easy 95%, thanks for the hint. I may well go for that at some point. Still, others may have the same problem...

A brief update on this issue. In the meantime I have crawled the wiki and extracted some properties of blocks and items, most of which are non-essential but nice to have. The wiki is not intended to be machine readable, so I had to catch many corner cases and the data is probably not 100% correct. It is okay for my purposes right now.
Just as a note in reference to #173: The information in the "Drops" category is extremely diverse and hard to parse, therefore I decided to ignore it for now.
One useful bit of information is whether blocks are "transparent", i.e., whether they block the view entirely or not. I use this to emulate vision from the grid observations. It is of course simplified, but it comes close to what I expect a minimal vision module to do: return all visible blocks in the vicinity.
The wiki does not answer the question whether a block can be walked through or not, so I added this data manually. Currently it is only one bit per block type. I'll have to define more categories, like "character cannot enter the block (otherwise suffocates)", "character can pass block in all directions", "character cannot pass bottom face" (e.g., lili pad).

Some of this falls right into what i consider fun.
Seems to me that as suggested, malmo should not initially hold any data about items, any items, at all, but provide instead some method of adding basic data, in the form of subsets. Given that we are using satans own database format (XML) it is relatively trivial to add to the system properties as discovered by the agent. I do have some trouble understanding how this might be achieved right now considering the weird way things are done.
As far as recipes are concerned, i'm assuming you are talking about crafting the items you need, the crafting system of the PC minecraft is deliberately and arbitrarily asinine, thats as polite as i'm ever going to get, there should be a lookup table of items an actor needs, and there should be a list of materials needed to create that item. You can layer this lookup system as needed, and add extra learning as needed, the in built chain of things you need to do to make each thing you need to make before you can make item x (enchanted book of feather falling level 4 for example) should already be available based on previous work anyway.  But if the actor wants an iron pick, he should throw 3 iron and a couple sticks in the crafting table, and malmo can intercept and work some maqic, because i can guarantee that unless you provide infinite stacks of sticks and piles or iron ingots, i find it unlikely that these recipes will be discovered. If theres a probability genius who can quick do the math of how many potential combinations of crafting can be created in a 3x3 grid with eve the exact composition (3 iron, 2 sticks).
TL;DR Malmo needs to add a function whereby an item can be identified by the agent, multiple levels of identification are needed from basic through to full disclosure.
Also, crafting is nasty, needs fixing, perhaps upgrading to console version crafting, anybody arouind here have MC sources.... 😈

@Bloodknight, I have two comments.
First, we should distinguish between information you intend to provide to the agent and those learned through interaction. I don't think that Malmö should ever care about managing the latter. That data belongs to your controller. It cannot be Malmö's task to manage the internal state of your control program. Malmö should only provide an interface to interact with the game. It turns out that some aspects of the game as very complex. Therefore we need some additional data (see below). However, I am only talking about static/constant data.
Second, I consider the larger part (combinatorial complexity) of the crafting problem solved, check out the SimpleCraftCommand:
https://github.com/Microsoft/malmo/blob/master/Schemas/MissionHandlers.xsd#L912
Sure, we still need lists of crafting ingredients. This is an example of additional static data that should be provided by Malmö. Actually, it should be provided by Minecraft, since realistically, without the wiki the game cannot be played.
Combining this information by recursively traversing the more and more basic ingredients needed for crafting a complex item is an inherent aspect of the game complexity. Call it asinine, but the long planning horizon required to craft complex items is one of the fascinating aspects of playing the game (manually or automated).
So I may end up writing another helper script to extract crafting ingredients from the wiki. Actually, that involves parsing html, which I consider even more diabolic than the basic subset of XML.
In short, I still see a need for some additional information provided by Malmö, but it is not all that bad :)

The chain of construction from basic to complex is fine, the asinine part is the exact shape pattern you must fill in in order to create... anything, even in terms of minecraft this exists in precisely 2 of 6? 5? versions, and that can be disabled in one, leaving the PC as the one and only version where arbitrary patterns are required to craft, rather than simple material provision and item request.
Static constant data is only as useful as the current version of minecraft, however what i meant by allowing or telling malmo to provide specific sets of data, would be in the form of differentiation between block types based purely on what tool you need for example. Another sample set would be a base tool set, so that the agent can have access to an axe for trees, pick for stone/rock/ore and shovel for sh...and....
The other point i made was simply that minecraft knows everything, so why in the heck malmo needs to know what minecraft knows i don't know, what it needs is the functionality to get that data from minecraft.
Extracting data from 3rd party sources when you have access to the primary resource has me scratching my head tbh (not only primary resource but also the tools to completely deobfuscate the source code if needed)
Just as a side comment, it appears you misunderstood most of my previous posts, it could be my writing style of the fact that researchers and game developers don't speak the same english.
My main point being that malmo should have the ability to provide what information you or i need to use to give the agent what (tools, info, resource) we want the agent to have, seems to me on the whole we agree on most points here :)

Thanks for clarifying, I see you point :)

Just revisiting this old thread.
"Extracting data from 3rd party sources when you have access to the primary resource has me scratching my head tbh"
Granted, but writing code so that other people can write code so that they can extract information which is already freely available on the internet... well, that doesn't make much sense either. Particularly when it's static information which only needs to be retrieved once, and writing the Malmo code to retrieve it would be non-trivial and time-consuming.
I'm closing this thread as being outside of Malmo's scope.
Although, FWIW, there is some test code in Malmo which will let you dump out a list of recipes... just hit "U" while in-game, and a file called "recipe_dump.txt" will get spat out into your Minecraft folder...  it will look like this:
1xtile.blockLapis = 9xitem.dyePowder.blue(Lapis Lazuli)
1xtile.blockCoal = 9xitem.coal(Coal)
1xtile.hayBlock = 9xitem.wheat(Wheat)
1xitem.ingotGold = 9xitem.goldNugget(Gold Nugget)
1xitem.ingotIron = 9xitem.ironNugget(Iron Nugget)
1xitem.rabbitStew = 0xtile.air(Air), 1xitem.rabbitCooked(Cooked Rabbit), 0xtile.air(Air), 1xitem.carrots(Carrot), 1xitem.potatoBaked(Baked Potato), 1xtile.mushroom(Mushroom), 0xtile.air(Air), 1xitem.bowl(Bowl), 0xtile.air(Air)
1xitem.rabbitStew = 0xtile.air(Air), 1xitem.rabbitCooked(Cooked Rabbit), 0xtile.air(Air), 1xitem.carrots(Carrot), 1xitem.potatoBaked(Baked Potato), 1xtile.mushroom(Mushroom), 0xtile.air(Air), 1xitem.bowl(Bowl), 0xtile.air(Air)
1xtile.melon = 9xitem.melon(Melon)

Thanks David. The U command sounds very useful - although adding the file to the repository would have done the job. Nice machine readable data :)
I don't fully agree with the "information which is already freely available on the internet" part, since the whole point of my request is to have that information in machine readable (straightforward to parse) format. The information must exist somewhere in Minecraft's logic (that's Bloodknight's point), however, I understand that it may exist in logic, not necessarily in tabular form, and it seems to be hard to extract and/or to provide. That's a pity, and I can live with having to learn the information through interaction.


How to create a .net standard client?

Hi,
I have a .net standard class library which needs to connect to ASP Core Signal r Hub. Is this achievable? If yes how?
Is there a nuget package i can use?
Regards,
Ali

What version of SignalR are you using?

I do not have a server yet, I need to create both server and client while the Server will be ASP.NET Core and client will be .Net Standard
I can use any version which will allow me to do this. Hoping for a nuget package or something similar to achieve this.

The packages for SignalR ASP.NET Core are available on the https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json feed. Your server will need to use Asp.NET Core 2.0

@moozzyk I get following error the moment i add Microsoft.AspNetCore.SignalR.Http package to my server.

Most likely you are mixing versions.

Following is all that i have installed in an empty ASP.NET Core Web application, the moment it is installed i get above error.

@malichishti - you also need 2.0 runtime and matching libraries.

@moozzyk - Its already added:

the project works fine if i uninstall Microsoft.AspNetCore.SignalR.Http

You need newer bits than 2.0.0 to use AspNetCore.SignalR, i.e. use 2.1.0-preview1-26462 of Microsoft.AspNetCore.All

Thank you that solved it.


error when create vm

Scenario

create storagecluster & vdisk
create vm

request
{
	"id": "test",
	"memory": 1024,
	"cpu": 1,
	"nics": [],
	"disks": [
		{
			"vdiskid": "ubuntu-image",
			"maxIOps": 2000
		}
	],
	"userCloudInit": null,
	"systemCloudInit": null
}

ays error
[Sun02 10:24] - Job.py              :57  :j.core.jobcontroller.job.8514d6d934832c7da98470e810604717 - ERROR    - Traceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/container/0545b041d699ef4c895f81640b8644d5.py", line 59, in start
    container = Container.from_ays(service, job.context['token'])
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Container.py", line 86, in from_ays
    node = Node.from_ays(service.parent, password)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Node.py", line 33, in from_ays
    timeout=timeout
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Node.py", line 18, in __init__
    self._client = Client(host=addr, port=port, password=password, timeout=timeout)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 2061, in __init__
    raise RuntimeError("Could not connect to remote host %s" % host)
RuntimeError: Could not connect to remote host <IP_ADDRESS>
[Sun02 10:25] - Job.py              :57  :j.core.jobcontroller.job.7a9c7c961be04702a47c996fca212237 - ERROR    - Traceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/vm/5baead8c7afed9d1e4a3f0e350844857.py", line 525, in init
    tlog_container = create_zerodisk_container(job, node)
  File "/tmp/actions/vm/5baead8c7afed9d1e4a3f0e350844857.py", line 187, in create_zerodisk_container
    j.tools.async.wrappers.sync(containerservice.executeAction('start', context=job.context))
  File "/opt/code/github/jumpscale/lib9/JumpScale9Lib/tools/async/Wrappers.py", line 12, in sync
    return loop.run_until_complete(coro)
  File "/usr/lib/python3.5/asyncio/base_events.py", line 387, in run_until_complete
    return future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
    raise self._exception
  File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
    result = coro.throw(exc)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/lib/Service.py", line 679, in executeAction
    return await self.executeActionJob(action, args, context=context)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/lib/Service.py", line 704, in executeActionJob
    result = await job.execute()
  File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/container/0545b041d699ef4c895f81640b8644d5.py", line 59, in start
    container = Container.from_ays(service, job.context['token'])
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Container.py", line 86, in from_ays
    node = Node.from_ays(service.parent, password)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Node.py", line 33, in from_ays
    timeout=timeout
  File "/usr/local/lib/python3.5/dist-packages/zeroos/orchestrator/sal/Node.py", line 18, in __init__
    self._client = Client(host=addr, port=port, password=password, timeout=timeout)
  File "/usr/local/lib/python3.5/dist-packages/zeroos/core0/client/client.py", line 2061, in __init__
    raise RuntimeError("Could not connect to remote host %s" % host)

software verison
master 10710d86

Software Version
d7c691a81bcd6166e5a5046b7b3c5a1f942be39b


21.05 Feature Freeze

Pinging all language, framework, and ecosystem owners to consolidate feature freeze items for the 21.05 release.
Please mention any items you see blocking the 21.05 release in your given domains. The branch off date will be the on the 21st of May. So there is still some time to address these items.
Nix/nix-cli ecosystem: @edolstra @grahamc @nbp @Profpatsch
Mobile: @samueldr
Nixos Modules / internals : @Infinisil @matthewbauer @Ericson2314 @orivej
Nixos tests: @tfc
Marketing: @garbas
Emacs: @adisbladis
Erlang: @gleber
Go: @kalbasit @Mic92 @zowoq
Haskell: @NixOS/haskell
Python: @FRidh
Perl: @stigtsp
php: @NixOS/php
Ruby: @alyssais
rust: @bhipple @Mic92 @andir @LnL7
Darwin: @NixOS/darwin-maintainers
bazel: @mboes
blockchains @mmahut
podman: @NixOS/podman
Gnome: @jtojnar @NixOS/gnome
Qt / KDE: @ttuegel @NixOS/qt-kde
Postgres: @thoughtpolice
in case I forgot anyone: @NixOS/nixpkgs-committers
Anyone is free to propose potential blockers, but I would ask that you remember that this is a volunteer organization. Unless someone is likely to "pick up" the work and address the concern in the coming weeks, please only state critical issues. Or if anyone is active in a given ecosystem and I did not mention them, then they are free to state that there's unlikely to be any concerns as well.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/21-05-release-feature-freeze/12933/1

Not blocking per se, but would need to be merged in case it's forgotten.

#121450
#121720
#121834

The one about the Raspberry Pi image would need something else on stable if for any reason we cannot land it before the branch-off. Well, it'd need to be applied as it is on 21.05 even if we ended up not wanting it right now in unstable.
The other two I intend to merge by next week if it's not done beforehand. Neither of which are breaking changes or new features, mainly correctness changes for ARM installers.

My goal is to get the Sourcehut service in:

113244

I would like to get WireGuard DNS refresh merged: https://github.com/NixOS/nixpkgs/pull/121331

I'd like to get QuickBMS (https://github.com/NixOS/nixpkgs/pull/121523) merged, I want to use it to package software that's only available in Windows installers.

It would be a good thing to fix #121293 before the freeze.

It would also be good to fix https://github.com/NixOS/nixpkgs/issues/121994 before the freeze and/or definitely before the release. We have potentially broken Cargo hashes in Rust-based derivations.

GNOME 40 is likely ready, just waiting for a confirmation from @LEXUGE whether the patch from Fedora unbroke log-in with a fingerprint reader (and the other critical issue).

Not a blocking one  #118573 . It's all about to have a clean OverlayFs multiple lower layers support.

for erlang and elixir related stuff, feel free to mention the beam team.
I don't see anything blocking. There are a couple of interesting things being worked on #121555 but it won't be ready before the release I think.

GNOME 40 is likely ready, just waiting for a confirmation from @LEXUGE whether the patch from Fedora unbroke log-in with a fingerprint reader (and the other critical issue).

As I mentioned in the PR, the patch fixed the problem of not being able to key in passwords. However, it still doesn't log me in with fingerprint. Not sure if it qualifies as a fix.

I'd like to get Ansible updates in and EOL versions out, they're over in #122670.

I'd like to get #120440 and #122241 in, as well as #121777 and the fixes necessary for TLS keys to work with the dendrite module using https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Credentials.
cc @mjlbach

It would be great if 21.05 had the some of the latest Erlang/Beam ecosystem changes:

#122646 introduces Erlang language server (erlang-ls)
#122723 adds Erlang R24
#122632 adds rebar3-nix

Maybe even #122633 if possible?

Not a language or framework, but I would like to get this in, as the current version is old:
https://github.com/NixOS/nixpkgs/pull/122140

Since I have been doing some vscode extension updates for myself, #122913 should be uncontroversial and specifically updates a couple of microsoft owned extensions to vscode.  I think the live-share extension is most important in that PR because I fear the risk of incompatibilities.  I confirmed both extensions are behaving for me.  Including doing a live-share between nixos and debian.

It would be great if we could get the openblas update merged https://github.com/NixOS/nixpkgs/pull/122035.

I don't want to be forced to set an OnCalendar value in the postgresqlBackup module.
https://github.com/NixOS/nixpkgs/pull/123006

I'm finding that building openblasCompat from this is causing my darwin machine, which has a setup very much like hydra's, to hang. Hope it doesn't have the same effect on hydra. Not that it's ultimately the fault of this package, I think.

Small version update, but it makes microsoft's python-language-server work with Python 3.9, which I think would be appropriate  for 21.05: https://github.com/NixOS/nixpkgs/pull/121522

I would like to get these ones in before the freeze:

#121708 - securely replace secrets in various modules
#121778 - various keycloak module fixes (security related and not) that would be good to have in its first stable release
#121145 - replace the broken geoip-updater module

Can we get https://github.com/NixOS/nixpkgs/pull/121588 before freeze?
It renames sip to sip_4 and sip_5 to sip. sip_5 never made it into stable, so if we rename it now we can avoid adding an alias.

For clarification, the original intent of this is for large ecosystems to express anything that's imperative to have in the next release. Most PRs that are targeting master aren't affected by this.
If you just want someone to review your PR, just cc me in the PR please. Or post on the PRs ready for review thread

I would love to see #123074 merged into final staging-next round, LLVM bump was one of the main "features" of rust 1.52 release, https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler

Any future staging PRs will need to be backported into the release. The backport staging branch won't be created until next week as well.

I labeled it, but https://github.com/NixOS/nixpkgs/pull/123415 from @sternenseemann is a fantastic catch of an old bug that somehow slipped underneath the radar for at least one release cycle.

Also, I wanted to notify that bluetooth headsets are harder and harder to use (at least on my computer) since 20.09 (just created a bug report there): I need to kill pulseaudio & restart applications to be able to switch to bluetooth, audio is muted by default, and since more recently I can't anymore use high fidelity bluetooth output (I'm stuck with the low quality sound+microphone mode). I'm not sure if I'm the only one experiencing such troubles, but I'm thinking that it could be great to fix bluetooth issues before releasing 21.05.

@tobiasbora pipewire has a lot better support for Bluetooth headsets, so that's your best bet.
Pulseaudio development was a mess for the last couple of years and pipewire just has better architecture going forward.

@domenkozar I can confirm that after a quick test, pipewire has much better support than pulseaudio (and supports much more bluetooth profiles). But I have 3 new issues with pipewire (maybe related):

Impossible to change volume with the volume keys on the keyboard (on KDE Plasma), I need to use pavucontrol to do so
The "volume" icon in the systray is not present anymore
pactl command is not present anymore: some people seem to have this command present, and it proves useful to use command lines to change volume, like pactl set-sink-volume @DEFAULT_SINK@ +10% or to check that the system is using pipewire and not pulseaudio (with pactl info). This command is present in pulseaudio packages, but I'm afraid to have conflicts between pulseaudio and pipewire if I install it.

I also tried to add my user to the audio group, it does not change anything.

@tobiasBora as explained by @jonringer above:

For clarification, the original intent of this is for large ecosystems to express anything that's imperative to have in the next release. Most PRs that are targeting master aren't affected by this.

Please don't post issues you're having with packages here, let's try to keep this focused :)

Seeing as the release is scheduled for tomorrow (will likely be pushed back until staging-next jobsets get closer to completing), I'm going to close this issue.

I'm late to this, but we should really get https://github.com/NixOS/nixpkgs/pull/124300 in 21.05, because https://ferd.ca/you-ve-got-to-upgrade-rebar3.html

Security fixes are never late.  They're the main point of maintaining release branches.

https://github.com/NixOS/nixpkgs/pull/124776
If this could be included in the 21.05 release then current users using the nixpkgs.config.dwm.patches interface wouldn't end up with a broken system on upgrade


When scrollbarH is set to "true", vertical scroll bar also appears and pagination breaks

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
I'm setting scrollbarH property to true and getting both horizontal and vertical scrollbars and the table is reloading itself each time I do scrolling, pagination doesn't work
When I scroll I see in network request list that it sends requests for reloading table data. When I press on pagination numbers it sends correct request, but immidiately after it it sends request for first page. So pagination doesn't work.
Expected behavior
If I set [scrollbarH]="true" only horizontal scrolling should be available, no vertical scrolling, no reloading the table, no broken pagination.
Reproduction of the problem

Create table with the following properties:
<ngx-datatable
[rows]="rows"
[columnMode]="'standard'"
[rowHeight]="'auto'"
[selectionType]="'row'"
(select)="saveSelectedRow($event)"
[reorderable]="false"
[columns]="columns"
[externalPaging]="true"
[count]="page.totalElements"
[offset]="page.number"
[limit]="page.size"
[footerHeight]="50"
[externalSorting]="true"
(sort)="onSort($event)"
[sorts]="[{prop: sort? sort.prop : null, dir: sort ? sort.dir : null}]"
(page)='onPage($event)'
[scrollbarH]="true"

Provide row set with more than 15 rows and a lot of colums (about 15).
Check table scrolling and validation

What is the motivation / use case for changing the behavior?
The table is too wide, I badly need horizontal scroll
Please tell us about your environment:
Windows 10, IntelliJ Idea Ultimate, npm

Table version:
13.1.0

Angular version:
Angular 6

Browser: [ Chrome 68.0  ]

Language: [ TypeScript, compiler v1.7.3 | ES5.1 ]

Even if I turn off vertical scroll manually via
ngx-datatable {
datatable-body {
overflow-y: hidden;
}
}
when I am trying to obtain some page there are more than 1 request sending to server, last request is getting the first page again, so pagination doesn't work.

[virtualization]="false" - helped. Thanks, seems that it works now