Stellar Lumens STOLEN > !

God dam it I've fallen for a Stellar Lumens scam and lost 17k XLM ! I don't suppose theres any way to get them back?
Seem the funds I've sent to the scammer have ended up in this wallet  :
GAF6XHGIRIMWG5BXR5OVPWHRZIJ4DOPQN4AEXT3VI2GZJHGLCJGFKQTQ
The wallet still shows a balance of over 1m XLM !
I was obviously dubious on seeing the initial email sent to me from what looked like Binance. I decided to head directly over to the stellar foundation site to check on staking and everything seemed to add up!
The process seemed so legitimate! I can't believe how it trapped me. Somehow I was fooled into thinking I was still on the legitimate Stellar foundation site whilst setting up the transfer for staking!
Geeezus ! Dam these people ...

God dam it I've fallen for a Stellar Lumens scam and lost 17k XLM ! I don't suppose theres any way to get them back?
Seem the funds I've sent to the scammer have ended up in this wallet :
GAF6XHGIRIMWG5BXR5OVPWHRZIJ4DOPQN4AEXT3VI2GZJHGLCJGFKQTQ The wallet still shows a balance of over 1m XLM !
I was obviously dubious on seeing the initial email sent to me from what looked like Binance. I decided to head directly over to the stellar foundation site to check on staking and everything seemed to add up!
The process seemed so legitimate! I can't believe how it trapped me. Somehow I was fooled into thinking I was still on the legitimate Stellar foundation site whilst setting up the transfer for staking!
Geeezus ! Dam these people ...

See my post yesterday, I had the same thing happen to me. 181,000 XLM stolen!

Are you a Binance member? I suggest reporting it to them asap, I am in the process of raising a scam report with them and Binance are following up. If you can put together a list of transactions beginning from your wallet.Follow the trail and you’ll see that the millions of XLM funds are now being transferred onto crypto exchanges and are being sold off now.Also report it to the Police and fraud action departments.
Good luck
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 1:11 am, gcr47 @.***> wrote:
See my post yesterday, I had the same thing happen to me. 181,000 XLM stolen!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

If you are UK based I suggest contacting them asap. Are you able to send me the transaction ID for the funds you sent? As I have an active case I can perhaps ask them to include this in the investigation.
Best
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 7:52 am, pipo @.***> wrote:
Are you a Binance member? I suggest reporting it to them asap, I am in the process of raising a scam report with them and Binance are following up. If you can put together a list of transactions beginning from your wallet.Follow the trail and you’ll see that the millions of XLM funds are now being transferred onto crypto exchanges and are being sold off now.Also report it to the Police and fraud action departments.
Good luck
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 1:11 am, gcr47 @.***> wrote:
See my post yesterday, I had the same thing happen to me. 181,000 XLM stolen!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I am un the USA, but please include my transaction ID as well if you can.
Much appreciated! See ID below:
Transaction ID 9c9fc832bfc81e7b20d18d24888e6f13d391f622055edb431a3063075a84f518
2023-06-21 16:29:17 UTC
https://stellar.expert/explorer/public/tx/9c9fc832bfc81e7b20d18d24888e6f13d391f622055edb431a3063075a84f518
On Sat, Jun 24, 2023, 01:57 piposan @.***> wrote:

If you are UK based I suggest contacting them asap. Are you able to send
me the transaction ID for the funds you sent? As I have an active case I
can perhaps ask them to include this in the investigation.
Best
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 7:52 am, pipo @.***> wrote:
Are you a Binance member? I suggest reporting it to them asap, I am in the
process of raising a scam report with them and Binance are following up. If
you can put together a list of transactions beginning from your
wallet.Follow the trail and you’ll see that the millions of XLM funds are
now being transferred onto crypto exchanges and are being sold off now.Also
report it to the Police and fraud action departments.
Good luck
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 1:11 am, gcr47 @.***> wrote:
See my post yesterday, I had the same thing happen to me. 181,000 XLM
stolen!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
@.***>
—
Reply to this email directly, view it on GitHub
https://github.com/stellar-expert/stellar-expert-explorer/issues/740#issuecomment-1605292534,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAYO65DMN37EFXAC4SJKY2LXM2FWRANCNFSM6AAAAAAWYMALL4
.
You are receiving this because you commented.Message ID:
@.***>

And here is where they take my fund and send to another address, then to a
final address where my stolen funds currently sit.
Please include these transaction IDs along with your case on Binance.  See
below:
Transaction ID
fbf7613b2b271694e7d6b1d171e9a5db504e2f12f2a4c83e7849cddb9ccca1a5
https://stellar.expert/explorer/public/tx/fbf7613b2b271694e7d6b1d171e9a5db504e2f12f2a4c83e7849cddb9ccca1a5
GBHPXJWO3CZOQJ7QZZBP62U6NQZW6MPBKO2QSY6BUZZ66GP6PP5OR457 (then sent the
money)
created/funded GBENQQUDHRSE4FESH66HOVX2TZLWMURZJTNDJX5ZNTDVFUPAFW3UTP2U
wallet with all the funds. As seen here: Transaction ID
609551bf0c06052cae6d3045d1e4d8783c80efe24a81b3aff2f225ba45bc4da5
https://stellar.expert/explorer/public/tx/609551bf0c06052cae6d3045d1e4d8783c80efe24a81b3aff2f225ba45bc4da5
On Sat, Jun 24, 2023, 01:57 piposan @.***> wrote:

If you are UK based I suggest contacting them asap. Are you able to send
me the transaction ID for the funds you sent? As I have an active case I
can perhaps ask them to include this in the investigation.
Best
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 7:52 am, pipo @.***> wrote:
Are you a Binance member? I suggest reporting it to them asap, I am in the
process of raising a scam report with them and Binance are following up. If
you can put together a list of transactions beginning from your
wallet.Follow the trail and you’ll see that the millions of XLM funds are
now being transferred onto crypto exchanges and are being sold off now.Also
report it to the Police and fraud action departments.
Good luck
Sent from Yahoo Mail for iPhone
On Saturday, June 24, 2023, 1:11 am, gcr47 @.***> wrote:
See my post yesterday, I had the same thing happen to me. 181,000 XLM
stolen!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
@.***>
—
Reply to this email directly, view it on GitHub
https://github.com/stellar-expert/stellar-expert-explorer/issues/740#issuecomment-1605292534,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAYO65DMN37EFXAC4SJKY2LXM2FWRANCNFSM6AAAAAAWYMALL4
.
  Please keep me updated on your progress, as well as if you are able to add my transaction string to your Binance complaint.  We need to get the guys responsible for this and get our funds back!  Let me know what else I can do to help!Thanks,Grant Sent from Mail for Windows From: piposanSent: Saturday, June 24, 2023 1:57 AMTo: stellar-expert/stellar-expert-explorerCc: gcr47; CommentSubject: Re: [stellar-expert/stellar-expert-explorer] Stellar Lumens STOLEN > ! (Issue #740) If you are UK based I suggest contacting them asap. Are you able to send me the transaction ID for the funds you sent? As I have an active case I can perhaps ask them to include this in the investigation. Best Sent from Yahoo Mail for iPhone On Saturday, June 24, 2023, 7:52 am, pipo<EMAIL_ADDRESS>wrote: Are you a Binance member? I suggest reporting it to them asap, I am in the process of raising a scam report with them and Binance are following up. If you can put together a list of transactions beginning from your wallet.Follow the trail and you’ll see that the millions of XLM funds are now being transferred onto crypto exchanges and are being sold off now.Also report it to the Police and fraud action departments. Good luck  Sent from Yahoo Mail for iPhone On Saturday, June 24, 2023, 1:11 am, gcr47<EMAIL_ADDRESS>wrote: See my post yesterday, I had the same thing happen to me. 181,000 XLM stolen! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID<EMAIL_ADDRESS>
Piposan,
I sent you all the string of my transactions and where my stolen XLM currently are sitting in the public address ending in TP2U.  Please keep me updated on your progress, as well as if you are able to add my transaction string to your Binance complaint.  We need to get the guys responsible for this and get our funds back!  Let me know what else I can do to help!Thanks,Grant

Ultimately you need to contact binance a record a complaint yourself. I am waiting for the police to contact me before binance will progress the issue.
My advice at this stage is contact binance asap.
Sent from Yahoo Mail for iPhone
On Sunday, June 25, 2023, 1:32 am, gcr47 @.***> wrote:
Piposan,
I sent you all the string of my transactions and where my stolen XLM currently are sitting in the public address ending in TP2U. Please keep me updated on your progress, as well as if you are able to add my transaction string to your Binance complaint. We need to get the guys responsible for this and get our funds back! Let me know what else I can do to help!Thanks,Grant
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Nothing ???? Has Nobody else had this same issue ?

I had lost a lot of coins in some scam case just like this thanks to the best hacker in the world who helped me recover all my funds,message him on telegram his telegram username is https://t.me/Blackhathacker110

Piposan,
I sent you all the string of my transactions and where my stolen XLM currently are sitting in the public address ending in TP2U. Please keep me updated on your progress, as well as if you are able to add my transaction string to your Binance complaint. We need to get the guys responsible for this and get our funds back! Let me know what else I can do to help!Thanks,Grant

Did you contact Binance? I've been in touch with the cyber crime devision here in the UK but unfortunately nothing appears to have progress as yet :O( Binance can not fully investigate the crime until the crime department certifies my claim.
If you didn't contact Binance I suggest you do as this might push the investigation forward.

Nothing ???? Has Nobody else had this same issue ?

I had lost a lot of coins in some scam case just like this thanks to the best hacker in the world who helped me recover all my funds,message him on telegram his telegram username is https://t.me/Blackhathacker110

I've just been screwed out of all my XLM, I'm certainly not planning to be clicking any more links to a referred 'Hacker' !
Thanks all the same.

No seriously he was the one who helped recover mine Binance won’t do anything I swear,you can just search Blackhathacker110 on telegram and let him help you


README: add basic feature matrix.

Closes #21. Needs further discussion, so marking as draft.
Probably needs additional details for the notes column, but this is where I'm at with it. Would love to hear any other details we should add.

Might as well use some of the more colorful unicode characteres for the categories

✅ (https://emojipedia.org/check-mark-button) for fully working
🟨 (https://emojipedia.org/large-yellow-square) for half working, described in note
❌ (https://emojipedia.org/cross-mark) for not working
❔ (https://emojipedia.org/white-question-mark) for never tried but possibly working, described in note

I like the alphabetical sorting, makes sense.
Content:
I think everything USB-C related should be in single block, something like this:

USB-C booting ✅
USB-C DisplayPort Alt Mode ❔
USB-C USB 3/4 ❔
USB-C PCIe ❌

Others:

Hardware video decoding ❌
Microphone ❌
Camera ❌
Battery charging + indicator ✅ (I think this is what you meant by "Power Management"? IMO should be a bit more specific)

USB 3/4 should work if booting does, updating now.

Nope, unless you have and USB4 device to test with, and can confirm with extensive testing that it is getting the advertised bandwidth, this should stay a question mark. There is a lot of stuff that goes into full USB4 support (configuring all the internal chip interconnects correctly, regulators, retimers, etc.), and I think not everything is complete yet.
Also I am not even familiar with the full feature set of USB4 (e.g. how is dp and pcie "tunneling" different from alt mode?), so I feel like this should stay a question mark for a while, until we learn more about USB4 and can confirm that every feature is working.

As for power management, I'm mainly referring to power-profiles-daemon and managing various power modes. I haven't tested this yet, but I'm assuming it doesn't work. Battery charge + indicator can definitely be their own line items though. I'll do some more testing.

Does it do anything other than setting the cpufreq governor?

Also FYI about the commits (but I will fix this up before merging anyway if you don't want to bother):

Please follow the existing commit message style. First word capitalized, imperative mood, no period at the end.
So something like Add basic feature matrix to the README should be the commit msg for this PR. (Yes having scopes like README: at the start would make some sense, but it should take an explicit proposal if we want to change the commit message style.)
There is no reason for this PR to have multiple commits, it should all be squashed into one.

Nope, unless you have and USB4 device to test with, and can confirm with extensive testing that it is getting the advertised bandwidth, this should stay a question mark. There is a lot of stuff that goes into full USB4 support (configuring all the internal chip interconnects correctly, regulators, retimers, etc.), and I think not everything is complete yet.

Oh right, forgot USB4 was distinct from USB3 for a second. 😅 Oopsie. I'll mark it as unknown.

Does it do anything other than setting the cpufreq governor?

Yes, for x86 processors, AMD and Intel pstate drivers control a whole host of thermal and power limits across the SoC. On Windows Qualcomm chips expose something similar (Best power efficiency, balanced, best performance). I am pretty sure this is related to thermal governors:
https://docs.qualcomm.com/bundle/publicresource/topics/80-70014-30/get-started-thermal.html
https://docs.qualcomm.com/bundle/publicresource/topics/80-70014-30/thermal%2520architecture.html
Either way, this is not exposed by power-profiles-daemon and other power management daemons (eg. TLP). But it does seem like wayyyy less of a big deal for performance and efficiency for Qualcomm chips, so it's not really that important and can be removed unless we want to specify it is not easily configurable in software.

Also FYI about the commits (but I will fix this up before merging anyway if you don't want to bother):

No worries, I knew this would take a few revisions, I can squash and fixup the commit naming scheme.

@alyraffauf I pushed some minor changes, please take a look if you approve of them.

Looks good to me!

Merged, thank you!


FilterWheel Refactor

Is your feature request related to a problem? Please describe.
Right now, the filterwheel class is messy especially in the yaml file. It would be nice to not have to list every filter as a subdevice of filter wheel since all the info is already contained inside the filterwheel.
Describe the solution you'd like
I'd like to remove the subdecive filters from the yaml but sill be able to call filter.enable(). The easiest solution I can think of is to input a function called something like unpack_filters that iterates through filters in filter wheels and create filter device objects. It would be called in the _create_device function in the instrument if the device type is an filter wheel.
Acceptance Criteria

[ ] remove filters as subdevices of filterwheel
[ ] still be able to call filter.enable() instead of going through the main filterwheel

@adamkglaser I can also see changing the driver files of FilterWheel and Filter similar to the stage refactor (#25) so you would only have to pass in what slot the filter correlated to in the init of the filter. I like keeping filters as a subdevice of the filterwheel since it most closely mimics what we are doing for other devices like the stage and lasers. It feels weird to me to have a separate function to sort out filters within a wheel when we are doing something similar with the stages axes but in a different manner.


[FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver

What is the purpose of the change
As FLINK-24819 described, the k8s API server would receive more pressure when HA is enabled, due to the configmap watching being achieved via filter with labels instead of just querying the configmap name. This could be done after FLINK-24038, which reduced the number of configmaps to only one.
Brief change log

Introduce new API named FlinkKubeClient#createConfigMapSharedWatcher(String) and use this API to create watcher.
Delete useless FlinkKubeClient#createConfigMapSharedWatcher(Map<String, String> labels) and FlinkKubeClient#deleteConfigMapsByLabels APIs.

Verifying this change
This change added tests and can be verified as follows:

Modified test KubernetesLeaderElectionAndRetrievalITCase
Modified test KubernetesTestFixture

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@wangyang0918 @dmvk @gyfora could you please take a look?

@Myasuka , I am a bit confused, you mention https://issues.apache.org/jira/browse/FLINK-24038 but I still see 2 high-availability configmaps for Flink 1.18 jobs

@gyfora Sorry for not describing the problem clearly, I focus on the <clusterId>-cluster-config-map which has leader election for all the components(e.g. restserver, dispatcher, resourcemanager, jobmanager), jobGraph store and running job registry. After FLINK-24038, it was still watched via labels.
The other <clusterId>-<jobId>-config-map, which records the checkpoint id, was not watched by taskmanagers and only used by jobmanager.
BTW, I have updated the descriptions in the ticket and this PR.


#24 Add config.yml to the issue template folder

What
It adds a config.yml file to the issue template folder.
Why
So that when an issue is created, GitHub pre-fills the form with the pre-built template.
How
By following the instructions in GitHub's documentation: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
Covers

#24
#31

Checklist

[X] Are the issues being addressed linked to this PR?
[X] Do all commit messages start with the issue number?

Should this be set to true out of interest @wendyyng ?
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
Looks like the true option is the default in either case 🤔

Should this be set to false out of interest @wendyyng ? https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser Looks like the true option is the default in either case 🤔

Hi @ryanolee, the reason why I used true is because I'm using the legacy workflow to manually create an issue_template.md and if it's false the template won't be used. We can use the new way to create the issue, which looks like this:

But looking at the issues we had before, the older workflow would suffice and it's also more similar to the pull request template.
I tried to move up the config.yml and the issue_template.md to the .github in a different repo and the new issue was pre-filled with the issue template automatically. I've committed changes to this branch, and after merging to main, it should work as expected.
If you prefer the new way please let me know and I'll look into it :)

Thanks for the detailed response @wendyyng , The Legacy workflow seems intuitive enough to me so merging!


[Feature Request] Component Skeleton Request

Existing Component
No
Component Name
Skeleton
Description
Please consider adding a Skeleton component, like https://ant.design/components/skeleton/

https://github.com/ElemeFE/element/issues/12968


[release-v1.4] Do not generate checksum for config tracing

config-tracing is removed during the make generate-release command
since it will come from eventing core, so ./hack/update-checksum.sh
fails since it can find the YAML.

/retest

/retest

/retest

/retest

/cc @aliok


"jit changes the exact numerics of outputs" FAQ example not working as expected

Description
Issue
When running JIT for the example "jit changes the exact numerics of outputs" (https://jax.readthedocs.io/en/latest/faq.html) I do not get the same result. For jit and non-jit function I receive 0.0010000467 (see in code).
jax version 0.3.23
CUDA Info
GeForce 2700
NVIDIA-SMI 522.25
Driver Version: 522.25
CUDA Version: 11.8
OS Version
Edition	Windows 10 Home
Version	21H2
Installed on	12/8/2021
OS build	19044.2006
Experience	Windows Feature Experience Pack 120.2212.4180.0
Code
>>> import jax
>>> jax.devices()
[GpuDevice(id=0, process_index=0)]
>>> from jax import jit
>>> def f(x, y):
...   return x + y - x
...
>>> import jax.numpy as jnp
>>> x = jnp.array(1.0)
>>> y = jnp.array(0.001)
>>> print(f(x, y))
0.0010000467
>>> print(jit(f)(x, y))
0.0010000467

What jax/jaxlib version are you using?
jax v0.3.23 jaxlib v0.3.20
Which accelerator(s) are you using?
GPU
Additional system info
Windows
NVIDIA GPU info

Sat Oct 22 15:56:32 2022
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 522.25       Driver Version: 522.25       CUDA Version: 11.8     |
|-------------------------------+----------------------+----------------------+
| GPU  Name            TCC/WDDM | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ... WDDM  | 00000000:01:00.0 Off |                  N/A |
| N/A   39C    P8     8W /  N/A |      0MiB /  8192MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      3528    C+G   ...IA GeForce Experience.exe    N/A      |
+-----------------------------------------------------------------------------+

Thanks for flagging this - it seems that XLA has changed some of its optimization paths since the documentation was first written, so this is no longer a good example of the issue.

It's a good meta-example of the issue, in that it shows jit numerics are unpredictable (and can hence invalidate our docs). 😛

So I should not expected jit to optimize my numerical computations anymore essentially?

JIT still optimizes numerical computations, but the particular optimization that led to those two outputs differing has been removed.

Thanks again for raising this - should be fixed now: https://jax.readthedocs.io/en/latest/faq.html#jit-changes-the-exact-numerics-of-outputs


Introduced ProfileSolidInformationRecord classes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@diegoalexdiaz have you run the schema inventory job to update the inventory?
@naveedkhan8067 schema validation jobs are being skipped on this branch

@diegoalexdiaz have you run the schema inventory job to update the inventory? You will also have to sign the CLA.
@naveedkhan8067 schema validation jobs are being skipped on this branch

Hey, this seems like a "Draft" PR and right now the validation builds only triggered with PR's which are not "Draft"

@diegoalexdiaz have you run the schema inventory job to update the inventory? You will also have to sign the CLA.
@naveedkhan8067 schema validation jobs are being skipped on this branch

Hey, this seems like a "Draft" PR and right now the validation builds only triggered with PR's which are not "Draft"

You're right.  Sorry about that.

@diegoalexdiaz have you run the schema inventory job to update the inventory? You will also have to sign the CLA.
@naveedkhan8067 schema validation jobs are being skipped on this branch

Hey, this seems like a "Draft" PR and right now the validation builds only triggered with PR's which are not "Draft"

You're right. Sorry about that.

No problem!

Interesting spelling mistake! Do we need Category's name that long? how about: ""ProfiledSolidRecordProperties"

Is your question about just the property-category name? or the usage of "ProfiledSolidInformationRecord" throughout the schema?
If it is the second, we have a decision to make. Class names in BIS schemas tend to replicate the naming introduced in BisCore when there's not a better name already established for a concept in a given domain. The name for the base class from BisCore in this case is "InformationRecord" so those two words have been typically replicated together whenever used.
I share your concern of the long names in the schema, so the decision to be made is about deviating from the naming conventions used everywhere else to achieve shorter class names in this particular case (i.e. ProfiledSolidInformationRecord --> ProfiledSolidRecord).
Any strong opinions @caseymullen, @ColinKerr and others?


Doesn't work in daphne

When django is run as a runserver it works very well. However, if you configure nginx and daphne for distribution, it does not work.
When onopen, message is delivered well, and wsconnect is fine.
However, even if the model is updated, it does not receive a special message.
If you know why, please answer.

When django is run as a runserver it works very well. However, if you configure nginx and daphne for distribution, it does not work.
When onopen, message is delivered well, and wsconnect is fine.
However, even if the model is updated, it does not receive a special message.
If you know why, please answer.


fix uninitialized variables

On line number 330 of ‘tokenizer.cpp’, ‘significand_bits’ and ‘exponent_bits’ may be accessed without an initialized value. It's always good to initialize variables, because if we try to access a value before it gets assigned any actual (non-garbage) value, then it results in undefined behavior.
Found by https://github.com/bryongloden/cppcheck

Thank you for this contribution. Do you have some source code that activates the undefined behavior here?
I'm not convinced there actually is undefined behavior here - and assigning 0 to variables can actually hide bugs. Right now if you run zig in valgrind, and undefined behavior is activated, valgrind will catch it. However, if we initialize these variables to 0, 0 may be an incorrect value, and incorrect behavior will happen which valgrind cannot catch.

What about the exponent overflow case? It looks like we'll memcpy garbage bytes into the literal value of the token, but then since the token is marked as an overflow we should never read it. Seems like we should just return from the overflow case and skip the memcpy.

Greetings @andrewrk. First, it's worth noting that we've done extensive studies, and 60% of the time our static analysis tool works all the time. Furthermore, sound and complete static analysis is shown to be undecidable, ergo we're led to a few false positives because we've adopted some unsound techniques in our tool. Moreover, valgrind has its set issues as well.
Having said all that, we don't have a test case for you that activates your undefined behavior here. Just reading through the code it became apparent to us that there was a logically sequence of control flow steps that could reach line 330 without also initializing ‘significand_bits’ and ‘exponent_bits’.
Whether or not you want to accept our patch is another story. We can mark our notes as a false positive if you insistent. It doesn't too much to us a this point. We just wanted to make you aware of the fact that control flow could reach line 330 and ‘significand_bits’ and ‘exponent_bits’ may be uninitialized.
After re-reading your comment, we believe the larger questions are simple: do we initialize ‘significand_bits’ and ‘exponent_bits’.? If so, what values do we initialized them to?
Cheers.

Greetings @thejoshwolfe.

What about the exponent overflow case? It looks like we'll memcpy garbage bytes into the literal value of the token, but then since the token is marked as an overflow we should never read it. Seems like we should just return from the overflow case and skip the memcpy.

Ah, yes that's right. I think that's the proper resolution to this.
So, thank you for the report @bryongloden - I think this was not a false positive, but the resolution is going to be slightly different than what is proposed here.

The fact that we do not initialize these variables found the missing return statement here when analyzed. If we had initialized them to 0 then we'd still copy garbage data in the memcpy. So I think everyone was right here.
@bryongloden found there was a bug with uninitialized memory.
The bug was found thanks in part to not redundantly initializing to 0 as I pointed out.
@thejoshwolfe identified the specific cause of the bug.

Awesome, thanks for the clarification @andrewrk.
Kudos all around!
👍


feat: enable validation of AsyncAPI Spec v3 documents in validate command

Description
Fixes https://github.com/asyncapi/cli/issues/770
This PR enables validation of AsyncAPI v3 documents through the validate command.
In order to not break model generation (that uses the future version of Parser-JS v3, which breaks the API), It uses a new independent library (https://github.com/smoya/multi-parser-js) that is temporarily needed for "downgrading" the parsed document to previous Parser-API version (v1.0.0) so it's aligned with the one in use by Modelina parser version. It is needed until https://github.com/asyncapi/modelina/issues/1493 gets fixed
Related issue(s)
https://github.com/asyncapi/cli/issues/770
cc @jonaslagoni

@Shurtu-gal I fixed the tests location.

/rtm


Question regarding tests

I was reading the source code for parser.move and was wondering if those repeated tests were meant to be that way or if it was actually the case that they were meant to test different cases. (afaik there could be only one test there as one of them is redundant, right?)
Could someone clarify this?

@Cardosaum Hey, I just revisit the source and you are right, there are some duplicate tests and it was a mistake. Will remove it in a future update. Does it answer your question?

Yeah, totally :)
Mind leaving the issue open for you to close in the PR fixing the duplicate tests or you prefer creating a new issue for it?


IntelliSense messed with code snippets

Issue Type: Bug

Behaviour
example I have a snippet for numpy:
 "np.size.rowcol": {
    "prefix": "np.init(row, col)",
    "body": "(${1:row}, ${2:col})$0",
    "description": "for the size parameter as 2D-Array, use tuple"
  },

Expected - after I disabled Python IntelliSense
when I type np. it is supposed to show me the snippets

Actual - Steps to reproduce:
as you can see enable the extension will clear the suggestion compared to picture above

Concern
this is not a big issue for me but it would be more convenient if I can type the dot
Is there a workaround for this issue? Currently the snippet I am using is from here and I receive complain from people

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.10.1
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Default

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "autopep8"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: true
• optInto: []
• optOutFrom: []

insidersChannel: "off"

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.0.1814523869
VS Code version: Code 1.64.2
OS version: Windows 10
Restricted Mode: No

This should probably be filed on VS Code. We don't control priority of snippet over completion.

@karthiknadig
sure it is priority but not the extension itself? Because as you can see in the picture the np word is gone when the extension is enabled

IntelliSense is provided over language server protocol. Based on your setting in your case it comes from the pylance extension. But that extension also provides completions over LSP. The python extension does not control how this is displayed.
/cc @judej

@karthiknadig just curious, do you know how the intellisense obtain the definition? I mean where is it store, because I like to add additional text or simplify some.
Like this one bytearray should be classified as built-in method but I see it is just label as class.

@ericsia For "python.languageServer": "Jedi" the code lives here.
For "python.languageServer": "Default" or "python.languageServer": "Pylance" you may have to file a bug here https://github.com/microsoft/pylance-release


per-test option cpusPerTask should work with the slurm module

The command line option --cpusPerTask works with the slurm module.
This option will add this to the srun line so it looks like so if run with ats -cpusPerTask=2
srun  --nodes=2-3 --cpus-per-task=2 --ntasks=40
However if the cpusPerTask=2 is specified on the ATS test line for an individual test case, it is ignored.  That is, this line is generated.
srun  --nodes=2-3 --cpus-per-task=1 --ntasks=40
The slurm module should honor that option on a per test basis, so that non threaded codes can reserve 2 CPUs for a test in order to undersubscribe nodes, or for any other reason.

Shawn will fix this issue.


Send message on a channel without users interacting

Hi, how could I send messages on a channel without users having to interact before? would be several warning messages during the day, my current status is this way.

from telepot.loop import MessageLoop
from decouple import config

def handle(msg):
    content_type, chat_type, chat_id = telepot.glance(msg)
    print(content_type, chat_type, chat_id)
    bot.sendMessage(chat_id, msg['text'])

bot = telepot.Bot(config('TOKEN'))
MessageLoop(bot, handle).run_as_thread()
print ('Listening ...')

while 1:
    pass

bot.sendMessage(chat_id,'Message text goes here') is the usual syntax. Do you get an error?
I wrote two python scripts, one to send message alerts to the channel and another to respond to chat requests.

how should i retrieve the reply from my bot in a colored text in telepot lib?

Firstly, start a new issue instead of hijacking a much older thread.
Secondly, please give a lot more context when asking questions. Perhaps some example code and what you are trying to achieve. I can interpret your question several ways and none of them make perfect sense.


Validation failed. View error details

Hi,
I tried to deploy with the custom template to create all the Azure Infrastructure needed to run the Notebooks (Azure Cognitive Search, Cognitive Services, SQL Database, CosmosDB, Bing Search API), but I got the following error message.
"InvalidTemplateDeployment: The template deployment 'MicrosoftTemplate' is not valid according to the validation procedure. The tracking id is '2d765e2c-4e79-4062-a78a-c26e02d13xxx. See inner errors for details.
Does anyone have the same problem before? Thanks

Not able to replicate. Closing.


ContextSpace draft

[x] New CARL env
[x] Port classic control
[ ] Port brax
[x] Port dmc
[ ] Port box2d
[ ] Port mario
[ ] Port RNA
[ ] Add unit tests for new CARL env

I updated Mario and RNA but couldn't test either:

Mario doesn't work on MAC
there are not install instructions for RNA and last time I managed was on an older python.

So I'd add:

[ ] Add install instructions for RNA
[ ] Test Mario
[ ] Test RNA


Implement containerized vendoring (and vendor validation) like we did in docker-app

This makes sure everyone use the same version of dep.

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   66.07%   66.07%
=======================================
  Files          88       88
  Lines       10987    10987
=======================================
  Hits         7260     7260
  Misses       3441     3441
  Partials      286      286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9264c5e...92c2323. Read the comment docs.


Add session_affinity_attributes field to LoadBalancer

Description
session_affinity_attributes is a new field to set the samesite and
secure attributes in a load balancer session affinity cookie. Also fixed
broken links in load balancer API reference.
Has your change been tested?
Add new fields to load balancing tests which verify the input struct matches the returning JSON/struct.
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Are you able to point to the documentation for this new field? I can't seem to find it on either the API or developer documentation.

@jacobbednarz In the create load balance API docs under Optional parameters section, there should be a session_affinity_attributes object with fields samesite and secure, https://api.cloudflare.com/#load-balancers-create-load-balancer. These fields should similarly exist for update load balancer and patch load balancer.

Thanks @tingwai 🙇 Not sure if this is a new thing but I don't think it was there when I initially checked (either that or PEBKAC 😛 )

Thanks @tingwai!


Store index segment offset information in compaction and use it to generate replication token

We know all the index segment offset information in the compaction, we should use them to later reset replication token when the index in the token is removed by compaction. The design doc is here.
https://docs.google.com/document/d/1eETr1ifIQXihN3DA0P3KIclLUiIxXKRwBKPNSyij4is/edit#

Codecov Report
Base: 73.08% // Head: 60.94% // Decreases project coverage by -12.14% :warning:

Coverage data is based on head (9beca37) compared to base (36bc2f1).
Patch coverage: 9.78% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2218       +/-   ##
=============================================
- Coverage     73.08%   60.94%   -12.15%
+ Complexity    10377     8491     -1886
=============================================
  Files           747      747
  Lines         56788    56947      +159
  Branches       6987     7015       +28
=============================================
- Hits          41502    34704     -6798
- Misses        13037    19943     +6906
- Partials       2249     2300       +51

Impacted Files
Coverage Δ

...ava/com/github/ambry/store/BlobStoreCompactor.java
5.46% <0.00%> (-80.10%)
:arrow_down:

...n/java/com/github/ambry/store/PersistentIndex.java
31.70% <3.07%> (-57.04%)
:arrow_down:

...ain/java/com/github/ambry/store/CompactionLog.java
3.35% <8.75%> (-70.36%)
:arrow_down:

...rc/main/java/com/github/ambry/store/BlobStore.java
45.42% <37.50%> (-39.62%)
:arrow_down:

...main/java/com/github/ambry/config/StoreConfig.java
100.00% <100.00%> (ø)

...rc/main/java/com/github/ambry/store/TimeRange.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/com/github/ambry/notification/UpdateType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/java/com/github/ambry/store/CostBenefitInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...om/github/ambry/store/CompactAllPolicyFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...thub/ambry/notification/BlobReplicaSourceType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 188 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TypeError: Cannot read property 'replace' of null

Storefront doesn't work.
[start-store]   path: /
[start-store]   error: TypeError: Cannot read property 'replace' of null

Thanks dewelloper!

Welcome it's oke :)


Can't find variable: window - aws-amplify-angular with nativescript

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI:  "@angular/compiler-cli": "~8.2.0",
Cross-platform modules: -na-
Android Runtime: -na-
iOS Runtime: 6.1.0
Plugin(s): nativescript-randombytes
NativeScript-Angular: "nativescript-angular": "~8.2.0",
Angular: "@angular/core": "~8.2.0",

Describe the bug
I am following the docs for aws-amplify-angular for angular+nativescript project I am working on.
As the 'aws-amplify-angular' module is loaded, I see following error:
JavaScript error:
file:///node_modules/aws-amplify-angular/dist/src/components/interactions/chatbot/aws-lex-audio.js:549:0: JS ERROR ReferenceError: Can't find variable: window
(CoreFoundation) *** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: ReferenceError: Can't find variable: window
To Reproduce

create a simple nativescript project
follow instruction here to setup amplify-angular.

Expected behavior
window object from Node runtime mapped in nnativescript.
Sample project
-na-
Additional context
there is no guidance on how to map window object from Node in nativescript.

@nirmay the instructions are made for Angular for Web but the library does not seem compatible with NativeScript (it uses DOM which is used by neither iOS nor Android and things like window makes no sense in  the context of mobile world).


Support alternate git installation

Recently I updated my system git installation and decided to try using the new zdiff3 config option for conflictStyle. However when I used any built-in git commands in VSCode I would get an error complaining about an unrecognized config option. I would like an option to set an alternate git installation from the one built-in to VSCode. If this isn't practical I should at least be able to easily discover the version of the current git installation so I can know what features are supported.

complaining about an unrecognized config option

What's exactly the error message?

from the one built-in to VSCode

Code doesn't ship with Git, it calls the system one.

set an alternate git installation

git.path setting.

That's good to know. I can't reproduce the error anymore even with that setting enabled so hopefully it was just a fluke.


Properties pane (right of the drawing canvas), scrolling does not work if the cursor if over the Monaco editor

Describe the bug
In the properties pane, when my cursor is over the Monaco editor, scrolling seems to be turned off. The expected behavior is for the entire pane to scroll if the contents of the Monaco editor do not need to scroll.
Version
Version:  1.4.0-nightly.238698.3e4162
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[x] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to any dialog.
Add an "Ask a question > Multi-choice" action.
In the properties pane on the right, select the "User Input" pivot.
Move the cursor over the "Expected responses" section.
Try to scroll the pane.

The pane does not scroll:
https://user-images.githubusercontent.com/39317542/115937011-a56fc480-a44b-11eb-8303-84d1ee80a858.mov
Without this behavior, the user might not realize there is more content below the Monaco editor, in particular for the Multi-Choice node.
Expected behavior
I expect scroll to work from child element up to parent. So when I'm hovering over a multi-line input and it has enough content to scroll, I expect that element to scroll. If it doesn't have enough content to scroll, I expect the parent element (like a page or section) to scroll if it has enough content to scroll.
Here's an example showing expected behavior:
https://user-images.githubusercontent.com/39317542/115937493-f8964700-a44c-11eb-94aa-5366ccbccfd4.mov
Screenshots

Additional context

Hi @mewa1024 , can you try #7357 to see it's expected behavior ?


Duration is out of dual 32-bit range

Hello,
I use ROS noetic on ubuntu 20.04.
I run that launch file :

<?xml version="1.0" ?>
<launch>
  <arg name="robot_ip" />

  <include file="$(find panda_moveit_config)/launch/franka_control.launch">
    <arg name="robot_ip" value="$(arg robot_ip)" />
  </include>

</launch>

After one or two moveit execution, I get that error:
[ INFO] [1650017555.624464339]: Controller 'position_joint_trajectory_controller' successfully finished
[ INFO] [1650017555.707375009]: Completed trajectory execution with status SUCCEEDED ...
[ INFO] [1650017555.714236078]: Received event 'stop'
[ INFO] [1650017555.812988489]: Received request to compute Cartesian path
[ INFO] [1650017555.813370991]: Attempting to follow 2 waypoints for link 'panda_link8' using a step of 0.010000 m and jump threshold 0.000000 (in global reference frame)
[ INFO] [1650017555.813802012]: Computed Cartesian path with 3 points (followed 100.000000% of requested trajectory)
[ INFO] [1650017555.814520703]: Execution request received
[ INFO] [1650017556.041427698]: Controller 'position_joint_trajectory_controller' successfully finished
[ INFO] [1650017556.140868267]: Completed trajectory execution with status SUCCEEDED ...
[ INFO] [1650017556.140992920]: Execution completed: SUCCEEDED
[ INFO] [1650017557.674071654]: Combined planning and execution request received for MoveGroup action. Forwarding to planning and execution pipeline.
[ INFO] [1650017557.674226121]: Planning attempt 1 of at most 1
[ INFO] [1650017557.675771675]: Planner configuration 'panda_arm' will use planner 'geometric::RRTConnect'. Additional configuration parameters will be set when the planner is constructed.
[ INFO] [1650017557.676177264]: panda_arm/panda_arm: Starting planning with 1 states already in datastructure
[ INFO] [1650017557.699567260]: panda_arm/panda_arm: Created 5 states (2 start + 3 goal)
[ INFO] [1650017557.699626543]: Solution found in 0.023645 seconds
[ INFO] [1650017557.716953937]: SimpleSetup: Path simplification took 0.017239 seconds and changed from 4 to 2 states
[ WARN] [1650017557.917534940]: FrankaHW:
	panda_joint4: 48.052401 degrees to joint limits (limits: [-3.071800, -0.069800] q: -2.233127)
[ INFO] [1650017560.191609366]: Controller 'position_joint_trajectory_controller' successfully finished
[ INFO] [1650017560.274275395]: Completed trajectory execution with status SUCCEEDED ...
[ INFO] [1650017560.281329970]: Received event 'stop'
[ INFO] [1650017560.340796921]: Combined planning and execution request received for MoveGroup action. Forwarding to planning and execution pipeline.
[ INFO] [1650017560.340938019]: Planning attempt 1 of at most 1
[ INFO] [1650017560.341766800]: Planner configuration 'panda_arm' will use planner 'geometric::RRTConnect'. Additional configuration parameters will be set when the planner is constructed.
[ INFO] [1650017560.341938683]: panda_arm/panda_arm: Starting planning with 1 states already in datastructure
[ INFO] [1650017560.357619875]: panda_arm/panda_arm: Created 5 states (2 start + 3 goal)
[ INFO] [1650017560.357657397]: Solution found in 0.015800 seconds
[ INFO] [1650017560.390585205]: SimpleSetup: Path simplification took 0.032877 seconds and changed from 4 to 2 states
[ WARN] [1650017562.918474636]: FrankaHW:
	panda_joint4: 47.972937 degrees to joint limits (limits: [-3.071800, -0.069800] q: -2.234514)
[ INFO] [1650017563.157946778]: Controller 'position_joint_trajectory_controller' successfully finished
[ INFO] [1650017563.240689409]: Completed trajectory execution with status SUCCEEDED ...
[ INFO] [1650017563.247838920]: Received event 'stop'
[ INFO] [1650017563.342252969]: Received request to compute Cartesian path
[ INFO] [1650017563.342370025]: Attempting to follow 2 waypoints for link 'panda_link8' using a step of 0.010000 m and jump threshold 0.000000 (in global reference frame)
[ INFO] [1650017563.342754963]: Computed Cartesian path with 3 points (followed 100.000000% of requested trajectory)
[ INFO] [1650017563.343340847]: Execution request received
terminate called after throwing an instance of 'std::runtime_error'
  what():  Duration is out of dual 32-bit range
================================================================================REQUIRED process [franka_control-3] has died!
process has died [pid 139304, exit code -6, cmd /home/fff/dev/catkin_ws/devel/lib/franka_control/franka_control_node __name:=franka_control __log:=/home/fff/.ros/log/8a163c10-bca4-11ec-b7e8-f91b2a3bdfbe/franka_control-3.log].
log file: /home/fff/.ros/log/8a163c10-bca4-11ec-b7e8-f91b2a3bdfbe/franka_control-3*.log
Initiating shutdown!
================================================================================
[rviz_fff_139214_966731689332244255-10] killing on exit
[move_group-9] killing on exit
[virtual_joint_broadcaster_0-8] killing on exit
[controller_spawner-7] killing on exit
[joint_state_publisher-6] killing on exit
[robot_state_publisher-5] killing on exit
[state_controller_spawner-4] killing on exit
[franka_control-3] killing on exit
[franka_gripper-2] killing on exit
[INFO] [1650017563.645560]: Shutting down spawner. Stopping and unloading controllers...
[INFO] [1650017563.645870]: Shutting down spawner. Stopping and unloading controllers...
[INFO] [1650017563.647024]: Stopping all controllers...
[INFO] [1650017563.647739]: Stopping all controllers...
[WARN] [1650017563.649646]: Controller Spawner error while taking down controllers: unable to connect to service: [Errno 111] Connection refused
[WARN] [1650017563.650208]: Controller Spawner error while taking down controllers: unable to connect to service: [Errno 111] Connection refused
[rosout-1] killing on exit
[master] killing on exit
shutting down processing monitor...
... shutting down processing monitor complete

Unfortunatly there is no franka_control-3.log file. Is there a way to get it?
And then, I don't really no where the problem comes. Can someone help me to solve this?

I try to add debug mode like this:
RLException: Roslaunch got a 'No such file or directory' error while attempting to run:

xterm -e gdb --args /home/fff/dev/catkin_ws/devel/lib/franka_control/franka_control_node __name:=franka_control __log:=/home/fff/.ros/log/19f6fe8e-bfc8-11ec-b7e8-f91b2a3bdfbe/franka_control-3.log

Please make sure that all the executables in this command exist and have
executable permission. This is often caused by a bad launch-

I modify the launch file like this:
<?xml version="1.0" ?>
<launch>
  <arg name="robot_ip" />
  <arg name="load_gripper" default="true" />

  <param name="robot_description" command="$(find xacro)/xacro $(find franka_description)/robots/panda_arm.urdf.xacro hand:=$(arg load_gripper)" />

  <include file="$(find franka_gripper)/launch/franka_gripper.launch" if="$(arg load_gripper)">
    <arg name="robot_ip" value="$(arg robot_ip)" />
  </include>

  <node name="franka_control" pkg="franka_control" type="franka_control_node" output="screen" required="true" launch-prefix="xterm -e gdb --args">
    <rosparam command="load" file="$(find franka_control)/config/franka_control_node.yaml" />
    <param name="robot_ip" value="$(arg robot_ip)" />
  </node>

  <rosparam command="load" file="$(find franka_control)/config/default_controllers.yaml" />
  <node name="state_controller_spawner" pkg="controller_manager" type="spawner" respawn="false" output="screen" args="franka_state_controller"/>
  <node name="robot_state_publisher" pkg="robot_state_publisher" type="robot_state_publisher" output="screen"/>
  <node name="joint_state_publisher" type="joint_state_publisher" pkg="joint_state_publisher" output="screen">
    <rosparam if="$(arg load_gripper)" param="source_list">[franka_state_controller/joint_states, franka_gripper/joint_states] </rosparam>
    <rosparam unless="$(arg load_gripper)" param="source_list">[franka_state_controller/joint_states] </rosparam>
    <param name="rate" value="30"/>
  </node>
</launch>

Do I made something wrong?

Same issue here, also seems to be random. ROS noetic on Ubuntu 20.04 (in a docker), libfranka 0.9.0-2focal.20220328.144759.

We also have the same issue. Any update on this, please?

There is an issue for the same problem in libfranka. You can try out the "solution" that was mentioned there, but I doubt that it will really fix your problem. Honestly, there is not much I can do for you as I cannot reproduce it :confused:

@marcbone Are my debug logs enough. Do you need other trace ? I can generated it for you.

@marcbone Are my debug logs enough. Do you need other trace ? I can generated it for you.

We also have had this error for some months:
[ INFO] [1648537848.852719572]: FrankaHW: Prepared switching controllers to joint_position with parameters limit_rate=1, cutoff_frequency=100, internal_controller=joint_impedance
[ INFO] [1648537848.855927422]: franka_control, main loop
terminate called after throwing an instance of 'std::runtime_error'
  what():  Duration is out of dual 32-bit range
================================================================================REQUIRED process [franka_control-1] has died!
process has died [pid 239, exit code -6, cmd /catkin_ws/devel/lib/franka_control/franka_control_node __name:=franka_control __log:=/root/.ros/log/a1ad6386-af2e-11ec-abea-902e16d1ae42/franka_control-1.log].
log file: /root/.ros/log/a1ad6386-af2e-11ec-abea-902e16d1ae42/franka_control-1*.log
Initiating shutdown!
================================================================================
[controller_spawner_visual_servoing-6] killing on exit

Scenario

We switch between 2 controllers, position_joint_trajectory_controller and a custom controller that uses hardware_interface::VelocityJointInterface

Most of the time it works. It switches controllers, moves the robot and everything is nice, but once and then we get the error.

Most of the time the error appears after the first time we switch controllers and switch back. We do the following:

Start with the position_joint_trajectory_controller
Successfully move the robot with it
Change to our custom controller
Successfully move the robot with it
Change back to the position_joint_trajectory_controller
Succesfully plan the next move, but when executing it, the error happens

We switch controllers by calling the service controller_manager/switch_controller and even when the error appears, the service returns success.

First we added a small wait of 0.2s after switching back to position_joint_trajectory_controller and before moving (or even planning) and seemed to help a bit, but not much. Now we got rid of this wait.

We now have a check before switching back to position_joint_trajectory_controller that reads the state of the robot from the /joint_states topic to make sure the change is done after the robot is not moving (we had an error involving a "velocity discontinuity" that was caused by this). This seems to decrease the frequency of appearance of the error, but it still appears.

We also tried just switching controllers very fast (at 20 Hz, but maybe we also tried faster, I don't remember) and the service always said the switch was successful.

The error also happened when the controllers were not being switch, in between movements with the position_joint_trajectory_controller, but this has happened just 2 or 3 times.

The error most of the time appears when the ROS master together with the franka-ros nodes are created. After they have been running for some time, the error rarely appears

We run the ROS master and most of our nodes on one computer, and franka control and control manager in a different, real time PC

What the problem could be
rhaschke stated in #232 (and a few days ago checked that the error was still there) that when the start of a controller actually failed, the ControllerManager thinks that controller switching succeeded.
Maybe our switch is not successful and we don't know it. But he also mentioned that this raises a ROS error, so I'm not sure if we would see this.
Any comments on our thoughts or ideas of what to try are welcome.

@HumbertoE I try a 'solution' since o,e week. I found on Ros forum that moveit Can create that keep of problem if the package is not updated.
So I update Moveit and ROS and it seems to solve my trouve.

@xav12358 could you share the ROS forum question or issue if you still have it open? We can try this, thanks. I will comment here if this solves the issue for us

@xav12358 what version of Moveit are you using? Or if installed from source, what commit of the Moveit repository are you at?
We are installing it from source and are in commit 7949bd6ea776e1268b8ff9e2015cad5cb695b829 that was done on August 16 (one week before you started testing I think) and we still got the error.
I will update moveit to the latest state in the master branch and test in the robot in a couple of days and inform if this solves the issue for us.

@HumbertoE  in fact I use the Ubuntu 20.04 Moveit package. Why do you need to install moveit from source package ?

So the release 1.1.5 maybe? I will try that one then and see if the duration error disappears. Thank you
We had to do some custom changes to one package for our application. They are not fixes, so we didn't make any pull request. I will also check that this package is in the corresponding commit to that release

We changed to the 1.1.5 release version on Moveit and we still have the same error.
We also changed to libfranka version 0.9.2 and franka ros 0.9.1 (before we had both at 0.9.0) and still we get the duration error.
In some point we also got another error of the controller not executing commands even when the controller manager said it was ok and running. I manually changed to another controller and then back to the position_joint_trajectory_controller and then it worked.
My theory is that when we change controllers, it fails but the controller manager reports it doesn't or it reports it was successful before it finishes (the controller switch service returns success after between 5 and 7 ms) and then when it receives some commands for the controller that is reported as loaded, it fails.
The problem here of the failure in changing controllers could be in our implementation, but if the controller switch is reported as successful when it is not, it is very hard to debug.

Now the problem seems to be solved for us. It hasn't appeared in more than a month, even when we try to provoke it.
We were running the ROS core in one computer and the ROS control node in another one with a different version of ROS. Now we have the same version of ROS and this solved the problem.


Broken Link to Prom Exporter

Not sure where things are going, but the below link is used in a few places to point to the GPU node exporter here, and it's broken:
https://github.com/NVIDIA/gpu-monitoring-tools/tree/master/exporters/prometheus-dcgm#node_exporter
That is, in your own readme and in node-exporters repo. I am wondering what the new "workflow" is to use this with Prometheus?

Same question

Same question

Why is it so hard to find instructions on how to install dcgm exporter on a baremetal host

Hello!
I cleaned up the repo and product to be a lot simpler to use. If you aren't interested in moving to the v2 I've created a branch called v1 that still has the documentation (though all links are broken because at the time we didn't use permalinks).
The new workflow with prometheus is now documented on the readme: https://github.com/NVIDIA/gpu-monitoring-tools#quickstart-on-kubernetes
On versioning, we are still currently at a release candidate stage (RC), but are already using the software in production in the context of GPU Operator. Expect RC to be here for at least 2-3 months, I'm thinking of making the G.A of the 2.0.0 version match the next version of DCGM.
Hope this clears up any issue!


Should readme indicate that nightly is needed?

Rust 1.64 tells me that that this lib is requires the feature portable_simd which is only in nightly as of yet, should this be declared in the readme somewhere?

done. https://github.com/yotarok/flacenc-rs/commit/0d8d505d61fcb5e493b30b0fd3a28863914ed302


Dynamic import(Emscripten ES6 Module With Pthread) cannot be built by vite @5.0.10

Describe the bug
When using emscripten's es6 and pthreads, the dynamic import of import("./CbWebLib.js")).then(exports=>exports.default(Module)) in worker.js will cause the vite build to fall into an infinite loop.

I have tow Files,one(CbWebLib.js) includes "worker=new Worker(new URL("CbWebLib.worker.js",import.meta.url))",the other(CbWebLib.worker.js) includes "import("./CbWebLib.js")).then(exports=>exports.default(Module))";

Reproduction
vite.new
Steps to reproduce
No response
System Info
windows,

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Duplicate of #7015


Content Creator: First time users dashboard experience

As a Content Creator, I want to understand the benefits of the CMS and how it works so that after I enter the CMS for the first time, I am able to see the information that I want to know.

Feature: Dashboard for first-time users
  As a Content Creator,
  I want to understand the benefits of the CMS and how it works
  So that after I enter the CMS for the first time, I am able to see the information that I want to know.

  Scenario: Educate around headless CMS (concept + benefits)
    Given that, I am a first time user of the CMS
      And that I may have used other CMS products in the past
      And that I am curious what benefits this CMS has
    When I enter the CMS for the first time
    Then I will see information about what a headless CMS is
      And the benefits of a headless CMS for me and my team

  Scenario: Explain how the product works (workflows, roles)
    Given that, I am a first time user of the CMS
      And that the first place
    When I enter the CMS for the first time
    Then I will see information about how the CMS works
      And understand how my role fits into the different workflows
      And ultimately be able to start contributing

Dashboard for first-time users:

[ ] Educate around headless CMS (concept + benefits)
[ ] Explain how the product works (workflows, roles)

🎱
@joshkimmell @poofichu @mkiang3051 @scottnath - Wrote a couple first-time user stories. Can you guys take a look and let me know what you think.

Related to #333

Waiting on Estimate to move to backlog

Blocked by #341
Also, need to create an implementation story as well.


Install with npm?

It is not published on npm? Why not? Very inconvenient. I doesn't have any script imports in my SPA setup!

Oh my todo list, coming soon. In the meantime, worth noting that you can install directly from GitHub, with versioning if desired.


native logger integration / dep loglevel config?

Python comes with some logging niceties built-in, among which the ability to use yaml-based configuration for logging. this facilitates e.g. the configuration of logging levels of dependencies.
this sounds nice, but i'm not sure how to achieve something similar with powertools's logger. is this something that is currently possible, or might this be desirable as a potential enhancement?

hey @KiaraGrouwstra thank you for creating it - apologies for the delay, just got back from a long vacation.
For setting the log level, you can use either Logger(level="DEBUG") or simply the environment variable LOG_LEVEL as per our docs: https://awslabs.github.io/aws-lambda-powertools-python/latest/core/logger/#getting-started
Child loggers (Logger(child=true)) have bi-directional sync, which means if you change the logger it'll replicate both ways, for example if you add a new key: logger.append_keys(payment_id="123")
We don't plan to add a YAML based config as you don't need to configure it like you do the traditional logger, you simply do logger = Logger(), and it just works. You can opt-in for other features like setting correlation ID, log sampling, but you'd want to do this conditionally, not statically.
Does that help?
I'm more than happy to clarify any questions you might have.

hi,
this issue i'm concerned about is about dependencies.
i know that for my own code i can control which logging level of messages will be printed.
the issue is, i'm consuming other pip packages that log things as well, and in some cases turn out buggy.
in such cases, i would like to be able to print debug-level info for such a broken package.
that is something that by default python logging can achieve. however, as i currently understand it, since the powertools logging library does not hook into this built-in way of logging, it lacks that functionality.
is this understanding correct?

Ah! I totally misunderstood, sorry.
You can get the namespace logger and set the level as you normally would
with any logging that used std logging, or set the level at the root logger
and it will be propagated.
Could you share the workflow you have in mind so I can share a snippet with
you?
I don’t wanna assume you want to propagate down, upwards, or in another way
I might not be thinking.
On Mon, 27 Sep 2021 at 17:08, Kiara Grouwstra @.***>
wrote:

hi,
this issue i'm concerned about is about dependencies.
i know that for my own code i can control which logging level of messages
will be printed.
the issue is, i'm consuming other pip packages that log things as well,
and in some cases turn out buggy.
in such cases, i would like to be able to print debug-level info for such
a broken package.
that is something that by default python logging can achieve. however, as
i currently understand it, since the powertools logging library does not
hook into this built-in way of logging, it lacks that functionality.
is this understanding correct?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/aws-lambda-powertools-python/issues/649#issuecomment-927966920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPQBDWTQS6CVZBDXQSFNDUECCHDANCNFSM5CWMENMQ
.

Checking in to see if this helped, and whether we could have more details on the issue report about the workflow to address this properly


polkadot: handle version without leaveDotGit

Leaving the .git directory around results in reproducibility
issues0.

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

/cc @andresilva re: https://github.com/NixOS/nixpkgs/pull/159279

Sorry, this is actually a stupid idea I applied for a flake, but won't work in this scenario.


Spinner for remote data provider

Depends on https://github.com/vaadin/vaadin-grid/pull/1114

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

tests are failing, even after https://github.com/vaadin/vaadin-grid/pull/1114 merged
needs rebase

Doesn't work properly in this case:

@limonte, done.


Add some missing versions for maven plugins

Maven was soft-complaining during the build process.

Test is failing due to missing fix from #1010

Re-opening for CI build


can add a new verify method?

Hi,
I store some data like user id in token, before invoke verify, I need decode token and get the data, then use the data to find secret, but now only have one verify method with string token, can add a method like verify(DecodedJWT jwt)，I decode the string token to a jwt object, then verify the jwt object???

every token has a particular secret, I need decode the token get the 'data', then use the 'data' find secret. I donnot trust the token, I just get some cliam from token, when I get the secret, will make a Verifier object, then verify the token.

If your "data" is a key id and your "secret" a public key, you could use the KeyProvider class to delegate that fetch (using whatever method or library to obtain it).
If this is not your scenario, why would you trust an unverified token's data? You shouldn't.
Possible dupe of #279.

every token has a particular secret, I need decode the token get the 'data', then use the 'data' find secret. I donnot trust the token, I just get some claim from token, once I get the secret, I will make a Verifier object use the particular secret, then verify the token. Now, I need decode token string first, and then verify method decode it again, it look like a waste.

I see. What if an attacker takes your token's payload, replaces the "data" you're using in your "find my secret" step with something they already know it's mapped to a given "secret" value. Then they re-sign the token using that same secret. When is your time to verify the signature, they have already replaced the signature with the one they created for the secret both you and they now. Thus, after your verification passes you will be using your token's contents thinking that no one has tampered with them mistakenly.
I suggest you host a pair of public keys (the JWKS) and move to use RSA256 instead as it protects you from this scenario.
I'll consider the issue linked above but keep the conversation in there.

thanks, but I'm a little confused, I parse the token, use claim data find a relevant 'secret', use the 'secret' generate Algorithm.HMAC256('secret') instance, then use the Algorithm instance generate JWTVerifier instance, and then use JWTVerifier verify token. The attacker impossible to get the 'secret', they just known verify success or fail, so they cannot re-sign token with the 'secret'.

I see. What if an attacker takes your token's payload, replaces the "data" you're using in your "find my secret" step with something they already know it's mapped to a given "secret" value. Then they re-sign the token using that same secret. When is your time to verify the signature, they have already replaced the signature with the one they created for the secret both you and they now. Thus, after your verification passes you will be using your token's contents thinking that no one has tampered with them mistakenly.
I suggest you host a pair of public keys (the JWKS) and move to use RSA256 instead as it protects you from this scenario.
I'll consider the issue linked above but keep the conversation in there.

thanks, but I'm a little confused, I parse the token, use claim data find a relevant 'secret', use the 'secret' generate Algorithm.HMAC256('secret') instance, then use the Algorithm instance generate JWTVerifier instance, and then use JWTVerifier verify token. The attacker impossible to get the 'secret', they just known verify success or fail, so they cannot re-sign token with the 'secret'.


Acknowledge messages on the response channel

This pr fixes issue https://github.com/rjrodger/seneca-rabbitmq-transport/issues/5

LGTM

@DOKKA please fix the merge conflict

@geek this can be closed now. I opened a new one with this fix. ref #12


usm: http2: Simplify static table user mode creation

What does this PR do?
Simplifies the creation of http2_static_table form the user mode.

Motivation
Cleaner code

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Nice!


Add syntax sugar to singleton map creation

Hi!
I have added another syntax sugar to simplify singleton map creation.
for instance:
Map<Integer, Integer> map = HashMap.of(1, 2);

instead of
Map<Integer, Integer> map = HashMap.empty().put(1, 2);

or
Map<Integer, Integer> map = HashMap.of(Tuple.of(1, 2));

P.S. I'm sorry if I'm annoying :)

Current coverage is 91.57%

Merging #831 into master will increase coverage by +0.01% as of b65e343

@@            master    #831   diff @@
======================================
  Files           79      79
  Stmts         8306    8311     +5
  Branches      1663    1664     +1
  Methods          0       0
======================================
+ Hit           7605    7611     +6
- Partial        210     211     +1
+ Missed         491     489     -2

Review entire Coverage Diff as of b65e343

Powered by Codecov. Updated on successful CI builds.

P.S. I'm sorry if I'm annoying :)

It isn't annoying! Your feedback improves the usability!

Well done, many thanks!!


Revert "Support username and password authentication in RHOS"

This reverts commit 1df0abf02174b00b094a6940bbea73932e9bcce7 which was
merged prematurely (without an RM exception).
The fix will be re-merged following 2.5 GA, for 2.5.z.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

/cc @sridhargaddam @tpantelis

/lgtm

/approve


I18N

Cf. https://github.com/recogito/recogito-js/issues/5

Now implemented for all variants (RecogitoJS, Annotorious, Annotorious OSD).


[GHSA-9wx4-h78v-vm56] Requests Session object does not verify requests after making first request with verify=False

Updates

Affected products
Description

Comments
https://pypi.org/project/requests/#history shows the fixed version as yanked.

Hi there @nateprewitt! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Hi @astellingwerf both 2.32.0 and 2.32.1 are valid releases for the CVE patch. They're both available for use on GitHub and PyPI if needed. Yanking a release on PyPI just instructs pip and other package management tools to prefer a different installation if the user doesn't explicitly ask for it. I'm not sure what's in the Security Advisory currently is inaccurate.

Thanks for your response, @nateprewitt. I proposed this change because of https://github.com/renovatebot/renovate/discussions/29280. Renovate will (with OSV alerts enabled) only update to the exact version that is declared as the fix version, but it also refuses to update to yanked/deprecated versions.
I'd imagine it makes little sense to suggest users to update to a yanked version, and the change would allow Renovate to update to a valid version with the fix for this security vulnerability.

Hi @astellingwerf, as @nateprewitt pointed out, version 2.32.0 contains the patch and the fix commit is tagged with version 2.32.0. I'm not accepting the contribution because changing the patched version to 2.32.2 would result in readers of the advisory receiving less accurate information, including thousands of users receiving alerts that say their software is vulnerable when it is not vulnerable. The difficulty you describe at https://github.com/renovatebot/renovate/discussions/29280 sounds frustrating, but difficulty with another org's tooling can't lead me to compromising on data accuracy.
Thank you for your interest in GHSA-9wx4-h78v-vm56 and have a great week.


404 on main.56afcf29.css

When trying to access: http://pcottle.github.io/learnGitBranching/
The main stylesheet seems to not be found, causing the whole page to fail to render correctly.
http://pcottle.github.io/learnGitBranching/build/main.56afcf29.css

I hit this today also

Ah my bad! I'm in manila right now for work and have really bad internet -- for PR #247 yesterday I had to push to prod and something probably got messed up along the way.
i just pushed again and it seems to be working -- sorry for the interruption :scream:


button-has-type not recognizing default props

Hi,
looks like whatever I try the button-has-type rule can't understand the default prop.
type Props = {
  type: 'submit' | 'button' | 'reset',
};

function Button({ type, ...extraProps }: Props) {
  return <button type={type} {...extraProps} />;
}

Button.defaultProps = {
  type: 'submit',
};

error  "null" is an invalid value for button type attribute  react/button-has-type

type Props = {
  type: 'submit' | 'button' | 'reset',
};

function Button({ type = 'submit', ...extraProps }: Props) {
  return <button type={type} {...extraProps} />;
}

error  "null" is an invalid value for button type attribute  react/button-has-type

How are you creating the <Button> element? Note that null doesn’t trigger defaults, but undefined does.

Oh, i see that this is the linter reporting it. This seems like a bug.

I'm getting the same error.
It seems that the button type attribute cannot be dynamic. But I don't understand why...

It is required to be static for a number of reasons; one is that it’s lintable, but also because each kind of button is a fundemantally different component/element - they’re not just different “flavors” of button.

@ljharb In our component library at my company we have a Button component that is used for various things.  We use a oneOf prop type to do an enum of type options and default to button since that's the sane default.  But the button can be used technically as a submit or reset button (and does get used).
We have a component due to css and classes, its easier to have one shared one where the app people don't have to worry about css classes and semantics, they can just use our Button.
I don't want to turn this rule off, but if its going to be forced to be static, don't really see another way.

@truckingsim what i'd expect is that you'd have that Button component wrapped by SubmitButton and ResetButton components, and inside those you'd override the rule for the dynamic type - but you wouldn't need that anywhere else.
(ofc, this is separate from the issue that reset buttons are terrible UX and shouldn't ever be on the page)

@ljharb that's what I just did, but also feels like I shouldn't have to do that.
Is there no way to take props into consideration for rules?  So that basically if there's a default + it only allows what is expected it passes?

If you can come up with a way for the rule to assert that the prop has a propType (or flow/TS type) that only permits one of the proper values, and that that prop is the dynamic value passed in, then that absolutely seems like something that could be allowed.
I'm not sure how to implement that, but I'd be happy to review a PR that achieves that.

Is it acceptable for the rule to just bail out when type is a curly expression?

Not by default; the intention is for the rule to forced a hardcoded inline string type.

It's like taking the variable name as a string value.

@JeromeLin https://github.com/yannickcr/eslint-plugin-react/issues/1846#issuecomment-401849676 ; we should make that error message better but it’d still need to be static.

eeeee
iam getting the same error. 好烦！

A coworker of mine just hit this same issue. She figured out two ways around the issue.
While all of the following feels hacky, these options might help until this bug is fixed.
Option 1: Store your button type in a variable named for one of the valid button types.
function Button({ type, ...extraProps }: Props) {
  const button = type;
  return <button type={button} {...extraProps} />;
}

Option 2: Disable this linter rule just for this line of code:
function Button({ type, ...extraProps }: Props) {
  // eslint-disable-next-line react/button-has-type
  return <button type={type} {...extraProps} >;
}

Happy coding!

@peoplespete note that Option 1 working is actually a bug, which will be fixed very soon :-) Option 2 is the proper workaround.

Has it been fixed in this version?
"eslint-plugin-react": "7.27.1",

@makoto-engineer yes, it was fixed in v7.20.0.

I think this should be closed.
<button type values should always be static so they can be statically analyzed, and for UX reasons reset should never be used.

Hi,
I think it's not fixed. I am using eslint 8.14.0

.

@Manub it’s not fixable. Type values should be static, not coming from a prop.

@manub it’s not fixable. Type values should be static, not coming from a prop (and “reset” should never ever be used)

Why?
Button html tag receive it like props, why should not we add it too?

@SalahAdDin why to which part? "reset" is a horrible UX pattern that should never be used, if that's what you mean.

@SalahAdDin why to which part? "reset" is a horrible UX pattern that should never be used, if that's what you mean.

I mean, the type property should be also available to be passed from a parameter.

Please, don't hang me up on the reset button. I am talking about type=button and type=submit. That's all.. :)

@Manubi @SalahAdDin it does work just fine when dynamically provided. However, that makes it impossible to lint for it - to statically analyze it.
By hardcoding it, you allow the lint rule to be useful.

but than I would need to have two button components one with type submit and one with type button. Right?

@Manubi no, you could still dynamically render one of two button elements within the same component.


Grid RowDefinitions/ColumnDefinitions breaks hot reload in VS 2022

Describe the bug
This might be related to #6370 but since this is another aspect of the break, filing separately
Steps to reproduce the bug
<Grid RowDefinitions="123,*">
...
</Grid>

Expected behavior
No response
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)
Windows app type

[ ] UWP
[X] Win32

Device form factor
No response
Windows version
Insider Build (xxxxx)
Additional context
No response

I reported this already here: https://github.com/microsoft/microsoft-ui-xaml/issues/5944

This means that there is effectively no visual editor for WinUI if you use this XAML as VS doesn't have one, and hot reload doesn't work as it doesn't recognise the XAML if any part is modified.

The problem still exists with Windows App SDK 1.3

As wbokkers says, looks like a dupe of #5944 , closing.


Improvement: Enhance !zu ck command with channel link

Description:
Currently, the !zu ck command does not include a direct link to the channel. To improve user experience, it would be beneficial to incorporate the channel link into the command output. This will allow users to easily access the channel directly from the command response.
Proposed Changes:

Modify the !zu ck command to include the channel link in its output.

Ensure that the link is formatted correctly and is easily accessible to users.

Benefits:

Improved usability and convenience for users.

Streamlined access to the channel, reducing the need for additional steps.

Channel id:<PHONE_NUMBER>80691486 (#échange-marché-corpo)

Previous commit will be used for the bot's code.

Successfully added to the bot:
embed = discord.Embed(title="ZUnivers - Corpokonar checker",color=discord.Colour(value=0x19BC14),
description=f"<#{ZU.utils.ECHANGE_MARCHE_CORPO_CHANNEL_ID}>\n\n" + "".join([f"- {x[0]} : {x[1]}\n" for x in tobe_tagged]))


Problem type example could be less specific

Often, a default problem response will be added to REST API's, referencing the belgif/problem/v1/problem-v1.yaml#/components/responses/ProblemResponse type.
In the generated swagger doc this becomes:

This example feels a bit out of place, as it is a very specific type of problem.
An alternative more generally applicable example could be:
{
  "type": "urn:problem-type:belgif:internalServerError",
  "href": "https://www.belgif.be/specification/rest/api-guide/problems/internalServerError.html",
  "title": "Internal Server Error"
  "status": 500,
  "instance": "urn:uuid:123e4567-e89b-12d3-a456-426614174000"
}

OK to change the problem example.
Having a response for status 500 when specifying generic Problem type for a 4xx code may be confusing as well. Is it possible to override in OpenAPI per response?
Same for InputValidationProblem.
To try out if it's possible to override example per status code; and if it's manageable. If not we can fall back to a generic example problem type that's clearly not used in practice.

Example from schema can be overridden in response object:
       "409":
         description: Conflict
         content:
           application/problem+json:
             schema:
               $ref: "./types.yaml#/components/schemas/Problem"
             example: {
               "custom": "example"
             }

However, it cannot be overridden when $ref-fing the response object:
$ref: "./belgif/openapi-problem.yaml#/components/responses/ProblemResponse".
PR created for more generic examples:  https://github.com/belgif/openapi-problem/pull/12/files

changes merged, I'll create a patch release


Add build script

The build script minifies the HTML, JS, and CSS, then pushes it to gh-pages if it's running in Travis (as linked in #43).
Now someone needs to add a travis.yml thing that does the following:
yarn install
yarn run build

Thanks for getting this started! Continuing work over in #124


Outdated unsoundness information in AsPrimitive documentation

The page for AsPrimitive mentions soundness holes from old versions of Rust related to floating point cast results, more specifically, #10184 and #15536. Those have now been resolved, which is why the documentation should remove mentions of those bugs or explicitly state that those have been fixed and no longer cause undefined behavior.

#184 updated this, but it hasn't been published in a release yet.


Add support of the command LCS

Refer to https://redis.io/commands/lcs/

I'm very interested in this command.

Great! Assigned.


Investigate upgrade to Entity Framework 6

/cc @yishaigalatzer @xavierdecoster
Also check #2595

Did an initial commit - feel free to give it a try.


MWPW-151862: Secure transaction label is not center aligned with CTA

Fixed the secure transaction label vertical alignment on merch cards.
Resolves: MWPW-151862
Test URLs:

Before: https://main--milo--adobecom.hlx.live/docs/library/kitchen-sink/merch-card?martech=off
After: https://mwpw-151862-secure-transaction-label--milo--mirafedas.hlx.live/docs/library/kitchen-sink/merch-card?martech=off

@yesil yes, sorry, now it should be good

@overmyheadandbody the reason you do not see the CTA on the after URL is CORS, because the feature branch is not allow listed.
here is before/after

btw this fix has been already merged to stage via another PR, likely: https://github.com/adobecom/milo/pull/2229/files
hence closing, thanks for the review @overmyheadandbody .

@yesil - I figured CORS is the issue, but I've been thinking more and more that Merch PRs are difficult to test by non-Merch folks. We might need to discuss what we can do to allow anyone to test these.


Convert underscores to hyphens

This is in line with the S3 naming convention: https://docs.aws.amazon.com/AmazonS3/latest/UG/CreatingaBucket.html

Looks fine. Merge away.


climate: Return None for current temperature if not returned by device

Current code will fall-back to raw value of the SET_TEMP property if the device does not return a valid, but that has two problems:

the value can be also unavailable and end up displayed as -3,
SET_TEMP is the currently set temperature, so displaying it as the current room temperature can be confusing to the user.

Fix this by simply returning None if the device does not return the current room temperature.

Ah, good catch, those other special values also need to be handled. Thanks!


[Forge] Incompatible with Rubidium 0.6.5

Mod Name
Rubidium
Mod Homepage
https://modrinth.com/mod/rubidium
Describe the bug
Crash with Rubidium 0.6.5
Steps to reproduce

Install Rubidium 0.6.5
Install Forgified and Connector
(on 1.20.1 with Forge 47.1.3)
Attempt to run

Logs
https://mclo.gs/3fHygCi
Additional context
Seems to be fixed by updating Rubidium, but ≥0.7.0 is incompatible with Oculus for the moment

Duplicate of https://github.com/Sinytra/Connector/issues/39

Ah, mb