Uncaught RangeError after updating tree-sitter

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

clone https://github.com/icecream17/language-javascript/tree/operators
apm install
apm link

This issue is actually because of https://github.com/atom/language-javascript/pull/692, not anything to do with the operators pr
So step 1 could also be:

clone https://github.com/atom/language-javascript (upgrade pr is already merged)

Expected behavior:
No errors
Actual behavior:
This error
(It also prevents syntax-highlighting)
Reproduces how often:
100%
Versions
atom-beta --version
Atom     : 1.56.0-beta0
Electron : 9.4.4
Chrome   : 83.0.4103.122
Node     : 12.14.1

apm-beta --version
apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.56.0-beta0
python 3.9.2
git 2.31.1.windows.1
visual studio 2015

OS: Windows 10 x64
Additional Information
After the above picture, there's another error, and then more of the same error (different stack traces but same cause)

The latest version of tree-sitter is 0.19.4, but I haven't tested whether updating it would fix the problem
    "text-buffer": "^13.18.5",
    "timecop": "https://www.atom.io/api/packages/timecop/versions/0.36.2/tarball",
    "tree-sitter": "0.17.1",
    "tree-view": "https://www.atom.io/api/packages/tree-view/versions/0.228.2/tarball",
    "typescript-simple": "8.0.6",

I ran into the same issue.
The problem appears to be that tree-sitter ABI 13 (release 0.19.0, commit https://github.com/tree-sitter/tree-sitter/commit/774ae5e3d5915dbdcca52e0abf54c3a6023cca3e, Feb 25 2021) is not backwards compatible with previous versions, so fixing this probably requires either duplicating code by supporting multiple versions at once or requiring that all tree-sitter grammars be recompiled in order to be usable.

Reply to previous comment:
See https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md

Hmm, there's no error now (with atom-beta --dev --safe)

Ok, there's no error, but for some reason the old tree-sitter versions are still being used

(Supposed to be "a" then "?." then "b")

Ok, now the error is back again

https://github.com/icecream17/language-javascript/tree/operators


Please grant access to the security scanning settings of the prime-reportstream repo

What type of help do you need?

[ ] Question
[ ] New Repo
[ ] Delete Repo
[ ] User Membership (please make sure new members are familiar with the CDC open practices and set up their profile with name and org info to help people collaborate with them)
[x] Other

I need to work on this ticket, but appear to not have enough permissions on that repo. Could you please grant dkrylovsb access to the security scanning settings of the prime-reportstream repo so that I could finish that ticket? Thanks!

@dkrylovsb
I read the ticket, can you check with Jeremy on your access needs for that repository, since he has the power to grant it too.


Create Initial Project

Create Initial Project
Create an Initial project targeting SharePoint Online.

Initial project is created and basic npm packages are added

Issue Closed


__uuidof(IDXGIDevice) is the preferred way to use this API

@shawnhar : Thanks for your contribution! The author(s) have been notified to review your proposed change.


fix: use utcnow() to check certificate validity

Symptom:
Using the certificates generated using ./create_certs.sh, 'make run-secc' with TLS and PNC enabled, would fail in the CertificateInstallationReq handling:
ERROR    2022-10-21 14:37:20,294 - iso15118.shared.security (977): CertNotYetValidError: Signature verification failed while checking certificate chain
Issue:
The cryptography Certificate object represents the validity period of the certificate in UTC.  https://cryptography.io/en/latest/x509/reference/#cryptography.x509.Certificate
However, security.py is comparing cert.not_valid_before to the local time, and as a result,  the certificate is reported invalid for those of us in zones earlier than GMT.
Fix:
Use datetime.utcnow() instead of datetime.now() to get the current time

thanks @rstanchak for your contribution!


Move settings to its own page

We are currently still having issues with the differences between chrome and firefox and how they handle displaying the settings page. If we have our own page we can completely control the styling.
Example from ublock:

Moved to #1287 👍


feat: Updated support & training page and added Cyren as an adopter

Signed-off-by: Hrishav Kumar<EMAIL_ADDRESS>

/merge


add ray on yarn project

What do these changes do?

Add the ray on yarn project to the folder "devops/yarn" .
This is a java project, which include ray on yarn client and appMaster. You can use this project to deploy a ray cluster on yarn environment.
Please read the file ''devops/yarn/README.md" to get the detail usage.
Future works:

support deploy multiple language version, E.g ray java version.
support an integrated failover implement.

Related issue number
The issue https://github.com/ray-project/ray/issues/2214

How about move the whole package under the java directory,  and of course i think the whole package under root directory has it's own advantages too.

@salah-man Ray on yarn is to be an independent package which can be used by python version and java version. So, if we move the whole package under the java directory, is it a clear folder framework？


add error handling for bs4 import

I don't think using bs4 as dependency has any issue. I used to add third party dependency for thesaurus_query.com support as well. However, doing so shall require failure handling. So that when import bs4 fails, not-so-power user can still use the prompt to understand what went wrong. I added the fail handling and the option to disable the backend in session when the dependency fails.

Sorry for my very late reply...


Lint for ordinal circular argument references

I noticed that Ruby emits a warning for ordinal circular argument references, not just optional keyword argument references. Should be helpful for RuboCop to lint for these as well.

Apart from my small remarks - this has to be rebased on top of the current master.

@bbatsov updated! Wasn't sure how else to put it

You'll have to rebase again - PRs are coming in like crazy these days.

Good problems to have :smile:
Avoiding changelog conflicts feels like it should be a solved problem, but I don't know the solution haha

:-)


Does not work with later JQuery version

       <!--Preloader-->               <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js"></script>
This does not work, hower version 1.6 does work.

google however provided a solution:
http://stackoverflow.com/questions/37738732/jquery-3-0-url-indexof-error
so:
//<![CDATA[ 		$(window).on('load', function() { // makes sure the whole site is loaded 			$('#status').fadeOut(); // will first fade out the loading animation 			$('#preloader').delay(350).fadeOut('slow'); // will fade out the white DIV that covers the website. 			$('body').delay(350).css({'overflow':'visible'}); 		}) 	//]]>
works with JQ version > 3

Thank you @sommmen for your research. I am just uploading the fix.


Add type attribute to buttons in control markup

Reviewer may want to review by commit due to index.html indentation.
gh-pages docs should also be audited.
Fixes #1323.

Updated.


Does anyone want historical btc-e data?

I have btc-e ticker data since Nov. 24th to a resolution of ~3ms. Could provide an api endpoint or just a dump. Is this something people could use?

Hi @Jonahss. Do you still have any relevant historical data? If so would you mind to share it here? Otherwise, @askmike, I think this issue can be closed.

hm yeah. i think I lost all the data long ago :(


Local catalog targeting local json schemas

Would it be possible to manage that local catalog files can refer to local JSON schema files ?
cf https://github.com/nvuillam/mega-linter/issues/730#issuecomment-918898173
Many thanks !

This did come up when the catalogs feature was implemented and we had a bit of a discussion around it:
https://github.com/chris48s/v8r/pull/92#discussion_r671888584
Long story short: the url property is "An absolute URL to the schema location" by design for several reasons

We can validate custom catalogs against https://json.schemastore.org/schema-catalog.json
If a custom catalog were to include a relative path, it may be ambiguous what the path is relative to if the custom catalog is local, and completely nonsensical if the custom catalog is remote

Obviously a local schema can be supplied on a one-off basis using the --schema flag but there is no way to specify a local schema in a custom catalog and I don't think that is the right place to add it.

One thing I have been mulling over since merging #92 is maybe v8r should have some kind of bespoke project config file (a .v8rrc or something) which is explicitly not a schema catalog (although it would probably end up being an extension of https://json.schemastore.org/schema-catalog.json ) that does allow local schema paths. If

.v8rrc must be a local file and
v8r looks for .v8rrc in the directory it is invoked from

then that would clear up the issue of where relative paths are relative to. It could also store files to ignore and that sort of thing if I implement #21. Of course, then I have to design and maintain a custom file format for it including validation. I don't think this is something I will work on soon. It needs some thought before I commit to it, but it is slowly churning around in my mind..

Local cosmiconfig-like file would indeed be nice , please let me know if you decide to implement it :)

Config file format added in v0.12.0 includes a customCatalog property which can include references to local schemas as well as remote ones. Docs at https://github.com/chris48s/v8r#configuration


Can plugin be used on DLA？

I want my model to run independently on DLA, but I found that some layers aren't supported. Is it possible to create a plugin to enable DLA to run those layers?

No, plugin layer is not supported by DLA (https://docs.nvidia.com/deeplearning/tensorrt/developer-guide/index.html#dla_layers).


Wire up the collection page

Describe the feature you'd like to request
Be able to view a collection of projects
This is a step on the way to getting to the full UI/UX of a stats table for the collection.
Describe the solution you'd like
TBD
Describe alternatives you've considered
TBD

For now, this will be handled as several variants on the current explore UI with the ability to access additional metrics, probably similar to how Messari handles this.

See inspo from here

@ryscheng I've added the dateOptions component plus a settings/filters widget that when a user clicks will give them options for selecting additional metrics. For now, we can ignore implementing a filters feature (eg, "num contributors with more than X contributions").

Next steps: implement a filter option to add / change metrics in the table

From discord
Regarding the demo for Oct 2, here's the minimum I think we should aim for in the explore view:

I can filter projects by collection [there will be a variety of OP-related collections in oss-directory]
I can see the following indicators in a sortable table, by project:

Number of repos it owns [from github event data]
Total forks for all of those repos [from github event data]
Total unique contributors for all of those repos [from github event data]
Total active developers for all of of those repos [from github event data]
Number of contracts deployed on Optimism [same as oss-directory]
Number of wallet addresses for receiving funds on Optimism [same as oss-directory]
Number of npm packages it owns [same as oss-directory]

I can further filter by date range [this filters the github event data only]

Stretch goal:

I can click on a project in the table and be brought to its project page
The project page displays real data for Onchain Impact (Metrics related to a project's onchain contracts and the resulting sequencer fees, transaction volumes, and user activity.)
The project page displays real GitHub event data (Metrics related to code and developer contributions for the project.)

Adding an API endpoint for getting data here
https://github.com/opensource-observer/oso/pull/466

Gonna close this out for now, filing subsequent issues on bugs and feature / refinements.


Add M1 Mac homebrew install fallback docs link

I have been struggling to install the CLI, especially through Homebrew. I found a StackOverflow that explains the steps to be able to install it through Rosetta which was the only way I could get it to work. Thought it would be worth adding a little footnote to the step as a fallback if someone else also runs into this.

@borjadotai Is this one still an issue? I have an M1 machine and had no issues with the install and we do publish ARM64 builds for MacOS these days. So I'm inclined to close this PR at this point.


[v9] Cosmwasm Binding API Review

Background
As mentioned in #1505, we need to familiarize ourselves with the cosmwasm API, its relation to osmosis, and if there are any issues with its implementation.
Acceptance Criteria

general dev consensus that cosmwasm API bindings are properly implemented

We basically want to look at the API / usage from within cosmwasm. Not sure if theres an example cosmwasm contract using the bindings in the bindings repo

I can work on that and document my findings

I think this is key as mentioned by @iboss-ptk in Slack.
https://github.com/osmosis-labs/osmosis/pull/1135

TODO for this issue: find or create a sample contract and document it

Done!


Html

You can see the result here:
https://htmlpreview.github.io/?https://github.com/weaversa/cryptol-course/blob/html/html/README.html
Links between labs don't work yet. And, though the code blocks display ok locally in my browser, they don't display correctly via github.io.

I used https://github.com/phseiff/github-flavored-markdown-to-html to render the HTML. As script go generate the HTML is in the scripts directory. Be careful as it uses a github api and you can only send 60 requests per hour, so it's easy to breach the limit.

How does the rendering look in GitHub Pages as a project page?  Based on GitHub Docs, if you go into Settings and declare master as the publishing source, you should see the existing index.html at the URL [`https://weaversa.github.io/cryptol-course``](https://weaversa.github.io/cryptol-course).  If I understand correctly, following the link to `README.md` would render that (and other existing Markdown pages via subsequent links) same as the corresponding code view on `github.com`.  One way to find out...
This wouldn't realize many gains from generating HTML, but neither does the rendering script.

How does the rendering look in GitHub Pages as a project page?  Based on GitHub Docs, if you go into Settings and declare master as the publishing source, you should see the existing index.html at the URL [`https://weaversa.github.io/cryptol-course``](https://weaversa.github.io/cryptol-course).  If I understand correctly, following the link to `README.md` would render that (and other existing Markdown pages via subsequent links) same as the corresponding code view on `github.com`.  One way to find out...
This wouldn't realize many gains from generating HTML, but neither does the rendering script.

I turned it on. Markdown is not rendered automatically.
On Sun, Jan 3, 2021 at 8:43 PM WeeknightMVP<EMAIL_ADDRESS>wrote:

How does the rendering look in GitHub Pages as a project page? Based on GitHub
Docs
https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source,
if you go into Settings and declare master as the publishing source, you
should see the existing index.html
https://github.com/weaversa/cryptol-course/blob/master/index.html at
the URL
https://weaversa.github.io/cryptol-course``
https://weaversa.github.io/cryptol-course](https://weaversa.github.io/cryptol-course).
If I understand correctly, following the link to README.mdwould render
that (and other existing Markdown pages via subsequent links) same as the
corresponding code view ongithub.com`. One way to find out...
This wouldn't realize many gains from generating HTML, but neither does
the rendering script.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaversa/cryptol-course/pull/167#issuecomment-753716100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYQSOVLMBWZRX2K7BH5JN3SYEMKNANCNFSM4VOLKDGQ
.

I turned it on. Markdown is not rendered automatically.
On Sun, Jan 3, 2021 at 8:43 PM WeeknightMVP<EMAIL_ADDRESS>wrote:

How does the rendering look in GitHub Pages as a project page? Based on GitHub
Docs
https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source,
if you go into Settings and declare master as the publishing source, you
should see the existing index.html
https://github.com/weaversa/cryptol-course/blob/master/index.html at
the URL
https://weaversa.github.io/cryptol-course``
https://weaversa.github.io/cryptol-course](https://weaversa.github.io/cryptol-course).
If I understand correctly, following the link to README.mdwould render
that (and other existing Markdown pages via subsequent links) same as the
corresponding code view ongithub.com`. One way to find out...
This wouldn't realize many gains from generating HTML, but neither does
the rendering script.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaversa/cryptol-course/pull/167#issuecomment-753716100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYQSOVLMBWZRX2K7BH5JN3SYEMKNANCNFSM4VOLKDGQ
.

We have to do something like this:
https://nicolas-van.github.io/easy-markdown-to-github-pages/
On Sun, Jan 3, 2021 at 8:55 PM Sean Weaver<EMAIL_ADDRESS>wrote:

I turned it on. Markdown is not rendered automatically.
On Sun, Jan 3, 2021 at 8:43 PM WeeknightMVP<EMAIL_ADDRESS>wrote:

How does the rendering look in GitHub Pages as a project page? Based on GitHub
Docs
https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source,
if you go into Settings and declare master as the publishing source, you
should see the existing index.html
https://github.com/weaversa/cryptol-course/blob/master/index.html at
the URL
https://weaversa.github.io/cryptol-course``
https://weaversa.github.io/cryptol-course](https://weaversa.github.io/cryptol-course).
If I understand correctly, following the link to README.mdwould render
that (and other existing Markdown pages via subsequent links) same as the
corresponding code view ongithub.com`. One way to find out...
This wouldn't realize many gains from generating HTML, but neither does
the rendering script.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaversa/cryptol-course/pull/167#issuecomment-753716100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYQSOVLMBWZRX2K7BH5JN3SYEMKNANCNFSM4VOLKDGQ
.

We have to do something like this:
https://nicolas-van.github.io/easy-markdown-to-github-pages/
On Sun, Jan 3, 2021 at 8:55 PM Sean Weaver<EMAIL_ADDRESS>wrote:

I turned it on. Markdown is not rendered automatically.
On Sun, Jan 3, 2021 at 8:43 PM WeeknightMVP<EMAIL_ADDRESS>wrote:

How does the rendering look in GitHub Pages as a project page? Based on GitHub
Docs
https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#choosing-a-publishing-source,
if you go into Settings and declare master as the publishing source, you
should see the existing index.html
https://github.com/weaversa/cryptol-course/blob/master/index.html at
the URL
https://weaversa.github.io/cryptol-course``
https://weaversa.github.io/cryptol-course](https://weaversa.github.io/cryptol-course).
If I understand correctly, following the link to README.mdwould render
that (and other existing Markdown pages via subsequent links) same as the
corresponding code view ongithub.com`. One way to find out...
This wouldn't realize many gains from generating HTML, but neither does
the rendering script.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaversa/cryptol-course/pull/167#issuecomment-753716100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYQSOVLMBWZRX2K7BH5JN3SYEMKNANCNFSM4VOLKDGQ
.

Alright. It works. Though, the markdown doesn't turn
" ```Xcryptol session "
into a code block. Otherwise, it looks cool! I'm messing around with themes right now.

Alright. It works. Though, the markdown doesn't turn
" ```Xcryptol session "
into a code block. Otherwise, it looks cool! I'm messing around with themes right now.

Ooh, a gazpacho recipe!
Are you using the CommonMark Markdown renderer (one of the settings)?  Not sure why this behavior would be inconsistent.
But good work with the GitHub Pages setup!

Ooh, a gazpacho recipe!
Are you using the CommonMark Markdown renderer (one of the settings)?  Not sure why this behavior would be inconsistent.
But good work with the GitHub Pages setup!

@WeeknightMVP Ok. It looks like Xcryptol session won't work, but Xcryptol-session will. Do you foresee any trouble changing spaces in markdown identifiers into dashes? This HTML stuff is so cool!

@WeeknightMVP Ok. It looks like Xcryptol session won't work, but Xcryptol-session will. Do you foresee any trouble changing spaces in markdown identifiers into dashes? This HTML stuff is so cool!

Also, the svg course flow is not clickable as currently embedded.

Also, the svg course flow is not clickable as currently embedded.

Also, the SVGs aren't responding to clicks on my end.  If you open it in a new tab, though, the links work.
I agree we should settle for Xcryptol-session for now.

Also, the SVGs aren't responding to clicks on my end.  If you open it in a new tab, though, the links work.
I agree we should settle for Xcryptol-session for now.

Also, if we use different themes, we should give the SVGs a transparent background.  Simple enough...

Also, if we use different themes, we should give the SVGs a transparent background.  Simple enough...

Looks like you can wrap SVG links with the nomarkdown directive, e.g.:
{::nomarkdown}
<svg ...>...</svg>
{:/}

No idea how the github.com code view would render these...

Looks like you can wrap SVG links with the nomarkdown directive, e.g.:
{::nomarkdown}
<svg ...>...</svg>
{:/}

No idea how the github.com code view would render these...

@WeeknightMVP I fixed the svg issue (good enough). I see that the layercake doesn't work due to how relative pathnames are  interpreted. See: https://github.com/jekyll/jekyll/issues/332
There are workarounds...but i'm not sure what the best solution is. I would like the relative markdown links to continue to work in tools like VSCode, but also work with github.io

@WeeknightMVP I fixed the svg issue (good enough). I see that the layercake doesn't work due to how relative pathnames are  interpreted. See: https://github.com/jekyll/jekyll/issues/332
There are workarounds...but i'm not sure what the best solution is. I would like the relative markdown links to continue to work in tools like VSCode, but also work with github.io

@WeeknightMVP I tried the {{ site.baseurl }} solution suggested above and it linked to the correct info, but used .md extension instead of .html. So, no good.
I also tried this:
# From here, you can go somewhere!

Up: [Course README](../../README.md)
Previous: [Language Basics](../Language/Basics.md)
Answers: [CRC](CRCAnswers.md)
More: [Cryptol Demos](../Demos/Cryptol/Demos.md)
      [SAW Demos](../Demos/SAW/Demos.md)
Next: [Salsa20](../Salsa20/Salsa20.md)

Which works perfectly. You can see it in action at labs/CRC/CRC.md
Now we REALLY need that layercake autogenerator :-)

@WeeknightMVP I tried the {{ site.baseurl }} solution suggested above and it linked to the correct info, but used .md extension instead of .html. So, no good.
I also tried this:
# From here, you can go somewhere!

Up: [Course README](../../README.md)
Previous: [Language Basics](../Language/Basics.md)
Answers: [CRC](CRCAnswers.md)
More: [Cryptol Demos](../Demos/Cryptol/Demos.md)
      [SAW Demos](../Demos/SAW/Demos.md)
Next: [Salsa20](../Salsa20/Salsa20.md)

Which works perfectly. You can see it in action at labs/CRC/CRC.md
Now we REALLY need that layercake autogenerator :-)

For what it's worth, I spent some cycles during the summer linking the
modules. Or at least trying to: I couldn't find a mechanism that worked
consistently in different domains (viewing via GitHub vs. downloaded).
Cheers,
Zig
On Wed, Dec 30, 2020, 6:59 AM weaversa<EMAIL_ADDRESS>wrote:

You can see the result here:
https://htmlpreview.github.io/?https://github.com/weaversa/cryptol-course/blob/html/html/README.html
Links between labs don't work yet. And, though the code blocks display ok
locally in my browser, they don't display correctly via github.io.

Reply to this email directly, view it on GitHub
https://github.com/weaversa/cryptol-course/pull/167, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRABRMU2ZPDMI6CEYU5XRTSXMW5ZANCNFSM4VOLKDGQ
.

For what it's worth, I spent some cycles during the summer linking the
modules. Or at least trying to: I couldn't find a mechanism that worked
consistently in different domains (viewing via GitHub vs. downloaded).
Cheers,
Zig
On Wed, Dec 30, 2020, 6:59 AM weaversa<EMAIL_ADDRESS>wrote:

You can see the result here:
https://htmlpreview.github.io/?https://github.com/weaversa/cryptol-course/blob/html/html/README.html
Links between labs don't work yet. And, though the code blocks display ok
locally in my browser, they don't display correctly via github.io.

Reply to this email directly, view it on GitHub
https://github.com/weaversa/cryptol-course/pull/167, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRABRMU2ZPDMI6CEYU5XRTSXMW5ZANCNFSM4VOLKDGQ
.


More eval results

Add MMLU, DROP, HumanEval, and BBH.
Basically, this could be achieved by using instruct-eval
BTW, my research interests lie particularly in efficient language models. This project is very interesting to me, and I would like to further contribute to this project if possible! E.g., currently, we are testing how Llama would behave when using speculative decoding, and TinyLlama would be a nice option.

I will find some time to reproduce your result tonight and then merge it. I have sent you an e-mail with my contact number. We can have some discussion :).

I realize the generation_config of our checkpoint will toggle on sampling, which makes the benchmark scores returned by instruct-eval different for each different run. I have since updated the generation config to disable sampling by default here. I will update the README now and close this pull request.


Modified the code so it follows the latest official Nuxt's Module Author Guide and bumped the medusa package version

Modified the code so it follows the latest official Nuxt's Module Author Guide and bumped the medusa package version.

Updated the packages to recent versions recommended by the guide.
Updated the npm scripts accordingly.
Added a default tsconfig.json file for the playground client code.
Added a default tsconfig.json file for the playground server code.
Updated app.vue to follow linting rules.
Updated module.ts to use the import type declaration.
Added yarn run dev:prepare as a pre step to the prepack operation in the release script.
Bumped @medusajs/medusa-js to the latest version.

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Hello @Baroshem as I said in the issue #31, I had a problem that seemed related to the npm package release. I tried to execute the module locally and it worked great, but I couldn't get it to work when importing the module as an npm package. I started to investigate and noticed that the module was not following the latest Nuxt Module Author Guide, so I updated the packages, added some default configuration to TypeScript that the builder needed and finally tested the module by uploading it to an npm registry  (it was my first time doing that) and it worked. I imported the test package in the project that I had the issue with in the first place, and it was a success.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

I don't know if this changes are ok, or if we need to change another thing or do further testing (first time contributor here :smiley: ). I tried executing the tests and they passed. I also tried to execute the playground example and it worked great. I also tried the package in the project that I had the problem in the first place and it worked there too.

Hey,
Thanks for this PR! I will review it and give you some hints :)

One small comment to resolve :)

That's right! That was an oopsie, I forgot to change back the name when I uploaded it to the npm registry for testing. Let me do a commit to fix it.

No worries Buddy. I am merging this PR and will release a new version soon! :)


fix: correct output

What does this PR do?
Corrects output issues raised in a previous PR
What issues does this PR fix or reference?
@W-11625322@

@WillieRuemmele Looks like the majority of these were fixed by you and Juliet, thank you!
This PR addresses the human results for pvr.

QA Notes

✅ : --json output now produces     "Branch": null, to match toolbelt
❓ : table output is printing
 Version                        <IP_ADDRESS>
 Description

where toolbelt prints
 Version                        <IP_ADDRESS>
 Description                    null


WIP: a first notebook tutorial

Proposed changes
Support for tutorial guides, embedded directly within notebooks.

I propose to write tutorials directly in notebooks so that we can embed them in the docs like in here.

@francescofarina do not hesitate to edit parts of the quickstart as needed. You can also present some of the graph operations you implemented if you think it's appropriate.

This is very cool @TristanBilot!

@TristanBilot can we merge this and then iterate on more tutorial examples?

Yes we can merge


'Fade Out' function in the animation.js plugin throwing an error

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When using the 'Fade Out' function in the animation.js plugin it throws an error:
Uncaught TypeError: graph.fadeNodes is not a function
To Reproduce

Open diagrams.net with the anim plugin: https://app.diagrams.net/?p=anim
Create a diagram and select any element of the diagram
Click on the menu Extras -> Animation
Click on "Fade Out" then on "Preview"
See the error happening!

Expected behavior
"Fade Out" should work without throwing an error!
Screenshots

diagrams.net version (In the Help->About menu of the diagrams.net editor): 20.3.6
Additional context

The error is on the line animation.js:139:17: graph.fadeNodes(graph.getNodesForCells([cell]), false);

Thanks for the report. This will be fixed in the next release.

Internal commit https://github.com/jgraph/drawio-dev/commit/0c99b6306a7e5553ba309c3b79095d6c78656bed


C# CognitiveServices.Speech.SpeechSynthesizer always fail to open http API when working behind a proxy server

Describe the bug
When using SpeechSynthesizer behind a Proxy server, it always fail to reach the Azure server.
I have configured the same proxy setting and it works with SpeechRecognizer, but it fail with SpeechSynthesizer.
To Reproduce
Steps to reproduce the behavior:

Set proxy setting in SpeechConfig
var synthesizer = new SpeechSynthesizer(config) -> no exception
var result = await synthesizer.SpeakTextAsync(text) -> result.Reason is "Canceled", Error Details is "HTTPAPI result code = HTTPAPI_OPEN_REQUEST_FAILED."
If I execute same code without seating behind a proxy server, no error.
SpeechRecognizer works fine with the same proxy setting under the same environment, I suggest to compare code between this 2 classes.

Expected behavior
SpeechSynthesizer works fine under a proxy server
Version of the Cognitive Services Speech SDK
Latest stable version 1.4.0
Platform, Operating System, and Programming Language

OS: Windows 10 Pro
Hardware - x64
Programming language: C# .NET Windows Form

we will take a look -
can you try without a proxy in your network?

we will take a look -
can you try without a proxy in your network?

As I mentioned in step 4 "If I execute same code without seating behind a proxy server, no error."

Just got the same issue. I can confirm its not working behind the proxy but working without proxy.

this will get fixed in a future release (not in the upcoming 'early May' refresh.
sorry about the trouble
Wolfgang

@Acetylen3 @dotnetdude FYI, the proxy for SpeechSynthesizer is now supported in release 1.6.0. The usage is same as SpeechRecognizer.


Move Bleve search index data from singleton to songlist.

This patch brings a few important changes:

Library indexing is asynchronous again.
Overlapping library updates during indexing aborts the old indexing job, and starts a new one.
Each songlist might potentionally have their own Bleve index.
More code documentation.

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   53.35%   53.35%
=======================================
  Files          51       51
  Lines        1818     1818
=======================================
  Hits          970      970
  Misses        825      825
  Partials       23       23

Impacted Files
Coverage Δ

commands/isolate.go
28.12% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5789d68...b1f44e0. Read the comment docs.


[RRFC] Stateful/reactive render functions

[x] I searched for an existing RRFC which might be relevant to my RRFC

Motivation
Functions are the simplest unit of composition and the first tool a developer leverages to accomplish almost any task. lit empowers developers to write shareable interoperable code that creates rich interactive interfaces. Minimizing the distance and friction between starting with a function and ending with a great UI serves that goal.
There are 2 main pieces of this puzzle: (1) describing rendering, (2) managing reactive state.
Describing rendering: Lit's html and css TTL syntaxes are excellent at this, and can easily be returned from a function.
Managing reactive state:

Lit's reactive properties provide an excellent mechanism for managing reactive state and make sense to use when creating custom elements that extend LitElement. If a dev started with a function, they must move to a class, and this is fine when it makes sense.
However, the new @lit-labs/preact-signals library provides an alternative for simpler use cases and it more seamlessly builds on top of functions.

Signals are reactive state containers. Their reactivity does require using them within a scope that records dependencies (aka effects), but the lit signals package provides SignalWatcher and watch to deal with this.
The one remaining problem is having a convenient way to create signals within a function. They can certainly be passed in as arguments, but what if they are internal the ui being managed by the function?

This last issue is addressed below...
Example
Consider creating a simple counter:
In a LitElement, it looks like:
@state()
accessor count = 0;

render() {
  return html`<button @click=${() => this.count++}>${this.count}</button>`;
}

With a function using signals, this can be:
const renderCounter = () => html`<button @click=${() => count.value++}>${count}</button>`;

But this doesn't work because we need to get the count signal from somewhere.
How
React solves this problem with hooks, but these have tradeoffs. Lit can make this more straightforward by leveraging the fact that all Lit templates are rendered into persistent "parts," and access to them is provided via the directives API.
So, all we need is a simple directive that can initialize state. Here's the updated counter example:
const renderCounter = (use) => {
  const count = use.state(() => signal(0));
  return html`<button @click=${() => count.value++}>${count}</button>`;
}

Then use it like this:
  return html`counter: ${stateful(renderCounter)}`

See working prototype.
The stateful directive provides a state method which memoizes the result of its argument.
References

n/a

Using this stateful directive building block with signals can unlock powerful behavior like this (which could be even further simplified):
const renderComments = (use, dataId) => {

  const stages = use.state(() => {

    const button = createRef();
    const buttonClicked = interactive(button); // separate helper

    return [
      // initial
      html`<button ref=${button}>Load Comments...</button>`,
      // loading
      new Promise(async (resolve) => {
        await buttonClicked;
        resolve(html`Loading...`);
      }),
      // comments
      new Promise(async (resolve) => {
         await import('comments'); // import-mapped
         const comments = await fetch(`commentsUrl/?id=${dataId}`);
         resolve(html`<x-comments .comments=${comments}></x-comments>`);
     })
     ].reverse();
  });

  return html`${until(...stages)}`;
}

Would be great if Lit were to use @lit-labs/preact-signals (or native signals once widely available) to make stateful function components a thing


Set handleActions to true

Changes:

Sets handleActions to true so the modal is created by Stripe.js.
Deleted function that used to handle the action, because it's unnecessary.
Minor changes to server.py

PD: The screenshots were taken with the current Stripe.js version, after we update the modal the voucher will look prettier.

@bonsanto-stripe Can you make sure to add the updated GIF too? With the modal? I assume you don't want to add it right now because the view needs to be fixed so it looks better, but once that's done let's not forget to come back and update the GIF :D


BUGFIX: rename videoragqna to videoqna to align with other examples

Description
As per request from OPEA technical forum, rename videoragqna to videoqna to align with other examples
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)
[ ] Others (enhancement, documentation, validation, etc.)

Dependencies
N/A
Tests
Describe the tests that you ran to verify your changes.

I fixed some issues for this example, please resolve the conflict.


Get-NfsMappedIdentity not working with UserIdentifier 0

When I try to check the mapped username to uid 0, I don't get a result:
(Get-NfsMappedIdentity -AccountType User -UserIdentifier 0).UserName
Every uid > 0 works, also (Get-NfsMappedIdentity -AccountType Group -GroupIdentifier 0).GroupName works fine, but not uid=0
(Windows 2012)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 852407bf-e8f2-7cb2-13a9-636576e87215
Version Independent ID: dd352e1e-a322-c60f-42b3-f69192d87db7
Content: Get-NfsMappedIdentity (nfs)
Content Source: docset/windows/nfs/get-nfsmappedidentity.md
Product: w10
Technology: powershell-windows
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@officedocsbot assign @e0i

Hello, @ivoruetsche  thank you for providing feedback.
Note that the issue tracker of this repository is intended for product documentation issues only.
Please consider opening a support ticket for product issues and bugs via the following link,
PowerShell UserVoice
You can also check relevant resources and ask the community regarding your problem via PowerShell Community,
PowerShell Community
Thanks.

@officedocsbot close


Add alternate pad chhed field to DB

SGPC saroops differ between themselves. For research purposes, it can help users to understand why there are differences in the displayed gurbani to what they may have found in their physical proofs.
In addition, work has been done by other schools of thought. One would imagine they are hoping to stir discussions on producing a singular, agreed-upon standard for the collective Sikh.
Since changes have been made to the SGPC saroops over time, it's easy to see that the standard can shift and is unlikely 100% "correct" today. Whatever "correct" means, is for a different discussion.
These alternates can help with verification, understanding nuances, and enriching a researcher with information.
Hopefully in the future, a larger collective group will begin the procedure to decide upon a single standard. We hope including this information helps them.

Duplicate of #95


Variable 'all_amis' duplicate found

Including the 'all_amis' variable breaks multi module configuration where each of my modules reference this module.

Could you please paste sample config which breaks it ?

For an example I have 2 modules (A,B) where both modules include:
module "ami" {
  source = "github.com/terraform-community-modules/tf_aws_coreos_ami/instance_type"
  region = "${var.region}"
  channel = "stable"
  instance_type = "${var.instance_type}"
}

These modules are executed with Make where Terraform command is called like:
terraform apply -target module.B

@llinder try now, thanks @girishramnani :)

That fixes it.  Thanks!


Find a crash

It's crashed when I click the view MarginView.Maybe cause by the code  "        view.layoutMargins = UIEdgeInsetsMake(5, 10, 15, 20); "  crash report -[UIView setLayoutMargins:]: unrecognized selector sent to instance 0x1755e5a0

The Masonry library does not add a method called setLayoutMargins to UIView.

@cloudkite Find.May I ask you another question?  the mesthod +(BOOL)requiresConstraintBasedLayout should be use in what kind of situation?

This tells UIKit it needs to call updateConstraints
see https://github.com/Masonry/Masonry/blob/master/Examples/Masonry iOS Examples/MASExampleUpdateView.m

@cloudkite Thank you .


Failed when I test with "The Python Driver API by Example"

I meet errors when I follow the guide of "The Python Driver API by Example" http://bigchaindb.readthedocs.io/en/latest/drivers-clients/python-driver-api-examples.html.

>>> from bigchaindb.client import temp_client
>>> c1 = temp_client()
>>> tx = c1.create({'value':'233333', 'msg':'test client'})
>>> tx
{'transaction': {'conditions': [{'new_owners': ['Ghve9ecC9gekwWh7LHMdrTDthVcD5LUiA3uLHcsHcRdG'], 'cid': 0, 'condition': {'uri': 'cc:4:20:6VswEYH3o-jW8AkaY_-SiCEibRQGDkFdeGF9ZzvdPw8:96', 'details': {'type': 'fulfillment', 'signature': None, 'type_id': 4, 'bitmask': 32, 'public_key': 'Ghve9ecC9gekwWh7LHMdrTDthVcD5LUiA3uLHcsHcRdG'}}}], 'operation': 'CREATE', 'fulfillments': [{'fid': 0, 'input': None, 'current_owners': ['DNh9fJwqfh8rMgxi2uZ8znCra1xhEYczFfcp6HKii4zu'], 'fulfillment': 'cf:4:t9rWS08U6nMrazXOwBhZvPUGmB4HU59_rQYBM4Z370Lne68F5Ph2TE_ZFQy_bVHVpMum52JJWe3OQ8EAGd1i4eUtF6J_5_2XSs5UFbIYTWOC1n1Hg6bmRC3LnhmcM7cM'}], 'timestamp': '1466667154.303503', 'data': {'hash': '28e538ae3672b171a33286901221a5ba5856aca42127cb29ee7f50bd480765b5', 'payload': {'value': '233333', 'msg': 'test client'}}}, 'version': 1, 'assignee': 'DNh9fJwqfh8rMgxi2uZ8znCra1xhEYczFfcp6HKii4zu', 'id': 'faeda120b633bb9c828a6981c4ed2047280b993153131278e3bf41915a90a2ce'}
>>> c1.transfer(c2.public_key, tx['id'], {'value':'33333', 'msg':'test client transder'})
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.4/dist-packages/bigchaindb/client.py", line 91, in transfer
tx, private_key=self.private_key)
File "/usr/local/lib/python3.4/dist-packages/bigchaindb/consensus.py", line 229, in sign_transaction
return util.sign_tx(transaction, private_key)
File "/usr/local/lib/python3.4/dist-packages/bigchaindb/util.py", line 335, in sign_tx
input_condition = get_input_condition(bigchain, fulfillment)
File "/usr/local/lib/python3.4/dist-packages/bigchaindb/util.py", line 512, in get_input_condition
previous_tx = bigchain.get_transaction(input_tx['txid'])
TypeError: string indices must be integers

I try to figure out the reason. It seems the second arguement of c1.transfer should not be tx['id'], and it should be {'cid':'****', 'txid':'*****'}.
When I test c1.transfer with b.get_owned_ids(c1.public_key), it works well.

>>> b.get_owned_ids(c1.public_key)
[{'cid': 0, 'txid': 'faeda120b633bb9c828a6981c4ed2047280b993153131278e3bf41915a90a2ce'}]
>>> c1.transfer(c2.public_key, b.get_owned_ids(c1.public_key), {'value':'33333', 'msg':'test client transder'})
{'transaction': {'conditions': [{'new_owners': ['DEZ7xyTvwGHzDVHzehZgftqzNVSooYFE1WbTskgava7Q'], 'cid': 0, 'condition': {'uri': 'cc:4:20:tcUcp54xZ2I9ZOXigp6ai0UvHU3sPgotoIgYZdUmI48:96', 'details': {'type': 'fulfillment', 'signature': None, 'type_id': 4, 'bitmask': 32, 'public_key': 'DEZ7xyTvwGHzDVHzehZgftqzNVSooYFE1WbTskgava7Q'}}}], 'operation': 'TRANSFER', 'fulfillments': [{'fid': 0, 'input': {'cid': 0, 'txid': 'faeda120b633bb9c828a6981c4ed2047280b993153131278e3bf41915a90a2ce'}, 'current_owners': ['Ghve9ecC9gekwWh7LHMdrTDthVcD5LUiA3uLHcsHcRdG'], 'fulfillment': 'cf:4:6VswEYH3o-jW8AkaY_-SiCEibRQGDkFdeGF9ZzvdPw-rIjPgTP_SR9vY4pq_-WQOXTu1uaOolAZ_amJVWv1dkfA3AFs_ZeMHc5Xhejjru9JUw-twuXDXvy-yPrQzl-EE'}], 'timestamp': '1466667692.027563', 'data': {'hash': 'ff9ccdb976ac39fd8d3a9dcf9d8d2884f0a7e622183d5141dc665f2f9d4613d2', 'payload': {'value': '33333', 'msg': 'test client transder'}}}, 'version': 1, 'assignee': 'DNh9fJwqfh8rMgxi2uZ8znCra1xhEYczFfcp6HKii4zu', 'id': 'b0e9dd71173814e7a3245079e06a3cae62889f0ec1b8dfe69644952da02a3d91'}

I try to figure out the reason. It seems the second arguement of c1.transfer should not be tx['id'], and it should be {'cid':'****', 'txid':'*****'}

Its true. Since we added support for multiple inputs and outputs, when specifying an input you also need to pass the condition index.
We will update the docs

Cool.
I am a freshman of BigchainDB, thanks so much for your response.
I have another question about BigchainDB. As you mentioned BigchainDB support multiple inputs and outputs.  If I want to implement a trade system, using BigchainDB, can BigchainDB support the multiple outputs with different users for now. For example, User A owns a transaction with 10 'dollars' as payload, and it wants to transfer 5 dollars to user B, and 5 dollars to user C.

A transfer transaction can transfer several different assets, each with different old and new owners.
Your example is about something different. Right now, an asset can't be split apart into smaller pieces. Right now, BigchainDB only handles indivisible assets. There's an enhancement proposal to support divisible assets.

At this point we do not support divisible assets, its on the roadmap #129
We also do not support sending different inputs to different owners with the current api. When you used create transaction all of the inputs will go to the same new_owners. Maybe we should rethink this and add support for this in the bigchaindb api.
You can however do it by creating custom crypto conditions https://bigchaindb.readthedocs.io/en/latest/nodes/python-server-api-examples.html

Resolved by PR #402


Update semanticdb-scalac to 4.8.12

About this PR
📦 Updates org.scalameta:semanticdb-scalac from 4.8.11 to 4.8.12
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "semanticdb-scalac" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "semanticdb-scalac" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (9a80aff) 85.61% compared to head (4bbc8c2) 85.61%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage   85.61%   85.61%
=======================================
  Files         141      141
  Lines        1529     1529
  Branches      258      258
=======================================
  Hits         1309     1309
  Misses        220      220

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Documented 'databases' check function argument.

Added in #12396 but not covered for the custom checks.

Rebased

@adamchainz Thanks :+1:


Moving keymaps shouldn't be dot-repeatable by default

I noticed that keymaps like ]q is dot-repeatable by default. Yes, I can disable it, but the default behavior is different from https://github.com/tpope/vim-unimpaired and Neovim in general (all moving operations like C-o is not dot-repeatable).

While I was writing this plugin, I thought about this for a while and intentionally decided to make them dot repeatable. I wanted to try, if it brings any benefit. But I think you're right, we should stick to tpopes defaults and change that. Give me some time because I'm a bit busy atm. Or you do a PR yourself.

@tummetott opened #6.


[Feature Request] Add groups to the search bar

Is it possible to add groups to the search bar? c: Would be great. The search bar on the vrchat website is very weird and only finds groups when you wrote the exact name instead of showing everything with the searched word in it. Maybe you can fix this. c:

Nope it's the reason VRCX doesn't have group search, it isn't available yet.


Potential issue while saving multiple cross-linked records inside one transaction

Current approaches:

save only one record since it will automatically sync outer one as part of branch
Use withRelations false for one of records

Fixed in 1.0.1 using branch limiters (for belongs-to relations)


Docker support

To try ex.sh at non-bare VPS, Docker is preferable.

Docker file and instructions are added https://github.com/EvgenyNerush/easy-xray/commit/20d02b8b10aacfaad508b15a0e36d33ca431ce2e


Add order filled_quantity

When we process an order we need to know how many the client requested (quantity_requested) and how many we will actually give them (quantity_filled).

[x] Create migration to add filled_quantity to OrderDetails
[ ] Implement filled_quantity to replace details.quantity(usually in a @order.order_details loop) where needed

When do we update filled_quantity? Do we want to display this to admin and non-admin users?

Once the order is submitted, the 'quantity' is locked in. The admin user will see the 'Quantity Requested' as non-editable text.
When the next action is to 'Approve!' or 'Fill Order', the quantity_filled will be a new column called 'Quantity To Be Filled'. This will be an editable field and will be pre-populated with the requested quantity.
Once the order is filled, (and the next action is to 'Ship It!'), the filled_quantity column will be called 'Quantity Filled' and will be uneditable.

Should we update the order_details quantity column to be called 'quantity_requested'?

Fixed in #374


OVH link rot

In Friends of Rust page, OVH's link to "log management system" redirects to https://labs.ovh.com/ which is not informative.

cc @jedisct1 from #449.

https://www.ovh.com/world/a2202.paas-logs-management-ovh appears like a better link.


react-native Integrated into the Swift project, cannot use use_frameworks! in Podfile

@Ramonfan could you post a link in addition to that screenshot? I'd like to see the rest of the discussion.

@genuinezack this is this link of post https://github.com/facebook/react-native/issues/25349

Ok great - thanks @Ramonfan. I see there that we can (hopefully) expect to see this fixed in 0.61.0. Fingers crossed!


Comparison with other tensorboard libs

Hi, sorry for the non-coding question. What's the difference between this library and the other older ones like Crayon and tensorboard_logger? Crayon looks a bit heavy-weight because it requires docker. tensorboard_logger has not been maintained for 9 months. Other than these, are there any functional differences?

I think tensorboard_logger can only be used for scalar data, so it can't be used for data with greater than 0 dims such as histograms.
This tensorboard-pytorch repo seems to be best because it retains all of tensorboard's functionality while remaining lightweight.

tensorboard_logger only saves scalar values, while tensorboard-pytorch saves other data such as image, audio, text, embedding, etc. Another difference is the suffix "-pytorch", tensorboard-pytorch let you pass pytorch tensors directly and it will make conversion behind. Compared with crayon, this package also supports more data format.

@lanpa this is awesome. I'll stick with your library for my research. Thanks for the efforts!


Referencing playwright in base project fails: Driver not found in any of the locations

Context:

GOOD Playwright Version: 0.170.2
BAD Playwright Version: all later
Operating System: Windows

Code Snippet

https://github.com/andyTheCoder/playwright-parent
run test in child project: fails

Describe the bug

Base project contains playwright nuget reference
Child project references base project
Child project does not contain playwright nuget reference
Test running in child project fails with: PlaywrightSharp.PlaywrightSharpException, Driver not found in any of the locations.

Note that when the child project includes the playwright nuget package, all is ok

Thanks for the quick response.
This is not a showstopper, it is just not expected behaviour of project references.
NB the reason I tagged this issue with regression is because the expected behaviour was working in version: 0.170.2

I believe this has been resolved in https://www.nuget.org/packages/Microsoft.Playwright/1.11.1-alpha-2. Please file a new issue if this still happens.

I can confirm that this has been resolved. Tested in Microsoft.Playwright Version="1.12.2"


general lecture

organised series of lectures for both developers and designers.

Gave a talk on primary, secondary and tertiary buttons and the benefits of implementing a 4 point system in a designs amongst other topics

I explained what a primary, secondary and tertiary button is and where and how they can be used in design. I explained button material design, shape psychology and colour psychology in design to team members with @Adevikthur .
I helped members understand how to implement a spacing system in their designs by creating a figures template designers could use. I explained how also using our grid system I created would make things easier because it already follows our spacing system

I organised brief meetings to teach, explain and provided materials to the developer team members


[CT-1290] Check root cause of not supporting Python 3.7.0/1

dbt-core does not run with Python 3.7.0, Python 3.7.1 (issue for removing support / (merged PR)).
Looking at this comment, it's possible we could undo this restriction on any dbt versions that support Mashumaro 3.0+ which as of now includes 1.3.latest.
The task is to undo the restriction on main and see if dbt runs. If it does, we can remove the Python version restriction, and backport to 1.3.latest.
Because there are not many people using these old versions of Python this is a low impact change.

We no longer support 3.7


Fix broken link syntax in upgrading verison 7 doc

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
n/a Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
n/a Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation
[x] Recognize contributor in release notes

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

There is a bad link:
# Valid links are:
# * Inside the same file: <<(#)section-name(,text)>>
# * To a different file: <<other-file(.adoc)#section-name,text>> - Note that the # and section are mandatory, otherwise the link is invalid in the single page output
#
# The checker does not handle implicit section names, so they must be explicit and declared as: [[section-name]]
ERROR: upgrading_version_7.adoc:306 Looking for section named application_convention_properties in application_plugin.adoc
    link:{javadocPath}/org/gradle/api/plugins/ApplicationPluginConvention.html[ApplicationPluginConvention] was already listed as deprecated in the <<application_plugin.adoc#application_convention_properties, documentation>>.

Ah, sorry, did not verify the section name, just fixed the ADOC syntax.
Section name should be valid now too.

And I missed it as well, thanks for the quick follow up.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

Some problem to resolve groovy? Doesn't look like my error?

No it's not your fault, repo.gradle.org was quite unstable in the past 2 days. Let's retry it.
@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Doppler shift animation and panel does not include negative shift

Hi Cédric:
On the latest V2.3.3 Dev jSolEx, I noticed when doing panels (see attached), the the doppler shift only shows the positive shift. I'm pretty sure that the shift normally should include both approaching and receding objects (plasma in this case).  So, a panel showing frames from 0 to 1.1 angstrom, I think should instead be showing -1.1 to 1.1 angstroms, centered around zero. And I imagine the sweep shouldn't go so far out into the wings as to reach the continuum - but that's a judgment call.
Things like filaments and other eruptions have both rising and falling areas, so I would expect a doppler animation to show both.
Fabulous work on this excellent project - I've been using it most of the day, after making scans this morning.
Steve

Hi Steve!
In fact this is not fully accurate: the animations show shifts from -1 to 1 A, but the panels only show from 0 to 1 (or -1 to 0 depending on where the maximum shift was detected). In addition, in animations there's interpolation between frames, where there's nothing for panels. The reason I've done this this way is that otherwise the panels were fairly large (twice their current size).
I can add an option to tell if you prefer to have the full range though.

Thanks for the additional detail Cédric. I think it would be nice to have a button allowing the full range to be a non-default option. It would be educational at least. I wouldn't call it a high priority, but would be nice to have.
Thanks for the work you have put into this.
Steve

This is shipped into 2.3.3, enjoy!

Thanks Cédric, I just downloaded it.
Cheers,
Steve

On May 27, 2024, at 12:02, Cédric Champeau @.***> wrote:
This is shipped into 2.3.3, enjoy!
—
Reply to this email directly, view it on GitHub https://github.com/melix/astro4j/issues/273#issuecomment-2133945218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4JHEEGL757VKX2L5KEXVDZEN7NZAVCNFSM6AAAAABIJIKPDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHE2DKMRRHA.
You are receiving this because you authored the thread.


Remove concrete inits from integer types

We should no longer need these with the protocol-based integer support we now have. Some small work may be needed to fix performance regressions, but that will come in a follow-on update.
I did have to keep the concrete init from Int around to keep the type checker from failing in some new cases; I hope we can remove that too in the future.
Fixes rdar://problem/33199966

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - ebfd97a456660354b13584616d8f7732a254ecaa

Build failed
Swift Test OS X Platform
Git Sha - ebfd97a456660354b13584616d8f7732a254ecaa

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - ebfd97a456660354b13584616d8f7732a254ecaa

Build failed
Swift Test OS X Platform
Git Sha - ebfd97a456660354b13584616d8f7732a254ecaa

@swift-ci please test

@swift-ci please benchmark

@swift-ci please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - 05ccbba8a4dc5a8ee33b9c3859b05cadd4e2acbe

Build failed
Swift Test Linux Platform
Git Sha - 05ccbba8a4dc5a8ee33b9c3859b05cadd4e2acbe

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

RandomDoubleLCG
2143
915
-57.3%
2.34x

IterateData
1707
1570
-8.0%
1.09x (?)

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

RandomValues.o
4631
4135
-10.7%
1.12x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

CStringLongAscii
3291
3548
+7.8%
0.93x

Improvement

RandomDoubleLCG
2586
971
-62.5%
2.66x

IterateData
1839
1642
-10.7%
1.12x (?)

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

RandomValues.o
4132
3620
-12.4%
1.14x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Improvement

RandomDoubleLCG
59073
50168
-15.1%
1.18x

ArrayOfPOD
846
758
-10.4%
1.12x (?)

How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB


[cleanup][broker] Remove duplicate code to improve delete subscription

Fixes #15324
Motivation
internalDeleteSubscriptionForcefully  and internalDeleteSubscription have duplicate code, and we should also avoid using synchronization methods like getTopicReference().
Modifications

Merge the duplicate code into internalDeleteSubscription()

Documentation

[x] no-need-doc
Just cleanup

/pulsarbot rerun-failure-checks

@nodece we can proceed this patch if you can rebase and resolve the conflict. What do you think?

@nodece we can proceed this patch if you can rebase and resolve the conflict. What do you think?

Done.


Team Meeting 14:30 4-3-2024

Agenda: 14:30 4-3-2024

Start (5 min)
Current status update (30 min)

Discussing the obstacles teammembers face and helping each other;

Future team goals and issue creation (15 min)

Main focus: Discussing ITO building blocks;

This meeting is completed. Tasks are divided between team members.


Prefix all classes with create-ui

Currently, some classes like dropdown-menu do not contain any vendor prefix. This means it overrides global styles (and such classes are used by bootstrap for instance).

@bergie I would love to spend sometime checking this out but I've no idea where to start. It's not clear just by the project structure where the HTML is generated. If you could give some directions It would be nice. I'm sure this bug is bugging (ah-ha) many people...


Watchtower server: how can I get pubkey of watchtower server?

Background
I want to set up watchtower server and its client.
I configured watchtower.active=1 in  lnd.conf and restarted lnd as document https://github.com/lightningnetwork/lnd/blob/master/docs/watchtower.md#configuring-a-watchtower.
But no way to get pubkey of watchtower server because lncli did not return the pubkey .
Your environment

version of lnd: 0.9.0-beta
which operating system (uname -a on *Nix): Ubuntu 16.04.6 LTS (GNU/Linux 4.4.0-139-generic x86_64)
version of btcd, bitcoind, or other backend : bitcoind v<IP_ADDRESS>, testnet3

Steps to reproduce

add watchtower.active=1 into  lnd.conf
restart lnd
$ lncli --network testnet tower info

Expected behaviour
lncli returns as follows.
{
        "pubkey": "03281d603b2c5e19b8893a484eb938d7377179a9ef1a6bca4c0bcbbfc291657b63",
        "listeners": [
                "[::]:9911"
        ],
        "uris": null,
}

Actual behaviour
$ lncli --network testnet tower info
No help topic for 'tower'

@takaya-imai the watchtowerrpc isn’t accessible by default in lnd or lncli. To do so, recompile with make install tags=“watchtowerrpc and restart lnd. The commands above look correct and should then work correctly

@cfromknecht solved. thanks!


indentation fix, minor updates #3967

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
[ ] In any other case, please file an Apache Individual Contributor License Agreement.

my guess is the reference to #987 is wrong in the PR should another ticket then #2237 be referenced here?


Doesn't do the AGDP patch for Black screen

Doesn't do the AGDP patch for Black screen

Hey,
I hate to link tonymac but, my buddy who made the 'fix' posted it on here: https://www.tonymacx86.com/threads/black-screen-with-macpro-6-1-or-imac-15-or-imac-17-system-definition.183113/
it's for when you use MacPro 6.1 SMBIOS and a few others. it causes a black screen.

its a rather simple patch. I think there are other ways to do it too. would be cool to see it added into this. one click install + patch if needed :)

Sorry, this is out of scope for this project. There are existing solutions and this project is only concerned with installing/running official nVidia drivers at this point.


grow and spread for OutputProgrammably

https://github.com/ddddddO/gtree/issues/237

Codecov Report
Patch coverage is 72.72% of modified lines.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed
Coverage

simple_tree_grow_spreader.go
70.00%

simple_tree.go
78.57%

:loudspeaker: Thoughts on this report? Let us know!.


Code mistake in ScheduleLocalNotification example block

UILocalNotification notification = new UILocalNotification();
NSDate.FromTimeIntervalSinceNow(15);

should be
UILocalNotification notification = new UILocalNotification();
notification.FireDate = NSDate.FromTimeIntervalSinceNow (15);

Else the notification does nothing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd0eb534-f7f4-e6c4-048f-d0712ebebe03
Version Independent ID: 8aa5d675-3d41-492f-23fe-c11fb4e7efcf
Content: Notifications in Xamarin.iOS - Xamarin
Content Source: docs/ios/platform/user-notifications/deprecated/local-notifications-in-ios.md
Product: xamarin
Technology: xamarin-ios
GitHub Login: @lobrien
Microsoft Alias: laobri

Fixed in linked PR


Legacy helm -> istioctl revisions migration path

This issue tracks work and docs needed for getting people off of the legacy helm install onto istioctl using revisions

Blocker: MCP does not respect revision label
Blocker: Old pilot holds leader election lock, blocking the root cert disrtibution.
Blocker: double metrics
TODO: add docs. As a blog post?

cc @nrjpoddar

FYI in order to make SDS work in 1.5 without third-party-jwt in the old Helm charts we had to do the following:

Add a new Helm option .global.jwtPolicy and set it by default to first-party-jwt
Add ENV variable JWT_POLICY in all sidecar and gateway proxies (including the ones added manually in control plane).
Guard the istio-token volume so that it's only enabled if jwtPolicy is third-party-jwts
Augment the sidecar injector template with changes for items 2 & 3 so that all workloads will be injected with the correct env and volume setting.

@nrjpoddar unless I am misunderstanding this, that is not related to this work right? This is for migrating from legacy helm charts to new helm charts. That should not require using SDS with the legacy helm charts?
Glad you got it working though

@nrjpoddar unless I am misunderstanding this, that is not related to this work right? This is for migrating from legacy helm charts to new helm charts. That should not require using SDS with the legacy helm charts?
Glad you got it working though

Correct! I just didn't have a good place to put this information. Feel free to delete the comment if it's confusing.

No sounds good, just wanted to verify I wasn't missing something. thanks

Hi @howardjohn - am I reading this correctly in concluding that currently there is no migration path for active production workloads (i.e without outage) from a Helm-managed installation to istioctl and this ticket is to track work to provide this supported migration path?
Currently we pipeline-automate all of our istio upgrades through multiple environments on different clusters via helm upgrade --wait so looking at how we can transition in an automated way.
I've been trying to find documentation of how to migrate or an overview of the current state, but haven't been able to find any, and the existing docs seem to imply that istioctl upgrade is only suitable if you installed that way in the first place. It's further complicated in my head by not fully understanding how the installation/upgrade tool is related to istiod, mixer-less telemetry and the consolidated control plane, and how best to make all these changes incrementally.
In any case, would the team recommend that users transition from 1.4.7 to 1.5.x using Helm to prepare us best for any supported migration path that will be instated with 1.6.x?

There is not yet a migration path for helm to istioctl, but it will certainly exist in 1.6,which is what this issue is tracking. You can go directly from 1.4 - 1.6 if desired once that is in place. Sorry about some of the confusion, as didn't do a great job around this

@howardjohn No need to apologise - you lot are doing some impressive work in a lot of different areas in parallel. Thanks for the clarification!
If there is no reason to hold off (e.g if the Helm 1.5 charts were in a slightly dodgy state due to their deprecation) I think we will try and get onto 1.5 via Helm for the better support for headless services and general philosophy of "change as little as possible as frequently as possible" for migrations.
I imagine migration from 1.5 to 1.6 will be more likely to be heavily tested from a control plane compatibility perspective so this seems a good compromise to reduce risk.

The upgrade path isn't too different for 1.4 for 1.5 for what it's worth due to https://preliminary.istio.io/blog/2020/multiple-control-planes/ which is how this will be handled. But always encouraged to update to the latest and greatest

Hi,
I'm trying to piece some thigns together from this issue and others and trying to make sure we don't end up unsupported. We're in a similar state to Chad above.
Currently we're on a 1.4 helm install.
As I understand it, we can't currently do a helm upgrade to 1.5.x as documented in this issue.
We could hold off until 1.6.x is released, at which point you will support users going from 1.4 to 1.6 without going via 1.5?
That would be a change to your current support statement, atleast for helm upgrades

Istio does NOT support skip level upgrades. Only upgrades from 1.4 to 1.5 are supported. If you are on an older version, please upgrade to 1.4 first.
Source
Can you confirm that that skipping 1.5 will be supported?

We could switch to helm template but that won't get us the istiod changes, instead leaving us on a Pilot based install. Source Is a pilot based 1.5 well tested/supported?

My understanding is that

helm upgrade to 1.5.x is still supported - the charts still exist and are updated (maybe there are some fixes/flexibility in deployment that is not being resolved in those however?)
helm install for new control plane instances is essentially deprecated
helm install + istioctl upgrade is currently unsupported/not working (which is what this ticket is about resolving). :-)

Apologies I think I mis spoke on helm upgrade to 1.5
AIUI that isn't supported -  https://github.com/istio/istio.io/pull/6725 removed the documentation for helm upgrade in part because https://github.com/istio/istio/issues/21648 showed that helm upgrade to 1.5 was broken

Our support policy is sort of irrelevant here, to some extent. We are adding support for multiple independent control planes, so you could move from Istio 1.1 to Istio 1.6 (in theory - don't actually try that though).
The recommended path would be to upgrade to 1.5 first then do the canary deployment to 1.6. However since apparently helm upgrade is broken by helms restrictions that may not work with tiller (although I think you can force it). If you use template you certainly can.

It seems you are right on support for helm upgrade @meganwalker-ibm ; thanks for the correction.
Frankly I'm a bit shocked by the removal of helm upgrade - it seems a bit anti-user; because unless I missed something it doesn't look like the decision was made based on user stats/usage patterns. Using helm template | kubectl apply isn't the same thing; when automating you have to construct your own kubectl commands coupled with the internal structure of the thing you're deployment (wait things to wait on, which rollouts to check status of, which jobs need to run...) to verify the state of every active deployed resource/component to validate; rather than what Helm gives you with --wait --cleanup-on-fail etc.
I see what I consider to be a bit of FUD in the PR about tiller security (irrelevant since tiller is gone in Helm 3, and client-side tiller is totally possible in Helm 2 via the helm-tiller plugin) but this looks a bit rash to me personally.
Later I will see if helm upgrade is indeed broken for us though.

Basic test of 1.5 legacy helm -> master is working now.
I tested 1.2 -> master as well. It sort of works, but the problem is the validating webhook. The EnvoyFilters for telemetry v2 are now invalid according to the 1.2 validation logic. To get around this you would need to disable telemetry v2 or disable validation on galley (--enable-validation=false and delete the webhook).

Verified the new "canary upgrade" from an Helm 3 installed version of 1.4.6 -> Helm 3 installed version of 1.6.alpha-46477282051c75b9005f64fe89e34d4bb99699ae. These were the issues found:

helm template --namespace istio-system istio-base ./manifests/charts/base/ --set revision=canary has many resources overlapping w/istio 1.4.6 install. Helm 3 will not install them and give out the following error:
Error: rendered manifests contain a resource that already exists. Unable to continue with install:   existing resource conflict: namespace: istio-system, name: istio-pilot-service-account,   existing_kind: /v1, Kind=ServiceAccount, new_kind: /v1, Kind=ServiceAccount

Another issue is that the 1.4.6 control plane rejects the telemetry v2 EnvoyFilter installed by 1.6 canary:
admission webhook "pilot.validation.istio.io" denied the request: configuration is invalid: Envoy   filter: unknown message type "udpa.type.v1.TypedStruct"

Deleting canary version ends up removing a lot of currently installed resources which makes the cluster unusable.

Possible solutions:

Move the ClusterRole/ClusterRoleBinding/ServiceAccount from "base" chart to components that need them e.g. "istio-control/istio-discovery" and add suffix based on "revision"
For old supported Istio releases (1.5, 1.4) add an option to disable EnvoyFilter webhook validation as old control planes don't honor rev labels and don't understand new EnvoyFilter schema/types.
Install multiple webhooks per revisions i.e. chain them so that new revisions validate the resources they know about along with old control plane versions
The "base" chart need to not install the old CRDs if revision is set. This is to allow Helm3 to install base chart for canary revisions.

CC @sdake for visibility.

I can help with the blog post.

Reading through this, it sounds like 1.4 -> 1.5 using helm template (not helm upgrade) should work, and then 1.5 -> 1.6 as a migration to istioctl would be next. However, I tried that first step today and had all kinds of connectivity issues (and of course no istiod).
I can wait on the blog post but wanted to call this out as something that should be made very clear for users when it's written.

Reading through this, it sounds like 1.4 -> 1.5 using helm template (not helm upgrade) should work, and then 1.5 -> 1.6 as a migration to istioctl would be next. However, I tried that first step today and had all kinds of connectivity issues (and of course no istiod).
I can wait on the blog post but wanted to call this out as something that should be made very clear for users when it's written.

@jaygorrell Helm support was dropped in 1.5 if you want to use the new charts (install/kubernetes/operator which gives you istiod). However, Helm works in 1.5 with the old chart (install/kubernetes/helm/) which doesn't give you istiod but the old microservices control plane. There are other subtle differences between the old and new charts so based on your use case one or the other might be better.

Thanks @nrjpoddar, I missed the new location for those. The old charts (install/kubernetes/helm) gave me a broken cluster, though -- sidecars stopped receiving config from pilot it seemed, and the ingress-gateway deployment failed to come up. I didn't spend much more time debugging before rolling back to 1.4 though.
But you'd say those really should work? I've been upgrading since 1.1 and this was the first issue like that. I'll try again if it's well tested and should work.

Regarding @nrjpoddar's comments:
It seems there are two usages for revisions:

Deploying two revisions of the same version.
Using a revision to upgrade between versions.

I expect that how we configure our install will be different based on which of those we plan for. (2) is likely much more common, so we should optimize for this case.
The base chart was meant as a way to separate cluster resources (installed by cluster admin) from others. This was mostly accomplished, except the mutating webhook. The intent was this was 1 per cluster, and not tied to a revision.
This has some issues, as Neeraj mentioned:

If a role changes, we have some issues. 1.x and 1.y may have incompatible requirements on what is required in the roles
Singleton validation webhook has issues. If I apply a "global" config (no istio.io/rev label), I would expect it to work for all existing revisions. If I apply a rev specific config, I only care that it works for that revision (and should NOT validate it against other revisions). This is a bit tricky because prior to 1.5 istio.io/rev label is not respected
Reusing the config names, breaking helm install
A bit hard to handle deletion. Not a huge blocker though as you can just delete the pilot chart, not others.

If we move ClusterRole/ClusterRoleBinding/ServiceAccount/Validation to the pilot component and suffix with revision, we mostly solve case (2). However, case (1) is made worse, as we don't have the privilege split, and we do multiple validation calls for no reason.

Regarding @nrjpoddar's comments:
It seems there are two usages for revisions:

Deploying two revisions of the same version.
Using a revision to upgrade between versions.

I expect that how we configure our install will be different based on which of those we plan for. (2) is likely much more common, so we should optimize for this case.

Agree about ensuring we make use case 2 work as it's the most asked feature. Making 1 work with requiring some more options/commands from users is not bad IMO.

The base chart was meant as a way to separate cluster resources (installed by cluster admin) from others. This was mostly accomplished, except the mutating webhook. The intent was this was 1 per cluster, and not tied to a revision.
This has some issues, as Neeraj mentioned:

If a role changes, we have some issues. 1.x and 1.y may have incompatible requirements on what is required in the roles
Singleton validation webhook has issues. If I apply a "global" config (no istio.io/rev label), I would expect it to work for all existing revisions. If I apply a rev specific config, I only care that it works for that revision (and should NOT validate it against other revisions). This is a bit tricky because prior to 1.5 istio.io/rev label is not respected
Reusing the config names, breaking helm install
A bit hard to handle deletion. Not a huge blocker though as you can just delete the pilot chart, not others.

If we move ClusterRole/ClusterRoleBinding/ServiceAccount/Validation to the pilot component and suffix with revision, we mostly solve case (2). However, case (1) is made worse, as we don't have the privilege split, and we do multiple validation calls for no reason.

Architecturally we shouldn't separate use case 1 & 2 as that indicates we haven't designed it well. Here are some fundamental ideas that should apply here:

If two revisions should have separate ownership for resources let's ensure we have that via labels/name suffixing/etc.
If we share "true" singletons (like CRDs) these are the options:

If the shared resources by two revisions are identical + new revision has new additions, then you can simply guard the shared resource install and declaratively make sure the new version only own additions.

If declarative guards become too complex, you can shield the shared resources by an imperative logic (like a job) which in turn will do the right thing based on cluster state.

If the shared resources by two revisions themselves change (e.g. OpenAPI specification for a CRD has changed), you need a more complex ownership pattern:

You probably need jobs which create/augment these resources and add label with a list of revisions that know about them. You can old delete/gc when the "list" of owners get empty.

@linsun also brought up another use case where they want just case+mutation webhook since they will have the Istiod in another cluster

subscribe - interested in this because I'm working on https://github.com/istio/istio/issues/23028 where i want to expose caBundle as a config option for remote cluster where istiod isn't enabled but i want my mutating webhook configuration to be there.

Also Helm3 has first class support for crds folder which may help some of the resource conflict errors (it will fail if the crd is in template/ but not crd/)

Another resource I need on remote cluster is istio-ca-root-cert configmap, which is currently configured in istio-discovery.

istio-ca-root-cert  is created at runtime so it is a bit orthogonal to the
install structure I think
On Tue, Apr 21, 2020 at 1:28 PM Lin Sun<EMAIL_ADDRESS>wrote:

Another resource I need on remote cluster is istio-ca-root-cert configmap,
which is currently configured in istio-discovery.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/22874#issuecomment-617397059, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIURJZHX2JBPC2VBS3RNX6W7ANCNFSM4MFVLUGQ
.

how do I mark this as a blocker for 1.6?

its already marked as a blocker through zenhub.

@howardjohn  Can you please provide ETA ?

@howardjohn  Can you please provide ETA since it's a release blocker ?

We have a PR: https://github.com/istio/istio/pull/23194 so blocked by review of this PR. its only 5 lines so Ill optimistically say today

@howardjohn can this be closed? 23194 looks like it's merged?

I think the last remaining step is a quick guide in te upgrade notes

This approach is apparently not supported on operator installs in 1.6: https://github.com/istio/istio/issues/23479

Upgrade notes in https://github.com/istio/istio.io/pull/7275/files
In cluster operator in https://github.com/istio/istio/issues/23479
So I think this is safe to close out for now. If anyone does experience issues during upgrade please open an issue and mention me. Thanks!

@howardjohn

The upgrade path isn't too different for 1.4 for 1.5 for what it's worth due to https://preliminary.istio.io/blog/2020/multiple-control-planes/ which is how this will be handled. But always encouraged to update to the latest and greatest

I'm looking at this page, and there's an iframe'd Google Sheets document that is asking for permission to access, and it's failing. I don't know if it's a Google Drive problem or what. Regardless, every time I want to access a "public" istio Google document, I need to ask for access. Couldn't these documents just be made publicly viewable for everyone without people asking for access?

@tmshort see https://github.com/istio/istio/issues/20282.

Thanks, but it doesn't help that I asking for access is failing for me now. I will comment there.


JAVA - Thing that sends a message to itself doesn't work in some case

thing Thing includes Message {
    provided port send {
        sends m1
    }

    required port receive {
        receives m1
    }

    statechart Statechart init Init {
        state Init {
            on entry send!m1()

            internal
            event receive?m1
            action print "OK"
        }
    }
}

This code doesn't work in JAVA, whereas in JS it works.
However, with the port configuration following :
  required port send {
        sends m1
    }

    provided port receive {
        receives m1
    }

I guess this bug is created by JASM library.

OK, I refactored the JASM library. I was not satisfied anyway with the way Connectors were made (it was too much logic going on whenever we wanted to change a message. Now everything is simplified. Ports can basically listens to other ports (on other Component/Thing, or on the same thing, it does not matter).


feat: Repository submission form - beta

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
The front-end for the "Repo submission feature" is done in this PR.
Event listener:
The event listener on this component is used for auto-closing/hiding the "repo submission-form" when the user clicks anywhere but outside the submission form.
How does it work?
It listens for the click event on all the components under the class "App" and checks if the clicked element is any part of the submission form with the class name "submission-form". And close/hide the "repo submission form" if it detects that the clicked element is not a part of the repo submission form.
This PR [adds/removes/fixes/replaces] the [feature/bug/etc].
Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@shamimbinnur, we need more of a description on these moving forward. This adding some new decisions to the app and the description addresses none of that. I will comment in places where more context is needed.

Floating repo submission form implemented.

Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@shamimbinnur, can you also address this by adding fixes #130

Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@shamimbinnur, can you also address this by adding fixes #130 to that section in the PR body.

@bdougie
Sorry for the inconvenience. It's added now.


I would like to copy & paste text from interface

However for some reason this is not supported.
For example I would like to copy & paste the Access Url in the below image.

As a workaround I removed the webkit-user-select: none style from body.

Seems like a simple feature request - You can usually capture these within the Settings > Ports tab

Is this still a feature request or is this issue resolved with PR #1201 ?

@ClemMakesApps Thanks for digging this up - I'll close the issue, as it was fixed by #1201 as you mentioned.
Thanks!


Pr fixes

Overview
Addresses comments left on
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/10568
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/10574
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/10561

/azp run

/azp run

/azp run