Bitmap fonts not working on Linux (neither in Chromium nor VScode)

This doesn't occur with just some font I tried, but any TTF or OTF font that uses pixel data instead of vector data. All other fonts load fine. All the TTF bitmap fonts load of course fine in other programs on Linux.
If you are looking for a bitmap font as an example, then you could use Gohufont.
The following is a comparison between vim + the famous "6x13" font, versus "Fira Mono Medium" which is possibly the clearest vector font you can find.

Note: If the letters are jammed together in some words in vim, that is because it is bold text and none of the text is bold in VScode.
I have skimmed through the issues and I read that other people reported that they could indeed load bitmap fonts in VScode (though some said they weren't displayed correctly but they were displayed). Maybe this is a Linux specific thing, maybe caused by different compile flags for electron?
It would be a shame because only bitmap fonts can provide crystal clear, pixel perfect text and vector fonts are always inferior.

Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:37:02.931Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.11.10-arch1-1
Steps to Reproduce:

Add "editor.fontFamily": "Any Bitmap Font Name Here" to settings.json
Doesn't work.

Does this issue occur when all extensions are disabled?: Yes

According to https://bugs.chromium.org/p/chromium/issues/detail?id=1239511#c7 Chromium rejects bitmap fonts wholesale no matter the format. Maybe we could file a bug report with Electron. I'm guessing the Chromium devs won't change their configuration but maybe it's something that Electron can patch?

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Virtual attributes?

Is waterline capable of handling virtual attributes?
E.g.
{
fullName: function() {
    return this.firstName + ' ' + this.lastName;
  }
}

That can be accessed without calling a function, and delivered to the client as the value rather than an instance method.

I would like to resurrect this feature request. Instance methods are nice but we lose them once we JSONfy the record. Ideally it would be great to have virtual attributes that could be exported to JSON.
@stevesims's suggestion in https://github.com/balderdashy/waterline/issues/201#issuecomment-30924443 looks good to me:
fullName: {
  type: 'virtual',
  set: function(val) {
    var name = val.split(' ');

    this.firstName = name[0];
    this.lastName = name[1];
  },
  get: function() {
    return this.firstName + ' ' + this.lastName;
  }
}

+1 and I think the suggestion here looks great.

Here's one way to do this currently: https://github.com/tjwebb/sails-auth/blob/master/api/models/User.js#L24-L36

@tjwebb, that's more or less the effect I would expect from a virtual attribute, I would just prefer a nice syntax! :)

Given the discussion in #990, a possibly desirable feature of a virtual attribute is for it to behave as transient in Java. This would mean that if a user tried to save a record with a virtual attribute, waterline would strip it before persisting it in the datastore. This would ensure that a virtual attribute would remain virtual.


Release 0.7 requires recompilation on every build

Dear all,
I just noticed that the recently published version 0.7 is rebuild by Cargo on every run, even though nothing has been modified.
To reproduce, create a new project and add mavlink to it:
$ cargo new --bin mavlink-test
$ cd mavlink-test
$ cargo add mavlink
$ cargo build

Then, just run the project twice without modifying anything in between:
$ cargo run && cargo run
   Compiling mavlink v0.7.0
   Compiling mavlink-test v0.1.0 (/Users/michaelp/Desktop/mavlink-test)
    Finished dev [unoptimized + debuginfo] target(s) in 17.18s
     Running `target/debug/mavlink-test`
Hello, world!
   Compiling mavlink v0.7.0
   Compiling mavlink-test v0.1.0 (/Users/michaelp/Desktop/mavlink-test)
    Finished dev [unoptimized + debuginfo] target(s) in 17.44s
     Running `target/debug/mavlink-test`
Hello, world!

Notice that both the mavlink crate as well as the application itself were compiled again.
For comparision, this is the output with version 0.6:
$ cargo run && cargo run
   Compiling mavlink-test v0.1.0 (/Users/michaelp/Desktop/mavlink-test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.25s
     Running `target/debug/mavlink-test`
Hello, world!
    Finished dev [unoptimized + debuginfo] target(s) in 0.05s
     Running `target/debug/mavlink-test`
Hello, world

I'm using this crate in a fairly large application where compile times are measured in minutes, so having to rebuild even though nothing has changed is pretty annoying as you can probably imagine :)
Thanks,
Michael

Hmm, I wonder if this is because we now checkout common.xml from mavlink submodule, rather than using a static copy of the file.
We should pin to a specific mavlink commit anyway, so git checkout ... would be better. I will see if pinning a specific commit makes this issue go away.

@michael-p this issue is currently fixed in master, and will be shortly published as version 0.8 on crates.io

@michael-p we just released 0.8 - I recommend updating your Cargo.toml as this will fix your issue.

Thank you Michal!


Make use of Zig's package manager

Requires https://github.com/limine-bootloader/limine-zig/pull/2.

Should we still clone https://github.com/limine-bootloader/limine-zig in kernel/GNUmakefile? Or is that taken care of by Zig's build system? I'm not sure how the new dependency system works yet.

Should we still clone https://github.com/limine-bootloader/limine-zig in kernel/GNUmakefile? Or is that taken care of by Zig's build system? I'm not sure how the new dependency system works yet.

Ah, that's automatically taken care of, I'll remove it.

I just tried this out locally - I don't like the fact that the package management depends on some hash. I'm not a fan of updating this repo every time we update https://github.com/limine-bootloader/limine-zig, but I'm unsure what the right solution is.

I think we should either start tagging https://github.com/limine-bootloader/limine-zig so we can have stable reference points for the package manager or use a commit hash and update build.zig.zon every time we make a major change.

I think we should either start tagging https://github.com/limine-bootloader/limine-zig so we can have stable reference points for the package manager or use a commit hash and update build.zig.zon every time we make a major change.

I'd use a commit hash but I can't predict what the commit hash is going to be when the PR is merged 😅
But maybe tagging limine-zig is a good idea as well

I set it up to download trunk, so if everything goes to plan, it should fail on the hash check if a newer archive is detected.

That's what I'm talking about, every time we update https://github.com/limine-bootloader/limine-zig we'll need to update the hash here also to ensure the build doesn't fail.

I'd use a commit hash but I can't predict what the commit hash is going to be when the PR is merged

It's a merge, so I believe the commit hash will be exactly the same as it is on your branch. Tagging is not a bad idea but I've never done it before so I'll have to read up on that 😅

That's what I'm talking about, every time we update https://github.com/limine-bootloader/limine-zig we'll need to update the hash here also to ensure the build doesn't fail.

Yeah, but my point is that the user should do it, it's not like it's very complicated.

It's a merge, so I believe the commit hash will be exactly the same as it is on your branch.

Hmm, I checked on a project I regularly contribute to and the commit hash on the PR vs the merged commit isn't the same...

We should use a commit hash for the Zig dependency - you can grab it after I merge limine-bootloader/limine-zig#2 😉 I think the user shouldn't have to update the hash manually to build the template.

Done!

I think the user shouldn't have to update the hash manually to build the template.

Yeah, but I don't think you can have the hash automatically.

I think it's enough if we update this when updating https://github.com/limine-bootloader/limine-zig. After all, it's not updated very frequently. Let's get this merged :^)

Thanks for both PRs! 😄


Enhance documentations

Changelog
Added
Changed

Refined documentation literature:

@Doom9527 Whenever we can say "we", we never use "you" in documentation. For example:

- You can access the API documentation at `doc.html` on your local server.
+ We can then access the API documentation at `doc.html` on our local server.

This is a little psychological tactic[^1] that makes our product more inclusive to all potential users. It also makes you more welcomed to others in daily life communications 😉

[^1]: What “you” and “we” say about me: How
small shifts in language reveal and empower
fundamental shifts in perspective
Deprecated
Removed

Deleted wrong CNAME file (@Doom9527 If you don't know or not sure about anything, ask rather than push blindly)

Fixed
Security
Checklist

[x] Test
[x] Self-review
[x] Documentation

OK, I have learned this usage.


Add system call instrumentation

Summary
This PR adds sched_note_syscall_enter/leave hooks for the system call instrumentation.
Syscall wrapper library is created for the hooks.
(Moved from PR #1271)
Impact
If CONFIG_SCHED_INSTRUMENTATION_SYSCALL is enabled, new library libwraps.a is built and additional linker options are passed to the final link process.
All syscalls are hooked by sched_note_syscall_enter/leave,
At this moment, only Arm and RISC-V can enable it.
Testing
Tested by spresense:nsh and maix-bit:nsh  by changing the following configurations.
CONFIG_DRIVER_NOTE=y
CONFIG_SCHED_INSTRUMENTATION=y
CONFIG_SCHED_INSTRUMENTATION_BUFFER=y
CONFIG_SCHED_INSTRUMENTATION_SYSCALL=y
CONFIG_SCHED_NOTE_GET=y
CONFIG_SYSTEM_NOTE=y
"note" command displays the system call information.

LGTM, @patacongo do you have any concern?

@YuuichiNakamura
Please fix the style violation.
../nuttx/tools/checkpatch.sh -g d24bd782a9a773480e9ecd4fe0340b5a143996fb..a2acd67e26b832116cb4e4d273696d696c6a54fd
##[warning]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/syscall/syscall_names.c:45:3: warning: #include outside of 'Included Files' section
##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/syscall/syscall_names.c:48:1: error: "Private/Public Functions" not found! File was not be checked
##[error]Process completed with exit code 1.

@xiaoxiang781216

@masayuki2009 it's hard to fix nxstyle warning due to the special design of syscall_lookup.h.

I've just checked the code and undestand it's hard to fix.


Sage Script for smoothed power laws with peaks

We have already implemented sage_n_pls_m_gs, which uses a truncated power-law without smoothing at the lower mass end. However, we also need this similar approach to build different models with any number of peaks (Gaussian) along with a power-law with smoothing.
This model is implemented in the LIGO population paper with the name power-law peak  (PP) model. We can call it sage_n_pls_m_gs_smoothed. In this way, we can still choose any combination of power-law and Gaussian.

[ ] Implementation of Smoothed PowerLaw Peak
[ ] Sage script

added in #374


Clearer error messages for ArgGroups

See #870.

If num groups > max(multiplicity) (whether the args are optional or required), it's currently:

Error: expected only one match but got (--group=<name> [--opt1=<opt>])={--group=foo --opt1=1} and (--group=<name> [--opt1=<opt>])={--opt1=1}

I like that this shows you the matched groups, but (1) it always says "expected only one match", even if the minimum multiplicity > 1, and (2) it seems unnecessary to repeat the group spec.
If num groups < min(multiplicity), it's currently:

Error: Group: (--group=<name> [--opt1=<opt>]) must be specified 2 times but was matched 1 times

For consistency, I think both cases should be something like:

Error:  (--group=<name> [--opt1=<opt>]) must be specified [X / at least X / at most X] time(s) but was matched 2 times: {--group=foo --opt1=1}, {--opt1=2}

This makes it clear how the groups are, well, grouped :)

If missing a required option for a group, it's currently:

Error: Missing required argument(s): --group=<name>

IMO something like

Error: --group=<name> is required in (--group=<name> [--opt1=<opt>]), got: {--opt1=1}

This clarifies that --group=<name> is only needed when specifying --opt1. This also applies for mutually dependent args:

Error: --req-arg1=<foo>, --req-arg2=<bar> are all required in (--req-arg1=<foo>, --req-arg2=<bar> [--opt1=<opt>]), got: {--req-arg1=foo}

Also highly relevant to #871 -- there are some questions raised there that may shape how the errors are printed / validation is done.

Please note the previous discussion on this topic (#744).


[SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

What changes were proposed in this pull request?
Since Issue SPARK-33139 has been done, and SQLConf.get and SparkSession.active are more reliable. We are trying to refine the existing code usage of passing SQLConf and SparkSession into sub-class of Rule[QueryPlan].
In this PR.

remove SQLConf from ctor-parameter of all sub-class of Rule[QueryPlan].
using SQLConf.get to replace the original SQLConf instance.
remove SparkSession from ctor-parameter of all sub-class of Rule[QueryPlan].
using SparkSession.active to replace the original SparkSession instance.

Why are the changes needed?
Code refine.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test

Test build #130031 has started for PR 30097 at commit 4792ebd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34637/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34637/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34637/
Test FAILed.

Test build #130031 has finished for PR 30097 at commit 4792ebd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 class RemoveAllHints extends Rule[LogicalPlan]
 class DisableHints extends RemoveAllHints

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130031/
Test FAILed.

Test build #130041 has started for PR 30097 at commit 90644da.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34648/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34648/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34648/
Test PASSed.

Test build #130041 has finished for PR 30097 at commit 90644da.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130041/
Test FAILed.

Test build #130073 has started for PR 30097 at commit c681752.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34682/

Test build #130073 has finished for PR 30097 at commit c681752.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130073/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34682/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34682/
Test PASSed.

Test build #130081 has started for PR 30097 at commit 76f9670.

Test build #130081 has finished for PR 30097 at commit 76f9670.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130081/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34690/

Test build #130084 has started for PR 30097 at commit 874f7f6.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34690/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34690/
Test PASSed.

Test build #130084 has finished for PR 30097 at commit 874f7f6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130084/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34693/

Test build #130088 has started for PR 30097 at commit 5872a20.

Test build #130089 has started for PR 30097 at commit a4822fd.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34693/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34693/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34697/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34697/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34697/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34698/

Test build #130088 has finished for PR 30097 at commit 5872a20.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130088/
Test FAILed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34698/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34698/
Test FAILed.

Test build #130094 has started for PR 30097 at commit 47526de.

Test build #130094 has finished for PR 30097 at commit 47526de.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130094/
Test FAILed.

Test build #130089 has finished for PR 30097 at commit a4822fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130089/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34703/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34703/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34703/
Test PASSed.

Test build #130097 has started for PR 30097 at commit 83c1577.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34706/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34706/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34706/
Test PASSed.

Test build #130097 has finished for PR 30097 at commit 83c1577.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130097/
Test FAILed.

Test build #130112 has started for PR 30097 at commit 6e521aa.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34721/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34721/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34721/
Test FAILed.

Test build #130112 has finished for PR 30097 at commit 6e521aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130112/
Test PASSed.

Test build #130232 has started for PR 30097 at commit c46be89.

Test build #130232 has finished for PR 30097 at commit c46be89.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130232/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34832/
Test FAILed.

Test build #130233 has started for PR 30097 at commit 7fc0716.

Test build #130233 has finished for PR 30097 at commit 7fc0716.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130233/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34833/

Test build #130234 has started for PR 30097 at commit 066a141.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34833/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34833/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34834/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34834/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34834/
Test PASSed.

Test build #130234 has finished for PR 30097 at commit 066a141.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130234/
Test PASSed.

Test build #130235 has started for PR 30097 at commit 2b263f3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34835/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34835/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34835/
Test FAILed.

Test build #130235 has finished for PR 30097 at commit 2b263f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130235/
Test PASSed.

@cloud-fan @maropu test passed, could you please have a look? thanks ^_^

Test build #130283 has started for PR 30097 at commit f4663d8.

Test build #130289 has started for PR 30097 at commit cd3329f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34885/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34885/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34885/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34890/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34890/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34890/
Test PASSed.

Test build #130283 has finished for PR 30097 at commit f4663d8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130283/
Test PASSed.

Test build #130289 has finished for PR 30097 at commit cd3329f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130289/
Test PASSed.

Test build #130311 has started for PR 30097 at commit f8e103b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34913/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34913/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34913/
Test PASSed.

Test build #130311 has finished for PR 30097 at commit f8e103b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130311/
Test FAILed.

retest this, please

Test build #130321 has started for PR 30097 at commit 7612695.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34923/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34923/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34923/
Test FAILed.

Test build #130321 has finished for PR 30097 at commit 7612695.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130321/
Test PASSed.

thanks, merging to master!


Dockerfile VOLUME inconsistent behavior

Hello,
According to https://docs.docker.com/reference/builder/#volume , when a volume is declared in a Dockerfile, the content of the endpoint prior to the volume declaration, should be part of the created volume. Now, apparently it works only when the volume is a docker volume and not a host volume.
Example:
FROM nodesource/trusty:0.12.7
RUN mkdir /mnt/vol
RUN echo "hello world" > /mnt/vol/file
VOLUME /mnt/vol

docker build -t "example_image" .

Host volume:
$ docker run --name "example_container" -d -v /home/user/new_folder:/mnt/vol example_image
$ ls /home/user/new_folder
# empty

Docker volume:
$ docker run --name "example_container" -d example_image
$ ls /var/lib/docker/volumes/volume_id/_data
file
$ cat /var/lib/docker/volumes/volume_id/_data
hello world

Is this a bug? if not any reference to docs will be appreciated.

Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Closing as dup of #13984


Search Nov 2024 Preview

PR addressing #42071

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-search-documents


[config:generate] Add an option to use MariaDB rather than MySQL

Actually this may be tricky as the required packages will differ depending on the guest operating system.

http://docs.drupalvm.com/en/latest/extras/mariadb


[documentation] Add Llama 7B Guide

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Automated Package Upgrade

:tada: This PR is included in version 5.0.291 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update 'Customization' section in README

Update Customization section in README
Ref: Discussion in #77
/cc @DirtyF

This seems like something that should be fixed with the way Jekyll handles themes.

This seems like something that should be fixed with the way Jekyll handles themes.

more specifically gem-based themes
/cc @parkr


Reproducible output

Right now, the XML output that's generated contains two different things that differ from invocation to invocation: the ID (due to the use of hash) and the timestamp.  I like to diff my XML against the previous version to verify the changes, and this adds a lot of diff noise.
It would be great if we could have a way to produce reproducible output.  I have a branch that replaces the invocation of hash with CRC32 and allows the user to set the SOURCE_DATE_EPOCH environment variable used in reproducible builds to get a fixed timestamp.
Assuming this is okay with you, I'd like to submit that branch, unless you're aware of a different way to go about it.

Sorry for the (very) delayed response! It is entirely my fault. This seems reasonable; feel free to send a pull request.
I'll admit that I don't use the XML workflow very often and I've even toyed with the idea of dropping support for it in 1.0 (to focus exclusively on managing filters via the API). It's helpful to know that someone out there still uses it.

I also use the XML workflow, so I can review the changes before anything gets applied. I would love to see this feature added too.

I don't think the ID value actually has any meaning to Gmail, so we can probably test out any other value. I don't think I ever actually needed to use hash, I just didn't want to use a constant out of caution.

I also use the XML workflow, so I can review the changes before anything gets applied. I would love to see this feature added too.

I'd love to hear more feedback on what makes XML output more useful than --dry-run --sync via the API. It will help me think about where to take this project next and where to invest development time.

In my case, I use it for diffing.  Also, I'm carrying a patch which doesn't sort the entries because I have entries which check for a missing label, so order is important, and that doesn't work with the automatic syncing code.

I'm very wary of anything having access to my email account. For me, if this tool had required API access I don't think I would have tried it in the first place.

That's a reasonable concern. For what it's worth, you store all your credentials locally and the application never requests more than the gmail.settings.basic and gmail.labels scopes. (Meaning the script can't read your email, set up new forwarding addresses, etc.) But I'm not planning to drop XML support right now.


feat:[PIPE-19142]: Add doc for support of expressions as part of allowed values in runtime input

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://667ce3ed0786a85c2566b8e1--harness-developer.netlify.app

This pull request has been automatically closed due to 30 days of inactivity. If you believe this was done in error, please feel free to reopen the PR or reach out to the BT team for further assistance. Thank you for your contributions!


Total games statistics from match score

Extract total games statistics from match score and make it available w/o match_stats.

Finished.


Remove config dirs from VOLUME

Per docker issue 3639 Dockerfile that constitute a base image should not
set config dirs w/ VOLUME as downstream Dockerfile can not modify w/ RUN
instructions.
https://github.com/docker/docker/issues/3639
Issue #8

On freenode IRC #gocd user gchristensen said the following about /var/go in the container:

perhaps, but the tricky thing is that the files in /var/go must remain over time, because it is the entire data store of gocd, so you're already attached to it ... build artifacts, logs, the database, everything

I don't know if that's necessarily true. Poking around at several long running containers, in once case a container that's been up six months, I don't see anything be written out to /var/go. Thoughts?

@holybit and @gchristensen: Hoping to finish conversations around this and move forward.
Having read the whole of https://github.com/docker/docker/issues/3639, https://github.com/docker/docker/pull/7133 and https://github.com/docker/docker/issues/8647, I'm not entirely sure that using VOLUME the way it is used is a bug. No one from the docker team seems to have come down with an opinion about it. The closest I found was this comment, which does not mention any rationale for it being that way.
However, whether it is a bug or a feature, there are problems when it is being used the way @holybit is trying to. My suggestion is that we have an -onbuild docker image, without any VOLUME instructions at all, and that can be used as a base image for any extensions. Then, the gocd-server and gocd-agent images use their corresponding -onbuild images and add the VOLUME instructions, so that they can be used by anyone, like this do today.
What do you think? That should help both use cases (a normal user's and that of someone looking to extend the base image).

The way I see it, the problem is really what's being put into /etc/go and /var/go - it's BOTH input and output:

input of keystore, config/starting point, ... <- I'd like this baked into the image (immutable/phoenix server concept)
output of updated config <- I'd like this in a VOLUME (the /etcparts)

If you could just separate these concerns (stable input vs "after system has booted config and workdir") - that'd clear things up for me and make it easier to use.

@FredrikWendt: I don't understand how the config and the keystore can be baked into a generic gocd/gocd-server image. These are changeable and will be changed both by a user possibly and by the server process itself. For instance, as an agent registers, the keystore and config might need to change.
I think a reasonable goal is to try and keep all changing and changeable content in a volume, so that a GoCD server image can be upgraded (15.3 to 16.2) without losing any data. Like a properly managed image is supposed to be.
The problem I see with doing that is that GoCD does not have a good concept of a data-only directory (is that what you meant by input and output)? The /var/go directory is lesser of a problem, since it is not used much, but /var/lib/go-server is a bigger problem. It has data (in db/h2db for instance), temporary files (in work/, plugins_work/, etc) and static files. Ideally, if it had the concept of a data directory, where all the data it manages is, then it would be nice. However, it doesn't, and I'm looking to see what we can do to work around it with what we have.
Is the goal I mentioned above reasonable, or am I missing anything?

The problem I had with keystore is to get the right X509 cert in there so that I could run the gocd server in a docker container and nothing else.
I understand there's valid use cases for pet servers with saving db and artifacts, and pet agents too. That's fine but my use case is primarily:

build a new gocd server image, start it up as fast possible - no history to care about
build a new gocd agent image, fire them up - no history to care about
run 'add-and-run-seed.sh' which adds the first pipeline which adds all other pipelines using API calls

Our agents has git, mercurial, bash and docker. They're wiped away, and new agents are started, every 24 hours. (A job runs on all agents, which starts a new agent using the latest gocd agent image, and then kills itself.)
For this scenario, the keystore should only contain TLS cert used for HTTPS. All key pairs for agents are added as agents register using the correct agentAutoRegisterKey.

@arvindsv I probably should have read all the PRs before submitting #42.
TLDR: I think I have the configuration items (including h2db) sanely exposed in a /config volume, and upgrades worked as planned.
@FredrikWendt where in a typical GoCD install does your X509 need to live?

@Tpbrown: No problem. As I said in #42, I'd make it the default and close a lot of these PRs and issues, and start over again. :)

Closing in favor of #42. That should allow this to be done in a good way?

@arvindsv I hope the new alpine based server will fix the issue. You did clean up the volume mounts - many thanks. I'll probably wait a few weeks before we test out the new alpine version until the issues shake out 😄

It was all @Tpbrown. I was just looking. :) Glad you think it's an improvement. I think so too. Let us know when you try it out.

@arvindsv @holybit the alpine server definitely does not fix this issue :-(
I believe we will need to resort to two images.  The standard 'use it as it is' that exposes volumes that should be mounted, and a 'base image' that does not expose volumes.

@Tpbrown The key question is what data is being created in either /etc/go or /var/go that warrant VOLUME persistence? Typical use cases for both /etc/ and /var/ do not warrant a VOLUME. That was the point of this PR.

@holybit  Agreed on /var/go, disagree on /etc/go -- you want configurations to persist across container lifecycles.
IMO (and I'm not part of the GoCD team so this is truly my opinion) you'd want config, artifacts, and logs to all be outside of the container lifecycle.    Everything else can be destroyed without losing data/metadata.

@arvindsv and @Tpbrown On the topic of /etc/go and configs in general the pattern I see most frequently in Docker Official Repositories (e.g., Httpd, MySQL, Redis, Postgres, etc.) is that default config(s) are provided in the image in a fixed location that can be overridden in several ways:

Volume mount custom config(s) to a /etc/server.d/ location w/ docker run -v ... or docker-compose
Add additional launch scripts w/ container run time Volume mount which an ENTRYPOINT script executes
Build new image FROM base image w/ custom config in place of default
etc.

The take away is that these Official Images are not concerned w/ how to persist custom config(s) - that's a devops task. Yes, the server should supply a default config and persist any data it creates. It's pretty clear if you read #21 that VOLUME mounting /etc/go is a bad idea as you can't customize any configs therein.

The way I see it, there is a bit of a difference in what configuration means in Postgres vs. GoCD. In Postgres, configuration includes files like postgres.conf and pg_hba.conf, which deal with the number of workers, the ports to listen to, authentication details (md5, password, etc).
In GoCD's case, /etc/go has really one major file that matters, and that is /etc/go/cruise-config.xml. This file is more data, than config, to me. It is user-controlled and defined. GoCD will provide a default (nearly empty) cruise-config.xml file, if it is not provided. If Postgres had a file with a list of all DB schemas, that would be the equivalent of the file here.
IMHO, I like to think of usage scenarios rather than whether VOLUME is the right thing or the wrong thing. Here are some scenarios I like:

You're using GoCD server in a docker container, with 16.5 and you want to upgrade to 16.6 and keep all your "data". That makes sense to me. For this to happen, /etc/go/cruise-config.xml cannot be destroyed during this upgrade. @Tpbrown's changes do allow this, without using VOLUME (but I would have been quite happy if it did, as long as it suited this use case).

Similar to use case 1, you want to move your GoCD server from one Docker host to another. This should be easy.

I want to use the GoCD server image, but I want to install extra software by default (this is where we start getting into the Dockerfile a bit).

I can't think of any other case at this point. I felt that @Tpbrown's changes allowed for all three. I am not agreeing with either one of you in this discussion. :) I just wanted to say that making it easy for people to use the image in different ways is IMO better than trying to understand how docker expects VOLUME to be used.

Maybe I slid too much to the pragmatism side. I don't know.

Also, @Tpbrown's current Dockerfile doesn't expose either /var/go or /etc/go directly. It symlinks to them.


Issue from website page Developing Packages

Steps to Reproduce
Please tell us what you were doing and what went wrong. If you are running flutter tools from the command line, please try adding the -v or --verbose option to gather more information.
If the problem is with your application's rendering, please attach a screenshot and any relevant source code.
If you are getting an exception in the logs, and your code is implicated in the first few frames, then please include the source code for the functions involved.
Logs
Run your application with flutter run and attach all the log output.
Run flutter analyze and attach any output of that command also.
Flutter Doctor
Paste the output of running flutter doctor here.

For more information about diagnosing and reporting Flutter bugs, please see https://flutter.io/bug-reports/.

@lbrawnbrawny it looks like this bug was filed with just the default bug template. Would you mind updating the description with the details of the issue?


New package: PostgreSQL.psqlODBC version 17.00.0002

Microsoft Reviewers: Open in CodeFlow

Verify:

This package doesn't seem to add any executables to the file system.


Add Form::Collection(CheckBoxes|RadioButtons)Component + helpers

Related to #4

Maybe we should do it without block first.
The block is not just about content. It give access to an object: https://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.html#method-i-collection_check_boxes.


Add extend

extend
Returns a copy of object, extended by extension.
const extend = require('1-liners/extend');

const object = {id: 1};

extend({ name: 'stoeffel' } object);  // => { id: 1, name: 'stoeffel' }

Spec
	•
	Source:  (extension, object) => Object.assign({}, object, extension);

A companion to put.
:checkered_flag: should I merge and release?

Now :checkered_flag: for good :)

100th issue BTW :D
:birthday:
:tada:

Yeah #100 :cake:
Yop merge and release.

:ok_hand:  Released as 0.2.10

nice :fireworks: good night.

Good night :)


Better Table organisation

SQL Operations Studio Version: 0.30.6

Steps to Reproduce: Open an SQL Database and look at the tables.
In order to organise and understand the structure of my tables, I put them in different schemas. It would be useful that instead of seeing schema.table name, the schema could be a subfolder under the table folder if it's not dbo.

Thanks for this feedback. We're tracking this request in #7. It does require some redesigns to the code to allow this kind of flexibility, so while it's in our long-term plans it's not on our immediate roadmap. Please track #7 to see the progress of this request - I'll close this issue as a duplicate.


update tsconfig file with target es2021

Signed-off-by: shirady<EMAIL_ADDRESS>Explain the changes

change target to es2021

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

[ ] Doc added/updated
[ ] Tests added

I changed the target to es2021 because I wanted to use the replaceAll function (which is a feature in es2021).
Before this change, I had this error (using Visual Studio as an IDE) :
[{
...
	"owner": "typescript",
	"code": "2550",
	"severity": 8,
	"message": "Property 'replaceAll' does not exist on type 'string'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2021' or later.",
	"source": "ts",
...
}]

I decided to change it to es2021 and not to es2022 because es2021 is fully supported by node 16, while es2022 is not yet. see here.

nice @shirady !
so far we had to use replace with /regexp/g in order to replace all, which is both an overkill and error-prone for replace all of an exact string...
also the logical-assignments operators are a nice addition so we can use to do async initializations, like for example -
let nvmrc = '';

exports.get_nvmrc = async () => {
    nvmrc ||= await fs.readFile('.nvmrc', 'utf8');
    return nvmrc.replaceAll('.', '_');
};


Fix #348: return err as nil when replying with DROP status

Change returned values in GRPC server's OnTopicEvent as followed to keep consistency with the Pub/sub API reference.

err
Status in response
Expected Action

nil
SUCCESS
Ack successfully

nil
DROP
Drop

other errors
RETRY
Retry later

See also #348

@longshine please fix CI.

@daixiang0 Hi, I've merged the latest main branch and CI issues should be resolved.

Thaks for your contribution


Not Related to this lib

Hi
I was using your lib GCDWebserver using SPM but I think you have deleted it ?
Could you pl share the lib so I can continue using it or anyother way to use this
Thanks

Hi @PrashantKT I just forked GCDWebServer to make it a Swift Package (if memory serves me right). It's quite simple to do so yourself if you'd like. Here are docs on how to fork a repository (in this case the original GCDWebServer). Then you can clone the repo locally and make a Swift Package. There's documentation on that step here.


Fix/dots categorisation

This PR addresses some issues on GHG emissions chart:

Changes svg quantifications dots ordering to avoid z-index problem with it's labels.
test it here: http://localhost:3000/countries/TUR
Adds functionality to make null quantifications values to behave as range values (that is to be represented as a line instead of as a dot) .
test it here: http://localhost:3000/countries/ECU
Changed yellow shade used on quantified targets to be the same as the base theme yellow ($theme-secondary) .
This last change follows a suggestion that could be checked in the last comment of this basecamp thread

@Bluesmile82 the PR is now ready to review after the reimport, thanks!


Changed .search() to properly parse the new Pitchfork page format

Some tests still arent passing, and I'm not sure if multireviews are being created properly due to changes in page formatting screwing up the BeautifulSoup parsing. Here are the tests currently failing:
======================================================================
ERROR: test_multi_review_label (main.TestMultiReview)
Traceback (most recent call last):
File "tests/test_pitchfork.py", line 52, in test_multi_review_label
self.assertEqual(self.multi_review.label(), 'Capitol')
File "/home/jon/projects/pitchfork/pitchfork/pitchfork.py", line 90, in label
label = self.soup.find(class_='info').h3.get_text()
AttributeError: 'NoneType' object has no attribute 'h3'
======================================================================
ERROR: test_multi_review_year (main.TestMultiReview)
Traceback (most recent call last):
File "tests/test_pitchfork.py", line 55, in test_multi_review_year
self.assertEqual(self.multi_review.year(), '2009')
File "/home/jon/projects/pitchfork/pitchfork/pitchfork.py", line 100, in year
year = self.soup.find(class_='info').h3.get_text()
AttributeError: 'NoneType' object has no attribute 'h3'
======================================================================
ERROR: test_review_label (main.TestReview)
Traceback (most recent call last):
File "tests/test_pitchfork.py", line 22, in test_review_label
self.assertEqual(self.review.label(), 'Chemikal Underground')
File "/home/jon/projects/pitchfork/pitchfork/pitchfork.py", line 90, in label
label = self.soup.find(class_='info').h3.get_text()
AttributeError: 'NoneType' object has no attribute 'h3'
======================================================================
ERROR: test_review_year (main.TestReview)
Traceback (most recent call last):
File "tests/test_pitchfork.py", line 25, in test_review_year
self.assertEqual(self.review.year(), '1999/2014')
File "/home/jon/projects/pitchfork/pitchfork/pitchfork.py", line 100, in year
year = self.soup.find(class_='info').h3.get_text()
AttributeError: 'NoneType' object has no attribute 'h3'
======================================================================
FAIL: test_multi_review (main.TestMultiReview)
Traceback (most recent call last):
File "tests/test_pitchfork.py", line 43, in test_multi_review
self.assertIsInstance(self.multi_review, MultiReview)
AssertionError: Review('radiohead', 'ok computer', 'Radiohead', "Pablo Honey: Collector's Edition / The Bends: Collector's Edition / OK Computer: Collector's Edition", 'radiohead%20ok%20computer', '/reviews/albums/12938-pablo-honey-collectors-edition-the-bends-collectors-edition-ok-computer-collectors-edition/', "<class 'bs4.BeautifulSoup'>") is not an instance of <class 'pitchfork.pitchfork.MultiReview'>
======================================================================
FAIL: test_multi_review_album (main.TestMultiReview)
Traceback (most recent call last):
File "tests/test_pitchfork.py", line 46, in test_multi_review_album
self.assertEqual(self.multi_review.album(), "OK Computer: Collector's Edition")
AssertionError: "Pablo Honey: Collector's Edition / The Be[55 chars]tion" != "OK Computer: Collector's Edition"

Pablo Honey: Collector's Edition / The Bends: Collector's Edition / OK Computer: Collector's Edition

OK Computer: Collector's Edition

Ran 14 tests in 3.900s
FAILED (failures=2, errors=4)
Still, this is better than the current not-working-at-all state

Hey, thanks for the pull request!
I didn't want to merge it with the existing errors of course, so pushed additional changes to your PR branch.
It looks like the MultiReviews are not necessary anymore because each review has a uniform format of a "single" review now. For this reason, I removed the tests for MultiReviews.
The frontend of pitchfork.com switched to react and they renamed a lot of their CSS classes, so i made changes accordingly as well.

https://github.com/michalczaplinski/pitchfork/pull/5


Widget can't be destroyed

We are using bdp in a SPA, and need to destroy the whole widget (including both dom and events) when the outer component is destroyed. Unfortunately I don't find such a method. Is it possible to add one? Thanks!

hey @shijistar ,
thank you for the suggestion. I added destroy() method to new version 2.1.3


⚠ Bofrost.be has degraded performance

In d930d4b, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1620 ms

Resolved: Bofrost.be performance has improved in 4452bba after 6 minutes.


Release notes and doc update for v0.5.0.

@r-clancy I'll wait for additional sanity checks, and then I'm merge...


ActivityIndicator element typ is invalid

Hey there and thank you for using React Native!
React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.
Do the checklist before filing an issue:

[ ] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.
[ ] Have a usage question? Ask your question on StackOverflow. We use StackOverflow for usage question and GitHub for bugs.
[ ] Have an idea for a feature? Post the feature request on Product Pains. It has a voting system to surface the important issues. GitHub issues should only be used for bugs.

None of the above, create a bug report
Make sure to add all the information needed to understand the bug so that someone can help. If the info is missing we'll add the 'Needs more information' label and close the issue until there is enough information.

[ ] Provide a minimal code snippet / rnplay example that reproduces the bug.
[ ] Provide screenshots where appropriate
[ ] What's the version of React Native you're using?
[ ] Does this occur on iOS, Android or both?
[ ] Are you using Mac, Linux or Windows?

Please provide a description of your issue along with code sample to reproduce the issue.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/activityindicator-element-typ-is-invalid
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Workspace: scope flex layout presentational styles to the flex layout examples

These styles https://github.com/patternfly/patternfly-next/blob/6744b3a6c5142d3faabae39e355b9850cc265d2e/src/patternfly/layouts/Flex/examples/Flex.css#L1-L2
Resulting in bleeding styles into other examples

:tada: This issue has been resolved in version 2.68.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Prevent peer from failure on malformed proposal

Bug fix

While the new peer gateway service tries to extract channel and chaincode information from the signed proposal, it doesn't check the proposal fields for validity. Therefore malformed proposal might end up crashing peer service. This commit adds validation to the parameters extracted from the proposal.

@denyeart fyi

@C0rWin There is a similar PR already being discussed here:
https://github.com/hyperledger/fabric/pull/3525
It has a few more checks in general, but yours has a few more checks later in apiutils.go. Perhaps we should add those to Andy's PR...

@C0rWin There is a similar PR already being discussed here: #3525
It has a few more checks in general, but yours has a few more checks later in apiutils.go. Perhaps we should add those to Andy's PR...

Yes, since these, I think the object of the discussion. Anyway, I will close that one.

I have noted a few checks that are still missing, based on @denyeart suggestion, rebased, and therefore reopening.


Handling negative timestamps

It seems like perfetto can't handle negative timestamps like catapult. Is this a design choice? Many systems use unsigned timestamps but is negative timestamp invalid? I did not see any constraints about negative timestamps in chrome trace format docs, so is this a bug?

We don't support negative timestamps in trace_processor tables (and hence in the UI) and I think this is unlikely to change.
We might be able to parse negative timestamps at import time (and convert/offset them to be positive). We have a bunch of fancy logic for handling events from multiple clocks already. For example if some of your events are timestamped in ns since the machine booted and other events are timestamped in ms since the unix epoch at parse time we normalize all of the events to the same clock. However I don't know that anyone has tried this with negative timestamped events and I'm not sure it's feasible to make this work with the json parser.
Does this come up in viztracer? I'd be interested to know where the negative timestamps stem from.

Well, it came from a bug that I found in VizTracer that the timestamp overflowed to signed bit in computation on Windows. This is undefined behavior I know, and I fixed the bug in the latest release. However, I realized that this bug has been there for months and I did not catch it, because catapult handled it well(and the compiler handled the UB well). It's not a deal breaker feature, but I don't think the feature will harm anyone. Even though I can understand if this is a design choice.
However, if this is design choice, I would expect a better error message. For now I think it reports "slice out of order" error, which was not helpful at all. It should report "negative timestamp not supported" instead.

Emitting a TraceProcessor::stat of type=error (which then becomes a warning in the UI) sounds a good plan.
It's not a priority though, so either send a patch or this will wait for a while.

It's not a priority for me either as I already fixed the bug in VizTracer. I'm ok if this does not happen for a while.

Hopefully fixed!


Set tenant info inside hangfire job

Hi,
I'm using hangfire for some recuring background tasks. Inside of this task I need to implement logic for a specific tenant.
Problem is that hangfire has not HttpContext. I read here that it should be possible use IMultiTenantContextAccessor by injecting into the task.
Is it possible set tenant manually by something like "TrySetTenantInfo".
Problem is also that when injectiong "IMultiTenantContextAccessor" the "MultiTenantContext" is null.
Best regards
Jan

I found this to be done:
 _scope.ServiceProvider.GetRequiredService<IMultiTenantContextAccessor>()
                    .MultiTenantContext = new MultiTenantContext<Multitenancy.Tenant>
                    {
                        TenantInfo = tenantInfo
                    };

Hi! Sorry for my slow response— you figured it out without my help though. Your solution looks good and is what I would recommend.


Add workaround for compiler type checks on iframe window

Fixes https://github.com/dart-lang/dart-pad/issues/2765
Fixes https://github.com/dart-lang/dart-pad/issues/2766
Staged: https://parlough-testing-skwasm.web.app/
Ignore the subdomain, it's built with flutter build web (dart2js)

I did open https://github.com/dart-lang/sdk/issues/54443 as a place to discuss if it makes sense for the compilers or package:web to have something special for this.


RenderStateNotation: Changed API for RenderStateNotationLoader

Merged in https://github.com/DiligentGraphics/DiligentTools/commit/63856f4158b25afecb8b9adaf9e87e9e2b779447


[NIFI-3876] trim whitespace processor names before applying ellipsis

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

Working as expected, no more issue on the UI when using a blank name. Will merge, thanks @scottyaslan


resource deployment ext implementation -wip

Do you have a design doc for this? We've discussed it in a couple of meetings before but it might be a good idea to do a full on design review before getting too far into the implementation.

Do you have a design doc for this? We've discussed it in a couple of meetings before but it might be a good idea to do a full on design review before getting too far into the implementation.

Dinakar will schedule one early next week.


feat: add host-side bucket accumulation function (PROOF-642)

Rationale for this change
Add a function to accumulate the generators for a multi-exponentiation into buckets. The function is invoked from the host and splits work across available GPUs.
This PR  builds on  #45 and is part of making multi-exponentiation perform better.
What changes are included in this PR?
A  new function for bucket accumulation.
Are these changes tested?
Yes.

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How do I know...

...when to use the Mutex and when to use the Semaphore?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51e078fd-3a63-8b58-49f8-67e49df9bc9f
Version Independent ID: f082f7b2-e1a3-aa31-1081-5ca11c954d80
Content: Semaphore and SemaphoreSlim
Content Source: docs/standard/threading/semaphore-and-semaphoreslim.md
Product: dotnet
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Are they both kernel objects?

@tcjohnson71 the following section might help you with your first question:
https://docs.microsoft.com/en-us/dotnet/standard/threading/overview-of-synchronization-primitives#synchronization-of-access-to-a-shared-resource

Thanks for submitting your question, @tcjohnson71, and thanks for your response, @pkulikov. I think that the article indicated by @pkulikov discusses the difference between a mutex and a semaphore sufficiently. Both are kernel objects, though both have to be assigned names to be used in cross-process operations. The lightweight, non-kernel equivalent to Semaphore is SemaphoreSlim.
Since I think that this answers your question, I'll close this issue. If you disagree, please feel free to respond.


element.getBoundClientRect() support

element.getBoundClientRect() support

This issue was imported from Google Moderator
Moderator votes: +3
Issue added by phoover on 2015-03-03
To vote this issue up or down, simply include +1 or -1 in your comment.

Duplicate of #991


fix: Minor bug in writing test_sentence.csv

Fix for python 3:
Traceback (most recent call last):
  File "examples/score_texts_emojis.py", line 71, in <module>
    'Pct_1', 'Pct_2', 'Pct_3', 'Pct_4', 'Pct_5'])
TypeError: a bytes-like object is required, not 'str'

And fix for python 2:
Traceback (most recent call last):
  File "examples/score_texts_emojis.py", line 68, in <module>
    writer = csv.writer(csvfile, delimiter=',', lineterminator='\n')
TypeError: "delimiter" must be string, not unicode

Thanks @hiepph !


Cascader Support Filter

What problem does this feature solve?
Cascader Component Support Filter Function

Screenshots from http://element.eleme.io/#/zh-CN/component/cascader
What does the proposed API look like?
<nz-cascader
      [(ngModel)]="values"
      [nzOptions]="nzOptions"
      [nzFilterable]="true"
      (ngModelChange)="onChanges($event)">
    </nz-cascader>

@simplejason Recently I implemented a similar feature on nz-tree. I can take it over if you are not working on this.


Shadowsocksr load error.

I change subscribe url, and require node info, then show me:
/usr/lib/lua/luci/dispatcher.lua:381: Failed to execute function dispatcher target for entry '/admin/services/shadowsocksr'.
The called action terminated with an exception:
/usr/lib/lua/luci/dispatcher.lua:381: Failed to execute cbi dispatcher target for entry '/admin/services/shadowsocksr/client'.
The called action terminated with an exception:
/usr/lib/lua/luci/model/cbi/shadowsocksr/client.lua:18: bad argument #1 to 'upper' (string expected, got nil)
stack traceback:
	[C]: in function 'assert'
	/usr/lib/lua/luci/dispatcher.lua:381: in function 'dispatch'
	/usr/lib/lua/luci/dispatcher.lua:95: in function </usr/lib/lua/luci/dispatcher.lua:94>

shadowsocksr is not hosted in this repo.


Firestore runTransaction transaction.get does not work

I am using the scenario for running a transaction from the example:
final DocumentReference postRef = Firestore.instance.document('posts/123');
Firestore.instance.runTransaction((Transaction tx) async {
  DocumentSnapshot postSnapshot = await tx.get(postRef);
  if (postSnapshot.exists) {
    await tx.update(postRef, <String, dynamic>{'likesCount': postSnapshot.data['likesCount'] + 1});
  }
});

It worked for me before, but not now, apparently:
DocumentSnapshot postSnapshot = await tx.get(postRef);

This instantly fails with a PlatformException , its message: Timed out waiting for task.

Flutter version: 0.5.4
cloud_firestore:  0.7.3

Stacktrace from Logcat on Android:
E/MethodChannel#plugins.flutter.io/cloud_firestore: Failed to handle method call result
    java.lang.IllegalStateException: Task is already complete
        at com.google.android.gms.common.internal.Preconditions.checkState(Unknown Source:9)
        at com.google.android.gms.tasks.zzu.zzdr(Unknown Source:6)
        at com.google.android.gms.tasks.zzu.setResult(Unknown Source:3)
        at com.google.android.gms.tasks.TaskCompletionSource.setResult(Unknown Source:2)
        at io.flutter.plugins.firebase.cloudfirestore.CloudFirestorePlugin$3$1.success(CloudFirestorePlugin.java:283)
        at io.flutter.plugin.common.MethodChannel$IncomingResultHandler.reply(MethodChannel.java:169)
        at io.flutter.view.FlutterNativeView.handlePlatformMessageResponse(FlutterNativeView.java:187)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:326)
        at android.os.Looper.loop(Looper.java:160)
        at android.app.ActivityThread.main(ActivityThread.java:6642)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

I just noticed that there are actually two different exceptions occuring. One is Timed out waiting for task and the other one is Task is already complete. I already mentioned both of them, but also found another question on StackOverflow having this problem.

I have a similar issue with it showing Failed to handle method call result and java.lang.IllegalStateException: Task is already complete. It also prints out the snapshot twice.

I am having same issue and i am about to run mad especially since it was working before i added a composite index to my collection.

same issue

Did you get it fixed? I had this issue one time but somehow it fixed itself without me doing anything.

Same issue here

I have decided to move the transaction activity to a firebase cloud function. Guess thats the only way for now.

Just finished writing it, tested with postman and its fine. Guess i will just start using firebase cloud functions instead of getting headaches from the flutter firestore plugin.

Hey! 👋 For the 'Task is already complete' exception, see my other comment: #17663 (comment).
Again, as I noted there, this may not be the case for you, so YMMV, but it may help others in a similar situation. 😅

This looks to be Android specific.
It seems likely that the "Task is already complete" error and printing the snapshot twice might be fixed by flutter/plugins#1202
Is the "Timed out waiting for task" happening always, or only under certain circumstances? Based on @iamjavademon's comment about composite indices, it seems like there might be errors that are causing the timeout.

...
RaisedButton(
                    onPressed: () async {
                      _formKey.currentState.save();

                      await Firestore.instance
                          .runTransaction((Transaction trans) async {
                        final docRef = Firestore.instance
                            .document('products/' + widget.product.key);
                        await trans.get(docRef);

                        print('Saving ' + widget.product.key + ' Name: ' + name);
                        // Artificial slowness
                        await Future.delayed(Duration(seconds: 2));

                        return trans.update(docRef, {'name': name});
                      });
                    },

I should add that the above freeze happens in 0.9.5+2

This looks to be Android specific.
It seems likely that the "Task is already complete" error and printing the snapshot twice might be fixed by flutter/plugins#1202
Is the "Timed out waiting for task" happening always, or only under certain circumstances? Based on @iamjavademon's comment about composite indices, it seems like there might be errors that are causing the timeout.

The "Timed out waiting for task" error happens when a document is open on two different devices after which the first one saves his update. Then after the other device tries to save his updates, he will get this error: "Error performing transaction, Timed out waiting for Task".

So we've tested transactions using various approaches. One was basically just hooking a button up to incrementing a counter, like in the official Flutter youtube video about Firestore support (www.youtube.com/watch?v=DqJ_KjFzL9I), and it's not looking good.
Here's the transaction we're running when you click a button. The idea here is to click the button multiple times, rapidly, in order to simulate race conditions:
final docRef = Firestore.instance.document('somewhere/' + widget.doc.key);
Firestore.instance.runTransaction((Transaction tx) async {
  DocumentSnapshot postSnapshot = await tx.get(docRef);
  final newVal = 1 + postSnapshot['counter'];
  print('NEWVAL ' + newVal.toString());
  await tx.update(postSnapshot.reference, {
     'counter': newVal,
   });
});

Clicking the button 5 times, rapidly, and then checking the affected document in Firestore we'd expect the counter to show 5, but it generally showed 2 or 3.
We've worked with transactions before, both in Cloud Functions and in the WebSDK, so I'm pretty confident we're doing it correctly. We can only conclude that transactions ARE NOT production ready, unlike what the youtube video seemed to indicate.
It's really a shame, because the rest seem to work really well, and Flutter in general is basically a godsend.
Ps. I can't help but notice there's a lot of open issues tied to transactions, some of which are getting old. Is anything being done about them?

Hi, Can you reproduce the issue using the latest cloud_firestore (0.9.5+2) plugin?

I think I found a workaround for this (which worked for me)
For every document reference read in the transaction, you must also perform update to that specific document reference (even though no change to the data)
Following code works successfully using cloud_firestore 0.8.2+3
db.runTransaction((Transaction tx) async {
    var courseDoc = await tx.get(courseRef);       // read courseRef
    await tx.update(courseRef, courseDoc.data);    // extra update to courseRef
    await tx.set(chatRef, chat);                   // actual intended operation
}

My transaction code has been running fine for months and suddenly the transactions are simply not running. No exceptions no logcat output no nothing. Just never returns or invokes the callback. Seems like its stuck waiting. There are no other firestore operations occurring at the same time so its not blocked as far as I can tell.
This was working fine for months then it suddenly stopped.
      Future<void> transactionUpdate(String path, Map<String, dynamic> json) async {
        DocumentReference doc = firestore.document(path);
        firestore.runTransaction((Transaction tx) async {
          DocumentSnapshot snapshot = await tx.get(doc);
          if (snapshot.exists) {
            await tx.update(doc, json);
          } else {
            await tx.set(doc, json);
          }
        });
      }

I am using cloud_firestore: 0.12.0
    [√] Flutter (Channel master, v1.6.6-pre.15, on Microsoft Windows [Version 10.0.17134.765], locale en-US)
        • Flutter version 1.6.6-pre.15 at C:\dev\libraries\flutter2\flutter
        • Framework revision 8139a368ea (7 hours ago), 2019-05-29 10:08:58 -0700
        • Engine revision 8dc3a4cde2
        • Dart version 2.3.2 (build 2.3.2-dev.0.0 e3edfd36b2)

    [√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
        • Android SDK at C:\dev\libraries\android-sdk
        • Android NDK location not configured (optional; useful for native profiling support)
        • Platform android-28, build-tools 28.0.3
        • ANDROID_HOME = C:\dev\libraries\android-sdk
        • Java binary at: C:\dev\tools\android-studio-ide-171.4402976-windows\android-studio\jre\bin\java
        • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
        • All Android licenses accepted.

    [√] Android Studio (version 3.4)
        • Android Studio at C:\dev\tools\android-studio-ide-171.4402976-windows\android-studio
        • Flutter plugin version 35.3.1
        • Dart plugin version 183.6270
        • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

I'm having the same problem as @RussellZornes. I'm on using cloud_firestore: 0.12.1. The code in a transaction is not being executed. It works fine if you put it outside a transaction. The app is not stuck and works fine. Just the transaction is not working. There are no other operations going on because only I have the app. I am working with Intellij, not Android Studio.
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.6.4-pre.5, on Linux, locale en_IN.utf8)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Android Studio (version 3.2)
[✓] Android Studio (version 3.2)
[!] Android Studio (version 3.1)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    ✗ Unable to find bundled Java version.
[✓] IntelliJ IDEA Community Edition (version 2018.1)
[✓] IntelliJ IDEA Community Edition (version 2019.1)
[!] IntelliJ IDEA Ultimate Edition (version 2017.3)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] Connected device (1 available)

! Doctor found issues in 2 categories.

Same here with cloud_firestore 0.10.1. A transaction that consistently worked suddenly won't go into the runTransaction handler:

[√] Flutter (Channel beta, v1.6.3, on Microsoft Windows [Version 10.0.17763.503], locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-> setup for detailed instructions.
[√] Android Studio (version 3.3)
[√] VS Code (version 1.34.0)
[√] Connected device (1 available)
! Doctor found issues in 1 category.

// Perform the atomic update
    await _store.runTransaction((transaction) async {
      DocumentSnapshot latest = await transaction.get(countSnapshot.reference);
      try {
        print(
            "Updating count to " + (latest[keyCount] + amount).toString());
        await transaction.update(latest.reference, {
          keyCount: val = (latest[keyCount] + amount),
        });
      } catch (error) {
        print("Failed to update $collection count: $error");
      }
      print("New count for $collection is $val");
    }).catchError((error) {
      print("Failed to change the count for $collection: $error");
      return null;
    });

Joining the choir of people - my transactions no longer work. cloud_firestore 0.12.1

Same in my app as well, the transaction never gets through.. even a simplified get operation seems to be not running when put inside a transaction. Any other solutions for atomic operations?

Transactions were fixed in 0.12.2, see #1701.
Please let me know if upgrading doesn't help and I'm happy to reopen this issue.

I just run into the same problem. My Transaction are not executing and I have no idea where to go from here. This is with the latest version of cloud_firestore 0.12.7 and the latest stable flutter release 1.7.
And line many others indicated there are no exceptions.
This is super important to us be because all depends on these calls being reliable.
I really hopes this get attention.

@ride4sun Does it work if you call transaction.set instead of calling setData() on the reference?

@ride4sun Does it work if you call transaction.set instead of calling setData() on the reference?

Like this?
    _fireStore.runTransaction(
      (Transaction transaction) async {
        transaction.set(_fireStore.collection("users").document(email),
            {'email': email, 'displayName': displayName});
      },
    );

Yeah

Tried it , does not execute...
_fireStore.runTransaction(
(Transaction transaction) async {
------- anything inside here is not executed ----------
  },
);

Is this fixed in the devopment branch or why  do we not reopen this Issue?

Is this fixed in the devopment branch or why do we not reopen this Issue?

The fix was to the plugin (0.12.2) rather than to Flutter. The integration tests for cloud_firestore transactions are passing on both iOS and Android. So something must be different about your setup.
    test('runTransaction', () async {
      final DocumentReference ref = firestore.collection('messages').document();
      await ref.setData(<String, dynamic>{
        'message': 'testing',
        'created_at': FieldValue.serverTimestamp(),
      });
      final DocumentSnapshot initialSnapshot = await ref.get();
      expect(initialSnapshot.data['message'], 'testing');
      final dynamic result = await firestore.runTransaction(
        (Transaction tx) async {
          final DocumentSnapshot snapshot = await tx.get(ref);
          final Map<String, dynamic> updatedData =
              Map<String, dynamic>.from(snapshot.data);
          updatedData['message'] = 'testing2';
          tx.update(ref, updatedData); // calling await here is optional
          return updatedData;
        },
      );
      expect(result['message'], 'testing2');

      await ref.delete();
      final DocumentSnapshot nonexistentSnapshot = await ref.get();
      expect(nonexistentSnapshot.data, null);
      expect(nonexistentSnapshot.exists, false);
    });

Built build/app/outputs/apk/debug/app-debug.apk.
Installing build/app/outputs/apk/app.apk...                         2.5s
I/flutter ( 5218): Observatory listening on http://<IP_ADDRESS>:42166/nDUUkDzgUng=/
[info ] FlutterDriver: Connecting to Flutter application at http://<IP_ADDRESS>:52973/nDUUkDzgUng=/
[trace] FlutterDriver: Isolate found with number:<PHONE_NUMBER>582027
[trace] FlutterDriver: Isolate is paused at start.
[trace] FlutterDriver: Attempting to resume isolate
[trace] FlutterDriver: Waiting for service extension
I/flutter ( 5218): 00:00 +0: Firestore getDocumentsWithFirestoreSettings
[info ] FlutterDriver: Connected to Flutter application.
I/flutter ( 5218): 00:00 +1: Firestore getDocumentsFromCollection
I/flutter ( 5218): 00:01 +2: Firestore getDocumentsFromCollectionGroup
I/flutter ( 5218): 00:01 +3: Firestore increment
I/flutter ( 5218): 00:03 +4: Firestore runTransaction
I/flutter ( 5218): 00:04 +5: Firestore pagination
I/flutter ( 5218): 00:06 +6: Firestore pagination with map
I/flutter ( 5218): 00:07 +7: (tearDownAll)
I/flutter ( 5218): 00:07 +8: All tests passed!
Stopping application instance.

Since the original issue was fix and is covered by tests, I'm leaving this issue closed, but you can file a new issue with steps to reproduce if you aren't able to solve this by updating to cloud_firestore 0.12.2.

I had the same problem. Try this. Hope it Helps
FIrestore Transaction Handler

@creativecreatorormaybenot
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/778. Any further collaboration will be done there.


name: Bug Issue about: why the performance of nnapi is much lower than cpu . labels: 'type:bug_template'

#36088 # System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): android O
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: GLK-AL00,Mi 6,vivo NEX,MI 8 SE

Describe the problem
I write  nnapidelegate in my Engine just like nnapidelegate in tensorflowlite. When i run the same model, the performance on devices GLK-AL00,Mi 6,vivo NEX,MI 8 SE is more than 200ms, on Pixel 2 XL is 25ms, on mi 9 ,SamSung G9700  is lower than 10ms. Who can tell me why the performance on GLK-AL00,Mi 6,vivo NEX,MI 8 SE is such lower than Pixel 2 XL.

nnapi is implemented by OEM, it's possible the hardware vendors have not provided fast implementation yet.


Resolve null value for Glue fields

Add null value check for glue fields.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10387/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10389/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.3 please


Rearange view elements and add button

PR Checklist

[x] This comment contains a description of changes (with reason)
[-] Referenced issue is linked
[-] If you've fixed a bug or added code that should be tested, add tests!
[-] Documentation in docs is updated
[-] CHANGELOG.rst is updated

Description of changes
This PR changes the CreateCustomerView and provides an extra button without functionality to be linked in the future to an affiliation creation.

Still looks good to me. I tested the listener locally, works for me :)


It would be useful to allow timestamps! in EmbeddedDocuments too

I did a local test and it seems fine to add the plugin after this line:
https://github.com/jnunemaker/mongomapper/blob/master/lib/mongo_mapper/embedded_document.rb#L23
Thoughts?

Closed by #377


iOS scroll issue

I am experiencing a strange scroll is on iOS. When focusing an input or the content size changes, the screen scrolls up out of view.

I've debugged this somewhat and I can see the issue is coming from the _onRef function. Specifically, y in measureInWindow returns about 700 meaning that the scroll calculation is always out. If I add a delay to the setTimeout, e.g.
setTimeout(() => {
            this._root._innerViewRef &&
            this._root._innerViewRef.measureInWindow((x, y) => {
                this._topOffset = y;
            });
        }, 1000);

then y becomes 25 and the scrolling works exactly as expected. Im not sure what the purpose of this _onRef function is and Im not confident that my solution is the best - feels hacky without knowing what this function is supposed to be doing.
Perhaps I am doing something wrong somewhere else but I feel like I have exhausted all attempts to resolve this now. Are you able to help?

Very strange.
Sometimes ScrollView is not at the top of the page, it may be below topBar, so get this offset when you initialize.
The question is, why do you get 700 when initialize? It's either a react-native bug or you change its position after initialization.
Can you reproduce this problem in __test__?

@robertobrogi Hi, I can't reproduce this problem. Can you provide a simple demo to reproduce this problem?

If there is any new feedback, please open it again

Hi @baijunjie ,
I have an error when using this module together with the screen transition module (react-navigation-transitions) .
Code is below.
After transition FirstScreen to MainScreen fromBottom, MainScreen has a problem.

App.js

import { createAppContainer, createStackNavigator } from 'react-navigation';
import { fromBottom } from 'react-navigation-transitions';

import FirstScreen from './First';  //Temp first screen component
import MainScreen from './Main';  //example code for react-native-input-scroll-view component

const RootStack = createStackNavigator({
  First: FirstScreen,
  Main: MainScreen,
}, {
  navigationOptions: {
    header: null,
    gesturesEnabled: false,
  },
  initialRouteName: 'First',
  transitionConfig: () => fromBottom()
});

export default App = createAppContainer(RootStack);

First.js

import React, {Component} from 'react';
import { View, Text, TouchableOpacity} from 'react-native';

export default class First extends Component {
    render() {
        return (
            <View>
                <TouchableOpacity
                onPress={()=>this.props.navigation.navigate('Main')}>
                    <Text>Touch to Main</Text>
                </TouchableOpacity>

            </View>
        )
    }
}

Main.js

export default class MainScreen extends Component<Props> {
  state = {
    text: '',
    textarea: '',
  };

  render() {
    const { text, textarea } = this.state;
    return (
      <View style={styles.container}>
        <InputScrollView>
          <View style={styles.placeholder} />
          <TextInput style={styles.input} value={text} />
          <TextInput style={styles.textarea}
                     value={textarea}
                     onChangeText={text => this.setState({ textarea: text })}
                     multiline />
        </InputScrollView>
      </View>
    );
  }
}

Thank you for your help.
I found the problem. The problem is that the screen enters the screen dynamically, and the automatic topOffset is wrong in the initial stage. Now try v1.9.0 and set the topOffset props manually.
Suppose TopBar.height=60
<InputScrollView topOffset={TopBar.height}>
         ...
</InputScrollView>


Add Cyberpunk 2077 Radio Stations

Add all files for each station

[x] 88.3 Pacific Dreams
[x] 89.3 Radio Vexelstorm
[x] 91.9 Royal Blue Radio
[x] 92.9 Night FM
[x] 95.2 Samizdat Radio
[x] 96.1 Ritual FM
[x] 98.7 Body Heat Radio
[x] 101.0 The Dirge
[x] 103.5 Radio Pebkac
[x] 106.9 30 Pricipales
[x] 107.3 Morro Rock Radio

Add playlists with currently available songs

[x] Spotify @MarauderXtreme
[ ] Apple Music @h4llow3En
[ ] Youtube Music tbd

@h4llow3En would you kindly have a look at this and add the respective playlist for apple music when you got time.

@h4llow3En would you kindly have a look at this and add the respective playlist for apple music when you got time.

wow this is very cool very nice


stimulus_reflex.js:388 Uncaught TypeError: Cannot read property 'completedOperations' of undefined

Bug Report
Issue that just seemed to crop up after upgrading Ruby + Stimulus Reflex.
I am using the content_reloader via the tutorial here.  The only difference is that instead of using fetch to apply new changes, I am using this.stimulate to re-render the content.
https://stimulusjs.org/handbook/working-with-external-resources
When navigating away from the page that contains this controller, I start receiving these error messages.  In fact, I keep getting automatically redirected to the page containing this controller.  I'm guessing that Reflex is holding onto the operations despite me navigating away.  When the operation triggers it directs me back to the original view.
The frustrating bit, is that I can't reproduce this locally.  Only in production.

Any ideas what could be going on here?
Versions
StimulusReflex

Gem: [e.g. 3.3.0]

External tools

Ruby: [e.g. 2.6.6]
Rails: [e.g. <IP_ADDRESS>]
Node: [e.g. 15.2.1]

Browser

Browser chrome
86.0.4240.198  Version [e.g. 22]

import { Controller } from 'stimulus'
import StimulusReflex from 'stimulus_reflex'

export default class extends Controller {

  connect() {
    StimulusReflex.register(this)
    if (this.data.has("refreshInterval")) {
      this.startRefreshing()
    }
  }

  disconnect(){
    console.log("disconnecting")
    this.stopRefreshing();
  }

  load() {
    console.log('stimulating')
    this.stimulate()
  }

  startRefreshing() {
    this.refreshTimer = setInterval(() => {
      this.load()
    }, this.data.get("refreshInterval"))
  }

  stopRefreshing(){
    if (this.refreshTimer) {
      console.log("Stopping refreshTimer")
      clearInterval(this.refreshTimer)
    }

  }

}

Hi Shaun,
What version of StimulusReflex are you using?
What version of Stimulus are you upgrading to?
Are you using Turbolinks?
Can you please confirm that you've read and understood https://docs.stimulusreflex.com/troubleshooting#dont-initiate-a-reflex-when-your-page-has-finished-loading as it seems like you're attempting to stimulate() when you load the page. This isn't how StimulusReflex is intended to be used.
A little bit of context for what you're trying to do in layman's terms would be a big help.
Finally, this would go much faster if you could prepare a quick MVCE showing the behaviour that you're seeing. An easy way to do this is to clone https://github.com/leastbad/stimulus_reflex_harness and post your own branch so we can run it locally.
Thanks!

If import "controllers" more than once will produce this problem. And ensure to use nodejs12, with nodejs10 afterReflex callback not work.

Hi @zhongsheng!
@davissp14 says that it's working in development but not in production. Unless he's not testing in development before deploying, hopefully he's caught any duplicate import "controllers" mishaps.
I'm honestly not sure what you mean about nodejs 10 vs 12. Could you go into more detail? It's the first time I'm hearing about this, given that it is a client library.

I've seen the error as well in both development and production.
In development, I have been able to reproduce it by opening the same URL in 2 different browser windows and then executing a reflex. The error happens on the window where the action wasn't triggered.
I haven't been able to reproduce the same scenario on production myself, but I have seen errors on Honeybadger from other users.

I realized that I also had imported controllers twice, but even after fixing that, I still see the issue happening.

I am on Ruby 2.7.2 and Stimulus Reflex version 3.3.0 for both gem and npm package.

I strongly advise that you upgrade to v3.4.0.pre8 (and soon, pre9) as this is unfortunately a known issue in v3.3 that cannot be easily fixed.

Upgrading to 3.4.0.pre8 did seen to resolve the issue.  Appreciate it!

Awesome! pre9 will be out soon, and it's non-trivially improved from pre8 in subtle but important ways. Keep your eyes peeled. 😀

It did resolve it for me as well. Thanks! 💯


WARNING in XXX depends on 'moment/locale/fr'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Describe the bug
After upgrading to Angular 10, Angular build has started giving below warning -
WARNING in XXX depends on 'moment/locale/fr'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
For more information refer this link -https://angular.io/guide/build#configuring-commonjs-dependencies
As a workaround, it is getting resolved after adding "moment" into "allowedCommonJsDependencies" section of angular.json file.
Expected behavior
No such warning should be visible while making the build.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Similar kind of issue has been already confirmed by chart.js library for which they will release the ES Module package. Please refer below link for additional details -
https://github.com/chartjs/Chart.js/issues/7550

Same warning here.
I use the same import 'moment/locale/fr; for years to include french locales ...  but I must confess I didn't know what this import really did.
I see it basically set a 'fr' locale using the defineLocale method with a large configuration object in JSON.
I guess we could properly export those objects (one per locale) and let the user add the final moment.defineLocale('fr', <imported_object> ); to his code.
Actually I have to write this:
import moment from 'moment';
import 'moment/locale/fr';
moment.locale('fr');

Tomorrow I would have to write this instead:
import moment from 'moment';
import LOCALE_FR from 'moment/locale/fr';
moment.defineLocale('fr', LOCALE_FR);
moment.locale('fr');

@marwahaha : I could try a POC if it is OK for you.

Same here:
Warning<EMAIL_ADDRESS>depends on 'moment'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

same problem