build_visit error message reports wrong path to log file

Describe the bug
Recording a discussion we had at our project meeting on 2/16/2021:
If a build fails, build_visit provides a message about what log file to look at.
The build_visit_log_ is relative to the build path of the lib that failed, however the actual log with the details is one dir up.
There is one in the lib build dir, but it doesn't have in the info we need.
Related issue:
Why are logs even created in the lib build dir, should all info be in the main log?

The build_visit log is in the directory that you run build_visit. There may be a log file in the directory of the software but it has only a line or a few lines and is typically not helpful.

I've found a fixed a slew of small problems with build_visit. One particularly bad one is the sensitivity of logic to detect compiler version number. That was far too dependent on there not being any positional (or, frankly, other kinds of) changes in the way vendors output compiler version info.
That said, the problem @cyrush ran into is an inherent issue with our scripting logic. We are constantly outputing via >> operator to a log file. When we cd into a build directory to work there, we effectively start doing those very same >> operations into a file by the very same name (e.g. build_visit_log) in that package's sub-dir.
But, it turns out for most packages, very little info winds up going there. That is because when we actually go to execute the configure (or cmake) work, we do that by invocing a sub-shell. That sub-shell is still having its output redirected to the top-level build_visit_log.
At least that is my current understanding of what is going on.

What is happening here is that all packages call info function to record what they are doing. That function uses echo to echo the information. Usually, we have a redirect active so that simply performing the echo command causes the output to go to the top-level log.
But, info also calls build_visit's log function. That function does an echo with explicit redirect (>>) to $LOG_FILE. So, whenever info is called between cd <package-build-dir> and cd <build_visit-start-dir> anything output by log function goes to $LOG_FILE (build_visit_log) IN THAT DIR.
Other than from within info there are just a few places log is used. I am going to remove that method entirely and this should fix the problem with creating build_visit_log files at the top and in individual package build dirs.
That said, there is still a lot of build_visit output behavior that seems odd to me.


Do not cache itemBuilder calls in a GridView

Description
Avoid caching the result of the itemBuilder for GridView. This causes problems particularly when the widget being built is expensive to hold in memory, such as when it's a memory image.
Ideally, this shouldn't land until after https://github.com/flutter/flutter/pull/61025 has run through the devicelab to show the improvement in memory usage expected.
This might potentially regress frame performance, but I can't find a benchmark ti should negatively impact. Either way, it's causing OOMs for a customer so it needs to be fixed. If we can determine a memory safe way of doing an LRU cache for this we could try that. However, we generally say that things that build widgets should be fast - I doubt we're really saving much time with this optimization.
/cc @chunhtai @Hixie
Related Issues
Fixes https://github.com/flutter/flutter/issues/61006
Tests
I added the following tests:
Unit test that we call the itemBuilder when scrolling.
Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

I doubt we're really saving much time with this optimization.

I would be more comfortable if we validated this claim; either via benchmarks or if that's too hard, by manual testing. Is the performance acceptable with the repro case that the client gave us (200 6M images)? I admit it is highly synthetic but it could give us an idea of what we are losing.

The use case this should help is when you have a GridView and rapidly scroll back and forth, it's caching the result of the itemBuilder function and so doesn't have to keep invoking it.
Anecdotally, I don't notice any significant performance difference with the customer's simplified demo, which I think is fairly close to their real use case. But I'm also testing on relatively recent hardware (iPhone 11, Pixel 4). Is there any chance the customer has any benchmarks for this?
I didn't think transitions perf would be much impacted by this, but it looks like the numbers are better overall:
on master:
    "missed_transition_count": 0,
    "average_frame_build_time_millis": 2.2558806306306307,
    "90th_percentile_frame_build_time_millis": 3.367,
    "99th_percentile_frame_build_time_millis": 22.765,
    "worst_frame_build_time_millis": 63.287,
    "missed_frame_build_budget_count": 15,
    "average_frame_rasterizer_time_millis": 5.261718785151857,
    "90th_percentile_frame_rasterizer_time_millis": 6.276,
    "99th_percentile_frame_rasterizer_time_millis": 21.771,
    "worst_frame_rasterizer_time_millis": 80.495,
    "missed_frame_rasterizer_budget_count": 15,
    "frame_count": 888,
    "frame_rasterizer_count": 889,
    "average_vsync_transitions_missed": 1.1791044776119404,
    "90th_percentile_vsync_transitions_missed": 2.0,
    "99th_percentile_vsync_transitions_missed": 2.0

-========

on grid_memory_widget with master:
    "missed_transition_count": 0,
    "average_frame_build_time_millis": 2.2474882943143832,
    "90th_percentile_frame_build_time_millis": 3.33,
    "99th_percentile_frame_build_time_millis": 22.208,
    "worst_frame_build_time_millis": 41.701,
    "missed_frame_build_budget_count": 12,
    "average_frame_rasterizer_time_millis": 5.14609933035714,
    "90th_percentile_frame_rasterizer_time_millis": 6.636,
    "99th_percentile_frame_rasterizer_time_millis": 19.603,
    "worst_frame_rasterizer_time_millis": 50.042,
    "missed_frame_rasterizer_budget_count": 12,
    "frame_count": 897,
    "frame_rasterizer_count": 896,
    "average_vsync_transitions_missed": 1.1388888888888888,
    "90th_percentile_vsync_transitions_missed": 1.0,
    "99th_percentile_vsync_transitions_missed": 5.0

Hmm.  Looking at https://github.com/flutter/flutter/commit/59524c697b7904e915b6e7936bf4a6ea3b4b9426, I'm wondering if this change is quite right. @Hixie wdyt?
At any rate, this patch should remove the remaining comment if we're not using it.
It's not clear to me what the failure mode would be here.

I'm going to go ahead with this. I can't come up with a case where this would cause problems, and if we find one we can fix it.


Zencash Wallet Version 0.74.7 Sending Incorrect Amounts

Using on Mac OS Sierra 10.12.6. When I execute a transfer the amount is correct. When it reaches the blockchain it's an incorrect  amount to a completely different address listed in my wallet not the wallet that was intended.

If you send ZEN from a T address its original balance is spent entirely in 3 parts:

The original amount sent to the intended destination
The transaction fee to the miners
3, The remaining balance is sent to another T address in the same wallet. This is a feature that comes from Bitcoin (the ZEN code-base). This point sometimes confuses users...

Could you please point to your transaction on the blockchain and specify: how much ZEN you intended to send and to which address and what part of the transfer was wrong. You could try this with a small amount just for the exercise...
Example transaction:
https://explorer.zensystem.io/tx/1283c4698e54dcb8f32928857c5ff51e850a9f5efa099d46ba36bdfc1505aede
here "some" user znbKhxbbJnFar1GaxTiAZjtTv7EX4yM4Dgu had 11.10163 zen. He sent 10 ZEN to address znarmmN6KNBxUMPVVG8kw7CTZJN2J5pU9gR and the remaining balance 1.10163 zen was automatically sent to another address in his wallet: znbKhxbbJnFar1GaxTiAZjtTv7EX4yM4Dgu ...

Support case - no further information received.


Added sender_keyword parameter to @method decorator

PR for issue #129

This isn't how I want to fix this problem. I'd rather pass the full message as context when requested. It will take some thinking about the design.


MWPW-159374: Support MAS switch to Prosemirror RTE

This PR updates the merch-card hydration logic from an AEM fragment, resolving the new markup for the different CTA styles.
Also added new tests, increased test coverage.
see: https://github.com/adobecom/mas/pull/79 for more details.
Resolves:
MWPW-159374
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://mwpw-159374--milo--adobecom.hlx.page/drafts/ilyas/merch-card?martech=off

@yesil  I have verified the PR with the Ready for stage label but the failing coverage check needs to be fix in order for PR to really be merged. Will be skipped otherwise


Add assertThrows(Class, ThrowingRunnable)

This adds a convenience method that simply delegates to expectThrows and
discards its result. There are three reasons for this:
(1) It prevents warnings: discarding a Throwable return value can raise
red flags
(2) It facilitates convention: "assert" is called solely for its side
effect, whereas "expect" returns something but first asserts
something about its return value
(3) It enhances discoverability: most people will look for methods
prefixed with "assert", and indeed, the return value of expectThrows
is often unneeded

Pinging this. No rush, I'd just like to see it ship with the next release, whenever that is.


Skip Prompt in RouterTabs

Alternative approach to https://github.com/vivid-planet/comet-admin/pull/545

add excludedRoutes to RouterPromptHandler
don't show a "Discarded unsaved changes" dialog when navigating to an excluded route
RouterTabs register their routes as excluded
=> when navigating inside RouterTabs, no "Discard unsaved change" dialog appears
add a flag promptOnNavigation that can be added to a RouterTab.
When added, its route is not excluded => "Discard unsaved change" dialog appears on navigation

While #545 bypasses the dirty check in FinalForm, this approach suppresses the prompt at its root
Open Questions

Is this a breaking change? I don't think so, but I'm not 100% sure if it counts as breaking

At the moment, RouterTabs registers all routes automatically. Maybe the default should be the other way round?
Meaning:
Instead of adding promptOnNavigation when navigation to a tab is unsave, add dontPromptOnNavigation (or similar)
when it's save to navigate there

Try it here:

https://deploy-preview-642--comet-admin.netlify.app/?path=/story/comet-admin-tabs--routertabs-with-form-in-stack
https://deploy-preview-642--comet-admin.netlify.app/?path=/story/comet-admin-tabs--nested-routertabs-with-form-in-stack

I'd prefer a solution where this behavior works out of the box, without the need to provide an additional prop promptOnNavigation.  The solution in #545 is more magic, but works without having the developer to think about adding or not adding such a prop to every tab. Maybe we could try for a solution such as #545 without the tight coupling between FinalForm and Router Tabs.

Fixed by #1027


Fix timestamp deserializing

Resolves #12
I only did some minimal tests which looked good but it's best for someone else to test it too.

It seems to be working fine now

Though it's wierd why I got a invalid session

Thanks for the fix! Never came across this considering I don’t use expiry. 😅

@hydrox19 As for invalid session, that is expected behaviour when it is unable to resume after a restart (likely because a long time has elapsed). You can disable this behaviour with the configurations, if you want.


Column width auto is not always spaced evenly

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
When using column width auto it should resize to fill the available space.
However, say I have three columns that all use .col class. they do not always space them selves to fill the available screen space
e.g. we have
.row > * {
flex-shrink: 0;
width: 100%;
max-width: 100%;
padding-right: calc(var(--bssk-gutter-x) * .5);
padding-left: calc(var(--bssk-gutter-x) * .5);
margin-top: var(--bssk-gutter-y);
}

From what I can tell the width property is simply not required. In fact this seems to be the source of the problems. i.e. the width does not adjust accordingly.
If I override this and set it explicitly to 0, the flex box seems to behave and respond correctly.
Please see attached screenshots

Reduced test cases
.row > * {
width: 100%;
}

What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Safari
What version of Bootstrap are you using?
5.3.3

Actually the above fix needs to be more specific e.g.
.row > .col {
width: 0;
}

Thanks for your quick response.
Ok I have tried to recreate the issue here
https://codepen.io/twodareis2do/pen/xxNGKPd
However I can't seem to replicate the same issue as on my local.
I  have tried switching JavaScript off in my browser, and that seems to rectify the problem as well!
Will try and investigate further as it seems likely that something else is causing this behaviour (i.e. not bs)

Ok, I was trying to reproduce the wrong page!
I have updated the demo (same link as per my previous post)
There should be three columns viewable and it is showing only two on page load.
If you uncomment the last line of the css, the 3 columns are alligned correctly.

Your example is not a reduced test case—it's a rather complex page full of extra HTML. Closing until we get a more defined test case we can isolate to Bootstrap's components.


[2.x] Restore using the class ClusterInfoRequest and ClusterInfoRequestBuilder from package 'org.opensearch.action.support.master.info' for subclasses (#4307)

Description
Backport PR https://github.com/opensearch-project/OpenSearch/pull/4307 / commit https://github.com/opensearch-project/OpenSearch/commit/65f966ed71ff9bc0a53490ee801943869c0f536d into 2.x branch

Restore the inheritance relationship of the class GetIndexRequest and GetMappingsRequest, to extend org.opensearch.action.support.master.info.ClusterInfoRequest. The 2 classes are the only subclasses of ClusterInfoRequest in other packages.
Add a unit test to validate the return type for the method GetIndexRequest#indices(java.lang.String[]) is an instance of org.opensearch.action.support.master.info.ClusterInfoRequest.

Issues Resolved
https://github.com/opensearch-project/OpenSearch/issues/4203
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4324 (78d9051) into 2.x (38372e1) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #4324      +/-   ##
============================================
- Coverage     70.61%   70.58%   -0.03%
+ Complexity    56935    56919      -16
============================================
  Files          4571     4571
  Lines        273530   273530
  Branches      40111    40111
============================================
- Hits         193147   193078      -69
- Misses        64195    64302     +107
+ Partials      16188    16150      -38

Impacted Files
Coverage Δ

...arch/action/admin/indices/get/GetIndexRequest.java
55.31% <ø> (ø)

...tion/admin/indices/get/GetIndexRequestBuilder.java
66.66% <ø> (ø)

.../admin/indices/mapping/get/GetMappingsRequest.java
50.00% <ø> (ø)

...indices/mapping/get/GetMappingsRequestBuilder.java
100.00% <ø> (ø)

...opensearch/index/mapper/MockFieldFilterPlugin.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...adcast/BroadcastShardOperationFailedException.java
33.33% <0.00%> (-66.67%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

...h/action/ingest/SimulateDocumentVerboseResult.java
60.71% <0.00%> (-39.29%)
:arrow_down:

...cluster/coordination/PublishClusterStateStats.java
33.33% <0.00%> (-37.51%)
:arrow_down:

... and 487 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

How does this work for deprecation? I mean can I write code that takes a dependency on the cluster manager types without ever hitting this?

@dblock That’s a good question. 😄 I think developers can totally use the classes with name cluster manager to replace the classes with master, for the classes related to this PR.
Class ClusterInfoRequest in master package is a subclass of the same-name class in clustermanager package. If an object type is o.o.action.support.master.info.ClusterInfoRequest, it’s also belongs to o.o.action.support.clustermanager.info.ClusterInfoRequest.

@dblock Thanks for your review! 👏


How to manually Abort startAuthentication () with browser autofill

In a single page app, how can we abort the startAuthentication() with browser autofill if ever the user leaves the page without the promise being resolved?

There's currently no way to do that; @simplewebauthn/browser doesn't expose a way to manually abort a Conditional UI request. However, the next time your authentication page renders and calls startAuthentication() @simplewebauthn/browser will automatically abort the first autofill request via the internal WebAuthnAbortService:
https://github.com/MasterKale/SimpleWebAuthn/blob/master/packages/browser/src/helpers/webAuthnAbortService.ts#L12-L22
The same thing will happen if, on your login page, you call startAuthentication(..., true) to initialize autofill, but then allow the user to manually initiate WebAuthn auth via startAuthentication(...).
This is getting into the weeds a bit, though. Suffice to say I believe users like yourself can forget about managing abort signals and just let @simplewebauthn/browser manage this aspect of WebAuthn use.

Thanks, @MasterKale, for the explanation. Wonderful project


Running simple/common gradle tasks under earth_enterprise/rpms fails

On a clean system (one that never did a scons stage_install simple commands like gradle clean or even gradle tasks fail to run with the following below error output.  These commands should succeeded and to the correct thing without having to run scons stage_install or even a scons build or any scons command.  This was somewhat of an issue prior to 5.2.4 but during the 5.2.4 release we inadvertently made this issue much worse via changes done for #987
Error output:
FAILURE: Build failed with an exception.

* Where:
Build file '/mnt/c/Users/rwildes/projects/geoplatform/earthenterprise/earth_enterprise/rpms/build.gradle' line: 100

* What went wrong:
A problem occurred evaluating root project 'rpms'.
>                 Runing `scons` to produce </tmp/fusion_os_install/gee_long_version.txt> failed!
                  Command: [/usr/bin/scons, release=1, /tmp/fusion_os_install/gee_long_version.txt]
                  Exit code: 2.
                  Error output:
                  scons: *** Do not know how to make File target `/tmp/fusion_os_install/gee_long_version.txt' (/tmp/fusion_os_install/gee_long_version.txt).  Stop.

                  Standard output:
                  scons: Reading SConscript files ...
  Checking for C library gtest... (cached) no
  Checking for C header file libpng12/png.h... (cached) yes
  scons: done reading SConscript files.
  scons: Building targets ...
  scons: building terminated because of errors.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 5s

Closing as fix was merged.


Chore change LocalExchangeSharedState:mem_usage signed type to avoid query …

…blocked when negative mem_usage
Proposed changes
change LocalExchangeSharedState:mem_usage signed type to avoid query blocked when negative mem_usage

run buildall


Connection list showing oldest connection first. Should be newest first

Description
If I connect to browser wallet via multiple dapps, I see the oldest connection at the top of the connection list. I would expect to see the most recent connection at the top
Steps to Reproduce

Get the browser wallet extension and on board
Open https://vegaprotocol.github.io/vegawallet-browser/ and connect to the wallet
approve the connection in the wallet
Go to arsenal.com and in the console execute vega.connectWallet()
approve the connection in the wallet
Click 'Connections' in the browser wallet navigation panel
observe that https://vegaprotocol.github.io/vegawallet-browser/  is shown first in the connections list, even though my connection to arsenal.com was more recent

Expected behavior
Most recent displayed first.
Screenshots/casts

Device details

Browser wallet 0.7.0 chrome

Backend API sorts by most recently used first. This is covered in this tests:
https://github.com/vegaprotocol/vegawallet-browser/blob/0d90faafe40c36df89e6217eadc6bc5cdb745149/web-extension/test/connections.spec.js#L190-L194


fix(ssa refactor): resolve replaced value ids for printing

Description

Problem*
The SSA printer gave confusing output when a value had been replaced (during mem2reg).
Resolves #1451
Summary*
Track ids involved in value replacements such that the printer can resolve them later.
For program:
fn main(x: Field) -> pub Field {
    let xs = [x];
    xs[0]
}

Before:
fn main f1 {
  b0(v0: Field):
    v1 = alloc 1 fields
    return v2
}

After:
fn main f1 {
  b0(v0: Field):
    v1 = alloc 1 fields
    return v0
}

Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

It may be the case we should remove set_value and set_value_from_id entirely. Instead we'd have to manually find each instruction that references the value and mutate that instruction.
Alternatively, if we want to keep set_value, we'd have to avoid HashMap<ValueId, _> entirely and switch to e.g. HashMap<Value, _> directly. Or switch ValueId to be the equivalent of a Value** rather than a Value*.

I'm more incline to remove set_value and set_value_from_id. It would be awkward when substitution is required, but I'd rather have to deal with that awkwardness in a contained manner, than have to introduce the extra mental overhead of thinking in terms of pointers to pointers everywhere else.

Added issue for tracking: https://github.com/noir-lang/noir/issues/1592


build all images every day to get the latest libraries

WHY are these changes introduced?
Version incompabilities between library versions in the build image and the runtime image can otherwise cause segfaults and other problems.
See: https://github.com/cloudamqp/amqproxy/issues/178
WHAT is this pull request doing?
Building a images every day at 4:45am UTC.
HOW can this pull request be tested?

Any downside on doing this?

I just noticed this change as it seemed odd to me that binary packages were rebuilt every day.
The motivation for this was docker images, so I suppose the rebuild doesn't need to affect packages? It could be avoided by adding something like if: github.event_name != 'schedule' to the debian and fedora jobs.
I'm also wondering however if daily rebuilds are actually necessary for docker images as well. Of course there can be compatibility issues if you copy binaries between images with different bases and thus potentially different libraries (https://github.com/cloudamqp/amqproxy/issues/178).
I understand the instructions have been updated to not recommend this in https://github.com/cloudamqp/amqproxy/pull/183.
So are daily rebuilds even necessary still?

oh, yeah, that was a mistake, only the container images should be recompiled. And it is to always have the latest library versions. Most dist shouldn't upgarde to ABI incompatible versions but apparently Alpine does.


Create FAQ page to address most common questions/problems that users may face when using devfiles

Add FAQ page to documentation for most common questions/problems. The intention is to help the user to self-service and reduce the requirement of contacting us for help. This will be an on-going document that we'll add entries as we go questions from devfile users/writers as needed.
The initial content of the FAQ will need to gather from current adopters/users, e.g. devfile/sample writers, e.g. MW teams, who provide the stacks, tools provider like odo, etc.

JIRA: https://issues.redhat.com/browse/RHDEVDOCS-2870

As mention in my comment, we will review this issue in upcoming refinement calls.

For criteria, it would be good to have a few good initial questions and answers to scope this issue then continue to build this page as more challenges are encountered.


feat(crashlytics): Move iOS deployment target from 10 to 9

Description
Since firebase-ios-sdk 7.3.0 bumps down crashlytics minimum deployment target to 9.0 . This plugin can also support iOS 9+.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

https://github.com/firebase/firebase-ios-sdk/pull/7053

Should I downgrade flutter_core too? Because flutter_core is a dependency from flutter_crashlytics

Should I downgrade flutter_core too? Because flutter_core is a dependency from flutter_crashlytics

If core from the iOS SDK supports iOS 9 then we should probably make that one iOS 9 too if we accept this as Crashlytics requires core to function.
cc @mikehardy - thoughts?

If core from the iOS SDK supports iOS 9 then we should probably make that one iOS 9 too if we accept this as Crashlytics requires core to function.
cc @mikehardy - thoughts?

Expediency (single target) vs widest compatibility. I think there are a few that do 9, analytics as well maybe? We decided for expediency when bumping to 10 before based on version install stats and other ecosystems moving to 10 minimum. If the version story will be complicated I'd encouraged it to match upstream exactly with a full package audit, then yes core is lowest to match.

Expediency (single target) vs widest compatibility. I think there are a few that do 9, analytics as well maybe? We decided for expediency when bumping to 10 before based on version install stats and other ecosystems moving to 10 minimum. If the version story will be complicated I'd encouraged it to match upstream exactly with a full package audit, then yes core is lowest to match.

Closing in favour of this PR: https://github.com/FirebaseExtended/flutterfire/pull/6757


getDeclaredMethods() should search super-interfaces recursively.

This should fix #51 .
A few comments:

While the original code instantiated the ArrayList lazily, this PR instantiates it before starting the scan (because it's simpler). I think it's acceptable, but please let me know if it isn't.
There may be a room for further refactoring (collectMethods() and collectAccessors()), but it requires a bigger change.
Is there any guideline for the code format? XD

Thank you very much I will test your code first thing tomorrow morning 😊

Thank you I've checked and your implementation is even better than the former one since it also get default methods of interface herited from super interfaces !!!
I look forward seeing this added to the 3.1.x branch :)
PS : BTW in your fork I noted some code not in the PR in method getReadMethod on line 2950 you replaced :
        BeanInfo info = Introspector.getBeanInfo(target);
        MethodDescriptor[] methods = info.getMethodDescriptors();

by :
Method[] methods = target.getMethods();
Is it to overcome a potential bug in Introspector since the code seems to handle just fine with your last PR ?
B.R.

Thank you for testing, @YSavanier !
I'm not sure which PR you are referring to, but it would be #33 that replaced Introspector (not my PR).
This is my third PR and I have not modified getReadMethods() so far.

https://github.com/jkuhnert/ognl/pull/40/files
https://github.com/jkuhnert/ognl/pull/41/files
https://github.com/jkuhnert/ognl/pull/55/files

Ok, I think we are good to merge this PR? Any objections?

I'm looking forward to it being released ^^

3.2.7 is under way to the Central :) Thanks a lot!

Thanks for the merge and the quick release, @lukaszlenart !
I'll open another PR for the 3.1.x port tonight.

Cool, thanks a lot for your support :)


Incorrect deleteScope declaration in .d.ts

Hello
Apply my PR with correct index.d.ts declaration
https://github.com/jaywcjlove/hotkeys/pull/362

@vkruglikov thx! Upgrade v3.9.1


Update translation strings as of 20200721T202356

Please do not manually merge this pull request.  It will either be automatically merged or withdrawn.

yarn run v1.22.4
$ eslint .
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


No rendezvous handler for env://

I found the error "No rendezvous handler for env://" when I train "classifier_train.py." Do you have any suggestions?
File "C:\Users\K.Nuttapol\PycharmProjects\diffusion-anomaly\scripts\classifier_train.py", line 288, in
main()
File "C:\Users\K.Nuttapol\PycharmProjects\diffusion-anomaly\scripts\classifier_train.py", line 45, in main
dist_util.setup_dist()
File "C:\Users\K.Nuttapol\PycharmProjects\diffusion-anomaly\guided_diffusion\dist_util.py", line 54, in setup_dist
dist.init_process_group(backend=backend, init_method="env://")
File "C:\ProgramData\Anaconda3\envs\diffusion-anomaly\lib\site-packages\torch\distributed\distributed_c10d.py", line 434, in init_process_group
init_method, rank, world_size, timeout=timeout
File "C:\ProgramData\Anaconda3\envs\diffusion-anomaly\lib\site-packages\torch\distributed\rendezvous.py", line 82, in rendezvous
raise RuntimeError("No rendezvous handler for {}://".format(result.scheme))
RuntimeError: No rendezvous handler for env://

Try to change the code that 'backend == "gloo"', then maybe it will work.


Fix test and improve process sandboxing

The native EventEmitter module will not create an _events collection, if there is already an existing one (see code here).
This causes that the existing listeners are not re-initialized in the deep copied process object, so tests triggering listeners will also trigger the original Jest listeners. The fix is simple: avoid copying the _events property so the object gets re-initialized.
Also fixes the ./child test from jest-worker when running in parallel mode.

Time to turn it into a whitelist? ;P

I think it's better to break when an option is wrongly copied than silently missing one recently added (unless the blacklist becomes bigger than 5-6 options; in which case I'd agree)

Codecov Report

Merging #5027 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5027      +/-   ##
==========================================
+ Coverage   60.35%   60.37%   +0.01%
==========================================
  Files         198      198
  Lines        6639     6637       -2
  Branches        4        3       -1
==========================================
  Hits         4007     4007
+ Misses       2632     2630       -2

Impacted Files
Coverage Δ

packages/jest-util/src/create_process_object.js
100% <ø> (ø)
:arrow_up:

packages/jest-environment-node/src/index.js
76.66% <0%> (ø)
:arrow_up:

packages/jest-environment-jsdom/src/index.js
40% <0%> (ø)
:arrow_up:

packages/jest-config/src/index.js
23.8% <0%> (ø)
:arrow_up:

packages/jest-config/src/normalize.js
92.94% <0%> (+2.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94101e9...87edaac. Read the comment docs.


fs.FS support?

Considering that the package is quite low-level at times, would it be at all possible to add support for the fs.FS interface?  For example, to have versions of TempDir and TempFile that accept fs.FS?  And perhaps the latter would return a modified version of fs.File?

I have only used fs.FS when working with the embed package thus far, so my experience with it is limited.
When you suggest adding a version of TempFile that accepts fs.FS, what sort of use-cases would that make possible? Can you provide an example or a specific motivation?
renameio needs os.OpenFile (to create a new file), (*os.File).Sync and os.Rename. AFAICT, fs.FS offers none of these, so we’d need to use interface assertions, or a custom interface to begin with.


How to run two app / project within just one?

What are the steps to run two app that are in two different directories within the same server (project). So that in this way two different server / hosting are not required. Cases like in which a static site / site is mounted with CMS and inside it is routed to an application also made in Node js / Express. Being able to run an app inside the other and route to each even though they are in different directories maybe but in the same project directory of the app that is running. If someone knows how to run two app in one to not use additional resources tell me how please.

For support or general discussions, please use https://gitter.im/expressjs/express This issue tracker is mainly for feature work and bug reports.

You have one solution of this problem. We all know that its not possible to deploy more then one app on single server. So instead of defining two app, just make it virtually separate.
In this case, you can create two separation by defining route prefix and all sub-route goes under respective app url.
app 1 : localhost:3000/api/first-app/other-routes
app 2 : localhost:3000/api/second-app/other-routes

I understand the part of separating in routes, the one that I do not understand is that of locating the different app directories and executing the referencing them. For example there is a project of https://www.npmjs.com/package/node-jasper-server that requires to run another app and route routes to generate the report in pdf or another format.

@martinmurciego where are two directories. Can you point me out line in the documentation?


1 pixel line on iOS when using offset

Reopening this issue as I'm experiencing a 1-pixel line on the shadow when using offset. See below code snippet and screenshot.
<Shadow
				distance={SPACING.s12}
				viewStyle={{ alignSelf: 'stretch' }}
				radius={SPACING.s16}
				startColor={COLORS.primary}
				finalColor={COLORS.primary}
				offset={[5, 5]}
				safeRender
			>

Package Version:
"react-native": "0.66.4",
"react-native-svg": "^12.1.1",
"react-native-shadow-2": "^6.0.2",

Thanks!
If you change the offset to offset={[-5, -5]}, does it also happens for the top and left sides?

Looks like it's a paintInside issue.
I think I found the cause: In the line 432 (in TS source), https://github.com/SrBrahma/react-native-shadow-2/blob/aaf5dee9f050ca40a98b7f471c3201410c20417a/src/index.tsx#L432, there is "width={width} height={height}".
In the transpiled .js file, it's on the line 240. You can give it a try and edit the node_modules/react-native-shadow-2/lib/index.js and replace what I quoted with width={widthWithAdditional} height={heightWithAdditional}. I think it will work, as by having a smaller width and height, the SVG gets shortened, specially on high dp screens, as your iPhone must be. What is your iPhone model?
If it fixes it, I will asap release it.

Also, please, make a minimal reproducible example in Expo Snack (iOS), so if I can get this issue here I won't have to make you try different stuff.

@SrBrahma thanks for the quick reply, I have tried editing line 240 above but that did not fix the issue.
Below is a screenshot of offset={[-5, -5]}, you can see that they are some 1 pixel lines visible

Also, the issue is visible on your snack, just change the shadow color to a darker color - https://snack.expo.dev/@srbrahma/react-native-shadow-2-sandbox
I am using an iPhone Xs

Hi, @walterholohan.
Big text ahead just for future references:
I managed to get the issue on my iPhone 8. As it doesn't have a high dp and has the issue, this seems it's an issue caused by how react-native-svg handles masks on iOS, a svg tag that paintInside uses. It doesn't seem to be predictable on iOS. Sometimes an x/y positioning of like +1 would fix it, sometimes not. In your image, you can see that some lines are thicker than others:

I've managed to get a solution: on 2nd render and beyond (or when size property is defined), we use a simple  SVG component to exactly paint the internal of the shadow.
<Path fill={startColor} d={`M0,${topLeft} v${height - bottomLeft - topLeft} h${bottomLeft} v${bottomLeft} h${width - bottomLeft - bottomRight} v${-bottomRight} h${bottomRight} v${-height + bottomRight + topRight} h${-topRight} v${-topRight} h${-width + topLeft + topRight} v${topLeft} Z`}/>

I can't do this on the first render as the Path doesn't accept percentage values, only number ones.
We could this on the first render if we smartly placed rectangles inside the hole, but it's a quite hard task, as each corner may have different radii. You can see this if you imagine a square and at each corner you remove a square of a random size. What algorithm would you use to always fill the entire hole without overlaps, as overlaps would mess the internal color, as it may have transparency? Also, doing this wouldn't give a guarantee that it wouldn't also give gaps.
On the first render, the current mask solution is still used, so the gaps will briefly show up. But, on a 60fps screen, 1px line and for something that just appeared, it isn't noticeable for common eyes.
tl;dr, Released 6.0.3 via 2f3001f388a68b3d04906d0a00ef9e10915d7c09!
Please, tell me if it worked for you!

If you think that those lines are noticeable on the first render, I could really use a hand on that rectangles algorithm. I am really out of time to do it right now.

This was recently merged on react-native-svg on 12.3.0: https://github.com/react-native-svg/react-native-svg/pull/1658
As it both mentions iOS mask and pixel-density, this probably fixes this issue.
I will it later try without my fix and with this new svg version.


ZLIBNG_VER_STATUS related build failure of perl 5.38.0 with zlib-ng 2.1.3

See https://gitlab.spack.io/spack/spack/-/jobs/7711837
cc -c  -I/home/software/spack/[padded-to-256-chars]/linux-ubuntu20.04-x86_64_v3/gcc-11.1.0/zlib-ng-2.1.3-336bvhbgdrysvjersb3j5j3cwlxb2jql/include -D_REENTRANT -D_GNU_SOURCE -DAPPLLIB_EXP="/home/software/spack/[padded-to-256-chars]/morepadding/linux-ubuntu20.04-x86_64_v3/gcc-11.1.0/perl-5.38.0-qgkulwfhciigujcnklxnk6hkpor6adph/lib/perl5" -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/home/software/spack/[padded-to-256-chars]/linux-ubuntu20.04-x86_64_v3/gcc-11.1.0/gdbm-1.23-xpyyzcrwdav47volmutsdrioid7x4npe/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -Wall -Werror=pointer-arith -Werror=vla -Wextra -Wno-long-long -Wno-declaration-after-statement -Wc++-compat -Wwrite-strings -O2   -DVERSION="2.204_001" -DXS_VERSION="2.204_001" -fPIC "-I../.."  -DNO_VIZ      -DGZIP_OS_CODE=3  -DPerl_crz_BUILD_ZLIB=0 Zlib.c
In file included from Zlib.xs:37:
constants.h: In function 'constant':
/home/software/spack/[padded-to-256-chars]/linux-ubuntu20.04-x86_64_v3/gcc-11.1.0/zlib-ng-2.1.3-336bvhbgdrysvjersb3j5j3cwlxb2jql/include/zlib.h:57:27: error: 'F' undeclared (first use in this function); did you mean 'OF'?
57 | #define ZLIBNG_VER_STATUS F         /* 0=devel, 1-E=beta, F=Release */
|                           ^

Similar as https://github.com/zlib-ng/zlib-ng/discussions/1517

@pmqs did you figure this out?

Found https://github.com/pmqs/Compress-Raw-Zlib/issues/24

Applied https://github.com/pmqs/Compress-Raw-Zlib/commit/0d505d9156ca7e9cac15e2d6e574099300f91a14#diff-ccd2686097cb7d6c300c0af47bec8fe7bf4c1c3ed05ad604b3786abb93d97e46 as a patch, which makes the build pass.
Is that sufficient for Perl 5.38 or do I need more @pmqs?

Applied pmqs/Compress-Raw-Zlib@0a8fb71 as a patch, which makes the build pass.
Is that sufficient for Perl 5.38 or do I need more @pmqs?

No - all is good. This change is now in Compress-Raw-Zlib 2.204


Exclude from pre-commit

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

#2708  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @atroyn and the rest of your teammates on  Graphite


release tantivy

prerelease
chore: Release

Codecov Report

Merging #2083 (8ee4d8f) into main (fdecb79) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage   94.39%   94.39%
=======================================
  Files         321      321
  Lines       60386    60386
=======================================
  Hits        57004    57004
  Misses       3382     3382


[responsive] Updates to use latest react-responsive-media

Force version of https://github.com/artsy/reaction/pull/1534

merge on green


Switch to VSCode official debian repo

https://code.visualstudio.com/updates/v1_10#_official-signed-repositories-for-linux
deb [arch=amd64] https://packages.microsoft.com/repos/vscode stable main

Done


Specific focus mode for popup?

I was trying to assign a specific shortcut key (instead of esc) to dismiss popup/tooltip box (as seen pointed by the red arrow in the screenshot).
Wondering if there's a specific focus mode I could use to target it? Something like "when": "editorFocus" but for popups instead?

That looks like the hover info.
Escape should by default dismiss the popup. It doesnt for you?

Yes escape worked fine by default, it's just that I mapped it to switch between active editor and integrated terminal, so now every time I want to dismiss the popup, it also switches the focus from editor to terminal.
What I wanted to do is setting up a new shortcut key to only dismiss the popup when it's displayed, but after that stay put in current editor.
Here's what I tried but to no avail, hence asking if there's specific focus mode I could use to replace <SOME_MODE>.
{
      "key": "escape escape", "command": "workbench.action.focusActiveEditorGroup", "when": "<SOME_MODE>"
    },

Try !editorTextFocus when mapping escape to switch between the active editor and the terminal. That way you will be switching when the text inside isn't focused
When inside the editor, esc would execute the default behavior.
For more on the clauses you can use, see https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts
Does that help?

hey thanks! !editorTextFocus worked like a charm!
Here's the full configuration for switching between editor/terminal using escape, and also remain the  capability to cancel popups.
{
    "key": "escape", "command": "workbench.action.terminal.focus", "when": "!editorTextFocus"
},
{
    "key": "escape", "command": "workbench.action.focusActiveEditorGroup", "when": "terminalFocus"
},

great, Happy Coding!


make output of children available to parent

perhaps a callback can be supplied: at_spawn or somesuch - which is invoked as new processes are spawned.

because children share stdout of parent (I believe that the stdout of a child is used internally as the comm channel between child and parent), this isn't really doable in a simple manner.
For now, let's just let users of this library implement their own comm mechanisms on top of the built in messaging.  as a need arises we can add crap.


remove deprecated function

React.unmountComponentAtNode is deprecated, it will cause a warning.

Nice, Thanks!


Update http links

@NextTurn : Thanks for your contribution! The author, @HeidiSteen, has been notified to review your proposed change.

LGTM -- thanks for the contribution.
#sign-off
#please-sign-off


uwsgi-sloth  latest_5mins.html fails when timezone uwsgi does not match timezone of user running uwsgi-sloth

My uwsgi logging is in utc, the users typically have timezone 'Europe/Amsterdam'.
running  uwsgi-sloth start  gives:
(v) harm@server:~/uwsgi-sloth$ uwsgi-sloth start -c myconf.conf
[2019-02-28 11:38:14,005] uwsgi_sloth INFO: Start from last savepoint, last_log_datetime: 2019-02-28 11:33:14.005028
[2019-02-28 11:38:20,828] uwsgi_sloth INFO: Rendering HTML file /home/harm/uwsgi-sloth/html/html/latest_5mins.html...

As the uwsgi logging timestamps are in UTC (eg: "Thu Feb 28 10:40:00 2019") uwsgi-sloth does do the lookup for the last 5 minutes correctly.
Result
latest_5mins.html  is always empty ( Slow / Total requests ==  0 / 0 )
Expeced Result
latest_5mins.html shows the last 5 minutes.
html output should use the timezone of the user.
The parsing of the uwsgi logging should be able to deal with the timezone difference between report and uwsgi logging.

Note workaround as mentioned in #9 does work, if I set export TZ=Europe/Amsterdam before running uwsgi-sloth start, then I do get output in latest_5mins.html.
But then the rendered html files show incorrect (utc) timstamps. I'd expect the html to render in the timezone as the users runs in.


Check EXO,ClimateVUE,and troll - are SNs in logger files? If yes, put into design table

SP will check logger code

I added serial numbers for TEMPEST instruments, which seems good enough for v1-0? But feel free to reopen.


Add Docker images to build with crypto backends for Windows, and include cross-builds

Right now, we have -fips tags, but they're limited to building on Linux targeting Linux.
We know that some people do build on Linux targeting Windows. It would help if we provide a tag to do that, rather than forcing them to manually configure GOEXPERIMENT in this particular case.
We also have no FIPS-preconfigured Windows builders, whether targeting Windows or Linux. I don't think we've identified any teams that build this way, but it seems reasonable to fill out the build matrix to have something ready for anyone who does.
We need a new naming scheme for this. I think dropping simple -fips- and mentioning the backend is needed. Simplest is to use the goexperiment string, like:

Tag
Build platform
Target platform

.../microsoft/golang:1.21-opensslcrypto-bullseye
Linux
Linux

.../microsoft/golang:1.21-cngcrypto-bullseye
Linux
Windows

.../microsoft/golang:1.21-opensslcrypto-windowsservercore-ltsc2022
Windows
Linux

.../microsoft/golang:1.21-cngcrypto-windowsservercore-ltsc2022
Windows
Windows

Something to perhaps point out more directly in our readme is that we don't produce runtime images. These (and the non-FIPS images for that matter) are all meant to be used for builds, not deployment.

Related: https://github.com/microsoft/go/issues/695
We could also consider adding e.g. golang:1.21-opensslcrypto-compelfips-bullseye tying in with https://github.com/microsoft/go/issues/928

Now that we have systemcrypto in 1.21, we can keep the old tag names, but make them usable for cross-building:

Tag
Build platform
Target platform

.../microsoft/golang:1.21-fips-bullseye
Linux
Linux

.../microsoft/golang:1.21-fips-bullseye
Linux
Windows

.../microsoft/golang:1.21-fips-windowsservercore-ltsc2022
Windows
Linux

.../microsoft/golang:1.21-fips-windowsservercore-ltsc2022
Windows
Windows

https://github.com/microsoft/go-images/pull/238 produced a set of rc images that seem to work as expected--a sample:
golangpublicimages.azurecr.io/nightly/oss/go/microsoft/golang:1.21-rc-fips-cbl-mariner2.0
golangpublicimages.azurecr.io/nightly/oss/go/microsoft/golang:1.21-rc-cbl-mariner2.0
golangpublicimages.azurecr.io/nightly/oss/go/microsoft/golang:1.21-rc-fips-windowsservercore-ltsc2022

We should note in the Docker repo that our Windows images don't have GCC so can't cross-compile to Linux+cgo for opensslcrypto. I think we're only aware of teams needing to cross-compile from Linux -> Windows, so I don't think this is an active concern. This also isn't a change from pre-1.21, the scenario is just easier to bump into with fancier build support in the image. 🙂


pip install deepspeed error ：Getting requirements to build wheel did not run successfully.

(venv) D:\test_pograming\Yi-main>pip install deepspeed
Collecting deepspeed
Using cached deepspeed-0.14.0.tar.gz (1.3 MB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [23 lines of output]
[WARNING] Unable to import torch, pre-compiling ops will be disabled. Please visit https://pytorch.org/ to see how to properly install torch on your system.
 [WARNING]  unable to import torch, please install it if you want to pre-compile any deepspeed ops.
DS_BUILD_OPS=1
Traceback (most recent call last):
File "D:\test_pograming\Yi-main\venv\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "D:\test_pograming\Yi-main\venv\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\test_pograming\Yi-main\venv\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\HeSongsheng\AppData\Local\Temp\pip-build-env-25w0rr_x\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\HeSongsheng\AppData\Local\Temp\pip-build-env-25w0rr_x\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
self.run_setup()
File "C:\Users\HeSongsheng\AppData\Local\Temp\pip-build-env-25w0rr_x\overlay\Lib\site-packages\setuptools\build_meta.py", line 487, in run_setup
super().run_setup(setup_script=setup_script)
File "C:\Users\HeSongsheng\AppData\Local\Temp\pip-build-env-25w0rr_x\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
exec(code, locals())
File "", line 148, in
AssertionError: Unable to pre-compile ops without torch installed. Please install torch before attempting to pre-compile ops.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
my system is windows10, and this enviroment`s cuda version is 11.7, my pytorch version is 2.0.0, so why it cannot install ,god please help me QAQ,

pleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleasepleaseplease help help me TAT

can you run the following commands in the same venv? it seems there is a problem with your torch installation
torch.cuda.is_available() torch.cuda.device_count() torch.cuda.get_device_name(0)

thanks, it looks like theres something wrong with my cuda enviroment, i will reinstall my system, its too confusing


Access restriction to model attributes

From: https://groups.google.com/forum/?fromgroups=#!topic/sailsjs/AM452zgLH-Y
As I understand policies allow restriction of viewing specific models. It would be important for larger apps to provide more granularity here, and allow restriction of viewing specific attributes/properties of a given model based on a policy.

What about output policies @mikermcneil? Similar to the current policies but applied only after the controller pass, and before the response gets sent. Separating them would make sense as they're not the same and the workaround from @mphasize seems quite close to a solution, though it's just not clean.
To me it sounds like a powerful idea to have, it's one of the biggest things I'm missing at the moment. Being able to modify the response on a different layer than the actual controller and apply this policy on a controller basis (same as current).
It may seem like the use case is small, but I find when trying to do any medium size project this comes up as a requirement. It actually comes up as a requirement way way earlier when we need to build a backoffice and modify protected attrs only from certain controller.
Any thoughts?

These seem related:

https://github.com/balderdashy/sails/issues/2423
https://github.com/balderdashy/sails/issues/352
https://github.com/balderdashy/sails/issues/2729

This should be done upon select, not response. It's overhead per-row. It's not needed.

@RWOverdijk not sure, sometimes I need to get all attributes in the controller from a query, like it works with current implementation of "protected". But I only want to send to the user specific ones based on the controller (but would be really awesome to even configure on a per action basis).
Protection as it is, it's great! What's missing is the ability to granularly attach protection to controllers <-> attributes.

@albertpeiro I understand what you're saying, but must advice against it for a couple of reasons.
The first reason is the fact that you're talking about needing all attributes, but wish to send back only a couple. If you need all of them, that probably means that you don't use the blueprints.So you might as well implement this yourself. But, reason two, is performance. Checking every attribute of every entity of every collection every time might become a heavy task to perform.

But I only want to send to the user specific ones based on the controller

I can understand the use case here, but we can't make everything infinitely configurable. sails.js gives you a lot out of the box, but at some point you have to start writing code :) I started sails-permissions as a starting point for dynamic policies, which will include attribute-level control of this kind, but which isn't yet implemented. I'd be interested in hearing more of your ideas on this over in sails-permissions.

I can understand the use case here, but we can't make everything infinitely configurable. sails.js gives you a lot out of the box, but at some point you have to start writing code :)

Absolutely. I didn't mean to be pushy, just trying to build a case and see if it's important enough and what benefits it could bring. And see what's the best way to tackle this problem, and if we can/should, add to sails/build other modules.
My case
The way I see it is we have this awesome MVC framework with a powerful mix of CoC sort of thing, but still easily extensible and presumably hyper-performant. One of its most powerful features is it has Models separated from Controllers. Now, one of the main advantages I see in using controllers is to map controllers to "perspectives" of the application, or points of view. For example: backoffice tool wants to be able to modify a User's email. On any other part of the application the User's email cannot be accessed because it's public (list of users, list of content with populated users). In the User's profile, the user needs to be able to see, and edit their email.
For me the whole point of having an MVC at all is to be able to modify/serve data from a different perspective (in a different way). From a Backoffice perspective, from a public user perspective, from a private users... and inside each of those I may need some attrs for a specific model in one action, or all of them in a different action. If you have perspectives you inevitably have different data needs, otherwise you most probably wouldn't have perspectives in first place. Considering all an API delivers is data. Data most of the times will be different. If data is different then why not build something to handle data delivery differently for each controller and action? To me that's the question we need to ask. Generalistic and tool-focused.
When I look at this case I can't help thinking this is way too common to not help solving it, and I'm like "damm if Sails had this built in it'd blew my mind and most importantly it'd relieve me from a huge pain", in the same way Sails blew my mind and relieved me from massive pain when I saw the CORS, blueprints, database & adapters,...
When you say we can't build everything you're right. But somehow Sailsjs manages to have an INSANE amount of things built in that required little config with a lot of extensibility. And that is the reason I use it. Hence, my proposal. This is not a minimalistic framework.
About performance
I'm not biased towards any solution here. I just wanted to get my point across for the need of this on sails. But when it comes to performance we must not forget to look at the forest and not just the tree. So let's look at the system and not just the server. If you have different views that require different data (that's why you have different views), then chances are most of the times some attributes (or many!) are not going to be needed. You're sending that data on every request and it's not needed by the client.
That is not high-performance either, and arguably, depending on the type of application, especially mobile, is even worse than having a server loop over a pages attributes (because at least you pay the bill, and not your users ;) )
Frameworks like GWT do some auto optimisations to ensure only the needed attributes are sent per view.
@tjwebb thank you for sharing sails-permissions I do like the idea of it. But I think tying data delivery granularity to an ACL is focusing only on part of the problem. I'd love to move Sails to production environments where I can apply performance optimisations outlined above.

I am using this http://sailsjs.org/documentation/reference/waterline-orm/records/to-json to remove unwanted attributes
module.exports = {
attributes: {
name: 'string',
phoneNumber: 'string',
// Override the default toJSON method

toJSON: function() {
  var obj = this.toObject();
  delete obj.phoneNumber;
  return obj;
}

}
}

Hello, I know this topic is silent for a while now, but re-animating it : I think the proposed solutions are good, but not complete, as they forget to account for association data.
Many models might have associations setup, and the blueprint API will allow the setting of nested association data during update or create actions. In order to make sure all the protected attributes are well removed from the tree data structure, I made the following (modified) implementation. What do you guys think about it?
/**
 * removeProtectedAttributes policy
 *
 * @module      :: Policy
 * @description :: Simple policy to protect API calls from setting attributes mark as "private"
 *
 */

 var actionUtil = require( '../../node_modules/sails/lib/hooks/blueprints/actionUtil' );

 module.exports = function ( req, res, next ) {

     var model = actionUtil.parseModel( req );
     if ( model.protectedAttributes ) {
         var attributes = model.protectedAttributes;
         _.each( attributes, function ( attr ) {
           if ( req.params.hasOwnProperty( attr ) ) {
               delete req.params[ attr ];
           }
           if ( req.query.hasOwnProperty( attr ) ) {
               delete req.query[ attr ];
           }
           if ( req.body.hasOwnProperty( attr ) ) {
               delete req.body[ attr ];
           }
         });
     }
     cleanAssociationData(model,req.body)
     return next();
 };

 // association data can be given only via body parameters
 // This method will recursively check the model definition tree for possible association and clean the related request body data if present
 function cleanAssociationData(model, reqAssosData){
   if(!model || !reqAssosData) return;
   for(var attributeName in model.attributes){
      var attr = model.attributes[attributeName];
      if(attr.model){
        // if a simple 1 to 1 association
        var associationModelName = attr.model;
        var associationModel = sails.models[associationModelName];
        var associationAttributes = associationModel.attributes;
        var associationProtectedAttributes = associationModel.protectedAttributes;
        if(associationProtectedAttributes && reqAssosData[attributeName]){
          for (var assosDataKey in reqAssosData[attributeName]) {
            var associationAttrValue = reqAssosData[attributeName][assosDataKey]
            if(associationProtectedAttributes.indexOf(assosDataKey) != -1) delete reqAssosData[attributeName][assosDataKey];
            // Check if current data related to an association, if yes, recursively clean it too.
            var subAssociationKey = associationAttributes[assosDataKey] ? associationAttributes[assosDataKey].model || associationAttributes[assosDataKey].collection : false;
            if(subAssociationKey) cleanAssociationData(sails.models[subAssociationKey],reqAssosData[attributeName][assosDataKey]);
          }
        }
      }else if(attr.collection){
        // if a 1 to many associastion
        var associationModelName = attr.collection;
        var associationModel = sails.models[associationModelName];
        var associationAttributes = associationModel.attributes;
        var associationProtectedAttributes = associationModel.protectedAttributes;
        if(associationProtectedAttributes && reqAssosData[attributeName] && reqAssosData[attributeName].length){
          for (var i = 0; i < reqAssosData[attributeName].length; i++) {
            for (var assosDataKey in reqAssosData[attributeName][i]) {
              var associationAttrValue = reqAssosData[attributeName][i][assosDataKey]
              if(associationProtectedAttributes.indexOf(assosDataKey) != -1) delete reqAssosData[attributeName][i][assosDataKey];
              // Check if current data related to an association, if yes, recursively clean it too.
              var subAssociationKey = associationAttributes[assosDataKey] ? associationAttributes[assosDataKey].model || associationAttributes[assosDataKey].collection : false;
              if(subAssociationKey) cleanAssociationData(sails.models[subAssociationKey],reqAssosData[attributeName][i][assosDataKey]);
            }
          }
        }
      }
    }
  }

@mikermcneil
it would be awesome if Waterline could have something like JMSSerializerBundle for Symfony.
In Entity I define property and define some serialize groups for which this property will be serialized, like:
/**
     * @var string
     *
     * @ORM\Column(name="slug", type="string", length=255, nullable=true)
     * @JMS\Expose
     * @JMS\Groups({"detailed"})
     */
    private $slug;

    /**
     * @var ArrayCollection|Product[]
     *
     * @ORM\OneToMany(targetEntity="AppBundle\Entity\SearchTag", mappedBy="menu")
     * @JMS\Expose
     * @JMS\Groups({"list"})
     */
    private $searchTags;

In controller I can set either "detailed" or "list" serialize group and get entity with different serialized fields.

As anyone check my previous fix? This is a working solution and could be integrated.


[Enum Request] report 5811 "Calc. Inventory Value - Test" - CalcBase

Describe the request
CalcBase: Option " ","Last Direct Unit Cost","Standard Cost - Assembly List","Standard Cost - Manufacturing";
Could you please make global var CalcBase in R5811 an Enum to existing enum 5899 "Inventory Value Calc. Base" like has been done previously in report 5899 "Calculate Inventory Value"?
Additional context
We are in dire need for an extra enum value 'Standard Cost - Item/SKU' to supply a customer customization
Internal work item: AB#495835

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 15245.


test: add test cases for parse date and random object

This PR is still failing tests. This is to show that the complex object case is failing.

I agree that the "smartness" of checking if a value is a date by regexing it is fair enough.
But at least the "get random object" test should pass because 99% of the developers as you say would expect a date inside an object coming as a Date object from a JSON response. Same for the WebSocket failure.

Havent fully gone through the code as I am on the go, but I'll check it later. Should be easy enough to check

I just cloned your fork and ran the tests.
I do believe the test case you wrote is still one of these edge-cases that cannot be solved; as the toEqual expects property g to be a string but eden parses that into a Date since the value of g looks like a Date. Therefore a string representing a Date is not equal to an actual Date object.
As I mentioned in my previous comment; you cannot really solve this ambiguity problem (whether to parse a string that looks like a date or not) without the actual specification TypeBox schema definition.


Selective deployment is not working as per include/exclude rule

Describe the bug
In selective deployment file, I have not added any object as a part of deployment. But it deployed multiple objects  from development to Next stages. My selective deployment file contains only exclusion rules with objects.
Logs also stating that rule defined for inclusion is  '0'. But it still deployed almost all objects to the next stages.

To Reproduce

Add parameter replacement of an object in configuration file.
Don't add any object as a part of inclusion rule for selective deployment. Not even the above object in which we have replaced it parameter as per next stages.
Now deploy it..

**Expected behavior **
It should deploy only those objects which is a part of inclusion. i.e. If an object is prefixed with '+' or without any prefixed should be deployed into next stages.
Screenshots
Log screenshot

Logs file has been to your mail<EMAIL_ADDRESS>Version of Publish Azure Data factory (task):

1.1.643

The process is clearly saying that 264 out of 380.
If you want to exclude more object - extend your 'exclusion' file.
Log line 1415 doesn't mean that no objects will be deployed. That simply means: no inclusion rules have been found.

The process is clearly saying that 264 out of 380.
If you want to exclude more object - extend your 'exclusion' file.
Log line 1415 doesn't mean that no objects will be deployed. That simply means: no inclusion rules have been found.

I observed that when we have single object as part of inclusion than it is deploying only that object. Those objects are not get deployed which not associated with either inclusion or exclusion.
Lets say we have 20 objects and in that 10 objects are part of inclusion, 5 objects are part of exclusion and remaining 5 objects is not a part of this rule file. So here only 10 objects are get deployed into next stage not 15 objects.
So based on this observation, If objects are not a part of inclusion than it should not get deployed into next stage.

I observed that when we have single object as part of inclusion than it is deploying only that object. Those objects are not get deployed which not associated with either inclusion or exclusion.
Lets say we have 20 objects and in that 10 objects are part of inclusion, 5 objects are part of exclusion and remaining 5 objects is not a part of this rule file. So here only 10 objects are get deployed into next stage not 15 objects.
So based on this observation, If objects are not a part of inclusion than it should not get deployed into next stage.

That's correct. You should not use both filtering method together, it's not supported as the doc says:

Bear in mind that Includes and Excludes lists are rules out each other.
Objects would be excluded from deployment only if Includes list remains empty.
When both lists are empty - all objects going to be published.
If you ever exclude some objects - these rules have priority over 'includes'.
Objects may not be part of the rule file, however, they will be associate to one of the group anyway.
I hope that helps.

That's correct. You should not use both filtering method together, it's not supported as the doc says:

Bear in mind that Includes and Excludes lists are rules out each other.
Objects would be excluded from deployment only if Includes list remains empty.
When both lists are empty - all objects going to be published.
If you ever exclude some objects - these rules have priority over 'includes'.
Objects may not be part of the rule file, however, they will be associate to one of the group anyway.
I hope that helps.


Font shorthand incorrectly processed

font: normal 300 100%/1.5 sans-serif; becomes font:400 300 100%/1.5 sans-serif, which is not interpreted correctly by browsers.

font: normal small-caps 400 medium Georgia, sans-serif; becomes font: 400 small-caps 400 medium Georgia, sans-serif; still :(

I've opened #529 as it's a slightly different case.


"fatal error, unexpected signal during runtime execution" on windows intermittently

On windows, a "fatal error, unexpected signal during runtime execution" occurs randomly during container IO

cause: https://github.com/Microsoft/go-winio/issues/41


Update cosmic module

I think the only issue is with the categories fetching using Promise.all
Change it to this and it should work:
  let categoriesData = []
  for (const categoryType of categoryTypes) {
    categoriesData.push(await getDataByCategory(categoryType?.id))
  }

cc @jazibsawar

I've opened a PR for the fix in the cosmic module. Promise.all will perform the requests parallelly which in my opinion is a better approach in this scenario.


Stevenic/adaptive fixes

Description

Added missing LG converter.
Fixed a case conversion issues.
Worked around a serialization issue for cards coming from LG.

Pull Request Test Coverage Report for Build 127482

13 of 13 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 79.863%

Totals

Change from base Build 127463:
0.01%

Covered Lines:
12433

Relevant Lines:
14856

💛  - Coveralls


Expose Additional Floating-UI Props for popup

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
Expose additional options for popup to take advantage of more floating-ui features.
Compute Position
This needs the strategy option available: https://floating-ui.com/docs/computePosition#strategy
Middleware
size: https://floating-ui.com/docs/size
autoplacement: https://floating-ui.com/docs/autoPlacement
hide: https://floating-ui.com/docs/hide
inline: https://floating-ui.com/docs/inline
There's also a typo in the docs where it's typed 'middelware' here, and in the interface as 'Middlware` here
This is prompted from the discussion on discord here
What type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
No response

Adding one more feature request: hover delay time

Another request: better error handling when the action fails to discover the paired popup element (or it's missing outright)

Implemented as part of: https://github.com/skeletonlabs/skeleton/pull/1421


Roy2pushkar patch 3

thanks @SaraJaoude  for help...now i close this pull request and open  a fresh one .


[SPARK-27062] CatalogImpl.refreshTable should recreate cache with received tableName.

If CatalogImpl.refreshTable() method is invoked against a cached table, this method would first uncache corresponding query in the shared state cache manager, and then cache it back to refresh the cache copy.
However, the table was recached with only 'table name'. The database name will be missed. Therefore, if cached table is not on the default database, the recreated cache may refer to a different table. For example, we may see the cached table name in driver's storage page will be changed after table refreshing.
Actually, CatalogImpl registers cache with received table name. Therefore, I would like to propose aligning the behavior. RefreshTable method should reuse the received table name instead.
What changes were proposed in this pull request?
Align the behavior of CatalogImpl.cacheTable and CatalogImpl.refreshTable, such that they both register query with received tableName.
How was this patch tested?
It was tested with existing unit tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Jenkins, test this please

Jenkins, add to whitelist


Generalized line unfolding in parser (issue #8)

Ignoring (CR)LF followed by a single whitespace char is now done in peek()
and therefore is enforced in all processing.
This version has been able to parse a full ics file exported from Google (the very one with which I encountered issue #8).
This is work in progress, and my actual first non utterly trivial code in Rust, don't hesitate to say if the approach taken doesn't suit you, or if assumptions about efficiency are wrong etc.
Some choices:

in consume_while(), tried to minimize the copying operations, but it can't return a str (slice)
anymore in any case.
for simplicity, I discarded CR completely from peek_at(). If you agree with this, some conditions
downstream (consume_eol()...) can be simplified.

Thanks, this is fantastic! I haven't looked closely through consume_while yet but I wouldn't have cared about the inefficient method.
Note this was one of the first things I did in Rust (and I come from a higher-level language) so code might actually be unidiomatic and imperformant (because I didn't care).

Also I think you wanted to reference https://github.com/untitaker/rust-vobject/issues/8 instead of #2

FTR

for simplicity, I discarded CR completely from peek_at()

That seems reasonable, but please do the simplifications (if you want) in a separate PR

Thanks for the review and the positive appreciation ! I'll take the remarks into account.
Speaking of CR, it wasn't to make the existing code simpler, but rather to avoid make the new one more complicated. I could make the current PR emit CR if not followed by LF in peek_at and then a new one that would discards CR again (and also the downstream tests), but the intermediate would be more complicated than the current one (actually tried to do that and gave up after a short while)
As a side note, I also come from a Python background, and funny thing (read your blog post), would like to make a CalDAV server in Rust (partly because I need one, partly because that involves learning a wide array of things).

I did the hiding of peek_at() behind peek() as an inline, like the idea.
For the various Some('x', 1), this has been abstracted away behind the new consume_only_char()
Hope that suits you, will look closer to that CR thing later, have to go right now.

Excellent, thanks!

As a side note, I also come from a Python background, and funny thing (read your blog post), would like to make a CalDAV server in Rust (partly because I need one, partly because that involves learning a wide array of things).

"learning a wide array of things" is one side, the other one is "it's incredibly hard".
I recommend SabreDAV as a reference on how to implement things properly, in case the spec is either unclear or incomprehensible.

thanks for the advice ! The devil lies in practical details indeed, I wouldn't have imagined querying to be so complicated. We'll see, I don't mind trashing the project if it becomes really painpful and does not qualify as training anymore.

For a start you can ignore queries and just return all items of the collection, it's correctly handled by most clients (although imperformant).
Feel free to email me questions if you have some.

@gracinet How's it going with your CalDAV project?

@untitaker hey, thanks for asking ! I have a very partial implementation for CardDAV (simpler), but had to put in on standby to get back to more down-to-earth concerns, and now I haven't played with it since around march I think.
If I remember correctly, last time I played with it, I was trying to use a cache to avoid reparsing the collections at each PROPFIND request, which to be fair is not necessary: from the measurements I got, even without such a cache, performance is already an order of magnitude better than radicale's, but it'd be again two orders better with it ;-)
I can show you if you're interested, of course. What I'd really need to get further would probably be a genuine need of it somewhere.

Are you saving every collection as one file each? I don't see a need for
parsing if you mirror the filestructure that is exposed via WebDAV directly
onto the filesystem, i.e. have one file per vcard.
On Thu, Jul 28, 2016 at 03:13:02PM -0700, Georges Racinet wrote:

@untitaker hey, thanks for asking ! I have a very partial implementation for CardDAV (simpler), but had to put in on standby to get back to more down-to-earth concerns, and now I haven't played with it since around march I think.
If I remember correctly, last time I played with it, I was trying to use a cache to avoid reparsing the collections at each PROPFIND request, which to be fair is not necessary: from the measurements I got, even without such a cache, performance is already an order of magnitude better than radicale's, but it'd be again two orders better with it ;-)
I can show you if you're interested, of course. What I'd really need to get further would probably be a genuine need of it somewhere.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/untitaker/rust-vobject/pull/9#issuecomment-236041095

yes, one file per collection is, IIRC what radicale does, but it doesn't matter that much: the clients I've played with (in CardDAV context) would request the properties of all the items at once, or something alike (don't remember that well).
Anyway, it's not very relevant, that was just to say I was looking at something that I knew very well wasn't really needed, one way or the other instead of finishing to implement the standard, because it was an interesting exercise in the language.


Is this project still maintained?

Hi there,
I just have a question if this project is still being maintained?
I see there are quite few issues opened and there hasn't been any update since January 2024.
Any update about the project's state would be very welcome.

Yeah, but no too fast..


Disabled prop for Button component

A built-in Button component was introduced the other day:
https://github.com/facebook/react-native/commit/2ae73ffa002221fde8011b012ea5e57e22979232#commitcomment-19393782
It could use a disabled boolean prop to handle states where the button is visible but cannot be pressed. This is expected to look standard and native on iOS and Android.
Please test the documentation generation with the website to make sure the prop is correctly documented: https://github.com/facebook/react-native/tree/master/website

Fixed via https://github.com/facebook/react-native/commit/c32ab7e60820eeca4f13722e652251b3e67d795e


feat(APIScheduledEvent): add image prop

Please describe the changes this PR makes and why it should be merged:
Reference Discord API Docs PRs or commits:

https://github.com/discord/discord-api-docs/pull/4380

Upstream PR merged


Ionic Serve is not working

Short description of the problem:
When I run:
ionic serve
it opens the browser and I cannot type Ionic Server Commands in console, like:
restart or r to restart the client app from the root
  goto or g and a url to have the app navigate to the given url
  consolelogs or c to enable/disable console log output
  serverlogs or s to enable/disable server log output
  quit or q to shutdown the server and exit

Post the output of ionic info below please
ordova CLI: 6.4.0
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 0.0.48
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v7.2.1
Xcode version: Not installed

Same issue ! Here

I have the same issue. No error shown, App is being served but no commands possible.
System information:
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 0.0.47
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v6.9.2
Xcode version: Xcode 8.2.1 Build version 8C1002

Please Uninstall app related software and clear cache. install all latest . I hope , it will help you.
Thank you.

@DILEEP-YADAV Thanks four your help. I uninstalled Ionic and Cordova globally, cleared the cache and installed both again. The result is the same.
But I found some other interesting fact. If I try to use ionic serve with an older project that was created with an older Ionic cli version then it works as expected!
And if I just follow the step described in "Getting started" : sudo ionic start --v2 myApp
and I change dir to myApp and try ionic serve the console looks like this:
Christophs-MBP:myApp user$ sudo ionic serve

> ionic-hello-world@ ionic:serve /Users/user/Documents/myApp
> ionic-app-scripts serve "--v2" "--address" "<IP_ADDRESS>" "--port" "8100" "--livereload-port" "35729"

[19:49:18]  ionic-app-scripts 1.0.0
[19:49:18]  watch started ...
[19:49:18]  build dev started ...
[19:49:18]  clean started ...
[19:49:18]  clean finished in less than 1 ms
[19:49:18]  copy started ...
[19:49:18]  transpile started ...
[19:49:21]  transpile finished in 2.60 s
[19:49:21]  webpack started ...
[19:49:21]  copy finished in 2.71 s
[19:49:28]  webpack finished in 7.06 s
[19:49:28]  sass started ...
[19:49:29]  sass finished in 1.23 s
[19:49:29]  build dev finished in 10.90 s
[19:49:29]  watch ready in 10.95 s
[19:49:29]  dev server running: http://localhost:8100/

No possible commands listed. Nor does I the console react to any.

same issue we have with both mac and windows.. any solution to this?

npm cache clean
npm install -g ionic@beta cordova (or npm install -g ionic cordova)

thank you for your reply.
I tried npm cache clean then  npm install -g ionic cordova but still same problem.

thank you for your reply.
I tried npm cache clean then npm install -g ionic cordova but still same
problem.
On Fri, Feb 17, 2017 at 3:10 PM, Dolce Key<EMAIL_ADDRESS>wrote:

npm cache clean
npm install -g ionic@beta cordova (or npm install -g ionic cordova)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/driftyco/ionic-cli/issues/1810#issuecomment-280633454,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARVLijA8_WFHfdILw8paG9B7gf0Wqg8oks5rdY4igaJpZM4LVgqB
.

You also need to delete and recreate new "node_modules".
Find more here...

It seems the problem is connected to the command ionic start. In app projects created with ionic start of an older ionic cli the command ionic serve works as expected. So to reproduce the problem just update to the latest cli, start a new app project with ionic start, go into the new app directory and try ionic serve. It does not work as expected.
By the way this basically the same issue as #1898.


i18n(ko-KR): update routing-reference.mdx

Description (required)

update routing-reference.mdx
#10352

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

ko/reference/routing-reference.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Implement Article.trim()

Hi @mkhatib,
PR based on #52.
These methods depend on the Layout component and initialized schema at editor.js. I don't know if this is right implmentation. Please can you look at them.
Some of the effected methods:

getFirstTextComponent
getLastTextComponent

Thanks for kicking this off @saadshahd ! I left a comment regarding the usage of getFirst/LastTextComponent

@mkhatib You're welcome. Please take a second look https://github.com/saadshahd/carbon/commit/b488463fe83b57cdf657e73b63047584ada7fe02.

@mkhatib Please check updates.

:+1: Thanks for the updates!


Fix mypy Error and Correct Platforms in README

🗣 Description
This PR fixes a mypy error and corrects an oversight in the project's README.

💭 Motivation and context
The latest cisagov/action-apb triggered GitHub Actions run had the following error:
src/vdp_scanner.py:258: error: Argument 2 to "str" has incompatible type "Optional[str]"; expected "str"

In the process of resolving that issue I noticed that the README did not have the correct platforms listed so I corrected them while I was working on the repo.

🧪 Testing

Automated tests pass. A local testing image ran as expected.

✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

Switched this to a release candidate because I will be stacking in multiple PRs for the final 0.0.5 version.


Expose voiceOverEnabled flag for greater accessibility control

Announcing and changing the accessibility control during a layout change is not always the desired behavior for some uses of this modal. This PR introduces a flag to disable voice over announcements on demand.

Any news on this?


how to add song in mod folder from scratch

Describe your problem here.
not a problem i just need help
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

im building from lua

Put your song's json , inst and voices in the data/yoursong and songs/yoursongs

i tried that and the music wont play

can you show an example of that?

sure

https://steamuserimages-a.akamaihd.net/ugc/1886472472721001520/7B6F1F4BA1F46C07D911547F2B9EBFEE7D4EB87E/


0041 stabilize multilateration results

Codecov Report

Merging #42 into dev will decrease coverage by 0.24%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##                dev      #42      +/-   ##
============================================
- Coverage     17.06%   16.81%   -0.25%
  Complexity       71       71
============================================
  Files            35       35
  Lines          1014     1029      +15
  Branches         82       85       +3
============================================
  Hits            173      173
- Misses          832      847      +15
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

...exenio/bleindoorpositioning/ble/beacon/Beacon.java
6.74% <0%> (ø)
2 <0> (ø)
:arrow_down:

...ning/location/multilateration/Multilateration.java
20% <0%> (ø)
2 <0> (ø)
:arrow_down:

...ng/location/distance/BeaconDistanceCalculator.java
5.55% <0%> (-4.45%)
1 <0> (ø)

...exenio/bleindoorpositioning/IndoorPositioning.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb2b09...becd714. Read the comment docs.


Maybe there can be an official doc note talking about event delegation

Maybe there can be an official doc note talking about event delegation, in the page of either
https://reactjs.org/docs/events.html
or
https://reactjs.org/docs/handling-events.html
From the following posts:
https://dev.to/thawsitt/should-i-use-event-delegation-in-react-nl0#:~:text=Event delegation is a performance optimization method in the world of Javascript.&text=With event delegation approach%2C instead,read more about it here.
and
https://github.com/facebook/react/issues/13635
It suggests that we should not do event delegation ourselves when doing React.  That's because React already does something similar by only attaching a single listener at the document level.
However, isn't it true that, if the page has 50 or 200 rows in a table, and the programmer is doing

 handleRowClick(i)} ...

then the 200 rows, each would be creating a function?  Maybe 200 functions for once is ok, but what if it is an app that updates this table every 5 seconds?
Then isn't it true that every 5 seconds, 200 new functions are created, and if it is a monitoring app, then it could be lots of functions created but it would depend on the browser's garbage collection.
I think, if the programmer writes
<tr data-index={i} key={i} onClick={handleRowClick} ...

then it is quite ok, because then it doesn't create a new function each time.  Now the programmer can use the ev.target.dataset.index to get to the value  (or the key? but the dataset should be more reliable).
Maybe the fact about not needing event delegation but at the same time, be aware that if possible, don't create extra functions if possible, can be documented in one page of the official docs.  Otherwise programmers have to rely on someone's blog and links to make decision and it is somewhat unofficial info.

Maybe the fact about not needing event delegation but at the same time, be aware that if possible, don't create extra functions if possible, can be documented in one page of the official docs. Otherwise programmers have to rely on someone's blog and links to make decision and it is somewhat unofficial info.

From my experience "creating functions" has virtually no cost at all. If I remember correctly, the React core team did investigate this before proposing Hooks since it's fairly common to create a lot of inline functions inside the render method. And rendering is performance critical so if it's not a problem then, I don't think it's a problem worth solving with event delegation.
Did you measure if event delegation improved the speed of your React application?

Maybe the fact about not needing event delegation but at the same time, be aware that if possible, don't create extra functions if possible, can be documented in one page of the official docs. Otherwise programmers have to rely on someone's blog and links to make decision and it is somewhat unofficial info.

From my experience "creating functions" has virtually no cost at all. If I remember correctly, the React core team did investigate this before proposing Hooks since it's fairly common to create a lot of inline functions inside the render method. And rendering is performance critical so if it's not a problem then, I don't think it's a problem worth solving with event delegation.
Did you measure if event delegation improved the speed of your React application?

I think React "already" does the event delegation for you.  So it is not binding 200 listeners to 200 elements, but just binding one.  The thing is, some programmers might write it so that 200 function instances are created.  So that can still be an issue, and like what I said, what if it is 200 function instances every 5 seconds? Yeah I can try it, but it also depends on Google Chrome, Safari, and Firefox and the various mobile browsers.  Or, what about just documenting that event delegation is not needed in the ReactJS docs? (but also, try your best to write onClick={handleClick} and not create extra functions if you can.

I understand what event delegation is and how React utilizes this pattern

The thing is, some programmers might write it so that 200 function instances are created. So that can still be an issue, and like what I said, what if it is 200 function instances every 5 seconds?

How do you know "creating function instances" is an issue?
Note that the docs specifically talk about performance concerns with creating many functions:

No. In modern browsers, the raw performance of closures compared to classes doesn’t differ significantly except in extreme scenarios.

-- https://reactjs.org/docs/hooks-faq.html#are-hooks-slow-because-of-creating-functions-in-render
I don't think "200 vs 5" is an extreme scenario. I suspect you only notice this after at least 2 or 3 orders of magnitude more. At this point creating functions is probably still only a small percentage of the runtime and virtualisation the better tool to solve performance problems.

Note that the docs specifically talk about performance concerns with creating many functions:

No. In modern browsers, the raw performance of closures compared to classes doesn’t differ significantly except in extreme scenarios.

Isn't that about closures, vs creating 200 functions for the event listeners?
In any event, I think it is good that the programmer can be aware of the two methods, and if one is a better version, and it is almost free of charge, why not?  Regarding not needing event delegation in React, I think it is worth it to have it included in the official docs.

Isn't that about having a closure, vs creating 200 functions for the event listeners?

It's answering "Are Hooks slow because of creating functions in render?". Maybe I'm not understanding what you're proposing. Could you share a code example of the two different approaches you think should be documented?

In any event, I think it is good that the programmer can be aware of the two methods, and if one is a better version, and it is almost free of charge, why not? R

We still haven't established if one version is better and how much better it is. If one only provides marginal gains, but requires more code, we don't need to mention it.

Isn't that about having a closure, vs creating 200 functions for the event listeners?

It's answering "Are Hooks slow because of creating functions in render?". Maybe I'm not understanding what you're proposing. Could you share a code example of the two different approaches you think should be documented?

In any event, I think it is good that the programmer can be aware of the two methods, and if one is a better version, and it is almost free of charge, why not? R

We still haven't established if one version is better and how much better it is. If one only provides marginal gains, but requires more code, we don't need to mention it.

Regardless how the two versions are written, "not needing to use event delegation in React" is a separate topic.
As for the two version, I have mentioned it in the original post.
It is when arr is an array of 200 items,

  arr.map((e, i) =>
e.num
);

vs

  arr.map((e, i) =>
 handleRowClick(i)}>e.num
);

As for the two versions, I have mentioned it in the original post.

Ok, so you are talking about creating functions during render. Seems to me this is what the FAQ answer is referring to.

I am saying it should be mentioned in the official docs. It should be mentioned regardless of how the two versions are written.

You can write JavaScript (or any program for that matter) in (virtually) infinite ways. That doesn't mean we should document every single approach but only the ones that do make sense.
The docs are about learning React and being productive with it. Documenting multiple patterns for the same problem should only be happening if these patterns have different trade-offs. Right now it seems to me your only argument is "another way exists, so we should document it".

No, I am saying documenting "not needing to use event delegation in React".  Can you re-read the post.

As for the two versions, I have mentioned it in the original post.

Ok, so you are talking about creating functions during render. Seems to me this is what the FAQ answer is referring to.

I am saying it should be mentioned in the official docs. It should be mentioned regardless of how the two versions are written.

You can write JavaScript (or any program for that matter) in (virtually) infinite ways. That doesn't mean we should document every single approach but only the ones that do make sense.
The docs are about learning React and being productive with it. Documenting multiple patterns for the same problem should only be happening if these patterns have different trade-offs. Right now it seems to me your only argument is "another way exists, so we should document it".

No, I am saying documenting "not needing to use event delegation in React". Can you re-read the post.

Please Document it whether to use it or not and what tradeoffs can happen and in which scenarios. So that we have better understanding of React like what to do and what not is required.

We explain the event system in the docs for events here. We're not going to document that you don't need to do delegation.


Modified the marketplace-publishers-guide

Updated the content and performed an edit pass for the marketplace-publishers-guide markdown file.

@jm-aditi-ms : Thanks for your contribution! The author, @v-josepm, has been notified to review your proposed change.

close per email