Fix cursor issue in room name input

Details

Fix the issue "When user inputs a space in middle of room name, cursor moves to the end"
Fixed Issues

$ https://github.com/Expensify/App/issues/7471
Tests

Create new room
Enter room name
Add space in middle of the room name

QA Steps

Create new room
Enter room name
Add space in middle of the room name

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

https://user-images.githubusercontent.com/25876548/153271608-47ac7210-1b1e-46df-b2fc-335011a34bb0.mov
Mobile Web

https://user-images.githubusercontent.com/25876548/153272750-cddbdd77-8bd5-4456-b977-9ca6d3b119f6.mov
Desktop

https://user-images.githubusercontent.com/25876548/153270674-d589cf44-59c6-452e-967c-74bceea48cf1.mov
iOS

https://user-images.githubusercontent.com/25876548/153274953-1f4c8a3e-df68-4f4c-81a8-ea2f59056cf4.mov
Android

https://user-images.githubusercontent.com/25876548/153272925-740170dc-d1fd-404d-801a-e038ae2b76dd.mov

🚀 Deployed to staging by @luacmartins in version: 1.1.39-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Issue 1 -
Title- [Medium] Chrome +Jaws : Form field 'Room name' is not associated with their visible label.
Actual - The 'Room value' field is not announced with their visible labels.
Screen reader only read the value of the Room name, not reading the Label 'Room name' along with the value.
Expected -The visible label of a form field is programmatically associated with its form field so that assistive technology announces the label with the form field.
Screen reader should read like "Abc  room name editable text box".
WCAG failure - 1.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web (Chrome + Jaws)
Note - Due to installation of build not able to check on Android
https://user-images.githubusercontent.com/97600950/156990129-04a1ec45-7c8f-4937-9570-b0dfcb95fa27.mp4
Issue 2 -
Title- [Medium] Chrome +Jaws : 'Room Name' text edit field is not marked as required and announced.
Actual - The fields 'Room name' text field is required to be filled but is not announced as required and no visual "" sign for required field.
Screen reader only read the value of the Room name, not reading the Label 'Room name' along with the value.
Expected -If the form element is required, it should be announced as such for the screen reader users and visual "" sign for required field should be there. Screen reader should read like "Abc  room name editable text box".
WCAG failure - 1.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web (Chrome + Jaws), Desktop (MAC), iOS(Voiceover), Mobile - web(Safari + Voiceover)
Note - Due to installation of build not able to check on Android
https://user-images.githubusercontent.com/97600950/156990162-e324cea1-9dea-4ba6-9dcf-bb0bcebc15da.mp4
Issue 3 -
Title-[High] Chrome + Jaws: Screen reader : Error message is not announced by the screen reader.
Actual - Screen reader does not announce any inline error message appear below to text boxes.
Expected - Inline error message should be conveyed to the users as soon as it appear on the fields so that user can resolve the error.
WCAG failure - 3.3.1
Reproducible in staging?: - Yes
Version Number: - v1.1.39-3
Platforms - Web(Chrome + Jaws), Desktop(MAC), Mobile-web (Safari + Voiceover)
Note - Due to installation of build not able to check on Android
https://user-images.githubusercontent.com/97600950/156995082-741e708a-da64-47d5-8577-bac7ad43a4de.mp4

@Stutikuls Thanks, I'd suggest that you post this on slack.
https://github.com/Expensify/App/blob/d4ed740be06862eb4ea31fa831de9416f7ed0a55/CONTRIBUTING.md#asking-questions

@Stutikuls Thanks, I'd suggest that you report this bug on slack because this bug doesn't seem to be related to this PR
https://github.com/Expensify/App/blob/d4ed740be06862eb4ea31fa831de9416f7ed0a55/CONTRIBUTING.md#asking-questions

Hi @rushatgabhane, the accessibility team is working on in-sprint testing for the PRs, the issues mentioned by Stuti are all related to the described flow. We were told to mention all accessibility issues we find in a comment to the corresponding PR.

Thanks, I wasn't aware of that. I'll take care of this


[8.x] Retrieve the underlying string value in Stringable

This PR adds the method get() to Illuminate/Support/Stringable. This can be useful to quickly retrieve the underlying string value without the need of casting:
// before
return (string) Str::of('foo')->uppercase()->append('!');

// after
return Str::of('foo')->uppercase()->append('!')->get();

Str::of('foo')->uppercase()->append('!')->__toString()

@huangdijia definitely possible but not as elegant and consistent, in my opinion

I like this PR, but I'd call the method toString instead.
A downside to having to use __toString() is that it doesn't get auto-completed by PHPStorm:

And having a dedicated method for getting the string looks nicer:
$string = Str::of('test')->__toString();

$string = (string) Str::of('test');

$string = Str::of('test')->toString();

Please send this to 9.x

New PR: https://github.com/laravel/framework/pull/40861


Missing token_fee_schedule_update.proto import in schedulable_transaction_body.proto

Description
Error in generating hedera-probufs-go
Steps to reproduce
Run protoc-gen-go
Additional context
No response
Hedera network
other
Version
protoc-gen-go v1.26.0-devel protoc v3.17.3
Operating system
Linux

Seems to be fixed now


Trivial formatting change to test public contribution system

You can reject this if you like, since it seems to be formatted differently from your regular layout.
I tried looking for a spelling error in your comments and docstrings but it's all impeccably spelled!
Signed-off-by: Paul Wayper<EMAIL_ADDRESS>

Just to clarify, this was asked for by Stef Walter as part of a test to see how easy it was to find and contribute to this project.

Happy to take this; I personally quite like when the command in the subprocess.run call is isolated and thus more clearly visible. This needs a rebase on main though to make CI happy (github's lack of merge queue allowed two commits that were green to be merged but the one modified the test data and then the test-data regeneration check was broken on main).
The commit message (subject) is a bit meta. Maybe something like test: isolate command for subprocess.run or something.

Just to clarify, this was asked for by Stef Walter as part of a test to see how easy it was to find and contribute to this project.

Would love to get feedback how easy it indeed was! We provide a VS Code dev container to be able to quickly hack on this project but I am sure we can make it better for newcomers somehow.

Hi @gicmo - thanks for that.
Well, maybe I'm not a typical developer, since my basic way of finding and contributing to this repository was to find it in Github and then fork it, clone it, create a branch, write the code, push it to my fork and create a PR from that.  I didn't need to set up an environment, I already have my development environment set up :smile:

You can reject this if you like, since it seems to be formatted differently from your regular layout.

Yeah, I like those splits, too! Looks good to me (but see comments from @gicmo).

I tried looking for a spelling error in your comments and docstrings but it's all impeccably spelled!

:heart:

Thanks for that - I've updated this to do the same for a few other uses of subprocess.run in the test file.  I've also updated the title and description now that it's actually useful.

Looks like we have found room for improvement for external contributors, our full CI is not getting triggered, and we don't currently have a nice work-around. As pointed out by @ondrejbudai in chat, we need something like https://github.com/rhinstaller/anaconda/blob/master/.github/workflows/tests-contributors.yml
For now force-merging after double checking the code (as it is just whitespace and passes the unit tests and linter).


" UItextView has no member 'placeholder' "

I used swift pakage manager, and correctly imported in my project file but It doesn't work.

Second...doesn't work.

it doesn't work either.

doesn't work for me either.

I got the same error, when I tried to add the library to my module written in Swift using SPM (Xcode 12.5.1)
I added an import to .h so that I could use the library in Swift:
#import <UITextView_Placeholder/UITextView+Placeholder.h>
and it produces an error "'UITextView_Placeholder/UITextView+Placeholder.h' file not found".
I checked Frameworks and Libraries for my target – the library is listed there. But UITextView+Placeholder.swiftmodule is missing from Products folder in Derived Data, though there still is UITextView+Placeholder.o.
I am not sure what caused the problem – maybe it has something to do with the modulemap implementation.

I just dragged the two files from the  Source Directory into my Project and use a bridging header where I import the file like this: #import "UITextVIew+Placeholder.h"


Unable to set no-run-unnecessary-builds with this action

Hi, I have a similar question somewhat related with #962. Running CodeQL cli it is possible to specify --no-run-unnecessary-builds to prevent the analysis of folders like target on Java. Would be possible to pass arguments to init like in the snippet below?
 - name: Initialize CodeQL
      uses: github/codeql-action/init@v1
      env:
        CODEQL_ACTION_EXTRA_OPTIONS: '{"database":{"create":["--no-run-unnecessary-builds"]}}'
      with:
        languages: java

Thanks in advance.

Yes. This should be possible. However, the action does not call database create directly. Instead it calls init, trace-command, and finalize. Both trace-command and finalize take --no-run-unnecessary-builds option. In your case, I'm not sure which command will be using it. It's no harm to specify it in both places, or you can try setting it in one of them first and then the other.
Something like this should work:
 - name: Initialize CodeQL
      uses: github/codeql-action/init@v1
      env:
        CODEQL_ACTION_EXTRA_OPTIONS: '{"database":{"trace-command":["--no-run-unnecessary-builds"]},"finalize":["--no-run-unnecessary-builds"]}}'
      with:
        languages: java

(Check my JSON syntax since I just copy/pasted the changes.)

Thank you so much @aeisenberg for your prompt reply! That made my day.


Mocha in browser not running tests

I have tests written in TypeScript and transcompiled to single .js file using Webpack:

Running mocha tests.js will work just fine.
Running tests using Karma (karma.conf.js uses mocha framework, loads tests.js, browser is PhantomJS) will work just fine.

However, running tests by opening (in browser from local disk) provided runner.html will NOT work (I can see Mocha's HTML created under

, but no test results are shown):
<!DOCTYPE html>

    <meta charset="UTF-8">
    <title>Tests</title>

    <link rel="stylesheet" href="../../../node_modules/mocha/mocha.css">

Can anyone give me insight as to why?

No real experience with browser side of this project myself, but since you have the Inspector open...

Anything shown in console tab?
"mocha.js" actually loaded in resources tab?

Title of this says tests are not running, but DOM node "mocha-report" exists which suggests otherwise. Are your tests running (add console.log() to "tests.js" and maybe before/after mocha.run())? Or is it that output is missing?

Where did it jump out of mocha.run() when you set your breakpoints?

Could you test it with CDN like here?

I'm going to close this as I have configured it to work flawlessly using Webpack + Karma. My guess (from limited exposure to this problem) is that the bundling of Mocha/Chai code using Webpack causes tests to not run - when bundled, there is no global mocha object (as I understand), thus including Mocha .js and calling mocha.run does nothing for the bundled Mocha code.
For anyone that wants to pursuit this further, this is what I did:

built .spec.ts files into single tests.js (with no Mocha/Chai included code)
bundled Mocha/Chai code into single vendor.js (My guess is that here lies the problem)

I can provide simple project if there is interest in tracking/understanding this issue.


refactor: make  PartitionSpec more safe

This discussion is a follow up of this comment, in summary, I'm thinking about make PartitionSpec safe with following changes:

Making all fields private to this struct.
Add a schema field to PartitionSpec.

This will introduce several changes:

PartitionSpec could only be built using builder, which has checks for serveral parts to ensure it's correct
PartitionSpec's partition type could be infered by itself
We may need to change the deserialization of TableMetadata to use builder to build it.

@liurenjie1024 we just need to be very careful with old PartitionSpecs: They might not be valid anymore for the current schema - yet, we still want to keep them.
In these cases Java has schema field pointing to the current schema, even if fields might not be present. Java achieves this by using build_unchecked.
In think it would be much cleaner to use UnboundPartitionSpecs for these cases.
We could change TableMetadata to
pub struct TableMetadata {
...
    pub(crate) partition_specs: HashMap<i32, UnboundPartitionSpecRef>,  // Changed to unbound
    pub(crate) default_spec: PartitionSpecRef, // This is a new field bound to the current schema.
    // Remove: default_spec_id - get it from default_spec.id
}


Upgrading to PyTorch master

It looks like the test failures are related to an import looking up the wrong MultivariateNormal. I think it's safe to simply remove the test since we'll be switching to upstream MultivariateNormal immediately in #916.

It looks like the test failures are related to an import looking up the wrong MultivariateNormal. I think it's safe to simply remove the test since we'll be switching to upstream MultivariateNormal immediately in #916.

I made changes to move to torch.distributions.multivariate_normal, and skipping this test. The issue is that the upstream pytorch implementation hasn't implemented .variance (or .mean), which causes this failure.

@neerajprad We could implement .variance and .mean in a wrapper in pyro/distributions/torch.py if those are needed elsewhere in Pyro. We can push those implementations upstream later.

@neerajprad We could implement .variance and .mean in a wrapper in pyro/distributions/torch.py if those are needed elsewhere in Pyro. We can push those implementations upstream later.

Done.


Create an Application for Receiving Messages

Tutorial URL: https://developers.sap.com/tutorials/cp-enterprisemessaging-nodejs-receiving-app.html
Please specify the step you are referring to 1
The SAP npm registry is not needed anymore and actually causes some confusion. I'd suggest to remove it.

Yes.. now its not more needed as the npm packages are now hosted here: https://www.npmjs.com/package/@sap/xb-msg-amqp-v100
I will update the tutorial. Thanks for the message.
regards
Pradeep

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.

It seems that the tutorial is not yet upgraded. Please keep the issue open until the tutorial reflects the change.

It seems that the tutorial is not yet upgraded. Please keep the issue open until the tutorial reflects the change.

we can close this issue as the fix has been provided. Please look into the tutorial and reopen it if you think otherwise.

@IObert ?

Many thanks, LGTM


The term 'Warn-IfCertificateNotPresentInLocalCertStore' is not recognized as the name of a cmdlet, function, script file, or operable program.

Environment

Server - Azure Pipelines

Agent - Private:

Win10, latest agent version

Issue Description
I've created a new service fabric cluster and cloned the build and release for this new cluster.
I've installed sf cluster certificated and configured in project settings.
As I try to run Service Fabric Application Deployment task, It connects to the cluster but I receive the following error.
##[error]The term 'Warn-IfCertificateNotPresentInLocalCertStore' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
Couldn't find anything about it.
The old/original build/release tasks are running without any errors.
The only difference between the clusters is that the original is 1-node and the new one is 5-node.
Error logs
##[error]The term 'Warn-IfCertificateNotPresentInLocalCertStore' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

I need to release to production environment, can you rollback to the previous version?

I've lost almost all day of work trying to find a solution for this

There you go https://github.com/Microsoft/azure-pipelines-tasks/pull/8740/files

This has been fixed.

It is now working with the new azure-pipelines-task fix.
thanks


Rewrite of the README

rewrite of README to be a map pointing to various work we have completed. We will be in the future including labs for people to run through.

LGTM


_AR_EXP_UpdateEntityIdx error when adding nodes to graph

Hi!
ResponseError                           Traceback (most recent call last)
~/repositories/redisgraph_test/main.py in <module>
     36                 graph.add_node(redisgraph.Node(label="account", properties=a))
     37
---> 38         qr = graph.commit()
     39         print(str(qr))

~/.local/share/virtualenvs/redisgraph_test-RxknWNSK/lib/python3.7/site-packages/redisgraph/graph.py in commit(self)
     94             query = query[:-1]
     95
---> 96         return self.query(query)
     97
     98     def flush(self):

~/.local/share/virtualenvs/redisgraph_test-RxknWNSK/lib/python3.7/site-packages/redisgraph/graph.py in query(self, q, params)
    129
    130         response = self.redis_con.execute_command("GRAPH.QUERY", self.name, q, "--compact")
--> 131         return QueryResult(self, response)
    132
    133     def _execution_plan_to_string(self, plan):

~/.local/share/virtualenvs/redisgraph_test-RxknWNSK/lib/python3.7/site-packages/redisgraph/query_result.py in __init__(self, graph, response)
     43         # If we encountered a run-time error, the last response element will be an exception.
     44         if isinstance(response[-1], ResponseError):
---> 45             raise response[-1]
     46
     47         if len(response) is 1:

ResponseError: _AR_EXP_UpdateEntityIdx: Unable to locate a value with alias None within the record

I'm getting this error while trying to create a bunch of nodes, pretty basic stuff. The error was a bit cryptic for me,  and I didn't find anything googling it, documentation-wise or similar question answered. Well, except the redisgraph code:
https://github.com/RedisGraph/RedisGraph/blob/0cf50df86d5846c1eba39b2c0fcf1f500c25abf2/src/arithmetic/arithmetic_expression.c#L327-L348
My guess is that this is a datatype mapping issue(None values are not automatically translated to cypher NULL). If so, what is the right way to encode a null value in a record?
I think it would be helpful to users to have some error interpretation between the raw redisgraph protocol messages and the client library user.
Thanks!

Hi @DrPyser,
I agree, we should improve our error reporting,
Would you mind letting us know what does a stands for in:
 graph.add_node(redisgraph.Node(label="account", properties=a))

I would like to see the actual query which was issued, one way of finding out is to have redis-cli running with the MONITOR command and then run your python script. you should see all of the commands received by your redis-server in the monitor.

	for a in accounts:
		print("a=",a)
		if a["mcc"] == "True":
			a.update(mcc=True)
		if a["mcc"] == "False":
			a.update(mcc=False)
		if a["parent_id"] == "<null>":
			a.update(parent_id=None)
		graph.add_node(redisgraph.Node(label="account", properties=a))

Basically, I'm loading data from a csv and creating "account" entities. Some attributes will be null.

An extract from the actual cypher query:
 "GRAPH.QUERY" "accounts" "CREATE (hpebuobbzn:account{account_id:\"310-095-8250\",name:\"Fondation Mira\",parent_id:None,mcc:False})

I guess it should be converting the None to a null, right?

Hi @DrPyser,
null is a somewhat tricky beast in Cypher, and RedisGraph is not totally consistent in this respect.
The main problem is that null is not actually allowed by Cypher to be the value of a property, though both the bulk loader and the CREATE clause will allow null values to be set (which is an error on our part).
When you perform property accesses on non-existent properties, null is returned, which sets up the more orthodox approach here. By not setting parent_id at all where it's currently null, you can write queries such as:
MATCH (a:account) WHERE a.parent_id IS NULL RETURN a
MATCH (a:account) WHERE a.parent_id IS NOT NULL RETURN a
MATCH (a:account) WHERE exists(a.parent_id) RETURN a

Okay, I got it. Thanks!


Probable mistake in the description of the static-only command

The page for static-only command or by its title "Active applications only" indicates :

Set to true ➡ "Only show active apps"
Set to false ➡ "Hide inactive apps from the Dock"

I understand what is being said but it doesn't seem clear to me.
For the default case, I think a good formulation might be: "Show apps pinned to the dock".
Also, I think it's good to mention that the layout of the apps in the Dock is lost when the command is used.
For example by adding "⚠ Beware this command empties your Dock" in the description
What do you think about it?

You're totally right, thanks for the alert & fix with #260


How to inject external startup assemblies in .net core 2.1?

What am I trying to do:
I am trying to load extra hostingstartupassemblies through use of the ASPNETCORE_HOSTINGSTARTUPASSEMBLIES environment variable.
Previously
In .net core 2.0 this worked fine, and the file would be grabbed from the local (implicit) runtime store. On linux this was located in /usr/share/dotnet/*.
Problem description
The current documentation at https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/platform-specific-configuration?view=aspnetcore-2.1&tabs=linux#class-library shows how this works with .net core 2.0. You add a deps.json file to the /usr/share/dotnet/additionalDependencies folder, and the binary to /usr/share/dotnet/store/x64/etc, and it will be ready for inclusion. This works exactly as described for .net core 2.0
This way when you use the ASPNETCORE_HOSTINGSTARTUPASSEMBLIES environment variable, the binary is loaded from disk and injected in the application without any problems.
With .net core 2.1+ the runtime store was deprecated and replaced by the shared library. The current instructions don't work with a clean install of the .net core 2.1, so I'm stuck on how to load my assemblies during runtime. Is there any way I can still invoke the runtime store, or is there a better way to inject external startup assemblies during runtime?
Issues:

The web app logs "Cannot find assembly [myname.dll]"
There is no runtime package store
There is no additionalDeps folder

Note: compile-time is not an option for me, this would have been easy with a NuGet package.
dotnet --info
.NET Core SDK (reflecting any global.json):
Version:   2.1.403
Commit:    04e15494b6
Runtime Environment:
OS Name:     centos
OS Version:  7
OS Platform: Linux
RID:         centos.7-x64
Base Path:   /usr/share/dotnet/sdk/2.1.403/
Host (useful for support):
Version: 2.1.5
Commit:  290303f510
.NET Core SDKs installed:
2.1.403 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.5 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

@JunTaoLuo ?

@las3r can you provide a repro for what's not working? Even though we are now delivering Microsoft.AspNetCore.App/.All through the shared framework, the runtime store mechanisms still exist to support hosting startup scenarios. If upgrading to 2.1 isn't working, it would be a regression.

@JunTaoLuo It does seem to load the assembly now, which is a great thing. I'm now however receiving "other" issues.
Oct 13 01:05:10  System.InvalidOperationException: Startup assembly MyCustomAssembly failed to execute. See the inner exception for more details. ---> System.IO.FileLoadException: Could not load file or assembly 'Microsoft.AspNetCore.Hosting.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040) Oct 13 01:05:10  at System.ModuleHandle.ResolveType(RuntimeModule module, Int32 typeToken, IntPtr* typeInstArgs, Int32 typeInstCount, IntPtr* methodInstArgs, Int32 methodInstCount, ObjectHandleOnStack type) Oct 13 01:05:10  at System.ModuleHandle.ResolveTypeHandleInternal(RuntimeModule module, Int32 typeToken, RuntimeTypeHandle[] typeInstantiationContext, RuntimeTypeHandle[] methodInstantiationContext) Oct 13 01:05:10  at System.Reflection.RuntimeModule.ResolveType(Int32 metadataToken, Type[] genericTypeArguments, Type[] genericMethodArguments) Oct 13 01:05:10  at System.Reflection.CustomAttribute.FilterCustomAttributeRecord(CustomAttributeRecord caRecord, MetadataImport scope, Assembly& lastAptcaOkAssembly, RuntimeModule decoratedModule, MetadataToken decoratedToken, RuntimeType attributeFilterType, Boolean mustBeInheritable, Object[] attributes, IList derivedAttributes, RuntimeType& attributeType, IRuntimeMethodInfo& ctor, Boolean& ctorHasParameters, Boolean& isVarArg) Oct 13 01:05:10  at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, Int32 pcaCount, RuntimeType attributeFilterType, Boolean mustBeInheritable, IList derivedAttributes) Oct 13 01:05:10  at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeAssembly assembly, RuntimeType caType) Oct 13 01:05:10  at System.Attribute.GetCustomAttributes(Assembly element, Type attributeType, Boolean inherit) Oct 13 01:05:10  at System.Reflection.CustomAttributeExtensions.GetCustomAttributes[T](Assembly element) Oct 13 01:05:10  at Microsoft.AspNetCore.Hosting.WebHostBuilder.BuildCommonServices(AggregateException& hostingStartupErrors)
I've run the following command to 'fill' the store with all dependancies:
 dotnet store --manifest /home/lib/MyCustomAssembly/MyCustomAssembly.csproj --runtime linux-x64 --skip-optimization --output /usr/share/dotnet/store/
I also see all the dependancies downloaded in the filesystem as seen in the screen below. What am I doing wrong?

In our site extensions, when they are launched, we set three environment variables: https://github.com/aspnet/AzureIntegration/blob/218ea6f3033eab25dfbf372bed95830142a17c16/extensions/Microsoft.AspNetCore.AzureAppServices.SiteExtension/applicationHost.xdt#L10-L12. Can you try setting DOTNET_ADDITIONAL_DEPS and DOTNET_SHARED_STORE to the location where you generated the runtime store and additional deps and see if that works?

Thanks @JunTaoLuo - is that from the windows-hosted Azure App service? I'd be very interesting in how that's done in the linux variant, because they might behave differently.
I've tried adding this but I didn't see a change, still the same exception about not being able to load Microsoft.AspNetCore.Hosting.Abstractions. As you can see in the screenshot above this is in the /usr/share/dotnet/store for the netcoreapp2.1 target. DOTNET_ADDITIONAL_DEPS was already in my service definition, and I just added the DOTNET_SHARED_STORE now.
My service for this .net core account:
[Unit]
Description=Test service to run .net core

[Service]
User=localuser
Group=localuser
WorkingDirectory=/home/localuser/www
ExecStart=/usr/bin/dotnet MyWebsite.dll
Restart=always
RestartSec=10
SyslogIdentifier=dotnetnetcore-ident
Environment=ASPNETCORE_URLS=http://<IP_ADDRESS>:11000
Environment=DOTNET_ADDITIONAL_DEPS=/usr/share/dotnet/additionalDeps/MyCustomAssembly
Environment=DOTNET_SHARED_STORE=/usr/share/dotnet/store
Environment=ASPNETCORE_HOSTINGSTARTUPASSEMBLIES=MyCustomAssembly
#custom
Environment=ASPNETCORE_ENVIRONMENT=Development
Environment=ASPNETCORE_DETAILEDERRORS=0
Environment=somevar=

[Install]
WantedBy=multi-user.target

I've also ruled out permission issues: with root user the same exception appears. Where does the runtime look for assemblies when loading them? I tried to see if there was any file access to the disk using fatrace but I don't see dotnet 'trying' to load a file from disk somewhere.

Hmm I think there are some package version mismatch issues then. Can you set the environment variable COREHOST_TRACE to 1 to enable the corehost logs and attach the output here? Or you can also provide a simplified repro here and I can debug it on my local machine. The OS does not affect the loading of hosting startup assemblies so that probably isn't the problem.

It has been attached @JunTaoLuo. I see no mention of the MyCustomAssembly.dll, and neither the Microsoft.AspNetCore.Hosting.Abstractions is being loaded. If you wish I could give you access to my dev server to see what's wrong.
coretrace.txt

You only captured the first portion of the trace logs. Usually the logs I see are ~40k lines but you only included the first ~2k lines.

My bad, attached again. This time it's 10k lines, this ends with "Application started". I also see the hosting abstractions being loaded here @JunTaoLuo, so not sure what's wrong.
netcore-trace-full.txt

Yup looks like a package version mismatch. In the logs, it's loading Microsoft.AspNetCore.Hosting.Abstractions 2.0.3
Processing TPA for deps entry [Microsoft.AspNetCore.Hosting.Abstractions, 2.0.3, lib/netstandard2.0/Microsoft.AspNetCore.Hosting.Abstractions.dll]
  Considering entry [Microsoft.AspNetCore.Hosting.Abstractions/2.0.3/lib/netstandard2.0/Microsoft.AspNetCore.Hosting.Abstractions.dll], probe dir [], probe fx level:0, entry fx level:0
    Local path query exists /home/las3r/public_aspnet/Microsoft.AspNetCore.Hosting.Abstractions.dll
    Probed deps dir and matched '/home/las3r/public_aspnet/Microsoft.AspNetCore.Hosting.Abstractions.dll'

What's most likely happening is that the version you are using in the app (which is published to /home/las3r/public_aspnet/ I assume) is different from the one that's required by the hosting startup assembly. Since only one set of assemblies are ultimately resolved (and the app's assemblies win), the one required by the hosting startup assembly (2.1.1) could not be found. You need to ensure the version required by your app and the hosting assembly match.
Though this is the most likely explanation, I can only confirm once I see your .deps.json files for both the app and the hosting startup assembly.

This is completely correct @JunTaoLuo. As you can see in my revised comment above I tested and doublechecked this. My web app is in /home/las3r/public_aspnet with version 2.0.3
The problem in this case is that I am not the one running the web app, it can be any number of clients with a scala of different web apps that are outside of my control (this is for a shared hosting offering basically). How is this handled in e.g Azure Web Apps? The same situation exists there, where user assemblies might cause issues when you are trying to inject dll's?
Can I safely remove any of the dependancies of MyCustomAssembly from the clients' web app before launching it? It can only be a small number of dependancies I suppose, since my assembly is very small, all it really does is check a header.

I see. However, 2.0 is now out of support so I'm not sure how relevant this scenario is. Starting in 2.1, you should target the lowest patch of a minor release to ensure compatibility (i.e. a hosting startup assembly targeting 2.1.3 will be compatible with apps targeting 2.1.3, 2.1.4, ...). However, you will still need to release an updated hosting startup assembly for each minor release.

The 2.0 was a reference to the version of the webhosting abstraction package, not dotnet core :).
Basically you suggest that I should implement a scheme where I upload an assembly for 2.1.0 with the dependencies for that runtime version, and so on for every minor release.
That will not prevent bad actors from circumventing my injected code by including a lower or higher version of in this case the hosting abstractions DLL, will it?

All right- well thank you very much for your answers. It has given me enough insights to implement this on our side. I'll close this issue (as I'm happy with the answers I've gotten here). Thank you!


server: fixed a bug that params description will be sent when no params in handleStmtDescription

What problem does this PR solve?
Fixed a bug that params description will be sent when no params in handleStmtDescription.
Translated some comments.
Handled flush message.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1b93def). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main        #61   +/-   ##
=========================================
  Coverage        ?   69.3915%
=========================================
  Files           ?        523
  Lines           ?     151040
  Branches        ?          0
=========================================
  Hits            ?     104809
  Misses          ?      36298
  Partials        ?       9933


ros2_intel_realsense: 2.0.4-2 in 'dashing/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros2_intel_realsense to 2.0.4-2:

upstream repository: https://github.com/intel/ros2_intel_realsense.git
release repository: https://github.com/ros2-gbp/ros2_intel_realsense-release.git
distro file: dashing/distribution.yaml
bloom version: 0.8.0
previous version for package: 2.0.3-2

realsense_camera_msgs
* update maintainer
* 2.0.3
* update changelog
* Contributors: Chris Ye

realsense_ros2_camera
* Merge pull request #50 <https://github.com/intel/ros2_intel_realsense/issues/50> from ahuizxc/dashing
  fix compiling failure after ros2 core updated and remove some warnings.
* fix compiling failure after ros2 core updated and remove some warnings.
* Merge pull request #44 <https://github.com/intel/ros2_intel_realsense/issues/44> from ahuizxc/master
  add depthimage to laser scan launch file
* add depthimage to laser scan
* enable librealsensev2.17.1
  enable librealsensev2.17.1
* update package.xml and readme
* enable librealsensev2.17.1
* Merge pull request #39 <https://github.com/intel/ros2_intel_realsense/issues/39> from challen-zhou/master
  Add options to enable/disable color-aligned point cloud
* Change aligned pointcloud format from XYZ to XYZRGB
* Add options to enable/disable color-aligned point cloud
  Since the default 2 point cloud process cost too much computation,
  add option to enable/disable(default) color-aligned point cloud.
* Merge pull request #36 <https://github.com/intel/ros2_intel_realsense/issues/36> from challen-zhou/master
  Add pointcloud aligned with color
* Add pointcloud aligned with color
  Add pointcloud generate from depth which aligned to color,
  no RGB channel since this pointcloud one-to-one matches with color image.
* Merge pull request #32 <https://github.com/intel/ros2_intel_realsense/issues/32> from challen-zhou/master
  Update depth alignment function to align with librealsense
* Merge pull request #30 <https://github.com/intel/ros2_intel_realsense/issues/30> from ahuizxc/master
  pass the format test and fix ctrl+c error
* Update depth alignment function to align with librealsense
  Update depth alignment function to align with librealsense since
  librealsense already upstreamed to ROS2/Crystal, also we can benifit from
  the future librealsense optimization.
* fix ctrl+c error
* pass the format test
* Merge pull request #29 <https://github.com/intel/ros2_intel_realsense/issues/29> from ahuizxc/master
  fixed bug that camera not work when enable_depth=False
* fixed bug that camera not work when enable_depth=False
* Merge pull request #23 <https://github.com/intel/ros2_intel_realsense/issues/23> from intel/fix_ctest
  fix error when run CTest
* fix error when run CTest
  * set Realsense device not exist by default, disable testapi when Realsense device not plugin
  * fix format error when run CTest
* Merge pull request #22 <https://github.com/intel/ros2_intel_realsense/issues/22> from RachelRen05/update_readme
  update project to install debain package dependency
* update readme.md
  * update project to install debain package dependency
  * add rviz default configuration and support ros2 launch
* update maintainer
* 2.0.3
* update changelog
* Merge pull request #18 <https://github.com/intel/ros2_intel_realsense/issues/18> from nuclearsandwich/add-dependencies-to-package.xml
  Add eigen as a build dependency for ros2debian
* Add eigen as a build dependency.
* Contributors: Chris Ye, Gary Liu, RachelRen05, Sharron LIU, Steven! Ragnarök, Xiaojun Huang, ahuizxc, challenzhou

Holding until after tomorrow's sync.


Fix stat blocks splitting columns in Chrome

From @rg-wood on March 30, 2018 15:13
From @rgladwell on March 25, 2018 12:55
Stat blocks can split across columns in Chrome:

Copied from original issue: grislyeye/vellum-stat-block#11
Copied from original issue: grislyeye/temp#6

This issue was moved to grislyeye/vellum-stat-block#18


I have problems with running the code with input images of 256*256.

 I don't want to resize it to 512*512 as they
will get blurry. Then I come to realize that the following code is hard, just specially for 512*512.
target_image[{{},{117,232},{117,396}}]:copy(target_image[{{},{1,116},{117,396}}])
target_image[{{},{233,280},{117,396}}]:copy(target_image[{{},{69,116},{117,396}}])
target_image[{{},{281,396},{117,396}}]:copy(target_image[{{},{397,512},{117,396}}])

Would you please give the corresponding numbers for 256*256.

Sorry for the late reply (paper deadline).
Are you talking about this:
output[{{},{73,184},{73,184}}]:copy(fake2[{{},{9, 120},{9, 120}}])


Hono streams immediately closes the connection unless sleep is used

What version of Hono are you using?
3.12.0
What runtime/platform is your app running on?
Bun
What steps can reproduce the bug?
According to the Hono documentation, to setup a stream and send SSE events, this is all that's needed
const app = new Hono()
let id = 0

app.get('/sse', async (c) => {
  return streamSSE(c, async (stream) => {
    while (true) {
      const message = `It is ${new Date().toISOString()}`
      await stream.writeSSE({
        data: message,
        event: 'time-update',
        id: String(id++),
      })
      await stream.sleep(1000)
    }
  })
})

While that is correct, the reason this works is because of the magic line await stream.sleep(1000) which basically keeps the connection open forever, extending it with 1000ms every loop. Basically the streamSSE callback never resolves.
Without this, Hono immediately resolves the callback, returns and closes the connection. And no more SSE events will be pushed.
In other words Hono does not keep the connection open unless you manually keep it open using some await stream.sleep() mechanism.
And because a Hono request always requires a return, there's no other option then to increase the time with some sleep.
What is the expected behavior?
I expect Hono to be able to keep a stream connection open so I can push future updates to it, without using stream.sleep.
What do you see instead?
Connection getting closed if I don't use await.stream.sleep.
Additional information
No response

@satyavh Thanks for the issue.
@sor4chi Can you handle this?

Hi, @satyavh
Is this the code you expect to work correctly?
import { Hono } from "hono";
import { streamSSE } from "hono/streaming";

const app = new Hono();
let id = 0;

app.get("/sse", async (c) => {
  return streamSSE(c, async (stream) => {
    while (true) {
      const message = `It is ${new Date().toISOString()}`;
      await stream.writeSSE({
        data: message,
        event: "time-update",
        id: String(id++),
      });
      // await stream.sleep(1000);
    }
  });
});

export default app;

Exactly
And then you'd always manually need to close the stream using stream.close() - or of course from the client side

If that is the problem closing to streamSSE, the v3.12.1 update may have improved it.

This can be closed - works fine now. Also the bug label can be removed too.

Okay. Closing. Thanks!


Day7

Resolves #15

Pull Request Test Coverage Report for Build 36

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 34:
0.0%

Covered Lines:
24

Relevant Lines:
24

💛  - Coveralls


Prepare new Grafana dashboard with Apache Kafka-broker related metrics

Prepare new Grafana dashboard with Apache Kafka-broker related metrics

Done already.


AT&T python cascade ~800/900 found

How'd you get this cascade image?

With maxSize added, all the error detections are removed.


FIX: Convert LTA to ITK with nitransforms

Closes #185.

BTW, would this (=nitransforms integration) be part of 20.1?

Hmm. Was that not already party of fmriprep?

Correct.
I integrated nitransforms for that problem because the alternative seemed even finickier (nipype conditionals and more third-party tooling). Nitransforms allowed me to read LTA (when running the full pipeline) and ITK (when using the anatomical fast-track) very easily.
I guess we can say the experimenting with nitransforms is done, and proceed with a more global (or full using my own term) integration.
I'm happy with that, just making sure we are all on the same page 👍

For 20.1, I'd say let's transition only things that need adjustment for some reason. We can make a full transition an explicit goal of 20.2.

Okay, how that approach materializes in practice? I mean, you are proposing:
a) having fmriprep's and smriprep's copies of this code coliving until 20.2; or
b) upstreaming the code to niworkflows (so there's no duplicity), but refrain from including more features of nitransforms beyond this interface, until 20.2

b, more or less.
I just meant "let's not transition convert3d nodes that are working". If it seems worth it to upstream the interface to niworkflows because it's now in two places, that's okay.

sounds great. I'll send a PR to niworkflows moving the code, tomorrow.

Codecov Report

Merging #188 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   71.55%   71.58%   +0.02%
==========================================
  Files          15       15
  Lines         995      996       +1
  Branches      135      135
==========================================
+ Hits          712      713       +1
  Misses        237      237
  Partials       46       46

Flag
Coverage Δ

#ds005
64.92% <66.66%> (+0.03%)
:arrow_up:

#ds054
51.35% <16.66%> (-0.06%)
:arrow_down:

Impacted Files
Coverage Δ

smriprep/workflows/anatomical.py
68.21% <33.33%> (+0.21%)
:arrow_up:

smriprep/workflows/outputs.py
71.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c0da6...4020d4f. Read the comment docs.

Running this on ds031 right now. I'll report back tomorrow

Okay, I had to switch from ds031 to ds114 as datalad+openneuro wasn't up-to-date when I started. Now I have sMRIPrep run on ds114 - will report soon whether this is working properly.

Because of #192, I haven't locally tested https://github.com/poldracklab/smriprep/pull/188/commits/a5a826326fa3daa1c53e95f7ae59b0e6c28b51b7 - will report back when finished. This should not affect Circle builds as we don't have any multisession / multi-t1 dataset there.

@effigies, @mgxd any final comments?
(Mathias, we can release right now and add it later. Otherwise, the changelog will need an update - WDYT?)

LGTM.

yeah, this will make it in for 20.1


OSS installation docs fixes for iso5

don't mention CentOS 7
expand instructions for non RHEL based distros to install and enable inmanta-ui + web-console
provide instructions for installing Postgres 13 instead of 10

Install instruction for PostgreSQL 13 are already there

Indeed, apparently I was looking at the stable OSS docs. For the dev docs it looks like the tabs for the distributions don't work though (they are just listed one below the other). I'll add that instead.


@xtina-starr => Support partner featured bio on artist biography page

This updates the biography page for an artist to support featured bios, through Metaphysics. MG version of https://github.com/artsy/force/pull/314.
Pretty straightforward, safe to merge. Next up, trying to figure out how to 'know' whether to render the bio tab on the main artist page, in the event of no Artsy bio but an existing featured partner bio. Unless the whole page is rewritten to use Metaphysics...I may have to add that call :(

Closes part of https://github.com/artsy/microgravity/issues/39

Ok, pr'ed a hacky, but necessary commit that will fetch/set the featured partner bio if there isn't an Artsy one. This way, the template can render the bio link if present.
Since existing code relies on Metaphysics to orchestrate (and it still needs to make the partner artist call), I don't see a way around this.
It's a pretty light/cached call though, so no biggie 👍

Closes all of https://github.com/artsy/microgravity/issues/39

⭐


README.md refers to old versions

README.md refers to version 1.1 even when 1.3 is released. Both pom snippet and "get it directly from maven" should probably be updated.

fixed in commits: b8c8f1d5b56698e772d28e87d5f75442c13b735f, d6b8053b2cde09baae612385cc0705fdff921a54, 11e4c51e0c6258d12c9f39489e3d5f9fcecd1979

Thanks for the report! i think i've caught all the random versions through out!


store: fix misc label_value issues related to external labels

If the requested label was an external label, we would ignore matchers in tsdb and prometheus store.

Could you please port this to v0.33 also?
This is very important fix, but not even in the changelog

Could you please port this to v0.33 also? This is very important fix, but not even in the changelog

Oh, yeah sorry, it seemed just like a small fix at the time! Let me cherry pick it a bit later!

Could you please port this to v0.33 also? This is very important fix, but not even in the changelog

This is included in 0.34.0!


[language] Allow printing of cross-module calls in disassembly

Allows disassembly of modules with calls into other modules than self. Also handles type parameters and instantiations correctly now for function calls.
This  ticks off one of the future features in issue #1559

:umbrella: The latest upstream changes (presumably b005ed2afbe7c26ad0c8c35b1c2438ed1a80666f) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=sblackshear

:pushpin: Commit eaebd36 has been approved by sblackshear

:hourglass: Testing commit eaebd3668431e043f1ff563239c243edf21798a0 with merge adefb310bc4fdf2bd26e13f9b998eb7c4839399e...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: sblackshear
Pushing adefb310bc4fdf2bd26e13f9b998eb7c4839399e to master...


Good First Issues?

Hi all I saw a blog post on this project, and it seems very interesting. Are there any good first issues for beginners to get involved? Thank you.

Timer driver for aarch64/raspi3a so the TimerService works.
UART driver for aarch64/raspi3a for the DebugConsole so there's an
interactive shell.
On Fri, Dec 2, 2022 at 6:29 PM Femi @.***> wrote:

Hi all I saw a blog post on this project, and it seems very interesting.
Are there any good first issues for beginners to get involved? Thank you.
—
Reply to this email directly, view it on GitHub
https://github.com/AmbiML/sparrow-cantrip-full/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRM7INNEBT2RJHRECBKA3TWLKV7TANCNFSM6AAAAAASSPKDJI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Doctest 2.4.8

This PR updates Doctest to the latest version 2.4.8.

Coverage remained the same at 100.0% when pulling f65ade0fa9424949b1e40f19ae09c3043506a68d on update_doctest into e6bf789f7de9b5fc7b8d473a8e19e65ae0de5ebf on develop.

Test fail for MSVC 2015. See https://github.com/doctest/doctest/issues/573 for bug report.

The bug was resolved in Doctest 2.4.8.

That's a lot of clang tidy suppressing.  Is there a way to specify those just for the test directory?

That's a lot of clang tidy suppressing. Is there a way to specify those just for the test directory?

I have no idea. I am only aware of suppressing warnings in the code via // NOLINT comments.
I currently just want to make it pass the CI. I will create an issue upstream to inform the Doctest maintainers that their latest release triggers these warnings.

I wonder if it would make sense to exclude the tests from clang tidy.  https://github.com/nlohmann/json/blob/1aca6cb949f4595994ba5e5188682416d3058688/cmake/ci.cmake#L635

It would be great to only exclude file doctest.h from the results. I have not found a way to do this, and I also have not found a way to check the header without adding Clang-Tidy to the compilation process of the test suite.

Blocked until https://github.com/doctest/doctest/issues/607 is addressed.

We'll wait until Doctest 2.4.9 (see https://github.com/doctest/doctest/issues/607#issuecomment-1146950377).


Database table sizes

As of current date, after running the Pioreactor for a few months in a small cluster, here's a snapshot of how large the Sqlite3 artifacts are on disk (in mb) (some of these tables aren't around anymore):
             od_reading_statistics   0.004096
    sqlite_autoindex_experiments_1   0.004096
        led_automation_settings_ix   0.004096
     dosing_automation_settings_ix   0.004096
           led_automation_settings   0.004096
                     sqlite_master   0.012288
        dosing_automation_settings   0.020480
                    stirring_rates   0.020480
temperature_automation_settings_ix   0.024576
                    experiments_ix   0.024576
                       experiments   0.028672
             alt_media_fraction_ix   0.073728
   temperature_automation_settings   0.086016
                      config_files   0.122880
                alt_media_fraction   0.180224
                  dosing_events_ix   0.217088
                       pid_logs_ix   0.335872
                     dosing_events   0.692224
                          pid_logs   1.441792
           temperature_readings_ix   1.949696
              temperature_readings   4.399104
                           logs_ix  21.004288
           od_readings_filtered_ix  22.425600
              od_readings_filtered  45.903872
          kalman_filter_outputs_ix  50.630656
                   growth_rates_ix  50.630656
                              logs  91.009024
                      growth_rates 105.705472
                od_readings_raw_ix 158.986240
                     led_events_ix 164.225024
                   od_readings_raw 367.345664
                        led_events 450.797568
             kalman_filter_outputs 638.550016

How can we optimize this? What's redundant?

[x] led_events data is very redundant - this was only holding the IR LED blinking on and off over experiments.
[x] Probably remove the index on led_events - we don't use it in the UI
[x] Remove the index kalman_filter_outputs_ix
[x] kalman_filter_outputs redundancy is storing arrays of floats as strings. That's silly. We could truncate the precision of the floats:

[0.9817443680619926, 1.007342729613004, 4.877678040174688e-05, 0.0]

to
[0.9817, 1.00734, 4.87e-05, 0.0]

A more recent snapshot:
The total size of the sqlite db was 4gb
sqlite> SELECT name ,SUM(pgsize)/1024 table_size  FROM "dbstat" GROUP BY name ORDER BY table_size desc;
name                                              table_size
------------------------------------------------  ----------
kalman_filter_outputs                             719720
pioreactor_unit_activity_data                     718384
pioreactor_unit_activity_data_ix                  512444
od_readings                                       403496
od_readings_ix                                    367964
od_readings_filtered                              349172
growth_rates                                      349172
growth_rates_ix                                   334264
od_readings_filtered_ix                           332876
logs                                              283080
pwm_dcs                                           244448
stirring_rates                                    127032
logs_ix                                           88896
ir_led_intensities                                47752
temperature_automation_events                     45192
temperature_readings                              14756
dosing_events                                     13804
temperature_readings_ix                           8192
alt_media_fractions                               5948
dosing_automation_events                          3396
alt_media_fractions_ix                            3000
config_files_histories                            200
dosing_automation_settings                        48
temperature_automation_settings                   36
sqlite_schema                                     20
calibrations                                      20
workers                                           4
sqlite_autoindex_workers_1                        4
sqlite_autoindex_pioreactor_unit_labels_2         4
sqlite_autoindex_pioreactor_unit_labels_1         4
sqlite_autoindex_experiments_1                    4
sqlite_autoindex_experiment_worker_assignments_1  4
sqlite_autoindex_calibrations_1                   4
pioreactor_unit_labels                            4
od_blanks                                         4
led_change_events                                 4
led_automation_settings                           4
led_automation_events                             4
experiments_ix                                    4
experiments                                       4
experiment_worker_assignments                     4
experiment_profile_runs                           4
config_files_histories_ix                         4
calibrations_ix                                   4


feat: Add hint for double click to insert text

Fixes #938

I would add, "In selection mode," before. Then it's good.


Fixed infinite recursion in navigationControllerSwizzled

Hey Peter,
Here's a small fix for an infinite recursion issue when ALLOW_SWIZZLING_NAVIGATIONCONTROLLER is used.
Thanks for your work on this code!

Ha, missed that one. Thanks!


[Docs] Fix Trilogy TRILOGY_CAPABILITIES docs

This PR tweaks a couple of things with our TRILOGY_CAPABILITIES docs:

I don't think the description for TRILOGY_CAPABILITIES_TRANSACTIONS is correct -- AFAICT it is supported, so I've updated the description to match.
Same thing with TRILOGY_CAPABILITIES_SSL - it said this flag wasn't supported, but Trilogy has SSL support.
We were also saying that MULTI_STATEMENTS still wasn't supported, so removed that line too.

One suggestions otherwise 👍


Development Plan and Problem Statement TA Feedback

Goals

Unique selling points moved to top of the table

Formatting and Style

Problem statement reworded
Introduction to sections added

Content

More specific content added around development plan

Team Member Roles

Team member roles updated to be more specific

Git Workflow Plan

issue tags added to development plan

POC Demo Plan

POC Demo Plan updated


Show on-disk file size in addition to 'added to repo' in backup summary

Output of restic version

restic 0.12.0 compiled with go1.15.8 on linux/amd64
What should restic do differently? Which functionality do you think we should add?

A successful restic backup outputs a summary that ends with something like:

Added to the repo: 12.345 MiB

It'd be nice if this showed both the 'real' size of added/changed/removed files, as on local disk, in addition to the amount 'added to the repo', which could be significantly less.
What are you trying to do? What problem would this solve?

It'd just be a nice at-a-glance summary of how well the added files, in particular, were covered by extant blocks.
Did restic help you today? Did it make you happy in any way?

Just a suggestion from yet another happy user.

I'd love to see this as well!
Thanks for the great project!

I'm really confused now - I thought I was experiencing this the other way around, but vaguely recalled this issue (didn't think I'd opened it! very short memory..).
Either way I think it'd be useful to show both, but which is it currently, what does 'Added to repo' mean:

The cumulative file size of new/modified/deleted files in the snapshot; or
The additional remote storage required by the snapshot, after block-wise de-duplication, etc.

? I think it could be clearer which it means even if it's not wanted (or not possible/too difficult) to add the 'other one'.

Restic reports how much deduplicated data was uploaded to the repository, without accounting for overheads due to encryption and other repository metadata. That is its roughly option 2.

Thanks @MichaelEischer. I just noticed though, after restic backup:

Added to the repo: 2.115 GiB

and then restic diff <parent> <new>:

Added:   2.115 GiB
Removed: 1.727 GiB

is the reason 'added to the repo' is not net of the 'removed' figure that all of what was removed is still referenced by at least the parent snapshot, so we added 2.115GiB worth of new (de-duplicated) blocks, removed references to 1.727GiB worth of old ones, but until a prune, restic backup itself will only ever add, and always equal to the 'added' figure in the resulting diff?
Many thanks.

Added:   2.115 GiB
Removed: 1.727 GiB

is the reason 'added to the repo' is not net of the 'removed' figure that all of what was removed is still referenced by at least the parent snapshot, so we added 2.115GiB worth of new (de-duplicated) blocks, removed references to 1.727GiB worth of old ones, but until a prune, restic backup itself will only ever add, and always equal to the 'added' figure in the resulting diff?

The added and removed numbers of backup and diff are independent of each other. backup reports how much new data was uploaded. diff reports the change between two snapshots. The added numbers can match, but there's no need to.
Just assume that you have a file "x" that has already been backed up in the past, but which you deleted in the meantime. That is "x" would not be included in the parent snapshot. Now, restore file "x". Then the new snapshot will include file "x" again. backup will deduplicate the file (as it still exists in an older snapshot) and therefore not add data to the repository. diff on the other hand will report that "x" has been added.
The Removed numbers show how much space could be freed by deleting the parent snapshot, under the assumption that the removed files are not referenced by any other snapshot. That is Removed is an upper boundary on how much space can be freed by deleting the parent snapshot.
A more reliable way to determine how much data can be freed by removing certain snapshots is to use restic stats --mode raw-data <kept-snapshots> to calculate how much space is required to store the snapshots that should be kept. Then subtract the repository size from that result.

Isn't the on-disk size covered by the "processed  files,  in " output just before the hash of the new snapshot? Not sure if that was added after this issue was created...


Please format the generated code

Hi. Would you mind running 'flutter/dart fmt' on the generated code please.
Many of my projects have checks to ensure that the code is formatted correct. This is usually done with a simple dart format -o none --set-exit-if-changed .
However, dart/flutter don't provide a way to exclude files from the formatting, and the dart team don't plan on fixing this - https://github.com/dart-lang/dart_style/issues/864 . This results in me having to implement the exclusion on my end, or format the generated code. I've finally done the latter, but I don't like having to add an explicit 'flutter format' for this package.
It would be awesome if this package could format its generated code. It would save me (and others) a lot of headache.

There is an option for formatting generated code:
assets_gen:
  ...
  format_dart_code: true

Could you have a try? 😆

I really should have read the docs better.
Sadly it doesn't seem to work for me. The file still isn't formatted
$ dart format -o none --set-exit-if-changed lib/generated/assets.dart
Changed lib/generated/assets.dart
Formatted 1 file (1 changed) in 0.12 seconds.

Also, out of curiosity, why not enable it by default?

Please try 1.4.1, it should fix the format issue.

Thank you. This works perfectly!


fixes and cleanup for pre-0.7 work - "butter risky"

The following contains a series of improvements for the Confluence builder extension. Most notables includes:

Corrects slew of markup/publishing errors observed in #39, #40 and #41 (see 255043422d25f8e437baf3182eafa6464a1ab288 and b6bb29230db22ccc45a5852c75f88ef4cfbea422).
Corrects unexpected "garbage" encoding data in #52 (see fa206b18982ad7765fd23e57b47718c6795df5ac).
Have title references emphasized (instead of strong'ed).

Perform validation set testing on Confluence 6.0.6 server (REST and XML-RPC) and Confluence Cloud  (REST and XML-RPC) with expected/improved results.

@jdknight ready for release

@tonybaloney Thanks! I'll do some re-testing to re-sync myself, take a look at the recent issues to see if there's anything critical and if everything good I can ping you to wrap up the owner tasks in #29 (if you thin that's a good plan).


Compatibility with Python3

Installation via pip3 is not possible due to use of Python2-only commands.
Collecting robotframework-mqttlibrary
  Downloading robotframework-mqttlibrary-0.5.0.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/n1/wsd2x88j48d6yr5dmwqs71m80000gn/T/pip-build-u7hpj9cr/robotframework-mqttlibrary/setup.py", line 9, in <module>
        execfile(join(here, 'src', 'MQTTLibrary', 'version.py'))
    NameError: name 'execfile' is not defined

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/n1/wsd2x88j48d6yr5dmwqs71m80000gn/T/pip-build-u7hpj9cr/robotframework-mqttlibrary/

Upvoting this one.

@randomsync what do you think? python 2.x is going to be deprecated by 2020 as pip is also suggesting. Should this library be python 2 compatible or is python3 enough?

Since python 2.x will be deprecated, there might not be a need to keep it python 2 compatible. However, I would love to get some help in making it python 3 compatible, as I haven't had time or would have time in near future to look into it.

@randomsync I have added compatibility with python3 in #13 , please have a look.

This has been merged and released in v0.7.0. Thanks @vogoltsov


Fmri utils

Do you have a good way to test this against current experiments that require it (to make sure nothing breaks?)

No experiment in expfactory-experiments uses this. I've tested it on the experiments I'm modifying to use it, but those are located in a separate repo. The reason I am adding this as a module to expfactory (rather than keep it in that separate repo) is it adds a simple function for converting javascript experiments into fmri-ready experiments. The function is defined with our scanner in mind however, so let me know if you think it doesn't belong as part of expfactory.

I leave it up to your judgment, the eventual plan with expfactory is to have all experiments (and dependencies) in containers, so tweaks to the current version (as long as they don't break anything) are ok with me.


DROP: Upgrade google.golang.org/protobuf to v1.34.2 to resolve CVE in ray-operator

Why are these changes needed?
Upgrade google.golang.org/protobuf to v1.34.2 to resolve CVE in ray-operator

Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Oh I see https://github.com/opendatahub-io/kuberay/commit/61b0d76b7633cc0a447be3828932324b8d68928b was for the apiserver :)


Add option for basic auth of web endpoints

Uses flask-basicauth to set up basic authentication for all endpoints if the following env vars are present:
DPP_BASIC_AUTH_USERNAME
DPP_BASIC_AUTH_PASSWORD

@akariv Tests are failing because of a missing tests/data/datapackage3.json referenced file in tests/stdlib/fixtures/simple_load_resource_dups. Have you got this?

Pushed the missing files... sorry :)
On Fri, Jun 22, 2018 at 4:13 PM Brook Elgie<EMAIL_ADDRESS>wrote:

@akariv https://github.com/akariv Tests are failing because of a
missing tests/data/datapackage3.json referenced file in
tests/stdlib/fixtures/simple_load_resource_dups. Have you got this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/frictionlessdata/datapackage-pipelines/pull/131#issuecomment-399438126,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQMdRZMjnMG9RJ6qWw_qgAvjGqyp0c3ks5t_O2SgaJpZM4Uzugz
.

Thanks @akariv. Can you have a quick look at #130 too. I won't be able to do a release unless we pin Flask.


How to ignore entries present in the filter URL?

Hello! The tool you developed is incredible. Congrats on the job!
Now how can I ignore some variables in the entry of my URL?
For example, the number 1 in the image below shows the filters that are needed. The parameters of item 2 are only required to display some items in the PDF. That is, these parameters are used as flags (true or false).

Is it possible to do that?
My URL:
//Get /filter?year=2019&identification=9999&city_id=1&institution_id=4&movement_status=on&origin_resource=Com+emenda
[
    'year'  => '2019',
    'identification' => '9999',
    'city_id' => '1',
    'institution_id' => '4',

    // I want to ignore...
    'movement_status' => 'on',
    'origin_resource' => 'Com emenda'
]

Hello! The tool you developed is incredible. Congrats on the job!

Thank you for your kind words.

Now how can I ignore some variables in the entry of my URL?

Each parameter that has a value applies as a filter.
If you want to ignore some filters set them with empty or null value.
For more info see ignore filters on null value in readme file.

@mohammad-fouladgar I got to see this section in the documentation. For the case of the parameter movement_status would work, because in it I only need two values (0 or 1; on or off; not empty or empty).
The problem is exactly in the origin_resource parameter. In it I need to identify the difference between 3 possibilities. That's when I can not ...

@ronaldaraujo Normally, when a filter is displayed, submitted and has a value, it applies.
I think you should check this filter in your logic.
It's possible I see your 'Controller' and OriginResourceFilter?
What do you think we have a method to ignore some of the filters?
Like the following:

ignoreFilter()
ignoreOnlyFilter()
ignoreExpectFilter()
...

$users = EloquentBuilder::to(User::class,$filters)->ignoreFilter('some_filter(s)')->get()

@mohammad-fouladgar maybe I have to fix my logic, but in my current scenario there are two inputs that are not part of any filter in the database. As I mentioned earlier, they would only be used to display a particular piece of content within the PDF.
This is the view:
{{ Form::open(array('role' => 'form', 'method' => 'GET', 'route' => 'processes.filter')) }}

Preencha uma ou todas as informações abaixo para filtrar

                    {{ Form::label('year', 'Ano') }}

                        {{ Form::text('year', null, array('class' => 'form-control pull-right datepicker-only-year')) }}

                    Identificação
                    {{ Form::text('identification', null, ['class' => 'form-control']) }}

                    Município
                    {{ Form::select('city_id', [], null, ['class' => 'form-control']) }}

                    Órgão
                    {{ Form::select('institution_id', [], null, ['class' => 'form-control']) }}

Filtros extras para a geração do relatório em PDF

                    <input type="checkbox" name="movement_status" id="movement_status">
                    Marque para exibir o status da movimentação no relatório em PDF

                    {{ Form::radio('origin_resource', 'Com emenda', null, ['id' => 'with_amendment', 'checked']) }}
                    Com emenda

                    {{ Form::radio('origin_resource', 'Com programação', null, ['id' => 'with_programming']) }}
                    Com programação

                    {{ Form::radio('origin_resource', 'Com emenda e programação', null, ['id' => 'with_amendment_and_programming']) }}
                    Com emenda e programação

        {{ Form::submit('Filtrar', ['class' => 'btn btn-danger']) }}
        {{ Form::submit('Gerar PDF', ['formtarget' => '_blank', 'name' => 'pdf', 'class' => 'btn btn-danger']) }}

{{ Form::close() }}

Note that there are two buttons:

"Filtrar": is used to filter the data and display on the screen;
"Gerar PDF": is also used to filter, but will open a new browser tab with the PDF content.

See my controller:
public function filter(Request $request)
{
    $processes = [];

    if (isset($request['pdf'])) {
        $processes = EloquentBuilder::to(Process::class, $request->all())->get();

        return PDF::loadView('dashboard.process.pdf', compact('processes'))
                    ->setPaper('A4', 'portrait')
                    ->stream('SAGCIC - Emendas.pdf');
    } else {
        $processes = EloquentBuilder::to(Process::class, $request->all())->paginate();

        return view('dashboard.process.index', ['processes' => $processes, 'filters' => $request->all()]);
    }
}

In summary, it would be amazing if we had some of the methods you mentioned:

ignoreFilter()
ignoreOnlyFilter()
ignoreExpectFilter()
...

@ronaldaraujo
Have you tried this  $processes = EloquentBuilder::to(Process::class, $request->only('the_fields'))->get(); or ? Personally, I will not pass all the request data to the filtering methods.

@joefazee I had already thought of something similar:
$movementStatus = $request['movement_status'];
$originResource = $request['origin_resource'];
$request = $request->except(['movement_status', 'origin_resource']);

However, I believe that there will be many fields in the front, so I was looking for something inside the library to leave the code clean.
But, thanks for the suggestion.

Personally, I will not pass all the request data to the filtering methods.

@joefazee You pointed to a nice note.
@ronaldaraujo  You must send the filters separately. Look at the example below:
/process?filters[identification]=999&filters[year]=2019&filters[city_id]=1&filters[institution_id]=4&movement_status=on&origin_resource=Com+emenda

Then usage like this below:
$processes = EloquentBuilder::to(Process::class, $request->only('filters'))->paginate();

Please feel free to any question :wink:

Implemented successfully.
Thanks to all for your help :)


Is this project still alive?

We try and commit code when we have the spare time :)

Glad to hear it.


Github page

I just gained access to Bootstrap Studio with a student license. I could try it out there. Do you have something in mind ?

I think the studio version is just an app for better designs, or does it change anything?, also, what happens after the student version is over? do we need to purchase it?
I wouldn't mind in general, but if there's a restriction of using only the studio version during or after the licence expires, then I do mind.

e

There are no restrictions. One export the project to readable html and then we can modify it like a 'normal' web page.

Cool, no problems then :)
From: Tanguy Andreani<EMAIL_ADDRESS><EMAIL_ADDRESS>Reply: elfenars/ruby-discord-bot
<EMAIL_ADDRESS><EMAIL_ADDRESS>Date: April 23, 2018 at 12:36:13
To: elfenars/ruby-discord-bot<EMAIL_ADDRESS><EMAIL_ADDRESS>CC: Feña Agar<EMAIL_ADDRESS><EMAIL_ADDRESS>State change
<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject:  Re: [elfenars/ruby-discord-bot] Github page (#6)
There are no restrictions. One export the project to readable html and then

we can modify it like a 'normal' web page.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/elfenars/ruby-discord-bot/issues/6#issuecomment-383530737,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvpAzMlgJwOlI4gSNVAGr6sAW9Q66KSks5tra6dgaJpZM4S56J5
.

So do you have something in mind ?

Not really, something simple with an intro and some docs on how to use and develop should do.


"Last changed" shows a time in the future

For any feature request you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/feature-requests
For any question you can open a new discussion here:
https://github.com/Clooos/Bubble-Card/discussions/categories/q-a
Describe the bug
"last changed" timestamp is 1 hours in the future
To Reproduce
Steps to reproduce the behavior:
In button settings, activate: Optional - Show last changed
Expected behavior
I expect the indication of the last changed time to be "1 second ago" instead of "in 3599 seconds"
Screenshots

YAML
If applicable, add any relevant YAML code.
 Not on my laptop or on my phone. I can conceive it might be an issue with my browser, but I can't imagine what.
Additional context
Add any other context about the problem here.
Thank you! 🍻

This was caused by a timezones misconfiguration that (weirdly) only manifested via the home assistant docker image.

@RmigD Thanks for the feedback and for closing.


Property 'strokeDash' not found on object of type 'RNSVGPath

This error occured when I updated to new version 1.1
Property 'strokeDash' not found on object of type 'RNSVGPath

Thx for reporting this.
got this fixed in 1.1.2


Support multiple decorations in editor glyph margin

In order to support share link decorations in the glyph margin for my share contribution proposal, I started down the path of reconciling multiple decorations with https://github.com/microsoft/vscode/pull/179657. I missed an existing issue with discussions https://github.com/microsoft/vscode/issues/114776, which Connor pointed me to in standup today. I don't think my PR can be merged as is, from standup feedback, there are two main concerns with the approach I took, which does the naive thing of expanding the glyph margin to accommodate decorations:

Anything more than 3 decorations in the glyph margin starts to look unreasonable
The current behavior doesn't render decorations at predictable offsets, which impacts muscle memory e.g. for setting breakpoints (and begs for some kind of 'lane' treatment per decoration type)

Therefore I'm opening this issue to discuss the approach we take, which should address the following issues (I'm creating a new issue to avoid mass-pinging all existing issue subscribers):

https://github.com/microsoft/vscode/issues/5923
https://github.com/microsoft/vscode/issues/114776
https://github.com/microsoft/vscode/issues/5455

Summary of existing discussion
Summarizing some alternative proposals from the above issue thread https://github.com/microsoft/vscode/issues/114776 and from standup, there are two main questions to solve:

How should we render decorations if there are multiple?

Have dedicated lanes for decoration types

We would merge all decorations into a single lane if no line has more than one decoration type, to preserve the nice behavior that test coverage extensions offer
This still potentially suffers from pathological cases with lots of decorations so requires some kind of overflow behavior

Have one dedicated lane for breakpoints (common case), and show all other decorations in a second lane
For overflow behavior, sort by each decoration's zIndex to figure out which decoration to render as the placeholder in the overflow
For common cases like testing and debug, the decorations can specify how to merge them to avoid overflow

Many but not all decorations are actionable, how do we decide what action to take?

Have decorations provide an onClick handler, if there's only one decoration registering an onClick handler we should execute that handler, otherwise show the context menu
Show overflowed decorations on hover (since the user still needs to be able to see non actionable decorations) and allow to click on decorations to execute their onClick handlers if any

Proposed approach
I'd like to rework my PR to incorporate the proposals that the team has suggested. Here's what I'm thinking of doing, please let me know what you think:

Create at most two lanes in the glyph margin

One lane is reserved for breakpoints (the hint as well as the actual breakpoint/logpoint)
Another lane is reserved for all other decorations, actionable or otherwise

This includes the diff revert icon, testing decorations, and extension-contributed decorations
If there is more than one decoration to render, we will decide which one to show based on the decoration's specified zIndex

Any lower priority decorations will be shown in a hover that still allows users to select or click the decorations, this is similar to what Atom did
It should be possible to tab to the overflowing decoration and hit tab to trigger the hover, then use left and right arrows to navigate between decorations. There should also be descriptive alt text for the decorations whether or not they are connected to onClick handlers

One question is whether to create space for one or two lanes if there are no decorations other than breakpoints to be rendered. I propose that we should create two lanes in order to avoid the glyph margin resizing in order to create the lane for a breakpoint hover hint if the user hovers over a non-breakpoint decoration and wants to set a breakpoint (though if this ends up behaving poorly I'm also happy to just have one lane)

Add support for optional onClick handlers in decorations and adopt them in core-contributed decorations

This is to support interacting with overflowed decorations in the proposed hover runs associated actions, which aligns with user expectations and achieves parity with what breakpoints have (today breakpoints and testing have separate context menu handlers)

Breakpoint clicks will work the way they currently do
If there are overflowing decorations and only the highest-priority decoration has a click handler, we will run that decoration's click handler when the user clicks that decoration
If there are overflowing decorations and a decoration which is not the highest-priority decoration has a click handler, we will display the hover

Expose support for running extension-contributed actions in decorations

This could be a command attribute in TextEditorDecorationType, or an event vscode.window.onDidSelectTextEditorDecoration

cc @alexdima

When there is more than one decoration provided for the second lane I think should be a visual indicator to tell me it is worth hovering over or navigating to so the hidden decorations appear.

@joyceerhl I really like your proposal. Given this might be a lot of work, and a lot of changes, my suggestion would be to stage the work in steps and split it up across multiple PRs.

@gjsjohnmurray good point, I think the dominant proposal for that is to render a badge, ellipses or a 🔽 next to an overflowing decoration to indicate that there are overflowing items. I'll pick one of those options in the initial exploration.
cc @connor4312 @rebornix @isidorn for additional feedback since you've had input on this issue in the past/in standup

Insightful write and the proposal is great 👍

One question is whether to create space for one or two lanes if there are no decorations other than breakpoints to be rendered. I propose that we should create two lanes in order to avoid the glyph margin resizing in order to create the lane for a breakpoint hover hint

Not sure if we want a wider gutter all of a sudden for all editors. Maybe we can check if there is debug adapter registered to control if breakpoint lane should be created, for example, it doesn't need to be created in markdown files in vanilla markdown, otherwise we will have an empty lane which doesn't do anything.

Thanks for the writeup. I agree with @rebornix - let's try to minimize doubling the gutter and only do that when it is really needed.
Reading the above, option 2. ii) sounds interesting to me - "Show overflowed decorations on hover". With that we would minimize the additional real estate we need. What is downside of that approach compared to the two gutters one?

@isidorn yeah, I proposed that we do both (have a dedicated breakpoint lane if it makes sense to render one, as well as render overflowing decorations via a hover). We need to solve the overflow problem regardless, and the dedicated lane allows that we can still show the breakpoint hover hint if there's already a decoration on that line (e.g. if you had test coverage decorations for every line in the file, you'd still be able to set breakpoints easily).

This sounds awesome! Can't wait for it all to land 😁

That's great news! Eager to use and contribute to it.
I follow @connor4312 preference for a dedicated debug lane, and as @eamodio commented, Rider UI approach to put breakpoint over the line number is interesting.
My only fear is about embracing zIndex to stack decorators. I wonder if it would end up extensions fighting with each other for the higher value. But I also understand that a wider gutter would not be great for some users as well (not my case, TBH). Maybe this could be a setting, leaving the user the decision on how to see the extension-contributed decorators in gutter. If you follow a wider gutter approach, maybe a new Contribution Point could defined, for extension authors contribute to gutter decorations. Doing so, VS Code could know upfront how many decorations it would have to deal with, and prepare the gutter according to it.
Thank you


Add FBTestManagerTestReporterComposite

As discussed in #281

Looks good from my side, aside from a few comments. I did want to remove OCMock as a dependency at some stage so the tests had no external dependencies, but that shouldn't hold up your changes.

Make sure to expose the class as public header in the project and add it to the umbrella header for the Framework.

Thank you for your feedback! I have addressed everything in separate commits. If you think it looks fine, I can squash all the commits in a single one before you're merging it.

This is really cool 👍

I can squash all the commits in a single one before you're merging it.

You don't have to worry about this in the future, the facebook robot should do this when I......
@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

Thank you 👍


Speed up rllib test

Shorten the time of the test_rllib_hiway_env test.

What is the speed improvement for this? I think this test took around 30 mins on my machine originally.

Not sure if this is reasonable, how about we create a even simpler scenario or duplicate an existing scenario just for the test and maybe gitignore it to prevent possible accidentally removal of it? I just have a feeling that in the future somehow we might forget that we have set this scenario for the test and delete it for some reason..

Not sure if this is reasonable, how about we create a even simpler scenario or duplicate an existing scenario just for the test and maybe gitignore it to prevent possible accidentally removal of it? I just have a feeling that in the future somehow we might forget that we have set this scenario for the test and delete it for some reason..

I do not think that is possible since it is linked to the CI.

What is the speed improvement for this? I think this test took around 30 mins on my machine originally.

I had the test take 3 minutes with this version.

@saulfield I think the next step after may be to limit the number of CPUs.


Update to build VS Code using latest TS nightly

Looks unblocked now that playwright-test has also been updated


ADDED flag to hide example text on init (WIP)

Closing this as the branch got in a mess with the vendors directory


Hitting "unreachable" code in the VM

vm-service: isolate 'analyzer.dart$main' has no debugger attached and is paused at exit.  Connect to Observatory at http://<IP_ADDRESS>:8181 to debug.
runtime/vm/object.cc:3347: error: unreachable code
/usr/local/google/home/floitsch/local/scripts/dart: line 1: 11314 Aborted                 (core dumped) $HOME/code/dart/sdk/out/ReleaseX64/dart $@

$ dart --version
Dart VM version: 1.15.0-edge.7a7ecf299ba684f81931a8c5ed2cf42eca4f573d (Fri Feb 19 16:38:54 2016) on "linux_x64"

I'm not sure if that was the reason but here were the actions (as far as I remember):

launch with --observe.
go into the debugger (at exit)
write vm restart.
Say no.
Try to set breakpoint. (But I think the VM was already disconnected at that moment.

Forget the vm restart. It's the setting a breakpoint that triggers the error.
I can reproduce with the latest bleeding edge: a8d71a461d82a54a5d9a2a7feac4faa74981aafc
dart --observe --package-root=$PWD/out/ReleaseX64/packages pkg/analyzer_cli/bin/analyzer.dart  --options=/tmp/options --dart-sdk=$PWD/sdk tests/language/config_import_test.dart --package-root=$PWD/out/ReleaseX64/packages
Go to the debugger.
Write b  and press tab to auto-complete. This crashes the VM.

I can reproduce this locally as well here is the back trace. cc @johnmccutchan
 * frame #0: 0x00007fff9362f002 libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fff973eb5c5 libsystem_pthread.dylib`pthread_kill + 90
    frame #2: 0x00007fff8d3ea6e7 libsystem_c.dylib`abort + 129
    frame #3: 0x00000001002902e9 dart`dart::OS::Abort() + 9 at os_macos.cc:386
    frame #4: 0x00000001000296f7 dart`dart::DynamicAssertionHelper::Fail(this=<unavailable>, format="%s") + 791 at assert.cc:42
    frame #5: 0x0000000100225372 dart`dart::Class::ComputeEndTokenPos(this=<unavailable>) const + 434 at object.cc:3368
    frame #6: 0x000000010028517d dart`dart::Class::PrintJSONImpl(this=0x0000700000408f70, stream=<unavailable>, ref=<unavailable>) const + 1597 at object_service.cc:111
    frame #7: 0x000000010034a2ef dart`dart::GetObject(thread=<unavailable>, js=0x00007000004089f0) + 511 at service.cc:3540
    frame #8: 0x0000000100345a2f dart`dart::Service::InvokeMethod(I=0x0000000101801000, msg=<unavailable>) + 1663 at service.cc:839
    frame #9: 0x00000001001f3a59 dart`dart::IsolateMessageHandler::HandleMessage(this=0x0000000100c0a990, message=0x0000000100f233f0) + 2025 at isolate.cc:521
    frame #10: 0x0000000100213971 dart`dart::MessageHandler::HandleMessages(this=0x0000000100c0a990, allow_normal_messages=false, allow_multiple_normal_messages=true) + 289 at message_handler.cc:206
    frame #11: 0x0000000100213de8 dart`dart::MessageHandler::TaskCallback(this=0x0000000100c0a990) + 360 at message_handler.cc:357
    frame #12: 0x0000000100371b76 dart`dart::ThreadPool::Worker::Loop(this=0x0000000103517260) + 54 at thread_pool.cc:387
    frame #13: 0x0000000100371a50 dart`dart::ThreadPool::Worker::Main(args=4350636640) + 96 at thread_pool.cc:442
    frame #14: 0x0000000100290837 dart`dart::ThreadStart(data_ptr=<unavailable>) + 71 at os_thread_macos.cc:97
    frame #15: 0x00007fff973e9c13 libsystem_pthread.dylib`_pthread_body + 131
    frame #16: 0x00007fff973e9b90 libsystem_pthread.dylib`_pthread_start + 168
    frame #17: 0x00007fff973e7375 libsystem_pthread.dylib`thread_start + 13

Actually this doesn't look related to the service protocol. @mhausner

I cannot repro this. With the command line
dart --package-root=xcodebuild/DebugX64/packages/ --observe
./pkg/analyzer_cli/bin/analyzer.dart --dart-sdk=./sdk
tests/language/config_import_test.dart --package-root=xcodebuild/DebugX64/packages/

I don't get a crash when I connect to the debugger via the Observatory. I can break into the running program, set breakpoints, step through code, and eventually Analyzer completes with the expected output, which is a litany of complaints because it does not understand the conditional import statements.
Analyzing [tests/language/config_import_test.dart]...
[error] Expected to find ';' (/src/d2/sdk/tests/language/config_import_test.dart, line 10, col 8)
[error] Unexpected token 'if' (/src/d2/sdk/tests/language/config_import_test.dart, line 11, col 3)
...

I can still repro on bleeding edge. I followed exactly my steps.

I saw Florian S repro it yesterday, but I have no luck. Keep trying...

Ok, got it.
The assertion is because Class::ComputeEndTokenPos() is called for class "ArgParserContributor" (from pkg/analyzer/lib/plugin/command_line.dart) that is just a typedef, not a class with a body.
Investigating...

Proposed fix:
https://codereview.chromium.org/1767113007/

Fixed with 5db2c56b5bb5c7e18146f11e2d4baf07e34d5fbb


Preview isn't live updated in sticky mode

When I lock note to preview, the Preview content is not auto-updated when I edit the note.

The point of pinning is to freeze the window so you can look at other notes or reference a note in other applications. It intentionally locks the updating.


release-cross.nix: fix cross bootstrap tools eval

Description of changes
In #175484, I changed pkgs/stdenv/linux/make-bootstrap-tools.nix
to take a package set instead of system and localSystem arguments, but
I forgot to update make-bootstrap-tools-cross.nix.
Now that we have a package set in make-bootstrap-tools-cross.nix, we
can use pkgsCross to avoid full re-evaluations of Nixpkgs for each
platform.
I'm not sure why release-cross.nix hardcodes the build system to
x86_64-linux, so I've left that as-is.
Fixes: 5643714dea5 ("stdenvBootstrapTools: inherit {cross,local}System")
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I would rather not use pkgsCross. I don't really like pkgsCross in general -- it is very gross it is part of the package set and not some out of band convenience.
If we want some sort of memoization maybe we can factor that out, e.g. into a new pkgs/top-level/memoized.nix?

I've pushed an implementation using release-lib.  The supportedSystems = [] hack I had to do is unfortunate — really that should just be an argument to the two functions in release-lib that use it…

I'm a bit late to the discussion here, but...

I don't really like pkgsCross in general -- it is very gross it is part of the package set and not some out of band convenience.

Does this dislike extend to pkgs.buildPackages?
I always thought of pkgs: pkgs.pkgsCross._ as the right inverses of pkgs: pkgs.buildPackages.

I get very nervous about platform enumeration happening for no good reason

Manually-coded enumeration bothers me too.  Unfortunately because so much software needs Rosetta Stones we can't really avoid having a manual enumeration for each of the four non-vendor components of a multiarch tuple: cpu-and-mode, kernel, libc, abi.  Would it still make you nervous if lib.getAttrs (pkgs.pkgsCross) were defined as the product of those lists (possibly filtered to remove nonsense combinations)?
Unfortunately nix doesn't have a high-precedence postfix function application operator.  If people have to write (pkgsCross "awesome-platform").myPackage they may resort to torches and pitchforks... so it might be hard to avoid some kind of enumeration since the set of attributes in an attrset must be finite.

pkgs: pkgs.targetPackages is the correct right inverse

I think that's the left inverse of pkgs: pkgs.buildPackages.

so e.g. pkgsCross.${x}.pkgsCross.${x} == pkgsCross.${x}

Oh wow, yes, that is gross.  And unexpected.

Nix can share eval work for attributes, but doesn't memoize functions.

Hrm, I thought it did.  I guess this changed?  From edolstra's thesis, section 4.4:

maximal sharing: if two terms are syntactically equal, then they occupy the same location in memory. ... Maximal sharing is implemented through a hash table.  Whenever a new term is created, the term is looked up in the hash table.  If the term already exists, the address of the term obtained from the hash table is returned.

I think the LISP people call this "hash consing".

Hrm, I thought it did. I guess this changed? From edolstra's thesis, section 4.4:

This is only the case for variable bindings, attribute sets etc. Functions behave like this (utilising the fact that valueSize can be (ab)used to observe whether a thunk has been evaluated yet or not):
nix-repl> f = x: x

nix-repl> builtins.valueSize (f {})
270130

nix-repl> f {}
{ }

nix-repl> builtins.valueSize (f {})
270130

nix-repl> x = f {}

nix-repl> x
{ }

nix-repl> builtins.valueSize x
32


SelectionCriteria is missing on find query

Hi 😄!
I wanted to excluded some attribute on my find() Mongodb query but I can't.
Indeed, On your find() implementation, I didn't found the selectionCriteria (only filter & findOptions are provided).
Mongodb documentation : here
Mongo rust driver find() implementation : here

Now you can achieve this through projection
db.collection.findOne( { }, { projection : { _id : 0 , name : 1 } } )


Proper check for UTF8 dependency

Added a test for UTF do proper UTF8 checks on startup and if check fails,it fails with a useful error message there.
as suggested here : https://github.com/mitmproxy/mitmproxy/pull/3874#issuecomment-607691135

Thanks for the PR - unfortunately this won't do very much in the setup.py file.
I suppose this logic should go somewhere in the files in mitmproxy/tools/.

Hey,
Thanks for reviewing the PR!
Can you tell me which linter is being used in the script, since there is no issue on my system.
Also should  add the logic in the _main.py ?


"Run the tests" button doesn't work

Describe your problem and - if possible - how to reproduce it
"Run the tests" button doesn't work properly
Add a Link to the page with the problem
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/accessing-nested-objects
Tell us about your browser and operating system

Browser Name: Google Chrome
Browser Version: Version 68.0.3440.106 (Official Build) (64-bit)
Operating System: Windows  10 pro

If possible, add a screenshot here

This "bug" is usually caused by your code being invalid.  In your case, try removing the , or . that's after the = in the line that starts with var gloveBoxContents =.  Stray characters are one of the most common bugs in code and can break everything.

From: Arnel Forbes<EMAIL_ADDRESS>Sent: August 21, 2018 10:02 PM
To: freeCodeCamp/freeCodeCamp
Cc: Subscribed
Subject: [freeCodeCamp/freeCodeCamp] "Run the tests" button doesn't work (#18038)
Describe your problem and - if possible - how to reproduce it
"Run the tests" button doesn't work properly
Add a Link to the page with the problem
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/accessing-nested-objectshttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.freecodecamp.org%2Fjavascript-algorithms-and-data-structures%2Fbasic-javascript%2Faccessing-nested-objects&data=02|01||22c6a0d954c34dc1b8a108d607cae990|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636704965407934706&sdata=ScML1rlxwrga6%2BX%2BDSWfRGZZQGIpRKPob18v3feNjis%3D&reserved=0
Tell us about your browser and operating system

Browser Name: Google Chrome
Browser Version: Version 68.0.3440.106 (Official Build) (64-bit)
Operating System: Windows 10 pro
[image]https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F35647539%2F44436838-4ef2be00-a5f2-11e8-835a-94bfd72dc6b4.png&data=02|01||22c6a0d954c34dc1b8a108d607cae990|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636704965407934706&sdata=yIrnsU9iRZ4KFNoP1puMuke3rC7lOJUqp4hYROL18Xc%3D&reserved=0

If possible, add a screenshot here
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FfreeCodeCamp%2FfreeCodeCamp%2Fissues%2F18038&data=02|01||22c6a0d954c34dc1b8a108d607cae990|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636704965407934706&sdata=xTmobHczO6%2FRBRqbfZE5qOoNgj0j3hWwfuzmi5uD2co%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF-4BYDqW7rxr-yRJHjv0YJr5U05AGYyks5uTK2bgaJpZM4WG0ve&data=02|01||22c6a0d954c34dc1b8a108d607cae990|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636704965407934706&sdata=QeJSqETZrnK4Pz9Gs87%2BRYTGrMmrN2BSGcWoJki%2FovM%3D&reserved=0.

im sorry for the "dot" after equals during screenshot but its still dont work even dot is ommited.