wasm-bindgen-cli: 0.2.75 -> 0.2.78

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

wasm-bindgen-cli's tests doesn't work outside the repository, should I keep it this way or do fetchCrate with doCheck = false; or try to patch the tests, which wouldn't be trivial, but it would be smaller than the current path


Update Corsican translation on January 2023

Hello,
This is an update of Corsican localization to change a couple of existing strings and add several new strings.
To identify the new strings, I browsed some existing locales for comparison because I didn't find any 'official' template.
Please can you check and confirm these new strings - from line 33 to 58 - need to be part of this file?
Cheers,
Patriccollu.

Thanks a lot for updating the translation. Indeed, there is no template for this one as the XML is embedded into C code and cannot be opened in the Translator app anyway.
The entries from line 33-58 belong here indeed. Entries 33-38 appear as edit commands in text fields' context menus. Entries 40-58 are used to compose keyboard shortcut hints in menus and should contain the common names of the keys or the text that is printed on the respective key, if applicable.
For example, the "Insert" key is just named Ins, because that's what printed on the key on English keyboards. In the German translation, it's Einfg, because that's whats printed on the key. Although we call the key "Einfügen" and a proper abbreviation would include a dot at the end "Einfg.", but neither is printed on the key on German keyboards.
Not sure if 40-58 are correct under these constraints. Can you confirm or adjust the translations if necessary?

Thank you for your comment @enzo1982
I just updated the file with some more appropriate changes.

Merged, thanks!


updated rllib examples to conform to rllib verison 0.5.0 DO NOT MERGE

All examples are updated to work in 0.5.0
Merging blocked until ARS PR is merged and eugenevinitsky/Ray is updated

Note, this is expected to fail the tests for now.

Comments addressed.


";" is duplicate when creating view

System information:

Operating system (distribution) and version win 10 x64
DBeaver version 6.0.1

Describe the problem you're observing:
[View creation] If query is ended with ";", it is duplicated when trying to save created view

verified


lets use a watch to wait for the docker-registry to start on minishift to make sure it doesn't barf later on due to a DC deploy timeout

[merge]


Roll Engine from fae92ed57427 to 0ce1137b7324 (6 revisions)

https://github.com/flutter/engine/compare/fae92ed57427...0ce1137b7324
2020-11-16<EMAIL_ADDRESS>[Android] Add systemNavigationBarDividerColor (flutter/engine#22538)
2020-11-16<EMAIL_ADDRESS>Roll Skia from cce84d1fd893 to 5a89ed542f06 (7 revisions) (flutter/engine#22539)
2020-11-16<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from E3briMHHv... to 2R7OWHAQq... (flutter/engine#22537)
2020-11-16<EMAIL_ADDRESS>Roll Dart SDK from 92e087bf82e2 to d67a5c245285 (1 revision) (flutter/engine#22536)
2020-11-16<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from 6LXPsNi-P... to LOnq8wpIx... (flutter/engine#22534)
2020-11-16<EMAIL_ADDRESS>Roll Skia from 031a76756e24 to cce84d1fd893 (4 revisions) (flutter/engine#22533)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from E3briMHHvl6d to 2R7OWHAQqLwf
fuchsia/sdk/core/mac-amd64 from 6LXPsNi-PFxz to LOnq8wpIxWpg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


CellProfiler workflow: optional scatter

This is an attempt to unify the "distributed" and "single-VM" CellProfiler workflows into the same workflow. It will scatter if you specify the input splitby_metadata as something other than "".
It has the option to copy outputs to a google bucket.
But it will also work without copying to a google bucket: the output files are outputs of the workflow (i.e. they will be copied to the Cromwell execution directory). The outputs are arrays. Each array element will be one scatter unit, if scattering occurs, and otherwise the array will have only one element.
Totally untested.

Excellent points!

Also:
3. illum_directory should be optional, at this moment it is a required variable
About load_data as an input vs config_yaml & plate_id. I think the best way is to make all of them optionals, and first do the check if the user passed either the .csv or the other two, and error out if the user failed passing the necesary input, @sjfleming is that a good idea or you have a better suggestion?

Oh I see... illum_image_dir is an input to cellprofiler_pipeline.wdl.... is that what you mean for (3)?  So we might have to change cellprofiler_pipeline_task a bit?
About the triplet of inputs ... I think you are right.  I think we could have the inputs in cellprofiler_pipeline so that they are all Strings, but they all have default values.  So they are "optional" (but always defined, so that the task will not complain about trying to coerce a String? to a String).
String load_data_csv = ""  # leave blank to run generate_load_data_csv task
String config_yaml = ""
String plate_id = ""

and then we can leave that part of the workflow almost as it is (adding the inputs):
# The load_data.csv file
  if (load_data_csv == "") {
    call util.generate_load_data_csv as script {
      input:
        xml_file=xml_file,
        stdout=directory.out,
        config_yaml=config_yaml,
        plate_id=plate_id,
    }
  }
  String load_data_csv_file = select_first([script.load_data_csv, load_data_csv])

because the section will skip if load_data_csv is provided.  On the other hand, if load_data_csv is not provided, that block will execute and util.generate_load_data_csv will immediately try to interpret config_yaml as a File, and the whole thing will error out if config_yaml is not provided.  The only catch here is that a user would still be allowed to not provide plate_id... and it would still run fine with plate_id = ""

About the illum_image_dir, it is a required input for the task splitto_scatter, to solve this I will define a default input as we did in the cpd_analysis_pipeline.wdl

About the triplet of inputs: Yes! I'll implement your suggested code. Oh, and plate_id can be empty, it would run as it used to before the fix to this issue

I don't know how to explicitly do complex input validation checks in WDL

Great!  Do we need to worry about the fact that cellprofiler_pipeline_task requires illum_image_dir and uses it in the code?

Or will it just work fine with that default and not actually care that there's no images in that directory?

I was thinking about adding an AssertionError with an informative message to the user.
Something along the lines:

Add correct the set of inputs: either provide the load_data csv file or the necessary config yaml to generate it.

It should work fine

That kind of thing would be cool!  But how would you implement the AssertionError?  I don't know how to do it in WDL.

The AssertionError or custom error message that I mentioned it is not implemented.
WDL will error if load_data_csv and config_yaml are not passed as inputs. However the error will inform the user that config_yaml file is missing, but won't mention that instead could just add load_data.csv.
Another option is to make load_data_csv required and skip the task generate_load_data_csv.
Motivation explained here
This workflow works (aka run CP without errors) but always scatter.

scattered run here
non-scattered try here, but it was scattered

Additionally, there is a very large amount of optional inputs, some could be removed, such as: input_directory (keep just input_directory_gsurl).

@sjfleming I can not request you for review, since you started this PR. 👋
Thoughts about skipping the task generate_load_data_csv?
also... should we changed output_directory be a required input??

About the test runs, for the one that was not supposed to scatter, I am pretty confused actually.  The workflow input splitby_metadata shows "" here (under the "inputs" tab), but I still see the input
splitby_metadata             "Metadata_Well"

here under the "inputs" tab.
I think this means that my Boolean variable do_scatter is not working for some reason.  Oh I think it's actually the if statement... I think I have to compare it to true, not just say if (do_scatter).  I will try to fix this!
But I don't really know where the value "Metadata_Well" is coming from.  At first I thought it was the default from one of the sub-tasks, but the sub-tasks are all passed the splitby_metadata variable from the main workflow.  Very strange!!

I also think there might be use cases where people may want to not copy the outputs to a specific google bucket, but just let Cromwell put them in the execution directory.  For example, if somebody uses this as part of a different pipeline, then they can take advantage of Cromwell's call caching that way.
Most people will probably want to copy the outputs to a specific google bucket directory though, like you usually do.


Can I ignore this warning message?

This method can cause UI unresponsiveness if invoked on the main thread. Instead, consider waiting for the -locationManagerDidChangeAuthorization: callback and checking authorizationStatus first.
from Native Code :
if ([CLLocationManager locationServicesEnabled]) {
if ([CLLocationManager authorizationStatus] == kCLAuthorizationStatusNotDetermined) {
[self requestDefaultLocationManagerAuthorization];
return;
} else if ([CLLocationManager authorizationStatus] == kCLAuthorizationStatusDenied) {
message = @"CLAuthorizationStatusDenied";
} else if ([CLLocationManager authorizationStatus] == kCLAuthorizationStatusRestricted) {
message = @"CLAuthorizationStatusRestricted";
} else {
// manage scanning
}
} else {
message = @"LocationServicesDisabled";
}
}

The Android Beacon Library appears to require an update.
Android Beacon Library


Fix a typo in service account name

An example provided for LogonUser contains a typo. There is no such account as LocalServer.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: diversenok sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@diversenok : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Feature Request: slow network detection

HI @chrisbolin, thanks a lot for this component.
Did you thought about implementing slow network support ? Thanks a lot
Why it's important
A user doesn't understand the behavior of an app under slow network connexion. Could be great to tell him his connexion is crap.

probably out of scope for this lil project. sorry! :/
browsers are getting better and better support for things like this tho. check out https://developer.mozilla.org/en-US/docs/Web/API/Network_Information_API


GEODE-8667: Duplicate online Oplog compaction after offline Oplog compaction

When Oplog.totalCount == 0, no Oplog compaction is needed.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I agree with Darrel.  Maybe the problem this test is finding is that the compaction is leaving behind an empty oplog (perhaps it generates an empty oplog to write to when it starts or something)?
If that's the case though - it's not much of a bug, especially since it gets cleaned up on startup the next time.
If I remember what you were showing me earlier, I thought the compaction on startup after the offline compact was taking a long time. I wouldn't expect that to be the case if all it's doing is removing empty oplogs?

add unit test coverage of needsCompaction to OplogTest.
It seems like the only change you made was to say we don't need to compact if an Oplog has a totalCount == 0. I think totalCount == 0 means that the oplog is empty. This seems like something we should compact. Do you understand why offline compaction gave us an empty oplog? I'm concerned this change might cause us not to remove empty oplogs. Or maybe we say it has no need to compact but still do a check and remove it for being empty somewhere else?

I have added a unit test in OplogTest.
totalCount == 0 does not necessarily mean the oplog is empty. You remind me of the case of an empty oplog. There is another field totalLiveCount to check. What I see in the persistent recovery immediately after an offline compaction is, the offline compacted oplog is non-empty. During the recovery, totalCount is 0. However, totalLiveCount has the actual number of live entries in the oplog. Therefore I add one more condition to check totalLiveCount.
If totalCount == 0 and totalLiveCount > 0, such as the case of recovery after offline compaction, we don't need compaction again. Are there any other cases that need compaction, even though totalCount == 0 and totalLiveCount > 0?
If totalCount == 0 and totalLiveCount <= 0, then the oplog is empty, which needs compaction. Please correct me if I am wrong.

When compacting oplogs offline, it creates a new krf and persists totalCount with 0 in Oplog constructor. Then live entries are copied from old oplogs to the new oplog. totalCount of the new oplog is updated during this process. However, the updated totalCount is not persisted. Its persisted value is still 0, although the oplog is non-empty after compaction.
During recovery, the value of totalCount is recovered from krf as 0.  totalLiveCount is incremented as the oplog is recovered. totalCount remains 0. Therefore, if totalCount == 0 and totalLiveCount > 0, no compaction is needed. Since this condition shows that offline compaction is just done before recovery.

I read your new fix and have different opinion. The root cause is the new oplog (i.e. #2) created during offline compaction wrote a krf with totalCount==0.
You fix is to still read the krf and when found it's totalCount is 0, change it to be totalLiveCount. This is just a patch fix. The real issue is: we should NOT create such a krf with totalCount==0. Actually, when offline compaction, it is not allowed to create krf.
Here is the better fix for this issue:
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java b/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
index f6daa3a1d6..0a31af9386 100755
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
@@ -582,7 +582,7 @@ public class Oplog implements CompactableOplog, Flushable {
createDrf(null);
createCrf(null);
// open krf for offline compaction

 if (getParent().isOfflineCompacting()) {

 if (getParent().isOfflineCompacting() && couldHaveKrf()) {
   krfFileCreate();
 }

} catch (Exception ex) {
@@ -3980,7 +3980,7 @@ public class Oplog implements CompactableOplog, Flushable {
} catch (IOException ignore) {
}

if (this.krf.f.exists()) {

if (this.krf.f != null && this.krf.f.exists()) {
this.krf.f.delete();
}
}
@@ -5789,7 +5789,7 @@ public class Oplog implements CompactableOplog, Flushable {
if (((rv / (double) rvHWMtmp) * 100) <= parent.getCompactionThreshold()) {
return true;
}

} else if (this.totalLiveCount.get() <= 0) {

} else {
return true;
}

I don't know who introduced "if (getParent().isOfflineCompacting()" here. To be conservative, I still keep this check. Maybe we can remove the 3 lines. But I want to be conservative for now.

I read your new fix and have different opinion. The root cause is the new oplog (i.e. #2) created during offline compaction wrote a krf with totalCount==0.

You fix is to still read the krf and when found it's totalCount is 0, change it to be totalLiveCount. This is just a patch fix. The real issue is: we should NOT create such a krf with totalCount==0. Actually, when offline compaction, it is not allowed to create krf.

Here is the better fix for this issue:

diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java b/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
index f6daa3a1d6..0a31af9386 100755
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
@@ -582,7 +582,7 @@ public class Oplog implements CompactableOplog, Flushable {
       createDrf(null);
       createCrf(null);
       // open krf for offline compaction
-      if (getParent().isOfflineCompacting()) {
+      if (getParent().isOfflineCompacting() && couldHaveKrf()) {
         krfFileCreate();
       }
     } catch (Exception ex) {
@@ -3980,7 +3980,7 @@ public class Oplog implements CompactableOplog, Flushable {
     } catch (IOException ignore) {
     }

-    if (this.krf.f.exists()) {
+    if (this.krf.f != null && this.krf.f.exists()) {
       this.krf.f.delete();
     }
   }
@@ -5789,7 +5789,7 @@ public class Oplog implements CompactableOplog, Flushable {
       if (((rv / (double) rvHWMtmp) * 100) <= parent.getCompactionThreshold()) {
         return true;
       }
-    } else if (this.totalLiveCount.get() <= 0) {
+    } else {
       return true;
     }

I don't know who introduced "if (getParent().isOfflineCompacting()" here. To be conservative, I still keep this check. Maybe we can remove the 3 lines. But I want to be conservative for now.

I don't think we should avoid creating krf during offline compaction. Your proposed fix avoid creating the krf file during offline compaction. After the compaction, the original non-compacted krf is also deleted. Without a krf, there is a significant impact on the performance of persistent recovery.

@dschneider-pivotal So far, I still consider the current fix is the best option we can have. We need a convenient and reliable way to tell that the Oplog is offline compacted. The persisted 0 value of totalCount in krf serves the purpose. And during persistence recovery, if totalCount is 0, then it is updated with the value of totalLiveCount, which is the most accurate value of the number of live entries in the Oplog.
I have been thinking about whether we should use the local variable krfEntryCount, instead of totalLiveCount. At the end of readKrf(), the value of totalLiveCount and krfEntryCount are the same. Because at the beginning of readKrf(), totalLiveCount and krfEntryCount are both 0. And in the while loop inside readKrf(), both variables are incremented together:
totalLiveCount is incremented here: https://github.com/apache/geode/blob/develop/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java#L1765
krfEntryCount is incremented here: https://github.com/apache/geode/blob/develop/geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java#L1768
I'd prefer using totalLiveCount instead of krfEntryCount which is a local variable.


Support customize pre color

The values set did appear in the style sheet. But seems not to take effect on any element. Is it on purpose?

Yes, the pre color will be overridden by the custom syntax highlight theme. If you disable the highlight_code, the pre color will work. Maybe we need a better solution to fix this.


As Juliana, I would like to make sure that feedback is ROUTED to the correct stakeholder so that if an angry user writes pointed feedback, it does not get lost as process feedback

[ ] We should add a question to the survey that says what division they were in (maybe?)
[ ] We should get a list of shareholders of what feedback should go to which particular section
[ ] We should add the business logic so that the e-mail goes to that particular place
[ ] We should verify that we mention in the survey that specific feedback will go to a particular shareholder

@mathias-gibson - can you handle this?

yeah, already have a list of departments and accompanying emails for routing. for the logic we should only route if they add content to the open text box questions

seems like this should be split out into issues for you and issues for me

@mathias-gibson: Yeah definitely. Can you link me the file where the list of routing is available?
Also assuming that doing the routing through typeform is okay, for now?

what does routing through typeform look like? what about text feedback? I
think we may just want to route role, dept and open text fields, and only
route if open text fields have text in them, (excluding fields that only
have "no"  or "na," which will be common in the text submission to move
along in the progression)
i'll send the contacts in slack
On Mon, Sep 14, 2015 at 12:38 PM, Ernie Hsiung<EMAIL_ADDRESS>wrote:

@mathias-gibson https://github.com/mathias-gibson: Yeah definitely. Can
you link me the file where the list of routing is available?
Also assuming that doing the routing through typeform is okay, for now?
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/mdc-feedback/issues/259#issuecomment-140185454
.

Ooof.
So I just took a look at the typeform routing options. They're not as easy
on Typeform as I thought - you either have an option to e-mail a certain
set of employees once a user has sent a form, no matter what section
they've chosen. There may be some hacking we can do involving e-mails
inside hidden fields but that doesn't seem to be so scalable.
I think the best thing to do from a high level would be to do the routing
logic on the python side and feed it into the app after all. Not as cut and
dry as doing it as Typeform and we'll have to spin off a new issue talking
about how to build this out and stuff
On Mon, Sep 14, 2015 at 4:11 PM, Mathias Gibson<EMAIL_ADDRESS>wrote:

what does routing through typeform look like? what about text feedback? I
think we may just want to route role, dept and open text fields, and only
route if open text fields have text in them, (excluding fields that only
have "no" or "na," which will be common in the text submission to move
along in the progression)
i'll send the contacts in slack
On Mon, Sep 14, 2015 at 12:38 PM, Ernie Hsiung<EMAIL_ADDRESS>wrote:

@mathias-gibson https://github.com/mathias-gibson: Yeah definitely.
Can
you link me the file where the list of routing is available?
Also assuming that doing the routing through typeform is okay, for now?
—
Reply to this email directly or view it on GitHub
<
https://github.com/codeforamerica/mdc-feedback/issues/259#issuecomment-140185454
.

—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/mdc-feedback/issues/259#issuecomment-140192668
.


read error on acknowledge file

Hi, I get the following error on opening a few acknowledge files that we acquired (here is a debug trace in ipython).
....
OSError: [Errno 22] Invalid argument
In [2]: %debug
> .../lib/python3.6/site-packages/bioread/reader.py(263)__read_journal_v4()
    261                     self.encoding, errors='ignore').strip('\0')
    262         # Either way, we should seek to this point.
--> 263         self.acq_file.seek(self.journal_length_header.data_end)
ipdb> self.journal_length_header.data_end
-318777935
ipdb> self.journal_length_header.offset
11703
ipdb> self.journal_length_header.journal_len
-318789638

Does that indicate that the files are corrupted?

Might be truncated... do you get any errors when opening in Acknowledge, or does it open fine?

Probably the file is okay (as long as it really is an acqknowledge file) but Something is Amiss in reading the journal. Since the journal comes before the data in the file, we really do need to figure out what's going on there. There's no spec from Biopac on these, so the code is all hacks and guesses.
Can you post the file?

Thanks for your suggestions. I went back to the acquisition computer where Acqknowledge is installed, and on opening the files where it occured, it says it's corrupted and offers to fix it. It might be worth setting an error message suggesting that fix.
I cannot share the file, unfortunately.
I will try to investigate the differences between the corrupted and fixed files to see what the fix did.

Thanks for the update; I've never heard of acqknowledge detecting and fixing corruption before. Neat!
Yeah, suggesting people try to read the file in acqknowledge is a good idea; at least it deserves documentation on the web page.
The other thing we could try code-wise is, if we've read the main header successfully and know how many channels there are, we could scan forward to try and find the channel data type headers if the journal or foreign data headers are "obviously bad" (we already do this for the foreign data header)


Get the people widget on a separate page

I've been trying to get the people widget on a separate independent page. Similar to this page here: https://www.tslab.org/people/
I don't seem to find a way to do it. Any hints, please?

It sounds like you wish to create another Widget Page - see https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page


Fix python >= 3.3 test_loader.py mock import

Python version: 3.6.5
Freshly cloned repo inside a virtualenv:
$> PYTHONPATH=.:$PYTHONPATH python tests/unit/test_loader.py
Traceback (most recent call last):
  File "tests/unit/test_loader.py", line 19, in <module>
    mock = unittest.mock
AttributeError: module 'unittest' has no attribute 'mock'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "tests/unit/test_loader.py", line 23, in <module>
    import mock
ModuleNotFoundError: No module named 'mock'

mock = unittest.mock doesn't work because mock is not exposed in the unittest package (at least not before doing import unittest.mock). This PR does from unittest import mock instead.
I think the reason it doesn't fail on travis is because they pre-install mock: https://docs.travis-ci.com/user/reference/trusty/#Pre-installed-pip-packages and so despite the mock = unittest.mock not working, the import mock still does the job.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   95.32%   95.32%
=======================================
  Files           5        5
  Lines         428      428
=======================================
  Hits          408      408
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4cdbd...273d1ea. Read the comment docs.


Let "--all" override "--onlyChanged"

--all must override any --onlyChanged flag.

Can you add a test for this behavior?

Codecov Report

Merging #5486 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5486      +/-   ##
==========================================
+ Coverage   61.64%   61.66%   +0.01%
==========================================
  Files         213      213
  Lines        7069     7069
  Branches        3        3
==========================================
+ Hits         4358     4359       +1
+ Misses       2710     2709       -1
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-config/src/normalize.js
93.25% <66.66%> (+1.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dcdd3...e302a28. Read the comment docs.

Done! @thymikee again the tar failure in CircleCI. I think it's caused when you push a branch while the builds are running, and CircleCI abruptly stops the process, but they cache an image :(

@mjesun seems like something we should report to circle


EPF refactor

Hi,
My EPF project is focused on the node-crawler.
I wanted to add a feature to check if a node is properly port-forwarded, basically what is described in #20, and I noticed the project needed some updates to work with recent versions of Go, and libraries.
I would say everything is basically changed, so I don't think reviewing each file would make sense. I tried to keep things as similar as possible, while still updating the libraries, and arranging the project similar to other Go projects.
What I've changed:

Swapped sqlite library to a pure go version, so CGO isn't needed anymore
Upgraded to the latest Ethereum library version, which also meant upgrading to urfave/cli/v2
Moved to a single Go package, and single executable, with crawler and api sub-commands

Plans still to come in no particular order:

[ ] Update the dockerfile and deployment instructions
[ ] Some more refactoring. I feel the package layout is a bit strange. I think it can be made easier to understand.
[ ] #20
[ ] Fix some of the reported issues.
[ ] Maybe: Bundle the frontend into the executable to make deployment easier (But compilation will require an extra step)

Please tell me if there's anything you would like me to look at or if you would like to discuss my project, my username is the same on Discord.

Awesome thank you! Since we are gonna refactor it, are there any plans to refactor it so tests would be easier to create? For contributions this big, I would have recommended multiple pull requests, would be easier to follow.

Since we are gonna refactor it, are there any plans to refactor it so tests would be easier to create?

Yeah, this is something I was sort of thinking about. There are some places where I can see tests will be useful.

For contributions this big, I would have recommended multiple pull requests, would be easier to follow.

Yeah I know. Just getting it to work with newer Go versions and updated libraries needed quite a few changes. The urfave/cli v1 to v2 was the most significant in this regard, as well as updating some things which are new/different in the geth code which is used.
It's still working now the way it did before I made any changes, at least as far as I can tell, there shouldn't be any functionality difference. Moving functionality into different packages really confused git quite a bit. It was mainly file renaming and function/type renaming. I think it should be pretty easy to see where a file was moved, but I am very freshly familiar with the code, so that would probably be a lot more difficult for someone who hasn't looked at it for some time. From what I remember doing, there should only be significant changes to how the API is run. Everything else should be pretty much how it was with a few minor tweaks. Maybe looking at each commit individually would shed some light on the process I took? They are not particularly well named. I didn't expect to make so many changes this quickly. We can even have a call on Discord if you think that would make it easier for me to explain it.
Would you like to review this before I shuffle things around in the packages some more?

Hey @angaz i was focusing more on the Javascript stuff, and @MariusVanDerWijden quickly made the crawler. I reviewed it looks good. If you have a plan how you want to refactor it, please share some diagrams so we can have a better understanding where things should be. What I care about the most is testability, and improving or rewriting the parser because that is the most fragile part.

i was focusing more on the Javascript stuff, and @MariusVanDerWijden quickly made the crawler.

Ok, good to know. I have not looked at the front end part yet. I probably should have tried to run the whole system first. I guess there will also be some library upgrades there which would be nice to have. So it's something I can look at. It's not my area of expertise though. I've got mostly database/backend/ops knowledge. I've dabbled a bit with JavaScript/Typescript/React, so I should be able to find my way around the upgrading of the libraries.
Yeah the parser is also where I can see there are some problems. Possibly there needs to be a lot more logic there. So I will have a look at that as part of the "fixing issues" phase of the project.
I don't have a concrete plan for how I want to restructure things. I think the configuration of the crawler could be made more straight forward to follow or change the naming a bit. I think that's where I had some bad feelings and felt like I wanted to change something.
I think the shared sqlite database file is still OK. I'm not sure what are the deployment requirements within the EF setup. Would it be better if there was an external database? Say Postgres? Or is it still OK to have it as sqlite files shared between containers? I saw #5 I'm not sure exactly what is needed for this. Is there an example from another project that I could look at? With the single executable, there will be one fewer container to create, it will just have different starting commands/environment variables.

I have a few more commits to refactor the docker compose and I updated the frontend libraries to work with node 18, and updated the README accordingly. Those commits will come soon. I don't believe it will be too much work to review them. They are pretty simple and I think it will be good to have the docker setup and docs updated in the same PR.

https://github.com/ethereum/node-crawler/pull/40/files/ab1a81df5ab929b643f201bfb6f4600473826856..56b4df2c60c498d09f0072d4af8eb86a9ba18cd6
Should be the new commits I spoke about. I have no more planned changes. The new things will come in future PRs. I think this is good to go.
With the updated docker compose, I believe it should be easier to deploy. I see the current https://pscrawl1.ethdevops.io/ seems to be broken. I tested the new docker compose on my machine and it seems like it's working as expected.

I will rebase when we are happy with everything. I see there is a merge conflict with one of the Dockerfiles.

I will rebase when we are happy with everything. I see there is a merge conflict with one of the Dockerfiles.

Let me know when you are ready to merge and I will merge

Great. I will be home in an hour or two and I'll resolve the merge conflict :rocket:

@mohamedmansour it's all ready to go :rocket:

Awesome, great work!

Hey @angaz sorry I didn't have time to review your PR, I took a quick peek now and it looks good. If you have some time it would be really nice to hop on a quick a call to discuss your changes and if you have some more ideas to improve the crawler


Add support for ticket codes 'class 5'

The class 5 NTP and ticket codes are supported by the authority service (authd).
Add support for creating and managing NTPs class 5.
We could have a global setting for class 4 vs class 5.  We don't need to ask the user every time an NTP instance is created as generally tenants only use one or the other.  Class 5 is the most common and scalable so it should be the default for new objects.

maybe we should call the new ones "class 6" tickets, adding a "class" argument to the API.
the impl can potentially have a similar structure as the VotingService, which looks a lot like it:

ticketing events have start and end, like a VotingEvent
individual tickets like are like Votes
events are per-tenant
...


How can the icons be changed?

Before you submit a new bug report, please check that

[X] I have read frequently asked questions and limitations

Write your question here
I’m trying to use this, so that I can have relevant icons.
Even just staying with mdi icons, how can the colour be set?

I do not think you can set the mdi icons color (only binary sensors do that). Unless you use a custom card.


added auth modal for unauth users

Description
Added auth modal for unath users
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report

Merging #420 (c8b1634) into master (2db3c6f) will decrease coverage by 1.56%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   33.38%   31.81%   -1.57%
==========================================
  Files         122      123       +1
  Lines        2702     2722      +20
  Branches      789      790       +1
==========================================
- Hits          902      866      -36
- Misses       1641     1696      +55
- Partials      159      160       +1

Impacted Files
Coverage Δ

src/App.js
0.00% <0.00%> (ø)

src/components/AuthModal.js
0.00% <0.00%> (ø)

src/components/BuildModalReview.js
0.00% <0.00%> (-100.00%)
:arrow_down:

src/Routes/Devices/UpdateDeviceModal.js
0.00% <0.00%> (-68.58%)
:arrow_down:

src/components/Modal.js
14.28% <0.00%> (-42.86%)
:arrow_down:

src/hooks/useApi.js
68.18% <0.00%> (-4.55%)
:arrow_down:

src/Routes/Repositories/RepositoryTable.js
73.33% <0.00%> (-3.59%)
:arrow_down:

src/Routes/GroupsDetail/GroupsDetail.js
42.10% <0.00%> (-1.49%)
:arrow_down:

src/Routes/Groups/GroupTable.js
27.08% <0.00%> (-0.58%)
:arrow_down:

src/components/general-table/GeneralTable.js
67.11% <0.00%> (-0.22%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db3c6f...c8b1634. Read the comment docs.


[WIP] T4 Lysozyme input files

@mkgilson I've uploaded in this branch the receptors in PDB format and ligands in mol2 format.
The receptors are clean (no crystal waters) and they went through MCCE to obtain the most relevant protonation states at the experimental pH. The ligands have been generated from the SMILES and docked into the receptors with OpenEye. The protonation state is the one Epik predicted. Each folder has a JSON file describing each ligand with associated reference and experimental conditions/measurements.
I haven't had the chance to put together a README and to organize the prmtop/inpcrd yet, but as far as I understood, the PDB files are the priority at this stage. I'll try to get the rest in by the end of the week.

I plan to upload the solvated systems soon. A few questions:

Do we want only the prmtop/inpcrd files here or the PDB files as well?
The set I have prepared includes 14 L99A binders that are not listed in the paper, which brings the total number of L99A binders to 21. Is there a particular reason why the current set has a relatively low number of ligands? I guess what I'm asking is: should I not upload these extra binders or should we update the table in the paper? Also, I haven't prepared the non-binders for now.
Uploading these files for all 29 systems will add ~370MB (~460MB if I add the PDB files as well) to the existing ~387MB. We should probably start coming up with a long-term plan for file storage as the repo is getting closer to the 1GB limit.

Thanks, @andrrizzi .

Do we want only the prmtop/inpcrd files here or the PDB files as well?

I think it'd be good to also have the PDBs since these are very helpful for some codes and also could assist if it is necessary to prepare other formats.

The set I have prepared includes 14 L99A binders that are not listed in the paper, which brings the total number of L99A binders to 21. Is there a particular reason why the current set has a relatively low number of ligands? I guess what I'm asking is: should I not upload these extra binders or should we update the table in the paper? Also, I haven't prepared the non-binders for now.

The short answer is: Please deposit them, and update the supplemental info to also list details of these. (See also work done on cyclodextrins and some of the other sets). We can update the paper to note this is available.
The main reason the current set has a low number of ligands is that we were, in this work, primarily focused on issues roughly like those addressed in the SAMPLing challenge -- assessing methods to ensure whether and how well they converge to known gold standard answers (when available) or at least how well they deal with the issues which are known to be important -- and less on accuracy relative to experiment. If you're interested in method efficiency separated from force field issues, and thus not in comparing to experiment, the number of ligands is less of a factor (as in the case of the SAMPLing challenge).
Eventually I need to update the paper to make this point and the terminology slightly more clear on this as John was confused on this too, but I haven't had time.

Oh, and also @andrrizzi

Uploading these files for all 29 systems will add ~370MB (~460MB if I add the PDB files as well) to the existing ~387MB. We should probably start coming up with a long-term plan for file storage as the repo is getting closer to the 1GB limit.

Good point. Any suggestions? One approach would be for me to make a separate data package in eScholarship which would get its own DOI and we could link to that from here. That's not under automatic version control (though I can upload versioned .tar.gz files), but it's free and the UC libraries maintain it so it's safe for the long haul. There are probably also other options but presumably they would be paid.

Sounds good, thanks!

Any suggestions?

Nothing specific comes to mind right now. I agree that we want to have versioned input files. If we want to keep things free, an alternative to manual versioning could be to split this into multiple github repos (e.g. benchmarksets/t4lysozyme, benchmarksets/hostguest), although I'm not sure which one of the two would be less cumbersome. Otherwise, I think adding 50GB to storage and bandwidth on GitHub costs $5/month (see here).

@andrrizzi - we are good to go now, I've added the 50 GB so you should be able to add those files.

Still missing the README/paper update, and the layout may need a little polishing but the files are here. I'll try to wrap up this PR next week.

@andrrizzi - any updates?

Sorry, I got caught up in other work. I'll try to find some time next week to finish this up.


exotica: 6.1.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository exotica to 6.1.0-1:

upstream repository: https://github.com/ipab-slmc/exotica.git
release repository: https://github.com/ipab-slmc/exotica-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.2
previous version for package: 6.0.2-1

exotica
* [exotica] Adjust version for documentation
* [exotica] Update installation.rst instructions
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_aico_solver
* Clang support and bug fixes (#731 <https://github.com/ipab-slmc/exotica/issues/731>)
* Contributors: Wolfgang Merkt

exotica_cartpole_dynamics_solver

No changes

exotica_collision_scene_fcl_latest

No changes

exotica_core
* Fix segmentation fault on exiting Python (#732 <https://github.com/ipab-slmc/exotica/issues/732>)
* Clang support and bug fixes (#731 <https://github.com/ipab-slmc/exotica/issues/731>)
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_core_task_maps
* Add DistanceToLine2D task map (#733 <https://github.com/ipab-slmc/exotica/issues/733>)
* Clang support and bug fixes (#731 <https://github.com/ipab-slmc/exotica/issues/731>)
* Upgrade formatting to clang-format-6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_ddp_solver
* Clang support and bug fixes (#731 <https://github.com/ipab-slmc/exotica/issues/731>)
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_double_integrator_dynamics_solver

No changes

exotica_dynamics_solvers

No changes

exotica_examples
* Fix TargetMarker
* Fix segmentation fault on exiting Python (#732 <https://github.com/ipab-slmc/exotica/issues/732>)
* Remove explicit specification of Integrator
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_ik_solver

No changes

exotica_ilqg_solver
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_ilqr_solver

No changes

exotica_levenberg_marquardt_solver
* [exotica_levenberg_marquardt_solver] Use better default for Convergence
* Contributors: Wolfgang Merkt

exotica_ompl_control_solver

No changes

exotica_ompl_solver
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_pendulum_dynamics_solver

No changes

exotica_pinocchio_dynamics_solver

No changes

exotica_python
* Fix segmentation fault on exiting Python (#732 <https://github.com/ipab-slmc/exotica/issues/732>)
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

exotica_quadrotor_dynamics_solver

No changes

exotica_scipy_solver

No changes

exotica_time_indexed_rrt_connect_solver
* Clang support and bug fixes (#731 <https://github.com/ipab-slmc/exotica/issues/731>)
* Upgrade clang format from v3.9 to v6.0 (#730 <https://github.com/ipab-slmc/exotica/issues/730>)
* Contributors: Wolfgang Merkt

Holding for Melodic sync.


Could not install the update

After downloading can't install the update TIA

Yes, Same here...the app gets downloaded and the status is 11 which indicates it's Downloaded. Can anyone help steps to install the update? Will a restart of the app work?

Hey @gowtham171  are you calling the inAppUpdates.installUpdate();. When working with flexible updates, you need to install by calling the aforementioned function. It is however not required for Immediate updates.


JOSS paper: add Fahima

Fixes #95

Coverage remained the same at 87.925% when pulling 3627db031ae7035b973f3e69ba05457c0ba4dcee on 95-fahima into 8428f28c05c66caae383bbda40c2cf67a361ad57 on master.


typeText containing a space scrolls the page on Safari

What is your Scenario?
I would like to type text with multiple words (separated by space) inside the input.
What is the Current behavior?
The test which is being run on Safari scrolls the page viewport.
Scrolling is obviously caused by space in the string which is passed inside the typeText method.
Test behaves correctly on other browsers.
What is the Expected behavior?
It should not scroll the page viewport.
What is your public website URL? (or attach your complete example)
<input id="input">

text to check scroll

What is your TestCafe test code?
test('Should not scroll', async () => {
    await t
        .click(Selector('#input'))
        .typeText(Selector('#input'), 'random text');
});

Your complete configuration file
No response
Your complete test report
No response
Screenshots
No response
Steps to Reproduce

run test on Safari where the text with multiple words separated by space is being typed inside the input
observe browser behavior while space is being typed inside the input
check that page viewport is being scrolled

TestCafe version
2.0.1-alpha.1
Node.js version
v14.16.1
Command-line arguments
testcafe remote **.e2e-spec.ts --speed 0.1 --hostname [ip-address] -e
Browser name(s) and version(s)
Safari 15.6.1
Platform(s) and version(s)
macOS Monterey Version 12.5.1
Other
No response

Hi @PierreRott
Thank you for the shared information. I've reproduced the issue.


build: expose internal pool

It is available as browserlessPool.pool
Closes #104

^ @hoang-innomizetech take a look!

Coverage remained the same at 42.466% when pulling b4f33c64d9f5c16765da560affe6636bd6f55f0c on pool into fd4ea553566c87182d4c8afeaa86ebea029cb2ce on master.

Coverage remained the same at 42.466% when pulling b4f33c64d9f5c16765da560affe6636bd6f55f0c on pool into fd4ea553566c87182d4c8afeaa86ebea029cb2ce on master.

@@hoang-innomizetech thoughts?


Ability to run crystal and ruby servers with Docker

Just simple setup to build containers and run them.
How to test it:

Install Docker https://docs.docker.com/engine/installation/
run docker-compose up [server_name]
try it with curl http://localhost:3000/

Cleanup:

Kill currently running server with ctrl+c
Remove all containers  and images with docker-compose down

PS: this is highly naive and if it should be meant seriously it needs a lot of improvement.

@tbrand Can I somehow run benchmarker from terminal just against some URL to test it?

Seems great!
Could you wait for the review?
Currently I don't have any environment to execute docker and docker-compose. sorry ...

Sure. It was just idea and I throw it to some code fast :)

I've started building docker environment!

Please do not close while I'm trying this :pray:

Thanks again!!:tada:
I've override the PR to make this working on my server! https://github.com/tbrand/which_is_the_fastest/pull/39
Your commit is in it!!


The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.

Bug description:
Android Studio build failed

Building the project via Android Studio prompts that the kotlin version does not meet the project requirements.
To Reproduce:

Expected behavior:

Screenshots/Videos:

Environment:

OS:Android
OS version:13
react-native version:0.71.8
react-native-webview version:13.3.1
Android:
minSdk 26
targetSdk 33

How did you solve? I'm having the same issue

same issue +1


When object is defined on single line editor fails

In HOCON editor, object can not be on single line (i.e. both opening and closing bracket on same line). For example attempt to write this:
x = {y: 1, z: "1"}
results in error:  no viable alternative at input '}'

+1
I experience the same.


Add a workflow ymal file.

Create a CI to automatically run unit tests on the Github server every time when

someone creates a PR to be merged to the main, or
someone tries to push a commit to the main.

This is just one of the many features that CI can provides. In the future, we can add more "events" to trigger the checks and also add more checks that serve our needs.
More about continuous integration.

@matthewclegg Sorry I didn't realize the PR automatically requested you as the reviewer. I am still trying to make it work. Will let you know once I finish it. Thanks!

Hey Craig @kungfucraig, we would like to have your review for this PR. After this PR is merged, we want to set up some branch rules. None of us in planning have the access to do so. Would you be able to help us?


Tests

More tests for the 4 LSTs pipeline

@Elisa-Visentin is this supposed to be merged after #170 ? or can it be merged before?

Here I am implementing some tests while we are upgrading the pipeline. This will be merged with/after the next pipeline PR (i.e., upgrades of the RFs, Dl2, DL3...). PR #170 is about semi-automatic scripts, so not dependent on tests.

ok, I see. thanks!


get_drive_count() not working on Windows export

Godot version:
3.2.3 RC3
OS/device including version:
Windows 10 64 bit
Issue description:
dir.get_drive_count() returns 0 on exported game (release and debug)
dir.get_drive_count() returns 3 on same project when run from editor <--CORRECT RESULT
Steps to reproduce:
var dir = Directory.new()
print(dir.get_drive_count())
Minimal reproduction project:

Was it working in 3.2.2?

Just tested on 3.2.2, same result, works when run from editor but not in exported project @Xrayez

I have same problem. But there is a way to get correct drive count.
Directory class can recognize opend drive self.
So after Directory open all drive (A: ~ Z:) and then Directory return correct drive count
var dir = Directory.new()
var drives = ["A:", "B:", "C:", "D:", "E:", "F:", "G:", "H:", "I:", "J:", "K:", "L:", "M:", "N:", "O:", "P:", "Q:", "R:", "S:", "T:", "U:", "V:", "W:", "X:", "Y:", "Z:"]
for dr in drives:
var _result = dir.open(dr)

This happens for me too on Linux.
Godot version:
3.5.stable.official
OS/device including version:
Linux Mint 19.2


Push a new tag and release

Thank you for your continued support of this package over the years!
This package will show up with a vulnerability because the latest tag v0.6.0 has a dependency on an unpatched version of goxmldsig <v1.1.0.
For anyone curious, there was a patch upstream https://github.com/russellhaering/goxmldsig/issues/48 against https://github.com/advisories/GHSA-q547-gmf8-8jr7
To solve this we pinned the latest commit explicitly in our go.mod
github.com/russellhaering/gosaml2 v0.6.1-0.20210916051624-757d23f1bc28

But it'll be nice to avoid special casing this and get a version bump, say v.0.6.1 or v0.7.0. What do you think @russellhaering ?

Can you do this please, @russellhaering?

This should now be resolved with the v0.7.0 release. Closing.


FundPsbt includes a non-empty scriptSig in the unsigned transaction value

Background
A PSBT produced by the WalletRpc method FundRpc erroneously includes a scriptSig value
According to BIP 174's specification of the unsigned transaction:

The scriptSigs and witnesses for each input must be empty. The transaction must be in the old serialization format (without witnesses).

Your environment

LND commit f8e3b41d1004aadc3dc506b2b13aaac4baec3b5a

Steps to reproduce

Create a single nested SegWit UTXO on an LND node
Call FundPsbt with no inputs to allow LND to select the funding inputs itself
Attempt to decode the resulting PSBT funded_psbt

Expected Behavior

The funding step should not include any signature data
The PSBT should be a valid BIP 174 PSBT

Actual Behavior
A scriptSig in the transaction encoded in the PSBT_GLOBAL_UNSIGNED_TX field is present. This causes decoding of the PSBT to fail, for example a call to decodepsbt in Bitcoin Core will fail.

Thanks for testing! Fix is on its way.


[AMBARI-23171] Ambari logo is missing.

What changes were proposed in this pull request?
original image version is now packed with pre compressed one.
Jetty 9 cannot serve static content if only compressed version exists anymore.
Original resource is required.
How was this patch tested?
Manual check

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1072/
Test FAILed.
Test FAILured.


use requests.Session for make HTTP persistent connection

Hi @darlev91, thanks for your contribution!
This change makes total sense to me, do you mind also adding the automated tests so the PR is complete?
Thanks again!

Looks good to me.
Thanks!


Create code documentation

Preferably using with Material for MkDocs in combination with mkdocstrings.
It's probably best to build the page using GitHub Actions and host the page using GitHub Pages.

Fixed with 65de0d074cf0694d3368fa8e3e8f0f7b28122206

Fixed with 65de0d074cf0694d3368fa8e3e8f0f7b28122206


Stop asking questions in slack applications

Currently, users have to provide their full names and experiences to join the Chainer slack teams. I think it is better to stop requiring these so that users can join them more casually.

Thank you for the suggestion. We have removed all the questions except for the e-mail address (which is used to send an invitation).

Great! Thank you for your quick action.


remove default js in "--watch-extensions" option; closes #3275

Description of the Change
Changes the behaviour of  the --watch-extensions option. No longer includes js by default, meaning that the specified list becomes an exclusive and not an additional set of extensions.
Benefits
Closes #3275.
Possible Drawbacks
Mocha will not behave as expected for people who rely on js files always being watched.
Applicable issues
#3275

Coverage increased (+0.05%) to 90.086% when pulling 159f0f773d816939913bd8947b27d11cd33b51cb on TheDancingCode:issue/3275 into 19b764dcb19a27ed410067373411d840042d815d on mochajs:master.

Originally I called this a "bug", but it's not.  You can see from the original help text that it's acting in a way consistent with the documentation.
That makes this a purely breaking change, so it necessitates a major release.  This PR LGTM, but I want to discuss a branching/release plan with @mochajs/core before this is merged.


Switch to mainline ponyc 0.19.2

Switch to mainline ponyc 0.19.2
Closes #1605

This is now waiting on final review and @JONBRWN performance regression testing.

@dipinhora I've addressed all your comments so far.

@jtfmumm As part of removing dagon you also need to remove the various .ini files in the performance apps directories. Additionally, there are references to dagon in various documentation files and code (giles sender/receiver) that need to be cleaned up for a full removal of dagon.

@dipinhora You bring up good points re: Dagon.  Since I don't have time to do all of that at the moment, I'm bringing Dagon back and switching it off at the Makefile level.

@dipinhora Also, I think the Makefiles are where you want them to be, though there might still be unnecessary changes on the CPP app in testing/performance.

@jtfmumm Thanks for making all the Makefile related changes. It's mostly to ease the merge/rebase between these changes and the changes from #1601.

@dipinhora No problem.  Anything else you think needs updating?

@jtfmumm Nothing else that I can tell (note: I did not review the actual pony source changes).

This can be merged if @JONBRWN determines there was no perf regression after all.  Otherwise it will have to wait until week after next.

That's not really the case @jtfmumm. At this point, there's something impacting machida. @JONBRWN, @dipinhora and @aturley can collectively have at it while we are gone.

@JONBRWN @SeanTAllen @dipinhora This is already broken into logical commits. If you do merge this down today, please don't squash these commits further.

@seantallen Ok, that's good to hear.

closed in favor of #1615


Trino connections can be made but workers are all failing

I can create a connection to the Trino server in the usual ways, but even the simplest of queries, such as listing schemas in the catalogs, leads to an error that takes 5 minutes to report:
---------------------------------------------------------------------------
TrinoQueryError                           Traceback (most recent call last)
<ipython-input-4-b0a8f62698e7> in <module>
     14 # Show available schemas to ensure trino connection is set correctly
     15 cur.execute('show schemas')
---> 16 cur.fetchall()

/opt/app-root/lib64/python3.8/site-packages/trino/dbapi.py in fetchall(self)
    455
    456     def fetchall(self) -> List[List[Any]]:
--> 457         return list(self.genall())
    458
    459     def cancel(self):

/opt/app-root/lib64/python3.8/site-packages/trino/client.py in __iter__(self)
    441         # Subsequent fetches from GET requests until next_uri is empty.
    442         while not self._query.finished:
--> 443             rows = self._query.fetch()
    444             for row in rows:
    445                 self._rownumber += 1

/opt/app-root/lib64/python3.8/site-packages/trino/client.py in fetch(self)
    518         """Continue fetching data for the current query_id"""
    519         response = self._request.get(self._request.next_uri)
--> 520         status = self._request.process(response)
    521         if status.columns:
    522             self._columns = status.columns

/opt/app-root/lib64/python3.8/site-packages/trino/client.py in process(self, http_response)
    388         logger.debug("HTTP %s: %s", http_response.status_code, response)
    389         if "error" in response:
--> 390             raise self._process_error(response["error"], response.get("id"))
    391
    392         if constants.HEADER_CLEAR_SESSION in http_response.headers:

TrinoQueryError: TrinoQueryError(type=INTERNAL_ERROR, name=TOO_MANY_REQUESTS_FAILED, message="Encountered too many errors talking to a worker node. The node may have crashed or be under too much load. This is probably a transient issue, so please retry your query in a few minutes. (getting task status http://<IP_ADDRESS>:8080/v1/task/20211212_153856_00120_givsz.1.0 - 110 failures, failure duration 300.41s, total failed request time 250.08s)", query_id=20211212_153856_00120_givsz)

Can we automatically test the liveness of the Trino worker pool and restart things deeply enough, in an automated fashion, if they should become wedged in this way again?  Or do we need sophisticated analysis of the failure in cases like this so that things don't cascade further?

I have not had this problem since we adjusted Trino's memory configuration and other parameters.  Closing (with fingers crossed).


Unable to make connection Growatt MIN 3000TL-X

Currently I am not be able to communicate to the Growatt inverter via Modbus.
I have a Waveshare RS485 To Eth(B) connected to the Growatt MIN 3000TL-X to the Sys-com connector.
The network connection to the Waveshare is working because the "Link" LED turns to blue which means the connection is opened successfully, so far so good. The "ACT" LED is blinking when it tries to communicate with the interverter via Modbus, but the following error messages appear:
"Device didn't respond".
"Device address is likely wrong".
I have checked the address of the inverter (I assume this address is for the COM address and Modbus address?) and it was set to 58. However I have changed it to 1, but still no luck.
Full details:
Communication layer: tcp
IP: <internal ip-address of Waveshare>
Port: 502
Modbus device address: 1
Modbus Framer: Modbus TCP

I am not sure if you are familiar with the Waveshare module, but the following is set:
Baudrate: 9600
Data bits: 8
Parity: None
Stop bits: 1
Flow control: none
Modbus gateway type: Simple Modbus TCP to RTU

Do I miss something?

Elfin EW11 settings with work

Unfortunately I'm not familiar waveshare module. Did you find a solution?

Thanks for your reply. But no, unfortunately not. But I have to admit I did not spend much time recently to this issue because of other projects I am working on.

Elfin EW11 settings with work

Thanks, that looks interesting! To make sure: this setup with the Elfin EW11 is actually working with this plugin in HA?

Elfin EW11 settings with work

Thanks, that looks interesting! To make sure: this setup with the Elfin EW11 is actually working with this plugin in HA?

Waveshare have same settings just different UI.

Elfin EW11 settings with work

Thanks, that looks interesting! To make sure: this setup with the Elfin EW11 is actually working with this plugin in HA?

Waveshare have same settings just different UI.

It is worth a try. However I cannot recognise all the settings of the Elfin compared with Waveshare, but I will take a closer look.

It is worth a try. However I cannot recognise all the settings of the Elfin compared with Waveshare, but I will take a closer look.

Post what you have to compare
basic is to have modbus to inverter set to 9600/8/n

It is worth a try. However I cannot recognise all the settings of the Elfin compared with Waveshare, but I will take a closer look.

Post what you have to compare basic is to have modbus to inverter set to 9600/8/n

Currently these are the settings as in VirCom:
Standard settings:

Advanced settings:

After comparing your settings and the settings in WaveShare I noticed the Flow Control was set to Half duplex in your configuration. In WaveShare it was set to None. So I have changed this to CTS\RTS (= half duplex as I can remember) and now I am be able to make a connection with this plug-in in Home Assistant!
Details will follow to tomorrow, because it is now dark at the moment. Status in HA is now Offline.

Currently these are the settings as in VirCom:

What are other option of "Transfer Protocol" is there RTU
why not use web interface of device

Currently these are the settings as in VirCom:

What are other option of "Transfer Protocol" is there RTU why not use web interface of device

Well, because of a stupid reason: I cannot remember the password I have set in the webinterface. I will have to reset the device back to factory settings. But I wanted to try out it first with the new setting, therefor I used the VirCom.
However, both interfaces can be used.
In VirCom I only the option Simple Modbus TCP to RTU, regarding to RTU.
But what I can remember of the webui, it is not that extensive like yours. Let me get back to you as soon a I have the webui running back again.

Currently these are the settings as in VirCom:

What are other option of "Transfer Protocol" is there RTU why not use web interface of device

Well, because of a stupid reason: I cannot remember the password I have set in the webinterface. I will have to reset the device back to factory settings. But I wanted to try out it first with the new setting, therefor I used the VirCom. However, both interfaces can be used. In VirCom I only the option Simple Modbus TCP to RTU, regarding to RTU.
But what I can remember of the webui, it is not that extensive like yours. Let me get back to you as soon a I have the webui running back again.

Herewith the settings via the WebUI. It does not much differ from VirCom and there a not a lot of options compared with your interface of WaveShare.


Meta: Automatically hide resolved comments on minor fixes issues

Related to https://github.com/refined-github/refined-github/issues/5222#issuecomment-996627450
Test URLs

https://togithub.com/refined-github/refined-github/issues/4008
https://togithub.com/refined-github/refined-github/issues/5222

Screenshot

Maybe spare a label instead of fixed URLs?

Or maybe just match the title on this repo 👍


transport/http: fix metrics race condition

This PR fixes a race condition reported by #548,
by introducing a simple wrapper for time.Time.
While by default aws-sdk-go-v2 uses NopMeterProvider, the transport/http internals are still instrumenting the http requests (the withMetrics func).
Maybe there is a room for improvement, to not call httptrace.WithClientTrace when the meter is nop,
however this is out of scope for this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fyi @lucix-aws @Madrigal

gentle ping


Remember selected color scheme

Checklist

[x] I have read the contributing guidelines.
[x] There is no similar request on existing issues (including closed ones).
[x] I have read the project progress and know the current progress of the project.
[x] I was in the master branch of the latest code.

Is your feature request related to a problem? Please describe
The color scheme switch works fine, but when opening the page in a new tab or window (tested in Firefox and Chromium) the scheme does not seem to be remembered.
Describe the solution you'd like
It would be great if the setting would be stored as a cookie or local storage setting.
Describe alternatives you've considered
Additional context

https://github.com/cotes2020/jekyll-theme-chirpy/blob/940b2810e95065e30600ae8d5e4612e7183da60e/_includes/mode-toggle.html#L61-L86
Hi Duke,
if you change the sessionStorage to localStorage in the code above, the browser will remember the selected theme.


can not resolve method 'avatarImage' in 'AvatarGenerator'

companion objects are not accessible from java project  so AvatarGenerator.avatarImage and AvatarConstants are not accessible. does this library only work in kotlin projects??

This has been addressed on


Fix doxygen ci differently (again [again [again]])

Fixes #55.

[X] Fix the doxygen links to use doxygen.nl since stack.nl/~dimitri/doxygen gives 403 again.  This appears to be the official site since doxygen.org redirects to doxygen.nl?
[X] Use binary installers from sourceforge on Windows.  Not linux because they didn't compile anything statically aka they're definitely not ummmm...distributable...
[X] Bonus: fix an apparent regression with codecov on AppVeyor.

And I'm sooo proud of me too, I was going to force-push stuff away on master but decided to revert instead.  This makes me a good person since there are forks now right? Hehehehehe............


SPRT-105 Fixed the links in footer

I fixed the links of social media in the footer.

@GonzaEnrique27 resolve the merge conflicts.


BPTC_FLOAT (BC6H) compression is broken

BTPC_FLOAT compression produces a segfault. This bug has been introduced after version v0.8.1, which produces correct (although not very high quality) results.

This bug has been fixed as of v0.9.2.


[PRETEST 1, 2, 3]: Added an overall proposal to implement cache support using bare repo for managing third-party dependencies

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

ref #384
2. What is the scope of this PR (e.g. component or file name):
proposal/add_support_for_cache.md
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

Here I have proposed an overall implementation of kpm managing the third-party dependencies making the use of bare repository, serving as a cache and facilitating the downloading of package dependencies from the bare repo itself. The implementation talks about handling the file systems based on the bare repo directory . But it is not that much solid for now I need reviews form the kcl maintainers to move forward with the exact changes to achieve the discussed approach.
cc: @Peefy @zong-zhe
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.812%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
3085

Relevant Lines:
7749

💛  - Coveralls

Hi @zong-zhe I have developed a final documentation for enhancing the KPM's dependencies management. This is with reference to the rust package manager Cargo, the way it handles the dependencies management through bare repo. I have also submitted a research work for different languages and the unified system supported by them.
I need review and valuable feedbacks from the maintainers and members of kcl community on the design doc so that I can quickly start working on the pretests based on the discussed approach.
Thanks
cc: @Peefy @liangyuanpeng

Hi @Manoramsharma 😄
I just merged a PR and left a TODO for you, you can try to complete this TODO:
https://github.com/kcl-lang/kpm/blob/655022e03e5cdd48fb434688a0d74700e23da0e7/pkg/downloader/downloader.go#L124
I extended DownloadOption with two new fields that support whether caching is enabled and the cache path.
https://github.com/kcl-lang/kpm/blob/655022e03e5cdd48fb434688a0d74700e23da0e7/pkg/downloader/downloader.go#L26
https://github.com/kcl-lang/kpm/blob/655022e03e5cdd48fb434688a0d74700e23da0e7/pkg/downloader/downloader.go#L29
The work you need to do next now consists of two main parts:

For GitDownloader, if EnableCache is True, you will use CachePath as the path to the bare repository, and then clone the bare repository from the CachePath to the LocalPath directory.

For OciDownloader,  if EnableCache is True, you will use CachePath as the path to OCI KCL package tar, and untar the file from CachePath to LocalPath.


user_groups: Add server level setting disallow anonymous groups for settings

This PR adds a server level setting which controls whether the setting can
be set to anonymous user groups. We only allow it in the tests for now because
the UI can only handle named user groups.
Discussion - https://chat.zulip.org/#narrow/stream/378-api-design/topic/managing.20resolve.20topic.20permissions.20independently/near/1809310

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I am not sure about the documentation changes. The current changes look like -

Also, not sure about whether we need a feature level entry in changelog.

Made some tweaks noted above and marked to merge once CI passes, thanks @sahil839!


De Blurring Webframe

Related Issues or bug

Web Frame for Face De-Blurring DL Model

Fixes: #1741
Proposed Changes

Created a website which has to take image inputs and convert the image into cartoonification using present models in the FACE-X model.
Improve the present notebook code and readme files of the Face Deblurring.
Also added the information of dataset linked with the Face Deblurring with proper details.

Screenshots

@akshitagupta15june Ma'am please review this pull request.

@akshitagupta15june ma'am please review this pull request and requested to merge it under WOC'24


Don't Compute Genesis Validator Weights on the Fly

Currently, genesis validator weights are computed on the fly as required by fast-sync.  This could be computed just once as an optimization.

@Fraser999 -> @xcthulhu - do you see this as a part of Q3 efforts

Superseded by #1666 1666


Request to fix broken link

There is an invalid link redirecting to non existing page.
Repro steps:
Go to https://docs.microsoft.com/en-us/microsoftteams/security-compliance-overview
Click the link "Compliance Framework for Industry Standards and Regulations"
Expected results:
Link redirect to an existing page or pdf file
Actual results:
404 - file or directory not found error occurred on https://download.microsoft.com/download/1/4/3/1434ABAB-B8E9-412D-8C3A-187B5FCB7A2F/Compliance Framework document.pdf

The following URL shows the pdf file published in March 2017.
https://download.microsoft.com/download/B/2/7/B27B3EF3-8849-4C18-8BA4-5AD755728620/Compliance Framework_customer guidance.pdf

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@sasaito Please review requested changes.

@MicrosoftHeidi could you review this one please?

@LolaJacobsen  @MicrosoftHeidi  See https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/2603

@LolaJacobsen @MicrosoftHeidi PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


make defult value

@safaaamro @shaima96 set up together and fix the conflict in brands and brand components


parser: Avoid module recursion in parser.parse{Value,Filter}

Fixes #163.

@bkutil

The test failure is not relevant to this change, filed #181, re-running.

The commit message could be a bit more verbose (what was the problem and why this fixes it), but +1 :)

Not in a verbose mood today :-)
More seriously, this fixes a problem of marginal importance and impact, so I figured an issue reference is good enough.


Fix TestRunExposeService

No longer emits "you will also need to explicitly open a firewall"
after #10974.
Fixes #11105

cc @wojtek-t, if you're still around.

(And obviously cc @brendandburns, and @thockin as on-call if you see this first.)

Awesome - thanks for the fix!
LGTM

Let's see if Shippable is actually clean now..

@k8s-bot test this

Shippable super green, woo. :+1:

@zmerlynn - should we merge it now to fix shippable?

I would, yeah. If there's a better way to fix this, Brendan can handle it
later. The PR noise is really bad now.
On Jul 13, 2015 7:30 AM, "Wojciech Tyczynski"<EMAIL_ADDRESS>wrote:

@zmerlynn https://github.com/zmerlynn - should we merge it now to fix
shippable?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/11147#issuecomment-120949409
.


add sphinx extension to support markups: cligroup and clicommand

The cligroup and clicommand will be used as follow:
.. cligroup:: az account
:summary: summary
:description: description
.. clicommand:: az account create
:summary: summary
:description: description
.. cliarg:: --name -n
 :summary: summary
 :description: description
 :values: values from

.. cliexample:: the example to create account
  az account create -n erich

Have to recreate a new PR because can't update this PR


[Feature] Mark Deleted Git Repositories

Display deleted repositories in greyed-out text.
After re-scanning repositories, automatically remove the deleted ones.

Done


Must amplify pull retrieve function modification you made in aws console ?

Which Category is your question related to?
Function
Amplify CLI Version
4.29.3
What AWS Services are you utilizing?

AppSynch

RDS Aurora (instance)

Lambda

Usage question
I'm using amplify cli as I use Git to pull/push modifications from aws cloud. When I'm trying to update my function code directly in aws console I'm not able to retrieve it locally. Here are the steps I'm doing :

Modification of a Function (Lambda Function in my amplify project) in aws console using online IDE.
Going locally in the folder where my amplify project is sync using my terminal. Trying to do amplify pull
Nothing is updated. All operation are "No Change"
When i'm trying to force it with amplify env pull dev --restore. I got the same result, nothing is updated.

My local project is correctly linked to the cloud. When I'm doing local modification I can amplify push them correctly.
Am I  doing something wrong ? Did amplify cli be used this way ? (Like git)
Thanks.

@Sam31000 The changes to the Lambda function will not be reflected back, but you can export the function and copy the changes manually

Thank you @ammarkarachi for your answer.
It seems to be complicated to retrieve locally all modification done on aws online IDE this way.
I will looking  for an automatic way to do it.


gn报错

make[3]: Entering directory '/home/runner/work/test/test/openwrt/package/lean/small/gn'
MAKEFLAGS="" /home/runner/work/test/test/openwrt/staging_dir/host/bin/ninja  -j1 -C /home/runner/work/test/test/openwrt/build_dir/hostpkg/gn-2023-11-17-7367b0df/out
ninja: Entering directory `/home/runner/work/test/test/openwrt/build_dir/hostpkg/gn-2023-11-17-7367b0df/out'
[1/287] CXX src/base/command_line.o
FAILED: src/base/command_line.o
clang++ -MMD -MF src/base/command_line.o.d -I../src -I. -DNDEBUG -O3 -fdata-sections -ffunction-sections -Werror -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -pthread -pipe -fno-exceptions -fno-rtti -fdiagnostics-color -Wall -Wextra -Wno-unused-parameter -Wextra-semi -Wundef -std=c++17 -Wrange-loop-analysis -Wextra-semi-stmt -c ../src/base/command_line.cc -o src/base/command_line.o
/bin/sh: 1: clang++: not found
ninja: build stopped: subcommand failed.
make[3]: *** [Makefile:58: /home/runner/work/test/test/openwrt/build_dir/hostpkg/gn-2023-11-17-7367b0df/.built] Error 1
make[3]: Leaving directory '/home/runner/work/test/test/openwrt/package/lean/small/gn'
time: package/lean/small/gn/host-compile#0.08#0.04#0.12
ERROR: package/lean/small/gn [host] failed to build.
make[2]: *** [package/Makefile:114: package/lean/small/gn/host/compile] Error 1
make[2]: Leaving directory '/home/runner/work/test/test/openwrt'
make[1]: *** [package/Makefile:110: /home/runner/work/test/test/openwrt/staging_dir/target-x86_64_musl/stamp/.package_compile] Error 2
make[1]: Leaving directory '/home/runner/work/test/test/openwrt'
make: *** [/home/runner/work/test/test/openwrt/include/toplevel.mk:231: world] Error 2
##[error]Process completed with exit code 2.

sudo apt install clang

修复了


Update cloud-native-security.md

/sig security
Please write a description for this pull request. Part of the role of a reviewer is to check that the effect of merging the PR matches the description.

Hey @Sagar2366 are you able to address comments from @sftim and @divya-mohan0209 ? Please add description to the PR as asked by sftim.


Make unsorted bin attack great again!

Corrupting the bk of a freed unsorted bin attack can be exploited to gain shell or any other security impact.
The technique was found when auditing GlibC 2.32 source code, but it's working against GlibC 2.34 too.

@MaherAzzouzi you mentioned that libc leak is required. That is not true. You can have three unsorted bin chunks head->A->B->C->head. Now all both fwd and bk pointers in B. You can use overflow to overwrite B's fwd and bk pointers to preserve its fwd pointer and change the bk pointer to a fake chunk X. And then you overwrite B's fwd pointer to X. Now you let X's fwd pointer to be B and X's bk pointer to be C. Now you have head->A->B->X->C->head. You successfully inserted X between B and C without knowing libc address (head)!

Yeah you're totally right I can insert one in the middle and only use heap leak, but sometimes a one freed chunk is all you have (the case of the challenge I was doing), and many more.
For suggestions 1 and 2 you're right the name can make an ambiguity with the old attack and I will change it, for the third suggestion it need to be + 0x8, else you will have the following error : malloc(): unsorted double linked list corrupted
I will try to add more output to the PoC when I have time.
Thanks for your time, and thanks for reviewing this technique.


Enhancement: Add ResponseSpec(examples=...)

Summary
Support adding custom examples for the response body.
The inbound parameters can be defined via Parameter, but the same does not work for the response body. ResponseSpec only has generate_examples, but it should support also examples for custom ones.
Basic Example
No response
Drawbacks and Impact
No response
Unresolved questions
No response

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Related, any thoughts about supporting Parameter (-like) construct for response annotation?
@get()
def endpoint() -> Annotated[ResponseModel, ResponseSpec(examples=[...])]: ...

Related, any thoughts about supporting Parameter (-like) construct for response annotation?
@get()
def endpoint() -> Annotated[ResponseModel, ResponseSpec(examples=[...])]: ...

Related, any thoughts about supporting Parameter (-like) construct for response annotation?
@get()
def endpoint() -> Annotated[ResponseModel, ResponseSpec(examples=[...])]: ...

This feels reasonable to me.


python-pip not found

https://github.com/atosatto/ansible-dockerswarm/blob/579f802ec3b97a6a57f1362fdea04006d13b4ee2/vars/Debian.yml#L4
while running this role on Ubuntu 20, it raises an error python-pip package not found, instead it should be python3-pip
Whenever I install this role, I have manually to update this package name before running my playbook

Same happens with GCP image: debian-cloud/debian-12


How can I remove GLOB_BRACE code?

I have the same problem as #289 but on different file, here is a screenshot of what I get (directory lister v3.0.0-rc.4)

I'm using linuxserver/letsencrypt as my webserver which is based on alpine and I'm aware this error is caused by alpine. Because I'm using directory lister only on my personal vps and no one else has access to it I don't mind changing it a little as long as it can list all of my files/directories. My question is, is there any way to remove parts of code where it needs GLOBE_BRACE and have direcory lister still working? I'm not a php programer please guide me with details.

You can remove GLOB_BRACE from the hiddenFiles() method in app/src/Factories/FinderFactory.php. Keep in mind this will likely break the hidden file functionality.

FYI, I've refactored the hidden file code to improve functionality and eliminate the reliance on GLOB_BRACE. This change will be included in the next release.

Thanks for letting me know, waiting for next release.


performance: avoid use getStringValue() in getTimeFormatter()

Proposed changes
Original getTimeFormatter() will convert long to string, and then parse string to int.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


[OSSC] Make Apache AGE compatible with pgcli

use some advacnce tools to reslove this

Hello @nasirbloch323, thanks for your tip. Which tools do you recommend for this?

how does one join this open projects?


libdom.d.ts changes of 4.4.x break WebRTC standard

lib Update (revert changes) Request
I tried to follow all those topics about the libdom.d.ts changes introduced in 4.4.x but i did miss a topic that encapsulates that the changes totally break the WebRTC standard.
I made a fork / Branch: https://github.com/JanFellner/TypeScript/tree/bugfix/CC-2424-revert-webrtc-related-changes-from-9d443b76

to revert all RTC related changes to strip down and just show the WebRTC changes that have been made.
to have the old lib.dom.d.old.ts which shows the embedded file before the changes made by #44842 / 9d443b76aac0832d7f3c890441264d39307fe31a in that branch

The changes are so massive that it takes some time to nail down what really is element of the current standard and what has been removed replaced improved.
Documentation Link
https://www.w3.org/TR/webrtc/

@MartinJohns can you give me a wider picture?
There is now (new?) a generator for dom.d.ts which will replace libdom.d.ts in the typescript repo in the future?
I also saw the large bug ticket https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1029 and it seems it´s not only on my side causing some confusion...
The changes that affect us were introduced in 4.4.x with a merge by @DanielRosenwasser so even if the origin of the sources is a second library i need to mention that here (at least to have all other affected notified properly)
Whats your proposal. Just open a ticket in the second library and link them together?
Just add the issue to https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1029
The problem is that the change is breaking a widely used standard....
I do actually also wonder that no one was complaining about this standard breaking in total so far, maybe i am missing something.

The DOM lib generator creates these .d.ts files directly from the spec pages and then uses tools like the db powering caniuse to determine if the API is used in more than one browser, and W3C systems for declaring deprecations. The 4.4 changes should be very closely aligned with the spec for WebRTC. It's likely that the API changes which affected you are either:

The name of an interface being renamed in the spec (and thus in the .d.ts)
There being only one browser enginer implementing the API and thus not passing the bar for inclusion
The W3C declared something as unimplemented (which I guess won't be the case here)

If you think we've missed something we're happy to take issues on the specifics in the linked repo 👍🏻


Change a example docker compose  value

add the "restart: unless-stopped" value in the example docker compose.
Just a Reminder for @Floppy

can i take this?

Sure thing! The repo at https://github.com/manyfold3d/website is probably the best place for it, along with docker-compose.example.yml in this repo if you want.

New update here: https://github.com/manyfold3d/website/pull/63


load_file breaks after import of activate_gui

Steps to reproduce
from pyiron_atomistics import Project
from pyiron_gui import activate_gui
pr = Project('test')
pr["image_file.tif"]
>> UnicodeDecodeError as cause of OSError

While
from pyiron_atomistics import Project
pr = Project('test')
pr["image_file.tif"]
>> Image output
from pyiron_gui import activate_gui
pr["image_file.tif"]

works like a charm. Any ideas what could be causing this?

@pmrv Could you maybe have a quick look what I miss here? Thanks!

Will have a look next week, when I'm back.

I assumed the PR #9 to fail since I from pyiron_gui import activate_gui in the test. However, this does not seem to break the test in this case!?

Ok I cannot reproduce it at the master branch any more. Only from the PR #7... Nonetheless, I do not understand how this import can affect the Project creation which is exclusively using pyiron_atomistics functionality? (And, indeed, I did not touch activate_gui)

To wrap up our findings in the meeting today:
The issue is caused by different Image.registered_extensions() depending on the order of the statements.
from pyiron_atomistics import Project
from pyiron_gui import ProjectBrowser
pr = Project('test')
pr["image_file.tif"]

results in  Image.registered_extensions() = {'.png': 'PNG', '.apng': 'PNG'}, while
from pyiron_atomistics import Project
pr = Project('test')
pr["image_file.tif"]
from pyiron_gui import ProjectBrowser

results in a long dict including .tif.