TypeScript 4.7 Iteration Plan

This document outlines our focused tasks for TypeScript 4.7. It minimally indicates intent to investigate tasks or contribute to an implementation. Nothing is set in stone, but we will strive to complete these tasks in a reasonable timeframe.

Date
Event

TBD
TypeScript 4.6 Release

April 1st
Create 4.7 Beta (4.7.0) Build for Testing

April 5th
TypeScript 4.7 Beta Release

May 6th
Create 4.7 RC (4.7.1) Build for Testing

May 10th
TypeScript 4.7 RC Release

May 20th
Create 4.7 Final (4.7.2) Build for Testing

May 24th
TypeScript 4.7 Final Release 🚀

Language and Compiler Features

Node ESM UX Issues, and Move Node ESM Mode from Nightly
Instantiation Expressions
Import Strategies for import type and /// <reference />
Investigate Contextually Typed And Compatible Operator
lib.d.ts Updates

Editor Productivity

Object Member Snippet Completions
Investigate Go to JavaScript Implementation
Prototype Virtual File System Support in TSServer
Prototype Automatic Type Acquisition in Web Contexts
Easy Run/Debug for Loose TypeScript Files
Investigate TS Server Plugins on the Web

Performance

Investigate Outstanding Performance Issues
Find All References Refactoring and Optimizations
Supporting Additional Trace Points
Profiling/Tracing Mode Improvements
Investigate Tooling for JIT Deoptimizations

Infrastructure

Migrate to Modules
Determine Shipping Strategy for Modules
Fuzzer Improvements and Addressing Crashes
Improving User Suite Reports
Expand Perf Suite

Website

Investigate Playground as a VS Code Extension

Hello, I am not sure if this is the right place for this but we got the below issue with version 4.7.0-dev.20220320 (this is automatically selected by VSCode) like the below image. We did some testing and noticed that this issue does not show up for version below 4.7.0, in our case 4.6.2 and 4.1.5 work fine. If this is not the right place for this, please let me know. Thanks
Context:

We provide type safe fetch (its type is quite nested) which allows us to safely type the response based on the url of the request we are trying to make for a good dev experience
We are getting the below error when we use our fetch in a Promise.all. My assumption is that Promise.all
is trying to infer the type from our fetch type which is quite nested and caused this error on 4.7.0-dev.20220320

const [responseOne, responseTwo] = await Promise.all([ // it complains about the below error here
    fetch("https://something/v1", { req, timeout: 5000 }),
    fetch(
      "https://something/v2",
      { req, timeout: 5000 }
    )
  ])

@vietanhtran16  yes, the issue is not for bug report, please file a new issue. :)

@vietanhtran16 yes, the issue is not for bug report, please file a new issue. :)

Cool I will file a new one

@typescript-bot create release-4.7

Looks like it's probably failing because of the Node ESM stuff which we were hoping to unflag for the beta at the least. There's also some basic bug fixes I'd like us to pull in before beta, so maybe we'll go out on 4/6 instead.

@typescript-bot create release-4.7

The feature roadmap now reflects what we've been able to get done for 4.7.

I still want to suggest typescript to drop Node 12 in new Node ESM. Lets start from Node 14. Node 14 has TLA support.

Node 12 will end LTS this month.

Hi! I've seen the 4.7-beta announcement, but it's not listed under releases and there's also no v4.7-beta tag. Are you planning on adding this?

Sorry, beta tag should be out https://github.com/microsoft/TypeScript/releases/tag/v4.7-beta

@DanielRosenwasser is there a specific tag or semantics for filing issues against this beta that will help streamline the process?

Not sure if this is a TS or yarn issue and I didn't want to cross-post, but just for reference, 4.7 seems to break when used with yarn pnp mode. If it's a TS problem I can also open an issue here.

Just open up issues and fill out the template, maybe signal specifically whether you've found a regression or a bug in a new feature.

We've removed resolution-mode from import type and export type, and moved it into nightly-only, so I cannot summon the bot. The bump to RC is at https://github.com/microsoft/TypeScript/pull/49007.

4.8 Iteration Plan is available at https://github.com/microsoft/TypeScript/issues/49074

@typescript-bot bump release-4.7

Just wanted to point out one mistake in the TypeScript 4.7 RC release notes that should probably be fixed for the full release and that's that the line:
Certain global-like values like require() and process cannot be used directly.

Is actually incorrect for process, unlike require which a per-cjs-module injected thing, the process object is actually just a property of global so is usable in ESM as a global without problems.
An alternative object for the sentence could the module per-cjs-module object i.e.:
Certain global-like values like require() and module cannot be used directly.

Thank you for that correction!

TypeScript 4.7 is now out!

Happy to test, but linked Typescript SDK has a 404 and nuget.org has a 4.7.2-rc (hu?).
But npm is available :-)

I installed the typescript 4.7.2 but I encountered an error
Module build failed (from ./node_modules/ts-loader/index.js):
Error: Debug Failure. False expression: Non-string value passed to ts.resolveTypeReferenceDirective, likely by a wrapping package working with an outdated resolveTypeReferenceDirectives signature. This is probably not a problem in TS itself.
I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Here are some of the packages I used
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

@typescript-bot bump release-4.7

@typescript-bot bump release-4.7


chore: Add default variant to the iOS archs

This fixes https://github.com/flutter/flutter/issues/136951
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Hixie or @stuartmorgan I think this qualifies for a test-exempt:

@Rohithgilla12 thank you for the contribution! You are missing tests for this change though, per the bots comment

@eliasyishak This actually doesn't require tests.
I have pinged for a test exempt, waiting on it 😄

This actually doesn't require tests

Could we not test that the MissingDefineException exception is not being thrown when missing the kIosArchs key from the environment variables?

@eliasyishak Sorry missed the message
Will check that

Your test is failing, here is the snippet of the error
01:00 +1601 ~1 -1: test/general.shard/build_system/targets/ios_test.dart: Default kIosArchs value [E]
  Expected: 'arm64'
    Actual: <null>
     Which: not an <Instance of 'String'>

  package:matcher                                             expect
  test/general.shard/build_system/targets/ios_test.dart 76:5  main.<fn>
  dart:async                                                  runZoned
  test/src/common.dart 214:14                                 testWithoutContext.<fn>
  test/src/common.dart 183:18                                 test.<fn>

I think a better test will be to override the enviornment.defines map and running the workflow you are editing

@eliasyishak Thanks for the help, all tests are now passing.

@vashworth if this is the right change to make, this LGTM, but can you confirm we want this to fallback to arm64?

@vashworth if this is the right change to make, this LGTM, but can you confirm we want this to fallback to arm64?

So I don't know that having a fallback is actually the correct thing here. If the ARCHs is empty/blank, that's for a reason and generally means that the project's settings do not support any arch (see https://github.com/flutter/flutter/issues/136931#issuecomment-1817190065 for an example of when this can happen).
Hypothetically, if we do default it to arm64, and arm64 is a not a valid arch, it'll most likely fail somewhere else in the build.
I think a better solution would probably be to give better error messaging, we could even parse the plugins and configs to try and determine the conflict that would cause ARCHs to be empty.

I think a better solution would probably be to give better error messaging, we could even parse the plugins and configs to try and determine the conflict that would cause ARCHs to be empty.

thanks for the context, and yeah, this approach sounds the most prudent.

@christopherfujino @vashworth
Can you please help me on how to do this, any high level overview helps!

@christopherfujino @vashworth Can you please help me on how to do this, any high level overview helps!

Thanks for contributing this PR. Unfortunately, offering technical guidance to contributors is outside the scope of our code review process (and simply would not scale to the number of PRs that we receive).

From tools PR triage, we are closing this as stale. Feel free to reopen if you wish to address the feedback and get this landed.


refactor!: rework Container API to support managing state without contextvars

Rework Container API so that it returns a Container a copy of the container, allowing state to be managed without contextvars. A wrapper around this that uses contextvars is still available for convenience.
Rename di.types -> di.api
Establish Container API via protocol in di.api.container.

Codecov Report

Merging #39 (6b83c51) into main (37260fa) will increase coverage by 0.02%.
The diff coverage is 98.97%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   98.22%   98.25%   +0.02%
==========================================
  Files          60       61       +1
  Lines        1914     2004      +90
  Branches      216      150      -66
==========================================
+ Hits         1880     1969      +89
- Misses         22       24       +2
+ Partials       12       11       -1

Impacted Files
Coverage Δ

di/_utils/types.py
100.00% <ø> (ø)

di/api/providers.py
100.00% <ø> (ø)

di/api/scopes.py
100.00% <ø> (ø)

di/api/solved.py
94.44% <83.33%> (ø)

di/container.py
99.09% <98.58%> (-0.91%)
:arrow_down:

di/_utils/execution_planning.py
100.00% <100.00%> (ø)

di/_utils/inspect.py
100.00% <100.00%> (ø)

di/_utils/nullcontext.py
100.00% <100.00%> (ø)

di/_utils/scope_map.py
95.23% <100.00%> (-4.77%)
:arrow_down:

di/_utils/scope_validation.py
100.00% <100.00%> (ø)

... and 23 more


Refactor React imports to named import

Overview
Refactored the import statements with named imports
Note

import and export do not work expectedly in .d.ts file

@kotaaaa Thank you for your prompt review!


change deployment logs to be json structured, add user data support, add tests for user data, deactivated cloudstack tests

resolves https://github.com/kthcloud/go-deploy/issues/406
resolves https://github.com/kthcloud/go-deploy/issues/407


Hoverboard and Rasberry pi Integration

Dear Alex Makarov and all,
I'm trying to communicate between my Hoberboard and Rasberry pi board using the Hoverboard-Driver as the ROS Package and the bipropellant-hoverboard-firmware that I flashed on the Mainboard-Hoverboard. I have tried changing the port configuration from / dev / ttyTHS1 to / dev / ttyS0 in the config.h in this ROS package. Besides that I also changed:
"#ifndef CONTROL_TYPE
#define CONTROL_TYPE HOVERBOARD_WITH_SOFTWARE_SERIAL_B2_C9
#endif "
Becomes :
#ifndef CONTROL_TYPE
#define CONTROL_TYPE USART2_CONTROLLED
#endif
Because I use the left sensor board for communication with the Rasberry Pi board.
However serial communication still failed. Is there still a configuration that is still lacking or incorrect?
Here is the Package that I use:

https://github.com/alex-makarov/hoverboard-driver
https://github.com/bipropellant/bipropellant-hoverboard-firmware

Is the hbprotocol on the bipropellant-hoverboard-firmware not the same version as the Hoverboard-driver ROS package?
If so, can you include the bipropellant-hoverboard-firmware you use for the Hoverboard-driver ROS package? I see the bipropellant-hoverboard-firmware has changed. Or the ROS package can still be used even though the latest version of the bipropellant-hoverboard-firmware?
 For your attention I would like to thank.
Best Begards,
Alaek

Did you get this resolved @alaeknuman ?
I am getting the same fault on a Nvida AG Xavier, thought they had the same HW setup as the Nano and NX ?
Using the right usart on the hoverboard, so i have not changed anything in the firmware
Any idea @alex-makarov ?
Regards
Spawn32

Solved it on my AGX Xavier:
needs to be     #define PORT "/dev/ttyTHS0" in "hoverboard-driver/include/hoverboard_driver/config.h"
Then you must disable the serial console:
$ systemctl stop nvgetty
$ systemctl disable nvgetty
$ udevadm trigger
And set the correct permissions for the serial port:
$ sudo chmod o+rw /dev/ttyTHS0


Improve label and def of GO:0098676 modulation of host virulence by virus

Looking at the Viral Zone description of this term, https://viralzone.expasy.org/3965, this term describes a interaction between 3 organisms. We'd like to clarify the definition.

definition needs to be improved: Current def: Any process by which a virus modulates the ability of its host to infect and/or damage an organism for which it is a host. Typically this involves a phage modulating the virulence of a bacterium. Mechanisms include the expression of factors that modulate a bacterial adhesion to a host cell, spread through host tissues, production of exotoxins or provide protection against host immune defenses.
Proposed:  A process by which a virus improves the virulence of its host for that host's respective host. Common in but not limited to bacteriophages; also occurs in phage-bearing bacteria infecting plants or animals for example. Mechanisms include the expression of factors that modulate a bacterial adhesion to a host cell, spread through host tissues, production of exotoxins or provide protection against host immune defenses.
PMID:23981100 -> enhancing host defense response to a third organism
PMID:10913072 -> phenotype, remove from def xref
PMID:11553559 -> OK keep
Add PMID:8658163

@pmasson55 can you please check that the proposed changes are OK from your perspective?

Hi Pascale
The new definition looks good.  Do you need more example or are you good to go?
Let me know if you require more info.
Patrick.

No it's fine, I just wanted to make sure this looked OK to you.


Add header for high-level and low-level PLGraphics access.

Make API more oriented towards OpenGL; remove layers for DirectX and software rendering.

Taken a different route with this


security: enable software CFI

until we have https://github.com/google/android-riscv64/issues/15 (which hopefully we'll get in the Android/riscv64 ABI), we should at least enable software-only CFI.
(we had to disable this in the build system's global settings, suggesting at least some llvm work is needed here.)

@appujee

CFI was disabled in: https://android-review.git.corp.google.com/c/platform/build/soong/+/2263628

Now that #22 has been fixed, is there something else blocking CFI?

i don't think so. i think we can re-enable scs for riscv64 too now we have the new compiler?

i'm testing scs first, and then i'll try the cfi.

for scs: https://android-review.googlesource.com/c/platform/build/soong/+/2660940

cfi enabled: https://android-review.googlesource.com/c/platform/build/soong/+/2595746

Reopening as CFI was disabled again in https://r.android.com/2684006.

I had some time to look into this issue, and the reason init crashes at boot when CFI is enabled is that the CFI shadow implementation in bionic assumes we have a 48-bit virtual address space, while the Linux kernel happily enables Sv57 for cuttlefish. Increasing kMaxTargetAddr allows cuttlefish to boot again:
diff --git a/libc/private/CFIShadow.h b/libc/private/CFIShadow.h
index cbdf0f706..0bc77350d 100644
--- a/libc/private/CFIShadow.h
+++ b/libc/private/CFIShadow.h
@@ -61,7 +61,9 @@ class CFIShadow {
   // Alignment of __cfi_check.
   static constexpr uintptr_t kCfiCheckAlign = 1UL << kCfiCheckGranularity;  // 4K

-#if defined (__LP64__)
+#if defined(__riscv)
+  static constexpr uintptr_t kMaxTargetAddr = (1UL << 57) - 1;
+#elif defined (__LP64__)
   static constexpr uintptr_t kMaxTargetAddr = 0xffffffffffff;
 #else
   static constexpr uintptr_t kMaxTargetAddr = 0xffffffff;

Of course, I suspect we're not going to need Sv57 any time soon in Android devices, so perhaps we should instead tell the cuttlefish kernel to use Sv48 by adding no5lvl to the kernel command line (or even no4lvl for Sv39). Any thoughts?

Of course, I suspect we're not going to need Sv57 any time soon in Android devices, so perhaps we should instead tell the cuttlefish kernel to use Sv48 by adding no5lvl to the kernel command line (or even no4lvl for Sv39). Any thoughts?

yeah, if we can make it match arm64, that's always my strong preference. ("one less thing to think about".)
we also have
#elif defined(__riscv)
    // TODO: sv48 and sv57 were both added to the kernel this year, so we
    // probably just need some kernel fixes to enable higher ASLR randomization,
    // but for now 24 is the maximum that the kernel supports.
    if (SetMmapRndBitsMin(24, 18, false)) {
        return {};
    }

in https://cs.android.com/android/platform/superproject/main/+/main:system/core/init/security.cpp;l=119?q=file:core%2Finit riscv which it would be nice to be able to fix.
(interestingly i notice that -- because this code predates GKI by a decade -- we have a weaker requirement there for arm64 than probably makes sense any more? do you know if the arm64 GKI is already configured for more? i'd happily bump arm64 to 33/33 :-) )

Of course, I suspect we're not going to need Sv57 any time soon in Android devices, so perhaps we should instead tell the cuttlefish kernel to use Sv48 by adding no5lvl to the kernel command line (or even no4lvl for Sv39). Any thoughts?

yeah, if we can make it match arm64, that's always my strong preference. ("one less thing to think about".)

Yes, that's what I thought too. I'll send a CL.

we also have
#elif defined(__riscv)
    // TODO: sv48 and sv57 were both added to the kernel this year, so we
    // probably just need some kernel fixes to enable higher ASLR randomization,
    // but for now 24 is the maximum that the kernel supports.
    if (SetMmapRndBitsMin(24, 18, false)) {
        return {};
    }

in https://cs.android.com/android/platform/superproject/main/+/main:system/core/init/security.cpp;l=119?q=file:core%2Finit riscv which it would be nice to be able to fix.

I plan to look into this next. The kernel still hardcodes the maximum to 24 for RISC-V. I believe the initial devices are going to be Sv39 though, so this is mostly relevant in the long term.

(interestingly i notice that -- because this code predates GKI by a decade -- we have a weaker requirement there for arm64 than probably makes sense any more? do you know if the arm64 GKI is already configured for more? i'd happily bump arm64 to 33/33 :-) )

GKI doesn't seem to change the default value for ARCH_MMAP_RND_BITS_MAX, which has been 33 bits with ARM64_VA_BITS=48 since v4.5:
https://elixir.bootlin.com/linux/v4.5.7/source/arch/arm64/Kconfig#L118
I'm not sure how old kernels we still need to support in the next release, but I suspect bumping the arm64 minimum to 33 should be safe now.

CFI is enabled again: https://r.android.com/q/topic:"riscv-cfi"


One-step launch instructions

Simplify the launch instructions for easy copy+paste

This oversimplifies the setup as you only use pwd and removed the use of the workplace subfolder for explicit separation.

@tobitege what does explicit separation do?
prevent people from accidentally running opendevin in their home dir?

Thanks for this! Indeed a bit easier to read/run

Need to change in docs\modules\usage\intro.mdx

@SmartManoj done. Re-review pls

Oh wait... another file needs to be updated too?

@SmartManoj it seems we missed intro.mdx change

@SmartManoj it seems we missed intro.mdx change

Isn't it done here?
https://github.com/OpenDevin/OpenDevin/pull/2189/commits/a06ebd2a0bcb83a855c6536add085de4458d228b


Fletcher checksum codec

It would be great if numcodecs could implement the Fletcher checksum algorithm in a way compatible with how hdf5 does it. In this version, the checksum is simply appended to the end of the chunk bytes. See https://github.com/fsspec/kerchunk/pull/274 for a dummy passthrough version.
There are some python implementations here:

https://github.com/njaladan/hashpy/blob/master/hashpy/fletcherNbit.py
https://gist.github.com/globby/9337839
https://gist.github.com/AJPoulter-Soton/9d0d2505af64f0719bdee59b9a4533ba

Some (fast) C implementations mentioned in https://stackoverflow.com/questions/40270450/correctness-of-fletcher32-checksum-algorithm (would cython well)

And just for completeness, here is the hdf5 version as vendored by netcdf4:
https://github.com/Unidata/netcdf-c/blob/8eb71290eb9360dcfd4955ba94759ba8d02c40a9/plugins/H5checksum.c


Wrong about test

The model I train and you provide both have this problem.

Avg. loss: 0.0000 | Mean IoU: nan
unlabeled: nan
road: nan
sidewalk: nan
building: nan
wall: nan
fence: nan
pole: nan
traffic_light: nan
traffic_sign: nan
vegetation: nan
terrain: nan
sky: nan
person: nan
rider: nan
car: nan
truck: nan
bus: nan
train: nan
motorcycle: nan
bicycle: nan

if you ran cityscapes in test mode that's expected since the test set of cityscapes is private; therefore, there are no images

So how to test on another test set after training ?

You can test on CamVid, but for other datasets you have to do your own dataloader and the test script (maybe reusing the test function and/or test class).

Ok thank you, kind regards.


specify animation sprite example?

Hello
I first used this code for animations in monogame but now moved to aseprite
https://www.monogameextended.net/docs/features/animations/animations
Can you give me a code example on how to do display the sprites in Update() function there (for key movements and associated sprite) but by using monogame.aseprite code?
I can't find how to do it
Thank you

I have a full project example, fully commented, showing this.  You can find it at https://github.com/manbeardgames/monogame-aseprite-demo

YOU ROCK!!!
I was assuming there were no examples (this is the case with many many monogame packages) so that's why I was not aware you HAVE good examples.

What .net frameworks can be used in combination with monogame-aseprite?
Because when I use .NET 6.0 I get a whole lot of errors while those 3 packages are installed

So it can't find anything here, not even monogame :-S

When I first open the solution, I get this error:

I'm no expert in all this. Can you help?

The 3.8 version should use the netstandard2.1 package automatically, so shouldn't be seeing issues with NET6.
Can you send me some info so I can try to reproduce this.

Visual Studio Version
installed MG templates? Or typicaly use the dotnet cli?
if installed templates, which version is installed?

Let me look into this and I'll reply back soon

Hi
Here is all info. I just opened the solution file and have changed it to .NET 6.0. Nothing else changed.

dotnet --list-sdks
2.1.202 [C:\Program Files\dotnet\sdk]
2.1.505 [C:\Program Files\dotnet\sdk]
2.1.602 [C:\Program Files\dotnet\sdk]
2.1.604 [C:\Program Files\dotnet\sdk]
2.1.700 [C:\Program Files\dotnet\sdk]
5.0.100 [C:\Program Files\dotnet\sdk]
6.0.201 [C:\Program Files\dotnet\sdk]

I use VS2022 community and the MG templates are not found. So I think they don't exist for VS2022 (only for VS2019).
I used the CLI to make a new desktop openGL project for MonoGame. But this works perfectly for other MonoGame code, also when using other packages like MonoGame.Extended. The MGCB editor was installed this way too.

So no templates used, because they don't exist for VS2022

When I first open the solution, I get this error (I'm using .NET 6.0):

I'm no expert in all this. Can you help?

No problems using .NET 6 here.
AsepriteDocumentImporter. This is related to MGCB - no? Have you added the .dll reference.
Like in my Content.mgcb =>
#-------------------------------- References --------------------------------#
/reference:...............nuget\packages\monogame.extended.content.pipeline\3.8.0\tools\MonoGame.Extended.Content.Pipeline.dll
/reference:...............nuget\packages\monogame.aseprite\<IP_ADDRESS>\contentFiles\netstandard2.0\MonoGame.Aseprite.ContentPipeline.dll

That must be it!
in the editor, there is a reference but it points to something that doesn't exist.
Where can I find MonoGame.Aseprite.ContentPipeline.dll ?
I don't even have a "packages" folder inside my solution while all packages are installed :-S
I thought normally all nuget packages are in such a folder, but I don't have one

The nuget folder is somewhere under your Windows folder. Do a search. The path should be the same as mine from nuget/packages onwards.
Follow this guide:
https://manbeardgames.github.io/monogame-aseprite/getting-started/monogame38installation

Thx! I added it and everything is working :)

Hi
I have a question about the example.
Why is this method needed?
private bool KeyPressed(Keys key)
{
return _curKeyState.IsKeyDown(key) && _prevKeyState.IsKeyUp(key);
}
Why you need to check the _prevKeyState to know which key is pressed?
I'm not 100% sure why that's needed.
I hope you can explain. I'm still a beginner using this library (and also aseprite)

I'm also wanting to know this.
Can you explain please

Checking the previous state here allows you to see if a key is pressed once versus being held down.
If you only check the current state each frame while a key is down, then it returns true for every frame

Also, to add, that specific method isn't something specific to the library. It's just general key/button state checking for the example project.

Original issue was resolved. For general questions, please use our discord


multiple events published for single tenant user authentication

Describe the issue:
Identity server publishes multiple events to IS analytics server when single tenant user authentication. One event is for super tenant and another is for the particular tenant.
How to reproduce:

Enable statistics="enable" and trace="enable" for IsAnalytics-Publisher-wso2event-AuthenticationData.xml
Create new tenant user and try to login to myaccount
Two event traces can be found in the wso2carbon logs

Expected behavior:
User authentication event should be published into a particular tenant only.
Environment information

Product Version: IS 5.11.0,
OS:  Linux
Database:  H2
Userstore: LDAP

Suggestions
When publishEvent method[1] is called, within the publishEvent method, it checks for publishingDomains in the authenticationData. For the publishingDomains, authenticationData object contains both super tenant and logged in user tenant. Therefore, two events are published for super tenant and particular tenant.
[1] https://github.com/wso2-extensions/identity-data-publisher-authentication/blob/5591450bb33133e552cfe642532ad5c3f2796da8/components/org.wso2.carbon.identity.data.publisher.authentication.analytics.login/src/main/java/org/wso2/carbon/identity/data/publisher/authentication/analytics/login/AnalyticsLoginDataPublishHandler.java#L148

Proposed improvement:

When a tenant user logs in from a SaaS app, the expected default behavior is to publish two events for is-analytics, where one is for the service provider existing tenant and the other one is for the user existing tenant.

If it is required to change the above default behavior, add below configuration in deployment.toml file to avoid publishing two login events. If the config is false, it will only publish a one login event for the SP existing tenant and if the config is true it will behave in the default manner.
[identity_mgt.analytics_login_data_publisher]
enableMultipleEventPublishingForSaasApps = false

NOTE: The default value of the above configuration will be true.


adding compliance logging for ssd

This replaces #159 . Since it uses mlperf_compliance 0.0.4, it should be able to merge without issues.

The logging still can't pass the compliance checker yet. I will try to fix it soon.

Now the log passes the compliance checking script.

Can you add a log to the examples? (Other than that it looks good.)


language-coverage-details: double glyph in Greek

This happened without sublocales and  WithSublocales (see #9) and Roboto-Slab
Greek 98% 107 of 109 skipped: 1 missing 2 ("̈" U+0308,"̈" U+0308)

U+0308 must not be doubled.

Fixed upstream in graphicore/specimenTools@2f18dbc4e7


support laravel/octane

this is support laravel/octane?

The compatibility of this package with Laravel Octane depends on how you structure your code. I have successfully developed an ecommerce project utilizing the capabilities of Laravel Octane in conjunction with this package. To ensure smooth operation, it is imperative to include 'Modules' in the watch configuration of your octane.php file.
In summary, yes, the package can be made compatible with Laravel Octane, as long as you configure it correctly as mentioned above.


docs: add realtime and segments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
(describe what this merge request does)
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @luorobin-a2z on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/12/2024, 10:07:18 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @luorobin-a2z on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/15/2024, 03:52:37 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @luorobin-a2z on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/15/2024, 03:52:57 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/15/2024, 15:36:49 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @luorobin-a2z on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.80
< 80

Duplicated lines density
:white_check_mark: OK
8.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/17/2024, 09:01:04 (UTC+0)


dns: lowering restrictions on dns_min_refresh_rate

Lowering API limits so we can more easily test dns refresh.

Risk Level: low
Testing: yes
Docs Changes: inline
Release Notes:

@lizan as it's an API and test only change can you do both API review and actual review?

/retest


Test runs forever without a ToList() on repository query

I am facing an odd issue with Effort.EF6 on an old .Net Framework solution.  The setup is as follows:
A .Net Framework 4.7.2 test project in C#, testing code in a .Net Framework 4.6.2 class library project in VB.Net.
The code under test does a query against a repository, iterates the result and performs work, then saves all changes once done.
My test data has a single record.
What happens is that when I run the test in isolation it passes, when I run it as part of a dozen tests it passes, but when I run it as part of the full suite of a couple of hundred tests it runs forever, doesn't complete, and I have to eventually kill the test runner after a few hours.
The really odd thing is that if I add a .ToList() on the end of my repository query then the test works fine, but that means I have to change my working code to let the test pass.
I could take the time to try and create a repo but as I have a workaround it's not going to be worth the effort, but I wondered if you knew of this issue or what the cause might be?

Hello @C-Wal ,
Are you running your test through multi-threading? If yes, perhaps the solution found by RuneAndersen could help you. See his solution: https://github.com/zzzprojects/EntityFramework-Effort/issues/152#issuecomment-1941228564
Best Regards,
Jon

Hi Jon.  I'm not and I'm using CreateTransient anyway.

Hello @C-Wal ,
In this case, we are not sure about this issue.
If you ever get the time to provide a project, let us know and we will look more deeply about this current issue.
Best Regards,
Jon


Vulkan: SSAO debug draw mode freezes after disabling SSAO

Godot version: Git 175d43738ac58afcf2d0531177eefeb260c4f296
OS/device including version: Fedora 31, GeForce GTX 1080 (NVIDIA 440.82)
Issue description:
After enabling SSAO and switching to the SSAO debug draw mode in the 3D viewport, disabling SSAO in WorldEnvironment will cause the viewport to freeze until the user switches back to another draw mode.
The draw mode should be automatically changed to "Draw Normal" once SSAO is disabled.
Also, when SSAO is disabled, it shouldn't be possible to switch to it in the first place. It should be grayed out with a tooltip instead. Right now, it just displays the normal scene when switching to the SSAO mode while SSAO is disabled.
Steps to reproduce:

Add a WorldEnvironment node and create a new Environment.
Enable Ssao in the Environment (already done in the MRP below).
Click the Perspective button in the top-left corner and change the draw mode to Display Advanced... > SSAO.

Note: On Linux, use arrow keys to access the second dropdown so it doesn't close when your mouse hovers it.

Disable Ssao in the Environment. Try to move the camera, see that nothing changes.

Minimal reproduction project: test_ssao_draw_mode_bug.zip

I think this is more of an enhancement actually. If you turn off SSAO, it stops updating, so it is as of your screen has frozen in place.
Changing viewport modes based on environment settings is an enhancement IMO.

Indeed, the debug check simply checks whether there is an SSAO buffer, which will be created when SSAO is turned on, but is not cleaned up if it is turned off.
I've left this alone even with moving everything to our render buffers implementation but I was thinking about this. It would be relatively easy to add a cleanup step if SSAO is turned off (and same with SSIL) and that would void the debug setting.

Indeed, the debug check simply checks whether there is an SSAO buffer, which will be created when SSAO is turned on, but is not cleaned up if it is turned off.
I've left this alone even with moving everything to our render buffers implementation but I was thinking about this. It would be relatively easy to add a cleanup step if SSAO is turned off (and same with SSIL) and that would void the debug setting.

I think that would be a good idea. We probably shouldn't be holding on to resources if effects are turned off.


Items not showing up on iOS

Hi,
I have followed the tutorial step by step but I'm unable to get this to work properly on iPhone X iOS 11.4.
It works fine on android, I get to see the items and click them to view page details, while on iOS I get an empty screen with "sessions" title.
I've also downloaded the code sample from GitHub and it yields the same problem.
I really hope to see this fixed soon because I could make use of it in one of my apps.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 055a0283-e820-8cc8-786c-589b0bd59a1f
Version Independent ID: 69023bfc-1bb8-e651-2bca-e980c7bab6d1
Content: Layout Compression - Xamarin
Content Source: docs/xamarin-forms/user-interface/layouts/layout-compression.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @mohammedwed
What sample are you running there? The LayoutCompression sample only has a single page, and it doesn't have a Sessions title.

Thanks for your reply.
Somehow the wrong links ended up in my thread.
Here's the correct links for the issue:
Original DataPages tutorial:
https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/datapages/get-started
Code sample:
https://github.com/xamarin/xamarin-forms-samples/tree/master/Pages/DataPagesDemo

I've closed this issue and opened a new issue #601 with correct information


[WIP][HUDI-3088] Use Spark 3.2 as default Spark version

Rebasing original PR https://github.com/apache/hudi/pull/4752/files#diff-626ac74908a8f50208219cea0d3774937c7df7cf7fca47b43df8d1acc01d71e9 onto latest master
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure

As discussed, we're going to have all changes for Hadoop/Hive/Spark 3.x upgrades in one PR: #5402.  Closing this one.


Use Transform instead of TryComp

About the PR

Why / Balance
Warnings are not Robust. RA0030 (Use non-generic variant).
Technical details

Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

None.

Thanks for the cleanup!


Wrong parameter filter for blockposition - filters only loaded blocks in /ugetblock.

Did not realize there was a separate parameter function for loaded block positions...  used that instead of unfiltered position.  ** oop - simple fix, already made.

Will update in 1.0.3, after I add optional parameter to specify world/nether/end/etc.
** much more useful - can probe the nether/end for... things.

Applied fix in 1.0.3.
Accepts optional world parameter after position.
Pulls block from any location, even unloaded/ungenerated


Install

Hi im new in the solidjs world and i found this repo here that i really like it, how i can use it?

Hi @JericoFX,
thanks for checking out this repo :)
Looks like I should finally add a installation section to the docs to make it easier.
Currently there is a PR for a CLI to help you install the components you need but for now there is only the manuall way.
There are some pre-requisites before adding the components:

pnpm install @kobalte/core
make sure you have the following function in ~/lib/utils.ts (pnpm install clsx tailwind-merge class-variance-authority)

export function cn(...inputs: ClassValue[]) {
  return twMerge(clsx(inputs))
}

if your component uses icons you need to copy ~/components/icons.tsx into your project (or switch to another icon repo if you like)

Then just copy the component you like to use to your project.
Like if you would love to use the buttons just copy ~/components/ui/button.tsx.
I really hope this already helps enough so that you can start developing :)


fix for https://github.com/divio/django-cms/issues/3563

backport changes to 3.0.X

Coverage decreased (-0.1%) to 87.239% when pulling 4c7205221d3894bf5797415abe8480179f0508af on Medvezhopok:support/3.0.x into 63c09c00f61f4f249c0b0bc9b40b2013f248d8d7 on divio:support/3.0.x.

Coverage decreased (-0.1%) to 87.239% when pulling 4c7205221d3894bf5797415abe8480179f0508af on Medvezhopok:support/3.0.x into 63c09c00f61f4f249c0b0bc9b40b2013f248d8d7 on divio:support/3.0.x.


Command to create, list, show, and delete application plans

Lower level command for application plans management

For create command, flag to enabled/disabled for all current methods
Enabled method for a given app plan -> no limit set
Disabled method for a given app plan -> set limit to 0

By default: enabled


Update Pull Request Procedure to Utilize Branching

Going forward, TFB will using a branching method to help consistently merge
pull requests in. Update the documentation to help guide that process.
Basically, submit PRs to master for bug fixes only and target the upcoming
round branch for everything else.
http://frameworkbenchmarks.readthedocs.io/en/latest/Development/Contributing-Guide/#github-pull-request-procedure

Excellent! Thanks @LadyMozzarella!


[457] (Part 3) Rake task to migrate userpremission from organisations

Context

This trello ticket

Changes proposed in this pull request

A rake task to migrate the OrganisationUser records to UserPermission

Guidance to review

bundle exec rake organisation_user_migrate:migrate_organisation_user_to_user_permission

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Rake task to migrate UserPremission from Organisations

As part of this, it might be worth writing a task that checks the migrated data. That is, something which compares the providers our users have access to via the old table vs the new, and confirms they're the same. We'd want to test the migration task thoroughly on QA before running in prod—something which automates those checks would be quicker and more comprehensive. @stellenberger @darokel WDYT?

As part of this, it might be worth writing a task that checks the migrated data. That is, something which compares the providers our users have access to via the old table vs the new, and confirms they're the same. We'd want to test the migration task thoroughly on QA before running in prod—something which automates those checks would be quicker and more comprehensive. @stellenberger @darokel WDYT?

Yup sounds good to me

LGTM on localhost merging this in... hold tight


Instructions on how to run?

I am looking to have an experiment with some applications with the idea of using them at a hackathon in a months time - This project sounds interesting but I am struggling to get it going with any of the docker compose files included. I have spun up docker-compose.yml and with a bit of tweaking got it to start-up but I am not seeing anything served on port 8000.
Are there any more complete instructions on how to run locally/in prod anywhere?

Hi @Ryanmt2! Thanks for checking out HackTJ Live.
For docs on setting up a local server, you'll want to read https://github.com/HackTJ/live/blob/main/docs/development.md. In short, run docker-compose -f docker-compose.yml -f docker-compose.dev.yml up --force-recreate --build and then open localhost:8000
For deploying a production instance, take a look at https://github.com/HackTJ/live/blob/main/docs/deployment/self-hosted.md. In short, run docker-compose -f docker-compose.yml -f docker-compose.prod.yml up and open localhost:8000.  We also have a basic Heroku setup supported (to scale well you'll probably need to spend some money on a better Heroku plan): https://github.com/HackTJ/live/blob/main/docs/deployment/heroku.md
Let me know if you have any issues or other questions!


Add 2017 Congressional Special Election candidates

http://www.utahcounty.gov/Dept/ClerkAud/Elections/documents/2017SpecialNotice.pdf
https://elections.utah.gov/election-resources/2017-candidate-filings

[ ] Update data to reflect the Utah Republican Party Convention results from this last Saturday.

See also: http://utah.gop/calendar-2/cd3infocenter/


New Rule: Fake DocuSign HTML table not linking to DocuSign domains

Alternative name: Brand Impersonation: DocuSign HTML Table Forgery
Open to suggestions.

/update-test-rules

Not seeing this in the test-rules table.....

/update-test-rules

Test rules are running, but I don't think this should be a blocker. This is pretty tightly scoped and has performed well in hunts already. FN coverage is solid.

Testing looks solid, also matching user reports.

/update-test-rules

Every test rule match has an AS of malicious, couldn't ask for better!


Prevent user from entering invalid "Amount" input field values on "Send Ether" page

on the "Send Ether" page, the user is not prevented from entering the following values for the "Amount" input field:

invalid characters like "+-eE,"
invalid use of decimal point like "0.0.0"
negative values like "-1"

And it doesn't display any error tooltip for the "Amount" input field (like "Please enter a valid amount") until after they've entered a value for the "To" input field that the form considers to be valid.
Is there an opportunity to prevent the user from entering invalid input values similar to what we did for the Balance input field of polkadot-js/apps https://github.com/polkadot-js/apps/issues/144?

PR welcome :)

On second thoughts..
It currently allows use of +e or -e to enter values in scientific notation (i.e. entering 1e-3 for the amount on the "Send Ether" page will send 0.001 Ether).
If those characters aren't used in those combinations then the user is shown a validation error.
Optionally we could add a button similar to the 'Max' button https://github.com/paritytech/fether/pull/302 that toggles scientific notation on/off (to make it more obvious such a feature exists... for example I didn't realise it existed until today), and next to the button have an info icon that shows a popup or similar explaining how to use it. And if the toggle is turned off then we just prevent the user from entering any of the following characters at all +-eE
Negative values when entered already show a validation error, but ideally we'd prevent the user from entering a - character at all unless they're using scientific notation (if we choose to add a scientific notation toggle button).
Multiple decimal points (i.e. .. or 0.0.) already show a validation error (Please enter a valid amount). We could try and prevent them from entering it a second time, but it may end up frustrating the user (since the second one may be the one they want). So I think we should just provide a more specific validation error by detecting when more than one decimal point has been entered and show a validation error like Please enter a valid amount with only one decimal point
I cannot enter the , character in the input field anymore, so we don't have to worry about that anymore.
invalid characters like "+-eE,"
invalid use of decimal point like "0.0.0"


Fixed address family test error for AF_UNIX in BIO_ADDR_make

trivial fix.

I would definitely be for cherry-pick.

I saw this one before the master one.  I'll close this one for the benefit of cherry-picking


Add viber

Viber is a messaging application
They have a deb available from their website.
https://download.cdn.viber.com/cdn/desktop/Linux/viber.deb

Sorry, we are only accepting software that provides a reliable way to dynamically determine the current published version. Please see:

Add guidelines for what packages are acceptable for inclusion


Save last flash mode

Now camera always starts with "auto" flash mode.
It is reasonable to save last user selection.

Added this in Commit 6c4409ae55aaa2ea1a030a230cca7a93038a7396


Slicing steps

Why this PR?
As a user I want to be able to define steps when indexing frames of CorrelatedStacks (i.e. decimate the frames).

Yihaa, thanks for taking the time for reviewing!


magick/api.h: No such file or directory

I am getting magick/api.h: No such file or directory in android studion. In magick_DrawInfo.c  file.
I followed all instruction.

I built using Cygwin and didn't try to build using Android Studio's NDK support.
Maybe Android Studio isn't ready for NDK building, it might be missing some includes.

I  also met this problem in Android studio  (T T.)


[OPT] Use new instruction folder for for all opcodes in spec consti folding

When folding and OpSpecConstantOp, we use the new instruction folder for
a small number of opcodes. This enable the new instruction folder for
all opcodes and uses the old one as a fall back. This allows us to
remove some code from the older folder that is now covered by the new
one.
Fixes #5499

This should fix https://crbug.com/oss-fuzz/66611.

The smoke test failures are due to a change in validation unrelated to this change. Should be fixed with https://github.com/google/shaderc/pull/1395


[Feature] Add Encode Method

Add an encode method to the existing Can class. The current existing decode method will translate a CAN frame into its corresponding signals, the encode method should do the opposite by taking in signals with values and translating them to a CAN payload.=

The encode method would be really useful for transmitting Can messages. Looking forward to it.

Hi @bit-dream Any plans on this feature?


I am making a

Hi. @AnshDeep24, Apple Logo already exists. Please create something else.

sir its not exists i have checked all the issues there is no apple logo u
can see pls merge or
On Mon, Apr 5, 2021 at 1:49 AM Salil Naik @.***> wrote:

Hi. @AnshDeep24 https://github.com/AnshDeep24, Apple Logo already
exists. Please create something else.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/salil-naik/css-art-gallery/issues/84#issuecomment-813093685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOEU6E6VQPGHXZ5UHMMGP2DTHDCT7ANCNFSM42LPNPPQ
.


adapt to SparkSQL Connector cassandra datastore needs

The properties are necessary to SparkSQL connector when it try connect to a Cassandra Cluster

Perfect. Thank you.


Implement JsonSchema

In src/main/scala/schemas.scala there is a unimplemented JsonSchema object.
We need to give it a proper implementation of type Prim[A], ie the "set" of primitive types in JSON.
I think we just need to create an ADT with string, number, boolean and null for that to work

Happy to start working on this


Accessibility Role 'textbox' not defined in documentation about accessibilityRole prop

I had a look here: https://reactnative.dev/docs/accessibility#accessibilityrole-ios-android, and it seems that a role is missing. Assuming that the roles are taken from the standard described here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles it looks like textbox is missing, https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/textbox_role.
Essentially I am looking for a role which describes an input, and it seems that is the correct one to choose.

@jacquesdev As you can see in the source code React Native doesn't support textbox accessibility role right now.
You should create an issue in the react-native repository or start a discussion in the official discussions-and-proposals repository.
Since it's the React Native Website repository we are not able handle your request here.


[WIP] Kafka Broker Triggers receive events from after they are Ready by default

So far, Kafka Broker Triggers receive events from the time before
they were ready by default, contrary to the eventing spec intent.
https://github.com/knative/specs/blob/main/specs/eventing/control-plane.md#trigger-lifecycle

When a Trigger becomes associated with a Broker (either due to creating the Trigger or the Broker), the Trigger MUST only set the Ready condition to true after the Broker has been configured to send all future events matching the spec.filter to the Trigger's spec.subscriber. The Broker MAY send some events to the Trigger's spec.subscriber prior to the Trigger's Readycondition being set to true. When a Trigger is deleted, the Broker MAY send some additional events to the Trigger's spec.subscriber after the deletion.

(notice the terms "all future events" and "MAY send some events
... prior to the Trigger's Ready condition"), the spec clearly mean
only future events should be sent, (allowing only "some prior events"
because of the possible race between Readiness and actual
broker setup... )
This behavior differs from the MTBroker behavior, so now
it's more consistent by default.
Users can still switch back to the previous behavior by changing the
auto.offset.reset=latest to earliest in config-kafka-broker-data-plane

Proposed Changes

Support initializing offsets in Trigger reconciler
Set auto.offset.reset to latest by default
Add E2E test

Release Note

Previously, triggers were receiving events that were sent to a Kafka Broker before they were created.
Now triggers receive events that are sent to the broker after the trigger is ready by default, skipping events that were sent previously.
To switch back to the previous behavior, you can change the `auto.offset.reset=latest` configuration to `earliest` in the `config-kafka-broker-data-plane` ConfigMap.

Can you improve the release note?
Something like:
Triggers were doing ...bla... which was not compliant with the Knative Eventing specification.
Now triggers will receive events that are sent to the broker after the trigger is ready by default, skipping events that were sent previously.
To switch back to the previous behavior, you can change the `auto.offset.reset=latest` configuration to `earliest` in the `config-kafka-broker-data-plane` ConfigMap.

Is this a fair statement for what this PR is doing: When auto.offset.reset=latest, we set the offset to latest for the consumer group in control-plane before consumption starts.
I couldn't really grasp how this would fix our issue here. We set the offset in control plane when trigger is still not ready. We might set the offset and then wait 5 mins before the trigger is ready.
Maybe instead of writing me a reply here, can you update the PR description?
/assign

Waiting for https://github.com/knative-sandbox/eventing-kafka-broker/pull/2602 to go in.

Maven:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.3.0:shade (default) on project receiver: Execution default of goal org.apache.maven.plugins:maven-shade-plugin:3.3.0:shade failed: Plugin org.apache.maven.plugins:maven-shade-plugin:3.3.0 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven:maven-artifact:jar:3.0 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.jar: Connection reset -> [Help 1]

/test unit-tests_eventing-kafka-broker_main

/retest-required

/retest-required

/retest-required

/lgtm
/approve

Failed https://github.com/knative-sandbox/eventing-kafka-broker/issues/2612 for unrelated error
/test upgrade-tests_eventing-kafka-broker_main

/retest

I rebased

/retest-required

/cherry-pick release-1.7


Integration test fails due to http deprecation

ImportError: cannot import name 'download' from 'robocorp.http'  in job.
Read migration guide and fix the invoke test run.

Fixed in https://github.com/robocorp/robocorp/commit/982be1513d5a72df27967f4b5401c85c212ec8d2


Wip prefix search

fix quick list by prefix

If the underlying store does not natively support prefix search, how about just return an error UNSUPPORTED? And then, the filer store wrapper can implement the logic to filter by prefix.
This way seems more cleaner than reimplementing the same logic in those stores?

ok

@chrislusf  Do more clean

Merged! Thanks!


fix: ActionBar items moves focus to disabled items.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

@Pareesh - I have done your suggested change, can you please review and approve/merge if it's looking fine now?


Use caasp v4 images

This needs to go together with https://github.com/kubic-project/salt/pull/747

@MaximilianMeister : will it be ok for you that we merge both Requests? I don't think  tests can pass separately...

https://github.com/SUSE/caasp-jenkins-library/pull/276

will it be ok for you that we merge both Requests? I don't think tests can pass separately...

yes, if you can force merge go ahead. image tags are all correct

@jordimassaguerpla can we now do it without a patch? see https://github.com/kubic-project/caasp-container-manifests/pull/222

now handeled in https://github.com/kubic-project/caasp-container-manifests/pull/222


Send deviceToken to Ably clients which already have been instantiated

This PR does 2 things:

It fixes https://github.com/ably/ably-flutter/issues/276
It allows users to give Ably flutter the device token if they're having issues activating push with Ably. This happens because in some cases (e.g. a customer), didRegisterForRemoteNotifications does not get called in Ably Flutter when running on iOS. This might happen due to method swizzling by other dependencies. This is a workaround for users who cannot fix the fact didRegisterForRemoteNotifications is not being called in Ably Flutter.

@lukasz-szyszkowski , I would like to change the pattern of calling a method in the singleton instance of AblyInstanceStore, seen in AblyInstanceStore.sharedInstance().didRegisterForRemoteNotifications(withDeviceToken: deviceToken)

We're pressured for time to get a release out. So, I'm going to land this work despite having not observed checks pass yet, due to the fact that the most recent commit should not fail CI and the preceding commit passed CI.


Documentation for the faucet service

Documentation for the faucet service.

In which section should it be included?


Idea: Alexa Smartthings skill temperature reporting

Currently, I can ask Alexa to tell me the current temperature reading on my thermostat device via the Smartthings Alexa skill.  But it won't work on the temperature sensor.  I'm wondering if this might be possible if the temp sensor DTH emulates the characterstics of a thermostat so that the ST Alexa skill will interact with it.

You need to install ask alexa or wait till echosistant v5 ti be released has a much easier setup (im on the beta team)

I see the thread on the SmartThings Community forums where you've floated this idea.
Just as discussed there, the ST Alexa skill supports asking the temperature of thermostat devices. It's a bad idea to code the device handler of a temperature sensor to "pretend" to be a thermostat, because then all SmartApps would see the sensors as having full thermostat capabilities, leading to confusion by users on how to properly integrate them into their SmartThings setup.
Also, as mentioned in the thread, the Ask Alexa or the new upcoming version of Echosistant would be the best way to go.
However, by all means, end users are welcome to custom-modify device handler code to suit their needs. I use Alexa devices at home, and when my Xiaomi Aqara Temp / Humidity sensor arrives tomorrow, I can try experimenting with the device handler code to see whether adding the tag for thermostat capability works or breaks things, and then pass on what code modification would get it working (if any).

Just as a note - Alexa will also give me temperature from Ecobee sensors - instead of just the Ecobee - that's through its Ecobee integration of course - but still, maybe one doesn't need a full thermostat definition.  Just a thought.

So is it recognizing your Ecobee sensors through the Ecobee Alexa Skill or the SmartThings skill?

alexa is very limited thats why 'ask alexa' exists with smart home devices only the following commands can be used https://www.amazon.co.uk/gp/help/customer/display.html?nodeId=201749260

Alexa can read back my Sensi Thermostat temp via the ST skill.   I  disabled the Sensi skill because it couldn't.
I noticed someone had created a virtual thermostat DTH (not just smartapp) on the ST community that let's you designate a sensor.  I haven't had time to see if that could bridge the gap.
On Mon, Feb 5, 2018 at 3:02 PM -0600, "Keith G"<EMAIL_ADDRESS>wrote:
So is it recognizing your Ecobee sensors through the Ecobee Alexa Skill or the SmartThings skill?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

should this request be closed?

Through the Ecobee skill... (to answer @veeceeoh ).

I vote close

close... not a dt feature and can be acomplished with "ask alexa"

Doesn't ask alexa require additional BT speakers?  Or is it fully functional with only the echo device? Other DTHs have done something similar such as enabling a garage door DTH to communicate as a switch for Alexa compatibility.
On Wed, Feb 14, 2018 at 2:42 PM -0600, "foz333"<EMAIL_ADDRESS>wrote:
close... not a dt feature and can be acomplished with "ask alexa"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Support encryption

Codecov Report

Merging #4 into master will increase coverage by 1.7%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
+ Coverage   93.75%   95.45%   +1.7%
=========================================
  Files           2        3      +1
  Lines          32       44     +12
  Branches        7        9      +2
=========================================
+ Hits           30       42     +12
  Misses          2        2

Impacted Files
Coverage Δ

src/main/middleware/draftMiddleware.ts
93.75% <100%> (+0.2%)
:arrow_up:

src/main/utils/uuidUtils.ts
100% <0%> (ø)
:arrow_up:

src/main/model/draftDocument.ts
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c641f21...fa62ee3. Read the comment docs.


Resource/leftArrow.png is incorrect

Resource/leftArrow.png is RightArrow actually. Please change it or set flow direction
I had to FlowDirection="RightToLeft" IsRightToLeftFlowDirectionEnabled="True" to fix this

https://github.com/AndreiMisiukevich/CardView/issues/211


ci: use foundry from Sep 2023

This PR sets foundry toolchain action for the version dated on 28 Sep 2023.
This is the closest release with the vm.parseJsonKeys feature (which is needed for this issue).
Chances are that this release will be removed in the future (because it is pretty much a fresh one and foundry tends to delete releases from time to time) but I haven't found any other ones with the vm.parseJsonKeys feature.

so we need it for #616 good catch @rndquu

so we need it for #616 good catch @rndquu, but we shouldn't rely on fresh release, they act fast, it will broke the CI

I don't have other ideas except simply using the latest nightly build which also might break the CI

and also if it breaks, then we change the CI, it will break the implementantion, what about we wait for a proper release and postpone #616

Yes, in such cases staging area is helpful. Foundry has been always 'nightly' so far but some nightlies are marked as pre-release.
I had a quick look and since the previous used version changes can be analyzed here
https://github.com/foundry-rs/foundry/compare/nightly-d369d2486f85576eec4ca41d277391dfdae21ba7...nightly-96ab9131e6735df35aca0249968c7d339590de20
The version selected by @rndquu was fortunately selected / pinned recently as a pre-release https://github.com/foundry-rs/foundry/tags vs https://github.com/foundry-rs/foundry/releases (see the pre-release label on 28th September) so it might have a chance for survival.

judging by the #803 i will consider #616 as breaking even tho it's labeled as a small task, we could give it a try but when we have to deal with reverts PR (in extreme cases) because rndqnuu changes a lot of things at #803

https://github.com/foundry-rs/foundry/releases/tag/nightly-96ab9131e6735df35aca0249968c7d339590de20

this release https://github.com/foundry-rs/foundry/releases/tag/nightly-96ab9131e6735df35aca0249968c7d339590de20 mentioned by rndqnuu in this PR was just removed

lol notice at the same time

but yeah i mean, i don't think you want to stale #616 and judging by when we found "stable" commit it was months, so i think it will take a few months to have a stable with the new implementation vm.parseJsonKey

but yeah i mean, i don't think you want to stale #616 and judging by when we found "stable" commit it was months, so i think it will take a few months to have a stable with the new implementation vm.parseJsonKey

I'm refactoring the deployment script and this issue is a part of this refactoring

Ok, right now foundry release from 30 Sep is set, let's wait for a couple of days. If it is not removed then I will merge the current PR because I really need the vm.parseJsonKeys feature.

we can deal with fixes if they come by

Interestingly I noticed that previously they kept always pre-release from 2nd day of a month. If this is still the case the one from October 2nd will stay. Let's see.


Create basic models

Create basic models of database and class structure for login.

I'm not sure so dont be mad, but I think that UserSecretId should be in other file added to git-ignore. pls explain if it's correct (?)

Some general remarks:

do we need all those empty classes / folders now?
overall suggestion: manage usings in files c:

Looks fine


Handling entry commands

Do you want to request a feature or report a bug?
bug
Please provide a sample input docker run command
docker run -p 8080:8080 -e KEYCLOAK_ADMIN=admin -e KEYCLOAK_ADMIN_PASSWORD=admin quay.io/keycloak/keycloak:18.0.2 start-dev

What is the current output?*
version: '3.3'
services:
    start-dev:
        ports:
            - '8080:8080'
        environment:
            - KEYCLOAK_ADMIN=admin
            - KEYCLOAK_ADMIN_PASSWORD=admin
        image: start-dev

What is the expected/desired output?
version: '3.3'
services:
    keycloak:
        ports:
            - '8080:8080'
        environment:
            - KEYCLOAK_ADMIN=admin
            - KEYCLOAK_ADMIN_PASSWORD=admin
        image: quay.io/keycloak/keycloak:18.0.2
        command: start-dev

I had the same issue

same issue

Maybe add --name will be ok.
docker run -p 8080:8080 -e KEYCLOAK_ADMIN=admin -e KEYCLOAK_ADMIN_PASSWORD=admin quay.io/keycloak/keycloak:18.0.2 --name start-dev

out:
version: '3.3'
services:
    keycloak:
        ports:
            - '8080:8080'
        environment:
            - KEYCLOAK_ADMIN=admin
            - KEYCLOAK_ADMIN_PASSWORD=admin
        container_name: start-dev
        image: 'quay.io/keycloak/keycloak:18.0.2'

Maybe add --name will be ok.
docker run -p 8080:8080 -e KEYCLOAK_ADMIN=admin -e KEYCLOAK_ADMIN_PASSWORD=admin quay.io/keycloak/keycloak:18.0.2 --name start-dev

out:
version: '3.3'
services:
    keycloak:
        ports:
            - '8080:8080'
        environment:
            - KEYCLOAK_ADMIN=admin
            - KEYCLOAK_ADMIN_PASSWORD=admin
        container_name: start-dev
        image: 'quay.io/keycloak/keycloak:18.0.2'

start-dev is a command which the container will execute. It isn't a container name.

Same issue with
docker run --rm -it -p 6080:6080 -v fgc:/fgc/data --pull=always ghcr.io/vogler/free-games-claimer node gog

Hi, this is solved by my PR https://github.com/magicmark/composerize/pull/571 deployed at https://deploy-preview-571--composerize.netlify.app/


Validate Checkpoint Config

Currently, Checkpoint assumes that the config object passed into the constructor is properly structured, but this will not always be the case.
Validation should be done on the config objects structure before starting the indexer. Maybe a using json schema validation.

Hey @perfectmak, I know some devs who'd be interested in working on this. Is there a budget for fixing this issue, and if so, how much?
I'd put this issue up on OpenQ.
Thanks!


⚠ Mobitopup has degraded performance

In b5c4219, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 8543 ms

Resolved: Mobitopup performance has improved in 4f5ae37.


feat: Manage-SDK, removeForApp, clear and clearForApp for secure storage

:tada: This PR is included in version 0.13.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


lib: context.cc: weird line, investigate later

around line 741:
 group_entry_view.GroupItemCount = entry_groups[group_entry_view.GroupName];

entry_groups is std::map<std::string, bool_t>
group_entry_view.GroupItemCount is uint64_t
Probably very wrong, need to find out what exactly is it supposed to do.

The entry_groups is used to keep track which of the groups are opened and witch are closed. The
// To cache grouped entries open/close status
  708:     std::map<std::string, bool_t> entry_groups;

The line 741 should not work and the number of group item should be always be 0 or 1 in that case.
That line can be removed as it is never used.
The correct number of items that is used in the UI is set a few line later.
                            group_view.GroupItemCount = group_items[group_view.GroupName].size();


Add initial support for SAMD11C14A

This should add initial support for the aforementioned device. Couldn't get the USB module to build so it is not included at this time, but everything else from hal/src/samd21 should be there. Only really tested with a blinky app so far, but that confirms multiple peripherals are functioning so that's a good sign.
The feature gating in hal/src/lib.rs could probably be a bit cleaner, but this should work for the time being. When/if more devices get added it may be worth adding a samd21 feature as well or something.
I haven't added anything to travis.yml regarding the new device as there are not currently any board crates that use it. Not sure if this is an issue or if it's okay for the time being.
If I've omitted anything or anything needs fixing just let me know.

I would like to see more testing done before merging

Sounds good, just wanted to get the ball rolling. I'll try to get a bit of testing done this evening or tomorrow if possible.

Pay special attention to sercom padout

Still working on this, slowly.
I've additionally tested Timers and the ADC, both appear to be functioning properly to the best of my knowledge. Working on testing PWM and UART next, will update when I have them working.

Great, thanks

I got the UART working this morning, tested SERCOM0 and SERCOM1.
I'm trying to figure out why PWM isn't working currently. I haven't looked at I2C or SPI at all yet, but those would be next and (for now) the last tests.
I've just been duplicating examples from other boards for my testing. Just to recap, so far I've replicated and validated:

feather_m0/examples/blinky_basic.rs
metro_m4/examples/timer.rs
feather_m0/examples/adc.rs
metro_m4/examples/serial.rs

Anything else you'd like to see done other than what's mentioned in this comment?

That's probably enough I think. Anything else you'd like to add?

I would eventually like to get USB working as well, but I think I'll wait to do so in another PR. I think what I have is a decent base for the time being.
Since I'm just using a chip on a breadboard I've created a samd11_bare "board", which I have now added and included in the Travis config. It's a bit hacky, so if you'd like any changes made to this let me know, wasn't quite sure how else to approach testing.
I took a look through awesome-embedded-rust and I own a couple of devices with I2C drivers implemented, so I'm hoping to have that working sometime this weekend. Unfortunately it doesn't appear I have anything with a SPI driver written at this point in time, I hope that's not a problem.

With SERCOMs, if Serial works, I2C and SPI likely will too.

16K flash is pretty smol. Try telling travis to build in release mode.

Yes that seems to be the issue, running without --release causes the linker error locally for me too.
I'm not super familiar with Travis unfortunately, am I able to add --release to the entry within env somehow, or do I need to specify it under script where cargo build gets called?

Yeah I see what you mean, it will require a few changes to our current travis setup. If you add me to your repo I can take care of it.

I've added you as a collaborator, thanks!

I'm good to merge if you are.

Sounds great, thanks again for the help.


Updated new wish list tests review

Please resolve the conflicts against master first by merging in the latest master into this branch and making a decision what is right. commit it and i am happy to merge.

Done, will open a new request.


Add React Native with hooks and TypeScript as package

Add shared package for components and validators.

Shared package considered harmful. Flat packages ftw. A shared package would become kitchen sink soon enough.


New cloud API

Hi,
I can see there has been some movement on the official cloud API.
Can you advise when/if this NR integration will be updated with this new API?
Thanks.

@vantech14 you can give it a first try using Open API branch. This is still work in progress because there are currently data missing which are used via the monitoring portal's API. Feel free to try it out – I would really appreciate your feedback!

@dehsgr thanks, will check it out next week as I'm currently on vacation. Looking forward to it.

Hi @dehsgr i am trying to figure out how to add this new integration to Nodered?
Thanks.

@dehsgr haven't been able to work on this yet but will try tomorrow. How far are you from a public release of the new integration?

Sorry for my late replay. Public release depends on Alpha ESS progress on their API and its release.

Hi @dehsgr hope all is well. What is the latest on this?
Thanks.

@vantech14 the same as on 2nd of April. ;-)

Published new v2 talking against open API.


Overlay hotkeys do not function if overlay section of side is not hovered over

Example: Pressing "G" for Room stats has no effect.
Hovering over right-side of screen where overlay icons are, "G" works again and the hovering box of roomstats appears. "G" cannot be pressed again to toggle the display off until hovering back over the icons.

Will investigate tomorrow, thanks for the bug reports!

Thanks for the bug report. Just fixed it with the last update. But modded overlay hotkeys won't work probably unless reported and  if I add a compat support for them.