Cant compile the code through ninja, even though the requirements have been met,

So, we were trying to recreate whisper, and have the required hardware installed, such as those 10Gb/s NICs and our software environment is:-

Ubuntu 16.04.7 LTS (GNU/Linux 4.4.0-186-generic x86_64)
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
g++ (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
Python 3.8.9
ninja 1.5.1
cmake version 3.11.0
dpdk-stable-18.11.11
Pcapplusplus v21.11
libtorch latest
mlpack 2.0.1-1 amd64

And when we try to build it using ninja here is the following error
[4/6] Building CXX object commune/CMakeFiles/commune.dir/deviceConfig.cpp.o
FAILED: /usr/bin/c++  -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_RPC -DUSE_TENSORPIPE -isystem /home/iiitd/Whisper_Recreation/libtorch/include -isystem /home/iiitd/Whisper_Recreation/libtorch/include/torch/csrc/api/include -D_GLIBCXX_USE_CXX11_ABI=0   -D_GLIBCXX_USE_CXX11_ABI=0 -fopenmp -std=gnu++14 -MD -MT commune/CMakeFiles/commune.dir/deviceConfig.cpp.o -MF commune/CMakeFiles/commune.dir/deviceConfig.cpp.o.d -o commune/CMakeFiles/commune.dir/deviceConfig.cpp.o -c ../commune/deviceConfig.cpp
../commune/deviceConfig.cpp: In member function ‘void Whisper::DeviceConfig::do_init()’:
../commune/deviceConfig.cpp:356:2: error: ‘LoggerPP’ has not been declared
  LoggerPP::getInstance().suppressErrors();
  ^
[4/6] Building CXX object commune/CMakeFiles/commune.dir/parserWorker.cpp.o
FAILED: /usr/bin/c++  -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_RPC -DUSE_TENSORPIPE -isystem /home/iiitd/Whisper_Recreation/libtorch/include -isystem /home/iiitd/Whisper_Recreation/libtorch/include/torch/csrc/api/include -D_GLIBCXX_USE_CXX11_ABI=0   -D_GLIBCXX_USE_CXX11_ABI=0 -fopenmp -std=gnu++14 -MD -MT commune/CMakeFiles/commune.dir/parserWorker.cpp.o -MF commune/CMakeFiles/commune.dir/parserWorker.cpp.o.d -o commune/CMakeFiles/commune.dir/parserWorker.cpp.o -c ../commune/parserWorker.cpp
../commune/parserWorker.cpp: In member function ‘virtual bool Whisper::ParserWorkerThread::run(uint32_t)’:
../commune/parserWorker.cpp:20:174: error: invalid cast from type ‘std::shared_ptr<Whisper::PacketMetaData []>’ to type ‘Whisper::PacketMetaData (*)[]’
  meta_pkt_arr = (Whisper::PacketMetaData (*)[])shared_ptr<PacketMetaData[]>(new PacketMetaData[p_parser_config->meta_pkt_arr_size](), std::default_delete<PacketMetaData[]>());

                  ^
../commune/parserWorker.cpp:110:18: error: no match for ‘operator[]’ (operand types are ‘std::shared_ptr<Whisper::PacketMetaData []>’ and ‘volatile size_t {aka volatile long unsigned int}’)
      meta_pkt_arr[meta_index] = *p_meta;
                  ^
In file included from /usr/include/c++/5/bits/shared_ptr.h:52:0,
                 from /usr/include/c++/5/memory:82,
                 from /usr/local/include/pcapplusplus/PcapFilter.h:6,
                 from /usr/local/include/pcapplusplus/Device.h:8,
                 from /usr/local/include/pcapplusplus/DpdkDevice.h:8,
                 from ../commune/dpdkCommon.hpp:15,
                 from ../commune/parserWorker.hpp:3,
                 from ../commune/parserWorker.cpp:1:
/usr/include/c++/5/bits/shared_ptr_base.h: In instantiation of ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(_Tp1*, _Deleter) [with _Tp1 = Whisper::PacketMetaData; _Deleter = std::default_delete<Whisper::PacketMetaData []>; _Tp = Whisper::PacketMetaData []; __gnu_cxx::_Lock_policy _Lp = (__gnu_cxx::_Lock_policy)2u]’:
/usr/include/c++/5/bits/shared_ptr.h:134:37:   required from ‘std::shared_ptr<_Tp>::shared_ptr(_Tp1*, _Deleter) [with _Tp1 = Whisper::PacketMetaData; _Deleter = std::default_delete<Whisper::PacketMetaData []>; _Tp = Whisper::PacketMetaData []]’
../commune/parserWorker.cpp:20:174:   required from here
/usr/include/c++/5/bits/shared_ptr_base.h:892:37: error: cannot convert ‘Whisper::PacketMetaData*’ to ‘Whisper::PacketMetaData (*)[]’ in initialization
  : _M_ptr(__p), _M_refcount(__p, __d)
                                     ^
[4/6] Building CXX object commune/CMakeFiles/commune.dir/analyzerWorker.cpp.o
FAILED: /usr/bin/c++  -DUSE_C10D_GLOO -DUSE_DISTRIBUTED -DUSE_RPC -DUSE_TENSORPIPE -isystem /home/iiitd/Whisper_Recreation/libtorch/include -isystem /home/iiitd/Whisper_Recreation/libtorch/include/torch/csrc/api/include -D_GLIBCXX_USE_CXX11_ABI=0   -D_GLIBCXX_USE_CXX11_ABI=0 -fopenmp -std=gnu++14 -MD -MT commune/CMakeFiles/commune.dir/analyzerWorker.cpp.o -MF commune/CMakeFiles/commune.dir/analyzerWorker.cpp.o.d -o commune/CMakeFiles/commune.dir/analyzerWorker.cpp.o -c ../commune/analyzerWorker.cpp
../commune/analyzerWorker.cpp: In member function ‘size_t Whisper::AnalyzerWorkerThread::fetch_form_parser(std::shared_ptr<Whisper::ParserWorkerThread>) const’:
../commune/analyzerWorker.cpp:159:33: error: invalid use of array with unspecified bounds
     memcpy(meta_pkt_arr.get() + m_index, pt->meta_pkt_arr.get(), copy_len * sizeof(PacketMetaData));
                                 ^
../commune/analyzerWorker.cpp: In member function ‘void Whisper::AnalyzerWorkerThread::wave_analyze()’:
../commune/analyzerWorker.cpp:184:42: error: invalid use of array with unspecified bounds
         uint32_t addr = (ntohl(raw_data[i].address));
                                          ^
../commune/analyzerWorker.cpp:184:43: error: invalid use of array with unspecified bounds
         uint32_t addr = (ntohl(raw_data[i].address));
                                           ^
../commune/analyzerWorker.cpp:185:39: error: invalid use of array with unspecified bounds
         analysis_pkt_len += raw_data[i].pkt_length;
                                       ^
../commune/analyzerWorker.cpp:185:40: error: invalid use of array with unspecified bounds
         analysis_pkt_len += raw_data[i].pkt_length;
                                        ^
../commune/analyzerWorker.cpp:210:28: error: invalid use of array with unspecified bounds
             raw_data[_ve[i]].time_stamp -= raw_data[_ve[i - 1]].time_stamp;
                            ^
../commune/analyzerWorker.cpp:210:29: error: invalid use of array with unspecified bounds
             raw_data[_ve[i]].time_stamp -= raw_data[_ve[i - 1]].time_stamp;
                             ^
../commune/analyzerWorker.cpp:210:63: error: invalid use of array with unspecified bounds
             raw_data[_ve[i]].time_stamp -= raw_data[_ve[i - 1]].time_stamp;
                                                               ^
../commune/analyzerWorker.cpp:210:64: error: invalid use of array with unspecified bounds
             raw_data[_ve[i]].time_stamp -= raw_data[_ve[i - 1]].time_stamp;
                                                                ^
../commune/analyzerWorker.cpp:211:32: error: invalid use of array with unspecified bounds
             if (raw_data[_ve[i]].time_stamp <= 0) {
                                ^
../commune/analyzerWorker.cpp:211:33: error: invalid use of array with unspecified bounds
             if (raw_data[_ve[i]].time_stamp <= 0) {
                                 ^
../commune/analyzerWorker.cpp:212:32: error: invalid use of array with unspecified bounds
                 raw_data[_ve[i]].time_stamp = min_interval_time;
                                ^
../commune/analyzerWorker.cpp:212:33: error: invalid use of array with unspecified bounds
                 raw_data[_ve[i]].time_stamp = min_interval_time;
                                 ^
../commune/analyzerWorker.cpp:215:24: error: invalid use of array with unspecified bounds
         raw_data[_ve[0]].time_stamp = min_interval_time;
                        ^
../commune/analyzerWorker.cpp:215:25: error: invalid use of array with unspecified bounds
         raw_data[_ve[0]].time_stamp = min_interval_time;
                         ^
../commune/analyzerWorker.cpp:224:54: error: invalid use of array with unspecified bounds
             ten[i] = weight_transform(raw_data[_ve[i]]);
                                                      ^
../commune/analyzerWorker.cpp:224:55: error: no matching function for call to ‘Whisper::AnalyzerWorkerThread::weight_transform(Whisper::PacketMetaData [])’
             ten[i] = weight_transform(raw_data[_ve[i]]);
                                                       ^
In file included from ../commune/analyzerWorker.cpp:1:0:
../commune/analyzerWorker.hpp:160:24: note: candidate: static double_t Whisper::AnalyzerWorkerThread::weight_transform(const Whisper::PacketMetaData&)
     auto static inline weight_transform(const PacketMetaData & info) -> double_t;
                        ^
../commune/analyzerWorker.hpp:160:24: note:   no known conversion for argument 1 from ‘Whisper::PacketMetaData []’ to ‘const Whisper::PacketMetaData&’
../commune/analyzerWorker.cpp:372:42: error: no match for ‘operator[]’ (operand types are ‘std::shared_ptr<Whisper::AnalyzerWorkerThread::FlowRecord []>’ and ‘size_t {aka long unsigned int}’)
             auto & buf_loc = flow_records[flow_record_size % result_buffer_size];
                                          ^
../commune/analyzerWorker.cpp: In member function ‘bool Whisper::AnalyzerWorkerThread::save_res_json() const’:
../commune/analyzerWorker.cpp:417:34: error: no match for ‘operator[]’ (operand types are ‘const std::shared_ptr<Whisper::AnalyzerWorkerThread::FlowRecord []>’ and ‘size_t {aka long unsigned int}’)
         _j.push_back(flow_records[i].address);
                                  ^
../commune/analyzerWorker.cpp:418:34: error: no match for ‘operator[]’ (operand types are ‘const std::shared_ptr<Whisper::AnalyzerWorkerThread::FlowRecord []>’ and ‘size_t {aka long unsigned int}’)
         _j.push_back(flow_records[i].distence);
                                  ^
../commune/analyzerWorker.cpp:419:34: error: no match for ‘operator[]’ (operand types are ‘const std::shared_ptr<Whisper::AnalyzerWorkerThread::FlowRecord []>’ and ‘size_t {aka long unsigned int}’)
         _j.push_back(flow_records[i].packet_num);
                                  ^
In file included from /usr/include/c++/5/bits/shared_ptr.h:52:0,
                 from /usr/include/c++/5/memory:82,
                 from ../commune/../common.hpp:11,
                 from ../commune/analyzerWorker.hpp:3,
                 from ../commune/analyzerWorker.cpp:1:
/usr/include/c++/5/bits/shared_ptr_base.h: In instantiation of ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(_Tp1*, _Deleter) [with _Tp1 = Whisper::PacketMetaData; _Deleter = std::default_delete<Whisper::PacketMetaData []>; _Tp = Whisper::PacketMetaData []; __gnu_cxx::_Lock_policy _Lp = (__gnu_cxx::_Lock_policy)2u]’:
/usr/include/c++/5/bits/shared_ptr.h:134:37:   required from ‘std::shared_ptr<_Tp>::shared_ptr(_Tp1*, _Deleter) [with _Tp1 = Whisper::PacketMetaData; _Deleter = std::default_delete<Whisper::PacketMetaData []>; _Tp = Whisper::PacketMetaData []]’
../commune/analyzerWorker.cpp:53:53:   required from here
/usr/include/c++/5/bits/shared_ptr_base.h:892:37: error: cannot convert ‘Whisper::PacketMetaData*’ to ‘Whisper::PacketMetaData (*)[]’ in initialization
  : _M_ptr(__p), _M_refcount(__p, __d)
                                     ^
/usr/include/c++/5/bits/shared_ptr_base.h: In instantiation of ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(_Tp1*, _Deleter) [with _Tp1 = Whisper::AnalyzerWorkerThread::FlowRecord; _Deleter = std::default_delete<Whisper::AnalyzerWorkerThread::FlowRecord []>; _Tp = Whisper::AnalyzerWorkerThread::FlowRecord []; __gnu_cxx::_Lock_policy _Lp = (__gnu_cxx::_Lock_policy)2u]’:
/usr/include/c++/5/bits/shared_ptr.h:134:37:   required from ‘std::shared_ptr<_Tp>::shared_ptr(_Tp1*, _Deleter) [with _Tp1 = Whisper::AnalyzerWorkerThread::FlowRecord; _Deleter = std::default_delete<Whisper::AnalyzerWorkerThread::FlowRecord []>; _Tp = Whisper::AnalyzerWorkerThread::FlowRecord []]’
../commune/analyzerWorker.cpp:60:47:   required from here
/usr/include/c++/5/bits/shared_ptr_base.h:892:37: error: cannot convert ‘Whisper::AnalyzerWorkerThread::FlowRecord*’ to ‘Whisper::AnalyzerWorkerThread::FlowRecord (*)[]’ in initialization
[4/6] Building CXX object CMakeFiles/Whisper.dir/main.cpp.o
ninja: build stopped: subcommand failed.

Thanks for your attention to this study!
I have encountered a similar issue when using a lower version of the compilers. I guess it's due to the incompatible version of Libpcap++ for Ubuntu 16. The LoggerPP module is always modified by the authors. Simply disabling the line of
LoggerPP::getInstance().suppressErrors();

might eliminate some of the errors.
And I will check out the versions of the libraries after my vacation and reply to you as soon as possible. Because I have updated the software suits to keep up with the latest versions for this repo.
For the other issues, if you like, contact me by email (fcp20@mails.tsinghua.edu.cn). Because I rarely look up what's going on on Github.
Thanks for this issue again.

Hey,
Hope your vacation went well, after a lot of retries and and double checking the speed of our NIC (Intel XL710 40G) with pktgen we are getting a total of 40 Gbps as can be seen here

we still are getting the above error as stated above and the software versions are the same as above as we followed the recreation steps from the pdf of your research. For a better view, the screenshots of the error is as follows

We mailed you at your email address yesterday, and our hoping for a response from your asap.
Thnx

Hi! I have the same problem as you. How did you solve it?

Hi! I recently managed to compile and run Whisper with these dependencies:

ubuntu 22.04
dpdk 19.11.8
pcap++ 21.05
torch 1.9.0
apt installed:

libmlpack-dev mlpack-bin
cmake
ninja-build
build-essential

I have created a repo to build docker with dpdk and pcap++. Might be helpful.
duskmoon314/docker-dpdk

Hey @duskmoon314 , ik this question would be more relevant for the author, but it would be great if you could look at them and if possible answer a few of my questions regarding the codebase as well.
Q1) As per the exectution, every flow-IP is being logged into a json file with some maliciousness score.
Where in the code does it decide  that a particular entry of flow-IP in json file is malicious/benign before making the auc-roc graph?
Q2) As per the auc.py code, it counts normal and abnormal packets while matching flow-Ip with malicious_IP retrie
ved from template.json file. Further this count is being used to calculate fpr/tpr and it is being used in generation of roc_auc curves.
So what about the packets that do not match with the malicious_IP retrieved from template.json file? The code should (somewhere) validate if a benign flow is actually being classified as "benign" ?
Thanks

Not sure if I am right, but here's how I understand it.

Where in the code does it decide that a particular entry of flow-IP in json file is malicious/benign before making the auc-roc graph?

I think the cpp part doesn't identify which flow is malicious or benign. It seems the address.json, which stores all the malicious IP, is only used in auc.py at lines 130-145.

So what about the packets that do not match with the malicious_IP retrieved from template.json file? The code should (somewhere) validate if a benign flow is actually being classified as "benign" ?

It seems the code treats flows that are not in address.json as benign.


ACCUMULO-3920 Deprecate mock components

Done so far

Deprecate Accumulo Mock classes
Add javadoc to mock package to add additional details
Create DeprecationUtil to help migrate code which must continue to use mock
Minimize mock usage throughout the tests wherever possible

Use EasyMock in a few cases where it was possible to satisfy the test
Apply @Rule, @Before, etc. to reduce number of calls to MockInstance

Create replacement IteratorAdapter for use outside of mock

Could use help with
(most of these can be pretty readily identified in Eclipse with deprecation warnings shown)

Migrating FormatterCommandTest.java to avoid use of MockShell
Migrating MapReduce tests and other "heavyweight" tests to use MiniAccumuloCluster
Migrating other "lightweight" tests to use EasyMock

I am thinking we can drop IntersectingIteratorTest.testWithBatchScanner() because ExamplesIT.testShardedIndex() will test IntersectingIter using a real batch scanner in an IT.  IntersectingIteratorTest.testWithBatchScanner() is testing IntersectingIter using the mock batch scanner.  Alternatively if we want to treat this as a test of mock, we could just suppress warnings on the test and add a comment stating the test is intended to test the mock batch scanner.

Works for me. Let's drop the redundant test.

I removed IntersectingIteratorTest.testWithBatchScanner()  in 712f4e8.  I checked coverge of IntersectingIterator before and after.  It went from 73.8 to 73.6


Mention this extension in Task docs

I think this extension should be mentioned here: https://taskfile.dev/community/#visual-studio-code-extension

Yup agreed. I've had a WIP branch for a while now. I'll get it pushed soon 👍


misc/cgo/test: issue24161 tests broken on Darwin

CL 152762 (which fixes #27340) appears to have broken the misc/cgo/test regression tests for #24161 on the darwin builders.
Sample log: https://build.golang.org/log/ace9419991890f522f2affbe8f1ceb2e6d5fe9fa

##### ../misc/cgo/test
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:09 Failed: exit status 2
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:10 Failed: exit status 2
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:11 Failed: exit status 2
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:11 Failed: exit status 2
2018/12/10 20:18:12 FAILED

CC @eliasnaur @ianlancetaylor @randall77

@gopherbot please open a backport issue for 1.11, as CL 152762 was cherry-picked there, causing the same issue.


Can't specify server in the server list

It is not possible to specify server in the server list, see video attached.
Reproduced on several devices at least Samsung S7 and Samsung S9+ (Android 8.0, see screenshot)
Application version latest available now in the Google play (screenshot attached), I can't find it in the menu nearby the username.
Steps to reproduce: in the newly installed application (or remove all data in "applications" settings) click on "server list" or swipe with two fingers. Click either on the empty list item or the "+" button.
Actual: see what's happening in the attached video, the list just disappears.
Expected: user is able to specify server address in the list successfully.
Video accessed here: https://1drv.ms/v/s!AlsU4wa12aVTu0XgkKEVApX25CwE

@virtualwatt Thanks for reporting! But this issue seems to be related to the Cordova app and not the native one. This repo is the native's one. Please repost your issue here: https://github.com/RocketChat/Rocket.Chat.Cordova


implement throw

add some codes in parser, vm_codegen, and vm for "throw" statement.
(trycatch.js)
for (i = 0; i < 1000; i++){
    if (i = 8) throw "count is " + i
}
console.log("finished")

$ cargo run examples/trycatch.js
    Finished dev [unoptimized + debuginfo] target(s) in 0.21s
     Running `target/debug/rapidus examples/trycatch.js`
runtime error: Uncaught Exception
'count is 8'
$ node examples/trycatch.js
.../examples/trycatch.js:2
    if (i = 8) throw "count is " + i
               ^
count is 8

Thank you for your PR.


chore: install helm before running tests (#2406)

Backport
This will backport the following commits from 2.x to 1.x:

chore: install helm before running tests (#2406)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2409

Questions ?
Please refer to the Backport tool documentation


Impossible to serve with Node v17.0.1

Version
5.0.0-beta.6
Environment info
Environment Info:

  System:
    OS: macOS 11.5.2
    CPU: (8) arm64 Apple M1
  Binaries:
    Node: 17.0.1 - /usr/local/bin/node
    Yarn: 1.22.15 - /opt/homebrew/bin/yarn
    npm: 8.1.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 94.0.4606.81
    Edge: Not Found
    Firefox: 92.0
    Safari: 14.1.2
  npmPackages:
    @intlify/vue-devtools:  9.1.9
    @intlify/vue-i18n-loader: 3.2.0 => 3.2.0
    @storybook/vue3: 6.3.12 => 6.3.12
    @vue/babel-helper-vue-jsx-merge-props:  1.2.1
    @vue/babel-helper-vue-transform-on:  1.0.2
    @vue/babel-plugin-jsx:  1.1.1
    @vue/babel-plugin-transform-vue-jsx:  1.2.1
    @vue/babel-preset-app:  5.0.0-beta.6
    @vue/babel-preset-jsx:  1.2.4
    @vue/babel-sugar-composition-api-inject-h:  1.2.1
    @vue/babel-sugar-composition-api-render-instance:  1.2.4
    @vue/babel-sugar-functional-vue:  1.2.2
    @vue/babel-sugar-inject-h:  1.2.2
    @vue/babel-sugar-v-model:  1.2.3
    @vue/babel-sugar-v-on:  1.2.3
    @vue/cli-overlay:  5.0.0-beta.6
    @vue/cli-plugin-babel: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-plugin-e2e-cypress: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-plugin-eslint: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-plugin-router: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-plugin-typescript: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-plugin-unit-jest: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-plugin-vuex: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-service: 5.0.0-beta.6 => 5.0.0-beta.6
    @vue/cli-shared-utils:  5.0.0-beta.6
    @vue/compiler-core:  3.2.20
    @vue/compiler-dom:  3.2.20
    @vue/compiler-sfc: 3.2.20 => 3.2.20
    @vue/compiler-ssr:  3.2.20
    @vue/component-compiler-utils:  3.2.2
    @vue/devtools-api:  6.0.0-beta.19
    @vue/eslint-config-prettier: 6.0.0 => 6.0.0
    @vue/eslint-config-typescript: 8.0.0 => 8.0.0
    @vue/reactivity:  3.2.20
    @vue/ref-transform:  3.2.20
    @vue/runtime-core:  3.2.20
    @vue/runtime-dom:  3.2.20
    @vue/server-renderer:  3.2.20
    @vue/shared:  3.2.20
    @vue/test-utils: 2.0.0-rc.16 => 2.0.0-rc.16
    @vue/vue3-jest: 27.0.0-alpha.1 => 27.0.0-alpha.1
    @vue/web-component-wrapper:  1.3.0
    eslint-plugin-vue: 7.20.0 => 7.20.0
    jest-serializer-vue:  2.0.2
    typescript: 4.4.4 => 4.4.4
    vue: 3.2.20 => 3.2.20 (2.6.14)
    vue-cli-plugin-i18n: 2.3.1 => 2.3.1
    vue-docgen-api:  4.41.2
    vue-docgen-loader:  undefined (1.5.0)
    vue-eslint-parser:  7.11.0
    vue-hot-reload-api:  2.3.4
    vue-i18n: 9.1.9 => 9.1.9 (8.26.5)
    vue-i18n-extract:  1.0.2
    vue-inbrowser-compiler-utils:  4.41.2
    vue-loader: 16.8.1 => 16.8.1 (15.9.8)
    vue-router: 4.0.12 => 4.0.12
    vue-style-loader:  4.1.3
    vue-template-es2015-compiler:  1.9.1
    vue3-click-away: 1.2.1 => 1.2.1
    vuex: 4.0.2 => 4.0.2
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

Update to Node v17.0.1
Create a new vue 3 app through the cli
run vue-cli-service serve script

What is expected?
Normal compilation of the app
What is actually happening?
Exit code 1
The following object appears in the console
{
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

From https://medium.com/the-node-js-collection/node-js-17-is-here-8dba1e14e382
we can see this issue is due to Open SSL 3.0
From the article:
"If you hit an ERR_OSSL_EVP_UNSUPPORTED  error in your application with Node.js 17, it’s likely that your application or a module you’re using is attempting to use an algorithm or key size which is no longer allowed by default with OpenSSL 3.0. A new command-line option, --openssl-legacy-provider, has been added to revert to the legacy provider as a temporary workaround for these tightened restrictions."

export NODE_OPTIONS=--openssl-legacy-provider fixes it for me.

Downgrading to Node:16.13.0 worked for me

Fixed in v5.0.0-beta.7

I just uninstalled @vue/cli 4.5.15 and installed @vue/cli 5.0.0-rc.0 and am getting the error, under NodeJS 17.0.1.

export NODE_OPTIONS=--openssl-legacy-provider fixes it for me.

Works for me with:

Node v. 17.1.0
@vue/cli v. 4.5.15
PowerShell 7.2.0
Windows 10 v. 20H2

@sergiocabral, I have seen that solution, but I also thought it had been addressed in v5.0.0-beta.7 per @sodatea?

@Miguel-Bento-Github
change script in pancake.json with
"serve": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve",     "build": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service build"

@mhavid You are commenting on a closed issue that has already been fixed.

@Miguel-Bento-Github change script in pancake.json with "serve": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve", "build": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service build"

THIS IS LEGIT ONLY ONE THING THAT WORKED!!!!!! THANK YOU

WILL BE USING THIS REGULARLY. lol

the SET NODE_OPTIONS strategy didn't work for me 😔, but what DID work was....
"serve": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve", "build": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service build",
(I just squished together @mrichman's fix and @mhavid, so credit to them!)

On Windows who can do this on CMD using
set NODE_OPTIONS=--openssl-legacy-provider

the SET NODE_OPTIONS strategy didn't work for me pensive, but what DID work was.... "serve": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve", "build": "export NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service build", (I just squished together @mrichman's fix and @mhavid, so credit to them!)

I have updated this in my package.json but I have not pushed the package.json file to my heroku. I want to ask, will pushing this code to my heroku master break the website or is it safe to do so? I am asking because ever since I have upgraded to node v17.3.1 I have noticed a lot of dependencies have updated in my package-lock.json. I am not sure if updating and pushing both these files will build a functioning version on my live heroku server as well.

@raja-chaudhary unfortunately that's a risk-weight analysis you need to do yourself, no one here can give you the answer to that. Just try on another test instance and see if it works.
It's easy if you have a staging environment ;)

On Windows who can do this on CMD using set NODE_OPTIONS=--openssl-legacy-provider

It's not work in Windows cmd.
Thes help for me:

"scripts": {
    "serve": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service serve",
    "build": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service build",
    "lint": "SET NODE_OPTIONS=--openssl-legacy-provider && vue-cli-service lint"
  },

Same issue with me, solved by doing this: unistall node.js. Install node v16.13.2  with additional components. Now again run npm run serve project will open on http://localhost:8080/

SET NODE_OPTIONS=--openssl-legacy-provider

It worked, I just had to change SET to export on mac

Thanks, @Voucik, I used "SET NODE_OPTIONS "， it was Done for me

not working yet

Impossible to serve with Node.js v18.14.1

export NODE_OPTIONS=--openssl-legacy-provider

Where to add this line?

export NODE_OPTIONS=--openssl-legacy-provider

Where to add this line?

@leolux in the package.json to the build scripts.

Using Docker, I had to add
ENV NODE_OPTIONS=--openssl-legacy-provider

in my Dockerfile

Nuxt being deployed on Elastic BeanStalk. I needed to create a predeploy hook with the flag to get it to run. package.json scripts update did not work for me.
.platform > hooks > predeploy > 01_build.sh

#!/bin/bash
export NODE_OPTIONS=--openssl-legacy-provider
npm run build

what voucik has said helped me
we have to set the options mentioned by him/her in package.json file of vuejs


TypeScript language server exited with error.Error message is : write EPIPE

Don't know why this issue was closed as it still happens

Confirm, I've got 5 instances of vscode open, and got a this error

If you're still seeing this, then open a new issue. Be sure to fill in the issue template and as much info as you can to reproduce it


ASP.NET Core Kestrel on Linux never prompts for client certificate

I have an ASP.NET Core 1.1 application set up to use Https and require client certificates:

I'm running the application on Linux.
If I change ClientCertificateMode to "AllowCertificates", then everything works fine, but the browser never prompts for a client cert.
With "RequireCertificate" set, I still don't get prompted by the browser for a certificate, and I get the two exceptions below (both repeated four times) on the server side and no response returned the the browser:
Microsoft.AspNetCore.Server.Kestrel:Error: ConnectionFilter.OnConnection
System.AggregateException: One or more errors occurred. (Authentication failed because the remote party has closed the transport stream.) ---> System.IO.IOException: Authentication failed because the remote party has closed the transport stream. at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.PartialFrameCallback(AsyncProtocolRequest asyncRequest) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Net.Security.SslState.InternalEndProcessAuthentication(LazyAsyncResult lazyResult) at System.Net.Security.SslState.EndProcessAuthentication(IAsyncResult result) at System.Net.Security.SslStream.EndAuthenticateAsServer(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.AspNetCore.Server.Kestrel.Https.HttpsConnectionFilter.d__3.MoveNext() --- End of inner exception stack trace --- ---> (Inner Exception #0) System.IO.IOException: Authentication failed because the remote party has closed the transport stream. at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.PartialFrameCallback(AsyncProtocolRequest asyncRequest) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Net.Security.SslState.InternalEndProcessAuthentication(LazyAsyncResult lazyResult) at System.Net.Security.SslState.EndProcessAuthentication(IAsyncResult result) at System.Net.Security.SslStream.EndAuthenticateAsServer(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.AspNetCore.Server.Kestrel.Https.HttpsConnectionFilter.d__3.MoveNext()<---
Microsoft.AspNetCore.Server.Kestrel:Error: ConnectionFilter.OnConnection
System.AggregateException: One or more errors occurred. (The remote certificate is invalid according to the validation procedure.) ---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid according to the validation procedure. at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Net.Security.SslState.StartSendAuthResetSignal(ProtocolToken message, AsyncProtocolRequest asyncRequest, ExceptionDispatchInfo exception) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.PartialFrameCallback(AsyncProtocolRequest asyncRequest) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Net.Security.SslState.InternalEndProcessAuthentication(LazyAsyncResult lazyResult) at System.Net.Security.SslState.EndProcessAuthentication(IAsyncResult result) at System.Net.Security.SslStream.EndAuthenticateAsServer(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.AspNetCore.Server.Kestrel.Https.HttpsConnectionFilter.d__3.MoveNext() --- End of inner exception stack trace --- ---> (Inner Exception #0) System.Security.Authentication.AuthenticationException: The remote certificate is invalid according to the validation procedure. at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Net.Security.SslState.StartSendAuthResetSignal(ProtocolToken message, AsyncProtocolRequest asyncRequest, ExceptionDispatchInfo exception) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest) at System.Net.Security.SslState.PartialFrameCallback(AsyncProtocolRequest asyncRequest) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Net.Security.SslState.InternalEndProcessAuthentication(LazyAsyncResult lazyResult) at System.Net.Security.SslState.EndProcessAuthentication(IAsyncResult result) at System.Net.Security.SslStream.EndAuthenticateAsServer(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.AspNetCore.Server.Kestrel.Https.HttpsConnectionFilter.d__3.MoveNext()<---

I've spent about days trying different things and Googling around, but I can't seem to figure out what the core cause of the issue is, so thought I'd check if anyone over here has an idea.

I see you're calling UseIISIntegration. Does that mean you're running this behind IIS?

On Windows we are running behind IIS Express. On Linux, no.

I tried removing that line to see if it was affecting something, and now I get this error:
info: Microsoft.AspNetCore.Server.Kestrel[17]
Connection id "0HL4HBCV1BOC0" bad request data: "Invalid request line: <0x16><0x03><0x01><0x00><0xD0><0x01><0x00><0x00><0xCC><0x03><0x03>0<0xBA><0x0B><0xCB><0x1A>1<0xFE><0x1F><0x0A>"
Microsoft.AspNetCore.Server.Kestrel.BadHttpRequestException: Invalid request line: <0x16><0x03><0x01><0x00><0xD0><0x01><0x00><0x00><0xCC><0x03><0x03>0<0xBA><0x0B><0xCB><0x1A>1<0xFE><0x1F><0x0A>
Microsoft.AspNetCore.Server.Kestrel:Information: Connection id "0HL4HBCV1BOC0" bad request data: "Invalid request line: <0x16><0x03><0x01><0x00><0xD0><0x01><0x00><0x00><0xCC><0x03><0x03>0<0xBA><0x0B><0xCB><0x1A>1<0xFE><0x1F><0x0A>"
Microsoft.AspNetCore.Server.Kestrel.BadHttpRequestException: Invalid request line: <0x16><0x03><0x01><0x00><0xD0><0x01><0x00><0x00><0xCC><0x03><0x03>0<0xBA><0x0B><0xCB><0x1A>1<0xFE><0x1F><0x0A>

@jceddy Did you figure out what the issue is? Any more details?

No...there doesn't seem to be a way to tell Kestrel which certificate authorities to accept (i.e. to prompt for in the browser). I'm completely running behind NGINX/IIS proxies now, which are handling the SSL interaction with the client for me and forwarding all traffic to Kestrel over HTTP.

Assigning to @halter73 to investigate (and add a test covering this scenario.)

@halter73 / @muratg - what action is required here for 2.0.0?

I think we can move this out. @halter73 thoughts?

In my opinion, this is not resolved. Kestrel in client certificate validation is not worked properly. Of course, you can move this functionality to nginx/IIS but is it the best way?

Moving to 2.1 due to time constraints. @halter73 if you could get it in very quickly, we can bring this back.

@stephentoub Any thoughts if this is an issue with SslStream?

Any thoughts if this is an issue with SslStream?

cc: @bartonjs, @Priya91

Are we sure it is just a linux issue? The problem is most likely that there is no way currently to tell SSLStream what cert authorities to accept. It needs to know so it can send the extension to the client this prompting the cert send if there is one matching. It might just be a matter of èxposing this option on the SSLStream wrapper for Kestrel?

On SslStream server side, if we expect remote cert, then we use the CA lists provided by the function X509_get_default_cert_dir() for system store and local user store under ~/dotnet/cryptography/, and sets the list of CAs sent to the client when requesting a client certificate with SSL_CTX_set_client_CA_list. If the CA you want is not getting sent, please ensure to install it in one of the mentioned locations.

I investigate this a bit more, and I think that the main issue is here:
https://github.com/dotnet/corefx/blob/0fd3d2c5bcb1a83e7ebd8025e4810e11e231ce03/src/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs#L323
The problem is that it adds all the local and user certs by default, and on the Windows side, it doesn't add anything.
Sending an empty list on SSL client cert basically means: "gimme what you got", while a list limits that.
It seems to be that sending the list (which in our tests http://issues.hibernatingrhinos.com/issue/RavenDB-8524) includes hundreds of entries is not what you want to do.
This is called here:
https://github.com/dotnet/corefx/blob/0fd3d2c5bcb1a83e7ebd8025e4810e11e231ce03/src/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs#L97
This is a reals tumbling block for us. Our situation calls for the user to use any client cert and the server side will handle the validation. However, with this logic on Linux, the admin is now forced into a lot of running around and managing certs that we would really wish to avoid.
Allow us to specify it would be much better, yes. Even if we need to write special code for Linux / Windows for this case, but right now this seems to be handled way too deep in the stack for us to have any sort of access to it.

cc @bartonjs

If we're not behaving the same on all platforms then that'd (probably) be a bug.  If SslStream on Windows stopped sending the CA list intentionally then Linux should be changed (and macOS evaluated).  If it's that Windows made a change in newer versions of Windows then we need to decide what we want.  (The "probably" is because if it's nuanced in Windows we may have a hard time forming an opinion on the other platforms, and macOS may or may not expose any part of this as an option)
If all the platforms support an explicit list of string/X500DistinguishedName/etc, I could certainly get behind user control.

External: https://github.com/dotnet/corefx/issues/23938

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Main screen hard to read when using Dark Theme

Using ProDarkThemePack -- OpenDark looks a bit better, but the gray color still doesn't show up very well.

Sub pages look a bit better

All end mill images could use more contrast or something.

I added some logic to improve contrast in dark themes, but it seems that the ProDark theme is simply broken and overwrites this. In other words, it styles things that just shouldn't be styled - even though I explicitly assigned the text color to each of the labels, the color is still not used when that theme is active.
It looks like this cannot be fixed in BTL - or if anyone knows how please provide a patch.

Here's what the main screen looks like in OpenDark

I now understand theming of FreeCAD better than when the issue was opened: This is actually not something BTL can or should control.
In other words, such bugs need to be reported to the theme author instead - I cannot fix it.


Feature Request - Hyprbars: Show only on floating windows

An option to only show title bars on floating windows would be a cool addition to manage floating windows while keeping the tiled ones unchanged.

I have already implemented a rough working version of this but needs some polishing before being merged, it meets my needs so I've been lazy. https://github.com/snehrbass/sn-hyprland-plugins/tree/sn-win-filter/hyprbars

I have already implemented a rough working version of this but needs some polishing before being merged, it meets my needs so I've been lazy. https://github.com/snehrbass/sn-hyprland-plugins/tree/sn-win-filter/hyprbars

Nice! I'm gonna try right away

I have already implemented a rough working version of this but needs some polishing before being merged, it meets my needs so I've been lazy. https://github.com/snehrbass/sn-hyprland-plugins/tree/sn-win-filter/hyprbars

I've noticed a weird behavior that u probably already know:
When window is tiled and bar's hidden, clicking & dragging on the top border acts as if the titlebar is there and drag the window around.

@nehrbash is this closer to being merged?

Essential feature, I hope this gets merged soon

By extension, can the inverse of this be applied as well? No hyprbar on floating windows so that popups, splashscreens and notifications don't have them?

For those still looking, now writing windowrulev2 = plugin:hyprbars:nobar, float:0 in your configuration does exactly what the original feature request asked for.

Thats not working. The rule should be windowrulev2 = plugin:hyprbars:nobar,floating:0


Disable the "Zip Slip Symlink exploit" check when using the --explode flag in the 'jf rt download' command

We have a use case where symlinks are commonly used when deploying archives to Artifactory. When downloading that archive with the --explode flag.
To reproduce this you can create a symlink inside a folder
ln -s Some_Path_location Symlink-Name
Here is an example of a folder being uploaded to Artifactory as an archive.
$ tree
.
└── testdir
├── emptydir
├── link-test-tmp4l1d9p6d
├── afolder
│   └── common
│       └── tmp4l1d330p6d.txt
└── rpm_verify -> ../../trilead-api.hpi
jf rt u "**" example-repo-local/test.zip --flat="false" --symlinks="True" --archive zip
Then if you attempt to download it you will see the error in the logs.
jf rt download example-repo-local/test.zip --explode --threads 2 --split-count=0
[Warn] [Thread 1] (Attempt 1) - Failure occurred while downloading <ART_URL>/artifactory/example-repo-local/test.zip: walking rpm_verify: illegal link path in archive: '../../trilead-api.hpi'. To prevent Zip Slip Symlink exploit, the path can't lead to an entry outside '/Users/derekp/testdir/downloads/'
This was attempted on JFCLI version 2.46.2.
Describe the solution you'd like to see
I would like to be able to disable this check on symlinks and allow the extraction of the archive to continue.
Possibly some sort of flag that we can set to true i.e. --disable-explode-symlink-check=true

@derekp This functionality has been available since version 2.37.0 in https://github.com/jfrog/jfrog-cli/pull/1899.
If you want to skip the inspection of archives, you can utilize the --bypass-archive-inspection option like this:
jf rt dl <source> <target> --explode --bypass-archive-inspection.
However, I would strongly advise against using this flag in a production environment.
For a complete list of available flags for downloading, you can run jf rt dl -h.


enter vehicle from the other side

Hello there,
The character can enter the vehicle from the the other side. I've tried with a method closestSeatToEnter() to check which one between driver/passenger seat is the closest from the character, but it wasn't stable at all. I've kept this method commented, just in case.
It doesn't have animation or transform that transfer him to the driver seat (GTA-style), which is a problem, but I thought it would be a starting point.

First off, I really appreciate you making a PR, but I'm afraid I want to approach this differently.

I wanted to find the closest seat right here, right when you press the F key:
https://github.com/swift502/Sketchbook/blob/967dcf164394f55e7966dd5d064d880f5f720bc8/src/ts/characters/Character.ts#L633
We'll also need to find the closest entry point of the seat (e.g. airplane can be climbed into from both sides)
I actually think the "transfer to other seat" animation is present in the animations list, but we still need to create a "transfer left" and "transfer right" character states which will play those animations and switch to and from other character states.
The seat points will need additional Blender custom properites... something like "neighboring seat", or "connected seat" which will point to any seats you can transfer to.

You added a this.passengerSeat property, and I wouldn't probably add that myself. there should always be only one targetSeat, the one towards which you're running to. And I intended for it to be selected when you press the F key like I mentioned earlier.
Tell me what you think. I think I have a very particular idea on how to go about this. But it will require adding character states, modyfying the car model in Blender, then parsing new custom properties and other stuff.
Tell me if you feel up to the task, but it's a lot of undocumented things that I know how to do just because I've done them already...

Ok! I wasn't sure how to implement this, you've clarified a lot. Like you said, maybe it would be better if you do it, as you did it already ^^. I forgot that a lot was made on Blender too

I'll focus on implementing this myself now. 👌


[BACKLOG-3294] - Setting parameters in transformation (connected to DI Server) through exception

I wasn't able to figure out how to prevent call of FocusListener when items disposed, so  I just add isDisposed() check.
@mdamour1976  please review.

I believe this was fixed by my commit yesterday, but a little extra protection can't hurt.


WIP: Multisite compatibility

This PR ensures that the Airstory plugin works in a WordPress multisite scenario.
User tokens, initialization vectors, and Airstory profile data should be stored once per user, with connections created for each site in the network. As a result, we're switching from *_user_meta() to *_user_option(), which has better multisite support.

This is finally ready for review.
Major changes:

Replaced instances of *_user_meta() with *_user_option(), which has multisite support (all profile data is stored globally and will be merged into a single key in #19, while connections end up with keys like "wp_2__airstory_target").
Introduced Settings\get_available_blogs(), which retrieves all of the blogs in a network that the user is a member of, then filters it down to those where the user has the edit_posts capability (e.g. "Contributor" or higher in stock installations).
Introduced Connection\set_connected_blogs(), which will loop through all of the available blogs for the user (via Settings\get_available_blogs()) and compare them to a list of blog IDs; those in the array will have connections established, while existing connections not in the list will be removed.

Once this PR gets merged, I'll update #19 and it'll be ready for code review as well.


Add native support for IndiePaper

There should be a native way to “save articles for later”. Right now this really can only use IndiePaper but in the future maybe it could support different services.
Together is also going to add support for IndiePaper: https://github.com/cleverdevil/together/issues/70

Aperture and Micro.blog both support IndieAuth for their "Channel"/"Save Later" Micropub endpoints. So Indigenous can use IndieAuth to get the token for the Save Later channel, and then pass that token to IndiePaper when needed

This is integrated with #100

Based on the discussion here: https://github.com/EdwardHinkle/indigenous-ios/issues/100#issuecomment-404193812
I'm going to close this issue and consider Save for Later feature resolved through the Share Sheet and the IndiePaper app.


Fix a couple of the DEC Special Graphics characters

Summary of the Pull Request
Corrects the 0x5f code point in the DEC Special Graphics character set, which is meant to map to a blank glyph rather than an underscore. and updates the 0x60 code point to map to a "black diamond suite" glyph, rather than the "black diamond" glyph, since the latter currently renders as a double width character.
PR Checklist

[x] Closes #2049
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #2049

Detailed Description of the Pull Request / Additional comments
The was mostly a matter of updating the s_rgDECSpecialGraphicsTranslations table in the TerminalOutput class, but also required a change in the TranslateKey method, to make sure the 0x5f code point was included in the range of translatable characters.
I've also made a few cosmetic changes to the source, fixing the comments on the translation table to match the DEC documentation (a couple of them were not quite right), and tidying up the case of the hex values in the table, so they're all consistently lowercase now.
The latter changes have been committed separately, so they're easy enough to revert if there are any objections to including them in this PR.
Validation Steps Performed
I've tested manually with Vttest's Test of character sets, making sure the two code points are mapped as expected, and the diamond glyph doesn't break the layout by being too wide.

@msftbot make sure @zadjii-msft signs off

Actually, nevermind.

@msftbot forget everything I just told you

This went out for conhost in insider build 19002! Thanks :smile:


RDK-32936 : SystemServices::requestReboot() will now use IARM_BUS_PWR…

…MGR_API_Reboot
Reason for change: all reboots will now go via pwrmgr, which
implements IARM_BUS_PWRMGR_API_Reboot. This give pwrmgr an opportunity
to set up things like frontpanel lights, splashscreen in a way that
meets product requirements. Note that the code that generates
onRebootRequest event has been removed from this function. This event
will be generated downstream by pwrmgr instead.
Test Procedure: trigger reboot via
SystemServices::requestSystemReboot(), verify that device reboots.
Risks: low
Signed-off-by: csojan<EMAIL_ADDRESS>

@anand-ky Please do not merge this until https://gerrit.teamccp.com/#/q/topic:coldboot_cr_stable2+(status:open+OR+status:merged) is merged in stable2, as there is a build dependency.
Thanks,
Chaithen

Closing the pull request. Will raise another one including another change to notify power manager events.


AO not returning result

Hi there.
I tried using ta.ao(high, low) but nothing is returned. I can get data on the same dataset from ta.rsi but not .ao, everything is undefined. Why? Can you explain?
Also I wonder why RSI is quite off from how for example the TMA v2 indicator or VMV cipher b (or any tradingview indicator really) calculates it....
Any help is greatly appreciated.

ok nvm it's because I used the normalized and the index is different.


is it capable to get http stream?

Hello,
I need to get a input stream from "http://<IP_ADDRESS>:8092/mainstream". As far as I see, I cant get stream in with video-viewer with combinations of methods and compression options.
Opencv can do it, I need to use video-viewer.
Best

@gyillikci my best suggestion is to see how OpenCV does it - if it's using GStreamer which pipeline does it use and with what source elements for capturing over HTTP.  Then modify the GStreamer pipeline in jetson-inference/utils/codec/gstDecoder.cpp to add that element for HTTP


angular-cli warnings after updating to beta

I'm using angular-cli to serve my app. when I run 'ng serve' it returns the following errors:
WARNING in<EMAIL_ADDRESS>64:4 export 'ProjectionModule' was not found in './core/index'

WARNING in<EMAIL_ADDRESS>89:16 export 'ProjectionModule' was not found in './core/index'

WARNING in<EMAIL_ADDRESS>21:75 export 'Platform' was not found in '../core'

And in the browser console:
Uncaught TypeError: Cannot read property 'prototype' of undefined
    at __extends (snack-bar-container.js:4)
    at snack-bar-container.js:28
    at Object.<anonymous> (snack-bar-container.js:122)
    at __webpack_require__ (bootstrap e22c42d…:52)
    at Object.<anonymous> (snack-bar-ref.js:70)
    at __webpack_require__ (bootstrap e22c42d…:52)
    at Object.<anonymous> (menu.js:40)
    at __webpack_require__ (bootstrap e22c42d…:52)
    at Object.<anonymous> (ripple.js:295)
    at __webpack_require__ (bootstrap e22c42d…:52)

@RickyGeek Try to delete your node_modules folder and reinstall it.

It didn't work

Are you using Webpack 2? If so, make sure you run on rc.3

I believe this is obsolete; we use the latest material version and angular-cli for material.angular.io and haven't encountered any issues.

I am having a similar issue but using systemjs
Note #4256
Looking deeper this is also a problem at __extends
Using
Angular 4.0.3
Material 2.0.0-beta.3
Systemjs 0.20.12
Rxjs 5.3.0
NOT USING WEBPACK, USING SYSTEMJS


Create ability to read mock response from file.

Create ability to read mock response from file.
Current interface vision is following:
dio..onGet(
     "path",
     (request) => request.reply(200,
             MockFile("./some.json"),
);```

MockFile() could be loaded by rootBundle, then put file bytes in.
I am working on adding reply data as byte format.


Update references

Get latest version of each bot framework reference and modify code as needed

can't update anything, all possible updates would ruin compatibility with other references. will continue to stay up to date as referenced libraries are updated


Docs Add docs for function random, mod, fmod

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.7 seconds
load time: 432 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221123023322_clickbench_pr_51150.html


[Bug]: Cannot set API version when creating AssistantsPlanner with Azure OpenAI

Language
Javascript/Typescript
Version
latest
Description
The static createAssistant method does have a azureClientOptions parameter to set API version, but AssistantsPlanner constructor does not have a way to set API version, which results in following errors:

Reproduction Steps
1.
2.
3.
...

Hi @corinagum , the issue still exists in v0.7.1, and can be reproduced using the mathBot sample. I take a quick look at it, seems it's because the openai sdk use apiVersion but not api_version. Can you please help confirm and fix it?

@corinagum - Could you please share your inputs on this?


[E2E] Byzantine network simulator environment

Objective
Make LocalNet be able to access arbitrary configurations to spin up any complex network. Nodes should be able to be fed arbitrary commands to act as different kinds of actors in the system. This should be plumbed with metrics for performance monitoring.
Origin Document
#466 specifically cut network simulation out of scope. This ticket addresses that scope to keep it tightly defined and well-documented.
Goals

Maintain E2E suite passing
Smoothly integrate with DevNet
Gather metrics for performance monitoring

Deliverable

[ ] The ability to provision networks of arbitrary complexity with arbitrary node behaviour.

Non-goals / Non-deliverables

Change how LocalNet fundamentally works
Break DevNet integration

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @dylanlott

@dylanlott I made some NITs to the issue description but was also hoping you clarify the goals & deliverables, perhaps with an example?
It's unclear to me exactly what the deliverable here is? New tooling? Documentation? Infrastructure? Should @okdas be a co-owner?

@Olshansk I'm spending time today shaping the actual deliverables for this issue based on my current experiments with LocalNet & Tilt. I think it's a good idea to make @okdas a co-owner on this, since it will be important to keep this in sync with DevNet as well as LocalNet.

Hey @dylanlott! Trying to finesse this parent ticket and identify any child tickets that are required. Reading the proposed implementation here, these are potential tickets I noted that could live under the "deliverables" section of this ticket. Wdyt?

Extend Debug CLI with new commands to control Byzantine actors
Create Helm charts and Kubernetes manifests for Byzantine nodes
Implement Chaos testing integration (e.g., using Chaos Mesh)
Develop a mechanism for cycling nodes on and off to simulate leaving and joining the network (?)

That looks good for deliverables, yes! The ticket might also want to mention #718 as possibly supporting some of these deliverables.

That would be great! Tysm @dylanlott I'll get started on those smaller tickets and add the links here.


Failure building

maxpro:states-language-cadence maxim$ make
rm -fR "bin/*"
rm -fR "gen/*"
go build -mod vendor -o bin  ./...
build go.uber.org/cadence/activity: cannot load go.uber.org/cadence/activity: open /Users/maxim/cadence/states-language-cadence/vendor/go.uber.org/cadence/activity: no such file or directory
build go.uber.org/cadence/workflow: cannot load go.uber.org/cadence/workflow: open /Users/maxim/cadence/states-language-cadence/vendor/go.uber.org/cadence/workflow: no such file or directory
build go.uber.org/cadence/worker: cannot load go.uber.org/cadence/worker: open /Users/maxim/cadence/states-language-cadence/vendor/go.uber.org/cadence/worker: no such file or directory
build github.com/joho/godotenv: cannot load github.com/joho/godotenv: open /Users/maxim/cadence/states-language-cadence/vendor/github.com/joho/godotenv: no such file or directory
build go.uber.org/zap: cannot load go.uber.org/zap: open /Users/maxim/cadence/states-language-cadence/vendor/go.uber.org/zap: no such file or directory
make: *** [build-all] Error 1

Im running macOS Mojave 10.14.6

Running go mod vendor before make fixes it.

Also had to install the linter:
brew install golangci/tap/golangci-lint


Update to Assertion logging for riscvOVPsim

Also updated riscvOVPsim

this addresses #110 by providing a command line variable RISCV_ASSERT=<0-or-1>


Casdoor Idp communicates with SAC through SAML

Good evening, help to follow up, thank you!

Background of the problem

The same Casdoor Idp SAML configuration has no problem connecting to gosaml2
Similarly, an error occurs when the Casdoor Idp SAML configuration connects to the SAC

Even SAC's error description

The following error message is displayed when Compress SAML Response is enabled
Protocol message signature failed signature pre-validation
The following error message is displayed when Compress SAML Response is disabled
Encountered error parsing message into its DOM representation

Problem progression (Possible cause)

You can connect to SAC from a third party IDAAS Authing

The only reason between them to be verified
Casdoor：The SAC requests a SAMLResponse through get
Authing：The Authing post SAMLResponse to the SAC

Thanks.

@fearless87 Casdoor now supports SAML POST too, update to latest version to try it. Also see docs: https://casdoor.org/docs/how-to-connect/saml/overview#configuration-in-casdoor-idp


iwara.tv is not working anymore

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.07.10. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.07.10

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[x] Other

Downloading of videos from iwara.tv is not working anymore.
The last time youtube-dl has worked with that site is 2018-07-18.
youtube-dl --version
2018.07.10

youtube-dl https://www.iwara.tv/videos/daek6sze7gtkemzex
[Iwara] daek6sze7gtkemzex: Downloading webpage
[Iwara] daek6sze7gtkemzex: Downloading JSON metadata
ERROR: unable to download video data: HTTP Error 418:

The modified extractor posted by user dstftw above doesn't fix it for me.
I also tried AlexAplin's modified iwara extractor (https://github.com/rg3/youtube-dl/pull/16741/commits/d26a533272c55957edcb13163fbe91788769b1b3), but it doesn't work anymore, either.
Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.07.21. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2018.07.21

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones
[X] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Full verbose output:

C:\Users\USERNAME>py -m youtube_dl -o "F:/HT/HT/VID/youtube-dl_automatic/iwara/%(uploader)s/%(upload_date)s --- %(id)s --- %(uploader)s --- %(title)s.%(ext)s" --batch-file="F:/HT/HT/VID/youtube-dl_automatic/dl_list.txt" -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-o', 'F:/HT/HT/VID/youtube-dl_automatic/iwara/%(uploader)s/%(upload_date)s --- %(id)s --- %(uploader)s --- %(title)s.%(ext)s', '--batch-file=F:/HT/HT/VID/youtube-dl_automatic/dl_list.txt', '-v']
[debug] Batch file urls: ['https://ecchi.iwara.tv/videos/b1mg6c6l3f36vold', 'https://ecchi.iwara.tv/videos/yjmbxsqaauoz245g', 'https://ecchi.iwara.tv/videos/ejoa3cb9m3tkv5kza', 'https://ecchi.iwara.tv/videos/k0we2hqkrwszrb1bp?language=en', 'https://ecchi.iwara.tv/videos/bbr7otwpvxf31b07g?language=en', 'https://ecchi.iwara.tv/videos/7kaqqurkdqcmgp9ng?language=en', 'https://ecchi.iwara.tv/videos/5zm8qtpvy3iw427nm?language=en', 'https://ecchi.iwara.tv/videos/k0zpqfqkrwszr0qmz?language=en', 'https://ecchi.iwara.tv/videos/elje6ubneqtmmveey?language=en', 'https://ecchi.iwara.tv/videos/my8m1ibgzgt88jxaq?language=en', 'https://ecchi.iwara.tv/videos/wyw2rugyvjcqq9zqb?language=en', 'https://ecchi.iwara.tv/videos/woqjpuvyvjsyyzblg?language=en', 'https://ecchi.iwara.tv/videos/e6grqsb4rktkk9vgm?language=en', 'https://ecchi.iwara.tv/videos/1qppmcz102u3308rp?language=en', 'https://ecchi.iwara.tv/videos/bpddzh0lqwsll8rp8?language=en', 'https://ecchi.iwara.tv/videos/4rpd8upo41iyywel5?language=en', 'https://ecchi.iwara.tv/videos/7kqxbirkdqcmmbggq?language=en', 'https://ecchi.iwara.tv/videos/dnymbfdgnqck7ovlr?language=en', 'https://ecchi.iwara.tv/videos/xrvertkaglcwnzoq1?language=en', 'https://ecchi.iwara.tv/videos/yovxvckj7qcog180w?language=en', 'https://ecchi.iwara.tv/videos/1ko8muz102u3yzywp?language=en', 'https://ecchi.iwara.tv/videos/z4oxgixyv1fkoe5zb?language=en', 'https://ecchi.iwara.tv/videos/v4krku68mxter9g1b?language=en', 'https://ecchi.iwara.tv/videos/pkrmyhzbk9togmq9z?language=en', 'https://ecchi.iwara.tv/videos/lb300ulq49t8brob9?language=en', 'https://ecchi.iwara.tv/videos/baao3swpvxf3j4amz?language=en', 'https://ecchi.iwara.tv/videos/owrovcaeebs6oj5mz?language=en', 'https://ecchi.iwara.tv/videos/0z88efeqo7szgqb0z?language=en', 'https://ecchi.iwara.tv/videos/jg1k9ugkgpuwlmyld?language=en', 'https://ecchi.iwara.tv/videos/1z85bcz5jef3e11rm?language=en', 'https://ecchi.iwara.tv/videos/g3yeyhrww3h7va1rn?language=en', 'https://ecchi.iwara.tv/videos/z2mmjur5bikkear4?language=en', 'https://ecchi.iwara.tv/videos/kegr1fz3gwhz3p1wv?language=en', 'https://ecchi.iwara.tv/videos/x1vz1u2pvuwvmeym?language=en', 'https://ecchi.iwara.tv/videos/jj1qmizgmyce03vej?language=en', 'https://ecchi.iwara.tv/videos/mlmk2crlrio7azol?language=en', 'https://ecchi.iwara.tv/videos/wgvgotnkgtyopm40?language=en', 'https://ecchi.iwara.tv/videos/gjlk7h212sopbq2w?language=en', 'https://ecchi.iwara.tv/videos/gjlkgs212sopbq0m?language=en', 'https://ecchi.iwara.tv/videos/ljmg1hjyjfwjed9l?language=en', 'https://ecchi.iwara.tv/videos/q9vj1hjqrbtr2wkox?language=en', 'https://ecchi.iwara.tv/videos/yjmrnt4p8fozaxjx?language=en', 'https://ecchi.iwara.tv/videos/ljmnqsly8oswjemym?language=en', 'https://ecchi.iwara.tv/videos/o5mqkc6lbxu1gjqx6?language=en', 'https://ecchi.iwara.tv/videos/kgmm5tzowwhqy32va?language=en', 'https://ecchi.iwara.tv/videos/jg1y2czzxyhwlzq3v?language=en', 'https://ecchi.iwara.tv/videos/z2m5wi39wyfkkq9w0?language=en', 'https://ecchi.iwara.tv/videos/9dyontqyeaiz2jn24?language=en', 'https://ecchi.iwara.tv/videos/o5mr1h6wri1gjjz0?language=en', 'https://ecchi.iwara.tv/videos/owgwqsrz51h6oveye?language=en', 'https://ecchi.iwara.tv/videos/g3y23sajaf7v0o0l?language=en', 'https://ecchi.iwara.tv/videos/rrr2jf90r6soqv2nm?language=en', 'https://ecchi.iwara.tv/videos/1zmbxslbvh3ea5b9?language=en', 'https://ecchi.iwara.tv/videos/1zmbmfbbzi3ea5vb?language=en', 'https://ecchi.iwara.tv/videos/60qvnirrzvuo1zll2?language=en', 'https://ecchi.iwara.tv/videos/9d4peuwjmpiz2qq57?language=en', 'https://ecchi.iwara.tv/videos/q9ywrcwjlsr2kzdy?language=en', 'https://ecchi.iwara.tv/videos/gj6djcka7copd4bv?language=en', 'https://ecchi.iwara.tv/videos/5q2johbbdiw1gzyn?language=en', 'https://ecchi.iwara.tv/videos/ej2y3hbovwckvaqo1?language=en', 'https://ecchi.iwara.tv/videos/4oax3fdl3hy0kloo?language=en', 'https://ecchi.iwara.tv/videos/q9ymvsjbqmsr2kbzl?language=en', 'https://ecchi.iwara.tv/videos/706g9tll3wfmw2m6z?language=en', 'https://ecchi.iwara.tv/videos/wgzaasz1vsyoabyq?language=en', 'https://ecchi.iwara.tv/videos/g3kgrtr2xu7vj8ew?language=en', 'https://ecchi.iwara.tv/videos/3jw92trk7u45kevm?language=en', 'https://ecchi.iwara.tv/videos/2xnqzfm6asq7kpkw?language=en', 'https://ecchi.iwara.tv/videos/60qw0s8wo1io1za2e?language=en', 'https://ecchi.iwara.tv/videos/60qmrsge6fo1ze8j?language=en', 'https://ecchi.iwara.tv/videos/o5p7gswn7s1gqqpg?language=en', 'https://ecchi.iwara.tv/videos/qe872tzpkeul8qvlj?language=en', 'https://ecchi.iwara.tv/videos/4oa6ycdzzafy0omvq?language=en', 'https://ecchi.iwara.tv/videos/o5pbph6gyof1gyyjb?language=en', 'https://ecchi.iwara.tv/videos/5q25dcjmwhw1qgdr?language=en', 'https://ecchi.iwara.tv/videos/706b1ieaaksmwzdzy?language=en', 'https://ecchi.iwara.tv/videos/x1zqziyklquwvwrg7?language=en', 'https://ecchi.iwara.tv/videos/bjrbouym1dhl1v2wq?language=en', 'https://ecchi.iwara.tv/videos/y6zjqikd2of0od8wj?language=en', 'https://ecchi.iwara.tv/videos/aombbipgqu7a1zrj?language=en', 'https://ecchi.iwara.tv/videos/ljw7mily6bhwjyy5y?language=en', 'https://ecchi.iwara.tv/videos/80jpef34w7flmvmyj?language=en', 'https://ecchi.iwara.tv/videos/y6zqoudbah0odem9?language=en', 'https://ecchi.iwara.tv/videos/bjraqc0gklil1vz1p?language=en', 'https://ecchi.iwara.tv/videos/9d4apselmcz2lnqb?language=en', 'https://ecchi.iwara.tv/videos/mbjkoirwlzi8pj0pg?language=en', 'https://ecchi.iwara.tv/videos/9d4o1s4oqfz2ljob?language=en', 'https://ecchi.iwara.tv/videos/gj6z3uzmjtop2g18?language=en', 'https://ecchi.iwara.tv/videos/abrk8h68af8rbbar?language=en', 'https://ecchi.iwara.tv/videos/vwkg4ir0yjiek732y?language=en', 'https://ecchi.iwara.tv/videos/y6z8wfm3rc0on75y?language=en', 'https://ecchi.iwara.tv/videos/r0robiyeq4hzx4np5?language=en', 'https://ecchi.iwara.tv/videos/lby2lugvext8ewnw1?language=en', 'https://ecchi.iwara.tv/videos/x1z3osmw3fwvdwko?language=en', 'https://ecchi.iwara.tv/videos/3jwvasqywwu45a4v7?language=en', 'https://ecchi.iwara.tv/videos/jg0w8ug799uwlew4p?language=en', 'https://ecchi.iwara.tv/videos/ml9mjfmoevio7qe3b?language=en', 'https://ecchi.iwara.tv/videos/daemxu5mbikeya03?language=en', 'https://ecchi.iwara.tv/videos/z2xjlslnpckk9wyl?language=en', 'https://ecchi.iwara.tv/videos/jg0mycdnnltwlqqrr?language=en', 'https://ecchi.iwara.tv/videos/1zmeliz3olu3eqqpz?language=en', 'https://ecchi.iwara.tv/videos/2xna2s9w8cq7dg8r?language=en', 'https://ecchi.iwara.tv/videos/o5pw0s6mbzf1gm5a4?language=en', 'https://ecchi.iwara.tv/videos/vwkypcx0ziekagb4?language=en', 'https://ecchi.iwara.tv/videos/z2xv7fx5r4fkk9gwn?language=en', 'https://ecchi.iwara.tv/videos/lby8rcgzrdh8eyyna?language=en', 'https://ecchi.iwara.tv/videos/abr0xi6yeu8r70r2?language=en', 'https://ecchi.iwara.tv/videos/5q2qru1n6cw1zknj?language=en', 'https://ecchi.iwara.tv/videos/ej2xwf7nzqckvp1gg?language=en', 'https://ecchi.iwara.tv/videos/3jw0pt71ot459j2n?language=en', 'https://ecchi.iwara.tv/videos/r0rkrfko15izx8vqz?language=en', 'https://ecchi.iwara.tv/videos/abr8eimjvaf8r7wvk?language=en', 'https://ecchi.iwara.tv/videos/ker15cq086sz3kaqm?language=en', 'https://ecchi.iwara.tv/videos/1zqbmck4zs3eolky?language=en', 'https://ecchi.iwara.tv/videos/y6kvjux3wf0oy30w?language=en', 'https://ecchi.iwara.tv/videos/owqbrurebu6okzvr?language=en', 'https://ecchi.iwara.tv/videos/q9jw3ukjyur2jrjg?language=en', 'https://ecchi.iwara.tv/videos/pk45jtb7bhogeakr?language=en']
[debug] Encodings: locale cp932, fs utf-8, out utf-8, pref cp932
[debug] youtube-dl version 2017.09.24
[debug] Python version 3.6.2 - Windows-10-10.0.15063-SP0
[debug] exe versions: ffmpeg N-90710-gaedbf1640c, ffprobe N-90710-gaedbf1640c
[debug] Proxy map: {}
[Iwara] b1mg6c6l3f36vold: Downloading webpage
[Iwara] b1mg6c6l3f36vold: Downloading JSON metadata
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'http://kokone.iwara.tv/file.php?expire=1532709896&hash=218feef7091e9e0e939acca31e9bd86a5b7f2c97&file=2017%2F03%2F29%2F1490751243_b1mG6C6L3F36vOlD_Source.mp4&op=dl&r=0'
ERROR: unable to download video data: HTTP Error 418:
Traceback (most recent call last):
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\site-packages\youtube_dl\YoutubeDL.py", line 1875, in process_info
    success = dl(filename, info_dict)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\site-packages\youtube_dl\YoutubeDL.py", line 1814, in dl
    return fd.download(name, info)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\site-packages\youtube_dl\downloader\common.py", line 361, in download
    return self.real_download(filename, info_dict)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\site-packages\youtube_dl\downloader\http.py", line 286, in real_download
    establish_connection()
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\site-packages\youtube_dl\downloader\http.py", line 74, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "C:\UsersUSERNAME\AppData\Local\Programs\Python\Python36-32\lib\site-packages\youtube_dl\YoutubeDL.py", line 2178, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 532, in open
    response = meth(req, response)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 570, in error
    return self._call_chain(*args)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 504, in _call_chain
    result = func(*args)
  File "C:\Users\USERNAME\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 418:

...
<end of log>

Example URLs:

Single video: https://www.iwara.tv/videos/woqbjs38viyyz57w
Single video: https://ecchi.iwara.tv/videos/yrjv4uvrmc0vy8j8

Description of your issue, suggested solution and other information
When I try to download any video on iwara.tv, I get an error saying "ERROR: unable to download video data: HTTP Error 418:" (nothing follows the colon) and youtube-dl doesn't download the files. I want to be able to download videos again. Usually, I batch-download them.
It had been working until a ~4 days ago, which coincides with an update to iwara, though the admin didn't specify what was changed. This might just be a coincidence, though.
I'm using Python version 2.7.14 on Windows 10. I tried dstftw's and AlexAplin's modified iwara extractors, too, but it didn't fix the problem.


Use official Plex image?

Just curious if there was a reason you're not using the official Plex docker image at https://github.com/plexinc/pms-docker?

No particular reason, initially it was due to consistency of configuration across the various LSIO containers.


[WIP] Add support to download and run local agents

To support networks that may not have access to CDN the agents
are now downloaded into the rancher/server container. They are
compressed and accessed through the CATTLE_ settings. The default
behavior will now be to use the local agents. If a user wants to
leverage the CDN versions a -e USE_LOCAL_AGENTS=false must be
passed when starting the container.

@ibuildthecloud, here is a first pass at putting the agents inside the server container. This will require a change in Cattle to use the tar.gz files instead of compressing and serving.


[Bug]: Server error not being caught by ErrorBoundary

Which Remix packages are impacted?

[ ] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[ ] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
1.0.6
What version of Node are you using? Minimum supported version is 14.
16.13.1
Steps to Reproduce

Go to https://remix-playground-jon301.vercel.app/demos/params
Click on Param: one , two, then use the browser's prev & next buttons until you get a 500 error
The error is not caught by the ErrorBoundary

https://user-images.githubusercontent.com/122108/146431623-29fd7e4a-2529-42eb-ab87-def58ffdad7d.mp4
Expected Behavior
The server error should be caught by the ErrorBoundary
Actual Behavior
The component is rendered partially (with no data)

Hi! I'm not a bot, but I'm closing out old issues that have long grown stale and are likely not up-to-date with recent versions. Feel free to ping me if this is still an issue and I can reopen.


KAFKA-4241: StreamsConfig doesn't pass through custom consumer and producer properties to ConsumerConfig and ProducerConfig

pass through user-defined consumer and producer properties from StreamsConfig to ConsumerConfig and ProducerConfig.
For example, consumer interceptor support, i.e, consumer.interceptor.classes=SomeClass

@guozhangwang @enothereska @miguno @mjsax
This one was reported on the confluent google group today

One minor comment otherwise LGTM.

Merged to trunk and 0.10.1.


[SPARK-27397][Core] Take care of OpenJ9 JVM in Spark

What changes were proposed in this pull request?
This PR supports OpenJ9 in addition to IBM JDK and OpenJDK in Spark by handling System.getProperty("java.vendor") = "Eclipse OpenJ9".
In inferDefaultMemory() and getKrb5LoginModuleName(), this PR uses non IBM way.
$ ~/jdk-11.0.2+9_openj9-0.12.1/bin/jshell
|  Welcome to JShell -- Version 11.0.2
|  For an introduction type: /help intro

jshell> System.out.println(System.getProperty("java.vendor"))
Eclipse OpenJ9

jshell> System.out.println(System.getProperty("java.vm.info"))
JRE 11 Linux amd64-64-Bit Compressed References 20190204_127 (JIT enabled, AOT enabled)
OpenJ9   - 90dd8cb40
OMR      - d2f4534b
JCL      - 289c70b6844 based on jdk-11.0.2+9

jshell> System.out.println(Class.forName("com.ibm.lang.management.OperatingSystemMXBean").getDeclaredMethod("getTotalPhysicalMemory"))
public abstract long com.ibm.lang.management.OperatingSystemMXBean.getTotalPhysicalMemory()

jshell> System.out.println(Class.forName("com.sun.management.OperatingSystemMXBean").getDeclaredMethod("getTotalPhysicalMemorySize"))
public abstract long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize()

jshell> System.out.println(Class.forName("com.ibm.security.auth.module.Krb5LoginModule"))
|  Exception java.lang.ClassNotFoundException: com.ibm.security.auth.module.Krb5LoginModule
|        at Class.forNameImpl (Native Method)
|        at Class.forName (Class.java:339)
|        at (#1:1)

jshell> System.out.println(Class.forName("com.sun.security.auth.module.Krb5LoginModule"))
class com.sun.security.auth.module.Krb5LoginModule

How was this patch tested?
Existing test suites
Manual testing with OpenJ9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9671/
Test PASSed.

Test build #104339 has started for PR 24308 at commit 96bcfd4.

Test build #104339 has finished for PR 24308 at commit 96bcfd4.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104339/
Test FAILed.

Retest this please

Test build #104342 has started for PR 24308 at commit 96bcfd4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9674/
Test PASSed.

Hi, @kiszk . Could you update How was this patch tested? section? Actually, Jenkins doesn't trigger OpenJ9 here with your PR. Maybe, you want to mention that Manual testing. Pass all tests with OpenJ9?

Test build #104342 has finished for PR 24308 at commit 96bcfd4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104342/
Test PASSed.

Test build #104348 has started for PR 24308 at commit 6265481.

Test build #104348 has finished for PR 24308 at commit 6265481.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104348/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9680/
Test PASSed.

Test build #4696 has started for PR 24308 at commit 6265481.

@kiszk . Although JDK8 doesn't have jshell, we can not test Spark on OpenJ9 JDK11, could you update the PR description with the information from Eclipse OpenJ9 VM (build openj9-0.12.1, JRE 1.8.0 Linux amd64-64-Bit Compressed References 20190205_213 (JIT enabled, AOT enabled)?

Test build #4696 has finished for PR 24308 at commit 6265481.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@dongjoon-hyun Thank you. I will address them on middle or late this week since I am on a business trip this week.

When I came back to home (I leave Mac at home), I realized that this link issue occurs only on Mac.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9903/
Test PASSed.

Test build #104580 has started for PR 24308 at commit 08eb67a.

@dongjoon-hyun I created an issue on OpenJ9 to address a jni link issue.

Test build #104580 has finished for PR 24308 at commit 08eb67a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104580/
Test PASSed.

Merged to master


Cannot start multiple server profiles from the same location.

The servers couldn't be started in the below directory strcture.

Servers
|- wso2iot_1
|- wso2iot_2
|- solr

Merged into the product master.


Typo's in the ReadMe

I have just seen your post on Reddit, It's come at a great time for me as I've just started using Asp.net Core WebApi. I'll be studying your code in detail over the next week or so.
For now I've spotted these typo's in the ReadMe.

In this project were applied the concepts of:

Suggestions for improvements are very welcome and if you find any bugs or have any questions just open an Issue and I'll take a look as soon as possible =)

Great work though, I've starred for future use!

Hello, Timmoth! Thanks for the reporting the typos, I fixed them in this new batch of adjusts.
Any questions, suggestions or bugs found, just open a new issue =)


Implement deep links for Fiat-on-Ramp on Ramp.network

Let us extend the fiat-on-ramp functionality to all the tokens available on Ramp network.

The current implementation takes users to Buy ETH for DAI, USDT etc.
Let us make the Buy  button for:

USDC
USDT
DAI

Hi @justindg If you implement this it should be done in a generic way - if you extend the current way it will lead to a mess.
Suggest you create an XML file with a list of contracts that are supported by Ramp eg
0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48,USDC
0x6b175474e89094c44da98b954eedeac495271d0f,DAI
0xdac17f958d2ee523a2206206994597c13d831ec7,USDT
Then, add a feature (within FunctionButtonBar is ok) to scan this file and add a 'Buy xxx with Ramp'.
Then patch the rest of the code to handle this generic system. After that it'll be easy to add more tokens as they become available.
As an extension can you add the site definition eg
0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48,USDC,Ramp
0x6b175474e89094c44da98b954eedeac495271d0f,DAI,Ramp
0xdac17f958d2ee523a2206206994597c13d831ec7,USDT,Ramp
And then generate the URI intent based on which Fiat on-ramp supplies that token, so that in future we can add new tokens with different on-ramp.

Close completed issue


Document query errors

Objective
Add documentation to Query and QueryState errors in bevy_ecs (QuerySingleError, QueryEntityError, QueryComponentError)
Solution

Change display message for QueryEntityError::QueryDoesNotMatch: this error can also happen when the entity has a component which is filtered out (with Without<C>)
Fix wrong reference in the documentation of Query::get_component and Query::get_component_mut from QueryEntityError to QueryComponentError
Complete the documentation of the three error enum variants.
Add examples for QueryComponentError::MissingReadAccess and QueryComponentError::MissingWriteAccess
Add reference to QueryState in QueryEntityError's documentation.

Migration Guide
Expect QueryEntityError::QueryDoesNotMatch's display message to change? Not sure that counts.

(Just in case, here is the file I used to test the example:)
use bevy::app::App;
use bevy::ecs::{prelude::*, system::QueryComponentError};

#[derive(Component)]
struct OtherComponent;

#[derive(Component)]
struct RequestedComponent;

#[derive(Resource)]
struct SpecificEntity {
    entity: Entity,
}

fn get_missing_read_access_error(query: Query<&RequestedComponent>, res: Res<SpecificEntity>) {
    if let Err(QueryComponentError::MissingReadAccess) = query.get_component::<OtherComponent>(res.entity) {
        println!("query doesn't have read access to OtherComponent");
    }
}

fn get_missing_write_access_error(mut query: Query<&RequestedComponent>, res: Res<SpecificEntity>) {
    if let Err(QueryComponentError::MissingWriteAccess) = query.get_component_mut::<RequestedComponent>(res.entity) {
        println!("query doesn't have write access to RequestedComponent");
    }
}

fn main() {
    App::new()
        .add_startup_system(setup)
        .add_system(get_missing_read_access_error)
        .add_system(get_missing_write_access_error.after(get_missing_read_access_error))
        .run();
}

fn setup(
    mut commands: Commands,
) {
    let entity = commands.spawn((RequestedComponent, OtherComponent)).id();
    commands.insert_resource(SpecificEntity{entity})
}```

Applied rustfmt (sorry I thought it was applied automatically somehow)

@Selene-Amanita it looks like your doc tests are failing: can you fix those up?

I fixed the check-docs check, I think.
I couldn't run cargo miri ("the 'miri' component which provides the command 'cargo-miri' is not available for the 'stable-x86_64-unknown-linux-gnu' toolchain") so hopefully this will work out too.
Btw should I use an assert inside the system in the doc test, to check that this scenario does yield the expected error?

Yeah, I would put an assert inside the doc test: it'll act as both clarification and as an extra layer of safety for our ECS code.

@alice-i-cecile
Okay! I added assert_eq it in 5559ce773a2646dfc22f2f995e91ebe3fda636d4 (I kept the println and expanded it a bit for clarity) but I still have two questions:

cargo fmt doesn't apply formating to tests/examples in doc, right? Should I do something about it?
should I keep bevy_ecs::system::assert_is_system(get_missing_write_access_error);?

cargo fmt doesn't apply formating to tests/examples in doc, right? Should I do something about it?

Mostly we just suffer here :( The tooling for doc tests is really subpar in general, which is a shame because they're very useful. Manually matching it is way more work than it's worth though.

I kept bevy_ecs::system::assert_is_system(get_missing_write_access_error);, should I delete it?

That's fine.

I kept the println! and expanded it a bit for clarity

Great!

I had to derive PartialEq and Debug for RequestedComponent otherwise I would have to make convoluted code

Good choice.
Merging!


⚠ Secret Website 3 has degraded performance

In d2f1755, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 1904 ms

Resolved: Secret Website 3 performance has improved in f909602.