Fix missed CRDs for deploys

What type of PR is this?

/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Fix missed CRDs for deploys

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/cherrypick release-0.4

/cherrypick release-0.5


ARROW-17246: [Packaging][deb][RPM] Don't use system jemalloc

Because system jemalloc can't be used with dlopen(). If system
jemalloc can't used with dlopen(), our shared libraried can't be
loaded as bindings of script languages such as Ruby:
+ ruby -r gi -e 'p GI.load('\''Arrow'\'')'
(null)-WARNING **: Failed to load shared library 'libarrow-glib.so.900' referenced by the typelib:
   /lib64/libjemalloc.so.2: cannot allocate memory in static TLS block

This is caused because system jemalloc isn't built with
--disable-initial-exec-tls.
See also:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951704
https://github.com/jemalloc/jemalloc/issues/1237

@github-actions crossbow submit -g linux

@github-actions crossbow submit -g linux


Failed to initialize Manjaro - Flathub

Description
Since the last update of the application on Manjaro, when it is necessary to start/use the application, it displays the loading screen. Shortly after, it also shows the initial application screen, where the registered connections are displayed. However, a few seconds later, the application is terminated. I have already restarted the computer, reinstalled DBeaver several times, and the issue persists.
DBeaver Version
DBeaver Community 23.1.5
Operating System
Manjaro
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Please, provide the log files. You can find instructions here https://dbeaver.com/docs/wiki/Log-files/.

.metadata.zip

Hi. Could you please send us the fava fatal log files? Here is a how-to: https://github.com/dbeaver/dbeaver/wiki/Log-files#java-fatal-logs

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.


mobile / Nova Wallet -> full screen button in galleryItem

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #8078

Tested
on Android phone with Nova Wallet
on desktop works as before -> no UX change
Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

https://github.com/kodadot/nft-gallery/assets/22791238/a2cab763-7ae7-49d7-8d07-bffaf61cfb6b
Copilot Summary

🤖[deprecated] Generated by Copilot at 505e00f
Enhanced the fullscreen functionality and mobile compatibility of the GalleryItem component. Removed unused code and added type annotations.

🤖[deprecated] Generated by Copilot at 505e00f

GalleryItem shines
Fullscreen fallback and previews
Winter of unused code

@yangwao  fixed

thanks!
pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.48 USD/DOT ~ 3.65 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xa7f7c3208b4244b26b2390543c6cccdafc80b0216252532a3e76ee95aede9a67
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


[FEATURE] Test Page INPUT Field Functionality

Is your feature request related to a problem? Please describe.
PROBLEM 1
When we are giving the test, we sometimes quickly press ENTER key as we have a habit of that in other tasks, but there is no functionality to submit the answer and go to the next question when ENTER key is pressed.
PROBLEM 2
The input tag in the TEST PAGE is not automatically focused when a new question is loaded, this results in irritation as the user needs to click again and again to type the answers into the input field.
Describe the solution you'd like
SOLUTION 1
We can add an event listener to the DONE button on the test page which will run the same function which is run on click, whenever we press ENTER key.
SOLUTION 2
We can put autofocus attribute inside the required HTML input tag of the test page.

This issue has been resolved in this commit


Does Casdoor support redis cluster as a session manager?

I modified the app.conf file and I typed the DNS of the redis cluster. But It seems that casdoor can not write data to redis. It seems connect to the read only node.

@popzones that feature is provided by Beego, the web framework used by Casdoor, plz ask the Beego community: https://github.com/beego/beego

Beego doesn't support cluster mode


AFR NimBLE: Disable RPA feature on ESP port

AFR NimBLE: Disable RPA feature on ESP port
Description

Few integration/functional test failures were observed with RPA feature enabled. The test cases need to be updated to take into account RPA feature. Till the cases are updated, disabling RPA feature.
Change list:

Disable RPA feature in ESP port.
Change own_addr_type in advertisement to public from random.
Configure distribution of LTK & IRK during bonding enable procedure itself. This step will help to mitigate issue observed with bond lost issue and device flash getting repeated entries of the same (RPA enabled) peer device.

I have run AFQP tests with the change and all the AFQP tests passed.
Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks


SUBMARINE-552. [WEB]Implement experiment information charts page.

What is this PR for?
1.Import swimlane/ngx-charts module with version 13.0.1 .
2.Implement experiment information charts page with simulated data for testing swimlane/ngx-charts.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-552
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@liuxunorg  @lleohao  @pingsutw  Please take a look this pr. Thanks :))


LibreCores CI Dev image + Config-as-Code

This pull request adds a Docker image, which close LibreCores CI and Libraries. The purpose of this image is to move the local instance do DockerHub in order to make the demos reproducible.

[x] - Setup full configuration as code for LibreCores CI Dev environment
[x] - Add several reference projects, which would work out of the box on the instance
Later: Switch to Docker Compose in order to spin the entire infrastructure like Modules

Eventually the configuration as code setup may replace the LCCI deployment
Related to #11

Integrating in order to get it in place for the tomorrow's demos. It does not impact the demo instance


Fail with clean exit

Run-in-Roblox failed while apparently giving a clean exit code during CI setup when running the command run-in-roblox --place build.rbxlx --script Tests/Run.server.lua.

Unfortunately I cannot reproduce this. Rerunning the job resulted in expected behavior. If I encounter it again I'll leave more details.

Wrapping back to this issue after several years, I still have no definitive cause for this bug. It happens intermittently and rarely (encountered using github action runners) and every time it has happened, simply re-running the job has resulted in a success.
I've never had it happen outside of CI and there is no discernible difference I've seen in CI logs that would indicate a cause. I think creating a reproduction for this bug is unlikely.


Update README.md with mission statement

Updates the readme to have a mission statement about why this exists.

:+1:

Nice. I should move the API design stuff to here.

:+1:


How to change alt tag shown in the instagram image  on website. Actually i don't like to show alt like this . When it shows in google search result it don't look good

Hi, I want to change alt text data and structure which can appear in the google search result. Current structure: username Instagram image 0 like this which does not look good anywhere. Please help.

This is not possible yet. This would be a feature request so we will consider to implement this in a future release.
Also, the way we would implement it would be defining an alt tag pattern, so the result will be almost the same

Adding onto this thread, not having a usable Alt tag is an accessibility issue. A simple fix for this would be to at least use the image caption as the alt tag. So, the code for the alt tag would become:
+"' alt='"+a[d].node.edge_media_to_caption.edges[0].node.text+"'"+

For images with only hashtags in the text that will be undefined. What I did is setting the caption in the following priority:

image text
image instagram alt
{{tag/username}} image X

Thanks :)


i18n(fr): update integration-guides

Description (required)

Remove astro/client inside code blocks in Integration guides (see #9081)

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
guides/integrations-guide/cloudflare.mdx
Localization changed, will be marked as complete.

fr
guides/integrations-guide/netlify.mdx
Localization changed, will be marked as complete.

fr
guides/integrations-guide/vercel.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Fix typo in detailed PV system design help file

Hello dear SAM team, this fixes a small typo in the Help page for the detailed PV model system design, presumably a copy/paste oversight from the similar GCR text a few lines down.

Got it, thanks @cpaulgilman!  I'll keep that in mind for the future.


Range-aware Port Per Broker with integer configuration

Type of change

Enhancement / new feature

Description
Mitigates #902
This new implementation introduces the concept of Node Id Ranges and enables you to configure multiple such ranges for your virtual cluster. Enabling a deterministic mapping of node ids to proxy ports even when there are large gaps between the ranges.
For example if I configure a virtual cluster with:
nodeStartPort: 9000
nodeIdRanges:
  - name: brokers
    startInclusive: 4
    endExclusive: 6
  - name: controllers
    startInclusive: 1
    endExclusive: 3

Then the ports will be mapped as follows:

node 1 -> port 9000
node 2 -> port 9001
node 4 -> port 9002
node 5 -> port 9003

Why:
Currently there are numerous drawbacks to using the PortPerBroker exposition scheme. If the lowest broker id is N and the highest is M then we must expose M-N ports so that we can deterministically map each node id to a port. So if you have two nodes with ids 100000 and 200000 you need 100000 ports mapped so that we can say startPort+0 is node 100000 and startPort+100000 is node id 200000.
Also with the advent of KRaft we now may have to contend with two distinct and evolving sets of node ids, a controller pool and a broker pool. If there is a significant gap between them we have the same problem as above.
This enables us to represent clusters with highly variable node ids using a more compact set of ports.
Note it still does not solve other issues, like some users regulurly introduce new nodes and remove old ones in their target cluster as part of upgrades.  Leading to eternal growth of node ids. To handle this in a better way we think the Proxy would need to be able to discover the target topology.
This is an alternative to #1210 where we used a mathematical interval notation to represent the range. That implementation brings in the complexity of parsing/regexing and reinventing what Guava has implemented. Maybe we should start with this simpler alternative and could introduce a range String to the RangeSpec later, which should be a small PR on top of the existing code to parse from String -> Range.
This alternative also gives us type safety on the integers through Jackson. The implementation has been simplified to separate the Range as a concept from any idea of indexing the node ids in the range. It borrows the terminology from guava of Range and RangeSet.
The existing PortPerBroker scheme is also refactored to be implemented using the Range aware implementation, treating it as a single-range configuration.
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

Good ideas Keith,
I've updated to the:
nodeStartPort: 9000
nodeIdRanges:
  - name: brokers
    range:
      startInclusive: 4
      endExclusive: 6
  - name: controllers
    range:
       startInclusive: 1
       endExclusive: 3

syntax, I agree it allows us to have flexible configuration per rangeSpec separate from how we define the range
I've converted Range to a record and removed the name knowledge from this pure mathematical part of the code.
I also decided that the RangeSet wasn't really adding enough value since it was just validating the ranges were distinct before they were converted to the offset Map. So I've made the Config class responsible for validating that the ranges are distinct.
Also I added a check that the range names are unique.


Ractive events doesn't work on components

Description of the bug:
I would expect ractive components behave just like any other native elements, but it seems ractive events are not working on components: https://jsfiddle.net/ceremcem/25e5wnv2/1/
Edit
It doesn't work with oninit: this.on... binding either: https://jsfiddle.net/ceremcem/25e5wnv2/2/

Same problem occurs with Ractive-v0.8.8: https://jsfiddle.net/ceremcem/25e5wnv2/5/ .
The "Components currently only support simple events - you cannot include arguments. Sorry!" error is vanished, but Same problem occurs with Ractive-v0.8.8: https://jsfiddle.net/ceremcem/25e5wnv2/5/ .

I am not sure if native DOM events automatically convert to custom events and delegate up as component events. As far as I know, native DOM events and custom events are two different things. I may be wrong though. Thoughts @martypdx @evs-chris ?
However, I do know that you can re-fire the DOM event as a custom event of my-widget. In this case, we fire a custom customclick from a DOM on-click.

MyWidget = Ractive.extend({
	template: "#my-widget"
})

ractive = new Ractive({
  el: "#main-output",
  template: "#main-template",
  data: {
    hello: "world"
  },
  components: {
  	"my-widget": MyWidget
  }
})

ractive.on({
  myRactiveEvent: function(){
    alert("hello world!");
  }
})

I am not sure if native DOM events automatically convert to custom events and delegate up as component events. As far as I know, native DOM events and custom events are two different things. I may be wrong though. Thoughts @martypdx @evs-chris ?

Correct, component events are from the ractive instance, element events are DOM events or custom events. Given that you might have multiple top-level elements and that you might want to selectively expose which elements raise the click event, it seemed something best left in user land.

Thank you guys, custom events solved that issue! The explanation is clear enough... Do we have this distinction in documentation or should I add this example in there?


move_to_preset shows as unknown instead of being disabled

Description
The value of the move_to_preset selection is empty (unknown).

Reproduction Steps
I do not have any preset's set-up.
Expected behavior
The dropdown should be disabled automatically in that case.
If applicable, add error logs.
No response
Device Firmware
1.3.6 Build 230424 Rel.77225n(4555)
Integration Version
5.4.2
Using stream component
Yes
Does camera work via official integrations?
Yes
Camera has all attributes filled out in developer tools
Yes
HASS Environment
OS
Search for similar issues
Yes
Additional information
access_token: xxx
model_name: C200
brand: TP-Link
motion_detection: on
frontend_stream_type: hls
device_type: SMART.IPCAMERA
device_model: C200
device_name: C200 1.0
device_info: C200 1.0 IPC
hw_version: 1.0
sw_version: 1.3.6 Build 230424 Rel.77225n(4555)
device_alias: Dining Room Camera
avatar: camera c212
longitude: 0
latitude: 0
has_set_location_info: 0
features: 3
barcode:
mac: 28-EE-52-93-E9-D3
dev_id: 80215ACBBFF1B116E989BD4366B7BBF31E273DDA
oem_id: 8902D2F34FCE407721DE92F5759839C2
hw_desc:<PHONE_NUMBER>4300000000000000000001
alarm: off
user: homeassistant
presets:
{}

record_plan:
sunday: '["0000-2400:2"]'
monday: '["0000-2400:2"]'
tuesday: '["0000-2400:2"]'
wednesday: '["0000-2400:2"]'
thursday: '["0000-2400:2"]'
friday: '["0000-2400:2"]'
saturday: '["0000-2400:2"]'

entity_picture: /api/camera_proxy/camera.dining_room?token=xxx
icon: mdi:webcam
friendly_name: Dining Room Camera
supported_features: 3

Correct, camera does not report current state. Not a bug.


Dark mode

Hello,
Would it be possible to create diagrams in dark mode similarly to the diagrams.net editor ?
I can achieve that effect manually changing all the colours, but it's a bit tedious.
Best,
Ivo

Sorry it was already asked and answered


Update solidity

Update solidity because of constructor bug in 0.4.22.

Pull Request Test Coverage Report for Build 30

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 28:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


Quick local

Description

Types of changes

New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)

Checklist

[x] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

NOTE: No code changes, only Docker and supporting scripting.
Further comments
Changes for ./local-infrastructure:

Health checks for postgres and keycloak in docker-compose.yml
Add retries/waits to node_migrate's run-migrations.sh
Add check/wait to ./app/settings/keycload-local-user.sh
Run updated run-migrations.sh using docker-compose.yml
run.sh for easy, consistent setup of local-infrastructure and main application (WSL, Linux)
Super easy quick start config: ./app/config/sample-local.json
Updated local-infrastructure/README.md
Open browser when app served (npm open-cli, just a nice to have)

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-149

@jujaga @parc-jason Thanks for the feedback!  Please feel free to keep those corrections coming.  :)

@jujaga @parc-jason All suggestions, including npm-based file open, are done and squashed into that last commit.

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-149


Change types to make them more stable

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (071865c) 97.86% compared to head (61986e0) 97.88%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   97.86%   97.88%   +0.02%
==========================================
  Files           6        6
  Lines         187      189       +2
==========================================
+ Hits          183      185       +2
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


NLQ Analysis for QALD-9 test dataset is not working as expected

NLQ Analysis for QALD-9 test dataset is not working as expected (upper/lower case issue):
For example (qald-9-test-multilingual) the following question will not be identified as "Is" question:
{       "language" : "en",       "string" : "Is Pamela Anderson a vegan?",       "keywords" : "Pamela Anderson,  vegan"     }

Thanks for your suggestion. I just like to mention that this class is deprecated and not in use. We replaced it with the "OneNLQAnalysis.java" class in our work to determine the NLQ type. We are also preparing for the Web version for CBench and it will be available soon.
I will remove this class in a few days.
Thanks again
Abdelghny Orogat


[1.20.1] Lock on fluid drawers in ATM9

https://github.com/AllTheMods/ATM-9/issues/762

I can't replicate it with a Mekanism pipe and Minecraft fluids


Additional options

What you guys thinks about adding functionality to specify either number of paragraphs to take, or minimum characters. (so if first paragraph have less than minimum characters, take also next one and so on..)
I can prepare PR if you are interested in it.

A PR would be welcome. It would be good to maintain the API and add the functionality via a switch.

I would add option truncate: number|stringthat would truncate the snippet to a max. of n characters and add an ellipsis (...)
I don't think specifying a minimum is common for an excerpt. For potentially better delimiting of the excerpt, see #41


Get resources configuration from Sales Configurator to fill part of the configuration in Web UI

Would it be possible to use a Sales Configurator export to configure cp-deploy resources request ?
There is a CSV file with many information that could help fill in for OCP build and/or CP4D configuration.
Most of the projects use the Sales configurator for sizing so they already did a work in configuring CP4D. IT avoid redoing the work and would help the Web UI part.

@ronanb3 this is a good idea for production deployments for sure, however do you think we need this for demo clusters? do we even use configurator for demos etc?


Wireguard VPN in docker

Wireguard and Deluge torrent clinet

There are some problems to deploy this setup on docker swam
No container linking support!

https://github.com/moby/moby/issues/33055

So there are 3 options

Route deluge torrent traffic through wirequard vpn container with ip routes and iptable rules. But there is no static ip address assigment to assign ips and configure routes during stack bring up.

https://github.com/moby/moby/issues/31860

Deploy this stack as plain docker-compose. But traefik can't allow both docker standalone and docker swam at same time

https://github.com/traefik/traefik/issues/6063

Find or build all-in-one docker image which has wireguard, deluge (jacket, sonarr and radarr)

Example: https://hub.docker.com/r/binhex/arch-delugevpn/

4th options

Deploy stack in docker swarm. Make sure torrent client not directly connect to external network i.e. internal: true and configure proxy in torrent client

Deluge ---------------------------> Wireguard -----> Internet
(Proxy configured to wireguard)

It is required to run socks proxy. One of the socks proxy server is dante-server. Example: https://github.com/kizzx2/docker-openvpn-client-socks

https://github.com/jesec/flood

https://www.reddit.com/r/unRAID/comments/lhilzu/qbittorrent_run_external_program_on_torrent/


scalar_implicit_cast should also apply to arrays of scalars?

Currently, it doesn't. This problem also shows up when automatic inferences are added to methods.
E.g. with the config 'scalar_implicit_cast' => true, and the below code:
<?php

class ArrayCastTest {
    /** @var int[] */
    public static $foo = ['key' => 2];

    /** @param string[] $data */
    public static function takesGenericArray($data) {
        echo $data['key'];
    }
}

ArrayCastTest::takesGenericArray(ArrayCastTest::$foo);

Expected behavior: No issue when 'scalar_implicit_cast' => true. There should still be an issue if false.
Actual behavior: src/array_cast.php:13 PhanTypeMismatchArgument Argument 1 (data) is int[] but \ArrayCastTest::takesGenericArray() takes string[] defined at src/array_cast.php:8
Similarly, null_casts_as_any_type might also make sense to affect arrays of types (maybe less useful).

Simplified test case
/** @param string[] $p */
function f($p) {}
f([42]);


Remove uses of unstable feature(cfg_target_has_atomic)

Instead of depending on unstable features of the compiler, use the TARGET environment variables provided by cargo for the build script and a list of targets that do not have atomic CAS.
This completely removes the dependency on unstable features from crates other than futures, futures-util, futures-io.
This way is inspired by the way heapless and defmt do, but this doesn't maintain the target list manually. (It's not really fully automated, but it's very easy to update.)
Closes #2399
Replaces #2294
r? @Nemo157 @cramertj
cc @jamesmunns @Dirbaio

This is great! Thanks for working on it :)
Removing cfg-target-has-atomic will break users building for custom targets that have no atomics, though.

Removing cfg-target-has-atomic will break users building for custom targets that have no atomics, though.

Hmm, you are right.
That said, we want to reduce dependency on unstable features as much as possible... So perhaps the compromise is to make cfg(no_atomic_cas) an unstable public API so that atomics can be disabled via RUSTFLAGS:
RUSTFLAGS='--cfg futures_no_atomic_cas' cargo build

Why not simply keep cfg-target-has-atomic as-is? I'm not a fan of having to use RUSTFLAGS. The standard way to customize lib behavior is cargo features.
Aditionally, removing it` (or keeping it but making it do nothing) is semver-breaking: it makes custom targets stop compiling.

Why not simply keep cfg-target-has-atomic as-is? I'm not a fan of having to use RUSTFLAGS. The standard way to customize lib behavior is cargo features.

The current design (enabling unstable features by feature flags) is that dependencies can enable unstable features even if the user doesn't enable them directly, and it is problematic.
See also https://github.com/rayon-rs/rayon/issues/369, https://github.com/rayon-rs/rayon/issues/364, https://github.com/alexcrichton/proc-macro2#unstable-features, https://github.com/tokio-rs/tokio/pull/1774#issuecomment-554505014, etc.

Note that this must not only be done for your crate, but for any crate that depends on your crate. This infectious nature is intentional, as it serves as a reminder that you are outside of the normal semver guarantees.

feature(cfg_target_has_atomic) will never stable as far as I understand. Continuing to rely on such "forever unstable" features is a maintenance burden. (Actually, I think it will be removed in favor of cfg(accessible) in the future, not "forever unstable".)

semver-breaking

No, cfg-target-has-atomic feature is unstable and stability is not guaranteed.
https://github.com/rust-lang/futures-rs/blob/c77cd3c9ba19b65db3d1931d2087032752fe9c7d/futures/Cargo.toml#L46-L48

I wasn't aware of this issue with unstable features and the shift to use RUSTFLAGS. Looks good to me then! :+1:

Hey @taiki-e, thank you for implementing this!
I have tested this change in my cassette repo (which prompted this), and I was able to replace my copy/paste exports with just exporting the futures dependency.
I can confirm this change works as expected for my project, at least :)

@jamesmunns Thanks for testing this!


Implement state verification and allow to pass nonce and prompt through the client

I think I'm done making mistakes for the moment. Sorry about the noise.

I think I'm done making mistakes for the moment, should be safe to review now. Sorry about the noise.

Well, almost :)

I forgot to add a comment but I've fixed the formatting. Mind approving the workflow yet another time? :)


Local caching support for Azure DCAP in Windows

Issue to track the work for porting the local caching of PCK Certificates feature to the Windows Azure DCAP library.
@msft-chow currently working on this.

This is complete


[5.2] Fix query strings handling

Same as #10894, but for 5.2 if you consider this breaking.

I don't think it would be considered breaking?


createSemanticDiagnosticsBuilderProgram is confusing and error prone

This is a follow up to #29176 which was never resolved. To clear up some confusion I think existed in the conversation there, here's what I think the crux of the issue is:
In the example at https://github.com/microsoft/TypeScript/wiki/Using-the-Compiler-API#writing-an-incremental-program-watcher, the code uses createSemanticDiagnosticsBuilderProgram. It is strongly implied by the comments there (and the name of the function itself, in contrast with createEmitAnd...) that the example will not emit code. But it actually does, for reasons explained at https://github.com/Microsoft/TypeScript/issues/29176#issuecomment-450232791.
Not only does it emit code, but it does so several times slower than optimal, since it is not using the optimized EmitAnd... builder.
#29176 explains how it all works, but the slow & confusing example code remains. So, what do you think about the following?

Fix the example. Two options for that: (a) Change it to use createEmitAndSemanticDiagnosticsBuilderProgram. (b) Change it to alter afterCreateProgram so that it does not emit (EDIT: an easy way to do this without touching afterCreateProgram is to just set {noEmit: true} as the second arg to createWatchCompilerHost). Or create an example for both.
Throw an exception (or at least log a warning?) when calling emit with a non-emit builder (SemanticDiagnosticsBuilderProgram), since doing so will be much slower, and is probably a mistake. Or are there valid use cases for doing that?

Exploring that last point even further, it's unclear why the non-emit builder needs to exist at all. The only thing it seems to optimize is avoiding appending some filenames to an array (affectedFilesPendingEmit), which doesn't seem consquential. I may be missing something, but I wonder if this could all be simplified by unifying the two kinds of BuilderProgram and simply avoiding a call to emit when you don't want emitting (which you have to do anyway, even when using the non-emit builder).
Thanks!
cc @sheetalkamat @0xorial @weswigham (from #29176)

cc @DanielRosenwasser
There exists two builders because lot of times, user of semantic diagnostics builder knows what files it wants to emit (eg. loaders for webpack). So this provides the way to be able to get diagnostics in optimal fashion in those scenarios. As explained earlier these users use emit with already known set of files it wants to emit so it isn't really slow as it is similar to emit and semantic diagnostics builder without builder having to track which files are emitted and which are not and that's the main distinction between the two builders where the emit and semantic builder, marks some file's change application complete only when that file (and related affected files) are emitted. It also needs to emit it in specific order since that's how the tracking works (it doesn't calculate all files to emit and that work is unnecessary when someone knows what files to emit and its their own order they are going to call in with.

@sheetalkamat thanks, that helps clarify. Given that, I think the issue is with naming, documentation, and the sample code.
It's now clear that SemanticDiagnosticsBuilderProgram is intended to be used with emit, so hopefully you can see why the other builder having the same name prefixed by EmitAnd is misleading. The names also don't hint at the difference in emitting all files vs affected files only (hence the confusion about performance issues).
Given the actual behavior differences, I'd propose naming them something like AffectedFilesBuilderProgram and AllFilesBuilderProgram, or something similar that captures the important difference between them.
The comments in the example code could also use some clarification:

// Between createEmitAndSemanticDiagnosticsBuilderProgram and
// createSemanticDiagnosticsBuilderProgram, the only difference is emit.
// For pure type-checking scenarios, or when another tool/process handles emit,
// using createSemanticDiagnosticsBuilderProgram may be more desirable.

"The only difference is emit" should say something like "the difference is that the latter will process all files, while the former will only process changed files and their transitive dependencies".
And finally, I think it makes sense for the example itself to be updated to use the builder that only processes affected files. If you're using a watcher, you most likely only want to process the files that changed.
Do those changes make sense?

I don't think we intend to change the names for the builder since these are there for long time. But adding @DanielRosenwasser to see if there is some clarification that needs to be done in samples.

Hey, thanks for looking into this @russelldavis - I think that comment suggestion is a change we'd be happy to accept on https://github.com/Microsoft/TypeScript-wiki/.
I'd personally be okay with an API rename provided we could deprecate the original names, but if this would be too confusing for existing users, maybe providing this directly in the JSDoc for each function and type would be good enough. That's also a PR we would be happy to take!

I was also very surprised when host.writeFile was called for SemanticDiagnosticsBuilderProgram. But what I also found that watching builder is nearly twice slower compared to "normal" build without emit.
Note I had to monkey patch isSourceFileFromExternalLibrary to always return false, so incremental rechecks are relatively fast (it is monorepo with yarn workspaces, and no subprojects). And TypeScript is hosted inside ChakraCore. I know very corner case, so just for your interest.


it seems dgl-0.4.1 cannot work properly

when running the script, will get the following error:
munmap_chunk(): invalid pointer
scripts/pretrain.sh: line 10: 17039 Aborted                 (core dumped) python train.py --exp Pretrain --model-path saved --tb-path tensorboard --gpu $gpu $ARGS
update dgl to 0.4.3 fix it.

HI @Coolgiserz ,
We find this can indeed happen on some machines, thanks for your contribution!


(Trying to get) subclocks to implement top-level S .data () synchronity

Any way this is possible? I know I can do something like this, but I'm envisioning a logger with multiple disparate sources. Why is the exception being thrown anyway, I can't see how can log receive multiple values in the same time instant anyway.

Ah-hah, that's a bug in S.subclock().  Specifically, when creating a subclock from top level, if the code running in the subclock sets a data signal in an outer clock, that outer data signal is being marked dirty but never scheduled for propagation.  When you later set A() again, S finds that log() is already still dirty and so thinks you've tried to set it twice.  This only happens when creating a subclock from top level: any other context, the subclock is running as part of its parent's update, so the parent update cycle picks up the change and propagates it.  I may need to add a special case to 'unwind' a subclock for this.
If you move log() into the subclock, you won't get the error.  But I'm not sure that accomplishes what you're trying to do.  Is the goal to have multiple signals that could feed into a single log() signal?  The code you've written doesn't really take advantage of subclocks (beyond finding an error :)).  Since all the signals it reads are from the outer clock, it will never have a follow-on update.

Pushed a fix and bumped npm version to 0.4.8.

Alright, the updated runkit runs now! But you're right, it doesn't preserve the synchronity. Do you think it's possible to synchrously pipe the value of one top level data into another top level data?

The piped-into data needs to be in the subclock for it to appear synchronous to top-level code.
It's not possible to pipe into a top-level data signal synchronously b/c that would actually break synchronicity :).  It's not just computations that belong to a clock, it's data signals too.  The top-level data signal can't update faster than its clock.  Or to put it another way, if you could, how could we guarantee that no computations read the data signal before it got its new value?
To be a bit figurative, top level code looks into a subclock and sees a peaceful world: all change has been brought to completion and the subclock is at rest.  Subclocks look up to top level code and see a frozen sky: immutable while they update.
So subclocks can set top level data signals, but that won't take effect until the top level itself updates.  It's no different, in that case, than a top level computation updating the data signal.

@adamhaile I guess the thing I actually wanted to achieve when I asked this question was how to make a computation not be recomputed, something akin to S(() => <code>) in the same way S.value is to S.data. Imagine we have a single S.data (or S.value) store the entire state of an app, and have separate computations extract various parts of the app state to render, wheras user actions change these separate parts of the state in the big master state. Wouldn't it be useful to not always rerender a component, if the root change in state had not actually changed the component's part of state? What do you think?


CLRMD isn't signed with a strong name and can't be referenced from strong named apps

A strong named application can't use CLRMD since it's unsigned. An exception is thrown at runtime.
It would be nice if the nuget package contained a strong named CLRMD assembly.
Current workaround is to compile the sources yourself and add your own snk file.

BenchmarkDotNet has the same problem with ClrMD
it would be great to have a strong named NuGet package

This was fixed a while back.


Email template localization using local claims doesn't comply with OIDC specification.

Describe the issue:
In WSO2 email template localization documentation[1] it says to add localization code (example fr_fr for French) to the "http://wso2.org/claims/locality" local claim in user's profile.
The local claim "http://wso2.org/claims/locality" is being mapped to the OIDC claim "locality". But according to the OIDC specification [2] the purpose of this claim is to have an address of a city (example "Los Angeles").
The localization functionality of email templates works with the language code given to the local claim "http://wso2.org/claims/locality" (which has been mapped to OIDC claim "locality")
Hence it seems like this is an OIDC spec violation. Also both local claims "http://wso2.org/claims/local" and "http://wso2.org/claims/locality" are being mapped to the same mapped attribute "local" which should be handled properly.
Expected behavior:
Ideally the email template localization should work with local claim "http://wso2.org/claims/local" since that is the attribute given in OIDC specification to store localization code (fr_fr).
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 5.11.0

[1] - https://is.docs.wso2.com/en/latest/learn/customizing-automated-emails/#updating-the-locale-of-a-user
[2] - https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Bugfix: Add the missed keyReleaseEvent method in QtViewerDockWidget

Description
I noticed that callbacks do not get key release events when the focus is not on the canvas but they continue to receive key press events. You can easily reproduce the issue by running examples/custom_key_bindings.py and then clicking, for example, on the layer in the layer list, the hello callback (on w key) no longer receives key release events after that.
The issue is cause by the missed keyReleaseEvent in QtViewerDockWidget.
References

Type of change

[X] Bugfix (non-breaking change which fixes an issue)

How has this been tested?

[X] I tested it manually

Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

In this example, our callback is still run when we press the Up key even if we are trying to navigate the layer list

@alisterburt Thank you for being mindful about possible issues. However, this PR doesn't actually affect it because it simply adds the omitted the key release event; the release press is already there (for years since 2019 judging by the commits history) and the described behavior with the Up key is happening with the current main branch.
All the possible pitfalls that you mentioned are already should be present as most callbacks only care about the key press event.


Plugin failes with gradle version 8.1.1

The plugin failes with this error message (unfortunately there is no more information in the gradle log output):
* What went wrong:
Failed to stop service 'gitHubDependencyExtractorService'.
> The GitHubDependencyGraphPlugin plugin encountered errors while writing the dependency snapshot json file. Please report this issue at: https://github.com/gradle/github-dependency-graph-gradle-plugin/issues

The plugin is working correctly with Gradle 8.1.1 as demonstrated by this CI job: https://github.com/gradle/github-dependency-graph-gradle-plugin/actions/runs/5912408084/job/16035895646
Can you please run the build with --stacktrace and see if that provides a clue as to what's going wrong? Possibly you are not setting one of the required environment variables.

You're right. I was missing GITHUB_JOB_CORRELATOR and GITHUB_JOB_ID. Was still setting GITHUB_DEPENDENCY_GRAPH_JOB_CORRELATOR and GITHUB_DEPENDENCY_GRAPH_JOB_ID.
Maybe there should be a better warning, when changing env-variables. As this project is still experimental it's ok, I think.
Thank you for your help :)


Tagging new release.

Thanks for the quick PR approval. Would you be so kind to tag a new release so Packagist picks up the changes?
Thanks in advance!

All done!

Perfect, thanks for the quick follow up, much appreciated!


Fix roborio crashes

As someone operating the robot I can continue operation without having the robot crash require physical reboot.

Current status, find latest firmware for navx mxp to fix i2c crash


windows install error

[x] I believe this to be a bug.
[x] I am on (or have tested on) Windows 10+

$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [i386-mingw32]
$ gem -v
2.6.11

My Reproduction Steps
$ gem install em-websocket

Temporarily enhancing PATH for MSYS/MINGW...
Building native extensions.  This could take a while...
ERROR:  Error installing em-websocket:
        ERROR: Failed to build gem native extension.

    current directory: C:/Ruby24/lib/ruby/gems/2.4.0/gems/http_parser.rb-0.6.0/ext/ruby_http_parser
C:/Ruby24/bin/ruby.exe -r ./siteconf20180212-6280-1wh9dlz.rb extconf.rb
creating Makefile

current directory: C:/Ruby24/lib/ruby/gems/2.4.0/gems/http_parser.rb-0.6.0/ext/ruby_http_parser
make "DESTDIR=" clean

current directory: C:/Ruby24/lib/ruby/gems/2.4.0/gems/http_parser.rb-0.6.0/ext/ruby_http_parser
make "DESTDIR="
generating ruby_http_parser-i386-mingw32.def
make: *** No rule to make target '/C/Ruby24/include/ruby-2.4.0/ruby.h', needed by 'ruby_http_parser.o'.  Stop.

make failed, exit code 2

Gem files will remain installed in C:/Ruby24/lib/ruby/gems/2.4.0/gems/http_parser.rb-0.6.0 for inspection.
Results logged to C:/Ruby24/lib/ruby/gems/2.4.0/extensions/x86-mingw32/2.4.0/http_parser.rb-0.6.0/gem_make.out

This error indicates that the http_parser.rb gem dependency failed to compile. Please try installing that gem and if necessary report a bug there. Thanks.


Conformal mapping plot: right half of z plane to unit disk

Hello,
I'm learning how to use this very useful package to display conformal maps having recently read the wonderful book: Wegert, Elias. Visual complex functions: an introduction with phase portraits. Springer Science & Business Media, 2012.
As a test, I tried to plot the following conformal map

from Kythe, Prem K. Handbook of conformal mappings and applications. CRC Press, 2019.
Using the following code
# test_conformal_mapping.jl

using DomainColoring
using GLMakie

function f_z(z::ComplexF64)::ComplexF64
    r, _ = reim(z)
    w::ComplexF64 = 0.0 + im*0.0

    if r >= 0.0
        w = z
    else
        w = NaN + im*NaN
    end

    return w
end

function f_unit_disk(z::ComplexF64)::ComplexF64
    r, _ = reim(z)
    w::ComplexF64 = 0.0 + im*0.0

    if r >= 0.0
        w = (z - 1.0) / (z + 1.0)
    else
        w = NaN + im*NaN
    end

    return w
end

function f_exp(z::ComplexF64)::ComplexF64
    r, _ = reim(z)
    w::ComplexF64 = 0.0 + im*0.0

    if r >= 0.0
        w = exp(z)
    else
        w = NaN + im*NaN
    end

    return w
end

function conformal_map_unit_disk(f_z, f_unit_disk; bounds)
    figure = Figure(fontsize = 32)

    axis_11 =
        Axis(
                figure[1,1],
                title=L"z \rightarrow z",
                aspect=DataAspect()
            )
    checkerplot!(axis_11, z -> f_z(z), bounds)

    axis_12 =
        Axis(
                figure[1,2],
                title=L"z \rightarrow \frac{z - 1}{z + 1}",
                aspect=DataAspect()
            )
    checkerplot!(axis_12, z -> f_unit_disk(z), bounds)

    axis_13 =
        Axis(
                figure[1,3],
                title=L"z \rightarrow \frac{z - 1}{z + 1}",
                aspect=DataAspect()
            )
    domaincolor!(axis_13, z -> f_unit_disk(z), bounds, abs=true)

    wait(display(figure))
end

function main()
    bounds = (-1.0, 8.0*π, -4.0*π, 4.0*π)
    conformal_map_unit_disk(f_z, f_unit_disk; bounds)
end

begin
    main()
end

However, the result is not what I expected.

For example, I would expect the point z = 0 to map to w = -1.
So I'm a bit puzzled. Is there an issue with my above code or in my understanding of conformal maps.

I find the box option rather useful to play with conformal maps. Compare for instance
domaincolor(z->z, 2, box=[(0,10+10im,:blue), (0,10-10im,:red)])
to
domaincolor(w->(1+w)/(1-w), 2, box=[(0,10+10im,:blue), (0,10-10im,:red)])
You see both squares being mapped to the unit circle (of course not the entire ubnit circle is filled as the squares are not infinite). Note the use of the expression for $z$ as a function of $w$. The axes show the input space and the colouring the output space. We want to see where the squares (which live in the $z$-plane) end up in the $w$-plane, hence we want to map the axes to the $w$-plane and the colouring to the $z$-plane.
Plotting conformal maps generally involves the inverse transform, that took me a while to graps 😅
Hope this helps!

(To see the entire unit circle you can use domaincolor(w->(1+w)/(1-w), 2, box=[(0,Inf+Inf*im,:blue), (0,Inf-Inf*im,:red)]))


Reverse a Array Program

Added Reverse-the-array-program. Hope it will help. DO ACCEPT MY PR.

@ASACHIT
Thank you very much !! I am grateful to you, can you please label this PR with Hacktoberfest-accepted !! Please...

@hanshulll Merging pull requests does the same thing. since hacktoberfest is a repository topic

@ASACHIT
Thank you so much for the info


尽量使代码符合PEP8规范

getattr to hasattr

Codecov Report

Merging #358 into master will increase coverage by 0.07%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   72.87%   72.95%   +0.07%
==========================================
  Files          74       74
  Lines        2640     2640
==========================================
+ Hits         1924     1926       +2
+ Misses        716      714       -2

Impacted Files
Coverage Δ

wechatpy/client/api/base.py
100% <100%> (ø)
:arrow_up:

wechatpy/pay/base.py
77.77% <25%> (ø)
:arrow_up:

wechatpy/pay/utils.py
93.33% <0%> (+3.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c5d00...c78c53c. Read the comment docs.

所以可以关闭这个PR了？


Updated Key-Value extension to use a list view.

Description
Improved the key-value extension to use a list view.
Approved by extension author @NirLevy98.
Screencast
https://github.com/raycast/extensions/assets/8081679/f0cb86f4-e1cc-449c-a4c0-db8a90bf5fe5
Checklist

[X] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast
[X] I checked that files in the assets folder are used by the extension itself
[X] I checked that assets used by the README are placed outside of the metadata folder

A very useful addition!

That's indeed a nice update, I think it could be simplified a bit with this approach, what do you two thinks?
import { ActionPanel, List, Action, getPreferenceValues } from "@raycast/api";
import { useCachedPromise } from "@raycast/utils";
import * as fs from "fs";

export default function Command() {
  const prefs = getPreferenceValues<ExtensionPreferences>();

  const { isLoading, data } = useCachedPromise(
    async () => {
      return JSON.parse(fs.readFileSync(prefs.jsonFilePath, "utf8"));
    },
    [],
    { initialData: [] }
  );

  const createListItem = (key: string, value: string) => {
    return (
      <List.Item
        key={key}
        title={key}
        keywords={[value]}
        subtitle={value}
        actions={
          <ActionPanel>
            <Action.CopyToClipboard content={value} />
          </ActionPanel>
        }
      />
    );
  };

  return (
    <List isLoading={isLoading}>
      <List.Section title="Key -> Value">{Object.keys(data).map((key) => createListItem(key, data[key]))}</List.Section>
    </List>
  );
}

Definitely, React isn't my expertise 😅
I'll commit an update

There might be one thing I forgot about, it's the copy to clipboard - two solutions:

Roll back and have to lists
Have two actions on the list item (One for copy key, one for copy value)

@pernielsentikaer I am adding two sections, one for key -> value and one for value -> key
The goal is to be able to quickly convert between the two quickly, so if i paste one i immediately get the other.


Catch errors in setup/teardown

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

test/TestServer/UnitTestFramework.js, line 133 [r1] (raw file):
This is minor and doesn't require acknowledgment, but the JSON.parse could have been within the setResult function to avoid repeating it every time it is called.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

test/TestServer/UnitTestFramework.js, line 133 [r1] (raw file):
I'm confused by this comment. Every time setResult is called it is called with a brand new result which requires a new parse so how would putting the parse into setResult fix anything?

Comments from the review on Reviewable.io


Updates maintainers affiliation

This updates Nisha's affiliation from VMware to Oracle
Signed-off-by: Ivana Atanasova<EMAIL_ADDRESS>

Thanks @ivanayov!


add a assembly.xml to define which files will be packed into source-release.zip

Considering we packed some incorrect files in the last release (RC1 to RC4), I think writing an assembly.xml file for generating the source-release.zip is a good way to avoid that.
What is more, it is very helpful when we switch different branches for releasing. for example, in v0.9.0, there is a module called session, which does not exist in 0.8.0. So, if I switch the branch from 0.9 to 0.8 (or rel/0.8) for a minor version releasing (e.g., 0.8.2), I have to remove the session folder manually.  But if we have an assembly.xml,  it will avoid that.
I have written the source-assembly.xml now. The assembly file looks ugly because we have to declare the files one by one. (I tried the  tag, which is more convenient. But because our module.artifactId != module.folder name, there is some issues that I can not solve. Finally I gave up using  tag).
If the PR is accepted, then for all contributors please notice that:
(1) If you add new source files into a src/ docs/ license folder, it is ok.
(2) If you add a new module,  create a new folder, or write a plain text file under the project's (or a module's) root directory, you have to maintain the source-assembly.xml file.. Otherwise the new added files will not be packed into source-release.zip.
Hope in this way, we can no longer get  dirty source-release.zip files.

I will close this because using mvn release:perform can get a clean packed file........
So sad that I spend about 6 hours to learn the plugin and finish the file :( But also happy that do not need to maintain such a file in the project.


For consideration: add a fully-featured html to text rendering function to rust_g

Just to get this out of the way, html2text is a huge dependency as it pulls html5ever. It will bloat the resulting binary to 1200 KB-ish. However, some of it is stuff we could use elsewhere maybe (serde), and it does not have any system-side dependencies, being pure rust.
It would give us a much much cleaner way of dealing with untrusted user input, rendering raw input Borgname into Borgname and leaving I am a b'anana as-is. Right now the first one eventually prints out as Borgname and the latter becomes I am a b'anana.
As for the branch name, I first intended to use html5ever directly however I'm afraid my rust skills don't stretch that far.

other alternatives: adding simple tag stripping

Getting messages like "I am a b'anana" in the chat has way more to do with double-encoding than with stripping HTML, I think we may need an encoding discipline more than this


[state sync] specs/README

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/libra/developers.libra.org, and link to your PR here.)

/land

:broken_heart: Test Failed - commit-workflow

/land

/cancel

/land

:broken_heart: Test Failed - commit-workflow

/land


Strict function args

Zod right now always adds .rest(z.unknown()) to any function initiation and makes it impossible to validate that a function does not get extra parameters it does not intend

Is this the desired behavior? One could call z.ZodFunction.create() directly but feels a bit strange.

Fixed in<EMAIL_ADDRESS>👍


(regression) Screen flickers when tabbing in git bash(affects 1.19.xxx)

Windows Terminal version
1.19.10573.0
Windows build number
10.0.19045.0
Other Software
No response
Steps to reproduce

Integrate git bash (from "bash for windows") in the Terminal
Open in any directory
<tab><tab> on an empty prompt
It will take a while until bash prints "Display all XXXX possibilities? (y or n)". A few seconds before that the terminal screen will flicker/redraw. It momentarily flashes the whole screen with a lighter color than the background. The same is observed when you answer n in the bash question.

Last known working version: 1.18.10301.0
The bug seems to have started with the 1.19.x series.
Expected Behavior
Terminal screen to not flicker/redraw/flash.
Actual Behavior
Terminal screen flickers/redraws/flashes.

Apparently the 1.19.xxx series have implemented more support for terminals/shells.
Thanks to they AI bot which pointed me to #7200.
The flickering is the visual bell.
To fix the issue:

Open C:\Program Files\Git\etc\inputrc (write protected location, open editor with admin rights)
Change line set bell-style visible to set bell-style none

Funny thing is that "Git for Windows" default terminal (aka mintty) doesn't support the visual bell. Only the audible one.


[Bug] Timer on iOS leaves white space on top and bottom

Screenshot on iPhone13

Screenshot on iPhone 5

Acceptance Criteria:

Background color is consistent on iOS

Hi @a-mabe I have found how to fix this issue, please can you assign this one to me?

Heya @a-mabe done this one.

Thank you @alastairrmcneill! I merged your fix for this


It seems not working

I have a 900+M big image:
arthurwangs-MacBook-Pro:docker-tar arthur$ docker history 552bb0624af2
IMAGE               CREATED             CREATED BY          SIZE                COMMENT
552bb0624af2        About an hour ago   /bin/bash           110.1 MB
1d345e8af171        3 days ago                              953.6 MB            Imported from -

I use squash to compress it , but it still remain in 1GB+ size:
arthurwangs-MacBook-Pro:docker-tar arthur$ docker save 552bb0624af2 | sudo docker-squash -verbose -t root:1 | docker load
Password:
Loading export from STDIN using /tmp/docker-squash046536096 for tempdir
Loaded image w/ 2 layers
Extracting layers...
  -  /tmp/docker-squash046536096/1d345e8af17112fa644f04ea6d93d10241b344e412f968bab81e337c9dd1bdae/layer.tar
  -  /tmp/docker-squash046536096/552bb0624af20d79ed1fe374eda40b4459e933aca812bc85d4784aeb44913320/layer.tar
Inserted new layer e56cfb97521e after 1d345e8af171
  -  1d345e8af171
  -> e56cfb97521e /bin/sh -c #(squash) from 1d345e8af171
  -  552bb0624af2 /bin/bash
Squashing from e56cfb97521e into e56cfb97521e
  -  Deleting whiteouts for layer 552bb0624af2
  -  Rewriting child history
  -  Removing 552bb0624af2. Squashed. (/bin/bash)
Tarring up squashed layer e56cfb97521e
Removing extracted layers
Tagging e56cfb97521e as root:1
Tarring new image to STDOUT
Done. New image created.
  -  1d345e8af171 3 days  977.4 MB
  -  e56cfb97521e 19 seconds /bin/sh -c #(squash) from 1d345e8af171 110.3 MB
Removing tempdir /tmp/docker-squash046536096
The image root:1 already exists, renaming the old one with ID c47f98670d7d to empty string
arthurwangs-MacBook-Pro:docker-tar arthur$ docker image
docker: 'image' is not a docker command.
See 'docker --help'.
arthurwangs-MacBook-Pro:docker-tar arthur$ docker images
REPOSITORY              TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
root                    1                   e56cfb97521e        2 minutes ago       1.064 GB
<none>                  <none>              c47f98670d7d        About an hour ago   1.064 GB
newtag                  latest              e25fb3d04c4f        About an hour ago   1.064 GB
rcontainer              iptableconfig       552bb0624af2        About an hour ago   1.064 GB
<none>                  <none>              8102a6a36300        4 hours ago         990.1 MB
init                    compressed          1d345e8af171        3 days ago          953.6 MB

Is there any steps Im missing ?

Perhaps similar to my issue #36
It seems to be working with an image I pulled from here (monsantoco/min-jessie:latest) but not on debian:jessie:latest. It appears something broke in the "latest" official Docker images?

@2devnull     'It appears something broke in the "latest" official Docker images?'   . I think so .

Have same problem (just a simple sinatra app):
FROM ruby

MAINTAINER drakmail "https://github.com/drakmail"

RUN gem install bundler

COPY . /app
WORKDIR "/app"

RUN bundle install

EXPOSE 4567

CMD ["bundle", "exec", "rackup", "config.ru", "-p", "4567", "-o", "<IP_ADDRESS>"]


use different dioxus versions depending on the platform

hello.
im trying to use the revision 1e99e355 for android and latest version of dioxus from master on the desktop.
referenced issue here: https://github.com/rust-lang/cargo/issues/7753#issuecomment-1377044663
why im trying to do this? because latest version of dioxus doesnt work on android. [maybe i will open a separate issue]
why revision 1e99e355? because this revision works on android and so this revision is used by default in a project template when you create a new project with x new (cargo xbuild)
the problem is: this revision, 1e99e355, doesnt have all the cool new features that i can use and so im trying to mix the both in the same codebase with conditional compilation, of course.
does anyone have a workaround for this?
thanks in advance!

i've even tried different paths depending on activation of the features, but that goes into the issue mentioned from cargo.

depending on activation of the features

why this doesnt work? it works, but when macro expansion happens from within the rsx! macro doesnt work. dependency ::dioxus is used and expected by the macro. i've tried to use something like this: use dioxus_030 as dioxus, but this doesnt work [i can make a separate issue for this if needed].

author of xbuild here: dioxus 0.3.0 should work on android. updated the template here: https://github.com/rust-mobile/xbuild/pull/104

ok. so how do i reflect the change of the template on my system?
by updating cargo-xbuild by running: cargo install --force cargo-xbuild ?

did something related to the code of xbuild changed? or just the template changed?
because i've tried dioxus 0.3.0 on android, and everything compiles well and even installs correctly on android, but when i open the app, the ui doesnt respond, and when im trying to type some text into an html input, the app crashes.

And that issue doesn't exist with the older dioxus version? In that case you should open a bug report once you've made sure that it isn't a user error. It sounds like it is maybe a duplicate of https://github.com/DioxusLabs/dioxus/issues/626

And that issue doesn't exist with the older dioxus version?

yes, with https://github.com/DioxusLabs/dioxus/commit/1e99e35572f6cf4f3ae09e1d0290b6e43838518d, no issue

ok, seems that this is the only change in the template PR: https://github.com/rust-mobile/xbuild/commit/7e40e18c040189c39dfea70b78fd46d0a019632b
what i understood from what you said is that if i use the version bumps from the pull request on the template, dioxus 0.3.0 should work on android. right?

not saying there aren't any bugs. dioxus 0.3 was just released recently and rewrote large parts of the internals. just started testing the 0.3 release and hit some bugs:

[0] https://github.com/DioxusLabs/dioxus/issues/734
[1] https://github.com/DioxusLabs/dioxus/issues/742

use_atom_ref with Fermi gives errors #734, honestly, i dont really understand why dioxus panics a lot in the source. i've also found a lot of panics.
have you considered using Results and propagating the error to the user to not panic at all?

ok, seems that this is the only change in the template PR: rust-mobile/xbuild@7e40e18
what i understood from what you said is that if i use the version bumps from the pull request on the template, dioxus 0.3.0 should work on android. right?
meaning that: i can use a project made with the old version of the template on which i only need to change the versions to update to latest dioxus. right?
lets see..

ok so the smallest example build with old template but with bumped versions works on android.
thanks for the suggestions and help!
now lets see if i can port my project to 0.3.0, after that i will close the issue.

doesnt work. false positive.
this example doesnt work
fn app(cx: Scope) -> Element {
    let mut count = use_state(&cx, || 0);

    cx.render(rsx! {
        div {
            "hello world"
            input {

            }

            h1 { "Count: {count}" }

            button { onclick: move |_| count.set(1), "+" }
            button { onclick: move |_| count.set(-1) , "-" }

            div {
                "just a div"
            }
            button {
                "just a button"
            }
        }
    })
}

more specific, when you press the + or - button, the UI freezes and nothing else its working.
seems to be related to this part
            button { onclick: move |_| count.set(1), "+" }
            button { onclick: move |_| count.set(-1) , "-" }

something happens there. i guess deadlock?
x run --device X doesnt show any panics or errors after deploying the app

just this log appears after pressing the + or - buttons.
13415 13415 I IMM_LC  : hideSoftInputFromWindow - mService.hideSoftInput
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 0
13415 13415 I ViewRootImpl@9e973b6[MainActivity]: ViewPostIme pointer 1

these logs represent me touching the phone on and on, but like i said nothing happens.

non related: how can i debug such applications that run on android? to know what part of the code is raising errors or panics or deadlocks.
or what can i do to see whats happening?


API-1509: Add aesgcm to encryption config

/assign @deads2k

this lgtm, but the generation didn't quite work.  I fixed it in the middle/last commit of https://github.com/openshift/api/pull/1413

Closing in favor of https://github.com/openshift/api/pull/1413.


Sensible defaults / Zero config

Once the entire Launcher app runs from a single JAR we should make it possible to run it without any configuration if possible.
We should either use sensible defaults (preferred option), offer an alternative solution or simply disable features automatically if the required configuration is not available.
For example: either use a default cluster list if LAUNCHER_MISSIONCONTROL_OPENSHIFT_CLUSTERS_FILE wasn't specified (defaults). Or we could perhaps show the user a field to allow them to enter the URL to their cluster (alternative option) or just remove the option to deploy to a cluster (disable).
Things that don't work:

[ ] OpenShift clusters
[ ] GitHub
[ ] Anything else?

Is this something you could take a first look at perhaps? With the new auth systems I don't really know what's necessary and/or possible.


Track - Volume button does not response on promotional modal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to FAB> Track Expense
Verify that promotional modal appears
Tap on volume button

Expected Result:
Volume button should response as mute/unmute
Actual Result:
Volume button does not response when tap on it
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/f63d8e2c-e58d-4221-9185-cd33c8f24e02
View all open jobs on GitHub

@mallenexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

Proposal
Please re-state the problem that we are trying to solve in this issue.
Volume button doesn't work in track expense explanation video.
What is the root cause of that problem?
When we press the volume, it will call updateVolume, however, currentVideoPlayerRef.current is null.
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/VolumeContext.tsx#L13-L18
The ref is initially set correctly, but a resetVideoPlayerData is called
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/PlaybackContext.tsx#L75-L81
because currentReportID is changed.
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/PlaybackContext.tsx#L85-L90
That's because when we open the track expense page, it will add the self DM report too to the stack, thanks to getAdaptedStateFromPath.
The currentReportID changes from undefined (but default to -1) to the self DM report ID.
What changes do you think we should make in order to solve the problem?

We can ignore the resetVideoPlayerData logic if the current video is not a report video. We already have a currentlyPlayingURLReportID state,
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/PlaybackContext.tsx#L13
useEffect(() => {
    if (!currentReportID || currentReportID === '-1' || !currentlyPlayingURLReportID) {
        return;
    }
    resetVideoPlayerData();
}, [currentReportID, resetVideoPlayerData]);

however, currentlyPlayingURLReportID currently holds the topmost report ID, so it will contains the self DM report ID.
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/PlaybackContext.tsx#L17
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/PlaybackContext.tsx#L42-L47
To fix that, we need to update updateCurrentlyPlayingURL to accept a 2nd param for the video report ID and use that as the currentlyPlayingURLReportID.
const updateCurrentlyPlayingURL = useCallback(
  (url: string | null, reportID: string | null) => {
    setCurrentlyPlayingURLReportID(reportID);

Then, for each usage of updateCurrentlyPlayingURL, we need to pass the reportID. There are a few usages, but here is a few usages you need to update to verify this solution.

First, add a new props called reportID in BaseVideoPlayer. Pass the reportID to both updateCurrentlyPlayingURL in BaseVideoPlayer.
In VideoPlayerPreview, there is already a reportID. Pass the reportID to updateCurrentlyPlayingURL and VideoPlayer component.

This way, the video in track expense explanation modal will have an undefined reportID.
Btw, I also notice that in Android, the video starts with a sound for a brief second. We already have the logic to mute the video initially (volume.value is initially 0), but looks like it's a bit late in Android, so the video starts with a sound for a second.
https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/components/VideoPlayerContexts/VolumeContext.tsx#L27-L32
To fix that, we can mute the video immediately on mount in BaseVideoPlayer.
useEffect(() => {
    videoPlayerRef.current?.setStatusAsync?.({volume: 0});
}, []);

ah shit.. another android native, volume issue.  @strepanier03 do you have an iOS or any other new bug GH I can trade ya with?  (cuz I don't think I can test in browserstack and I haven't ordered a physical phone for the bank yet)

Will get to soon

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@strepanier03 I found the issue and assigned to you, thx!

I am also unable to repro this on Android/Native using a Google Pixel 6. My version is v9.0.17-0. Going to close this out.


write PCAP handler

Motivation:
Especially with TLS but also without, in real production environments it
can be handy to be able to write pcap files from NIO directly.
Modifications:
add a ChannelHandler that can write a PCAP trace from what's going on in
the ChannelPipeline.
Result:
easier debugging in production

SUPER WIP, but wireshark kind of understands what's going on already :)

it actually works properly now. Also supports IPv6 now and even Unix Domain Sockets (using fake IP addresses :) )

@Lukasa / @tomerd  I would love to test this but the best testing strategy (short of writing a PCAP parser (which I won't be doing 😬)) is to also add the bash integration test framework from swift-nio to this repo and just running tcpdump -r FILE -XXX and then testing certain things...
Any better ideas?

I think that idea is fine tbh.


Split readme and avoid most broken links

Largely avoids https://github.com/nrf-rs/nrf-hal/issues/375, just the license file links are broken now.
bors r+

bors r+


Hotfix to remove a duplicate menu item in vscode command palette

Oops I messed up during merge conflicts

[x] Does the PR description accurately reflect the changes made?
[ ] Do the commit messages accurately reflect the changes made?
[x] Is the changelist for this pull request under ~200 lines? (Excepting automatically generated code and package installations)
[x] Does the code follow the coding style guidelines that we have set up?
[ ] Does the coder include unit tests for his functions?
[ ] Does the QA who reviews the code include his unit tests for all the functions?
[ ] Is there a documentation in place if the functions is related to how users build, test, interact with, or release code?

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


PR Links Using Old URL Format

The links to the PRs link to the old DevOps URL format.  (https://[account].visualstudio.com/)
Steps to reproduce the behavior:

Go to https://dev.azure.com/[account]/AS/_apps/hub/caribeiro84.pull-request-manager-hub.view
Click on any PR name link
New browser window opens up in https://[account].visualstudio.com/ format.

Expected behavior
The new window that opens up should be in the new format (https://dev.azure.com/[account]
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 84

Hello @kyleherzog
Thanks for the inputs. The extension is based on the primary URL set on the Org's settings where it's being used the old or new URL scheme. Could you please confirm which one is it set for your account?
Thanks a lot

Didn't know that setting existed. That fixed it. Thanks!

You are welcome @kyleherzog - don't forget to give your rating to the extension in the marketplace, it helps us to improve it :-)