Anitlockout rule opens ports on WAN interface

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Under some circumstances the anti lockout firewall rule chooses a WAN interface and then WebGUI (ports 80,443) and SSH (port 22, if enabled) are accessible on the WAN! That is for sure not desired behaviour!
To Reproduce
Steps to reproduce the behavior:

install a fresh OPNsense on a host with 4 NICs
create a 2nd WAN interface (WAN_NEW)
create a 2nd LAN interface (LAN_NEW) and an appropriate "allow" firewall rule
at this point verify that both WANs have no open ports
delete the old WAN and LAN interfaces
reload all services
check the WAN again for open ports

=> Now port 80 and 443 are open on WAN (and 22 if SSH access was enabled)
Note: The order of creation of WAN_NEW and LAN_NEW is important: WAN_NEW first, then LAN_NEW
Expected behavior
The anti lockout rule should never apply to a WAN interface.
Describe alternatives you considered
Enabling the setting "Disable anti-lockout" in Firewall/Settings/Advanced prevents this from happening, of course. This will be my default setting from now on.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.1.3_1-amd64
FreeBSD 13.2-RELEASE-p10

And that is exactly why the machine shouldn't guess!
I found out the hard way, suddenly my firewall was open, even though I did not make any changes to the Firewall rules. It was simply because I made changes to my interfaces and then a default(!) setting kicked in opening ports on WAN.
That is quite unexpected. Choosing any interface is actually unexpected. The setting could easily be made more robust:
Instead of a checkbox it could be a select box where one can select the interface that the rule shall apply for. By default it is LAN, nothing selected means disabled and if someone tries to delete the selected interface a warning could appear thatg this will disable the anti lockout rule.
No more guessing, no surprises. So what do you think?
I know I can disable it (I wrote that) and I have now. But this is a default setting and it was in its default state all those years I have been using OPNsense...
P.S.: What does the "support" label mean?

If we change the behaviour a lot more complaints of people being locked out will follow. I don’t see a way out of this as you try to indicate.

As all rules that apply are visible on the interface in question, it shouldn't be needed to change anything here. Offering people a choice to which interface it applies basically is the same as offering the option to disable it, with the added bonus of having people locked out before they're able to change the setting.
I don't mind extending the help text if it's not clear enough how this works now, the feature itself is there for good reasons (I don't hear anybody volunteering offering free support to all people who managed to lock themselves out).

I cannot believe you two guys. You worry more about locked out complaining users than an open port on the WAN side? And as a workaround you suggest to me to switch off that very rule so that exactly that what you fear may happen: I may eventually lock myself out and complain?
I never questioned the sense of the anti lockout rule, in fact, I want it on. But I do not want it to randomly open ports on WAN. The rule clearly has a bug. Switching the rule off is not a solution. A better help text also not, because both do not fix the root cause of the bug. Fixing the bug is the solution.
So I suggested a way to fix it. But I did not expect we end up discussing the sense of the rule. I expected to discuss possible solutions to the problem and how we can make the rule work 100% correctly at all times. I believe this is possible without too much effort. We are talking about router/firewall software here and a randomly open port is completely unacceptable. Being locked out is also quite uncool.
So:
If you are worried about users being locked out by accident, prevent that from happening. Prevent the removal of the interface that is currently selected by the anti lockout rule and force the user to select a different interface before being able to delete it. Problem solved, no random open ports, no accidentally locked out users and an always properly working anti-lockout rule. Just how it should be.
That is my suggestion and I believe it will work. If not, please explain me exactly why it will not work. It is very well possible that I am not aware of side effects. But please, let's not discuss the sense of this rule, let's discuss possible solutions to a critical bug of that rule.
So up to you:

Ignore the bug and keep things as they are.
Find a solution to the bug. In that case I am willing to have a go at fixing it or at least support with testing.

Awaiting your choice.

Just open a PR and I’ll happily guide you through all the cans of worms you’re going to hit eventually. Maybe that’s more productive than warning you about introducing regressions that are somebody else‘s problem from your POV.
Cheers,
Franco

I dont get the point, you install opnsense and in interface assignment via CLI you are asked about lan and wan interface. The LAN gets anti lockout, the WAN doesnt. This should be intuitive for everyone?

The edge case presented here is complete reassignment through GUI. The lowest OPT1 will be the lockout interface in that case. LAN and WAN only create from console and factory reset.

How about the anti lockout rule deactivates on interfaces that have a non-RFC-1918 address or a GUA?

I have created a PR as requested:

the anti lockout interface is now a select box
the interface can no longer be an inactive interface (the old logic didn't filter for active interfaces and thus may have selected an inactive one...)
the code prevents the user from unassigning/disabling/deleting the interface that is currently being used by the anti lockout rule
the old configuration is being migrated to the new setting (*)

I have successfully tested the following scenarios:

Reset to factory defaults => will choose LAN interface
migrate old configuration with both, antilockout enabled or disabled
-- if it was enabled, the same logic as now chooses an interface (**)
-- if it was disabled, it will stay disabled
delete the selected interface => not possible, error message shows the problem
create bridge, VLAN and GRE, assign and enable them, then choose as antilockout interface, then try to delete it  => not possible, because the current logic already detects that the VLAN, bridge, GRE is already in use
create PPPoE interface, assign and enable it, try to delete it => it is possible to delete the PPPoE interface, the current logic does not prevent to remove an assigned PPPoE interface. Could this be related to https://github.com/opnsense/core/issues/7349?

* The place of the migration code seems wrong. I have seen that it is possible to do config migrations, but I couldn't find the "hook" for the system/webgui model (I also didn't spend much time looking for it...)
** the code is almost the same. I have added a filter for enabled interfaces so that only enabled interfaces will be found.
Please have a look and feel free to make the necessary changes. As you can see I have done quite a bit of testing and so far it works pretty well.

Thanks, at first glance this likely inhibits scope creep and room for regressions going over multiple files and trying to accomplish migration and backwards compatibility but maybe that’s just me. I’ll take a closer look tomorrow.

Simply that being said a more elegant solution would be to generate anti-lockout rules per interface setting although from past experiences rule toggles in interface code have their downsides as well. It would also require fudging values into setup wizards and changing the current anti-lockout behaviour to off by default which… bears the risk ok further lockouts. 😉


Disabled Items still showing in macro rotation

The HoA is no longer needed in Shadowlands so I have unticked the 'Neck' from the rotation. However, once saved and using the macro, the neck is still showing.
You also cannot fully disable it. If you remove the tick and save it, then use the macro, review it and the tick box is gold.[

](url)

First off - the use neck tick box didn’t activate the HoA - your macro needed a line /cast Heart Essence as simply clicking the neck didn’t activate the essence.  You will need to remove that line manually from your macro.
As to it not saving the ticks - I can’t replicate this.  Is it saving any other changes except this?
TimothyLuke

On 28 Nov 2020, at 1:06 am, snips86x<EMAIL_ADDRESS>wrote:

The HoA is no longer needed in Shadowlands so I have unticked the 'Neck' from the rotation. However, once saved and using the macro, the neck is still showing.
You also cannot fully disable it. If you remove the tick and save it, then use the macro, review it and the tick box is gold.[
](url)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Content: Reshuffle RDM

During the content sprint it was suggested to have the topics under "Research Data Management" follow the lables/steps provided in the/a data life cycle graphic. Big topics could still get their own page afterwards. This would require reshuffling content accordingly.
E.g. see the following mockup:

It was also suggested to use the image and steps of (or similar to) the Elixir data life cycle https://rdmkit.elixir-europe.org/data_life_cycle

another example:
https://www.gfbio.org/training/material/data-life-cycle


Feature/add application base

At this point, i dont know how to simulate a user input threw a test and i dont know how to test the console output. We should ask them.

Ups, wrong repo :D


Update deprecated gradle functions

Fix warning API 'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'.
Related to https://github.com/expo/react-native-appearance/issues/26

Still happening in 0.3.3
WARNING: API 'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'.
It will be removed at the end of 2019.
For more information, see https://d.android.com/r/tools/task-configuration-avoidance.
To determine what is calling variant.getJavaCompile(), use -Pandroid.debug.obsoleteApi=true on the command line to display more information.
Affected Modules: react-native-appearance

thanks!

I am still running with 0.3.3 and the deprecated feature is still there, as mentioned by @jose920405.
When do you plan to release a new version of react-native-appearance where the issue is resolved? Maybe 0.3.4 ?


KIC patch version can fluctuate if rescheduled

In the following scenario:

the user deploys KIC using any of our methods (both helm and kustomize are affected), the deployment in the cluster pulls some KIC X.Y tag (major.minor, implicitly pointing to the latest patch release).  :warning: Let's assume that the deployment has more than 1 replica :warning:.
user's k8s nodes pull the X.Y tag which points to X.Y.Z (the latest patch release for the time being)
a few days later, we release a new patch version X.Y.Z+1. The X.Y tag gets reattached from X.Y.Z to X.Y.Z+1.
a few days later, one of the replicas gets rescheduled to a node that does not have X.Y in the cache so it pulls the new image.

In that case some nodes in the cluster have the X.Y.Z image in the cache and other nodes have the X.Y.Z+1 image. This means that, depending on which of the replicas wins the leader election at a given time, the version of KIC running in the cluster will be non-deterministic.
This wouldn't happen if our ImagePullPolicy was Always but it is IfNotPresent now.

Is this not also the case with Always? Still-running replicas on X.Y.Z will not re-pull the image on their kubelet or restart if some other kubelet pulls X.Y.Z+1. Always corrects the issue if you run a rollout restart but not if some individual replica reschedules and the others remain as-is.
This seems like it's just inherent to the use of major-minor tags for image configuration, so if we want that to be viable the onus is on us to ensure that newer patch releases are at least compatible with one another. The meaning of "compatible" is kind of nebulous though, since controller instances don't really interact with one another. You either have:

DB-less, where each controller manages its own proxy instance. Changes that affect proxy configuration manifest as differences in each proxy instance's behavior.
DB-backed, where some arbitrary controller instance manages all proxies' configuration, and the proxy behavior is determined by whichever instance happens to be the leader. This will often be an older version instance, simply because those instances will be longer-lived and will more likely have already held leadership or grabbed it while newer version instances were spawning.

As a result, any change that affects proxy behavior is effectively breaking, even if it's a fix.

Closing as stale, let's re-open if we feel this requires further attention.


Access Denied on Coveralls

The Coveralls report (https://coveralls.io/github/Netflix/falcor) is private. We cannot access it without being logged as a Falcor Maintainer (I think so, but I havn't tested as I'm not a maintainer).

I'll look into whether or not we can reconfigure the existing Coveralls job to allow report access to the now public repo (so we don't lose history).
Worst case, we'll reset up the job off of the public repo.

@geekuillaume Can you let me know if you can get to it now, from the Badge. I can, without being authenticated.

I believe this is fixed (had to contact the Coveralls folks to migrate for us). Feel free to re-open if you still can't get to the reports.

Okay, it's working here too ! Thanks ! :smile:


Fix SQL generation for index and unique fields

Closes: https://github.com/metarhia/metasql/issues/205
Closes: https://github.com/metarhia/metasql/issues/204

[x] tests and linter show no problems (npm t)
[x] code is properly formatted (npm run fmt)
[x] description of changes is added in CHANGELOG.md

Landed in https://github.com/metarhia/metasql/commit/dfe84d7bd408a4d255b5a22d7933e56f892a5095


Not work after upgrade to macOS 12.3 beta

In debug mode, after input "cur" in alfred, the error is as below:
[23:58:55.694] Coinc[Script Filter] Queuing argument '(null)'
[23:58:55.783] Coinc[Script Filter] Script with argv '(null)' finished
[23:58:55.786] ERROR: Coinc[Script Filter] Code 127: /Users/kamus/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/DF280CF6-E1C2-4C73-9803-EB25E1430C46: line 1: python: command not found
[23:59:06.519] Coinc[Script Filter] Queuing argument '(null)'
[23:59:06.597] Coinc[Script Filter] Script with argv '(null)' finished
[23:59:06.600] ERROR: Coinc[Script Filter] Code 127: /Users/kamus/Library/Caches/com.runningwithcrayons.Alfred/Workflow Scripts/1562FAF5-DAD3-4257-B26D-22FC57F9A506: line 1: python: command not found

Maybe the reason is Apple removes Python 2.7 in macOS 12.3 beta, but I did ln -s python3 python, still can't let Coinc works.
❯ which python
/usr/local/bin/python
❯ ll /usr/local/bin/python
lrwxr-xr-x  1 root  wheel  25 Feb  7 22:19 /usr/local/bin/python -> /opt/homebrew/bin/python3
❯ python --version
Python 3.9.9

Thanks for reporting this.
I'm currently on vacation now, I'll take a look whenever I'm available. If you already have ideas on fixing, you can draft a PR.

@kamusis I just uploaded an v2 release candidate, please help test it out. If everything went well, I'll drop the pre-release tag

@tomy0000000 Thank you for the fixing. First of all, all the "cur" command looks perfect now, running smoothly in python3!
but I'm not sure why you decide to check a hardcoding python3 path: /usr/local/bin/python3?
In "V2 migration guide", you mentioned only support homebrew, but on my laptop, python3 is in
❯ which python3
/opt/homebrew/bin/python3

I'm using M1 silicon Macbook Pro, I believed that the default PATH has been changed between homebrew for x86 and for ARM.
My suggestion:
change "cur" script to:
if command -v python3 1>/dev/null 2>&1; then
	python3 main.py convert $1
else
    echo '{
  "items": [
    {
      "title": "Manual Upgrade is required",
      "subtitle": "Hit enter to open migration Guide on GitHub",
      "valid": true,
      "arg": "open,https://github.com/tomy0000000/Coinc/wiki/V2-Migration-Guide",
      "icon": {
        "path": "hints/info.png"
      }
    }
  ]
}'
fi

In workflow environment variables page, add a PATH variables, you can fill both python3 default path for x86 and ARM into it.

BTW: cur-add/cur-rm/cur-arr are also leaved in python not python3.

I'm using M1 silicon Macbook Pro, I believed that the default PATH has been changed between homebrew for x86 and for ARM.

The reason I decided to use the fixed path is to ensure that the python3 being used is indeed provided by homebrew. Therefore, I'm much prefer to hard code the path rather than having user to figure out how to configure.
I adapt [these] from homebrew installation script, which should be good enough to generate dynamic path. This is what I end up having:
UNAME_MACHINE="$(/usr/bin/uname -m)"
if [[ "${UNAME_MACHINE}" == "arm64" ]]
then
  HOMEBREW_PREFIX="/opt/homebrew"
else
  HOMEBREW_PREFIX="/usr/local"
fi

if command -v "$HOMEBREW_PREFIX/bin/python3" 1>/dev/null 2>&1; then
	$HOMEBREW_PREFIX/bin/python3 main.py convert $1
else
    echo '{
  "items": [
    {
      "title": "Manual Upgrade is required",
      "subtitle": "Hit enter to open migration Guide on GitHub",
      "valid": true,
      "arg": "open,https://github.com/tomy0000000/Coinc/wiki/V2-Migration-Guide",
      "icon": {
        "path": "hints/info.png"
      }
    }
  ]
}'
fi

BTW: cur-add/cur-rm/cur-arr are also leaved in python not python3.

That's my mistake, will fix it
I've updated the pre-release, please check it again if you will. :)

UNAME_MACHINE="$(/usr/bin/uname -m)"
check the infra at first is a good method. should be no problem.

I've updated the pre-release, please check it again if you will. :)
I tested the latest version, cur-add/cur-rm/cur-arr are not working, the error still is "python: command not found".
I modified 3 places manually, changed python to python3, now it's OK.

I tested the latest version, cur-add/cur-rm/cur-arr are not working, the error still is "python: command not found".
I modified 3 places manually, changed python to python3, now it's OK.

That is my mistake again, because there is no exception or error detection mechanism built on workflow part, so I did not spot those changes not applying during my own test.
rc3 should fix this issue now :)

Hi tommy, thank you again for the quick response and this amazing workflow 💯
I'll close the issue.


Difficulties to use the options with Windows

Hello,
I have difficulties to use the options with Windows Command Line (for example --dry-run).
I get this error : [InvalidArgumentException] The "û-dry-run" directory does not exist.
What is the correct syntax ?
Could you give an example of a command using --dry-run for Windows ?
Thanks,
P.LEBRUN

Hi, unfortunately no, I have no experience with Windows.


orf:oe1 has changed links

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.04.28. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.04.28

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[xxx ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

orf:oe1 was fine until yesterday (28.4.2017) - then they changed the links (and perhaps also the data structures?) - youtube-dl does not work any more.
example:

youtube-dl "http://oe1.orf.at/programm/20170428/468721
[orf:oe1] 20170428: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 500: Internal Server Error (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...would be fine if you could adapt to the new formats.

not fixed in the newest version 2017.05.01
two example links:
http://oe1.orf.at/player/20170429/468774
http://oe1.orf.at/programm/20170429/468772
possible that it is similar to orf:fm4 now
changes are necessary in youtube-dl/youtube_dl/extractor/orf.py

Yes, it's the same as orf:fm4. I submitted #11643 but haven't found the time to finish it so far. Feel free to contribute :)


compile and shaderc fixes

compiling on non-home computer was showing some issues when running shaderc on all examples. plus gnuc version issue with the trivially copyable.
you probably have better idea on the string matching, idk what the intent is but my hack fixes the issue.
essentially the char ch = *(ptr.getPtr() - 1); was looking at the memory outside the string, and by blind luck it seems that memory isn't usually alphanumeric, and so hence it passes.

@bkaradzic this is still an issue on master for linux.
fix:
#if _GNUC_VER > 0 && _GNUC_VER < 501
		return __has_trivial_copy(Ty) && __has_trivial_destructor(Ty);
#else
		return __is_trivially_copyable(Ty);
#endif

well I guess updating gcc version is the fix too.


Add python linter/formatter checks

The group chose python to implement the application.
That means we need to check the python code for potential issues each time something is added to the repository.
The goal of this task is to add automatic code checking. Consider using yapf or flake8.
For example you could run:
python3 -m yapf -p -i <list of python files>
test $(git status --porcelain | wc -l) -eq 0 || { git diff; false; }

in the CI.
This depends on #2.

Added Python linter, we used the provided yapf code.
Thanks.


"Extra" collapsible arrow icon?

Hi there! For some reason whenever I use the collapse parameter an extra arrow will show up, just like the one in collapsible headings:

I believe this isn't the expected behaviour, as per the illustration on the plug-in page:

I've tried the normal theme and also different ones, but the issue persists. My codeblock has nothing exceptional typed in it, so I'm not sure what could be causing this.

This is typically caused by having an old installer version. Can you try redownloading Obsidian and reinstalling it?

That did it! Thank you (:

Great news!


Toggle Mod Off

Is there an option to temporarily disable all effects at once? Not disabling each individually, but essentially toggling off the dispatcher or toggling off the effect activation timer. That would be nice.

That's awesome to hear!
On Thu, Jun 29, 2023, 10:37 Goorakh @.***> wrote:

Currently this feature is only in the debug build of the mod, only reason
I didn't put it in the release build is that I just didn't think anyone
wanted to have it. This will be added in the next mod update, whenever that
will be.
—
Reply to this email directly, view it on GitHub
https://github.com/Goorakh/RiskOfChaos/issues/8#issuecomment-1613299930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAQRLIXRCWEDKPRSPOPCCXLXNWHLBANCNFSM6AAAAAAZD64UMY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Feature added as of version 1.8.0


fix dataclass module changing in deps

Ensure that changes in the module without changes in the parameters triggers a re-run.

Probably don't want the zntrack.json to be listed in dvc params show - revert to adding the module to params.yaml as a single entry.


Update package and sample resources for 5/14 ig update

As reported, changes made to sample resources in the IG (and a small structure definition change) occurred, so updating kit to hold the latest versions of all relevant files.

This should be deployed now @ljtucker

Thanks for getting it through!


nvcc fatal   : A single input file is required for a non-link phase when an outputfile is specified

I'm a beginner about this,and when I was compile the gemm_op.so library,I was caught in a problem.
when i run make in the directory,there is a mistake as:
nvcc -std=c++11 -c -o obj/xnor_gemm_kernel.cu.o src/xnor_gemm_kernel.cu.cc -I  -D GOOGLE_CUDA=1 -x cu -Xcompiler -fPIC --expt-relaxed-constexpr --Wno-deprecated-gpu-targets nvcc fatal   : A single input file is required for a non-link phase when an outputfile is specified Makefile:2: recipe for target 'all' failed make: *** [all] Error 1
I wonder if its because my win system.But on my friends' linux computer it's also unworkable.
My environment is:

windows10
gcc version 6.3.0 (MinGW.org GCC-6.3.0-1)
python 3.6 & python 3.5
tensorflow 1.2.0
Cuda compilation tools, release 8.0, V8.0.60

Thanks for anyone who can give me some advices

you should set the variable ${CUDA_ROOT}, it works for me.


Javascript support

Tracking the issue of javascript support in the scripting framework
Consider one of the JSR 223-compliant JS engines: Nashorn or Rhino. Nashorn is kinda newer.
Some information can be found here: http://stackoverflow.com/questions/22502630/switching-from-rhino-to-nashorn

I just did a little more research those engines. It looks like Nashorn has two issues: 1) it requires Java 8, 2) it is GPL with library exception -- which might not be compatible with Apache. So we can discard it. Rhino is MPL and is compatible with Apache. We may use it unless there is better choices.

Java script is supported now. The patch is https://github.com/Samsung/GearVRf/pull/375


yarn2 pnp goto definition support

When using a yarn v2 project that uses yarn plug-in-play, it would be nice if coc-definition would jump into the archive that holds the source definition. In pnp, yarn stores project dependencies as zip files which appears to complicate things.
Oddly depending on how I attempt to jump, I get two different behaviors. If I attempt to jump to definition with ctrl-] (with set tagfunc=CocTagFunc), I get E429: File "/zip:/home/shaw/Projects/foo/.yarn/cache/<EMAIL_ADDRESS>does not exist. However, if I run coc-definition, the screen begins to flashes/flickers until I exit neovim.
This was initially opened against here but was told this was a language server issue.
vim version: NVIM v0.5.0-dev (4ed5204bc9d58)
node version: v12.18.4
coc.nvim version: 0.0.80-7642d233d6

Need some help for open zip file in vim.

Neovim is able to open up that file if instead I change the filename to be:
zipfile:/home/shaw/Projects/foo/.yarn/cache/<EMAIL_ADDRESS>i.e., nvim zipfile:/home/shaw/Projects/foo/.yarn/cache/<EMAIL_ADDRESS>works as you would hope; opens the archive and I can view the contents of global.d.ts.
If I just nvim on the zip file, neovim says that it is using zip.vim to view the archive. Presumably that plugin ships with neovim as I did not install it.
So, the path coc is trying to open is close, but :/zip should be zipfile, and there should be a :: instead of / after the .zip.  Course not sure if that method will work within coc.

I had success with adding the following to my Neovim config:
function! OpenZippedFile(f)
  " get number of new (empty) buffer
  let l:b = bufnr('%')
  " construct full path
  let l:f = substitute(a:f, '.zip/', '.zip::', '')
  let l:f = substitute(l:f, '/zip:', 'zipfile:', '')

  " swap back to original buffer
  b #
  " delete new one
  exe 'bd! ' . l:b
  " open buffer with correct path
  sil exe 'e ' . l:f
  " read in zip data
  call zip#Read(l:f, 1)
endfunction

au BufReadCmd /zip:*.yarn/cache/*.zip/* call OpenZippedFile(expand('<afile>'))

This is a slightly modified version of this: https://www.reddit.com/r/vim/comments/euxaml/is_it_possible_to_open_files_in_a_zip_directly/fftbf2u/?context=3

I had success with adding the following to my Neovim config:
function! OpenZippedFile(f)
  " get number of new (empty) buffer
  let l:b = bufnr('%')
  " construct full path
  let l:f = substitute(a:f, '.zip/', '.zip::', '')
  let l:f = substitute(l:f, '/zip:', 'zipfile:', '')

  " swap back to original buffer
  b #
  " delete new one
  exe 'bd! ' . l:b
  " open buffer with correct path
  sil exe 'e ' . l:f
  " read in zip data
  call zip#Read(l:f, 1)
endfunction

au BufReadCmd /zip:*.yarn/cache/*.zip/* call OpenZippedFile(expand('<afile>'))

This is a slightly modified version of this: https://www.reddit.com/r/vim/comments/euxaml/is_it_possible_to_open_files_in_a_zip_directly/fftbf2u/?context=3

@BenElgar thanks for the above, really helpful!
I find though I still have instances of the bad buffer names in my buffer list
:ls
  1 #a   "src/index.tsx"                line 1
  3 %a<EMAIL_ADDRESS><EMAIL_ADDRESS>line 4
  6  h<EMAIL_ADDRESS><EMAIL_ADDRESS>line 0

Even with a manual :bwipe [bad buffer name] the buffer reappears only with a new buffer index. Is this something you see?

@BenElgar thanks for the above, really helpful!
I find though I still have instances of the bad buffer names in my buffer list
:ls
  1 #a   "src/index.tsx"                line 1
  3 %a<EMAIL_ADDRESS><EMAIL_ADDRESS>line 4
  6  h<EMAIL_ADDRESS><EMAIL_ADDRESS>line 0

Even with a manual :bwipe [bad buffer name] the buffer reappears only with a new buffer index. Is this something you see?

Yes, I've experienced that. I'm afraid I'm not quite sure why and I haven't spent the time to figure it out. 🙃

Yes, I've experienced that. I'm afraid I'm not quite sure why and I haven't spent the time to figure it out. 🙃

https://github.com/yarnpkg/berry/pull/2598 is merged into upstream. go to definition will works with @BenElgar's snippet or vim-rzip plugin in next release.

Currently I can go to definition once but when I do it again in the same file it will lead me to an empty buffer. Anyone else getting this?

With the change to neovim expecting zipfile://{filename} instead of zipfile:{filename}, go to definition has stopped working for me completely. I wrote this PR in an attempt to make it work again: https://github.com/neoclide/coc-tsserver/pull/360

Maybe unrelated, I'm exploring grafana dev and did yarn dlx @yarnpkg/sdks vim. But all the external imports are not resolving. And tsserver log shows
Using tsserver from: $HOME/.config/coc/extensions/node_modules/coc-tsserver/node_modules/typescript/lib

However, after adding   "tsserver.useLocalTsdk": true, to .vim/coc-settings.json then it all worked


lib/recursiveUpdateUntil: fix code to match documentation

Motivation for this change
The function recursiveUpdateUntil did not produce the expected result for the exact example given in the documentation.
This fixes that and makes the function useable for any predicate that actually looks at the path argument. In current nixpkgs, there is only 1 location that touches this functionality:
https://github.com/NixOS/nixpkgs/blob/75601e10cb30d5220c09c5d0cf2c8ee55fc4b34a/nixos/maintainers/option-usages.nix#L128-L131
I'm not fully sure what that is all about, but since it's maintainer-only I do not expect issues will arise because of this fix, as they probably just assumed this function worked as advertised as well.
$ nix repl lib
Welcome to Nix version 2.0.2. Type :? for help.

Loading 'lib'...
Added 350 variables.

-- this is the exact example from the function's documentation:
nix-repl> recursiveUpdateUntil (path: l: r: path == ["foo"]) {
                   # first attribute set
                   foo.bar = 1;
                   foo.baz = 2;
                   bar = 3;
                 } {
                   #second attribute set
                   foo.bar = 1;
                   foo.quz = 2;
                   baz = 4;
                 }
{ bar = 3; baz = 4; foo = { bar = 1; baz = 2; quz = 2; }; }

-- although the documentation says:
{
    foo.bar = 1; # 'foo.*' from the second set
    foo.quz = 2; #
    bar = 3;     # 'bar' from the first set
    baz = 4;     # 'baz' from the second set
}

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Ping @Profpatsch
I'd rather have the documentation changed instead of the behaviour of the function. These functions might be widely used by other projects, which we can't know of whether it would break anything.

tbh that wouldn’t have happened if the original author spared five minutes to put the example into the tests. :disappointed:
I’m in favour of changing this function to match its documentation, because I don’t think we really need to be bug compatible in this case.
@bluescreen303 can you add a section to the release note file in nixos/doc/manual/release-notes/rl-1809.xml?
I’d like to see the example as a test in lib/tests/misc.nix as well.

Ping?

@Infinisil added the test & release note, what do you say?

@GrahamcOfBorg eval


increase code coverage

I'm splitting into seperate commits, feel free to review seperately.

Some recent cleanup reminded me about this patch. This is very long overdue (can you believe it's been two years?), but I certainly appreciate all the effort you put in, @lukeapage, especially the granularity of the commits. That made it easy to address the bit rot that's occurred. A few improvements offered have since found their way to master through other means, so I've skipped them. I split 494456930b8610b0ede8d7dea5d4d0b3f10418ca into a series of dedicated commits, taking care to preserve authorship metadata. I've also re-worded some of the commit messages to adhere to our contribution guidelines. Finally, one of these changes (fde3952) caught a bug in new code!
Here are the rebased commits in master:

9606805 [[CHORE]] Remove code that will never run.
ebd35ca [[TEST]] Add test for strict violation
3dd4d96 [[TEST]] Test for a catch block without curlies
a120793 [[CHORE]] Remove dead code
7e52e01 [[TEST]] Test for invalid ++ suffix
aa40b2b [[CHORE]] Remove W023 which cannot be reached
94ef687 [[TEST]] Add a test for unexpected break statement
4fa4bc0 [[CHORE]] Remove un-used defaults in functions
051ec36 [[CHORE]] Remove un-needed || "" condition
be02fd7 [[CHORE]] Remove unecessary condition
1867508 [[TEST]] Test untested global options
5b5091e [[CHORE]] Move environment tests to envs.js
20924db [[CHORE]] Remove unnecessary condition
00af182 [[CHORE]] Ignore branch during coverage analysis
c375878 [[CHORE]] Remove dead code
9f007e4 [[CHORE]] Remove unused method, isContext
b7cee0e [[CHORE]] Remove guards for (tokens) property
f3eb555 [[TEST]] Test non-token usage after token usage
17241b0 [[CHORE]] Ignore branches during coverage analysis
fde3952 [[CHORE]] Test polluted Object prototype
9e4ea4c [[CHORE]] Add Windows support for npm commands

So thank you, Luke. Your efforts are improving JSHint even today.


[stable/redis-ha] haproxy init container doesn't wait for service announce

Hello,
Just runned into that bug.
Our config:
deploy on GCP K8S (v1.12.7-gke.10)
3 redis instances
1 haproxy pod

The haproxy pod is in crashloopbackoff due to :
[ALERT] 267/072039 (1) : parsing [/usr/local/etc/haproxy/haproxy.cfg:20] : 'tcp-check expect string' expects <string> as an argument.
[ALERT] 267/072039 (1) : Error(s) found in configuration file : /usr/local/etc/haproxy/haproxy.cfg
[ALERT] 267/072039 (1) : Fatal errors found in configuration.

After investiguate, seems that the init container of haproxy responsive of making the haproxy.cfg did not wait for the announce service to have an IP
even with
spec:
 publishNotReadyAddresses: true

so the line tcp-check expect string REPLACE_ANNOUNCE{{ $i }} is empty (should be the service announce ip)
the init container should at least wait for the service to announce an ip before trying to sed the haproxy.cfg file:
perhaps with something like:
until nslookup {{ $fullName }}-announce-{{ $i }}.{{ .Release.Namespace }}.svc.cluster.local
  do echo waiting for service announce to be ready
  sleep 1
done

Note that our redis are under toleration and nodeSelector settings that could lead to more time to assign the pod to an available node.
Thanks

@cschockaert This is a pretty fair race-condition that hasn't been considered.
That loop would be a nice way around it, but we'd need some form of timeout on that to ensure the container does eventually fail if announce services are not being produced for whatever reason

Sure, do you want me to make a PR?

@cschockaert I'd be very grateful for a PR, if not, I'll try and get it done asap

Ok i'll do it


Can't connect to Polar device

When I try to connect to a Polar device - clicking the card below - nothing happens. I can't connect to the device.

It is currently trying to connect to the device, have you tried turning the Polar on and off?

This worked for me until today, now I have the same issue

This worked for me until today, now I have the same issue

No code has been changed since yesterday, but this could be related to #179 , which @Panosfunk is working on.


Blocking mybbc-analytics.files.bbci.co.uk breaks BritBox for Chromecast

Not sure if this is something suitable to address here, but I've discovered that the inclusion of mybbc-analytics.files.bbci.co.uk on the blocklists breaks the BritBox app for Google Chromecast.
Unlike with the Android (and presumably other) apps, which ignore the failure, the Chromecast app will spin for 30s and then show "something went wrong" unless this host is whitelisted.
Looks like I'm not the first to discover this: https://www.reddit.com/r/pihole/comments/nlhu3y/bbc_iplayer_connection_error_could_this_be_caused/

Thank you for this Effy @ineffyble.
This domain is blocked by several of our list curators.
So this won't change.
This appears to be an issue with BritBox.
Closing.


Tests pushing to production graylog

Currently running unit tests locally is pushing a large number of messages to production graylog, it shouldn't

Underlying issue is that the zocalo config we currently use enables prod logging for the whole program when we activate the environment e.g.
import logging
import os

import zocalo.configuration

os.environ["ZOCALO_CONFIG"] = "/dls_sw/apps/zocalo/live/configuration.yaml"

zc = zocalo.configuration.from_file()
zc.activate_environment("devrmq")

LOGGER = logging.getLogger("Artemis")
LOGGER.setLevel(logging.DEBUG)  # default logger to log everything

LOGGER.info("Test")

Will cause "Test" to be logged to graylog


npm install minidump fail on centos 6

install fail.
uname -a : 2.6.32-431.20.3.el6.mt20161028.x86_64 #1 SMP Fri Oct 28 17:50:35 CST 2016 x86_64 x86_64 x86_64 GNU/Linux
node version: 7.6
npm version: 4.1.2
How to solve this problem?
><EMAIL_ADDRESS>install /home/dragon/crash/node_modules/minidump
> node-gyp rebuild

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
make: Entering directory `/home/dragon/crash/node_modules/minidump/build'
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf/bytereader.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf_cfi_to_module.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf_cu_to_module.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf/dwarf2diehandler.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf/dwarf2reader.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf/elf_reader.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/dwarf_line_to_module.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/language.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/linux/crc32.o
  CXX(host) Release/obj.host/dump_syms/deps/breakpad/src/common/linux/dump_symbols.o
In file included from ../deps/breakpad/src/common/linux/file_id.h:40,
                 from ../deps/breakpad/src/common/linux/dump_symbols.cc:66:
../deps/breakpad/src/common/memory.h: In constructor ‘google_breakpad::PageStdAllocator<T>::PageStdAllocator(const google_breakpad::PageStdAllocator<Other>&)’:
../deps/breakpad/src/common/memory.h:181: error: ‘nullptr’ was not declared in this scope
make: *** [Release/obj.host/dump_syms/deps/breakpad/src/common/linux/dump_symbols.o] Error 1
make: Leaving directory `/home/dragon/crash/node_modules/minidump/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/dragon/.nvm/versions/node/v7.6.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:192:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 2.6.32-431.20.3.el6.mt20161028.x86_64
gyp ERR! command "/home/dragon/.nvm/versions/node/v7.6.0/bin/node" "/home/dragon/.nvm/versions/node/v7.6.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/dragon/crash/node_modules/minidump
gyp ERR! node -v v7.6.0
gyp ERR! node-gyp -v v3.5.0
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm ERR! Linux 2.6.32-431.20.3.el6.mt20161028.x86_64
npm ERR! argv "/home/dragon/.nvm/versions/node/v7.6.0/bin/node" "/home/dragon/.nvm/versions/node/v7.6.0/bin/npm" "install" "minidump" "--save"
npm ERR! node v7.6.0
npm ERR! npm  v4.1.2
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the minidump package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs minidump
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls minidump
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/dragon/crash/npm-debug.log

it use nullptr , c++11 feature, require gcc 4.8, but my gcc version is 4.7. so, i rewrite nullptr => NULL, and it works!


Fix OCaml 4.11 support

This minor patch should probably integrated into 12da2e09ec0d8ee84399b478d3ed5785ed1ae03f using a rebase.

Yes indeed, thanks.

Superseded by #168


[BUG?] Increasing load due blocked/dead processes

Not sure if this is related due Longhorn or Kubernetes but we experience theses issues in different environments, one of them is documented here:
It's maybe related if a pod is terminated and a volume detached.
15 min Load:

Processes Dead/Locked:

Longhorn Version: 1.4.0
lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 11 (bullseye)
Release:        11
Codename:       bullseye

uname -a
Linux theia 5.10.0-20-amd64 #1 SMP Debian 5.10.158-2 (2022-12-13) x86_64 GNU/Linux

k3s --version
k3s version v1.24.9+k3s1 (4dcf0a33)
go version go1.18.9

Processes:
processes.log

A ReadWriteMany volume? If yes, it's fixed in this issue and will be included in the upcoming v1.4.1.

@derekbit Yes, its RWX. Workaround with umount -f did its job.


Field Extensions incorrectly rely on resolver context to determine execution context for their own resolution.

When using a custom field extension on a resolver, the execution context that will be used for the extension resolver depends on the field resolver to make a decision on whether the field extensions resolve or resolve_async is to be used. The decision is made during schema conversion.
On any application running under asgi and exposing the api through AsyncGraphQLView if any resolver uses such an extension and is wrapped with @sync_to_async the extension's resolve will be called instead of resolve_async. This is the case for instance with resolvers exposed by strawberry-graphql-django via it's CUD mutations.
Field extension's resolution precedes the execution of the field's resolver and the above situation does not allow the user to implement asynchronous logic in the extensions resolver.
As a sample use case, I could for example want to have a field extension that will asynchronously gather information from a few third party APIs and then  proceed to execute a mutation wrapped with @sync_or_async to ensure synchronous database access.
Describe the Bug
Reproduction
A minimal reproduction of the bug:
class TestContextExtension(FieldExtension):
    def resolve(self, next: Callable[..., Any], source: Any, info: Info, **kwargs):  # noqa: A002
        return "TestContextExtension SYNC"

    async def resolve_async(self, next: Callable[..., Any], source: Any, info: Info, **kwargs):  # noqa: A002
        return "TestContextExtension ASYNC"

@strawberry.type
class Query:
    @strawberry.field(extensions=[TestContextExtension()])
    @sync_to_async
    def test_context(self, info: Info) -> str:
        return "test_context"

Despite running under asgi and with an asynchronous view the query will return:
{
  "data": {
    "testContext": "TestContextExtension SYNC"
  }
}

Expected behavior
To call resolve_async on the extension instead of resolve.
System Information

Operating system:

Linux localhost.localdomain 6.5.9-1-default #1 SMP PREEMPT_DYNAMIC Wed Oct 25 10:31:37 UTC 2023 (29edc7c) x86_64 x86_64 x86_64 GNU/Linux

Strawberry version (if applicable):

[tool.poetry.dependencies]
python = "^3.10"
strawberry-graphql = "^0.214.0"
strawberry-graphql-django = "^0.24.3"

Additional Context
I did a little bit of poking around to try to trace the origin of the bug. Here are the relevant snippets from strawberry's code base:
from schema_converter.py:
# combine all the extension resolvers
return reduce(
    lambda chained_fn, next_fn: partial(next_fn, chained_fn),
    extension_functions,
    wrapped_get_result,
)(_source, info, **field_kwargs)

from field_extensions.py:
if field.is_async:
    if len(non_async_extensions) > 0:
        raise TypeError(
            f"Cannot add sync-only extension(s) {non_async_extension_names} "
            f"to the async resolver of Field {field.name}. "
            f"Please add a resolve_async method to the extension(s)."
        )
    return _get_async_resolvers(field.extensions)

from field.py:
@cached_property
    def is_async(self) -> bool:
        return self._has_async_permission_classes or self._has_async_base_resolver
@property
    def _has_async_base_resolver(self) -> bool:
        return self.base_resolver is not None and self.base_resolver.is_async

and from resolver.py:
@cached_property
def is_async(self) -> bool:
    return iscoroutinefunction(self._unbound_wrapped_func) or isasyncgenfunction(
        self._unbound_wrapped_func
    )

Hope this helps you track down the reason this is happening. As a side note, when it comes to CUD mutations of strawberry-graphql-django while testing this with a debugger I noticed that base_resolver is always None but that shouldn't affect the reproduction I posted above.
Thank you.

Ok, I did a bit more digging and it would seem all that's needed for the resolver to be properly recognized as async when wrapped with @sync_to_async is a small modification in resolver.py :
@cached_property
    def is_async(self) -> bool:
        return iscoroutinefunction(self._unbound_wrapped_func) or isasyncgenfunction(
            self._unbound_wrapped_func
-       )
+       ) or isinstance(self.wrapped_func, (asgiref.sync.SyncToAsync))


NNDSVD

we need to change the name to FluidBufNMFSeed - we might as well do that here? or do you want me to review that, we merge than change it in SC and Doc before the max translation?

we need to change the name to FluidBufNMFSeed - we might as well do that here? or do you want me to review that, we merge than change it in SC and Doc before the max translation?

I think we should get the shape of the documentation right and then apply a considered name change across all the CCEs in one blow.

ok I'll review as is now but we should change the name before @jamesb93 translates to Max to avoid double work


[Snyk] Upgrade eslint from 8.50.0 to 8.51.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade eslint from 8.50.0 to 8.51.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2023-10-06.

Release notes

Package name: eslint

8.51.0 - 2023-10-06Features

0a9c433 feat: Add --no-warn-ignored CLI option for flat config (#17569) (Domantas Petrauskas)
977e67e feat: logical-assignment-operators to report expressions with 3 operands (#17600) (Yosuke Ota)

Bug Fixes

f976b2f fix: make rule severity case-sensitive in flat config (#17619) (Milos Djermanovic)
0edfe36 fix: Ensure crash error messages are not duplicated (#17584) (Nicholas C. Zakas)
dd79abc fix: eslint-disable to be able to parse quoted rule names (#17612) (Yosuke Ota)
d2f6801 fix: Ensure correct code path for && followed by ?? (#17618) (Nicholas C. Zakas)

Documentation

ee5be81 docs: default to sourceType: "module" in rule examples (#17615) (Francesco Trotta)
1aa26df docs: Add more examples for multiline-ternary (#17610) (George Ashiotis)
47d0b44 docs: Update README (GitHub Actions Bot)
dbf831e docs: use generated og image (#17601) (Percy Ma)
1866da5 docs: Update README (GitHub Actions Bot)

Chores

1ef39ea chore: upgrade<EMAIL_ADDRESS>(#17624) (Milos Djermanovic)
f8c7403 chore: package.json update for @ eslint/js release (ESLint Jenkins)
2665552 test: fix flat config linter tests to use Linter in flat config mode (#17616) (Milos Djermanovic)
7b77bcc chore: Refactor CodePathState (#17510) (Nicholas C. Zakas)
bc77c9a chore: Document and refactor ForkContext (#17566) (Nicholas C. Zakas)
24e1f14 chore: Refactor and document CodePath (#17558) (Nicholas C. Zakas)

8.50.0 - 2023-09-22Features

27d5a9e feat: add suggestions to array-callback-return (#17590) (Tanuj Kanti)
f9082ff feat: flat-rule-tester make sure default config always matches (#17585) (fnx)
83914ad feat: Implement SourceCode#applyInlineConfig() (#17351) (Nicholas C. Zakas)
22a5582 feat: add rule no-object-constructor, deprecate no-new-object (#17576) (Francesco Trotta)
85a3d9e feat: allowVoid option in array-callback-return (#17564) (Tanuj Kanti)

Bug Fixes

cc4d26b fix: Ensure deprecated context.parserServices warns (#17593) (Nicholas C. Zakas)
1ea4cfb fix: Ensure all RuleTester tests all deprecated context methods (#17587) (Nicholas C. Zakas)
aa1b657 fix: wrong suggestion and message in no-misleading-character-class (#17571) (Yosuke Ota)

Documentation

1800537 docs: Fix and standardize JSX code examples (#17591) (Francesco Trotta)
48a44a7 docs: Add correct/incorrect tags to prefer-arrow-callback (#17589) (Francesco Trotta)
20893d4 docs: fix incorrect tag's place (#17575) (Tanuj Kanti)
bd7a71f docs: Update README (GitHub Actions Bot)

Chores

f8a8a2d chore: upgrade<EMAIL_ADDRESS>(#17599) (Milos Djermanovic)
38ada6d chore: package.json update for @ eslint/js release (ESLint Jenkins)

    from eslint GitHub release notes

Commit messages

Package name: eslint

f079382 8.51.0
e8235e5 Build: changelog update for 8.51.0
1ef39ea chore: upgrade<EMAIL_ADDRESS>(#17624)
f8c7403 chore: package.json update for @ eslint/js release
f976b2f fix: make rule severity case-sensitive in flat config (#17619)
0edfe36 fix: Ensure crash error messages are not duplicated (#17584)
ee5be81 docs: default to `sourceType: "module"` in rule examples (#17615)
dd79abc fix: `eslint-disable` to be able to parse quoted rule names (#17612)
d2f6801 fix: Ensure correct code path for && followed by ?? (#17618)
2665552 test: fix flat config linter tests to use Linter in flat config mode (#17616)
1aa26df docs: Add more examples for multiline-ternary (#17610)
47d0b44 docs: Update README
dbf831e docs: use generated og image (#17601)
0a9c433 feat: Add `--no-warn-ignored` CLI option for flat config (#17569)
1866da5 docs: Update README
7b77bcc chore: Refactor CodePathState (#17510)
977e67e feat: logical-assignment-operators to report expressions with 3 operands (#17600)
bc77c9a chore: Document and refactor ForkContext (#17566)
24e1f14 chore: Refactor and document CodePath (#17558)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

We're currently processing your upload.  This comment will be updated when the results are available.


RoleAssignment documentation 404 Not Found

On Azure SDK for Python Docs, if you search for "roleassignment" the follow appear

Clicking on these returns a 404 Not Found. See here for an example link: https://docs.microsoft.com/en-us/python/api/azure.mgmt.authorization.models.RoleAssignment?view=azure-python

@dend

@lmazuel @billpratt ACK. We are working on fixing this - stay tuned.

@dend any updates?

@dendeli-msft any updates?

@logachev we are re-indexing the content, and I will update you when it's done!

@dendeli-msft , any update on these docs? FYI @logachev @stefangordon


Support choice of sip or sips scheme for outbound gateway using TLS

Currently when we add an outbound gateway we can choose the protocol, as per below:

However, when we choose TLS or TLS/SRTP we always then use the "sips" scheme.  This signifies end-to-end encryption.  Some carriers though, because they are only using encryption on the leg of the call to us, either prefer or require that we use the "sip" scheme.
Therefore, we need an additional checkbox on outbound gateways that is labeled "Use sips scheme".  If not checked, we should default to using "sip", both if/when registering and sending OPTIONS pings as well as outbound calls

The - https://github.com/jambonz/sbc-outbound/pull/136
Does not fix the above issue.

Hi @mercuryyy
I'm sorry that I missed your comment, could you please attach some log or tell us how to reproduce the issue?


[FLINK-16803][hive] Need to make sure partition inherit table spec wh…

…en writing to Hive tables

What is the purpose of the change
When inserting to a partition, Hive will update the partition's SD according to table SD. For example, consider the following use case:
create table foo (x int,y int) partitioned by (p string);
insert overwrite table foo partition (p='1') select * from ...;
alter table foo set fileformat rcfile;
insert overwrite table foo partition (p='1') select * from ...;

The second INSERT will write RC files to the partition and therefore the partition SD needs to be updated to use RC file input format. Otherwise we hit exception when reading from this partition.
Brief change log

Add new interface to alter partition in TableMetaStore.
Alter existing partition in PartitionLoader.
Add test case.

Verifying this change
Existing and added test cases.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation
NA

cc @JingsongLi

@flinkbot run travis

PR  rebased.
@JingsongLi Please let me know if you have further comments.


fix(Link):  mergeProps  shouldn't override user props

Currently if i will pass activeClass prop that will be overwritten by default value - active

Thanks a lot! LGTM


Include in Third-Party Providers list

This is great. Should it be listed on:
https://github.com/thephpleague/oauth2-client/blob/master/docs/providers/thirdparty.md

Hey there,
Thanks for the interest,  I have created a PR for this change,
https://github.com/thephpleague/oauth2-client/pull/588

The PR has been accepted and the provider is now on the list. 👍


traffic lights or traffic controllers?

the repo name referes to traffic lights, whereas the file sxl_traffic_controller.md referes to traffic controllers. we should choose one or the other and be consistent.

other options:
traffic light controller
tlc

fixed in 1.0.15-draft


Fixed shell color code of "Blue"

This is now merged (without changes to the single-include version) to the master, closing the PR.


Operator tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@cf5717b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage        ?   20.44%
  Complexity      ?       14
=======================================
  Files           ?       11
  Lines           ?      225
  Branches        ?       17
=======================================
  Hits            ?       46
  Misses          ?      173
  Partials        ?        6

Flag
Coverage Δ
Complexity Δ

unittests
20.44% <0.00%> (?)
14.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5717b...ea347ce. Read the comment docs.


At the LogIn page a link to reset the password is needed to support the use case someone forgot it

Duplicate. see: https://github.com/ASRG/asrg.io/issues/206


Handle window resize better

solved from https://github.com/grebtsew/dcDeployControl/commit/7fa447d011c92b6120b6680eb2dccb7045ec9bee


[Android] Fix the issue that video can't play with blob url.

Blob data is stored in the Crosswalk cache, the cache path's scheme is
null, e.g "/sdcard/cache/". In Crosswalk, "ResourceLoadingFilter" has
been implemented to customize the resource url, but for cache path, the
scheme is null which will lead to null pointer exception in
"MediaPlayerBridge.java:setDataSource()", then report media error format.
BUG=XWALK-6004

LGTM. Thanks@wuhengzhi

@lincsoon @fujunwei @xzhan96 @XiaosongWei @axinging PTAL, thanks.

With offline sync with @wuhengzhi , the updated git log and code LGTM. Will merge when trybot green.

can we have a test for this bug fix?

I will investigate how to add test case.

I have tried to implement the test case by TestWebServer, but failed. Then we can implement it by online urls, e.g https://vidolio.com/crosswalk-bug/, but it maybe deleted in future and the internet access was disabled on test device.

What problems did you encounter with TestWebServer? My understanding was that you could put a small video and use IndexedDB to test this. I'd like to land this with a test, otherwise we can't be sure this won't regress in the future.

@rakuco The previous idea is try to get video data from XHR by TestWebServer, then write to indexedDB.
Now with following steps to implement test case:

Open database, write video data to indexedDB.
Open database, read video data from indexedDB.
Verify the play status.
@halton PTAL again.
Thanks.

LGTM, will merge after trybot green.


Note the preferred way to include non-MD5 hashes

Done as per the discussion on #85.

Oh, I interpreted your proposal as key:value, e.g.
"sha1": "97bd38305a81f2d89b5f3aa44500ec964b87cf8a" rather than
"hash": "sha1:97bd38305a81f2d89b5f3aa44500ec964b87cf8a"
I've updated the pull request to do it the latter way.

Perfect - thanks! Merging now.


Add a fileClass field that is a Select from files with a specific tag

So, I'm trying to make life easier by using Metadata Menu to allow me to select from a list of files tagged with a specific tag when I create a certain type of note.
For example, with I create a new "deal", I want to have a SELECT field type called "site" where I can select from a list of my notes that are tagged with #site.
I'm no good with Dataview yet, so I'm failing to understand how to get this to work correctly.

Figured it out... Based on the example text in that input, it should be p => p.file.name, not p.name. Once I updated that, this modal worked as expected!


What i need to do now

Showing All Issues
Check dependencies
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.

I installed Alamofire  using Cocoapods and have the same error.
my Podfile
use_frameworks!
target "eWayCRM" do
pod 'Alamofire', '~> 4.0'
end

Have same issue for Alamofire Version 4.0.1

Please, check this reference: https://github.com/Alamofire/Alamofire/issues/1639

Could this cause the problem? CocoaPods are still in release candidate 2, I am waiting for stable 1.1.0 version.
kolisko$ pod --version
1.0.1

You need to use the CocoaPods 1.1.0-rc.2 release to use Alamofire 4.0.0+. You can install this version using gem install cocoapods --pre.


BUG: linalg: fix handling of complex matrices in solve_sylvester

Nils Wagner reported a problem with solve_sylvester on the SciPy-Dev mailing list.  This should fix it.

This test coverage is far more thorough.  Sorry for the problem with complex cases. I never work in the domain myself, so when I did write the original code for it, complex cases were an afterthought.

Thanks, merged in e77f24a


fcmClient.send(DataMulticastMessage) throwing NoSuchMethodError.

I am trying to use version 2.4 of FcmJava to post a DataMultiCastMessage and the following error is being thrown.
java.lang.NoSuchMethodError: org.apache.http.client.methods.RequestBuilder.post(Ljava/lang/String;)Lorg/apache/http/client/methods/RequestBuilder;
at de.bytefish.fcmjava.client.http.apache.DefaultHttpClient.buildPostRequest(DefaultHttpClient.java:128)
at de.bytefish.fcmjava.client.http.apache.DefaultHttpClient.internalPost(DefaultHttpClient.java:98)
at de.bytefish.fcmjava.client.http.apache.DefaultHttpClient.post(DefaultHttpClient.java:195)
at de.bytefish.fcmjava.client.FcmClient.post(FcmClient.java:97)
at de.bytefish.fcmjava.client.FcmClient.send(FcmClient.java:53)

Update.  After debugging for a bit the issue seems to be my apache httpcomponents version (4.3) the constructor for RequestBuilder.post in version 4.3 does not take arguments and the version first introduced a method to do that is 4.4.  I upgraded to 4.4.1 and now I am getting ssl verification errors but I am further along.
de.bytefish.fcmjava.http.exceptions.HttpCommunicationException: Error making POST Request
at de.bytefish.fcmjava.client.http.apache.DefaultHttpClient.post(DefaultHttpClient.java:197)
at de.bytefish.fcmjava.client.FcmClient.post(FcmClient.java:97)
at de.bytefish.fcmjava.client.FcmClient.send(FcmClient.java:53)
at com.powerupcharger.app.integration.charger.FirebaseTest.test(FirebaseTest.java:29)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
at org.testng.internal.MethodInvocationHelper$1.runTestMethod(MethodInvocationHelper.java:200)
at org.springframework.test.context.testng.AbstractTestNGSpringContextTests.run(AbstractTestNGSpringContextTests.java:171)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.testng.internal.MethodInvocationHelper.invokeHookable(MethodInvocationHelper.java:212)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:707)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
at org.testng.SuiteRunner.run(SuiteRunner.java:254)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
at org.testng.TestNG.run(TestNG.java:1057)
at org.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:72)
at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:127)

Caused by: javax.net.ssl.SSLPeerUnverifiedException: Host name 'fcm.googleapis.com' does not match the certificate subject provided by the peer (CN=*.googleapis.com, O=Google Inc, L=Mountain View, ST=California, C=US)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:465)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:395)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:353)
at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:134)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:353)
at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:380)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:107)
at de.bytefish.fcmjava.client.http.apache.DefaultHttpClient.internalPost(DefaultHttpClient.java:98)
at de.bytefish.fcmjava.client.http.apache.DefaultHttpClient.post(DefaultHttpClient.java:195)

Final update.  I upgrade httpclient again to 4.5.3 and everything seems to be working fine now.  Might be worthwhile to include the minimum httpclient version required for this library in the README since it took me a bit of digging to get to the bottom of this.

Thank you very much for your detailed analysis and great it works. 😎 Yes, I will add a note to the README on the top, which is stating the minimum Apache HttpClient Version, when I get home next week. 👍

@scottcarter87 In the Maven POM I have defined the Apache HttpComponents Version 4.5.2. Apparently Maven picked a Version Number lower than it. 🤔 Do you happen to know how I have to define the Maven POM, so that this doesn't happen? My Maven skills are limited. 😳

@bytefish Sorry for the slow response.  You will want to update your dependency management section in the top level pom with the version of Apache HttpClient and then define that as a dependency in your sub modules without a version so it inherits from the parent pom.  That should be all you need to do.  Not sure if this would break some people projects though since this could effectively cause 2 versions of Apache HttpClient to be installed if somebody had a project like mine where spring boot starter pulls in Apache HttpClient for me and needed to be overridden.  The other option would be to change your code to use the noarg constructor for RequestBuilder.post which will cover a wider range of versions of Apache HttpClient.  Not sure if there would be other issues with doing that though.  Hope this helps.

@scottcarter87 I don't know. Shouldn't this be done on the user side?
Like it is done here:

https://github.com/ralscha/blog/blob/master/push/server/pom.xml#L59


ListView doesn't render items when set to Horizontal

Description
I created a horizontal ListView. When I first display the component, I cannot see the inner items. When I click (and drag a bit) on the ListView, suddenly all the iteam appears.
Sometimes the component is rendered with 1 item, sometimes with 2, then after dragging over it, all the other appears. There is no consistency in this behaviour.

(if you look at the last of the 3 gif, even by clicking to an external element, seems to trigger a new render.
It does happen with any type of items (Text, Image, Complex View, etc).
Worth mentioning that the ListView is used as categoryHeader inside another ListView
Reproduction
I opened up my entire codebase, so feel free to download and compile.
One example of the implementation is here.
[https://github.com/PolyStyle/ReactNativeMobileClient/blob/master/app/containers/UserProfile/UserProfileContainer.js#L289-L305]
Solution
Haven't figure out this yet :(
When I remove
showsHorizontalScrollIndicator={false}
from the ListView, seems that the time that the component renders properly are higher than the times that it doesn't.
Additional Information

React Native version: 0.34.0
Platform: iOS (not tested in Android)
Operating System: Mac OsX

@nicolabortignon does it still happens if you render it in the renderHeader instead of renderSectionHeader?

hey @brunolemos , thanks for coming back to me,
no, no changes.
here an example with both the same component rendered as renderHeader (first red block) and as renderSectionHeader (second red block).

When interacting for the first time with anything in that 'page' everything renders properly.

Try setting removeClippedSubviews={false} on the ListView

@brentvatne,  unfortunately no, doesn't seams to help

Here another  example of how random is the behaviour

My bad, the change didn't go through while using the hot reload. After restarting the emulator the problem was finaly fixed.
So yes,
adding removeClippedSubviews={false} to the renderSectionHeader rendering function, fixed the problem.
Wonder why, now!

same issue here, but I don't have renderSectionHeader function,
how to fix it?

@Chren, mind sharing your code?
Does it happen in renderHeader? Is the list view wrapped around anything else?

@nicolabortignon
I finally fixed it by just add removeClippedSubviews={false} inside ListView.
However, isn't there memory issue with removeClippedSubviews = false? Since it won't remove subviews even it is scrolled to invisible region, and I have a long list of data.


Request to add additional root certificates

    .add_root_certificate(cert)

Please advise if you would like me to supply the change.

Not adding additional root certificates breaks the app.
Adding additional root certificates to OS breaks the compiler .

I'm curious what is the motivation for this?

The motivation is to avoid breaking the rust compiler and your influxdb2 client.
Elaboration:

Those new to influxdb2 may install influxdb2 OSS locally.

At present, by design:
- rust appears to emit an error and refuses to compile if a self-signed CA has been added to the target.
At present, by design, your client:
- will not connect to the server, unless it trusts the server's CA
- will not accept addtional trusted root certificates to establish trust,
- meaning:
- if the server's CA is self-signed, the CA needs to be installed on the target
- we have a condundrum
it is my recommendation that:
-  we add the ability to allow the client to accept additional certificates so that your client can increase it's "marketshare"

Anyone else having the same issue? I've never experienced this issue even when installing influxdb2 locally or using Docker.
When using Docker sometimes it shows the problem of not having the correct certificate but it can be solved by installing the SSL package.

Since installing a CA certificate is at the network level can't it be handled at the network level? Like by passing in the connection factory that first download the ca certificate.
Anyway this is suspect since I don't believe it should be handled at the library level since CA certificate should be handled at the network level. Pull request is welcome but no guarantee I'll accept it.

I have attached the proposed change above.

Yeah looking at the code, I believe this shouldn't be part of the Influxdb2 library because user is able to achieve the same thing by just instantiating a reqwest::Client and creating an influxdb2::Client manually.

Can you please elaborate?

It sounds like you are saying fork the code base.


refactor: move global config to meta config

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#279  👈
#278
#277
#276
#275
#274
#273
#266
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


[chore](show replica) show replica print path

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run p0

run buildall

run buildall


Add support for accessibility when tapping on rating icon

Before raising issue, first thanks for creating this library. 😃
During usage of library, I found that when talkback is active,

for readonly ratings its accessing child icons as well, instead I think it should read out something like "rated x out of x" on parent view
for tappable icons, it is reading nothing.

Thanks!

ahh! a11y is important and I totally missed it 🤦
Will work on it and update soon .. Thanks for raising the issue

@andrewTaylor2  I have been pretty busy recently. Today only I got some time off to work on a11y.
So reg. a11y.... It was actually a bit tricky as we use background and foreground (colored) icons, So when screen reader is ON, on swipe it was focusing on both icons whereas we want it only on background icons. Else it just focuses and announce same label twice.
But still could manage it, see if you could take a pull the branch and test it.
Also once tapped by user, you may add a custom <Text> component with accessibilityLiveRegion="polite". This will announce user what he just selected.
Something like:
const [rating, setRating] = useState(0);
...
...
...
return (
  <View style={styles.card}>
    <Rating
      rated={rating}
      totalCount={5}
      ratingColor="#f1c644"
      ratingBackgroundColor="#d4d4d4"
      size={32}
      icon="add-circle"
      direction="column"
      onIconTap={pos => setRating(pos)}
    />
    <Text accessibilityLiveRegion="polite" accessibilityLabel={`Rating selected ${rating} out of 5`}>{rating}/5 (200)</Text>
  </View>
);

and in end for readonly ratings, it would be better if you could wrap it around your custom View and add a11y labels to it. This way you will have full control for readonly ratings.

Thank you for taking time off and working on this issue. I just forked and tested the branch, it working as expected in my android device 🎉

a11y ready release v5.3.4

Thanks for release🎊


[bug] Few bugs in 1.0.6

Mod Version (e.g. Fabric 0.3.4):
Minecraft 1.20.4
Fabric 0.15.3
Fabric API 0.91.3
Java 20.0.2
Scriptor 1.0.6
BUGS:

Chalk sometimes don't render when placed on the ground. Though it gets fixed and renders after a restart, the issue still sometimes occurs when trying to place new ones.

This next issue occur when trying to interact with a failed, nested-like Chalk Circle. This was discovered by a friend during a LAN session earlier when he attempted to create a nested-like Chalk Circle similar to the picture below. When he tried to interact with it, the spell failed, resulting in a massive lag spike, bombarding sounds and huge amount of particles.

In fabric, you can make the patchouli_book loot table load only if Patchouli is installed by adding fabric:load_conditions to the patchouli_book loot table. This ensures that the loot table will only load if Patchouli is installed in your game, thereby eliminating the error in the logs: [16:40:38] [Worker-ResourceReload-10/ERROR]: Couldn't parse element loot_tables:scriptor:patchouli_book - Unknown registry key in ResourceKey[minecraft:root / minecraft:item]: patchouli:guide_book. The advancement still works tho without the loot table being loaded when Patchouli is not installed.

{
  "type": "advancement_reward",
  "pools": [
    {
      "rolls": 1,
      "entries": [
        {
          "type": "item",
          "name": "patchouli:guide_book",
          "functions": [
            {
              "function": "set_nbt",
              "tag": "{\"patchouli:book\": \"scriptor:scriptor_guide\"}"
            }
          ]
        }
      ]
    }
  ],
  "fabric:load_conditions": [
    {
      "condition": "fabric:registry_contains",
      "values": [
        "patchouli:guide_book"
      ]
    }
  ]
}

Just committed some fixes based on these reports, thank you. Marked you as a Co-Author for the third fix since I directly used code you included. Thank you again for reporting!


added more details to article

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM! Looks like this has conflicts that can only be resolved on the command line, which I don't feel like learning right now - hey @cmccormack, this might be a good one for some practice with that for you.

Thank you for your contribution.  At this time we have decided not to merge your pull request.  We welcome future pull requests from you.
Reason:

Your Pull Request has conflicts with the master branch and you deleted your forked branch; we are unable to help resolve conflicts.  Please feel free to submit a new pull request forked from the latest freeCodeCamp master branch.

Happy Coding!


[BUG] Using env.reset() and env.async_reset() results in illegal instructions

Describe the bug
env.reset() and env.async_reset() results in illegal instructions. This warrants a better error message.
To Reproduce
import envpool
import numpy as np

# make asynchronous
num_envs = 64
batch_size = 16
env = envpool.make("Pong-v5", env_type="gym", num_envs=num_envs, batch_size=batch_size)
action_num = env.action_space.n
env.reset()
env.async_reset()  # send the initial reset signal to all envs
while True:
    obs, rew, done, info = env.recv()
    env_id = info["env_id"]
    action = np.random.randint(action_num, size=batch_size)
    env.send(action, env_id)
    print(action)

[0 4 0 3 1 1 2 1 0 3 0 3 3 4 4 5]
[2 1 0 2 1 2 4 2 5 0 1 0 2 4 2 2]
[1 5 2 0 5 4 1 2 0 1 2 0 0 3 2 0]
[5 5 4 3 5 0 3 5 5 5 2 5 0 2 0 2]
[1 3 5 3 4 2 4 1 1 5 3 5 1 5 5 1]
[5 4 4 1 4 3 2 0 4 1 1 5 2 4 5 5]
[1 0 1 0 1 3 3 3 2 0 0 3 4 5 0 2]
Illegal Instruction! 69
Illegal Instruction! 8a
Illegal Instruction! 2
Illegal Instruction! 2
Illegal Instruction! 2
Illegal Instruction! 2
Illegal Instruction! 2
Illegal Instruction! [4 1 4 1 2 1 2 2 3 2 4 0 5 4 0 2]
2
Illegal Instruction! e8
Illegal Instruction! 30
Illegal Instruction! 2
Illegal Instruction! 38
Illegal Instruction! 84
Illegal Instruction! a
Illegal Instruction! b9
[1 0 1 4 4 5 3 3 2 1 1 4 3 1 0 0]
[2 5 2 1 0 2 5 0 2 3 1 4 4 0 3 3]
[4 0 3 2 5 2 2 4 4 0 2 2 4 4 0 3]
Illegal Instruction! b2
[3 2 3 0 2 1 0 1 4 2 1 0 3 3 2 3]
[4 5 2 3 1 0 2 5 5 2 2 2 5 5 5 4]
[4 1 2 0 5 2 0 2 4 1 4 2 4 0 4 4]
[0 4 2 0 5 4 4 1 2 4 0 0 1 0 4 4]
[2 1 5 4 3 3 2 5 2 2 0 4 5 4 5 0]
[2 0 5 2 3 3 2 4 1 2 4 2 0 0 0 0]
[0 3 1 2 0 5 2 5 1 3 0 3 2 0 4 5]
[1 0 0 3 2 3 2 1 2 4 0 4 4 4 4 2]
[4 2 5 5 4 1 3 2 4 4 4 0 1 3 0 5]
[5 5 0 3 3 4 0 1 3 4 4 3 2 1 5 3]
[2 1 2 2 4 4 2 4 4 3 3 5 2 1 1 3]
Illegal Instruction! 2

Expected behavior
A better error message should be available like saying env.reset() and env.async_reset() cannot be used at the same time.

[x] I have checked that there is no similar issue in the repo (required)
[x] I have read the documentation (required)
[x] I have provided a minimal working example to reproduce the bug (required)

is this safe to ignore?

No, it is an error you need to care about. By design, envpool never allows users to use multiple reset function calls. You should do either one of the following patterns:
env.async_reset()
env.recv()
env.send(...)
env.recv()
env.send(...)
...

or
env.reset()
env.step(...)
env.step(...)
...

Makes sense. Closing the issue.


docs: mention flag for using software templates on Node 20

Hey, I just made a Pull Request!
This adds a brief note to the docs about a required flag (--no-node-snapshot) for using the software templates with Node 20. There's a bit more detail on the issue in #20661
Closes #20661
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hey, just checking in on this PR again -- I see there's a CI failure but the microsite builds locally for me. I'm happy to dig into it more if it would be helpful


Ranks/scores should also be specified in settings

Currently every visualisation is being defaulted on "Ranks", with the possibility to switch to "Scores". I think it's more important to be able to switch and save this inside the settings, and possibly making the controls available to the end-user.
For example: polling data and football tables you usually want to show as scores, but currently defaults to ranks. Especially in case of sports tables, as they use a different tiebreak system (taking into account goal difference etc).

The setting is still there, it's just under "default view" rather than "axes", which wasn't very intuitive (felt more like somewhere you'd specify axis labels etc). If you didn't see it maybe that section should be further up?
Agree it wouldn't hurt to have a setting to hide or show the ranks switch. Is that what you meant?
Good point about goal difference. Maybe we should support that one day.

Ah, missed that one. Will add a "Hide button"-setting.
Goal difference is probably a rabbit hole, as it's not a consistent system across different sports. Plus you'll then have to support cases where points and goal difference are both equal, etc.


add dockerfile and build.yaml

Great start!
I think next we need:

Add github secrets once quay.io is back up.
Test base image build
Start adding Fortran and other deps


Master

C# signing: Commented code, save PDF when signed, removed unused libs, better console output, improved error handling.
README.md: Fixed spelling mistakes.

Thank you @samuelskottenborg 🙌


Difficulty ordering gift cards

Reported by<EMAIL_ADDRESS>Reason for priority: No customers can book
Steps to reproduce

https://app.getoccasion.com/xp/llihu5a8
Try purchasing a GC

Expected behavior
After selecting the amount, it should ask for me to enter my CC
Actual behavior
It does not ask me for CC
Notes
https://secure.helpscout.net/conversation/698793896

This is not supported, by design.


ProjectReference, Reference, and package creation properties

Fixes #18195
Removes extraneous lines from project file snippets
Fleshes out the package creation and restoration sections

Thanks for the review, Tom!


fixing empty lines and comments in apt.txt

closes #149

Not quite sure why the apt-get test fails :-/

This was a flaky test. Passing now. Thanks, @GladysNalvarte!


Suggestion: separate main.py

I think we should separate main.py to some files like main.py, settings.py etc.

Yes, this has been in my mind for a pretty long time.
There are many lines of code, and things are getting hard to control.
We can separate things like, Settings, Main Window, Various Functions.


wmii needs which

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

While wmii will sort of work without it, it breaks before it
runs any user configuration which requires me to using the windows
key as my modifier.

Thank you


feat: Collpase homework with dl/dt/dd tags

Closes #7
Added dl dt dd tags to homework page to collapse each row into an accordion.

lol you're not going to leave anything for anyone else to do, are you? 😆
This actually isn't the solution I wanted, unfortunately. I know this is the suggestion that was made, but as I mentioned in the issue, what I'd like to do is have the homework page have two tabs, Outstanding and Completed (or something to that effect). Or have completed homework move to the bottom of the list. We could, however, also have the homework items be collapsible (I can see a situation where someone wants to skip over certain homework for a while and would like to hide it in the meantime). But if we do that, it needs two features:

all homework is expanded by default, and
the user's expand/collapse preference for each homework item needs to be remembered, so we'd need DB changes.

I'm going to update the issues to reflect that there are two possible feature improvements (somehow segregating the completed items, and making homework collapsible). If you'd like to go ahead with this one, you can link the PR to the new issue.
I'll leave this open for the moment until you decide if you'd like to go ahead with it or not.

Closing this as there's been no further activity.


How to Display Event Titles instead of color dots

Bug description / Feature request:
Link to minimally-working plunker that reproduces the issue (starter template: http://plnkr.co/edit/LE4F4U7AnnD3tjM9ZH4G?p=preview)
Versions
Angular:
Calendar library:
Browser name and version:

The short answer is you can't, but if you don't use event end dates you may be able to use a custom month cell template to change how events are displayed, but YMMV.


feat: Optimize bytecode size for pedersen hash

After https://github.com/AztecProtocol/aztec-packages/pull/8798 we are using msm instead of a pedersen opcode. This PR should optimize a bit bytecode size for pedersen implemented in noir, by avoiding vecs and using generic arithmetic instead.

Hmmm that's weird

It's indeed bigger in some of them, but no idea why


Failure deploying container app to existing managed environment (Code=ManagedEnvironmentNotProvisioned)

This issue is a: (mark with an x)

[ ] bug report -> please search issues before submitting
[ ] documentation issue or request
[x] regression (a behavior that used to work and stopped in a new release)

Issue description
I am trying to update the image of an existing container app in the environment and it keeps failing with the following error. I am getting the same error when I try to deploy a new container app into the same environment. This was working just fine as recent as two days ago.
error: Code="ManagedEnvironmentNotProvisioned" Message="The environment '/subscriptions/***/resourceGroups/staging/providers/Microsoft.App/managedEnvironments/***' has not been provisioned successfully."

Steps to reproduce
I am not sure if this can be replicated in another existing environment in the Consumption tier.

Deploy a new or update a container in an already existing environment

Expected behavior
The container app should be updated successfully.
Actual behavior
Error updating the container app:
error: Code="ManagedEnvironmentNotProvisioned" Message="The environment '/subscriptions/***/resourceGroups/staging/providers/Microsoft.App/managedEnvironments/***' has not been provisioned successfully."

Screenshots
I see this (screenshot) in the portal when I open my already existing environment.

Additional context
I came across #433 and left a comment there but I am opening this new issue due to the severity of the problem.
Also, I have not updated anything else about the environment and nothing has been changed in the VNET it is deployed into.

It seems that the provisioningState property for the environment is in Failed state but I don't understand why the environment flipped to a failed provisioning state when nothing about its infrastructure should have changed?

@torosent from the time I opened this issue, I've also created a support ticket through the portal. They may have reached out to you already. Would you still like me to email acasupport?

Also, please make sure your NSGs are following this
https://learn.microsoft.com/en-us/azure/container-apps/firewall-integration

This environment was created in a VNET with that configuration (from the link above) back in October 2022. Nothing has changed about this environment's network security since then. I would like to point out that deployments were fine as recent as two days ago. Just yesterday, trying to deploy an update to the apps in the environment started to fail.

@praneetloke
Did you resolve the issue? I have just been facing the same issue these days.
My container app suddenly throws an error when I create a new revision (for new deploying)
Error code :
ManagedEnvironmentNotProvisioned

I resolved my issue, please read this
https://github.com/microsoft/azure-container-apps/issues/1112#issuecomment-2314355933


Nrfx 5977 extend mbox sample

Print on what board/core sample is executing.
Print how many bytes of data can be sent in the mbox message (show use of mbox_mtu_get_dt()).
Print how many channels are available for incoming and/or outgoing messages (show use of mbox_max_channels_get_dt()).
Add sample configuration 'nrf54h20_app_ppr' where:

cpuapp sends messages to cpuppr vevif channel 15,
cpuppr sends messages to cpuapp bellboard channel 18.

Add sample configuration 'nrf54h20_rad_app' where:

cpuapp sends messages to cpurad bellboard channel 12,
cpurad sends messages to cpuapp bellboard channel 18.

FYI @anangl, @jaz1-nordic, @nordic-piks

This PR will fix/make obsolete following Zephyr issue:
https://github.com/zephyrproject-rtos/zephyr/issues/72661


Comments for export test sources

Description
Comments for export test sources
Fixes #118
Type of change

Documentation update

Testing steps
N/A

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   72.75%   72.75%
=======================================
  Files           9        9
  Lines         378      378
=======================================
  Hits          275      275
  Misses         84       84
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae19b2...cb24fa9. Read the comment docs.


can 'resolve' but not 'get'

I can 'resolve' but cannot 'get' a url.
'get' returns a timeout.
Steps to reproduce
$ lbrynet-cli resolve uri=what
{
"claim": {
"address": "bMavvzXG2XT5GRK4kgQCFop1B5XvHRJPye",
"amount": "1",
...
$ lbrynet-cli get uri=what
{
"error": "Timeout"
}
Expected behaviour
I should download the uri.
Actual behaviour
I get a timeout message
System Configuration
$ lbrynet-cli version
{
"build": "release",
"ip": "***",
"lbrynet_version": "0.10.3",
"lbryschema_version": "0.0.4",
"lbryum_version": "2.7.22",
"os_release": "4.4.0-53-generic",
"os_system": "Linux",
"platform": "Linux-4.4.0-53-generic-x86_64-with-LinuxMint-18.1-serena",
"processor": "x86_64",
"python_version": "2.7.12"
}

LBRY Daemon version: 0.10.3
Operating system: Ubuntu 16.04 derivative (Mint 18.1)

@jackrobison and/or @lyoshenka this is likely a network issue since many others are able to fetch this URI, but I wonder if we could build a tool or add some code to the daemon that debugs/detects network issues.

this is in the error log:
2017-05-26 01:00:00,380 ERROR    lbryum.interface:115: Failed to connect to (2, 1, 6, '', ('<IP_ADDRESS>', 50001))
Traceback (most recent call last):
File "site-packages/lbryum/interface.py", line 110, in get_simple_socket
File "socket.py", line 228, in meth
error: [Errno 111] Connection refused
This is an amazon server.  Is this one of your servers?  I wonder if the firewall is refusing connections from my area?

@lyoshenka @iateadonut looked into this further and thought that we may have a security group rule blocking IPs from certain countries. I don't think we do, but can you confirm? He's interested in helping debug this, you can contact him on Slack under the same name.

I dont believe we're blocking anything based on location. I do know our lbryum server has issues sometimes, and @jackrobison is gonna be working on fixes for it.
@iateadonut the daemon should have several lbryum servers in its list, and should try to connect to other servers if the first one fails. are you seeing that in the logs? does the daemon still work for you despite this error?

The daemon runs well.
The error in the logs that I posted happens when I execute a 'get' command.
Looking at the telnet response, it seems that the server is actively blocking my ip address.

@iateadonut still seeing this? please re-open if so

still doesn't work.
i'll have to do some more testing to make sure i can set it up on a server in the States and watch it work.

@iateadonut did you update to the latest version? Lbry.io/get
Please do so and then post the logs files here


Tests added

@Gummibeer recommended Snapshottests with this package: https://github.com/spatie/phpunit-snapshot-assertions
I added a basic test case. However, I still have to figure out how to test the color display but I'm tired right now. To be continued.

Hi dear,
Nice package, thanks for your efforts, I think the snapshot testing here works as an Integration/Feature test, it still needs to have coverage for some other parts within the Unit Test(like as you mentioned colors or other logics within the command class), if you are ok I can create a PR for Unit Test and cover all of them.

@saeidee That would be really nice. Thank you!

@saeidee see #12 for thisn to be implemented.

@Wulfheart dear, tests added here https://github.com/Wulfheart/pretty-routes/pull/19