Slider crashing on iPhone 5 IOS 12.1

Slider on drag crash. Stay everything blank if drag more than 6 times and sometimes the slide crop in half bellow link to video demonstration.
https://embed-cdn.ziggeo.com/v1/applications/6aee922ad3f285d863ead96ac1676735/videos/5eea62262800459cf5089677c51f6ac6/video.mp4?force_refresh=1578194517073

tiny Slider V2
Safari IOS 12.1

I have the same problem.
iOS allow very limited memory for the browsers (tested on chrome & safari, iOS 13.3), and will simply crash when JS asks too much.
The project I'm working on was using owlCarousel, it allowed less than 30 items before crashing on swipe motion.
With tiny slider, I can go up to 50-60 items before crash (and now only w/ chrome).
I believe you will not be able to do much for this in the library, it's mainly up to apple engineers to get their sh*t together.


Missing markup tags

Markup tags for H2 and H3 missing, same with olist and ulist.

#1 adds h2 and h3, but olist and ulist are still planned features. They were a little more complicated to implement than I thought.
I'll deploy the new version in the coming days!

H2 and H3 addition branch has been deployed and can now be used in app.


[$250] Web - Chat - Notification preferences RHP does not animate smoothly

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.2-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to any chat.
Tap on the chat header.
Tap Notification preferences.
Tap back button.
Repeat Step 4 and 5 a few times.

Expected Result:
Notification preferences RHP will animate smoothly.
Actual Result:
Notification preferences RHP does not animate smoothly.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/2221f261-7ea5-48b5-8591-cf21490554da

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010b485abb3cf759ae
Upwork Job ID:<PHONE_NUMBER>824781554
Last Price Increase: 2024-06-26

Issue OwnerCurrent Issue Owner: @Ollyws

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to  #vip-vsb

@robertjchen confirming this is happening on Staging and not on production
Logs -
logs-2024-06-26 01_30_31.960.txt
Vid -
https://github.com/Expensify/App/assets/22508304/6005a045-e29c-41f7-ac5e-8ac8f75b629c
Unsure where to check to find the offending PR

Thanks! Yeah- it definitely seems to be stemming for a recent change 🤔 Going to tag External to see if someone can spot the issue here 👍

@mananjadhav 👀 on @Krishna2323 's proposal plz

Couple other thoughts...

I'm guessing this is a regression. If we can find that, please link so we can assign the contributor and C+ ( @Krishna2323 , since we marked this Help Wanted if we do find the offending PR and others are assigned, you might be eligible for compensation if your solution is used, that's determined after the PR has hit production for a week)
Is SCREENS_WITH_AUTOFOCUS causing other bugs that could be fixed at the same time? I have no idea, just saw quite a few pop up when I searched.

@parasharrajat @huzaifa-99 another issue that might be related to https://github.com/Expensify/App/pull/44360

Unassigning myself from here.

@mananjadhav if you're unassigning, can you please provide reasoning? thx.
@Ollyws 👀 above please.

@parasharrajat @huzaifa-99 another issue that might be related to #44360

I assumed this is a regression. Looks like it's not.

Great find! Let's go with @Krishna2323 's proposal 👍

Contributor: @Krishna2323 paid $ via Upwork
Contributor+: @Ollyws due $250 via NewDot
Test case, thanks @Ollyws

https://github.com/Expensify/Expensify/issues/414490

$250 approved for @Ollyws


feat(CSTM-CPC-900) Error Handling for Owners

JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-900?atlOrigin=eyJpIjoiMTUxZTEyYTZiMzI2NDAyZThkZDA2YzAyN2Y3YWQ0MDciLCJwIjoiaiJ9
Context:
This story was simply to make the field requisites stricter for Owners. Before, we could input as big as big of a first name as we wished, for example. This may impose a security or reliability risk, so after consulting with the POs, We concurred at 50 characters for the limit. We could also input emojis which will just cause issues in a real life project. Foreign characters aren't accepted anymore since only ASCII characters are accepted. If a user submits a form with unacceptable fields, it will warn the user via a dialogue box that they must respect the ASCII formatting rule.
Changes
ADDED 50 character maximum to all form fields for Register and Edit Owner
ADDED ASCII only text to all form fields for Register and Edit Owner
FIXED Grammar
Before and After UI
BEFORE (See large fields, emojis, invalid formats, etc)

AFTER (Uniform information, less possibility of errors down the line, etc)

Sad I can't put emoji's anymore but a necessary change. The Max length may be an issue if someone has a long name

name 1 human with 50 characters in their first or last name

Sad I can't put emoji's anymore but a necessary change. The Max length may be an issue if someone has a long name

name 1 human with 50 characters in their first or last name

According the Guinness World Records, this persons name is 700+ Characters. We don't want our system to discriminate someone based off the length of their name.
Adolph Blaine Charles David Earl Frederick Gerald Hubert Irvin John Kenneth Lloyd Martin Nero Oliver Paul Quincy Randolph Sherman Thomas Uncas Victor William Xerxes Yancy Zeus Wolfeschlegelsteinhausenbergerdorffwelchevoralternwarengewissenhaftschaferswessenschafewarenwohlgepflegeundsorgfaltigkeitbeschutzenvonangreifendurchihrraubgierigfeindewelchevoralternzwolftausendjahresvorandieerscheinenvanderersteerdemenschderraumschiffgebrauchlichtalsseinursprungvonkraftgestartseinlangefahrthinzwischensternartigraumaufdersuchenachdiesternwelchegehabtbewohnbarplanetenkreisedrehensichundwohinderneurassevonverstandigmenschlichkeitkonntefortpflanzenundsicherfreuenanlebenslanglichfreudeundruhemitnichteinfurchtvorangreifenvonandererintelligentgeschopfsvonhinzwischensternartigraum.

Looks great, I would suggest thinking about having a way for owners to hold more than just the address and the city, maybe add province/state as well.

Good suggestion. i'll see what i can do in proceeding stories, family


Import error with Python 3.13

adtl does not import under Python 3.13 (latest release version). This appears to be due to the new stricter frozen dataclass hierarchies. In particular, the issue seems to relate to pint, and if you import pint you get a very similar error to the one seen below (see https://github.com/hgrecco/pint/issues/ 1969; note that the pint issue was raised in April).
Python 3.13.0 (v3.13.0:60403a5409f, Oct  7 2024, 00:37:40) [Clang 15.0.0 (clang-15<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import adtl
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    import adtl
  File "/Users/jsb/Desktop/ddd/venv/lib/python3.13/site-packages/adtl/__init__.py", line 18, in <module>
    import pint
  File "/Users/jsb/Desktop/ddd/venv/lib/python3.13/site-packages/pint/__init__.py", line 18, in <module>
    from .delegates.formatter._format_helpers import formatter
  File "/Users/jsb/Desktop/ddd/venv/lib/python3.13/site-packages/pint/delegates/__init__.py", line 12, in <module>
    from . import txt_defparser
  File "/Users/jsb/Desktop/ddd/venv/lib/python3.13/site-packages/pint/delegates/txt_defparser/__init__.py", line 12, in <module>
    from .defparser import DefParser
  File "/Users/jsb/Desktop/ddd/venv/lib/python3.13/site-packages/pint/delegates/txt_defparser/defparser.py", line 10, in <module>
    from . import block, common, context, defaults, group, plain, system
  File "/Users/jsb/Desktop/ddd/venv/lib/python3.13/site-packages/pint/delegates/txt_defparser/common.py", line 23, in <module>
    @dataclass(frozen=True)
     ~~~~~~~~~^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/dataclasses.py", line 1295, in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
                          frozen, match_args, kw_only, slots,
                          weakref_slot)
  File "/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/dataclasses.py", line 1043, in _process_class
    raise TypeError('cannot inherit frozen dataclass from a '
                    'non-frozen one')
TypeError: cannot inherit frozen dataclass from a non-frozen one
>>>

Thanks for raising this @jsbrittain - seems like supporting 3.13 will be blocked until the Pint issue is resolved. I'll mirror what you have done for InsightBoard and add a label to the docs indicating 3.13 is not currently supported.


[v2] zplug update doesn't pull repo's

As I mentioned earlier in #121 (I'm sorry), zplug fails to update my repositories. I'm using Debian unstable.

I seem to have problems updating with zplug (v2):
kevin@kevin-laptop ~ (master↑2|✚3…)
 % zplug status
Fetching the status of packages ...
Packages with from:'local' are skipped.
===
paretje/unisister                     (up to date) 'https://github.com/paretje/unisister.git'
torhve/weechat-matrix-protocol-scriptprintf: %0s: invalid conversion specification
zsh-users/zsh-completions             (up to date) 'https://github.com/zsh-users/zsh-completions.git'
b4b4r07/zplug                         (up to date) 'https://github.com/b4b4r07/zplug.git'
paretje/qutebrowser                   (up to date) 'https://github.com/paretje/qutebrowser.git'
olivierverdier/zsh-git-prompt         (up to date) 'https://github.com/olivierverdier/zsh-git-prompt.git'
rawdigits/wee-slack                   (up to date) 'https://github.com/rawdigits/wee-slack.git'
plugins/pip                           (local out of date) 'https://github.com/robbyrussell/oh-my-zsh.git'
plugins/vi-mode                       (local out of date) 'https://github.com/robbyrussell/oh-my-zsh.git'
===
Finished 2.038882

kevin@kevin-laptop ~ (master↑2|✚3…)
 % zplug update
Updating...          zsh-users/zsh-completions
Updating...          plugins/pip
Updating...          paretje/unisister
Updating...          torhve/weechat-matrix-protocol-script
Updating...          plugins/vi-mode
Up-to-date           zsh-users/zsh-completions                  (0.22s)
Updating...          olivierverdier/zsh-git-prompt
Updating...          paretje/qutebrowser
Up-to-date           paretje/unisister                          (0.24s)
Updating...          b4b4r07/zplug
Up-to-date           plugins/pip                                (0.26s)
Up-to-date           torhve/weechat-matrix-protocol-script      (0.26s)
Up-to-date           olivierverdier/zsh-git-prompt              (0.28s)
Up-to-date           plugins/vi-mode                            (0.29s)
Updating...          rawdigits/wee-slack
Up-to-date           paretje/qutebrowser                        (0.30s)
Up-to-date           b4b4r07/zplug                              (0.30s)
Up-to-date           rawdigits/wee-slack                        (0.32s)

Relevant part of zshrc:
source "$ZPLUG_HOME/init.zsh"

zplug "b4b4r07/zplug", at:v2, hook-build:"zplug update --self"

zplug "olivierverdier/zsh-git-prompt", use:zshrc.sh, hook-build:"zplug clear"
zplug "zsh-users/zsh-completions"

zplug "plugins/vi-mode", from:oh-my-zsh
zplug "plugins/pip", from:oh-my-zsh

# Abuse antigen to keep track of weechat plugins
zplug "rawdigits/wee-slack", use:
zplug "torhve/weechat-matrix-protocol-script", use:

zplug "paretje/unisister", as:command, use:unisister
zplug "paretje/qutebrowser", as:command, use:".venv/bin/qutebrowser", at:paretje, hook-build:"tox -r -e mkvenv && scripts/asciidoc2html.py"

zplug load

In this case the problem occurs with oh-my-zsh (of which 2 plugins are used), but it also happens with others, I just did a git pull of zlug in an attempt to fix. I already udated qutebrowser manually.

I just checked and it still is an issue. I also seem to have the same problem on a Debian stable install. Note the error in the output of zplug update, which seems to come from awk. I'm using gawk, as zplug didn't seem to work at all with mawk.

Thanks for reporting! Just to make sure, the issue is that zplug update doesn't update even though it says Up-to-date, correct?

Indeed, and zplug status does detect the need to update correctly, although there does seem to be a awk issue in zplug status.  What awk implementation do you use?

Okay, thanks. My gut tells me it's this part that's preventing the packages from being updated. I will look into it later today.
There seems to be a problem with mawk where it complains about invalid array tag in cache.awk. I personally use gawk and have found no problem with it. We haven't tested with nawk and other variants, but nawk should work as well.

@paretje This should be fixed with 3534034b2560daefd886d783eae7df1915ae8f30. Please update your zplug and try it out. Let me know if something is still wrong!

It works, thanks!


e2e:chore - test for the information severity flag

- What I did
E2e test for the --information-severity
- How to verify it
run make test-e2e and expected all tests passed.
- Description for the changelog
N/A

Signed-off-by: lucas.bruno<EMAIL_ADDRESS>

When trying to write a more assertive test, using an INFO type vulnerability, I identified that the CLI is not showing this severity and reported what happened in issue #785

Resolve conflicts. @lucasbrunozup


Syntax errors in .github/deployment/queries/CCO_classes_have_BFO_superclass.sparql

The URLs in query CCO_classes_have_BFO_superclass.sparql need to be surrounded by angle brackets:

The two prefix declarations.
The reference to BFO_000001 in the FILTER clause.

@swartik  Very good. PR now open,


Port/order.concept

(I'm just an amateur).
In mathlib port progress, order.concept is a light blue node. I also checked port_status, pull request and Zulip, and it seems that no one is working on it.
So I picked it up and gave a try. With some changes I made it build.
TODOs: (** Need help / comments **)
We have theorems that violates naming convention, e.g.:
theorem intent_closure_union (s₁ s₂ : Set α) :
theorem intent_closure_Union (f : ι → Set α) :

#lint errors:
/- The `docBlame` linter reports:
DEFINITIONS ARE MISSING DOCUMENTATION STRINGS: -/
#check @Concept.closure_fst /- definition missing documentation string -/
#check @Concept.closure_snd /- definition missing documentation string -/

/- The `simpNF` linter reports:
SOME SIMP LEMMAS ARE NOT IN SIMP-NORMAL FORM.
see note [simp-normal form] for tips how to debug this.
https://leanprover-community.github.io/mathlib_docs/notes.html#simp-normal%20form -/
#check @intent_closure_Union₂ /- simp can prove this:
  by simp only [intent_closure_Union]
One of the lemmas above could be a duplicate.
If that's not the case try reordering lemmas or adding @[priority].
 -/
#check @extent_closure_Union₂ /- simp can prove this:
  by simp only [extent_closure_Union]
One of the lemmas above could be a duplicate.
If that's not the case try reordering lemmas or adding @[priority].
 -/

start_port.sh created import Order.Concept but I have a feeling that it should be import Mathlib.Order.Concept?

start_port.sh created import Order.Concept but I have a feeling that it should be import Mathlib.Order.Concept?

Definitely; I think you must have run it as ./scripts/start_port.sh Order/Concept.lean, without the Mathlib/ prefix. It's a bug that the script doesn't fail in this case, and manages to continue anyways.

As for the other two linter errors, just comment out @[simp] with --  and add a porting note explaining why.

Abandoned. I'll create a new one as a branch of leanprover-community/mathlib4


Salvage Shuttle Console makes you wait FOREVER (sometimes) before letting you FTL to a planet.

Description

Title says it all. No clue how this seemingly hasn't been reported yet. First started appearing after the shuttle console refactor.
Reproduction

1: Accept an exped
2: Insert disk into shuttle computer
3: Click "Scan" under the "Map" menu on the shuttle console. FTL for the planet should take a while to show up. The time for it to show up can range anywhere between 30 seconds and 10 minutes if you're unlucky.
Screenshots

Additional context

Seems to be caused by the scan gradually revealing objects that are further away.

Duplicate of #26348


Regarding the code

Hi,
Excellent dataset and paper. I'd like to use AMOS for my research and want to reproduce some results in the paper. But I find that codes are removed from this repo.  I would greatly appreciate it if you could provide some code to help me get started.
Best.

Never mind, I find it in the code branch


Do not build with internal SQLite

We do not need sqlite3 session extension anymore, so let's get rid of the internal copy of sqlite and just use whatever is available on the system.
This should also help us to avoid possible database corruption when pygeodiff in QGIS is using its own sqlite copy and that clashes with the normal copy:
https://github.com/lutraconsulting/qgis-mergin-plugin/issues/225
Fixes #105

TODO:

mac compilation with sqlite from homebrew
windows compilation (need to download sqlite - precompiled / chocolatey / vcpkg / conda ?)

let me fix CI in the new PR


Error: Unhandled Exception: 'package:flutter/src/widgets/navigator.dart': Failed assertion: line 2845 pos 18: '!navigator._debugLocked': is not true

I am new in Flutter. I face a problem about Unhandled Exception: 'package:flutter/src/widgets/navigator.dart': Failed assertion: line 2845 pos 18: '!navigator._debugLocked': is not true.
This is my Debug Console:
E/flutter ( 5236): [ERROR:flutter/lib/ui/ui_dart_state.cc(198)] Unhandled Exception: 'package:flutter/src/widgets/navigator.dart': Failed assertion: line 2845 pos 18: '!navigator._debugLocked': is not true.
package:flutter/…/widgets/navigator.dart:2845
E/flutter ( 5236): #0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
E/flutter ( 5236): #1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
E/flutter ( 5236): #2      _RouteEntry.handlePush.<anonymous closure>
package:flutter/…/widgets/navigator.dart:2845
E/flutter ( 5236): #3      TickerFuture.whenCompleteOrCancel.thunk
package:flutter/…/scheduler/ticker.dart:407
E/flutter ( 5236): #4      _rootRunUnary (dart:async/zone.dart:1434:47)
E/flutter ( 5236): #5      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
E/flutter ( 5236): <asynchronous suspension>
E/flutter ( 5236): #6      TickerFuture.whenCompleteOrCancel.thunk
package:flutter/…/scheduler/ticker.dart:406
E/flutter ( 5236): <asynchronous suspension>
E/flutter ( 5236):

I would appreciate any help.

Hi @mycar98765, Thanks for filing the issue. Please share output of flutter doctor -v and a minimal and complete reproducible code sample to investigate the issue further.
Additionally, Please refer to this SO answer and see if this helps solve your issue

This answer didn't help me.

Thanks for the update, In order to investigate further we would need a minimal and complete sample code.
Thanks

onPressed: () {
                      Navigator.pop(context);
                    },

@mycar98765 The above piece of code wouldn't help us to find the cause of the issue. We would need a minimal and complete reproducible code  which we can directly copy and run and it should reproduce the same error as reported in the original post.

On my own, I finally found a solution.

On my own, I finally found a solution. I've been testing my widget to see what's causing the problem. Finally, I found it.

what solution did you find? please share


how to add subtitle

When creating an issue, please ensure that you provide as much information as you can. Issues with a basic description will sadly be ignored as it doesn't help diagnose the issue :(
If you don't help me, I can't help you ¯\_(ツ)_/¯
Here are some common things to include that can help your issue be diagnosed.

[x] react-native-af-video-player version:

[ ] React Native version:

[ ] OS:

[ ] Has this issue already been raised?

[ ] Have you clearly read and understood the Readme?

[ ] Code and explanation to replicate this issue:

[ ] Are there any console logs?

[ ] Include Screeshots / Video:

Hi, this module is good to play video. but i want to show subtitle on the play screen. so can you help me?

This module uses zIndex. Max value is 99.


Proposed API changes

What
Proposed API changes outlined in the swagger spec.
Who can review
Anyone but me.

Closing in favour of updated spec PR: https://github.com/ONSdigital/dp-image-api/pull/33


Unable to execute code action on nightly

When i try to execute any code action by pressing <CR> i get pressended with this error message
neovim version: v0.6.0-dev+364-gec4731d98
E5108: Error executing lua ...me/xanderio/Local/share/nvim/runtime/lua/vim/lsp/buf.lua:605: command: expected string, got nil
stack traceback:
        ...me/xanderio/Local/share/nvim/runtime/lua/vim/lsp/buf.lua:605: in function 'execute_command'
        ...enu/lua/code_action_menu/lsp_objects/actions/command.lua:43: in function 'execute'
        ...acker/opt/nvim-code-action-menu/lua/code_action_menu.lua:107: in function 'execute_selected_action'
        [string ":lua"]:1: in main chunk

Interesting. I just checked the PR list and also the git blame for the vim.lsp.buf module. Nothing has changed. And the code just passes the action from the server to this function (i.e. this data). So either your server returns something awkward, or I interpreted this wrongly as a command and it is rather an CodeAction object. The decision what it is, is made here.
I'm very sorry, but could you maybe add some logging of the raw server data above the line I just linked and post me the output?

Any maybe verify that you can execute the action just by using :lua vim.lsp.buf.code_action() and selecting the same action.

I might can easily fix that by switching the if-else statement and check for all mandatory fields a Command must have and else it is a CodeAction. Actually a CodeAction either has an edit or a command attribute. But both are optional for this or. If your server for a reason I don't understand here sends you a CodeAction without any of those two, I assume it is a Command straight. This assumtion might be wrong.
But in that case the execution of the CodeAction would fail here. I need to double check how the native menu does this...

It works perfectly with :lua vim.lsp.buf.code_action(). Maybe i should have mentioned that i'm working with rust-analyzer.
I'm was just about to add the debug code you mentioned, but your ever fast with your replies and i'm not sure if you still nedd this information :)

The native implementation does actually nothing different.

Oh

It works perfectly with :lua vim.lsp.buf.code_action(). Maybe i should have mentioned that i'm working with rust-analyzer.
I'm was just about to add the debug code you mentioned, but your ever fast with your replies and i'm not sure if you still nedd this information :)

Oh... I'm confused.

Haha, I use rust-analyzer as well. But I barely see commands form it, just code actions of type quickfixed or refactoring. But I'm not too much of a Rust developer unfortunately.

Could you please still add the logging?

I added a print(vim.inspect(data)) before the if statment on line 46.
{
  data = {
    codeActionParams = {
      context = {
        diagnostics = {}
      },
      range = {
        end = {
          character = 14,
          line = 1
        },
        start = {
          character = 14,
          line = 1
        }
      },
      textDocument = {
        uri = "file:///usr/home/xanderio/Projects/testy/src/main.rs"
      }
    },
    id = "make_raw_string:RefactorRewrite:0"
  },
  kind = "refactor.rewrite",
  title = "Rewrite as raw string"
}

I should properly also mention that im currently using the lastest master of rust-analyzer.

Aaaaah. This is an action that needs to be resolved. It uses the data field. Nice. This is why I wanted to have feedback. I never had this and somehow I forgot/missed that this exists.

Alright, let's see how fast I can fix this.

It would be helpful if I could have local setup where I can trigger your case. Is this testy project public? The cursor position I can see.

Else I think I have a straight forward solution which should just work. I would open a PR and you can test it.

In a way :D
Just create it with cargo new testy :D

Else I think I have a straight forward solution which should just work. I would open a PR and you can test it.

Sure

Btw: this was really just added last night. So you really found a up to date bug.

So if I got this right, NeoVim now sets this capability that it can resolve code actions and then rust analyzer sends such actions only. This is why it worked before where the capability was not there and rust analyzer was sending "normal" actions.

Finding these kinds of bugs is exactly the reason why I always run the lasted version of software. Some one has to spot and report them :D
Also thanks for the plugin and the very quick responce

Finding these kinds of bugs is exactly the reason why I always run the lasted version of software. Some one has to spot and report them :D

That is generous 😅
I do it to have the most recent cool features. But I'm not yet on last nights build 🙈
I'm glad that I can help.

I also just realized that NeoVim introduced custom commands. I need to handle this as well. 🤯

@xanderio may I ask were you take the nightly from? I was using the ArchLinux package nvim-nightly-bin but that doesn't work anymore as apparently NeoVim doesn't upload nightlies to the downloads anymore.
I have a solution, and it also makes the parsing more stable. So it will resolve actions, but also if it can't resolve it or failed to parse what the server send (which basically means it send crap or I'm not on the most recent specification version), it will warn the user with notifications, but still continue with the rest of the actions.

As I currently can't update NeoVim @xanderio would you please give #11 a try and check if it works for you? Thanks!

@xanderio may I ask were you take the nightly from?

I just build them from directly from source.

would you please give #11 a try

With that patch applied i get this error message when executing :CodeActionMenu
E5108: Error executing lua ...m-code-action-menu/lua/code_action_menu/shared_utils.lua:55: attempt to index loc
al 'data' (a nil value)

Ah sure, that makes sense.  I hate not strongly typed languages. They make me crazy. 😑
I'll get the nightly myself to not abuse you as a tester. Its too asynchronous with too much delay anyway. I'll ping you in the PR once I think it should really work.


Unordered input when testing speaker frame classification

Dear developer,
I'm currently evaluating pretrained Tera model on Librispeech
speaker classification task(by frame). When using original s3prl script, the result is similar to what paper report. But when I evaluate the task using my own script, I find a big performance gap. After checking my script output the same feature as s3prl script, I finally find that the bug comes from that I use unordered(length) input to form batch data.
I run the task again with my own configuration using s3prl script, with/without using random order input to form batch, and similar performance drop is found.
I add following code below this line
https://github.com/s3prl/s3prl/blob/8e3e995dd72d368e47a5410f2f6f1aaf47fc65ab/s3prl/downstream/speaker_linear_utter_libri/dataset.py#L60
tmp = list(zip(X, X_lens))
random.Random(4).shuffle(tmp)
X, X_lens = zip(*tmp)
X = list(X)
X_lens = list(X_lens)

and downstream configuration change is:
total_steps: 40000
lr: 0.0025
train_batch_size: 3
eval_batch_size: 3

Hi,
I presume the performance drop is caused by the padded zeros.
Please take a look at these two lines.
In our original implementation, we use ordered length input (bucketing), as a result, there is almost no padding needed (only in extremely rare cases/batches).
However, if you do not order the input, there will be lots of padding. Thus you have to use a mask when you compute the loss and take extra care of the padded frames. (This part we did not implement.)
Hope this can help you debug your script.

Thanks for the quick reply!
If I didn't get it work, the issue about zero padding may have been solved by line 48、63、64?

Thanks for the quick reply!
If I didn't get it wrong, the issue about zero padding may have been solved by line 48、63、64?

Line 63, 64 are for logging, you have to apply line 48 to line 59 (loss).

I got it!
I will add these code before loss calculation and see the result, thanks.
ignore = self.objective.ignore_index
for i in range(labels.shape[0]):
    labels[i, lengths[i].item():] = ignore


db_engine_specs: use correct sqlite week time grain

We want the week of year %W and not the day of week %w
when using week as time grain.
Reference:
https://www.sqlite.org/lang_datefunc.html

Codecov Report

Merging #4831 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4831   +/-   ##
=======================================
  Coverage   72.36%   72.36%
=======================================
  Files         208      208
  Lines       15662    15662
  Branches     1227     1227
=======================================
  Hits        11334    11334
  Misses       4325     4325
  Partials        3        3

Impacted Files
Coverage Δ

superset/db_engine_specs.py
51.89% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a3365...5ea97f0. Read the comment docs.


Add minimum required field check in CNI json validataion

This fix introduces to additional CNI json validation, which
clearly identify the given json is conf or conflist then check
minimum required fields are filled.

This is found at https://bugzilla.redhat.com/show_bug.cgi?id=1769435


db: print better error messages for invalid input

When client secrets are not base64 encoded, print an error message
that's not a generic base64 decode error:
client secrets must be base64 decodable. See issue #337.
Please consider replaceing "secret" with "c2VjcmV0"

When a user file is missing a mandatory field print an error message.
Unable to build Server: user elroy-foo is missing email field

For #400

cc @chancez how does this and #402 look to you?

Looks pretty solid.


"Could not load css"

Describe the bug
If you generate a new remix app and upgrade to vite@6 and run remix vite:dev, it has a problem with loading CSS files on the server side.  It will print
Could not load /Users/me/my-remix-app/app/tailwind.css to the console and the page will initially display unstyled, but then it will load the CSS file eventually anyway.  This proves that it can see the file, but is having some sort of problem in the initial server side rendering.  It works fine with vite@5 so this is a regression.
The repro steps are very simple so I don't think a reproduction link is necessary. I can't reproduce the problem without using Remix.  Should this issue be reported on Remix instead of Vite?
Reproduction
(just follow the repro steps)
Steps to reproduce
bunx create-remix@latest
cd my-remix-app
bun add -d vite@6
bun --bun remix vite:dev

View it in your browser.
Notice there is a flash of unstyled content every time you refresh.
Each time, it will print this to the console:
Could not load /Users/me/my-remix-app/app/tailwind.css
System Info
System:
    OS: macOS 15.1.1
    CPU: (8) arm64 Apple M1
    Memory: 94.38 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v16.10.0/bin/yarn
    npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
    bun: 1.1.37 - ~/.bun/bin/bun
  npmPackages:
    vite: 6 => 6.0.1

Used Package Manager
bun
Logs
Could not load /Users/me/my-remix-app/app/tailwind.css
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Can your ask Remix / react-router for Vite 6 support? There are a few breaking change which needs to be addressed by framework. As far as I can tell, they still have peer dev with Vite 5, so I would imagine you have peer dep warning if you try Vite 6.


[Bug] Property pane action list items are truncated

Description:
Few  options of "onClick, onTextChanged , onSubmit ..etc" in the drop down of the widget are truncated by default.
This issue might be in other widgets also.
Actual:

Expected:

Steps:

Drag and drop button widget

Select "onClick" action from the Menu of the button

Check the list items few of them are truncated

Details:

Version: [Cloud Appsmith v1.5.14-SNAPSHOT ]
OS: [Win10]
Browser [chrome]
Environment [production]

I would love to work on this issue. Please assign it to me.

@SandipPalit go for it!

@vivekverma2312 can you check if this happening in all the dropdown controls

I would like to work on this issue. Please assign it to me.

Closing this since I'm unable to see this issue in production.

Reopening this since it's a Windows system specific issue that's still present in production env.


Add formats and logging to AVFoundation backend

Changes:

Add logging for unincluded raw frame formats
Add NV12 support for avfoundation
Fix wrong Cb and Cr order in NV21

Possibly resolves https://github.com/pion/mediadevices/issues/292

GetMediaDevice works for me now!

GetMediaDevice works for me now!


Remove comment in splice

Haddock doesn't like it and fails because it thinks it's section syntax:
src/Data/Avro/Deriving.hs:465:15: error:
    parse error on input ‘-- $(schemaDef' sch)’
    |
465 |       x = sch -- $(schemaDef' sch)
    |               ^^^^^^^^^^^^^^^^^^^^

Hmm, out of interest, which version of GHC?
It works fine with 8.4.4 and 8.6.5 in our projects, and in CI...

Interesting, that specific project was using 8.4.4!


Need to take a screenshot from an iframe that loads the content from external sources

I need to take a screenshot from an iframe that I am adding using page.SetContent(');. The issue is my Iframe is making external requests to get the content. Once all the content is received and displayed in the Iframe I need to take the screenshot.

You can try to find the frame by its URL among the page.frames() elements and then use frame.waitForSelector() with this frame waiting for some selector available on the iframe complete loading.

The content is dynamic i dont know what selectors are there.


How to pass a custom event from class CustomStepComponent that extends the NgFlowchartStepComponent

I have a requirement to output a custom event from class CustomStepComponent that extends the NgFlowchartStepComponent and catch the same in the <div id="canvas" ngFlowchartCanvas [ngFlowchartOptions]="options" [ngFlowchartCallbacks]="callbacks" [disabled]="disabled" (editCustomStepEvent)="onEdit($event)">

@saurabhmehta-me did you figure this out? I've run into the same type of issue.

I can add a new event to the outputs:
 /**
 * Called after a step is initialized
 */
afterStepInit?: (step: NgFlowchartStepComponent) => void;

In custom-step.component.ts:
@Output() clicked = new EventEmitter();

In app.component.ts hosting the canvas:
stepSubscriptions: { stepId: string; sub: Subscription }[] = [];
  afterDeleteStep(step) {
    this.stepSubscriptions.find(s => s.stepId === step.id)?.sub.unsubscribe();
  }
  afterStepInit(step) {
    // choose step type to register events for
    if (step.type === 'router') {
      this.stepSubscriptions.push({
        stepId: step.id,
        sub: (step as CustomStepComponent).clicked.subscribe(() => {
          console.log('clicked in parent');
        }),
      });
    }
  }

if this works for you guys or if anyone can think of a better way to do this just let me know and I can add it.

It would help if one of you could give a specific use case to why you need the event in the canvas hosting component instead of just handling the event in the step component. @saurabhmehta-me @donbwhite


error during buile tensorflow_demo

I installed tensorflow from sources. convolution.py works well
but when I try to build android demo apk, I got the build error
It is looking for libz.so.1. which package include it?
Environment info
Operating System: 14.04.1-Ubuntu
I installed from sources
Steps to reproduce

in WORKSPACE
android_sdk_repository(
name = "androidsdk",
api_level = 21,
build_tools_version = "21.0.1",
path = "../../Android/android-sdk-linux/",
)

android_ndk_repository(
name="androidndk",
path = "../../Android/android-ndk-r10e/",
api_level=21)
2.bazel build //tensorflow/examples/android:tensorflow_demo
3.error message is like this
Exception in thread "main" Error: Failed to run command:
bazel-out/host/bin/external/androidsdk/aapt_binary s -i /tmp/android_resources_tmp451471447479393920/tmp-deduplicated/tensorflow/examples/android/res/drawable-hdpi/ic_action_info.png -o /tmp/android_resources_tmp451471447479393920/merged_resources/drawable-hdpi-v4/ic_action_info.png
Error Code:
127
Output:
bazel-out/host/bin/external/androidsdk/aapt_binary.runfiles/external/androidsdk/build-tools/21.0.1/aapt: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory
What have you tried?

Logs or other output that would be helpful
(If logs are large, please upload as attachment).

same error with SDK 23.0.1

Are you running a 32 or 64 bit OS?
Here are some suggestions for a user who experienced a similar error: http://stackoverflow.com/questions/17020298/android-sdks-build-tools-17-0-0-aapt-error-while-loading-shared-libraries-libz

Closing due to inactivity. Please reopen if issue persists.


add govulncheck make target

Issue #, if available:
Description of changes:
Adds a make target to EKS A for executing govulncheck.
govulncheck is:

a low-noise, reliable way for Go users to learn about known vulnerabilities that may affect their projects. Govulncheck analyzes your codebase and only surfaces vulnerabilities that actually affect you, based on which functions in your code are transitively calling vulnerable functions.

For the whole story, check out: https://go.dev/blog/vuln
To use this, just run make vulncheck to execut the command against the EKS Anywhere module.
The use of this command in the EKS Anywhere module highlights the importance of regular Go updates and the need to migrate to the latest patch version of 1.18.
Testing (if applicable):
make vulncheck
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approved


Workaround. Added FifoQueue to ignore attribute list when setting queue attribute

The origin of the problem is explained here:
https://github.com/localstack/localstack/issues/2096

Released in 0.15.5. Thanks!


Update font-awesome from v4.3.0 to v4.5.0

The title says it all.

Thanks @pgericson for updating this dependency.


Kusto extension is raising an error on startup on dev builds

Azure Data Studio Version: main

Steps to Reproduce:

Run ADS on dev build

Expected: No errors on startup
Actual: Kusto is raising an error on startup

@gupta1 @qifahs could someone please take a look and resolve this?  I have to dismiss these notifications everytime I debug currently.

Closing as duplicate of https://github.com/microsoft/azuredatastudio/issues/11984
@qifahs @gupta1 Any progress on the fix? This is affecting everyone developing in ADS currently.

Closing as duplicate of #11984
@qifahs @gupta1 Any progress on the fix? This is affecting everyone developing in ADS currently.

Working on the fix. I will send a PR soon.


Add Link to Github Repo

https://crimson-portal.herokuapp.com/ should contain a link to this Github repo so that users can immediately browse the code and understand the concepts.

Yes, that's a good idea.


Required property "uri" in licenses and sources

Validation is not passing due to missing uri property in licenses and sources. Is that expected? I've looked at https://specs.frictionlessdata.io/data-package/#licenses and https://specs.frictionlessdata.io/data-package/#sources and it seems like it does not have uri property at all (and also all properties are optional). However, in the default profile here it says it is required - https://github.com/frictionlessdata/datapackage-js/blob/master/src/profiles/data-package.json#L197

@anuveyatsu
Is it alpha version? I think there is still specs problems but have you tried to use new DataPackage(descriptor, {strict: false})? to do not trow on validation errors?


Question about the number of channels

Hi,
May I ask you a question? Why are the output channels of conv_reduce four times the number of input channels and how it can play the role of reducing dimensions before 3*3 convolution?
CifarResNeXt (
(conv_1_3x3): Conv2d(3, 64, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1), bias=False)
(bn_1): BatchNorm2d(64, eps=1e-05, momentum=0.1, affine=True)
(stage_1): Sequential (
(stage_1_bottleneck_0): ResNeXtBottleneck (
(conv_reduce): Conv2d(64, 512, kernel_size=(1, 1), stride=(1, 1), bias=False)
(bn_reduce): BatchNorm2d(512, eps=1e-05, momentum=0.1, affine=True)
(conv_conv): Conv2d(512, 512, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1), groups=8, bias=False)
(bn): BatchNorm2d(512, eps=1e-05, momentum=0.1, affine=True)
(conv_expand): Conv2d(512, 256, kernel_size=(1, 1), stride=(1, 1), bias=False)
(bn_expand): BatchNorm2d(256, eps=1e-05, momentum=0.1, affine=True)
(shortcut): Sequential (
(shortcut_conv): Conv2d(64, 256, kernel_size=(1, 1), stride=(1, 1), bias=False)
(shortcut_bn): BatchNorm2d(256, eps=1e-05, momentum=0.1, affine=True)
)
)

There are two factors here: the cardinality and the widen factor. The conv_reduce eliminates ("reduces") the widen factor but the same conv_reduce layer is used to expand the cardinality (number of groups). Since here cardinality > widen factor, it the result is an expansion. I know the "reduce" term might be misleading but I use it to keep the same notation as the plain resnet.
I hope this answers your question!

@prlz77 Thanks for responsing me patiently. But I wonder why you made such modifications since it decrease the efficiency of the model which is different from the origin intention of ResNeXt.

No problem! I did not make any modification, the code should be as the original! The original behaviour should be that if you use cardinality=8, the 1x1 convolution should output 512 feature maps (8*64) for the first block. I don't see difference with respect to the original implementation in luatorch:
        input
          |`-> (1): nn.Sequential {
          |      [input -> (1) -> (2) -> (3) -> (4) -> (5) -> (6) -> (7) -> (8) -> output]
          |      (1): cudnn.SpatialConvolution(64 -> **512**, 1x1) without bias
          |      (2): nn.SpatialBatchNormalization (4D) (512)
          |      (3): cudnn.ReLU
          |      (4): cudnn.SpatialConvolution(512 -> 512, 3x3, 1,1, 1,1) without bias
          |      (5): nn.SpatialBatchNormalization (4D) (512)
          |      (6): cudnn.ReLU
          |      (7): cudnn.SpatialConvolution(512 -> 256, 1x1) without bias
          |      (8): nn.SpatialBatchNormalization (4D) (256)
          |    }

If you still think there is something different, please, tell me the parameters you are using (cardinality, width, etc.) to see if there is an error in the code.

@prlz77 Yes, you are right! I have figured it out. Thank you for your help and I'll close the issue.


Validation: Description-missing fixes.

Added missing descriptions to fix validation errors.

Docs Build status updates of commit 9388492:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/v8-web-control/modules/directions-module/routeoptimization-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/geoxml-module/kmlscreenoverlayoptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/heat-map-module/heatmaplayer-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/heat-map-module/heatmaplayeroptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/heat-map-module/index.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/index.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/address-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/geocodelocation-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/geocoderequestoptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/geocoderesult-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/index.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/matchcode-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/matchconfidence-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/placeresult-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/reversegeocoderequestoptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/searchmanager-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/copyright-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/copyrightsource-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filter-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filtercompareoperator-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filtergroup-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filterlogicaloperator-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/geodataapimanager-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/geodataprimitive-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/geodataresult-object.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@stevemunk @rbrundritt
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

@stevemunk
I've implemented the requested changes. Please let me know if there are any other issues preventing approval and merge. Thank you and have a great day!

Docs Build status updates of commit 77a8043:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/v8-web-control/modules/directions-module/routeoptimization-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/geoxml-module/kmlscreenoverlayoptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/heat-map-module/heatmaplayer-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/heat-map-module/heatmaplayeroptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/heat-map-module/index.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/index.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/address-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/geocodelocation-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/geocoderequestoptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/geocoderesult-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/index.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/matchcode-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/matchconfidence-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/placeresult-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/reversegeocoderequestoptions-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/search-module/searchmanager-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/copyright-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/copyrightsource-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filter-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filtercompareoperator-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filtergroup-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/filterlogicaloperator-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/geodataapimanager-class.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/geodataprimitive-object.md
:white_check_mark:Succeeded
View

BingMaps/v8-web-control/modules/spatial-data-service-module/geodataresult-object.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@brittmsantos Thank you! Merging....


tests: What are they even, and where can we buy some?

[x] Some tests, any tests what-so-ever
[x] Add something resembling a test suite for travisci to run
[x] Have travisci build the example(s)
[x] Test complex server behavior with multiple users

62% coverage is a pretty good start.


validate_token route defaults test

Test for #1032
To pass test merge #1032 before.
Also see issue #1031

Closed. The tests should be together with code.


Put upper bound of 2.0.0 for Ocaml migrate parsetree.

This is a more complete version of this PR
Questions:
I think that this won't be enough to fix package installs because we might need
to deprecated the old version of Reason packages, or at least edit the esy opam
overrides repo to make sure earlier versions of Reason don't get solved
assuming it is compatible with omp 2.0.0

Looks good ☺


App Suggestion: [Obsidian Live Sync ]

Please tell us what app you'd like to see on CapRover as a one-click app.
Looks like a nice app that doesn't require much to run. Sadly I don't have the knowledge to make it run properly
Do you know if there is any official Docker image for the app?
Yes
Here is the repo: https://github.com/vrtmrz/obsidian-livesync

They don't have a docker image?

I thought they did, But apparently I read it wrong, sorry. They just have a docker compose for CouchBD and Traefik in their repo


Add Cellprofiler tutorial

Cellprofiler tutorial as discussed in theislab/squidpy_reproducibility#14

Hi @michalk8 thx for your review. The mentioned tasks should be addressed with the last push.


Jump_Game

🚀 Feature
Jump Game :
We need to find the minimum number of jumps to reach the end of the array starting from the first element of the array,
jumps value would be (-1) if we are not able to reach the end of the array
example : array = {2,3,0,1,4,1,1,2,0,3,5}
minimum jumps = 5  {2 to 3, 3 to 4, 4 to 2, 2 to 3, 3 to 5}
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Concept Building
Pitch
Jump Game is one of the most asked interview question

/assign


Refactor DiffusionSimulation tracing

Fixes https://github.com/input-output-hk/ouroboros-network/issues/4610

This PR needs to be updated.

@coot done!


encoding/gob: better support for error

Errors created by the errors package are not registered with encoding/gob which is necessary in order to send them as results of remote procedure calls.
By now, returning an error from the standard library  through an RPC method will cause that the receiver get an EOF error and the transmitter a gob: type not registered for interface: errors.errorString
My proposal is add an init() function in the errors package to register the struct errorString so then,  developers will avoid create its own errors implementation when using RPCs.

fwiw, I'm not convinced it is needed. The loss of type will still surprise some, but a little more insidiously. The person who expects the real type after unmarshaling will get caught out... quietly.
Marshaled structs typically form part of a contract that crosses process boundaries, and these contracts should attempt to remain simple and or explicit. In the simple case I would rather see a string type in the contract and it populated by an err.Error() so as to avoid the looming disappointment. If more complex errors are to form part of the contract then I agree the explicit marshaller interface as per @robpike s upspin example is the better approach.
I would say the marshalling of errors is almost binary:

The client of the unmarshaled error expects an error type, and if they do they will surely have, or soon have, more complex needs like wrapped errors (a.la. upspin)
The error may as well be explicitly a string

In case anecdotes are in any way useful. In 4 years of working with rpc contracts across 40 services this issue has come up once, and never wrt persistence (we do gob encode for persistence). We found it quickly because it failed loudly.

In the model I have, the special handling would occur only if the implementing type is not otherwise marshalable, which I think addresses your worry.

encoding/gob has been frozen for ages now and we aren't adding more features/support to it, thus I shall close this issue. So long encoding/gob, you served us well!

Hey @odeke-em; might it be an idea to clarify that in the godoc, with some possible alternatives (not sure which?) similar to how net/smtp has a notice?

The smtp package is frozen and is not accepting new features. Some external packages provide more functionality. See:
https://godoc.org/?q=smtp


functional/platform: remove --experimental-api

The --experimental-api flag is deprecated and has no effect
on the fleetctl commands run by the functional tests.

LGTM :hear_no_evil:


I cant put the token...

Sorry my dumb question but... i cant paste the token.... is strange because i have a previous version of lichs, and there i can paste... but cant in this "new version". Cant even write.
Probably a easy solution, but... i dont know how.
Thanks.

I have the same issue.  How did you fix it?

I have the same issue. How did you fix it?

When i ask, i have in mind the first versions of lichs. Now is like this:
"Jump into your terminal and write lichs <api_token> (put your API token instead of <api_token>) and run the command. To get this clear, an example would have been lichs lzRceo5XOUND74Lm. You should then see a message to confirm that the API token has been saved."


Fixes microsoft/monaco-editor#1818: check matchOnlyAtLineStart when e…

This PR fixes microsoft/monaco-editor#1818.
I tested this by copying one of the .html files in playground.generated and changing the JavaScript to include the following:
const DEMO_LANG_ID = "demo";

const languageConfiguration = {
  // The main tokenizer for our languages
  tokenizer: {
    root: [
      [/^\!/, { token: 'delimiter.curly', next: 'jsonInBang', nextEmbedded: 'json' }],
    ],
    jsonInBang: [
      [/^\!/, { token: 'delimiter.curly', next: '@pop', nextEmbedded: '@pop' }],
    ],
  },
};
monaco.languages.register({
  id: DEMO_LANG_ID,
  extensions: ['.example'],
});
monaco.languages.setMonarchTokensProvider(DEMO_LANG_ID, languageConfiguration);

      const value = `\
!
  {
    "foo": "b!ar"
  }
!
`;

var editor = monaco.editor.create(document.getElementById("container"), {
  value,
  language: DEMO_LANG_ID,

  lineNumbers: "off",
  roundedSelection: false,
  scrollBeyondLastLine: false,
  readOnly: false,
  theme: "vs-dark",
});

When I loaded the page, now the entire "b!ar" string literal was highlighted correctly. Previously, the syntax highlighting stopped at the !.

https://github.com/microsoft/monaco-editor/blob/master/CONTRIBUTING.md mentions a bunch of test pages, but not a lot about running automated tests. I did try running the following from my ~/src/vscode folder as it recommends:
npm run monaco-editor-test

but that failed with:
npm ERR! missing script: monaco-editor-test

npm ERR!      /Users/mbolin/.npm/_logs/2020-02-07T23_54_12_536Z-debug.log

The change looks good.
I ran the tests at https://github.com/microsoft/monaco-languages using the patch and they all pass.

@alexdima Thanks so much for the fast accept and the release!
If I want to add a test, is monaco-languages the right place to do it?

The best would be to have tests inside the vscode repository... The monaco-languages repository is more concerned with testing that the various tokenizers are correct in tokenizing their respective programming languages...
But currently there are no specific Monarch tests in the vscode repository so you would need to scaffold a bit to get some tests running...


[Issue] cant install

Describe the bug
when i run install command it doesnt work
ghtracker version
Include the version of ghtracker you are using, ghtracker -version
Complete command you used to reproduce this
Screenshots
Add screenshots of the error for a better context.

You need to add golang's bin directory to the environment variable.


Add details to HTTP error message exceptions

Add in error->details to the thrown exception when there's an HTTP error

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

closing PR due to extreme staleness


clear pw list as well as the server list on the clear servers command

Fixes #8956

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for feature-requests.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #10077 (d83342b) into main (e6f523d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10077   +/-   ##
======================================
  Coverage     64%      64%
======================================
  Files        216      216
  Lines      10060    10060
  Branches    1613     1613
======================================
  Hits        6508     6508
  Misses      3028     3028
  Partials     524      524


Circular Progress component implemented

Implemented the Circular indicator for progress as a LitElement component
https://material.io/design/components/progress-indicators.html#circular-progress-indicators

I'm ok with my commits being contributed to this project.

If you all can get this merged in, or some feedback, we got plenty more components to send you. I'll resubmit the Select, Textfield, etc that we have been working on fixes for

Sorry for the delay, Circular Progress has had a redesign recently. Would you be willing to update this PR to reflect that once the design is updated?

Thanks for the PR! We're currently working on an implementation for circular progress. Follow #500 for updates 😊


cast to tv

Is your feature request related to a problem? Please describe:
A clear and concise description of what the problem is. Ex. I have an issue when [...]
Describe the solution you'd like:
A clear and concise description of what you want to happen. What are the benefits and drawbacks?
Describe alternatives you've considered:
A clear and concise description of any alternative solutions or features you've considered.
Additional context:
Add any other context or screenshots about the feature request here.

Hello @washi6450. It seems you forgot to fill in the details of your feature request. Could you do that?


Continue plotter reconcile loop on update or blueprint not found of an entry

Continues the the processing of other blueprint specs in the plotter reconcile loop if blueprints are updated instead of returning for each update or not found blueprint.

I will revisit the error handling. About the requeueing as there is no external mechanism right now that gives notifications the current strategy is to periodically requeue. Although I'd like to introduce some kind of backoff if the state does not seem to progress further. (e.g. if the plotter is in state ready only check status every minute or so)


Create a dead-letter queue

For queue items that fail to get built more than 5 times.

Closing since we are no longer using the queue so this is now irrelevant.


Add reactivity to forms

Can we add reactivity when a form is saved? I'm using a form to create a SQL query, so when it finishes running I want the table that displays the data to load automatically instead of needing to click the refresh button.

upgrade to 0.4.8, you have three reactivity witht form and button, please refer to change.md file


Lspinstaller setup breaking change

https://github.com/williamboman/nvim-lsp-installer/pull/631

Any updates on fixing the issues?

local function on_attach(client, bufnr)
	require("navigator.lspclient.mapping").setup({
		client = client,
		bufnr = bufnr,
		cap = client.server_capabilities,
	})
end

lspconfig.rust_analyzer.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
lspconfig.sumneko_lua.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
lspconfig.tsserver.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
lspconfig.prismals.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
lspconfig.svelte.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
lspconfig.taplo.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
lspconfig.jsonls.setup (coq.lsp_ensure_capabilities({on_attach = on_attach}))
``` this is what im currently doing to get this plugin working


CodeFormatter should accept SyntaxTree

There are cases where someone has a SourceText and being forced to convert it to a string is an extra step that shouldn't be required. CodeFormatter could pretty easily accept SourceText as well.

I actually noticed that a SourceText is already a finalized visual form of the SyntaxTree, so it therefore really should instead have an overload accepting the actual SyntaxTree, what do you think?

Yeah that makes sense. Maybe it has an overload for both of them?

CSharpSyntaxTree.ParseText has an overload that accepts a SourceText that you may have missed.

Oh I think that we are both talking about different things. When I am creating a source code through the SyntaxFactory API I am currently first converting the SyntaxTree > SourceText > string. Now from my perspective it would make the most sense if I could directly pass the CodeFormatter the SyntaxTree. Not because it is necessarily less code to write, but rather because it is a lot faster, as you are converting the passed string/SourceText back to a SyntaxTree as far as I am aware of.

Oh I see 😄. Well that would make sense however do you think that it should be encourage to pass it a SourceText? CSharpSyntaxTree.ParseText will more or less convert it to a string anyway and the performance hit would just be hidden. Also I can't think of any quick scenario in my head where I'd have the SourceText, but not the SyntaxTree representation of a piece of code.

I am good with just having the overload for SyntaxTree, no need to add another overload if no one is going to need it.


fixing panic when root is symlink

Re-submitting PR (tests passing running locally!)
When the root path that is set is a symlink, caddyserver will not start and panics.
This PR is adding a check to determine if the path is a symlink first and if it is then delegate the responsibility that it is a valid path to the underlying OS, otherwise continue with the existing checks.

Thanks @pennywisdom! I am surprised that it straight-up panicked in that case... do you think you could write a test so that it preserves the fix contained in your patch?

yes @mholt  i'll get one/some created.

Not sure how to handle the issue on Windows (not server. You need to be running as Administrator to create a symlink  and if you are not then an error throw, however I'm not sure this is a good case for failing the tests, seems like a bit of an edge case, and we only need to create the symlink in the test, its not part of running Caddy.
For this reason, the test verifies that the error is thrown when privileges need elevating and skips the test, which will be logged by the runner.

I also really appreciate your effort in writing the test case and considering the permissions issues. I think you handled it fine. Would you like to be added as a collaborator on the project? That means you could contribute without having to fork, you could just do it in a branch, and you could help review pull requests and issues.

No probs at all, really happy to help out. Yes please do add me as a collaborator that would be great!


[5.3] Revert Eloquent builder changes on firstOr* functions to fix bug

This reverts the changes made in PR #14656 & Issue #14649, which broke the firstOr* functions. They started returning either a new instance if the DB was empty or the first row if anything existed.
We will need to come up with a new way to allow mutators to work...but in the meantime this will fix those functions.

Probably needs backporting to 5.2, and a final 5.2 release happening.

@GrahamCampbell Yeah, I agree it should be backported to 5.2 as it was a breaking change introduced in 5.2 which wasn't documented. The overall implementation worked, but it broke existing use of the function depending on how the function was used.

Ok, I've backported this. :)


Help with URL patterns

Attached below is my current crawler config and I have a few questions about the URL patterns.
I have a "Support Training" page that has 10 links to other .aspx pages that contain links to PDFs on them. However, not all 10 of the links on the "Support Training" page are crawled. I tried to show this below. The "itsp.aspx" and "documentation.aspx" pages are both linked from the main "Support Training" page. Any idea why some PDFs are index but not others?
(here's a picture of the text below since github messes up the format: http://i.imgur.com/FREWgGa.png)

https://mysite.com/support_training/support_training_overview.aspx
A. https://mysite.com/support_training/itsp.aspx (No Scraping Rule)
A1. https://mysite.com/documents/support_training/itsp_appnotes/document1.pdf (Doesn't get index)
A2. https://mysite.com/documents/support_training/itsp_appnotes/document2.pdf (Doesn't get index)
A3. https://mysite.com/documents/support_training/itsp_appnotes/document3.pdf (Doesn't get index)
A4. https://mysite.com/documents/support_training/itsp_appnotes/document4.pdf (Doesn't get index)
B. https://mysite.com/support_training/documentation.aspx (Gets crawled)
B1. https://mysite.com/documents/support_training/publications/ReleaseNotes/Server/document1.pdf (Gets indexed)
B2. https://mysite.com/documents/support_training/publications/ReleaseNotes/Server/document2.pdf (Gets indexed)
B3. https://mysite.com/documents/support_training/publications/ReleaseNotes/Server/document3.pdf (Gets indexed)
B4. https://mysite.com/documents/support_training/publications/ReleaseNotes/Server/document4.pdf (Gets indexed)

    "index" : "index_mysite_web",
    "type" : "type_mysite_web",
    "url" : ["https://mysite.com/default.aspx"],
    "includeFilter" : ["https://mysite.com/.*", "https://mysite.com/support_training/*", "https://na13.salesforce.com/_ui/selfservice/pkb/PublicKnowledgeSolution/*"],
    "excludeFilter" : ["https://mysite.com/.*(?:png|jpg|jpeg|gif|css|js|axd|zip|tgz|tar|gz|bz)"],
    "maxDepth" : 10,
    "maxAccessCount" : 100,
    "numOfThread" : 10,
    "interval" : 1000,
    "overwrite" : true,
    "robotsTxt" : true,
    "userAgent" : "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1",
    "target" : [
      {
        "settings" : {
          "html" : false
        },
        "pattern" : {
          "url" : "https://mysite.com/documents/.*pdf",
          "mimeType" : "application/pdf"
        },
        "properties": {
            "file": {
                "type": "attachment",
                "maxFileSize" :<PHONE_NUMBER>000000000
            }
        }
      },
      {
        "settings" : {
          "html" : false
        },
        "pattern" : {
          "url" : "https://mysite.com/documents/.*doc",
          "mimeType" : "application/msword"
        },
        "properties": {
            "file": {
                "type": "attachment",
                "maxFileSize" :<PHONE_NUMBER>000000000
            }
        }
      },
      {
        "settings" : {
          "html" : false
        },
        "pattern" : {
          "url" : "https://mysite.com/documents/.*docx",
          "mimeType" : "application/vnd.openxmlformats-officedocument.wordprocessingml.document"
        },
        "properties": {
            "file": {
                "type": "attachment",
                "maxFileSize" :<PHONE_NUMBER>000000000
            }
        }
      },
      {
        "settings" : {
          "html" : false
        },
        "pattern" : {
          "url" : "https://na13.salesforce.com/_ui/selfservice/pkb/PublicKnowledgeSolution/d",
          "mimeType" : "text/html"
        },
        "properties": {
            "title": {
                "text": ".solutionTitleDetail"
            },
            "body": {
                "text": ".solutionBodyDetail"
            }
        }
      },
      {
        "settings" : {
          "html" : false
        },
        "pattern" : {
          "url" : "https://mysite.com/support_training/rma/rma_submission.aspx",
          "mimeType" : "text/html"
        },
        "properties": {
            "title": {
                "text": ".headerBar p"
            },
            "body": {
                "text": "#portal_content"
            }
        }
      }
    ]
}```

Please check a log file after changing to debug level in config/log4j.xml.

so my issue was, maxAccessCount was set to "100" which it was reaching so it never scraped the page I posted about.


Dialog onCancel not called on overlay click

I am implementing the Dialog component and need to show a "are you sure you want to discard" confirmation message when the user attempts to close the dialog.
Is it possible to run logic before closing the Dialog?
I am able to do this with the onCancel property but it appears it only triggers when the cancel button is clicked not when the modal is closed by clicking the overlay when shouldCloseOnOverlayClick is set to true.

I don't think this is currently possible without hacking around the props exposed by the Dialog component. Our SideSheet component has this functionality (exposed through an onBeforeClose prop which you can return false from to prevent closing), so it wouldn't be hard to add.
In the meantime, you might want to set shouldCloseOnOverlayClick to false if you're worried about users closing your dialog without saving first.

Thank @brandongregoryscott. I have indeed set shouldCloseOnOverlayClick to prevent this. Will leave the issue open as it's not ideal for our case, but feel free to close it if you want to reduce noise


need fastprocessor parameter like in HX711

clock low time should be at least 0.2 us, and fast processors can break clocking of data.
(seen in email 10 nov )

labeled as BUG to prioritize


Remove local clones & make hooks run on merge/edit/upload

This PR removes the local clones from the Wiki and the Repository.
It also fixes #6544 by ensuring that the hooks are run on pushing.

This is a redo of the closed #6505
I've not moved over the improvement to tree as that will conflict with @filipnavara's git patches and I haven't reduced temporary repo to a shim as previously.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b1bb700). Click here to learn what that means.
The diff coverage is 42.53%.

@@            Coverage Diff            @@
##             master    #6672   +/-   ##
=========================================
  Coverage          ?   40.83%
=========================================
  Files             ?      425
  Lines             ?    57690
  Branches          ?        0
=========================================
  Hits              ?    23555
  Misses            ?    31012
  Partials          ?     3123

Impacted Files
Coverage Δ

routers/repo/branch.go
58.19% <ø> (ø)

models/user.go
50.18% <ø> (ø)

modules/setting/repository.go
51.42% <ø> (ø)

modules/git/repo_tree.go
30.64% <0%> (ø)

modules/git/repo_object.go
0% <0%> (ø)

modules/git/repo_index.go
0% <0%> (ø)

modules/git/repo.go
60.58% <100%> (ø)

models/repo.go
46.78% <100%> (ø)

modules/git/repo_branch.go
82.17% <100%> (ø)

modules/repofiles/temp_repo.go
70.5% <33.33%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bb700...20d1cd1. Read the comment docs.

please resolve conflicts but otherwise lgtm


Update build.ninja, remove USM flag

Support for this flag was removed from the compiler when the behavior became default. Accidentally forgot to remove the bad flag from the ninja file.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[X] Command Line
[X] Visual Studio

Since this is locally tested and an urgent fix, I will merge without waiting for CI results.


Req: shortened citekeys through a look-up table

Log ID: 8VKUX4NC-euc
Revisiting an earlier idea.
When the author is an organisation, BBT correctly produces citekeys like these:
britishbroadcastingcorporationBBCHandbook19751976
departmentfordigitalculturemediaandsportConsultationRenewalDigital2021
The names of organisations are supposed to appear in full in Zotero and in references, but it would be more practical if citekeys looked like these:
bbcBBCHandbook19751976
dcmsConsultationRenewalDigital2021
I suppose one way to achieve that is adding a user-defined translation table, (re)generating citekeys, and possibly pinning the affected citekeys. The translation table would replace, say, all instances of departmentfordigitalculturemediaandsport with dcms.
This may be done with any user selected string, anywhere in the citekey (not just organisations or authors).

I think I can reactivate #2081 when I get back home, sounds like that does what you want.

The CSV mapping you are describing there would do the job. Ideally, the functionality would be eventually incorporated into the Zotero Preferences dialogue, but I am not sure how many people would actually use the feature. IMV it is an obvious and significant addition. At least the file could be linked to from Preferences. I am using .2554 at the moment.

I'm not keen on UI work, and I don't think the zotero UI framework has an editable grid, so I'd have to create it from scratch.

I was thinking of something like your '@string definitions' tab with entries like:
British Broadcasting Corporation; bbc
United Nations; un

But a clickable relative path to the csv file will also be fine.

Oh I suppose that's doable. I could make it so that you could copy-paste from a spreadsheet for easier bulk editing.

Not sure why 'awaiting-user-feedback' was added.

I should have removed it. It is always automatically added after I comment.

Newlines can't be pasted into the hidden prefs. I'll have to think of another way

I am guessing the hidden prefs don't take strings that are long enough to accommodate many comma separated pairs in one line. It's not elegant, but how about using a dummy bibliography entry to store this and other data for the plugin? It's a bit hacky and the users will have to make sure they don't delete the dummy source, but there are advantages (eg these preferences will automatically synchronise across installations with the sources). But there may be better ways to do this.

It's not the length, the hidden prefs editor eats newlines.
I'll think about using a zotero item.


configure tabs as 2 spaces to avoid a dependency on global ruby defaults

This is a small change, but I often have to work on ruby projects that have different spacing requirements.
I would prefer to keep the spacing for vagrant at the Hashicorp 2 space tab standard.
I have also modified the other repos.  If you accept this pull request and you want pull requests let me know.
Thank you for consolidating these tools in one place.

Sorry for the delay, reviewing this now.

@mattyjones I'm ok with this if you are.


[Segment Replication] [BUG] Primary to primary recovery (relocation) breaks with segment conflicts.

From https://github.com/opensearch-project/OpenSearch/issues/4665 & related .  Primary-Primary recovery operates the same under segment replication as it does today by using Peer recovery.
This process works by copying segments out to the new primary and then any operations received during the copy duration to be replayed, followed by the relocation handoff.  With segment replication the old primary shard will continue to copy out to other replicas during the relocation process.  Once the new primary is recovered it will reindex the operations received.  This means the new primary will reindex operations already sent out to the replication group, causing a segment conflict.  This will cause the replicas to fail and recover again from the new primary.
Ideas to fix:

Bump SegmentInfos counter on the new primary to write segments with a different name.  Will mean segments containing the same ops will be copied twice. This conflict & solution is similar to the same problem encountered within failover steps.  However, with failover we do not have the luxury of a graceful handoff.
Recover the soon to be new primary as a replica. Once complete, block the old primary from copying out new segments to the group and force a segrep event to the new primary.  Recover from xlog any ops received during segment copy & perform handoff.
Block old primary from syncing to the rest of the replication group while relocation is in progress.  Could cause replicas to fall far of sync with primary & after relocation is complete will trigger expensive syncs.

Looking into it

Of three available fixes, third solution (block old primary from blocking replication) will cause delays on replicas and is not the considered. First solution (bump SegmentInfo counter) is hacky and also identifying ideal bump number is tricky to find.
Based on above, I will be following the second approach for this fix. Below is the rough plan for the same

[ ] Write integration test which mimics this scenario and fails.
[ ] Understand existing primary-primary relocation mechanism

[ ] Understand different phases in peer recovery
[ ] Understand code flow comprising the three phases of recovery

[ ] Change the replication type for new primary to replica
[ ] Add unit test and ensure integration test passes

With integration test below
    public void testSimplePrimaryRelocationWithoutFlushBeforeRelocation() throws Exception{
        logger.info("--> starting [node1] ...");
        final String node_1 = internalCluster().startNode();

        logger.info("--> creating test index ...");
        prepareCreate(INDEX_NAME, Settings.builder().put("index.number_of_shards", 1)
            .put(IndexModule.INDEX_QUERY_CACHE_ENABLED_SETTING.getKey(), false)
            .put(IndexMetadata.SETTING_REPLICATION_TYPE, ReplicationType.SEGMENT)
            .put("index.number_of_replicas", 1)).get();

        final String node_2 = internalCluster().startNode();

        ensureGreen(INDEX_NAME);

        logger.info("--> index 1 doc");
        client().prepareIndex(INDEX_NAME).setId("1").setSource("foo", "bar").setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE).get();
        waitForReplicaUpdate();
        logger.info("--> verifying count");
        assertThat(client(node_1).prepareSearch(INDEX_NAME).setSize(0).setPreference("_local").execute().actionGet().getHits().getTotalHits().value, equalTo(1L));
        assertThat(client(node_2).prepareSearch(INDEX_NAME).setSize(0).setPreference("_local").execute().actionGet().getHits().getTotalHits().value, equalTo(1L));

        // If we do a flush before relocation, this test will pass.
//        flush(INDEX_NAME);

        logger.info("--> start another node");
        final String node_3 = internalCluster().startNode();
        ClusterHealthResponse clusterHealthResponse = client().admin()
            .cluster()
            .prepareHealth()
            .setWaitForEvents(Priority.LANGUID)
            .setWaitForNodes("3")
            .execute()
            .actionGet();
        assertThat(clusterHealthResponse.isTimedOut(), equalTo(false));

//        logger.info("--> Cluster state before relocation {}", internalCluster().clusterService().state());
        logger.info("--> relocate the shard from node1 to node3");

        client().admin().cluster().prepareReroute().add(new MoveAllocationCommand(INDEX_NAME, 0, node_1, node_3)).execute().actionGet();
        clusterHealthResponse = client().admin()
            .cluster()
            .prepareHealth()
            .setWaitForEvents(Priority.LANGUID)
            .setWaitForNoRelocatingShards(true)
            .setTimeout(ACCEPTABLE_RELOCATION_TIME)
            .execute()
            .actionGet();
        assertThat(clusterHealthResponse.isTimedOut(), equalTo(false));

        logger.info("--> Done relocating the shard from node1 to node3");

//        logger.info("--> Cluster state after relocation {}", internalCluster().clusterService().state());

        client().prepareIndex(INDEX_NAME).setId("2").setSource("bar", "baz").setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE).get();
        waitForReplicaUpdate();
        logger.info("--> verifying count again...");
        client().admin().indices().prepareRefresh().execute().actionGet();
        assertThat(client().prepareSearch(INDEX_NAME).setSize(0).execute().actionGet().getHits().getTotalHits().value, equalTo(2L));
    }

![primary relocation with segrep](https://user-images.githubusercontent.com/79435743/202587152-1335bded-decd-492a-93a1-987c0e4f09e1.png)

Tried out the changes on 3gb data set with 3 data nodes. Force merged the segments to 1 and see the segrep round took 3472ms during relocation handoff; making the overall recovery time to 3.5sec.
[2022-12-30T18:21:47,946][INFO ][o.o.i.r.PeerRecoverySourceService] [runTask-0] [geonames][0] starting recovery to {runTask-1}{J8UB_CreR3eLksYcTYTarg}{TaFmmo3lQayop7BDCQpNmw}{<IP_ADDRESS>}{<IP_ADDRESS>:9301}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}
[2022-12-30T18:21:47,931][INFO ][o.o.i.s.IndexShard       ] [runTask-1] [geonames][0] [geonames][0] writing shard state, reason [initial state with allocation id [[id=Ky7cfzVzQZ6u4-Lk_01-bQ, rId=UYXqn-CvTQ6yxYd8S02iog]]]
[2022-12-30T18:21:47,951][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.nvd], does not exist in remote
[2022-12-30T18:21:47,942][DEBUG][o.o.c.c.C.CoordinatorPublication] [runTask-1] publication ended successfully: Publication{term=4, version=37}
[2022-12-30T18:21:47,951][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.tip], does not exist in remote
[2022-12-30T18:21:47,942][INFO ][o.o.i.r.PeerRecoveryTargetService] [runTask-1] [geonames][0] preparing shard for peer recovery
[2022-12-30T18:21:47,951][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.dvm], does not exist in remote
[2022-12-30T18:21:47,943][INFO ][o.o.i.s.IndexShard       ] [runTask-1] [geonames][0] skip local recovery as no index commit found
[2022-12-30T18:21:47,951][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.doc], does not exist in remote
[2022-12-30T18:21:47,943][INFO ][o.o.i.r.PeerRecoveryTargetService] [runTask-1] [geonames][0] collecting local files for [{runTask-0}{_66hjBZaQaGdr4eM81BbUg}{b2yeMvYhRvmcxjeNVUseBg}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}]
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.tim], does not exist in remote
[2022-12-30T18:21:47,944][INFO ][o.o.i.r.PeerRecoveryTargetService] [runTask-1] [geonames][0] [1] shard folder empty, recovering all files
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.nvm], does not exist in remote
[2022-12-30T18:21:47,944][INFO ][o.o.i.r.PeerRecoveryTargetService] [runTask-1] [geonames][0] local file count [0]
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.fnm], does not exist in remote
[2022-12-30T18:21:47,945][INFO ][o.o.i.r.PeerRecoveryTargetService] [runTask-1] [geonames][0] starting recovery from {runTask-0}{_66hjBZaQaGdr4eM81BbUg}{b2yeMvYhRvmcxjeNVUseBg}{<IP_ADDRESS>}{<IP_ADDRESS>:9300}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.kdd], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.si], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.tmd], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.fdm], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.kdi], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.fdt], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.pos], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.kdm], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3.fdx], does not exist in remote
[2022-12-30T18:21:47,952][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [_4e3_Lucene90_0.dvd], does not exist in remote
[2022-12-30T18:21:47,953][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering [segments_f], does not exist in remote
[2022-12-30T18:21:47,953][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: recovering_files [18] with total_size [2.7gb], reusing_files [0] with total_size [0b]
[2022-12-30T18:22:06,245][INFO ][o.o.i.s.IndexShard       ] [runTask-0] [geonames][0] background syncing retention leases [RetentionLeases{primaryTerm=3, version=82, leases={peer_recovery/_66hjBZaQaGdr4eM81BbUg=RetentionLease{id='peer_recovery/_66hjBZaQaGdr4eM81BbUg', retainingSequenceNumber=11396503, timestamp=1672421548475, source='peer recovery'}, peer_recovery/ZFdsWwXnQPaYw9zQCck9Eg=RetentionLease{id='peer_recovery/ZFdsWwXnQPaYw9zQCck9Eg', retainingSequenceNumber=11396503, timestamp=1672423345358, source='peer recovery'}}}] after expiration check
[2022-12-30T18:22:36,247][INFO ][o.o.i.s.IndexShard       ] [runTask-0] [geonames][0] background syncing retention leases [RetentionLeases{primaryTerm=3, version=82, leases={peer_recovery/_66hjBZaQaGdr4eM81BbUg=RetentionLease{id='peer_recovery/_66hjBZaQaGdr4eM81BbUg', retainingSequenceNumber=11396503, timestamp=1672421548475, source='peer recovery'}, peer_recovery/ZFdsWwXnQPaYw9zQCck9Eg=RetentionLease{id='peer_recovery/ZFdsWwXnQPaYw9zQCck9Eg', retainingSequenceNumber=11396503, timestamp=1672423345358, source='peer recovery'}}}] after expiration check
[2022-12-30T18:22:58,061][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] cloning primary's retention lease
[2022-12-30T18:22:58,067][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] cloned primary's retention lease as [RetentionLease{id='peer_recovery/J8UB_CreR3eLksYcTYTarg', retainingSequenceNumber=11396503, timestamp=1672424577973, source='peer recovery'}]
[2022-12-30T18:22:58,142][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: took [0s]
[2022-12-30T18:22:58,145][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: prepare remote engine for translog
[2022-12-30T18:22:58,204][INFO ][o.o.i.r.SegmentReplicationTarget] [runTask-1] [geonames][0] [shardId 0] Replica starting replication [id 2]
[2022-12-30T18:22:58,181][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase1]: remote engine start took [36.1ms]
[2022-12-30T18:22:58,213][INFO ][o.o.i.r.SegmentReplicationTarget] [runTask-1] [geonames][0] Replication diff RecoveryDiff{identical=[name [_4e3.nvd], length [71085134], checksum [30wnt9], writtenBy [9.5.0], name [_4e3_Lucene90_0.tip], length [12739182], checksum [a5f4c], writtenBy [9.5.0], name [_4e3_Lucene90_0.dvm], length [3312], checksum [1hw81ay], writtenBy [9.5.0], name [_4e3_Lucene90_0.doc], length [333209690], checksum [c5znp9], writtenBy [9.5.0], name [_4e3_Lucene90_0.tim], length [501129690], checksum [1akj3ua], writtenBy [9.5.0], name [_4e3.nvm], length [535], checksum [11ui58n], writtenBy [9.5.0], name [_4e3.fnm], length [4448], checksum [tac9zs], writtenBy [9.5.0], name [_4e3.kdd], length [202634252], checksum [est16h], writtenBy [9.5.0], name [_4e3.si], length [603], checksum [bdefyh], writtenBy [9.5.0], name [_4e3_Lucene90_0.tmd], length [2759], checksum [792l51], writtenBy [9.5.0], name [_4e3.fdm], length [2008], checksum [167u17q], writtenBy [9.5.0], name [_4e3.kdi], length [447867], checksum [5mqwzi], writtenBy [9.5.0], name [_4e3.fdt], length [1165257249], checksum [w6c6q7], writtenBy [9.5.0], name [_4e3_Lucene90_0.pos], length [52197628], checksum [1vwx6db], writtenBy [9.5.0], name [_4e3.kdm], length [412], checksum [1aqd8pn], writtenBy [9.5.0], name [_4e3.fdx], length [184379], checksum [ekorv3], writtenBy [9.5.0], name [_4e3_Lucene90_0.dvd], length [599322206], checksum [13axavd], writtenBy [9.5.0]], different=[], missing=[]}
[2022-12-30T18:22:58,183][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase2]: sending transaction log operations (from [11396503] to [11396502]
[2022-12-30T18:22:58,188][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] recovery [phase2]: took [5ms]
[2022-12-30T18:22:58,188][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] finalizing recovery
[2022-12-30T18:22:58,195][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] performing relocation hand-off
[2022-12-30T18:22:58,208][INFO ][o.o.i.r.SegmentReplicationSourceService] [runTask-0] [replication id 2] Source node sent checkpoint info [ReplicationCheckpoint{shardId=[geonames][0], primaryTerm=4, segmentsGen=15, seqNo=11396502, version=11414}] to target node [J8UB_CreR3eLksYcTYTarg], timing: 1
[2022-12-30T18:23:01,742][INFO ][o.o.i.r.RecoverySourceHandler] [runTask-0] [geonames][0][recover to runTask-1] finalizing recovery took [3.5s]
[2022-12-30T18:23:01,678][INFO ][o.o.i.r.RecoveryTarget   ] [runTask-1] [geonames][0] [shardId 0] [replication id 2] Replication complete, timing data: [Tuple [v1=INIT, v2=1], Tuple [v1=REPLICATING, v2=0], Tuple [v1=GET_CHECKPOINT_INFO, v2=4], Tuple [v1=FILE_DIFF, v2=4], Tuple [v1=GET_FILES, v2=1], Tuple [v1=FINALIZE_REPLICATION, v2=3461], Tuple [v1=OVERALL, v2=3472]]

ubuntu@ip-172-31-41-165:~$ curl localhost:9200/_cat/shards?v
index    shard prirep state       docs store ip        node
geonames 0     r      STARTED 11396503 2.7gb <IP_ADDRESS> runTask-2
geonames 0     p      STARTED 11396503 2.7gb <IP_ADDRESS> runTask-0
ubuntu@ip-172-31-41-165:~$ curl localhost:9200/_cat/segments?v
index    shard prirep ip        segment generation docs.count docs.deleted  size size.memory committed searchable version compound
geonames 0     r      <IP_ADDRESS> _4e3          5691   11396503            0 2.7gb           0 true      true       9.5.0   false
geonames 0     p      <IP_ADDRESS> _4e3          5691   11396503            0 2.7gb           0 true      true       9.5.0   false

Closing as https://github.com/opensearch-project/OpenSearch/pull/5344 is merged.


CMakeList.txt catkin_make error undefined reference openCV

On ROS kinetic 16.04  latest commit made catkin_make not possible to build the package:
undefined reference to `cv::resizeWindow(cv::String const&, int, int)'
I suspect commit: c30619a5b5432f62205482973e87afacb1499d87 from @kunaltyagi
I went back to commit 42e31571ed257d7d0eb1c069892ab868dbe299dc and it is perfectly working and compiling.
For now I have not identified the error.

cv::resizeWindow(cv::String const&, int, int) is present all the way back in v2.4

Yes I know but it is not the error. It is a linking error due to the cleaning of the CMakeLists.txt, I guess. I have just point this undefined reference but I have plenty more in the error. And when I go back just from one commit behind it is perfectly working without changing anything.

It is a linking error due to the cleaning of the CMakeLists.txt

Got it. Could you provide the following 2:

CMake config (output of building a package from scratch, before the building/linking prompts with percentage)
Verbose build/link commands that fail (using VERBOSE=1 <command used to build> and finding the lines just above the error)

@kunaltyagi Hi I was having some issues with catkin make after I installed your files from the pull request to make darknet ros compatible with open cv 4. After changing
if (CUDA_FOUND)
  link_directories(
    #${CUDA_TOOLKIT_ROOT_DIR}/lib
  )

to
if (CUDA_FOUND)
  link_directories(
    /usr/local/cuda/lib64
  )

it worked.
This was the error I was getting:
/usr/bin/ld: cannot find -lcudart
/usr/bin/ld: cannot find -lcublas
/usr/bin/ld: cannot find -lcurand
collect2: error: ld returned 1 exit status
darknet_ros/darknet_ros/CMakeFiles/darknet_ros_lib.dir/build.make:1961: recipe for target '/home/jorge/catkin_ws/devel/lib/libdarknet_ros_lib.so' failed
make[2]: *** [/home/jorge/catkin_ws/devel/lib/libdarknet_ros_lib.so] Error 1
CMakeFiles/Makefile2:3141: recipe for target 'darknet_ros/darknet_ros/CMakeFiles/darknet_ros_lib.dir/all' failed
make[1]: *** [darknet_ros/darknet_ros/CMakeFiles/darknet_ros_lib.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
Invoking "make -j4 -l4" failed

#${CUDA_TOOLKIT_ROOT_DIR}/lib

That's a mistake if so. It should be  ${CUDA_TOOLKIT_ROOT_DIR}/lib (no hash/pound)

Yeah sorry that’s a copy from my code where I commented out that line in my file

This is a wrong place to discuss this particular error, but old cmake versions (or bad findCuda modules) can result in such errors. Hard-coding the location of cuda is harmful for the generic user.


Format of Operations is unknown

The JSON format of operations in API function "Apply operations" is unknown.