Support a list of "include" search paths

The Apache Thrift compiler lets you specify a list of paths to search for included files:
  -I dir      Add a directory to the list of directories
                searched for include directives

We should add a similar capability to our generator, probably configured via a thrift_includes: [] value.

Implemented by #219


add notes for that strategic merge patch is unsupported for CR

Per https://github.com/kubernetes/kubernetes/issues/97423#issuecomment-749312425,  strategic merge patch is unsupported for Custom Resource objects

/assign @tengqm

/sig api-machinery

Markdown LGTM. I made a suggestion; it's fine to merge the text as-is providing this gets a tech review signoff.

Accept it. Thanks @sftim

/assign @tengqm

/assign @tengqm

/unassign
I'm not sure about the strategic merge patch details.

/unassign
I'm not sure about the strategic merge patch details.

@prasadkatti can you have a look？

@prasadkatti can you have a look？

need /approve @sftim

need /approve @sftim

/lgtm

/lgtm

/approve

/approve


Add asset page asset hash link

We should add the ability for people to directly link to assets on the asset page. We could link to an asset by with: /assets#DENOM. The app would directly scroll to that asset in the page.

6/28 sprint planning -
Victor: valuable because it makes our app more shareable, though the link should be human readable.

Will be removing asset page as we know it


Reduce logo filesize

Sorry, this is what I meant by #39. It's a mobile-oriented site; the icon shouldn't be 100 KB.
First I shrunk it to double its display size (which is recommended for high-density screens; I notice no change on my Retina screen). Then I ran optipng on it which performs lossless compression.
Note that all of the extra blank space around this logo indicates that it can (and should) be reduced further (and further shrinking can happen if #64 goes through). I didn't want to muck about in any spacing though for a first pass.

:+1 to merge this. Thanks, @JacobEvelyn!

Thanks for the review!

Are there browsers that this project is committed to support? If support for IE8 isn't required then perhaps an svg logo would make more sense as it will have a smaller file size and scale for larger/higher density displays.

Great question @tomleo. I'd guess IE8 support isn't a concern given this is targeted at mobile. Would you be able to make an SVG version of the logo?
(Please confirm we don't want IE8 support @radhikamalik @geoffreylitt @davidlago.)

@JacobEvelyn I have not worked with design software for a long time (I'm mostly a backend developer), but I could give it a shot. Who created the original Icon? And what program was used? If Illustrator or Photoshop was used then I believe you can export the image as SVG.

Thanks for this @JacobEvelyn :heart:
@tomleo unfortunately we have a vector asset for this image, so I'm not sure it's worth the effort to convert a bitmap to SVG.

I don't know much about SVG editing but it feels like it wouldn't be
terrible to build from scratch. On the other hand, a small PNG is probably
fine for our purposes.
On Thu, Feb 26, 2015 at 9:58 PM, Geoffrey Litt<EMAIL_ADDRESS>wrote:

Thanks for this @JacobEvelyn https://github.com/JacobEvelyn [image:
:heart:]
@tomleo https://github.com/tomleo unfortunately we have a vector asset
for this image, so I'm not sure it's worth the effort to convert a bitmap
to SVG.
—
Reply to this email directly or view it on GitHub
https://github.com/davidlago/mbta-ninja/pull/65#issuecomment-76322670.


Changing themes is buggy

Oni Version: 0.3.6
Neovim Version (Linux only):
Operating System: Microsoft Windows 10 x64 v1709, build nº16299.15
Issue: Changing themes is buggy and laggy it slows Oni down so much.
Expected behavior: Like in VSCode or Atom, when i select a theme, it instantaneously changes the actual theme to the new i selected. In Oni, this doesn't happen.
Actual behavior: It takes so much to change between themes, when i select one in the command palette, the screen flashes and the theme starts to load slowly. After about 5-10 seconds i can use Oni normally again.
Steps to reproduce: Just open up the command palette and select Themes => Choose theme and select any theme from the list.
I understand that this is still an experimental / beta version, but even with all the bugs, the development team is to be congratulated! It really is a beautiful job! Thank you :) 👍

Glad to know it is an easy thing to fix. Thanks for the support :D

Can i take it?

@koutselakismanos that would be fantastic 🎉 let me know if you need any help

@Akin909 What are you suggesting that should be done? When using x mode  :colorscheme gruvbox or :colorscheme node it works properly, i tried checking if there is a problem when configuration.setValues({ "ui.colorscheme": newOption.label }) or when  themeManager.setTheme(newOption.label)
but i can't seem to find the problem.

I think the problem @koutselakismanos is in the command pallete theme switcher.
That is, Ctrl-Shift-P (cmd-shift-p on mac) and then select the theme changer. You can swap themes there, and highlighting a different theme will swap to that theme, but seems to cause some flickering and other issues where the theme doesn't swap and more.

@CrossR I meant i can't seem to find the solution, i have managed to fix the problem but not completely, there is still some flickering but only if you change themes really fast. I will keep trying to solve the problem.


Introduce DTypePolicyMap

ORIGINAL FROM #19783
Sorry for the inconvenience.
I have tried to implement the idea mentioned by @mattdangerw :
https://github.com/keras-team/keras-nlp/pull/1612
I think this idea is clean and only requires some small changes to support mixing dtype policies into subclasses.
In general, DTypePolicyMap is similar to LayoutMap as it contains a dict to record the (layer name, policy) pair.
The limitations / overheads of using DTypePolicyMap:

Each layer must have a unique name (auto_name might fail)
Some extra logic needs to be added in get_config for the top class (ex: Backbone in KerasCV and KerasNLP)

The basic usage  (adding quantization support for MultiHeadAttention):

import keras
from keras import dtype_policies
from keras import ops
import numpy as np

@keras.saving.register_keras_serializable("MyPackage")
class MyMultiHeadAttention(keras.layers.MultiHeadAttention):
    def get_config(self):
        config = super().get_config()
        # `default_policy=None` enables us to defer to
        # `keras.config.dtype_policy` during loading.
        dtype_policy_map = dtype_policies.DTypePolicyMap(default_policy=None)
        for layer in self._flatten_layers():
            if layer.dtype_policy.is_quantized:
                dtype_policy_map[layer.name] = layer.dtype_policy
        if len(dtype_policy_map) > 0:
            config.update({"dtype": dtype_policy_map})
        return config

query = keras.Input(shape=[4, 6])
value = keras.Input(shape=[4, 6])
outputs = MyMultiHeadAttention(2, 4, name="my_mha")(query, value)
model = keras.Model([query, value], outputs)

x_query = keras.random.uniform([2, 4, 6])
x_value = keras.random.uniform([2, 4, 6])
print(f"Saving stage, global policy: {keras.config.dtype_policy()}")
model.quantize("int8")
for layer in model._flatten_layers(include_self=False, recursive=True):
    print(layer.name, layer.dtype_policy)
model.save("model.keras")
y = model([x_query, x_value])

keras.config.set_dtype_policy("mixed_bfloat16")
print(f"Loading stage, global policy: {keras.config.dtype_policy()}")
new_model = keras.models.load_model("model.keras")
for layer in new_model._flatten_layers(include_self=False, recursive=True):
    print(layer.name, layer.dtype_policy)
ref_y = new_model([x_query, x_value])

np.testing.assert_allclose(
    ops.convert_to_numpy(y),
    ops.convert_to_numpy(ops.cast(ref_y, "float32")),
    atol=1e-2,
)

Outputs:
Saving stage, global policy: <FloatDTypePolicy "float32">
input_layer <FloatDTypePolicy "float32">
input_layer_1 <FloatDTypePolicy "float32">
my_mha <FloatDTypePolicy "float32">
attention_output <QuantizedDTypePolicy "int8_from_float32">
dropout <FloatDTypePolicy "float32">
softmax <FloatDTypePolicy "float32">
value <QuantizedDTypePolicy "int8_from_float32">
key <QuantizedDTypePolicy "int8_from_float32">
query <QuantizedDTypePolicy "int8_from_float32">

Loading stage, global policy: <FloatDTypePolicy "bfloat16">
input_layer <FloatDTypePolicy "mixed_bfloat16">
input_layer_1 <FloatDTypePolicy "mixed_bfloat16">
my_mha <FloatDTypePolicy "mixed_bfloat16">
attention_output <QuantizedDTypePolicy "int8_from_mixed_bfloat16">
dropout_1 <FloatDTypePolicy "mixed_bfloat16">
softmax_1 <FloatDTypePolicy "mixed_bfloat16">
value <QuantizedDTypePolicy "int8_from_mixed_bfloat16">
key <QuantizedDTypePolicy "int8_from_mixed_bfloat16">
query <QuantizedDTypePolicy "int8_from_mixed_bfloat16">

Some updates:

A high-level description has been added, as suggested by @mattdangerw
An internal property, dtype_argument, has been introduced to store the passed argument. dtype_argument can be further utilized in build (e.g., in MultiHeadAttention).

Codecov Report
Attention: Patch coverage is 80.41237% with 19 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (84b283e) to head (1c01d4e).

Files
Patch %
Lines

keras/src/dtype_policies/dtype_policy_map.py
84.37%
7 Missing and 3 partials :warning:

keras/src/dtype_policies/dtype_policy.py
78.94%
2 Missing and 2 partials :warning:

keras/src/dtype_policies/__init__.py
33.33%
1 Missing and 1 partial :warning:

keras/src/ops/operation.py
66.66%
1 Missing and 1 partial :warning:

...ras/api/_tf_keras/keras/dtype_policies/__init__.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19858       +/-   ##
===========================================
- Coverage   78.83%   57.00%   -21.84%
===========================================
  Files         498      499        +1
  Lines       45864    45955       +91
  Branches     8450     8472       +22
===========================================
- Hits        36159    26196     -9963
- Misses       7999    18147    +10148
+ Partials     1706     1612       -94

Flag
Coverage Δ

keras
57.00% <80.41%> (-21.70%)
:arrow_down:

keras-jax
?

keras-numpy
57.00% <80.41%> (+0.04%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @mattdangerw @fchollet
I have successfully brought quantization support for Gemma with this PR.
This should provide high confidence that DTypePolicyMap works.
Here is the implementation in just 1 script:
(The actual modifications are small)

import numpy as np
from keras_nlp.src.layers.modeling.reversible_embedding import (
    ReversibleEmbedding,
)
from keras_nlp.src.layers.modeling.rotary_embedding import RotaryEmbedding
from keras_nlp.src.models.backbone import Backbone
from keras_nlp.src.models.gemma.gemma_attention import CachedGemmaAttention
from keras_nlp.src.models.gemma.gemma_backbone import GemmaBackbone
from keras_nlp.src.models.gemma.gemma_decoder_block import GemmaDecoderBlock
from keras_nlp.src.models.gemma.rms_normalization import RMSNormalization

import keras
from keras import dtype_policies
from keras import ops

@keras.saving.register_keras_serializable()
class MyCachedGemmaAttention(CachedGemmaAttention):
    def build(self, inputs_shape):
        self.hidden_dim = inputs_shape[-1]
        self.query_dense = keras.layers.EinsumDense(
            "btd,ndh->btnh",
            output_shape=(None, self.num_query_heads, self.head_dim),
            kernel_initializer=self._kernel_initializer,
            dtype=self.dtype_argument,
            name="query",
        )
        self.query_dense.build(inputs_shape)
        self.key_dense = keras.layers.EinsumDense(
            "bsd,kdh->bskh",
            output_shape=(None, self.num_key_value_heads, self.head_dim),
            kernel_initializer=self._kernel_initializer,
            dtype=self.dtype_argument,
            name="key",
        )
        self.key_dense.build(inputs_shape)
        self.value_dense = keras.layers.EinsumDense(
            "bsd,kdh->bskh",
            output_shape=(None, self.num_key_value_heads, self.head_dim),
            kernel_initializer=self._kernel_initializer,
            dtype=self.dtype_argument,
            name="value",
        )
        self.value_dense.build(inputs_shape)
        self.dropout_layer = keras.layers.Dropout(
            rate=self.dropout,
            dtype=self.dtype_argument,
        )
        self.output_dense = keras.layers.EinsumDense(
            equation="btnh,nhd->btd",
            output_shape=(None, self.hidden_dim),
            kernel_initializer=self._kernel_initializer,
            dtype=self.dtype_argument,
            name="attention_output",
        )
        self.output_dense.build(
            (None, None, self.num_query_heads, self.head_dim)
        )
        self.softmax = keras.layers.Softmax(dtype="float32")
        self.rope_layer = RotaryEmbedding(
            max_wavelength=10_000.0, dtype=self.dtype_argument
        )
        self.built = True

@keras.saving.register_keras_serializable()
class MyGemmaDecoderBlock(GemmaDecoderBlock):
    def __init__(
        self,
        hidden_dim,
        intermediate_dim,
        head_dim,
        num_query_heads,
        num_key_value_heads,
        layer_norm_epsilon=1e-6,
        dropout=0,
        **kwargs,
    ):
        keras.layers.Layer.__init__(self, **kwargs)
        self.intermediate_dim = intermediate_dim
        self.hidden_dim = hidden_dim
        self.num_query_heads = num_query_heads
        self.num_key_value_heads = num_key_value_heads
        self.head_dim = head_dim
        self.layer_norm_epsilon = layer_norm_epsilon
        self.dropout = dropout
        self.pre_attention_norm = RMSNormalization(
            epsilon=self.layer_norm_epsilon,
            dtype=self.dtype_argument,
            name="pre_attention_norm",
        )
        self.attention = MyCachedGemmaAttention(
            head_dim=head_dim,
            num_query_heads=num_query_heads,
            num_key_value_heads=num_key_value_heads,
            dropout=dropout,
            dtype=self.dtype_argument,
            name="attention",
        )
        if self.dropout > 0:
            self.attention_dropout = keras.layers.Dropout(rate=dropout)
            self.feedforward_dropout = keras.layers.Dropout(rate=dropout)
        self.pre_ffw_norm = RMSNormalization(
            epsilon=self.layer_norm_epsilon,
            dtype=self.dtype_argument,
            name="pre_ffw_norm",
        )
        self.gating_ffw = keras.layers.EinsumDense(
            equation="btd,df->btf",
            output_shape=(None, self.intermediate_dim // 2),
            dtype=self.dtype_argument,
            name="ffw_gating",
        )
        self.gating_ffw_2 = keras.layers.EinsumDense(
            equation="btd,df->btf",
            output_shape=(None, self.intermediate_dim // 2),
            dtype=self.dtype_argument,
            name="ffw_gating_2",
        )
        self.ffw_linear = keras.layers.EinsumDense(
            equation="btf,fd->btd",
            output_shape=(None, self.hidden_dim),
            dtype=self.dtype_argument,
            name="ffw_linear",
        )

@keras.saving.register_keras_serializable()
class MyGemmaBackbone(GemmaBackbone):
    def __init__(
        self,
        vocabulary_size,
        num_layers,
        num_query_heads,
        num_key_value_heads,
        hidden_dim,
        intermediate_dim,
        head_dim,
        layer_norm_epsilon=1e-6,
        dropout=0,
        dtype=None,
        dtype_policy_map=None,
        **kwargs,
    ):
        if dtype_policy_map is not None:
            dtype_policy_map = keras.dtype_policies.deserialize(
                dtype_policy_map
            )
        if dtype is None and dtype_policy_map is not None:
            dtype_policy_map._default_policy = keras.dtype_policies.get(dtype)
            dtype = dtype_policy_map
        self.token_embedding = ReversibleEmbedding(
            input_dim=vocabulary_size,
            output_dim=hidden_dim,
            tie_weights=True,
            embeddings_initializer=keras.initializers.VarianceScaling(
                scale=1.0,
                mode="fan_in",
                distribution="untruncated_normal",
                seed=None,
            ),
            dtype=dtype,
            name="token_embedding",
        )
        self.transformer_layers = []
        for i in range(num_layers):
            layer = MyGemmaDecoderBlock(
                intermediate_dim=intermediate_dim,
                hidden_dim=hidden_dim,
                num_query_heads=num_query_heads,
                head_dim=head_dim,
                num_key_value_heads=num_key_value_heads,
                dropout=dropout,
                dtype=dtype,
                name=f"decoder_block_{i}",
            )
            self.transformer_layers.append(layer)
        self.layer_norm = RMSNormalization(
            epsilon=layer_norm_epsilon,
            dtype=dtype,
            name="final_normalization",
        )
        # === Functional Model ===
        token_id_input = keras.Input(
            shape=(None,), dtype="float32", name="token_ids"
        )
        padding_mask_input = keras.Input(
            shape=(None,), dtype="float32", name="padding_mask"
        )
        x = self.token_embedding(token_id_input)
        x = x * ops.cast(ops.sqrt(hidden_dim), x.dtype)
        for transformer_layer in self.transformer_layers:
            x = transformer_layer(x, padding_mask=padding_mask_input)
        sequence_output = self.layer_norm(x)
        Backbone.__init__(
            self,
            inputs={
                "token_ids": token_id_input,
                "padding_mask": padding_mask_input,
            },
            outputs=sequence_output,
            dtype=(
                dtype
                if not isinstance(dtype, keras.dtype_policies.DTypePolicyMap)
                else dtype.default_policy
            ),
            **kwargs,
        )
        # === Config ===
        self.vocabulary_size = vocabulary_size
        self.num_layers = num_layers
        self.num_query_heads = num_query_heads
        self.num_key_value_heads = num_key_value_heads
        self.hidden_dim = hidden_dim
        self.intermediate_dim = intermediate_dim
        self.head_dim = head_dim
        self.layer_norm_epsilon = layer_norm_epsilon
        self.dropout = dropout

    def get_config(self):
        config = super().get_config()
        dtype_policy_map = dtype_policies.DTypePolicyMap(default_policy=None)
        for layer in self._flatten_layers():
            if (
                layer.dtype_policy.is_quantized
                and layer.name not in dtype_policy_map
            ):
                dtype_policy_map[layer.name] = layer.dtype_policy
        if len(dtype_policy_map) > 0:
            config.update({"dtype_policy_map": dtype_policy_map})
        return config

gemma_backbone = MyGemmaBackbone(256128, 2, 4, 4, 128, 256, 128, 1e-6)
token_ids = keras.ops.ones((2, 5), "int32")
padding_mask = keras.ops.ones((2, 5), "int32")
inputs = {"token_ids": token_ids, "padding_mask": padding_mask}

gemma_backbone.quantize("int8")
print("`gemma_backbone` has been quantized to int8")
y = gemma_backbone(inputs)
config = gemma_backbone.get_config()
gemma_backbone.save("model.keras")

reloaded_gemma_backbone = keras.saving.load_model("model.keras")
reloaded_y = reloaded_gemma_backbone(inputs)

np.testing.assert_allclose(
    keras.ops.convert_to_numpy(y),
    keras.ops.convert_to_numpy(reloaded_y),
)
print("The outputs are all closed!")

The modifications are as follows:

Replace the plain dtype with dtype_argument introduced by this PR.
dtype_argument is the passed dtype argument store in Operation and it could be a str, DTypePolicy or DTypePolicyMap
Determine the dtype passed to subclasses and sublayers in GemmaBackbone.__init__

That's all. Super simple. It should even be feasible to do this in Backbone and apply it to all models.
Please let me know what you think. Thanks!

Looking good -- I'll wait to hear from @mattdangerw before merging.

@james77777778 looks good!
Still a couple things that I think we might want to fix up with the high level UX.

Layer names are often not unique.
The pathing for this and keras.distribution.LayoutMap are very different. Which feels confusing for users.

I'm gonna put together a quick commit on how we could deal with this and share it with you, just to get some thoughts. Or I'll try to do it today, and realize a bunch of places I'm missing things :). Either way I'll post back here soon!

Ok, I'll keep testing this out, but just to share early the idea is here...
https://github.com/james77777778/keras/compare/dtype-policy-map-2...mattdangerw:keras:dtype-policy-map-idea

Make the map another DTypePolicy subclass.
Add a self.quantization_mode property on the base layer, much like self.compute_dtype and self.variable_dtype.
Have all those properties on the base layer pull the correct policy form the map.
Lastly, use the build time name scope to look up by keys. So the names work the same way as keras.distribution.LayoutMap.

Here's a colab with a little more usage -> https://colab.research.google.com/gist/mattdangerw/aee1ce80eb8128dff3911ea3442d68af/dtypemap-usages.ipynb
I think there's some advantages here.

Everything passed as dtype resolves to a DTypePolicy object.
Supports global and local setting of these policy maps.
Supports specifying policies by the full name scope paths, e.g. "encoder/.*/query" and decoder/.*/value.
Does not change the way dtype should be proxied from layer -> sublayer. Pass self.dtype_policy.
Delegating resolving quantization_mode to the base layer is similar to how we handle compute_dtype and variable_dtype. Simpler division of responsibilities, cleans up the dense/embedding layers a bit.

Very possible I am still missing some cases though. Let me know what you think!

Hey @mattdangerw
This is great. It really simplifies the high-level logic!
The only issue I see is that we now rely on self.built to get the correct policy.
The properties of the layer might be wrong before the build, no?
Could I merge these changes and see how it goes, or do you prefer building it in your fork?

Could I merge these changes and see how it goes, or do you prefer building it in your fork?

Yeah, merge away!
Re the build before/after problem. Yeah, I couldn't really figure out a way around that. Basically, we don't have a reliable way to get the name scope until we have built. We could consider extend the name scope to layer init time, but layers might be initialized in a weird order (e.g. function model is layers first, than model). It's really only at build/call time we can construct the correct nested name scope.
I was content to let that be a quirk of how these are applied, but @fchollet do you have any thoughts here?

I have fixed the CI and made some minor changes:

Simplify the logic of *_dtype by utilizing self.dtype_policy
Rely on self.build_name_scope instead of self.built in self.dtype_policy because we need the correct policy during build
Raise an error if there is a nested DTypePolicyMap
Fix the dtype_policy setter
Fix the quantize in Dense, Einsum and Embedding

Should be ready for reviewing.
@mattdangerw @fchollet

LGTM -- will defer to @mattdangerw for final approval. Thank you!

The failure seems to be an unrelated issue.
I was able to successfully pass all tests with my CUDA rig.
One question:
Once this PR is merged, will there be a new release of Keras?
If so, I can proceed to implement quantization support for KerasNLP.

Once this PR is merged, will there be a new release of Keras?
If so, I can proceed to implement quantization support for KerasNLP.

Awesome -- yes, we'll release a new Keras version on Monday.


PFCP Session Establishment Request missing Forwarding Parameters IE

Dear Team,
Using test scripts and all core Stage3 functions with a different vendor UPF, this was complaining about lack of Forwarding Parameters IE when creating the tunnel. As per specification TS. 29.244, if FAR indicates FORW within Apply Action IE the forwarding rule shall include Forwarding Parameters IE. I checked captures from Stage 2 and SMF was correctly generating this IE.
It can be reproduced just running the default
./test.sh -o TestRegistration

Therein I think as in Stage2 it should include Destination Interface and Network Instance (APN).

I think that is a bug, we'll working on it.
Thanks for your report!

Dear @daniel-garciasanchez ,
free5GC has fix this bug on v3.0.3. Please try and test it.
Thanks for your report!

The parameter below should be "Core", not "Access", right?
As it's for PDR ID 1(uplink traffics) and should be forward to DN(Core). Thanks!

Hi @Qxff ,
This seems to be free5GC's bug.
Thanks for your report.

@free5gc-org Trying the same test on v3.1.0 and same issue happens:

Related issue on smf repository: https://github.com/free5gc/smf/issues/55


Integrate Spotless to format Java/Kotlin code

The Spotless provides the rich functionality to format Java and Kotlin source code. We can use it to format current source code, and keep format persistence for newer commit. @farmerbb what's your opinion about it?

The Google's android-fhir uses the Spotless to format code, and integrate it with GitHub Action.

The android/compose-samples also use Spotless to format code.


[Bug]: Searching profiles and fetching resume giving error

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

Expected behavior
There shouldn't be errors and resume should be generated.
Add ScreenShots
No response
On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[ ] I'm a GSSOC'24 contributor
[X] I have starred the repository

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

This issue has been automatically closed because it has been inactive for more than 30 days. If you believe this is still relevant, feel free to reopen it or create a new one. Thank you!

Hello @ashutosh-rath02! Your issue #458 has been closed. Thank you for your contribution!


Texture unit out of range

After several blendTo calls changing a symbol, you get an activeTexture: texture unit out of range error like:
WebGL: INVALID_ENUM: activeTexture: texture unit out of range
[.WebGL-0x7fe4fc860e00]GL ERROR :GL_INVALID_VALUE : glUniform1i: texture unit out of range

Example: https://jsfiddle.net/vac07t93/ from https://github.com/CartoDB/carto-vl/issues/1053.
This could be similar to https://github.com/CartoDB/carto-vl/issues/103.

@CartoDB/support-team please notify SB 22803250 when this is fixed.


HDDS-4923. Added acceptance test

What changes were proposed in this pull request?
This is a test task to add acceptance test for S3.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4923
How was this patch tested?
Modified S3 acceptance test.

Thanks @mukul1987 , @sadanand48 for the review help!
I will merge this to the feature branch.


removed all references to init.d file, for #312

part of #312 ... removing support of laying down init.d file as the 5.0 RPM already does so.

Thanks for this. While this patch wasn't directly merged into master, the work it represents is now part of the new-and-improved module version. 🍻


Upstream master/backup

Does ERPC support upstream selection based on master/backup logic. The idea being that the requests should only be forwarded to the master unless the master is unavailable or as fall behind following the chain head or any other serious issues.
The use case is that the master is a local cheap node and latency is not critical.

With the current scoring mechanism only health aspects are considered (latency, rate limits, failures, etc). These scores will be used as a 'weight' when selecting an upstream, so a 'weighted random selection' happens using these scores.
I think your use-case is pretty common that you'd want to give higher weight to a particular upstream. There are few approaches I'm thinking about:

(1) Allow users assign a weight (0.0 to 1.0) which intentionally skews the scores in favor of an upstream.
or, (2) Introduce a concept like 'priority tiers' where you can define 'low' and 'high' tiers for example, and as long as even 1 upstream is is 'alive' stick with the same tier. Definition of 'alive' can be simple or complex (error rate threshold, latency threshold, etc)

Generally 'upstream selection' always brings up these questions:

When exactly would you consider an upstream broken?
How often and with what strategy would want to 'give an upstream a chance' to prove themselves?
Do you sort upstreams and try from best ones? Or do you treat them on/off and completely disable the bad ones?

Basically a trade off of Cost (e.g. redundant/hedged calls, cpu/mem pressure, 3rd party provider billing) vs Performance (how fast requests are served) and Resiliency (how often we finally get a good response).

Also have thought about another idea to introduce a standByRules config on upstream-level:
      - id: my-cheap-node-1
         endpoint: http://my-veeery-cheap-node1.svc.cluster.local
      - id: my-cheap-node-2
         endpoint: http://my-veeery-cheap-node2.svc.cluster.local
      - id: my-cheap-node-3
         endpoint: http://my-veeery-cheap-node2.svc.cluster.local

      - id: my-semi-somewhat-affordable-node
        endpoint: https://www.blastapi.io/xxxxxxxxx
        standByRules:
          - bringAsBackupIf:
              minAvailableUpstreamsLessThan: 3 # bring in if any of cheap ones are down
              errorRateHigherThan: 0.5 # OR if error rates are >=50% on other upstreams
              latencyP90HigherThan: 3s # OR if current upstreams have too high p90 latency

      - id: my-veeeery-expensive-node
        endpoint: https://infura.io/xxxxxxxxx
        standByRules:
          - bringAsBackupIf:
              minAvailableUpstreamsLessThan: 1 # bring in if no upstream is available
              errorRateHigherThan: 0.95 # OR if error rates are >=95% on other upstreams
              latencyP90HigherThan: 10s # OR if current upstreams have too high p90 latency

This allows to define these on upstream-level and express that by default these nodes must be standby, and brought on certain conditions.
I'm still thinking about the best way to express this (e.g. maybe on network-level? maybe a more generic idea like 'tier's so we can extend beyond standby use-case, etc).

For me, the rules concept is the best idea for controlling the behavior of how it should forward the request to upstream. I agree it should be generic enough to allow other use cases.
The standby wouldn't be completely idle, right? because the proxy would still have to compare the head of each upstream to unsure that the active upstream is not stuck somewhere.

After giving more thoughts introducing inclusion/exclusion rules seems like an interesting idea:
- id: my-cheap-node-1
  endpoint: http://my-veeery-cheap-node1.svc.cluster.local
- id: my-cheap-node-2
  endpoint: http://my-veeery-cheap-node2.svc.cluster.local

- id: my-cheap-node-3
  endpoint: http://my-veeery-cheap-node2.svc.cluster.local
  exclusionRules:
    - whenMetrics:
        errorRateHigherThan: 0.95 # OR if error rate is >=95%
        blockHeadLagHigherThan: 1000 # OR if block lag is > 1,000 blocks

- id: my-semi-somewhat-affordable-node
  endpoint: https://www.blastapi.io/xxxxxxxxx
  exclusionRules:
    - excludeByDefault: true
    - whenMetrics:
        errorRateHigherThan: 0.60
  inclusionRules:
    - whenIncludedUpstreams:
        lessThan: 2

- id: my-veeeery-expensive-node
  endpoint: https://infura.io/xxxxxxxxx
  exclusionRules:
    - excludeByDefault: true
    - whenMetrics:
        errorRateHigherThan: 0.60
  inclusionRules:
    - whenIncludedUpstreams:
        lessThan: 1

The standby wouldn't be completely idle, right? because the proxy would still have to compare the head of each upstream to unsure that the active upstream is not stuck somewhere.

That's right, the process that determines an upstream's health should be always running in the background, and only inclusion/exclusion of such node must be impacted by this new module.

I think inclusion/exclusion rules cover pretty well situations where there are intermittent failures, but for instance in a situation where the node is completely stuck in time (e.g. not processing new blocks), potentially it would not fail for queries about blocks that it already have data, but that node should not be considered healthy.

Implemented in https://github.com/erpc/erpc/pull/69 and is released in 0.0.28 🚀
Docs will be added after some real-world testing. The PR contains a config example for those who want to test it as 'preview' feature.
By default if you just add "fallback" group to upstreams, then a default policy will be added with a simple logic: https://github.com/erpc/erpc/blob/main/common/defaults.go#L412-L431 you can copy-paste and edit the policy if you want, or provide env vars as shown to control it a bit.


Remove more core dependency from ReferencePath

TODO:

[x] handle arrays

I also want more_core_extensions out since this is the only place where we use it.
I was concerned about accessing strings, hashes, or arrays.
It seemed like json supports all 3. (🍅 please)
Does this new code handle all 3?
Glad you moved the @path code into the initializer. I am wondering why we need the map stuff. I think I just don't understand it.

can we test:

The top level object is an array. (we only currently deal with hashes, and I think array is valid. To punt, we can pass in $ as the path.
Is there a way to append to an array? (per the spec)

The top level object is an array.

Absolutely, done.

Is there a way to append to an array? (per the spec)

That is a great question I don't know

Is there a way to append to an array? (per the spec)

That is a great question I don't know

So it looks like [-1:] would mean the last element of an array, but the spec for reference paths specifically says that: The operators "@", ",", ":", and "?" are not supported so that wouldn't be valid.  I was able to easily set e.g. $.[1].title to create a second element in an array that only had one before though which seems like a valid case.

High level is the goal just to drop more core?  If so I'm curious why?

Just trying to cut down on dependencies particularly because more_core brings in activesupport and trying to keep this "clean"

If you ignore the development gems in Gemfile, dropping more_core_extensions drops quite a few gems:

more_core_extensions

active_support

base64
bigdecimal
concurrent-ruby
connection_pool
drb

ruby2_keywords

i18n
minitest
mutex_m
tzinfo

sync

ASIDE: kubeclient has even more dependencies, but not trivial to remove:

kubeclient

http

addressable

public_suffix

http-cookie

domain_name

http-form_data
llhttp-ffi

ffi-compiler

ffi

jsonpath
recursive-open-struct
rest-client

http-accept
(http-cookie)
mime-types

mime-types-data

netrc

bump @Fryguy - you ok with this?


Move veg_hist logic to driver.

Moved veg_hist logic out of vic_run().
Created new function update_step_vars() which currently only updates the veg_var
structure to store the current veg_hist variables.  This is called from vic_classic() in classic mode and from vic_image_run() in image mode.
Added logic to image mode vic_force() to read timeseries (non-climatological) of LAI, albedo, and vegcover from the 2nd forcing file, conditional on those variables' options.VARNAME_SRC being set to FROM_VEGHIST.
In both classic and image mode, the veg_hist array is initialized with climatological values from veg_con, and then optionally overwritted with values from the veg_hist file if options.VARNAME_SRC is set to FROM_VEGHIST.
closes #275
closes #325

This looks good too @tbohn.  A few comments on the implementation, but otherwise this is a nice cleanup of the veghist code.
This is blocked by #357

@tbohn - can you pull in the latest develop branch here.  The travis tests should pass now.

@jhamman OK, I've pulled in the latest develop branch (via merging from create_default_no_soil_evap branch, so that it has the resolution of the merge conflicts that I did there).
I'm still looking for clarification: is it OK to perform the correction of vegcover relative to MIN_VEGCOVER, with a warning message, or did you mean that the warning message would take the place of the correction?  I'm guessing that the warning would be in addition to the correction to avoid division by 0.  I'll go ahead and implement that but if that's not what you meant, please let me know.

@jhamman this is ready for your review...

This looks good.  Merging now.


Async offset will be limited to yaw-only

Random offsets don't play well with new rotational smoothing + reprojection and it doesn't seem like there's a real use case for it. External drift correction can lead to many problems and introduces unneeded complexity to tracking mixing.
The feature will also work incorrectly on high-quality VR devices with reprojection in 2.2.x but those devices don't usually need any drift corrections and it seems extremely unlikely that someone uses it in these scenarios.
If anyone is using it and has no way to replace this feature, please comment on this issue.

I've noticed that setting an offset in the beta version causes strange things to happen. As in the view ports seem to become smaller depending on the offset. Is that related to this?
If we still want to keep offset in check with V4, does this mean switching to the (potentially performance killing) synchronous headtracking API to correct drift?
My own use case is using a Kinect to keep drift on an LG V30 in check (as well as provide headtracking). Otherwise I have to recenter fairly often.

What you're seeing is reprojection correcting the rotation to original orientation. The higher the drift is, the lower the actually rendered viewport will be (because it becomes more and more out of sync). We left this unchanged in 2.2 because we didn't expect that headsets with reprojection (such as your, as it's Daydream-enabled) would require drift correction.
We discussed how to proceed with offset (both sync and async) because there were quite a lot of changes in 2.2.x versions related to positional tracking. In the end, it was extremely time-consuming to make the offset work in all cases (with API tracking, with Nolo tracking, with reprojection enabled, with controllers (AIO or API) and with any kind of combination of listed options). It becomes even more complex with controllers (some controllers can be recentered in their own environment, some controllers need to use our internal recentering (another offset), the complexity grows dramatically with each device's internal orientation system and recentering mechanism.
Eventually we decided to deprecate it because we can't assure that it will work in all cases. You already experience one of those problems (async offset + reprojection).
Your options are:

The wild idea would be to use your external tracking system to detect when you're looking forward and call API's Recenter command every now and then. It might work but I haven't tested it and it might result in some problems. This API call results in the same action on the server side as pressing recenter hotkey.
We can build you an APK of 2.2.6 version that has reprojection disabled. This will significantly affect the smoothness in negative way but will still work with async offset. Let us know if you'd like us to build it.
Stop using offsets until we figure how to bring it back universally to work with all combinations.

Sorry for the trouble. It can be solved with another layer of math and offset matrix recalculations, we just didn't want to spend a week on it because we weren't even sure if someone uses it. We don't have API access keys/analytics so we're sort of blind when it comes to knowing what is actually used by API developers.
We would like to fix it in v4/2.3 but I can't promise anything solid yet. Let me know if any of the above listed options is viable for you until then. We might come up with something else.

Thanks for the comprehensive reply. I've been trying your first idea which sort of works although it's obviously not as flexible as using offset.
I wouldn't like to lose the reprojection as it is quite a nice feature. :) I may just wait and hope that you can come up with an idea to improve this.
I haven't got any other experience with other Daydream devices so I'm not sure if the drift I suffer from is specific to the LG V30. It's noticeably worse than the PS Move controllers.

The Daydream is quite surprising, really. We didn't expect it as it never came up during our testing but it's always possible that we didn't run tests that were long enough to notice it drifting off few degrees.
We hope to have a solution for it because we need to refactor tracking systems a bit anyway. Currently the most limiting factor is API v1 (from VRidge 1.3 if I recall correctly) which is still compatible as Nolo desktop driver uses it so we can't drift off too much from original specs & tracking mixer. We'll figure something out.

Progress update
I'm 99% sure that async offset will stay unchanged and won't have problems with reprojection in 2.3 update. We just need to run all the backwards compatibility tests before being 100% sure.

Current on beta channel (2.3.9), Async offset does not work at all.
I provided yaw data but the camera did not move.
Tried settings:
task type = 201
data = [0, 1, 0], [0, 3.14, 0], [0, 100, 0], [100, 100, 100], [3.14, 3.14, 3.14], [1.57, 1.57, 1.57], [0, (0..10 linear), 0]
All did not work :(
Minor note: Using recenter for drift correction does not feel good because it snaps.

Can you show me a code sample?
I just tested both with new and older v3 API clients and it seems to work as expected.
Desktop example from this repo @ latest public commit (https://github.com/RiftCat/vridge-api/commit/0eef9ce41f8bd3edfde9f7d914c31ceb9a1d9cae)

@balukin
Okay, so it indeed was my fault. I'm terribly sorry.

Closing. Discussed changes are now in effect and merged into stable VRidge channel and master branch of this repo.
Offset is now limited to yaw axis only. Older API calls will be converted and non-yaw data will be discarded but yaw offset should still be correctly applied without breaking reprojection. It will also correctly reorient 3rd party and our controllers.


notifyDatasetChanged

Hi!
I have recyclerview with
private FastAdapter<GenericShiftTypeItem> fastAdapter;
GenericItemAdapter<ShiftType, GenericShiftTypeItem> itemAdapter;

in ListActivity code I notify
    @Override
    protected void onResume() {
        super.onResume();
        itemAdapter.notifyDataSetChanged();
    }

I have other EditActivity for create\edit new entities. If I press arrow on actionBar marked as getSupportActionBar().setDisplayHomeAsUpEnabled(true); all work fine. If I press back button on my phone function onResume fired but dataset not changed (existed entities reloaded and all changes showed, but new entity not shown in list. When I reload activity all entities shown right). What I do wrong?

@dexion please use the FastAdapter specific notify methods:
notifyAdapterDataSetChanged()

I tried, this has no effect in my case.

I think if I use fastAdapter.notifyAdapterDataSetChanged(); listView should be refreshed automatically - it is a basic logic. Why I should reseting all items in listView by GenericItemAdapter#set?

if you know the position of the changed element

Changed element shown right. New created element doesn't showed. It is always last element in listview.
If you want, you may try my app ListShiftType If you will try, you should turn off Instant run in Android Studio due some problems in libraries.
Scripts:
A

add new entity (just click FAB +), no need other actions

Click back arrow in top left corner toolbar
All works fine.

add another new entity (just click FAB +)

Click back arrow in your phone (hard button or system arrow at bottom)

List view should be refreshed but it doesn't.
B

Click any item in list view. New activity will be shown.

Change something, like name

Click back arrow in top left corner toolbar
All works fine. Item show changed info

Click any item in list view. New activity will be shown.

Change something, like name

Click back arrow in your phone (hard button or system arrow at bottom)

All works fine. Item show changed info

What happens in the onBackPressed or onOptionsItemClick listeners in the activity where you add the new item?
You have to somewhere add the new item to the Models / Item's which are currently displayed inside the list?

I create new item:
call activity with params from ListActivity
save new entity into DB in ShowActivity
after that if click back arrow in toolbar - work
after that if click back button - doesn't work (I can't figure out difference between back arrow in toolbar methods and back button methods)
try reload adapter onResume
ShowActivity didn't have any overriden functions like onBackPressed or onOptionsItemClick

Ok. If click back arrow calls onCreate ListActivity so adapter fully refill. If click back button calls onResume ListActivity so adapter change only already added items. I think this is not quite right, but i understand. In my case I should clear and fully refill adapter onResume, no other choice, isn't it?

@dexion if you can not find out or notify the main activity about which items you have changed, the best is to get the list of items new, and use the method to set a new list of items. (The best would probably be the one with the DiffCallback, so the UI just updates new / modified / removed items)

Thanks for help!


Hi. Where can I download the pre-train file (Fabnet/nv2_curriculum.pth)?

Hi. Where can I download the pre-train file (Fabnet/nv2_curriculum.pth)?

I've found the download link. Thank you very much for your repo.


Still doesn't work

ython 3.5.3 (a39af0be3a22, Jun 05 2017, 20:18:00)
[PyPy 5.8.0-beta0 with GCC 6.2.0 20160901] on linux
Type "help", "copyright", "credits" or "license" for more information.
And now for something completely different: ``why there is no "PyPy 1.4
released" in topic any more?''
>>>> guac.py
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'guac' is not defined
>>>> execfile("guac.py")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'execfile' is not defined
>>>> exec(open("guac.py").read(),globals())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<string>", line 158, in <module>
  File "<string>", line 103, in monadic_context
  File "<string>", line 50, in _run
  File "<string>", line 48, in step
  File "<string>", line 129, in bind
  File "<string>", line 41, in proceed
  File "/home/user/pypy3/lib-python/3/copy.py", line 182, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/home/user/pypy3/lib-python/3/copy.py", line 292, in _reconstruct
    y = callable(*args)
  File "/home/user/pypy3/lib-python/3/copyreg.py", line 88, in __newobj__
    return cls.__new__(cls, *args)
TypeError: object.__new__(generator) is not safe, use generator.__new__()

@JadenGeller I'm using pypy3.

Did you try to install guac from pip?
pip3 install guac

There's no file named guac.py, so I don't know what you're trying to do.

Closing due to inactivity.


Fix #231 and linting issues in toggle

#fix#
Fix #231

Remove one-way-controls
Remove unnecessary comments

Fix other

Fix linting issues in toggle

:+1:


Can we install tool on windows?

How to install tools on windows operating system. Please guide

@sainathpawar There is no way to install it in windows currently. Kindly use the web version from Windows. The functionality is the same. https://tecoholic.github.io/ner-annotator/

@sainathpawar You can now install it in windows using this installer https://github.com/tecoholic/ner-annotator/releases/download/v1.0.2/NER.Annotator_1.0.2_x64.msi

Thanks @tecoholic its really wonderful. Appreciate for quickly turnaround on solution for windows user. I was getting lot off issue while training data that was annotated by doccano. but you save me. I am able to train the model on data annotated by your tools without any issue. Thank you so much. It would be great

if you can add option to import new file once annotation is done for one file.

@sainathpawar It's always great to hear such positive feedback. I understand what you are suggesting. I will add it my issue list. Thanks


[BUG/Help] Model generates mixture of English and Chinese when it should only respond in English

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When loading THUDM/chatglm-6b-int8 or THUDM/chatglm-6b-int4, I regularly get outputs like these:
![image](https://user-images.githubusercontent.com/19983153/232739610-79ae3060-10ca-485f-88ac-da9109016834.png)
The output is great, but is there any way to restrict the model to only generate in English? This way it is not really usable, as this mixing of languages seems to happen quite often. Maybe there is a way to restrict the tokens the model can use?
I would appreciate any help!
Expected Behavior
Generation in either English when the question/chat is in English.
Steps To Reproduce

Load the int4 or int8 model
Ask questions
Model will regularly include Chinese characters in the answer

Environment
- OS: Ubuntu 20.04
- Python: 3.8
- Transformers: 4.28.1
- PyTorch: 2.0.0+cu118
- CUDA Support (`python -c "import torch; print(torch.cuda.is_available())"`) : True

+1


no key event

macos 10.12.5
I clone code and build it yesterday. It can work when I install it, but after I login again from login windows. There is no key event for all keys. Noting happened when I touch the key.

There is no reply, so I close it.


Attempt #10002

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

👍


Create a separate license file

This way, GitHub will automatically recognize the license. It also makes the license easier to be noticed by potential contributors.

Thanks @zdroid for getting this started. Actually a collaborator and myself have been discussing it and I'm leaning towards making the project AGPL licensed, what's your take on that? And I promise moving the license into its separate file is on my to-do list it's just below a bunch of stuff so thank you for getting the ball rolling on that!

It depends on what do you want the project to become. AGPL has a lot of conditions to potential forks. MIT has only one (License and copyright notice), on the other side.

I like the idea that a company wouldn't be able to fork the code, improve it and then license it without a licensing agreement, really I want to model this project after WordPress and they run a GPLv2+ license, but I think the additional clause of AGPL could be useful based upon the kind of service NodeTube is (distributed servers). So that was my thought process, I think I will merge this here just so it's cleaner and also automatically recognized by Github but I think a move to AGPL may be in the future. Thanks for the PR!

You're right, that's one way to go. There's also a blogging service licensed under MIT, Ghost.

Oh cool, Ghost uses the MIT license. What do you think would be best for the community at large? I had one collaborator telling me he flatly refuses to work on anything as OS that isn't GPL licensed lol. Luckily from MIT I can switch to GPL so we have some time on our hands here to hash it out and make a solid decision.

GPL is better for business, MIT for the community. Almost all popular GitHub projects (with really large communities) use MIT.

Thanks for that info, I'd definitely like to hear more from the community on their opinion as well but thanks for the PR man you're epic!


Replace PERSISTENT_COMMITTEE_PERIOD with SHARD_COMMITTEE_PERIOD

Issue
Phase 0 spec of the beacon chain has PERSISTENT_COMMITTEE_PERIOD = 2048 constant which is used in process_voluntary_exit. It should be replaced with SHARD_COMMITTEE_PERIOD = 256 according to the recent version of Phase 1 spec.

closing via #1783


Add gt and lt overrides for TagBase.

Fixes an incompatibility with django-modelcluster and, by extension, Wagtail.
Currently untested, just committing the change to 'save' it.

Oops, created this by accident.  Please ignore. :)


ConversationLanguageUnderstandingRecognizer not shown

Describe the bug
I am following the installation guide to add CLU Support to the composer:
https://github.com/Microsoft/botframework-components/tree/main/packages/Recognizers/ConversationLanguageUnderstanding/dotnet
I did install the CLU Recoginzer package

However, the search for ConversationLanguageUnderstandingRecognizer is not successfull.

Version
Release: 2.1.3-nightly.364675.1a93f21
as
Release 2.1.2 has the certificate error
To Reproduce
See above,
install the CLU Recoginzer package, start with the emty bot template and try to find the package to install.
Thank you

Hi @TWDevLead,
I'm able to reproduce. Thanks for reporting this issue.
The ConversationLanguageUnderstanding readme mentions:

Search for ConversationLanguageUnderstandingRecognizer and install the package.

In Composer's package manager, searching for ConversationLanguageUnderstandingRecognizer indeed does not show any packages:

I think this is a documentation issue in ConversationLanguageUnderstanding readme.
To install the CLU recognizer package in Composer, the ConversationLanguageUnderstanding readme documentation should mention the actual CLU package name Microsoft.Bot.Components.Recognizers.CLURecognizer instead of ConversationLanguageUnderstandingRecognizer


Logo float left

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Weird, the logo doesn't seem to be floating on my side (using Chrome) at https://huggingface.co/docs/datasets/master/en/index

https://huggingface.co/docs/datasets/index
The needed css change from moon-landing just got deployed


Updated information about Azure Application Gateway

Added an icon that signifies Azure Application Gateway is zone redundant

@janegilring : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for reporting this.  The change should go live today.
#please-close


Deffered object

I would like to do some things when InTelInput has finished its setup, for example, when class int-tel-input is available.
I have tried .done() but get an error that IntlTelInput does not have function done().
Any thoughts?

The only asynchronous part of the initialisation is with defaultCountry: "auto" so if you're not using that, you should be good to assume the plugin is ready to go in the next JS statement e.g.
$("input").intlTelInput();
$("input").parent().hasClass("intl-tel-input"); // this should be true

Does that work for you? But I should add something for the async situation. I'm just short on time atm, so I'm open to pull requests ;)

Ok I've bundled this with some other issues around setting defaultCountry to "auto" - see https://github.com/Bluefieldscom/intl-tel-input/issues/168.

Hi,
Although this is a welcome change it should have increased the major version number as it breaks the existing behavior of returning a jQuery object.


[Utils]: Increase odds ratio resolution to 4 decimal points

Issue: https://github.com/opentargets/genetics/issues/537
Deploy: https://deploy-preview-210--genetics-app.netlify.app/

I know this might be a way the library works, but if possible it would be nice to resolve this rounding issue:

It's not very consistent that we have different decimal points if the value is a '0.XXXX' or a '1.XXX'. We would ideally want both of them to have the same number of decimal points (e.g. 4).

@d0choa fix numbers to 4 digits in lastest commit
Deploy: https://deploy-preview-210--genetics-app.netlify.app/

Could you please increase the resolution for:
1 - Confidence intervals in the study table?
https://deploy-preview-210--genetics-app.netlify.app/study/GCST90038599
2- Odds ratio and confidence intervals for the GWAS lead variants in variant page:
https://deploy-preview-210--genetics-app.netlify.app/variant/9_97819742_A_G
3 - Odds ratio in the phewas table
https://deploy-preview-210--genetics-app.netlify.app/variant/9_97819742_A_G


chore: Refactor examples to leverage terraform-aws-eks for cluster creation

What does this PR do?

Refactor examples to leverage terraform-aws-eks for cluster creation
Bump version of tflint to catch more checks
Remove the following examples:

ingress-controllers/nginx - doesn't provide additional value beyond enabling the addon, addon is shown in other examples already
node-groups/* - no longer required due to use of terraform-aws-eks module
portworx - doesn't provide additional value beyond enabling the addon, currently does not work due to the IAM policy (should use IRSA but currently does not support)
upstream-with-k8s-addons - no longer required since nearly all examples are demonstrating this (in this PR)
gitlab-ci-cd - this example didn't show anything relevant to EKS and instead just demonstrated using GitLab for Terraform remote state management. A proper example is slated to be implemented in https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/493

Motivation

Relates to #868
Updating examples to start showing what the future plan is for examples/blueprints without introducing any breaking changes to users
Resolves #1076

More

[ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have added a new example under examples to support my PR
[ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
[ ] Yes, I have updated the docs for this feature
[x] Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

Use an existing example when possible to demonstrate a new addons usage
A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

failed plans will fail since those are removed or re-named

switching to draft to split up PR


Missing keys

Shift + F-keys
Ctrl + F-keys
Shift + tab
Numpad / * - +
Shift + backspace sends \8 instead of \127

Alt + backspace also doesn't seem to be passed through to the underlying shell.

Any news from numpad + - support ?
It's could be perfect with action: IncreaseFontSize

Also

Ctrl + tab
Ctrl + Shift + tab

Also

Ctrl + Left Mouse

The remaining mappings should be fixed by https://github.com/tomaka/winit/pull/805.


stuttering player sprite

Zach: For some reason in game the idle animation is stuttering, its not like that in the animation and if you look at the sprite frames it doesn't stutter, only in game.
https://discord.com/channels/1166554341650477066/1170828464434200687/1170828464434200687

Solved in project settings, with advanced settings turned on, under Renderer, 2D.
Turn on Snap 2D Transforms to Pixel
(I turned on vertices snap as well, but that's probably not necessary)


WIP add dragon ball characters to faker

This isn't finished because I keep getting this failure when I run my test, with my characters included in the en.yml file.
Failure:
Z0G 3RL didn't match (?-mix:[A-PR-UWYZ][A-HK-Y]?[0-9][ABEHMNPRVWXY0-9]? {1,2}[0-9][ABD-HJLN-UW-Z]{2}).
 is not true.
test_regex(TestLocale)
/Users/chasedunagan/mod_4/faker/test/test_locale.rb:41:in `test_regex'
38:   def test_regex
39:     Faker::Config.locale = 'en-GB'
40:     re = /[A-PR-UWYZ][A-HK-Y]?[0-9][ABEHMNPRVWXY0-9]? {1,2}[0-9][ABD-HJLN-UW-Z]{2}/
=> 41:     assert re.match(result = Faker::Address.postcode), "#{result} didn't match #{re}"
42:   end
43:
Is there anyone that can help me fix this error so I can make a clean PR?

If you run the tests on the master branch, does the same error happen?

I found the same thing. It is because the regex patters don't match. I have fixed it here:
https://github.com/stympy/faker/pull/849


Axis constrained entities spawned by SEnt not behaving correctly after duplication

What I think is happening:
The Wheels are being spawned at 0,0,0 relative to the Railcar? They were copied at 245.8,0,1.4 and should only spawn there.
I have code that removes any extra Wheels it spawns (as they are spawned in ENT:Initialize()), after the duplication has finished, I tested with and without, and its only being caused by AdvDupe2 spawning the Wheels.
Issue does not occur with normal Gmod duplicator.
Expected behaviour:

Result:

Video demonstration: https://imgur.com/a/SoXBYRu
Might be an issue with my code, as far as I am aware, and from my testing, It isnt.
The SEnt source code can be found here.

I think this is screwing up the duplicator's constraint location logic https://github.com/TitusStudiosMediaGroup/garrysmod_lua_railcars/blob/main/lua/entities/gmod_railcars_testcar.lua#L65

I removed the set pos, same issue still occurring, just at a different position (it spawns lower now). It needs the set pos so that the wheels do not spawn in the ground.

Ok I'll try to give it a look this weekend.

Latest dev build also has the same issue. I removed the old SetPos on the parent, moved to the ENT:SpawnFunction().
Any SetPos is messing with the constraints? Wouldn't explain why simfphys cars work when duped.. unless its only on a few constraint types, unsure.
https://github.com/TitusStudiosMediaGroup/garrysmod_lua_railcars/blob/e66c5c74d0a4c67be19f4ff06e15b9adeadb8502/lua/entities/gmod_railcars_testcar.lua#L46

Is this a new problem? I know @robotboy655 recently changed some slider stuff

Unsure, I’ve only very recently been experimenting with SEnts. Fascinating

Ah, I don't think he touched Axis though so nevermind.

Yeah, it was sliders and ropes.

Yup that fixed it! Thats rather interesting that you have to wait, just added a timer of 0s. Just need to add a entity rego so that I can dupe it with the submaterials. Thanks for the help! Closing now?

No, that's just a hacky work-around. Need to investigate the root of the problem.

Ah right I see I see. Atleast I can keep working on more dupe functions for the time being.

The root of it is probably in here https://github.com/wiremod/advdupe2/blob/master/lua/advdupe2/sv_misc.lua#L20. I'm wondering if the physobj Pos/Ang is needing a frame to update now.

This timer https://github.com/wiremod/advdupe2/blob/master/lua/advdupe2/sv_misc.lua#L82

@TitusStudiosMediaGroup can you see if increasing that to 0.2 or 0.3 makes it work without your own work-around? If so then I think it's some kind of desyncing between physobj and entity.

On it

Setting it to 0.2 fixed the issue without the workaround.

@robotboy655 I think the october or august update introduced this.

Might be able to work-around it by waiting another frame.

It just really isn't a gmod bug. We know it works properly with the default duplicator and nothing about constraint entities or Set/Get Pos/Angles has changed in a long time.
You can try addonsystem beta branch (code:goodpassword), which is very outdated and see if happens there.

Can test in an hour or so.

Had an engine error crash on singleplayer load using the addonsystem dev branch

Engine Error:
Server Lua Stack Leak [1]!
0> UNKNOWN (nil)

Rip. You could try running minimal amount of addons.

Yep that fixed it, the moment I spawn my lua SEnt it crashes with the same error haha

seems to be something with timers? I added a timer to an autorun lua file and it crashed on spawn

My power was out all day. now its back. let me try.

@robotboy655
So far i've confirmed that this code works in that branch
--timer.simple(0.001,function()
    wheelEnt:setPos(wheelPos + offset + awayoffset)
--timer.simple(0.001,function()
    constraint.elastic(1, baseEnt, wheelEnt, 0, 0, baseEnt:worldToLocal(wheelCenterEdge+offset+awayoffset), wheelEnt:worldToLocal(wheelCenterEdge+offset+awayoffset), constant, damping, rdamping, elasticWidth)
--timer.simple(0.001,function()
    wheelEnt:setPos(wheelPos - offset + awayoffset)
--timer.simple(0.001,function()
    constraint.elastic(1, baseEnt, wheelEnt, 0, 0, baseEnt:worldToLocal(wheelCenterEdge-offset+awayoffset), wheelEnt:worldToLocal(wheelCenterEdge-offset+awayoffset), constant, damping, rdamping, elasticWidth)
--timer.simple(0.001,function()
    wheelEnt:setPos(wheelPos)
--end) end) end) end) end)

Now the timers need uncommented. I think that change is related to this issue.

This code is basically pre-tensioning the elastics. It used to work in a single frame.

I can make a reproduction snippet if u need.

local e = Entity(67)
local startpos = e:GetPos()
e:SetPos(startpos + Vector(0,100,0))
constraint.Elastic(e, game.GetWorld(), 0, 0, Vector(), startpos + Vector(0,100,100), 10000, 200, 50, "cable/cable2", 5)
e:SetPos(startpos)

Nevermind... it works again now too.

Ah but duplicator fails to get the correct offsets. I'll test that in the old branch.

Same behavior. So I guess that timer to get the constraint info is creating race conditions. Will need to refactor that.

I'll be testing. I think overriding AddConstraintTable is the best way to get rid of the timer.

Nvm, that's before the SetTable()

@TitusStudiosMediaGroup can you try replacing that file with this? https://github.com/wiremod/advdupe2/blob/d2446060cac353438b025edb09d8cdcccbd0989b/lua/advdupe2/sv_misc.lua
It fixes the issue for me. I'll pull it once I know it works for you.

Yup sure can, I'm in town at the moment I can get to it a little later today, cheers

Sorry I got a little caught up yesterday haha. The new sv_misc fixes the issue on my side.

alright nice. thanks for verifying.

The new code has broken "auto-aligning" axis constraints. Only on constraints made after the bug fix

what tool makes those?

Just the normal axis tool, its when you left click on the first entity, it auto positions it to the next entity (where you click)


Upgrade to FreeRDP latest version

The Myrtille project started some years ago, using FreeRDP 0.8.2. I didn't wanted to upgrade it because it was working fine for the Myrtille purpose, and also because the FreeRDP code structure has quite changed meantime.
The Myrtille code in FreeRDP is surrounded by region tags "#pragma region Myrtille" and "#pragma endregion". The rest was left unmodified.
If someone want to help, it would be a nice contribution to Myrtille! Thanks :)

Implemented in myrtille version 1.1.0


How to increase buffer size to reduce number of reads to cloud-hosted virtual IO?

I've been using soundfile for many months now, to extract a few seconds clip from longer audio, then covert the numpy data of that clip to a spectrogram.  As we store more files in the cloud, I've made a simple class AzureReader, a file-like object interface over a single sound file in Azure blob storage.
It works well functionally, but is slow, and I believe I've narrowed the latency down to a large number of network round-trips from my computer to Azure's servers.
My interaction with soundfile looks like this
    reader = AzureReader(BlobClient.from_blob_url(url))
    with soundfile.SoundFile(reader) as f:
        f.seek(2112000)
        clip = f.read(96000)

When I instrumented my AzureReader implementation to log all reads, I see a few at the start of the blob, followed by over a dozen round-trips, over the course of > 1 second, to the cloud server just for this one window:
19:35:16.147232 : AzureReader.readinto(0, 12)
19:35:16.219924 : AzureReader.readinto(0, 8192)
19:35:16.283336 : AzureReader.readinto(8192, 8192)
19:35:16.345368 : AzureReader.readinto(1917856, 8192)
19:35:16.410200 : AzureReader.readinto(1926048, 8192)
19:35:16.474066 : AzureReader.readinto(1934240, 8192)
19:35:16.536846 : AzureReader.readinto(1942432, 8192)
19:35:16.622472 : AzureReader.readinto(1950624, 8192)
19:35:16.687365 : AzureReader.readinto(1958816, 8192)
19:35:16.750721 : AzureReader.readinto(1967008, 8192)
19:35:16.813712 : AzureReader.readinto(1975200, 8192)
19:35:16.876422 : AzureReader.readinto(1983392, 8192)
19:35:16.942945 : AzureReader.readinto(1991584, 8192)
19:35:17.008546 : AzureReader.readinto(1999776, 8192)
19:35:17.074706 : AzureReader.readinto(2007968, 8192)
19:35:17.348153 : AzureReader.readinto(2004842, 8192)

I do not believe the slowness results solely from the amount of data transferred: the virtual reader transfers a total of only 122kb out of a 2.4MB sound file blob.
Is there a way I can override the 8192 buffersize used by soundfile to decrease the number of round-trips needed?  Or any ideas of some other clever workaround when reading from cloud storage?

There is no way to modify this behavior, as it is governed by the underlying libsndfile, not soundfile itself.
That said, you could write a wrapper class that implements read, write, seek, and tell, but caches data internally. Wrap your AzureReader in your wrapper, then pass the wrapper to SoundFile.

That's an interesting idea, I'll give it a try.  Thanks for sharing your insight!


Fix typo bug in convex-convex separating axis test

Fix typo introduced by https://github.com/godotengine/godot/pull/51355.

Fixes https://github.com/godotengine/godot/issues/75734

Thanks!

Cherry-picked for 4.0.3.


[WIP] Add signature to reply addon

Add signature field to reply addon (Ezine::Addon::Reply).
This is WIP Pull Request, so DO NOT merge yet now.

Changes Unknown when pulling 87fbcbb49fc7209536ae1a28e774b5473c072668 on kaosf:add-signature-to-verificatin-mail into ** on shirasagi:master**.


Fix error message for failed object conversion

The original cad_objs will just log an empty list. Assuming the original intent was to log cad_obj instead.
Noticed this while exploring voneiden/cq-cam/issues/23
As a side note, looks like adding support for AIS objects might be a bit involved. We got two visualization options in cq-cam, AIS based and Edge based. AIS was originally used because it allows connecting lines of different colours using AIS_MultipleConnectedInteractive. However I'd be willing to research a bit if the edge based visualization can be improved to make AIS visualization redundant.

Thanks for fixing it!
I am not familiar with AIS (and ocp_tessellate is not using AIS).
What do you want to achieve from a user perspective?

Yeah no worries, I'll see what I can do. cq-cam allows generating CNC machining toolpaths on cadquery parts, so I'm using AIS to visualize the various generated paths. For example something like this

Besides getting better colour control, I have a faint memory that there may have been a performance benefit from using AIS, but I'll need to reinvestigate this.


[Feature Request] Helper to get available position

Add an utility or helper class that can return an available position within the grid given a new potential item (only w and h) and current items. This helper could provide the x and y coordinates where the new item can be placed within the items.
The function could be based on getAvailablePosition

(this class could be extended to have more utility functions)

Maybe something like this
<Grid {...} let:controller={gridController} />

what about bind:controller={gridController} or import { gridController } from '$lib'? to have a reference outside the Grid component


Fix code scanning alert - Use of a broken or weak cryptographic hashing algorithm on sensitive data

Tracking issue for:

[ ] https://github.com/licenseware/licenseware-sdk-v2/security/code-scanning/6

The file can be deleted + it's a false positive. The analyzer doesn't detect the context.  There are more going on there..
These crappy analyzers just waste electricity in 90% of the cases :))


fix: increase z-index for reconnect modal

Use the maximum value for z-index as I think it should be shown above any other custom modal (e.g. from a 3rd party library that can have randomly big z-index value).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Stamo-Gochev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@javiercn Can you provide some guidelines how to fix the error in:
https://dev.azure.com/dnceng/public/_build/results?buildId=194153
I don't see how this is connected with the change, so probably something else is causing the problem.

The change looks good to me. But there are a couple of things I'm not sure about:

Do we have to make it the maximum or just some very high value. If not people can run in the opposite scenario where this dialog hides some critical functionality. I don't think this is likely, but is good to think about it.
Could this be fixed in the application with just a custom CSS selector? Alternatively, you could (and likely should) customize the UI for your app so that the style is inline with the appearance of the rest of your app.

@SteveSandersonMS thoughts?

Adding my thoughts on the question - the idea of the maximum possible value is that showing the reconnect modal means there is a critical problem with the app - the user is no longer to interact with the page in a blazor-related way. I don't think there can be anything more critical that is displayed by a third-party modal.
I also don't think that adding a custom selector will work if you don't know that this modal exists (although adding the CSS rule will work). The way I hit this problem is that I had an element that had a higher z-index and the reconnect modal wasn't visible at all. This means that developers can deploy their app and experience a crash without an easy to spot message why this is happening. I was able to find the problem by inspecting the dev tools console, but for end users, they will probably report a "crash"without any error message, which is hard to investigate.

@SteveSandersonMS Any update on the suggestion?

It's a reasonable suggestion. Just FYI we're already at max capacity for delivering committed work items for 3.0, so anything not already committed will have to happen after 3.0 (including incoming PRs). Hope you understand!

Given that we haven't heard similar complaints about the current z-index value, we've decided not to move forward with this change. An easy alternative is to override the z-index in your own CSS rule.


"Build this branch on every push" option does not work

What App Center service does this affect?
Build
Describe the bug
Although the option is selected for "Build this branch on every push" we are still having to manually press the button every time that we want to create a build. There are some times where it does automatically do this, however it is rare/inconsistent. Screenshot is proof that we have not had an automatic build for our last PR, however it should have been automatically triggered.
To Reproduce
Steps to reproduce the behavior:

Set up a branch under the Build tab
Make sure to check the box for "Build this branch on every push" on the branch options
Create a pull request in Azure Dev Ops with some changes
Complete the pull request
See that the commit shows up in AppCenter, but there is no build that is triggered.

Expected behavior
I would expect that every time there is a PR made into Azure Dev Ops, which we have connected to AppCenter, that it creates a new build for our Development branch.
Screenshots
Desktop:

Mac OS Mojave version 10.14.3

Smartphone:

Android & iOS deployments

Wow. Github is not letting me upload a 55k PNG file right now... will try again later.
Basically it shows that the last build happened 3 weeks ago even though we had a completed PR a few hours ago.

Hey @ekimlinger this definitely sounds like a bug. Do you mind reaching out to support via App Center portal? We will need additional details to dig deeper.

Will do.

@DennisPan I'm experiencing the same issue, though this has only stopped working for me today, but was fine yesterday and I've been using "on push" for builds for many weeks successfully and very consistently.
How do I reach out to support via the App Center portal? I've had a quick look, but nothing is jumping out at me? I'd thought it'd be under the "?" on the top right hand corner of the portal, but nope.

Surprise, surprise, this is now working. Triggering "on push" builds much later after the fact isn't ideal, as I've wasted plenty of time trying to "fix" it and diagnose it for sharing here and I could have been doing something useful.
Anyway, when something doesn't work in App Center, my advise to you is like when you feel under the weather, if it's still dodgy after a few days, then see your doctor.

@jason-system1 I'd like to take a look at your repository's webhook request history for better understanding of what happened. Could you check if you see the blue chat bubble at bottom right of portal? That's how you can reach out to support. You can ask support to assign the conversation directly to me.

@ekimlinger @jason-system1 are you still experiencing this issue? Similar issue just came in #948

@nrajpurkar As you can imagine from my response above, no, no I'm not experiencing this behaviour anymore.
@DennisPan I've contacted the Blue Support Bubble people and I hope you can get linked up with my logs to help identify what was going on. For clarity, I didn't do anything that I think would have fixed it.

Thanks for the updates! Closing this out, but reach out again if anything comes up.

I'm having the same issue.  In Azure DevOps I see two service hooks configured for App Center (both created by an ex-employee).  When I try to test those hooks, both return a 404 error from App center.  I can find no documentation on how service hooks between Azure DevOps and App center should be set up.
Is there some way I can delete the connections and re-create them?  Is this documented somewhere?

I contacted App Center support using the chat button in the lower corner.  They did a soft reset on the projects on their back end and the service hooks started working.


Resolve from Owl if Content not present in Deer in while updating Equ…

…ivalent content.

One comment, otherwise :+1:


Fix docstring example: session.begin_transaction() needs to be awaited

Found this error in the docstring while working with the async module of the driver. When the session is an instance of AsyncSession the method begin_transaction() is async and needs to be awaited. The example in the docstring was missing the await keyword and running it as that returns AttributeError: __aenter__

Hello and thanks for taking the time to fix the docstring and opening this PR. Before I can even review it, I must ask you to sign our CLA (Contributor License Agreement).

Sure! I just did it, sorry for the delay. It is a great module by the way: very clean and well documented! I just felt that a little detail like that fix can save someone some time. Thank you for taking the time to review it.

Perfect. Thanks for the kind words and taking the time to contribute to our library! :raised_hands:


Multiple editors w/ single toolbar possible?

Hi,
Is it possible to use a single toolbar for multiple editor instances?
Thanks.

I have submitted a pull request. Please reopen the issue.


Release notes for ringpop-go v0.6.0.

Let's do a release!

Coverage decreased (-0.09%) to 94.574% when pulling d9069f08b75567b16582468014ca7a04814df69a on release-v0.6.0 into ededf80d28c312a13c731a6979886a3fb71c8b15 on dev.

Looks good!

Some small nits, but LGTM!


Corrected a Typo in a property name in readme file

"[colors]" property is mentioned as "colours" in read me file. Using [colours] throws error, it is [colors]

Wow, my first PR, man, this repo is way behind the original, i don't even know if it still works, but thanks, if you're actually using this let me know how's it working.

Hey, Yeah, using these charts in an ionic 2 app (meant for taking quiz), and charts are working pretty good! Thank you!!

I may try and update with latest version tomorrow, however i don't have an app to test, do you?


Featuresupport insert into select.

Proposed changes
Issue Number: close #xxx
support insert the ret-value of a query into a table with partition, with label, cols tags:
Like：
insert into t partition (p1, p2) with label label_1 (c1, c2, c3) [hint1, hint2] with cte as (select * from src) select k1, k2, k3 from cte

We make class named InsertIntoTableCommand to describe the command. Add the insert into schema to statementCtx so than we can check if the query's outputs are compatible the target table schema.
When planned the sql, we create datasink in the run() in the command and init it. Then we run a transaction to insert the data.
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[x] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[x] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

A known bug: insert into unique table without group by unique key will cause the replication different.
3 replications maybe receive the data with different when exchange.
e.g.
+-----------+                        +--------------------------+
| machine 1 |        exchange        |   machine 4 (replica 1)  |
+-----------+                        +--------------------------+
|   'a'     |                        |       'a', 'b', 'c'      |
+-----------+                        +--------------------------+
                       \

+-----------+                        +--------------------------+
| machine 2 |                        |   machine 5 (replica 2)  |
+-----------+          -             +--------------------------+
|   'b'     |                        |       'c', 'a', 'b'      |
+-----------+                        +--------------------------+
                       /

+-----------+                        +--------------------------+
| machine 3 |                        |   machine 5 (replica 2)  |
+-----------+                        +--------------------------+
|   'c'     |                        |       'b', 'c', 'a'      |
+-----------+                        +--------------------------+

so when insert into the table with unique key, we should let the final instance satisfy the distribution same with the key, and you should add a hash(unique key) require properties to the top of the select

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.22 seconds
stream load tsv:          423 seconds loaded<PHONE_NUMBER>9 Bytes, about 168 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230424072025_clickbench_pr_133873.html

run buildall

run p0

run buildall

run buildall

run buildall

run buildall

run buildall

run fe ut

run p0

run buildall

run buildall

run buildall

run buildall

run buildall

run p0

run buildall

run buildall

run p0

run p0

run p0

run buildall

run p0

run p0

run p0

run p0

run buildall

run p0

run p0

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.3 seconds
stream load tsv:          418 seconds loaded<PHONE_NUMBER>9 Bytes, about 170 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          60 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          78.4 seconds inserted 10000000 Rows, about 127K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230523031506_clickbench_pr_148616.html

run buildall

run p0

run p0

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.58 seconds
stream load tsv:          415 seconds loaded<PHONE_NUMBER>9 Bytes, about 171 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          78.4 seconds inserted 10000000 Rows, about 127K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230523091037_clickbench_pr_148848.html

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.73 seconds
stream load tsv:          419 seconds loaded<PHONE_NUMBER>9 Bytes, about 170 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          77.6 seconds inserted 10000000 Rows, about 128K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230523122834_clickbench_pr_149042.html

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.51 seconds
stream load tsv:          414 seconds loaded<PHONE_NUMBER>9 Bytes, about 172 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          78.5 seconds inserted 10000000 Rows, about 127K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230523130232_clickbench_pr_149053.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.04 seconds
stream load tsv:          417 seconds loaded<PHONE_NUMBER>9 Bytes, about 171 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          60 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          78.0 seconds inserted 10000000 Rows, about 128K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230523132539_clickbench_pr_149083.html

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.89 seconds
stream load tsv:          420 seconds loaded<PHONE_NUMBER>9 Bytes, about 169 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          79.1 seconds inserted 10000000 Rows, about 126K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524072841_clickbench_pr_149576.html

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.8 seconds
stream load tsv:          416 seconds loaded<PHONE_NUMBER>9 Bytes, about 171 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          60 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          79.0 seconds inserted 10000000 Rows, about 126K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524093627_clickbench_pr_149652.html

run buildall

do not merge this PR until the author update commit msg


Call clean task with verifyPaparazziDebug

WHAT
Call clean task with verifyPaparazziDebug
WHY
In order to prevent it using cache, in an attempt to fix https://github.com/google/horologist/issues/339
HOW

add clean task to be called with verifyPaparazziDebug;
move "snapshot test" step to be executed after "upload test reports" step, due to the clean task that would delete the previously generated reports;
change "upload snapshot tests failures" step to also archive the test results and to run "always";

Checklist :clipboard:

[N/A] Add explicit visibility modifier and explicit return types for public declarations
[N/A] Run spotless check
[x] Run tests
[N/A] Update metalava's signature text files

With this PR, this issue https://github.com/google/horologist/issues/340 is surfaced again:
> Task :media-ui:testDebugUnitTest
com.google.android.horologist.media.ui.FigmaVolumeScreenTest > volumePlayerScreen FAILED
    java.lang.NullPointerException at FigmaVolumeScreenTest.kt:46

After https://github.com/google/horologist/issues/340 was merged, main got red, which is a good indication that the fix put in place might have worked. It needs monitoring and this issue should be reopened if the problem persists.


Update with New Features from template.github-0.8.0

Description
Attempting to add features from https://github.com/devlinjunker/template.github to this repo
Contains:

Add Issue Templates
Labels

Config File
Manage Labels Action

PR Template Updated
Move Notes to NOTES.md
Follow README format
Code of Conduct
Security Policy File
Update Package.json version
Fix License
Update contributing
Add badges to README

Related
https://github.com/devlinjunker/template.github/issues/9
#29
#23
TODO

[x] Follow instructions in https://github.com/devlinjunker/template.github/issues/9
[ ] Updated README

Add Badges

~"Read the Docs" to point at github pages site: https://docs.readthedocs.io/en/stable/badges.html~

seems based on python
do custom “docs|available” badge from http://shields.io

npm dependencies?
swagger/openapi
review #29

Link to NOTES.md
update Core Initiative ranking

[x] Update Contributing File (see comments in PR)
[x] Remove from_name in labels.yaml
[x] PR Body
[ ] Test docsite on localhost

After merge:

[ ] Add issue for completing Core Initiative Passing status: https://bestpractices.coreinfrastructure.org/en/projects/4288


IBM Verse Mail: "Open in new window" button opens a blank window

Mail: "Open in new window" button opens a blank window.

[ctrl] Click "Open with default browser" doesn't work either.

Closing as duplicate of https://github.com/jiahaog/nativefier/issues/408


Support of VR180

Support of VR180
Renderer configuration & options for VR180 video/images

This looks good - I will test and merge soon.


Upgrade from 0.14.2 to 0.24.3 results in "MISSING DEP  Can not find dependency '@vitest/coverage-c8'"

Describe the bug
We use renovate in GitHub qhich suggest we should make this upgrade - but if we do then running tests with vitest with --coverage then fail with MISSING DEP  Can not find dependency '@vitest/coverage-c8' with no obvious clue where.  I guess we could simply install this package - but if it is a dependency shouldn't vitest include it automatically?
Reproduction
Upgrade from 0.14.2 to 0.24.3 then run tests with --coverage option.
System Info
System:
    OS: macOS 11.6.8
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 295.07 MB / 16.00 GB
    Shell: 5.8 - /usr/local/bin/zsh
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v14.16.1/bin/yarn
    npm: 6.14.12 - ~/.nvm/versions/node/v14.16.1/bin/npm

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Upgrade from 0.14.2 to 0.24.3 then run tests with --coverage option.

This is not a reproduction.

I guess we could simply install this package - but if it is a dependency shouldn't vitest include it automatically?

I don't know if you tried running it locally, but it usually gives a prompt: https://vitest.dev/guide/coverage.html#coverage-providers. Just install the package, it's optional - we cannot bundle it with Vitest.

Just want to add that this was intentional breaking change in v0.22.0. https://github.com/vitest-dev/vitest/releases/tag/v0.22.0
You should see this mentioned in changelogs of Renovate's PR.

Ok thanks that’s very useful info


Add WSSE header support with autogenerated nonce/date and shortcut to refresh it

Hi,
I use WSSE on some projects and it's very painful to use it with your extensions (because need to refresh header value on each request), so I take time to add support of that.
I don't know a lot Polymer but I tried to respect existing style, coding method... to do it.
Don't hesitate to do some comments if you want I change smoething before merge, I'll try to do it.
PS : Normally, WSSE use base64 encoded nonce on header, but some people don't do it (and it's my case on some projects) so I add an option for that
Thanks

Hi,
Thank you for the PR.
It's great you wrote the header support for this use case.  Though I'm not feel confident of putting fill support specific functionality in the headers editor. Modules included into the editor should contain all the UI and logic required to provide the support.
Also putting another icon in the filed is not scalable since it may end up adding more and more icons depending on different headers.
I could propose the following flow.
The UI for the app hasn't changed. Editor recognizes support for x-wsseheader and only one "edit" icon is visible to the user. Click on the icon opens the dialog there the user may enter credentials.
The wsse-support element registers a listener for the ready event on document.body. When the event fires and the event's target is the arc-request-controller then it automatically refreshes the value (calls the refreshValue function).
The event listener must be removed when the element is detached from the DOM.
I think is has more sense from the scalability and UX point of view. Headers editor element is still responsible for editing a headers only (not additional tasks) and the user don't need to refresh the value before each call because the fill support element is doing it automatically.
What do you think about this approach?

Hi,
It's ok for me. I'd looking for a way to refresh it automatically, and I didn't find an example on your code to do that so I don't do it ;)
I'll try that and I'll add a new commit after.

I do some changes, let me know if it's ok or not

I merged it into the develop branch. However, I've changed it a bit. See merge for more details.
Today the update will be available in ARC's canary and dev channels. I suggest you to try it in unstable channels before it will be send to the stable channel.

Hi,
Sorry but links for dev & canary versions don't work for me.
An error occurred:
Item not found. This item may have been removed by its author.

Only group members for linked groups can see the items in the Chrome Web Store. When you join one of them (or both) you'll be able to see the items.


I have tried your solution on my S20 Ultra 5G. My APP, RideWithGPS, continues to loose the GPS signal when the screen turns off. Your solution did not work.

Hello, does the app use a foreground service? Also if you are on latest
Android that apps can only use GPS when used.. not in the background any
more..
Thank you very much.
Best regards,
Petr

P.S. Sorry for my brevity or longer response time. I'm handling hundreds of
emails daily and I try hard to respond to most of them it the best way I
can. Just let me know if you need more details, please.
On Wed, Dec 2, 2020 at 7:34 AM rccdale<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbandroid-team/dont-kill-my-app/issues/260, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIPQZ5MK3FKHVVYXC2AWT3SSXNWTANCNFSM4UKBJ26Q
.


SAK-42072 calendar,content: ...newTime().breakdownLocal().getYear() =…

int year = TimeService.newTime().breakdownLocal().getYear() =>
int year = Year.now().getValue();

@adrianfish Year.now(ZoneId) ?

I saw that and wondered too. It doesn't sound like it does anything other than just shift the timezone. If the thing we need is the local time then this is probably fine. Maybe put a comment on one of the now() statements stating that assumption?


A small lag of screen while scrolling on the home page

Scroll to the bottom first
Now try scrolling to the top of the website, when you will reach close to Navbar, something weird happens on the screen everytime

Could you please assign it to me
Thanks & Regards
Shlok


Fixes name of and link to MutatingAdmissionWebhook (ALP)

Description

Corrects the name of the feature in question
Also fixes anchor link which was incorrect

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit b4e8f37372bc8fbd1516fb9bccc675c5e6fc71e0
https://deploy-preview-2207--calico.netlify.com


Improvements to URL matching in guessMediaType()

function guessMediaType(url) {
  const extensionMatch = url.match(/\.([^/.]+)$/);
  if (extensionMatch === null)
    return 'image';
  const extension = extensionMatch[1];
  // ...
}

That means the plugin is currently looking for a dot . followed by anything but a dot or slash before the end of the URL. If I'm not mistaken, this should yield unwanted results in these example cases:

http://example.mov -- match is mov, which could be a recognized video file extension and is a valid TLD
video.mp4?t=1m30s -- match is mp4?t=1m30s, not mp4 as intended
audio.mp3#chapter4 -- match is mp3#chapter4, not mp3 as intended

I'm not sure if it's usable yet, but URL.pathname should strip out host, query and hash automatically. Otherwise you could also consider them manually.
  const extensionMatch = url.match(/\/.*\.([^/.]+)(?:\?[^?]*)?(?:#[^#]*)?$/);

Thanks for the report, @Crissov! I agree that the matching should be improved. I'm reluctant to add the URL dependency to simplify running the same code in Node and in the browser, and also because URL isn't supported by IE without a polyfill. But I'll do some testing with your suggested regex and may use that, or a version of that.