LFS files in forks fail to download via separate remote or PR ref

Gitea Version
1.15.6
Git Version
Seen on different servers running 2.25.1 and 2.34.0
Operating System
Ubuntu 20.04.3
How are you running Gitea?
One server is manually deployed from a GitHub release and started with a systemd script. The other uses the apt-installed version of Gitea.
Database
PostgreSQL
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
I can gather a log if that would be helpful. I've included clear repro steps in the description.
Description
LFS files are failing to download from forks. The only reason I can't repro on try.gitea.io is because LFS doesn't seem to be enabled. This is my minimal repro (visible at https://git.pernicious.games/try-gitea-lfs/lfs-fork-test and the fork at https://git.pernicious.games/cpickett/lfs-fork-test/src/branch/fork-1).
Note that we are pretty sure this used to work on our Gitea installation months ago, so it may be caused by a relatively recent Gitea version (maybe 1.15+).
The repro steps are:

Create new repo with an LFS file
Fork that repo
Commit a new rev of the LFS file in a branch on the fork
Open a PR for the main repo from the fork's branch

Now clone the base repo somewhere else and try to either pull from the remote or the PR ref:

Clone base repo (e.g. git clone https://git.pernicious.games/try-gitea-lfs/lfs-fork-test.git)
Add the fork as a remote and fetch it (e.g.: git remote add parnic https://git.pernicious.games/cpickett/lfs-fork-test.git, git fetch parnic)
Try switching to the branch that exists in the fork with the modified LFS file (e.g.: git switch fork-1)

Receive error, e.g.:

Downloading test.lfs (9 B)
Error downloading object: test.lfs (7ffc8bb): Smudge error: Error downloading test.lfs (7ffc8bb3b0c443a3d170b1f6aa402a66c6de86c49dd2d74e452d6d82b855939f): [7ffc8bb3b0c443a3d170b1f6aa402a66c6de86c49dd2d74e452d6d82b855939f] Not Found: [404] Not Found

Restore modified files and try switching to the PR ref instead (e.g.: git restore ., git fetch origin pull/1/head:test, git switch test)

Receive same error as above

Note that the LFS file at the specified revision/hash exists in the fork, e.g.: https://git.pernicious.games/cpickett/lfs-fork-test.git/info/lfs/objects/7ffc8bb3b0c443a3d170b1f6aa402a66c6de86c49dd2d74e452d6d82b855939f/direct
but it does not exist in the base repo: https://git.pernicious.games/try-gitea-lfs/lfs-fork-test.git/info/lfs/objects/7ffc8bb3b0c443a3d170b1f6aa402a66c6de86c49dd2d74e452d6d82b855939f/direct
This is important because when running git lfs fetch --all we see that it is trying to pull from the base org, not the fork:
>git lfs fetch --all
fetch: 2 object(s) found, done.
fetch: Fetching all references...
[7ffc8bb3b0c443a3d170b1f6aa402a66c6de86c49dd2d74e452d6d82b855939f] Not Found: [404] Not Found
error: failed to fetch some objects from 'https://git.pernicious.games/try-gitea-lfs/lfs-fork-test.git/info/lfs'

Finally, note that the LFS file does exist on the disk under the generic LFS directory. For this example, that's
/var/lib/gitea/data/lfs/7f/fc/8bb3b0c443a3d170b1f6aa402a66c6de86c49dd2d74e452d6d82b855939f
Screenshots
No response

Can @zeripath or @KN4CK3R or someone else help to confirm?
IIRC the LFS code gets some changes during 1.14 -> 1.15, I am not sure whether this is a permission problem or a database consistency problem.

Are you sure that worked before? After creating the PR the base repository contains the dangling pointer without the database reference:

(top = base, bottom = pr branch)
During 1.14 -> 1.15 I changed the LFS API code but this looks like we need to sync the LFS objects when creating a PR. And that functionality was never implemented I think.

Looks like, I was wrong. I tested 1.12 and it works with that version (but is not correct I think). After creating the PR blob list does only show a single pointer (that's wrong because of the new PR branch?). Seems like the download request associated the pointer, so my changes in #16865 or #15523 may be the reason of the problem.

The old code created the database references when downloading files. I changed that in #15523 so that only upload requests are able to do that.
Reasons:

The download request should just not do that (?)
To associate the file only Read-rights were enforced
The user could associate every file from different repositories (private too) to this repo if he knows the pointer data (was fixed in #16865)

So the question is how we would like to handle this problem. Personally I don't like to bring back file association in the download request. Auto-sync when creating a PR?

The old code created the database references when downloading files. I changed that in #15523 so that only upload requests are able to do that.
Reasons:

The download request should just not do that (?)
To associate the file only Read-rights were enforced
The user could associate every file from different repositories (private too) to this repo if he knows the pointer data (was fixed in Test if LFS object is accessible #16865)

So the question is how we would like to handle this problem. Personally I don't like to bring back file association in the download request. Auto-sync when creating a PR?

I vote later.

And just FYI, I remember this issue: https://github.com/go-gitea/gitea/issues/17207 , are they related? That issue also said about the behavior differs between Gitea release.

Yes, I think they are related. Just putting the files in the directory does not associate the repo to them.

I agree they are probably related and I've run into this issue as well. As a workaround you can do a git lfs fetch <UPSTREAM> and then a git lfs checkout to get the files.

We are hosting a private Gitea server behind a VPN, so I've temporarily reintroduced the associate-LFS-pointers-on-download code for a hacked-up local build, in case anyone else needs the temporary workaround: https://github.com/go-gitea/gitea/compare/v1.15.6...parnic-sks:associate-lfs-obj-on-download?expand=1

We are hosting a private Gitea server behind a VPN, so I've temporarily reintroduced the associate-LFS-pointers-on-download code for a hacked-up local build, in case anyone else needs the temporary workaround: https://github.com/go-gitea/gitea/compare/v1.15.6...parnic-sks:associate-lfs-obj-on-download?expand=1

And just FYI, I remember this issue: #17207 , are they related? That issue also said about the behavior differs between Gitea release.

I built 1.15.6 cherry-picked the changes from https://github.com/parnic-sks/gitea/commit/768aaab7dac4638fbde8b17df61f091f66ef68a0 and it did not fix issue #17207. Detail below.
We got a new bundle with LFS updates. I extracted the new LFS files, fetched the branch, and tried to push to origin. It would not push due hint: Your push was rejected due to missing or corrupt local objects. I also tried git lfs fetch --all and the push failed again.

And just FYI, I remember this issue: #17207 , are they related? That issue also said about the behavior differs between Gitea release.

I built 1.15.6 cherry-picked the changes from parnic-sks@768aaab and it did not fix issue #17207. Detail below.
We got a new bundle with LFS updates. I extracted the new LFS files, fetched the branch, and tried to push to origin. It would not push due hint: Your push was rejected due to missing or corrupt local objects. I also tried git lfs fetch --all and the push failed again.

That one commit is not enough, you need the entire branch diff. https://github.com/parnic-sks/gitea/commit/3872374b4cce2c116a9f0a35f1059d192e8f235d was actually the correct fix, but it needs the commit after that to fix the nil user deref.

And just FYI, I remember this issue: #17207 , are they related? That issue also said about the behavior differs between Gitea release.

I built 1.15.6 cherry-picked the changes from parnic-sks@768aaab and it did not fix issue #17207. Detail below.
We got a new bundle with LFS updates. I extracted the new LFS files, fetched the branch, and tried to push to origin. It would not push due hint: Your push was rejected due to missing or corrupt local objects. I also tried git lfs fetch --all and the push failed again.

That one commit is not enough, you need the entire branch diff. parnic-sks@3872374 was actually the correct fix, but it needs the commit after that to fix the nil user deref.

Sorry I mean I cherry-picked the whole branch.

Any update here? We are continuing to maintain the aforementioned patch on top of each Gitea release, but I'd love if we could find a more permanent solution that didn't require hand-building each version.

Any update here? We are continuing to maintain the aforementioned patch on top of each Gitea release, but I'd love if we could find a more permanent solution that didn't require hand-building each version.
(sorry for the double comment, I keep using the wrong account...)

OK the PR is a bit of a false flag here.

Create a repo A
Add an lfs file A_file on branch A_branch
Fork the repo B
Add an lfs file B_file on branch B_branch
clone A
Add B as a remote
checkout B_branch

This will fail.

Clearly this breaks any use of forks with LFS and needs to be fixed.

I have the exactly the same problem here.
Repo B is forked from repo A, if I clone B to local, and add an upstream for repo A, then fetch A, merge A, and a 404 error occurs. Cannot download LFS files from A.

Any updates on this?

In case you still have local files:

Go to https://git.example.com/user_name/repo_name/settings/lfs/pointers

Check lfs file which isn't in the repo or isn't in store. For example OID: 6c8872a754. Click on to Blob SHA: 1935a2af06 -> it will open a website and dispaly oid sha256:6c8872a754e3519067ab69de950cb7a980a73bd9cc565e858121aa6cd95119c6

Now use terminal, cd to repo folder.
Then run git lfs push origin --object-id 6c8872a754e3519067ab69de950cb7a980a73bd9cc565e858121aa6cd95119c61. Repeat the all other files.

So the question is how we would like to handle this problem. Personally I don't like to bring back file association in the download request. Auto-sync when creating a PR?

While I agree that associate on download is not ideal, there should be an auto-sync that associates all the files in PR. This would allow the commits and its LFS objects can be checked out in target repository.

Hoping this gets some attention at some point. This is a brutally frustrating issue.


docs: typo fix

tutorial-header.scss -> _tutorial-header.scss
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Hi @milindsingh! When importing Sass partials, you can omit the leading underscore so I don't believe this is a necessary change. Was there a reason in particular that you wanted to make this change?

Thanks @abbeyhrt I thought VSCode not detecting the files is due to wrong filename. I am new to design.


incompatible with go1.20-

slices and cmp is features introduced on go1.21.
To be compatible with go 1.18, remove uses of slices and cmp

also fmt.FormatString is used. This needs go1.20+ .

its needs go1.21.
func Equal[T any, E interface{ Equal(T) bool }](want E) Matcher[T] {

requires 1.21 feature.

go1.18 is abandoned. its is switched to go1.21+.


refactor(monorepo): relocate superset-ui

SUMMARY

This PR MUST wait for monorepo-stage-2 to pass CI.
This PR MUST merged before monorepo-stage-2 .

add lerna.json in superset-frontend
add workspace in packages.json
run command npx lerna import --flatten  --dest temporary_superset_ui ../../superset-ui to import all commits into superset-frontend. commit cut to : https://github.com/apache-superset/superset-ui/commit/3e1699542808f0720a6c05d95fc95f557d5c90fc
discard workspace changing in packages.json (in order not to add new dependencies, dependencies will be added in stage-2 PR)
ignore temporary_superset_ui in pre-commit-config
remove *.ipynb from .gitignore
in order to support merge or squash this PR so temporarily update .asf.yml

To ensure that every PR passes the CI, the monorepo-related PR is split into multiple stages.

https://github.com/apache/superset/pull/17427
https://github.com/apache/superset/pull/17445 (this PR)
https://github.com/apache/superset/pull/17437

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Before merge this PR, we must update .asf.yml to enable "Create merge commit", otherwise it is not possible:

This is really a huge change, it's too friendly for developers, what version will be launched?

We are just about to make a new release cut for 1.5. Finalizing the first release candidate + shipping it usually takes some time, but you should be able to start testing the new release branch within the next few weeks


Solution(?) for error while installing pyreason-gym

Error displayed:

error: Multiple top-level packages discovered in a flat-layout: ['media', 'pyreason_gym']

Solution that worked for me:
+    py_modules=[],
in setup.py line 6.
Verify if installation is correct when this is used.

Great, thanks @kmukherji I'll check this out. Can you open a PR and reference this issue?


docs(ui/select): use the setup script for exmple and docs

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #452 (fbc3d21) into docs/script-setup (7da02f0) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           docs/script-setup     #452   +/-   ##
==================================================
  Coverage              96.42%   96.42%
==================================================
  Files                    217      217
  Lines                   5148     5148
  Branches                 944      944
==================================================
  Hits                    4964     4964
  Misses                   184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da02f0...fbc3d21. Read the comment docs.


Rewrite external styles to allow dead code elimination

Currently external styles are rewritten to include both the global and scoped version of them because we cannot guess how the user wants to use them.
So
import css from 'styled-jsx/css'

export default css`body { background: red }`

Becomes
var _defaultExport = ['body{background:red;}'];
_defaultExport.__hash = '1536091005';
_defaultExport.__scoped = ['body.jsx-3002312892{background:red;}'];
_defaultExport.__scopedHash = '3002312892';
exports.default = _defaultExport;

I bet that most of the times users consume them either as global or scoped only.
Therefore we should find a way to make external files treeshake-able or rather see if we can rewrite them so that tools like UglifyJS or something can do dead code elimination.
If we manage do to so then styled-jsx could become a tool to use regular .CSS files in js/react with a plugin like this https://github.com/coox/styled-jsx-css-loader

cc @nkzawa @rauchg

Another option (breaking change) could be to repurpose the css tag from styled-jsx/css.
And have:

css genererate scoped styles only
css.global generate global styles only
css.universal generate both scoped and global styles

CONS: maybe prettier won't understand css.global and css.universal but we can submit a PR to fix that.

I have no good idea about this, but css and css.global make sense to me.

I am interested to work on this issue as I see this to be a great learning opportunity to learn more about css-in-js, writing babel plugin (babel-macro).
PS: I have very little experience writing babel plugins

@abiduzz420 hi! That's not a problem at all. Probably the scope of this feature is a bit broad, specially for someone who's never written a plugin before. That said if you or anybody else want to give it a shot, I would suggest to watch Kent's seminar about ASTs, and try to write a super dummy plugin on https://astexplorer.net
This feature can be split in two PRs. The first one should rewrite the current implementation of css to support the new requirements (see above). This should be the best way to start off I think. In a second PR we can re-use most of the code to implement css.resolve and finally make a babel macro plugin (I can do that in a 3rd PR).
Just clone the project, install the dependencies open up test/external.js and do the following:
diff --git a/test/external.js b/test/external.js
index 9ccf99c..6f1e56a 100644
--- a/test/external.js
+++ b/test/external.js
@@ -10,9 +10,10 @@ const transform = (file, opts = {}) =>
     plugins: [[plugin, opts]]
   })

-test('transpiles external stylesheets', async t => {
+test.only('transpiles external stylesheets', async t => {
   const { code } = await transform('./fixtures/styles.js')
-  t.snapshot(code)
+  console.log(code)
+  // t.snapshot(code)
 })

 test('(optimized) transpiles external stylesheets', async t => {

Now run the tests:
npm test

Make some changes in src/babel-external.js to the visitor/related functions and re run the tests.

fixed in #422


[BUG] No checking if system supports TUN adapters

Describe the bug
Lack of checking if TUN kernel module is available
To Reproduce
Steps to reproduce the behavior:

Deploy container-based server (ex. OVZ)
Run the role

Expected behavior
I expect the role to error early on with a message saying TUN kernel module is required
Screenshots
root@cdg:~# journalctl -xe
Dec 04 11:42:59 cdg tailscaled[8439]: logger closing down
Dec 04 11:43:00 cdg tailscaled[8449]: logtail started
Dec 04 11:43:00 cdg tailscaled[8449]: Program starting: v1.32.3-ta07555f43-g093d1e978, Go 1.19.2-ts3fd24dee31: []string{"/usr/sbin/tailscaled", "--state=/var/lib/tailscale/tailscaled.state", "--socket=/run/tailsc
Dec 04 11:43:00 cdg tailscaled[8449]: LogID: e92f5b48cb44249d26fed8efe5fab1af987f268626f6e6f4ca134a159e3856d5
Dec 04 11:43:00 cdg tailscaled[8449]: logpolicy: using $STATE_DIRECTORY, "/var/lib/tailscale"
Dec 04 11:43:00 cdg tailscaled[8449]: wgengine.NewUserspaceEngine(tun "tailscale0") ...
Dec 04 11:43:00 cdg tailscaled[8449]: Linux kernel version: 3.10.0-1160.53.1.vz7.185.3
Dec 04 11:43:00 cdg tailscaled[8449]: is CONFIG_TUN enabled in your kernel? modprobe tun failed with: modprobe: ERROR: ../libkmod/libkmod.c:514 lookup_builtin_file() could not open builtin file '/lib/modules/3.
Dec 04 11:43:00 cdg tailscaled[8449]: modprobe: FATAL: Module tun not found in directory /lib/modules/3.10.0-1160.53.1.vz7.185.3
Dec 04 11:43:00 cdg tailscaled[8449]: tun module not loaded nor found on disk
Dec 04 11:43:00 cdg tailscaled[8449]: wgengine.NewUserspaceEngine(tun "tailscale0") error: tstun.New("tailscale0"): operation not permitted
Dec 04 11:43:00 cdg tailscaled[8449]: flushing log.
Dec 04 11:43:00 cdg tailscaled[8449]: logger closing down
Dec 04 11:43:00 cdg tailscaled[8449]: createEngine: tstun.New("tailscale0"): operation not permitted
root@cdg:~# modprobe tun
modprobe: ERROR: ../libkmod/libkmod.c:514 lookup_builtin_file() could not open builtin file '/lib/modules/3.10.0-1160.53.1.vz7.185.3/modules.builtin.bin'
modprobe: FATAL: Module tun not found in directory /lib/modules/3.10.0-1160.53.1.vz7.185.3
Target (please complete the following information):

OS: n/a
Ansible version: n/a
artis3n.tailscale version: Latest
Tailscale version (set verbose to true): n/a

Additional context
Just wanted to document this error here.
I will create a PR with a check soon.

Fix: https://github.com/artis3n/ansible-role-tailscale/pull/264

Left a comment on the PR - https://github.com/artis3n/ansible-role-tailscale/pull/264#issuecomment-1336432850
I don't believe the TUN module is required - https://tailscale.com/kb/1177/kernel-vs-userspace-routers/ and https://tailscale.com/kb/1112/userspace-networking/ . My preference would be to leave the determination of whether kernel or usermode operation is desired to the end user.
Going to close the issue, but it will be unlocked for further discussion if I'm wrong about this.


6th message

What happens with the 6th message for E1?  Is it blocked?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca3f7a45-e892-fbb3-baf1-c556fa8e3720
Version Independent ID: 9c8b63e8-7320-ed8f-e560-ed478009dd57
Content: Priority Notifications in Teams Messaging  - Microsoft Teams
Content Source: Teams/teams-add-on-licensing/pri-message.md
Service: msteams
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@kisnardonline thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Filters - Events not displayed when schedule filter is set based on the event's end date or in between dates

Pre-requisites:
Create an event that spans for a couple of days (say 1 Jan - 7 Jan)
Steps to reproduce:

Launch the Application Under Test url: https://events-qa.on.fleek.co/
On the filters panel invoke the Schedule filter-Start date and select the date as '3 Jan'

Expected Result:
The related event (created on the pre-requisite) should get successfully displayed
Actual Result:
The related event (created on the pre-requisite) does not gets displayed.

Fixed the issue to show events between date range.. @WinsCodes  Please verify

Verified that the issue is now resolved.


Test

Since soccerwindow2 is working fine and also because the --port flag of the monitor (start.py line 75) is for soccerwindow2 not rcssmonitor (it should be --server-port for rcssmonitor) it is better to switch to soccerwindow2

Thanks for the PR! It looks good :)
I'm going to change the flags a little bit so that a user can specify the number of offensive agents, defensive agents, offensive teammates, and defensive teammates. This way we can support both single-agent and multi-agent learning.

Should we proceed with the multi agent setup

What more needs to be done for the multi-agent setup?

What does the output of "features = hfo.getState()" (Line 23, HFO/example/hfo_example_agent.py) correspond to? I mean each value in the tuple correspond to in the state of the world.

They are documented in the manual. Please see https://github.com/mhauskn/HFO/blob/master/doc/manual.pdf
Notably missing from this set are features that tell the agent if it has the ball and/or the location of the ball. I suspect I should add these features.

Yes, please add those.

Will add them today.

I've updated the manual and high level feature set to include ball-related features. Please do a pull to get the latest.


DO NOT MERGE -- KOGITO-102: jBPM Rule Unit integration

Initial implementation for runtime logic of https://github.com/kiegroup/kogito-examples/pull/72. this is still WIP

refactored BusinessRuleTask implementation so that it includes a RuleType, which may be RuleFlowGroup, RuleUnit, Decision, with respective parameters.

added code-generation:
      org.jbpm.ruleflow.core.factory.RuleSetNodeFactory ruleSetNode2 = factory.ruleSetNode(2);
      ruleSetNode2.name("Evaluate person");
      // no longer a lambda, the RuleUnit is given
      ruleSetNode2.ruleUnit("PersonValidationService",
            app.ruleUnits().createPersonValidationServiceRuleUnit());
      ruleSetNode2.inMapping("persons", "person");
      ruleSetNode2.outMapping("persons", "person");
      ...
      ruleSetNode2.done();

added handling logic for runtime
          } else if (ruleType.isRuleUnit()) {
              RuleUnitMemory> workingMemory = /* reflective magic to instantiate: we need to improve this */;
              RuleUnit<RuleUnitMemory> ruleUnit = ruleSetNode.getRuleUnit();
              RuleUnitInstance<RuleUnitMemory> instance = ruleUnit.createInstance(workingMemory);
              instance.fire();
              triggerCompleted();

@evacchi so effectively we have now three types of "rules" supported in business rule task

rule flow group
dmn
rule units
is this correct?

Overall looks good to me, just this reflection stuff to get the working memory. Can't we get it from the rule unit itself?

I think we should be able to pre-generate everything at compile time, will work on it

rebased over https://github.com/kiegroup/kogito-runtimes/pull/128

updated first post with details on how parameter mapping is currently working

code is still pretty rough/duplicated, so I'll open a JIRA for refactoring; however: tests pass. I'd say we could merge it, WDYT? @mswiderski @mariofusco

ok, let's wait for CI and see

jenkins please retest this


nixos/systemd.oomd: set the memory pressure thresholds as mkDefault

These should be defaults as they're pretty reasonable to want to override as a user. Unsure how to change the slice defaults to be overridable, that should probably be a later conversation.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Unsure how to change the slice defaults to be overridable, that should probably be a later conversation.

I think the best way is by adding systemd.user.slices.


Support polkadot wallet connect and implement AssetHub offramp

🦈 🟢 PR

[x] Support Polkadot wallet connect on Vortex
[x] Support AssetHub USDC balance
[x] Support AssetHub offramping flow

Closes #271 and closes #283.
Changes

build - NODE_OPTIONS='--max_old_space_size=8192' vite build
If we don’t include it, the build process breaks due to out-of-memory crashes. It increases the maximum memory allocation for Node.js in our app during the build process to prevent such crashes. I think we should debug the issue and eliminate it soon.

Removed GlobalState as it was unused. It previously contained code from Portal that wasn’t relevant here. For Polkadot-related state, I created two dedicated contexts: networks.tsx and polkadotWallet/index.tsx.

Removed models - it was unused

Reorganized the /assets directory as it was really cluttered. I reorganized it to chains, coins, logo (for Vortex logos), offramp (for quote providers), socials, wallets

Removed unused variables from config/index.ts (Pendulum Portal related)

<ConnectWalletButton> is now divided into <EVMWalletButton> and <PolkadotWalletButton>

I merged tokenConfig.ts with changes from #284 to be able to properly handle AssetHub USDC balance

@ebma This merge turned out to be huge, I'll clean it and describe Monday morning

@pendulum-chain/devs Ready for review 🟢

@ebma When USDT is selected and I try to change the network from Polygon to AssetHub there is an error, I'm implementing a fix

@ebma It is ready ✅

@ebma I agree that unifying the handling of substrate-related APIs is crucial for consistency and maintainability. I’ve removed the singleton and refactored the related files to be hooks and integrated usePendulumNode context

Some comments about the UI/UX (also for @prayagd):

shall we not call it "Polkadot AssetHub" instead of "AssetHub"?
wouldn't it be more clear to also write the name of the currently selected network in the network select button instead of only the logo?
wouldn't it make sense to also have a down chevron in the network select button to indicate that it is a dropdown list (similar to the token select buttons)?
When selecting AssetHub, then only the "Connect Wallet" button in the upper right-hand corner lets me select Polkadot compatible wallets. The "Connect Wallet" button in the input form still connects to EVM wallets. I can then connect with Metamask without problems. Then I the "Connect Wallet" button in the upper right-hand corner still says "Connect Wallet".
When selecting AssetHub and then pressing the "Connect Wallet" button in the upper right-hand corner to connect to a Polkadot compatible wallet, then even if this works, the main button in the form still reads "Connect Wallet" and, when clicking it, wants me to connect to an EVM wallet.
If connected to Metamask (when selecting Polygon) and I enter a valid input amount, the "Confirm" button stays disabled and I just see the error message "Something went wrong" under the output field.

@ebma The Network Selector still needs to be improved. When the user selects the network, the dropdown is not closing right now.

The last 5 commits add the logic for the AssetHub transfer that were originally implemented in #284. As this PR already used some of the code of #284, I decided to just add the rest so that this PR now covers the whole AssetHub flow. Merging this PR in isolation wouldn't make much sense anyway as the AssetHub USDC would be selectable but not usable.

Tested the deploy

The limits dont work, i can input lower amounts than 10 EUR and click on confirm
Compare quote feature is not visible
If i join using polygon network and click on "Confirm" and then switch the network to Assethub, I still see the continue with partner button. It does not refresh's or starts from beginning

Compare quote feature is not visible

@prayagd this is because none of the three quote providers are able to offramp assets from AssetHub. So we have two options: 1) not show the compare quotes feature on AssetHub at all or 2) show the compare quotes table and show 'N/A' or a different wording in each row. What would you prefer?

@ebma, let's add comparative quotes from Polygon and state that somewhere in the UI.

@vadaynujra So should we show Polygon's comparison prices for AssetHub?

Yes @Sharqiewicz, we will show the Polygon quote, and mention Polygon in the text as Sending 11 USDC (Polygon) with. When the user hovers on Polygon, they see a tooltip message saying: Quotes are for Polygon, as the providers don't support Asset hub yet.

@ebma @prayagd @gianfra-t
When user submits the swap by clicking on "Confirm" button, the "Continue with Partner" button appears. When the user switches between the networks the "Continue with Partner" remains - this is because the request to the partner is updated automatically.

@pendulum-chain/devs any estimate how long this will take to go live?

The last blocker we have is some bugs in the code we haven't managedto work around yet. Hard to tell.


Additional data added to dev fixtures #811

I plan on adding more data to the fixtures as I get more familiar with the rest of the page, but thought this should be a good checkpoint to merge changes in.
Included in this PR:

Overriden createsuperuser django-admin command so that it creates both auth.User and an associated assopy.User.
Added normal and admin user creation to the fixture.
Added sponsors associated with the current conference to the fixture with dynamic-generated logos.
Added the created pages to the top navigation menu.
Added text plugins to the homepage.

Instead of a mental note, I'll create a ticket for it - I'll happily take it over, but won't have capacity before the week of the 17th.

Great. Let's merge this one and I'm going to rebase #821


Add Service Offering to listSystemVMs and fix link from VR to its offering

Description
The API call listSystemVMs does not return the VM's service offering like listVirtualMachines does and, as such, the system VM page in the UI doesn't have that information like a user VM page has. This PR adds the fields serviceOfferingId and serviceOfferingName to the SystemVmResponse class.
It also changes the link to the offering in the VR page from client/#/computeoffering/<uuid>?issystem=true to /client/#/systemoffering/<uuid> for consistency (since it was the only place with such a way to access the system offering).
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

How Has This Been Tested?
I accessed the SSVM and CPVM pages in the UI and saw the field "Compute offering" with the name and link to their respective offerings. If the offering does not exist, it returns 404 in the same way a missing template does.
On the VR page, the link to its offering now redirects to the same page as if you had gone through Service Offerings -> System offerings.

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7038

@blueorangutan test

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-7673)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43559 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7938-t7673-kvm-centos7.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


Collapse alert groups when initially viewing ui

helps with frontend rendering, and (in my opinion) makes it more usable. clicking the + expands the group, much like showing/hiding annotations for individual alerts.
requested in #911

As far as I understand this would only allow to expand one group. Can we allow expanding multiple groups? Can we also have a button to expand all groups?

As far as I understand this would only allow to expand one group. Can we allow expanding multiple groups?

We definitely can. I thought about this but did the simple thing first. Also, since we only allow a single alert's annotation information to be open at a time, I thought I could do that as well.
I'm guessing, for implementation, we would store a List of Labels and compare against that.

Can we also have a button to expand all groups?

We definitely could. I'm wondering how often it would be used. But, if there are users/alertmanager installations running that have relatively few alerts/alert groups, maybe it would make sense to provide this.
Maybe you could give some suggestions on how to show this, and where to place it (I have very little UX skill..)

If we add a button to expand all groups, can we keep this preference in the localStorage like the username?

+1

If there is a single group, can we always expand it?

Makes sense

@stuartnelson3 let’s chat about this on Monday
Some ideas:
Would it be cool to collapse groups with too many alerts and auto-expand groups with a few?
Shall we show the number of alerts in a group?

Thanks for the PR and the discussion. Dynamically autoexpanding if a group has very few alerts and/or there are very few groups altogether would be awesome (cf. how GitHub renders notifications https://github.com/notifications , they even have partial expansion there, perhaps that would be interesting here as well, to see an example alert").
Would be great to see a number next to unexpanded groups ("44 alerts") or partially expanded groups ("41 more alerts, see more...")

My plans for this PR:

for a single group, expand it always
support expanding multiple groups
add a button to toggle expand/collapse all (user setting stored in localStorage)
add alert count behind group labels

And of course, this PR doesn't have to solve everything. It's already a great start.

@w0rm could you help a bit with the styling? in particular, the alert count seems to be on the "baseline" and should probably be bumped up higher, and the "expand all" button doesn't quite seem to be lined up correctly.

@stuartnelson3 I adjusted the styling:


app registry - create .github/.gitlab-ci.yml

@johndietz can you add more information to what this issue is please?


Preparing Own content for train

I am trying to create Q&A bot type, how should be my training data format. its should be like
> Q: why?
> A: answer1
> Q: who?
> A: answer2
or it should be only answers to the conversation?
> answer1
>answer2
@pender

The easiest would be training data of two lines per conversation, each line starting with '>'. For example:
> How many legs does a cow have?
> A cow has four legs.

> What color is a lemon?
> Lemons are yellow.

But, my repo is probably not the best architecture for simple Q&A without context being carried over between questions. You're probably better off looking at the Tensorflow tutorials for language translation ("seq2seq" models), and then thinking of it as translating questions into answers.


PemissionsEX stop at the second server start

I put the PEX in the plugins folder and then I start the server, all ok. When I shutdown the server and then I open this, the PEX don't work. I have installed the v1.23.3 in Spigot 1.8 with 31 more plugins (WorldEdit, ColoredSigns, VoidWorld, PlaceholderAPI, PerWorldPlugins, PlugMan, BlockedCommands, Heads, ProtocolLib, Multiverse-Core, VoidSpawn, WorldGuard, LibsDisguises, RogueParkour, eZProtector, DoubleJumpPlus, Murder, PerWorldTab, NoWeather, Tab, Vault, Essentials, CorpseReborn, ArmorStandTools, GadgetsMenu, Citizens, Shopkeepers, BuyNodes, EssentialsChat, PlayMoreSounds, EssentialsSpawn)

i don't work either


Tree: Remember find widget input across usages

Testing #156100
When find box is not visible and I just type but there are multiple results, then maybe allow me via keybindings (F3?) to go to next/prev result?

You mean using the type navigation feature? I think this would be too implicit. I don't know of any other native widget doing something like this.

I think the editor has a way to navigate in find results even without showing find. i think in that mode it only puts the search toggles up in a little overlay.

I think the tree does the same, I had tried F3 and it showed the input box, but it was empty though.

Yeah. Renamed this to remember the input across usages, which is what the editor does.


"d.dep.setValue is not a function" on nested components

I'm trying to use edge version and found some bug. I've prepared testcase as usual)
Bug appears after merge #1546 and looks related to #1542.
My case: http://jsfiddle.net/d4sgqma2/
All items are required to reproduce - component1 inherits values from root object, component2 rewrites context and uses function call and value is defined after first initialization.
Function itself isn't important — it fails with any one. http://jsfiddle.net/d4sgqma2/1/
new Ractive({
    el: 'body',
    template: '<component1 />',

    components: {
        component1: Ractive.extend({
            template: '<component2 foo="{{ bar }}" />',
        }),

        component2: Ractive.extend({
            template: '{{ console.log(foo) }}',
        }),
    },

    onrender: function() {
        this.set('bar', 1);
    },
});

http://jsfiddle.net/d4sgqma2/ doesn't work again with another one error.
Error: Exposing privileged or cross-origin callable is prohibited
this.node = document.createTextNode(this.value != undefined ? this.value : "");

in Interpolator.prototype.render()

What version of Firefox are you using? In FF36 I don't see anything like that. The this.set('bar',{}) inside the onrender doesn't seem to do anything, which is odd (marking this as a bug), but that behaviour's consistent between Chrome and FF.

I'm not getting the error in Firefox from the beta channel. Do you have any extra security/privacy/content restrictions enabled?
It looks like the mapping isn't getting added properly, because adding data: { bar: undefined } makes the empty object log on set.

It's 36.0.1, and seems there is no privacy extensions or something like that. I have some cases with this bug, I'll investigate it deeper and write details.

Ok, I've found. This isn't associated with this ticket.
Firebugs console.log returns undefined-like but object, which can't be rendered by ractive. Chrome Devtools and Firefox built-in debugger returns native undefined and everything is ok.
Maybe I'll post new ticket if there is some issues inside ractive about this.

Yes, this is firefox or firebug issue, nothing to fix in ractive


Core draft restructure

This PR is a proposal to restructure the draft drawing inspiration from the latest BLS signatures draft. Essentially the high-level structure of the document after this PR is merged will take the following form.

Introduction

Terminology
Notation
Structure of this document

Conventions
Scheme Definition

Parameters
Operations

KeyGen
SkToPk
....

Security Considerations
Profile -> Ciphersuite

Format
BLS12-381 Ciphersuite

IANA Considerations
Appendix
.....

Multiple approvals, purely editorial, merging


Typo fix lenght -> length

rector notice seems unrelated.

rector notice seems unrelated.

Thanks :+1:

Thanks :+1:


Adding drilldown links from the table plugin

Hi @fbaligand ,
I have a scenario wherein i will need to use drill down links. The default table plugin has the drilldown links however I couldn't find this in the plugin. Is there an alternate way to use the drill down links?
I will not be able to use the String formatting (URL) at the Index level because I will need to pass the filter value & also the value data which i'm choosing inside the table.

Hi @ganesh-s05,
Drilldown links are supported by enhanced-table since Kibana 7.9.2.
So the easy way is to upgrade your Kibana version to v7.9.2.
If it is not possible for you, you can add a computed column, with "Apply template" setting.
In Template, you can put a html link that references another dashboard with a filter applied based on some column value of the row:
{{col1}}

that's a brilliant idea @fbaligand . I couldn't upgrade to 7.9 for now.. but the reference column trick worked out. Thank you very much!
I actually had a control filter on top & also needed to reference the "column" as well. I wasn't very sure on how to reference the control filter value, so i added that field as another column as well, referenced it in the 'href' easily & hid the original column.
Thank you once again.

Nice to see that it solves your need!

@fbaligand - a quick question. Not relevant to the above ones. I did not want to open a new ticket for a simple question.
I am having about 40 columns of which 22 are reference columns. I will be anyways showing only about 10 columns and remaining i will be hiding. Will there be any performance issues that has been encountered in your experience with too many computations & reference columns?
Are there any kind of best practice should i keep in mind for these many columns?

Wow, 40 columns!
Honestly, I never experimented so much. So I can't tell how it behaves.
Just one thing, if you want to display one row per document, use Document Table, not Enhanced Table, performance will be greatly better (and your Elasticsearch memory also).

Well, I can get you the observations then.. I already have about 30 columns of which 10 are referenced columns. So, far its OK except for some shards issue if there isn't any filter applied.
I really am not sure about the "one row per document" thing.. I will also see how the Document Table is displaying my data.

Document Table shares a lot of code with Enhanced table, especially render view that displays the table.
Options tab is also shared.
So the only difference is that enhanced table query is a aggregations query (in your case, a lot of sub aggregations), and document table query is a simple search query where results displayed are hits.
That's why document table way more performant.

Hi,
I'm using kibana 7.9.2 but can't find Drilldown actions,
could you please give a sample?

Hi @shayegh,
First, be sure you have Kibana with at least "Basic" license, given that the feature is not OpenSource.
Globally, to get Drilldown actions:

you go to your dashboard page
you click on "Edit" link
you click on Enhanced Table viz settings icon (at top-right)
and you click on "Drilldown actions" menu item
if you don't see this menu item, you probably need to create a fresh new "Enhanced Table" visualization, as it may not be able available for visualizations created before Kibana 7.9.

Hi,
thanks for your response,
But is there any way to drill down by rows?
for example, I click on a row and by its data it sho me another dashboard.

This is exactly the aim of "Drilldowns" feature.
You can find official Kibana documentation about that feature here: https://www.elastic.co/guide/en/kibana/current/drilldowns.html
Concerning precisely enhanced-table, to use configured "Drilldowns", you click on "Filter for value" / "Filter out value" icon on one cell, and Kibana will ask you if you want to filter this dashboard or open a Drilldown dashboard.

Hi @fbaligand ,
Thank you for the quick answer, it solved my problem.
it's good to add this in your amazing plugin readme.

I didn't have indicated this in README, because, this is core feature provided by Kibana.
But everybody does not know every Kibana new feature, so that's a nice idea to document it.

Hi,
This information is now documented in README page.

Hi,
This information is now documented in README page.


Backport 2573 and fix dead links

Signed-off-by: ariamarble<EMAIL_ADDRESS>Description
Backport 2573 and fix dead links
Issues Resolved
#2092
Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Submitting backport and deadlink fixes


Reverse the semantics order of modal barrier and modal scope

Description
This will change the order that semantics focus traverse.
Related Issues
Fixes https://github.com/flutter/flutter/issues/46625
Tests
I added the following tests:
TBD, will add test once we are ok with this approach.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@goderbauer would you take a look at this pr? I don't have test yet since i would like to have some feedback if this the approach we want to take.

Can you use sortKey wrapped around the barrier and the modal scope to achieve the same affect in a simpler way (and without potentially messing up hittest order?
https://api.flutter.dev/flutter/semantics/SemanticsProperties/sortKey.html

Hi @goderbauer  I uses the sort key, and it seems to be a cleaner way to solve this problem. This however, broke a lot of semantics test because we add a new semantics node above each modal route. Before I proceed to fix all the failing tests, do you think this is the approach we want to take?

@goderbauer can you take another look at this?


[CSL-478] Introduce some policy regarding fees

@gromak

We need to develop some policy regarding fees. For example: each transaction should have at least size (tx) / 100 ADA as fees.
We need to update transaction verification to check fees according to policy developed in (1). I want this logic to be in a separate function. We can start with very stupid policy (e. g. consider all txs valid w. r. t. fees) and after we develop good policy we can change this function accordingly.
We need to modify wallet so that it creates txs with enough fees. It will be separate issue.

See Lars's paper on Tx Fees
Cardano Transaction Fees (1).pdf


[EDA] - Create NEW Education History Object

Critical Changes
Changes
Issues Closed
Closes #1266
New Metadata
Custom Objects:
Education_History__c
Deleted Metadata
Testing Notes

@m-kinkade Should page layout(s) be included this PR? cc @MatthewBlanski

@m-kinkade Should page layout(s) be included this PR? cc @MatthewBlanski

@kevinswiggum yes, they will be.  I'll be adding them shortly.

@MatthewBlanski changes discussed this morning have been incorporated.  PR is now ready for review :)


Update AUTHORS.md

I have updated the formatting of AUTHORS.md to improve the look and adjusted the dates to follow ISO 8601.
Additionally, I've placed myself in the retired maintainers category for the following reasons:

I’m no longer at Phenopolis, where this library is used in an internal project.
I’m not currently using it in personal projects.

Given the context, might be worthwhile merging this project with https://github.com/Vici37/cr-image?

cc @Vici37

cc @IsmailM


Update sources

:robot_face: Updating sources to the latest version.
Diff between current and this version can be seen here: https://github.com/NixOS/nixpkgs/compare/efe0307291c4a792951a947011f2e90038b6d116...d609c9c79e467929282a14c4226f823868e2672c

let's wait for unstable, since the macOS builds don't seem to be cached.


Create kpi

@xxxrocoxxx Could you please rename lib/domains/ua/edu/kpi to lib/domains/ua/edu/kpi.txt to follow this repository rules? Thank you!

@xxxrocoxxx I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen or create a new one if you have an update regarding the issue described above. Thank you for your understanding!


chore(dependencies): Update dependency eslint-plugin-jsdoc to v46.10.1

This PR contains the following updates:

Package
Type
Update
Change

eslint-plugin-jsdoc
devDependencies
minor
46.8.2 -> 46.10.1

Release Notes

gajus/eslint-plugin-jsdoc
v46.10.1
Compare Source
Bug Fixes

revert change to engines for now (5e6280f)

v46.10.0
Compare Source
Features

support ESLint 9 (eec9d95)

v46.9.1
Compare Source
Bug Fixes

check-examples: properly replace final extension; fixes #1172 (b102693)

v46.9.0
Compare Source
Features

bump jsdoccomment, devDeps.; fixes #1167 (fd1eab0)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixed a typo in the warn if private log message.

The CLA should now be signed.

coverage: 92.711% (+0.04%) from 92.669%
when pulling 7d4a5dd801c6ab73a5c0e581dc5e68f9495fd194 on rizerco:main
into 9f29edc71a3bdd26fee253694796002125416227 on dart-lang:main.

Thanks — I’ve signed the CLA but couldn’t see a way to rerun the checks?

Thanks — I’ve signed the CLA but couldn’t see a way to rerun the checks?

I've hit rerun, all green now!


minor fix

The example training command contains a minor bug: voc07+12-segmentation must be in place of voc07+12-segment

Appreciate your pull request a lot. However, I've already made the same modifications thanks to your issue :)


Disambiguate "estimate" pose from "goal" pose in log

Fixes #417
Previously setting a 2D Pose Estimate then a 2D Nav Goal would log something like:
[INFO] [rviz2]: Setting goal: Frame:map, Position(1.30849, -2.7475, 0), Orientation(0, 0, 0.624316, 0.781172) = Angle: 1.34851
[INFO] [rviz2]: Setting goal: Frame:map, Position(-2.8186, 2.15941, 0), Orientation(0, 0, 0.555852, 0.831281) = Angle: 1.17878

Now it logs something like:
[INFO] [rviz2]: Setting estimate pose: Frame:map, Position(0.672111, -0.269852, 0), Orientation(0, 0, -0.964214, 0.265125) = Angle: -2.60493
[INFO] [rviz2]: Setting goal pose: Frame:map, Position(0.259397, 0.284402, 0), Orientation(0, 0, -0.98341, 0.181399) = Angle: -2.77678

@jacobperron Done. How do I request a re-review

Just like that :smile:

@rotu Thanks for the contribution!


Request for Documentation on Updating Device Flow in GitHub Enterprise Server 3.9

Extension version: 0.72
VSCode Version: Version: 1.82.0 (Universal)
OS: Linux

Steps to Reproduce:
I am encountering an issue while trying to authenticate with a GitHub Enterprise Server version 3.9 using the "Authorizing OAuth apps" method. The error message I receive is as follows:
2023-09-20 11:51:37.970 [error] Failed to get one-time code: {"error":"device_flow_disabled","error_description":"Device Flow must be explicitly enabled for this<EMAIL_ADDRESS>
I kindly request documentation or guidance on how to update or enable the Device Flow for GitHub Enterprise Server version 3.9. This information would be immensely helpful in resolving the authentication issue I am facing.
I have already referred to the official documentation for GitHub Enterprise Server version 3.9, specifically this link<EMAIL_ADDRESS>but it does not provide details on updating or enabling the Device Flow.
Your assistance in this matter would be greatly appreciated, as it will enable me to successfully authenticate with GitHub Enterprise Server 3.9 using the "Authorizing OAuth apps" method.

@TylerLeonhardt, could the error include a link to how to enable device flow?

Hai @alexr00 ,
I'm looking for detailed guidance on enabling 'Authorizing OAuth apps' organization-wide on GitHub. Currently, our extension is displaying authentication errors and prompting users to follow the personal access token authentication method. However, our goal is to have Authorizing OAuth apps enabled for the entire organization, ensuring that all users go through authentication using the authentication app exclusively. If you could provide the necessary steps, I'll be able to share with our GitHub admin so that we can implement this change."

Hello @TylerLeonhardt, I've been in touch with the GitHub admin, and they've suggested that I connect with the Visual Studio Code (VSCode) team regarding an issue that's affecting the VSCode IDE. Specifically, the problem seems to be related to the device workflow, and it's occurring in version 3.9 of Github Enterprise. Interestingly, this issue didn't exist in version 3.7, and I also encountered a similar problem with a different Git Enterprise instance that also runs version 3.9.
Could you provide guidance on what configurations might be causing or disabling the device workflow in version 3.9? Additionally, it would be helpful if you could test the OAuth app against the 3.9 version to confirm whether it's functioning properly in that environment.

Thanks for the context @BhavyaVM1. I'll get back to you as soon as I have more information from GitHub on what needs to be done here.
cc @joshaber for awareness


Update gptv tool and save code tests

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (23c2762) 83.31% compared to head (cb402b7) 82.61%.
Report is 3 commits behind head on dev.

Files
Patch %
Lines

metagpt/tools/libs/gpt_v_generator.py
93.33%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #847      +/-   ##
==========================================
- Coverage   83.31%   82.61%   -0.70%
==========================================
  Files         225      225
  Lines       12456    12439      -17
==========================================
- Hits        10378    10277     -101
- Misses       2078     2162      +84

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix process not quitting when you close the window

Implements #62

Oh hey I missed this, why did it get closed?

I found a problem with it. Will open a new PR later today. ;)
Matt Bell<EMAIL_ADDRESS>schrieb am Fr., 17. Nov. 2017, 13:29:

Oh hey I missed this, why did it get closed?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/cosmos/cosmos-ui/pull/63#issuecomment-345231605, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFmO2aHKN8PuCo5YNgTBRbd-oXDwzNF3ks5s3Xw1gaJpZM4QgvD3
.


fix(sg): do not use cache for security groups

Fixes #1098
What is going on:
After the virtual machine is deleted, it is still in the list with the status removed. At this time, the security group still believes that she has a VM. After a while, CloudStack will remove the virtual machine from the list and only after this removal the security group will not have attached virtual machines and we can delete it.

PR updated. I remove the delete action for a system templates. These templates define by an administrator and can not be removed in any case.


at Microsoft.ML.Runtime.Contracts.CheckNonEmpty(IExceptionContext ctx, String s, String paramName)    at Microsoft.ML.ModelOperationsCatalog.Load(String filePath, DataViewSchema& inputSchema)    at Microsoft.ML.ModelBuilder.AutoMLService.Experiments.LocalAutoMLExperiment.d__15.MoveNext() in //src/Microsoft.ML.ModelBuilder.AutoMLService/Experiments/LocalAutoMLExperiment.cs:line 231 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.ML.ModelBuilder.AutoMLEngine.d__21.MoveNext() in //src/Microsoft.ML.ModelBuilder.AutoMLService/AutoMLEngineService/AutoMLEngine.cs:line 160

System Information (please complete the following information):

Model Builder Version (available in Manage Extensions dialog):
Visual Studio Version

Describe the bug

On which step of the process did you run into an issue:
Clear description of the problem:

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

#2752


Validate Tool

@thomasyu888 I've added a snippet of commented code that uses jsonschema package to validate a JSON object against a JSON schema. When testing a tool, we want to client to get the JSON object by sending a request to the Tool instead of reading JSON data from file. The snippet comes from this script that I used in our schemas repository to validate schemas: https://github.com/Sage-Bionetworks/nlp-sandbox-schemas/blob/develop/tools/validate/validate.py

'jsonschema>=3.2.0' is already in setup.py

Thanks for starting this @tschaffter .  I was actually going to rename NlpClient to DataNodeClient and then have a NlpToolClient.  Thoughts?

Depends on #42

@tschaffter, this can be merged


This file cannot be modified: present in egg denylist. in Python egg when uploading a JSON file.

So, I was tryna upload a JSON file named shit.json. It was the config file for my bot, but it gave me this error This file cannot be modified: present in egg denylist.. When I tried to rename and then upload, it gave me the same error. I even tried creating the file through the file manager, then it raised this error [Wings Error]: This file cannot be modified: present in egg denylist..

Hmm, I'll look into this in a few hours.

I can import the file perfectly, would you mind supplying me the logs?

@YajTPG Sorry for the delay with replying, here are the logs: https://ptero.co/dapuwejabo

Hmm, I don't really see anything related to the eggs, panel logs please?

Hmm, I don't really see anything related to the eggs, panel logs please?

http://bin.ptdl.co/ti2um here you go

The issue was not with the eggs.


tmux: Add support for setting the host clipboard

See tmux 96e7f33da3078facc504c6c66d42956bc44b2e54

I have a concern about this being exploited, I wonder if this should raise an event, and the app needs to prompt for whether to allow this.


fix: add type info for item parameter

Thanks for the interest in contributing.
What's the reason behind this change? All variables in the current stub are typed - Go allows to group together consecutive variables with the same type and it's what's happening here.

@andrerfcsantos i didn't know that about go. perhaps i missed it somewhere in the track, but this would also be confusing for other people new to the language, if it wasn't already explicitly introduced.

@wgwz The exercise gross store has the concept "functions" as prequisite (exercise "lasagna master"). The introduction document of "functions" explains the syntax used here. A test case can't really cover this so there is no explicit task to apply this. For some things, we need to rely on people reading the text.


Fixed for loop example regarding indexes

For-loop examples in chapter 1 using indexes do not seem to be syntactically correct.
It currently reads in the form for(slice, range) but specifying the range does not seem to work with zig 0.10.1.

Hi jonathan, sorry for the confusion but this repo currently tracks the master branch of zig rather than the major releases.


Adding get Migration Controller API to azure core.

Pull Request Test Coverage Report for Build 495090224

1 of 5 (20.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 43.087%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/extension.ts
0
1
0.0%

extensions/azurecore/src/azureResource/utils.ts
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 489251011:
-0.004%

Covered Lines:
24329

Relevant Lines:
51758

💛  - Coveralls

Pull Request Test Coverage Report for Build 495090224

1 of 5 (20.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 43.087%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/extension.ts
0
1
0.0%

extensions/azurecore/src/azureResource/utils.ts
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
3
72.99%

Totals

Change from base Build 489251011:
-0.004%

Covered Lines:
24329

Relevant Lines:
51758

💛  - Coveralls


Add support for lemesh.light.wy0c09

Add support for lemesh.light.wy0c09， https://github.com/AlexxIT/XiaomiGateway3/issues/814

Thanks!


bug fix and add pretrain weight loading for resnet50

What does this PR do?

Fixes #112 and AttributeError: 'ResNet50' object has no attribute 'fc' when using resnet for comatch.
Does your PR introduce any breaking changes? If yes, please list them.
No

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you list all the breaking changes introduced by this pull request?

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

@microsoft-github-policy-service agree


measure_single_shot() doesn't work

When running this with a SHT30-D sensor connected via i2c to a raspberry pi, I can't use the method measure_single_shot() without getting an exception.
start_periodic_measurement() and blocking_read_measurement() methods work.
Here is the error I get:
Exception has occurred: TypeError
argument must be an int, or have a fileno() method.
  File "/home/admin/vext_python/input/humiditysensor.py", line 29, in readTempHumidity
    (a_temperature, a_humidity) = self.sensor.measure_single_shot(
  File "/home/admin/vext_python/main.py", line 25, in <module>
    tempHumiditySensorHelper.readTempHumidity()
TypeError: argument must be an int, or have a fileno() method.

The relevant code section looks like this:
def readTempHumidity(self):
    (a_temperature, a_humidity) = self.sensor.measure_single_shot(
        Repeatability.MEDIUM, False
    )
    print(f"a_temperature: {a_temperature}; " f"a_humidity: {a_humidity}; ")

Line 29 of the error corresponds to (a_temperature, a_humidity) = ....
Doing the following yields the same result:
def readTempHumidity(self):
        # try:
        (raw_temp, raw_humi) = self.sensor.sht3x.measure_single_shot_high_repeatability()
        print(f"a_temperature: {SignalTemperature(raw_temp)}; " f"a_humidity: {SignalHumidity(raw_humi)}; ")

Any help would be gratly appreciated, I've been trying to debug this for 2 hours :D
EDIT: here is the whole file:
import time
from sensirion_i2c_driver import LinuxI2cTransceiver, I2cConnection, CrcCalculator
from sensirion_driver_adapters.i2c_adapter.i2c_channel import I2cChannel
from sensirion_i2c_sht3x.device import Sht3xDevice
from sensirion_i2c_sht3x.commands import Repeatability

from abstract.thingsboard import client

class TempHumiditySensorHelper:
    i2cPort = "/dev/i2c-1"

    def init(self):
        with LinuxI2cTransceiver(self.i2cPort) as i2c_transceiver:
            channel = I2cChannel(
                I2cConnection(i2c_transceiver),
                slave_address=0x44,
                crc=CrcCalculator(8, 0x31, 0xFF, 0x0),
            )
            self.sensor = Sht3xDevice(channel)
            self.sensor.stop_measurement()
            time.sleep(0.001)
            self.sensor.soft_reset()
            time.sleep(0.1)
            status_register = self.sensor.read_status_register()
            print(f"status_register: {status_register}; ")

    def readTempHumidity(self):
        (a_temperature, a_humidity) = self.sensor.measure_single_shot(
        Repeatability.MEDIUM, False
        )
        print(f"a_temperature: {a_temperature}; " f"a_humidity: {a_humidity}; ")

Oops, the problem was that I was using with LinuxI2cTransceiver(self.i2cPort) as i2c_transceiver:, meaning that the i2c_transceiver was automatically closed in my init method, so it could not be used anymore in the readTempHumidity method. Now I feel dumb.
Apologies for spamming your issues!


Fix graph partitioner when multiple MLIROp instances go side-by-side

Also fixed missing return statement in is_dubug function.
It should fix addmm pytorch layer tests (but the final graph form is not what we want to have -- due to ConvertLike ops that break the graph into multiple parts -- will be addressed later).

For me, tests run and gracefully fail on mlir branch but crash with this PR.
Maybe my build is dirty?
Anyway +1 on the missing return.

For me, tests run and gracefully fail on mlir branch but crash with this PR. Maybe my build is dirty? Anyway +1 on the missing return.

Are you running without TPP (OV_MLIR_TPP=OFF env var)? With TPP it is expected to fail in Python.

Are you running without TPP (OV_MLIR_TPP=OFF env var)?

Spot on, I didn't. Works fine with that.


Unauthorized access. 'Listen' claim(s) are required to perform this operation

Trying to receive messages from a Azure Service Bus Topic using a Shared Access Signature.
var topicToken = "SharedAccessSignature sr=sb%3a%2f%2ftestdev.servicebus.windows.net&sig=j********&se=1442125460&skn=Receive";
MessagingFactory mf = MessagingFactory.Create(runtimeUri, TokenProvider.CreateSharedAccessSignatureTokenProvider(topicToken));
var receiveClient = mf.CreateSubscriptionClient(topicName,subscriptionName);
var msg = receiveClient.Receive();
But keep getting Unauthorized error messages in the trace
[11:27.808] RECV sasl-mechanisms(sasl-server-mechanisms:[PLAIN,EXTERNAL])
[11:27.900] RECV sasl-outcome(code:0,additional-data:57656C636F6D6521)

[11:27.972] RECV AMQP 0 1 0 0
[11:28.060] RECV (ch=0) open(container-id:5ca3fcbab5ae45e5b9bccd079fe958c4_G8,max-frame-size:16384,channel-max:3,idle-time-out:240000)
[11:28.060] RECV (ch=0) begin(remote-channel:0,next-outgoing-id:1,incoming-window:2048,outgoing-window:2048,handle-max:7)
[11:28.201] RECV (ch=0) attach(name:amqp-receive-link testdev-t/Subscriptions/48835779804448ddac34e632f4f6aed7,handle:0,role:False,initial-delivery-count:0,max-message-size:266240)
[11:28.305] RECV (ch=0) detach(handle:0,closed:True,error:error(condition:amqp:unauthorized-access,description:Unauthorized access. 'Listen' claim(s) are required to perform this operation. Resource: 'sb://testdev.servicebus.windows.net/testdev-t/subscriptions/48835779804448ddac34e632f4f6aed7'.
Looks like the TokenProvider.CreateSharedAccessSignatureTokenProvider() with a shared access signature is not working. The same token / topic_subscription using WindowsAzure.ServiceBus nuget works fine. The 'Listen' permissions are granted.

Thanks for opening the issue.
The current version lacks the claim based authentication on receiver. I'll fix it and add into next release.
Paolo.

Thank you.
Regards,
From: Paolo Patierno<EMAIL_ADDRESS>Sent: Tuesday, September 8, 2015 4:54 PM
To: ppatierno/azuresblite
Cc: Vijayshinva Balasaheb Karnure
Subject: Re: [azuresblite] Unauthorized access. 'Listen' claim(s) are required to perform this operation (#2)
Thanks for opening the issue.
The current version lacks the claim based authentication on receiver. I'll fix it and add into next release.
Paolo.
—
Reply to this email directly or view it on GitHubhttps://github.com/ppatierno/azuresblite/issues/2#issuecomment-138522475.
VIJAYSHINVA BALASAHEB KARNURE
Technical Architect
HARMAN Connected Services
Tel. +918066107000 | Mobile +918066107000 | Twitterhttps://twitter.com/symphony_teleca
3 Floor, C4block, Wing A ,Manyata SEZ park, Rachenahalli,Nagawara village,Outer ring road,Bangalore-560045
[www.symphonyteleca.com]http://www.symphonyteleca.com/company/newsroom/blog/the-st-blog/2015/july/microsoft-iot-partner-of-the-year-and-the-award-goes-to/
Please consider the environment before you print.
Notice to recipient: This e-mail (including any attachments) is meant for the intended recipient only, may contain confidential and proprietary information, and is protected by law. If you received this e-mail in error, please immediately notify the sender of the error by return e-mail, delete this communication and any attachments, and shred any printouts. Unauthorized review, use, dissemination, distribution, copying or taking of any action based on this communication is strictly prohibited.

I have just updated the "develop" branch of the project with the feature.
You can use it and test if it works in your scenario : a feedback is appreciated so that I'll merge in the "master" branch and will release on Nuget the new package.
Thanks,
Paolo.

Just released version 1.2.0 with SAS token support.
Paolo.

Hi,
We see the below error on updating the package to the latest version. This link also states a similar exception https://github.com/aspnet/dnx/issues/526
Missing method System.Net.Sockets.Socket::.ctor(SocketType,ProtocolType) in assembly /usr/lib/mono/gac/System/<IP_ADDRESS>__b77a5c561934e089/System.dll, referenced in assembly /home/pi/Gateway/IoTNext.Gateway/Amqp.Net.dll
2015-09-16 12:20:09.0927|ERROR|IoTNext.Gateway.Daemon.CloudSubscriber|System.MissingMethodException: Method not found: 'System.Net.Sockets.Socket..ctor'.
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[d__5] (Amqp.d__5& stateMachine) [0x00000] in :0
at Amqp.TcpTransport.ConnectAsync (Amqp.Address address, Amqp.ConnectionFactory factory) [0x00000] in :0


[BEAM-8335] Add initial modules for interactive streaming support

Adds the InteractiveService proto and impl for sending remote scripts to a TestStream
Adds the StreamingCache that knows how to read from an underlying cache and correctly emit elements to the TestStream

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

I discussed with Robert the necessity of the GRPC service. In it, we agreed that the easiest way to support an interactive streaming job is through an HTTP service. Unfortunately, using HTTP transcoding with GRPC requires having a copy certain protos in the repo to be used during proto compilation. Thus, I will make a separate HTTP server without using the GRPC service definition and remove all InteractiveService rpcs except for the Events request.

Run Python PreCommit

Run Java PreCommit

Run Python PreCommit

Run Java_Examples_Dataflow PreCommit

Whether this is streaming or not has nothing to do with quiescence. By spreading the call across several RPC calls the service has become stateful, more complicated, and idempotent. Much better for the RPC to be "give me the events of this test stream" than have a (one-time-use) multi-RPC protocol to fetch them.

The current implementation in the DirectRunner is that the TestStreamEvaluator reads a single event from the TestStream at a time. It is stateful in nature as it has to keep its current index into the TestStream events between calls. Remember that the DirectRunner creates a TransformEvaluator per application of a bundle. In order to support that semantic of requesting and sending a single element, the service will also reflect that.

This PR does three separate things that all fall under the heading of "add initial modules." To facilitate getting this in, I suggest braking it up in to multiple PRs.
(1) Augment TestStream to support multiple output, with tests.
(2) Add a service backing for TestStream.
(3) Add the StreamingCache stream merging classes.

With all due respect, this should have been brought up at the start of the review. With that in mind, I am inclined to finish this PR as-is, without breaking it up. I will keep your recommendation in mind in future PRs.

Whether this is streaming or not has nothing to do with quiescence. By spreading the call across several RPC calls the service has become stateful, more complicated, and idempotent. Much better for the RPC to be "give me the events of this test stream" than have a (one-time-use) multi-RPC protocol to fetch them.

The current implementation in the DirectRunner is that the TestStreamEvaluator reads a single event from the TestStream at a time. It is stateful in nature as it has to keep its current index into the TestStream events between calls. Remember that the DirectRunner creates a TransformEvaluator per application of a bundle. In order to support that semantic of requesting and sending a single element, the service will also reflect that.

We should not let an implementation, especially one that is hopefully going away soon, dictate what our APIs should be. Instead, we should come up with clean APIs that represent the abstraction well, and then figure out how they can be implemented. Only if it's truly impossible (or undesirable) to support a clean API should we mangle it to reflect the implementation.
Alright, I rewrote the API to return a stream of TestStream events back. This also allowed to get rid of the ConnectRequest.

This PR does three separate things that all fall under the heading of "add initial modules." To facilitate getting this in, I suggest braking it up in to multiple PRs.
(1) Augment TestStream to support multiple output, with tests.
(2) Add a service backing for TestStream.
(3) Add the StreamingCache stream merging classes.

With all due respect, this should have been brought up at the start of the review. With that in mind, I am inclined to finish this PR as-is, without breaking it up. I will keep your recommendation in mind in future PRs.

I don't see how splitting it up now is harder than it would have been at the start (though, yes, had we done it sooner perhaps some pieces could have been in already). But this is a huge change with many orthogonal features that should be separated out, if just for ease of rollback in case something is broken, and for clean history when trying to understand the code.

Run Portable_Python PreCommit

Run Java PreCommit

I broke up the PRs into:

https://github.com/apache/beam/pull/10120 : TestStreamService
https://github.com/apache/beam/pull/10119 : StreamingCache
https://github.com/apache/beam/pull/10117 : Protos

PTAL at your earliest convenience.


Scientific Notation

Sorry to bother you but I can't figure out how to convert EFloat or EDecimal to scientific notation. the default ToString() only converts number to string, same with ToEngineeringString().

Can you explain in more detail what you seek to achieve, including examples of inputs and expected outputs?
Are you trying to get a format like the following?  9.9999 * 10^50.
The format returned by ToString and ToEngineeringString is not exactly scientific notation.  For example, ToString's documentation currently says: "The text string will be in exponential notation if the exponent is greater than 0 or if the number's first nonzero digit is more than five digits after the decimal point."

What I want is to display EFloat as scientific notation. For example 15001 represented as 1.5001e+4 or  1.5001e4. Is there a built in method? Surprisingly when I use ScaleByPowerOfTen on EDecimal, the default ToString starts showing scientific notation.

Indeed, ToString does not always show what you call "scientific notation"; this is to match the behavior in the General Decimal Arithmetic Specification.  In particular, see the examples in the text.  Also, you can use ScaleByPowerOfTen on an EDecimal number as you found out to add more "digits" to an EDecimal and bring its exponent to greater than 0.  Finally, EFloat.ToString converts the string to EDecimal, then calls ToString, so much of the same discussion applies to EFloat as well.

Thank you for clarification.


Corrupted database after attempting to import from Chabotui.com

I imported a json that I had exported from chatbotui.com, but the app now throws this error when run

(This is now a showstopper as I don't know how to fix it without rebuilding the whole thing including the database)

Okay, mark this as solved.
The readme suggests that NEXTAUTH_URL has a default value, ie doesn't have to be set, but in fact it must be set when running locally. I had commented it out.

@johnbrownlow check this branch: https://github.com/jorge-menjivar/unSAGED/tree/import-fix
Let me know if this solves the issues

Yes! That solved it. Thank you!

I notice that it doesn't import system prompts. Is this because ChatbotUI doesn't export them?

Chatbot UI doesn’t have support for system prompts at all. Their “prompts”, are imported as message templates.
There are some caveats to have in mind as well. Importing the same file twice will result in duplicate messages because chatbot UI doesn’t include message IDs or timestamps, so there is no easy way of telling which messages have already been imported. I guess we could go message by message comparing the content to find the difference and make a guess what messages the user would like to import, but that’s out scope for now.

It works fine for me right now as I'm just using it to transition. Cheers!


[FLINK-32729] allow new deployment with suspended state

What is the purpose of the change
Allow new deployment with suspended state. So that a backup application can created in advance.
Brief change log

Change the DefaultValidator to accept both running and suspend state for first deployment
Change DefaultValidatorTest to reflect the latest logic.

Verifying this change
This change is already covered by existing tests in DefaultValidatorTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changes to the CustomResourceDescriptors: (no)
Core observer or reconciler logic that is regularly executed: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not documented)

@gyfora when can we get a release with this changeset included?

We just completed the 1.6.0 release, this feature is not included in that as it was merged after the release cut. This will be part of then next 1.7.0 release, scheduled in about 2-3 months normally.


Problem with cascading when using the same form in different dialogs

I have dialog with a form (A) that includes two lookup editors where the second editor cascades from the first. The dialog and casading is working perfectly fine. My problem occurs when I load form (A) into a tab in a different dialog like below: (I'm reusing the same form as a view in another dialog)
 constructor() {
            super();
          this.secondPropertyGrid_in_other_dialog = new Serenity.PropertyGrid(this.byId("secondPropertyGrid_in_other_dialog "), { items:   Q.getForm(MyForm.formKey),
useCategories: true });
        }

         protected afterLoadEntity() {
            super.afterLoadEntity();

           Service.Retrieve({
                EntityId: this.entity.SomeId
            }, response => {
                this.secondPropertyGrid_in_other_dialog .load(response.Entity);
              });
        }

What happens is that the form loads fine except the cascaded field. I get an error: Can't find cascaded parent element with ID: "MyCascadeField". The error comes from Serenity.Script.UI.js
var parent = Q.findElementWithRelativeId(this.$widget.element, this.$parentID).tryGetWidget(TParent);
				if (ss.isValue(parent))
{
					parent.element.bind('change.' + this.$widget.uniqueName, ss.mkdel(this, function() {
						this.$parentChange(parent);
					}));
					return parent;
				}
				else {
					Q.notifyError("Can't find cascaded parent element with ID: " + this.$parentID + '!', '', null);
					return null;
				}
`

    Driving me nuts..any help apreciated...

I believe it has something to do with the generated html id:s that look diferent when I use the form with another propertygrid. All Id:s begins with "undefined....."

did you use a template for that dialog?

Yes I do. Another template with tabs and a form with a property grid on the
first tab.
Den 4 jan 2017 05:31 skrev "dfaruque"<EMAIL_ADDRESS>
did you use a template for that dialog?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/volkanceylan/Serenity/issues/1727#issuecomment-270292810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APgOzkR89PvhF_c6HnN7Y_8_lYg4aeyvks5rOyCdgaJpZM4LZwMx
.

This wont work. Find full ID somehow

Even if you succeed this is a bad design

Thanks, but I don't understand what you mean with full ID.

Ok I understand now what you mean by full ID, but I don't understand why it's not generated in my example.

Dialogs has unique ID, generated every time, an editor can only find elements in its own container, e.g. dialog with relative ID.

What I am doing is exactly what you show in your example BasicSample/Dialogs/another from in tab. I have discovered that your example behaves the same way like my code, and I bet casacding wouldn't work in your example either.

Sorry for the big image, but as you see the id's in the cutomer tab is being prefixed with undefined, and i belive that this is the problem. Now I wonder how to workaround this.

Hmm pass idPrefix option as this.idPrefix while creating second property grid

Thanx alot... IT WORKS....... I understand you have much to do. But if you have a minute over please explain why it works.

If you pass idPrefix (which you should always pass, i forgot that in sample), property grid creates elements with IDs that are prefixed with that idPrefix, which is the same for main property grid in dialog, thus they all have ID's that start with SomeDialog1357_ etc.
This also means your if you have two properties with same name in those grids, they will clash. So if thats the case, use idPrefix: this.idPrefix + "Secondary_" etc. So items in first property grid will have SomeDialog1357_Field1 while second one, SomeDialog1357_Secondary_Field2. This should still let you use CascadeFrom("Field1") on Field2, as it can split on "_" and find a parent element.

Thanks for helping me out with this.


Xamarin.iOS 10.0 - Image not loading

This is the error we get from FFImageLoading service
Package used: 2.1.8 (Happens in the lower versions as well)
FFImageLoading package is using HTTPClient I believe, instead it has to use modern HTTPClient
This link might be helpful to resolve this issue.
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0004e] in :0
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x0002e] in :0
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x0000b] in :0
at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1+ConfiguredTaskAwaiter[TResult].GetResult () [0x00000] in :0
at FFImageLoading.Work.ImageLoaderTask+d__9.MoveNext () [0x00316] in <4f7daaa7a2514c898dffc252f489bd9f>:0

It's not an FFImageLoading issue. Read more here: https://github.com/luberda-molinet/FFImageLoading/wiki/iOS-API#internet

On iOS9 you will need to configure ATS (App Transport Security) to load from non HTTPS websites: by default ATS prevents requests to non HTTPS website. This is easily configurable: http://ste.vn/2015/06/10/configuring-app-transport-security-ios-9-osx-10-11/

You can also use ModernHttpClient (or any other custom HttpClient). Just initialize a custom FFImageLoading config with
			var config = new FFImageLoading.Config.Configuration()
			{
				HttpClient = new CustomHttpClient(),
			};
			ImageService.Instance.Initialize(config);


The local CCM activate command fails to properly set the AMT password when the AMT password is specified using the "-password" flag

Steps to reproduce:

rpc activate -local -ccm -password AMTPassword
See the activation successful message
rpc configure syncclock -password AMTPassword
See the error, 'Authentication failed'

Note:
Issue is only seen when activated using '-password' flag. Don't replicate this issue when password is prompted (ex: rpc activate -local -ccm).

Fixed in this PR #475


What's the tested most stable set of configurations?

I'll be using this with an Electron project and more specifically on the main process. I'm extremely impressed by this tool and kinda overwhelmed with the configuration.
I'm finding reported bugs here and there with different combinations of configs. What would be the safest set of configurations to use if I plan to split my main process into multiple files? Which means I need to be able to import and call functions + access variables from those files.

Use option presets as a start point:
https://github.com/javascript-obfuscator/javascript-obfuscator#optionspreset

Use option presets as a start point:
https://github.com/javascript-obfuscator/javascript-obfuscator#optionspreset

Thank you for the instant response. Just noticed that. Will the simplify setting in default preset cause me any issues as mentioned in #860?
Also will the function names between files be an issue?

Thank you for the instant response. Just noticed that. Will the simplify setting in default preset cause me any issues as mentioned in #860?
Also will the function names between files be an issue?

#860 should be a rare issue, so try to use it

#860 should be a rare issue, so try to use it

Will do. Thank you. Closing the issue.

Will do. Thank you. Closing the issue.


Thread local storage annotation

We need a way to annotate that some particular storage should be replicated across threads and to choose the type of storage that gets created in the local copy.

duplicate of #245

Partially closed via #256


1 package failed: moveit2_tutorials

Description
Overview of your issue here.
Your environment

ROS Distro: [Foxy|Galactic|Humble|Rolling]
OS Version: e.g. Ubuntu 22.04
Source or Binary build?
If binary, which release version?
If source, which git commit or tag?

Steps to reproduce
Tell us how to reproduce this issue. Attempt to provide a working demo, perhaps using Docker.
Expected behaviour
Tell us what should happen
Backtrace or Console output
Use gist.github.com to copy-paste the console output or segfault backtrace using gdb.

Closing this as the issue contains no information around the actual issue


feat(bin/projext-runner): add log messages for all the steps

What does this PR do?

This comes from homer0/projext#79.
This has been bothering me for some time now: the bin commands are SLOW. My theory is that the problem is a mix of sync calls on the file system and commander.
On the long run, the idea is to fix those issues (go async when possible and replace commander), but for now, I added more log mesages on the binary so you can at least know what's happening while you wait.

So, I applied the same logic to the runner binary.
How should it be tested manually?
In order to test this, you need to install homer0/projext#next.
Checkout the branch and try running a target, you'll see step by step what the runner and projext are doing.

Pull Request Test Coverage Report for Build 148

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 143:
0.0%

Covered Lines:
355

Relevant Lines:
355

💛  - Coveralls

Pull Request Test Coverage Report for Build 148

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 143:
0.0%

Covered Lines:
355

Relevant Lines:
355

💛  - Coveralls


Only build LLVM 7.0.1 for Windows CI.

In order to simplify our CI, we will only build with LLVM 7.0.1 for Windows.

Ignore the failing CirrusCI "Docker Build" job.


Error creating WhatsAround need after HTTP 503

WhatsAround need currently cannot be created (any environment, any browser)
Error in js console:
Failed to load resource: the server responded with a status of 503 (Service Unavailable)
/owner/#!/landingpage:1 Failed to load https://nominatim.openstreetmap.org/reverse?lat=48.2168662&lon=16.361997499999998&format=json&zoom=13: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://www.matchat.org' is therefore not allowed access. The response had HTTP status code 503. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
/owner/#!/landingpage:1 Uncaught (in promise) TypeError: Failed to fetch

Interesting:
https://help.openstreetmap.org/questions/15990/api-js-cross-domain-problem

seemed to be a temporary error


Is there a way to connect with HANA Studio to HANA Express in docker?

could not get a connect where local connect is possible

Hi @jochensteinmetz,
When using Docker, the port numbers are slightly different (39017 instead of 39013 and 39041 instead of 39015), and in addition when starting your container you have to publish these port using the "-p" switch.
in step 5 of  Installing SAP HANA, express edition with Docker, yu can see the run command which publish these ports:
sudo docker run -p 39013:39013 -p 39017:39017 -p 39041-39045:39041-39045 -p 1128-1129:1128-1129 -p 59013-59014:59013-59014 -v /data/express_edition:/hana/mounts \
--ulimit nofile=1048576:1048576 \
--sysctl kernel.shmmax=1073741824 \
--sysctl net.ipv4.ip_local_port_range='40000 60999' \
--sysctl kernel.shmmni=524288 \
--sysctl kernel.shmall=8388608 \
--name express_edition \
store/saplabs/hanaexpress:<IP_ADDRESS>.20171211.1 \
--passwords-url file:///hana/password.json \
--agree-to-sap-license

Then when configuring the SAP HANA Tools for Eclipse, you can check the following tutorial: Use the SAP HANA Tools for Eclipse as a SQL query tool for SAP HANA, express edition which explains that with Docker you have to use a little trick (see step 3 and 4).
Hope this helps.
@bdel

Hi Abdel,
thank you so much, that did the trick.
"In order to connect to the System Database, you will need to select then select Tenant database, and input SYSTEMDB:39017 in the name field. This is due to a specific port binding configuration"
Best regards,
Jochen


[CXF-7462] Minor improvements to OutboundSseEventImpl

Make the fields final to reflect that the event is immutable.
Use defaults for the data type (String.class) and media type
(SERVER_SENT_EVENT_TYPE).
Restrict the constructor's visibility.

New tests.

Thanks for the improvements, @andymc12! Just a couple of minor comments before merging. Thanks!

Andriy, I went ahead with throwing IllegalArgumentExceptions when the user passes in null as either the data or type parameters.  This is more consistent with the API in the javax.ws.rs.sse.Sse interface.  If you disagree, please let me know.  I'll plan to leave this PR open until tomorrow.
Thanks again for the thorough review!

@reta @sberyozkin I've updated the code again - here is the rough summary of changes:

Default the event's type to be data.getClass()
Throw an IllegalArgumentException if data is null.  This is consistent with the spec's Sse.newEvent(null) method.
Default the event's MediaType to be MediaType.TEXT_PLAIN_TYPE - this avoids NPEs that I was seeing in the OutboundSseEventBodyWriter class.
Tests for all of these cases.

I'm going on vacation tomorrow, so hopefully I can get this merged today.  Can you two give the code one last review?
Thanks again!
Andy

Thanks, @andymc12! It's in master, have a great vacation!

Thanks @reta!


Add fast path to AllocationPool::allocateFixed

Almost all uses of the function allocate an unaligned small piece from an already allocated range in AllocationPool. Test for this first. Most existing tests hit this fast path.

@oerling Do we want to inline the fast path if this is a bottleneck?  We can move the long implementation in another private method.


[BUG] It seems like the Interactive Engine doesn't support some Cypher statements

Describe the bug
MATCH p=()-[:write]->() RETURN p LIMIT 25;

Match (a)-[c*1..3]->(b) Return a, c, b

Match (n) return n limit 10 this statement executed successfully.

To Reproduce
Steps to reproduce the behavior:
Refer to this document: https://graphscope.io/docs/flex/interactive/custom_graph_data

For the first query, p = xxx such kind of query is not supported yet. We have no plan to support it in a short time.

For the second query, I will fix it via #3538 , BUT the returned result(only return the last vertex) will still different from the standard neo4j cypher query result(returning all vertices/edges on path). See #3537


https://developer.mozilla.org/ru/docs/Web/API/CanvasRenderingContext2D/createLinearGradient

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

https://developer.mozilla.org/ru/docs/Web/API/CanvasRenderingContext2D/createLinearGradient
In example on Russian lang nothing.

Fixed it.
Problem was that it was trying to load the example (EmbedLiveSample) with the English title instead of the Russian title.

Awesome, thanks @MendyBerger !


Rename 32-bit OS X platform identifier from mac32.xcode24 to mac32.gcc4

Fixed in c2238dceb4147a8a35b60f5eeeecfd9708c9dffd and ed8ab183ed60ff5270c31f6d56bd6be150f69782.