Weaviate Vectorstore not initialized with Azure OpenAI embeddings

System Info
Weaviate vectorstore not getting initialized with Azure OpenAI embeddings.
Code:
from langchain.embeddings import OpenAIEmbeddings
from langchain.vectorstores import Weaviate
from langchain.embeddings.base import Embeddings

auth_config = weaviate.auth.AuthApiKey(api_key=WEAVIATE_API)
client = weaviate.Client(url=WEAVIATE_HOST, auth_client_secret=auth_config)
embeddings_model: Embeddings = OpenAIEmbeddings(model="text-embedding-ada-002", chunk_size=1)
vectorstore = Weaviate(client=client, index_name="chatbot_dev", text_key="content", embedding=embeddings_model)

Error:
TypeError: Weaviate.__init__() got an unexpected keyword argument 'embedding'

Also, tried to initialize with Weaviate.from_texts()
from langchain.vectorstores import Weaviate
qa = Weaviate.from_texts(texts=['here is a sample'], embedding=embeddings_model, index_name="content", weaviate_url="your Weaviate URL")

Error:
NotImplementedError: weaviate does not currently support `from_texts`

Who can help?
@ruanwz @vowelparrot
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[X] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
from langchain.embeddings import OpenAIEmbeddings
from langchain.vectorstores import Weaviate
from langchain.embeddings.base import Embeddings

auth_config = weaviate.auth.AuthApiKey(api_key=WEAVIATE_API)
client = weaviate.Client(url=WEAVIATE_HOST, auth_client_secret=auth_config)
embeddings_model: Embeddings = OpenAIEmbeddings(model="text-embedding-ada-002", chunk_size=1)
vectorstore = Weaviate(client=client, index_name="chatbot_dev", text_key="content", embedding=embeddings_model)

Expected behavior
Weaviate vector store library should be generic to support multiple use cases.

Same error I am getting.

I am thinking that can I use Weaviate implementation direct from weaviate package without using langchain.vectorstores , anyone have any comment on this ?
If I got success I will post it here the approach.

is this solved already ? I am getting the same error !

@yassinsws, you can do Weaviate implementation directly from the Weaviate package without using langchain.vectorstores. if you need I can provide working code.

Yes that would be helpful thank you


can't use v6 with Fastify anymore due to webhooks processing

Issue summary
Shopify webhook processing also sends headers, which messes up non-Express frameworks, such as Fastify.
In previous version,
https://github.com/Shopify/shopify-api-js/blob/main/docs/migrating-to-v6.md#changes-to-webhook-functions
this was workaround-able with a custom handler ran very early, before body was received
await Shopify.Webhooks.Registry.process(req.raw, res.raw);

process() was fetching request body, and sending response headers, so it handled everything.
In v6, it wants the rawbody though, already handled by the app:
await shopify.webhooks.process({
      rawBody: (req as any).rawBody, // as a string
      rawRequest: req,
      rawResponse: res,
    });

This is good.
BUT it also sends HTTP headers/responses.
If we wait until body is received by our app, processing webhooks with above leads to error  FastifyError: Reply was already sent.
Expected behavior
Since process() has stopped reading body by itself, also stop sending HTTP traffic. Just process the data and return headers/status to the caller app, which will handle them using any framework.
Steps to reproduce the problem

try to implement webhook handlers using Fastify instead of Express

Checklist

[x] I have described this issue in a way that is actionable (if possible)

Hi, thanks for reporting this! As you mentioned, the new process call will always respond to Shopify, whether it worked or not.
Is there a specific use case for not responding once we run the handler? The idea behind this method is that you can call it, it'll trigger your added handler and make sure Shopify gets a response, so the app doesn't have to worry about dealing with the request.
We could look into optionally skipping the response part, but I'd like to understand the scenario a bit better.


Unable to find device on bus pirate using bp_read.py [Windows]

I'm on a windows 8 machine running Python 2.7.12 with pycrypto 2.6.1 installed. When trying to use the test file bp_read.py I am unable to find my EEPROM chip.
In cmd I use the command python bp_read.py COM7 eeprom.bin and I've made sure that I'm connected to the correct COM port and the baud rate is set to 115200.
The following output is received:
λ python bp_read.py COM7 eepromBin
Device found: None
Traceback (most recent call last):
File "bp_read.py", line 138, in
raise(Exception("unable to find a device on this 1-wire bus"))
Exception: unable to find a device on this 1-wire bus
I've tested the EEPROM chip with a OneWire sniffer and can find all of the data.
I've tested the buspirate with the hardware test on the dangerous prototype website with all OK
I cannot figure out why I'm unable to find my EEPROM chip.
My setup looks like this:

won't fix as BusPirate is not the preferred option (use a raspberry pi).


Remove "J2objc" prefix from all filenames (kept for config and tasks)

The J2objc was useful when it was a single file. Since moving in to the new Plugin architecture, it obscures the purpose of classes and files, as you have to look in more detail to parse it. Since the plugin is in an isolated GitHub repository and doesn't have to interact with other code except as a plugin, I don't believe there's any concerns about collisions.
My plan is to remove J2objc from all files and classes.
The j2objcConfig config and all tasks will retain the j2objc prefix.

@advayDev1, @confile - please comment.

I strongly support this.

Thanks @confile.
@advayDev1 - please give your sign off and then I'll go ahead.
If there's any other suggestions you have for moving around code or renaming files, this would be a good time to suggest it.

I'm fine either way.  The only loss is annoying blame history.  But if this makes your development lives easier, go for it.

It appears that the file history, including blame is still preserved:
https://git.wiki.kernel.org/index.php/GitFaq#Why_does_Git_not_.22track.22_renames.3F
The two tools for assigning blame, git-blame(1) and git-annotate(1) both use the automatic rename detection code to track renames.
Great Linus rant on tracking renames if you'd care to read it:
http://permalink.gmane.org/gmane.comp.version-control.git/217

Oh I understand that git keeps track of the content vs. the file, it is just that in github.com's GUI 'blame' view at least for my own repos it only sometimes tracks the lines across renames.

It seems to vary with the use of the --follow flag. I'm wondering if it
should be done in two commits in a single PR... first to do only a rename.
Then secondly to rename all the classes.
On Tue, Jun 23, 2015 at 9:38 AM Advay Mengle<EMAIL_ADDRESS>wrote:

Oh I understand that git keeps track of the content vs. the file, it is
just that in github.com's GUI 'blame' view at least for my own repos it
only sometimes tracks the lines across renames.
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/210#issuecomment-114566014
.

sgtm, and then a single PR to merge both those commits?
we'd violate the always-builds rule, but i think it makes sense

I'll do it a slightly weird way...

Do the git mv, changing only the file names and then commit
From a separate copy, do the rename within the IDE, replace the src/
contents and then make that the second commit

...in many ways I trust the IDE rename better than my own changes. At
least, I'll experiment.
On Tue, Jun 23, 2015 at 1:33 PM Advay Mengle<EMAIL_ADDRESS>wrote:

sgtm, and then a single PR to merge both those commits?
we'd violate the always-builds rule, but i think it makes sense
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/210#issuecomment-114633923
.

Actually this should work fine because it is Groovy.  No rule that the class name == filename right?

Android Studio complains if they're different... and it would make sense
for them to be same.
On Tue, Jun 23, 2015 at 3:35 PM Advay Mengle<EMAIL_ADDRESS>wrote:

Actually this should work fine because it is Groovy. No rule that the
class name == filename right?
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/210#issuecomment-114661275
.

:)  i was agreeing with your steps.  in that doing (1) and committing it seems should build just fine

@brunobowden - please keep the J2objc prefix on the plugin class itself.  Avoids collision with Plugin<>

Agreed.
I won't be able to do this until this evening, along with the
translateXXXpath changes. Please feel free to go ahead with testing if you
think it's worthwhile. I will be including some better testing around the
different tasks.
On Thu, Jun 25, 2015 at 12:20 PM Advay Mengle<EMAIL_ADDRESS>wrote:

@brunobowden https://github.com/brunobowden - please keep the J2objc
prefix on the plugin class itself. Avoids collision with Plugin<>
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/210#issuecomment-115368612
.

@brunobowden - went ahead and did this already because I had other pending work.  See PR


Complex numbers as a field

Basic complex numbers module. I verify the field axioms. Nothing topological.

I don't really understand why the checks have failed. If I can fix this myself, or can help in any other way, let me know.
I've done some basic undergrad-level complex number questions using this module and in particular I can say that I've got it working at my end.

Thanks. I will get to these at some point (I have some major work commitments for the next 6 days and am travelling over the weekend so this might have to wait a week; I trust there's no huge hurry). As you spotted, the commentary was put there just to flag issues I wasn't sure about -- I thought it was worth explicitly flagging them rather than just guessing something (possibly incorrectly) and hoping nobody noticed/cared.

Thanks for these comments.  Term finishes tomorrow and I will get to this soon after.

Of course take your time. For deriving the field structure after the add_comm_group: you can use the new {mul := _ ... , .. complex.add_comm_group } syntax to avoid repeating the elements for the group. (if this was part of the problem?)


[FEATURE] Index Template cleanup

Is your feature request related to a problem?
We're using index templates to maintain mappings on all backing indices of index patterns, aliases and datastreams that users are using as input of detector. We need reliable way to delete unused templates.
What solution would you like?
When monitor is deleted do following:

Fetch all Detectors and compile list of all inputs which are either index pattern, alias or datastream
If template doesn't contain any user defined component templates added to it, and no other detector has input which matches template index pattern: delete component and index template

@petardz Is there any pending AI for this post 2.5?

Closing as completed by #317


feat: refactor multi-geth to core-geth

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Copyright in LICENSE is blank

Copyright [yyyy] [name of copyright owner]
https://github.com/ibm-messaging/mq-docker/blob/master/LICENSE#L190

Good spot, this repo is deprecated but i will make the change to this.
I've checked the new repo and can see the problem is there as well so i've created the following issue:
https://github.com/ibm-messaging/mq-container/issues/61


Browser compatibility

Thanks for the nice library - I'm wondering if there is a way to use it in the browser? I've tried browserify, but got seems not to be compatible. Any suggestions?

Thanks but I'm afraid we cannot use it in the browser. It's by mocking browser request with Node, however, the browser doesn't allow us to add some unsafe headers for the security. We have to run it in a server.

What is the header that is not allowed in the browser (just curious)?

The referer header and user-agent header etc. We can't change it at will in the browser.

Would not replacing got with something like ky-universal, support both node and the browser?

Actually, the referer doesn't matter, cookies don't matter, and the browser's own User Agent is fine. A few tweaks this can totally work inside a browser - but you do have to use a CORS anywhere proxy to get around the SOP. I have it working locally, I'll send a PR soon. You don't even need ky, plain browser fetch is sufficient.


update header files

I am update header files.

update header

For whoever has to deal with these spam pull requests, my sympathies.


[Issue #492] Delete the old dataflow module

This PR is one of the last steps to remove old dataflow module in issue #492 .
All files under the old dataflow module are deleted.

Great.  Yeah!


TypeError if narration index is absent

Currently, a narration index is basically mandatory. Line 203 in bb_import.py causes a TypeError to be thrown because that index is NoneType. Can be fixed by checking for the existence of args.indexes.narration. I will create a pull request.

I also encountered this. @luciano-fiandesio Thanks for this library!

hi @ihinsdale would you be able to send a obfuscated test CSV file, I'm not sure how to reproduce it.


CI/CD uplift

Create deploy hooks so that any push to Master in GitHub triggers a production deployment

Document CICD setup so that other developers can maintain

The card says using github triggers. Is it worth us setting up the CI/CD while we're still doing the development in gitlab?

This is now been implemented and triggers automatically on deployment to main.
It builds and replaces the UI and also restarts the backend.


Pixel-level annotation

Using GeoJS polygon annotations to being with

@aashish24 will provide a dataset to play with

Need to create a mode switching mechanism so I can switch between Bounds and Polygon Modes.
Bounds mode allows you to edit the Rect where as polygon mode allows you to edit the polygon.
This switching of modes should also apply to visibility of rects and polygons for a track.
I like how geoJS does initial polygon drawing, but I need to make sure I don't disable it through the annotation layer by technically clicking on blank space.  Need some way to indicate that the polygon is DONE, and no more points need to be added.  Probably a right click should help with this when in new Polygon mode.
Not a huge fan of how polygons are edited, but It should work for now with the dragging of additional edges.  I'm looking currently into getting some other stuff to properly switch between rect and polygon.

Putting together a TODO in here to list out things I need to to and update to get working properly:

[ ] Create the Editing Mode interface, probably in the NavBar, when you're in edit mode you can choose Rectangle or Polygon
[ ] Modify the styling so that the bounds for a Rect don't look like the polygon at the same time.  The bounds should be faded or dimmer if we are editing a polygon.
[ ] Prevent clicking on other annotations when in creation mode for polygons, they need to have a special mode for themselves
[ ] Subset to the above is to change the editing variable in FrameData from a boolean to string indicating the mode of editing, this can have multiple effects to clean up some complexity.
[ ] Selection in the interface of a polygon or a rect and how it is done.  Do we select only polygons if they are available?
[ ] Add in some sort of Text indicating what is going on in Polygon mode and how to add points and completion of adding points.

Update to the above list:
Created interface for editing/visible.  Not finalized yet because use cases might include options.
So the first Tasks are done:

Added in line and point icons in there right now.  Will most likely remove them in the future.
Boundinb Box is thinner and more transparent when compared with polygon.

Still can edit polygon:

Okay I have the above stuff finished future updates include:

[ ] Need to look into geoJS and figure out deletion of points/selection of points
[ ] Subset of above is to maybe use the new menu system for removing points
[ ] Not sold on the help system I currently build I feel there is a better way to implement it.
[ ] Possible move the markerLayer into the EditLayer as well
[ ] Add in Line editor to create lines

Working on removing points, I believe it has to be done manually through editing the source data and there is no system in place for doing it in GeoJS (At least I can't see anything in the documentation).  I need to be able to select a point of the polygon by clicking on it and then provide the ability to remove that point (by going through the polygon list and removing the index).  So I'm putting some infrastructure to support that.
Corner cases/Notes:
Once you get below 3 points you shouldn't be allowed to remove any more points, because it is no longer a polygon then.
Also make sure you change the selected Index after it is removed if it is the last index in the order it needs to be updated or at least reset to -1 or some default non-existant value.


Can't select a .file from File Open dialog

code-server version: 1.939-vsc1.33.1
OS Version: Docker ubuntu:18.10

Description
Files beginiing with a . aren't visible in the Open File dialog.
Steps to Reproduce
File->Open File...

Was fixed by https://github.com/cdr/code-server/commit/a2ad3d4ff4ae6019627028d6a65ef5f228d5b6f7.


Fix COPY TO with WHERE on primary key

This adds support for shard projection execution using the
PKLookupOperation in order to support actions like COPY TO WHERE pkCol = ? which choose a primary key lookup strategy but also require
shard projections.

retest this please

retest this please

retest this please


Why is Machine invoking super()?

I can see that Machine.__init__() always invokes super().
In my case, where I have multiple inheritance for `Machine, the above code breaks because the base-classes does not know the machine's kwds.
Of course I can workaround it, by inheriting that a base-class just to add a dummy **kwds in its constructor signature. But still i cannot understand why the machine is invoking super's constructor even if it does not have any base class?
I tried to search in the issues if there is a specific reason for this code, and I'm not sure if that was an explicit decision; So was that one?

I just had a quick look at the blame view of core and this is related to #112. It's a feature, not a bug :).


ageing-related accumulation of "lipofuscin" - non-pathological BP?

PMID: 22982048 states
"Cellular aging in general is characterized by a progressive accumulation of nonfunctional cellular components due to oxidative damage and a decline in turnover rates..." and "...abnormal, damaged proteins usually develop aberrant intermolecular interactions resulting in the formation of aggregates. These aggregates can be further oxidized and cross-linked resulting in undegradable lipofuscin [24]. This process is not considered to be pathologic..."
Lipofuscin has been described in PMID:12208347 as "a hallmark of aging" and as "a chemically and morphologically poly- morphous waste material...".
Should we have a term for the BP of [cellular]? ageing-related accumulation of lipofuscin?
GOC:pad

Even though this is described as not pathological it doesn't sound like a "process", (unless the aggregation happens via a process as a way to deal with the toxicity).
I would only add the term if you have a pathway (i.e gene products to annotate) that actively makes the aggregates and they don't just happen as a symptom of damage....

Thanks Val - thinking more about this, because there is no obvious pathway, I'll drop this idea.


Add libxml2

libxml2 is famous xml library and widely used in C world. http://xmlsoft.org/
If we can use libxml2 by vcpkg, many other xml software will be open to vcpkg.

This would depend on libiconv. I may try to create ports for both. @ras0219-msft is that okay?

@ethanhs  We'd happily accept a PR for each of these. Please make them as separate PRs, however, to make it easier to review.

This was added in https://github.com/Microsoft/vcpkg/pull/166.

thanks!


⚠ Samsung has degraded performance

In 2a60b43, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2766 ms

Resolved: Samsung performance has improved in e58174c.


fix renovate configuration behavior and failures

Overview
The Renovate configuration is currently failing. The workflows are causing issues. Renovate should have it's dependencies grouped such that the workflows are fixed and minimal PR's are open.
Additionally, each fix commit would create a new version & thus we want to group these dependencies fixes together as much as possible.

Deleted the dependabot configuration that was there
updated labeler as well while I was there https://github.com/liatrio/liatrio-otel-collector/pull/258
potentially going to create an ADR with a couple things:

update configuration for otel repo to enable renovate to bypass main branch detection for auto merges

working on figuring out how to best update the match managers to ensure compatibility with the make tidy-all functionality that is run as part of the workflows.

updated latest versions of all components
removed automerge from the renovate.json
adjusted the renovate.json to use file match managers

segmented out into compgen, components, tools, actions, and dockerfiles

still noticed that one pr that was open still didn't succeed. Looks like renovate didn't update the packages that needed to be updated alongside through go mod tidy - going to review this with the team

This pull request is an example of a cyclical dependency. Every time we publish a new version of the collector, Renovate is going to create a PR to update this version, which in turn will cause a new version to be created, which will cause a new PR and so forth.
OTEL manages this in two ways.

OTEL has a separate release process that isn't on every commit and is managed by a separate repository.
OTEL leverages the multimod utility to manage versions via the versions.yaml file and publish commits.

Currently my thought process is to simply exclude our own package, ensuring that the replace statement always keeps it up-to-date and not creating a cyclical dependency.

Giving this a couple more days to see if any packages are updated. Will be waiting for v0.93.0 comes out for collector contrib.

Renovate usage has improved some since the last set of changes, but is still subject to failing due to not having run go tidy or make tidy-all.
I tested out adding the postUpdateOptions for renovate but it caused an issue because we're using v1.21 of go instead of the currently supported v1.20.  This is reflective by this renovate comment on one of the PR's it opened.
For now we've reverted this change and will be manually fixing PR's as needed. We will create new tickets per the last TAG sync that evaluates whether or not we want to self-host renovate for this repository and leverage the postUpgradeTasks instead.


Fix count Json representation for Request message

Because count is backed by a UInt, kotlinx.serialization writes negative numbers for big values, resulting in a confusing serialised format.
Example when count == UInt.MAX_VALUE :
{"type": "request", "count": -1, "site": "6e5d4661"}

Not relevant with binary serialisation.


modify the name of the dict transformer to typed dict

Tracking issue

Why are the changes needed?
Modifying the name to "Python Dictionary" requires users to re-register their reference tasks and launch plans, which would otherwise lead to errors such as:
Error 0: Code: MismatchingTypes, Node Id: n4, Description: Variable [o0] (type [union_type:{variants:{simple:STRUCT  structure:{tag:"Typed Dict"}}  variants:{simple:NONE  structure:{tag:"none"}}}]) doesn't match expected type [union_type:{variants:{simple:STRUCT  structure:{tag:"Python Dictionary"}}  variants:{simple:NONE  structure:{tag:"none"}}}].

What changes were proposed in this pull request?
Same as title.

How was this patch tested?

Setup process
Screenshots
Check all the applicable boxes

[ ] I updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] All commits are signed-off.

Related PRs

Docs link

@pingsutw can you +1 again, please?


pull request for e2e test at 11/10/2016 20:56:08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


THEEDGE-1874 switched DB call from Save to Update

previously querying database for full image info to update one column
switched to a gorm Update to only set Status where ID = id
needed to speed up the graceful shutdown at interrupt

Signed-off-by: Jonathan Holloway<EMAIL_ADDRESS>Description
Speeding up the graceful shutdown of image builds with an Update Status vs Save All
Fixes # (issue) THEEDGE-1874
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[x] Refactor

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I run go fmt ./... to check that my code is properly formatted
[x] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #827 (fefe26d) into main (0779479) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   30.85%   30.86%
=======================================
  Files          44       44
  Lines        4923     4922    -1
=======================================
  Hits         1519     1519
+ Misses       3201     3200    -1
  Partials      203      203

Impacted Files
Coverage Δ

pkg/services/images.go
16.02% <0.00%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0779479...fefe26d. Read the comment docs.


fix multi-lines vanishing when exiting edit mode

@bmathews fixes #163
2 issues were present with this bug. Eating of empty lines when exiting edit mode and eating of multi-line list items when exiting out of edit mode.
before--

after--

@rgerstenberger Refactored to use reduce instead of the while loop.

Dependent on a spectacle-editor-viewer release, will :shipit: once that's ready

viewer PR looks good. 👍


[Feature] support pass abortSignal into options

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@himself65 great idea, we are moving the typescript generator to our monorepo and then will move the issue there as well


Time step with predictor velocities

This PR refactors the time-stepping algorithm to use the "predictor velocities" abstraction in the fractional step method. This brings the implemented algorithm in line with the algorithm described in the documentation.

@ali-ramadhan I may need some help with the checkpointer...

I'll have a look

Think I fixed it. At least checkpointer tests pass on my laptop.


Enhance fpt delete

This enhance change the logic of FTP Upload splitting the delete of camera storage after upload as requested in #166

Closed for dirty commit
Reopened as #170


Meta handles leader changes and other errorcodes uniformly

For meta, when the leader changes, it is not handled correctly in most cases, and an incorrect error code is returned. So the leader of the meta was changed, but the meta client received other error codes and did not try again.
This pr uniformly handles the error codes of various operations in meta BaseProcessor and so on.
benefit:

The leader change situation of meta can be processed uniformly .
It also facilitates the unified processing of subsequent errorcodes.

Depend on https://github.com/vesoft-inc/nebula-common/pull/494

Good, just remove all StatusOr in meta...

nice job，massive project.

Conflict again, maybe because there are several reverts these days. You could contact @liuyu85cn if necessary.

test passed, ready to review.


The latest version of comfyui and ComfyUI-N-Sidebar seem to have compatibility problems

The latest version of comfyui and ComfyUI-N-Sidebar seem to have compatibility problems, the N-Sidebar in the upper left corner cannot be displayed properly when clicked on, only ComfyUI-N-Sidebar is installed separately. other plugin conflicts have been ruled out.

Are you sure? Because it works fine for me with the latest version, can you give me a screenshot example?

Are you sure? Because it works fine for me with the latest version, can you give me a screenshot example?

I'm sorry, it was a display problem caused by me accidentally dragging the box around the edge


Feature Request: Hex Editor

Would be hard to add a way to display files in a hex editor manner? Or maybe a way to allow plugins to do something like this?
(would this be contrary to the editor motto?)

I think it is pretty possible to make a plugin to do so. Open a file internally and then write the hex contents to docview. When saving, convert the hex contents of the docview to binary and save.


Map should be downloaded alongside replay

Also should be added for drag and drop.

They are in all cases except a unknown file placed in the directory so this is fixed.


Error Code 500 when Bot has multiple dialogs (POST 500 directline/conversations//activities)

Hello,
I have the issue, that my new bot doesn't want to start properly, when I have multiple dialogs and program the ability to change them. The LUIS itself seems to work fine, so the triggers doesn't seem to be the problem. But when I set the trigger to change to a different dialog, it gives me the error 500 when it starts, even before the welcome message. When I remove the dialog change and just say that it should send a response in that trigger, it works fine again. I've built a different bot, that seems to work just fine with that dialog change with trigger usage.
It gives me this Post message with this JSON in the response:
POST 500 directline/conversations//activities

Thanks in advance, for all who have or try to find a solution to this problem.

Hi @JonasBergholz
Something is likely broken in your bot, likely within the configuration of the Dialog that is causing the different in behavior. What you say the LUIS itself seems to work fine, what do you mean? Are you seeing LuisTrace logs when using the Emulator?

Hi @JonasBergholz
Checking in. Can you please give us more information per Chris's questions?

Hi @JonasBergholz Just touching base once again. Can you please give us some more info? Or is this resolved for you?

Hi @JonasBergholz I'm closing this one as we haven't heard from you in some time and we still need further information to proceed. Please reopen or let us know if you are still having issues and need assistance.

I am also having the same issue, with receiving an error 500 when I start the bot Emulator from Framework Composer.
My bot also has multiple dialogs. My configurations for LUIS and QnA maker appear to be correct. Not sure where to troubleshoot. Any help is greatly appreciated.
Thank you

@df9723 Are you supplying appid/apppassword in either the Bot/Composer or Emulator? If you have them set in the bot/app settings, then they need to be supplied in the Emulator (which should be done by default). Additionally, makes you have the right values in the correct settings, if so. (In settings, MicrosoftAppPassword is listed first, MicrosoftAppId second).
Does this only happen with multiple dialogs? Are you able to share a repo (sanitized of personal/sensitive info) of your bot so that we can attempt to reproduce?

I'm sorry that I didn't answer. Moved on to another project. It is the same
problem that df9723 has. I have checked my settings and I have provided an
AppId and AppPassword. I'm able to publish, but it only works, if I have a
single dialog. Can't share my repo or anything like that.
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virenfrei.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
Am Di., 27. Okt. 2020 um 23:37 Uhr schrieb Dana V<EMAIL_ADDRESS>
:

@df9723 https://github.com/df9723 Are you supplying appid/apppassword
in either the Bot/Composer or Emulator? If you have them set in the bot/app
settings, then they need to be supplied in the Emulator (which should be
done by default). Additionally, makes you have the right values in the
correct settings, if so. (In settings, MicrosoftAppPassword is listed
first, MicrosoftAppId second).
Does this only happen with multiple dialogs? Are you able to share a repo
(sanitized of personal/sensitive info) of your bot so that we can attempt
to reproduce?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/BotFramework-Composer/issues/4159#issuecomment-717581315,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOWVDEXME2MR5LHIQ264BFDSM5DR5ANCNFSM4RPCWYTQ
.

I do have appid/apppassword setup in the Bot/Composer and verified that I am using the correct values setup in the Azure App Registration. Along with multiple dialogs, I am making calls to multiple QnA knowledge bases. Not sure if that would cause an issue. Also unfortunately I am unable to share my bot configuration.  Thanks again for your help.

Hi @JonasBergholz and @df9723
We're going to need a bit more to go on unfortunately. Can you give me explicit and simple instructions on how to reproduce? @df9723 Are you able to share a repo of a reproduction of the issue?
If you can give me the simplest repro steps, that will go a long way to determine what is going on.

Hi dmvtech,
I have attached some details on how we are structuring our bot.
Thanks
500error.pdf

SOLVED: I no longer receive the error 500 message within Emulator, once I removed all routes back to the main dialog from a child dialog and any repeat of the main dialog, while in the main dialog.
Hope this helps.

Ah, thank you @df9723 Yeah, as you have found, you don't want to do that. Assuming your FAQ dialog has Auto end dialog set to true, you shouldn't need to do much else as it will just bubble up to the calling dialog. You could, of course, specifically add an End dialog action in place of where you were calling the Main dialog, but it's not needed if Auto end dialog is set. Optionally, you could also use an if branch and check on a value (like user.foundallaswers or something), and then have your FAQ logic inside that. Lots of options actually.
@JonasBergholz is your logic anything like this above? (are you calling the main dialog from another dialog?)

Hi dmvtech,
Yes I was calling the main dialog from another dialog. To mitigate the issue, I call a hero card with selections. But I appreciate the additional info. I am new to using the Framework Composer.
Thanks again.

@JonasBergholz I'm closing this. If the solution wasn't the same for you, please let us know.


Merge branches

Full functionality - Due to be delivered by 18th Sept'20.
Requirements to be delivered in two weeks (OCC) - 17th July'20
It's for 3++

Produce requirements
Produce model/picture
Guidance and review by Cath and Angela

05/11 - awaiting load with 2 versions of DD for DD team to be able to run realistic tests/informed review.
Split into tickets to do in different Sprints
Oxford to provide a working prototype for DD Team (Cath/Angela) to work/practice

18/01/21 - functionality is in UAT - ready for testing - https://modelcatalogue.cs.ox.ac.uk/nhsd-test
Request Access from James or Cath if needed - and Angela

18/01/21 - functionality is in UAT - ready for testing - https://modelcatalogue.cs.ox.ac.uk/nhsd-test
Request Access from James or Cath if needed - and Angela

Awaiting more than one release to be loaded for testing

Awaiting more than one release to be loaded for testing

@jamesrwelch to make two versions of DD available for @cach1 and @AngelaFaulding to test.

5/5 CC and AF still waiting for content changes to fully test.  Escalate with JW

25/6 - needs MS32 completing before this can be fully tested.

7/1/22 - James hoping to demonstrate on 10/1/22.

Meeting with James 17/1/22.
James to produce documentation to describe this.

James is yet to demonstrate this to the Team.

James is yet to demonstrate this to the Team.

James to Demo on 01/02/2022 - to DD team.

Once James has demonstrated, we can test.

We haven’t tested this yet as we haven’t got any branches to test. We can ask James to merge two old trunks if required. However, that wouldn’t be a full test.

Work Package has been signed off.
We will test when we have branches to merge. Oxford will fix any issues we identify.

Branch creation works but we can't do merges until we can author full CR content.

Branch creation works but we can't do merges until we can author full CR content.

Error produced when trying to merge from main to CR8001 branch under TEST
Server Error
We're sorry, but the server responded with an error message.
Details
{
  "headers": {
    "normalizedNames": {},
    "lazyUpdate": null
  },
  "status": 500,
  "statusText": "OK",
  "url": "https://mauro.dev.dataproducts.nhs.uk/api/versionedFolders/15c1f6ca-a607-4f15-b26a-697b967b8f23/mergeInto/29502b48-5b4e-467b-80a6-762c9014fc14?isLegacy=false",
  "ok": false,
  "name": "HttpErrorResponse",
  "message": "Http failure response for https://mauro.dev.dataproducts.nhs.uk/api/versionedFolders/15c1f6ca-a607-4f15-b26a-697b967b8f23/mergeInto/29502b48-5b4e-467b-80a6-762c9014fc14?isLegacy=false: 500 OK",
  "error": {
    "status": 500,
    "reason": "Internal Server Error",
    "errorCode": "DMSXX",
    "message": "Could not find branched model resource HODF UPDATE TYPE in branch CR8001 - National Hair Colour Data Set Version 1",
    "path": "/api/versionedFolders/15c1f6ca-a607-4f15-b26a-697b967b8f23/mergeInto/29502b48-5b4e-467b-80a6-762c9014fc14",
    "version": "5.4.0-SNAPSHOT",
    "exception": {
      "type": "ApiInternalException",
      "message": "Could not find branched model resource HODF UPDATE TYPE in branch CR8001 - National Hair Colour Data Set Version 1",
      "stacktrace": [
        "uk.ac.ox.softeng.maurodatamapper.datamodel.DataModelService$__tt__updateCopiedCrossModelDataTypeLinks_closure178.doCall(DataModelService.groovy:1586)",
        "uk.ac.ox.softeng.maurodatamapper.datamodel.DataModelService.$tt__updateCopiedCrossModelDataTypeLinks(DataModelService.groovy:1551)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.datamodel.DataModelService.$tt__dataModelService_updateCopiedCrossModelLinks(DataModelService.groovy:1542)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService$__tt__copyModelsInFolder_closure67$_closure78.doCall(FolderService.groovy:507)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService$__tt__copyModelsInFolder_closure67.doCall(FolderService.groovy:482)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService.$tt__copyModelsInFolder(FolderService.groovy:473)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService.$tt__copyFolderContents(FolderService.groovy:445)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService.$tt__copyFolderPass(FolderService.groovy:402)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService.$tt__copyFolder(FolderService.groovy:359)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.FolderService.$tt__copyFolder(FolderService.groovy:346)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.VersionedFolderService.$tt__processCreationPatchOfFolder(VersionedFolderService.groovy:1296)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.VersionedFolderService.$tt__processCreationPatchIntoVersionedFolder(VersionedFolderService.groovy:1121)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.VersionedFolderService$__tt__mergeObjectPatchDataIntoVersionedFolder_closure131.doCall(VersionedFolderService.groovy:1063)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.VersionedFolderService.$tt__mergeObjectPatchDataIntoVersionedFolder(VersionedFolderService.groovy:1053)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "uk.ac.ox.softeng.maurodatamapper.core.container.VersionedFolderController.$tt__mergeInto(VersionedFolderController.groovy:397)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "grails.gorm.transactions.GrailsTransactionTemplate$2.doInTransaction(GrailsTransactionTemplate.groovy:94)",
        "org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)",
        "grails.gorm.transactions.GrailsTransactionTemplate.execute(GrailsTransactionTemplate.groovy:91)",
        "org.grails.core.DefaultGrailsControllerClass$MethodHandleInvoker.invoke(DefaultGrailsControllerClass.java:223)",
        "org.grails.core.DefaultGrailsControllerClass.invoke(DefaultGrailsControllerClass.java:188)",
        "org.grails.web.mapping.mvc.UrlMappingsInfoHandlerAdapter.handle(UrlMappingsInfoHandlerAdapter.groovy:90)",
        "org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1071)",
        "org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:964)",
        "org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)",
        "org.springframework.web.servlet.FrameworkServlet.doPut(FrameworkServlet.java:920)",
        "org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)",
        "org.grails.web.servlet.mvc.GrailsWebRequestFilter.doFilterInternal(GrailsWebRequestFilter.java:77)",
        "org.grails.web.filters.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:67)",
        "org.springframework.boot.web.servlet.support.ErrorPageFilter.doFilter(ErrorPageFilter.java:126)",
        "org.springframework.boot.web.servlet.support.ErrorPageFilter.access$000(ErrorPageFilter.java:64)",
        "org.springframework.boot.web.servlet.support.ErrorPageFilter$1.doFilterInternal(ErrorPageFilter.java:101)",
        "org.springframework.boot.web.servlet.support.ErrorPageFilter.doFilter(ErrorPageFilter.java:119)"
      ]
    }
  }
}

@jamesrwelch - Peter tried to incorporate and merge a branch today and both failed. The content above is for the failed merge.
Peter will talk to you about this as he says it is core Mauro and therefore is an Oxford issue.
This was supposed to be working as part of the first stage of the project but we never had enough content to test.

15/10/24 - James will investigate.

@jamesrwelch - I am trying to start the Wiki for this as it is so long ago since Peter kept tying this.
I tried to accept changes from branch and it didn't work. Nothing happened.

But when I tried to accept changes from the main release it appeared to work and everything moved from the Changes tab to the Committing tab:

When this is fixed, could you go through merge and incorporation with us please? I certainly got confused as Peter didn't understand the difference between a merge and an incorporation for us.

@jamesrwelch - I hope you don't mind but I will put questions here which may help when you look to fix this. It will help us later.
If all changes have been moved to the Committing tab, can a single change be moved back as the only option is Cancel All:


HDDS-1624 : Refactor operations inside the bucket lock in OM key write.

There are a few steps that are done inside the OM bucket lock that are lock invariant and can be done outside the lock. This patch refactors those steps. It also adds an isExist API in the metadata store so that we dont need to deserialize the byte[] to Object while doing a simple table.get(key) != null check.
On applying the patch, the OM + SCM (With dummy datanodes) write performance improves by around 3x.
Thanks to @nandakumar131  who helped with this patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
539
trunk passed

+1
compile
281
trunk passed

+1
checkstyle
77
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
917
branch has no errors when building and testing our client artifacts.

+1
javadoc
168
trunk passed

0
spotbugs
336
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
523
trunk passed

_ Patch Compile Tests _

0
mvndep
29
Maven dependency ordering for patch

+1
mvninstall
492
the patch passed

+1
compile
291
the patch passed

+1
javac
291
the patch passed

-0
checkstyle
40
hadoop-hdds: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-0
checkstyle
43
hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
739
patch has no errors when building and testing our client artifacts.

+1
javadoc
183
the patch passed

+1
findbugs
733
the patch passed

_ Other Tests _

-1
unit
239
hadoop-hdds in the patch failed.

-1
unit
1776
hadoop-ozone in the patch failed.

+1
asflicense
83
The patch does not generate ASF License warnings.

7412

Reason
Tests

Failed junit tests
hadoop.hdds.scm.container.TestReplicationManager

hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics

hadoop.ozone.TestMiniChaosOzoneCluster

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.scm.TestAllocateContainer

hadoop.ozone.scm.TestXceiverClientManager

hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/882

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a4eeedf5e44a 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4cb559e

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/diff-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/testReport/

Max. process+thread count
5196 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/label ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
595
trunk passed

+1
compile
281
trunk passed

+1
checkstyle
73
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
846
branch has no errors when building and testing our client artifacts.

+1
javadoc
175
trunk passed

0
spotbugs
326
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
515
trunk passed

_ Patch Compile Tests _

0
mvndep
36
Maven dependency ordering for patch

+1
mvninstall
502
the patch passed

+1
compile
303
the patch passed

+1
javac
303
the patch passed

+1
checkstyle
96
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
677
patch has no errors when building and testing our client artifacts.

+1
javadoc
153
the patch passed

+1
findbugs
518
the patch passed

_ Other Tests _

+1
unit
236
hadoop-hdds in the patch passed.

-1
unit
1182
hadoop-ozone in the patch failed.

+1
asflicense
56
The patch does not generate ASF License warnings.

6494

Reason
Tests

Failed junit tests
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-882/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/882

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 38b20a6fb63b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c1d2d92

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/2/testReport/

Max. process+thread count
5276 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

cc @bharatviswa504

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
34
Maven dependency ordering for branch

+1
mvninstall
550
trunk passed

+1
compile
301
trunk passed

+1
checkstyle
83
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
884
branch has no errors when building and testing our client artifacts.

+1
javadoc
166
trunk passed

0
spotbugs
348
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
544
trunk passed

_ Patch Compile Tests _

0
mvndep
62
Maven dependency ordering for patch

+1
mvninstall
493
the patch passed

+1
compile
286
the patch passed

+1
javac
286
the patch passed

+1
checkstyle
73
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
635
patch has no errors when building and testing our client artifacts.

+1
javadoc
155
the patch passed

+1
findbugs
536
the patch passed

_ Other Tests _

+1
unit
235
hadoop-hdds in the patch passed.

-1
unit
1297
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6602

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/882

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2d5973154278 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 97607f3

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/testReport/

Max. process+thread count
4452 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Hey @avijayanhwx
There is a test failure in ITestOzoneContractGetFileStatus. Could you once check if it is related to this change?

Test failed due to SCM start failure. Not related to this change.
I will commit this.


[Java] object deep copy into different type

Feature Request
We've supported object deep copy of object from one instance to another instance, but we still don't support deep copy object from one type into another type.
Is your feature request related to a problem? Please describe
deep copy object from one type into another type:
class Struct1 {
  int f1;
  String f2;

  public Struct1(int f1, String f2) {
    this.f1 = f1;
    this.f2 = f2;
  }
}

class Struct2 {
  int f1;
  String f2;
  double f3;
}

Struct1 s1 = xxx;
Struct2 struct2 = copyTo(s1, Struct2.class)

Describe the solution you'd like
Extend the current object deep copy mechanism
Describe alternatives you've considered
Mock by:
public class StructMappingExample {
  static class Struct1 {
    int f1;
    String f2;

    public Struct1(int f1, String f2) {
      this.f1 = f1;
      this.f2 = f2;
    }
  }

  static class Struct2 {
    int f1;
    String f2;
    double f3;
  }

  static ThreadSafeFury fury1 = Fury.builder()
    .withCompatibleMode(CompatibleMode.COMPATIBLE).buildThreadSafeFury();
  static ThreadSafeFury fury2 = Fury.builder()
    .withCompatibleMode(CompatibleMode.COMPATIBLE).buildThreadSafeFury();

  static {
    fury1.register(Struct1.class);
    fury2.register(Struct2.class);
  }

  public static void main(String[] args) {
    Struct1 struct1 = new Struct1(10, "abc");
    Struct2 struct2 = (Struct2) fury2.deserialize(fury1.serialize(struct1));
    Assert.assertEquals(struct2.f1, struct1.f1);
    Assert.assertEquals(struct2.f2, struct1.f2);
    struct1 = (Struct1) fury1.deserialize(fury2.serialize(struct2));
    Assert.assertEquals(struct1.f1, struct2.f1);
    Assert.assertEquals(struct1.f2, struct2.f2);
  }
}

This will work, but not that efficient cause it will write/read buffer.
Additional context
https://github.com/apache/fury/discussions/1973
https://github.com/apache/fury/pull/1974

Hi @zhaommmmomo , would you like to take over this issue?


Update lodash

@lucaong Please check.
Changelog can be found here

Merge, new lodash --> awesomeness :)

:+1:


Let the component "palette" be optional too

Almost all components are optionals, but not the palette itself.
For some use cases, we need to let users choose colors ONLY from suggestions, so from swatches.
If the "palette" is also a component, with true or false, we will be able to have either

only the palette
or the palette and swatches
or only swatches

And so Pickr will really takes in account all cases possible! :smiley:
(I will try to look at the code, but I absolutely don't know webpack and all the thousand of tools needed, so I'm not sure I'm going to succeed. :smile: )

Hey, no problem :) But fantastic idea, will be added in the next days 😃

Glad, thanks!

Added here: 8042007b53e82d7fc365f6c9d21cff767aa585cc
Because otherwise there would be enorm backward-compatibility issues palette will automatically set to true if either preview, opacity or hue are true. It wouldn't make sense to set preview to true without palette so yeah :)

Thanks, it works very well and it's perfect!
(for the detail: for accessibility we apply the pickr either on an text input if the user can choose any value, or on a select list if values are limited. Pickr replace that first real field by a button if JS is here, and we save the value in a hidden. But if no JS, that's always ok, even if limited values.)


[Aspire] Names vary across layers

What we doc as the orchestrator is called the "AppHost" in the project name and the "AspireHost" in msbuild.
What we doc as configuration (I think) is called "ServiceDefaults" in the project name and "AspireSharedProject" in msbuild.

I don't think we call out anything specific to MSBuild in the docs, could you please find a link to where we're doing that?

We show project file segments with property names IsAspireHost and IsAspireSharedProject.

Right, ok. I think those are fine - it's only in two places and it's explaining the XML. Outside that, we are consistent. Changing those properties would be a product concern, not docs. I'll close this.


Fix encoding of german examination strings

"name": "Therapeutischer Ultraschall von Gef��en von Kopf und Hals",

Hopefully fixed by changing csv to UTF-8.

Fixed :rose:


Cannot use service labels .?

Hi,
Impressive plugin.
Can you clarify this
Cannot use service labels
I normally attach traefik labels under deploy of a compose file for swarm.
These hold the domain name and service port etc. these are still supported right ?

When a service is scaled to zero, the labels are not registered anymore. The route is no longer reachable and thus the plugin cannot be triggered.
The only way to scale to zero is to have the configuration under the file provider. Which is now independant from the service's lifecycle. It can be scaled to zero, the route will still be triggered.
So you cannot use the labels on your docker-compose file because of this. Is this the answer you expected ?

Ok thanks @acouvreur . Yes this is the answer i was expecting, I just wanted to confirm it.

You can actually use - traefik.docker.lbswarm=true.
If you do not use the swarm load balancer, traefik will evict the service from its pool as soon as the service is 0/0. If you do not set that, fallback to dynamic-config.yml file usage.


[BUG] If the description field for a Tool is too long, it breaks

I receive this error when putting in a long descriptive description in the new tool widget:
There was an error loading the langchain_object. Please, check all the nodes and try again.

i will check this, but I think its's caused by other thing than the long description

I'm noticing this even when I simply try to add a memory buffer, as well as whenever I try to use Python functions.

Same problem

Could you please test again in the last version v0.0.56, and let us know if you still find this error? If yes, please post an image of the flow or JSON here.
I will close it for now because there was a bug with the tools in one of the versions, please reopen it if the error persists.


Fix remaining links + add webpack example

fix links I did not notice in the last PR.
adds simple webpack example since there are 4 browserify examples.

Could you split this into 2 PRs?

@phated reduced to one commit with just the link changes

Thanks again @stevelacy


Added pipeline aggregations.

Codecov Report

Merging #8 into master will increase coverage by 0.62%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     85.05%   85.68%   +0.62%
- Complexity      321      322       +1
============================================
  Files            22       23       +1
  Lines           870      873       +3
============================================
+ Hits            740      748       +8
+ Misses          130      125       -5

Impacted Files
Coverage Δ
Complexity Δ

src/Business/Dsl/Aggregation/Pipeline.php
100% <100%> (ø)
1 <1> (?)

src/Business/Dsl/Aggregation.php
100% <0%> (+22.72%)
7% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ca5e7...2b659a0. Read the comment docs.


Provide direct rendering API

It's all well and good having an animated scene, but wouldn't it be nice to provide a clean way to get a still image that could be re-used elsewhere.
Options could range from just a simple ASCII string from a renderer to a full colour coded image suitable for display in the current terminal.

Currently limited to simple ASCII rendering. Full colour will require Screen to expose a colour aware version of print.


Create deploy-staging.yml

Fixes #24
Describe the changes you have made in this PR -
Added deploy-staging.yml

Resolved in latest commit :eye:


Update Live and Test URLs as per Opayo requirements

From Opayo:

The URLs you use to send transactions to Opayo will be changing to an Elavon domain and you need to make the changes to
send your transactions to the updated URLs.
These changes must be made by 31st March 2024, this is when the SagePay URLs will cease to work.
We've already added these updated URL's to our Developer Hub to help you make the changes, you can find the URLs specific to your integration below:
...
Direct integration
Form integration
Server integration
...

Thank you, this will reduce the worry of a lot of people.
That typo in the tests inplies the tests aren't running on PRs, so I guess that needs looking at too.

My bad, I didn't run phpunit. Running it flagged the typo, which I have fixed and merged with my previous commit.
However, for me phpunit is spewing lots of warnings and notices to the console and failing:
PHP 8.1:
FAILURES!
Tests: 290, Assertions: 952, Failures: 2.
PHP 8.2:
FAILURES!
Tests: 290, Assertions: 952, Failures: 5.

Those tests should have run automatically on commit, so that's something for me to look at.
The codebase is still largely from the PHP 7.4 days, so needs a good upgrade (I'd love to rewrite it all from scratch with a PHP 8.1 minimum TBH). The latest OmniPay core requires ^7.2|^8.0, which is positively ancient. There will be a few places where we can add some attributes to to suppress the PHP deprecation warnings and PHP 8.2 deprecation errors. That will buy some time, but I think a major version update is needed to move to a PHP8.1 minimum, but suspect there will still be some older sites that may need the older branch maintained. Not sure how many though.

If you let me know how you'd prefer to handle the potential for NULLs I may be able to submit a PR
E.g.
strtolower((string) $this->httpRequest->request->get('VPSSignature'));
or
strtolower($this->httpRequest->request->get('VPSSignature') ?? '');
etc.
Regarding dynamic properties, I believe we can opt-in to this (even at PHP 9) by adding #[\AllowDynamicProperties] to the affected class(es). Again, I can open a PR. I think that's all it is complaining about.

I think any dynamic prpperties are an oversight, and probably need to be added explicitly. Might as well move the right direction.
I think the null coalescing operator approach feels right. The reason is that it is accepting either a string or a null, but no other data types to spring surprises. But that could be an argument for always casting to a string. I'm leaning towards ?? but it's your call.

Dynamic properties are only affecting the TestCase class and extended classes it seems.

I think any dynamic prpperties are an oversight, and probably need to be added explicitly. Might as well move the right direction.
I think the null coalescing operator approach feels right. The reason is that it is accepting either a string or a null, but no other data types to spring surprises. But that could be an argument for always casting to a string. I'm leaning towards ?? but it's your call.

PR submitted

git push/pull seems to be down for me at the moment. I'll come back to this later, but looks good - thank you.

Hi Jamie, I've merged everything into master, with some additional fixes to remove a few other deprecation errors.

The tests run for me on PHP 8.0 and 8.2. I'm guessing if it works on those, then PHP 8.1 will work - but correct me if I'm wrong there.
Not tried PHP 7.4, but that should work. If anything, the utf8_decode replacement may be the thing that fails there? But not sure.
I've not tried it against test Sage Pay (Opayo now, I guess) yet.

Would you like to give dev-master a go, testing, Opayo test account, whatever you have?

Hi Jamie, I've merged everything into master, with some additional fixes to remove a few other deprecation errors.

The tests run for me on PHP 8.0 and 8.2. I'm guessing if it works on those, then PHP 8.1 will work - but correct me if I'm wrong there.
Not tried PHP 7.4, but that should work. If anything, the utf8_decode replacement may be the thing that fails there? But not sure.
I've not tried it against test Sage Pay (Opayo now, I guess) yet.

Would you like to give dev-master a go, testing, Opayo test account, whatever you have?

Excellent. mb_convert_encoding has been around since PHP4 (who knew?!) so that should be a compatible replacement.
I can test against a sandbox/test account next week. If that works, I'll happily push it to a project using live credentials.

Excellent, if I get a chance to try it out on yhe test account soon I will. Really busy until Wednesday though, so maybe later in the week.

@judgej I successfully put through a test transaction using the master branch code against a sandbox account. This was using the SagePay\Server gateway. Also tested an ABORT which worked.

Excellent, great work Jamie. I'll get to tagging this soon - will run it through some older apps I have running first, for beld and braces. I'm trying to keep legacy sites working on the current 4.x branch, then maybe got for a higher PHP version for 5.x while providing some support still for 4.x
Or maybe start again with an Opayo driver.

Excellent, great work Jamie. I'll get to tagging this soon - will run it through some older apps I have running first, for beld and braces. I'm trying to keep legacy sites working on the current 4.x branch, then maybe got for a higher PHP version for 5.x while providing some support still for 4.x
Or maybe start again with an Opayo driver.

Apart from encouraging people to use newer versions of PHP, I don't think the current codebase requires PHP 8+?

Hey @jamieburchell do you know where I can find the docuemntation for the new URLs? Elavon seem to have broken all the old links and dumped a bunch of documentation (or hidden it really well). All the above links - for me at least - just redirect to the Elaovon developert home page. The API spec for Pi can be found there, but the OpenAPI spec still points to sagepay URLs.

Hey @jamieburchell do you know where I can find the docuemntation for the new URLs? Elavon seem to have broken all the old links and dumped a bunch of documentation (or hidden it really well). All the above links - for me at least - just redirect to the Elaovon developert home page. The API spec for Pi can be found there, but the OpenAPI spec still points to sagepay URLs.

As you say, all of the links in the email we received informing us of the update (copied above) are redirecting to https://developer.elavon.com/. I can only assume that's a (embarrassing) mistake on their part.

@judgej
Think I found them under "Legacy APIs" in the top menu under "API Docs"
https://developer.elavon.com/products/opayo-forms/v1/form-documentation
https://developer.elavon.com/products/opayo-server/v1
https://developer.elavon.com/products/opayo-shared-api/v1
https://developer.elavon.com/products/opayo-direct/v1
So, they are legacy APIs now?!

Yeah, just spoke to the helpdesk and they pionted me there. They confirmed just change "sagepay" to "opayo" in the URLs and it should work. Also confirmed that the old pages that listed the URLs (and that they sent oiut thousands of emails for) has gone for now, but should be back in the near future. Thanks.
Just found test and live URLs for form: https://developer.elavon.com/products/opayo-forms/v1/test-and-live-urls-4633 and common https://developer.elavon.com/products/opayo-shared-api/v1/urls-4714 Those numbers on the end seem a little "temporary" so expect those URLs to die at some point.
The Pi API is under the new pages and not under legacy, and no URLs are mentions there at all.

the old pages that listed the URLs (and that they sent oiut thousands of emails for) has gone for now, but should be back in the near future.

Wow. That's pretty terrible isn't it.

But honestly, not putting redirects in when the documentation is being updated is the height of laziness.

Absolutely.

just change "sagepay" to "opayo" in the URLs and it should work

That's not quite true - "test" has become "sandbox" and the domain is now opayo.eu.elavon.com but yeah.


fix(security): update dependency versions

should reduce vulnerabilities found by snyk:
https://snyk.io/test/npm/changelog/1.4.1

@holvonixAdvay sorry I missed this originally. Closing as no longer in use or some other reason?

yeah we stopped using this (via github-changes) - just cleaning up my PRs.
check out @dependabot - does it for you :)

@holvonixAdvay also check out https://github.com/renovateapp/renovate :)
I don’t own this repo so haven’t enabled it here.


Research (Samantha) - Python Automated Code Transformations

As a member of the team, I need to learn how to automate editing Python code via Syntax Trees
by watching a formal presentation on the topic
so that I can work on implementing ASTs and automating code changing in Python during Sprint 2.
Source:
Joe Gordon - Syntax Trees and Python - Automated Code Transformations - PyCon 2019
https://youtu.be/viNzD1zD-Fg?si=laeu8L7QwquqldeT

Research Notes:

Compared to RegEx, which can be hindered by things like empty spaces, a Syntax Tree blocking out the program allows for managing complex implementations.
Multi-line transformations are easier with ASTs and Concrete Syntax Trees.
Went over Python Bowler which works for refactoring python code at the syntax level.


Setup instruction is out-dated

Change the example code from
<com.quickbirdstudios.survey_kit.public_api.survey.SurveyView
    android:id="@+id/survey_view"
    android:layout_width="match_parent"
    android:layout_height="match_parent" />

To
<com.quickbirdstudios.surveykit.survey.SurveyView
    android:id="@+id/survey_view"
    android:layout_width="match_parent"
    android:layout_height="match_parent" />

Otherwise a runtime error is thrown
[...] Caused by: android.view.InflateException: Binary XML file line #8: Error inflating class com.quickbirdstudios.survey_kit.public_api.survey.SurveyView [...]

Thank you very much for reporting this!
Adjusted ✅


cmake.buildDirectory not used

Discussed in https://github.com/microsoft/vscode-cmake-tools/discussions/4053

Originally posted by bradenmcd September  9, 2024
Why might the value for cmake.buildDirectory not be used?
The entirety of my user settings.json is this:
{
    "window.autoDetectColorScheme": true,
    "cmake.showOptionsMovedNotification": false,
    "cmake.pinnedCommands": [
        "workbench.action.tasks.configureTaskRunner",
        "workbench.action.tasks.runTask"
    ],
    "cmake.buildDirectory": "${userHome}/build/${workspaceRootFolderName}"
}

There is no project-specific settings.json (i.e., no .vscode directory for the project); yet, the cmake command line that VS Code executes looks like this:
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -DCMAKE_BUILD_TYPE=RelWithDebInfo -SC:/Users/Braden/OneDrive/Source/Repos/hello-cpp -BC:/Users/Braden/OneDrive/Source/Repos/hello-cpp/out/build/windows-x64-v143-RelWithDebInfo -G Ninja

Why might the cmake.buildDirectory setting not be picked up?
I'm using version 1.19.51 of the CMake Tools.

Hi @bradenmcd , based on the information you provided, we are unable to reproduce your issue, you can get the reproduction steps below, please let us know if there is any error, thank you!
ENV:
VSCode: 1.93.1
CMake tools version: V1.91.51
C/C++ version: V1.22.4
Repro steps:

Open this folder Test.zip with VSCode
Click F1 to run command "CMake: configure"
Check that the build directory is correctly using the path specified in cmake.buildDirectory

Actual result:
The settings.json setting is valid, and CMake uses C:/Users/v-cathyzhang/build/New as the build directory
Output info:
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\IntPreview\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.EXE" --version
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\IntPreview\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.EXE" -E capabilities
[kit] Successfully loaded 16 kits from C:\Users\v-cathyzhang\AppData\Local\CMakeTools\cmake-tools-kits.json
[variant] Loaded new set of variants
[cmakefileapi-driver] Removing C:/Users/v-cathyzhang/build/New/CMakeCache.txt
[main] Configuring project: New
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\IntPreview\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.EXE" -DCMAKE_BUILD_TYPE:STRING=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE --no-warn-unused-cli -SC:/Users/v-cathyzhang/Desktop/New -BC:/Users/v-cathyzhang/build/New
[cmake] Not searching for unused variables given on the command line.
[cmake] -- Building for: Visual Studio 17 2022
[cmake] -- Selecting Windows SDK version 10.0.26100.0 to target Windows 10.0.22631.
[cmake] -- The C compiler identification is MSVC 19.42.34321.1
[cmake] -- The CXX compiler identification is MSVC 19.42.34321.1
[cmake] -- Detecting C compiler ABI info
[cmake] -- Detecting C compiler ABI info - done
[cmake] -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/IntPreview/VC/Tools/MSVC/14.42.34321/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting C compile features
[cmake] -- Detecting C compile features - done
[cmake] -- Detecting CXX compiler ABI info
[cmake] -- Detecting CXX compiler ABI info - done
[cmake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/IntPreview/VC/Tools/MSVC/14.42.34321/bin/Hostx64/x64/cl.exe - skipped
[cmake] -- Detecting CXX compile features
[cmake] -- Detecting CXX compile features - done
[cmake] -- Configuring done (5.4s)
[cmake] -- Generating done (0.1s)
[cmake] -- Build files have been written to: C:/Users/v-cathyzhang/build/New

@bradenmcd We tried to reproduce the program based on the information you provided, but we can't reproduce it, here are the steps we took to reproduce it, can you give some suggestions?
ENV：
CMake Tools: v1.19.52
vscode: v1.93.1
c/c++: v1.21.6
Repro steps：

Create a folder and open it with vscode
Add a file named main.cpp and add the Add a file named CMakeLists.txt and add the following code:

#include "iostream"
using  namespace std;

int main()
{
    cout<< "helloworld"<<endl;
    return 0;
}

Add a file named CMakeLists.txt and add the following code:

cmake_minimum_required(VERSION 3.5.0)
project(Helloworld)
add_executable(Helloworld main.cpp)

3.Set in the settings.json file:"cmake.buildDirectory": "${userHome}/build/${workspaceRootFolderName}"
4.Run command: CMake: "configure"
5. Run command: CMake: "Build"
Actual result:

I think the problem may be triggered by the addition of a CMakePresets.json.
Consider the attached one.
CMakePresets.json
If I add this file, initially things work fine.
But if I shut down VSCode and restart it, I see the following in the output window when trying to configure:
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" --version
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -E capabilities
[kit] Successfully loaded 4 kits from C:\Users\Braden\AppData\Local\CMakeTools\cmake-tools-kits.json
[presetController] Reading and validating the presets "file C:\Users\Braden\OneDrive\Source\Repos\vscode-cmake-tools-4083-test\CMakePresets.json"
[presetController] Successfully validated C:\Users\Braden\OneDrive\Source\Repos\vscode-cmake-tools-4083-test\CMakePresets.json against presets schema
[presetController] Expanding presets file C:\Users\Braden\OneDrive\Source\Repos\vscode-cmake-tools-4083-test\CMakePresets.json
[presetController] Successfully expanded presets file C:\Users\Braden\OneDrive\Source\Repos\vscode-cmake-tools-4083-test\CMakePresets.json
[main] Configuring project: vscode-cmake-tools-4083-test
[proc] Executing command: "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -DCMAKE_BUILD_TYPE=RelWithDebInfo -SC:/Users/Braden/OneDrive/Source/Repos/vscode-cmake-tools-4083-test -BC:/Users/Braden/OneDrive/Source/Repos/vscode-cmake-tools-4083-test/out/build/windows-x64-v143-RelWithDebInfo -G Ninja
[cmake] CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
[cmake] CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
[cmake] CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
[cmake] -- Configuring incomplete, errors occurred!
[proc] The command: "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -DCMAKE_BUILD_TYPE=RelWithDebInfo -SC:/Users/Braden/OneDrive/Source/Repos/vscode-cmake-tools-4083-test -BC:/Users/Braden/OneDrive/Source/Repos/vscode-cmake-tools-4083-test/out/build/windows-x64-v143-RelWithDebInfo -G Ninja exited with code: 1

@bradenmcd @gcampbell-msft We reproduced the issue using a simple project that doesn't reproduce when I don't add CMakePresets.json, and reproduces the issue when I add CMakePresets.json:
ENV：
CMake Tools: v1.19.52
vscode: v1.93.1
c/c++: v1.21.6
Repro steps：

Create a folder and open it with vscode
Add a file named main.cpp and add the following code:

#include "iostream"
using  namespace std;

int main()
{
    cout<< "helloworld"<<endl;
    return 0;
}

Add a file named CMakeLists.txt and add the following code:

cmake_minimum_required(VERSION 3.5.0)
project(Helloworld)
add_executable(Helloworld main.cpp)

Add a file named CMakePresets.json and add the following code:

{
    "version": 3,
    "cmakeMinimumRequired": {
      "major": 3,
      "minor": 21,
      "patch": 0
    },
    "configurePresets": [
      {
        "name": "windows",
        "hidden": true,
        "generator": "Ninja",
        "condition": {
          "type": "equals",
          "lhs": "${hostSystemName}",
          "rhs": "Windows"
        }
      },
      {
        "name": "windows-x64",
        "inherits": "windows",
        "hidden": true,
        "architecture": {
          "value": "x64",
          "strategy": "external"
        }
      },
      {
        "name": "windows-x64-v143",
        "inherits": "windows-x64",
        "hidden": true,
        "toolset": {
          "value": "v143",
          "strategy": "external"
        }
      },
      {
        "name": "windows-x64-v143-RelWithDebInfo",
        "inherits": "windows-x64-v143",
        "cacheVariables": {
          "CMAKE_BUILD_TYPE": "RelWithDebInfo"
        }
      },
      {
        "name": "windows-x64-v143-Debug",
        "inherits": "windows-x64-v143",
        "cacheVariables": {
          "CMAKE_BUILD_TYPE": "Debug"
        }
      }
    ],
    "buildPresets": [
      {
        "name": "windows-x64-v143-RelWithDebInfo",
        "configurePreset": "windows-x64-v143-RelWithDebInfo"
      },
      {
        "name": "windows-x64-v143-Debug",
        "configurePreset": "windows-x64-v143-Debug"
      }
    ]
  }

Set in the settings.json file:"cmake.buildDirectory": "${userHome}/build/${workspaceRootFolderName}"
Reopen project.
Run command: CMake: "configure"
Select "windows-x64-v143-RelWithDebInfo"
Run command: CMake: "Build"

Don't add CMakePreset.json：

Add CMakePreset.json：

@v-frankwang There is an additional issue here that you seem not to have reproduced; but, for me, is also triggered by the addition of the CMakePresets.json: while CMake Tools finds the cmake.exe included with VS2022 just fine, it seems not to find the similarly included ninja.exe. Note that I have neither cmake.exe nor ninja.exe in the system PATH; nor have I set cmake.cmakePath.
However, if there is no CMakePresets.json, the CMake Tools seem to find both cmake.exe and ninja.exe just fine.

@bradenmcd For this problem :xx, its because your compiler and generator are installed by installing visual studio, so you should use Developer Command Prompt for VS to open vscode and this problem will be solved! Below is my demo recording:

@v-frankwang I understand why that works.
But VSCode CMake Tools' behavior here still seems broken.

It doesn't make sense to me that VSCode CMake Tools would be able to find the cmake.exe that Visual Studio installs (when it is not in the PATH), yet unable to find ninja.exe under the same parameters.
Your own example (initially offered here) demonstrates VSCode CMake Tools finding both cmake.exe and ninja.exe from the Visual Studio installation; so, the failure to find ninja.exe appears to be something else triggered by the addition of CMakePresets.json.

@bradenmcd To make this easier you can use the setting cmake.useVsDeveloperEnvironment. This setting defaults to auto, which only tries to add the PATHs you're mentioning if it can find the VS environment, and also based on what compiler you're using. To turn this on by default, you can change the setting to always.
If you enable this setting, does this resolve your issue?

@gcampbell-msft Changing cmake.useVsDeveloperEnvironment to always does allow ninja.exe to be found. But, based on your description here, it seems like auto should be working this way, too.

@bradenmcd Great! However, auto will only work if you have a certain compiler defined using your CMake cache variables AND it's not found on the system, and therefore we look for it.
You can see the code here: https://github.com/microsoft/vscode-cmake-tools/blob/9b6e016e726acecd19272ded2f1c211fcfeeb1c7/src/preset.ts#L1094

@bradenmcd Following up again, the original issue is expected, as the cmake.buildDirectory is not used when Presets are used. Instead, the settings of the presets are used. With the above comments and this information in mind, I believe this issue is resolved as expected behavior, so I'll close the issue as such.
Please feel free to ping me here if there is information that is still missing or if you believe this issue shouldn't be closed. Thanks!

@gcampbell-msft

However, auto will only work if you have a certain compiler defined using your CMake cache variables AND it's not found on the system, and therefore we look for it.

Backing up a bit, it seems intuitive to me that if CMake Tools is able to find the cmake.exe that Visual Studio installed, it should also be able to find the ninja.exe without further assistance. I understand your explanation that this is not currently the case; but why shouldn't it be the case?
Regarding the original issue, note that in this case CMakePresets.json does not define binaryDir. In this case, rather than using the value defined for cmake.buildDirectory, CMake Tools seems to use the (baked-in) default value for cmake.buildDirectory. I understand this isn't an out-of-spec choice; it's just not the most intuitive one.

Backing up a bit, it seems intuitive to me that if CMake Tools is able to find the cmake.exe that Visual Studio installed, it should also be able to find the ninja.exe without further assistance. I understand your explanation that this is not currently the case; but why shouldn't it be the case?

I would actually agree with this. Looking at the code, assuming it didn't find Ninja, when using the auto setting and we detect that we should use the auto setting, it should look for both, assuming we don't find Ninja. If this is something that you're experiencing, please open an issue!

Regarding the original issue, note that in this case CMakePresets.json does not define binaryDir. In this case, rather than using the value defined for cmake.buildDirectory, CMake Tools seems to use the (baked-in) default value for cmake.buildDirectory. I understand this isn't an out-of-spec choice; it's just not the most intuitive one.

Thanks for the feedback. Just for some additional context, after Presets v3 binaryDir isn't required and it defaults to a value, so we are attempting to follow that design.


Enhance README for Better Clarity and Usability

The current README file can be improved for better understanding and usage of the repository. Here are a few suggestions:

Add Project Logo or Banner
Add a project logo or banner at the top of the README to enhance its appearance and create a strong visual identity.

Add a Prerequisites Section
Add a section before installation instructions that lists prerequisites like Python version, Streamlit, and any other dependencies needed for setting up the project.

Add Environment Setup Instructions
Add instructions to create and activate a virtual environment before installing the dependencies, to help avoid conflicts with system-level packages.

Expand Dataset Section
Provide more details about the structure of the dataset, and instructions on how users can extend it or modify it for their needs. A table explaining the dataset features would be helpful.

Add How to Contribute Steps
Provide step-by-step instructions for contributors on how to fork the repository, create a branch, make changes, and submit a pull request.

Add Usage Examples with Screenshots or GIFs
Include examples of the application in action, with screenshots or GIFs, to make it easier for users to understand how the project works.

The current README file can be improved for better understanding and usage of the repository. Here are a few suggestions:

Add Project Logo or Banner
Add a project logo or banner at the top of the README to enhance its appearance and create a strong visual identity.
Add a Prerequisites Section
Add a section before installation instructions that lists prerequisites like Python version, Streamlit, and any other dependencies needed for setting up the project.
Add Environment Setup Instructions
Add instructions to create and activate a virtual environment before installing the dependencies, to help avoid conflicts with system-level packages.
Expand Dataset Section
Provide more details about the structure of the dataset, and instructions on how users can extend it or modify it for their needs. A table explaining the dataset features would be helpful.
Add How to Contribute Steps
Provide step-by-step instructions for contributors on how to fork the repository, create a branch, make changes, and submit a pull request.
Add Usage Examples with Screenshots or GIFs
Include examples of the application in action, with screenshots or GIFs, to make it easier for users to understand how the project works.

sure plz try

i would like to contribute @Devanik21


added buy form placeholder

Buy form with verification placeholder.
Faucet integration added
Tab structure for showing owned names

images


Anchor Deploy ELF Error: Invalid String

So I'm working on a new program and got it to build. I want to deploy to devnet, so I set my Solana config to api.devnet.solana.com. I generated a vanity keypair for the program and passed that private key array to the keypair.json file that generates when you run anchor build. But then I run anchor deploy --provider.cluster devnet I get this error...
ELF error: ELF error: Failed to parse ELF file: invalid string
I'm not sure what string it's referring to that's invalid. Someone suggested it might be related to my Cargo.toml file.
name = "word"
version = "0.1.0"
description = "Created with Anchor"
edition = "2021"

[lib]
crate-type = ["cdylib", "lib"]
name = "sayword"

[features]
no-entrypoint = []
no-idl = []
no-log-ix-name = []
cpi = ["no-entrypoint"]
default = []

[dependencies]
anchor-lang = { version = "0.29.0", features = ["init-if-needed"] }
anchor-spl = "0.29.0"
random_word = { version = "0.4.1", features = ["en"] }
solana-program = "1.17.9"

This is also the beginning of my lib.rs file...
use anchor_lang::prelude::*;
use crate::state::state::Increment;

pub mod instructions;
pub mod state;
mod errors;

pub use instructions::*;
pub use state::*;

declare_id!("3iQ3v19x7zQUgqV3amCMmuci8UjGejQp1fpEXBaP8pAB");

#[program]
pub mod word {
    use super::*;

    /// Creates the Game Account
    pub fn initialize_create_game(
        ctx: Context<CreateGame>, name: String, min_deposit: u8) -> Result<()> {
        handle_create_game(ctx, name, min_deposit)?;
        Ok(())
    }

I ran into this issue when trying to run anchor test too, but I was somehow able to resolve it, but I kept running into testing errors that I can't pin down the origin of. Not sure if it's the program, the way the test is written, or something else. So I was just going to deploy it and test it on devnet via the IDL.

This is because you're using random_word crate which depends on rand crate. Programs execution must be deterministic so crates like rand is not allowed to be used inside Solana programs(not Anchor specific).
Please see on-chain program restrictions.