drive pub  command presents an invalid address of the published file

Great program with a hopeful potential!
When I try to publish a google document using drive pub command, the document gets shared publically, but the drive pub command returns an invalid address for the published document.
Here:
me@mine:~/Drive$ drive pub test
/test Published on https://googledrive.com/host/1nR2ZzEe6XqjEUVqeQdRkI3OqzR2lI5PQhzlBgixkbS8
If you press the link, you will end up with a 404 error.
through the web interface one can find the real address of the publically shared document, it is this in this case:
https://docs.google.com/document/d/1nR2ZzEe6XqjEUVqeQdRkI3OqzR2lI5PQhzlBgixkbS8/edit?usp=sharing
You can see that the ID part of the document is the same, but the rest of the address is wrong.
It may be because I use my own domain (google apps account?),  I have not checked it with the regular google account.
It is also to be noted that there are two ways make a document public in Google Documents. One is called Publishing (to be found under the File menu) and it produces a non-editable version. The other is called sharing, and accessible via a special button on the top right corner. There are various modes of sharing, one of which makes the document public, but it stays a Google Documents document all the same. I expected that "pub" option, in contrast with "share" option, will publish document in the first sense, but I got the second. Not a big problem, imho, but maybe it could be rearranged to more exactly align with the google apps behaviour?

Thank you for reporting this. To get started, did you check out drive share? Also the fileId in both cases looks uniform so that eliminates the variable of invalid fileId. Makes me suspect the domain.

To test out a hypothesis I have about Google Docs, would you mind publishing a non Google doc? E.g a photo, then a folder -- different mimeTypes.

Been able to reproduce this, it confirms my suspicions about Google Docs + Sheets using a different publicView domain. I'll jump onto this in about 10 hours when I get back home.

Thank you for a quick response. By the way, I am currently using drive version 0.1.0, but this problem has been present before.
Strange:
$ drive pub test.png
/test.png Published on https://googledrive.com/host/0B7N4UaoQWBXiY1ZKamR1c09hMHM

The above address works.

$ drive pub testdir/
/testdir Published on https://googledrive.com/host/0B7N4UaoQWBXiUS1CcE9EYmw0STQ

The directory publishing also works!

Now, the sharing thing:
I also did some tests, as you suggested.
$ drive share -emails<EMAIL_ADDRESS>-message "Test of Share feature" -role writer -type group test_shared.png
Message:
Test of Share feature
Receipients:
+<EMAIL_ADDRESS>File(s) to share:
+ test_shared.png
Proceed with the changes? [Y/n]: Y
googleapi: Error 500: Internal Error, internalError
Ok, strange... The command actually failed, the file did not get shared. Also it fails the same way repeatedly, and inbetween other commands do work, so it is not a temporary issue.
It is also to be noted that when I did the command this way after reading help:
$ drive share test_shared.png<EMAIL_ADDRESS>-message="testing share feature of drive" -notify=true -role="writer"
It just failed (the file was not shared) without any messages being printed on the command prompt.
Anything else I can do to test this out?

Thank you for the tests, as mentioned above the issue is with Google Docs + Sheets using a different publishing domain. It seems like a change in Google Docs + Sheets in the last year or so ie them supplying a generated URL instead of allowing for access through the usual domain: sometime back I reported a bug to the Google Drive team in which created Doc files right after upload to your drive, before they were converted and had their url changed to point to the Google Docs domain, you'd get that error. I could be wrong about the Google Drive bug but so far it points to the pub url for Docs + Sheets.

When I removed the "-type group" part from the command, it completed successfully (the file was successfully shared with my other account):
$ drive share -emails<EMAIL_ADDRESS>-message "Test of Share feature" -role writer test_shared.png
Message:
Test of Share feature
Receipients:
+<EMAIL_ADDRESS>File(s) to share:
+ test_shared.png
Proceed with the changes? [Y/n]: Y
Actually, I have not explored the particulars of the share command and the possibilities that google gives for sharing, I do not even know what "-type group"  means. :)

Fixed by https://github.com/odeke-em/drive/commit/7140805e858d3a0f8ebc57c594766a3363da6d58


Fix race in LogAppender::haveAppenders.

Scope & Purpose
Backport of #13789
haveAppenders is called as part of audit logging. It accesses _topics2appenders and _globalAppenders but previously did not hold a lock while doing so.
This problem only showed up because previously we used operator[] which inserts a new entry if none is found and this caused a memory leak in the ASan tests.

[x] :hankey: Bugfix
[x] :book: CHANGELOG entry made

Backports:

[x] No backports required

Testing & Verification

[x] The behavior in this PR was manually tested

Tests blue except unrelated failure.


Android fix b

I found a small issue in the profile.d-android.sh file in which android_NDK was used instead of android_SDK.
I also added some supporting files in the workspace

This finally works on my stand alone machine. Minor issue with gradle needing sudo  to run just the first time. Will probably PR again soon.

 I have put them back. The only thing that really matters is that the Cloud 9 build actually works and the ENV variables should have zero effect on the Cloud 9 build

This branch seems to work fine. Can you check it and make a pull request with the master.

This should now fully work

I would like to do a Pull Request to the master. Do I have to do that or can you?
On a side note: Hopefully Cloud 9 can set-up a development server for Dockerfile testing so that we do not have to bug you with every little change. If I had access to building on a developmental Cloud 9 server this would have been a few days of programming instead of this long convoluted way of developing containers.
P.S. Thanks for the help Justin8, for the present way of doing things you have been awesome.


Question about the Segmentation task

Hi @MaureenZOU ,
Thank you for your consideration
I have a question that if I run this:
mpirun -n 8 python eval.py evaluate --conf_files configs/xdecoder/svlp_focalt_lang.yaml  --overrides WEIGHT [BestSeg Tiny](https://projects4jw.blob.core.windows.net/x-decoder/release/xdecoder_focalt_best_openseg.pt)

and just only for ADE panoptic dataset:

What would be the model between the following two?

It would be (a)

I see, thank you.

Hi @MaureenZOU ,
I have quick question about where is in the code for the arrow from Text Encoder to Semantic Output when inference.


doc: Document claiming devices using claim auth code

Summary
Closes #1079
Notes for Reviewers
Is this good place to locate these instructions? I find it a bit weird that it's separated from QR code-related docs and adding devices, but I somehow don't see these in Adding Devices. Also I'm curious, why does join-server-enabled option have to be set to false?
Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
[x] Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
[x] Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

Claiming a device using the QR Code from the Consle is already documented in the main flow. I think claiming using the CLI should go into the Bulk section since you can automate claiming for multiple devices. I would remove this page entirely and add a alias in the main flow.

I moved this to adding devices in bulk section and added info on how to claim both single and multiple devices, so all options are documented. I also think we should keep the Claiming devices doc as it has interesting info about the general concept of claiming.


data in the paper

Hello, the work in your papers is great, which gives me great inspiration and help. When can the data in the paper be public? Looking forward to your reply.

Hello,
Your publication is interesting, could you please share the dataset used in the research here.
Thanks.

@tommonopolinks  Thank you for being willing to share your dataset with the public. Could you please share the dataset if possible?

@WangZhenqing-RS @Hassnain1 @PradeepYLN
Thank you for reaching out, and sorry for the late reply.
Source code and landslide inventories have now been uploaded to this repository. Notebooks in the processing/ folder are used to load each inventory, search relevant Sentinel-2 products and download them, and perform the rest of the preprocessing operations (cloud detection, DEM processing, S2 tiles generation), as detailed in the paper.
I will soon write a detailed readme to reproduce the experiments.

@tommonopolinks Thank you very much for your sharing spirit, but I can't seem to run the data processing code well
Downloading products...
pre_s2: 100%|██████████| 12/12 [00:00<00:00, 12803.78it/s]
post_s2: 100%|██████████| 4/4 [00:00<?, ?it/s]
dem: 100%|██████████| 1/1 [00:00<?, ?it/s]
 25%|██▌       | 4/16 [00:00<00:00, 12.42it/s]
Traceback (most recent call last):
  File "E:\igarss-landslide-delineation\processing\colombia.py", line 236, in <module>
    mask = cloud_detector(stack)
  File "E:\lib\site-packages\torch\nn\modules\module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "E:\lib\site-packages\torch\nn\modules\module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "E:\igarss-landslide-delineation\src\cloud_detector.py", line 58, in forward
    assert set(self.bands).issubset(list(stack.long_name)), f"The given bands {list(stack.long_name)} do not contain the necessary bands for cloud masking. Please include bands {self.bands}."
AssertionError: The given bands ['s', 't', 'a', 'c', 'k', 's', 't', 'a', 'c', '-', 'c', '8', '2', '6', '8', '9', 'b', '6', 'b', '2', 'f', '0', '0', 'e', 'c', '4', '2', '9', '3', 'e', '8', '4', 'c', '2', 'f', 'a', 'a', 'b', '1', '0', '5', '2'] do not contain the necessary bands for cloud masking. Please include bands ['B01', 'B02', 'B03', 'B04', 'B05', 'B06', 'B07', 'B8A', 'B09', 'B11', 'B12', 'AOT', 'WVP'].

I noticed that the images I downloaded were completely black, but still tens to hundreds in size.

Sorry, this is due to my bad network, and the downloaded file may be corrupted. Please note that the data is about 20-30G per folder, and the total may be 100G.

@joe-vettek  how can we resolve the issue which you are showing in this image.

@joe-vettek  how can we resolve the issue which you are showing in this image.

i deleted the image which casue the crash and try download it again. i' think it's a network problem leading to a bad image file.

@joe-vettek  i am facing issue while trying to train bbunet model  precision, recall and f1-score all are coming 0 only. can you give suggestion how can i resolve this

@joe-vettek i am facing issue while trying to train bbunet model precision, recall and f1-score all are coming 0 only. can you give suggestion how can i resolve this我在尝试训练 bbunet 模型时遇到问题，精度、召回率和 f1 分数都仅为 0。你能给我建议吗我该如何解决这个问题

strange, i use the china dataset emmm, maybe your dataset downloaded has some problem?

hello @joe-vettek , @tommonopolinks
I am facing an issue related to CUDA out of memory (OOM) errors when attempting to download the Sentinel-2 (S2) inventory for Haiti, Indonesia, and China. The error occurs while executing the following lines of code:

System Configuration:
GPUs: 4 x 16GB
Software environment: python version 3.10.12
Despite having multiple GPUs with 16GB of memory each, the memory seems insufficient to handle the download process. It appears that the process exceeds the available GPU memory resources.
giving error like this

Please give me any suggestions to reduce batch size or i can make some change in these code like do some for pre images first and after for post images.
thanks

Hi @indraraj493, I was not aware of how much GPU memory was needed for the cloud detection part, as I used a fairly big GPU (80GB) and had no problems.
The cloud detector used is a fully convolutional one, therefore a full-sized image can be fed into it without tiling needed. This obviously becomes a GPU memory bottleneck when an image is too large, and tiling the image beforehand will be needed. Perhaps I can modify code in src/cloud_detector.py to optionally perform this tiling. I will do it when I have time.
In the meanwhile, you could either try modifying the code yourself or simply rely on device='cpu' (if your RAM is sufficiently large)

thanks @tommonopolinks ,
i am able to download this cells on device='cpu' but i getting some issue in downloading the things for "indonesia"
error is like this

i am running the script "processing_indonesia.ipynb"

Thank you @indraraj493, glad that you found my work useful!
Ways to enhance the model's performances would be:

Additional landslides in the training set (data quantity). Scanning the literature for other open-access landslide inventories, process them as done in this repo and adding them to the training set. I am currently pursuing this path, for a 2nd version of my BBUnet model.
Finding ways to deal with inaccurate ground-truth delineations (data quality). What I noticed is that some manually-annotated landslide inventories you can find online are not very accurate in terms of delineation accuracy. This is aggravated by Sentinel-2 relatively low spatial resolution of 10 m/px. One way to deal with not-so-accurate delineations could be to use label-smoothing techniques such as SVLS or GeoLS.
Experiment with different and/or more aggressive data augmentation (data variety). You could try experimenting with mask-wise augmentations like mask erosion/dilation, or other augmentation techniques used specifically for satellite images, e.g. MixChannel.


Graceful: Allow graceful restart for unix sockets

Previously we could not handle graceful restarts for http over unix sockets. This PR adds this functionality.

Codecov Report

Merging #9113 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #9113      +/-   ##
==========================================
- Coverage   41.11%   41.11%   -0.01%
==========================================
  Files         547      547
  Lines       71614    71613       -1
==========================================
- Hits        29447    29442       -5
- Misses      38442    38445       +3
- Partials     3725     3726       +1

Impacted Files
Coverage Δ

modules/graceful/restart_unix.go
4.44% <0%> (-0.32%)
:arrow_down:

cmd/web.go
0% <0%> (ø)
:arrow_up:

modules/graceful/net_unix.go
18.97% <0%> (-1.34%)
:arrow_down:

cmd/web_graceful.go
0% <0%> (ø)
:arrow_up:

modules/process/manager.go
74.32% <0%> (-4.06%)
:arrow_down:

models/repo_list.go
73.14% <0%> (-0.93%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0aaffe...2877786. Read the comment docs.


spinner not on right side of CustomView in split action bar

In a split action bar the spinner is shown to the right of any custom view.
Thus it is shown superimposed above the custom view until that changed location to the left to free up layout space at the right border.
(this custom view has gravity RIGHT. while the default gravity is LEFT.)
It should be displayed left of any custom view like it is in a non-split action bar.

Can you provide a quick .zip or pastebin of the code to demonstrate this? I'll be able to debug much faster and want to make sure I fix specifically what you're looking for.

A customView with gravity right...
final ActionBar supportActionBar = getSupportActionBar();
final ImageView dashboard = new ImageView(this);
final LayoutParams layoutParams = new ActionBar.LayoutParams(
LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT,
Gravity.RIGHT | Gravity.CENTER_VERTICAL);
			dashboard.setLayoutParams(layoutParams);
		dashboard.setImageDrawable(this.getResources().getDrawable(
				R.drawable.icn_raster));
		supportActionBar.setCustomView(dashboard);

and in onCreate:
	requestWindowFeature(Window.FEATURE_PROGRESS);
	requestWindowFeature(Window.FEATURE_INDETERMINATE_PROGRESS);
            super.onCreate(savedInstanceState);
	setContentView(R.layout....);

and then actually show the spinner at some random point in time while the activity is showing.
	setSupportProgressBarVisibility(true);
	setSupportProgressBarIndeterminateVisibility(true);
	setSupportProgress(Window.PROGRESS_END);

When the spinner runs for just a second or so, it looks like it is
superimposed on the customView because the customView has not yet
animated/moved to the left.
Before it gets a chance to do so, the spinner is already gone.
Is there a way to get the spinner to display to the left of the customView?
That would be a simple solution without having icons shifting around.
This way http://i.imgur.com/18zny.png looks quite wrong.
On Fri, Feb 10, 2012 at 04:42, Jake Wharton <
<EMAIL_ADDRESS>
wrote:

When I use setCustomView(dashboard, layoutParams) I don't see the
problem (I think).
Is this what it's supposed to look like or is this the bug?
http://i.imgur.com/K7La1.png
http://i.imgur.com/kUaVt.png
http://i.imgur.com/18zny.png

Reply to this email directly or view it on GitHub:
https://github.com/JakeWharton/ActionBarSherlock/issues/237#issuecomment-3900716

The only way to do this would be to include the spinner in your custom view. The action bar can only be so dynamic to support all of these cases and it seems that something like this wasn't accounted for unfortunately.
That being said, I don't disagree with you that this should be considered as an option. File a bug on http://b.android.com and paste the link to it here for reference. I've already sent in a couple tiny fixes to the AOSP so maybe one day I'll get around to tackling this (or Google will).


Hide "spec only" button when it doesn't do anything

The environment variables window has a toggle button that controls whether only "from spec" variables are shown.
This change hides the button in the case that all items are from the spec, in which case toggling it would have no visible effect.

It might be better to disable the button instead of hiding it completely.

Agreed - from an accessibility perspective disabled is better in this scenario.

Updated to disable rather than hide the button.


Every time terraform apply is run, ops agents are removed and reinstalled.

TL;DR
When the terraform apply command is run on a project with an ops agent policy, the ops agents and their dependencies are removed from all instances that are part of that ops agent policy and then reinstalled.

Expected behavior
To not initiate ops agent removal or reinstallation.
Observed behavior
However, once the ops agent installation and removal process begins, some servers are unable to have the ops agent reinstalled.

Terraform Configuration
module "agent_policy_windows_2012" {
  source  = "terraform-google-modules/cloud-operations/google//modules/agent-policy"
  version = "~> 0.2.3"

  project_id = ""
  policy_id  = "ops-agents-windows-policy"
  agent_rules = [
    {
      type                   = "ops-agent"
      version                = "current-major"
      package_state          = "installed"
      enable_autoupgrade     = true
    },
  ]
  group_labels = [
    {
      env = "test"
      app = "windows"
    }
  ]
  os_types = [
    {
      short_name = "windows"
      version    = "6.3.9600"
    },
  ]

}

Terraform Version
Terraform v0.13.7

Additional information
No response

Having the same issue, makes this module unusable across large numbers of VMs

same issue.  TF does not track well things executed outside of it.. aka this module calls a local-exec of gcloud to execute the changes.

+1

Also a thing for me.


Update on-boarding.rst

Changed the Administration tasks to incorporate a loose outline of common first tasks that the admin needs to do after installing and deploying Mattermost.  Moved the document from Administration Guide > Configure Mattermost to **Administration Guide > Getting Started"

@amyblais I've addressed the bullets and updating the links.


ServeAPI error: is a directory

New docker nodes that I bring up are getting this error. Any suggestions or ideas?
I've tried it now on two completely fresh boxes. This is Docker 1.7.1
Note: because Linode uses custom kernels, I've always fallen back to devicemapper since aufs support isn't possible without a bootloader.
root@localhost:~# docker -d
WARN[0000] Udev sync is not supported. This will lead to unexpected behavior, data loss and errors. For more information, see https://docs.docker.com/reference/commandline/cli/#daemon-storage-driver-option
ERRO[0000] ServeAPI error: is a directory
INFO[0000] [graphdriver] using prior storage driver "devicemapper"
WARN[0000] Running modprobe bridge nf_nat failed with message: , error: exit status 1
WARN[0000] Your kernel does not support swap memory limit.
INFO[0000] Loading containers: start.
......ERRO[0000] Error unmounting device 90562e5df6b554a1bc41196f6c24f1d9bdd452818377913773b475d940839897: UnmountDevice: device not-mounted id 90562e5df6b554a1bc41196f6c24f1d9bdd452818377913773b475d940839897
ERRO[0000] error locating network id f4428f1834021aaba328334c1dd2d56279cf04f9c88215658111e15ce84d725a: network f4428f1834021aaba328334c1dd2d56279cf04f9c88215658111e15ce84d725a not found
ERRO[0000] Error unmounting device 90562e5df6b554a1bc41196f6c24f1d9bdd452818377913773b475d940839897: UnmountDevice: device not-mounted id 90562e5df6b554a1bc41196f6c24f1d9bdd452818377913773b475d940839897

INFO[0000] Loading containers: done.
INFO[0000] Daemon has completed initialization
INFO[0000] Docker daemon                                 commit=786b29d execdriver=native-0.2 graphdriver=devicemapper version=1.7.1
ERRO[0001] Error during graph storage driver.Cleanup(): device or resource busy
ERRO[0001] remove /var/run/docker.pid: no such file or directory
FATA[0001] Shutting down due to ServeAPI error: is a directory

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

docker version:
Client version: 1.7.1
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 786b29d
OS/Arch (client): linux/amd64
docker info:
Cannot connect to the Docker daemon.  I deleted the directory, did a touch on docker.sock, and now Docker loads up fine. Any idea why this is happening? This happened on two completely fresh servers. Thanks again!

What is setting up your servers?

@cpuguy83 I used the Tutum installation scripts, which installs 1.7.1. Is this possibly a Tutum issue rather than Docker? Wouldn't the socket be created with the Docker install? Thanks!

Definitely not docker. cc @fermayo

@fermayo @cpuguy83 - Looks like somehow the sock file that I created got deleted and a directory placed back in its place, so once again it is failing.

understood, @cpuguy83 thanks for your help

Closing this since it looks like it's not an issue. :tada:

@calavera @cpuguy83 @etcook
I have spent some time on this issue and it looks like a RC in the docker daemon. The RC condition happens when there is a running container A mounting the host folder /var/run/docker.sock (for example weaveworks/weave:1.0.1). If the docker daemon is restarted, it happens that the container A is restarted before  /var/run/docker.sock is created by the docker daemon and then, /var/run/docker.sock is created as a folder (the default behavior for docker volumes).

Note that I am able to reproduce this error only if using TLS and using the exact DOCKER_OPTS parameter order shown above. For example, switching -H tcp://<IP_ADDRESS>:2375 and  -H unix:///var/run/docker.sock I am not able to reproduce the error (probably because this way the docker daemon creates /var/run/docker.dock faster) which is the workaround we are using in Tutum for now.
Thanks!

@cpuguy83 definitely it's docker ;-)

Thanks! Re-opening

#Investigating
FYI... not reproducing on:
mike@ubuntuMikeBrown:~$ docker version
Client:
Version:      1.8.1
API version:  1.20
Go version:   go1.4.2
Git commit:   d12ea79
Built:        Thu Aug 13 02:35:49 UTC 2015
OS/Arch:      linux/amd64
Server:
Version:      1.8.1
API version:  1.20
Go version:   go1.4.2
Git commit:   d12ea79
Built:        Thu Aug 13 02:35:49 UTC 2015
OS/Arch:      linux/amd64
mike@ubuntuMikeBrown:~$ docker info
Containers: 15
Images: 570
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 600
Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.19.0-25-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 1
Total Memory: 3.86 GiB
Name: ubuntuMikeBrown
ID: I5RH:OQVQ:Q2FC:GYRT:THGN:LM64:SCTA:QILK:5R54:UIWU:2CSC:XNUW

I think you might have been attempting to use and restart docker before the container had finished restarting...  I was having problems running your script as the docker container had not finished restarting before the docker ps command was executed. So I used the script below and all seems fine now.  Was the docker ps successful on your run? Or did it report a failure?  Can you try this?
#!/bin/bash
while true
do
service docker restart
if [[ -d "/var/run/docker.sock" ]]; then
echo "RC creating /var/run/docker.sock"
exit 1
else
while [ ! -e "/var/run/docker.sock" ] ; do
inotifywait -t 2 -e create $(dirname "/var/run/docker.sock")
done
  docker ps

fi
done

Yes, that script also fails for me. It is not related to the docker ps command, it also fails if using  sleep 1 instead of docker ps. I can repro this consistently in fresh t2.micro machines. I am installing docker like this:
https://gist.github.com/parente/025dcb2b9400a12d1a9f

Thx.. I was trying to reproduce on docker not lxc-docker.

I have been able to repro this by installing:
   apt-get install docker-engine=1.7.1-0~trusty

but not in the latest 1.8.1 version.

Thx.. for the update.

I'm getting this again on a freshly compiled master with a --restart=always container that mounts the Docker socket.  I know we fixed this once by moving the initialization of container mounts to after the point where the daemon creates the socket, but I don't know whether the problem is exactly the same this time (although the symptoms are definitely 100% identical).
If I sudo rm -rf /var/run/docker* before restarting the daemon, the daemon itself recreates the socket location as a directory.

Pretty sure it was latest @calavera refactoring. Shouldn't be hard to fix.

Also now container can take daemon port too.

@tianon ok, I fixed it and found that last time I wrote false-positive test. Will post PR tomorrow.

You're a hero, @LK4D4! :heart:

it seems this problem is still alive?
I'm getting this on Fedora 23 and docker version 1.9.1-fc23
If i have restart=always and mounted the docker.sock.
my workaround at the moment:

Add this line to the systemd unit file docker.service:
ExecStartPre=/usr/bin/touch /var/run/docker.sock

Am I wrong in this thread?

Have had the same issue on Fedora 23 today. It was working the other day but stopped after a restart was triggered.
After removing the mentioned directory /var/run/docker.sock/ it was working again.

Yes but it stopps always after a restart is triggerd, or is this not the case on your system?

@setiseta @appelgriebsch that's because the systemd unit file doesn't contain Requires=docker.s octet. Check https://bugzilla.redhat.com/show_bug.cgi?id=1289851 for a workaround also. Luckily this will be fixed in docker-1.10.

Just hit this issue on a few nodes with CoreOS 1068.8.0 Docker 1.10.3 :(

We are seeing this in docker 1.11.2 in Ubuntu 14.04 as well, this definitely isn't resolved.  Any chance we can get this bug re-opened or should a new issue be opened? @vdemeester

I am also seeing this issue in docker 1.11.2:
root@v33:/etc/kubernetes# docker --version
Docker version 1.11.2, build b9f10c9

My docker logs:
time="2016-10-27T08:41:10.295693965Z" level=error msg="Force shutdown daemon"
^[[34mINFO^[[0m[8687] stopping containerd after receiving terminated
/var/run/docker.sock is up
time="2016-10-27T08:41:11.412032150Z" level=warning msg="/!\\      DON'T BIND ON ANY IP ADDRESS WITHOUT setting -tlsverify IF YOU DON'T KNOW WHAT YOU'RE DOING /!\\"
time="2016-10-27T08:41:11.762604081Z" level=fatal msg="can't create unix socket /var/run/docker.sock: is a directory"

I found after stopped docker service, docker.sock may be changed to directory:
root@v34:/etc/kubernetes# ls -al /var/run/docker.sock
srw-rw---- 1 root docker 0 Oct 27 10:17 /var/run/docker.sock
root@v34:/etc/kubernetes# service docker stop
docker stop/waiting
root@v34:/etc/kubernetes# ls -al /var/run/docker.sock
total 0
drwxr-xr-x  2 root root  40 Oct 27 10:18 .
drwxr-xr-x 28 root root 940 Oct 27 10:18

Now, I solved this problem temporily just by add rm -rf /var/run/docker.sock in pre-start script of docker.conf:
pre-start script
	# see also https://github.com/tianon/cgroupfs-mount/blob/master/cgroupfs-mount
	if grep -v '^#' /etc/fstab | grep -q cgroup \
		|| [ ! -e /proc/cgroups ] \
		|| [ ! -d /sys/fs/cgroup ]; then
		exit 0
	fi
	if ! mountpoint -q /sys/fs/cgroup; then
		mount -t tmpfs -o uid=0,gid=0,mode=0755 cgroup /sys/fs/cgroup
	fi
	(
		cd /sys/fs/cgroup
		for sys in $(awk '!/^#/ { if ($4 == 1) print $1 }' /proc/cgroups); do
			mkdir -p $sys
			if ! mountpoint -q $sys; then
				if ! mount -n -t cgroup -o $sys cgroup $sys; then
					rmdir $sys || true
				fi
			fi
		done
	)
	rm -rf /var/run/docker.sock
end script


Configure the feed-in limit; resolves issue #47

The following changes are contained:

add parameter to the config page
use the parameter in the code (to have consistent names the variable fc_above_70 was renamed to enable_smart_battery_control)
add a few comments in the code to explain what happens

I just noticed that I forgot to add some translations for the config page. I'll do that and create a new pull request.


Remove Arc from gfx-rs

Fixes #824
This is API breaking so it should be part of 0.9. We will probably want to add a way to do Ord for our handles as it is needed for gfx_scene (This change will break gfx_scene).

Well, considering the PSO stuff coming in, gfx_scene doesn't have no chance to survive without a bit of re-design anyway ;)
Thanks for cleaning this up!
@homu r+

:pushpin: Commit ea0830e has been approved by kvark

:hourglass: Testing commit ea0830e with merge 4bdd9a0...

:broken_heart: Test failed - status

@homu retry

:hourglass: Testing commit ea0830e with merge 1e791ab...

:sunny: Test successful - status


⚠ Bofrost.fr has degraded performance

In 946f2bb, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 877 ms

Resolved: Bofrost.fr performance has improved in e3fbd87 after 6 minutes.


Front end minor issues

Visualization typos in front end tooltips
snapshoot -> snapshot
record -> Record (if you care about consistency)
Model info. -> remove period; also the fields are empty when you click on it

@AlbertoCasasOrtiz Can you take care of the first two issues above? Also the size of the rectangle of the drop area for drag-and-drop is a bit skinny, could that be enlarged a bit? Thank you

I fixed the typos in the i18n file.

This seems to have been fixed, will move to done pending feedback.


Update the delete docs for Runtime V2 on Windows

Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

LGTM

LGTM


Standardize Ray external resource messages

Standardizes the Ray external resource messages so that they all have the same structure.
Also updates some exception logs to deduplicate exception printing.

666
😈


NIFI-9714 Added overloaded toMap to MapRecord that can convert sub-re…

…cords into maps.

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@mattyb149 I extracted this from an old PR for adding JSON support to PutDatabaseRecord.

@mattyb149 can you review so I can restart the JSON/JSONB support in PutDatabaseRecord?

+1 LGTM, thanks for the improvement! Merging to main


Add concurrency

We can add concurrency to enable simultaneous execution which can significantly improve the performance of Skua.

/


Pipeline identity issues running the dogbreed classification example

Hi,
I am facing pipeline API server auth issues running the dogbreed classification problem from a kale note book with "HP Tuning with Katib" enabled. When I press the Complile and run Katib job" from the notebook I see the user identity missing errors in the pipeline API server logs, (excerpt below)
I0916 14:55:34.876951       7 error.go:218] Request header error: there is no user identity header. github.com/kubeflow/pipelines/backend/src/apiserver/server.getUserIdentity         backend/src/apiserver/server/util.go:304 github.com/kubeflow/pipelines/backend/src/apiserver/server.isAuthorized         backend/src/apiserver/server/util.go:377 github.com/kubeflow/pipelines/backend/src/apiserver/server.CanAccessNamespaceInResourceReferences         backend/src/apiserver/server/util.go:350 github.com/kubeflow/pipelines/backend/src/apiserver/server.(*ExperimentServer).CreateExperiment         backend/src/apiserver/server/experiment_server.go:26 github.com/kubeflow/pipelines/backend/api/go_client._ExperimentService_CreateExperiment_Handler.func1         bazel-out/k8-opt/bin/backend/api/linux_amd64_stripped/go_client_go_proto%/github.com/kubeflow/pipelines/backend/api/go_client/experiment.pb.go:569 main.apiServerInterceptor         backend/src/apiserver/interceptor.go:30 github.com/kubeflow/pipelines/backend/api/go_client._ExperimentService_CreateExperiment_Handler         bazel-out/k8-opt/bin/backend/api/linux_amd64_stripped/go_client_go_proto%/github.com/kubeflow/pipelines/backend/api/go_client/experi .. Bad request.
...
github.com/kubeflow/pipelines/backend/src/common/util.(*UserError).wrap         backend/src/common/util/error.go:211 github.com/kubeflow/pipelines/backend/src/common/util.Wrap         backend/src/common/util/error.go:244 github.com/kubeflow/pipelines/backend/src/apiserver/server.isAuthorized         backend/src/apiserver/server/util.go:379
..
Failed to authorize with API resource references
All the trials fail, seemingly when the jobs fail creating experiments.
It seems the API server requires a user identity to authorize the call but should'nt that be happening automatically somehow?
I also had to add a "pipleine-runner" service account in my namespace, which the trial jobs require, as it wasnt there by default and assign it the proper clusterrole / rolebindings.
I am running kubeflow 1.1 using this manifest file on AKS 1.15.13
I am using the 'gcr.io/arrikto/jupyter-kale:v0.5.0-47-g2427cc9' image to create the notebook server and updating the following kubeflow components after install.
Katib controller: gcr.io/arrikto/katib-controller:40b5b51a
Katib Chocolate service: gcr.io/arrikto/suggestion-chocolate:40b5b51a
After installing 1.1, I faced an issue described here and applied a workaround, by updating pipeline istio destination rules to HTTP instead of mTLS, also discussed in the same thread. Though, I am not sure if this issue is related with my current problem.
Looking for suggestions.

For anyone facing the same issue, I posted this query on the kubeflow kale slack channel and this is the response I got from @elikatsis
"The trial uses the KFP python client to create experiments and runs.
The problem here is that upstream KFP (I believe that's the one you have deployed) supports authentication/authorization for its client only from outside the cluster and only on GCP.
The reason why the codelab works on MiniKF is that we (Arrikto) have extended the KFP apiserver and the python client accordingly enabling their secure communication.
We will be pushing these designs and implementations upstream in the near future."

@danishsamad Have you heared something in regards to this topic?
We are facing the same issue with [1.2.0 AWS deployment with istio 1.1[(https://github.com/kubeflow/manifests/blob/v1.2-branch/kfdef/kfctl_aws_cognito.v1.2.0.yaml). The problem seems not be present using the 1.2 deployment with dex.
Maybe this is related to the old istio version used in that manifest?


Generating a HAR file

I am creating a HAR file with tracerbench create-archive --url https://www.google.com/, but I noticed that the HAR file doesn't have as much information as when I download a HAR file manually from a browser. Is there a way to get more info using tracerbench create-archive?

In the latest major release create-archive has been replaced by record-har command which records significantly more data. Please note we now are requiring a cookies file. If your SPA doesn’t require auth simply pass a cookies.json with an empty hash.

thanks!


Ability to serve images from database or s3?

Hi,
I've got a setup where I cannot rely on user uploaded images being on disk, users upload images and I'm storing the file data and mimetype in the database, resizing them and then passing them along to s3.
Have you considered a similar approach?
Cheers

see the answers on liip/LiipImagineBundle#56


Few questions about unpackerr

I have been looking at using this tool for a while, but I finally got around to setting it up, and I absolutely love it, but I have a couple of questions in relation to the usage/config.
I know that you can run parallel unpackings instead of serial, but what's the absolute minimum in terms of times you can set for the different sections?
When it says that there were X number of restarts, is there an easy way of seeing what was restarted and why?
The same goes for failures.
What exactly does pre-Queue mean? I'm seeing pre-Queue for stuff that wasn't rared, so I would assume it should just ignor eit, but I'm not seeing that.
Thanks for the awesome tool.

What's the absolute minimum in terms of times you can set for the different sections?

I'm sorry, but I'm not sure what you're asking here.

Is there an easy way of seeing what was restarted and why?

That information is in the logs. Things will only restart if extraction failed. They may restart forever until it's fixed. I have not experienced this behavior much, so if you want to share your logs I'd be happy to have a look. email: david at sleepers dot pro.

What exactly does pre-Queue mean?

It means the item is still in your Activity Queue, and not being imported. An item staying this way for a long period while completed usually means you need to go into your app and manually import the item or remove if from the queue. If an extractable file is found in the item, the item will leave pre-queue and become queued for extraction.

Sorry, the first question was a mixture of thoughts and should've been clearer. What I meant was, how quickly can each of the time-based options be set to? You mention in the config example that it's all based on Go, so I was trying to understand can you go into the seconds or milliseconds timing or are you limited to just minutes.
The restarts seem to be related to one pack that has a bad rar in them, but I've manually imported those files so I'm curious as to why it keeps trying to unpack and import them.
For the pre-Queue, I see that a lot for non-rared files which is why I'm confused. I'll double check my radarr instance, but I'm pretty sure they're already imported. I will send the log over as well, just so you can take a look at what mine looks like with all of its fun.

How quickly can each of the time-based options be set to?
What's the absolute minimum in terms of times you can set for the different sections?

These two questions seem like they ask the same thing. Are you referring to configuration options? Which ones? I'm still not understanding what the problem is you're trying to solve with this question. Can you describe the problem?

I'm curious as to why it keeps trying to unpack and import them.

It's trying to unpack them, but import them? I don't think it can import them until it gets properly unpacked. You mention a bad archive: this will cause it to keep retrying. It's expecting you to either delete it, or finish downloading it so it's complete.

I'll double check my radarr instance, but I'm pretty sure they're already imported.

Radarr v3 hides unknown movies by default, but continues to provide them to API callers. Go into Radarr -> Activity -> Click Options in the top right and check the box that says Show Unknown Movie Items. Once the unknown movies display in your queue, either manually import them or delete them.

For the timing thing, I was meaning the config, such as this:
How long an item must be queued (download complete) before extraction will start.
One minute is the historic default and works well. Set higher if your downloads
take longer to finalize (or transfer locally). Uses Go Duration.
start_delay = "30s"
I assumed it would fail after X number of tries, but that makes sense that it'll just keep retrying.
I'm using Radarr v2 and Sonarr v3, and I found the problem which was that in both instances, the movies or TV shows in question were still in the queue even though they had already been imported (hover text said 'Has same file size as existing file') so I just manually imported them and it's happy now.

oh, start_delay. When an items hits complete in sonarr or radarr, unpackerr will wait start_delay before queuing the item for extraction. I would generally just recommend leaving that at 1 minute, but 30s is probably fine. I think the way things work internally though, it only actually checks every minute, so a minute is probably actual minimum.
I made this value to be turned UP not DOWN. Some folks run radarr and their download client in different locations and they use a script to copy downloads locally. Sometimes this takes a while and increasing start_delay makes it work better.

Ah, ok, that makes sense. I'm running everything locally, so it's not as much of an issue for me for the start_delay. Overall, though, the tool has been amazing in fixing the major problem I'd been having, which is that Sonarr and Radarr would import the files before they were totally done extracting, so I had to re-import the files after finding out (much later) that they were broken.

The *arr apps should only attempt to import when your download client makes the transfer as done. Do you know why they would import prematurely? It's not clear how this app will fix that.

I have no idea, but they were doing it constantly. Since setting this up, I haven't had that problem.

Interesting. Glad it's working out! :)

Yeah. New question: is there anyway to copy certain extra files, specifically the .nfo and .srr files into wherever the mkvs are being extracted so they get pulled in at the same time?

unpackerr moves every file it unpacked from a rar file back into the folder it unrar'd from, unless there is an existing file it may refuse to overwrite.

I'm seeing it do that for some things, but not all season packs, which is odd. Here's what one looks like right now:
offspring@CloudSeedbox:/mnt/local/downloads/torrents/rutorrent/completed/sonarr4k/Bloodline.S02.2160p.WEBRip.X264-DEFLATE$ ls
Bloodline.S02E01.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E01.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E02.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E02.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E03.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E03.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E04.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E04.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E05.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E05.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E06.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E06.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E07.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E07.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E08.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E08.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E09.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E09.2160p.WEBRip.X264-DEFLATE.mkv
Bloodline.S02E10.2160p.WEBRip.X264-DEFLATE
Bloodline.S02E10.2160p.WEBRip.X264-DEFLATE.mkv
_unpackerred

If I then go into the first folder, for example,
bloodline.s02e01.2160p.webrip.x264-deflate.nfo
bloodline.s02e01.2160p.webrip.x264-deflate.r00
bloodline.s02e01.2160p.webrip.x264-deflate.r01
bloodline.s02e01.2160p.webrip.x264-deflate.r02
bloodline.s02e01.2160p.webrip.x264-deflate.r03
bloodline.s02e01.2160p.webrip.x264-deflate.r04
bloodline.s02e01.2160p.webrip.x264-deflate.r05
bloodline.s02e01.2160p.webrip.x264-deflate.r06
bloodline.s02e01.2160p.webrip.x264-deflate.r07
bloodline.s02e01.2160p.webrip.x264-deflate.r08
bloodline.s02e01.2160p.webrip.x264-deflate.r09
bloodline.s02e01.2160p.webrip.x264-deflate.r10
bloodline.s02e01.2160p.webrip.x264-deflate.r11
bloodline.s02e01.2160p.webrip.x264-deflate.r12
bloodline.s02e01.2160p.webrip.x264-deflate.r13
bloodline.s02e01.2160p.webrip.x264-deflate.r14
bloodline.s02e01.2160p.webrip.x264-deflate.r15
bloodline.s02e01.2160p.webrip.x264-deflate.r16
bloodline.s02e01.2160p.webrip.x264-deflate.r17
bloodline.s02e01.2160p.webrip.x264-deflate.r18
bloodline.s02e01.2160p.webrip.x264-deflate.r19
bloodline.s02e01.2160p.webrip.x264-deflate.r20
bloodline.s02e01.2160p.webrip.x264-deflate.r21
bloodline.s02e01.2160p.webrip.x264-deflate.r22
bloodline.s02e01.2160p.webrip.x264-deflate.r23
bloodline.s02e01.2160p.webrip.x264-deflate.r24
bloodline.s02e01.2160p.webrip.x264-deflate.r25
bloodline.s02e01.2160p.webrip.x264-deflate.r26
bloodline.s02e01.2160p.webrip.x264-deflate.r27
bloodline.s02e01.2160p.webrip.x264-deflate.r28
bloodline.s02e01.2160p.webrip.x264-deflate.r29
bloodline.s02e01.2160p.webrip.x264-deflate.r30
bloodline.s02e01.2160p.webrip.x264-deflate.r31
bloodline.s02e01.2160p.webrip.x264-deflate.r32
bloodline.s02e01.2160p.webrip.x264-deflate.r33
bloodline.s02e01.2160p.webrip.x264-deflate.r34
bloodline.s02e01.2160p.webrip.x264-deflate.r35
bloodline.s02e01.2160p.webrip.x264-deflate.r36
bloodline.s02e01.2160p.webrip.x264-deflate.r37
bloodline.s02e01.2160p.webrip.x264-deflate.r38
bloodline.s02e01.2160p.webrip.x264-deflate.r39
bloodline.s02e01.2160p.webrip.x264-deflate.r40
bloodline.s02e01.2160p.webrip.x264-deflate.r41
bloodline.s02e01.2160p.webrip.x264-deflate.r42
bloodline.s02e01.2160p.webrip.x264-deflate.r43
bloodline.s02e01.2160p.webrip.x264-deflate.r44
bloodline.s02e01.2160p.webrip.x264-deflate.r45
bloodline.s02e01.2160p.webrip.x264-deflate.r46
bloodline.s02e01.2160p.webrip.x264-deflate.r47
bloodline.s02e01.2160p.webrip.x264-deflate.r48
bloodline.s02e01.2160p.webrip.x264-deflate.r49
bloodline.s02e01.2160p.webrip.x264-deflate.r50
bloodline.s02e01.2160p.webrip.x264-deflate.r51
bloodline.s02e01.2160p.webrip.x264-deflate.r52
bloodline.s02e01.2160p.webrip.x264-deflate.r53
bloodline.s02e01.2160p.webrip.x264-deflate.r54
bloodline.s02e01.2160p.webrip.x264-deflate.r55
bloodline.s02e01.2160p.webrip.x264-deflate.r56
bloodline.s02e01.2160p.webrip.x264-deflate.r57
bloodline.s02e01.2160p.webrip.x264-deflate.r58
bloodline.s02e01.2160p.webrip.x264-deflate.r59
bloodline.s02e01.2160p.webrip.x264-deflate.r60
bloodline.s02e01.2160p.webrip.x264-deflate.r61
bloodline.s02e01.2160p.webrip.x264-deflate.r62
bloodline.s02e01.2160p.webrip.x264-deflate.r63
bloodline.s02e01.2160p.webrip.x264-deflate.r64
bloodline.s02e01.2160p.webrip.x264-deflate.r65
bloodline.s02e01.2160p.webrip.x264-deflate.r66
bloodline.s02e01.2160p.webrip.x264-deflate.r67
bloodline.s02e01.2160p.webrip.x264-deflate.r68
bloodline.s02e01.2160p.webrip.x264-deflate.r69
bloodline.s02e01.2160p.webrip.x264-deflate.r70
bloodline.s02e01.2160p.webrip.x264-deflate.r71
bloodline.s02e01.2160p.webrip.x264-deflate.r72
bloodline.s02e01.2160p.webrip.x264-deflate.r73
bloodline.s02e01.2160p.webrip.x264-deflate.r74
bloodline.s02e01.2160p.webrip.x264-deflate.r75
bloodline.s02e01.2160p.webrip.x264-deflate.r76
bloodline.s02e01.2160p.webrip.x264-deflate.r77
bloodline.s02e01.2160p.webrip.x264-deflate.r78
bloodline.s02e01.2160p.webrip.x264-deflate.r79
bloodline.s02e01.2160p.webrip.x264-deflate.r80
bloodline.s02e01.2160p.webrip.x264-deflate.r81
bloodline.s02e01.2160p.webrip.x264-deflate.r82
bloodline.s02e01.2160p.webrip.x264-deflate.r83
bloodline.s02e01.2160p.webrip.x264-deflate.rar
bloodline.s02e01.2160p.webrip.x264-deflate.sfv

So for some reason unpackerr didn't move the files back to the root folder, but instead left them up one directory.

You'll need to share logs for me to understand what happened. Please be specific about the problem. "didn't move the files back to the root folder" is not specific enough for me to understand the issue you're having. Which files do you expect it to move, and to which folder? Please provide the logs so I know what it did.

Sure. I expected the tool to move the .rar files back to the folder with its name, as you said it should do. What I mean by that is: I expected the .mkv files to be moved from the root folder of Bloodline.S02.2160p.WEBRip.x264-DEFLATE back to their proper folders, which is what you said it would do previously. So the .mkv files should not be in the Bloodline.S02.2160p.WEBRip.x264-DEFLATE folder, but rather in each of the episodic folders such as Bloodline.S02E01.2160p.WEBRip.x264-DEFLATE, Bloodline.S02E02.2160p.WEBRip.x264-DEFLATE, etc.
The logs are 19 megs, since I've been running with debug since I got it setup. Let me figure out where the important section is and parse it down so that there's not a ton of extraneous data.

I expected the tool to move the .rar files

The tool does not move rar files. It only moves files that were inside the rar files; such as an mkv file. I would expect the mkv files to be moved into the same folder as the rar files, but now I'm wondering if you're using the folder feature instead of the sonarr probe. The folder feature may work differently with nested sub folders.
Did you set this up with a folder watcher, or are you probing Sonarr?

I still have the unedited log, it's just 19 megs tarred, and like 250 megs unpacked so I didn't want to hammer a system with that much data. I didn't restart the app, at all. I just let it run.
No, 9 hours seems...insane...for 237gb.
The fix was simply to create a symlink for Sonarr to find the files and then import them, since I had moved the folder at one point prior to the download completing so that it would properly be imported by Sonarr.

tbf, it extracted like 30 others things in that 9 hours... haha
Can you look in your bash history for that symlink command you used?
Can you grep -iE 'error|bloodline' unpackerr.log > new.log and send me that zipped up? My email will take files up to 20mb; my address is in my first reply on this thread.

The symlink command was
ln -s /mnt/local/downloads/torrents/rutorrent/completed/sonarr4k/Bloodline.S02.2160p.WEBRip.X264-DEFLATE/ .

Log file e-mailed.

These logs are great, thank you! What is parallel set to?
grep -i parallel unpackerr.log if you don't mind!

offspring@machine:/opt/unpackerr$ grep -i parallel unpackerr.log
2020/11/22 01:26:28  => Parallel: 1
2020/11/22 01:48:10  => Parallel: 1
2020/11/22 01:49:29  => Parallel: 1
2020/11/22 01:50:15  => Parallel: 1
2020/11/22 01:55:01.869529 logs.go:106:  => Parallel: 1
2020/11/22 02:05:13.760454 logs.go:106:  => Parallel: 1
2020/11/22 02:05:38.719733 logs.go:106:  => Parallel: 1
2020/11/22 10:58:06.304475 logs.go:106:  => Parallel: 5
2020/11/22 16:46:12.895560 logs.go:106:  => Parallel: 5

whew. I was sure hoping you set parallel higher than 1, or there was yet another bug.
So, you've found a bug, but I'm not sure the bug you found - that worries me - is the same problem you originally reported.
There is a second "display-only" bug in the Renamed Temp File log line. The two paths are always printed the same, this really confused me for a while. (fixed)
Your original report was that files were not being moved back into "the correct folder."
The bug you found seems to be triggered when the connection to an *arr app is lost. Here's how it was trigged:

Extraction begins.
A connection to Sonarr fails. This "empties" the internal queue.
When the queue was emptied this item was marked imported even though it was still extracting. (fixed)
Another connection to Sonarr succeed and the item came back.
The item was immediately reset, re-queued, and began extracting a second time.
This process repeated a 3rd time and the app extracted all 10 files 3 times each for 30 total extractions over a ~10 hour period.
Since you had parallel set to 5, other items extracted during this time as well.

Overall, despite the weird behavior, it looks like it worked and copied the mkv files back into the root Bloodline.S02.2160p.WEBRip.X264-DEFLATE folder.
Questions:

In which folder did you find the extracted mkv files?
Did Sonarr import them automatically? [doesn't seem like it did]

I re-read your original messages and I now know what is going on. I think this is a bug in Sonarr and it should import the mkv files from the root folder. @austinwbest - What do you think?

Unpackerr actually didn't move the files, I did. Then no, Sonarr didn't import them, I had to manually do it through the Sonarr UI. The extracted files were in the root Bloodline.S02.2160p folder, rather than the individual episodic subfolders.

Yup, it's currently designed to put all extracted things into that root folder. When I wrote this, I was trying to grab subs I subs/ folders and stuff. I didn't anticipate seasons/episodes like that, and so far it's never come up. I made a lot of changes to the xtractr library to deal with this, and I have to do a good bit of testing to make sure I didn't break anything.
Appreciate you working with me to figure this out!

No worries, like I said I really like the tool and it's worked out for my needs. Finding bugs is kind of a thing I used to do professionally, and as you can tell, I still find them for fun with other projects.

I posted a new beta release. The docker tag is almost done building and the binaries/package should be available within an hour or so. Give it a try if you're adventurous.

I re-read your original messages and I now know what is going on. I think this is a bug in Sonarr and it should import the mkv files from the root folder. @austinwbest - What do you think? See this comment. I feel like that's something Sonarr should import.
EDIT: This is not a situation I've seen before, and I'm puzzled. Looking at my code, it's always behaved this way, and changing it a good bit of work. I think it's a good change though and I'll work on it.

Are you referring to the queue being empty? That happens on a restart & takes a minute (literally) to repopulate. It's the monitored downloads task. You can get around it but not without an extra api call

Yup, it's currently designed to put all extracted things into that root folder. When I wrote this, I was trying to grab subs in subs/ folders and stuff. I didn't anticipate seasons/episodes like that, and so far it's never come up. I made a lot of changes to the xtractr library to deal with this, and I have to do a good bit of testing to make sure I didn't break anything.
Appreciate you working with me to figure this out!

Seems you have sorted it out but yea, that is a problem. If the rar files are inside folders then they would have to be extracted to that folder for *arr to find them.

Running the new version, it seems to constantly be restarting the docker container, and for some reason it only starts to unpack the Lion King movie, then stop. When I looked at the file itself, it was like 580kb. I was able to manually extract it and Radarr imported the file, but still odd. Here's the log: https://mactaggart.eskimomafia.com/selif/unpackerr.log

It's crashing it seems, and the crash isn't in the logs, it'll be in the console (docker logs <container id>).
Try the master docker tag.

2020/11/25 20:29:28.274273 handlers.go:133: Extraction Started: The.Lion.the.Witch.and.the.Wardrobe.1979.iNTERNAL.DVDRip.XviD-8BaLLRiPS, items in queue: 0
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x7f6dd1]
goroutine 24 [running]:
github.com/davidnewhall/unpackerr/pkg/unpackerr.(*Unpackerr).sendWebhooks(0xc000108440, 0xc000076320)
/unpackerr/pkg/unpackerr/webhook.go:91 +0x321
github.com/davidnewhall/unpackerr/pkg/unpackerr.(*Unpackerr).updateQueueStatus(0xc000108440, 0xc00009cdd8, 0x2a)
/unpackerr/pkg/unpackerr/folder.go:344 +0x19a
github.com/davidnewhall/unpackerr/pkg/unpackerr.(*Unpackerr).handleXtractrCallback(0xc000108440, 0xc0001302c0)
/unpackerr/pkg/unpackerr/handlers.go:134 +0x540
github.com/davidnewhall/unpackerr/pkg/unpackerr.(*Unpackerr).Run(0xc000108440)
/unpackerr/pkg/unpackerr/start.go:175 +0x289
created by github.com/davidnewhall/unpackerr/pkg/unpackerr.Start
/unpackerr/pkg/unpackerr/start.go:127 +0x6f7
2020/11/25 20:29:28.283801 start.go:111: Unpackerr v0.7.2-beta6- Starting! (PID: 2322) 2020-11-25 20:29:28.283786399 +0300 EEST m=+0.001436984

Perfect thanks. Fixed in master.

I cut a beta7 release which should work. I've been running it all night and seems fine so far. Once Travis-CI decides to build it, there will be files added to the release. For now, you can use the docker tag to get it (Docker builds a lot faster than Travis).
Question: DO you use Qbitorrent? If not, what is your download client?

Nope. rTorrent with the ruTorrent webui.

What version of sonarr? v0.2 or v3?

Sonarr is v3, Radarr is v2 and v3 depending on FullHD or 4K.

A working beta version is available now. Please try it out and let me know how it works out for you. https://github.com/davidnewhall/unpackerr/releases/tag/v0.7.2-beta7
On docker: docker pull golift/unpackerr:0.7.2-beta7

Grabbed and pulled/running. Will probably need to wait til tomorrow to find another pack to test against, but it shouldn't take long.

For sure, I tried to find a few folks to test. it takes time for this thing to do stuff...

heh true, but it's more that it's just past midnight here so when I wake up I'll go searching for some packs to screw with.

That was the wrong click. Whoops.

Here's a log from today: https://mactaggart.eskimomafia.com/selif/unpackerr1.log. I was able to test a pack, and it worked, but individual files are causing it to break.

Is this still related to sonarr & individual episodes not being imported? If so can you enable trace in sonarr, clear the logs, hit the refresh downloads task & attach the log?
I also highly recommended v3 for sonarr

Yeah, it is. I'm already using Sonarr v3. It's Radarr that I'm mixing/matching.

Gotcha, well throw a sonarr log up there and I'll see if I can help

So looking at the logs, and my services I think this case it's not specifically Sonarr causing issues. Looks like unpackerr extracted a movie into the Subs/ directory, and that's causing stuff to be stuck in "Pending Import". I'm running Sonarr with trace watching the logs fly past but haven't seen anything stick out related to that.

Relevant logs:
2020/11/26 13:59:11.038083 handlers.go:133: Extraction Started: Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW, items in queue: 0
2020/11/26 13:59:11.038152 queue.go:211: [DEBUG] Extracting File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/snow-toy.story.of.terror.2013.1080p.bluray.x264.rar to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred
2020/11/26 13:59:31.697278 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/_unpackerred to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/_unpackerred: (refusing to overwrite existing file)
2020/11/26 13:59:31.697376 files.go:162: [DEBUG] Renamed Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.mkv -> /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/snow-toy.story.of.terror.2013.1080p.bluray.x264.mkv
2020/11/26 13:59:31.697397 queue.go:211: [DEBUG] Extracting File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/snow-toy.story.of.terror.2013.1080p.bluray.x264.rar to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred
2020/11/26 13:59:32.454571 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/_unpackerred to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/_unpackerred: (refusing to overwrite existing file)
2020/11/26 13:59:32.454619 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.sub to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/snow-toy.story.of.terror.2013.1080p.bluray.x264.sub: (refusing to overwrite existing file)
2020/11/26 13:59:32.454628 queue.go:211: [DEBUG] Extracting File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/snow-toy.story.of.terror.2013.1080p.bluray.x264-subs.rar to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred
2020/11/26 13:59:32.611566 queue.go:211: [DEBUG] Extracting File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.rar to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred
2020/11/26 13:59:32.880778 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/_unpackerred to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/_unpackerred: (refusing to overwrite existing file)
2020/11/26 13:59:32.880820 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.idx to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/snow-toy.story.of.terror.2013.1080p.bluray.x264.idx: (refusing to overwrite existing file)
2020/11/26 13:59:32.880835 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.rar to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/snow-toy.story.of.terror.2013.1080p.bluray.x264.rar: (refusing to overwrite existing file)
2020/11/26 13:59:32.880850 files.go:148: Error: Renaming Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.sub to /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/Subs/snow-toy.story.of.terror.2013.1080p.bluray.x264.sub: (refusing to overwrite existing file)
2020/11/26 13:59:33.067180 files.go:183: Deleted (recursively): /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred
2020/11/26 13:59:33.067232 handlers.go:139: Extraction Finished: Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW => elapsed: 22s, archives: 3, extra archives: 1, files extracted: 8, wrote: 1518MiB

Every line had an error (odd that all the extracted files already existed), except this one:
Renamed Temp File: /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW_unpackerred/snow-toy.story.of.terror.2013.1080p.bluray.x264.mkv -> /downloads/completed/radarr/Toy.Story.Of.Terror.2013.1080p.BluRay.x264-SNOW/snow-toy.story.of.terror.2013.1080p.bluray.x264.mkv

That looks to me like the movie was copied into the correct path. What is the message in Sonarr about why it wont import?
It then "goes away and comes back" (which could mean the connection to sonarr was interrupted. This triggers it to extract again. I think that is a minor bug I can fix on my end, so it wont extract again after it already did successfully.
There are a lot of logs here. What's the name of the pack you saw it put a movie into Subs/?

You can jump in my discord. This thread is getting long, Might be easier to finish this off in a chat session. https://discord.gg/tVMPw6mCZw
I'll be around later after I stuff myself with dead birds and mushy bread.

Sure thing. I just finished myself with dead birds and mashed taters.


[Bug]: Width of Label should not change when a non-integer value is entered

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Even though we get an error when we enter a non-integer number in the Width (in columns) property of a widget the width of the label still changes as per the value.
https://www.loom.com/share/84a4cc8b8117472eb8c96db0f0b1aef1
Note: This bug is present in all widgets that have a label.
Steps To Reproduce

D&D a Select widget.
In the Width (in columns) property enter a non-integer value.

Public Sample App
No response
Version
Cloud

Stats

Stat
Values

Reach
265.1

Effort (months)
0.5


MySQL should not be required to run tests

The test_standalone.py script executes tests against a sqlite database.  However, MySQL is required for two reasons:
MYSQL-python is listed in the requirements.txt, and this won't install without mysql_config installed on the system (e.g. via brew install mysql)
The ratechecker/management/commands/load_daily_data.py management command imports _mysql_exceptions, which causes tests to fail unless the MySQL stack is installed.

@m3brown This has been fixed in https://github.com/cfpb/owning-a-home-api/pull/76
Please let me know if there's any other questions.


bpf,test: Fix verifier issues in IPv6 BPF tests when running locally

When running the TestBPF/ipv6_test.o test locally with clang v13 and kernel v5.17 it resulted in the following verifier error:
171: (b7) r2 = 1                      ; R2_w=inv1
; authhdr->seq = 1;
172: (63) *(u32 *)(r1 +8) = r2
invalid access to packet, off=8 size=4, R1(id=6,off=8,r=2)
R1 offset is outside of the packet

Tracked this down to ipv6_with_hop_auth_tcp_pktgen. It gets a pointer
from pktgen__append_ipv6_extension_header. All expected bounds checks
were in place. It even has a function called ctx_data_valid with some
inline assembly which is supposed to perform additional bounds checks.
Was able to fix this by replacing ctx_data_valid with a normal check
and adding a bounds check to ipv6_with_hop_auth_tcp_pktgen. This
bounds check seems to be necessary because bounds checks do not seem
to apply to copies.
The verifier log reveals the following:
85: (69) r2 = *(u16 *)(r10 -40)       ; R2_w=invP14 R10=fp0
; builder->layer_offsets[layer_idx] = builder->cur_off;
86: (6b) *(u16 *)(r4 +10) = r2        ; R2_w=invP14 R4_w=fp-44 fp-40=mmmmmmmm
; layer = ctx_data(ctx) + builder->cur_off;
87: (0f) r1 += r7                     ; R1_w=pkt(id=0,off=14,r=54,imm=0) R7=invP14
; builder->cur_off += hdrsize;
88: (69) r2 = *(u16 *)(r10 -40)       ; R2_w=inv(id=0,umax_value=65535,var_off=(0x0; 0xffff)) R10=fp0

At instruction 85 we know the offset is 14 exactly. It is then written
back to the stack. And at 88 we have lost bounds data. Since this is
an offset we use to construct the pointers, this uncertainty becomes
part of all pointers causing the need for additional checks.
To mitigate the result of the above apparent verifier bug/limitation,
I have also changes our offset value from 16 bit to 64 bit which tracks
better.
Fix verifier issues in IPv6 BPF tests

I fixed CI by using __u64 offsets everywhere so the verifier has an easier time keeping track these values.

/test

We appear to be hitting flake #24961

/test-1.25-4.19

Marking for backports to v1.12 and v1.13 as otherwise https://github.com/cilium/cilium/pull/25699 fails there with the above verifier error.


Can't enable/disable Teleportation System in scripting

Describe the bug
I have been trying to disable the teleportation system on a button press:
CoreServices.TeleportSystem.Disable();
but for some reason, the system stays enabled.
To reproduce

Create a scene with teleportation enabled
Add "CoreServices.TeleportSystem.Disable();"in the start() function of a new script that is present in the scene.
Play the scene and you'll notice that the Teleportation system is still enabled.

Expected behavior
The teleportation system should have been disabled.
Your setup (please complete the following information)

Unity Version [2019.3.0f1]
MRTK Version [v2.2.0]

Target platform

WMR immersive

This issue still exists.

Still exist in v2.5. Any Updates On this?   I am unsure how to implement the workaround that was mentioned. Can you someone Explain if further?

I'm experiencing this issue as well using MRTK v2.6.1 and Unity 2019.4.25f1.

Here's a suggested workaround:
When you need to disable the teleportation system, have a script change the layer of all the teleportation hot-spots / surfaces in your environment to a layer other than the one you've defined as valid for teleportation.
This won't prevent the teleportation arc / beam from being displayed when the user makes the hand gesture... but it will prevent them from teleporting.

Any update on this issue? Thanks

This issue is still valid in v2.7.2

@kapitanmliko The solution we found was to get GameObject.FindObjectsOfType(); and then disable it.

The temporary solution I found was to disable all colliders in "SceneContent" children (Empty GameObject that contains all the assets that make up the scene).
foreach (var all in SceneContent.GetComponentsInChildren<Collider>())             {                 all.enabled = false;             }
Doesn't disable the teleport system entirely, but prevents the player for teleporting.
It was really simple to implement so I hope it can be of help!

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


[chore] Circle ci update

Move from old legacy circleci repo to cimg
Bump node img version to 16.5.0

does circleci add anything beyond GitHub actions? could we ditch this altogether?
if Android job isn't running, I'd like to get rid of the job
if Android job isn't running, do we still need to install rust?

does circleci add anything beyond GitHub actions? could we ditch this altogether?
if Android job isn't running, I'd like to get rid of the job
if Android job isn't running, do we still need to install rust?

@vsubhuman has a plan to remove the ci pipeline from dev we will keep it only for releases probably, but that is not covered in this PR.
There is no longer the android job in ci.


ripple ：Modify the field #1023

Checklist

[x] Fix linting errors
[x] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #1025 (3b43859) into dev (dd6d31f) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##              dev    #1025   +/-   ##
=======================================
  Coverage   95.96%   95.96%
=======================================
  Files         325      325
  Lines       21263    21263
  Branches     1412     1412
=======================================
  Hits        20405    20405
  Misses        812      812
  Partials       46       46

Impacted Files
Coverage Δ

packages/varlet-ui/src/ripple/index.ts
98.87% <100.00%> (ø)


Improve on_build, on_build_file and on_xxx for target and rule

Improve on_build in target/rule
We can call original build script:
on_build(function (target, opt)
    opt.origin(target, opt)
end)

Add before/after/on_build_file in target
before_build_file(function (target, sourcefile, opt)
end)

on_build_file(function (target, sourcefile, opt)
    opt.origin(target, sourcefile, opt)
end)

after_build_file(function (target, sourcefile, opt)
end)

Add before/after/on_build_files in target
before_build_files(function (target, sourcebatch, opt)
end)

on_build_files(function (target, sourcebatch, opt)
    opt.origin(target, sourcebatch, opt)
end)

before_build_files(function (target, sourcebatch, opt)
end)

#261

Documents: https://xmake.io/#/zh/manual?id=targeton_build_file


Update Smoke CO Alarm Implementation

Main updates are as follows:

Add GetExpiryDate function to accommodate cluster changes.
Add the conflict handling of DeviceMuted and Critical alarms.
Add emberAfHandleEventTrigger function and build description for manufacturer testing.

Refactor the underlying code of ExpressedState.
Add timer to simulate self-test.
Add manual self-test.


App icon shows cordova icon

I followed the the steps mentioned in icons_splash_screens.md
Added icon.png in res/android/default & res/ios/default
Added below line in config.xml [I am only building app for android]
<platform name="android">
  <icon src="res/android/default/icon.png" />
</platform>

Run below command
gulp --cordova "run android"
But the app icon in mobile is cordova icon
I have also tried to remove platform and add it again but it didn't work
Below is more detail
OS: Ubuntu 15.10
node : v4.6.0
npm: 3.10.8
cordova: 6.0.0,
gulp: 3.9.0

Hi
Put your icon and pad in resources folder in root of ionic app. Then run following command
Ionic resources.
Automatically icons will be generated and for iOS and android with all configurations required.
For more info
http://ionicframework.com/docs/cli/icon-splashscreen.html
I hope it helps.
Thanks
Kunal

Thanks Kunal
Your solution didn't work for me. I am using generator-m-ionic for app development
Using command ionic resources --icon shows error message Couldn't find ionic.config.json file. Are you in an Ionic project?
Thanks
Keval

Hi
Which version of iconic you are using? Yes We have to run command in ionic project. And it seems you are using ionic 2. So you need to add config file. Please use this app as reference for app structure except for src folder.
https://github.com/driftyco/ionic-conference-app?files=1
Let me know
Thanks.
Kunal

@codestorycooked
I am using ionic 1.3.2

Even if you using ionic 1 you require ionic.config.json as you must have update ionic cli.

icons_splash_screens.md doesn't mention anything like that.
In my other ionic project it works as you have mentioned, but in my current project I am using generator-m-ionic & I have followed steps mentioned in it to replace default icons
Thanks.

hey @codestorycooked and @kevalmalde!
You don't have to run the ionic splash screen generator and you don't need to have an ionic project.
Although it makes things easier if you are not familiar with icons and splash screens.
Because ionic does the icon generation and injects the xml code.
You can do it manually, but you have to add the specific resolutions and stuff:
See this cordova guide for more information on it.
https://cordova.apache.org/docs/en/6.x/config_ref/images.html#android
Sorry for the confusion with our icons guide, we will think about an update there.


fix pick output filename windows

Description
Resolves #17005
Use FileFunctions::Basename so that path is stripped off correctly.
Type of change

[X] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Other

Checklist:

[X] I have followed the style guidelines of this project.~~
[X] I have performed a self-review of my own code.~~
[X] I have commented my code where applicable.~~
[X] I have updated the release notes.~~
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
[X] I have confirmed new and existing unit tests pass locally with my changes.~~
- [ ] I have added new baselines for any new tests to the repo.
[X] I have NOT made any changes to protocol or public interfaces in an RC branch.~~
[X ] I have assigned reviewers (see VisIt's PR procedures for more information).~~

The release notes were updated.

Looks like I had forgotten to push the update of release notes. Should show up now.

Sorry...I thought I had selected approved when I made that initial review comment. I am trying to get in the practice of if I find something small, approving but also raising a question instead of withholding approving. So, that probably read straing that I had no opinion one way or the other but didn't approve.

You did approve. My push of the release notes erased your approval.


Should samples mimic the specflow samples?

Specifically, should the samples here mimic: https://github.com/techtalk/SpecFlow-Examples/tree/master/ASP.NET-MVC/BookShop but with dnx451 / dnx46?
Note, we should probably ask the TechTalk guys if we decide to provide a DNX version of their samples.

My initial reaction is "whoa, that looks like a helluvalotta work", which roughly translates to "umm, no...?".
But srsly, I'm not sure we need to go in to that level of detail. I think it's enough if these samples show that glue files are generated from feature files, and leave the official examples to show more complex SpecFlow usage.
You could try chatting to the TechTalk guys, and happy to take a PR but seems like a lot of work for a hopefully short-lived project!

I don't think it would be all that much work because we can almost copy/paste everything and then ""simply"" wire in dnx. However, I'm happy to skip it.
I'm not up to date on how the official repo is doing with regards to dnx compatibility, I should probably go do some research. Am I correct in thinking it will happen as part of their v2 work?
Maybe the effort would be better spent seeing what can be done to help them out.

Yeah, I think that's a better plan; at least the effort should be around longer than this project. I'm not 100% sure on what's in v2, but there is a separate repo for the extension that I've been meaning to investigate, but time...
Let me know what your research uncovers.

Scanning over the issues, commits, branches, and SpecFlow.VisualStudio repo which I believe you were referring to, I basically got nowhere. I need to get home and test all the pieces together which will involve getting them to build and hooking up to the ci nuget feed. I'll let you know how I get on.
I've also hopped onto the google group and asked the v2.0 branch fella if he knows where we stand on DNX and what we can do to help. To be honest, the repo is a bit of a mess with regards to issue and roadmap management.

I don't think there is any appetite for this right now, so closing.


Add text/links for each point?

This is really awesome stuff.
I wanted to utilize this but wanted to append text around each point to illustrate a web of ideas. Is there a way to do this?

Hi Phil, thanks for you kind words, and sorry for the late reply!
Unfortunately the plugin doesn't support text for now. It could be a good feature :+1:

Hi @VincentGarreau, particle.js is wonderful. It could be a nice tool if you can add this feature, i.e. "random words".


Confidential Transactions

This is a draft DIP for adding Confidential Transactions (CTs) to Dash. I would like to request a DIP number be assigned.
Any and all feedback is welcome, including suggestions for a base58 prefix for CT addresses.

@UdjinM6 @PastaPastaPasta I believe recent updates to the DIP have addressed all your review comments, so I am requesting another review

also, it was not mentioned in review but since this DIP changes Consensus rules I changed the DIP Type to Consensus


Add CAN nodes for STM32H7 series

Each STM32H7 Series chip contains 2 or 3 FDCAN controllers.
(https://www.st.com/en/microcontrollers-microprocessors/
stm32h7-series.html)

Thank you for the addition!
Did you test this on a board?
I was told that there are modifications requited for the h7 series.

Did you test this on a board?
Just tried with new board. Unfortunately, unsuccessful:

zephyr/drivers/can/can_stm32fd.c:52:29: error: 'LL_RCC_FDCAN_CLKSOURCE_PCLK1' undeclared (first use in this function); did you mean 'LL_RCC_FDCAN_CLKSOURCE_PLL1Q'?

I will be glad for any suggestion, it's critical for me to run CAN on STM32H7
My DTS node:
&can1 {
	pinctrl-0 = <&fdcan1_rx_pa11 &fdcan1_tx_pa12>;
	pinctrl-names = "default";
	bus-speed = <125000>;
	bus-speed-data = <1000000>;
	sjw = <1>;
	sjw-data = <1>;
	prop-seg = <0>;
	phase-seg1 = <6>;
	phase-seg2 = <5>;
	status = "okay";
};

@Delsian does it work now on your board?

Set as DNM to avoid merge before we have a proof that it's working

@alexanderwachter yesterday I got info from the factory: my hardware delays until the middle of January. So, maybe guys from ST (or anybody else) can test if they have boards with FDCAN?

@Delsian I think you will at least need the following PR:
https://github.com/zephyrproject-rtos/zephyr/pull/41328

@Delsian I think you will at least need the following PR: #41328

Yes, thank you!

my hardware delays until the middle of January. So, maybe guys from ST (or anybody else) can test if they have boards with FDCAN?

@Delsian If you're pushing something on your own and for your need, the minimum would be that you are able to run it on your side. We can help for non regression or complementary testing when required, but a minimum basic functional testing is expected from the PR's author in any case.

I suggest moving this to draft state until the functionality has been tested on hardware.

@Delsian I have gotten CAN working on the STM32H7, checkout this PR: https://github.com/zephyrproject-rtos/zephyr/pull/41549

@JeremyBCD Thank you!


How to load existing downloaded dataset ?

Hi @mariosasko @lhoestq  @katielink
Thanks for your contribution and hard work.
Feature request
First, I download a dataset as normal by:
from datasets import load_dataset

dataset = load_dataset('username/data_name', cache_dir='data')

The dataset format in data directory will be:
-data
  |-data_name
    |-test-00000-of-00001-bf4c733542e35fcb.parquet
    |-train-00000-of-00001-2a1df75c6bce91ab.parquet

Then I use SCP to clone this dataset into another machine, and then try:
from datasets import load_dataset

dataset = load_dataset('data/data_name')  # load from local path

This leads to re-generating training and validation split for each time, and the disk quota will be duplicated occupation.
How can I just load the dataset without generating and saving these splits again?
Motivation
I do not want to download the same dataset in two machines, scp is much faster and better than HuggingFace API. I hope we can directly load the downloaded datasets (.parquest)
Your contribution
Please refer to the feature

Feel free to use dataset.save_to_disk(...), then scp the directory containing the saved dataset and reload it on your other machine using dataset = load_from_disk(...)


Extract Error

I've encountered the following error:
C:\Users\migeo\Music\download>youtube-dl.exe -F https://www.youtube.com/watch?v=PgzuOXKd6Sg&list=PL6MzJecijvlhFQVF52VDXexjmwZQpFMfq&index=14
[youtube] PgzuOXKd6Sg: Downloading webpage
[youtube] PgzuOXKd6Sg: Downloading video info webpage
[youtube] PgzuOXKd6Sg: Extracting video information
ERROR: Signature extraction failed: Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpaa64pv68\build\youtube_dl\extractor\youtube.py", line 1005, in _decrypt_signature
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpaa64pv68\build\youtube_dl\extractor\youtube.py", line 897, in _extract_signature_function
youtube_dl.utils.ExtractorError: Cannot identify player '/yts/jsbin/player-vflmgXZN3/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError("Cannot identify player '/yts/jsbin/player-vflmgXZN3/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
'list' is not recognized as an internal or external command,
operable program or batch file.
'index' is not recognized as an internal or external command,
operable program or batch file.
Not sure  what else I can say to help debug.

You are using an outdated version of youtube-dl. Read this FAQ entry if you have troubles updating.


v3 Table - Fractional pixellation

🐛 Bug Report
The left property of a table cell, if it results in a fraction, results in a pixel gap between some cells. For tables where isQuiet={true}, this show a noticeable gap depending on the background color, and when hovering over the cell.
For tables with isQuiet={false}, this doesn't happen in the table cells themselves, but it does in the header.
🤔 Expected Behavior
This could easily be resolved by changing the background color of the table's parent element, but then the issue is still apparent when hovering over a row, as the color is changed
😯 Current Behavior

🔦 Context
Best way to reproduce is in the 6 column table sandbox below.
💻 Code Sample
https://codesandbox.io/s/morning-waterfall-c62q6
To reproduce, you will likely need to resize the render window where the width of the table is an odd number. See screenshot of the result you're trying to achieve when resizing
Quiet table: Notice the vertical red line in the table

Non-quiet tables: the header (and even a few corner cells' border-radius and the right-most header cell) have gaps

🌍 Your Environment

@react-spectrum/table: 3.0.0-alpha.9
🧢 Your Company/Team
Adobe Analytics
🕷 Tracking Issue (optional)

Yep, I see that as well in your example. In particular, it appears to actually be the fractional width's.
There are two things we should try (I tried the usual zTransform(0) and translate(0, 0) to no avail)

use translate instead of absolute positioning (I think perf will be the same)
round widths and positions down to a whole number, this may be tricky though because we'll potentially need to round half of them up in response


Remove Material UI dependencies from Accordion and Accordion Group

Summary of changes:

The HTML structure of the component has been completely overwritten to match the current W3C design pattern for accordions. Now the component has two main parts: the Accordion Header (an h3 tag with a button inside) and the Accordion Panel (regular div for the custom content).
Accordion Group has also been updated, removing the Material selectors and replacing them for regular CSS.
Added accessibility attributes to the component, following the aria specifications of W3C.
Updated stories and Jest testing.

What do you think about adding hover, active and focus stories for accordion group?


ensure coverage for addTargetDependency with invalid input

This PR resolves https://github.com/apache/cordova-node-xcode/issues/74.

@brodybits Travis CI seems to be pokey today, but this should be good to go (verified by running stryker locally).


Exclude std::any from implicit conversion (fixes #3428)

Fixes #3428 (MSVC) and silences compiler warning on GCC (-Wconversion).

Thanks!


Improve ranking

After including package downloads within the search results, we noticed a very common problem with relevance. I believe it's caused by ignoring "js" and probably typo tolerance, and I wonder if there's a way to improve this. A few examples:

https://www-jsdelivr-com-pr-400.onrender.com/?query=vue
First match "vue" (correct), then "vue.js" (garbage), then "vuejs" (garbage, even marked as deprecated), then relevant vue-related packages.

https://www-jsdelivr-com-pr-400.onrender.com/?query=react
First match "react" (correct), then "reactjs" (garbage), then re-act (garbage), then relevant react-related packages.

https://www-jsdelivr-com-pr-400.onrender.com/?query=bootstrap
First match "bootstrap" (correct), then "bootstrapjs" (garbage).

I know that in some cases, it's the other way around and "package.js" is the correct popular name while "package" is garbage, so this isn't easy, but at the same time, npm has very often multiple packages with similar names, so this happens for the majority of searches. To get correct results, we'd need to allow the "relaxed" matching (js ignore and typos) only if a popular match isn't found.
I'm not sure how doable this is but one idea I got so far - maybe instead of ignoring "js" globally, only set the other version as alternate name for packages that seem relevant (downloads above some threshold, not deprecated, have readme, ...). Non-relevant packages wouldn't get this relaxed matching.

Technically I'm not sure how this could be done, but we could indeed have a certain download number threshold before adding alternative names maybe? That way at least those three examples would not show up anymore, it bothered me too.

just ordering by download should help no?

The problem is that custom ranking comes after word relevance, unless you mean resorting in the frontend @bodinsamuel

Downloads are already used as part of the ranking but as I understand they have lower priority than the match on project name, so they don't help here.
Something I'm not 100% sure about though - I would expect that "ignored words" apply only to whole words, not parts of them so in "vuejs" the "js" suffix would not be ignored. But based on the search results, it either is ignored even when it's a suffix (in which case my proposed solution would help) or it's some other algolia feature that makes this rank higher (in which case the threshold idea may not help).

The js is not an ignored word, but it's listed as an alternativeName, which is listed after the official name

Oh I see, I previously looked only at the index config but there's a whole bunch of logic that adds alternative names in the code. Than my previous suggestion stands - do this only if the package seems relevant based on other metadata.

deprecated should already show up lower according to ranking, but if you spell it correctly, it should still be the first result, as sometimes you would be looking for that.
I think we can add a certain popularity threshold before packages get alternative names. Will look into a PR

I agree you should get deprecated packages when spelled correctly but not sure about alternative names - there it's a similar problem that if the name is similar enough, deprecation has too low priority to push the result down. My idea was to use multiple attributes for this because downloads may not always be enough, e.g. add it only if all:

Is not deprecated.
Has 1k npm downloads or 10k jsDelivr downloads.
Has non-empty description field or a readme file or a source repository linked.

Any update on the reindex progress? Are we able to test the new attributes now?

yup sorry with all the holidays I did not had time to look into it.
What we did in the past is to pop a new instance that will create a new index and once it's ready swap the index.
I'll try to setup that today or tomorrow, full indexing takes more than a week.

Yes it's currently running ☺

NB: you can test what you want using the tmp index named npm-search-bootstrap-6 it will be renamed npm-search-6 at some point. And then will replace the main index.

The index doesn't use the newly added field yet because we wanted to test it first after all packages are updated (https://github.com/algolia/npm-search/commit/0e5194d3b9131a46e58e88d060e6f3c127f28f65) without affecting the main index. Considering the bootstrap runs in a separate index anyway, what would be the best course of action? I suppose we could update the config right away?

ah true, forgot about that. Since we did not merge, all manual changes will be erased after some time by the script so not good. We could merge the PR in master and do not deploy the main process

Awesome, it works really well! I tested all packages from my initial post here as well as those from comments in #951 and all of them return relevant results now.

@bodinsamuel @Haroenv ping, can we get this live, please? 😄

I'll merge 👌🏻

Also not sure if the indexes were swapped yet.

Applied on the main index 👍🏻

Awesome! https://twitter.com/jsDelivr/status/1552660335219429377


getLinesViewportData api in verticalObjects is returning range where start line and end line is not visible

verticalObjects.getLinesViewportData() returns the view lines data those are not visible in the current view port.

When a line is wrapped and is not visible completely on the top, Some times start line number value is the wrapped line # which is not visible.
End line number is always one number greater than visible end line

As a result, In Vim:

H and L commands seem to go to outside the view.

Closing this, since this is no longer an issue for VIM.

@sandy081 Opened #10934 to follow up