Styled html rendering

Html rendering should be based on styles.
A style should be defined by a set of css attributes used in rendering.
Perhaps an easy to use API to build the output.
Then we should have a default style, used for rendering and a magic which can change the style.

Commit: https://github.com/padreati/rapaio-jupyter-kernel/commit/7c112bc8d25bafe32df7a314008f012ec148479c
A draft start for this feature. I created an API which allows building html in a declarative safe way. It contains building blocks for styling, but there is a need to create at least some styles to be fully implemented.


parametrize extendedmodels loadmodel() API for url download

Can you please consider parametrizing the loadmodel() API in:
deepface/extendedmodels/Age.py
deepface/extendedmodels/Emotion.py
deepface/extendedmodels/Gender.py
deepface/extendedmodels/Race.py
So that the url for the package download can be overloaded like:
def loadModel(url = <default_url>):
This is along the same lines as the parameter that is already present in other loadModel() APIs like in DeepID.py / Facenet.py and so on.

Sure, it's going to be done in the next release.

This is handled in 0.0.52. It will be published soon.

Awesome, thanks !


Lapack 3.6.1

The pull request will import LAPACK 3.6.1. into OpenBLAS.
4 functions are added by the LAPACK team and many bugs are fixed.

While I do not feel competent to review, I am a bit worried how this meshes with previous individual changes to the OpenBLAS lapack-netlib subtree made since 3.6.0 - as a trivial but easy to check example your PR would appear to revert 8d652f1 ? (This is why I suggested to submit only the minimal necessary PR for #971 to get that accepted quickly)

I changed the nep.in file in order to fit the one created by 8d6552f1. Furthermore, I imported directory by directory an checked the makefiles if there are OpenBLAS related things in for examples the special tuned LAPACK routines like dgetrf provided by LAPACK. So the "main" makefile of LAPACK (lapack-netlib/SRC/makefile) only differs in the addition of the 4 new routines that exist in LAPACK 3.6.1.
I hope that helps.

Finally, I checked all changes that were done on LAPACK 3.6.0 since the import into OpenBLAS and applied them, if necessary.  Issue #971 is also fixed because this is not inlcuded in LAPACK 3.6.1.

Thank you, I will review this patch these days.

Based on a comment in #1019 is there anything I can do to speed the review of this PR?

I will check #1019 for integration in my pull request tomorrow.

@grisuthedragon I believe #1019 is already part of your PR as the fix is tagged 3.6.1 in the netlib repo.
So the answer to "anything I could do" would seem to be "clone xianyi" unfortunately. (And I still believe the point fix has a greater chance to be approved and committed on the fly than the whole of 3.6.1)

I checked for it and yes it is already in

Looks good for me. I merge this patch at first. Maybe we can test more in future.


Focus correct Combobox listbox option

When clicking on a Combobox listbox option:
1 focus event triggered (handlePillFocus): Focus changes to the active option (defaults to the first option)
2 click event triggered (handlePillClickSelectedListbox): Focus changes to the clicked option
In an extreme case when some options are offscreen, this causes the wrong option to be focused and brought into view during (1), and the clicked option is never focused.
This fix sets the correct active option during (1) so that focus always goes to the correct option.
Fixes https://github.com/salesforce/design-system-react/issues/2723

Is handlePillClickSelectedListbox still needed?

Is handlePillClickSelectedListbox still needed?

You're right, since click also focuses, there's no need to have that callback at all.

You're right, since click also focuses, there's no need to have that callback at all.


10/14/2022 PM Publish

PR Summary

PR Checklist

[ ] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[ ] Summary: This PR's summary describes the scope and intent of the change.
[ ] Contributor's Guide: I have read the contributors guide.
[ ] Style: This PR adheres to the style guide.

Learn Build status updates of commit 7f00175:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-8.3.0/upcoming-breaking-changes.md
:white_check_mark:Succeeded
View (azps-8.3.0)

docs-conceptual/azps-9.0.0/upcoming-breaking-changes.md
:white_check_mark:Succeeded
View (azps-9.0.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


HDRP support?

While recording in HDRP, the game view only shows the skybox, and the recorded file is 1kb.  Will there be HDRP support?

I'm thinking of adding SRP support but don't have time for it. At the moment, it's recommended to use Unity Recorder instead.

HDRP support was added in the latest version.
https://github.com/keijiro/FFmpegOut/releases/tag/v1.0.0

I'm closing this issue. Please feel free to reopen for further questions.


Initial sdk

Implementation of https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker/issues/20
Aimed for feature parity with the python SDK, but I took some different paths:

auto-generated the web calls using the open api definition
used function parameters instead of TestRun class

Still to do:

[ ]  codacy integration
[ ] release 4.7.0 nuget package
[ ] update examples with final nuget package

@pashidlos Ready for you to have a look now.
I don't have permission to add the repo to coday. Do you mind adding it and setting up the github secret? Then I can address the inevitable issues that codacy finds ;)

@dcrowe let me try run it locally )

repo added to Codacy
secret is now set up

Thanks. I should be able to knock off the codacy feedback pretty quick.

I also had to make a few more changes to openapi description for things to work. Are you able to see if they can be fixed in the backend?
The null userId response seems particularly suspect. I haven't dug into it, but I would have expected this field to always be populated?
I'm running VRT 4.6.0
See: https://github.com/Visual-Regression-Tracker/sdk-dotnet/pull/1/commits/18cc55b86d8eda9b51c89c3604ec45ab0b0c14ce#diff-13b5a249042f8ca10c2aa7122e238c9fc62122722b7ce0f8580673284c803126

I also had to make a few more changes to openapi description for things to work. Are you able to see if they can be fixed in the backend?
The null userId response seems particularly suspect. I haven't dug into it, but I would have expected this field to always be populated?
I'm running VRT 4.6.0
See: 18cc55b#diff-13b5a249042f8ca10c2aa7122e238c9fc62122722b7ce0f8580673284c803126

field is empty right now, will use it in future to know whos api key was used to start build
so far it's always null but it still missing proper swagger annotation
here is updated version
updated openapi schema

openapi: 3.0.0
info:
  title: Visual Regression Tracker
  description: API Documentation
  version: '1.0'
  contact: {}
tags: []
servers: []
components:
  securitySchemes:
    bearer:
      scheme: bearer
      bearerFormat: JWT
      type: http
    api_key:
      type: apiKey
      in: header
      name: apiKey
      description: API Key For External calls
  schemas:
    CreateUserDto:
      type: object
      properties:
        email:
          type: string
        password:
          type: string
        firstName:
          type: string
        lastName:
          type: string
      required:
        - email
        - password
        - firstName
        - lastName
    UserLoginResponseDto:
      type: object
      properties:
        id:
          type: string
        email:
          type: string
        firstName:
          type: string
        lastName:
          type: string
        apiKey:
          type: string
        token:
          type: string
      required:
        - id
        - email
        - firstName
        - lastName
        - apiKey
        - token
    UserLoginRequestDto:
      type: object
      properties:
        email:
          type: string
        password:
          type: string
      required:
        - email
        - password
    UpdateUserDto:
      type: object
      properties:
        email:
          type: string
        firstName:
          type: string
        lastName:
          type: string
      required:
        - email
        - firstName
        - lastName
    BuildDto:
      type: object
      properties:
        id:
          type: string
        ciBuildId:
          type: string
        number:
          type: number
        branchName:
          type: string
        status:
          type: string
        projectId:
          type: string
        updatedAt:
          format: date-time
          type: string
        createdAt:
          format: date-time
          type: string
        userId:
          type: string
        passedCount:
          type: number
        unresolvedCount:
          type: number
        failedCount:
          type: number
        isRunning:
          type: boolean
      required:
        - id
        - number
        - branchName
        - status
        - projectId
        - updatedAt
        - createdAt
        - passedCount
        - unresolvedCount
        - failedCount
        - isRunning
    CreateBuildDto:
      type: object
      properties:
        ciBuildId:
          type: string
        branchName:
          type: string
        project:
          type: string
      required:
        - branchName
        - project
    CommentDto:
      type: object
      properties:
        comment:
          type: string
      required:
        - comment
    IgnoreAreaDto:
      type: object
      properties:
        x:
          type: number
        'y':
          type: number
        width:
          type: number
        height:
          type: number
      required:
        - x
        - 'y'
        - width
        - height
    CreateTestRequestDto:
      type: object
      properties:
        name:
          type: string
        os:
          type: string
        browser:
          type: string
        viewport:
          type: string
        device:
          type: string
        branchName:
          type: string
        imageBase64:
          type: string
        buildId:
          type: string
        projectId:
          type: string
        diffTollerancePercent:
          type: number
        merge:
          type: boolean
        ignoreAreas:
          type: array
          items:
            $ref: '#/components/schemas/IgnoreAreaDto'
      required:
        - name
        - branchName
        - imageBase64
        - buildId
        - projectId
    TestRunResultDto:
      type: object
      properties:
        id:
          type: string
        imageName:
          type: string
        diffName:
          type: string
        baselineName:
          type: string
        diffPercent:
          type: number
        diffTollerancePercent:
          type: number
        pixelMisMatchCount:
          type: number
        status:
          type: string
        url:
          type: string
        merge:
          type: boolean
      required:
        - id
        - imageName
        - diffName
        - baselineName
        - diffPercent
        - diffTollerancePercent
        - pixelMisMatchCount
        - status
        - url
        - merge
    ProjectDto:
      type: object
      properties:
        id:
          type: string
        buildsCounter:
          type: number
        name:
          type: string
        mainBranchName:
          type: string
        createdAt:
          format: date-time
          type: string
        updatedAt:
          format: date-time
          type: string
      required:
        - id
        - buildsCounter
        - name
        - mainBranchName
        - createdAt
        - updatedAt
    CreateProjectDto:
      type: object
      properties:
        name:
          type: string
        mainBranchName:
          type: string
      required:
        - name
        - mainBranchName
paths:
  /users/register:
    post:
      operationId: UsersController_register
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CreateUserDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/UserLoginResponseDto'
      tags:
        - users
  /users/login:
    post:
      operationId: UsersController_login
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/UserLoginRequestDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/UserLoginResponseDto'
      tags:
        - users
  /users/newApiKey:
    get:
      operationId: UsersController_generateNewApiKey
      parameters: []
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                type: string
      tags:
        - users
      security:
        - bearer: []
  /users/password:
    put:
      operationId: UsersController_changePassword
      parameters: []
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                type: boolean
      tags:
        - users
      security:
        - bearer: []
  /users:
    put:
      operationId: UsersController_update
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/UpdateUserDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/UserLoginResponseDto'
      tags:
        - users
      security:
        - bearer: []
  /builds:
    get:
      operationId: BuildsController_get
      parameters:
        - name: projectId
          required: true
          in: query
          schema:
            type: string
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/BuildDto'
      tags:
        - builds
      security:
        - bearer: []
    post:
      operationId: BuildsController_create
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CreateBuildDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/BuildDto'
      tags:
        - builds
      security:
        - api_key: []
  '/builds/{id}':
    delete:
      operationId: BuildsController_remove
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - builds
      security:
        - bearer: []
    patch:
      operationId: BuildsController_stop
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/BuildDto'
      tags:
        - builds
      security:
        - bearer: []
        - api_key: []
  /test-runs:
    get:
      operationId: TestRunsController_get
      parameters:
        - name: buildId
          required: true
          in: query
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
    post:
      operationId: TestRunsController_postTestRun
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CreateTestRequestDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/TestRunResultDto'
      tags:
        - test-runs
      security:
        - api_key: []
  '/test-runs/recalculateDiff/{id}':
    get:
      operationId: TestRunsController_recalculateDiff
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
  /test-runs/approve:
    get:
      operationId: TestRunsController_approveTestRun
      parameters:
        - name: id
          required: true
          in: query
          schema:
            type: string
        - name: merge
          required: false
          in: query
          schema:
            type: boolean
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
  '/test-runs/reject/{id}':
    get:
      operationId: TestRunsController_rejectTestRun
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
  '/test-runs/{id}':
    delete:
      operationId: TestRunsController_deleteTestRun
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
  '/test-runs/ignoreArea/{testRunId}':
    put:
      operationId: TestRunsController_updateIgnoreAreas
      parameters:
        - name: testRunId
          required: true
          in: path
          schema:
            type: string
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: array
              items:
                type: string
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
  '/test-runs/comment/{testRunId}':
    put:
      operationId: TestRunsController_updateComment
      parameters:
        - name: testRunId
          required: true
          in: path
          schema:
            type: string
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CommentDto'
      responses:
        '200':
          description: ''
      tags:
        - test-runs
      security:
        - bearer: []
  /test-variations:
    get:
      operationId: TestVariationsController_getList
      parameters:
        - name: projectId
          required: true
          in: query
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-variations
      security:
        - bearer: []
  '/test-variations/details/{id}':
    get:
      operationId: TestVariationsController_getDetails
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-variations
      security:
        - bearer: []
  '/test-variations/ignoreArea/{variationId}':
    put:
      operationId: TestVariationsController_updateIgnoreAreas
      parameters:
        - name: variationId
          required: true
          in: path
          schema:
            type: string
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: array
              items:
                type: string
      responses:
        '200':
          description: ''
      tags:
        - test-variations
      security:
        - bearer: []
  '/test-variations/comment/{id}':
    put:
      operationId: TestVariationsController_updateComment
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CommentDto'
      responses:
        '200':
          description: ''
      tags:
        - test-variations
      security:
        - bearer: []
  /test-variations/merge/:
    get:
      operationId: TestVariationsController_merge
      parameters:
        - name: projectId
          required: true
          in: query
          schema:
            type: string
        - name: branchName
          required: true
          in: query
          schema:
            type: string
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/BuildDto'
      tags:
        - test-variations
      security:
        - bearer: []
  '/test-variations/{id}':
    delete:
      operationId: TestVariationsController_delete
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
      tags:
        - test-variations
      security:
        - bearer: []
  /projects:
    get:
      operationId: ProjectsController_getAll
      parameters: []
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/ProjectDto'
      tags:
        - projects
      security:
        - bearer: []
    post:
      operationId: ProjectsController_create
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CreateProjectDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ProjectDto'
      tags:
        - projects
      security:
        - bearer: []
    put:
      operationId: ProjectsController_update
      parameters: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/ProjectDto'
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ProjectDto'
      tags:
        - projects
      security:
        - bearer: []
  '/projects/{id}':
    delete:
      operationId: ProjectsController_remove
      parameters:
        - name: id
          required: true
          in: path
          schema:
            type: string
      responses:
        '200':
          description: ''
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ProjectDto'
      tags:
        - projects
      security:
        - bearer: []

Thanks

@pashidlos I've addressed most of the codacy feedback, but I wanted to run the last ones by you to see what you think.
(ignore the ApiClient.cs warnings, they are incorrect and have been disabled, but haven't disappeared yet)
What do you think of the pattern I have used for Track?
Codacy is definitely recommending the normal standard, but I'm tempted to keep this pattern because it has requires less typing. ie a slightly lower barrier to entry.
public async Task<TestRunResult> Track(
            string name,
            string imageBase64,
            CancellationToken? cancellationToken = null,
            string os = null,
            string browser = null,
            string viewport = null,
            string device = null,
            double? diffTollerancePercent = null,
            IEnumerable<IgnoreAreaDto> ignoreAreas = null)

@dcrowe I like the idea of less typing
don't see a problem there

I think its finally ready to merge. Happy with it?

definitely!
could you please make a release and add info about how to do it here?
https://github.com/orgs/Visual-Regression-Tracker/teams/sdk-dotnet

See https://github.com/orgs/Visual-Regression-Tracker/teams/sdk-dotnet/discussions/1


EOS-19065: Use shared Motr-Hare confstore to populate BE segment1 in CDF

Problem:
Jira link - EOS-19065
Confluence page - page
Description:

prepare | Motr | server>name>cvg[0]>m0d[0]>md_seg1 | /dev/vg_srvnode-1_md1/lv_raw_md1 | string |
prepare | Motr | server>name>cvg[0]>m0d[0]>md_journal | /dev/vg_srvnode-1_md1/lv_be_log | string |
prepare | Motr | server>name>cvg[1]>m0d[0]>md_seg0 | /dev/vg_srvnode-1_md2/lv_md2_seg0 | string |

The above keys are generated by Motr. Since, we cannot update the global confstore and the keys are specific to Motr-hare.
A shared confstore between hare-motr is required.
This confstore will be available after motr's prepare stage.
Note: Currently, the value for BE segment1 is hard-coded.
Solution:
Read BE segment1 using Motr-Hare confStore in config stage.
Update the cluster definition file.
This confstore will be available after motr's prepare stage.
Tests
Sample motr_hare_keys.json file used for testing.
{
    "server": {
      "srvnode-1": {
        "cvg": [
          {
            "m0d": [
              {
                "md_seg1": "/dev/vg_srvnode-1_md1/lv_raw_md1"
              }
            ]
          },
          {
            "m0d": [
              {
                "md_seg1": "/dev/vg_srvnode-1_md2/lv_raw_md2"
              }
            ]
          }
        ]
      }
    }
  }

CDF file generated
...
nodes:
- m0_servers:
  - io_disks:
      data:
      - /dev/loop0
      - /dev/loop1
      - /dev/loop3
      meta_data: /dev/vg_srvnode-1_md1/lv_raw_md1
    runs_confd: false
  - io_disks:
      data:
      - /dev/loop4
      - /dev/loop5
      - /dev/loop6
      meta_data: /dev/vg_srvnode-1_md2/lv_raw_md2
    runs_confd: false
  - io_disks:
      data: []
      meta_data: null
    runs_confd: true
  data_iface: eth0
  hostname: ssc-vm-4899.colo.seagate.com
...

Note: Currently, we need this file at the desired location to be present. Else hare config stage will fail.

@Shreya-18
Can you also please copy the logs here in case the file motr_hare_keys.json is not found?
Thank you!

@suvratjoshi Here are the logs,

For motr_hare_keys.json file not found

$ /opt/seagate/cortx/hare/bin/hare_setup config --config 'json:///root/prov/config' --file '/var/lib/hare/cluster.yaml'
2021-07-29 04:14:31,792 [ERROR] Error performing configuration (config file: json:///opt/seagate/cortx/motr/conf/motr_hare_keys.json does not exist)

For keys not found in a particular confstore, I have added the confstore URL path info in the error log, which will tell us the problem in which confstore.

$ /opt/seagate/cortx/hare/bin/hare_setup config --config 'json:///root/prov/config' --file '/var/lib/hare/cluster.yaml'
2021-07-29 01:18:38,494 [ERROR] Error performing configuration (Required key 'server>srvnode-1>cvg[0]>m0d' not found in 'json:///opt/seagate/cortx/motr/conf/motr_hare_keys.json')

$ /opt/seagate/cortx/hare/bin/hare_setup config --config 'json:///root/prov/config_temp' --file '/var/lib/hare/cluster.yaml'
2021-07-29 01:32:35,247 [ERROR] Error performing configuration (Required key 'server_node' not found in 'json:///root/prov/config_temp')

Anything else required as part of logs, please do suggest.

@Shreya-18, kindly elaborate the commit message,

does not explain the problem.
title must summarize the problem not the solution (e.g. motr metadata device path is hard coded)
avoid using acronyms and rather use full generic names where ever possible (e.g. BE -> motr metadata device)

Currently, the value for BE segment1 is hard-coded. -> what value? better mention metadata device.
Solution: Read BE segment1 using Motr-Hare confStore in config stage.
Update the cluster definition file.
This confstore will be available after motr's prepare stage.

consider,
The motr metadata device path is hardcoded for every motr ioservice. This restricts the configurability of the system and increases dependencies.

Solution:
- Take metadata devices paths as input from motr via a shared Cortx conf-store mechanism between Hare and Motr.
- Add validations for existence of this shared Cortx conf-store.

You can add more if missed anything.

@mssawant

@Shreya-18, We need to co-ordinate landing with motr, We need to have a custom build and test deployment with corresponding motr branch. cc @vaibhavparatwar

There is another option. We could make the existence of this "motr" confstore file optional: if it exists, then new logic applies, if not - we fall back to the older implementation with hardcoded values.
BTW that's one of the points why the overall idea with multiple configuration files looks sub-optimal. We get more room for unexpected failures to happen.
The configuration file can be missing due to some error in external component (Motr), but our component fails. Doesn't it sound like tight coupling?

Custom build - http://cortx-storage.colo.seagate.com/releases/cortx/github/integration-custom-ci/centos-7.8.2003/custom-build-2268/
Test deployment - http://eos-jenkins.mero.colo.seagate.com/job/Cortx-Deployment/job/VM-Deployment-R2-3Node/559/
3 node deployment is successful.
Testing -
IOs were successful
info: I/O workload is finished.
info: Total: time=[47:330062994] objs=80 ops=1600
info: C: [0:288333644] ([0:027140079] per op)
info: O: [0:142133827] ([0:011475369] per op)
info: D: [2:229070369] ([0:095099909] per op)
info: W: [38:844239636] ([0:352493996] per op), 819200 KiB, 21089 KiB/s
info: R: [6:523162258] ([0:054088100] per op), 819200 KiB, 125583 KiB/s
info: done workload 0
info: ---------------------------------------

No need to mention Jira link and confluence page in the PR description, its redundant and confluence page links may break if the page is moved.
VM deployment is failing because of,
04:36:48                  "stderr": "2021-07-29 10:36:47,559 [ERROR] Error performing configuration (config file: json:///opt/seagate/cortx/motr/conf/motr_hare_keys.json does not exist)"

@Shreya-18, We need to co-ordinate landing with motr, We need to have a custom build and test deployment with corresponding motr branch. cc @vaibhavparatwar

@mssawant @knekrasov  This has tested our error msg in a way :) we are throwing correct error msg. Also this jenkins VM deployment job will fail as it does not have motr changes, @Shreya-18 and Rajat patil (from motr) has tested custom build deployment and I/Os as well
[root@ssc-vm-6407 ~]# hctl status
Data pool:
    # fid name
    0x6f00000000000001:0x96 'storage-set-1__sns'
Profile:
    # fid name: pool(s)
    0x7000000000000001:0xf8 'Profile_the_pool': 'storage-set-1__sns' None None
Services:
    ssc-vm-6407.colo.seagate.com
    [started]  hax        0x7200000000000001:0x7   <IP_ADDRESS>@tcp:12345:1:1
    [started]  ioservice  0x7200000000000001:0xa   <IP_ADDRESS>@tcp:12345:2:1
    [started]  ioservice  0x7200000000000001:0x19  <IP_ADDRESS>@tcp:12345:2:2
    [started]  confd      0x7200000000000001:0x28  <IP_ADDRESS>@tcp:12345:2:3
    [started]  s3server   0x7200000000000001:0x2b  <IP_ADDRESS>@tcp:12345:3:1
    [unknown]  m0_client  0x7200000000000001:0x2e  <IP_ADDRESS>@tcp:12345:4:1
    [unknown]  m0_client  0x7200000000000001:0x31  <IP_ADDRESS>@tcp:12345:4:2
    ssc-vm-6408.colo.seagate.com
    [started]  hax        0x7200000000000001:0x38  <IP_ADDRESS>@tcp:12345:1:1
    [started]  ioservice  0x7200000000000001:0x3b  <IP_ADDRESS>@tcp:12345:2:1
    [started]  ioservice  0x7200000000000001:0x4a  <IP_ADDRESS>@tcp:12345:2:2
    [started]  confd      0x7200000000000001:0x59  <IP_ADDRESS>@tcp:12345:2:3
    [started]  s3server   0x7200000000000001:0x5c  <IP_ADDRESS>@tcp:12345:3:1
    [unknown]  m0_client  0x7200000000000001:0x5f  <IP_ADDRESS>@tcp:12345:4:1
    [unknown]  m0_client  0x7200000000000001:0x62  <IP_ADDRESS>@tcp:12345:4:2
    ssc-vm-6409.colo.seagate.com
    [started]  hax        0x7200000000000001:0x69  <IP_ADDRESS>@tcp:12345:1:1
    [started]  ioservice  0x7200000000000001:0x6c  <IP_ADDRESS>@tcp:12345:2:1
    [started]  ioservice  0x7200000000000001:0x7b  <IP_ADDRESS>@tcp:12345:2:2
    [started]  confd      0x7200000000000001:0x8a  <IP_ADDRESS>@tcp:12345:2:3
    [started]  s3server   0x7200000000000001:0x8d  <IP_ADDRESS>@tcp:12345:3:1
    [unknown]  m0_client  0x7200000000000001:0x90  <IP_ADDRESS>@tcp:12345:4:1
    [unknown]  m0_client  0x7200000000000001:0x93  <IP_ADDRESS>@tcp:12345:4:2
[root@ssc-vm-6407 ~]# ls /opt/seagate/
cortx/         cortx_configs/ users/
[root@ssc-vm-6407 ~]# ls /opt/seagate/cortx/motr/
bin/      common/   conf/     libexec/  sanity/   workload/
[root@ssc-vm-6407 ~]# ls /opt/seagate/cortx/motr/conf/
examples   motr.config.tmpl         motr_hare_keys.json     motr.post_install.tmpl.sample  motr.prepare.tmpl.sample  motr.test.tmpl.sample
motr.conf  motr.config.tmpl.sample  motr.post_install.tmpl  motr.prepare.tmpl              motr.test.tmpl            setup.yaml
[root@ssc-vm-6407 ~]# ls /opt/seagate/cortx/motr/conf/motr_hare_keys.json
/opt/seagate/cortx/motr/conf/motr_hare_keys.json
[root@ssc-vm-6407 ~]#
[root@ssc-vm-6407 ~]#
[root@ssc-vm-6407 ~]#
[root@ssc-vm-6407 ~]# cortx cluster stop --all
{"status": "InProgress", "output": "Cluster stop is in progress.", "error": ""}[root@ssc-vm-6407 ~]#
You have new mail in /var/spool/mail/root
[root@ssc-vm-6407 ~]# cortx cluster start
{"status": "InProgress", "output": "Cluster start operation performed", "error": ""}You have new mail in /var/spool/mail/root
[root@ssc-vm-6407 ~]# pcs status
Cluster name: cortx_cluster
Stack: corosync
Current DC: srvnode-1.data.private (version 1.1.23-1.el7-9acf116022) - partition with quorum
Last updated: Thu Jul 29 14:38:54 2021
Last change: Wed Jul 28 11:46:02 2021 by root via cibadmin on srvnode-1.data.private

3 nodes configured
40 resource instances configured

Online: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]

Full list of resources:

 Clone Set: hax-clone [hax]
     Started: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Clone Set: motr-confd-1-clone [motr-confd-1]
     Started: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Clone Set: motr-ios-1-clone [motr-ios-1]
     motr-ios-1 (ocf::seagate:dynamic_fid_service_ra):  Starting srvnode-3.data.private
     Started: [ srvnode-1.data.private srvnode-2.data.private ]
 Clone Set: motr-ios-2-clone [motr-ios-2]
     motr-ios-2 (ocf::seagate:dynamic_fid_service_ra):  Starting srvnode-3.data.private
     Started: [ srvnode-1.data.private srvnode-2.data.private ]
 Clone Set: s3auth-clone [s3auth]
     Started: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Clone Set: s3server-1-clone [s3server-1]
     Stopped: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Clone Set: haproxy-clone [haproxy]
     Stopped: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Clone Set: s3backcons-clone [s3backcons]
     Stopped: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 motr-free-space-mon    (systemd:motr-free-space-monitor):      Stopped
 s3backprod     (systemd:s3backgroundproducer): Stopped
 Clone Set: monitor_group-clone [monitor_group]
     Started: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Resource Group: management_group
     mgmt-vip   (ocf::heartbeat:IPaddr2):       Started srvnode-1.data.private
     kibana     (systemd:kibana):       Started srvnode-1.data.private
     csm-agent  (systemd:csm_agent):    Started srvnode-1.data.private
     csm-web    (systemd:csm_web):      Started srvnode-1.data.private
 Resource Group: ha_group
     event_analyzer     (systemd:event_analyzer):       Started srvnode-2.data.private
 Clone Set: srv_counter-clone [srv_counter]
     Started: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]
 Clone Set: mbus_rest-clone [mbus_rest]
     Started: [ srvnode-1.data.private srvnode-2.data.private srvnode-3.data.private ]

Daemon Status:
  corosync: active/enabled
  pacemaker: active/enabled
  pcsd: active/enabled

@Shreya-18, kindly elaborate the commit message,

does not explain the problem.
title must summarize the problem not the solution (e.g. motr metadata device path is hard coded)
avoid using acronyms and rather use full generic names where ever possible (e.g. BE -> motr metadata device)

consider,
The motr metadata device path is hardcoded for every motr ioservice. This restricts the configurability of the system and increases dependencies.

Solution:
- Take metadata devices paths as input from motr via a shared Cortx conf-store mechanism between Hare and Motr.
- Add validations for existence of this shared Cortx conf-store.

You can add more if missed anything.

Updated the commit message. Thanks for the tips @mssawant 👍


Issue 443: Adding python support for 3.11

Change log description
(2-3 concise points about the changes in this PR. When committing this PR, the committer is expected to copy the content of this section to the merge description box)
Purpose of the change
(e.g., Fixes #666, Closes #1234)
What the code does
(Detailed description of the code changes)
How to verify it
(Optional: steps to verify that the changes are effective)

Codecov Report

Merging #445 (9fb8e0e) into master (3014d15) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   72.84%   72.78%   -0.06%
==========================================
  Files          49       49
  Lines       12399    12399
  Branches    12399    12399
==========================================
- Hits         9032     9025       -7
- Misses       3367     3374       +7

see 3 files with indirect coverage changes


docs/layers: smalle -> smaller

There were the following issues with your Pull Request

Commit: 196854f5166fe5c800ff403c88268211ea9a1244
Commits must be in the following format: %{type}/%{scope}: %{description}

Guidelines are available at https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines

This message was auto-generated by https://gitcop.com

Already fixed in another PR.


java.lang.IllegalArgumentException: Crashlytics found an invalid API key: null.

:sample:fabricGenerateResourcesDebug
ERROR - Crashlytics Developer Tools error.
java.lang.IllegalArgumentException: Crashlytics found an invalid API key: null.
Check the Crashlytics plugin to make sure that the application has been added successfully!
Contact<EMAIL_ADDRESS>for assistance.

I disabled fabric in sample module. Please check it out again @jiqimaogou


update generated api-reference docs for 1.10

Also updated the _data/reference.yml file, in addition to the generated docs.
It looks as though the issue with the make copyapi -- or possibly with cp, haven't checked that far -- is that it does not like to create directory names with punctuation in them. Or least, not with either dashes or periods. Not fully tested yet, not sure what to recommend going forward. Will ponder later. Thanks for all your help.
/assign @steveperry-53

/lgtm
/approve
/hold
@Bradamant3 Please feel free to remove the /hold when you're ready.

@Bradamant3 Initial pass: It doesn't seem right that we have several cases of "File renamed without changes".  But when I saw those "File renamed without changes" diffs, I also noticed that they are all css/js files for presenting the content. They aren't content files themselves. So I'd sort of expect them to remain the same.

new file:   docs/reference/generated/kubernetes-api/v1.10/index.html
        new file:   docs/reference/generated/kubernetes-api/v1.10/navData.js
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/bootstrap/dist/css/bootstrap.min.css
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/css/font-awesome.css
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/css/font-awesome.css.map
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/css/font-awesome.min.css
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/fonts/FontAwesome.otf
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/fonts/fontawesome-webfont.eot
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/fonts/fontawesome-webfont.svg
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/fonts/fontawesome-webfont.ttf
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/fonts/fontawesome-webfont.woff
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/font-awesome/fonts/fontawesome-webfont.woff2
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/highlight.js/styles/default.css
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/jquery.scrollto/jquery.scrollTo.min.js
        new file:   docs/reference/generated/kubernetes-api/v1.10/node_modules/jquery/dist/jquery.min.js
        new file:   docs/reference/generated/kubernetes-api/v1.10/scroll.js
        new file:   docs/reference/generated/kubernetes-api/v1.10/stylesheet.css
        new file:   docs/reference/generated/kubernetes-api/v1.10/tabvisibility.js

hrm. OK, running various things again. bc kubectl docs also messed up.

@Bradamant3 Given that you deleted the 1.9 files, I think this PR is correct.
/approve

/hold cancel


promql: Make range selections left-open and right-closed

Proposal
For historical reasons, a range selector selects a closed interval, i.e. samples perfectly coinciding with the boundaries of the range are included in the selection.
For various reasons, it is more consistent and more helpful in practice to make the selection "left open" and "right closed", i.e. a sample coinciding with the "left" boundary (the one further in the past) is excluded from the selection, while at the "right" boundary (the one further towards the future) stays inclusive.
For example, with samples perfectly spaced every 1m (very common in practice), a range over 5m might currently select 5 or 6 samples, depending on the exact alignment. In practice, it almost always selects 5 samples, because perfect alignment rarely happens in real-world scenarios. However, in test scenarios, perfect alignment happens easily, even without intending to do so. So test cases can easily represent a case that is very rare in practice. With the proposed change, the range will always select 5 samples in the case of perfectly spaced samples.
This is, however, a breaking change, although the impact is mostly academic. Therefore, we should implement this change with the upcoming 3.0.0 release.

Hello! I am following this change.
May I ask why the range selector is defined as left-open and right-closed instead of left-closed and right-open?
I think the latter is better because it is consistent with the behavior of range selectors for lists in multiple programming languages.
For example, in Go, use [lo:hi] to operate on array or slice arr, the result is:
arr[lo], arr[lo+1], arr[lo+2],..., arr[hi-1]

It includes left bound and excludes right bound.
Thanks.

Good question. I should have mentioned the rationale for that, too. The short answer is that a range vector should always select the samples that the corresponding instant vector would have selected, too.
In more detail:
An instant vector will select a sample that is precisely at the evaluation timestamp (if there is one, otherwise it will search for the next sample in the past). So let's say the instant vector foo returns a sample that happens to be precisely at the evaluation timestamp. If you change that instant vector to a range vector foo[1m], you should still see that same sample selected as part of the range. That's accomplished with a "right closed" range. However, with a "right open" range, you would not select that sample.

When the range selection interval becomes smaller and smaller, the result shall converge to the corresponding instant query result - Well designed, thanks😀

Hey @beorn7, I would like to work on this issue.
So, where in which function are we supposed to make this change?
The query data flows like this ig - NewRangeQuery -> Exec -> exec -> execEvalStmt -> InitStepTracking -> Eval -> eval in promql/engine.go.

Hey @beorn7, I would like to work on this issue.

I have assigned this issue to you.

So, in which function are we supposed to make this change?

I don't know the PromQL codebase well enough to answer this question from the top of my head. You have to investigate the codebase yourself (as you have already started to do so). #prometheus-dev on the CNCF slack might be a good forum to fish for more experienced PromQL coders than me or general help.
Note that these changes have to be behind a feature flag in v2.x and will only become default in v3.

Hey @beorn7 👋 I just stumbled upon this issue since I was looking at the same artifact of including more datapoints than I intend to when using <agg_function>_over_time for the purpose of downs-ampling a gauge metric.
What I was thinking wrt this proposed solution is to do the opposite selection of which side is open and which one is closed. When down-sampling using an aggregation function over time, you would expect the left limit of the range interval to be included in the aggregation but not the right limit, i.e. left-closed and right-open.
Doing the opposite would mean that in a range between t1 and t2 timestamps, the t1 aggregate doesn't include t1 but includes t2 and is tracked under t2 in the resulting timeseries, which is not accurate to describe which time-bucket a given aggregate represents. In other words, with left-open and right-closed, what you get is the aggregate of the (t1, t2] interval timestamped on the right-side limit (t2) when the semantic (or intuitive) behavior of down-sampling is to calculate the aggregate over the [t1, t2) interval and timestamp it on t1.
Maybe I'm missing something, but "left-closed and right-open" is how I've seen all re-sampling/down-sampling intervals working across multiple time-series tools (database query languages, stream processing, data frame libraries, etc.). Maybe the fundamental behavior here is also based on the range interval in prometheus always looking back as opposed to creating discrete [t1, t2) intervals over the overall query time range, since today I can easily achieve the "left-open and right-closed" range interval by using a simple offset 1s on my range vectors (assuming stored data sampling rate is > 1s), but that looks just odd for example on the last timestamp aggregate when you don't have the full interval and if you're using sum aggregation you already see a complete interval total 🤔
I don't know if this behavior also relates to @KofClubs's comment or if that one was purely based on array slicing semantics 😅

I guess the one important argument would be that an instant selector selects the most recent sample at or before the evaluation timestamp. If a range selector was right-open, it would not select a sample exactly at the evaluation timestamp, so it would be possible that an instant selector selects a sample that a range selector at the same timestamp would not select, which I believe is highly undesirable.

/assign

#13904 is an example showing how I would implement it.

This is done. It will be released in v3.0.0.


[VQC-CHALLENGE] [Feynman-Prodigies] [November 4, 2022]

Team members
Rohit Saini
Abdullah Kazi
Pranav Maheshwari
Rishabh Singh
Vansh Jhunjhunwala
Soubhadra Maiti
Submission summary
private submission
qBraid account<EMAIL_ADDRESS>Additional comments
Check HAQS-2022/qml-classifier-challenge/vqc_challenge.ipynb
Commit: VQC_cost_optimization

We have pushed the files to Feynman-Prodigies public branch, just in case.


Activate ABAP track!

closes #1 🎉 🥳 🎈
@ErikSchierboom if all looks okay, we can merge?
We are planning an official launch stream on April 1st on YouTube, link will go up later today. When that is up, we can start buzzing and linking to that stream.

https://www.youtube.com/watch?v=F2zBmjqM8xo

🥳


Autodetect version tags

Towards #2139

I would suggest just to make a new test-repo and add a new test case. It's not a good practice to edit the VCR cassettes by hand unless very trivial edits that don't relate to the object under test. You should erase those cassettes and re-record them if you need to, but otherwise, just make a new test case so you can record cassettes against a real API instead of copying it in.

I would suggest just to make a new test-repo and add a new test case. It's not a good practice to edit the VCR cassettes by hand unless very trivial edits that don't relate to the object under test. You should erase those cassettes and re-record them if you need to, but otherwise, just make a new test case so you can record cassettes against a real API instead of copying it in.

I agree it would be better to record cassettes instead of hand-editing them. I cannot create repo's under ciitest/coreinfrastructure, though, and it'd be a bit awkward to record them against repo's not under ciitest/coreinfrastructure control - which is why I asked to add a version tag to https://github.com/ciitest/test-repo .
If no-one can create a tag on https://github.com/ciitest/test-repo (or create a new repo under ciitest/coreinfrastructure) I'll indeed create a repo under my own account and test against that.

Someone probably can but I don't know who it is. @david-a-wheeler might know. But fine to use your own repo for now. Or make a fake github user called ciitest. That is what some of the other stuff is.


#273

no marketDefinition handling added to stream to prevent stream failing
test added

Coverage increased (+0.007%) to 94.111% when pulling 4f06480a32a55d71d3ccf9b07af9e76ee407033a on bugfix/273-no-market-definition into 9fab5c411b9dedf3d03a857c8f2a9080ef7a5070 on master.


Fix dropped mod items with 3D items enabled

Replaces the instanceof ItemRecord with a test to see whether the block ID for the rendered ItemStack is a valid block.

Needs improvement, this code only work because of how FoxLoader work, I'll say it's good enough for now.
I would preferably would like the method to use an item API instead, feel free to open a new PR if you wish.


Closed Alpha Test

We want to test with a broader group of non-staff, but we've got a few todos before we're ready for that.

[x] #359
[x] Make a new oauth client for an app named "iNat Beta", make sure if has an image that's the same as the app icon (https://www.inaturalist.org/oauth/applications/843)
[x] Look into TestFlight options, make sure we can make an invite-only group w/ ~100 ppl
[x] Update fastlane, probably need a new alpha lane that's basically like the internal lane but posts builds to new closed alpha audience
[ ] TBD

Re testflight options,

Yes, we can make an invite-only group, and in fact we already have one called "iNat Friends"
All test groups can have up to 10,000 people
We can also make a public link for a test group and limit the number of members
Apparently if you take a screenshot of an app in TestFlight and tap it immediately, you get an option to share feedback that we can see in TestFlight. Really not-obvious, so if we want people to do this we'll need some instructions.

@abhasinat here's a proposal:

If there are particular users we want feedback from (maybe a few power users, a few casual users), we should invite them to the existing "iNat Friends" group and continue to treat that group as an invite-only group. We can continue to send them "internal" builds whenever we make new builds for staff.
Create a separate "Open Beta" group that has a public link and use this for in-person testing. We can make a QR code of the URL so people should be able to join the group and download the app relatively easily. This way you can do in-person testing using a variety of actual devices, plus we can share this a little more broadly if we'd like.

This sounds good.
I would use 2) primarily on usertesting.com. I will create tasks for users to download the beta on their devices via a public URL and then screen record as they use it. This would be used for both casual users (who have never seen our apps before) and for power users (who we choose to send a link to).
For 1) I would keep this small, and create some sort of regular feedback mechanism akin to our weekly testing doc for those power users. I'm imagining power users who we send a link to in 2) could self-select or be selected for this group.

Ok, that's sorted, @abhasinat.

Closed alpha functionality supported through the "iNat Friends" group on TestFlight. Go to the TestFlight admin page to manually invite people
Open beta functionality supported through the "Open Beta" group on TestFlight. It has a public link that you can get from the TestFlight admin page

Do you want to make any other changes, like removing placeholder or "TODOs" from the app, or are we good?

I'll take that as a no.

I think removing placeholder TODOs would be great! I would just make sure they have corresponding issues in github already.


Import transcripts into episode template

In issue #15 Emma mentioned wanting to add the transcripts to the episode pages rather than just linking to them on GitHub.
Here's what I did as one possible solution:

Sourced the transcripts using gatsby-source-filesystem in gatsby-config.js.

Updated the GraphQL query in gatsby-node.js to filter out Markdown files that don't have a title in their frontmatter, so that only the episode Markdown files get turned into pages.

Added a link to the transcript Markdown files to the frontmatter of the episode Markdown files.

Updated the BlogPostByPath query in the episode.js template to also grab the transcript.

Added the transcript in a section tag below the episode in episode.js. (I originally ran into facebook/react#5479 where dangerouslySetInnerHTML does not work with nested  tags.)

My code is here
I also set up a live demo on Netlify to check that it didn't just work on my local machine.

THIS LOOKS AWESOME THANK YOU! I'll take a look today :)


Request failed with status code 400 when add ingestion

I'm trying to add an ingestion, but got "Request failed with status code 400" each time.
 The JSON Schema

I didn't active the security config, there would be no owner id at all, since none of the authentication methods is an option for our company, are you going to support any other open standards like LDAP or OAuth2.0 ?

There is a bug that we need to fix. The owner is required here but in the JSON Schema can be null. We plan to support all the authentication methods needed by our users. Just drop me a message in Slack so that we collect your requirements.

There is a bug that we need to fix. The owner is required here but in the JSON Schema can be null. We plan to support all the authentication methods needed by our users. Just drop me a message in Slack so that we collect your requirements.

This is very old and may no longer be an issue. @velna, please reopen, if it is still an issue.


support glm edge

What does this PR do?
support GLM-Edge models family https://huggingface.co/collections/THUDM/glm-edge-6743283c5809de4a7b9e0b8b
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Merging as minor changes enabling new model.


Feature request: support retrieving sealed subclasses

Since these are known at compile-time, it would be quite helpful to be able to generate that information.

Isn't it covered by KClass.sealedSubclasses?

@nbirillo I've implemented a working prototype of this as an IR transform here. Would you be interested in a PR of that to this project? If not I'll just release it as its own project
https://github.com/ZacSweers/MoshiX/pull/272

Hello! It looks great!
However, we changed a lot of main logic in Reflekt since we are deleting the old front-end from the plugin
The current changes are available here (in the delete-old-front-end branch). @elena-lyulina are finishing with replacing all tests into tests with the tests compiler framework (it is available in the official kotlin repo), after that we will merge all changes to the master branch (approximately in several days)
After that, the core architecture will be stable since we will use only stable parts for the Kotlin compiler (in our case only IR backend) and we will complement new features and so on
If you have time to merge your changes with the delete-old-front-end branch (I can help you if you want) the changes will be beneficial for our project
In your case what way to interact with Reflekt do you prefer? a new type of query in DSL?
Also, we will implement some wrappers to get not only entities but the information about them (see this issue) to avoid run-time reflection after getting the entities. We are going to have information about sealed subclasses

Happy to. Do you want me to PR something against that branch or just wait until it's merged?

In your case what way to interact with Reflekt do you prefer? a new type of query in DSL?

The way I've implemented actually just replaces the KClass.sealedSubclasses calls (which otherwise would be an error to call at runtime) during IR transformation so it doesn't require any sort of new runtime API/DSL.
If #112 is implemented though, I would expect that to supersede the need for my implementation since it offers an alternative mechanism. Let me know either way.

Happy to. Do you want me to PR something against that branch or just wait until it's merged?

In your case what way to interact with Reflekt do you prefer? a new type of query in DSL?

The way I've implemented actually just replaces the KClass.sealedSubclasses calls (which otherwise would be an error to call at runtime) during IR transformation so it doesn't require any sort of new runtime API/DSL.
If #112 is implemented though, I would expect that to supersede the need for my implementation since it offers an alternative mechanism. Let me know either way.

The problem with replacing KClass calls is that it may break cases when the user really wants runtime reflection (however, it seems to be OK since it's obviously impossible to add new sealed subclass at run-time). Another one is that such calls produce an allocation for listOf, so static registry would be more efficient.

In fact, replacing calls to KClass directly can confuse users, since in this case some of the calls will be in runtime, and some will be in compile-time
You can try to add it marked experimental. Also, I see you use descriptors in the implementation, they will be removed in future versions of the compiler, so they should be removed anyway
#112 and incremental compilation are first what should we do after merging the current changes.
@elena-lyulina What do you think? Do we want to try adding these changes as experimental ones?

We can't mark KClass.sealedSubclasses experimental since it is in Kotlin's module.

I know, I mean mark it internally

A separate entry-point could be used as well, I just used that as a convenience since it was similar to how kotlin-reflect's presence works.

Also, I see you use descriptors in the implementation, they will be removed in future versions of the compiler, so they should be removed anyway

Unfortunately it doesn't seem like this is implemented outside of descriptors yet, but perhaps that's changed in kotlin 1.6 or 1.7. I'll take a look

Another one is that such calls produce an allocation for listOf, so static registry would be more efficient.

Fair. I considered this a bit low overhead but we could also generate it as a singleton list somewhere and just return that

Looks like they're present now (or I missed them before!), updated the impl with descriptors removed now 👍

that could work, or an alternative to using FIR could just be to create a placeholder function that's replaced (if you look in the earlier commits of the PR, this is how I started it). If you don't want to ship a runtime artifact, this could be exposed as a gradle plugin DSL with an fqname to a consumer-provided function (similar to how all-open and related plugins allow users to bring their own annotations). What do you think?

I think this is better than replacing the runtime artefact 👍

It will be fixed by issue#112


Reciept uploading now works!

fixes #47

If this is tested feel free to merge.

Needs testing on iOS but I believe it should be good to merge.


Bug triggered by drag and drop

I think I found a bug when dragging/dropping onto a list ... see a demo script for RoboFont here: https://gist.github.com/fsi-jens/3ef12361015f84cbc418
Dragging the color onto the list will trigger the bug.
Traceback (most recent call last):
  File "/Applications/RoboFont.app/Contents/Resources/lib/python2.7/vanilla/vanillaList.py", line 164, in tableView_validateDrop_proposedRow_proposedDropOperation_
    return self._handleDrop(True, tableView, draggingInfo, row, dropOperation)
  File "/Applications/RoboFont.app/Contents/Resources/lib/python2.7/vanilla/vanillaList.py", line 110, in _handleDrop
    if window is not None and draggingSource is not None and window == draggingSource.window() and vanillaWrapper._selfWindowDropSettings is not None:
AttributeError: No attribute window```

this is still an issue
proposal:
List drag and drop has been build with the assumption that a dragging source is a table view and that is maybe not correct. In this case the dragging source is an NSColorPanel.
Test if the source is has a window, if not: alway use the otherApplicationDropSettings... Its not completely correct, as its possible to have multiple colorwells in different windows that could drop in specified tableviews..., but the validation is in those cases up to the script instead handleDrop of the vanilla list...


Lithunian eID Card Support

Need someone with Lithunian eID Card test.
Certificats and CRL can find here: http://www.nsc.vrm.lt/downloads_en.htm

Added certificates and crls in #13


Sidebar links are wrong

Context
The current links from the sidebar to each of the study types are wrong.
This is due to the confusing status options we have for each type of study.
Possible Fix
Document each possible study and fix links.
This template was adapted ~stolen~ from Aurelia Moser

fixed in #73


"Error! No Internet Connection?" message.

This error message appears when using Nominatim. Occurs in the example in  jsFiddle
To fix, remove the slash at the end of the url.
Before;
https://nominatim.openstreetmap.org/search/
After:
https://nominatim.openstreetmap.org/search

Cannot reproduce! Are you able to provide a demo?

Closing but feel free to reopen with some reproduction.


Fix constant redefinition across multiple files

Motivation

The test included on this branch previously crashed. There was an ENFORCE that
assumed namer works the way it works the way it finally does in this PR.
Specifically, we assumed that we handled all class definitions before all
non-class definitions. When the code all lives in a single file that was the
case, but the test case seen in this PR shows a case where the static field
definition is processed before the class def of the same name in another file.
Honestly, this is code is gross and once #6422 lands we can delete the most of
the lines added to defineSymbols in this PR, because in that PR
enterNonDeletableMethods becomes empty.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Mk3dy9ja205s9P
→ https://go/builds/bui_Mk3d9uoTmcMLQ5


Optimize _render_canvas_item_tree by reducing z-index iteration range

Optimize _render_canvas_item_tree by reducing z-index iteration range
This PR optimizes the _render_canvas_item_tree function by reducing the iteration range over the z-index. Instead of iterating over the entire possible range (which was leading to 8193 iterations always hitting "continue"), we now compute the minimum and maximum used z-index during the culling process. This significantly reduces the number of iterations required.
Performance Results (Empty Scene):
Before:

_render_canvas_item_tree: 5.23% CPU time
Overall function: 12.1% CPU time

After:

_render_canvas_item_tree: 0.08% CPU time
Overall function: 6.38% CPU time

Screenshots
Before

After

Testing
Tested with an empty 3d scene:

This optimization should lead to a noticeable performance improvement.

Color me skeptical, but it sounds unlikely that a loop of ~8192 with early outs would take >5% of CPU. This is presumably the reason it isn't optimized.
I've never seen it register on profiles in 3.x, but perhaps 4.x is doing something differently. :shrug:
I'll see if I can profile on 4.x.

UPDATE: Yes as expected, it barely registers on a profile. Even in debug.

It looks like your profiling shows 2.41% CPU time in this loop and if statement. Are you using perf and empty 3d scene for profiling? That's what I used.
Even 2.4% is significant and can be reduced to 0% with my change.

It looks like your profiling shows 2.41% CPU time in this loop and if statement. Are you using perf and empty 3d scene for profiling? That's what I used.

Those aren't percentages. This is valgrind.
If you are getting a large percentage in an empty scene, it's because there's no vsync and it's spinning in a tight loop. But I think it's more likely you are misunderstanding the profile.

If you are getting a large percentage in an empty scene, it's because there's no vsync and it's spinning in a tight loop, or it's waiting for vsync all the time.

To be fair, FPS is not the only thing that should be measured when doing optimization. Power consumption also matters as it directly impacts battery life, heat emissions and fan noise in laptops and mobile devices.

Profiling the 100,000 Node2D example above I get the z_range loop using 0.09% of one CPU core.
Real world this % will likely be a lot less as these benchmark nodes aren't doing anything.
There must be something else going on if you are getting differences like that (maybe I'm missing something).


Regenerate the part classes when the files are saved

It's basically a file watcher detecting when a file contains the @genq annotations is saved.
I think it would improve the UX developer avoiding us to constantly switch between the Flutter bash and the genq bash

Would you expect this to be included in the genq command?
Something like
genq --watch

Which watches for changes, and regenerates when a file changes? I think we could include something like this.

Yes, I would expect something like genq --watch
And yeah, it should regenerates when a file changes.

That will be super useful 🚀


LOG4J2-3280 - Add support for microsecond precision in RFC5424Layout

This pull request is to imlement RFE LOG4J2-3280
The change

Adds new attribute timestampPrecision to Rfc5424Layout and SyslogAppender.
Replaces existing logic to append timestamp and uses two new fixed date formats to format timestamp.
Added new unit tests
Verified that 'mvn clean install' and 'mvn verify' are successful.

I believe the failure in PropertiesConfigurationTest is unrelated to this change, and being fixed with #685
Once that is fixed, how do I get this PR to build and run CI tests again?

Hi @atulpendse
You will need to rebase this PR to pick up the latest changes.

Hi @atulpendse
You will need to rebase this PR to pick up the latest changes.

Thanks for the info. I have updated PR with the latest from upstream. Latest commit seems to have passed all the tests.

Fantastic work @atulpendse! Thanks so much!
Mind adding SyslogAppender tests and a changes.xml entry, please?
I am also not sure if a timestampPrecision argument of type String is the right way to go. Thinking out loudly:

Why don't we simply make the instant formatting pattern configurable?
Doesn't the spec enforce a certain precision?
If not, why don't we simply (automatically?) pick the most precise representation possible?

I would NOT update changes.xml, this makes cherry-picking the commit to master impossible.

IMHO, cherry-picking to master is almost already impossible. Nevertheless, I will rephrase my comment to exclude the changes.xml part.

@vy
Thanks for taking time to review the PR.
Here are my thoughts about questions you raised.

I am also not sure if a timestampPrecision argument of type String is the right way to go. Thinking out loudly:

Why don't we simply make the instant formatting pattern configurable?

With making pattern configuration, there is risk of the message not being compliant to RFC5424 spec (if someone updates format that is not as per RFC5424)

Doesn't the spec enforce a certain precision?

The spec does not enforce 'a particular' precision, rather it supports three precisions

Without any sub-second value
Milliseconds
Microseconds

If not, why don't we simply (automatically?) pick the most precise representation possible?

We could, that would work for my usecase. But if someone is expecting precision to be millisecond (like my app was expecting it to be microsecond), it would break their app.
I will add a test for SyslogAppender.

Commit fbccefc updates existing test for SyslogAppender

@vy @garydgregory anything else that I should do to make progress on this PR?

I only took a cursory look this AM. Please use the style of the files you are editing: Use spaces, no tabs. The bigger question is whether we should use an enum for the microsecond vs millisecond format, @jvz any thoughts?

Thanks for taking time to review. I have fixed the concerns with latest commit. Now timestampPrecision is an enum.

Looks like a test is failing on MacOS. Failure doesn't look related to my changes though. I don't have access to Mac to find out why exactly it's failing.

@garydgregory, please let me know how I can help to get the PR going.
I rebased the PR with latest code and submitted back with commit b425497

Just FYI.. I was able to build it successfully on my Mac. Last time @garydgregory tried to submit build with this PR, it failed on Mac, not sure why.

Hello @atulpendse
In general, you want to avoid breaking binary compatibility,  so that means not editing public and protected type names and method signatures. This is critical in the log4j-api module and less so in others, but, in this case it seems easy to do. Also, we have been switching from factory methods to builders as we go from release to release in order to avoid keeping on deprecating factory methods. So edit or add builders, don't edit factory methods is the idea. TY!

@vy Why was this closed? To be honest, I am not sure why this hasn't been merged.

It's a side effect of deleting the release-2.x branch: Github deletes the related PRs.
@atulpendse: can submit again against the 2.x branch?


DeprecationWarning: You are using the get() function from 'botocore.vendored.requests'.

Describe the bug
DeprecationWarning: You are using the get() function from 'botocore.vendored.requests'.  This is not a public API in botocore and will be removed in the future. Additionally, this version of requests is out of date.  We recommend you install the requests package, 'import requests' directly, and use the requests.get() function instead.
To Reproduce
Steps to reproduce the behavior:

Are you testing a QuickStart or Custom template?
Attach or link a copy of the template if possible (remove any sensitive info)
Provide the parameters that you passed. (remove any sensitive info)
How did you install taskcat? (docker or pip3) pip3
Are you using a profile, an instance role or  access keys to run taskcat?
Is your AWS environment configured via aws configure?

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
**Version (Please make sure you are running the latest version of taskcat)

Taskcat Version (ex: [2018.817.210357])

Note: Python Version (python3 required)
To find versions:
Via taskcat: taskcat -V
Via pip3: pip3 show taskcat
Note: both version should match
To update taskcat run:
for docker : docker pull taskcat/taskcat
for pip3: pip3 install --upgrade taskcat
Additional context
Add any other context about the problem here.

https://github.com/aws-quickstart/taskcat/blob/0d5004f00303008bb1aec7e7af9de44a8e73a4da/taskcat/stacker.py#L39
https://github.com/aws-quickstart/taskcat/blob/0d5004f00303008bb1aec7e7af9de44a8e73a4da/taskcat/generate_reports.py#L4
This likely won't be addressed until v0.9 branch (we're relatively close). I'm adding the relevent v0.9 issues as related items so we can fully track.

Report Generation:

https://github.com/taskcat/taskcat-v9/issues/2

Stacker:

https://github.com/taskcat/taskcat-v9/pull/41

Report Generation:

taskcat/taskcat-v9#2

Stacker:

taskcat/taskcat-v9#41

not importing requests from botocore anywhere in this pr 😺

Fixed by #343


A a virtual column to the Audit Events table that shows the "Target"

I think audit events have some sort of concept of the "target" - the thing the audit event is talking about. So for a release this is obviously the release itself.. and for login events this is obviously the user.
And in most situations this is all implied in the UI context - i.e looking at audit events for the release - the context "target" is the release. And for logins the target is normally the person performing the operation.
But when looking at the overall audit events - outside of a release context - we lose the target. Also, for things like "change permission" - the person doing the change is not in fact the target, they are just the performer.
So I think we should add some sort of virtual "target" column that gets passed out by the backend GetEvents call - and fills this column in with a string of the "target" depending on some logic we can come up with.
And then we can decide where we want to show this in the UI (certainly in the overall Audit Events table we would add this column)

Happy for a better name than "target"
Focus?

This would also mean that the target should never be mentioned in the actual text of the event entry.
i.e. no "changed settings: AGR0003"
Instead the text is "Changed settings".. and the "Target" is "AGR0003"

A super interesting example here is "Add user to release: AGR003". Because from my perspective - we actually have 2 users and 1 release.
Performer: who initiated the action (this is traditionally what is audited)
Target user: the person being added
Target release: the release the person is added to
I'm not sure for instance that we currently audit the performer - we instead audit the target user.
And equally - not sure what we should do here - in terms of modelling in the audit event


WIP: Adds support for URI RegexRewrites

Tickets: https://github.com/istio/istio/issues/22290
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@abhide: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhide: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-notes_istio

integ-operator-controller-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-notes_istio

integ-operator-controller-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-notes_istio

integ-operator-controller-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test analyze-tests_istio

integ-helm-tests_istio
229314d0644d56899fb899d741b93eec393eb1f8
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhide: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-security-k8s-tests_istio

lint_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test lint_istio

gencheck_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test gencheck_istio

release-test_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test release-notes_istio

integ-operator-controller-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb0f2531fbe4aa913bf4710ae3387867c66cc886
link
/test analyze-tests_istio

integ-helm-tests_istio
229314d0644d56899fb899d741b93eec393eb1f8
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
229314d0644d56899fb899d741b93eec393eb1f8
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Train and compare ResNet with Inception classifier

Both the ResNet classifier and the Inception classifier used in umesh-timalsina/redshift will need to be trained and compared for performance on multiple datasets. Datasets should include both standard datasets like the CIFAR-10 and a subset of the sdss image set.

Models have been successfully implemented and compared using the CIFAR-10 dataset. ResNet model shows marked improvement in accuracy, as the cost of training/testing time and slightly slower convergence.