remove redundant modifiers (support recent checkstyle versions)

Coverage remained the same at 95.194% when pulling ed12b7e727ffda8fcbae1a25f074986faa24a569 on osiegmar:remove-redundant-modifiers into cc94767e7eabdfcf9d1cab1d8d1d8556864394c6 on apache:master.

Thanks! :+1:


Typed Text not saved.

I have a ReactiveTypeAhead widget for which I want to select from the selections, but if one doesn't match then it will be added as a new value.. I have the field set as Validators.required.. However no matter what I type in the field, it never updates the selection unless I select one of the suggestions..  If I do the same thing with the standard TypeAheadField it works fine as this example shows:
                      textFieldConfiguration: TextFieldConfiguration(
                        keyboardType: TextInputType.emailAddress,
                        decoration: InputDecoration(
                          labelText: 'Email',
                          icon: Icon(Icons.email),
                        ),
                        controller: _typeAheadController,
                      ),
                      suggestionsCallback: (pattern) =>
                          CitiesService.getSuggestions(pattern),
                      itemBuilder: (context, String suggestion) {
                        return ListTile(
                          title: Text(suggestion),
                        );
                      },
                      onSuggestionSelected: (String suggestion) {TypeAheadField(
                      textFieldConfiguration: TextFieldConfiguration(
                        keyboardType: TextInputType.emailAddress,
                        decoration: InputDecoration(
                          labelText: 'Email',
                          icon: Icon(Icons.email),
                        ),
                        controller: _typeAheadController,
                      ),
                      suggestionsCallback: (pattern) =>
                          CitiesService.getSuggestions(pattern),
                      itemBuilder: (context, String suggestion) {
                        return ListTile(
                          title: Text(suggestion),
                        );
                      },
                      onSuggestionSelected: (String suggestion) {
                        _typeAheadController.text = suggestion;
                      },
                      },

I added the above code to the Sample ReactiveTypeAhead example and set the input field to required, and I always got an invalid form if I didn't select an option, but on then TypeAheadField I got either the entered value, or the selected value.
How can I have a ReactiveTypeAhead field that will accept New data values? The _typeAheadController.text field will still contain the text entered if a selection is not selected.  That does not happen with the ReactiveTypeAhead. Thanks.

@vasilich6107 Thanks for all you do within this community.
I have a main.dart available here: https://github.com/JulianSwales/test_riverpod_typeahead with example code in it..
There are two issues:

Enter an email address into the email field, one that does NOT exist in the suggestions (If an email address doesn't exist in the suggestions, then the user would be adding the new member).. Then enter a last name, first name and phone and hit the book button.. It will show the email field as being required, and the form shows as invalid with null in the email field. .
If I select one of the suggestions listed, it returns the Model, instead of the string value resulting in an error.. I'm guessing I'm doing something wrong with the code here, but I don't know how to get the email from the Member model as the value into the field.  (The idea here is that the suggestion selected would auto fill the other fields) I only setup the firstName field on the valueChanges listen for the test.


SideNav hides automatically when list item is clicked

SideNav hides automatically when clicked

hi @maverickpravin
This behavior of Sidebar is by design on mobile devices. On large screens, it should stay open after a click.
If you experiencing something different, please include:

steps to reproduce the issue
CoreUI template version
@coreui/vue version
node and npm version
browser & os version


Cdx-go and JSON schema inconsistency - fields missing from DataService

The cyclonedx-go implementation is missing all the option fields for the serviceData field.
https://github.com/CycloneDX/cyclonedx-go/blob/8508cc10e87bf4be7bc76a1c7416d35bd0316b95/schema/bom-1.6.schema.json#L1972-L2046
In type Service:
https://github.com/CycloneDX/cyclonedx-go/blob/8508cc10e87bf4be7bc76a1c7416d35bd0316b95/cyclonedx.go#L1288
In type DataClassification:
https://github.com/CycloneDX/cyclonedx-go/blob/8508cc10e87bf4be7bc76a1c7416d35bd0316b95/cyclonedx.go#L519-L522
The struct is missing name, description, governance, source and destination fields.

I'm also facing the same issue - it would be great if this could be updated please

@nscuro sorry to tag you directly but I see you merged the bulk of the recent PRs etc. is this something that can be triaged please?


start stopwatch in pause mode by default not resume mode

Current Behaviour
On clicking Add stopwatch, the stopwatch is added and immediately starts running.
Expected Behaviour
the stopwatch should wait for user to click on resume to start

Hi! I'd like to work on this

closed with #21


[IBCDPE-581] Add htan workspace access to team members

Purpose: Adds Phil/Tom/Rixing to htan tower workspace

Just a heads up, I am not authorized to merge this PR


Develop

What It Does 🔎

Release 1.0.0-alpha testing CD on main branch in particular.
Documentation Updates 📘

N/A
How To Test ✔

cargo test
Linked Issues 🎫

N/A
Related Pull Requests 🔀

N/A

🛑 Wrong PR according to git flow.


Don't error in simplify_expressions rule

Which issue does this PR close?
Closes #8909
Rationale for this change
see #8910 and #8909 ,
What changes are included in this PR?
before this pr, in simplify_espression we try to fold the expression, but this can result some error, for example
select case 1 when 2 then 4/0 end;

4/0 never reach in runtime.
so in this PR, if we encounter an error during fold expression, return the origin expression, and the error will occur in runtime if it is a real error(not the short-circuit problem).
Note: this pr doesn't solve #8910 , due to #8927
Are these changes tested?
test by existing tests
Are there any user-facing changes?

cc @jackwener @alamb. This is the first step to solving #8910; the main change in this PR is that it throws an error in runtime, not in simplify_expression.
before this pr
❯ select 1/0;
Optimizer rule 'simplify_expressions' failed
caused by
Arrow error: Divide by zero error

after this pr
❯ select 1/0;
Arrow error: Divide by zero error

Thanks @alamb for the great reviews; I apply your suggestions, re-added the deleted tests and add some new tests.


Surface Recon fails on GPU but not on CPU (AWS GPU and CPU instance)

Question/Support Request
I am running surface reconstruction through a subprocess that runs ./recon-surf.sh --sd /output/Output --sid T1w --t1 /output/Output/conformed_sub-RC4210_ses-1_T1w.nii.gz --asegdkt_segfile /output/Output/sub-RC4210_ses-1_T1w.nii.gz/mri/aparc.DKTatlas+aseg.deep.mgz --allow_root. The recon fails when run on a GPU instance that has 16 GB mem available, however doesn't fail on a CPU with 8 GB mem. --threads are set to default which is 1, I am running the pipeline sequentially so left hemi first then right. The memory usage spikes considerably (~11 GB) for a few seconds during mris_sample_parc, and then I get error: mris_sample_parc: LabelAlloc() could not allocate 0-sized vector\x00' and it crashes. I run the same exact command, but on my CPU and recon runs perfectly fine. It does get heavily loaded during mris_sample_parc but it's able to struggle through and move onto the next step. Given that there is 8 GB mem on my CPU instance it's understandable that it would take recon-surf-run-time-hours  2.077, much longer than the 60 min that the docs refer to.
I know that recon doesn't use the GPU at all and the reason why a GPU instance is used (preferred) because I run the segmentation prior to the recon in a single run, and like to take advantage of the ~1 min segmentation time.
These are the dimensions of my input t1 file after running fslinfo sub-RC4210_ses-1_T1w.nii.gz
pixdim1		1.000000
pixdim2		1.000000
pixdim3		1.000000
pixdim4		0.007629

The GPU instance has been successful in running the recon for a few runs. The dimensions of those file(s) are:
pixdim1		0.976562
pixdim2		0.976562
pixdim3		1.000000
pixdim4		1.760000

Anybody have any ideas? Is it something to do with dim4 or is it really just something with with the instances I'm using.

Hi,
The high memory requirement during mri_sample_parc is strange. Maybe the freesurfer folks know why this is necessary ( or maybe they are not yet aware of this)? For that you can check their email support list and archive.
Wrt the input, you need to pass 3d images. We should check for that and stop if 4d is passed. That could cause all kinds of problems. Can you run freesurfers mri_info on the inputs? Also on the images that come out of our segmentation after conforming?

You're right, passing in 3D images results in successful recon runs. Thanks!
I ran mri_info --conformed on those input T1s' (that were 4D) segmentation outputs and they are conformed and 3D. (probably got lucky with recon finishing successfully despite those T1s not being 3D).


Update Daria and fast-test to scala 2.12

@danp11 - thanks for the PR.  Feel free to send additional commits and I'll do my best to get them merged ASAP!

Hi @MrPowers
Im a Java developer so havent written any Scala before this weekend soI gets stuck at times :-)
Im very intrested in Big Data and have lately seen Delta lake presentations
from you and others and from the Spark summit and I've decieded to learn this now:-)
Saw you written some books that looks interesting and after seeing Dominique Brezinski
last talk on Spark summit I got inspired to build a "generic" ELT pipleine.
I have started on my delta-example-fork and I'm gonna continue writing test and
develop more this coming week I hope. Although not ready yet just let me know
if you think it could be of help for others and we can put it in the repo (After polish and probably some refactor needed haha)
Regards from Stockholm, Sweden
/Dan

@danp11 - thanks for responding.  Delta is awesome.  You'll find Scala easy to learn if you're coming from the Java world!
Definitely send me your pull request.  I was also inspired to write some ELT code based on Dominique's Spark Summit talk, see this ELT snippet: https://github.com/MrPowers/spark-daria/commit/d84611bb601eb9a77d32823d7d262f2bd2a33668
Getting an ELT code snippet in here would be great.  Definitely send a PR if you can!


Feature/local development

This adds the docker compose from vf-wp.
We'll probably want to modify the configuration in .env eventually. But for now it mostly has extra things that won't hurt us.

I would like to change in the file .env:
PROJECT_NAME=emblebivfwpsis
Am I allowed to do it?

I would like to change in the file .env:
PROJECT_NAME=emblebivfwpsis

I think that should be fine. Believe it only set the local container/space of the project.


Docblock does not work.

Describe the bug
Docblock does not work. Typing /** should trigger it, but does not show anything. I have bought intelephense premium too.
To Reproduce
Steps to reproduce the behavior:
Type in a function, go 1 line above the function, type /**, you won't get a snippet list.
Expected behavior
I should see a snippet that is waiting to be completed by pressing the completion mapping.
Screenshots
https://i.imgur.com/0los5vH.png
Additional context
versions
vim version: NVIM v0.4.4
node version: v14.12.0
coc.nvim version: 0.0.79-3e5fbe3a93
coc.nvim directory: /home/aseem/.vim/plugged/coc.nvim
term: xterm-256color
platform: linux
Log of coc.nvim
2020-11-05T20:20:00.860 INFO (pid:622078) [plugin] - coc.nvim 0.0.79-3e5fbe3a93 initialized with node: v14.12.0 after 464ms
2020-11-05T20:20:01.981 INFO (pid:622078) [watchman] - watchman watching project: /home/aseem/Code/Projects/test
2020-11-05T20:20:05.578 INFO (pid:622078) [coc-phpls] - intelephense module (builtin) is ready to be started
2020-11-05T20:20:05.619 INFO (pid:622078) [language-client-index] - phpls started with 622671
2020-11-05T20:20:05.898 INFO (pid:622078) [language-client-index] - tailwindCSS started with 622851
2020-11-05T20:20:09.175 INFO (pid:622078) [completion-complete] - Results from: file
2020-11-05T20:20:10.790 ERROR (pid:622078) [languages] - Complete "phpls-1" error: TypeError: Cannot read property 'hasOwnProperty' of null
at /home/aseem/.config/coc/extensions/node_modules/coc-phpls/lib/index.js:97:29
at async Object.doComplete (/home/aseem/.vim/plugged/coc.nvim/build/index.js:71822:30)
2020-11-05T20:20:12.022 INFO (pid:622078) [willSaveHandler] - Will save cost: 62
2020-11-05T20:20:13.012 INFO (pid:622078) [completion-complete] - Results from: file
2020-11-05T20:20:13.412 ERROR (pid:622078) [languages] - Complete "phpls-1" error: TypeError: Cannot read property 'hasOwnProperty' of null
at /home/aseem/.config/coc/extensions/node_modules/coc-phpls/lib/index.js:97:29
at async Object.doComplete (/home/aseem/.vim/plugged/coc.nvim/build/index.js:71822:30)
2020-11-05T20:21:11.877 INFO (pid:622078) [willSaveHandler] - Will save cost: 63

Same situation here. Any solutions?

Same situation here. Any solutions?

Not yet. Looks like this extension is not maintained anymore. But i'm still using it.

Not yet. Looks like this extension is not maintained anymore. But i'm still using it.

I solved this problem by disabling fixer provided by 'dense-analysis/ale'.
Now I use 'stephpy/vim-php-cs-fixer' with @PhpCsFixer rule and it works!
@alalfakawma can you check your plugins and confirm this solution?

I solved this problem by disabling fixer provided by 'dense-analysis/ale'.
Now I use 'stephpy/vim-php-cs-fixer' with @PhpCsFixer rule and it works!
@alalfakawma can you check your plugins and confirm this solution?

I solved this problem by disabling fixer provided by 'dense-analysis/ale'.
Now I use 'stephpy/vim-php-cs-fixer' with @PhpCsFixer rule and it works!
@alalfakawma can you check your plugins and confirm this solution?
EDIT: Proper coc/ale config

I'm not using the lint plugins you mentioned, so I cannot confirm this.

I solved this problem by disabling fixer provided by 'dense-analysis/ale'.
Now I use 'stephpy/vim-php-cs-fixer' with @PhpCsFixer rule and it works!
@alalfakawma can you check your plugins and confirm this solution?
EDIT: Proper coc/ale config

I'm not using the lint plugins you mentioned, so I cannot confirm this.

After few days I have same problem as before my fix.

After few days I have same problem as before my fix.

@alalfakawma /** is displayed by VSCode's snippet feature.
The intelephense language server does not return completion suggestions for /**, so it may not be easy for coc-phpls to handle this.
You can use the CodeAction feature to support doc comment.
See: https://github.com/marlonfan/coc-phpls/issues/38#issuecomment-660704805

@alalfakawma /** is displayed by VSCode's snippet feature.
The intelephense language server does not return completion suggestions for /**, so it may not be easy for coc-phpls to handle this.
You can use the CodeAction feature to support doc comment.
See: https://github.com/marlonfan/coc-phpls/issues/38#issuecomment-660704805

@alalfakawma /** is displayed by VSCode's snippet feature.
The intelephense language server does not return completion suggestions for /**, so it may not be easy for coc-phpls to handle this.
There is another way to go about doc comment.
You can use the CodeAction feature to support doc comment.
See: https://github.com/marlonfan/coc-phpls/issues/38#issuecomment-660704805

I mean. It does work sometimes, that's the thing that's bothering me. Sometimes when I create a random php file and create a class, it suddenly works, but adds unnecessary lines in the doc. Meaning, it is capable of working, and there has to be a solution to make it work consistently.

@alalfakawma /** is displayed by VSCode's snippet feature.
The intelephense language server does not return completion suggestions for /**, so it may not be easy for coc-phpls to handle this.
There is another way to go about doc comment.
You can use the CodeAction feature to support doc comment.
See: https://github.com/marlonfan/coc-phpls/issues/38#issuecomment-660704805

I mean. It does work sometimes, that's the thing that's bothering me. Sometimes when I create a random php file and create a class, it suddenly works, but adds unnecessary lines in the doc. Meaning, it is capable of working, and there has to be a solution to make it work consistently.

After few days I have same problem as before my fix.
I have one solution for that: clear cache
rm -rf ~/.config/coc/extensions/coc-phpls-data

Will try this and get back with the result.

After few days I have same problem as before my fix.
I have one solution for that: clear cache
rm -rf ~/.config/coc/extensions/coc-phpls-data

Will try this and get back with the result.

I mean. It does work sometimes, that's the thing that's bothering me. Sometimes when I create a random php file and create a class, it suddenly works, but adds unnecessary lines in the doc. Meaning, it is capable of working, and there has to be a solution to make it work consistently.

Do you have any coc extensions installed, such as coc-snippets, or Vim plugins, such as ultisnips?
Is there any chance that those snippet feature are working?
If you can find a reproducible procedure, I may be able to help you with something.

I mean. It does work sometimes, that's the thing that's bothering me. Sometimes when I create a random php file and create a class, it suddenly works, but adds unnecessary lines in the doc. Meaning, it is capable of working, and there has to be a solution to make it work consistently.

Do you have any coc extensions installed, such as coc-snippets, or Vim plugins, such as ultisnips?
Is there any chance that those snippet feature are working?
If you can find a reproducible procedure, I may be able to help you with something.

I mean. It does work sometimes, that's the thing that's bothering me. Sometimes when I create a random php file and create a class, it suddenly works, but adds unnecessary lines in the doc. Meaning, it is capable of working, and there has to be a solution to make it work consistently.

Do you have any coc extensions installed, such as coc-snippets, or Vim plugins, such as ultisnips?
Is there any chance that those snippet feature are working?
If you can find a reproducible procedure, I may be able to help you with something.

Yeah I do have coc-snippets enabled, and they do work. Everything is working except the docblock, I can go to references, go to implementations, etc. As you can see in the logs above, I kept an eye on CocInfo to get the logs and this is the line that keeps popping up whenever it doesn't try to autocomplete the docblock for me -
2020-11-05T20:20:10.790 ERROR (pid:622078) [languages] - Complete "phpls-1" error: TypeError: Cannot read property 'hasOwnProperty' of null
at /home/aseem/.config/coc/extensions/node_modules/coc-phpls/lib/index.js:97:29
at async Object.doComplete (/home/aseem/.vim/plugged/coc.nvim/build/index.js:71822:30)

I mean. It does work sometimes, that's the thing that's bothering me. Sometimes when I create a random php file and create a class, it suddenly works, but adds unnecessary lines in the doc. Meaning, it is capable of working, and there has to be a solution to make it work consistently.

Do you have any coc extensions installed, such as coc-snippets, or Vim plugins, such as ultisnips?
Is there any chance that those snippet feature are working?
If you can find a reproducible procedure, I may be able to help you with something.

Yeah I do have coc-snippets enabled, and they do work. Everything is working except the docblock, I can go to references, go to implementations, etc. As you can see in the logs above, I kept an eye on CocInfo to get the logs and this is the line that keeps popping up whenever it doesn't try to autocomplete the docblock for me -
2020-11-05T20:20:10.790 ERROR (pid:622078) [languages] - Complete "phpls-1" error: TypeError: Cannot read property 'hasOwnProperty' of null
at /home/aseem/.config/coc/extensions/node_modules/coc-phpls/lib/index.js:97:29
at async Object.doComplete (/home/aseem/.vim/plugged/coc.nvim/build/index.js:71822:30)

@alalfakawma Unfortunately, it's probably just a log of coc-phpls' lack of null handling, and has nothing to do with the /** docblock.
However, I have found a way to complement the docblock.
/**|*/ (| is the position of the cursor.)
I found out that if I do the completion with this |, I get a candidate.

@alalfakawma Unfortunately, it's probably just a log of coc-phpls' lack of null handling, and has nothing to do with the /** docblock.
However, I have found a way to complement the docblock.
/**|*/ (| is the position of the cursor.)
I found out that if I do the completion with this |, I get a candidate.

@alalfakawma Unfortunately, it's probably just a log of coc-phpls' lack of null handling, and has nothing to do with the /** docblock.
However, I have found a way to complement the docblock.
/**|*/ (| is the position of the cursor.)
I found out that if I do the completion with this |, I get a candidate.

Code
<?php

/**|*/
function check(string $hoge)
{
}

Oh alright. I will try it out as soon as I get to my PC. I've never tried what you have suggested. And will report if it works or not.

@alalfakawma Unfortunately, it's probably just a log of coc-phpls' lack of null handling, and has nothing to do with the /** docblock.
However, I have found a way to complement the docblock.
/**|*/ (| is the position of the cursor.)
I found out that if I do the completion with this |, I get a candidate.

Code
<?php

/**|*/
function check(string $hoge)
{
}

Oh alright. I will try it out as soon as I get to my PC. I've never tried what you have suggested. And will report if it works or not.

@alalfakawma Unfortunately, it's probably just a log of coc-phpls' lack of null handling, and has nothing to do with the /** docblock.
However, I have found a way to complement the docblock.
/**|*/ (| is the position of the cursor.)
I found out that if I do the completion with this |, I get a candidate.

Code
<?php

/**|*/
function check(string $hoge)
{
}

I can confirm this does work. I will just create my own snippet that creates a /*|*/, and moves the cursor where the | is. I know it's not the perfect solution, but it should do for now. But I really hope this can get fixed somehow. @yaegassy Thank you for your help mate. @d0nth4x you should try this out.

@alalfakawma Unfortunately, it's probably just a log of coc-phpls' lack of null handling, and has nothing to do with the /** docblock.
However, I have found a way to complement the docblock.
/**|*/ (| is the position of the cursor.)
I found out that if I do the completion with this |, I get a candidate.

Code
<?php

/**|*/
function check(string $hoge)
{
}

I can confirm this does work. I will just create my own snippet that creates a /*|*/, and moves the cursor where the | is. I know it's not the perfect solution, but it should do for now. But I really hope this can get fixed somehow. @yaegassy Thank you for your help mate. @d0nth4x you should try this out.


Minimal Fatal Shock search algorithm

In the paper: https://www.nature.com/articles/s41598-020-68805-6

Minimal fatal shocks in multistable complex networks, Halekotte & Feudel, 2020

The authors discuss a "shock-induced-tipping" and quantifying its resilience via the Minimal Fatal Shock.
The main gist of the idea is in Fig. 1 of the article.
I think it is possible, and perhaps even simple, to implement an algorithm that computes this for a generic dynamical system in a generic manner.
Inputs should be dynamical system and initial condition u_0 and a function that quantifies the change of attractor (or we use automatic search in basins? I'll need to read the paper in more detail to say more about this function. It is the color coding of the figure below)

There is some code here: https://github.com/halekotte/mifas but I doubt it will be of much help. The code isn't generic enough to be applied in arbitrary dynamical systems. However reading parts of the code will speedup making our own implementation here.

A student wants to apply to implement this in GSoC. I guess he can start wit hthe easy stochastic part and then we can have a meeting to think about the second step.

Sounds good! If we are not tied to the original implementation we can dig into the ecosystem of Julia package for constrained optimization (NonConvex.jl for example). I have a couple of ideas we can explore.


NIFI-4326: Add unit test cases

Hi @btwood,
Here is the pull request that adds test cases. In addition to the NPE, I added test cases for the non-strict address parsing feature you added.
In preparing this, I came across a few other things that I included with this PR:

Removed unused headers that were failing the mvn -Pcontrib-check for Apache NiFi
Changed the STRICT_ADDRESSING PropertyDescriptor "required" field to "false" (it defaults to "true", which will be used if getProperty is called for an unset property.
Noticed that the javax.mail library we are using has a Session property to set strict=true|false, which does the same thing we were trying to accomplish, so I used that to cut down on code to maintain in this Processor.
Extracted some repetitive code doing the null check and looping into a private static helper method (this was not your code, this was repetitive code that already existed in the processor which was just getting a bit worse with the added null checks).

Let me know if you agree with these changes. Thanks!

Looks good. I'm going to throw some of my production data at it just to test. But it looks a lot cleaner than it did before.
The edits you made are also more in keeping with the coding style and verbiage of the project, which is appreciated.
I'll merge this and commit to upstream once my short test it done. I think we can close out the issue today if it all goes well.

@kevdoran
ExtractEmailAttachments.java had the "STRICT_ADDRESSING" property descriptor in it as well.
It has been removed in this code and replaced with non-strict call to "getFrom()", was that a desired change?
That seems to be the only thing that is functionally different between our branches. My testing of the processors works for my use case. If you think that ExtractEmailAttachments.java is correct then I can go ahead an merge. Otherwise we may want to add the property back.

Oops. That may have been only in my local copy.
So to change my question, should we add the same property to ExtractEmailAttachments.java?

Good catch!
TBH, I'm not sure of the value of the getFrom() in ExtractEmailAttachments, as the contents of the From/Sender headers are never stored/written (ie, to an attribute). It is only checked for presence, effectively as part of a poor man's RFC-2822 validation check.
So in this case, I think there are two viable options:

Add the new strict address parsing property descriptor, with the same behavior, to maintain consistency with ExtractEmailHeaders.
Do the same check, but only use non-strict address checking in this processor as the extracted values are never used outside of the processor's internal logic. That is, something like this, with the same function gut the strict address property hardcoded to false instead of being read from a property descriptor:

Properties props = new Properties();
props.put("mail.mime.address.strict", "false");  // because result of getFrom() is never written
Session mailSession = Session.getInstance(props);
MimeMessage originalMessage = new MimeMessage(mailSession, in);
MimeMessageParser parser = new MimeMessageParser(originalMessage).parse();
// RFC-2822 determines that a message must have a "From:" header
// if a message lacks the field, it is flagged as invalid
Address[] from = originalMessage.getFrom();
if (from == null) {
    throw new MessagingException("Message failed RFC-2822 validation: No Sender");
}
Date sentDate = originalMessage.getSentDate();
if (sentDate == null ) {
    // Throws MessageException due to lack of minimum required headers
    throw new MessagingException("Message failed RFC-2822 validation: No Sent Date");
}

I normally prefer configurability and consistency, but in this case I think the presence of this property has the potential to also confuse the user as the processor documentation does not indicate why it the style of mailbox address handling (unless they are also using ExtractEmailHeaders and read that processor's documentation, which gives the context for the property's purpose).
Perhaps a compromise would be to change the property descriptor's display name from "Use Strict Email Addresses" to "Use Stricter RFC Format Validation", or something along those lines. Then it could be used in both processor's with a clear meaning, and in the future a developer could use the same property to control other parsing logic where there is a "letter-of-the-RFC" and "likely-to-be-encountered-in-the-wild" decision to make.
I'm not very inclined in any particular solution here, so I leave it up to you as to how to handle this in ExtractEmailAttachments.

I have no problem making it a "looser" processor. From my perspective, it would be silly to fail extracting a mail attachment because of the sender address. (Often spoofed and almost guaranteed to be wrong depending on the upstream data source.) And I would also argue that people wouldn't be using this processor to "validate" mail.
My vote would be for relaxing the validation check in this processor. But I'm not the only stakeholder. I think it would also be reasonable to add/rename the property to allow for tuning.

I agree with you. Let's submit the PR that way and see what others think. At least one committer will need to weigh in before this gets to NiFi master.

OK. I'll accept this if you have no more changes then. I can triple check, clean up anything else, and submit mine after that.

As part of the clean up, You may want to change "true" and "false" values from strings to use the AllowableValue class. Here is an example: https://github.com/apache/nifi/pull/2148/files#diff-4f399a5e493f124a256ae2740c20f839


Separate cookies jar

It would be nice if Vienna had its own cookie jar so it doesn't use Safari's one.
This way you can see pages without having Google, Twitter, Facebooc & co. associate your browsing to the account you're logged in in Safari.

https://stackoverflow.com/questions/364219/how-can-i-have-multiple-instances-of-webkit-without-sharing-cookies might help us implement this.

WKWebView solves this problem.

It is already solved by recent versions of OS X (Apple changed the behavior).
So, now, Vienna is lacking a cookie manager… 😸

I'm still on Yosemite. I hope I can update soon

Might be of interest for further work on this subject : BinaryCookieReader.
Usage : python BinaryCookieReader.py  ~/Library/Cookies/uk.co.opencommunity.vienna2.binarycookies

This is probably a bigger issue now based on the proliferation of trackers. I know I generally open links in an external browser now due to this shortcoming. It should go back to at least the Nice to Have list.


Infer test cases from input HeroSeries in test_indexes

Currently test_indexes save all test cases using hard encoding, by listing all functions and their valid inputs separately, where lots of functions share the same input. With HeroSeries objects as inputs, it seems easy infer a valid input for each of them.
For example, save a allowed_hero_series_type variable for each function,
def InputSeries(allowed_hero_series_type):
...
    def decorator(func):
        func.allowed_hero_series_type = allowed_hero_series_type
        @functools.wraps(func)
        def wrapper(*args, **kwargs):
...

Then iterate all functions through dir(hero) and generate test cases,
# Define the valid inputs for each HeroSeries type
valid_inputs = {
    "TokenSeries": s_tokenized_lists,
    "TextSeries": s_text,
    "VectorSeries": s_numeric_lists
}

test_cases = []
# Find all functions under texthero
func_strs = [s for s in dir(hero) if not s.startswith("__") and s not in {'preprocessing', 'visualization', 'representation', 'nlp', 'stopwords'}]

# Exceptions for test cases in case they need specific inputs
test_case_exceptions = {
    "pca": ["pca", representation.pca, (s_numeric_lists, 0)]
}

for func_str in func_strs:
    if func_str in test_case_exceptions:
            test_cases.append(test_case_exceptions[func_str])
    else:
        func = getattr(hero, func_str)
        if hasattr(func, 'allowed_hero_series_type'):
            if func.allowed_hero_series_type.__name__ in valid_inputs:
                test_cases.append([func_str, func, (valid_inputs[func.allowed_hero_series_type.__name__],)])

Will it make the code cleaner and easier to maintain?

Hey @AlfredWGA, I agree with you and it seems a good idea!
The only part that might be tricky is that for some functions we need to pass more than one parameter (see for instance pca in test_indexes).
By the way, we should also test that all functions work when the given Series input is empty and also when it contains nan values. I believe we can unify all these three tests ...

The only part that might be tricky is that for some functions we need to pass more than one parameter (see for instance pca in test_indexes).

That can be done by manually adding test cases like
# Exceptions for test cases in case they need specific inputs
test_case_exceptions = {
    "pca": ["pca", representation.pca, (s_numeric_lists, 0)]
}

And adding empty and nan Series test shouldn't be a problem, I'll work on that.

Beautiful!

See #130 for test handling nan


Help setting up Hubot for development

So I was trying to set up hubot for development and I followed the instructions and did npm link from my local clone and npm link hubot in my test hubot. But when I run the hubot it fails when requiring modules from external-scripts saying that they are not found despite them being installed in my test hubot's node_modules folder

This is a duplicate of https://github.com/github/hubot/issues/804 The workaround is in https://github.com/github/hubot/issues/804#issuecomment-116659253:
export NODE_PATH=$NODE_PATH:./node_modules

perhaps this should be added to CONTRIBUTING.md ?

Closing a duplicate.


Getting an error use of deprecated version

Error : This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2.
But when I edit your code by replacing the line actions/upload-artifact: v2 by
actions/upload-artifact: v4 I was able to get the APK created.
I'm new to GitHub and YAML, but I was able to fix an issue by updating a deprecated version. However, I'm still getting warnings during debugging. Could you please explain if these warnings are a concern and how I can address them?
I'm seeing several warnings during debugging, but my application seems to be running fine and creating the APK correctly. Could you explain if this is a potential issue, and if so, how I can address it? Additionally, can you modifying your GitHub repository?

I will soon update the deprecated versions of some packages, but using the
latest @.*** its still ok
On Sun, 22 Sep 2024, 08:18 vinay375, @.***> wrote:

Error : This request has been automatically failed because it uses a
deprecated version of actions/upload-artifact: v2.
But when I edit your code by replacing the line actions/upload-artifact:
v2 by
actions/upload-artifact: v4 I was able to get the APK created.
I'm new to GitHub and YAML, but I was able to fix an issue by updating a
deprecated version. However, I'm still getting warnings during debugging.
Could you please explain if these warnings are a concern and how I can
address them?
I'm seeing several warnings during debugging, but my application seems to
be running fine and creating the APK correctly. Could you explain if this
is a potential issue, and if so, how I can address it? Additionally, can
you modifying your GitHub repository?
—
Reply to this email directly, view it on GitHub
https://github.com/digreatbrian/buildozer-action/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A4MAPRYZDJC7FR5IOFXSZWDZXZOMFAVCNFSM6AAAAABOUIKHP2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DANRWGE3DONY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Error : This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2.
But when I edit your code by replacing the line actions/upload-artifact: v2 by actions/upload-artifact: v4 I was able to get the APK created.
I'm new to GitHub and YAML, but I was able to fix an issue by updating a deprecated version. However, I'm still getting warnings during debugging. Could you please explain if these warnings are a concern and how I can address them?
I'm seeing several warnings during debugging, but my application seems to be running fine and creating the APK correctly. Could you explain if this is a potential issue, and if so, how I can address it? Additionally, can you modifying your GitHub repository?

Just update the the versions of actions to v4 for example upload-artifact@v4 and checkout@v4. This will ensure the action to work right away. Refer to my buildozer-action readme, it's now updated.


Play video from asset or raw folder

Tried to play a video in my raw folder like this
String path = "android.resource://"+  getPackageName() + '/' + R.raw.test;
videoView.setUp(path, JCVideoPlayerStandard.SCREEN_LAYOUT_DETAIL, "Test Video");

but it doesn't work and shows this error in the logcat "Protocol not found"
I tried to follow the instructions linked on the readme https://github.com/Bilibili/ijkplayer/issues/1013 but it's from a dependency project and the discussion is not very clear on how it applies to this library. Either way i tried some things they mentioned but that didn't work either
Uri uri = Uri.parse(path);
        if(uri.getScheme().equals(ContentResolver.SCHEME_ANDROID_RESOURCE)) {
            AssetFileDescriptor fileDescriptor = null;
            try {
                fileDescriptor = getContentResolver().openAssetFileDescriptor(uri, "r");
            } catch (FileNotFoundException e) {
                e.printStackTrace();
            }
            IMediaDataSource dataSource = new RawDataSourceProvider(fileDescriptor);
            if(fileDescriptor != null)
                JCMediaManager.instance().mediaPlayer.setDataSource(dataSource);
            else{

                return ;
            }
        }

All my searches on how to do this have ended up with closed issues with no clear explanation. Maybe how to do this can be added in the sample app?
Also found this comment on the dependency project "Playback of asset file is not a completed feature, for now." https://github.com/Bilibili/ijkplayer/issues/1303 so if it's not supported yet maybe it should be removed from the readme

Play video in assets you should copy to local path first.Try by myself like thistextureview will stop on first frame and error on logcat
没懂你什么意思 参见 主页这个解释

I think somthing wrong with ijkplayer, ijkplayer should make function complete, should not let other people config before use.

@YuJunKui2016 you're just repeating what's stated in the readme it doesn't work
@lipangit you're right...the admin him self said this on one of the issues "Playback of asset file is not a completed feature, for now." https://github.com/Bilibili/ijkplayer/issues/1303
Perhaps there's something we can do to allow it to play local files? I'll look into it...

5.0+support assert video

@lipangit How? I tried use url "file:///android_asset/test.mp4", but this not work.

Play video in asset folder, see demo ActivityApiCustomMediaPlayer.java， it will show you how to custom video player


After update, Select all is work wrong

VSCode version 1.23.1
Node 7.9.0
Windows 7 64bit
Steps to Reproduce:

Open any file
Press Ctrl + a or use menu to select all

Then, the text area is alway selected, and I can't edit this file anymore, even after I close the editor and reopen VSCode, the files is also in that state. Is this a bug?

Does this issue occur when all extensions are disabled?: Yes

@TonyGao My suspicion is drag and drop is blocking you. Can you try to set editor.dragAndDrop to false and see if you can reproduce?

It's my bad, after days it's not occur anymore, I don't know why, but I will close this issue.


Coveralls spamming

Can we please disable the automatic reply from Coveralls? The response in the check below each PR is enough I think, we are getting spammed, see #12

I think this is a result of the different jobs (5.6, 7.0, 7.1) on Travis all reporting separately to Coveralls. I'll look into disabling the PR comments from Coveralls.

I think these settings will disable the PR comments. We'll see the next time a PR is created.
Thanks for reporting this!


Add a command keybinding to kill link URL into kill-ring

In many situation, I need to copy out the link URL to other places.

Looks good, thanks!


Prepare migration from contractkit

Splitting the following issue in two since dappkit is done but contractkit is taking a while longer to properly finalize the way forward.

#10207

Current migration guide from contractkit

#10228

Brief note: can be closed when migration guide is published


Autofocus P. D. bug

Autofocus does not work in GUI

Not a bug, in OASYS workflow you have to initialize the elements first...


commit history and permalinks broken?

I have some permalinks to this repo that are now broken due to recent changes. For example this link is now a 404: https://github.com/newrelic/newrelic-python-agent/blob/v<IP_ADDRESS>/newrelic/newrelic/core/data_collector.py
The history of commits seems to also have been force-pushed over. This breaks git mirroring into our downstream custom version of this package. Additionally, all the useful git history is now gone. The oldest commit is now only 27 days ago? So when we experience issues between older versions, we cannot see the commits that happened between versions...

Hi @spyoungtech. Thank you for submitting this issue.
To get the permalinks to work, please remove the the extra 'newrelic/' from the path. For example, use the link below:
https://github.com/newrelic/newrelic-python-agent/blob/v<IP_ADDRESS>/newrelic/core/data_collector.py
We moved our code over to the new repo 27 days ago to make our agent code open source. The code however does reflect changes back to version 5.2.0. For example, this link shows the changes made between v5.2.0 and v5.8.0 https://github.com/newrelic/newrelic-python-agent/compare/v5.2.0...v5.8.0
With the agent now open sourced, I would encourage you to submit the changes you made in your custom version back to the original repo.
Let me know if we can help.

I see. I think I understand now what happened and the source of my confusion. Thanks for the help.


feat: release JS SDK V3

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@95f9291). Click here to learn what that means.

:exclamation: Current head f64f76c differs from pull request most recent head 633e0f2. Consider uploading reports for the commit 633e0f2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage        ?   69.51%
=======================================
  Files           ?       19
  Lines           ?      561
  Branches        ?      110
=======================================
  Hits            ?      390
  Misses          ?      139
  Partials        ?       32

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support oneOf

This is in support of Zil0's effort on documenting E2E (#1284).

In HTML you'll have the schema defined inside a oneOf list (e.g., CipherTextInfo from zil0's PR) converted to a separate table; and instead of things like string or object you'll be able to get string or CipherTextInfo. A similar trick can be used in push rules (I'll probably make a separate PR to improve their definition using oneOf).


Add unit test cases

Codecov Report

Merging #55 into master will increase coverage by 22%.
The diff coverage is 96.8%.

@@           Coverage Diff            @@
##           master      #55    +/-   ##
========================================
+ Coverage   18.17%   40.17%   +22%
========================================
  Files          13       14     +1
  Lines         930     1023    +93
  Branches      123      126     +3
========================================
+ Hits          169      411   +242
+ Misses        741      564   -177
- Partials       20       48    +28

Impacted Files
Coverage Δ

src/wss_mgr.c
2.72% <100%> (+2.72%)
:white_check_mark:

src/connection.c
57.48% <66.66%> (+57.48%)
:white_check_mark:

tests/test_connection.c
97.75% <97.75%> (ø)

src/string_helpers.c
100% <ø> (+100%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ea6b5...bd5f2b0. Read the comment docs.

Merged as https://github.com/Comcast/parodus/pull/58


Only on Ruby 3: wrong number of arguments (given 2, expected 1) (ArgumentError)

projects = Gitlab.group_projects(43).auto_paginate raises the below error on Ruby 3.0.2. Changing to Ruby 2.5.8 and the problem is gone.
/home/nowaker/.rvm/gems/ruby-3.0.2/gems/json-2.1.0/lib/json/common.rb:156:in `initialize': wrong number of arguments (given 2, expected 1) (ArgumentError)
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/json-2.1.0/lib/json/common.rb:156:in `new'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/json-2.1.0/lib/json/common.rb:156:in `parse'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/json-2.1.0/lib/json/common.rb:335:in `load'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab/request.rb:35:in `decode'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab/request.rb:18:in `parse'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab/request.rb:12:in `block in <class:Request>'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/httparty-0.18.1/lib/httparty/request.rb:327:in `parse_response'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/httparty-0.18.1/lib/httparty/request.rb:295:in `block in handle_response'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/httparty-0.18.1/lib/httparty/response.rb:35:in `parsed_response'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab/request.rb:61:in `validate'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab/request.rb:51:in `block (2 levels) in <class:Request>'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab/client/groups.rb:185:in `group_projects'
        from /home/nowaker/.rvm/gems/ruby-3.0.2/gems/gitlab-4.17.0/lib/gitlab.rb:28:in `method_missing'

I believe this isn't an issue with gem. We have specs that are passing on Ruby 3.0 https://github.com/NARKOZ/gitlab/blob/master/spec/gitlab/paginated_response_spec.rb

@NARKOZ I'll check when I'm back to work and let you know.


Config file

Hi,
I am having issues installing this package onto Lumen.
The config file located in config/pusher.php is completely ignored, instead the vendor/vinkla config file is used.
As far as i can see, the issue lies here:
https://github.com/vinkla/pusher/blob/master/src/PusherServiceProvider.php#L44:L46

Did you turn enable the configuration functionality?

Have you registered the service provider correctly?

http://lumen.laravel.com/docs/installation#configuration-files

I added this to app.php.
$app->register('Vinkla\Pusher\PusherServiceProvider');
$app->configure('pusher');

Thanks @vinkla

:+1:


Compare performance of WordPress 4.4 through 4.7

One year on from producing the unpublished results for WordPress 4.4 and each of the top 12 plugins I want to produce a new set, to see if the plugins are more or less efficient than their previous versions.

I needed to create a new 'vanilla' control for WP 4.4 and the base set of 35 plugins.
To ensure comparable results I needed to eliminate from the input file those queries that caused more than one transaction to be run in the server.

The results indicate that WordPress itself has slowed down.

It would be nice to know the main causes of this performance degradation

and whether or not anything can be done about it.

Prime candidates are the REST API, and action and filter hook logic changes in 4.7

See vanilla-44-47-summary.ods for the result set that indicates that the run time server performance has increased by 9% average.
WordPress 4.7 is slower than WordPress 4.4 due to:

Unverified performance degradation in WordPress 4.5 ( added 0.5% )
Additional logic and query for 'can_compress_scripts' ( added 1.55%, in WordPress 4.6 )
Additional logic and query for Custom CSS ( added 2% )
Addition of REST API
Increased number of hook invocations
New hook logic - difficult to measure
Other changes


Upgrade style to desktop display

In this pull, following changes were made;

Add display for desktop
Use media query
Refactor previous mobile style

Thank you @roshan-bajgain for your painstaking review.


Improve placement and design of temporary status banners

Once we update or change UI frameworks, I'd like to explore options to improve the placement and display of temporary status banners. Currently we tend to display them at the top of the page. Many of our pages are long forms, and so we have an awkward behavior where the message either appears "above the fold" or we automatically scroll people to the top when they may prefer to stay put.
I also am not a fan of the current color scheme with colored text on a colored background -- not the easiest to scan.
I want to investigate best practices, and check out any available libraries that could make this work easy for us to implement.

Duplicated by other tickets.


Decode a Morse code message

Create a method to decode a Morse code character, takes a string parameter, and return the corresponding character in uppercase (e.g. decode_char(".-") returns "A").
Create a method to decode an entire word in Morse code, takes a string parameter, and return the string representation. Every character in a word will be separated by a single space (e.g. decode_word("-- -.--") returns "MY").
Create a method to decode the entire message in Morse code, takes a string parameter, and return the string representation

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @HanaSabih and @eric2umeh,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Kindly format your README using this template. All the main headers should be present and properly linked to different sections in the README
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


FormatOfLeadingComment

Hello Cemalettin;
First of all: thank's for your pretty nice helper.
it' working very well.
I tested it a bit a found one problem:
I have an ini with a leading Comment.
It is read from Disk ok, but when i write it to Disk then there is a problem with the Line-ending.
You can only see it in a hex-editor, texteditors correct it automatically.
In the leading Comment is only a linfeed (\n) appended and not a CR\LF (\r\n)
I think the problem is in file "setting.cs" line 528 + 540
return string.Format("{0}\n{1}={2}" should be  return string.Format("{0}\r\n{1}={2}",
But i haven't tested it.
May be you can look for?
thanks a lot
best regards
Klaus

Hey Klaus, thanks and you're welcome!
That's actually correct and a big mistake, as it shouldn't be \n and also not \r\n, but rather Environment.NewLine (which is \r\n on Windows, and corresponding on other platforms).
I will fix that, thank you for the hint.
Cheers!

Alright, it's fixed by the new version, 1.5.4!


[jsonConfig]: admin.0 - ical has an invalid jsonConfig

No existing issues.

[X] There is no existing issue for my request.

Problem location
ioBroker Log
Warning message
ical has an invalid jsonConfig: [{"instancePath":"/items/_calendars/items/calendars/items/5","schemaPath":"#/items/allOf/6/then/allOf/1/additionalProperties","keyword":"additionalProperties","params":{"additionalProperty":"width"},"message":"must NOT have additional properties"},{"instancePath":"/items/_calendars/items/calendars","schemaPath":"#/patternProperties/%5E.%2B/allOf/27/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match "then" schema"},{"instancePath":"/items/_calendars","schemaPath":"#/properties/items/patternProperties/%5E.%2B/allOf/9/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match "then" schema"},{"instancePath":"","schemaPath":"#/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match "then" schema"}]
Source link
Nichts zu sehen
Additional information
No response

Please add link to source file (jsonConfig.json).
Nichts zu sehen passt da nicht so wirklich.

Sorry @mcm1957
Ist eingefügt, ich hoffe das ist richtig so...


Gradle-intellij-plugin 0.4.7 not compatible with Gradle 5.4-rc1

Gradle 5.4-rc1 updated IvyDescriptorFileGenerator again in 5.4-rc1, causing the configuration of the plugin to fail.

thanks


Create inspection to report if the default selector is used in Terra.validates calls

Summary of scope
The scope is to implement an inspection for Terra.validates.screenshot(); and related calls, so that it would report when an explicitly specified CSS selector is the same as the one defined as default in the project's wdio.conf.js.
Solution details

The inspection would report the CSS selector string literal when it is exactly the same as the default selector.
The calls to include:

Terra.validates.screenshot
Terra.validates.element
Terra.it.validatesScreenshot
Terra.it.validatesElement

Example for a wdio.conf.js file: https://github.com/cerner/terra-toolkit-boneyard/blob/main/docs/Wdio_Utility.md#configuration-setup

Out of scope

N/A

Completed.


Stan -> CmdStan

Stan.jl has been deprecated in favour of CmdStan.jl. This PR uses CmdStan.jl when available, much like how we used Stan.jl.

Changes are minimal, and tests pass so merging.


Composer report error when select "false" in if-else step

Describe the bug
Composer report error when select "false" in if-else step

Version

Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

create a if-else step
choose bool for condition, select "false"
See error

Expected behavior
Should not report error for this case

Screenshots

Additional context

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2821


Make it clear that 'cog' is the specific cog mentioned in the README.md not any other

There's a few different 'cogs' out there, it might be helpful to state they need to install the one specified in the readme.

Hi @quarterturn 👋🏼
Thanks for your input. Can you help me understand where specifically this clarification is needed?

I think it's clear in the README that this project is called Cog, and that references to "cog" within this project would be about this project.
Since this issue was opened, we've also updated the README in this repo to include a table of contents to make it more clear what's covered, including installation:

Hopefully that helps. I'm going to close this, but feel free to weigh in if I'm missing something.


Bug in the reported standard error for lnratio with vce(svy)

sysuse nlsw88, clear
svyset _n

dstat proportion married, over(union, lnratio)

Ln(ratio) of proportion                         Number of obs     =      1,878
                                                Contrast          =    0.union

            0: union = Nonunion
            1: union = Union

------------------------------------------------------------------------------
     married | Coefficient  Std. err.      t    P>|t|     [95% conf. interval]
-------------+----------------------------------------------------------------
1            |
     married |
     Single  |   .1580814   .0689764     2.29   0.022     .0228029    .2933599
    Married  |  -.0903165   .0419407    -2.15   0.031    -.1725718   -.0080612
------------------------------------------------------------------------------

dstat proportion married, over(union, lnratio) vce(svy)

(running dstat_svyr on estimation sample)

Survey: Ln(ratio) of proportion

Number of strata =     1                        Number of obs     =      1,878
Number of PSUs   = 1,878                        Population size   =      1,878
                                                Design df         =      1,877
                                                Contrast          =    0.union

            0: union = Nonunion
            1: union = Union

------------------------------------------------------------------------------
             |             Linearized
     married | Coefficient  std. err.      t    P>|t|     [95% conf. interval]
-------------+----------------------------------------------------------------
1            |
     married |
     Single  |   .1580814   .0227501     6.95   0.000     .1134634    .2026995
    Married  |  -.0903165   .0227501    -3.97   0.000    -.1349345   -.0456984
------------------------------------------------------------------------------

This is now fixed. Thanks for reporting the bug.
Explanation: dstat stored the original influence functions instead of the transformed influence functions when lnratio was specified, such that svy reported the SEs of the original results rather than the transformed results; this was because the code implementing lnratio accidentally turned the Mata view containing the influence functions into a non-view.


API Rate Limiting

(Inspired by @awitherow's question)
Right now it seems that the only method that has any notion of API rate limiting is PublicClient.fetchTrades.
I think it would be a good idea to somehow abstract rate limiting lower down closer to the actual http/request calls so that all of the clients' methods can use it transparently.
Looking at docs.gdax.com/#rate-limits, it says that

When a rate limit is exceeded, a status of 429 Too Many Requests will be returned.
REST API
PUBLIC ENDPOINTS
We throttle public endpoints by IP: 3 requests per second, up to 6 requests per second in bursts.
ENDPOINTS
We throttle private endpoints by user ID: 5 requests per second, up to 10 requests per second in bursts.

Knowing these limits, and with a single internal handler of rate limiting, we could theoretically keep track of the requests going out and preemptively hold them (maybe even in a queue) if it would be expected to return a 429 anyways. That way, we wouldn't have to wait an entire RTT to find out that we hit a limit, potentially having tried to fire off more in the meantime.
Sidenote: I'm not sure what GDAX defines as "bursts", I haven't found anything about it elsewhere in the docs.

And execute the requests one by one via a promise interface?

Having a queue that synchronously executes one after the other would probably be the easiest thing to implement, and might be a good place to start.
We may also consider a scenario where, if the API is limited to n requests per second, a client that has been idle for a while wants to send n new, independent requests very quickly. Theoretically, the client should be able to send all of those at once without having to wait for a response from each one. To support that in combination with preemptive limiting, we would some more internal state that remembers timing.
My initial thought is that a {Public,Authenticated}Client instance will need to remember the timestamp of the last n requests that successfully fulfilled. The timing information, coupled with the request queue, would determine whether a request could be fired now, fired after some time from now, or added to the end of the queue to be handled later after other pending requests.
And for completeness' sake, it will still need to handle catching 429 responses and then re-enqueuing / retrying requests.

With the switch to using superagent for network requests, there's a plugin superagent-throttle that adds the ability to automatically handle a lot of this logic.
The implementation in #86 uses this throttling by default.

Hi @fb55 ,
Regarding question 1 above: "Also, is the distinction between public/private endpoints per URL, or by whether valid auth credentials are included? E.g., what if an AuthenticatedClient instance were used to call a public endpoint?"
BTW, the limiter module does rate limiting and allows for bursting. It is used in the gdax-tt module.

Also, is the distinction between public/private endpoints per URL, or by whether valid auth credentials are included? E.g., what if an AuthenticatedClient instance were used to call a public endpoint?

The latter. If you provide credentials your limits are bumped for public endpoints.

BTW, the limiter module does rate limiting and allows for bursting. It is used in the gdax-tt module.

Good to know :)


BREAKING CHANGE: upgrade for compatibility with graphql transformer v2

fixes https://github.com/flogy/graphql-ttl-transformer/issues/12
But I did not update unit tests or documentation. Just wanted to contribute changes needed to upgrade this directive to v2.
Also I did not test scenario where you change the ttl attribute on an existing table. From https://github.com/aws/aws-cdk/issues/13106 it appears that scenario is not supported through CDK.

Thanks for the awesome PR! Just merged it and will release it together with some more optimizations like fixing the tests soon!


Fix conversion of TextChanges to FileCodeEdits for new file

Should fix  #24118
@mjbvz Could you test this out in your branch?

We should add a fourslash/server test for this. but i would do that in a different PR, since the infrastructure is not there yet.


Not possible to deploy functions from VS Code. Region error on multiple regions.

Does this occur consistently?
Repro steps:

Following the Azure Training https://docs.microsoft.com/en-us/learn/modules/automatic-update-of-a-webapp-using-azure-functions-and-signalr/7-exercise-host-a-static-website-using-a-storage-account

After set up VS Code with the Subscription ID, and then trying to use Azure Function: Deploy Advance and Basic modes, neither works.

Tried on 4 different zones, none works.

Action: azureFunctions.deploy
Error type: Unauthorized
Error Message: The scale operation is not allowed for this subscription in this region. Try selecting different region or scale option.
 You can read more here and just try a different region to see if it works

As demand continues to grow, if we are faced with any capacity constraints in any region during this time, we have established clear criteria for the priority of new cloud capacity. Top priority will be going to first responders, health and emergency management services, critical government infrastructure organizational use, and ensuring remote workers stay up and running with the core functionality of Teams. We will also consider adjusting free offers, as necessary, to ensure support of existing customers.


Understanding how cloud-config gets loaded and used

Hi,
This is not an issue per se but more of a request for confirmation that I am understanding this correctly.
I was struggling to understand what was happening Vagrantfile#L95-L96 and why the image used by Vagrant had the vagrant-specific directory: /var/lib/coreos-vagrant/ and file: /var/lib/coreos-vagrant/vagrantfile-user-data. I got here because I'm trying to wrap my head around CoreOS, Fleet, etcd, etc. I want to use these for as much of my web/service development as I can. I hope to be able to emulate production clusters locally and hopefully be able to use the same cloud-config or a very similar one in localdev and production. With that in mind, I need to understand what goes where and why.
So I went into a CoreOS instance via vagrant ssh and, after much Googling that got me to realize systemctl was what I needed to understand, ran systemctl list-units | grep vagrant which yielded:
coreos-cloudinit-vagrant-user.path                                                       loaded active running   coreos-cloudinit-vagrant-user.path
<EMAIL_ADDRESS>           loaded active exited    Load cloud-config from /var/lib/coreos-vagrant/vagrantfile-user-data

This tells me there are at least two units related specifically to vagrant. One seems to set up a path and the other loads a cloud-config file from a file within said path (as stated in the description).
I then ran systemctl show coreos-cloudinit-vagrant-user.path and got (truncated for brevity):
PathExists=/var/lib/coreos-vagrant/vagrantfile-user-data
MakeDirectory=no
<EMAIL_ADDRESS>paths.target shutdown.target

This seems to ensure that:

/var/lib/coreos-vagrant/vagrantfile-user-data exists and...
this unit is loaded Before<EMAIL_ADDRESS>but it...
does not create the directory if it doesn't exist by setting MakeDirectory=no

Correct?
Then I ran systemctl show<EMAIL_ADDRESS>which yielded a number of lines but most importantly:
ExecStart={ path=/usr/bin/coreos-cloudinit ; argv[]=/usr/bin/coreos-cloudinit --from-file=%f ; ignore_errors=no ; start_time=[n/a] ; stop_time=[n/a] ; pid=0 ; code=(null) ; status=0/0 }

In there I see /usr/bin/coreos-cloudinit being called with the %f specifier which refers to the instance name (I believe). This is how the user-data file gets consumed, correct?
I tend to prefer keeping things simple, customizing or depending on as little as possible. I would like to know why the decision to create a Vagrant-specific directory and file and not simply place the cloud-config in a predetermined location since CoreOS comes with Fleet built in and should expect it to exist somewhere already, no?
Understanding this will help me figure out if I can share configuration files between Vagrant (localdev) and production (probably GCE) and probably how. I don't know if that'll be possible but it's worth a try.
Thank you,
Luis

Hi Luis,
I have a similar requirement as yours, i.e. emulating production env using VMs, but keeping the configuration and corresponding directories as close to the actual production env.
-Nitin

@nr17 +1

@nr17 & @starkovv My work on this was interrupted by other issues and projects but I haven't given up on it yet. I'll post a followup here as soon as I can. Sorry for not being able to get back sooner.

I have a similar question about /var/lib/coreos-vagrant/vagrantfile-user-data.
I have seen several units defined in vagrantfile-user-data, for example,
coreos:
  etcd2:
    name: master
    listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
    advertise-client-urls: http://$public_ipv4:2379,http://$public_ipv4:4001
    listen-peer-urls: http://$private_ipv4:2380,http://$private_ipv4:7001
  fleet:
    public-ip: $public_ipv4
    metadata: "role=master"
  flannel:
    interface: eth1
 ...

Those services have been started automatically when vagrant machine is up. I do not see the fleetctl start *.service or anything along this line to start those service
      if File.exist?(CLOUD_CONFIG_PATH)
        config.vm.provision :file, :source => "#{CLOUD_CONFIG_PATH}", :destination => "/tmp/vagrantfile-user-data"
        config.vm.provision :shell, :inline => "mv /tmp/vagrantfile-user-data /var/lib/coreos-vagrant/", :privileged => true
      end

Does CoreOS start this cloud-config file (vagrantfile-user-data ) by default? If I want my production server to load the same exactly cloud-config file, what name and path should I use to auto load those default services?
thanks


Remove h4 headings from the in-page contents menu

The material theme we're using provides a contents menu for each page. It is automatically populated with the headings from the page, h2 > h4 (at least). For this site, we only want h2 and h3 headings including in the contents menu.
Example: https://techwritertoolkit.com/consultant/core-values/
The contents menu there includes all the "Example" h4 headings, which looks messy.
Customize the theme to only include h2 and h3 headings.
Refer to guidance in the theme docs: https://squidfunk.github.io/mkdocs-material/customization/#extending-the-theme. This task involves overriding a partial.

To clarify, the way to do this is to find the partial .html file in the Squidfunk theme that controls the in-page toc, and override.


Incorrect tab change with multiple browser windows on Firefoy

Extension Version
1.7.6
Description
Steps to reproduce:

Start Firefox. Create 2 browser Windows.
In browser Window A: Start 5 tabs (sth. doesn't matter).
In browser Window B: Start 2 tabs.
In browser Window B: Login to an AWS Account with extension. (AWS Console is now on 3rd tab.)
In browser Window A: Login to the same Account using extension.
Behavior: The extension switches to the third tab in the current browser window. Seems like the extension ignores the browser Window information.

=> Not sure whether this is fixable with switching to the other browser window. But this would be the expected output, but it might also be confusing, as the other window may be on a completely different screen.
Browsers
Firefox
OS
Mac

Good find, this should be fixed now.


Update Speech Recognition documentation

Formatting improvements
Grammar

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@miparnisari : Thanks for your contribution to the Azure documentation! The author, @priyaravi20, has been notified to review your proposed change.

@miparnisari : Thanks for your contribution to the Azure documentation! The author, @priyaravi20, has been notified to review your proposed change.

#sign-off


v-for alternative

Hi all. In most of all case this directive work fine. But i have 10k+ elements. And v-for has frieze. I'll tried to create custom directive with same functional.  But this is not possible with the current directive functionality.
What i guess: add some property to 'v-for' for asynchronous appending to DOM.
P.S. Sorry for my English =) TY.

Please use our forum or Discord for questions like this.


Display only recipes with picture in Recipes#Index

Okay but you need to sort by id DESC

corrected in b9dd3e6


[apollo-tooling] bump bootstraped version of Apollo to 4.0.0-beta.3

Eat our own @catch food.

Field insights ✅

Made another pass at it. Looks like we can factor the error handling. See ApolloResponse.toException (source). Let me know what you think

I merged this PR so it doesn't become stale and we can move forward with other PRs. Reminder to ourselves to re-test again using the integration test since there's been a few changes since your last tests.


Model speed

Hello! I m trying to create cpu-real-time face recognition system based on GhostFaceNets. Detection model that i use shows 50-60 fps. But when i add verification step (Feature extraction via GhostFaceNets) the speed of system drops to 3 fps (checked on Macbook Pro A1708 and Magicbook15). is that how it should be? Is it any option to increase speed? Have you tried to create cpu-real-time face recognition system based on GhostFaceNets? What fps did you gained?
I've used code below
feauture_extractor = keras.models.load_model('models/GN_W0.5_S2_ArcFace_epoch16 (1).h5', compile=False)
for faces in faces:
   ...
   cropped_face = img[y:y + h, x:x + w]
   cropped_face = tf.image.resize(cropped_face, [112, 112]) /255.0
   cropped_face = tf.expand_dims(cropped_face, axis=0)
   face_embedding = feauture_extractor(cropped_face)

Hi,
Let me test it and get back to you by the end of the day hopefully.

Hello! I m trying to create cpu-real-time face recognition system based on GhostFaceNets. Detection model that i use shows 50-60 fps. But when i add verification step (Feature extraction via GhostFaceNets) the speed of system drops to 3 fps (checked on Macbook Pro A1708 and Magicbook15). is that how it should be? Is it any option to increase speed? Have you tried to create cpu-real-time face recognition system based on GhostFaceNets? What fps did you gained? I've used code below feauture_extractor = keras.models.load_model('models/GN_W0.5_S2_ArcFace_epoch16 (1).h5', compile=False) for faces in faces:  ...  cropped_face = img[y:y + h, x:x + w]  cropped_face = tf.image.resize(cropped_face, [112, 112]) /255.0  cropped_face = tf.expand_dims(cropped_face, axis=0)  face_embedding = feauture_extractor(cropped_face)

Hi,
Let me test it and get back to you by the end of the day hopefully.

i found that this model GhostFaceNetV1-0.5-2 (A) (which i used firstly) is slower than GhostFaceNetV1-1.3-2 (A).
GhostFaceNetV1-0.5-2 inference time:

GhostFaceNetV1-1.3-2 inference time:

However GhostFaceNetV1-0.5-2 have less parameters than GhostFaceNetV1-1.3-2 according to paper:

i found that this model GhostFaceNetV1-0.5-2 (A) (which i used firstly) is slower than GhostFaceNetV1-1.3-2 (A). GhostFaceNetV1-0.5-2 inference time:  GhostFaceNetV1-1.3-2 inference time:
However GhostFaceNetV1-0.5-2 have less parameters than GhostFaceNetV1-1.3-2 according to paper:

Hi,
Sorry for being late in replying, I am in an exams period in my university.
This should not be the case, based on the experiments done to produce the results in the paper, GhostFaceNets with width of 0.5 were extremely fast to train and test.
I will develop a full system for you on CPU as soon as possible; but again, currently busy with the exams so I cannot promise when it will be ready. Hopefully in one day time.

I will develop a full system for you on CPU as soon as possible;
Don't bother yourself with it. My CPU is just so slow to use this model in real-time system.


Problems with null values on prediction time

I have trained a classification model with two categorical variables:

country
browser

I have done it in  Datalab with Tensorflow version 1.8. Since there can be missing values in both variables, I have used defaults values in the reading function:
CSV_COLUMNS = ['country', 'browser', 'indDownloaded']
LABEL_COLUMN = 'indDownloaded'
DEFAULTS = [['Zimbabwe'], ['Opera'], [0]]

def read_dataset(filename, mode, batch_size = 512):
      def decode_csv(value_column):
          columns = tf.decode_csv(value_column, record_defaults = DEFAULTS)
          features = dict(zip(CSV_COLUMNS, columns))
          label = features.pop(LABEL_COLUMN)
          # The key passes through the graph unused.
          return features, label

      filenames_dataset = tf.data.Dataset.list_files(filename)
      textlines_dataset = filenames_dataset.flat_map(tf.data.TextLineDataset)
      dataset = textlines_dataset.map(decode_csv)

      if mode == tf.estimator.ModeKeys.TRAIN:
          num_epochs = None # indefinitely
          dataset = dataset.shuffle(buffer_size = 10 * batch_size)
      else:
          num_epochs = 1

      dataset = dataset.repeat(num_epochs).batch(batch_size)

      return dataset

I wanted to export the model to use it in real time. In the serving function I have used  placeholder_with_default functions in order to manage the missing values:
def serving_input_fn():
    json_feature_placeholders = {
      'country' : tf.placeholder_with_default(
        input = ['Zimbabwe'],
        shape = [None]
      ),

      'browser' : tf.placeholder_with_default(
        input = ['Opera'],
        shape = [None]
      )
    }

    features = json_feature_placeholders # no transformation needed
    return tf.estimator.export.ServingInputReceiver(features, json_feature_placeholders)

Once the model was ready to be deployed, I wanted to check what happened when one variable was missing (country is the missing one). This is how I did:
%%writefile ./test.json
{"country": "Venezuela"}

%%bash
gcloud ml-engine local predict  \
    --model-dir=path _to_the_model \
    --json-instances=./test.json

Everything is ok with the local prediction. However, when I deploy to the MLE and test with missing values, I get some errors.
Input 1
%%writefile ./test.json
{"country": "Venezuela"}

Output1
{
  "error": "Prediction failed: Error during model execution: AbortionError(code=StatusCode.INVALID_ARGUMENT, details=\"input size does not match signature\")"
}

Input 2
%%writefile ./test.json
{"country": "Venezuela", "browser" : null}

Output 2
{
  "error": "Prediction failed: Error processing input: Expected string, got None of type '_Message' instead."
}

I am using the following comand:
%%bash
gcloud ml-engine predict --model=${MODEL_NAME} --version=${MODEL_VERSION} --json-instances=./test.json

So, locally I manage to set one variable to null and get a prediction. However, on the Cloud that is not possible. Can you help me, please? I think this is related to https://github.com/tensorflow/tensorflow/issues/10014

@dizcology could you followup this.

@dizcology PTAL


sha

Could you elaborate on how you obtain a sha at the end of the version number ? I imagine it's obvious but...

This addon uses git-repo-version library which appends first 8 characters from git SHA to the version number in package.json. You can tell it to not add but SHA by adding + to the end of the version number.

<IP_ADDRESS>fd42c31
1.1.1+beta1 (+ causes it to not append the sha)

(1.1.1 is taken from package.json)

Thanks, however I can't get it to add the SHA.

My project is under git
I have  "version": "1.0.0" in my package.json
I tried to add git-repo-version and even git-repo-info to my dependencies

I feel like I'm missing something here... Maybe it is because I'm under ember-cli 0.1.2 ?

It looks like I was wrong. It works the opposite to how I described. If you add + to the end, then it will append .sha. So, if you set the package.json version to 1.0.1.beta, then it will become 1.0.1.beta.2fd42c31
I changed this code to accommodate a request and now I don't understand it's intended to be used.

@cibernox why does git-repo-version only append a hash to a version that has + in it? Can you describe the workflow that git-repo-version was created for?

@taras It was for ember.js / ED workflow.
In fact, I basically extracted and splitted a bit of functionality that was present in some ember-related projects: https://github.com/emberjs/ember.js/blob/00d1be8c455ff32b7a3005baa88ee70c3a75105a/lib/calculate-version.js
In ember, only builds with +canary or +beta get a sha at the end.
It might be a good idea add a parameter to force SHA addition and that defaults to true if the version has a + in the name.

I'm not sure if a pattern that is used for Ember framework development is appropriate for Ember App development.
In a large app that I was working on, we were using tags to mark all versions, so 1.0.1 would be a tag and the version in package.json. Our versioning would then automatically add SHA to end when there were commits beyond the latest tag. So, you know you're on a commit that was created after 1.0.1 was tagged.
@cibernox @florent-blanvillain does the Ember framework versioning workflow work for apps? Is my suggested workflow better? what do you think?

It makes sense to me. If this commit has a tag on it, that's its name. If not, recover the latest tag in history and add the SHA.
I think that that workflow could work for both, ember and apps.

@cibernox to make this possible, we'd need to modify https://github.com/rwjblue/git-repo-info/blob/master/index.js because it doesn't currently know anything about tags.

Yes, the need to change that.
I've found a case that is not covered by that workflow, at least in ember project. Right now, master is tagged with 1.11.beta.1. The last tag is 1.10.beta4. Which one wins? I assume that always the newest one.

It would be whichever is in package.json, because "since tag" is calculated on commits since last tag. If that information is missing, it will just append the hash to version in package.json.

In a nutshell:
A. Current commit is tagged
Use the tag. P.e 1.0.1
B.  Current commit is not tagged
Go back in history to find the last tagged commit.
B1) There is a tag and is greater than the on in package.json: Use tag + SHA
B2) Otherwise (no tags was found or it's older than the one in package.json): Use the version in package.json + SHA
Right?

B. Current commit is not tagged
Use the version in package.json + SHA

In essence, we're only adding the ability to match tags to commits. From code prospective, we'll need to replace version.indexOf('+') with isCurrentCommitTagged()

I have work for this evening then :)

@rwjblue I ping you just in case you have something to add here about if this approach will work for ember.js

@cibernox awesome :)

@taras @cibernox It would be just perfect for my usage :)

git-repo-info 1.0.3 has been released and now includes the tag for the current sha (if available).  Thanks @cibernox!

Version 0.1.0 of git-repo-version released: https://www.npmjs.com/package/git-repo-version

@rwjblue @cibernox you guys rock! version 0.3.0 released with tag support!


Allow overriding of service name via values.yaml

Can we modify the name of the service object so that it can be customized via values.yaml? i.e. change it from this:
 {{- default .Release.Name -}}

To something like so:
 {{- default .Release.Name .Values.nameOverride | trunc 63 | trimSuffix "-" | trimSuffix "." -}}

I have a top-level chart that pulls in nats-operator alongside other charts, and there are cases where a top-level chart has two third-party sub-charts that use {{- default .Release.Name -}} for the name of a service object (resulting in a naming collision). It'd be great to be able to override this outright.

We've gotten similar requests in other Helm chart like this so I think sounds good to adopt nameOverride here as well
https://github.com/nats-io/k8s/commit/c43203fe9b5fb5f6c59b335188c6832a0b033b6e

That's almost exactly the patch I would have proposed (if I had to write it from scratch). It's to my understanding that .Release.Name and templated values (i.e. from _helpers.tpl) in sub-charts cannot be overriden via the parent chart, so it's either this type of change, or forking the chart.

While we're at it, can we extend this feature to the nats-box helper-pod?

@wallyqs I'm happy to provide the PR/patch, if it helps with lead time. Do you have a docker container or test/regression script I should test my patched chart against prior to putting up the code review?

Thanks @IAXES this is a small fix so I can take a look at it today.

A bit confused, it seems that the helm chart here already supports nameOverride: https://github.com/nats-io/nats-operator/blob/master/helm/nats-operator/templates/_helpers.tpl#L7
Maybe this is a duplicate of https://github.com/nats-io/k8s/pull/62?

Here's the repo setup I have:
nats                    https://nats-io.github.io/k8s/helm/charts/

Inspecting the output of helm fetch nats/nats (output is in nats-0.4.0.tgz):
nats/templates/service.yaml
---
apiVersion: v1
kind: Service
metadata:
  name: {{ template "nats.name" . }}
  labels:
    app: {{ template "nats.name" . }}
    chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
spec:
  selector:
    app: {{ template "nats.name" . }}
  clusterIP: None
  ports:
  - name: client
    port: 4222
  - name: cluster
    port: 6222
  - name: monitor
    port: 8222
  - name: metrics
    port: 7777
  - name: leafnodes
    port: 7422
  - name: gateways
    port: 7522

From ``nats/templates/_helpers.tpl
 1 {{/*
 2 Expand the name of the chart.
 3 */}}
 4 {{- define "nats.name" -}}
 5 {{- default .Release.Name -}}
 6 {{- end -}}

So, assuming I'm pulling the latest-and-greatest helm release of NATS-operator correctly, the K8S service object doesn't support the features exposed by the above-noted patch.

Interesting. The source for the chart at the link you provided is considerably different from the source bundled with https://nats-io.github.io/k8s/helm/charts/. Are these two separate project repos/forks?

@IAXES That's because you are pulling older version than is currently in master.
I think @wallyqs have to make a release so it is available.

@IAXES yes they are different repos, and thinking on moving the helm chart in the repo from the operator to be hosted there to be served along the other charts.  I will migrate this issue to that repo too as well since related to those charts then.
Also I have just released version v0.4.2 of the nats charts, so nameOverride would be possible to be used now: https://github.com/nats-io/k8s/releases/tag/v0.4.2
Thanks


sysadmins: Document CentOS 6 Python 2.7 and Ice 3.5 installation

This describes the manual steps to set up Python and Ice, and also how to configure the environment to start up the server.
I've tested this on a bare CentOS 6 install, and if you repeat the instructions you should get something similar to below.  You should also be able to connect with insight, upload and view images etc.
/cc @joshmoore @chris-allan @stick
[rleigh@localhost OMERO.server-5.1.4-ice35-b55]$ bin/omero admin start
Creating /opt/omero/OMERO.server-5.1.4-ice35-b55/var/master
Creating /opt/omero/OMERO.server-5.1.4-ice35-b55/var/registry
No descriptor given. Using etc/grid/default.xml
Waiting on startup.  True	Is writable? True
OMERO temp dir:'/home/rleigh/omero/tmp'       Exists? True	Is writable? True   (Size: 20384)

JVM settings: Blitz                         -Xmx600m -XX:MaxPermSize=512m -XX:+IgnoreUnrecognizedVMOptions
JVM settings: Indexer                       -Xmx400m -XX:MaxPermSize=512m -XX:+IgnoreUnrecognizedVMOptions
JVM settings: Pixeldata                     -Xmx600m -XX:MaxPermSize=512m -XX:+IgnoreUnrecognizedVMOptions
JVM settings: Repository                    -Xmx400m -XX:MaxPermSize=512m -XX:+IgnoreUnrecognizedVMOptions

OMERO.web status... WARNING: FastCGI support is deprecated and will be removed in OMERO 5.2. Install Gunicorn and update config.
[NOT STARTED]

Otherwise, makes sense. Leaving you and @manics to decide the zip/rpm/job work which will test this. (There's some danger of those getting out of sync. If that can be fixed via an @include, then :+1:)

Is this good to merge or do you want additional changes?

This still needs signing off @joshmoore

@hflynn: listed for tomorrow standup

Otherwise, makes sense. Leaving you and @manics to decide the zip/rpm/job work which will test this. (There's some danger of those getting out of sync. If that can be fixed via an @include, then :+1:)

e.g. omero-install? That's somewhere on my todo list (and a downloadable RPM for ice would be nice)...
A general comment, there's no top-level overview to tell people where to start reading. These are both pages of links:
https://www.openmicroscopy.org/site/support/omero5.2-staging/sysadmins/
https://www.openmicroscopy.org/site/support/omero5.2-staging/sysadmins/unix/index.html

@jburel Fix pushed.

Thanks

Looks good to me, here's the scripts I used for testing: https://github.com/manics/omero-install/compare/wsgi-release...manics:wsgi-release-c6-py27?expand=1

Thanks @rleigh-dundee. Merging


OpenCart v3.x

Any plans to support OpenCart v3.x?

there's a plan to support oc v3.x. maybe on another branch or diffrent repo. it's been on the pipeline already

Hi there, just incase you haven't create the oc3 module.. still on my github, please try it on..
https://github.com/harrypujianto/SNAP-Opencart3


fix(server): Fixed Refreshing forgets new server

PR related to this trello task --> https://trello.com/c/nhjNsgEE

:tada: This PR is included in version 1.3.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix loading stats file with py3.5 (part deux)

Supersedes #5
Committing the test case first to see how it behaves with travis. Actual fix to be added.

Coverage remained the same at 100.0% when pulling 0833bf54af1a1709cbcd890cf0a8103d1e1e6ebb on tetframework:py35-stats-fix-rebased into 62ae7f8fe21cbea540e8e3a3557c407a8f4fa521 on stevearc:master.

The new test case fails for py3.4 and 3.5 (as expected): https://travis-ci.org/stevearc/pyramid_webpack/builds/272069113

Coverage decreased (-0.5%) to 99.459% when pulling aa60dcb5bd47890b91a2235661874f61f98db669 on tetframework:py35-stats-fix-rebased into 62ae7f8fe21cbea540e8e3a3557c407a8f4fa521 on stevearc:master.

I changed the implementation so that StaticResource always returns a text stream. Previously, it returned a binary stream (in py3) if path was given in the a:b/c notation.
This should fix the issue.

Coverage remained the same at 100.0% when pulling 9d600d927df056bf7256ace5d01e1a37b46aeebe on tetframework:py35-stats-fix-rebased into 62ae7f8fe21cbea540e8e3a3557c407a8f4fa521 on stevearc:master.

Looks great! Thanks for the PR!


FIX: wh_pos with DisconnectedError

Looks like this now:
[[OPHYD_DEV]] In [1]: wh_pos()

+------------+---------------+--------------+--------------+
| Positioner |         Value |    Low Limit |   High Limit |
+------------+---------------+--------------+--------------+
| vx         |     -98.52000 |   -140.00000 |   -140.00000 |
| vy         |    2896.12300 |   2800.00000 |   3000.00000 |
| vz         |      11.41000 |      0.00000 |      0.00000 |
| zpssx      |       INVALID | Disconnected | Disconnected |
| zpssy      |       INVALID | Disconnected | Disconnected |
| zpssz      |       INVALID | Disconnected | Disconnected |
+------------+---------------+--------------+--------------+

Looks good to me. I'll let one more pairs of eyes take a look before it's merged.

@klauer Could you verify that this fixes log_pos also?

@dchabot Can you make unit tests a high priority? It's a bummer that we were able to render these two functions unusable without noticing it.

Added some untested fixes for log_pos_diff/log_pos_mov - which we don't use at the HXN. If you agree with the implementation, mind giving it a go @dchabot?

log_pos fixes from @ericdill added - reported working at the beamline. Look good enough to merge yet?

@dchabot?


Feature request: support CiliumNetworkPolicies

We're keen to integrate cyclonus into Cilium's CI (https://github.com/cilium/cilium/issues/14722).
As a stretch goal, would it be possible to extend cyclonus to support CiliumNetworkPolicys? These include features beyond standard Kubernetes NetworkPolicys.

Closing as stale.


To add a course page

Is your feature request related to a problem? Please describe.
I want to add course page so that the website is one more step closer to being professional.

@thestarsahil what courses should I add here???? Any suggestions


RUBY CAPSTONE PROJECT

Link --> https://github.com/users/jr-cast/projects/4
Microverse was not able to assign me a team. I was offered 2 options, wait until Sep 5th or do the project solo. I opt for the second option. So there is only one person in this repository.
I assigned myself tasks from Team member #1 and half of the tasks of  Team member #3. Both tasks related to Book items, labels and authors' objects.

Hi @jr-cast,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted an issue, that doesn't have a link to their GitHub project.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Thanks for the feedback Shahier. It´s done, you can see the updated link in the issue above.

Please resubmit it again.

Hello again @ShahierNashaat I already did it one hour ago but it's still under review, can you help me with that, please?

Hi @jr-cast 😊,
STATUS: APPROVED! 🥇 💯

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit: 🚀
Congratulations! 🎉
Highlights
✅ Kanban board setup correctly.
✅ Project has met all the technical aspects you needed for this project. Keep rocking!
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


camel case folders & linux

Hey,
I had an issue while publishing (yarn run ig:publish)
Load Content                                                                     (19.0363sec)
Publishing Content Failed: Unable to find file /home/nps/git/shr-cli/./out/fhir/guide/resources/implementationguide/shr.xml (19.0364sec)
                                                                                (19.0364sec)
Use -? to get command line help                                                  (19.0364sec)
                                                                                (19.0364sec)
Stack Dump (for debugging):                                                      (19.0364sec)
java.lang.Exception: Unable to find file /home/nps/git/shr-cli/./out/fhir/guide/resources/implementationguide/shr.xml

ls out/fhir/guide/resources/
CodeSystem  ImplementationGuide  StructureDefinition  ValueSet

moving those folders to lower case solved the issue.
Looks like an unix issue with case sensitive path or something (I am using linux)
Thanks

Thanks for the report.  Sometimes I forget that my Mac filesystem is case insensitive (it feels like it should be case sensitive).  We'll take a look at this.

This has been fixed via the shr-fhir-export 4.2.2 release and the shr-cli 4.3.2 release.


Improving UI design of contribution page

@Anuj3553 I would like to enhance the user interface design of the contribution page, Faq page for a more intuitive and engaging experience.

I see that while clicking on privacy page its empty page.

I believe we should add a team member who has experience developing projects to strengthen our team.

Hyy @Pushpa472, I'm assigning this issue to you.

Can you give star to this repo?

yes

@Anuj3553 Above I share img of FAQ not found that img , I got this .
It's correct

@Anuj3553 Above I share img of FAQ not found that img , I got this . It's correct

Yes its correct

@Anuj3553 I see that team is already implement in about us page.


Add 3 MB limit to pagerduty.rb

assuming duplicate method is identical, move into service.rb (and remove the definition from zapier)
consider adding a pagerduty test case for a long form submission. slack_test.rb has an example.

@markdascher assigned back to you

json_limited was identical in neptune.rb and zapier.rb, so I moved it into service.rb.
created a test_size_limit in pagerduty_test.rb, mimicking the tests in neptune.rb and zapier.rb.


feat: add demo rust program

Closes #
Wrote a rust app that connect to the bridge port, receive Actions and also sends payload data.
Changes
Add demo rust app
Why?
To demonstrate the use of uplink with a connected application.
Trials Performed
Ran against normal uplink instance connected to local broker, verified receiving bridge Action and response.

In order to keep things simple, I feel like we should do this in a single file, demo.rs. For that we will have to remove non std deps like serde.

The changes look good. Can you verify if read_to_string has intended behaviour? i.e. does it overwrite the string as we want it to, or does it append the newly read values to the string. You can check within the docs by running examples or by actually sending Actions with this rumqttc example.

It seems like read_to_string doesn't overwrite the string and it continues to append newly added read values to the string until EOF (i.e until the socket closes). So the current code seems to print all the received actions together upon the closing of the tcp socket, that too in a loop.

So the current code seems to print all the received actions together upon the closing of the tcp socket, that too in a loop.

We better not do that and use the right solution for this, which I believe would be lines.


defmt 0.2.0

bors r+

panic-probe release does not seem to have been successfully uploaded to crates.io


rails-assets not picking the latest version?

I'm having a strange problem with rails-assets-alephbet. It was updated to version 0.12.0 a while ago. On bower it shows the latest version, but on rails-assets it still shows version 0.11.0. Any idea why?

rails-assets does have functionality to automatically grab and build latest versions, but it wasn't being used due to it not having been integrated with Capistrano at all and fear of more overloading issues (which have since been resolved quite well).
I'm developing that part now on https://github.com/tenex/rails-assets/tree/lb/fix-update-scheduler

Fix has been merged and is deploying now.

Verified that cron was updated, and manually triggered the scheduler. All of the components should be updated shortly.

Thanks, @hut8

This is taking longer than anticipated, as the jobs that fetch the metadata were being enqueued every 3 hours, and it takes longer than that for the jobs that are spawned by those jobs to complete. So I changed it to update every 12 hours.
The job that enqueued the build job for alephbet completed, but the build job will be done by tomorrow (I hope ;)
Anyway, just wanted to update you on that.

Looks fixed.