RigidBody2D pushing KinematicBody2D when hit from a certain angle and using move_and_collide

Godot version:
3.0.2, 3.0.3
OS:
Ubuntu 16.04
Issue description:
A RigidBody2D (Ball), with a child CircleShape2D, manages to push a KinematicBody2D (Palette), with a child CapsuleShape2D, when it hits the bottom-right corner of the Palette while being moved with move_and_collide.
The Ball is moving upwards by setting its linear_velocity to (0, -400) and the Palette is being moved downwards by calling move_and_collide(Vector2(0.0, 100 * delta)) in _physics_process(delta).
Additionally, other relevant properties of the Ball where changed:

Gravity Scale was set to 0.
Friction was set to 0.
Bounce was set to 1.

The expected result was the ball just bouncing off towards the down-right diagonal direction. The result was:

The Palette being displaced in the X axis towards the left side, but keeping its downward movement.
The Ball bouncing off towards the top-right diagonal direction with its velocity reduced.

I believe this is a bug since the Docs state that A KinematicBody2D can be affected by gravity and other forces, but you must calculate the movement in code. The physics engine will not move a KinematicBody2D.
Steps to reproduce:

Open Minimal Reproduction Project in any of the reported Godot Versions.
Play the Project and watch the effect.

Minimal reproduction project:
CollisionBug.zip
Experiments:

Instead of setting the Ball's linear_velocity manually i called apply_impulse in _ready. Yielded the same result. Just wanted to make sure this wasn't something of the kind "don't set properties manually, apply forces instead" type of issue.
Lower the Ball's mass to minimum. Yielded the same result.
Replace the Palette's collision shape with a RectangleShape2D. This led to the ball continually pushing the Palette in upwards direction which i believe isn't intended behavior either.
Changing the Ball's continous_cd property to Cast Shape which fixed the issue. However, bumping the speed of both the Ball and the Palette made it reappear. This leads me to believe that maybe this isn't exactly a bug but an implementation limit of the physics engine when dealing with high speed objects. If this is indeed the case, should we document this interaction somewhere?

The issue here is that you are using move_and_collide, when the ball s too close, the separation makes the capsule try to avoid the rigid, the only option on Godot 3.0 is to use a children KB to collide with the ball.
Godot 3.1 applied some inertia settings that allow the KB to ignore the rigids so is solved there.

Indeed, if i don't move_and_collide the Palette this doesn't happen.
I will keep the test project to check the behavior when 3.1 is released.
Should we close or archive the issue?

Not sure if close, but probably, the fix breaks compatibility so I guess it cannot be picked for 3.0
Is #16757


feat(rr2.6): update to be compatible with the RR 2.6

Reason for This PR

Update to RR 2.6

Description of Changes

Update events bus
Update all deps

License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[x] Any required documentation changes (code and docs) are included in this PR.
[x] Any user-facing changes are mentioned in CHANGELOG.md.
[x] All added/changed functionality is tested.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: rustatian:x: dependabot[bot]You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #118 (8824a29) into master (222d7d2) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   65.43%   65.28%   -0.15%
==========================================
  Files          18       18
  Lines        1027     1040      +13
==========================================
+ Hits          672      679       +7
- Misses        263      268       +5
- Partials       92       93       +1

Impacted Files
Coverage Δ

activity/rpc.go
57.14% <ø> (ø)

client/metrics.go
66.66% <ø> (ø)

client/plugin.go
74.62% <ø> (ø)

protocol/converter.go
63.15% <ø> (ø)

protocol/message.go
45.63% <ø> (ø)

protocol/worker_info.go
42.85% <ø> (ø)

workflow/id_registry.go
66.66% <ø> (ø)

workflow/worker.go
84.05% <ø> (+2.62%)
:arrow_up:

activity/plugin.go
39.09% <44.44%> (-1.11%)
:arrow_down:

workflow/plugin.go
66.37% <50.00%> (+6.91%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222d7d2...8824a29. Read the comment docs.


System.Exception: Correlation failed.

Hi Skoruba, I am having the following problem, when I run the band new version, from the scratch.
I ve followed all those steps in https://github.com/skoruba/IdentityServer4.Admin and however it runs :
I am running two apps
http://localhost:9000 for \IdentityServer4.Admin\src\Skoruba.IdentityServer4.Admin
http://localhost:5000 for \IdentityServer4.Admin\src\Skoruba.IdentityServer4.STS.Identity
all the others steps went fine ( including miggrations )
but when I ran, then I ve got the following situation

Hi @alvarovalle
did you change the default configuration? :)
Please, check detailed log.

nops.
by the way, I am running out of container.
I am just running dotnet run over both of them.

I have the same issue, and I'm pretty sure that it's linked to SameSite cookie changes issue. In fact I had no problem with Mozilla

Hi Skoruba, I am having the following problem, when I run the band new version, from the scratch.
I ve followed all those steps in https://github.com/skoruba/IdentityServer4.Admin and however it runs :
I am running two apps
http://localhost:9000 for \IdentityServer4.Admin\src\Skoruba.IdentityServer4.Admin
http://localhost:5000 for \IdentityServer4.Admin\src\Skoruba.IdentityServer4.STS.Identity
all the others steps went fine ( including miggrations )
but when I ran, then I ve got the following situation

Thanks guys for reporting this. I will fix it.

@fahaad05  that is it.
I ve tryed in mozilla firefox and that worked on it.
but what makes me think is that my costumers will want to run on chrome browser.
so I am not sure if it has o be hot-fixed in skoruba
or in https://identityserver.io/
What do you suggest mr @skoruba ?

Hi, I fixed this issue here: https://github.com/skoruba/IdentityServer4.Admin/commit/12f62d9dc12c76056ec5811c42b8d43a20465a4d - please try clone dev branch and verify this fix. Thanks.

Hello, this is still happening on chrome (version 80.0.3987.132).

Just like @alvarovalle said, on firefox it works correctly. However, for curiosity I've tried to http://localhost:9000/signin-oidc directly on it and got the same error (I don't know if this is the normal behaviour or not).

Hi, did you use latest dev? Thx

Google Chrome: Version 80.0.3987.149 (official version) (64-bit)
I found that many people have problems after updating chrome recently, the dev version still reports an error
My error message is the same as above

Hello,
Just to share what was done on my side to make it works (I'm still on the beta7 due to the number of changes).
First of all, you can read this: https://www.thinktecture.com/en/identity/samesite/prepare-your-identityserver/?fbclid=IwAR2nIi3CBKLZ-JJLSGVfXLTW_2oQQCSgTpxm80UDNjkiJBD_5tiTN9YikyM
with almost the same code as Skoruba already have done in 3 différents commits:
https://github.com/skoruba/IdentityServer4.Admin/commit/12f62d9dc12c76056ec5811c42b8d43a20465a4d
https://github.com/skoruba/IdentityServer4.Admin/commit/b346c5fbaf9dbc368d290eb46dadcff056632f20
https://github.com/skoruba/IdentityServer4.Admin/commit/b4921fc7e2ad1ab6c236844a5c7fd92a81f07ce6
The only changes on my side is on the last commit, I put options.Secure = CookieSecurePolicy.Always; and not options.Secure = CookieSecurePolicy.SameAsRequest;
You can see that this line was not referenced in my first link, this was an issue and have to add it manually.
I think the fix is the same for https://github.com/skoruba/IdentityServer4.Admin/issues/532

@CaminGui Hi, I have read this article you provided before, and I also modified my other applications in accordance with the practices in the article, but the Conrrelation failed error still appears above, and I found a strange thing, the same version of Chrome Browser, my colleague can log in normally, but not my computer.

Hi, did you use latest dev branch? Thx

I applied the commit 12f62d9 on my project, which is based on your master branch.

Please check all changes in dev.

Ok, I'll try it now and report it back to you.

@CaminGui Hi, I have read this article you provided before, and I also modified my other applications in accordance with the practices in the article, but the Conrrelation failed error still appears above, and I found a strange thing, the same version of Chrome Browser, my colleague can log in normally, but not my computer.

@myesn, Can you try to disable this chrome://flags/#cookies-without-same-site-must-be-secure, you should be able to login and then take a look on your cookies, they should be SameSite = None and Secure.

Untill this is not the case it will not work with the cookies-without-same-site-must-be-secure flag set to default / enabled

@CaminGui Thank you, now he can work normally

@skoruba I keeps happening on the dev branch. However, the solution provided by @CaminGui is working!

@pfaustinopt IdentityServer4 author has reported issues to aspnetcore official
https://github.com/IdentityServer/IdentityServer4/issues/4170
https://github.com/dotnet/aspnetcore/issues/19939

And we won't be "fixing" it. It's by design. You should be running over https, especially for identity server installations

I will switch dev environment to https #550.

We recently ran into an issue on another project that seems similar to this. We found that google seems to be selectively deploying new requirements to browsers to adhere to the cookie behavior where samesite=none must be accompanied by the secure flag. The fact that they're deploying it selectively to some clients but not others (with the same version) might be making this more confusing. I mean, I could be wrong about that but it seems that's what they were doing based on our internal testing. So, to the fix.
services.AddAuthentication(options =>
{
...
})
...
.AddOpenIdConnect("oidc", options =>
{
options.NonceCookie.SecurePolicy = Microsoft.AspNetCore.Http.CookieSecurePolicy.Always;
options.CorrelationCookie.SecurePolicy = Microsoft.AspNetCore.Http.CookieSecurePolicy.Always;
});
This worked for our stuff. I'm not sure it applies here because honestly i'm just revisiting the project and saw this issue and it rang a bell.

Additionally, I should add that there are definitely installations that run over http behind a reverse proxy or on kubernetes in a private environment and don't encrypt the backend traffic. I agree that best practice should be to run over https, but there are certain exceptions that are acceptable

@cculver
thanks a lot for this. I was having infinite redirect with Chrome only and I have TLS termination at Ingress. you solution made Chrome happy!

Yes, Thanks @cculver!!! I wasted entirely way too much time on this, and your solution fixed it for me.


Integrate reef tests with our customizations

I would prefer to either cherry-pick the old commit or copying over the additional information from the commit message.

Done, thanks for pointing that commit out to me.


Minimum carb absorption for AMA

When deviation is <= 0 after a meal, we should still assume carbs are absorbing (slowly), and that BG is failing to rise for some other reason. This will prevent COB from staying high indefinitely until the carbs fall off the back of the pumphistory. For starters, perhaps use a minimum carb impact of 3 mg/dL per 5m. This would only apply for historical carb absorption, not for calculating current and future carb impact.

Think this will help with active days a lot

This is ready for testing.  Two line change.  ;-)

Looks like this is working: carbs are slowly decaying even with negative deviation.

Nice, I'll update to latest AMA today

Working well so far.

Working good for us also, estimate looking much better
I still see COB higher that actual carbs right after meal, maybe we limit that?

Can you paste/link an example of what you're seeing there?

18g snack and right after COB was 28.65
Jun 08 10:12:16 indy-e1 openaps-loop:  pump://JSON/model/monitor/model.json
Jun 08 10:12:16 indy-e1 openaps-loop:  reporting monitor/model.json
Jun 08 10:12:16 indy-e1 openaps-loop:  pump://JSON/read_status/monitor/status.json
Jun 08 10:12:16 indy-e1 openaps-loop:  reporting monitor/status.json
Jun 08 10:12:16 indy-e1 openaps-loop:  pump://JSON/iter_pump_hours/monitor/pump-history.json
Jun 08 10:12:16 indy-e1 openaps-loop:  reporting monitor/pump-history.json
Jun 08 10:12:16 indy-e1 openaps-loop:  tz://JSON/clock/monitor/clock-zoned.json
Jun 08 10:12:16 indy-e1 openaps-loop:  reporting monitor/clock-zoned.json
Jun 08 10:12:16 indy-e1 openaps-loop:  tz://JSON/rezone/monitor/pump-history-zoned.json
Jun 08 10:12:16 indy-e1 openaps-loop:  reporting monitor/pump-history-zoned.json
Jun 08 10:12:33 indy-e1 openaps-loop:  No recent treatments to upload
Jun 08 10:12:47 indy-e1 openaps-loop:  12 0 '2016-06-08T13:51:00.000Z'
Jun 08 10:12:47 indy-e1 openaps-loop:  ----=-=-----+===+-=+-+++++++++++++----+=+++++==----=-----------=--------+--=+---------- 58% of non-meal deviations negative (target 45%-50%)
Jun 08 10:12:47 indy-e1 openaps-loop:  Excess insulin sensitivity detected: ISF adjusted from 80 to 100
Jun 08 10:12:47 indy-e1 openaps-loop:  0
Jun 08 10:12:47 indy-e1 openaps-loop:  18 0 '2016-06-08T10:00:25-07:00'
Jun 08 10:12:47 indy-e1 openaps-loop:  ----=-=-----+===+-=+-+++++++++++++----+=+++++==----=-----------=--------+--=+---------- 58% of non-meal deviations negative (target 45%-50%)
Jun 08 10:12:47 indy-e1 openaps-loop:  Excess insulin sensitivity detected: ISF adjusted from 80 to 100
Jun 08 10:12:47 indy-e1 openaps-loop:  28.65

after some more reports...
Jun 08 10:13:22 indy-e1 openaps-loop:  {"carbs":30,"boluses":0,"mealCOB":29}
Jun 08 10:13:22 indy-e1 openaps-loop:  {"ratio":1.02}
Jun 08 10:13:22 indy-e1 openaps-loop:  {"iob":1.251,"activity":0.0063,"bolussnooze":0.844,"basaliob":0.264,"netbasalinsulin":0.45,"hightempinsulin":0.65,"time":"2016-06-08T17:11:16.000Z"}
Jun 08 10:13:22 indy-e1 openaps-loop:  {"delta":-5,"glucose":131,"avgdelta":-3.667}
Jun 08 10:13:22 indy-e1 openaps-loop:  {"duration":12,"rate":0.575,"temp":"absolute"}
Jun 08 10:13:22 indy-e1 openaps-loop: {"max_iob":2,"type":"current","dia":3,"skip_neutral_temps":false,"current_basal":0.575,"max_daily_basal":0.75,"max_basal":2.25,"min_bg":115,"max_bg":115,"sens":80,"carb_ratio":18}
Jun 08 10:13:22 indy-e1 openaps-loop:  Adjusting basal from 0.575 to 0.59
Jun 08 10:13:22 indy-e1 openaps-loop:  Adjusting target_bg from 115 to 114
Jun 08 10:13:22 indy-e1 openaps-loop:  Adjusting sens from 80 to 78.4
Jun 08 10:13:22 indy-e1 openaps-loop:  Carb Impact: 3 mg/dL per 5m; CI Duration: 7 hours
Jun 08 10:13:22 indy-e1 openaps-loop:  Accel. Carb Impact: 10 mg/dL per 5m; ACI Duration: 2.1 hours
Jun 08 10:13:22 indy-e1 openaps-loop:  calculate-iob://text/shell/predict/iob.json
Jun 08 10:13:22 indy-e1 openaps-loop:  reporting predict/iob.json
Jun 08 10:13:22 indy-e1 openaps-loop:  determine-basal://text/shell/predict/oref0.json
Jun 08 10:13:22 indy-e1 openaps-loop:  reporting predict/oref0.json
Jun 08 10:13:22 indy-e1 openaps-loop:  {"temp":"absolute","bg":131,"tick":-5,"eventualBG":115,"snoozeBG":125,"predBGs":{"IOB":[131,131,131,130,129,127,125,122,119,116,112,108,103,98,93,88,84,80,76,72,69,66,63,60,58,56,54,53,51,50,49,48,48,47],"aCOB":[131,138,145,150,156,160,164,167,170,172,174,175,176,176,175,174,174,173,172,171,169,168,166,165,163,161,159,157,156,155,154,153,152],"COB":[131,131,132,132,131,130,130,128,127,126,124,122,120,117,115,113,111,109,107,106,105,104,104,103,103,103,103,104,104,105,106,107,108,110,111,113,115]},"COB":29,"IOB":1.251,"reason":"COB: 29, Dev: -7, BGI: -2.47, ISF: 78.4, Target: 114; Eventual BG 115>114 but Avg. Delta -5.00 < Exp. Delta 2.4; setting current basal of 0.59 as temp","duration":30,"rate":0.6}

Closing this issue.  Please open a new one for any remaining issues.


mini.files support preview image

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.files
Description
Now the preview of mini.file does not support previewing images. Whether to add image preview support (if the terminal allows it) and related options.

Thanks for the suggestion!
This is not planned at the moment due to either high complexity or needing to introduce third party dependency. Plus, it doesn't really fit the decision of not trying to be a full file explorer: as it is not reasonable to expect images to be edited, having they anything extra is (currently) out of scope.
Closing as "currently it is too complex to support; once there is built-in tools in Neovim itself for that (see neovim/neovim#30889), this can be revisited".


Broken links in spec

https://github.com/eclipse/microprofile-opentracing/blob/master/spec/src/main/asciidoc/configuration.asciidoc
The [server-skip-pattern] and [server-span-name] are broken links.

Both links work well in pdf and html uploaded in https://github.com/eclipse/microprofile-opentracing/releases. Could you please double check?

I didn't know it was for the PDF.  Closing this issue.


Document iOS demo app in TF Lite Readme

See the rendered markdown here: https://github.com/miaout17/tensorflow/blob/ios-example-readme/tensorflow/contrib/lite/README.md#ios-demo-app
I think the demo app is already well-explained for the Android, so it just require a few lines to describe how to build the iOS version.

Can one of the admins verify this patch?

@Sarahs1 FYI


docs: how to execute e.g. combined with ts-jest?

This project seems a nice fit for constructing dynamic paths within the tsconfig.json where based on e.g. an environment variable a different directory is used to e.g. load different data sets.
The only thing I miss here is how to 'execute' or trigger e.g. the tsconfig.js/once? Maybe I am overthinking things to much, but do I place it within my package.json's script or jest.config.js? In my scenario I use ts-jest and have the following setup;
( minimal repo: https://github.com/dnmd/ts-jest-tsconfig.js )
package.json
  "scripts": {
    "test": "jest"
  },

jest.config.js
module.exports = {
  preset: 'ts-jest',
  testEnvironment: 'node',
  moduleNameMapper: {
    // as this file is already a .js file I can user `${process.env.NODE_ENV}` here already pointing to e.g. dev or test
    '^app/(.*)$': `<rootDir>/${process.env.NODE_ENV}/$1`,
  }
};

tsconfig.json
// tsconfig.json
{
    "compilerOptions": {
        "baseUrl": ".",
        "paths": {
            "@app/*": [
                // ====> here I also would like to use the environment var to point to a different path depending on the env.
                // `src/${process.env.NODE_ENV}/*`
                "src/*"
            ]
        }
    }
}

Hello @dnmd
Thank you for reaching out! 🙂
I'm sorry for the late reply, I'm swamped with other work.
Regarding your query, I'm actually unsure what exactly you are trying to accomplish, but I'll try to help towards what I understand. It's been quite some time since I've used jest, so I may be overlooking something. Please elaborate accordingly.
In order to trigger a single run before any run of npm test, you can just add a pretest script to your package.json, like so:
    "pretest": "npx tsconfig.js --once --extensions=ts",
    "test": "jest"

I've added it to your repo: https://github.com/rasenplanscher/ts-jest-tsconfig.js

Note that it's necessary to add a loader, and unfortunately, there's an error preventing the related message to be printed when this is not fulfilled.
I will have to update the docs, and also fix that error, which I found while answering your question.


sbt 0.13.x for 7 <= x <= 9 fails to work with java 1.8 on mac os x

Here's a log of three sessions: https://gist.github.com/132c624383a0f2855bee
macports installs 0.13.7. That fails.
brew install 0.13.8. That fails.
The download from typesafe is 0.13.9. That fails.
In each case we can't even launch sbt.

is the directory you're doing this inside a freshly made empty directory? does moving aside your ~/.sbt directory first help?

I wasn't able to reproduce this:
[N:~/work/quick-test/sbt-2236]$ java -version
java version "1.8.0_60"
Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode)
[N:~/work/quick-test/sbt-2236]$ mkdir project
[N:~/work/quick-test/sbt-2236]$ echo "sbt.version=0.13.9" >> project/build.properties
[N:~/work/quick-test/sbt-2236]$ sbt
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0
[info] Loading global plugins from /xxx/dotfiles/sbt/0.13/plugins
[info] Updating {file:/xxx/.sbt/0.13/plugins/}global-plugins...
[info] Resolving org.scala-sbt.ivy#ivy;2.3.0-sbt-c5d1b95fdcc1e1007740ffbecf4eb07[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Loading project definition from /xxx/quick-test/sbt-2236/project
[info] Updating {file:/xxx/work/quick-test/sbt-2236/project/}sbt-2236-build...
[info] Resolving org.scala-sbt.ivy#ivy;2.3.0-sbt-c5d1b95fdcc1e1007740ffbecf4eb07[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Set current project to sbt-2236 (in build file:/xxx/quick-test/sbt-2236/)
sbt-2236>

Do you have project/build.properties file? That file determines the sbt version to be used, not the launcher version.


“exporter.Export(view)”  warn.

hello , when i first build this program , happen this

Hello First of all, the program is OK; 1. First, check whether the environment you configured is 2018 or 2020. 2. No one knows what the problem is. What is your 72 lines of code? I guess it is "RevitExportGltfContext context=new RevitExportGltfContext (doc, sdial. FileName);" I think the problem is the API version! You should take a closer look at this (after all, the API designed by revit itself is incompatible with each other and will not be compatible with the next version)


"1 failure" isn't as helpful as it could be

https://cirrus-ci.com/task/5355049111519232
I'm trying to understand what "1 failure" this customer testing run is reporting. Some script has decided that there was 1 failure but neglected to leave any clues about why that decision was made. I've looked through the voluminous output a few times and don't see anything obvious. No doubt the failure is noted in the log somewhere. When one error message is buried in nearly 5000 lines of log output, reading about it it would be more efficient if the failure message was dramatically highlighted in situ.

By any chance is this also failing in LUCI? Most likely related to https://github.com/flutter/flutter/issues/115476

They do seem to be related, although in this case the "1 failure" doesn't appear to correspond to anything in the logs.

This unfortunately is too old and the logs have been culled. In general, this infrastructure has no owner so if you see a problem I encourage you to debug it directly. In this particular case, that probably means doing something similar to what test.dart does with collecting error messages and repeating them at the bottom when something has failed.


Received exception on video upload ('Connection aborted.', timeout('The write operation timed out'))

Error has been received when uploading the sequences to osc today

@chip-grab is there something wrong with osc api today? i got one sequence to upload without a problem. the other two had a problem

Closing this issue since there was no activity here in the last couple of years.

This is now resolved @salabogdan so the closure is valid.
It was my ISP that was causing it.


Toggling comment not working correctly with tsx files.

Hi, I have a problem when a made a comment in tsx files.
Expect
<Wrapper>
   Hello world
</Wrapper>

{/* comment */}

<Wrapper>
  {/* Hello world */}
</Wrapper>

{/* uncomment */}

<Wrapper>
   Hello world
</Wrapper>

Actual
<Wrapper>
   Hello world
</Wrapper>

{/* comment */}

<Wrapper>
  {/* Hello world */}
</Wrapper>

{/* uncomment */}

<Wrapper>
  /* {/* Hello world */} */
</Wrapper>

I have installed:
  use 'numToStr/Comment.nvim'
  use 'JoosepAlviste/nvim-ts-context-commentstring'

This is my lua config:
local status, comment = pcall(require, 'Comment')
if (not status) then return end

comment.setup {
  pre_hook = function(ctx)
    local U = require 'Comment.utils'

    local location = nil
    if ctx.type == U.ctype.block then
      location = require('ts_context_commentstring.utils').get_cursor_location()
    elseif ctx.cmotion == U.cmotion.v or ctx.cmotion == U.cmotion.V then
      location = require('ts_context_commentstring.utils').get_visual_start_location()
    end

    return require('ts_context_commentstring.internal').calculate_commentstring {
      key = ctx.ctype == U.ctype.line and '__default' or '__multiline',
      location = location
    }

  end
}

I tried with the config in the readme but is not work.
{
    pre_hook = require('ts_context_commentstring.integrations.comment_nvim').create_pre_hook(),
}

This is my nvim setup.
The problem is with tsx files, with lua files works fine, I don't know what is wrong, I have update all the plugins.

Thanks

This is a issue with ts-context-commentstring. You might need to report there.

I am closing this as this is not directly a bug in Comment.nvim. Although, feel free to share your findings in replies.


运行此命令时缺少matcha  python3 webui.py --port 50000 --model_dir pretrained_models/CosyVoice-300M

root@autodl-container-e3aa42aaff-16030c09:~/autodl-tmp/CosyVoice# python3 webui.py --port 50000 --model_dir pretrained_models/CosyVoice-300M
2024-07-31 14:58:56,677 - modelscope - INFO - PyTorch version 2.0.1+cu118 Found.
2024-07-31 14:58:56,678 - modelscope - INFO - Loading ast index from /root/.cache/modelscope/ast_indexer
2024-07-31 14:58:56,729 - modelscope - INFO - Loading done! Current index file version is 1.15.0, with md5 c08808b83c7e7f2d9f5ed3bf8b60502f and a total number of 980 components indexed
transformer is not installed, please install it if you want to use related modules
/root/miniconda3/lib/python3.8/site-packages/torch/_jit_internal.py:726: FutureWarning: ignore(True) has been deprecated. TorchScript will now drop the function call on compilation. Use torch.jit.unused now. {}
warnings.warn(
Traceback (most recent call last):
File "/root/miniconda3/lib/python3.8/pydoc.py", line 343, in safeimport
module = import(path)
File "/root/autodl-tmp/CosyVoice/cosyvoice/flow/flow_matching.py", line 16, in
from matcha.models.components.flow_matching import BASECFM
ModuleNotFoundError: No module named 'matcha'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "webui.py", line 190, in
cosyvoice = CosyVoice(args.model_dir)
File "/root/autodl-tmp/CosyVoice/cosyvoice/cli/cosyvoice.py", line 29, in init
configs = load_hyperpyyaml(f)
File "/root/miniconda3/lib/python3.8/site-packages/hyperpyyaml/core.py", line 188, in load_hyperpyyaml
hparams = yaml.load(yaml_stream, Loader=loader)
File "/root/miniconda3/lib/python3.8/site-packages/yaml/init.py", line 81, in load
return loader.get_single_data()
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 121, in get_single_data
return self.construct_document(node)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 126, in construct_document
data = self.construct_object(node)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 154, in construct_object
data = self.construct_non_recursive_object(node)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 196, in construct_non_recursive_object
for _dummy in generator:
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 674, in construct_yaml_map
value = self.construct_mapping(node)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 445, in construct_mapping
return BaseConstructor.construct_mapping(self, node, deep=deep)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 261, in construct_mapping
value = self.construct_object(value_node, deep=deep)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 154, in construct_object
data = self.construct_non_recursive_object(node)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 191, in construct_non_recursive_object
data = constructor(self, tag_suffix, node)
File "/root/miniconda3/lib/python3.8/site-packages/hyperpyyaml/core.py", line 480, in _construct_object
args, kwargs = _load_node(loader, node)
File "/root/miniconda3/lib/python3.8/site-packages/hyperpyyaml/core.py", line 434, in _load_node
kwargs = loader.construct_mapping(node, deep=True)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 445, in construct_mapping
return BaseConstructor.construct_mapping(self, node, deep=deep)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 261, in construct_mapping
value = self.construct_object(value_node, deep=deep)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 154, in construct_object
data = self.construct_non_recursive_object(node)
File "/root/miniconda3/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 191, in construct_non_recursive_object
data = constructor(self, tag_suffix, node)
File "/root/miniconda3/lib/python3.8/site-packages/hyperpyyaml/core.py", line 470, in construct_object
callable = pydoc.locate(callable_string)
File "/root/miniconda3/lib/python3.8/pydoc.py", line 1625, in locate
nextmodule = safeimport('.'.join(parts[:n+1]), forceload)
File "/root/miniconda3/lib/python3.8/pydoc.py", line 358, in safeimport
raise ErrorDuringImport(path, sys.exc_info())
pydoc.ErrorDuringImport: problem in cosyvoice.flow.flow_matching - ModuleNotFoundError: No module named 'matcha'

check faq.md, export pythonpath

you need this module: https://github.com/shivammehta25/Matcha-TTS/tree/main/matcha

你需要这个模块：https://github.com/shivammehta25/Matcha-TTS/tree/main/matcha

请问这个模型放在哪里啊

项目的根目录下，把那个仓库的matcha文件夹整个放进去:


K8SPXC-274 force mysql_upgrade if version upgrade is detected

during each Pod start, we store MySQL version into version_info file
after that during the next Pod started we able to compare the current
MySQL version with the version stored in version_info
if version changed we run mysql_upgrade tool, it works fine if any
changes needed. but fails if MySQL changes not needed.

Test name
Status

big-data
passed

scaling
passed

init-deploy
passed

storage
passed

recreate
passed

scaling-proxysql
passed

self-healing
passed

limits
passed

upgrade
passed

restore-to-encrypted-cluster
failed

monitoring
passed

self-healing-advanced
passed

upgrade-consistency
passed

operator-self-healing
passed

security-context
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

demand-backup
failed

Test name
Status

big-data
passed

init-deploy
passed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

recreate
passed

restore-to-encrypted-cluster
failed

scaling
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
passed

security-context
passed

storage
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

demand-backup
failed


gulp --production: Potentially unhandled rejection [2] 'layouts/tinymce.less' wasn't found.

Submit a bug report

[X] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[X] This is a bug report
[ ] This request isn't a duplicate of an existing issue
[ ] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[ ] This is not a personal support request that should be posted on the Roots Discourse forums

What is the current behavior?
gulp --production for theme test.
What is the expected or desired behavior?

[X] gulp error with: Potentially unhandled rejection [2] 'layouts/tinymce.less' wasn't found.
Actually, it should be tinymce.scss.
If comment the last line in main.scss, will show posts.less not found.

Bug report
(delete this section if not applicable)
Please provide steps to reproduce, including full log output:

composer create-project roots/sage sage842 8.4.2
yarn
bower install

[X] 4. gulp --production

Please describe your local environment:
WordPress version:

[X] 4.7

OS:

[X] macOS 10.12.2

NPM/Node version:

[X] node: v7.2.1
[X] npm: 3.10.9
[X] yarn: 0.17.10

Where did the bug happen? Development or remote servers?

[X] Local Development

Is there a related Discourse thread or were any utilized (please link them)?

[X] Yes, one issue related but not solved:
https://discourse.roots.io/t/gulp-issue-potentially-unhandled-rejection-2-error-enoent-open/3456

See https://github.com/roots/sage/issues/1648 — have you updated gulp-if as per https://github.com/roots/sage/commit/2d3f25b3b6a97380164a4097673379f3cc868775?

I'm thinking this was fixed with Sage 8.5.0.
If you still have the issue in the latest stable version of Sage, then post here and we'll revisit this issue.

Solved with 8.5.0 package.json.
Thank you all.


../../../../coines.mk: No such file or directory

Hi Folks,
Very glade to bought 2x BME680 example. Since I'm planning to run BME680 on my Jetson Nano Devkit.I've really push my self to understand the driver code. But so far without luck.
The official BME680_driver seems won't work without bsec library. Since I'm pretty newbie still. I just wounder how to get a handy start point with this sensor.
I've tried to test "forced_mode" in this repo with make command. But only get the error log as title above mentioned. I'm reaching the interest to figure out way to use these awesome drivers. Could any one help out?

Hi @Gfast2 ,
Let us look into this and get back to you.

Hello All,
I try to build on  Ubuntu but  build error as below
thongle@thongle-virtual-machine:~/samba/BME68x-Sensor-API/examples/sequential_mode$ make
Makefile:15: ../../../../coines.mk: No such file or directory
make: *** No rule to make target '../../../../coines.mk'.  Stop.

Do you have any update?

Hi @letrthong ,
I didn't have the chance to figure out the reason. Good news is that I've found another repo which give me the out of box experience I need on linux plattform: https://github.com/alexh-name/bsec_bme680_linux

@Gfast2 ,
Thank  you for your information, actually ,  BME680 can work on  my board . below is result  which show off on web
Loại cảm biến: BME680
🌡Nhiệt độ (°C): 28.3
💧Độ ẩm (%): 78.8
🧘♂Chất lượng không khí (IAQI): 198.1 (Ô nhiễm)
🧭Áp suất (Pa): 100603.0
☁CO2(ppm): 1000.6
Currently,  I want to build BME688 to  detect smell  is coffee or not.
Now I am building sourc "BSEC_<IP_ADDRESS>_Generic_Release_04302021" ( Go to https://www.bosch-sensortec.com/software-tools/software/bme688-software/  to download )
if porting bme688 successfully, I will share them

@BoschSensortec ,
Do we run one source code from  bme68x.h for both BME680 and BME688 ?

@BoschSensortec Any update on this? This is not the only file that is missing; another file, coines.h, is missing as well.

https://www.bosch-sensortec.com/software-tools/tools/coines/

@juergs Thanks, but this seems to be either outdated or too new, as it does not compile with the examples stored in this repository:
../common/common.c:34:12: error: too few arguments to function ‘coines_read_i2c’
   34 |     return coines_read_i2c(dev_addr, reg_addr, reg_data, (uint16_t)len);

(among other errors)

@juergs Thanks, but that link does not cut it. The functions are already implemented in common.c, therefore defining them again would just cause additional errors. Furthermore, these errors are not covered by the forum post at all:
../common/common.c:64:12: error: too few arguments to function ‘coines_write_spi’
   64 |     return coines_write_spi(dev_addr, reg_addr, (uint8_t *)reg_data, (uint16_t)len);
      |            ^~~~~~~~~~~~~~~~
In file included from ../common/common.c:12:
../../../../coines-api/coines.h:664:8: note: declared here
  664 | int8_t coines_write_spi(enum coines_spi_bus bus, uint8_t dev_addr, uint8_t reg_addr, uint8_t *reg_data, uint16_t count);
      |        ^~~~~~~~~~~~~~~~
../common/common.c: In function ‘bme68x_interface_init’:
../common/common.c:114:26: error: too few arguments to function ‘coines_open_comm_intf’
  114 |         int16_t result = coines_open_comm_intf(COINES_COMM_INTF_USB);

It seems to me that the examples in this repository require some custom-modified version of this "coines" library.

Hi @philippludwig , the common file wasn't updated to support the latest interface changes in COINES. Updated the common.c file now in the examples to reflect the needed changes. Can you confirm that is works with the new changes?

@BoschSensortec Yes, the examples now compile without issues, thanks.


Linear ticks for LogLocator

Description
The official tutorial adds the ticks for LogLocator like this: xlocator='log', xminorlocator='logminor'.
But, if I manually set the ticks to linear one, it doesn't work well.
Steps to reproduce
fig, axs = plot.subplots(share=0)
axs.format(xlim=(1, 18), xlocator='log', xminorlocator=1, xtickminor=True)

Expected behavior:
The minor ticks should follow what we set in the format.

See the matplotlib code below.
Actual behavior:

Equivalent steps in matplotlib
import numpy as np
import matplotlib.pyplot as plt
from matplotlib.ticker import FormatStrFormatter

fig, ax = plt.subplots()
ax.plot([1, 10, 15], [1,2,3])
ax.set_xscale('log')
ax.xaxis.set_minor_locator(matplotlib.ticker.LinearLocator(17))

Proplot version
0.6.4

This is probably related to #219 --  it is fixed as of v0.7.0 (released Sunday). Also btw to match the first image you will need xscale='log'. Here's what I get:
fig, axs = pplt.subplots(share=0)
axs.format(xlim=(1, 18), xscale='log', xlocator='log', xminorlocator=1, xtickminor=True)


ngnix may expose .env secrets

The following was brought up by @geeknik.

If folks want to use .env, they'll need to properly configure their server in order to ensure the .env file doesn't get inadvertently exposed to the world. Here is a configuration example for nginx which denies access to locations starting with . other than the .well-known directory:

location ~ /\.(?!well-known).* {
    deny all;
    access_log off;
    log_not_found off;
}

Originally posted by @geeknik in https://github.com/ssl/ezXSS/pull/54#issuecomment-684951688

While the default instructions specify the use of apache which protects this file through the .htaccess it feels important to note for users of nginx that this may not be the case.
How should we go about this?

https://github.com/ssl/ezXSS/issues/23 includes basic information on how to configure nginx to work with this software. @ssl mentioned better nginx support in the future, so maybe that is still on their roadmap. 👍🏻  I'm here to help support nginx in any way I can.

I want to move the installation process to the wiki page. @geeknik could you provide your nginx config setup for the wiki? Thanks!

Here is my server information from /etc/nginx/sites-enabled/default.
server {
    listen 80 default_server;
    listen [::]:80 default_server;

    root /var/www/html;
    index index.php index.html index.htm index.nginx-debian.html;

    client_max_body_size 150m;

    server_name 'domain.tld';
    add_header 'Access-Control-Allow-Origin' '*';
    add_header 'Access-Control-Allow-Methods' 'GET, POST';
    add_header 'Access-Control-Allow-Headers' 'origin, x-requested-with, content-type';

    autoindex off;

    # Redirect all HTTP requests to HTTPS with a 301 Moved Permanently response.
    return 301 https://$host$request_uri;

    # Misc Hardening
    server_tokens off;

    location ~ /\.(?!well-known).* {
      deny all;
      access_log off;
      log_not_found off;
      return 404;
    }

    if ($request_method !~ ^(GET|HEAD|POST)$ ) {
        return 444;
    }

}

server {
    listen 443 ssl http2;
    listen [::]:443 ssl http2;

    root /var/www/html;
    index index.php index.html index.htm index.nginx-debian.html;

    client_max_body_size 150m;

    autoindex off;

    server_name 'domain.tld';
    add_header 'Access-Control-Allow-Origin' '*';
    add_header 'Access-Control-Allow-Methods' 'GET, POST';
    add_header 'Access-Control-Allow-Headers' 'origin, x-requested-with, content-type';

This configuration allows for a 150MB POST to be made, capturing as much information from the target as possible. It blocks access to all .dotfiles except the .well-known directory. And it blocks any requests made to the server that aren't a GET, HEAD or POST request. Has worked well with all recent versions of ezXSS. 👍🏻

Thanks @geeknik and @GlitchWitch !
I've updated the wiki and added the config file https://github.com/ssl/ezXSS/commit/6ab40dd534af5f6b9eff3f9cb7340536bfd43c41

This config is throwing an error for me. I noticed a couple of lines are missing semi-colons (the ciphers and resolver lines), but even adding those in and fixing some white space it still throws an error:
nginx: [emerg] unexpected end of file, expecting ";" or "}" in /etc/nginx/sites-enabled/default:118 nginx: configuration file /etc/nginx/nginx.conf test failed
Any idea on what I'm derping up?

Ah, figured it out. The ciphers line is also missing a single quote. Should I submit a pull request to fix these or do you just want to manually do it quickly?

You can submit a pull request if you want @Marshall-Hallenbeck

Sorry about that, however nginx 1.15.9-ubuntu1.2 under Ubuntu 19.04 LTS doesn't complain. Neither did gixy which runs every time I commit a change to our config.
root@1:~# nginx -t
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful
root@1:~# gixy
==================== Results ===================
No issues found.

==================== Summary ===================
Total issues:
    Unspecified: 0
    Low: 0
    Medium: 0
    High: 0

I see a problem with the  ssl_ciphers line, it shoudl read this instead:
'ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256';

Copy pasta error on my part. Oopsie.


Add guardrail metrics to 21.1

https://cockroachlabs.atlassian.net/browse/DOC-1839

This change is


Update Auth library for Android Unity projects

Does Unity/ARENA project Auth run on Android well? May need:

https://github.com/googleapis/google-api-dotnet-client/tree/main/Src/Support/Google.Apis.Auth.AspNetCore3.IntegrationTests
https://aaronparecki.com/oauth-2-simplified/#single-page-apps

Workaround here for the short-term:  https://github.com/conix-center/ARENA-unity/blob/main/Documentation/Development.md


ref: remove enabling --wait when --atomic is specified; fix rollback issues

Addresses some design issues with the current --atomic flag:

disables the --wait flag by default. With the current design, there's no way to disable the --wait flag, and there's no technical reason why it was required in the first place. Users can opt in with helm install/upgrade --atomic --wait if they so choose.
fixes an issue where helm upgrade --atomic will always choose the latest revision regardless of the state it was in, and regardless if it was the release we were upgrading from. By removing the revision field to the rollbackCmd, tiller will roll back to the latest deployed release.

closes #5377

So for some context here, the --wait flag is required for this to work properly. The goal of the --atomic flag is to automatically roll back (or purge) when a release fails. The only way to know if a release fails is through using the --wait flag so tiller can inform the client that the release has entered a failed state

Will this get pulled into 2.14.1?

There's some valid design decisions pointed out by @thomastaylor312 that I need to address before this can be considered for another review. I'm not sure I have the time to work on this PR as I'm focusing on Helm 3. If you would like to work on this @helgi, you're more than welcome to :)

@bacongobbler can you rebase this?

FWIW @mattfarina I am working on porting this to Helm 3 (with logic for handling when a previous release is broken). For Helm 2, the only open comment I worry about is this one: https://github.com/helm/helm/pull/5395#discussion_r270111879, but things are not broken per se
Otherwise the --wait flag is required for this to work properly, so I don't know that this would add much at this point

So for some context here, the --wait flag is required for this to work properly. The goal of the --atomic flag is to automatically roll back (or purge) when a release fails. The only way to know if a release fails is through using the --wait flag so tiller can inform the client that the release has entered a failed state

I'm not sure if it still makes sense to reply on this closed PR, but after experimenting with --atomic, we're also hitting this issue.
Basically, there are 2 different ways how helm upgrade can fail:
(1) It can fail to create the kubernetes deployment.
(2) It can successfully create the kubernetes deployment, which then fails to run properly.
What I want is a way to roll back in case (1) but not case (2) and I would expect --atomic to do that while --atomic --wait would check both (1) and (2).

@jdemeyer So that distinction is interesting. I think many people would also want (2) to be atomic because if your deployment fails to run properly (but was running well before), something in your chart that changed likely caused it to fail, so it rolls back to the last successful state. Can you clarify a bit more (with a specific use case) of what kind of behavior related to (2) that you wouldn't want to rollback with on atomic? I want to make sure I fully understand before commenting further

I'm using --atomic mainly to work around https://github.com/roboll/helmfile/issues/471
The main reason that I don't like (2) is because it's slow. Our deployments take a while to start, so helm now takes considerably longer. This is essentially the issue #5377 that motivated this PR.
For staging, not rolling back deployments that fail to run also makes it much easier to debug the failed deployment.
For production, you're right: better roll back in any case.

So I totally understand it being slow @jdemeyer. Like I said before in this PR though, we need to wait in order to have the signal for atomic to roll things back when things fail. I think the best option in your staging example is to make --atomic something you only specify when rolling out to prod. You can still use helm rollback in a staging type environment if helm has a non-0 exit code or if other parts of your validation fail


Feature Request: Smart domain sort in Dashboard (sort by domain level)

Currently, when sorting by name, it treats the field as one.  Howver, if entries have subdomains, this is not the ideal way to sort, and it would be better to sort within each subdomain.
Example:
Current ordering (fully alphabetic)
a
a.b
b.z
d
x.z
z.b
Preferred ordering (within subdomain)
a
a.b
z.b
d
x.z
b.z
This sorts by name components, right to left, so: a, b, d, z.  Then it sorts within the b and z domains.
This will make it easier to view a large zone file, as subdomain records will be groups appropriately.
In addition, reverse zones should sort numerically rather than alphabetically, thus:
5
6
11
12
100
250
Ideally, this would be either a global option, or a secondary sort ordering (so click on the heading once to reverse direction, then again to change sort mode, etc)
This is most useful when viewing reverse zones at a class B level as they can get hard to follow otherwise.

I can see that you have a lot of ideas to improve PDA.

Hello,
This request is stale for too long. Regarding our policy to cleanup this project, we are closing it. As this is a Feature Request, it will be listed in #1178
Regards
PowerDNS Admin Team
See #1153 for the policy


GH-768: Implement copy function from on-prem to Cloud

Purpose

https://broadinstitute.atlassian.net/browse/GH-768

Changes

[x] Adapt and copy some existing functions from WFL for the GCS interactions.
[x] Set up Linter/Formatter for the code base.
[x] Refactor some code organization.
[ ] Unit tests.

Review Instructions

Not yet ready.

maybe we can start a library and reference as a sub module?

Highly up for it otherwise we will run into inconsistency problems as the code grow. Speaking of that, we should also talk about choosing mono-repo or multi-repo organization for WFL asap.


There's no valid scenario right now to query the consensus node with the blockNum.

Description
There's no valid scenario right now to query the consensus node with the blockNum.  The Consensus node only supports current account info.    If there's a blockNum we should hit the Mirror Node with the timestamp on the account query. If that fails the transaction should fail.
Steps to reproduce

Running a value transfer.
Batch3 test "Returns revert reason in receipt for payable methods" consistently triggers an error in previewnet when the code to be replaced, the consensus query code, is run.

Additional context
No response
Hedera network
previewnet
Version
v0.21.0
Operating system
None

Should be address by #1103


rio uninstall does not cleanup all the rio resources

Describe the bug
Running rio uninstall leaves some rio resources in the cluster.
To Reproduce

Run rio uninstall in a cluster that has rio installed.
It removes everything from kubectl api-resources and kubectl get crds -A as expected, but there are three unexpected items with kubectl get clusterroles -A:

...
rio-rio-system-autoscaler                                              2d14h
rio-rio-system-cert-manager                                            2d14h
rio-rio-system-webhook                                                 2d14h
...

Running kubectl get validatingwebhookconfigurations.admissionregistration.k8s.io -A yields No resources found as expected.
Kubernetes version & type (GKE, on-prem): kubectl version -- multiple versions, but most recently:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-19T13:57:45Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:09:08Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Rio version: rio info
Uninstalled, but this was on v0.6.0-alpha.1

Also, kubectl get clusterrolebindings leaves these resoures as well:
...
rio-rio-system-cert-manager-rio-rio-system-cert-manager   4d
rio-rio-system-autoscaler-rio-rio-system-autoscaler       4d
rio-rio-system-webhook-rio-rio-system-webhook             4d
...

Also does not remove any secrets that were added with rio (githubtoken in my case)

Rio uninstall should wait for CRDS to be cleaned up before deleting the controller. This avoids cert-manager CRDS blocking rio-system ns deletion.

@rancher-max Available to test in master.

This gave a fatal error, but actually did clean up the resources. We should remove the FATAL though:
$ rio uninstall
Waiting for linkerd uninstall job to be finished
Cleaning up CRDs...
Deleting System Namespace rio-system...
Delete validating webhook
FATA[0049] clusterroles.rbac.authorization.k8s.io "rio-privileged" not found

Riofile that I used for testing https://github.com/daxmc99/rio-demo/tree/rio-permissions-test

Looks like it's all fixed! Uninstalling and reinstalling successfully, and resources are cleaned up on uninstall.


Add the ability to browse all upsells

As a User
I need the ability to see all upsells related to the current product
So that I can find the best deal
Details & Assumptions:

The name of the product and the upsell relation should be pass in by the user
A call to GET /recommendation/{product_id}/{upsells} should list all upsells

Acceptance Criteria:
When I call GET /recommendation/{product_id}/{upsells}
I should see a list of upsells as a JSON string

Can we update this, Issue #5 and  Issue #3 as query recommendation?


Records in ALA not getting retrieved by the app

When executing a search for plants in the preloaded North Head polygon, it retrieves 13 records associated with collections. However, if I use the ALA spatial tool, apply the exact same polygon, and then download that species data, it retrieves 119 collection-based records
some of these were rightfully excluded by our app, as we set the maximum threshold for coordinate uncertainty to be  <= 1000 m; there are a number of collections with coordinates in North Head, but with very large uncertainty values (eg 25,000 m), so we don't want these
BUT, from my ALA direct download, if I filter to collection records w/ uncertainty <= 1000 m (or with that field blank, we're accepting those too), there are actually 51 records. So 38 are somehow not coming through into our app.
For at least one of these, I figured out why.
For this record: https://biocache.ala.org.au/occurrences/e888493f-9b46-4736-859a-02a83f2f8f6b
It's getting excluded from the default maps because it's been annotated as a duplicate record associated with a different representative record
(as an aside, that's completely bogus, as the 'representative record' doesn't even have the same coordinates, and indeed is actually a bit outside the North Head area)
So ideally as fix no. 1 to address what seems to be a multi-pronged problem, we should ideally override the "Exclude duplicate records" data profile filter in the ALA and actually include those records. I'm yet to check how many of the 38 missing records fall within this reason, but it's at least 1.
However, there are some records where I have no explanation for the app failing to retrieve them. Eg https://biocache.ala.org.au/occurrences/f8f31d02-779a-457a-9b9b-739d2e29db12
I cannot find any reason at face value why it's not getting pulled in. Coordinates fall within the area, it's IDed to species, it's a collection, coordinate uncertainty is blank.

I will check all 38 missing records tonight to see why each is missing

(will keep updating this comment)

https://biocache.ala.org.au/occurrences/0413de31-d4c5-4a2b-b44d-ec57bcf880f3 - no explanation
https://biocache.ala.org.au/occurrences/f8f31d02-779a-457a-9b9b-739d2e29db12 - no explanation
https://biocache.ala.org.au/occurrences/e888493f-9b46-4736-859a-02a83f2f8f6b - excluded due to "Exclude duplicate records" data profile filter"

OK this has to do with the data quality profiles we are using! Heres the plan, I'm working on a new branch 'data-profiles'
I'm going to download the data for plants with no data profile applied. This is a little risky, cause the download is considerably bigger without the data quality profile...4 mil records more...

maybe we can use the AVH profile?? thoughts @tmesaglio

or we can make our own "profile" in R code as a precleaning step

@fontikar so the two unexplained examples above are also being excluded due to one of these filters? (if yes, which one are the falling under?)

(will keep updating this comment)

https://biocache.ala.org.au/occurrences/0413de31-d4c5-4a2b-b44d-ec57bcf880f3 - no explanation
https://biocache.ala.org.au/occurrences/f8f31d02-779a-457a-9b9b-739d2e29db12 - no explanation
https://biocache.ala.org.au/occurrences/e888493f-9b46-4736-859a-02a83f2f8f6b - excluded due to "Exclude duplicate records" data profile filter"

The first one I wonder if its because of: "Coordinate uncertainty meters invalid" under Data quality header

it's not that reason, because there are two records that are getting pulled in by the app that also have that same invalid message
https://biocache.ala.org.au/occurrences/d83dbced-3203-4ac5-a247-4c0c3ac340f5

under data quality tests, my two missing examples and the two examples that are getting sucked in in the comment directly above have identical data quality tests

Difference in counts for all plantae in Aus
# With profile
galah_call() |>
+   galah_identify("Plantae") |>
+   galah_apply_profile("CSDM") |>
+   galah_filter(
+     species != "",
+     decimalLatitude != "",
+     year >= 1923,
+     basisOfRecord == c("HUMAN_OBSERVATION", "PRESERVED_SPECIMEN")
+   )  |>
+   atlas_counts()
# A tibble: 1 × 1
     count
     <int>
1 15250795

> # Spatially valid ones
> galah_call() |>
+   galah_identify("Plantae") |>
+   galah_filter(
+     spatiallyValid == TRUE,
+     species != "",
+     decimalLatitude != "",
+     year >= 1923,
+     basisOfRecord == c("HUMAN_OBSERVATION", "PRESERVED_SPECIMEN")
+   )  |>
+   atlas_counts()
# A tibble: 1 × 1
     count
     <int>
1 20421229

> # Outlier
> galah_call() |>
+   galah_identify("Plantae") |>
+   galah_filter(
+     outlierLayerCount < 1,
+     species != "",
+     decimalLatitude != "",
+     year >= 1923,
+     basisOfRecord == c("HUMAN_OBSERVATION", "PRESERVED_SPECIMEN")
+   )  |>
+   atlas_counts()
# A tibble: 1 × 1
     count
     <int>
1 20274237

Fonti broke galah (growing queue), will try tomorrow, if its still broken then Modnay!

Need to download isDuplicateOf to see what sort of variable it is too

Fixed by Fonti, we had to remove some of the CDSM filters applied by the ALA


By table streams implementation

Pull Request Test Coverage Report for Build 526

113 of 137 (82.48%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 86.801%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/com/salesforce/dynamodbv2/mt/mappers/sharedtable/impl/MtAmazonDynamoDbStreamsBySharedTable.java
29
30
96.67%

src/main/java/com/salesforce/dynamodbv2/mt/mappers/MtAmazonDynamoDbByTable.java
8
9
88.89%

src/main/java/com/salesforce/dynamodbv2/mt/mappers/DelegatingAmazonDynamoDbStreams.java
7
12
58.33%

src/main/java/com/salesforce/dynamodbv2/mt/mappers/MtAmazonDynamoDbStreamsBase.java
46
63
73.02%

Totals

Change from base Build 512:
0.2%

Covered Lines:
1940

Relevant Lines:
2235

💛  - Coveralls


Add Apple wallet button to gift card template

I made the updates for adding the Apple wallet button to the gift card template, to account for Apple's wallet, and showing the QR code all the time, instead of only on print.
@ohsabry can you check this out for me?

Thanks. Code looks fine, is there any way I can :tophat: ?

This seems like it works, but we don't see the Apple wallet button for some reason.
https://checkout.shopify.com/gift_cards/10007292/preview this should show you the example of the new gift card page in my test store.

:+1:

@blboyle Sorry, a few gotchas
One is that the beta flag name was changed from passbook to apple_pass.
The other is that non alphanumeric characters other than spaces are currently not allowed for the pass title, and your shop name has an exclamation point. I'll fix that today.
The last one is that you button won't download a pass if the shop is password protected.
I was able to go into your shop, add the new beta flag, enable apple wallet, and get it to appear:
https://checkout.shopify.com/gift_cards/10007292/cd7c26541fb53b0b64b4bc9ce11cc66c


readme: add new pyo3 article

With thanks to @ohadravid for the great piece!

Cool. I would recommend it if someone asked me for a nice introduction to PyO3.


need to write a document on how to create a flow scriptIssue Title

We need a document that describes how to write a flow script, including all field definitions in the 2 flavours of the MQTT flow command, and the 2 flavours of the FLOW_GO vommand, and the method for defining and calling repeated cycles of multiple flow rows.
This will also provide input into what the flow compiler needs to produce as it's MQTT script output

needs to cover:
-initial flow go command to reset flow environment
-final flow go command, and all the options
-repeatable cycle commands
-convention to number flow rows in comments for reference
-all of the f_operation functions
- absolute coords vs. relative to home vs. relative to last
- global coords vs local coords
-how to graph leg positions for all or part of a flow
-how to get a nicely formatted display of a flow
-how to work with MQTT.fx
- restart if you create a new script file,
- minimum delay of 200 msec between commands.
- file naming conventions
- identifying target hexbot

This completed document was just uploaded/merged: creating-flows.odt along with a sample script onestep. Submission was done under issue 133. closing this issue


support generation of RDF into a specific named graph

you can use Graphs#withContext to set the named graph for RDF generated by Pinto after the fact, but it would be convenient of the mapper did this for you.  either by mapper configuration, annotations, or both.

it should be both. annotations will be the easiest for your default case, but configuration will be ideal if you want more sophisticated logic than just an annotation w/ a value. this has come up recently on the empire list in a standard use case.


Leaving & rejoining the survival world spawns you back in the overworld.

Reported by Loki_BM in private.

I assume this means that if you use /hub from survival nether, then go through the portal it spawns you back in the overworld?

Updated server to use new command. Confirmed working


Adding a new option to aperture_mask

I added a new option to for the shape of an aperture_mask. In addition to the 'pipeline' and 'all' options, this adds an method that selects the mask by looking for pixels above a threshold, where the threshold is set is sigma -- although I used robust statistics.

There are a couple of things that I think need changing. The most glaring of which is that I arbitrarily hard coded that the target star has to be within +/- 2 pixels of the center of the pixel mask. This could be a parameter.

Here are a couple of screenshots showing it in action.

Codecov Report

Merging #231 into master will decrease coverage by 0.38%.
The diff coverage is 30%.

@@            Coverage Diff            @@
##           master    #231      +/-   ##
=========================================
- Coverage   88.79%   88.4%   -0.39%
=========================================
  Files          24      24
  Lines        3114    3132      +18
=========================================
+ Hits         2765    2769       +4
- Misses        349     363      +14

Impacted Files
Coverage Δ

lightkurve/targetpixelfile.py
71.51% <30%> (-1.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89df6d1...177887e. Read the comment docs.

Thanks @mrtommyb!  Selecting pixels above a threshold is something I find myself doing a lot by hand, so it makes sense to automate this!  I hope we'll be able to review this asap.

For K2 is there an option, or should we consider adding one, that extends the aperture in the direction of motion?
Or maybe create an aperture this way, but on the averaged flux image across the entire campaign?

Currently I use a median image to calculate the pixels above threshold, but we could probably instead look at the union of all pixels above threshold in any image.

There is a bug in this pull request with the threshold keyword not being passed to the _parse_aperture_mask function. I'm working on a fix. I'm going to need some help with how you want this variable to be passed. I'm going to implement it as part of kwargs.

@barentsen I've just gone through and made my changes on this, can you take a look?
@mrtommyb I have taken out the contiguous region part of this PR. It's harder to understand and shouldn't affect most of our sources.

Codecov Report

Merging #231 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   90.38%   90.43%   +0.04%
==========================================
  Files          26       26
  Lines        3329     3346      +17
==========================================
+ Hits         3009     3026      +17
  Misses        320      320

Impacted Files
Coverage Δ

lightkurve/utils.py
100% <100%> (ø)
:arrow_up:

lightkurve/tests/test_targetpixelfile.py
100% <100%> (ø)
:arrow_up:

lightkurve/targetpixelfile.py
90.18% <100%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3ad75...545b426. Read the comment docs.

I made the following changes:

I applied the tpf.verb() rule to this PR and renamed the new method tpf.create_threshold_mask().
To keep the API clean, I propose that we do not accept threshold as a parameter in all functions that accept the aperture_mask parameter.  Instead I propose that we require a user to explicitly call create_threshold_mask()  if they want to change the threshold, e.g. tpf.plot(aperture_mask=tpf.create_threshold_mask(5)).  This makes the API future-proof against other forms of aperture mask creation.
I rebased on master.

I am happy for this to be merged, but I noticed that the feature which ensure that a mask is contiguous has disappeared.  Is this not important?

I think we might want/need to revisit this. The contiguous region part of the code may have been a little complex but I think it important/nessessary. Otherwise you get weird situations like the one below.
@barentsen

The pull request included code to ensure that the theshold region was contiguous

Thanks @mrtommyb!  I agree we should make this smarter.  I opened #337 to discuss the possible solutions.  Would you like to share your thoughts on the best solution there?


Docs

Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 75%.


Luci does not support dnat advanced nat configuration

Luci supports snat advanced nat configuration, but it does not support dnat.
Dnat is necessary to ensure such things as captive portals and forced dns can be properly redirected without resorting to custom rules.

It does. All DNAT options offered by fw3 are in the Redirct Rules tab.


O(1) send/recv data across isolates, possibly by "move" semantics, in more general cases

I am considering whether this is possible (and may be related to https://github.com/dart-lang/sdk/issues/49468).
Surely, we should not share mutable objects across isolates otherwise we need locks - violating Dart fundamentals. But if we move from one isolate to another, looks possible?
Just very draft idea and want to post here in case someone have some other ideas :)

https://api.flutter.dev/flutter/dart-isolate/Isolate/exit.html provides one solution to the problem of "moving" data between isolates.
Sender isolate exiting provides a solution to the problem of ensuring that sender doesn't access "moved" data.

@aam I agree (and that is O(1)). Just thinking about whether we can do something more general indeed.

Duplicate of #49587

Let's keep just one issue open for this.

Ah great to see that discussion!


about the screen

hello, I want to know that whether the screen image can be changed. If yes please tell me how. Thank you

Yes, you can follow the instructions for my Red Herring keyboard (Change OLED Graphic): https://github.com/dcpedit/redherring/tree/main/firmware#change-oled-graphic
You'll need to change the following line since the screen is a different resolution: (32x128)/8
#define LOGO_SIZE 512


Enable Wayland by default

Objective

Fixes #4106

Solution
Just one commit to add wayland to the default features indeed
Why should it be merged?
The discussion in #4106 seems to be overwhelmingly positive toward adding wayland to the default features, as it can greatly improve user experience for Linux users who use Wayland.
Many of the most popular Linux Desktop Environments (DE) like KDE Plasma Desktop and GNOME have Wayland support. With the release of Plasma 6, Wayland is now used by default, and in GNOME, Wayland has been the default for quite a while now.
With Plasma and GNOME, the most popular Linux DEs, now defaulting to Wayland, it seems like enabling Wayland support would truly indeed positively affect quite a lot of Linux users indeed.

Wayland is currently broken for me. It renders one frame and then the window becomes unresponsive or segfaults outright.

Do wgpu's examples show the same behavior?

though interestingly enough on 0.27 and 0.28 no window appears at all (no crash)

This, at least, is just because in order for a wayland window to appear, the application needs to have rendered anything, which winit's examples prior to 0.29 did not do.

Do wgpu's examples show the same behavior?

Yes, no segfault's though.

This, at least, is just because in order for a wayland window to appear, the application needs to have rendered anything, which winit's examples prior to 0.29 did not do.

Aha.

It seems like it's a problem between wgpu and the latest NVIDIA driver:

https://github.com/gfx-rs/wgpu/issues/4775
https://github.com/gfx-rs/wgpu/issues/4689

I think it's worth discussing going one step further, and remove both x11 and wayland as top level features of Bevy, and just always enable them on winit

perhaps but the Customization directly from Bevy features sure is nice indeed truly

https://github.com/gfx-rs/wgpu/pull/4967 has been merged, which should fix the NVIDIA issue. Unfortunately, it couldn't make it into wgpu 0.19 because of breaking API changes: https://github.com/gfx-rs/wgpu/pull/5114#issuecomment-1902823743

I support keeping the cargo features on the Bevy crate to allow for customizability. Do not remove them in favor of unconditionally enabling both on the winit dependency.
I fully support adding Wayland to default features. I have had this position for years.
It is no longer the case that Wayland users are a small minority or early-adopters of new tech. Most Linux distros nowadays default to Wayland. Wayland should be enabled by default to provide the best experience for users.
Also it is no longer the case that XWayland is just fine for everyone and any Wayland users can be assumed to have a reasonably good experience with XWayland anyway. A few years ago, Wayland was mostly being adopted by users on systems that already had great support for X11. Nowadays, there are many platforms and environments where X11 support is neglected (usually available but works poorly) and only Wayland is well-supported. I personally have quite a few "unusual" systems where I have had to build Bevy with Wayland support for it to be usable and not run into weird issues; to name a few: Asahi Linux, WSLg in WSL2, Chromebooks, ...
Modern Linux distros and desktop development focus on Wayland. X11 is bitrotting.

@aMyTimed This also fixes https://github.com/bevyengine/bevy/issues/13340 so maybe you want to add that to the PR description too.

Is there an equivalent to xvfb for wayland?

Take a look at xwayland-run.

To fix CI, this PR should also add libwayland-dev libxkbcommon-dev to the Install Linux dependencies step of the build (ubuntu-latest) job.

I want to draw attention to this issue: https://github.com/gfx-rs/wgpu/issues/5505
Defaulting to Wayland will break Bevy for Wayland users with no access to Vulkan drivers.
I already have a fix cooking for this, but haven't had the time to finish it yet.

Removing the X-Controversial label because I think there is a consensus here, especially among Linux users, based on discussions on GitHub and Discord. Indeed, many new users are surprised that Wayland is not already the default. Feel free to add it again if I misread the room :)

I think "this is blocked on higher quality" is a more accurate read than "this is controversial".


Remove version: ZenBrowser.Zen version 1.0.0-a.26

Move to #168940, #168942
I believe Zen-Team.Zen-Browser is an appropriate name given it follows the <Publisher>.<App name> format
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/zen-browser/desktop/releases/download/1.0.0-a.26/zen.installer.exe
OK
(Automated message - build 917)

URL: https://github.com/zen-browser/desktop/releases/download/1.0.0-a.26/zen.installer.exe
OK
(Automated message - build 917)


[Vue][ColorPicker] Component cannot be controlled

Description
When I'm using the controlled version of ColorPicker (v-model) I expect that external changes to the modelValue to update the picker component parts accordingly with the new color value.
What's happening currently is that the component is not reacting to modelValue changes from outside.
Link to Reproduction
https://stackblitz.com/edit/vitejs-vite-1sszcg?file=src%2FApp.vue
Steps to reproduce

In the demo click the button with the label "This should change color to green"
Notice that none of the parts of the ColorPicker component reacts to this modelValue change and the color value highlight by the "parts" remains the old value (blue-ish) within the component.

Ark UI Version
0.7.0
Framework

[ ] React
[ ] Solid
[X] Vue

Browser
Irrelevant.
Additional Information

The reproduction demo is copy pasted as is from the documentation example, omitting some of the parts for brevity only.

Thanks for taking your time to report this issue. Will be fixed within the next release.
https://github.com/chakra-ui/ark/assets/1846056/b2f0fb5a-177d-4bdc-af98-c6f84649206e


Unmarshal nested structs with annotations

After pull request #99 is merged, it would be worthwhile to add a test for nested structs:
foo::{
  field1: bar::{
    field2: baz::5
  }
}

Fixed in this commit: 9cd2cc5f1bf59e0708f2bacd635988747a2c8341


Update the github wiki

The github wiki is out of date. We should update it now that the repository is public.

Made general updates. The only page that is still out-dated is
https://github.com/LSSTDESC/CCL/wiki/Basic--usage
@vrastil, do you think you could take a look at that one?

I`ll get to it on Monday


Fix for stale ghprbCommentBody values (#233/JENKINS-40802)

This has been running on our instance for several months and has the desired effect. I'm afraid there is no test for this issue included; I'm not a java programmer and wouldn't really know where to start.

I would still like to see this merged to master and a released. In the mean time, I will build from your fork and deploy it to your master.  Thanks for this fix!!!!


output info from template project's README

Currently after downloading and installing a template project, you get the following:
✔ Successfully created app! To get started, run:

cd test-noo
npm start

It would be nice to also show other things you can do in a project, like npm run build or how to launch in production mode.
Because we allow using any repo as a template project, it might be best to allow the repo to determine what gets printed to the console.  I'm thinking using content from the README of the project might be a good way to do that.  Perhaps having a specific markdown heading that marko create looks for and then printing the contents of that section to the console.  There are a number of options for printing markdown to the terminal:

https://www.npmjs.com/package/marked-terminal
https://www.npmjs.com/package/lessmd
https://www.npmjs.com/package/cli-md
etc.

We now surface information from the package.json for build and start commands.


adding modified package json files to avoid stashing them in future

Changes in this PR:
Added the two automatically modified Package.json files when I install Sass via NPM.
This happens every time I install sass, so would like to avoid stashing or restoring these files each time.
Trello card / Rollbar error (etc)

Screenshots of UI changes:
Before

After

[ ] Requires env variable(s) to be updated

Codecov Report

Merging #571 (58ffaaf) into main (92e4b87) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   80.13%   80.13%
=======================================
  Files          17       17
  Lines         725      725
  Branches       46       46
=======================================
  Hits          581      581
  Misses        131      131
  Partials       13       13

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Since we use sass it's not a terrible thing if it's in the node package.json


Index curator coordinate access

One way to address the geoprivacy issue @tiwane raised: https://inaturalist.slack.com/archives/C02F8RN5Q/p1499397827435545

Pref. loading happens from the DB in the API, Patrick is working on more sweeping index changes.


Calibration file format

Hello, thank you for open-sourcing this great work.
I've been testing your work with my own data lately, and I have a few questions I'd like to ask:
1、What is the difference between "batch" and "jsonbatch" in AutoCalib options ?
2、I downloaded the demo data you provided, does the json file in the TF70TrueJson folder need to be specified in advance? The camera parameters in ""cloudCamera" are known in advance, and other content such as ""Extrinsic" and ""EulerR", are  they generated by app， Or how to specify it?
3、When I use a pair of images and point clouds for calibration, the program occasionally reports an error, what are the possible causes and solutions?

I am looking forward to your reply. Thanks again. :smile:

1、	What is the difference between "batch" and "jsonbatch" in AutoCalib options ?
Answer:
 is designed for saving interactive time when you have a series of cloud and images with same intrinsics, in this case, you just need to put all the clouds and images in a folder(of course ,you need to name the clouds and images per our instructions in program.md), then operate as per the instructions in the program.md.
 is designed for saving interactive time when you have a series of cloud and images with different intrinsics. In this case , you need to put all images and clouds in one folder, and put intrinsic json files for each image and cloud pair in another folder. (make sure you naming the json,clouds,and images per our instruction in program.md). then the program will read the intrinsic jsons in the folder , and perform calibration automatically. Please note:
The intrinsic json file shall be named as “suppose”+essential name+”.json”.
Then the program will find the cloud “essential name +”_merge.pcd”, and find the image “essential name+”_1.png” in the specified data folder ,and perform the calibration.

l downloaded the demo data you provided, does the ison file in the TE70Truelson folder need to be specifed in adyance? Thecamera parameters in "cloudCamera" are known in advance, and other content such as ""Extrinsic" and ""EulerR", are theygenerated by app, Or how to specify it?
Answer:
2.1 you just need to operate per the program.md. in  mode, you need to select the true json/pcd/image per the promption from the program, in< batch calibration>, you need select a true json and select a folder of clouds and images with same true intrinsic per the promption from the program.  and in Mjsonbatch calibration> mode, you need prepare a jsonbatchtest.json file in advance, you can take our jsonbatch example as a template, just revise the paths is enough.
2.2 only intrinsic is important for calibration. The extrinsic is only used to prepare the Et and Er for the calibration report. If you provide wrong extrinsic in the true json file, the calibration result is still right, but the Et and Er in the report will be wrong, you need to calculate the et and Er yourself using the right extrinsic.
The EulerR and WorldT is not important, the program will calculate per the calibration result automatically and rewrite them. We provide them is just because it is produced by our program automatically. You don’t need to do anything, in a word, you can put any number in these two subject.
In a word, intrinsic is critical for calibration, extrinsic is for evaluation of the calibration, EulerR and WorldT is calculated by the program.

2、	When l use a pair of images and point clouds for callbration, the program occasionally reports an error, what are the possiblecauses and solutions?
From the screen shot you provided, we think it is because the cloud is very poor and the C3M can’t find enough match pairs. (<4). In this case ,the program will return a default calibration result in the zero point of the cloud.
If possible, please send the cloud and image to us for further study. Thanks.
Hope above text answers your questions, thanks.

1、	What is the difference between "batch" and "jsonbatch" in AutoCalib options ?
Answer:
 is designed for saving interactive time when you have a series of cloud and images with the same intrinsics, in this case, you just need to put all the clouds and images in a folder(of course , you need to name the clouds and images per our instructions in program.md), then operate as per the instructions in the program.md.
 is designed to save interactive time when you have a series of cloud and images with different intrinsics. In this case , you need to put all images and clouds in one folder, and put intrinsic json files for each image and cloud pair in another folder. (make sure you naming the json,clouds,and images per our instruction in program.md). then the program will read the intrinsic jsons in the folder , and perform calibration automatically. Please note:
The intrinsic json file shall be named as “suppose”+essential name+”.json”.
Then the program will find the cloud “essential name +”_merge.pcd”, and find the image “essential name+”_1.png” in the specified data folder, and perform the calibration.

l downloaded the demo data you provided, does the ison file in the TE70Truelson folder need to be specifed in adyance? The camera parameters in "cloudCamera" are known in advance, and other content such as ""Extrinsic" and ""EulerR", are theygenerated by app, Or how to specify it?
Answer:
2.1 you just need to operate per the program.md. in  mode, you need to select the true json/pcd/image per the promption from the program, in< batch calibration>, you need to select a true json and select a folder of clouds and images with same true intrinsic per the promption from the program.  and in Mjsonbatch calibration> mode, you need to prepare a jsonbatchtest.json file in advance, you can take our jsonbatch example as a template, just revise the paths is enough.
2.2 only intrinsic is important for calibration. The extrinsic is only used to prepare the Et and Er for the calibration report. If you provide wrong extrinsic in the true json file, the calibration result is still right, but the Et and Er in the report will be wrong, you need to calculate the et and Er yourself using the right extrinsic.
The EulerR and WorldT is not important, the program will calculate per the calibration result automatically and rewrite them. We provide them is just because it is produced by our program automatically. You don’t need to do anything, in a word, you can put any number in these two subjects.
In a word, intrinsic is critical for calibration, extrinsic is for evaluation of the calibration, EulerR and WorldT is calculated by the program.

2、	When l use a pair of images and point clouds for calibration, the program occasionally reports an error, what are the possiblecauses and solutions?
From the screenshot you provided, we think it is because the cloud is very poor and the C3M can’t find enough match pairs. (<4). In this case , the program will return a default calibration result in the zero point of the cloud.
If possible, please send the cloud and image to us for further study. Thanks.
Hope the above text answers your questions, thanks.

1、	What is the difference between "batch" and "jsonbatch" in AutoCalib options ?
Answer:
 is designed for saving interactive time when you have a series of cloud and images with same intrinsics, in this case, you just need to put all the clouds and images in a folder(of course ,you need to name the clouds and images per our instructions in program.md), then operate as per the instructions in the program.md.
 is designed for saving interactive time when you have a series of cloud and images with different intrinsics. In this case , you need to put all images and clouds in one folder, and put intrinsic json files for each image and cloud pair in another folder. (make sure you naming the json,clouds,and images per our instruction in program.md). then the program will read the intrinsic jsons in the folder , and perform calibration automatically. Please note:
The intrinsic json file shall be named as “suppose”+essential name+”.json”.
Then the program will find the cloud “essential name +”_merge.pcd”, and find the image “essential name+”_1.png” in the specified data folder ,and perform the calibration.

l downloaded the demo data you provided, does the ison file in the TE70Truelson folder need to be specifed in adyance? The camera parameters in "cloudCamera" are known in advance, and other content such as ""Extrinsic" and ""EulerR", are theygenerated by app, Or how to specify it?
Answer:
2.1 you just need to operate per the program.md. in  mode, you need to select the true json/pcd/image per the promption from the program, in< batch calibration>, you need select a true json and select a folder of clouds and images with same true intrinsic per the promption from the program.  and in Mjsonbatch calibration> mode, you need prepare a jsonbatchtest.json file in advance, you can take our jsonbatch example as a template, just revise the paths is enough.
2.2 only intrinsic is important for calibration. The extrinsic is only used to prepare the Et and Er for the calibration report. If you provide wrong extrinsic in the true json file, the calibration result is still right, but the Et and Er in the report will be wrong, you need to calculate the et and Er yourself using the right extrinsic.
The EulerR and WorldT is not important, the program will calculate per the calibration result automatically and rewrite them. We provide them is just because it is produced by our program automatically. You don’t need to do anything, in a word, you can put any number in these two subject.
In a word, intrinsic is critical for calibration, extrinsic is for evaluation of the calibration, EulerR and WorldT is calculated by the program.

2、	When l use a pair of images and point clouds for callbration, the program occasionally reports an error, what are the possiblecauses and solutions?
From the screen shot you provided, we think it is because the cloud is very poor and the C3M can’t find enough match pairs. (<4). In this case ,the program will return a default calibration result in the zero point of the cloud.
If possible, please send the cloud and image to us for further study. Thanks.
Hope above text answers your questions, thanks.

1、	What is the difference between "batch" and "jsonbatch" in AutoCalib options ?
Answer:
"Batch" is designed for saving interactive time when you have a series of cloud and images with same intrinsics, in this case, you just need to put all the clouds and images in a folder(of course ,you need to name the clouds and images per our instructions in program.md), then operate as per the instructions in the program.md.
"JsonBatch" is designed for saving interactive time when you have a series of cloud and images with different intrinsics. In this case , you need to put all images and clouds in one folder, and put intrinsic json files for each image and cloud pair in another folder. (make sure you naming the json,clouds,and images per our instruction in program.md). then the program will read the intrinsic jsons in the folder , and perform calibration automatically. Please note:
The intrinsic json file shall be named as “suppose”+essential name+”.json”.
Then the program will find the cloud “essential name +”_merge.pcd”, and find the image “essential name+”_1.png” in the specified data folder ,and perform the calibration.

l downloaded the demo data you provided, does the ison file in the TE70Truelson folder need to be specifed in adyance? Thecamera parameters in "cloudCamera" are known in advance, and other content such as ""Extrinsic" and ""EulerR", are theygenerated by app, Or how to specify it?
Answer:
2.1 you just need to operate per the program.md. in  mode, you need to select the true json/pcd/image per the promption from the program, in< batch calibration>, you need select a true json and select a folder of clouds and images with same true intrinsic per the promption from the program.  and in Mjsonbatch calibration> mode, you need prepare a jsonbatchtest.json file in advance, you can take our jsonbatch example as a template, just revise the paths is enough.
2.2 only intrinsic is important for calibration. The extrinsic is only used to prepare the Et and Er for the calibration report. If you provide wrong extrinsic in the true json file, the calibration result is still right, but the Et and Er in the report will be wrong, you need to calculate the et and Er yourself using the right extrinsic.
The EulerR and WorldT is not important, the program will calculate per the calibration result automatically and rewrite them. We provide them is just because it is produced by our program automatically. You don’t need to do anything, in a word, you can put any number in these two subject.
In a word, intrinsic is critical for calibration, extrinsic is for evaluation of the calibration, EulerR and WorldT is calculated by the program.

2、	When l use a pair of images and point clouds for callbration, the program occasionally reports an error, what are the possiblecauses and solutions?
From the screen shot you provided, we think it is because the cloud is very poor and the C3M can’t find enough match pairs. (<4). In this case ,the program will return a default calibration result in the zero point of the cloud.
If possible, please send the cloud and image to us for further study. Thanks.
Hope above text answers your questions, thanks.

Thank you for your reply, I will test again😄.


showing the wrong flutter version even though im adding flutter version 1.20.4

Could you run flutter doctor on that directory and check what version of flutter is actually located there? It might be an IDE issue.

Feel free to re-open with new details


Pool times out while waiting for an open connection

I tried to solve this on my own but I haven't made any progress. The mysql 20.1 crate works just fine when I use it.
When trying to execute a query, after a length delay I receive this message:
Error:    0: pool timed out while waiting for an open connection
I setup the MySQL pool like so:
    let sqlx_pool = MySqlPoolOptions::new()
        .connect_timeout(core::time::Duration::from_secs(120u64))
        .test_before_acquire(true)
        .min_connections(1)
        .max_connections(5)
        .connect("mysql://user:pass@[0:0:0:0:0:ffff:c0a8:15]:3306/schema").await?;

SQLx appears to connect successfully. The returned pool looks like so:
Pool {
    size: 0,
    num_idle: 0,
    is_closed: false,
    options: PoolOptions {
        max_connections: 5,
        min_connections: 1,
        connect_timeout: 120s,
        max_lifetime: Some(
            1800s,
        ),
        idle_timeout: Some(
            600s,
        ),
        test_before_acquire: true,
    },
}

The following code will execute successfully:
        let mut rows = query(
            "SELECT `tail`,`head` FROM `vecs`"
        ).fetch(sqlx_pool);

But SQLx will time-out here:
        while let Some(row) = rows.try_next().await? {
            let tail: u32 = row.try_get("tail")?;
            let head: u32 = row.try_get("head")?;
        }; // while

Possibly related to Issue #846? I am trying to connect to host IP IPv4 <IP_ADDRESS> but I am having to use host IPv6 [0:0:0:0:0:ffff:c0a8:15] to get it to connnect.

Hey @leontoeides I realise it's been almost three years but do you remember what the problem was here?

@martijnarts Since I just found this ticket while investigating why sqlx 0.7.2 seems to produce this issue for me, where 0.6.3 worked perfectly fine.. did you try the same code with the older version yet?

@TimB87 I don't remember! But it might be that the server had no more connections available? I did have that issue recently.

In my case, I can ensure that the server hat enough connections available. It works with 0.6.2 and doesn't with 0.7.

I encountered this issue as well using Postgres on SQLx 0.7.2

I have this problem as well, but i'm not sure if it is caused by sqlx. Also using a postgres server which has definitely enough connections.

Anyone found a solution? :/

I use postgresql + sqlx 0.7.4 + actix-web. The same thing happens to me very occasionally. Is there a solution?(pool timed out while waiting for an open connection)

same here, pool timed out while waiting for an open connection, i use postgresql+axum,


Cannot figure out login URL

The step says to:
f. For Login URL , enter "https://login.microsoftonline.com". Insert your login URL (without a forward slash "/" appended to the end)
How do I find out what is my login URL?

So it was figured out, just use https://login.microsoftonline.com


feat(cli): add ability to dynamically load release-please plugin

feat: export Strategy interface so external packages can implement
This should allow you to publish private configs in your own npm package and load via the CLI (you can already load configs programatically via registerReleaseType etc).
To make an external package dynamically loadable via the release-please CLI, export an init() method from your main file that registers your release-please extensions.

This approach seems reasonable. Keep in mind however, it won't work with the action, which I think some Googlers (the SQL connector folks?) are using.

A reasonable fix for this would be getting more people on the app if necessary, i.e., if they're using yoshi-specific strategies.

This approach seems reasonable. Keep in mind however, it won't work with the action, which I think some Googlers (the SQL connector folks?) are using.

A reasonable fix for this would be getting more people on the app if necessary, i.e., if they're using yoshi-specific strategies.

We can programmatically load the yoshi extensions in the action if we want. We won't be able to load arbitrary external plugins but that's probably ok.


add timestamps to logs without it, fix better clean up policy for vm snapshots

https://github.com/kthcloud/landing-frontend/issues/146


Pull request with type [CREATE] for user [Jing099] and object type [ConfigurationItem] - titled [TestChildCI]

Automated pull request from the Endpoint Configuration Manager Community hub.

drop it


Get redis host and password from environment

Fixes https://github.com/DiamondLightSource/mx-bluesky/issues/149
Note: This also needed the following adding to the values.yaml for BlueAPI:
  - name: VALKEY_PASSWORD
    valueFrom:
     secretKeyRef:
       name: valkey-secret
       key: requirepass

Instructions to reviewer on how to test:

Confirm matches production at /dls_sw/i04/software/bluesky/scratch/dodal

Checks for reviewer

[ ] Would the PR title make sense to a scientist on a set of release notes
[ ] If a new device has been added does it follow the standards
[ ] If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
[ ] Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Just noting that the envVar needs to go in the extraEnvVars, in case that half of the ticket is picked up by someone else.