[WIP] Tf12 backwards compat

This is another take on the TF12 upgrade - with TF11 backwards compatibility.
Majority of the changes are related to adding test stages to make local testing easier.

Well actually all the changes are related to the tests 😄

Oh nice! Do you have a sense as to what is different about the modules here that makes it work?

Closing in favor of #26


minor change for 'Get started with dataflow pipeline components'

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[ ] Use the notebook template as a starting point.
[ ] Follow the style and grammar rules outlined in the above notebook template.
[ ] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[ ] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[ ] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under # Official Notebooks section, pointing to the author or the author's team.
[ ] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

If you are opening a PR for Community Notebooks under the notebooks/community folder:

[ ] This notebook has been added to the CODEOWNERS file under the # Community Notebooks section, pointing to the author or the author's team.
[x] Passes all the required formatting and linting checks. You can locally test with these instructions.

If you are opening a PR for Community Content under the community-content folder:

[x] Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
[ ] The main content directory has been added to the CODEOWNERS file under the # Community Content section, pointing to the author or the author's team.
[x] Passes all the required formatting and linting checks. You can locally test with these instructions.

@andrewferlitsch : Manually tested on colab and workbench.

Automated test not ran. Submitter manually confirmed execution with Colab/Workbench. I am manually merging the PR.


Q: Meilisearch v1.11.x - Breaking Changes

I know I don't need to upgrade Meilisearch that often, but I use renovateBot which keeps everything updated.  It seems Meilisearch now offering AI features, but I'm more worried about possible breaking changes:

Curious if you see anything to be concerned about.

Tested and working with Meilisearch v1.11.
Thanks!


Docs: automatic clean up data operation

Ⅰ. Describe what this PR does
Add docs for  automatic clean up data operation
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/test fluid-e2e

/retest


lorem-ipsum.js must not depend on 'os'

This PR is a suggestion to fix #25.
@knicklabs The change should not impact the behaviour.
I tested it on a Windows 7 64 bits running node and got \r\n as expected.
I also confirmed manually that the fix would fix the failure to build an iife module depending on lorem-ipsum.js with rollup. If you are interested into adding such iife build test, I can issue another PR for this purpose.

👍 @knicklabs Need this for a front-end generator.

@knicklabs Thanks!

Thanks a lot for the quick release.
By the way, I think I will have to open another issue related to ES6 modules builds not really supporting exports = function() {}.


[BUG] When the data in the multi-level directory is empty,  an error pops up

Which version of Dolphin Scheduler:
-[dev-resource-tree]

Does anyone begin to fix this bug? If not, I will fix it.

Does anyone begin to fix this bug? If not, I will fix it.

already fixed


Pick the longest integrity value in package-lock.json

In #35 it was suggested to pick the longest integrity instead of just the last element in the array. I had implemented it locally, but forgot to push again before the PR got merged. Sorry for that.
I'm including the change here since I think it could be useful.

Thanks! Merged :-)


github workflows: run make test on pushes and workflow_dispatch too

What
This should make it easier to keep track of whether tests are (still) passing or not.

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Probably should be limited to non-main branches?


Update the PHP Compatibility parsed output to include warnings

Pull Request Test Coverage Report for Build 175

38 of 47 (80.85%)  changed or added relevant lines in 2 files are covered.
16 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-1.03%) to 96.509%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

phpcompat/phpcompat.go
24
25
96.0%

phpcompat/parser.go
14
22
63.64%

Files with Coverage Reduction
New Missed Lines
%

sync/firestore/firestore.go
2
97.4%

message/firestore/firestore.go
2
98.02%

phpcompat/parser.go
12
91.19%

Totals

Change from base Build 167:
-1.03%

Covered Lines:
2239

Relevant Lines:
2320

💛  - Coveralls


Add docker-machine provision command

This allows users to re-run provisioning on an existing Docker Machine instance.  If something blows up during the ordinary create or provisioning process, this allows users to potentially salvage the machine using docker-machine provision.
TODO:

[ ] Add docs
[ ] Add tests

Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

Can this command help somehow with #1518 by re-provisioning Swarm agents and circumvent the certs issues on reboot? Although we lose all the containers running on the machine on the re-provisioning process right?
/cc @ehazlett

:+1:. What's the expectation for how solid this will be? I'm guessing there will be a few weird cases where the previous provisioning died in an unsalvageable way and provision won't succeed. Is there a "normal" use case for this? i.e. any reason a user would want to use provision on a host where provisioning succeeded?

Can this command help somehow with #1518 by re-provisioning Swarm agents and circumvent the certs issues on reboot?

Ideally, yes.  One of my goals with this direction is to make re-provisioning of your Swarm system's state easier.  As you're aware, right now if you do something like reboot a machine where containers from --swarm etc. were running, they are gone and you are hosed (not to mention if you accidentally remove them manually).

Although we lose all the containers running on the machine on the re-provisioning process right?

Yes, although in the future I'd like to consider making Machine capable of "elegant" restarts where it will remember which containers are running and restart them in the correct order on such an operation.

What's the expectation for how solid this will be? I'm guessing there will be a few weird cases where the previous provisioning died in an unsalvageable way and provision won't succeed.

There probably are cases where such is the case, and this is why tools like Terraform have a notion of a "tainted" resource (it's impossible to establish whether or not it can be salvaged).  Longer-termish, I'd like to make provisioning as idempotent of an operation as possible (it's not right now), so that you could reasonably be assured that by calling the same transform on the machine over and over you are getting the same result.

Is there a "normal" use case for this? i.e. any reason a user would want to use provision on a host where provisioning succeeded?

Oh, definitely -- it won't be super slick and usable right away, but medium-termish this type of command could be used to, say, update the EngineOptions and re-apply the changes to the instance.

I'd like to make provisioning as idempotent of an operation as possible

:+1: - would love to make this a less long-termish goal. Are there any issues logged about this yet? It'd be useful to flesh out all the different reasons why we don't have provisioning idempotence yet.

this type of command could be used to, say, update the EngineOptions and re-apply the changes to the instance.

Sort of like docker-machine apply? This would be totally awesome.

Agreed, SGTM!  This might be useful in many cases.

:+1: - would love to make this a less long-termish goal. Are there any issues logged about this yet? It'd be useful to flesh out all the different reasons why we don't have provisioning idempotence yet.

Nope, but feel free to go ahead and do so!

Sort of like docker-machine apply? This would be totally awesome.

Yeah, basically.

Nope, but feel free to go ahead and do so!

@nathanleclaire - done - #1605 ;)

Ah. This is what my proposed #1766 more or less is then. Cool that it's on the roadmap.

This is a little outdated and I have a more up to date one in the works


Documentation: Link not working

This link http://www.pirbot.com/mirrors/ctan/graphics/pgf/contrib/tikzducks/arxiv.org/abs/1707.02945, on footnote 3, seams to be broken.

@foreachthing Thanks for reporting! https was missing.


PV3 and PV4 dont show

Inverter 15k et:
the entities for PV3 and PV4 are not displayed for me.
In SolarGo they are displayed as normal.

The current for the MPPT is also specified in watts

thx

Indeed.
There is a copy/paste mistake in the library using power instead of current. I'll fix it.
As for the pv3/4, there is problem as well (actually a confusion of pv and mppt values).
It would be great if you could provide the raw responses from the logs so I can add them to unit tests.

Fixed in v<IP_ADDRESS>


api for column summary e.g. histogram

For ordinal value such as integer, float, date, timestamp, what about we use min, max, number of bins as parameters? The problem is what do we do with the null value..

This is essentially a histogram over a single /attribute/...entitypath.../filter/column right?  I.e. the client may have a complex query to reduce the set of entities and then we want a histogram of one column from that set of entities.
Should the min and max be optional, in which case the server has to figure it out?
Should values outside the min and max range be discarded or accumulated into first/last bins?
Do you expect to have a search UI where you would allow selection of null as a filter?  If so, I can see having a separate null bin.  If not, I think you'd want to exclude nulls from the totals and only talk about the distribution of values which can act as a facet.

There is a built-in postgres function width_bucket() which might be the right thing to use here.  It has two calling conventions:

For numeric sample types it can take a half-open interval boundary [lower,upper) and a number of steps N to divide that interval into bins, and calculates the bin number for a given sample value.

works natively for integer, float
we can apply it to dates or timestamps with an appropriate expression e.g. to convert into epoch time values or similar

For any ordered sample type (postgres anyelement polymorphism) it takes an N-length array of bin lower bounds and determines the bin number for a given sample value.

could apply to additional types like text

If we want the server to do the work, it would have to determine the min and max value for the range as separate queries and then feed that into the final histogram query.  If we want the client to control it, we need a syntax allowing for the client to specify bounds in the URL.
We have to decide whether to make this a separate API or just a special projection mode that lets us access something like the bucket function as a grouping key.  The results would be one row per bin, and should have the bin number and/or bin half-open interval values in it since it may be sparse.  We'll only see an output bin if at least one sample falls within the bin.  An advantage of doing it as a projection is that we could add other kinds of group key projection later, such as precision truncation operators for timestamps, e.g. day/week/month/year groupings.

It looks like the polymorphic width_bucket function was first added in postgres 9.5 so we won't be able to use that and test in our current travis builds unless we move them forward from 9.4 which they currently use in testing.

This is pushed to master for basic numerical column types and where the client must explicitly specify the number of bins and min/max of the value range they wish to analyze.

@hongsudt this wasn't reviewed before @RFSH went on break.  can someone else review the ermrest feature?

@RFSH @jrchudy have you guys played with the histogram api enough to close this ermrest review issue...?

A bug was found in reviewing this... the result bins were labeled with incorrect descriptive boundary values, even though correct boundaries were used to actually assign the rows to bins.  A fix for this, as well as generalization of the feature to support timestamptz and date column types has been pushed to master and also merged to the acls-everywhere branch.

After the recent fix you made @karlcz, binning seems to work a lot more appropriately. Now, as I increase the number of bins without changing the interval, I see that the bin ranges are changing appropriately.
For example, I have bin(int;9;10;100), I see bins being returned as [0, null, 10], [1, 10, 20], and [10, 100, null]. I also only see bins that had values in it. So in my example, I didn't see bins for some ranges that I had no values for the ranges 40-50 and 70-80.
I verified this works for my foreign key columns as well when it has an integer or a serial. And verified that it works for date and timestamptz columns.


Added db_owner parameter to postgres setup

This pull adds the db_owner as a role variable, removing the need to specify the owner in the playbook.

So, the way we'd done this component previously was to wrap it in another playbook that specified the correct role (see https://github.com/galaxyproject/planemo-machine/blob/master/provision.yml#L25 for an example).  Does this still work with that functionality?

You're right, there's a problem there. However, at the moment, it'll still work, only because the db_owner defaults to postgres as well. If someone has specified a different user, that would be ignored. Ideally, the sudo_user would be removed from the playbook and passed in as a parameter to the role, so that the role contains reasonable defaults. (e.g. running as root would cause the role to fail and role_dependencies don't appear to support switching users either)

Ok, cool.  I'll let someone who's more of an authority on the 'right' way to do things in Ansible weigh in on this one (whether it should be a parameter or just inherit the user), but I just wanted to understand the repercussions.  Thanks!

The problem with putting sudo right in to the role is that different sites may operate in different ways, which is why I try to push all of that logic up to the playbook level. For example, we are unable to use sudo so we have to set up ssh keys that allow people to log in directly as the system users in question. So we wouldn't be able to use this role without modification.

The embedded sudo requirement plus all the repetition are certainly not an ideal solution. However, Ansible doe not allow this option to be set at a role level (http://stackoverflow.com/questions/23759377/multiple-tasks-with-same-sudo-user-in-ansible-role) without it being wrapped in a playbook.
When this becomes problematic is when the role needs to be included as a dependency. I can't find any docs or comments saying that a variable (such as sudo or sudo_user) can be included when specifying a role as a playbook dependency. Anyone know this?
As a compromise, how about removing the sudo clause but leaving the sudo_user one? Then, if necessary, sudo can be specified at the playbook level where this is used as a dependency.
It would probably be best to follow up with Ansible guys too and see if dependency-based variables are conceptually ok, then perhaps follow up with a PR...

My honeymoon with Ansible appears to be on very shaky ground :-)
The problem I'm trying to solve is forcing me in an opposite direction to the one it's forcing Nate on - that is, to move as much as possible out of the playbook. The reason is as follows. It was apparent early on that there was a lot of repetition between the GVL playbook and the Cloudman Playbook, but it effectively doubled when Simon started developing the micro-gvl flavour, which is yet another playbook extending the GVL playbook (https://bitbucket.org/sgladman/micro-gvl-image-playbook/src)
So when Cloudman was refactored into smaller roles for example, or additional variables were introduced, both the GVL and the micro GVL would break.
The only solution appeared to be to minimise the content that's repeated in playbooks, and simplify it to something like:
-include: gvl
and the gvl role would internally encapsulate all its dependencies, default variables etc. Similarly, the gvl would include: cloudman - turtles all the way down. The world would be beautiful again.
It looked like dependencies was the way to go. Dependencies have very limited functionality at present, and apart from the fact that they introduce a specialised mechanism for mysterious reasons (instead of following the existing mechanism through which roles are included in playbooks with pre/post tasks), they don't support anything other than simple role parameters.
Nevertheless, I thought I almost had it nailed, after going to the extent of creating a dummy role to execute pre-tasks, this latest pull was the final step that would have solved the issue once and for all.
Then Nate rained on my parade :-)
To be fair, the problem he's talking about is even less negotiable - since there's almost no room to side-step the issue he mentioned.
So I'm not sure what now. WRT to using sudo_user without sudo, does that work? Is sudo_user ignored if sudo: yes is not defined? If so, that seems like a simple and splendid workaround.
The only other thing I can think of doing is a conditional include as follows:
(in cloudman-database/defaults/main.yml)
-include: database_tasks.yaml
sudo: yes
sudo_user: {{ db_user }}
when: db_user is defined
-include: database_tasks.yaml
when: db_user is not defined
and move all the tasks into database_tasks.yaml. This way, the included tasks would execute whichever way we want them to, depending on whether db_user is defined or not.

OK, a compromise I mentioned above seems to work well I think. Here's a summary of what I ran: http://pastie.org/10067628
Now, if sudo is not set at the playbook level, the role just runs as the login user (ie, ubuntu) regardless of what is set in the role as sudo_user. Conveniently, the role/playbook does not crash. If sudo is set (as the case is the provided pastie), then sudo_user is honored and the role runs as such (postgres in this case).
So I think leaving sudo_user and removing sudo will work for the desired scenarios because it only requires setting sudo if desired at the playbook level that's using this role.

Thanks for the feedback and great solution! I'm running a build now and it seems to be working well.  Check [here] (https://bitbucket.org/gvl/gvl-image-playbook/src/9d36da2e246f1cdcdb0c1036cd208312132e5d3a/cloud.yml?at=master). Almost no knowledge required or repeated from the role internals. Almost, because sudo: yes and the galaxy user name still leak out. If it's ok, I might issue a similar pull for Galaxy, moving that username bit out as well. And there's still the flexibility to handle the no sudo case. Looks like a win win.
Of course, in the long run, this still has a chance to break, if ever there's a dependency on a role for which this is just not doable. I've posted a question on the Ansible mailing list about this. Not sure whether there'll be any traction on it, but I do hope they make the role dependency mechanism more consistent with playbooks. It looks like pre_tasks for roles might be in the works.


PWM - frequency

ledc_timer_config_t timer;
memset(&timer, 0, sizeof(timer));
timer.freq_hz = 100;
timer.duty_resolution = 10;
timer.speed_mode = LEDC_HIGH_SPEED_MODE;
timer.timer_num = LEDC_TIMER_0;
I expected that this leads to a 100 Hz frequency, But the result is a 50 Hz frequency. Why the factor 2 ???

I've tested your code, but the frequency seems correct according to the logic analyser.

@Reiner1210 , is there any update? Could you provide a test project so we can reproduce your problem?

I will retry it - tomorrow
Am 12. Juli 2018 5:21:28 vorm. schrieb FayeY<EMAIL_ADDRESS>
@Reiner1210 , is there any update? Could you provide a test project so we
can reproduce your problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Mit AquaMail Android
https://www.mobisystems.com/aqua-mail

I use the following
timer.freq_hz = 1000;
timer.duty_resolution = 10;
timer.speed_mode = LEDC_HIGH_SPEED_MODE;
timer.timer_num = LEDC_TIMER_0;
uint32_t duty = (uint32_t)((float)(1<<timer.duty_resolution) * 0.25f + .5f);
This leads to the following:

Hi @Reiner1210 ,
Have you changed the frequency when config, Could you provide more code ?

@Reiner1210 Could you help provide some updates? Thanks.

@Reiner1210 Could you help share if any updates for this issue? Thanks.


Juliaup launcher Crash Report

I am using the newest Juliaup and the newest Julia (1.9.1) via juliaup (juliaup add 1.9). I can't run versioninfo() because Julia won't start.
Here is the crash report:
name = 'Juliaup launcher'
operating_system = 'unix:Unknown'
crate_version = '1.8.16'
explanation = '''
Panic occurred in file 'src/config_file.rs' at line 120
'''
cause = 'called `Result::unwrap()` on an `Err` value: Os { code: 524, kind: Uncategorized, message: "No error information" }'
method = 'Panic'
backtrace = '''

   0: 0x7fffed63ea15 - julialauncher::main::h7c3cfe36d9073d96
   1: 0x7fffed6343c3 - std::sys_common::backtrace::__rust_begin_short_backtrace::hafff6f50adcb8cae
   2: 0x7fffed64650e - main'''

I am running on Frontier, and HPC system at OLCF https://www.olcf.ornl.gov/frontier/. I installed Juliaup and Julia on a login node, and I am receiving this crash report when running on a compute node.

I believe a dup of https://github.com/JuliaLang/juliaup/issues/252.


Use no_std unless the "std" feature is present

This crate was 99% of the way there for no_std support. Here's the last 1%.

Bump, should this be merged as it has already been approved?

I'd definitely appreciate that as otherwise I continue to operate off this branch for the latest dalek to work on no_std


Fix burr() distribution stats() method and add other methods

closes scipy issue #9544 (mean and stats method of burr() return erroneous results).
Also fixes the issues in fisk and burr12 that inherit from burr.
Adds unit test(s) for c<1 case (mean/variance are np.nan and c>1 case (mean is finite).
Also cleans up the docstring for burr and adds refs.

The pypy3 circle CI build fails are something in the signal library (no signal code touched in this PR) so unrelated.

looks like the 2 failures are random; circile ci "Too long with no output (exceeded 10m0s)" and the azure build is related to mpmath precision issues at complex values of z. Both having nothing to do w/my changes. I'm going to remove the LIC44-45 of tests/test_continuous_basic.py and see if the build still works. Other than these changes I'll just address whatever comments there are in the PR that come up (I think I got all of @chrisb83 comments but let me know if I missed something).

burr: sample mean test fails still for c<1
?['burr', (0.94839838075366045, 4.3820284068855795)],

Denominator is missing?

Too late at night I guess :). Most recent pushed commit should resolve the issues (except for flaky tests).
Thanks for catching! I couldn't figure out what the issue was last night.

For the Azure build the log shows the same tests as before;
\special\tests\test_mpmath.py::TestSystematic
tests under this are nothing I've touched, not sure if this is flaky b/c of windows 32 bit machine or just windows :).
Everything else looks good.

@ev-br @chrisb83 @WarrenWeckesser @josef-pkt friendly bump, anything else I should change on this PR?

@WarrenWeckesser Thanks for the comments! I hadn't caught the broadcast error, good eyes!
I reshaped the np.arange(1,5) to np.arange(1,5).reshape(4,1) which appears to fix the broadcasting issue for _stats and mean. I think this most recent commit (commit <5 minutes ago) addresses the 3 comments you've made here. Please let me know if I missed something.

I think this most recent commit (commit <5 minutes ago) addresses the 3 comments you've made

Nope, the broadcast wasn't fixed. Most recent commit fixes broadcast and hacks to fix issues that propogate from (I think) removal of _sf.

I think this most recent commit (commit <5 minutes ago) addresses the 3 comments you've made

Nope, the broadcast wasn't fixed. Most recent commit fixes broadcast and hacks to fix issues that
propogate from (I think) removal of _sf.

Nope. I put _sf implementation back into burr and ran unit tests that doesn't fix the error I was getting. However, the most recent commit fixes both broadcast issue and the too many args issue in fisk. @WarrenWeckesser your comments have been addressed and passing CI, (azure build is flaky), do you have more comments for me to address?

@rlucas7, thanks.  I probably won't get back to this until after the holidays.

@WarrenWeckesser the most recent push removes some of the Fisk distribution changes (they weren't necessary after some cleanup) and addresses the broadcast issue. The method to fix the broadcast unwraps the first 4 moments into separate lines of code. This works and I can't think of a more elegant way to do the first 4 moments. Your code is more elegant than mine so let me know if you have any idea on a fix. Otherwise, I'll leave as is.

git rebase fail, git 1, rlucas7, 0. :(

Relevant commits are 5770438 and below, correct? I'd cherry-pick them into a new branch, then force-push here.

@ev-br thanks for suggesting the approach, not clear to me if by "here" you mean the pull request branch directly or the associated branch on my forked repo. Could you clarify which is meant by
"here"?

Here I squashed your 30+ commits to make cherry-picking easier, please check.
https://github.com/ev-br/scipy/pull/new/pr/9585-copy
A way to squash is to first git log to find the first commit beyond your commits, then
git rebase -i 74c32fb2914bb76e90a91929b03ede6330dfbfcf where the commit hash is what you've just found. Then in the editor which opens, change pick to f, close the editor. If there are conflicts, resolve them (git status, open the files which are "both" changed, search for >>>>>>>, edit, save, git add <filename> && git rebase --continue)
Notice that I did all this in a copy of a branch --- best make a copy whenever you're about to rebase things.
Once there's a single commit then just git cherry-pick <commit hash> , test it, and git push origin --force <pr-branch-name>.
Two main gotchas are

interactive rebase off too old commit (I guess this is what happened here). Always find the most recent commit for which to rebase onto.
force-pushing to the remote repo (git push --force). This is needed because rebasing changes commit hashes.

Hope this helps :-)

I'd try 1) check git status locally, 2) check the origin fork (have you actually pushed it already?), 3) git push origin local_branch:new_name

I'd try 1) check git status locally, 2) check the origin fork (have you actually pushed it already?), 3) git push origin local_branch:new_name

This creates a new branch on my forked repository with the option to open a new pull request-was that the desired outcome?
scipy-dev) Lucass-MacBook:stats rlucas$ git push origin scipy_issue_9544:gh_issue_9544
Total 0 (delta 0), reused 0 (delta 0)
remote:
remote: Create a pull request for 'gh_issue_9544' on GitHub by visiting:
remote:      https://github.com/rlucas7/scipy/pull/new/gh_issue_9544
remote:
To https://github.com/rlucas7/scipy.git
 * [new branch]          scipy_issue_9544 -> gh_issue_9544

Yes :-). That, or delete the old local branch, rename the new one to an old name and force-push.

Yes :-). That, or delete the old local branch, rename the new one to an old name and force-push.

Ok. I've got a new PR branch, I'll keep this one open for now until the PR is merged.

@rlucas7 can we close this PR to get it out of the review queue?

@rlucas7 can we close this PR to get it out of the review queue?

Yes closing. I had left it open thinking I would merge the new PR, but the PR from @pvanmulbregt incorporates some of this PR and other stuff too and should be the merged one. I'll close both of my PRs on this issue.

To be clear, closing in favor of PR #9983


possible to use a method in model as column

First I tried this… which did not work
multisearchable against: [:title, :desc, :details],  associated_against: { brand: :name }

Is it possible to use something like this, to allow pg_search to index off the brand/tags of a product. Or what is the best approach to do something like this?
class Product

    has_and_belongs_to_many :tags
    belongs_to :brand

    multisearchable against: [:title, :desc, :details, :brand_name, :tag_names]

    def brand_name
        brand.name
    end

    def tag_names
        tags.pluck(:name).join(", ")
    end
end

ran the associated_against migration as directed, and then rebuilt my index on Product, but i don't see the brand names being added to teh content column of the search index table
EDIT: I got this to work by adding the naive approach update method in the model
def self.rebuild_pg_search_documents
    find_each { |record| record.update_pg_search_document }
end

It would not work with the rake pg_search:multisearch:rebuild[Product], but worked fine using this method. Hopefully this is the proper way to approach this. It makes sense, as it the methods do not exist in a query/SQL.
THIS GEM ROCKS.

Yes, your usage should be working fine without the naive approach.
I think this is the same issue as in #214 so I am closing this one out to save space. Let me know if that's an incorrect assumption. Thanks!

Duplicate of #157


Split multiline OCR text with newlines

Better recognition of newlines in multiline document / image. Currently, most of the time multiple lines are merged into a single string without separator (space/newline). This relates to the text only OCR view
For reference, https://github.com/SubhamTyagi/android-ocr also uses tesseract as OCR engine and the newline detection is significantly more accurate, maybe some preprocessing or filters can be borrowed from there

@balporig yes it was done on purpose because there was far too many unwanted new lines. Will find a better way

@balporig new build released on github.


Fixed PATH clobbering by bad kit file env

This change addresses item #701 and #713
This changes kit file caching of PATH variable on MinGW kits
The following changes are proposed:

rename PATH to CMT_MINGW_PATH in kits file
correct usage of stat.isFile to function call (stat.isFile()) in getCTestPath()

Other Notes/Information
In the issues above, the problem occurs because the ctest command is not found in the PATH variable as defined in the output of getEffectiveSubprocessEnvironment().  This may be caused by the actual absence of CTest in PATH, but it is also possible that the true environment PATH can be clobbered by the values in the kit file if using the kit environment is enabled.  MinGW kits, in their original behavior, would record the current value of PATH at the time of the scan as a kit environment variable. In my case, I scanned for kits before I had added the CMake directory to my environment path, and thus CTest could not be found.  Because the kit environment takes precedence when enabled, it was using the old cached value and hiding CTest from the executeCommand() call even after I updated my system PATH to include the path to CMake and CTest.
See issues #759 for more issues about why CTest is downmoding to searching on the PATH in the first place.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: emanspeaks sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can someone help me with addressing the failed Travis CI builds?  I'm not sure I understand what is broken there or how to fix it.

Can you revert the changes to package.json and see if that addresses the issue?  I wasn't sure why it was changed.  I don't see anything else in this change that could potentially fail the build.

Yup the package revert fixed it!  I think this is good to go now.

Thank you for the bug fix!


Errors building ReactiveUI solution

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When I pull down the latest on ReactiveUI open the solution in Visual Studio 2017 15.4, I get build errors.  I am unable to build the source code on my local machine.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Below is a gist containing the list of build errors I am seeing.
I am running Visual Studio 2017 15.4
dotnet --version returns 1.1 but I am sure I have other versions installed.
What is the expected behavior?
The expected behavior is that I am able to build the source code on my local machine.
What is the motivation / use case for changing the behavior?
I wanted to work on issues blocking the 8.0 release.
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot
This is not an issue with consumption of ReactiveUI, more an issue that I can't work on the source code.
Other information (e.g. stacktraces, related issues, suggestions how to fix)
https://gist.github.com/RLittlesII/cf1672088522ab9d3b18135e0df899d3
Some of the errors are valid which I see in the project they are set "Warnings as Errors" which are the NU1202 errors, although I am still not sure how to solve those.

Thanks for reporting this.
Can I check a couple of things

do you know which workloads you have installed
would you be able to do git reset HEAD --hard and git clean -fdx
is this from within VS, or is this the output of running build.cmd?

I updated my fork and don't see this issue anymore.  I was getting this from the command line running .\build.cmd in Power Shell.

Thanks for confirming, shout if you hit similar problems again!


[SPARK-47309][SQL][XML] Add schema inference unit tests

What changes were proposed in this pull request?

As titled.
Why are the changes needed?

Fix a bug.
Does this PR introduce any user-facing change?

Yes
How was this patch tested?

Unit tests
Was this patch authored or co-authored using generative AI tooling?

No

Merged to master.


Command_WebAPIProcess_ExecuteAsync wipes RowVersion

In : https://github.com/microsoft/PowerPlatform-DataverseServiceClient/blob/dfba939dbbfe967c5ef339dfffa70ba41b7196ab/src/GeneralTools/DataverseClient/Client/ConnectionService.cs#L1757
RowVersion is not cloned, this leads to https://github.com/microsoft/PowerPlatform-DataverseServiceClient/blob/dfba939dbbfe967c5ef339dfffa70ba41b7196ab/src/GeneralTools/DataverseClient/Client/ConnectionService.cs#L1846 always returning false thus https://github.com/microsoft/PowerPlatform-DataverseServiceClient/blob/dfba939dbbfe967c5ef339dfffa70ba41b7196ab/src/GeneralTools/DataverseClient/Client/ConnectionService.cs#L1864 always throws.
Which also contains a spelling error (then/than).
Which AFAICT makes deletion with optimistic concurrency impossible.

Thanks for your report,  Team is having a look at it as part of the current pass.


[FEATURE] Develop a web-based sandbox/IDE

This was suggested by @ebuchman.
This issue would probably involve a separate project that leveraged Apalache, but this seems to be a good place to the track the idea for the issue, just to get started.
Some eventual features might include:

In browser IDE support (at least basic linting and syntax highlighting)
Basic file management
Running checks on our backend server
Export/import of .tla files
Production of counter-examples

This has already been build.  See screencast at http://tla.msr-inria.inria.fr/kuppe/TLAExamplesGitpod3cut.mp4 and https://github.com/lemmy/BlockingQueue/tree/apalache  for apalache specifically.  Works with gitpod (GCE), VSCode codespaces, and Github codespaces.

Nice! Then this may be closer to hand then initially thought. Perhaps we only need some documentation and accessible and visible on-ramp to get people taking advantage of these.

Can apalache be installed from an apt repository?  If yes, the gitpod & vscode setup could be simplified by removing docker entirely.

We definitely should not duplicate work. As for apt, it looks like the standard packages for z3 do not include java bindings.

What about https://packages.ubuntu.com/focal/libz3-java ?

We should understand, whether we need two build environments instead of one. Our current build environment is tuned towards development. We cannot depend on the availability of z3 at the system level, as z3 had API incompatibilities in the past. However, if we like to maintain an apt package in Ubuntu, we have to deal with the system-level instance of z3.

As an intermediate step for a web IDE, apalache.jar (without z3) could - like tla2tools.jar - be bundled with the VSCode extension and (implicitly) depend on the current z3 version available in Ubuntu 20.04.  The z3 version is fixed as per the Ubuntu package policy and we have two years to the next Ubuntu LTS, which Codespaces or Gitpod will eventually switch to.

Two years sounds like a lot to be stuck with the same version of z3... Not that we jump to the new versions all the time, but the new versions sometimes boost the tool's performance for free.

You could deliberately decide to use an Unstable/PPA with a newer version of z3.  I'd just say that this is a decision to be made by whoever maintains the IDE and not the individual users.

I've updated https://github.com/lemmy/BlockingQueue/tree/apalache to use the docker image apalache/mc on Github Codespaces.  If there is interest to try it out, please request early access and get back to me (I should be able to fast-track your request).

Hi Markus! Yes, that sounds interesting. I have requested early access. If you could fast-track, that would be great.

Wow. That looks great! Thanks!

A few issues that I've observed:

Codespace suspends on inactivity despite Apalache running in the background
Apalache docker image:

bash not default shell
Runs as root (cosmetic issue)

Between @lemmy's work on codespaces and the sandbox here https://github.com/informalsystems/apalache-sandbox, we effectively have this.
But we've de-prioritized expanding on it for the time being.


[CARBONDATA-1448] fix partitionInfo null issue in CarbonTableInputFormat

Build Failed with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/106/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/230/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/231/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/107/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/861/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/862/

LGTM


Adding support for icasa Zigbee 3.0 keypad ICZB-KPD18S

As discussed the zigbee messages are found fine now.
Bedankt/Thanks Koen ;-)

Thanks!


Reuse Reducer code

Hi guys
I´m developing an application using built_redux, but I need that some componets and modules can be reused in other applications. For instance, if we develop a dashboard module, it needs to be reused in other applications.
As you know, when we create a module, it needs an aplication state (AppState), actions, middleware, reducer, and views.
My questios is, there is a way to reuse middleware, reducers, actions and state?
there is a pattern to extend states?
I appreciate you help
Thank you in advance

Hi
I just have implemented a saga middleware which I think is a perfect candidate for answering the problem of reusability in the middleware layer. It's built above built_redux.
It's very early in it's development stage but I am using it in a very big project and evolving it at the same time.
https://pub.dartlang.org/packages/built_redux_saga


search count messages do not show in Statusline Components

Describe the bug
Since commit e5092c2 (#211), the search count message does not appear in status line. What is weird is that the first result has a search count, but subsequent n/N matchs and searches do not. Status line config can be seen in GIF.
Which version of Neovim are you using?
NVIM v0.9.0-dev-296+g7335a67b5
To Reproduce
Steps to reproduce the behavior:

It was "working" (although disappearing) in fb0e3b0.

Expected Behavior
Search count in status line.
Screenshots

Noice Log
Nothing relevant.

I assume you had vim.go.hlsearch = false set in your config? That didn't work as intended. Should be fixed now!

Hi, sorry for the late response.
I tested it on c11d1c6 and unfortunately, it is still the same behaviour as before. Also, as you mentioned, I have vim.go.hlsearch = false. I tried setting it to true, but the problem is still there.

It really should work now. Are you sure you updated?
And it already workes with hlsearch=true.
What is your Noice config?

Are you sure you updated?

Yes I previously had 7b62ccf stapled in packer (commit = ...) and the feature was working. I removed that option, updated, and double checked the git repo sha in .local/share/nvim/... and it was c11d1c6.
My config is as follow:
require("noice").setup({
  popupmenu = {
    enabled = false, -- enables the Noice popupmenu UI
  },
  notify = {
    enabled = false,
  },
  lsp = {
    progress = {
      enabled = false,
    },
    override = {
      -- override the default lsp markdown formatter with Noice
      ["vim.lsp.util.convert_input_to_markdown_lines"] = true,
      -- override the lsp markdown formatter with Noice
      ["vim.lsp.util.stylize_markdown"] = true,
    },
    documentation = {
      view = "hover",
      opts = {
        lang = "markdown",
        replace = true,
        render = "plain",
        format = { "{message}" },
        win_options = { concealcursor = "n", conceallevel = 3 },
      },
    },
  },
  presets = {
    lsp_doc_border = true
  },
  routes = {
    {
      filter = {
        event = "msg_show",
        ["not"] = {
          kind = { "confirm", "confirm_sub" },
        },
      },
      opts = { skip = true },
    },
  },
})

You will want to remove that lang=markdown. That's no longer needed and will lead to rendering issues most likely.
Also be aware that you're skipping all messages? So command output, errors, ...
Apart from that all works as expected with your config for me.
Please provide a https://github.com/folke/noice.nvim/wiki/Minimal-`init.lua`-to-Reproduce-an-Issue

Also, what is your statusline config?

I was able to get a complete reproductible example with that:
minimal.txt

You're getting the last message in the statusline, not search. Please check the docs

Oh! Now I get it, thanks! I was searching at the wrong place since the behaviour changed in updating to latest commit. My apologies for the trouble, I did not read the docs correctly.


Pit tag row numbers between field notes and reader csv export not aligned

See https://github.com/NewGraphEnvironment/dff-2022/issues/44
As per the last entry

Looking at the times of the pit_tag file generated from

dff-2022/scripts/pit_tags.R
Line 13 in 066c382
pit_tag <- readr::read_csv(path) %>%
they look like those first two fish from the Missinka site. If that is the case then the numbers in the fish dataframe would all be off by one. To remedyis  that we would have needed to add 1 to the row_id numbering in the pit_tag sheet for it to match.

Since this is already done we probably just leave it but for reference the way to fix it is perhaps  to mutate the row ID column of the fish day frame by subtracting one before joining

You were right, when I imported the tag data for skeena I subtracted one from tag_row column in fish_data.csv and that did the trick. I had to do this by hand though because I needed the paper cards to find out which fish got a tag and which didn't. Hope that makes sense.


Issues running finetuned versions of supported models

I've been testing running various finetuned versions of supported models on GKE. However, it gets stuck on  Using the Hugging Face API to retrieve tokenizer config
This are the full logs
2024-07-02T18:54:46.894948Z  INFO text_generation_launcher: Args { model_id: "ICTNLP/Llama-2-7b-chat-TruthX", revision: None, validation_workers: 2, sharded: None, num_shard: None, quantize: None, speculate: None, dtype: None, trust_remote_code: false, max_concurrent_requests: 4, max_best_of: 2, max_stop_sequences: 4, max_top_n_tokens: 5, max_input_tokens: None, max_input_length: Some(32), max_total_tokens: Some(64), waiting_served_ratio: 1.2, max_batch_prefill_tokens: None, max_batch_total_tokens: None, max_waiting_tokens: 20, max_batch_size: Some(1), cuda_graphs: None, hostname: "tgi-tpu-84bdb4d847-fdw7j", port: 80, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: Some("/data"), weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, rope_scaling: None, rope_factor: None, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_edge: None, tokenizer_config_path: None, disable_grammar_support: false, env: false, max_client_batch_size: 4 }
2024-07-02T18:54:46.895049Z  INFO hf_hub: Token file not found "/root/.cache/huggingface/token"
2024-07-02T18:54:47.190379Z  INFO text_generation_launcher: Default `max_batch_prefill_tokens` to 32
2024-07-02T18:54:47.190398Z  INFO text_generation_launcher: Using default cuda graphs [1, 2, 4, 8, 16, 32]
2024-07-02T18:54:47.190512Z  INFO download: text_generation_launcher: Starting download process.
2024-07-02T18:54:47.270672Z  WARN text_generation_launcher: 'extension' argument is not supported and will be ignored.

2024-07-02T18:54:51.295843Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2024-07-02T18:54:51.296183Z  INFO shard-manager: text_generation_launcher: Starting shard rank=0
2024-07-02T18:54:53.940271Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-0

2024-07-02T18:54:54.000595Z  INFO shard-manager: text_generation_launcher: Shard ready in 2.703388509s rank=0
2024-07-02T18:54:54.098804Z  INFO text_generation_launcher: Starting Webserver
2024-07-02T18:54:54.121130Z  INFO text_generation_router: router/src/main.rs:185: Using the Hugging Face API
2024-07-02T18:54:54.121182Z  INFO hf_hub: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/hf-hub-0.3.2/src/lib.rs:55: Token file not found "/root/.cache/huggingface/token"
2024-07-02T18:54:54.436475Z  INFO text_generation_router: router/src/main.rs:471: Serving revision 2d186e966af6eaa237495a39433a6f6d7de3ad9e of model ICTNLP/Llama-2-7b-chat-TruthX
2024-07-02T18:54:54.436496Z  INFO text_generation_router: router/src/main.rs:253: Using config Some(Llama)
2024-07-02T18:54:54.436501Z  INFO text_generation_router: router/src/main.rs:265: Using the Hugging Face API to retrieve tokenizer config

I get this issue in the following models: RLHFlow/ArmoRM-Llama3-8B-v0.1, Trendyol/Trendyol-LLM-7b-base-v0.1, ICTNLP/Llama-2-7b-chat-TruthX.
However, I've also been able to successfully run the following models: UCLA-AGI/Llama-3-Instruct-8B-SPPO-Iter3, georgesung/llama2_7b_chat_uncensored
I was wondering if there were any requirements in terms of files that were required to run a finetuned model? Or any help debugging the issue
This is the yaml that I used to deploy
apiVersion: apps/v1
kind: Deployment
metadata:
  name: tgi-tpu
spec:
  replicas: 1
  selector:
    matchLabels:
      app: tgi-tpu
  template:
    metadata:
      labels:
        app: tgi-tpu
    spec:
      nodeSelector:
        cloud.google.com/gke-tpu-topology: 2x4
        cloud.google.com/gke-tpu-accelerator: tpu-v5-lite-podslice
      volumes:
        - name: data-volume
          emptyDir: {}
      containers:
      - name: tgi-tpu
        image: {optium_tpu_image}
        args:
        - --model-id=ICTNLP/Llama-2-7b-chat-TruthX
        - --max-concurrent-requests=4
        - --max-input-length=32
        - --max-total-tokens=64
        - --max-batch-size=1
        securityContext:
            privileged: true
        env:
          - name: HF_TOKEN
            value: {my_hf_token}
        ports:
        - containerPort: 80
        volumeMounts:
            - name: data-volume
              mountPath: /data
        resources:
          limits:
            google.com/tpu: 8
---
apiVersion: v1
kind: Service
metadata:
  name: service
spec:
  selector:
    app: tgi-tpu
  ports:
    - name: http
      protocol: TCP
      port: 8080
      targetPort: 80

Hi @Edwinhr716, we're investigating this, we will get back to you!

any update for this? why any finetuned versions will not be supported?

The error is:
2024-07-02T18:54:54.121182Z  INFO hf_hub: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/hf-hub-0.3.2/src/lib.rs:55: Token file not found "/root/.cache/huggingface/token"

So it looks like you are missing a Huggingface token. Did you run huggingface-cli login --token [TOKEN]?

I don't think it is related to that log. I've had the same log show up in successful deployments of optimum tpu.

It needs to be run in the same container as tgi-tpu. Try adding that as an init-container.

@Edwinhr716 could you share the full logs? I think you'd mentioned over chat that you saw some warning like this:
 Could not find a fast tokenizer implementation for Trendyol/Trendyol-LLM-7b-base-v0.1

Those are the full logs. That was the initial issue that I was facing, but I circumvented it by duplicating the Trendyol repo and adding the Llama2 tokenizer here: https://huggingface.co/Edwinhr716/Trendyol-LLM-7b-chat-v0.1-duplicate/tree/main. After doing that, I get the issue mentioned here.

Based on the comment in the slack channel (https://huggingface.slack.com/archives/C06GAFTA5AN/p1721259640899439), looks like this may be due to a known issue with TGI container serving fine-tuned models?

Not sure, I just tested deploying ICTNLP/Llama-2-7b-chat-TruthX using TGI 2.0.2 release and was able to do it successfully. These are the log messages for the TGI one
2024-07-18T17:34:52.776080Z  INFO text_generation_router: router/src/main.rs:195: Using the Hugging Face API
2024-07-18T17:34:52.776138Z  INFO hf_hub: /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/hf-hub-0.3.2/src/lib.rs:55: Token file not found "/root/.cache/huggingface/token"
2024-07-18T17:34:53.048994Z  INFO text_generation_router: router/src/main.rs:474: Serving revision 2d186e966af6eaa237495a39433a6f6d7de3ad9e of model ICTNLP/Llama-2-7b-chat-TruthX
2024-07-18T17:34:53.087825Z  INFO text_generation_router: router/src/main.rs:289: Using config Some(Llama)
2024-07-18T17:34:53.090733Z  INFO text_generation_router: router/src/main.rs:317: Warming up model
2024-07-18T17:34:53.953134Z  INFO text_generation_launcher: Cuda Graphs are enabled for sizes [1, 2, 4, 8, 16, 32]

2024-07-18T17:34:54.490155Z  INFO text_generation_router: router/src/main.rs:354: Setting max batch total tokens to 125856
2024-07-18T17:34:54.490179Z  INFO text_generation_router: router/src/main.rs:355: Connected
2024-07-18T17:34:54.490183Z  WARN text_generation_router: router/src/main.rs:369: Invalid hostname, defaulting to <IP_ADDRESS>

And this is the yaml that I used for the GPU one
apiVersion: apps/v1
kind: Deployment
metadata:
  name: tgi-gemma-deployment
spec:
  replicas: 1
  selector:
    matchLabels:
      app: gemma-server
  template:
    metadata:
      labels:
        app: gemma-server
        ai.gke.io/model: gemma-2b-1.1-it
        ai.gke.io/inference-server: text-generation-inference
        examples.ai.gke.io/source: user-guide
    spec:
      containers:
      - name: inference-server
        image: ghcr.io/huggingface/text-generation-inference:2.0.2
        resources:
          requests:
            nvidia.com/gpu: 1
          limits:
            nvidia.com/gpu: 1
        args:
        - --model-id=$(MODEL_ID)
        - --num-shard=1
        env:
        - name: MODEL_ID
          value: ICTNLP/Llama-2-7b-chat-TruthX
        - name: PORT
          value: "8000"
        - name: HUGGING_FACE_HUB_TOKEN
          valueFrom:
            secretKeyRef:
              name: hf-secret
              key: hf_api_token
        volumeMounts:
        - mountPath: /dev/shm
          name: dshm
      volumes:
      - name: dshm
        emptyDir:
          medium: Memory
---
apiVersion: v1
kind: Service
metadata:
  name: llm-service
spec:
  selector:
    app: gemma-server
  type: ClusterIP
  ports:
  - protocol: TCP
    port: 8000
    targetPort: 8000

Taken from https://cloud.google.com/kubernetes-engine/docs/tutorials/serve-gemma-gpu-tgi.
So It seems like it is an optimum TPU side issue

Looked into this with @Edwinhr716 . Optimum tpu is failing to load these models for various reasons:
RLHFlow/ArmoRM-Llama3-8B-v0.1
  File "/usr/local/lib/python3.10/dist-packages/text_generation_server/generator.py", line 818, in _mp_fn
    generator = TpuGeneratorSingleThread.from_pretrained(model_path, revision, max_batch_size, max_sequence_length)
  File "/usr/local/lib/python3.10/dist-packages/text_generation_server/generator.py", line 776, in from_pretrained
    model = AutoModelForCausalLM.from_pretrained(
  File "/opt/optimum-tpu/optimum/tpu/modeling.py", line 64, in from_pretrained
    model = cls.from_pretrained(pretrained_model_name_or_path, *model_args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 3626, in from_pretrained
    model = cls(config, *model_args, **model_kwargs)
  File "/opt/optimum-tpu/optimum/tpu/modeling_llama.py", line 1182, in __init__
    self.lm_head = ColumnParallelLinear.create(
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 605, in create
    return ColumnParallelLinear(
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 496, in __init__
    self.output_size_per_partition = divide_and_check_no_remainder(out_features, self.world_size)
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 218, in divide_and_check_no_remainder
    ensure_divisibility(numerator, denominator)
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 212, in ensure_divisibility
    assert numerator % denominator == 0, "{} is not divisible by {}".format(numerator, denominator)
AssertionError: 128257 is not divisible by 4

Trendyol/Trendyol-LLM-7b-base-v0.1
  File "/usr/local/lib/python3.10/dist-packages/torch_xla/_internal/pjrt.py", line 71, in _thread_fn
    return fn()
  File "/usr/local/lib/python3.10/dist-packages/torch_xla/_internal/pjrt.py", line 187, in __call__
    self.fn(runtime.global_ordinal(), *self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/dist-packages/text_generation_server/generator.py", line 818, in _mp_fn
    generator = TpuGeneratorSingleThread.from_pretrained(model_path, revision, max_batch_size, max_sequence_length)
  File "/usr/local/lib/python3.10/dist-packages/text_generation_server/generator.py", line 776, in from_pretrained
    model = AutoModelForCausalLM.from_pretrained(
  File "/opt/optimum-tpu/optimum/tpu/modeling.py", line 64, in from_pretrained
    model = cls.from_pretrained(pretrained_model_name_or_path, *model_args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 3626, in from_pretrained
    model = cls(config, *model_args, **model_kwargs)
  File "/opt/optimum-tpu/optimum/tpu/modeling_llama.py", line 1182, in __init__
    self.lm_head = ColumnParallelLinear.create(
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 605, in create
    return ColumnParallelLinear(
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 496, in __init__
    self.output_size_per_partition = divide_and_check_no_remainder(out_features, self.world_size)
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 218, in divide_and_check_no_remainder
    ensure_divisibility(numerator, denominator)
  File "/opt/optimum-tpu/optimum/tpu/xla_model_parallel.py", line 212, in ensure_divisibility
    assert numerator % denominator == 0, "{} is not divisible by {}".format(numerator, denominator)
AssertionError: 44222 is not divisible by 4

ICTNLP/Llama-2-7b-chat-TruthX
File "/usr/local/lib/python3.10/dist-packages/torch_xla/_internal/pjrt.py", line 71, in _thread_fn
    return fn()
  File "/usr/local/lib/python3.10/dist-packages/torch_xla/_internal/pjrt.py", line 187, in __call__
    self.fn(runtime.global_ordinal(), *self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/dist-packages/text_generation_server/generator.py", line 818, in _mp_fn
    generator = TpuGeneratorSingleThread.from_pretrained(model_path, revision, max_batch_size, max_sequence_length)
  File "/usr/local/lib/python3.10/dist-packages/text_generation_server/generator.py", line 776, in from_pretrained
    model = AutoModelForCausalLM.from_pretrained(
  File "/opt/optimum-tpu/optimum/tpu/modeling.py", line 64, in from_pretrained
    model = cls.from_pretrained(pretrained_model_name_or_path, *model_args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 3305, in from_pretrained
    raise EnvironmentError(
OSError: Error no file named pytorch_model.bin, model.safetensors, tf_model.h5, model.ckpt.index or flax_model.msgpack found in directory /data/models--ICTNLP--Llama-2-7b-chat-TruthX/snapshots/2d186e966af6eaa237495a39433a6f6d7de3ad9e.

For some reason the stdout or stderr logs are not getting redirected back to the console.


MUMUP-2202: Update home page search bar, make mobile search look better, improve crest and title

Before:

After:

For now we can't really update the placeholder text, because our search results don't show people or web results yet, so I left the text as is. @keirserrie let me know if you think something else would be better for the text in the meantime.
You'll notice the crest is a bit larger and moved up and left, so it overflows on both sides. I think this looks better, but open to opinions.
Also, fixed mobile so it looks better:
Before:

After:

:+1:

I like the server error in your screen shot
the mobile thing makes me feel better

Well done, :+1:

Looks great! Nitpicks when possible: reduce space btw "MyUW" and searchbar and also line up right margins :+1:

@keirserrie good idea wrt space between, what do you mean by right margins though?

Sorry, this should make it clearer--

I like pictures


Geotagger updates SEG-Y file generated from Zond Aero LF GPR with wrong coordinates

Attached are template of Emlid Studio generated POS file, SEG-Y file and corresponding position.csv file
After coordinates injection it is visible (in Prism2 for example) that coordinates in SEG-Y file are wrong (shape of trahjectory is absolutly different).
Original track:

Track after coordinates injection:

Reach-Rover_raw_20230624202211.zip
2023-06-24-20-23-00-gpr.zip
2023-06-24-20-23-00-position.zip

Fixed in release 1.0.6


Create CODEOWNERS

@cullenlam-jask need for this.

Hi @perk-sumo! Could you add this team as an admin of this particular repo? I don't have the rights and Cullen might be busy.


Function to manually trigger abort/pause uploading file

Is there a way that we can manually trigger abort/pause uploading file ?
I found an event handler processfileabort for abort event, but not sure if there's a way to trigger that ?
Please use Stack Overflow when:

You need help with integrating FilePond;
You are looking for information on how a feature works;
You have a question about a specific feature of FilePond;

https://stackoverflow.com/questions/tagged/filepond
Any issues opened for help requests will be closed to keep from clogging up the issue tracker.

Please use Stack Overflow when:
You need help with integrating FilePond;
You are looking for information on how a feature works;
You have a question about a specific feature of FilePond;


Unable to display the screen correctly

My local system is windows10, the development system is ubuntu22.04 in wsl2, I am using bullet2.88, freeglut3.0.0, glew2.1.0, swig4.0.0, the configuration is the same as the deepmimic paper environment, I use x11 in wsl2 Forwarding, windows uses VcXsrv to monitor. When I run the visualization program in the thesis, I can't display the graphics content correctly, but my code output is fine. After that, I ran the AppBasicExampleGui in the bullet example, and there was only a 10% chance that it could be displayed normally (tested 100 times). My opengl version is 3.1.6. I wonder if anyone encountered the same situation? Help me, I'm about to collapse!
Below is my output:
cd /home/peter/physic_playground ; /usr/bin/env /usr/bin/python3 /home/peter/.vscode-server/extensions/ms-python.python-2023.8.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher 36605 -- /home/peter/physic_playground/run/local_run_test_env_gui.py
2023-06-27 22:07:13.058228: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-06-27 22:07:14.102008: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
WARNING:tensorflow:From /home/peter/.local/lib/python3.10/site-packages/tensorflow/python/compat/v2_compat.py:107: disable_resource_variables (from tensorflow.python.ops.variable_scope) is deprecated and will be removed in a future version.
Instructions for updating:
non-resource variables are not supported in the long term
/home/peter/.local/lib/python3.10/site-packages/newton/model/network_blocks.py:54: UserWarning: tf.layers.flatten is deprecated and will be removed in a future version. Please use tf.keras.layers.Flatten instead.
h = tf.layers.flatten(X)
2023-06-27 22:07:16.678289: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:353] MLIR V1 optimization pass is not enabled
Renderer: D3D12 (Intel(R) UHD Graphics 630)
OpenGL version supported 4.1 (Compatibility Profile) Mesa 22.2.5-0ubuntu0.1~22.04.3
Compiling shader: data/shaders/Mesh_VS.glsl
Compiling shader: data/shaders/VertColor_PS.glsl
Compiling shader: data/shaders/FullScreenQuad_VS.glsl
Compiling shader: data/shaders/DownSample_PS.glsl
Compiling shader: data/shaders/Mesh_VS.glsl
Compiling shader: data/shaders/DownSample_PS.glsl
Loaded 1.283 seconds of motion data from data/motions/humanoid3d_spinkick.txt.
Agent Registry
Num Agents: 1
Agent 0: ct_pd
Compiling shader: data/shaders/Mesh_VS.glsl
Compiling shader: data/shaders/Depth_PS.glsl
Compiling shader: data/shaders/Mesh_VS.glsl
Compiling shader: data/shaders/Lighting_Lambert_PS.glsl
Loaded scene: Imitate
0.998900590229061
0.8293166566209201
0.6034301836506686
0.4551450902410313
0.38282293090748165

Ok, I've solved this problem. It looks like a problem with intelGraphics - windows DCH drivers. The solution can be to upgrade the driver, or add: GALLIUM_DRIVER=llvmpipe to the command line.
refer to:
https://github.com/microsoft/wslg/issues/654
https://github.com/microsoft/wslg/issues/334/


Azure.Communication.CallingServer referenced by the docs and the sample has been unlisted on NuGet

Both the sample and the docs reference the Azure.Communication.CallingServer NuGet package, however the package has been unlisted on NuGet and is no longer available.
https://www.nuget.org/packages/Azure.Communication.CallingServer
Could we please get any guidance if the package is still valid and why it has been unlisted?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: afd1a8d3-1b36-f3e4-b802-6368ba71a62a
Version Independent ID: 59d7b75c-5eb5-fdc8-cc02-549ab9492e34
Content: Azure Communication Services Call Recording API quickstart - An Azure Communication Services quickstart document
Content Source: articles/communication-services/quickstarts/voice-video-calling/call-recording-sample.md
Service: azure-communication-services
Sub-service: calling
GitHub Login: @ravithanneeru
Microsoft Alias: jken

@marcinburak Thank you for your feedback! We will review and update as appropriate.

The package is back and up on NuGet, I was able to use it in my code with success, thank you, I'm closing the issue :)


Tracking: Missing workflow in API

Since the introduction of the policy reasoner, various functions need to provide a workflow to the registry in order to retrieve data. The problem is that some interfaces cannot infer this information with the current API. Therefore, the API has to change. This is a tracking issue for the interfaces that still need to change.

[ ] brane-cli: download_result
[ ] brane-cli-c: vm_process
[ ] brane-cli: download_data

All of these should be fixed before we can create a 4.0.0 release, download_result needs to be fixed for the basic functionality of datasets to work again.

API -> brane-api?


URN without definition, with proposal

Two URNs have no definition. Here they are, with proposals for definition:
Lemma Pierius -  urn:cite:perseus:latlexent.lex6722.1 "adjective of belonging to or of Mount Pierus in Thessaly"
Lemma Pieris - urn:cite:perseus:latlexent.lex6723.1 "name for a female dweller of Mount Pierus"

Corrected in commit 021ffa0


Dungeon Siege II Broken World - Objects / Meshes wrong position.

Software information
Dungeon Siege 2 Broken World
System information

GPU: nVidia GTX 960
Driver: 435.27.02
Wine version: 4.18
DXVK version: #957 master (3deda2a0)

Apitrace file(s)
https://drive.google.com/file/d/1LKBPM9euB56nVmqYpbYAplCpx77OFgGs/view?usp=sharing
Log files
https://drive.google.com/file/d/1boUYmAV85Z4LsiHO7ZUPoJinIYYXQ76J/view?usp=sharing

Dungeon Siege II Broken World with d9vk renders all objects in the world (npc, rocks, grass, etc.) in wrong position. Moving main character or rotating camera all objects jumping all over the screen. Probably the problem is with calculation of transformations.
P.S. Wined3d renders everything fine except the performance is abysmal (30-40 fps) compared with d9vk (const 60 fps).
Few shots and video below shows the problem better.

Video example:
https://drive.google.com/file/d/11oiS28cxbRDZcTDMEld2aVEOTbfAwC-G/view?usp=sharing

Windows (d3d9):

Wine (d9vk):

Well, the world is not broken anymore! It can be closed.
Tested with DXVK 1168.

Yep, fixed in master.


Add game dino Chrome version

PR Description 📜
Game added which is same as of chrome dino game
Fixes #1700

Mark the task you have completed ✅

[x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ x] I have performed a self-review of my own code or work.
[x ] I have commented my code, particularly in hard-to-understand areas.
[x ] My changes generates no new warnings.
[ x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ x] I have added screenshot for website preview in assets/images
[x ] I have added entries for my game in main README.md
[x ] I have added README.md in my folder
[x ] I have added working video of the game in README.md (optional)
[ x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Swapnil-2503 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit please see this and merge pr

we already have this game on GameZone 👀 !!

Thank you  @Swapnil-2503 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit please can you see again i know there is game dino runner allready but that is different as this game based on chromes dino game and also the visuals are different it's totally different


Deleted Dropbox files on Colab

Colab code uses wget to download the model files, but these files are returning a 404.
!wget https://www.dropbox.com/s/a7ftqt9rmdpkzou/styleganinv_ffhq256_encoder.pth?dl=0 -O $MODEL_DIR/styleganinv_ffhq256_encoder.pth  --quiet
!wget https://www.dropbox.com/s/i0tj94zhpgqsxso/styleganinv_ffhq256_generator.pth?dl=0 -O $MODEL_DIR/styleganinv_ffhq256_generator.pth  --quiet
!wget https://www.dropbox.com/s/ll4gal1iubyowpk/vgg16.pth?dl=0 -O $MODEL_DIR/vgg16.pth  --quiet

the links are updated. previous ones are blocked by dropbox due to too much access.


Log4jXmlEvent - Improve performance (CPU & memory)

Log4jXmlEvent - Replaced Regex-search with XmlConvert.IsXmlChar  and reduced memory allocations

This change is

Current coverage is 82% (diff: 73%)

Merging #1829 into master will increase coverage by <1%

@@             master      #1829   diff @@
==========================================
  Files           276        276
  Lines         18373      18395    +22
  Methods        2848       2848
  Messages          0          0
  Branches       2107       2115     +8
==========================================
+ Hits          15003      15034    +31
+ Misses         2890       2881     -9
  Partials        480        480

Powered by Codecov. Last update 68839ac...969a0e0

Writing 1.000.000 messages of 16 bytes:

Test Name
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Mem (MB)

Old Version
22.483
44.476
6
446
1993
24.062
42,711

Test Name
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Mem (MB)

New Version
16.748
59.707
16
464
1828
18.234
50,359

To be honest, I don't like the repetitive check of sb ==null from the readability viewpoint.
I have another proposal, which is clearer IMO
            for (int i = 0; i < text.Length; ++i)
            {
                char ch = text[i];
                if (!XmlConvert.IsXmlChar(ch))
                {
                    //first invalid, clean whole string
                    text = CleanValue(text, i);
                    break;
                }
            }

        private static string CleanValue(string text, int firstInvalidIndex)
        {
            var sb = new StringBuilder(text.Length);
            //init with valid values
            sb.Append(text, 0, firstInvalidIndex);
            for (int i = firstInvalidIndex; i < text.Length; ++i) //not sure if this should be firstInvalidIndex+1
            {
                char ch = text[i];
                if (XmlConvert.IsXmlChar(ch))
                {
                    sb.Append(ch);
                }
            }
            return sb.ToString();
        }

Have no opinion about this thing. The invalid-xml-char is a rare case, so whatever works.
Anyways split into two methods.

Thanks!


Module not found: Can't resolve 'tslib'

Hi! I just followed the install instructions in the readme, then I got this error:
./node_modules/react-locomotive-scroll/module/LocomotiveScroll.context.js:4:0
Module not found: Can't resolve 'tslib'
null

Any idea why this happens, and how I can make it work?

Hi! I just followed the install instructions in the readme, then I got this error:
./node_modules/react-locomotive-scroll/module/LocomotiveScroll.context.js:4:0
Module not found: Can't resolve 'tslib'
null

Any idea why this happens, and how I can make it work?

Same issue :)

Not exactly the same issue, but I fixed my error by installing tslib. Please give this a try:
"npm install --save tslib"


Mo' Creatures - some entities not rendering

This is due to MoCRenderSnake trying to call entitysnake.isInsideOfMaterial(Material.WATER), which causes an exception with FakeClientWorld in JER. This is most likely going to require fixing it directly in JER and until then the snake will not be included in loot drops.

This also happens with a few other entities, like turtles and medium fish.


Create a whitelist of bulbs

Now that the newer LIFX bulbs are HomeKit enabled, it may be more convenient to list the bulbs you want to control via Homebridge instead of creating a list of all the ones you don't. This provides both  whitelist (enabledDevices) and blacklist (ignoredDevices) functionality.

Thanks, I have updated accordingly. This is my first node.js pull request, so the feedback is welcome! :)

Ping @devbobo. Any chance of a fresh review?

It would be awesome to see this being added to an update


Security - default_wallet encryption

The default_wallet file needs to be encrypted in order to prevent just anyone or any app on the device from gaining access to the private keys.

Done in the wallet-encryption branch (https://github.com/lbryio/lbry-android/tree/wallet-encryption). Waiting for the corresponding 'lbry and lbryum pull requests to be merged into master.


[jjbb]: folder description is required

What does this pull request do?
Fixes the issues with the missing description field in the folder items.
Related issues
closes #ISSUE

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #865 opened]

Start Time: 2020-06-18T14:24:05.685+0000

Duration: 29 min 14 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
9291

Skipped
7233

Total
16524


Heatmap color shades for negative numbers

Codepen
https://codepen.io/anon/pen/ZNeEgx

What is the behavior you expect?
With positive numbers, the higher the number, the darker the shade. 5 is darker than 1 for example (which is fine, no problems there).
With negative numbers however, if we're being logically consistent, you'd expect the shade to get lighter the closer to zero the number is. For example -1 should be lighter than -5.
What is happening instead?
Currently with negative numbers, the shade is darker the closer to zero you get. Another example of what I'd expect here: (where darker reds mean larger losses, darker greens mean larger gains)

Sure.
Added a new property plotOptions.heatmap.reverseNegativeShade which when turned on will reverse the shades for negatives but keep the positive shades as it is now.
The change will be released in<EMAIL_ADDRESS>

@junedchhipa
reverseNegativeShade does help. However, the color is set at the 0 for negative values, as the value become closer to negative infinite, the color become very dark to a extent that people don't expect. Ideally, the color configured for negative values, after reverseNegativeShade is true, should set for the negative infinite value and become lighter for number close to zero. This should provide same scale of darkness as green that is set. Please fix this, thanks!


error_payload/1 does not match Ecto.Changeset case as suggested in Docs

Hello,
I am having trouble using the error_payload/1 function in my resolvers. The error is a match error when I pass an Ecto.Changeset as argument. I am willing to work on this and submit a PR, but, I wanted to open a discussion about the approach. Should I update the docs or should I implement the case function for Ecto.Changeset?
The line that says that error_payload can take an Ecto.Changeset: here
The implementation: here

Just ran into this issue as well. Doesn't seem to work at all with changesets which is why I wanted to use kronky in the first place 👀


make the live stream header popup not intractable if is not visible

You seem to be able to interact with the empty space over the banner
where the live stream would be if visible. So I have made it so it’s
visibility property is hidden until the animation for the fade in
starts.

I have signed the Contributor License Agreement.

Has been resolved in the latest commit with pointer events.


Select a parent folder

Hi,
First of all I want to say I really love your work and it helps me a lot to keep things organized!
It is not an issue itself but a suggestion how you might improve this plugin.
The idea is to allow user to select a parent folder for symbols user wants to place.
So if the symbol structure is
Symbols /
a- /
buttons / ...
icons / ...
It would be cool to have an ability to place only icons or only buttons.
Thanks!

@archgear Thank you for the feedback. I just published an update which allows you to create instances for a page in a library, which is a step in the right direction. I will consider even more granularity like you suggest.


Support specifying a function to choose the url

This will allow dynamically choosing the url at call time.
My use case for this is that my backend is AWS lambda, where each "telefunc.ts" file being bundled into a separate lambda and hosted in cloud front at different urls.
This is an early PR to gain feedback before I add more tests and cleanup some more, I'm not sure if this is the best approach.  Happy to change it if you have suggestions.
Alternatively, I'd be happy to implement #60 which would would support the same behavior.

Why not 👍.
Although I'm reluctant to pass the whole CallContext because it's internal. What information do you need? I guess only the telefunction path and name?
I may have an alternative proposal.

yes, I'd only need the name, but probably should pass the path as well for future users. I'll go ahead and clean it up, document and get specs passing. Thanks for glancing at it

How about this instead:
// TodoList.telefunc.ts

// The next version of Telefunc will require each telefunction to be wrapped with telefunction()
import { telefunction } from 'telefunc'

export const onTodoTextUpdate = telefunction(
  (id: string, text: string) => {
     await Todo.update(id, { text })
  },
  {
    telefuncUrl: 'https://example.com/_telefunc'
  }
 )

Yes, I think that would work well for my use case.  I'm assuming the code would run server-side and have access to env variables or able to read a JSON file with the mappings.
Should we hold off on this until the change lands? I can redo the work then if you'd like

I'm assuming the code would run server-side and have access to env variables or able to read a JSON file with the mappings.

Yes, since it's a .telefunc.js file.

Should we hold off on this until the change lands? I can redo the work then if you'd like

Yes that'd be the best.
Also, if you're up for it: PR welcome to implement that little redesign.
Closing in the meantime.


Add a stack parameter to opt out of anonymized data collection

Is your feature request related to a problem? Please describe.
Currently, if I want to opt-out of anonymized data collection, I need to edit the template file and make changes to select "No" for sending anonymized data to AWS.
When updating the template to a new version, I need to remember to edit the template again. This brings about more chances to forget to edit the file, or making mistakes while updating the template file.
Describe the feature you'd like
I would like to be able to opt out of anonymized data collection by setting a parameter in the stack. In this way, I don't need to edit the template file anymore and just provide the parameter in the stack creation/update process.
Even a better solution is to change the default behavior. This means by default there anonymized data collection is set to "No" and only those who wish to enable it can do so by setting a parameter.
Additional context
Opt-out guides: Anonymized data collection
https://docs.aws.amazon.com/solutions/latest/landing-zone-accelerator-on-aws/reference.html

Hi @bakharzy,
I agree with you that something like a CF parameter for user to be able select and not bury in documentation and code editing in order to opt in or out of sending data should have been there, however making it default No wont encourage customers to feed data back to AWS so a default position of Yes and select to opt-out is acceptable imo. I have raised a PR and hope its accepted.
Would like to hear AWS's feedback on this.


AppInsights: PII is logged even if logPersonalInformation is false

Version
4.11.0
Describe the bug
BBF always logs the user's text.
To Reproduce

Have bot with AppInsights integration. Configure the bot to not log the user's personal information as per doc https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-telemetry?view=azure-bot-service-4.0&tabs=csharp.
Talk to the bot
Look into any event that logs the Recognizer telemetry, e.g. ValueRecognizerResult
Check the customDimensions, you will find "Text" property there. Example:

{"conversationId":"0a9d58c0-3301-11eb-bf90-2102e829151f|livechat","activityType":"message","channelId":"emulator","activityId":"2d360170-3301-11eb-98d6-891267dfc0ed","TopIntentScore":"Microsoft.Bot.Builder.IntentScore","Entities":"{\r\n "$instance": {\r\n "Ordinal": [\r\n {\r\n "Name": "Ordinal",\r\n "Value": 2,\r\n "Start": 4,\r\n "End": 9,\r\n "Text": "second"\r\n }\r\n ]\r\n }\r\n}","TopIntent":"test2","Intents":"{"test2":{"score":0.989161491394043}}","Text":"the second test"}
Expected behavior
User's text should not be logged if logPersonalInformation == false
Additional context
The issue is that the LogPersonalInformation property is in TelemetryLoggerMiddleware. It should be a property in IBotTelemetryClient (it should be virtual on BotTelemetryClient). FillRecognizerResultTelemetryProperties method should check the property on the logger and it shouldn't log text or alteredtext if LogPersonalInformation  == false.
Also, we need to do additional analysis to ensure that we don't log PII in recognizerResult.Properties object.

This needs to be evaluated across all language implementations to ensure the text is not logged.

Thanks for reporting! I'll start working on this next week after the weekend!

@Zerryth FYI - the LUIS adaptive recognizer already does this.. We have a method for logging the result which can be overridden for this purpose. See https://github.com/microsoft/botbuilder-dotnet/blob/3af7b7b53255b9327de24dcb994dbc7a64bc1725/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisAdaptiveRecognizer.cs#L181-L230

@Robulane I'm having issues reproducing what you experienced--maybe it's specific to ValueRecognizerResult--is this adaptive? Maybe adaptive issue...

However I just grabbed sample 21.corebot-app-insights, and didn't see any PII logged with default setup.

LogPII False - Application Insights - customDimensions

Compared to explicitly to log PII as true.
Startup.cs
            services.AddSingleton<TelemetryLoggerMiddleware>(sp =>
            {
                var telemetryClient = sp.GetService<IBotTelemetryClient>();
                return new TelemetryLoggerMiddleware(telemetryClient, logPersonalInformation: true);
            });

LogPII True - Application Insights - customDimensions
* ![image](https://user-images.githubusercontent.com/35248895/101536759-46535c80-394f-11eb-8c5d-7746cec74696.png)

I guess could you provide more information on how you set up the bot, so I can get the same buggy behavior?

@Zerryth, yes, TelemetryLoggerMiddleware handles PII as expected. This bug is about the fact that there other places in BBF that log PII data. Examples that I found:

All recognizer results (ValueRecognizerResult, RegexRecognizerResult, RecognizerSetResult, etc.)
GeneratorResult can log text that may contain PII data in "text" field

Gotcha. I see what you mean now, testing out with RegexRecognizerResult. No bueno.

Update: still working on this.
I've spoken with Eric regarding best practices/design issue that arises around

There being a lot of classes that derive from Recognizer
Implementing the LogPersonalInformation
LogPersonalInformation wanting to be a BoolExpression (which needs dependency on AdaptiveExpressions) for adaptive bits, but only a bool for non-adaptive

It goes deeper, however Eric said maybe we should discuss best practices with Gabo, since current solution I can think of isn't that pretty


Image of final demo?

Would be great to see an image in the beginning of what the final demo looks like.

Issue addressed


AppImage Fails to start

The app image fails to Launch
Process

Download AppImage
mv Download/Station-x86_64.AppImage /opt
chmod +x Station-x86_64.AppImage
./Station-x86_64.AppImage

My System

Fedora 35 (Workstation)
Kernel: 5.14.16-301.fc35.x86_64
Gnome version 41.1
Running X11

version 11.0
X.Org version: 1.20.11

Error When running App Image
./Station-x86_64.AppImage
(electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead.
Fontconfig warning: "/usr/share/fontconfig/conf.avail/05-reset-dirs-sample.conf", line 6: unknown element "reset-dirs"
[23040:1108/115844.469867:FATAL:gpu_data_manager_impl_private.cc(986)] The display compositor is frequently crashing. Goodbye.
[1]    23040 trace trap (core dumped)  ./Station-x86_64.AppImage

Hello,
I only got the first message on Linux Mint 19.3 but no launch either.
Thanks

Same problem except that it was installed/launched with appimagelauncher.
I'm on the same OS, also Gnome 41 and X11.
./Station-x86_64_7c0df140ea727d18b16a1bff66cc3da2.AppImage /usr/bin/AppImageLauncher: /lib64/libcurl.so.4: no version information available (required by /usr/bin/../lib/x86_64-linux-gnu/appimagelauncher/libappimageupdate.so) (electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead. Fontconfig warning: "/usr/share/fontconfig/conf.avail/05-reset-dirs-sample.conf", line 6: unknown element "reset-dirs" [4313:1227/083229.800117:FATAL:gpu_data_manager_impl_private.cc(986)] The display compositor is frequently crashing. Goodbye.

Hi, I was able to get it running using
chmod a+x ./Station-x86_64.AppImage
sudo ./Station_x86_64.AppImage --install --no-sandbox

However, I'm new to linux and do not understand how AppImages work. I used these commands in my Downloads folder. Output seemed to contain errors that look like this:
[09:12:22.910] [info] File:<PHONE_NUMBER>5500-add-notification-pref.js.map does not match pattern: /\.[jt]s$/

for basically every file that this application is build from.
When running without sudo, the error output looked like this:
$ ./Station-x86_64.AppImage
(electron) 'getName function' is deprecated and will be removed. Please use 'name property' instead.
Fontconfig warning: "/usr/share/fontconfig/conf.avail/05-reset-dirs-sample.conf", line 6: unknown element "reset-dirs"
[32075:0417/092544.349038:FATAL:gpu_data_manager_impl_private.cc(986)] The display compositor is frequently crashing. Goodbye.
Trace/breakpoint trap (core dumped)

Also, I was unable to build from the source code, because of node-gyp error that's caused by electron 17 and up.
My system:
Linux 5.15.32-1-MANJARO


Implement Submodules

see R2API for submodule implementation. Facilitates dynamic loading of dependant libraries which increases robustness on patchdays, and negates instant, community-wide failure due to 1 single change.

This may be hard /annoying to do now that we released a version of JVL on stores, meaning that old mods will have to switch to use the submodules instead


Unable to call the token endpoint with client_assertion_type jwt-bearer and grant type

Hi All
When trying to call the token endpoint by using the refresh token grant type and client_assertion_type urn:ietf:params:oauth:client-assertion-type:jwt-bearer. The system prints invalid_request', description='Missing parameters: client_secret client_id
In this request I am not passing the Authorization: Basic <Base64Encoded(Client_Id:Client_Secret)>. When I invoke the below sample with the necessary values
steps i followed to get  the refresh token
1.use the client credentials grant type and get an access token
2.use the access token and get an AccountRequestId
3.Using the AccountRequestId in the signed request object call the Authorize Endpoint and get an access token and a refresh token
4.pass the refresh token to the below sample
curl -k -d "grant_type=refresh_token&refresh_token=&scope=am_application_scope accounts&client_assertion_type=urn%3Aietf%3Aparams%3Aoauth%3Aclient-assertion-type%3Ajwt-bearer&client_assertion=" -H "Content-Type: application/x-www-form-urlencoded;charset=UTF-8"  -H "Content-Type: application/x-www-form-urlencoded" https://<IP_ADDRESS>:8243/TokenAPI/v1.0.0/
Logs and identity.xml
identity.zip

identity.zip

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


docker compose

Hello,
You might want to update your docker-compose path to docker compose in the relevant files ?
I changed it manually in<EMAIL_ADDRESS>to overcome this issue
16:01 $ devcontainer up --workspace-folder .
[2 ms] @devcontainers/cli 0.47.0. Node.js v16.19.1. linux 5.4.0-152-generic x64.
[588 ms] Start: Run: docker-compose -f /home/hum/git/some/path/.devcontainer/docker-compose.yml config
[1236 ms]
[1236 ms] Version in "/home/hum/git/some/path/.devcontainer/docker-compose.yml" is unsupported. You might be seeing this error because you're using the wrong Compose file version. Either specify a supported version (e.g "2.2" or "3.3") and place your service definitions under the `services` key, or omit the `version` key and place your service definitions at the root of the file to use version 1.
For more on the Compose file format versions, see https://docs.docker.com/compose/compose-file/

[1236 ms] Exit code 1
Error: Command failed: docker-compose -f /home/hum/git/some/path/.devcontainer/docker-compose.yml config
    at Sl (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2005:889)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async kte (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:1972:1370)
    at async _te (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:1954:3170)
    at async Qte (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2024:3833)
    at async Kf (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2024:4775)
    at async xne (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2156:12125)
    at async wne (/usr/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:2156:11866)
{"outcome":"error","message":"Command failed: docker-compose -f /home/hum/git/some/path/.devcontainer/docker-compose.yml config","description":"An error occurred retrieving the Docker Compose configuration."}

You can uninstall docker-compose, we will automatically use docker compose then.


Plutarch staging produces build errors

Existing nix setup (with the applyPlutarchDep jazz) that used to build Plutarch fine, now fails with weird specialization warnings and type family reduction errors. Check https://github.com/mlabs-haskell/ply/commit/29492e02e274e7cf7e808d1e1722ebd8586c3bf1 - the commit updates plutarch staging to the commit a9bd6f240f306bdacaa8d5d7e749ff6550c78c78. It was previously using a9bd6f240f306bdacaa8d5d7e749ff6550c78c78 (which still builds fine).
In between a sea of "missed specialization warnings", there's this error culprit:
Plutarch/Internal/Newtype.hs:28:43: error:
    • Could not deduce: (Plutarch.Internal.TypeFamily.ToPType2
                           (Generics.SOP.GGP.ToSumCode
                              (GHC.Generics.Rep
                                 (a (ghc-prim-0.8.0:GHC.Types.Any @Plutarch.Internal.S)))
                              ('[] @[Type])) :: [[PType]])
                        ghc-prim-0.8.0:GHC.Prim.~# ((':)
                                                      @[PType]
                                                      ((':)
                                                         @PType
                                                         (GetPNewtype'
                                                            (Plutarch.Internal.TypeFamily.ToPType2
                                                               (Generics.SOP.GGP.ToSumCode
                                                                  (GHC.Generics.Rep
                                                                     (a (ghc-prim-0.8.0:GHC.Types.Any
                                                                           @Plutarch.Internal.S)))
                                                                  ('[] @[Type]))))
                                                         ('[] @PType))
                                                      xs0 :: [[PType]])
      from the context: (Plutarch.Internal.PlutusType.DerivePlutusType a,
                         (Plutarch.Internal.PlutusType.DPTStrat a :: Type)
                         ~ (PlutusTypeNewtype :: Type))
        bound by the type signature for:
                   derivedPMatch :: forall (a :: PType) (s :: Plutarch.Internal.S)
                                           (b :: PType).
                                    (Plutarch.Internal.PlutusType.DerivePlutusType a,
                                     (Plutarch.Internal.PlutusType.DPTStrat a :: Type)
                                     ~ (PlutusTypeNewtype :: Type)) =>
                                    Plutarch.Internal.Term s (DerivedPInner PlutusTypeNewtype a)
                                    -> (a s -> Plutarch.Internal.Term s b)
                                    -> Plutarch.Internal.Term s b
        at Plutarch/Internal/Newtype.hs:28:3-15
      Expected: SOP.NS
                  @[PType] (SOP.NP @PType (Plutarch.Internal.Term s)) (PCode a)
        Actual: SOP.NS
                  @[PType]
                  (SOP.NP @PType (Plutarch.Internal.Term s))
                  ((':)
                     @[PType]
                     ((':)
                        @PType
                        (GetPNewtype'
                           (Plutarch.Internal.TypeFamily.ToPType2
                              (Generics.SOP.GGP.ToSumCode
                                 (GHC.Generics.Rep
                                    (a (ghc-prim-0.8.0:GHC.Types.Any @Plutarch.Internal.S)))
                                 ('[] @[Type]))))
                        ('[] @PType))
                     xs0)
      The type variable ‘xs0’ is ambiguous
    • In the second argument of ‘($)’, namely
        ‘SOP.Z $ x SOP.:* SOP.Nil’
      In the second argument of ‘($)’, namely
        ‘SOP.SOP $ SOP.Z $ x SOP.:* SOP.Nil’
      In the first argument of ‘f’, namely
        ‘(gpto $ SOP.SOP $ SOP.Z $ x SOP.:* SOP.Nil)’
    • Relevant bindings include
        f :: a s -> Plutarch.Internal.Term s b
          (bound at Plutarch/Internal/Newtype.hs:28:19)
        x :: Plutarch.Internal.Term s (DerivedPInner PlutusTypeNewtype a)
          (bound at Plutarch/Internal/Newtype.hs:28:17)
        derivedPMatch :: Plutarch.Internal.Term
                           s (DerivedPInner PlutusTypeNewtype a)
                         -> (a s -> Plutarch.Internal.Term s b)
                         -> Plutarch.Internal.Term s b
          (bound at Plutarch/Internal/Newtype.hs:28:3)
   |
28 |   derivedPMatch x f = f (gpto $ SOP.SOP $ SOP.Z $ x SOP.:* SOP.Nil)

This error also happens when trying to build on ghc 8.10.7 iirc.
Are you building against ghc 9.2.3?

This error also happens when trying to build on ghc 8.10.7 iirc. Are you building against ghc 9.2.3?

GHC 9.2.1 actually, I didn't change the flake

i think we have a GHC bug boys
I think it's still that PForall business. it's extremely flakey and it also didn't work on ghc 8.10.7. It apparently only works on GHC 9.2.3.

According to @MangoIV (thanks!), it seems to be related to https://gitlab.haskell.org/ghc/ghc/-/issues/21515.
I think we can close this?


refactor(feature_flags): add from future import annotations

Issue number: #4965
Summary
Changes
Add from __future__ import annotations to feature_flags package
User experience
Discussed in #4607
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[X] Meet tenets criteria
[X] I have performed a self-review of this change
[X] Changes have been tested
[ ] Changes are documented
[X] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Fixed

Fixed

Thanks! This would fail in 3.9 as well, we don't have much to do! 😄


Fix pool and oracle health metrics

Close #307
Close #308
Determine oracle health and active oracles count in the pool based on the last oracle's box height rather than pool box height.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 20 (0.0%)  changed or added relevant lines in 3 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 54.448%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/metrics.rs
0
2
0.0%

core/src/api.rs
0
4
0.0%

core/src/monitor.rs
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

core/src/api.rs
2
0%

core/src/monitor.rs
3
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
2093

Relevant Lines:
3844

💛  - Coveralls


Add latency threshold to load test for node local dns measurement

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds option to parametrize node local dns latency threshold in load test.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/lgtm
/approve

/lgtm
/approve